1 2012-04-01 Eli Zaretskii <eliz@gnu.org>
3 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4 instead of alloca. (Bug#11138)
6 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
8 * w32menu.c (is_simple_dialog): Properly check lisp types.
11 2012-03-31 Eli Zaretskii <eliz@gnu.org>
13 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
14 position we get to after a call to move_it_to fails the
15 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
16 only if we wind up in a string from display property. (Bug#11063)
18 * window.c (Fdelete_other_windows_internal): Invalidate the row
19 and column information about mouse highlight, so that redisplay
20 restores it after reallocating the glyph matrices. (Bug#7464)
22 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
23 string comes from a `display' text property, use the buffer
24 position of that property as if we actually saw that position in
26 (move_it_by_lines): Remove the assertion that
27 "it->current_x == 0 && it->hpos == 0" which can be legitimately
28 violated when there's a before-string at the beginning of a line.
31 2012-03-30 Eli Zaretskii <eliz@gnu.org>
33 * xdisp.c (append_space_for_newline): If the default face was
34 remapped, use the remapped face for the appended newline.
35 (extend_face_to_end_of_line): Use the remapped default face for
36 extending the face to the end of the line.
37 (display_line): Call extend_face_to_end_of_line when the default
38 face was remapped. (Bug#11068)
40 2012-03-29 Eli Zaretskii <eliz@gnu.org>
42 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
44 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
46 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
48 2012-03-27 Glenn Morris <rgm@gnu.org>
50 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
53 2012-03-26 Kenichi Handa <handa@m17n.org>
55 * dispextern.h (struct glyph): Fix previous change. Change the
56 bit length of glyphless.ch to 25 (Bug#11082).
58 2012-03-26 Chong Yidong <cyd@gnu.org>
60 * keyboard.c (Vselection_inhibit_update_commands): New variable.
61 (command_loop_1): Use it; inhibit selection update for
62 handle-select-window too (Bug#8996).
64 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
66 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
68 2012-03-25 Kenichi Handa <handa@m17n.org>
70 * dispextern.h (struct glyph): Change the bit length of
71 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
73 2012-03-24 Eli Zaretskii <eliz@gnu.org>
75 * s/ms-w32.h (tzname): Include time.h before redirecting to
76 _tzname. Fixes the MSVC build. (Bug#9960)
78 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
80 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
83 * xterm.c (XTread_socket): Only modify handling_signal if
84 !SYNC_INPUT. (Bug#11080)
86 2012-03-23 Eli Zaretskii <eliz@gnu.org>
88 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
89 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
90 when fetching a multibyte character consumes more bytes than
91 CHAR_BYTES returns, due to unification of CJK characters in
92 string_char. (Bug#11073)
94 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
96 * process.c (wait_reading_process_output): Handle pty disconnect
97 by refraining from sending oneself a SIGCHLD (bug#10933).
99 2012-03-22 Chong Yidong <cyd@gnu.org>
101 * dispextern.h (struct it): New member string_from_prefix_prop_p.
103 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
104 Mark string as coming from a prefix property.
105 (handle_face_prop): Use default face for prefix strings (Bug#4281).
106 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
108 2012-03-21 Chong Yidong <cyd@gnu.org>
110 * xfaces.c (Vface_remapping_alist): Doc fix.
112 2012-03-20 Eli Zaretskii <eliz@gnu.org>
114 * w32proc.c (Fw32_set_console_codepage)
115 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
118 2012-03-20 Chong Yidong <cyd@gnu.org>
120 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
121 to reflect default non-nil value of redisplay-dont-pause.
123 2012-03-19 Kenichi Handa <handa@m17n.org>
125 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
126 it fit in a valid range (Bug#11003).
128 2012-03-18 Eli Zaretskii <eliz@gnu.org>
130 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
131 that is not from display property, accept the row as a "cursor
132 row" if one of the string's character has a non-nil `cursor'
133 property. Fixes cursor positioning when there are newlines in
134 overlay strings, e.g. in icomplete.el. (Bug#11035)
136 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
138 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
140 2012-03-12 Chong Yidong <cyd@gnu.org>
142 * eval.c (inhibit_lisp_code): Rename from
143 inhibit_window_configuration_change_hook; move from window.c.
145 * xfns.c (unwind_create_frame_1, Fx_create_frame):
146 * window.c (run_window_configuration_change_hook)
147 (syms_of_window): Callers changed.
149 2012-03-11 Chong Yidong <cyd@gnu.org>
151 * keymap.c (Fkey_description): Doc fix (Bug#9700).
153 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
155 2012-03-10 Chong Yidong <cyd@gnu.org>
157 * frame.c (other_visible_frames): Don't assume the selected frame
158 is visible (Bug#10955).
160 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
162 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
164 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
166 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
167 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
170 2012-03-03 Glenn Morris <rgm@gnu.org>
172 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
174 2012-03-02 Eli Zaretskii <eliz@gnu.org>
176 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
177 position past the first glyph_row that ends at ZV. (Bug#10902)
178 (redisplay_window, next_element_from_string): Fix typos in
180 (redisplay_window): Pass to move_it_vertically the margin in
181 pixels, not in screen lines.
183 2012-03-02 Glenn Morris <rgm@gnu.org>
185 * buffer.c (buffer-list-update-hook): Doc fix.
187 2012-02-29 Eli Zaretskii <eliz@gnu.org>
189 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
190 push_it before setting up the iterator for the first overlay
191 string, even if we have an empty string loaded.
192 (next_overlay_string): If there's an empty string on the iterator
193 stack, pop the stack. (Bug#10903)
195 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
197 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
198 Suggested by Stefan Monnier in
199 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
200 * alloc.c (widen_to_Lisp_Object): New static function.
201 (mark_memory): Also mark Lisp_Objects by fetching pointer words
202 and widening them to Lisp_Objects. This would work even if
203 USE_LSB_TAG is defined and wide integers are used, which might
204 happen in a future version of Emacs.
206 2012-02-25 Chong Yidong <cyd@gnu.org>
208 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
211 * xselect.c (Fx_selection_exists_p): Doc fix.
212 (x_clipboard_manager_save_all): Print an informative message
213 before saving to clipboard manager.
215 2012-02-24 Chong Yidong <cyd@gnu.org>
217 * keyboard.c (process_special_events): Handle all X selection
218 requests in kbd_buffer, not just the next one (Bug#8869).
220 2012-02-23 Chong Yidong <cyd@gnu.org>
222 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
223 call when setting menu-bar-lines and tool-bar-lines parameters.
224 (unwind_create_frame_1): New helper function.
226 * window.c (inhibit_window_configuration_change_hook): New var.
227 (run_window_configuration_change_hook): Obey it.
228 (syms_of_window): Initialize it.
230 2012-02-22 Chong Yidong <cyd@gnu.org>
232 * xterm.c (x_draw_image_relief): Add missing type check for
233 Vtool_bar_button_margin (Bug#10743).
235 2012-02-21 Chong Yidong <cyd@gnu.org>
237 * fileio.c (Vfile_name_handler_alist): Doc fix.
239 * buffer.c (Fget_file_buffer): Protect against invalid file
240 handler return value.
242 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
244 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
245 when computing $valmask.
247 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
248 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
249 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
250 It's useless in that case, and it can cause problems on hosts
251 that allocate halves of EMACS_INT values separately.
252 Reported by Dan Horák. Diagnosed by Andreas Schwab in
253 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
254 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
255 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
256 it avoids undefined behavior on hosts where shifting right by more
257 than the word width has undefined behavior.
259 2012-02-19 Chong Yidong <cyd@gnu.org>
261 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
262 (Funhandled_file_name_directory, Ffile_name_as_directory)
263 (Fdirectory_file_name, Fexpand_file_name)
264 (Fsubstitute_in_file_name): Protect against invalid file handler
265 return values (Bug#10845).
267 2012-02-18 Eli Zaretskii <eliz@gnu.org>
269 * .gdbinit (pitx): Fix incorrect references to fields of the
272 2012-02-17 Chong Yidong <cyd@gnu.org>
274 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
276 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
278 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
279 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
281 2012-02-15 Chong Yidong <cyd@gnu.org>
283 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
284 marked as special. Also, starting docstrings with * is obsolete.
286 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
288 * gnutls.c (emacs_gnutls_write): Fix last change.
290 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
292 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
295 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
297 * keymap.c (Fsingle_key_description): Handle char ranges.
299 2012-02-12 Chong Yidong <cyd@gnu.org>
301 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
302 as that creates a dangerous corner case.
304 * window.c (Fdelete_window_internal): Invalidate the mouse
305 highlight (Bug#9904).
307 2012-02-12 Glenn Morris <rgm@gnu.org>
309 * xselect.c (Fx_own_selection_internal)
310 (Fx_get_selection_internal, Fx_disown_selection_internal)
311 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
312 * nsselect.m (Fx_own_selection_internal)
313 (Fx_disown_selection_internal, Fx_selection_exists_p)
314 (Fx_selection_owner_p, Fx_get_selection_internal):
315 Sync docs and argument specs with the xselect.c versions.
317 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
319 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
321 2012-02-11 Eli Zaretskii <eliz@gnu.org>
323 * w32select.c (Fx_selection_exists_p): Sync doc string and
324 argument list with xselect.c. (Bug#10783)
326 * w16select.c (Fx_selection_exists_p): Sync doc string and
327 argument list with xselect.c. (Bug#10783)
329 2012-02-10 Glenn Morris <rgm@gnu.org>
331 * fns.c (Fsecure_hash): Doc fix.
333 2012-02-09 Kenichi Handa <handa@m17n.org>
335 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
337 2012-02-07 Chong Yidong <cyd@gnu.org>
339 * buffer.c (Fbuffer_local_variables)
340 (buffer_lisp_local_variables): Handle unbound vars correctly;
341 don't let Qunbound leak into Lisp.
343 2012-02-07 Glenn Morris <rgm@gnu.org>
345 * image.c (Fimagemagick_types): Doc fix.
347 * image.c (imagemagick-render-type): Change it from a lisp object
348 to an integer. Move the doc here from the lisp manual.
349 Treat all values not equal to 0 the same.
351 2012-02-06 Chong Yidong <cyd@gnu.org>
353 * doc.c (store_function_docstring): Avoid applying docstring of
354 alias to base function (Bug#2603).
356 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
358 * .gdbinit (pp1, pv1): Remove redundant defines.
361 2012-02-04 Chong Yidong <cyd@gnu.org>
363 * nsterm.m: Declare a global (Bug#10694).
365 2012-02-04 Eli Zaretskii <eliz@gnu.org>
367 * w32.c (get_emacs_configuration_options):
368 Include --enable-checking, if specified, in the return value.
370 2012-02-04 Martin Rudalics <rudalics@gmx.at>
372 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
373 after rounding frame sizes. (Bug#9723)
375 2012-02-04 Eli Zaretskii <eliz@gnu.org>
377 * keyboard.c (adjust_point_for_property): Don't position point
378 before BEGV. (Bug#10696)
380 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
382 Handle overflow when computing char display width (Bug#9496).
383 * character.c (char_width): Return EMACS_INT, not int.
384 (char_width, c_string_width): Check for overflow when
385 computing the width; this is possible now that individual
386 characters can have unbounded width. Problem introduced
387 by merge from Emacs 23 on 2012-01-19.
389 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
391 * dbusbind.c (Fdbus_register_method): Mention the return value
392 :ignore in the docstring.
394 2012-02-02 Glenn Morris <rgm@gnu.org>
396 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
398 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
399 Unconditionally set to t. (Bug#10673)
400 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
401 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
402 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
404 2012-02-02 Kenichi Handa <handa@m17n.org>
406 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
407 0, do not call append_composite_glyph.
409 2012-02-02 Kenichi Handa <handa@m17n.org>
411 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
413 (x_produce_glyphs): If the component of a composition is a null
414 string, set it->pixel_width to 1 to avoid zero-width glyph.
416 2012-02-01 Eli Zaretskii <eliz@gnu.org>
418 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
419 first 2 arguments are identical. This makes inserting large
420 output from a subprocess an order of magnitude faster on
421 MS-Windows, where all sbrk'ed memory is always contiguous.
423 2012-01-31 Glenn Morris <rgm@gnu.org>
425 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
426 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
427 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
429 2012-01-29 Glenn Morris <rgm@gnu.org>
431 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
433 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
435 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
437 2012-01-28 Chong Yidong <cyd@gnu.org>
439 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
441 2012-01-26 Chong Yidong <cyd@gnu.org>
443 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
445 * search.c (Fsearch_forward, Fsearch_backward): Document negative
446 repeat counts (Bug#10507).
448 2012-01-26 Glenn Morris <rgm@gnu.org>
450 * lread.c (syms_of_lread): Doc fix.
452 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
454 * coding.c (encode_designation_at_bol): Change return value to
457 2012-01-25 Chong Yidong <cyd@gnu.org>
459 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
461 2012-01-21 Chong Yidong <cyd@gnu.org>
463 * floatfns.c (Fcopysign): Make the second argument non-optional,
464 since nil is not allowed anyway.
466 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
468 * process.c (read_process_output): Use p instead of XPROCESS (proc).
469 (send_process): Likewise.
471 2012-01-19 Martin Rudalics <rudalics@gmx.at>
473 * window.c (save_window_save, Fcurrent_window_configuration)
474 (Vwindow_persistent_parameters): Do not use Qstate.
477 2012-01-19 Kenichi Handa <handa@m17n.org>
479 * character.c (char_width): New function.
480 (Fchar_width, c_string_width, lisp_string_width):
481 Use char_width (Bug#9496).
483 2012-01-16 Martin Rudalics <rudalics@gmx.at>
485 * window.c (Vwindow_persistent_parameters): New variable.
486 (Fset_window_configuration, save_window_save): Handle persistent
489 2012-01-14 Eli Zaretskii <eliz@gnu.org>
491 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
492 thrashing the stack of the thread. (Bug#9087)
494 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
496 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
498 2012-01-11 Eli Zaretskii <eliz@gnu.org>
500 * xdisp.c (rows_from_pos_range): Handle the case where the
501 highlight ends on a newline. (Bug#10464)
502 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
503 he end column for display of highlight that ends on a newline
506 2012-01-11 Glenn Morris <rgm@gnu.org>
508 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
509 from load-path also when installation-directory is nil. (Bug#10208)
511 2012-01-10 Glenn Morris <rgm@gnu.org>
513 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
515 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
516 Update template values to be closer to their typical values these days.
518 2012-01-09 Eli Zaretskii <eliz@gnu.org>
520 * xdisp.c (rows_from_pos_range): Accept additional argument
521 DISP_STRING, and accept any glyph in a row whose object is that
522 string as eligible for mouse highlight. Fixes mouse highlight of
523 display strings from overlays. (Bug#10464)
525 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
527 emacs: fix an auto-save permissions race condition (Bug#10400)
528 * fileio.c (auto_saving_dir_umask): New static var.
529 (Fmake_directory_internal): Use it.
530 (do_auto_save_make_dir): Set it, instead of invoking chmod after
531 creating the directory. The old code temporarily assigns
532 too-generous permissions to the directory.
533 (do_auto_save_eh): Clear it.
534 (Fdo_auto_save): Catch all errors, not just file errors, so
535 that the var is always cleared.
537 2012-01-07 Eli Zaretskii <eliz@gnu.org>
539 * search.c (scan_buffer): Pass character positions to
540 know_region_cache, not byte positions. (Bug#6540)
542 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
544 * w32.c (sys_rename): Report EXDEV when rename of a directory
545 fails because the target is on another logical disk. (Bug#10284)
547 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
549 * xterm.c (x_embed_request_focus): New function.
551 * xterm.h: Add prototype.
553 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
555 2012-01-05 Glenn Morris <rgm@gnu.org>
557 * emacs.c (emacs_copyright): Update short copyright year to 2012.
559 2012-01-01 Eli Zaretskii <eliz@gnu.org>
561 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
562 Load gnutls_transport_set_lowat only if GnuTLS version is below
564 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
565 GnuTLS versions below 2.11.1.
567 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
569 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
570 to the doc string advising against its use for altering the way
571 windows are scrolled.
573 2011-12-28 Kenichi Handa <handa@m17n.org>
575 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
576 coding-system ASCII compatible only when it does not produce BOM
577 on encoding (Bug#10383).
579 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
581 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
583 (create_and_show_popup_menu): Always use menu_position_func for
586 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
588 * callint.c (Fcall_interactively): Don't truncate prompt string.
590 2011-12-23 Eli Zaretskii <eliz@gnu.org>
592 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
593 property that ends at ZV, so that the bidi iteration could be
594 resumed from there (after widening). (Bug#10360)
596 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
598 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
600 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
602 * nsterm.m (x_free_frame_resources):
603 Release f->output_data.ns->miniimage.
604 (ns_index_color): Fix indentation. Do not retain
605 color_table->colors[i].
607 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
610 * nsfns.m (x_set_background_color): Assign return value from
611 ns_index_color to face-background instead of NSColor*.
612 (ns_implicitly_set_icon_type): Fix indentation.
613 Change assignment in for loop to comparison.
615 * emacs.c (ns_pool): New variable.
616 (main): Assign ns_pool.
617 (Fkill_emacs): Call ns_release_autorelease_pool.
619 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
620 autorelease fdesc, release fdAttrs and tdict.
621 (ns_get_covering_families): Release charset.
622 (ns_findfonts): Release NSFontDescriptor created with new.
623 (ns_uni_to_glyphs): Fix indentation.
624 (setString): Release attrStr before assigning new value.
626 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
628 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
630 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
631 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
633 2011-12-18 David Reitter <reitter@cmu.edu>
635 * nsterm.m (ns_term_init): Subscribe for notifications
636 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
637 to method trackingNotification in EmacsMenu.
639 * nsmenu.m (trackingMenu): New variable.
640 (trackingNotification): New method (from Aquamacs).
641 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
642 from Aquamacs (Bug#7030).
644 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
646 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
647 (symbol_to_nsstring): Fix indentation.
648 (ns_symbol_to_pb): New function.
649 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
650 (Fns_rotate_cut_buffers_internal): Remove.
651 (Fns_store_selection_internal): Rename from
652 Fns_store_cut_buffer_internal.
653 (ns_get_foreign_selection, Fx_own_selection_internal)
654 (Fx_disown_selection_internal, Fx_selection_exists_p)
655 (Fns_get_selection_internal, Fns_store_selection_internal):
656 Use ns_symbol_to_pb and check if return value is nil.
657 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
658 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
659 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
660 renamed to Sns_store_selection_internal.
661 (ns_handle_selection_request): Move code to Fx_own_selection_internal
662 and remove this function.
663 (ns_handle_selection_clear): Remove, never used.
664 (Fx_own_selection_internal): Move code from ns_handle_selection_request
667 2011-12-17 Ken Brown <kbrown@cornell.edu>
669 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
670 GID is unknown (Bug#10257).
672 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
674 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
675 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
676 which caused a build failure on GNU/Linux IA-64. This problem was
677 introduced by my 2011-10-07 patch.
679 2011-12-15 Juri Linkov <juri@jurta.org>
681 * image.c (imagemagick_error): New function. (Bug#10112)
682 (imagemagick_load_image): Comment out `MagickSetResolution' call.
683 Use `imagemagick_error' where ImageMagick functions return
685 (Fimagemagick_types): Add `Fnreverse' to return the list in the
688 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
690 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
691 fill background (Bug#8992).
693 2011-12-13 Martin Rudalics <rudalics@gmx.at>
695 * window.c (Vwindow_combination_resize)
696 (Vwindow_combination_limit): Use t instead of non-nil in
698 (Vrecenter_redisplay): Add first sentence of doc-string on
700 (Frecenter): Fix doc-string typo.
702 2011-12-11 Kenichi Handa <handa@m17n.org>
704 * coding.c (Funencodable_char_position): Pay attention to the
705 buffer text relocation (Bug#9389).
707 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
709 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
710 gtk_init (Bug#10100).
712 2011-12-10 Eli Zaretskii <eliz@gnu.org>
714 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
715 IT->string is nil. (Bug#10263)
717 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
719 * nsterm.h (x_free_frame_resources): Declare.
721 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
722 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
724 * nsterm.h (ns_get_defaults_value): Declare.
726 * nsterm.m (ns_default): Call ns_get_defaults_value.
728 2011-12-09 Eli Zaretskii <eliz@gnu.org>
730 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
733 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
735 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
736 that where the value of an _OBJC_* symbol points to is in the .bss
739 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
741 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
742 after the loop to call ccl_driver at least once (Bug#8619).
744 2011-12-08 Kenichi Handa <handa@m17n.org>
746 * ftfont.c (get_adstyle_property): Fix previous change
749 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
751 * w32.c (init_environment): If no_site_lisp, remove site-lisp
752 dirs from the default value of EMACSLOADPATH (bug#10208).
754 2011-12-07 Glenn Morris <rgm@gnu.org>
756 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
757 installation and source directories as well. (Bug#10208)
759 2011-12-06 Chong Yidong <cyd@gnu.org>
761 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
763 2011-12-06 Glenn Morris <rgm@gnu.org>
765 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
766 as an error, not just -1. (Bug#10217)
768 2011-12-05 Chong Yidong <cyd@gnu.org>
770 * keyboard.c (process_special_events): New function.
771 (swallow_events, Finput_pending_p): Use it (Bug#10195).
773 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
775 * coding.c (encode_designation_at_bol): Don't use uninitialized
776 local variable (Bug#9318).
778 2011-12-05 Kenichi Handa <handa@m17n.org>
780 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
781 return Qnil (Bug#8046, Bug#10193).
783 2011-12-05 Kenichi Handa <handa@m17n.org>
785 * coding.c (encode_designation_at_bol): New args charbuf_end and
786 dst. Return the number of produced bytes. Callers changed.
787 (coding_set_source): Return how many bytes coding->source was
789 (coding_set_destination): Return how many bytes
790 coding->destination was relocated.
791 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
792 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
794 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
796 * coding.c (CODING_CHAR_CHARSET_P): New macro.
797 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
800 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
802 The following changes are to fix Bug#9318.
804 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
805 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
806 (encode_coding_iso_2022, encode_coding_sjis)
807 (encode_coding_big5, encode_coding_charset): Use the above macros.
809 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
811 * lisp.h (process_quit_flag): Fix external declaration.
813 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
815 Don't macro-inline non-performance-critical code.
816 * eval.c (process_quit_flag): New function.
817 * lisp.h (QUIT): Use it.
819 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
821 * nsfns.m (get_geometry_from_preferences): New function.
822 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
824 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
826 * emacs.c (Qkill_emacs): Define.
827 (syms_of_emacs): Initialize it.
828 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
829 Qquit_flag to `kill-emacs' instead.
830 (quit_throw_to_read_char): Add parameter `from_signal'.
831 All callers changed. Call Fkill_emacs if requested and safe.
832 * lisp.h (QUIT): Call Fkill_emacs if requested.
834 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
836 * widget.c (update_wm_hints): Return if wmshell is null.
837 (widget_update_wm_size_hints): New function.
839 * widget.h (widget_update_wm_size_hints): Declare.
841 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
842 widget_update_wm_size_hints (Bug#10104).
844 2011-12-03 Eli Zaretskii <eliz@gnu.org>
846 * xdisp.c (handle_invisible_prop): If the invisible text ends just
847 before a newline, prepare the bidi iterator for consuming the
848 newline, and keep the current paragraph direction. (Bug#10183)
849 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
851 2011-12-02 Juri Linkov <juri@jurta.org>
853 * search.c (Fword_search_regexp): New Lisp function created from
854 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
855 (Fword_search_backward, Fword_search_forward)
856 (Fword_search_backward_lax, Fword_search_forward_lax):
857 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
858 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
860 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
862 * fileio.c (Finsert_file_contents): Move after-change-function call
863 to before the "handled:" label, since all "goto handled" appear in
864 cases where the *-change-functions have already been properly called
867 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
869 * keyboard.c (interrupt_signal): Don't call kill-emacs when
870 waiting for input. (Bug#10169)
872 2011-11-30 Eli Zaretskii <eliz@gnu.org>
874 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
875 verifies glyph row's hash code--we have just reallocated the
876 glyphs, so their contents can be complete garbage. (Bug#10164)
878 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
880 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
882 2011-11-30 Eli Zaretskii <eliz@gnu.org>
884 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
885 attributes are tested _before_ calling verify_row_hash, to protect
886 against GCC re-ordering of the tests. (Bug#10164)
888 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
890 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
892 * xterm.c (handle_one_xevent): Only set async_visible and friends
893 if net_wm_state_hidden_seen is non-zero (Bug#10002)
894 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
895 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
897 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
899 Remove GCPRO-related macros that exist only to avoid shadowing locals.
900 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
901 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
902 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
903 All uses changed to use GCPRO1 etc.
904 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
905 Revert to old implementation (i.e., before 2011-03-11).
907 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
909 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
910 of scroll runs so as to avoid assigning disabled bogus rows and
911 unnecessary graphics copy operations.
913 2011-11-27 Eli Zaretskii <eliz@gnu.org>
915 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
916 (snprintf) [_MSC_VER]: Redirect to _snprintf.
917 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
918 (malloc, free, realloc, calloc): Redirect to e_* only when
921 * lisp.h (GCTYPEBITS): Move before first use.
922 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
923 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
924 this macro definition.
926 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
929 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
931 * gtkutil.c (xg_create_frame_widgets):
932 Call gtk_window_set_has_resize_grip (FALSE) if that function is
933 present with Gtk+ 2.0.
935 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
937 * fileio.c (Finsert_file_contents): Undo previous change; see
938 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
940 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
942 Rename locals to avoid shadowing.
943 * fileio.c (Finsert_file_contents):
944 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
945 * process.c (wait_reading_process_output):
946 Rename inner 'proc' to 'p' to avoid shadowing.
947 Indent for consistency with usual Emacs style.
949 2011-11-25 Eli Zaretskii <eliz@gnu.org>
951 * xdisp.c (redisplay_window): If cursor row is not fully visible
952 after recentering, and scroll-conservatively is set to a large
953 number, scroll window by a few more lines to make the cursor fully
954 visible and out of scroll-margin. (Bug#10105)
955 (start_display): Don't move to the next line if the display should
956 start at a newline that is part of a display vector or an overlay
959 2011-11-24 Juri Linkov <juri@jurta.org>
961 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
962 after the `MagickPingImage' call. (Bug#10112)
964 2011-11-23 Chong Yidong <cyd@gnu.org>
966 * window.c (Fcoordinates_in_window_p): Accept only live windows.
968 2011-11-23 Martin Rudalics <rudalics@gmx.at>
970 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
971 making another buffer current. (Bug#10114)
973 2011-11-23 Glenn Morris <rgm@gnu.org>
975 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
977 2011-11-23 Chong Yidong <cyd@gnu.org>
979 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
982 2011-11-22 Eli Zaretskii <eliz@gnu.org>
984 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
985 and header-lines, as they don't have one computed for them.
988 * .gdbinit (prow): Make displayed values more self-explaining.
991 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
993 * process.c (wait_reading_process_output): Fix asynchrounous
994 GnuTLS socket handling on some versions of the GnuTLS library.
995 (wait_reading_process_output): Add comment and URL.
997 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
999 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1001 2011-11-21 Chong Yidong <cyd@gnu.org>
1003 * window.c (Fnext_window, Fprevious_window): Doc fix.
1005 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1007 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1009 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1011 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1013 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1015 * window.c (Fset_window_combination_limit): Rename argument
1017 (Vwindow_combination_limit): Remove "status" from doc-string.
1019 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1021 * m/ibms390.h: Remove.
1022 * m/ibms390x.h: Don't include "ibms390.h".
1024 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1026 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1027 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1029 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1031 * casetab.c (Fset_case_table):
1032 * charset.c (Fcharset_after): Fix typos.
1034 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1036 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1037 Otherwise, valgrind does not work on some platforms.
1038 Problem reported by Andreas Schwab in
1039 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1040 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1041 is set, removing the need for VIRT_ADDRESS_VARIES.
1042 (PURE_P): Use a more-efficient implementation that needs just one
1043 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1044 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1045 to 4 (xorl, subq, cmpq, setbe).
1046 * alloc.c (pure): Always extern now, since that's the
1047 VIRT_ADDR_VARIES behavior.
1048 (PURE_POINTER_P): Use a single comparison, not two, for
1049 consistency with the new puresize.h.
1050 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1051 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1052 Remove VIRT_ADDR_VARIES no longer needed.
1054 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1056 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1057 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1058 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1059 behave as if the cursor position were at the window margin.
1061 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1062 and the cursor position is out of bounds, behave as if the cursor
1063 position were at the window margin. (Bug#10075)
1065 2011-11-18 Chong Yidong <cyd@gnu.org>
1067 * window.c (Fwindow_combination_limit): Make first argument
1068 non-optional, since it is meaningless for live windows like the
1071 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1073 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1075 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1077 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1078 (graft_intervals_into_buffer): Simplify.
1080 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1082 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1083 hash values of the two rows.
1084 (copy_row_except_pointers): Preserve the used[] arrays and the
1085 hash values of the two rows. (Bug#10035)
1086 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1088 * xdisp.c (row_hash): New function, body extracted from
1089 compute_line_metrics.
1090 (compute_line_metrics): Call row_hash, instead of computing the
1093 * dispnew.c (verify_row_hash): Call row_hash for computing the
1094 hash code of a row, instead of duplicating code from xdisp.c.
1096 * dispextern.h (row_hash): Add prototype.
1098 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1100 * frame.c (delete_frame): Don't delete the terminal when the last
1101 X frame is closed if emacs is built with GTK toolkit.
1103 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1105 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1107 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1109 * window.c (Vwindow_splits): Rename to
1110 Vwindow_combination_resize. Suggested by Juri Linkov.
1111 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1114 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1116 * nsfns.m (Fns_font_name):
1117 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1119 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1121 * window.h (window): Rename slot "nest" to "combination_limit".
1122 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1123 (Fset_window_nest): Rename to Fset_window_combination_limit.
1124 (Vwindow_nest): Rename to Vwindow_combination_limit.
1125 (recombine_windows, make_parent_window, make_window)
1126 (Fsplit_window_internal, saved_window)
1127 (Fset_window_configuration, save_window_save): Rename all
1128 occurrences of window_nest to window_combination_limit.
1130 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1132 * image.c (imagemagick_load_image): Fix typo.
1134 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1136 * xdisp.c (display_line): Move the call to
1137 highlight_trailing_whitespace before the call to
1138 compute_line_metrics, since the latter needs to see the final
1139 faces of all the glyphs to compute ROW's hash value.
1140 Fixes assertion violations in row_equal_p. (Bug#10035)
1142 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1144 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1145 just return (bug#10044).
1147 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1149 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1150 with user-defined heap size. Bump the default size of the temacs
1151 heap to 27MB, to avoid memory warning when running temacs.
1152 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1154 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1155 current_matrix and desired_matrix. (Bug#9990)
1156 (verify_row_hash) [XASSERTS]: New function.
1157 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1158 that the hash value of glyph rows is correct.
1160 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1162 * window.h (window): Remove splits slot.
1163 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1164 (Fdelete_other_windows_internal, make_parent_window)
1165 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1166 (Fset_window_configuration, save_window_save): Don't deal with
1167 split status of windows.
1168 (saved_window): Remove splits slot.
1169 (Vwindow_splits): Rewrite doc-string.
1171 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1173 * xfns.c (unwind_create_frame):
1174 * nsfns.m (unwind_create_frame):
1175 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1176 Vframe_list (Bug#9999).
1178 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1180 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1182 2011-11-11 Kenichi Handa <handa@m17n.org>
1184 * callproc.c (Fcall_process): Set the member dst_multibyte of
1187 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1189 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1190 avoid a crash (bug#9496).
1192 2011-11-09 Chong Yidong <cyd@gnu.org>
1194 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1195 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1197 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1199 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1201 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1203 Avoid some portability problems by eschewing 'extern inline' functions.
1204 The trivial performance wins aren't worth the portability hassles; see
1205 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1207 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1208 (window_box_width, window_box_left, window_box_left_offset)
1209 (window_box_right, window_box_right_offset): Undo previous change,
1210 by removing the "extern"s.
1211 * intervals.c (adjust_intervals_for_insertion)
1212 (adjust_intervals_for_deletion): Undo previous change,
1213 making these static again.
1214 (offset_intervals, temp_set_point_both, temp_set_point)
1215 (copy_intervals_to_string): No longer inline.
1216 * xdisp.c (window_text_bottom_y, window_box_width)
1217 (window_box_height, window_box_left_offset)
1218 (window_box_right_offset, window_box_left, window_box_right)
1219 (window_box): No longer inline.
1221 2011-11-08 Chong Yidong <cyd@gnu.org>
1223 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1224 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1225 Signal an error if not a live window.
1226 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1227 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1229 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1231 * lisp.h (syms_of_abbrev): Remove declaration.
1232 Reported by CHENG Gao <chenggao@royau.me>.
1234 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1236 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1237 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1238 of temacs in GUI mode.
1240 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1242 * window.h: Declare delete_all_child_windows instead of
1243 delete_all_subwindows.
1244 * window.c (Fwindow_nest, Fset_window_nest)
1245 (Fset_window_new_total, Fset_window_new_normal)
1246 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1247 (delete_all_subwindows): Rename to delete_all_child_windows.
1248 (Fdelete_other_windows_internal, Fset_window_configuration):
1249 Call delete_all_child_windows instead of delete_all_subwindows.
1250 * frame.c (delete_frame): Call delete_all_child_windows instead
1251 of delete_all_subwindows.
1253 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1255 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1256 This is also needed for porting to any host where GC_MARK_STACK is
1257 not GC_MAKE_GCPROS_NOOPS.
1258 (which_symbols): Use it.
1260 2011-11-07 Kenichi Handa <handa@m17n.org>
1262 * coding.c (coding_set_destination): Check coding->src_pos only
1263 when coding->src_object is a buffer (bug#9910).
1265 * process.c (send_process): Set the member src_multibyte of coding
1266 to 0 (bug#9911) when sending a unibyte text.
1268 * callproc.c (Fcall_process): Set the member src_multibyte of
1269 process_coding to 0 (bug#9912).
1271 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1273 * xmenu.c (cleanup_widget_value_tree): New function.
1274 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1275 calling free_menubar_widget_value_tree directly (Bug#9830).
1277 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1279 Fix some portability problems with 'inline'.
1280 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1281 (window_box_width, window_box_left, window_box_left_offset)
1282 (window_box_right, window_box_right_offset): Declare extern.
1283 Otherwise, these inline functions do not conform to C99 and
1284 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1285 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1286 * intervals.c (adjust_intervals_for_insertion)
1287 (adjust_intervals_for_deletion): Now extern, because otherwise the
1288 extern inline functions 'offset_intervals' couldn't refer to it.
1289 (static_offset_intervals): Remove.
1290 (offset_intervals): Rewrite using the old contents of
1291 static_offset_intervals. The old version didn't conform to C99
1292 because an extern inline function contained a reference to an
1293 identifier with static linkage.
1295 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1297 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1300 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1302 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1303 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1304 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1305 return Qleft_to_right.
1307 2011-11-06 Chong Yidong <cyd@gnu.org>
1309 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1310 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1311 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1312 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1313 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1314 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1315 (Fwindow_vscroll): Doc fix.
1316 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1317 argument, since it makes no sense to pass a live window and for
1318 consistency with window-child.
1320 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1322 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1325 2011-11-05 Jason Rumney <jasonr@gnu.org>
1327 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1328 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1330 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1331 bitwise arithmetic preventing use of unicode-sip and non-truetype
1334 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1336 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1339 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1340 initialization code to keep similarity to xfns.c after changes
1343 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1345 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1346 (unwind_create_frame): New function (Bug#9943).
1347 (Fx_create_frame): Restructure code to be more similar to the one in
1348 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1349 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1350 Move terminal->reference_count++ just before making the frame official
1353 * nsterm.m (x_free_frame_resources): New function.
1354 (x_destroy_window): Move code to x_free_frame_resources.
1356 * xfns.c (unwind_create_frame): Fix comment.
1357 (Fx_create_frame, x_create_tip_frame):
1358 Move terminal->reference_count++ just before making the frame
1359 official. Move initialization of image_cache_refcount and
1360 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1362 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1364 Support MSVC build with newer versions of Visual Studio.
1365 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1366 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1369 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1370 which are not supported by MSVC.
1371 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1372 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1374 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1376 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1378 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1380 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1382 Support MSVC build with newer versions of Visual Studio.
1383 * w32.c: Don't include w32api.h for MSVC.
1384 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1386 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1387 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1388 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1389 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1391 (alloca) [_MSC_VER]: Define to _alloca.
1393 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1395 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1397 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1399 * xdisp.c (note_mouse_highlight): If either of
1400 previous/next-single-property-change returns nil, treat that as
1401 the beginning or the end of the buffer. (Bug#9955)
1403 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1405 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1406 label is not null (Bug#9951).
1407 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1410 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1412 * window.c (Fwindow_body_size): Mention in the doc string that the
1413 return value is in frame's canonical units. (Bug#9949)
1415 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1417 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1419 * w32fns.c (unwind_create_frame): If needed, free the glyph
1420 matrices of the partially constructed frame. (Bug#9943)
1421 * xfns.c (unwind_create_frame): Likewise.
1423 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1425 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1426 Don't stop backward scan on the continuation glyph, even though
1427 its CHARPOS is positive.
1428 (mouse_face_from_buffer_pos, note_mouse_highlight):
1429 Rename cover_string to disp_string.
1431 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1433 * window.c (temp_output_buffer_show): Don't use
1434 Vtemp_buffer_show_specifiers.
1435 (Vtemp_buffer_show_specifiers): Remove unused variable.
1437 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1439 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1440 past the beginning of the current glyph matrix.
1442 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1444 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1445 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1446 HAVE_GTK3 (Bug#9869).
1448 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1449 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1451 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1453 * xterm.c: Declare x_handle_net_wm_state to return int.
1454 (handle_one_xevent): Check if we are iconified but don't have
1455 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1456 (get_current_wm_state): Return non-zero if not hidden,
1457 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1458 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1459 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1460 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1462 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1464 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1465 so that this new function doesn't get optimized away by a
1466 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1468 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1470 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1472 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1474 Fix the `xbytecode' command.
1475 * .gdbinit (xprintbytestr): New command.
1476 (xwhichsymbols): Rename from `which'; all callers changed.
1477 (xbytecode): Print the byte-code string as well.
1479 2011-10-29 Kim Storm <storm@cua.dk>
1481 * alloc.c (which_symbols): New function.
1483 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1485 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1488 2011-10-29 Glenn Morris <rgm@gnu.org>
1490 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1491 Not clear what it was for, and it causes various bugs. (Bug#9839)
1493 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1495 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1496 possible random value that matches one of those tested as
1497 condition to clear the mouse face.
1499 2011-10-28 Chong Yidong <cyd@gnu.org>
1501 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1503 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1505 * window.c (make_window): Initialize phys_cursor_on_p.
1507 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1509 * lisp.h (struct Lisp_Symbol): Update comments.
1511 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1513 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1515 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1517 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1518 <oslsachem@gmail.com> for helping to debug this.
1520 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1521 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1522 (g_b_init_get_glyph_outline_w): New static variables.
1523 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1524 (GetGlyphOutlineW_Proc): New typedefs.
1525 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1526 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1528 (w32font_open_internal, compute_metrics):
1529 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1530 instead of calling the "wide" APIs directly.
1532 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1534 * w32.h (syms_of_w32font): Add prototype.
1536 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1538 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1539 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1540 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1541 (Fmove_to_window_line): Doc fix.
1543 2011-10-27 Chong Yidong <cyd@gnu.org>
1545 * process.c (make_process): Set gnutls_state to NULL.
1547 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1548 non-NULL, regardless of GNUTLS_INITSTAGE.
1549 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1550 an error. Set process slots as soon as we allocate them.
1552 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1554 2011-10-27 Chong Yidong <cyd@gnu.org>
1556 * gnutls.c (emacs_gnutls_deinit): New function.
1557 Deallocate credentials structures as well as calling gnutls_deinit.
1558 (Fgnutls_deinit, Fgnutls_boot): Use it.
1560 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1561 (deactivate_process): Call emacs_gnutls_deinit.
1563 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1565 * image.c (x_create_x_image_and_pixmap):
1566 * w32.c (sys_rename, w32_delayed_load):
1567 * w32font.c (fill_in_logfont):
1568 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1570 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1572 * w32fns.c (w32_default_color_map): New function,
1573 extracted from Fw32_default_color_map.
1574 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1576 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1578 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1580 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1582 * keyboard.c (test_undefined): New function (bug#9751).
1583 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1585 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1587 * sysdep.c (init_sys_modes): Fix the check for the controlling
1588 terminal (Bug#6649).
1590 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1592 * dispextern.h (struct bidi_it): New member next_en_type.
1594 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1595 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1596 current character, check also for next_en_type being WEAK_EN.
1597 (bidi_resolve_weak): Don't enter the expensive loop if the current
1598 position is before next_en_pos. Record the bidi type of the first
1599 non-ET, non-BN character we find, in addition to its position.
1600 (bidi_level_of_next_char): Invalidate next_en_type when
1601 next_en_pos is over-stepped.
1603 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1605 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1606 * editfns.c: Rewrite current-time-zone so that it invokes
1607 the equivalent of (format-time-string "%Z") to get the time zone name.
1608 This fixes a bug when the time zone name contains characters that
1609 need converting from the system time locale to Emacs internal format.
1610 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1611 that patch fixed format-time-string to do the conversion, but
1612 I forgot to fix current-time-zone.
1613 (format_time_string): New function, containing most of
1614 what Fformat_time_string used to contain.
1615 (Fformat_time_string): Rewrite in terms of format_time_string.
1616 This doesn't change this function's behavior.
1617 (current-time-zone): Rewrite to use format_time_string.
1618 This fixes the bug reported by Michael Schierl in
1619 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1620 Jason Rumney's 2007-06-07 change worked around this bug, but
1622 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1624 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1626 * xdisp.c (start_display): If the character at POS is displayed
1627 via a display vector, reset IT->current.dpvec_index to zero.
1628 (try_window_reusing_current_matrix): If a line ends in a display
1629 vector or the next line starts in a display vector, continue
1630 redrawing the window even though the character position of
1631 start_row was reached.
1634 2011-10-18 Chong Yidong <cyd@gnu.org>
1636 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1637 with nobreak-char-display too.
1639 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1641 Fix part 3 of bug#9771.
1642 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1643 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1644 non-neutral characters if the current character is a paragraph
1645 separator (a.k.a. Newline). This avoids running the same
1646 expensive loop twice, once when we consume the preceding newline
1647 and the other time when the line actually needs to be displayed.
1648 Avoid the loop when we see neutrals on the base embedding level
1649 following a character whose directionality is the same as the
1650 paragraph's. This avoids running the expensive loop when a line
1651 ends in a long sequence of neutrals, like control characters.
1652 Add assertion against STRONG_AL type. Slightly rearrange code
1653 that determines the type of a neutral given the first non-neutral
1655 (bidi_level_of_next_char): Set next_en_pos to zero when
1656 invalidating its info.
1658 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1660 * xdisp.c (push_display_prop): Determine whether to record string
1661 or buffer position by IT->string, not by IT->method. Allow
1662 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1663 (move_it_vertically_backward): Don't look for character position
1664 immediately after the newline when in a continuation line.
1667 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1669 * window.c (coordinates_in_window): Rewrite and delabelize
1670 vertical border check. (Bug#5357) (Bug#9618)
1672 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1674 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1675 errors in XSetWindowBorder (bug#9310).
1677 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1679 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1680 avoid crash when xmalloc overrun checking is enabled.
1682 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1684 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1685 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1686 cursor motion with <left> and <right> arrow keys.
1688 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1689 some callers set that themselves.
1691 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1693 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1694 display string and the previous row comes from the same string and
1695 is empty. (Bug#9739) (Bug#9738)
1697 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1699 * doc.c (get_doc_string): Encode file name (bug#9735).
1701 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1703 * bidi.c (bidi_level_of_next_char):
1704 * xdisp.c (get_visually_first_element): Remove old incorrect
1705 comments regarding the Unicode Line Separator character.
1707 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1709 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1711 * alloc.c (Fgc_status): Do not access beyond zombies array
1712 boundary if nzombies > MAX_ZOMBIES.
1713 * alloc.c (dump_zombies): Add missing format specifier.
1715 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1717 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1718 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1720 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1721 Some packages use them to denote characters with modifiers.
1723 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1725 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1726 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1727 matching a pp-number. Rename parameter var to var1.
1729 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1731 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1733 2011-10-08 Glenn Morris <rgm@gnu.org>
1735 * callint.c (Fcall_interactively): Give a more explicit error for the
1736 'c' case with a non-character input. (Bug#8479)
1738 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1740 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1742 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1743 lines that are hscrolled on the left.
1745 * dispnew.c (buffer_posn_from_coords): Account for a possible
1746 presence of header-line. (Bug#4426)
1748 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1750 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1751 Don't advertise functionality which we discourage or doesn't work.
1753 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1755 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1756 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1757 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1758 this makes Emacs dump core during garbage collection on rare
1759 occasions. sizeof is obviously inferior to offsetof here, so
1760 stick with offsetof.
1761 (GC_POINTER_ALIGNMENT): New macro.
1762 (mark_memory): Omit 3rd (offset) arg; caller changed.
1763 Don't assume EMACS_INT alignment is the same as pointer alignment.
1765 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1767 * keyboard.c (read_key_sequence_remapped): New var.
1768 (read_key_sequence): Compute remapping in the right buffer.
1769 (command_loop_1): Use read_key_sequence's remapping directly.
1771 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1773 * dired.c (file_name_completion): Don't expand file name.
1774 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1775 before checking file name handler.
1777 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1778 they've been requested explicitly (bug#9591).
1780 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1782 * keymap.c (Fsingle_key_description): Use make_specified_string
1783 instead of build_string to build string from push_key_description.
1786 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1788 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1789 This fixes a Y2038 bug on 64-bit hosts.
1790 * buffer.c (reset_buffer):
1791 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1792 (Fclear_buffer_auto_save_failure):
1793 Use 0, not -1, to represent an unset failure time, since time_t
1794 might not be signed.
1796 Remove dependency on glibc malloc internals.
1797 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1798 Move back here from lisp.h, but with their new implementations.
1799 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1800 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1801 * charset.c (charset_table_init): New static var.
1802 (syms_of_charset): Use it instead of xmalloc. This removes a
1803 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1804 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1805 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1806 Move back to alloc.c.
1807 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1808 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1810 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1812 * nsterm.m (windowDidResize): Call x_set_window_size only when
1813 ns_in_resize is true. Otherwise set pixelwidth/height and
1814 call change_frame_size (Bug#9628).
1816 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1818 Port --enable-checking=all to Fedora 14 x86-64.
1819 * charset.c (syms_of_charset): Also account for glibc malloc's
1820 internal overhead when calculating the initial malloc maximum.
1822 Port --enable-checking=all to Fedora 14 x86.
1823 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1825 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1826 (overrun_check_realloc, overrun_check_free):
1827 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1828 That way, xmalloc returns a properly-aligned pointer even if
1829 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1830 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1831 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1832 into account when calculating the initial malloc maximum.
1833 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1834 Move here from alloc.c, so that charset.c can use it too.
1835 Properly align; the old code wasn't right for common 32-bit hosts
1836 when configured with --enable-checking=all.
1837 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1838 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1840 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1842 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1845 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1847 * xdisp.c (compute_display_string_end): If there's no display
1848 string at CHARPOS, return -1.
1850 * bidi.c (bidi_fetch_char): When compute_display_string_end
1851 returns a negative value, treat the character as a normal
1852 character not covered by a display string. (Bug#9624)
1854 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1856 * lread.c (Fread_from_string): Fix typo in docstring.
1858 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1860 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1861 newline, reseat the iterator instead of bidi-iterating there one
1862 character at a time. (Bug#9610)
1863 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1864 TO_CHARPOS if the bidi iterator is at base embedding level.
1866 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1868 * lread.c (readevalloop): Use correct code for NBSP.
1869 (read1): Likewise. (Bug#9608)
1871 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1873 * dbusbind.c (Fdbus_register_signal): When service is not
1874 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1876 2011-09-25 Glenn Morris <rgm@gnu.org>
1878 * buffer.c (truncate-lines): Doc fix.
1880 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1882 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1883 (Fset_window_next_buffers): Doc fix.
1885 2011-09-24 Glenn Morris <rgm@gnu.org>
1887 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1889 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1891 Fix minor problems found by static checking.
1892 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1893 * indent.c (Fvertical_motion): Fix == vs = typo.
1895 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1897 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1898 Default value is now t. Doc fix.
1900 * indent.c (Fvertical_motion): Compute and apply the overshoot
1901 logic when moving up, not only when moving down. Fix the
1902 confusing name and values of the it_overshoot_expected variable;
1903 logic changes accordingly. (Bug#9254) (Bug#9549)
1905 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1906 CHARPOS is covered by a display string which includes newlines.
1907 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1908 is covered by a display string with embedded newlines.
1910 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1912 * dbusbind.c (Fdbus_register_signal): Add match rule to
1913 Vdbus_registered_objects_table. (Bug#9581)
1914 (Fdbus_register_method, Vdbus_registered_objects_table):
1917 2011-09-24 Jim Meyering <meyering@redhat.com>
1919 do not ignore write error for any output size
1920 The previous change was incomplete.
1921 While it makes emacs --batch detect the vast majority of stdout
1922 write failures, errors were still ignored whenever the output size is
1923 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1924 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1925 && echo FAIL: ignored write error
1926 FAIL: ignored write error
1927 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1928 && echo FAIL: ignored write error
1929 FAIL: ignored write error
1930 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1932 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1934 * emacs.c (Fkill_emacs): In noninteractive mode exit
1935 non-successfully if a write error occurred on stdout. (Bug#9574)
1937 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1939 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1942 * dispextern.h (struct it): Update the comment documenting what
1945 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1947 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1948 a display string, extend search for cursor position to end of row.
1949 (find_row_edges): If the row ends in a newline from a display
1950 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1951 Handle the case of a display string with multiple newlines.
1952 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1953 non-empty line. Fixes confusing cursor motion with arrow keys at
1954 the beginning of a line that starts with whitespace.
1956 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1958 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1961 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1963 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1966 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1968 * xdisp.c (display_line): Record maximum and minimum buffer
1969 positions even if no glyphs were produced (e.g., by a zero-width
1970 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1971 buffer positions that will be removed from the glyph row because
1973 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1974 column is beyond frame width: don't subtract 1 "pixel" when
1975 computing width of the stretch.
1976 (reseat_at_next_visible_line_start): Undo the change made on
1977 2011-09-17 that saved paragraph information and restored it after
1978 the call to `reseat'. (Bug#9545)
1980 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1982 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1983 and turn window cursor on if cleared (Bug#9415).
1985 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1987 * search.c (boyer_moore): Take unibyte characters from pattern
1988 literally. (Bug#9458)
1990 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1992 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1994 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1996 Fix minor problem found by static checking.
1997 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1998 initialized, to pacify gcc -Wuninitialized.
2000 * fileio.c: Report proper errno when syscall falls.
2001 (Finsert_file_contents): Save and restore errno,
2002 so that report_file_error outputs the correct diagnostic.
2003 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2005 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2007 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2009 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2011 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2012 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2014 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2016 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2017 about the current paragraph and restore it after the call to reseat.
2019 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2020 (bidi_find_paragraph_start): Search back for paragraph beginning
2021 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2022 (bidi_move_to_visually_next): Only trigger paragraph-related
2023 computations when the last character is a newline or at EOB, not
2024 just any NEUTRAL_B. (Bug#9470)
2026 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2027 truncated lines if point is covered by a display string. (Bug#9524)
2029 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2031 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2032 (cons_to_x_long): New function.
2033 (lisp_data_to_selection_data): Use it. Correct the test for
2034 short-versus-long data; it was negated. Break out of vector
2035 loop, for efficiency, when a long datum is discovered.
2037 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2039 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2041 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2043 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2044 GCC PR/17406) by declaring this function with external scope.
2046 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2048 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2049 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2051 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2053 * editfns.c (Fformat): Correctly handle text properties on "%%".
2055 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2057 * xterm.c (x_draw_composite_glyph_string_foreground):
2058 * w32term.c (x_draw_composite_glyph_string_foreground):
2059 * term.c (encode_terminal_code):
2060 * composite.c (composition_update_it, get_composition_id):
2061 * xdisp.c (get_next_display_element)
2062 (fill_composite_glyph_string): Add comments about special meaning
2063 of TAB characters in a composition.
2065 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2067 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2068 This occurs when processing a multibyte format.
2069 Problem reported by Wolfgang Jenker.
2071 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2073 * xdisp.c (try_cursor_movement): Only check for exact match if
2074 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2076 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2078 Remove unused external symbols.
2079 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2080 * xdisp.c (calc_pixel_width_or_height): Now static.
2081 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2082 * indent.c (check_display_width):
2083 * w32term.c: Fix comment to match code.
2084 * xterm.c, xterm.h (x_catching_errors): Remove.
2086 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2088 * xselect.c: Use signed conversions more consistently (Bug#9498).
2089 (selection_data_to_lisp_data): Assume incoming selection data are
2090 signed integers, not unsigned. This is to be consistent with
2091 outgoing selection data, which was modified to use signed integers
2092 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2093 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2094 expects long, not unsigned long.
2096 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2098 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2099 computation of loop end. Reported by Johan Bockgård
2102 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2104 * frame.c (Fother_visible_frames_p): Function deleted.
2106 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2108 * indent.c (compute_motion): Process display vector front to back
2109 rather than the other way around. (Bug#2496)
2111 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2113 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2115 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2117 * minibuf.c (Fread_from_minibuffer): Doc fix.
2119 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2121 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2122 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2124 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2126 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2127 value for non-existent files.
2129 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2131 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2132 set its "size" to -1. This will set the modtime_size field of
2133 the corresponding buffer to -1, which is what
2134 verify-visited-file-modtime expects for files that do not exist.
2137 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2139 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2141 * lisp.h: ... from here. push_key_description is no longer
2142 defined in keyboard.c, so its declaration should not be in
2143 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2144 logically belongs with push_key_description.
2146 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2148 * buffer.h: Include <sys/types.h> instead of <time.h>.
2149 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2150 Problem reported by Herbert J. Skuhra.
2152 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2154 * xml.c (parse_region): Make the parsing work for
2155 non-comment-starting XML files again (bug#9144).
2157 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2159 * image.c (gif_load): Fix calculation of bottom and right corner.
2162 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2164 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2165 redisplay in small windows.
2167 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2169 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2171 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2173 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2174 Operate on live windows only.
2176 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2178 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2180 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2182 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2183 only under bidi iteration.
2185 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2187 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2189 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2191 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2192 Without this fix, the command to link temacs failed due to an
2193 undefined symbol __builtin_isnan. This is because
2194 /usr/include/iso/math_c99.h #defines isnan(x) to
2195 __builtin_isnan(x), but the bundled gcc, which identifies itself
2196 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2198 * floatfns.c (isnan): #undef, and then #define to a clone of
2200 (Fisnan): Always define, since it's always available now.
2201 (syms_of_floatfns): Always define isnan at the Lisp level.
2203 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2205 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2207 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2209 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2210 The previous code assumed that file offsets (off_t values) fit in
2211 EMACS_INT variables, which is not true on typical 32-bit hosts.
2212 The code messed up by falsely reporting buffer overflow in cases
2213 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2214 when "big" contains more than 2**29 bytes, even though this
2215 inserts just one byte and does not overflow the buffer.
2216 (Finsert_file_contents): Store file offsets as off_t
2217 values, not as EMACS_INT values. Check for overflow when
2218 converting between EMACS_INT and off_t. When checking for
2219 buffer overflow or for overlap, take the offsets into account.
2220 Don't use EMACS_INT for small values where int suffices.
2221 When checking for overlap, fix a typo: ZV was used where
2222 ZV_BYTE was intended.
2223 (Fwrite_region): Don't assume off_t fits into 'long'.
2224 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2226 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2228 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2230 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2232 sprintf-related integer and memory overflow issues (Bug#9412).
2234 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2235 (esprintf, exprintf, evxprintf): New functions.
2236 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2237 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2238 (modify_event_symbol): Do not assume that the length of
2239 name_alist_or_stem is safe to alloca and fits in int.
2240 (Fexecute_extended_command): Likewise for function name and binding.
2241 (Frecursion_depth): Wrap around reliably on integer overflow.
2242 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2243 since some callers pass EMACS_INT values.
2244 (Fsingle_key_description): Don't crash if symbol name contains more
2245 than MAX_ALLOCA bytes.
2246 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2247 (get_minibuffer): Arg is now EMACS_INT, not int.
2248 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2249 (esprintf, exprintf, evxprintf): New decls.
2250 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2252 * dbusbind.c (signature_cat): New function.
2253 (xd_signature, Fdbus_register_signal):
2254 Do not overrun buffer; instead, report string overflow.
2256 * dispnew.c (add_window_display_history): Don't overrun buffer.
2257 Truncate instead; this is OK since it's just a log.
2259 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2260 even if the time zone offset is outlandishly large.
2261 Don't mishandle offset == INT_MIN.
2263 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2264 when creating daemon; the previous buffer-overflow check was incorrect.
2266 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2267 which has the guts of the old verror function.
2269 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2270 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2272 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2273 (font_unparse_xlfd): Don't blindly alloca long strings.
2274 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2275 fits in int, when using sprintf. Use single snprintf to count
2276 length of string rather than counting it via multiple sprintfs;
2277 that's simpler and more reliable.
2278 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2279 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2280 sprintf, in case result does not fit in int.
2282 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2283 (fontset_from_font): Print it.
2285 * frame.c (tty_frame_count): Now printmax_t, not int.
2286 (make_terminal_frame, set_term_frame_name): Print it.
2287 (x_report_frame_params): In X, window IDs are unsigned long,
2288 not signed long, so print them as unsigned.
2289 (validate_x_resource_name): Check for implausibly long names,
2290 and don't assume name length fits in 'int'.
2291 (x_get_resource_string): Don't blindly alloca invocation name;
2292 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2295 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2296 (xg_check_special_colors, xg_set_geometry):
2297 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2299 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2300 Use esprintf, not sprintf, in case result does not fit in int.
2302 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2303 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2304 it as a large positive number.
2305 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2306 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2308 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2309 in case result does not fit in int.
2311 * print.c (float_to_string): Detect width overflow more reliably.
2312 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2313 buffer overrun. Don't assume list length fits in 'int'. Treat
2314 print length of 0 as 0, not as infinity; to be consistent with other
2315 uses of print length in this function. Don't overflow print length
2316 index. Don't assume hash table size fits in 'long', or that
2317 vectorlike size fits in 'unsigned long'.
2319 * process.c (make_process): Use printmax_t, not int, to format
2320 process-name gensyms.
2322 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2324 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2325 to avoid potential buffer overrun.
2327 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2328 if X resource line is longer than 512 bytes.
2330 * xfns.c (x_window): Make sprintf buffer a bit bigger
2331 to avoid potential buffer overrun.
2333 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2335 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2337 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2339 Integer overflow fixes for scrolling, etc.
2340 Without these, Emacs silently mishandles large integers sometimes.
2341 For example, "C-u 4294967297 M-x recenter" was treated as if
2342 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2344 * xdisp.c (try_window_id): Check Emacs fixnum range before
2345 converting to 'int'.
2347 * window.c (window_scroll_line_based, Frecenter):
2348 Check that an Emacs fixnum is in range before assigning it to 'int'.
2349 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2350 values converted from Emacs fixnums.
2351 (Frecenter): Don't wrap around a line count if it is out of 'int'
2352 range; instead, treat it as an extreme value.
2353 (Fset_window_configuration, compare_window_configurations):
2354 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2356 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2357 that can exceed INT_MAX. Check that EMACS_INT value is in range
2358 before assigning it to the (possibly-narrower) index.
2359 (match_limit): Don't assume that a fixnum can fit in 'int'.
2361 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2364 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2365 (Fvertical_motion): Don't wrap around LINES values that don't fit
2366 in 'int'. Instead, treat them as extreme values. This is good
2367 enough for windows, which can't have more than INT_MAX lines anyway.
2369 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2371 * Require libxml/parser.h to avoid compilation warning.
2373 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2375 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2376 since this reportedly can destroy thread storage.
2378 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2380 * syntax.c (find_defun_start): Update all cache variables if
2381 exiting early (Bug#9401).
2383 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2385 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2387 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2388 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2389 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2391 * term.c (tty_append_glyph): New function.
2392 (produce_stretch_glyph): Static function and its prototype deleted.
2394 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2397 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2399 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2400 when checking :margin (Bug#9390).
2401 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2402 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2403 so that the name doesn't mislead. All uses changed.
2405 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2407 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2410 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2412 * xdisp.c (move_it_to): Don't bail out early when reaching
2413 position beyond to_charpos, if we are scanning backwards.
2414 (move_it_vertically_backward): When DY == 0, make sure we get to
2415 the first character in the line after the newline.
2417 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2419 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2420 (ccl_driver): Do not generate an out-of-range pointer.
2421 (Fccl_execute_on_string): Remove unnecessary check for
2422 integer overflow, noted by Stefan Monnier in
2423 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2424 Remove a FIXME that didn't need fixing.
2425 Simplify the newly-introduced buffer reallocation code.
2427 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2429 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2431 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2433 Integer and memory overflow issues (Bug#9196).
2435 * doc.c (get_doc_string): Rework so that
2436 get_doc_string_buffer_size is the actual buffer size, rather than
2437 being 1 less than the actual buffer size; this makes xpalloc more
2440 * image.c (x_allocate_bitmap_record, cache_image):
2441 * xselect.c (Fx_register_dnd_atom):
2442 Simplify previous changes by using xpalloc.
2444 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2445 since either will do and ptrdiff_t is convenient with xpalloc.
2447 * charset.c (charset_table_size)
2448 (struct charset_sort_data.priority): Now ptrdiff_t.
2449 (charset_compare): Don't overflow if priorities differ greatly.
2450 (Fsort_charsets): Don't assume list length fits in int.
2451 Check for size-calculation overflow when allocating sort data.
2452 (syms_of_charset): Allocate an initial charset table that is
2453 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2455 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2457 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2458 The actual value is always <= INT_MAX, and leaving it unsigned made
2459 overflow checking harder.
2461 * dispextern.h (struct glyph_matrix.rows_allocated)
2462 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2463 with xpalloc. The values are still always <= INT_MAX.
2465 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2467 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2468 (SAFE_NALLOCA): New macro.
2470 * region-cache.c (struct boundary.pos, find_cache_boundary)
2471 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2472 (set_cache_region, invalidate_region_cache)
2473 (revalidate_region_cache, know_region_cache, region_cache_forward)
2474 (region_cache_backward, pp_cache):
2475 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2476 so that ptrdiff_t * can be passed to xpalloc.
2477 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2478 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2479 (pp_cache): Don't assume cache_len fits in int.
2480 * region-cache.h: Adjust extern decls to match.
2482 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2483 EMACS_INT, since either will do, for xpalloc.
2485 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2486 (xnmalloc, xnrealloc, xpalloc): New functions.
2488 * bidi.c (bidi_shelve_header_size): New constant.
2489 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2490 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2492 * bidi.c (bidi_cache_shrink):
2493 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2495 Don't update size of array until after memory allocation succeeds,
2496 because xmalloc/xrealloc may not return.
2497 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2498 now that we have proper integer overflow checking.
2499 (record_overlay_string, overlay_strings): Catch overflows when
2500 calculating size of overlay_str_buf.
2502 * callproc.c (Fcall_process): Check for size overflow when
2503 calculating size of args2.
2504 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2505 Normally we prefer signed values, but sticking with ptrdiff_t would
2506 require adding more-complicated checks.
2508 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2509 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2510 Redo buffer-overflow calculations to avoid integer overflow.
2511 Add a FIXME comment where memory seems to be over-allocated.
2513 * character.c (Fstring): Check for size-calculation overflow.
2515 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2516 unnecessary integer overflow. Check for size overflow.
2517 (encode_coding_object): Don't update size until xmalloc succeeds.
2519 * composite.c (get_composition_id): Check for overflow in glyph
2520 length calculations.
2522 Integer and memory overflow fixes for display code.
2523 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2524 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2525 (scrolling_window): Check for overflow in size calculations.
2526 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2527 Don't assume glyph table len fits in int.
2528 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2529 (row_table_size): Now ptrdiff_t, not int.
2530 (scrolling_window): Avoid overflow in size calculations.
2531 Don't update size until allocation succeeds.
2532 * fns.c (concat): Check for overflow in size calculations.
2533 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2534 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2535 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2537 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2538 (get_doc_string): Check for size calculation overflow.
2539 Don't update size until allocation succeeds.
2540 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2541 EMACS_INT, where ptrdiff_t will do.
2542 (Fsubstitute_command_keys): Check for string overflow.
2544 * editfns.c (set_time_zone_rule): Don't assume environment length
2546 (message_length): Now ptrdiff_t, not int.
2547 (Fmessage_box): Don't update size until allocation succeeds.
2548 Don't assume message length fits in int.
2549 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2551 * emacs.c (main): Do not reallocate argv, since there is a null at
2552 the end that can be overwritten, and this way there's no need to
2553 worry about size-calculation overflow.
2554 (sort_args): Check for size-calculation overflow.
2556 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2558 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2560 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2561 (x_set_scroll_bar_width, x_figure_window_size):
2562 Check for integer overflow.
2563 (x_set_alpha): Do not assume XINT fits in int.
2565 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2566 This is for the members text_lines, text_cols, total_lines, total_cols,
2567 where the system imposes an 'int' limit.
2569 * fringe.c (Fdefine_fringe_bitmap):
2570 Don't update size until alloc works.
2572 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2573 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2575 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2576 Check for size-calculation overflow.
2577 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2578 do, as we prefer signed integers.
2579 (id_to_widget.max_size, id_to_widget.used)
2580 (xg_store_widget_in_map, xg_remove_widget_from_map)
2581 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2582 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2583 Use and return ptrdiff_t, not int.
2584 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2585 * gtkutil.h: Change prototypes to match the above.
2587 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2588 are duplicate now that they've been promoted to lisp.h.
2589 (x_allocate_bitmap_record, x_alloc_image_color)
2590 (make_image_cache, cache_image, xpm_load):
2591 Don't update size until alloc is done.
2592 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2594 Check for size calculation overflow.
2595 (ct_colors_allocated_max): New constant.
2596 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2599 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2600 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2601 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2602 Use ptrdiff_t, not int, to count maps.
2603 (read_char_minibuf_menu_prompt): Check for overflow in size
2604 calculations. Don't update size until allocation succeeds.
2605 Redo calculations to avoid overflow.
2606 * keyboard.h: Change prototypes to match the above.
2608 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2610 (current_minor_maps): Check for size calculation overflow.
2611 * keymap.h: Change prototypes to match the above.
2613 * lread.c (read1, init_obarray): Don't update size until alloc done.
2615 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2616 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2618 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2619 Now ptrdiff_t, not int.
2620 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2621 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2623 * process.c (Fnetwork_interface_list): Check for overflow
2624 in size calculation.
2626 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2628 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2629 overflow. Don't bother calling xmalloc when xrealloc will do.
2631 * search.c (Freplace_match): Check for size calculation overflow.
2632 (Fset_match_data): Don't assume list lengths fit in 'int'.
2634 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2635 for command line length. Do not attempt to address one before the
2636 beginning of an array, as that's not portable.
2638 * term.c (max_frame_lines): Remove; unused.
2639 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2641 (encode_terminal_code, calculate_costs): Check for size
2642 calculation overflow.
2643 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2644 table lengths and related sizes. Don't update size until alloc
2645 done. Redo calculations to avoid overflow.
2646 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2648 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2649 subtracting pointers.
2650 (gobble_line): Check for overflow more carefully. Don't update size
2653 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2654 Don't update size until alloc done.
2655 Redo size calculations to avoid overflow.
2656 Check for size calculation overflow.
2657 (main) [DEBUG]: Fix typo in invoking tparam1.
2659 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2660 Use ptrdiff_t, not int, for sizes.
2661 (store_mode_line_noprop_char): Don't update size until alloc done.
2663 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2664 Use ptrdiff_t, not int, for sizes.
2665 (Finternal_make_lisp_face, cache_face):
2666 Check for size calculation overflow.
2667 (cache_face): Treat size calculation overflows as if they were
2668 memory exhaustion (the usual treatment), rather than aborting.
2670 * xfns.c (x_encode_text, x_set_name_internal)
2671 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2672 sizes, since they can exceed INT_MAX in size. Check for size
2673 calculation overflow.
2675 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2676 (xg_select): Check for size calculation overflow.
2677 Don't update size until alloc done.
2679 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2680 as sprintf is limited to int lengths.
2682 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2683 (X_LONG_MIN): New macros.
2684 Use them to make the following changes clearer.
2685 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2686 This change doesn't affect the value now, but it may help remind
2687 future maintainers not to raise the value too much later.
2688 (SELECTION_QUANTUM): Remove, replacing with ...
2689 (selection_quantum): ... new function, which avoids overflow.
2691 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2692 assumption that selection length fits in 'int'.
2693 (x_reply_selection_request, x_handle_selection_request)
2694 (x_get_window_property, receive_incremental_selection)
2695 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2696 (lisp_data_to_selection_data, clean_local_selection_data):
2697 Use ptrdiff_t, not int, to record length of selection.
2698 (x_reply_selection_request, x_get_window_property)
2699 (receive_incremental_selection, x_property_data_to_lisp):
2700 Redo calculations to avoid overflow.
2701 (x_reply_selection_request): When sending hint, ceiling it at
2702 X_LONG_MAX rather than relying on wraparound overflow to send
2704 (x_get_window_property, receive_incremental_selection)
2705 (lisp_data_to_selection_data, x_property_data_to_lisp):
2706 Check for size-calculation overflow.
2707 (x_get_window_property, receive_incremental_selection)
2708 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2709 Don't store size until memory allocation succeeds.
2710 (x_get_window_property): Plug memory leak on memory exhaustion.
2711 Don't double-block input; malloc is safe here. Don't assume 2**34
2712 - 4 fits in unsigned long. Add an xassert to check
2713 XGetWindowProperty overflow. Be more careful about overflow
2714 calculations, and distinguish size from memory overflow better.
2715 (receive_incremental_selection): When tracing, don't assume
2716 unsigned int is less than INT_MAX.
2717 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2718 harmful) conversions of unsigned short to int.
2719 (lisp_data_to_selection_data): Don't assume that integers
2720 in the range -65535 through -1 fit in an X unsigned short.
2721 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2722 result parameters unless successful. Rely on cons_to_unsigned
2723 to report problems with elements; the old code wasn't right anyway.
2724 (x_check_property_data): Check for int overflow; we cannot use
2725 a wider type due to X limits.
2726 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2728 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2730 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2731 (x_term_init): Check for size calculation overflow.
2732 (x_color_cells): Don't store size until memory allocation succeeds.
2733 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2734 Don't assume alloca size is less than MAX_ALLOCA.
2735 (x_term_init): Don't assume length fits in int (sprintf is limited
2738 Use ptrdiff_t for composition IDs.
2739 * character.c (lisp_string_width):
2740 * composite.c (composition_table_size, n_compositions)
2741 (get_composition_id, composition_gstring_from_id):
2742 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2743 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2744 * window.c (Frecenter):
2745 Use ptrdiff_t, not int, for composition IDs.
2746 * composite.c (get_composition_id): Check for integer overflow.
2747 * composite.h: Adjust prototypes to match the above changes.
2749 Use ptrdiff_t for hash table indexes.
2750 * category.c (hash_get_category_set):
2751 * ccl.c (ccl_driver):
2752 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2753 * coding.c (coding_system_charset_list, detect_coding_system):
2754 * coding.h (struct coding_system.id):
2755 * composite.c (get_composition_id, gstring_lookup_cache):
2756 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2757 * image.c (xpm_get_color_table_h):
2758 * lisp.h (hash_lookup, hash_put):
2759 * minibuf.c (Ftest_completion):
2760 Use ptrdiff_t for hash table indexes, not int (which is too
2761 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2762 32-bit --with-wide-int hosts).
2764 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2765 Add a FIXME comment about memory leaks.
2766 (syms_of_charset): Don't assume xmalloc returns.
2768 Don't assume that stated character widths fit in int.
2769 * character.c (Fchar_width, c_string_width, lisp_string_width):
2770 * character.h (CHAR_WIDTH):
2771 * indent.c (MULTIBYTE_BYTES_WIDTH):
2772 Use sanitize_char_width to avoid undefined and/or bad behavior
2773 with outlandish widths.
2774 * character.h (sanitize_tab_width): Rename from sanitize_width,
2775 now that we have two such functions. All uses changed.
2776 (sanitize_char_width): New inline function.
2778 Don't assume that tab-width fits in int.
2779 * character.h (sanitize_width): New inline function.
2780 (SANE_TAB_WIDTH): New macro.
2781 (ASCII_CHAR_WIDTH): Use it.
2782 * indent.c (sane_tab_width): Remove. All uses replaced by
2783 SANE_TAB_WIDTH (current_buffer).
2784 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2786 * fileio.c: Integer overflow issues with file modes.
2787 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2789 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2790 Remove unreachable code.
2791 (read_hex, load_charset_map_from_file): Check for integer overflow.
2793 * xterm.c: Don't go over XClientMessageEvent limit.
2794 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2795 (x_send_scroll_bar_event): Likewise. Check that the size does not
2796 exceed limits imposed by XClientMessageEvent, as well as the usual
2797 ptrdiff_t and size_t limits.
2799 * keyboard.c: Overflow, signedness and related fixes.
2800 (make_lispy_movement): Use same integer type in forward decl
2801 that is used in the definition.
2802 (read_key_sequence, keyremap_step):
2803 Change bufsize argument back to int, undoing my 2011-03-30 change.
2804 We prefer signed types, and int is wide enough here.
2805 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2806 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2807 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2808 length, not size_t. Use ptrdiff_t for index, not int.
2809 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2810 possibility of integer overflow.
2812 Overflow, signedness and related fixes for images.
2814 * dispextern.h (struct it.stack[0].u.image.image_id)
2815 (struct_it.image_id, struct image.id, struct image_cache.size)
2816 (struct image_cache.used, struct image_cache.ref_count):
2817 * gtkutil.c (update_frame_tool_bar):
2818 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2819 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2820 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2821 * nsmenu.m (update_frame_tool_bar):
2822 * xdisp.c (calc_pixel_width_or_height):
2823 * xfns.c (image_cache_refcount):
2824 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2825 on typical 64-bit hosts.
2827 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2828 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2829 Omit unnecessary casts to int.
2830 (parse_image_spec): Check that integers fall into 'int' range
2831 when the callers expect that.
2832 (image_ascent): Redo ascent calculation to avoid int overflow.
2833 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2834 (lookup_image): Remove unnecessary tests.
2835 (xbm_image_p): Locals are now of int, not EMACS_INT,
2836 since parse_image_check makes sure they fit into int.
2837 (png_load, gif_load, svg_load_image):
2838 Prefer int to unsigned where either will do.
2839 (tiff_handler): New function, combining the cores of the
2840 old tiff_error_handler and tiff_warning_handler.
2841 This function is rewritten to use vsnprintf and thereby avoid
2842 stack buffer overflows. It uses only the features of vsnprintf
2843 that are common to both POSIX and native Microsoft.
2844 (tiff_error_handler, tiff_warning_handler): Use it.
2845 (tiff_load, gif_load, imagemagick_load_image):
2846 Don't assume :index value fits in 'int'.
2847 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2848 (imagemagick_load_image): Check that crop parameters fit into
2849 the integer types that MagickCropImage accepts. Don't assume
2850 Vimagemagick_render_type has a nonnegative value. Don't assume
2851 size_t fits in 'long'.
2852 (gs_load): Use printmax_t to print the widest integers possible.
2853 Check for integer overflow when computing image height and width.
2855 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2857 * xdisp.c (redisplay_window): Don't force window start if point
2858 will be invisible in the resulting window. (Bug#9324)
2860 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2862 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2863 the display spec is of the form `(space ...)'.
2864 (handle_display_spec): Return the value returned by
2865 handle_single_display_spec, not just 1 or zero.
2866 (handle_single_display_spec): If the display spec is of the form
2867 `(space ...)', and specifies display in the text area, return 2
2869 (try_cursor_movement): Check for the need to scroll more
2870 accurately, and prefer exact match for point under bidi.
2871 Don't advance `row' beyond the last row of the window.
2873 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2874 into disp_prop; all users changed.
2876 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2877 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2878 for the text covered by the display property.
2880 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2882 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2883 Change return value to nil.
2884 (Frecord_buffer): Delete unused function.
2886 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2888 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2889 buffers, return left-to-right.
2890 (set_cursor_from_row): Consider candidate row a win if its glyph
2891 represents a newline and point is on that newline. Fixes cursor
2892 positioning on the newline at EOL of R2L text within L2R
2893 paragraph, and vice versa.
2894 (try_cursor_movement): Check continued rows, in addition to
2895 continuation rows. Fixes unwarranted scroll when point enters a
2896 continued line of R2L text within an L2R paragraph, or vice versa.
2897 (cursor_row_p): Consider the case of point being equal to
2898 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2899 from the end of a short line to the beginning of a continued line
2900 of R2L text within L2R paragraph.
2901 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2902 composed characters.
2904 * bidi.c (bidi_check_type): Use xassert.
2905 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2908 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2910 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2913 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2915 * nsfont.m (ns_otf_to_script): Fix typo.
2917 2011-08-22 Kenichi Handa <handa@m17n.org>
2919 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2920 extra slot even if the purpose is char-code-property-table.
2922 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2924 * xdisp.c (redisplay_window): When computing centering_position,
2925 account for the height of the header line. (Bug#8874)
2927 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2928 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2929 candidate is selected by the mouse, and that candidate has a
2930 composed character under the mouse.
2932 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2933 coordinates reported by pos-visible-in-window-p for a composed
2934 character in column zero.
2936 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2938 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2940 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2942 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2943 consider it a hit if to_charpos is anywhere in the range of the
2944 composed buffer positions.
2946 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2948 * image.c (gif_load): Don't assume that each subimage has the same
2949 dimensions as the base image. Handle disposal method that is
2950 "undefined" by the gif spec (Bug#9335).
2952 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2954 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2955 (Fcondition_case): Document `debug' symbol in error handler.
2957 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2959 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2960 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2961 from an Org mode buffer to a Speedbar frame.
2963 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2964 a composition, take its buffer position from IT->cmp_it.charpos.
2965 Fixes cursor positioning at the beginning of a line that begins
2966 with a composed character.
2968 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2970 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2971 character bidirectional type, use STRONG_L instead. Fixes crashes
2972 in a buffer produced by `describe-categories'.
2974 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2975 members before the level stack, so they would be saved and
2976 restored when copying iterator state. Fixes incorrect reordering
2977 around TABs covered by display properties.
2979 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2981 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2983 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2985 * eval.c (internal_condition_case, internal_condition_case_1)
2986 (internal_condition_case_2, internal_condition_case_n):
2987 Remove unnecessary aborts (Bug#9081).
2989 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2991 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2992 has no `load' handler, try opening the file locally. (Bug#9311)
2994 2011-08-16 Ken Brown <kbrown@cornell.edu>
2996 * gmalloc.c: Expand comment.
2998 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3000 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3001 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3003 2011-08-16 Ken Brown <kbrown@cornell.edu>
3005 Fix memory allocation problems in Cygwin build (Bug#9273).
3007 * unexcw.c ( __malloc_initialized): Declare external variable.
3008 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3010 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3012 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3014 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3016 [CYGWIN] (special_realloc): New function.
3017 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3018 requests to realloc storage in the static heap.
3020 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3022 * bidi.c (bidi_initialize): Remove unused local.
3024 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3027 * biditype.h: Remove file.
3028 * makefile.w32-in ($(BLD)/bidi.$(O)):
3029 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3031 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3033 * chartab.c: Improve commentary for the uniprop_table API.
3035 * bidi.c (bidi_paragraph_init): Support zero value of
3036 bidi_ignore_explicit_marks_for_paragraph_level.
3037 (bidi_initialize): Use uniprop_table instead of including
3038 biditype.h and bidimirror.h.
3040 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3041 coordinates of the iterator when restoring from ppos_it.
3044 2011-08-14 Kenichi Handa <handa@m17n.org>
3046 * process.c (create_process): Call setup_process_coding_systems
3047 after the pid of the process is set to -1 (Bug#8162).
3049 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3051 * xdisp.c (move_it_in_display_line_to): Don't invoke
3052 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3053 ppos_it. Fixes vertical cursor motion when line beginning is
3054 covered by an image. (Bug#9296)
3056 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3058 * nsterm.h (ns_run_ascript): Declare.
3059 (NSAPP_DATA2_RUNASSCRIPT): Define.
3061 * nsfns.m (as_script, as_result, as_status): New static variables.
3062 (ns_run_ascript): New function.
3063 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3064 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3065 the event loop. Get status from as_status (Bug#7276).
3067 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3068 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3069 the event loop (Bug#7276).
3071 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3073 * gnutls.c (QCgnutls_bootprop_priority)
3074 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3075 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3076 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3077 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3078 (QCgnutls_bootprop_verify_hostname_error)
3079 (QCgnutls_bootprop_callbacks_verify): Rename from
3080 Qgnutls_bootprop_..., all uses changed.
3082 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3085 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3087 * xfaces.c (Qframe_set_background_mode): Now static.
3088 * dispextern.h (Qframe_set_background_mode): Remove decl.
3090 * process.c (Fnetwork_interface_info): Declare local only if needed.
3092 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3094 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3095 (Fnetwork_interface_list): Allocate in increments of bytes instead
3096 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3097 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3099 (struct ifflag_def): notrailers is smart on OSX.
3100 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3101 Get hardware address with getifaddrs if available.
3103 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3105 * xdisp.c (iterate_out_of_display_property): xassert that
3106 IT->position is set to within IT->object's boundaries. Break from
3107 the loop as soon as EOB is reached; avoids infloops in redisplay
3108 when IT->position is set up wrongly due to some bug.
3109 Set IT->current to match the bidi iterator unconditionally.
3110 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3111 entry. Force push_it to save on the stack the current
3112 buffer/string position, to be restored by pop_it. Fix flags in
3113 the iterator structure wrt the object coming from a display
3114 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3115 properties. (Bug#9284)
3117 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3119 * fontset.c (fontset_get_font_group): Add proper type checks.
3122 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3124 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3125 and LC_VERSION_MIN_MACOSX.
3126 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3127 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3129 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3131 * xdisp.c (forward_to_next_line_start): Allow to use the
3132 no-display-properties-and-no-overlays under bidi display.
3133 Set disp_pos in the bidi iterator to avoid searches for display
3134 properties and overlays.
3136 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3138 * editfns.c (Fset_time_zone_rule): Document relationship with the
3141 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3142 the font entity extracted from the cache (Bug#8109).
3144 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3146 * composite.c (autocmp_chars): Don't reset point. That is done by
3147 restore_point_unwind (Bug#5984).
3149 2011-08-07 Juri Linkov <juri@jurta.org>
3151 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3152 to show the arg `TIME' instead of `TIMEVAL'.
3154 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3156 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3157 display property strides EOL and includes a newline, as in
3158 longlines-mode. (Bug#9254)
3159 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3160 word-wrap under bidirectional display. (Bug#9224)
3162 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3163 is non-zero, even if the data buffer is NULL. Fixes a crash in
3164 vertical-motion with longlines-mode. (Bug#9254)
3166 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3168 * bidi.c <bidi_cache_total_alloc>: Now static.
3169 (bidi_initialize): Initialize bidi_cache_total_alloc.
3171 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3174 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3175 amount allocated this far in `bidi_cache_total_alloc'.
3176 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3177 non-zero, only free the data buffer without restoring the cache
3178 contents. All callers changed.
3180 * dispextern.h (bidi_unshelve_cache): Update prototype.
3182 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3183 (move_it_in_display_line, move_it_to)
3184 (move_it_vertically_backward, move_it_by_lines): Replace the call
3185 to xfree to an equivalent call to bidi_unshelve_cache.
3186 (move_it_in_display_line_to): Fix logic of returning
3187 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3189 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3191 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3192 came from a string character with a `cursor' property. (Bug#9229)
3194 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3196 * Makefile.in (LIB_PTHREAD): New variable.
3197 (LIBES): Add LIB_PTHREAD (Bug#9216).
3199 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3200 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3202 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3204 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3206 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3208 * xterm.c (x_find_topmost_parent): New function.
3209 (x_set_frame_alpha): Find topmost parent window with
3210 x_find_topmost_parent and set the property there also (bug#9181).
3211 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3213 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3215 * callproc.c (Fcall_process): Avoid vfork clobbering
3216 the local vars buffer, coding_systems, current_dir.
3218 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3220 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3222 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3224 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3225 so that it is not optimized away.
3227 * xdisp.c (compute_display_string_pos): Remove unused local.
3229 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3231 Fix slow cursor motion and scrolling in large buffers with
3232 selective display, like Org Mode buffers. (Bug#9218)
3234 * dispextern.h (struct bidi_it): New member disp_prop_p.
3236 * xdisp.c: Remove one-slot cache of display string positions.
3237 (compute_display_string_pos): Accept an additional argument
3238 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3239 for a display string or property. If found, set DISP_PROP_P
3242 * bidi.c (bidi_fetch_char): Accept an additional argument
3243 DISP_PROP_P, and pass it to compute_display_string_pos.
3244 Only handle text covered by a display string if DISP_PROP_P is returned
3245 non-zero. All callers of bidi_fetch_char changed.
3247 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3249 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3251 2010-12-03 Don March <don@ohspite.net>
3253 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3254 last character M-[char] is translated to ESC [char] (bug#7541).
3256 2011-08-02 Kenichi Handa <handa@m17n.org>
3258 * lisp.h (uniprop_table): Extern it.
3260 * chartab.c (uniprop_table): Make it non-static.
3262 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3264 * xdisp.c (forward_to_next_line_start): Accept additional argument
3265 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3267 (reseat_at_next_visible_line_start): Use the bidi iterator state
3268 returned by forward_to_next_line_start to restore the state of
3269 it->bidi_it after backing up to previous newline. (Bug#9212)
3271 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3273 * regex.c (re_comp): Protoize.
3274 (re_exec): Fix return type.
3275 (regexec): Fix type of `ret'. (Bug#9203)
3277 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3279 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3280 This is needed if max-image-size is a floating-point number.
3282 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3284 * print.c (print_object): Print empty symbol as ##.
3286 * lread.c (read1): Read ## as empty symbol.
3288 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3290 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3291 setting frame foreground color (Bug#9175).
3292 (x_set_background_color): Likewise.
3294 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3295 contents (Bug#9176).
3296 (EmacsTooltip -init): Remove bezels and add shadows to
3299 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3300 or scroll bar (Bug#8470).
3302 * nsfont.m (nsfont_open): Remove assignment to voffset and
3303 unnecessary vars hshink, expand, hd, full_height, min_height.
3304 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3306 * nsterm.h (nsfont_info): Remove voffset field.
3308 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3310 Implement strike-through and overline on NextStep (Bug#8863).
3312 * nsfont.m (nsfont_open): Use underline position provided by font,
3313 instead of hard-coded value of 2.
3314 (nsfont_draw): Call ns_draw_text_decoration instead.
3316 * nsterm.h: Add declaration for ns_draw_text_decoration.
3318 * nsterm.m (ns_draw_text_decoration): New function for drawing
3319 underline, overline, and strike-through.
3320 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3321 ns_draw_text_decoration. Change treatment of cursor drawing to
3322 accommodate underlining, etc.
3324 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3326 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3329 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3331 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3332 Without this fix, if a signal arrives just after memory fills up,
3333 'malloc' might be invoked reentrantly.
3335 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3336 In other words, assume that every image size is allowed, on non-X
3337 hosts. This assumption is probably wrong, but it lets Emacs compile.
3339 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3341 * regex.c (re_iswctype): Convert return values to boolean.
3343 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3345 * xdisp.c (compute_display_string_pos): Don't use cached display
3346 string position if the buffer had its restriction changed.
3349 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3351 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3353 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3355 Integer signedness and overflow and related fixes. (Bug#9079)
3357 * bidi.c: Integer size and overflow fixes.
3358 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3359 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3360 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3361 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3362 (bidi_find_other_level_edge):
3363 Use ptrdiff_t instead of EMACS_INT where either will do.
3364 This works better on 32-bit hosts configured --with-wide-int.
3365 (bidi_cache_ensure_space): Check for size-calculation overflow.
3366 Use % rather than repeated addition, for better worst-case speed.
3367 Don't set bidi_cache_size until after xrealloc returns, because it
3369 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3370 (bidi_cache_ensure_space): Also check that the bidi cache size
3371 does not exceed that of the largest Lisp string or buffer. See Eli
3372 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3374 * alloc.c (__malloc_size_t): Remove.
3375 All uses replaced by size_t. See Andreas Schwab's note
3376 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3378 * image.c: Improve checking for integer overflow.
3379 (check_image_size): Assume that f is nonnull, since
3380 it is always nonnull in practice. This is one less thing to
3381 worry about when checking for integer overflow later.
3382 (x_check_image_size): New function, which checks for integer
3383 overflow issues inside X.
3384 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3385 This removes the need for a memory_full check.
3386 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3387 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3388 (xbm_read_bitmap_data): Change locals back to 'int', since
3389 their values must fit in 'int'.
3390 (xpm_load_image, png_load, tiff_load):
3391 Invoke x_create_x_image_and_pixmap earlier,
3392 to avoid much needless work if the image is too large.
3393 (tiff_load): Treat overly large images as if
3394 x_create_x_image_and_pixmap failed, not as malloc failures.
3395 (gs_load): Use x_check_image_size.
3397 * gtkutil.c: Omit integer casts.
3398 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3399 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3401 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3403 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3404 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3405 would wrongly return t on a 64-bit host.
3407 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3408 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3409 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3410 and therefore cause GCC to emit a bogus diagnostic in some cases.
3412 * image.c: Integer signedness and overflow and related fixes.
3413 This is not an exhaustive set of fixes, but it's time to
3414 record what I've got.
3415 (lookup_pixel_color, check_image_size): Remove redundant decls.
3416 (check_image_size): Don't assume that arbitrary EMACS_INT values
3417 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3418 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3419 (tiff_load, imagemagick_load_image):
3420 Check for overflow in size calculations.
3421 (x_create_x_image_and_pixmap): Remove unnecessary test for
3422 xmalloc returning NULL; that can't happen.
3423 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3424 (xpm_color_bucket): Use better integer hashing function.
3425 (xpm_cache_color): Don't possibly over-allocate memory.
3426 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3427 (gif_memory_source):
3428 Use ptrdiff_t, not int or size_t, to record sizes.
3429 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3430 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3431 either works, as we prefer signed integers.
3432 (tiff_read_from_memory, tiff_write_from_memory):
3433 Return tsize_t, not size_t, since that's what the TIFF API wants.
3434 (tiff_read_from_memory): Don't fail simply because the read would
3435 go past EOF; instead, return a short read.
3436 (tiff_load): Omit no-longer-needed casts.
3437 (Fimagemagick_types): Don't assume size fits into 'int'.
3439 Improve hashing quality when configured --with-wide-int.
3440 * fns.c (hash_string): New function, taken from sxhash_string.
3441 Do not discard information about ASCII character case; this
3442 discarding is no longer needed.
3443 (sxhash-string): Use it. Change sig to match it. Caller changed.
3444 * lisp.h: Declare it.
3445 * lread.c (hash_string): Remove, since we now use fns.c's version.
3446 The fns.c version returns a wider integer if --with-wide-int is
3447 specified, so this should help the quality of the hashing a bit.
3449 * emacs.c: Integer overflow minor fix.
3450 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3451 Define only if GNU_LINUX.
3452 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3454 * dispnew.c: Integer signedness and overflow fixes.
3455 Remove unnecessary forward decls, that were a maintenance hassle.
3456 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3458 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3459 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3460 (prepare_desired_row, line_draw_cost):
3461 Use int, not unsigned, where either works.
3462 (save_current_matrix, restore_current_matrix):
3463 Use ptrdiff_t, not size_t, where either works.
3464 (init_display): Check for overflow more accurately, and without
3465 relying on undefined behavior.
3467 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3468 Remove, replacing with the new symbols in lisp.h. All uses changed.
3469 * fileio.c (make_temp_name):
3470 * filelock.c (lock_file_1, lock_file):
3471 * xdisp.c (message_dolog):
3472 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3473 Use pMd etc. instead.
3474 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3475 replacing the pWIDE etc. symbols removed from editfns.c.
3477 * keyboard.h (num_input_events): Now uintmax_t.
3478 This is (very slightly) less likely to mess up due to wraparound.
3481 * buffer.c: Integer signedness fixes.
3482 (alloc_buffer_text, enlarge_buffer_text):
3483 Use ptrdiff_t rather than size_t when either will do, as we prefer
3486 * alloc.c: Integer signedness and overflow fixes.
3487 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3488 (__malloc_size_t): Default to size_t, not to int.
3489 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3490 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3491 Prefer ptrdiff_t to size_t when either would do, as we prefer
3493 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3494 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3495 Now const. Initialize with values that are in range even if char
3497 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3498 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3499 These functions do the right thing with sizes > 2**32.
3500 (check_depth): Now ptrdiff_t, not int.
3501 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3502 Adjust to new way of storing sizes. Check for size overflow bugs
3504 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3505 slightly wrong anyway, as it missed one instance of
3506 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3507 (refill_memory_reserve): Omit needless cast to size_t.
3508 (mark_object_loop_halt): Mark as externally visible.
3510 * xselect.c: Integer signedness and overflow fixes.
3511 (Fx_register_dnd_atom, x_handle_dnd_message):
3512 Use ptrdiff_t, not size_t, since we prefer signed.
3513 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3514 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3515 x_dnd_atoms_size and x_dnd_atoms_length.
3517 * doprnt.c: Prefer signed to unsigned when either works.
3519 * doprnt.c (doprnt):
3521 * xdisp.c (vmessage):
3522 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3523 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3524 prefer signed arithmetic to avoid comparison confusion.
3525 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3526 but is a bit tricky.
3528 Assume freestanding C89 headers, string.h, stdlib.h.
3529 * data.c, doprnt.c, floatfns.c, print.c:
3530 Include float.h unconditionally.
3531 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3532 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3533 * regex.c: Likewise for stddef.h, string.h.
3534 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3535 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3536 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3537 (STDC_HEADERS): Remove obsolete defines.
3538 * sysdep.c: Include limits.h unconditionally.
3540 Assume support for memcmp, memcpy, memmove, memset.
3541 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3542 * regex.c (memcmp, memcpy):
3543 Remove; we assume C89 now.
3545 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3546 (__malloc_safe_bcopy): Remove; no longer needed.
3548 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3549 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3550 well either way, and we prefer signed to unsigned.
3552 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3554 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3555 closes the connection while we're reading (bug#9182).
3557 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3559 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3560 are specified (Bug#9168).
3562 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3564 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3565 Found by GCC static checking and --with-wide-int on a 32-bit host.
3567 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3569 * xdisp.c (compute_display_string_pos): Fix logic of caching
3570 previous display string position. Initialize cached_prev_pos to
3571 -1. Fixes slow-down at the beginning of a buffer.
3573 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3575 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3576 for attrs[LFACE_FONTSET_INDEX].
3578 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3580 * xml.c (parse_region): Remove unused local
3581 that was recently introduced.
3583 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3585 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3586 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3588 * xdisp.c (move_it_in_display_line_to): Record the best matching
3589 position for TO_CHARPOS while scanning the line, and restore it on
3590 exit if none of the characters scanned was an exact match.
3591 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3592 when exact match is impossible due to invisible text, and the
3593 lines are truncated.
3595 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3597 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3600 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3602 Fix a significant slow-down of cursor motion with C-n, C-p,
3603 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3604 auto-repeat under bidi redisplay in fontified buffers.
3605 * xdisp.c (compute_stop_pos_backwards): New function.
3606 (next_element_from_buffer): Call compute_stop_pos_backwards to
3607 find a suitable prev_stop when we find ourselves before
3609 (reseat): Don't look for prev_stop, as that could mean a very long
3611 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3612 <cached_disp_overlay_modiff>: Cache for last found display string
3614 (compute_display_string_pos): Return the cached position if asked
3615 about the same buffer in the same area of character positions, and
3616 the buffer wasn't changed since the time the display string
3617 position was cached.
3619 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3621 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3622 is an integer, which is important for empty lines. (Bug#9149)
3624 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3626 * frame.c (Fmodify_frame_parameters): In tty case, update the
3627 default face if necessary (Bug#4238).
3629 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3631 * editfns.c (Fstring_to_char): No need to explain what a character
3632 is in the docstring (Bug#6576).
3634 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3636 * xml.c (parse_region): Make sure we always return a tree.
3638 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3640 * xml.c (parse_region): If a document contains only comments,
3643 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3645 * xml.c (make_dom): Return comments, too.
3647 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3650 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3651 and the surrounding thread.
3652 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3653 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3654 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3656 * s/openbsd.h (BROKEN_SIGIO): Define.
3657 * unexelf.c (unexec) [__OpenBSD__]:
3658 Don't update the .mdebug section of the Alpha COFF symbol table.
3660 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3662 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3665 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3667 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3668 This fixes some race conditions on the permissions of any newly
3671 * alloc.c (valid_pointer_p): Use pipe, not open.
3672 This fixes some permissions issues when debugging.
3674 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3675 If fchown fails to set both uid and gid, try to set just gid,
3676 as that is sometimes allowed. Adjust the file's mode to eliminate
3677 setuid or setgid bits that are inappropriate if fchown fails.
3679 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3681 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3682 to compare Lisp_Objects.
3683 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3684 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3685 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3687 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3689 * lread.c (read_integer): Unread even EOF character.
3690 (read1): Likewise. Properly record start position of symbol.
3692 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3693 symbol character follows.
3695 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3697 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3698 This works around a problem with the previous change to Fcopy_file.
3699 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3700 and without this change, GCC might complain about discarding
3701 fchown's return value.
3703 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3705 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3707 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3709 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3711 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3713 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3714 it's used from the C level.
3716 * process.c: Use the same condition for POLL_FOR_INPUT in both
3717 keyboard.c and process.c (bug#1858).
3719 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3721 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3722 (Fgnutls_boot): Use it.
3724 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3726 * doc.c (Fsubstitute_command_keys): Revert last change.
3728 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3730 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3731 quotes the next character, and doesn't affect other longer
3732 sequences (bug#8935).
3734 * lread.c (syms_of_lread): Clarify that is isn't only
3735 `eval-buffer' and `eval-defun' that's affected by
3736 `lexical-binding' (bug#8460).
3738 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3740 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3741 bidi redisplay when a line includes both an image and is truncated.
3743 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3745 Fix minor problems found by static checking.
3746 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3747 (elsz): Now a signed constant, not a size_t var. We prefer signed
3748 types to unsigned, to avoid integer comparison confusion. Without
3749 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3750 "cannot optimize loop, the loop counter may overflow", a symptom
3752 * indent.c (Fvertical_motion): Mark locals as initialized.
3753 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3755 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3757 * search.c (Fre_search_backward): Mention `case-fold-search' in
3758 all the re_search_* functions (bug#8138).
3760 * keyboard.c (Fopen_dribble_file): Document when the file is
3763 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3765 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3768 Support bidi reordering of display and overlay strings.
3769 * xdisp.c (compute_display_string_pos)
3770 (compute_display_string_end): Accept additional argument STRING.
3771 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3772 (reseat_to_string): Initialize bidi_it->string.s and
3773 bidi_it->string.schars.
3774 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3775 NULL (avoids a crash in bidi_paragraph_init).
3776 Initialize itb.string.lstring.
3777 (init_iterator): Call bidi_init_it only of a valid
3778 buffer position was specified. Initialize paragraph_embedding to
3780 (reseat_to_string): Initialize the bidi iterator.
3781 (display_string): If we need to ignore text properties of
3782 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3783 original value of -1 will not work with bidi.)
3784 (compute_display_string_pos): First arg is now struct
3785 `text_pos *'; all callers changed. Support display properties on
3787 (compute_display_string_end): Support display properties on Lisp
3789 (init_iterator, reseat_1, reseat_to_string): Initialize the
3790 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3791 when iterating on a string not from display properties).
3792 (compute_display_string_pos, compute_display_string_end):
3793 Fix calculation of the object to scan. Fixes an error when using
3795 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3796 base_level_stop; instead, set base_level_stop to BEGV.
3797 Fixes crashes in vertical-motion.
3798 (next_element_from_buffer): Improve commentary for when
3799 the iterator is before prev_stop.
3800 (init_iterator): Initialize bidi_p from the default value of
3801 bidi-display-reordering, not from buffer-local value. Use the
3802 buffer-local value only if initializing for buffer iteration.
3803 (handle_invisible_prop): Support invisible properties on strings
3804 that are being bidi-reordered.
3805 (set_iterator_to_next): Support bidi reordering of C strings and
3807 (next_element_from_string): Support bidi reordering of Lisp
3809 (handle_stop_backwards): Support Lisp strings as well.
3810 (display_string): Support display of R2L glyph rows.
3811 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3812 (init_iterator): Don't initialize it->bidi_p for strings
3814 (reseat_to_string): Initialize it->bidi_p for strings here.
3815 (next_element_from_string, next_element_from_c_string)
3816 (next_element_from_buffer): Add xassert's for correspondence
3817 between IT's object being iterated and it->bidi_it.string
3819 (face_before_or_after_it_pos): Support bidi iteration.
3820 (next_element_from_c_string): Handle the case of the first string
3821 character that is not the first one in the visual order.
3822 (get_visually_first_element): New function, refactored from common
3823 parts of next_element_from_buffer, next_element_from_string, and
3824 next_element_from_c_string.
3825 (tool_bar_lines_needed, redisplay_tool_bar)
3826 (display_menu_bar): Force left-to-right direction. Add a FIXME
3827 comment for making that be controlled by a user option.
3828 (push_it, pop_it): Save and restore the state of the
3829 bidi iterator. Save and restore the bidi_p flag.
3830 (pop_it): Iterate out of display property for string iteration as
3832 (iterate_out_of_display_property): Support iteration over strings.
3833 (handle_single_display_spec): Set up it->bidi_it for iteration
3834 over a display string, and call bidi_init_it.
3835 (handle_single_display_spec, next_overlay_string)
3836 (get_overlay_strings_1, push_display_prop): Set up the bidi
3837 iterator for displaying display or overlay strings.
3838 (forward_to_next_line_start): Don't use the shortcut if
3840 (back_to_previous_visible_line_start): If handle_display_prop
3841 pushed the iterator stack, restore the internal state of the bidi
3842 iterator by calling bidi_pop_it same number of times.
3843 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3844 and we are bidi-iterating, don't decrement the iterator position;
3845 instead, set the first_elt flag in the bidi iterator, to produce
3847 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3848 (push_display_prop): xassert that we are iterating a buffer.
3849 (push_it, pop_it): Save and restore paragraph_embedding member.
3850 (handle_single_display_spec, next_overlay_string)
3851 (get_overlay_strings_1, reseat_1, reseat_to_string)
3852 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3853 correctly. Don't assume unibyte strings are not bidi-reordered.
3854 (compute_display_string_pos)
3855 (compute_display_string_end): Fix handling the case of C string.
3856 (push_it, pop_it): Save and restore from_disp_prop_p.
3857 (handle_single_display_spec, push_display_prop): Set the
3858 from_disp_prop_p flag.
3859 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3860 (pop_it): Call iterate_out_of_display_property only if we are
3861 popping after iteration over a string that came from a display
3862 property. Fix a typo in popping stretch info. Add an assertion
3863 for verifying that the iterator position is in sync with the bidi
3865 (handle_single_display_spec, get_overlay_strings_1)
3866 (push_display_prop): Fix initialization of paragraph direction for
3867 string when that of the parent object is not yet determined.
3868 (reseat_1): Call bidi_init_it to resync the bidi
3869 iterator with IT's position. (Bug#7616)
3870 (find_row_edges): If ROW->start.pos gives position
3871 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3872 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3873 Reset the from_disp_prop_p flag.
3874 (SAVE_IT, RESTORE_IT): New macros.
3875 (pos_visible_p, face_before_or_after_it_pos)
3876 (back_to_previous_visible_line_start)
3877 (move_it_in_display_line_to, move_it_in_display_line)
3878 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3879 (try_scrolling, redisplay_window, display_line): Use them when
3880 saving a temporary copy of the iterator and restoring it back.
3881 (back_to_previous_visible_line_start, reseat_1)
3882 (init_iterator): Empty the bidi cache "stack".
3883 (move_it_in_display_line_to): If iterator ended up at
3884 EOL, but we never saw any buffer positions smaller than
3885 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3886 motion in bidi-reordered lines.
3887 (move_it_in_display_line_to): Record prev_method and prev_pos
3888 immediately before the call to set_iterator_to_next. Fixes cursor
3889 motion in bidi-reordered lines with stretch glyphs and strings
3890 displayed in margins. (Bug#8133) (Bug#8867)
3891 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3893 (pos_visible_p): Support positions in bidi-reordered lines.
3894 Save and restore bidi cache.
3896 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3897 (bidi_paragraph_info): Delete unused struct.
3898 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3899 (bidi_cache_start): New variable.
3900 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3902 (bidi_cache_fetch_state, bidi_cache_search)
3903 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3904 (bidi_cache_find, bidi_peek_at_next_level)
3905 (bidi_level_of_next_char, bidi_find_other_level_edge)
3906 (bidi_move_to_visually_next): Compare cache index with
3907 bidi_cache_start rather than with zero.
3908 (bidi_fetch_char): Accept new argument STRING; all callers
3909 changed. Support iteration over a string. Support strings with
3910 display properties. Support unibyte strings. Fix the type of
3911 `len' according to what STRING_CHAR_AND_LENGTH expects.
3912 (bidi_paragraph_init, bidi_resolve_explicit_1)
3913 (bidi_resolve_explicit, bidi_resolve_weak)
3914 (bidi_level_of_next_char, bidi_move_to_visually_next):
3915 Support iteration over a string.
3916 (bidi_set_sor_type, bidi_resolve_explicit_1)
3917 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3918 can now be zero (for strings); special values 0 and -1 were
3919 changed to -1 and -2, respectively.
3920 (bidi_char_at_pos): New function.
3921 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3922 Call it instead of FETCH_MULTIBYTE_CHAR.
3923 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3924 initialized to valid values.
3925 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3927 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3928 the test for valid cached positions. Fix the logic for looking up
3929 the sentinel state in the cache. GCPRO the Lisp string we are
3931 (bidi_push_it, bidi_pop_it): New functions.
3932 (bidi_initialize): Initialize the bidi cache start stack pointer.
3933 (bidi_cache_ensure_space): New function, refactored from part of
3934 bidi_cache_iterator_state. Don't assume the required size is just
3935 one BIDI_CACHE_CHUNK away.
3936 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3937 (bidi_count_bytes, bidi_char_at_pos): New functions.
3938 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3939 always valid if bidi_cache_idx is valid.
3940 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3941 is valid if it's going to be used.
3942 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3943 (bidi_cache_fetch_state, bidi_cache_search)
3944 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3945 (bidi_cache_iterator_state, bidi_cache_find)
3946 (bidi_find_other_level_edge, bidi_cache_start_stack):
3947 All variables related to cache indices are now EMACS_INT.
3949 * dispextern.h (struct bidi_string_data): New structure.
3950 (struct bidi_it): New member `string'. Make flag members be 1-bit
3951 fields, and put them last in the struct.
3952 (compute_display_string_pos, compute_display_string_end):
3954 (bidi_push_it, bidi_pop_it): Add prototypes.
3955 (struct iterator_stack_entry): New members bidi_p,
3956 paragraph_embedding, and from_disp_prop_p.
3957 (struct it): Member bidi_p is now a bit field 1 bit wide.
3958 (bidi_shelve_cache, bidi_unshelve_cache):
3961 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3962 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3963 and vector-like objects.
3965 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3966 cache around display iteration.
3968 * window.c (Fwindow_end, window_scroll_pixel_based)
3969 (displayed_window_lines, Frecenter): Save and restore the bidi
3970 cache around display iteration.
3972 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3974 * editfns.c (Fdelete_region): Clarify the use of the named
3975 parameters (bug#6788).
3977 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3979 * indent.c (Fvertical_motion): Set and restore w->pointm when
3980 saving and restoring the window's buffer (Bug#9006).
3982 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3984 * editfns.c (Fstring_to_char): Clarify just what is returned
3985 (bug#6576). Text by Eli Zaretskii.
3987 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3989 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3991 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3993 * buffer.c (mmap_find): Fix a typo.
3995 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3997 Fix execution of x selection hooks.
3998 * xselect.c (Qx_lost_selection_functions)
3999 (Qx_sent_selection_functions): New vars.
4000 (syms_of_xselect): DEFSYM them.
4001 (x_handle_selection_request): Pass Qx_sent_selection_functions
4002 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4003 (x_handle_selection_clear,x_clear_frame_selections):
4004 Pass Qx_lost_selection_functions rather than
4005 Vx_lost_selection_functions to Frun_hook_with_args.
4007 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4009 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4010 The old code sometimes used this field without initializing it.
4012 * alloc.c (gc_sweep): Don't read past end of array.
4013 In theory, the old code could also have corrupted Emacs internals,
4014 though it'd be very unlikely.
4016 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4018 * character.c (Fcharacterp): Don't advertise optional ignored
4019 argument. (Bug#4026)
4021 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4023 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4026 * window.c (Fset_window_start): Doc fix (bug#4199).
4027 (Fset_window_hscroll): Ditto.
4029 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4031 Fix minor new problems caught by GCC 4.6.1.
4032 * term.c (init_tty): Remove unused local.
4033 * xsettings.c (store_monospaced_changed): Define this function only
4034 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4037 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4039 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4041 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4043 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4044 are the mini-buffer and the echo area (bug#3320).
4046 * term.c (init_tty): Remove support for supdup, c10 and perq
4047 terminals, which are no longer supported (bug#1482).
4049 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4051 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4053 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4055 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4056 for non-popups (Bug#3642).
4058 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4060 * alloc.c (reset_malloc_hooks): Protoize.
4061 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4062 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4063 * cm.c (losecursor): Likewise.
4064 * data.c (fmod): Likewise.
4065 * dispnew.c (swap_glyphs_in_rows): Likewise.
4066 * emacs.c (memory_warning_signal): Likewise.
4067 * floatfns.c (float_error): Likewise.
4068 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4069 (otf_open, font_otf_capability, generate_otf_features)
4070 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4072 * image.c (pbm_read_file): Likewise.
4073 * indent.c (string_display_width): Likewise.
4074 * intervals.c (check_for_interval, search_for_interval)
4075 (inc_interval_count, count_intervals, root_interval)
4076 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4077 * lread.c (defalias): Likewise.
4078 * ralloc.c (r_alloc_check): Likewise.
4079 * regex.c (set_image_of_range_1, set_image_of_range)
4080 (regex_grow_registers): Likewise.
4081 * sysdep.c (strerror): Likewise.
4082 * termcap.c (valid_filename_p, tprint, main): Likewise.
4083 * tparam.c (main): Likewise.
4084 * unexhp9k800.c (run_time_remap, save_data_space)
4085 (update_file_ptrs, read_header, write_header, calculate_checksum)
4086 (copy_file, copy_rest, display_header): Likewise.
4087 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4089 * xdisp.c (check_it): Likewise.
4090 * xfaces.c (register_color, unregister_color, unregister_colors):
4092 * xfns.c (print_fontset_result): Likewise.
4093 * xrdb.c (member, fatal, main): Likewise.
4095 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4097 Fix minor problems found by static checking (Bug#9031).
4098 * chartab.c (char_table_set_range, map_sub_char_table):
4099 Remove unused locals.
4100 (uniprop_table): Now static.
4101 * composite.c (_work_char): Remove unused static var.
4103 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4105 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4107 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4109 * gtkutil.c (qttip_cb): Remove code without function.
4111 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4113 * w32.c (pthread_sigmask): New stub.
4115 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4117 Use pthread_sigmask, not sigprocmask (Bug#9010).
4118 sigprocmask is portable only for single-threaded applications, and
4119 Emacs can be multi-threaded when it uses GTK.
4120 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4122 * callproc.c (Fcall_process):
4123 * process.c (create_process):
4124 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4125 Use pthread_sigmask, not sigprocmask.
4127 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4129 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4130 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4133 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4135 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4136 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4137 (xg_hide_tooltip): Fix comment.
4139 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4140 in registerServicesMenuSendTypes.
4141 (validRequestorForSendType): Don't check ns_return_types.
4143 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4146 2011-07-08 Jason Rumney <jasonr@gnu.org>
4148 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4149 SH_SHOW for hidden windows (Bug#5482).
4151 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4152 frame struct members of non-existent frames (Bug#6284).
4154 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4156 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4157 variable firstTime not needed on OSX >= 10.6.
4158 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4159 >= 10.5. Use setKnobProportion, setDoubleValue.
4161 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4162 (MAC_OS_X_VERSION_10_5): Define if not defined.
4163 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4164 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4165 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4167 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4168 cString and lossyCString on OSX >= 10.4
4170 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4171 sizeToFit on OSX >= 10.2.
4173 * nsimage.m (allocInitFromFile): Don't use deprecated method
4174 bestRepresentationForDevice on OSX >= 10.6.
4176 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4179 * emacs.c: Declare unexec_init_emacs_zone.
4181 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4183 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4185 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4186 on svcsMenu (Bug#8842).
4188 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4190 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4192 * nsterm.m (QUTF8_STRING): Declare.
4193 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4194 (validRequestorForSendType): Return type is (id).
4195 Change indexOfObjectIdenticalTo to indexOfObject.
4196 Check if we have local selection before returning self (Bug#8842).
4197 (writeSelectionToPasteboard): Put local selection into paste board
4198 if we have a local selection (Bug#8842).
4199 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4201 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4202 (ns_get_local_selection): Declare.
4204 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4206 * keymap.c (describe_map_tree): Don't insert a double newline at
4207 the end of the buffer (bug#1169) and return whether we inserted
4210 * callint.c (Fcall_interactively): Change "reading args" to
4211 "providing args" to try to clarify what it does (bug#1010).
4213 2011-07-07 Kenichi Handa <handa@m17n.org>
4215 * composite.c (composition_compute_stop_pos): Ignore a static
4216 composition starting before CHARPOS (Bug#8915).
4218 * xdisp.c (handle_composition_prop): Likewise.
4220 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4222 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4225 2011-07-07 Kenichi Handa <handa@m17n.org>
4227 * character.h (unicode_category_t): New enum type.
4229 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4230 (Qchar_code_property_table): New variable.
4231 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4232 (UNIPROP_COMPRESSED_FORM_P): New macros.
4233 (char_table_ascii): Uncompress the compressed values.
4234 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4235 Uncompress the compressed values.
4236 (sub_char_table_ref_and_range): Likewise.
4237 (char_table_ref_and_range): Uncompress the compressed values.
4238 (sub_char_table_set): New arg is_uniprop. Callers changed.
4239 Uncompress the compressed values.
4240 (sub_char_table_set_range): Args changed. Callers changed.
4241 (char_table_set_range): Adjuted for the above change.
4242 (map_sub_char_table): Delete args default_val and parent. Add arg
4243 top. Give decoded values to a Lisp function.
4244 (map_char_table): Adjust for the above change. Give decoded
4245 values to a Lisp function. Gcpro more variables.
4246 (uniprop_table_uncompress)
4247 (uniprop_decode_value_run_length): New functions.
4248 (uniprop_decoder, uniprop_decoder_count): New variables.
4249 (uniprop_get_decoder, uniprop_encode_value_character)
4250 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4252 (uniprop_encoder, uniprop_encoder_count): New variables.
4253 (uniprop_get_encoder, uniprop_table)
4254 (Funicode_property_table_internal, Fget_unicode_property_internal)
4255 (Fput_unicode_property_internal): New functions.
4256 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4257 Sunicode_property_table_internal, Sget_unicode_property_internal,
4258 and Sput_unicode_property_internal. Defvar_lisp
4259 char-code-property-alist.
4261 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4262 Vunicode_category_table.
4264 * font.c (font_range): Adjust for the change of
4265 Vunicode_category_table.
4267 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4269 * m/iris4d.h: Remove file, move contents ...
4270 * s/irix6-5.h: ... here.
4272 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4274 Remove unportable assumption about struct layout (Bug#8884).
4275 * alloc.c (mark_buffer):
4276 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4277 (clone_per_buffer_values): Don't assume that
4278 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4279 This isn't true in general, and it's particularly not true
4280 if Emacs is configured with --with-wide-int.
4281 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4282 New macros, used in the buffer.c change.
4284 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4286 * xsettings.c: Use both GConf and GSettings if both are available.
4287 (store_config_changed_event): Add comment.
4288 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4289 (store_tool_bar_style_changed): New functions.
4290 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4291 (struct xsettings): Move font inside HAVE_XFT.
4292 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4293 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4294 Move inside HAVE_XFT.
4295 (something_changed_gsettingsCB): Rename from something_changedCB.
4296 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4298 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4299 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4300 (something_changed_gconfCB): Rename from something_changedCB.
4301 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4302 (parse_settings): Move check for font inside HAVE_XFT.
4303 (read_settings, apply_xft_settings): Add comment.
4304 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4305 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4306 call store_font_name_changed.
4307 (xft_settings_event): Add comment.
4308 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4309 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4310 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4311 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4312 (xsettings_initialize): Call init_gsettings last.
4313 (xsettings_get_system_font, xsettings_get_system_normal_font):
4316 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4318 Random fixes. E.g., (random) never returned negative values.
4319 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4320 subseconds part to the entropy, as that's a bit more random.
4321 Prefer signed to unsigned, since the signedness doesn't matter and
4322 in general we prefer signed. When given a limit, use a
4323 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4324 latter isn't right if USE_2_TAGS_FOR_INTS.
4325 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4326 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4328 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4330 * textprop.c (text_property_stickiness):
4331 Obey Vtext_property_default_nonsticky.
4332 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4333 * w32fns.c (syms_of_w32fns):
4334 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4336 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4338 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4339 This is more efficient than Ffile_directory_p and avoids a minor race.
4341 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4343 * buffer.c (Foverlay_put): Say what the return value is
4346 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4347 is a directory before asking whether to use the file name
4349 (barf_or_query_if_file_exists): Make the "File is a directory"
4350 error be more correct.
4352 * fns.c (Frequire): Remove the mention of the .gz files, since
4353 that's installation-specific, but keep the mention of
4354 `get-load-suffixes'.
4356 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4358 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4359 Report string overflow if the output is too long.
4361 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4363 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4364 (syms_of_gnutls): Remove duplicate DEFSYM for
4365 Qgnutls_bootprop_verify_hostname_error, an error for
4366 Qgnutls_bootprop_verify_error (which is no longer used).
4368 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4369 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4370 Also (re)move comments that are misplaced or no longer relevant.
4372 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4374 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4376 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4378 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4379 and background color parameters if they have been changed.
4381 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4383 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4385 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4387 * xsettings.c (SYSTEM_FONT): Define only when used.
4388 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4390 * keymap.c (access_keymap_1): Now static.
4392 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4394 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4395 leave any prefix arg for the up event (Bug#1586).
4397 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4399 * lread.c (syms_of_lread): Mention single symbols defined by
4400 `defvar' or `defconst' (bug#7154).
4402 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4403 (Frequire): Mention get-load-suffixes.
4405 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4407 * window.h (window): Remove clone_number slot.
4408 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4410 (make_parent_window, make_window, saved_window)
4411 (Fset_window_configuration, save_window_save): Don't deal with
4413 * buffer.c (Qclone_number): Remove declaration.
4414 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4416 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4418 Add multiple inheritance to keymaps.
4419 * keymap.c (Fmake_composed_keymap): New function.
4420 (Fset_keymap_parent): Simplify.
4421 (fix_submap_inheritance): Remove.
4422 (access_keymap_1): New function extracted from access_keymap to handle
4423 embedded parents and handle lists of maps.
4424 (access_keymap): Use it.
4425 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4426 (Fcopy_keymap): Handle embedded parents.
4427 (Fcommand_remapping, define_as_prefix): Simplify.
4428 (Fkey_binding): Simplify.
4429 (syms_of_keymap): Move minibuffer-local-completion-map,
4430 minibuffer-local-filename-completion-map,
4431 minibuffer-local-must-match-map, and
4432 minibuffer-local-filename-must-match-map to Elisp.
4433 (syms_of_keymap): Defsubr make-composed-keymap.
4434 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4435 (parse_menu_item): Trivial simplification.
4437 2011-07-01 Glenn Morris <rgm@gnu.org>
4439 * Makefile.in (SETTINGS_LIBS): Fix typo.
4441 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4443 * coding.c (Fencode_coding_string): Record the last coding system
4444 used, as the function doc string says (bug#8738).
4446 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4448 * xsettings.c (store_monospaced_changed): Take new font as arg and
4449 check for change against current_mono_font.
4450 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4451 (emacs_settings_constructor, emacs_settings_get_property)
4452 (emacs_settings_set_property, emacs_settings_class_init)
4453 (emacs_settings_init, gsettings_obj): Remove.
4454 (something_changedCB): New function for HAVE_GSETTINGS.
4455 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4456 with value as argument.
4457 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4458 g_settings_new (Bug#8967). Do not create gsettings_obj.
4459 Remove calls to g_settings_bind. Connect something_changedCB to
4462 * xgselect.c: Add defined (HAVE_GSETTINGS).
4463 (xgselect_initialize): Ditto.
4465 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4466 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4469 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4471 * eval.c (struct backtrace): Simplify and port the data structure.
4472 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4473 signed bit field, as this assumption is not portable and it makes
4474 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4475 "char debug_on_exit : 1" as this is not portable either; instead,
4476 use the portable "unsigned int debug_on_exit : 1". Remove unused
4477 member evalargs. Remove obsolete comments about cc bombing out.
4479 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4481 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4482 Let HAVE_GSETTINGS override HAVE_GCONF.
4483 (store_monospaced_changed): New function.
4484 (EMACS_SETTINGS): A new type derived from GObject to handle
4485 GSettings notifications.
4486 (emacs_settings_constructor, emacs_settings_get_property)
4487 (emacs_settings_set_property, emacs_settings_class_init):
4489 (gsettings_client, gsettings_obj): New variables.
4490 (GSETTINGS_SCHEMA): New define.
4491 (something_changedCB): Call store_monospaced_changed.
4492 (init_gsettings): New function.
4493 (xsettings_initialize): Call init_gsettings.
4494 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4497 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4500 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4502 * window.c (resize_root_window, grow_mini_window)
4503 (shrink_mini_window): Rename Qresize_root_window to
4504 Qwindow_resize_root_window and Qresize_root_window_vertically to
4505 Qwindow_resize_root_window_vertically.
4507 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4509 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4511 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4513 * makefile.w32-in: Redesign dependencies so they reflect more
4514 clearly which files are directly included by each source file,
4515 and not through other includes.
4517 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4519 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4520 (sort_overlays, overlay_strings): When an overlay's clone number
4521 matches the window's clone number process the overlay even if
4522 the overlay's window property doesn't match the current window.
4524 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4525 (Fwindow_hchild): Rename to Fwindow_left_child.
4526 (Fwindow_next): Rename to Fwindow_next_sibling.
4527 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4528 (resize_window_check): Rename to window_resize_check.
4529 (resize_window_apply): Rename to window_resize_apply.
4530 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4531 (Fdelete_other_windows_internal, resize_frame_windows)
4532 (Fsplit_window_internal, Fdelete_window_internal)
4533 (grow_mini_window, shrink_mini_window)
4534 (Fresize_mini_window_internal): Fix callers accordingly.
4536 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4538 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4539 (emacs_fixed_set_min_size): Remove.
4540 (emacs_fixed_new): Take frame as argument.
4542 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4543 (_EmacsFixedPrivate): Remove minwidth/height.
4544 Add struct frame *f.
4545 (emacs_fixed_init): Initialize priv->f.
4546 (get_parent_class, emacs_fixed_set_min_size): Remove.
4547 (emacs_fixed_new): Set priv->f to argument.
4548 (emacs_fixed_get_preferred_width)
4549 (emacs_fixed_get_preferred_height): Use min_width/height from
4550 frames size_hint to set minimum and natural (Bug#8919).
4551 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4552 and use min_width/height from frames size_hint to set
4553 min_width/height (Bug#8919).
4555 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4556 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4559 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4561 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4562 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4565 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4567 * process.c (wait_reading_process_output): Bypass select if
4568 waiting for a cell while ignoring keyboard input, and input is
4569 pending. Suggested by Jan Djärv (Bug#8869).
4571 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4573 Use gnulib's dup2 module instead of rolling our own.
4574 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4576 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4578 * dispnew.c (scrolling_window): Before scrolling, turn off a
4579 mouse-highlight in the window being scrolled.
4581 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4583 Move DEFSYM to lisp.h and use everywhere.
4585 * character.h (DEFSYM): Move declaration...
4586 * lisp.h (DEFSYM): ...here.
4592 * w32select.c: Don't include character.h.
4594 * alloc.c (syms_of_alloc):
4595 * buffer.c (syms_of_buffer):
4596 * bytecode.c (syms_of_bytecode):
4597 * callint.c (syms_of_callint):
4598 * casefiddle.c (syms_of_casefiddle):
4599 * casetab.c (init_casetab_once):
4600 * category.c (init_category_once, syms_of_category):
4601 * ccl.c (syms_of_ccl):
4602 * cmds.c (syms_of_cmds):
4603 * composite.c (syms_of_composite):
4604 * dbusbind.c (syms_of_dbusbind):
4605 * dired.c (syms_of_dired):
4606 * dispnew.c (syms_of_display):
4607 * doc.c (syms_of_doc):
4608 * editfns.c (syms_of_editfns):
4609 * emacs.c (syms_of_emacs):
4610 * eval.c (syms_of_eval):
4611 * fileio.c (syms_of_fileio):
4612 * fns.c (syms_of_fns):
4613 * frame.c (syms_of_frame):
4614 * fringe.c (syms_of_fringe):
4615 * insdel.c (syms_of_insdel):
4616 * keymap.c (syms_of_keymap):
4617 * lread.c (init_obarray, syms_of_lread):
4618 * macros.c (syms_of_macros):
4619 * msdos.c (syms_of_msdos):
4620 * print.c (syms_of_print):
4621 * process.c (syms_of_process):
4622 * search.c (syms_of_search):
4623 * sound.c (syms_of_sound):
4624 * syntax.c (init_syntax_once, syms_of_syntax):
4625 * terminal.c (syms_of_terminal):
4626 * textprop.c (syms_of_textprop):
4627 * undo.c (syms_of_undo):
4628 * w32.c (globals_of_w32):
4629 * window.c (syms_of_window):
4630 * xdisp.c (syms_of_xdisp):
4631 * xfaces.c (syms_of_xfaces):
4632 * xfns.c (syms_of_xfns):
4633 * xmenu.c (syms_of_xmenu):
4634 * xsettings.c (syms_of_xsettings):
4635 * xterm.c (syms_of_xterm): Use DEFSYM.
4637 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4639 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4641 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4643 Integer and buffer overflow fixes (Bug#8873).
4645 * print.c (printchar, strout): Check for string overflow.
4646 (PRINTPREPARE, printchar, strout):
4647 Don't set size unless allocation succeeds.
4649 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4650 for sizes. Check for string overflow more accurately.
4651 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4653 * macros.c: Integer and buffer overflow fixes.
4654 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4655 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4656 Use ptrdiff_t, not int, for sizes.
4657 Don't increment bufsize until after realloc succeeds.
4658 Check for size-calculation overflow.
4659 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4661 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4663 * lread.c: Integer overflow fixes.
4664 (read_integer): Radix is now EMACS_INT, not int,
4665 to improve quality of diagnostics for out-of-range radices.
4666 Calculate buffer size correctly for out-of-range radices.
4667 (read1): Check for integer overflow in radices, and in
4668 read-circle numbers.
4669 (read_escape): Avoid int overflow.
4670 (Fload, openp, read_buffer_size, read1)
4671 (substitute_object_recurse, read_vector, read_list, map_obarray):
4672 Use ptrdiff_t, not int, for sizes.
4673 (read1): Use EMACS_INT, not int, for sizes.
4674 Check for size overflow.
4676 * image.c (cache_image): Check for size arithmetic overflow.
4678 * lread.c: Integer overflow issues.
4679 (saved_doc_string_size, saved_doc_string_length)
4680 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4681 Now ptrdiff_t, not int.
4682 (read1): Don't assume doc string length fits in int. Check for
4683 out-of-range doc string lengths.
4684 (read_list): Don't assume file position fits in int.
4685 (read_escape): Check for hex character overflow.
4687 2011-06-22 Leo Liu <sdl.web@gmail.com>
4689 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4690 Move to minibuffer.el.
4692 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4694 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4695 The following patches are for when GLYPH_DEBUG && !XASSERT.
4696 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4697 * dispnew.c (flush_stdout):
4698 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4699 Mark as externally visible.
4700 * dispnew.c (check_window_matrix_pointers): Now static.
4701 * dispnew.c (window_to_frame_vpos):
4702 * xfns.c (unwind_create_frame):
4703 * xterm.c (x_check_font): Remove unused local.
4704 * scroll.c (CHECK_BOUNDS):
4705 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4706 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4707 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4708 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4709 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4711 (debug_method_add): Use va_list and vsprintf rather than relying
4712 on undefined behavior with wrong number of arguments.
4713 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4714 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4715 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4716 since we're not interested in debugging glyphs with old libraries.
4717 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4718 GCC 4.6.0's static checking.
4720 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4722 Integer overflow and signedness fixes (Bug#8873).
4723 A few related buffer overrun fixes, too.
4725 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4727 * dispextern.h (struct face.stipple):
4728 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4729 (x_bitmap_mask, x_allocate_bitmap_record)
4730 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4731 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4732 (x_create_bitmap_from_xpm_data):
4733 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4734 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4736 * xfaces.c (load_pixmap):
4737 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4738 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4739 (.bitmaps_last, struct x_output.icon_bitmap):
4740 Use ptrdiff_t, not int, for bitmap indexes.
4741 (x_allocate_bitmap_record): Check for size overflow.
4742 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4744 Use ptrdiff_t, not int, for overlay counts.
4745 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4746 * editfns.c (overlays_around, get_pos_property):
4747 * textprop.c (get_char_property_and_overlay):
4748 * xdisp.c (next_overlay_change, note_mouse_highlight):
4749 * xfaces.c (face_at_buffer_position):
4750 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4751 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4752 (Fnext_overlay_change, Fprevious_overlay_change)
4753 (mouse_face_overlay_overlaps, Foverlays_in):
4754 Use ptrdiff_t, not int, for sizes.
4755 (overlays_at, overlays_in): Check for size-calculation overflow.
4757 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4759 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4760 (x_session_initialize): Do not assume string length fits in int.
4762 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4763 This is unlikely, but can occur if DPI is outlandish.
4765 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4766 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4768 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4769 * xrdb.c (magic_file_p, search_magic_path):
4770 Omit last arg SUFFIX; it was always 0. All callers changed.
4771 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4773 * xfont.c (xfont_match): Avoid need for strlen.
4775 * xfns.c: Don't assume strlen fits in int.
4776 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4778 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4779 not unsigned long, as we prefer signed integers. All callers changed.
4780 Detect integer overflow in repeat count.
4781 (message_dolog): Don't assume print length fits in 39 bytes.
4782 (display_mode_element): Don't assume strlen fits in int.
4784 * termcap.c: Don't assume sizes fit in int and never overflow.
4785 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4786 (gobble_line): Check for size-calculation overflow.
4788 * minibuf.c (Fread_buffer):
4789 * lread.c (intern, intern_c_string):
4790 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4791 Don't assume string length fits in int.
4793 * keyboard.c (parse_tool_bar_item):
4794 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4796 * font.c: Don't assume string length fits in int.
4797 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4798 Use ptrdiff_t, not int.
4799 (font_intern_prop): Don't assume string length fits in int.
4800 Don't assume integer property fits in fixnum.
4801 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4803 * filelock.c: Fix some buffer overrun and integer overflow issues.
4804 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4805 Reformulate so as not to need the command string.
4806 Invoke gzip -cd rather than gunzip, as it's more portable.
4807 (lock_info_type, lock_file_1, lock_file):
4808 Don't assume pid_t and time_t fit in unsigned long.
4809 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4810 (current_lock_owner): Prefer signed type for sizes.
4811 Use memcpy, not strncpy, where memcpy is what is really wanted.
4812 Don't assume (via atoi) that time_t and pid_t fit in int.
4813 Check for time_t and/or pid_t out of range, e.g., via a network share.
4814 Don't alloca where an auto var works fine.
4816 * fileio.c: Fix some integer overflow issues.
4817 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4818 Don't assume string length fits in int.
4819 (directory_file_name): Don't assume string length fits in long.
4820 (make_temp_name): Don't assume pid fits in int, or that its print
4821 length is less than 20.
4823 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4825 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4827 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4829 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4830 We prefer signed integers, even for size calculations.
4832 * emacs.c: Don't assume string length fits in 'int'.
4833 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4834 (main): Don't invoke strlen when not needed.
4836 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4837 (XD_DEBUG_MESSAGE): Don't waste a byte.
4839 * callproc.c (getenv_internal_1, getenv_internal)
4841 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4843 * lread.c (invalid_syntax): Omit length argument.
4844 All uses changed. This doesn't fix a bug, but it simplifies the
4845 code away from its former Hollerith-constant appearance, and it's
4846 one less 'int' to worry about when looking at integer-overflow issues.
4847 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4849 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4850 This didn't break anything, but it didn't help either.
4851 It's confusing to put a bogus integer in a place where the actual
4852 value does not matter.
4853 (LIST_END_P): Remove unused macro and its bogus comment.
4854 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4856 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4857 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4859 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4860 We prefer signed types, and the value cannot exceed the EMACS_INT
4861 range anyway (because otherwise the length would not be representable).
4862 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4863 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4864 This avoids a GCC warning when WIDE_EMACS_INT.
4866 * indent.c (sane_tab_width): New function.
4867 (current_column, scan_for_column, Findent_to, position_indentation)
4868 (compute_motion): Use it. This is just for clarity.
4869 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4871 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4873 * lisp.h (lint_assume): New macro.
4874 * composite.c (composition_gstring_put_cache):
4875 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4877 * editfns.c, insdel.c:
4878 Omit unnecessary forward decls, to simplify future changes.
4880 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4882 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4884 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4885 Use much-faster test for byte-length change.
4886 Don't assume string byte-length fits in 'int'.
4887 Check that character arg fits in 'int'.
4888 (mapcar1): Declare byte as byte, for clarity.
4890 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4892 * fns.c (concat): Catch string overflow earlier.
4893 Do not rely on integer wraparound.
4895 * dispextern.h (struct it.overlay_strings_charpos)
4896 (struct it.selective): Now EMACS_INT, not int.
4897 * xdisp.c (forward_to_next_line_start)
4898 (back_to_previous_visible_line_start)
4899 (reseat_at_next_visible_line_start, next_element_from_buffer):
4900 Don't arbitrarily truncate the value of 'selective' to int.
4902 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4904 * composite.c: Don't truncate sizes to 'int'.
4905 (composition_gstring_p, composition_reseat_it)
4906 (composition_adjust_point): Use EMACS_INT, not int.
4907 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4908 not EMACS_UINT, for indexes.
4910 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4912 * buffer.c: Include <verify.h>.
4913 (struct sortvec.priority, struct sortstr.priority):
4914 Now EMACS_INT, not int.
4915 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4916 (struct sortstr.size, record_overlay_string)
4917 (struct sortstrlist.size, struct sortlist.used):
4918 Don't truncate size to int.
4919 (record_overlay_string): Check for size-calculation overflow.
4920 (init_buffer_once): Check at compile-time, not run-time.
4922 2011-06-22 Jim Meyering <meyering@redhat.com>
4924 Don't leak an XBM-image-sized buffer
4925 * image.c (xbm_load): Free the image buffer after using it.
4927 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4930 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4931 that Sun C diagnosed.
4932 * fns.c (secure_hash): Fix pointer signedness issue.
4933 * intervals.c (static_offset_intervals): New function.
4934 (offset_intervals): Use it.
4936 2011-06-21 Leo Liu <sdl.web@gmail.com>
4939 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4942 * fns.c (secure_hash): Rename from crypto_hash_function and change
4943 the first arg to accept symbols.
4944 (Fsecure_hash): New primitive.
4945 (syms_of_fns): New symbols.
4947 2011-06-20 Deniz Dogan <deniz@dogan.se>
4949 * process.c (Fset_process_buffer): Clarify return value in
4952 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4954 * dispnew.c (add_window_display_history): Use BVAR.
4956 * xdisp.c (debug_method_add): Use BVAR.
4957 (check_window_end, dump_glyph_matrix, dump_glyph)
4958 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4960 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4963 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4964 check till after the cache is created in init_frame_faces.
4966 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4968 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4970 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4972 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4973 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4974 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4976 Improve buffer-overflow checking (Bug#8873).
4977 * fileio.c (Finsert_file_contents):
4978 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4979 Remove the old (too-loose) buffer overflow checks.
4980 They weren't needed, since make_gap checks for buffer overflow.
4981 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4982 The old code merely checked for Emacs fixnum overflow, and relied
4983 on undefined (wraparound) behavior. The new code avoids undefined
4984 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4986 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4987 Tune. Don't use wider integers than needed. Don't use alloca.
4988 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4990 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4992 * insdel.c, lisp.h (buffer_overflow): New function.
4993 (insert_from_buffer_1, replace_range, replace_range_2):
4994 * insdel.c (make_gap_larger):
4995 * editfns.c (Finsert_char):
4996 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4998 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5000 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5002 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5004 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5005 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5007 * fileio.c: Don't assume EMACS_INT fits in off_t.
5008 (emacs_lseek): New static function.
5009 (Finsert_file_contents, Fwrite_region): Use it.
5010 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5012 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5014 * fns.c: Don't overflow int when computing a list length.
5015 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5016 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5017 truncation on 64-bit hosts. Check for QUIT every
5018 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5019 faster and is responsive enough.
5020 (Flength): Report an error instead of overflowing an integer.
5021 (Fsafe_length): Return a float if the value is not representable
5022 as a fixnum. This shouldn't happen except in contrived situations.
5023 (Fnthcdr, Fsort): Don't assume list length fits in int.
5024 (Fcopy_sequence): Don't assume vector length fits in int.
5026 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5027 (header_size, word_size): New constants.
5028 (allocate_vectorlike): Don't check size overflow here.
5029 (allocate_vector): Check it here instead, since this is the only
5030 caller of allocate_vectorlike that could cause overflow.
5031 Check that the new vector's length is representable as a fixnum.
5033 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5034 The previous code was bogus. For example, next_almost_prime (32)
5035 returned 39, which is undesirable as it is a multiple of 3; and
5036 next_almost_prime (24) returned 25, which is a multiple of 5 so
5037 why was the code bothering to check for multiples of 7?
5039 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5041 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5043 Variadic C functions now count arguments with ptrdiff_t.
5044 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5045 Back then I didn't know that the Emacs coding style prefers signed int.
5046 Also, in the meantime I found a few more instances where arguments
5047 were being counted with int, which may truncate counts on 64-bit
5048 machines, or EMACS_INT, which may be unnecessarily wide.
5049 * lisp.h (struct Lisp_Subr.function.aMANY)
5050 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5051 Arg counts are now ptrdiff_t, not size_t.
5052 All variadic functions and their callers changed accordingly.
5053 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5054 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5055 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5056 * callint.c (Fcall_interactively): Check arg count for overflow,
5057 to avoid potential buffer overrun. Use signed char, not 'int',
5058 for 'varies' array, so that we needn't bother to check its size
5059 calculation for overflow.
5060 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5061 * eval.c (apply_lambda):
5062 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5063 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5064 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5066 * callint.c (Fcall_interactively): Don't use index var as event count.
5068 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5069 * mem-limits.h (SIZE): Remove; no longer used.
5071 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5073 Remove unnecessary casts.
5074 * xterm.c (x_term_init):
5075 * xfns.c (x_set_border_pixel):
5076 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5077 These aren't needed now that we assume ANSI C.
5079 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5080 It's more likely to cause problems (due to unsigned overflow)
5083 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5085 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5087 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5089 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5091 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5093 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5095 GLYPH_CODE_FACE returns EMACS_INT, not int.
5096 * dispextern.h (merge_faces):
5097 * xfaces.c (merge_faces):
5098 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5099 Don't assume EMACS_INT fits in int.
5101 * character.h (CHAR_VALID_P): Remove unused parameter.
5102 * fontset.c, lisp.h, xdisp.c: All uses changed.
5104 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5106 * fns.c (concat): Minor tuning based on overflow analysis.
5107 This doesn't fix any bugs. Use int to hold character, instead
5108 of constantly refetching from Emacs object. Use XFASTINT, not
5109 XINT, for value known to be a character. Don't bother comparing
5110 a single byte to 0400, as it's always less.
5112 * floatfns.c (Fexpt):
5113 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5115 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5118 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5120 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5121 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5122 incorrectly succeed when S was a string, because 4294967386 was
5123 truncated before it was used.
5125 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5126 Otherwise, an out-of-range integer could cause undefined behavior
5129 * composite.c: Use int, not EMACS_INT, for characters.
5130 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5131 EMACS_INT, for values that are known to be in character range.
5132 This doesn't fix any bugs but is the usual style inside Emacs and
5133 may generate better code on 32-bit machines.
5135 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5136 This is for reasons similar to the recent CHAR_STRING fix.
5137 * charset.c (Fencode_char): Check that character arg is actually
5138 a character. Pass an int to ENCODE_CHAR.
5139 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5140 wider than 'int', as a compile-time check to prevent future regressions
5143 * character.c (char_string): Remove unnecessary casts.
5145 Make sure a 64-bit char is never passed to CHAR_STRING.
5146 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5147 by silently ignoring the top 32 bits, allowing some values
5148 that were far too large to be valid characters.
5149 * character.h: Include <verify.h>.
5150 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5151 arguments are no wider than unsigned, as a compile-time check
5152 to prevent future regressions in this area.
5154 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5155 (Fsubst_char_in_region):
5157 * xdisp.c (decode_mode_spec_coding):
5158 Adjust to CHAR_STRING's new requirement.
5159 * editfns.c (Finsert_char, Fsubst_char_in_region):
5160 * fns.c (concat): Check that character args are actually
5161 characters. Without this test, these functions did the wrong
5162 thing with wildly out-of-range values on 64-bit hosts.
5164 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5165 These casts should not be needed on 32-bit hosts, either.
5166 * keyboard.c (read_char):
5167 * lread.c (Fload): Remove casts to unsigned.
5169 * lisp.h (UNSIGNED_CMP): New macro.
5170 This fixes comparison bugs on 64-bit hosts.
5171 (ASCII_CHAR_P): Use it.
5172 * casefiddle.c (casify_object):
5173 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5174 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5175 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5176 * dispextern.h (FACE_FROM_ID):
5177 * keyboard.c (read_char): Use UNSIGNED_CMP.
5179 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5180 not to EMACS_INT, to avoid GCC warning.
5182 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5184 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5185 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5186 isn't needed on 32-bit machines.
5188 * buffer.c (Fgenerate_new_buffer_name):
5189 Use EMACS_INT for count, not int.
5190 (advance_to_char_boundary): Return EMACS_INT, not int.
5192 * data.c (Qcompiled_function): Now static.
5194 * window.c (window_body_lines): Now static.
5196 * image.c (gif_load): Rename local to avoid shadowing.
5198 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5199 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5200 * alloc.c (make_save_value): Integer argument is now of type
5202 (mark_object): Use ptrdiff_t, not int.
5203 * lisp.h (pD): New macro.
5204 * print.c (print_object): Use it.
5206 * alloc.c: Use EMACS_INT, not int, to count objects.
5207 (total_conses, total_markers, total_symbols, total_vector_size)
5208 (total_free_conses, total_free_markers, total_free_symbols)
5209 (total_free_floats, total_floats, total_free_intervals)
5210 (total_intervals, total_strings, total_free_strings):
5211 Now EMACS_INT, not int. All uses changed.
5212 (Fgarbage_collect): Compute overall total using a double, so that
5213 integer overflow is less likely to be a problem. Check for overflow
5214 when converting back to an integer.
5215 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5216 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5217 These were 'int' variables that could overflow on 64-bit hosts;
5218 they were never used, so remove them instead of repairing them.
5219 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5220 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5221 Previously, this ceilinged at INT_MAX, but that doesn't work on
5223 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5225 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5226 (allocate_vectorlike): Check for ptrdiff_t overflow.
5227 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5228 when a (possibly-narrower) signed value would do just as well.
5229 We prefer using signed arithmetic, to avoid comparison confusion.
5231 * alloc.c: Catch some string size overflows that we were missing.
5232 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5233 for convenience in STRING_BYTES_MAX.
5234 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5235 The definition here is exact; the one in lisp.h was approximate.
5236 (allocate_string_data): Check for string overflow. This catches
5237 some instances we weren't catching before. Also, it catches
5238 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5239 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5240 and ptrdiff_t and EMACS_INT are both 64 bits.
5242 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5243 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5244 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5246 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5248 * alloc.c (Fmake_string): Check for out-of-range init.
5250 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5252 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5254 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5256 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5257 xg_get_default_scrollbar_width.
5259 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5260 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5261 (style_changed_cb): Call update_theme_scrollbar_width and call
5262 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5263 all frames (Bug#8505).
5264 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5265 Call gtk_window_set_resizable if HAVE_GTK3.
5266 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5267 and height if HAVE_GTK3 (Bug#8505).
5268 (scroll_bar_width_for_theme): New variable.
5269 (update_theme_scrollbar_width): New function.
5270 (xg_get_default_scrollbar_width): Move code to
5271 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5272 (xg_initialize): Call update_theme_scrollbar_width.
5274 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5276 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5278 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5280 * frame.c (make_frame): Call other_buffer_safely instead of
5283 * window.c (temp_output_buffer_show): Call display_buffer with
5284 second argument Vtemp_buffer_show_specifiers and reset latter
5285 immediately after the call.
5286 (Vtemp_buffer_show_specifiers): New variable.
5287 (auto_window_vscroll_p, next_screen_context_lines)
5288 (Vscroll_preserve_screen_position): Remove leading asterisks from
5291 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5293 Fix minor problems found by GCC 4.6.0 static checking.
5294 * buffer.c (Qclone_number): Remove for now, as it's unused.
5295 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5296 (record_buffer): Remove unused local.
5297 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5298 (set_frame_buffer_list): Remove; unused.
5299 * frame.h (other_visible_frames): Remove decl.
5300 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5301 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5302 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5304 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5305 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5306 Define only if HAVE_GPM.
5307 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5308 (update_hints_inhibit): Remove; never set. All uses removed.
5309 * widgetprv.h (emacsFrameClassRec): Remove decl.
5310 * window.c (delete_deletable_window): Now returns void, since it
5311 wasn't returning anything.
5312 (compare_window_configurations): Remove unused locals.
5313 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5314 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5315 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5316 the same widths as pointers. This follows up on the 2011-05-06 patch.
5317 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5318 * xterm.h: Likewise.
5319 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5321 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5323 * makefile.w32-in: Update dependencies.
5324 (LISP_H): Add lib/intprops.h.
5326 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5328 * image.c (gif_load): Add animation frame delay to the metadata.
5329 (syms_of_image): Use DEFSYM. New symbol `delay'.
5331 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5333 * window.c (delete_deletable_window): Re-add.
5334 (Fset_window_configuration): Rewrite to handle dead buffers and
5335 consequently deletable windows.
5336 (window_tree, Fwindow_tree): Remove. Supply functionality in
5338 (compare_window_configurations): Simplify code.
5340 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5342 * image.c (imagemagick_load_image): Fix type mismatch.
5343 (Fimagemagick_types): Likewise.
5345 * window.h (replace_buffer_in_windows): Declare.
5347 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5349 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5350 Qclone_number. Remove external declaration of Qdelete_window.
5351 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5353 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5354 Run Qbuffer_list_update_hook if allowed.
5355 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5356 buffer list implementation.
5357 (other_buffer_safely): New function.
5358 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5359 calls to replace_buffer_in_windows and
5360 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5362 (record_buffer): Inhibit quitting and rewrite using quittable
5363 functions. Run Qbuffer_list_update_hook if allowed.
5364 (Frecord_buffer, Funrecord_buffer): New functions.
5365 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5366 Move switch-to-buffer to window.el.
5367 (bury-buffer): Move to window.el.
5368 (Vbuffer_list_update_hook): New variable.
5370 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5373 * window.h (resize_frame_windows): Move up in code.
5374 (Fwindow_frame): Remove EXFUN.
5375 (replace_buffer_in_all_windows): Remove prototype.
5376 (replace_buffer_in_windows_safely): Add prototype.
5378 * window.c: Declare Qdelete_window static again. Move down
5379 declaration of select_count.
5380 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5381 (Fother_window): Move to window.el.
5382 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5383 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5384 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5386 (replace_buffer_in_windows): Implement by calling
5387 Qreplace_buffer_in_windows.
5388 (replace_buffer_in_all_windows): Remove with some functionality
5389 moved into replace_buffer_in_windows_safely.
5390 (replace_buffer_in_windows_safely): New function.
5391 (select_window_norecord, select_frame_norecord): Move in front
5392 of run_window_configuration_change_hook. Remove now obsolete
5394 (Fset_window_buffer): Rewrite doc-string.
5395 Call Qrecord_window_buffer.
5396 (keys_of_window): Move binding for other-window to window.el.
5398 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5400 * dispextern.h (struct image): Replace data member, whose int_val
5401 and ptr_val fields were not used by anything, with a single
5404 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5405 (gif_clear_image, gif_load, imagemagick_load_image)
5406 (gs_clear_image, gs_load): Callers changed.
5408 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5410 * buffer.h: Include <time.h>, for time_t.
5411 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5413 Fix minor problems found by static checking.
5415 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5417 Make identifiers static if they are not used in other modules.
5418 * data.c (Qcompiled_function, Qframe, Qvector):
5419 * image.c (QimageMagick, Qsvg):
5420 * minibuf.c (Qmetadata):
5421 * window.c (resize_window_check, resize_root_window): Now static.
5422 * window.h (resize_window_check, resize_root_window): Remove decls.
5424 * window.c (window_deletion_count, delete_deletable_window):
5426 (window_body_lines): Now static.
5427 (Fdelete_other_windows_internal): Mark vars as initialized.
5428 Make sure 'resize_failed' is initialized.
5429 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5430 (resize_window_apply): Remove unused local.
5431 * window.h (delete_deletable_window): Remove decl.
5433 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5434 (imagemagick_load_image): Fix pointer signedness problem by changing
5435 last arg from unsigned char * to char *. All uses changed.
5436 Also, fix a local for similar reasons.
5437 Remove unused locals. Remove locals to avoid shadowing.
5438 (fn_rsvg_handle_free): Remove; unused.
5439 (svg_load, svg_load_image): Fix pointer signedness problem.
5440 (imagemagick_load_image): Don't use garbage pointer image_wand.
5442 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5444 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5446 * image.c (gif_load): Fix omitted cast error introduced by
5449 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5451 * window.h (resize_proportionally, orig_total_lines)
5452 (orig_top_line): Remove from window structure.
5453 (set_window_height, set_window_width, change_window_heights)
5454 (Fdelete_window): Remove prototypes.
5455 (resize_frame_windows): Remove duplicate declaration.
5457 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5459 * window.h (resize_frame_windows, resize_window_check)
5460 (delete_deletable_window, resize_root_window)
5461 (resize_frame_windows): Declare prototypes.
5463 * window.c (resize_window_apply): Make definition be "static" to
5464 match the prototype.
5466 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5468 * window.c: Remove declarations of Qwindow_size_fixed,
5469 window_min_size_1, window_min_size_2, window_min_size,
5470 size_window, window_fixed_size_p, enlarge_window, delete_window.
5471 Remove static from declaration of Qdelete_window, it's
5472 temporarily needed by Fbury_buffer.
5473 (replace_window): Don't assign orig_top_line and
5475 (Fdelete_window, delete_window): Remove. Window deletion is
5476 handled by window.el.
5477 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5478 Replace Fdelete_window calls with calls to Qdelete_window.
5479 (Fdelete_other_windows): Remove. Deleting other windows is
5480 handled by window.el.
5481 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5482 handled in window.el.
5483 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5484 Window minimum sizes are handled in window.el.
5485 (shrink_windows, size_window, set_window_height)
5486 (set_window_width, change_window_heights, window_height)
5487 (window_width, CURBEG, CURSIZE, enlarge_window)
5488 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5489 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5490 handled in window.el.
5491 (make_dummy_parent): Rename to make_parent_window and give it a
5492 second argument horflag.
5493 (make_window): Don't set resize_proportionally any more.
5494 (Fsplit_window): Remove. Windows are split in window.el.
5495 (save_restore_action, save_restore_orig_size)
5496 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5497 Resize mini windows in window.el.
5498 (grow_mini_window, shrink_mini_window): Implement by calling
5499 Qresize_root_window_vertically, resize_window_check and
5500 resize_window_apply.
5501 (saved_window, Fset_window_configuration, save_window_save):
5502 Do not handle orig_top_line, orig_total_lines, and
5503 resize_proportionally.
5504 (window_min_height, window_min_width): Move to window.el.
5505 (keys_of_window): Move bindings for delete-other-windows,
5506 split-window, delete-window and enlarge-window to window.el.
5508 * buffer.c: Temporarily extern Qdelete_window.
5509 (Fbury_buffer): Temporarily call Qdelete_window instead of
5510 Fdelete_window (Fbury_buffer will move to window.el soon).
5512 * frame.c (set_menu_bar_lines_1): Remove code handling
5513 orig_top_line and orig_total_lines.
5515 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5516 set_window_height but set heights directly.
5517 (change_frame_size_1): Use resize_frame_windows.
5519 * xdisp.c (init_xdisp): Don't use set_window_height but set
5522 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5523 Use resize_frame_windows instead of change_window_heights and run
5524 run_window_configuration_change_hook.
5526 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5527 instead of change_window_heights and run
5528 run_window_configuration_change_hook.
5530 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5532 * window.c (replace_window): Rename second argument REPLACEMENT to
5533 NEW. New third argument SETFLAG. Rewrite.
5534 (delete_window, make_dummy_parent): Call replace_window with
5536 (window_list_1): Move down in code.
5537 (run_window_configuration_change_hook): Move set_buffer part
5538 before select_frame_norecord part in order to unwind correctly.
5539 Rename count1 to count.
5540 (recombine_windows, delete_deletable_window, resize_root_window)
5541 (Fdelete_other_windows_internal)
5542 (Frun_window_configuration_change_hook, make_parent_window)
5543 (resize_window_check, resize_window_apply, Fresize_window_apply)
5544 (resize_frame_windows, Fsplit_window_internal)
5545 (Fdelete_window_internal, Fresize_mini_window_internal):
5547 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5549 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5551 * window.h (window): Add some new members to window structure -
5552 normal_lines, normal_cols, new_total, new_normal, clone_number,
5553 splits, nest, prev_buffers, next_buffers.
5554 (WINDOW_TOTAL_SIZE): Move here from window.c.
5555 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5557 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5559 (make_dummy_parent): Set new members of windows structure.
5560 (make_window): Move down in code. Handle new members of window
5562 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5563 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5564 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5565 (Fset_window_prev_buffers, Fwindow_next_buffers)
5566 (Fset_window_next_buffers, Fset_window_clone_number):
5568 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5569 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5571 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5572 Argument WINDOW can be now internal window too.
5573 (Fwindow_use_time): Move up in code.
5574 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5576 (Fset_window_configuration, saved_window)
5577 (Fcurrent_window_configuration, save_window_save): Handle new
5578 members of window structure.
5579 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5580 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5581 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5582 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5583 Qget_mru_window, Qresize_root_window,
5584 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5585 Qauto_buffer_name; staticpro them.
5587 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5589 * window.c (Fwindow_total_size, Fwindow_left_column)
5590 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5591 (Fwindow_list_1): New functions.
5592 (window_box_text_cols): Replace with window_body_cols.
5593 (Fwindow_width, Fscroll_left, Fscroll_right):
5594 Use window_body_cols instead of window_box_text_cols.
5595 (delete_window, Fset_window_configuration):
5596 Call delete_all_subwindows with window as argument.
5597 (delete_all_subwindows): Take a window as argument and not a
5599 (window_loop): Remove handling of GET_LRU_WINDOW and
5601 (Fget_lru_window, Fget_largest_window): Move to window.el.
5603 * window.h: Extern window_body_cols instead of
5604 window_box_text_cols. delete_all_subwindows now takes a
5605 Lisp_Object as argument.
5607 * indent.c (compute_motion, Fcompute_motion):
5608 Use window_body_cols instead of window_box_text_cols.
5610 * frame.c (delete_frame): Call delete_all_subwindows with root
5613 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5615 * fns.c (Fputhash): Document return value.
5617 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5619 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5621 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5623 Cons<->int and similar integer overflow fixes (Bug#8794).
5625 Check for overflow when converting integer to cons and back.
5626 * charset.c (Fdefine_charset_internal, Fdecode_char):
5627 Use cons_to_unsigned to catch overflow.
5628 (Fencode_char): Use INTEGER_TO_CONS.
5629 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5630 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5631 * data.c (long_to_cons, cons_to_long): Remove.
5632 (cons_to_unsigned, cons_to_signed): New functions.
5633 These signal an error for invalid or out-of-range values.
5634 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5635 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5636 * font.c (Ffont_variation_glyphs):
5637 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5638 * lisp.h: Include <intprops.h>.
5639 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5640 (cons_to_signed, cons_to_unsigned): New decls.
5641 (long_to_cons, cons_to_long): Remove decls.
5642 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5643 (Fprimitive_undo): Use CONS_TO_INTEGER.
5644 * xfns.c (Fx_window_property): Likewise.
5645 * xselect.c: Include <limits.h>.
5646 (x_own_selection, selection_data_to_lisp_data):
5647 Use INTEGER_TO_CONS.
5648 (x_handle_selection_request, x_handle_selection_clear)
5649 (x_get_foreign_selection, Fx_disown_selection_internal)
5650 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5651 (lisp_data_to_selection_data): Use cons_to_unsigned.
5652 (x_fill_property_data): Use cons_to_signed.
5653 Report values out of range.
5655 Check for buffer and string overflow more precisely.
5656 * buffer.h (BUF_BYTES_MAX): New macro.
5657 * lisp.h (STRING_BYTES_MAX): New macro.
5658 * alloc.c (Fmake_string):
5659 * character.c (string_escape_byte8):
5660 * coding.c (coding_alloc_by_realloc):
5661 * doprnt.c (doprnt):
5662 * editfns.c (Fformat):
5664 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5665 since they may not be the same number.
5666 * editfns.c (Finsert_char):
5667 * fileio.c (Finsert_file_contents):
5668 Likewise for BUF_BYTES_MAX.
5670 * image.c: Use ptrdiff_t, not int, for sizes.
5671 (slurp_file): Switch from int to ptrdiff_t.
5673 (slurp_file): Check that file size fits in both size_t (for
5674 malloc) and ptrdiff_t (for sanity and safety).
5676 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5677 if b->modtime has its maximal value.
5679 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5681 Don't assume time_t can fit into int.
5682 * buffer.h (struct buffer.modtime): Now time_t, not int.
5683 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5684 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5686 Minor fixes for signed vs unsigned integers.
5687 * character.h (MAYBE_UNIFY_CHAR):
5688 * charset.c (maybe_unify_char):
5689 * keyboard.c (read_char, reorder_modifiers):
5690 XINT -> XFASTINT, since the integer must be nonnegative.
5691 * ftfont.c (ftfont_spec_pattern):
5692 * keymap.c (access_keymap, silly_event_symbol_error):
5693 XUINT -> XFASTINT, since the integer must be nonnegative.
5694 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5695 since it makes no difference and we prefer signed.
5696 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5697 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5700 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5702 * window.h (Fwindow_frame): Declare.
5704 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5706 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5707 (SPARE_MEMORY): Always define.
5708 (LARGE_REQUEST): Remove.
5709 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5711 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5713 * lisp.h: Move EXFUNS for Fframe_root_window,
5714 Fframe_first_window and Fset_frame_selected_window to window.h.
5716 * window.h: Move EXFUNS for Fframe_root_window,
5717 Fframe_first_window and Fset_frame_selected_window here from
5720 * frame.c (Fwindow_frame, Fframe_first_window)
5721 (Fframe_root_window, Fframe_selected_window)
5722 (Fset_frame_selected_window): Move to window.c.
5723 (Factive_minibuffer_window): Move to minibuf.c.
5724 (Fother_visible_frames_p): New function.
5726 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5728 * window.c (decode_window, decode_any_window): Move up in code.
5729 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5730 (inhibit_frame_unsplittable): Remove unused variable.
5731 (Fwindow_buffer): Move up and rewrite doc-string.
5732 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5733 (Fwindow_prev): New functions.
5734 (Fwindow_frame): Move here from frame.c. Accept any window as
5736 (Fframe_root_window, Fframe_first_window)
5737 (Fframe_selected_window): Move here from frame.c. Accept frame
5738 or arbitrary window as argument. Update doc-strings.
5739 (Fminibuffer_window): Move up in code.
5740 (Fwindow_minibuffer_p): Move up in code and simplify.
5741 (Fset_frame_selected_window): Move here from frame.c.
5743 (Fselected_window, select_window, Fselect_window): Move up in
5744 code. Minor doc-string fixes.
5746 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5748 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5749 Do not assume that spare memory exists; that assumption is valid
5750 only if SYSTEM_MALLOC.
5751 (LARGE_REQUEST): New macro, so that the issue of large requests
5752 is separated from the issue of spare memory.
5754 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5756 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5759 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5761 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5764 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5766 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5768 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5770 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5771 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5773 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5775 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5777 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5779 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5780 (x_clipboard_manager_save): Add return value.
5781 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5783 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5784 Obey Vx_select_enable_clipboard_manager. Catch errors in
5785 x_clipboard_manager_save (Bug#8779).
5786 (Vx_select_enable_clipboard_manager): New variable.
5787 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5789 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5791 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5793 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5795 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5796 in the current matrix if keep_current_p is non-zero.
5798 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5800 * bidi.c (bidi_level_of_next_char): Fix last change.
5802 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5804 Support bidi reordering of text covered by display properties.
5806 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5807 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5808 (bidi_cache_search, bidi_cache_iterator_state)
5809 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5810 (bidi_level_of_next_char, bidi_move_to_visually_next):
5811 Support character positions inside a run of characters covered by a
5813 (bidi_paragraph_init, bidi_resolve_explicit_1)
5814 (bidi_level_of_next_char): Call bidi_fetch_char and
5815 bidi_fetch_char_advance instead of FETCH_CHAR and
5817 (bidi_init_it): Initialize new members.
5818 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5820 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5821 instead of using explicit *_CHAR codes.
5822 (bidi_resolve_explicit, bidi_resolve_weak):
5823 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5824 bidirectional text is supported only in multibyte buffers.
5825 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5826 it to initialize the frame_window_p member of struct bidi_it.
5827 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5828 (bidi_resolve_explicit, bidi_resolve_weak)
5829 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5830 bidi_it->nchars is non-positive.
5831 (bidi_level_of_next_char): Don't try to lookup the cache for the
5832 next/previous character if nothing is cached there yet, or if we
5833 were just reseat()'ed to a new position.
5835 * xdisp.c (set_cursor_from_row): Set start and stop points
5836 according to the row's direction when priming the loop that looks
5837 for the glyph on which to display cursor.
5838 (single_display_spec_intangible_p): Function deleted.
5839 (display_prop_intangible_p): Reimplement to call
5840 handle_display_spec instead of single_display_spec_intangible_p.
5841 Accept 3 additional arguments needed by handle_display_spec.
5842 This fixes incorrect cursor motion across display property with complex
5843 values: lists, `(when COND...)' forms, etc.
5844 (single_display_spec_string_p): Support property values that are
5845 lists with the argument STRING its top-level element.
5846 (display_prop_string_p): Fix the condition for processing a
5847 property that is a list to be consistent with handle_display_spec.
5848 (handle_display_spec): New function, refactored from the
5849 last portion of handle_display_prop.
5850 (compute_display_string_pos): Accept additional argument
5851 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5852 value of a `display' property is a "replacing spec".
5853 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5854 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5855 the display property, but just return a value indicating whether
5856 the display property will replace the characters it covers.
5857 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5858 frame_window_p members of struct bidi_it.
5859 (compute_display_string_pos, compute_display_string_end):
5861 (push_it): Accept second argument POSITION, where pop_it should
5862 jump to continue iteration.
5863 (reseat_1): Initialize bidi_it.disp_pos.
5865 * keyboard.c (adjust_point_for_property): Adjust the call to
5866 display_prop_intangible_p to its new signature.
5868 * dispextern.h (struct bidi_it): New member frame_window_p.
5869 (bidi_init_it): Update prototypes.
5870 (display_prop_intangible_p): Update prototype.
5871 (compute_display_string_pos, compute_display_string_end):
5873 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5876 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5878 Malloc failure behavior now depends on size of allocation.
5879 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5880 * lisp.h: Change signatures accordingly.
5881 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5882 All callers changed. (Bug#8762)
5884 * gnutls.c: Use Emacs's memory allocators.
5885 Without this change, the gnutls library would invoke malloc etc.
5886 directly, which causes problems on non-SYNC_INPUT hosts, and which
5887 runs afoul of improving memory_full behavior. (Bug#8761)
5888 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5889 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5890 xfree instead of the default malloc, realloc, free.
5891 (Fgnutls_boot): No need to check for memory allocation failure,
5892 since xmalloc does that for us.
5894 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5895 * category.c (hash_get_category_set):
5896 * ccl.c (ccl_driver):
5897 * charset.c (Fdefine_charset_internal):
5898 * charset.h (struct charset.hash_index):
5899 * composite.c (get_composition_id, gstring_lookup_cache)
5900 (composition_gstring_put_cache):
5901 * composite.h (struct composition.hash_index):
5902 * dispextern.h (struct image.hash):
5903 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5904 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5905 (hashfn_equal, hashfn_user_defined, make_hash_table)
5906 (maybe_resize_hash_table, hash_lookup, hash_put)
5907 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5908 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5909 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5910 * image.c (make_image, search_image_cache, lookup_image)
5911 (xpm_put_color_table_h):
5912 * lisp.h (struct Lisp_Hash_Table):
5913 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5914 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5915 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5916 * alloc.c (allocate_vectorlike):
5917 Check for overflow in vector size calculations.
5918 * ccl.c (ccl_driver):
5919 Check for overflow when converting EMACS_INT to int.
5920 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5921 need to be updated by these changes.
5922 * fns.c (make_hash_table, maybe_resize_hash_table):
5923 Check for integer overflow with large hash tables.
5924 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5925 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5926 (SXHASH_REDUCE): New macro.
5927 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5928 Use it instead of discarding useful hash info with large hash values.
5929 (sxhash_float): New function.
5930 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5931 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5932 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5933 Rewrite to use FIXNUM_BITS, as this simplifies things.
5934 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5935 Adjust signatures to match updated version of code.
5936 (consing_since_gc): Now EMACS_INT, since a single hash table can
5937 use more than INT_MAX bytes.
5939 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5941 Make it possible to build with GCC-4.6+ -O2 -flto.
5943 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5945 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5947 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5948 Call minibuffer-inactive-mode.
5950 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5952 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5953 Update dependencies.
5955 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5957 * data.c (init_data): Remove code for UTS, this system is not
5960 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5962 Don't force ./temacs to start in terminal mode.
5964 * frame.c (make_initial_frame): Initialize faces in all cases, not
5965 only when CANNOT_DUMP is defined.
5966 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5968 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5970 * dispnew.c (add_window_display_history): Use const for the string
5971 pointer. Remove declaration, not needed.
5973 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5975 Use 'inline', not 'INLINE'.
5976 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5977 * alloc.c, fontset.c (INLINE): Remove.
5978 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5979 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5980 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5981 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5982 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5984 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5986 Make it possible to run ./temacs.
5988 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5989 syms_of_callproc does the same thing. Remove test for
5990 "initialized", do it in the caller.
5991 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5993 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5995 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5996 (read_minibuf): Use get_minibuffer.
5997 (syms_of_minibuf): Use DEFSYM.
5998 (Qmetadata): New var.
5999 * data.c (Qbuffer): Don't make it static.
6000 (syms_of_data): Use DEFSYM.
6002 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6004 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6005 (CCL_CODE_MIN): New macro.
6007 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6009 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6011 * eval.c (Qdebug): Now static.
6012 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6013 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6014 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6016 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6018 * image.c: Various fixes to ImageMagick code comments.
6019 (Fimagemagick_types): Doc fix.
6021 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6023 Minor fixes prompted by GCC 4.6.0 warnings.
6025 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6027 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6028 (x_clipboard_manager_save_all): Move extern decl to ...
6029 * xterm.h: ... here, so that it can be checked for consistency.
6031 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6033 * xselect.c (x_clipboard_manager_save_frame)
6034 (x_clipboard_manager_save_all): New functions.
6035 (Fx_clipboard_manager_save): Lisp function deleted.
6037 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6038 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6040 * xterm.h: Update prototype.
6042 2011-05-28 William Xu <william.xwl@gmail.com>
6044 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6047 2011-05-28 Jim Meyering <meyering@redhat.com>
6049 Avoid a sign-extension bug in crypto_hash_function.
6050 * fns.c (to_uchar): Define.
6051 (crypto_hash_function): Use it to convert some newly-signed
6052 variables to unsigned, to avoid sign-extension bugs. For example,
6053 without this change, (md5 "truc") would evaluate to
6054 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6055 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6056 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6058 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6060 Integer overflow fixes.
6062 * dbusbind.c: Serial number integer overflow fixes.
6063 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6064 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6065 to hold a serial number that is too large for a fixnum.
6066 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6067 Check for serial numbers out of range. Decode any serial number
6068 that was so large that it became a float. (Bug#8722)
6070 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6071 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6072 Use XFASTINT rather than XUINT when numbers are nonnegative.
6073 (xd_append_arg, Fdbus_method_return_internal):
6074 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6075 arguments, check that Lisp number is nonnegative, rather than
6076 silently wrapping negative numbers around. (Bug#8722)
6077 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6080 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6082 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6084 ccl: Add integer overflow checks.
6085 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6086 (IN_INT_RANGE): New macros.
6087 (ccl_driver): Use them to check for integer overflow when
6088 decoding a CCL program. Many of the new checks are whether XINT (x)
6089 fits in int; it doesn't always, on 64-bit hosts. The new version
6090 doesn't catch all possible integer overflows, but it's an
6091 improvement. (Bug#8719)
6093 * alloc.c (make_event_array): Use XINT, not XUINT.
6094 There's no need for unsigned here.
6096 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6097 This follows up to the 2011-05-06 change that substituted uintptr_t
6098 for EMACS_INT. This case wasn't caught back then.
6100 Rework Fformat to avoid integer overflow issues.
6101 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6102 now (part of C89). Include <verify.h>.
6103 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6104 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6105 (Fformat): Avoid the prepass trying to compute sizes; it was only
6106 approximate and thus did not catch overflow reliably. Instead, walk
6107 through the format just once, formatting and computing sizes as we go,
6108 checking for integer overflow at every step, and allocating a larger
6109 buffer as needed. Keep track separately whether the format is
6110 multibyte. Keep only the most-recently calculated precision, rather
6111 than them all. Record whether each argument has been converted to
6112 string. Use EMACS_INT, not int, for byte and char and arg counts.
6113 Support field widths and precisions larger than INT_MAX. Avoid
6114 sprintf's undefined behavior with conversion specifications such as %#d
6115 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6116 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6117 formatting out-of-range floating point numbers with int
6120 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6122 * data.c: Avoid integer truncation in expressions involving floats.
6123 * data.c: Include <intprops.h>.
6124 (arith_driver): When there's an integer overflow in an expression
6125 involving floating point, convert the integers to floating point
6126 so that the resulting value does not suffer from catastrophic
6127 integer truncation. For example, on a 64-bit host (* 4
6128 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6129 Do not rely on undefined behavior after integer overflow.
6131 merge count_size_as_multibyte, parse_str_to_multibyte
6132 * character.c, character.h (count_size_as_multibyte):
6133 Rename from parse_str_to_multibyte; all uses changed.
6134 Check for integer overflow.
6135 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6136 since it's now a duplicate of the other. This is more of
6137 a character than a buffer op, so better that it's in character.c.
6138 * fns.c, print.c: Adjust to above changes.
6140 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6142 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6144 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6146 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6147 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6148 (x_clipboard_manager_save): Now static.
6149 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6151 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6152 (crypto_hash_function): Now static.
6153 Fix pointer signedness problems. Avoid unnecessary initializations.
6155 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6157 * termhooks.h (Vselection_alist): Make it terminal-local.
6159 * terminal.c (create_terminal): Initialize it.
6161 * xselect.c: Support for clipboard managers.
6162 (Vselection_alist): Move to termhooks.h as terminal-local var.
6163 (LOCAL_SELECTION): New macro.
6164 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6165 (symbol_to_x_atom): Remove gratuitous arg.
6166 (x_handle_selection_request, lisp_data_to_selection_data)
6167 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6168 (x_own_selection, x_get_local_selection, x_convert_selection):
6169 New arg, specifying work frame. Use terminal-local Vselection_alist.
6170 (some_frame_on_display): Delete unused function.
6171 (Fx_own_selection_internal, Fx_get_selection_internal)
6172 (Fx_disown_selection_internal, Fx_selection_owner_p)
6173 (Fx_selection_exists_p): New optional frame arg.
6174 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6175 (x_handle_selection_clear): Don't treat other terminals with the
6176 same keyboard specially. Use the terminal-local Vselection_alist.
6177 (x_clear_frame_selections): Use Frun_hook_with_args.
6179 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6181 * xterm.h: Add support for those atoms.
6183 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6185 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6186 (converted_selections, conversion_fail_tag): New global variables.
6187 (x_selection_request_lisp_error): Free the above.
6188 (x_get_local_selection): Remove unnecessary code.
6189 (x_reply_selection_request): Args changed; handle arbitrary array
6190 of converted selections stored in converted_selections.
6191 Separate the XChangeProperty and SelectionNotify steps.
6192 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6193 (x_convert_selection): New function.
6194 (x_handle_selection_event): Simplify.
6195 (x_get_foreign_selection): Don't ignore incoming requests while
6196 waiting for an answer; this will fail when we implement
6197 SAVE_TARGETS, and seems unnecessary anyway.
6198 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6199 (Vx_sent_selection_functions): Doc fix.
6201 2011-05-26 Leo Liu <sdl.web@gmail.com>
6203 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6205 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6207 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6209 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6210 for fringe update if it has periodic bitmap.
6211 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6212 and fringe_bitmap_periodic_p.
6214 * fringe.c (get_fringe_bitmap_data): New function.
6215 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6216 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6217 row. Mark glyph row for fringe update if periodicity changed.
6219 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6220 for fringe update unless it has periodic bitmap.
6222 2011-05-25 Kenichi Handa <handa@m17n.org>
6224 * xdisp.c (get_next_display_element): Set correct it->face_id for
6225 a static composition.
6227 2011-05-24 Leo Liu <sdl.web@gmail.com>
6230 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6232 * fns.c (crypto_hash_function, Fsha1): New function.
6233 (Fmd5): Use crypto_hash_function.
6234 (syms_of_fns): Add Ssha1.
6236 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6238 * gnutls.c: Remove unused macros.
6239 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6240 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6241 Remove macros that are defined and never used.
6242 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6244 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6246 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6247 (Fx_get_selection_internal): Minor cleanup.
6248 (Fx_own_selection_internal): Rename arguments for consistency with
6251 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6253 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6255 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6257 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6259 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6261 * dispnew.c (scrolling_window): Don't exclude the case that the
6262 last enabled row in the desired matrix touches the bottom boundary.
6264 2011-05-21 Glenn Morris <rgm@gnu.org>
6266 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6267 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6268 and add some more files.
6270 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6272 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6273 report_file_error introduced by the change from 2011-05-07.
6275 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6277 * systime.h (Time): Define only if emacs is defined.
6278 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6279 where the include path doesn't have X11/X.h by default. See
6280 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6282 2011-05-20 Kenichi Handa <handa@m17n.org>
6284 * composite.c (find_automatic_composition): Fix previous change.
6286 2011-05-20 Glenn Morris <rgm@gnu.org>
6288 * lisp.mk: New file, split from Makefile.in.
6289 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6290 (shortlisp): Remove.
6291 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6293 2011-05-19 Glenn Morris <rgm@gnu.org>
6295 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6296 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6297 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6298 (lisp): Set the order to that of loadup.el.
6299 (shortlisp): Make it a copy of $lisp.
6300 (SOME_MACHINE_LISP): Remove.
6301 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6302 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6304 2011-05-18 Kenichi Handa <handa@m17n.org>
6306 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6307 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6308 (find_automatic_composition): Mostly rewrite for efficiency.
6310 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6312 * makefile.w32-in: Update dependencies.
6314 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6316 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6317 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6319 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6321 Fix some integer overflow issues, such as string length overflow.
6323 * insdel.c (count_size_as_multibyte): Check for string overflow.
6325 * character.c (lisp_string_width): Check for string overflow.
6326 Use EMACS_INT, not int, for string indexes and lengths; in
6327 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6328 the resulting string length overflows an EMACS_INT; instead,
6329 report a string overflow if no precision given. When checking for
6330 precision exhaustion, use a check that cannot possibly have
6331 integer overflow. (Bug#8675)
6332 * character.h (lisp_string_width): Adjust to new signature.
6334 * alloc.c (string_overflow): New function.
6335 (Fmake_string): Use it. This doesn't change behavior, but saves
6336 a few bytes and will simplify future changes.
6337 * character.c (string_escape_byte8): Likewise.
6338 * lisp.h (string_overflow): New decl.
6340 Fixups, following up to the user-interface timestamp change.
6341 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6342 for UI timestamps, instead of unsigned long.
6343 * msdos.c (mouse_get_pos): Likewise.
6344 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6345 * w32gui.h (Time): Define by including "systime.h" rather than by
6346 declaring it ourselves. (Bug#8664)
6348 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6349 * image.c (clear_image_cache): Likewise.
6351 * term.c (term_mouse_position): Don't assume time_t wraparound.
6353 Be more systematic about user-interface timestamps.
6354 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6355 and sometimes 'EMACS_UINT', to represent these timestamps.
6356 This change causes it to use 'Time' uniformly, as that's what X uses.
6357 This makes the code easier to follow, and makes it easier to catch
6358 integer overflow bugs such as Bug#8664.
6359 * frame.c (Fmouse_position, Fmouse_pixel_position):
6360 Use Time, not unsigned long, for user-interface timestamps.
6361 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6362 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6363 * keyboard.h (last_event_timestamp): Likewise.
6364 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6365 * menu.h (xmenu_show): Likewise.
6366 * term.c (term_mouse_position): Likewise.
6367 * termhooks.h (struct input_event.timestamp): Likewise.
6368 (struct terminal.mouse_position_hook): Likewise.
6369 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6370 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6371 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6372 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6374 * menu.h, termhooks.h: Include "systime.h", for Time.
6376 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6377 Don't assume that the difference between two unsigned long values
6378 can fit into an integer. At this point, we know button_down_time
6379 <= event->timestamp, so the difference must be nonnegative, so
6380 there's no need to cast the result if double-click-time is
6381 nonnegative, as it should be; check that it's nonnegative, just in
6382 case. This bug is triggered when events are more than 2**31 ms
6383 apart (about 25 days). (Bug#8664)
6385 * xselect.c (last_event_timestamp): Remove duplicate decl.
6386 (x_own_selection): Remove needless cast to unsigned long.
6388 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6389 that always fit in int. Use a sentinel instead of a counter, to
6390 avoid a temp and to allay GCC's concerns about possible int overflow.
6391 * frame.h (struct frame): Use int for menu_bar_items_used
6392 instead of EMACS_INT, since it always fits in int.
6394 * menu.c (grow_menu_items): Check for int overflow.
6396 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6398 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6399 Before, the code was not consistent. These values cannot exceed
6400 2**31 - 1 so there's no need to make them unsigned.
6401 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6402 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6403 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6405 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6407 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6408 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6409 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6410 presumably because the widths might not match.
6412 * window.c (size_window): Avoid needless test at loop start.
6414 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6416 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6418 2011-05-12 Drew Adams <drew.adams@oracle.com>
6420 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6422 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6424 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6425 `width' to `bar_area_x' and `bar_area_width', respectively.
6426 (x_scroll_run): Take account of fringe background extension.
6428 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6429 Rename local vars `left' and `width' to `bar_area_x' and
6430 `bar_area_width', respectively.
6431 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6432 background extension.
6434 2011-05-10 Jim Meyering <meyering@redhat.com>
6436 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6438 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6440 * image.c (Finit_image_library): Return t for built-in image types,
6441 like pbm and xbm. (Bug#8640)
6443 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6445 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6447 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6449 * w32console.c (Fset_screen_color): Doc fix.
6450 (Fget_screen_color): New function.
6451 (syms_of_ntterm): Defsubr it.
6453 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6454 unlink the temporary file if Fcall_process didn't create it in the
6456 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6457 child process will be redirected to a file specified with `:file'.
6458 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6459 cue to call_process_cleanup not to close that handle.
6461 2011-05-07 Ben Key <bkey76@gmail.com>
6463 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6464 one of two shell specific rules, either bootstrap-temacs-CMD or
6465 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6466 to the previous implementation of the bootstrap-temacs rule.
6467 The bootstrap-temacs-CMD rule is similar to the previous
6468 implementation of the bootstrap-temacs rule except that it
6469 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6472 These changes, along with some changes to nt/configure.bat,
6473 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6474 earlier fix to add support for --cflags and --ldflags options
6475 that include quotes so that it works whether make uses cmd or
6478 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6480 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6481 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6483 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6484 a string. Handle both cases.
6485 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6486 (Fdbus_register_method): Use Qinvalid_function.
6488 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6490 * makefile.w32-in: Update dependencies.
6491 (LISP_H): Add inttypes.h and stdin.h.
6492 (PROCESS_H): Add unistd.h.
6494 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6496 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6497 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6499 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6501 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6503 * term.c (vfatal): Remove stray call to va_end.
6504 It's not needed and the C Standard doesn't allow it here anyway.
6506 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6507 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6509 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6512 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6514 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6516 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6518 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6520 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6522 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6523 * charset.c (Fdefine_charset_internal): Don't initialize
6524 charset.code_space[15]. The value was garbage, on hosts with
6525 32-bit int (Bug#8600).
6527 * lread.c (read_integer): Be more consistent with string-to-number.
6528 Use string_to_number to do the actual conversion; this avoids
6529 rounding errors and fixes some other screwups. Without this fix,
6530 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6531 (digit_to_number): Move earlier, for benefit of read_integer.
6532 Return -1 if the digit is out of range for the base, -2 if it is
6533 not a digit in any supported base. (Bug#8602)
6535 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6537 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6538 to match comment at start of function. This also removes a
6539 GCC warning about overflow in a 32+64-bit port.
6541 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6543 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6544 Reported by Stefan Monnier in
6545 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6546 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6547 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6549 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6550 (EMACS_UINTPTR): Likewise, with uintptr_t.
6552 * lisp.h: Prefer 64-bit EMACS_INT if available.
6553 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6554 on 32-bit hosts that have 64-bit int, so that they can access
6556 However, temporarily disable this change unless the temporary
6557 symbol WIDE_EMACS_INT is defined.
6559 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6561 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6562 This removes an assumption that EMACS_INT and long are the same
6563 width as pointers. The assumption is true for Emacs porting targets
6564 now, but we want to make other targets possible.
6565 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6566 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6567 In the rest of the code, change types of integers that hold casted
6568 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6569 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6570 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6571 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6572 No need to cast type when ORing.
6573 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6574 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6575 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6576 assume EMACS_INT is the same width as char *.
6577 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6578 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6579 Remove no-longer-needed casts.
6580 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6581 (xg_tool_bar_help_callback, xg_make_tool_item):
6582 Use EMACS_INTPTR to hold an integer
6583 that will be cast to void *; this can avoid a GCC warning
6584 if EMACS_INT is not the same width as void *.
6585 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6586 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6587 (current_message_1, set_message_1):
6588 Use a local to convert to proper width without a cast.
6589 * xmenu.c (dialog_selection_callback): Likewise.
6591 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6592 Also, don't assume VALBITS / RAND_BITS is less than 5,
6593 and don't rely on undefined behavior when shifting a 1 left into
6595 * lisp.h (get_random): Change signature to match.
6597 * lread.c (hash_string): Use size_t, not int, for hash computation.
6598 Normally we prefer signed values; but hashing is special, because
6599 it's better to use unsigned division on hash table sizes so that
6600 the remainder is nonnegative. Also, size_t is the natural width
6601 for hashing into memory. The previous code used 'int', which doesn't
6602 retain enough info to hash well into very large tables.
6603 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6605 * dbusbind.c: Don't possibly lose pointer info when converting.
6606 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6607 Use XPNTR rather than XHASH, so that the high-order bits of
6608 the pointer aren't lost when converting through void *.
6610 * eval.c (Fautoload): Don't double-shift a pointer.
6612 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6614 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6616 * gnutls.c (DEF_GNUTLS_FN):
6617 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6619 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6621 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6624 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6626 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6627 New version that can reserve upto 2GB of heap space.
6629 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6631 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6633 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6635 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6636 `gnutls_certificate_set_x509_key_file'.
6638 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6640 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6641 Update dependencies.
6643 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6645 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6646 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6647 Remove unused parameter `fildes'.
6648 * process.c (read_process_output, send_process): Don't pass it.
6650 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6652 Fix previous change: the library cache is defined in w32.c.
6653 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6654 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6656 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6658 Implement dynamic loading of GnuTLS on Windows.
6660 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6661 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6662 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6665 * gnutls.c (Qgnutls_dll): Define.
6666 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6667 (gnutls_*): Declare function pointers.
6668 (init_gnutls_functions): New function to initialize function pointers.
6669 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6670 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6671 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6672 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6673 (emacs_gnutls_write, emacs_gnutls_read)
6674 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6675 (Fgnutls_available_p): New function.
6676 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6677 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6678 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6680 * image.c: Include w32.h.
6681 (Vimage_type_cache): Delete.
6682 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6683 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6684 (w32_delayed_load): Move to w32.c.
6686 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6688 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6689 (w32_delayed_load): Move from image.c. When loading a library, record
6690 its filename in the :loaded-from property of the library id.
6691 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6692 Initialize and staticpro them.
6693 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6695 * process.c: Include lisp.h before w32.h, not after.
6696 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6697 instead of gnutls_record_check_pending.
6699 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6701 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6703 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6704 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6707 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6709 * xterm.c (x_set_frame_alpha): Do not set property on anything
6710 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6712 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6714 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6716 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6718 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6719 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6720 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6721 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6722 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6723 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6724 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6725 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6726 (Qgnutls_bootprop_callbacks_verify): Make static.
6728 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6730 * callproc.c: Indentation fixup.
6732 * sysdep.c (wait_for_termination_1): Make static.
6733 (wait_for_termination, interruptible_wait_for_termination):
6734 Move after wait_for_termination_1.
6736 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6738 * sysdep.c (interruptible_wait_for_termination): New function
6739 which is like wait_for_termination, but allows keyboard
6742 * callproc.c (Fcall_process): Add (:file "file") as an option for
6744 (Fcall_process_region): Ditto.
6746 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6748 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6749 rather than `XVECTOR (FOO)->size'.
6751 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6752 inttypes.h, as a gnulib replacement is used if it not available in
6755 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6757 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6758 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6759 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6761 * coding.c (coding_alloc_by_realloc): Error out if destination
6762 will grow beyond MOST_POSITIVE_FIXNUM.
6763 (decode_coding_emacs_mule): Abort if there isn't enough place in
6764 charbuf for the composition carryover bytes. Reserve an extra
6765 space for up to 2 characters produced in a loop.
6766 (decode_coding_iso_2022): Abort if there isn't enough place in
6767 charbuf for the composition carryover bytes.
6769 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6771 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6772 aborting when %lld or %lll format is passed.
6773 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6774 %llo or %llx format is passed. (Bug#8545)
6776 * window.c (window_scroll_line_based): Use a marker instead of
6777 simple variables to record original value of point. (Bug#7952)
6779 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6780 produced by %s or %c overflows available buffer space. (Bug#8545)
6782 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6784 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6785 (SIZE_MAX): Move defn after all includes, as they might #define it.
6787 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6789 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6791 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6793 * keyboard.c (Qdelayed_warnings_hook): Define.
6794 (command_loop_1): Run `delayed-warnings-hook'
6795 if Vdelayed_warnings_list is non-nil.
6796 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6797 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6799 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6801 * doprnt.c (doprnt): Don't return value smaller than the buffer
6802 size if the message was truncated. (Bug#8545).
6804 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6806 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6807 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6809 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6811 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6813 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6815 * makefile.w32-in: Update dependencies.
6817 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6819 Improve `doprnt' and its usage. (Bug#8545)
6820 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6821 `format_end'. Remove support for %l as a conversion specifier.
6822 Don't use xrealloc. Improve diagnostics when the %l size modifier
6823 is used. Update the commentary.
6825 * eval.c (verror): Simplify calculation of size_t.
6827 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6830 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6832 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6835 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6837 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6838 This makes this file independent of the recent pseudovector change.
6840 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6842 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6844 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6845 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6846 Remove unused local.
6847 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6849 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6850 GCC 4.6.0 optimizes based on type-based alias analysis.
6851 For example, if b is of type struct buffer * and v of type struct
6852 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6853 != &v->size, and therefore "v->size = 1; b->size = 2; return
6854 v->size;" must therefore return 1. This assumption is incorrect
6855 for Emacs, since it type-puns struct Lisp_Vector * with many other
6856 types. To fix this problem, this patch adds a new type struct
6857 vectorlike_header that documents the constraints on layout of vectors
6858 and pseudovectors, and helps optimizing compilers not get fooled
6859 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6860 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6861 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6863 (XSETPVECTYPE): Rewrite in terms of new macro.
6864 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6865 This is a bit clearer, and further avoids the possibility of
6866 undesirable aliasing.
6867 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6868 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6869 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6870 since Lisp_Subr is a special case (no "next" field).
6871 (ASIZE): Now uses header.size rather than size.
6872 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6873 to avoid the hassle of writing XVECTOR (foo)->header.size.
6874 (struct vectorlike_header): New type.
6875 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6876 object, to help avoid aliasing.
6877 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6878 (SUBRP): Likewise, since Lisp_Subr is a special case.
6879 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6880 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6881 (struct Lisp_Hash_Table): Combine first two members into a single
6882 struct vectorlike_header member. All uses of "size" and "next" members
6883 changed to be "header.size" and "header.next".
6884 * buffer.h (struct buffer): Likewise.
6885 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6886 * frame.h (struct frame): Likewise.
6887 * process.h (struct Lisp_Process): Likewise.
6888 * termhooks.h (struct terminal): Likewise.
6889 * window.c (struct save_window_data, struct saved_window): Likewise.
6890 * window.h (struct window): Likewise.
6891 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6892 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6893 * buffer.c (init_buffer_once): Likewise.
6894 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6896 * process.c (Fformat_network_address): Use local var for size,
6899 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6901 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6902 * data.c (atof): Remove decl; no longer used or needed.
6903 (digit_to_number): Move to lread.c.
6904 (Fstring_to_number): Use new string_to_number function, to be
6905 consistent with how the Lisp reader treats infinities and NaNs.
6906 Do not assume that floating-point numbers represent EMACS_INT
6907 without losing information; this is not true on most 64-bit hosts.
6908 Avoid double-rounding errors, by insisting on integers when
6909 parsing non-base-10 numbers, as the documentation specifies.
6910 * lisp.h (string_to_number): New decl, replacing ...
6911 (isfloat_string): Remove.
6912 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6913 (read1): Do not accept +. and -. as integers; this
6914 appears to have been a coding error. Similarly, do not accept
6915 strings like +-1e0 as floating point numbers. Do not report
6916 overflow for integer overflows unless the base is not 10 which
6917 means we have no simple and reliable way to continue.
6918 Break out the floating-point parsing into a new
6919 function string_to_number, so that Fstring_to_number parses
6920 floating point numbers consistently with the Lisp reader.
6921 (digit_to_number): Move here from data.c. Make it static inline.
6922 (E_CHAR, EXP_INT): Remove, replacing with ...
6923 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6924 (string_to_number): New function, replacing isfloat_string.
6925 This function checks for valid syntax and produces the resulting
6926 Lisp float number too. Rework it so that string-to-number
6927 no longer mishandles examples like "1.0e+". Use strtoumax,
6928 so that overflow for non-base-10 numbers is reported only when
6929 there's no portable and simple way to convert to floating point.
6931 * textprop.c (set_text_properties_1): Rewrite for clarity,
6932 and to avoid GCC warning about integer overflow.
6934 * intervals.h (struct interval): Use EMACS_INT for members
6935 where EMACS_UINT might cause problems. See
6936 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6937 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6938 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6940 (offset_intervals): Tell GCC not to worry about length overflow
6941 when negating a negative length.
6943 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6944 (overrun_check_free): Likewise.
6946 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6947 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6950 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6951 (gnutls_make_error): Rename local to avoid shadowing.
6952 (gnutls_emacs_global_deinit): ifdef out; not used.
6953 (Fgnutls_boot): Use const for pointer to readonly storage.
6954 Comment out unused local. Fix pointer signedness problems.
6956 * lread.c (openp): Don't stuff size_t into an 'int'.
6957 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6958 about possible signed overflow.
6960 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6961 (GDK_KEY_g): Don't define if already defined.
6962 (xg_prepare_tooltip): Avoid pointer signedness problem.
6963 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6965 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6966 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6968 * xfns.c (Fx_window_property): Simplify a bit,
6969 to make a bit faster and to avoid GCC 4.6.0 warning.
6970 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6972 * fns.c (internal_equal): Don't assume size_t fits in int.
6974 * alloc.c (compact_small_strings): Tighten assertion a little.
6976 Replace pEd with more-general pI, and fix some printf arg casts.
6977 * lisp.h (pI): New macro, generalizing old pEd macro to other
6978 conversion specifiers. For example, use "...%"pI"d..." rather
6979 than "...%"pEd"...".
6980 (pEd): Remove. All uses replaced with similar uses of pI.
6981 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6982 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6983 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6984 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6985 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6986 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6987 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6989 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6990 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6991 * print.c (safe_debug_print, print_object): Likewise.
6992 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6994 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6995 avoiding the 0 flag, which is not portable.
6996 * process.c (Fmake_network_process): Use pI to avoid cast.
6997 * region-cache.c (pp_cache): Likewise.
6998 * xdisp.c (decode_mode_spec): Likewise.
6999 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7000 behavior on 64-bit hosts with printf arg.
7001 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7002 (x_stop_queuing_selection_requests): Likewise.
7003 (x_get_window_property): Don't truncate byte count to an 'int'
7006 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7007 here, since it parses constructs like leading '-' and spaces,
7008 which are not wanted; and it overflows with large numbers.
7009 Instead, simply match F[0-9]+, which is what is wanted anyway.
7011 * alloc.c: Remove unportable assumptions about struct layout.
7012 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7013 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7014 (allocate_vectorlike, make_pure_vector): Use the new macros,
7015 plus offsetof, to remove unportable assumptions about struct layout.
7016 These assumptions hold on all porting targets that I know of, but
7017 they are not guaranteed, they're easy to remove, and removing them
7018 makes further changes easier.
7020 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7021 This doesn't fix a bug but makes the code clearer.
7022 (string_overrun_cookie): Now const. Use initializers that
7023 don't formally overflow signed char, to avoid warnings.
7024 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7025 can cause Emacs to crash when string overrun checking is enabled.
7026 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7027 multiple of sizeof (EMACS_INT); it need not be, if
7028 alignof(EMACS_INT) < sizeof (EMACS_INT).
7029 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7031 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7033 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7035 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7037 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7038 supposed to be handshaking. (Bug#8556)
7039 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7041 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7043 * lisp.h (Qdebug): List symbol.
7044 * eval.c (Qdebug): Restore global linkage.
7045 * keyboard.c (debug-on-event): New variable.
7046 (handle_user_signal): Break into debugger when debug-on-event
7047 matches the current signal symbol.
7049 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7051 * alloc.c (check_sblock, check_string_bytes)
7052 (check_string_free_list): Convert to standard C.
7054 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7056 * w32.c (emacs_gnutls_push): Fix typo.
7058 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7060 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7061 "cast to pointer from integer of different size".
7063 Improve doprnt and its use in verror. (Bug#8545)
7064 * doprnt.c (doprnt): Document the set of format control sequences
7065 supported by the function. Use SAFE_ALLOCA instead of always
7068 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7069 is one byte too soon. Don't use xrealloc; instead xfree and
7072 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7074 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7077 * gnutls.c: Renamed global_initialized to
7078 gnutls_global_initialized. Added internals for the
7079 :verify-hostname-error, :verify-error, and :verify-flags
7080 parameters of `gnutls-boot' and documented those parameters in the
7081 docstring. Start callback support.
7082 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7083 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7084 on error. Return error code.
7085 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7086 (emacs_gnutls_read): Likewise.
7087 (Fgnutls_boot): Return handshake error code.
7088 (emacs_gnutls_handle_error): New function.
7089 (wsaerror_to_errno): Likewise.
7091 * w32.h (emacs_gnutls_pull): Add prototype.
7092 (emacs_gnutls_push): Likewise.
7094 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7095 (emacs_gnutls_push): Likewise.
7097 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7099 * process.c (wait_reading_process_output): Check if GnuTLS
7100 buffered some data internally if no FDs are set for TLS
7103 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7104 (LIBS): Link to USER_LIBS.
7105 ($(BLD)/gnutls.$(0)): New target.
7107 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7109 * xdisp.c (handle_single_display_spec): Rename the
7110 display_replaced_before_p argument into display_replaced_p, to
7111 make it consistent with the commentary. Fix typos in the
7114 * textprop.c (syms_of_textprop): Remove dead code.
7115 (copy_text_properties): Delete obsolete commentary about an
7116 interface that was deleted long ago. Fix typos in the description
7119 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7120 to changes in oldXMenu/XMenu.h from 2011-04-16.
7121 <menu_help_message, prev_menu_help_message>: Constify.
7122 (IT_menu_make_room): menu->help_text is now `const char **';
7125 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7126 to changes in oldXMenu/XMenu.h from 2011-04-16.
7127 (struct XMenu): Declare `help_text' `const char **'.
7129 * xfaces.c <Qunspecified>: Make extern again.
7131 * syntax.c: Include sys/types.h before including regex.h, as
7134 * doc.c (get_doc_string): Improve the format passed to `error'.
7136 * doprnt.c (doprnt): Improve commentary.
7138 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7140 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7143 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7144 changes in globals.h immediately force recompilation.
7145 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7146 $(CURDIR)/s/ms-w32.h.
7147 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7149 * character.c (Fchar_direction): Function deleted.
7150 (syms_of_character): Don't defsubr it.
7151 <char-direction-table>: Deleted.
7153 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7155 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7156 * doprnt.c: Include limits.h.
7157 (SIZE_MAX): New macro.
7158 (doprnt): Return a size_t value. 2nd arg is now size_t.
7159 Many local variables are now size_t instead of int or unsigned.
7160 Improve overflow protection. Support `l' modifier for integer
7161 conversions. Support %l conversion. Don't assume an EMACS_INT
7162 argument for integer conversions and for %c.
7164 * lisp.h (doprnt): Restore prototype.
7166 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7169 * Makefile.in (base_obj): Add back doprnt.o.
7171 * deps.mk (doprnt.o): Add back prerequisites.
7172 (callint.o): Depend on character.h.
7174 * eval.c (internal_lisp_condition_case): Include the handler
7175 representation in the error message.
7176 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7177 when breaking from the loop.
7179 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7181 * callint.c (Fcall_interactively): When displaying error message
7182 about invalid control letter, pass the character's codepoint, not
7183 a pointer to its multibyte form. Improve display of the character
7184 in octal and display also its hex code.
7186 * character.c (char_string): Use %x to display the (unsigned)
7187 codepoint of an invalid character, to avoid displaying a bogus
7190 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7191 `error', not SYMBOL_NAME itself.
7193 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7194 character arguments to `error'.
7196 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7197 to `error' in error message about FINAL_CHAR argument. Make sure
7198 FINAL_CHAR is a character, and use %c when it is passed as
7199 argument to `error'.
7201 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7203 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7205 * w32.c: Include <time.h>.
7206 (sys_localtime): New function.
7208 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7210 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7212 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7214 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7216 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7219 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7221 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7222 gl_state.e_property when gl_state.object is Qt.
7224 * insdel.c (make_gap_larger): Remove limitation of buffer size
7227 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7229 * xdisp.c (lookup_glyphless_char_display)
7230 (produce_glyphless_glyph): Handle cons cell entry in
7231 glyphless-char-display.
7232 (Vglyphless_char_display): Document it.
7234 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7235 glyphless-char-display.
7237 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7239 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7241 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7243 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7244 definition for no-X builds.
7246 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7248 Static checks with GCC 4.6.0 and non-default toolkits.
7250 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7252 * process.c (keyboard_bit_set): Define only if SIGIO.
7253 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7254 (send_process): Repair possible setjmp clobbering.
7256 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7258 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7260 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7262 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7263 Define only if needed.
7265 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7266 by pacifying GCC about it. Maybe it's time to retire it?
7267 * xfaces.c (USG, __TIMEVAL__): Likewise.
7269 * dispextern.h (struct redisplay_interface): Rename param
7271 * termhooks.h (struct terminal): Likewise.
7272 * xterm.c (xembed_send_message): Likewise.
7274 * insdel.c (make_gap_smaller): Define only if
7275 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7277 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7280 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7281 so that we aren't warned about unused symbols.
7283 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7285 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7287 * xfns.c (x_real_positions): Mark locals as initialized.
7289 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7291 * xterm.c: Fix problems found by static analysis with other toolkits.
7292 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7293 (x_dispatch_event): Declare static if USE_GTK, and
7294 define if USE_GTK || USE_X_TOOLKIT.
7295 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7296 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7297 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7298 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7300 * xmenu.c (menu_help_callback): Pointer type fixes.
7301 Use const pointers when pointing at readonly data. Avoid pointer
7303 (FALSE): Remove unused macro.
7304 (update_frame_menubar): Remove unused decl.
7306 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7308 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7309 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7310 (single_menu_item): Rename local to avoid shadowing.
7312 * keyboard.c (make_lispy_event): Remove unused local var.
7314 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7315 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7317 * bitmaps: Change bitmaps from unsigned char back to the X11
7318 compatible char. Avoid the old compiler warnings about
7319 out-of-range initializers by using, for example, '\xab' rather
7322 * xgselect.c (xgselect_initialize): Check vs interface
7323 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7325 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7327 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7328 to read-only memory.
7330 * fns.c (vector): Remove; this old hack is no longer needed.
7332 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7334 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7336 * xrdb.c (x_load_resources): Omit unused local.
7338 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7339 (x_window): Rename locals to avoid shadowing.
7340 (USG): Use the kludged USG macro, to pacify gcc.
7342 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7343 (x_term_init): Remove local to avoid shadowing.
7345 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7347 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7348 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7350 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7352 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7354 Fix regex.c, syntax.c and friends for buffers > 2GB.
7355 * syntax.h (struct gl_state_s): Declare character position members
7358 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7360 * textprop.c (verify_interval_modification, interval_of):
7361 Declare arguments EMACS_INT.
7363 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7366 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7368 * indent.c (Fvertical_motion): Local variable it_start is now
7371 * regex.c (re_match, re_match_2, re_match_2_internal)
7372 (bcmp_translate, regcomp, regexec, print_double_string)
7373 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7374 (re_compile_pattern, re_exec): Declare arguments and local
7375 variables `size_t' and `ssize_t' and return values `regoff_t', as
7377 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7378 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7379 <compile_stack_type>: `size' and `avail' are now `size_t'.
7381 * regex.h <regoff_t>: Use ssize_t, not int.
7382 (re_search, re_search_2, re_match, re_match_2): Arguments that
7383 specify buffer/string position and length are now ssize_t and
7384 size_t. Return type is regoff_t.
7386 2011-04-16 Ben Key <bkey76@gmail.com>
7388 * nsfont.m: Fixed bugs in ns_get_family and
7389 ns_descriptor_to_entity that were caused by using free to
7390 deallocate memory blocks that were allocated by xmalloc (via
7391 xstrdup). This caused Emacs to crash when compiled with
7392 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7393 --enable-checking=xmallocoverrun). xfree is now used to
7394 deallocate these memory blocks.
7396 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7398 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7400 emacs_write: Accept and return EMACS_INT for sizes.
7401 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7403 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7404 Accept and return EMACS_INT.
7405 (emacs_gnutls_write): Return the number of bytes written on
7407 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7408 (emacs_read, emacs_write): Remove check for negative size, as the
7409 Emacs source code has been audited now.
7410 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7411 (emacs_read, emacs_write): Use it.
7412 * process.c (send_process): Adjust to the new signatures of
7413 emacs_write and emacs_gnutls_write. Do not attempt to store
7414 a byte offset into an 'int'; it might overflow.
7415 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7417 * sound.c: Don't assume sizes fit in 'int'.
7418 (struct sound_device.period_size, alsa_period_size):
7419 Return EMACS_INT, not int.
7420 (struct sound_device.write, vox_write, alsa_write):
7421 Accept EMACS_INT, not int.
7422 (wav_play, au_play): Use EMACS_INT to store sizes and to
7423 record read return values.
7425 2011-04-15 Ben Key <bkey76@gmail.com>
7427 * keyboard.c (Qundefined): Don't declare static since it is used
7429 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7430 static since they are used in nsfont.m.
7432 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7434 * process.c (Qprocessp): Don't declare static.
7435 * lisp.h (Qprocessp): Declare again.
7437 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7439 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7441 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7443 Improve C-level modularity by making more things 'static'.
7445 Don't publish debugger-only interfaces to other modules.
7446 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7447 (verify_bytepos, count_markers): Move decls to the only modules
7449 * region-cache.h (pp_cache): Likewise.
7450 * window.h (check_all_windows): Likewise.
7451 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7453 * sysdep.c (croak): Now static, if
7454 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7455 * syssignal.h (croak): Declare only if not static.
7457 * alloc.c (refill_memory_reserve): Now static if
7458 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7459 * lisp.h (refill_memory_reserve): Declare only if not static.
7461 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7462 Define only if USE_LUCID.
7464 * xrdb.c (x_customization_string, x_rm_string): Now static.
7466 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7467 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7469 * xdisp.c (draw_row_with_mouse_face): Now static.
7470 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7472 * window.h (check_all_windows): Mark externally visible.
7474 * window.c (window_deletion_count): Now static.
7476 * undo.c: Make symbols static if they're not exported.
7477 (last_undo_buffer, last_boundary_position, pending_boundary):
7480 * textprop.c (interval_insert_behind_hooks): Now static.
7481 (interval_insert_in_front_hooks): Likewise.
7483 * term.c: Make symbols static if they're not exported.
7484 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7485 (max_frame_lines, tty_set_terminal_modes):
7486 (tty_reset_terminal_modes, tty_turn_off_highlight):
7487 (get_tty_terminal): Now static.
7488 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7489 * termhooks.h (term_mouse_moveto): Do not declare if
7491 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7492 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7494 * sysdep.c: Make symbols static if they're not exported.
7495 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7497 (sigprocmask_set, full_mask): Remove; unused.
7498 (wait_debugging): Mark as visible.
7499 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7500 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7502 * syntax.c (syntax_temp): Define only if !__GNUC__.
7504 * sound.c (current_sound_device, current_sound): Now static.
7506 * search.c (searchbufs, searchbuf_head): Now static.
7508 * scroll.c (scroll_cost): Remove; unused.
7509 * dispextern.h (scroll_cost): Remove decl.
7511 * region-cache.h (pp_cache): Mark as externally visible.
7513 * process.c: Make symbols static if they're not exported.
7514 (process_tick, update_tick, create_process, chan_process):
7515 (Vprocess_alist, proc_buffered_char, datagram_access):
7516 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7517 (deactivate_process): Mark defn as static, as well as decl.
7518 * lisp.h (create_process): Remove decl.
7519 * process.h (chan_process, Vprocess_alist): Remove decls.
7521 * print.c: Make symbols static if they're not exported.
7522 (print_depth, new_backquote_output, being_printed, print_buffer):
7523 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7524 (print_interval, print_number_index, initial_stderr_stream):
7526 * lisp.h (Fprinc): Remove decl.
7527 (debug_output_compilation_hack): Mark as externally visible.
7529 * sysdep.c (croak): Move decl from here to syssignal.h.
7530 * syssignal.h (croak): Put it here, so the API can be checked when
7531 'croak' is called from dissociate_if_controlling_tty.
7533 * minibuf.c: Make symbols static if they're not exported.
7534 (minibuf_save_list, choose_minibuf_frame): Now static.
7535 * lisp.h (choose_minibuf_frame): Remove decl.
7537 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7539 * lread.c: Make symbols static if they're not exported.
7540 (read_objects, initial_obarray, oblookup_last_bucket_number):
7542 (make_symbol): Remove; unused.
7543 * lisp.h (initial_obarray, make_symbol): Remove decls.
7545 * keyboard.c: Make symbols static if they're not exported.
7546 (single_kboard, recent_keys_index, total_keys, recent_keys):
7547 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7548 (this_single_command_key_start, echoing, last_auto_save):
7549 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7550 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7551 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7552 (Vlispy_mouse_stem, double_click_count):
7554 (force_auto_save_soon): Define only if SIGDANGER.
7555 (ignore_mouse_drag_p): Now static if
7556 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7557 (print_help): Remove; unused.
7558 (stop_character, last_timer_event): Mark as externally visible.
7559 * keyboard.h (ignore_mouse_drag_p): Declare only if
7560 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7561 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7562 * lisp.h (echoing): Remove decl.
7563 (force_auto_save_soon): Declare only if SIGDANGER.
7564 * xdisp.c (redisplay_window): Simplify code, to make it more
7565 obvious that ignore_mouse_drag_p is not accessed if !defined
7566 USE_GTK && !defined HAVE_NS.
7568 * intervals.c: Make symbols static if they're not exported.
7569 (merge_properties_sticky, merge_interval_right, delete_interval):
7571 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7573 * insdel.c: Make symbols static if they're not exported.
7574 However, leave prepare_to_modify_buffer alone. It's never
7575 called from outside this function, but that appears to be a bug.
7576 (combine_after_change_list, combine_after_change_buffer):
7577 (adjust_after_replace, signal_before_change): Now static.
7578 (adjust_after_replace_noundo): Remove; unused.
7579 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7580 (signal_before_change): Remove decls.
7582 * indent.c (val_compute_motion, val_vmotion): Now static.
7584 * image.c: Make symbols static if they're not exported.
7585 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7587 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7588 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7590 * fringe.c (standard_bitmaps): Now static.
7591 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7593 * frame.c: Make symbols static if they're not exported.
7594 (x_report_frame_params, make_terminal_frame): Now static.
7595 (get_frame_param): Now static, unless HAVE_NS.
7596 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7597 (x_get_resource_string): Remove; not used.
7598 * frame.h (make_terminal_frame, x_report_frame_params):
7599 (x_get_resource_string); Remove decls.
7600 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7601 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7603 * font.c, fontset.c: Make symbols static if they're not exported.
7604 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7605 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7606 * font.c (font_close_object): Now static.
7607 * font.h (font_close_object): Remove.
7608 * fontset.c (FONTSET_OBJLIST): Remove.
7609 (free_realized_fontset) #if-0 the body, which does nothing.
7610 (face_suitable_for_char_p): #if-0, as it's never called.
7611 * fontset.h (face_suitable_for_char_p): Remove decl.
7612 * xfaces.c (face_at_string_position):
7613 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7614 since 0 is always ASCII.
7616 * fns.c (weak_hash_tables): Now static.
7618 * fileio.c: Make symbols static if they're not exported.
7619 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7620 (Vwrite_region_annotation_buffers): Now static.
7622 * eval.c: Make symbols static if they're not exported.
7623 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7624 * lisp.h (backtrace_list): Remove decl.
7626 * emacs.c: Make symbols static if they're not exported.
7627 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7628 (fatal_error_code, fatal_error_signal_hook, standard_args):
7630 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7631 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7632 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7633 * lisp.h (fatal_error_signal_hook): Remove decl.
7634 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7636 * editfns.c: Move a (normally-unused) function to its only use.
7637 * editfns.c, lisp.h (get_operating_system_release): Remove.
7638 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7639 worth the hassle of breaking this out.
7641 * xterm.c: Make symbols static if they're not exported.
7642 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7643 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7644 (x_destroy_window, x_delete_display):
7646 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7647 (x_mouse_leave): Remove; unused.
7648 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7649 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7650 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7652 (x_mouse_leave): Declare only if WINDOWSNT.
7653 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7654 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7657 * ftxfont.c: Make symbols static if they're not exported.
7658 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7660 * font.h (ftxfont_driver): Likewise.
7662 * xfns.c: Make symbols static if they're not exported.
7663 (x_last_font_name, x_display_info_for_name):
7664 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7665 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7666 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7667 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7668 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7669 (last_show_tip_args): Now static.
7670 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7671 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7672 (x_screen_planes): Remove; unused.
7673 * dispextern.h (x_screen_planes): Remove decl.
7675 * dispnew.c: Make symbols static if they're not exported.
7676 * dispextern.h (redraw_garbaged_frames, scrolling):
7677 (increment_row_positions): Remove.
7678 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7679 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7681 (redraw_garbaged_frames): Remove; unused.
7683 * xfaces.c: Make symbols static if they're not exported.
7684 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7686 * xterm.h (defined_color): Remove decls.
7687 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7688 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7689 (menu_face_changed_default, defined_color, free_realized_face):
7690 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7691 (ascii_face_of_lisp_face): Remove; unused.
7693 * xdisp.c: Make symbols static if they're not exported.
7694 * dispextern.h (scratch_glyph_row, window_box_edges):
7695 (glyph_to_pixel_coords, set_cursor_from_row):
7696 (get_next_display_element, set_iterator_to_next):
7697 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7698 (show_mouse_face): Remove decls
7699 * frame.h (message_buf_print): Likewise.
7700 * lisp.h (pop_message, set_message, check_point_in_composition):
7702 * xterm.h (set_vertical_scroll_bar): Likewise.
7703 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7704 (message_buf_print, scratch_glyph_row, displayed_buffer):
7705 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7706 (get_next_display_element, show_mouse_face, window_box_edges):
7707 (frame_to_window_pixel_xy, check_point_in_composition):
7708 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7709 (glyph_to_pixel_coords): Remove; unused.
7711 * dired.c (file_name_completion): Now static.
7713 * dbusbind.c (xd_in_read_queued_messages): Now static.
7715 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7716 * data.c (circular_list_error): Remove.
7718 * commands.h (last_point_position, last_point_position_buffer):
7719 (last_point_position_window): Remove decls.
7720 * keyboard.c: Make these variables static.
7722 * coding.h (coding, code_convert_region, encode_coding_gap):
7724 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7725 (iso_code_class, detect_coding, code_convert_region): Now static.
7726 (encode_coding_gap): Remove; unused.
7728 * chartab.c (chartab_chars, chartab_bits): Now static.
7730 * charset.h (charset_iso_8859_1): Remove decl.
7731 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7734 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7735 * ccl.c (Vccl_program_table): Now static.
7736 (check_ccl_update): Remove; unused.
7738 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7739 * category.h: ... from here.
7740 * category.c (check_category_table, set_category_set): Now static.
7742 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7743 * lisp.h: Remove these decls.
7745 * buffer.c (buffer_count): Remove unused var.
7747 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7748 so that it's not optimized away.
7749 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7750 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7751 exported only to the debugger.
7753 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7754 * atimer.h (run_all_atimers): Remove; not exported.
7756 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7757 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7758 was inaccessible from Lisp.
7759 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7760 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7762 alloc.c: Import and export fewer symbols, and remove unused items.
7763 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7765 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7766 it's not optimized away by whole-program optimization.
7767 (message_enable_multibyte, free_misc): Remove.
7768 (catchlist, handlerlist, mark_backtrace):
7769 Declare only if BYTE_MARK_STACK.
7770 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7771 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7772 (message_enable_multibyte): Remove decl.
7773 (free_misc, interval_free_list, float_block, float_block_index):
7774 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7775 (cons_free_list, last_marked_index):
7777 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7778 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7779 (mark_backtrace): Define only if BYTE_MARK_STACK.
7780 * xdisp.c (message_enable_multibyte): Now static.
7782 Declare Lisp_Object Q* variables to be 'static' if not exported.
7783 This makes it easier for human readers (and static analyzers)
7784 to see whether these variables are used from other modules.
7785 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7786 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7787 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7788 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7789 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7790 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7791 * xmenu.c, xselect.c:
7792 Declare Q* vars static if they are not used in other modules.
7793 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7794 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7795 Remove decls of unexported vars.
7796 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7798 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7800 Make Emacs functions such as Fatom 'static' by default.
7801 This makes it easier for human readers (and static analyzers)
7802 to see whether these functions can be called from other modules.
7803 DEFUN now defines a static function. To make the function external
7804 so that it can be used in other C modules, use the new macro DEFUE.
7805 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7806 (Finit_image_library):
7807 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7808 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7809 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7810 Remove decls, since these functions are now static.
7811 (Funintern, Fget_internal_run_time): New decls, since these functions
7812 were already external.
7814 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7815 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7816 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7817 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7818 * keyboard.c, keymap.c, lread.c:
7819 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7820 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7821 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7822 Mark functions with DEFUE instead of DEFUN,
7823 if they are used in other modules.
7824 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7825 decls for now-static functions.
7826 * buffer.h (Fdelete_overlay): Remove decl.
7827 * callproc.c (Fgetenv_internal): Mark as internal.
7828 * composite.c (Fremove_list_of_text_properties): Remove decl.
7829 (Fcomposition_get_gstring): New forward static decl.
7830 * composite.h (Fcomposite_get_gstring): Remove decl.
7831 * dired.c (Ffile_attributes): New forward static decl.
7832 * doc.c (Fdocumntation_property): New forward static decl.
7833 * eval.c (Ffetch_bytecode): New forward static decl.
7834 (Funintern): Remove extern decl; now in .h file where it belongs.
7835 * fileio.c (Fmake_symbolic_link): New forward static decl.
7836 * image.c (Finit_image_library): New forward static decl.
7837 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7838 * intervals.h (Fprevious_property_change):
7839 (Fremove_list_of_text_properties): Remove decls.
7840 * keyboard.c (Fthis_command_keys): Remove decl.
7841 (Fcommand_execute): New forward static decl.
7842 * keymap.c (Flookup_key): New forward static decl.
7843 (Fcopy_keymap): Now static.
7844 * keymap.h (Flookup_key): Remove decl.
7845 * process.c (Fget_process): New forward static decl.
7846 (Fprocess_datagram_address): Mark as internal.
7847 * syntax.c (Fsyntax_table_p): New forward static decl.
7848 (skip_chars): Remove duplicate decl.
7849 * textprop.c (Fprevious_property_change): New forward static decl.
7850 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7852 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7853 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7855 * editfns.c (Fformat): Remove unreachable code.
7857 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7859 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7862 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7864 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7865 when at ZV. (Bug#8487)
7867 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7869 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7871 * keyboard.c (parse_tool_bar_item): Likewise.
7872 * sound.c (sound_cleanup, alsa_close): Likewise.
7873 * termcap.c (tgetent): Likewise.
7874 * xfns.c (x_default_font_parameter): Likewise.
7875 * xsettings.c (read_and_apply_settings): Likewise.
7877 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7878 (overrun_check_free): Protoize.
7880 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7882 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7883 since callers should never pass a negative size.
7884 Change the signature to match that of plain 'read' and 'write'; see
7885 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7886 * lisp.h: Update prototypes of emacs_write and emacs_read.
7888 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7890 * xdisp.c (redisplay_window): Don't try to determine the character
7891 position of the scroll margin if the window start point w->startp
7892 is outside the buffer's accessible region. (Bug#8468)
7894 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7896 Fix write-region and its subroutines for buffers > 2GB.
7897 * fileio.c (a_write, e_write): Modify declaration of arguments and
7898 local variables to support buffers larger than 2GB.
7899 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7901 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7902 argument, local variables, and return value.
7904 * lisp.h: Update prototypes of emacs_write and emacs_read.
7906 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7908 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7910 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7912 Fix more problems found by GCC 4.6.0's static checks.
7914 * xdisp.c (vmessage): Use a better test for character truncation.
7916 * charset.c (load_charset_map): <, not <=, for optimization,
7917 and to avoid potential problems with integer overflow.
7918 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7919 * casetab.c (set_identity, shuffle): Likewise.
7920 * editfns.c (Fformat): Likewise.
7921 * syntax.c (skip_chars): Likewise.
7923 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7924 This also lets GCC 4.6.0 generate slightly better loop code.
7926 * callint.c (Fcall_interactively): <, not <=, for optimization.
7927 (Fcall_interactively): Count the number of arguments produced,
7928 not the number of arguments given. This is simpler and lets GCC
7929 4.6.0 generate slightly better code.
7931 * ftfont.c: Distingish more carefully between FcChar8 and char.
7932 The previous code passed unsigned char * to a functions like
7933 strlen and xstrcasecmp that expect char *, which does not
7934 conform to the C standard.
7935 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7936 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7937 char * when the C standard requires it.
7939 * keyboard.c (read_char): Remove unused var.
7941 * eval.c: Port to Windows vsnprintf (Bug#8435).
7943 (SIZE_MAX): Define if the headers do not.
7944 (verror): Do not give up if vsnprintf returns a negative count.
7945 Instead, grow the buffer. This ports to Windows vsnprintf, which
7946 does not conform to C99. Problem reported by Eli Zaretskii.
7947 Also, simplify the allocation scheme, by avoiding the need for
7948 calling realloc, and removing the ALLOCATED variable.
7950 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7952 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7953 But keep the doprint source code for now, as we might revamp it
7954 and use it again (Bug#8435).
7955 * lisp.h (doprnt): Remove.
7956 * Makefile.in (base_obj): Remove doprnt.o.
7957 * deps.mk (doprnt.o): Remove.
7959 error: Print 32- and 64-bit integers portably (Bug#8435).
7960 Without this change, on typical 64-bit hosts error ("...%d...", N)
7961 was used to print both 32- and 64-bit integers N, which relied on
7963 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7964 * lisp.h (error, verror): Mark as printf-like functions.
7965 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7966 Report overflow in size calculations when allocating printf buffer.
7967 Do not truncate output string at its first null byte.
7968 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7969 Truncate the output at a character boundary, since vsnprintf does not
7971 * charset.c (check_iso_charset_parameter): Convert internal
7972 character to string before calling 'error', since %c now has the
7974 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7975 overflow when computing char to be passed to 'error'. Do not
7976 pass Lisp_Object to 'error'; pass the integer instead.
7977 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7978 formatted with plain %d.
7980 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7982 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7984 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7986 * xterm.c (x_catch_errors): Remove duplicate declaration.
7988 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7990 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7992 2011-04-10 Jim Meyering <meyering@redhat.com>
7994 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7995 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7996 return ssize_t not "int", and use size_t as the buffer length.
7997 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7998 * gnutls.h: Update declarations.
7999 * process.c (read_process_output): Use ssize_t, to match.
8000 (send_process): Likewise.
8002 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8004 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8006 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8008 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8009 Use unsigned char, to match FcChar8 type definition.
8011 * xterm.c (handle_one_xevent):
8012 * xmenu.c (create_and_show_popup_menu):
8013 * xselect.c (x_decline_selection_request)
8014 (x_reply_selection_request): Avoid type-punned deref of X events.
8016 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8018 Fix some uses of `int' instead of EMACS_INT.
8019 * search.c (string_match_1, fast_string_match)
8020 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8021 (scan_buffer, find_next_newline_no_quit)
8022 (find_before_next_newline, search_command, Freplace_match)
8023 (Fmatch_data): Make some `int' variables be EMACS_INT.
8025 * xdisp.c (display_count_lines): 3rd argument and return value now
8026 EMACS_INT. All callers changed.
8027 (pint2hrstr): Last argument is now EMACS_INT.
8029 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8030 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8031 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8032 (decode_coding_utf_16, decode_coding_emacs_mule)
8033 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8034 (decode_coding_ccl, decode_coding_charset)
8035 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8036 (decode_coding_iso_2022, decode_coding_emacs_mule)
8037 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8038 <char_offset, last_offset>: Declare EMACS_INT.
8039 (encode_coding_utf_8, encode_coding_utf_16)
8040 (encode_coding_emacs_mule, encode_invocation_designation)
8041 (encode_designation_at_bol, encode_coding_iso_2022)
8042 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8043 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8045 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8046 (encode_invocation_designation): Last argument P_NCHARS is now
8048 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8049 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8051 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8054 * ccl.c (Fccl_execute_on_string): Declare some variables
8057 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8059 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8061 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8063 * process.c (Fformat_network_address): Doc fix.
8065 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8067 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8069 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8071 * keyboard.c (read_char): Call Lisp function help-form-show,
8072 instead of using internal_with_output_to_temp_buffer.
8073 (Qhelp_form_show): New var.
8074 (syms_of_keyboard): Use DEFSYM macro.
8076 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8078 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8080 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8082 * process.c (Flist_processes): Remove to Lisp.
8083 (list_processes_1): Delete.
8085 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8087 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8089 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8091 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8093 Fix more problems found by GCC 4.6.0's static checks.
8095 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8097 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8099 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8101 * xdisp.c (vmessage): Mark as a printf-like function.
8103 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8105 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8107 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8108 printf-like functions.
8109 (tiff_load): Add casts to remove these marks before passing them
8110 to system-supplied API.
8112 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8114 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8115 This avoids several warnings with gcc -Wstrict-overflow.
8116 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8117 directly, rather than having caller test rule sign. This avoids
8118 some unnecessary tests.
8119 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8120 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8121 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8123 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8124 (xfont_open): Avoid unnecessary tests.
8126 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8128 * composite.h, composite.c (composition_gstring_put_cache):
8129 Use EMACS_INT, not int, for length.
8131 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8132 breaking out part of COMPOSITION_DECODE_RULE.
8133 (COMPOSITION_DECODE_RULE): Use it.
8134 * composite.c (get_composition_id): Remove unused local vars,
8135 by using the new macro.
8137 * textprop.c (set_text_properties_1): Change while to do-while,
8138 since the condition is always true at first.
8140 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8141 (interval_deletion_adjustment): Return unsigned value.
8144 * process.c (list_processes_1, create_pty, read_process_output):
8145 (exec_sentinel): Remove vars that were set but not used.
8146 (create_pty): Remove unnecessary "volatile"s.
8147 (Fnetwork_interface_info): Avoid possibility of int overflow.
8148 (read_process_output): Do adaptive read buffering even if carryover.
8149 (read_process_output): Simplify nbytes computation if buffered.
8151 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8153 * syntax.c (scan_words): Remove var that was set but not used.
8154 (update_syntax_table): Use unsigned instead of int.
8156 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8157 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8158 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8160 * print.c (print_error_message): Avoid int overflow.
8162 * font.c (font_list_entities): Redo for clarity,
8163 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8165 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8166 (font_score): Avoid potential overflow in diff calculation.
8168 * fns.c (substring_both): Remove var that is set but not used.
8169 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8171 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8173 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8174 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8175 can always succeed if overflow has undefined behavior.
8177 * search.c (boyer_moore, wordify): Remove vars set but not used.
8178 (wordify): Omit three unnecessary tests.
8180 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8181 All callers changed. This avoids the need for an unused var.
8183 * casefiddle.c (casify_region): Remove var that is set but not used.
8185 * dired.c (file_name_completion): Remove var that is set but not used.
8187 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8189 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8190 (Finsert_file_contents): Remove unnecessary code checking fd.
8192 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8193 Check for integer overflow on size calculations.
8195 * buffer.c (Fprevious_overlay_change): Remove var that is set
8198 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8199 Remove vars that are set but not used.
8200 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8201 (timer_check_2): Mark vars as initialized.
8203 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8205 * image.c (lookup_image): Remove var that is set but not used.
8206 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8208 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8209 that are set but not used.
8211 * xfns.c (make_invisible_cursor): Don't return garbage
8212 if XCreateBitmapFromData fails (Bug#8410).
8214 * xselect.c (x_get_local_selection, x_handle_property_notify):
8215 Remove vars that are set but not used.
8217 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8218 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8220 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8221 Remove var that is set but not used.
8222 (scroll_bar_windows_size): Now size_t, not int.
8223 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8226 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8227 (map_tty_color) [!defined MSDOS]: Likewise.
8229 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8231 * coding.c: Remove vars that are set but not used.
8232 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8233 All callers changed.
8234 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8235 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8236 (decode_coding_charset): Remove vars that are set but not used.
8238 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8239 that is set but not used.
8241 * print.c (print_object): Remove var that is set but not used.
8243 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8244 The gnulib version avoids calling malloc in the usual case,
8245 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8246 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8247 * filelock.c (current_lock_owner): Likewise.
8248 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8249 * sysdep.c: Include allocator.h, careadlinkat.h.
8250 (emacs_no_realloc_allocator): New static constant.
8251 (emacs_readlink): New function.
8252 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8253 ../lib/careadlinkat.h.
8255 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8257 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8258 first non-nil return value).
8260 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8262 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8263 if not defined (Bug#8403).
8265 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8267 * xdisp.c (display_count_lines): Remove parameter `start',
8268 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8269 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8270 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8271 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8272 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8273 and thereabouts. All callers changed.
8274 (get_per_char_metric): Remove parameter `f', unused since
8275 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8277 2011-04-02 Jim Meyering <meyering@redhat.com>
8279 do not dereference NULL upon failed strdup
8280 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8281 (ns_get_family): Likewise.
8283 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8285 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8287 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8289 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8292 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8294 Add lexical binding.
8296 * window.c (Ftemp_output_buffer_show): New fun.
8297 (Fsave_window_excursion):
8298 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8300 * lread.c (lisp_file_lexically_bound_p): New function.
8301 (Fload): Bind Qlexical_binding.
8302 (readevalloop): Remove `evalfun' arg.
8303 Bind Qinternal_interpreter_environment.
8304 (Feval_buffer): Bind Qlexical_binding.
8305 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8307 (syms_of_lread): Declare `lexical-binding'.
8309 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8311 * keyboard.c (eval_dyn): New fun.
8312 (menu_item_eval_property): Use it.
8314 * image.c (parse_image_spec): Use Ffunctionp.
8316 * fns.c (concat, mapcar1): Accept byte-code-functions.
8318 * eval.c (Fsetq): Handle lexical vars.
8319 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8320 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8321 (FletX, Flet): Obey lexical binding.
8322 (Fcommandp): Handle closures.
8323 (Feval): New `lexical' arg.
8324 (eval_sub): New function extracted from Feval. Use it almost
8325 everywhere where Feval was used. Look up vars in lexical env.
8327 (Ffunctionp): Move from subr.el.
8328 (Ffuncall): Handle closures.
8329 (apply_lambda): Remove `eval_flags'.
8330 (funcall_lambda): Handle closures and new byte-code-functions.
8331 (Fspecial_variable_p): New function.
8332 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8333 but without exporting it to Lisp.
8335 * doc.c (Fdocumentation, store_function_docstring):
8336 * data.c (Finteractive_form): Handle closures.
8338 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8341 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8343 (exec_byte_code): New function extracted from Fbyte_code to handle new
8344 calling convention for byte-code-functions. Add new byte-codes.
8346 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8348 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8350 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8352 * xdisp.c (redisplay_internal): Fix prototype.
8354 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8356 * xdisp.c (SCROLL_LIMIT): New macro.
8357 (try_scrolling): Use it when setting scroll_limit.
8358 Limit scrolling to 100 screen lines.
8359 (redisplay_window): Even when falling back on "recentering",
8360 position point in the window according to scroll-conservatively,
8361 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8363 (try_scrolling): When point is above the window, allow searching
8364 as far as scroll_max, or one screenful, to compute vertical
8365 distance from PT to the scroll margin position. This prevents
8366 try_scrolling from unnecessarily failing when
8367 scroll-conservatively is set to a value slightly larger than the
8368 window height. Clean up the case of PT below the margin at bottom
8369 of window: scroll_max can no longer be INT_MAX. When aggressive
8370 scrolling is in use, don't let point enter the opposite scroll
8371 margin as result of the scroll.
8372 (syms_of_xdisp) <scroll-conservatively>: Document the
8373 threshold of 100 lines for never-recentering scrolling.
8375 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8377 * dispextern.h (move_it_by_lines):
8378 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8379 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8380 (message_log_check_duplicate): Remove parameters `prev_bol' and
8381 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8382 (redisplay_internal): Remove parameter `preserve_echo_area',
8383 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8385 * indent.c (Fvertical_motion):
8386 * window.c (window_scroll_pixel_based, Frecenter):
8387 Don't pass `need_y_p' to `move_it_by_lines'.
8389 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8391 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8392 steal a few bits to be more compact.
8393 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8394 Remove unneeded casts.
8396 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8398 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8400 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8401 binding" message (bug#7967).
8403 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8405 Fix more problems found by GCC 4.6.0's static checks.
8407 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8408 Remove unused local var.
8410 * editfns.c (Fmessage_box): Remove unused local var.
8412 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8413 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8414 Omit unused local vars.
8415 * window.c (shrink_windows): Omit unused local var.
8416 * menu.c (digest_single_submenu): Omit unused local var.
8417 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8418 Omit unused local var.
8420 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8421 Don't assume string length fits in int.
8422 (keyremap_step, read_key_sequence): Use size_t for sizes.
8423 (read_key_sequence): Don't check last_real_key_start redundantly.
8425 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8426 instead of alloca (Bug#8344).
8428 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8429 (Fbacktrace_frame): Don't assume nframes fits in int.
8431 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8433 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8436 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8438 * cm.c (calccost): Turn while-do into do-while, for clarity.
8440 * keyboard.c (syms_of_keyboard): Use the same style as later
8441 in this function when indexing through an array. This also
8442 works around GCC bug 48267.
8444 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8446 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8448 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8449 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8451 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8452 This avoids undefined behavior on integer overflow, and is a bit
8453 more convenient anyway since it is compared to a size_t variable.
8455 Variadic C functions now count arguments with size_t, not int.
8456 This avoids an unnecessary limitation on 64-bit machines, which
8457 caused (substring ...) to crash on large vectors (Bug#8344).
8458 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8459 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8460 All variadic functions and their callers changed accordingly.
8461 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8462 * data.c (arith_driver, float_arith_driver): Likewise.
8463 * editfns.c (general_insert_function): Likewise.
8464 * eval.c (struct backtrace.nargs, interactive_p)
8465 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8466 (funcall_lambda, mark_backtrace): Likewise.
8467 * fns.c (concat): Likewise.
8468 * frame.c (x_set_frame_parameters): Likewise.
8469 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8470 0 if not found, not -1. All callers changed.
8472 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8473 (stack_copy_size): Now size_t, not int.
8474 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8476 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8478 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8479 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8480 All callers changed.
8482 * lisp.h (multibyte_char_to_unibyte):
8483 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8484 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8485 * character.h (CHAR_TO_BYTE8):
8486 * cmds.c (internal_self_insert):
8487 * editfns.c (general_insert_function):
8488 * keymap.c (push_key_description):
8489 * search.c (Freplace_match):
8490 * xdisp.c (message_dolog, set_message_1): All callers changed.
8492 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8494 * keyboard.c (safe_run_hook_funcall): New function.
8495 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8496 don't set the hook to nil, but remove the offending function instead.
8497 (Qcommand_hook_internal): Remove, unused.
8498 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8499 Vcommand_hook_internal.
8501 * eval.c (enum run_hooks_condition): Remove.
8502 (funcall_nil, funcall_not): New functions.
8503 (run_hook_with_args): Call each function through a `funcall' argument.
8504 Remove `cond' argument, now redundant.
8505 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8506 (Frun_hook_with_args_until_failure): Adjust accordingly.
8507 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8509 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8511 * dispextern.h (string_buffer_position): Remove declaration.
8513 * print.c (strout): Remove parameter `multibyte', unused since
8514 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8516 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8517 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8518 All callers changed.
8520 * w32.c (_wsa_errlist): Use braces for struct initializers.
8522 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8523 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8524 All callers changed.
8525 (string_buffer_position): Likewise. Also, make static (it's never
8526 used outside xdisp.c).
8527 (cursor_row_p): Remove parameter `w', unused since
8528 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8529 (decode_mode_spec): Remove parameter `precision', introduced during
8530 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8531 All callers changed.
8533 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8535 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8537 2011-03-27 Anders Lindgren <andlind@gmail.com>
8539 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8540 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8541 (ns_update_auto_hide_menu_bar): New functions.
8542 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8543 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8544 ns_constrain_all_frames.
8545 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8546 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8548 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8550 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8552 2011-03-27 Glenn Morris <rgm@gnu.org>
8554 * syssignal.h: Replace RETSIGTYPE with void.
8555 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8556 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8557 Replace SIGTYPE with void everywhere.
8558 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8559 * s/template.h (SIGTYPE): Remove commented out definition.
8561 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8563 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8564 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8566 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8568 * w32.c (read_unc_volume): Use parameter `henum', instead of
8569 global variable `wget_enum_handle'.
8571 * keymap.c (describe_vector): Remove parameters `indices' and
8572 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8573 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8575 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8577 * keyboard.c (timer_check): Remove parameter `do_it_now',
8578 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8579 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8580 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8582 * keyboard.c (read_char):
8583 * w32menu.c (w32_menu_display_help):
8584 * xmenu.c (show_help_event, menu_help_callback):
8585 Adjust calls to `show_help_echo'.
8587 * gtkutil.c (xg_maybe_add_timer):
8588 * keyboard.c (readable_events):
8589 * process.c (wait_reading_process_output):
8590 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8592 * insdel.c (adjust_markers_gap_motion):
8593 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8594 (gap_left, gap_right): Don't call it.
8596 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8598 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8599 incurred during fontification.
8601 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8603 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8604 (DEFVAR_PER_BUFFER): Don't pass it.
8606 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8607 (scrolling_window): Don't pass it.
8609 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8611 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8613 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8615 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8616 of variables specific to SELinux and computation of `encoded_absname'.
8618 * image.c (XPutPixel): Remove unused variable `height'.
8620 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8622 * unexw32.c (get_section_info): Remove unused variable `section'.
8624 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8625 (system_process_attributes): Remove unused variable `sess'.
8626 (sys_read): Remove unused variable `err'.
8628 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8629 (w32_wnd_proc): Remove unused variable `isdead'.
8630 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8631 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8632 (x_create_tip_frame): Remove unused variable `tem'.
8634 * w32inevt.c (w32_console_read_socket):
8635 Remove unused variable `no_events'.
8637 * w32term.c (x_draw_composite_glyph_string_foreground):
8638 Remove unused variable `width'.
8640 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8642 * w32term.c (x_set_glyph_string_clipping):
8643 Don't pass uninitialized region to CombineRgn.
8645 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8647 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8648 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8649 (Fx_close_connection): Remove unused variable `i'.
8651 * w32font.c (w32font_draw): Return number of glyphs.
8652 (w32font_open_internal): Remove unused variable `i'.
8653 (w32font_driver): Add missing initializer.
8655 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8656 (fill_in_menu): Remove unused variable `items_added'.
8658 * w32term.c (last_mouse_press_frame): Remove static global variable.
8659 (w32_clip_to_row): Remove unused variable `f'.
8660 (x_delete_terminal): Remove unused variable `i'.
8662 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8663 (NOTHING): Remove unused static global variable.
8664 (uniscribe_check_otf): Remove unused variable `table'.
8665 (uniscribe_font_driver): Add missing initializers.
8667 2011-03-23 Julien Danjou <julien@danjou.info>
8669 * term.c (Fsuspend_tty, Fresume_tty):
8670 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8671 * window.c (temp_output_buffer_show):
8672 * insdel.c (signal_before_change):
8673 * frame.c (Fhandle_switch_frame):
8674 * fileio.c (Fdo_auto_save):
8675 * emacs.c (Fkill_emacs):
8676 * editfns.c (save_excursion_restore):
8677 * cmds.c (internal_self_insert):
8678 * callint.c (Fcall_interactively):
8679 * buffer.c (Fkill_all_local_variables):
8680 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8682 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8683 unconditionally since it does the check itself.
8685 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8687 Fix more problems found by GCC 4.5.2's static checks.
8689 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8690 the first time through the loop, since we know p0 < p1 then.
8691 This also avoids a gcc -Wstrict-overflow warning.
8693 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8694 leading to a memory leak, possible in functions like
8695 load_charset_map_from_file that can allocate an unbounded number
8696 of objects (Bug#8318).
8698 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8699 that could (at least in theory) be that large.
8701 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8702 This is less likely to overflow, and avoids undefined behavior if
8703 overflow does occur. All callers changed. Use strtoul to scan
8704 for the unsigned long integer.
8705 (pint2hrstr): Simplify and tune code slightly.
8706 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8708 * scroll.c (do_scrolling): Work around GCC bug 48228.
8709 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8711 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8712 This also avoids a warning with gcc -Wstrict-overflow.
8713 (validate_x_resource_name): Simplify count usage.
8714 This also avoids a warning with gcc -Wstrict-overflow.
8716 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8719 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8721 * process.c (Fmake_network_process): Use socklen_t, not int,
8722 where POSIX says socklen_t is required in portable programs.
8723 This fixes a porting bug on hosts like 64-bit HP-UX, where
8724 socklen_t is wider than int (Bug#8277).
8725 (Fmake_network_process, server_accept_connection):
8726 (wait_reading_process_output, read_process_output):
8729 * process.c: Rename or move locals to avoid shadowing.
8730 (list_processes_1, Fmake_network_process):
8731 (read_process_output_error_handler, exec_sentinel_error_handler):
8732 Rename or move locals.
8733 (Fmake_network_process): Define label "retry_connect" only if needed.
8734 (Fnetwork_interface_info): Fix pointer signedness.
8735 (process_send_signal): Add cast to avoid pointer signedness problem.
8736 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8737 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8739 Make tparam.h and terminfo.c consistent.
8740 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8741 Include tparam.h instead, since it declares them.
8742 * cm.h (PC): Remove extern decl; tparam.h now does this.
8743 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8744 * terminfo.c: Include tparam.h, to check interfaces.
8745 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8746 (tparam): Adjust signature to match interface in tparam.h;
8747 this removes some undefined behavior. Check that outstring and len
8748 are zero, which they always are with Emacs.
8749 * tparam.h (PC, BC, UP): New extern decls.
8751 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8752 (xftfont_open): Rename locals to avoid shadowing.
8754 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8755 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8756 (OTF_TAG_SYM): Omit macro if not needed.
8757 (ftfont_list): Remove unused local.
8758 (get_adstyle_property, ftfont_pattern_entity):
8759 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8760 Rename locals to avoid shadowing.
8762 * xfont.c (xfont_list_family): Mark var as initialized.
8764 * xml.c (make_dom): Now static.
8766 * composite.c (composition_compute_stop_pos): Rename local to
8768 (composition_reseat_it): Remove unused locals.
8769 (find_automatic_composition, composition_adjust_point): Likewise.
8770 (composition_update_it): Mark var as initialized.
8771 (find_automatic_composition): Mark vars as initialized,
8772 with a FIXME (Bug#8290).
8774 character.h: Rename locals to avoid shadowing.
8775 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8776 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8777 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8778 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8781 * textprop.c (property_change_between_p): Remove; unused.
8783 * intervals.c (interval_start_pos): Now static.
8785 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8787 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8788 Rename locals to avoid shadowing.
8790 * sound.c (wav_play, au_play, Fplay_sound_internal):
8791 Fix pointer signedness.
8792 (alsa_choose_format): Remove unused local var.
8793 (wav_play): Initialize a variable to 0, to prevent undefined
8794 behavior (Bug#8278).
8796 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8798 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8800 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8801 clobbering (Bug#8298).
8802 * sysdep.c (sys_subshell): Likewise.
8803 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8805 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8806 This should get cleaned up, so that child_setup has the
8807 same signature on all platforms.
8809 * callproc.c (call_process_cleanup): Now static.
8810 (relocate_fd): Rename locals to avoid shadowing.
8812 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8814 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8815 not to be necessary, and produces flickering.
8817 2011-03-20 Glenn Morris <rgm@gnu.org>
8819 * config.in: Remove file.
8821 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8823 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8824 are now in src/globals.h.
8825 (syms_of_minibuf): Remove spurious & from previous change.
8827 2011-03-20 Leo Liu <sdl.web@gmail.com>
8829 * minibuf.c (completing-read-function): New variable.
8830 (completing-read-default): Rename from completing-read.
8831 (completing-read): Call completing-read-function.
8833 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8835 * xfaces.c (Fx_load_color_file):
8836 Read color file from absolute filename (bug#8250).
8838 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8840 * makefile.w32-in: Update dependencies.
8842 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8844 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8846 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8848 Fix more problems found by GCC 4.5.2's static checks.
8850 * process.c (make_serial_process_unwind, send_process_trap):
8851 (sigchld_handler): Now static.
8853 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8854 That way, the code declares only the vars that it needs.
8855 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8856 * s/cygwin.h (PTY_ITERATION): Likewise.
8857 * s/darwin.h (PTY_ITERATION): Likewise.
8858 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8860 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8861 * process.c (allocate_pty): Don't declare stb unless it's needed.
8863 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8864 (CONSTANTLIM): Remove; unused.
8865 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8866 Define only if needed.
8868 * unexelf.c (unexec): Name an expression,
8869 to avoid gcc -Wbad-function-cast warning.
8870 Use a different way to cause a compilation error if anyone uses
8871 n rather than nn, a way that does not involve shadowing.
8872 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8874 * deps.mk (unexalpha.o): Remove; unused.
8876 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8877 * unexec.h: New file.
8878 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8879 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8881 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8882 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8883 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8884 Change as necessary to match prototype in unexec.h.
8886 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8888 (back_comment, skip_chars): Mark vars as initialized.
8890 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8891 Rename locals to avoid shadowing.
8893 * lread.c (read1): Rewrite so as not to use empty "else".
8894 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8896 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8898 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8899 warning when compiling print.c.
8901 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8902 instead of using an uninitialized var.
8903 (font_sort_entities): Mark var as initialized.
8905 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8907 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8908 pointers to constants.
8909 (font_parse_fcname): Remove unused vars.
8910 (font_delete_unmatched): Now static.
8911 (font_get_spec): Remove; unused.
8912 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8913 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8914 Rename or move locals to avoid shadowing.
8916 * fns.c (require_nesting_list, require_unwind): Now static.
8917 (Ffillarray): Rename locals to avoid shadowing.
8919 * floatfns.c (domain_error2): Define only if needed.
8920 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8922 * alloc.c (mark_backtrace): Move decl from here ...
8923 * lisp.h: ... to here, so that it can be checked.
8925 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8926 (Fdefvar): Rewrite so as not to use empty "else".
8927 (lisp_indirect_variable): Name an expression,
8928 to avoid gcc -Wbad-function-cast warning.
8929 (Fdefvar): Rename locals to avoid shadowing.
8931 * callint.c (quotify_arg, quotify_args): Now static.
8932 (Fcall_interactively): Rename locals to avoid shadowing.
8933 Use const pointer when appropriate.
8935 * lisp.h (get_system_name, get_operating_system_release):
8936 Move decls here, to check interfaces.
8937 * process.c (get_operating_system_release): Move decl to lisp.h.
8938 * xrdb.c (get_system_name): Likewise.
8939 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8940 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8941 some of which prompt warnings from gcc -Wbad-function-cast.
8942 (Fformat_time_string, Fencode_time, Finsert_char):
8943 (Ftranslate_region_internal, Fformat):
8944 Rename or remove local vars to avoid shadowing.
8945 (Ftranslate_region_internal): Mark var as initialized.
8947 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8950 * lisp.h (eassert): Check that the argument compiles, even if
8951 ENABLE_CHECKING is not defined.
8953 * data.c (Findirect_variable): Name an expression, to avoid
8954 gcc -Wbad-function-cast warning.
8955 (default_value, arithcompare, arith_driver, arith_error): Now static.
8956 (store_symval_forwarding): Rename local to avoid shadowing.
8957 (Fmake_variable_buffer_local, Fmake_local_variable):
8958 Mark variables as initialized.
8959 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8961 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8962 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8963 Rename locals to avoid shadowing.
8964 (mark_stack): Move local variables into the #ifdef region where
8966 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8967 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8969 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8970 (GC_STRING_CHARS): Remove; not used.
8971 (Fmemory_limit): Cast sbrk's returned value to char *.
8973 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8974 avoids undefined behavior in theory.
8976 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8978 Use functions, not macros, for up- and down-casing (Bug#8254).
8979 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8980 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8981 to use the following functions instead of these macros.
8982 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8983 EMACS_INT, since callers assume the returned value fits in int.
8984 (upcase1): Likewise, for UPCASE_TABLE.
8985 (uppercasep, lowercasep, upcase): New static inline functions.
8986 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8987 the race-condition problem in the old DOWNCASE.
8989 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8990 Rename locals to avoid shadowing.
8991 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8992 (regex_compile, re_search_2, re_match_2_internal):
8993 Remove unused local vars.
8994 (FREE_VAR): Rewrite so as not to use empty "else",
8995 which gcc can warn about.
8996 (regex_compile, re_match_2_internal): Mark locals as initialized.
8997 (RETALLOC_IF): Define only if needed.
8998 (WORDCHAR_P): Likewise. This one is never needed, but is used
8999 only in a comment talking about a compiler bug, so put inside
9000 the #if 0 of that comment.
9001 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9002 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9005 * search.c (boyer_moore): Rename locals to avoid shadowing.
9006 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9007 (PREV_CHAR_BOUNDARY): Likewise.
9009 * search.c (simple_search): Remove unused var.
9011 * dired.c (compile_pattern): Move decl from here ...
9012 * lisp.h: ... to here, so that it can be checked.
9013 (struct re_registers): New forward decl.
9015 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9017 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9019 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9020 Rename locals to avoid shadowing.
9021 (Fvertical_motion): Mark locals as initialized.
9023 * casefiddle.c (casify_object, casify_region): Now static.
9024 (casify_region): Mark local as initialized.
9026 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9028 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9029 New macros, so that the caller can use some names other than
9030 gcpro1, gcpro2, etc.
9031 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9033 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9034 argument, for consistency with GCPRO2_VAR, etc: it is now the
9035 prefix of the variable, not the variable itself. All uses
9037 * dired.c (directory_files_internal, file_name_completion):
9038 Rename locals to avoid shadowing.
9040 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9041 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9042 dired.c's scmp function, had undefined behavior.
9043 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9044 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9045 * buffer.h: ... to here, because these macros use current_buffer,
9046 and the new implementation with inline functions needs to have
9047 current_buffer in scope now, rather than later when the macros
9049 (downcase, upcase1): New static inline functions.
9050 (DOWNCASE, UPCASE1): Reimplement using these functions.
9051 This avoids undefined behavior in expressions like
9052 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9053 from race conditions in accessing the global variables
9054 case_temp1 and case_temp2.
9055 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9056 * lisp.h (case_temp1, case_temp2): Remove their decls.
9057 * character.h (ASCII_CHAR_P): Move from here ...
9058 * lisp.h: ... to here, so that the inline functions mentioned
9061 * dired.c (directory_files_internal_unwind): Now static.
9063 * fileio.c (file_name_as_directory, directory_file_name):
9064 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9066 (file_name_as_directory): Use const pointers when appropriate.
9067 (Fexpand_file_name): Likewise. In particular, newdir might
9068 point at constant storage, so make it a const pointer.
9069 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9070 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9072 (Fset_file_times, Finsert_file_contents, auto_save_error):
9073 Rename locals to avoid shadowing.
9075 * minibuf.c (choose_minibuf_frame_1): Now static.
9076 (Ftry_completion, Fall_completions): Rename or remove locals
9079 * marker.c (bytepos_to_charpos): Remove; unused.
9081 * lisp.h (verify_bytepos, count_markers): New decls,
9082 so that gcc does not warn that these functions aren't declared.
9084 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9085 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9086 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9087 (copy_text): Remove unused local var.
9089 * filelock.c (within_one_second): Now static.
9090 (lock_file_1): Rename local to avoid shadowing.
9092 * buffer.c (fix_overlays_before): Mark locals as initialized.
9093 (fix_start_end_in_overlays): Likewise. This function should be
9094 simplified by using pointers-to-pointers, but that's a different
9096 (switch_to_buffer_1): Now static.
9097 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9098 (report_overlay_modification): Rename locals to avoid shadowing.
9100 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9101 Fix pointer signedness issue.
9102 (sys_subshell): Mark local as volatile if checking for lint,
9103 to suppress a gcc -Wclobbered warning that does not seem to be right.
9104 (MAXPATHLEN): Define only if needed.
9106 * process.c (serial_open, serial_configure): Move decls from here ...
9107 * systty.h: ... to here, so that they can be checked.
9109 * fns.c (get_random, seed_random): Move extern decls from here ...
9110 * lisp.h: ... to here, so that they can be checked.
9112 * sysdep.c (reset_io): Now static.
9113 (wait_for_termination_signal): Remove; unused.
9115 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9116 (copy_keymap_item, append_key, push_text_char_description):
9118 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9119 (DENSE_TABLE_SIZE): Remove; unused.
9120 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9121 (describe_map_tree):
9122 Rename locals to avoid shadowing.
9124 * keyboard.c: Declare functions static if they are not used elsewhere.
9125 (echo_char, echo_dash, cmd_error, top_level_2):
9126 (poll_for_input, handle_async_input): Now static.
9127 (read_char, kbd_buffer_get_event, make_lispy_position):
9128 (make_lispy_event, make_lispy_movement, apply_modifiers):
9129 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9130 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9131 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9132 (read_key_sequence, read_char): Mark locals as initialized.
9133 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9135 * keyboard.h (make_ctrl_char): New decl.
9136 (mark_kboards): Move decl here ...
9137 * alloc.c (mark_kboards): ... from here.
9139 * lisp.h (force_auto_save_soon): New decl.
9141 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9142 (DEFINE_DUMMY_FUNCTION): New macro.
9143 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9145 (main): Add casts to avoid warnings
9146 if GCC considers string literals to be constants.
9148 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9150 * dbusbind.c: Pointer signedness fixes.
9151 (xd_signature, xd_append_arg, xd_initialize):
9152 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9153 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9154 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9155 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9157 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9158 if GCC considers string literals to be constants.
9159 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9161 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9163 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9164 (print_preprocess, print_object): New macro to fix last change.
9166 * print.c (print_preprocess): Don't forget font objects.
9168 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9170 * emacs.c (USAGE3): Doc fixes.
9172 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9174 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9177 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9179 * lisp.h (VWindow_system, Qfile_name_history):
9180 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9181 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9182 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9184 * w32select.c: Don't #include "keyboard.h".
9185 (run_protected): Add extern declaration for waiting_for_input.
9187 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9188 * w32console.c (detect_input_pending, read_input_pending)
9189 (encode_terminal_code):
9190 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9191 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9192 (w32_system_caret_y, Qfile_name_history):
9193 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9194 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9195 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9196 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9197 * w32proc.c (Qlocal, report_file_error):
9198 * w32term.c (Vwindow_system, updating_frame):
9199 * w32uniscribe.c (initialized, uniscribe_font_driver):
9200 Remove unneeded extern declarations.
9202 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9204 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9206 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9208 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9209 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9210 These macros can no longer be used for assignment.
9212 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9213 Assign struct members directly, instead of using BUF_BEGV etc.
9214 (record_buffer_markers, fetch_buffer_markers): New functions for
9215 recording and fetching special buffer markers.
9216 (set_buffer_internal_1, set_buffer_temp): Use them.
9218 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9220 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9222 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9223 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9225 * xdisp.c (hscroll_window_tree):
9226 (reconsider_clip_changes): Use PT instead of BUF_PT.
9228 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9230 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9231 $(EMACS_ROOT)/lib/intprops.h.
9233 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9235 Fix more problems found by GCC 4.5.2's static checks.
9237 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9238 to unsigned char * to avoid compiler diagnostic.
9239 (xg_free_frame_widgets): Make it clear that a local variable is
9240 needed only if USE_GTK_TOOLTIP.
9241 (gdk_window_get_screen): Make it clear that this macro is needed
9242 only if USE_GTK_TOOLTIP.
9243 (int_gtk_range_get_value): New function, which avoids a diagnostic
9244 from gcc -Wbad-function-cast.
9245 (xg_set_toolkit_scroll_bar_thumb): Use it.
9246 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9247 diagnostic from gcc -Wbad-function-cast.
9248 (get_utf8_string, xg_get_file_with_chooser):
9249 Rename locals to avoid shadowing.
9250 (create_dialog): Move locals to avoid shadowing.
9252 * xgselect.c (xg_select): Remove unused var.
9254 * image.c (four_corners_best): Mark locals as initialized.
9255 (gif_load): Initialize transparent_p to zero (Bug#8238).
9256 Mark another local as initialized.
9257 (my_png_error, my_error_exit): Mark with NO_RETURN.
9259 * image.c (clear_image_cache): Now static.
9260 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9261 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9262 (x_edge_detection): Remove unnecessary cast that
9263 gcc -Wbad-function-cast diagnoses.
9264 (gif_load): Fix pointer signedness.
9265 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9266 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9268 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9270 Improve quality of tests for time stamp overflow.
9271 For example, without this patch (encode-time 0 0 0 1 1
9272 1152921504606846976) returns the obviously-bogus value (-948597
9273 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9274 reports time overflow. See
9275 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9276 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9277 * editfns.c: Include limits.h and intprops.h.
9278 (TIME_T_MIN, TIME_T_MAX): New macros.
9279 (time_overflow): Move earlier, to before first use.
9280 (hi_time, lo_time): New functions, for an accurate test for
9282 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9283 (Fget_internal_run_time): Don't assume time_t fits in int.
9284 (make_time): Use list2 instead of Fcons twice.
9285 (Fdecode_time): More accurate test for out-of-range times.
9286 (check_tm_member): New function.
9287 (Fencode_time): Use it, to test for out-of-range times.
9288 (lisp_time_argument): Don't rely on undefined left-shift and
9289 right-shift behavior when checking for time stamp overflow.
9291 * editfns.c (time_overflow): New function, refactoring common code.
9292 (Fformat_time_string, Fdecode_time, Fencode_time):
9293 (Fcurrent_time_string): Use it.
9295 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9296 * dired.c (make_time): Move to ...
9297 * editfns.c (make_time): ... here.
9298 * systime.h: Note the move.
9300 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9302 * fringe.c (update_window_fringes): Remove unused variables.
9304 * unexmacosx.c (copy_data_segment): Also copy __got section.
9307 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9309 * termcap.c [MSDOS]: Include "msdos.h".
9310 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9311 Constify `char *' arguments and their references according to
9312 prototypes in tparam.h.
9314 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9316 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9317 Adapt all references accordingly.
9319 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9321 2011-03-11 Tom Tromey <tromey@redhat.com>
9323 * buffer.c (syms_of_buffer): Remove obsolete comment.
9325 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9327 * termhooks.h (encode_terminal_code): Declare prototype.
9329 * msdos.c (encode_terminal_code): Don't declare prototype.
9331 * term.c (encode_terminal_code): Now external again, used by
9332 w32console.c and msdos.c.
9334 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9335 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9337 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9339 Fix some minor problems found by GCC 4.5.2's static checks.
9341 * fringe.c (update_window_fringes): Mark locals as initialized
9343 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9345 * alloc.c (mark_fringe_data): Move decl from here ...
9346 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9347 to check its interface.
9348 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9350 * fontset.c (free_realized_fontset): Now static.
9351 (Fset_fontset_font): Rename local to avoid shadowing.
9352 (fontset_font): Mark local as initialized.
9353 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9355 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9357 * xselect.c (x_disown_buffer_selections): Remove; not used.
9358 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9359 (x_own_selection, Fx_disown_selection_internal): Rename locals
9361 (x_handle_dnd_message): Remove local to avoid shadowing.
9363 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9364 so that the caller can use some name other than gcpro1.
9365 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9366 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9367 (Fx_backspace_delete_keys_p):
9368 Use them to avoid shadowing, and rename vars to avoid shadowing.
9369 (x_decode_color, x_set_name, x_window): Now static.
9370 (Fx_create_frame): Add braces to silence GCC warning.
9371 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9372 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9373 Remove unused locals.
9374 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9375 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9376 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9379 * xterm.h (x_mouse_leave): New decl.
9381 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9382 Remove unused functions.
9383 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9384 (x_calc_absolute_position): Now static.
9385 (XTread_socket): Don't define label "out" unless it's used.
9386 Don't declare local "event" unless it's used.
9387 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9388 unless they are used.
9389 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9390 (x_fatal_error_signal): Remove; not used.
9391 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9392 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9393 (x_error_catcher, x_connection_closed, x_error_handler):
9394 (x_error_quitter, xembed_send_message, x_iconify_frame):
9395 (my_log_handler): Rename locals to avoid shadowing.
9396 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9397 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9399 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9400 Rename or move locals to avoid shadowing.
9401 (tty_defined_color, merge_face_heights): Now static.
9402 (free_realized_faces_for_fontset): Remove; not used.
9403 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9404 does not deduce is never used uninitialized.
9405 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9406 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9408 * terminal.c (store_terminal_param): Now static.
9410 * xmenu.c (menu_highlight_callback): Now static.
9411 (set_frame_menubar): Remove unused local.
9412 (xmenu_show): Rename parameter to avoid shadowing.
9413 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9414 since they might point to immutable storage.
9415 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9416 since it's unused otherwise.
9418 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9419 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9420 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9421 avoids a gcc -Wuninitialized diagnostic.
9422 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9423 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9424 does not deduce are never used uninitialized.
9426 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9428 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9429 * window.c (window_loop, size_window):
9430 (run_window_configuration_change_hook, enlarge_window): Likewise.
9432 * window.c (display_buffer): Now static.
9433 (size_window): Mark variables that gcc -Wuninitialized
9434 does not deduce are never used uninitialized.
9435 * window.h (check_all_windows): New decl, to forestall
9436 gcc -Wmissing-prototypes diagnostic.
9437 * dispextern.h (bidi_dump_cached_states): Likewise.
9439 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9441 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9443 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9444 and to avoid gcc -Wuninitialized warning.
9445 (load_charset_map): Mark variables that gcc -Wuninitialized
9446 does not deduce are never used uninitialized.
9447 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9449 * coding.c (coding_set_source, coding_set_destination):
9450 Use "else { /* comment */ }" rather than "else /* comment */;"
9451 for clarity, and to avoid gcc -Wempty-body warning.
9452 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9453 a block, when the outer 'i' will do.
9454 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9455 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9456 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9457 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9458 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9459 Rename locals to avoid shadowing.
9460 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9461 * coding.c (emacs_mule_char, encode_invocation_designation):
9462 Now static, since they're not used elsewhere.
9463 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9464 (decode_coding_object, encode_coding_object, detect_coding_system):
9465 (decode_coding_emacs_mule): Mark variables that gcc
9466 -Wuninitialized does not deduce are never used uninitialized.
9467 (detect_coding_iso_2022): Initialize a local variable that might
9468 be used uninitialized. Leave a FIXME because it's not clear that
9469 this initialization is needed. (Bug#8211)
9470 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9471 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9472 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9473 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9474 Remove unused macros.
9476 * category.c (hash_get_category_set): Remove unused local var.
9477 (copy_category_table): Now static, since it's not used elsewhere.
9478 * character.c (string_count_byte8): Likewise.
9480 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9481 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9483 * chartab.c (copy_sub_char_table): Now static, since it's not used
9485 (sub_char_table_ref_and_range, char_table_ref_and_range):
9486 Rename locals to avoid shadowing.
9487 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9489 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9490 (BIDI_BOB): Remove unused macro.
9492 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9493 deduce are never used uninitialized.
9494 * term.c (encode_terminal_code): Likewise.
9496 * term.c (encode_terminal_code): Now static. Remove unused local.
9498 * tparam.h: New file.
9499 * term.c, tparam.h: Include it.
9500 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9501 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9502 Move these decls to tparam.h, and make them agree with what
9503 is actually in tparam.c. The previous trick of using incompatible
9504 decls in different modules does not conform to the C standard.
9505 All callers of tparam changed to use tparam's actual API.
9506 * tparam.c (tparam1, tparam, tgoto):
9507 Use const pointers where appropriate.
9509 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9510 * cm.h (struct cm): Likewise.
9511 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9512 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9513 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9514 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9515 (turn_on_face, init_tty): Likewise.
9516 * termchar.h (struct tty_display_info): Likewise.
9518 * term.c (term_mouse_position): Rename local to avoid shadowing.
9520 * alloc.c (mark_ttys): Move decl from here ...
9521 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9523 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9525 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9527 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9529 * search.c (compile_pattern_1): Remove argument regp, unused since
9530 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9531 (compile_pattern): Don't pass it.
9533 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9535 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9536 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9538 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9540 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9542 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9543 gdk_window_get_screen, gdk_window_get_geometry,
9544 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9545 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9546 (xg_get_pixbuf_from_pixmap): New function.
9547 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9548 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9549 Call xg_get_pixbuf_from_pixmap instead of
9550 gdk_pixbuf_get_from_drawable.
9551 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9552 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9553 (xg_check_special_colors): Use GtkStyleContext and its functions
9555 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9556 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9557 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9558 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9559 Call gtk_widget_get_preferred_size.
9560 (xg_frame_resized): gdk_window_get_geometry only takes 5
9562 (xg_win_to_widget, xg_event_is_for_menubar):
9563 Call gdk_x11_window_lookup_for_display.
9564 (xg_set_widget_bg): New function.
9565 (delete_cb): New function.
9566 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9567 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9568 (xg_set_background_color): Call xg_set_widget_bg.
9569 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9570 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9571 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9572 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9574 (update_frame_tool_bar): Call gtk_widget_hide.
9575 (xg_initialize): Use GDK_KEY_g.
9577 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9579 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9581 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9582 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9583 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9585 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9587 * w32xfns.c (select_palette): Check success of RealizePalette against
9588 GDI_ERROR, not zero.
9590 See ChangeLog.11 for earlier changes.
9596 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9598 This file is part of GNU Emacs.
9600 GNU Emacs is free software: you can redistribute it and/or modify
9601 it under the terms of the GNU General Public License as published by
9602 the Free Software Foundation, either version 3 of the License, or
9603 (at your option) any later version.
9605 GNU Emacs is distributed in the hope that it will be useful,
9606 but WITHOUT ANY WARRANTY; without even the implied warranty of
9607 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9608 GNU General Public License for more details.
9610 You should have received a copy of the GNU General Public License
9611 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.