1 2011-04-29 Paul Eggert <eggert@cs.ucla.edu>
3 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4 This removes an assumption that EMACS_INT and long are the same
5 width as pointers. The assumption is true for Emacs porting targets
6 now, but we want to make other targets possible.
7 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9 In the rest of the code, change types of integers that hold casted
10 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
13 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
14 No need to cast type when ORing.
15 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
16 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
17 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
18 assume EMACS_INT is the same width as char *.
19 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
20 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
21 Remove no-longer-needed casts.
22 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
23 (xg_tool_bar_help_callback, xg_make_tool_item):
24 Use EMACS_INTPTR to hold an integer
25 that will be cast to void *; this can avoid a GCC warning
26 if EMACS_INT is not the same width as void *.
27 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
28 * xdisp.c (display_echo_area_1, resize_mini_window_1):
29 (current_message_1, set_message_1):
30 Use a local to convert to proper width without a cast.
31 * xmenu.c (dialog_selection_callback): Likewise.
33 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
35 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
36 Also, don't assume VALBITS / RAND_BITS is less than 5,
37 and don't rely on undefined behavior when shifting a 1 left into
39 * lisp.h (get_random): Change signature to match.
41 * lread.c (hash_string): Use size_t, not int, for hash computation.
42 Normally we prefer signed values; but hashing is special, because
43 it's better to use unsigned division on hash table sizes so that
44 the remainder is nonnegative. Also, size_t is the natural width
45 for hashing into memory. The previous code used 'int', which doesn't
46 retain enough info to hash well into very large tables.
47 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
49 * dbusbind.c: Don't possibly lose pointer info when converting.
50 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
51 Use XPNTR rather than XHASH, so that the high-order bits of
52 the pointer aren't lost when converting through void *.
54 * eval.c (Fautoload): Don't double-shift a pointer.
56 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
58 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
60 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
61 (SIZE_MAX): Move defn after all includes, as they might #define it.
63 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
65 * w32.c (init_environment): Warn about defaulting HOME to C:\.
67 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
69 * keyboard.c (Qdelayed_warnings_hook): Define.
70 (command_loop_1): Run `delayed-warnings-hook'
71 if Vdelayed_warnings_list is non-nil.
72 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
73 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
75 2011-04-28 Eli Zaretskii <eliz@gnu.org>
77 * doprnt.c (doprnt): Don't return value smaller than the buffer
78 size if the message was truncated. (Bug#8545).
80 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
82 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
83 (Fx_window_property): #if-0 the whole functions, not just the bodies.
85 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
87 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
89 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
91 * makefile.w32-in: Update dependencies.
93 2011-04-27 Eli Zaretskii <eliz@gnu.org>
95 Improve `doprnt' and its usage. (Bug#8545)
96 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
97 `format_end'. Remove support for %l as a conversion specifier.
98 Don't use xrealloc. Improve diagnostics when the %l size modifier
99 is used. Update the commentary.
101 * eval.c (verror): Simplify calculation of size_t.
103 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
106 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
108 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
111 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
113 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
114 This makes this file independent of the recent pseudovector change.
116 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
118 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
120 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
121 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
123 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
125 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
126 GCC 4.6.0 optimizes based on type-based alias analysis. For
127 example, if b is of type struct buffer * and v of type struct
128 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
129 != &v->size, and therefore "v->size = 1; b->size = 2; return
130 v->size;" must therefore return 1. This assumption is incorrect
131 for Emacs, since it type-puns struct Lisp_Vector * with many other
132 types. To fix this problem, this patch adds a new type struct
133 vectorlike_header that documents the constraints on layout of vectors
134 and pseudovectors, and helps optimizing compilers not get fooled
135 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
136 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
137 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
139 (XSETPVECTYPE): Rewrite in terms of new macro.
140 (XSETPVECTYPESIZE): New macro, specifying both type and size.
141 This is a bit clearer, and further avoids the possibility of
142 undesirable aliasing.
143 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
144 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
145 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
146 since Lisp_Subr is a special case (no "next" field).
147 (ASIZE): Now uses header.size rather than size. All
148 previous uses of XVECTOR (foo)->size replaced to use this macro,
149 to avoid the hassle of writing XVECTOR (foo)->header.size.
150 (struct vectorlike_header): New type.
151 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
152 object, to help avoid aliasing.
153 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
154 (SUBRP): Likewise, since Lisp_Subr is a special case.
155 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
156 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
157 (struct Lisp_Hash_Table): Combine first two members into a single
158 struct vectorlike_header member. All uses of "size" and "next" members
159 changed to be "header.size" and "header.next".
160 * buffer.h (struct buffer): Likewise.
161 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
162 * frame.h (struct frame): Likewise.
163 * process.h (struct Lisp_Process): Likewise.
164 * termhooks.h (struct terminal): Likewise.
165 * window.c (struct save_window_data, struct saved_window): Likewise.
166 * window.h (struct window): Likewise.
167 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
168 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
169 * buffer.c (init_buffer_once): Likewise.
170 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
172 * process.c (Fformat_network_address): Use local var for size,
175 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
177 Make the Lisp reader and string-to-float more consistent (Bug#8525)
178 * data.c (atof): Remove decl; no longer used or needed.
179 (digit_to_number): Move to lread.c.
180 (Fstring_to_number): Use new string_to_number function, to be
181 consistent with how the Lisp reader treats infinities and NaNs.
182 Do not assume that floating-point numbers represent EMACS_INT
183 without losing information; this is not true on most 64-bit hosts.
184 Avoid double-rounding errors, by insisting on integers when
185 parsing non-base-10 numbers, as the documentation specifies.
186 * lisp.h (string_to_number): New decl, replacing ...
187 (isfloat_string): Remove.
188 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
189 (read1): Do not accept +. and -. as integers; this
190 appears to have been a coding error. Similarly, do not accept
191 strings like +-1e0 as floating point numbers. Do not report
192 overflow for integer overflows unless the base is not 10 which
193 means we have no simple and reliable way to continue.
194 Break out the floating-point parsing into a new
195 function string_to_number, so that Fstring_to_number parses
196 floating point numbers consistently with the Lisp reader.
197 (digit_to_number): Moved here from data.c. Make it static inline.
198 (E_CHAR, EXP_INT): Remove, replacing with ...
199 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
200 (string_to_number): New function, replacing isfloat_string.
201 This function checks for valid syntax and produces the resulting
202 Lisp float number too. Rework it so that string-to-number
203 no longer mishandles examples like "1.0e+". Use strtoumax,
204 so that overflow for non-base-10 numbers is reported only when
205 there's no portable and simple way to convert to floating point.
207 * textprop.c (set_text_properties_1): Rewrite for clarity,
208 and to avoid GCC warning about integer overflow.
210 * intervals.h (struct interval): Use EMACS_INT for members
211 where EMACS_UINT might cause problems. See
212 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
213 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
214 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
216 (offset_intervals): Tell GCC not to worry about length overflow
217 when negating a negative length.
219 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
220 (overrun_check_free): Likewise.
222 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
223 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
226 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
227 (gnutls_make_error): Rename local to avoid shadowing.
228 (gnutls_emacs_global_deinit): ifdef out; not used.
229 (Fgnutls_boot): Use const for pointer to readonly storage.
230 Comment out unused local. Fix pointer signedness problems.
232 * lread.c (openp): Don't stuff size_t into an 'int'.
233 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
234 about possible signed overflow.
236 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
237 (GDK_KEY_g): Don't define if already defined.
238 (xg_prepare_tooltip): Avoid pointer signedness problem.
239 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
241 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
242 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
244 * xfns.c (Fx_window_property): Simplify a bit,
245 to make a bit faster and to avoid GCC 4.6.0 warning.
246 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
248 * fns.c (internal_equal): Don't assume size_t fits in int.
250 * alloc.c (compact_small_strings): Tighten assertion a little.
252 Replace pEd with more-general pI, and fix some printf arg casts.
253 * lisp.h (pI): New macro, generalizing old pEd macro to other
254 conversion specifiers. For example, use "...%"pI"d..." rather
256 (pEd): Remove. All uses replaced with similar uses of pI.
257 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
258 * alloc.c (check_pure_size): Don't overflow by converting size to int.
259 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
260 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
261 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
262 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
263 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
265 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
266 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
267 * print.c (safe_debug_print, print_object): Likewise.
268 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
270 Use pI instead of if-then-else-abort. Use %p to avoid casts,
271 avoiding the 0 flag, which is not portable.
272 * process.c (Fmake_network_process): Use pI to avoid cast.
273 * region-cache.c (pp_cache): Likewise.
274 * xdisp.c (decode_mode_spec): Likewise.
275 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
276 behavior on 64-bit hosts with printf arg.
277 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
278 (x_stop_queuing_selection_requests): Likewise.
279 (x_get_window_property): Don't truncate byte count to an 'int'
282 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
283 here, since it parses constructs like leading '-' and spaces,
284 which are not wanted; and it overflows with large numbers.
285 Instead, simply match F[0-9]+, which is what is wanted anyway.
287 * alloc.c: Remove unportable assumptions about struct layout.
288 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
289 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
290 (allocate_vectorlike, make_pure_vector): Use the new macros,
291 plus offsetof, to remove unportable assumptions about struct layout.
292 These assumptions hold on all porting targets that I know of, but
293 they are not guaranteed, they're easy to remove, and removing them
294 makes further changes easier.
296 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
297 This doesn't fix a bug but makes the code clearer.
298 (string_overrun_cookie): Now const. Use initializers that
299 don't formally overflow signed char, to avoid warnings.
300 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
301 can cause Emacs to crash when string overrun checking is enabled.
302 (allocate_buffer): Don't assume sizeof (struct buffer) is a
303 multiple of sizeof (EMACS_INT); it need not be, if
304 alignof(EMACS_INT) < sizeof (EMACS_INT).
305 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
307 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
309 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
311 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
313 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
314 supposed to be handshaking. (Bug#8556)
315 Reported by Paul Eggert <eggert@cs.ucla.edu>.
317 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
319 * lisp.h (Qdebug): List symbol.
320 * eval.c (Qdebug): Restore global linkage.
321 * keyboard.c (debug-on-event): New variable.
322 (handle_user_signal): Break into debugger when debug-on-event
323 matches the current signal symbol.
325 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
327 * alloc.c (check_sblock, check_string_bytes)
328 (check_string_free_list): Convert to standard C.
330 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
332 * w32.c (emacs_gnutls_push): Fix typo.
334 2011-04-25 Eli Zaretskii <eliz@gnu.org>
336 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
337 "cast to pointer from integer of different size".
339 Improve doprnt and its use in verror. (Bug#8545)
340 * doprnt.c (doprnt): Document the set of format control sequences
341 supported by the function. Use SAFE_ALLOCA instead of always
344 * eval.c (verror): Don't limit the buffer size at size_max-1, that
345 is one byte too soon. Don't use xrealloc; instead xfree and
348 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
350 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
353 * gnutls.c: Renamed global_initialized to
354 gnutls_global_initialized. Added internals for the
355 :verify-hostname-error, :verify-error, and :verify-flags
356 parameters of `gnutls-boot' and documented those parameters in the
357 docstring. Start callback support.
358 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
359 unless a fatal error occured. Call gnutls_alert_send_appropriate
360 on error. Return error code.
361 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
362 (emacs_gnutls_read): Likewise.
363 (Fgnutls_boot): Return handshake error code.
364 (emacs_gnutls_handle_error): New function.
365 (wsaerror_to_errno): Likewise.
367 * w32.h (emacs_gnutls_pull): Add prototype.
368 (emacs_gnutls_push): Likewise.
370 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
371 (emacs_gnutls_push): Likewise.
373 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
375 * process.c (wait_reading_process_output): Check if GnuTLS
376 buffered some data internally if no FDs are set for TLS
379 * makefile.w32-in (OBJ2): Add gnutls.$(O).
380 (LIBS): Link to USER_LIBS.
381 ($(BLD)/gnutls.$(0)): New target.
383 2011-04-24 Eli Zaretskii <eliz@gnu.org>
385 * xdisp.c (handle_single_display_spec): Rename the
386 display_replaced_before_p argument into display_replaced_p, to
387 make it consistent with the commentary. Fix typos in the
390 * textprop.c (syms_of_textprop): Remove dead code.
391 (copy_text_properties): Delete obsolete commentary about an
392 interface that was deleted long ago. Fix typos in the description
395 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
396 to changes in oldXMenu/XMenu.h from 2011-04-16.
397 <menu_help_message, prev_menu_help_message>: Constify.
398 (IT_menu_make_room): menu->help_text is now `const char **';
401 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
402 to changes in oldXMenu/XMenu.h from 2011-04-16.
403 (struct XMenu): Declare `help_text' `const char **'.
405 * xfaces.c <Qunspecified>: Make extern again.
407 * syntax.c: Include sys/types.h before including regex.h, as
410 * doc.c (get_doc_string): Improve the format passed to `error'.
412 * doprnt.c (doprnt): Improve commentary.
414 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
416 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
419 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
420 changes in globals.h immediately force recompilation.
421 (TAGS): Depend on $(CURDIR)/m/intel386.h and
422 $(CURDIR)/s/ms-w32.h.
423 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
425 * character.c (Fchar_direction): Function deleted.
426 (syms_of_character): Don't defsubr it.
427 <char-direction-table>: Deleted.
429 2011-04-23 Eli Zaretskii <eliz@gnu.org>
431 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
432 * doprnt.c: Include limits.h.
433 (SIZE_MAX): New macro.
434 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
435 local variables are now size_t instead of int or unsigned.
436 Improve overflow protection. Support `l' modifier for integer
437 conversions. Support %l conversion. Don't assume an EMACS_INT
438 argument for integer conversions and for %c.
440 * lisp.h (doprnt): Restore prototype.
442 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
445 * Makefile.in (base_obj): Add back doprnt.o.
447 * deps.mk (doprnt.o): Add back prerequisites.
448 (callint.o): Depend on character.h.
450 * eval.c (internal_lisp_condition_case): Include the handler
451 representation in the error message.
452 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
453 when breaking from the loop.
455 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
457 * callint.c (Fcall_interactively): When displaying error message
458 about invalid control letter, pass the character's codepoint, not
459 a pointer to its multibyte form. Improve display of the character
460 in octal and display also its hex code.
462 * character.c (char_string): Use %x to display the (unsigned)
463 codepoint of an invalid character, to avoid displaying a bogus
466 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
467 `error', not SYMBOL_NAME itself.
469 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
470 character arguments to `error'.
472 * charset.c (check_iso_charset_parameter): Fix incorrect argument
473 to `error' in error message about FINAL_CHAR argument. Make sure
474 FINAL_CHAR is a character, and use %c when it is passed as
477 2011-04-23 Eli Zaretskii <eliz@gnu.org>
479 * s/ms-w32.h (localtime): Redirect to sys_localtime.
481 * w32.c: Include <time.h>.
482 (sys_localtime): New function.
484 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
486 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
488 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
490 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
492 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
495 2011-04-19 Eli Zaretskii <eliz@gnu.org>
497 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
498 gl_state.e_property when gl_state.object is Qt.
500 * insdel.c (make_gap_larger): Remove limitation of buffer size
503 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
505 * xdisp.c (lookup_glyphless_char_display)
506 (produce_glyphless_glyph): Handle cons cell entry in
507 glyphless-char-display.
508 (Vglyphless_char_display): Document it.
510 * term.c (produce_glyphless_glyph): Handle cons cell entry in
511 glyphless-char-display.
513 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
515 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
517 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
519 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
520 definition for no-X builds.
522 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
524 Static checks with GCC 4.6.0 and non-default toolkits.
526 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
528 * process.c (keyboard_bit_set): Define only if SIGIO.
529 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
530 (send_process): Repair possible setjmp clobbering.
532 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
534 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
536 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
538 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
539 Define only if needed.
541 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
542 by pacifying GCC about it. Maybe it's time to retire it?
543 * xfaces.c (USG, __TIMEVAL__): Likewise.
545 * dispextern.h (struct redisplay_interface): Rename param
547 * termhooks.h (struct terminal): Likewise.
548 * xterm.c (xembed_send_message): Likewise.
550 * insdel.c (make_gap_smaller): Define only if
551 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
553 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
556 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
557 so that we aren't warned about unused symbols.
559 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
561 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
563 * xfns.c (x_real_positions): Mark locals as initialized.
565 * xmenu.c (xmenu_show): Don't use uninitialized vars.
567 * xterm.c: Fix problems found by static analysis with other toolkits.
568 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
569 (x_dispatch_event): Declare static if USE_GTK, and
570 define if USE_GTK || USE_X_TOOLKIT.
571 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
572 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
573 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
574 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
576 * xmenu.c (menu_help_callback): Pointer type fixes.
577 Use const pointers when pointing at readonly data. Avoid pointer
579 (FALSE): Remove unused macro.
580 (update_frame_menubar): Remove unused decl.
582 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
584 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
585 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
586 (single_menu_item): Rename local to avoid shadowing.
588 * keyboard.c (make_lispy_event): Remove unused local var.
590 * frame.c, frame.h (x_get_resource_string): Bring this back, but
591 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
593 * bitmaps: Change bitmaps from unsigned char back to the X11
594 compatible char. Avoid the old compiler warnings about
595 out-of-range initializers by using, for example, '\xab' rather
598 * xgselect.c (xgselect_initialize): Check vs interface
599 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
601 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
603 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
606 * fns.c (vector): Remove; this old hack is no longer needed.
608 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
610 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
612 * xrdb.c (x_load_resources): Omit unused local.
614 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
615 (x_window): Rename locals to avoid shadowing.
616 (USG): Use the kludged USG macro, to pacify gcc.
618 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
619 (x_term_init): Remove local to avoid shadowing.
621 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
623 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
624 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
626 2011-04-16 Eli Zaretskii <eliz@gnu.org>
628 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
630 Fix regex.c, syntax.c and friends for buffers > 2GB.
631 * syntax.h (struct gl_state_s): Declare character position members
634 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
636 * textprop.c (verify_interval_modification, interval_of): Declare
639 * intervals.c (adjust_intervals_for_insertion): Declare arguments
642 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
644 * indent.c (Fvertical_motion): Local variable it_start is now
647 * regex.c (re_match, re_match_2, re_match_2_internal)
648 (bcmp_translate, regcomp, regexec, print_double_string)
649 (group_in_compile_stack, re_search, re_search_2, regex_compile)
650 (re_compile_pattern, re_exec): Declare arguments and local
651 variables `size_t' and `ssize_t' and return values `regoff_t', as
653 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
654 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
655 <compile_stack_type>: `size' and `avail' are now `size_t'.
657 * regex.h <regoff_t>: Use ssize_t, not int.
658 (re_search, re_search_2, re_match, re_match_2): Arguments that
659 specify buffer/string position and length are now ssize_t and
660 size_t. Return type is regoff_t.
662 2011-04-16 Ben Key <bkey76@gmail.com>
664 * nsfont.m: Fixed bugs in ns_get_family and
665 ns_descriptor_to_entity that were caused by using free to
666 deallocate memory blocks that were allocated by xmalloc (via
667 xstrdup). This caused Emacs to crash when compiled with
668 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
669 --enable-checking=xmallocoverrun). xfree is now used to
670 deallocate these memory blocks.
672 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
674 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
676 emacs_write: Accept and return EMACS_INT for sizes.
677 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
679 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
680 Accept and return EMACS_INT.
681 (emacs_gnutls_write): Return the number of bytes written on
683 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
684 (emacs_read, emacs_write): Remove check for negative size, as the
685 Emacs source code has been audited now.
686 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
687 (emacs_read, emacs_write): Use it.
688 * process.c (send_process): Adjust to the new signatures of
689 emacs_write and emacs_gnutls_write. Do not attempt to store
690 a byte offset into an 'int'; it might overflow.
691 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
693 * sound.c: Don't assume sizes fit in 'int'.
694 (struct sound_device.period_size, alsa_period_size):
695 Return EMACS_INT, not int.
696 (struct sound_device.write, vox_write, alsa_write):
697 Accept EMACS_INT, not int.
698 (wav_play, au_play): Use EMACS_INT to store sizes and to
699 record read return values.
701 2011-04-15 Ben Key <bkey76@gmail.com>
703 * keyboard.c (Qundefined): Don't declare static since it is used
705 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
706 static since they are used in nsfont.m.
708 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
710 * process.c (Qprocessp): Don't declare static.
711 * lisp.h (Qprocessp): Declare again.
713 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
715 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
717 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
719 Improve C-level modularity by making more things 'static'.
721 Don't publish debugger-only interfaces to other modules.
722 * lisp.h (safe_debug_print, debug_output_compilation_hack):
723 (verify_bytepos, count_markers): Move decls to the only modules
725 * region-cache.h (pp_cache): Likewise.
726 * window.h (check_all_windows): Likewise.
727 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
729 * sysdep.c (croak): Now static, if
730 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
731 * syssignal.h (croak): Declare only if not static.
733 * alloc.c (refill_memory_reserve): Now static if
734 !defined REL_ALLOC || defined SYSTEM_MALLOC.
735 * lisp.h (refill_memory_reserve): Declare only if not static.
737 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
738 Define only if USE_LUCID.
740 * xrdb.c (x_customization_string, x_rm_string): Now static.
742 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
743 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
745 * xdisp.c (draw_row_with_mouse_face): Now static.
746 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
748 * window.h (check_all_windows): Mark externally visible.
750 * window.c (window_deletion_count): Now static.
752 * undo.c: Make symbols static if they're not exported.
753 (last_undo_buffer, last_boundary_position, pending_boundary):
756 * textprop.c (interval_insert_behind_hooks): Now static.
757 (interval_insert_in_front_hooks): Likewise.
759 * term.c: Make symbols static if they're not exported.
760 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
761 (max_frame_lines, tty_set_terminal_modes):
762 (tty_reset_terminal_modes, tty_turn_off_highlight):
763 (get_tty_terminal): Now static.
764 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
765 * termhooks.h (term_mouse_moveto): Do not declare if
767 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
768 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
770 * sysdep.c: Make symbols static if they're not exported.
771 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
773 (sigprocmask_set, full_mask): Remove; unused.
774 (wait_debugging): Mark as visible.
775 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
776 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
778 * syntax.c (syntax_temp): Define only if !__GNUC__.
780 * sound.c (current_sound_device, current_sound): Now static.
782 * search.c (searchbufs, searchbuf_head): Now static.
784 * scroll.c (scroll_cost): Remove; unused.
785 * dispextern.h (scroll_cost): Remove decl.
787 * region-cache.h (pp_cache): Mark as externally visible.
789 * process.c: Make symbols static if they're not exported.
790 (process_tick, update_tick, create_process, chan_process):
791 (Vprocess_alist, proc_buffered_char, datagram_access):
792 (fd_callback_data, send_process_frame, process_sent_to): Now static.
793 (deactivate_process): Mark defn as static, as well as decl.
794 * lisp.h (create_process): Remove decl.
795 * process.h (chan_process, Vprocess_alist): Remove decls.
797 * print.c: Make symbols static if they're not exported.
798 (print_depth, new_backquote_output, being_printed, print_buffer):
799 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
800 (print_interval, print_number_index, initial_stderr_stream):
802 * lisp.h (Fprinc): Remove decl.
803 (debug_output_compilation_hack): Mark as externally visible.
805 * sysdep.c (croak): Move decl from here to syssignal.h.
806 * syssignal.h (croak): Put it here, so the API can be checked when
807 'croak' is called from dissociate_if_controlling_tty.
809 * minibuf.c: Make symbols static if they're not exported.
810 (minibuf_save_list, choose_minibuf_frame): Now static.
811 * lisp.h (choose_minibuf_frame): Remove decl.
813 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
815 * lread.c: Make symbols static if they're not exported.
816 (read_objects, initial_obarray, oblookup_last_bucket_number):
818 (make_symbol): Remove; unused.
819 * lisp.h (initial_obarray, make_symbol): Remove decls.
821 * keyboard.c: Make symbols static if they're not exported.
822 (single_kboard, recent_keys_index, total_keys, recent_keys):
823 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
824 (this_single_command_key_start, echoing, last_auto_save):
825 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
826 (command_loop, echo_now, keyboard_init_hook, help_char_p):
827 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
828 (Vlispy_mouse_stem, double_click_count):
830 (force_auto_save_soon): Define only if SIGDANGER.
831 (ignore_mouse_drag_p): Now static if
832 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
833 (print_help): Remove; unused.
834 (stop_character, last_timer_event): Mark as externally visible.
835 * keyboard.h (ignore_mouse_drag_p): Declare only if
836 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
837 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
838 * lisp.h (echoing): Remove decl.
839 (force_auto_save_soon): Declare only if SIGDANGER.
840 * xdisp.c (redisplay_window): Simplify code, to make it more
841 obvious that ignore_mouse_drag_p is not accessed if !defined
842 USE_GTK && !defined HAVE_NS.
844 * intervals.c: Make symbols static if they're not exported.
845 (merge_properties_sticky, merge_interval_right, delete_interval):
847 * intervals.h (merge_interval_right, delete_interval): Remove decls.
849 * insdel.c: Make symbols static if they're not exported.
850 However, leave prepare_to_modify_buffer alone. It's never
851 called from outside this function, but that appears to be a bug.
852 (combine_after_change_list, combine_after_change_buffer):
853 (adjust_after_replace, signal_before_change): Now static.
854 (adjust_after_replace_noundo): Remove; unused.
855 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
856 (signal_before_change): Remove decls.
858 * indent.c (val_compute_motion, val_vmotion): Now static.
860 * image.c: Make symbols static if they're not exported.
861 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
863 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
864 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
866 * fringe.c (standard_bitmaps): Now static.
867 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
869 * frame.c: Make symbols static if they're not exported.
870 (x_report_frame_params, make_terminal_frame): Now static.
871 (get_frame_param): Now static, unless HAVE_NS.
872 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
873 (x_get_resource_string): Remove; not used.
874 * frame.h (make_terminal_frame, x_report_frame_params):
875 (x_get_resource_string); Remove decls.
876 (x_fullscreen_adjust): Declare only if WINDOWSNT.
877 * lisp.h (get_frame_param): Declare only if HAVE_NS.
879 * font.c, fontset.c: Make symbols static if they're not exported.
880 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
881 (FACE_SUITABLE_FOR_CHAR_P): Use it.
882 * font.c (font_close_object): Now static.
883 * font.h (font_close_object): Remove.
884 * fontset.c (FONTSET_OBJLIST): Remove.
885 (free_realized_fontset) #if-0 the body, which does nothing.
886 (face_suitable_for_char_p): #if-0, as it's never called.
887 * fontset.h (face_suitable_for_char_p): Remove decl.
888 * xfaces.c (face_at_string_position): Use
889 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
890 since 0 is always ASCII.
892 * fns.c (weak_hash_tables): Now static.
894 * fileio.c: Make symbols static if they're not exported.
895 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
896 (Vwrite_region_annotation_buffers): Now static.
898 * eval.c: Make symbols static if they're not exported.
899 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
900 * lisp.h (backtrace_list): Remove decl.
902 * emacs.c: Make symbols static if they're not exported.
903 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
904 (fatal_error_code, fatal_error_signal_hook, standard_args):
906 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
907 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
908 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
909 * lisp.h (fatal_error_signal_hook): Remove decl.
910 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
912 * editfns.c: Move a (normally-unused) function to its only use.
913 * editfns.c, lisp.h (get_operating_system_release): Remove.
914 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
915 worth the hassle of breaking this out.
917 * xterm.c: Make symbols static if they're not exported.
918 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
919 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
920 (x_destroy_window, x_delete_display):
922 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
923 (x_mouse_leave): Remove; unused.
924 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
925 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
926 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
928 (x_mouse_leave): Declare only if WINDOWSNT.
929 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
930 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
933 * ftxfont.c: Make symbols static if they're not exported.
934 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
936 * font.h (ftxfont_driver): Likewise.
938 * xfns.c: Make symbols static if they're not exported.
939 (x_last_font_name, x_display_info_for_name):
940 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
941 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
942 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
943 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
944 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
945 (last_show_tip_args): Now static.
946 (xic_defaut_fontset, xic_create_fontsetname): Define only if
947 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
948 (x_screen_planes): Remove; unused.
949 * dispextern.h (x_screen_planes): Remove decl.
951 * dispnew.c: Make symbols static if they're not exported.
952 * dispextern.h (redraw_garbaged_frames, scrolling):
953 (increment_row_positions): Remove.
954 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
955 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
957 (redraw_garbaged_frames): Remove; unused.
959 * xfaces.c: Make symbols static if they're not exported.
960 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
962 * xterm.h (defined_color): Remove decls.
963 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
964 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
965 (menu_face_changed_default, defined_color, free_realized_face):
966 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
967 (ascii_face_of_lisp_face): Remove; unused.
969 * xdisp.c: Make symbols static if they're not exported.
970 * dispextern.h (scratch_glyph_row, window_box_edges):
971 (glyph_to_pixel_coords, set_cursor_from_row):
972 (get_next_display_element, set_iterator_to_next):
973 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
974 (show_mouse_face): Remove decls
975 * frame.h (message_buf_print): Likewise.
976 * lisp.h (pop_message, set_message, check_point_in_composition):
978 * xterm.h (set_vertical_scroll_bar): Likewise.
979 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
980 (message_buf_print, scratch_glyph_row, displayed_buffer):
981 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
982 (get_next_display_element, show_mouse_face, window_box_edges):
983 (frame_to_window_pixel_xy, check_point_in_composition):
984 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
985 (glyph_to_pixel_coords): Remove; unused.
987 * dired.c (file_name_completion): Now static.
989 * dbusbind.c (xd_in_read_queued_messages): Now static.
991 * lisp.h (circular_list_error, FOREACH): Remove; unused.
992 * data.c (circular_list_error): Remove.
994 * commands.h (last_point_position, last_point_position_buffer):
995 (last_point_position_window): Remove decls.
996 * keyboard.c: Make these variables static.
998 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1000 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1001 (iso_code_class, detect_coding, code_convert_region): Now static.
1002 (encode_coding_gap): Remove; unused.
1004 * chartab.c (chartab_chars, chartab_bits): Now static.
1006 * charset.h (charset_iso_8859_1): Remove decl.
1007 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1010 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1011 * ccl.c (Vccl_program_table): Now static.
1012 (check_ccl_update): Remove; unused.
1014 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1015 * category.h: ... from here.
1016 * category.c (check_category_table, set_category_set): Now static.
1018 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1019 * lisp.h: Remove these decls.
1021 * buffer.c (buffer_count): Remove unused var.
1023 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1024 so that it's not optimized away.
1025 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1026 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1027 exported only to the debugger.
1029 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1030 * atimer.h (run_all_atimers): Removed; not exported.
1032 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1033 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1034 was inaccessible from Lisp.
1035 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1036 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1038 alloc.c: Import and export fewer symbols, and remove unused items.
1039 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1041 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1042 it's not optimized away by whole-program optimization.
1043 (message_enable_multibyte, free_misc): Remove.
1044 (catchlist, handlerlist, mark_backtrace):
1045 Declare only if BYTE_MARK_STACK.
1046 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1047 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1048 (message_enable_multibyte): Remove decl.
1049 (free_misc, interval_free_list, float_block, float_block_index):
1050 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1051 (cons_free_list, last_marked_index):
1053 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1054 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1055 (mark_backtrace): Define only if BYTE_MARK_STACK.
1056 * xdisp.c (message_enable_multibyte): Now static.
1058 Declare Lisp_Object Q* variables to be 'static' if not exported.
1059 This makes it easier for human readers (and static analyzers)
1060 to see whether these variables are used from other modules.
1061 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1062 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1063 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1064 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1065 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1066 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1067 * xmenu.c, xselect.c:
1068 Declare Q* vars static if they are not used in other modules.
1069 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1070 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1071 Remove decls of unexported vars.
1072 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1074 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1076 Make Emacs functions such as Fatom 'static' by default.
1077 This makes it easier for human readers (and static analyzers)
1078 to see whether these functions can be called from other modules.
1079 DEFUN now defines a static function. To make the function external
1080 so that it can be used in other C modules, use the new macro DEFUE.
1081 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1082 (Finit_image_library):
1083 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1084 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1085 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1086 Remove decls, since these functions are now static.
1087 (Funintern, Fget_internal_run_time): New decls, since these functions
1088 were already external.
1090 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1091 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1092 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1093 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1094 * keyboard.c, keymap.c, lread.c:
1095 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1096 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1097 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1098 Mark functions with DEFUE instead of DEFUN,
1099 if they are used in other modules.
1100 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1101 decls for now-static functions.
1102 * buffer.h (Fdelete_overlay): Remove decl.
1103 * callproc.c (Fgetenv_internal): Mark as internal.
1104 * composite.c (Fremove_list_of_text_properties): Remove decl.
1105 (Fcomposition_get_gstring): New forward static decl.
1106 * composite.h (Fcomposite_get_gstring): Remove decl.
1107 * dired.c (Ffile_attributes): New forward static decl.
1108 * doc.c (Fdocumntation_property): New forward static decl.
1109 * eval.c (Ffetch_bytecode): New forward static decl.
1110 (Funintern): Remove extern decl; now in .h file where it belongs.
1111 * fileio.c (Fmake_symbolic_link): New forward static decl.
1112 * image.c (Finit_image_library): New forward static decl.
1113 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1114 * intervals.h (Fprevious_property_change):
1115 (Fremove_list_of_text_properties): Remove decls.
1116 * keyboard.c (Fthis_command_keys): Remove decl.
1117 (Fcommand_execute): New forward static decl.
1118 * keymap.c (Flookup_key): New forward static decl.
1119 (Fcopy_keymap): Now static.
1120 * keymap.h (Flookup_key): Remove decl.
1121 * process.c (Fget_process): New forward static decl.
1122 (Fprocess_datagram_address): Mark as internal.
1123 * syntax.c (Fsyntax_table_p): New forward static decl.
1124 (skip_chars): Remove duplicate decl.
1125 * textprop.c (Fprevious_property_change): New forward static decl.
1126 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1128 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1129 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1131 * editfns.c (Fformat): Remove unreachable code.
1133 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1135 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1138 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1140 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1141 when at ZV. (Bug#8487)
1143 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1145 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1147 * keyboard.c (parse_tool_bar_item): Likewise.
1148 * sound.c (sound_cleanup, alsa_close): Likewise.
1149 * termcap.c (tgetent): Likewise.
1150 * xfns.c (x_default_font_parameter): Likewise.
1151 * xsettings.c (read_and_apply_settings): Likewise.
1153 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1154 (overrun_check_free): Protoize.
1156 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1158 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1159 since callers should never pass a negative size.
1160 Change the signature to match that of plain 'read' and 'write'; see
1161 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1162 * lisp.h: Update prototypes of emacs_write and emacs_read.
1164 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1166 * xdisp.c (redisplay_window): Don't try to determine the character
1167 position of the scroll margin if the window start point w->startp
1168 is outside the buffer's accessible region. (Bug#8468)
1170 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1172 Fix write-region and its subroutines for buffers > 2GB.
1173 * fileio.c (a_write, e_write): Modify declaration of arguments and
1174 local variables to support buffers larger than 2GB.
1175 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1177 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1178 argument, local variables, and return value.
1180 * lisp.h: Update prototypes of emacs_write and emacs_read.
1182 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1184 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1186 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1188 Fix more problems found by GCC 4.6.0's static checks.
1190 * xdisp.c (vmessage): Use a better test for character truncation.
1192 * charset.c (load_charset_map): <, not <=, for optimization,
1193 and to avoid potential problems with integer overflow.
1194 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1195 * casetab.c (set_identity, shuffle): Likewise.
1196 * editfns.c (Fformat): Likewise.
1197 * syntax.c (skip_chars): Likewise.
1199 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1200 This also lets GCC 4.6.0 generate slightly better loop code.
1202 * callint.c (Fcall_interactively): <, not <=, for optimization.
1203 (Fcall_interactively): Count the number of arguments produced,
1204 not the number of arguments given. This is simpler and lets GCC
1205 4.6.0 generate slightly better code.
1207 * ftfont.c: Distingish more carefully between FcChar8 and char.
1208 The previous code passed unsigned char * to a functions like
1209 strlen and xstrcasecmp that expect char *, which does not
1210 conform to the C standard.
1211 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1212 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1213 char * when the C standard requires it.
1215 * keyboard.c (read_char): Remove unused var.
1217 * eval.c: Port to Windows vsnprintf (Bug#8435).
1219 (SIZE_MAX): Define if the headers do not.
1220 (verror): Do not give up if vsnprintf returns a negative count.
1221 Instead, grow the buffer. This ports to Windows vsnprintf, which
1222 does not conform to C99. Problem reported by Eli Zaretskii.
1223 Also, simplify the allocation scheme, by avoiding the need for
1224 calling realloc, and removing the ALLOCATED variable.
1226 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1228 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1229 But keep the doprint source code for now, as we might revamp it
1230 and use it again (Bug#8435).
1231 * lisp.h (doprnt): Remove.
1232 * Makefile.in (base_obj): Remove doprnt.o.
1233 * deps.mk (doprnt.o): Remove.
1235 error: Print 32- and 64-bit integers portably (Bug#8435).
1236 Without this change, on typical 64-bit hosts error ("...%d...", N)
1237 was used to print both 32- and 64-bit integers N, which relied on
1239 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1241 * lisp.h (error, verror): Mark as printf-like functions.
1242 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1243 Report overflow in size calculations when allocating printf buffer.
1244 Do not truncate output string at its first null byte.
1245 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1246 Truncate the output at a character boundary, since vsnprintf does not
1248 * charset.c (check_iso_charset_parameter): Convert internal
1249 character to string before calling 'error', since %c now has the
1251 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1252 overflow when computing char to be passed to 'error'. Do not
1253 pass Lisp_Object to 'error'; pass the integer instead.
1254 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1255 formatted with plain %d.
1257 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1259 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1261 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1263 * xterm.c (x_catch_errors): Remove duplicate declaration.
1265 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1267 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1269 2011-04-10 Jim Meyering <meyering@redhat.com>
1271 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1272 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1273 return ssize_t not "int", and use size_t as the buffer length.
1274 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1275 * gnutls.h: Update declarations.
1276 * process.c (read_process_output): Use ssize_t, to match.
1277 (send_process): Likewise.
1279 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1281 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1283 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1285 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1286 unsigned char, to match FcChar8 type definition.
1288 * xterm.c (handle_one_xevent):
1289 * xmenu.c (create_and_show_popup_menu):
1290 * xselect.c (x_decline_selection_request)
1291 (x_reply_selection_request): Avoid type-punned deref of X events.
1293 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1295 Fix some uses of `int' instead of EMACS_INT.
1296 * search.c (string_match_1, fast_string_match)
1297 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1298 (scan_buffer, find_next_newline_no_quit)
1299 (find_before_next_newline, search_command, Freplace_match)
1300 (Fmatch_data): Make some `int' variables be EMACS_INT.
1302 * xdisp.c (display_count_lines): 3rd argument and return value now
1303 EMACS_INT. All callers changed.
1304 (pint2hrstr): Last argument is now EMACS_INT.
1306 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1307 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1308 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1309 (decode_coding_utf_16, decode_coding_emacs_mule)
1310 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1311 (decode_coding_ccl, decode_coding_charset)
1312 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1313 (decode_coding_iso_2022, decode_coding_emacs_mule)
1314 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1315 <char_offset, last_offset>: Declare EMACS_INT.
1316 (encode_coding_utf_8, encode_coding_utf_16)
1317 (encode_coding_emacs_mule, encode_invocation_designation)
1318 (encode_designation_at_bol, encode_coding_iso_2022)
1319 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1320 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1322 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1323 (encode_invocation_designation): Last argument P_NCHARS is now
1325 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1326 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1328 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1331 * ccl.c (Fccl_execute_on_string): Declare some variables
1334 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1336 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1338 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1340 * process.c (Fformat_network_address): Doc fix.
1342 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1344 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1346 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1348 * keyboard.c (read_char): Call Lisp function help-form-show,
1349 instead of using internal_with_output_to_temp_buffer.
1350 (Qhelp_form_show): New var.
1351 (syms_of_keyboard): Use DEFSYM macro.
1353 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1355 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1357 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1359 * process.c (Flist_processes): Removed to Lisp.
1360 (list_processes_1): Deleted.
1362 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1364 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1366 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1368 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1370 Fix more problems found by GCC 4.6.0's static checks.
1372 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1374 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1376 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1378 * xdisp.c (vmessage): Mark as a printf-like function.
1380 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1382 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1384 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1385 printf-like functions.
1386 (tiff_load): Add casts to remove these marks before passing them
1387 to system-supplied API.
1389 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1391 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1392 This avoids several warnings with gcc -Wstrict-overflow.
1393 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1394 directly, rather than having caller test rule sign. This avoids
1395 some unnecessary tests.
1396 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1397 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1398 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1400 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1401 (xfont_open): Avoid unnecessary tests.
1403 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1405 * composite.h, composite.c (composition_gstring_put_cache):
1406 Use EMACS_INT, not int, for length.
1408 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1409 breaking out part of COMPOSITION_DECODE_RULE.
1410 (COMPOSITION_DECODE_RULE): Use it.
1411 * composite.c (get_composition_id): Remove unused local vars,
1412 by using the new macro.
1414 * textprop.c (set_text_properties_1): Change while to do-while,
1415 since the condition is always true at first.
1417 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1418 (interval_deletion_adjustment): Return unsigned value.
1421 * process.c (list_processes_1, create_pty, read_process_output):
1422 (exec_sentinel): Remove vars that were set but not used.
1423 (create_pty): Remove unnecessary "volatile"s.
1424 (Fnetwork_interface_info): Avoid possibility of int overflow.
1425 (read_process_output): Do adaptive read buffering even if carryover.
1426 (read_process_output): Simplify nbytes computation if buffered.
1428 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1430 * syntax.c (scan_words): Remove var that was set but not used.
1431 (update_syntax_table): Use unsigned instead of int.
1433 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1434 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1435 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1437 * print.c (print_error_message): Avoid int overflow.
1439 * font.c (font_list_entities): Redo for clarity,
1440 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1442 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1443 (font_score): Avoid potential overflow in diff calculation.
1445 * fns.c (substring_both): Remove var that is set but not used.
1446 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1448 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1450 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1451 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1452 can always succeed if overflow has undefined behavior.
1454 * search.c (boyer_moore, wordify): Remove vars set but not used.
1455 (wordify): Omit three unnecessary tests.
1457 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1458 All callers changed. This avoids the need for an unused var.
1460 * casefiddle.c (casify_region): Remove var that is set but not used.
1462 * dired.c (file_name_completion): Remove var that is set but not used.
1464 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1466 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1467 (Finsert_file_contents): Remove unnecessary code checking fd.
1469 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1470 Check for integer overflow on size calculations.
1472 * buffer.c (Fprevious_overlay_change): Remove var that is set
1475 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1476 Remove vars that are set but not used.
1477 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1478 (timer_check_2): Mark vars as initialized.
1480 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1482 * image.c (lookup_image): Remove var that is set but not used.
1483 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1485 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1486 that are set but not used.
1488 * xfns.c (make_invisible_cursor): Don't return garbage
1489 if XCreateBitmapFromData fails (Bug#8410).
1491 * xselect.c (x_get_local_selection, x_handle_property_notify):
1492 Remove vars that are set but not used.
1494 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1495 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1497 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1498 Remove var that is set but not used.
1499 (scroll_bar_windows_size): Now size_t, not int.
1500 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1503 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1504 (map_tty_color) [!defined MSDOS]: Likewise.
1506 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1508 * coding.c: Remove vars that are set but not used.
1509 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1510 All callers changed.
1511 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1512 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1513 (decode_coding_charset): Remove vars that are set but not used.
1515 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1516 that is set but not used.
1518 * print.c (print_object): Remove var that is set but not used.
1520 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1521 The gnulib version avoids calling malloc in the usual case,
1522 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1523 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1524 * filelock.c (current_lock_owner): Likewise.
1525 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1526 * sysdep.c: Include allocator.h, careadlinkat.h.
1527 (emacs_no_realloc_allocator): New static constant.
1528 (emacs_readlink): New function.
1529 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1530 ../lib/careadlinkat.h.
1532 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1534 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1535 first non-nil return value).
1537 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1539 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1540 if not defined (Bug#8403).
1542 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1544 * xdisp.c (display_count_lines): Remove parameter `start',
1545 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1546 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1547 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1548 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1549 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1550 and thereabouts. All callers changed.
1551 (get_per_char_metric): Remove parameter `f', unused since
1552 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1554 2011-04-02 Jim Meyering <meyering@redhat.com>
1556 do not dereference NULL upon failed strdup
1557 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1558 (ns_get_family): Likewise.
1560 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1562 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1564 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1566 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1569 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1571 Add lexical binding.
1573 * window.c (Ftemp_output_buffer_show): New fun.
1574 (Fsave_window_excursion):
1575 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1577 * lread.c (lisp_file_lexically_bound_p): New function.
1578 (Fload): Bind Qlexical_binding.
1579 (readevalloop): Remove `evalfun' arg.
1580 Bind Qinternal_interpreter_environment.
1581 (Feval_buffer): Bind Qlexical_binding.
1582 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1584 (syms_of_lread): Declare `lexical-binding'.
1586 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1588 * keyboard.c (eval_dyn): New fun.
1589 (menu_item_eval_property): Use it.
1591 * image.c (parse_image_spec): Use Ffunctionp.
1593 * fns.c (concat, mapcar1): Accept byte-code-functions.
1595 * eval.c (Fsetq): Handle lexical vars.
1596 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1597 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1598 (FletX, Flet): Obey lexical binding.
1599 (Fcommandp): Handle closures.
1600 (Feval): New `lexical' arg.
1601 (eval_sub): New function extracted from Feval. Use it almost
1602 everywhere where Feval was used. Look up vars in lexical env.
1604 (Ffunctionp): Move from subr.el.
1605 (Ffuncall): Handle closures.
1606 (apply_lambda): Remove `eval_flags'.
1607 (funcall_lambda): Handle closures and new byte-code-functions.
1608 (Fspecial_variable_p): New function.
1609 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1610 but without exporting it to Lisp.
1612 * doc.c (Fdocumentation, store_function_docstring):
1613 * data.c (Finteractive_form): Handle closures.
1615 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1618 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1620 (exec_byte_code): New function extracted from Fbyte_code to handle new
1621 calling convention for byte-code-functions. Add new byte-codes.
1623 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1625 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1627 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1629 * xdisp.c (redisplay_internal): Fix prototype.
1631 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1633 * xdisp.c (SCROLL_LIMIT): New macro.
1634 (try_scrolling): Use it when setting scroll_limit. Limit
1635 scrolling to 100 screen lines.
1636 (redisplay_window): Even when falling back on "recentering",
1637 position point in the window according to scroll-conservatively,
1638 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1640 (try_scrolling): When point is above the window, allow searching
1641 as far as scroll_max, or one screenful, to compute vertical
1642 distance from PT to the scroll margin position. This prevents
1643 try_scrolling from unnecessarily failing when
1644 scroll-conservatively is set to a value slightly larger than the
1645 window height. Clean up the case of PT below the margin at bottom
1646 of window: scroll_max can no longer be INT_MAX. When aggressive
1647 scrolling is in use, don't let point enter the opposite scroll
1648 margin as result of the scroll.
1649 (syms_of_xdisp) <scroll-conservatively>: Document the
1650 threshold of 100 lines for never-recentering scrolling.
1652 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1654 * dispextern.h (move_it_by_lines):
1655 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1656 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1657 (message_log_check_duplicate): Remove parameters `prev_bol' and
1658 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1659 (redisplay_internal): Remove parameter `preserve_echo_area',
1660 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1662 * indent.c (Fvertical_motion):
1663 * window.c (window_scroll_pixel_based, Frecenter):
1664 Don't pass `need_y_p' to `move_it_by_lines'.
1666 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1668 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1669 steal a few bits to be more compact.
1670 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1671 Remove unneeded casts.
1673 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1675 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1677 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1678 binding" message (bug#7967).
1680 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1682 Fix more problems found by GCC 4.6.0's static checks.
1684 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1685 Remove unused local var.
1687 * editfns.c (Fmessage_box): Remove unused local var.
1689 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1690 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1691 Omit unused local vars.
1692 * window.c (shrink_windows): Omit unused local var.
1693 * menu.c (digest_single_submenu): Omit unused local var.
1694 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1695 Omit unused local var.
1697 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1698 Don't assume string length fits in int.
1699 (keyremap_step, read_key_sequence): Use size_t for sizes.
1700 (read_key_sequence): Don't check last_real_key_start redundantly.
1702 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1703 instead of alloca (Bug#8344).
1705 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1706 (Fbacktrace_frame): Don't assume nframes fits in int.
1708 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1710 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1713 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1715 * cm.c (calccost): Turn while-do into do-while, for clarity.
1717 * keyboard.c (syms_of_keyboard): Use the same style as later
1718 in this function when indexing through an array. This also
1719 works around GCC bug 48267.
1721 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1723 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1725 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1726 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1728 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1729 This avoids undefined behavior on integer overflow, and is a bit
1730 more convenient anyway since it is compared to a size_t variable.
1732 Variadic C functions now count arguments with size_t, not int.
1733 This avoids an unnecessary limitation on 64-bit machines, which
1734 caused (substring ...) to crash on large vectors (Bug#8344).
1735 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1736 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1737 All variadic functions and their callers changed accordingly.
1738 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1739 * data.c (arith_driver, float_arith_driver): Likewise.
1740 * editfns.c (general_insert_function): Likewise.
1741 * eval.c (struct backtrace.nargs, interactive_p)
1742 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1743 (funcall_lambda, mark_backtrace): Likewise.
1744 * fns.c (concat): Likewise.
1745 * frame.c (x_set_frame_parameters): Likewise.
1746 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1747 0 if not found, not -1. All callers changed.
1749 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1750 (stack_copy_size): Now size_t, not int.
1751 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1753 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1755 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1756 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1757 All callers changed.
1759 * lisp.h (multibyte_char_to_unibyte):
1760 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1761 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1762 * character.h (CHAR_TO_BYTE8):
1763 * cmds.c (internal_self_insert):
1764 * editfns.c (general_insert_function):
1765 * keymap.c (push_key_description):
1766 * search.c (Freplace_match):
1767 * xdisp.c (message_dolog, set_message_1): All callers changed.
1769 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1771 * keyboard.c (safe_run_hook_funcall): New function.
1772 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1773 don't set the hook to nil, but remove the offending function instead.
1774 (Qcommand_hook_internal): Remove, unused.
1775 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1776 Vcommand_hook_internal.
1778 * eval.c (enum run_hooks_condition): Remove.
1779 (funcall_nil, funcall_not): New functions.
1780 (run_hook_with_args): Call each function through a `funcall' argument.
1781 Remove `cond' argument, now redundant.
1782 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1783 (Frun_hook_with_args_until_failure): Adjust accordingly.
1784 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1786 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1788 * dispextern.h (string_buffer_position): Remove declaration.
1790 * print.c (strout): Remove parameter `multibyte', unused since
1791 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1793 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1794 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1795 All callers changed.
1797 * w32.c (_wsa_errlist): Use braces for struct initializers.
1799 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1800 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1801 All callers changed.
1802 (string_buffer_position): Likewise. Also, make static (it's never
1803 used outside xdisp.c).
1804 (cursor_row_p): Remove parameter `w', unused since
1805 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1806 (decode_mode_spec): Remove parameter `precision', introduced during
1807 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1808 All callers changed.
1810 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1812 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1814 2011-03-27 Anders Lindgren <andlind@gmail.com>
1816 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1817 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1818 (ns_update_auto_hide_menu_bar): New functions.
1819 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1820 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1821 ns_constrain_all_frames.
1822 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1823 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1825 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1827 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1829 2011-03-27 Glenn Morris <rgm@gnu.org>
1831 * syssignal.h: Replace RETSIGTYPE with void.
1832 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1833 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1834 Replace SIGTYPE with void everywhere.
1835 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1836 * s/template.h (SIGTYPE): Remove commented out definition.
1838 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1840 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1841 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1843 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1845 * w32.c (read_unc_volume): Use parameter `henum', instead of
1846 global variable `wget_enum_handle'.
1848 * keymap.c (describe_vector): Remove parameters `indices' and
1849 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1850 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1852 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1854 * keyboard.c (timer_check): Remove parameter `do_it_now',
1855 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1856 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1857 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1859 * keyboard.c (read_char):
1860 * w32menu.c (w32_menu_display_help):
1861 * xmenu.c (show_help_event, menu_help_callback):
1862 Adjust calls to `show_help_echo'.
1864 * gtkutil.c (xg_maybe_add_timer):
1865 * keyboard.c (readable_events):
1866 * process.c (wait_reading_process_output):
1867 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1869 * insdel.c (adjust_markers_gap_motion):
1870 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1871 (gap_left, gap_right): Don't call it.
1873 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1875 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1876 incurred during fontification.
1878 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1880 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1881 (DEFVAR_PER_BUFFER): Don't pass it.
1883 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1884 (scrolling_window): Don't pass it.
1886 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1888 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1890 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1892 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1893 of variables specific to SELinux and computation of `encoded_absname'.
1895 * image.c (XPutPixel): Remove unused variable `height'.
1897 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1899 * unexw32.c (get_section_info): Remove unused variable `section'.
1901 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1902 (system_process_attributes): Remove unused variable `sess'.
1903 (sys_read): Remove unused variable `err'.
1905 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1906 (w32_wnd_proc): Remove unused variable `isdead'.
1907 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1908 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1909 (x_create_tip_frame): Remove unused variable `tem'.
1911 * w32inevt.c (w32_console_read_socket):
1912 Remove unused variable `no_events'.
1914 * w32term.c (x_draw_composite_glyph_string_foreground):
1915 Remove unused variable `width'.
1917 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
1919 * w32term.c (x_set_glyph_string_clipping):
1920 Don't pass uninitialized region to CombineRgn.
1922 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
1924 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1925 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1926 (Fx_close_connection): Remove unused variable `i'.
1928 * w32font.c (w32font_draw): Return number of glyphs.
1929 (w32font_open_internal): Remove unused variable `i'.
1930 (w32font_driver): Add missing initializer.
1932 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1933 (fill_in_menu): Remove unused variable `items_added'.
1935 * w32term.c (last_mouse_press_frame): Remove static global variable.
1936 (w32_clip_to_row): Remove unused variable `f'.
1937 (x_delete_terminal): Remove unused variable `i'.
1939 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1940 (NOTHING): Remove unused static global variable.
1941 (uniscribe_check_otf): Remove unused variable `table'.
1942 (uniscribe_font_driver): Add missing initializers.
1944 2011-03-23 Julien Danjou <julien@danjou.info>
1946 * term.c (Fsuspend_tty, Fresume_tty):
1947 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1948 * window.c (temp_output_buffer_show):
1949 * insdel.c (signal_before_change):
1950 * frame.c (Fhandle_switch_frame):
1951 * fileio.c (Fdo_auto_save):
1952 * emacs.c (Fkill_emacs):
1953 * editfns.c (save_excursion_restore):
1954 * cmds.c (internal_self_insert):
1955 * callint.c (Fcall_interactively):
1956 * buffer.c (Fkill_all_local_variables):
1957 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1959 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
1960 unconditionnaly since it does the check itself.
1962 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
1964 Fix more problems found by GCC 4.5.2's static checks.
1966 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1967 the first time through the loop, since we know p0 < p1 then.
1968 This also avoids a gcc -Wstrict-overflow warning.
1970 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1971 leading to a memory leak, possible in functions like
1972 load_charset_map_from_file that can allocate an unbounded number
1973 of objects (Bug#8318).
1975 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1976 that could (at least in theory) be that large.
1978 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1979 This is less likely to overflow, and avoids undefined behavior if
1980 overflow does occur. All callers changed. Use strtoul to scan
1981 for the unsigned long integer.
1982 (pint2hrstr): Simplify and tune code slightly.
1983 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1985 * scroll.c (do_scrolling): Work around GCC bug 48228.
1986 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1988 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1989 This also avoids a warning with gcc -Wstrict-overflow.
1990 (validate_x_resource_name): Simplify count usage.
1991 This also avoids a warning with gcc -Wstrict-overflow.
1993 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1996 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1998 * process.c (Fmake_network_process): Use socklen_t, not int,
1999 where POSIX says socklen_t is required in portable programs.
2000 This fixes a porting bug on hosts like 64-bit HP-UX, where
2001 socklen_t is wider than int (Bug#8277).
2002 (Fmake_network_process, server_accept_connection):
2003 (wait_reading_process_output, read_process_output):
2006 * process.c: Rename or move locals to avoid shadowing.
2007 (list_processes_1, Fmake_network_process):
2008 (read_process_output_error_handler, exec_sentinel_error_handler):
2009 Rename or move locals.
2010 (Fmake_network_process): Define label "retry_connect" only if needed.
2011 (Fnetwork_interface_info): Fix pointer signedness.
2012 (process_send_signal): Add cast to avoid pointer signedness problem.
2013 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2014 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2016 Make tparam.h and terminfo.c consistent.
2017 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2018 Include tparam.h instead, since it declares them.
2019 * cm.h (PC): Remove extern decl; tparam.h now does this.
2020 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2021 * terminfo.c: Include tparam.h, to check interfaces.
2022 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2023 (tparam): Adjust signature to match interface in tparam.h;
2024 this removes some undefined behavior. Check that outstring and len
2025 are zero, which they always are with Emacs.
2026 * tparam.h (PC, BC, UP): New extern decls.
2028 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2029 (xftfont_open): Rename locals to avoid shadowing.
2031 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2032 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2033 (OTF_TAG_SYM): Omit macro if not needed.
2034 (ftfont_list): Remove unused local.
2035 (get_adstyle_property, ftfont_pattern_entity):
2036 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2037 Rename locals to avoid shadowing.
2039 * xfont.c (xfont_list_family): Mark var as initialized.
2041 * xml.c (make_dom): Now static.
2043 * composite.c (composition_compute_stop_pos): Rename local to
2045 (composition_reseat_it): Remove unused locals.
2046 (find_automatic_composition, composition_adjust_point): Likewise.
2047 (composition_update_it): Mark var as initialized.
2048 (find_automatic_composition): Mark vars as initialized,
2049 with a FIXME (Bug#8290).
2051 character.h: Rename locals to avoid shadowing.
2052 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2053 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2054 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2055 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2058 * textprop.c (property_change_between_p): Remove; unused.
2060 * intervals.c (interval_start_pos): Now static.
2062 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2064 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2065 Rename locals to avoid shadowing.
2067 * sound.c (wav_play, au_play, Fplay_sound_internal):
2068 Fix pointer signedness.
2069 (alsa_choose_format): Remove unused local var.
2070 (wav_play): Initialize a variable to 0, to prevent undefined
2071 behavior (Bug#8278).
2073 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2075 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2077 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2078 clobbering (Bug#8298).
2079 * sysdep.c (sys_subshell): Likewise.
2080 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2082 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2083 This should get cleaned up, so that child_setup has the
2084 same signature on all platforms.
2086 * callproc.c (call_process_cleanup): Now static.
2087 (relocate_fd): Rename locals to avoid shadowing.
2089 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2091 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2092 not to be necessary, and produces flickering.
2094 2011-03-20 Glenn Morris <rgm@gnu.org>
2096 * config.in: Remove file.
2098 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2100 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2101 are now in src/globals.h.
2102 (syms_of_minibuf): Remove spurious & from previous change.
2104 2011-03-20 Leo <sdl.web@gmail.com>
2106 * minibuf.c (completing-read-function): New variable.
2107 (completing-read-default): Rename from completing-read.
2108 (completing-read): Call completing-read-function.
2110 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2112 * xfaces.c (Fx_load_color_file):
2113 Read color file from absolute filename (bug#8250).
2115 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2117 * makefile.w32-in: Update dependencies.
2119 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2121 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2123 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2125 Fix more problems found by GCC 4.5.2's static checks.
2127 * process.c (make_serial_process_unwind, send_process_trap):
2128 (sigchld_handler): Now static.
2130 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2131 That way, the code declares only the vars that it needs.
2132 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2133 * s/cygwin.h (PTY_ITERATION): Likewise.
2134 * s/darwin.h (PTY_ITERATION): Likewise.
2135 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2137 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2138 * process.c (allocate_pty): Don't declare stb unless it's needed.
2140 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2141 (CONSTANTLIM): Remove; unused.
2142 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2143 Define only if needed.
2145 * unexelf.c (unexec): Name an expression,
2146 to avoid gcc -Wbad-function-cast warning.
2147 Use a different way to cause a compilation error if anyone uses
2148 n rather than nn, a way that does not involve shadowing.
2149 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2151 * deps.mk (unexalpha.o): Remove; unused.
2153 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2154 * unexec.h: New file.
2155 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2156 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2158 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2159 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2160 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2161 Change as necessary to match prototype in unexec.h.
2163 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2165 (back_comment, skip_chars): Mark vars as initialized.
2167 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2168 Rename locals to avoid shadowing.
2170 * lread.c (read1): Rewrite so as not to use empty "else".
2171 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2173 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2175 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2176 warning when compiling print.c.
2178 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2179 instead of using an uninitialized var.
2180 (font_sort_entities): Mark var as initialized.
2182 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2184 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2185 pointers to constants.
2186 (font_parse_fcname): Remove unused vars.
2187 (font_delete_unmatched): Now static.
2188 (font_get_spec): Remove; unused.
2189 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2190 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2191 Rename or move locals to avoid shadowing.
2193 * fns.c (require_nesting_list, require_unwind): Now static.
2194 (Ffillarray): Rename locals to avoid shadowing.
2196 * floatfns.c (domain_error2): Define only if needed.
2197 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2199 * alloc.c (mark_backtrace): Move decl from here ...
2200 * lisp.h: ... to here, so that it can be checked.
2202 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2203 (Fdefvar): Rewrite so as not to use empty "else".
2204 (lisp_indirect_variable): Name an expression,
2205 to avoid gcc -Wbad-function-cast warning.
2206 (Fdefvar): Rename locals to avoid shadowing.
2208 * callint.c (quotify_arg, quotify_args): Now static.
2209 (Fcall_interactively): Rename locals to avoid shadowing.
2210 Use const pointer when appropriate.
2212 * lisp.h (get_system_name, get_operating_system_release):
2213 Move decls here, to check interfaces.
2214 * process.c (get_operating_system_release): Move decl to lisp.h.
2215 * xrdb.c (get_system_name): Likewise.
2216 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2217 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2218 some of which prompt warnings from gcc -Wbad-function-cast.
2219 (Fformat_time_string, Fencode_time, Finsert_char):
2220 (Ftranslate_region_internal, Fformat):
2221 Rename or remove local vars to avoid shadowing.
2222 (Ftranslate_region_internal): Mark var as initialized.
2224 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2227 * lisp.h (eassert): Check that the argument compiles, even if
2228 ENABLE_CHECKING is not defined.
2230 * data.c (Findirect_variable): Name an expression, to avoid
2231 gcc -Wbad-function-cast warning.
2232 (default_value, arithcompare, arith_driver, arith_error): Now static.
2233 (store_symval_forwarding): Rename local to avoid shadowing.
2234 (Fmake_variable_buffer_local, Fmake_local_variable):
2235 Mark variables as initialized.
2236 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2238 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2239 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2240 Rename locals to avoid shadowing.
2241 (mark_stack): Move local variables into the #ifdef region where
2243 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2244 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2246 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2247 (GC_STRING_CHARS): Remove; not used.
2248 (Fmemory_limit): Cast sbrk's returned value to char *.
2250 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2251 avoids undefined behavior in theory.
2253 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2255 Use functions, not macros, for up- and down-casing (Bug#8254).
2256 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2257 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2258 to use the following functions instead of these macros.
2259 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2260 EMACS_INT, since callers assume the returned value fits in int.
2261 (upcase1): Likewise, for UPCASE_TABLE.
2262 (uppercasep, lowercasep, upcase): New static inline functions.
2263 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2264 the race-condition problem in the old DOWNCASE.
2266 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2267 Rename locals to avoid shadowing.
2268 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2269 (regex_compile, re_search_2, re_match_2_internal):
2270 Remove unused local vars.
2271 (FREE_VAR): Rewrite so as not to use empty "else",
2272 which gcc can warn about.
2273 (regex_compile, re_match_2_internal): Mark locals as initialized.
2274 (RETALLOC_IF): Define only if needed.
2275 (WORDCHAR_P): Likewise. This one is never needed, but is used
2276 only in a comment talking about a compiler bug, so put inside
2277 the #if 0 of that comment.
2278 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2279 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2282 * search.c (boyer_moore): Rename locals to avoid shadowing.
2283 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2284 (PREV_CHAR_BOUNDARY): Likewise.
2286 * search.c (simple_search): Remove unused var.
2288 * dired.c (compile_pattern): Move decl from here ...
2289 * lisp.h: ... to here, so that it can be checked.
2290 (struct re_registers): New forward decl.
2292 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2294 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2296 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2297 Rename locals to avoid shadowing.
2298 (Fvertical_motion): Mark locals as initialized.
2300 * casefiddle.c (casify_object, casify_region): Now static.
2301 (casify_region): Mark local as initialized.
2303 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2305 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2306 New macros, so that the caller can use some names other than
2307 gcpro1, gcpro2, etc.
2308 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2310 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2311 argument, for consistency with GCPRO2_VAR, etc: it is now the
2312 prefix of the variable, not the variable itself. All uses
2314 * dired.c (directory_files_internal, file_name_completion):
2315 Rename locals to avoid shadowing.
2317 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2318 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2319 dired.c's scmp function, had undefined behavior.
2320 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2321 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2322 * buffer.h: ... to here, because these macros use current_buffer,
2323 and the new implementation with inline functions needs to have
2324 current_buffer in scope now, rather than later when the macros
2326 (downcase, upcase1): New static inline functions.
2327 (DOWNCASE, UPCASE1): Reimplement using these functions.
2328 This avoids undefined behavior in expressions like
2329 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2330 from race conditions in accessing the global variables
2331 case_temp1 and case_temp2.
2332 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2333 * lisp.h (case_temp1, case_temp2): Remove their decls.
2334 * character.h (ASCII_CHAR_P): Move from here ...
2335 * lisp.h: ... to here, so that the inline functions mentioned
2338 * dired.c (directory_files_internal_unwind): Now static.
2340 * fileio.c (file_name_as_directory, directory_file_name):
2341 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2343 (file_name_as_directory): Use const pointers when appropriate.
2344 (Fexpand_file_name): Likewise. In particular, newdir might
2345 point at constant storage, so make it a const pointer.
2346 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2347 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2349 (Fset_file_times, Finsert_file_contents, auto_save_error):
2350 Rename locals to avoid shadowing.
2352 * minibuf.c (choose_minibuf_frame_1): Now static.
2353 (Ftry_completion, Fall_completions): Rename or remove locals
2356 * marker.c (bytepos_to_charpos): Remove; unused.
2358 * lisp.h (verify_bytepos, count_markers): New decls,
2359 so that gcc does not warn that these functions aren't declared.
2361 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2362 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2363 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2364 (copy_text): Remove unused local var.
2366 * filelock.c (within_one_second): Now static.
2367 (lock_file_1): Rename local to avoid shadowing.
2369 * buffer.c (fix_overlays_before): Mark locals as initialized.
2370 (fix_start_end_in_overlays): Likewise. This function should be
2371 simplified by using pointers-to-pointers, but that's a different
2373 (switch_to_buffer_1): Now static.
2374 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2375 (report_overlay_modification): Rename locals to avoid shadowing.
2377 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2378 Fix pointer signedness issue.
2379 (sys_subshell): Mark local as volatile if checking for lint,
2380 to suppress a gcc -Wclobbered warning that does not seem to be right.
2381 (MAXPATHLEN): Define only if needed.
2383 * process.c (serial_open, serial_configure): Move decls from here ...
2384 * systty.h: ... to here, so that they can be checked.
2386 * fns.c (get_random, seed_random): Move extern decls from here ...
2387 * lisp.h: ... to here, so that they can be checked.
2389 * sysdep.c (reset_io): Now static.
2390 (wait_for_termination_signal): Remove; unused.
2392 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2393 (copy_keymap_item, append_key, push_text_char_description):
2395 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2396 (DENSE_TABLE_SIZE): Remove; unused.
2397 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2398 (describe_map_tree):
2399 Rename locals to avoid shadowing.
2401 * keyboard.c: Declare functions static if they are not used elsewhere.
2402 (echo_char, echo_dash, cmd_error, top_level_2):
2403 (poll_for_input, handle_async_input): Now static.
2404 (read_char, kbd_buffer_get_event, make_lispy_position):
2405 (make_lispy_event, make_lispy_movement, apply_modifiers):
2406 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2407 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2408 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2409 (read_key_sequence, read_char): Mark locals as initialized.
2410 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2412 * keyboard.h (make_ctrl_char): New decl.
2413 (mark_kboards): Move decl here ...
2414 * alloc.c (mark_kboards): ... from here.
2416 * lisp.h (force_auto_save_soon): New decl.
2418 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2419 (DEFINE_DUMMY_FUNCTION): New macro.
2420 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2422 (main): Add casts to avoid warnings
2423 if GCC considers string literals to be constants.
2425 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2427 * dbusbind.c: Pointer signedness fixes.
2428 (xd_signature, xd_append_arg, xd_initialize):
2429 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2430 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2431 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2432 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2434 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2435 if GCC considers string literals to be constants.
2436 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2438 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2440 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2441 (print_preprocess, print_object): New macro to fix last change.
2443 * print.c (print_preprocess): Don't forget font objects.
2445 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2447 * emacs.c (USAGE3): Doc fixes.
2449 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2451 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2454 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2456 * lisp.h (VWindow_system, Qfile_name_history):
2457 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2458 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2459 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2461 * w32select.c: Don't #include "keyboard.h".
2462 (run_protected): Add extern declaration for waiting_for_input.
2464 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2465 * w32console.c (detect_input_pending, read_input_pending)
2466 (encode_terminal_code):
2467 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2468 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2469 (w32_system_caret_y, Qfile_name_history):
2470 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2471 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2472 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2473 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2474 * w32proc.c (Qlocal, report_file_error):
2475 * w32term.c (Vwindow_system, updating_frame):
2476 * w32uniscribe.c (initialized, uniscribe_font_driver):
2477 Remove unneeded extern declarations.
2479 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2481 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2483 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2485 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2486 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2487 These macros can no longer be used for assignment.
2489 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2490 Assign struct members directly, instead of using BUF_BEGV etc.
2491 (record_buffer_markers, fetch_buffer_markers): New functions for
2492 recording and fetching special buffer markers.
2493 (set_buffer_internal_1, set_buffer_temp): Use them.
2495 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2497 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2499 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2500 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2502 * xdisp.c (hscroll_window_tree):
2503 (reconsider_clip_changes): Use PT instead of BUF_PT.
2505 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2507 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2508 $(EMACS_ROOT)/lib/intprops.h.
2510 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2512 Fix more problems found by GCC 4.5.2's static checks.
2514 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2515 to unsigned char * to avoid compiler diagnostic.
2516 (xg_free_frame_widgets): Make it clear that a local variable is
2517 needed only if USE_GTK_TOOLTIP.
2518 (gdk_window_get_screen): Make it clear that this macro is needed
2519 only if USE_GTK_TOOLTIP.
2520 (int_gtk_range_get_value): New function, which avoids a diagnostic
2521 from gcc -Wbad-function-cast.
2522 (xg_set_toolkit_scroll_bar_thumb): Use it.
2523 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2524 diagnostic from gcc -Wbad-function-cast.
2525 (get_utf8_string, xg_get_file_with_chooser):
2526 Rename locals to avoid shadowing.
2527 (create_dialog): Move locals to avoid shadowing.
2529 * xgselect.c (xg_select): Remove unused var.
2531 * image.c (four_corners_best): Mark locals as initialized.
2532 (gif_load): Initialize transparent_p to zero (Bug#8238).
2533 Mark another local as initialized.
2534 (my_png_error, my_error_exit): Mark with NO_RETURN.
2536 * image.c (clear_image_cache): Now static.
2537 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2538 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2539 (x_edge_detection): Remove unnecessary cast that
2540 gcc -Wbad-function-cast diagnoses.
2541 (gif_load): Fix pointer signedness.
2542 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2543 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2545 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2547 Improve quality of tests for time stamp overflow.
2548 For example, without this patch (encode-time 0 0 0 1 1
2549 1152921504606846976) returns the obviously-bogus value (-948597
2550 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2551 reports time overflow. See
2552 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2553 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2554 * editfns.c: Include limits.h and intprops.h.
2555 (TIME_T_MIN, TIME_T_MAX): New macros.
2556 (time_overflow): Move earlier, to before first use.
2557 (hi_time, lo_time): New functions, for an accurate test for
2559 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2560 (Fget_internal_run_time): Don't assume time_t fits in int.
2561 (make_time): Use list2 instead of Fcons twice.
2562 (Fdecode_time): More accurate test for out-of-range times.
2563 (check_tm_member): New function.
2564 (Fencode_time): Use it, to test for out-of-range times.
2565 (lisp_time_argument): Don't rely on undefined left-shift and
2566 right-shift behavior when checking for time stamp overflow.
2568 * editfns.c (time_overflow): New function, refactoring common code.
2569 (Fformat_time_string, Fdecode_time, Fencode_time):
2570 (Fcurrent_time_string): Use it.
2572 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2573 * dired.c (make_time): Move to ...
2574 * editfns.c (make_time): ... here.
2575 * systime.h: Note the move.
2577 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2579 * fringe.c (update_window_fringes): Remove unused variables.
2581 * unexmacosx.c (copy_data_segment): Also copy __got section.
2584 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2586 * termcap.c [MSDOS]: Include "msdos.h".
2587 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2588 Constify `char *' arguments and their references according to
2589 prototypes in tparam.h.
2591 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2593 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2594 Adapt all references accordingly.
2596 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2598 2011-03-11 Tom Tromey <tromey@redhat.com>
2600 * buffer.c (syms_of_buffer): Remove obsolete comment.
2602 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2604 * termhooks.h (encode_terminal_code): Declare prototype.
2606 * msdos.c (encode_terminal_code): Don't declare prototype.
2608 * term.c (encode_terminal_code): Now external again, used by
2609 w32console.c and msdos.c.
2611 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2612 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2614 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2616 Fix some minor problems found by GCC 4.5.2's static checks.
2618 * fringe.c (update_window_fringes): Mark locals as initialized
2620 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2622 * alloc.c (mark_fringe_data): Move decl from here ...
2623 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2624 to check its interface.
2625 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2627 * fontset.c (free_realized_fontset): Now static.
2628 (Fset_fontset_font): Rename local to avoid shadowing.
2629 (fontset_font): Mark local as initialized.
2630 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2632 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2634 * xselect.c (x_disown_buffer_selections): Remove; not used.
2635 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2636 (x_own_selection, Fx_disown_selection_internal): Rename locals
2638 (x_handle_dnd_message): Remove local to avoid shadowing.
2640 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2641 so that the caller can use some name other than gcpro1.
2642 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2643 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2644 (Fx_backspace_delete_keys_p):
2645 Use them to avoid shadowing, and rename vars to avoid shadowing.
2646 (x_decode_color, x_set_name, x_window): Now static.
2647 (Fx_create_frame): Add braces to silence GCC warning.
2648 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2649 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2650 Remove unused locals.
2651 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2652 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2653 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2656 * xterm.h (x_mouse_leave): New decl.
2658 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2659 Remove unused functions.
2660 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2661 (x_calc_absolute_position): Now static.
2662 (XTread_socket): Don't define label "out" unless it's used.
2663 Don't declare local "event" unless it's used.
2664 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2665 unless they are used.
2666 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2667 (x_fatal_error_signal): Remove; not used.
2668 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2669 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2670 (x_error_catcher, x_connection_closed, x_error_handler):
2671 (x_error_quitter, xembed_send_message, x_iconify_frame):
2672 (my_log_handler): Rename locals to avoid shadowing.
2673 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2674 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2676 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2677 Rename or move locals to avoid shadowing.
2678 (tty_defined_color, merge_face_heights): Now static.
2679 (free_realized_faces_for_fontset): Remove; not used.
2680 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2681 does not deduce is never used uninitialized.
2682 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2683 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2685 * terminal.c (store_terminal_param): Now static.
2687 * xmenu.c (menu_highlight_callback): Now static.
2688 (set_frame_menubar): Remove unused local.
2689 (xmenu_show): Rename parameter to avoid shadowing.
2690 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2691 since they might point to immutable storage.
2692 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2693 since it's unused otherwise.
2695 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2696 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2697 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2698 avoids a gcc -Wuninitialized diagnostic.
2699 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2700 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2701 does not deduce are never used uninitialized.
2703 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2705 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2706 * window.c (window_loop, size_window):
2707 (run_window_configuration_change_hook, enlarge_window): Likewise.
2709 * window.c (display_buffer): Now static.
2710 (size_window): Mark variables that gcc -Wuninitialized
2711 does not deduce are never used uninitialized.
2712 * window.h (check_all_windows): New decl, to forestall
2713 gcc -Wmissing-prototypes diagnostic.
2714 * dispextern.h (bidi_dump_cached_states): Likewise.
2716 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2718 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2720 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2721 and to avoid gcc -Wuninitialized warning.
2722 (load_charset_map): Mark variables that gcc -Wuninitialized
2723 does not deduce are never used uninitialized.
2724 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2726 * coding.c (coding_set_source, coding_set_destination):
2727 Use "else { /* comment */ }" rather than "else /* comment */;"
2728 for clarity, and to avoid gcc -Wempty-body warning.
2729 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2730 a block, when the outer 'i' will do.
2731 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2732 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2733 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2734 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2735 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2736 Rename locals to avoid shadowing.
2737 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2738 * coding.c (emacs_mule_char, encode_invocation_designation):
2739 Now static, since they're not used elsewhere.
2740 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2741 (decode_coding_object, encode_coding_object, detect_coding_system):
2742 (decode_coding_emacs_mule): Mark variables that gcc
2743 -Wuninitialized does not deduce are never used uninitialized.
2744 (detect_coding_iso_2022): Initialize a local variable that might
2745 be used uninitialized. Leave a FIXME because it's not clear that
2746 this initialization is needed. (Bug#8211)
2747 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2748 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2749 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2750 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2751 Remove unused macros.
2753 * category.c (hash_get_category_set): Remove unused local var.
2754 (copy_category_table): Now static, since it's not used elsewhere.
2755 * character.c (string_count_byte8): Likewise.
2757 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2758 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2760 * chartab.c (copy_sub_char_table): Now static, since it's not used
2762 (sub_char_table_ref_and_range, char_table_ref_and_range):
2763 Rename locals to avoid shadowing.
2764 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2766 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2767 (BIDI_BOB): Remove unused macro.
2769 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2770 deduce are never used uninitialized.
2771 * term.c (encode_terminal_code): Likewise.
2773 * term.c (encode_terminal_code): Now static. Remove unused local.
2775 * tparam.h: New file.
2776 * term.c, tparam.h: Include it.
2777 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2778 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2779 Move these decls to tparam.h, and make them agree with what
2780 is actually in tparam.c. The previous trick of using incompatible
2781 decls in different modules does not conform to the C standard.
2782 All callers of tparam changed to use tparam's actual API.
2783 * tparam.c (tparam1, tparam, tgoto):
2784 Use const pointers where appropriate.
2786 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2787 * cm.h (struct cm): Likewise.
2788 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2789 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2790 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2791 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2792 (turn_on_face, init_tty): Likewise.
2793 * termchar.h (struct tty_display_info): Likewise.
2795 * term.c (term_mouse_position): Rename local to avoid shadowing.
2797 * alloc.c (mark_ttys): Move decl from here ...
2798 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2800 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2802 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2804 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2806 * search.c (compile_pattern_1): Remove argument regp, unused since
2807 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2808 (compile_pattern): Don't pass it.
2810 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2812 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2813 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2815 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2817 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2819 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2820 gdk_window_get_screen, gdk_window_get_geometry,
2821 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2822 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2823 (xg_get_pixbuf_from_pixmap): New function.
2824 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2825 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2826 Call xg_get_pixbuf_from_pixmap instead of
2827 gdk_pixbuf_get_from_drawable.
2828 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2829 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2830 (xg_check_special_colors): Use GtkStyleContext and its functions
2832 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2833 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2834 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2835 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2836 Call gtk_widget_get_preferred_size.
2837 (xg_frame_resized): gdk_window_get_geometry only takes 5
2839 (xg_win_to_widget, xg_event_is_for_menubar):
2840 Call gdk_x11_window_lookup_for_display.
2841 (xg_set_widget_bg): New function.
2842 (delete_cb): New function.
2843 (xg_create_frame_widgets): Connect delete-event to delete_cb.
2844 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2845 (xg_set_background_color): Call xg_set_widget_bg.
2846 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2847 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2848 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2849 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2851 (update_frame_tool_bar): Call gtk_widget_hide.
2852 (xg_initialize): Use GDK_KEY_g.
2854 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2856 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2858 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2859 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2860 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2862 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2864 * w32xfns.c (select_palette): Check success of RealizePalette against
2865 GDI_ERROR, not zero.
2867 See ChangeLog.11 for earlier changes.
2873 Copyright (C) 2011 Free Software Foundation, Inc.
2875 This file is part of GNU Emacs.
2877 GNU Emacs is free software: you can redistribute it and/or modify
2878 it under the terms of the GNU General Public License as published by
2879 the Free Software Foundation, either version 3 of the License, or
2880 (at your option) any later version.
2882 GNU Emacs is distributed in the hope that it will be useful,
2883 but WITHOUT ANY WARRANTY; without even the implied warranty of
2884 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2885 GNU General Public License for more details.
2887 You should have received a copy of the GNU General Public License
2888 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.