1 2012-07-24 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (init_iterator): Don't compute dimensions of truncation
4 and continuation glyphs on tooltip frames, leave them at zero.
5 Avoids continued lines in tooltips. (Bug#11832)
7 2012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
10 * buffer.c (copy_overlay): Simplify, use build_marker.
11 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
13 2012-07-23 Eli Zaretskii <eliz@gnu.org>
15 * print.c (print_object): Don't crash when a frame's name is nil
16 or invalid. (Bug#12025)
18 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
19 it signals an error when a tooltip frame is being created.
21 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
23 Cleanup miscellaneous objects allocation and initialization.
24 * alloc.c (allocate_misc): Change to static. Add argument to
25 specify the subtype. Adjust comment and users.
26 (build_overlay): New function.
27 * buffer.c (copy_overlays, Fmake_overlay): Use it.
28 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
29 (allocate_misc): Remove prototype.
30 (build_overlay): Add prototype.
32 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
34 Swap buffer text indirection counters in Fbuffer_swap_text.
35 * buffer.c (Fbuffer_swap_text): Swap indirections too.
36 This avoids crash reported by Christoph Scholtes at
37 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
39 2012-07-22 Jan Djärv <jan.h.d@swipnet.se>
41 * nsmenu.m (Popdown_data): New struct.
42 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
44 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
45 (initWithContentRect): Make imgView and contentView non-static
46 and autorelease them. Also autorelease img and matrix (Bug#12005).
47 (dealloc): Remove (Bug#12005).
49 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
51 Adjust consing_since_gc when objects are explicitly freed.
52 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
53 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
54 (free_cons, free_misc): Subtract object size from consing_since_gc.
56 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
58 Simplify and cleanup markers positioning code.
59 * marker.c (attach_marker): More useful eassert.
60 (live_buffer, set_marker_internal): New function.
61 (Fset_marker, set_marker_restricted): Use set_marker_internal.
62 (set_marker_both, set_marker_restricted_both): Use live_buffer.
64 2012-07-22 Paul Eggert <eggert@cs.ucla.edu>
66 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
67 as it's limited by the amount of memory, not by INT_MAX.
69 2012-07-21 Eli Zaretskii <eliz@gnu.org>
71 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
72 in special-event-map. See the discussion at
73 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
76 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
77 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
78 Fabrice Popineau <fabrice.popineau@supelec.fr>.
80 2012-07-21 Jan Djärv <jan.h.d@swipnet.se>
82 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
83 (conversationIdentifier): Return value is NSInteger.
84 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
86 2012-07-21 Chong Yidong <cyd@gnu.org>
88 * window.c (decode_any_window): Signal an error if the window is
89 on a dead frame (Bug#11984).
91 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
93 Add indirection counting to speed up Fkill_buffer.
94 * buffer.h (struct buffer): New member.
95 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
96 (Fmake_indirect_buffer): Set indirection counter to -1, increment
97 base buffer indirection counter.
98 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
99 (Fkill_buffer): Adjust indirection counters as needed, don't walk
100 through buffer list if indirection counter is 0.
102 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
104 Extend the value returned by Fgarbage_collect with heap statistics.
105 * alloc.c (Qheap): New symbol.
106 (syms_of_alloc): DEFSYM it.
107 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
108 (Fmemory_free): Remove.
109 (syms_of_alloc): Don't defsubr it.
110 * buffer.c (Fcompact_buffer): Remove.
111 (syms_of_buffer): Don't defsubr it.
113 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
115 Make maybe_gc inline.
116 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
117 * lisp.h (consing_since_gc, gc_relative_threshold)
118 (memory_full_cons_threshold): Revert declaration.
119 (maybe_gc): Remove prototype, define as inline.
120 * alloc.c: Remove old commented-out code.
121 (consing_since_gc, gc_relative_threshold)
122 (memory_full_cons_threshold): Revert to global.
125 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
127 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
128 * lisp.h (build_unibyte_string): New function.
129 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
130 * sysdep.c, w32fns.c, xfns.c: Use it.
131 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
132 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
133 Adjust users accordingly.
134 * font.h (font_open_by_name): Adjust prototype.
136 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
138 Cleanup calls to Fgarbage_collect.
139 * lisp.h (maybe_gc): New prototype.
140 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
142 * alloc.c (maybe_gc): New function.
143 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
145 * bytecode.c (MAYBE_GC): Use maybe_gc.
146 * eval.c (eval_sub, Ffuncall): Likewise.
147 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
148 to avoid dependency from auto-save feature.
150 2012-07-19 Paul Eggert <eggert@cs.ucla.edu>
152 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
153 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
154 'for_each_per_buffer_object_at'.
155 All uses changed. It's better to use upper-case for macros that
156 cannot be implemented as functions, to give the reader a clue
157 that they're special.
159 2012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
161 * alloc.c (Fgarbage_collect): Tweak docstring.
163 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
165 Tweak the value returned from Fgarbage_collect again.
166 * alloc.c (Fgarbage_collect): New return value, as confirmed in
167 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
168 Adjust documentation.
169 (total_vector_bytes): Rename to total_vector_slots, adjust
171 (total_free_vector_bytes): Rename to total_free_vector_slots,
173 (Qstring_bytes, Qvector_slots): New symbols.
174 (syms_of_alloc): DEFSYM them.
176 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
178 Buffer compaction primitive which may be used from Lisp.
179 * buffer.c (compact_buffer, Fcompact_buffer): New function.
180 (syms_of_buffer): Register Fcompact_buffer.
181 * alloc.c (Fgarbage_collect): Use compact_buffer.
182 * buffer.h (compact_buffer): New prototype.
183 (struct buffer_text): New member.
185 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
187 New macro to iterate over all buffers, miscellaneous cleanups.
188 * lisp.h (all_buffers): Remove declaration.
189 * buffer.h (all_buffers): Add declaration, with comment.
190 (for_each_buffer): New macro.
191 * alloc.c (Fgarbage_collect, mark_object): Use it.
192 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
193 (init_buffer): Likewise.
194 * data.c (Fset_default): Likewise.
195 * coding.c (code_conversion_restore): Remove redundant check
197 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
199 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
201 Fix bug that created negative-length intervals.
202 * intervals.c (merge_interval_right, merge_interval_left):
203 Do not zero out this interval if it is absorbed by its children,
204 as this interval's total length doesn't change in that case. See
205 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
207 2012-07-18 Paul Eggert <eggert@cs.ucla.edu>
209 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
210 when invoking (make-bool-vector N t) and N is a positive
211 multiple of 8 -- the last 8 bits were mistakenly cleared.
213 Remove some struct layout assumptions in bool vectors.
214 * alloc.c (bool_header_size): New constant.
215 (header_size, word_size): Move earlier, as they're now used earlier.
216 Use 'word_size' in a few more places, where it's appropriate.
217 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
218 padding before the data member of a bool vector.
219 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
220 than doing the check by hand with an abort ().
222 2012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
224 * eval.c (Fdefvar): Don't check constants since we only set the var if
225 it's not yet defined anyway (bug#11904).
227 * lisp.h (last_undo_boundary): Declare new var.
228 * keyboard.c (command_loop_1): Set it.
229 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
230 were auto-added by the command loop (bug#11774).
232 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
234 * w32font.c (Qsymbol): Remove local definition.
235 (syms_of_w32font): Don't DEFSYM it.
237 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
239 Fix sweep_vectors to handle large bool vectors correctly.
240 * alloc.c (sweep_vectors): Account total_vector_bytes for
241 bool vectors larger than VBLOCK_BYTES_MAX.
243 2012-07-18 Chong Yidong <cyd@gnu.org>
245 * frame.c (x_set_frame_parameters): Revert bogus change introduced
246 in 2012-05-25 commit by Paul Eggert (Bug#11738).
248 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
250 Return more descriptive data from Fgarbage_collect.
251 Suggested by Stefan Monnier in
252 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
253 * alloc.c (bounded_number): New function.
254 (total_buffers, total_vectors): New variable.
255 (total_string_size): Rename to total_string_bytes, adjust users.
256 (total_vector_size): Rename to total_vector_bytes, adjust users.
257 (sweep_vectors): Account total_vectors and total_vector_bytes.
258 (Fgarbage_collect): New return value. Adjust documentation.
259 (gc_sweep): Account total_buffers.
260 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
261 (VECTOR_SIZE): Remove.
262 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
263 (Qinterval, Qmisc): New symbols.
264 (syms_of_data): Initialize them.
265 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
266 (Qcons, Qbuffer): New declarations.
268 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
270 * alloc.c (Fmemory_free): Account for memory-free's own storage.
271 Round up, not down. Improve doc.
273 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
275 Restore old code in allocate_string_data to avoid Faset breakage.
276 Reported by Julien Danjou <julien@danjou.info> in
277 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
278 * alloc.c (allocate_string_data): Restore old code with minor
279 adjustments, fix comment to explain this subtle issue.
281 2012-07-17 Eli Zaretskii <eliz@gnu.org>
283 Remove FILE_SYSTEM_CASE.
284 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
286 * fileio.c (FILE_SYSTEM_CASE): Don't define.
287 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
288 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
289 call-process-region passes it through expand-file-name.
291 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
293 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
295 Fix crash when creating indirect buffer (Bug#11917)
296 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
297 Don't handle unbound variables specially if non-zero.
298 (Fbuffer_local_variables): Pass zero.
299 (clone_per_buffer_values): Pass non-zero.
301 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
303 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
304 to make the loop interruptible.
306 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
308 * gnutls.c (emacs_gnutls_handshake): Only retry if
309 GNUTLS_E_INTERRUPTED.
311 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
313 Cleanup and convert miscellaneous checks to eassert.
314 * alloc.c (mark_interval): Fix comment, partially rephrase
315 old comment from intervals.h (see below).
316 * intervals.c (find_interval, adjust_intervals_for_insertion)
317 (delete_interval, adjust_intervals_for_deletion)
318 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
320 (adjust_intervals_for_insertion, make_new_interval):
321 Remove obsolete and unused code.
322 * intervals.h (struct interval): Remove obsolete comment.
323 * textprotp.c (erase_properties): Remove unused code.
324 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
325 (Fremove_list_of_text_properties): Convert to eassert.
327 2012-07-17 Chong Yidong <cyd@gnu.org>
329 * editfns.c (Finsert_char): Doc fix.
331 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
333 Fix previous change to make Fmemory_free always accurate.
334 * alloc.c (make_interval): Update total_free_intervals.
335 (make_float): Likewise for total_free_floats.
336 (free_cons, Fcons): Likewise for total_free_conses.
337 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
338 Likewise for total_free_vector_bytes.
339 (Fmake_symbol): Likewise for total_free_symbols.
340 (bytes_free): Remove.
342 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
344 Simple free memory accounting feature.
345 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
346 (sweep_vectors): Accumulate size of free vectors.
347 (Fgarbage_collect): Setup bytes_free.
348 (Fmemory_free): New function.
349 (syms_of_alloc): Register it.
351 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
353 Cleanup overlays checking.
354 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
355 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
356 eassert and OVERLAYP.
357 (sort_overlays): Change to use OVERLAYP.
359 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
361 * editfns.c (Finsert_char): Make it interactive, and make the
362 second arg optional. Copy interactive spec and docstring from
365 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
367 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
368 Unlike the other wrapped functions, fabs has an unspecified
371 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
373 * nsterm.m (keyDown): Interpret flags without left/right bits
374 as the left key (Bug#11670).
376 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
378 Remove empty and useless init functions.
379 * lisp.h (init_character_once, init_fns, init_image)
380 (init_filelock, init_sound): Remove prototype.
381 * character.c (init_character_once): Remove.
382 * filelock.c (init_filelock): Likewise.
383 * fns.c (init_fns): Likewise.
384 * image.c (init_image): Likewise.
385 * sound.c (init_sound): Likewise.
386 * emacs.c (main): Adjust accordingly.
388 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
390 * gtkutil.h: Tiny cleanups.
391 (use_old_gtk_file_dialog): Remove useless declaration.
392 (xg_uses_old_file_dialog): Add suggested const attribute.
394 2012-07-15 Eli Zaretskii <eliz@gnu.org>
396 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
397 (bidi_paragraph_init): Use it to limit search forward for a strong
398 directional character in abnormally large paragraphs full of
399 neutral or weak characters. (Bug#11943)
401 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
403 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
404 the toolbar (Bug#9451).
405 (xg_make_tool_item): Give the widget event box a transparent
408 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
410 Cleanup basic allocation variables and functions.
411 * alloc.c (ignore_warnings, init_intervals, init_float)
412 (init_cons, init_symbol, init_marker): Remove.
413 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
414 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
415 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
416 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
417 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
418 (staticidx, init_alloc_once, init_strings, free_ablock):
419 Remove redundant initialization.
420 * fns.c (init_weak_hash_tables): Remove.
421 * lisp.h (init_weak_hash_tables): Remove prototype.
423 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
425 Use zero_vector where appropriate.
426 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
428 * lisp.h (zero_vector): New declaration.
429 * font.c (null_vector): Remove.
430 (syms_of_font): Remove initialization and staticpro.
431 (font_list_entities, font_find_for_lface): Change to use zero_vector.
432 * keymap.c (Faccessible_keymaps): Likewise.
434 2012-07-15 Leo Liu <sdl.web@gmail.com>
436 * fringe.c: Fix typo in comments.
438 2012-07-14 Leo Liu <sdl.web@gmail.com>
440 * fringe.c: Add a new bitmap exclamation-mark.
442 2012-07-14 Eli Zaretskii <eliz@gnu.org>
444 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
446 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
447 (HAVE_MENUS): Don't define, defined by editing config.in with
449 (GMALLOC_INHIBIT_VALLOC): Don't define.
450 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
452 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
454 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
456 2012-07-14 Glenn Morris <rgm@gnu.org>
458 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
459 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
460 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
462 2012-07-13 Glenn Morris <rgm@gnu.org>
464 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
466 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
467 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
469 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
471 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
472 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
473 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
474 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
476 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
477 as boolean expression.
478 (x_set_window_size): Remove unused variable toolbar.
479 (ns_get_color_default, ns_mod_to_lisp): Remove.
480 (ns_mouse_position): Remove unused variables xchar and ychar.
481 (ns_compute_glyph_string_overhangs): Remove unused variable face.
482 (ns_set_vertical_scroll_bar): Remove unused variable count.
483 (ns_delete_terminal): Remove unused variable i.
484 (ns_term_init): Remove unused variables r, g and b.
485 (mouseDown): Remove unused variable window.
486 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
487 (initFrameFromEmacs): Remove unused variable vbextra.
488 (mouseEntered): Remove unused variables p and dpyinfo.
489 (mouseExited): Remove unused variables p and r.
490 (ns_define_frame_cursor, ns_clear_frame_area)
491 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
492 (menuDown): Assign [sender tag] to variable and cast the variable.
494 * nsterm.h (menuDown): Add id as type to argument sender.
495 (ns_display_info_for_name): Add Lisp_Object argument.
496 (ns_term_init): Add Lisp_Object argument.
497 (ns_map_event_to_object): Add void argument.
498 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
499 prototype with arguments and only declare if __OBJC__.
500 (nxatoms_of_nsselect): Add void argument.
501 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
502 (ns_alloc_autorelease_pool): Add void argument.
503 (ns_release_autorelease_pool): Add void* argument.
504 (ns_get_defaults_value): Add const char* argument.
506 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
507 (initFromContents): Use SSDATA where appropriate.
508 (ns_update_menubar): Add braces to ambigous if-else.
509 (initWithTitle): Put () around assignment in if statement.
510 (ns_menu_show): Remove unused variables window and keymap.
511 (update_frame_tool_bar): Remove unused variable selected_p.
512 (initWithContentRect): Remove unused variable this_cmd_name.
514 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
516 (setXBMColor): Remove unused variable len.
517 (setPixmapData): Put () around assignment in loop statement.
519 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
520 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
522 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
523 around assignment in loop statement.
524 (nsfont_open): Remove unused variable i.
525 (nsfont_open): Remove unused variable len.
526 (nsfont_draw): Remove unused variable cs.
528 * nsfns.m (x_set_icon_name, ns_set_name_internal)
529 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
530 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
531 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
532 (Fns_font_name, Fns_perform_service)
533 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
534 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
535 (ns_set_name): Remove unused variable view.
536 (x_set_menu_bar_lines): Remove unused variable olines.
537 (x_set_tool_bar_lines): Remove unused variable root_window.
538 (Fns_list_colors): Put () around assignment in while statement.
539 (Fns_perform_service): Remove unused variable len.
540 (Fns_display_usable_bounds): Remove unused variable top.
541 (syms_of_nsfns): Remove unused variable i.
543 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
546 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
548 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
549 and free it with DestroyExceptionInfo (Bug#11558).
551 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
553 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
554 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
555 Set here, not in nt/config.nt.
557 2012-07-13 Eli Zaretskii <eliz@gnu.org>
559 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
560 cursor overflow into the last glyph on display line when the right
561 fringe is off. (Bug#11832)
563 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
565 * xdisp.c (produce_special_glyphs): Now static.
566 * dispextern.h (produce_special_glyphs): Remove decl.
568 2012-07-13 Glenn Morris <rgm@gnu.org>
570 * s/bsd-common, s/cygwin.h: Remove empty files.
571 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
573 * s/usg5-4-common.h (USG, USG5):
574 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
575 * s/sol2-6.h (SOLARIS2):
576 * s/irix6-5.h (IRIX6_5):
577 * s/hpux10-20.h (USG, USG5, HPUX):
578 * s/gnu-linux.h (USG, GNU_LINUX):
579 * s/freebsd.h (BSD_SYSTEM):
580 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
581 * s/cygwin.h (CYGWIN):
582 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
583 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
585 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
587 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
589 2012-07-13 Glenn Morris <rgm@gnu.org>
591 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
593 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
595 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
596 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
598 2012-07-12 Glenn Morris <rgm@gnu.org>
600 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
602 * process.c (init_process_emacs): Rename from init_process.
603 The old name is also the name of a Mach system call.
604 * lisp.h, emacs.c: Update for this name change.
605 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
608 2012-07-12 Eli Zaretskii <eliz@gnu.org>
610 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
611 memmove call that removes glyphs covered by the left truncation
612 glyph. Improve commentary.
613 (display_line): Fix display of continuation glyphs on GUI frames
614 when the right fringe is turned off and variable-size fonts are
615 used in the window. Move the code that appends a stretch glyph to
616 produce_special_glyphs, so that it could be used for truncation
617 and continuation glyphs alike.
618 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
619 glyph of a suitably computed width, to align the special glyphs at
620 the window margin. Code moved from display_line. (Bug#11832)
622 2012-07-12 Glenn Morris <rgm@gnu.org>
624 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
626 * s/gnu-linux.h, s/hpux10-20.h:
627 Do not unconditionally define HAVE_XRMSETDATABASE.
629 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
631 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
633 Fix typos that broke OS X build.
634 Reported by Randal L. Schwartz in
635 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
636 * nsterm.m (ns_timeout): Add missing local decl.
637 (ns_get_color): snprintf -> sprintf, to fix typo.
639 2012-07-12 Glenn Morris <rgm@gnu.org>
641 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
642 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
643 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
644 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
646 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
647 Move PTY_OPEN to configure.
649 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
650 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
651 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
653 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
655 Use empty_unibyte_string where applicable.
656 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
657 * lread.c (read1): Likewise.
658 * xsettings.c (syms_of_xsettings): Likewise.
660 2012-07-12 Glenn Morris <rgm@gnu.org>
662 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
663 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
664 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
665 * s/hpux10-20.h (RUN_TIME_REMAP):
666 * s/bsd-common.h (TABDLY): Move to configure.
668 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
670 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
672 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
673 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
675 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
677 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
678 * s/template.h: Move NARROWPROTO to configure.
680 2012-07-11 Glenn Morris <rgm@gnu.org>
682 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
683 unused since 2011-01-17 change to systty.h.
685 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
686 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
687 Move HAVE_PTYS and HAVE_SOCKETS to configure.
689 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
691 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
693 2012-07-11 Glenn Morris <rgm@gnu.org>
695 * s/darwin.h, s/gnu-linux.h, s/template.h:
696 Move INTERRUPT_INPUT to configure.
698 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
700 Minor adjustments to interning code.
701 * lisp.h (intern, intern_c_string): Redefine as static inline
702 wrappers for intern_1 and intern_c_string_1, respectively.
703 (intern_1, intern_c_string_1): Rename prototypes.
704 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
706 * font.c (font_intern_prop): Likewise. Adjust comment.
707 * w32font.c (intern_font_name): Likewise.
709 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
711 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
713 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
714 of Fcar/Fcdr if possible.
715 * font.c (check_otf_features): Likewise.
716 * fontset.c (Fnew_fontset): Likewise.
717 * gnutls.c (Fgnutls_boot): Likewise.
718 * minibuf.c (read_minibuf): Likewise.
719 * msdos.c (IT_set_frame_parameters): Likewise.
720 * xmenu.c (Fx_popup_dialog): Likewise.
721 * w32menu.c (Fx_popup_dialog): Likewise.
723 2012-07-11 Glenn Morris <rgm@gnu.org>
725 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
726 since nothing has defined it on these platforms.
728 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
729 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
731 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
732 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
733 Move CLASH_DETECTION to configure.
735 * s/gnu.h: Remove file, which is now empty.
737 * s/gnu.h, s/gnu-linux.h:
738 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
740 2012-07-11 John Wiegley <johnw@newartisans.com>
742 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
743 function attribute, so we only use it if it exists in the
746 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
748 Avoid call to strlen in fast_c_string_match_ignore_case.
749 * search.c (fast_c_string_match_ignore_case): Change to use
750 length argument. Adjust users accordingly.
751 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
753 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
756 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
757 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
760 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
763 * s/hpux10-20.h (HAVE_PERROR): Remove.
764 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
765 Remove dummy definition, as this problem was obsolete long ago.
768 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
770 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
772 Avoid calls to strlen in font processing functions.
773 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
774 (font_open_by_name): Change to use length argument. Adjust
776 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
778 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
779 Change to return ptrdiff_t.
780 (xfont_list_pattern, xfont_match): Use length returned by
781 xfont_decode_coding_xlfd.
782 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
784 2012-07-11 Glenn Morris <rgm@gnu.org>
786 * s/darwin.h, s/freebsd.h, s/netbsd.h:
787 Move DONT_REOPEN_PTY to configure.
789 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
790 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
792 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
794 Remove "#define unix" that is no longer needed (Bug#11905).
795 * s/aix4-2.h (unix): Remove; no longer needed.
797 EMACS_TIME simplification (Bug#11875).
798 This replaces macros (which typically do not work in GDB)
799 with functions, typedefs and enums, making the code easier to debug.
800 The functional style also makes code easier to read and maintain.
801 * systime.h: Include <sys/time.h> on all hosts, not just if
802 WINDOWSNT, since 'struct timeval' is needed in general.
803 (EMACS_TIME): Now a typedef, not a macro.
804 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
806 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
807 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
808 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
809 (EMACS_TIME_LE): Now functions, not macros.
810 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
811 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
812 which are not functions. All uses rewritten to use:
813 (make_emacs_time): New function.
814 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
815 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
816 not functions. All uses rewritten to use the following, respectively:
817 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
818 (add_emacs_time, sub_emacs_time): New functions.
819 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
820 * fileio.c (Fcopy_file):
821 * xterm.c (XTflash): Get the current time closer to when it's used.
822 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
824 * bytecode.c (targets): Suppress -Woverride-init warnings.
826 Simplify by avoiding confusing use of strncpy etc.
827 * doc.c (Fsnarf_documentation):
828 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
829 * frame.c (Fmake_terminal_frame):
830 * gtkutil.c (get_utf8_string):
832 * nsmenu.m (ns_update_menubar):
833 * regex.c (regerror):
834 Prefer memcpy to strncpy and strncat when either will do.
835 * fileio.c (Fsubstitute_in_file_name):
836 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
837 (menu_separator_name_p):
838 * nsmenu.m (ns_update_menubar):
839 Prefer memcmp to strncmp when either will do.
840 * nsterm.m: Include <ftoastr.h>.
842 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
843 Prefer snprintf to strncpy.
844 * nsterm.m (ns_term_init):
845 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
846 * nsterm.m (ns_term_init):
847 Avoid the need for strncpy, by using build_string or
848 make_unibyte_string directly. Use dtoastr, not snprintf.
849 * process.c (Fmake_network_process): Diagnose service names that
850 are too long, rather than silently truncating them or creating
851 non-null-terminated names.
852 (Fnetwork_interface_info): Likewise, for interface names.
853 * sysdep.c (system_process_attributes) [GNU_LINUX]:
854 Prefer sprintf to strncat.
855 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
856 Prefer vsnprintf to vsprintf + strncpy.
858 2012-07-10 Glenn Morris <rgm@gnu.org>
860 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
861 Clarify fallback case.
863 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
865 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
866 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
867 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
868 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
869 where argument type is known to be a Lisp_Cons.
871 2012-07-10 Tom Tromey <tromey@redhat.com>
873 * bytecode.c (BYTE_CODE_THREADED): New macro.
874 (BYTE_CODES): New macro. Replaces all old byte-code defines.
875 (enum byte_code_op): New type.
876 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
877 (exec_byte_code): Use them. Use token threading when applicable.
879 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
881 Optimize pure C strings initialization.
882 * lisp.h (make_pure_string): Fix prototype.
883 (build_pure_c_string): New function, defined as static inline. This
884 provides a better opportunity to optimize away calls to strlen when
885 the function is called with compile-time constant argument.
886 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
887 argument, adjust users accordingly. Use build_pure_c_string where
889 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
890 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
891 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
893 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
895 Avoid calls to strlen in miscellaneous functions.
896 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
897 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
898 * lread.c (openp): Likewise.
900 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
902 Avoid calls to strlen in path processing functions.
903 * fileio.c (file_name_as_directory): Add comment. Change to add
904 srclen argument and return the length of result. Adjust users
906 (directory_file_name): Fix comment. Change to add srclen argument,
907 swap 1st and 2nd arguments to obey the common convention. Adjust
909 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
911 2012-07-10 Glenn Morris <rgm@gnu.org>
913 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
914 Move PENDING_OUTPUT_COUNT definition to configure.
916 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
917 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
918 * s/gnu.h (DATA_START): Move definitions to configure.
920 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
921 We include usg5-4-common.h, which defines them both.
923 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
924 O_RDONLY already includes it).
926 Stop ns builds setting the EMACSLOADPATH environment variable.
927 * nsterm.m (ns_load_path): Rename from ns_init_paths.
928 Now it does not set EMACSLOADPATH, just returns the load-path string.
929 * nsterm.h: Update accordingly.
930 * lread.c [HAVE_NS]: Include nsterm.h.
931 (init_lread) [HAVE_NS]: Use ns_load_path.
932 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
934 2012-07-09 Glenn Morris <rgm@gnu.org>
936 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
937 since the included bsd-common.h does so.
939 Stop ns builds setting the EMACSPATH environment variable.
940 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
941 (ns_init_paths): Do not set EMACSPATH.
942 * nsterm.h (ns_exec_path): Add it.
943 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
946 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
948 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
950 * process.c (wait_reading_process_output): 'waitchannels' was unset
951 when read_kbd || !NILP (wait_for_cell); fix this.
953 Add GCC-style 'const' attribute to functions that can use it.
954 * character.h (char_resolve_modifier_mask):
955 * keyboard.h (make_ctrl_char):
956 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
957 (init_character_once, next_almost_prime, init_fns, init_image)
958 (flush_pending_output, init_sound):
959 * mem-limits.h (start_of_data):
960 * menu.h (finish_menu_items):
962 * emacs.c (DEFINE_DUMMY_FUNCTION):
963 Declare the dummy function with ATTRIBUTE_CONST.
964 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
965 Add decls with ATTRIBUTE_CONST.
967 Minor improvements to make_formatted_string.
968 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
969 where int is good enough, as vsprintf returns an int.
970 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
972 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
974 Use make_formatted_string to avoid double length calculation.
975 * lisp.h (make_formatted_string): New prototype.
976 * alloc.c (make_formatted_string): New function.
977 * buffer.c (Fgenerate_new_buffer_name): Use it.
978 * dbus.c (syms_of_dbusbind): Likewise.
979 * editfns.c (Fcurrent_time_zone): Likewise.
980 * filelock.c (get_boot_time): Likewise.
981 * frame.c (make_terminal_frame, set_term_frame_name)
982 (x_report_frame_params): Likewise.
983 * image.c (gs_load): Likewise.
984 * minibuf.c (get_minibuffer): Likewise.
985 * msdos.c (dos_set_window_size): Likewise.
986 * process.c (make_process): Likewise.
987 * xdisp.c (ensure_echo_area_buffers): Likewise.
988 * xsettings.c (apply_xft_settings): Likewise.
990 2012-07-09 Glenn Morris <rgm@gnu.org>
992 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
993 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
994 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
995 * nsterm.h (ns_etc_directory): Add it.
996 * callproc.c [HAVE_NS]: Include nsterm.h.
997 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
999 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1001 Move marker debugging code under MARKER_DEBUG.
1002 * marker.c (MARKER_DEBUG): Move marker debugging code under
1003 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1004 for bootstrap with --enable-checking (~3x slowdown reported
1005 by Juanma Barranquero <lekktu@gmail.com>).
1006 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1008 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1010 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1011 See <http://bugs.gnu.org/11825#29>.
1013 2012-07-08 Eli Zaretskii <eliz@gnu.org>
1015 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1016 has no font, use the frame's font. (Bug#11813)
1017 (display_line): Add commentary about displaying truncation glyphs
1019 (produce_special_glyphs): Move here from term.c.
1021 * term.c (produce_special_glyphs): Move to xdisp.c.
1023 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1026 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1028 * xdisp.c (display_line): Avoid warning about implicit declaration
1031 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1033 * lisp.h: Remove empty conditional.
1035 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1037 * lread.c (load_path_check): Now static.
1039 Fix some minor --with-ns problems found by static checking.
1040 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1041 (x_set_font) [!HAVE_X_WINDOWS]:
1042 * image.c (xpm_load_image) [HAVE_NS]:
1043 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1044 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1045 Remove unused local.
1046 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1047 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1048 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1049 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1050 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1051 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1052 Fix pointer signedness problem.
1053 * xfaces.c (FRAME_X_FONT_TABLE):
1054 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1056 2012-07-07 Glenn Morris <rgm@gnu.org>
1058 * lread.c (load_path_check): New function, split from init_lread.
1059 (init_lread): Reorganize. Motivation:
1060 If EMACSLOADPATH is set, check/warn about that rather than the
1061 defaults, which we are not going to use. Hence we can remove
1062 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1063 Don't warn if site-lisp directories are missing.
1064 If not installed, start from a blank load-path, since
1065 PATH_LOADSEARCH refers to the eventual installation directories.
1067 2012-07-07 Eli Zaretskii <eliz@gnu.org>
1069 Support truncation and continuation glyphs on GUI frames, when
1070 fringes are disabled. (Bug#11832)
1071 * xdisp.c (init_iterator): Get dimensions of truncation and
1072 continuation glyphs even if on GUI frames. Adjust
1073 it->last_visible_x on GUI frames when the left or right fringes,
1074 or both, are absent.
1075 (start_display, move_it_in_display_line_to): Handle the case of a
1076 GUI frame without a fringe to display continuation or truncation
1078 (insert_left_trunc_glyphs): Support GUI frames: make sure
1079 truncation glyphs overwrite enough glyphs from the current line to
1080 have sufficient space in pixels.
1081 (display_line): Support truncation and continuation glyphs on GUI
1082 frames. If some spare pixels are left on the line after inserting
1083 the truncation glyphs, fill that space with a stretch glyph of a
1084 suitably computed width.
1086 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1087 produce_glyphs, to support GUI sessions.
1089 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1091 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1093 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1095 Do not require float-time's arg to fit in time_t (Bug#11825).
1096 This works better on hosts where time_t is unsigned, and where
1097 float-time is applied to the (negative) difference between two times.
1098 * editfns.c (decode_time_components): Last arg is now double *,
1099 not int *, and means to store all the result as a double, without
1100 worrying about whether the seconds part fits in time_t.
1101 All callers changed.
1102 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1103 All callers changed.
1104 (Ffloat_time): Do not fail merely because the specified time falls
1105 outside of time_t range.
1107 2012-07-07 Glenn Morris <rgm@gnu.org>
1109 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1110 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1111 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1113 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
1115 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1116 Update dependencies.
1118 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1120 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1122 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1123 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1124 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1125 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1126 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1127 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1129 * xfont.c (compare_font_names): Redo to omit the need for casts.
1131 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1133 * xfns.c (Fx_change_window_property): Doc fix.
1134 * w32fns.c (Fx_change_window_property): Doc fix.
1136 * w32fns.c (Fx_window_property): Accept the same arguments as the
1137 X Windows version. Doc fix.
1138 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1140 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
1141 Eli Zaretskii <eliz@gnu.org>
1143 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1144 Windows-specific code from nt/config.nt moved here.
1145 Obsolete settings removed.
1147 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1149 * process.c: Avoid unnecessary calls to gettime.
1150 (wait_reading_process_output): Don't get the time of day
1151 when gobbling data immediately and not waiting, as there's no need
1152 for it in that case. This removes a FIXME.
1154 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1156 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1157 is defined (Bug#11768).
1159 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1161 Fix marker debugging code.
1162 * marker.c (byte_char_debug_check): Do not perform the check
1163 if buffer is not multibyte.
1164 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1165 Call byte_char_debug_check with correct arguments.
1167 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1169 Compile marker debugging code only if ENABLE_CHECKING is defined.
1170 * marker.c (byte_char_debug_check, count_markers):
1171 Use only if ENABLE_CHECKING is defined.
1172 (byte_debug_flag): Remove.
1173 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1174 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1176 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1178 Avoid code repetition in marker-related functions.
1179 * marker.c (attach_marker): New function.
1180 (Fset_marker, set_marker_restricted, set_marker_both)
1181 (set_marker_restricted_both): Use it.
1182 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1183 Consistently rename charno to charpos.
1184 (marker_position): Add eassert.
1185 (marker_byte_position): Convert to eassert.
1187 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1189 Simplify list operations in unchain_overlay and unchain_marker.
1190 * buffer.c (unchain_overlay): Simplify. Add comment.
1191 * marker.c (unchain_marker): Simplify. Fix comments.
1193 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1195 Introduce fast path for the widely used marker operation.
1196 * alloc.c (build_marker): New function.
1197 * lisp.h (build_marker): New prototype.
1198 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1199 * composite.c (autocmp_chars): Likewise.
1200 * editfns.c (buildmark): Remove.
1201 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1202 (save_restriction_save): Use build_marker.
1203 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1204 * window.c (save_window_save): Likewise.
1206 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1208 Do not use Fdelete_overlay in delete_all_overlays
1209 to avoid redundant calls to unchain_overlay.
1210 * buffer.c (drop_overlay): New function.
1211 (delete_all_overlays, Fdelete_overlay): Use it.
1212 * minibuf.c (get_minibuffer): Fix comment.
1214 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1216 Port to OpenBSD 5.1 amd64.
1217 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1218 This is needed for OpenBSD, and should be harmless on all BSD systems.
1219 Also, include <sys/sysctl.h>, as it should be available on all
1220 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1221 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1222 use p_pid member, not kp_proc.pid.
1224 2012-07-06 Glenn Morris <rgm@gnu.org>
1226 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1228 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1230 More xmalloc and related cleanup.
1231 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1232 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1233 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1234 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1235 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1236 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1237 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1238 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1239 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1241 Omit needless casts involving void * pointers and allocation.
1242 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1243 as the former is more robust if P's type is changed.
1244 Prefer xzalloc to xmalloc + memset 0.
1245 Simplify malloc-or-realloc to realloc.
1246 Don't worry about xmalloc returning a null pointer.
1247 Prefer xstrdup to xmalloc + strcpy.
1248 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1250 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1251 alloca of a constant.
1253 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1255 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1256 hscroll is larger than the line width. Fixes long and futile
1257 looping inside extend_face_to_end_of_line (on a TTY) producing
1258 glyphs that are not needed and thrown away.
1260 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1262 * marker.c (set_marker_restricted_both): Simplify by using
1265 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1267 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1269 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1271 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1272 not defined (Bug#11768).
1273 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1274 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1275 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1276 followed by gtk_box_set_homogeneous (Bug#11768).
1277 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
1278 (update_theme_scrollbar_width, xg_create_scroll_bar):
1279 Use gtk_scrollbar_new (Bug#11768).
1280 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1281 (is_box_type): New function (Bug#11768).
1282 (xg_tool_item_stale_p): Call is_box_type.
1283 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
1284 with default display (Bug#11768).
1286 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1288 * xdisp.c (window_hscroll_limited): New function.
1289 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1290 coordinates when window's hscroll is set to insanely large
1293 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
1295 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1296 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1298 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1301 * lisp.h (xzalloc): New prototype. Omit needless casts.
1302 * alloc.c (xzalloc): New function. Omit needless casts.
1303 * charset.c: Omit needless casts. Convert all calls to
1304 xmalloc with following memset to xzalloc.
1305 * dispnew.c: Likewise.
1306 * fringe.c: Likewise.
1307 * image.c: Likewise.
1308 * sound.c: Likewise.
1310 * w32fns.c: Likewise.
1311 * w32font.c: Likewise.
1312 * w32term.c: Likewise.
1313 * xfaces.c: Likewise.
1315 * xterm.c: Likewise.
1316 * atimer.c: Omit needless casts.
1317 * buffer.c: Likewise.
1318 * callproc.c: Likewise.
1320 * coding.c: Likewise.
1321 * composite.c: Likewise.
1323 * doprnt.c: Likewise.
1324 * editfns.c: Likewise.
1325 * emacs.c: Likewise.
1327 * filelock.c: Likewise.
1329 * gtkutil.c: Likewise.
1330 * keyboard.c: Likewise.
1332 * lread.c: Likewise.
1333 * minibuf.c: Likewise.
1334 * msdos.c: Likewise.
1335 * print.c: Likewise.
1336 * process.c: Likewise.
1337 * region-cache.c: Likewise.
1338 * search.c: Likewise.
1339 * sysdep.c: Likewise.
1340 * termcap.c: Likewise.
1341 * terminal.c: Likewise.
1342 * tparam.c: Likewise.
1343 * w16select.c: Likewise.
1345 * w32reg.c: Likewise.
1346 * w32select.c: Likewise.
1347 * w32uniscribe.c: Likewise.
1348 * widget.c: Likewise.
1349 * xdisp.c: Likewise.
1350 * xmenu.c: Likewise.
1352 * xselect.c: Likewise.
1354 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1356 * fileio.c (time_error_value): Check the right error number.
1357 Problem reported by Troels Nielsen in
1358 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1360 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1362 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1363 This should be fixed in a better way; see Eli Zaretskii in
1364 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1365 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1367 * fileio.c (time_error_value): Rename from special_mtime.
1368 The old name's problems were noted by Eli Zaretskii in
1369 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1371 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1372 This variable's comment says Emacs needs at least one GDB-visible
1373 symbol of type enum pvec_type, to work around GDB problems.
1374 The symbol's value doesn't matter.
1376 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1377 that causes compilation to fail on pre-C99 compilers.
1379 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
1381 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1382 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1384 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1386 * buffer.c (init_buffer_once): Fix initialization of
1387 headers for buffer_defaults and buffer_local_symbols.
1388 Reported by Juanma Barranquero <lekktu@gmail.com>.
1390 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1392 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1393 * lisp.h (enum pvec_type): Use fewer bits.
1394 (PSEUDOVECTOR_SIZE_BITS): New constant.
1395 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1396 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1397 change in pvec_type.
1398 (PSEUDOVECTOR_TYPEP): New macro.
1399 (TYPED_PSEUDOVECTORP): Use it.
1400 * fns.c (internal_equal): Adapt code to extract pvectype.
1401 * emacs.c (gdb_pvec_type): Update type.
1402 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1403 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1404 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1405 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1406 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1407 abusing vector->header.next.nbytes.
1408 (live_vector_p): Use PVEC_TYPE.
1409 (mark_object): Adapt code to extract pvectype. Use switch.
1411 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1413 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1414 Tighten new eassert a bit.
1416 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1418 Fix compilation with --enable-gcc-warnings and -O1
1420 * doprnt.c (doprnt): Change type of tem to int, initialize
1421 to avoid compiler warning. Add eassert.
1422 * search.c (simple_search): Initialize match_byte to avoid
1423 compiler warning. Add eassert.
1425 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1427 Avoid weird behavior with large horizontal scrolls.
1428 Without this change, for example, large hscroll values would
1429 mess up Emacs's display on Fedora 15 x86, presumably due to
1430 overflows in int calculations in the display code.
1431 Also, if buffers had long lines, Emacs would freeze.
1432 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1433 (set_window_hscroll): New function, containing the old guts of
1434 Fset_window_hscroll. Return the clipped value.
1435 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1436 This avoids the need to check against PTRDIFF_MAX.
1438 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1440 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1442 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1444 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1446 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1447 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1448 since GCC 4.4.6 issues a bogus warning for them.
1450 Fix bugs in file timestamp newness comparisons.
1451 * fileio.c (Ffile_newer_than_file_p):
1452 * lread.c (Fload): Use full timestamp resolution of files,
1453 not just the 1-second resolution, so that files that are only
1454 slightly newer still count as newer.
1455 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1456 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1458 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1460 * fileio.c: Improve handling of file time marker. (Bug#11852)
1461 (special_mtime): New function.
1462 (Finsert_file_contents, Fverify_visited_file_modtime):
1463 Use it to set special mtime values consistently.
1465 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1467 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1468 marker for non-existing file. (Bug#11852)
1470 2012-07-03 Glenn Morris <rgm@gnu.org>
1472 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1473 and did not make it into globals.h).
1475 2012-07-03 Tom Tromey <tromey@redhat.com>
1477 * window.c (Fset_window_margins, Fset_window_fringes)
1478 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1479 * textprop.c (Fprevious_property_change): No longer static.
1480 * syntax.c (Fsyntax_table_p): No longer static.
1481 * process.c (Fget_process, Fprocess_datagram_address): No longer
1483 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1484 * keyboard.c (Fcommand_execute): No longer static.
1486 * insdel.c (Fcombine_after_change_execute): No longer static.
1487 * image.c (Finit_image_library): No longer static.
1488 * fileio.c (Fmake_symbolic_link): No longer static.
1489 * eval.c (Ffetch_bytecode): No longer static.
1490 * editfns.c (Fuser_full_name): No longer static.
1491 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1493 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1495 * dired.c (Ffile_attributes): No longer static.
1496 * composite.c (Fcomposition_get_gstring): No longer static.
1497 * callproc.c (Fgetenv_internal): No longer static.
1499 * ccl.h: Remove EXFUNs.
1500 * buffer.h: Remove EXFUNs.
1501 * dispextern.h: Remove EXFUNs.
1502 * intervals.h: Remove EXFUNs.
1503 * fontset.h: Remove EXFUN.
1504 * font.h: Remove EXFUNs.
1505 * dosfns.c (system_process_attributes): Remove EXFUN.
1506 * keymap.h: Remove EXFUNs.
1507 * lisp.h: Remove EXFUNs.
1508 * w32term.h: Remove EXFUNs.
1509 * window.h: Remove EXFUNs.
1510 * xsettings.h: Remove EXFUN.
1511 * xterm.h: Remove EXFUN.
1513 2012-07-03 Glenn Morris <rgm@gnu.org>
1515 * lisp.h (Frandom): Make it visible to C.
1516 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1517 buffer for invisible buffers. (Bug#1229)
1519 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1521 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1522 values which aren't power of 2.
1523 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1524 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1527 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1529 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1531 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1533 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1535 * alloc.c (allocate_vector_block): Remove redundant
1536 calls to mallopt if DOUG_LEA_MALLOC is defined.
1537 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1538 avoid calls to mallopt if zero_vector is returned.
1540 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1542 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1543 is enabled, avoid dereferencing NULL current_sblock if
1546 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1548 Cleanup basic buffer management.
1549 * buffer.h (struct buffer): Change layout to use generic vector
1550 marking code. Fix some comments. Change type of 'clip_changed'
1551 to bitfield. Remove unused #ifndef old.
1552 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1553 (GET_OVERLAYS_AT): Fix indentation.
1554 (for_each_per_buffer_object_at): New macro.
1555 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1556 (Fbuffer_local_variables): Use it.
1557 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1558 * alloc.c (allocate_buffer): Adjust to match new layout of
1559 struct buffer. Fix comment.
1560 (mark_overlay): New function.
1561 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1562 Lisp area of struct buffer.
1563 (mark_object): Use it. Adjust marking of misc objects
1564 and related comments.
1566 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1568 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1569 wrapper that is not needed because the wrapped code is a no-op (zero
1570 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1571 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1573 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1575 * alloc.c (mark_buffer): Simplify. Remove prototype.
1576 (mark_object): Add comment. Reorganize marking of vector-like
1577 objects. Use CHECK_LIVE for all vector-like objects except buffers
1578 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1579 redundant calls to mark_vectorlike for bool vectors.
1581 2012-06-30 Glenn Morris <rgm@gnu.org>
1583 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1585 * epaths.in (PATH_SITELOADSEARCH): New.
1586 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1587 This is rather than relying on --enable-locallisppath elements
1588 having "site-lisp" in their names. (Bug#10208#25, 11658)
1590 2012-06-30 Eli Zaretskii <eliz@gnu.org>
1592 * w32proc.c (sys_select): Accept and ignore one more argument.
1594 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1596 * sysselect.h [DOS_NT]: Don't include sys/select.h.
1597 (pselect) [!MS_DOS]: Redirect to sys_select.
1599 * sysdep.c: Don't include dos.h and dosfns.h.
1601 * process.c (sys_select):
1602 * msdos.c (sys_select): Accept one more argument and ignore it.
1604 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1605 adapt data types and code to that.
1608 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1609 which clashes with the gnulib function of the same name.
1611 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1613 * font.c (font_style_to_value, font_style_symbolic)
1614 (font_prop_validate_style): Add type checks for values in
1617 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1619 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1622 2012-06-29 Eli Zaretskii <eliz@gnu.org>
1624 * xdisp.c (try_window_id): Undo last change.
1626 * w32.c (getwd): Adjust commentary about startup_dir.
1627 (init_environment): Always call sys_access, even in non-MSVC
1628 builds. Don't chdir to the directory of the Emacs executable.
1629 This undoes code from 1997 which was justified by the need to
1630 "avoid conflicts when removing and renaming directories". But its
1631 downside was that every relative file name was being interpreted
1632 relative to the directory of the Emacs executable, which can never
1633 be TRT. In particular, it broke sys_access when called with
1634 relative file names.
1635 (sys_access): Map GetLastError to errno.
1637 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1639 * window.h (struct window): Change type of 'fringes_outside_margins'
1640 to bitfield. Fix comment. Adjust users accordingly.
1641 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
1643 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1646 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
1648 * gnutls.c (emacs_gnutls_handshake):
1649 Add QUIT to make the loop interruptible.
1651 2012-06-29 Glenn Morris <rgm@gnu.org>
1653 * charset.c (init_charset): Make lack of etc/charsets fatal.
1655 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1657 * editfns.c (region_limit): Fix type mismatch.
1659 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1661 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1662 undefined. Convert from xassert to eassert.
1663 * nsmenu.m: Convert from xassert to eassert.
1664 * nsterm.m: Likewise.
1666 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1668 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1670 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1672 Avoid integer overflow on scroll-left and scroll-right.
1673 * window.c (HSCROLL_MAX): New macro.
1674 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1675 overflow when requested scroll falls outside ptrdiff_t range.
1677 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1679 * window.h (struct window): Change type of 'hscroll',
1680 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1681 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1682 Adjust users accordingly.
1683 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1684 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1685 from EMACS_INT to ptrdiff_t.
1686 (make_window): Omit redundant initialization.
1688 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
1690 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1692 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1694 * window.h (struct window): Change type of 'use_time' and
1695 'sequence_number' from Lisp_Object to int.
1696 * frame.c (make_frame): Adjust users accordingly.
1697 * print.c (print_object): Likewise.
1698 * window.c (select_window, Fwindow_use_time, make_parent_window)
1699 (make_window): Likewise.
1701 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1703 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1704 enabled with --enable-checking=[all,glyphs] configure option.
1705 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1706 adjust comments accordingly.
1707 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1708 undefined, adjust comments accordingly.
1709 * image.c: Likewise.
1710 * scroll.c: Likewise.
1711 * w32fns.c: Likewise.
1712 * w32term.c: Likewise.
1713 * xdisp.c: Likewise.
1714 * xfaces.c: Likewise.
1716 * xterm.c: Likewise.
1718 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1720 Generalize run-time debugging checks.
1721 * dispextern.h (XASSERTS): Remove.
1722 * fontset.c (xassert): Remove.
1723 Convert from xassert to eassert.
1724 * alloc.c: Convert from xassert to eassert.
1726 * dispnew.c: Likewise.
1728 * fringe.c: Likewise.
1729 * ftfont.c: Likewise.
1730 * gtkutil.c: Likewise.
1731 * image.c: Likewise.
1732 * keyboard.c: Likewise.
1734 * process.c: Likewise.
1735 * scroll.c: Likewise.
1736 * sound.c: Likewise.
1738 * w32console.c: Likewise.
1739 * w32fns.c: Likewise.
1740 * w32term.c: Likewise.
1741 * window.c: Likewise.
1742 * xdisp.c: Likewise.
1743 * xfaces.c: Likewise.
1745 * xselect.c: Likewise.
1746 * xterm.c: Likewise.
1748 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1750 * fns.c (maybe_resize_hash_table): Output message when growing the
1753 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1755 * alloc.c (allocate_string_data): Remove dead code.
1756 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1757 avoid GCC warning about unused macro.
1759 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1761 * alloc.c (allocate_string): Omit intervals initialization.
1762 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1763 as in make_pure_string and make_pure_c_string.
1765 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1767 * alloc.c (allocate_string): Fix last change.
1769 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1771 * alloc.c (allocate_string): Remove two redundant calls
1772 to memset, add explicit initialization where appropriate.
1774 2012-06-27 Glenn Morris <rgm@gnu.org>
1776 * lisp.mk (lisp): Remove paths.elc.
1778 2012-06-27 Chong Yidong <cyd@gnu.org>
1780 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1782 2012-06-26 John Wiegley <johnw@newartisans.com>
1784 * unexmacosx.c (copy_data_segment): Add two section names used
1785 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1787 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1788 when building with Clang.
1790 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1792 * eval.c (Fapply): Allow calling it with a single argument.
1794 2012-06-26 Eli Zaretskii <eliz@gnu.org>
1796 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1797 _stricmp and _strnicmp.
1798 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1800 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1802 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1804 (allocate_process): Likewise for new process.
1805 (allocate_terminal): Change to use offsetof.
1806 (allocate_frame): Likewise.
1807 * frame.c (make_frame): Omit redundant initialization.
1808 * window.c (make_parent_window): Use memset.
1809 (make_window): Omit redundant initialization.
1810 * process.c (make_process): Omit redundant initialization.
1811 * terminal.c (create_terminal): Likewise.
1813 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1815 * term.c (delete_tty): Remove redundant call to memset.
1817 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1819 * alloc.c: Remove build_string.
1820 * lisp.h: Define build_string as static inline. This provides
1821 a better opportunity to optimize away calls to strlen when the
1822 function is called with compile-time constant argument.
1823 * image.c (imagemagick_error): Convert to build_string.
1824 * w32proc.c (sys_spawnve): Likewise.
1825 * xterm.c (x_term_init): Likewise.
1827 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1829 Use sprintf return value instead of invoking strlen on result.
1830 In the old days this wasn't portable, since some sprintf
1831 implementations returned char *. But they died out years ago and
1832 Emacs already assumes sprintf returns int.
1833 Similarly for float_to_string.
1834 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1835 * ccl.c (ccl_driver):
1836 * character.c (string_escape_byte8):
1837 * data.c (Fnumber_to_string):
1838 * doprnt.c (doprnt):
1839 * print.c (print_object):
1840 * xdisp.c (message_dolog):
1841 * xfns.c (syms_of_xfns):
1842 Use sprintf or float_to_string result to avoid need to call strlen.
1843 * data.c (Fnumber_to_string):
1844 Use make_unibyte_string, since the string must be ASCII.
1845 * lisp.h, print.c (float_to_string): Now returns int length.
1846 * term.c (produce_glyphless_glyph):
1847 Use sprintf result rather than recomputing it.
1849 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1850 * Makefile.in (ALL_CFLAGS):
1851 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1852 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1854 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1856 * dispextern.h (xstrcasecmp): Define to library function
1857 strcasecmp if available.
1858 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1860 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1862 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1863 Avoid comma operator.
1864 * menu.c (push_submenu_start, push_submenu_end)
1865 (push_left_right_boundary, push_menu_pane): Likewise.
1866 * msdos.c (dos_rawgetc): Likewise.
1868 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1870 * xfns.c (xic_create_fontsetname): Remove redundant calls
1873 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1875 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1876 sprintf already null-terminates its output.
1878 * xfns.c (x_window): Remove redundant cast.
1880 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1882 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1883 `const char *' to `char *' to avoid compiler warning.
1885 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1887 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1888 instead of truncating it to 63 (admittedly a generous limit).
1890 * process.c: Fix spelling and caps in comments.
1892 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1894 * emacs.c (setpgrp): Remove definition, unused.
1895 * sysdep.c (setpgrp): Remove definition, not used in this file.
1897 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
1899 * makefile.w32-in: Update dependencies.
1901 2012-06-24 Eli Zaretskii <eliz@gnu.org>
1903 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1904 (SYSTIME_H): Add nt/inc/sys/time.h.
1906 * systime.h [WINDOWSNT]: Include sys/time.h.
1908 * s/ms-w32.h (struct timespec): Definition moved from
1909 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1911 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1913 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1914 * buffer.h (buffer_slot_type_mismatch):
1915 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1916 * eval.c (unwind_to_catch):
1917 * image.c (my_png_error, my_error_exit):
1918 * keyboard.c (quit_throw_to_read_char, user_error)
1919 (Fexit_recursive_edit, Fabort_recursive_edit):
1920 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1921 (wrong_type_argument, buffer_overflow, __executable_start)
1922 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1923 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1924 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1926 (child_setup) [!DOS_NT]:
1927 * lread.c (end_of_file_error, invalid_syntax):
1928 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1929 * puresize.h (pure_write_error):
1930 * search.c (matcher_overflow):
1931 * sound.c (sound_perror, alsa_sound_perror):
1932 * sysdep.c, syssignal.h (croak):
1933 * term.c (maybe_fatal, vfatal):
1934 * textprop.c (text_read_only):
1935 * undo.c (user_error):
1936 * unexmacosx.c (unexec_error):
1937 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1938 Use _Noreturn rather than NO_RETURN.
1939 No need for separate decl merely because of _Noreturn.
1940 * sound.c (sound_warning, parse_sound):
1941 Remove unnecessary forward decls.
1943 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1945 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1946 * lisp.h (WAIT_READING_MAX): New macro.
1947 * dispnew.c (Fsleep_for, sit_for):
1948 * keyboard.c (kbd_buffer_get_event):
1949 * process.c (Faccept_process_output):
1950 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1951 This improves on the previous patch, which introduced a bug
1952 when time_t is unsigned and as wide as intmax_t.
1953 See <http://bugs.gnu.org/9000#51>.
1955 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1957 * dispnew.c (sit_for, Fsleep_for):
1958 * keyboard.c (kbd_buffer_get_event):
1959 * process.c (Faccept_process_output): Avoid compiler warnings when
1960 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1962 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
1964 * makefile.w32-in: Update dependencies.
1966 * w32.c (ltime): Add return type and declare static.
1967 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1969 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1971 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1972 Privately reported by Herbert J. Skuhra.
1973 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1975 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1976 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1978 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1980 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1981 last argument of make_unibyte_string.
1983 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1984 language ID in the event parameters.
1986 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1987 event.code, not the obscure "character set ID".
1989 2012-06-23 Chong Yidong <cyd@gnu.org>
1991 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1993 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1995 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1996 * w32.c (fdutimens): New function.
1998 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2000 * s/ms-w32.h (pselect): Redirect to sys_select.
2002 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2004 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2005 in the logic of incrementing and decrementing the value of
2006 use_relocatable_buffers.
2008 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2010 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2011 Privately reported by Herbert J. Skuhra.
2012 [__FreeBSD__]: Remove "*/" typo after "#include".
2013 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2014 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2015 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2016 Don't assume EMACS_TIME and struct timeval are the same type.
2018 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2020 Support higher-resolution time stamps (Bug#9000).
2021 The time stamps are only nanosecond-resolution at the C level,
2022 since that's the best that any real-world system supports now.
2023 But they are picosecond-resolution at the Lisp level, as that's
2024 easy, and leaves room for future OS improvements.
2026 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2029 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2030 Don't get current time unless it's needed.
2032 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2033 now provides it if it's absent.
2034 (start_atimer): Port to higher-res time stamps.
2035 Check for time stamp overflow. Don't get current time more
2036 often than is needed.
2038 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2039 Include systime.h, not time.h.
2040 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2042 * dired.c: Include stat-time.h.
2043 (Ffile-attributes): File times now have higher resolution.
2045 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2046 (struct image): Timestamp now has higher resolution.
2048 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2049 has at least microseconds now. All uses removed.
2050 (update_frame, update_single_window, update_window, update_frame_1)
2051 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2053 * editfns.c (time_overflow): Now extern.
2054 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2055 (float-time, Fformat_time_string, Fcurrent_time_string)
2056 (Fcurrent_time_zone): Accept and generate higher-resolution
2058 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2059 (decode_time_components, lisp_seconds_argument): New functions.
2060 (make_time): Now static.
2061 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2062 Report an error if the time is invalid, rather than having the caller
2065 * fileio.c: Include <stat-time.h>
2066 (Fcopy_file): Copy higher-resolution time stamps.
2067 Prefer to set the time stamp via a file descriptor if that works.
2068 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2069 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2070 (Fvisited_file_modtime, Fset_visited_file_modtime):
2071 Support higher-resolution time stamps.
2073 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2075 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2077 * image.c (prepare_image_for_display, clear_image_cache)
2078 (lookup_image): Port to higer-resolution time stamps.
2080 * keyboard.c (start_polling, bind_polling_period):
2081 Check for time stamp overflow.
2082 (read_char, kbd_buffer_get_event, timer_start_idle)
2083 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2084 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2085 Port to higher-resolution time stamps. Do not assume time_t is signed.
2086 (decode_timer): New function. Timers are now vectors of length 9,
2087 not 8, to accommodate the picosecond component.
2088 (timer_check_2): Use it.
2090 * nsterm.m (select_timeout, timeval_subtract): Remove.
2091 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2092 as they're a bit more accurate and handle overflow better.
2093 (ns_select): Change prototype to be compatible with pselect.
2094 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2095 * nsterm.h (ns_select): Adjust prototype.
2097 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2098 us-resolution time stamps.
2099 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2101 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2103 * lisp.h (time_overflow): New decl.
2104 (wait_reading_process_output): First arg is now intmax_t, not int,
2105 to accommodate larger waits.
2107 * process.h (struct Lisp_Process.read_output_delay):
2108 Now counts nanoseconds, not microseconds.
2109 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2111 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2112 (wait_reading_process_output):
2113 Port to ns-resolution time stamps.
2114 (Faccept_process_output, wait_reading_process_output):
2115 Check for time stamp overflow. Do not assume time_t is signed.
2116 (select_wrapper): Remove; we now use pselect.
2117 (Fprocess_attributes): Now generates ns-resolution time stamps.
2119 * sysdep.c: Include utimens.h. Don't include utime.h
2120 or worry about struct utimbuf; gnulib does that for us now.
2121 (gettimeofday): Remove; gnulib provides a substitute.
2122 (make_timeval): New function.
2123 (set_file_times): Now sets ns-resolution time stamps.
2124 New arg FD; all uses changed.
2125 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2126 (system_process_attributes):
2127 Now returns ns-resolution time stamp. All uses changed.
2128 Check for time stamp overflow.
2130 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2131 provides a substitute now.
2133 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2134 since it guarantees struct timespec.
2135 (EMACS_TIME): Now struct timespec, so that we can support
2136 ns-resolution time stamps.
2137 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2138 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2139 (EMACS_USECS): Remove.
2140 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2141 so multiply the arg by 1000 before storing it.
2142 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2144 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2145 Port to ns-resolution time stamps.
2146 (EMACS_TIME_NEG_P): Remove; replaced by....
2147 (EMACS_TIME_SIGN): New macro.
2148 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2149 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2150 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2151 (make_timeval, make_lisp_time, decode_time_components): New decls.
2152 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2153 that it mishandled time_t overflow. You can't compare by subtracting!
2154 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2155 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2157 * term.c: Include <sys/time.h>.
2158 (timeval_to_Time): New function, for proper overflow wraparound.
2159 (term_mouse_position, term_mouse_click): Use it.
2161 * undo.c (record_first_change): Support higher-resolution time stamps
2163 (Fprimitive_undo): Use them when restoring time stamps.
2165 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2166 (w32_get_internal_run_time):
2167 Port to higher-resolution Emacs time stamps.
2168 (ltime): Now accepts single 64-bit integer, as that's more convenient
2171 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2173 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2174 for compatibility with pselect. Support ns-resolution time stamps.
2176 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2178 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2179 Check for time stamp overflow, and support ns-resolution time stamps.
2181 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2182 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2183 (timeval_subtract): Remove; no longer needed.
2184 (XTflash, XTring_bell, x_wait_for_event):
2185 Port to ns-resolution time stamps. Don't assume time_t is signed.
2187 2012-06-22 Chong Yidong <cyd@gnu.org>
2189 * xdisp.c (x_consider_frame_title): Revert last change.
2191 2012-06-22 Eli Zaretskii <eliz@gnu.org>
2193 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2194 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2195 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2196 staticidx goes up to 1597 out of 1600 = 0x640.)
2198 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2200 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2201 Otherwise, the umask might be mistakenly 0 while handling input signals.
2203 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2205 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2207 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2209 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2210 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2211 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2212 access to `contents' member of Lisp_Vector objects with AREF and ASET
2215 2012-06-19 Chong Yidong <cyd@gnu.org>
2217 * frame.c (delete_frame): When selecting a frame on a different
2218 text terminal, do not alter the terminal's top-frame.
2220 * xdisp.c (format_mode_line_unwind_data): Record the target
2221 frame's selected window and its terminal's top-frame.
2222 (unwind_format_mode_line): Restore them.
2223 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2225 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2226 since tty frames can be explicitly named.
2227 (prepare_menu_bars): Likewise.
2229 * term.c (Ftty_top_frame): New function.
2231 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2233 Port byte-code-meter to modern targets.
2234 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2235 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
2236 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
2237 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2238 (METER_1, METER_2): Simplify.
2240 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2242 * data.c (Fdefalias): Return `symbol' (bug#11686).
2244 2012-06-18 Martin Rudalics <rudalics@gmx.at>
2246 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
2247 gets killed during executing of this function (Bug#11665).
2248 Try to always return Qt when the buffer has been actually killed.
2249 (Vkill_buffer_query_functions): In doc-string say that functions
2250 run by this hook should not change the current buffer.
2252 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2254 Fix recently-introduced process.c problems found by static checking.
2255 * process.c (write_queue_push, write_queue_pop, send_process):
2256 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2257 (write_queue_pop): Fix pointer signedness problem.
2258 (send_process): Remove unused local.
2260 2012-06-17 Chong Yidong <cyd@gnu.org>
2262 * xdisp.c (redisplay_internal): No need to redisplay terminal
2263 frames that are not on top.
2265 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
2267 * process.c (make_process): Initialize write_queue.
2268 (write_queue_push, write_queue_pop): New functions.
2269 (send_process): Use them to maintain correct ordering of process
2272 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2274 * lisp.h (eassert): Assume C89 or later.
2275 This removes the need for CHECK.
2276 (CHECK): Remove. Its comments about always evaluating its
2277 argument were confusing, as 'eassert' typically does not evaluate
2280 * coding.c (produce_chars): Use ptrdiff_t, not int.
2282 * xterm.c (x_draw_underwave): Check for integer overflow.
2283 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2285 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
2287 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2288 referenced (Bug#11583).
2290 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2292 Implement wave-style variant of underlining.
2293 * dispextern.h (face_underline_type): New enum.
2294 (face): Add field for underline type.
2295 * nsterm.m (ns_draw_underwave): New function.
2296 (ns_draw_text_decoration): Use it.
2297 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2299 (x_draw_glyph_string): Use them.
2300 * xfaces.c (Qline, Qwave): New Lisp objects.
2301 (check_lface_attrs, merge_face_ref)
2302 (Finternal_set_lisp_face_attribute, realize_x_face):
2303 Handle wave-style underline face attributes.
2304 * xterm.c (x_draw_underwave): New function.
2305 (x_draw_glyph_string): Use it.
2307 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
2309 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2310 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2311 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2312 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2313 ($(BLD)/w32select.$(O)): Update dependencies.
2315 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2317 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2318 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2319 * character.c (_fetch_multibyte_char_p): Remove.
2320 * alloc.c: Include "character.h" before "buffer.h".
2322 * buffer.c: Likewise.
2323 * bytecode.c: Likewise.
2324 * callint.c: Likewise.
2325 * callproc.c: Likewise.
2326 * casefiddle.c: Likewise.
2327 * casetab.c: Likewise.
2328 * category.c: Likewise.
2330 * coding.c: Likewise.
2331 * composite.c: Likewise.
2332 * dired.c: Likewise.
2333 * dispnew.c: Likewise.
2335 * dosfns.c: Likewise.
2336 * editfns.c: Likewise.
2337 * emacs.c: Likewise.
2338 * fileio.c: Likewise.
2339 * filelock.c: Likewise.
2341 * fontset.c: Likewise.
2342 * fringe.c: Likewise.
2343 * indent.c: Likewise.
2344 * insdel.c: Likewise.
2345 * intervals.c: Likewise.
2346 * keyboard.c: Likewise.
2347 * keymap.c: Likewise.
2348 * lread.c: Likewise.
2349 * macros.c: Likewise.
2350 * marker.c: Likewise.
2351 * minibuf.c: Likewise.
2352 * nsfns.m: Likewise.
2353 * nsmenu.m: Likewise.
2354 * print.c: Likewise.
2355 * process.c: Likewise.
2356 * regex.c: Likewise.
2357 * region-cache.c: Likewise.
2358 * search.c: Likewise.
2359 * syntax.c: Likewise.
2361 * textprop.c: Likewise.
2363 * unexsol.c: Likewise.
2364 * w16select.c: Likewise.
2365 * w32fns.c: Likewise.
2366 * w32menu.c: Likewise.
2367 * window.c: Likewise.
2368 * xdisp.c: Likewise.
2370 * xmenu.c: Likewise.
2372 * xselect.c: Likewise.
2374 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2376 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2377 If all the glyphs of the glyph row came from strings, and we have no
2378 cursor positioning clues, put the cursor on the first glyph of the
2380 (handle_face_prop): Use chunk-relative overlay string index when
2381 indexing into it->string_overlays array. (Bug#11653)
2382 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2383 the rightmost. (Bug#11720)
2385 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2387 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2388 (CATEGORY_MEMBER): Enforce 1/0 value.
2389 * category.c (_temp_category_set): Remove.
2391 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2393 * window.c (Fdelete_other_windows_internal)
2394 (Fdelete_window_internal): Don't access frame's mouse highlight
2395 info of the initial frame. (Bug#11677)
2397 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2399 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2400 Assume USE_2_TAGS_FOR_INTS.
2401 (xreload): Adjust $tagmask width to match recent lisp.h change.
2403 Simplify lisp.h in minor ways that should not affect code.
2404 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2405 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2406 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2407 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2408 (INTTYPEBITS): New macro, for clarity.
2409 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
2410 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2411 Simplify now that USE_LSB_TAG is always defined.
2412 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2413 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2415 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
2417 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2419 2012-06-13 Glenn Morris <rgm@gnu.org>
2421 * s/bsd-common.h (BSD4_3):
2422 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2424 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2426 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2429 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2431 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
2432 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
2433 * alloc.c (widen_to_Lisp_Object): Remove.
2434 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2435 * frame.c (delete_frame): Remove outdated comment.
2436 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2437 USE_LISP_UNION_TYPE.
2438 (Fw32_unregister_hot_key): Likewise.
2439 (Fw32_toggle_lock_key): Likewise.
2440 * w32menu.c (add_menu_item): Likewise.
2441 (w32_menu_display_help): Use XIL instead of checking
2442 USE_LISP_UNION_TYPE.
2443 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2444 (init_heap): Likewise.
2445 * w32term.c (w32_read_socket): Update comment.
2447 2012-06-13 Glenn Morris <rgm@gnu.org>
2449 * s/usg5-4-common.h, src/s/unixware.h:
2450 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2452 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2454 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2456 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2457 * alloc.c (make_number) [!defined make_number]:
2458 Remove, as lisp.h always defines this now.
2459 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2460 (roundup_size): Verify that it is a power of 2.
2461 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2462 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2463 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2464 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2465 USE_LSB_TAG now is always defined to be either 0 or 1.
2467 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2468 code works fine either way, and efficiency is not a concern here,
2469 as the union type is for debugging, not for production.
2470 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2471 Use an inline function on all platforms when using the union type,
2472 since this is simpler and 'static inline' can be used portably
2474 (LISP_INITIALLY_ZERO): New macro.
2475 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2476 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2478 2012-06-12 Glenn Morris <rgm@gnu.org>
2480 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2482 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
2484 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2485 Move BROKEN_SIGIO to configure.
2487 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2488 Move NO_TERMIO to configure.
2490 2012-06-12 Chong Yidong <cyd@gnu.org>
2492 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2493 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2494 MagickExportImagePixels is undefined.
2496 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2498 * image.c (imagemagick_load_image): Remove unused label.
2500 2012-06-11 Glenn Morris <rgm@gnu.org>
2502 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2503 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2504 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2505 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2507 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2509 * alloc.c (make_byte_code): New function.
2510 (Fmake_byte_code): Use it. Don't purify here.
2511 * lread.c (read1): Use it as well to avoid extra allocation.
2513 2012-06-11 Chong Yidong <cyd@gnu.org>
2515 * image.c (imagemagick_load_image): Implement transparency.
2517 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2519 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2520 account for preceding backslashes. (Bug#11663)
2522 2012-06-09 Chong Yidong <cyd@gnu.org>
2524 * term.c: Support italics in capable terminals (Bug#9652).
2525 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2526 (turn_on_face): Output using TS_enter_italic_mode if available.
2527 Don't handle unused blinking and alt-charset cases.
2528 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2529 and tty_alt_charset_p cases.
2530 (tty_capable_p, init_tty): Support italics.
2532 * termchar.h (struct tty_display_info): Add field for italics.
2533 Remove unused blink field.
2535 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2538 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2539 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2540 tty_alt_charset_p. Add tty_italic_p.
2542 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
2544 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2545 dbus_type_is_basic if available.
2546 (xd_extract_signed, xd_extract_unsigned): Rename from
2547 extract_signed and extract_unsigned, respectively. Adapt callers.
2549 2012-06-09 Chong Yidong <cyd@gnu.org>
2551 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2553 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2556 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2558 * xdisp.c (vmessage): Treat frame message as multibyte.
2559 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2560 would generate the diagnostic "Making \302\247 buffer-local while
2563 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2565 * dispnew.c (showing_window_margins_p): Undo last change, which
2566 was done due to an inadvertent commit.
2567 (adjust_frame_glyphs_for_frame_redisplay): Do call
2568 showing_window_margins_p.
2570 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2572 * eval.c (Fmake_var_non_special): New primitive.
2573 (syms_of_eval): Defsubr it.
2574 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2576 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
2578 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2579 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2581 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2583 * alloc.c (allocate_vectorlike): Fix last change.
2585 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2587 Block-based vector allocation of small vectors.
2588 * lisp.h (struct vectorlike_header): New field `nbytes',
2589 adjust comment accordingly.
2590 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2591 to denote vector blocks. Adjust users (live_vector_p,
2592 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2593 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2594 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2595 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2596 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2597 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2598 (roundup_size): New constant.
2599 (struct vector_block): New data type.
2600 (vector_blocks, vector_free_lists, zero_vector): New variables.
2601 (all_vectors): Rename to `large_vectors'.
2602 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2603 (sweep_vectors): New functions.
2604 (allocate_vectorlike): Return `zero_vector' as the only vector of
2605 0 items. Allocate new vector from block if vector size is less than
2606 or equal to VBLOCK_BYTES_MAX.
2607 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2608 (init_alloc_once): Add call to init_vectors.
2610 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2612 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2614 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2616 * doprnt.c (doprnt): Truncate multibyte char correctly.
2617 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2618 would mishandle a string argument "Xc" if X was a multibyte
2619 character of length 2: it would truncate after X's first byte
2620 rather than including all of X.
2622 2012-06-06 Chong Yidong <cyd@gnu.org>
2624 * buffer.c (word_wrap): Doc fix.
2626 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2628 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2630 2012-06-03 Glenn Morris <rgm@gnu.org>
2632 * xdisp.c (tool-bar-style): Doc fix.
2634 2012-06-03 Ulrich Müller <ulm@gentoo.org>
2636 * Makefile.in (PAXCTL): Define.
2637 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2638 binary via PaX flags if the paxctl utility is available.
2639 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2640 Restore PaX flags to their default. (Bug#11398)
2642 2012-06-03 Chong Yidong <cyd@gnu.org>
2644 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2647 2012-06-03 Chong Yidong <cyd@gnu.org>
2649 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2650 (note_mode_line_or_margin_highlight): If there is no help echo,
2651 use mode-line-default-help-echo. Handle the case where the mouse
2652 position is past the end of the mode line string.
2654 * buffer.c (buffer_local_value_1): New function, split from
2655 Fbuffer_local_value; can return Qunbound.
2656 (Fbuffer_local_value): Use it.
2657 (Vmode_line_format): Docstring tweaks.
2659 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2661 * sysdep.c (system_process_attributes): Improve comment.
2663 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2665 * keyboard.c: Export real-this-command to Elisp.
2666 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2667 and DEFVAR it. Update all users.
2669 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2671 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2673 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2674 Convert pctcpu and pctmem to Lisp float properly.
2675 Let the compiler fold better, as 100.0/0x8000 is exact.
2677 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2679 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2682 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2684 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2686 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2688 For a 'struct window', replace some Lisp_Object fields to
2689 bitfields where appropriate, remove unused fields.
2690 * window.h (struct window): Remove unused 'last_mark_x' and
2691 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2692 change it's type from Lisp_Object to bitfield.
2693 Change type of 'force_start', 'optional_new_start',
2694 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2695 fields from Lisp_Object to bitfield. Adjust users accordingly.
2697 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2699 Pacify gcc -Wdouble-precision when using Xaw.
2700 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2701 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2702 Use 'float' consistently, rather than 'float' in most places
2703 and 'double' in a couple of places.
2705 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2707 * xdisp.c (handle_stop): Detect whether we have overlay strings
2708 loaded by testing it->current.overlay_string_index to be
2709 non-negative, instead of checking whether n_overlay_strings is
2710 positive. (Bug#11587)
2712 2012-05-31 Chong Yidong <cyd@gnu.org>
2714 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2716 * doc.c (Fsubstitute_command_keys): Doc fix.
2718 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2720 * search.c (search_buffer): Remove calls to
2721 r_alloc_inhibit_buffer_relocation, as it is now called by
2722 maybe_unify_char, which was the cause of relocation of buffer text
2725 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2727 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2728 for the duration of call to load_charset, to avoid problems with
2729 callers of maybe_unify_char that access buffer text through C
2732 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2733 decrement the inhibition flag, instead of just setting or
2736 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2738 Remove obsolete '#define static' cruft.
2739 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2740 This #undef was "temporary" in 2000; it is no longer needed
2741 now that '#define static' has gone away.
2742 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2743 (gray_bitmap_bits): Remove; no longer needed.
2744 All uses replaced with definiens.
2745 * xterm.c: Include "bitmaps/gray.xbm".
2747 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2749 Clean up __executable_start, monstartup when --enable-profiling.
2750 The following changes affect the code only when profiling.
2751 * dispnew.c (__executable_start): Rename from safe_bcopy.
2752 Define only on platforms that need it.
2753 * emacs.c: Include <sys/gmon.h> when profiling.
2754 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2755 (__executable_start): Remove decl, since lisp.h does it now.
2756 (safe_bcopy): Remove decl; no longer has that name.
2757 (main): Coalesce #if into single bit of code, for simplicity.
2758 Cast pointers to uintptr_t, since standard libraries want integers
2760 * lisp.h (__executable_start): New decl.
2762 2012-05-31 Glenn Morris <rgm@gnu.org>
2764 * image.c (Fimagemagick_types): Doc fix.
2766 2012-05-30 Jim Meyering <meyering@redhat.com>
2768 * callproc.c (Fcall_process_region): Include directory component
2769 in mkstemp error message (Bug#11586).
2771 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2773 * alloc.c, lisp.h (make_pure_vector): Now static.
2775 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2777 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2778 Move to byte-run.el.
2779 (Fautoload): Do the hash-doc more carefully.
2780 * data.c (Fdefalias): Purify definition, except for keymaps.
2781 (Qdefun): Move from eval.c.
2782 * lisp.h (Qdefun): Remove.
2783 * lread.c (read1): Tiny simplification.
2785 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
2787 Do not create empty overlays with the evaporate property (Bug#9642).
2788 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2789 Bug#9642, but explicitly check that the buffer the overlay would
2790 be moved to is live and rearrange lines to make sure that errors
2791 will not put the overlay in an inconsistent state.
2792 (Fdelete_overlay): Cosmetics.
2794 2012-05-28 Eli Zaretskii <eliz@gnu.org>
2796 * w32term.c (my_bring_window_to_top): New function.
2797 (x_raise_frame): Use handle returned by DeferWindowPos, which
2798 could be different from the original one.
2799 Call my_bring_window_to_top instead of my_set_foreground_window.
2802 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2803 by calling BringWindowToTop.
2805 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2806 (WM_EMACS_END): Increase by one.
2808 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2810 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2811 This avoids undefined behavior that might cause the eassert
2812 to not catch an out-of-range value.
2814 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
2816 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2817 Update dependencies.
2819 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2821 * bidi.c (bidi_mirror_char): Fix last change.
2823 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2825 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2826 when referring to sectname field in printf format.
2828 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2830 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2831 Only r_alloc_inhibit_buffer_relocation needed to be added;
2832 the others were already declared.
2834 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2835 before checking whether it's out of range. Put the check inside
2837 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2839 2012-05-27 Ken Brown <kbrown@cornell.edu>
2841 * callproc.c (Fcall_process): Restore a line that was accidentally
2842 commented out in the 2011-02-13 change (bug#11547).
2844 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2846 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2847 defined on ralloc.c.
2849 * buffer.c [REL_ALLOC]: Remove prototypes of
2850 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2851 they are now on lisp.h.
2853 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2855 * search.c (search_buffer): Use it to inhibit relocation of buffer
2856 text while re_search_2 is doing its job, because re_search_2 is
2857 passed C pointers to buffer text. (Bug#11519)
2859 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2862 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2863 state after an additional call to move_it_in_display_line_to, keep
2864 the values of it->max_ascent and it->max_descent found for the
2866 (pos_visible_p): Revert the comparison against bottom_y to what it
2867 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2870 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2872 Fix coding-related core dumps with gcc -ftrapv.
2873 The code was computing A - B, where A and B are pointers, and B is
2874 random garbage. This can lead to core dumps on platforms that
2875 have special pointer registers, and it also leads to core dumps on
2876 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2877 A - B only when B is initialized properly.
2878 * coding.c (coding_set_source, coding_set_destination): Return void.
2879 (coding_change_source, coding_change_destinations): New functions,
2880 with the old behaviors of coding_set_source and coding_set_destination.
2881 All callers that need an offset changed to use these new functions.
2883 2012-05-26 Glenn Morris <rgm@gnu.org>
2885 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2887 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2889 Extend mouse support on W32 text-mode console.
2890 * xdisp.c (draw_row_with_mouse_face):
2891 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
2893 * w32console.c: Include window.h.
2894 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2896 (initialize_w32_display): Initialize mouse-highlight data.
2898 * w32inevt.c: Include termchar.h and window.h.
2899 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2900 moves, call note_mouse_highlight. If help_echo changed, call
2901 gen_help_event to produce help-echo message in the echo area.
2902 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2905 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2907 * lread.c (read1): Simplify slightly to avoid an overflow warning
2908 with GCC 4.7.0 on x86-64.
2910 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2912 * bidi.c (bidi_mirror_char): Revert last change: an int is
2913 definitely wide enough here.
2915 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
2917 Fix integer width and related bugs (Bug#9874).
2918 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
2919 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2920 (string_bytes, check_sblock, allocate_string_data):
2921 (compact_small_strings, Fmake_bool_vector, make_string)
2922 (make_unibyte_string, make_multibyte_string)
2923 (make_string_from_bytes, make_specified_string)
2924 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2925 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2928 (allocate_pseudovector):
2929 Use int, not EMACS_INT, where int is wide enough.
2930 (inhibit_garbage_collection, Fgarbage_collect):
2931 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2932 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2933 int might not be wide enough.
2934 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2935 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2936 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2937 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2938 (bidi_level_of_next_char, bidi_move_to_visually_next):
2939 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2940 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2941 (Fkill_buffer, Fset_buffer_major_mode)
2942 (advance_to_char_boundary, Fbuffer_swap_text)
2943 (Fset_buffer_multibyte, overlays_at, overlays_in)
2944 (overlay_touches_p, struct sortvec, record_overlay_string)
2945 (overlay_strings, recenter_overlay_lists)
2946 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2947 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2948 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2949 (Foverlay_recenter, last_overlay_modification_hooks_used)
2950 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2951 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2952 (validate_region): Omit unnecessary test for b <= e,
2953 since that's guaranteed by the previous test.
2954 (adjust_overlays_for_delete): Avoid pos + length overflow.
2955 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2956 (report_overlay_modification):
2957 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2958 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2959 Omit pointer cast, which isn't needed anyway, and doesn't work
2960 after the EMACS_INT -> ptrdiff_t change.
2961 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
2962 * buffer.h: Adjust decls to match defn changes elsewhere.
2963 (struct buffer_text, struct buffer):
2964 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2965 Use EMACS_INT, not int, where int might not be wide enough.
2966 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2967 not int, to avoid needless 32-bit limit on 64-bit hosts.
2968 (exec_byte_code): Use tighter memory-full test, one that checks
2969 for alloca overflow. Don't compute the address of the object just
2970 before an array, as that's not portable. Use EMACS_INT, not
2971 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
2972 * callint.c (Fcall_interactively):
2973 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2974 * callproc.c (call_process_kill, Fcall_process):
2975 Don't assume pid_t fits into an Emacs fixnum.
2976 (call_process_cleanup, Fcall_process, child_setup):
2977 Don't assume pid_t fits into int.
2978 (call_process_cleanup, Fcall_process, delete_temp_file)
2979 (Fcall_process_region):
2980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2981 (Fcall_process): Simplify handling of volatile integers.
2982 Use int, not EMACS_INT, where int will do.
2983 * casefiddle.c (casify_object, casify_region, operate_on_word)
2984 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2985 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2986 (casify_object): Avoid integer overflow when overallocating buffer.
2987 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
2988 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
2989 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2990 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2991 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2992 integers are now checked earlier. All uses replaced with XINT.
2994 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2995 For CCL_MapSingle, check that content and value are in int range.
2996 (ccl_driver, Fregister_code_conversion_map):
2997 Check that Vcode_version_map_vector is a vector.
2998 (resolve_symbol_ccl_program): Check that vector header is in range.
2999 Always copy the vector, so that we can check its contents reliably
3000 now rather than having to recheck each instruction as it's being
3001 executed. Check that vector words fit in 'int'.
3002 (ccl_get_compiled_code, Fregister_ccl_program)
3003 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3004 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3005 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3006 contents are in range.
3007 (Fccl_execute_on_string): Check that status is in range.
3008 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3009 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3010 Accept and return EMACS_INT, not int, because callers can pass values
3012 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3013 (multibyte_chars_in_text, parse_str_as_multibyte)
3014 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3015 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3016 (string_escape_byte8, Fget_byte):
3017 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3018 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
3019 avoid mishandling large integers.
3020 * character.h: Adjust decls to match defn changes elsewhere.
3021 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3022 (Ffind_charset_region):
3023 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3024 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3025 (load_charset_map_from_vector, Fdefine_charset_internal):
3026 Don't assume fixnum fits in int.
3027 (load_charset_map_from_vector, Fmap_charset_chars):
3028 Remove now-unnecessary CHECK_NATNUMs.
3029 (Fdefine_charset_internal): Check ranges here, more carefully.
3030 Don't rely on undefined behavior with signed left shift overflow.
3031 Don't assume unsigned int fits into fixnum, or that fixnum fits
3032 into unsigned int. Don't require max_code to be a valid fixnum;
3033 that's not true for gb10830 4-byte on a 32-bit host. Allow
3034 invalid_code to be a cons, for the same reason. Require code_offset
3035 to be a character. Avoid int overflow if max_char is close
3037 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3038 this is intended anyway and avoids some undefined behavior.
3039 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3040 INDEX_TO_CODE_POINT, as that's what it expects.
3041 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
3042 * charset.h (DECODE_CHAR): Return int, not unsigned;
3043 this is what was intended anyway, and it avoids undefined behavior.
3044 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3045 integer-overflow issues.
3046 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3047 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3048 where the argument is EMACS_INT, and this behavior is not intended.
3049 * chartab.c (Fmake_char_table, Fset_char_table_range)
3050 (uniprop_get_decoder, uniprop_get_encoder):
3051 Don't assume fixnum fits in int.
3052 * cmds.c (move_point): New function, that does the gist of
3053 Fforward_char and Fbackward_char, but does so while checking
3054 for integer overflow more accurately.
3055 (Fforward_char, Fbackward_char): Use it.
3056 (Fforward_line, Fend_of_line, internal_self_insert)
3057 (internal_self_insert):
3058 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3059 Fix a FIXME, by checking for integer overflow when calculating
3060 target_clm and actual_clm.
3061 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
3062 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
3063 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3064 (coding_alloc_by_making_gap, alloc_destination)
3065 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3066 (encode_coding_utf_16, detect_coding_emacs_mule)
3067 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3068 (detect_coding_iso_2022, decode_coding_iso_2022)
3069 (encode_invocation_designation, encode_designation_at_bol)
3070 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3071 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3072 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3073 (encode_coding_ccl, encode_coding_raw_text)
3074 (detect_coding_charset, decode_coding_charset)
3075 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3076 (produce_composition, produce_charset, produce_annotation)
3077 (decode_coding, handle_composition_annotation)
3078 (handle_charset_annotation, consume_chars, decode_coding_gap)
3079 (decode_coding_object, encode_coding_object, detect_coding_system)
3080 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3081 (code_convert_region, code_convert_string)
3082 (Fdefine_coding_system_internal)
3083 (coding_set_source, coding_set_destination):
3084 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3085 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3086 (Fdefine_coding_system_internal):
3087 Don't assume fixnums fit in int.
3088 (decode_coding_gap, decode_coding_object, encode_coding_object)
3089 (Fread_coding_system, Fdetect_coding_region)
3090 (Funencodable_char_position, Fcheck_coding_systems_region)
3091 (get_translation, handle_composition_annotation, consume_chars):
3092 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3093 (consume_chars): Rewrite to not calculate an address outside buffer.
3094 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
3095 Don't access memory outside of the args array.
3096 (Fdefine_coding_system_internal): Check for charset-id overflow.
3097 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3098 result of ENCODE_CHAR.
3099 * coding.h: Adjust decls to match defn changes elsewhere.
3100 (struct coding_system):
3101 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3102 * composite.c (get_composition_id, find_composition)
3103 (run_composition_function, update_compositions)
3104 (compose_text, composition_gstring_put_cache)
3105 (composition_gstring_p, composition_gstring_width)
3106 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3107 (composition_compute_stop_pos, composition_reseat_it)
3108 (composition_update_it, struct position_record)
3109 (find_automatic_composition, composition_adjust_point)
3110 (Fcomposition_get_gstring, Ffind_composition_internal):
3111 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3112 (update_compositions):
3113 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3114 * composite.h: Adjust decls to match defn changes elsewhere.
3115 (struct composition):
3116 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3117 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3118 Do not attempt to compute the address of the object just before a
3119 buffer; this is not portable.
3121 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3122 (Faset): Use int, not EMACS_INT, where int is wide enough.
3123 (Fstring_to_number): Don't assume fixnums fit in int.
3124 (Frem): Don't assume arg is nonnegative.
3125 * dbusbind.c (xd_append_arg): Check for integers out of range.
3126 (Fdbus_call_method): Don't overflow the timeout int.
3127 (extract_signed, extract_unsigned): New functions.
3128 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3129 (xd_get_connection_references): Return ptrdiff_t, not int.
3131 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3132 (xd_read_message_1):
3133 Use int, not unsigned, where the dbus API uses int.
3134 (Fdbus_message_internal): Don't overflow mtype.
3135 (syms_of_dbusbind): Allocate right-sized buffer for integers.
3136 * dired.c (directory_files_internal, file_name_completion, scmp)
3137 (file_name_completion_stat):
3138 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3139 (file_name_completion): Don't overflow matchcount.
3140 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3141 * dispextern.h: Adjust decls to match defn changes elsewhere.
3142 (struct text_pos, struct glyph, struct bidi_saved_info)
3143 (struct bidi_string_data, struct bidi_it, struct composition_it)
3145 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3146 (struct display_pos, struct composition_it, struct it):
3147 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3148 * dispnew.c (increment_matrix_positions)
3149 (increment_row_positions, mode_line_string)
3150 (marginal_area_string):
3151 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3152 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
3153 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3154 (duration_to_sec_usec): New function, to check for overflow better.
3155 (Fsleep_for, sit_for): Use it.
3156 * doc.c (get_doc_string, store_function_docstring):
3157 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3158 (get_doc_string, Fsnarf_documentation):
3159 Use int, not EMACS_INT, where int is wide enough.
3161 Use SAFE_ALLOCA, not alloca.
3162 Check for overflow when converting EMACS_INT to off_t.
3163 * doprnt.c (doprnt):
3164 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3165 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3166 Don't assume uid_t fits into fixnum.
3167 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3168 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3169 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3170 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3171 (general_insert_function)
3172 (Finsert_char, make_buffer_string, make_buffer_string_both)
3173 (update_buffer_properties, Fbuffer_substring)
3174 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3175 (Fsubst_char_in_region, check_translation)
3176 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3177 (transpose_markers, Ftranspose_regions):
3178 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3179 (clip_to_bounds): Move to lisp.h as an inline function).
3180 (Fconstrain_to_field): Don't assume integers are nonnegative.
3181 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3182 (Fsubst_char_in_region, Fsave_restriction):
3183 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3184 (Femacs_pid): Don't assume pid_t fits into fixnum.
3185 (lo_time): Use int, not EMACS_INT, when int suffices.
3186 (lisp_time_argument): Check for usec out of range.
3187 (Fencode_time): Don't assume fixnum fits in int.
3188 (Fuser_login_name, Fuser_full_name): Signal an error
3189 if a uid argument is out of range, rather than relying on
3191 (Fformat_time_string): Remove now-unnecessary check.
3192 lisp_time_argument checks for out-of-range usec now.
3193 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
3194 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3195 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3196 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3197 (init_cmdargs, Fdump_emacs):
3198 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3199 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3200 the bottom (typically) 32 bits of the fixnum.
3201 * eval.c (specpdl_size, call_debugger):
3202 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3203 (when_entered_debugger, Fbacktrace_debug):
3204 Don't assume fixnum can fit in int.
3205 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3206 the object just before a buffer; this is not portable.
3207 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3208 (grow_specpdl, unbind_to):
3209 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3210 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3211 (grow_specpdl): Simplify allocation by using xpalloc.
3212 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
3213 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3214 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3215 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3216 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3218 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3219 (Fcopy_file, non_regular_nbytes, read_non_regular)
3220 (Finsert_file_contents):
3221 Use int, not EMACS_INT, where int is wide enough.
3222 (READ_BUF_SIZE): Verify that it fits in int.
3223 (Finsert_file_contents): Check that counts are in proper range,
3224 rather than assuming fixnums fit into ptrdiff_t etc.
3225 Don't assume fixnums fit into int.
3226 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
3227 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3228 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
3229 (string_char_to_byte, string_byte_to_char)
3230 (string_make_multibyte, string_to_multibyte)
3231 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3232 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3233 (substring_both, Fdelete, internal_equal, Ffillarray)
3234 (Fclear_string, mapcar1)
3235 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3236 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3237 (larger_vector, make_hash_table, maybe_resize_hash_table)
3238 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3239 (Fmaphash, secure_hash):
3240 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3241 (concat): Check for string index and length overflow.
3242 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3244 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3245 (larger_vector): New API (vec, incr_min, size_max) replaces old
3246 one (vec, new_size, init). This catches size overflow.
3247 INIT was removed because it was always Qnil.
3248 All callers changed.
3249 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3250 the upper bound on a hash table index size.
3251 (make_hash_table, maybe_resize_hash_table): Use it.
3252 (secure_hash): Computer start_byte and end_byte only after
3253 they're known to be in ptrdiff_t range.
3254 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3255 (Ffont_get_glyphs, Ffont_at):
3256 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3257 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3258 (Flist_fonts, Fopen_font):
3259 Don't assume fixnum can fit in int.
3260 (check_gstring): Don't assume index can fit in int.
3261 (font_match_p): Check that fixnum is a character, not a nonnegative
3262 fixnum, since the later code needs to stuff it into an int.
3263 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3264 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3265 conversion overflow issues.
3266 (Fopen_font): Check for integer out of range.
3267 (Ffont_get_glyphs): Don't assume index can fit in int.
3268 * font.h: Adjust decls to match defn changes elsewhere.
3269 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3271 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3272 printmax_t, where ptrdiff_t is wide enough.
3273 (Finternal_char_font):
3274 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3275 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3276 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3277 (Fset_frame_position, x_set_frame_parameters)
3278 (x_set_line_spacing, x_set_border_width)
3279 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3280 Check that fixnums are in proper range for system types.
3281 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3282 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3283 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3284 Use SAFE_ALLOCA_LISP, not alloca.
3285 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3286 intptr_t is wide enough.
3287 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3288 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3289 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3290 Check for fixnum out of range.
3291 * ftfont.c (ftfont_list): Don't assume index fits in int.
3292 Check that fixnums are in proper range for system types.
3293 (ftfont_shape_by_flt):
3294 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3295 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3296 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3297 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3298 Check that fixnums are in proper range for system types.
3299 * gnutls.h: Adjust decls to match defn changes elsewhere.
3300 * gtkutil.c (xg_dialog_run):
3301 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3302 (update_frame_tool_bar):
3303 Check that fixnums are in proper range for system types.
3304 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
3305 (lookup_image): Check that fixnums are in range for system types.
3306 * indent.c (last_known_column, last_known_column_point):
3307 (current_column_bol_cache):
3308 (skip_invisible, current_column, check_display_width):
3309 (check_display_width, scan_for_column, current_column_1)
3310 (Findent_to, Fcurrent_indentation, position_indentation)
3311 (indented_beyond_p, Fmove_to_column, compute_motion):
3312 (Fcompute_motion, Fvertical_motion):
3313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3314 (last_known_column_modified): Use EMACS_INT, not int.
3315 (check_display_width):
3317 Check that fixnums and floats are in proper range for system types.
3318 (compute_motion): Don't assume index or fixnum fits in int.
3319 (compute_motion, Fcompute_motion):
3320 Use int, not EMACS_INT, when it is wide enough.
3321 (vmotion): Omit local var start_hpos that is always 0; that way
3322 we don't need to worry about overflow in expressions involving it.
3323 * indent.h: Adjust decls to match defn changes elsewhere.
3325 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3326 Use int, not EMACS_INT, where int is wide enough.
3327 Remove unused members ovstring_chars_done and tab_offset;
3329 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3330 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3331 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3332 (make_gap, copy_text, insert, insert_and_inherit)
3333 (insert_before_markers, insert_before_markers_and_inherit)
3334 (insert_1, count_combining_before, count_combining_after)
3335 (insert_1_both, insert_from_string)
3336 (insert_from_string_before_markers, insert_from_string_1)
3337 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3338 (adjust_after_replace, adjust_after_insert, replace_range)
3339 (replace_range_2, del_range, del_range_1, del_range_byte)
3340 (del_range_both, del_range_2, modify_region)
3341 (prepare_to_modify_buffer, signal_before_change)
3342 (signal_after_change, Fcombine_after_change_execute):
3343 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3344 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3345 (balance_an_interval, split_interval_right, split_interval_left)
3346 (find_interval, next_interval, update_interval)
3347 (adjust_intervals_for_insertion, delete_node, delete_interval)
3348 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3349 (static_offset_intervals, offset_intervals)
3350 (merge_interval_right, merge_interval_left, make_new_interval)
3351 (graft_intervals_into_buffer, temp_set_point_both)
3352 (temp_set_point, set_point, adjust_for_invis_intang)
3353 (set_point_both, move_if_not_intangible, get_property_and_range)
3354 (get_local_map, copy_intervals, copy_intervals_to_string)
3355 (compare_string_intervals, set_intervals_multibyte_1):
3356 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3357 * intervals.h: Adjust decls to match defn changes elsewhere.
3359 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3360 * keyboard.c (this_command_key_count, this_single_command_key_start)
3361 (before_command_key_count, before_command_echo_length, echo_now)
3362 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3363 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3364 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3365 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3366 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3367 (last_non_minibuf_size, last_point_position, echo_truncate)
3368 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3369 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3370 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3371 (stuff_buffered_input):
3372 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3373 (last_auto_save, command_loop_1, read_char):
3374 Use EMACS_INT, not int, to avoid integer overflow.
3375 (record_char): Avoid overflow in total_keys computation.
3376 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3377 * keyboard.h: Adjust decls to match defn changes elsewhere.
3378 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3379 (Fkey_description, Fdescribe_vector, Flookup_key):
3380 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3381 (click_position): New function, to check that positions are in range.
3382 (Fcurrent_active_maps):
3384 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3385 (Faccessible_keymaps, Fkey_description):
3386 (preferred_sequence_p):
3387 Don't assume fixnum can fit into int.
3388 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3389 Check for integer overflow in size calculations.
3390 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3391 avoid mishandling large integers.
3392 * lisp.h: Adjust decls to match defn changes elsewhere.
3393 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3394 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3395 (struct Lisp_Marker):
3396 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3397 (clip_to_bounds): Now an inline function, moved here from editfns.c.
3398 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3399 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3400 All callers changed.
3401 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3402 Assume the arg has valid form, since it always does.
3403 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3404 unsigned integer system type.
3405 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3406 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3407 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3408 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3409 (duration_to_sec_usec): New decl.
3410 * lread.c (read_from_string_index, read_from_string_index_byte)
3411 (read_from_string_limit, readchar, unreadchar, openp)
3412 (read_internal_start, read1, oblookup):
3413 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3414 (Fload, readevalloop, Feval_buffer, Feval_region):
3415 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3416 (openp): Check for out-of-range argument to 'access'.
3417 (read1): Use int, not EMACS_INT, where int is wide enough.
3418 Don't assume fixnum fits into int.
3419 Fix off-by-one error that can read outside a buffer.
3420 (read_filtered_event): Use duration_to_sec_usec
3421 to do proper overflow checking on durations.
3422 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3423 in size calculation.
3424 (Fexecute_kbd_macro):
3425 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3426 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3427 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3428 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3429 (set_marker_both, set_marker_restricted_both, marker_position)
3430 (marker_byte_position, Fbuffer_has_markers_at):
3431 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3432 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
3433 * menu.c (ensure_menu_items): Rename from grow_menu_items.
3434 It now merely ensures that the menu is large enough, without
3435 necessarily growing it, as this avoids some integer overflow issues.
3436 All callers changed.
3437 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3438 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3439 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3440 Use SAFE_ALLOCA_LISP, not alloca.
3441 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3442 to EMACS_INT. Check that fixnums are in proper range for system types.
3443 * minibuf.c (minibuf_prompt_width, string_to_object)
3444 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3445 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3447 (get_minibuffer, read_minibuf_unwind):
3448 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3449 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3450 this simplifies overflow checking. All callers changed.
3451 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3453 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3454 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3455 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3456 Check that fixnums are in proper range for system types.
3457 (Fx_create_frame, Fx_show_tip):
3458 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3459 * nsfont.m (ns_findfonts, nsfont_list_family):
3460 Don't assume fixnum fits in long.
3461 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3462 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3463 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3465 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
3466 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3467 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3468 (PRINTDECLARE, PRINTPREPARE):
3469 (strout, print_string):
3470 (print, print_preprocess, print_check_string_charset_prop)
3472 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3474 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3475 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3476 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
3477 (printchar, strout): Use xpalloc to catch size calculation overflow.
3478 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
3479 (print_error_message): Use SAFE_ALLOCA, not alloca.
3480 (print_object): Use int, not EMACS_INT, where int is wide enough.
3481 (print_depth, new_backquote_output, print_number_index):
3482 Use ptrdiff_t, not int, where int might not be wide enough.
3483 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3484 (Fset_process_window_size, Fformat_network_address)
3485 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
3487 Check that fixnums are in proper range for system types.
3488 (Fsignal_process): Simplify by avoiding a goto.
3489 Check for process-ids out of pid_t range rather than relying on
3491 (process_tick, update_tick): Use EMACS_INT, not int.
3492 (Fformat_network_address, read_process_output, send_process)
3493 (Fprocess_send_region, status_notify):
3494 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3495 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3496 (wait_reading_process_output, read_process_output, exec_sentinel):
3497 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3498 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3499 (Faccept_process_output): Use duration_to_sec_usec to do proper
3500 overflow checking on durations.
3501 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3502 Don't assume pid_t fits in int.
3503 * process.h (struct Lisp_Process): Members tick and update_tick
3504 are now of type EMACS_INT, not int.
3505 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3506 configured --with-wide-int.
3507 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3508 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3509 * search.c (looking_at_1, string_match_1):
3510 (fast_string_match, fast_c_string_match_ignore_case)
3511 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3512 (scan_newline, find_before_next_newline, search_command)
3513 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3514 (set_search_regs, wordify):
3517 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3518 (string_match_1, search_buffer, set_search_regs):
3520 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3521 (wordify): Check for overflow in size calculation.
3522 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3523 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3524 Check that fixnums are in proper range for system types.
3525 * sound.c (struct sound_device)
3526 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3527 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3528 (Fplay_sound_internal):
3529 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3530 * syntax.c (struct lisp_parse_state, find_start_modiff)
3531 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3532 (Fparse_partial_sexp):
3533 Don't assume fixnums can fit in int.
3534 (struct lisp_parse_state, find_start_pos, find_start_value)
3535 (find_start_value_byte, find_start_begv)
3536 (update_syntax_table, char_quoted, dec_bytepos)
3537 (find_defun_start, prev_char_comend_first, back_comment):
3538 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3539 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3540 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3541 (Finternal_describe_syntax_value): Check that match_lisp is a
3542 character, not an integer, since the code stuffs it into int.
3543 (scan_words, scan_sexps_forward):
3544 Check that fixnums are in proper range for system types.
3546 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3547 (scan_sexps_forward):
3548 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3549 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3550 * syntax.h: Adjust decls to match defn changes elsewhere.
3551 (struct gl_state_s):
3552 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3553 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3554 MOST_POSITIVE_FIXNUM.
3555 * sysdep.c (wait_for_termination_1, wait_for_termination)
3556 (interruptible_wait_for_termination, mkdir):
3557 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3558 (emacs_read, emacs_write):
3559 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3560 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3561 and double all fit in int.
3562 * term.c (set_tty_color_mode):
3563 Check that fixnums are in proper range for system types.
3564 * termhooks.h (struct input_event):
3565 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3566 * textprop.c (validate_interval_range, interval_of)
3567 (Fadd_text_properties, set_text_properties_1)
3568 (Fremove_text_properties, Fremove_list_of_text_properties)
3569 (Ftext_property_any, Ftext_property_not_all)
3570 (copy_text_properties, text_property_list, extend_property_ranges)
3571 (verify_interval_modification):
3572 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3573 (Fnext_single_char_property_change)
3574 (Fprevious_single_char_property_change):
3575 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3576 (copy_text_properties):
3577 Check for integer overflow in index calculation.
3578 * undo.c (last_boundary_position, record_point, record_insert)
3579 (record_delete, record_marker_adjustment, record_change)
3580 (record_property_change):
3581 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3582 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3583 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3584 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3585 (Fx_hide_tip, Fx_file_dialog):
3586 * w32menu.c (set_frame_menubar):
3587 Use ptrdiff_t, not int, for consistency with rest of code.
3588 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3589 (select_window, Fdelete_other_windows_internal)
3590 (window_scroll_pixel_based, window_scroll_line_based)
3591 (Frecenter, Fset_window_configuration):
3592 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3593 (Fset_window_hscroll, run_window_configuration_change_hook)
3594 (set_window_buffer, temp_output_buffer_show, scroll_command)
3595 (Fscroll_other_window, Frecenter):
3596 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3597 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3598 Don't assume fixnum fits in int.
3599 (Fset_window_scroll_bars):
3600 Check that fixnums are in proper range for system types.
3601 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3602 (string_pos, c_string_pos, number_of_chars, init_iterator)
3603 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3604 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3605 (compute_display_string_end, handle_face_prop)
3606 (face_before_or_after_it_pos, handle_invisible_prop)
3607 (handle_display_prop, handle_display_spec, handle_single_display_spec)
3608 (display_prop_intangible_p, string_buffer_position_lim)
3609 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3610 (get_overlay_strings_1, get_overlay_strings)
3611 (iterate_out_of_display_property, forward_to_next_line_start)
3612 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3613 (get_next_display_element, set_iterator_to_next)
3614 (get_visually_first_element, compute_stop_pos_backwards)
3615 (handle_stop_backwards, next_element_from_buffer)
3616 (move_it_in_display_line_to, move_it_in_display_line)
3617 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3618 (add_to_log, message_dolog, message_log_check_duplicate)
3619 (message2, message2_nolog, message3, message3_nolog
3620 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3621 (current_message_1, truncate_echo_area, truncate_message_1)
3622 (set_message, set_message_1, store_mode_line_noprop)
3623 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3624 (text_outside_line_unchanged_p, check_point_in_composition)
3625 (reconsider_clip_changes)
3626 (redisplay_internal, set_cursor_from_row, try_scrolling)
3627 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3628 (redisplay_window, find_last_unchanged_at_beg_row)
3629 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3630 (trailing_whitespace_p, find_row_edges, display_line)
3631 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3632 (display_mode_element, store_mode_line_string)
3633 (pint2str, pint2hrstr, decode_mode_spec)
3634 (display_count_lines, display_string, draw_glyphs)
3635 (x_produce_glyphs, x_insert_glyphs)
3636 (rows_from_pos_range, mouse_face_from_buffer_pos)
3637 (fast_find_string_pos, mouse_face_from_string_pos)
3638 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3639 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3640 (safe_call, init_from_display_pos, handle_fontified_prop)
3641 (handle_single_display_spec, load_overlay_strings)
3642 (with_echo_area_buffer, setup_echo_area_for_printing)
3643 (display_echo_area, echo_area_display)
3644 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3645 (update_tool_bar, hscroll_window_tree, redisplay_internal)
3646 (redisplay_window, dump_glyph_row, display_mode_line)
3647 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
3648 (handle_display_spec, display_prop_string_p):
3649 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3650 (handle_single_display_spec, build_desired_tool_bar_string)
3651 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3652 (get_specified_cursor_type):
3653 Check that fixnums are in proper range for system types.
3654 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3655 (Flookup_image_map):
3656 Don't assume fixnums fit in int.
3657 (compare_overlay_entries):
3658 Avoid mishandling comparisons due to subtraction overflow.
3659 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3660 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3661 (handle_tool_bar_click):
3662 Use int, not unsigned, since we prefer signed and the signedness
3663 doesn't matter here.
3664 (get_next_display_element, next_element_from_display_vector):
3665 Use int, not EMACS_INT, when int is wide enough.
3666 (start_hourglass): Use duration_to_sec_usec to do proper
3667 overflow checking on durations.
3668 * xfaces.c (Fbitmap_spec_p):
3669 Check that fixnums are in proper range for system types.
3670 (compare_fonts_by_sort_order):
3671 Avoid mishandling comparisons due to subtraction overflow.
3672 (Fx_family_fonts, realize_basic_faces):
3673 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3675 Don't assume fixnum fits in int.
3676 Use SAFE_ALLOCA_LISP, not alloca.
3677 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3678 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3679 (face_at_buffer_position, face_for_overlay_string)
3680 (face_at_string_position):
3681 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3682 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3683 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3685 Check that fixnums are in proper range for system types.
3686 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3687 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3688 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3689 (Fx_change_window_property): Don't assume fixnums fit in int.
3690 * xfont.c (xfont_chars_supported):
3691 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3692 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3693 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3694 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3695 * xml.c (parse_region):
3696 * xrdb.c (magic_file_p):
3697 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3698 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3699 (x_get_local_selection, x_reply_selection_request)
3700 (x_handle_selection_request, wait_for_property_change):
3701 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3702 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3703 short is wide enough.
3704 (x_send_client_event): Don't assume fixnum fits in int.
3705 * xterm.c (x_x_to_emacs_modifiers):
3706 Don't assume EMACS_INT overflows nicely into int.
3707 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3709 (handle_one_xevent): NATNUMP can eval its arg twice.
3710 (x_connection_closed):
3711 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3712 * xterm.h: Adjust decls to match defn changes elsewhere.
3713 (struct scroll_bar): Use struct vectorlike_header
3714 rather than rolling our own approximation.
3715 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3717 2012-05-25 Glenn Morris <rgm@gnu.org>
3719 * lisp.mk (lisp): Update for more files being compiled now.
3721 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3723 * lread.c: Remove `read_pure' which makes no difference.
3724 (read_pure): Remove var.
3725 (unreadpure): Remove function.
3726 (readevalloop): Don't call read_list with -1 flag.
3727 (read1, read_vector): Don't test read_pure any more.
3728 (read_list): Simplify.
3730 * fileio.c, character.h: Minor style tweaks.
3732 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3734 * window.h (clip_changed): Remove useless declaration.
3736 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
3738 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3739 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3741 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3744 This directory predates autoconf and is no longer needed nowadays.
3745 Move its few remaining bits of functionality to where they're needed.
3746 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3747 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3748 * m/template.h: Remove.
3749 * Makefile.in (M_FILE): Remove. All uses removed.
3750 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3751 * lisp.h (USE_LSB_TAG):
3752 * mem-limits.h (EXCEEDS_LISP_PTR):
3753 Use VAL_MAX, not VALBITS, in #if.
3754 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3755 (EMACS_UINT): Define unconditionally now.
3756 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3757 (BITS_PER_EMACS_INT): New constants, replacing
3758 what used to be in config.h, but not useful in #if.
3759 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3760 define them any more.
3761 (VAL_MAX): New macro.
3763 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3764 BITS_PER_EMACS_INT, in #if.
3765 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3766 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3767 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3768 * s/ms-w32.h (DATA_START):
3769 Move here from removed file m/intel386.h.
3770 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3771 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3773 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3775 Assume C89 or later.
3776 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3777 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3779 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3780 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3781 * textprop.c, tparam.c (NULL): Remove.
3782 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3783 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3784 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3785 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3786 * xterm.c (input_signal_count): Assume volatile works.
3788 2012-05-21 Ken Brown <kbrown@cornell.edu>
3790 * xgselect.c (xg_select): Fix first argument in call to 'select'
3793 2012-05-20 Ken Brown <kbrown@cornell.edu>
3795 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
3796 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
3798 2012-05-19 Ken Brown <kbrown@cornell.edu>
3800 * xfns.c (x_in_use): Remove `static' qualifier.
3801 * xterm.h (x_in_use): Declare.
3802 * xgselect.c: Include xterm.h.
3803 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3804 and `display_arg' (bug#9754).
3806 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3808 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3810 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3811 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3813 2012-05-18 Eli Zaretskii <eliz@gnu.org>
3815 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3817 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
3818 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
3820 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3821 reference to image_cache->refcount.
3822 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3824 2012-05-17 Juri Linkov <juri@jurta.org>
3826 * search.c (Fword_search_regexp, Fword_search_backward)
3827 (Fword_search_forward, Fword_search_backward_lax)
3828 (Fword_search_forward_lax): Move functions to isearch.el
3829 (bug#10145, bug#11381).
3831 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3833 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3835 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3837 * lread.c (init_obarray): Declare Qt and Qnil as special.
3839 2012-05-14 Glenn Morris <rgm@gnu.org>
3841 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
3842 Put "libexec" before "bin", for the sake of init_callproc_1.
3844 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3846 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3848 * unexaix.c: Port to more-recent AIX compilers.
3849 (report_error, report_error_1, make_hdr, copy_sym)
3850 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3851 Make arguments const char *, not char *, to avoid violations of C
3852 standard and to fix some AIX warnings reported by Gilles Pion.
3854 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3856 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3857 already have overlays loaded.
3858 (handle_single_display_spec): Before returning without displaying
3859 fringe bitmap, synchronize the bidi iterator with the main display
3860 iterator, by calling iterate_out_of_display_property.
3861 (iterate_out_of_display_property): Detect buffer iteration by
3862 testing that it->string is a Lisp string.
3863 (get_next_display_element): When the current object is exhausted,
3864 and there's something on it->stack, call set_iterator_to_next to
3865 proceed with what's on the stack, instead of returning zero.
3866 (set_iterator_to_next): If called at the end of a Lisp string,
3867 proceed to consider_string_end without incrementing string
3868 position. Don't increment display vector index past the end of
3869 the display vector. (Bug#11417)
3870 (pos_visible_p): Don't report a position visible when move_it_to
3871 stopped at the last line of window, which happens to be scanned
3872 backwards by the bidi iteration. (Bug#11464)
3874 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3876 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3877 and right-margin display specs even if the spec is invalid or we
3878 are on a TTY, and thus unable to display on the fringes.
3879 That's because the text with the property will not be displayed anyway,
3880 so we need to signal to the caller that this is a "replacing"
3881 display spec. This fixes display when the spec is invalid or we
3884 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3886 * unexaix.c (make_hdr): Fix typo in prototype.
3887 This bug broke the build on AIX. Problem reported by Gilles Pion.
3889 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
3891 * keyboard.c (kbd_buffer_get_event): Read special events also in
3892 batch mode. (Bug#11415)
3894 2012-05-12 Glenn Morris <rgm@gnu.org>
3896 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3898 2012-05-12 Eli Zaretskii <eliz@gnu.org>
3900 * lisp.mk (lisp): Add newcomment.elc.
3902 2012-05-12 Glenn Morris <rgm@gnu.org>
3904 * Makefile.in (MKDIR_P): New, set by configure.
3905 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3907 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3909 Remove unused function hourglass_started.
3910 * dispextern.h (hourglass_started):
3911 * w32fns.c (hourglass_started):
3912 * xdisp.c (hourglass_started): Remove.
3914 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
3916 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3917 Update dependencies.
3919 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3921 * xgselect.c (xg_select): Put maxfds+1 into a var.
3922 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3924 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3926 2012-05-10 Dave Abrahams <dave@boostpro.com>
3928 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3929 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3931 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
3933 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3934 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3935 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3936 Initialize xd_registered_buses.
3938 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3940 Untag more efficiently if USE_LSB_TAG.
3941 This is based on a proposal by YAMAMOTO Mitsuharu in
3942 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3943 For an admittedly artificial (nth 8000 longlist) benchmark on
3944 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3945 Emacs's overall text size by 1%.
3946 * lisp.h (XUNTAG): New macro.
3947 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3948 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3949 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3950 * eval.c (Fautoload):
3951 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3952 * frame.h (XFRAME): Use XUNTAG.
3954 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3955 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3956 Remove unportable assumptions about print widths of types like
3958 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3959 intptr_t when converting between pointer and integer, to avoid GCC
3960 warnings about wrong width.
3962 2012-05-09 Eli Zaretskii <eliz@gnu.org>
3964 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3965 stack for each reader_thread, instead of defaulting to 8MB
3966 determined by the linker. This avoids failures in creating
3967 subprocesses on Windows 7, see the discussion in this thread:
3968 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3970 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3972 Fix up display of the *Minibuf-0* buffer in the mini window.
3973 * keyboard.c (read_char): Don't clear the echo area if there's no
3975 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
3976 contents of *Minibuf-0*) if there's no message displayed in its stead.
3978 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
3980 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3983 2012-05-06 Chong Yidong <cyd@gnu.org>
3985 * lisp.mk (lisp): Update.
3987 2012-05-05 Jim Meyering <meyering@redhat.com>
3989 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3991 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3993 * data.c (PUT_ERROR): New macro.
3994 (syms_of_data): Use it. Add new error type `user-error'.
3995 * undo.c (user_error): New function.
3996 (Fprimitive_undo): Use it.
3997 * print.c (print_error_message): Adjust print style for `user-error'.
3998 * keyboard.c (user_error): New function.
3999 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4001 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4003 Do not limit current-time-string to years 1000..9999.
4004 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4005 (Fcurrent_time_string): Support any year that is supported by the
4006 underlying localtime representation. Don't use asctime, as it
4007 has undefined behavior for years outside the range -999..9999.
4009 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4011 Fix race conditions involving setenv, gmtime, localtime, asctime.
4012 Without this fix, interrupts could mess up code that uses these
4013 nonreentrant functions, since setting TZ invalidates existing
4014 tm_zone or tzname values, and since most of these functions return
4015 pointers to static storage.
4016 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4017 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4018 Grow the critical sections to include not just invoking
4019 localtime/gmtime, but also accessing these functions' results
4020 including their tm_zone values if any, and any related TZ setting.
4021 (format_time_string): Last arg is now struct tm *, not struct tm **,
4022 so that the struct tm is saved in the critical section.
4023 All callers changed. Simplify allocation of initial buffer, partly
4024 motivated by the fact that memory allocation needs to be outside
4025 the critical section.
4027 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4029 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4030 with RESET_INTERVAL.
4032 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4033 Remove duplicated buffer name initialization.
4035 2012-05-02 Jim Meyering <jim@meyering.net>
4037 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4039 * xfns.c (x_window): Use xstrdup (Bug#11375).
4041 2012-05-02 Eli Zaretskii <eliz@gnu.org>
4043 * xdisp.c (pos_visible_p): If already at a newline from the
4044 display string before the 'while' loop, don't walk back the glyphs
4045 from it3.glyph_row. Solves assertion violation when the display
4046 string begins with a newline (egg.el). (Bug#11367)
4048 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4050 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4053 2012-05-01 Glenn Morris <rgm@gnu.org>
4055 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4056 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4057 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4058 All were removed before 23.1.
4060 * dispnew.c: Remove HAVE_LIBNCURSES test;
4061 it is always true on relevant platforms.
4063 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4064 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4066 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4068 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4070 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4071 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4074 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4076 Do not avoid creating empty evaporating overlays (Bug#9642).
4077 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4078 That is, do not delete an evaporating overlay if it becomes
4079 empty after its bounds are adjusted to fit within its buffer.
4080 This fix caused other problems, and I'm reverting it until we get
4081 to the bottom of them.
4083 2012-04-27 Chong Yidong <cyd@gnu.org>
4085 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4087 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4089 * xdisp.c (pos_visible_p): If the window start position is beyond
4090 ZV, start the display from buffer beginning. Prevents assertion
4091 violation in init_iterator when the minibuffer window is scrolled
4094 * window.c (window_scroll_pixel_based): Likewise.
4096 2012-04-27 Chong Yidong <cyd@gnu.org>
4098 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4100 2012-04-27 Glenn Morris <rgm@gnu.org>
4102 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4103 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4105 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4107 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4108 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
4110 2012-04-26 Eli Zaretskii <eliz@gnu.org>
4112 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4113 display element, check also the underlying string or buffer
4114 character. (Bug#11341)
4116 * w32menu.c: Include w32heap.h.
4117 (add_menu_item): If the call to AppendMenuW (via
4118 unicode_append_menu) fails, disable Unicode menus only if we are
4119 running on Windows 9X/Me.
4121 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4123 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4124 (xgetint): Add missing shift for LSB tags.
4126 2012-04-24 Martin Rudalics <rudalics@gmx.at>
4128 * keyboard.c (read_char): Don't wipe echo area for select window
4129 events: These might get delayed via `mouse-autoselect-window'
4132 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
4134 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4135 manipulation of :loaded-from data.
4137 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
4139 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4140 now a cons (bug#11311).
4142 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4144 Do not create empty overlays with the evaporate property (Bug#9642).
4145 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4146 if it becomes empty after its bounds are adjusted to fit within
4147 its buffer. Without this fix, in a nonempty buffer (let ((o
4148 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4149 yields an empty overlay that has the evaporate property, which is
4150 not supposed to happen.
4152 Fix minor GTK3 problems found by static checking.
4153 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4154 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4155 (struct _EmacsFixedClass, emacs_fixed_get_type):
4156 Move decls here from emacsgtkfixed.h, since they needn't be public.
4157 (emacs_fixed_get_type): Now static.
4158 (emacs_fixed_class_init): Omit unused local.
4159 (emacs_fixed_child_type): Remove; unused.
4160 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4161 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4162 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4163 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4164 (EMACS_FIXED_GET_CLASS): Remove; unused.
4165 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4167 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4168 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4170 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4172 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
4173 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
4174 (__malloc_size_t, __malloc_ptrdiff_t):
4175 Remove. All uses removed, replaced by the definiens if needed,
4176 since we can assume C89 or better now.
4177 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4178 (protect_malloc_state, align, get_contiguous_space)
4179 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4180 (malloc_atfork_handler_child, malloc_enable_thread)
4181 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4182 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4183 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4184 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4185 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4186 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4187 Define using prototypes, not old style.
4188 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4189 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4190 (align): Don't assume that signed integer overflow wraps around.
4191 Omit unused local var.
4192 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4193 (_free_internal_nolock, memalign, mallochook, reallochook):
4194 Omit no-longer-needed casts.
4195 (valloc): Use getpagesize, not __getpagesize.
4196 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4197 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4199 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4201 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
4203 Move functions from C to Lisp. Make non-blocking method calls
4204 the default. Implement further D-Bus standard interfaces.
4206 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4207 (QCdbus_request_name_allow_replacement)
4208 (QCdbus_request_name_replace_existing)
4209 (QCdbus_request_name_do_not_queue)
4210 (QCdbus_request_name_reply_primary_owner)
4211 (QCdbus_request_name_reply_in_queue)
4212 (QCdbus_request_name_reply_exists)
4213 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4214 (QCdbus_registered_serial, QCdbus_registered_method)
4215 (QCdbus_registered_signal): New Lisp objects.
4216 (XD_DEBUG_MESSAGE): Use sizeof.
4217 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4218 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4219 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4220 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4221 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4222 (xd_signature, xd_append_arg): Allow float for integer types.
4223 (xd_get_connection_references): New function.
4224 (xd_get_connection_address): Rename from xd_initialize.
4225 Return cached address.
4226 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4227 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4229 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
4230 Return number of refcounts.
4231 (Fdbus_get_unique_name): Make stronger parameter check.
4232 (Fdbus_message_internal): New defun.
4233 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4234 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4235 (Fdbus_send_signal, Fdbus_register_service)
4236 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4237 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4238 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4239 (Vdbus_compiled_version, Vdbus_runtime_version)
4240 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4241 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4242 (Vdbus_message_type_signal): New defvars.
4243 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4246 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4248 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4249 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4250 Do not assume ptrdiff_t is the same width as 'int'.
4252 * alloc.c: Handle unusual debugging option combinations.
4253 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4254 since the two debugging options are incompatible.
4255 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4257 (mem_init, mem_insert, mem_insert_fixup):
4258 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4259 (NEED_MEM_INSERT): Remove; no longer needed.
4261 2012-04-22 Leo Liu <sdl.web@gmail.com>
4263 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4265 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4267 * sysdep.c [__FreeBSD__]: Minor cleanups.
4268 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4269 Use Emacs indenting style more consistently. Avoid some casts.
4270 Use 'double' consistently rather than mixing 'float' and 'double'.
4272 2012-04-21 Eduard Wiebe <usenet@pusto.de>
4274 * sysdep.c (list_system_processes, system_process_attributes):
4275 Add implementation for FreeBSD (Bug#5243).
4277 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4279 * lisp.mk (lisp): Update.
4281 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4283 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4284 It is never used otherwise.
4286 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4288 * print.c (print_preprocess): Only check print_depth if print-circle
4290 (print_object): Check for cycles even when print-circle is nil and
4291 print-gensym is t, but only check print_depth if print-circle is nil.
4293 2012-04-20 Chong Yidong <cyd@gnu.org>
4295 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4296 set the status to "failed" and ensure that sentinel is run.
4298 2012-04-20 Glenn Morris <rgm@gnu.org>
4300 * process.c (Fset_process_inherit_coding_system_flag)
4301 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4302 (Fmake_network_process, Fmake_serial_process): Doc fix.
4304 2012-04-20 Eli Zaretskii <eliz@gnu.org>
4306 * xdisp.c (string_buffer_position_lim): Limit starting position to
4308 (set_cursor_from_row): If called for a mode-line or header-line
4309 row, return zero immediately.
4310 (try_cursor_movement): If inside continuation line, don't back up
4311 farther than the first row after the header line, if any.
4312 Don't consider the header-line row as "partially visible", even if
4313 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4315 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4317 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4320 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
4321 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
4323 configure: new option --enable-gcc-warnings (Bug#11207)
4324 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4325 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4326 (ALL_CFLAGS): Use new macros rather than old.
4327 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4328 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4329 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4330 -Wunused-result, -Wunused-variable. This should go away once
4331 the Emacs and Gnulib regex code is merged.
4332 (xmalloc, xrealloc): Now static.
4334 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4336 * dired.c (Fsystem_groups): Remove unused local.
4338 2012-04-17 Glenn Morris <rgm@gnu.org>
4340 * dired.c (Fsystem_users): Doc fix.
4342 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4344 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4345 (syms_of_dired): Add them.
4347 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4349 Fix minor alloc.c problems found by static checking.
4350 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4351 New extern decls, to avoid calling undeclared functions.
4352 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4353 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4354 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4355 (NEED_MEM_INSERT): New macro.
4356 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4357 Remove one incorrect comment and fix another.
4359 Fix minor ralloc.c problems found by static checking.
4360 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4361 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4362 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4363 (r_alloc_sbrk): Now static.
4365 Improve ralloc.c interface checking.
4366 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4367 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4368 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4369 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4370 [REL_ALLOC]: ... to here, to check interface.
4371 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4372 Remove decls. This fixes an "It stinks!".
4374 * alloc.c (which_symbols): Fix alignment issue / type clash.
4376 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4378 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4379 (struct Lisp_Misc_Any): Likewise.
4380 (struct Lisp_Free): Likewise.
4381 * alloc.c (union aligned_Lisp_Symbol): Define.
4382 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4383 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4384 (union aligned_Lisp_Misc): Define.
4385 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4386 aligned_Lisp_Misc instead of union Lisp_Misc.
4387 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
4389 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4391 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4392 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4393 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4394 * s/netbsd.h, s/sol2-6.h:
4395 Remove definition of GC_MARK_STACK, since the default now works.
4396 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4397 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4398 no longer the default.
4399 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4401 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4403 * lread.c (lisp_file_lexically_bound_p):
4404 Fix hang at ";-*-\n" (bug#11238).
4406 2012-04-14 Eli Zaretskii <eliz@gnu.org>
4408 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4409 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4411 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4413 * nsterm.m (constrainFrameRect): Always constrain when there is only
4414 one screen (Bug#10962).
4416 2012-04-13 Ken Brown <kbrown@cornell.edu>
4418 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4420 2012-04-13 Reuben Thomas <rrt@sc3d.org>
4422 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4424 2012-04-11 Daniel Colascione <dancol@dancol.org>
4426 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4427 against is gone. It's better to use vfork now so that when Cygwin
4428 gains a new, working vfork, we use it automatically (bug#10398).
4430 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4432 * window.c (save_window_save): Obey window-point-insertion-type.
4434 2012-04-11 Glenn Morris <rgm@gnu.org>
4436 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4438 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4440 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4442 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
4444 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4445 (force_quit_count): New var.
4446 (handle_interrupt): Use it.
4448 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
4450 * w32.c (w32_delayed_load): Record the full path of the library
4451 being loaded (bug#10424).
4453 2012-04-09 Glenn Morris <rgm@gnu.org>
4455 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4456 not just in the obarray, before snarfing them. (Bug#11036)
4458 * Makefile.in ($(leimdir)/leim-list.el):
4459 Pass EMACS rather than BUILT_EMACS.
4461 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4463 * process.c (make_process):
4464 * process.h: Add integer `gnutls_handshakes_tried' member to
4467 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4468 Add convenience `GNUTLS_LOG2i' macro.
4470 * gnutls.c (gnutls_log_function2i): Convenience log function.
4471 (emacs_gnutls_read): Use new log functions,
4472 `gnutls_handshakes_tried' process member, and
4473 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4474 attempts per process (connection).
4476 2012-04-09 Chong Yidong <cyd@gnu.org>
4478 * eval.c (Fuser_variable_p, user_variable_p_eh)
4479 (lisp_indirect_variable): Functions deleted.
4480 (Fdefvar): Caller changed.
4482 * callint.c (Finteractive, Fcall_interactively):
4483 * minibuf.c (Fread_variable): Callers changed.
4485 2012-04-09 Eli Zaretskii <eliz@gnu.org>
4487 * xdisp.c (set_cursor_from_row): If the display string appears in
4488 the buffer at position that is closer to point than the position
4489 after the display string, display the cursor on the first glyph of
4490 the display string. Fixes cursor display when a 'display' text
4491 property immediately follows invisible text. (Bug#11094)
4493 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4495 composite.c: use 'double' consistently
4496 * composite.c (get_composition_id): Use 'double' consistently
4497 instead of converting 'float' to 'double' and vice versa; this is
4498 easier to understand and avoids a GCC warning.
4500 2012-04-09 Glenn Morris <rgm@gnu.org>
4502 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4503 preparation for dumping it with emacs. (Bug#4789)
4504 (leimdir): New variable.
4505 ($(leimdir)/leim-list.el): New rule.
4506 (emacs$(EXEEXT)): Depend on leim-list.el.
4508 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4509 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4510 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4512 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4514 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4517 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
4519 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4520 Remove unused local variable.
4522 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4524 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4525 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4526 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4527 objects, as mark_maybe_pointer will catch them otherwise.
4528 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4529 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4531 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4533 Fix typo that broke non-Windows builds.
4534 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4536 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4538 Support building on MS-Windows with libxml2.
4540 * makefile.w32-in (OBJ2): Add xml.$(O).
4541 (GLOBAL_SOURCES): Add xml.c.
4542 ($(BLD)/xml.$(O)): New dependency list.
4544 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4545 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4546 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4547 [!WINDOWSNT]: New macros.
4548 (init_libxml2_functions, libxml2_loaded_p): New functions.
4549 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4550 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4551 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4552 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4554 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4555 Call init_libxml2_functions before calling libxml2 functions.
4556 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4558 * emacs.c: Don't include libxml/parser.h.
4559 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4560 xmlCleanupParser directly.
4562 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4564 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4566 * indent.c (Fvertical_motion): If there is a display string at
4567 point, use it.vpos to compute how many lines to backtrack after
4568 move_it_to point. (Bug#11133)
4570 2012-04-06 Eli Zaretskii <eliz@gnu.org>
4572 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4573 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4574 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4575 macros related to unification of CJK characters. For the details,
4576 see the discussion following the message here:
4577 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4579 2012-04-04 Chong Yidong <cyd@gnu.org>
4581 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4583 2012-04-01 Eli Zaretskii <eliz@gnu.org>
4585 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4586 instead of alloca. (Bug#11138)
4588 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4590 * w32menu.c (is_simple_dialog): Properly check lisp types.
4593 2012-03-31 Eli Zaretskii <eliz@gnu.org>
4595 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4596 position we get to after a call to move_it_to fails the
4597 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4598 only if we wind up in a string from display property. (Bug#11063)
4600 * window.c (Fdelete_other_windows_internal): Invalidate the row
4601 and column information about mouse highlight, so that redisplay
4602 restores it after reallocating the glyph matrices. (Bug#7464)
4604 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4605 string comes from a `display' text property, use the buffer
4606 position of that property as if we actually saw that position in
4608 (move_it_by_lines): Remove the assertion that
4609 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4610 violated when there's a before-string at the beginning of a line.
4613 2012-03-30 Eli Zaretskii <eliz@gnu.org>
4615 * xdisp.c (append_space_for_newline): If the default face was
4616 remapped, use the remapped face for the appended newline.
4617 (extend_face_to_end_of_line): Use the remapped default face for
4618 extending the face to the end of the line.
4619 (display_line): Call extend_face_to_end_of_line when the default
4620 face was remapped. (Bug#11068)
4622 2012-03-29 Eli Zaretskii <eliz@gnu.org>
4624 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4626 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4628 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4630 2012-03-27 Glenn Morris <rgm@gnu.org>
4632 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4635 2012-03-26 Kenichi Handa <handa@m17n.org>
4637 * dispextern.h (struct glyph): Fix previous change. Change the
4638 bit length of glyphless.ch to 25 (Bug#11082).
4640 2012-03-26 Chong Yidong <cyd@gnu.org>
4642 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4643 (command_loop_1): Use it; inhibit selection update for
4644 handle-select-window too (Bug#8996).
4646 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4648 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
4650 2012-03-25 Kenichi Handa <handa@m17n.org>
4652 * dispextern.h (struct glyph): Change the bit length of
4653 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4655 2012-03-24 Eli Zaretskii <eliz@gnu.org>
4657 * s/ms-w32.h (tzname): Include time.h before redirecting to
4658 _tzname. Fixes the MSVC build. (Bug#9960)
4660 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4662 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4665 * xterm.c (XTread_socket): Only modify handling_signal if
4666 !SYNC_INPUT. (Bug#11080)
4668 2012-03-23 Eli Zaretskii <eliz@gnu.org>
4670 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4671 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4672 when fetching a multibyte character consumes more bytes than
4673 CHAR_BYTES returns, due to unification of CJK characters in
4674 string_char. (Bug#11073)
4676 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4678 * process.c (wait_reading_process_output): Handle pty disconnect
4679 by refraining from sending oneself a SIGCHLD (bug#10933).
4681 2012-03-22 Chong Yidong <cyd@gnu.org>
4683 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4685 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
4686 Mark string as coming from a prefix property.
4687 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4688 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4690 2012-03-21 Chong Yidong <cyd@gnu.org>
4692 * xfaces.c (Vface_remapping_alist): Doc fix.
4694 2012-03-20 Eli Zaretskii <eliz@gnu.org>
4696 * w32proc.c (Fw32_set_console_codepage)
4697 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4700 2012-03-20 Chong Yidong <cyd@gnu.org>
4702 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4703 to reflect default non-nil value of redisplay-dont-pause.
4705 2012-03-19 Kenichi Handa <handa@m17n.org>
4707 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4708 it fit in a valid range (Bug#11003).
4710 2012-03-18 Eli Zaretskii <eliz@gnu.org>
4712 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4713 that is not from display property, accept the row as a "cursor
4714 row" if one of the string's character has a non-nil `cursor'
4715 property. Fixes cursor positioning when there are newlines in
4716 overlay strings, e.g. in icomplete.el. (Bug#11035)
4718 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4720 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4722 2012-03-12 Chong Yidong <cyd@gnu.org>
4724 * eval.c (inhibit_lisp_code): Rename from
4725 inhibit_window_configuration_change_hook; move from window.c.
4727 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4728 * window.c (run_window_configuration_change_hook)
4729 (syms_of_window): Callers changed.
4731 2012-03-11 Chong Yidong <cyd@gnu.org>
4733 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4735 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4737 2012-03-10 Chong Yidong <cyd@gnu.org>
4739 * frame.c (other_visible_frames): Don't assume the selected frame
4740 is visible (Bug#10955).
4742 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4744 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4746 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4748 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4749 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4752 2012-03-03 Glenn Morris <rgm@gnu.org>
4754 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
4756 2012-03-02 Eli Zaretskii <eliz@gnu.org>
4758 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4759 position past the first glyph_row that ends at ZV. (Bug#10902)
4760 (redisplay_window, next_element_from_string): Fix typos in
4762 (redisplay_window): Pass to move_it_vertically the margin in
4763 pixels, not in screen lines.
4765 2012-03-02 Glenn Morris <rgm@gnu.org>
4767 * buffer.c (buffer-list-update-hook): Doc fix.
4769 2012-02-29 Eli Zaretskii <eliz@gnu.org>
4771 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4772 push_it before setting up the iterator for the first overlay
4773 string, even if we have an empty string loaded.
4774 (next_overlay_string): If there's an empty string on the iterator
4775 stack, pop the stack. (Bug#10903)
4777 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4779 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4780 Suggested by Stefan Monnier in
4781 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4782 * alloc.c (widen_to_Lisp_Object): New static function.
4783 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4784 and widening them to Lisp_Objects. This would work even if
4785 USE_LSB_TAG is defined and wide integers are used, which might
4786 happen in a future version of Emacs.
4788 2012-02-25 Chong Yidong <cyd@gnu.org>
4790 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4793 * xselect.c (Fx_selection_exists_p): Doc fix.
4794 (x_clipboard_manager_save_all): Print an informative message
4795 before saving to clipboard manager.
4797 2012-02-24 Chong Yidong <cyd@gnu.org>
4799 * keyboard.c (process_special_events): Handle all X selection
4800 requests in kbd_buffer, not just the next one (Bug#8869).
4802 2012-02-23 Chong Yidong <cyd@gnu.org>
4804 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4805 call when setting menu-bar-lines and tool-bar-lines parameters.
4806 (unwind_create_frame_1): New helper function.
4808 * window.c (inhibit_window_configuration_change_hook): New var.
4809 (run_window_configuration_change_hook): Obey it.
4810 (syms_of_window): Initialize it.
4812 2012-02-22 Chong Yidong <cyd@gnu.org>
4814 * xterm.c (x_draw_image_relief): Add missing type check for
4815 Vtool_bar_button_margin (Bug#10743).
4817 2012-02-21 Chong Yidong <cyd@gnu.org>
4819 * fileio.c (Vfile_name_handler_alist): Doc fix.
4821 * buffer.c (Fget_file_buffer): Protect against invalid file
4822 handler return value.
4824 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4826 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4827 when computing $valmask.
4829 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4830 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4831 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4832 It's useless in that case, and it can cause problems on hosts
4833 that allocate halves of EMACS_INT values separately.
4834 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4835 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4836 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4837 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4838 it avoids undefined behavior on hosts where shifting right by more
4839 than the word width has undefined behavior.
4841 2012-02-19 Chong Yidong <cyd@gnu.org>
4843 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4844 (Funhandled_file_name_directory, Ffile_name_as_directory)
4845 (Fdirectory_file_name, Fexpand_file_name)
4846 (Fsubstitute_in_file_name): Protect against invalid file handler
4847 return values (Bug#10845).
4849 2012-02-18 Eli Zaretskii <eliz@gnu.org>
4851 * .gdbinit (pitx): Fix incorrect references to fields of the
4854 2012-02-17 Chong Yidong <cyd@gnu.org>
4856 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4858 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4860 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4861 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4863 2012-02-15 Chong Yidong <cyd@gnu.org>
4865 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4866 marked as special. Also, starting docstrings with * is obsolete.
4868 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4870 * gnutls.c (emacs_gnutls_write): Fix last change.
4872 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4874 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4877 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4879 * keymap.c (Fsingle_key_description): Handle char ranges.
4881 2012-02-12 Chong Yidong <cyd@gnu.org>
4883 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4884 as that creates a dangerous corner case.
4886 * window.c (Fdelete_window_internal): Invalidate the mouse
4887 highlight (Bug#9904).
4889 2012-02-12 Glenn Morris <rgm@gnu.org>
4891 * xselect.c (Fx_own_selection_internal)
4892 (Fx_get_selection_internal, Fx_disown_selection_internal)
4893 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4894 * nsselect.m (Fx_own_selection_internal)
4895 (Fx_disown_selection_internal, Fx_selection_exists_p)
4896 (Fx_selection_owner_p, Fx_get_selection_internal):
4897 Sync docs and argument specs with the xselect.c versions.
4899 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4901 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4903 2012-02-11 Eli Zaretskii <eliz@gnu.org>
4905 * w32select.c (Fx_selection_exists_p): Sync doc string and
4906 argument list with xselect.c. (Bug#10783)
4908 * w16select.c (Fx_selection_exists_p): Sync doc string and
4909 argument list with xselect.c. (Bug#10783)
4911 2012-02-10 Glenn Morris <rgm@gnu.org>
4913 * fns.c (Fsecure_hash): Doc fix.
4915 2012-02-09 Kenichi Handa <handa@m17n.org>
4917 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4919 2012-02-07 Chong Yidong <cyd@gnu.org>
4921 * buffer.c (Fbuffer_local_variables)
4922 (buffer_lisp_local_variables): Handle unbound vars correctly;
4923 don't let Qunbound leak into Lisp.
4925 2012-02-07 Glenn Morris <rgm@gnu.org>
4927 * image.c (Fimagemagick_types): Doc fix.
4929 * image.c (imagemagick-render-type): Change it from a lisp object
4930 to an integer. Move the doc here from the lisp manual.
4931 Treat all values not equal to 0 the same.
4933 2012-02-06 Chong Yidong <cyd@gnu.org>
4935 * doc.c (store_function_docstring): Avoid applying docstring of
4936 alias to base function (Bug#2603).
4938 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4940 * .gdbinit (pp1, pv1): Remove redundant defines.
4943 2012-02-04 Chong Yidong <cyd@gnu.org>
4945 * nsterm.m: Declare a global (Bug#10694).
4947 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4949 * w32.c (get_emacs_configuration_options):
4950 Include --enable-checking, if specified, in the return value.
4952 2012-02-04 Martin Rudalics <rudalics@gmx.at>
4954 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4955 after rounding frame sizes. (Bug#9723)
4957 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4959 * keyboard.c (adjust_point_for_property): Don't position point
4960 before BEGV. (Bug#10696)
4962 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4964 Handle overflow when computing char display width (Bug#9496).
4965 * character.c (char_width): Return EMACS_INT, not int.
4966 (char_width, c_string_width): Check for overflow when
4967 computing the width; this is possible now that individual
4968 characters can have unbounded width. Problem introduced
4969 by merge from Emacs 23 on 2012-01-19.
4971 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
4973 * dbusbind.c (Fdbus_register_method): Mention the return value
4974 :ignore in the docstring.
4976 2012-02-02 Glenn Morris <rgm@gnu.org>
4978 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4980 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4981 Unconditionally set to t. (Bug#10673)
4982 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4983 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4984 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4986 2012-02-02 Kenichi Handa <handa@m17n.org>
4988 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4989 0, do not call append_composite_glyph.
4991 2012-02-02 Kenichi Handa <handa@m17n.org>
4993 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4995 (x_produce_glyphs): If the component of a composition is a null
4996 string, set it->pixel_width to 1 to avoid zero-width glyph.
4998 2012-02-01 Eli Zaretskii <eliz@gnu.org>
5000 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5001 first 2 arguments are identical. This makes inserting large
5002 output from a subprocess an order of magnitude faster on
5003 MS-Windows, where all sbrk'ed memory is always contiguous.
5005 2012-01-31 Glenn Morris <rgm@gnu.org>
5007 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5008 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5009 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5011 2012-01-29 Glenn Morris <rgm@gnu.org>
5013 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5015 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5017 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5019 2012-01-28 Chong Yidong <cyd@gnu.org>
5021 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5023 2012-01-26 Chong Yidong <cyd@gnu.org>
5025 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5027 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5028 repeat counts (Bug#10507).
5030 2012-01-26 Glenn Morris <rgm@gnu.org>
5032 * lread.c (syms_of_lread): Doc fix.
5034 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5036 * coding.c (encode_designation_at_bol): Change return value to
5039 2012-01-25 Chong Yidong <cyd@gnu.org>
5041 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5043 2012-01-21 Chong Yidong <cyd@gnu.org>
5045 * floatfns.c (Fcopysign): Make the second argument non-optional,
5046 since nil is not allowed anyway.
5048 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5050 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5051 (send_process): Likewise.
5053 2012-01-19 Martin Rudalics <rudalics@gmx.at>
5055 * window.c (save_window_save, Fcurrent_window_configuration)
5056 (Vwindow_persistent_parameters): Do not use Qstate.
5057 Rewrite doc-strings.
5059 2012-01-19 Kenichi Handa <handa@m17n.org>
5061 * character.c (char_width): New function.
5062 (Fchar_width, c_string_width, lisp_string_width):
5063 Use char_width (Bug#9496).
5065 2012-01-16 Martin Rudalics <rudalics@gmx.at>
5067 * window.c (Vwindow_persistent_parameters): New variable.
5068 (Fset_window_configuration, save_window_save): Handle persistent
5071 2012-01-14 Eli Zaretskii <eliz@gnu.org>
5073 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5074 thrashing the stack of the thread. (Bug#9087)
5076 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5078 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5080 2012-01-11 Eli Zaretskii <eliz@gnu.org>
5082 * xdisp.c (rows_from_pos_range): Handle the case where the
5083 highlight ends on a newline. (Bug#10464)
5084 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5085 he end column for display of highlight that ends on a newline
5088 2012-01-11 Glenn Morris <rgm@gnu.org>
5090 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5091 from load-path also when installation-directory is nil. (Bug#10208)
5093 2012-01-10 Glenn Morris <rgm@gnu.org>
5095 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5097 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5098 Update template values to be closer to their typical values these days.
5100 2012-01-09 Eli Zaretskii <eliz@gnu.org>
5102 * xdisp.c (rows_from_pos_range): Accept additional argument
5103 DISP_STRING, and accept any glyph in a row whose object is that
5104 string as eligible for mouse highlight. Fixes mouse highlight of
5105 display strings from overlays. (Bug#10464)
5107 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
5109 emacs: fix an auto-save permissions race condition (Bug#10400)
5110 * fileio.c (auto_saving_dir_umask): New static var.
5111 (Fmake_directory_internal): Use it.
5112 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5113 creating the directory. The old code temporarily assigns
5114 too-generous permissions to the directory.
5115 (do_auto_save_eh): Clear it.
5116 (Fdo_auto_save): Catch all errors, not just file errors, so
5117 that the var is always cleared.
5119 2012-01-07 Eli Zaretskii <eliz@gnu.org>
5121 * search.c (scan_buffer): Pass character positions to
5122 know_region_cache, not byte positions. (Bug#6540)
5124 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
5126 * w32.c (sys_rename): Report EXDEV when rename of a directory
5127 fails because the target is on another logical disk. (Bug#10284)
5129 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5131 * xterm.c (x_embed_request_focus): New function.
5133 * xterm.h: Add prototype.
5135 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5137 2012-01-05 Glenn Morris <rgm@gnu.org>
5139 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5141 2012-01-01 Eli Zaretskii <eliz@gnu.org>
5143 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5144 Load gnutls_transport_set_lowat only if GnuTLS version is below
5146 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5147 GnuTLS versions below 2.11.1.
5149 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5151 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5152 to the doc string advising against its use for altering the way
5153 windows are scrolled.
5155 2011-12-28 Kenichi Handa <handa@m17n.org>
5157 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5158 coding-system ASCII compatible only when it does not produce BOM
5159 on encoding (Bug#10383).
5161 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5163 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5165 (create_and_show_popup_menu): Always use menu_position_func for
5168 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5170 * callint.c (Fcall_interactively): Don't truncate prompt string.
5172 2011-12-23 Eli Zaretskii <eliz@gnu.org>
5174 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5175 property that ends at ZV, so that the bidi iteration could be
5176 resumed from there (after widening). (Bug#10360)
5178 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5180 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5182 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5184 * nsterm.m (x_free_frame_resources):
5185 Release f->output_data.ns->miniimage.
5186 (ns_index_color): Fix indentation. Do not retain
5187 color_table->colors[i].
5189 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5192 * nsfns.m (x_set_background_color): Assign return value from
5193 ns_index_color to face-background instead of NSColor*.
5194 (ns_implicitly_set_icon_type): Fix indentation.
5195 Change assignment in for loop to comparison.
5197 * emacs.c (ns_pool): New variable.
5198 (main): Assign ns_pool.
5199 (Fkill_emacs): Call ns_release_autorelease_pool.
5201 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5202 autorelease fdesc, release fdAttrs and tdict.
5203 (ns_get_covering_families): Release charset.
5204 (ns_findfonts): Release NSFontDescriptor created with new.
5205 (ns_uni_to_glyphs): Fix indentation.
5206 (setString): Release attrStr before assigning new value.
5208 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5210 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5212 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5213 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5215 2011-12-18 David Reitter <reitter@cmu.edu>
5217 * nsterm.m (ns_term_init): Subscribe for notifications
5218 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5219 to method trackingNotification in EmacsMenu.
5221 * nsmenu.m (trackingMenu): New variable.
5222 (trackingNotification): New method (from Aquamacs).
5223 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
5224 from Aquamacs (Bug#7030).
5226 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5228 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5229 (symbol_to_nsstring): Fix indentation.
5230 (ns_symbol_to_pb): New function.
5231 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5232 (Fns_rotate_cut_buffers_internal): Remove.
5233 (Fns_store_selection_internal): Rename from
5234 Fns_store_cut_buffer_internal.
5235 (ns_get_foreign_selection, Fx_own_selection_internal)
5236 (Fx_disown_selection_internal, Fx_selection_exists_p)
5237 (Fns_get_selection_internal, Fns_store_selection_internal):
5238 Use ns_symbol_to_pb and check if return value is nil.
5239 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5240 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
5241 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5242 renamed to Sns_store_selection_internal.
5243 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5244 and remove this function.
5245 (ns_handle_selection_clear): Remove, never used.
5246 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5249 2011-12-17 Ken Brown <kbrown@cornell.edu>
5251 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5252 GID is unknown (Bug#10257).
5254 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5256 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5257 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5258 which caused a build failure on GNU/Linux IA-64. This problem was
5259 introduced by my 2011-10-07 patch.
5261 2011-12-15 Juri Linkov <juri@jurta.org>
5263 * image.c (imagemagick_error): New function. (Bug#10112)
5264 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5265 Use `imagemagick_error' where ImageMagick functions return
5267 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5270 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5272 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5273 fill background (Bug#8992).
5275 2011-12-13 Martin Rudalics <rudalics@gmx.at>
5277 * window.c (Vwindow_combination_resize)
5278 (Vwindow_combination_limit): Use t instead of non-nil in
5280 (Vrecenter_redisplay): Add first sentence of doc-string on
5282 (Frecenter): Fix doc-string typo.
5284 2011-12-11 Kenichi Handa <handa@m17n.org>
5286 * coding.c (Funencodable_char_position): Pay attention to the
5287 buffer text relocation (Bug#9389).
5289 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5291 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5292 gtk_init (Bug#10100).
5294 2011-12-10 Eli Zaretskii <eliz@gnu.org>
5296 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5297 IT->string is nil. (Bug#10263)
5299 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5301 * nsterm.h (x_free_frame_resources): Declare.
5303 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5304 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5306 * nsterm.h (ns_get_defaults_value): Declare.
5308 * nsterm.m (ns_default): Call ns_get_defaults_value.
5310 2011-12-09 Eli Zaretskii <eliz@gnu.org>
5312 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5315 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5317 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5318 that where the value of an _OBJC_* symbol points to is in the .bss
5319 section (Bug#10240).
5321 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5323 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
5324 after the loop to call ccl_driver at least once (Bug#8619).
5326 2011-12-08 Kenichi Handa <handa@m17n.org>
5328 * ftfont.c (get_adstyle_property): Fix previous change
5331 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
5333 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5334 dirs from the default value of EMACSLOADPATH (bug#10208).
5336 2011-12-07 Glenn Morris <rgm@gnu.org>
5338 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5339 installation and source directories as well. (Bug#10208)
5341 2011-12-06 Chong Yidong <cyd@gnu.org>
5343 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5345 2011-12-06 Glenn Morris <rgm@gnu.org>
5347 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5348 as an error, not just -1. (Bug#10217)
5350 2011-12-05 Chong Yidong <cyd@gnu.org>
5352 * keyboard.c (process_special_events): New function.
5353 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5355 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5357 * coding.c (encode_designation_at_bol): Don't use uninitialized
5358 local variable (Bug#9318).
5360 2011-12-05 Kenichi Handa <handa@m17n.org>
5362 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5363 return Qnil (Bug#8046, Bug#10193).
5365 2011-12-05 Kenichi Handa <handa@m17n.org>
5367 * coding.c (encode_designation_at_bol): New args charbuf_end and
5368 dst. Return the number of produced bytes. Callers changed.
5369 (coding_set_source): Return how many bytes coding->source was
5371 (coding_set_destination): Return how many bytes
5372 coding->destination was relocated.
5373 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
5374 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5376 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5378 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5379 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5382 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5384 The following changes are to fix Bug#9318.
5386 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5387 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5388 (encode_coding_iso_2022, encode_coding_sjis)
5389 (encode_coding_big5, encode_coding_charset): Use the above macros.
5391 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
5393 * lisp.h (process_quit_flag): Fix external declaration.
5395 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5397 Don't macro-inline non-performance-critical code.
5398 * eval.c (process_quit_flag): New function.
5399 * lisp.h (QUIT): Use it.
5401 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5403 * nsfns.m (get_geometry_from_preferences): New function.
5404 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5406 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5408 * emacs.c (Qkill_emacs): Define.
5409 (syms_of_emacs): Initialize it.
5410 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5411 Qquit_flag to `kill-emacs' instead.
5412 (quit_throw_to_read_char): Add parameter `from_signal'.
5413 All callers changed. Call Fkill_emacs if requested and safe.
5414 * lisp.h (QUIT): Call Fkill_emacs if requested.
5416 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5418 * widget.c (update_wm_hints): Return if wmshell is null.
5419 (widget_update_wm_size_hints): New function.
5421 * widget.h (widget_update_wm_size_hints): Declare.
5423 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5424 widget_update_wm_size_hints (Bug#10104).
5426 2011-12-03 Eli Zaretskii <eliz@gnu.org>
5428 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5429 before a newline, prepare the bidi iterator for consuming the
5430 newline, and keep the current paragraph direction. (Bug#10183)
5431 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
5433 2011-12-02 Juri Linkov <juri@jurta.org>
5435 * search.c (Fword_search_regexp): New Lisp function created from
5436 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5437 (Fword_search_backward, Fword_search_forward)
5438 (Fword_search_backward_lax, Fword_search_forward_lax):
5439 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5440 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5442 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5444 * fileio.c (Finsert_file_contents): Move after-change-function call
5445 to before the "handled:" label, since all "goto handled" appear in
5446 cases where the *-change-functions have already been properly called
5449 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5451 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5452 waiting for input. (Bug#10169)
5454 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5456 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5457 verifies glyph row's hash code--we have just reallocated the
5458 glyphs, so their contents can be complete garbage. (Bug#10164)
5460 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
5462 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5464 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5466 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5467 attributes are tested _before_ calling verify_row_hash, to protect
5468 against GCC re-ordering of the tests. (Bug#10164)
5470 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5472 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5474 * xterm.c (handle_one_xevent): Only set async_visible and friends
5475 if net_wm_state_hidden_seen is non-zero (Bug#10002)
5476 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
5477 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5479 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5481 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5482 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5483 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5484 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5485 All uses changed to use GCPRO1 etc.
5486 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5487 Revert to old implementation (i.e., before 2011-03-11).
5489 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5491 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5492 of scroll runs so as to avoid assigning disabled bogus rows and
5493 unnecessary graphics copy operations.
5495 2011-11-27 Eli Zaretskii <eliz@gnu.org>
5497 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5498 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5499 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5500 (malloc, free, realloc, calloc): Redirect to e_* only when
5503 * lisp.h (GCTYPEBITS): Move before first use.
5504 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5505 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5506 this macro definition.
5508 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5511 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5513 * gtkutil.c (xg_create_frame_widgets):
5514 Call gtk_window_set_has_resize_grip (FALSE) if that function is
5515 present with Gtk+ 2.0.
5517 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5519 * fileio.c (Finsert_file_contents): Undo previous change; see
5520 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5522 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5524 Rename locals to avoid shadowing.
5525 * fileio.c (Finsert_file_contents):
5526 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5527 * process.c (wait_reading_process_output):
5528 Rename inner 'proc' to 'p' to avoid shadowing.
5529 Indent for consistency with usual Emacs style.
5531 2011-11-25 Eli Zaretskii <eliz@gnu.org>
5533 * xdisp.c (redisplay_window): If cursor row is not fully visible
5534 after recentering, and scroll-conservatively is set to a large
5535 number, scroll window by a few more lines to make the cursor fully
5536 visible and out of scroll-margin. (Bug#10105)
5537 (start_display): Don't move to the next line if the display should
5538 start at a newline that is part of a display vector or an overlay
5541 2011-11-24 Juri Linkov <juri@jurta.org>
5543 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5544 after the `MagickPingImage' call. (Bug#10112)
5546 2011-11-23 Chong Yidong <cyd@gnu.org>
5548 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5550 2011-11-23 Martin Rudalics <rudalics@gmx.at>
5552 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5553 making another buffer current. (Bug#10114)
5555 2011-11-23 Glenn Morris <rgm@gnu.org>
5557 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5559 2011-11-23 Chong Yidong <cyd@gnu.org>
5561 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5562 using it (Bug#5984).
5564 2011-11-22 Eli Zaretskii <eliz@gnu.org>
5566 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5567 and header-lines, as they don't have one computed for them.
5570 * .gdbinit (prow): Make displayed values more self-explaining.
5571 Add row's hash code.
5573 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5575 * process.c (wait_reading_process_output): Fix asynchrounous
5576 GnuTLS socket handling on some versions of the GnuTLS library.
5577 (wait_reading_process_output): Add comment and URL.
5579 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5581 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5583 2011-11-21 Chong Yidong <cyd@gnu.org>
5585 * window.c (Fnext_window, Fprevious_window): Doc fix.
5587 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5589 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5591 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5593 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5595 2011-11-20 Martin Rudalics <rudalics@gmx.at>
5597 * window.c (Fset_window_combination_limit): Rename argument
5599 (Vwindow_combination_limit): Remove "status" from doc-string.
5601 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5603 * m/ibms390.h: Remove.
5604 * m/ibms390x.h: Don't include "ibms390.h".
5606 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5608 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5609 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5611 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5613 * casetab.c (Fset_case_table):
5614 * charset.c (Fcharset_after): Fix typos.
5616 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
5618 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5619 Otherwise, valgrind does not work on some platforms.
5620 Problem reported by Andreas Schwab in
5621 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5622 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5623 is set, removing the need for VIRT_ADDRESS_VARIES.
5624 (PURE_P): Use a more-efficient implementation that needs just one
5625 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5626 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5627 to 4 (xorl, subq, cmpq, setbe).
5628 * alloc.c (pure): Always extern now, since that's the
5629 VIRT_ADDR_VARIES behavior.
5630 (PURE_POINTER_P): Use a single comparison, not two, for
5631 consistency with the new puresize.h.
5632 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5633 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5634 Remove VIRT_ADDR_VARIES no longer needed.
5636 2011-11-19 Eli Zaretskii <eliz@gnu.org>
5638 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5639 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5640 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5641 behave as if the cursor position were at the window margin.
5643 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5644 and the cursor position is out of bounds, behave as if the cursor
5645 position were at the window margin. (Bug#10075)
5647 2011-11-18 Chong Yidong <cyd@gnu.org>
5649 * window.c (Fwindow_combination_limit): Make first argument
5650 non-optional, since it is meaningless for live windows like the
5653 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5655 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5657 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5659 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5660 (graft_intervals_into_buffer): Simplify.
5662 2011-11-18 Eli Zaretskii <eliz@gnu.org>
5664 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5665 hash values of the two rows.
5666 (copy_row_except_pointers): Preserve the used[] arrays and the
5667 hash values of the two rows. (Bug#10035)
5668 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
5670 * xdisp.c (row_hash): New function, body extracted from
5671 compute_line_metrics.
5672 (compute_line_metrics): Call row_hash, instead of computing the
5675 * dispnew.c (verify_row_hash): Call row_hash for computing the
5676 hash code of a row, instead of duplicating code from xdisp.c.
5678 * dispextern.h (row_hash): Add prototype.
5680 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5682 * frame.c (delete_frame): Don't delete the terminal when the last
5683 X frame is closed if emacs is built with GTK toolkit.
5685 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
5687 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5689 2011-11-17 Martin Rudalics <rudalics@gmx.at>
5691 * window.c (Vwindow_splits): Rename to
5692 Vwindow_combination_resize. Suggested by Juri Linkov.
5693 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5696 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
5698 * nsfns.m (Fns_font_name):
5699 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
5701 2011-11-16 Martin Rudalics <rudalics@gmx.at>
5703 * window.h (window): Rename slot "nest" to "combination_limit".
5704 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5705 (Fset_window_nest): Rename to Fset_window_combination_limit.
5706 (Vwindow_nest): Rename to Vwindow_combination_limit.
5707 (recombine_windows, make_parent_window, make_window)
5708 (Fsplit_window_internal, saved_window)
5709 (Fset_window_configuration, save_window_save): Rename all
5710 occurrences of window_nest to window_combination_limit.
5712 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
5714 * image.c (imagemagick_load_image): Fix typo.
5716 2011-11-14 Eli Zaretskii <eliz@gnu.org>
5718 * xdisp.c (display_line): Move the call to
5719 highlight_trailing_whitespace before the call to
5720 compute_line_metrics, since the latter needs to see the final
5721 faces of all the glyphs to compute ROW's hash value.
5722 Fixes assertion violations in row_equal_p. (Bug#10035)
5724 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
5726 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5727 just return (bug#10044).
5729 2011-11-12 Eli Zaretskii <eliz@gnu.org>
5731 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5732 with user-defined heap size. Bump the default size of the temacs
5733 heap to 27MB, to avoid memory warning when running temacs.
5734 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5736 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5737 current_matrix and desired_matrix. (Bug#9990)
5738 (verify_row_hash) [XASSERTS]: New function.
5739 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5740 that the hash value of glyph rows is correct.
5742 2011-11-12 Martin Rudalics <rudalics@gmx.at>
5744 * window.h (window): Remove splits slot.
5745 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5746 (Fdelete_other_windows_internal, make_parent_window)
5747 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5748 (Fset_window_configuration, save_window_save): Don't deal with
5749 split status of windows.
5750 (saved_window): Remove splits slot.
5751 (Vwindow_splits): Rewrite doc-string.
5753 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5755 * xfns.c (unwind_create_frame):
5756 * nsfns.m (unwind_create_frame):
5757 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5758 Vframe_list (Bug#9999).
5760 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5762 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
5764 2011-11-11 Kenichi Handa <handa@m17n.org>
5766 * callproc.c (Fcall_process): Set the member dst_multibyte of
5769 2011-11-11 Johan Bockgård <bojohan@gnu.org>
5771 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5772 avoid a crash (bug#9496).
5774 2011-11-09 Chong Yidong <cyd@gnu.org>
5776 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5777 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5779 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5781 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5783 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5785 Avoid some portability problems by eschewing 'extern inline' functions.
5786 The trivial performance wins aren't worth the portability hassles; see
5787 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5789 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5790 (window_box_width, window_box_left, window_box_left_offset)
5791 (window_box_right, window_box_right_offset): Undo previous change,
5792 by removing the "extern"s.
5793 * intervals.c (adjust_intervals_for_insertion)
5794 (adjust_intervals_for_deletion): Undo previous change,
5795 making these static again.
5796 (offset_intervals, temp_set_point_both, temp_set_point)
5797 (copy_intervals_to_string): No longer inline.
5798 * xdisp.c (window_text_bottom_y, window_box_width)
5799 (window_box_height, window_box_left_offset)
5800 (window_box_right_offset, window_box_left, window_box_right)
5801 (window_box): No longer inline.
5803 2011-11-08 Chong Yidong <cyd@gnu.org>
5805 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
5806 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5807 Signal an error if not a live window.
5808 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5809 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5811 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
5813 * lisp.h (syms_of_abbrev): Remove declaration.
5814 Reported by CHENG Gao <chenggao@royau.me>.
5816 2011-11-07 Eli Zaretskii <eliz@gnu.org>
5818 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5819 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5820 of temacs in GUI mode.
5822 2011-11-07 Martin Rudalics <rudalics@gmx.at>
5824 * window.h: Declare delete_all_child_windows instead of
5825 delete_all_subwindows.
5826 * window.c (Fwindow_nest, Fset_window_nest)
5827 (Fset_window_new_total, Fset_window_new_normal)
5828 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5829 (delete_all_subwindows): Rename to delete_all_child_windows.
5830 (Fdelete_other_windows_internal, Fset_window_configuration):
5831 Call delete_all_child_windows instead of delete_all_subwindows.
5832 * frame.c (delete_frame): Call delete_all_child_windows instead
5833 of delete_all_subwindows.
5835 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5837 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5838 This is also needed for porting to any host where GC_MARK_STACK is
5839 not GC_MAKE_GCPROS_NOOPS.
5840 (which_symbols): Use it.
5842 2011-11-07 Kenichi Handa <handa@m17n.org>
5844 * coding.c (coding_set_destination): Check coding->src_pos only
5845 when coding->src_object is a buffer (bug#9910).
5847 * process.c (send_process): Set the member src_multibyte of coding
5848 to 0 (bug#9911) when sending a unibyte text.
5850 * callproc.c (Fcall_process): Set the member src_multibyte of
5851 process_coding to 0 (bug#9912).
5853 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5855 * xmenu.c (cleanup_widget_value_tree): New function.
5856 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5857 calling free_menubar_widget_value_tree directly (Bug#9830).
5859 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5861 Fix some portability problems with 'inline'.
5862 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5863 (window_box_width, window_box_left, window_box_left_offset)
5864 (window_box_right, window_box_right_offset): Declare extern.
5865 Otherwise, these inline functions do not conform to C99 and
5866 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5867 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5868 * intervals.c (adjust_intervals_for_insertion)
5869 (adjust_intervals_for_deletion): Now extern, because otherwise the
5870 extern inline functions 'offset_intervals' couldn't refer to it.
5871 (static_offset_intervals): Remove.
5872 (offset_intervals): Rewrite using the old contents of
5873 static_offset_intervals. The old version didn't conform to C99
5874 because an extern inline function contained a reference to an
5875 identifier with static linkage.
5877 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5879 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5882 2011-11-06 Eli Zaretskii <eliz@gnu.org>
5884 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5885 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5886 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5887 return Qleft_to_right.
5889 2011-11-06 Chong Yidong <cyd@gnu.org>
5891 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5892 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5893 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5894 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5895 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5896 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5897 (Fwindow_vscroll): Doc fix.
5898 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5899 argument, since it makes no sense to pass a live window and for
5900 consistency with window-child.
5902 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5904 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5907 2011-11-05 Jason Rumney <jasonr@gnu.org>
5909 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5910 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5912 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5913 bitwise arithmetic preventing use of unicode-sip and non-truetype
5916 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5918 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5921 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5922 initialization code to keep similarity to xfns.c after changes
5925 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5927 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5928 (unwind_create_frame): New function (Bug#9943).
5929 (Fx_create_frame): Restructure code to be more similar to the one in
5930 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5931 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5932 Move terminal->reference_count++ just before making the frame official
5935 * nsterm.m (x_free_frame_resources): New function.
5936 (x_destroy_window): Move code to x_free_frame_resources.
5938 * xfns.c (unwind_create_frame): Fix comment.
5939 (Fx_create_frame, x_create_tip_frame):
5940 Move terminal->reference_count++ just before making the frame
5941 official. Move initialization of image_cache_refcount and
5942 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5944 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5946 Support MSVC build with newer versions of Visual Studio.
5947 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5948 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5951 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5952 which are not supported by MSVC.
5953 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5954 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5956 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5958 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5960 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5962 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
5964 Support MSVC build with newer versions of Visual Studio.
5965 * w32.c: Don't include w32api.h for MSVC.
5966 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5968 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5969 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5970 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5971 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5973 (alloca) [_MSC_VER]: Define to _alloca.
5975 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5977 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5979 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5981 * xdisp.c (note_mouse_highlight): If either of
5982 previous/next-single-property-change returns nil, treat that as
5983 the beginning or the end of the buffer. (Bug#9955)
5985 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5987 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
5988 label is not null (Bug#9951).
5989 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5992 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5994 * window.c (Fwindow_body_size): Mention in the doc string that the
5995 return value is in frame's canonical units. (Bug#9949)
5997 2011-11-03 Eli Zaretskii <eliz@gnu.org>
5999 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6001 * w32fns.c (unwind_create_frame): If needed, free the glyph
6002 matrices of the partially constructed frame. (Bug#9943)
6003 * xfns.c (unwind_create_frame): Likewise.
6005 2011-11-01 Eli Zaretskii <eliz@gnu.org>
6007 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6008 Don't stop backward scan on the continuation glyph, even though
6009 its CHARPOS is positive.
6010 (mouse_face_from_buffer_pos, note_mouse_highlight):
6011 Rename cover_string to disp_string.
6013 2011-11-01 Martin Rudalics <rudalics@gmx.at>
6015 * window.c (temp_output_buffer_show): Don't use
6016 Vtemp_buffer_show_specifiers.
6017 (Vtemp_buffer_show_specifiers): Remove unused variable.
6019 2011-10-30 Eli Zaretskii <eliz@gnu.org>
6021 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6022 past the beginning of the current glyph matrix.
6024 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6026 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6027 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6028 HAVE_GTK3 (Bug#9869).
6030 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6031 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6033 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6035 * xterm.c: Declare x_handle_net_wm_state to return int.
6036 (handle_one_xevent): Check if we are iconified but don't have
6037 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6038 (get_current_wm_state): Return non-zero if not hidden,
6039 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6040 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6041 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6042 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6044 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6046 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6047 so that this new function doesn't get optimized away by a
6048 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6050 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6052 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6054 2011-10-29 Eli Zaretskii <eliz@gnu.org>
6056 Fix the `xbytecode' command.
6057 * .gdbinit (xprintbytestr): New command.
6058 (xwhichsymbols): Rename from `which'; all callers changed.
6059 (xbytecode): Print the byte-code string as well.
6061 2011-10-29 Kim Storm <storm@cua.dk>
6063 * alloc.c (which_symbols): New function.
6065 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6067 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6070 2011-10-29 Glenn Morris <rgm@gnu.org>
6072 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6073 Not clear what it was for, and it causes various bugs. (Bug#9839)
6075 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6077 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6078 possible random value that matches one of those tested as
6079 condition to clear the mouse face.
6081 2011-10-28 Chong Yidong <cyd@gnu.org>
6083 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6085 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6087 * window.c (make_window): Initialize phys_cursor_on_p.
6089 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6091 * lisp.h (struct Lisp_Symbol): Update comments.
6093 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
6095 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6097 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6099 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6100 <oslsachem@gmail.com> for helping to debug this.
6102 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6103 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6104 (g_b_init_get_glyph_outline_w): New static variables.
6105 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6106 (GetGlyphOutlineW_Proc): New typedefs.
6107 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
6108 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6110 (w32font_open_internal, compute_metrics):
6111 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
6112 instead of calling the "wide" APIs directly.
6114 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6116 * w32.h (syms_of_w32font): Add prototype.
6118 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6120 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6121 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6122 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6123 (Fmove_to_window_line): Doc fix.
6125 2011-10-27 Chong Yidong <cyd@gnu.org>
6127 * process.c (make_process): Set gnutls_state to NULL.
6129 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6130 non-NULL, regardless of GNUTLS_INITSTAGE.
6131 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6132 an error. Set process slots as soon as we allocate them.
6134 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6136 2011-10-27 Chong Yidong <cyd@gnu.org>
6138 * gnutls.c (emacs_gnutls_deinit): New function.
6139 Deallocate credentials structures as well as calling gnutls_deinit.
6140 (Fgnutls_deinit, Fgnutls_boot): Use it.
6142 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6143 (deactivate_process): Call emacs_gnutls_deinit.
6145 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6147 * image.c (x_create_x_image_and_pixmap):
6148 * w32.c (sys_rename, w32_delayed_load):
6149 * w32font.c (fill_in_logfont):
6150 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6152 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
6154 * w32fns.c (w32_default_color_map): New function,
6155 extracted from Fw32_default_color_map.
6156 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
6158 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6160 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6162 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6164 * keyboard.c (test_undefined): New function (bug#9751).
6165 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6167 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6169 * sysdep.c (init_sys_modes): Fix the check for the controlling
6170 terminal (Bug#6649).
6172 2011-10-20 Eli Zaretskii <eliz@gnu.org>
6174 * dispextern.h (struct bidi_it): New member next_en_type.
6176 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6177 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6178 current character, check also for next_en_type being WEAK_EN.
6179 (bidi_resolve_weak): Don't enter the expensive loop if the current
6180 position is before next_en_pos. Record the bidi type of the first
6181 non-ET, non-BN character we find, in addition to its position.
6182 (bidi_level_of_next_char): Invalidate next_en_type when
6183 next_en_pos is over-stepped.
6185 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6187 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6188 * editfns.c: Rewrite current-time-zone so that it invokes
6189 the equivalent of (format-time-string "%Z") to get the time zone name.
6190 This fixes a bug when the time zone name contains characters that
6191 need converting from the system time locale to Emacs internal format.
6192 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6193 that patch fixed format-time-string to do the conversion, but
6194 I forgot to fix current-time-zone.
6195 (format_time_string): New function, containing most of
6196 what Fformat_time_string used to contain.
6197 (Fformat_time_string): Rewrite in terms of format_time_string.
6198 This doesn't change this function's behavior.
6199 (current-time-zone): Rewrite to use format_time_string.
6200 This fixes the bug reported by Michael Schierl in
6201 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6202 Jason Rumney's 2007-06-07 change worked around this bug, but
6204 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6206 2011-10-19 Eli Zaretskii <eliz@gnu.org>
6208 * xdisp.c (start_display): If the character at POS is displayed
6209 via a display vector, reset IT->current.dpvec_index to zero.
6210 (try_window_reusing_current_matrix): If a line ends in a display
6211 vector or the next line starts in a display vector, continue
6212 redrawing the window even though the character position of
6213 start_row was reached.
6216 2011-10-18 Chong Yidong <cyd@gnu.org>
6218 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6219 with nobreak-char-display too.
6221 2011-10-18 Eli Zaretskii <eliz@gnu.org>
6223 Fix part 3 of bug#9771.
6224 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6225 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6226 non-neutral characters if the current character is a paragraph
6227 separator (a.k.a. Newline). This avoids running the same
6228 expensive loop twice, once when we consume the preceding newline
6229 and the other time when the line actually needs to be displayed.
6230 Avoid the loop when we see neutrals on the base embedding level
6231 following a character whose directionality is the same as the
6232 paragraph's. This avoids running the expensive loop when a line
6233 ends in a long sequence of neutrals, like control characters.
6234 Add assertion against STRONG_AL type. Slightly rearrange code
6235 that determines the type of a neutral given the first non-neutral
6237 (bidi_level_of_next_char): Set next_en_pos to zero when
6238 invalidating its info.
6240 2011-10-17 Eli Zaretskii <eliz@gnu.org>
6242 * xdisp.c (push_display_prop): Determine whether to record string
6243 or buffer position by IT->string, not by IT->method. Allow
6244 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
6245 (move_it_vertically_backward): Don't look for character position
6246 immediately after the newline when in a continuation line.
6249 2011-10-15 Martin Rudalics <rudalics@gmx.at>
6251 * window.c (coordinates_in_window): Rewrite and delabelize
6252 vertical border check. (Bug#5357) (Bug#9618)
6254 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6256 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6257 errors in XSetWindowBorder (bug#9310).
6259 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6261 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6262 avoid crash when xmalloc overrun checking is enabled.
6264 2011-10-13 Eli Zaretskii <eliz@gnu.org>
6266 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6267 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6268 cursor motion with <left> and <right> arrow keys.
6270 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6271 some callers set that themselves.
6273 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6275 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6276 display string and the previous row comes from the same string and
6277 is empty. (Bug#9739) (Bug#9738)
6279 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6281 * doc.c (get_doc_string): Encode file name (bug#9735).
6283 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6285 * bidi.c (bidi_level_of_next_char):
6286 * xdisp.c (get_visually_first_element): Remove old incorrect
6287 comments regarding the Unicode Line Separator character.
6289 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6291 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6293 * alloc.c (Fgc_status): Do not access beyond zombies array
6294 boundary if nzombies > MAX_ZOMBIES.
6295 * alloc.c (dump_zombies): Add missing format specifier.
6297 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6299 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6300 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6302 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6303 Some packages use them to denote characters with modifiers.
6305 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6307 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6308 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6309 matching a pp-number. Rename parameter var to var1.
6311 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6313 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6315 2011-10-08 Glenn Morris <rgm@gnu.org>
6317 * callint.c (Fcall_interactively): Give a more explicit error for the
6318 'c' case with a non-character input. (Bug#8479)
6320 2011-10-08 Eli Zaretskii <eliz@gnu.org>
6322 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6324 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6325 lines that are hscrolled on the left.
6327 * dispnew.c (buffer_posn_from_coords): Account for a possible
6328 presence of header-line. (Bug#4426)
6330 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6332 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6333 Don't advertise functionality which we discourage or doesn't work.
6335 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6337 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6338 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6339 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6340 this makes Emacs dump core during garbage collection on rare
6341 occasions. sizeof is obviously inferior to offsetof here, so
6342 stick with offsetof.
6343 (GC_POINTER_ALIGNMENT): New macro.
6344 (mark_memory): Omit 3rd (offset) arg; caller changed.
6345 Don't assume EMACS_INT alignment is the same as pointer alignment.
6347 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6349 * keyboard.c (read_key_sequence_remapped): New var.
6350 (read_key_sequence): Compute remapping in the right buffer.
6351 (command_loop_1): Use read_key_sequence's remapping directly.
6353 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6355 * dired.c (file_name_completion): Don't expand file name.
6356 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6357 before checking file name handler.
6359 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6360 they've been requested explicitly (bug#9591).
6362 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
6364 * keymap.c (Fsingle_key_description): Use make_specified_string
6365 instead of build_string to build string from push_key_description.
6368 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6370 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6371 This fixes a Y2038 bug on 64-bit hosts.
6372 * buffer.c (reset_buffer):
6373 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6374 (Fclear_buffer_auto_save_failure):
6375 Use 0, not -1, to represent an unset failure time, since time_t
6376 might not be signed.
6378 Remove dependency on glibc malloc internals.
6379 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6380 Move back here from lisp.h, but with their new implementations.
6381 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6382 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6383 * charset.c (charset_table_init): New static var.
6384 (syms_of_charset): Use it instead of xmalloc. This removes a
6385 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6386 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6387 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6388 Move back to alloc.c.
6389 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6390 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6392 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6394 * nsterm.m (windowDidResize): Call x_set_window_size only when
6395 ns_in_resize is true. Otherwise set pixelwidth/height and
6396 call change_frame_size (Bug#9628).
6398 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6400 Port --enable-checking=all to Fedora 14 x86-64.
6401 * charset.c (syms_of_charset): Also account for glibc malloc's
6402 internal overhead when calculating the initial malloc maximum.
6404 Port --enable-checking=all to Fedora 14 x86.
6405 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6407 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6408 (overrun_check_realloc, overrun_check_free):
6409 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6410 That way, xmalloc returns a properly-aligned pointer even if
6411 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6412 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6413 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6414 into account when calculating the initial malloc maximum.
6415 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6416 Move here from alloc.c, so that charset.c can use it too.
6417 Properly align; the old code wasn't right for common 32-bit hosts
6418 when configured with --enable-checking=all.
6419 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6420 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6422 2011-09-29 Eli Zaretskii <eliz@gnu.org>
6424 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
6427 2011-09-28 Eli Zaretskii <eliz@gnu.org>
6429 * xdisp.c (compute_display_string_end): If there's no display
6430 string at CHARPOS, return -1.
6432 * bidi.c (bidi_fetch_char): When compute_display_string_end
6433 returns a negative value, treat the character as a normal
6434 character not covered by a display string. (Bug#9624)
6436 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
6438 * lread.c (Fread_from_string): Fix typo in docstring.
6440 2011-09-27 Eli Zaretskii <eliz@gnu.org>
6442 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6443 newline, reseat the iterator instead of bidi-iterating there one
6444 character at a time. (Bug#9610)
6445 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6446 TO_CHARPOS if the bidi iterator is at base embedding level.
6448 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6450 * lread.c (readevalloop): Use correct code for NBSP.
6451 (read1): Likewise. (Bug#9608)
6453 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
6455 * dbusbind.c (Fdbus_register_signal): When service is not
6456 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6458 2011-09-25 Glenn Morris <rgm@gnu.org>
6460 * buffer.c (truncate-lines): Doc fix.
6462 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
6464 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6465 (Fset_window_next_buffers): Doc fix.
6467 2011-09-24 Glenn Morris <rgm@gnu.org>
6469 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6471 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6473 Fix minor problems found by static checking.
6474 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
6475 * indent.c (Fvertical_motion): Fix == vs = typo.
6477 2011-09-24 Eli Zaretskii <eliz@gnu.org>
6479 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6480 Default value is now t. Doc fix.
6482 * indent.c (Fvertical_motion): Compute and apply the overshoot
6483 logic when moving up, not only when moving down. Fix the
6484 confusing name and values of the it_overshoot_expected variable;
6485 logic changes accordingly. (Bug#9254) (Bug#9549)
6487 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6488 CHARPOS is covered by a display string which includes newlines.
6489 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6490 is covered by a display string with embedded newlines.
6492 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
6494 * dbusbind.c (Fdbus_register_signal): Add match rule to
6495 Vdbus_registered_objects_table. (Bug#9581)
6496 (Fdbus_register_method, Vdbus_registered_objects_table):
6499 2011-09-24 Jim Meyering <meyering@redhat.com>
6501 do not ignore write error for any output size
6502 The previous change was incomplete.
6503 While it makes emacs --batch detect the vast majority of stdout
6504 write failures, errors were still ignored whenever the output size is
6505 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6506 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6507 && echo FAIL: ignored write error
6508 FAIL: ignored write error
6509 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6510 && echo FAIL: ignored write error
6511 FAIL: ignored write error
6512 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6514 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6516 * emacs.c (Fkill_emacs): In noninteractive mode exit
6517 non-successfully if a write error occurred on stdout. (Bug#9574)
6519 2011-09-21 Eli Zaretskii <eliz@gnu.org>
6521 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6524 * dispextern.h (struct it): Update the comment documenting what
6527 2011-09-20 Eli Zaretskii <eliz@gnu.org>
6529 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6530 a display string, extend search for cursor position to end of row.
6531 (find_row_edges): If the row ends in a newline from a display
6532 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6533 Handle the case of a display string with multiple newlines.
6534 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6535 non-empty line. Fixes confusing cursor motion with arrow keys at
6536 the beginning of a line that starts with whitespace.
6538 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6540 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6543 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
6545 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6548 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6550 * xdisp.c (display_line): Record maximum and minimum buffer
6551 positions even if no glyphs were produced (e.g., by a zero-width
6552 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6553 buffer positions that will be removed from the glyph row because
6555 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6556 column is beyond frame width: don't subtract 1 "pixel" when
6557 computing width of the stretch.
6558 (reseat_at_next_visible_line_start): Undo the change made on
6559 2011-09-17 that saved paragraph information and restored it after
6560 the call to `reseat'. (Bug#9545)
6562 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6564 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6565 and turn window cursor on if cleared (Bug#9415).
6567 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
6569 * search.c (boyer_moore): Take unibyte characters from pattern
6570 literally. (Bug#9458)
6572 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6574 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6576 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6578 Fix minor problem found by static checking.
6579 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6580 initialized, to pacify gcc -Wuninitialized.
6582 * fileio.c: Report proper errno when syscall falls.
6583 (Finsert_file_contents): Save and restore errno,
6584 so that report_file_error outputs the correct diagnostic.
6585 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6587 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6589 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6591 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6593 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6594 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6596 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6598 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6599 about the current paragraph and restore it after the call to reseat.
6601 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6602 (bidi_find_paragraph_start): Search back for paragraph beginning
6603 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6604 (bidi_move_to_visually_next): Only trigger paragraph-related
6605 computations when the last character is a newline or at EOB, not
6606 just any NEUTRAL_B. (Bug#9470)
6608 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6609 truncated lines if point is covered by a display string. (Bug#9524)
6611 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6613 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6614 (cons_to_x_long): New function.
6615 (lisp_data_to_selection_data): Use it. Correct the test for
6616 short-versus-long data; it was negated. Break out of vector
6617 loop, for efficiency, when a long datum is discovered.
6619 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6621 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6623 2011-09-16 Eli Zaretskii <eliz@gnu.org>
6625 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6626 GCC PR/17406) by declaring this function with external scope.
6628 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6630 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6631 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6633 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6635 * editfns.c (Fformat): Correctly handle text properties on "%%".
6637 2011-09-15 Eli Zaretskii <eliz@gnu.org>
6639 * xterm.c (x_draw_composite_glyph_string_foreground):
6640 * w32term.c (x_draw_composite_glyph_string_foreground):
6641 * term.c (encode_terminal_code):
6642 * composite.c (composition_update_it, get_composition_id):
6643 * xdisp.c (get_next_display_element)
6644 (fill_composite_glyph_string): Add comments about special meaning
6645 of TAB characters in a composition.
6647 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6649 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
6650 This occurs when processing a multibyte format.
6651 Problem reported by Wolfgang Jenker.
6653 2011-09-15 Johan Bockgård <bojohan@gnu.org>
6655 * xdisp.c (try_cursor_movement): Only check for exact match if
6656 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6658 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6660 Remove unused external symbols.
6661 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6662 * xdisp.c (calc_pixel_width_or_height): Now static.
6663 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6664 * indent.c (check_display_width):
6665 * w32term.c: Fix comment to match code.
6666 * xterm.c, xterm.h (x_catching_errors): Remove.
6668 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6670 * xselect.c: Use signed conversions more consistently (Bug#9498).
6671 (selection_data_to_lisp_data): Assume incoming selection data are
6672 signed integers, not unsigned. This is to be consistent with
6673 outgoing selection data, which was modified to use signed integers
6674 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6675 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6676 expects long, not unsigned long.
6678 2011-09-14 Eli Zaretskii <eliz@gnu.org>
6680 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6681 computation of loop end. Reported by Johan Bockgård
6684 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
6686 * frame.c (Fother_visible_frames_p): Function deleted.
6688 2011-09-12 Eli Zaretskii <eliz@gnu.org>
6690 * indent.c (compute_motion): Process display vector front to back
6691 rather than the other way around. (Bug#2496)
6693 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6695 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6697 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
6699 * minibuf.c (Fread_from_minibuffer): Doc fix.
6701 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6703 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6704 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6706 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6708 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6709 value for non-existent files.
6711 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6713 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6714 set its "size" to -1. This will set the modtime_size field of
6715 the corresponding buffer to -1, which is what
6716 verify-visited-file-modtime expects for files that do not exist.
6719 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6721 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6723 * lisp.h: ... from here. push_key_description is no longer
6724 defined in keyboard.c, so its declaration should not be in
6725 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6726 logically belongs with push_key_description.
6728 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6730 * buffer.h: Include <sys/types.h> instead of <time.h>.
6731 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6732 Problem reported by Herbert J. Skuhra.
6734 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6736 * xml.c (parse_region): Make the parsing work for
6737 non-comment-starting XML files again (bug#9144).
6739 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6741 * image.c (gif_load): Fix calculation of bottom and right corner.
6744 2011-09-10 Eli Zaretskii <eliz@gnu.org>
6746 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6747 redisplay in small windows.
6749 2011-09-09 Eli Zaretskii <eliz@gnu.org>
6751 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6753 2011-09-08 Martin Rudalics <rudalics@gmx.at>
6755 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6756 Operate on live windows only.
6758 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
6760 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6762 2011-09-07 Eli Zaretskii <eliz@gnu.org>
6764 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6765 only under bidi iteration.
6767 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6769 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6771 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6773 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6774 Without this fix, the command to link temacs failed due to an
6775 undefined symbol __builtin_isnan. This is because
6776 /usr/include/iso/math_c99.h #defines isnan(x) to
6777 __builtin_isnan(x), but the bundled gcc, which identifies itself
6778 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6780 * floatfns.c (isnan): #undef, and then #define to a clone of
6782 (Fisnan): Always define, since it's always available now.
6783 (syms_of_floatfns): Always define isnan at the Lisp level.
6785 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6787 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6789 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6791 * fileio.c: Fix bugs with large file offsets (Bug#9428).
6792 The previous code assumed that file offsets (off_t values) fit in
6793 EMACS_INT variables, which is not true on typical 32-bit hosts.
6794 The code messed up by falsely reporting buffer overflow in cases
6795 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6796 when "big" contains more than 2**29 bytes, even though this
6797 inserts just one byte and does not overflow the buffer.
6798 (Finsert_file_contents): Store file offsets as off_t
6799 values, not as EMACS_INT values. Check for overflow when
6800 converting between EMACS_INT and off_t. When checking for
6801 buffer overflow or for overlap, take the offsets into account.
6802 Don't use EMACS_INT for small values where int suffices.
6803 When checking for overlap, fix a typo: ZV was used where
6804 ZV_BYTE was intended.
6805 (Fwrite_region): Don't assume off_t fits into 'long'.
6806 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6808 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
6810 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6812 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6814 sprintf-related integer and memory overflow issues (Bug#9412).
6816 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6817 (esprintf, exprintf, evxprintf): New functions.
6818 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6819 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
6820 (modify_event_symbol): Do not assume that the length of
6821 name_alist_or_stem is safe to alloca and fits in int.
6822 (Fexecute_extended_command): Likewise for function name and binding.
6823 (Frecursion_depth): Wrap around reliably on integer overflow.
6824 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6825 since some callers pass EMACS_INT values.
6826 (Fsingle_key_description): Don't crash if symbol name contains more
6827 than MAX_ALLOCA bytes.
6828 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6829 (get_minibuffer): Arg is now EMACS_INT, not int.
6830 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
6831 (esprintf, exprintf, evxprintf): New decls.
6832 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6834 * dbusbind.c (signature_cat): New function.
6835 (xd_signature, Fdbus_register_signal):
6836 Do not overrun buffer; instead, report string overflow.
6838 * dispnew.c (add_window_display_history): Don't overrun buffer.
6839 Truncate instead; this is OK since it's just a log.
6841 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6842 even if the time zone offset is outlandishly large.
6843 Don't mishandle offset == INT_MIN.
6845 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6846 when creating daemon; the previous buffer-overflow check was incorrect.
6848 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6849 which has the guts of the old verror function.
6851 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6852 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6854 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6855 (font_unparse_xlfd): Don't blindly alloca long strings.
6856 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
6857 fits in int, when using sprintf. Use single snprintf to count
6858 length of string rather than counting it via multiple sprintfs;
6859 that's simpler and more reliable.
6860 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6861 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6862 sprintf, in case result does not fit in int.
6864 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6865 (fontset_from_font): Print it.
6867 * frame.c (tty_frame_count): Now printmax_t, not int.
6868 (make_terminal_frame, set_term_frame_name): Print it.
6869 (x_report_frame_params): In X, window IDs are unsigned long,
6870 not signed long, so print them as unsigned.
6871 (validate_x_resource_name): Check for implausibly long names,
6872 and don't assume name length fits in 'int'.
6873 (x_get_resource_string): Don't blindly alloca invocation name;
6874 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6877 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6878 (xg_check_special_colors, xg_set_geometry):
6879 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6881 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6882 Use esprintf, not sprintf, in case result does not fit in int.
6884 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6885 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6886 it as a large positive number.
6887 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6888 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6890 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6891 in case result does not fit in int.
6893 * print.c (float_to_string): Detect width overflow more reliably.
6894 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6895 buffer overrun. Don't assume list length fits in 'int'. Treat
6896 print length of 0 as 0, not as infinity; to be consistent with other
6897 uses of print length in this function. Don't overflow print length
6898 index. Don't assume hash table size fits in 'long', or that
6899 vectorlike size fits in 'unsigned long'.
6901 * process.c (make_process): Use printmax_t, not int, to format
6902 process-name gensyms.
6904 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6906 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6907 to avoid potential buffer overrun.
6909 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6910 if X resource line is longer than 512 bytes.
6912 * xfns.c (x_window): Make sprintf buffer a bit bigger
6913 to avoid potential buffer overrun.
6915 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6917 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6919 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6921 Integer overflow fixes for scrolling, etc.
6922 Without these, Emacs silently mishandles large integers sometimes.
6923 For example, "C-u 4294967297 M-x recenter" was treated as if
6924 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6926 * xdisp.c (try_window_id): Check Emacs fixnum range before
6927 converting to 'int'.
6929 * window.c (window_scroll_line_based, Frecenter):
6930 Check that an Emacs fixnum is in range before assigning it to 'int'.
6931 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6932 values converted from Emacs fixnums.
6933 (Frecenter): Don't wrap around a line count if it is out of 'int'
6934 range; instead, treat it as an extreme value.
6935 (Fset_window_configuration, compare_window_configurations):
6936 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6938 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6939 that can exceed INT_MAX. Check that EMACS_INT value is in range
6940 before assigning it to the (possibly-narrower) index.
6941 (match_limit): Don't assume that a fixnum can fit in 'int'.
6943 * print.c (print_object): Use ptrdiff_t, not int, for index that can
6946 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
6947 (Fvertical_motion): Don't wrap around LINES values that don't fit
6948 in 'int'. Instead, treat them as extreme values. This is good
6949 enough for windows, which can't have more than INT_MAX lines anyway.
6951 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6953 * Require libxml/parser.h to avoid compilation warning.
6955 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6957 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6958 since this reportedly can destroy thread storage.
6960 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
6962 * syntax.c (find_defun_start): Update all cache variables if
6963 exiting early (Bug#9401).
6965 2011-08-30 Eli Zaretskii <eliz@gnu.org>
6967 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6969 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6970 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6971 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6973 * term.c (tty_append_glyph): New function.
6974 (produce_stretch_glyph): Static function and its prototype deleted.
6976 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6979 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6981 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6982 when checking :margin (Bug#9390).
6983 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
6984 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
6985 so that the name doesn't mislead. All uses changed.
6987 2011-08-28 Johan Bockgård <bojohan@gnu.org>
6989 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6992 2011-08-27 Eli Zaretskii <eliz@gnu.org>
6994 * xdisp.c (move_it_to): Don't bail out early when reaching
6995 position beyond to_charpos, if we are scanning backwards.
6996 (move_it_vertically_backward): When DY == 0, make sure we get to
6997 the first character in the line after the newline.
6999 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7001 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7002 (ccl_driver): Do not generate an out-of-range pointer.
7003 (Fccl_execute_on_string): Remove unnecessary check for
7004 integer overflow, noted by Stefan Monnier in
7005 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7006 Remove a FIXME that didn't need fixing.
7007 Simplify the newly-introduced buffer reallocation code.
7009 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
7011 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7013 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
7015 Integer and memory overflow issues (Bug#9196).
7017 * doc.c (get_doc_string): Rework so that
7018 get_doc_string_buffer_size is the actual buffer size, rather than
7019 being 1 less than the actual buffer size; this makes xpalloc more
7022 * image.c (x_allocate_bitmap_record, cache_image):
7023 * xselect.c (Fx_register_dnd_atom):
7024 Simplify previous changes by using xpalloc.
7026 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7027 since either will do and ptrdiff_t is convenient with xpalloc.
7029 * charset.c (charset_table_size)
7030 (struct charset_sort_data.priority): Now ptrdiff_t.
7031 (charset_compare): Don't overflow if priorities differ greatly.
7032 (Fsort_charsets): Don't assume list length fits in int.
7033 Check for size-calculation overflow when allocating sort data.
7034 (syms_of_charset): Allocate an initial charset table that is
7035 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7037 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7039 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7040 The actual value is always <= INT_MAX, and leaving it unsigned made
7041 overflow checking harder.
7043 * dispextern.h (struct glyph_matrix.rows_allocated)
7044 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7045 with xpalloc. The values are still always <= INT_MAX.
7047 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7049 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7050 (SAFE_NALLOCA): New macro.
7052 * region-cache.c (struct boundary.pos, find_cache_boundary)
7053 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7054 (set_cache_region, invalidate_region_cache)
7055 (revalidate_region_cache, know_region_cache, region_cache_forward)
7056 (region_cache_backward, pp_cache):
7057 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7058 so that ptrdiff_t * can be passed to xpalloc.
7059 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7060 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7061 (pp_cache): Don't assume cache_len fits in int.
7062 * region-cache.h: Adjust extern decls to match.
7064 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7065 EMACS_INT, since either will do, for xpalloc.
7067 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7068 (xnmalloc, xnrealloc, xpalloc): New functions.
7070 * bidi.c (bidi_shelve_header_size): New constant.
7071 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7072 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7074 * bidi.c (bidi_cache_shrink):
7075 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7077 Don't update size of array until after memory allocation succeeds,
7078 because xmalloc/xrealloc may not return.
7079 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7080 now that we have proper integer overflow checking.
7081 (record_overlay_string, overlay_strings): Catch overflows when
7082 calculating size of overlay_str_buf.
7084 * callproc.c (Fcall_process): Check for size overflow when
7085 calculating size of args2.
7086 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7087 Normally we prefer signed values, but sticking with ptrdiff_t would
7088 require adding more-complicated checks.
7090 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7091 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7092 Redo buffer-overflow calculations to avoid integer overflow.
7093 Add a FIXME comment where memory seems to be over-allocated.
7095 * character.c (Fstring): Check for size-calculation overflow.
7097 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7098 unnecessary integer overflow. Check for size overflow.
7099 (encode_coding_object): Don't update size until xmalloc succeeds.
7101 * composite.c (get_composition_id): Check for overflow in glyph
7102 length calculations.
7104 Integer and memory overflow fixes for display code.
7105 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7106 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7107 (scrolling_window): Check for overflow in size calculations.
7108 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7109 Don't assume glyph table len fits in int.
7110 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7111 (row_table_size): Now ptrdiff_t, not int.
7112 (scrolling_window): Avoid overflow in size calculations.
7113 Don't update size until allocation succeeds.
7114 * fns.c (concat): Check for overflow in size calculations.
7115 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7116 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7117 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7119 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7120 (get_doc_string): Check for size calculation overflow.
7121 Don't update size until allocation succeeds.
7122 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7123 EMACS_INT, where ptrdiff_t will do.
7124 (Fsubstitute_command_keys): Check for string overflow.
7126 * editfns.c (set_time_zone_rule): Don't assume environment length
7128 (message_length): Now ptrdiff_t, not int.
7129 (Fmessage_box): Don't update size until allocation succeeds.
7130 Don't assume message length fits in int.
7131 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7133 * emacs.c (main): Do not reallocate argv, since there is a null at
7134 the end that can be overwritten, and this way there's no need to
7135 worry about size-calculation overflow.
7136 (sort_args): Check for size-calculation overflow.
7138 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7140 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7142 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7143 (x_set_scroll_bar_width, x_figure_window_size):
7144 Check for integer overflow.
7145 (x_set_alpha): Do not assume XINT fits in int.
7147 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7148 This is for the members text_lines, text_cols, total_lines, total_cols,
7149 where the system imposes an 'int' limit.
7151 * fringe.c (Fdefine_fringe_bitmap):
7152 Don't update size until alloc works.
7154 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7155 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7157 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7158 Check for size-calculation overflow.
7159 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7160 do, as we prefer signed integers.
7161 (id_to_widget.max_size, id_to_widget.used)
7162 (xg_store_widget_in_map, xg_remove_widget_from_map)
7163 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7164 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7165 Use and return ptrdiff_t, not int.
7166 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7167 * gtkutil.h: Change prototypes to match the above.
7169 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7170 are duplicate now that they've been promoted to lisp.h.
7171 (x_allocate_bitmap_record, x_alloc_image_color)
7172 (make_image_cache, cache_image, xpm_load):
7173 Don't update size until alloc is done.
7174 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7176 Check for size calculation overflow.
7177 (ct_colors_allocated_max): New constant.
7178 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7181 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7182 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7183 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7184 Use ptrdiff_t, not int, to count maps.
7185 (read_char_minibuf_menu_prompt): Check for overflow in size
7186 calculations. Don't update size until allocation succeeds.
7187 Redo calculations to avoid overflow.
7188 * keyboard.h: Change prototypes to match the above.
7190 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7192 (current_minor_maps): Check for size calculation overflow.
7193 * keymap.h: Change prototypes to match the above.
7195 * lread.c (read1, init_obarray): Don't update size until alloc done.
7197 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7198 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7200 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7201 Now ptrdiff_t, not int.
7202 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7203 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7205 * process.c (Fnetwork_interface_list): Check for overflow
7206 in size calculation.
7208 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7210 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7211 overflow. Don't bother calling xmalloc when xrealloc will do.
7213 * search.c (Freplace_match): Check for size calculation overflow.
7214 (Fset_match_data): Don't assume list lengths fit in 'int'.
7216 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7217 for command line length. Do not attempt to address one before the
7218 beginning of an array, as that's not portable.
7220 * term.c (max_frame_lines): Remove; unused.
7221 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7223 (encode_terminal_code, calculate_costs): Check for size
7224 calculation overflow.
7225 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7226 table lengths and related sizes. Don't update size until alloc
7227 done. Redo calculations to avoid overflow.
7228 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7230 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7231 subtracting pointers.
7232 (gobble_line): Check for overflow more carefully. Don't update size
7235 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7236 Don't update size until alloc done.
7237 Redo size calculations to avoid overflow.
7238 Check for size calculation overflow.
7239 (main) [DEBUG]: Fix typo in invoking tparam1.
7241 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7242 Use ptrdiff_t, not int, for sizes.
7243 (store_mode_line_noprop_char): Don't update size until alloc done.
7245 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7246 Use ptrdiff_t, not int, for sizes.
7247 (Finternal_make_lisp_face, cache_face):
7248 Check for size calculation overflow.
7249 (cache_face): Treat size calculation overflows as if they were
7250 memory exhaustion (the usual treatment), rather than aborting.
7252 * xfns.c (x_encode_text, x_set_name_internal)
7253 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7254 sizes, since they can exceed INT_MAX in size. Check for size
7255 calculation overflow.
7257 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7258 (xg_select): Check for size calculation overflow.
7259 Don't update size until alloc done.
7261 * xrdb.c (get_environ_db): Don't assume path length fits in int,
7262 as sprintf is limited to int lengths.
7264 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7265 (X_LONG_MIN): New macros.
7266 Use them to make the following changes clearer.
7267 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7268 This change doesn't affect the value now, but it may help remind
7269 future maintainers not to raise the value too much later.
7270 (SELECTION_QUANTUM): Remove, replacing with ...
7271 (selection_quantum): ... new function, which avoids overflow.
7273 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7274 assumption that selection length fits in 'int'.
7275 (x_reply_selection_request, x_handle_selection_request)
7276 (x_get_window_property, receive_incremental_selection)
7277 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7278 (lisp_data_to_selection_data, clean_local_selection_data):
7279 Use ptrdiff_t, not int, to record length of selection.
7280 (x_reply_selection_request, x_get_window_property)
7281 (receive_incremental_selection, x_property_data_to_lisp):
7282 Redo calculations to avoid overflow.
7283 (x_reply_selection_request): When sending hint, ceiling it at
7284 X_LONG_MAX rather than relying on wraparound overflow to send
7286 (x_get_window_property, receive_incremental_selection)
7287 (lisp_data_to_selection_data, x_property_data_to_lisp):
7288 Check for size-calculation overflow.
7289 (x_get_window_property, receive_incremental_selection)
7290 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7291 Don't store size until memory allocation succeeds.
7292 (x_get_window_property): Plug memory leak on memory exhaustion.
7293 Don't double-block input; malloc is safe here. Don't assume 2**34
7294 - 4 fits in unsigned long. Add an xassert to check
7295 XGetWindowProperty overflow. Be more careful about overflow
7296 calculations, and distinguish size from memory overflow better.
7297 (receive_incremental_selection): When tracing, don't assume
7298 unsigned int is less than INT_MAX.
7299 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7300 harmful) conversions of unsigned short to int.
7301 (lisp_data_to_selection_data): Don't assume that integers
7302 in the range -65535 through -1 fit in an X unsigned short.
7303 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7304 result parameters unless successful. Rely on cons_to_unsigned
7305 to report problems with elements; the old code wasn't right anyway.
7306 (x_check_property_data): Check for int overflow; we cannot use
7307 a wider type due to X limits.
7308 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7310 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
7312 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7313 (x_term_init): Check for size calculation overflow.
7314 (x_color_cells): Don't store size until memory allocation succeeds.
7315 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
7316 Don't assume alloca size is less than MAX_ALLOCA.
7317 (x_term_init): Don't assume length fits in int (sprintf is limited
7320 Use ptrdiff_t for composition IDs.
7321 * character.c (lisp_string_width):
7322 * composite.c (composition_table_size, n_compositions)
7323 (get_composition_id, composition_gstring_from_id):
7324 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7325 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7326 * window.c (Frecenter):
7327 Use ptrdiff_t, not int, for composition IDs.
7328 * composite.c (get_composition_id): Check for integer overflow.
7329 * composite.h: Adjust prototypes to match the above changes.
7331 Use ptrdiff_t for hash table indexes.
7332 * category.c (hash_get_category_set):
7333 * ccl.c (ccl_driver):
7334 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7335 * coding.c (coding_system_charset_list, detect_coding_system):
7336 * coding.h (struct coding_system.id):
7337 * composite.c (get_composition_id, gstring_lookup_cache):
7338 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7339 * image.c (xpm_get_color_table_h):
7340 * lisp.h (hash_lookup, hash_put):
7341 * minibuf.c (Ftest_completion):
7342 Use ptrdiff_t for hash table indexes, not int (which is too
7343 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7344 32-bit --with-wide-int hosts).
7346 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7347 Add a FIXME comment about memory leaks.
7348 (syms_of_charset): Don't assume xmalloc returns.
7350 Don't assume that stated character widths fit in int.
7351 * character.c (Fchar_width, c_string_width, lisp_string_width):
7352 * character.h (CHAR_WIDTH):
7353 * indent.c (MULTIBYTE_BYTES_WIDTH):
7354 Use sanitize_char_width to avoid undefined and/or bad behavior
7355 with outlandish widths.
7356 * character.h (sanitize_tab_width): Rename from sanitize_width,
7357 now that we have two such functions. All uses changed.
7358 (sanitize_char_width): New inline function.
7360 Don't assume that tab-width fits in int.
7361 * character.h (sanitize_width): New inline function.
7362 (SANE_TAB_WIDTH): New macro.
7363 (ASCII_CHAR_WIDTH): Use it.
7364 * indent.c (sane_tab_width): Remove. All uses replaced by
7365 SANE_TAB_WIDTH (current_buffer).
7366 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7368 * fileio.c: Integer overflow issues with file modes.
7369 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7371 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7372 Remove unreachable code.
7373 (read_hex, load_charset_map_from_file): Check for integer overflow.
7375 * xterm.c: Don't go over XClientMessageEvent limit.
7376 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7377 (x_send_scroll_bar_event): Likewise. Check that the size does not
7378 exceed limits imposed by XClientMessageEvent, as well as the usual
7379 ptrdiff_t and size_t limits.
7381 * keyboard.c: Overflow, signedness and related fixes.
7382 (make_lispy_movement): Use same integer type in forward decl
7383 that is used in the definition.
7384 (read_key_sequence, keyremap_step):
7385 Change bufsize argument back to int, undoing my 2011-03-30 change.
7386 We prefer signed types, and int is wide enough here.
7387 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7388 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7389 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7390 length, not size_t. Use ptrdiff_t for index, not int.
7391 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7392 possibility of integer overflow.
7394 Overflow, signedness and related fixes for images.
7396 * dispextern.h (struct it.stack[0].u.image.image_id)
7397 (struct_it.image_id, struct image.id, struct image_cache.size)
7398 (struct image_cache.used, struct image_cache.ref_count):
7399 * gtkutil.c (update_frame_tool_bar):
7400 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7401 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7402 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7403 * nsmenu.m (update_frame_tool_bar):
7404 * xdisp.c (calc_pixel_width_or_height):
7405 * xfns.c (image_cache_refcount):
7406 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7407 on typical 64-bit hosts.
7409 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7410 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7411 Omit unnecessary casts to int.
7412 (parse_image_spec): Check that integers fall into 'int' range
7413 when the callers expect that.
7414 (image_ascent): Redo ascent calculation to avoid int overflow.
7415 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7416 (lookup_image): Remove unnecessary tests.
7417 (xbm_image_p): Locals are now of int, not EMACS_INT,
7418 since parse_image_check makes sure they fit into int.
7419 (png_load, gif_load, svg_load_image):
7420 Prefer int to unsigned where either will do.
7421 (tiff_handler): New function, combining the cores of the
7422 old tiff_error_handler and tiff_warning_handler.
7423 This function is rewritten to use vsnprintf and thereby avoid
7424 stack buffer overflows. It uses only the features of vsnprintf
7425 that are common to both POSIX and native Microsoft.
7426 (tiff_error_handler, tiff_warning_handler): Use it.
7427 (tiff_load, gif_load, imagemagick_load_image):
7428 Don't assume :index value fits in 'int'.
7429 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7430 (imagemagick_load_image): Check that crop parameters fit into
7431 the integer types that MagickCropImage accepts. Don't assume
7432 Vimagemagick_render_type has a nonnegative value. Don't assume
7433 size_t fits in 'long'.
7434 (gs_load): Use printmax_t to print the widest integers possible.
7435 Check for integer overflow when computing image height and width.
7437 2011-08-26 Eli Zaretskii <eliz@gnu.org>
7439 * xdisp.c (redisplay_window): Don't force window start if point
7440 will be invisible in the resulting window. (Bug#9324)
7442 2011-08-25 Eli Zaretskii <eliz@gnu.org>
7444 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7445 the display spec is of the form `(space ...)'.
7446 (handle_display_spec): Return the value returned by
7447 handle_single_display_spec, not just 1 or zero.
7448 (handle_single_display_spec): If the display spec is of the form
7449 `(space ...)', and specifies display in the text area, return 2
7451 (try_cursor_movement): Check for the need to scroll more
7452 accurately, and prefer exact match for point under bidi.
7453 Don't advance `row' beyond the last row of the window.
7455 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7456 into disp_prop; all users changed.
7458 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7459 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7460 for the text covered by the display property.
7462 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
7464 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7465 Change return value to nil.
7466 (Frecord_buffer): Delete unused function.
7468 2011-08-24 Eli Zaretskii <eliz@gnu.org>
7470 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7471 buffers, return left-to-right.
7472 (set_cursor_from_row): Consider candidate row a win if its glyph
7473 represents a newline and point is on that newline. Fixes cursor
7474 positioning on the newline at EOL of R2L text within L2R
7475 paragraph, and vice versa.
7476 (try_cursor_movement): Check continued rows, in addition to
7477 continuation rows. Fixes unwarranted scroll when point enters a
7478 continued line of R2L text within an L2R paragraph, or vice versa.
7479 (cursor_row_p): Consider the case of point being equal to
7480 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7481 from the end of a short line to the beginning of a continued line
7482 of R2L text within L2R paragraph.
7483 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7484 composed characters.
7486 * bidi.c (bidi_check_type): Use xassert.
7487 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7490 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7492 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7495 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
7497 * nsfont.m (ns_otf_to_script): Fix typo.
7499 2011-08-22 Kenichi Handa <handa@m17n.org>
7501 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7502 extra slot even if the purpose is char-code-property-table.
7504 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7506 * xdisp.c (redisplay_window): When computing centering_position,
7507 account for the height of the header line. (Bug#8874)
7509 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7510 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7511 candidate is selected by the mouse, and that candidate has a
7512 composed character under the mouse.
7514 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7515 coordinates reported by pos-visible-in-window-p for a composed
7516 character in column zero.
7518 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7520 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7522 2011-08-22 Eli Zaretskii <eliz@gnu.org>
7524 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7525 consider it a hit if to_charpos is anywhere in the range of the
7526 composed buffer positions.
7528 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
7530 * image.c (gif_load): Don't assume that each subimage has the same
7531 dimensions as the base image. Handle disposal method that is
7532 "undefined" by the gif spec (Bug#9335).
7534 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
7536 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
7537 (Fcondition_case): Document `debug' symbol in error handler.
7539 2011-08-19 Eli Zaretskii <eliz@gnu.org>
7541 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7542 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7543 from an Org mode buffer to a Speedbar frame.
7545 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7546 a composition, take its buffer position from IT->cmp_it.charpos.
7547 Fixes cursor positioning at the beginning of a line that begins
7548 with a composed character.
7550 2011-08-18 Eli Zaretskii <eliz@gnu.org>
7552 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7553 character bidirectional type, use STRONG_L instead. Fixes crashes
7554 in a buffer produced by `describe-categories'.
7556 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7557 members before the level stack, so they would be saved and
7558 restored when copying iterator state. Fixes incorrect reordering
7559 around TABs covered by display properties.
7561 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7563 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
7565 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
7567 * eval.c (internal_condition_case, internal_condition_case_1)
7568 (internal_condition_case_2, internal_condition_case_n):
7569 Remove unnecessary aborts (Bug#9081).
7571 2011-08-17 Eli Zaretskii <eliz@gnu.org>
7573 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7574 has no `load' handler, try opening the file locally. (Bug#9311)
7576 2011-08-16 Ken Brown <kbrown@cornell.edu>
7578 * gmalloc.c: Expand comment.
7580 2011-08-16 Eli Zaretskii <eliz@gnu.org>
7582 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7583 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7585 2011-08-16 Ken Brown <kbrown@cornell.edu>
7587 Fix memory allocation problems in Cygwin build (Bug#9273).
7589 * unexcw.c ( __malloc_initialized): Declare external variable.
7590 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7592 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7594 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7596 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7598 [CYGWIN] (special_realloc): New function.
7599 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7600 requests to realloc storage in the static heap.
7602 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7604 * bidi.c (bidi_initialize): Remove unused local.
7606 2011-08-15 Eli Zaretskii <eliz@gnu.org>
7609 * biditype.h: Remove file.
7610 * makefile.w32-in ($(BLD)/bidi.$(O)):
7611 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
7613 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7615 * chartab.c: Improve commentary for the uniprop_table API.
7617 * bidi.c (bidi_paragraph_init): Support zero value of
7618 bidi_ignore_explicit_marks_for_paragraph_level.
7619 (bidi_initialize): Use uniprop_table instead of including
7620 biditype.h and bidimirror.h.
7622 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7623 coordinates of the iterator when restoring from ppos_it.
7626 2011-08-14 Kenichi Handa <handa@m17n.org>
7628 * process.c (create_process): Call setup_process_coding_systems
7629 after the pid of the process is set to -1 (Bug#8162).
7631 2011-08-14 Eli Zaretskii <eliz@gnu.org>
7633 * xdisp.c (move_it_in_display_line_to): Don't invoke
7634 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7635 ppos_it. Fixes vertical cursor motion when line beginning is
7636 covered by an image. (Bug#9296)
7638 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7640 * nsterm.h (ns_run_ascript): Declare.
7641 (NSAPP_DATA2_RUNASSCRIPT): Define.
7643 * nsfns.m (as_script, as_result, as_status): New static variables.
7644 (ns_run_ascript): New function.
7645 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
7646 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7647 the event loop. Get status from as_status (Bug#7276).
7649 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7650 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7651 the event loop (Bug#7276).
7653 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7655 * gnutls.c (QCgnutls_bootprop_priority)
7656 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7657 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7658 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7659 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7660 (QCgnutls_bootprop_verify_hostname_error)
7661 (QCgnutls_bootprop_callbacks_verify): Rename from
7662 Qgnutls_bootprop_..., all uses changed.
7664 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7667 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7669 * xfaces.c (Qframe_set_background_mode): Now static.
7670 * dispextern.h (Qframe_set_background_mode): Remove decl.
7672 * process.c (Fnetwork_interface_info): Declare local only if needed.
7674 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7676 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7677 (Fnetwork_interface_list): Allocate in increments of bytes instead
7678 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7679 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7681 (struct ifflag_def): notrailers is smart on OSX.
7682 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7683 Get hardware address with getifaddrs if available.
7685 2011-08-12 Eli Zaretskii <eliz@gnu.org>
7687 * xdisp.c (iterate_out_of_display_property): xassert that
7688 IT->position is set to within IT->object's boundaries. Break from
7689 the loop as soon as EOB is reached; avoids infloops in redisplay
7690 when IT->position is set up wrongly due to some bug.
7691 Set IT->current to match the bidi iterator unconditionally.
7692 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7693 entry. Force push_it to save on the stack the current
7694 buffer/string position, to be restored by pop_it. Fix flags in
7695 the iterator structure wrt the object coming from a display
7696 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7697 properties. (Bug#9284)
7699 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
7701 * fontset.c (fontset_get_font_group): Add proper type checks.
7704 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7706 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7707 and LC_VERSION_MIN_MACOSX.
7708 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7709 (dump_it) [LC_FUNCTION_STARTS]: Use it.
7711 2011-08-08 Eli Zaretskii <eliz@gnu.org>
7713 * xdisp.c (forward_to_next_line_start): Allow to use the
7714 no-display-properties-and-no-overlays under bidi display.
7715 Set disp_pos in the bidi iterator to avoid searches for display
7716 properties and overlays.
7718 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
7720 * editfns.c (Fset_time_zone_rule): Document relationship with the
7723 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7724 the font entity extracted from the cache (Bug#8109).
7726 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
7728 * composite.c (autocmp_chars): Don't reset point. That is done by
7729 restore_point_unwind (Bug#5984).
7731 2011-08-07 Juri Linkov <juri@jurta.org>
7733 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7734 to show the arg `TIME' instead of `TIMEVAL'.
7736 2011-08-06 Eli Zaretskii <eliz@gnu.org>
7738 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7739 display property strides EOL and includes a newline, as in
7740 longlines-mode. (Bug#9254)
7741 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7742 word-wrap under bidirectional display. (Bug#9224)
7744 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7745 is non-zero, even if the data buffer is NULL. Fixes a crash in
7746 vertical-motion with longlines-mode. (Bug#9254)
7748 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7750 * bidi.c <bidi_cache_total_alloc>: Now static.
7751 (bidi_initialize): Initialize bidi_cache_total_alloc.
7753 * xdisp.c (display_line): Release buffer allocated for shelved bidi
7756 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7757 amount allocated this far in `bidi_cache_total_alloc'.
7758 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7759 non-zero, only free the data buffer without restoring the cache
7760 contents. All callers changed.
7762 * dispextern.h (bidi_unshelve_cache): Update prototype.
7764 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7765 (move_it_in_display_line, move_it_to)
7766 (move_it_vertically_backward, move_it_by_lines): Replace the call
7767 to xfree to an equivalent call to bidi_unshelve_cache.
7768 (move_it_in_display_line_to): Fix logic of returning
7769 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
7771 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7773 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7774 came from a string character with a `cursor' property. (Bug#9229)
7776 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7778 * Makefile.in (LIB_PTHREAD): New variable.
7779 (LIBES): Add LIB_PTHREAD (Bug#9216).
7781 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7782 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7784 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7786 * regex.c (re_iswctype): Remove some redundant boolean conversions.
7788 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7790 * xterm.c (x_find_topmost_parent): New function.
7791 (x_set_frame_alpha): Find topmost parent window with
7792 x_find_topmost_parent and set the property there also (bug#9181).
7793 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7795 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7797 * callproc.c (Fcall_process): Avoid vfork clobbering
7798 the local vars buffer, coding_systems, current_dir.
7800 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7802 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7804 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7806 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7807 so that it is not optimized away.
7809 * xdisp.c (compute_display_string_pos): Remove unused local.
7811 2011-08-02 Eli Zaretskii <eliz@gnu.org>
7813 Fix slow cursor motion and scrolling in large buffers with
7814 selective display, like Org Mode buffers. (Bug#9218)
7816 * dispextern.h (struct bidi_it): New member disp_prop_p.
7818 * xdisp.c: Remove one-slot cache of display string positions.
7819 (compute_display_string_pos): Accept an additional argument
7820 DISP_PROP_P; callers changed. Scan at most 5K characters forward
7821 for a display string or property. If found, set DISP_PROP_P
7824 * bidi.c (bidi_fetch_char): Accept an additional argument
7825 DISP_PROP_P, and pass it to compute_display_string_pos.
7826 Only handle text covered by a display string if DISP_PROP_P is returned
7827 non-zero. All callers of bidi_fetch_char changed.
7829 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7831 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7833 2010-12-03 Don March <don@ohspite.net>
7835 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7836 last character M-[char] is translated to ESC [char] (bug#7541).
7838 2011-08-02 Kenichi Handa <handa@m17n.org>
7840 * lisp.h (uniprop_table): Extern it.
7842 * chartab.c (uniprop_table): Make it non-static.
7844 2011-08-01 Eli Zaretskii <eliz@gnu.org>
7846 * xdisp.c (forward_to_next_line_start): Accept additional argument
7847 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7849 (reseat_at_next_visible_line_start): Use the bidi iterator state
7850 returned by forward_to_next_line_start to restore the state of
7851 it->bidi_it after backing up to previous newline. (Bug#9212)
7853 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7855 * regex.c (re_comp): Protoize.
7856 (re_exec): Fix return type.
7857 (regexec): Fix type of `ret'. (Bug#9203)
7859 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7861 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7862 This is needed if max-image-size is a floating-point number.
7864 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7866 * print.c (print_object): Print empty symbol as ##.
7868 * lread.c (read1): Read ## as empty symbol.
7870 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7872 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7873 setting frame foreground color (Bug#9175).
7874 (x_set_background_color): Likewise.
7876 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7877 contents (Bug#9176).
7878 (EmacsTooltip -init): Remove bezels and add shadows to
7881 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7882 or scroll bar (Bug#8470).
7884 * nsfont.m (nsfont_open): Remove assignment to voffset and
7885 unnecessary vars hshink, expand, hd, full_height, min_height.
7886 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7888 * nsterm.h (nsfont_info): Remove voffset field.
7890 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7892 Implement strike-through and overline on NextStep (Bug#8863).
7894 * nsfont.m (nsfont_open): Use underline position provided by font,
7895 instead of hard-coded value of 2.
7896 (nsfont_draw): Call ns_draw_text_decoration instead.
7898 * nsterm.h: Add declaration for ns_draw_text_decoration.
7900 * nsterm.m (ns_draw_text_decoration): New function for drawing
7901 underline, overline, and strike-through.
7902 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7903 ns_draw_text_decoration. Change treatment of cursor drawing to
7904 accommodate underlining, etc.
7906 2011-07-28 Eli Zaretskii <eliz@gnu.org>
7908 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7911 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7913 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7914 Without this fix, if a signal arrives just after memory fills up,
7915 'malloc' might be invoked reentrantly.
7917 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7918 In other words, assume that every image size is allowed, on non-X
7919 hosts. This assumption is probably wrong, but it lets Emacs compile.
7921 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7923 * regex.c (re_iswctype): Convert return values to boolean.
7925 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7927 * xdisp.c (compute_display_string_pos): Don't use cached display
7928 string position if the buffer had its restriction changed.
7931 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7933 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7935 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7937 Integer signedness and overflow and related fixes. (Bug#9079)
7939 * bidi.c: Integer size and overflow fixes.
7940 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7941 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7942 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7943 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7944 (bidi_find_other_level_edge):
7945 Use ptrdiff_t instead of EMACS_INT where either will do.
7946 This works better on 32-bit hosts configured --with-wide-int.
7947 (bidi_cache_ensure_space): Check for size-calculation overflow.
7948 Use % rather than repeated addition, for better worst-case speed.
7949 Don't set bidi_cache_size until after xrealloc returns, because it
7951 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
7952 (bidi_cache_ensure_space): Also check that the bidi cache size
7953 does not exceed that of the largest Lisp string or buffer. See Eli
7954 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
7956 * alloc.c (__malloc_size_t): Remove.
7957 All uses replaced by size_t. See Andreas Schwab's note
7958 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7960 * image.c: Improve checking for integer overflow.
7961 (check_image_size): Assume that f is nonnull, since
7962 it is always nonnull in practice. This is one less thing to
7963 worry about when checking for integer overflow later.
7964 (x_check_image_size): New function, which checks for integer
7965 overflow issues inside X.
7966 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7967 This removes the need for a memory_full check.
7968 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7969 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7970 (xbm_read_bitmap_data): Change locals back to 'int', since
7971 their values must fit in 'int'.
7972 (xpm_load_image, png_load, tiff_load):
7973 Invoke x_create_x_image_and_pixmap earlier,
7974 to avoid much needless work if the image is too large.
7975 (tiff_load): Treat overly large images as if
7976 x_create_x_image_and_pixmap failed, not as malloc failures.
7977 (gs_load): Use x_check_image_size.
7979 * gtkutil.c: Omit integer casts.
7980 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7981 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7983 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7985 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7986 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7987 would wrongly return t on a 64-bit host.
7989 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7990 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7991 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7992 and therefore cause GCC to emit a bogus diagnostic in some cases.
7994 * image.c: Integer signedness and overflow and related fixes.
7995 This is not an exhaustive set of fixes, but it's time to
7996 record what I've got.
7997 (lookup_pixel_color, check_image_size): Remove redundant decls.
7998 (check_image_size): Don't assume that arbitrary EMACS_INT values
7999 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8000 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8001 (tiff_load, imagemagick_load_image):
8002 Check for overflow in size calculations.
8003 (x_create_x_image_and_pixmap): Remove unnecessary test for
8004 xmalloc returning NULL; that can't happen.
8005 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8006 (xpm_color_bucket): Use better integer hashing function.
8007 (xpm_cache_color): Don't possibly over-allocate memory.
8008 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8009 (gif_memory_source):
8010 Use ptrdiff_t, not int or size_t, to record sizes.
8011 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8012 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8013 either works, as we prefer signed integers.
8014 (tiff_read_from_memory, tiff_write_from_memory):
8015 Return tsize_t, not size_t, since that's what the TIFF API wants.
8016 (tiff_read_from_memory): Don't fail simply because the read would
8017 go past EOF; instead, return a short read.
8018 (tiff_load): Omit no-longer-needed casts.
8019 (Fimagemagick_types): Don't assume size fits into 'int'.
8021 Improve hashing quality when configured --with-wide-int.
8022 * fns.c (hash_string): New function, taken from sxhash_string.
8023 Do not discard information about ASCII character case; this
8024 discarding is no longer needed.
8025 (sxhash-string): Use it. Change sig to match it. Caller changed.
8026 * lisp.h: Declare it.
8027 * lread.c (hash_string): Remove, since we now use fns.c's version.
8028 The fns.c version returns a wider integer if --with-wide-int is
8029 specified, so this should help the quality of the hashing a bit.
8031 * emacs.c: Integer overflow minor fix.
8032 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8033 Define only if GNU_LINUX.
8034 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8036 * dispnew.c: Integer signedness and overflow fixes.
8037 Remove unnecessary forward decls, that were a maintenance hassle.
8038 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8040 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8041 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8042 (prepare_desired_row, line_draw_cost):
8043 Use int, not unsigned, where either works.
8044 (save_current_matrix, restore_current_matrix):
8045 Use ptrdiff_t, not size_t, where either works.
8046 (init_display): Check for overflow more accurately, and without
8047 relying on undefined behavior.
8049 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8050 Remove, replacing with the new symbols in lisp.h. All uses changed.
8051 * fileio.c (make_temp_name):
8052 * filelock.c (lock_file_1, lock_file):
8053 * xdisp.c (message_dolog):
8054 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8055 Use pMd etc. instead.
8056 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8057 replacing the pWIDE etc. symbols removed from editfns.c.
8059 * keyboard.h (num_input_events): Now uintmax_t.
8060 This is (very slightly) less likely to mess up due to wraparound.
8063 * buffer.c: Integer signedness fixes.
8064 (alloc_buffer_text, enlarge_buffer_text):
8065 Use ptrdiff_t rather than size_t when either will do, as we prefer
8068 * alloc.c: Integer signedness and overflow fixes.
8069 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8070 (__malloc_size_t): Default to size_t, not to int.
8071 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8072 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8073 Prefer ptrdiff_t to size_t when either would do, as we prefer
8075 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8076 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8077 Now const. Initialize with values that are in range even if char
8079 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8080 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8081 These functions do the right thing with sizes > 2**32.
8082 (check_depth): Now ptrdiff_t, not int.
8083 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8084 Adjust to new way of storing sizes. Check for size overflow bugs
8086 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8087 slightly wrong anyway, as it missed one instance of
8088 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8089 (refill_memory_reserve): Omit needless cast to size_t.
8090 (mark_object_loop_halt): Mark as externally visible.
8092 * xselect.c: Integer signedness and overflow fixes.
8093 (Fx_register_dnd_atom, x_handle_dnd_message):
8094 Use ptrdiff_t, not size_t, since we prefer signed.
8095 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8096 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8097 x_dnd_atoms_size and x_dnd_atoms_length.
8099 * doprnt.c: Prefer signed to unsigned when either works.
8101 * doprnt.c (doprnt):
8103 * xdisp.c (vmessage):
8104 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8105 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8106 prefer signed arithmetic to avoid comparison confusion.
8107 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8108 but is a bit tricky.
8110 Assume freestanding C89 headers, string.h, stdlib.h.
8111 * data.c, doprnt.c, floatfns.c, print.c:
8112 Include float.h unconditionally.
8113 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8114 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8115 * regex.c: Likewise for stddef.h, string.h.
8116 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8117 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8118 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8119 (STDC_HEADERS): Remove obsolete defines.
8120 * sysdep.c: Include limits.h unconditionally.
8122 Assume support for memcmp, memcpy, memmove, memset.
8123 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8124 * regex.c (memcmp, memcpy):
8125 Remove; we assume C89 now.
8127 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8128 (__malloc_safe_bcopy): Remove; no longer needed.
8130 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
8131 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8132 well either way, and we prefer signed to unsigned.
8134 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8136 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8137 closes the connection while we're reading (bug#9182).
8139 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
8141 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8142 are specified (Bug#9168).
8144 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8146 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8147 Found by GCC static checking and --with-wide-int on a 32-bit host.
8149 2011-07-25 Eli Zaretskii <eliz@gnu.org>
8151 * xdisp.c (compute_display_string_pos): Fix logic of caching
8152 previous display string position. Initialize cached_prev_pos to
8153 -1. Fixes slow-down at the beginning of a buffer.
8155 2011-07-24 Eli Zaretskii <eliz@gnu.org>
8157 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8158 for attrs[LFACE_FONTSET_INDEX].
8160 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8162 * xml.c (parse_region): Remove unused local
8163 that was recently introduced.
8165 2011-07-23 Eli Zaretskii <eliz@gnu.org>
8167 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8168 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8170 * xdisp.c (move_it_in_display_line_to): Record the best matching
8171 position for TO_CHARPOS while scanning the line, and restore it on
8172 exit if none of the characters scanned was an exact match.
8173 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
8174 when exact match is impossible due to invisible text, and the
8175 lines are truncated.
8177 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8179 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8182 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8184 Fix a significant slow-down of cursor motion with C-n, C-p,
8185 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8186 auto-repeat under bidi redisplay in fontified buffers.
8187 * xdisp.c (compute_stop_pos_backwards): New function.
8188 (next_element_from_buffer): Call compute_stop_pos_backwards to
8189 find a suitable prev_stop when we find ourselves before
8191 (reseat): Don't look for prev_stop, as that could mean a very long
8193 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8194 <cached_disp_overlay_modiff>: Cache for last found display string
8196 (compute_display_string_pos): Return the cached position if asked
8197 about the same buffer in the same area of character positions, and
8198 the buffer wasn't changed since the time the display string
8199 position was cached.
8201 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8203 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8204 is an integer, which is important for empty lines. (Bug#9149)
8206 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
8208 * frame.c (Fmodify_frame_parameters): In tty case, update the
8209 default face if necessary (Bug#4238).
8211 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
8213 * editfns.c (Fstring_to_char): No need to explain what a character
8214 is in the docstring (Bug#6576).
8216 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8218 * xml.c (parse_region): Make sure we always return a tree.
8220 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8222 * xml.c (parse_region): If a document contains only comments,
8225 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8227 * xml.c (make_dom): Return comments, too.
8229 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8232 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8233 and the surrounding thread.
8234 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8235 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8236 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8238 * s/openbsd.h (BROKEN_SIGIO): Define.
8239 * unexelf.c (unexec) [__OpenBSD__]:
8240 Don't update the .mdebug section of the Alpha COFF symbol table.
8242 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8244 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8247 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8249 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8250 This fixes some race conditions on the permissions of any newly
8253 * alloc.c (valid_pointer_p): Use pipe, not open.
8254 This fixes some permissions issues when debugging.
8256 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8257 If fchown fails to set both uid and gid, try to set just gid,
8258 as that is sometimes allowed. Adjust the file's mode to eliminate
8259 setuid or setgid bits that are inappropriate if fchown fails.
8261 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8263 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8264 to compare Lisp_Objects.
8265 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8266 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8267 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8269 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8271 * lread.c (read_integer): Unread even EOF character.
8272 (read1): Likewise. Properly record start position of symbol.
8274 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8275 symbol character follows.
8277 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8279 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8280 This works around a problem with the previous change to Fcopy_file.
8281 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8282 and without this change, GCC might complain about discarding
8283 fchown's return value.
8285 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
8287 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8289 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8291 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8293 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8295 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8296 it's used from the C level.
8298 * process.c: Use the same condition for POLL_FOR_INPUT in both
8299 keyboard.c and process.c (bug#1858).
8301 2011-07-09 Lawrence Mitchell <wence@gmx.li>
8303 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8304 (Fgnutls_boot): Use it.
8306 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8308 * doc.c (Fsubstitute_command_keys): Revert last change.
8310 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8312 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8313 quotes the next character, and doesn't affect other longer
8314 sequences (bug#8935).
8316 * lread.c (syms_of_lread): Clarify that is isn't only
8317 `eval-buffer' and `eval-defun' that's affected by
8318 `lexical-binding' (bug#8460).
8320 2011-07-15 Eli Zaretskii <eliz@gnu.org>
8322 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
8323 bidi redisplay when a line includes both an image and is truncated.
8325 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8327 Fix minor problems found by static checking.
8328 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8329 (elsz): Now a signed constant, not a size_t var. We prefer signed
8330 types to unsigned, to avoid integer comparison confusion. Without
8331 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8332 "cannot optimize loop, the loop counter may overflow", a symptom
8334 * indent.c (Fvertical_motion): Mark locals as initialized.
8335 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8337 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8339 * search.c (Fre_search_backward): Mention `case-fold-search' in
8340 all the re_search_* functions (bug#8138).
8342 * keyboard.c (Fopen_dribble_file): Document when the file is
8345 2011-07-14 Eli Zaretskii <eliz@gnu.org>
8347 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8350 Support bidi reordering of display and overlay strings.
8351 * xdisp.c (compute_display_string_pos)
8352 (compute_display_string_end): Accept additional argument STRING.
8353 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8354 (reseat_to_string): Initialize bidi_it->string.s and
8355 bidi_it->string.schars.
8356 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
8357 NULL (avoids a crash in bidi_paragraph_init).
8358 Initialize itb.string.lstring.
8359 (init_iterator): Call bidi_init_it only of a valid
8360 buffer position was specified. Initialize paragraph_embedding to
8362 (reseat_to_string): Initialize the bidi iterator.
8363 (display_string): If we need to ignore text properties of
8364 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8365 original value of -1 will not work with bidi.)
8366 (compute_display_string_pos): First arg is now struct
8367 `text_pos *'; all callers changed. Support display properties on
8369 (compute_display_string_end): Support display properties on Lisp
8371 (init_iterator, reseat_1, reseat_to_string): Initialize the
8372 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8373 when iterating on a string not from display properties).
8374 (compute_display_string_pos, compute_display_string_end):
8375 Fix calculation of the object to scan. Fixes an error when using
8377 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
8378 base_level_stop; instead, set base_level_stop to BEGV.
8379 Fixes crashes in vertical-motion.
8380 (next_element_from_buffer): Improve commentary for when
8381 the iterator is before prev_stop.
8382 (init_iterator): Initialize bidi_p from the default value of
8383 bidi-display-reordering, not from buffer-local value. Use the
8384 buffer-local value only if initializing for buffer iteration.
8385 (handle_invisible_prop): Support invisible properties on strings
8386 that are being bidi-reordered.
8387 (set_iterator_to_next): Support bidi reordering of C strings and
8389 (next_element_from_string): Support bidi reordering of Lisp
8391 (handle_stop_backwards): Support Lisp strings as well.
8392 (display_string): Support display of R2L glyph rows.
8393 Use IT_STRING_CHARPOS when displaying from a Lisp string.
8394 (init_iterator): Don't initialize it->bidi_p for strings
8396 (reseat_to_string): Initialize it->bidi_p for strings here.
8397 (next_element_from_string, next_element_from_c_string)
8398 (next_element_from_buffer): Add xassert's for correspondence
8399 between IT's object being iterated and it->bidi_it.string
8401 (face_before_or_after_it_pos): Support bidi iteration.
8402 (next_element_from_c_string): Handle the case of the first string
8403 character that is not the first one in the visual order.
8404 (get_visually_first_element): New function, refactored from common
8405 parts of next_element_from_buffer, next_element_from_string, and
8406 next_element_from_c_string.
8407 (tool_bar_lines_needed, redisplay_tool_bar)
8408 (display_menu_bar): Force left-to-right direction. Add a FIXME
8409 comment for making that be controlled by a user option.
8410 (push_it, pop_it): Save and restore the state of the
8411 bidi iterator. Save and restore the bidi_p flag.
8412 (pop_it): Iterate out of display property for string iteration as
8414 (iterate_out_of_display_property): Support iteration over strings.
8415 (handle_single_display_spec): Set up it->bidi_it for iteration
8416 over a display string, and call bidi_init_it.
8417 (handle_single_display_spec, next_overlay_string)
8418 (get_overlay_strings_1, push_display_prop): Set up the bidi
8419 iterator for displaying display or overlay strings.
8420 (forward_to_next_line_start): Don't use the shortcut if
8422 (back_to_previous_visible_line_start): If handle_display_prop
8423 pushed the iterator stack, restore the internal state of the bidi
8424 iterator by calling bidi_pop_it same number of times.
8425 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8426 and we are bidi-iterating, don't decrement the iterator position;
8427 instead, set the first_elt flag in the bidi iterator, to produce
8429 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8430 (push_display_prop): xassert that we are iterating a buffer.
8431 (push_it, pop_it): Save and restore paragraph_embedding member.
8432 (handle_single_display_spec, next_overlay_string)
8433 (get_overlay_strings_1, reseat_1, reseat_to_string)
8434 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8435 correctly. Don't assume unibyte strings are not bidi-reordered.
8436 (compute_display_string_pos)
8437 (compute_display_string_end): Fix handling the case of C string.
8438 (push_it, pop_it): Save and restore from_disp_prop_p.
8439 (handle_single_display_spec, push_display_prop): Set the
8440 from_disp_prop_p flag.
8441 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8442 (pop_it): Call iterate_out_of_display_property only if we are
8443 popping after iteration over a string that came from a display
8444 property. Fix a typo in popping stretch info. Add an assertion
8445 for verifying that the iterator position is in sync with the bidi
8447 (handle_single_display_spec, get_overlay_strings_1)
8448 (push_display_prop): Fix initialization of paragraph direction for
8449 string when that of the parent object is not yet determined.
8450 (reseat_1): Call bidi_init_it to resync the bidi
8451 iterator with IT's position. (Bug#7616)
8452 (find_row_edges): If ROW->start.pos gives position
8453 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8454 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8455 Reset the from_disp_prop_p flag.
8456 (SAVE_IT, RESTORE_IT): New macros.
8457 (pos_visible_p, face_before_or_after_it_pos)
8458 (back_to_previous_visible_line_start)
8459 (move_it_in_display_line_to, move_it_in_display_line)
8460 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8461 (try_scrolling, redisplay_window, display_line): Use them when
8462 saving a temporary copy of the iterator and restoring it back.
8463 (back_to_previous_visible_line_start, reseat_1)
8464 (init_iterator): Empty the bidi cache "stack".
8465 (move_it_in_display_line_to): If iterator ended up at
8466 EOL, but we never saw any buffer positions smaller than
8467 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8468 motion in bidi-reordered lines.
8469 (move_it_in_display_line_to): Record prev_method and prev_pos
8470 immediately before the call to set_iterator_to_next. Fixes cursor
8471 motion in bidi-reordered lines with stretch glyphs and strings
8472 displayed in margins. (Bug#8133) (Bug#8867)
8473 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8475 (pos_visible_p): Support positions in bidi-reordered lines.
8476 Save and restore bidi cache.
8478 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8479 (bidi_paragraph_info): Delete unused struct.
8480 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8481 (bidi_cache_start): New variable.
8482 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8484 (bidi_cache_fetch_state, bidi_cache_search)
8485 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8486 (bidi_cache_find, bidi_peek_at_next_level)
8487 (bidi_level_of_next_char, bidi_find_other_level_edge)
8488 (bidi_move_to_visually_next): Compare cache index with
8489 bidi_cache_start rather than with zero.
8490 (bidi_fetch_char): Accept new argument STRING; all callers
8491 changed. Support iteration over a string. Support strings with
8492 display properties. Support unibyte strings. Fix the type of
8493 `len' according to what STRING_CHAR_AND_LENGTH expects.
8494 (bidi_paragraph_init, bidi_resolve_explicit_1)
8495 (bidi_resolve_explicit, bidi_resolve_weak)
8496 (bidi_level_of_next_char, bidi_move_to_visually_next):
8497 Support iteration over a string.
8498 (bidi_set_sor_type, bidi_resolve_explicit_1)
8499 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8500 can now be zero (for strings); special values 0 and -1 were
8501 changed to -1 and -2, respectively.
8502 (bidi_char_at_pos): New function.
8503 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8504 Call it instead of FETCH_MULTIBYTE_CHAR.
8505 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8506 initialized to valid values.
8507 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8509 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8510 the test for valid cached positions. Fix the logic for looking up
8511 the sentinel state in the cache. GCPRO the Lisp string we are
8513 (bidi_push_it, bidi_pop_it): New functions.
8514 (bidi_initialize): Initialize the bidi cache start stack pointer.
8515 (bidi_cache_ensure_space): New function, refactored from part of
8516 bidi_cache_iterator_state. Don't assume the required size is just
8517 one BIDI_CACHE_CHUNK away.
8518 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8519 (bidi_count_bytes, bidi_char_at_pos): New functions.
8520 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8521 always valid if bidi_cache_idx is valid.
8522 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8523 is valid if it's going to be used.
8524 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8525 (bidi_cache_fetch_state, bidi_cache_search)
8526 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8527 (bidi_cache_iterator_state, bidi_cache_find)
8528 (bidi_find_other_level_edge, bidi_cache_start_stack):
8529 All variables related to cache indices are now EMACS_INT.
8531 * dispextern.h (struct bidi_string_data): New structure.
8532 (struct bidi_it): New member `string'. Make flag members be 1-bit
8533 fields, and put them last in the struct.
8534 (compute_display_string_pos, compute_display_string_end):
8536 (bidi_push_it, bidi_pop_it): Add prototypes.
8537 (struct iterator_stack_entry): New members bidi_p,
8538 paragraph_embedding, and from_disp_prop_p.
8539 (struct it): Member bidi_p is now a bit field 1 bit wide.
8540 (bidi_shelve_cache, bidi_unshelve_cache):
8543 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8544 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8545 and vector-like objects.
8547 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8548 cache around display iteration.
8550 * window.c (Fwindow_end, window_scroll_pixel_based)
8551 (displayed_window_lines, Frecenter): Save and restore the bidi
8552 cache around display iteration.
8554 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8556 * editfns.c (Fdelete_region): Clarify the use of the named
8557 parameters (bug#6788).
8559 2011-07-14 Martin Rudalics <rudalics@gmx.at>
8561 * indent.c (Fvertical_motion): Set and restore w->pointm when
8562 saving and restoring the window's buffer (Bug#9006).
8564 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8566 * editfns.c (Fstring_to_char): Clarify just what is returned
8567 (bug#6576). Text by Eli Zaretskii.
8569 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
8571 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8573 2011-07-13 Eli Zaretskii <eliz@gnu.org>
8575 * buffer.c (mmap_find): Fix a typo.
8577 2011-07-13 Johan Bockgård <bojohan@gnu.org>
8579 Fix execution of x selection hooks.
8580 * xselect.c (Qx_lost_selection_functions)
8581 (Qx_sent_selection_functions): New vars.
8582 (syms_of_xselect): DEFSYM them.
8583 (x_handle_selection_request): Pass Qx_sent_selection_functions
8584 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8585 (x_handle_selection_clear,x_clear_frame_selections):
8586 Pass Qx_lost_selection_functions rather than
8587 Vx_lost_selection_functions to Frun_hook_with_args.
8589 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8591 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
8592 The old code sometimes used this field without initializing it.
8594 * alloc.c (gc_sweep): Don't read past end of array.
8595 In theory, the old code could also have corrupted Emacs internals,
8596 though it'd be very unlikely.
8598 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8600 * character.c (Fcharacterp): Don't advertise optional ignored
8601 argument. (Bug#4026)
8603 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8605 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8608 * window.c (Fset_window_start): Doc fix (bug#4199).
8609 (Fset_window_hscroll): Ditto.
8611 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8613 Fix minor new problems caught by GCC 4.6.1.
8614 * term.c (init_tty): Remove unused local.
8615 * xsettings.c (store_monospaced_changed): Define this function only
8616 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
8619 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
8621 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8623 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8625 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8626 are the mini-buffer and the echo area (bug#3320).
8628 * term.c (init_tty): Remove support for supdup, c10 and perq
8629 terminals, which are no longer supported (bug#1482).
8631 2011-07-10 Johan Bockgård <bojohan@gnu.org>
8633 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8635 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8637 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8638 for non-popups (Bug#3642).
8640 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8642 * alloc.c (reset_malloc_hooks): Protoize.
8643 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
8644 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8645 * cm.c (losecursor): Likewise.
8646 * data.c (fmod): Likewise.
8647 * dispnew.c (swap_glyphs_in_rows): Likewise.
8648 * emacs.c (memory_warning_signal): Likewise.
8649 * floatfns.c (float_error): Likewise.
8650 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8651 (otf_open, font_otf_capability, generate_otf_features)
8652 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8654 * image.c (pbm_read_file): Likewise.
8655 * indent.c (string_display_width): Likewise.
8656 * intervals.c (check_for_interval, search_for_interval)
8657 (inc_interval_count, count_intervals, root_interval)
8658 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8659 * lread.c (defalias): Likewise.
8660 * ralloc.c (r_alloc_check): Likewise.
8661 * regex.c (set_image_of_range_1, set_image_of_range)
8662 (regex_grow_registers): Likewise.
8663 * sysdep.c (strerror): Likewise.
8664 * termcap.c (valid_filename_p, tprint, main): Likewise.
8665 * tparam.c (main): Likewise.
8666 * unexhp9k800.c (run_time_remap, save_data_space)
8667 (update_file_ptrs, read_header, write_header, calculate_checksum)
8668 (copy_file, copy_rest, display_header): Likewise.
8669 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8671 * xdisp.c (check_it): Likewise.
8672 * xfaces.c (register_color, unregister_color, unregister_colors):
8674 * xfns.c (print_fontset_result): Likewise.
8675 * xrdb.c (member, fatal, main): Likewise.
8677 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8679 Fix minor problems found by static checking (Bug#9031).
8680 * chartab.c (char_table_set_range, map_sub_char_table):
8681 Remove unused locals.
8682 (uniprop_table): Now static.
8683 * composite.c (_work_char): Remove unused static var.
8685 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
8687 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8689 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8691 * gtkutil.c (qttip_cb): Remove code without function.
8693 2011-07-09 Eli Zaretskii <eliz@gnu.org>
8695 * w32.c (pthread_sigmask): New stub.
8697 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
8699 Use pthread_sigmask, not sigprocmask (Bug#9010).
8700 sigprocmask is portable only for single-threaded applications, and
8701 Emacs can be multi-threaded when it uses GTK.
8702 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8704 * callproc.c (Fcall_process):
8705 * process.c (create_process):
8706 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8707 Use pthread_sigmask, not sigprocmask.
8709 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8711 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8712 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8715 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8717 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8718 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8719 (xg_hide_tooltip): Fix comment.
8721 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8722 in registerServicesMenuSendTypes.
8723 (validRequestorForSendType): Don't check ns_return_types.
8725 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8728 2011-07-08 Jason Rumney <jasonr@gnu.org>
8730 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8731 SH_SHOW for hidden windows (Bug#5482).
8733 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8734 frame struct members of non-existent frames (Bug#6284).
8736 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8738 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8739 variable firstTime not needed on OSX >= 10.6.
8740 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8741 >= 10.5. Use setKnobProportion, setDoubleValue.
8743 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8744 (MAC_OS_X_VERSION_10_5): Define if not defined.
8745 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8746 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8747 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8749 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
8750 cString and lossyCString on OSX >= 10.4.
8752 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
8753 sizeToFit on OSX >= 10.2.
8755 * nsimage.m (allocInitFromFile): Don't use deprecated method
8756 bestRepresentationForDevice on OSX >= 10.6.
8758 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8761 * emacs.c: Declare unexec_init_emacs_zone.
8763 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8765 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8767 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8768 on svcsMenu (Bug#8842).
8770 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8772 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8774 * nsterm.m (QUTF8_STRING): Declare.
8775 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8776 (validRequestorForSendType): Return type is (id).
8777 Change indexOfObjectIdenticalTo to indexOfObject.
8778 Check if we have local selection before returning self (Bug#8842).
8779 (writeSelectionToPasteboard): Put local selection into paste board
8780 if we have a local selection (Bug#8842).
8781 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8783 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8784 (ns_get_local_selection): Declare.
8786 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8788 * keymap.c (describe_map_tree): Don't insert a double newline at
8789 the end of the buffer (bug#1169) and return whether we inserted
8792 * callint.c (Fcall_interactively): Change "reading args" to
8793 "providing args" to try to clarify what it does (bug#1010).
8795 2011-07-07 Kenichi Handa <handa@m17n.org>
8797 * composite.c (composition_compute_stop_pos): Ignore a static
8798 composition starting before CHARPOS (Bug#8915).
8800 * xdisp.c (handle_composition_prop): Likewise.
8802 2011-07-07 Eli Zaretskii <eliz@gnu.org>
8804 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8807 2011-07-07 Kenichi Handa <handa@m17n.org>
8809 * character.h (unicode_category_t): New enum type.
8811 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8812 (Qchar_code_property_table): New variable.
8813 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8814 (UNIPROP_COMPRESSED_FORM_P): New macros.
8815 (char_table_ascii): Uncompress the compressed values.
8816 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8817 Uncompress the compressed values.
8818 (sub_char_table_ref_and_range): Likewise.
8819 (char_table_ref_and_range): Uncompress the compressed values.
8820 (sub_char_table_set): New arg is_uniprop. Callers changed.
8821 Uncompress the compressed values.
8822 (sub_char_table_set_range): Args changed. Callers changed.
8823 (char_table_set_range): Adjuted for the above change.
8824 (map_sub_char_table): Delete args default_val and parent. Add arg
8825 top. Give decoded values to a Lisp function.
8826 (map_char_table): Adjust for the above change. Give decoded
8827 values to a Lisp function. Gcpro more variables.
8828 (uniprop_table_uncompress)
8829 (uniprop_decode_value_run_length): New functions.
8830 (uniprop_decoder, uniprop_decoder_count): New variables.
8831 (uniprop_get_decoder, uniprop_encode_value_character)
8832 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8834 (uniprop_encoder, uniprop_encoder_count): New variables.
8835 (uniprop_get_encoder, uniprop_table)
8836 (Funicode_property_table_internal, Fget_unicode_property_internal)
8837 (Fput_unicode_property_internal): New functions.
8838 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8839 Sunicode_property_table_internal, Sget_unicode_property_internal,
8840 and Sput_unicode_property_internal. Defvar_lisp
8841 char-code-property-alist.
8843 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
8844 Vunicode_category_table.
8846 * font.c (font_range): Adjust for the change of
8847 Vunicode_category_table.
8849 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8851 * m/iris4d.h: Remove file, move contents ...
8852 * s/irix6-5.h: ... here.
8854 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8856 Remove unportable assumption about struct layout (Bug#8884).
8857 * alloc.c (mark_buffer):
8858 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8859 (clone_per_buffer_values): Don't assume that
8860 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8861 This isn't true in general, and it's particularly not true
8862 if Emacs is configured with --with-wide-int.
8863 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8864 New macros, used in the buffer.c change.
8866 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8868 * xsettings.c: Use both GConf and GSettings if both are available.
8869 (store_config_changed_event): Add comment.
8870 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8871 (store_tool_bar_style_changed): New functions.
8872 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
8873 (struct xsettings): Move font inside HAVE_XFT.
8874 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
8875 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
8876 Move inside HAVE_XFT.
8877 (something_changed_gsettingsCB): Rename from something_changedCB.
8878 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8880 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
8881 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
8882 (something_changed_gconfCB): Rename from something_changedCB.
8883 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8884 (parse_settings): Move check for font inside HAVE_XFT.
8885 (read_settings, apply_xft_settings): Add comment.
8886 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8887 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8888 call store_font_name_changed.
8889 (xft_settings_event): Add comment.
8890 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8891 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8892 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8893 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8894 (xsettings_initialize): Call init_gsettings last.
8895 (xsettings_get_system_font, xsettings_get_system_normal_font):
8898 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8900 Random fixes. E.g., (random) never returned negative values.
8901 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8902 subseconds part to the entropy, as that's a bit more random.
8903 Prefer signed to unsigned, since the signedness doesn't matter and
8904 in general we prefer signed. When given a limit, use a
8905 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8906 latter isn't right if USE_2_TAGS_FOR_INTS.
8907 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8908 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8910 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8912 * textprop.c (text_property_stickiness):
8913 Obey Vtext_property_default_nonsticky.
8914 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8915 * w32fns.c (syms_of_w32fns):
8916 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8918 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8920 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8921 This is more efficient than Ffile_directory_p and avoids a minor race.
8923 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8925 * buffer.c (Foverlay_put): Say what the return value is
8928 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8929 is a directory before asking whether to use the file name
8931 (barf_or_query_if_file_exists): Make the "File is a directory"
8932 error be more correct.
8934 * fns.c (Frequire): Remove the mention of the .gz files, since
8935 that's installation-specific, but keep the mention of
8936 `get-load-suffixes'.
8938 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8940 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8941 Report string overflow if the output is too long.
8943 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
8945 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8946 (syms_of_gnutls): Remove duplicate DEFSYM for
8947 Qgnutls_bootprop_verify_hostname_error, an error for
8948 Qgnutls_bootprop_verify_error (which is no longer used).
8950 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8951 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8952 Also (re)move comments that are misplaced or no longer relevant.
8954 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8956 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8958 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
8960 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8961 and background color parameters if they have been changed.
8963 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8965 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8967 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8969 * xsettings.c (SYSTEM_FONT): Define only when used.
8970 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8972 * keymap.c (access_keymap_1): Now static.
8974 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
8976 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8977 leave any prefix arg for the up event (Bug#1586).
8979 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8981 * lread.c (syms_of_lread): Mention single symbols defined by
8982 `defvar' or `defconst' (bug#7154).
8984 * fns.c (Frequire): Mention .el.gz files (bug#7314).
8985 (Frequire): Mention get-load-suffixes.
8987 2011-07-02 Martin Rudalics <rudalics@gmx.at>
8989 * window.h (window): Remove clone_number slot.
8990 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8992 (make_parent_window, make_window, saved_window)
8993 (Fset_window_configuration, save_window_save): Don't deal with
8995 * buffer.c (Qclone_number): Remove declaration.
8996 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8998 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9000 Add multiple inheritance to keymaps.
9001 * keymap.c (Fmake_composed_keymap): New function.
9002 (Fset_keymap_parent): Simplify.
9003 (fix_submap_inheritance): Remove.
9004 (access_keymap_1): New function extracted from access_keymap to handle
9005 embedded parents and handle lists of maps.
9006 (access_keymap): Use it.
9007 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9008 (Fcopy_keymap): Handle embedded parents.
9009 (Fcommand_remapping, define_as_prefix): Simplify.
9010 (Fkey_binding): Simplify.
9011 (syms_of_keymap): Move minibuffer-local-completion-map,
9012 minibuffer-local-filename-completion-map,
9013 minibuffer-local-must-match-map, and
9014 minibuffer-local-filename-must-match-map to Elisp.
9015 (syms_of_keymap): Defsubr make-composed-keymap.
9016 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9017 (parse_menu_item): Trivial simplification.
9019 2011-07-01 Glenn Morris <rgm@gnu.org>
9021 * Makefile.in (SETTINGS_LIBS): Fix typo.
9023 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9025 * coding.c (Fencode_coding_string): Record the last coding system
9026 used, as the function doc string says (bug#8738).
9028 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9030 * xsettings.c (store_monospaced_changed): Take new font as arg and
9031 check for change against current_mono_font.
9032 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9033 (emacs_settings_constructor, emacs_settings_get_property)
9034 (emacs_settings_set_property, emacs_settings_class_init)
9035 (emacs_settings_init, gsettings_obj): Remove.
9036 (something_changedCB): New function for HAVE_GSETTINGS.
9037 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9038 with value as argument.
9039 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9040 g_settings_new (Bug#8967). Do not create gsettings_obj.
9041 Remove calls to g_settings_bind. Connect something_changedCB to
9044 * xgselect.c: Add defined (HAVE_GSETTINGS).
9045 (xgselect_initialize): Ditto.
9047 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9048 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9051 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9053 * eval.c (struct backtrace): Simplify and port the data structure.
9054 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9055 signed bit field, as this assumption is not portable and it makes
9056 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9057 "char debug_on_exit : 1" as this is not portable either; instead,
9058 use the portable "unsigned int debug_on_exit : 1". Remove unused
9059 member evalargs. Remove obsolete comments about cc bombing out.
9061 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9063 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9064 Let HAVE_GSETTINGS override HAVE_GCONF.
9065 (store_monospaced_changed): New function.
9066 (EMACS_SETTINGS): A new type derived from GObject to handle
9067 GSettings notifications.
9068 (emacs_settings_constructor, emacs_settings_get_property)
9069 (emacs_settings_set_property, emacs_settings_class_init):
9071 (gsettings_client, gsettings_obj): New variables.
9072 (GSETTINGS_SCHEMA): New define.
9073 (something_changedCB): Call store_monospaced_changed.
9074 (init_gsettings): New function.
9075 (xsettings_initialize): Call init_gsettings.
9076 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9079 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9082 2011-06-29 Martin Rudalics <rudalics@gmx.at>
9084 * window.c (resize_root_window, grow_mini_window)
9085 (shrink_mini_window): Rename Qresize_root_window to
9086 Qwindow_resize_root_window and Qresize_root_window_vertically to
9087 Qwindow_resize_root_window_vertically.
9089 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9091 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9093 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
9095 * makefile.w32-in: Redesign dependencies so they reflect more
9096 clearly which files are directly included by each source file,
9097 and not through other includes.
9099 2011-06-27 Martin Rudalics <rudalics@gmx.at>
9101 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9102 (sort_overlays, overlay_strings): When an overlay's clone number
9103 matches the window's clone number process the overlay even if
9104 the overlay's window property doesn't match the current window.
9106 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9107 (Fwindow_hchild): Rename to Fwindow_left_child.
9108 (Fwindow_next): Rename to Fwindow_next_sibling.
9109 (Fwindow_prev): Rename to Fwindow_prev_sibling.
9110 (resize_window_check): Rename to window_resize_check.
9111 (resize_window_apply): Rename to window_resize_apply.
9112 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9113 (Fdelete_other_windows_internal, resize_frame_windows)
9114 (Fsplit_window_internal, Fdelete_window_internal)
9115 (grow_mini_window, shrink_mini_window)
9116 (Fresize_mini_window_internal): Fix callers accordingly.
9118 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9120 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9121 (emacs_fixed_set_min_size): Remove.
9122 (emacs_fixed_new): Take frame as argument.
9124 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9125 (_EmacsFixedPrivate): Remove minwidth/height.
9126 Add struct frame *f.
9127 (emacs_fixed_init): Initialize priv->f.
9128 (get_parent_class, emacs_fixed_set_min_size): Remove.
9129 (emacs_fixed_new): Set priv->f to argument.
9130 (emacs_fixed_get_preferred_width)
9131 (emacs_fixed_get_preferred_height): Use min_width/height from
9132 frames size_hint to set minimum and natural (Bug#8919).
9133 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9134 and use min_width/height from frames size_hint to set
9135 min_width/height (Bug#8919).
9137 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9138 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9141 2011-06-26 Eli Zaretskii <eliz@gnu.org>
9143 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9144 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9147 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
9149 * process.c (wait_reading_process_output): Bypass select if
9150 waiting for a cell while ignoring keyboard input, and input is
9151 pending. Suggested by Jan Djärv (Bug#8869).
9153 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9155 Use gnulib's dup2 module instead of rolling our own.
9156 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9158 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9160 * dispnew.c (scrolling_window): Before scrolling, turn off a
9161 mouse-highlight in the window being scrolled.
9163 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
9165 Move DEFSYM to lisp.h and use everywhere.
9167 * character.h (DEFSYM): Move declaration...
9168 * lisp.h (DEFSYM): ...here.
9174 * w32select.c: Don't include character.h.
9176 * alloc.c (syms_of_alloc):
9177 * buffer.c (syms_of_buffer):
9178 * bytecode.c (syms_of_bytecode):
9179 * callint.c (syms_of_callint):
9180 * casefiddle.c (syms_of_casefiddle):
9181 * casetab.c (init_casetab_once):
9182 * category.c (init_category_once, syms_of_category):
9183 * ccl.c (syms_of_ccl):
9184 * cmds.c (syms_of_cmds):
9185 * composite.c (syms_of_composite):
9186 * dbusbind.c (syms_of_dbusbind):
9187 * dired.c (syms_of_dired):
9188 * dispnew.c (syms_of_display):
9189 * doc.c (syms_of_doc):
9190 * editfns.c (syms_of_editfns):
9191 * emacs.c (syms_of_emacs):
9192 * eval.c (syms_of_eval):
9193 * fileio.c (syms_of_fileio):
9194 * fns.c (syms_of_fns):
9195 * frame.c (syms_of_frame):
9196 * fringe.c (syms_of_fringe):
9197 * insdel.c (syms_of_insdel):
9198 * keymap.c (syms_of_keymap):
9199 * lread.c (init_obarray, syms_of_lread):
9200 * macros.c (syms_of_macros):
9201 * msdos.c (syms_of_msdos):
9202 * print.c (syms_of_print):
9203 * process.c (syms_of_process):
9204 * search.c (syms_of_search):
9205 * sound.c (syms_of_sound):
9206 * syntax.c (init_syntax_once, syms_of_syntax):
9207 * terminal.c (syms_of_terminal):
9208 * textprop.c (syms_of_textprop):
9209 * undo.c (syms_of_undo):
9210 * w32.c (globals_of_w32):
9211 * window.c (syms_of_window):
9212 * xdisp.c (syms_of_xdisp):
9213 * xfaces.c (syms_of_xfaces):
9214 * xfns.c (syms_of_xfns):
9215 * xmenu.c (syms_of_xmenu):
9216 * xsettings.c (syms_of_xsettings):
9217 * xterm.c (syms_of_xterm): Use DEFSYM.
9219 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9221 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
9223 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9225 Integer and buffer overflow fixes (Bug#8873).
9227 * print.c (printchar, strout): Check for string overflow.
9228 (PRINTPREPARE, printchar, strout):
9229 Don't set size unless allocation succeeds.
9231 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9232 for sizes. Check for string overflow more accurately.
9233 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9235 * macros.c: Integer and buffer overflow fixes.
9236 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9237 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9238 Use ptrdiff_t, not int, for sizes.
9239 Don't increment bufsize until after realloc succeeds.
9240 Check for size-calculation overflow.
9241 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9243 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9245 * lread.c: Integer overflow fixes.
9246 (read_integer): Radix is now EMACS_INT, not int,
9247 to improve quality of diagnostics for out-of-range radices.
9248 Calculate buffer size correctly for out-of-range radices.
9249 (read1): Check for integer overflow in radices, and in
9250 read-circle numbers.
9251 (read_escape): Avoid int overflow.
9252 (Fload, openp, read_buffer_size, read1)
9253 (substitute_object_recurse, read_vector, read_list, map_obarray):
9254 Use ptrdiff_t, not int, for sizes.
9255 (read1): Use EMACS_INT, not int, for sizes.
9256 Check for size overflow.
9258 * image.c (cache_image): Check for size arithmetic overflow.
9260 * lread.c: Integer overflow issues.
9261 (saved_doc_string_size, saved_doc_string_length)
9262 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9263 Now ptrdiff_t, not int.
9264 (read1): Don't assume doc string length fits in int. Check for
9265 out-of-range doc string lengths.
9266 (read_list): Don't assume file position fits in int.
9267 (read_escape): Check for hex character overflow.
9269 2011-06-22 Leo Liu <sdl.web@gmail.com>
9271 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9272 Move to minibuffer.el.
9274 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9276 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
9277 The following patches are for when GLYPH_DEBUG && !XASSERT.
9278 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9279 * dispnew.c (flush_stdout):
9280 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9281 Mark as externally visible.
9282 * dispnew.c (check_window_matrix_pointers): Now static.
9283 * dispnew.c (window_to_frame_vpos):
9284 * xfns.c (unwind_create_frame):
9285 * xterm.c (x_check_font): Remove unused local.
9286 * scroll.c (CHECK_BOUNDS):
9287 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9288 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9289 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9290 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9291 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9293 (debug_method_add): Use va_list and vsprintf rather than relying
9294 on undefined behavior with wrong number of arguments.
9295 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9296 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9297 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9298 since we're not interested in debugging glyphs with old libraries.
9299 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9300 GCC 4.6.0's static checking.
9302 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9304 Integer overflow and signedness fixes (Bug#8873).
9305 A few related buffer overrun fixes, too.
9307 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9309 * dispextern.h (struct face.stipple):
9310 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9311 (x_bitmap_mask, x_allocate_bitmap_record)
9312 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9313 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9314 (x_create_bitmap_from_xpm_data):
9315 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9316 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9318 * xfaces.c (load_pixmap):
9319 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9320 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9321 (.bitmaps_last, struct x_output.icon_bitmap):
9322 Use ptrdiff_t, not int, for bitmap indexes.
9323 (x_allocate_bitmap_record): Check for size overflow.
9324 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9326 Use ptrdiff_t, not int, for overlay counts.
9327 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9328 * editfns.c (overlays_around, get_pos_property):
9329 * textprop.c (get_char_property_and_overlay):
9330 * xdisp.c (next_overlay_change, note_mouse_highlight):
9331 * xfaces.c (face_at_buffer_position):
9332 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9333 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9334 (Fnext_overlay_change, Fprevious_overlay_change)
9335 (mouse_face_overlay_overlaps, Foverlays_in):
9336 Use ptrdiff_t, not int, for sizes.
9337 (overlays_at, overlays_in): Check for size-calculation overflow.
9339 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9341 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9342 (x_session_initialize): Do not assume string length fits in int.
9344 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9345 This is unlikely, but can occur if DPI is outlandish.
9347 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
9348 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9350 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9351 * xrdb.c (magic_file_p, search_magic_path):
9352 Omit last arg SUFFIX; it was always 0. All callers changed.
9353 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9355 * xfont.c (xfont_match): Avoid need for strlen.
9357 * xfns.c: Don't assume strlen fits in int.
9358 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9360 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9361 not unsigned long, as we prefer signed integers. All callers changed.
9362 Detect integer overflow in repeat count.
9363 (message_dolog): Don't assume print length fits in 39 bytes.
9364 (display_mode_element): Don't assume strlen fits in int.
9366 * termcap.c: Don't assume sizes fit in int and never overflow.
9367 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9368 (gobble_line): Check for size-calculation overflow.
9370 * minibuf.c (Fread_buffer):
9371 * lread.c (intern, intern_c_string):
9372 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9373 Don't assume string length fits in int.
9375 * keyboard.c (parse_tool_bar_item):
9376 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9378 * font.c: Don't assume string length fits in int.
9379 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9380 Use ptrdiff_t, not int.
9381 (font_intern_prop): Don't assume string length fits in int.
9382 Don't assume integer property fits in fixnum.
9383 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
9385 * filelock.c: Fix some buffer overrun and integer overflow issues.
9386 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
9387 Reformulate so as not to need the command string.
9388 Invoke gzip -cd rather than gunzip, as it's more portable.
9389 (lock_info_type, lock_file_1, lock_file):
9390 Don't assume pid_t and time_t fit in unsigned long.
9391 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9392 (current_lock_owner): Prefer signed type for sizes.
9393 Use memcpy, not strncpy, where memcpy is what is really wanted.
9394 Don't assume (via atoi) that time_t and pid_t fit in int.
9395 Check for time_t and/or pid_t out of range, e.g., via a network share.
9396 Don't alloca where an auto var works fine.
9398 * fileio.c: Fix some integer overflow issues.
9399 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9400 Don't assume string length fits in int.
9401 (directory_file_name): Don't assume string length fits in long.
9402 (make_temp_name): Don't assume pid fits in int, or that its print
9403 length is less than 20.
9405 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9407 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9409 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9411 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9412 We prefer signed integers, even for size calculations.
9414 * emacs.c: Don't assume string length fits in 'int'.
9415 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9416 (main): Don't invoke strlen when not needed.
9418 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9419 (XD_DEBUG_MESSAGE): Don't waste a byte.
9421 * callproc.c (getenv_internal_1, getenv_internal)
9423 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9425 * lread.c (invalid_syntax): Omit length argument.
9426 All uses changed. This doesn't fix a bug, but it simplifies the
9427 code away from its former Hollerith-constant appearance, and it's
9428 one less 'int' to worry about when looking at integer-overflow issues.
9429 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
9431 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9432 This didn't break anything, but it didn't help either.
9433 It's confusing to put a bogus integer in a place where the actual
9434 value does not matter.
9435 (LIST_END_P): Remove unused macro and its bogus comment.
9436 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
9438 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9439 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9441 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9442 We prefer signed types, and the value cannot exceed the EMACS_INT
9443 range anyway (because otherwise the length would not be representable).
9444 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9445 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9446 This avoids a GCC warning when WIDE_EMACS_INT.
9448 * indent.c (sane_tab_width): New function.
9449 (current_column, scan_for_column, Findent_to, position_indentation)
9450 (compute_motion): Use it. This is just for clarity.
9451 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
9453 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
9455 * lisp.h (lint_assume): New macro.
9456 * composite.c (composition_gstring_put_cache):
9457 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9459 * editfns.c, insdel.c:
9460 Omit unnecessary forward decls, to simplify future changes.
9462 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9464 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9466 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
9467 Use much-faster test for byte-length change.
9468 Don't assume string byte-length fits in 'int'.
9469 Check that character arg fits in 'int'.
9470 (mapcar1): Declare byte as byte, for clarity.
9472 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9474 * fns.c (concat): Catch string overflow earlier.
9475 Do not rely on integer wraparound.
9477 * dispextern.h (struct it.overlay_strings_charpos)
9478 (struct it.selective): Now EMACS_INT, not int.
9479 * xdisp.c (forward_to_next_line_start)
9480 (back_to_previous_visible_line_start)
9481 (reseat_at_next_visible_line_start, next_element_from_buffer):
9482 Don't arbitrarily truncate the value of 'selective' to int.
9484 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9486 * composite.c: Don't truncate sizes to 'int'.
9487 (composition_gstring_p, composition_reseat_it)
9488 (composition_adjust_point): Use EMACS_INT, not int.
9489 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9490 not EMACS_UINT, for indexes.
9492 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9494 * buffer.c: Include <verify.h>.
9495 (struct sortvec.priority, struct sortstr.priority):
9496 Now EMACS_INT, not int.
9497 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
9498 (struct sortstr.size, record_overlay_string)
9499 (struct sortstrlist.size, struct sortlist.used):
9500 Don't truncate size to int.
9501 (record_overlay_string): Check for size-calculation overflow.
9502 (init_buffer_once): Check at compile-time, not run-time.
9504 2011-06-22 Jim Meyering <meyering@redhat.com>
9506 Don't leak an XBM-image-sized buffer
9507 * image.c (xbm_load): Free the image buffer after using it.
9509 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9512 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9513 that Sun C diagnosed.
9514 * fns.c (secure_hash): Fix pointer signedness issue.
9515 * intervals.c (static_offset_intervals): New function.
9516 (offset_intervals): Use it.
9518 2011-06-21 Leo Liu <sdl.web@gmail.com>
9521 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9524 * fns.c (secure_hash): Rename from crypto_hash_function and change
9525 the first arg to accept symbols.
9526 (Fsecure_hash): New primitive.
9527 (syms_of_fns): New symbols.
9529 2011-06-20 Deniz Dogan <deniz@dogan.se>
9531 * process.c (Fset_process_buffer): Clarify return value in
9534 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
9536 * dispnew.c (add_window_display_history): Use BVAR.
9538 * xdisp.c (debug_method_add): Use BVAR.
9539 (check_window_end, dump_glyph_matrix, dump_glyph)
9540 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9542 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9545 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9546 check till after the cache is created in init_frame_faces.
9548 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9550 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9552 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9554 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9555 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9556 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9558 Improve buffer-overflow checking (Bug#8873).
9559 * fileio.c (Finsert_file_contents):
9560 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9561 Remove the old (too-loose) buffer overflow checks.
9562 They weren't needed, since make_gap checks for buffer overflow.
9563 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9564 The old code merely checked for Emacs fixnum overflow, and relied
9565 on undefined (wraparound) behavior. The new code avoids undefined
9566 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9568 * editfns.c (Finsert_char): Don't dump core with very negative counts.
9569 Tune. Don't use wider integers than needed. Don't use alloca.
9570 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
9572 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9574 * insdel.c, lisp.h (buffer_overflow): New function.
9575 (insert_from_buffer_1, replace_range, replace_range_2):
9576 * insdel.c (make_gap_larger):
9577 * editfns.c (Finsert_char):
9578 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9580 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9582 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9584 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
9586 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9587 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9589 * fileio.c: Don't assume EMACS_INT fits in off_t.
9590 (emacs_lseek): New static function.
9591 (Finsert_file_contents, Fwrite_region): Use it.
9592 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9594 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9596 * fns.c: Don't overflow int when computing a list length.
9597 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9598 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9599 truncation on 64-bit hosts. Check for QUIT every
9600 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9601 faster and is responsive enough.
9602 (Flength): Report an error instead of overflowing an integer.
9603 (Fsafe_length): Return a float if the value is not representable
9604 as a fixnum. This shouldn't happen except in contrived situations.
9605 (Fnthcdr, Fsort): Don't assume list length fits in int.
9606 (Fcopy_sequence): Don't assume vector length fits in int.
9608 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9609 (header_size, word_size): New constants.
9610 (allocate_vectorlike): Don't check size overflow here.
9611 (allocate_vector): Check it here instead, since this is the only
9612 caller of allocate_vectorlike that could cause overflow.
9613 Check that the new vector's length is representable as a fixnum.
9615 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9616 The previous code was bogus. For example, next_almost_prime (32)
9617 returned 39, which is undesirable as it is a multiple of 3; and
9618 next_almost_prime (24) returned 25, which is a multiple of 5 so
9619 why was the code bothering to check for multiples of 7?
9621 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9623 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9625 Variadic C functions now count arguments with ptrdiff_t.
9626 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9627 Back then I didn't know that the Emacs coding style prefers signed int.
9628 Also, in the meantime I found a few more instances where arguments
9629 were being counted with int, which may truncate counts on 64-bit
9630 machines, or EMACS_INT, which may be unnecessarily wide.
9631 * lisp.h (struct Lisp_Subr.function.aMANY)
9632 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9633 Arg counts are now ptrdiff_t, not size_t.
9634 All variadic functions and their callers changed accordingly.
9635 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9636 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9637 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9638 * callint.c (Fcall_interactively): Check arg count for overflow,
9639 to avoid potential buffer overrun. Use signed char, not 'int',
9640 for 'varies' array, so that we needn't bother to check its size
9641 calculation for overflow.
9642 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9643 * eval.c (apply_lambda):
9644 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9645 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9646 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9648 * callint.c (Fcall_interactively): Don't use index var as event count.
9650 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9651 * mem-limits.h (SIZE): Remove; no longer used.
9653 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
9655 Remove unnecessary casts.
9656 * xterm.c (x_term_init):
9657 * xfns.c (x_set_border_pixel):
9658 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9659 These aren't needed now that we assume ANSI C.
9661 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9662 It's more likely to cause problems (due to unsigned overflow)
9665 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9667 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9669 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9671 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9673 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9675 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9677 GLYPH_CODE_FACE returns EMACS_INT, not int.
9678 * dispextern.h (merge_faces):
9679 * xfaces.c (merge_faces):
9680 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9681 Don't assume EMACS_INT fits in int.
9683 * character.h (CHAR_VALID_P): Remove unused parameter.
9684 * fontset.c, lisp.h, xdisp.c: All uses changed.
9686 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9688 * fns.c (concat): Minor tuning based on overflow analysis.
9689 This doesn't fix any bugs. Use int to hold character, instead
9690 of constantly refetching from Emacs object. Use XFASTINT, not
9691 XINT, for value known to be a character. Don't bother comparing
9692 a single byte to 0400, as it's always less.
9694 * floatfns.c (Fexpt):
9695 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9697 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9700 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9702 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9703 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9704 incorrectly succeed when S was a string, because 4294967386 was
9705 truncated before it was used.
9707 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9708 Otherwise, an out-of-range integer could cause undefined behavior
9711 * composite.c: Use int, not EMACS_INT, for characters.
9712 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9713 EMACS_INT, for values that are known to be in character range.
9714 This doesn't fix any bugs but is the usual style inside Emacs and
9715 may generate better code on 32-bit machines.
9717 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9718 This is for reasons similar to the recent CHAR_STRING fix.
9719 * charset.c (Fencode_char): Check that character arg is actually
9720 a character. Pass an int to ENCODE_CHAR.
9721 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9722 wider than 'int', as a compile-time check to prevent future regressions
9725 * character.c (char_string): Remove unnecessary casts.
9727 Make sure a 64-bit char is never passed to CHAR_STRING.
9728 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9729 by silently ignoring the top 32 bits, allowing some values
9730 that were far too large to be valid characters.
9731 * character.h: Include <verify.h>.
9732 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9733 arguments are no wider than unsigned, as a compile-time check
9734 to prevent future regressions in this area.
9736 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
9737 (Fsubst_char_in_region):
9739 * xdisp.c (decode_mode_spec_coding):
9740 Adjust to CHAR_STRING's new requirement.
9741 * editfns.c (Finsert_char, Fsubst_char_in_region):
9742 * fns.c (concat): Check that character args are actually
9743 characters. Without this test, these functions did the wrong
9744 thing with wildly out-of-range values on 64-bit hosts.
9746 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9747 These casts should not be needed on 32-bit hosts, either.
9748 * keyboard.c (read_char):
9749 * lread.c (Fload): Remove casts to unsigned.
9751 * lisp.h (UNSIGNED_CMP): New macro.
9752 This fixes comparison bugs on 64-bit hosts.
9753 (ASCII_CHAR_P): Use it.
9754 * casefiddle.c (casify_object):
9755 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
9756 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9757 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9758 * dispextern.h (FACE_FROM_ID):
9759 * keyboard.c (read_char): Use UNSIGNED_CMP.
9761 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9762 not to EMACS_INT, to avoid GCC warning.
9764 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9766 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9767 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9768 isn't needed on 32-bit machines.
9770 * buffer.c (Fgenerate_new_buffer_name):
9771 Use EMACS_INT for count, not int.
9772 (advance_to_char_boundary): Return EMACS_INT, not int.
9774 * data.c (Qcompiled_function): Now static.
9776 * window.c (window_body_lines): Now static.
9778 * image.c (gif_load): Rename local to avoid shadowing.
9780 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9781 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9782 * alloc.c (make_save_value): Integer argument is now of type
9784 (mark_object): Use ptrdiff_t, not int.
9785 * lisp.h (pD): New macro.
9786 * print.c (print_object): Use it.
9788 * alloc.c: Use EMACS_INT, not int, to count objects.
9789 (total_conses, total_markers, total_symbols, total_vector_size)
9790 (total_free_conses, total_free_markers, total_free_symbols)
9791 (total_free_floats, total_floats, total_free_intervals)
9792 (total_intervals, total_strings, total_free_strings):
9793 Now EMACS_INT, not int. All uses changed.
9794 (Fgarbage_collect): Compute overall total using a double, so that
9795 integer overflow is less likely to be a problem. Check for overflow
9796 when converting back to an integer.
9797 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9798 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9799 These were 'int' variables that could overflow on 64-bit hosts;
9800 they were never used, so remove them instead of repairing them.
9801 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
9802 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9803 Previously, this ceilinged at INT_MAX, but that doesn't work on
9805 (allocate_pseudovector): Don't use EMACS_INT when int would do.
9807 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
9808 (allocate_vectorlike): Check for ptrdiff_t overflow.
9809 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9810 when a (possibly-narrower) signed value would do just as well.
9811 We prefer using signed arithmetic, to avoid comparison confusion.
9813 * alloc.c: Catch some string size overflows that we were missing.
9814 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9815 for convenience in STRING_BYTES_MAX.
9816 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9817 The definition here is exact; the one in lisp.h was approximate.
9818 (allocate_string_data): Check for string overflow. This catches
9819 some instances we weren't catching before. Also, it catches
9820 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9821 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9822 and ptrdiff_t and EMACS_INT are both 64 bits.
9824 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9825 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
9826 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
9828 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9830 * alloc.c (Fmake_string): Check for out-of-range init.
9832 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9834 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9836 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9838 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9839 xg_get_default_scrollbar_width.
9841 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9842 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9843 (style_changed_cb): Call update_theme_scrollbar_width and call
9844 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9845 all frames (Bug#8505).
9846 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9847 Call gtk_window_set_resizable if HAVE_GTK3.
9848 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9849 and height if HAVE_GTK3 (Bug#8505).
9850 (scroll_bar_width_for_theme): New variable.
9851 (update_theme_scrollbar_width): New function.
9852 (xg_get_default_scrollbar_width): Move code to
9853 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9854 (xg_initialize): Call update_theme_scrollbar_width.
9856 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9858 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9860 2011-06-12 Martin Rudalics <rudalics@gmx.at>
9862 * frame.c (make_frame): Call other_buffer_safely instead of
9865 * window.c (temp_output_buffer_show): Call display_buffer with
9866 second argument Vtemp_buffer_show_specifiers and reset latter
9867 immediately after the call.
9868 (Vtemp_buffer_show_specifiers): New variable.
9869 (auto_window_vscroll_p, next_screen_context_lines)
9870 (Vscroll_preserve_screen_position): Remove leading asterisks from
9873 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
9875 Fix minor problems found by GCC 4.6.0 static checking.
9876 * buffer.c (Qclone_number): Remove for now, as it's unused.
9877 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9878 (record_buffer): Remove unused local.
9879 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9880 (set_frame_buffer_list): Remove; unused.
9881 * frame.h (other_visible_frames): Remove decl.
9882 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9883 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9884 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9886 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9887 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9888 Define only if HAVE_GPM.
9889 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9890 (update_hints_inhibit): Remove; never set. All uses removed.
9891 * widgetprv.h (emacsFrameClassRec): Remove decl.
9892 * window.c (delete_deletable_window): Now returns void, since it
9893 wasn't returning anything.
9894 (compare_window_configurations): Remove unused locals.
9895 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9896 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
9897 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9898 the same widths as pointers. This follows up on the 2011-05-06 patch.
9899 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9900 * xterm.h: Likewise.
9901 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9903 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
9905 * makefile.w32-in: Update dependencies.
9906 (LISP_H): Add lib/intprops.h.
9908 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9910 * image.c (gif_load): Add animation frame delay to the metadata.
9911 (syms_of_image): Use DEFSYM. New symbol `delay'.
9913 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9915 * window.c (delete_deletable_window): Re-add.
9916 (Fset_window_configuration): Rewrite to handle dead buffers and
9917 consequently deletable windows.
9918 (window_tree, Fwindow_tree): Remove. Supply functionality in
9920 (compare_window_configurations): Simplify code.
9922 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9924 * image.c (imagemagick_load_image): Fix type mismatch.
9925 (Fimagemagick_types): Likewise.
9927 * window.h (replace_buffer_in_windows): Declare.
9929 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9931 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9932 Qclone_number. Remove external declaration of Qdelete_window.
9933 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9935 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9936 Run Qbuffer_list_update_hook if allowed.
9937 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9938 buffer list implementation.
9939 (other_buffer_safely): New function.
9940 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9941 calls to replace_buffer_in_windows and
9942 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9944 (record_buffer): Inhibit quitting and rewrite using quittable
9945 functions. Run Qbuffer_list_update_hook if allowed.
9946 (Frecord_buffer, Funrecord_buffer): New functions.
9947 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9948 Move switch-to-buffer to window.el.
9949 (bury-buffer): Move to window.el.
9950 (Vbuffer_list_update_hook): New variable.
9952 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9955 * window.h (resize_frame_windows): Move up in code.
9956 (Fwindow_frame): Remove EXFUN.
9957 (replace_buffer_in_all_windows): Remove prototype.
9958 (replace_buffer_in_windows_safely): Add prototype.
9960 * window.c: Declare Qdelete_window static again. Move down
9961 declaration of select_count.
9962 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9963 (Fother_window): Move to window.el.
9964 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9965 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9966 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9968 (replace_buffer_in_windows): Implement by calling
9969 Qreplace_buffer_in_windows.
9970 (replace_buffer_in_all_windows): Remove with some functionality
9971 moved into replace_buffer_in_windows_safely.
9972 (replace_buffer_in_windows_safely): New function.
9973 (select_window_norecord, select_frame_norecord): Move in front
9974 of run_window_configuration_change_hook. Remove now obsolete
9976 (Fset_window_buffer): Rewrite doc-string.
9977 Call Qrecord_window_buffer.
9978 (keys_of_window): Move binding for other-window to window.el.
9980 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9982 * dispextern.h (struct image): Replace data member, whose int_val
9983 and ptr_val fields were not used by anything, with a single
9986 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9987 (gif_clear_image, gif_load, imagemagick_load_image)
9988 (gs_clear_image, gs_load): Callers changed.
9990 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9992 * buffer.h: Include <time.h>, for time_t.
9993 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9995 Fix minor problems found by static checking.
9997 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9999 Make identifiers static if they are not used in other modules.
10000 * data.c (Qcompiled_function, Qframe, Qvector):
10001 * image.c (QimageMagick, Qsvg):
10002 * minibuf.c (Qmetadata):
10003 * window.c (resize_window_check, resize_root_window): Now static.
10004 * window.h (resize_window_check, resize_root_window): Remove decls.
10006 * window.c (window_deletion_count, delete_deletable_window):
10008 (window_body_lines): Now static.
10009 (Fdelete_other_windows_internal): Mark vars as initialized.
10010 Make sure 'resize_failed' is initialized.
10011 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10012 (resize_window_apply): Remove unused local.
10013 * window.h (delete_deletable_window): Remove decl.
10015 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
10016 (imagemagick_load_image): Fix pointer signedness problem by changing
10017 last arg from unsigned char * to char *. All uses changed.
10018 Also, fix a local for similar reasons.
10019 Remove unused locals. Remove locals to avoid shadowing.
10020 (fn_rsvg_handle_free): Remove; unused.
10021 (svg_load, svg_load_image): Fix pointer signedness problem.
10022 (imagemagick_load_image): Don't use garbage pointer image_wand.
10024 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10026 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
10028 * image.c (gif_load): Fix omitted cast error introduced by
10031 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10033 * window.h (resize_proportionally, orig_total_lines)
10034 (orig_top_line): Remove from window structure.
10035 (set_window_height, set_window_width, change_window_heights)
10036 (Fdelete_window): Remove prototypes.
10037 (resize_frame_windows): Remove duplicate declaration.
10039 2011-06-10 Eli Zaretskii <eliz@gnu.org>
10041 * window.h (resize_frame_windows, resize_window_check)
10042 (delete_deletable_window, resize_root_window)
10043 (resize_frame_windows): Declare prototypes.
10045 * window.c (resize_window_apply): Make definition be "static" to
10046 match the prototype.
10048 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10050 * window.c: Remove declarations of Qwindow_size_fixed,
10051 window_min_size_1, window_min_size_2, window_min_size,
10052 size_window, window_fixed_size_p, enlarge_window, delete_window.
10053 Remove static from declaration of Qdelete_window, it's
10054 temporarily needed by Fbury_buffer.
10055 (replace_window): Don't assign orig_top_line and
10057 (Fdelete_window, delete_window): Remove. Window deletion is
10058 handled by window.el.
10059 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10060 Replace Fdelete_window calls with calls to Qdelete_window.
10061 (Fdelete_other_windows): Remove. Deleting other windows is
10062 handled by window.el.
10063 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10064 handled in window.el.
10065 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10066 Window minimum sizes are handled in window.el.
10067 (shrink_windows, size_window, set_window_height)
10068 (set_window_width, change_window_heights, window_height)
10069 (window_width, CURBEG, CURSIZE, enlarge_window)
10070 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10071 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10072 handled in window.el.
10073 (make_dummy_parent): Rename to make_parent_window and give it a
10074 second argument horflag.
10075 (make_window): Don't set resize_proportionally any more.
10076 (Fsplit_window): Remove. Windows are split in window.el.
10077 (save_restore_action, save_restore_orig_size)
10078 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10079 Resize mini windows in window.el.
10080 (grow_mini_window, shrink_mini_window): Implement by calling
10081 Qresize_root_window_vertically, resize_window_check and
10082 resize_window_apply.
10083 (saved_window, Fset_window_configuration, save_window_save):
10084 Do not handle orig_top_line, orig_total_lines, and
10085 resize_proportionally.
10086 (window_min_height, window_min_width): Move to window.el.
10087 (keys_of_window): Move bindings for delete-other-windows,
10088 split-window, delete-window and enlarge-window to window.el.
10090 * buffer.c: Temporarily extern Qdelete_window.
10091 (Fbury_buffer): Temporarily call Qdelete_window instead of
10092 Fdelete_window (Fbury_buffer will move to window.el soon).
10094 * frame.c (set_menu_bar_lines_1): Remove code handling
10095 orig_top_line and orig_total_lines.
10097 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10098 set_window_height but set heights directly.
10099 (change_frame_size_1): Use resize_frame_windows.
10101 * xdisp.c (init_xdisp): Don't use set_window_height but set
10104 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10105 Use resize_frame_windows instead of change_window_heights and run
10106 run_window_configuration_change_hook.
10108 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10109 instead of change_window_heights and run
10110 run_window_configuration_change_hook.
10112 2011-06-09 Martin Rudalics <rudalics@gmx.at>
10114 * window.c (replace_window): Rename second argument REPLACEMENT to
10115 NEW. New third argument SETFLAG. Rewrite.
10116 (delete_window, make_dummy_parent): Call replace_window with
10118 (window_list_1): Move down in code.
10119 (run_window_configuration_change_hook): Move set_buffer part
10120 before select_frame_norecord part in order to unwind correctly.
10121 Rename count1 to count.
10122 (recombine_windows, delete_deletable_window, resize_root_window)
10123 (Fdelete_other_windows_internal)
10124 (Frun_window_configuration_change_hook, make_parent_window)
10125 (resize_window_check, resize_window_apply, Fresize_window_apply)
10126 (resize_frame_windows, Fsplit_window_internal)
10127 (Fdelete_window_internal, Fresize_mini_window_internal):
10129 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10131 2011-06-08 Martin Rudalics <rudalics@gmx.at>
10133 * window.h (window): Add some new members to window structure -
10134 normal_lines, normal_cols, new_total, new_normal, clone_number,
10135 splits, nest, prev_buffers, next_buffers.
10136 (WINDOW_TOTAL_SIZE): Move here from window.c.
10137 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
10139 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10141 (make_dummy_parent): Set new members of windows structure.
10142 (make_window): Move down in code. Handle new members of window
10144 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10145 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10146 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10147 (Fset_window_prev_buffers, Fwindow_next_buffers)
10148 (Fset_window_next_buffers, Fset_window_clone_number):
10150 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10151 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10153 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10154 Argument WINDOW can be now internal window too.
10155 (Fwindow_use_time): Move up in code.
10156 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10157 Rewrite doc-string.
10158 (Fset_window_configuration, saved_window)
10159 (Fcurrent_window_configuration, save_window_save): Handle new
10160 members of window structure.
10161 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10162 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10163 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10164 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10165 Qget_mru_window, Qresize_root_window,
10166 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10167 Qauto_buffer_name; staticpro them.
10169 2011-06-07 Martin Rudalics <rudalics@gmx.at>
10171 * window.c (Fwindow_total_size, Fwindow_left_column)
10172 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10173 (Fwindow_list_1): New functions.
10174 (window_box_text_cols): Replace with window_body_cols.
10175 (Fwindow_width, Fscroll_left, Fscroll_right):
10176 Use window_body_cols instead of window_box_text_cols.
10177 (delete_window, Fset_window_configuration):
10178 Call delete_all_subwindows with window as argument.
10179 (delete_all_subwindows): Take a window as argument and not a
10180 structure. Rewrite.
10181 (window_loop): Remove handling of GET_LRU_WINDOW and
10182 GET_LARGEST_WINDOW.
10183 (Fget_lru_window, Fget_largest_window): Move to window.el.
10185 * window.h: Extern window_body_cols instead of
10186 window_box_text_cols. delete_all_subwindows now takes a
10187 Lisp_Object as argument.
10189 * indent.c (compute_motion, Fcompute_motion):
10190 Use window_body_cols instead of window_box_text_cols.
10192 * frame.c (delete_frame): Call delete_all_subwindows with root
10193 window as argument.
10195 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10197 * fns.c (Fputhash): Document return value.
10199 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
10201 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10203 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10205 Cons<->int and similar integer overflow fixes (Bug#8794).
10207 Check for overflow when converting integer to cons and back.
10208 * charset.c (Fdefine_charset_internal, Fdecode_char):
10209 Use cons_to_unsigned to catch overflow.
10210 (Fencode_char): Use INTEGER_TO_CONS.
10211 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10212 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10213 * data.c (long_to_cons, cons_to_long): Remove.
10214 (cons_to_unsigned, cons_to_signed): New functions.
10215 These signal an error for invalid or out-of-range values.
10216 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10217 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10218 * font.c (Ffont_variation_glyphs):
10219 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10220 * lisp.h: Include <intprops.h>.
10221 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10222 (cons_to_signed, cons_to_unsigned): New decls.
10223 (long_to_cons, cons_to_long): Remove decls.
10224 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10225 (Fprimitive_undo): Use CONS_TO_INTEGER.
10226 * xfns.c (Fx_window_property): Likewise.
10227 * xselect.c: Include <limits.h>.
10228 (x_own_selection, selection_data_to_lisp_data):
10229 Use INTEGER_TO_CONS.
10230 (x_handle_selection_request, x_handle_selection_clear)
10231 (x_get_foreign_selection, Fx_disown_selection_internal)
10232 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10233 (lisp_data_to_selection_data): Use cons_to_unsigned.
10234 (x_fill_property_data): Use cons_to_signed.
10235 Report values out of range.
10237 Check for buffer and string overflow more precisely.
10238 * buffer.h (BUF_BYTES_MAX): New macro.
10239 * lisp.h (STRING_BYTES_MAX): New macro.
10240 * alloc.c (Fmake_string):
10241 * character.c (string_escape_byte8):
10242 * coding.c (coding_alloc_by_realloc):
10243 * doprnt.c (doprnt):
10244 * editfns.c (Fformat):
10246 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10247 since they may not be the same number.
10248 * editfns.c (Finsert_char):
10249 * fileio.c (Finsert_file_contents):
10250 Likewise for BUF_BYTES_MAX.
10252 * image.c: Use ptrdiff_t, not int, for sizes.
10253 (slurp_file): Switch from int to ptrdiff_t.
10255 (slurp_file): Check that file size fits in both size_t (for
10256 malloc) and ptrdiff_t (for sanity and safety).
10258 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10259 if b->modtime has its maximal value.
10261 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10263 Don't assume time_t can fit into int.
10264 * buffer.h (struct buffer.modtime): Now time_t, not int.
10265 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10266 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10268 Minor fixes for signed vs unsigned integers.
10269 * character.h (MAYBE_UNIFY_CHAR):
10270 * charset.c (maybe_unify_char):
10271 * keyboard.c (read_char, reorder_modifiers):
10272 XINT -> XFASTINT, since the integer must be nonnegative.
10273 * ftfont.c (ftfont_spec_pattern):
10274 * keymap.c (access_keymap, silly_event_symbol_error):
10275 XUINT -> XFASTINT, since the integer must be nonnegative.
10276 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10277 since it makes no difference and we prefer signed.
10278 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10279 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10282 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10284 * window.h (Fwindow_frame): Declare.
10286 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10288 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10289 (SPARE_MEMORY): Always define.
10290 (LARGE_REQUEST): Remove.
10291 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10293 2011-06-06 Martin Rudalics <rudalics@gmx.at>
10295 * lisp.h: Move EXFUNS for Fframe_root_window,
10296 Fframe_first_window and Fset_frame_selected_window to window.h.
10298 * window.h: Move EXFUNS for Fframe_root_window,
10299 Fframe_first_window and Fset_frame_selected_window here from
10302 * frame.c (Fwindow_frame, Fframe_first_window)
10303 (Fframe_root_window, Fframe_selected_window)
10304 (Fset_frame_selected_window): Move to window.c.
10305 (Factive_minibuffer_window): Move to minibuf.c.
10306 (Fother_visible_frames_p): New function.
10308 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10310 * window.c (decode_window, decode_any_window): Move up in code.
10311 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10312 (inhibit_frame_unsplittable): Remove unused variable.
10313 (Fwindow_buffer): Move up and rewrite doc-string.
10314 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10315 (Fwindow_prev): New functions.
10316 (Fwindow_frame): Move here from frame.c. Accept any window as
10318 (Fframe_root_window, Fframe_first_window)
10319 (Fframe_selected_window): Move here from frame.c. Accept frame
10320 or arbitrary window as argument. Update doc-strings.
10321 (Fminibuffer_window): Move up in code.
10322 (Fwindow_minibuffer_p): Move up in code and simplify.
10323 (Fset_frame_selected_window): Move here from frame.c.
10325 (Fselected_window, select_window, Fselect_window): Move up in
10326 code. Minor doc-string fixes.
10328 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10330 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10331 Do not assume that spare memory exists; that assumption is valid
10332 only if SYSTEM_MALLOC.
10333 (LARGE_REQUEST): New macro, so that the issue of large requests
10334 is separated from the issue of spare memory.
10336 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10338 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10341 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10343 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10346 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10348 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10350 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10352 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10353 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10355 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
10357 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10359 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
10361 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10362 (x_clipboard_manager_save): Add return value.
10363 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10364 New error handlers.
10365 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10366 Obey Vx_select_enable_clipboard_manager. Catch errors in
10367 x_clipboard_manager_save (Bug#8779).
10368 (Vx_select_enable_clipboard_manager): New variable.
10369 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
10371 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
10373 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10375 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10377 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10378 in the current matrix if keep_current_p is non-zero.
10380 2011-06-04 Eli Zaretskii <eliz@gnu.org>
10382 * bidi.c (bidi_level_of_next_char): Fix last change.
10384 2011-06-03 Eli Zaretskii <eliz@gnu.org>
10386 Support bidi reordering of text covered by display properties.
10388 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10389 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10390 (bidi_cache_search, bidi_cache_iterator_state)
10391 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
10392 (bidi_level_of_next_char, bidi_move_to_visually_next):
10393 Support character positions inside a run of characters covered by a
10395 (bidi_paragraph_init, bidi_resolve_explicit_1)
10396 (bidi_level_of_next_char): Call bidi_fetch_char and
10397 bidi_fetch_char_advance instead of FETCH_CHAR and
10398 FETCH_CHAR_ADVANCE.
10399 (bidi_init_it): Initialize new members.
10400 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10402 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10403 instead of using explicit *_CHAR codes.
10404 (bidi_resolve_explicit, bidi_resolve_weak):
10405 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
10406 bidirectional text is supported only in multibyte buffers.
10407 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10408 it to initialize the frame_window_p member of struct bidi_it.
10409 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10410 (bidi_resolve_explicit, bidi_resolve_weak)
10411 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10412 bidi_it->nchars is non-positive.
10413 (bidi_level_of_next_char): Don't try to lookup the cache for the
10414 next/previous character if nothing is cached there yet, or if we
10415 were just reseat()'ed to a new position.
10417 * xdisp.c (set_cursor_from_row): Set start and stop points
10418 according to the row's direction when priming the loop that looks
10419 for the glyph on which to display cursor.
10420 (single_display_spec_intangible_p): Function deleted.
10421 (display_prop_intangible_p): Reimplement to call
10422 handle_display_spec instead of single_display_spec_intangible_p.
10423 Accept 3 additional arguments needed by handle_display_spec.
10424 This fixes incorrect cursor motion across display property with complex
10425 values: lists, `(when COND...)' forms, etc.
10426 (single_display_spec_string_p): Support property values that are
10427 lists with the argument STRING its top-level element.
10428 (display_prop_string_p): Fix the condition for processing a
10429 property that is a list to be consistent with handle_display_spec.
10430 (handle_display_spec): New function, refactored from the
10431 last portion of handle_display_prop.
10432 (compute_display_string_pos): Accept additional argument
10433 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10434 value of a `display' property is a "replacing spec".
10435 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10436 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10437 the display property, but just return a value indicating whether
10438 the display property will replace the characters it covers.
10439 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10440 frame_window_p members of struct bidi_it.
10441 (compute_display_string_pos, compute_display_string_end):
10443 (push_it): Accept second argument POSITION, where pop_it should
10444 jump to continue iteration.
10445 (reseat_1): Initialize bidi_it.disp_pos.
10447 * keyboard.c (adjust_point_for_property): Adjust the call to
10448 display_prop_intangible_p to its new signature.
10450 * dispextern.h (struct bidi_it): New member frame_window_p.
10451 (bidi_init_it): Update prototypes.
10452 (display_prop_intangible_p): Update prototype.
10453 (compute_display_string_pos, compute_display_string_end):
10454 Declare prototypes.
10455 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10458 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
10460 Malloc failure behavior now depends on size of allocation.
10461 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10462 * lisp.h: Change signatures accordingly.
10463 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10464 All callers changed. (Bug#8762)
10466 * gnutls.c: Use Emacs's memory allocators.
10467 Without this change, the gnutls library would invoke malloc etc.
10468 directly, which causes problems on non-SYNC_INPUT hosts, and which
10469 runs afoul of improving memory_full behavior. (Bug#8761)
10470 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10471 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10472 xfree instead of the default malloc, realloc, free.
10473 (Fgnutls_boot): No need to check for memory allocation failure,
10474 since xmalloc does that for us.
10476 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
10477 * category.c (hash_get_category_set):
10478 * ccl.c (ccl_driver):
10479 * charset.c (Fdefine_charset_internal):
10480 * charset.h (struct charset.hash_index):
10481 * composite.c (get_composition_id, gstring_lookup_cache)
10482 (composition_gstring_put_cache):
10483 * composite.h (struct composition.hash_index):
10484 * dispextern.h (struct image.hash):
10485 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10486 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10487 (hashfn_equal, hashfn_user_defined, make_hash_table)
10488 (maybe_resize_hash_table, hash_lookup, hash_put)
10489 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10490 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10491 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10492 * image.c (make_image, search_image_cache, lookup_image)
10493 (xpm_put_color_table_h):
10494 * lisp.h (struct Lisp_Hash_Table):
10495 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
10496 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
10497 for hashes and hash indexes, instead of 'unsigned' and 'int'.
10498 * alloc.c (allocate_vectorlike):
10499 Check for overflow in vector size calculations.
10500 * ccl.c (ccl_driver):
10501 Check for overflow when converting EMACS_INT to int.
10502 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10503 need to be updated by these changes.
10504 * fns.c (make_hash_table, maybe_resize_hash_table):
10505 Check for integer overflow with large hash tables.
10506 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10507 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10508 (SXHASH_REDUCE): New macro.
10509 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10510 Use it instead of discarding useful hash info with large hash values.
10511 (sxhash_float): New function.
10512 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10513 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
10514 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10515 Rewrite to use FIXNUM_BITS, as this simplifies things.
10516 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10517 Adjust signatures to match updated version of code.
10518 (consing_since_gc): Now EMACS_INT, since a single hash table can
10519 use more than INT_MAX bytes.
10521 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10523 Make it possible to build with GCC-4.6+ -O2 -flto.
10525 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10527 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10529 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10530 Call minibuffer-inactive-mode.
10532 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
10534 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10535 Update dependencies.
10537 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10539 * data.c (init_data): Remove code for UTS, this system is not
10542 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10544 Don't force ./temacs to start in terminal mode.
10546 * frame.c (make_initial_frame): Initialize faces in all cases, not
10547 only when CANNOT_DUMP is defined.
10548 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10550 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10552 * dispnew.c (add_window_display_history): Use const for the string
10553 pointer. Remove declaration, not needed.
10555 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10557 Use 'inline', not 'INLINE'.
10558 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
10559 * alloc.c, fontset.c (INLINE): Remove.
10560 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10561 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10562 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10563 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10564 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10566 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10568 Make it possible to run ./temacs.
10570 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10571 syms_of_callproc does the same thing. Remove test for
10572 "initialized", do it in the caller.
10573 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10575 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10577 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10578 (read_minibuf): Use get_minibuffer.
10579 (syms_of_minibuf): Use DEFSYM.
10580 (Qmetadata): New var.
10581 * data.c (Qbuffer): Don't make it static.
10582 (syms_of_data): Use DEFSYM.
10584 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10586 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10587 (CCL_CODE_MIN): New macro.
10589 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10591 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10593 * eval.c (Qdebug): Now static.
10594 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10595 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10596 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10598 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10600 * image.c: Various fixes to ImageMagick code comments.
10601 (Fimagemagick_types): Doc fix.
10603 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10605 Minor fixes prompted by GCC 4.6.0 warnings.
10607 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10609 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10610 (x_clipboard_manager_save_all): Move extern decl to ...
10611 * xterm.h: ... here, so that it can be checked for consistency.
10613 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10615 * xselect.c (x_clipboard_manager_save_frame)
10616 (x_clipboard_manager_save_all): New functions.
10617 (Fx_clipboard_manager_save): Lisp function deleted.
10619 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10620 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10622 * xterm.h: Update prototype.
10624 2011-05-28 William Xu <william.xwl@gmail.com>
10626 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10627 exiting (Bug#8239).
10629 2011-05-28 Jim Meyering <meyering@redhat.com>
10631 Avoid a sign-extension bug in crypto_hash_function.
10632 * fns.c (to_uchar): Define.
10633 (crypto_hash_function): Use it to convert some newly-signed
10634 variables to unsigned, to avoid sign-extension bugs. For example,
10635 without this change, (md5 "truc") would evaluate to
10636 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10637 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
10638 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
10640 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10642 Integer overflow fixes.
10644 * dbusbind.c: Serial number integer overflow fixes.
10645 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
10646 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10647 to hold a serial number that is too large for a fixnum.
10648 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10649 Check for serial numbers out of range. Decode any serial number
10650 that was so large that it became a float. (Bug#8722)
10652 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10653 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10654 Use XFASTINT rather than XUINT when numbers are nonnegative.
10655 (xd_append_arg, Fdbus_method_return_internal):
10656 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10657 arguments, check that Lisp number is nonnegative, rather than
10658 silently wrapping negative numbers around. (Bug#8722)
10659 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
10662 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10664 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10666 ccl: Add integer overflow checks.
10667 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10668 (IN_INT_RANGE): New macros.
10669 (ccl_driver): Use them to check for integer overflow when
10670 decoding a CCL program. Many of the new checks are whether XINT (x)
10671 fits in int; it doesn't always, on 64-bit hosts. The new version
10672 doesn't catch all possible integer overflows, but it's an
10673 improvement. (Bug#8719)
10675 * alloc.c (make_event_array): Use XINT, not XUINT.
10676 There's no need for unsigned here.
10678 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10679 This follows up to the 2011-05-06 change that substituted uintptr_t
10680 for EMACS_INT. This case wasn't caught back then.
10682 Rework Fformat to avoid integer overflow issues.
10683 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10684 now (part of C89). Include <verify.h>.
10685 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10686 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10687 (Fformat): Avoid the prepass trying to compute sizes; it was only
10688 approximate and thus did not catch overflow reliably. Instead, walk
10689 through the format just once, formatting and computing sizes as we go,
10690 checking for integer overflow at every step, and allocating a larger
10691 buffer as needed. Keep track separately whether the format is
10692 multibyte. Keep only the most-recently calculated precision, rather
10693 than them all. Record whether each argument has been converted to
10694 string. Use EMACS_INT, not int, for byte and char and arg counts.
10695 Support field widths and precisions larger than INT_MAX. Avoid
10696 sprintf's undefined behavior with conversion specifications such as %#d
10697 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10698 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10699 formatting out-of-range floating point numbers with int
10700 formats. (Bug#8668)
10702 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10704 * data.c: Avoid integer truncation in expressions involving floats.
10705 * data.c: Include <intprops.h>.
10706 (arith_driver): When there's an integer overflow in an expression
10707 involving floating point, convert the integers to floating point
10708 so that the resulting value does not suffer from catastrophic
10709 integer truncation. For example, on a 64-bit host (* 4
10710 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10711 Do not rely on undefined behavior after integer overflow.
10713 merge count_size_as_multibyte, parse_str_to_multibyte
10714 * character.c, character.h (count_size_as_multibyte):
10715 Rename from parse_str_to_multibyte; all uses changed.
10716 Check for integer overflow.
10717 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10718 since it's now a duplicate of the other. This is more of
10719 a character than a buffer op, so better that it's in character.c.
10720 * fns.c, print.c: Adjust to above changes.
10722 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10724 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10726 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10728 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10729 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10730 (x_clipboard_manager_save): Now static.
10731 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10733 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10734 (crypto_hash_function): Now static.
10735 Fix pointer signedness problems. Avoid unnecessary initializations.
10737 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
10739 * termhooks.h (Vselection_alist): Make it terminal-local.
10741 * terminal.c (create_terminal): Initialize it.
10743 * xselect.c: Support for clipboard managers.
10744 (Vselection_alist): Move to termhooks.h as terminal-local var.
10745 (LOCAL_SELECTION): New macro.
10746 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10747 (symbol_to_x_atom): Remove gratuitous arg.
10748 (x_handle_selection_request, lisp_data_to_selection_data)
10749 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
10750 (x_own_selection, x_get_local_selection, x_convert_selection):
10751 New arg, specifying work frame. Use terminal-local Vselection_alist.
10752 (some_frame_on_display): Delete unused function.
10753 (Fx_own_selection_internal, Fx_get_selection_internal)
10754 (Fx_disown_selection_internal, Fx_selection_owner_p)
10755 (Fx_selection_exists_p): New optional frame arg.
10756 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10757 (x_handle_selection_clear): Don't treat other terminals with the
10758 same keyboard specially. Use the terminal-local Vselection_alist.
10759 (x_clear_frame_selections): Use Frun_hook_with_args.
10761 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10763 * xterm.h: Add support for those atoms.
10765 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
10767 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10768 (converted_selections, conversion_fail_tag): New global variables.
10769 (x_selection_request_lisp_error): Free the above.
10770 (x_get_local_selection): Remove unnecessary code.
10771 (x_reply_selection_request): Args changed; handle arbitrary array
10772 of converted selections stored in converted_selections.
10773 Separate the XChangeProperty and SelectionNotify steps.
10774 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10775 (x_convert_selection): New function.
10776 (x_handle_selection_event): Simplify.
10777 (x_get_foreign_selection): Don't ignore incoming requests while
10778 waiting for an answer; this will fail when we implement
10779 SAVE_TARGETS, and seems unnecessary anyway.
10780 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10781 (Vx_sent_selection_functions): Doc fix.
10783 2011-05-26 Leo Liu <sdl.web@gmail.com>
10785 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10787 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10789 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10791 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10792 for fringe update if it has periodic bitmap.
10793 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
10794 and fringe_bitmap_periodic_p.
10796 * fringe.c (get_fringe_bitmap_data): New function.
10797 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10798 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10799 row. Mark glyph row for fringe update if periodicity changed.
10801 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10802 for fringe update unless it has periodic bitmap.
10804 2011-05-25 Kenichi Handa <handa@m17n.org>
10806 * xdisp.c (get_next_display_element): Set correct it->face_id for
10807 a static composition.
10809 2011-05-24 Leo Liu <sdl.web@gmail.com>
10812 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10814 * fns.c (crypto_hash_function, Fsha1): New function.
10815 (Fmd5): Use crypto_hash_function.
10816 (syms_of_fns): Add Ssha1.
10818 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10820 * gnutls.c: Remove unused macros.
10821 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10822 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10823 Remove macros that are defined and never used.
10824 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10826 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10828 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10829 (Fx_get_selection_internal): Minor cleanup.
10830 (Fx_own_selection_internal): Rename arguments for consistency with
10833 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10835 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10837 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10839 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10841 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10843 * dispnew.c (scrolling_window): Don't exclude the case that the
10844 last enabled row in the desired matrix touches the bottom boundary.
10846 2011-05-21 Glenn Morris <rgm@gnu.org>
10848 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
10849 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10850 and add some more files.
10852 2011-05-20 Eli Zaretskii <eliz@gnu.org>
10854 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10855 report_file_error introduced by the change from 2011-05-07.
10857 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10859 * systime.h (Time): Define only if emacs is defined.
10860 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10861 where the include path doesn't have X11/X.h by default. See
10862 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10864 2011-05-20 Kenichi Handa <handa@m17n.org>
10866 * composite.c (find_automatic_composition): Fix previous change.
10868 2011-05-20 Glenn Morris <rgm@gnu.org>
10870 * lisp.mk: New file, split from Makefile.in.
10871 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10872 (shortlisp): Remove.
10873 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10875 2011-05-19 Glenn Morris <rgm@gnu.org>
10877 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10878 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10879 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10880 (lisp): Set the order to that of loadup.el.
10881 (shortlisp): Make it a copy of $lisp.
10882 (SOME_MACHINE_LISP): Remove.
10883 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10884 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10886 2011-05-18 Kenichi Handa <handa@m17n.org>
10888 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10889 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10890 (find_automatic_composition): Mostly rewrite for efficiency.
10892 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
10894 * makefile.w32-in: Update dependencies.
10896 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10898 * menu.c: Include limits.h (fixes the MS-Windows build broken by
10899 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
10901 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
10903 Fix some integer overflow issues, such as string length overflow.
10905 * insdel.c (count_size_as_multibyte): Check for string overflow.
10907 * character.c (lisp_string_width): Check for string overflow.
10908 Use EMACS_INT, not int, for string indexes and lengths; in
10909 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10910 the resulting string length overflows an EMACS_INT; instead,
10911 report a string overflow if no precision given. When checking for
10912 precision exhaustion, use a check that cannot possibly have
10913 integer overflow. (Bug#8675)
10914 * character.h (lisp_string_width): Adjust to new signature.
10916 * alloc.c (string_overflow): New function.
10917 (Fmake_string): Use it. This doesn't change behavior, but saves
10918 a few bytes and will simplify future changes.
10919 * character.c (string_escape_byte8): Likewise.
10920 * lisp.h (string_overflow): New decl.
10922 Fixups, following up to the user-interface timestamp change.
10923 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10924 for UI timestamps, instead of unsigned long.
10925 * msdos.c (mouse_get_pos): Likewise.
10926 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
10927 * w32gui.h (Time): Define by including "systime.h" rather than by
10928 declaring it ourselves. (Bug#8664)
10930 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10931 * image.c (clear_image_cache): Likewise.
10933 * term.c (term_mouse_position): Don't assume time_t wraparound.
10935 Be more systematic about user-interface timestamps.
10936 Before, the code sometimes used 'Time', sometimes 'unsigned long',
10937 and sometimes 'EMACS_UINT', to represent these timestamps.
10938 This change causes it to use 'Time' uniformly, as that's what X uses.
10939 This makes the code easier to follow, and makes it easier to catch
10940 integer overflow bugs such as Bug#8664.
10941 * frame.c (Fmouse_position, Fmouse_pixel_position):
10942 Use Time, not unsigned long, for user-interface timestamps.
10943 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10944 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10945 * keyboard.h (last_event_timestamp): Likewise.
10946 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10947 * menu.h (xmenu_show): Likewise.
10948 * term.c (term_mouse_position): Likewise.
10949 * termhooks.h (struct input_event.timestamp): Likewise.
10950 (struct terminal.mouse_position_hook): Likewise.
10951 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10952 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10953 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10954 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10955 what it was before.
10956 * menu.h, termhooks.h: Include "systime.h", for Time.
10958 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10959 Don't assume that the difference between two unsigned long values
10960 can fit into an integer. At this point, we know button_down_time
10961 <= event->timestamp, so the difference must be nonnegative, so
10962 there's no need to cast the result if double-click-time is
10963 nonnegative, as it should be; check that it's nonnegative, just in
10964 case. This bug is triggered when events are more than 2**31 ms
10965 apart (about 25 days). (Bug#8664)
10967 * xselect.c (last_event_timestamp): Remove duplicate decl.
10968 (x_own_selection): Remove needless cast to unsigned long.
10970 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10971 that always fit in int. Use a sentinel instead of a counter, to
10972 avoid a temp and to allay GCC's concerns about possible int overflow.
10973 * frame.h (struct frame): Use int for menu_bar_items_used
10974 instead of EMACS_INT, since it always fits in int.
10976 * menu.c (grow_menu_items): Check for int overflow.
10978 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10980 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10981 Before, the code was not consistent. These values cannot exceed
10982 2**31 - 1 so there's no need to make them unsigned.
10983 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10984 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10985 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10987 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10989 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10990 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10991 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10992 presumably because the widths might not match.
10994 * window.c (size_window): Avoid needless test at loop start.
10996 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10998 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11000 2011-05-12 Drew Adams <drew.adams@oracle.com>
11002 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11004 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11006 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11007 `width' to `bar_area_x' and `bar_area_width', respectively.
11008 (x_scroll_run): Take account of fringe background extension.
11010 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11011 Rename local vars `left' and `width' to `bar_area_x' and
11012 `bar_area_width', respectively.
11013 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11014 background extension.
11016 2011-05-10 Jim Meyering <meyering@redhat.com>
11018 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11020 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
11022 * image.c (Finit_image_library): Return t for built-in image types,
11023 like pbm and xbm. (Bug#8640)
11025 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11027 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11029 2011-05-07 Eli Zaretskii <eliz@gnu.org>
11031 * w32console.c (Fset_screen_color): Doc fix.
11032 (Fget_screen_color): New function.
11033 (syms_of_ntterm): Defsubr it.
11035 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11036 unlink the temporary file if Fcall_process didn't create it in the
11038 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11039 child process will be redirected to a file specified with `:file'.
11040 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11041 cue to call_process_cleanup not to close that handle.
11043 2011-05-07 Ben Key <bkey76@gmail.com>
11045 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11046 one of two shell specific rules, either bootstrap-temacs-CMD or
11047 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11048 to the previous implementation of the bootstrap-temacs rule.
11049 The bootstrap-temacs-CMD rule is similar to the previous
11050 implementation of the bootstrap-temacs rule except that it
11051 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11054 These changes, along with some changes to nt/configure.bat,
11055 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11056 earlier fix to add support for --cflags and --ldflags options
11057 that include quotes so that it works whether make uses cmd or
11060 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
11062 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11063 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11065 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11066 a string. Handle both cases.
11067 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11068 (Fdbus_register_method): Use Qinvalid_function.
11070 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11072 * makefile.w32-in: Update dependencies.
11073 (LISP_H): Add inttypes.h and stdin.h.
11074 (PROCESS_H): Add unistd.h.
11076 2011-05-06 Eli Zaretskii <eliz@gnu.org>
11078 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11079 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11081 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
11083 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11085 * term.c (vfatal): Remove stray call to va_end.
11086 It's not needed and the C Standard doesn't allow it here anyway.
11088 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11089 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11091 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11094 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11096 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11098 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11100 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11102 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11104 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11105 * charset.c (Fdefine_charset_internal): Don't initialize
11106 charset.code_space[15]. The value was garbage, on hosts with
11107 32-bit int (Bug#8600).
11109 * lread.c (read_integer): Be more consistent with string-to-number.
11110 Use string_to_number to do the actual conversion; this avoids
11111 rounding errors and fixes some other screwups. Without this fix,
11112 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11113 (digit_to_number): Move earlier, for benefit of read_integer.
11114 Return -1 if the digit is out of range for the base, -2 if it is
11115 not a digit in any supported base. (Bug#8602)
11117 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11119 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11120 to match comment at start of function. This also removes a
11121 GCC warning about overflow in a 32+64-bit port.
11123 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11125 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11126 Reported by Stefan Monnier in
11127 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
11128 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11129 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
11131 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11132 (EMACS_UINTPTR): Likewise, with uintptr_t.
11134 * lisp.h: Prefer 64-bit EMACS_INT if available.
11135 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11136 on 32-bit hosts that have 64-bit int, so that they can access
11138 However, temporarily disable this change unless the temporary
11139 symbol WIDE_EMACS_INT is defined.
11141 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11143 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11144 This removes an assumption that EMACS_INT and long are the same
11145 width as pointers. The assumption is true for Emacs porting targets
11146 now, but we want to make other targets possible.
11147 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11148 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11149 In the rest of the code, change types of integers that hold casted
11150 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11151 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11152 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11153 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11154 No need to cast type when ORing.
11155 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11156 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11157 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11158 assume EMACS_INT is the same width as char *.
11159 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11160 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11161 Remove no-longer-needed casts.
11162 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11163 (xg_tool_bar_help_callback, xg_make_tool_item):
11164 Use EMACS_INTPTR to hold an integer
11165 that will be cast to void *; this can avoid a GCC warning
11166 if EMACS_INT is not the same width as void *.
11167 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11168 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11169 (current_message_1, set_message_1):
11170 Use a local to convert to proper width without a cast.
11171 * xmenu.c (dialog_selection_callback): Likewise.
11173 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11174 Also, don't assume VALBITS / RAND_BITS is less than 5,
11175 and don't rely on undefined behavior when shifting a 1 left into
11177 * lisp.h (get_random): Change signature to match.
11179 * lread.c (hash_string): Use size_t, not int, for hash computation.
11180 Normally we prefer signed values; but hashing is special, because
11181 it's better to use unsigned division on hash table sizes so that
11182 the remainder is nonnegative. Also, size_t is the natural width
11183 for hashing into memory. The previous code used 'int', which doesn't
11184 retain enough info to hash well into very large tables.
11185 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11187 * dbusbind.c: Don't possibly lose pointer info when converting.
11188 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11189 Use XPNTR rather than XHASH, so that the high-order bits of
11190 the pointer aren't lost when converting through void *.
11192 * eval.c (Fautoload): Don't double-shift a pointer.
11194 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11196 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11198 * gnutls.c (DEF_GNUTLS_FN):
11199 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11201 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11203 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11206 2011-05-05 Eli Zaretskii <eliz@gnu.org>
11208 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11209 New version that can reserve upto 2GB of heap space.
11211 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
11213 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11215 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11217 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11218 `gnutls_certificate_set_x509_key_file'.
11220 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
11222 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11223 Update dependencies.
11225 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11227 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11228 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11229 Remove unused parameter `fildes'.
11230 * process.c (read_process_output, send_process): Don't pass it.
11232 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11234 Fix previous change: the library cache is defined in w32.c.
11235 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11236 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11238 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11240 Implement dynamic loading of GnuTLS on Windows.
11242 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11243 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11244 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11247 * gnutls.c (Qgnutls_dll): Define.
11248 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11249 (gnutls_*): Declare function pointers.
11250 (init_gnutls_functions): New function to initialize function pointers.
11251 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11252 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11253 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11254 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11255 (emacs_gnutls_write, emacs_gnutls_read)
11256 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11257 (Fgnutls_available_p): New function.
11258 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11259 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11260 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11262 * image.c: Include w32.h.
11263 (Vimage_type_cache): Delete.
11264 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11265 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11266 (w32_delayed_load): Move to w32.c.
11268 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11270 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11271 (w32_delayed_load): Move from image.c. When loading a library, record
11272 its filename in the :loaded-from property of the library id.
11273 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11274 Initialize and staticpro them.
11275 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11277 * process.c: Include lisp.h before w32.h, not after.
11278 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11279 instead of gnutls_record_check_pending.
11281 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11283 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11285 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11286 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11289 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11291 * xterm.c (x_set_frame_alpha): Do not set property on anything
11292 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11294 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11296 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11298 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11300 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11301 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11302 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11303 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11304 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11305 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11306 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11307 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11308 (Qgnutls_bootprop_callbacks_verify): Make static.
11310 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11312 * callproc.c: Indentation fixup.
11314 * sysdep.c (wait_for_termination_1): Make static.
11315 (wait_for_termination, interruptible_wait_for_termination):
11316 Move after wait_for_termination_1.
11318 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11320 * sysdep.c (interruptible_wait_for_termination): New function
11321 which is like wait_for_termination, but allows keyboard
11324 * callproc.c (Fcall_process): Add (:file "file") as an option for
11326 (Fcall_process_region): Ditto.
11328 2011-04-30 Eli Zaretskii <eliz@gnu.org>
11330 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11331 rather than `XVECTOR (FOO)->size'.
11333 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11334 inttypes.h, as a gnulib replacement is used if it not available in
11337 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11339 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11340 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11341 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11343 * coding.c (coding_alloc_by_realloc): Error out if destination
11344 will grow beyond MOST_POSITIVE_FIXNUM.
11345 (decode_coding_emacs_mule): Abort if there isn't enough place in
11346 charbuf for the composition carryover bytes. Reserve an extra
11347 space for up to 2 characters produced in a loop.
11348 (decode_coding_iso_2022): Abort if there isn't enough place in
11349 charbuf for the composition carryover bytes.
11351 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11353 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11354 aborting when %lld or %lll format is passed.
11355 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11356 %llo or %llx format is passed. (Bug#8545)
11358 * window.c (window_scroll_line_based): Use a marker instead of
11359 simple variables to record original value of point. (Bug#7952)
11361 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11362 produced by %s or %c overflows available buffer space. (Bug#8545)
11364 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11366 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
11367 (SIZE_MAX): Move defn after all includes, as they might #define it.
11369 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11371 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11373 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11375 * keyboard.c (Qdelayed_warnings_hook): Define.
11376 (command_loop_1): Run `delayed-warnings-hook'
11377 if Vdelayed_warnings_list is non-nil.
11378 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11379 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11381 2011-04-28 Eli Zaretskii <eliz@gnu.org>
11383 * doprnt.c (doprnt): Don't return value smaller than the buffer
11384 size if the message was truncated. (Bug#8545).
11386 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11388 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11389 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11391 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11393 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11395 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
11397 * makefile.w32-in: Update dependencies.
11399 2011-04-27 Eli Zaretskii <eliz@gnu.org>
11401 Improve `doprnt' and its usage. (Bug#8545)
11402 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11403 `format_end'. Remove support for %l as a conversion specifier.
11404 Don't use xrealloc. Improve diagnostics when the %l size modifier
11405 is used. Update the commentary.
11407 * eval.c (verror): Simplify calculation of size_t.
11409 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11412 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11414 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11417 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11419 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11420 This makes this file independent of the recent pseudovector change.
11422 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
11424 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11426 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
11427 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
11428 Remove unused local.
11429 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
11431 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
11432 GCC 4.6.0 optimizes based on type-based alias analysis.
11433 For example, if b is of type struct buffer * and v of type struct
11434 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11435 != &v->size, and therefore "v->size = 1; b->size = 2; return
11436 v->size;" must therefore return 1. This assumption is incorrect
11437 for Emacs, since it type-puns struct Lisp_Vector * with many other
11438 types. To fix this problem, this patch adds a new type struct
11439 vectorlike_header that documents the constraints on layout of vectors
11440 and pseudovectors, and helps optimizing compilers not get fooled
11441 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11442 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
11443 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11445 (XSETPVECTYPE): Rewrite in terms of new macro.
11446 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11447 This is a bit clearer, and further avoids the possibility of
11448 undesirable aliasing.
11449 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
11450 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
11451 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11452 since Lisp_Subr is a special case (no "next" field).
11453 (ASIZE): Now uses header.size rather than size.
11454 All previous uses of XVECTOR (foo)->size replaced to use this macro,
11455 to avoid the hassle of writing XVECTOR (foo)->header.size.
11456 (struct vectorlike_header): New type.
11457 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11458 object, to help avoid aliasing.
11459 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11460 (SUBRP): Likewise, since Lisp_Subr is a special case.
11461 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11462 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11463 (struct Lisp_Hash_Table): Combine first two members into a single
11464 struct vectorlike_header member. All uses of "size" and "next" members
11465 changed to be "header.size" and "header.next".
11466 * buffer.h (struct buffer): Likewise.
11467 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11468 * frame.h (struct frame): Likewise.
11469 * process.h (struct Lisp_Process): Likewise.
11470 * termhooks.h (struct terminal): Likewise.
11471 * window.c (struct save_window_data, struct saved_window): Likewise.
11472 * window.h (struct window): Likewise.
11473 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11474 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11475 * buffer.c (init_buffer_once): Likewise.
11476 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11478 * process.c (Fformat_network_address): Use local var for size,
11481 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11483 Make the Lisp reader and string-to-float more consistent (Bug#8525)
11484 * data.c (atof): Remove decl; no longer used or needed.
11485 (digit_to_number): Move to lread.c.
11486 (Fstring_to_number): Use new string_to_number function, to be
11487 consistent with how the Lisp reader treats infinities and NaNs.
11488 Do not assume that floating-point numbers represent EMACS_INT
11489 without losing information; this is not true on most 64-bit hosts.
11490 Avoid double-rounding errors, by insisting on integers when
11491 parsing non-base-10 numbers, as the documentation specifies.
11492 * lisp.h (string_to_number): New decl, replacing ...
11493 (isfloat_string): Remove.
11494 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
11495 (read1): Do not accept +. and -. as integers; this
11496 appears to have been a coding error. Similarly, do not accept
11497 strings like +-1e0 as floating point numbers. Do not report
11498 overflow for integer overflows unless the base is not 10 which
11499 means we have no simple and reliable way to continue.
11500 Break out the floating-point parsing into a new
11501 function string_to_number, so that Fstring_to_number parses
11502 floating point numbers consistently with the Lisp reader.
11503 (digit_to_number): Move here from data.c. Make it static inline.
11504 (E_CHAR, EXP_INT): Remove, replacing with ...
11505 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11506 (string_to_number): New function, replacing isfloat_string.
11507 This function checks for valid syntax and produces the resulting
11508 Lisp float number too. Rework it so that string-to-number
11509 no longer mishandles examples like "1.0e+". Use strtoumax,
11510 so that overflow for non-base-10 numbers is reported only when
11511 there's no portable and simple way to convert to floating point.
11513 * textprop.c (set_text_properties_1): Rewrite for clarity,
11514 and to avoid GCC warning about integer overflow.
11516 * intervals.h (struct interval): Use EMACS_INT for members
11517 where EMACS_UINT might cause problems. See
11518 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11519 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11520 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11522 (offset_intervals): Tell GCC not to worry about length overflow
11523 when negating a negative length.
11525 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11526 (overrun_check_free): Likewise.
11528 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11529 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11532 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11533 (gnutls_make_error): Rename local to avoid shadowing.
11534 (gnutls_emacs_global_deinit): ifdef out; not used.
11535 (Fgnutls_boot): Use const for pointer to readonly storage.
11536 Comment out unused local. Fix pointer signedness problems.
11538 * lread.c (openp): Don't stuff size_t into an 'int'.
11539 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11540 about possible signed overflow.
11542 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11543 (GDK_KEY_g): Don't define if already defined.
11544 (xg_prepare_tooltip): Avoid pointer signedness problem.
11545 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11547 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11548 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11550 * xfns.c (Fx_window_property): Simplify a bit,
11551 to make a bit faster and to avoid GCC 4.6.0 warning.
11552 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11554 * fns.c (internal_equal): Don't assume size_t fits in int.
11556 * alloc.c (compact_small_strings): Tighten assertion a little.
11558 Replace pEd with more-general pI, and fix some printf arg casts.
11559 * lisp.h (pI): New macro, generalizing old pEd macro to other
11560 conversion specifiers. For example, use "...%"pI"d..." rather
11561 than "...%"pEd"...".
11562 (pEd): Remove. All uses replaced with similar uses of pI.
11563 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
11564 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11565 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11566 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11567 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11568 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11569 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11571 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11572 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11573 * print.c (safe_debug_print, print_object): Likewise.
11574 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11576 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11577 avoiding the 0 flag, which is not portable.
11578 * process.c (Fmake_network_process): Use pI to avoid cast.
11579 * region-cache.c (pp_cache): Likewise.
11580 * xdisp.c (decode_mode_spec): Likewise.
11581 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11582 behavior on 64-bit hosts with printf arg.
11583 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
11584 (x_stop_queuing_selection_requests): Likewise.
11585 (x_get_window_property): Don't truncate byte count to an 'int'
11588 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11589 here, since it parses constructs like leading '-' and spaces,
11590 which are not wanted; and it overflows with large numbers.
11591 Instead, simply match F[0-9]+, which is what is wanted anyway.
11593 * alloc.c: Remove unportable assumptions about struct layout.
11594 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11595 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11596 (allocate_vectorlike, make_pure_vector): Use the new macros,
11597 plus offsetof, to remove unportable assumptions about struct layout.
11598 These assumptions hold on all porting targets that I know of, but
11599 they are not guaranteed, they're easy to remove, and removing them
11600 makes further changes easier.
11602 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11603 This doesn't fix a bug but makes the code clearer.
11604 (string_overrun_cookie): Now const. Use initializers that
11605 don't formally overflow signed char, to avoid warnings.
11606 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11607 can cause Emacs to crash when string overrun checking is enabled.
11608 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11609 multiple of sizeof (EMACS_INT); it need not be, if
11610 alignof(EMACS_INT) < sizeof (EMACS_INT).
11611 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
11613 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
11615 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11617 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11619 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
11620 supposed to be handshaking. (Bug#8556)
11621 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11623 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
11625 * lisp.h (Qdebug): List symbol.
11626 * eval.c (Qdebug): Restore global linkage.
11627 * keyboard.c (debug-on-event): New variable.
11628 (handle_user_signal): Break into debugger when debug-on-event
11629 matches the current signal symbol.
11631 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11633 * alloc.c (check_sblock, check_string_bytes)
11634 (check_string_free_list): Convert to standard C.
11636 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11638 * w32.c (emacs_gnutls_push): Fix typo.
11640 2011-04-25 Eli Zaretskii <eliz@gnu.org>
11642 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11643 "cast to pointer from integer of different size".
11645 Improve doprnt and its use in verror. (Bug#8545)
11646 * doprnt.c (doprnt): Document the set of format control sequences
11647 supported by the function. Use SAFE_ALLOCA instead of always
11650 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11651 is one byte too soon. Don't use xrealloc; instead xfree and
11654 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11656 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11659 * gnutls.c: Renamed global_initialized to
11660 gnutls_global_initialized. Added internals for the
11661 :verify-hostname-error, :verify-error, and :verify-flags
11662 parameters of `gnutls-boot' and documented those parameters in the
11663 docstring. Start callback support.
11664 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11665 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11666 on error. Return error code.
11667 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11668 (emacs_gnutls_read): Likewise.
11669 (Fgnutls_boot): Return handshake error code.
11670 (emacs_gnutls_handle_error): New function.
11671 (wsaerror_to_errno): Likewise.
11673 * w32.h (emacs_gnutls_pull): Add prototype.
11674 (emacs_gnutls_push): Likewise.
11676 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11677 (emacs_gnutls_push): Likewise.
11679 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11681 * process.c (wait_reading_process_output): Check if GnuTLS
11682 buffered some data internally if no FDs are set for TLS
11685 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11686 (LIBS): Link to USER_LIBS.
11687 ($(BLD)/gnutls.$(0)): New target.
11689 2011-04-24 Eli Zaretskii <eliz@gnu.org>
11691 * xdisp.c (handle_single_display_spec): Rename the
11692 display_replaced_before_p argument into display_replaced_p, to
11693 make it consistent with the commentary. Fix typos in the
11696 * textprop.c (syms_of_textprop): Remove dead code.
11697 (copy_text_properties): Delete obsolete commentary about an
11698 interface that was deleted long ago. Fix typos in the description
11701 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11702 to changes in oldXMenu/XMenu.h from 2011-04-16.
11703 <menu_help_message, prev_menu_help_message>: Constify.
11704 (IT_menu_make_room): menu->help_text is now `const char **';
11707 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11708 to changes in oldXMenu/XMenu.h from 2011-04-16.
11709 (struct XMenu): Declare `help_text' `const char **'.
11711 * xfaces.c <Qunspecified>: Make extern again.
11713 * syntax.c: Include sys/types.h before including regex.h, as
11716 * doc.c (get_doc_string): Improve the format passed to `error'.
11718 * doprnt.c (doprnt): Improve commentary.
11720 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11722 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11725 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11726 changes in globals.h immediately force recompilation.
11727 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11728 $(CURDIR)/s/ms-w32.h.
11729 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
11731 * character.c (Fchar_direction): Function deleted.
11732 (syms_of_character): Don't defsubr it.
11733 <char-direction-table>: Deleted.
11735 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11737 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11738 * doprnt.c: Include limits.h.
11739 (SIZE_MAX): New macro.
11740 (doprnt): Return a size_t value. 2nd arg is now size_t.
11741 Many local variables are now size_t instead of int or unsigned.
11742 Improve overflow protection. Support `l' modifier for integer
11743 conversions. Support %l conversion. Don't assume an EMACS_INT
11744 argument for integer conversions and for %c.
11746 * lisp.h (doprnt): Restore prototype.
11748 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11749 $(SRC)/character.h.
11751 * Makefile.in (base_obj): Add back doprnt.o.
11753 * deps.mk (doprnt.o): Add back prerequisites.
11754 (callint.o): Depend on character.h.
11756 * eval.c (internal_lisp_condition_case): Include the handler
11757 representation in the error message.
11758 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11759 when breaking from the loop.
11761 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11763 * callint.c (Fcall_interactively): When displaying error message
11764 about invalid control letter, pass the character's codepoint, not
11765 a pointer to its multibyte form. Improve display of the character
11766 in octal and display also its hex code.
11768 * character.c (char_string): Use %x to display the (unsigned)
11769 codepoint of an invalid character, to avoid displaying a bogus
11772 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11773 `error', not SYMBOL_NAME itself.
11775 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11776 character arguments to `error'.
11778 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11779 to `error' in error message about FINAL_CHAR argument. Make sure
11780 FINAL_CHAR is a character, and use %c when it is passed as
11781 argument to `error'.
11783 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11785 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11787 * w32.c: Include <time.h>.
11788 (sys_localtime): New function.
11790 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
11792 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11794 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
11796 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
11798 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11799 zombies (Bug#8467).
11801 2011-04-19 Eli Zaretskii <eliz@gnu.org>
11803 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11804 gl_state.e_property when gl_state.object is Qt.
11806 * insdel.c (make_gap_larger): Remove limitation of buffer size
11809 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
11811 * xdisp.c (lookup_glyphless_char_display)
11812 (produce_glyphless_glyph): Handle cons cell entry in
11813 glyphless-char-display.
11814 (Vglyphless_char_display): Document it.
11816 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11817 glyphless-char-display.
11819 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
11821 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11823 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11825 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11826 definition for no-X builds.
11828 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
11830 Static checks with GCC 4.6.0 and non-default toolkits.
11832 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11834 * process.c (keyboard_bit_set): Define only if SIGIO.
11835 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11836 (send_process): Repair possible setjmp clobbering.
11838 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11840 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11842 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11844 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11845 Define only if needed.
11847 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11848 by pacifying GCC about it. Maybe it's time to retire it?
11849 * xfaces.c (USG, __TIMEVAL__): Likewise.
11851 * dispextern.h (struct redisplay_interface): Rename param
11852 to avoid shadowing.
11853 * termhooks.h (struct terminal): Likewise.
11854 * xterm.c (xembed_send_message): Likewise.
11856 * insdel.c (make_gap_smaller): Define only if
11857 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11859 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11862 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11863 so that we aren't warned about unused symbols.
11865 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11867 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
11869 * xfns.c (x_real_positions): Mark locals as initialized.
11871 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11873 * xterm.c: Fix problems found by static analysis with other toolkits.
11874 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
11875 (x_dispatch_event): Declare static if USE_GTK, and
11876 define if USE_GTK || USE_X_TOOLKIT.
11877 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
11878 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
11879 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11880 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
11882 * xmenu.c (menu_help_callback): Pointer type fixes.
11883 Use const pointers when pointing at readonly data. Avoid pointer
11884 signedness clashes.
11885 (FALSE): Remove unused macro.
11886 (update_frame_menubar): Remove unused decl.
11888 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11890 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11891 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11892 (single_menu_item): Rename local to avoid shadowing.
11894 * keyboard.c (make_lispy_event): Remove unused local var.
11896 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11897 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11899 * bitmaps: Change bitmaps from unsigned char back to the X11
11900 compatible char. Avoid the old compiler warnings about
11901 out-of-range initializers by using, for example, '\xab' rather
11904 * xgselect.c (xgselect_initialize): Check vs interface
11905 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11907 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11909 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11910 to read-only memory.
11912 * fns.c (vector): Remove; this old hack is no longer needed.
11914 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
11916 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
11918 * xrdb.c (x_load_resources): Omit unused local.
11920 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
11921 (x_window): Rename locals to avoid shadowing.
11922 (USG): Use the kludged USG macro, to pacify gcc.
11924 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
11925 (x_term_init): Remove local to avoid shadowing.
11927 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
11929 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11930 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11932 2011-04-16 Eli Zaretskii <eliz@gnu.org>
11934 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11936 Fix regex.c, syntax.c and friends for buffers > 2GB.
11937 * syntax.h (struct gl_state_s): Declare character position members
11940 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11942 * textprop.c (verify_interval_modification, interval_of):
11943 Declare arguments EMACS_INT.
11945 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11948 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11950 * indent.c (Fvertical_motion): Local variable it_start is now
11953 * regex.c (re_match, re_match_2, re_match_2_internal)
11954 (bcmp_translate, regcomp, regexec, print_double_string)
11955 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11956 (re_compile_pattern, re_exec): Declare arguments and local
11957 variables `size_t' and `ssize_t' and return values `regoff_t', as
11959 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11960 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11961 <compile_stack_type>: `size' and `avail' are now `size_t'.
11963 * regex.h <regoff_t>: Use ssize_t, not int.
11964 (re_search, re_search_2, re_match, re_match_2): Arguments that
11965 specify buffer/string position and length are now ssize_t and
11966 size_t. Return type is regoff_t.
11968 2011-04-16 Ben Key <bkey76@gmail.com>
11970 * nsfont.m: Fixed bugs in ns_get_family and
11971 ns_descriptor_to_entity that were caused by using free to
11972 deallocate memory blocks that were allocated by xmalloc (via
11973 xstrdup). This caused Emacs to crash when compiled with
11974 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11975 --enable-checking=xmallocoverrun). xfree is now used to
11976 deallocate these memory blocks.
11978 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
11980 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11982 emacs_write: Accept and return EMACS_INT for sizes.
11983 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11985 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11986 Accept and return EMACS_INT.
11987 (emacs_gnutls_write): Return the number of bytes written on
11989 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
11990 (emacs_read, emacs_write): Remove check for negative size, as the
11991 Emacs source code has been audited now.
11992 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11993 (emacs_read, emacs_write): Use it.
11994 * process.c (send_process): Adjust to the new signatures of
11995 emacs_write and emacs_gnutls_write. Do not attempt to store
11996 a byte offset into an 'int'; it might overflow.
11997 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
11999 * sound.c: Don't assume sizes fit in 'int'.
12000 (struct sound_device.period_size, alsa_period_size):
12001 Return EMACS_INT, not int.
12002 (struct sound_device.write, vox_write, alsa_write):
12003 Accept EMACS_INT, not int.
12004 (wav_play, au_play): Use EMACS_INT to store sizes and to
12005 record read return values.
12007 2011-04-15 Ben Key <bkey76@gmail.com>
12009 * keyboard.c (Qundefined): Don't declare static since it is used
12011 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12012 static since they are used in nsfont.m.
12014 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12016 * process.c (Qprocessp): Don't declare static.
12017 * lisp.h (Qprocessp): Declare again.
12019 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
12021 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12023 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12025 Improve C-level modularity by making more things 'static'.
12027 Don't publish debugger-only interfaces to other modules.
12028 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12029 (verify_bytepos, count_markers): Move decls to the only modules
12031 * region-cache.h (pp_cache): Likewise.
12032 * window.h (check_all_windows): Likewise.
12033 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12035 * sysdep.c (croak): Now static, if
12036 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12037 * syssignal.h (croak): Declare only if not static.
12039 * alloc.c (refill_memory_reserve): Now static if
12040 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12041 * lisp.h (refill_memory_reserve): Declare only if not static.
12043 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12044 Define only if USE_LUCID.
12046 * xrdb.c (x_customization_string, x_rm_string): Now static.
12048 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12049 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12051 * xdisp.c (draw_row_with_mouse_face): Now static.
12052 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12054 * window.h (check_all_windows): Mark externally visible.
12056 * window.c (window_deletion_count): Now static.
12058 * undo.c: Make symbols static if they're not exported.
12059 (last_undo_buffer, last_boundary_position, pending_boundary):
12062 * textprop.c (interval_insert_behind_hooks): Now static.
12063 (interval_insert_in_front_hooks): Likewise.
12065 * term.c: Make symbols static if they're not exported.
12066 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12067 (max_frame_lines, tty_set_terminal_modes):
12068 (tty_reset_terminal_modes, tty_turn_off_highlight):
12069 (get_tty_terminal): Now static.
12070 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12071 * termhooks.h (term_mouse_moveto): Do not declare if
12072 HAVE_WINDOW_SYSTEM.
12073 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12074 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12076 * sysdep.c: Make symbols static if they're not exported.
12077 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12079 (sigprocmask_set, full_mask): Remove; unused.
12080 (wait_debugging): Mark as visible.
12081 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12082 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12084 * syntax.c (syntax_temp): Define only if !__GNUC__.
12086 * sound.c (current_sound_device, current_sound): Now static.
12088 * search.c (searchbufs, searchbuf_head): Now static.
12090 * scroll.c (scroll_cost): Remove; unused.
12091 * dispextern.h (scroll_cost): Remove decl.
12093 * region-cache.h (pp_cache): Mark as externally visible.
12095 * process.c: Make symbols static if they're not exported.
12096 (process_tick, update_tick, create_process, chan_process):
12097 (Vprocess_alist, proc_buffered_char, datagram_access):
12098 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12099 (deactivate_process): Mark defn as static, as well as decl.
12100 * lisp.h (create_process): Remove decl.
12101 * process.h (chan_process, Vprocess_alist): Remove decls.
12103 * print.c: Make symbols static if they're not exported.
12104 (print_depth, new_backquote_output, being_printed, print_buffer):
12105 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12106 (print_interval, print_number_index, initial_stderr_stream):
12108 * lisp.h (Fprinc): Remove decl.
12109 (debug_output_compilation_hack): Mark as externally visible.
12111 * sysdep.c (croak): Move decl from here to syssignal.h.
12112 * syssignal.h (croak): Put it here, so the API can be checked when
12113 'croak' is called from dissociate_if_controlling_tty.
12115 * minibuf.c: Make symbols static if they're not exported.
12116 (minibuf_save_list, choose_minibuf_frame): Now static.
12117 * lisp.h (choose_minibuf_frame): Remove decl.
12119 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12121 * lread.c: Make symbols static if they're not exported.
12122 (read_objects, initial_obarray, oblookup_last_bucket_number):
12124 (make_symbol): Remove; unused.
12125 * lisp.h (initial_obarray, make_symbol): Remove decls.
12127 * keyboard.c: Make symbols static if they're not exported.
12128 (single_kboard, recent_keys_index, total_keys, recent_keys):
12129 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12130 (this_single_command_key_start, echoing, last_auto_save):
12131 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12132 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12133 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12134 (Vlispy_mouse_stem, double_click_count):
12136 (force_auto_save_soon): Define only if SIGDANGER.
12137 (ignore_mouse_drag_p): Now static if
12138 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12139 (print_help): Remove; unused.
12140 (stop_character, last_timer_event): Mark as externally visible.
12141 * keyboard.h (ignore_mouse_drag_p): Declare only if
12142 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12143 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12144 * lisp.h (echoing): Remove decl.
12145 (force_auto_save_soon): Declare only if SIGDANGER.
12146 * xdisp.c (redisplay_window): Simplify code, to make it more
12147 obvious that ignore_mouse_drag_p is not accessed if !defined
12148 USE_GTK && !defined HAVE_NS.
12150 * intervals.c: Make symbols static if they're not exported.
12151 (merge_properties_sticky, merge_interval_right, delete_interval):
12153 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12155 * insdel.c: Make symbols static if they're not exported.
12156 However, leave prepare_to_modify_buffer alone. It's never
12157 called from outside this function, but that appears to be a bug.
12158 (combine_after_change_list, combine_after_change_buffer):
12159 (adjust_after_replace, signal_before_change): Now static.
12160 (adjust_after_replace_noundo): Remove; unused.
12161 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
12162 (signal_before_change): Remove decls.
12164 * indent.c (val_compute_motion, val_vmotion): Now static.
12166 * image.c: Make symbols static if they're not exported.
12167 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12169 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12170 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12172 * fringe.c (standard_bitmaps): Now static.
12173 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12175 * frame.c: Make symbols static if they're not exported.
12176 (x_report_frame_params, make_terminal_frame): Now static.
12177 (get_frame_param): Now static, unless HAVE_NS.
12178 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12179 (x_get_resource_string): Remove; not used.
12180 * frame.h (make_terminal_frame, x_report_frame_params):
12181 (x_get_resource_string); Remove decls.
12182 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12183 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12185 * font.c, fontset.c: Make symbols static if they're not exported.
12186 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12187 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12188 * font.c (font_close_object): Now static.
12189 * font.h (font_close_object): Remove.
12190 * fontset.c (FONTSET_OBJLIST): Remove.
12191 (free_realized_fontset) #if-0 the body, which does nothing.
12192 (face_suitable_for_char_p): #if-0, as it's never called.
12193 * fontset.h (face_suitable_for_char_p): Remove decl.
12194 * xfaces.c (face_at_string_position):
12195 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
12196 since 0 is always ASCII.
12198 * fns.c (weak_hash_tables): Now static.
12200 * fileio.c: Make symbols static if they're not exported.
12201 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12202 (Vwrite_region_annotation_buffers): Now static.
12204 * eval.c: Make symbols static if they're not exported.
12205 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12206 * lisp.h (backtrace_list): Remove decl.
12208 * emacs.c: Make symbols static if they're not exported.
12209 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12210 (fatal_error_code, fatal_error_signal_hook, standard_args):
12212 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12213 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12214 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12215 * lisp.h (fatal_error_signal_hook): Remove decl.
12216 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12218 * editfns.c: Move a (normally-unused) function to its only use.
12219 * editfns.c, lisp.h (get_operating_system_release): Remove.
12220 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12221 worth the hassle of breaking this out.
12223 * xterm.c: Make symbols static if they're not exported.
12224 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12225 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12226 (x_destroy_window, x_delete_display):
12228 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12229 (x_mouse_leave): Remove; unused.
12230 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12231 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12232 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12234 (x_mouse_leave): Declare only if WINDOWSNT.
12235 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12236 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12239 * ftxfont.c: Make symbols static if they're not exported.
12240 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12242 * font.h (ftxfont_driver): Likewise.
12244 * xfns.c: Make symbols static if they're not exported.
12245 (x_last_font_name, x_display_info_for_name):
12246 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12247 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12248 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12249 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12250 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12251 (last_show_tip_args): Now static.
12252 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12253 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12254 (x_screen_planes): Remove; unused.
12255 * dispextern.h (x_screen_planes): Remove decl.
12257 * dispnew.c: Make symbols static if they're not exported.
12258 * dispextern.h (redraw_garbaged_frames, scrolling):
12259 (increment_row_positions): Remove.
12260 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12261 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12263 (redraw_garbaged_frames): Remove; unused.
12265 * xfaces.c: Make symbols static if they're not exported.
12266 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12268 * xterm.h (defined_color): Remove decls.
12269 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12270 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12271 (menu_face_changed_default, defined_color, free_realized_face):
12272 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12273 (ascii_face_of_lisp_face): Remove; unused.
12275 * xdisp.c: Make symbols static if they're not exported.
12276 * dispextern.h (scratch_glyph_row, window_box_edges):
12277 (glyph_to_pixel_coords, set_cursor_from_row):
12278 (get_next_display_element, set_iterator_to_next):
12279 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12280 (show_mouse_face): Remove decls
12281 * frame.h (message_buf_print): Likewise.
12282 * lisp.h (pop_message, set_message, check_point_in_composition):
12284 * xterm.h (set_vertical_scroll_bar): Likewise.
12285 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12286 (message_buf_print, scratch_glyph_row, displayed_buffer):
12287 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12288 (get_next_display_element, show_mouse_face, window_box_edges):
12289 (frame_to_window_pixel_xy, check_point_in_composition):
12290 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12291 (glyph_to_pixel_coords): Remove; unused.
12293 * dired.c (file_name_completion): Now static.
12295 * dbusbind.c (xd_in_read_queued_messages): Now static.
12297 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12298 * data.c (circular_list_error): Remove.
12300 * commands.h (last_point_position, last_point_position_buffer):
12301 (last_point_position_window): Remove decls.
12302 * keyboard.c: Make these variables static.
12304 * coding.h (coding, code_convert_region, encode_coding_gap):
12306 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12307 (iso_code_class, detect_coding, code_convert_region): Now static.
12308 (encode_coding_gap): Remove; unused.
12310 * chartab.c (chartab_chars, chartab_bits): Now static.
12312 * charset.h (charset_iso_8859_1): Remove decl.
12313 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12316 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12317 * ccl.c (Vccl_program_table): Now static.
12318 (check_ccl_update): Remove; unused.
12320 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12321 * category.h: ... from here.
12322 * category.c (check_category_table, set_category_set): Now static.
12324 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12325 * lisp.h: Remove these decls.
12327 * buffer.c (buffer_count): Remove unused var.
12329 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12330 so that it's not optimized away.
12331 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12332 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12333 exported only to the debugger.
12335 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
12336 * atimer.h (run_all_atimers): Remove; not exported.
12338 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12339 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12340 was inaccessible from Lisp.
12341 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12342 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12344 alloc.c: Import and export fewer symbols, and remove unused items.
12345 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12347 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12348 it's not optimized away by whole-program optimization.
12349 (message_enable_multibyte, free_misc): Remove.
12350 (catchlist, handlerlist, mark_backtrace):
12351 Declare only if BYTE_MARK_STACK.
12352 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12353 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12354 (message_enable_multibyte): Remove decl.
12355 (free_misc, interval_free_list, float_block, float_block_index):
12356 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12357 (cons_free_list, last_marked_index):
12359 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12360 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12361 (mark_backtrace): Define only if BYTE_MARK_STACK.
12362 * xdisp.c (message_enable_multibyte): Now static.
12364 Declare Lisp_Object Q* variables to be 'static' if not exported.
12365 This makes it easier for human readers (and static analyzers)
12366 to see whether these variables are used from other modules.
12367 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12368 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12369 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12370 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12371 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12372 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12373 * xmenu.c, xselect.c:
12374 Declare Q* vars static if they are not used in other modules.
12375 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12376 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12377 Remove decls of unexported vars.
12378 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12380 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12382 Make Emacs functions such as Fatom 'static' by default.
12383 This makes it easier for human readers (and static analyzers)
12384 to see whether these functions can be called from other modules.
12385 DEFUN now defines a static function. To make the function external
12386 so that it can be used in other C modules, use the new macro DEFUE.
12387 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12388 (Finit_image_library):
12389 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12390 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12391 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12392 Remove decls, since these functions are now static.
12393 (Funintern, Fget_internal_run_time): New decls, since these functions
12394 were already external.
12396 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12397 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12398 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12399 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12400 * keyboard.c, keymap.c, lread.c:
12401 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12402 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12403 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12404 Mark functions with DEFUE instead of DEFUN,
12405 if they are used in other modules.
12406 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12407 decls for now-static functions.
12408 * buffer.h (Fdelete_overlay): Remove decl.
12409 * callproc.c (Fgetenv_internal): Mark as internal.
12410 * composite.c (Fremove_list_of_text_properties): Remove decl.
12411 (Fcomposition_get_gstring): New forward static decl.
12412 * composite.h (Fcomposite_get_gstring): Remove decl.
12413 * dired.c (Ffile_attributes): New forward static decl.
12414 * doc.c (Fdocumntation_property): New forward static decl.
12415 * eval.c (Ffetch_bytecode): New forward static decl.
12416 (Funintern): Remove extern decl; now in .h file where it belongs.
12417 * fileio.c (Fmake_symbolic_link): New forward static decl.
12418 * image.c (Finit_image_library): New forward static decl.
12419 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12420 * intervals.h (Fprevious_property_change):
12421 (Fremove_list_of_text_properties): Remove decls.
12422 * keyboard.c (Fthis_command_keys): Remove decl.
12423 (Fcommand_execute): New forward static decl.
12424 * keymap.c (Flookup_key): New forward static decl.
12425 (Fcopy_keymap): Now static.
12426 * keymap.h (Flookup_key): Remove decl.
12427 * process.c (Fget_process): New forward static decl.
12428 (Fprocess_datagram_address): Mark as internal.
12429 * syntax.c (Fsyntax_table_p): New forward static decl.
12430 (skip_chars): Remove duplicate decl.
12431 * textprop.c (Fprevious_property_change): New forward static decl.
12432 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12434 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12435 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12437 * editfns.c (Fformat): Remove unreachable code.
12439 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12441 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12444 2011-04-13 Eli Zaretskii <eliz@gnu.org>
12446 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12447 when at ZV. (Bug#8487)
12449 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12451 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12453 * keyboard.c (parse_tool_bar_item): Likewise.
12454 * sound.c (sound_cleanup, alsa_close): Likewise.
12455 * termcap.c (tgetent): Likewise.
12456 * xfns.c (x_default_font_parameter): Likewise.
12457 * xsettings.c (read_and_apply_settings): Likewise.
12459 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12460 (overrun_check_free): Protoize.
12462 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12464 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12465 since callers should never pass a negative size.
12466 Change the signature to match that of plain 'read' and 'write'; see
12467 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12468 * lisp.h: Update prototypes of emacs_write and emacs_read.
12470 2011-04-11 Eli Zaretskii <eliz@gnu.org>
12472 * xdisp.c (redisplay_window): Don't try to determine the character
12473 position of the scroll margin if the window start point w->startp
12474 is outside the buffer's accessible region. (Bug#8468)
12476 2011-04-10 Eli Zaretskii <eliz@gnu.org>
12478 Fix write-region and its subroutines for buffers > 2GB.
12479 * fileio.c (a_write, e_write): Modify declaration of arguments and
12480 local variables to support buffers larger than 2GB.
12481 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12483 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12484 argument, local variables, and return value.
12486 * lisp.h: Update prototypes of emacs_write and emacs_read.
12488 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12490 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
12492 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12494 Fix more problems found by GCC 4.6.0's static checks.
12496 * xdisp.c (vmessage): Use a better test for character truncation.
12498 * charset.c (load_charset_map): <, not <=, for optimization,
12499 and to avoid potential problems with integer overflow.
12500 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
12501 * casetab.c (set_identity, shuffle): Likewise.
12502 * editfns.c (Fformat): Likewise.
12503 * syntax.c (skip_chars): Likewise.
12505 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12506 This also lets GCC 4.6.0 generate slightly better loop code.
12508 * callint.c (Fcall_interactively): <, not <=, for optimization.
12509 (Fcall_interactively): Count the number of arguments produced,
12510 not the number of arguments given. This is simpler and lets GCC
12511 4.6.0 generate slightly better code.
12513 * ftfont.c: Distingish more carefully between FcChar8 and char.
12514 The previous code passed unsigned char * to a functions like
12515 strlen and xstrcasecmp that expect char *, which does not
12516 conform to the C standard.
12517 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12518 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12519 char * when the C standard requires it.
12521 * keyboard.c (read_char): Remove unused var.
12523 * eval.c: Port to Windows vsnprintf (Bug#8435).
12524 Include <limits.h>.
12525 (SIZE_MAX): Define if the headers do not.
12526 (verror): Do not give up if vsnprintf returns a negative count.
12527 Instead, grow the buffer. This ports to Windows vsnprintf, which
12528 does not conform to C99. Problem reported by Eli Zaretskii.
12529 Also, simplify the allocation scheme, by avoiding the need for
12530 calling realloc, and removing the ALLOCATED variable.
12532 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12534 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12535 But keep the doprint source code for now, as we might revamp it
12536 and use it again (Bug#8435).
12537 * lisp.h (doprnt): Remove.
12538 * Makefile.in (base_obj): Remove doprnt.o.
12539 * deps.mk (doprnt.o): Remove.
12541 error: Print 32- and 64-bit integers portably (Bug#8435).
12542 Without this change, on typical 64-bit hosts error ("...%d...", N)
12543 was used to print both 32- and 64-bit integers N, which relied on
12544 undefined behavior.
12545 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
12546 * lisp.h (error, verror): Mark as printf-like functions.
12547 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12548 Report overflow in size calculations when allocating printf buffer.
12549 Do not truncate output string at its first null byte.
12550 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12551 Truncate the output at a character boundary, since vsnprintf does not
12553 * charset.c (check_iso_charset_parameter): Convert internal
12554 character to string before calling 'error', since %c now has the
12556 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12557 overflow when computing char to be passed to 'error'. Do not
12558 pass Lisp_Object to 'error'; pass the integer instead.
12559 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12560 formatted with plain %d.
12562 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12564 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12566 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12568 * xterm.c (x_catch_errors): Remove duplicate declaration.
12570 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12572 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12574 2011-04-10 Jim Meyering <meyering@redhat.com>
12576 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12577 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12578 return ssize_t not "int", and use size_t as the buffer length.
12579 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12580 * gnutls.h: Update declarations.
12581 * process.c (read_process_output): Use ssize_t, to match.
12582 (send_process): Likewise.
12584 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12586 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12588 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12590 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12591 Use unsigned char, to match FcChar8 type definition.
12593 * xterm.c (handle_one_xevent):
12594 * xmenu.c (create_and_show_popup_menu):
12595 * xselect.c (x_decline_selection_request)
12596 (x_reply_selection_request): Avoid type-punned deref of X events.
12598 2011-04-09 Eli Zaretskii <eliz@gnu.org>
12600 Fix some uses of `int' instead of EMACS_INT.
12601 * search.c (string_match_1, fast_string_match)
12602 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12603 (scan_buffer, find_next_newline_no_quit)
12604 (find_before_next_newline, search_command, Freplace_match)
12605 (Fmatch_data): Make some `int' variables be EMACS_INT.
12607 * xdisp.c (display_count_lines): 3rd argument and return value now
12608 EMACS_INT. All callers changed.
12609 (pint2hrstr): Last argument is now EMACS_INT.
12611 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12612 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12613 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12614 (decode_coding_utf_16, decode_coding_emacs_mule)
12615 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12616 (decode_coding_ccl, decode_coding_charset)
12617 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12618 (decode_coding_iso_2022, decode_coding_emacs_mule)
12619 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12620 <char_offset, last_offset>: Declare EMACS_INT.
12621 (encode_coding_utf_8, encode_coding_utf_16)
12622 (encode_coding_emacs_mule, encode_invocation_designation)
12623 (encode_designation_at_bol, encode_coding_iso_2022)
12624 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12625 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12627 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12628 (encode_invocation_designation): Last argument P_NCHARS is now
12630 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12631 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12633 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12636 * ccl.c (Fccl_execute_on_string): Declare some variables
12639 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
12641 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12643 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12645 * process.c (Fformat_network_address): Doc fix.
12647 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12649 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
12651 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
12653 * keyboard.c (read_char): Call Lisp function help-form-show,
12654 instead of using internal_with_output_to_temp_buffer.
12655 (Qhelp_form_show): New var.
12656 (syms_of_keyboard): Use DEFSYM macro.
12658 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12660 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12662 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
12664 * process.c (Flist_processes): Remove to Lisp.
12665 (list_processes_1): Delete.
12667 2011-04-06 Eli Zaretskii <eliz@gnu.org>
12669 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12671 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12673 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
12675 Fix more problems found by GCC 4.6.0's static checks.
12677 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12679 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12681 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
12683 * xdisp.c (vmessage): Mark as a printf-like function.
12685 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12687 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12689 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12690 printf-like functions.
12691 (tiff_load): Add casts to remove these marks before passing them
12692 to system-supplied API.
12694 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12696 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12697 This avoids several warnings with gcc -Wstrict-overflow.
12698 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12699 directly, rather than having caller test rule sign. This avoids
12700 some unnecessary tests.
12701 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12702 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12703 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
12705 * xfont.c (xfont_text_extents): Remove var that was set but not used.
12706 (xfont_open): Avoid unnecessary tests.
12708 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12710 * composite.h, composite.c (composition_gstring_put_cache):
12711 Use EMACS_INT, not int, for length.
12713 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12714 breaking out part of COMPOSITION_DECODE_RULE.
12715 (COMPOSITION_DECODE_RULE): Use it.
12716 * composite.c (get_composition_id): Remove unused local vars,
12717 by using the new macro.
12719 * textprop.c (set_text_properties_1): Change while to do-while,
12720 since the condition is always true at first.
12722 * intervals.c (graft_intervals_into_buffer): Mark var as used.
12723 (interval_deletion_adjustment): Return unsigned value.
12726 * process.c (list_processes_1, create_pty, read_process_output):
12727 (exec_sentinel): Remove vars that were set but not used.
12728 (create_pty): Remove unnecessary "volatile"s.
12729 (Fnetwork_interface_info): Avoid possibility of int overflow.
12730 (read_process_output): Do adaptive read buffering even if carryover.
12731 (read_process_output): Simplify nbytes computation if buffered.
12733 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12735 * syntax.c (scan_words): Remove var that was set but not used.
12736 (update_syntax_table): Use unsigned instead of int.
12738 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
12739 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
12740 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
12742 * print.c (print_error_message): Avoid int overflow.
12744 * font.c (font_list_entities): Redo for clarity,
12745 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12747 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
12748 (font_score): Avoid potential overflow in diff calculation.
12750 * fns.c (substring_both): Remove var that is set but not used.
12751 (sxhash): Redo loop for clarity and to avoid wraparound warning.
12753 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12755 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12756 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12757 can always succeed if overflow has undefined behavior.
12759 * search.c (boyer_moore, wordify): Remove vars set but not used.
12760 (wordify): Omit three unnecessary tests.
12762 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12763 All callers changed. This avoids the need for an unused var.
12765 * casefiddle.c (casify_region): Remove var that is set but not used.
12767 * dired.c (file_name_completion): Remove var that is set but not used.
12769 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12771 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
12772 (Finsert_file_contents): Remove unnecessary code checking fd.
12774 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12775 Check for integer overflow on size calculations.
12777 * buffer.c (Fprevious_overlay_change): Remove var that is set
12780 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12781 Remove vars that are set but not used.
12782 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
12783 (timer_check_2): Mark vars as initialized.
12785 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12787 * image.c (lookup_image): Remove var that is set but not used.
12788 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
12790 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12791 that are set but not used.
12793 * xfns.c (make_invisible_cursor): Don't return garbage
12794 if XCreateBitmapFromData fails (Bug#8410).
12796 * xselect.c (x_get_local_selection, x_handle_property_notify):
12797 Remove vars that are set but not used.
12799 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
12800 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
12802 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12803 Remove var that is set but not used.
12804 (scroll_bar_windows_size): Now size_t, not int.
12805 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12806 Check for overflow.
12808 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12809 (map_tty_color) [!defined MSDOS]: Likewise.
12811 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12813 * coding.c: Remove vars that are set but not used.
12814 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12815 All callers changed.
12816 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12817 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12818 (decode_coding_charset): Remove vars that are set but not used.
12820 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12821 that is set but not used.
12823 * print.c (print_object): Remove var that is set but not used.
12825 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
12826 The gnulib version avoids calling malloc in the usual case,
12827 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12828 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12829 * filelock.c (current_lock_owner): Likewise.
12830 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12831 * sysdep.c: Include allocator.h, careadlinkat.h.
12832 (emacs_no_realloc_allocator): New static constant.
12833 (emacs_readlink): New function.
12834 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12835 ../lib/careadlinkat.h.
12837 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12839 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12840 first non-nil return value).
12842 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12844 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12845 if not defined (Bug#8403).
12847 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12849 * xdisp.c (display_count_lines): Remove parameter `start',
12850 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12851 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12852 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12853 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12854 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12855 and thereabouts. All callers changed.
12856 (get_per_char_metric): Remove parameter `f', unused since
12857 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12859 2011-04-02 Jim Meyering <meyering@redhat.com>
12861 do not dereference NULL upon failed strdup
12862 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12863 (ns_get_family): Likewise.
12865 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12867 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12869 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12871 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12874 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12876 Add lexical binding.
12878 * window.c (Ftemp_output_buffer_show): New fun.
12879 (Fsave_window_excursion):
12880 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12882 * lread.c (lisp_file_lexically_bound_p): New function.
12883 (Fload): Bind Qlexical_binding.
12884 (readevalloop): Remove `evalfun' arg.
12885 Bind Qinternal_interpreter_environment.
12886 (Feval_buffer): Bind Qlexical_binding.
12887 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12889 (syms_of_lread): Declare `lexical-binding'.
12891 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12893 * keyboard.c (eval_dyn): New fun.
12894 (menu_item_eval_property): Use it.
12896 * image.c (parse_image_spec): Use Ffunctionp.
12898 * fns.c (concat, mapcar1): Accept byte-code-functions.
12900 * eval.c (Fsetq): Handle lexical vars.
12901 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12902 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12903 (FletX, Flet): Obey lexical binding.
12904 (Fcommandp): Handle closures.
12905 (Feval): New `lexical' arg.
12906 (eval_sub): New function extracted from Feval. Use it almost
12907 everywhere where Feval was used. Look up vars in lexical env.
12909 (Ffunctionp): Move from subr.el.
12910 (Ffuncall): Handle closures.
12911 (apply_lambda): Remove `eval_flags'.
12912 (funcall_lambda): Handle closures and new byte-code-functions.
12913 (Fspecial_variable_p): New function.
12914 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12915 but without exporting it to Lisp.
12917 * doc.c (Fdocumentation, store_function_docstring):
12918 * data.c (Finteractive_form): Handle closures.
12920 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12923 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12925 (exec_byte_code): New function extracted from Fbyte_code to handle new
12926 calling convention for byte-code-functions. Add new byte-codes.
12928 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
12930 * alloc.c (Fmake_symbol): Init new `declared_special' field.
12932 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12934 * xdisp.c (redisplay_internal): Fix prototype.
12936 2011-03-31 Eli Zaretskii <eliz@gnu.org>
12938 * xdisp.c (SCROLL_LIMIT): New macro.
12939 (try_scrolling): Use it when setting scroll_limit.
12940 Limit scrolling to 100 screen lines.
12941 (redisplay_window): Even when falling back on "recentering",
12942 position point in the window according to scroll-conservatively,
12943 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12945 (try_scrolling): When point is above the window, allow searching
12946 as far as scroll_max, or one screenful, to compute vertical
12947 distance from PT to the scroll margin position. This prevents
12948 try_scrolling from unnecessarily failing when
12949 scroll-conservatively is set to a value slightly larger than the
12950 window height. Clean up the case of PT below the margin at bottom
12951 of window: scroll_max can no longer be INT_MAX. When aggressive
12952 scrolling is in use, don't let point enter the opposite scroll
12953 margin as result of the scroll.
12954 (syms_of_xdisp) <scroll-conservatively>: Document the
12955 threshold of 100 lines for never-recentering scrolling.
12957 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12959 * dispextern.h (move_it_by_lines):
12960 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12961 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12962 (message_log_check_duplicate): Remove parameters `prev_bol' and
12963 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12964 (redisplay_internal): Remove parameter `preserve_echo_area',
12965 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12967 * indent.c (Fvertical_motion):
12968 * window.c (window_scroll_pixel_based, Frecenter):
12969 Don't pass `need_y_p' to `move_it_by_lines'.
12971 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12973 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12974 steal a few bits to be more compact.
12975 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12976 Remove unneeded casts.
12978 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12980 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12982 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12983 binding" message (bug#7967).
12985 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12987 Fix more problems found by GCC 4.6.0's static checks.
12989 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12990 Remove unused local var.
12992 * editfns.c (Fmessage_box): Remove unused local var.
12994 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12995 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12996 Omit unused local vars.
12997 * window.c (shrink_windows): Omit unused local var.
12998 * menu.c (digest_single_submenu): Omit unused local var.
12999 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13000 Omit unused local var.
13002 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13003 Don't assume string length fits in int.
13004 (keyremap_step, read_key_sequence): Use size_t for sizes.
13005 (read_key_sequence): Don't check last_real_key_start redundantly.
13007 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13008 instead of alloca (Bug#8344).
13010 * eval.c (Fbacktrace): Don't assume nargs fits in int.
13011 (Fbacktrace_frame): Don't assume nframes fits in int.
13013 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13015 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13018 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13020 * cm.c (calccost): Turn while-do into do-while, for clarity.
13022 * keyboard.c (syms_of_keyboard): Use the same style as later
13023 in this function when indexing through an array. This also
13024 works around GCC bug 48267.
13026 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13028 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13030 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13031 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13033 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13034 This avoids undefined behavior on integer overflow, and is a bit
13035 more convenient anyway since it is compared to a size_t variable.
13037 Variadic C functions now count arguments with size_t, not int.
13038 This avoids an unnecessary limitation on 64-bit machines, which
13039 caused (substring ...) to crash on large vectors (Bug#8344).
13040 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13041 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
13042 All variadic functions and their callers changed accordingly.
13043 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13044 * data.c (arith_driver, float_arith_driver): Likewise.
13045 * editfns.c (general_insert_function): Likewise.
13046 * eval.c (struct backtrace.nargs, interactive_p)
13047 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13048 (funcall_lambda, mark_backtrace): Likewise.
13049 * fns.c (concat): Likewise.
13050 * frame.c (x_set_frame_parameters): Likewise.
13051 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13052 0 if not found, not -1. All callers changed.
13054 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13055 (stack_copy_size): Now size_t, not int.
13056 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13058 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13060 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13061 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13062 All callers changed.
13064 * lisp.h (multibyte_char_to_unibyte):
13065 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13066 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13067 * character.h (CHAR_TO_BYTE8):
13068 * cmds.c (internal_self_insert):
13069 * editfns.c (general_insert_function):
13070 * keymap.c (push_key_description):
13071 * search.c (Freplace_match):
13072 * xdisp.c (message_dolog, set_message_1): All callers changed.
13074 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13076 * keyboard.c (safe_run_hook_funcall): New function.
13077 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13078 don't set the hook to nil, but remove the offending function instead.
13079 (Qcommand_hook_internal): Remove, unused.
13080 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13081 Vcommand_hook_internal.
13083 * eval.c (enum run_hooks_condition): Remove.
13084 (funcall_nil, funcall_not): New functions.
13085 (run_hook_with_args): Call each function through a `funcall' argument.
13086 Remove `cond' argument, now redundant.
13087 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13088 (Frun_hook_with_args_until_failure): Adjust accordingly.
13089 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13091 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13093 * dispextern.h (string_buffer_position): Remove declaration.
13095 * print.c (strout): Remove parameter `multibyte', unused since
13096 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13098 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13099 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13100 All callers changed.
13102 * w32.c (_wsa_errlist): Use braces for struct initializers.
13104 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13105 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13106 All callers changed.
13107 (string_buffer_position): Likewise. Also, make static (it's never
13108 used outside xdisp.c).
13109 (cursor_row_p): Remove parameter `w', unused since
13110 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13111 (decode_mode_spec): Remove parameter `precision', introduced during
13112 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13113 All callers changed.
13115 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13117 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13119 2011-03-27 Anders Lindgren <andlind@gmail.com>
13121 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13122 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13123 (ns_update_auto_hide_menu_bar): New functions.
13124 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13125 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13126 ns_constrain_all_frames.
13127 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13128 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13130 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13132 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13134 2011-03-27 Glenn Morris <rgm@gnu.org>
13136 * syssignal.h: Replace RETSIGTYPE with void.
13137 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13138 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13139 Replace SIGTYPE with void everywhere.
13140 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13141 * s/template.h (SIGTYPE): Remove commented out definition.
13143 2011-03-26 Eli Zaretskii <eliz@gnu.org>
13145 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13146 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13148 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
13150 * w32.c (read_unc_volume): Use parameter `henum', instead of
13151 global variable `wget_enum_handle'.
13153 * keymap.c (describe_vector): Remove parameters `indices' and
13154 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13155 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13157 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13159 * keyboard.c (timer_check): Remove parameter `do_it_now',
13160 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13161 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13162 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13164 * keyboard.c (read_char):
13165 * w32menu.c (w32_menu_display_help):
13166 * xmenu.c (show_help_event, menu_help_callback):
13167 Adjust calls to `show_help_echo'.
13169 * gtkutil.c (xg_maybe_add_timer):
13170 * keyboard.c (readable_events):
13171 * process.c (wait_reading_process_output):
13172 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13174 * insdel.c (adjust_markers_gap_motion):
13175 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13176 (gap_left, gap_right): Don't call it.
13178 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
13180 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13181 incurred during fontification.
13183 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13185 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13186 (DEFVAR_PER_BUFFER): Don't pass it.
13188 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13189 (scrolling_window): Don't pass it.
13191 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13193 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13195 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13197 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13198 of variables specific to SELinux and computation of `encoded_absname'.
13200 * image.c (XPutPixel): Remove unused variable `height'.
13202 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13204 * unexw32.c (get_section_info): Remove unused variable `section'.
13206 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13207 (system_process_attributes): Remove unused variable `sess'.
13208 (sys_read): Remove unused variable `err'.
13210 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13211 (w32_wnd_proc): Remove unused variable `isdead'.
13212 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13213 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13214 (x_create_tip_frame): Remove unused variable `tem'.
13216 * w32inevt.c (w32_console_read_socket):
13217 Remove unused variable `no_events'.
13219 * w32term.c (x_draw_composite_glyph_string_foreground):
13220 Remove unused variable `width'.
13222 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
13224 * w32term.c (x_set_glyph_string_clipping):
13225 Don't pass uninitialized region to CombineRgn.
13227 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
13229 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13230 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13231 (Fx_close_connection): Remove unused variable `i'.
13233 * w32font.c (w32font_draw): Return number of glyphs.
13234 (w32font_open_internal): Remove unused variable `i'.
13235 (w32font_driver): Add missing initializer.
13237 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13238 (fill_in_menu): Remove unused variable `items_added'.
13240 * w32term.c (last_mouse_press_frame): Remove static global variable.
13241 (w32_clip_to_row): Remove unused variable `f'.
13242 (x_delete_terminal): Remove unused variable `i'.
13244 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13245 (NOTHING): Remove unused static global variable.
13246 (uniscribe_check_otf): Remove unused variable `table'.
13247 (uniscribe_font_driver): Add missing initializers.
13249 2011-03-23 Julien Danjou <julien@danjou.info>
13251 * term.c (Fsuspend_tty, Fresume_tty):
13252 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13253 * window.c (temp_output_buffer_show):
13254 * insdel.c (signal_before_change):
13255 * frame.c (Fhandle_switch_frame):
13256 * fileio.c (Fdo_auto_save):
13257 * emacs.c (Fkill_emacs):
13258 * editfns.c (save_excursion_restore):
13259 * cmds.c (internal_self_insert):
13260 * callint.c (Fcall_interactively):
13261 * buffer.c (Fkill_all_local_variables):
13262 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13264 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
13265 unconditionally since it does the check itself.
13267 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
13269 Fix more problems found by GCC 4.5.2's static checks.
13271 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13272 the first time through the loop, since we know p0 < p1 then.
13273 This also avoids a gcc -Wstrict-overflow warning.
13275 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13276 leading to a memory leak, possible in functions like
13277 load_charset_map_from_file that can allocate an unbounded number
13278 of objects (Bug#8318).
13280 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13281 that could (at least in theory) be that large.
13283 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13284 This is less likely to overflow, and avoids undefined behavior if
13285 overflow does occur. All callers changed. Use strtoul to scan
13286 for the unsigned long integer.
13287 (pint2hrstr): Simplify and tune code slightly.
13288 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
13290 * scroll.c (do_scrolling): Work around GCC bug 48228.
13291 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13293 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13294 This also avoids a warning with gcc -Wstrict-overflow.
13295 (validate_x_resource_name): Simplify count usage.
13296 This also avoids a warning with gcc -Wstrict-overflow.
13298 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13301 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
13303 * process.c (Fmake_network_process): Use socklen_t, not int,
13304 where POSIX says socklen_t is required in portable programs.
13305 This fixes a porting bug on hosts like 64-bit HP-UX, where
13306 socklen_t is wider than int (Bug#8277).
13307 (Fmake_network_process, server_accept_connection):
13308 (wait_reading_process_output, read_process_output):
13311 * process.c: Rename or move locals to avoid shadowing.
13312 (list_processes_1, Fmake_network_process):
13313 (read_process_output_error_handler, exec_sentinel_error_handler):
13314 Rename or move locals.
13315 (Fmake_network_process): Define label "retry_connect" only if needed.
13316 (Fnetwork_interface_info): Fix pointer signedness.
13317 (process_send_signal): Add cast to avoid pointer signedness problem.
13318 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
13319 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
13321 Make tparam.h and terminfo.c consistent.
13322 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13323 Include tparam.h instead, since it declares them.
13324 * cm.h (PC): Remove extern decl; tparam.h now does this.
13325 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13326 * terminfo.c: Include tparam.h, to check interfaces.
13327 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13328 (tparam): Adjust signature to match interface in tparam.h;
13329 this removes some undefined behavior. Check that outstring and len
13330 are zero, which they always are with Emacs.
13331 * tparam.h (PC, BC, UP): New extern decls.
13333 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
13334 (xftfont_open): Rename locals to avoid shadowing.
13336 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
13337 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13338 (OTF_TAG_SYM): Omit macro if not needed.
13339 (ftfont_list): Remove unused local.
13340 (get_adstyle_property, ftfont_pattern_entity):
13341 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13342 Rename locals to avoid shadowing.
13344 * xfont.c (xfont_list_family): Mark var as initialized.
13346 * xml.c (make_dom): Now static.
13348 * composite.c (composition_compute_stop_pos): Rename local to
13350 (composition_reseat_it): Remove unused locals.
13351 (find_automatic_composition, composition_adjust_point): Likewise.
13352 (composition_update_it): Mark var as initialized.
13353 (find_automatic_composition): Mark vars as initialized,
13354 with a FIXME (Bug#8290).
13356 character.h: Rename locals to avoid shadowing.
13357 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13358 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13359 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13360 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13361 to avoid shadowing.
13363 * textprop.c (property_change_between_p): Remove; unused.
13365 * intervals.c (interval_start_pos): Now static.
13367 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13369 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13370 Rename locals to avoid shadowing.
13372 * sound.c (wav_play, au_play, Fplay_sound_internal):
13373 Fix pointer signedness.
13374 (alsa_choose_format): Remove unused local var.
13375 (wav_play): Initialize a variable to 0, to prevent undefined
13376 behavior (Bug#8278).
13378 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13380 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13382 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13383 clobbering (Bug#8298).
13384 * sysdep.c (sys_subshell): Likewise.
13385 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
13387 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13388 This should get cleaned up, so that child_setup has the
13389 same signature on all platforms.
13391 * callproc.c (call_process_cleanup): Now static.
13392 (relocate_fd): Rename locals to avoid shadowing.
13394 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
13396 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13397 not to be necessary, and produces flickering.
13399 2011-03-20 Glenn Morris <rgm@gnu.org>
13401 * config.in: Remove file.
13403 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
13405 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13406 are now in src/globals.h.
13407 (syms_of_minibuf): Remove spurious & from previous change.
13409 2011-03-20 Leo Liu <sdl.web@gmail.com>
13411 * minibuf.c (completing-read-function): New variable.
13412 (completing-read-default): Rename from completing-read.
13413 (completing-read): Call completing-read-function.
13415 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13417 * xfaces.c (Fx_load_color_file):
13418 Read color file from absolute filename (bug#8250).
13420 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13422 * makefile.w32-in: Update dependencies.
13424 2011-03-17 Eli Zaretskii <eliz@gnu.org>
13426 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13428 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13430 Fix more problems found by GCC 4.5.2's static checks.
13432 * process.c (make_serial_process_unwind, send_process_trap):
13433 (sigchld_handler): Now static.
13435 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13436 That way, the code declares only the vars that it needs.
13437 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13438 * s/cygwin.h (PTY_ITERATION): Likewise.
13439 * s/darwin.h (PTY_ITERATION): Likewise.
13440 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13442 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13443 * process.c (allocate_pty): Don't declare stb unless it's needed.
13445 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
13446 (CONSTANTLIM): Remove; unused.
13447 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13448 Define only if needed.
13450 * unexelf.c (unexec): Name an expression,
13451 to avoid gcc -Wbad-function-cast warning.
13452 Use a different way to cause a compilation error if anyone uses
13453 n rather than nn, a way that does not involve shadowing.
13454 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
13456 * deps.mk (unexalpha.o): Remove; unused.
13458 New file unexec.h, the (simple) interface for unexec (Bug#8267).
13459 * unexec.h: New file.
13460 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13461 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13462 Depend on unexec.h.
13463 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13464 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13465 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
13466 Change as necessary to match prototype in unexec.h.
13468 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13470 (back_comment, skip_chars): Mark vars as initialized.
13472 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13473 Rename locals to avoid shadowing.
13475 * lread.c (read1): Rewrite so as not to use empty "else".
13476 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
13478 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13480 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13481 warning when compiling print.c.
13483 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13484 instead of using an uninitialized var.
13485 (font_sort_entities): Mark var as initialized.
13487 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13489 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13490 pointers to constants.
13491 (font_parse_fcname): Remove unused vars.
13492 (font_delete_unmatched): Now static.
13493 (font_get_spec): Remove; unused.
13494 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13495 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13496 Rename or move locals to avoid shadowing.
13498 * fns.c (require_nesting_list, require_unwind): Now static.
13499 (Ffillarray): Rename locals to avoid shadowing.
13501 * floatfns.c (domain_error2): Define only if needed.
13502 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
13504 * alloc.c (mark_backtrace): Move decl from here ...
13505 * lisp.h: ... to here, so that it can be checked.
13507 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
13508 (Fdefvar): Rewrite so as not to use empty "else".
13509 (lisp_indirect_variable): Name an expression,
13510 to avoid gcc -Wbad-function-cast warning.
13511 (Fdefvar): Rename locals to avoid shadowing.
13513 * callint.c (quotify_arg, quotify_args): Now static.
13514 (Fcall_interactively): Rename locals to avoid shadowing.
13515 Use const pointer when appropriate.
13517 * lisp.h (get_system_name, get_operating_system_release):
13518 Move decls here, to check interfaces.
13519 * process.c (get_operating_system_release): Move decl to lisp.h.
13520 * xrdb.c (get_system_name): Likewise.
13521 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13522 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13523 some of which prompt warnings from gcc -Wbad-function-cast.
13524 (Fformat_time_string, Fencode_time, Finsert_char):
13525 (Ftranslate_region_internal, Fformat):
13526 Rename or remove local vars to avoid shadowing.
13527 (Ftranslate_region_internal): Mark var as initialized.
13529 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13532 * lisp.h (eassert): Check that the argument compiles, even if
13533 ENABLE_CHECKING is not defined.
13535 * data.c (Findirect_variable): Name an expression, to avoid
13536 gcc -Wbad-function-cast warning.
13537 (default_value, arithcompare, arith_driver, arith_error): Now static.
13538 (store_symval_forwarding): Rename local to avoid shadowing.
13539 (Fmake_variable_buffer_local, Fmake_local_variable):
13540 Mark variables as initialized.
13541 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
13543 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
13544 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13545 Rename locals to avoid shadowing.
13546 (mark_stack): Move local variables into the #ifdef region where
13548 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13549 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13551 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13552 (GC_STRING_CHARS): Remove; not used.
13553 (Fmemory_limit): Cast sbrk's returned value to char *.
13555 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13556 avoids undefined behavior in theory.
13558 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13560 Use functions, not macros, for up- and down-casing (Bug#8254).
13561 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13562 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13563 to use the following functions instead of these macros.
13564 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13565 EMACS_INT, since callers assume the returned value fits in int.
13566 (upcase1): Likewise, for UPCASE_TABLE.
13567 (uppercasep, lowercasep, upcase): New static inline functions.
13568 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
13569 the race-condition problem in the old DOWNCASE.
13571 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13572 Rename locals to avoid shadowing.
13573 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
13574 (regex_compile, re_search_2, re_match_2_internal):
13575 Remove unused local vars.
13576 (FREE_VAR): Rewrite so as not to use empty "else",
13577 which gcc can warn about.
13578 (regex_compile, re_match_2_internal): Mark locals as initialized.
13579 (RETALLOC_IF): Define only if needed.
13580 (WORDCHAR_P): Likewise. This one is never needed, but is used
13581 only in a comment talking about a compiler bug, so put inside
13582 the #if 0 of that comment.
13583 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13584 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13587 * search.c (boyer_moore): Rename locals to avoid shadowing.
13588 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13589 (PREV_CHAR_BOUNDARY): Likewise.
13591 * search.c (simple_search): Remove unused var.
13593 * dired.c (compile_pattern): Move decl from here ...
13594 * lisp.h: ... to here, so that it can be checked.
13595 (struct re_registers): New forward decl.
13597 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13599 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13601 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13602 Rename locals to avoid shadowing.
13603 (Fvertical_motion): Mark locals as initialized.
13605 * casefiddle.c (casify_object, casify_region): Now static.
13606 (casify_region): Mark local as initialized.
13608 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13610 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13611 New macros, so that the caller can use some names other than
13612 gcpro1, gcpro2, etc.
13613 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13615 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13616 argument, for consistency with GCPRO2_VAR, etc: it is now the
13617 prefix of the variable, not the variable itself. All uses
13619 * dired.c (directory_files_internal, file_name_completion):
13620 Rename locals to avoid shadowing.
13622 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13623 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13624 dired.c's scmp function, had undefined behavior.
13625 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13626 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13627 * buffer.h: ... to here, because these macros use current_buffer,
13628 and the new implementation with inline functions needs to have
13629 current_buffer in scope now, rather than later when the macros
13631 (downcase, upcase1): New static inline functions.
13632 (DOWNCASE, UPCASE1): Reimplement using these functions.
13633 This avoids undefined behavior in expressions like
13634 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13635 from race conditions in accessing the global variables
13636 case_temp1 and case_temp2.
13637 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13638 * lisp.h (case_temp1, case_temp2): Remove their decls.
13639 * character.h (ASCII_CHAR_P): Move from here ...
13640 * lisp.h: ... to here, so that the inline functions mentioned
13641 above can use them.
13643 * dired.c (directory_files_internal_unwind): Now static.
13645 * fileio.c (file_name_as_directory, directory_file_name):
13646 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13648 (file_name_as_directory): Use const pointers when appropriate.
13649 (Fexpand_file_name): Likewise. In particular, newdir might
13650 point at constant storage, so make it a const pointer.
13651 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
13652 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13654 (Fset_file_times, Finsert_file_contents, auto_save_error):
13655 Rename locals to avoid shadowing.
13657 * minibuf.c (choose_minibuf_frame_1): Now static.
13658 (Ftry_completion, Fall_completions): Rename or remove locals
13659 to avoid shadowing.
13661 * marker.c (bytepos_to_charpos): Remove; unused.
13663 * lisp.h (verify_bytepos, count_markers): New decls,
13664 so that gcc does not warn that these functions aren't declared.
13666 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13667 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
13668 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
13669 (copy_text): Remove unused local var.
13671 * filelock.c (within_one_second): Now static.
13672 (lock_file_1): Rename local to avoid shadowing.
13674 * buffer.c (fix_overlays_before): Mark locals as initialized.
13675 (fix_start_end_in_overlays): Likewise. This function should be
13676 simplified by using pointers-to-pointers, but that's a different
13678 (switch_to_buffer_1): Now static.
13679 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13680 (report_overlay_modification): Rename locals to avoid shadowing.
13682 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
13683 Fix pointer signedness issue.
13684 (sys_subshell): Mark local as volatile if checking for lint,
13685 to suppress a gcc -Wclobbered warning that does not seem to be right.
13686 (MAXPATHLEN): Define only if needed.
13688 * process.c (serial_open, serial_configure): Move decls from here ...
13689 * systty.h: ... to here, so that they can be checked.
13691 * fns.c (get_random, seed_random): Move extern decls from here ...
13692 * lisp.h: ... to here, so that they can be checked.
13694 * sysdep.c (reset_io): Now static.
13695 (wait_for_termination_signal): Remove; unused.
13697 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13698 (copy_keymap_item, append_key, push_text_char_description):
13700 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
13701 (DENSE_TABLE_SIZE): Remove; unused.
13702 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13703 (describe_map_tree):
13704 Rename locals to avoid shadowing.
13706 * keyboard.c: Declare functions static if they are not used elsewhere.
13707 (echo_char, echo_dash, cmd_error, top_level_2):
13708 (poll_for_input, handle_async_input): Now static.
13709 (read_char, kbd_buffer_get_event, make_lispy_position):
13710 (make_lispy_event, make_lispy_movement, apply_modifiers):
13711 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13712 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13713 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
13714 (read_key_sequence, read_char): Mark locals as initialized.
13715 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
13717 * keyboard.h (make_ctrl_char): New decl.
13718 (mark_kboards): Move decl here ...
13719 * alloc.c (mark_kboards): ... from here.
13721 * lisp.h (force_auto_save_soon): New decl.
13723 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
13724 (DEFINE_DUMMY_FUNCTION): New macro.
13725 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13727 (main): Add casts to avoid warnings
13728 if GCC considers string literals to be constants.
13730 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13732 * dbusbind.c: Pointer signedness fixes.
13733 (xd_signature, xd_append_arg, xd_initialize):
13734 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13735 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13736 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13737 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13739 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13740 if GCC considers string literals to be constants.
13741 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
13743 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13745 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13746 (print_preprocess, print_object): New macro to fix last change.
13748 * print.c (print_preprocess): Don't forget font objects.
13750 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
13752 * emacs.c (USAGE3): Doc fixes.
13754 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13756 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13759 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
13761 * lisp.h (VWindow_system, Qfile_name_history):
13762 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13763 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13764 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13766 * w32select.c: Don't #include "keyboard.h".
13767 (run_protected): Add extern declaration for waiting_for_input.
13769 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13770 * w32console.c (detect_input_pending, read_input_pending)
13771 (encode_terminal_code):
13772 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13773 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13774 (w32_system_caret_y, Qfile_name_history):
13775 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13776 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13777 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13778 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13779 * w32proc.c (Qlocal, report_file_error):
13780 * w32term.c (Vwindow_system, updating_frame):
13781 * w32uniscribe.c (initialized, uniscribe_font_driver):
13782 Remove unneeded extern declarations.
13784 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
13786 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
13788 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
13790 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13791 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13792 These macros can no longer be used for assignment.
13794 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13795 Assign struct members directly, instead of using BUF_BEGV etc.
13796 (record_buffer_markers, fetch_buffer_markers): New functions for
13797 recording and fetching special buffer markers.
13798 (set_buffer_internal_1, set_buffer_temp): Use them.
13800 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13802 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13804 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13805 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13807 * xdisp.c (hscroll_window_tree):
13808 (reconsider_clip_changes): Use PT instead of BUF_PT.
13810 2011-03-13 Eli Zaretskii <eliz@gnu.org>
13812 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13813 $(EMACS_ROOT)/lib/intprops.h.
13815 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13817 Fix more problems found by GCC 4.5.2's static checks.
13819 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13820 to unsigned char * to avoid compiler diagnostic.
13821 (xg_free_frame_widgets): Make it clear that a local variable is
13822 needed only if USE_GTK_TOOLTIP.
13823 (gdk_window_get_screen): Make it clear that this macro is needed
13824 only if USE_GTK_TOOLTIP.
13825 (int_gtk_range_get_value): New function, which avoids a diagnostic
13826 from gcc -Wbad-function-cast.
13827 (xg_set_toolkit_scroll_bar_thumb): Use it.
13828 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13829 diagnostic from gcc -Wbad-function-cast.
13830 (get_utf8_string, xg_get_file_with_chooser):
13831 Rename locals to avoid shadowing.
13832 (create_dialog): Move locals to avoid shadowing.
13834 * xgselect.c (xg_select): Remove unused var.
13836 * image.c (four_corners_best): Mark locals as initialized.
13837 (gif_load): Initialize transparent_p to zero (Bug#8238).
13838 Mark another local as initialized.
13839 (my_png_error, my_error_exit): Mark with NO_RETURN.
13841 * image.c (clear_image_cache): Now static.
13842 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
13843 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
13844 (x_edge_detection): Remove unnecessary cast that
13845 gcc -Wbad-function-cast diagnoses.
13846 (gif_load): Fix pointer signedness.
13847 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13848 (jpeg_load, gif_load): Rename locals to avoid shadowing.
13850 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
13852 Improve quality of tests for time stamp overflow.
13853 For example, without this patch (encode-time 0 0 0 1 1
13854 1152921504606846976) returns the obviously-bogus value (-948597
13855 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13856 reports time overflow. See
13857 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
13858 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13859 * editfns.c: Include limits.h and intprops.h.
13860 (TIME_T_MIN, TIME_T_MAX): New macros.
13861 (time_overflow): Move earlier, to before first use.
13862 (hi_time, lo_time): New functions, for an accurate test for
13863 out-of-range times.
13864 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13865 (Fget_internal_run_time): Don't assume time_t fits in int.
13866 (make_time): Use list2 instead of Fcons twice.
13867 (Fdecode_time): More accurate test for out-of-range times.
13868 (check_tm_member): New function.
13869 (Fencode_time): Use it, to test for out-of-range times.
13870 (lisp_time_argument): Don't rely on undefined left-shift and
13871 right-shift behavior when checking for time stamp overflow.
13873 * editfns.c (time_overflow): New function, refactoring common code.
13874 (Fformat_time_string, Fdecode_time, Fencode_time):
13875 (Fcurrent_time_string): Use it.
13877 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13878 * dired.c (make_time): Move to ...
13879 * editfns.c (make_time): ... here.
13880 * systime.h: Note the move.
13882 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13884 * fringe.c (update_window_fringes): Remove unused variables.
13886 * unexmacosx.c (copy_data_segment): Also copy __got section.
13889 2011-03-12 Eli Zaretskii <eliz@gnu.org>
13891 * termcap.c [MSDOS]: Include "msdos.h".
13892 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13893 Constify `char *' arguments and their references according to
13894 prototypes in tparam.h.
13896 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
13898 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13899 Adapt all references accordingly.
13901 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13903 2011-03-11 Tom Tromey <tromey@redhat.com>
13905 * buffer.c (syms_of_buffer): Remove obsolete comment.
13907 2011-03-11 Eli Zaretskii <eliz@gnu.org>
13909 * termhooks.h (encode_terminal_code): Declare prototype.
13911 * msdos.c (encode_terminal_code): Don't declare prototype.
13913 * term.c (encode_terminal_code): Now external again, used by
13914 w32console.c and msdos.c.
13916 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13917 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
13919 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
13921 Fix some minor problems found by GCC 4.5.2's static checks.
13923 * fringe.c (update_window_fringes): Mark locals as initialized
13925 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
13927 * alloc.c (mark_fringe_data): Move decl from here ...
13928 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13929 to check its interface.
13930 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13932 * fontset.c (free_realized_fontset): Now static.
13933 (Fset_fontset_font): Rename local to avoid shadowing.
13934 (fontset_font): Mark local as initialized.
13935 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
13937 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13939 * xselect.c (x_disown_buffer_selections): Remove; not used.
13940 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
13941 (x_own_selection, Fx_disown_selection_internal): Rename locals
13942 to avoid shadowing.
13943 (x_handle_dnd_message): Remove local to avoid shadowing.
13945 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13946 so that the caller can use some name other than gcpro1.
13947 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
13948 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13949 (Fx_backspace_delete_keys_p):
13950 Use them to avoid shadowing, and rename vars to avoid shadowing.
13951 (x_decode_color, x_set_name, x_window): Now static.
13952 (Fx_create_frame): Add braces to silence GCC warning.
13953 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
13954 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13955 Remove unused locals.
13956 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13957 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13958 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13961 * xterm.h (x_mouse_leave): New decl.
13963 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13964 Remove unused functions.
13965 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13966 (x_calc_absolute_position): Now static.
13967 (XTread_socket): Don't define label "out" unless it's used.
13968 Don't declare local "event" unless it's used.
13969 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13970 unless they are used.
13971 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13972 (x_fatal_error_signal): Remove; not used.
13973 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13974 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13975 (x_error_catcher, x_connection_closed, x_error_handler):
13976 (x_error_quitter, xembed_send_message, x_iconify_frame):
13977 (my_log_handler): Rename locals to avoid shadowing.
13978 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
13979 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
13981 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13982 Rename or move locals to avoid shadowing.
13983 (tty_defined_color, merge_face_heights): Now static.
13984 (free_realized_faces_for_fontset): Remove; not used.
13985 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13986 does not deduce is never used uninitialized.
13987 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13988 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
13990 * terminal.c (store_terminal_param): Now static.
13992 * xmenu.c (menu_highlight_callback): Now static.
13993 (set_frame_menubar): Remove unused local.
13994 (xmenu_show): Rename parameter to avoid shadowing.
13995 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13996 since they might point to immutable storage.
13997 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13998 since it's unused otherwise.
14000 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
14001 Add a FIXME, since the code still doesn't look right. (Bug#8215)
14002 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14003 avoids a gcc -Wuninitialized diagnostic.
14004 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
14005 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14006 does not deduce are never used uninitialized.
14008 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14010 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
14011 * window.c (window_loop, size_window):
14012 (run_window_configuration_change_hook, enlarge_window): Likewise.
14014 * window.c (display_buffer): Now static.
14015 (size_window): Mark variables that gcc -Wuninitialized
14016 does not deduce are never used uninitialized.
14017 * window.h (check_all_windows): New decl, to forestall
14018 gcc -Wmissing-prototypes diagnostic.
14019 * dispextern.h (bidi_dump_cached_states): Likewise.
14021 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14023 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
14024 Include <limits.h>.
14025 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14026 and to avoid gcc -Wuninitialized warning.
14027 (load_charset_map): Mark variables that gcc -Wuninitialized
14028 does not deduce are never used uninitialized.
14029 (load_charset): Abort instead of using uninitialized var (Bug#8229).
14031 * coding.c (coding_set_source, coding_set_destination):
14032 Use "else { /* comment */ }" rather than "else /* comment */;"
14033 for clarity, and to avoid gcc -Wempty-body warning.
14034 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14035 a block, when the outer 'i' will do.
14036 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14037 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14038 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14039 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14040 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14041 Rename locals to avoid shadowing.
14042 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
14043 * coding.c (emacs_mule_char, encode_invocation_designation):
14044 Now static, since they're not used elsewhere.
14045 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
14046 (decode_coding_object, encode_coding_object, detect_coding_system):
14047 (decode_coding_emacs_mule): Mark variables that gcc
14048 -Wuninitialized does not deduce are never used uninitialized.
14049 (detect_coding_iso_2022): Initialize a local variable that might
14050 be used uninitialized. Leave a FIXME because it's not clear that
14051 this initialization is needed. (Bug#8211)
14052 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14053 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14054 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14055 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14056 Remove unused macros.
14058 * category.c (hash_get_category_set): Remove unused local var.
14059 (copy_category_table): Now static, since it's not used elsewhere.
14060 * character.c (string_count_byte8): Likewise.
14062 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14063 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14065 * chartab.c (copy_sub_char_table): Now static, since it's not used
14067 (sub_char_table_ref_and_range, char_table_ref_and_range):
14068 Rename locals to avoid shadowing.
14069 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
14071 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
14072 (BIDI_BOB): Remove unused macro.
14074 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14075 deduce are never used uninitialized.
14076 * term.c (encode_terminal_code): Likewise.
14078 * term.c (encode_terminal_code): Now static. Remove unused local.
14080 * tparam.h: New file.
14081 * term.c, tparam.h: Include it.
14082 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14083 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14084 Move these decls to tparam.h, and make them agree with what
14085 is actually in tparam.c. The previous trick of using incompatible
14086 decls in different modules does not conform to the C standard.
14087 All callers of tparam changed to use tparam's actual API.
14088 * tparam.c (tparam1, tparam, tgoto):
14089 Use const pointers where appropriate.
14091 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14092 * cm.h (struct cm): Likewise.
14093 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14094 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14095 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14096 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14097 (turn_on_face, init_tty): Likewise.
14098 * termchar.h (struct tty_display_info): Likewise.
14100 * term.c (term_mouse_position): Rename local to avoid shadowing.
14102 * alloc.c (mark_ttys): Move decl from here ...
14103 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14105 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14107 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14109 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
14111 * search.c (compile_pattern_1): Remove argument regp, unused since
14112 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14113 (compile_pattern): Don't pass it.
14115 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14117 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14118 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14120 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14122 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14124 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14125 gdk_window_get_screen, gdk_window_get_geometry,
14126 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14127 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14128 (xg_get_pixbuf_from_pixmap): New function.
14129 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14130 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14131 Call xg_get_pixbuf_from_pixmap instead of
14132 gdk_pixbuf_get_from_drawable.
14133 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14134 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14135 (xg_check_special_colors): Use GtkStyleContext and its functions
14137 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14138 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14139 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
14140 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14141 Call gtk_widget_get_preferred_size.
14142 (xg_frame_resized): gdk_window_get_geometry only takes 5
14144 (xg_win_to_widget, xg_event_is_for_menubar):
14145 Call gdk_x11_window_lookup_for_display.
14146 (xg_set_widget_bg): New function.
14147 (delete_cb): New function.
14148 (xg_create_frame_widgets): Connect delete-event to delete_cb.
14149 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
14150 (xg_set_background_color): Call xg_set_widget_bg.
14151 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14152 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14153 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14154 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14156 (update_frame_tool_bar): Call gtk_widget_hide.
14157 (xg_initialize): Use GDK_KEY_g.
14159 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14161 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14163 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14164 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14165 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14167 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
14169 * w32xfns.c (select_palette): Check success of RealizePalette against
14170 GDI_ERROR, not zero.
14172 See ChangeLog.11 for earlier changes.
14174 ;; Local Variables:
14178 Copyright (C) 2011-2012 Free Software Foundation, Inc.
14180 This file is part of GNU Emacs.
14182 GNU Emacs is free software: you can redistribute it and/or modify
14183 it under the terms of the GNU General Public License as published by
14184 the Free Software Foundation, either version 3 of the License, or
14185 (at your option) any later version.
14187 GNU Emacs is distributed in the hope that it will be useful,
14188 but WITHOUT ANY WARRANTY; without even the implied warranty of
14189 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14190 GNU General Public License for more details.
14192 You should have received a copy of the GNU General Public License
14193 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.