src/keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
[bpt/emacs.git] / src / ChangeLog
1 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2
3 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4
5 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6
7 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
8 supposed to be handshaking.
9 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10
11 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
12
13 * lisp.h (Qdebug): List symbol.
14 * eval.c (Qdebug): Restore global linkage.
15 * keyboard.c (debug-on-event): New variable.
16 (handle_user_signal): Break into debugger when debug-on-event
17 matches the current signal symbol.
18
19 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
20
21 * alloc.c (check_sblock, check_string_bytes)
22 (check_string_free_list): Convert to standard C.
23
24 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
25
26 * w32.c (emacs_gnutls_push): Fix typo.
27
28 2011-04-25 Eli Zaretskii <eliz@gnu.org>
29
30 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
31 "cast to pointer from integer of different size".
32
33 Improve doprnt and its use in verror. (Bug#8545)
34 * doprnt.c (doprnt): Document the set of format control sequences
35 supported by the function. Use SAFE_ALLOCA instead of always
36 using `alloca'.
37
38 * eval.c (verror): Don't limit the buffer size at size_max-1, that
39 is one byte too soon. Don't use xrealloc; instead xfree and
40 xmalloc anew.
41
42 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
43
44 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
45 callbacks stage.
46
47 * gnutls.c: Renamed global_initialized to
48 gnutls_global_initialized. Added internals for the
49 :verify-hostname-error, :verify-error, and :verify-flags
50 parameters of `gnutls-boot' and documented those parameters in the
51 docstring. Start callback support.
52 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
53 unless a fatal error occured. Call gnutls_alert_send_appropriate
54 on error. Return error code.
55 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
56 (emacs_gnutls_read): Likewise.
57 (Fgnutls_boot): Return handshake error code.
58 (emacs_gnutls_handle_error): New function.
59 (wsaerror_to_errno): Likewise.
60
61 * w32.h (emacs_gnutls_pull): Add prototype.
62 (emacs_gnutls_push): Likewise.
63
64 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
65 (emacs_gnutls_push): Likewise.
66
67 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
68
69 * process.c (wait_reading_process_output): Check if GnuTLS
70 buffered some data internally if no FDs are set for TLS
71 connections.
72
73 * makefile.w32-in (OBJ2): Add gnutls.$(O).
74 (LIBS): Link to USER_LIBS.
75 ($(BLD)/gnutls.$(0)): New target.
76
77 2011-04-24 Eli Zaretskii <eliz@gnu.org>
78
79 * xdisp.c (handle_single_display_spec): Rename the
80 display_replaced_before_p argument into display_replaced_p, to
81 make it consistent with the commentary. Fix typos in the
82 commentary.
83
84 * textprop.c (syms_of_textprop): Remove dead code.
85 (copy_text_properties): Delete obsolete commentary about an
86 interface that was deleted long ago. Fix typos in the description
87 of arguments.
88
89 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
90 to changes in oldXMenu/XMenu.h from 2011-04-16.
91 <menu_help_message, prev_menu_help_message>: Constify.
92 (IT_menu_make_room): menu->help_text is now `const char **';
93 adjust.
94
95 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
96 to changes in oldXMenu/XMenu.h from 2011-04-16.
97 (struct XMenu): Declare `help_text' `const char **'.
98
99 * xfaces.c <Qunspecified>: Make extern again.
100
101 * syntax.c: Include sys/types.h before including regex.h, as
102 required by Posix.
103
104 * doc.c (get_doc_string): Improve the format passed to `error'.
105
106 * doprnt.c (doprnt): Improve commentary.
107
108 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
109
110 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
111 them with etags.
112
113 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
114 changes in globals.h immediately force recompilation.
115 (TAGS): Depend on $(CURDIR)/m/intel386.h and
116 $(CURDIR)/s/ms-w32.h.
117 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
118
119 * character.c (Fchar_direction): Function deleted.
120 (syms_of_character): Don't defsubr it.
121 <char-direction-table>: Deleted.
122
123 2011-04-23 Eli Zaretskii <eliz@gnu.org>
124
125 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
126 * doprnt.c: Include limits.h.
127 (SIZE_MAX): New macro.
128 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
129 local variables are now size_t instead of int or unsigned.
130 Improve overflow protection. Support `l' modifier for integer
131 conversions. Support %l conversion. Don't assume an EMACS_INT
132 argument for integer conversions and for %c.
133
134 * lisp.h (doprnt): Restore prototype.
135
136 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
137 $(SRC)/character.h.
138
139 * Makefile.in (base_obj): Add back doprnt.o.
140
141 * deps.mk (doprnt.o): Add back prerequisites.
142 (callint.o): Depend on character.h.
143
144 * eval.c (internal_lisp_condition_case): Include the handler
145 representation in the error message.
146 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
147 when breaking from the loop.
148
149 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
150
151 * callint.c (Fcall_interactively): When displaying error message
152 about invalid control letter, pass the character's codepoint, not
153 a pointer to its multibyte form. Improve display of the character
154 in octal and display also its hex code.
155
156 * character.c (char_string): Use %x to display the (unsigned)
157 codepoint of an invalid character, to avoid displaying a bogus
158 negative value.
159
160 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
161 `error', not SYMBOL_NAME itself.
162
163 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
164 character arguments to `error'.
165
166 * charset.c (check_iso_charset_parameter): Fix incorrect argument
167 to `error' in error message about FINAL_CHAR argument. Make sure
168 FINAL_CHAR is a character, and use %c when it is passed as
169 argument to `error'.
170
171 2011-04-23 Eli Zaretskii <eliz@gnu.org>
172
173 * s/ms-w32.h (localtime): Redirect to sys_localtime.
174
175 * w32.c: Include <time.h>.
176 (sys_localtime): New function.
177
178 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
179
180 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
181
182 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
183
184 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
185
186 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
187 zombies (Bug#8467).
188
189 2011-04-19 Eli Zaretskii <eliz@gnu.org>
190
191 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
192 gl_state.e_property when gl_state.object is Qt.
193
194 * insdel.c (make_gap_larger): Remove limitation of buffer size
195 to <= INT_MAX.
196
197 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
198
199 * xdisp.c (lookup_glyphless_char_display)
200 (produce_glyphless_glyph): Handle cons cell entry in
201 glyphless-char-display.
202 (Vglyphless_char_display): Document it.
203
204 * term.c (produce_glyphless_glyph): Handle cons cell entry in
205 glyphless-char-display.
206
207 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
208
209 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
210
211 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
212
213 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
214 definition for no-X builds.
215
216 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
217
218 Static checks with GCC 4.6.0 and non-default toolkits.
219
220 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
221
222 * process.c (keyboard_bit_set): Define only if SIGIO.
223 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
224 (send_process): Repair possible setjmp clobbering.
225
226 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
227
228 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
229
230 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
231
232 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
233 Define only if needed.
234
235 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
236 by pacifying GCC about it. Maybe it's time to retire it?
237 * xfaces.c (USG, __TIMEVAL__): Likewise.
238
239 * dispextern.h (struct redisplay_interface): Rename param
240 to avoid shadowing.
241 * termhooks.h (struct terminal): Likewise.
242 * xterm.c (xembed_send_message): Likewise.
243
244 * insdel.c (make_gap_smaller): Define only if
245 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
246
247 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
248 it.
249
250 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
251 so that we aren't warned about unused symbols.
252
253 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
254
255 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
256
257 * xfns.c (x_real_positions): Mark locals as initialized.
258
259 * xmenu.c (xmenu_show): Don't use uninitialized vars.
260
261 * xterm.c: Fix problems found by static analysis with other toolkits.
262 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
263 (x_dispatch_event): Declare static if USE_GTK, and
264 define if USE_GTK || USE_X_TOOLKIT.
265 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
266 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
267 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
268 defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
269
270 * xmenu.c (menu_help_callback): Pointer type fixes.
271 Use const pointers when pointing at readonly data. Avoid pointer
272 signedness clashes.
273 (FALSE): Remove unused macro.
274 (update_frame_menubar): Remove unused decl.
275
276 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
277
278 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
279 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
280 (single_menu_item): Rename local to avoid shadowing.
281
282 * keyboard.c (make_lispy_event): Remove unused local var.
283
284 * frame.c, frame.h (x_get_resource_string): Bring this back, but
285 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
286
287 * bitmaps: Change bitmaps from unsigned char back to the X11
288 compatible char. Avoid the old compiler warnings about
289 out-of-range initializers by using, for example, '\xab' rather
290 than 0xab.
291
292 * xgselect.c (xgselect_initialize): Check vs interface
293 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
294
295 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
296
297 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
298 to read-only memory.
299
300 * fns.c (vector): Remove; this old hack is no longer needed.
301
302 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
303 Remove unused var.
304 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
305
306 * xrdb.c (x_load_resources): Omit unused local.
307
308 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
309 (x_window): Rename locals to avoid shadowing.
310 (USG): Use the kludged USG macro, to pacify gcc.
311
312 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
313 (x_term_init): Remove local to avoid shadowing.
314
315 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
316
317 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
318 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
319
320 2011-04-16 Eli Zaretskii <eliz@gnu.org>
321
322 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
323
324 Fix regex.c, syntax.c and friends for buffers > 2GB.
325 * syntax.h (struct gl_state_s): Declare character position members
326 EMACS_INT.
327
328 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
329
330 * textprop.c (verify_interval_modification, interval_of): Declare
331 arguments EMACS_INT.
332
333 * intervals.c (adjust_intervals_for_insertion): Declare arguments
334 EMACS_INT.
335
336 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
337
338 * indent.c (Fvertical_motion): Local variable it_start is now
339 EMACS_INT.
340
341 * regex.c (re_match, re_match_2, re_match_2_internal)
342 (bcmp_translate, regcomp, regexec, print_double_string)
343 (group_in_compile_stack, re_search, re_search_2, regex_compile)
344 (re_compile_pattern, re_exec): Declare arguments and local
345 variables `size_t' and `ssize_t' and return values `regoff_t', as
346 appropriate.
347 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
348 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
349 <compile_stack_type>: `size' and `avail' are now `size_t'.
350
351 * regex.h <regoff_t>: Use ssize_t, not int.
352 (re_search, re_search_2, re_match, re_match_2): Arguments that
353 specify buffer/string position and length are now ssize_t and
354 size_t. Return type is regoff_t.
355
356 2011-04-16 Ben Key <bkey76@gmail.com>
357
358 * nsfont.m: Fixed bugs in ns_get_family and
359 ns_descriptor_to_entity that were caused by using free to
360 deallocate memory blocks that were allocated by xmalloc (via
361 xstrdup). This caused Emacs to crash when compiled with
362 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
363 --enable-checking=xmallocoverrun). xfree is now used to
364 deallocate these memory blocks.
365
366 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
367
368 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
369
370 emacs_write: Accept and return EMACS_INT for sizes.
371 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
372 et seq.
373 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
374 Accept and return EMACS_INT.
375 (emacs_gnutls_write): Return the number of bytes written on
376 partial writes.
377 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
378 (emacs_read, emacs_write): Remove check for negative size, as the
379 Emacs source code has been audited now.
380 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
381 (emacs_read, emacs_write): Use it.
382 * process.c (send_process): Adjust to the new signatures of
383 emacs_write and emacs_gnutls_write. Do not attempt to store
384 a byte offset into an 'int'; it might overflow.
385 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
386
387 * sound.c: Don't assume sizes fit in 'int'.
388 (struct sound_device.period_size, alsa_period_size):
389 Return EMACS_INT, not int.
390 (struct sound_device.write, vox_write, alsa_write):
391 Accept EMACS_INT, not int.
392 (wav_play, au_play): Use EMACS_INT to store sizes and to
393 record read return values.
394
395 2011-04-15 Ben Key <bkey76@gmail.com>
396
397 * keyboard.c (Qundefined): Don't declare static since it is used
398 in nsfns.m.
399 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
400 static since they are used in nsfont.m.
401
402 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
403
404 * process.c (Qprocessp): Don't declare static.
405 * lisp.h (Qprocessp): Declare again.
406
407 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
408
409 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
410
411 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
412
413 Improve C-level modularity by making more things 'static'.
414
415 Don't publish debugger-only interfaces to other modules.
416 * lisp.h (safe_debug_print, debug_output_compilation_hack):
417 (verify_bytepos, count_markers): Move decls to the only modules
418 that need them.
419 * region-cache.h (pp_cache): Likewise.
420 * window.h (check_all_windows): Likewise.
421 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
422
423 * sysdep.c (croak): Now static, if
424 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
425 * syssignal.h (croak): Declare only if not static.
426
427 * alloc.c (refill_memory_reserve): Now static if
428 !defined REL_ALLOC || defined SYSTEM_MALLOC.
429 * lisp.h (refill_memory_reserve): Declare only if not static.
430
431 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
432 Define only if USE_LUCID.
433
434 * xrdb.c (x_customization_string, x_rm_string): Now static.
435
436 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
437 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
438
439 * xdisp.c (draw_row_with_mouse_face): Now static.
440 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
441
442 * window.h (check_all_windows): Mark externally visible.
443
444 * window.c (window_deletion_count): Now static.
445
446 * undo.c: Make symbols static if they're not exported.
447 (last_undo_buffer, last_boundary_position, pending_boundary):
448 Now static.
449
450 * textprop.c (interval_insert_behind_hooks): Now static.
451 (interval_insert_in_front_hooks): Likewise.
452
453 * term.c: Make symbols static if they're not exported.
454 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
455 (max_frame_lines, tty_set_terminal_modes):
456 (tty_reset_terminal_modes, tty_turn_off_highlight):
457 (get_tty_terminal): Now static.
458 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
459 * termhooks.h (term_mouse_moveto): Do not declare if
460 HAVE_WINDOW_SYSTEM.
461 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
462 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
463
464 * sysdep.c: Make symbols static if they're not exported.
465 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
466 Now static.
467 (sigprocmask_set, full_mask): Remove; unused.
468 (wait_debugging): Mark as visible.
469 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
470 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
471
472 * syntax.c (syntax_temp): Define only if !__GNUC__.
473
474 * sound.c (current_sound_device, current_sound): Now static.
475
476 * search.c (searchbufs, searchbuf_head): Now static.
477
478 * scroll.c (scroll_cost): Remove; unused.
479 * dispextern.h (scroll_cost): Remove decl.
480
481 * region-cache.h (pp_cache): Mark as externally visible.
482
483 * process.c: Make symbols static if they're not exported.
484 (process_tick, update_tick, create_process, chan_process):
485 (Vprocess_alist, proc_buffered_char, datagram_access):
486 (fd_callback_data, send_process_frame, process_sent_to): Now static.
487 (deactivate_process): Mark defn as static, as well as decl.
488 * lisp.h (create_process): Remove decl.
489 * process.h (chan_process, Vprocess_alist): Remove decls.
490
491 * print.c: Make symbols static if they're not exported.
492 (print_depth, new_backquote_output, being_printed, print_buffer):
493 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
494 (print_interval, print_number_index, initial_stderr_stream):
495 Now static.
496 * lisp.h (Fprinc): Remove decl.
497 (debug_output_compilation_hack): Mark as externally visible.
498
499 * sysdep.c (croak): Move decl from here to syssignal.h.
500 * syssignal.h (croak): Put it here, so the API can be checked when
501 'croak' is called from dissociate_if_controlling_tty.
502
503 * minibuf.c: Make symbols static if they're not exported.
504 (minibuf_save_list, choose_minibuf_frame): Now static.
505 * lisp.h (choose_minibuf_frame): Remove decl.
506
507 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
508
509 * lread.c: Make symbols static if they're not exported.
510 (read_objects, initial_obarray, oblookup_last_bucket_number):
511 Now static.
512 (make_symbol): Remove; unused.
513 * lisp.h (initial_obarray, make_symbol): Remove decls.
514
515 * keyboard.c: Make symbols static if they're not exported.
516 (single_kboard, recent_keys_index, total_keys, recent_keys):
517 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
518 (this_single_command_key_start, echoing, last_auto_save):
519 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
520 (command_loop, echo_now, keyboard_init_hook, help_char_p):
521 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
522 (Vlispy_mouse_stem, double_click_count):
523 Now static.
524 (force_auto_save_soon): Define only if SIGDANGER.
525 (ignore_mouse_drag_p): Now static if
526 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
527 (print_help): Remove; unused.
528 (stop_character, last_timer_event): Mark as externally visible.
529 * keyboard.h (ignore_mouse_drag_p): Declare only if
530 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
531 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
532 * lisp.h (echoing): Remove decl.
533 (force_auto_save_soon): Declare only if SIGDANGER.
534 * xdisp.c (redisplay_window): Simplify code, to make it more
535 obvious that ignore_mouse_drag_p is not accessed if !defined
536 USE_GTK && !defined HAVE_NS.
537
538 * intervals.c: Make symbols static if they're not exported.
539 (merge_properties_sticky, merge_interval_right, delete_interval):
540 Now static.
541 * intervals.h (merge_interval_right, delete_interval): Remove decls.
542
543 * insdel.c: Make symbols static if they're not exported.
544 However, leave prepare_to_modify_buffer alone. It's never
545 called from outside this function, but that appears to be a bug.
546 (combine_after_change_list, combine_after_change_buffer):
547 (adjust_after_replace, signal_before_change): Now static.
548 (adjust_after_replace_noundo): Remove; unused.
549 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
550 (signal_before_change): Remove decls.
551
552 * indent.c (val_compute_motion, val_vmotion): Now static.
553
554 * image.c: Make symbols static if they're not exported.
555 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
556 if USE_GTK.
557 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
558 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
559
560 * fringe.c (standard_bitmaps): Now static.
561 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
562
563 * frame.c: Make symbols static if they're not exported.
564 (x_report_frame_params, make_terminal_frame): Now static.
565 (get_frame_param): Now static, unless HAVE_NS.
566 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
567 (x_get_resource_string): Remove; not used.
568 * frame.h (make_terminal_frame, x_report_frame_params):
569 (x_get_resource_string); Remove decls.
570 (x_fullscreen_adjust): Declare only if WINDOWSNT.
571 * lisp.h (get_frame_param): Declare only if HAVE_NS.
572
573 * font.c, fontset.c: Make symbols static if they're not exported.
574 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
575 (FACE_SUITABLE_FOR_CHAR_P): Use it.
576 * font.c (font_close_object): Now static.
577 * font.h (font_close_object): Remove.
578 * fontset.c (FONTSET_OBJLIST): Remove.
579 (free_realized_fontset) #if-0 the body, which does nothing.
580 (face_suitable_for_char_p): #if-0, as it's never called.
581 * fontset.h (face_suitable_for_char_p): Remove decl.
582 * xfaces.c (face_at_string_position): Use
583 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
584 since 0 is always ASCII.
585
586 * fns.c (weak_hash_tables): Now static.
587
588 * fileio.c: Make symbols static if they're not exported.
589 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
590 (Vwrite_region_annotation_buffers): Now static.
591
592 * eval.c: Make symbols static if they're not exported.
593 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
594 * lisp.h (backtrace_list): Remove decl.
595
596 * emacs.c: Make symbols static if they're not exported.
597 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
598 (fatal_error_code, fatal_error_signal_hook, standard_args):
599 Now static.
600 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
601 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
602 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
603 * lisp.h (fatal_error_signal_hook): Remove decl.
604 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
605
606 * editfns.c: Move a (normally-unused) function to its only use.
607 * editfns.c, lisp.h (get_operating_system_release): Remove.
608 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
609 worth the hassle of breaking this out.
610
611 * xterm.c: Make symbols static if they're not exported.
612 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
613 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
614 (x_destroy_window, x_delete_display):
615 Now static.
616 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
617 (x_mouse_leave): Remove; unused.
618 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
619 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
620 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
621 Remove decls.
622 (x_mouse_leave): Declare only if WINDOWSNT.
623 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
624 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
625 USE_X_TOOLKIT.
626
627 * ftxfont.c: Make symbols static if they're not exported.
628 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
629 HAVE_FREETYPE.
630 * font.h (ftxfont_driver): Likewise.
631
632 * xfns.c: Make symbols static if they're not exported.
633 (x_last_font_name, x_display_info_for_name):
634 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
635 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
636 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
637 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
638 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
639 (last_show_tip_args): Now static.
640 (xic_defaut_fontset, xic_create_fontsetname): Define only if
641 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
642 (x_screen_planes): Remove; unused.
643 * dispextern.h (x_screen_planes): Remove decl.
644
645 * dispnew.c: Make symbols static if they're not exported.
646 * dispextern.h (redraw_garbaged_frames, scrolling):
647 (increment_row_positions): Remove.
648 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
649 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
650 Now static.
651 (redraw_garbaged_frames): Remove; unused.
652
653 * xfaces.c: Make symbols static if they're not exported.
654 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
655 Remove decls.
656 * xterm.h (defined_color): Remove decls.
657 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
658 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
659 (menu_face_changed_default, defined_color, free_realized_face):
660 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
661 (ascii_face_of_lisp_face): Remove; unused.
662
663 * xdisp.c: Make symbols static if they're not exported.
664 * dispextern.h (scratch_glyph_row, window_box_edges):
665 (glyph_to_pixel_coords, set_cursor_from_row):
666 (get_next_display_element, set_iterator_to_next):
667 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
668 (show_mouse_face): Remove decls
669 * frame.h (message_buf_print): Likewise.
670 * lisp.h (pop_message, set_message, check_point_in_composition):
671 Likewise.
672 * xterm.h (set_vertical_scroll_bar): Likewise.
673 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
674 (message_buf_print, scratch_glyph_row, displayed_buffer):
675 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
676 (get_next_display_element, show_mouse_face, window_box_edges):
677 (frame_to_window_pixel_xy, check_point_in_composition):
678 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
679 (glyph_to_pixel_coords): Remove; unused.
680
681 * dired.c (file_name_completion): Now static.
682
683 * dbusbind.c (xd_in_read_queued_messages): Now static.
684
685 * lisp.h (circular_list_error, FOREACH): Remove; unused.
686 * data.c (circular_list_error): Remove.
687
688 * commands.h (last_point_position, last_point_position_buffer):
689 (last_point_position_window): Remove decls.
690 * keyboard.c: Make these variables static.
691
692 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
693 decls.
694 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
695 (iso_code_class, detect_coding, code_convert_region): Now static.
696 (encode_coding_gap): Remove; unused.
697
698 * chartab.c (chartab_chars, chartab_bits): Now static.
699
700 * charset.h (charset_iso_8859_1): Remove decl.
701 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
702 Now static.
703
704 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
705 * ccl.c (Vccl_program_table): Now static.
706 (check_ccl_update): Remove; unused.
707
708 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
709 * category.h: ... from here.
710 * category.c (check_category_table, set_category_set): Now static.
711
712 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
713 * lisp.h: Remove these decls.
714
715 * buffer.c (buffer_count): Remove unused var.
716
717 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
718 so that it's not optimized away.
719 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
720 * dispextern.h (bidi_dump_cached_states): Remove, since it's
721 exported only to the debugger.
722
723 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
724 * atimer.h (run_all_atimers): Removed; not exported.
725
726 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
727 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
728 was inaccessible from Lisp.
729 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
730 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
731
732 alloc.c: Import and export fewer symbols, and remove unused items.
733 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
734 is defined.
735 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
736 it's not optimized away by whole-program optimization.
737 (message_enable_multibyte, free_misc): Remove.
738 (catchlist, handlerlist, mark_backtrace):
739 Declare only if BYTE_MARK_STACK.
740 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
741 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
742 (message_enable_multibyte): Remove decl.
743 (free_misc, interval_free_list, float_block, float_block_index):
744 (n_float_blocks, float_free_list, cons_block, cons_block_index):
745 (cons_free_list, last_marked_index):
746 Now static.
747 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
748 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
749 (mark_backtrace): Define only if BYTE_MARK_STACK.
750 * xdisp.c (message_enable_multibyte): Now static.
751
752 Declare Lisp_Object Q* variables to be 'static' if not exported.
753 This makes it easier for human readers (and static analyzers)
754 to see whether these variables are used from other modules.
755 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
756 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
757 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
758 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
759 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
760 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
761 * xmenu.c, xselect.c:
762 Declare Q* vars static if they are not used in other modules.
763 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
764 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
765 Remove decls of unexported vars.
766 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
767
768 * lisp.h (DEFINE_FUNC): Make sname 'static'.
769
770 Make Emacs functions such as Fatom 'static' by default.
771 This makes it easier for human readers (and static analyzers)
772 to see whether these functions can be called from other modules.
773 DEFUN now defines a static function. To make the function external
774 so that it can be used in other C modules, use the new macro DEFUE.
775 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
776 (Finit_image_library):
777 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
778 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
779 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
780 Remove decls, since these functions are now static.
781 (Funintern, Fget_internal_run_time): New decls, since these functions
782 were already external.
783
784 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
785 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
786 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
787 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
788 * keyboard.c, keymap.c, lread.c:
789 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
790 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
791 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
792 Mark functions with DEFUE instead of DEFUN,
793 if they are used in other modules.
794 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
795 decls for now-static functions.
796 * buffer.h (Fdelete_overlay): Remove decl.
797 * callproc.c (Fgetenv_internal): Mark as internal.
798 * composite.c (Fremove_list_of_text_properties): Remove decl.
799 (Fcomposition_get_gstring): New forward static decl.
800 * composite.h (Fcomposite_get_gstring): Remove decl.
801 * dired.c (Ffile_attributes): New forward static decl.
802 * doc.c (Fdocumntation_property): New forward static decl.
803 * eval.c (Ffetch_bytecode): New forward static decl.
804 (Funintern): Remove extern decl; now in .h file where it belongs.
805 * fileio.c (Fmake_symbolic_link): New forward static decl.
806 * image.c (Finit_image_library): New forward static decl.
807 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
808 * intervals.h (Fprevious_property_change):
809 (Fremove_list_of_text_properties): Remove decls.
810 * keyboard.c (Fthis_command_keys): Remove decl.
811 (Fcommand_execute): New forward static decl.
812 * keymap.c (Flookup_key): New forward static decl.
813 (Fcopy_keymap): Now static.
814 * keymap.h (Flookup_key): Remove decl.
815 * process.c (Fget_process): New forward static decl.
816 (Fprocess_datagram_address): Mark as internal.
817 * syntax.c (Fsyntax_table_p): New forward static decl.
818 (skip_chars): Remove duplicate decl.
819 * textprop.c (Fprevious_property_change): New forward static decl.
820 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
821 Now internal.
822 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
823 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
824
825 * editfns.c (Fformat): Remove unreachable code.
826
827 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
828
829 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
830 change. (Bug#8496)
831
832 2011-04-13 Eli Zaretskii <eliz@gnu.org>
833
834 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
835 when at ZV. (Bug#8487)
836
837 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
838
839 * charset.c (Fclear_charset_maps): Use xfree instead of free.
840 (Bug#8437)
841 * keyboard.c (parse_tool_bar_item): Likewise.
842 * sound.c (sound_cleanup, alsa_close): Likewise.
843 * termcap.c (tgetent): Likewise.
844 * xfns.c (x_default_font_parameter): Likewise.
845 * xsettings.c (read_and_apply_settings): Likewise.
846
847 * alloc.c (overrun_check_malloc, overrun_check_realloc)
848 (overrun_check_free): Protoize.
849
850 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
851
852 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
853 since callers should never pass a negative size.
854 Change the signature to match that of plain 'read' and 'write'; see
855 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
856 * lisp.h: Update prototypes of emacs_write and emacs_read.
857
858 2011-04-11 Eli Zaretskii <eliz@gnu.org>
859
860 * xdisp.c (redisplay_window): Don't try to determine the character
861 position of the scroll margin if the window start point w->startp
862 is outside the buffer's accessible region. (Bug#8468)
863
864 2011-04-10 Eli Zaretskii <eliz@gnu.org>
865
866 Fix write-region and its subroutines for buffers > 2GB.
867 * fileio.c (a_write, e_write): Modify declaration of arguments and
868 local variables to support buffers larger than 2GB.
869 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
870
871 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
872 argument, local variables, and return value.
873
874 * lisp.h: Update prototypes of emacs_write and emacs_read.
875
876 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
877
878 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
879
880 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
881
882 Fix more problems found by GCC 4.6.0's static checks.
883
884 * xdisp.c (vmessage): Use a better test for character truncation.
885
886 * charset.c (load_charset_map): <, not <=, for optimization,
887 and to avoid potential problems with integer overflow.
888 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
889 * casetab.c (set_identity, shuffle): Likewise.
890 * editfns.c (Fformat): Likewise.
891 * syntax.c (skip_chars): Likewise.
892
893 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
894 This also lets GCC 4.6.0 generate slightly better loop code.
895
896 * callint.c (Fcall_interactively): <, not <=, for optimization.
897 (Fcall_interactively): Count the number of arguments produced,
898 not the number of arguments given. This is simpler and lets GCC
899 4.6.0 generate slightly better code.
900
901 * ftfont.c: Distingish more carefully between FcChar8 and char.
902 The previous code passed unsigned char * to a functions like
903 strlen and xstrcasecmp that expect char *, which does not
904 conform to the C standard.
905 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
906 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
907 char * when the C standard requires it.
908
909 * keyboard.c (read_char): Remove unused var.
910
911 * eval.c: Port to Windows vsnprintf (Bug#8435).
912 Include <limits.h>.
913 (SIZE_MAX): Define if the headers do not.
914 (verror): Do not give up if vsnprintf returns a negative count.
915 Instead, grow the buffer. This ports to Windows vsnprintf, which
916 does not conform to C99. Problem reported by Eli Zaretskii.
917 Also, simplify the allocation scheme, by avoiding the need for
918 calling realloc, and removing the ALLOCATED variable.
919
920 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
921
922 Remove invocations of doprnt, as Emacs now uses vsnprintf.
923 But keep the doprint source code for now, as we might revamp it
924 and use it again (Bug#8435).
925 * lisp.h (doprnt): Remove.
926 * Makefile.in (base_obj): Remove doprnt.o.
927 * deps.mk (doprnt.o): Remove.
928
929 error: Print 32- and 64-bit integers portably (Bug#8435).
930 Without this change, on typical 64-bit hosts error ("...%d...", N)
931 was used to print both 32- and 64-bit integers N, which relied on
932 undefined behavior.
933 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
934 New macro.
935 * lisp.h (error, verror): Mark as printf-like functions.
936 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
937 Report overflow in size calculations when allocating printf buffer.
938 Do not truncate output string at its first null byte.
939 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
940 Truncate the output at a character boundary, since vsnprintf does not
941 do that.
942 * charset.c (check_iso_charset_parameter): Convert internal
943 character to string before calling 'error', since %c now has the
944 printf meaning.
945 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
946 overflow when computing char to be passed to 'error'. Do not
947 pass Lisp_Object to 'error'; pass the integer instead.
948 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
949 formatted with plain %d.
950
951 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
952
953 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
954
955 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
956
957 * xterm.c (x_catch_errors): Remove duplicate declaration.
958
959 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
960
961 * xdisp.c, lisp.h (message_nolog): Remove; unused.
962
963 2011-04-10 Jim Meyering <meyering@redhat.com>
964
965 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
966 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
967 return ssize_t not "int", and use size_t as the buffer length.
968 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
969 * gnutls.h: Update declarations.
970 * process.c (read_process_output): Use ssize_t, to match.
971 (send_process): Likewise.
972
973 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
974
975 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
976
977 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
978
979 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
980 unsigned char, to match FcChar8 type definition.
981
982 * xterm.c (handle_one_xevent):
983 * xmenu.c (create_and_show_popup_menu):
984 * xselect.c (x_decline_selection_request)
985 (x_reply_selection_request): Avoid type-punned deref of X events.
986
987 2011-04-09 Eli Zaretskii <eliz@gnu.org>
988
989 Fix some uses of `int' instead of EMACS_INT.
990 * search.c (string_match_1, fast_string_match)
991 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
992 (scan_buffer, find_next_newline_no_quit)
993 (find_before_next_newline, search_command, Freplace_match)
994 (Fmatch_data): Make some `int' variables be EMACS_INT.
995
996 * xdisp.c (display_count_lines): 3rd argument and return value now
997 EMACS_INT. All callers changed.
998 (pint2hrstr): Last argument is now EMACS_INT.
999
1000 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1001 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1002 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1003 (decode_coding_utf_16, decode_coding_emacs_mule)
1004 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1005 (decode_coding_ccl, decode_coding_charset)
1006 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1007 (decode_coding_iso_2022, decode_coding_emacs_mule)
1008 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1009 <char_offset, last_offset>: Declare EMACS_INT.
1010 (encode_coding_utf_8, encode_coding_utf_16)
1011 (encode_coding_emacs_mule, encode_invocation_designation)
1012 (encode_designation_at_bol, encode_coding_iso_2022)
1013 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1014 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1015 Declare EMACS_INT.
1016 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1017 (encode_invocation_designation): Last argument P_NCHARS is now
1018 EMACS_INT.
1019 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1020 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1021
1022 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1023 All users changed.
1024
1025 * ccl.c (Fccl_execute_on_string): Declare some variables
1026 EMACS_INT.
1027
1028 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1029
1030 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1031
1032 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1033
1034 * process.c (Fformat_network_address): Doc fix.
1035
1036 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1037
1038 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1039
1040 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1041
1042 * keyboard.c (read_char): Call Lisp function help-form-show,
1043 instead of using internal_with_output_to_temp_buffer.
1044 (Qhelp_form_show): New var.
1045 (syms_of_keyboard): Use DEFSYM macro.
1046
1047 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1048
1049 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1050
1051 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1052
1053 * process.c (Flist_processes): Removed to Lisp.
1054 (list_processes_1): Deleted.
1055
1056 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1057
1058 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1059
1060 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1061
1062 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1063
1064 Fix more problems found by GCC 4.6.0's static checks.
1065
1066 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1067
1068 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1069
1070 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1071
1072 * xdisp.c (vmessage): Mark as a printf-like function.
1073
1074 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1075
1076 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1077
1078 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1079 printf-like functions.
1080 (tiff_load): Add casts to remove these marks before passing them
1081 to system-supplied API.
1082
1083 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1084
1085 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1086 This avoids several warnings with gcc -Wstrict-overflow.
1087 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1088 directly, rather than having caller test rule sign. This avoids
1089 some unnecessary tests.
1090 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1091 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1092 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1093
1094 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1095 (xfont_open): Avoid unnecessary tests.
1096
1097 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1098
1099 * composite.h, composite.c (composition_gstring_put_cache):
1100 Use EMACS_INT, not int, for length.
1101
1102 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1103 breaking out part of COMPOSITION_DECODE_RULE.
1104 (COMPOSITION_DECODE_RULE): Use it.
1105 * composite.c (get_composition_id): Remove unused local vars,
1106 by using the new macro.
1107
1108 * textprop.c (set_text_properties_1): Change while to do-while,
1109 since the condition is always true at first.
1110
1111 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1112 (interval_deletion_adjustment): Return unsigned value.
1113 All uses changed.
1114
1115 * process.c (list_processes_1, create_pty, read_process_output):
1116 (exec_sentinel): Remove vars that were set but not used.
1117 (create_pty): Remove unnecessary "volatile"s.
1118 (Fnetwork_interface_info): Avoid possibility of int overflow.
1119 (read_process_output): Do adaptive read buffering even if carryover.
1120 (read_process_output): Simplify nbytes computation if buffered.
1121
1122 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1123
1124 * syntax.c (scan_words): Remove var that was set but not used.
1125 (update_syntax_table): Use unsigned instead of int.
1126
1127 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1128 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1129 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1130
1131 * print.c (print_error_message): Avoid int overflow.
1132
1133 * font.c (font_list_entities): Redo for clarity,
1134 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1135
1136 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1137 (font_score): Avoid potential overflow in diff calculation.
1138
1139 * fns.c (substring_both): Remove var that is set but not used.
1140 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1141
1142 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1143
1144 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1145 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1146 can always succeed if overflow has undefined behavior.
1147
1148 * search.c (boyer_moore, wordify): Remove vars set but not used.
1149 (wordify): Omit three unnecessary tests.
1150
1151 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1152 All callers changed. This avoids the need for an unused var.
1153
1154 * casefiddle.c (casify_region): Remove var that is set but not used.
1155
1156 * dired.c (file_name_completion): Remove var that is set but not used.
1157
1158 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1159
1160 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1161 (Finsert_file_contents): Remove unnecessary code checking fd.
1162
1163 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1164 Check for integer overflow on size calculations.
1165
1166 * buffer.c (Fprevious_overlay_change): Remove var that is set
1167 but not used.
1168
1169 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1170 Remove vars that are set but not used.
1171 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1172 (timer_check_2): Mark vars as initialized.
1173
1174 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1175
1176 * image.c (lookup_image): Remove var that is set but not used.
1177 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1178
1179 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1180 that are set but not used.
1181
1182 * xfns.c (make_invisible_cursor): Don't return garbage
1183 if XCreateBitmapFromData fails (Bug#8410).
1184
1185 * xselect.c (x_get_local_selection, x_handle_property_notify):
1186 Remove vars that are set but not used.
1187
1188 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1189 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1190
1191 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1192 Remove var that is set but not used.
1193 (scroll_bar_windows_size): Now size_t, not int.
1194 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1195 Check for overflow.
1196
1197 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1198 (map_tty_color) [!defined MSDOS]: Likewise.
1199
1200 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1201
1202 * coding.c: Remove vars that are set but not used.
1203 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1204 All callers changed.
1205 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1206 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1207 (decode_coding_charset): Remove vars that are set but not used.
1208
1209 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1210 that is set but not used.
1211
1212 * print.c (print_object): Remove var that is set but not used.
1213
1214 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1215 The gnulib version avoids calling malloc in the usual case,
1216 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1217 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1218 * filelock.c (current_lock_owner): Likewise.
1219 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1220 * sysdep.c: Include allocator.h, careadlinkat.h.
1221 (emacs_no_realloc_allocator): New static constant.
1222 (emacs_readlink): New function.
1223 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1224 ../lib/careadlinkat.h.
1225
1226 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1227
1228 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1229 first non-nil return value).
1230
1231 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1232
1233 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1234 if not defined (Bug#8403).
1235
1236 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1237
1238 * xdisp.c (display_count_lines): Remove parameter `start',
1239 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1240 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1241 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1242 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1243 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1244 and thereabouts. All callers changed.
1245 (get_per_char_metric): Remove parameter `f', unused since
1246 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1247
1248 2011-04-02 Jim Meyering <meyering@redhat.com>
1249
1250 do not dereference NULL upon failed strdup
1251 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1252 (ns_get_family): Likewise.
1253
1254 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1255
1256 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1257
1258 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1259
1260 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1261 later (Bug#8403).
1262
1263 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1264
1265 Add lexical binding.
1266
1267 * window.c (Ftemp_output_buffer_show): New fun.
1268 (Fsave_window_excursion):
1269 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1270
1271 * lread.c (lisp_file_lexically_bound_p): New function.
1272 (Fload): Bind Qlexical_binding.
1273 (readevalloop): Remove `evalfun' arg.
1274 Bind Qinternal_interpreter_environment.
1275 (Feval_buffer): Bind Qlexical_binding.
1276 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1277 Mark as dynamic.
1278 (syms_of_lread): Declare `lexical-binding'.
1279
1280 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1281
1282 * keyboard.c (eval_dyn): New fun.
1283 (menu_item_eval_property): Use it.
1284
1285 * image.c (parse_image_spec): Use Ffunctionp.
1286
1287 * fns.c (concat, mapcar1): Accept byte-code-functions.
1288
1289 * eval.c (Fsetq): Handle lexical vars.
1290 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1291 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1292 (FletX, Flet): Obey lexical binding.
1293 (Fcommandp): Handle closures.
1294 (Feval): New `lexical' arg.
1295 (eval_sub): New function extracted from Feval. Use it almost
1296 everywhere where Feval was used. Look up vars in lexical env.
1297 Handle closures.
1298 (Ffunctionp): Move from subr.el.
1299 (Ffuncall): Handle closures.
1300 (apply_lambda): Remove `eval_flags'.
1301 (funcall_lambda): Handle closures and new byte-code-functions.
1302 (Fspecial_variable_p): New function.
1303 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1304 but without exporting it to Lisp.
1305
1306 * doc.c (Fdocumentation, store_function_docstring):
1307 * data.c (Finteractive_form): Handle closures.
1308
1309 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1310 interactive spec.
1311
1312 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1313 byte-codes.
1314 (exec_byte_code): New function extracted from Fbyte_code to handle new
1315 calling convention for byte-code-functions. Add new byte-codes.
1316
1317 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1318
1319 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1320
1321 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1322
1323 * xdisp.c (redisplay_internal): Fix prototype.
1324
1325 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1326
1327 * xdisp.c (SCROLL_LIMIT): New macro.
1328 (try_scrolling): Use it when setting scroll_limit. Limit
1329 scrolling to 100 screen lines.
1330 (redisplay_window): Even when falling back on "recentering",
1331 position point in the window according to scroll-conservatively,
1332 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1333
1334 (try_scrolling): When point is above the window, allow searching
1335 as far as scroll_max, or one screenful, to compute vertical
1336 distance from PT to the scroll margin position. This prevents
1337 try_scrolling from unnecessarily failing when
1338 scroll-conservatively is set to a value slightly larger than the
1339 window height. Clean up the case of PT below the margin at bottom
1340 of window: scroll_max can no longer be INT_MAX. When aggressive
1341 scrolling is in use, don't let point enter the opposite scroll
1342 margin as result of the scroll.
1343 (syms_of_xdisp) <scroll-conservatively>: Document the
1344 threshold of 100 lines for never-recentering scrolling.
1345
1346 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1347
1348 * dispextern.h (move_it_by_lines):
1349 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1350 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1351 (message_log_check_duplicate): Remove parameters `prev_bol' and
1352 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1353 (redisplay_internal): Remove parameter `preserve_echo_area',
1354 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1355
1356 * indent.c (Fvertical_motion):
1357 * window.c (window_scroll_pixel_based, Frecenter):
1358 Don't pass `need_y_p' to `move_it_by_lines'.
1359
1360 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1361
1362 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1363 steal a few bits to be more compact.
1364 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1365 Remove unneeded casts.
1366
1367 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1368
1369 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1370
1371 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1372 binding" message (bug#7967).
1373
1374 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1375
1376 Fix more problems found by GCC 4.6.0's static checks.
1377
1378 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1379 Remove unused local var.
1380
1381 * editfns.c (Fmessage_box): Remove unused local var.
1382
1383 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1384 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1385 Omit unused local vars.
1386 * window.c (shrink_windows): Omit unused local var.
1387 * menu.c (digest_single_submenu): Omit unused local var.
1388 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1389 Omit unused local var.
1390
1391 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1392 Don't assume string length fits in int.
1393 (keyremap_step, read_key_sequence): Use size_t for sizes.
1394 (read_key_sequence): Don't check last_real_key_start redundantly.
1395
1396 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1397 instead of alloca (Bug#8344).
1398
1399 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1400 (Fbacktrace_frame): Don't assume nframes fits in int.
1401
1402 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1403
1404 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1405 concerns.
1406
1407 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1408
1409 * cm.c (calccost): Turn while-do into do-while, for clarity.
1410
1411 * keyboard.c (syms_of_keyboard): Use the same style as later
1412 in this function when indexing through an array. This also
1413 works around GCC bug 48267.
1414
1415 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1416
1417 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1418
1419 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1420 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1421
1422 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1423 This avoids undefined behavior on integer overflow, and is a bit
1424 more convenient anyway since it is compared to a size_t variable.
1425
1426 Variadic C functions now count arguments with size_t, not int.
1427 This avoids an unnecessary limitation on 64-bit machines, which
1428 caused (substring ...) to crash on large vectors (Bug#8344).
1429 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1430 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1431 All variadic functions and their callers changed accordingly.
1432 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1433 * data.c (arith_driver, float_arith_driver): Likewise.
1434 * editfns.c (general_insert_function): Likewise.
1435 * eval.c (struct backtrace.nargs, interactive_p)
1436 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1437 (funcall_lambda, mark_backtrace): Likewise.
1438 * fns.c (concat): Likewise.
1439 * frame.c (x_set_frame_parameters): Likewise.
1440 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1441 0 if not found, not -1. All callers changed.
1442
1443 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1444 (stack_copy_size): Now size_t, not int.
1445 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1446
1447 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1448
1449 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1450 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1451 All callers changed.
1452
1453 * lisp.h (multibyte_char_to_unibyte):
1454 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1455 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1456 * character.h (CHAR_TO_BYTE8):
1457 * cmds.c (internal_self_insert):
1458 * editfns.c (general_insert_function):
1459 * keymap.c (push_key_description):
1460 * search.c (Freplace_match):
1461 * xdisp.c (message_dolog, set_message_1): All callers changed.
1462
1463 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1464
1465 * keyboard.c (safe_run_hook_funcall): New function.
1466 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1467 don't set the hook to nil, but remove the offending function instead.
1468 (Qcommand_hook_internal): Remove, unused.
1469 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1470 Vcommand_hook_internal.
1471
1472 * eval.c (enum run_hooks_condition): Remove.
1473 (funcall_nil, funcall_not): New functions.
1474 (run_hook_with_args): Call each function through a `funcall' argument.
1475 Remove `cond' argument, now redundant.
1476 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1477 (Frun_hook_with_args_until_failure): Adjust accordingly.
1478 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1479
1480 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1481
1482 * dispextern.h (string_buffer_position): Remove declaration.
1483
1484 * print.c (strout): Remove parameter `multibyte', unused since
1485 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1486
1487 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1488 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1489 All callers changed.
1490
1491 * w32.c (_wsa_errlist): Use braces for struct initializers.
1492
1493 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1494 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1495 All callers changed.
1496 (string_buffer_position): Likewise. Also, make static (it's never
1497 used outside xdisp.c).
1498 (cursor_row_p): Remove parameter `w', unused since
1499 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1500 (decode_mode_spec): Remove parameter `precision', introduced during
1501 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1502 All callers changed.
1503
1504 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1505
1506 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1507
1508 2011-03-27 Anders Lindgren <andlind@gmail.com>
1509
1510 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1511 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1512 (ns_update_auto_hide_menu_bar): New functions.
1513 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1514 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1515 ns_constrain_all_frames.
1516 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1517 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1518
1519 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1520
1521 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1522
1523 2011-03-27 Glenn Morris <rgm@gnu.org>
1524
1525 * syssignal.h: Replace RETSIGTYPE with void.
1526 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1527 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1528 Replace SIGTYPE with void everywhere.
1529 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1530 * s/template.h (SIGTYPE): Remove commented out definition.
1531
1532 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1533
1534 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1535 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1536
1537 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1538
1539 * w32.c (read_unc_volume): Use parameter `henum', instead of
1540 global variable `wget_enum_handle'.
1541
1542 * keymap.c (describe_vector): Remove parameters `indices' and
1543 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1544 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1545
1546 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1547
1548 * keyboard.c (timer_check): Remove parameter `do_it_now',
1549 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1550 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1551 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1552
1553 * keyboard.c (read_char):
1554 * w32menu.c (w32_menu_display_help):
1555 * xmenu.c (show_help_event, menu_help_callback):
1556 Adjust calls to `show_help_echo'.
1557
1558 * gtkutil.c (xg_maybe_add_timer):
1559 * keyboard.c (readable_events):
1560 * process.c (wait_reading_process_output):
1561 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1562
1563 * insdel.c (adjust_markers_gap_motion):
1564 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1565 (gap_left, gap_right): Don't call it.
1566
1567 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1568
1569 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1570 incurred during fontification.
1571
1572 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1573
1574 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1575 (DEFVAR_PER_BUFFER): Don't pass it.
1576
1577 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1578 (scrolling_window): Don't pass it.
1579
1580 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1581
1582 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1583
1584 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1585 and `suffix'.
1586 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1587 of variables specific to SELinux and computation of `encoded_absname'.
1588
1589 * image.c (XPutPixel): Remove unused variable `height'.
1590
1591 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1592
1593 * unexw32.c (get_section_info): Remove unused variable `section'.
1594
1595 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1596 (system_process_attributes): Remove unused variable `sess'.
1597 (sys_read): Remove unused variable `err'.
1598
1599 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1600 (w32_wnd_proc): Remove unused variable `isdead'.
1601 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1602 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1603 (x_create_tip_frame): Remove unused variable `tem'.
1604
1605 * w32inevt.c (w32_console_read_socket):
1606 Remove unused variable `no_events'.
1607
1608 * w32term.c (x_draw_composite_glyph_string_foreground):
1609 Remove unused variable `width'.
1610
1611 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
1612
1613 * w32term.c (x_set_glyph_string_clipping):
1614 Don't pass uninitialized region to CombineRgn.
1615
1616 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
1617
1618 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1619 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1620 (Fx_close_connection): Remove unused variable `i'.
1621
1622 * w32font.c (w32font_draw): Return number of glyphs.
1623 (w32font_open_internal): Remove unused variable `i'.
1624 (w32font_driver): Add missing initializer.
1625
1626 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1627 (fill_in_menu): Remove unused variable `items_added'.
1628
1629 * w32term.c (last_mouse_press_frame): Remove static global variable.
1630 (w32_clip_to_row): Remove unused variable `f'.
1631 (x_delete_terminal): Remove unused variable `i'.
1632
1633 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1634 (NOTHING): Remove unused static global variable.
1635 (uniscribe_check_otf): Remove unused variable `table'.
1636 (uniscribe_font_driver): Add missing initializers.
1637
1638 2011-03-23 Julien Danjou <julien@danjou.info>
1639
1640 * term.c (Fsuspend_tty, Fresume_tty):
1641 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1642 * window.c (temp_output_buffer_show):
1643 * insdel.c (signal_before_change):
1644 * frame.c (Fhandle_switch_frame):
1645 * fileio.c (Fdo_auto_save):
1646 * emacs.c (Fkill_emacs):
1647 * editfns.c (save_excursion_restore):
1648 * cmds.c (internal_self_insert):
1649 * callint.c (Fcall_interactively):
1650 * buffer.c (Fkill_all_local_variables):
1651 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1652 Use Frun_hooks.
1653 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
1654 unconditionnaly since it does the check itself.
1655
1656 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
1657
1658 Fix more problems found by GCC 4.5.2's static checks.
1659
1660 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1661 the first time through the loop, since we know p0 < p1 then.
1662 This also avoids a gcc -Wstrict-overflow warning.
1663
1664 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1665 leading to a memory leak, possible in functions like
1666 load_charset_map_from_file that can allocate an unbounded number
1667 of objects (Bug#8318).
1668
1669 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1670 that could (at least in theory) be that large.
1671
1672 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1673 This is less likely to overflow, and avoids undefined behavior if
1674 overflow does occur. All callers changed. Use strtoul to scan
1675 for the unsigned long integer.
1676 (pint2hrstr): Simplify and tune code slightly.
1677 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1678
1679 * scroll.c (do_scrolling): Work around GCC bug 48228.
1680 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1681
1682 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1683 This also avoids a warning with gcc -Wstrict-overflow.
1684 (validate_x_resource_name): Simplify count usage.
1685 This also avoids a warning with gcc -Wstrict-overflow.
1686
1687 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1688 fail (Bug#8306).
1689
1690 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1691
1692 * process.c (Fmake_network_process): Use socklen_t, not int,
1693 where POSIX says socklen_t is required in portable programs.
1694 This fixes a porting bug on hosts like 64-bit HP-UX, where
1695 socklen_t is wider than int (Bug#8277).
1696 (Fmake_network_process, server_accept_connection):
1697 (wait_reading_process_output, read_process_output):
1698 Likewise.
1699
1700 * process.c: Rename or move locals to avoid shadowing.
1701 (list_processes_1, Fmake_network_process):
1702 (read_process_output_error_handler, exec_sentinel_error_handler):
1703 Rename or move locals.
1704 (Fmake_network_process): Define label "retry_connect" only if needed.
1705 (Fnetwork_interface_info): Fix pointer signedness.
1706 (process_send_signal): Add cast to avoid pointer signedness problem.
1707 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
1708 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
1709
1710 Make tparam.h and terminfo.c consistent.
1711 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1712 Include tparam.h instead, since it declares them.
1713 * cm.h (PC): Remove extern decl; tparam.h now does this.
1714 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1715 * terminfo.c: Include tparam.h, to check interfaces.
1716 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1717 (tparam): Adjust signature to match interface in tparam.h;
1718 this removes some undefined behavior. Check that outstring and len
1719 are zero, which they always are with Emacs.
1720 * tparam.h (PC, BC, UP): New extern decls.
1721
1722 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
1723 (xftfont_open): Rename locals to avoid shadowing.
1724
1725 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
1726 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1727 (OTF_TAG_SYM): Omit macro if not needed.
1728 (ftfont_list): Remove unused local.
1729 (get_adstyle_property, ftfont_pattern_entity):
1730 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1731 Rename locals to avoid shadowing.
1732
1733 * xfont.c (xfont_list_family): Mark var as initialized.
1734
1735 * xml.c (make_dom): Now static.
1736
1737 * composite.c (composition_compute_stop_pos): Rename local to
1738 avoid shadowing.
1739 (composition_reseat_it): Remove unused locals.
1740 (find_automatic_composition, composition_adjust_point): Likewise.
1741 (composition_update_it): Mark var as initialized.
1742 (find_automatic_composition): Mark vars as initialized,
1743 with a FIXME (Bug#8290).
1744
1745 character.h: Rename locals to avoid shadowing.
1746 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1747 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1748 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1749 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1750 to avoid shadowing.
1751
1752 * textprop.c (property_change_between_p): Remove; unused.
1753
1754 * intervals.c (interval_start_pos): Now static.
1755
1756 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1757
1758 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1759 Rename locals to avoid shadowing.
1760
1761 * sound.c (wav_play, au_play, Fplay_sound_internal):
1762 Fix pointer signedness.
1763 (alsa_choose_format): Remove unused local var.
1764 (wav_play): Initialize a variable to 0, to prevent undefined
1765 behavior (Bug#8278).
1766
1767 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1768
1769 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1770
1771 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1772 clobbering (Bug#8298).
1773 * sysdep.c (sys_subshell): Likewise.
1774 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
1775
1776 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1777 This should get cleaned up, so that child_setup has the
1778 same signature on all platforms.
1779
1780 * callproc.c (call_process_cleanup): Now static.
1781 (relocate_fd): Rename locals to avoid shadowing.
1782
1783 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
1784
1785 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1786 not to be necessary, and produces flickering.
1787
1788 2011-03-20 Glenn Morris <rgm@gnu.org>
1789
1790 * config.in: Remove file.
1791
1792 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
1793
1794 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1795 are now in src/globals.h.
1796 (syms_of_minibuf): Remove spurious & from previous change.
1797
1798 2011-03-20 Leo <sdl.web@gmail.com>
1799
1800 * minibuf.c (completing-read-function): New variable.
1801 (completing-read-default): Rename from completing-read.
1802 (completing-read): Call completing-read-function.
1803
1804 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1805
1806 * xfaces.c (Fx_load_color_file):
1807 Read color file from absolute filename (bug#8250).
1808
1809 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1810
1811 * makefile.w32-in: Update dependencies.
1812
1813 2011-03-17 Eli Zaretskii <eliz@gnu.org>
1814
1815 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1816
1817 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1818
1819 Fix more problems found by GCC 4.5.2's static checks.
1820
1821 * process.c (make_serial_process_unwind, send_process_trap):
1822 (sigchld_handler): Now static.
1823
1824 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1825 That way, the code declares only the vars that it needs.
1826 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1827 * s/cygwin.h (PTY_ITERATION): Likewise.
1828 * s/darwin.h (PTY_ITERATION): Likewise.
1829 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1830
1831 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1832 * process.c (allocate_pty): Don't declare stb unless it's needed.
1833
1834 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
1835 (CONSTANTLIM): Remove; unused.
1836 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1837 Define only if needed.
1838
1839 * unexelf.c (unexec): Name an expression,
1840 to avoid gcc -Wbad-function-cast warning.
1841 Use a different way to cause a compilation error if anyone uses
1842 n rather than nn, a way that does not involve shadowing.
1843 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
1844
1845 * deps.mk (unexalpha.o): Remove; unused.
1846
1847 New file unexec.h, the (simple) interface for unexec (Bug#8267).
1848 * unexec.h: New file.
1849 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1850 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1851 Depend on unexec.h.
1852 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1853 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1854 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
1855 Change as necessary to match prototype in unexec.h.
1856
1857 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1858 shadowing.
1859 (back_comment, skip_chars): Mark vars as initialized.
1860
1861 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1862 Rename locals to avoid shadowing.
1863
1864 * lread.c (read1): Rewrite so as not to use empty "else".
1865 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
1866
1867 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1868
1869 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1870 warning when compiling print.c.
1871
1872 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1873 instead of using an uninitialized var.
1874 (font_sort_entities): Mark var as initialized.
1875
1876 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1877
1878 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1879 pointers to constants.
1880 (font_parse_fcname): Remove unused vars.
1881 (font_delete_unmatched): Now static.
1882 (font_get_spec): Remove; unused.
1883 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1884 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1885 Rename or move locals to avoid shadowing.
1886
1887 * fns.c (require_nesting_list, require_unwind): Now static.
1888 (Ffillarray): Rename locals to avoid shadowing.
1889
1890 * floatfns.c (domain_error2): Define only if needed.
1891 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1892
1893 * alloc.c (mark_backtrace): Move decl from here ...
1894 * lisp.h: ... to here, so that it can be checked.
1895
1896 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
1897 (Fdefvar): Rewrite so as not to use empty "else".
1898 (lisp_indirect_variable): Name an expression,
1899 to avoid gcc -Wbad-function-cast warning.
1900 (Fdefvar): Rename locals to avoid shadowing.
1901
1902 * callint.c (quotify_arg, quotify_args): Now static.
1903 (Fcall_interactively): Rename locals to avoid shadowing.
1904 Use const pointer when appropriate.
1905
1906 * lisp.h (get_system_name, get_operating_system_release):
1907 Move decls here, to check interfaces.
1908 * process.c (get_operating_system_release): Move decl to lisp.h.
1909 * xrdb.c (get_system_name): Likewise.
1910 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1911 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1912 some of which prompt warnings from gcc -Wbad-function-cast.
1913 (Fformat_time_string, Fencode_time, Finsert_char):
1914 (Ftranslate_region_internal, Fformat):
1915 Rename or remove local vars to avoid shadowing.
1916 (Ftranslate_region_internal): Mark var as initialized.
1917
1918 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1919 avoid shadowing.
1920
1921 * lisp.h (eassert): Check that the argument compiles, even if
1922 ENABLE_CHECKING is not defined.
1923
1924 * data.c (Findirect_variable): Name an expression, to avoid
1925 gcc -Wbad-function-cast warning.
1926 (default_value, arithcompare, arith_driver, arith_error): Now static.
1927 (store_symval_forwarding): Rename local to avoid shadowing.
1928 (Fmake_variable_buffer_local, Fmake_local_variable):
1929 Mark variables as initialized.
1930 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
1931
1932 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
1933 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1934 Rename locals to avoid shadowing.
1935 (mark_stack): Move local variables into the #ifdef region where
1936 they're used.
1937 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1938 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1939 needed otherwise.
1940 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1941 (GC_STRING_CHARS): Remove; not used.
1942 (Fmemory_limit): Cast sbrk's returned value to char *.
1943
1944 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1945 avoids undefined behavior in theory.
1946
1947 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1948
1949 Use functions, not macros, for up- and down-casing (Bug#8254).
1950 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1951 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1952 to use the following functions instead of these macros.
1953 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1954 EMACS_INT, since callers assume the returned value fits in int.
1955 (upcase1): Likewise, for UPCASE_TABLE.
1956 (uppercasep, lowercasep, upcase): New static inline functions.
1957 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
1958 the race-condition problem in the old DOWNCASE.
1959
1960 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1961 Rename locals to avoid shadowing.
1962 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
1963 (regex_compile, re_search_2, re_match_2_internal):
1964 Remove unused local vars.
1965 (FREE_VAR): Rewrite so as not to use empty "else",
1966 which gcc can warn about.
1967 (regex_compile, re_match_2_internal): Mark locals as initialized.
1968 (RETALLOC_IF): Define only if needed.
1969 (WORDCHAR_P): Likewise. This one is never needed, but is used
1970 only in a comment talking about a compiler bug, so put inside
1971 the #if 0 of that comment.
1972 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1973 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1974 Remove; unused.
1975
1976 * search.c (boyer_moore): Rename locals to avoid shadowing.
1977 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1978 (PREV_CHAR_BOUNDARY): Likewise.
1979
1980 * search.c (simple_search): Remove unused var.
1981
1982 * dired.c (compile_pattern): Move decl from here ...
1983 * lisp.h: ... to here, so that it can be checked.
1984 (struct re_registers): New forward decl.
1985
1986 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1987
1988 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1989 All uses changed.
1990 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1991 Rename locals to avoid shadowing.
1992 (Fvertical_motion): Mark locals as initialized.
1993
1994 * casefiddle.c (casify_object, casify_region): Now static.
1995 (casify_region): Mark local as initialized.
1996
1997 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1998
1999 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2000 New macros, so that the caller can use some names other than
2001 gcpro1, gcpro2, etc.
2002 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2003 of the new macros.
2004 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2005 argument, for consistency with GCPRO2_VAR, etc: it is now the
2006 prefix of the variable, not the variable itself. All uses
2007 changed.
2008 * dired.c (directory_files_internal, file_name_completion):
2009 Rename locals to avoid shadowing.
2010
2011 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2012 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2013 dired.c's scmp function, had undefined behavior.
2014 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2015 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2016 * buffer.h: ... to here, because these macros use current_buffer,
2017 and the new implementation with inline functions needs to have
2018 current_buffer in scope now, rather than later when the macros
2019 are used.
2020 (downcase, upcase1): New static inline functions.
2021 (DOWNCASE, UPCASE1): Reimplement using these functions.
2022 This avoids undefined behavior in expressions like
2023 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2024 from race conditions in accessing the global variables
2025 case_temp1 and case_temp2.
2026 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2027 * lisp.h (case_temp1, case_temp2): Remove their decls.
2028 * character.h (ASCII_CHAR_P): Move from here ...
2029 * lisp.h: ... to here, so that the inline functions mentioned
2030 above can use them.
2031
2032 * dired.c (directory_files_internal_unwind): Now static.
2033
2034 * fileio.c (file_name_as_directory, directory_file_name):
2035 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2036 Now static.
2037 (file_name_as_directory): Use const pointers when appropriate.
2038 (Fexpand_file_name): Likewise. In particular, newdir might
2039 point at constant storage, so make it a const pointer.
2040 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2041 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2042 signedness issues.
2043 (Fset_file_times, Finsert_file_contents, auto_save_error):
2044 Rename locals to avoid shadowing.
2045
2046 * minibuf.c (choose_minibuf_frame_1): Now static.
2047 (Ftry_completion, Fall_completions): Rename or remove locals
2048 to avoid shadowing.
2049
2050 * marker.c (bytepos_to_charpos): Remove; unused.
2051
2052 * lisp.h (verify_bytepos, count_markers): New decls,
2053 so that gcc does not warn that these functions aren't declared.
2054
2055 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2056 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2057 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2058 (copy_text): Remove unused local var.
2059
2060 * filelock.c (within_one_second): Now static.
2061 (lock_file_1): Rename local to avoid shadowing.
2062
2063 * buffer.c (fix_overlays_before): Mark locals as initialized.
2064 (fix_start_end_in_overlays): Likewise. This function should be
2065 simplified by using pointers-to-pointers, but that's a different
2066 matter.
2067 (switch_to_buffer_1): Now static.
2068 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2069 (report_overlay_modification): Rename locals to avoid shadowing.
2070
2071 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2072 Fix pointer signedness issue.
2073 (sys_subshell): Mark local as volatile if checking for lint,
2074 to suppress a gcc -Wclobbered warning that does not seem to be right.
2075 (MAXPATHLEN): Define only if needed.
2076
2077 * process.c (serial_open, serial_configure): Move decls from here ...
2078 * systty.h: ... to here, so that they can be checked.
2079
2080 * fns.c (get_random, seed_random): Move extern decls from here ...
2081 * lisp.h: ... to here, so that they can be checked.
2082
2083 * sysdep.c (reset_io): Now static.
2084 (wait_for_termination_signal): Remove; unused.
2085
2086 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2087 (copy_keymap_item, append_key, push_text_char_description):
2088 Now static.
2089 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2090 (DENSE_TABLE_SIZE): Remove; unused.
2091 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2092 (describe_map_tree):
2093 Rename locals to avoid shadowing.
2094
2095 * keyboard.c: Declare functions static if they are not used elsewhere.
2096 (echo_char, echo_dash, cmd_error, top_level_2):
2097 (poll_for_input, handle_async_input): Now static.
2098 (read_char, kbd_buffer_get_event, make_lispy_position):
2099 (make_lispy_event, make_lispy_movement, apply_modifiers):
2100 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2101 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2102 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2103 (read_key_sequence, read_char): Mark locals as initialized.
2104 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2105
2106 * keyboard.h (make_ctrl_char): New decl.
2107 (mark_kboards): Move decl here ...
2108 * alloc.c (mark_kboards): ... from here.
2109
2110 * lisp.h (force_auto_save_soon): New decl.
2111
2112 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2113 (DEFINE_DUMMY_FUNCTION): New macro.
2114 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2115 Use it.
2116 (main): Add casts to avoid warnings
2117 if GCC considers string literals to be constants.
2118
2119 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2120
2121 * dbusbind.c: Pointer signedness fixes.
2122 (xd_signature, xd_append_arg, xd_initialize):
2123 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2124 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2125 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2126 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2127
2128 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2129 if GCC considers string literals to be constants.
2130 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2131
2132 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2133
2134 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2135 (print_preprocess, print_object): New macro to fix last change.
2136
2137 * print.c (print_preprocess): Don't forget font objects.
2138
2139 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2140
2141 * emacs.c (USAGE3): Doc fixes.
2142
2143 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2144
2145 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2146 structure.
2147
2148 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2149
2150 * lisp.h (VWindow_system, Qfile_name_history):
2151 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2152 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2153 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2154
2155 * w32select.c: Don't #include "keyboard.h".
2156 (run_protected): Add extern declaration for waiting_for_input.
2157
2158 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2159 * w32console.c (detect_input_pending, read_input_pending)
2160 (encode_terminal_code):
2161 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2162 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2163 (w32_system_caret_y, Qfile_name_history):
2164 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2165 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2166 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2167 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2168 * w32proc.c (Qlocal, report_file_error):
2169 * w32term.c (Vwindow_system, updating_frame):
2170 * w32uniscribe.c (initialized, uniscribe_font_driver):
2171 Remove unneeded extern declarations.
2172
2173 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2174
2175 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2176
2177 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2178
2179 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2180 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2181 These macros can no longer be used for assignment.
2182
2183 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2184 Assign struct members directly, instead of using BUF_BEGV etc.
2185 (record_buffer_markers, fetch_buffer_markers): New functions for
2186 recording and fetching special buffer markers.
2187 (set_buffer_internal_1, set_buffer_temp): Use them.
2188
2189 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2190
2191 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2192
2193 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2194 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2195
2196 * xdisp.c (hscroll_window_tree):
2197 (reconsider_clip_changes): Use PT instead of BUF_PT.
2198
2199 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2200
2201 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2202 $(EMACS_ROOT)/lib/intprops.h.
2203
2204 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2205
2206 Fix more problems found by GCC 4.5.2's static checks.
2207
2208 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2209 to unsigned char * to avoid compiler diagnostic.
2210 (xg_free_frame_widgets): Make it clear that a local variable is
2211 needed only if USE_GTK_TOOLTIP.
2212 (gdk_window_get_screen): Make it clear that this macro is needed
2213 only if USE_GTK_TOOLTIP.
2214 (int_gtk_range_get_value): New function, which avoids a diagnostic
2215 from gcc -Wbad-function-cast.
2216 (xg_set_toolkit_scroll_bar_thumb): Use it.
2217 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2218 diagnostic from gcc -Wbad-function-cast.
2219 (get_utf8_string, xg_get_file_with_chooser):
2220 Rename locals to avoid shadowing.
2221 (create_dialog): Move locals to avoid shadowing.
2222
2223 * xgselect.c (xg_select): Remove unused var.
2224
2225 * image.c (four_corners_best): Mark locals as initialized.
2226 (gif_load): Initialize transparent_p to zero (Bug#8238).
2227 Mark another local as initialized.
2228 (my_png_error, my_error_exit): Mark with NO_RETURN.
2229
2230 * image.c (clear_image_cache): Now static.
2231 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2232 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2233 (x_edge_detection): Remove unnecessary cast that
2234 gcc -Wbad-function-cast diagnoses.
2235 (gif_load): Fix pointer signedness.
2236 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2237 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2238
2239 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2240
2241 Improve quality of tests for time stamp overflow.
2242 For example, without this patch (encode-time 0 0 0 1 1
2243 1152921504606846976) returns the obviously-bogus value (-948597
2244 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2245 reports time overflow. See
2246 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2247 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2248 * editfns.c: Include limits.h and intprops.h.
2249 (TIME_T_MIN, TIME_T_MAX): New macros.
2250 (time_overflow): Move earlier, to before first use.
2251 (hi_time, lo_time): New functions, for an accurate test for
2252 out-of-range times.
2253 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2254 (Fget_internal_run_time): Don't assume time_t fits in int.
2255 (make_time): Use list2 instead of Fcons twice.
2256 (Fdecode_time): More accurate test for out-of-range times.
2257 (check_tm_member): New function.
2258 (Fencode_time): Use it, to test for out-of-range times.
2259 (lisp_time_argument): Don't rely on undefined left-shift and
2260 right-shift behavior when checking for time stamp overflow.
2261
2262 * editfns.c (time_overflow): New function, refactoring common code.
2263 (Fformat_time_string, Fdecode_time, Fencode_time):
2264 (Fcurrent_time_string): Use it.
2265
2266 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2267 * dired.c (make_time): Move to ...
2268 * editfns.c (make_time): ... here.
2269 * systime.h: Note the move.
2270
2271 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2272
2273 * fringe.c (update_window_fringes): Remove unused variables.
2274
2275 * unexmacosx.c (copy_data_segment): Also copy __got section.
2276 (Bug#8223)
2277
2278 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2279
2280 * termcap.c [MSDOS]: Include "msdos.h".
2281 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2282 Constify `char *' arguments and their references according to
2283 prototypes in tparam.h.
2284
2285 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2286
2287 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2288 Adapt all references accordingly.
2289
2290 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2291
2292 2011-03-11 Tom Tromey <tromey@redhat.com>
2293
2294 * buffer.c (syms_of_buffer): Remove obsolete comment.
2295
2296 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2297
2298 * termhooks.h (encode_terminal_code): Declare prototype.
2299
2300 * msdos.c (encode_terminal_code): Don't declare prototype.
2301
2302 * term.c (encode_terminal_code): Now external again, used by
2303 w32console.c and msdos.c.
2304
2305 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2306 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2307
2308 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2309
2310 Fix some minor problems found by GCC 4.5.2's static checks.
2311
2312 * fringe.c (update_window_fringes): Mark locals as initialized
2313 (Bug#8227).
2314 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2315
2316 * alloc.c (mark_fringe_data): Move decl from here ...
2317 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2318 to check its interface.
2319 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2320
2321 * fontset.c (free_realized_fontset): Now static.
2322 (Fset_fontset_font): Rename local to avoid shadowing.
2323 (fontset_font): Mark local as initialized.
2324 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2325
2326 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2327
2328 * xselect.c (x_disown_buffer_selections): Remove; not used.
2329 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2330 (x_own_selection, Fx_disown_selection_internal): Rename locals
2331 to avoid shadowing.
2332 (x_handle_dnd_message): Remove local to avoid shadowing.
2333
2334 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2335 so that the caller can use some name other than gcpro1.
2336 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2337 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2338 (Fx_backspace_delete_keys_p):
2339 Use them to avoid shadowing, and rename vars to avoid shadowing.
2340 (x_decode_color, x_set_name, x_window): Now static.
2341 (Fx_create_frame): Add braces to silence GCC warning.
2342 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2343 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2344 Remove unused locals.
2345 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2346 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2347 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2348 macros.
2349
2350 * xterm.h (x_mouse_leave): New decl.
2351
2352 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2353 Remove unused functions.
2354 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2355 (x_calc_absolute_position): Now static.
2356 (XTread_socket): Don't define label "out" unless it's used.
2357 Don't declare local "event" unless it's used.
2358 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2359 unless they are used.
2360 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2361 (x_fatal_error_signal): Remove; not used.
2362 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2363 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2364 (x_error_catcher, x_connection_closed, x_error_handler):
2365 (x_error_quitter, xembed_send_message, x_iconify_frame):
2366 (my_log_handler): Rename locals to avoid shadowing.
2367 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2368 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2369
2370 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2371 Rename or move locals to avoid shadowing.
2372 (tty_defined_color, merge_face_heights): Now static.
2373 (free_realized_faces_for_fontset): Remove; not used.
2374 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2375 does not deduce is never used uninitialized.
2376 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2377 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2378
2379 * terminal.c (store_terminal_param): Now static.
2380
2381 * xmenu.c (menu_highlight_callback): Now static.
2382 (set_frame_menubar): Remove unused local.
2383 (xmenu_show): Rename parameter to avoid shadowing.
2384 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2385 since they might point to immutable storage.
2386 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2387 since it's unused otherwise.
2388
2389 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2390 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2391 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2392 avoids a gcc -Wuninitialized diagnostic.
2393 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2394 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2395 does not deduce are never used uninitialized.
2396
2397 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2398
2399 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2400 * window.c (window_loop, size_window):
2401 (run_window_configuration_change_hook, enlarge_window): Likewise.
2402
2403 * window.c (display_buffer): Now static.
2404 (size_window): Mark variables that gcc -Wuninitialized
2405 does not deduce are never used uninitialized.
2406 * window.h (check_all_windows): New decl, to forestall
2407 gcc -Wmissing-prototypes diagnostic.
2408 * dispextern.h (bidi_dump_cached_states): Likewise.
2409
2410 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2411 shadowing.
2412 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2413 Include <limits.h>.
2414 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2415 and to avoid gcc -Wuninitialized warning.
2416 (load_charset_map): Mark variables that gcc -Wuninitialized
2417 does not deduce are never used uninitialized.
2418 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2419
2420 * coding.c (coding_set_source, coding_set_destination):
2421 Use "else { /* comment */ }" rather than "else /* comment */;"
2422 for clarity, and to avoid gcc -Wempty-body warning.
2423 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2424 a block, when the outer 'i' will do.
2425 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2426 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2427 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2428 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2429 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2430 Rename locals to avoid shadowing.
2431 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2432 * coding.c (emacs_mule_char, encode_invocation_designation):
2433 Now static, since they're not used elsewhere.
2434 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2435 (decode_coding_object, encode_coding_object, detect_coding_system):
2436 (decode_coding_emacs_mule): Mark variables that gcc
2437 -Wuninitialized does not deduce are never used uninitialized.
2438 (detect_coding_iso_2022): Initialize a local variable that might
2439 be used uninitialized. Leave a FIXME because it's not clear that
2440 this initialization is needed. (Bug#8211)
2441 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2442 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2443 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2444 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2445 Remove unused macros.
2446
2447 * category.c (hash_get_category_set): Remove unused local var.
2448 (copy_category_table): Now static, since it's not used elsewhere.
2449 * character.c (string_count_byte8): Likewise.
2450
2451 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2452 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2453
2454 * chartab.c (copy_sub_char_table): Now static, since it's not used
2455 elsewhere.
2456 (sub_char_table_ref_and_range, char_table_ref_and_range):
2457 Rename locals to avoid shadowing.
2458 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2459
2460 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2461 (BIDI_BOB): Remove unused macro.
2462
2463 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2464 deduce are never used uninitialized.
2465 * term.c (encode_terminal_code): Likewise.
2466
2467 * term.c (encode_terminal_code): Now static. Remove unused local.
2468
2469 * tparam.h: New file.
2470 * term.c, tparam.h: Include it.
2471 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2472 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2473 Move these decls to tparam.h, and make them agree with what
2474 is actually in tparam.c. The previous trick of using incompatible
2475 decls in different modules does not conform to the C standard.
2476 All callers of tparam changed to use tparam's actual API.
2477 * tparam.c (tparam1, tparam, tgoto):
2478 Use const pointers where appropriate.
2479
2480 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2481 * cm.h (struct cm): Likewise.
2482 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2483 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2484 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2485 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2486 (turn_on_face, init_tty): Likewise.
2487 * termchar.h (struct tty_display_info): Likewise.
2488
2489 * term.c (term_mouse_position): Rename local to avoid shadowing.
2490
2491 * alloc.c (mark_ttys): Move decl from here ...
2492 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2493
2494 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2495
2496 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2497
2498 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2499
2500 * search.c (compile_pattern_1): Remove argument regp, unused since
2501 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2502 (compile_pattern): Don't pass it.
2503
2504 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2505
2506 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2507 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2508 for ! HAVE_GTK3.
2509 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2510
2511 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2512
2513 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2514 gdk_window_get_screen, gdk_window_get_geometry,
2515 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2516 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2517 (xg_get_pixbuf_from_pixmap): New function.
2518 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2519 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2520 Call xg_get_pixbuf_from_pixmap instead of
2521 gdk_pixbuf_get_from_drawable.
2522 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2523 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2524 (xg_check_special_colors): Use GtkStyleContext and its functions
2525 for HAVE_GTK3.
2526 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2527 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2528 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2529 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2530 Call gtk_widget_get_preferred_size.
2531 (xg_frame_resized): gdk_window_get_geometry only takes 5
2532 parameters.
2533 (xg_win_to_widget, xg_event_is_for_menubar):
2534 Call gdk_x11_window_lookup_for_display.
2535 (xg_set_widget_bg): New function.
2536 (delete_cb): New function.
2537 (xg_create_frame_widgets): Connect delete-event to delete_cb.
2538 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2539 (xg_set_background_color): Call xg_set_widget_bg.
2540 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2541 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2542 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2543 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2544 if ! HAVE_GTK3.
2545 (update_frame_tool_bar): Call gtk_widget_hide.
2546 (xg_initialize): Use GDK_KEY_g.
2547
2548 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2549 if ! HAVE_GTK3
2550 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2551
2552 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2553 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2554 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2555
2556 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2557
2558 * w32xfns.c (select_palette): Check success of RealizePalette against
2559 GDI_ERROR, not zero.
2560
2561 See ChangeLog.11 for earlier changes.
2562
2563 ;; Local Variables:
2564 ;; coding: utf-8
2565 ;; End:
2566
2567 Copyright (C) 2011 Free Software Foundation, Inc.
2568
2569 This file is part of GNU Emacs.
2570
2571 GNU Emacs is free software: you can redistribute it and/or modify
2572 it under the terms of the GNU General Public License as published by
2573 the Free Software Foundation, either version 3 of the License, or
2574 (at your option) any later version.
2575
2576 GNU Emacs is distributed in the hope that it will be useful,
2577 but WITHOUT ANY WARRANTY; without even the implied warranty of
2578 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2579 GNU General Public License for more details.
2580
2581 You should have received a copy of the GNU General Public License
2582 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.