* filelock.c: Fix some buffer overrun and integer overflow issues.
[bpt/emacs.git] / src / ChangeLog
1 2011-06-20 Paul Eggert <eggert@cs.ucla.edu>
2
3 * filelock.c: Fix some buffer overrun and integer overflow issues.
4 (get_boot_time): Don't assume that gzip command string fits in 100 bytes.
5 Reformulate so as not to need the command string.
6 Invoke gzip -cd rather than gunzip, as it's more portable.
7 (lock_info_type, lock_file_1, lock_file):
8 Don't assume pid_t and time_t fit in unsigned long.
9 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10 (current_lock_owner): Prefer signed type for sizes.
11 Use memcpy, not strncpy, where memcpy is what is really wanted.
12 Don't assume (via atoi) that time_t and pid_t fit in int.
13 Check for time_t and/or pid_t out of range, e.g., via a network share.
14 Don't alloca where an auto var works fine.
15
16 2011-06-19 Paul Eggert <eggert@cs.ucla.edu>
17
18 * fileio.c: Fix some integer overflow issues.
19 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
20 Don't assume string length fits in int.
21 (directory_file_name): Don't assume string length fits in long.
22 (make_temp_name): Don't assume pid fits in int, or that its print
23 length is less than 20.
24
25 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
26
27 * coding.c (make_subsidiaries): Don't assume string length fits in int.
28
29 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
30
31 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
32 We prefer signed integers, even for size calculations.
33
34 * emacs.c: Don't assume string length fits in 'int'.
35 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
36 (main): Don't invoke strlen when not needed.
37
38 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
39 (XD_DEBUG_MESSAGE): Don't waste a byte.
40
41 * callproc.c (getenv_internal_1, getenv_internal)
42 (Fgetenv_internal):
43 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
44
45 * lread.c (invalid_syntax): Omit length argument.
46 All uses changed. This doesn't fix a bug, but it simplifies the
47 code away from its former Hollerith-constant appearance, and it's
48 one less 'int' to worry about when looking at integer-overflow issues.
49 (string_to_number): Simplify the 2011-04-26 change by invoking xsignal1.
50
51 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
52 This didn't break anything, but it didn't help either.
53 It's confusing to put a bogus integer in a place where the actual
54 value does not matter.
55 (LIST_END_P): Remove unused macro and its bogus comment.
56 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
57
58 2011-06-18 Paul Eggert <eggert@cs.ucla.edu>
59
60 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
61 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
62 implementation.
63 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
64 We prefer signed types, and the value cannot exceed the EMACS_INT
65 range anyway (because otherwise the length would not be representable).
66 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
67 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
68 This avoids a GCC warning when WIDE_EMACS_INT.
69
70 * indent.c (sane_tab_width): New function.
71 (current_column, scan_for_column, Findent_to, position_indentation)
72 (compute_motion): Use it. This is just for clarity.
73 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
74
75 * image.c (xbm_image_p): Don't assume stated width and height fit in int.
76
77 * lisp.h (lint_assume): New macro.
78 * composite.c (composition_gstring_put_cache):
79 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
80
81 * editfns.c, insdel.c:
82 Omit unnecessary forward decls, to simplify future changes.
83
84 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
85
86 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
87
88 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
89 Use much-faster test for byte-length change.
90 Don't assume string byte-length fits in 'int'.
91 Check that character arg fits in 'int'.
92 (mapcar1): Declare byte as byte, for clarity.
93
94 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
95
96 * fns.c (concat): Catch string overflow earlier.
97 Do not rely on integer wraparound.
98
99 * dispextern.h (struct it.overlay_strings_charpos): EMACS_INT, not int.
100
101 2011-06-17 Paul Eggert <eggert@cs.ucla.edu>
102
103 * dispextern.h (struct it.selective): Now EMACS_INT, not int.
104 * xdisp.c (forward_to_next_line_start)
105 (back_to_previous_visible_line_start)
106 (reseat_at_next_visible_line_start, next_element_from_buffer):
107 Don't arbitrarily truncate the value of 'selective' to int.
108
109 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
110
111 * composite.c: Don't truncate sizes to 'int'.
112 (composition_gstring_p, composition_reseat_it)
113 (composition_adjust_point): Use EMACS_INT, not int.
114 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
115 not EMACS_UINT, for indexes.
116
117 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
118
119 * buffer.c: Include <verify.h>.
120 (struct sortvec.priority, struct sortstr.priority):
121 Now EMACS_INT, not int.
122 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
123 (struct sortstr.size, record_overlay_string)
124 (struct sortstrlist.size, struct sortlist.used):
125 Don't truncate size to int.
126 (record_overlay_string): Check for size-calculation overflow.
127 (init_buffer_once): Check at compile-time, not run-time.
128
129 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
130
131 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
132 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
133 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
134
135 Improve buffer-overflow checking (Bug#8873).
136 * fileio.c (Finsert_file_contents):
137 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
138 Remove the old (too-loose) buffer overflow checks.
139 They weren't needed, since make_gap checks for buffer overflow.
140 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
141 The old code merely checked for Emacs fixnum overflow, and relied
142 on undefined (wraparound) behavior. The new code avoids undefined
143 behavior, and also checks for ptrdiff_t and/or size_t overflow.
144
145 * editfns.c (Finsert_char): Don't dump core with very negative counts.
146 Tune. Don't use wider integers than needed. Don't use alloca.
147 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
148
149 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
150
151 * insdel.c, lisp.h (buffer_overflow): New function.
152 (insert_from_buffer_1, replace_range, replace_range_2):
153 * insdel.c (make_gap_larger):
154 * editfns.c (Finsert_char):
155 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
156
157 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
158
159 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
160
161 Integer overflow and signedness fixes (Bug#8873).
162
163 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
164 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
165
166 * fileio.c: Don't assume EMACS_INT fits in off_t.
167 (emacs_lseek): New static function.
168 (Finsert_file_contents, Fwrite_region): Use it.
169 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
170
171 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
172
173 * fns.c: Don't overflow int when computing a list length.
174 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
175 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
176 truncation on 64-bit hosts. Check for QUIT every
177 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
178 faster and is responsive enough.
179 (Flength): Report an error instead of overflowing an integer.
180 (Fsafe_length): Return a float if the value is not representable
181 as a fixnum. This shouldn't happen except in contrived situations.
182 (Fnthcdr, Fsort): Don't assume list length fits in int.
183 (Fcopy_sequence): Don't assume vector length fits in int.
184
185 * alloc.c: Check that resized vectors' lengths fit in fixnums.
186 (header_size, word_size): New constants.
187 (allocate_vectorlike): Don't check size overflow here.
188 (allocate_vector): Check it here instead, since this is the only
189 caller of allocate_vectorlike that could cause overflow.
190 Check that the new vector's length is representable as a fixnum.
191
192 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
193 The previous code was bogus. For example, next_almost_prime (32)
194 returned 39, which is undesirable as it is a multiple of 3; and
195 next_almost_prime (24) returned 25, which is a multiple of 5 so
196 why was the code bothering to check for multiples of 7?
197
198 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
199
200 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
201
202 Variadic C functions now count arguments with ptrdiff_t.
203 This partly undoes my 2011-03-30 change, which replaced int with size_t.
204 Back then I didn't know that the Emacs coding style prefers signed int.
205 Also, in the meantime I found a few more instances where arguments
206 were being counted with int, which may truncate counts on 64-bit
207 machines, or EMACS_INT, which may be unnecessarily wide.
208 * lisp.h (struct Lisp_Subr.function.aMANY)
209 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
210 Arg counts are now ptrdiff_t, not size_t.
211 All variadic functions and their callers changed accordingly.
212 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
213 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
214 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
215 * callint.c (Fcall_interactively): Check arg count for overflow,
216 to avoid potential buffer overrun. Use signed char, not 'int',
217 for 'varies' array, so that we needn't bother to check its size
218 calculation for overflow.
219 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
220 * eval.c (apply_lambda):
221 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
222 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
223 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
224
225 * callint.c (Fcall_interactively): Don't use index var as event count.
226
227 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
228 * mem-limits.h (SIZE): Remove; no longer used.
229
230 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
231
232 Remove unnecessary casts.
233 * xterm.c (x_term_init):
234 * xfns.c (x_set_border_pixel):
235 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
236 These aren't needed now that we assume ANSI C.
237
238 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
239 It's more likely to cause problems (due to unsigned overflow)
240 than to cure them.
241
242 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
243
244 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
245
246 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
247
248 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
249
250 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
251
252 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
253
254 GLYPH_CODE_FACE returns EMACS_INT, not int.
255 * dispextern.h (merge_faces):
256 * xfaces.c (merge_faces):
257 * xdisp.c (get_next_display_element, next_element_from_display_vector):
258 Don't assume EMACS_INT fits in int.
259
260 * character.h (CHAR_VALID_P): Remove unused parameter.
261 * fontset.c, lisp.h, xdisp.c: All uses changed.
262
263 * editfns.c (Ftranslate_region_internal): Omit redundant test.
264
265 * fns.c (concat): Minor tuning based on overflow analysis.
266 This doesn't fix any bugs. Use int to hold character, instead
267 of constantly refetching from Emacs object. Use XFASTINT, not
268 XINT, for value known to be a character. Don't bother comparing
269 a single byte to 0400, as it's always less.
270
271 * floatfns.c (Fexpt):
272 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
273
274 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
275 for characters.
276
277 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
278
279 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
280 Without this fix, on a 64-bit host (aset S 0 4294967386) would
281 incorrectly succeed when S was a string, because 4294967386 was
282 truncated before it was used.
283
284 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
285 Otherwise, an out-of-range integer could cause undefined behavior
286 on a 64-bit host.
287
288 * composite.c: Use int, not EMACS_INT, for characters.
289 (fill_gstring_body, composition_compute_stop_pos): Use int, not
290 EMACS_INT, for values that are known to be in character range.
291 This doesn't fix any bugs but is the usual style inside Emacs and
292 may generate better code on 32-bit machines.
293
294 Make sure a 64-bit char is never passed to ENCODE_CHAR.
295 This is for reasons similar to the recent CHAR_STRING fix.
296 * charset.c (Fencode_char): Check that character arg is actually
297 a character. Pass an int to ENCODE_CHAR.
298 * charset.h (ENCODE_CHAR): Verify that the character argument is no
299 wider than 'int', as a compile-time check to prevent future regressions
300 in this area.
301
302 * character.c (char_string): Remove unnecessary casts.
303
304 Make sure a 64-bit char is never passed to CHAR_STRING.
305 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
306 by silently ignoring the top 32 bits, allowing some values
307 that were far too large to be valid characters.
308 * character.h: Include <verify.h>.
309 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
310 arguments are no wider than unsigned, as a compile-time check
311 to prevent future regressions in this area.
312 * data.c (Faset):
313 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
314 (Fsubst_char_in_region):
315 * fns.c (concat):
316 * xdisp.c (decode_mode_spec_coding):
317 Adjust to CHAR_STRING's new requirement.
318 * editfns.c (Finsert_char, Fsubst_char_in_region):
319 * fns.c (concat): Check that character args are actually
320 characters. Without this test, these functions did the wrong
321 thing with wildly out-of-range values on 64-bit hosts.
322
323 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
324 These casts should not be needed on 32-bit hosts, either.
325 * keyboard.c (read_char):
326 * lread.c (Fload): Remove casts to unsigned.
327
328 * lisp.h (UNSIGNED_CMP): New macro.
329 This fixes comparison bugs on 64-bit hosts.
330 (ASCII_CHAR_P): Use it.
331 * casefiddle.c (casify_object):
332 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
333 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
334 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
335 * dispextern.h (FACE_FROM_ID):
336 * keyboard.c (read_char): Use UNSIGNED_CMP.
337
338 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
339 not to EMACS_INT, to avoid GCC warning.
340
341 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
342
343 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
344 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
345 isn't needed on 32-bit machines.
346
347 * buffer.c (Fgenerate_new_buffer_name):
348 Use EMACS_INT for count, not int.
349 (advance_to_char_boundary): Return EMACS_INT, not int.
350
351 * data.c (Qcompiled_function): Now static.
352
353 * window.c (window_body_lines): Now static.
354
355 * image.c (gif_load): Rename local to avoid shadowing.
356
357 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
358 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
359 * alloc.c (make_save_value): Integer argument is now of type
360 ptrdiff_t, not int.
361 (mark_object): Use ptrdiff_t, not int.
362 * lisp.h (pD): New macro.
363 * print.c (print_object): Use it.
364
365 * alloc.c: Use EMACS_INT, not int, to count objects.
366 (total_conses, total_markers, total_symbols, total_vector_size)
367 (total_free_conses, total_free_markers, total_free_symbols)
368 (total_free_floats, total_floats, total_free_intervals)
369 (total_intervals, total_strings, total_free_strings):
370 Now EMACS_INT, not int. All uses changed.
371 (Fgarbage_collect): Compute overall total using a double, so that
372 integer overflow is less likely to be a problem. Check for overflow
373 when converting back to an integer.
374 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
375 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
376 These were 'int' variables that could overflow on 64-bit hosts;
377 they were never used, so remove them instead of repairing them.
378 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
379 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
380 Previously, this ceilinged at INT_MAX, but that doesn't work on
381 64-bit machines.
382 (allocate_pseudovector): Don't use EMACS_INT when int would do.
383
384 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
385 (allocate_vectorlike): Check for ptrdiff_t overflow.
386 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
387 when a (possibly-narrower) signed value would do just as well.
388 We prefer using signed arithmetic, to avoid comparison confusion.
389
390 * alloc.c: Catch some string size overflows that we were missing.
391 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
392 for convenience in STRING_BYTES_MAX.
393 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
394 The definition here is exact; the one in lisp.h was approximate.
395 (allocate_string_data): Check for string overflow. This catches
396 some instances we weren't catching before. Also, it catches
397 size_t overflow on (unusual) hosts where SIZE_MAX <= min
398 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
399 and ptrdiff_t and EMACS_INT are both 64 bits.
400
401 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
402 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
403 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
404
405 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
406
407 * alloc.c (Fmake_string): Check for out-of-range init.
408
409 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
410
411 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
412
413 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
414
415 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
416 xg_get_default_scrollbar_width.
417
418 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
419 (int_gtk_range_get_value): Move to the scroll bar part of the file.
420 (style_changed_cb): Call update_theme_scrollbar_width and call
421 x_set_scroll_bar_default_width and xg_frame_set_char_size for
422 all frames (Bug#8505).
423 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
424 Call gtk_window_set_resizable if HAVE_GTK3.
425 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
426 and height if HAVE_GTK3 (Bug#8505).
427 (scroll_bar_width_for_theme): New variable.
428 (update_theme_scrollbar_width): New function.
429 (xg_get_default_scrollbar_width): Move code to
430 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
431 (xg_initialize): Call update_theme_scrollbar_width.
432
433 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
434
435 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
436
437 2011-06-12 Martin Rudalics <rudalics@gmx.at>
438
439 * frame.c (make_frame): Call other_buffer_safely instead of
440 other_buffer.
441
442 * window.c (temp_output_buffer_show): Call display_buffer with
443 second argument Vtemp_buffer_show_specifiers and reset latter
444 immediately after the call.
445 (Vtemp_buffer_show_specifiers): New variable.
446 (auto_window_vscroll_p, next_screen_context_lines)
447 (Vscroll_preserve_screen_position): Remove leading asterisks from
448 doc-strings.
449
450 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
451
452 Fix minor problems found by GCC 4.6.0 static checking.
453 * buffer.c (Qclone_number): Remove for now, as it's unused.
454 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
455 (record_buffer): Remove unused local.
456 * frame.c (other_visible_frames, frame_buffer_list): Now static.
457 (set_frame_buffer_list): Remove; unused.
458 * frame.h (other_visible_frames): Remove decl.
459 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
460 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
461 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
462 if HAVE_GPM.
463 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
464 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
465 Define only if HAVE_GPM.
466 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
467 (update_hints_inhibit): Remove; never set. All uses removed.
468 * widgetprv.h (emacsFrameClassRec): Remove decl.
469 * window.c (delete_deletable_window): Now returns void, since it
470 wasn't returning anything.
471 (compare_window_configurations): Remove unused locals.
472 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
473 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
474 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
475 the same widths as pointers. This follows up on the 2011-05-06 patch.
476 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
477 * xterm.h: Likewise.
478 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
479
480 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
481
482 * makefile.w32-in: Update dependencies.
483 (LISP_H): Add lib/intprops.h.
484
485 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
486
487 * image.c (gif_load): Add animation frame delay to the metadata.
488 (syms_of_image): Use DEFSYM. New symbol `delay'.
489
490 2011-06-11 Martin Rudalics <rudalics@gmx.at>
491
492 * window.c (delete_deletable_window): Re-add.
493 (Fset_window_configuration): Rewrite to handle dead buffers and
494 consequently deletable windows.
495 (window_tree, Fwindow_tree): Remove. Supply functionality in
496 window.el.
497 (compare_window_configurations): Simplify code.
498
499 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
500
501 * image.c (imagemagick_load_image): Fix type mismatch.
502 (Fimagemagick_types): Likewise.
503
504 * window.h (replace_buffer_in_windows): Declare.
505
506 2011-06-11 Martin Rudalics <rudalics@gmx.at>
507
508 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
509 Qclone_number. Remove external declaration of Qdelete_window.
510 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
511 code.
512 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
513 Qbuffer_list_update_hook if allowed.
514 (Fother_buffer): Rewrite doc-string. Major rewrite for new
515 buffer list implementation.
516 (other_buffer_safely): New function.
517 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
518 calls to replace_buffer_in_windows and
519 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
520 if allowed.
521 (record_buffer): Inhibit quitting and rewrite using quittable
522 functions. Run Qbuffer_list_update_hook if allowed.
523 (Frecord_buffer, Funrecord_buffer): New functions.
524 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
525 switch-to-buffer to window.el.
526 (bury-buffer): Move to window.el.
527 (Vbuffer_list_update_hook): New variable.
528
529 * lisp.h (other_buffer_safely): Add prototype in buffer.c
530 section.
531
532 * window.h (resize_frame_windows): Move up in code.
533 (Fwindow_frame): Remove EXFUN.
534 (replace_buffer_in_all_windows): Remove prototype.
535 (replace_buffer_in_windows_safely): Add prototype.
536
537 * window.c: Declare Qdelete_window static again. Move down
538 declaration of select_count.
539 (Fnext_window, Fprevious_window): Rewrite doc-strings.
540 (Fother_window): Move to window.el.
541 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
542 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
543 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
544 window.el.
545 (replace_buffer_in_windows): Implement by calling
546 Qreplace_buffer_in_windows.
547 (replace_buffer_in_all_windows): Remove with some functionality
548 moved into replace_buffer_in_windows_safely.
549 (replace_buffer_in_windows_safely): New function.
550 (select_window_norecord, select_frame_norecord): Move in front
551 of run_window_configuration_change_hook. Remove now obsolete
552 declarations.
553 (Fset_window_buffer): Rewrite doc-string. Call
554 Qrecord_window_buffer.
555 (keys_of_window): Move binding for other-window to window.el.
556
557 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
558
559 * dispextern.h (struct image): Replace data member, whose int_val
560 and ptr_val fields were not used by anything, with a single
561 lisp_val object.
562
563 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
564 (gif_clear_image, gif_load, imagemagick_load_image)
565 (gs_clear_image, gs_load): Callers changed.
566
567 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
568
569 * buffer.h: Include <time.h>, for time_t.
570 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
571
572 Fix minor problems found by static checking.
573
574 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
575
576 Make identifiers static if they are not used in other modules.
577 * data.c (Qcompiled_function, Qframe, Qvector):
578 * image.c (QimageMagick, Qsvg):
579 * minibuf.c (Qmetadata):
580 * window.c (resize_window_check, resize_root_window): Now static.
581 * window.h (resize_window_check, resize_root_window): Remove decls.
582
583 * window.c (window_deletion_count, delete_deletable_window):
584 Remove; unused.
585 (window_body_lines): Now static.
586 (Fdelete_other_windows_internal): Mark vars as initialized.
587 Make sure 'resize_failed' is initialized.
588 (run_window_configuration_change_hook): Rename local to avoid shadowing.
589 (resize_window_apply): Remove unused local.
590 * window.h (delete_deletable_window): Remove decl.
591
592 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
593 (imagemagick_load_image): Fix pointer signedness problem by changing
594 last arg from unsigned char * to char *. All uses changed.
595 Also, fix a local for similar reasons.
596 Remove unused locals. Remove locals to avoid shadowing.
597 (fn_rsvg_handle_free): Remove; unused.
598 (svg_load, svg_load_image): Fix pointer signedness problem.
599 (imagemagick_load_image): Don't use garbage pointer image_wand.
600
601 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
602
603 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
604
605 * image.c (gif_load): Fix omitted cast error introduced by
606 2011-06-06 change.
607
608 2011-06-10 Martin Rudalics <rudalics@gmx.at>
609
610 * window.h (resize_proportionally, orig_total_lines)
611 (orig_top_line): Remove from window structure.
612 (set_window_height, set_window_width, change_window_heights)
613 (Fdelete_window): Remove prototypes.
614 (resize_frame_windows): Remove duplicate declaration.
615
616 2011-06-10 Eli Zaretskii <eliz@gnu.org>
617
618 * window.h (resize_frame_windows, resize_window_check)
619 (delete_deletable_window, resize_root_window)
620 (resize_frame_windows): Declare prototypes.
621
622 * window.c (resize_window_apply): Make definition be "static" to
623 match the prototype.
624
625 2011-06-10 Martin Rudalics <rudalics@gmx.at>
626
627 * window.c: Remove declarations of Qwindow_size_fixed,
628 window_min_size_1, window_min_size_2, window_min_size,
629 size_window, window_fixed_size_p, enlarge_window, delete_window.
630 Remove static from declaration of Qdelete_window, it's
631 temporarily needed by Fbury_buffer.
632 (replace_window): Don't assign orig_top_line and
633 orig_total_lines.
634 (Fdelete_window, delete_window): Remove. Window deletion is
635 handled by window.el.
636 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
637 Fdelete_window calls with calls to Qdelete_window.
638 (Fdelete_other_windows): Remove. Deleting other windows is
639 handled by window.el.
640 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
641 handled in window.el.
642 (window_min_size_2, window_min_size_1, window_min_size): Remove.
643 Window minimum sizes are handled in window.el.
644 (shrink_windows, size_window, set_window_height)
645 (set_window_width, change_window_heights, window_height)
646 (window_width, CURBEG, CURSIZE, enlarge_window)
647 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
648 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
649 handled in window.el.
650 (make_dummy_parent): Rename to make_parent_window and give it a
651 second argument horflag.
652 (make_window): Don't set resize_proportionally any more.
653 (Fsplit_window): Remove. Windows are split in window.el.
654 (save_restore_action, save_restore_orig_size)
655 (shrink_window_lowest_first, save_restore_orig_size): Remove.
656 Resize mini windows in window.el.
657 (grow_mini_window, shrink_mini_window): Implement by calling
658 Qresize_root_window_vertically, resize_window_check and
659 resize_window_apply.
660 (saved_window, Fset_window_configuration, save_window_save): Do
661 not handle orig_top_line, orig_total_lines, and
662 resize_proportionally.
663 (window_min_height, window_min_width): Move to window.el.
664 (keys_of_window): Move bindings for delete-other-windows,
665 split-window, delete-window and enlarge-window to window.el.
666
667 * buffer.c: Temporarily extern Qdelete_window.
668 (Fbury_buffer): Temporarily call Qdelete_window instead of
669 Fdelete_window (Fbury_buffer will move to window.el soon).
670
671 * frame.c (set_menu_bar_lines_1): Remove code handling
672 orig_top_line and orig_total_lines.
673
674 * dispnew.c (adjust_frame_glyphs_initially): Don't use
675 set_window_height but set heights directly.
676 (change_frame_size_1): Use resize_frame_windows.
677
678 * xdisp.c (init_xdisp): Don't use set_window_height but set
679 heights directly.
680
681 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
682 resize_frame_windows instead of change_window_heights and run
683 run_window_configuration_change_hook.
684
685 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
686 instead of change_window_heights and run
687 run_window_configuration_change_hook.
688
689 2011-06-09 Martin Rudalics <rudalics@gmx.at>
690
691 * window.c (replace_window): Rename second argument REPLACEMENT to
692 NEW. New third argument SETFLAG. Rewrite.
693 (delete_window, make_dummy_parent): Call replace_window with
694 third argument 1.
695 (window_list_1): Move down in code.
696 (run_window_configuration_change_hook): Move set_buffer part
697 before select_frame_norecord part in order to unwind correctly.
698 Rename count1 to count.
699 (recombine_windows, delete_deletable_window, resize_root_window)
700 (Fdelete_other_windows_internal)
701 (Frun_window_configuration_change_hook, make_parent_window)
702 (resize_window_check, resize_window_apply, Fresize_window_apply)
703 (resize_frame_windows, Fsplit_window_internal)
704 (Fdelete_window_internal, Fresize_mini_window_internal): New
705 functions.
706 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
707
708 2011-06-08 Martin Rudalics <rudalics@gmx.at>
709
710 * window.h (window): Add some new members to window structure -
711 normal_lines, normal_cols, new_total, new_normal, clone_number,
712 splits, nest, prev_buffers, next_buffers.
713 (WINDOW_TOTAL_SIZE): Move here from window.c.
714 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
715
716 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
717 Remove.
718 (make_dummy_parent): Set new members of windows structure.
719 (make_window): Move down in code. Handle new members of window
720 structure.
721 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
722 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
723 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
724 (Fset_window_prev_buffers, Fwindow_next_buffers)
725 (Fset_window_next_buffers, Fset_window_clone_number): New
726 functions.
727 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
728 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
729 Doc-string fixes.
730 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
731 Argument WINDOW can be now internal window too.
732 (Fwindow_use_time): Move up in code.
733 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
734 Rewrite doc-string.
735 (Fset_window_configuration, saved_window)
736 (Fcurrent_window_configuration, save_window_save): Handle new
737 members of window structure.
738 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
739 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
740 (syms_of_window): New Lisp objects Qrecord_window_buffer,
741 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
742 Qget_mru_window, Qresize_root_window,
743 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
744 Qauto_buffer_name; staticpro them.
745
746 2011-06-07 Martin Rudalics <rudalics@gmx.at>
747
748 * window.c (Fwindow_total_size, Fwindow_left_column)
749 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
750 (Fwindow_list_1): New functions.
751 (window_box_text_cols): Replace with window_body_cols.
752 (Fwindow_width, Fscroll_left, Fscroll_right): Use
753 window_body_cols instead of window_box_text_cols.
754 (delete_window, Fset_window_configuration): Call
755 delete_all_subwindows with window as argument.
756 (delete_all_subwindows): Take a window as argument and not a
757 structure. Rewrite.
758 (window_loop): Remove handling of GET_LRU_WINDOW and
759 GET_LARGEST_WINDOW.
760 (Fget_lru_window, Fget_largest_window): Move to window.el.
761
762 * window.h: Extern window_body_cols instead of
763 window_box_text_cols. delete_all_subwindows now takes a
764 Lisp_Object as argument.
765
766 * indent.c (compute_motion, Fcompute_motion): Use
767 window_body_cols instead of window_box_text_cols.
768
769 * frame.c (delete_frame): Call delete_all_subwindows with root
770 window as argument.
771
772 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
773
774 * fns.c (Fputhash): Document return value.
775
776 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
777
778 * image.c (gif_load): Implement gif89a spec "no disposal" method.
779
780 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
781
782 Cons<->int and similar integer overflow fixes (Bug#8794).
783
784 Check for overflow when converting integer to cons and back.
785 * charset.c (Fdefine_charset_internal, Fdecode_char):
786 Use cons_to_unsigned to catch overflow.
787 (Fencode_char): Use INTEGER_TO_CONS.
788 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
789 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
790 * data.c (long_to_cons, cons_to_long): Remove.
791 (cons_to_unsigned, cons_to_signed): New functions.
792 These signal an error for invalid or out-of-range values.
793 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
794 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
795 * font.c (Ffont_variation_glyphs):
796 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
797 * lisp.h: Include <intprops.h>.
798 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
799 (cons_to_signed, cons_to_unsigned): New decls.
800 (long_to_cons, cons_to_long): Remove decls.
801 * undo.c (record_first_change): Use INTEGER_TO_CONS.
802 (Fprimitive_undo): Use CONS_TO_INTEGER.
803 * xfns.c (Fx_window_property): Likewise.
804 * xselect.c: Include <limits.h>.
805 (x_own_selection, selection_data_to_lisp_data):
806 Use INTEGER_TO_CONS.
807 (x_handle_selection_request, x_handle_selection_clear)
808 (x_get_foreign_selection, Fx_disown_selection_internal)
809 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
810 (lisp_data_to_selection_data): Use cons_to_unsigned.
811 (x_fill_property_data): Use cons_to_signed.
812 Report values out of range.
813
814 Check for buffer and string overflow more precisely.
815 * buffer.h (BUF_BYTES_MAX): New macro.
816 * lisp.h (STRING_BYTES_MAX): New macro.
817 * alloc.c (Fmake_string):
818 * character.c (string_escape_byte8):
819 * coding.c (coding_alloc_by_realloc):
820 * doprnt.c (doprnt):
821 * editfns.c (Fformat):
822 * eval.c (verror):
823 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
824 since they may not be the same number.
825 * editfns.c (Finsert_char):
826 * fileio.c (Finsert_file_contents):
827 Likewise for BUF_BYTES_MAX.
828
829 * image.c: Use ptrdiff_t, not int, for sizes.
830 (slurp_file): Switch from int to ptrdiff_t.
831 All uses changed.
832 (slurp_file): Check that file size fits in both size_t (for
833 malloc) and ptrdiff_t (for sanity and safety).
834
835 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
836 if b->modtime has its maximal value.
837
838 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
839
840 Don't assume time_t can fit into int.
841 * buffer.h (struct buffer.modtime): Now time_t, not int.
842 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
843 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
844
845 Minor fixes for signed vs unsigned integers.
846 * character.h (MAYBE_UNIFY_CHAR):
847 * charset.c (maybe_unify_char):
848 * keyboard.c (read_char, reorder_modifiers):
849 XINT -> XFASTINT, since the integer must be nonnegative.
850 * ftfont.c (ftfont_spec_pattern):
851 * keymap.c (access_keymap, silly_event_symbol_error):
852 XUINT -> XFASTINT, since the integer must be nonnegative.
853 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
854 since it makes no difference and we prefer signed.
855 * keyboard.c (record_char): Use XUINT when all the neighbors do.
856 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
857 nonnegative.
858
859 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
860
861 * window.h (Fwindow_frame): Declare.
862
863 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
864
865 * alloc.c: Simplify handling of large-request failures (Bug#8800).
866 (SPARE_MEMORY): Always define.
867 (LARGE_REQUEST): Remove.
868 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
869
870 2011-06-06 Martin Rudalics <rudalics@gmx.at>
871
872 * lisp.h: Move EXFUNS for Fframe_root_window,
873 Fframe_first_window and Fset_frame_selected_window to window.h.
874
875 * window.h: Move EXFUNS for Fframe_root_window,
876 Fframe_first_window and Fset_frame_selected_window here from
877 lisp.h.
878
879 * frame.c (Fwindow_frame, Fframe_first_window)
880 (Fframe_root_window, Fframe_selected_window)
881 (Fset_frame_selected_window): Move to window.c.
882 (Factive_minibuffer_window): Move to minibuf.c.
883 (Fother_visible_frames_p): New function.
884
885 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
886
887 * window.c (decode_window, decode_any_window): Move up in code.
888 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
889 (inhibit_frame_unsplittable): Remove unused variable.
890 (Fwindow_buffer): Move up and rewrite doc-string.
891 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
892 (Fwindow_prev): New functions.
893 (Fwindow_frame): Move here from frame.c. Accept any window as
894 argument.
895 (Fframe_root_window, Fframe_first_window)
896 (Fframe_selected_window): Move here from frame.c. Accept frame
897 or arbitrary window as argument. Update doc-strings.
898 (Fminibuffer_window): Move up in code.
899 (Fwindow_minibuffer_p): Move up in code and simplify.
900 (Fset_frame_selected_window): Move here from frame.c.
901 Marginal rewrite.
902 (Fselected_window, select_window, Fselect_window): Move up in
903 code. Minor doc-string fixes.
904
905 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
906
907 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
908 Do not assume that spare memory exists; that assumption is valid
909 only if SYSTEM_MALLOC.
910 (LARGE_REQUEST): New macro, so that the issue of large requests
911 is separated from the issue of spare memory.
912
913 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
914
915 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
916 format. (Bug#8806)
917
918 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
919
920 * xfns.c (x_set_scroll_bar_default_width): Move declarations
921 before statements.
922
923 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
924
925 * gtkutil.c (xg_get_default_scrollbar_width): New function.
926
927 * gtkutil.h: Declare xg_get_default_scrollbar_width.
928
929 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
930 min width by calling x_set_scroll_bar_default_width (Bug#8505).
931
932 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
933
934 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
935
936 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
937
938 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
939 (x_clipboard_manager_save): Add return value.
940 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
941 New error handlers.
942 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
943 Obey Vx_select_enable_clipboard_manager. Catch errors in
944 x_clipboard_manager_save (Bug#8779).
945 (Vx_select_enable_clipboard_manager): New variable.
946 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
947
948 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
949
950 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
951
952 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
953
954 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
955 in the current matrix if keep_current_p is non-zero.
956
957 2011-06-04 Eli Zaretskii <eliz@gnu.org>
958
959 * bidi.c (bidi_level_of_next_char): Fix last change.
960
961 2011-06-03 Eli Zaretskii <eliz@gnu.org>
962
963 Support bidi reordering of text covered by display properties.
964
965 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
966 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
967 (bidi_cache_search, bidi_cache_iterator_state)
968 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
969 (bidi_level_of_next_char, bidi_move_to_visually_next):
970 Support character positions inside a run of characters covered by a
971 display string.
972 (bidi_paragraph_init, bidi_resolve_explicit_1)
973 (bidi_level_of_next_char): Call bidi_fetch_char and
974 bidi_fetch_char_advance instead of FETCH_CHAR and
975 FETCH_CHAR_ADVANCE.
976 (bidi_init_it): Initialize new members.
977 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
978 definitions.
979 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
980 instead of using explicit *_CHAR codes.
981 (bidi_resolve_explicit, bidi_resolve_weak):
982 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
983 bidirectional text is supported only in multibyte buffers.
984 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
985 it to initialize the frame_window_p member of struct bidi_it.
986 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
987 (bidi_resolve_explicit, bidi_resolve_weak)
988 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
989 bidi_it->nchars is non-positive.
990 (bidi_level_of_next_char): Don't try to lookup the cache for the
991 next/previous character if nothing is cached there yet, or if we
992 were just reseat()'ed to a new position.
993
994 * xdisp.c (set_cursor_from_row): Set start and stop points
995 according to the row's direction when priming the loop that looks
996 for the glyph on which to display cursor.
997 (single_display_spec_intangible_p): Function deleted.
998 (display_prop_intangible_p): Reimplement to call
999 handle_display_spec instead of single_display_spec_intangible_p.
1000 Accept 3 additional arguments needed by handle_display_spec.
1001 This fixes incorrect cursor motion across display property with complex
1002 values: lists, `(when COND...)' forms, etc.
1003 (single_display_spec_string_p): Support property values that are
1004 lists with the argument STRING its top-level element.
1005 (display_prop_string_p): Fix the condition for processing a
1006 property that is a list to be consistent with handle_display_spec.
1007 (handle_display_spec): New function, refactored from the
1008 last portion of handle_display_prop.
1009 (compute_display_string_pos): Accept additional argument
1010 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1011 value of a `display' property is a "replacing spec".
1012 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1013 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1014 the display property, but just return a value indicating whether
1015 the display property will replace the characters it covers.
1016 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1017 frame_window_p members of struct bidi_it.
1018 (compute_display_string_pos, compute_display_string_end):
1019 New functions.
1020 (push_it): Accept second argument POSITION, where pop_it should
1021 jump to continue iteration.
1022 (reseat_1): Initialize bidi_it.disp_pos.
1023
1024 * keyboard.c (adjust_point_for_property): Adjust the call to
1025 display_prop_intangible_p to its new signature.
1026
1027 * dispextern.h (struct bidi_it): New member frame_window_p.
1028 (bidi_init_it): Update prototypes.
1029 (display_prop_intangible_p): Update prototype.
1030 (compute_display_string_pos, compute_display_string_end):
1031 Declare prototypes.
1032 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1033 EMACS_INT.
1034
1035 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1036
1037 Malloc failure behavior now depends on size of allocation.
1038 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1039 * lisp.h: Change signatures accordingly.
1040 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1041 All callers changed. (Bug#8762)
1042
1043 * gnutls.c: Use Emacs's memory allocators.
1044 Without this change, the gnutls library would invoke malloc etc.
1045 directly, which causes problems on non-SYNC_INPUT hosts, and which
1046 runs afoul of improving memory_full behavior. (Bug#8761)
1047 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1048 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1049 xfree instead of the default malloc, realloc, free.
1050 (Fgnutls_boot): No need to check for memory allocation failure,
1051 since xmalloc does that for us.
1052
1053 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1054 * category.c (hash_get_category_set):
1055 * ccl.c (ccl_driver):
1056 * charset.c (Fdefine_charset_internal):
1057 * charset.h (struct charset.hash_index):
1058 * composite.c (get_composition_id, gstring_lookup_cache)
1059 (composition_gstring_put_cache):
1060 * composite.h (struct composition.hash_index):
1061 * dispextern.h (struct image.hash):
1062 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1063 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1064 (hashfn_equal, hashfn_user_defined, make_hash_table)
1065 (maybe_resize_hash_table, hash_lookup, hash_put)
1066 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1067 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1068 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1069 * image.c (make_image, search_image_cache, lookup_image)
1070 (xpm_put_color_table_h):
1071 * lisp.h (struct Lisp_Hash_Table):
1072 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1073 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1074 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1075 * alloc.c (allocate_vectorlike):
1076 Check for overflow in vector size calculations.
1077 * ccl.c (ccl_driver):
1078 Check for overflow when converting EMACS_INT to int.
1079 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1080 need to be updated by these changes.
1081 * fns.c (make_hash_table, maybe_resize_hash_table):
1082 Check for integer overflow with large hash tables.
1083 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1084 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1085 (SXHASH_REDUCE): New macro.
1086 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1087 Use it instead of discarding useful hash info with large hash values.
1088 (sxhash_float): New function.
1089 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1090 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1091 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1092 Rewrite to use FIXNUM_BITS, as this simplifies things.
1093 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1094 Adjust signatures to match updated version of code.
1095 (consing_since_gc): Now EMACS_INT, since a single hash table can
1096 use more than INT_MAX bytes.
1097
1098 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1099
1100 Make it possible to build with GCC-4.6+ -O2 -flto.
1101
1102 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1103
1104 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1105
1106 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1107 Call minibuffer-inactive-mode.
1108
1109 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1110
1111 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1112 Update dependencies.
1113
1114 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1115
1116 * data.c (init_data): Remove code for UTS, this system is not
1117 supported anymore.
1118
1119 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1120
1121 Don't force ./temacs to start in terminal mode.
1122
1123 * frame.c (make_initial_frame): Initialize faces in all cases, not
1124 only when CANNOT_DUMP is defined.
1125 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1126
1127 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1128
1129 * dispnew.c (add_window_display_history): Use const for the string
1130 pointer. Remove declaration, not needed.
1131
1132 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1133
1134 Use 'inline', not 'INLINE'.
1135 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1136 * alloc.c, fontset.c (INLINE): Remove.
1137 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1138 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1139 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1140 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1141 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1142
1143 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1144
1145 Make it possible to run ./temacs.
1146
1147 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1148 syms_of_callproc does the same thing. Remove test for
1149 "initialized", do it in the caller.
1150 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1151
1152 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1153
1154 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1155 (read_minibuf): Use get_minibuffer.
1156 (syms_of_minibuf): Use DEFSYM.
1157 (Qmetadata): New var.
1158 * data.c (Qbuffer): Don't make it static.
1159 (syms_of_data): Use DEFSYM.
1160
1161 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1162
1163 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1164 (CCL_CODE_MIN): New macro.
1165
1166 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1167
1168 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1169
1170 * eval.c (Qdebug): Now static.
1171 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1172 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1173 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1174
1175 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1176
1177 * image.c: Various fixes to ImageMagick code comments.
1178 (Fimagemagick_types): Doc fix.
1179
1180 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1181
1182 Minor fixes prompted by GCC 4.6.0 warnings.
1183
1184 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1185
1186 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1187 (x_clipboard_manager_save_all): Move extern decl to ...
1188 * xterm.h: ... here, so that it can be checked for consistency.
1189
1190 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1191
1192 * xselect.c (x_clipboard_manager_save_frame)
1193 (x_clipboard_manager_save_all): New functions.
1194 (Fx_clipboard_manager_save): Lisp function deleted.
1195
1196 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1197 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1198
1199 * xterm.h: Update prototype.
1200
1201 2011-05-28 William Xu <william.xwl@gmail.com>
1202
1203 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1204 exiting (Bug#8239).
1205
1206 2011-05-28 Jim Meyering <meyering@redhat.com>
1207
1208 Avoid a sign-extension bug in crypto_hash_function.
1209 * fns.c (to_uchar): Define.
1210 (crypto_hash_function): Use it to convert some newly-signed
1211 variables to unsigned, to avoid sign-extension bugs. For example,
1212 without this change, (md5 "truc") would evaluate to
1213 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1214 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1215 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1216
1217 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1218
1219 Integer overflow fixes.
1220
1221 * dbusbind.c: Serial number integer overflow fixes.
1222 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1223 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1224 to hold a serial number that is too large for a fixnum.
1225 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1226 Check for serial numbers out of range. Decode any serial number
1227 that was so large that it became a float. (Bug#8722)
1228
1229 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1230 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1231 Use XFASTINT rather than XUINT when numbers are nonnegative.
1232 (xd_append_arg, Fdbus_method_return_internal):
1233 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1234 arguments, check that Lisp number is nonnegative, rather than
1235 silently wrapping negative numbers around. (Bug#8722)
1236 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1237 (Bug#8722)
1238
1239 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1240
1241 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1242
1243 ccl: add integer overflow checks
1244 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1245 (IN_INT_RANGE): New macros.
1246 (ccl_driver): Use them to check for integer overflow when
1247 decoding a CCL program. Many of the new checks are whether XINT (x)
1248 fits in int; it doesn't always, on 64-bit hosts. The new version
1249 doesn't catch all possible integer overflows, but it's an
1250 improvement. (Bug#8719)
1251
1252 * alloc.c (make_event_array): Use XINT, not XUINT.
1253 There's no need for unsigned here.
1254
1255 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1256 This follows up to the 2011-05-06 change that substituted uintptr_t
1257 for EMACS_INT. This case wasn't caught back then.
1258
1259 Rework Fformat to avoid integer overflow issues.
1260 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1261 now (part of C89). Include <verify.h>.
1262 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1263 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1264 (Fformat): Avoid the prepass trying to compute sizes; it was only
1265 approximate and thus did not catch overflow reliably. Instead, walk
1266 through the format just once, formatting and computing sizes as we go,
1267 checking for integer overflow at every step, and allocating a larger
1268 buffer as needed. Keep track separately whether the format is
1269 multibyte. Keep only the most-recently calculated precision, rather
1270 than them all. Record whether each argument has been converted to
1271 string. Use EMACS_INT, not int, for byte and char and arg counts.
1272 Support field widths and precisions larger than INT_MAX. Avoid
1273 sprintf's undefined behavior with conversion specifications such as %#d
1274 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1275 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1276 formatting out-of-range floating point numbers with int
1277 formats. (Bug#8668)
1278
1279 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1280
1281 * data.c: Avoid integer truncation in expressions involving floats.
1282 * data.c: Include <intprops.h>.
1283 (arith_driver): When there's an integer overflow in an expression
1284 involving floating point, convert the integers to floating point
1285 so that the resulting value does not suffer from catastrophic
1286 integer truncation. For example, on a 64-bit host (* 4
1287 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1288 Do not rely on undefined behavior after integer overflow.
1289
1290 merge count_size_as_multibyte, parse_str_to_multibyte
1291 * character.c, character.h (count_size_as_multibyte):
1292 Rename from parse_str_to_multibyte; all uses changed.
1293 Check for integer overflow.
1294 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1295 since it's now a duplicate of the other. This is more of
1296 a character than a buffer op, so better that it's in character.c.
1297 * fns.c, print.c: Adjust to above changes.
1298
1299 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1300
1301 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1302
1303 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1304
1305 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1306 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1307 (x_clipboard_manager_save): Now static.
1308 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1309
1310 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1311 (crypto_hash_function): Now static.
1312 Fix pointer signedness problems. Avoid unnecessary initializations.
1313
1314 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1315
1316 * termhooks.h (Vselection_alist): Make it terminal-local.
1317
1318 * terminal.c (create_terminal): Initialize it.
1319
1320 * xselect.c: Support for clipboard managers.
1321 (Vselection_alist): Move to termhooks.h as terminal-local var.
1322 (LOCAL_SELECTION): New macro.
1323 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1324 (symbol_to_x_atom): Remove gratuitous arg.
1325 (x_handle_selection_request, lisp_data_to_selection_data)
1326 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1327 (x_own_selection, x_get_local_selection, x_convert_selection):
1328 New arg, specifying work frame. Use terminal-local Vselection_alist.
1329 (some_frame_on_display): Delete unused function.
1330 (Fx_own_selection_internal, Fx_get_selection_internal)
1331 (Fx_disown_selection_internal, Fx_selection_owner_p)
1332 (Fx_selection_exists_p): New optional frame arg.
1333 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1334 (x_handle_selection_clear): Don't treat other terminals with the
1335 same keyboard specially. Use the terminal-local Vselection_alist.
1336 (x_clear_frame_selections): Use Frun_hook_with_args.
1337
1338 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1339
1340 * xterm.h: Add support for those atoms.
1341
1342 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1343
1344 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1345 (converted_selections, conversion_fail_tag): New global variables.
1346 (x_selection_request_lisp_error): Free the above.
1347 (x_get_local_selection): Remove unnecessary code.
1348 (x_reply_selection_request): Args changed; handle arbitrary array
1349 of converted selections stored in converted_selections.
1350 Separate the XChangeProperty and SelectionNotify steps.
1351 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1352 (x_convert_selection): New function.
1353 (x_handle_selection_event): Simplify.
1354 (x_get_foreign_selection): Don't ignore incoming requests while
1355 waiting for an answer; this will fail when we implement
1356 SAVE_TARGETS, and seems unnecessary anyway.
1357 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1358 (Vx_sent_selection_functions): Doc fix.
1359
1360 2011-05-26 Leo Liu <sdl.web@gmail.com>
1361
1362 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1363
1364 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1365
1366 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1367
1368 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1369 for fringe update if it has periodic bitmap.
1370 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1371 and fringe_bitmap_periodic_p.
1372
1373 * fringe.c (get_fringe_bitmap_data): New function.
1374 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1375 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1376 row. Mark glyph row for fringe update if periodicity changed.
1377
1378 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1379 for fringe update unless it has periodic bitmap.
1380
1381 2011-05-25 Kenichi Handa <handa@m17n.org>
1382
1383 * xdisp.c (get_next_display_element): Set correct it->face_id for
1384 a static composition.
1385
1386 2011-05-24 Leo Liu <sdl.web@gmail.com>
1387
1388 * deps.mk (fns.o):
1389 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1390
1391 * fns.c (crypto_hash_function, Fsha1): New function.
1392 (Fmd5): Use crypto_hash_function.
1393 (syms_of_fns): Add Ssha1.
1394
1395 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1396
1397 * gnutls.c: Remove unused macros.
1398 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1399 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1400 Remove macros that are defined and never used.
1401 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1402
1403 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1404
1405 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1406 (Fx_get_selection_internal): Minor cleanup.
1407 (Fx_own_selection_internal): Rename arguments for consistency with
1408 select.el.
1409
1410 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1411
1412 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1413
1414 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1415
1416 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1417
1418 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1419
1420 * dispnew.c (scrolling_window): Don't exclude the case that the
1421 last enabled row in the desired matrix touches the bottom boundary.
1422
1423 2011-05-21 Glenn Morris <rgm@gnu.org>
1424
1425 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1426 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1427 and add some more files.
1428
1429 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1430
1431 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1432 report_file_error introduced by the change from 2011-05-07.
1433
1434 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1435
1436 * systime.h (Time): Define only if emacs is defined.
1437 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1438 where the include path doesn't have X11/X.h by default. See
1439 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1440
1441 2011-05-20 Kenichi Handa <handa@m17n.org>
1442
1443 * composite.c (find_automatic_composition): Fix previous change.
1444
1445 2011-05-20 Glenn Morris <rgm@gnu.org>
1446
1447 * lisp.mk: New file, split from Makefile.in.
1448 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1449 (shortlisp): Remove.
1450 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1451
1452 2011-05-19 Glenn Morris <rgm@gnu.org>
1453
1454 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1455 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1456 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1457 (lisp): Set the order to that of loadup.el.
1458 (shortlisp): Make it a copy of $lisp.
1459 (SOME_MACHINE_LISP): Remove.
1460 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1461 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1462
1463 2011-05-18 Kenichi Handa <handa@m17n.org>
1464
1465 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1466 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1467 (find_automatic_composition): Mostly rewrite for efficiency.
1468
1469 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1470
1471 * makefile.w32-in: Update dependencies.
1472
1473 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1474
1475 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1476 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1477
1478 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1479
1480 Fix some integer overflow issues, such as string length overflow.
1481
1482 * insdel.c (count_size_as_multibyte): Check for string overflow.
1483
1484 * character.c (lisp_string_width): Check for string overflow.
1485 Use EMACS_INT, not int, for string indexes and lengths; in
1486 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1487 the resulting string length overflows an EMACS_INT; instead,
1488 report a string overflow if no precision given. When checking for
1489 precision exhaustion, use a check that cannot possibly have
1490 integer overflow. (Bug#8675)
1491 * character.h (lisp_string_width): Adjust to new signature.
1492
1493 * alloc.c (string_overflow): New function.
1494 (Fmake_string): Use it. This doesn't change behavior, but saves
1495 a few bytes and will simplify future changes.
1496 * character.c (string_escape_byte8): Likewise.
1497 * lisp.h (string_overflow): New decl.
1498
1499 Fixups, following up to the user-interface timestamp change.
1500 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1501 for UI timestamps, instead of unsigned long.
1502 * msdos.c (mouse_get_pos): Likewise.
1503 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1504 * w32gui.h (Time): Define by including "systime.h" rather than by
1505 declaring it ourselves. (Bug#8664)
1506
1507 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1508 * image.c (clear_image_cache): Likewise.
1509
1510 * term.c (term_mouse_position): Don't assume time_t wraparound.
1511
1512 Be more systematic about user-interface timestamps.
1513 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1514 and sometimes 'EMACS_UINT', to represent these timestamps.
1515 This change causes it to use 'Time' uniformly, as that's what X uses.
1516 This makes the code easier to follow, and makes it easier to catch
1517 integer overflow bugs such as Bug#8664.
1518 * frame.c (Fmouse_position, Fmouse_pixel_position):
1519 Use Time, not unsigned long, for user-interface timestamps.
1520 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1521 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1522 * keyboard.h (last_event_timestamp): Likewise.
1523 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1524 * menu.h (xmenu_show): Likewise.
1525 * term.c (term_mouse_position): Likewise.
1526 * termhooks.h (struct input_event.timestamp): Likewise.
1527 (struct terminal.mouse_position_hook): Likewise.
1528 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1529 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1530 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1531 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1532 what it was before.
1533 * menu.h, termhooks.h: Include "systime.h", for Time.
1534
1535 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1536 Don't assume that the difference between two unsigned long values
1537 can fit into an integer. At this point, we know button_down_time
1538 <= event->timestamp, so the difference must be nonnegative, so
1539 there's no need to cast the result if double-click-time is
1540 nonnegative, as it should be; check that it's nonnegative, just in
1541 case. This bug is triggered when events are more than 2**31 ms
1542 apart (about 25 days). (Bug#8664)
1543
1544 * xselect.c (last_event_timestamp): Remove duplicate decl.
1545 (x_own_selection): Remove needless cast to unsigned long.
1546
1547 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1548 that always fit in int. Use a sentinel instead of a counter, to
1549 avoid a temp and to allay GCC's concerns about possible int overflow.
1550 * frame.h (struct frame): Use int for menu_bar_items_used
1551 instead of EMACS_INT, since it always fits in int.
1552
1553 * menu.c (grow_menu_items): Check for int overflow.
1554
1555 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1556
1557 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1558 Before, the code was not consistent. These values cannot exceed
1559 2**31 - 1 so there's no need to make them unsigned.
1560 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1561 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1562 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1563 as modifiers.
1564 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1565
1566 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1567 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1568 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1569 presumably because the widths might not match.
1570
1571 * window.c (size_window): Avoid needless test at loop start.
1572
1573 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1574
1575 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1576
1577 2011-05-12 Drew Adams <drew.adams@oracle.com>
1578
1579 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1580
1581 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1582
1583 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1584 `width' to `bar_area_x' and `bar_area_width', respectively.
1585 (x_scroll_run): Take account of fringe background extension.
1586
1587 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1588 Rename local vars `left' and `width' to `bar_area_x' and
1589 `bar_area_width', respectively.
1590 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1591 background extension.
1592
1593 2011-05-10 Jim Meyering <meyering@redhat.com>
1594
1595 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1596
1597 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1598
1599 * image.c (Finit_image_library): Return t for built-in image types,
1600 like pbm and xbm. (Bug#8640)
1601
1602 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1603
1604 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1605
1606 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1607
1608 * w32console.c (Fset_screen_color): Doc fix.
1609 (Fget_screen_color): New function.
1610 (syms_of_ntterm): Defsubr it.
1611
1612 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1613 unlink the temporary file if Fcall_process didn't create it in the
1614 first place.
1615 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1616 child process will be redirected to a file specified with `:file'.
1617 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1618 cue to call_process_cleanup not to close that handle.
1619
1620 2011-05-07 Ben Key <bkey76@gmail.com>
1621
1622 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1623 one of two shell specific rules, either bootstrap-temacs-CMD or
1624 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1625 to the previous implementation of the bootstrap-temacs rule.
1626 The bootstrap-temacs-CMD rule is similar to the previous
1627 implementation of the bootstrap-temacs rule except that it
1628 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1629 variable.
1630
1631 These changes, along with some changes to nt/configure.bat,
1632 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1633 earlier fix to add support for --cflags and --ldflags options
1634 that include quotes so that it works whether make uses cmd or
1635 sh as the shell.
1636
1637 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1638
1639 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1640 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1641 is a constant.
1642 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1643 a string. Handle both cases.
1644 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1645 (Fdbus_register_method): Use Qinvalid_function.
1646
1647 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1648
1649 * makefile.w32-in: Update dependencies.
1650 (LISP_H): Add inttypes.h and stdin.h.
1651 (PROCESS_H): Add unistd.h.
1652
1653 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1654
1655 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1656 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1657
1658 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1659
1660 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1661
1662 * term.c (vfatal): Remove stray call to va_end.
1663 It's not needed and the C Standard doesn't allow it here anyway.
1664
1665 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1666 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1667
1668 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1669 bytes.
1670
1671 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1672
1673 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1674
1675 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1676
1677 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1678
1679 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1680
1681 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1682 * charset.c (Fdefine_charset_internal): Don't initialize
1683 charset.code_space[15]. The value was garbage, on hosts with
1684 32-bit int (Bug#8600).
1685
1686 * lread.c (read_integer): Be more consistent with string-to-number.
1687 Use string_to_number to do the actual conversion; this avoids
1688 rounding errors and fixes some other screwups. Without this fix,
1689 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1690 (digit_to_number): Move earlier, for benefit of read_integer.
1691 Return -1 if the digit is out of range for the base, -2 if it is
1692 not a digit in any supported base. (Bug#8602)
1693
1694 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1695
1696 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1697 to match comment at start of function. This also removes a
1698 GCC warning about overflow in a 32+64-bit port.
1699
1700 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1701
1702 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1703 Reported by Stefan Monnier in
1704 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1705 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1706 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1707
1708 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1709 (EMACS_UINTPTR): Likewise, with uintptr_t.
1710
1711 * lisp.h: Prefer 64-bit EMACS_INT if available.
1712 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1713 on 32-bit hosts that have 64-bit int, so that they can access
1714 large files.
1715 However, temporarily disable this change unless the temporary
1716 symbol WIDE_EMACS_INT is defined.
1717
1718 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1719
1720 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1721 This removes an assumption that EMACS_INT and long are the same
1722 width as pointers. The assumption is true for Emacs porting targets
1723 now, but we want to make other targets possible.
1724 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1725 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1726 In the rest of the code, change types of integers that hold casted
1727 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1728 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1729 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1730 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1731 No need to cast type when ORing.
1732 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1733 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1734 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1735 assume EMACS_INT is the same width as char *.
1736 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1737 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1738 Remove no-longer-needed casts.
1739 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1740 (xg_tool_bar_help_callback, xg_make_tool_item):
1741 Use EMACS_INTPTR to hold an integer
1742 that will be cast to void *; this can avoid a GCC warning
1743 if EMACS_INT is not the same width as void *.
1744 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1745 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1746 (current_message_1, set_message_1):
1747 Use a local to convert to proper width without a cast.
1748 * xmenu.c (dialog_selection_callback): Likewise.
1749
1750 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1751 Also, don't assume VALBITS / RAND_BITS is less than 5,
1752 and don't rely on undefined behavior when shifting a 1 left into
1753 the sign bit.
1754 * lisp.h (get_random): Change signature to match.
1755
1756 * lread.c (hash_string): Use size_t, not int, for hash computation.
1757 Normally we prefer signed values; but hashing is special, because
1758 it's better to use unsigned division on hash table sizes so that
1759 the remainder is nonnegative. Also, size_t is the natural width
1760 for hashing into memory. The previous code used 'int', which doesn't
1761 retain enough info to hash well into very large tables.
1762 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1763
1764 * dbusbind.c: Don't possibly lose pointer info when converting.
1765 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1766 Use XPNTR rather than XHASH, so that the high-order bits of
1767 the pointer aren't lost when converting through void *.
1768
1769 * eval.c (Fautoload): Don't double-shift a pointer.
1770
1771 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1772
1773 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1774
1775 * gnutls.c (DEF_GNUTLS_FN):
1776 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1777
1778 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1779
1780 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1781 marker. (Bug#8610)
1782
1783 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1784
1785 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1786 New version that can reserve upto 2GB of heap space.
1787
1788 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1789
1790 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1791
1792 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1793
1794 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1795 `gnutls_certificate_set_x509_key_file'.
1796
1797 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1798
1799 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1800 Update dependencies.
1801
1802 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1803
1804 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1805 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1806 Remove unused parameter `fildes'.
1807 * process.c (read_process_output, send_process): Don't pass it.
1808
1809 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1810
1811 Fix previous change: the library cache is defined in w32.c.
1812 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1813 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1814
1815 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1816
1817 Implement dynamic loading of GnuTLS on Windows.
1818
1819 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1820 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1821 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1822 Declare.
1823
1824 * gnutls.c (Qgnutls_dll): Define.
1825 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1826 (gnutls_*): Declare function pointers.
1827 (init_gnutls_functions): New function to initialize function pointers.
1828 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1829 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1830 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1831 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1832 (emacs_gnutls_write, emacs_gnutls_read)
1833 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1834 (Fgnutls_available_p): New function.
1835 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1836 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1837 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1838
1839 * image.c: Include w32.h.
1840 (Vimage_type_cache): Delete.
1841 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1842 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1843 (w32_delayed_load): Move to w32.c.
1844
1845 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1846
1847 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1848 (w32_delayed_load): Move from image.c. When loading a library, record
1849 its filename in the :loaded-from property of the library id.
1850 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1851 Initialize and staticpro them.
1852 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1853
1854 * process.c: Include lisp.h before w32.h, not after.
1855 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1856 instead of gnutls_record_check_pending.
1857
1858 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1859
1860 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1861
1862 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1863 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1864 as passed in.
1865
1866 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1867
1868 * xterm.c (x_set_frame_alpha): Do not set property on anything
1869 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1870
1871 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1872
1873 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1874
1875 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1876
1877 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1878 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1879 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1880 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1881 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1882 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1883 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1884 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1885 (Qgnutls_bootprop_callbacks_verify): Make static.
1886
1887 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1888
1889 * callproc.c: Indentation fixup.
1890
1891 * sysdep.c (wait_for_termination_1): Make static.
1892 (wait_for_termination, interruptible_wait_for_termination):
1893 Move after wait_for_termination_1.
1894
1895 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1896
1897 * sysdep.c (interruptible_wait_for_termination): New function
1898 which is like wait_for_termination, but allows keyboard
1899 interruptions.
1900
1901 * callproc.c (Fcall_process): Add (:file "file") as an option for
1902 the STDOUT buffer.
1903 (Fcall_process_region): Ditto.
1904
1905 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1906
1907 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1908 rather than `XVECTOR (FOO)->size'.
1909
1910 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1911 inttypes.h, as a gnulib replacement is used if it not available in
1912 system headers.
1913
1914 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1915
1916 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1917 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1918 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1919
1920 * coding.c (coding_alloc_by_realloc): Error out if destination
1921 will grow beyond MOST_POSITIVE_FIXNUM.
1922 (decode_coding_emacs_mule): Abort if there isn't enough place in
1923 charbuf for the composition carryover bytes. Reserve an extra
1924 space for up to 2 characters produced in a loop.
1925 (decode_coding_iso_2022): Abort if there isn't enough place in
1926 charbuf for the composition carryover bytes.
1927
1928 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1929
1930 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1931 aborting when %lld or %lll format is passed.
1932 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1933 %llo or %llx format is passed. (Bug#8545)
1934
1935 * window.c (window_scroll_line_based): Use a marker instead of
1936 simple variables to record original value of point. (Bug#7952)
1937
1938 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1939 produced by %s or %c overflows available buffer space. (Bug#8545)
1940
1941 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1942
1943 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1944 (SIZE_MAX): Move defn after all includes, as they might #define it.
1945
1946 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1947
1948 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1949
1950 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1951
1952 * keyboard.c (Qdelayed_warnings_hook): Define.
1953 (command_loop_1): Run `delayed-warnings-hook'
1954 if Vdelayed_warnings_list is non-nil.
1955 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1956 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1957
1958 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1959
1960 * doprnt.c (doprnt): Don't return value smaller than the buffer
1961 size if the message was truncated. (Bug#8545).
1962
1963 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1964
1965 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1966 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1967
1968 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1969
1970 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1971
1972 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1973
1974 * makefile.w32-in: Update dependencies.
1975
1976 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1977
1978 Improve `doprnt' and its usage. (Bug#8545)
1979 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1980 `format_end'. Remove support for %l as a conversion specifier.
1981 Don't use xrealloc. Improve diagnostics when the %l size modifier
1982 is used. Update the commentary.
1983
1984 * eval.c (verror): Simplify calculation of size_t.
1985
1986 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1987 messages.
1988
1989 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1990
1991 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1992 change.
1993
1994 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1995
1996 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1997 This makes this file independent of the recent pseudovector change.
1998
1999 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2000
2001 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2002
2003 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2004 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2005 Remove unused local.
2006 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2007
2008 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2009 GCC 4.6.0 optimizes based on type-based alias analysis.
2010 For example, if b is of type struct buffer * and v of type struct
2011 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2012 != &v->size, and therefore "v->size = 1; b->size = 2; return
2013 v->size;" must therefore return 1. This assumption is incorrect
2014 for Emacs, since it type-puns struct Lisp_Vector * with many other
2015 types. To fix this problem, this patch adds a new type struct
2016 vectorlike_header that documents the constraints on layout of vectors
2017 and pseudovectors, and helps optimizing compilers not get fooled
2018 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2019 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2020 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2021 the size member.
2022 (XSETPVECTYPE): Rewrite in terms of new macro.
2023 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2024 This is a bit clearer, and further avoids the possibility of
2025 undesirable aliasing.
2026 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2027 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2028 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2029 since Lisp_Subr is a special case (no "next" field).
2030 (ASIZE): Now uses header.size rather than size.
2031 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2032 to avoid the hassle of writing XVECTOR (foo)->header.size.
2033 (struct vectorlike_header): New type.
2034 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2035 object, to help avoid aliasing.
2036 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2037 (SUBRP): Likewise, since Lisp_Subr is a special case.
2038 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2039 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2040 (struct Lisp_Hash_Table): Combine first two members into a single
2041 struct vectorlike_header member. All uses of "size" and "next" members
2042 changed to be "header.size" and "header.next".
2043 * buffer.h (struct buffer): Likewise.
2044 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2045 * frame.h (struct frame): Likewise.
2046 * process.h (struct Lisp_Process): Likewise.
2047 * termhooks.h (struct terminal): Likewise.
2048 * window.c (struct save_window_data, struct saved_window): Likewise.
2049 * window.h (struct window): Likewise.
2050 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2051 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2052 * buffer.c (init_buffer_once): Likewise.
2053 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2054 special case.
2055 * process.c (Fformat_network_address): Use local var for size,
2056 for brevity.
2057
2058 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2059
2060 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2061 * data.c (atof): Remove decl; no longer used or needed.
2062 (digit_to_number): Move to lread.c.
2063 (Fstring_to_number): Use new string_to_number function, to be
2064 consistent with how the Lisp reader treats infinities and NaNs.
2065 Do not assume that floating-point numbers represent EMACS_INT
2066 without losing information; this is not true on most 64-bit hosts.
2067 Avoid double-rounding errors, by insisting on integers when
2068 parsing non-base-10 numbers, as the documentation specifies.
2069 * lisp.h (string_to_number): New decl, replacing ...
2070 (isfloat_string): Remove.
2071 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2072 (read1): Do not accept +. and -. as integers; this
2073 appears to have been a coding error. Similarly, do not accept
2074 strings like +-1e0 as floating point numbers. Do not report
2075 overflow for integer overflows unless the base is not 10 which
2076 means we have no simple and reliable way to continue.
2077 Break out the floating-point parsing into a new
2078 function string_to_number, so that Fstring_to_number parses
2079 floating point numbers consistently with the Lisp reader.
2080 (digit_to_number): Move here from data.c. Make it static inline.
2081 (E_CHAR, EXP_INT): Remove, replacing with ...
2082 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2083 (string_to_number): New function, replacing isfloat_string.
2084 This function checks for valid syntax and produces the resulting
2085 Lisp float number too. Rework it so that string-to-number
2086 no longer mishandles examples like "1.0e+". Use strtoumax,
2087 so that overflow for non-base-10 numbers is reported only when
2088 there's no portable and simple way to convert to floating point.
2089
2090 * textprop.c (set_text_properties_1): Rewrite for clarity,
2091 and to avoid GCC warning about integer overflow.
2092
2093 * intervals.h (struct interval): Use EMACS_INT for members
2094 where EMACS_UINT might cause problems. See
2095 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2096 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2097 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2098 All uses changed.
2099 (offset_intervals): Tell GCC not to worry about length overflow
2100 when negating a negative length.
2101
2102 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2103 (overrun_check_free): Likewise.
2104
2105 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2106 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2107 word size.
2108
2109 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2110 (gnutls_make_error): Rename local to avoid shadowing.
2111 (gnutls_emacs_global_deinit): ifdef out; not used.
2112 (Fgnutls_boot): Use const for pointer to readonly storage.
2113 Comment out unused local. Fix pointer signedness problems.
2114
2115 * lread.c (openp): Don't stuff size_t into an 'int'.
2116 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2117 about possible signed overflow.
2118
2119 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2120 (GDK_KEY_g): Don't define if already defined.
2121 (xg_prepare_tooltip): Avoid pointer signedness problem.
2122 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2123
2124 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2125 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2126
2127 * xfns.c (Fx_window_property): Simplify a bit,
2128 to make a bit faster and to avoid GCC 4.6.0 warning.
2129 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2130
2131 * fns.c (internal_equal): Don't assume size_t fits in int.
2132
2133 * alloc.c (compact_small_strings): Tighten assertion a little.
2134
2135 Replace pEd with more-general pI, and fix some printf arg casts.
2136 * lisp.h (pI): New macro, generalizing old pEd macro to other
2137 conversion specifiers. For example, use "...%"pI"d..." rather
2138 than "...%"pEd"...".
2139 (pEd): Remove. All uses replaced with similar uses of pI.
2140 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2141 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2142 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2143 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2144 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2145 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2146 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2147 64-bit hosts.
2148 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2149 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2150 * print.c (safe_debug_print, print_object): Likewise.
2151 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2152 to int.
2153 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2154 avoiding the 0 flag, which is not portable.
2155 * process.c (Fmake_network_process): Use pI to avoid cast.
2156 * region-cache.c (pp_cache): Likewise.
2157 * xdisp.c (decode_mode_spec): Likewise.
2158 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2159 behavior on 64-bit hosts with printf arg.
2160 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2161 (x_stop_queuing_selection_requests): Likewise.
2162 (x_get_window_property): Don't truncate byte count to an 'int'
2163 when tracing.
2164
2165 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2166 here, since it parses constructs like leading '-' and spaces,
2167 which are not wanted; and it overflows with large numbers.
2168 Instead, simply match F[0-9]+, which is what is wanted anyway.
2169
2170 * alloc.c: Remove unportable assumptions about struct layout.
2171 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2172 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2173 (allocate_vectorlike, make_pure_vector): Use the new macros,
2174 plus offsetof, to remove unportable assumptions about struct layout.
2175 These assumptions hold on all porting targets that I know of, but
2176 they are not guaranteed, they're easy to remove, and removing them
2177 makes further changes easier.
2178
2179 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2180 This doesn't fix a bug but makes the code clearer.
2181 (string_overrun_cookie): Now const. Use initializers that
2182 don't formally overflow signed char, to avoid warnings.
2183 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2184 can cause Emacs to crash when string overrun checking is enabled.
2185 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2186 multiple of sizeof (EMACS_INT); it need not be, if
2187 alignof(EMACS_INT) < sizeof (EMACS_INT).
2188 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2189
2190 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2191
2192 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2193
2194 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2195
2196 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2197 supposed to be handshaking. (Bug#8556)
2198 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2199
2200 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2201
2202 * lisp.h (Qdebug): List symbol.
2203 * eval.c (Qdebug): Restore global linkage.
2204 * keyboard.c (debug-on-event): New variable.
2205 (handle_user_signal): Break into debugger when debug-on-event
2206 matches the current signal symbol.
2207
2208 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2209
2210 * alloc.c (check_sblock, check_string_bytes)
2211 (check_string_free_list): Convert to standard C.
2212
2213 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2214
2215 * w32.c (emacs_gnutls_push): Fix typo.
2216
2217 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2218
2219 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2220 "cast to pointer from integer of different size".
2221
2222 Improve doprnt and its use in verror. (Bug#8545)
2223 * doprnt.c (doprnt): Document the set of format control sequences
2224 supported by the function. Use SAFE_ALLOCA instead of always
2225 using `alloca'.
2226
2227 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2228 is one byte too soon. Don't use xrealloc; instead xfree and
2229 xmalloc anew.
2230
2231 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2232
2233 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2234 callbacks stage.
2235
2236 * gnutls.c: Renamed global_initialized to
2237 gnutls_global_initialized. Added internals for the
2238 :verify-hostname-error, :verify-error, and :verify-flags
2239 parameters of `gnutls-boot' and documented those parameters in the
2240 docstring. Start callback support.
2241 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2242 unless a fatal error occured. Call gnutls_alert_send_appropriate
2243 on error. Return error code.
2244 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2245 (emacs_gnutls_read): Likewise.
2246 (Fgnutls_boot): Return handshake error code.
2247 (emacs_gnutls_handle_error): New function.
2248 (wsaerror_to_errno): Likewise.
2249
2250 * w32.h (emacs_gnutls_pull): Add prototype.
2251 (emacs_gnutls_push): Likewise.
2252
2253 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2254 (emacs_gnutls_push): Likewise.
2255
2256 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2257
2258 * process.c (wait_reading_process_output): Check if GnuTLS
2259 buffered some data internally if no FDs are set for TLS
2260 connections.
2261
2262 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2263 (LIBS): Link to USER_LIBS.
2264 ($(BLD)/gnutls.$(0)): New target.
2265
2266 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2267
2268 * xdisp.c (handle_single_display_spec): Rename the
2269 display_replaced_before_p argument into display_replaced_p, to
2270 make it consistent with the commentary. Fix typos in the
2271 commentary.
2272
2273 * textprop.c (syms_of_textprop): Remove dead code.
2274 (copy_text_properties): Delete obsolete commentary about an
2275 interface that was deleted long ago. Fix typos in the description
2276 of arguments.
2277
2278 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2279 to changes in oldXMenu/XMenu.h from 2011-04-16.
2280 <menu_help_message, prev_menu_help_message>: Constify.
2281 (IT_menu_make_room): menu->help_text is now `const char **';
2282 adjust.
2283
2284 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2285 to changes in oldXMenu/XMenu.h from 2011-04-16.
2286 (struct XMenu): Declare `help_text' `const char **'.
2287
2288 * xfaces.c <Qunspecified>: Make extern again.
2289
2290 * syntax.c: Include sys/types.h before including regex.h, as
2291 required by Posix.
2292
2293 * doc.c (get_doc_string): Improve the format passed to `error'.
2294
2295 * doprnt.c (doprnt): Improve commentary.
2296
2297 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2298
2299 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2300 them with etags.
2301
2302 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2303 changes in globals.h immediately force recompilation.
2304 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2305 $(CURDIR)/s/ms-w32.h.
2306 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2307
2308 * character.c (Fchar_direction): Function deleted.
2309 (syms_of_character): Don't defsubr it.
2310 <char-direction-table>: Deleted.
2311
2312 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2313
2314 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2315 * doprnt.c: Include limits.h.
2316 (SIZE_MAX): New macro.
2317 (doprnt): Return a size_t value. 2nd arg is now size_t.
2318 Many local variables are now size_t instead of int or unsigned.
2319 Improve overflow protection. Support `l' modifier for integer
2320 conversions. Support %l conversion. Don't assume an EMACS_INT
2321 argument for integer conversions and for %c.
2322
2323 * lisp.h (doprnt): Restore prototype.
2324
2325 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2326 $(SRC)/character.h.
2327
2328 * Makefile.in (base_obj): Add back doprnt.o.
2329
2330 * deps.mk (doprnt.o): Add back prerequisites.
2331 (callint.o): Depend on character.h.
2332
2333 * eval.c (internal_lisp_condition_case): Include the handler
2334 representation in the error message.
2335 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2336 when breaking from the loop.
2337
2338 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2339
2340 * callint.c (Fcall_interactively): When displaying error message
2341 about invalid control letter, pass the character's codepoint, not
2342 a pointer to its multibyte form. Improve display of the character
2343 in octal and display also its hex code.
2344
2345 * character.c (char_string): Use %x to display the (unsigned)
2346 codepoint of an invalid character, to avoid displaying a bogus
2347 negative value.
2348
2349 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2350 `error', not SYMBOL_NAME itself.
2351
2352 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2353 character arguments to `error'.
2354
2355 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2356 to `error' in error message about FINAL_CHAR argument. Make sure
2357 FINAL_CHAR is a character, and use %c when it is passed as
2358 argument to `error'.
2359
2360 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2361
2362 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2363
2364 * w32.c: Include <time.h>.
2365 (sys_localtime): New function.
2366
2367 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2368
2369 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2370
2371 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2372
2373 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2374
2375 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2376 zombies (Bug#8467).
2377
2378 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2379
2380 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2381 gl_state.e_property when gl_state.object is Qt.
2382
2383 * insdel.c (make_gap_larger): Remove limitation of buffer size
2384 to <= INT_MAX.
2385
2386 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2387
2388 * xdisp.c (lookup_glyphless_char_display)
2389 (produce_glyphless_glyph): Handle cons cell entry in
2390 glyphless-char-display.
2391 (Vglyphless_char_display): Document it.
2392
2393 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2394 glyphless-char-display.
2395
2396 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2397
2398 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2399
2400 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2401
2402 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2403 definition for no-X builds.
2404
2405 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2406
2407 Static checks with GCC 4.6.0 and non-default toolkits.
2408
2409 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2410
2411 * process.c (keyboard_bit_set): Define only if SIGIO.
2412 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2413 (send_process): Repair possible setjmp clobbering.
2414
2415 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2416
2417 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2418
2419 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2420
2421 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2422 Define only if needed.
2423
2424 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2425 by pacifying GCC about it. Maybe it's time to retire it?
2426 * xfaces.c (USG, __TIMEVAL__): Likewise.
2427
2428 * dispextern.h (struct redisplay_interface): Rename param
2429 to avoid shadowing.
2430 * termhooks.h (struct terminal): Likewise.
2431 * xterm.c (xembed_send_message): Likewise.
2432
2433 * insdel.c (make_gap_smaller): Define only if
2434 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2435
2436 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2437 it.
2438
2439 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2440 so that we aren't warned about unused symbols.
2441
2442 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2443
2444 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2445
2446 * xfns.c (x_real_positions): Mark locals as initialized.
2447
2448 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2449
2450 * xterm.c: Fix problems found by static analysis with other toolkits.
2451 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2452 (x_dispatch_event): Declare static if USE_GTK, and
2453 define if USE_GTK || USE_X_TOOLKIT.
2454 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2455 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2456 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2457 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2458
2459 * xmenu.c (menu_help_callback): Pointer type fixes.
2460 Use const pointers when pointing at readonly data. Avoid pointer
2461 signedness clashes.
2462 (FALSE): Remove unused macro.
2463 (update_frame_menubar): Remove unused decl.
2464
2465 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2466
2467 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2468 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2469 (single_menu_item): Rename local to avoid shadowing.
2470
2471 * keyboard.c (make_lispy_event): Remove unused local var.
2472
2473 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2474 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2475
2476 * bitmaps: Change bitmaps from unsigned char back to the X11
2477 compatible char. Avoid the old compiler warnings about
2478 out-of-range initializers by using, for example, '\xab' rather
2479 than 0xab.
2480
2481 * xgselect.c (xgselect_initialize): Check vs interface
2482 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2483
2484 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2485
2486 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2487 to read-only memory.
2488
2489 * fns.c (vector): Remove; this old hack is no longer needed.
2490
2491 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2492 Remove unused var.
2493 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2494
2495 * xrdb.c (x_load_resources): Omit unused local.
2496
2497 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2498 (x_window): Rename locals to avoid shadowing.
2499 (USG): Use the kludged USG macro, to pacify gcc.
2500
2501 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2502 (x_term_init): Remove local to avoid shadowing.
2503
2504 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2505
2506 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2507 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2508
2509 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2510
2511 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2512
2513 Fix regex.c, syntax.c and friends for buffers > 2GB.
2514 * syntax.h (struct gl_state_s): Declare character position members
2515 EMACS_INT.
2516
2517 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2518
2519 * textprop.c (verify_interval_modification, interval_of):
2520 Declare arguments EMACS_INT.
2521
2522 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2523 EMACS_INT.
2524
2525 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2526
2527 * indent.c (Fvertical_motion): Local variable it_start is now
2528 EMACS_INT.
2529
2530 * regex.c (re_match, re_match_2, re_match_2_internal)
2531 (bcmp_translate, regcomp, regexec, print_double_string)
2532 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2533 (re_compile_pattern, re_exec): Declare arguments and local
2534 variables `size_t' and `ssize_t' and return values `regoff_t', as
2535 appropriate.
2536 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2537 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2538 <compile_stack_type>: `size' and `avail' are now `size_t'.
2539
2540 * regex.h <regoff_t>: Use ssize_t, not int.
2541 (re_search, re_search_2, re_match, re_match_2): Arguments that
2542 specify buffer/string position and length are now ssize_t and
2543 size_t. Return type is regoff_t.
2544
2545 2011-04-16 Ben Key <bkey76@gmail.com>
2546
2547 * nsfont.m: Fixed bugs in ns_get_family and
2548 ns_descriptor_to_entity that were caused by using free to
2549 deallocate memory blocks that were allocated by xmalloc (via
2550 xstrdup). This caused Emacs to crash when compiled with
2551 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2552 --enable-checking=xmallocoverrun). xfree is now used to
2553 deallocate these memory blocks.
2554
2555 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2556
2557 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2558
2559 emacs_write: Accept and return EMACS_INT for sizes.
2560 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2561 et seq.
2562 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2563 Accept and return EMACS_INT.
2564 (emacs_gnutls_write): Return the number of bytes written on
2565 partial writes.
2566 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2567 (emacs_read, emacs_write): Remove check for negative size, as the
2568 Emacs source code has been audited now.
2569 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2570 (emacs_read, emacs_write): Use it.
2571 * process.c (send_process): Adjust to the new signatures of
2572 emacs_write and emacs_gnutls_write. Do not attempt to store
2573 a byte offset into an 'int'; it might overflow.
2574 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2575
2576 * sound.c: Don't assume sizes fit in 'int'.
2577 (struct sound_device.period_size, alsa_period_size):
2578 Return EMACS_INT, not int.
2579 (struct sound_device.write, vox_write, alsa_write):
2580 Accept EMACS_INT, not int.
2581 (wav_play, au_play): Use EMACS_INT to store sizes and to
2582 record read return values.
2583
2584 2011-04-15 Ben Key <bkey76@gmail.com>
2585
2586 * keyboard.c (Qundefined): Don't declare static since it is used
2587 in nsfns.m.
2588 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2589 static since they are used in nsfont.m.
2590
2591 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2592
2593 * process.c (Qprocessp): Don't declare static.
2594 * lisp.h (Qprocessp): Declare again.
2595
2596 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2597
2598 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2599
2600 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2601
2602 Improve C-level modularity by making more things 'static'.
2603
2604 Don't publish debugger-only interfaces to other modules.
2605 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2606 (verify_bytepos, count_markers): Move decls to the only modules
2607 that need them.
2608 * region-cache.h (pp_cache): Likewise.
2609 * window.h (check_all_windows): Likewise.
2610 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2611
2612 * sysdep.c (croak): Now static, if
2613 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2614 * syssignal.h (croak): Declare only if not static.
2615
2616 * alloc.c (refill_memory_reserve): Now static if
2617 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2618 * lisp.h (refill_memory_reserve): Declare only if not static.
2619
2620 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2621 Define only if USE_LUCID.
2622
2623 * xrdb.c (x_customization_string, x_rm_string): Now static.
2624
2625 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2626 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2627
2628 * xdisp.c (draw_row_with_mouse_face): Now static.
2629 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2630
2631 * window.h (check_all_windows): Mark externally visible.
2632
2633 * window.c (window_deletion_count): Now static.
2634
2635 * undo.c: Make symbols static if they're not exported.
2636 (last_undo_buffer, last_boundary_position, pending_boundary):
2637 Now static.
2638
2639 * textprop.c (interval_insert_behind_hooks): Now static.
2640 (interval_insert_in_front_hooks): Likewise.
2641
2642 * term.c: Make symbols static if they're not exported.
2643 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2644 (max_frame_lines, tty_set_terminal_modes):
2645 (tty_reset_terminal_modes, tty_turn_off_highlight):
2646 (get_tty_terminal): Now static.
2647 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2648 * termhooks.h (term_mouse_moveto): Do not declare if
2649 HAVE_WINDOW_SYSTEM.
2650 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2651 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2652
2653 * sysdep.c: Make symbols static if they're not exported.
2654 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2655 Now static.
2656 (sigprocmask_set, full_mask): Remove; unused.
2657 (wait_debugging): Mark as visible.
2658 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2659 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2660
2661 * syntax.c (syntax_temp): Define only if !__GNUC__.
2662
2663 * sound.c (current_sound_device, current_sound): Now static.
2664
2665 * search.c (searchbufs, searchbuf_head): Now static.
2666
2667 * scroll.c (scroll_cost): Remove; unused.
2668 * dispextern.h (scroll_cost): Remove decl.
2669
2670 * region-cache.h (pp_cache): Mark as externally visible.
2671
2672 * process.c: Make symbols static if they're not exported.
2673 (process_tick, update_tick, create_process, chan_process):
2674 (Vprocess_alist, proc_buffered_char, datagram_access):
2675 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2676 (deactivate_process): Mark defn as static, as well as decl.
2677 * lisp.h (create_process): Remove decl.
2678 * process.h (chan_process, Vprocess_alist): Remove decls.
2679
2680 * print.c: Make symbols static if they're not exported.
2681 (print_depth, new_backquote_output, being_printed, print_buffer):
2682 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2683 (print_interval, print_number_index, initial_stderr_stream):
2684 Now static.
2685 * lisp.h (Fprinc): Remove decl.
2686 (debug_output_compilation_hack): Mark as externally visible.
2687
2688 * sysdep.c (croak): Move decl from here to syssignal.h.
2689 * syssignal.h (croak): Put it here, so the API can be checked when
2690 'croak' is called from dissociate_if_controlling_tty.
2691
2692 * minibuf.c: Make symbols static if they're not exported.
2693 (minibuf_save_list, choose_minibuf_frame): Now static.
2694 * lisp.h (choose_minibuf_frame): Remove decl.
2695
2696 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2697
2698 * lread.c: Make symbols static if they're not exported.
2699 (read_objects, initial_obarray, oblookup_last_bucket_number):
2700 Now static.
2701 (make_symbol): Remove; unused.
2702 * lisp.h (initial_obarray, make_symbol): Remove decls.
2703
2704 * keyboard.c: Make symbols static if they're not exported.
2705 (single_kboard, recent_keys_index, total_keys, recent_keys):
2706 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2707 (this_single_command_key_start, echoing, last_auto_save):
2708 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2709 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2710 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2711 (Vlispy_mouse_stem, double_click_count):
2712 Now static.
2713 (force_auto_save_soon): Define only if SIGDANGER.
2714 (ignore_mouse_drag_p): Now static if
2715 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2716 (print_help): Remove; unused.
2717 (stop_character, last_timer_event): Mark as externally visible.
2718 * keyboard.h (ignore_mouse_drag_p): Declare only if
2719 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2720 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2721 * lisp.h (echoing): Remove decl.
2722 (force_auto_save_soon): Declare only if SIGDANGER.
2723 * xdisp.c (redisplay_window): Simplify code, to make it more
2724 obvious that ignore_mouse_drag_p is not accessed if !defined
2725 USE_GTK && !defined HAVE_NS.
2726
2727 * intervals.c: Make symbols static if they're not exported.
2728 (merge_properties_sticky, merge_interval_right, delete_interval):
2729 Now static.
2730 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2731
2732 * insdel.c: Make symbols static if they're not exported.
2733 However, leave prepare_to_modify_buffer alone. It's never
2734 called from outside this function, but that appears to be a bug.
2735 (combine_after_change_list, combine_after_change_buffer):
2736 (adjust_after_replace, signal_before_change): Now static.
2737 (adjust_after_replace_noundo): Remove; unused.
2738 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2739 (signal_before_change): Remove decls.
2740
2741 * indent.c (val_compute_motion, val_vmotion): Now static.
2742
2743 * image.c: Make symbols static if they're not exported.
2744 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2745 if USE_GTK.
2746 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2747 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2748
2749 * fringe.c (standard_bitmaps): Now static.
2750 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2751
2752 * frame.c: Make symbols static if they're not exported.
2753 (x_report_frame_params, make_terminal_frame): Now static.
2754 (get_frame_param): Now static, unless HAVE_NS.
2755 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2756 (x_get_resource_string): Remove; not used.
2757 * frame.h (make_terminal_frame, x_report_frame_params):
2758 (x_get_resource_string); Remove decls.
2759 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2760 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2761
2762 * font.c, fontset.c: Make symbols static if they're not exported.
2763 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2764 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2765 * font.c (font_close_object): Now static.
2766 * font.h (font_close_object): Remove.
2767 * fontset.c (FONTSET_OBJLIST): Remove.
2768 (free_realized_fontset) #if-0 the body, which does nothing.
2769 (face_suitable_for_char_p): #if-0, as it's never called.
2770 * fontset.h (face_suitable_for_char_p): Remove decl.
2771 * xfaces.c (face_at_string_position):
2772 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2773 since 0 is always ASCII.
2774
2775 * fns.c (weak_hash_tables): Now static.
2776
2777 * fileio.c: Make symbols static if they're not exported.
2778 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2779 (Vwrite_region_annotation_buffers): Now static.
2780
2781 * eval.c: Make symbols static if they're not exported.
2782 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2783 * lisp.h (backtrace_list): Remove decl.
2784
2785 * emacs.c: Make symbols static if they're not exported.
2786 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2787 (fatal_error_code, fatal_error_signal_hook, standard_args):
2788 Now static.
2789 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2790 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2791 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2792 * lisp.h (fatal_error_signal_hook): Remove decl.
2793 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2794
2795 * editfns.c: Move a (normally-unused) function to its only use.
2796 * editfns.c, lisp.h (get_operating_system_release): Remove.
2797 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2798 worth the hassle of breaking this out.
2799
2800 * xterm.c: Make symbols static if they're not exported.
2801 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2802 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2803 (x_destroy_window, x_delete_display):
2804 Now static.
2805 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2806 (x_mouse_leave): Remove; unused.
2807 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2808 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2809 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2810 Remove decls.
2811 (x_mouse_leave): Declare only if WINDOWSNT.
2812 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2813 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2814 USE_X_TOOLKIT.
2815
2816 * ftxfont.c: Make symbols static if they're not exported.
2817 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2818 HAVE_FREETYPE.
2819 * font.h (ftxfont_driver): Likewise.
2820
2821 * xfns.c: Make symbols static if they're not exported.
2822 (x_last_font_name, x_display_info_for_name):
2823 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2824 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2825 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2826 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2827 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2828 (last_show_tip_args): Now static.
2829 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2830 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2831 (x_screen_planes): Remove; unused.
2832 * dispextern.h (x_screen_planes): Remove decl.
2833
2834 * dispnew.c: Make symbols static if they're not exported.
2835 * dispextern.h (redraw_garbaged_frames, scrolling):
2836 (increment_row_positions): Remove.
2837 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2838 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2839 Now static.
2840 (redraw_garbaged_frames): Remove; unused.
2841
2842 * xfaces.c: Make symbols static if they're not exported.
2843 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2844 Remove decls.
2845 * xterm.h (defined_color): Remove decls.
2846 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2847 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2848 (menu_face_changed_default, defined_color, free_realized_face):
2849 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2850 (ascii_face_of_lisp_face): Remove; unused.
2851
2852 * xdisp.c: Make symbols static if they're not exported.
2853 * dispextern.h (scratch_glyph_row, window_box_edges):
2854 (glyph_to_pixel_coords, set_cursor_from_row):
2855 (get_next_display_element, set_iterator_to_next):
2856 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2857 (show_mouse_face): Remove decls
2858 * frame.h (message_buf_print): Likewise.
2859 * lisp.h (pop_message, set_message, check_point_in_composition):
2860 Likewise.
2861 * xterm.h (set_vertical_scroll_bar): Likewise.
2862 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2863 (message_buf_print, scratch_glyph_row, displayed_buffer):
2864 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2865 (get_next_display_element, show_mouse_face, window_box_edges):
2866 (frame_to_window_pixel_xy, check_point_in_composition):
2867 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2868 (glyph_to_pixel_coords): Remove; unused.
2869
2870 * dired.c (file_name_completion): Now static.
2871
2872 * dbusbind.c (xd_in_read_queued_messages): Now static.
2873
2874 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2875 * data.c (circular_list_error): Remove.
2876
2877 * commands.h (last_point_position, last_point_position_buffer):
2878 (last_point_position_window): Remove decls.
2879 * keyboard.c: Make these variables static.
2880
2881 * coding.h (coding, code_convert_region, encode_coding_gap):
2882 Remove decls.
2883 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2884 (iso_code_class, detect_coding, code_convert_region): Now static.
2885 (encode_coding_gap): Remove; unused.
2886
2887 * chartab.c (chartab_chars, chartab_bits): Now static.
2888
2889 * charset.h (charset_iso_8859_1): Remove decl.
2890 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2891 Now static.
2892
2893 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2894 * ccl.c (Vccl_program_table): Now static.
2895 (check_ccl_update): Remove; unused.
2896
2897 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2898 * category.h: ... from here.
2899 * category.c (check_category_table, set_category_set): Now static.
2900
2901 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2902 * lisp.h: Remove these decls.
2903
2904 * buffer.c (buffer_count): Remove unused var.
2905
2906 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2907 so that it's not optimized away.
2908 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2909 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2910 exported only to the debugger.
2911
2912 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2913 * atimer.h (run_all_atimers): Remove; not exported.
2914
2915 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2916 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2917 was inaccessible from Lisp.
2918 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2919 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2920
2921 alloc.c: Import and export fewer symbols, and remove unused items.
2922 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2923 is defined.
2924 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2925 it's not optimized away by whole-program optimization.
2926 (message_enable_multibyte, free_misc): Remove.
2927 (catchlist, handlerlist, mark_backtrace):
2928 Declare only if BYTE_MARK_STACK.
2929 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2930 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2931 (message_enable_multibyte): Remove decl.
2932 (free_misc, interval_free_list, float_block, float_block_index):
2933 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2934 (cons_free_list, last_marked_index):
2935 Now static.
2936 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2937 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2938 (mark_backtrace): Define only if BYTE_MARK_STACK.
2939 * xdisp.c (message_enable_multibyte): Now static.
2940
2941 Declare Lisp_Object Q* variables to be 'static' if not exported.
2942 This makes it easier for human readers (and static analyzers)
2943 to see whether these variables are used from other modules.
2944 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2945 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2946 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2947 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2948 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2949 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2950 * xmenu.c, xselect.c:
2951 Declare Q* vars static if they are not used in other modules.
2952 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2953 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2954 Remove decls of unexported vars.
2955 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2956
2957 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2958
2959 Make Emacs functions such as Fatom 'static' by default.
2960 This makes it easier for human readers (and static analyzers)
2961 to see whether these functions can be called from other modules.
2962 DEFUN now defines a static function. To make the function external
2963 so that it can be used in other C modules, use the new macro DEFUE.
2964 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2965 (Finit_image_library):
2966 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2967 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2968 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2969 Remove decls, since these functions are now static.
2970 (Funintern, Fget_internal_run_time): New decls, since these functions
2971 were already external.
2972
2973 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2974 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2975 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2976 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2977 * keyboard.c, keymap.c, lread.c:
2978 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2979 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2980 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2981 Mark functions with DEFUE instead of DEFUN,
2982 if they are used in other modules.
2983 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2984 decls for now-static functions.
2985 * buffer.h (Fdelete_overlay): Remove decl.
2986 * callproc.c (Fgetenv_internal): Mark as internal.
2987 * composite.c (Fremove_list_of_text_properties): Remove decl.
2988 (Fcomposition_get_gstring): New forward static decl.
2989 * composite.h (Fcomposite_get_gstring): Remove decl.
2990 * dired.c (Ffile_attributes): New forward static decl.
2991 * doc.c (Fdocumntation_property): New forward static decl.
2992 * eval.c (Ffetch_bytecode): New forward static decl.
2993 (Funintern): Remove extern decl; now in .h file where it belongs.
2994 * fileio.c (Fmake_symbolic_link): New forward static decl.
2995 * image.c (Finit_image_library): New forward static decl.
2996 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2997 * intervals.h (Fprevious_property_change):
2998 (Fremove_list_of_text_properties): Remove decls.
2999 * keyboard.c (Fthis_command_keys): Remove decl.
3000 (Fcommand_execute): New forward static decl.
3001 * keymap.c (Flookup_key): New forward static decl.
3002 (Fcopy_keymap): Now static.
3003 * keymap.h (Flookup_key): Remove decl.
3004 * process.c (Fget_process): New forward static decl.
3005 (Fprocess_datagram_address): Mark as internal.
3006 * syntax.c (Fsyntax_table_p): New forward static decl.
3007 (skip_chars): Remove duplicate decl.
3008 * textprop.c (Fprevious_property_change): New forward static decl.
3009 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3010 Now internal.
3011 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3012 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3013
3014 * editfns.c (Fformat): Remove unreachable code.
3015
3016 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3017
3018 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3019 change. (Bug#8496)
3020
3021 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3022
3023 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3024 when at ZV. (Bug#8487)
3025
3026 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3027
3028 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3029 (Bug#8437)
3030 * keyboard.c (parse_tool_bar_item): Likewise.
3031 * sound.c (sound_cleanup, alsa_close): Likewise.
3032 * termcap.c (tgetent): Likewise.
3033 * xfns.c (x_default_font_parameter): Likewise.
3034 * xsettings.c (read_and_apply_settings): Likewise.
3035
3036 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3037 (overrun_check_free): Protoize.
3038
3039 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3040
3041 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3042 since callers should never pass a negative size.
3043 Change the signature to match that of plain 'read' and 'write'; see
3044 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3045 * lisp.h: Update prototypes of emacs_write and emacs_read.
3046
3047 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3048
3049 * xdisp.c (redisplay_window): Don't try to determine the character
3050 position of the scroll margin if the window start point w->startp
3051 is outside the buffer's accessible region. (Bug#8468)
3052
3053 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3054
3055 Fix write-region and its subroutines for buffers > 2GB.
3056 * fileio.c (a_write, e_write): Modify declaration of arguments and
3057 local variables to support buffers larger than 2GB.
3058 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3059
3060 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3061 argument, local variables, and return value.
3062
3063 * lisp.h: Update prototypes of emacs_write and emacs_read.
3064
3065 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3066
3067 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3068
3069 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3070
3071 Fix more problems found by GCC 4.6.0's static checks.
3072
3073 * xdisp.c (vmessage): Use a better test for character truncation.
3074
3075 * charset.c (load_charset_map): <, not <=, for optimization,
3076 and to avoid potential problems with integer overflow.
3077 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3078 * casetab.c (set_identity, shuffle): Likewise.
3079 * editfns.c (Fformat): Likewise.
3080 * syntax.c (skip_chars): Likewise.
3081
3082 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3083 This also lets GCC 4.6.0 generate slightly better loop code.
3084
3085 * callint.c (Fcall_interactively): <, not <=, for optimization.
3086 (Fcall_interactively): Count the number of arguments produced,
3087 not the number of arguments given. This is simpler and lets GCC
3088 4.6.0 generate slightly better code.
3089
3090 * ftfont.c: Distingish more carefully between FcChar8 and char.
3091 The previous code passed unsigned char * to a functions like
3092 strlen and xstrcasecmp that expect char *, which does not
3093 conform to the C standard.
3094 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3095 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3096 char * when the C standard requires it.
3097
3098 * keyboard.c (read_char): Remove unused var.
3099
3100 * eval.c: Port to Windows vsnprintf (Bug#8435).
3101 Include <limits.h>.
3102 (SIZE_MAX): Define if the headers do not.
3103 (verror): Do not give up if vsnprintf returns a negative count.
3104 Instead, grow the buffer. This ports to Windows vsnprintf, which
3105 does not conform to C99. Problem reported by Eli Zaretskii.
3106 Also, simplify the allocation scheme, by avoiding the need for
3107 calling realloc, and removing the ALLOCATED variable.
3108
3109 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3110
3111 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3112 But keep the doprint source code for now, as we might revamp it
3113 and use it again (Bug#8435).
3114 * lisp.h (doprnt): Remove.
3115 * Makefile.in (base_obj): Remove doprnt.o.
3116 * deps.mk (doprnt.o): Remove.
3117
3118 error: Print 32- and 64-bit integers portably (Bug#8435).
3119 Without this change, on typical 64-bit hosts error ("...%d...", N)
3120 was used to print both 32- and 64-bit integers N, which relied on
3121 undefined behavior.
3122 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3123 New macro.
3124 * lisp.h (error, verror): Mark as printf-like functions.
3125 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3126 Report overflow in size calculations when allocating printf buffer.
3127 Do not truncate output string at its first null byte.
3128 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3129 Truncate the output at a character boundary, since vsnprintf does not
3130 do that.
3131 * charset.c (check_iso_charset_parameter): Convert internal
3132 character to string before calling 'error', since %c now has the
3133 printf meaning.
3134 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3135 overflow when computing char to be passed to 'error'. Do not
3136 pass Lisp_Object to 'error'; pass the integer instead.
3137 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3138 formatted with plain %d.
3139
3140 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3141
3142 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3143
3144 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3145
3146 * xterm.c (x_catch_errors): Remove duplicate declaration.
3147
3148 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3149
3150 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3151
3152 2011-04-10 Jim Meyering <meyering@redhat.com>
3153
3154 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3155 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3156 return ssize_t not "int", and use size_t as the buffer length.
3157 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3158 * gnutls.h: Update declarations.
3159 * process.c (read_process_output): Use ssize_t, to match.
3160 (send_process): Likewise.
3161
3162 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3163
3164 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3165
3166 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3167
3168 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3169 Use unsigned char, to match FcChar8 type definition.
3170
3171 * xterm.c (handle_one_xevent):
3172 * xmenu.c (create_and_show_popup_menu):
3173 * xselect.c (x_decline_selection_request)
3174 (x_reply_selection_request): Avoid type-punned deref of X events.
3175
3176 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3177
3178 Fix some uses of `int' instead of EMACS_INT.
3179 * search.c (string_match_1, fast_string_match)
3180 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3181 (scan_buffer, find_next_newline_no_quit)
3182 (find_before_next_newline, search_command, Freplace_match)
3183 (Fmatch_data): Make some `int' variables be EMACS_INT.
3184
3185 * xdisp.c (display_count_lines): 3rd argument and return value now
3186 EMACS_INT. All callers changed.
3187 (pint2hrstr): Last argument is now EMACS_INT.
3188
3189 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3190 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3191 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3192 (decode_coding_utf_16, decode_coding_emacs_mule)
3193 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3194 (decode_coding_ccl, decode_coding_charset)
3195 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3196 (decode_coding_iso_2022, decode_coding_emacs_mule)
3197 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3198 <char_offset, last_offset>: Declare EMACS_INT.
3199 (encode_coding_utf_8, encode_coding_utf_16)
3200 (encode_coding_emacs_mule, encode_invocation_designation)
3201 (encode_designation_at_bol, encode_coding_iso_2022)
3202 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3203 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3204 Declare EMACS_INT.
3205 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3206 (encode_invocation_designation): Last argument P_NCHARS is now
3207 EMACS_INT.
3208 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3209 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3210
3211 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3212 All users changed.
3213
3214 * ccl.c (Fccl_execute_on_string): Declare some variables
3215 EMACS_INT.
3216
3217 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3218
3219 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3220
3221 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3222
3223 * process.c (Fformat_network_address): Doc fix.
3224
3225 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3226
3227 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3228
3229 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3230
3231 * keyboard.c (read_char): Call Lisp function help-form-show,
3232 instead of using internal_with_output_to_temp_buffer.
3233 (Qhelp_form_show): New var.
3234 (syms_of_keyboard): Use DEFSYM macro.
3235
3236 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3237
3238 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3239
3240 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3241
3242 * process.c (Flist_processes): Remove to Lisp.
3243 (list_processes_1): Delete.
3244
3245 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3246
3247 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3248
3249 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3250
3251 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3252
3253 Fix more problems found by GCC 4.6.0's static checks.
3254
3255 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3256
3257 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3258
3259 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3260
3261 * xdisp.c (vmessage): Mark as a printf-like function.
3262
3263 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3264
3265 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3266
3267 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3268 printf-like functions.
3269 (tiff_load): Add casts to remove these marks before passing them
3270 to system-supplied API.
3271
3272 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3273
3274 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3275 This avoids several warnings with gcc -Wstrict-overflow.
3276 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3277 directly, rather than having caller test rule sign. This avoids
3278 some unnecessary tests.
3279 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3280 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3281 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3282
3283 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3284 (xfont_open): Avoid unnecessary tests.
3285
3286 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3287
3288 * composite.h, composite.c (composition_gstring_put_cache):
3289 Use EMACS_INT, not int, for length.
3290
3291 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3292 breaking out part of COMPOSITION_DECODE_RULE.
3293 (COMPOSITION_DECODE_RULE): Use it.
3294 * composite.c (get_composition_id): Remove unused local vars,
3295 by using the new macro.
3296
3297 * textprop.c (set_text_properties_1): Change while to do-while,
3298 since the condition is always true at first.
3299
3300 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3301 (interval_deletion_adjustment): Return unsigned value.
3302 All uses changed.
3303
3304 * process.c (list_processes_1, create_pty, read_process_output):
3305 (exec_sentinel): Remove vars that were set but not used.
3306 (create_pty): Remove unnecessary "volatile"s.
3307 (Fnetwork_interface_info): Avoid possibility of int overflow.
3308 (read_process_output): Do adaptive read buffering even if carryover.
3309 (read_process_output): Simplify nbytes computation if buffered.
3310
3311 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3312
3313 * syntax.c (scan_words): Remove var that was set but not used.
3314 (update_syntax_table): Use unsigned instead of int.
3315
3316 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3317 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3318 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3319
3320 * print.c (print_error_message): Avoid int overflow.
3321
3322 * font.c (font_list_entities): Redo for clarity,
3323 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3324
3325 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3326 (font_score): Avoid potential overflow in diff calculation.
3327
3328 * fns.c (substring_both): Remove var that is set but not used.
3329 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3330
3331 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3332
3333 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3334 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3335 can always succeed if overflow has undefined behavior.
3336
3337 * search.c (boyer_moore, wordify): Remove vars set but not used.
3338 (wordify): Omit three unnecessary tests.
3339
3340 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3341 All callers changed. This avoids the need for an unused var.
3342
3343 * casefiddle.c (casify_region): Remove var that is set but not used.
3344
3345 * dired.c (file_name_completion): Remove var that is set but not used.
3346
3347 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3348
3349 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3350 (Finsert_file_contents): Remove unnecessary code checking fd.
3351
3352 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3353 Check for integer overflow on size calculations.
3354
3355 * buffer.c (Fprevious_overlay_change): Remove var that is set
3356 but not used.
3357
3358 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3359 Remove vars that are set but not used.
3360 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3361 (timer_check_2): Mark vars as initialized.
3362
3363 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3364
3365 * image.c (lookup_image): Remove var that is set but not used.
3366 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3367
3368 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3369 that are set but not used.
3370
3371 * xfns.c (make_invisible_cursor): Don't return garbage
3372 if XCreateBitmapFromData fails (Bug#8410).
3373
3374 * xselect.c (x_get_local_selection, x_handle_property_notify):
3375 Remove vars that are set but not used.
3376
3377 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3378 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3379
3380 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3381 Remove var that is set but not used.
3382 (scroll_bar_windows_size): Now size_t, not int.
3383 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3384 Check for overflow.
3385
3386 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3387 (map_tty_color) [!defined MSDOS]: Likewise.
3388
3389 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3390
3391 * coding.c: Remove vars that are set but not used.
3392 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3393 All callers changed.
3394 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3395 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3396 (decode_coding_charset): Remove vars that are set but not used.
3397
3398 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3399 that is set but not used.
3400
3401 * print.c (print_object): Remove var that is set but not used.
3402
3403 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3404 The gnulib version avoids calling malloc in the usual case,
3405 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3406 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3407 * filelock.c (current_lock_owner): Likewise.
3408 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3409 * sysdep.c: Include allocator.h, careadlinkat.h.
3410 (emacs_no_realloc_allocator): New static constant.
3411 (emacs_readlink): New function.
3412 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3413 ../lib/careadlinkat.h.
3414
3415 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3416
3417 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3418 first non-nil return value).
3419
3420 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3421
3422 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3423 if not defined (Bug#8403).
3424
3425 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3426
3427 * xdisp.c (display_count_lines): Remove parameter `start',
3428 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3429 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3430 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3431 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3432 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3433 and thereabouts. All callers changed.
3434 (get_per_char_metric): Remove parameter `f', unused since
3435 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3436
3437 2011-04-02 Jim Meyering <meyering@redhat.com>
3438
3439 do not dereference NULL upon failed strdup
3440 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3441 (ns_get_family): Likewise.
3442
3443 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3444
3445 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3446
3447 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3448
3449 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3450 later (Bug#8403).
3451
3452 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3453
3454 Add lexical binding.
3455
3456 * window.c (Ftemp_output_buffer_show): New fun.
3457 (Fsave_window_excursion):
3458 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3459
3460 * lread.c (lisp_file_lexically_bound_p): New function.
3461 (Fload): Bind Qlexical_binding.
3462 (readevalloop): Remove `evalfun' arg.
3463 Bind Qinternal_interpreter_environment.
3464 (Feval_buffer): Bind Qlexical_binding.
3465 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3466 Mark as dynamic.
3467 (syms_of_lread): Declare `lexical-binding'.
3468
3469 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3470
3471 * keyboard.c (eval_dyn): New fun.
3472 (menu_item_eval_property): Use it.
3473
3474 * image.c (parse_image_spec): Use Ffunctionp.
3475
3476 * fns.c (concat, mapcar1): Accept byte-code-functions.
3477
3478 * eval.c (Fsetq): Handle lexical vars.
3479 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3480 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3481 (FletX, Flet): Obey lexical binding.
3482 (Fcommandp): Handle closures.
3483 (Feval): New `lexical' arg.
3484 (eval_sub): New function extracted from Feval. Use it almost
3485 everywhere where Feval was used. Look up vars in lexical env.
3486 Handle closures.
3487 (Ffunctionp): Move from subr.el.
3488 (Ffuncall): Handle closures.
3489 (apply_lambda): Remove `eval_flags'.
3490 (funcall_lambda): Handle closures and new byte-code-functions.
3491 (Fspecial_variable_p): New function.
3492 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3493 but without exporting it to Lisp.
3494
3495 * doc.c (Fdocumentation, store_function_docstring):
3496 * data.c (Finteractive_form): Handle closures.
3497
3498 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3499 interactive spec.
3500
3501 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3502 New byte-codes.
3503 (exec_byte_code): New function extracted from Fbyte_code to handle new
3504 calling convention for byte-code-functions. Add new byte-codes.
3505
3506 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3507
3508 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3509
3510 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3511
3512 * xdisp.c (redisplay_internal): Fix prototype.
3513
3514 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3515
3516 * xdisp.c (SCROLL_LIMIT): New macro.
3517 (try_scrolling): Use it when setting scroll_limit.
3518 Limit scrolling to 100 screen lines.
3519 (redisplay_window): Even when falling back on "recentering",
3520 position point in the window according to scroll-conservatively,
3521 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3522
3523 (try_scrolling): When point is above the window, allow searching
3524 as far as scroll_max, or one screenful, to compute vertical
3525 distance from PT to the scroll margin position. This prevents
3526 try_scrolling from unnecessarily failing when
3527 scroll-conservatively is set to a value slightly larger than the
3528 window height. Clean up the case of PT below the margin at bottom
3529 of window: scroll_max can no longer be INT_MAX. When aggressive
3530 scrolling is in use, don't let point enter the opposite scroll
3531 margin as result of the scroll.
3532 (syms_of_xdisp) <scroll-conservatively>: Document the
3533 threshold of 100 lines for never-recentering scrolling.
3534
3535 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3536
3537 * dispextern.h (move_it_by_lines):
3538 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3539 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3540 (message_log_check_duplicate): Remove parameters `prev_bol' and
3541 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3542 (redisplay_internal): Remove parameter `preserve_echo_area',
3543 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3544
3545 * indent.c (Fvertical_motion):
3546 * window.c (window_scroll_pixel_based, Frecenter):
3547 Don't pass `need_y_p' to `move_it_by_lines'.
3548
3549 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3550
3551 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3552 steal a few bits to be more compact.
3553 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3554 Remove unneeded casts.
3555
3556 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3557
3558 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3559
3560 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3561 binding" message (bug#7967).
3562
3563 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3564
3565 Fix more problems found by GCC 4.6.0's static checks.
3566
3567 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3568 Remove unused local var.
3569
3570 * editfns.c (Fmessage_box): Remove unused local var.
3571
3572 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3573 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3574 Omit unused local vars.
3575 * window.c (shrink_windows): Omit unused local var.
3576 * menu.c (digest_single_submenu): Omit unused local var.
3577 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3578 Omit unused local var.
3579
3580 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3581 Don't assume string length fits in int.
3582 (keyremap_step, read_key_sequence): Use size_t for sizes.
3583 (read_key_sequence): Don't check last_real_key_start redundantly.
3584
3585 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3586 instead of alloca (Bug#8344).
3587
3588 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3589 (Fbacktrace_frame): Don't assume nframes fits in int.
3590
3591 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3592
3593 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3594 concerns.
3595
3596 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3597
3598 * cm.c (calccost): Turn while-do into do-while, for clarity.
3599
3600 * keyboard.c (syms_of_keyboard): Use the same style as later
3601 in this function when indexing through an array. This also
3602 works around GCC bug 48267.
3603
3604 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3605
3606 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3607
3608 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3609 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3610
3611 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3612 This avoids undefined behavior on integer overflow, and is a bit
3613 more convenient anyway since it is compared to a size_t variable.
3614
3615 Variadic C functions now count arguments with size_t, not int.
3616 This avoids an unnecessary limitation on 64-bit machines, which
3617 caused (substring ...) to crash on large vectors (Bug#8344).
3618 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3619 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3620 All variadic functions and their callers changed accordingly.
3621 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3622 * data.c (arith_driver, float_arith_driver): Likewise.
3623 * editfns.c (general_insert_function): Likewise.
3624 * eval.c (struct backtrace.nargs, interactive_p)
3625 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3626 (funcall_lambda, mark_backtrace): Likewise.
3627 * fns.c (concat): Likewise.
3628 * frame.c (x_set_frame_parameters): Likewise.
3629 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3630 0 if not found, not -1. All callers changed.
3631
3632 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3633 (stack_copy_size): Now size_t, not int.
3634 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3635
3636 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3637
3638 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3639 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3640 All callers changed.
3641
3642 * lisp.h (multibyte_char_to_unibyte):
3643 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3644 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3645 * character.h (CHAR_TO_BYTE8):
3646 * cmds.c (internal_self_insert):
3647 * editfns.c (general_insert_function):
3648 * keymap.c (push_key_description):
3649 * search.c (Freplace_match):
3650 * xdisp.c (message_dolog, set_message_1): All callers changed.
3651
3652 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3653
3654 * keyboard.c (safe_run_hook_funcall): New function.
3655 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3656 don't set the hook to nil, but remove the offending function instead.
3657 (Qcommand_hook_internal): Remove, unused.
3658 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3659 Vcommand_hook_internal.
3660
3661 * eval.c (enum run_hooks_condition): Remove.
3662 (funcall_nil, funcall_not): New functions.
3663 (run_hook_with_args): Call each function through a `funcall' argument.
3664 Remove `cond' argument, now redundant.
3665 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3666 (Frun_hook_with_args_until_failure): Adjust accordingly.
3667 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3668
3669 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3670
3671 * dispextern.h (string_buffer_position): Remove declaration.
3672
3673 * print.c (strout): Remove parameter `multibyte', unused since
3674 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3675
3676 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3677 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3678 All callers changed.
3679
3680 * w32.c (_wsa_errlist): Use braces for struct initializers.
3681
3682 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3683 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3684 All callers changed.
3685 (string_buffer_position): Likewise. Also, make static (it's never
3686 used outside xdisp.c).
3687 (cursor_row_p): Remove parameter `w', unused since
3688 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3689 (decode_mode_spec): Remove parameter `precision', introduced during
3690 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3691 All callers changed.
3692
3693 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3694
3695 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3696
3697 2011-03-27 Anders Lindgren <andlind@gmail.com>
3698
3699 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3700 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3701 (ns_update_auto_hide_menu_bar): New functions.
3702 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3703 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3704 ns_constrain_all_frames.
3705 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3706 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3707
3708 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3709
3710 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3711
3712 2011-03-27 Glenn Morris <rgm@gnu.org>
3713
3714 * syssignal.h: Replace RETSIGTYPE with void.
3715 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3716 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3717 Replace SIGTYPE with void everywhere.
3718 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3719 * s/template.h (SIGTYPE): Remove commented out definition.
3720
3721 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3722
3723 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3724 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3725
3726 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3727
3728 * w32.c (read_unc_volume): Use parameter `henum', instead of
3729 global variable `wget_enum_handle'.
3730
3731 * keymap.c (describe_vector): Remove parameters `indices' and
3732 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3733 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3734
3735 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3736
3737 * keyboard.c (timer_check): Remove parameter `do_it_now',
3738 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3739 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3740 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3741
3742 * keyboard.c (read_char):
3743 * w32menu.c (w32_menu_display_help):
3744 * xmenu.c (show_help_event, menu_help_callback):
3745 Adjust calls to `show_help_echo'.
3746
3747 * gtkutil.c (xg_maybe_add_timer):
3748 * keyboard.c (readable_events):
3749 * process.c (wait_reading_process_output):
3750 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3751
3752 * insdel.c (adjust_markers_gap_motion):
3753 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3754 (gap_left, gap_right): Don't call it.
3755
3756 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3757
3758 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3759 incurred during fontification.
3760
3761 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3762
3763 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3764 (DEFVAR_PER_BUFFER): Don't pass it.
3765
3766 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3767 (scrolling_window): Don't pass it.
3768
3769 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3770
3771 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3772
3773 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3774 and `suffix'.
3775 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3776 of variables specific to SELinux and computation of `encoded_absname'.
3777
3778 * image.c (XPutPixel): Remove unused variable `height'.
3779
3780 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3781
3782 * unexw32.c (get_section_info): Remove unused variable `section'.
3783
3784 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3785 (system_process_attributes): Remove unused variable `sess'.
3786 (sys_read): Remove unused variable `err'.
3787
3788 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3789 (w32_wnd_proc): Remove unused variable `isdead'.
3790 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3791 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3792 (x_create_tip_frame): Remove unused variable `tem'.
3793
3794 * w32inevt.c (w32_console_read_socket):
3795 Remove unused variable `no_events'.
3796
3797 * w32term.c (x_draw_composite_glyph_string_foreground):
3798 Remove unused variable `width'.
3799
3800 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3801
3802 * w32term.c (x_set_glyph_string_clipping):
3803 Don't pass uninitialized region to CombineRgn.
3804
3805 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3806
3807 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3808 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3809 (Fx_close_connection): Remove unused variable `i'.
3810
3811 * w32font.c (w32font_draw): Return number of glyphs.
3812 (w32font_open_internal): Remove unused variable `i'.
3813 (w32font_driver): Add missing initializer.
3814
3815 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3816 (fill_in_menu): Remove unused variable `items_added'.
3817
3818 * w32term.c (last_mouse_press_frame): Remove static global variable.
3819 (w32_clip_to_row): Remove unused variable `f'.
3820 (x_delete_terminal): Remove unused variable `i'.
3821
3822 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3823 (NOTHING): Remove unused static global variable.
3824 (uniscribe_check_otf): Remove unused variable `table'.
3825 (uniscribe_font_driver): Add missing initializers.
3826
3827 2011-03-23 Julien Danjou <julien@danjou.info>
3828
3829 * term.c (Fsuspend_tty, Fresume_tty):
3830 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3831 * window.c (temp_output_buffer_show):
3832 * insdel.c (signal_before_change):
3833 * frame.c (Fhandle_switch_frame):
3834 * fileio.c (Fdo_auto_save):
3835 * emacs.c (Fkill_emacs):
3836 * editfns.c (save_excursion_restore):
3837 * cmds.c (internal_self_insert):
3838 * callint.c (Fcall_interactively):
3839 * buffer.c (Fkill_all_local_variables):
3840 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3841 Use Frun_hooks.
3842 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3843 unconditionnaly since it does the check itself.
3844
3845 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3846
3847 Fix more problems found by GCC 4.5.2's static checks.
3848
3849 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3850 the first time through the loop, since we know p0 < p1 then.
3851 This also avoids a gcc -Wstrict-overflow warning.
3852
3853 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3854 leading to a memory leak, possible in functions like
3855 load_charset_map_from_file that can allocate an unbounded number
3856 of objects (Bug#8318).
3857
3858 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3859 that could (at least in theory) be that large.
3860
3861 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3862 This is less likely to overflow, and avoids undefined behavior if
3863 overflow does occur. All callers changed. Use strtoul to scan
3864 for the unsigned long integer.
3865 (pint2hrstr): Simplify and tune code slightly.
3866 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3867
3868 * scroll.c (do_scrolling): Work around GCC bug 48228.
3869 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3870
3871 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3872 This also avoids a warning with gcc -Wstrict-overflow.
3873 (validate_x_resource_name): Simplify count usage.
3874 This also avoids a warning with gcc -Wstrict-overflow.
3875
3876 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3877 fail (Bug#8306).
3878
3879 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3880
3881 * process.c (Fmake_network_process): Use socklen_t, not int,
3882 where POSIX says socklen_t is required in portable programs.
3883 This fixes a porting bug on hosts like 64-bit HP-UX, where
3884 socklen_t is wider than int (Bug#8277).
3885 (Fmake_network_process, server_accept_connection):
3886 (wait_reading_process_output, read_process_output):
3887 Likewise.
3888
3889 * process.c: Rename or move locals to avoid shadowing.
3890 (list_processes_1, Fmake_network_process):
3891 (read_process_output_error_handler, exec_sentinel_error_handler):
3892 Rename or move locals.
3893 (Fmake_network_process): Define label "retry_connect" only if needed.
3894 (Fnetwork_interface_info): Fix pointer signedness.
3895 (process_send_signal): Add cast to avoid pointer signedness problem.
3896 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3897 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3898
3899 Make tparam.h and terminfo.c consistent.
3900 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3901 Include tparam.h instead, since it declares them.
3902 * cm.h (PC): Remove extern decl; tparam.h now does this.
3903 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3904 * terminfo.c: Include tparam.h, to check interfaces.
3905 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3906 (tparam): Adjust signature to match interface in tparam.h;
3907 this removes some undefined behavior. Check that outstring and len
3908 are zero, which they always are with Emacs.
3909 * tparam.h (PC, BC, UP): New extern decls.
3910
3911 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3912 (xftfont_open): Rename locals to avoid shadowing.
3913
3914 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3915 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3916 (OTF_TAG_SYM): Omit macro if not needed.
3917 (ftfont_list): Remove unused local.
3918 (get_adstyle_property, ftfont_pattern_entity):
3919 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3920 Rename locals to avoid shadowing.
3921
3922 * xfont.c (xfont_list_family): Mark var as initialized.
3923
3924 * xml.c (make_dom): Now static.
3925
3926 * composite.c (composition_compute_stop_pos): Rename local to
3927 avoid shadowing.
3928 (composition_reseat_it): Remove unused locals.
3929 (find_automatic_composition, composition_adjust_point): Likewise.
3930 (composition_update_it): Mark var as initialized.
3931 (find_automatic_composition): Mark vars as initialized,
3932 with a FIXME (Bug#8290).
3933
3934 character.h: Rename locals to avoid shadowing.
3935 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3936 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3937 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3938 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3939 to avoid shadowing.
3940
3941 * textprop.c (property_change_between_p): Remove; unused.
3942
3943 * intervals.c (interval_start_pos): Now static.
3944
3945 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3946
3947 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3948 Rename locals to avoid shadowing.
3949
3950 * sound.c (wav_play, au_play, Fplay_sound_internal):
3951 Fix pointer signedness.
3952 (alsa_choose_format): Remove unused local var.
3953 (wav_play): Initialize a variable to 0, to prevent undefined
3954 behavior (Bug#8278).
3955
3956 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3957
3958 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3959
3960 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3961 clobbering (Bug#8298).
3962 * sysdep.c (sys_subshell): Likewise.
3963 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3964
3965 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3966 This should get cleaned up, so that child_setup has the
3967 same signature on all platforms.
3968
3969 * callproc.c (call_process_cleanup): Now static.
3970 (relocate_fd): Rename locals to avoid shadowing.
3971
3972 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3973
3974 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3975 not to be necessary, and produces flickering.
3976
3977 2011-03-20 Glenn Morris <rgm@gnu.org>
3978
3979 * config.in: Remove file.
3980
3981 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3982
3983 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3984 are now in src/globals.h.
3985 (syms_of_minibuf): Remove spurious & from previous change.
3986
3987 2011-03-20 Leo <sdl.web@gmail.com>
3988
3989 * minibuf.c (completing-read-function): New variable.
3990 (completing-read-default): Rename from completing-read.
3991 (completing-read): Call completing-read-function.
3992
3993 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3994
3995 * xfaces.c (Fx_load_color_file):
3996 Read color file from absolute filename (bug#8250).
3997
3998 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3999
4000 * makefile.w32-in: Update dependencies.
4001
4002 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4003
4004 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4005
4006 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4007
4008 Fix more problems found by GCC 4.5.2's static checks.
4009
4010 * process.c (make_serial_process_unwind, send_process_trap):
4011 (sigchld_handler): Now static.
4012
4013 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4014 That way, the code declares only the vars that it needs.
4015 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4016 * s/cygwin.h (PTY_ITERATION): Likewise.
4017 * s/darwin.h (PTY_ITERATION): Likewise.
4018 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4019
4020 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4021 * process.c (allocate_pty): Don't declare stb unless it's needed.
4022
4023 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4024 (CONSTANTLIM): Remove; unused.
4025 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4026 Define only if needed.
4027
4028 * unexelf.c (unexec): Name an expression,
4029 to avoid gcc -Wbad-function-cast warning.
4030 Use a different way to cause a compilation error if anyone uses
4031 n rather than nn, a way that does not involve shadowing.
4032 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4033
4034 * deps.mk (unexalpha.o): Remove; unused.
4035
4036 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4037 * unexec.h: New file.
4038 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4039 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4040 Depend on unexec.h.
4041 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4042 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4043 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4044 Change as necessary to match prototype in unexec.h.
4045
4046 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4047 shadowing.
4048 (back_comment, skip_chars): Mark vars as initialized.
4049
4050 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4051 Rename locals to avoid shadowing.
4052
4053 * lread.c (read1): Rewrite so as not to use empty "else".
4054 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4055
4056 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4057
4058 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4059 warning when compiling print.c.
4060
4061 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4062 instead of using an uninitialized var.
4063 (font_sort_entities): Mark var as initialized.
4064
4065 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4066
4067 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4068 pointers to constants.
4069 (font_parse_fcname): Remove unused vars.
4070 (font_delete_unmatched): Now static.
4071 (font_get_spec): Remove; unused.
4072 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4073 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4074 Rename or move locals to avoid shadowing.
4075
4076 * fns.c (require_nesting_list, require_unwind): Now static.
4077 (Ffillarray): Rename locals to avoid shadowing.
4078
4079 * floatfns.c (domain_error2): Define only if needed.
4080 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4081
4082 * alloc.c (mark_backtrace): Move decl from here ...
4083 * lisp.h: ... to here, so that it can be checked.
4084
4085 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4086 (Fdefvar): Rewrite so as not to use empty "else".
4087 (lisp_indirect_variable): Name an expression,
4088 to avoid gcc -Wbad-function-cast warning.
4089 (Fdefvar): Rename locals to avoid shadowing.
4090
4091 * callint.c (quotify_arg, quotify_args): Now static.
4092 (Fcall_interactively): Rename locals to avoid shadowing.
4093 Use const pointer when appropriate.
4094
4095 * lisp.h (get_system_name, get_operating_system_release):
4096 Move decls here, to check interfaces.
4097 * process.c (get_operating_system_release): Move decl to lisp.h.
4098 * xrdb.c (get_system_name): Likewise.
4099 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4100 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4101 some of which prompt warnings from gcc -Wbad-function-cast.
4102 (Fformat_time_string, Fencode_time, Finsert_char):
4103 (Ftranslate_region_internal, Fformat):
4104 Rename or remove local vars to avoid shadowing.
4105 (Ftranslate_region_internal): Mark var as initialized.
4106
4107 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4108 avoid shadowing.
4109
4110 * lisp.h (eassert): Check that the argument compiles, even if
4111 ENABLE_CHECKING is not defined.
4112
4113 * data.c (Findirect_variable): Name an expression, to avoid
4114 gcc -Wbad-function-cast warning.
4115 (default_value, arithcompare, arith_driver, arith_error): Now static.
4116 (store_symval_forwarding): Rename local to avoid shadowing.
4117 (Fmake_variable_buffer_local, Fmake_local_variable):
4118 Mark variables as initialized.
4119 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4120
4121 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4122 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4123 Rename locals to avoid shadowing.
4124 (mark_stack): Move local variables into the #ifdef region where
4125 they're used.
4126 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4127 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4128 needed otherwise.
4129 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4130 (GC_STRING_CHARS): Remove; not used.
4131 (Fmemory_limit): Cast sbrk's returned value to char *.
4132
4133 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4134 avoids undefined behavior in theory.
4135
4136 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4137
4138 Use functions, not macros, for up- and down-casing (Bug#8254).
4139 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4140 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4141 to use the following functions instead of these macros.
4142 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4143 EMACS_INT, since callers assume the returned value fits in int.
4144 (upcase1): Likewise, for UPCASE_TABLE.
4145 (uppercasep, lowercasep, upcase): New static inline functions.
4146 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4147 the race-condition problem in the old DOWNCASE.
4148
4149 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4150 Rename locals to avoid shadowing.
4151 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4152 (regex_compile, re_search_2, re_match_2_internal):
4153 Remove unused local vars.
4154 (FREE_VAR): Rewrite so as not to use empty "else",
4155 which gcc can warn about.
4156 (regex_compile, re_match_2_internal): Mark locals as initialized.
4157 (RETALLOC_IF): Define only if needed.
4158 (WORDCHAR_P): Likewise. This one is never needed, but is used
4159 only in a comment talking about a compiler bug, so put inside
4160 the #if 0 of that comment.
4161 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4162 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4163 Remove; unused.
4164
4165 * search.c (boyer_moore): Rename locals to avoid shadowing.
4166 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4167 (PREV_CHAR_BOUNDARY): Likewise.
4168
4169 * search.c (simple_search): Remove unused var.
4170
4171 * dired.c (compile_pattern): Move decl from here ...
4172 * lisp.h: ... to here, so that it can be checked.
4173 (struct re_registers): New forward decl.
4174
4175 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4176
4177 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4178 All uses changed.
4179 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4180 Rename locals to avoid shadowing.
4181 (Fvertical_motion): Mark locals as initialized.
4182
4183 * casefiddle.c (casify_object, casify_region): Now static.
4184 (casify_region): Mark local as initialized.
4185
4186 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4187
4188 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4189 New macros, so that the caller can use some names other than
4190 gcpro1, gcpro2, etc.
4191 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4192 of the new macros.
4193 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4194 argument, for consistency with GCPRO2_VAR, etc: it is now the
4195 prefix of the variable, not the variable itself. All uses
4196 changed.
4197 * dired.c (directory_files_internal, file_name_completion):
4198 Rename locals to avoid shadowing.
4199
4200 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4201 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4202 dired.c's scmp function, had undefined behavior.
4203 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4204 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4205 * buffer.h: ... to here, because these macros use current_buffer,
4206 and the new implementation with inline functions needs to have
4207 current_buffer in scope now, rather than later when the macros
4208 are used.
4209 (downcase, upcase1): New static inline functions.
4210 (DOWNCASE, UPCASE1): Reimplement using these functions.
4211 This avoids undefined behavior in expressions like
4212 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4213 from race conditions in accessing the global variables
4214 case_temp1 and case_temp2.
4215 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4216 * lisp.h (case_temp1, case_temp2): Remove their decls.
4217 * character.h (ASCII_CHAR_P): Move from here ...
4218 * lisp.h: ... to here, so that the inline functions mentioned
4219 above can use them.
4220
4221 * dired.c (directory_files_internal_unwind): Now static.
4222
4223 * fileio.c (file_name_as_directory, directory_file_name):
4224 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4225 Now static.
4226 (file_name_as_directory): Use const pointers when appropriate.
4227 (Fexpand_file_name): Likewise. In particular, newdir might
4228 point at constant storage, so make it a const pointer.
4229 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4230 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4231 signedness issues.
4232 (Fset_file_times, Finsert_file_contents, auto_save_error):
4233 Rename locals to avoid shadowing.
4234
4235 * minibuf.c (choose_minibuf_frame_1): Now static.
4236 (Ftry_completion, Fall_completions): Rename or remove locals
4237 to avoid shadowing.
4238
4239 * marker.c (bytepos_to_charpos): Remove; unused.
4240
4241 * lisp.h (verify_bytepos, count_markers): New decls,
4242 so that gcc does not warn that these functions aren't declared.
4243
4244 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4245 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4246 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4247 (copy_text): Remove unused local var.
4248
4249 * filelock.c (within_one_second): Now static.
4250 (lock_file_1): Rename local to avoid shadowing.
4251
4252 * buffer.c (fix_overlays_before): Mark locals as initialized.
4253 (fix_start_end_in_overlays): Likewise. This function should be
4254 simplified by using pointers-to-pointers, but that's a different
4255 matter.
4256 (switch_to_buffer_1): Now static.
4257 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4258 (report_overlay_modification): Rename locals to avoid shadowing.
4259
4260 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4261 Fix pointer signedness issue.
4262 (sys_subshell): Mark local as volatile if checking for lint,
4263 to suppress a gcc -Wclobbered warning that does not seem to be right.
4264 (MAXPATHLEN): Define only if needed.
4265
4266 * process.c (serial_open, serial_configure): Move decls from here ...
4267 * systty.h: ... to here, so that they can be checked.
4268
4269 * fns.c (get_random, seed_random): Move extern decls from here ...
4270 * lisp.h: ... to here, so that they can be checked.
4271
4272 * sysdep.c (reset_io): Now static.
4273 (wait_for_termination_signal): Remove; unused.
4274
4275 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4276 (copy_keymap_item, append_key, push_text_char_description):
4277 Now static.
4278 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4279 (DENSE_TABLE_SIZE): Remove; unused.
4280 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4281 (describe_map_tree):
4282 Rename locals to avoid shadowing.
4283
4284 * keyboard.c: Declare functions static if they are not used elsewhere.
4285 (echo_char, echo_dash, cmd_error, top_level_2):
4286 (poll_for_input, handle_async_input): Now static.
4287 (read_char, kbd_buffer_get_event, make_lispy_position):
4288 (make_lispy_event, make_lispy_movement, apply_modifiers):
4289 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4290 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4291 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4292 (read_key_sequence, read_char): Mark locals as initialized.
4293 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4294
4295 * keyboard.h (make_ctrl_char): New decl.
4296 (mark_kboards): Move decl here ...
4297 * alloc.c (mark_kboards): ... from here.
4298
4299 * lisp.h (force_auto_save_soon): New decl.
4300
4301 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4302 (DEFINE_DUMMY_FUNCTION): New macro.
4303 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4304 Use it.
4305 (main): Add casts to avoid warnings
4306 if GCC considers string literals to be constants.
4307
4308 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4309
4310 * dbusbind.c: Pointer signedness fixes.
4311 (xd_signature, xd_append_arg, xd_initialize):
4312 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4313 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4314 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4315 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4316
4317 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4318 if GCC considers string literals to be constants.
4319 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4320
4321 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4322
4323 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4324 (print_preprocess, print_object): New macro to fix last change.
4325
4326 * print.c (print_preprocess): Don't forget font objects.
4327
4328 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4329
4330 * emacs.c (USAGE3): Doc fixes.
4331
4332 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4333
4334 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4335 structure.
4336
4337 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4338
4339 * lisp.h (VWindow_system, Qfile_name_history):
4340 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4341 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4342 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4343
4344 * w32select.c: Don't #include "keyboard.h".
4345 (run_protected): Add extern declaration for waiting_for_input.
4346
4347 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4348 * w32console.c (detect_input_pending, read_input_pending)
4349 (encode_terminal_code):
4350 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4351 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4352 (w32_system_caret_y, Qfile_name_history):
4353 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4354 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4355 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4356 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4357 * w32proc.c (Qlocal, report_file_error):
4358 * w32term.c (Vwindow_system, updating_frame):
4359 * w32uniscribe.c (initialized, uniscribe_font_driver):
4360 Remove unneeded extern declarations.
4361
4362 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4363
4364 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4365
4366 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4367
4368 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4369 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4370 These macros can no longer be used for assignment.
4371
4372 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4373 Assign struct members directly, instead of using BUF_BEGV etc.
4374 (record_buffer_markers, fetch_buffer_markers): New functions for
4375 recording and fetching special buffer markers.
4376 (set_buffer_internal_1, set_buffer_temp): Use them.
4377
4378 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4379
4380 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4381
4382 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4383 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4384
4385 * xdisp.c (hscroll_window_tree):
4386 (reconsider_clip_changes): Use PT instead of BUF_PT.
4387
4388 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4389
4390 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4391 $(EMACS_ROOT)/lib/intprops.h.
4392
4393 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4394
4395 Fix more problems found by GCC 4.5.2's static checks.
4396
4397 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4398 to unsigned char * to avoid compiler diagnostic.
4399 (xg_free_frame_widgets): Make it clear that a local variable is
4400 needed only if USE_GTK_TOOLTIP.
4401 (gdk_window_get_screen): Make it clear that this macro is needed
4402 only if USE_GTK_TOOLTIP.
4403 (int_gtk_range_get_value): New function, which avoids a diagnostic
4404 from gcc -Wbad-function-cast.
4405 (xg_set_toolkit_scroll_bar_thumb): Use it.
4406 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4407 diagnostic from gcc -Wbad-function-cast.
4408 (get_utf8_string, xg_get_file_with_chooser):
4409 Rename locals to avoid shadowing.
4410 (create_dialog): Move locals to avoid shadowing.
4411
4412 * xgselect.c (xg_select): Remove unused var.
4413
4414 * image.c (four_corners_best): Mark locals as initialized.
4415 (gif_load): Initialize transparent_p to zero (Bug#8238).
4416 Mark another local as initialized.
4417 (my_png_error, my_error_exit): Mark with NO_RETURN.
4418
4419 * image.c (clear_image_cache): Now static.
4420 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4421 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4422 (x_edge_detection): Remove unnecessary cast that
4423 gcc -Wbad-function-cast diagnoses.
4424 (gif_load): Fix pointer signedness.
4425 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4426 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4427
4428 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4429
4430 Improve quality of tests for time stamp overflow.
4431 For example, without this patch (encode-time 0 0 0 1 1
4432 1152921504606846976) returns the obviously-bogus value (-948597
4433 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4434 reports time overflow. See
4435 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4436 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4437 * editfns.c: Include limits.h and intprops.h.
4438 (TIME_T_MIN, TIME_T_MAX): New macros.
4439 (time_overflow): Move earlier, to before first use.
4440 (hi_time, lo_time): New functions, for an accurate test for
4441 out-of-range times.
4442 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4443 (Fget_internal_run_time): Don't assume time_t fits in int.
4444 (make_time): Use list2 instead of Fcons twice.
4445 (Fdecode_time): More accurate test for out-of-range times.
4446 (check_tm_member): New function.
4447 (Fencode_time): Use it, to test for out-of-range times.
4448 (lisp_time_argument): Don't rely on undefined left-shift and
4449 right-shift behavior when checking for time stamp overflow.
4450
4451 * editfns.c (time_overflow): New function, refactoring common code.
4452 (Fformat_time_string, Fdecode_time, Fencode_time):
4453 (Fcurrent_time_string): Use it.
4454
4455 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4456 * dired.c (make_time): Move to ...
4457 * editfns.c (make_time): ... here.
4458 * systime.h: Note the move.
4459
4460 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4461
4462 * fringe.c (update_window_fringes): Remove unused variables.
4463
4464 * unexmacosx.c (copy_data_segment): Also copy __got section.
4465 (Bug#8223)
4466
4467 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4468
4469 * termcap.c [MSDOS]: Include "msdos.h".
4470 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4471 Constify `char *' arguments and their references according to
4472 prototypes in tparam.h.
4473
4474 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4475
4476 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4477 Adapt all references accordingly.
4478
4479 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4480
4481 2011-03-11 Tom Tromey <tromey@redhat.com>
4482
4483 * buffer.c (syms_of_buffer): Remove obsolete comment.
4484
4485 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4486
4487 * termhooks.h (encode_terminal_code): Declare prototype.
4488
4489 * msdos.c (encode_terminal_code): Don't declare prototype.
4490
4491 * term.c (encode_terminal_code): Now external again, used by
4492 w32console.c and msdos.c.
4493
4494 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4495 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4496
4497 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4498
4499 Fix some minor problems found by GCC 4.5.2's static checks.
4500
4501 * fringe.c (update_window_fringes): Mark locals as initialized
4502 (Bug#8227).
4503 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4504
4505 * alloc.c (mark_fringe_data): Move decl from here ...
4506 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4507 to check its interface.
4508 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4509
4510 * fontset.c (free_realized_fontset): Now static.
4511 (Fset_fontset_font): Rename local to avoid shadowing.
4512 (fontset_font): Mark local as initialized.
4513 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4514
4515 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4516
4517 * xselect.c (x_disown_buffer_selections): Remove; not used.
4518 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4519 (x_own_selection, Fx_disown_selection_internal): Rename locals
4520 to avoid shadowing.
4521 (x_handle_dnd_message): Remove local to avoid shadowing.
4522
4523 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4524 so that the caller can use some name other than gcpro1.
4525 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4526 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4527 (Fx_backspace_delete_keys_p):
4528 Use them to avoid shadowing, and rename vars to avoid shadowing.
4529 (x_decode_color, x_set_name, x_window): Now static.
4530 (Fx_create_frame): Add braces to silence GCC warning.
4531 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4532 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4533 Remove unused locals.
4534 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4535 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4536 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4537 macros.
4538
4539 * xterm.h (x_mouse_leave): New decl.
4540
4541 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4542 Remove unused functions.
4543 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4544 (x_calc_absolute_position): Now static.
4545 (XTread_socket): Don't define label "out" unless it's used.
4546 Don't declare local "event" unless it's used.
4547 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4548 unless they are used.
4549 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4550 (x_fatal_error_signal): Remove; not used.
4551 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4552 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4553 (x_error_catcher, x_connection_closed, x_error_handler):
4554 (x_error_quitter, xembed_send_message, x_iconify_frame):
4555 (my_log_handler): Rename locals to avoid shadowing.
4556 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4557 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4558
4559 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4560 Rename or move locals to avoid shadowing.
4561 (tty_defined_color, merge_face_heights): Now static.
4562 (free_realized_faces_for_fontset): Remove; not used.
4563 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4564 does not deduce is never used uninitialized.
4565 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4566 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4567
4568 * terminal.c (store_terminal_param): Now static.
4569
4570 * xmenu.c (menu_highlight_callback): Now static.
4571 (set_frame_menubar): Remove unused local.
4572 (xmenu_show): Rename parameter to avoid shadowing.
4573 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4574 since they might point to immutable storage.
4575 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4576 since it's unused otherwise.
4577
4578 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4579 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4580 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4581 avoids a gcc -Wuninitialized diagnostic.
4582 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4583 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4584 does not deduce are never used uninitialized.
4585
4586 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4587
4588 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4589 * window.c (window_loop, size_window):
4590 (run_window_configuration_change_hook, enlarge_window): Likewise.
4591
4592 * window.c (display_buffer): Now static.
4593 (size_window): Mark variables that gcc -Wuninitialized
4594 does not deduce are never used uninitialized.
4595 * window.h (check_all_windows): New decl, to forestall
4596 gcc -Wmissing-prototypes diagnostic.
4597 * dispextern.h (bidi_dump_cached_states): Likewise.
4598
4599 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4600 shadowing.
4601 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4602 Include <limits.h>.
4603 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4604 and to avoid gcc -Wuninitialized warning.
4605 (load_charset_map): Mark variables that gcc -Wuninitialized
4606 does not deduce are never used uninitialized.
4607 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4608
4609 * coding.c (coding_set_source, coding_set_destination):
4610 Use "else { /* comment */ }" rather than "else /* comment */;"
4611 for clarity, and to avoid gcc -Wempty-body warning.
4612 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4613 a block, when the outer 'i' will do.
4614 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4615 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4616 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4617 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4618 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4619 Rename locals to avoid shadowing.
4620 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4621 * coding.c (emacs_mule_char, encode_invocation_designation):
4622 Now static, since they're not used elsewhere.
4623 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4624 (decode_coding_object, encode_coding_object, detect_coding_system):
4625 (decode_coding_emacs_mule): Mark variables that gcc
4626 -Wuninitialized does not deduce are never used uninitialized.
4627 (detect_coding_iso_2022): Initialize a local variable that might
4628 be used uninitialized. Leave a FIXME because it's not clear that
4629 this initialization is needed. (Bug#8211)
4630 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4631 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4632 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4633 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4634 Remove unused macros.
4635
4636 * category.c (hash_get_category_set): Remove unused local var.
4637 (copy_category_table): Now static, since it's not used elsewhere.
4638 * character.c (string_count_byte8): Likewise.
4639
4640 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4641 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4642
4643 * chartab.c (copy_sub_char_table): Now static, since it's not used
4644 elsewhere.
4645 (sub_char_table_ref_and_range, char_table_ref_and_range):
4646 Rename locals to avoid shadowing.
4647 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4648
4649 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4650 (BIDI_BOB): Remove unused macro.
4651
4652 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4653 deduce are never used uninitialized.
4654 * term.c (encode_terminal_code): Likewise.
4655
4656 * term.c (encode_terminal_code): Now static. Remove unused local.
4657
4658 * tparam.h: New file.
4659 * term.c, tparam.h: Include it.
4660 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4661 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4662 Move these decls to tparam.h, and make them agree with what
4663 is actually in tparam.c. The previous trick of using incompatible
4664 decls in different modules does not conform to the C standard.
4665 All callers of tparam changed to use tparam's actual API.
4666 * tparam.c (tparam1, tparam, tgoto):
4667 Use const pointers where appropriate.
4668
4669 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4670 * cm.h (struct cm): Likewise.
4671 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4672 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4673 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4674 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4675 (turn_on_face, init_tty): Likewise.
4676 * termchar.h (struct tty_display_info): Likewise.
4677
4678 * term.c (term_mouse_position): Rename local to avoid shadowing.
4679
4680 * alloc.c (mark_ttys): Move decl from here ...
4681 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4682
4683 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4684
4685 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4686
4687 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4688
4689 * search.c (compile_pattern_1): Remove argument regp, unused since
4690 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4691 (compile_pattern): Don't pass it.
4692
4693 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4694
4695 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4696 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4697 for ! HAVE_GTK3.
4698 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4699
4700 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4701
4702 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4703 gdk_window_get_screen, gdk_window_get_geometry,
4704 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4705 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4706 (xg_get_pixbuf_from_pixmap): New function.
4707 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4708 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4709 Call xg_get_pixbuf_from_pixmap instead of
4710 gdk_pixbuf_get_from_drawable.
4711 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4712 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4713 (xg_check_special_colors): Use GtkStyleContext and its functions
4714 for HAVE_GTK3.
4715 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4716 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4717 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4718 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4719 Call gtk_widget_get_preferred_size.
4720 (xg_frame_resized): gdk_window_get_geometry only takes 5
4721 parameters.
4722 (xg_win_to_widget, xg_event_is_for_menubar):
4723 Call gdk_x11_window_lookup_for_display.
4724 (xg_set_widget_bg): New function.
4725 (delete_cb): New function.
4726 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4727 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4728 (xg_set_background_color): Call xg_set_widget_bg.
4729 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4730 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4731 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4732 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4733 if ! HAVE_GTK3.
4734 (update_frame_tool_bar): Call gtk_widget_hide.
4735 (xg_initialize): Use GDK_KEY_g.
4736
4737 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4738 if ! HAVE_GTK3
4739 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4740
4741 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4742 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4743 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4744
4745 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4746
4747 * w32xfns.c (select_palette): Check success of RealizePalette against
4748 GDI_ERROR, not zero.
4749
4750 See ChangeLog.11 for earlier changes.
4751
4752 ;; Local Variables:
4753 ;; coding: utf-8
4754 ;; End:
4755
4756 Copyright (C) 2011 Free Software Foundation, Inc.
4757
4758 This file is part of GNU Emacs.
4759
4760 GNU Emacs is free software: you can redistribute it and/or modify
4761 it under the terms of the GNU General Public License as published by
4762 the Free Software Foundation, either version 3 of the License, or
4763 (at your option) any later version.
4764
4765 GNU Emacs is distributed in the hope that it will be useful,
4766 but WITHOUT ANY WARRANTY; without even the implied warranty of
4767 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4768 GNU General Public License for more details.
4769
4770 You should have received a copy of the GNU General Public License
4771 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.