1 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3 * xsettings.c: Use both GConf and GSettings if both are available.
4 (store_config_changed_event): Add comment.
5 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6 (store_tool_bar_style_changed): New functions.
7 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
8 (struct xsettings): Move font inside HAVE_XFT.
9 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
10 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
12 (something_changed_gsettingsCB): Renamed from something_changedCB.
13 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
15 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
16 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
17 (something_changed_gconfCB): Renamed from something_changedCB.
18 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
19 (parse_settings): Move check for font inside HAVE_XFT.
20 (read_settings, apply_xft_settings): Add comment.
21 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
22 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
23 call store_font_name_changed.
24 (xft_settings_event): Add comment.
25 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
26 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
27 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
28 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
29 (xsettings_initialize): Call init_gsettings last.
30 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
33 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
35 Random fixes. E.g., (random) never returned negative values.
36 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
37 subseconds part to the entropy, as that's a bit more random.
38 Prefer signed to unsigned, since the signedness doesn't matter and
39 in general we prefer signed. When given a limit, use a
40 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
41 latter isn't right if USE_2_TAGS_FOR_INTS.
42 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
43 not 0..VALMASK. Don't discard "excess" bits that random () returns.
45 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
47 * textprop.c (text_property_stickiness):
48 Obey Vtext_property_default_nonsticky.
49 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
50 * w32fns.c (syms_of_w32fns):
51 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
53 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
55 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
56 This is more efficient than Ffile_directory_p and avoids a minor race.
58 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
60 * buffer.c (Foverlay_put): Say what the return value is
63 * fileio.c (barf_or_query_if_file_exists): Check first if the file
64 is a directory before asking whether to use the file name
66 (barf_or_query_if_file_exists): Make the "File is a directory"
67 error be more correct.
69 * fns.c (Frequire): Remove the mention of the .gz files, since
70 that's installation-specific, but keep the mention of
73 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
75 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
76 Report string overflow if the output is too long.
78 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
80 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
81 (syms_of_gnutls): Remove duplicate DEFSYM for
82 Qgnutls_bootprop_verify_hostname_error, an error for
83 Qgnutls_bootprop_verify_error (which is no longer used).
85 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
86 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
87 Also (re)move comments that are misplaced or no longer relevant.
89 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
91 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
93 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
95 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
96 and background color parameters if they have been changed.
98 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
100 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
102 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
104 * xsettings.c (SYSTEM_FONT): Define only when used.
105 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
107 * keymap.c (access_keymap_1): Now static.
109 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
111 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
112 leave any prefix arg for the up event (Bug#1586).
114 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
116 * lread.c (syms_of_lread): Mention single symbols defined by
117 `defvar' or `defconst' (bug#7154).
119 * fns.c (Frequire): Mention .el.gz files (bug#7314).
120 (Frequire): Mention get-load-suffixes.
122 2011-07-02 Martin Rudalics <rudalics@gmx.at>
124 * window.h (window): Remove clone_number slot.
125 * window.c (Fwindow_clone_number, Fset_window_clone_number):
127 (make_parent_window, make_window, saved_window)
128 (Fset_window_configuration, save_window_save): Don't deal with
130 * buffer.c (Qclone_number): Remove declaration.
131 (sort_overlays, overlay_strings): Don't deal with clone numbers.
133 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
135 Add multiple inheritance to keymaps.
136 * keymap.c (Fmake_composed_keymap): New function.
137 (Fset_keymap_parent): Simplify.
138 (fix_submap_inheritance): Remove.
139 (access_keymap_1): New function extracted from access_keymap to handle
140 embedded parents and handle lists of maps.
141 (access_keymap): Use it.
142 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
143 (Fcopy_keymap): Handle embedded parents.
144 (Fcommand_remapping, define_as_prefix): Simplify.
145 (Fkey_binding): Simplify.
146 (syms_of_keymap): Move minibuffer-local-completion-map,
147 minibuffer-local-filename-completion-map,
148 minibuffer-local-must-match-map, and
149 minibuffer-local-filename-must-match-map to Elisp.
150 (syms_of_keymap): Defsubr make-composed-keymap.
151 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
152 (parse_menu_item): Trivial simplification.
154 2011-07-01 Glenn Morris <rgm@gnu.org>
156 * Makefile.in (SETTINGS_LIBS): Fix typo.
158 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
160 * coding.c (Fencode_coding_string): Record the last coding system
161 used, as the function doc string says (bug#8738).
163 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
165 * xsettings.c (store_monospaced_changed): Take new font as arg and
166 check for change against current_mono_font.
167 (EMACS_TYPE_SETTINGS): Remove this and related defines.
168 (emacs_settings_constructor, emacs_settings_get_property)
169 (emacs_settings_set_property, emacs_settings_class_init)
170 (emacs_settings_init, gsettings_obj): Remove.
171 (something_changedCB): New function for HAVE_GSETTINGS.
172 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
173 with value as argument.
174 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
175 g_settings_new (Bug#8967). Do not create gsettings_obj.
176 Remove calls to g_settings_bind. Connect something_changedCB to
179 * xgselect.c: Add defined (HAVE_GSETTINGS).
180 (xgselect_initialize): Ditto.
182 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
183 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
186 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
188 * eval.c (struct backtrace): Simplify and port the data structure.
189 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
190 signed bit field, as this assumption is not portable and it makes
191 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
192 "char debug_on_exit : 1" as this is not portable either; instead,
193 use the portable "unsigned int debug_on_exit : 1". Remove unused
194 member evalargs. Remove obsolete comments about cc bombing out.
196 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
198 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
199 Let HAVE_GSETTINGS override HAVE_GCONF.
200 (store_monospaced_changed): New function.
201 (EMACS_SETTINGS): A new type derived from GObject to handle
202 GSettings notifications.
203 (emacs_settings_constructor, emacs_settings_get_property)
204 (emacs_settings_set_property, emacs_settings_class_init):
206 (gsettings_client, gsettings_obj): New variables.
207 (GSETTINGS_SCHEMA): New define.
208 (something_changedCB): Call store_monospaced_changed.
209 (init_gsettings): New function.
210 (xsettings_initialize): Call init_gsettings.
211 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
214 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
217 2011-06-29 Martin Rudalics <rudalics@gmx.at>
219 * window.c (resize_root_window, grow_mini_window)
220 (shrink_mini_window): Rename Qresize_root_window to
221 Qwindow_resize_root_window and Qresize_root_window_vertically to
222 Qwindow_resize_root_window_vertically.
224 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
226 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
228 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
230 * makefile.w32-in: Redesign dependencies so they reflect more
231 clearly which files are directly included by each source file,
232 and not through other includes.
234 2011-06-27 Martin Rudalics <rudalics@gmx.at>
236 * buffer.c (Qclone_number): Declare static and DEFSYM it.
237 (sort_overlays, overlay_strings): When an overlay's clone number
238 matches the window's clone number process the overlay even if
239 the overlay's window property doesn't match the current window.
241 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
242 (Fwindow_hchild): Rename to Fwindow_left_child.
243 (Fwindow_next): Rename to Fwindow_next_sibling.
244 (Fwindow_prev): Rename to Fwindow_prev_sibling.
245 (resize_window_check): Rename to window_resize_check.
246 (resize_window_apply): Rename to window_resize_apply.
247 (Fresize_window_apply): Rename to Fwindow_resize_apply.
248 (Fdelete_other_windows_internal, resize_frame_windows)
249 (Fsplit_window_internal, Fdelete_window_internal)
250 (grow_mini_window, shrink_mini_window)
251 (Fresize_mini_window_internal): Fix callers accordingly.
253 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
255 * emacsgtkfixed.h: State that this is only used with Gtk+3.
256 (emacs_fixed_set_min_size): Remove.
257 (emacs_fixed_new): Take frame as argument.
259 * emacsgtkfixed.c: State that this is only used with Gtk+3.
260 (_EmacsFixedPrivate): Remove minwidth/height.
262 (emacs_fixed_init): Initialize priv->f.
263 (get_parent_class, emacs_fixed_set_min_size): Remove.
264 (emacs_fixed_new): Set priv->f to argument.
265 (emacs_fixed_get_preferred_width)
266 (emacs_fixed_get_preferred_height): Use min_width/height from
267 frames size_hint to set minimum and natural (Bug#8919).
268 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
269 and use min_width/height from frames size_hint to set
270 min_width/height (Bug#8919).
272 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
273 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. Fix
276 2011-06-26 Eli Zaretskii <eliz@gnu.org>
278 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
279 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
282 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
284 * process.c (wait_reading_process_output): Bypass select if
285 waiting for a cell while ignoring keyboard input, and input is
286 pending. Suggested by Jan Djärv (Bug#8869).
288 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
290 Use gnulib's dup2 module instead of rolling our own.
291 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
293 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
295 * dispnew.c (scrolling_window): Before scrolling, turn off a
296 mouse-highlight in the window being scrolled.
298 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
300 Move DEFSYM to lisp.h and use everywhere.
302 * character.h (DEFSYM): Move declaration...
303 * lisp.h (DEFSYM): ...here.
309 * w32select.c: Don't include character.h.
311 * alloc.c (syms_of_alloc):
312 * buffer.c (syms_of_buffer):
313 * bytecode.c (syms_of_bytecode):
314 * callint.c (syms_of_callint):
315 * casefiddle.c (syms_of_casefiddle):
316 * casetab.c (init_casetab_once):
317 * category.c (init_category_once, syms_of_category):
318 * ccl.c (syms_of_ccl):
319 * cmds.c (syms_of_cmds):
320 * composite.c (syms_of_composite):
321 * dbusbind.c (syms_of_dbusbind):
322 * dired.c (syms_of_dired):
323 * dispnew.c (syms_of_display):
324 * doc.c (syms_of_doc):
325 * editfns.c (syms_of_editfns):
326 * emacs.c (syms_of_emacs):
327 * eval.c (syms_of_eval):
328 * fileio.c (syms_of_fileio):
329 * fns.c (syms_of_fns):
330 * frame.c (syms_of_frame):
331 * fringe.c (syms_of_fringe):
332 * insdel.c (syms_of_insdel):
333 * keymap.c (syms_of_keymap):
334 * lread.c (init_obarray, syms_of_lread):
335 * macros.c (syms_of_macros):
336 * msdos.c (syms_of_msdos):
337 * print.c (syms_of_print):
338 * process.c (syms_of_process):
339 * search.c (syms_of_search):
340 * sound.c (syms_of_sound):
341 * syntax.c (init_syntax_once, syms_of_syntax):
342 * terminal.c (syms_of_terminal):
343 * textprop.c (syms_of_textprop):
344 * undo.c (syms_of_undo):
345 * w32.c (globals_of_w32):
346 * window.c (syms_of_window):
347 * xdisp.c (syms_of_xdisp):
348 * xfaces.c (syms_of_xfaces):
349 * xfns.c (syms_of_xfns):
350 * xmenu.c (syms_of_xmenu):
351 * xsettings.c (syms_of_xsettings):
352 * xterm.c (syms_of_xterm): Use DEFSYM.
354 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
356 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
358 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
360 Integer and buffer overflow fixes (Bug#8873).
362 * print.c (printchar, strout): Check for string overflow.
363 (PRINTPREPARE, printchar, strout):
364 Don't set size unless allocation succeeds.
366 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
367 for sizes. Check for string overflow more accurately.
368 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
370 * macros.c: Integer and buffer overflow fixes.
371 * keyboard.h (struct keyboard.kbd_macro_bufsize):
372 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
373 Use ptrdiff_t, not int, for sizes.
374 Don't increment bufsize until after realloc succeeds.
375 Check for size-calculation overflow.
376 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
378 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
380 * lread.c: Integer overflow fixes.
381 (read_integer): Radix is now EMACS_INT, not int,
382 to improve quality of diagnostics for out-of-range radices.
383 Calculate buffer size correctly for out-of-range radices.
384 (read1): Check for integer overflow in radices, and in
386 (read_escape): Avoid int overflow.
387 (Fload, openp, read_buffer_size, read1)
388 (substitute_object_recurse, read_vector, read_list, map_obarray):
389 Use ptrdiff_t, not int, for sizes.
390 (read1): Use EMACS_INT, not int, for sizes.
391 Check for size overflow.
393 * image.c (cache_image): Check for size arithmetic overflow.
395 * lread.c: Integer overflow issues.
396 (saved_doc_string_size, saved_doc_string_length)
397 (prev_saved_doc_string_size, prev_saved_doc_string_length):
398 Now ptrdiff_t, not int.
399 (read1): Don't assume doc string length fits in int. Check for
400 out-of-range doc string lengths.
401 (read_list): Don't assume file position fits in int.
402 (read_escape): Check for hex character overflow.
404 2011-06-22 Leo Liu <sdl.web@gmail.com>
406 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
407 Move to minibuffer.el.
409 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
411 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
412 The following patches are for when GLYPH_DEBUG && !XASSERT.
413 * dispextern.h (trace_redisplay_p, dump_glyph_string):
414 * dispnew.c (flush_stdout):
415 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
416 Mark as externally visible.
417 * dispnew.c (check_window_matrix_pointers): Now static.
418 * dispnew.c (window_to_frame_vpos):
419 * xfns.c (unwind_create_frame):
420 * xterm.c (x_check_font): Remove unused local.
421 * scroll.c (CHECK_BOUNDS):
422 * xfaces.c (cache_fache): Rename local to avoid shadowing.
423 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
424 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
425 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
426 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
428 (debug_method_add): Use va_list and vsprintf rather than relying
429 on undefined behavior with wrong number of arguments.
430 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
431 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
432 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
433 since we're not interested in debugging glyphs with old libraries.
434 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
435 GCC 4.6.0's static checking.
437 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
439 Integer overflow and signedness fixes (Bug#8873).
440 A few related buffer overrun fixes, too.
442 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
444 * dispextern.h (struct face.stipple):
445 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
446 (x_bitmap_mask, x_allocate_bitmap_record)
447 (x_create_bitmap_from_data, x_create_bitmap_from_file)
448 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
449 (x_create_bitmap_from_xpm_data):
450 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
451 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
453 * xfaces.c (load_pixmap):
454 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
455 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
456 (.bitmaps_last, struct x_output.icon_bitmap):
457 Use ptrdiff_t, not int, for bitmap indexes.
458 (x_allocate_bitmap_record): Check for size overflow.
459 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
461 Use ptrdiff_t, not int, for overlay counts.
462 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
463 * editfns.c (overlays_around, get_pos_property):
464 * textprop.c (get_char_property_and_overlay):
465 * xdisp.c (next_overlay_change, note_mouse_highlight):
466 * xfaces.c (face_at_buffer_position):
467 * buffer.c (OVERLAY_COUNT_MAX): New macro.
468 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
469 (Fnext_overlay_change, Fprevious_overlay_change)
470 (mouse_face_overlay_overlaps, Foverlays_in):
471 Use ptrdiff_t, not int, for sizes.
472 (overlays_at, overlays_in): Check for size-calculation overflow.
474 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
476 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
477 (x_session_initialize): Do not assume string length fits in int.
479 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
480 This is unlikely, but can occur if DPI is outlandish.
482 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
483 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
485 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
486 * xrdb.c (magic_file_p, search_magic_path):
487 Omit last arg SUFFIX; it was always 0. All callers changed.
488 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
490 * xfont.c (xfont_match): Avoid need for strlen.
492 * xfns.c: Don't assume strlen fits in int.
493 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
495 * xdisp.c (message_log_check_duplicate): Return intmax_t,
496 not unsigned long, as we prefer signed integers. All callers changed.
497 Detect integer overflow in repeat count.
498 (message_dolog): Don't assume print length fits in 39 bytes.
499 (display_mode_element): Don't assume strlen fits in int.
501 * termcap.c: Don't assume sizes fit in int and never overflow.
502 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
503 (gobble_line): Check for size-calculation overflow.
505 * minibuf.c (Fread_buffer):
506 * lread.c (intern, intern_c_string):
507 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
508 Don't assume string length fits in int.
510 * keyboard.c (parse_tool_bar_item):
511 * gtkutil.c (style_changed_cb): Avoid need for strlen.
513 * font.c: Don't assume string length fits in int.
514 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
515 Use ptrdiff_t, not int.
516 (font_intern_prop): Don't assume string length fits in int.
517 Don't assume integer property fits in fixnum.
518 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
520 * filelock.c: Fix some buffer overrun and integer overflow issues.
521 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
522 Reformulate so as not to need the command string.
523 Invoke gzip -cd rather than gunzip, as it's more portable.
524 (lock_info_type, lock_file_1, lock_file):
525 Don't assume pid_t and time_t fit in unsigned long.
526 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
527 (current_lock_owner): Prefer signed type for sizes.
528 Use memcpy, not strncpy, where memcpy is what is really wanted.
529 Don't assume (via atoi) that time_t and pid_t fit in int.
530 Check for time_t and/or pid_t out of range, e.g., via a network share.
531 Don't alloca where an auto var works fine.
533 * fileio.c: Fix some integer overflow issues.
534 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
535 Don't assume string length fits in int.
536 (directory_file_name): Don't assume string length fits in long.
537 (make_temp_name): Don't assume pid fits in int, or that its print
538 length is less than 20.
540 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
542 * coding.c (make_subsidiaries): Don't assume string length fits in int.
544 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
546 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
547 We prefer signed integers, even for size calculations.
549 * emacs.c: Don't assume string length fits in 'int'.
550 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
551 (main): Don't invoke strlen when not needed.
553 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
554 (XD_DEBUG_MESSAGE): Don't waste a byte.
556 * callproc.c (getenv_internal_1, getenv_internal)
558 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
560 * lread.c (invalid_syntax): Omit length argument.
561 All uses changed. This doesn't fix a bug, but it simplifies the
562 code away from its former Hollerith-constant appearance, and it's
563 one less 'int' to worry about when looking at integer-overflow issues.
564 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
566 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
567 This didn't break anything, but it didn't help either.
568 It's confusing to put a bogus integer in a place where the actual
569 value does not matter.
570 (LIST_END_P): Remove unused macro and its bogus comment.
571 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
573 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
574 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
576 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
577 We prefer signed types, and the value cannot exceed the EMACS_INT
578 range anyway (because otherwise the length would not be representable).
579 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
580 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
581 This avoids a GCC warning when WIDE_EMACS_INT.
583 * indent.c (sane_tab_width): New function.
584 (current_column, scan_for_column, Findent_to, position_indentation)
585 (compute_motion): Use it. This is just for clarity.
586 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
588 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
590 * lisp.h (lint_assume): New macro.
591 * composite.c (composition_gstring_put_cache):
592 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
594 * editfns.c, insdel.c:
595 Omit unnecessary forward decls, to simplify future changes.
597 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
599 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
601 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
602 Use much-faster test for byte-length change.
603 Don't assume string byte-length fits in 'int'.
604 Check that character arg fits in 'int'.
605 (mapcar1): Declare byte as byte, for clarity.
607 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
609 * fns.c (concat): Catch string overflow earlier.
610 Do not rely on integer wraparound.
612 * dispextern.h (struct it.overlay_strings_charpos)
613 (struct it.selective): Now EMACS_INT, not int.
614 * xdisp.c (forward_to_next_line_start)
615 (back_to_previous_visible_line_start)
616 (reseat_at_next_visible_line_start, next_element_from_buffer):
617 Don't arbitrarily truncate the value of 'selective' to int.
619 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
621 * composite.c: Don't truncate sizes to 'int'.
622 (composition_gstring_p, composition_reseat_it)
623 (composition_adjust_point): Use EMACS_INT, not int.
624 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
625 not EMACS_UINT, for indexes.
627 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
629 * buffer.c: Include <verify.h>.
630 (struct sortvec.priority, struct sortstr.priority):
631 Now EMACS_INT, not int.
632 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
633 (struct sortstr.size, record_overlay_string)
634 (struct sortstrlist.size, struct sortlist.used):
635 Don't truncate size to int.
636 (record_overlay_string): Check for size-calculation overflow.
637 (init_buffer_once): Check at compile-time, not run-time.
639 2011-06-22 Jim Meyering <meyering@redhat.com>
641 Don't leak an XBM-image-sized buffer
642 * image.c (xbm_load): Free the image buffer after using it.
644 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
647 * composite.c (find_automatic_composition): Omit needless 'return 0;'
648 that Sun C diagnosed.
649 * fns.c (secure_hash): Fix pointer signedness issue.
650 * intervals.c (static_offset_intervals): New function.
651 (offset_intervals): Use it.
653 2011-06-21 Leo Liu <sdl.web@gmail.com>
656 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
659 * fns.c (secure_hash): Rename from crypto_hash_function and change
660 the first arg to accept symbols.
661 (Fsecure_hash): New primitive.
662 (syms_of_fns): New symbols.
664 2011-06-20 Deniz Dogan <deniz@dogan.se>
666 * process.c (Fset_process_buffer): Clarify return value in
669 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
671 * dispnew.c (add_window_display_history): Use BVAR.
673 * xdisp.c (debug_method_add): Use BVAR.
674 (check_window_end, dump_glyph_matrix, dump_glyph)
675 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
677 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
680 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
681 check till after the cache is created in init_frame_faces.
683 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
685 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
687 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
689 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
690 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
691 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
693 Improve buffer-overflow checking (Bug#8873).
694 * fileio.c (Finsert_file_contents):
695 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
696 Remove the old (too-loose) buffer overflow checks.
697 They weren't needed, since make_gap checks for buffer overflow.
698 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
699 The old code merely checked for Emacs fixnum overflow, and relied
700 on undefined (wraparound) behavior. The new code avoids undefined
701 behavior, and also checks for ptrdiff_t and/or size_t overflow.
703 * editfns.c (Finsert_char): Don't dump core with very negative counts.
704 Tune. Don't use wider integers than needed. Don't use alloca.
705 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
707 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
709 * insdel.c, lisp.h (buffer_overflow): New function.
710 (insert_from_buffer_1, replace_range, replace_range_2):
711 * insdel.c (make_gap_larger):
712 * editfns.c (Finsert_char):
713 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
715 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
717 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
719 Integer overflow and signedness fixes (Bug#8873).
721 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
722 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
724 * fileio.c: Don't assume EMACS_INT fits in off_t.
725 (emacs_lseek): New static function.
726 (Finsert_file_contents, Fwrite_region): Use it.
727 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
729 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
731 * fns.c: Don't overflow int when computing a list length.
732 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
733 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
734 truncation on 64-bit hosts. Check for QUIT every
735 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
736 faster and is responsive enough.
737 (Flength): Report an error instead of overflowing an integer.
738 (Fsafe_length): Return a float if the value is not representable
739 as a fixnum. This shouldn't happen except in contrived situations.
740 (Fnthcdr, Fsort): Don't assume list length fits in int.
741 (Fcopy_sequence): Don't assume vector length fits in int.
743 * alloc.c: Check that resized vectors' lengths fit in fixnums.
744 (header_size, word_size): New constants.
745 (allocate_vectorlike): Don't check size overflow here.
746 (allocate_vector): Check it here instead, since this is the only
747 caller of allocate_vectorlike that could cause overflow.
748 Check that the new vector's length is representable as a fixnum.
750 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
751 The previous code was bogus. For example, next_almost_prime (32)
752 returned 39, which is undesirable as it is a multiple of 3; and
753 next_almost_prime (24) returned 25, which is a multiple of 5 so
754 why was the code bothering to check for multiples of 7?
756 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
758 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
760 Variadic C functions now count arguments with ptrdiff_t.
761 This partly undoes my 2011-03-30 change, which replaced int with size_t.
762 Back then I didn't know that the Emacs coding style prefers signed int.
763 Also, in the meantime I found a few more instances where arguments
764 were being counted with int, which may truncate counts on 64-bit
765 machines, or EMACS_INT, which may be unnecessarily wide.
766 * lisp.h (struct Lisp_Subr.function.aMANY)
767 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
768 Arg counts are now ptrdiff_t, not size_t.
769 All variadic functions and their callers changed accordingly.
770 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
771 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
772 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
773 * callint.c (Fcall_interactively): Check arg count for overflow,
774 to avoid potential buffer overrun. Use signed char, not 'int',
775 for 'varies' array, so that we needn't bother to check its size
776 calculation for overflow.
777 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
778 * eval.c (apply_lambda):
779 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
780 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
781 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
783 * callint.c (Fcall_interactively): Don't use index var as event count.
785 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
786 * mem-limits.h (SIZE): Remove; no longer used.
788 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
790 Remove unnecessary casts.
791 * xterm.c (x_term_init):
792 * xfns.c (x_set_border_pixel):
793 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
794 These aren't needed now that we assume ANSI C.
796 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
797 It's more likely to cause problems (due to unsigned overflow)
800 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
802 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
804 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
806 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
808 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
810 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
812 GLYPH_CODE_FACE returns EMACS_INT, not int.
813 * dispextern.h (merge_faces):
814 * xfaces.c (merge_faces):
815 * xdisp.c (get_next_display_element, next_element_from_display_vector):
816 Don't assume EMACS_INT fits in int.
818 * character.h (CHAR_VALID_P): Remove unused parameter.
819 * fontset.c, lisp.h, xdisp.c: All uses changed.
821 * editfns.c (Ftranslate_region_internal): Omit redundant test.
823 * fns.c (concat): Minor tuning based on overflow analysis.
824 This doesn't fix any bugs. Use int to hold character, instead
825 of constantly refetching from Emacs object. Use XFASTINT, not
826 XINT, for value known to be a character. Don't bother comparing
827 a single byte to 0400, as it's always less.
829 * floatfns.c (Fexpt):
830 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
832 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
835 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
837 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
838 Without this fix, on a 64-bit host (aset S 0 4294967386) would
839 incorrectly succeed when S was a string, because 4294967386 was
840 truncated before it was used.
842 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
843 Otherwise, an out-of-range integer could cause undefined behavior
846 * composite.c: Use int, not EMACS_INT, for characters.
847 (fill_gstring_body, composition_compute_stop_pos): Use int, not
848 EMACS_INT, for values that are known to be in character range.
849 This doesn't fix any bugs but is the usual style inside Emacs and
850 may generate better code on 32-bit machines.
852 Make sure a 64-bit char is never passed to ENCODE_CHAR.
853 This is for reasons similar to the recent CHAR_STRING fix.
854 * charset.c (Fencode_char): Check that character arg is actually
855 a character. Pass an int to ENCODE_CHAR.
856 * charset.h (ENCODE_CHAR): Verify that the character argument is no
857 wider than 'int', as a compile-time check to prevent future regressions
860 * character.c (char_string): Remove unnecessary casts.
862 Make sure a 64-bit char is never passed to CHAR_STRING.
863 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
864 by silently ignoring the top 32 bits, allowing some values
865 that were far too large to be valid characters.
866 * character.h: Include <verify.h>.
867 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
868 arguments are no wider than unsigned, as a compile-time check
869 to prevent future regressions in this area.
871 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
872 (Fsubst_char_in_region):
874 * xdisp.c (decode_mode_spec_coding):
875 Adjust to CHAR_STRING's new requirement.
876 * editfns.c (Finsert_char, Fsubst_char_in_region):
877 * fns.c (concat): Check that character args are actually
878 characters. Without this test, these functions did the wrong
879 thing with wildly out-of-range values on 64-bit hosts.
881 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
882 These casts should not be needed on 32-bit hosts, either.
883 * keyboard.c (read_char):
884 * lread.c (Fload): Remove casts to unsigned.
886 * lisp.h (UNSIGNED_CMP): New macro.
887 This fixes comparison bugs on 64-bit hosts.
888 (ASCII_CHAR_P): Use it.
889 * casefiddle.c (casify_object):
890 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
891 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
892 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
893 * dispextern.h (FACE_FROM_ID):
894 * keyboard.c (read_char): Use UNSIGNED_CMP.
896 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
897 not to EMACS_INT, to avoid GCC warning.
899 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
901 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
902 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
903 isn't needed on 32-bit machines.
905 * buffer.c (Fgenerate_new_buffer_name):
906 Use EMACS_INT for count, not int.
907 (advance_to_char_boundary): Return EMACS_INT, not int.
909 * data.c (Qcompiled_function): Now static.
911 * window.c (window_body_lines): Now static.
913 * image.c (gif_load): Rename local to avoid shadowing.
915 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
916 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
917 * alloc.c (make_save_value): Integer argument is now of type
919 (mark_object): Use ptrdiff_t, not int.
920 * lisp.h (pD): New macro.
921 * print.c (print_object): Use it.
923 * alloc.c: Use EMACS_INT, not int, to count objects.
924 (total_conses, total_markers, total_symbols, total_vector_size)
925 (total_free_conses, total_free_markers, total_free_symbols)
926 (total_free_floats, total_floats, total_free_intervals)
927 (total_intervals, total_strings, total_free_strings):
928 Now EMACS_INT, not int. All uses changed.
929 (Fgarbage_collect): Compute overall total using a double, so that
930 integer overflow is less likely to be a problem. Check for overflow
931 when converting back to an integer.
932 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
933 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
934 These were 'int' variables that could overflow on 64-bit hosts;
935 they were never used, so remove them instead of repairing them.
936 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
937 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
938 Previously, this ceilinged at INT_MAX, but that doesn't work on
940 (allocate_pseudovector): Don't use EMACS_INT when int would do.
942 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
943 (allocate_vectorlike): Check for ptrdiff_t overflow.
944 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
945 when a (possibly-narrower) signed value would do just as well.
946 We prefer using signed arithmetic, to avoid comparison confusion.
948 * alloc.c: Catch some string size overflows that we were missing.
949 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
950 for convenience in STRING_BYTES_MAX.
951 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
952 The definition here is exact; the one in lisp.h was approximate.
953 (allocate_string_data): Check for string overflow. This catches
954 some instances we weren't catching before. Also, it catches
955 size_t overflow on (unusual) hosts where SIZE_MAX <= min
956 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
957 and ptrdiff_t and EMACS_INT are both 64 bits.
959 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
960 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
961 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
963 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
965 * alloc.c (Fmake_string): Check for out-of-range init.
967 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
969 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
971 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
973 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
974 xg_get_default_scrollbar_width.
976 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
977 (int_gtk_range_get_value): Move to the scroll bar part of the file.
978 (style_changed_cb): Call update_theme_scrollbar_width and call
979 x_set_scroll_bar_default_width and xg_frame_set_char_size for
980 all frames (Bug#8505).
981 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
982 Call gtk_window_set_resizable if HAVE_GTK3.
983 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
984 and height if HAVE_GTK3 (Bug#8505).
985 (scroll_bar_width_for_theme): New variable.
986 (update_theme_scrollbar_width): New function.
987 (xg_get_default_scrollbar_width): Move code to
988 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
989 (xg_initialize): Call update_theme_scrollbar_width.
991 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
993 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
995 2011-06-12 Martin Rudalics <rudalics@gmx.at>
997 * frame.c (make_frame): Call other_buffer_safely instead of
1000 * window.c (temp_output_buffer_show): Call display_buffer with
1001 second argument Vtemp_buffer_show_specifiers and reset latter
1002 immediately after the call.
1003 (Vtemp_buffer_show_specifiers): New variable.
1004 (auto_window_vscroll_p, next_screen_context_lines)
1005 (Vscroll_preserve_screen_position): Remove leading asterisks from
1008 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1010 Fix minor problems found by GCC 4.6.0 static checking.
1011 * buffer.c (Qclone_number): Remove for now, as it's unused.
1012 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1013 (record_buffer): Remove unused local.
1014 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1015 (set_frame_buffer_list): Remove; unused.
1016 * frame.h (other_visible_frames): Remove decl.
1017 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1018 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1019 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1021 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1022 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1023 Define only if HAVE_GPM.
1024 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1025 (update_hints_inhibit): Remove; never set. All uses removed.
1026 * widgetprv.h (emacsFrameClassRec): Remove decl.
1027 * window.c (delete_deletable_window): Now returns void, since it
1028 wasn't returning anything.
1029 (compare_window_configurations): Remove unused locals.
1030 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1031 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1032 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1033 the same widths as pointers. This follows up on the 2011-05-06 patch.
1034 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1035 * xterm.h: Likewise.
1036 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1038 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1040 * makefile.w32-in: Update dependencies.
1041 (LISP_H): Add lib/intprops.h.
1043 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1045 * image.c (gif_load): Add animation frame delay to the metadata.
1046 (syms_of_image): Use DEFSYM. New symbol `delay'.
1048 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1050 * window.c (delete_deletable_window): Re-add.
1051 (Fset_window_configuration): Rewrite to handle dead buffers and
1052 consequently deletable windows.
1053 (window_tree, Fwindow_tree): Remove. Supply functionality in
1055 (compare_window_configurations): Simplify code.
1057 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1059 * image.c (imagemagick_load_image): Fix type mismatch.
1060 (Fimagemagick_types): Likewise.
1062 * window.h (replace_buffer_in_windows): Declare.
1064 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1066 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1067 Qclone_number. Remove external declaration of Qdelete_window.
1068 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1070 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1071 Qbuffer_list_update_hook if allowed.
1072 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1073 buffer list implementation.
1074 (other_buffer_safely): New function.
1075 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1076 calls to replace_buffer_in_windows and
1077 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1079 (record_buffer): Inhibit quitting and rewrite using quittable
1080 functions. Run Qbuffer_list_update_hook if allowed.
1081 (Frecord_buffer, Funrecord_buffer): New functions.
1082 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1083 switch-to-buffer to window.el.
1084 (bury-buffer): Move to window.el.
1085 (Vbuffer_list_update_hook): New variable.
1087 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1090 * window.h (resize_frame_windows): Move up in code.
1091 (Fwindow_frame): Remove EXFUN.
1092 (replace_buffer_in_all_windows): Remove prototype.
1093 (replace_buffer_in_windows_safely): Add prototype.
1095 * window.c: Declare Qdelete_window static again. Move down
1096 declaration of select_count.
1097 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1098 (Fother_window): Move to window.el.
1099 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1100 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1101 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1103 (replace_buffer_in_windows): Implement by calling
1104 Qreplace_buffer_in_windows.
1105 (replace_buffer_in_all_windows): Remove with some functionality
1106 moved into replace_buffer_in_windows_safely.
1107 (replace_buffer_in_windows_safely): New function.
1108 (select_window_norecord, select_frame_norecord): Move in front
1109 of run_window_configuration_change_hook. Remove now obsolete
1111 (Fset_window_buffer): Rewrite doc-string. Call
1112 Qrecord_window_buffer.
1113 (keys_of_window): Move binding for other-window to window.el.
1115 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1117 * dispextern.h (struct image): Replace data member, whose int_val
1118 and ptr_val fields were not used by anything, with a single
1121 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1122 (gif_clear_image, gif_load, imagemagick_load_image)
1123 (gs_clear_image, gs_load): Callers changed.
1125 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1127 * buffer.h: Include <time.h>, for time_t.
1128 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1130 Fix minor problems found by static checking.
1132 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1134 Make identifiers static if they are not used in other modules.
1135 * data.c (Qcompiled_function, Qframe, Qvector):
1136 * image.c (QimageMagick, Qsvg):
1137 * minibuf.c (Qmetadata):
1138 * window.c (resize_window_check, resize_root_window): Now static.
1139 * window.h (resize_window_check, resize_root_window): Remove decls.
1141 * window.c (window_deletion_count, delete_deletable_window):
1143 (window_body_lines): Now static.
1144 (Fdelete_other_windows_internal): Mark vars as initialized.
1145 Make sure 'resize_failed' is initialized.
1146 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1147 (resize_window_apply): Remove unused local.
1148 * window.h (delete_deletable_window): Remove decl.
1150 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1151 (imagemagick_load_image): Fix pointer signedness problem by changing
1152 last arg from unsigned char * to char *. All uses changed.
1153 Also, fix a local for similar reasons.
1154 Remove unused locals. Remove locals to avoid shadowing.
1155 (fn_rsvg_handle_free): Remove; unused.
1156 (svg_load, svg_load_image): Fix pointer signedness problem.
1157 (imagemagick_load_image): Don't use garbage pointer image_wand.
1159 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1161 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1163 * image.c (gif_load): Fix omitted cast error introduced by
1166 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1168 * window.h (resize_proportionally, orig_total_lines)
1169 (orig_top_line): Remove from window structure.
1170 (set_window_height, set_window_width, change_window_heights)
1171 (Fdelete_window): Remove prototypes.
1172 (resize_frame_windows): Remove duplicate declaration.
1174 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1176 * window.h (resize_frame_windows, resize_window_check)
1177 (delete_deletable_window, resize_root_window)
1178 (resize_frame_windows): Declare prototypes.
1180 * window.c (resize_window_apply): Make definition be "static" to
1181 match the prototype.
1183 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1185 * window.c: Remove declarations of Qwindow_size_fixed,
1186 window_min_size_1, window_min_size_2, window_min_size,
1187 size_window, window_fixed_size_p, enlarge_window, delete_window.
1188 Remove static from declaration of Qdelete_window, it's
1189 temporarily needed by Fbury_buffer.
1190 (replace_window): Don't assign orig_top_line and
1192 (Fdelete_window, delete_window): Remove. Window deletion is
1193 handled by window.el.
1194 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1195 Fdelete_window calls with calls to Qdelete_window.
1196 (Fdelete_other_windows): Remove. Deleting other windows is
1197 handled by window.el.
1198 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1199 handled in window.el.
1200 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1201 Window minimum sizes are handled in window.el.
1202 (shrink_windows, size_window, set_window_height)
1203 (set_window_width, change_window_heights, window_height)
1204 (window_width, CURBEG, CURSIZE, enlarge_window)
1205 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1206 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1207 handled in window.el.
1208 (make_dummy_parent): Rename to make_parent_window and give it a
1209 second argument horflag.
1210 (make_window): Don't set resize_proportionally any more.
1211 (Fsplit_window): Remove. Windows are split in window.el.
1212 (save_restore_action, save_restore_orig_size)
1213 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1214 Resize mini windows in window.el.
1215 (grow_mini_window, shrink_mini_window): Implement by calling
1216 Qresize_root_window_vertically, resize_window_check and
1217 resize_window_apply.
1218 (saved_window, Fset_window_configuration, save_window_save): Do
1219 not handle orig_top_line, orig_total_lines, and
1220 resize_proportionally.
1221 (window_min_height, window_min_width): Move to window.el.
1222 (keys_of_window): Move bindings for delete-other-windows,
1223 split-window, delete-window and enlarge-window to window.el.
1225 * buffer.c: Temporarily extern Qdelete_window.
1226 (Fbury_buffer): Temporarily call Qdelete_window instead of
1227 Fdelete_window (Fbury_buffer will move to window.el soon).
1229 * frame.c (set_menu_bar_lines_1): Remove code handling
1230 orig_top_line and orig_total_lines.
1232 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1233 set_window_height but set heights directly.
1234 (change_frame_size_1): Use resize_frame_windows.
1236 * xdisp.c (init_xdisp): Don't use set_window_height but set
1239 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1240 resize_frame_windows instead of change_window_heights and run
1241 run_window_configuration_change_hook.
1243 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1244 instead of change_window_heights and run
1245 run_window_configuration_change_hook.
1247 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1249 * window.c (replace_window): Rename second argument REPLACEMENT to
1250 NEW. New third argument SETFLAG. Rewrite.
1251 (delete_window, make_dummy_parent): Call replace_window with
1253 (window_list_1): Move down in code.
1254 (run_window_configuration_change_hook): Move set_buffer part
1255 before select_frame_norecord part in order to unwind correctly.
1256 Rename count1 to count.
1257 (recombine_windows, delete_deletable_window, resize_root_window)
1258 (Fdelete_other_windows_internal)
1259 (Frun_window_configuration_change_hook, make_parent_window)
1260 (resize_window_check, resize_window_apply, Fresize_window_apply)
1261 (resize_frame_windows, Fsplit_window_internal)
1262 (Fdelete_window_internal, Fresize_mini_window_internal): New
1264 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1266 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1268 * window.h (window): Add some new members to window structure -
1269 normal_lines, normal_cols, new_total, new_normal, clone_number,
1270 splits, nest, prev_buffers, next_buffers.
1271 (WINDOW_TOTAL_SIZE): Move here from window.c.
1272 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1274 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1276 (make_dummy_parent): Set new members of windows structure.
1277 (make_window): Move down in code. Handle new members of window
1279 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1280 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1281 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1282 (Fset_window_prev_buffers, Fwindow_next_buffers)
1283 (Fset_window_next_buffers, Fset_window_clone_number): New
1285 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1286 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1288 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1289 Argument WINDOW can be now internal window too.
1290 (Fwindow_use_time): Move up in code.
1291 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1293 (Fset_window_configuration, saved_window)
1294 (Fcurrent_window_configuration, save_window_save): Handle new
1295 members of window structure.
1296 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1297 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1298 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1299 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1300 Qget_mru_window, Qresize_root_window,
1301 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1302 Qauto_buffer_name; staticpro them.
1304 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1306 * window.c (Fwindow_total_size, Fwindow_left_column)
1307 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1308 (Fwindow_list_1): New functions.
1309 (window_box_text_cols): Replace with window_body_cols.
1310 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1311 window_body_cols instead of window_box_text_cols.
1312 (delete_window, Fset_window_configuration): Call
1313 delete_all_subwindows with window as argument.
1314 (delete_all_subwindows): Take a window as argument and not a
1316 (window_loop): Remove handling of GET_LRU_WINDOW and
1318 (Fget_lru_window, Fget_largest_window): Move to window.el.
1320 * window.h: Extern window_body_cols instead of
1321 window_box_text_cols. delete_all_subwindows now takes a
1322 Lisp_Object as argument.
1324 * indent.c (compute_motion, Fcompute_motion): Use
1325 window_body_cols instead of window_box_text_cols.
1327 * frame.c (delete_frame): Call delete_all_subwindows with root
1330 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1332 * fns.c (Fputhash): Document return value.
1334 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1336 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1338 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1340 Cons<->int and similar integer overflow fixes (Bug#8794).
1342 Check for overflow when converting integer to cons and back.
1343 * charset.c (Fdefine_charset_internal, Fdecode_char):
1344 Use cons_to_unsigned to catch overflow.
1345 (Fencode_char): Use INTEGER_TO_CONS.
1346 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1347 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1348 * data.c (long_to_cons, cons_to_long): Remove.
1349 (cons_to_unsigned, cons_to_signed): New functions.
1350 These signal an error for invalid or out-of-range values.
1351 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1352 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1353 * font.c (Ffont_variation_glyphs):
1354 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1355 * lisp.h: Include <intprops.h>.
1356 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1357 (cons_to_signed, cons_to_unsigned): New decls.
1358 (long_to_cons, cons_to_long): Remove decls.
1359 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1360 (Fprimitive_undo): Use CONS_TO_INTEGER.
1361 * xfns.c (Fx_window_property): Likewise.
1362 * xselect.c: Include <limits.h>.
1363 (x_own_selection, selection_data_to_lisp_data):
1364 Use INTEGER_TO_CONS.
1365 (x_handle_selection_request, x_handle_selection_clear)
1366 (x_get_foreign_selection, Fx_disown_selection_internal)
1367 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1368 (lisp_data_to_selection_data): Use cons_to_unsigned.
1369 (x_fill_property_data): Use cons_to_signed.
1370 Report values out of range.
1372 Check for buffer and string overflow more precisely.
1373 * buffer.h (BUF_BYTES_MAX): New macro.
1374 * lisp.h (STRING_BYTES_MAX): New macro.
1375 * alloc.c (Fmake_string):
1376 * character.c (string_escape_byte8):
1377 * coding.c (coding_alloc_by_realloc):
1378 * doprnt.c (doprnt):
1379 * editfns.c (Fformat):
1381 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1382 since they may not be the same number.
1383 * editfns.c (Finsert_char):
1384 * fileio.c (Finsert_file_contents):
1385 Likewise for BUF_BYTES_MAX.
1387 * image.c: Use ptrdiff_t, not int, for sizes.
1388 (slurp_file): Switch from int to ptrdiff_t.
1390 (slurp_file): Check that file size fits in both size_t (for
1391 malloc) and ptrdiff_t (for sanity and safety).
1393 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1394 if b->modtime has its maximal value.
1396 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1398 Don't assume time_t can fit into int.
1399 * buffer.h (struct buffer.modtime): Now time_t, not int.
1400 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1401 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1403 Minor fixes for signed vs unsigned integers.
1404 * character.h (MAYBE_UNIFY_CHAR):
1405 * charset.c (maybe_unify_char):
1406 * keyboard.c (read_char, reorder_modifiers):
1407 XINT -> XFASTINT, since the integer must be nonnegative.
1408 * ftfont.c (ftfont_spec_pattern):
1409 * keymap.c (access_keymap, silly_event_symbol_error):
1410 XUINT -> XFASTINT, since the integer must be nonnegative.
1411 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1412 since it makes no difference and we prefer signed.
1413 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1414 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1417 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1419 * window.h (Fwindow_frame): Declare.
1421 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1423 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1424 (SPARE_MEMORY): Always define.
1425 (LARGE_REQUEST): Remove.
1426 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1428 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1430 * lisp.h: Move EXFUNS for Fframe_root_window,
1431 Fframe_first_window and Fset_frame_selected_window to window.h.
1433 * window.h: Move EXFUNS for Fframe_root_window,
1434 Fframe_first_window and Fset_frame_selected_window here from
1437 * frame.c (Fwindow_frame, Fframe_first_window)
1438 (Fframe_root_window, Fframe_selected_window)
1439 (Fset_frame_selected_window): Move to window.c.
1440 (Factive_minibuffer_window): Move to minibuf.c.
1441 (Fother_visible_frames_p): New function.
1443 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1445 * window.c (decode_window, decode_any_window): Move up in code.
1446 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1447 (inhibit_frame_unsplittable): Remove unused variable.
1448 (Fwindow_buffer): Move up and rewrite doc-string.
1449 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1450 (Fwindow_prev): New functions.
1451 (Fwindow_frame): Move here from frame.c. Accept any window as
1453 (Fframe_root_window, Fframe_first_window)
1454 (Fframe_selected_window): Move here from frame.c. Accept frame
1455 or arbitrary window as argument. Update doc-strings.
1456 (Fminibuffer_window): Move up in code.
1457 (Fwindow_minibuffer_p): Move up in code and simplify.
1458 (Fset_frame_selected_window): Move here from frame.c.
1460 (Fselected_window, select_window, Fselect_window): Move up in
1461 code. Minor doc-string fixes.
1463 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1465 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1466 Do not assume that spare memory exists; that assumption is valid
1467 only if SYSTEM_MALLOC.
1468 (LARGE_REQUEST): New macro, so that the issue of large requests
1469 is separated from the issue of spare memory.
1471 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1473 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1476 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1478 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1481 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1483 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1485 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1487 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1488 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1490 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1492 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1494 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1496 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1497 (x_clipboard_manager_save): Add return value.
1498 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1500 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1501 Obey Vx_select_enable_clipboard_manager. Catch errors in
1502 x_clipboard_manager_save (Bug#8779).
1503 (Vx_select_enable_clipboard_manager): New variable.
1504 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1506 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1508 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1510 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1512 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1513 in the current matrix if keep_current_p is non-zero.
1515 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1517 * bidi.c (bidi_level_of_next_char): Fix last change.
1519 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1521 Support bidi reordering of text covered by display properties.
1523 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1524 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1525 (bidi_cache_search, bidi_cache_iterator_state)
1526 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1527 (bidi_level_of_next_char, bidi_move_to_visually_next):
1528 Support character positions inside a run of characters covered by a
1530 (bidi_paragraph_init, bidi_resolve_explicit_1)
1531 (bidi_level_of_next_char): Call bidi_fetch_char and
1532 bidi_fetch_char_advance instead of FETCH_CHAR and
1534 (bidi_init_it): Initialize new members.
1535 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1537 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1538 instead of using explicit *_CHAR codes.
1539 (bidi_resolve_explicit, bidi_resolve_weak):
1540 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1541 bidirectional text is supported only in multibyte buffers.
1542 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1543 it to initialize the frame_window_p member of struct bidi_it.
1544 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1545 (bidi_resolve_explicit, bidi_resolve_weak)
1546 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1547 bidi_it->nchars is non-positive.
1548 (bidi_level_of_next_char): Don't try to lookup the cache for the
1549 next/previous character if nothing is cached there yet, or if we
1550 were just reseat()'ed to a new position.
1552 * xdisp.c (set_cursor_from_row): Set start and stop points
1553 according to the row's direction when priming the loop that looks
1554 for the glyph on which to display cursor.
1555 (single_display_spec_intangible_p): Function deleted.
1556 (display_prop_intangible_p): Reimplement to call
1557 handle_display_spec instead of single_display_spec_intangible_p.
1558 Accept 3 additional arguments needed by handle_display_spec.
1559 This fixes incorrect cursor motion across display property with complex
1560 values: lists, `(when COND...)' forms, etc.
1561 (single_display_spec_string_p): Support property values that are
1562 lists with the argument STRING its top-level element.
1563 (display_prop_string_p): Fix the condition for processing a
1564 property that is a list to be consistent with handle_display_spec.
1565 (handle_display_spec): New function, refactored from the
1566 last portion of handle_display_prop.
1567 (compute_display_string_pos): Accept additional argument
1568 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1569 value of a `display' property is a "replacing spec".
1570 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1571 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1572 the display property, but just return a value indicating whether
1573 the display property will replace the characters it covers.
1574 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1575 frame_window_p members of struct bidi_it.
1576 (compute_display_string_pos, compute_display_string_end):
1578 (push_it): Accept second argument POSITION, where pop_it should
1579 jump to continue iteration.
1580 (reseat_1): Initialize bidi_it.disp_pos.
1582 * keyboard.c (adjust_point_for_property): Adjust the call to
1583 display_prop_intangible_p to its new signature.
1585 * dispextern.h (struct bidi_it): New member frame_window_p.
1586 (bidi_init_it): Update prototypes.
1587 (display_prop_intangible_p): Update prototype.
1588 (compute_display_string_pos, compute_display_string_end):
1590 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1593 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1595 Malloc failure behavior now depends on size of allocation.
1596 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1597 * lisp.h: Change signatures accordingly.
1598 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1599 All callers changed. (Bug#8762)
1601 * gnutls.c: Use Emacs's memory allocators.
1602 Without this change, the gnutls library would invoke malloc etc.
1603 directly, which causes problems on non-SYNC_INPUT hosts, and which
1604 runs afoul of improving memory_full behavior. (Bug#8761)
1605 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1606 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1607 xfree instead of the default malloc, realloc, free.
1608 (Fgnutls_boot): No need to check for memory allocation failure,
1609 since xmalloc does that for us.
1611 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1612 * category.c (hash_get_category_set):
1613 * ccl.c (ccl_driver):
1614 * charset.c (Fdefine_charset_internal):
1615 * charset.h (struct charset.hash_index):
1616 * composite.c (get_composition_id, gstring_lookup_cache)
1617 (composition_gstring_put_cache):
1618 * composite.h (struct composition.hash_index):
1619 * dispextern.h (struct image.hash):
1620 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1621 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1622 (hashfn_equal, hashfn_user_defined, make_hash_table)
1623 (maybe_resize_hash_table, hash_lookup, hash_put)
1624 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1625 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1626 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1627 * image.c (make_image, search_image_cache, lookup_image)
1628 (xpm_put_color_table_h):
1629 * lisp.h (struct Lisp_Hash_Table):
1630 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1631 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1632 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1633 * alloc.c (allocate_vectorlike):
1634 Check for overflow in vector size calculations.
1635 * ccl.c (ccl_driver):
1636 Check for overflow when converting EMACS_INT to int.
1637 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1638 need to be updated by these changes.
1639 * fns.c (make_hash_table, maybe_resize_hash_table):
1640 Check for integer overflow with large hash tables.
1641 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1642 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1643 (SXHASH_REDUCE): New macro.
1644 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1645 Use it instead of discarding useful hash info with large hash values.
1646 (sxhash_float): New function.
1647 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1648 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1649 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1650 Rewrite to use FIXNUM_BITS, as this simplifies things.
1651 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1652 Adjust signatures to match updated version of code.
1653 (consing_since_gc): Now EMACS_INT, since a single hash table can
1654 use more than INT_MAX bytes.
1656 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1658 Make it possible to build with GCC-4.6+ -O2 -flto.
1660 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1662 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1664 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1665 Call minibuffer-inactive-mode.
1667 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1669 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1670 Update dependencies.
1672 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1674 * data.c (init_data): Remove code for UTS, this system is not
1677 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1679 Don't force ./temacs to start in terminal mode.
1681 * frame.c (make_initial_frame): Initialize faces in all cases, not
1682 only when CANNOT_DUMP is defined.
1683 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1685 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1687 * dispnew.c (add_window_display_history): Use const for the string
1688 pointer. Remove declaration, not needed.
1690 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1692 Use 'inline', not 'INLINE'.
1693 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1694 * alloc.c, fontset.c (INLINE): Remove.
1695 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1696 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1697 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1698 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1699 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1701 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1703 Make it possible to run ./temacs.
1705 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1706 syms_of_callproc does the same thing. Remove test for
1707 "initialized", do it in the caller.
1708 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1710 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1712 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1713 (read_minibuf): Use get_minibuffer.
1714 (syms_of_minibuf): Use DEFSYM.
1715 (Qmetadata): New var.
1716 * data.c (Qbuffer): Don't make it static.
1717 (syms_of_data): Use DEFSYM.
1719 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1721 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1722 (CCL_CODE_MIN): New macro.
1724 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1726 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1728 * eval.c (Qdebug): Now static.
1729 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1730 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1731 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1733 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1735 * image.c: Various fixes to ImageMagick code comments.
1736 (Fimagemagick_types): Doc fix.
1738 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1740 Minor fixes prompted by GCC 4.6.0 warnings.
1742 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1744 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1745 (x_clipboard_manager_save_all): Move extern decl to ...
1746 * xterm.h: ... here, so that it can be checked for consistency.
1748 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1750 * xselect.c (x_clipboard_manager_save_frame)
1751 (x_clipboard_manager_save_all): New functions.
1752 (Fx_clipboard_manager_save): Lisp function deleted.
1754 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1755 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1757 * xterm.h: Update prototype.
1759 2011-05-28 William Xu <william.xwl@gmail.com>
1761 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1764 2011-05-28 Jim Meyering <meyering@redhat.com>
1766 Avoid a sign-extension bug in crypto_hash_function.
1767 * fns.c (to_uchar): Define.
1768 (crypto_hash_function): Use it to convert some newly-signed
1769 variables to unsigned, to avoid sign-extension bugs. For example,
1770 without this change, (md5 "truc") would evaluate to
1771 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1772 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1773 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1775 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1777 Integer overflow fixes.
1779 * dbusbind.c: Serial number integer overflow fixes.
1780 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1781 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1782 to hold a serial number that is too large for a fixnum.
1783 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1784 Check for serial numbers out of range. Decode any serial number
1785 that was so large that it became a float. (Bug#8722)
1787 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1788 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1789 Use XFASTINT rather than XUINT when numbers are nonnegative.
1790 (xd_append_arg, Fdbus_method_return_internal):
1791 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1792 arguments, check that Lisp number is nonnegative, rather than
1793 silently wrapping negative numbers around. (Bug#8722)
1794 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1797 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1799 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1801 ccl: add integer overflow checks
1802 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1803 (IN_INT_RANGE): New macros.
1804 (ccl_driver): Use them to check for integer overflow when
1805 decoding a CCL program. Many of the new checks are whether XINT (x)
1806 fits in int; it doesn't always, on 64-bit hosts. The new version
1807 doesn't catch all possible integer overflows, but it's an
1808 improvement. (Bug#8719)
1810 * alloc.c (make_event_array): Use XINT, not XUINT.
1811 There's no need for unsigned here.
1813 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1814 This follows up to the 2011-05-06 change that substituted uintptr_t
1815 for EMACS_INT. This case wasn't caught back then.
1817 Rework Fformat to avoid integer overflow issues.
1818 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1819 now (part of C89). Include <verify.h>.
1820 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1821 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1822 (Fformat): Avoid the prepass trying to compute sizes; it was only
1823 approximate and thus did not catch overflow reliably. Instead, walk
1824 through the format just once, formatting and computing sizes as we go,
1825 checking for integer overflow at every step, and allocating a larger
1826 buffer as needed. Keep track separately whether the format is
1827 multibyte. Keep only the most-recently calculated precision, rather
1828 than them all. Record whether each argument has been converted to
1829 string. Use EMACS_INT, not int, for byte and char and arg counts.
1830 Support field widths and precisions larger than INT_MAX. Avoid
1831 sprintf's undefined behavior with conversion specifications such as %#d
1832 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1833 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1834 formatting out-of-range floating point numbers with int
1837 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1839 * data.c: Avoid integer truncation in expressions involving floats.
1840 * data.c: Include <intprops.h>.
1841 (arith_driver): When there's an integer overflow in an expression
1842 involving floating point, convert the integers to floating point
1843 so that the resulting value does not suffer from catastrophic
1844 integer truncation. For example, on a 64-bit host (* 4
1845 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1846 Do not rely on undefined behavior after integer overflow.
1848 merge count_size_as_multibyte, parse_str_to_multibyte
1849 * character.c, character.h (count_size_as_multibyte):
1850 Rename from parse_str_to_multibyte; all uses changed.
1851 Check for integer overflow.
1852 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1853 since it's now a duplicate of the other. This is more of
1854 a character than a buffer op, so better that it's in character.c.
1855 * fns.c, print.c: Adjust to above changes.
1857 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1859 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1861 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1863 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1864 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1865 (x_clipboard_manager_save): Now static.
1866 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1868 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1869 (crypto_hash_function): Now static.
1870 Fix pointer signedness problems. Avoid unnecessary initializations.
1872 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1874 * termhooks.h (Vselection_alist): Make it terminal-local.
1876 * terminal.c (create_terminal): Initialize it.
1878 * xselect.c: Support for clipboard managers.
1879 (Vselection_alist): Move to termhooks.h as terminal-local var.
1880 (LOCAL_SELECTION): New macro.
1881 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1882 (symbol_to_x_atom): Remove gratuitous arg.
1883 (x_handle_selection_request, lisp_data_to_selection_data)
1884 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1885 (x_own_selection, x_get_local_selection, x_convert_selection):
1886 New arg, specifying work frame. Use terminal-local Vselection_alist.
1887 (some_frame_on_display): Delete unused function.
1888 (Fx_own_selection_internal, Fx_get_selection_internal)
1889 (Fx_disown_selection_internal, Fx_selection_owner_p)
1890 (Fx_selection_exists_p): New optional frame arg.
1891 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1892 (x_handle_selection_clear): Don't treat other terminals with the
1893 same keyboard specially. Use the terminal-local Vselection_alist.
1894 (x_clear_frame_selections): Use Frun_hook_with_args.
1896 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1898 * xterm.h: Add support for those atoms.
1900 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1902 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1903 (converted_selections, conversion_fail_tag): New global variables.
1904 (x_selection_request_lisp_error): Free the above.
1905 (x_get_local_selection): Remove unnecessary code.
1906 (x_reply_selection_request): Args changed; handle arbitrary array
1907 of converted selections stored in converted_selections.
1908 Separate the XChangeProperty and SelectionNotify steps.
1909 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1910 (x_convert_selection): New function.
1911 (x_handle_selection_event): Simplify.
1912 (x_get_foreign_selection): Don't ignore incoming requests while
1913 waiting for an answer; this will fail when we implement
1914 SAVE_TARGETS, and seems unnecessary anyway.
1915 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1916 (Vx_sent_selection_functions): Doc fix.
1918 2011-05-26 Leo Liu <sdl.web@gmail.com>
1920 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1922 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1924 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1926 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1927 for fringe update if it has periodic bitmap.
1928 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1929 and fringe_bitmap_periodic_p.
1931 * fringe.c (get_fringe_bitmap_data): New function.
1932 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1933 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1934 row. Mark glyph row for fringe update if periodicity changed.
1936 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1937 for fringe update unless it has periodic bitmap.
1939 2011-05-25 Kenichi Handa <handa@m17n.org>
1941 * xdisp.c (get_next_display_element): Set correct it->face_id for
1942 a static composition.
1944 2011-05-24 Leo Liu <sdl.web@gmail.com>
1947 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1949 * fns.c (crypto_hash_function, Fsha1): New function.
1950 (Fmd5): Use crypto_hash_function.
1951 (syms_of_fns): Add Ssha1.
1953 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1955 * gnutls.c: Remove unused macros.
1956 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1957 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1958 Remove macros that are defined and never used.
1959 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1961 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1963 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1964 (Fx_get_selection_internal): Minor cleanup.
1965 (Fx_own_selection_internal): Rename arguments for consistency with
1968 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1970 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1972 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1974 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1976 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1978 * dispnew.c (scrolling_window): Don't exclude the case that the
1979 last enabled row in the desired matrix touches the bottom boundary.
1981 2011-05-21 Glenn Morris <rgm@gnu.org>
1983 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1984 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1985 and add some more files.
1987 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1989 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1990 report_file_error introduced by the change from 2011-05-07.
1992 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1994 * systime.h (Time): Define only if emacs is defined.
1995 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1996 where the include path doesn't have X11/X.h by default. See
1997 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1999 2011-05-20 Kenichi Handa <handa@m17n.org>
2001 * composite.c (find_automatic_composition): Fix previous change.
2003 2011-05-20 Glenn Morris <rgm@gnu.org>
2005 * lisp.mk: New file, split from Makefile.in.
2006 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2007 (shortlisp): Remove.
2008 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2010 2011-05-19 Glenn Morris <rgm@gnu.org>
2012 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2013 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2014 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2015 (lisp): Set the order to that of loadup.el.
2016 (shortlisp): Make it a copy of $lisp.
2017 (SOME_MACHINE_LISP): Remove.
2018 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2019 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2021 2011-05-18 Kenichi Handa <handa@m17n.org>
2023 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2024 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2025 (find_automatic_composition): Mostly rewrite for efficiency.
2027 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2029 * makefile.w32-in: Update dependencies.
2031 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2033 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2034 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2036 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2038 Fix some integer overflow issues, such as string length overflow.
2040 * insdel.c (count_size_as_multibyte): Check for string overflow.
2042 * character.c (lisp_string_width): Check for string overflow.
2043 Use EMACS_INT, not int, for string indexes and lengths; in
2044 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2045 the resulting string length overflows an EMACS_INT; instead,
2046 report a string overflow if no precision given. When checking for
2047 precision exhaustion, use a check that cannot possibly have
2048 integer overflow. (Bug#8675)
2049 * character.h (lisp_string_width): Adjust to new signature.
2051 * alloc.c (string_overflow): New function.
2052 (Fmake_string): Use it. This doesn't change behavior, but saves
2053 a few bytes and will simplify future changes.
2054 * character.c (string_escape_byte8): Likewise.
2055 * lisp.h (string_overflow): New decl.
2057 Fixups, following up to the user-interface timestamp change.
2058 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2059 for UI timestamps, instead of unsigned long.
2060 * msdos.c (mouse_get_pos): Likewise.
2061 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2062 * w32gui.h (Time): Define by including "systime.h" rather than by
2063 declaring it ourselves. (Bug#8664)
2065 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2066 * image.c (clear_image_cache): Likewise.
2068 * term.c (term_mouse_position): Don't assume time_t wraparound.
2070 Be more systematic about user-interface timestamps.
2071 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2072 and sometimes 'EMACS_UINT', to represent these timestamps.
2073 This change causes it to use 'Time' uniformly, as that's what X uses.
2074 This makes the code easier to follow, and makes it easier to catch
2075 integer overflow bugs such as Bug#8664.
2076 * frame.c (Fmouse_position, Fmouse_pixel_position):
2077 Use Time, not unsigned long, for user-interface timestamps.
2078 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2079 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2080 * keyboard.h (last_event_timestamp): Likewise.
2081 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2082 * menu.h (xmenu_show): Likewise.
2083 * term.c (term_mouse_position): Likewise.
2084 * termhooks.h (struct input_event.timestamp): Likewise.
2085 (struct terminal.mouse_position_hook): Likewise.
2086 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2087 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2088 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2089 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2091 * menu.h, termhooks.h: Include "systime.h", for Time.
2093 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2094 Don't assume that the difference between two unsigned long values
2095 can fit into an integer. At this point, we know button_down_time
2096 <= event->timestamp, so the difference must be nonnegative, so
2097 there's no need to cast the result if double-click-time is
2098 nonnegative, as it should be; check that it's nonnegative, just in
2099 case. This bug is triggered when events are more than 2**31 ms
2100 apart (about 25 days). (Bug#8664)
2102 * xselect.c (last_event_timestamp): Remove duplicate decl.
2103 (x_own_selection): Remove needless cast to unsigned long.
2105 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2106 that always fit in int. Use a sentinel instead of a counter, to
2107 avoid a temp and to allay GCC's concerns about possible int overflow.
2108 * frame.h (struct frame): Use int for menu_bar_items_used
2109 instead of EMACS_INT, since it always fits in int.
2111 * menu.c (grow_menu_items): Check for int overflow.
2113 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2115 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2116 Before, the code was not consistent. These values cannot exceed
2117 2**31 - 1 so there's no need to make them unsigned.
2118 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2119 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2120 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2122 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2124 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2125 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2126 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2127 presumably because the widths might not match.
2129 * window.c (size_window): Avoid needless test at loop start.
2131 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2133 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2135 2011-05-12 Drew Adams <drew.adams@oracle.com>
2137 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2139 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2141 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2142 `width' to `bar_area_x' and `bar_area_width', respectively.
2143 (x_scroll_run): Take account of fringe background extension.
2145 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2146 Rename local vars `left' and `width' to `bar_area_x' and
2147 `bar_area_width', respectively.
2148 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2149 background extension.
2151 2011-05-10 Jim Meyering <meyering@redhat.com>
2153 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2155 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2157 * image.c (Finit_image_library): Return t for built-in image types,
2158 like pbm and xbm. (Bug#8640)
2160 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2162 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2164 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2166 * w32console.c (Fset_screen_color): Doc fix.
2167 (Fget_screen_color): New function.
2168 (syms_of_ntterm): Defsubr it.
2170 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2171 unlink the temporary file if Fcall_process didn't create it in the
2173 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2174 child process will be redirected to a file specified with `:file'.
2175 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2176 cue to call_process_cleanup not to close that handle.
2178 2011-05-07 Ben Key <bkey76@gmail.com>
2180 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2181 one of two shell specific rules, either bootstrap-temacs-CMD or
2182 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2183 to the previous implementation of the bootstrap-temacs rule.
2184 The bootstrap-temacs-CMD rule is similar to the previous
2185 implementation of the bootstrap-temacs rule except that it
2186 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2189 These changes, along with some changes to nt/configure.bat,
2190 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2191 earlier fix to add support for --cflags and --ldflags options
2192 that include quotes so that it works whether make uses cmd or
2195 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2197 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2198 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2200 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2201 a string. Handle both cases.
2202 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2203 (Fdbus_register_method): Use Qinvalid_function.
2205 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2207 * makefile.w32-in: Update dependencies.
2208 (LISP_H): Add inttypes.h and stdin.h.
2209 (PROCESS_H): Add unistd.h.
2211 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2213 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2214 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2216 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2218 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2220 * term.c (vfatal): Remove stray call to va_end.
2221 It's not needed and the C Standard doesn't allow it here anyway.
2223 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2224 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2226 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2229 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2231 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2233 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2235 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2237 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2239 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2240 * charset.c (Fdefine_charset_internal): Don't initialize
2241 charset.code_space[15]. The value was garbage, on hosts with
2242 32-bit int (Bug#8600).
2244 * lread.c (read_integer): Be more consistent with string-to-number.
2245 Use string_to_number to do the actual conversion; this avoids
2246 rounding errors and fixes some other screwups. Without this fix,
2247 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2248 (digit_to_number): Move earlier, for benefit of read_integer.
2249 Return -1 if the digit is out of range for the base, -2 if it is
2250 not a digit in any supported base. (Bug#8602)
2252 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2254 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2255 to match comment at start of function. This also removes a
2256 GCC warning about overflow in a 32+64-bit port.
2258 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2260 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2261 Reported by Stefan Monnier in
2262 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2263 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2264 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2266 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2267 (EMACS_UINTPTR): Likewise, with uintptr_t.
2269 * lisp.h: Prefer 64-bit EMACS_INT if available.
2270 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2271 on 32-bit hosts that have 64-bit int, so that they can access
2273 However, temporarily disable this change unless the temporary
2274 symbol WIDE_EMACS_INT is defined.
2276 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2278 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2279 This removes an assumption that EMACS_INT and long are the same
2280 width as pointers. The assumption is true for Emacs porting targets
2281 now, but we want to make other targets possible.
2282 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2283 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2284 In the rest of the code, change types of integers that hold casted
2285 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2286 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2287 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2288 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2289 No need to cast type when ORing.
2290 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2291 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2292 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2293 assume EMACS_INT is the same width as char *.
2294 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2295 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2296 Remove no-longer-needed casts.
2297 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2298 (xg_tool_bar_help_callback, xg_make_tool_item):
2299 Use EMACS_INTPTR to hold an integer
2300 that will be cast to void *; this can avoid a GCC warning
2301 if EMACS_INT is not the same width as void *.
2302 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2303 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2304 (current_message_1, set_message_1):
2305 Use a local to convert to proper width without a cast.
2306 * xmenu.c (dialog_selection_callback): Likewise.
2308 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2309 Also, don't assume VALBITS / RAND_BITS is less than 5,
2310 and don't rely on undefined behavior when shifting a 1 left into
2312 * lisp.h (get_random): Change signature to match.
2314 * lread.c (hash_string): Use size_t, not int, for hash computation.
2315 Normally we prefer signed values; but hashing is special, because
2316 it's better to use unsigned division on hash table sizes so that
2317 the remainder is nonnegative. Also, size_t is the natural width
2318 for hashing into memory. The previous code used 'int', which doesn't
2319 retain enough info to hash well into very large tables.
2320 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2322 * dbusbind.c: Don't possibly lose pointer info when converting.
2323 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2324 Use XPNTR rather than XHASH, so that the high-order bits of
2325 the pointer aren't lost when converting through void *.
2327 * eval.c (Fautoload): Don't double-shift a pointer.
2329 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2331 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2333 * gnutls.c (DEF_GNUTLS_FN):
2334 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2336 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2338 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2341 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2343 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2344 New version that can reserve upto 2GB of heap space.
2346 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2348 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2350 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2352 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2353 `gnutls_certificate_set_x509_key_file'.
2355 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2357 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2358 Update dependencies.
2360 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2362 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2363 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2364 Remove unused parameter `fildes'.
2365 * process.c (read_process_output, send_process): Don't pass it.
2367 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2369 Fix previous change: the library cache is defined in w32.c.
2370 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2371 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2373 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2375 Implement dynamic loading of GnuTLS on Windows.
2377 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2378 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2379 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2382 * gnutls.c (Qgnutls_dll): Define.
2383 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2384 (gnutls_*): Declare function pointers.
2385 (init_gnutls_functions): New function to initialize function pointers.
2386 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2387 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2388 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2389 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2390 (emacs_gnutls_write, emacs_gnutls_read)
2391 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2392 (Fgnutls_available_p): New function.
2393 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2394 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2395 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2397 * image.c: Include w32.h.
2398 (Vimage_type_cache): Delete.
2399 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2400 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2401 (w32_delayed_load): Move to w32.c.
2403 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2405 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2406 (w32_delayed_load): Move from image.c. When loading a library, record
2407 its filename in the :loaded-from property of the library id.
2408 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2409 Initialize and staticpro them.
2410 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2412 * process.c: Include lisp.h before w32.h, not after.
2413 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2414 instead of gnutls_record_check_pending.
2416 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2418 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2420 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2421 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2424 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2426 * xterm.c (x_set_frame_alpha): Do not set property on anything
2427 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2429 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2431 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2433 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2435 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2436 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2437 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2438 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2439 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2440 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2441 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2442 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2443 (Qgnutls_bootprop_callbacks_verify): Make static.
2445 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2447 * callproc.c: Indentation fixup.
2449 * sysdep.c (wait_for_termination_1): Make static.
2450 (wait_for_termination, interruptible_wait_for_termination):
2451 Move after wait_for_termination_1.
2453 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2455 * sysdep.c (interruptible_wait_for_termination): New function
2456 which is like wait_for_termination, but allows keyboard
2459 * callproc.c (Fcall_process): Add (:file "file") as an option for
2461 (Fcall_process_region): Ditto.
2463 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2465 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2466 rather than `XVECTOR (FOO)->size'.
2468 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2469 inttypes.h, as a gnulib replacement is used if it not available in
2472 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2474 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2475 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2476 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2478 * coding.c (coding_alloc_by_realloc): Error out if destination
2479 will grow beyond MOST_POSITIVE_FIXNUM.
2480 (decode_coding_emacs_mule): Abort if there isn't enough place in
2481 charbuf for the composition carryover bytes. Reserve an extra
2482 space for up to 2 characters produced in a loop.
2483 (decode_coding_iso_2022): Abort if there isn't enough place in
2484 charbuf for the composition carryover bytes.
2486 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2488 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2489 aborting when %lld or %lll format is passed.
2490 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2491 %llo or %llx format is passed. (Bug#8545)
2493 * window.c (window_scroll_line_based): Use a marker instead of
2494 simple variables to record original value of point. (Bug#7952)
2496 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2497 produced by %s or %c overflows available buffer space. (Bug#8545)
2499 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2501 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2502 (SIZE_MAX): Move defn after all includes, as they might #define it.
2504 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2506 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2508 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2510 * keyboard.c (Qdelayed_warnings_hook): Define.
2511 (command_loop_1): Run `delayed-warnings-hook'
2512 if Vdelayed_warnings_list is non-nil.
2513 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2514 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2516 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2518 * doprnt.c (doprnt): Don't return value smaller than the buffer
2519 size if the message was truncated. (Bug#8545).
2521 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2523 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2524 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2526 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2528 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2530 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2532 * makefile.w32-in: Update dependencies.
2534 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2536 Improve `doprnt' and its usage. (Bug#8545)
2537 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2538 `format_end'. Remove support for %l as a conversion specifier.
2539 Don't use xrealloc. Improve diagnostics when the %l size modifier
2540 is used. Update the commentary.
2542 * eval.c (verror): Simplify calculation of size_t.
2544 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2547 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2549 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2552 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2554 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2555 This makes this file independent of the recent pseudovector change.
2557 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2559 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2561 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2562 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2563 Remove unused local.
2564 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2566 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2567 GCC 4.6.0 optimizes based on type-based alias analysis.
2568 For example, if b is of type struct buffer * and v of type struct
2569 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2570 != &v->size, and therefore "v->size = 1; b->size = 2; return
2571 v->size;" must therefore return 1. This assumption is incorrect
2572 for Emacs, since it type-puns struct Lisp_Vector * with many other
2573 types. To fix this problem, this patch adds a new type struct
2574 vectorlike_header that documents the constraints on layout of vectors
2575 and pseudovectors, and helps optimizing compilers not get fooled
2576 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2577 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2578 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2580 (XSETPVECTYPE): Rewrite in terms of new macro.
2581 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2582 This is a bit clearer, and further avoids the possibility of
2583 undesirable aliasing.
2584 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2585 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2586 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2587 since Lisp_Subr is a special case (no "next" field).
2588 (ASIZE): Now uses header.size rather than size.
2589 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2590 to avoid the hassle of writing XVECTOR (foo)->header.size.
2591 (struct vectorlike_header): New type.
2592 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2593 object, to help avoid aliasing.
2594 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2595 (SUBRP): Likewise, since Lisp_Subr is a special case.
2596 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2597 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2598 (struct Lisp_Hash_Table): Combine first two members into a single
2599 struct vectorlike_header member. All uses of "size" and "next" members
2600 changed to be "header.size" and "header.next".
2601 * buffer.h (struct buffer): Likewise.
2602 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2603 * frame.h (struct frame): Likewise.
2604 * process.h (struct Lisp_Process): Likewise.
2605 * termhooks.h (struct terminal): Likewise.
2606 * window.c (struct save_window_data, struct saved_window): Likewise.
2607 * window.h (struct window): Likewise.
2608 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2609 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2610 * buffer.c (init_buffer_once): Likewise.
2611 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2613 * process.c (Fformat_network_address): Use local var for size,
2616 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2618 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2619 * data.c (atof): Remove decl; no longer used or needed.
2620 (digit_to_number): Move to lread.c.
2621 (Fstring_to_number): Use new string_to_number function, to be
2622 consistent with how the Lisp reader treats infinities and NaNs.
2623 Do not assume that floating-point numbers represent EMACS_INT
2624 without losing information; this is not true on most 64-bit hosts.
2625 Avoid double-rounding errors, by insisting on integers when
2626 parsing non-base-10 numbers, as the documentation specifies.
2627 * lisp.h (string_to_number): New decl, replacing ...
2628 (isfloat_string): Remove.
2629 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2630 (read1): Do not accept +. and -. as integers; this
2631 appears to have been a coding error. Similarly, do not accept
2632 strings like +-1e0 as floating point numbers. Do not report
2633 overflow for integer overflows unless the base is not 10 which
2634 means we have no simple and reliable way to continue.
2635 Break out the floating-point parsing into a new
2636 function string_to_number, so that Fstring_to_number parses
2637 floating point numbers consistently with the Lisp reader.
2638 (digit_to_number): Move here from data.c. Make it static inline.
2639 (E_CHAR, EXP_INT): Remove, replacing with ...
2640 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2641 (string_to_number): New function, replacing isfloat_string.
2642 This function checks for valid syntax and produces the resulting
2643 Lisp float number too. Rework it so that string-to-number
2644 no longer mishandles examples like "1.0e+". Use strtoumax,
2645 so that overflow for non-base-10 numbers is reported only when
2646 there's no portable and simple way to convert to floating point.
2648 * textprop.c (set_text_properties_1): Rewrite for clarity,
2649 and to avoid GCC warning about integer overflow.
2651 * intervals.h (struct interval): Use EMACS_INT for members
2652 where EMACS_UINT might cause problems. See
2653 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2654 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2655 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2657 (offset_intervals): Tell GCC not to worry about length overflow
2658 when negating a negative length.
2660 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2661 (overrun_check_free): Likewise.
2663 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2664 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2667 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2668 (gnutls_make_error): Rename local to avoid shadowing.
2669 (gnutls_emacs_global_deinit): ifdef out; not used.
2670 (Fgnutls_boot): Use const for pointer to readonly storage.
2671 Comment out unused local. Fix pointer signedness problems.
2673 * lread.c (openp): Don't stuff size_t into an 'int'.
2674 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2675 about possible signed overflow.
2677 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2678 (GDK_KEY_g): Don't define if already defined.
2679 (xg_prepare_tooltip): Avoid pointer signedness problem.
2680 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2682 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2683 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2685 * xfns.c (Fx_window_property): Simplify a bit,
2686 to make a bit faster and to avoid GCC 4.6.0 warning.
2687 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2689 * fns.c (internal_equal): Don't assume size_t fits in int.
2691 * alloc.c (compact_small_strings): Tighten assertion a little.
2693 Replace pEd with more-general pI, and fix some printf arg casts.
2694 * lisp.h (pI): New macro, generalizing old pEd macro to other
2695 conversion specifiers. For example, use "...%"pI"d..." rather
2696 than "...%"pEd"...".
2697 (pEd): Remove. All uses replaced with similar uses of pI.
2698 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2699 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2700 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2701 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2702 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2703 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2704 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2706 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2707 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2708 * print.c (safe_debug_print, print_object): Likewise.
2709 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2711 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2712 avoiding the 0 flag, which is not portable.
2713 * process.c (Fmake_network_process): Use pI to avoid cast.
2714 * region-cache.c (pp_cache): Likewise.
2715 * xdisp.c (decode_mode_spec): Likewise.
2716 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2717 behavior on 64-bit hosts with printf arg.
2718 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2719 (x_stop_queuing_selection_requests): Likewise.
2720 (x_get_window_property): Don't truncate byte count to an 'int'
2723 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2724 here, since it parses constructs like leading '-' and spaces,
2725 which are not wanted; and it overflows with large numbers.
2726 Instead, simply match F[0-9]+, which is what is wanted anyway.
2728 * alloc.c: Remove unportable assumptions about struct layout.
2729 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2730 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2731 (allocate_vectorlike, make_pure_vector): Use the new macros,
2732 plus offsetof, to remove unportable assumptions about struct layout.
2733 These assumptions hold on all porting targets that I know of, but
2734 they are not guaranteed, they're easy to remove, and removing them
2735 makes further changes easier.
2737 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2738 This doesn't fix a bug but makes the code clearer.
2739 (string_overrun_cookie): Now const. Use initializers that
2740 don't formally overflow signed char, to avoid warnings.
2741 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2742 can cause Emacs to crash when string overrun checking is enabled.
2743 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2744 multiple of sizeof (EMACS_INT); it need not be, if
2745 alignof(EMACS_INT) < sizeof (EMACS_INT).
2746 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2748 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2750 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2752 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2754 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2755 supposed to be handshaking. (Bug#8556)
2756 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2758 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2760 * lisp.h (Qdebug): List symbol.
2761 * eval.c (Qdebug): Restore global linkage.
2762 * keyboard.c (debug-on-event): New variable.
2763 (handle_user_signal): Break into debugger when debug-on-event
2764 matches the current signal symbol.
2766 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2768 * alloc.c (check_sblock, check_string_bytes)
2769 (check_string_free_list): Convert to standard C.
2771 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2773 * w32.c (emacs_gnutls_push): Fix typo.
2775 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2777 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2778 "cast to pointer from integer of different size".
2780 Improve doprnt and its use in verror. (Bug#8545)
2781 * doprnt.c (doprnt): Document the set of format control sequences
2782 supported by the function. Use SAFE_ALLOCA instead of always
2785 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2786 is one byte too soon. Don't use xrealloc; instead xfree and
2789 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2791 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2794 * gnutls.c: Renamed global_initialized to
2795 gnutls_global_initialized. Added internals for the
2796 :verify-hostname-error, :verify-error, and :verify-flags
2797 parameters of `gnutls-boot' and documented those parameters in the
2798 docstring. Start callback support.
2799 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2800 unless a fatal error occured. Call gnutls_alert_send_appropriate
2801 on error. Return error code.
2802 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2803 (emacs_gnutls_read): Likewise.
2804 (Fgnutls_boot): Return handshake error code.
2805 (emacs_gnutls_handle_error): New function.
2806 (wsaerror_to_errno): Likewise.
2808 * w32.h (emacs_gnutls_pull): Add prototype.
2809 (emacs_gnutls_push): Likewise.
2811 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2812 (emacs_gnutls_push): Likewise.
2814 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2816 * process.c (wait_reading_process_output): Check if GnuTLS
2817 buffered some data internally if no FDs are set for TLS
2820 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2821 (LIBS): Link to USER_LIBS.
2822 ($(BLD)/gnutls.$(0)): New target.
2824 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2826 * xdisp.c (handle_single_display_spec): Rename the
2827 display_replaced_before_p argument into display_replaced_p, to
2828 make it consistent with the commentary. Fix typos in the
2831 * textprop.c (syms_of_textprop): Remove dead code.
2832 (copy_text_properties): Delete obsolete commentary about an
2833 interface that was deleted long ago. Fix typos in the description
2836 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2837 to changes in oldXMenu/XMenu.h from 2011-04-16.
2838 <menu_help_message, prev_menu_help_message>: Constify.
2839 (IT_menu_make_room): menu->help_text is now `const char **';
2842 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2843 to changes in oldXMenu/XMenu.h from 2011-04-16.
2844 (struct XMenu): Declare `help_text' `const char **'.
2846 * xfaces.c <Qunspecified>: Make extern again.
2848 * syntax.c: Include sys/types.h before including regex.h, as
2851 * doc.c (get_doc_string): Improve the format passed to `error'.
2853 * doprnt.c (doprnt): Improve commentary.
2855 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2857 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2860 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2861 changes in globals.h immediately force recompilation.
2862 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2863 $(CURDIR)/s/ms-w32.h.
2864 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2866 * character.c (Fchar_direction): Function deleted.
2867 (syms_of_character): Don't defsubr it.
2868 <char-direction-table>: Deleted.
2870 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2872 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2873 * doprnt.c: Include limits.h.
2874 (SIZE_MAX): New macro.
2875 (doprnt): Return a size_t value. 2nd arg is now size_t.
2876 Many local variables are now size_t instead of int or unsigned.
2877 Improve overflow protection. Support `l' modifier for integer
2878 conversions. Support %l conversion. Don't assume an EMACS_INT
2879 argument for integer conversions and for %c.
2881 * lisp.h (doprnt): Restore prototype.
2883 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2886 * Makefile.in (base_obj): Add back doprnt.o.
2888 * deps.mk (doprnt.o): Add back prerequisites.
2889 (callint.o): Depend on character.h.
2891 * eval.c (internal_lisp_condition_case): Include the handler
2892 representation in the error message.
2893 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2894 when breaking from the loop.
2896 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2898 * callint.c (Fcall_interactively): When displaying error message
2899 about invalid control letter, pass the character's codepoint, not
2900 a pointer to its multibyte form. Improve display of the character
2901 in octal and display also its hex code.
2903 * character.c (char_string): Use %x to display the (unsigned)
2904 codepoint of an invalid character, to avoid displaying a bogus
2907 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2908 `error', not SYMBOL_NAME itself.
2910 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2911 character arguments to `error'.
2913 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2914 to `error' in error message about FINAL_CHAR argument. Make sure
2915 FINAL_CHAR is a character, and use %c when it is passed as
2916 argument to `error'.
2918 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2920 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2922 * w32.c: Include <time.h>.
2923 (sys_localtime): New function.
2925 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2927 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2929 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2931 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2933 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2936 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2938 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2939 gl_state.e_property when gl_state.object is Qt.
2941 * insdel.c (make_gap_larger): Remove limitation of buffer size
2944 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2946 * xdisp.c (lookup_glyphless_char_display)
2947 (produce_glyphless_glyph): Handle cons cell entry in
2948 glyphless-char-display.
2949 (Vglyphless_char_display): Document it.
2951 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2952 glyphless-char-display.
2954 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2956 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2958 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2960 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2961 definition for no-X builds.
2963 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2965 Static checks with GCC 4.6.0 and non-default toolkits.
2967 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2969 * process.c (keyboard_bit_set): Define only if SIGIO.
2970 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2971 (send_process): Repair possible setjmp clobbering.
2973 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2975 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2977 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2979 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2980 Define only if needed.
2982 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2983 by pacifying GCC about it. Maybe it's time to retire it?
2984 * xfaces.c (USG, __TIMEVAL__): Likewise.
2986 * dispextern.h (struct redisplay_interface): Rename param
2988 * termhooks.h (struct terminal): Likewise.
2989 * xterm.c (xembed_send_message): Likewise.
2991 * insdel.c (make_gap_smaller): Define only if
2992 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2994 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2997 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2998 so that we aren't warned about unused symbols.
3000 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3002 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3004 * xfns.c (x_real_positions): Mark locals as initialized.
3006 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3008 * xterm.c: Fix problems found by static analysis with other toolkits.
3009 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3010 (x_dispatch_event): Declare static if USE_GTK, and
3011 define if USE_GTK || USE_X_TOOLKIT.
3012 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3013 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3014 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3015 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3017 * xmenu.c (menu_help_callback): Pointer type fixes.
3018 Use const pointers when pointing at readonly data. Avoid pointer
3020 (FALSE): Remove unused macro.
3021 (update_frame_menubar): Remove unused decl.
3023 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3025 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3026 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3027 (single_menu_item): Rename local to avoid shadowing.
3029 * keyboard.c (make_lispy_event): Remove unused local var.
3031 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3032 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3034 * bitmaps: Change bitmaps from unsigned char back to the X11
3035 compatible char. Avoid the old compiler warnings about
3036 out-of-range initializers by using, for example, '\xab' rather
3039 * xgselect.c (xgselect_initialize): Check vs interface
3040 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3042 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3044 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3045 to read-only memory.
3047 * fns.c (vector): Remove; this old hack is no longer needed.
3049 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3051 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3053 * xrdb.c (x_load_resources): Omit unused local.
3055 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3056 (x_window): Rename locals to avoid shadowing.
3057 (USG): Use the kludged USG macro, to pacify gcc.
3059 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3060 (x_term_init): Remove local to avoid shadowing.
3062 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3064 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3065 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3067 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3069 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3071 Fix regex.c, syntax.c and friends for buffers > 2GB.
3072 * syntax.h (struct gl_state_s): Declare character position members
3075 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3077 * textprop.c (verify_interval_modification, interval_of):
3078 Declare arguments EMACS_INT.
3080 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3083 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3085 * indent.c (Fvertical_motion): Local variable it_start is now
3088 * regex.c (re_match, re_match_2, re_match_2_internal)
3089 (bcmp_translate, regcomp, regexec, print_double_string)
3090 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3091 (re_compile_pattern, re_exec): Declare arguments and local
3092 variables `size_t' and `ssize_t' and return values `regoff_t', as
3094 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3095 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3096 <compile_stack_type>: `size' and `avail' are now `size_t'.
3098 * regex.h <regoff_t>: Use ssize_t, not int.
3099 (re_search, re_search_2, re_match, re_match_2): Arguments that
3100 specify buffer/string position and length are now ssize_t and
3101 size_t. Return type is regoff_t.
3103 2011-04-16 Ben Key <bkey76@gmail.com>
3105 * nsfont.m: Fixed bugs in ns_get_family and
3106 ns_descriptor_to_entity that were caused by using free to
3107 deallocate memory blocks that were allocated by xmalloc (via
3108 xstrdup). This caused Emacs to crash when compiled with
3109 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3110 --enable-checking=xmallocoverrun). xfree is now used to
3111 deallocate these memory blocks.
3113 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3115 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3117 emacs_write: Accept and return EMACS_INT for sizes.
3118 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3120 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3121 Accept and return EMACS_INT.
3122 (emacs_gnutls_write): Return the number of bytes written on
3124 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3125 (emacs_read, emacs_write): Remove check for negative size, as the
3126 Emacs source code has been audited now.
3127 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3128 (emacs_read, emacs_write): Use it.
3129 * process.c (send_process): Adjust to the new signatures of
3130 emacs_write and emacs_gnutls_write. Do not attempt to store
3131 a byte offset into an 'int'; it might overflow.
3132 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3134 * sound.c: Don't assume sizes fit in 'int'.
3135 (struct sound_device.period_size, alsa_period_size):
3136 Return EMACS_INT, not int.
3137 (struct sound_device.write, vox_write, alsa_write):
3138 Accept EMACS_INT, not int.
3139 (wav_play, au_play): Use EMACS_INT to store sizes and to
3140 record read return values.
3142 2011-04-15 Ben Key <bkey76@gmail.com>
3144 * keyboard.c (Qundefined): Don't declare static since it is used
3146 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3147 static since they are used in nsfont.m.
3149 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3151 * process.c (Qprocessp): Don't declare static.
3152 * lisp.h (Qprocessp): Declare again.
3154 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3156 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3158 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3160 Improve C-level modularity by making more things 'static'.
3162 Don't publish debugger-only interfaces to other modules.
3163 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3164 (verify_bytepos, count_markers): Move decls to the only modules
3166 * region-cache.h (pp_cache): Likewise.
3167 * window.h (check_all_windows): Likewise.
3168 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3170 * sysdep.c (croak): Now static, if
3171 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3172 * syssignal.h (croak): Declare only if not static.
3174 * alloc.c (refill_memory_reserve): Now static if
3175 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3176 * lisp.h (refill_memory_reserve): Declare only if not static.
3178 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3179 Define only if USE_LUCID.
3181 * xrdb.c (x_customization_string, x_rm_string): Now static.
3183 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3184 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3186 * xdisp.c (draw_row_with_mouse_face): Now static.
3187 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3189 * window.h (check_all_windows): Mark externally visible.
3191 * window.c (window_deletion_count): Now static.
3193 * undo.c: Make symbols static if they're not exported.
3194 (last_undo_buffer, last_boundary_position, pending_boundary):
3197 * textprop.c (interval_insert_behind_hooks): Now static.
3198 (interval_insert_in_front_hooks): Likewise.
3200 * term.c: Make symbols static if they're not exported.
3201 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3202 (max_frame_lines, tty_set_terminal_modes):
3203 (tty_reset_terminal_modes, tty_turn_off_highlight):
3204 (get_tty_terminal): Now static.
3205 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3206 * termhooks.h (term_mouse_moveto): Do not declare if
3208 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3209 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3211 * sysdep.c: Make symbols static if they're not exported.
3212 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3214 (sigprocmask_set, full_mask): Remove; unused.
3215 (wait_debugging): Mark as visible.
3216 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3217 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3219 * syntax.c (syntax_temp): Define only if !__GNUC__.
3221 * sound.c (current_sound_device, current_sound): Now static.
3223 * search.c (searchbufs, searchbuf_head): Now static.
3225 * scroll.c (scroll_cost): Remove; unused.
3226 * dispextern.h (scroll_cost): Remove decl.
3228 * region-cache.h (pp_cache): Mark as externally visible.
3230 * process.c: Make symbols static if they're not exported.
3231 (process_tick, update_tick, create_process, chan_process):
3232 (Vprocess_alist, proc_buffered_char, datagram_access):
3233 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3234 (deactivate_process): Mark defn as static, as well as decl.
3235 * lisp.h (create_process): Remove decl.
3236 * process.h (chan_process, Vprocess_alist): Remove decls.
3238 * print.c: Make symbols static if they're not exported.
3239 (print_depth, new_backquote_output, being_printed, print_buffer):
3240 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3241 (print_interval, print_number_index, initial_stderr_stream):
3243 * lisp.h (Fprinc): Remove decl.
3244 (debug_output_compilation_hack): Mark as externally visible.
3246 * sysdep.c (croak): Move decl from here to syssignal.h.
3247 * syssignal.h (croak): Put it here, so the API can be checked when
3248 'croak' is called from dissociate_if_controlling_tty.
3250 * minibuf.c: Make symbols static if they're not exported.
3251 (minibuf_save_list, choose_minibuf_frame): Now static.
3252 * lisp.h (choose_minibuf_frame): Remove decl.
3254 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3256 * lread.c: Make symbols static if they're not exported.
3257 (read_objects, initial_obarray, oblookup_last_bucket_number):
3259 (make_symbol): Remove; unused.
3260 * lisp.h (initial_obarray, make_symbol): Remove decls.
3262 * keyboard.c: Make symbols static if they're not exported.
3263 (single_kboard, recent_keys_index, total_keys, recent_keys):
3264 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3265 (this_single_command_key_start, echoing, last_auto_save):
3266 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3267 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3268 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3269 (Vlispy_mouse_stem, double_click_count):
3271 (force_auto_save_soon): Define only if SIGDANGER.
3272 (ignore_mouse_drag_p): Now static if
3273 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3274 (print_help): Remove; unused.
3275 (stop_character, last_timer_event): Mark as externally visible.
3276 * keyboard.h (ignore_mouse_drag_p): Declare only if
3277 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3278 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3279 * lisp.h (echoing): Remove decl.
3280 (force_auto_save_soon): Declare only if SIGDANGER.
3281 * xdisp.c (redisplay_window): Simplify code, to make it more
3282 obvious that ignore_mouse_drag_p is not accessed if !defined
3283 USE_GTK && !defined HAVE_NS.
3285 * intervals.c: Make symbols static if they're not exported.
3286 (merge_properties_sticky, merge_interval_right, delete_interval):
3288 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3290 * insdel.c: Make symbols static if they're not exported.
3291 However, leave prepare_to_modify_buffer alone. It's never
3292 called from outside this function, but that appears to be a bug.
3293 (combine_after_change_list, combine_after_change_buffer):
3294 (adjust_after_replace, signal_before_change): Now static.
3295 (adjust_after_replace_noundo): Remove; unused.
3296 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3297 (signal_before_change): Remove decls.
3299 * indent.c (val_compute_motion, val_vmotion): Now static.
3301 * image.c: Make symbols static if they're not exported.
3302 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3304 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3305 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3307 * fringe.c (standard_bitmaps): Now static.
3308 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3310 * frame.c: Make symbols static if they're not exported.
3311 (x_report_frame_params, make_terminal_frame): Now static.
3312 (get_frame_param): Now static, unless HAVE_NS.
3313 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3314 (x_get_resource_string): Remove; not used.
3315 * frame.h (make_terminal_frame, x_report_frame_params):
3316 (x_get_resource_string); Remove decls.
3317 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3318 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3320 * font.c, fontset.c: Make symbols static if they're not exported.
3321 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3322 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3323 * font.c (font_close_object): Now static.
3324 * font.h (font_close_object): Remove.
3325 * fontset.c (FONTSET_OBJLIST): Remove.
3326 (free_realized_fontset) #if-0 the body, which does nothing.
3327 (face_suitable_for_char_p): #if-0, as it's never called.
3328 * fontset.h (face_suitable_for_char_p): Remove decl.
3329 * xfaces.c (face_at_string_position):
3330 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3331 since 0 is always ASCII.
3333 * fns.c (weak_hash_tables): Now static.
3335 * fileio.c: Make symbols static if they're not exported.
3336 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3337 (Vwrite_region_annotation_buffers): Now static.
3339 * eval.c: Make symbols static if they're not exported.
3340 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3341 * lisp.h (backtrace_list): Remove decl.
3343 * emacs.c: Make symbols static if they're not exported.
3344 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3345 (fatal_error_code, fatal_error_signal_hook, standard_args):
3347 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3348 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3349 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3350 * lisp.h (fatal_error_signal_hook): Remove decl.
3351 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3353 * editfns.c: Move a (normally-unused) function to its only use.
3354 * editfns.c, lisp.h (get_operating_system_release): Remove.
3355 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3356 worth the hassle of breaking this out.
3358 * xterm.c: Make symbols static if they're not exported.
3359 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3360 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3361 (x_destroy_window, x_delete_display):
3363 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3364 (x_mouse_leave): Remove; unused.
3365 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3366 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3367 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3369 (x_mouse_leave): Declare only if WINDOWSNT.
3370 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3371 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3374 * ftxfont.c: Make symbols static if they're not exported.
3375 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3377 * font.h (ftxfont_driver): Likewise.
3379 * xfns.c: Make symbols static if they're not exported.
3380 (x_last_font_name, x_display_info_for_name):
3381 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3382 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3383 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3384 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3385 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3386 (last_show_tip_args): Now static.
3387 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3388 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3389 (x_screen_planes): Remove; unused.
3390 * dispextern.h (x_screen_planes): Remove decl.
3392 * dispnew.c: Make symbols static if they're not exported.
3393 * dispextern.h (redraw_garbaged_frames, scrolling):
3394 (increment_row_positions): Remove.
3395 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3396 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3398 (redraw_garbaged_frames): Remove; unused.
3400 * xfaces.c: Make symbols static if they're not exported.
3401 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3403 * xterm.h (defined_color): Remove decls.
3404 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3405 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3406 (menu_face_changed_default, defined_color, free_realized_face):
3407 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3408 (ascii_face_of_lisp_face): Remove; unused.
3410 * xdisp.c: Make symbols static if they're not exported.
3411 * dispextern.h (scratch_glyph_row, window_box_edges):
3412 (glyph_to_pixel_coords, set_cursor_from_row):
3413 (get_next_display_element, set_iterator_to_next):
3414 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3415 (show_mouse_face): Remove decls
3416 * frame.h (message_buf_print): Likewise.
3417 * lisp.h (pop_message, set_message, check_point_in_composition):
3419 * xterm.h (set_vertical_scroll_bar): Likewise.
3420 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3421 (message_buf_print, scratch_glyph_row, displayed_buffer):
3422 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3423 (get_next_display_element, show_mouse_face, window_box_edges):
3424 (frame_to_window_pixel_xy, check_point_in_composition):
3425 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3426 (glyph_to_pixel_coords): Remove; unused.
3428 * dired.c (file_name_completion): Now static.
3430 * dbusbind.c (xd_in_read_queued_messages): Now static.
3432 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3433 * data.c (circular_list_error): Remove.
3435 * commands.h (last_point_position, last_point_position_buffer):
3436 (last_point_position_window): Remove decls.
3437 * keyboard.c: Make these variables static.
3439 * coding.h (coding, code_convert_region, encode_coding_gap):
3441 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3442 (iso_code_class, detect_coding, code_convert_region): Now static.
3443 (encode_coding_gap): Remove; unused.
3445 * chartab.c (chartab_chars, chartab_bits): Now static.
3447 * charset.h (charset_iso_8859_1): Remove decl.
3448 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3451 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3452 * ccl.c (Vccl_program_table): Now static.
3453 (check_ccl_update): Remove; unused.
3455 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3456 * category.h: ... from here.
3457 * category.c (check_category_table, set_category_set): Now static.
3459 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3460 * lisp.h: Remove these decls.
3462 * buffer.c (buffer_count): Remove unused var.
3464 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3465 so that it's not optimized away.
3466 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3467 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3468 exported only to the debugger.
3470 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3471 * atimer.h (run_all_atimers): Remove; not exported.
3473 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3474 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3475 was inaccessible from Lisp.
3476 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3477 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3479 alloc.c: Import and export fewer symbols, and remove unused items.
3480 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3482 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3483 it's not optimized away by whole-program optimization.
3484 (message_enable_multibyte, free_misc): Remove.
3485 (catchlist, handlerlist, mark_backtrace):
3486 Declare only if BYTE_MARK_STACK.
3487 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3488 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3489 (message_enable_multibyte): Remove decl.
3490 (free_misc, interval_free_list, float_block, float_block_index):
3491 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3492 (cons_free_list, last_marked_index):
3494 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3495 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3496 (mark_backtrace): Define only if BYTE_MARK_STACK.
3497 * xdisp.c (message_enable_multibyte): Now static.
3499 Declare Lisp_Object Q* variables to be 'static' if not exported.
3500 This makes it easier for human readers (and static analyzers)
3501 to see whether these variables are used from other modules.
3502 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3503 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3504 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3505 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3506 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3507 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3508 * xmenu.c, xselect.c:
3509 Declare Q* vars static if they are not used in other modules.
3510 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3511 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3512 Remove decls of unexported vars.
3513 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3515 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3517 Make Emacs functions such as Fatom 'static' by default.
3518 This makes it easier for human readers (and static analyzers)
3519 to see whether these functions can be called from other modules.
3520 DEFUN now defines a static function. To make the function external
3521 so that it can be used in other C modules, use the new macro DEFUE.
3522 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3523 (Finit_image_library):
3524 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3525 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3526 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3527 Remove decls, since these functions are now static.
3528 (Funintern, Fget_internal_run_time): New decls, since these functions
3529 were already external.
3531 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3532 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3533 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3534 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3535 * keyboard.c, keymap.c, lread.c:
3536 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3537 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3538 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3539 Mark functions with DEFUE instead of DEFUN,
3540 if they are used in other modules.
3541 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3542 decls for now-static functions.
3543 * buffer.h (Fdelete_overlay): Remove decl.
3544 * callproc.c (Fgetenv_internal): Mark as internal.
3545 * composite.c (Fremove_list_of_text_properties): Remove decl.
3546 (Fcomposition_get_gstring): New forward static decl.
3547 * composite.h (Fcomposite_get_gstring): Remove decl.
3548 * dired.c (Ffile_attributes): New forward static decl.
3549 * doc.c (Fdocumntation_property): New forward static decl.
3550 * eval.c (Ffetch_bytecode): New forward static decl.
3551 (Funintern): Remove extern decl; now in .h file where it belongs.
3552 * fileio.c (Fmake_symbolic_link): New forward static decl.
3553 * image.c (Finit_image_library): New forward static decl.
3554 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3555 * intervals.h (Fprevious_property_change):
3556 (Fremove_list_of_text_properties): Remove decls.
3557 * keyboard.c (Fthis_command_keys): Remove decl.
3558 (Fcommand_execute): New forward static decl.
3559 * keymap.c (Flookup_key): New forward static decl.
3560 (Fcopy_keymap): Now static.
3561 * keymap.h (Flookup_key): Remove decl.
3562 * process.c (Fget_process): New forward static decl.
3563 (Fprocess_datagram_address): Mark as internal.
3564 * syntax.c (Fsyntax_table_p): New forward static decl.
3565 (skip_chars): Remove duplicate decl.
3566 * textprop.c (Fprevious_property_change): New forward static decl.
3567 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3569 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3570 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3572 * editfns.c (Fformat): Remove unreachable code.
3574 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3576 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3579 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3581 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3582 when at ZV. (Bug#8487)
3584 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3586 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3588 * keyboard.c (parse_tool_bar_item): Likewise.
3589 * sound.c (sound_cleanup, alsa_close): Likewise.
3590 * termcap.c (tgetent): Likewise.
3591 * xfns.c (x_default_font_parameter): Likewise.
3592 * xsettings.c (read_and_apply_settings): Likewise.
3594 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3595 (overrun_check_free): Protoize.
3597 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3599 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3600 since callers should never pass a negative size.
3601 Change the signature to match that of plain 'read' and 'write'; see
3602 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3603 * lisp.h: Update prototypes of emacs_write and emacs_read.
3605 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3607 * xdisp.c (redisplay_window): Don't try to determine the character
3608 position of the scroll margin if the window start point w->startp
3609 is outside the buffer's accessible region. (Bug#8468)
3611 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3613 Fix write-region and its subroutines for buffers > 2GB.
3614 * fileio.c (a_write, e_write): Modify declaration of arguments and
3615 local variables to support buffers larger than 2GB.
3616 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3618 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3619 argument, local variables, and return value.
3621 * lisp.h: Update prototypes of emacs_write and emacs_read.
3623 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3625 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3627 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3629 Fix more problems found by GCC 4.6.0's static checks.
3631 * xdisp.c (vmessage): Use a better test for character truncation.
3633 * charset.c (load_charset_map): <, not <=, for optimization,
3634 and to avoid potential problems with integer overflow.
3635 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3636 * casetab.c (set_identity, shuffle): Likewise.
3637 * editfns.c (Fformat): Likewise.
3638 * syntax.c (skip_chars): Likewise.
3640 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3641 This also lets GCC 4.6.0 generate slightly better loop code.
3643 * callint.c (Fcall_interactively): <, not <=, for optimization.
3644 (Fcall_interactively): Count the number of arguments produced,
3645 not the number of arguments given. This is simpler and lets GCC
3646 4.6.0 generate slightly better code.
3648 * ftfont.c: Distingish more carefully between FcChar8 and char.
3649 The previous code passed unsigned char * to a functions like
3650 strlen and xstrcasecmp that expect char *, which does not
3651 conform to the C standard.
3652 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3653 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3654 char * when the C standard requires it.
3656 * keyboard.c (read_char): Remove unused var.
3658 * eval.c: Port to Windows vsnprintf (Bug#8435).
3660 (SIZE_MAX): Define if the headers do not.
3661 (verror): Do not give up if vsnprintf returns a negative count.
3662 Instead, grow the buffer. This ports to Windows vsnprintf, which
3663 does not conform to C99. Problem reported by Eli Zaretskii.
3664 Also, simplify the allocation scheme, by avoiding the need for
3665 calling realloc, and removing the ALLOCATED variable.
3667 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3669 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3670 But keep the doprint source code for now, as we might revamp it
3671 and use it again (Bug#8435).
3672 * lisp.h (doprnt): Remove.
3673 * Makefile.in (base_obj): Remove doprnt.o.
3674 * deps.mk (doprnt.o): Remove.
3676 error: Print 32- and 64-bit integers portably (Bug#8435).
3677 Without this change, on typical 64-bit hosts error ("...%d...", N)
3678 was used to print both 32- and 64-bit integers N, which relied on
3680 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3682 * lisp.h (error, verror): Mark as printf-like functions.
3683 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3684 Report overflow in size calculations when allocating printf buffer.
3685 Do not truncate output string at its first null byte.
3686 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3687 Truncate the output at a character boundary, since vsnprintf does not
3689 * charset.c (check_iso_charset_parameter): Convert internal
3690 character to string before calling 'error', since %c now has the
3692 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3693 overflow when computing char to be passed to 'error'. Do not
3694 pass Lisp_Object to 'error'; pass the integer instead.
3695 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3696 formatted with plain %d.
3698 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3700 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3702 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3704 * xterm.c (x_catch_errors): Remove duplicate declaration.
3706 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3708 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3710 2011-04-10 Jim Meyering <meyering@redhat.com>
3712 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3713 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3714 return ssize_t not "int", and use size_t as the buffer length.
3715 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3716 * gnutls.h: Update declarations.
3717 * process.c (read_process_output): Use ssize_t, to match.
3718 (send_process): Likewise.
3720 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3722 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3724 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3726 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3727 Use unsigned char, to match FcChar8 type definition.
3729 * xterm.c (handle_one_xevent):
3730 * xmenu.c (create_and_show_popup_menu):
3731 * xselect.c (x_decline_selection_request)
3732 (x_reply_selection_request): Avoid type-punned deref of X events.
3734 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3736 Fix some uses of `int' instead of EMACS_INT.
3737 * search.c (string_match_1, fast_string_match)
3738 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3739 (scan_buffer, find_next_newline_no_quit)
3740 (find_before_next_newline, search_command, Freplace_match)
3741 (Fmatch_data): Make some `int' variables be EMACS_INT.
3743 * xdisp.c (display_count_lines): 3rd argument and return value now
3744 EMACS_INT. All callers changed.
3745 (pint2hrstr): Last argument is now EMACS_INT.
3747 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3748 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3749 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3750 (decode_coding_utf_16, decode_coding_emacs_mule)
3751 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3752 (decode_coding_ccl, decode_coding_charset)
3753 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3754 (decode_coding_iso_2022, decode_coding_emacs_mule)
3755 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3756 <char_offset, last_offset>: Declare EMACS_INT.
3757 (encode_coding_utf_8, encode_coding_utf_16)
3758 (encode_coding_emacs_mule, encode_invocation_designation)
3759 (encode_designation_at_bol, encode_coding_iso_2022)
3760 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3761 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3763 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3764 (encode_invocation_designation): Last argument P_NCHARS is now
3766 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3767 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3769 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3772 * ccl.c (Fccl_execute_on_string): Declare some variables
3775 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3777 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3779 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3781 * process.c (Fformat_network_address): Doc fix.
3783 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3785 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3787 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3789 * keyboard.c (read_char): Call Lisp function help-form-show,
3790 instead of using internal_with_output_to_temp_buffer.
3791 (Qhelp_form_show): New var.
3792 (syms_of_keyboard): Use DEFSYM macro.
3794 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3796 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3798 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3800 * process.c (Flist_processes): Remove to Lisp.
3801 (list_processes_1): Delete.
3803 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3805 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3807 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3809 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3811 Fix more problems found by GCC 4.6.0's static checks.
3813 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3815 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3817 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3819 * xdisp.c (vmessage): Mark as a printf-like function.
3821 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3823 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3825 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3826 printf-like functions.
3827 (tiff_load): Add casts to remove these marks before passing them
3828 to system-supplied API.
3830 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3832 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3833 This avoids several warnings with gcc -Wstrict-overflow.
3834 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3835 directly, rather than having caller test rule sign. This avoids
3836 some unnecessary tests.
3837 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3838 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3839 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3841 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3842 (xfont_open): Avoid unnecessary tests.
3844 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3846 * composite.h, composite.c (composition_gstring_put_cache):
3847 Use EMACS_INT, not int, for length.
3849 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3850 breaking out part of COMPOSITION_DECODE_RULE.
3851 (COMPOSITION_DECODE_RULE): Use it.
3852 * composite.c (get_composition_id): Remove unused local vars,
3853 by using the new macro.
3855 * textprop.c (set_text_properties_1): Change while to do-while,
3856 since the condition is always true at first.
3858 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3859 (interval_deletion_adjustment): Return unsigned value.
3862 * process.c (list_processes_1, create_pty, read_process_output):
3863 (exec_sentinel): Remove vars that were set but not used.
3864 (create_pty): Remove unnecessary "volatile"s.
3865 (Fnetwork_interface_info): Avoid possibility of int overflow.
3866 (read_process_output): Do adaptive read buffering even if carryover.
3867 (read_process_output): Simplify nbytes computation if buffered.
3869 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3871 * syntax.c (scan_words): Remove var that was set but not used.
3872 (update_syntax_table): Use unsigned instead of int.
3874 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3875 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3876 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3878 * print.c (print_error_message): Avoid int overflow.
3880 * font.c (font_list_entities): Redo for clarity,
3881 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3883 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3884 (font_score): Avoid potential overflow in diff calculation.
3886 * fns.c (substring_both): Remove var that is set but not used.
3887 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3889 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3891 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3892 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3893 can always succeed if overflow has undefined behavior.
3895 * search.c (boyer_moore, wordify): Remove vars set but not used.
3896 (wordify): Omit three unnecessary tests.
3898 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3899 All callers changed. This avoids the need for an unused var.
3901 * casefiddle.c (casify_region): Remove var that is set but not used.
3903 * dired.c (file_name_completion): Remove var that is set but not used.
3905 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3907 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3908 (Finsert_file_contents): Remove unnecessary code checking fd.
3910 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3911 Check for integer overflow on size calculations.
3913 * buffer.c (Fprevious_overlay_change): Remove var that is set
3916 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3917 Remove vars that are set but not used.
3918 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3919 (timer_check_2): Mark vars as initialized.
3921 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3923 * image.c (lookup_image): Remove var that is set but not used.
3924 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3926 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3927 that are set but not used.
3929 * xfns.c (make_invisible_cursor): Don't return garbage
3930 if XCreateBitmapFromData fails (Bug#8410).
3932 * xselect.c (x_get_local_selection, x_handle_property_notify):
3933 Remove vars that are set but not used.
3935 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3936 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3938 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3939 Remove var that is set but not used.
3940 (scroll_bar_windows_size): Now size_t, not int.
3941 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3944 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3945 (map_tty_color) [!defined MSDOS]: Likewise.
3947 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3949 * coding.c: Remove vars that are set but not used.
3950 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3951 All callers changed.
3952 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3953 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3954 (decode_coding_charset): Remove vars that are set but not used.
3956 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3957 that is set but not used.
3959 * print.c (print_object): Remove var that is set but not used.
3961 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3962 The gnulib version avoids calling malloc in the usual case,
3963 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3964 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3965 * filelock.c (current_lock_owner): Likewise.
3966 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3967 * sysdep.c: Include allocator.h, careadlinkat.h.
3968 (emacs_no_realloc_allocator): New static constant.
3969 (emacs_readlink): New function.
3970 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3971 ../lib/careadlinkat.h.
3973 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3975 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3976 first non-nil return value).
3978 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3980 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3981 if not defined (Bug#8403).
3983 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3985 * xdisp.c (display_count_lines): Remove parameter `start',
3986 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3987 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3988 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3989 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3990 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3991 and thereabouts. All callers changed.
3992 (get_per_char_metric): Remove parameter `f', unused since
3993 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3995 2011-04-02 Jim Meyering <meyering@redhat.com>
3997 do not dereference NULL upon failed strdup
3998 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3999 (ns_get_family): Likewise.
4001 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4003 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4005 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4007 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4010 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4012 Add lexical binding.
4014 * window.c (Ftemp_output_buffer_show): New fun.
4015 (Fsave_window_excursion):
4016 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4018 * lread.c (lisp_file_lexically_bound_p): New function.
4019 (Fload): Bind Qlexical_binding.
4020 (readevalloop): Remove `evalfun' arg.
4021 Bind Qinternal_interpreter_environment.
4022 (Feval_buffer): Bind Qlexical_binding.
4023 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4025 (syms_of_lread): Declare `lexical-binding'.
4027 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4029 * keyboard.c (eval_dyn): New fun.
4030 (menu_item_eval_property): Use it.
4032 * image.c (parse_image_spec): Use Ffunctionp.
4034 * fns.c (concat, mapcar1): Accept byte-code-functions.
4036 * eval.c (Fsetq): Handle lexical vars.
4037 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4038 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4039 (FletX, Flet): Obey lexical binding.
4040 (Fcommandp): Handle closures.
4041 (Feval): New `lexical' arg.
4042 (eval_sub): New function extracted from Feval. Use it almost
4043 everywhere where Feval was used. Look up vars in lexical env.
4045 (Ffunctionp): Move from subr.el.
4046 (Ffuncall): Handle closures.
4047 (apply_lambda): Remove `eval_flags'.
4048 (funcall_lambda): Handle closures and new byte-code-functions.
4049 (Fspecial_variable_p): New function.
4050 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4051 but without exporting it to Lisp.
4053 * doc.c (Fdocumentation, store_function_docstring):
4054 * data.c (Finteractive_form): Handle closures.
4056 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4059 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4061 (exec_byte_code): New function extracted from Fbyte_code to handle new
4062 calling convention for byte-code-functions. Add new byte-codes.
4064 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4066 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4068 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4070 * xdisp.c (redisplay_internal): Fix prototype.
4072 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4074 * xdisp.c (SCROLL_LIMIT): New macro.
4075 (try_scrolling): Use it when setting scroll_limit.
4076 Limit scrolling to 100 screen lines.
4077 (redisplay_window): Even when falling back on "recentering",
4078 position point in the window according to scroll-conservatively,
4079 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4081 (try_scrolling): When point is above the window, allow searching
4082 as far as scroll_max, or one screenful, to compute vertical
4083 distance from PT to the scroll margin position. This prevents
4084 try_scrolling from unnecessarily failing when
4085 scroll-conservatively is set to a value slightly larger than the
4086 window height. Clean up the case of PT below the margin at bottom
4087 of window: scroll_max can no longer be INT_MAX. When aggressive
4088 scrolling is in use, don't let point enter the opposite scroll
4089 margin as result of the scroll.
4090 (syms_of_xdisp) <scroll-conservatively>: Document the
4091 threshold of 100 lines for never-recentering scrolling.
4093 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4095 * dispextern.h (move_it_by_lines):
4096 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4097 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4098 (message_log_check_duplicate): Remove parameters `prev_bol' and
4099 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4100 (redisplay_internal): Remove parameter `preserve_echo_area',
4101 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4103 * indent.c (Fvertical_motion):
4104 * window.c (window_scroll_pixel_based, Frecenter):
4105 Don't pass `need_y_p' to `move_it_by_lines'.
4107 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4109 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4110 steal a few bits to be more compact.
4111 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4112 Remove unneeded casts.
4114 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4116 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4118 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4119 binding" message (bug#7967).
4121 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4123 Fix more problems found by GCC 4.6.0's static checks.
4125 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4126 Remove unused local var.
4128 * editfns.c (Fmessage_box): Remove unused local var.
4130 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4131 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4132 Omit unused local vars.
4133 * window.c (shrink_windows): Omit unused local var.
4134 * menu.c (digest_single_submenu): Omit unused local var.
4135 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4136 Omit unused local var.
4138 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4139 Don't assume string length fits in int.
4140 (keyremap_step, read_key_sequence): Use size_t for sizes.
4141 (read_key_sequence): Don't check last_real_key_start redundantly.
4143 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4144 instead of alloca (Bug#8344).
4146 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4147 (Fbacktrace_frame): Don't assume nframes fits in int.
4149 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4151 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4154 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4156 * cm.c (calccost): Turn while-do into do-while, for clarity.
4158 * keyboard.c (syms_of_keyboard): Use the same style as later
4159 in this function when indexing through an array. This also
4160 works around GCC bug 48267.
4162 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4164 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4166 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4167 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4169 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4170 This avoids undefined behavior on integer overflow, and is a bit
4171 more convenient anyway since it is compared to a size_t variable.
4173 Variadic C functions now count arguments with size_t, not int.
4174 This avoids an unnecessary limitation on 64-bit machines, which
4175 caused (substring ...) to crash on large vectors (Bug#8344).
4176 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4177 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4178 All variadic functions and their callers changed accordingly.
4179 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4180 * data.c (arith_driver, float_arith_driver): Likewise.
4181 * editfns.c (general_insert_function): Likewise.
4182 * eval.c (struct backtrace.nargs, interactive_p)
4183 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4184 (funcall_lambda, mark_backtrace): Likewise.
4185 * fns.c (concat): Likewise.
4186 * frame.c (x_set_frame_parameters): Likewise.
4187 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4188 0 if not found, not -1. All callers changed.
4190 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4191 (stack_copy_size): Now size_t, not int.
4192 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4194 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4196 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4197 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4198 All callers changed.
4200 * lisp.h (multibyte_char_to_unibyte):
4201 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4202 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4203 * character.h (CHAR_TO_BYTE8):
4204 * cmds.c (internal_self_insert):
4205 * editfns.c (general_insert_function):
4206 * keymap.c (push_key_description):
4207 * search.c (Freplace_match):
4208 * xdisp.c (message_dolog, set_message_1): All callers changed.
4210 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4212 * keyboard.c (safe_run_hook_funcall): New function.
4213 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4214 don't set the hook to nil, but remove the offending function instead.
4215 (Qcommand_hook_internal): Remove, unused.
4216 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4217 Vcommand_hook_internal.
4219 * eval.c (enum run_hooks_condition): Remove.
4220 (funcall_nil, funcall_not): New functions.
4221 (run_hook_with_args): Call each function through a `funcall' argument.
4222 Remove `cond' argument, now redundant.
4223 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4224 (Frun_hook_with_args_until_failure): Adjust accordingly.
4225 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4227 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4229 * dispextern.h (string_buffer_position): Remove declaration.
4231 * print.c (strout): Remove parameter `multibyte', unused since
4232 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4234 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4235 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4236 All callers changed.
4238 * w32.c (_wsa_errlist): Use braces for struct initializers.
4240 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4241 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4242 All callers changed.
4243 (string_buffer_position): Likewise. Also, make static (it's never
4244 used outside xdisp.c).
4245 (cursor_row_p): Remove parameter `w', unused since
4246 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4247 (decode_mode_spec): Remove parameter `precision', introduced during
4248 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4249 All callers changed.
4251 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4253 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4255 2011-03-27 Anders Lindgren <andlind@gmail.com>
4257 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4258 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4259 (ns_update_auto_hide_menu_bar): New functions.
4260 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4261 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4262 ns_constrain_all_frames.
4263 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4264 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4266 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4268 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4270 2011-03-27 Glenn Morris <rgm@gnu.org>
4272 * syssignal.h: Replace RETSIGTYPE with void.
4273 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4274 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4275 Replace SIGTYPE with void everywhere.
4276 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4277 * s/template.h (SIGTYPE): Remove commented out definition.
4279 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4281 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4282 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4284 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4286 * w32.c (read_unc_volume): Use parameter `henum', instead of
4287 global variable `wget_enum_handle'.
4289 * keymap.c (describe_vector): Remove parameters `indices' and
4290 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4291 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4293 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4295 * keyboard.c (timer_check): Remove parameter `do_it_now',
4296 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4297 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4298 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4300 * keyboard.c (read_char):
4301 * w32menu.c (w32_menu_display_help):
4302 * xmenu.c (show_help_event, menu_help_callback):
4303 Adjust calls to `show_help_echo'.
4305 * gtkutil.c (xg_maybe_add_timer):
4306 * keyboard.c (readable_events):
4307 * process.c (wait_reading_process_output):
4308 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4310 * insdel.c (adjust_markers_gap_motion):
4311 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4312 (gap_left, gap_right): Don't call it.
4314 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4316 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4317 incurred during fontification.
4319 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4321 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4322 (DEFVAR_PER_BUFFER): Don't pass it.
4324 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4325 (scrolling_window): Don't pass it.
4327 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4329 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4331 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4333 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4334 of variables specific to SELinux and computation of `encoded_absname'.
4336 * image.c (XPutPixel): Remove unused variable `height'.
4338 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4340 * unexw32.c (get_section_info): Remove unused variable `section'.
4342 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4343 (system_process_attributes): Remove unused variable `sess'.
4344 (sys_read): Remove unused variable `err'.
4346 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4347 (w32_wnd_proc): Remove unused variable `isdead'.
4348 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4349 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4350 (x_create_tip_frame): Remove unused variable `tem'.
4352 * w32inevt.c (w32_console_read_socket):
4353 Remove unused variable `no_events'.
4355 * w32term.c (x_draw_composite_glyph_string_foreground):
4356 Remove unused variable `width'.
4358 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4360 * w32term.c (x_set_glyph_string_clipping):
4361 Don't pass uninitialized region to CombineRgn.
4363 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4365 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4366 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4367 (Fx_close_connection): Remove unused variable `i'.
4369 * w32font.c (w32font_draw): Return number of glyphs.
4370 (w32font_open_internal): Remove unused variable `i'.
4371 (w32font_driver): Add missing initializer.
4373 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4374 (fill_in_menu): Remove unused variable `items_added'.
4376 * w32term.c (last_mouse_press_frame): Remove static global variable.
4377 (w32_clip_to_row): Remove unused variable `f'.
4378 (x_delete_terminal): Remove unused variable `i'.
4380 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4381 (NOTHING): Remove unused static global variable.
4382 (uniscribe_check_otf): Remove unused variable `table'.
4383 (uniscribe_font_driver): Add missing initializers.
4385 2011-03-23 Julien Danjou <julien@danjou.info>
4387 * term.c (Fsuspend_tty, Fresume_tty):
4388 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4389 * window.c (temp_output_buffer_show):
4390 * insdel.c (signal_before_change):
4391 * frame.c (Fhandle_switch_frame):
4392 * fileio.c (Fdo_auto_save):
4393 * emacs.c (Fkill_emacs):
4394 * editfns.c (save_excursion_restore):
4395 * cmds.c (internal_self_insert):
4396 * callint.c (Fcall_interactively):
4397 * buffer.c (Fkill_all_local_variables):
4398 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4400 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4401 unconditionnaly since it does the check itself.
4403 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4405 Fix more problems found by GCC 4.5.2's static checks.
4407 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4408 the first time through the loop, since we know p0 < p1 then.
4409 This also avoids a gcc -Wstrict-overflow warning.
4411 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4412 leading to a memory leak, possible in functions like
4413 load_charset_map_from_file that can allocate an unbounded number
4414 of objects (Bug#8318).
4416 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4417 that could (at least in theory) be that large.
4419 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4420 This is less likely to overflow, and avoids undefined behavior if
4421 overflow does occur. All callers changed. Use strtoul to scan
4422 for the unsigned long integer.
4423 (pint2hrstr): Simplify and tune code slightly.
4424 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4426 * scroll.c (do_scrolling): Work around GCC bug 48228.
4427 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4429 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4430 This also avoids a warning with gcc -Wstrict-overflow.
4431 (validate_x_resource_name): Simplify count usage.
4432 This also avoids a warning with gcc -Wstrict-overflow.
4434 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4437 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4439 * process.c (Fmake_network_process): Use socklen_t, not int,
4440 where POSIX says socklen_t is required in portable programs.
4441 This fixes a porting bug on hosts like 64-bit HP-UX, where
4442 socklen_t is wider than int (Bug#8277).
4443 (Fmake_network_process, server_accept_connection):
4444 (wait_reading_process_output, read_process_output):
4447 * process.c: Rename or move locals to avoid shadowing.
4448 (list_processes_1, Fmake_network_process):
4449 (read_process_output_error_handler, exec_sentinel_error_handler):
4450 Rename or move locals.
4451 (Fmake_network_process): Define label "retry_connect" only if needed.
4452 (Fnetwork_interface_info): Fix pointer signedness.
4453 (process_send_signal): Add cast to avoid pointer signedness problem.
4454 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4455 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4457 Make tparam.h and terminfo.c consistent.
4458 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4459 Include tparam.h instead, since it declares them.
4460 * cm.h (PC): Remove extern decl; tparam.h now does this.
4461 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4462 * terminfo.c: Include tparam.h, to check interfaces.
4463 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4464 (tparam): Adjust signature to match interface in tparam.h;
4465 this removes some undefined behavior. Check that outstring and len
4466 are zero, which they always are with Emacs.
4467 * tparam.h (PC, BC, UP): New extern decls.
4469 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4470 (xftfont_open): Rename locals to avoid shadowing.
4472 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4473 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4474 (OTF_TAG_SYM): Omit macro if not needed.
4475 (ftfont_list): Remove unused local.
4476 (get_adstyle_property, ftfont_pattern_entity):
4477 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4478 Rename locals to avoid shadowing.
4480 * xfont.c (xfont_list_family): Mark var as initialized.
4482 * xml.c (make_dom): Now static.
4484 * composite.c (composition_compute_stop_pos): Rename local to
4486 (composition_reseat_it): Remove unused locals.
4487 (find_automatic_composition, composition_adjust_point): Likewise.
4488 (composition_update_it): Mark var as initialized.
4489 (find_automatic_composition): Mark vars as initialized,
4490 with a FIXME (Bug#8290).
4492 character.h: Rename locals to avoid shadowing.
4493 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4494 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4495 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4496 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4499 * textprop.c (property_change_between_p): Remove; unused.
4501 * intervals.c (interval_start_pos): Now static.
4503 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4505 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4506 Rename locals to avoid shadowing.
4508 * sound.c (wav_play, au_play, Fplay_sound_internal):
4509 Fix pointer signedness.
4510 (alsa_choose_format): Remove unused local var.
4511 (wav_play): Initialize a variable to 0, to prevent undefined
4512 behavior (Bug#8278).
4514 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4516 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4518 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4519 clobbering (Bug#8298).
4520 * sysdep.c (sys_subshell): Likewise.
4521 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4523 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4524 This should get cleaned up, so that child_setup has the
4525 same signature on all platforms.
4527 * callproc.c (call_process_cleanup): Now static.
4528 (relocate_fd): Rename locals to avoid shadowing.
4530 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4532 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4533 not to be necessary, and produces flickering.
4535 2011-03-20 Glenn Morris <rgm@gnu.org>
4537 * config.in: Remove file.
4539 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4541 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4542 are now in src/globals.h.
4543 (syms_of_minibuf): Remove spurious & from previous change.
4545 2011-03-20 Leo <sdl.web@gmail.com>
4547 * minibuf.c (completing-read-function): New variable.
4548 (completing-read-default): Rename from completing-read.
4549 (completing-read): Call completing-read-function.
4551 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4553 * xfaces.c (Fx_load_color_file):
4554 Read color file from absolute filename (bug#8250).
4556 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4558 * makefile.w32-in: Update dependencies.
4560 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4562 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4564 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4566 Fix more problems found by GCC 4.5.2's static checks.
4568 * process.c (make_serial_process_unwind, send_process_trap):
4569 (sigchld_handler): Now static.
4571 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4572 That way, the code declares only the vars that it needs.
4573 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4574 * s/cygwin.h (PTY_ITERATION): Likewise.
4575 * s/darwin.h (PTY_ITERATION): Likewise.
4576 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4578 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4579 * process.c (allocate_pty): Don't declare stb unless it's needed.
4581 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4582 (CONSTANTLIM): Remove; unused.
4583 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4584 Define only if needed.
4586 * unexelf.c (unexec): Name an expression,
4587 to avoid gcc -Wbad-function-cast warning.
4588 Use a different way to cause a compilation error if anyone uses
4589 n rather than nn, a way that does not involve shadowing.
4590 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4592 * deps.mk (unexalpha.o): Remove; unused.
4594 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4595 * unexec.h: New file.
4596 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4597 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4599 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4600 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4601 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4602 Change as necessary to match prototype in unexec.h.
4604 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4606 (back_comment, skip_chars): Mark vars as initialized.
4608 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4609 Rename locals to avoid shadowing.
4611 * lread.c (read1): Rewrite so as not to use empty "else".
4612 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4614 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4616 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4617 warning when compiling print.c.
4619 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4620 instead of using an uninitialized var.
4621 (font_sort_entities): Mark var as initialized.
4623 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4625 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4626 pointers to constants.
4627 (font_parse_fcname): Remove unused vars.
4628 (font_delete_unmatched): Now static.
4629 (font_get_spec): Remove; unused.
4630 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4631 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4632 Rename or move locals to avoid shadowing.
4634 * fns.c (require_nesting_list, require_unwind): Now static.
4635 (Ffillarray): Rename locals to avoid shadowing.
4637 * floatfns.c (domain_error2): Define only if needed.
4638 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4640 * alloc.c (mark_backtrace): Move decl from here ...
4641 * lisp.h: ... to here, so that it can be checked.
4643 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4644 (Fdefvar): Rewrite so as not to use empty "else".
4645 (lisp_indirect_variable): Name an expression,
4646 to avoid gcc -Wbad-function-cast warning.
4647 (Fdefvar): Rename locals to avoid shadowing.
4649 * callint.c (quotify_arg, quotify_args): Now static.
4650 (Fcall_interactively): Rename locals to avoid shadowing.
4651 Use const pointer when appropriate.
4653 * lisp.h (get_system_name, get_operating_system_release):
4654 Move decls here, to check interfaces.
4655 * process.c (get_operating_system_release): Move decl to lisp.h.
4656 * xrdb.c (get_system_name): Likewise.
4657 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4658 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4659 some of which prompt warnings from gcc -Wbad-function-cast.
4660 (Fformat_time_string, Fencode_time, Finsert_char):
4661 (Ftranslate_region_internal, Fformat):
4662 Rename or remove local vars to avoid shadowing.
4663 (Ftranslate_region_internal): Mark var as initialized.
4665 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4668 * lisp.h (eassert): Check that the argument compiles, even if
4669 ENABLE_CHECKING is not defined.
4671 * data.c (Findirect_variable): Name an expression, to avoid
4672 gcc -Wbad-function-cast warning.
4673 (default_value, arithcompare, arith_driver, arith_error): Now static.
4674 (store_symval_forwarding): Rename local to avoid shadowing.
4675 (Fmake_variable_buffer_local, Fmake_local_variable):
4676 Mark variables as initialized.
4677 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4679 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4680 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4681 Rename locals to avoid shadowing.
4682 (mark_stack): Move local variables into the #ifdef region where
4684 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4685 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4687 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4688 (GC_STRING_CHARS): Remove; not used.
4689 (Fmemory_limit): Cast sbrk's returned value to char *.
4691 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4692 avoids undefined behavior in theory.
4694 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4696 Use functions, not macros, for up- and down-casing (Bug#8254).
4697 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4698 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4699 to use the following functions instead of these macros.
4700 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4701 EMACS_INT, since callers assume the returned value fits in int.
4702 (upcase1): Likewise, for UPCASE_TABLE.
4703 (uppercasep, lowercasep, upcase): New static inline functions.
4704 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4705 the race-condition problem in the old DOWNCASE.
4707 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4708 Rename locals to avoid shadowing.
4709 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4710 (regex_compile, re_search_2, re_match_2_internal):
4711 Remove unused local vars.
4712 (FREE_VAR): Rewrite so as not to use empty "else",
4713 which gcc can warn about.
4714 (regex_compile, re_match_2_internal): Mark locals as initialized.
4715 (RETALLOC_IF): Define only if needed.
4716 (WORDCHAR_P): Likewise. This one is never needed, but is used
4717 only in a comment talking about a compiler bug, so put inside
4718 the #if 0 of that comment.
4719 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4720 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4723 * search.c (boyer_moore): Rename locals to avoid shadowing.
4724 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4725 (PREV_CHAR_BOUNDARY): Likewise.
4727 * search.c (simple_search): Remove unused var.
4729 * dired.c (compile_pattern): Move decl from here ...
4730 * lisp.h: ... to here, so that it can be checked.
4731 (struct re_registers): New forward decl.
4733 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4735 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4737 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4738 Rename locals to avoid shadowing.
4739 (Fvertical_motion): Mark locals as initialized.
4741 * casefiddle.c (casify_object, casify_region): Now static.
4742 (casify_region): Mark local as initialized.
4744 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4746 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4747 New macros, so that the caller can use some names other than
4748 gcpro1, gcpro2, etc.
4749 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4751 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4752 argument, for consistency with GCPRO2_VAR, etc: it is now the
4753 prefix of the variable, not the variable itself. All uses
4755 * dired.c (directory_files_internal, file_name_completion):
4756 Rename locals to avoid shadowing.
4758 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4759 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4760 dired.c's scmp function, had undefined behavior.
4761 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4762 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4763 * buffer.h: ... to here, because these macros use current_buffer,
4764 and the new implementation with inline functions needs to have
4765 current_buffer in scope now, rather than later when the macros
4767 (downcase, upcase1): New static inline functions.
4768 (DOWNCASE, UPCASE1): Reimplement using these functions.
4769 This avoids undefined behavior in expressions like
4770 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4771 from race conditions in accessing the global variables
4772 case_temp1 and case_temp2.
4773 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4774 * lisp.h (case_temp1, case_temp2): Remove their decls.
4775 * character.h (ASCII_CHAR_P): Move from here ...
4776 * lisp.h: ... to here, so that the inline functions mentioned
4779 * dired.c (directory_files_internal_unwind): Now static.
4781 * fileio.c (file_name_as_directory, directory_file_name):
4782 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4784 (file_name_as_directory): Use const pointers when appropriate.
4785 (Fexpand_file_name): Likewise. In particular, newdir might
4786 point at constant storage, so make it a const pointer.
4787 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4788 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4790 (Fset_file_times, Finsert_file_contents, auto_save_error):
4791 Rename locals to avoid shadowing.
4793 * minibuf.c (choose_minibuf_frame_1): Now static.
4794 (Ftry_completion, Fall_completions): Rename or remove locals
4797 * marker.c (bytepos_to_charpos): Remove; unused.
4799 * lisp.h (verify_bytepos, count_markers): New decls,
4800 so that gcc does not warn that these functions aren't declared.
4802 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4803 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4804 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4805 (copy_text): Remove unused local var.
4807 * filelock.c (within_one_second): Now static.
4808 (lock_file_1): Rename local to avoid shadowing.
4810 * buffer.c (fix_overlays_before): Mark locals as initialized.
4811 (fix_start_end_in_overlays): Likewise. This function should be
4812 simplified by using pointers-to-pointers, but that's a different
4814 (switch_to_buffer_1): Now static.
4815 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4816 (report_overlay_modification): Rename locals to avoid shadowing.
4818 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4819 Fix pointer signedness issue.
4820 (sys_subshell): Mark local as volatile if checking for lint,
4821 to suppress a gcc -Wclobbered warning that does not seem to be right.
4822 (MAXPATHLEN): Define only if needed.
4824 * process.c (serial_open, serial_configure): Move decls from here ...
4825 * systty.h: ... to here, so that they can be checked.
4827 * fns.c (get_random, seed_random): Move extern decls from here ...
4828 * lisp.h: ... to here, so that they can be checked.
4830 * sysdep.c (reset_io): Now static.
4831 (wait_for_termination_signal): Remove; unused.
4833 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4834 (copy_keymap_item, append_key, push_text_char_description):
4836 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4837 (DENSE_TABLE_SIZE): Remove; unused.
4838 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4839 (describe_map_tree):
4840 Rename locals to avoid shadowing.
4842 * keyboard.c: Declare functions static if they are not used elsewhere.
4843 (echo_char, echo_dash, cmd_error, top_level_2):
4844 (poll_for_input, handle_async_input): Now static.
4845 (read_char, kbd_buffer_get_event, make_lispy_position):
4846 (make_lispy_event, make_lispy_movement, apply_modifiers):
4847 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4848 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4849 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4850 (read_key_sequence, read_char): Mark locals as initialized.
4851 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4853 * keyboard.h (make_ctrl_char): New decl.
4854 (mark_kboards): Move decl here ...
4855 * alloc.c (mark_kboards): ... from here.
4857 * lisp.h (force_auto_save_soon): New decl.
4859 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4860 (DEFINE_DUMMY_FUNCTION): New macro.
4861 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4863 (main): Add casts to avoid warnings
4864 if GCC considers string literals to be constants.
4866 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4868 * dbusbind.c: Pointer signedness fixes.
4869 (xd_signature, xd_append_arg, xd_initialize):
4870 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4871 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4872 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4873 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4875 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4876 if GCC considers string literals to be constants.
4877 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4879 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4881 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4882 (print_preprocess, print_object): New macro to fix last change.
4884 * print.c (print_preprocess): Don't forget font objects.
4886 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4888 * emacs.c (USAGE3): Doc fixes.
4890 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4892 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4895 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4897 * lisp.h (VWindow_system, Qfile_name_history):
4898 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4899 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4900 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4902 * w32select.c: Don't #include "keyboard.h".
4903 (run_protected): Add extern declaration for waiting_for_input.
4905 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4906 * w32console.c (detect_input_pending, read_input_pending)
4907 (encode_terminal_code):
4908 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4909 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4910 (w32_system_caret_y, Qfile_name_history):
4911 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4912 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4913 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4914 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4915 * w32proc.c (Qlocal, report_file_error):
4916 * w32term.c (Vwindow_system, updating_frame):
4917 * w32uniscribe.c (initialized, uniscribe_font_driver):
4918 Remove unneeded extern declarations.
4920 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4922 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4924 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4926 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4927 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4928 These macros can no longer be used for assignment.
4930 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4931 Assign struct members directly, instead of using BUF_BEGV etc.
4932 (record_buffer_markers, fetch_buffer_markers): New functions for
4933 recording and fetching special buffer markers.
4934 (set_buffer_internal_1, set_buffer_temp): Use them.
4936 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4938 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4940 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4941 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4943 * xdisp.c (hscroll_window_tree):
4944 (reconsider_clip_changes): Use PT instead of BUF_PT.
4946 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4948 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4949 $(EMACS_ROOT)/lib/intprops.h.
4951 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4953 Fix more problems found by GCC 4.5.2's static checks.
4955 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4956 to unsigned char * to avoid compiler diagnostic.
4957 (xg_free_frame_widgets): Make it clear that a local variable is
4958 needed only if USE_GTK_TOOLTIP.
4959 (gdk_window_get_screen): Make it clear that this macro is needed
4960 only if USE_GTK_TOOLTIP.
4961 (int_gtk_range_get_value): New function, which avoids a diagnostic
4962 from gcc -Wbad-function-cast.
4963 (xg_set_toolkit_scroll_bar_thumb): Use it.
4964 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4965 diagnostic from gcc -Wbad-function-cast.
4966 (get_utf8_string, xg_get_file_with_chooser):
4967 Rename locals to avoid shadowing.
4968 (create_dialog): Move locals to avoid shadowing.
4970 * xgselect.c (xg_select): Remove unused var.
4972 * image.c (four_corners_best): Mark locals as initialized.
4973 (gif_load): Initialize transparent_p to zero (Bug#8238).
4974 Mark another local as initialized.
4975 (my_png_error, my_error_exit): Mark with NO_RETURN.
4977 * image.c (clear_image_cache): Now static.
4978 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4979 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4980 (x_edge_detection): Remove unnecessary cast that
4981 gcc -Wbad-function-cast diagnoses.
4982 (gif_load): Fix pointer signedness.
4983 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4984 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4986 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4988 Improve quality of tests for time stamp overflow.
4989 For example, without this patch (encode-time 0 0 0 1 1
4990 1152921504606846976) returns the obviously-bogus value (-948597
4991 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4992 reports time overflow. See
4993 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4994 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4995 * editfns.c: Include limits.h and intprops.h.
4996 (TIME_T_MIN, TIME_T_MAX): New macros.
4997 (time_overflow): Move earlier, to before first use.
4998 (hi_time, lo_time): New functions, for an accurate test for
5000 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5001 (Fget_internal_run_time): Don't assume time_t fits in int.
5002 (make_time): Use list2 instead of Fcons twice.
5003 (Fdecode_time): More accurate test for out-of-range times.
5004 (check_tm_member): New function.
5005 (Fencode_time): Use it, to test for out-of-range times.
5006 (lisp_time_argument): Don't rely on undefined left-shift and
5007 right-shift behavior when checking for time stamp overflow.
5009 * editfns.c (time_overflow): New function, refactoring common code.
5010 (Fformat_time_string, Fdecode_time, Fencode_time):
5011 (Fcurrent_time_string): Use it.
5013 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5014 * dired.c (make_time): Move to ...
5015 * editfns.c (make_time): ... here.
5016 * systime.h: Note the move.
5018 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5020 * fringe.c (update_window_fringes): Remove unused variables.
5022 * unexmacosx.c (copy_data_segment): Also copy __got section.
5025 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5027 * termcap.c [MSDOS]: Include "msdos.h".
5028 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5029 Constify `char *' arguments and their references according to
5030 prototypes in tparam.h.
5032 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5034 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5035 Adapt all references accordingly.
5037 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5039 2011-03-11 Tom Tromey <tromey@redhat.com>
5041 * buffer.c (syms_of_buffer): Remove obsolete comment.
5043 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5045 * termhooks.h (encode_terminal_code): Declare prototype.
5047 * msdos.c (encode_terminal_code): Don't declare prototype.
5049 * term.c (encode_terminal_code): Now external again, used by
5050 w32console.c and msdos.c.
5052 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5053 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5055 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5057 Fix some minor problems found by GCC 4.5.2's static checks.
5059 * fringe.c (update_window_fringes): Mark locals as initialized
5061 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5063 * alloc.c (mark_fringe_data): Move decl from here ...
5064 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5065 to check its interface.
5066 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5068 * fontset.c (free_realized_fontset): Now static.
5069 (Fset_fontset_font): Rename local to avoid shadowing.
5070 (fontset_font): Mark local as initialized.
5071 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5073 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5075 * xselect.c (x_disown_buffer_selections): Remove; not used.
5076 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5077 (x_own_selection, Fx_disown_selection_internal): Rename locals
5079 (x_handle_dnd_message): Remove local to avoid shadowing.
5081 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5082 so that the caller can use some name other than gcpro1.
5083 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5084 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5085 (Fx_backspace_delete_keys_p):
5086 Use them to avoid shadowing, and rename vars to avoid shadowing.
5087 (x_decode_color, x_set_name, x_window): Now static.
5088 (Fx_create_frame): Add braces to silence GCC warning.
5089 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5090 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5091 Remove unused locals.
5092 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5093 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5094 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5097 * xterm.h (x_mouse_leave): New decl.
5099 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5100 Remove unused functions.
5101 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5102 (x_calc_absolute_position): Now static.
5103 (XTread_socket): Don't define label "out" unless it's used.
5104 Don't declare local "event" unless it's used.
5105 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5106 unless they are used.
5107 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5108 (x_fatal_error_signal): Remove; not used.
5109 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5110 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5111 (x_error_catcher, x_connection_closed, x_error_handler):
5112 (x_error_quitter, xembed_send_message, x_iconify_frame):
5113 (my_log_handler): Rename locals to avoid shadowing.
5114 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5115 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5117 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5118 Rename or move locals to avoid shadowing.
5119 (tty_defined_color, merge_face_heights): Now static.
5120 (free_realized_faces_for_fontset): Remove; not used.
5121 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5122 does not deduce is never used uninitialized.
5123 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5124 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5126 * terminal.c (store_terminal_param): Now static.
5128 * xmenu.c (menu_highlight_callback): Now static.
5129 (set_frame_menubar): Remove unused local.
5130 (xmenu_show): Rename parameter to avoid shadowing.
5131 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5132 since they might point to immutable storage.
5133 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5134 since it's unused otherwise.
5136 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5137 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5138 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5139 avoids a gcc -Wuninitialized diagnostic.
5140 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5141 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5142 does not deduce are never used uninitialized.
5144 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5146 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5147 * window.c (window_loop, size_window):
5148 (run_window_configuration_change_hook, enlarge_window): Likewise.
5150 * window.c (display_buffer): Now static.
5151 (size_window): Mark variables that gcc -Wuninitialized
5152 does not deduce are never used uninitialized.
5153 * window.h (check_all_windows): New decl, to forestall
5154 gcc -Wmissing-prototypes diagnostic.
5155 * dispextern.h (bidi_dump_cached_states): Likewise.
5157 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5159 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5161 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5162 and to avoid gcc -Wuninitialized warning.
5163 (load_charset_map): Mark variables that gcc -Wuninitialized
5164 does not deduce are never used uninitialized.
5165 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5167 * coding.c (coding_set_source, coding_set_destination):
5168 Use "else { /* comment */ }" rather than "else /* comment */;"
5169 for clarity, and to avoid gcc -Wempty-body warning.
5170 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5171 a block, when the outer 'i' will do.
5172 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5173 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5174 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5175 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5176 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5177 Rename locals to avoid shadowing.
5178 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5179 * coding.c (emacs_mule_char, encode_invocation_designation):
5180 Now static, since they're not used elsewhere.
5181 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5182 (decode_coding_object, encode_coding_object, detect_coding_system):
5183 (decode_coding_emacs_mule): Mark variables that gcc
5184 -Wuninitialized does not deduce are never used uninitialized.
5185 (detect_coding_iso_2022): Initialize a local variable that might
5186 be used uninitialized. Leave a FIXME because it's not clear that
5187 this initialization is needed. (Bug#8211)
5188 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5189 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5190 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5191 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5192 Remove unused macros.
5194 * category.c (hash_get_category_set): Remove unused local var.
5195 (copy_category_table): Now static, since it's not used elsewhere.
5196 * character.c (string_count_byte8): Likewise.
5198 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5199 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5201 * chartab.c (copy_sub_char_table): Now static, since it's not used
5203 (sub_char_table_ref_and_range, char_table_ref_and_range):
5204 Rename locals to avoid shadowing.
5205 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5207 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5208 (BIDI_BOB): Remove unused macro.
5210 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5211 deduce are never used uninitialized.
5212 * term.c (encode_terminal_code): Likewise.
5214 * term.c (encode_terminal_code): Now static. Remove unused local.
5216 * tparam.h: New file.
5217 * term.c, tparam.h: Include it.
5218 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5219 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5220 Move these decls to tparam.h, and make them agree with what
5221 is actually in tparam.c. The previous trick of using incompatible
5222 decls in different modules does not conform to the C standard.
5223 All callers of tparam changed to use tparam's actual API.
5224 * tparam.c (tparam1, tparam, tgoto):
5225 Use const pointers where appropriate.
5227 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5228 * cm.h (struct cm): Likewise.
5229 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5230 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5231 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5232 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5233 (turn_on_face, init_tty): Likewise.
5234 * termchar.h (struct tty_display_info): Likewise.
5236 * term.c (term_mouse_position): Rename local to avoid shadowing.
5238 * alloc.c (mark_ttys): Move decl from here ...
5239 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5241 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5243 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5245 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5247 * search.c (compile_pattern_1): Remove argument regp, unused since
5248 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5249 (compile_pattern): Don't pass it.
5251 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5253 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5254 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5256 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5258 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5260 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5261 gdk_window_get_screen, gdk_window_get_geometry,
5262 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5263 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5264 (xg_get_pixbuf_from_pixmap): New function.
5265 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5266 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5267 Call xg_get_pixbuf_from_pixmap instead of
5268 gdk_pixbuf_get_from_drawable.
5269 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5270 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5271 (xg_check_special_colors): Use GtkStyleContext and its functions
5273 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5274 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5275 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5276 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5277 Call gtk_widget_get_preferred_size.
5278 (xg_frame_resized): gdk_window_get_geometry only takes 5
5280 (xg_win_to_widget, xg_event_is_for_menubar):
5281 Call gdk_x11_window_lookup_for_display.
5282 (xg_set_widget_bg): New function.
5283 (delete_cb): New function.
5284 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5285 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5286 (xg_set_background_color): Call xg_set_widget_bg.
5287 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5288 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5289 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5290 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5292 (update_frame_tool_bar): Call gtk_widget_hide.
5293 (xg_initialize): Use GDK_KEY_g.
5295 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5297 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5299 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5300 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5301 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5303 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5305 * w32xfns.c (select_palette): Check success of RealizePalette against
5306 GDI_ERROR, not zero.
5308 See ChangeLog.11 for earlier changes.
5314 Copyright (C) 2011 Free Software Foundation, Inc.
5316 This file is part of GNU Emacs.
5318 GNU Emacs is free software: you can redistribute it and/or modify
5319 it under the terms of the GNU General Public License as published by
5320 the Free Software Foundation, either version 3 of the License, or
5321 (at your option) any later version.
5323 GNU Emacs is distributed in the hope that it will be useful,
5324 but WITHOUT ANY WARRANTY; without even the implied warranty of
5325 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5326 GNU General Public License for more details.
5328 You should have received a copy of the GNU General Public License
5329 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.