* callproc.c (child_setup): Don't assume strlen fits in int.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2
3 * callproc.c (child_setup): Don't assume strlen fits in int.
4
5 * buffer.c: Memory overflow fixes.
6 (overlays_at, overlays_in, record_overlay_string, overlay_strings):
7 Don't update size of array until after memory allocation succeeds,
8 because xmalloc/xrealloc may not return.
9
10 * bidi.c: Integer overflow fix.
11 (bidi_shelve_header_size): New constant.
12 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
13 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
14
15 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
16
17 Use ptrdiff_t for composition IDs.
18 * character.c (lisp_string_width):
19 * composite.c (composition_table_size, n_compositions)
20 (get_composition_id, composition_gstring_from_id):
21 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
22 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
23 * window.c (Frecenter):
24 Use ptrdiff_t, not int, for composition IDs.
25 * composite.c (get_composition_id): Check for integer overflow.
26 * composite.h: Adjust prototypes to match the above changes.
27
28 Use ptrdiff_t for hash table indexes.
29 * category.c (hash_get_category_set):
30 * ccl.c (ccl_driver):
31 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
32 * coding.c (coding_system_charset_list, detect_coding_system):
33 * coding.h (struct coding_system.id):
34 * composite.c (get_composition_id, gstring_lookup_cache):
35 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
36 * image.c (xpm_get_color_table_h):
37 * lisp.h (hash_lookup, hash_put):
38 * minibuf.c (Ftest_completion):
39 Use ptrdiff_t for hash table indexes, not int (which is too
40 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
41 32-bit --with-wide-int hosts).
42
43 * charset.c (Fdefine_charset_internal): Check for integer overflow.
44 Add a FIXME comment about memory leaks.
45 (syms_of_charset): Don't assume xmalloc returns.
46
47 Don't assume that stated character widths fit in int.
48 * character.c (Fchar_width, c_string_width, lisp_string_width):
49 * character.h (CHAR_WIDTH):
50 * indent.c (MULTIBYTE_BYTES_WIDTH):
51 Use sanitize_char_width to avoid undefined and/or bad behavior
52 with outlandish widths.
53 * character.h (sanitize_tab_width): Renamed from sanitize_width,
54 now that we have two such functions. All uses changed.
55 (sanitize_char_width): New inline function.
56
57 Don't assume that tab-width fits in int.
58 * character.h (sanitize_width): New inline function.
59 (SANE_TAB_WIDTH): New macro.
60 (ASCII_CHAR_WIDTH): Use it.
61 * indent.c (sane_tab_width): Remove. All uses replaced by
62 SANE_TAB_WIDTH (current_buffer).
63 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
64
65 * fileio.c: Integer overflow issues with file modes.
66 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
67
68 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
69 Remove unreachable code.
70 (read_hex, load_charset_map_from_file): Check for integer overflow.
71
72 * xterm.c: don't go over XClientMessageEvent limit
73 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
74 (x_send_scroll_bar_event): Likewise. Check that the size does not
75 exceed limits imposed by XClientMessageEvent, as well as the usual
76 ptrdiff_t and size_t limits.
77
78 * keyboard.c: Overflow, signedness and related fixes.
79 (make_lispy_movement): Use same integer type in forward decl
80 that is used in the definition.
81 (read_key_sequence, keyremap_step):
82 Change bufsize argument back to int, undoing my 2011-03-30 change.
83 We prefer signed types, and int is wide enough here.
84 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
85 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
86 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
87 length, not size_t. Use ptrdiff_t for index, not int.
88 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
89 possibility of integer overflow.
90
91 Overflow, signedness and related fixes for images.
92
93 * dispextern.h (struct it.stack[0].u.image.image_id)
94 (struct_it.image_id, struct image.id, struct image_cache.size)
95 (struct image_cache.used, struct image_cache.ref_count):
96 * gtkutil.c (update_frame_tool_bar):
97 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
98 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
99 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
100 * nsmenu.m (update_frame_tool_bar):
101 * xdisp.c (calc_pixel_width_or_height):
102 * xfns.c (image_cache_refcount):
103 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
104 on typical 64-bit hosts.
105
106 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
107 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
108 Omit unnecessary casts to int.
109 (parse_image_spec): Check that integers fall into 'int' range
110 when the callers expect that.
111 (image_ascent): Redo ascent calculation to avoid int overflow.
112 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
113 (lookup_image): Remove unnecessary tests.
114 (xbm_image_p): Locals are now of int, not EMACS_INT,
115 since parse_image_check makes sure they fit into int.
116 (png_load, gif_load, svg_load_image):
117 Prefer int to unsigned where either will do.
118 (tiff_handler): New function, combining the cores of the
119 old tiff_error_handler and tiff_warning_handler. This
120 function is rewritten to use vsnprintf and thereby avoid
121 stack buffer overflows. It uses only the features of vsnprintf
122 that are common to both POSIX and native Microsoft.
123 (tiff_error_handler, tiff_warning_handler): Use it.
124 (tiff_load, gif_load, imagemagick_load_image):
125 Don't assume :index value fits in 'int'.
126 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
127 (imagemagick_load_image): Check that crop parameters fit into
128 the integer types that MagickCropImage accepts. Don't assume
129 Vimagemagick_render_type has a nonnegative value. Don't assume
130 size_t fits in 'long'.
131 (gs_load): Use printmax_t to print the widest integers possible.
132 Check for integer overflow when computing image height and width.
133
134 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
135
136 Integer signedness and overflow and related fixes. (Bug#9079)
137
138 * bidi.c: Integer size and overflow fixes.
139 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
140 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
141 (bidi_cache_find_level_change, bidi_cache_ensure_space)
142 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
143 (bidi_find_other_level_edge):
144 Use ptrdiff_t instead of EMACS_INT where either will do.
145 This works better on 32-bit hosts configured --with-wide-int.
146 (bidi_cache_ensure_space): Check for size-calculation overflow.
147 Use % rather than repeated addition, for better worst-case speed.
148 Don't set bidi_cache_size until after xrealloc returns, because it
149 might not return.
150 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
151 (bidi_cache_ensure_space): Also check that the bidi cache size
152 does not exceed that of the largest Lisp string or buffer. See Eli
153 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
154
155 * alloc.c (__malloc_size_t): Remove.
156 All uses replaced by size_t. See Andreas Schwab's note
157 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
158
159 * image.c: Improve checking for integer overflow.
160 (check_image_size): Assume that f is nonnull, since
161 it is always nonnull in practice. This is one less thing to
162 worry about when checking for integer overflow later.
163 (x_check_image_size): New function, which checks for integer
164 overflow issues inside X.
165 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
166 This removes the need for a memory_full check.
167 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
168 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
169 (xbm_read_bitmap_data): Change locals back to 'int', since
170 their values must fit in 'int'.
171 (xpm_load_image, png_load, tiff_load):
172 Invoke x_create_x_image_and_pixmap earlier,
173 to avoid much needless work if the image is too large.
174 (tiff_load): Treat overly large images as if
175 x_create_x_image_and_pixmap failed, not as malloc failures.
176 (gs_load): Use x_check_image_size.
177
178 * gtkutil.c: Omit integer casts.
179 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
180 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
181
182 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
183
184 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
185 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
186 would wrongly return t on a 64-bit host.
187
188 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
189 The plain *_OVERFLOW macros run afoul of GCC bug 49705
190 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
191 and therefore cause GCC to emit a bogus diagnostic in some cases.
192
193 * image.c: Integer signedness and overflow and related fixes.
194 This is not an exhaustive set of fixes, but it's time to
195 record what I've got.
196 (lookup_pixel_color, check_image_size): Remove redundant decls.
197 (check_image_size): Don't assume that arbitrary EMACS_INT values
198 fit in 'int', or that arbitrary 'double' values fit in 'int'.
199 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
200 (tiff_load, imagemagick_load_image):
201 Check for overflow in size calculations.
202 (x_create_x_image_and_pixmap): Remove unnecessary test for
203 xmalloc returning NULL; that can't happen.
204 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
205 (xpm_color_bucket): Use better integer hashing function.
206 (xpm_cache_color): Don't possibly over-allocate memory.
207 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
208 (gif_memory_source):
209 Use ptrdiff_t, not int or size_t, to record sizes.
210 (png_load): Don't assume values greater than 2**31 fit in 'int'.
211 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
212 either works, as we prefer signed integers.
213 (tiff_read_from_memory, tiff_write_from_memory):
214 Return tsize_t, not size_t, since that's what the TIFF API wants.
215 (tiff_read_from_memory): Don't fail simply because the read would
216 go past EOF; instead, return a short read.
217 (tiff_load): Omit no-longer-needed casts.
218 (Fimagemagick_types): Don't assume size fits into 'int'.
219
220 Improve hashing quality when configured --with-wide-int.
221 * fns.c (hash_string): New function, taken from sxhash_string.
222 Do not discard information about ASCII character case; this
223 discarding is no longer needed.
224 (sxhash-string): Use it. Change sig to match it. Caller changed.
225 * lisp.h: Declare it.
226 * lread.c (hash_string): Remove, since we now use fns.c's version.
227 The fns.c version returns a wider integer if --with-wide-int is
228 specified, so this should help the quality of the hashing a bit.
229
230 * emacs.c: Integer overflow minor fix.
231 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
232 Define only if GNU_LINUX.
233 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
234
235 * dispnew.c: Integer signedness and overflow fixes.
236 Remove unnecessary forward decls, that were a maintenance hassle.
237 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
238 All uses changed.
239 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
240 (scrolling_window): Use ptrdiff_t, not int, for byte count.
241 (prepare_desired_row, line_draw_cost):
242 Use int, not unsigned, where either works.
243 (save_current_matrix, restore_current_matrix):
244 Use ptrdiff_t, not size_t, where either works.
245 (init_display): Check for overflow more accurately, and without
246 relying on undefined behavior.
247
248 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
249 Remove, replacing with the new symbols in lisp.h. All uses changed.
250 * fileio.c (make_temp_name):
251 * filelock.c (lock_file_1, lock_file):
252 * xdisp.c (message_dolog):
253 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
254 Use pMd etc. instead.
255 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
256 replacing the pWIDE etc. symbols removed from editfns.c.
257
258 * keyboard.h (num_input_events): Now uintmax_t.
259 This is (very slightly) less likely to mess up due to wraparound.
260 All uses changed.
261
262 * buffer.c: Integer signedness fixes.
263 (alloc_buffer_text, enlarge_buffer_text):
264 Use ptrdiff_t rather than size_t when either will do, as we prefer
265 signed integers.
266
267 * alloc.c: Integer signedness and overflow fixes.
268 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
269 (__malloc_size_t): Default to size_t, not to int.
270 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
271 (Fgarbage_collect, mark_object_loop_halt, mark_object):
272 Prefer ptrdiff_t to size_t when either would do, as we prefer
273 signed integers.
274 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
275 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
276 Now const. Initialize with values that are in range even if char
277 is signed.
278 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
279 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
280 These functions do the right thing with sizes > 2**32.
281 (check_depth): Now ptrdiff_t, not int.
282 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
283 Adjust to new way of storing sizes. Check for size overflow bugs
284 in rest of code.
285 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
286 slightly wrong anyway, as it missed one instance of
287 XMALLOC_OVERRUN_CHECK_OVERHEAD.
288 (refill_memory_reserve): Omit needless cast to size_t.
289 (mark_object_loop_halt): Mark as externally visible.
290
291 * xselect.c: Integer signedness and overflow fixes.
292 (Fx_register_dnd_atom, x_handle_dnd_message):
293 Use ptrdiff_t, not size_t, since we prefer signed.
294 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
295 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
296 x_dnd_atoms_size and x_dnd_atoms_length.
297
298 * doprnt.c: Prefer signed to unsigned when either works.
299 * eval.c (verror):
300 * doprnt.c (doprnt):
301 * lisp.h (doprnt):
302 * xdisp.c (vmessage):
303 Use ptrdiff_t, not size_t, when using or implementing doprnt,
304 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
305 prefer signed arithmetic to avoid comparison confusion.
306 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
307 but is a bit tricky.
308
309 Assume freestanding C89 headers, string.h, stdlib.h.
310 * data.c, doprnt.c, floatfns.c, print.c:
311 Include float.h unconditionally.
312 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
313 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
314 * regex.c: Likewise for stddef.h, string.h.
315 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
316 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
317 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
318 (STDC_HEADERS): Remove obsolete defines.
319 * sysdep.c: Include limits.h unconditionally.
320
321 Assume support for memcmp, memcpy, memmove, memset.
322 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
323 * regex.c (memcmp, memcpy):
324 Remove; we assume C89 now.
325
326 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
327 (__malloc_safe_bcopy): Remove; no longer needed.
328
329 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
330 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
331 well either way, and we prefer signed to unsigned.
332
333 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
334
335 Port to OpenBSD.
336 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
337 and the surrounding thread.
338 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
339 rather than fgets, and retry after EINTR. Otherwise, 'emacs
340 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
341 timer goes off.
342 * s/openbsd.h (BROKEN_SIGIO): Define.
343 * unexelf.c (unexec) [__OpenBSD__]:
344 Don't update the .mdebug section of the Alpha COFF symbol table.
345
346 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
347
348 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
349 (bug#8460).
350
351 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
352
353 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
354 This fixes some race conditions on the permissions of any newly
355 created file.
356
357 * alloc.c (valid_pointer_p): Use pipe, not open.
358 This fixes some permissions issues when debugging.
359
360 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
361 If fchown fails to set both uid and gid, try to set just gid,
362 as that is sometimes allowed. Adjust the file's mode to eliminate
363 setuid or setgid bits that are inappropriate if fchown fails.
364
365 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
366
367 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
368 to compare Lisp_Objects.
369 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
370 global_gnutls_log_level, don't mistake it for a Lisp_Object.
371 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
372
373 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
374
375 * lread.c (read_integer): Unread even EOF character.
376 (read1): Likewise. Properly record start position of symbol.
377
378 * lread.c (read1): Read `#:' as empty uninterned symbol if no
379 symbol character follows.
380
381 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
382
383 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
384 This works around a problem with the previous change to Fcopy_file.
385 Recent glibc declares fchown with __attribute__((warn_unused_result)),
386 and without this change, GCC might complain about discarding
387 fchown's return value.
388
389 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
390
391 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
392
393 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
394
395 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
396
397 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
398
399 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
400 it's used from the C level.
401
402 * process.c: Use the same condition for POLL_FOR_INPUT in both
403 keyboard.c and process.c (bug#1858).
404
405 2011-07-09 Lawrence Mitchell <wence@gmx.li>
406
407 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
408 (Fgnutls_boot): Use it.
409
410 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
411
412 * doc.c (Fsubstitute_command_keys): Revert last change.
413
414 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
415
416 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
417 quotes the next character, and doesn't affect other longer
418 sequences (bug#8935).
419
420 * lread.c (syms_of_lread): Clarify that is isn't only
421 `eval-buffer' and `eval-defun' that's affected by
422 `lexical-binding' (bug#8460).
423
424 2011-07-15 Eli Zaretskii <eliz@gnu.org>
425
426 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
427 bidi redisplay when a line includes both an image and is
428 truncated.
429
430 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
431
432 Fix minor problems found by static checking.
433 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
434 (elsz): Now a signed constant, not a size_t var. We prefer signed
435 types to unsigned, to avoid integer comparison confusion. Without
436 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
437 "cannot optimize loop, the loop counter may overflow", a symptom
438 of the confusion.
439 * indent.c (Fvertical_motion): Mark locals as initialized.
440 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
441
442 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
443
444 * search.c (Fre_search_backward): Mention `case-fold-search' in
445 all the re_search_* functions (bug#8138).
446
447 * keyboard.c (Fopen_dribble_file): Document when the file is
448 closed (bug#8056).
449
450 2011-07-14 Eli Zaretskii <eliz@gnu.org>
451
452 * bidi.c (bidi_dump_cached_states): Fix format of displaying
453 bidi_cache_idx.
454
455 Support bidi reordering of display and overlay strings.
456 * xdisp.c (compute_display_string_pos)
457 (compute_display_string_end): Accept additional argument STRING.
458 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
459 (reseat_to_string): Initialize bidi_it->string.s and
460 bidi_it->string.schars.
461 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
462 NULL (avoids a crash in bidi_paragraph_init). Initialize
463 itb.string.lstring.
464 (init_iterator): Call bidi_init_it only of a valid
465 buffer position was specified. Initialize paragraph_embedding to
466 L2R.
467 (reseat_to_string): Initialize the bidi iterator.
468 (display_string): If we need to ignore text properties of
469 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
470 original value of -1 will not work with bidi.)
471 (compute_display_string_pos): First arg is now struct
472 `text_pos *'; all callers changed. Support display properties on
473 Lisp strings.
474 (compute_display_string_end): Support display properties on Lisp
475 strings.
476 (init_iterator, reseat_1, reseat_to_string): Initialize the
477 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
478 when iterating on a string not from display properties).
479 (compute_display_string_pos, compute_display_string_end): Fix
480 calculation of the object to scan. Fixes an error when using
481 arrow keys.
482 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
483 base_level_stop; instead, set base_level_stop to BEGV. Fixes
484 crashes in vertical-motion.
485 (next_element_from_buffer): Improve commentary for when
486 the iterator is before prev_stop.
487 (init_iterator): Initialize bidi_p from the default value of
488 bidi-display-reordering, not from buffer-local value. Use the
489 buffer-local value only if initializing for buffer iteration.
490 (handle_invisible_prop): Support invisible properties on strings
491 that are being bidi-reordered.
492 (set_iterator_to_next): Support bidi reordering of C strings and
493 Lisp strings.
494 (next_element_from_string): Support bidi reordering of Lisp
495 strings.
496 (handle_stop_backwards): Support Lisp strings as well.
497 (display_string): Support display of R2L glyph rows. Use
498 IT_STRING_CHARPOS when displaying from a Lisp string.
499 (init_iterator): Don't initialize it->bidi_p for strings
500 here.
501 (reseat_to_string): Initialize it->bidi_p for strings here.
502 (next_element_from_string, next_element_from_c_string)
503 (next_element_from_buffer): Add xassert's for correspondence
504 between IT's object being iterated and it->bidi_it.string
505 structure.
506 (face_before_or_after_it_pos): Support bidi iteration.
507 (next_element_from_c_string): Handle the case of the first string
508 character that is not the first one in the visual order.
509 (get_visually_first_element): New function, refactored from common
510 parts of next_element_from_buffer, next_element_from_string, and
511 next_element_from_c_string.
512 (tool_bar_lines_needed, redisplay_tool_bar)
513 (display_menu_bar): Force left-to-right direction. Add a FIXME
514 comment for making that be controlled by a user option.
515 (push_it, pop_it): Save and restore the state of the
516 bidi iterator. Save and restore the bidi_p flag.
517 (pop_it): Iterate out of display property for string iteration as
518 well.
519 (iterate_out_of_display_property): Support iteration over strings.
520 (handle_single_display_spec): Set up it->bidi_it for iteration
521 over a display string, and call bidi_init_it.
522 (handle_single_display_spec, next_overlay_string)
523 (get_overlay_strings_1, push_display_prop): Set up the bidi
524 iterator for displaying display or overlay strings.
525 (forward_to_next_line_start): Don't use the shortcut if
526 bidi-iterating.
527 (back_to_previous_visible_line_start): If handle_display_prop
528 pushed the iterator stack, restore the internal state of the bidi
529 iterator by calling bidi_pop_it same number of times.
530 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
531 and we are bidi-iterating, don't decrement the iterator position;
532 instead, set the first_elt flag in the bidi iterator, to produce
533 the same effect.
534 (reseat_1): Remove redundant setting of string_from_display_prop_p.
535 (push_display_prop): xassert that we are iterating a buffer.
536 (push_it, pop_it): Save and restore paragraph_embedding member.
537 (handle_single_display_spec, next_overlay_string)
538 (get_overlay_strings_1, reseat_1, reseat_to_string)
539 (push_display_prop): Set up the `unibyte' member of bidi_it.string
540 correctly. Don't assume unibyte strings are not bidi-reordered.
541 (compute_display_string_pos)
542 (compute_display_string_end): Fix handling the case of C string.
543 (push_it, pop_it): Save and restore from_disp_prop_p.
544 (handle_single_display_spec, push_display_prop): Set the
545 from_disp_prop_p flag.
546 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
547 (pop_it): Call iterate_out_of_display_property only if we are
548 popping after iteration over a string that came from a display
549 property. Fix a typo in popping stretch info. Add an assertion
550 for verifying that the iterator position is in sync with the bidi
551 iterator.
552 (handle_single_display_spec, get_overlay_strings_1)
553 (push_display_prop): Fix initialization of paragraph direction for
554 string when that of the parent object is not yet determined.
555 (reseat_1): Call bidi_init_it to resync the bidi
556 iterator with IT's position. (Bug#7616)
557 (find_row_edges): If ROW->start.pos gives position
558 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
559 (handle_stop, back_to_previous_visible_line_start, reseat_1):
560 Reset the from_disp_prop_p flag.
561 (SAVE_IT, RESTORE_IT): New macros.
562 (pos_visible_p, face_before_or_after_it_pos)
563 (back_to_previous_visible_line_start)
564 (move_it_in_display_line_to, move_it_in_display_line)
565 (move_it_to, move_it_vertically_backward, move_it_by_lines)
566 (try_scrolling, redisplay_window, display_line): Use them when
567 saving a temporary copy of the iterator and restoring it back.
568 (back_to_previous_visible_line_start, reseat_1)
569 (init_iterator): Empty the bidi cache "stack".
570 (move_it_in_display_line_to): If iterator ended up at
571 EOL, but we never saw any buffer positions smaller than
572 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
573 motion in bidi-reordered lines.
574 (move_it_in_display_line_to): Record prev_method and prev_pos
575 immediately before the call to set_iterator_to_next. Fixes cursor
576 motion in bidi-reordered lines with stretch glyphs and strings
577 displayed in margins. (Bug#8133) (Bug#8867)
578 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
579 TO_CHARPOS.
580 (pos_visible_p): Support positions in bidi-reordered lines. Save
581 and restore bidi cache.
582
583 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
584 (bidi_paragraph_info): Delete unused struct.
585 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
586 (bidi_cache_start): New variable.
587 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
588 to zero.
589 (bidi_cache_fetch_state, bidi_cache_search)
590 (bidi_cache_find_level_change, bidi_cache_iterator_state)
591 (bidi_cache_find, bidi_peek_at_next_level)
592 (bidi_level_of_next_char, bidi_find_other_level_edge)
593 (bidi_move_to_visually_next): Compare cache index with
594 bidi_cache_start rather than with zero.
595 (bidi_fetch_char): Accept new argument STRING; all callers
596 changed. Support iteration over a string. Support strings with
597 display properties. Support unibyte strings. Fix the type of
598 `len' according to what STRING_CHAR_AND_LENGTH expects.
599 (bidi_paragraph_init, bidi_resolve_explicit_1)
600 (bidi_resolve_explicit, bidi_resolve_weak)
601 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
602 iteration over a string.
603 (bidi_set_sor_type, bidi_resolve_explicit_1)
604 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
605 can now be zero (for strings); special values 0 and -1 were
606 changed to -1 and -2, respectively.
607 (bidi_char_at_pos): New function.
608 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
609 Call it instead of FETCH_MULTIBYTE_CHAR.
610 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
611 initialized to valid values.
612 (bidi_init_it): Don't initialize charpos and bytepos with invalid
613 values.
614 (bidi_level_of_next_char): Allow the sentinel "position" to pass
615 the test for valid cached positions. Fix the logic for looking up
616 the sentinel state in the cache. GCPRO the Lisp string we are
617 iterating.
618 (bidi_push_it, bidi_pop_it): New functions.
619 (bidi_initialize): Initialize the bidi cache start stack pointer.
620 (bidi_cache_ensure_space): New function, refactored from part of
621 bidi_cache_iterator_state. Don't assume the required size is just
622 one BIDI_CACHE_CHUNK away.
623 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
624 (bidi_count_bytes, bidi_char_at_pos): New functions.
625 (bidi_cache_search): Don't assume bidi_cache_last_idx is
626 always valid if bidi_cache_idx is valid.
627 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
628 is valid if it's going to be used.
629 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
630 (bidi_cache_fetch_state, bidi_cache_search)
631 (bidi_cache_find_level_change, bidi_cache_ensure_space)
632 (bidi_cache_iterator_state, bidi_cache_find)
633 (bidi_find_other_level_edge, bidi_cache_start_stack): All
634 variables related to cache indices are now EMACS_INT.
635
636 * dispextern.h (struct bidi_string_data): New structure.
637 (struct bidi_it): New member `string'. Make flag members be 1-bit
638 fields, and put them last in the struct.
639 (compute_display_string_pos, compute_display_string_end): Update
640 prototypes.
641 (bidi_push_it, bidi_pop_it): Add prototypes.
642 (struct iterator_stack_entry): New members bidi_p,
643 paragraph_embedding, and from_disp_prop_p.
644 (struct it): Member bidi_p is now a bit field 1 bit wide.
645 (bidi_shelve_cache, bidi_unshelve_cache): Declare
646 prototypes.
647
648 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
649 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
650 and vector-like objects.
651
652 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
653 cache around display iteration.
654
655 * window.c (Fwindow_end, window_scroll_pixel_based)
656 (displayed_window_lines, Frecenter): Save and restore the bidi
657 cache around display iteration.
658
659 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
660
661 * editfns.c (Fdelete_region): Clarify the use of the named
662 parameters (bug#6788).
663
664 2011-07-14 Martin Rudalics <rudalics@gmx.at>
665
666 * indent.c (Fvertical_motion): Set and restore w->pointm when
667 saving and restoring the window's buffer (Bug#9006).
668
669 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
670
671 * editfns.c (Fstring_to_char): Clarify just what is returned
672 (bug#6576). Text by Eli Zaretskii.
673
674 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
675
676 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
677
678 2011-07-13 Eli Zaretskii <eliz@gnu.org>
679
680 * buffer.c (mmap_find): Fix a typo.
681
682 2011-07-13 Johan Bockgård <bojohan@gnu.org>
683
684 Fix execution of x selection hooks.
685 * xselect.c (Qx_lost_selection_functions)
686 (Qx_sent_selection_functions): New vars.
687 (syms_of_xselect): DEFSYM them.
688 (x_handle_selection_request): Pass Qx_sent_selection_functions
689 rather than Vx_sent_selection_functions to Frun_hook_with_args.
690 (x_handle_selection_clear,x_clear_frame_selections):
691 Pass Qx_lost_selection_functions rather than
692 Vx_lost_selection_functions to Frun_hook_with_args.
693
694 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
695
696 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
697 The old code sometimes used this field without initializing it.
698
699 * alloc.c (gc_sweep): Don't read past end of array.
700 In theory, the old code could also have corrupted Emacs internals,
701 though it'd be very unlikely.
702
703 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
704
705 * character.c (Fcharacterp): Don't advertise optional ignored
706 argument. (Bug#4026)
707
708 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
709
710 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
711 key" (bug#4257).
712
713 * window.c (Fset_window_start): Doc fix (bug#4199).
714 (Fset_window_hscroll): Ditto.
715
716 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
717
718 Fix minor new problems caught by GCC 4.6.1.
719 * term.c (init_tty): Remove unused local.
720 * xsettings.c (store_monospaced_changed): Define this function only
721 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
722 not used otherwise.
723
724 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
725
726 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
727
728 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
729
730 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
731 are the mini-buffer and the echo area (bug#3320).
732
733 * term.c (init_tty): Remove support for supdup, c10 and perq
734 terminals, which are no longer supported (bug#1482).
735
736 2011-07-10 Johan Bockgård <bojohan@gnu.org>
737
738 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
739
740 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
741
742 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
743 for non-popups (Bug#3642).
744
745 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
746
747 * alloc.c (reset_malloc_hooks): Protoize.
748 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
749 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
750 * cm.c (losecursor): Likewise.
751 * data.c (fmod): Likewise.
752 * dispnew.c (swap_glyphs_in_rows): Likewise.
753 * emacs.c (memory_warning_signal): Likewise.
754 * floatfns.c (float_error): Likewise.
755 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
756 (otf_open, font_otf_capability, generate_otf_features)
757 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
758 Likewise.
759 * image.c (pbm_read_file): Likewise.
760 * indent.c (string_display_width): Likewise.
761 * intervals.c (check_for_interval, search_for_interval)
762 (inc_interval_count, count_intervals, root_interval)
763 (adjust_intervals_for_insertion, make_new_interval): Likewise.
764 * lread.c (defalias): Likewise.
765 * ralloc.c (r_alloc_check): Likewise.
766 * regex.c (set_image_of_range_1, set_image_of_range)
767 (regex_grow_registers): Likewise.
768 * sysdep.c (strerror): Likewise.
769 * termcap.c (valid_filename_p, tprint, main): Likewise.
770 * tparam.c (main): Likewise.
771 * unexhp9k800.c (run_time_remap, save_data_space)
772 (update_file_ptrs, read_header, write_header, calculate_checksum)
773 (copy_file, copy_rest, display_header): Likewise.
774 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
775 Likewise.
776 * xdisp.c (check_it): Likewise.
777 * xfaces.c (register_color, unregister_color, unregister_colors):
778 Likewise.
779 * xfns.c (print_fontset_result): Likewise.
780 * xrdb.c (member, fatal, main): Likewise.
781
782 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
783
784 Fix minor problems found by static checking (Bug#9031).
785 * chartab.c (char_table_set_range, map_sub_char_table):
786 Remove unused locals.
787 (uniprop_table): Now static.
788 * composite.c (_work_char): Remove unused static var.
789
790 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
791
792 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
793
794 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
795
796 * gtkutil.c (qttip_cb): Remove code without function.
797
798 2011-07-09 Eli Zaretskii <eliz@gnu.org>
799
800 * w32.c (pthread_sigmask): New stub.
801
802 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
803
804 Use pthread_sigmask, not sigprocmask (Bug#9010).
805 sigprocmask is portable only for single-threaded applications, and
806 Emacs can be multi-threaded when it uses GTK.
807 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
808 (LIBES): Use it.
809 * callproc.c (Fcall_process):
810 * process.c (create_process):
811 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
812 Use pthread_sigmask, not sigprocmask.
813
814 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
815
816 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
817 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
818 wrong (Bug#8591).
819
820 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
821
822 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
823 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
824 (xg_hide_tooltip): Fix comment.
825
826 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
827 in registerServicesMenuSendTypes.
828 (validRequestorForSendType): Don't check ns_return_types.
829
830 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
831 ns_return_type.
832
833 2011-07-08 Jason Rumney <jasonr@gnu.org>
834
835 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
836 frame struct members of non-existent frames (Bug#6284).
837
838 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
839
840 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
841 variable firstTime not needed on OSX >= 10.6.
842 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
843 >= 10.5. Use setKnobProportion, setDoubleValue.
844
845 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
846 (MAC_OS_X_VERSION_10_5): Define if not defined.
847 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
848 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
849 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
850
851 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
852 cString and lossyCString on OSX >= 10.4
853
854 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
855 sizeToFit on OSX >= 10.2.
856
857 * nsimage.m (allocInitFromFile): Don't use deprecated method
858 bestRepresentationForDevice on OSX >= 10.6.
859
860 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
861 to avoid warning.
862
863 * emacs.c: Declare unexec_init_emacs_zone.
864
865 * nsgui.h: Fix compiler warning about gnulib redefining verify.
866
867 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
868
869 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
870 on svcsMenu (Bug#8842).
871
872 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
873 ns_return_types.
874 (Fns_list_services): Just return Qnil on 10.6, code not working there.
875
876 * nsterm.m (QUTF8_STRING): Declare.
877 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
878 (validRequestorForSendType): Return type is (id).
879 Change indexOfObjectIdenticalTo to indexOfObject.
880 Check if we have local selection before returning self (Bug#8842).
881 (writeSelectionToPasteboard): Put local selection into paste board
882 if we have a local selection (Bug#8842).
883 (syms_of_nsterm): DEFSYM QUTF8_STRING.
884
885 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
886 (ns_get_local_selection): Declare.
887
888 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
889
890 * keymap.c (describe_map_tree): Don't insert a double newline at
891 the end of the buffer (bug#1169) and return whether we inserted
892 something.
893
894 * callint.c (Fcall_interactively): Change "reading args" to
895 "providing args" to try to clarify what it does (bug#1010).
896
897 2011-07-07 Kenichi Handa <handa@m17n.org>
898
899 * composite.c (composition_compute_stop_pos): Ignore a static
900 composition starting before CHARPOS (Bug#8915).
901
902 * xdisp.c (handle_composition_prop): Likewise.
903
904 2011-07-07 Eli Zaretskii <eliz@gnu.org>
905
906 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
907 (Bug#9015)
908
909 2011-07-07 Kenichi Handa <handa@m17n.org>
910
911 * character.h (unicode_category_t): New enum type.
912
913 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
914 (Qchar_code_property_table): New variable.
915 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
916 (UNIPROP_COMPRESSED_FORM_P): New macros.
917 (char_table_ascii): Uncompress the compressed values.
918 (sub_char_table_ref): New arg is_uniprop. Callers changed.
919 Uncompress the compressed values.
920 (sub_char_table_ref_and_range): Likewise.
921 (char_table_ref_and_range): Uncompress the compressed values.
922 (sub_char_table_set): New arg is_uniprop. Callers changed.
923 Uncompress the compressed values.
924 (sub_char_table_set_range): Args changed. Callers changed.
925 (char_table_set_range): Adjuted for the above change.
926 (map_sub_char_table): Delete args default_val and parent. Add arg
927 top. Give decoded values to a Lisp function.
928 (map_char_table): Adjusted for the above change. Give decoded
929 values to a Lisp function. Gcpro more variables.
930 (uniprop_table_uncompress)
931 (uniprop_decode_value_run_length): New functions.
932 (uniprop_decoder, uniprop_decoder_count): New variables.
933 (uniprop_get_decoder, uniprop_encode_value_character)
934 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
935 New functions.
936 (uniprop_encoder, uniprop_encoder_count): New variables.
937 (uniprop_get_encoder, uniprop_table)
938 (Funicode_property_table_internal, Fget_unicode_property_internal)
939 (Fput_unicode_property_internal): New functions.
940 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
941 Sunicode_property_table_internal, Sget_unicode_property_internal,
942 and Sput_unicode_property_internal. Defvar_lisp
943 char-code-property-alist.
944
945 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
946 Vunicode_category_table.
947
948 * font.c (font_range): Adjusted for the change of
949 Vunicode_category_table.
950
951 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
952
953 * m/iris4d.h: Remove file, move contents ...
954 * s/irix6-5.h: ... here.
955
956 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
957
958 Remove unportable assumption about struct layout (Bug#8884).
959 * alloc.c (mark_buffer):
960 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
961 (clone_per_buffer_values): Don't assume that
962 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
963 This isn't true in general, and it's particularly not true
964 if Emacs is configured with --with-wide-int.
965 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
966 New macros, used in the buffer.c change.
967
968 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
969
970 * xsettings.c: Use both GConf and GSettings if both are available.
971 (store_config_changed_event): Add comment.
972 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
973 (store_tool_bar_style_changed): New functions.
974 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
975 (struct xsettings): Move font inside HAVE_XFT.
976 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
977 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
978 Move inside HAVE_XFT.
979 (something_changed_gsettingsCB): Renamed from something_changedCB.
980 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
981 also.
982 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
983 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
984 (something_changed_gconfCB): Renamed from something_changedCB.
985 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
986 (parse_settings): Move check for font inside HAVE_XFT.
987 (read_settings, apply_xft_settings): Add comment.
988 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
989 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
990 call store_font_name_changed.
991 (xft_settings_event): Add comment.
992 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
993 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
994 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
995 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
996 (xsettings_initialize): Call init_gsettings last.
997 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
998 comment.
999
1000 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1001
1002 Random fixes. E.g., (random) never returned negative values.
1003 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1004 subseconds part to the entropy, as that's a bit more random.
1005 Prefer signed to unsigned, since the signedness doesn't matter and
1006 in general we prefer signed. When given a limit, use a
1007 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1008 latter isn't right if USE_2_TAGS_FOR_INTS.
1009 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1010 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1011
1012 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1013
1014 * textprop.c (text_property_stickiness):
1015 Obey Vtext_property_default_nonsticky.
1016 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1017 * w32fns.c (syms_of_w32fns):
1018 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1019
1020 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1021
1022 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1023 This is more efficient than Ffile_directory_p and avoids a minor race.
1024
1025 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1026
1027 * buffer.c (Foverlay_put): Say what the return value is
1028 (bug#7835).
1029
1030 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1031 is a directory before asking whether to use the file name
1032 (bug#7564).
1033 (barf_or_query_if_file_exists): Make the "File is a directory"
1034 error be more correct.
1035
1036 * fns.c (Frequire): Remove the mention of the .gz files, since
1037 that's installation-specific, but keep the mention of
1038 `get-load-suffixes'.
1039
1040 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1041
1042 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1043 Report string overflow if the output is too long.
1044
1045 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1046
1047 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1048 (syms_of_gnutls): Remove duplicate DEFSYM for
1049 Qgnutls_bootprop_verify_hostname_error, an error for
1050 Qgnutls_bootprop_verify_error (which is no longer used).
1051
1052 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1053 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1054 Also (re)move comments that are misplaced or no longer relevant.
1055
1056 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1057
1058 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1059
1060 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1061
1062 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1063 and background color parameters if they have been changed.
1064
1065 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1066
1067 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1068
1069 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1070
1071 * xsettings.c (SYSTEM_FONT): Define only when used.
1072 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1073
1074 * keymap.c (access_keymap_1): Now static.
1075
1076 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1077
1078 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1079 leave any prefix arg for the up event (Bug#1586).
1080
1081 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1082
1083 * lread.c (syms_of_lread): Mention single symbols defined by
1084 `defvar' or `defconst' (bug#7154).
1085
1086 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1087 (Frequire): Mention get-load-suffixes.
1088
1089 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1090
1091 * window.h (window): Remove clone_number slot.
1092 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1093 Remove.
1094 (make_parent_window, make_window, saved_window)
1095 (Fset_window_configuration, save_window_save): Don't deal with
1096 clone numbers.
1097 * buffer.c (Qclone_number): Remove declaration.
1098 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1099
1100 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1101
1102 Add multiple inheritance to keymaps.
1103 * keymap.c (Fmake_composed_keymap): New function.
1104 (Fset_keymap_parent): Simplify.
1105 (fix_submap_inheritance): Remove.
1106 (access_keymap_1): New function extracted from access_keymap to handle
1107 embedded parents and handle lists of maps.
1108 (access_keymap): Use it.
1109 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1110 (Fcopy_keymap): Handle embedded parents.
1111 (Fcommand_remapping, define_as_prefix): Simplify.
1112 (Fkey_binding): Simplify.
1113 (syms_of_keymap): Move minibuffer-local-completion-map,
1114 minibuffer-local-filename-completion-map,
1115 minibuffer-local-must-match-map, and
1116 minibuffer-local-filename-must-match-map to Elisp.
1117 (syms_of_keymap): Defsubr make-composed-keymap.
1118 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1119 (parse_menu_item): Trivial simplification.
1120
1121 2011-07-01 Glenn Morris <rgm@gnu.org>
1122
1123 * Makefile.in (SETTINGS_LIBS): Fix typo.
1124
1125 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1126
1127 * coding.c (Fencode_coding_string): Record the last coding system
1128 used, as the function doc string says (bug#8738).
1129
1130 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1131
1132 * xsettings.c (store_monospaced_changed): Take new font as arg and
1133 check for change against current_mono_font.
1134 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1135 (emacs_settings_constructor, emacs_settings_get_property)
1136 (emacs_settings_set_property, emacs_settings_class_init)
1137 (emacs_settings_init, gsettings_obj): Remove.
1138 (something_changedCB): New function for HAVE_GSETTINGS.
1139 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1140 with value as argument.
1141 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1142 g_settings_new (Bug#8967). Do not create gsettings_obj.
1143 Remove calls to g_settings_bind. Connect something_changedCB to
1144 "changed".
1145
1146 * xgselect.c: Add defined (HAVE_GSETTINGS).
1147 (xgselect_initialize): Ditto.
1148
1149 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1150 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1151 xg_select.
1152
1153 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1154
1155 * eval.c (struct backtrace): Simplify and port the data structure.
1156 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1157 signed bit field, as this assumption is not portable and it makes
1158 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1159 "char debug_on_exit : 1" as this is not portable either; instead,
1160 use the portable "unsigned int debug_on_exit : 1". Remove unused
1161 member evalargs. Remove obsolete comments about cc bombing out.
1162
1163 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1164
1165 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1166 Let HAVE_GSETTINGS override HAVE_GCONF.
1167 (store_monospaced_changed): New function.
1168 (EMACS_SETTINGS): A new type derived from GObject to handle
1169 GSettings notifications.
1170 (emacs_settings_constructor, emacs_settings_get_property)
1171 (emacs_settings_set_property, emacs_settings_class_init):
1172 New functions.
1173 (gsettings_client, gsettings_obj): New variables.
1174 (GSETTINGS_SCHEMA): New define.
1175 (something_changedCB): Call store_monospaced_changed.
1176 (init_gsettings): New function.
1177 (xsettings_initialize): Call init_gsettings.
1178 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1179 to NULL.
1180
1181 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1182 GCONF_CFLAGS/LIBS.
1183
1184 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1185
1186 * window.c (resize_root_window, grow_mini_window)
1187 (shrink_mini_window): Rename Qresize_root_window to
1188 Qwindow_resize_root_window and Qresize_root_window_vertically to
1189 Qwindow_resize_root_window_vertically.
1190
1191 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1192
1193 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1194
1195 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1196
1197 * makefile.w32-in: Redesign dependencies so they reflect more
1198 clearly which files are directly included by each source file,
1199 and not through other includes.
1200
1201 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1202
1203 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1204 (sort_overlays, overlay_strings): When an overlay's clone number
1205 matches the window's clone number process the overlay even if
1206 the overlay's window property doesn't match the current window.
1207
1208 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1209 (Fwindow_hchild): Rename to Fwindow_left_child.
1210 (Fwindow_next): Rename to Fwindow_next_sibling.
1211 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1212 (resize_window_check): Rename to window_resize_check.
1213 (resize_window_apply): Rename to window_resize_apply.
1214 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1215 (Fdelete_other_windows_internal, resize_frame_windows)
1216 (Fsplit_window_internal, Fdelete_window_internal)
1217 (grow_mini_window, shrink_mini_window)
1218 (Fresize_mini_window_internal): Fix callers accordingly.
1219
1220 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1221
1222 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1223 (emacs_fixed_set_min_size): Remove.
1224 (emacs_fixed_new): Take frame as argument.
1225
1226 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1227 (_EmacsFixedPrivate): Remove minwidth/height.
1228 Add struct frame *f.
1229 (emacs_fixed_init): Initialize priv->f.
1230 (get_parent_class, emacs_fixed_set_min_size): Remove.
1231 (emacs_fixed_new): Set priv->f to argument.
1232 (emacs_fixed_get_preferred_width)
1233 (emacs_fixed_get_preferred_height): Use min_width/height from
1234 frames size_hint to set minimum and natural (Bug#8919).
1235 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1236 and use min_width/height from frames size_hint to set
1237 min_width/height (Bug#8919).
1238
1239 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1240 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1241 Fix indentation.
1242
1243 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1244
1245 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1246 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1247 called at ZV.
1248
1249 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1250
1251 * process.c (wait_reading_process_output): Bypass select if
1252 waiting for a cell while ignoring keyboard input, and input is
1253 pending. Suggested by Jan Djärv (Bug#8869).
1254
1255 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1256
1257 Use gnulib's dup2 module instead of rolling our own.
1258 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1259
1260 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1261
1262 * dispnew.c (scrolling_window): Before scrolling, turn off a
1263 mouse-highlight in the window being scrolled.
1264
1265 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1266
1267 Move DEFSYM to lisp.h and use everywhere.
1268
1269 * character.h (DEFSYM): Move declaration...
1270 * lisp.h (DEFSYM): ...here.
1271
1272 * gnutls.c:
1273 * minibuf.c:
1274 * w32menu.c:
1275 * w32proc.c:
1276 * w32select.c: Don't include character.h.
1277
1278 * alloc.c (syms_of_alloc):
1279 * buffer.c (syms_of_buffer):
1280 * bytecode.c (syms_of_bytecode):
1281 * callint.c (syms_of_callint):
1282 * casefiddle.c (syms_of_casefiddle):
1283 * casetab.c (init_casetab_once):
1284 * category.c (init_category_once, syms_of_category):
1285 * ccl.c (syms_of_ccl):
1286 * cmds.c (syms_of_cmds):
1287 * composite.c (syms_of_composite):
1288 * dbusbind.c (syms_of_dbusbind):
1289 * dired.c (syms_of_dired):
1290 * dispnew.c (syms_of_display):
1291 * doc.c (syms_of_doc):
1292 * editfns.c (syms_of_editfns):
1293 * emacs.c (syms_of_emacs):
1294 * eval.c (syms_of_eval):
1295 * fileio.c (syms_of_fileio):
1296 * fns.c (syms_of_fns):
1297 * frame.c (syms_of_frame):
1298 * fringe.c (syms_of_fringe):
1299 * insdel.c (syms_of_insdel):
1300 * keymap.c (syms_of_keymap):
1301 * lread.c (init_obarray, syms_of_lread):
1302 * macros.c (syms_of_macros):
1303 * msdos.c (syms_of_msdos):
1304 * print.c (syms_of_print):
1305 * process.c (syms_of_process):
1306 * search.c (syms_of_search):
1307 * sound.c (syms_of_sound):
1308 * syntax.c (init_syntax_once, syms_of_syntax):
1309 * terminal.c (syms_of_terminal):
1310 * textprop.c (syms_of_textprop):
1311 * undo.c (syms_of_undo):
1312 * w32.c (globals_of_w32):
1313 * window.c (syms_of_window):
1314 * xdisp.c (syms_of_xdisp):
1315 * xfaces.c (syms_of_xfaces):
1316 * xfns.c (syms_of_xfns):
1317 * xmenu.c (syms_of_xmenu):
1318 * xsettings.c (syms_of_xsettings):
1319 * xterm.c (syms_of_xterm): Use DEFSYM.
1320
1321 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1322
1323 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1324
1325 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1326
1327 Integer and buffer overflow fixes (Bug#8873).
1328
1329 * print.c (printchar, strout): Check for string overflow.
1330 (PRINTPREPARE, printchar, strout):
1331 Don't set size unless allocation succeeds.
1332
1333 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1334 for sizes. Check for string overflow more accurately.
1335 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1336
1337 * macros.c: Integer and buffer overflow fixes.
1338 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1339 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1340 Use ptrdiff_t, not int, for sizes.
1341 Don't increment bufsize until after realloc succeeds.
1342 Check for size-calculation overflow.
1343 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1344
1345 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1346
1347 * lread.c: Integer overflow fixes.
1348 (read_integer): Radix is now EMACS_INT, not int,
1349 to improve quality of diagnostics for out-of-range radices.
1350 Calculate buffer size correctly for out-of-range radices.
1351 (read1): Check for integer overflow in radices, and in
1352 read-circle numbers.
1353 (read_escape): Avoid int overflow.
1354 (Fload, openp, read_buffer_size, read1)
1355 (substitute_object_recurse, read_vector, read_list, map_obarray):
1356 Use ptrdiff_t, not int, for sizes.
1357 (read1): Use EMACS_INT, not int, for sizes.
1358 Check for size overflow.
1359
1360 * image.c (cache_image): Check for size arithmetic overflow.
1361
1362 * lread.c: Integer overflow issues.
1363 (saved_doc_string_size, saved_doc_string_length)
1364 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1365 Now ptrdiff_t, not int.
1366 (read1): Don't assume doc string length fits in int. Check for
1367 out-of-range doc string lengths.
1368 (read_list): Don't assume file position fits in int.
1369 (read_escape): Check for hex character overflow.
1370
1371 2011-06-22 Leo Liu <sdl.web@gmail.com>
1372
1373 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1374 Move to minibuffer.el.
1375
1376 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1377
1378 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1379 The following patches are for when GLYPH_DEBUG && !XASSERT.
1380 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1381 * dispnew.c (flush_stdout):
1382 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1383 Mark as externally visible.
1384 * dispnew.c (check_window_matrix_pointers): Now static.
1385 * dispnew.c (window_to_frame_vpos):
1386 * xfns.c (unwind_create_frame):
1387 * xterm.c (x_check_font): Remove unused local.
1388 * scroll.c (CHECK_BOUNDS):
1389 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1390 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1391 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1392 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1393 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1394 Now static.
1395 (debug_method_add): Use va_list and vsprintf rather than relying
1396 on undefined behavior with wrong number of arguments.
1397 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1398 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1399 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1400 since we're not interested in debugging glyphs with old libraries.
1401 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1402 GCC 4.6.0's static checking.
1403
1404 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1405
1406 Integer overflow and signedness fixes (Bug#8873).
1407 A few related buffer overrun fixes, too.
1408
1409 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1410
1411 * dispextern.h (struct face.stipple):
1412 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1413 (x_bitmap_mask, x_allocate_bitmap_record)
1414 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1415 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1416 (x_create_bitmap_from_xpm_data):
1417 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1418 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1419 (.bitmaps_last):
1420 * xfaces.c (load_pixmap):
1421 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1422 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1423 (.bitmaps_last, struct x_output.icon_bitmap):
1424 Use ptrdiff_t, not int, for bitmap indexes.
1425 (x_allocate_bitmap_record): Check for size overflow.
1426 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1427
1428 Use ptrdiff_t, not int, for overlay counts.
1429 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1430 * editfns.c (overlays_around, get_pos_property):
1431 * textprop.c (get_char_property_and_overlay):
1432 * xdisp.c (next_overlay_change, note_mouse_highlight):
1433 * xfaces.c (face_at_buffer_position):
1434 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1435 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1436 (Fnext_overlay_change, Fprevious_overlay_change)
1437 (mouse_face_overlay_overlaps, Foverlays_in):
1438 Use ptrdiff_t, not int, for sizes.
1439 (overlays_at, overlays_in): Check for size-calculation overflow.
1440
1441 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1442
1443 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1444 (x_session_initialize): Do not assume string length fits in int.
1445
1446 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1447 This is unlikely, but can occur if DPI is outlandish.
1448
1449 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1450 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1451
1452 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1453 * xrdb.c (magic_file_p, search_magic_path):
1454 Omit last arg SUFFIX; it was always 0. All callers changed.
1455 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1456
1457 * xfont.c (xfont_match): Avoid need for strlen.
1458
1459 * xfns.c: Don't assume strlen fits in int.
1460 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1461
1462 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1463 not unsigned long, as we prefer signed integers. All callers changed.
1464 Detect integer overflow in repeat count.
1465 (message_dolog): Don't assume print length fits in 39 bytes.
1466 (display_mode_element): Don't assume strlen fits in int.
1467
1468 * termcap.c: Don't assume sizes fit in int and never overflow.
1469 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1470 (gobble_line): Check for size-calculation overflow.
1471
1472 * minibuf.c (Fread_buffer):
1473 * lread.c (intern, intern_c_string):
1474 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1475 Don't assume string length fits in int.
1476
1477 * keyboard.c (parse_tool_bar_item):
1478 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1479
1480 * font.c: Don't assume string length fits in int.
1481 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1482 Use ptrdiff_t, not int.
1483 (font_intern_prop): Don't assume string length fits in int.
1484 Don't assume integer property fits in fixnum.
1485 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1486
1487 * filelock.c: Fix some buffer overrun and integer overflow issues.
1488 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1489 Reformulate so as not to need the command string.
1490 Invoke gzip -cd rather than gunzip, as it's more portable.
1491 (lock_info_type, lock_file_1, lock_file):
1492 Don't assume pid_t and time_t fit in unsigned long.
1493 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1494 (current_lock_owner): Prefer signed type for sizes.
1495 Use memcpy, not strncpy, where memcpy is what is really wanted.
1496 Don't assume (via atoi) that time_t and pid_t fit in int.
1497 Check for time_t and/or pid_t out of range, e.g., via a network share.
1498 Don't alloca where an auto var works fine.
1499
1500 * fileio.c: Fix some integer overflow issues.
1501 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1502 Don't assume string length fits in int.
1503 (directory_file_name): Don't assume string length fits in long.
1504 (make_temp_name): Don't assume pid fits in int, or that its print
1505 length is less than 20.
1506
1507 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1508
1509 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1510
1511 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1512
1513 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1514 We prefer signed integers, even for size calculations.
1515
1516 * emacs.c: Don't assume string length fits in 'int'.
1517 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1518 (main): Don't invoke strlen when not needed.
1519
1520 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1521 (XD_DEBUG_MESSAGE): Don't waste a byte.
1522
1523 * callproc.c (getenv_internal_1, getenv_internal)
1524 (Fgetenv_internal):
1525 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1526
1527 * lread.c (invalid_syntax): Omit length argument.
1528 All uses changed. This doesn't fix a bug, but it simplifies the
1529 code away from its former Hollerith-constant appearance, and it's
1530 one less 'int' to worry about when looking at integer-overflow issues.
1531 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1532
1533 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1534 This didn't break anything, but it didn't help either.
1535 It's confusing to put a bogus integer in a place where the actual
1536 value does not matter.
1537 (LIST_END_P): Remove unused macro and its bogus comment.
1538 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1539
1540 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1541 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1542 implementation.
1543 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1544 We prefer signed types, and the value cannot exceed the EMACS_INT
1545 range anyway (because otherwise the length would not be representable).
1546 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1547 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1548 This avoids a GCC warning when WIDE_EMACS_INT.
1549
1550 * indent.c (sane_tab_width): New function.
1551 (current_column, scan_for_column, Findent_to, position_indentation)
1552 (compute_motion): Use it. This is just for clarity.
1553 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1554
1555 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1556
1557 * lisp.h (lint_assume): New macro.
1558 * composite.c (composition_gstring_put_cache):
1559 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1560
1561 * editfns.c, insdel.c:
1562 Omit unnecessary forward decls, to simplify future changes.
1563
1564 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1565
1566 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1567
1568 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1569 Use much-faster test for byte-length change.
1570 Don't assume string byte-length fits in 'int'.
1571 Check that character arg fits in 'int'.
1572 (mapcar1): Declare byte as byte, for clarity.
1573
1574 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1575
1576 * fns.c (concat): Catch string overflow earlier.
1577 Do not rely on integer wraparound.
1578
1579 * dispextern.h (struct it.overlay_strings_charpos)
1580 (struct it.selective): Now EMACS_INT, not int.
1581 * xdisp.c (forward_to_next_line_start)
1582 (back_to_previous_visible_line_start)
1583 (reseat_at_next_visible_line_start, next_element_from_buffer):
1584 Don't arbitrarily truncate the value of 'selective' to int.
1585
1586 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1587
1588 * composite.c: Don't truncate sizes to 'int'.
1589 (composition_gstring_p, composition_reseat_it)
1590 (composition_adjust_point): Use EMACS_INT, not int.
1591 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1592 not EMACS_UINT, for indexes.
1593
1594 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1595
1596 * buffer.c: Include <verify.h>.
1597 (struct sortvec.priority, struct sortstr.priority):
1598 Now EMACS_INT, not int.
1599 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1600 (struct sortstr.size, record_overlay_string)
1601 (struct sortstrlist.size, struct sortlist.used):
1602 Don't truncate size to int.
1603 (record_overlay_string): Check for size-calculation overflow.
1604 (init_buffer_once): Check at compile-time, not run-time.
1605
1606 2011-06-22 Jim Meyering <meyering@redhat.com>
1607
1608 Don't leak an XBM-image-sized buffer
1609 * image.c (xbm_load): Free the image buffer after using it.
1610
1611 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1612
1613 Port to Sun C.
1614 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1615 that Sun C diagnosed.
1616 * fns.c (secure_hash): Fix pointer signedness issue.
1617 * intervals.c (static_offset_intervals): New function.
1618 (offset_intervals): Use it.
1619
1620 2011-06-21 Leo Liu <sdl.web@gmail.com>
1621
1622 * deps.mk (fns.o):
1623 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1624 sha512.h.
1625
1626 * fns.c (secure_hash): Rename from crypto_hash_function and change
1627 the first arg to accept symbols.
1628 (Fsecure_hash): New primitive.
1629 (syms_of_fns): New symbols.
1630
1631 2011-06-20 Deniz Dogan <deniz@dogan.se>
1632
1633 * process.c (Fset_process_buffer): Clarify return value in
1634 docstring.
1635
1636 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1637
1638 * dispnew.c (add_window_display_history): Use BVAR.
1639
1640 * xdisp.c (debug_method_add): Use BVAR.
1641 (check_window_end, dump_glyph_matrix, dump_glyph)
1642 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1643
1644 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1645 Likewise.
1646
1647 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1648 check till after the cache is created in init_frame_faces.
1649
1650 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1651
1652 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1653
1654 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1655
1656 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1657 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1658 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1659
1660 Improve buffer-overflow checking (Bug#8873).
1661 * fileio.c (Finsert_file_contents):
1662 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1663 Remove the old (too-loose) buffer overflow checks.
1664 They weren't needed, since make_gap checks for buffer overflow.
1665 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1666 The old code merely checked for Emacs fixnum overflow, and relied
1667 on undefined (wraparound) behavior. The new code avoids undefined
1668 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1669
1670 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1671 Tune. Don't use wider integers than needed. Don't use alloca.
1672 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1673
1674 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1675
1676 * insdel.c, lisp.h (buffer_overflow): New function.
1677 (insert_from_buffer_1, replace_range, replace_range_2):
1678 * insdel.c (make_gap_larger):
1679 * editfns.c (Finsert_char):
1680 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1681
1682 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1683
1684 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1685
1686 Integer overflow and signedness fixes (Bug#8873).
1687
1688 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1689 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1690
1691 * fileio.c: Don't assume EMACS_INT fits in off_t.
1692 (emacs_lseek): New static function.
1693 (Finsert_file_contents, Fwrite_region): Use it.
1694 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1695
1696 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1697
1698 * fns.c: Don't overflow int when computing a list length.
1699 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1700 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1701 truncation on 64-bit hosts. Check for QUIT every
1702 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1703 faster and is responsive enough.
1704 (Flength): Report an error instead of overflowing an integer.
1705 (Fsafe_length): Return a float if the value is not representable
1706 as a fixnum. This shouldn't happen except in contrived situations.
1707 (Fnthcdr, Fsort): Don't assume list length fits in int.
1708 (Fcopy_sequence): Don't assume vector length fits in int.
1709
1710 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1711 (header_size, word_size): New constants.
1712 (allocate_vectorlike): Don't check size overflow here.
1713 (allocate_vector): Check it here instead, since this is the only
1714 caller of allocate_vectorlike that could cause overflow.
1715 Check that the new vector's length is representable as a fixnum.
1716
1717 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1718 The previous code was bogus. For example, next_almost_prime (32)
1719 returned 39, which is undesirable as it is a multiple of 3; and
1720 next_almost_prime (24) returned 25, which is a multiple of 5 so
1721 why was the code bothering to check for multiples of 7?
1722
1723 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1724
1725 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1726
1727 Variadic C functions now count arguments with ptrdiff_t.
1728 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1729 Back then I didn't know that the Emacs coding style prefers signed int.
1730 Also, in the meantime I found a few more instances where arguments
1731 were being counted with int, which may truncate counts on 64-bit
1732 machines, or EMACS_INT, which may be unnecessarily wide.
1733 * lisp.h (struct Lisp_Subr.function.aMANY)
1734 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1735 Arg counts are now ptrdiff_t, not size_t.
1736 All variadic functions and their callers changed accordingly.
1737 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1738 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1739 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1740 * callint.c (Fcall_interactively): Check arg count for overflow,
1741 to avoid potential buffer overrun. Use signed char, not 'int',
1742 for 'varies' array, so that we needn't bother to check its size
1743 calculation for overflow.
1744 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1745 * eval.c (apply_lambda):
1746 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1747 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1748 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1749
1750 * callint.c (Fcall_interactively): Don't use index var as event count.
1751
1752 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1753 * mem-limits.h (SIZE): Remove; no longer used.
1754
1755 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1756
1757 Remove unnecessary casts.
1758 * xterm.c (x_term_init):
1759 * xfns.c (x_set_border_pixel):
1760 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1761 These aren't needed now that we assume ANSI C.
1762
1763 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1764 It's more likely to cause problems (due to unsigned overflow)
1765 than to cure them.
1766
1767 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1768
1769 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1770
1771 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1772
1773 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1774
1775 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1776
1777 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1778
1779 GLYPH_CODE_FACE returns EMACS_INT, not int.
1780 * dispextern.h (merge_faces):
1781 * xfaces.c (merge_faces):
1782 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1783 Don't assume EMACS_INT fits in int.
1784
1785 * character.h (CHAR_VALID_P): Remove unused parameter.
1786 * fontset.c, lisp.h, xdisp.c: All uses changed.
1787
1788 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1789
1790 * fns.c (concat): Minor tuning based on overflow analysis.
1791 This doesn't fix any bugs. Use int to hold character, instead
1792 of constantly refetching from Emacs object. Use XFASTINT, not
1793 XINT, for value known to be a character. Don't bother comparing
1794 a single byte to 0400, as it's always less.
1795
1796 * floatfns.c (Fexpt):
1797 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1798
1799 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1800 for characters.
1801
1802 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1803
1804 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1805 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1806 incorrectly succeed when S was a string, because 4294967386 was
1807 truncated before it was used.
1808
1809 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1810 Otherwise, an out-of-range integer could cause undefined behavior
1811 on a 64-bit host.
1812
1813 * composite.c: Use int, not EMACS_INT, for characters.
1814 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1815 EMACS_INT, for values that are known to be in character range.
1816 This doesn't fix any bugs but is the usual style inside Emacs and
1817 may generate better code on 32-bit machines.
1818
1819 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1820 This is for reasons similar to the recent CHAR_STRING fix.
1821 * charset.c (Fencode_char): Check that character arg is actually
1822 a character. Pass an int to ENCODE_CHAR.
1823 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1824 wider than 'int', as a compile-time check to prevent future regressions
1825 in this area.
1826
1827 * character.c (char_string): Remove unnecessary casts.
1828
1829 Make sure a 64-bit char is never passed to CHAR_STRING.
1830 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1831 by silently ignoring the top 32 bits, allowing some values
1832 that were far too large to be valid characters.
1833 * character.h: Include <verify.h>.
1834 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1835 arguments are no wider than unsigned, as a compile-time check
1836 to prevent future regressions in this area.
1837 * data.c (Faset):
1838 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1839 (Fsubst_char_in_region):
1840 * fns.c (concat):
1841 * xdisp.c (decode_mode_spec_coding):
1842 Adjust to CHAR_STRING's new requirement.
1843 * editfns.c (Finsert_char, Fsubst_char_in_region):
1844 * fns.c (concat): Check that character args are actually
1845 characters. Without this test, these functions did the wrong
1846 thing with wildly out-of-range values on 64-bit hosts.
1847
1848 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1849 These casts should not be needed on 32-bit hosts, either.
1850 * keyboard.c (read_char):
1851 * lread.c (Fload): Remove casts to unsigned.
1852
1853 * lisp.h (UNSIGNED_CMP): New macro.
1854 This fixes comparison bugs on 64-bit hosts.
1855 (ASCII_CHAR_P): Use it.
1856 * casefiddle.c (casify_object):
1857 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1858 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1859 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1860 * dispextern.h (FACE_FROM_ID):
1861 * keyboard.c (read_char): Use UNSIGNED_CMP.
1862
1863 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1864 not to EMACS_INT, to avoid GCC warning.
1865
1866 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1867
1868 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1869 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1870 isn't needed on 32-bit machines.
1871
1872 * buffer.c (Fgenerate_new_buffer_name):
1873 Use EMACS_INT for count, not int.
1874 (advance_to_char_boundary): Return EMACS_INT, not int.
1875
1876 * data.c (Qcompiled_function): Now static.
1877
1878 * window.c (window_body_lines): Now static.
1879
1880 * image.c (gif_load): Rename local to avoid shadowing.
1881
1882 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1883 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1884 * alloc.c (make_save_value): Integer argument is now of type
1885 ptrdiff_t, not int.
1886 (mark_object): Use ptrdiff_t, not int.
1887 * lisp.h (pD): New macro.
1888 * print.c (print_object): Use it.
1889
1890 * alloc.c: Use EMACS_INT, not int, to count objects.
1891 (total_conses, total_markers, total_symbols, total_vector_size)
1892 (total_free_conses, total_free_markers, total_free_symbols)
1893 (total_free_floats, total_floats, total_free_intervals)
1894 (total_intervals, total_strings, total_free_strings):
1895 Now EMACS_INT, not int. All uses changed.
1896 (Fgarbage_collect): Compute overall total using a double, so that
1897 integer overflow is less likely to be a problem. Check for overflow
1898 when converting back to an integer.
1899 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1900 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1901 These were 'int' variables that could overflow on 64-bit hosts;
1902 they were never used, so remove them instead of repairing them.
1903 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1904 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1905 Previously, this ceilinged at INT_MAX, but that doesn't work on
1906 64-bit machines.
1907 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1908
1909 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1910 (allocate_vectorlike): Check for ptrdiff_t overflow.
1911 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1912 when a (possibly-narrower) signed value would do just as well.
1913 We prefer using signed arithmetic, to avoid comparison confusion.
1914
1915 * alloc.c: Catch some string size overflows that we were missing.
1916 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1917 for convenience in STRING_BYTES_MAX.
1918 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1919 The definition here is exact; the one in lisp.h was approximate.
1920 (allocate_string_data): Check for string overflow. This catches
1921 some instances we weren't catching before. Also, it catches
1922 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1923 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1924 and ptrdiff_t and EMACS_INT are both 64 bits.
1925
1926 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1927 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1928 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1929
1930 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1931
1932 * alloc.c (Fmake_string): Check for out-of-range init.
1933
1934 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1935
1936 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1937
1938 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1939
1940 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1941 xg_get_default_scrollbar_width.
1942
1943 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1944 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1945 (style_changed_cb): Call update_theme_scrollbar_width and call
1946 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1947 all frames (Bug#8505).
1948 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1949 Call gtk_window_set_resizable if HAVE_GTK3.
1950 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1951 and height if HAVE_GTK3 (Bug#8505).
1952 (scroll_bar_width_for_theme): New variable.
1953 (update_theme_scrollbar_width): New function.
1954 (xg_get_default_scrollbar_width): Move code to
1955 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1956 (xg_initialize): Call update_theme_scrollbar_width.
1957
1958 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1959
1960 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1961
1962 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1963
1964 * frame.c (make_frame): Call other_buffer_safely instead of
1965 other_buffer.
1966
1967 * window.c (temp_output_buffer_show): Call display_buffer with
1968 second argument Vtemp_buffer_show_specifiers and reset latter
1969 immediately after the call.
1970 (Vtemp_buffer_show_specifiers): New variable.
1971 (auto_window_vscroll_p, next_screen_context_lines)
1972 (Vscroll_preserve_screen_position): Remove leading asterisks from
1973 doc-strings.
1974
1975 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1976
1977 Fix minor problems found by GCC 4.6.0 static checking.
1978 * buffer.c (Qclone_number): Remove for now, as it's unused.
1979 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1980 (record_buffer): Remove unused local.
1981 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1982 (set_frame_buffer_list): Remove; unused.
1983 * frame.h (other_visible_frames): Remove decl.
1984 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1985 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1986 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1987 if HAVE_GPM.
1988 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1989 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1990 Define only if HAVE_GPM.
1991 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1992 (update_hints_inhibit): Remove; never set. All uses removed.
1993 * widgetprv.h (emacsFrameClassRec): Remove decl.
1994 * window.c (delete_deletable_window): Now returns void, since it
1995 wasn't returning anything.
1996 (compare_window_configurations): Remove unused locals.
1997 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1998 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1999 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2000 the same widths as pointers. This follows up on the 2011-05-06 patch.
2001 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2002 * xterm.h: Likewise.
2003 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2004
2005 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2006
2007 * makefile.w32-in: Update dependencies.
2008 (LISP_H): Add lib/intprops.h.
2009
2010 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2011
2012 * image.c (gif_load): Add animation frame delay to the metadata.
2013 (syms_of_image): Use DEFSYM. New symbol `delay'.
2014
2015 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2016
2017 * window.c (delete_deletable_window): Re-add.
2018 (Fset_window_configuration): Rewrite to handle dead buffers and
2019 consequently deletable windows.
2020 (window_tree, Fwindow_tree): Remove. Supply functionality in
2021 window.el.
2022 (compare_window_configurations): Simplify code.
2023
2024 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2025
2026 * image.c (imagemagick_load_image): Fix type mismatch.
2027 (Fimagemagick_types): Likewise.
2028
2029 * window.h (replace_buffer_in_windows): Declare.
2030
2031 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2032
2033 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2034 Qclone_number. Remove external declaration of Qdelete_window.
2035 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2036 code.
2037 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2038 Qbuffer_list_update_hook if allowed.
2039 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2040 buffer list implementation.
2041 (other_buffer_safely): New function.
2042 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2043 calls to replace_buffer_in_windows and
2044 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2045 if allowed.
2046 (record_buffer): Inhibit quitting and rewrite using quittable
2047 functions. Run Qbuffer_list_update_hook if allowed.
2048 (Frecord_buffer, Funrecord_buffer): New functions.
2049 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2050 switch-to-buffer to window.el.
2051 (bury-buffer): Move to window.el.
2052 (Vbuffer_list_update_hook): New variable.
2053
2054 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2055 section.
2056
2057 * window.h (resize_frame_windows): Move up in code.
2058 (Fwindow_frame): Remove EXFUN.
2059 (replace_buffer_in_all_windows): Remove prototype.
2060 (replace_buffer_in_windows_safely): Add prototype.
2061
2062 * window.c: Declare Qdelete_window static again. Move down
2063 declaration of select_count.
2064 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2065 (Fother_window): Move to window.el.
2066 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2067 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2068 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2069 window.el.
2070 (replace_buffer_in_windows): Implement by calling
2071 Qreplace_buffer_in_windows.
2072 (replace_buffer_in_all_windows): Remove with some functionality
2073 moved into replace_buffer_in_windows_safely.
2074 (replace_buffer_in_windows_safely): New function.
2075 (select_window_norecord, select_frame_norecord): Move in front
2076 of run_window_configuration_change_hook. Remove now obsolete
2077 declarations.
2078 (Fset_window_buffer): Rewrite doc-string. Call
2079 Qrecord_window_buffer.
2080 (keys_of_window): Move binding for other-window to window.el.
2081
2082 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2083
2084 * dispextern.h (struct image): Replace data member, whose int_val
2085 and ptr_val fields were not used by anything, with a single
2086 lisp_val object.
2087
2088 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2089 (gif_clear_image, gif_load, imagemagick_load_image)
2090 (gs_clear_image, gs_load): Callers changed.
2091
2092 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2093
2094 * buffer.h: Include <time.h>, for time_t.
2095 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2096
2097 Fix minor problems found by static checking.
2098
2099 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2100
2101 Make identifiers static if they are not used in other modules.
2102 * data.c (Qcompiled_function, Qframe, Qvector):
2103 * image.c (QimageMagick, Qsvg):
2104 * minibuf.c (Qmetadata):
2105 * window.c (resize_window_check, resize_root_window): Now static.
2106 * window.h (resize_window_check, resize_root_window): Remove decls.
2107
2108 * window.c (window_deletion_count, delete_deletable_window):
2109 Remove; unused.
2110 (window_body_lines): Now static.
2111 (Fdelete_other_windows_internal): Mark vars as initialized.
2112 Make sure 'resize_failed' is initialized.
2113 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2114 (resize_window_apply): Remove unused local.
2115 * window.h (delete_deletable_window): Remove decl.
2116
2117 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2118 (imagemagick_load_image): Fix pointer signedness problem by changing
2119 last arg from unsigned char * to char *. All uses changed.
2120 Also, fix a local for similar reasons.
2121 Remove unused locals. Remove locals to avoid shadowing.
2122 (fn_rsvg_handle_free): Remove; unused.
2123 (svg_load, svg_load_image): Fix pointer signedness problem.
2124 (imagemagick_load_image): Don't use garbage pointer image_wand.
2125
2126 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2127
2128 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2129
2130 * image.c (gif_load): Fix omitted cast error introduced by
2131 2011-06-06 change.
2132
2133 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2134
2135 * window.h (resize_proportionally, orig_total_lines)
2136 (orig_top_line): Remove from window structure.
2137 (set_window_height, set_window_width, change_window_heights)
2138 (Fdelete_window): Remove prototypes.
2139 (resize_frame_windows): Remove duplicate declaration.
2140
2141 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2142
2143 * window.h (resize_frame_windows, resize_window_check)
2144 (delete_deletable_window, resize_root_window)
2145 (resize_frame_windows): Declare prototypes.
2146
2147 * window.c (resize_window_apply): Make definition be "static" to
2148 match the prototype.
2149
2150 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2151
2152 * window.c: Remove declarations of Qwindow_size_fixed,
2153 window_min_size_1, window_min_size_2, window_min_size,
2154 size_window, window_fixed_size_p, enlarge_window, delete_window.
2155 Remove static from declaration of Qdelete_window, it's
2156 temporarily needed by Fbury_buffer.
2157 (replace_window): Don't assign orig_top_line and
2158 orig_total_lines.
2159 (Fdelete_window, delete_window): Remove. Window deletion is
2160 handled by window.el.
2161 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2162 Fdelete_window calls with calls to Qdelete_window.
2163 (Fdelete_other_windows): Remove. Deleting other windows is
2164 handled by window.el.
2165 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2166 handled in window.el.
2167 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2168 Window minimum sizes are handled in window.el.
2169 (shrink_windows, size_window, set_window_height)
2170 (set_window_width, change_window_heights, window_height)
2171 (window_width, CURBEG, CURSIZE, enlarge_window)
2172 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2173 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2174 handled in window.el.
2175 (make_dummy_parent): Rename to make_parent_window and give it a
2176 second argument horflag.
2177 (make_window): Don't set resize_proportionally any more.
2178 (Fsplit_window): Remove. Windows are split in window.el.
2179 (save_restore_action, save_restore_orig_size)
2180 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2181 Resize mini windows in window.el.
2182 (grow_mini_window, shrink_mini_window): Implement by calling
2183 Qresize_root_window_vertically, resize_window_check and
2184 resize_window_apply.
2185 (saved_window, Fset_window_configuration, save_window_save): Do
2186 not handle orig_top_line, orig_total_lines, and
2187 resize_proportionally.
2188 (window_min_height, window_min_width): Move to window.el.
2189 (keys_of_window): Move bindings for delete-other-windows,
2190 split-window, delete-window and enlarge-window to window.el.
2191
2192 * buffer.c: Temporarily extern Qdelete_window.
2193 (Fbury_buffer): Temporarily call Qdelete_window instead of
2194 Fdelete_window (Fbury_buffer will move to window.el soon).
2195
2196 * frame.c (set_menu_bar_lines_1): Remove code handling
2197 orig_top_line and orig_total_lines.
2198
2199 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2200 set_window_height but set heights directly.
2201 (change_frame_size_1): Use resize_frame_windows.
2202
2203 * xdisp.c (init_xdisp): Don't use set_window_height but set
2204 heights directly.
2205
2206 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2207 resize_frame_windows instead of change_window_heights and run
2208 run_window_configuration_change_hook.
2209
2210 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2211 instead of change_window_heights and run
2212 run_window_configuration_change_hook.
2213
2214 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2215
2216 * window.c (replace_window): Rename second argument REPLACEMENT to
2217 NEW. New third argument SETFLAG. Rewrite.
2218 (delete_window, make_dummy_parent): Call replace_window with
2219 third argument 1.
2220 (window_list_1): Move down in code.
2221 (run_window_configuration_change_hook): Move set_buffer part
2222 before select_frame_norecord part in order to unwind correctly.
2223 Rename count1 to count.
2224 (recombine_windows, delete_deletable_window, resize_root_window)
2225 (Fdelete_other_windows_internal)
2226 (Frun_window_configuration_change_hook, make_parent_window)
2227 (resize_window_check, resize_window_apply, Fresize_window_apply)
2228 (resize_frame_windows, Fsplit_window_internal)
2229 (Fdelete_window_internal, Fresize_mini_window_internal): New
2230 functions.
2231 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2232
2233 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2234
2235 * window.h (window): Add some new members to window structure -
2236 normal_lines, normal_cols, new_total, new_normal, clone_number,
2237 splits, nest, prev_buffers, next_buffers.
2238 (WINDOW_TOTAL_SIZE): Move here from window.c.
2239 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2240
2241 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2242 Remove.
2243 (make_dummy_parent): Set new members of windows structure.
2244 (make_window): Move down in code. Handle new members of window
2245 structure.
2246 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2247 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2248 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2249 (Fset_window_prev_buffers, Fwindow_next_buffers)
2250 (Fset_window_next_buffers, Fset_window_clone_number): New
2251 functions.
2252 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2253 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2254 Doc-string fixes.
2255 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2256 Argument WINDOW can be now internal window too.
2257 (Fwindow_use_time): Move up in code.
2258 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2259 Rewrite doc-string.
2260 (Fset_window_configuration, saved_window)
2261 (Fcurrent_window_configuration, save_window_save): Handle new
2262 members of window structure.
2263 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2264 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2265 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2266 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2267 Qget_mru_window, Qresize_root_window,
2268 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2269 Qauto_buffer_name; staticpro them.
2270
2271 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2272
2273 * window.c (Fwindow_total_size, Fwindow_left_column)
2274 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2275 (Fwindow_list_1): New functions.
2276 (window_box_text_cols): Replace with window_body_cols.
2277 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2278 window_body_cols instead of window_box_text_cols.
2279 (delete_window, Fset_window_configuration): Call
2280 delete_all_subwindows with window as argument.
2281 (delete_all_subwindows): Take a window as argument and not a
2282 structure. Rewrite.
2283 (window_loop): Remove handling of GET_LRU_WINDOW and
2284 GET_LARGEST_WINDOW.
2285 (Fget_lru_window, Fget_largest_window): Move to window.el.
2286
2287 * window.h: Extern window_body_cols instead of
2288 window_box_text_cols. delete_all_subwindows now takes a
2289 Lisp_Object as argument.
2290
2291 * indent.c (compute_motion, Fcompute_motion): Use
2292 window_body_cols instead of window_box_text_cols.
2293
2294 * frame.c (delete_frame): Call delete_all_subwindows with root
2295 window as argument.
2296
2297 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2298
2299 * fns.c (Fputhash): Document return value.
2300
2301 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2302
2303 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2304
2305 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2306
2307 Cons<->int and similar integer overflow fixes (Bug#8794).
2308
2309 Check for overflow when converting integer to cons and back.
2310 * charset.c (Fdefine_charset_internal, Fdecode_char):
2311 Use cons_to_unsigned to catch overflow.
2312 (Fencode_char): Use INTEGER_TO_CONS.
2313 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2314 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2315 * data.c (long_to_cons, cons_to_long): Remove.
2316 (cons_to_unsigned, cons_to_signed): New functions.
2317 These signal an error for invalid or out-of-range values.
2318 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2319 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2320 * font.c (Ffont_variation_glyphs):
2321 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2322 * lisp.h: Include <intprops.h>.
2323 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2324 (cons_to_signed, cons_to_unsigned): New decls.
2325 (long_to_cons, cons_to_long): Remove decls.
2326 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2327 (Fprimitive_undo): Use CONS_TO_INTEGER.
2328 * xfns.c (Fx_window_property): Likewise.
2329 * xselect.c: Include <limits.h>.
2330 (x_own_selection, selection_data_to_lisp_data):
2331 Use INTEGER_TO_CONS.
2332 (x_handle_selection_request, x_handle_selection_clear)
2333 (x_get_foreign_selection, Fx_disown_selection_internal)
2334 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2335 (lisp_data_to_selection_data): Use cons_to_unsigned.
2336 (x_fill_property_data): Use cons_to_signed.
2337 Report values out of range.
2338
2339 Check for buffer and string overflow more precisely.
2340 * buffer.h (BUF_BYTES_MAX): New macro.
2341 * lisp.h (STRING_BYTES_MAX): New macro.
2342 * alloc.c (Fmake_string):
2343 * character.c (string_escape_byte8):
2344 * coding.c (coding_alloc_by_realloc):
2345 * doprnt.c (doprnt):
2346 * editfns.c (Fformat):
2347 * eval.c (verror):
2348 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2349 since they may not be the same number.
2350 * editfns.c (Finsert_char):
2351 * fileio.c (Finsert_file_contents):
2352 Likewise for BUF_BYTES_MAX.
2353
2354 * image.c: Use ptrdiff_t, not int, for sizes.
2355 (slurp_file): Switch from int to ptrdiff_t.
2356 All uses changed.
2357 (slurp_file): Check that file size fits in both size_t (for
2358 malloc) and ptrdiff_t (for sanity and safety).
2359
2360 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2361 if b->modtime has its maximal value.
2362
2363 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2364
2365 Don't assume time_t can fit into int.
2366 * buffer.h (struct buffer.modtime): Now time_t, not int.
2367 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2368 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2369
2370 Minor fixes for signed vs unsigned integers.
2371 * character.h (MAYBE_UNIFY_CHAR):
2372 * charset.c (maybe_unify_char):
2373 * keyboard.c (read_char, reorder_modifiers):
2374 XINT -> XFASTINT, since the integer must be nonnegative.
2375 * ftfont.c (ftfont_spec_pattern):
2376 * keymap.c (access_keymap, silly_event_symbol_error):
2377 XUINT -> XFASTINT, since the integer must be nonnegative.
2378 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2379 since it makes no difference and we prefer signed.
2380 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2381 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2382 nonnegative.
2383
2384 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2385
2386 * window.h (Fwindow_frame): Declare.
2387
2388 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2389
2390 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2391 (SPARE_MEMORY): Always define.
2392 (LARGE_REQUEST): Remove.
2393 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2394
2395 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2396
2397 * lisp.h: Move EXFUNS for Fframe_root_window,
2398 Fframe_first_window and Fset_frame_selected_window to window.h.
2399
2400 * window.h: Move EXFUNS for Fframe_root_window,
2401 Fframe_first_window and Fset_frame_selected_window here from
2402 lisp.h.
2403
2404 * frame.c (Fwindow_frame, Fframe_first_window)
2405 (Fframe_root_window, Fframe_selected_window)
2406 (Fset_frame_selected_window): Move to window.c.
2407 (Factive_minibuffer_window): Move to minibuf.c.
2408 (Fother_visible_frames_p): New function.
2409
2410 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2411
2412 * window.c (decode_window, decode_any_window): Move up in code.
2413 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2414 (inhibit_frame_unsplittable): Remove unused variable.
2415 (Fwindow_buffer): Move up and rewrite doc-string.
2416 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2417 (Fwindow_prev): New functions.
2418 (Fwindow_frame): Move here from frame.c. Accept any window as
2419 argument.
2420 (Fframe_root_window, Fframe_first_window)
2421 (Fframe_selected_window): Move here from frame.c. Accept frame
2422 or arbitrary window as argument. Update doc-strings.
2423 (Fminibuffer_window): Move up in code.
2424 (Fwindow_minibuffer_p): Move up in code and simplify.
2425 (Fset_frame_selected_window): Move here from frame.c.
2426 Marginal rewrite.
2427 (Fselected_window, select_window, Fselect_window): Move up in
2428 code. Minor doc-string fixes.
2429
2430 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2431
2432 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2433 Do not assume that spare memory exists; that assumption is valid
2434 only if SYSTEM_MALLOC.
2435 (LARGE_REQUEST): New macro, so that the issue of large requests
2436 is separated from the issue of spare memory.
2437
2438 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2439
2440 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2441 format. (Bug#8806)
2442
2443 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2444
2445 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2446 before statements.
2447
2448 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2449
2450 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2451
2452 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2453
2454 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2455 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2456
2457 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2458
2459 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2460
2461 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2462
2463 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2464 (x_clipboard_manager_save): Add return value.
2465 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2466 New error handlers.
2467 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2468 Obey Vx_select_enable_clipboard_manager. Catch errors in
2469 x_clipboard_manager_save (Bug#8779).
2470 (Vx_select_enable_clipboard_manager): New variable.
2471 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2472
2473 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2474
2475 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2476
2477 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2478
2479 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2480 in the current matrix if keep_current_p is non-zero.
2481
2482 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2483
2484 * bidi.c (bidi_level_of_next_char): Fix last change.
2485
2486 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2487
2488 Support bidi reordering of text covered by display properties.
2489
2490 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2491 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2492 (bidi_cache_search, bidi_cache_iterator_state)
2493 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2494 (bidi_level_of_next_char, bidi_move_to_visually_next):
2495 Support character positions inside a run of characters covered by a
2496 display string.
2497 (bidi_paragraph_init, bidi_resolve_explicit_1)
2498 (bidi_level_of_next_char): Call bidi_fetch_char and
2499 bidi_fetch_char_advance instead of FETCH_CHAR and
2500 FETCH_CHAR_ADVANCE.
2501 (bidi_init_it): Initialize new members.
2502 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2503 definitions.
2504 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2505 instead of using explicit *_CHAR codes.
2506 (bidi_resolve_explicit, bidi_resolve_weak):
2507 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2508 bidirectional text is supported only in multibyte buffers.
2509 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2510 it to initialize the frame_window_p member of struct bidi_it.
2511 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2512 (bidi_resolve_explicit, bidi_resolve_weak)
2513 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2514 bidi_it->nchars is non-positive.
2515 (bidi_level_of_next_char): Don't try to lookup the cache for the
2516 next/previous character if nothing is cached there yet, or if we
2517 were just reseat()'ed to a new position.
2518
2519 * xdisp.c (set_cursor_from_row): Set start and stop points
2520 according to the row's direction when priming the loop that looks
2521 for the glyph on which to display cursor.
2522 (single_display_spec_intangible_p): Function deleted.
2523 (display_prop_intangible_p): Reimplement to call
2524 handle_display_spec instead of single_display_spec_intangible_p.
2525 Accept 3 additional arguments needed by handle_display_spec.
2526 This fixes incorrect cursor motion across display property with complex
2527 values: lists, `(when COND...)' forms, etc.
2528 (single_display_spec_string_p): Support property values that are
2529 lists with the argument STRING its top-level element.
2530 (display_prop_string_p): Fix the condition for processing a
2531 property that is a list to be consistent with handle_display_spec.
2532 (handle_display_spec): New function, refactored from the
2533 last portion of handle_display_prop.
2534 (compute_display_string_pos): Accept additional argument
2535 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2536 value of a `display' property is a "replacing spec".
2537 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2538 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2539 the display property, but just return a value indicating whether
2540 the display property will replace the characters it covers.
2541 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2542 frame_window_p members of struct bidi_it.
2543 (compute_display_string_pos, compute_display_string_end):
2544 New functions.
2545 (push_it): Accept second argument POSITION, where pop_it should
2546 jump to continue iteration.
2547 (reseat_1): Initialize bidi_it.disp_pos.
2548
2549 * keyboard.c (adjust_point_for_property): Adjust the call to
2550 display_prop_intangible_p to its new signature.
2551
2552 * dispextern.h (struct bidi_it): New member frame_window_p.
2553 (bidi_init_it): Update prototypes.
2554 (display_prop_intangible_p): Update prototype.
2555 (compute_display_string_pos, compute_display_string_end):
2556 Declare prototypes.
2557 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2558 EMACS_INT.
2559
2560 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2561
2562 Malloc failure behavior now depends on size of allocation.
2563 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2564 * lisp.h: Change signatures accordingly.
2565 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2566 All callers changed. (Bug#8762)
2567
2568 * gnutls.c: Use Emacs's memory allocators.
2569 Without this change, the gnutls library would invoke malloc etc.
2570 directly, which causes problems on non-SYNC_INPUT hosts, and which
2571 runs afoul of improving memory_full behavior. (Bug#8761)
2572 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2573 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2574 xfree instead of the default malloc, realloc, free.
2575 (Fgnutls_boot): No need to check for memory allocation failure,
2576 since xmalloc does that for us.
2577
2578 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2579 * category.c (hash_get_category_set):
2580 * ccl.c (ccl_driver):
2581 * charset.c (Fdefine_charset_internal):
2582 * charset.h (struct charset.hash_index):
2583 * composite.c (get_composition_id, gstring_lookup_cache)
2584 (composition_gstring_put_cache):
2585 * composite.h (struct composition.hash_index):
2586 * dispextern.h (struct image.hash):
2587 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2588 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2589 (hashfn_equal, hashfn_user_defined, make_hash_table)
2590 (maybe_resize_hash_table, hash_lookup, hash_put)
2591 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2592 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2593 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2594 * image.c (make_image, search_image_cache, lookup_image)
2595 (xpm_put_color_table_h):
2596 * lisp.h (struct Lisp_Hash_Table):
2597 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2598 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2599 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2600 * alloc.c (allocate_vectorlike):
2601 Check for overflow in vector size calculations.
2602 * ccl.c (ccl_driver):
2603 Check for overflow when converting EMACS_INT to int.
2604 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2605 need to be updated by these changes.
2606 * fns.c (make_hash_table, maybe_resize_hash_table):
2607 Check for integer overflow with large hash tables.
2608 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2609 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2610 (SXHASH_REDUCE): New macro.
2611 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2612 Use it instead of discarding useful hash info with large hash values.
2613 (sxhash_float): New function.
2614 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2615 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2616 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2617 Rewrite to use FIXNUM_BITS, as this simplifies things.
2618 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2619 Adjust signatures to match updated version of code.
2620 (consing_since_gc): Now EMACS_INT, since a single hash table can
2621 use more than INT_MAX bytes.
2622
2623 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2624
2625 Make it possible to build with GCC-4.6+ -O2 -flto.
2626
2627 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2628
2629 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2630
2631 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2632 Call minibuffer-inactive-mode.
2633
2634 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2635
2636 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2637 Update dependencies.
2638
2639 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2640
2641 * data.c (init_data): Remove code for UTS, this system is not
2642 supported anymore.
2643
2644 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2645
2646 Don't force ./temacs to start in terminal mode.
2647
2648 * frame.c (make_initial_frame): Initialize faces in all cases, not
2649 only when CANNOT_DUMP is defined.
2650 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2651
2652 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2653
2654 * dispnew.c (add_window_display_history): Use const for the string
2655 pointer. Remove declaration, not needed.
2656
2657 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2658
2659 Use 'inline', not 'INLINE'.
2660 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2661 * alloc.c, fontset.c (INLINE): Remove.
2662 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2663 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2664 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2665 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2666 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2667
2668 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2669
2670 Make it possible to run ./temacs.
2671
2672 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2673 syms_of_callproc does the same thing. Remove test for
2674 "initialized", do it in the caller.
2675 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2676
2677 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2678
2679 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2680 (read_minibuf): Use get_minibuffer.
2681 (syms_of_minibuf): Use DEFSYM.
2682 (Qmetadata): New var.
2683 * data.c (Qbuffer): Don't make it static.
2684 (syms_of_data): Use DEFSYM.
2685
2686 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2687
2688 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2689 (CCL_CODE_MIN): New macro.
2690
2691 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2692
2693 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2694
2695 * eval.c (Qdebug): Now static.
2696 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2697 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2698 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2699
2700 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2701
2702 * image.c: Various fixes to ImageMagick code comments.
2703 (Fimagemagick_types): Doc fix.
2704
2705 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2706
2707 Minor fixes prompted by GCC 4.6.0 warnings.
2708
2709 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2710
2711 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2712 (x_clipboard_manager_save_all): Move extern decl to ...
2713 * xterm.h: ... here, so that it can be checked for consistency.
2714
2715 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2716
2717 * xselect.c (x_clipboard_manager_save_frame)
2718 (x_clipboard_manager_save_all): New functions.
2719 (Fx_clipboard_manager_save): Lisp function deleted.
2720
2721 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2722 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2723
2724 * xterm.h: Update prototype.
2725
2726 2011-05-28 William Xu <william.xwl@gmail.com>
2727
2728 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2729 exiting (Bug#8239).
2730
2731 2011-05-28 Jim Meyering <meyering@redhat.com>
2732
2733 Avoid a sign-extension bug in crypto_hash_function.
2734 * fns.c (to_uchar): Define.
2735 (crypto_hash_function): Use it to convert some newly-signed
2736 variables to unsigned, to avoid sign-extension bugs. For example,
2737 without this change, (md5 "truc") would evaluate to
2738 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2739 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2740 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2741
2742 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2743
2744 Integer overflow fixes.
2745
2746 * dbusbind.c: Serial number integer overflow fixes.
2747 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2748 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2749 to hold a serial number that is too large for a fixnum.
2750 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2751 Check for serial numbers out of range. Decode any serial number
2752 that was so large that it became a float. (Bug#8722)
2753
2754 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2755 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2756 Use XFASTINT rather than XUINT when numbers are nonnegative.
2757 (xd_append_arg, Fdbus_method_return_internal):
2758 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2759 arguments, check that Lisp number is nonnegative, rather than
2760 silently wrapping negative numbers around. (Bug#8722)
2761 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2762 (Bug#8722)
2763
2764 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2765
2766 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2767
2768 ccl: add integer overflow checks
2769 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2770 (IN_INT_RANGE): New macros.
2771 (ccl_driver): Use them to check for integer overflow when
2772 decoding a CCL program. Many of the new checks are whether XINT (x)
2773 fits in int; it doesn't always, on 64-bit hosts. The new version
2774 doesn't catch all possible integer overflows, but it's an
2775 improvement. (Bug#8719)
2776
2777 * alloc.c (make_event_array): Use XINT, not XUINT.
2778 There's no need for unsigned here.
2779
2780 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2781 This follows up to the 2011-05-06 change that substituted uintptr_t
2782 for EMACS_INT. This case wasn't caught back then.
2783
2784 Rework Fformat to avoid integer overflow issues.
2785 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2786 now (part of C89). Include <verify.h>.
2787 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2788 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2789 (Fformat): Avoid the prepass trying to compute sizes; it was only
2790 approximate and thus did not catch overflow reliably. Instead, walk
2791 through the format just once, formatting and computing sizes as we go,
2792 checking for integer overflow at every step, and allocating a larger
2793 buffer as needed. Keep track separately whether the format is
2794 multibyte. Keep only the most-recently calculated precision, rather
2795 than them all. Record whether each argument has been converted to
2796 string. Use EMACS_INT, not int, for byte and char and arg counts.
2797 Support field widths and precisions larger than INT_MAX. Avoid
2798 sprintf's undefined behavior with conversion specifications such as %#d
2799 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2800 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2801 formatting out-of-range floating point numbers with int
2802 formats. (Bug#8668)
2803
2804 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2805
2806 * data.c: Avoid integer truncation in expressions involving floats.
2807 * data.c: Include <intprops.h>.
2808 (arith_driver): When there's an integer overflow in an expression
2809 involving floating point, convert the integers to floating point
2810 so that the resulting value does not suffer from catastrophic
2811 integer truncation. For example, on a 64-bit host (* 4
2812 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2813 Do not rely on undefined behavior after integer overflow.
2814
2815 merge count_size_as_multibyte, parse_str_to_multibyte
2816 * character.c, character.h (count_size_as_multibyte):
2817 Rename from parse_str_to_multibyte; all uses changed.
2818 Check for integer overflow.
2819 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2820 since it's now a duplicate of the other. This is more of
2821 a character than a buffer op, so better that it's in character.c.
2822 * fns.c, print.c: Adjust to above changes.
2823
2824 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2825
2826 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2827
2828 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2829
2830 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2831 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2832 (x_clipboard_manager_save): Now static.
2833 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2834
2835 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2836 (crypto_hash_function): Now static.
2837 Fix pointer signedness problems. Avoid unnecessary initializations.
2838
2839 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2840
2841 * termhooks.h (Vselection_alist): Make it terminal-local.
2842
2843 * terminal.c (create_terminal): Initialize it.
2844
2845 * xselect.c: Support for clipboard managers.
2846 (Vselection_alist): Move to termhooks.h as terminal-local var.
2847 (LOCAL_SELECTION): New macro.
2848 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2849 (symbol_to_x_atom): Remove gratuitous arg.
2850 (x_handle_selection_request, lisp_data_to_selection_data)
2851 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2852 (x_own_selection, x_get_local_selection, x_convert_selection):
2853 New arg, specifying work frame. Use terminal-local Vselection_alist.
2854 (some_frame_on_display): Delete unused function.
2855 (Fx_own_selection_internal, Fx_get_selection_internal)
2856 (Fx_disown_selection_internal, Fx_selection_owner_p)
2857 (Fx_selection_exists_p): New optional frame arg.
2858 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2859 (x_handle_selection_clear): Don't treat other terminals with the
2860 same keyboard specially. Use the terminal-local Vselection_alist.
2861 (x_clear_frame_selections): Use Frun_hook_with_args.
2862
2863 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2864
2865 * xterm.h: Add support for those atoms.
2866
2867 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2868
2869 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2870 (converted_selections, conversion_fail_tag): New global variables.
2871 (x_selection_request_lisp_error): Free the above.
2872 (x_get_local_selection): Remove unnecessary code.
2873 (x_reply_selection_request): Args changed; handle arbitrary array
2874 of converted selections stored in converted_selections.
2875 Separate the XChangeProperty and SelectionNotify steps.
2876 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2877 (x_convert_selection): New function.
2878 (x_handle_selection_event): Simplify.
2879 (x_get_foreign_selection): Don't ignore incoming requests while
2880 waiting for an answer; this will fail when we implement
2881 SAVE_TARGETS, and seems unnecessary anyway.
2882 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2883 (Vx_sent_selection_functions): Doc fix.
2884
2885 2011-05-26 Leo Liu <sdl.web@gmail.com>
2886
2887 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2888
2889 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2890
2891 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2892
2893 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2894 for fringe update if it has periodic bitmap.
2895 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2896 and fringe_bitmap_periodic_p.
2897
2898 * fringe.c (get_fringe_bitmap_data): New function.
2899 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2900 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2901 row. Mark glyph row for fringe update if periodicity changed.
2902
2903 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2904 for fringe update unless it has periodic bitmap.
2905
2906 2011-05-25 Kenichi Handa <handa@m17n.org>
2907
2908 * xdisp.c (get_next_display_element): Set correct it->face_id for
2909 a static composition.
2910
2911 2011-05-24 Leo Liu <sdl.web@gmail.com>
2912
2913 * deps.mk (fns.o):
2914 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2915
2916 * fns.c (crypto_hash_function, Fsha1): New function.
2917 (Fmd5): Use crypto_hash_function.
2918 (syms_of_fns): Add Ssha1.
2919
2920 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2921
2922 * gnutls.c: Remove unused macros.
2923 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2924 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2925 Remove macros that are defined and never used.
2926 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2927
2928 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2929
2930 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2931 (Fx_get_selection_internal): Minor cleanup.
2932 (Fx_own_selection_internal): Rename arguments for consistency with
2933 select.el.
2934
2935 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2936
2937 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2938
2939 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2940
2941 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2942
2943 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2944
2945 * dispnew.c (scrolling_window): Don't exclude the case that the
2946 last enabled row in the desired matrix touches the bottom boundary.
2947
2948 2011-05-21 Glenn Morris <rgm@gnu.org>
2949
2950 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2951 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2952 and add some more files.
2953
2954 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2955
2956 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2957 report_file_error introduced by the change from 2011-05-07.
2958
2959 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2960
2961 * systime.h (Time): Define only if emacs is defined.
2962 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2963 where the include path doesn't have X11/X.h by default. See
2964 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2965
2966 2011-05-20 Kenichi Handa <handa@m17n.org>
2967
2968 * composite.c (find_automatic_composition): Fix previous change.
2969
2970 2011-05-20 Glenn Morris <rgm@gnu.org>
2971
2972 * lisp.mk: New file, split from Makefile.in.
2973 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2974 (shortlisp): Remove.
2975 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2976
2977 2011-05-19 Glenn Morris <rgm@gnu.org>
2978
2979 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2980 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2981 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2982 (lisp): Set the order to that of loadup.el.
2983 (shortlisp): Make it a copy of $lisp.
2984 (SOME_MACHINE_LISP): Remove.
2985 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2986 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2987
2988 2011-05-18 Kenichi Handa <handa@m17n.org>
2989
2990 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2991 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2992 (find_automatic_composition): Mostly rewrite for efficiency.
2993
2994 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2995
2996 * makefile.w32-in: Update dependencies.
2997
2998 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2999
3000 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3001 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3002
3003 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3004
3005 Fix some integer overflow issues, such as string length overflow.
3006
3007 * insdel.c (count_size_as_multibyte): Check for string overflow.
3008
3009 * character.c (lisp_string_width): Check for string overflow.
3010 Use EMACS_INT, not int, for string indexes and lengths; in
3011 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3012 the resulting string length overflows an EMACS_INT; instead,
3013 report a string overflow if no precision given. When checking for
3014 precision exhaustion, use a check that cannot possibly have
3015 integer overflow. (Bug#8675)
3016 * character.h (lisp_string_width): Adjust to new signature.
3017
3018 * alloc.c (string_overflow): New function.
3019 (Fmake_string): Use it. This doesn't change behavior, but saves
3020 a few bytes and will simplify future changes.
3021 * character.c (string_escape_byte8): Likewise.
3022 * lisp.h (string_overflow): New decl.
3023
3024 Fixups, following up to the user-interface timestamp change.
3025 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3026 for UI timestamps, instead of unsigned long.
3027 * msdos.c (mouse_get_pos): Likewise.
3028 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3029 * w32gui.h (Time): Define by including "systime.h" rather than by
3030 declaring it ourselves. (Bug#8664)
3031
3032 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3033 * image.c (clear_image_cache): Likewise.
3034
3035 * term.c (term_mouse_position): Don't assume time_t wraparound.
3036
3037 Be more systematic about user-interface timestamps.
3038 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3039 and sometimes 'EMACS_UINT', to represent these timestamps.
3040 This change causes it to use 'Time' uniformly, as that's what X uses.
3041 This makes the code easier to follow, and makes it easier to catch
3042 integer overflow bugs such as Bug#8664.
3043 * frame.c (Fmouse_position, Fmouse_pixel_position):
3044 Use Time, not unsigned long, for user-interface timestamps.
3045 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3046 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3047 * keyboard.h (last_event_timestamp): Likewise.
3048 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3049 * menu.h (xmenu_show): Likewise.
3050 * term.c (term_mouse_position): Likewise.
3051 * termhooks.h (struct input_event.timestamp): Likewise.
3052 (struct terminal.mouse_position_hook): Likewise.
3053 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3054 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3055 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3056 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3057 what it was before.
3058 * menu.h, termhooks.h: Include "systime.h", for Time.
3059
3060 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3061 Don't assume that the difference between two unsigned long values
3062 can fit into an integer. At this point, we know button_down_time
3063 <= event->timestamp, so the difference must be nonnegative, so
3064 there's no need to cast the result if double-click-time is
3065 nonnegative, as it should be; check that it's nonnegative, just in
3066 case. This bug is triggered when events are more than 2**31 ms
3067 apart (about 25 days). (Bug#8664)
3068
3069 * xselect.c (last_event_timestamp): Remove duplicate decl.
3070 (x_own_selection): Remove needless cast to unsigned long.
3071
3072 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3073 that always fit in int. Use a sentinel instead of a counter, to
3074 avoid a temp and to allay GCC's concerns about possible int overflow.
3075 * frame.h (struct frame): Use int for menu_bar_items_used
3076 instead of EMACS_INT, since it always fits in int.
3077
3078 * menu.c (grow_menu_items): Check for int overflow.
3079
3080 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3081
3082 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3083 Before, the code was not consistent. These values cannot exceed
3084 2**31 - 1 so there's no need to make them unsigned.
3085 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3086 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3087 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3088 as modifiers.
3089 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3090
3091 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3092 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3093 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3094 presumably because the widths might not match.
3095
3096 * window.c (size_window): Avoid needless test at loop start.
3097
3098 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3099
3100 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3101
3102 2011-05-12 Drew Adams <drew.adams@oracle.com>
3103
3104 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3105
3106 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3107
3108 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3109 `width' to `bar_area_x' and `bar_area_width', respectively.
3110 (x_scroll_run): Take account of fringe background extension.
3111
3112 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3113 Rename local vars `left' and `width' to `bar_area_x' and
3114 `bar_area_width', respectively.
3115 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3116 background extension.
3117
3118 2011-05-10 Jim Meyering <meyering@redhat.com>
3119
3120 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3121
3122 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3123
3124 * image.c (Finit_image_library): Return t for built-in image types,
3125 like pbm and xbm. (Bug#8640)
3126
3127 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3128
3129 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3130
3131 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3132
3133 * w32console.c (Fset_screen_color): Doc fix.
3134 (Fget_screen_color): New function.
3135 (syms_of_ntterm): Defsubr it.
3136
3137 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3138 unlink the temporary file if Fcall_process didn't create it in the
3139 first place.
3140 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3141 child process will be redirected to a file specified with `:file'.
3142 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3143 cue to call_process_cleanup not to close that handle.
3144
3145 2011-05-07 Ben Key <bkey76@gmail.com>
3146
3147 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3148 one of two shell specific rules, either bootstrap-temacs-CMD or
3149 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3150 to the previous implementation of the bootstrap-temacs rule.
3151 The bootstrap-temacs-CMD rule is similar to the previous
3152 implementation of the bootstrap-temacs rule except that it
3153 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3154 variable.
3155
3156 These changes, along with some changes to nt/configure.bat,
3157 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3158 earlier fix to add support for --cflags and --ldflags options
3159 that include quotes so that it works whether make uses cmd or
3160 sh as the shell.
3161
3162 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3163
3164 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3165 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3166 is a constant.
3167 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3168 a string. Handle both cases.
3169 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3170 (Fdbus_register_method): Use Qinvalid_function.
3171
3172 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3173
3174 * makefile.w32-in: Update dependencies.
3175 (LISP_H): Add inttypes.h and stdin.h.
3176 (PROCESS_H): Add unistd.h.
3177
3178 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3179
3180 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3181 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3182
3183 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3184
3185 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3186
3187 * term.c (vfatal): Remove stray call to va_end.
3188 It's not needed and the C Standard doesn't allow it here anyway.
3189
3190 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3191 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3192
3193 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3194 bytes.
3195
3196 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3197
3198 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3199
3200 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3201
3202 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3203
3204 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3205
3206 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3207 * charset.c (Fdefine_charset_internal): Don't initialize
3208 charset.code_space[15]. The value was garbage, on hosts with
3209 32-bit int (Bug#8600).
3210
3211 * lread.c (read_integer): Be more consistent with string-to-number.
3212 Use string_to_number to do the actual conversion; this avoids
3213 rounding errors and fixes some other screwups. Without this fix,
3214 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3215 (digit_to_number): Move earlier, for benefit of read_integer.
3216 Return -1 if the digit is out of range for the base, -2 if it is
3217 not a digit in any supported base. (Bug#8602)
3218
3219 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3220
3221 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3222 to match comment at start of function. This also removes a
3223 GCC warning about overflow in a 32+64-bit port.
3224
3225 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3226
3227 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3228 Reported by Stefan Monnier in
3229 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3230 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3231 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3232
3233 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3234 (EMACS_UINTPTR): Likewise, with uintptr_t.
3235
3236 * lisp.h: Prefer 64-bit EMACS_INT if available.
3237 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3238 on 32-bit hosts that have 64-bit int, so that they can access
3239 large files.
3240 However, temporarily disable this change unless the temporary
3241 symbol WIDE_EMACS_INT is defined.
3242
3243 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3244
3245 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3246 This removes an assumption that EMACS_INT and long are the same
3247 width as pointers. The assumption is true for Emacs porting targets
3248 now, but we want to make other targets possible.
3249 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3250 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3251 In the rest of the code, change types of integers that hold casted
3252 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3253 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3254 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3255 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3256 No need to cast type when ORing.
3257 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3258 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3259 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3260 assume EMACS_INT is the same width as char *.
3261 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3262 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3263 Remove no-longer-needed casts.
3264 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3265 (xg_tool_bar_help_callback, xg_make_tool_item):
3266 Use EMACS_INTPTR to hold an integer
3267 that will be cast to void *; this can avoid a GCC warning
3268 if EMACS_INT is not the same width as void *.
3269 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3270 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3271 (current_message_1, set_message_1):
3272 Use a local to convert to proper width without a cast.
3273 * xmenu.c (dialog_selection_callback): Likewise.
3274
3275 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3276 Also, don't assume VALBITS / RAND_BITS is less than 5,
3277 and don't rely on undefined behavior when shifting a 1 left into
3278 the sign bit.
3279 * lisp.h (get_random): Change signature to match.
3280
3281 * lread.c (hash_string): Use size_t, not int, for hash computation.
3282 Normally we prefer signed values; but hashing is special, because
3283 it's better to use unsigned division on hash table sizes so that
3284 the remainder is nonnegative. Also, size_t is the natural width
3285 for hashing into memory. The previous code used 'int', which doesn't
3286 retain enough info to hash well into very large tables.
3287 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3288
3289 * dbusbind.c: Don't possibly lose pointer info when converting.
3290 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3291 Use XPNTR rather than XHASH, so that the high-order bits of
3292 the pointer aren't lost when converting through void *.
3293
3294 * eval.c (Fautoload): Don't double-shift a pointer.
3295
3296 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3297
3298 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3299
3300 * gnutls.c (DEF_GNUTLS_FN):
3301 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3302
3303 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3304
3305 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3306 marker. (Bug#8610)
3307
3308 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3309
3310 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3311 New version that can reserve upto 2GB of heap space.
3312
3313 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3314
3315 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3316
3317 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3318
3319 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3320 `gnutls_certificate_set_x509_key_file'.
3321
3322 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3323
3324 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3325 Update dependencies.
3326
3327 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3328
3329 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3330 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3331 Remove unused parameter `fildes'.
3332 * process.c (read_process_output, send_process): Don't pass it.
3333
3334 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3335
3336 Fix previous change: the library cache is defined in w32.c.
3337 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3338 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3339
3340 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3341
3342 Implement dynamic loading of GnuTLS on Windows.
3343
3344 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3345 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3346 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3347 Declare.
3348
3349 * gnutls.c (Qgnutls_dll): Define.
3350 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3351 (gnutls_*): Declare function pointers.
3352 (init_gnutls_functions): New function to initialize function pointers.
3353 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3354 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3355 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3356 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3357 (emacs_gnutls_write, emacs_gnutls_read)
3358 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3359 (Fgnutls_available_p): New function.
3360 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3361 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3362 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3363
3364 * image.c: Include w32.h.
3365 (Vimage_type_cache): Delete.
3366 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3367 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3368 (w32_delayed_load): Move to w32.c.
3369
3370 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3371
3372 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3373 (w32_delayed_load): Move from image.c. When loading a library, record
3374 its filename in the :loaded-from property of the library id.
3375 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3376 Initialize and staticpro them.
3377 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3378
3379 * process.c: Include lisp.h before w32.h, not after.
3380 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3381 instead of gnutls_record_check_pending.
3382
3383 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3384
3385 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3386
3387 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3388 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3389 as passed in.
3390
3391 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3392
3393 * xterm.c (x_set_frame_alpha): Do not set property on anything
3394 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3395
3396 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3397
3398 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3399
3400 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3401
3402 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3403 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3404 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3405 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3406 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3407 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3408 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3409 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3410 (Qgnutls_bootprop_callbacks_verify): Make static.
3411
3412 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3413
3414 * callproc.c: Indentation fixup.
3415
3416 * sysdep.c (wait_for_termination_1): Make static.
3417 (wait_for_termination, interruptible_wait_for_termination):
3418 Move after wait_for_termination_1.
3419
3420 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3421
3422 * sysdep.c (interruptible_wait_for_termination): New function
3423 which is like wait_for_termination, but allows keyboard
3424 interruptions.
3425
3426 * callproc.c (Fcall_process): Add (:file "file") as an option for
3427 the STDOUT buffer.
3428 (Fcall_process_region): Ditto.
3429
3430 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3431
3432 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3433 rather than `XVECTOR (FOO)->size'.
3434
3435 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3436 inttypes.h, as a gnulib replacement is used if it not available in
3437 system headers.
3438
3439 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3440
3441 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3442 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3443 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3444
3445 * coding.c (coding_alloc_by_realloc): Error out if destination
3446 will grow beyond MOST_POSITIVE_FIXNUM.
3447 (decode_coding_emacs_mule): Abort if there isn't enough place in
3448 charbuf for the composition carryover bytes. Reserve an extra
3449 space for up to 2 characters produced in a loop.
3450 (decode_coding_iso_2022): Abort if there isn't enough place in
3451 charbuf for the composition carryover bytes.
3452
3453 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3454
3455 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3456 aborting when %lld or %lll format is passed.
3457 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3458 %llo or %llx format is passed. (Bug#8545)
3459
3460 * window.c (window_scroll_line_based): Use a marker instead of
3461 simple variables to record original value of point. (Bug#7952)
3462
3463 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3464 produced by %s or %c overflows available buffer space. (Bug#8545)
3465
3466 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3467
3468 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3469 (SIZE_MAX): Move defn after all includes, as they might #define it.
3470
3471 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3472
3473 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3474
3475 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3476
3477 * keyboard.c (Qdelayed_warnings_hook): Define.
3478 (command_loop_1): Run `delayed-warnings-hook'
3479 if Vdelayed_warnings_list is non-nil.
3480 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3481 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3482
3483 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3484
3485 * doprnt.c (doprnt): Don't return value smaller than the buffer
3486 size if the message was truncated. (Bug#8545).
3487
3488 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3489
3490 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3491 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3492
3493 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3494
3495 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3496
3497 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3498
3499 * makefile.w32-in: Update dependencies.
3500
3501 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3502
3503 Improve `doprnt' and its usage. (Bug#8545)
3504 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3505 `format_end'. Remove support for %l as a conversion specifier.
3506 Don't use xrealloc. Improve diagnostics when the %l size modifier
3507 is used. Update the commentary.
3508
3509 * eval.c (verror): Simplify calculation of size_t.
3510
3511 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3512 messages.
3513
3514 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3515
3516 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3517 change.
3518
3519 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3520
3521 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3522 This makes this file independent of the recent pseudovector change.
3523
3524 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3525
3526 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3527
3528 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3529 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3530 Remove unused local.
3531 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3532
3533 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3534 GCC 4.6.0 optimizes based on type-based alias analysis.
3535 For example, if b is of type struct buffer * and v of type struct
3536 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3537 != &v->size, and therefore "v->size = 1; b->size = 2; return
3538 v->size;" must therefore return 1. This assumption is incorrect
3539 for Emacs, since it type-puns struct Lisp_Vector * with many other
3540 types. To fix this problem, this patch adds a new type struct
3541 vectorlike_header that documents the constraints on layout of vectors
3542 and pseudovectors, and helps optimizing compilers not get fooled
3543 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3544 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3545 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3546 the size member.
3547 (XSETPVECTYPE): Rewrite in terms of new macro.
3548 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3549 This is a bit clearer, and further avoids the possibility of
3550 undesirable aliasing.
3551 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3552 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3553 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3554 since Lisp_Subr is a special case (no "next" field).
3555 (ASIZE): Now uses header.size rather than size.
3556 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3557 to avoid the hassle of writing XVECTOR (foo)->header.size.
3558 (struct vectorlike_header): New type.
3559 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3560 object, to help avoid aliasing.
3561 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3562 (SUBRP): Likewise, since Lisp_Subr is a special case.
3563 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3564 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3565 (struct Lisp_Hash_Table): Combine first two members into a single
3566 struct vectorlike_header member. All uses of "size" and "next" members
3567 changed to be "header.size" and "header.next".
3568 * buffer.h (struct buffer): Likewise.
3569 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3570 * frame.h (struct frame): Likewise.
3571 * process.h (struct Lisp_Process): Likewise.
3572 * termhooks.h (struct terminal): Likewise.
3573 * window.c (struct save_window_data, struct saved_window): Likewise.
3574 * window.h (struct window): Likewise.
3575 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3576 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3577 * buffer.c (init_buffer_once): Likewise.
3578 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3579 special case.
3580 * process.c (Fformat_network_address): Use local var for size,
3581 for brevity.
3582
3583 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3584
3585 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3586 * data.c (atof): Remove decl; no longer used or needed.
3587 (digit_to_number): Move to lread.c.
3588 (Fstring_to_number): Use new string_to_number function, to be
3589 consistent with how the Lisp reader treats infinities and NaNs.
3590 Do not assume that floating-point numbers represent EMACS_INT
3591 without losing information; this is not true on most 64-bit hosts.
3592 Avoid double-rounding errors, by insisting on integers when
3593 parsing non-base-10 numbers, as the documentation specifies.
3594 * lisp.h (string_to_number): New decl, replacing ...
3595 (isfloat_string): Remove.
3596 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3597 (read1): Do not accept +. and -. as integers; this
3598 appears to have been a coding error. Similarly, do not accept
3599 strings like +-1e0 as floating point numbers. Do not report
3600 overflow for integer overflows unless the base is not 10 which
3601 means we have no simple and reliable way to continue.
3602 Break out the floating-point parsing into a new
3603 function string_to_number, so that Fstring_to_number parses
3604 floating point numbers consistently with the Lisp reader.
3605 (digit_to_number): Move here from data.c. Make it static inline.
3606 (E_CHAR, EXP_INT): Remove, replacing with ...
3607 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3608 (string_to_number): New function, replacing isfloat_string.
3609 This function checks for valid syntax and produces the resulting
3610 Lisp float number too. Rework it so that string-to-number
3611 no longer mishandles examples like "1.0e+". Use strtoumax,
3612 so that overflow for non-base-10 numbers is reported only when
3613 there's no portable and simple way to convert to floating point.
3614
3615 * textprop.c (set_text_properties_1): Rewrite for clarity,
3616 and to avoid GCC warning about integer overflow.
3617
3618 * intervals.h (struct interval): Use EMACS_INT for members
3619 where EMACS_UINT might cause problems. See
3620 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3621 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3622 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3623 All uses changed.
3624 (offset_intervals): Tell GCC not to worry about length overflow
3625 when negating a negative length.
3626
3627 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3628 (overrun_check_free): Likewise.
3629
3630 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3631 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3632 word size.
3633
3634 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3635 (gnutls_make_error): Rename local to avoid shadowing.
3636 (gnutls_emacs_global_deinit): ifdef out; not used.
3637 (Fgnutls_boot): Use const for pointer to readonly storage.
3638 Comment out unused local. Fix pointer signedness problems.
3639
3640 * lread.c (openp): Don't stuff size_t into an 'int'.
3641 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3642 about possible signed overflow.
3643
3644 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3645 (GDK_KEY_g): Don't define if already defined.
3646 (xg_prepare_tooltip): Avoid pointer signedness problem.
3647 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3648
3649 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3650 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3651
3652 * xfns.c (Fx_window_property): Simplify a bit,
3653 to make a bit faster and to avoid GCC 4.6.0 warning.
3654 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3655
3656 * fns.c (internal_equal): Don't assume size_t fits in int.
3657
3658 * alloc.c (compact_small_strings): Tighten assertion a little.
3659
3660 Replace pEd with more-general pI, and fix some printf arg casts.
3661 * lisp.h (pI): New macro, generalizing old pEd macro to other
3662 conversion specifiers. For example, use "...%"pI"d..." rather
3663 than "...%"pEd"...".
3664 (pEd): Remove. All uses replaced with similar uses of pI.
3665 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3666 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3667 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3668 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3669 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3670 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3671 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3672 64-bit hosts.
3673 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3674 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3675 * print.c (safe_debug_print, print_object): Likewise.
3676 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3677 to int.
3678 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3679 avoiding the 0 flag, which is not portable.
3680 * process.c (Fmake_network_process): Use pI to avoid cast.
3681 * region-cache.c (pp_cache): Likewise.
3682 * xdisp.c (decode_mode_spec): Likewise.
3683 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3684 behavior on 64-bit hosts with printf arg.
3685 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3686 (x_stop_queuing_selection_requests): Likewise.
3687 (x_get_window_property): Don't truncate byte count to an 'int'
3688 when tracing.
3689
3690 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3691 here, since it parses constructs like leading '-' and spaces,
3692 which are not wanted; and it overflows with large numbers.
3693 Instead, simply match F[0-9]+, which is what is wanted anyway.
3694
3695 * alloc.c: Remove unportable assumptions about struct layout.
3696 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3697 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3698 (allocate_vectorlike, make_pure_vector): Use the new macros,
3699 plus offsetof, to remove unportable assumptions about struct layout.
3700 These assumptions hold on all porting targets that I know of, but
3701 they are not guaranteed, they're easy to remove, and removing them
3702 makes further changes easier.
3703
3704 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3705 This doesn't fix a bug but makes the code clearer.
3706 (string_overrun_cookie): Now const. Use initializers that
3707 don't formally overflow signed char, to avoid warnings.
3708 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3709 can cause Emacs to crash when string overrun checking is enabled.
3710 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3711 multiple of sizeof (EMACS_INT); it need not be, if
3712 alignof(EMACS_INT) < sizeof (EMACS_INT).
3713 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3714
3715 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3716
3717 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3718
3719 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3720
3721 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3722 supposed to be handshaking. (Bug#8556)
3723 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3724
3725 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3726
3727 * lisp.h (Qdebug): List symbol.
3728 * eval.c (Qdebug): Restore global linkage.
3729 * keyboard.c (debug-on-event): New variable.
3730 (handle_user_signal): Break into debugger when debug-on-event
3731 matches the current signal symbol.
3732
3733 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3734
3735 * alloc.c (check_sblock, check_string_bytes)
3736 (check_string_free_list): Convert to standard C.
3737
3738 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3739
3740 * w32.c (emacs_gnutls_push): Fix typo.
3741
3742 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3743
3744 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3745 "cast to pointer from integer of different size".
3746
3747 Improve doprnt and its use in verror. (Bug#8545)
3748 * doprnt.c (doprnt): Document the set of format control sequences
3749 supported by the function. Use SAFE_ALLOCA instead of always
3750 using `alloca'.
3751
3752 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3753 is one byte too soon. Don't use xrealloc; instead xfree and
3754 xmalloc anew.
3755
3756 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3757
3758 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3759 callbacks stage.
3760
3761 * gnutls.c: Renamed global_initialized to
3762 gnutls_global_initialized. Added internals for the
3763 :verify-hostname-error, :verify-error, and :verify-flags
3764 parameters of `gnutls-boot' and documented those parameters in the
3765 docstring. Start callback support.
3766 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3767 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3768 on error. Return error code.
3769 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3770 (emacs_gnutls_read): Likewise.
3771 (Fgnutls_boot): Return handshake error code.
3772 (emacs_gnutls_handle_error): New function.
3773 (wsaerror_to_errno): Likewise.
3774
3775 * w32.h (emacs_gnutls_pull): Add prototype.
3776 (emacs_gnutls_push): Likewise.
3777
3778 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3779 (emacs_gnutls_push): Likewise.
3780
3781 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3782
3783 * process.c (wait_reading_process_output): Check if GnuTLS
3784 buffered some data internally if no FDs are set for TLS
3785 connections.
3786
3787 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3788 (LIBS): Link to USER_LIBS.
3789 ($(BLD)/gnutls.$(0)): New target.
3790
3791 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3792
3793 * xdisp.c (handle_single_display_spec): Rename the
3794 display_replaced_before_p argument into display_replaced_p, to
3795 make it consistent with the commentary. Fix typos in the
3796 commentary.
3797
3798 * textprop.c (syms_of_textprop): Remove dead code.
3799 (copy_text_properties): Delete obsolete commentary about an
3800 interface that was deleted long ago. Fix typos in the description
3801 of arguments.
3802
3803 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3804 to changes in oldXMenu/XMenu.h from 2011-04-16.
3805 <menu_help_message, prev_menu_help_message>: Constify.
3806 (IT_menu_make_room): menu->help_text is now `const char **';
3807 adjust.
3808
3809 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3810 to changes in oldXMenu/XMenu.h from 2011-04-16.
3811 (struct XMenu): Declare `help_text' `const char **'.
3812
3813 * xfaces.c <Qunspecified>: Make extern again.
3814
3815 * syntax.c: Include sys/types.h before including regex.h, as
3816 required by Posix.
3817
3818 * doc.c (get_doc_string): Improve the format passed to `error'.
3819
3820 * doprnt.c (doprnt): Improve commentary.
3821
3822 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3823
3824 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3825 them with etags.
3826
3827 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3828 changes in globals.h immediately force recompilation.
3829 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3830 $(CURDIR)/s/ms-w32.h.
3831 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3832
3833 * character.c (Fchar_direction): Function deleted.
3834 (syms_of_character): Don't defsubr it.
3835 <char-direction-table>: Deleted.
3836
3837 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3838
3839 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3840 * doprnt.c: Include limits.h.
3841 (SIZE_MAX): New macro.
3842 (doprnt): Return a size_t value. 2nd arg is now size_t.
3843 Many local variables are now size_t instead of int or unsigned.
3844 Improve overflow protection. Support `l' modifier for integer
3845 conversions. Support %l conversion. Don't assume an EMACS_INT
3846 argument for integer conversions and for %c.
3847
3848 * lisp.h (doprnt): Restore prototype.
3849
3850 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3851 $(SRC)/character.h.
3852
3853 * Makefile.in (base_obj): Add back doprnt.o.
3854
3855 * deps.mk (doprnt.o): Add back prerequisites.
3856 (callint.o): Depend on character.h.
3857
3858 * eval.c (internal_lisp_condition_case): Include the handler
3859 representation in the error message.
3860 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3861 when breaking from the loop.
3862
3863 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3864
3865 * callint.c (Fcall_interactively): When displaying error message
3866 about invalid control letter, pass the character's codepoint, not
3867 a pointer to its multibyte form. Improve display of the character
3868 in octal and display also its hex code.
3869
3870 * character.c (char_string): Use %x to display the (unsigned)
3871 codepoint of an invalid character, to avoid displaying a bogus
3872 negative value.
3873
3874 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3875 `error', not SYMBOL_NAME itself.
3876
3877 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3878 character arguments to `error'.
3879
3880 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3881 to `error' in error message about FINAL_CHAR argument. Make sure
3882 FINAL_CHAR is a character, and use %c when it is passed as
3883 argument to `error'.
3884
3885 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3886
3887 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3888
3889 * w32.c: Include <time.h>.
3890 (sys_localtime): New function.
3891
3892 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3893
3894 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3895
3896 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3897
3898 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3899
3900 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3901 zombies (Bug#8467).
3902
3903 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3904
3905 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3906 gl_state.e_property when gl_state.object is Qt.
3907
3908 * insdel.c (make_gap_larger): Remove limitation of buffer size
3909 to <= INT_MAX.
3910
3911 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3912
3913 * xdisp.c (lookup_glyphless_char_display)
3914 (produce_glyphless_glyph): Handle cons cell entry in
3915 glyphless-char-display.
3916 (Vglyphless_char_display): Document it.
3917
3918 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3919 glyphless-char-display.
3920
3921 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3922
3923 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3924
3925 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3926
3927 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3928 definition for no-X builds.
3929
3930 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3931
3932 Static checks with GCC 4.6.0 and non-default toolkits.
3933
3934 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3935
3936 * process.c (keyboard_bit_set): Define only if SIGIO.
3937 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3938 (send_process): Repair possible setjmp clobbering.
3939
3940 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3941
3942 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3943
3944 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3945
3946 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3947 Define only if needed.
3948
3949 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3950 by pacifying GCC about it. Maybe it's time to retire it?
3951 * xfaces.c (USG, __TIMEVAL__): Likewise.
3952
3953 * dispextern.h (struct redisplay_interface): Rename param
3954 to avoid shadowing.
3955 * termhooks.h (struct terminal): Likewise.
3956 * xterm.c (xembed_send_message): Likewise.
3957
3958 * insdel.c (make_gap_smaller): Define only if
3959 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3960
3961 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3962 it.
3963
3964 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3965 so that we aren't warned about unused symbols.
3966
3967 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3968
3969 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3970
3971 * xfns.c (x_real_positions): Mark locals as initialized.
3972
3973 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3974
3975 * xterm.c: Fix problems found by static analysis with other toolkits.
3976 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3977 (x_dispatch_event): Declare static if USE_GTK, and
3978 define if USE_GTK || USE_X_TOOLKIT.
3979 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3980 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3981 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3982 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3983
3984 * xmenu.c (menu_help_callback): Pointer type fixes.
3985 Use const pointers when pointing at readonly data. Avoid pointer
3986 signedness clashes.
3987 (FALSE): Remove unused macro.
3988 (update_frame_menubar): Remove unused decl.
3989
3990 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3991
3992 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3993 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3994 (single_menu_item): Rename local to avoid shadowing.
3995
3996 * keyboard.c (make_lispy_event): Remove unused local var.
3997
3998 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3999 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4000
4001 * bitmaps: Change bitmaps from unsigned char back to the X11
4002 compatible char. Avoid the old compiler warnings about
4003 out-of-range initializers by using, for example, '\xab' rather
4004 than 0xab.
4005
4006 * xgselect.c (xgselect_initialize): Check vs interface
4007 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4008
4009 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4010
4011 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4012 to read-only memory.
4013
4014 * fns.c (vector): Remove; this old hack is no longer needed.
4015
4016 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4017 Remove unused var.
4018 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4019
4020 * xrdb.c (x_load_resources): Omit unused local.
4021
4022 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4023 (x_window): Rename locals to avoid shadowing.
4024 (USG): Use the kludged USG macro, to pacify gcc.
4025
4026 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4027 (x_term_init): Remove local to avoid shadowing.
4028
4029 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4030
4031 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4032 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4033
4034 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4035
4036 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4037
4038 Fix regex.c, syntax.c and friends for buffers > 2GB.
4039 * syntax.h (struct gl_state_s): Declare character position members
4040 EMACS_INT.
4041
4042 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4043
4044 * textprop.c (verify_interval_modification, interval_of):
4045 Declare arguments EMACS_INT.
4046
4047 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4048 EMACS_INT.
4049
4050 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4051
4052 * indent.c (Fvertical_motion): Local variable it_start is now
4053 EMACS_INT.
4054
4055 * regex.c (re_match, re_match_2, re_match_2_internal)
4056 (bcmp_translate, regcomp, regexec, print_double_string)
4057 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4058 (re_compile_pattern, re_exec): Declare arguments and local
4059 variables `size_t' and `ssize_t' and return values `regoff_t', as
4060 appropriate.
4061 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4062 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4063 <compile_stack_type>: `size' and `avail' are now `size_t'.
4064
4065 * regex.h <regoff_t>: Use ssize_t, not int.
4066 (re_search, re_search_2, re_match, re_match_2): Arguments that
4067 specify buffer/string position and length are now ssize_t and
4068 size_t. Return type is regoff_t.
4069
4070 2011-04-16 Ben Key <bkey76@gmail.com>
4071
4072 * nsfont.m: Fixed bugs in ns_get_family and
4073 ns_descriptor_to_entity that were caused by using free to
4074 deallocate memory blocks that were allocated by xmalloc (via
4075 xstrdup). This caused Emacs to crash when compiled with
4076 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4077 --enable-checking=xmallocoverrun). xfree is now used to
4078 deallocate these memory blocks.
4079
4080 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4081
4082 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4083
4084 emacs_write: Accept and return EMACS_INT for sizes.
4085 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4086 et seq.
4087 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4088 Accept and return EMACS_INT.
4089 (emacs_gnutls_write): Return the number of bytes written on
4090 partial writes.
4091 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4092 (emacs_read, emacs_write): Remove check for negative size, as the
4093 Emacs source code has been audited now.
4094 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4095 (emacs_read, emacs_write): Use it.
4096 * process.c (send_process): Adjust to the new signatures of
4097 emacs_write and emacs_gnutls_write. Do not attempt to store
4098 a byte offset into an 'int'; it might overflow.
4099 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4100
4101 * sound.c: Don't assume sizes fit in 'int'.
4102 (struct sound_device.period_size, alsa_period_size):
4103 Return EMACS_INT, not int.
4104 (struct sound_device.write, vox_write, alsa_write):
4105 Accept EMACS_INT, not int.
4106 (wav_play, au_play): Use EMACS_INT to store sizes and to
4107 record read return values.
4108
4109 2011-04-15 Ben Key <bkey76@gmail.com>
4110
4111 * keyboard.c (Qundefined): Don't declare static since it is used
4112 in nsfns.m.
4113 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4114 static since they are used in nsfont.m.
4115
4116 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4117
4118 * process.c (Qprocessp): Don't declare static.
4119 * lisp.h (Qprocessp): Declare again.
4120
4121 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4122
4123 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4124
4125 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4126
4127 Improve C-level modularity by making more things 'static'.
4128
4129 Don't publish debugger-only interfaces to other modules.
4130 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4131 (verify_bytepos, count_markers): Move decls to the only modules
4132 that need them.
4133 * region-cache.h (pp_cache): Likewise.
4134 * window.h (check_all_windows): Likewise.
4135 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4136
4137 * sysdep.c (croak): Now static, if
4138 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4139 * syssignal.h (croak): Declare only if not static.
4140
4141 * alloc.c (refill_memory_reserve): Now static if
4142 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4143 * lisp.h (refill_memory_reserve): Declare only if not static.
4144
4145 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4146 Define only if USE_LUCID.
4147
4148 * xrdb.c (x_customization_string, x_rm_string): Now static.
4149
4150 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4151 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4152
4153 * xdisp.c (draw_row_with_mouse_face): Now static.
4154 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4155
4156 * window.h (check_all_windows): Mark externally visible.
4157
4158 * window.c (window_deletion_count): Now static.
4159
4160 * undo.c: Make symbols static if they're not exported.
4161 (last_undo_buffer, last_boundary_position, pending_boundary):
4162 Now static.
4163
4164 * textprop.c (interval_insert_behind_hooks): Now static.
4165 (interval_insert_in_front_hooks): Likewise.
4166
4167 * term.c: Make symbols static if they're not exported.
4168 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4169 (max_frame_lines, tty_set_terminal_modes):
4170 (tty_reset_terminal_modes, tty_turn_off_highlight):
4171 (get_tty_terminal): Now static.
4172 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4173 * termhooks.h (term_mouse_moveto): Do not declare if
4174 HAVE_WINDOW_SYSTEM.
4175 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4176 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4177
4178 * sysdep.c: Make symbols static if they're not exported.
4179 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4180 Now static.
4181 (sigprocmask_set, full_mask): Remove; unused.
4182 (wait_debugging): Mark as visible.
4183 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4184 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4185
4186 * syntax.c (syntax_temp): Define only if !__GNUC__.
4187
4188 * sound.c (current_sound_device, current_sound): Now static.
4189
4190 * search.c (searchbufs, searchbuf_head): Now static.
4191
4192 * scroll.c (scroll_cost): Remove; unused.
4193 * dispextern.h (scroll_cost): Remove decl.
4194
4195 * region-cache.h (pp_cache): Mark as externally visible.
4196
4197 * process.c: Make symbols static if they're not exported.
4198 (process_tick, update_tick, create_process, chan_process):
4199 (Vprocess_alist, proc_buffered_char, datagram_access):
4200 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4201 (deactivate_process): Mark defn as static, as well as decl.
4202 * lisp.h (create_process): Remove decl.
4203 * process.h (chan_process, Vprocess_alist): Remove decls.
4204
4205 * print.c: Make symbols static if they're not exported.
4206 (print_depth, new_backquote_output, being_printed, print_buffer):
4207 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4208 (print_interval, print_number_index, initial_stderr_stream):
4209 Now static.
4210 * lisp.h (Fprinc): Remove decl.
4211 (debug_output_compilation_hack): Mark as externally visible.
4212
4213 * sysdep.c (croak): Move decl from here to syssignal.h.
4214 * syssignal.h (croak): Put it here, so the API can be checked when
4215 'croak' is called from dissociate_if_controlling_tty.
4216
4217 * minibuf.c: Make symbols static if they're not exported.
4218 (minibuf_save_list, choose_minibuf_frame): Now static.
4219 * lisp.h (choose_minibuf_frame): Remove decl.
4220
4221 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4222
4223 * lread.c: Make symbols static if they're not exported.
4224 (read_objects, initial_obarray, oblookup_last_bucket_number):
4225 Now static.
4226 (make_symbol): Remove; unused.
4227 * lisp.h (initial_obarray, make_symbol): Remove decls.
4228
4229 * keyboard.c: Make symbols static if they're not exported.
4230 (single_kboard, recent_keys_index, total_keys, recent_keys):
4231 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4232 (this_single_command_key_start, echoing, last_auto_save):
4233 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4234 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4235 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4236 (Vlispy_mouse_stem, double_click_count):
4237 Now static.
4238 (force_auto_save_soon): Define only if SIGDANGER.
4239 (ignore_mouse_drag_p): Now static if
4240 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4241 (print_help): Remove; unused.
4242 (stop_character, last_timer_event): Mark as externally visible.
4243 * keyboard.h (ignore_mouse_drag_p): Declare only if
4244 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4245 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4246 * lisp.h (echoing): Remove decl.
4247 (force_auto_save_soon): Declare only if SIGDANGER.
4248 * xdisp.c (redisplay_window): Simplify code, to make it more
4249 obvious that ignore_mouse_drag_p is not accessed if !defined
4250 USE_GTK && !defined HAVE_NS.
4251
4252 * intervals.c: Make symbols static if they're not exported.
4253 (merge_properties_sticky, merge_interval_right, delete_interval):
4254 Now static.
4255 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4256
4257 * insdel.c: Make symbols static if they're not exported.
4258 However, leave prepare_to_modify_buffer alone. It's never
4259 called from outside this function, but that appears to be a bug.
4260 (combine_after_change_list, combine_after_change_buffer):
4261 (adjust_after_replace, signal_before_change): Now static.
4262 (adjust_after_replace_noundo): Remove; unused.
4263 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4264 (signal_before_change): Remove decls.
4265
4266 * indent.c (val_compute_motion, val_vmotion): Now static.
4267
4268 * image.c: Make symbols static if they're not exported.
4269 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4270 if USE_GTK.
4271 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4272 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4273
4274 * fringe.c (standard_bitmaps): Now static.
4275 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4276
4277 * frame.c: Make symbols static if they're not exported.
4278 (x_report_frame_params, make_terminal_frame): Now static.
4279 (get_frame_param): Now static, unless HAVE_NS.
4280 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4281 (x_get_resource_string): Remove; not used.
4282 * frame.h (make_terminal_frame, x_report_frame_params):
4283 (x_get_resource_string); Remove decls.
4284 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4285 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4286
4287 * font.c, fontset.c: Make symbols static if they're not exported.
4288 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4289 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4290 * font.c (font_close_object): Now static.
4291 * font.h (font_close_object): Remove.
4292 * fontset.c (FONTSET_OBJLIST): Remove.
4293 (free_realized_fontset) #if-0 the body, which does nothing.
4294 (face_suitable_for_char_p): #if-0, as it's never called.
4295 * fontset.h (face_suitable_for_char_p): Remove decl.
4296 * xfaces.c (face_at_string_position):
4297 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4298 since 0 is always ASCII.
4299
4300 * fns.c (weak_hash_tables): Now static.
4301
4302 * fileio.c: Make symbols static if they're not exported.
4303 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4304 (Vwrite_region_annotation_buffers): Now static.
4305
4306 * eval.c: Make symbols static if they're not exported.
4307 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4308 * lisp.h (backtrace_list): Remove decl.
4309
4310 * emacs.c: Make symbols static if they're not exported.
4311 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4312 (fatal_error_code, fatal_error_signal_hook, standard_args):
4313 Now static.
4314 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4315 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4316 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4317 * lisp.h (fatal_error_signal_hook): Remove decl.
4318 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4319
4320 * editfns.c: Move a (normally-unused) function to its only use.
4321 * editfns.c, lisp.h (get_operating_system_release): Remove.
4322 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4323 worth the hassle of breaking this out.
4324
4325 * xterm.c: Make symbols static if they're not exported.
4326 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4327 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4328 (x_destroy_window, x_delete_display):
4329 Now static.
4330 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4331 (x_mouse_leave): Remove; unused.
4332 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4333 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4334 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4335 Remove decls.
4336 (x_mouse_leave): Declare only if WINDOWSNT.
4337 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4338 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4339 USE_X_TOOLKIT.
4340
4341 * ftxfont.c: Make symbols static if they're not exported.
4342 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4343 HAVE_FREETYPE.
4344 * font.h (ftxfont_driver): Likewise.
4345
4346 * xfns.c: Make symbols static if they're not exported.
4347 (x_last_font_name, x_display_info_for_name):
4348 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4349 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4350 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4351 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4352 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4353 (last_show_tip_args): Now static.
4354 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4355 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4356 (x_screen_planes): Remove; unused.
4357 * dispextern.h (x_screen_planes): Remove decl.
4358
4359 * dispnew.c: Make symbols static if they're not exported.
4360 * dispextern.h (redraw_garbaged_frames, scrolling):
4361 (increment_row_positions): Remove.
4362 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4363 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4364 Now static.
4365 (redraw_garbaged_frames): Remove; unused.
4366
4367 * xfaces.c: Make symbols static if they're not exported.
4368 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4369 Remove decls.
4370 * xterm.h (defined_color): Remove decls.
4371 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4372 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4373 (menu_face_changed_default, defined_color, free_realized_face):
4374 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4375 (ascii_face_of_lisp_face): Remove; unused.
4376
4377 * xdisp.c: Make symbols static if they're not exported.
4378 * dispextern.h (scratch_glyph_row, window_box_edges):
4379 (glyph_to_pixel_coords, set_cursor_from_row):
4380 (get_next_display_element, set_iterator_to_next):
4381 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4382 (show_mouse_face): Remove decls
4383 * frame.h (message_buf_print): Likewise.
4384 * lisp.h (pop_message, set_message, check_point_in_composition):
4385 Likewise.
4386 * xterm.h (set_vertical_scroll_bar): Likewise.
4387 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4388 (message_buf_print, scratch_glyph_row, displayed_buffer):
4389 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4390 (get_next_display_element, show_mouse_face, window_box_edges):
4391 (frame_to_window_pixel_xy, check_point_in_composition):
4392 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4393 (glyph_to_pixel_coords): Remove; unused.
4394
4395 * dired.c (file_name_completion): Now static.
4396
4397 * dbusbind.c (xd_in_read_queued_messages): Now static.
4398
4399 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4400 * data.c (circular_list_error): Remove.
4401
4402 * commands.h (last_point_position, last_point_position_buffer):
4403 (last_point_position_window): Remove decls.
4404 * keyboard.c: Make these variables static.
4405
4406 * coding.h (coding, code_convert_region, encode_coding_gap):
4407 Remove decls.
4408 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4409 (iso_code_class, detect_coding, code_convert_region): Now static.
4410 (encode_coding_gap): Remove; unused.
4411
4412 * chartab.c (chartab_chars, chartab_bits): Now static.
4413
4414 * charset.h (charset_iso_8859_1): Remove decl.
4415 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4416 Now static.
4417
4418 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4419 * ccl.c (Vccl_program_table): Now static.
4420 (check_ccl_update): Remove; unused.
4421
4422 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4423 * category.h: ... from here.
4424 * category.c (check_category_table, set_category_set): Now static.
4425
4426 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4427 * lisp.h: Remove these decls.
4428
4429 * buffer.c (buffer_count): Remove unused var.
4430
4431 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4432 so that it's not optimized away.
4433 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4434 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4435 exported only to the debugger.
4436
4437 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4438 * atimer.h (run_all_atimers): Remove; not exported.
4439
4440 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4441 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4442 was inaccessible from Lisp.
4443 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4444 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4445
4446 alloc.c: Import and export fewer symbols, and remove unused items.
4447 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4448 is defined.
4449 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4450 it's not optimized away by whole-program optimization.
4451 (message_enable_multibyte, free_misc): Remove.
4452 (catchlist, handlerlist, mark_backtrace):
4453 Declare only if BYTE_MARK_STACK.
4454 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4455 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4456 (message_enable_multibyte): Remove decl.
4457 (free_misc, interval_free_list, float_block, float_block_index):
4458 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4459 (cons_free_list, last_marked_index):
4460 Now static.
4461 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4462 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4463 (mark_backtrace): Define only if BYTE_MARK_STACK.
4464 * xdisp.c (message_enable_multibyte): Now static.
4465
4466 Declare Lisp_Object Q* variables to be 'static' if not exported.
4467 This makes it easier for human readers (and static analyzers)
4468 to see whether these variables are used from other modules.
4469 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4470 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4471 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4472 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4473 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4474 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4475 * xmenu.c, xselect.c:
4476 Declare Q* vars static if they are not used in other modules.
4477 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4478 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4479 Remove decls of unexported vars.
4480 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4481
4482 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4483
4484 Make Emacs functions such as Fatom 'static' by default.
4485 This makes it easier for human readers (and static analyzers)
4486 to see whether these functions can be called from other modules.
4487 DEFUN now defines a static function. To make the function external
4488 so that it can be used in other C modules, use the new macro DEFUE.
4489 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4490 (Finit_image_library):
4491 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4492 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4493 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4494 Remove decls, since these functions are now static.
4495 (Funintern, Fget_internal_run_time): New decls, since these functions
4496 were already external.
4497
4498 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4499 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4500 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4501 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4502 * keyboard.c, keymap.c, lread.c:
4503 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4504 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4505 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4506 Mark functions with DEFUE instead of DEFUN,
4507 if they are used in other modules.
4508 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4509 decls for now-static functions.
4510 * buffer.h (Fdelete_overlay): Remove decl.
4511 * callproc.c (Fgetenv_internal): Mark as internal.
4512 * composite.c (Fremove_list_of_text_properties): Remove decl.
4513 (Fcomposition_get_gstring): New forward static decl.
4514 * composite.h (Fcomposite_get_gstring): Remove decl.
4515 * dired.c (Ffile_attributes): New forward static decl.
4516 * doc.c (Fdocumntation_property): New forward static decl.
4517 * eval.c (Ffetch_bytecode): New forward static decl.
4518 (Funintern): Remove extern decl; now in .h file where it belongs.
4519 * fileio.c (Fmake_symbolic_link): New forward static decl.
4520 * image.c (Finit_image_library): New forward static decl.
4521 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4522 * intervals.h (Fprevious_property_change):
4523 (Fremove_list_of_text_properties): Remove decls.
4524 * keyboard.c (Fthis_command_keys): Remove decl.
4525 (Fcommand_execute): New forward static decl.
4526 * keymap.c (Flookup_key): New forward static decl.
4527 (Fcopy_keymap): Now static.
4528 * keymap.h (Flookup_key): Remove decl.
4529 * process.c (Fget_process): New forward static decl.
4530 (Fprocess_datagram_address): Mark as internal.
4531 * syntax.c (Fsyntax_table_p): New forward static decl.
4532 (skip_chars): Remove duplicate decl.
4533 * textprop.c (Fprevious_property_change): New forward static decl.
4534 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4535 Now internal.
4536 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4537 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4538
4539 * editfns.c (Fformat): Remove unreachable code.
4540
4541 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4542
4543 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4544 change. (Bug#8496)
4545
4546 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4547
4548 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4549 when at ZV. (Bug#8487)
4550
4551 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4552
4553 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4554 (Bug#8437)
4555 * keyboard.c (parse_tool_bar_item): Likewise.
4556 * sound.c (sound_cleanup, alsa_close): Likewise.
4557 * termcap.c (tgetent): Likewise.
4558 * xfns.c (x_default_font_parameter): Likewise.
4559 * xsettings.c (read_and_apply_settings): Likewise.
4560
4561 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4562 (overrun_check_free): Protoize.
4563
4564 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4565
4566 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4567 since callers should never pass a negative size.
4568 Change the signature to match that of plain 'read' and 'write'; see
4569 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4570 * lisp.h: Update prototypes of emacs_write and emacs_read.
4571
4572 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4573
4574 * xdisp.c (redisplay_window): Don't try to determine the character
4575 position of the scroll margin if the window start point w->startp
4576 is outside the buffer's accessible region. (Bug#8468)
4577
4578 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4579
4580 Fix write-region and its subroutines for buffers > 2GB.
4581 * fileio.c (a_write, e_write): Modify declaration of arguments and
4582 local variables to support buffers larger than 2GB.
4583 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4584
4585 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4586 argument, local variables, and return value.
4587
4588 * lisp.h: Update prototypes of emacs_write and emacs_read.
4589
4590 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4591
4592 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4593
4594 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4595
4596 Fix more problems found by GCC 4.6.0's static checks.
4597
4598 * xdisp.c (vmessage): Use a better test for character truncation.
4599
4600 * charset.c (load_charset_map): <, not <=, for optimization,
4601 and to avoid potential problems with integer overflow.
4602 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4603 * casetab.c (set_identity, shuffle): Likewise.
4604 * editfns.c (Fformat): Likewise.
4605 * syntax.c (skip_chars): Likewise.
4606
4607 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4608 This also lets GCC 4.6.0 generate slightly better loop code.
4609
4610 * callint.c (Fcall_interactively): <, not <=, for optimization.
4611 (Fcall_interactively): Count the number of arguments produced,
4612 not the number of arguments given. This is simpler and lets GCC
4613 4.6.0 generate slightly better code.
4614
4615 * ftfont.c: Distingish more carefully between FcChar8 and char.
4616 The previous code passed unsigned char * to a functions like
4617 strlen and xstrcasecmp that expect char *, which does not
4618 conform to the C standard.
4619 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4620 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4621 char * when the C standard requires it.
4622
4623 * keyboard.c (read_char): Remove unused var.
4624
4625 * eval.c: Port to Windows vsnprintf (Bug#8435).
4626 Include <limits.h>.
4627 (SIZE_MAX): Define if the headers do not.
4628 (verror): Do not give up if vsnprintf returns a negative count.
4629 Instead, grow the buffer. This ports to Windows vsnprintf, which
4630 does not conform to C99. Problem reported by Eli Zaretskii.
4631 Also, simplify the allocation scheme, by avoiding the need for
4632 calling realloc, and removing the ALLOCATED variable.
4633
4634 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4635
4636 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4637 But keep the doprint source code for now, as we might revamp it
4638 and use it again (Bug#8435).
4639 * lisp.h (doprnt): Remove.
4640 * Makefile.in (base_obj): Remove doprnt.o.
4641 * deps.mk (doprnt.o): Remove.
4642
4643 error: Print 32- and 64-bit integers portably (Bug#8435).
4644 Without this change, on typical 64-bit hosts error ("...%d...", N)
4645 was used to print both 32- and 64-bit integers N, which relied on
4646 undefined behavior.
4647 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4648 New macro.
4649 * lisp.h (error, verror): Mark as printf-like functions.
4650 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4651 Report overflow in size calculations when allocating printf buffer.
4652 Do not truncate output string at its first null byte.
4653 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4654 Truncate the output at a character boundary, since vsnprintf does not
4655 do that.
4656 * charset.c (check_iso_charset_parameter): Convert internal
4657 character to string before calling 'error', since %c now has the
4658 printf meaning.
4659 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4660 overflow when computing char to be passed to 'error'. Do not
4661 pass Lisp_Object to 'error'; pass the integer instead.
4662 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4663 formatted with plain %d.
4664
4665 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4666
4667 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4668
4669 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4670
4671 * xterm.c (x_catch_errors): Remove duplicate declaration.
4672
4673 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4674
4675 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4676
4677 2011-04-10 Jim Meyering <meyering@redhat.com>
4678
4679 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4680 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4681 return ssize_t not "int", and use size_t as the buffer length.
4682 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4683 * gnutls.h: Update declarations.
4684 * process.c (read_process_output): Use ssize_t, to match.
4685 (send_process): Likewise.
4686
4687 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4688
4689 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4690
4691 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4692
4693 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4694 Use unsigned char, to match FcChar8 type definition.
4695
4696 * xterm.c (handle_one_xevent):
4697 * xmenu.c (create_and_show_popup_menu):
4698 * xselect.c (x_decline_selection_request)
4699 (x_reply_selection_request): Avoid type-punned deref of X events.
4700
4701 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4702
4703 Fix some uses of `int' instead of EMACS_INT.
4704 * search.c (string_match_1, fast_string_match)
4705 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4706 (scan_buffer, find_next_newline_no_quit)
4707 (find_before_next_newline, search_command, Freplace_match)
4708 (Fmatch_data): Make some `int' variables be EMACS_INT.
4709
4710 * xdisp.c (display_count_lines): 3rd argument and return value now
4711 EMACS_INT. All callers changed.
4712 (pint2hrstr): Last argument is now EMACS_INT.
4713
4714 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4715 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4716 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4717 (decode_coding_utf_16, decode_coding_emacs_mule)
4718 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4719 (decode_coding_ccl, decode_coding_charset)
4720 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4721 (decode_coding_iso_2022, decode_coding_emacs_mule)
4722 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4723 <char_offset, last_offset>: Declare EMACS_INT.
4724 (encode_coding_utf_8, encode_coding_utf_16)
4725 (encode_coding_emacs_mule, encode_invocation_designation)
4726 (encode_designation_at_bol, encode_coding_iso_2022)
4727 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4728 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4729 Declare EMACS_INT.
4730 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4731 (encode_invocation_designation): Last argument P_NCHARS is now
4732 EMACS_INT.
4733 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4734 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4735
4736 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4737 All users changed.
4738
4739 * ccl.c (Fccl_execute_on_string): Declare some variables
4740 EMACS_INT.
4741
4742 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4743
4744 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4745
4746 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4747
4748 * process.c (Fformat_network_address): Doc fix.
4749
4750 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4751
4752 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4753
4754 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4755
4756 * keyboard.c (read_char): Call Lisp function help-form-show,
4757 instead of using internal_with_output_to_temp_buffer.
4758 (Qhelp_form_show): New var.
4759 (syms_of_keyboard): Use DEFSYM macro.
4760
4761 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4762
4763 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4764
4765 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4766
4767 * process.c (Flist_processes): Remove to Lisp.
4768 (list_processes_1): Delete.
4769
4770 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4771
4772 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4773
4774 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4775
4776 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4777
4778 Fix more problems found by GCC 4.6.0's static checks.
4779
4780 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4781
4782 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4783
4784 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4785
4786 * xdisp.c (vmessage): Mark as a printf-like function.
4787
4788 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4789
4790 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4791
4792 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4793 printf-like functions.
4794 (tiff_load): Add casts to remove these marks before passing them
4795 to system-supplied API.
4796
4797 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4798
4799 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4800 This avoids several warnings with gcc -Wstrict-overflow.
4801 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4802 directly, rather than having caller test rule sign. This avoids
4803 some unnecessary tests.
4804 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4805 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4806 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4807
4808 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4809 (xfont_open): Avoid unnecessary tests.
4810
4811 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4812
4813 * composite.h, composite.c (composition_gstring_put_cache):
4814 Use EMACS_INT, not int, for length.
4815
4816 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4817 breaking out part of COMPOSITION_DECODE_RULE.
4818 (COMPOSITION_DECODE_RULE): Use it.
4819 * composite.c (get_composition_id): Remove unused local vars,
4820 by using the new macro.
4821
4822 * textprop.c (set_text_properties_1): Change while to do-while,
4823 since the condition is always true at first.
4824
4825 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4826 (interval_deletion_adjustment): Return unsigned value.
4827 All uses changed.
4828
4829 * process.c (list_processes_1, create_pty, read_process_output):
4830 (exec_sentinel): Remove vars that were set but not used.
4831 (create_pty): Remove unnecessary "volatile"s.
4832 (Fnetwork_interface_info): Avoid possibility of int overflow.
4833 (read_process_output): Do adaptive read buffering even if carryover.
4834 (read_process_output): Simplify nbytes computation if buffered.
4835
4836 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4837
4838 * syntax.c (scan_words): Remove var that was set but not used.
4839 (update_syntax_table): Use unsigned instead of int.
4840
4841 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4842 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4843 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4844
4845 * print.c (print_error_message): Avoid int overflow.
4846
4847 * font.c (font_list_entities): Redo for clarity,
4848 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4849
4850 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4851 (font_score): Avoid potential overflow in diff calculation.
4852
4853 * fns.c (substring_both): Remove var that is set but not used.
4854 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4855
4856 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4857
4858 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4859 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4860 can always succeed if overflow has undefined behavior.
4861
4862 * search.c (boyer_moore, wordify): Remove vars set but not used.
4863 (wordify): Omit three unnecessary tests.
4864
4865 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4866 All callers changed. This avoids the need for an unused var.
4867
4868 * casefiddle.c (casify_region): Remove var that is set but not used.
4869
4870 * dired.c (file_name_completion): Remove var that is set but not used.
4871
4872 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4873
4874 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4875 (Finsert_file_contents): Remove unnecessary code checking fd.
4876
4877 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4878 Check for integer overflow on size calculations.
4879
4880 * buffer.c (Fprevious_overlay_change): Remove var that is set
4881 but not used.
4882
4883 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4884 Remove vars that are set but not used.
4885 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4886 (timer_check_2): Mark vars as initialized.
4887
4888 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4889
4890 * image.c (lookup_image): Remove var that is set but not used.
4891 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4892
4893 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4894 that are set but not used.
4895
4896 * xfns.c (make_invisible_cursor): Don't return garbage
4897 if XCreateBitmapFromData fails (Bug#8410).
4898
4899 * xselect.c (x_get_local_selection, x_handle_property_notify):
4900 Remove vars that are set but not used.
4901
4902 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4903 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4904
4905 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4906 Remove var that is set but not used.
4907 (scroll_bar_windows_size): Now size_t, not int.
4908 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4909 Check for overflow.
4910
4911 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4912 (map_tty_color) [!defined MSDOS]: Likewise.
4913
4914 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4915
4916 * coding.c: Remove vars that are set but not used.
4917 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4918 All callers changed.
4919 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4920 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4921 (decode_coding_charset): Remove vars that are set but not used.
4922
4923 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4924 that is set but not used.
4925
4926 * print.c (print_object): Remove var that is set but not used.
4927
4928 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4929 The gnulib version avoids calling malloc in the usual case,
4930 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4931 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4932 * filelock.c (current_lock_owner): Likewise.
4933 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4934 * sysdep.c: Include allocator.h, careadlinkat.h.
4935 (emacs_no_realloc_allocator): New static constant.
4936 (emacs_readlink): New function.
4937 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4938 ../lib/careadlinkat.h.
4939
4940 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4941
4942 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4943 first non-nil return value).
4944
4945 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4946
4947 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4948 if not defined (Bug#8403).
4949
4950 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4951
4952 * xdisp.c (display_count_lines): Remove parameter `start',
4953 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4954 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4955 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4956 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4957 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4958 and thereabouts. All callers changed.
4959 (get_per_char_metric): Remove parameter `f', unused since
4960 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4961
4962 2011-04-02 Jim Meyering <meyering@redhat.com>
4963
4964 do not dereference NULL upon failed strdup
4965 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4966 (ns_get_family): Likewise.
4967
4968 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4969
4970 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4971
4972 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4973
4974 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4975 later (Bug#8403).
4976
4977 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4978
4979 Add lexical binding.
4980
4981 * window.c (Ftemp_output_buffer_show): New fun.
4982 (Fsave_window_excursion):
4983 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4984
4985 * lread.c (lisp_file_lexically_bound_p): New function.
4986 (Fload): Bind Qlexical_binding.
4987 (readevalloop): Remove `evalfun' arg.
4988 Bind Qinternal_interpreter_environment.
4989 (Feval_buffer): Bind Qlexical_binding.
4990 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4991 Mark as dynamic.
4992 (syms_of_lread): Declare `lexical-binding'.
4993
4994 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4995
4996 * keyboard.c (eval_dyn): New fun.
4997 (menu_item_eval_property): Use it.
4998
4999 * image.c (parse_image_spec): Use Ffunctionp.
5000
5001 * fns.c (concat, mapcar1): Accept byte-code-functions.
5002
5003 * eval.c (Fsetq): Handle lexical vars.
5004 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5005 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5006 (FletX, Flet): Obey lexical binding.
5007 (Fcommandp): Handle closures.
5008 (Feval): New `lexical' arg.
5009 (eval_sub): New function extracted from Feval. Use it almost
5010 everywhere where Feval was used. Look up vars in lexical env.
5011 Handle closures.
5012 (Ffunctionp): Move from subr.el.
5013 (Ffuncall): Handle closures.
5014 (apply_lambda): Remove `eval_flags'.
5015 (funcall_lambda): Handle closures and new byte-code-functions.
5016 (Fspecial_variable_p): New function.
5017 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5018 but without exporting it to Lisp.
5019
5020 * doc.c (Fdocumentation, store_function_docstring):
5021 * data.c (Finteractive_form): Handle closures.
5022
5023 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5024 interactive spec.
5025
5026 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5027 New byte-codes.
5028 (exec_byte_code): New function extracted from Fbyte_code to handle new
5029 calling convention for byte-code-functions. Add new byte-codes.
5030
5031 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5032
5033 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5034
5035 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5036
5037 * xdisp.c (redisplay_internal): Fix prototype.
5038
5039 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5040
5041 * xdisp.c (SCROLL_LIMIT): New macro.
5042 (try_scrolling): Use it when setting scroll_limit.
5043 Limit scrolling to 100 screen lines.
5044 (redisplay_window): Even when falling back on "recentering",
5045 position point in the window according to scroll-conservatively,
5046 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5047
5048 (try_scrolling): When point is above the window, allow searching
5049 as far as scroll_max, or one screenful, to compute vertical
5050 distance from PT to the scroll margin position. This prevents
5051 try_scrolling from unnecessarily failing when
5052 scroll-conservatively is set to a value slightly larger than the
5053 window height. Clean up the case of PT below the margin at bottom
5054 of window: scroll_max can no longer be INT_MAX. When aggressive
5055 scrolling is in use, don't let point enter the opposite scroll
5056 margin as result of the scroll.
5057 (syms_of_xdisp) <scroll-conservatively>: Document the
5058 threshold of 100 lines for never-recentering scrolling.
5059
5060 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5061
5062 * dispextern.h (move_it_by_lines):
5063 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5064 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5065 (message_log_check_duplicate): Remove parameters `prev_bol' and
5066 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5067 (redisplay_internal): Remove parameter `preserve_echo_area',
5068 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5069
5070 * indent.c (Fvertical_motion):
5071 * window.c (window_scroll_pixel_based, Frecenter):
5072 Don't pass `need_y_p' to `move_it_by_lines'.
5073
5074 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5075
5076 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5077 steal a few bits to be more compact.
5078 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5079 Remove unneeded casts.
5080
5081 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5082
5083 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5084
5085 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5086 binding" message (bug#7967).
5087
5088 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5089
5090 Fix more problems found by GCC 4.6.0's static checks.
5091
5092 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5093 Remove unused local var.
5094
5095 * editfns.c (Fmessage_box): Remove unused local var.
5096
5097 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5098 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5099 Omit unused local vars.
5100 * window.c (shrink_windows): Omit unused local var.
5101 * menu.c (digest_single_submenu): Omit unused local var.
5102 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5103 Omit unused local var.
5104
5105 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5106 Don't assume string length fits in int.
5107 (keyremap_step, read_key_sequence): Use size_t for sizes.
5108 (read_key_sequence): Don't check last_real_key_start redundantly.
5109
5110 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5111 instead of alloca (Bug#8344).
5112
5113 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5114 (Fbacktrace_frame): Don't assume nframes fits in int.
5115
5116 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5117
5118 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5119 concerns.
5120
5121 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5122
5123 * cm.c (calccost): Turn while-do into do-while, for clarity.
5124
5125 * keyboard.c (syms_of_keyboard): Use the same style as later
5126 in this function when indexing through an array. This also
5127 works around GCC bug 48267.
5128
5129 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5130
5131 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5132
5133 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5134 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5135
5136 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5137 This avoids undefined behavior on integer overflow, and is a bit
5138 more convenient anyway since it is compared to a size_t variable.
5139
5140 Variadic C functions now count arguments with size_t, not int.
5141 This avoids an unnecessary limitation on 64-bit machines, which
5142 caused (substring ...) to crash on large vectors (Bug#8344).
5143 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5144 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5145 All variadic functions and their callers changed accordingly.
5146 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5147 * data.c (arith_driver, float_arith_driver): Likewise.
5148 * editfns.c (general_insert_function): Likewise.
5149 * eval.c (struct backtrace.nargs, interactive_p)
5150 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5151 (funcall_lambda, mark_backtrace): Likewise.
5152 * fns.c (concat): Likewise.
5153 * frame.c (x_set_frame_parameters): Likewise.
5154 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5155 0 if not found, not -1. All callers changed.
5156
5157 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5158 (stack_copy_size): Now size_t, not int.
5159 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5160
5161 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5162
5163 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5164 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5165 All callers changed.
5166
5167 * lisp.h (multibyte_char_to_unibyte):
5168 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5169 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5170 * character.h (CHAR_TO_BYTE8):
5171 * cmds.c (internal_self_insert):
5172 * editfns.c (general_insert_function):
5173 * keymap.c (push_key_description):
5174 * search.c (Freplace_match):
5175 * xdisp.c (message_dolog, set_message_1): All callers changed.
5176
5177 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5178
5179 * keyboard.c (safe_run_hook_funcall): New function.
5180 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5181 don't set the hook to nil, but remove the offending function instead.
5182 (Qcommand_hook_internal): Remove, unused.
5183 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5184 Vcommand_hook_internal.
5185
5186 * eval.c (enum run_hooks_condition): Remove.
5187 (funcall_nil, funcall_not): New functions.
5188 (run_hook_with_args): Call each function through a `funcall' argument.
5189 Remove `cond' argument, now redundant.
5190 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5191 (Frun_hook_with_args_until_failure): Adjust accordingly.
5192 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5193
5194 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5195
5196 * dispextern.h (string_buffer_position): Remove declaration.
5197
5198 * print.c (strout): Remove parameter `multibyte', unused since
5199 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5200
5201 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5202 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5203 All callers changed.
5204
5205 * w32.c (_wsa_errlist): Use braces for struct initializers.
5206
5207 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5208 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5209 All callers changed.
5210 (string_buffer_position): Likewise. Also, make static (it's never
5211 used outside xdisp.c).
5212 (cursor_row_p): Remove parameter `w', unused since
5213 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5214 (decode_mode_spec): Remove parameter `precision', introduced during
5215 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5216 All callers changed.
5217
5218 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5219
5220 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5221
5222 2011-03-27 Anders Lindgren <andlind@gmail.com>
5223
5224 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5225 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5226 (ns_update_auto_hide_menu_bar): New functions.
5227 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5228 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5229 ns_constrain_all_frames.
5230 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5231 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5232
5233 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5234
5235 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5236
5237 2011-03-27 Glenn Morris <rgm@gnu.org>
5238
5239 * syssignal.h: Replace RETSIGTYPE with void.
5240 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5241 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5242 Replace SIGTYPE with void everywhere.
5243 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5244 * s/template.h (SIGTYPE): Remove commented out definition.
5245
5246 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5247
5248 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5249 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5250
5251 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5252
5253 * w32.c (read_unc_volume): Use parameter `henum', instead of
5254 global variable `wget_enum_handle'.
5255
5256 * keymap.c (describe_vector): Remove parameters `indices' and
5257 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5258 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5259
5260 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5261
5262 * keyboard.c (timer_check): Remove parameter `do_it_now',
5263 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5264 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5265 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5266
5267 * keyboard.c (read_char):
5268 * w32menu.c (w32_menu_display_help):
5269 * xmenu.c (show_help_event, menu_help_callback):
5270 Adjust calls to `show_help_echo'.
5271
5272 * gtkutil.c (xg_maybe_add_timer):
5273 * keyboard.c (readable_events):
5274 * process.c (wait_reading_process_output):
5275 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5276
5277 * insdel.c (adjust_markers_gap_motion):
5278 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5279 (gap_left, gap_right): Don't call it.
5280
5281 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5282
5283 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5284 incurred during fontification.
5285
5286 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5287
5288 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5289 (DEFVAR_PER_BUFFER): Don't pass it.
5290
5291 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5292 (scrolling_window): Don't pass it.
5293
5294 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5295
5296 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5297
5298 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5299 and `suffix'.
5300 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5301 of variables specific to SELinux and computation of `encoded_absname'.
5302
5303 * image.c (XPutPixel): Remove unused variable `height'.
5304
5305 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5306
5307 * unexw32.c (get_section_info): Remove unused variable `section'.
5308
5309 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5310 (system_process_attributes): Remove unused variable `sess'.
5311 (sys_read): Remove unused variable `err'.
5312
5313 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5314 (w32_wnd_proc): Remove unused variable `isdead'.
5315 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5316 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5317 (x_create_tip_frame): Remove unused variable `tem'.
5318
5319 * w32inevt.c (w32_console_read_socket):
5320 Remove unused variable `no_events'.
5321
5322 * w32term.c (x_draw_composite_glyph_string_foreground):
5323 Remove unused variable `width'.
5324
5325 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5326
5327 * w32term.c (x_set_glyph_string_clipping):
5328 Don't pass uninitialized region to CombineRgn.
5329
5330 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5331
5332 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5333 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5334 (Fx_close_connection): Remove unused variable `i'.
5335
5336 * w32font.c (w32font_draw): Return number of glyphs.
5337 (w32font_open_internal): Remove unused variable `i'.
5338 (w32font_driver): Add missing initializer.
5339
5340 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5341 (fill_in_menu): Remove unused variable `items_added'.
5342
5343 * w32term.c (last_mouse_press_frame): Remove static global variable.
5344 (w32_clip_to_row): Remove unused variable `f'.
5345 (x_delete_terminal): Remove unused variable `i'.
5346
5347 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5348 (NOTHING): Remove unused static global variable.
5349 (uniscribe_check_otf): Remove unused variable `table'.
5350 (uniscribe_font_driver): Add missing initializers.
5351
5352 2011-03-23 Julien Danjou <julien@danjou.info>
5353
5354 * term.c (Fsuspend_tty, Fresume_tty):
5355 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5356 * window.c (temp_output_buffer_show):
5357 * insdel.c (signal_before_change):
5358 * frame.c (Fhandle_switch_frame):
5359 * fileio.c (Fdo_auto_save):
5360 * emacs.c (Fkill_emacs):
5361 * editfns.c (save_excursion_restore):
5362 * cmds.c (internal_self_insert):
5363 * callint.c (Fcall_interactively):
5364 * buffer.c (Fkill_all_local_variables):
5365 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5366 Use Frun_hooks.
5367 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5368 unconditionnaly since it does the check itself.
5369
5370 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5371
5372 Fix more problems found by GCC 4.5.2's static checks.
5373
5374 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5375 the first time through the loop, since we know p0 < p1 then.
5376 This also avoids a gcc -Wstrict-overflow warning.
5377
5378 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5379 leading to a memory leak, possible in functions like
5380 load_charset_map_from_file that can allocate an unbounded number
5381 of objects (Bug#8318).
5382
5383 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5384 that could (at least in theory) be that large.
5385
5386 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5387 This is less likely to overflow, and avoids undefined behavior if
5388 overflow does occur. All callers changed. Use strtoul to scan
5389 for the unsigned long integer.
5390 (pint2hrstr): Simplify and tune code slightly.
5391 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5392
5393 * scroll.c (do_scrolling): Work around GCC bug 48228.
5394 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5395
5396 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5397 This also avoids a warning with gcc -Wstrict-overflow.
5398 (validate_x_resource_name): Simplify count usage.
5399 This also avoids a warning with gcc -Wstrict-overflow.
5400
5401 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5402 fail (Bug#8306).
5403
5404 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5405
5406 * process.c (Fmake_network_process): Use socklen_t, not int,
5407 where POSIX says socklen_t is required in portable programs.
5408 This fixes a porting bug on hosts like 64-bit HP-UX, where
5409 socklen_t is wider than int (Bug#8277).
5410 (Fmake_network_process, server_accept_connection):
5411 (wait_reading_process_output, read_process_output):
5412 Likewise.
5413
5414 * process.c: Rename or move locals to avoid shadowing.
5415 (list_processes_1, Fmake_network_process):
5416 (read_process_output_error_handler, exec_sentinel_error_handler):
5417 Rename or move locals.
5418 (Fmake_network_process): Define label "retry_connect" only if needed.
5419 (Fnetwork_interface_info): Fix pointer signedness.
5420 (process_send_signal): Add cast to avoid pointer signedness problem.
5421 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5422 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5423
5424 Make tparam.h and terminfo.c consistent.
5425 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5426 Include tparam.h instead, since it declares them.
5427 * cm.h (PC): Remove extern decl; tparam.h now does this.
5428 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5429 * terminfo.c: Include tparam.h, to check interfaces.
5430 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5431 (tparam): Adjust signature to match interface in tparam.h;
5432 this removes some undefined behavior. Check that outstring and len
5433 are zero, which they always are with Emacs.
5434 * tparam.h (PC, BC, UP): New extern decls.
5435
5436 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5437 (xftfont_open): Rename locals to avoid shadowing.
5438
5439 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5440 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5441 (OTF_TAG_SYM): Omit macro if not needed.
5442 (ftfont_list): Remove unused local.
5443 (get_adstyle_property, ftfont_pattern_entity):
5444 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5445 Rename locals to avoid shadowing.
5446
5447 * xfont.c (xfont_list_family): Mark var as initialized.
5448
5449 * xml.c (make_dom): Now static.
5450
5451 * composite.c (composition_compute_stop_pos): Rename local to
5452 avoid shadowing.
5453 (composition_reseat_it): Remove unused locals.
5454 (find_automatic_composition, composition_adjust_point): Likewise.
5455 (composition_update_it): Mark var as initialized.
5456 (find_automatic_composition): Mark vars as initialized,
5457 with a FIXME (Bug#8290).
5458
5459 character.h: Rename locals to avoid shadowing.
5460 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5461 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5462 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5463 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5464 to avoid shadowing.
5465
5466 * textprop.c (property_change_between_p): Remove; unused.
5467
5468 * intervals.c (interval_start_pos): Now static.
5469
5470 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5471
5472 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5473 Rename locals to avoid shadowing.
5474
5475 * sound.c (wav_play, au_play, Fplay_sound_internal):
5476 Fix pointer signedness.
5477 (alsa_choose_format): Remove unused local var.
5478 (wav_play): Initialize a variable to 0, to prevent undefined
5479 behavior (Bug#8278).
5480
5481 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5482
5483 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5484
5485 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5486 clobbering (Bug#8298).
5487 * sysdep.c (sys_subshell): Likewise.
5488 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5489
5490 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5491 This should get cleaned up, so that child_setup has the
5492 same signature on all platforms.
5493
5494 * callproc.c (call_process_cleanup): Now static.
5495 (relocate_fd): Rename locals to avoid shadowing.
5496
5497 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5498
5499 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5500 not to be necessary, and produces flickering.
5501
5502 2011-03-20 Glenn Morris <rgm@gnu.org>
5503
5504 * config.in: Remove file.
5505
5506 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5507
5508 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5509 are now in src/globals.h.
5510 (syms_of_minibuf): Remove spurious & from previous change.
5511
5512 2011-03-20 Leo <sdl.web@gmail.com>
5513
5514 * minibuf.c (completing-read-function): New variable.
5515 (completing-read-default): Rename from completing-read.
5516 (completing-read): Call completing-read-function.
5517
5518 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5519
5520 * xfaces.c (Fx_load_color_file):
5521 Read color file from absolute filename (bug#8250).
5522
5523 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5524
5525 * makefile.w32-in: Update dependencies.
5526
5527 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5528
5529 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5530
5531 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5532
5533 Fix more problems found by GCC 4.5.2's static checks.
5534
5535 * process.c (make_serial_process_unwind, send_process_trap):
5536 (sigchld_handler): Now static.
5537
5538 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5539 That way, the code declares only the vars that it needs.
5540 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5541 * s/cygwin.h (PTY_ITERATION): Likewise.
5542 * s/darwin.h (PTY_ITERATION): Likewise.
5543 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5544
5545 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5546 * process.c (allocate_pty): Don't declare stb unless it's needed.
5547
5548 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5549 (CONSTANTLIM): Remove; unused.
5550 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5551 Define only if needed.
5552
5553 * unexelf.c (unexec): Name an expression,
5554 to avoid gcc -Wbad-function-cast warning.
5555 Use a different way to cause a compilation error if anyone uses
5556 n rather than nn, a way that does not involve shadowing.
5557 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5558
5559 * deps.mk (unexalpha.o): Remove; unused.
5560
5561 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5562 * unexec.h: New file.
5563 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5564 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5565 Depend on unexec.h.
5566 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5567 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5568 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5569 Change as necessary to match prototype in unexec.h.
5570
5571 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5572 shadowing.
5573 (back_comment, skip_chars): Mark vars as initialized.
5574
5575 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5576 Rename locals to avoid shadowing.
5577
5578 * lread.c (read1): Rewrite so as not to use empty "else".
5579 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5580
5581 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5582
5583 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5584 warning when compiling print.c.
5585
5586 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5587 instead of using an uninitialized var.
5588 (font_sort_entities): Mark var as initialized.
5589
5590 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5591
5592 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5593 pointers to constants.
5594 (font_parse_fcname): Remove unused vars.
5595 (font_delete_unmatched): Now static.
5596 (font_get_spec): Remove; unused.
5597 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5598 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5599 Rename or move locals to avoid shadowing.
5600
5601 * fns.c (require_nesting_list, require_unwind): Now static.
5602 (Ffillarray): Rename locals to avoid shadowing.
5603
5604 * floatfns.c (domain_error2): Define only if needed.
5605 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5606
5607 * alloc.c (mark_backtrace): Move decl from here ...
5608 * lisp.h: ... to here, so that it can be checked.
5609
5610 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5611 (Fdefvar): Rewrite so as not to use empty "else".
5612 (lisp_indirect_variable): Name an expression,
5613 to avoid gcc -Wbad-function-cast warning.
5614 (Fdefvar): Rename locals to avoid shadowing.
5615
5616 * callint.c (quotify_arg, quotify_args): Now static.
5617 (Fcall_interactively): Rename locals to avoid shadowing.
5618 Use const pointer when appropriate.
5619
5620 * lisp.h (get_system_name, get_operating_system_release):
5621 Move decls here, to check interfaces.
5622 * process.c (get_operating_system_release): Move decl to lisp.h.
5623 * xrdb.c (get_system_name): Likewise.
5624 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5625 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5626 some of which prompt warnings from gcc -Wbad-function-cast.
5627 (Fformat_time_string, Fencode_time, Finsert_char):
5628 (Ftranslate_region_internal, Fformat):
5629 Rename or remove local vars to avoid shadowing.
5630 (Ftranslate_region_internal): Mark var as initialized.
5631
5632 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5633 avoid shadowing.
5634
5635 * lisp.h (eassert): Check that the argument compiles, even if
5636 ENABLE_CHECKING is not defined.
5637
5638 * data.c (Findirect_variable): Name an expression, to avoid
5639 gcc -Wbad-function-cast warning.
5640 (default_value, arithcompare, arith_driver, arith_error): Now static.
5641 (store_symval_forwarding): Rename local to avoid shadowing.
5642 (Fmake_variable_buffer_local, Fmake_local_variable):
5643 Mark variables as initialized.
5644 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5645
5646 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5647 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5648 Rename locals to avoid shadowing.
5649 (mark_stack): Move local variables into the #ifdef region where
5650 they're used.
5651 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5652 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5653 needed otherwise.
5654 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5655 (GC_STRING_CHARS): Remove; not used.
5656 (Fmemory_limit): Cast sbrk's returned value to char *.
5657
5658 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5659 avoids undefined behavior in theory.
5660
5661 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5662
5663 Use functions, not macros, for up- and down-casing (Bug#8254).
5664 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5665 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5666 to use the following functions instead of these macros.
5667 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5668 EMACS_INT, since callers assume the returned value fits in int.
5669 (upcase1): Likewise, for UPCASE_TABLE.
5670 (uppercasep, lowercasep, upcase): New static inline functions.
5671 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5672 the race-condition problem in the old DOWNCASE.
5673
5674 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5675 Rename locals to avoid shadowing.
5676 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5677 (regex_compile, re_search_2, re_match_2_internal):
5678 Remove unused local vars.
5679 (FREE_VAR): Rewrite so as not to use empty "else",
5680 which gcc can warn about.
5681 (regex_compile, re_match_2_internal): Mark locals as initialized.
5682 (RETALLOC_IF): Define only if needed.
5683 (WORDCHAR_P): Likewise. This one is never needed, but is used
5684 only in a comment talking about a compiler bug, so put inside
5685 the #if 0 of that comment.
5686 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5687 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5688 Remove; unused.
5689
5690 * search.c (boyer_moore): Rename locals to avoid shadowing.
5691 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5692 (PREV_CHAR_BOUNDARY): Likewise.
5693
5694 * search.c (simple_search): Remove unused var.
5695
5696 * dired.c (compile_pattern): Move decl from here ...
5697 * lisp.h: ... to here, so that it can be checked.
5698 (struct re_registers): New forward decl.
5699
5700 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5701
5702 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5703 All uses changed.
5704 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5705 Rename locals to avoid shadowing.
5706 (Fvertical_motion): Mark locals as initialized.
5707
5708 * casefiddle.c (casify_object, casify_region): Now static.
5709 (casify_region): Mark local as initialized.
5710
5711 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5712
5713 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5714 New macros, so that the caller can use some names other than
5715 gcpro1, gcpro2, etc.
5716 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5717 of the new macros.
5718 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5719 argument, for consistency with GCPRO2_VAR, etc: it is now the
5720 prefix of the variable, not the variable itself. All uses
5721 changed.
5722 * dired.c (directory_files_internal, file_name_completion):
5723 Rename locals to avoid shadowing.
5724
5725 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5726 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5727 dired.c's scmp function, had undefined behavior.
5728 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5729 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5730 * buffer.h: ... to here, because these macros use current_buffer,
5731 and the new implementation with inline functions needs to have
5732 current_buffer in scope now, rather than later when the macros
5733 are used.
5734 (downcase, upcase1): New static inline functions.
5735 (DOWNCASE, UPCASE1): Reimplement using these functions.
5736 This avoids undefined behavior in expressions like
5737 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5738 from race conditions in accessing the global variables
5739 case_temp1 and case_temp2.
5740 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5741 * lisp.h (case_temp1, case_temp2): Remove their decls.
5742 * character.h (ASCII_CHAR_P): Move from here ...
5743 * lisp.h: ... to here, so that the inline functions mentioned
5744 above can use them.
5745
5746 * dired.c (directory_files_internal_unwind): Now static.
5747
5748 * fileio.c (file_name_as_directory, directory_file_name):
5749 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5750 Now static.
5751 (file_name_as_directory): Use const pointers when appropriate.
5752 (Fexpand_file_name): Likewise. In particular, newdir might
5753 point at constant storage, so make it a const pointer.
5754 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5755 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5756 signedness issues.
5757 (Fset_file_times, Finsert_file_contents, auto_save_error):
5758 Rename locals to avoid shadowing.
5759
5760 * minibuf.c (choose_minibuf_frame_1): Now static.
5761 (Ftry_completion, Fall_completions): Rename or remove locals
5762 to avoid shadowing.
5763
5764 * marker.c (bytepos_to_charpos): Remove; unused.
5765
5766 * lisp.h (verify_bytepos, count_markers): New decls,
5767 so that gcc does not warn that these functions aren't declared.
5768
5769 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5770 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5771 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5772 (copy_text): Remove unused local var.
5773
5774 * filelock.c (within_one_second): Now static.
5775 (lock_file_1): Rename local to avoid shadowing.
5776
5777 * buffer.c (fix_overlays_before): Mark locals as initialized.
5778 (fix_start_end_in_overlays): Likewise. This function should be
5779 simplified by using pointers-to-pointers, but that's a different
5780 matter.
5781 (switch_to_buffer_1): Now static.
5782 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5783 (report_overlay_modification): Rename locals to avoid shadowing.
5784
5785 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5786 Fix pointer signedness issue.
5787 (sys_subshell): Mark local as volatile if checking for lint,
5788 to suppress a gcc -Wclobbered warning that does not seem to be right.
5789 (MAXPATHLEN): Define only if needed.
5790
5791 * process.c (serial_open, serial_configure): Move decls from here ...
5792 * systty.h: ... to here, so that they can be checked.
5793
5794 * fns.c (get_random, seed_random): Move extern decls from here ...
5795 * lisp.h: ... to here, so that they can be checked.
5796
5797 * sysdep.c (reset_io): Now static.
5798 (wait_for_termination_signal): Remove; unused.
5799
5800 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5801 (copy_keymap_item, append_key, push_text_char_description):
5802 Now static.
5803 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5804 (DENSE_TABLE_SIZE): Remove; unused.
5805 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5806 (describe_map_tree):
5807 Rename locals to avoid shadowing.
5808
5809 * keyboard.c: Declare functions static if they are not used elsewhere.
5810 (echo_char, echo_dash, cmd_error, top_level_2):
5811 (poll_for_input, handle_async_input): Now static.
5812 (read_char, kbd_buffer_get_event, make_lispy_position):
5813 (make_lispy_event, make_lispy_movement, apply_modifiers):
5814 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5815 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5816 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5817 (read_key_sequence, read_char): Mark locals as initialized.
5818 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5819
5820 * keyboard.h (make_ctrl_char): New decl.
5821 (mark_kboards): Move decl here ...
5822 * alloc.c (mark_kboards): ... from here.
5823
5824 * lisp.h (force_auto_save_soon): New decl.
5825
5826 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5827 (DEFINE_DUMMY_FUNCTION): New macro.
5828 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5829 Use it.
5830 (main): Add casts to avoid warnings
5831 if GCC considers string literals to be constants.
5832
5833 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5834
5835 * dbusbind.c: Pointer signedness fixes.
5836 (xd_signature, xd_append_arg, xd_initialize):
5837 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5838 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5839 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5840 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5841
5842 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5843 if GCC considers string literals to be constants.
5844 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5845
5846 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5847
5848 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5849 (print_preprocess, print_object): New macro to fix last change.
5850
5851 * print.c (print_preprocess): Don't forget font objects.
5852
5853 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5854
5855 * emacs.c (USAGE3): Doc fixes.
5856
5857 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5858
5859 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5860 structure.
5861
5862 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5863
5864 * lisp.h (VWindow_system, Qfile_name_history):
5865 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5866 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5867 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5868
5869 * w32select.c: Don't #include "keyboard.h".
5870 (run_protected): Add extern declaration for waiting_for_input.
5871
5872 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5873 * w32console.c (detect_input_pending, read_input_pending)
5874 (encode_terminal_code):
5875 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5876 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5877 (w32_system_caret_y, Qfile_name_history):
5878 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5879 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5880 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5881 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5882 * w32proc.c (Qlocal, report_file_error):
5883 * w32term.c (Vwindow_system, updating_frame):
5884 * w32uniscribe.c (initialized, uniscribe_font_driver):
5885 Remove unneeded extern declarations.
5886
5887 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5888
5889 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5890
5891 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5892
5893 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5894 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5895 These macros can no longer be used for assignment.
5896
5897 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5898 Assign struct members directly, instead of using BUF_BEGV etc.
5899 (record_buffer_markers, fetch_buffer_markers): New functions for
5900 recording and fetching special buffer markers.
5901 (set_buffer_internal_1, set_buffer_temp): Use them.
5902
5903 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5904
5905 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5906
5907 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5908 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5909
5910 * xdisp.c (hscroll_window_tree):
5911 (reconsider_clip_changes): Use PT instead of BUF_PT.
5912
5913 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5914
5915 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5916 $(EMACS_ROOT)/lib/intprops.h.
5917
5918 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5919
5920 Fix more problems found by GCC 4.5.2's static checks.
5921
5922 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5923 to unsigned char * to avoid compiler diagnostic.
5924 (xg_free_frame_widgets): Make it clear that a local variable is
5925 needed only if USE_GTK_TOOLTIP.
5926 (gdk_window_get_screen): Make it clear that this macro is needed
5927 only if USE_GTK_TOOLTIP.
5928 (int_gtk_range_get_value): New function, which avoids a diagnostic
5929 from gcc -Wbad-function-cast.
5930 (xg_set_toolkit_scroll_bar_thumb): Use it.
5931 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5932 diagnostic from gcc -Wbad-function-cast.
5933 (get_utf8_string, xg_get_file_with_chooser):
5934 Rename locals to avoid shadowing.
5935 (create_dialog): Move locals to avoid shadowing.
5936
5937 * xgselect.c (xg_select): Remove unused var.
5938
5939 * image.c (four_corners_best): Mark locals as initialized.
5940 (gif_load): Initialize transparent_p to zero (Bug#8238).
5941 Mark another local as initialized.
5942 (my_png_error, my_error_exit): Mark with NO_RETURN.
5943
5944 * image.c (clear_image_cache): Now static.
5945 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5946 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5947 (x_edge_detection): Remove unnecessary cast that
5948 gcc -Wbad-function-cast diagnoses.
5949 (gif_load): Fix pointer signedness.
5950 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5951 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5952
5953 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5954
5955 Improve quality of tests for time stamp overflow.
5956 For example, without this patch (encode-time 0 0 0 1 1
5957 1152921504606846976) returns the obviously-bogus value (-948597
5958 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5959 reports time overflow. See
5960 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5961 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5962 * editfns.c: Include limits.h and intprops.h.
5963 (TIME_T_MIN, TIME_T_MAX): New macros.
5964 (time_overflow): Move earlier, to before first use.
5965 (hi_time, lo_time): New functions, for an accurate test for
5966 out-of-range times.
5967 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5968 (Fget_internal_run_time): Don't assume time_t fits in int.
5969 (make_time): Use list2 instead of Fcons twice.
5970 (Fdecode_time): More accurate test for out-of-range times.
5971 (check_tm_member): New function.
5972 (Fencode_time): Use it, to test for out-of-range times.
5973 (lisp_time_argument): Don't rely on undefined left-shift and
5974 right-shift behavior when checking for time stamp overflow.
5975
5976 * editfns.c (time_overflow): New function, refactoring common code.
5977 (Fformat_time_string, Fdecode_time, Fencode_time):
5978 (Fcurrent_time_string): Use it.
5979
5980 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5981 * dired.c (make_time): Move to ...
5982 * editfns.c (make_time): ... here.
5983 * systime.h: Note the move.
5984
5985 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5986
5987 * fringe.c (update_window_fringes): Remove unused variables.
5988
5989 * unexmacosx.c (copy_data_segment): Also copy __got section.
5990 (Bug#8223)
5991
5992 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5993
5994 * termcap.c [MSDOS]: Include "msdos.h".
5995 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5996 Constify `char *' arguments and their references according to
5997 prototypes in tparam.h.
5998
5999 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6000
6001 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6002 Adapt all references accordingly.
6003
6004 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6005
6006 2011-03-11 Tom Tromey <tromey@redhat.com>
6007
6008 * buffer.c (syms_of_buffer): Remove obsolete comment.
6009
6010 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6011
6012 * termhooks.h (encode_terminal_code): Declare prototype.
6013
6014 * msdos.c (encode_terminal_code): Don't declare prototype.
6015
6016 * term.c (encode_terminal_code): Now external again, used by
6017 w32console.c and msdos.c.
6018
6019 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6020 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6021
6022 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6023
6024 Fix some minor problems found by GCC 4.5.2's static checks.
6025
6026 * fringe.c (update_window_fringes): Mark locals as initialized
6027 (Bug#8227).
6028 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6029
6030 * alloc.c (mark_fringe_data): Move decl from here ...
6031 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6032 to check its interface.
6033 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6034
6035 * fontset.c (free_realized_fontset): Now static.
6036 (Fset_fontset_font): Rename local to avoid shadowing.
6037 (fontset_font): Mark local as initialized.
6038 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6039
6040 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6041
6042 * xselect.c (x_disown_buffer_selections): Remove; not used.
6043 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6044 (x_own_selection, Fx_disown_selection_internal): Rename locals
6045 to avoid shadowing.
6046 (x_handle_dnd_message): Remove local to avoid shadowing.
6047
6048 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6049 so that the caller can use some name other than gcpro1.
6050 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6051 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6052 (Fx_backspace_delete_keys_p):
6053 Use them to avoid shadowing, and rename vars to avoid shadowing.
6054 (x_decode_color, x_set_name, x_window): Now static.
6055 (Fx_create_frame): Add braces to silence GCC warning.
6056 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6057 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6058 Remove unused locals.
6059 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6060 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6061 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6062 macros.
6063
6064 * xterm.h (x_mouse_leave): New decl.
6065
6066 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6067 Remove unused functions.
6068 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6069 (x_calc_absolute_position): Now static.
6070 (XTread_socket): Don't define label "out" unless it's used.
6071 Don't declare local "event" unless it's used.
6072 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6073 unless they are used.
6074 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6075 (x_fatal_error_signal): Remove; not used.
6076 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6077 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6078 (x_error_catcher, x_connection_closed, x_error_handler):
6079 (x_error_quitter, xembed_send_message, x_iconify_frame):
6080 (my_log_handler): Rename locals to avoid shadowing.
6081 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6082 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6083
6084 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6085 Rename or move locals to avoid shadowing.
6086 (tty_defined_color, merge_face_heights): Now static.
6087 (free_realized_faces_for_fontset): Remove; not used.
6088 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6089 does not deduce is never used uninitialized.
6090 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6091 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6092
6093 * terminal.c (store_terminal_param): Now static.
6094
6095 * xmenu.c (menu_highlight_callback): Now static.
6096 (set_frame_menubar): Remove unused local.
6097 (xmenu_show): Rename parameter to avoid shadowing.
6098 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6099 since they might point to immutable storage.
6100 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6101 since it's unused otherwise.
6102
6103 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6104 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6105 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6106 avoids a gcc -Wuninitialized diagnostic.
6107 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6108 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6109 does not deduce are never used uninitialized.
6110
6111 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6112
6113 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6114 * window.c (window_loop, size_window):
6115 (run_window_configuration_change_hook, enlarge_window): Likewise.
6116
6117 * window.c (display_buffer): Now static.
6118 (size_window): Mark variables that gcc -Wuninitialized
6119 does not deduce are never used uninitialized.
6120 * window.h (check_all_windows): New decl, to forestall
6121 gcc -Wmissing-prototypes diagnostic.
6122 * dispextern.h (bidi_dump_cached_states): Likewise.
6123
6124 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6125 shadowing.
6126 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6127 Include <limits.h>.
6128 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6129 and to avoid gcc -Wuninitialized warning.
6130 (load_charset_map): Mark variables that gcc -Wuninitialized
6131 does not deduce are never used uninitialized.
6132 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6133
6134 * coding.c (coding_set_source, coding_set_destination):
6135 Use "else { /* comment */ }" rather than "else /* comment */;"
6136 for clarity, and to avoid gcc -Wempty-body warning.
6137 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6138 a block, when the outer 'i' will do.
6139 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6140 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6141 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6142 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6143 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6144 Rename locals to avoid shadowing.
6145 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6146 * coding.c (emacs_mule_char, encode_invocation_designation):
6147 Now static, since they're not used elsewhere.
6148 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6149 (decode_coding_object, encode_coding_object, detect_coding_system):
6150 (decode_coding_emacs_mule): Mark variables that gcc
6151 -Wuninitialized does not deduce are never used uninitialized.
6152 (detect_coding_iso_2022): Initialize a local variable that might
6153 be used uninitialized. Leave a FIXME because it's not clear that
6154 this initialization is needed. (Bug#8211)
6155 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6156 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6157 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6158 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6159 Remove unused macros.
6160
6161 * category.c (hash_get_category_set): Remove unused local var.
6162 (copy_category_table): Now static, since it's not used elsewhere.
6163 * character.c (string_count_byte8): Likewise.
6164
6165 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6166 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6167
6168 * chartab.c (copy_sub_char_table): Now static, since it's not used
6169 elsewhere.
6170 (sub_char_table_ref_and_range, char_table_ref_and_range):
6171 Rename locals to avoid shadowing.
6172 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6173
6174 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6175 (BIDI_BOB): Remove unused macro.
6176
6177 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6178 deduce are never used uninitialized.
6179 * term.c (encode_terminal_code): Likewise.
6180
6181 * term.c (encode_terminal_code): Now static. Remove unused local.
6182
6183 * tparam.h: New file.
6184 * term.c, tparam.h: Include it.
6185 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6186 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6187 Move these decls to tparam.h, and make them agree with what
6188 is actually in tparam.c. The previous trick of using incompatible
6189 decls in different modules does not conform to the C standard.
6190 All callers of tparam changed to use tparam's actual API.
6191 * tparam.c (tparam1, tparam, tgoto):
6192 Use const pointers where appropriate.
6193
6194 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6195 * cm.h (struct cm): Likewise.
6196 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6197 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6198 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6199 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6200 (turn_on_face, init_tty): Likewise.
6201 * termchar.h (struct tty_display_info): Likewise.
6202
6203 * term.c (term_mouse_position): Rename local to avoid shadowing.
6204
6205 * alloc.c (mark_ttys): Move decl from here ...
6206 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6207
6208 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6209
6210 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6211
6212 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6213
6214 * search.c (compile_pattern_1): Remove argument regp, unused since
6215 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6216 (compile_pattern): Don't pass it.
6217
6218 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6219
6220 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6221 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6222 for ! HAVE_GTK3.
6223 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6224
6225 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6226
6227 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6228 gdk_window_get_screen, gdk_window_get_geometry,
6229 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6230 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6231 (xg_get_pixbuf_from_pixmap): New function.
6232 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6233 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6234 Call xg_get_pixbuf_from_pixmap instead of
6235 gdk_pixbuf_get_from_drawable.
6236 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6237 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6238 (xg_check_special_colors): Use GtkStyleContext and its functions
6239 for HAVE_GTK3.
6240 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6241 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6242 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6243 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6244 Call gtk_widget_get_preferred_size.
6245 (xg_frame_resized): gdk_window_get_geometry only takes 5
6246 parameters.
6247 (xg_win_to_widget, xg_event_is_for_menubar):
6248 Call gdk_x11_window_lookup_for_display.
6249 (xg_set_widget_bg): New function.
6250 (delete_cb): New function.
6251 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6252 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6253 (xg_set_background_color): Call xg_set_widget_bg.
6254 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6255 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6256 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6257 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6258 if ! HAVE_GTK3.
6259 (update_frame_tool_bar): Call gtk_widget_hide.
6260 (xg_initialize): Use GDK_KEY_g.
6261
6262 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6263 if ! HAVE_GTK3
6264 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6265
6266 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6267 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6268 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6269
6270 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6271
6272 * w32xfns.c (select_palette): Check success of RealizePalette against
6273 GDI_ERROR, not zero.
6274
6275 See ChangeLog.11 for earlier changes.
6276
6277 ;; Local Variables:
6278 ;; coding: utf-8
6279 ;; End:
6280
6281 Copyright (C) 2011 Free Software Foundation, Inc.
6282
6283 This file is part of GNU Emacs.
6284
6285 GNU Emacs is free software: you can redistribute it and/or modify
6286 it under the terms of the GNU General Public License as published by
6287 the Free Software Foundation, either version 3 of the License, or
6288 (at your option) any later version.
6289
6290 GNU Emacs is distributed in the hope that it will be useful,
6291 but WITHOUT ANY WARRANTY; without even the implied warranty of
6292 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6293 GNU General Public License for more details.
6294
6295 You should have received a copy of the GNU General Public License
6296 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.