Add bug#.
[bpt/emacs.git] / src / ChangeLog
1 2011-05-23 Paul Eggert <eggert@cs.ucla.edu>
2
3 ccl: add integer overflow checks
4 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5 (IN_INT_RANGE): New macros.
6 (ccl_driver): Use them to check for integer overflow when
7 decoding a CCL program. Many of the new checks are whether XINT (x)
8 fits in int; it doesn't always, on 64-bit hosts. The new version
9 doesn't catch all possible integer overflows, but it's an
10 improvement. (Bug#8719)
11
12 * alloc.c (make_event_array): Use XINT, not XUINT.
13 There's no need for unsigned here.
14
15 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
16 This follows up to the 2011-05-06 change that substituted uintptr_t
17 for EMACS_INT. This case wasn't caught back then.
18
19 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
20
21 Rework Fformat to avoid integer overflow issues.
22 * editfns.c: Include <float.h> unconditionally, as it's everywhere
23 now (part of C89). Include <verify.h>.
24 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
25 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
26 (Fformat): Avoid the prepass trying to compute sizes; it was only
27 approximate and thus did not catch overflow reliably. Instead, walk
28 through the format just once, formatting and computing sizes as we go,
29 checking for integer overflow at every step, and allocating a larger
30 buffer as needed. Keep track separately whether the format is
31 multibyte. Keep only the most-recently calculated precision, rather
32 than them all. Record whether each argument has been converted to
33 string. Use EMACS_INT, not int, for byte and char and arg counts.
34 Support field widths and precisions larger than INT_MAX. Avoid
35 sprintf's undefined behavior with conversion specifications such as %#d
36 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
37 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
38 formatting out-of-range floating point numbers with int
39 formats. (Bug#8668)
40
41 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
42
43 * data.c: Avoid integer truncation in expressions involving floats.
44 * data.c: Include <intprops.h>.
45 (arith_driver): When there's an integer overflow in an expression
46 involving floating point, convert the integers to floating point
47 so that the resulting value does not suffer from catastrophic
48 integer truncation. For example, on a 64-bit host (* 4
49 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
50 Do not rely on undefined behavior after integer overflow.
51
52 merge count_size_as_multibyte, parse_str_to_multibyte
53 * character.c, character.h (count_size_as_multibyte):
54 Renamed from parse_str_to_multibyte; all uses changed.
55 Check for integer overflow.
56 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
57 since it's now a duplicate of the other. This is more of
58 a character than a buffer op, so better that it's in character.c.
59 * fns.c, print.c: Adjust to above changes.
60
61 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
62
63 * gnutls.c: Remove unused macros.
64 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
65 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
66 Remove macros that are defined and never used.
67 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
68
69 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
70
71 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
72 (Fx_get_selection_internal): Minor cleanup.
73 (Fx_own_selection_internal): Rename arguments for consistency with
74 select.el.
75
76 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
77
78 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
79
80 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
81
82 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
83
84 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
85
86 * dispnew.c (scrolling_window): Don't exclude the case that the
87 last enabled row in the desired matrix touches the bottom boundary.
88
89 2011-05-21 Glenn Morris <rgm@gnu.org>
90
91 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
92 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
93 and add some more files.
94
95 2011-05-20 Eli Zaretskii <eliz@gnu.org>
96
97 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
98 report_file_error introduced by the change from 2011-05-07.
99
100 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
101
102 * systime.h (Time): Define only if emacs is defined.
103 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
104 where the include path doesn't have X11/X.h by default. See
105 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
106
107 2011-05-20 Kenichi Handa <handa@m17n.org>
108
109 * composite.c (find_automatic_composition): Fix previous change.
110
111 2011-05-20 Glenn Morris <rgm@gnu.org>
112
113 * lisp.mk: New file, split from Makefile.in.
114 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
115 (shortlisp): Remove.
116 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
117
118 2011-05-19 Glenn Morris <rgm@gnu.org>
119
120 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
121 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
122 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
123 (lisp): Set the order to that of loadup.el.
124 (shortlisp): Make it a copy of $lisp.
125 (SOME_MACHINE_LISP): Remove.
126 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
127 Use just $shortlisp, not $SOME_MACHINE_LISP too.
128
129 2011-05-18 Kenichi Handa <handa@m17n.org>
130
131 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
132 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
133 (find_automatic_composition): Mostly rewrite for efficiency.
134
135 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
136
137 * makefile.w32-in: Update dependencies.
138
139 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
140
141 * menu.c: Include limits.h (fixes the MS-Windows build broken by
142 revision 104625).
143
144 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
145
146 Fix some integer overflow issues, such as string length overflow.
147
148 * insdel.c (count_size_as_multibyte): Check for string overflow.
149
150 * character.c (lisp_string_width): Check for string overflow.
151 Use EMACS_INT, not int, for string indexes and lengths; in
152 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
153 the resulting string length overflows an EMACS_INT; instead,
154 report a string overflow if no precision given. When checking for
155 precision exhaustion, use a check that cannot possibly have
156 integer overflow. (Bug#8675)
157 * character.h (lisp_string_width): Adjust to new signature.
158
159 * alloc.c (string_overflow): New function.
160 (Fmake_string): Use it. This doesn't change behavior, but saves
161 a few bytes and will simplify future changes.
162 * character.c (string_escape_byte8): Likewise.
163 * lisp.h (string_overflow): New decl.
164
165 Fixups, following up to the user-interface timestamp change.
166 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
167 for UI timestamps, instead of unsigned long.
168 * msdos.c (mouse_get_pos): Likewise.
169 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
170 * w32gui.h (Time): Define by including "systime.h" rather than by
171 declaring it ourselves. (Bug#8664)
172
173 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
174 * image.c (clear_image_cache): Likewise.
175
176 * term.c (term_mouse_position): Don't assume time_t wraparound.
177
178 Be more systematic about user-interface timestamps.
179 Before, the code sometimes used 'Time', sometimes 'unsigned long',
180 and sometimes 'EMACS_UINT', to represent these timestamps. This
181 change causes it to use 'Time' uniformly, as that's what X uses.
182 This makes the code easier to follow, and makes it easier to catch
183 integer overflow bugs such as Bug#8664.
184 * frame.c (Fmouse_position, Fmouse_pixel_position):
185 Use Time, not unsigned long, for user-interface timestamps.
186 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
187 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
188 * keyboard.h (last_event_timestamp): Likewise.
189 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
190 * menu.h (xmenu_show): Likewise.
191 * term.c (term_mouse_position): Likewise.
192 * termhooks.h (struct input_event.timestamp): Likewise.
193 (struct terminal.mouse_position_hook): Likewise.
194 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
195 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
196 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
197 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
198 what it was before.
199 * menu.h, termhooks.h: Include "systime.h", for Time.
200
201 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
202 Don't assume that the difference between two unsigned long values
203 can fit into an integer. At this point, we know button_down_time
204 <= event->timestamp, so the difference must be nonnegative, so
205 there's no need to cast the result if double-click-time is
206 nonnegative, as it should be; check that it's nonnegative, just in
207 case. This bug is triggered when events are more than 2**31 ms
208 apart (about 25 days). (Bug#8664)
209
210 * xselect.c (last_event_timestamp): Remove duplicate decl.
211 (x_own_selection): Remove needless cast to unsigned long.
212
213 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
214 that always fit in int. Use a sentinel instead of a counter, to
215 avoid a temp and to allay GCC's concerns about possible int overflow.
216 * frame.h (struct frame): Use int for menu_bar_items_used
217 instead of EMACS_INT, since it always fits in int.
218
219 * menu.c (grow_menu_items): Check for int overflow.
220
221 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
222
223 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
224 Before, the code was not consistent. These values cannot exceed
225 2**31 - 1 so there's no need to make them unsigned.
226 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
227 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
228 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
229 as modifiers.
230 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
231
232 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
233 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
234 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
235 presumably because the widths might not match.
236
237 * window.c (size_window): Avoid needless test at loop start.
238
239 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
240
241 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
242
243 2011-05-12 Drew Adams <drew.adams@oracle.com>
244
245 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
246
247 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
248
249 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
250 `width' to `bar_area_x' and `bar_area_width', respectively.
251 (x_scroll_run): Take account of fringe background extension.
252
253 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
254 Rename local vars `left' and `width' to `bar_area_x' and
255 `bar_area_width', respectively.
256 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
257 background extension.
258
259 2011-05-10 Jim Meyering <meyering@redhat.com>
260
261 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
262
263 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
264
265 * image.c (Finit_image_library): Return t for built-in image types,
266 like pbm and xbm. (Bug#8640)
267
268 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
269
270 * w32menu.c (set_frame_menubar): Fix submenu allocation.
271
272 2011-05-07 Eli Zaretskii <eliz@gnu.org>
273
274 * w32console.c (Fset_screen_color): Doc fix.
275 (Fget_screen_color): New function.
276 (syms_of_ntterm): Defsubr it.
277
278 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
279 unlink the temporary file if Fcall_process didn't create it in the
280 first place.
281 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
282 child process will be redirected to a file specified with `:file'.
283 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
284 cue to call_process_cleanup not to close that handle.
285
286 2011-05-07 Ben Key <bkey76@gmail.com>
287
288 * makefile.w32-in: The bootstrap-temacs rule now makes use of
289 one of two shell specific rules, either bootstrap-temacs-CMD or
290 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
291 to the previous implementation of the bootstrap-temacs rule.
292 The bootstrap-temacs-CMD rule is similar to the previous
293 implementation of the bootstrap-temacs rule except that it
294 makes use of the ESC_CFLAGS variable instead of the CFLAGS
295 variable.
296
297 These changes, along with some changes to nt/configure.bat,
298 nt/gmake.defs, and nt/nmake.defs, are required to extend my
299 earlier fix to add support for --cflags and --ldflags options
300 that include quotes so that it works whether make uses cmd or
301 sh as the shell.
302
303 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
304
305 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
306 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
307 is a constant.
308 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
309 a string. Handle both cases.
310 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
311 (Fdbus_register_method): Use Qinvalid_function.
312
313 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
314
315 * makefile.w32-in: Update dependencies.
316 (LISP_H): Add inttypes.h and stdin.h.
317 (PROCESS_H): Add unistd.h.
318
319 2011-05-06 Eli Zaretskii <eliz@gnu.org>
320
321 * lread.c: Include limits.h (fixes the MS-Windows build broken by
322 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
323
324 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
325
326 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
327
328 * term.c (vfatal): Remove stray call to va_end.
329 It's not needed and the C Standard doesn't allow it here anyway.
330
331 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
332 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
333
334 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
335 bytes.
336
337 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
338
339 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
340
341 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
342
343 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
344
345 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
346
347 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
348 * charset.c (Fdefine_charset_internal): Don't initialize
349 charset.code_space[15]. The value was garbage, on hosts with
350 32-bit int (Bug#8600).
351
352 * lread.c (read_integer): Be more consistent with string-to-number.
353 Use string_to_number to do the actual conversion; this avoids
354 rounding errors and fixes some other screwups. Without this fix,
355 for example, #x1fffffffffffffff was misread as -2305843009213693952.
356 (digit_to_number): Move earlier, for benefit of read_integer.
357 Return -1 if the digit is out of range for the base, -2 if it is
358 not a digit in any supported base. (Bug#8602)
359
360 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
361
362 * dispnew.c (scrolling_window): Return 1 if we scrolled,
363 to match comment at start of function. This also removes a
364 GCC warning about overflow in a 32+64-bit port.
365
366 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
367
368 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
369 Reported by Stefan Monnier in
370 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
371 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
372 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
373
374 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
375 (EMACS_UINTPTR): Likewise, with uintptr_t.
376
377 * lisp.h: Prefer 64-bit EMACS_INT if available.
378 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
379 on 32-bit hosts that have 64-bit int, so that they can access
380 large files.
381 However, temporarily disable this change unless the temporary
382 symbol WIDE_EMACS_INT is defined.
383
384 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
385
386 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
387 This removes an assumption that EMACS_INT and long are the same
388 width as pointers. The assumption is true for Emacs porting targets
389 now, but we want to make other targets possible.
390 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
391 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
392 In the rest of the code, change types of integers that hold casted
393 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
394 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
395 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
396 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
397 No need to cast type when ORing.
398 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
399 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
400 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
401 assume EMACS_INT is the same width as char *.
402 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
403 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
404 Remove no-longer-needed casts.
405 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
406 (xg_tool_bar_help_callback, xg_make_tool_item):
407 Use EMACS_INTPTR to hold an integer
408 that will be cast to void *; this can avoid a GCC warning
409 if EMACS_INT is not the same width as void *.
410 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
411 * xdisp.c (display_echo_area_1, resize_mini_window_1):
412 (current_message_1, set_message_1):
413 Use a local to convert to proper width without a cast.
414 * xmenu.c (dialog_selection_callback): Likewise.
415
416 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
417 Also, don't assume VALBITS / RAND_BITS is less than 5,
418 and don't rely on undefined behavior when shifting a 1 left into
419 the sign bit.
420 * lisp.h (get_random): Change signature to match.
421
422 * lread.c (hash_string): Use size_t, not int, for hash computation.
423 Normally we prefer signed values; but hashing is special, because
424 it's better to use unsigned division on hash table sizes so that
425 the remainder is nonnegative. Also, size_t is the natural width
426 for hashing into memory. The previous code used 'int', which doesn't
427 retain enough info to hash well into very large tables.
428 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
429
430 * dbusbind.c: Don't possibly lose pointer info when converting.
431 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
432 Use XPNTR rather than XHASH, so that the high-order bits of
433 the pointer aren't lost when converting through void *.
434
435 * eval.c (Fautoload): Don't double-shift a pointer.
436
437 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
438
439 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
440
441 * gnutls.c (DEF_GNUTLS_FN):
442 * image.c (DEF_IMGLIB_FN): Make function pointers static.
443
444 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
445
446 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
447 marker. (Bug#8610)
448
449 2011-05-05 Eli Zaretskii <eliz@gnu.org>
450
451 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
452 New version that can reserve upto 2GB of heap space.
453
454 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
455
456 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
457
458 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
459
460 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
461 `gnutls_certificate_set_x509_key_file'.
462
463 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
464
465 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
466 Update dependencies.
467
468 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
469
470 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
471 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
472 Remove unused parameter `fildes'.
473 * process.c (read_process_output, send_process): Don't pass it.
474
475 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
476
477 Fix previous change: the library cache is defined in w32.c.
478 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
479 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
480
481 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
482
483 Implement dynamic loading of GnuTLS on Windows.
484
485 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
486 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
487 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
488 Declare.
489
490 * gnutls.c (Qgnutls_dll): Define.
491 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
492 (gnutls_*): Declare function pointers.
493 (init_gnutls_functions): New function to initialize function pointers.
494 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
495 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
496 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
497 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
498 (emacs_gnutls_write, emacs_gnutls_read)
499 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
500 (Fgnutls_available_p): New function.
501 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
502 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
503 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
504
505 * image.c: Include w32.h.
506 (Vimage_type_cache): Delete.
507 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
508 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
509 (w32_delayed_load): Move to w32.c.
510
511 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
512
513 * w32.c (QCloaded_from, Vlibrary_cache): Define.
514 (w32_delayed_load): Move from image.c. When loading a library, record
515 its filename in the :loaded-from property of the library id.
516 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
517 Initialize and staticpro them.
518 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
519
520 * process.c: Include lisp.h before w32.h, not after.
521 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
522 instead of gnutls_record_check_pending.
523
524 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
525
526 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
527
528 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
529 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
530 as passed in.
531
532 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
533
534 * xterm.c (x_set_frame_alpha): Do not set property on anything
535 else than FRAME_X_OUTER_WINDOW (Bug#8608).
536
537 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
538
539 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
540
541 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
542
543 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
544 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
545 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
546 (gnutls_global_initialized, Qgnutls_bootprop_priority)
547 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
548 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
549 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
550 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
551 (Qgnutls_bootprop_callbacks_verify): Make static.
552
553 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
554
555 * callproc.c: Indentation fixup.
556
557 * sysdep.c (wait_for_termination_1): Make static.
558 (wait_for_termination, interruptible_wait_for_termination):
559 Move after wait_for_termination_1.
560
561 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
562
563 * sysdep.c (interruptible_wait_for_termination): New function
564 which is like wait_for_termination, but allows keyboard
565 interruptions.
566
567 * callproc.c (Fcall_process): Add (:file "file") as an option for
568 the STDOUT buffer.
569 (Fcall_process_region): Ditto.
570
571 2011-04-30 Eli Zaretskii <eliz@gnu.org>
572
573 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
574 rather than `XVECTOR (FOO)->size'.
575
576 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
577 inttypes.h, as a gnulib replacement is used if it not available in
578 system headers.
579
580 2011-04-21 Eli Zaretskii <eliz@gnu.org>
581
582 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
583 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
584 of MOST_POSITIVE_FIXNUM. (Bug#8528)
585
586 * coding.c (coding_alloc_by_realloc): Error out if destination
587 will grow beyond MOST_POSITIVE_FIXNUM.
588 (decode_coding_emacs_mule): Abort if there isn't enough place in
589 charbuf for the composition carryover bytes. Reserve an extra
590 space for up to 2 characters produced in a loop.
591 (decode_coding_iso_2022): Abort if there isn't enough place in
592 charbuf for the composition carryover bytes.
593
594 2011-04-21 Eli Zaretskii <eliz@gnu.org>
595
596 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
597 aborting when %lld or %lll format is passed.
598 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
599 %llo or %llx format is passed. (Bug#8545)
600
601 * window.c (window_scroll_line_based): Use a marker instead of
602 simple variables to record original value of point. (Bug#7952)
603
604 * doprnt.c (doprnt): Fix the case where a multibyte sequence
605 produced by %s or %c overflows available buffer space. (Bug#8545)
606
607 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
608
609 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
610 (SIZE_MAX): Move defn after all includes, as they might #define it.
611
612 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
613
614 * w32.c (init_environment): Warn about defaulting HOME to C:\.
615
616 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
617
618 * keyboard.c (Qdelayed_warnings_hook): Define.
619 (command_loop_1): Run `delayed-warnings-hook'
620 if Vdelayed_warnings_list is non-nil.
621 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
622 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
623
624 2011-04-28 Eli Zaretskii <eliz@gnu.org>
625
626 * doprnt.c (doprnt): Don't return value smaller than the buffer
627 size if the message was truncated. (Bug#8545).
628
629 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
630
631 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
632 (Fx_window_property): #if-0 the whole functions, not just the bodies.
633
634 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
635
636 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
637
638 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
639
640 * makefile.w32-in: Update dependencies.
641
642 2011-04-27 Eli Zaretskii <eliz@gnu.org>
643
644 Improve `doprnt' and its usage. (Bug#8545)
645 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
646 `format_end'. Remove support for %l as a conversion specifier.
647 Don't use xrealloc. Improve diagnostics when the %l size modifier
648 is used. Update the commentary.
649
650 * eval.c (verror): Simplify calculation of size_t.
651
652 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
653 messages.
654
655 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
656
657 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
658 change.
659
660 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
661
662 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
663 This makes this file independent of the recent pseudovector change.
664
665 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
666
667 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
668
669 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
670 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
671 Remove unused local.
672 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
673
674 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
675 GCC 4.6.0 optimizes based on type-based alias analysis.
676 For example, if b is of type struct buffer * and v of type struct
677 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
678 != &v->size, and therefore "v->size = 1; b->size = 2; return
679 v->size;" must therefore return 1. This assumption is incorrect
680 for Emacs, since it type-puns struct Lisp_Vector * with many other
681 types. To fix this problem, this patch adds a new type struct
682 vectorlike_header that documents the constraints on layout of vectors
683 and pseudovectors, and helps optimizing compilers not get fooled
684 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
685 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
686 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
687 the size member.
688 (XSETPVECTYPE): Rewrite in terms of new macro.
689 (XSETPVECTYPESIZE): New macro, specifying both type and size.
690 This is a bit clearer, and further avoids the possibility of
691 undesirable aliasing.
692 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
693 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
694 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
695 since Lisp_Subr is a special case (no "next" field).
696 (ASIZE): Now uses header.size rather than size.
697 All previous uses of XVECTOR (foo)->size replaced to use this macro,
698 to avoid the hassle of writing XVECTOR (foo)->header.size.
699 (struct vectorlike_header): New type.
700 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
701 object, to help avoid aliasing.
702 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
703 (SUBRP): Likewise, since Lisp_Subr is a special case.
704 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
705 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
706 (struct Lisp_Hash_Table): Combine first two members into a single
707 struct vectorlike_header member. All uses of "size" and "next" members
708 changed to be "header.size" and "header.next".
709 * buffer.h (struct buffer): Likewise.
710 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
711 * frame.h (struct frame): Likewise.
712 * process.h (struct Lisp_Process): Likewise.
713 * termhooks.h (struct terminal): Likewise.
714 * window.c (struct save_window_data, struct saved_window): Likewise.
715 * window.h (struct window): Likewise.
716 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
717 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
718 * buffer.c (init_buffer_once): Likewise.
719 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
720 special case.
721 * process.c (Fformat_network_address): Use local var for size,
722 for brevity.
723
724 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
725
726 Make the Lisp reader and string-to-float more consistent (Bug#8525)
727 * data.c (atof): Remove decl; no longer used or needed.
728 (digit_to_number): Move to lread.c.
729 (Fstring_to_number): Use new string_to_number function, to be
730 consistent with how the Lisp reader treats infinities and NaNs.
731 Do not assume that floating-point numbers represent EMACS_INT
732 without losing information; this is not true on most 64-bit hosts.
733 Avoid double-rounding errors, by insisting on integers when
734 parsing non-base-10 numbers, as the documentation specifies.
735 * lisp.h (string_to_number): New decl, replacing ...
736 (isfloat_string): Remove.
737 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
738 (read1): Do not accept +. and -. as integers; this
739 appears to have been a coding error. Similarly, do not accept
740 strings like +-1e0 as floating point numbers. Do not report
741 overflow for integer overflows unless the base is not 10 which
742 means we have no simple and reliable way to continue.
743 Break out the floating-point parsing into a new
744 function string_to_number, so that Fstring_to_number parses
745 floating point numbers consistently with the Lisp reader.
746 (digit_to_number): Move here from data.c. Make it static inline.
747 (E_CHAR, EXP_INT): Remove, replacing with ...
748 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
749 (string_to_number): New function, replacing isfloat_string.
750 This function checks for valid syntax and produces the resulting
751 Lisp float number too. Rework it so that string-to-number
752 no longer mishandles examples like "1.0e+". Use strtoumax,
753 so that overflow for non-base-10 numbers is reported only when
754 there's no portable and simple way to convert to floating point.
755
756 * textprop.c (set_text_properties_1): Rewrite for clarity,
757 and to avoid GCC warning about integer overflow.
758
759 * intervals.h (struct interval): Use EMACS_INT for members
760 where EMACS_UINT might cause problems. See
761 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
762 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
763 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
764 All uses changed.
765 (offset_intervals): Tell GCC not to worry about length overflow
766 when negating a negative length.
767
768 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
769 (overrun_check_free): Likewise.
770
771 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
772 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
773 word size.
774
775 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
776 (gnutls_make_error): Rename local to avoid shadowing.
777 (gnutls_emacs_global_deinit): ifdef out; not used.
778 (Fgnutls_boot): Use const for pointer to readonly storage.
779 Comment out unused local. Fix pointer signedness problems.
780
781 * lread.c (openp): Don't stuff size_t into an 'int'.
782 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
783 about possible signed overflow.
784
785 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
786 (GDK_KEY_g): Don't define if already defined.
787 (xg_prepare_tooltip): Avoid pointer signedness problem.
788 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
789
790 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
791 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
792
793 * xfns.c (Fx_window_property): Simplify a bit,
794 to make a bit faster and to avoid GCC 4.6.0 warning.
795 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
796
797 * fns.c (internal_equal): Don't assume size_t fits in int.
798
799 * alloc.c (compact_small_strings): Tighten assertion a little.
800
801 Replace pEd with more-general pI, and fix some printf arg casts.
802 * lisp.h (pI): New macro, generalizing old pEd macro to other
803 conversion specifiers. For example, use "...%"pI"d..." rather
804 than "...%"pEd"...".
805 (pEd): Remove. All uses replaced with similar uses of pI.
806 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
807 * alloc.c (check_pure_size): Don't overflow by converting size to int.
808 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
809 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
810 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
811 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
812 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
813 64-bit hosts.
814 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
815 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
816 * print.c (safe_debug_print, print_object): Likewise.
817 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
818 to int.
819 Use pI instead of if-then-else-abort. Use %p to avoid casts,
820 avoiding the 0 flag, which is not portable.
821 * process.c (Fmake_network_process): Use pI to avoid cast.
822 * region-cache.c (pp_cache): Likewise.
823 * xdisp.c (decode_mode_spec): Likewise.
824 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
825 behavior on 64-bit hosts with printf arg.
826 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
827 (x_stop_queuing_selection_requests): Likewise.
828 (x_get_window_property): Don't truncate byte count to an 'int'
829 when tracing.
830
831 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
832 here, since it parses constructs like leading '-' and spaces,
833 which are not wanted; and it overflows with large numbers.
834 Instead, simply match F[0-9]+, which is what is wanted anyway.
835
836 * alloc.c: Remove unportable assumptions about struct layout.
837 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
838 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
839 (allocate_vectorlike, make_pure_vector): Use the new macros,
840 plus offsetof, to remove unportable assumptions about struct layout.
841 These assumptions hold on all porting targets that I know of, but
842 they are not guaranteed, they're easy to remove, and removing them
843 makes further changes easier.
844
845 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
846 This doesn't fix a bug but makes the code clearer.
847 (string_overrun_cookie): Now const. Use initializers that
848 don't formally overflow signed char, to avoid warnings.
849 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
850 can cause Emacs to crash when string overrun checking is enabled.
851 (allocate_buffer): Don't assume sizeof (struct buffer) is a
852 multiple of sizeof (EMACS_INT); it need not be, if
853 alignof(EMACS_INT) < sizeof (EMACS_INT).
854 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
855
856 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
857
858 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
859
860 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
861
862 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
863 supposed to be handshaking. (Bug#8556)
864 Reported by Paul Eggert <eggert@cs.ucla.edu>.
865
866 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
867
868 * lisp.h (Qdebug): List symbol.
869 * eval.c (Qdebug): Restore global linkage.
870 * keyboard.c (debug-on-event): New variable.
871 (handle_user_signal): Break into debugger when debug-on-event
872 matches the current signal symbol.
873
874 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
875
876 * alloc.c (check_sblock, check_string_bytes)
877 (check_string_free_list): Convert to standard C.
878
879 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
880
881 * w32.c (emacs_gnutls_push): Fix typo.
882
883 2011-04-25 Eli Zaretskii <eliz@gnu.org>
884
885 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
886 "cast to pointer from integer of different size".
887
888 Improve doprnt and its use in verror. (Bug#8545)
889 * doprnt.c (doprnt): Document the set of format control sequences
890 supported by the function. Use SAFE_ALLOCA instead of always
891 using `alloca'.
892
893 * eval.c (verror): Don't limit the buffer size at size_max-1, that
894 is one byte too soon. Don't use xrealloc; instead xfree and
895 xmalloc anew.
896
897 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
898
899 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
900 callbacks stage.
901
902 * gnutls.c: Renamed global_initialized to
903 gnutls_global_initialized. Added internals for the
904 :verify-hostname-error, :verify-error, and :verify-flags
905 parameters of `gnutls-boot' and documented those parameters in the
906 docstring. Start callback support.
907 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
908 unless a fatal error occured. Call gnutls_alert_send_appropriate
909 on error. Return error code.
910 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
911 (emacs_gnutls_read): Likewise.
912 (Fgnutls_boot): Return handshake error code.
913 (emacs_gnutls_handle_error): New function.
914 (wsaerror_to_errno): Likewise.
915
916 * w32.h (emacs_gnutls_pull): Add prototype.
917 (emacs_gnutls_push): Likewise.
918
919 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
920 (emacs_gnutls_push): Likewise.
921
922 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
923
924 * process.c (wait_reading_process_output): Check if GnuTLS
925 buffered some data internally if no FDs are set for TLS
926 connections.
927
928 * makefile.w32-in (OBJ2): Add gnutls.$(O).
929 (LIBS): Link to USER_LIBS.
930 ($(BLD)/gnutls.$(0)): New target.
931
932 2011-04-24 Eli Zaretskii <eliz@gnu.org>
933
934 * xdisp.c (handle_single_display_spec): Rename the
935 display_replaced_before_p argument into display_replaced_p, to
936 make it consistent with the commentary. Fix typos in the
937 commentary.
938
939 * textprop.c (syms_of_textprop): Remove dead code.
940 (copy_text_properties): Delete obsolete commentary about an
941 interface that was deleted long ago. Fix typos in the description
942 of arguments.
943
944 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
945 to changes in oldXMenu/XMenu.h from 2011-04-16.
946 <menu_help_message, prev_menu_help_message>: Constify.
947 (IT_menu_make_room): menu->help_text is now `const char **';
948 adjust.
949
950 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
951 to changes in oldXMenu/XMenu.h from 2011-04-16.
952 (struct XMenu): Declare `help_text' `const char **'.
953
954 * xfaces.c <Qunspecified>: Make extern again.
955
956 * syntax.c: Include sys/types.h before including regex.h, as
957 required by Posix.
958
959 * doc.c (get_doc_string): Improve the format passed to `error'.
960
961 * doprnt.c (doprnt): Improve commentary.
962
963 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
964
965 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
966 them with etags.
967
968 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
969 changes in globals.h immediately force recompilation.
970 (TAGS): Depend on $(CURDIR)/m/intel386.h and
971 $(CURDIR)/s/ms-w32.h.
972 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
973
974 * character.c (Fchar_direction): Function deleted.
975 (syms_of_character): Don't defsubr it.
976 <char-direction-table>: Deleted.
977
978 2011-04-23 Eli Zaretskii <eliz@gnu.org>
979
980 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
981 * doprnt.c: Include limits.h.
982 (SIZE_MAX): New macro.
983 (doprnt): Return a size_t value. 2nd arg is now size_t.
984 Many local variables are now size_t instead of int or unsigned.
985 Improve overflow protection. Support `l' modifier for integer
986 conversions. Support %l conversion. Don't assume an EMACS_INT
987 argument for integer conversions and for %c.
988
989 * lisp.h (doprnt): Restore prototype.
990
991 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
992 $(SRC)/character.h.
993
994 * Makefile.in (base_obj): Add back doprnt.o.
995
996 * deps.mk (doprnt.o): Add back prerequisites.
997 (callint.o): Depend on character.h.
998
999 * eval.c (internal_lisp_condition_case): Include the handler
1000 representation in the error message.
1001 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1002 when breaking from the loop.
1003
1004 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1005
1006 * callint.c (Fcall_interactively): When displaying error message
1007 about invalid control letter, pass the character's codepoint, not
1008 a pointer to its multibyte form. Improve display of the character
1009 in octal and display also its hex code.
1010
1011 * character.c (char_string): Use %x to display the (unsigned)
1012 codepoint of an invalid character, to avoid displaying a bogus
1013 negative value.
1014
1015 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1016 `error', not SYMBOL_NAME itself.
1017
1018 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1019 character arguments to `error'.
1020
1021 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1022 to `error' in error message about FINAL_CHAR argument. Make sure
1023 FINAL_CHAR is a character, and use %c when it is passed as
1024 argument to `error'.
1025
1026 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1027
1028 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1029
1030 * w32.c: Include <time.h>.
1031 (sys_localtime): New function.
1032
1033 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1034
1035 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1036
1037 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1038
1039 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1040
1041 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1042 zombies (Bug#8467).
1043
1044 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1045
1046 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1047 gl_state.e_property when gl_state.object is Qt.
1048
1049 * insdel.c (make_gap_larger): Remove limitation of buffer size
1050 to <= INT_MAX.
1051
1052 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1053
1054 * xdisp.c (lookup_glyphless_char_display)
1055 (produce_glyphless_glyph): Handle cons cell entry in
1056 glyphless-char-display.
1057 (Vglyphless_char_display): Document it.
1058
1059 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1060 glyphless-char-display.
1061
1062 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1063
1064 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1065
1066 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1067
1068 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1069 definition for no-X builds.
1070
1071 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1072
1073 Static checks with GCC 4.6.0 and non-default toolkits.
1074
1075 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1076
1077 * process.c (keyboard_bit_set): Define only if SIGIO.
1078 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1079 (send_process): Repair possible setjmp clobbering.
1080
1081 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1082
1083 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1084
1085 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1086
1087 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1088 Define only if needed.
1089
1090 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1091 by pacifying GCC about it. Maybe it's time to retire it?
1092 * xfaces.c (USG, __TIMEVAL__): Likewise.
1093
1094 * dispextern.h (struct redisplay_interface): Rename param
1095 to avoid shadowing.
1096 * termhooks.h (struct terminal): Likewise.
1097 * xterm.c (xembed_send_message): Likewise.
1098
1099 * insdel.c (make_gap_smaller): Define only if
1100 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1101
1102 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1103 it.
1104
1105 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1106 so that we aren't warned about unused symbols.
1107
1108 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1109
1110 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1111
1112 * xfns.c (x_real_positions): Mark locals as initialized.
1113
1114 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1115
1116 * xterm.c: Fix problems found by static analysis with other toolkits.
1117 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1118 (x_dispatch_event): Declare static if USE_GTK, and
1119 define if USE_GTK || USE_X_TOOLKIT.
1120 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1121 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1122 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1123 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1124
1125 * xmenu.c (menu_help_callback): Pointer type fixes.
1126 Use const pointers when pointing at readonly data. Avoid pointer
1127 signedness clashes.
1128 (FALSE): Remove unused macro.
1129 (update_frame_menubar): Remove unused decl.
1130
1131 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1132
1133 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1134 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1135 (single_menu_item): Rename local to avoid shadowing.
1136
1137 * keyboard.c (make_lispy_event): Remove unused local var.
1138
1139 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1140 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1141
1142 * bitmaps: Change bitmaps from unsigned char back to the X11
1143 compatible char. Avoid the old compiler warnings about
1144 out-of-range initializers by using, for example, '\xab' rather
1145 than 0xab.
1146
1147 * xgselect.c (xgselect_initialize): Check vs interface
1148 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1149
1150 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1151
1152 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1153 to read-only memory.
1154
1155 * fns.c (vector): Remove; this old hack is no longer needed.
1156
1157 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1158 Remove unused var.
1159 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1160
1161 * xrdb.c (x_load_resources): Omit unused local.
1162
1163 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1164 (x_window): Rename locals to avoid shadowing.
1165 (USG): Use the kludged USG macro, to pacify gcc.
1166
1167 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1168 (x_term_init): Remove local to avoid shadowing.
1169
1170 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1171
1172 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1173 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1174
1175 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1176
1177 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1178
1179 Fix regex.c, syntax.c and friends for buffers > 2GB.
1180 * syntax.h (struct gl_state_s): Declare character position members
1181 EMACS_INT.
1182
1183 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1184
1185 * textprop.c (verify_interval_modification, interval_of):
1186 Declare arguments EMACS_INT.
1187
1188 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1189 EMACS_INT.
1190
1191 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1192
1193 * indent.c (Fvertical_motion): Local variable it_start is now
1194 EMACS_INT.
1195
1196 * regex.c (re_match, re_match_2, re_match_2_internal)
1197 (bcmp_translate, regcomp, regexec, print_double_string)
1198 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1199 (re_compile_pattern, re_exec): Declare arguments and local
1200 variables `size_t' and `ssize_t' and return values `regoff_t', as
1201 appropriate.
1202 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1203 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1204 <compile_stack_type>: `size' and `avail' are now `size_t'.
1205
1206 * regex.h <regoff_t>: Use ssize_t, not int.
1207 (re_search, re_search_2, re_match, re_match_2): Arguments that
1208 specify buffer/string position and length are now ssize_t and
1209 size_t. Return type is regoff_t.
1210
1211 2011-04-16 Ben Key <bkey76@gmail.com>
1212
1213 * nsfont.m: Fixed bugs in ns_get_family and
1214 ns_descriptor_to_entity that were caused by using free to
1215 deallocate memory blocks that were allocated by xmalloc (via
1216 xstrdup). This caused Emacs to crash when compiled with
1217 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1218 --enable-checking=xmallocoverrun). xfree is now used to
1219 deallocate these memory blocks.
1220
1221 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1222
1223 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1224
1225 emacs_write: Accept and return EMACS_INT for sizes.
1226 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1227 et seq.
1228 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1229 Accept and return EMACS_INT.
1230 (emacs_gnutls_write): Return the number of bytes written on
1231 partial writes.
1232 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1233 (emacs_read, emacs_write): Remove check for negative size, as the
1234 Emacs source code has been audited now.
1235 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1236 (emacs_read, emacs_write): Use it.
1237 * process.c (send_process): Adjust to the new signatures of
1238 emacs_write and emacs_gnutls_write. Do not attempt to store
1239 a byte offset into an 'int'; it might overflow.
1240 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1241
1242 * sound.c: Don't assume sizes fit in 'int'.
1243 (struct sound_device.period_size, alsa_period_size):
1244 Return EMACS_INT, not int.
1245 (struct sound_device.write, vox_write, alsa_write):
1246 Accept EMACS_INT, not int.
1247 (wav_play, au_play): Use EMACS_INT to store sizes and to
1248 record read return values.
1249
1250 2011-04-15 Ben Key <bkey76@gmail.com>
1251
1252 * keyboard.c (Qundefined): Don't declare static since it is used
1253 in nsfns.m.
1254 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1255 static since they are used in nsfont.m.
1256
1257 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1258
1259 * process.c (Qprocessp): Don't declare static.
1260 * lisp.h (Qprocessp): Declare again.
1261
1262 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1263
1264 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1265
1266 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1267
1268 Improve C-level modularity by making more things 'static'.
1269
1270 Don't publish debugger-only interfaces to other modules.
1271 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1272 (verify_bytepos, count_markers): Move decls to the only modules
1273 that need them.
1274 * region-cache.h (pp_cache): Likewise.
1275 * window.h (check_all_windows): Likewise.
1276 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1277
1278 * sysdep.c (croak): Now static, if
1279 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1280 * syssignal.h (croak): Declare only if not static.
1281
1282 * alloc.c (refill_memory_reserve): Now static if
1283 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1284 * lisp.h (refill_memory_reserve): Declare only if not static.
1285
1286 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1287 Define only if USE_LUCID.
1288
1289 * xrdb.c (x_customization_string, x_rm_string): Now static.
1290
1291 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1292 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1293
1294 * xdisp.c (draw_row_with_mouse_face): Now static.
1295 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1296
1297 * window.h (check_all_windows): Mark externally visible.
1298
1299 * window.c (window_deletion_count): Now static.
1300
1301 * undo.c: Make symbols static if they're not exported.
1302 (last_undo_buffer, last_boundary_position, pending_boundary):
1303 Now static.
1304
1305 * textprop.c (interval_insert_behind_hooks): Now static.
1306 (interval_insert_in_front_hooks): Likewise.
1307
1308 * term.c: Make symbols static if they're not exported.
1309 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1310 (max_frame_lines, tty_set_terminal_modes):
1311 (tty_reset_terminal_modes, tty_turn_off_highlight):
1312 (get_tty_terminal): Now static.
1313 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1314 * termhooks.h (term_mouse_moveto): Do not declare if
1315 HAVE_WINDOW_SYSTEM.
1316 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1317 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1318
1319 * sysdep.c: Make symbols static if they're not exported.
1320 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1321 Now static.
1322 (sigprocmask_set, full_mask): Remove; unused.
1323 (wait_debugging): Mark as visible.
1324 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1325 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1326
1327 * syntax.c (syntax_temp): Define only if !__GNUC__.
1328
1329 * sound.c (current_sound_device, current_sound): Now static.
1330
1331 * search.c (searchbufs, searchbuf_head): Now static.
1332
1333 * scroll.c (scroll_cost): Remove; unused.
1334 * dispextern.h (scroll_cost): Remove decl.
1335
1336 * region-cache.h (pp_cache): Mark as externally visible.
1337
1338 * process.c: Make symbols static if they're not exported.
1339 (process_tick, update_tick, create_process, chan_process):
1340 (Vprocess_alist, proc_buffered_char, datagram_access):
1341 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1342 (deactivate_process): Mark defn as static, as well as decl.
1343 * lisp.h (create_process): Remove decl.
1344 * process.h (chan_process, Vprocess_alist): Remove decls.
1345
1346 * print.c: Make symbols static if they're not exported.
1347 (print_depth, new_backquote_output, being_printed, print_buffer):
1348 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1349 (print_interval, print_number_index, initial_stderr_stream):
1350 Now static.
1351 * lisp.h (Fprinc): Remove decl.
1352 (debug_output_compilation_hack): Mark as externally visible.
1353
1354 * sysdep.c (croak): Move decl from here to syssignal.h.
1355 * syssignal.h (croak): Put it here, so the API can be checked when
1356 'croak' is called from dissociate_if_controlling_tty.
1357
1358 * minibuf.c: Make symbols static if they're not exported.
1359 (minibuf_save_list, choose_minibuf_frame): Now static.
1360 * lisp.h (choose_minibuf_frame): Remove decl.
1361
1362 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1363
1364 * lread.c: Make symbols static if they're not exported.
1365 (read_objects, initial_obarray, oblookup_last_bucket_number):
1366 Now static.
1367 (make_symbol): Remove; unused.
1368 * lisp.h (initial_obarray, make_symbol): Remove decls.
1369
1370 * keyboard.c: Make symbols static if they're not exported.
1371 (single_kboard, recent_keys_index, total_keys, recent_keys):
1372 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1373 (this_single_command_key_start, echoing, last_auto_save):
1374 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1375 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1376 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1377 (Vlispy_mouse_stem, double_click_count):
1378 Now static.
1379 (force_auto_save_soon): Define only if SIGDANGER.
1380 (ignore_mouse_drag_p): Now static if
1381 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1382 (print_help): Remove; unused.
1383 (stop_character, last_timer_event): Mark as externally visible.
1384 * keyboard.h (ignore_mouse_drag_p): Declare only if
1385 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1386 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1387 * lisp.h (echoing): Remove decl.
1388 (force_auto_save_soon): Declare only if SIGDANGER.
1389 * xdisp.c (redisplay_window): Simplify code, to make it more
1390 obvious that ignore_mouse_drag_p is not accessed if !defined
1391 USE_GTK && !defined HAVE_NS.
1392
1393 * intervals.c: Make symbols static if they're not exported.
1394 (merge_properties_sticky, merge_interval_right, delete_interval):
1395 Now static.
1396 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1397
1398 * insdel.c: Make symbols static if they're not exported.
1399 However, leave prepare_to_modify_buffer alone. It's never
1400 called from outside this function, but that appears to be a bug.
1401 (combine_after_change_list, combine_after_change_buffer):
1402 (adjust_after_replace, signal_before_change): Now static.
1403 (adjust_after_replace_noundo): Remove; unused.
1404 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1405 (signal_before_change): Remove decls.
1406
1407 * indent.c (val_compute_motion, val_vmotion): Now static.
1408
1409 * image.c: Make symbols static if they're not exported.
1410 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1411 if USE_GTK.
1412 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1413 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1414
1415 * fringe.c (standard_bitmaps): Now static.
1416 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1417
1418 * frame.c: Make symbols static if they're not exported.
1419 (x_report_frame_params, make_terminal_frame): Now static.
1420 (get_frame_param): Now static, unless HAVE_NS.
1421 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1422 (x_get_resource_string): Remove; not used.
1423 * frame.h (make_terminal_frame, x_report_frame_params):
1424 (x_get_resource_string); Remove decls.
1425 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1426 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1427
1428 * font.c, fontset.c: Make symbols static if they're not exported.
1429 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1430 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1431 * font.c (font_close_object): Now static.
1432 * font.h (font_close_object): Remove.
1433 * fontset.c (FONTSET_OBJLIST): Remove.
1434 (free_realized_fontset) #if-0 the body, which does nothing.
1435 (face_suitable_for_char_p): #if-0, as it's never called.
1436 * fontset.h (face_suitable_for_char_p): Remove decl.
1437 * xfaces.c (face_at_string_position):
1438 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1439 since 0 is always ASCII.
1440
1441 * fns.c (weak_hash_tables): Now static.
1442
1443 * fileio.c: Make symbols static if they're not exported.
1444 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1445 (Vwrite_region_annotation_buffers): Now static.
1446
1447 * eval.c: Make symbols static if they're not exported.
1448 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1449 * lisp.h (backtrace_list): Remove decl.
1450
1451 * emacs.c: Make symbols static if they're not exported.
1452 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1453 (fatal_error_code, fatal_error_signal_hook, standard_args):
1454 Now static.
1455 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1456 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1457 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1458 * lisp.h (fatal_error_signal_hook): Remove decl.
1459 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1460
1461 * editfns.c: Move a (normally-unused) function to its only use.
1462 * editfns.c, lisp.h (get_operating_system_release): Remove.
1463 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1464 worth the hassle of breaking this out.
1465
1466 * xterm.c: Make symbols static if they're not exported.
1467 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1468 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1469 (x_destroy_window, x_delete_display):
1470 Now static.
1471 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1472 (x_mouse_leave): Remove; unused.
1473 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1474 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1475 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1476 Remove decls.
1477 (x_mouse_leave): Declare only if WINDOWSNT.
1478 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1479 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1480 USE_X_TOOLKIT.
1481
1482 * ftxfont.c: Make symbols static if they're not exported.
1483 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1484 HAVE_FREETYPE.
1485 * font.h (ftxfont_driver): Likewise.
1486
1487 * xfns.c: Make symbols static if they're not exported.
1488 (x_last_font_name, x_display_info_for_name):
1489 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1490 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1491 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1492 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1493 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1494 (last_show_tip_args): Now static.
1495 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1496 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1497 (x_screen_planes): Remove; unused.
1498 * dispextern.h (x_screen_planes): Remove decl.
1499
1500 * dispnew.c: Make symbols static if they're not exported.
1501 * dispextern.h (redraw_garbaged_frames, scrolling):
1502 (increment_row_positions): Remove.
1503 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1504 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1505 Now static.
1506 (redraw_garbaged_frames): Remove; unused.
1507
1508 * xfaces.c: Make symbols static if they're not exported.
1509 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1510 Remove decls.
1511 * xterm.h (defined_color): Remove decls.
1512 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1513 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1514 (menu_face_changed_default, defined_color, free_realized_face):
1515 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1516 (ascii_face_of_lisp_face): Remove; unused.
1517
1518 * xdisp.c: Make symbols static if they're not exported.
1519 * dispextern.h (scratch_glyph_row, window_box_edges):
1520 (glyph_to_pixel_coords, set_cursor_from_row):
1521 (get_next_display_element, set_iterator_to_next):
1522 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1523 (show_mouse_face): Remove decls
1524 * frame.h (message_buf_print): Likewise.
1525 * lisp.h (pop_message, set_message, check_point_in_composition):
1526 Likewise.
1527 * xterm.h (set_vertical_scroll_bar): Likewise.
1528 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1529 (message_buf_print, scratch_glyph_row, displayed_buffer):
1530 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1531 (get_next_display_element, show_mouse_face, window_box_edges):
1532 (frame_to_window_pixel_xy, check_point_in_composition):
1533 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1534 (glyph_to_pixel_coords): Remove; unused.
1535
1536 * dired.c (file_name_completion): Now static.
1537
1538 * dbusbind.c (xd_in_read_queued_messages): Now static.
1539
1540 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1541 * data.c (circular_list_error): Remove.
1542
1543 * commands.h (last_point_position, last_point_position_buffer):
1544 (last_point_position_window): Remove decls.
1545 * keyboard.c: Make these variables static.
1546
1547 * coding.h (coding, code_convert_region, encode_coding_gap):
1548 Remove decls.
1549 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1550 (iso_code_class, detect_coding, code_convert_region): Now static.
1551 (encode_coding_gap): Remove; unused.
1552
1553 * chartab.c (chartab_chars, chartab_bits): Now static.
1554
1555 * charset.h (charset_iso_8859_1): Remove decl.
1556 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1557 Now static.
1558
1559 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1560 * ccl.c (Vccl_program_table): Now static.
1561 (check_ccl_update): Remove; unused.
1562
1563 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1564 * category.h: ... from here.
1565 * category.c (check_category_table, set_category_set): Now static.
1566
1567 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1568 * lisp.h: Remove these decls.
1569
1570 * buffer.c (buffer_count): Remove unused var.
1571
1572 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1573 so that it's not optimized away.
1574 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1575 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1576 exported only to the debugger.
1577
1578 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1579 * atimer.h (run_all_atimers): Remove; not exported.
1580
1581 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1582 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1583 was inaccessible from Lisp.
1584 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1585 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1586
1587 alloc.c: Import and export fewer symbols, and remove unused items.
1588 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1589 is defined.
1590 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1591 it's not optimized away by whole-program optimization.
1592 (message_enable_multibyte, free_misc): Remove.
1593 (catchlist, handlerlist, mark_backtrace):
1594 Declare only if BYTE_MARK_STACK.
1595 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1596 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1597 (message_enable_multibyte): Remove decl.
1598 (free_misc, interval_free_list, float_block, float_block_index):
1599 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1600 (cons_free_list, last_marked_index):
1601 Now static.
1602 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1603 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1604 (mark_backtrace): Define only if BYTE_MARK_STACK.
1605 * xdisp.c (message_enable_multibyte): Now static.
1606
1607 Declare Lisp_Object Q* variables to be 'static' if not exported.
1608 This makes it easier for human readers (and static analyzers)
1609 to see whether these variables are used from other modules.
1610 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1611 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1612 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1613 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1614 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1615 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1616 * xmenu.c, xselect.c:
1617 Declare Q* vars static if they are not used in other modules.
1618 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1619 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1620 Remove decls of unexported vars.
1621 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1622
1623 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1624
1625 Make Emacs functions such as Fatom 'static' by default.
1626 This makes it easier for human readers (and static analyzers)
1627 to see whether these functions can be called from other modules.
1628 DEFUN now defines a static function. To make the function external
1629 so that it can be used in other C modules, use the new macro DEFUE.
1630 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1631 (Finit_image_library):
1632 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1633 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1634 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1635 Remove decls, since these functions are now static.
1636 (Funintern, Fget_internal_run_time): New decls, since these functions
1637 were already external.
1638
1639 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1640 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1641 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1642 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1643 * keyboard.c, keymap.c, lread.c:
1644 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1645 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1646 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1647 Mark functions with DEFUE instead of DEFUN,
1648 if they are used in other modules.
1649 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1650 decls for now-static functions.
1651 * buffer.h (Fdelete_overlay): Remove decl.
1652 * callproc.c (Fgetenv_internal): Mark as internal.
1653 * composite.c (Fremove_list_of_text_properties): Remove decl.
1654 (Fcomposition_get_gstring): New forward static decl.
1655 * composite.h (Fcomposite_get_gstring): Remove decl.
1656 * dired.c (Ffile_attributes): New forward static decl.
1657 * doc.c (Fdocumntation_property): New forward static decl.
1658 * eval.c (Ffetch_bytecode): New forward static decl.
1659 (Funintern): Remove extern decl; now in .h file where it belongs.
1660 * fileio.c (Fmake_symbolic_link): New forward static decl.
1661 * image.c (Finit_image_library): New forward static decl.
1662 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1663 * intervals.h (Fprevious_property_change):
1664 (Fremove_list_of_text_properties): Remove decls.
1665 * keyboard.c (Fthis_command_keys): Remove decl.
1666 (Fcommand_execute): New forward static decl.
1667 * keymap.c (Flookup_key): New forward static decl.
1668 (Fcopy_keymap): Now static.
1669 * keymap.h (Flookup_key): Remove decl.
1670 * process.c (Fget_process): New forward static decl.
1671 (Fprocess_datagram_address): Mark as internal.
1672 * syntax.c (Fsyntax_table_p): New forward static decl.
1673 (skip_chars): Remove duplicate decl.
1674 * textprop.c (Fprevious_property_change): New forward static decl.
1675 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1676 Now internal.
1677 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1678 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1679
1680 * editfns.c (Fformat): Remove unreachable code.
1681
1682 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1683
1684 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1685 change. (Bug#8496)
1686
1687 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1688
1689 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1690 when at ZV. (Bug#8487)
1691
1692 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1693
1694 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1695 (Bug#8437)
1696 * keyboard.c (parse_tool_bar_item): Likewise.
1697 * sound.c (sound_cleanup, alsa_close): Likewise.
1698 * termcap.c (tgetent): Likewise.
1699 * xfns.c (x_default_font_parameter): Likewise.
1700 * xsettings.c (read_and_apply_settings): Likewise.
1701
1702 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1703 (overrun_check_free): Protoize.
1704
1705 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1706
1707 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1708 since callers should never pass a negative size.
1709 Change the signature to match that of plain 'read' and 'write'; see
1710 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1711 * lisp.h: Update prototypes of emacs_write and emacs_read.
1712
1713 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1714
1715 * xdisp.c (redisplay_window): Don't try to determine the character
1716 position of the scroll margin if the window start point w->startp
1717 is outside the buffer's accessible region. (Bug#8468)
1718
1719 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1720
1721 Fix write-region and its subroutines for buffers > 2GB.
1722 * fileio.c (a_write, e_write): Modify declaration of arguments and
1723 local variables to support buffers larger than 2GB.
1724 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1725
1726 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1727 argument, local variables, and return value.
1728
1729 * lisp.h: Update prototypes of emacs_write and emacs_read.
1730
1731 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1732
1733 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1734
1735 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1736
1737 Fix more problems found by GCC 4.6.0's static checks.
1738
1739 * xdisp.c (vmessage): Use a better test for character truncation.
1740
1741 * charset.c (load_charset_map): <, not <=, for optimization,
1742 and to avoid potential problems with integer overflow.
1743 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1744 * casetab.c (set_identity, shuffle): Likewise.
1745 * editfns.c (Fformat): Likewise.
1746 * syntax.c (skip_chars): Likewise.
1747
1748 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1749 This also lets GCC 4.6.0 generate slightly better loop code.
1750
1751 * callint.c (Fcall_interactively): <, not <=, for optimization.
1752 (Fcall_interactively): Count the number of arguments produced,
1753 not the number of arguments given. This is simpler and lets GCC
1754 4.6.0 generate slightly better code.
1755
1756 * ftfont.c: Distingish more carefully between FcChar8 and char.
1757 The previous code passed unsigned char * to a functions like
1758 strlen and xstrcasecmp that expect char *, which does not
1759 conform to the C standard.
1760 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1761 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1762 char * when the C standard requires it.
1763
1764 * keyboard.c (read_char): Remove unused var.
1765
1766 * eval.c: Port to Windows vsnprintf (Bug#8435).
1767 Include <limits.h>.
1768 (SIZE_MAX): Define if the headers do not.
1769 (verror): Do not give up if vsnprintf returns a negative count.
1770 Instead, grow the buffer. This ports to Windows vsnprintf, which
1771 does not conform to C99. Problem reported by Eli Zaretskii.
1772 Also, simplify the allocation scheme, by avoiding the need for
1773 calling realloc, and removing the ALLOCATED variable.
1774
1775 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1776
1777 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1778 But keep the doprint source code for now, as we might revamp it
1779 and use it again (Bug#8435).
1780 * lisp.h (doprnt): Remove.
1781 * Makefile.in (base_obj): Remove doprnt.o.
1782 * deps.mk (doprnt.o): Remove.
1783
1784 error: Print 32- and 64-bit integers portably (Bug#8435).
1785 Without this change, on typical 64-bit hosts error ("...%d...", N)
1786 was used to print both 32- and 64-bit integers N, which relied on
1787 undefined behavior.
1788 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1789 New macro.
1790 * lisp.h (error, verror): Mark as printf-like functions.
1791 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1792 Report overflow in size calculations when allocating printf buffer.
1793 Do not truncate output string at its first null byte.
1794 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1795 Truncate the output at a character boundary, since vsnprintf does not
1796 do that.
1797 * charset.c (check_iso_charset_parameter): Convert internal
1798 character to string before calling 'error', since %c now has the
1799 printf meaning.
1800 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1801 overflow when computing char to be passed to 'error'. Do not
1802 pass Lisp_Object to 'error'; pass the integer instead.
1803 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1804 formatted with plain %d.
1805
1806 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1807
1808 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1809
1810 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1811
1812 * xterm.c (x_catch_errors): Remove duplicate declaration.
1813
1814 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1815
1816 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1817
1818 2011-04-10 Jim Meyering <meyering@redhat.com>
1819
1820 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1821 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1822 return ssize_t not "int", and use size_t as the buffer length.
1823 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1824 * gnutls.h: Update declarations.
1825 * process.c (read_process_output): Use ssize_t, to match.
1826 (send_process): Likewise.
1827
1828 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1829
1830 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1831
1832 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1833
1834 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
1835 Use unsigned char, to match FcChar8 type definition.
1836
1837 * xterm.c (handle_one_xevent):
1838 * xmenu.c (create_and_show_popup_menu):
1839 * xselect.c (x_decline_selection_request)
1840 (x_reply_selection_request): Avoid type-punned deref of X events.
1841
1842 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1843
1844 Fix some uses of `int' instead of EMACS_INT.
1845 * search.c (string_match_1, fast_string_match)
1846 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1847 (scan_buffer, find_next_newline_no_quit)
1848 (find_before_next_newline, search_command, Freplace_match)
1849 (Fmatch_data): Make some `int' variables be EMACS_INT.
1850
1851 * xdisp.c (display_count_lines): 3rd argument and return value now
1852 EMACS_INT. All callers changed.
1853 (pint2hrstr): Last argument is now EMACS_INT.
1854
1855 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1856 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1857 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1858 (decode_coding_utf_16, decode_coding_emacs_mule)
1859 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1860 (decode_coding_ccl, decode_coding_charset)
1861 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1862 (decode_coding_iso_2022, decode_coding_emacs_mule)
1863 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1864 <char_offset, last_offset>: Declare EMACS_INT.
1865 (encode_coding_utf_8, encode_coding_utf_16)
1866 (encode_coding_emacs_mule, encode_invocation_designation)
1867 (encode_designation_at_bol, encode_coding_iso_2022)
1868 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1869 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1870 Declare EMACS_INT.
1871 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1872 (encode_invocation_designation): Last argument P_NCHARS is now
1873 EMACS_INT.
1874 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1875 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1876
1877 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1878 All users changed.
1879
1880 * ccl.c (Fccl_execute_on_string): Declare some variables
1881 EMACS_INT.
1882
1883 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1884
1885 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1886
1887 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1888
1889 * process.c (Fformat_network_address): Doc fix.
1890
1891 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1892
1893 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1894
1895 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1896
1897 * keyboard.c (read_char): Call Lisp function help-form-show,
1898 instead of using internal_with_output_to_temp_buffer.
1899 (Qhelp_form_show): New var.
1900 (syms_of_keyboard): Use DEFSYM macro.
1901
1902 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1903
1904 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1905
1906 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1907
1908 * process.c (Flist_processes): Remove to Lisp.
1909 (list_processes_1): Delete.
1910
1911 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1912
1913 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1914
1915 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1916
1917 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1918
1919 Fix more problems found by GCC 4.6.0's static checks.
1920
1921 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1922
1923 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1924
1925 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1926
1927 * xdisp.c (vmessage): Mark as a printf-like function.
1928
1929 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1930
1931 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1932
1933 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1934 printf-like functions.
1935 (tiff_load): Add casts to remove these marks before passing them
1936 to system-supplied API.
1937
1938 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1939
1940 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1941 This avoids several warnings with gcc -Wstrict-overflow.
1942 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1943 directly, rather than having caller test rule sign. This avoids
1944 some unnecessary tests.
1945 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1946 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1947 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1948
1949 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1950 (xfont_open): Avoid unnecessary tests.
1951
1952 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1953
1954 * composite.h, composite.c (composition_gstring_put_cache):
1955 Use EMACS_INT, not int, for length.
1956
1957 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1958 breaking out part of COMPOSITION_DECODE_RULE.
1959 (COMPOSITION_DECODE_RULE): Use it.
1960 * composite.c (get_composition_id): Remove unused local vars,
1961 by using the new macro.
1962
1963 * textprop.c (set_text_properties_1): Change while to do-while,
1964 since the condition is always true at first.
1965
1966 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1967 (interval_deletion_adjustment): Return unsigned value.
1968 All uses changed.
1969
1970 * process.c (list_processes_1, create_pty, read_process_output):
1971 (exec_sentinel): Remove vars that were set but not used.
1972 (create_pty): Remove unnecessary "volatile"s.
1973 (Fnetwork_interface_info): Avoid possibility of int overflow.
1974 (read_process_output): Do adaptive read buffering even if carryover.
1975 (read_process_output): Simplify nbytes computation if buffered.
1976
1977 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1978
1979 * syntax.c (scan_words): Remove var that was set but not used.
1980 (update_syntax_table): Use unsigned instead of int.
1981
1982 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1983 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1984 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1985
1986 * print.c (print_error_message): Avoid int overflow.
1987
1988 * font.c (font_list_entities): Redo for clarity,
1989 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1990
1991 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1992 (font_score): Avoid potential overflow in diff calculation.
1993
1994 * fns.c (substring_both): Remove var that is set but not used.
1995 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1996
1997 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1998
1999 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2000 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2001 can always succeed if overflow has undefined behavior.
2002
2003 * search.c (boyer_moore, wordify): Remove vars set but not used.
2004 (wordify): Omit three unnecessary tests.
2005
2006 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2007 All callers changed. This avoids the need for an unused var.
2008
2009 * casefiddle.c (casify_region): Remove var that is set but not used.
2010
2011 * dired.c (file_name_completion): Remove var that is set but not used.
2012
2013 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2014
2015 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2016 (Finsert_file_contents): Remove unnecessary code checking fd.
2017
2018 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2019 Check for integer overflow on size calculations.
2020
2021 * buffer.c (Fprevious_overlay_change): Remove var that is set
2022 but not used.
2023
2024 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2025 Remove vars that are set but not used.
2026 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2027 (timer_check_2): Mark vars as initialized.
2028
2029 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2030
2031 * image.c (lookup_image): Remove var that is set but not used.
2032 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2033
2034 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2035 that are set but not used.
2036
2037 * xfns.c (make_invisible_cursor): Don't return garbage
2038 if XCreateBitmapFromData fails (Bug#8410).
2039
2040 * xselect.c (x_get_local_selection, x_handle_property_notify):
2041 Remove vars that are set but not used.
2042
2043 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2044 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2045
2046 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2047 Remove var that is set but not used.
2048 (scroll_bar_windows_size): Now size_t, not int.
2049 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2050 Check for overflow.
2051
2052 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2053 (map_tty_color) [!defined MSDOS]: Likewise.
2054
2055 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2056
2057 * coding.c: Remove vars that are set but not used.
2058 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2059 All callers changed.
2060 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2061 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2062 (decode_coding_charset): Remove vars that are set but not used.
2063
2064 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2065 that is set but not used.
2066
2067 * print.c (print_object): Remove var that is set but not used.
2068
2069 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2070 The gnulib version avoids calling malloc in the usual case,
2071 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2072 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2073 * filelock.c (current_lock_owner): Likewise.
2074 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2075 * sysdep.c: Include allocator.h, careadlinkat.h.
2076 (emacs_no_realloc_allocator): New static constant.
2077 (emacs_readlink): New function.
2078 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2079 ../lib/careadlinkat.h.
2080
2081 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2082
2083 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2084 first non-nil return value).
2085
2086 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2087
2088 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2089 if not defined (Bug#8403).
2090
2091 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2092
2093 * xdisp.c (display_count_lines): Remove parameter `start',
2094 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2095 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2096 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2097 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2098 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2099 and thereabouts. All callers changed.
2100 (get_per_char_metric): Remove parameter `f', unused since
2101 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2102
2103 2011-04-02 Jim Meyering <meyering@redhat.com>
2104
2105 do not dereference NULL upon failed strdup
2106 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2107 (ns_get_family): Likewise.
2108
2109 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2110
2111 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2112
2113 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2114
2115 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2116 later (Bug#8403).
2117
2118 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2119
2120 Add lexical binding.
2121
2122 * window.c (Ftemp_output_buffer_show): New fun.
2123 (Fsave_window_excursion):
2124 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2125
2126 * lread.c (lisp_file_lexically_bound_p): New function.
2127 (Fload): Bind Qlexical_binding.
2128 (readevalloop): Remove `evalfun' arg.
2129 Bind Qinternal_interpreter_environment.
2130 (Feval_buffer): Bind Qlexical_binding.
2131 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2132 Mark as dynamic.
2133 (syms_of_lread): Declare `lexical-binding'.
2134
2135 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2136
2137 * keyboard.c (eval_dyn): New fun.
2138 (menu_item_eval_property): Use it.
2139
2140 * image.c (parse_image_spec): Use Ffunctionp.
2141
2142 * fns.c (concat, mapcar1): Accept byte-code-functions.
2143
2144 * eval.c (Fsetq): Handle lexical vars.
2145 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2146 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2147 (FletX, Flet): Obey lexical binding.
2148 (Fcommandp): Handle closures.
2149 (Feval): New `lexical' arg.
2150 (eval_sub): New function extracted from Feval. Use it almost
2151 everywhere where Feval was used. Look up vars in lexical env.
2152 Handle closures.
2153 (Ffunctionp): Move from subr.el.
2154 (Ffuncall): Handle closures.
2155 (apply_lambda): Remove `eval_flags'.
2156 (funcall_lambda): Handle closures and new byte-code-functions.
2157 (Fspecial_variable_p): New function.
2158 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2159 but without exporting it to Lisp.
2160
2161 * doc.c (Fdocumentation, store_function_docstring):
2162 * data.c (Finteractive_form): Handle closures.
2163
2164 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2165 interactive spec.
2166
2167 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2168 New byte-codes.
2169 (exec_byte_code): New function extracted from Fbyte_code to handle new
2170 calling convention for byte-code-functions. Add new byte-codes.
2171
2172 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2173
2174 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2175
2176 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2177
2178 * xdisp.c (redisplay_internal): Fix prototype.
2179
2180 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2181
2182 * xdisp.c (SCROLL_LIMIT): New macro.
2183 (try_scrolling): Use it when setting scroll_limit.
2184 Limit scrolling to 100 screen lines.
2185 (redisplay_window): Even when falling back on "recentering",
2186 position point in the window according to scroll-conservatively,
2187 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2188
2189 (try_scrolling): When point is above the window, allow searching
2190 as far as scroll_max, or one screenful, to compute vertical
2191 distance from PT to the scroll margin position. This prevents
2192 try_scrolling from unnecessarily failing when
2193 scroll-conservatively is set to a value slightly larger than the
2194 window height. Clean up the case of PT below the margin at bottom
2195 of window: scroll_max can no longer be INT_MAX. When aggressive
2196 scrolling is in use, don't let point enter the opposite scroll
2197 margin as result of the scroll.
2198 (syms_of_xdisp) <scroll-conservatively>: Document the
2199 threshold of 100 lines for never-recentering scrolling.
2200
2201 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2202
2203 * dispextern.h (move_it_by_lines):
2204 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2205 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2206 (message_log_check_duplicate): Remove parameters `prev_bol' and
2207 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2208 (redisplay_internal): Remove parameter `preserve_echo_area',
2209 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2210
2211 * indent.c (Fvertical_motion):
2212 * window.c (window_scroll_pixel_based, Frecenter):
2213 Don't pass `need_y_p' to `move_it_by_lines'.
2214
2215 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2216
2217 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2218 steal a few bits to be more compact.
2219 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2220 Remove unneeded casts.
2221
2222 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2223
2224 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2225
2226 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2227 binding" message (bug#7967).
2228
2229 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2230
2231 Fix more problems found by GCC 4.6.0's static checks.
2232
2233 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2234 Remove unused local var.
2235
2236 * editfns.c (Fmessage_box): Remove unused local var.
2237
2238 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2239 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2240 Omit unused local vars.
2241 * window.c (shrink_windows): Omit unused local var.
2242 * menu.c (digest_single_submenu): Omit unused local var.
2243 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2244 Omit unused local var.
2245
2246 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2247 Don't assume string length fits in int.
2248 (keyremap_step, read_key_sequence): Use size_t for sizes.
2249 (read_key_sequence): Don't check last_real_key_start redundantly.
2250
2251 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2252 instead of alloca (Bug#8344).
2253
2254 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2255 (Fbacktrace_frame): Don't assume nframes fits in int.
2256
2257 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2258
2259 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2260 concerns.
2261
2262 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2263
2264 * cm.c (calccost): Turn while-do into do-while, for clarity.
2265
2266 * keyboard.c (syms_of_keyboard): Use the same style as later
2267 in this function when indexing through an array. This also
2268 works around GCC bug 48267.
2269
2270 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2271
2272 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2273
2274 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2275 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2276
2277 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2278 This avoids undefined behavior on integer overflow, and is a bit
2279 more convenient anyway since it is compared to a size_t variable.
2280
2281 Variadic C functions now count arguments with size_t, not int.
2282 This avoids an unnecessary limitation on 64-bit machines, which
2283 caused (substring ...) to crash on large vectors (Bug#8344).
2284 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2285 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2286 All variadic functions and their callers changed accordingly.
2287 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2288 * data.c (arith_driver, float_arith_driver): Likewise.
2289 * editfns.c (general_insert_function): Likewise.
2290 * eval.c (struct backtrace.nargs, interactive_p)
2291 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2292 (funcall_lambda, mark_backtrace): Likewise.
2293 * fns.c (concat): Likewise.
2294 * frame.c (x_set_frame_parameters): Likewise.
2295 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2296 0 if not found, not -1. All callers changed.
2297
2298 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2299 (stack_copy_size): Now size_t, not int.
2300 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2301
2302 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2303
2304 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2305 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2306 All callers changed.
2307
2308 * lisp.h (multibyte_char_to_unibyte):
2309 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2310 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2311 * character.h (CHAR_TO_BYTE8):
2312 * cmds.c (internal_self_insert):
2313 * editfns.c (general_insert_function):
2314 * keymap.c (push_key_description):
2315 * search.c (Freplace_match):
2316 * xdisp.c (message_dolog, set_message_1): All callers changed.
2317
2318 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2319
2320 * keyboard.c (safe_run_hook_funcall): New function.
2321 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2322 don't set the hook to nil, but remove the offending function instead.
2323 (Qcommand_hook_internal): Remove, unused.
2324 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2325 Vcommand_hook_internal.
2326
2327 * eval.c (enum run_hooks_condition): Remove.
2328 (funcall_nil, funcall_not): New functions.
2329 (run_hook_with_args): Call each function through a `funcall' argument.
2330 Remove `cond' argument, now redundant.
2331 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2332 (Frun_hook_with_args_until_failure): Adjust accordingly.
2333 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2334
2335 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2336
2337 * dispextern.h (string_buffer_position): Remove declaration.
2338
2339 * print.c (strout): Remove parameter `multibyte', unused since
2340 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2341
2342 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2343 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2344 All callers changed.
2345
2346 * w32.c (_wsa_errlist): Use braces for struct initializers.
2347
2348 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2349 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2350 All callers changed.
2351 (string_buffer_position): Likewise. Also, make static (it's never
2352 used outside xdisp.c).
2353 (cursor_row_p): Remove parameter `w', unused since
2354 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2355 (decode_mode_spec): Remove parameter `precision', introduced during
2356 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2357 All callers changed.
2358
2359 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2360
2361 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2362
2363 2011-03-27 Anders Lindgren <andlind@gmail.com>
2364
2365 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2366 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2367 (ns_update_auto_hide_menu_bar): New functions.
2368 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2369 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2370 ns_constrain_all_frames.
2371 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2372 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2373
2374 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2375
2376 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2377
2378 2011-03-27 Glenn Morris <rgm@gnu.org>
2379
2380 * syssignal.h: Replace RETSIGTYPE with void.
2381 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2382 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2383 Replace SIGTYPE with void everywhere.
2384 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2385 * s/template.h (SIGTYPE): Remove commented out definition.
2386
2387 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2388
2389 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2390 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2391
2392 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2393
2394 * w32.c (read_unc_volume): Use parameter `henum', instead of
2395 global variable `wget_enum_handle'.
2396
2397 * keymap.c (describe_vector): Remove parameters `indices' and
2398 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2399 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2400
2401 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2402
2403 * keyboard.c (timer_check): Remove parameter `do_it_now',
2404 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2405 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2406 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2407
2408 * keyboard.c (read_char):
2409 * w32menu.c (w32_menu_display_help):
2410 * xmenu.c (show_help_event, menu_help_callback):
2411 Adjust calls to `show_help_echo'.
2412
2413 * gtkutil.c (xg_maybe_add_timer):
2414 * keyboard.c (readable_events):
2415 * process.c (wait_reading_process_output):
2416 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2417
2418 * insdel.c (adjust_markers_gap_motion):
2419 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2420 (gap_left, gap_right): Don't call it.
2421
2422 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2423
2424 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2425 incurred during fontification.
2426
2427 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2428
2429 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2430 (DEFVAR_PER_BUFFER): Don't pass it.
2431
2432 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2433 (scrolling_window): Don't pass it.
2434
2435 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2436
2437 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2438
2439 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2440 and `suffix'.
2441 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2442 of variables specific to SELinux and computation of `encoded_absname'.
2443
2444 * image.c (XPutPixel): Remove unused variable `height'.
2445
2446 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2447
2448 * unexw32.c (get_section_info): Remove unused variable `section'.
2449
2450 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2451 (system_process_attributes): Remove unused variable `sess'.
2452 (sys_read): Remove unused variable `err'.
2453
2454 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2455 (w32_wnd_proc): Remove unused variable `isdead'.
2456 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2457 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2458 (x_create_tip_frame): Remove unused variable `tem'.
2459
2460 * w32inevt.c (w32_console_read_socket):
2461 Remove unused variable `no_events'.
2462
2463 * w32term.c (x_draw_composite_glyph_string_foreground):
2464 Remove unused variable `width'.
2465
2466 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2467
2468 * w32term.c (x_set_glyph_string_clipping):
2469 Don't pass uninitialized region to CombineRgn.
2470
2471 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2472
2473 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2474 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2475 (Fx_close_connection): Remove unused variable `i'.
2476
2477 * w32font.c (w32font_draw): Return number of glyphs.
2478 (w32font_open_internal): Remove unused variable `i'.
2479 (w32font_driver): Add missing initializer.
2480
2481 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2482 (fill_in_menu): Remove unused variable `items_added'.
2483
2484 * w32term.c (last_mouse_press_frame): Remove static global variable.
2485 (w32_clip_to_row): Remove unused variable `f'.
2486 (x_delete_terminal): Remove unused variable `i'.
2487
2488 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2489 (NOTHING): Remove unused static global variable.
2490 (uniscribe_check_otf): Remove unused variable `table'.
2491 (uniscribe_font_driver): Add missing initializers.
2492
2493 2011-03-23 Julien Danjou <julien@danjou.info>
2494
2495 * term.c (Fsuspend_tty, Fresume_tty):
2496 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2497 * window.c (temp_output_buffer_show):
2498 * insdel.c (signal_before_change):
2499 * frame.c (Fhandle_switch_frame):
2500 * fileio.c (Fdo_auto_save):
2501 * emacs.c (Fkill_emacs):
2502 * editfns.c (save_excursion_restore):
2503 * cmds.c (internal_self_insert):
2504 * callint.c (Fcall_interactively):
2505 * buffer.c (Fkill_all_local_variables):
2506 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2507 Use Frun_hooks.
2508 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2509 unconditionnaly since it does the check itself.
2510
2511 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2512
2513 Fix more problems found by GCC 4.5.2's static checks.
2514
2515 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2516 the first time through the loop, since we know p0 < p1 then.
2517 This also avoids a gcc -Wstrict-overflow warning.
2518
2519 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2520 leading to a memory leak, possible in functions like
2521 load_charset_map_from_file that can allocate an unbounded number
2522 of objects (Bug#8318).
2523
2524 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2525 that could (at least in theory) be that large.
2526
2527 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2528 This is less likely to overflow, and avoids undefined behavior if
2529 overflow does occur. All callers changed. Use strtoul to scan
2530 for the unsigned long integer.
2531 (pint2hrstr): Simplify and tune code slightly.
2532 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2533
2534 * scroll.c (do_scrolling): Work around GCC bug 48228.
2535 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2536
2537 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2538 This also avoids a warning with gcc -Wstrict-overflow.
2539 (validate_x_resource_name): Simplify count usage.
2540 This also avoids a warning with gcc -Wstrict-overflow.
2541
2542 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2543 fail (Bug#8306).
2544
2545 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2546
2547 * process.c (Fmake_network_process): Use socklen_t, not int,
2548 where POSIX says socklen_t is required in portable programs.
2549 This fixes a porting bug on hosts like 64-bit HP-UX, where
2550 socklen_t is wider than int (Bug#8277).
2551 (Fmake_network_process, server_accept_connection):
2552 (wait_reading_process_output, read_process_output):
2553 Likewise.
2554
2555 * process.c: Rename or move locals to avoid shadowing.
2556 (list_processes_1, Fmake_network_process):
2557 (read_process_output_error_handler, exec_sentinel_error_handler):
2558 Rename or move locals.
2559 (Fmake_network_process): Define label "retry_connect" only if needed.
2560 (Fnetwork_interface_info): Fix pointer signedness.
2561 (process_send_signal): Add cast to avoid pointer signedness problem.
2562 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2563 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2564
2565 Make tparam.h and terminfo.c consistent.
2566 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2567 Include tparam.h instead, since it declares them.
2568 * cm.h (PC): Remove extern decl; tparam.h now does this.
2569 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2570 * terminfo.c: Include tparam.h, to check interfaces.
2571 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2572 (tparam): Adjust signature to match interface in tparam.h;
2573 this removes some undefined behavior. Check that outstring and len
2574 are zero, which they always are with Emacs.
2575 * tparam.h (PC, BC, UP): New extern decls.
2576
2577 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2578 (xftfont_open): Rename locals to avoid shadowing.
2579
2580 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2581 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2582 (OTF_TAG_SYM): Omit macro if not needed.
2583 (ftfont_list): Remove unused local.
2584 (get_adstyle_property, ftfont_pattern_entity):
2585 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2586 Rename locals to avoid shadowing.
2587
2588 * xfont.c (xfont_list_family): Mark var as initialized.
2589
2590 * xml.c (make_dom): Now static.
2591
2592 * composite.c (composition_compute_stop_pos): Rename local to
2593 avoid shadowing.
2594 (composition_reseat_it): Remove unused locals.
2595 (find_automatic_composition, composition_adjust_point): Likewise.
2596 (composition_update_it): Mark var as initialized.
2597 (find_automatic_composition): Mark vars as initialized,
2598 with a FIXME (Bug#8290).
2599
2600 character.h: Rename locals to avoid shadowing.
2601 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2602 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2603 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2604 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2605 to avoid shadowing.
2606
2607 * textprop.c (property_change_between_p): Remove; unused.
2608
2609 * intervals.c (interval_start_pos): Now static.
2610
2611 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2612
2613 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2614 Rename locals to avoid shadowing.
2615
2616 * sound.c (wav_play, au_play, Fplay_sound_internal):
2617 Fix pointer signedness.
2618 (alsa_choose_format): Remove unused local var.
2619 (wav_play): Initialize a variable to 0, to prevent undefined
2620 behavior (Bug#8278).
2621
2622 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2623
2624 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2625
2626 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2627 clobbering (Bug#8298).
2628 * sysdep.c (sys_subshell): Likewise.
2629 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2630
2631 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2632 This should get cleaned up, so that child_setup has the
2633 same signature on all platforms.
2634
2635 * callproc.c (call_process_cleanup): Now static.
2636 (relocate_fd): Rename locals to avoid shadowing.
2637
2638 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2639
2640 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2641 not to be necessary, and produces flickering.
2642
2643 2011-03-20 Glenn Morris <rgm@gnu.org>
2644
2645 * config.in: Remove file.
2646
2647 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2648
2649 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2650 are now in src/globals.h.
2651 (syms_of_minibuf): Remove spurious & from previous change.
2652
2653 2011-03-20 Leo <sdl.web@gmail.com>
2654
2655 * minibuf.c (completing-read-function): New variable.
2656 (completing-read-default): Rename from completing-read.
2657 (completing-read): Call completing-read-function.
2658
2659 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2660
2661 * xfaces.c (Fx_load_color_file):
2662 Read color file from absolute filename (bug#8250).
2663
2664 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2665
2666 * makefile.w32-in: Update dependencies.
2667
2668 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2669
2670 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2671
2672 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2673
2674 Fix more problems found by GCC 4.5.2's static checks.
2675
2676 * process.c (make_serial_process_unwind, send_process_trap):
2677 (sigchld_handler): Now static.
2678
2679 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2680 That way, the code declares only the vars that it needs.
2681 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2682 * s/cygwin.h (PTY_ITERATION): Likewise.
2683 * s/darwin.h (PTY_ITERATION): Likewise.
2684 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2685
2686 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2687 * process.c (allocate_pty): Don't declare stb unless it's needed.
2688
2689 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2690 (CONSTANTLIM): Remove; unused.
2691 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2692 Define only if needed.
2693
2694 * unexelf.c (unexec): Name an expression,
2695 to avoid gcc -Wbad-function-cast warning.
2696 Use a different way to cause a compilation error if anyone uses
2697 n rather than nn, a way that does not involve shadowing.
2698 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2699
2700 * deps.mk (unexalpha.o): Remove; unused.
2701
2702 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2703 * unexec.h: New file.
2704 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2705 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2706 Depend on unexec.h.
2707 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2708 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2709 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2710 Change as necessary to match prototype in unexec.h.
2711
2712 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2713 shadowing.
2714 (back_comment, skip_chars): Mark vars as initialized.
2715
2716 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2717 Rename locals to avoid shadowing.
2718
2719 * lread.c (read1): Rewrite so as not to use empty "else".
2720 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2721
2722 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2723
2724 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2725 warning when compiling print.c.
2726
2727 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2728 instead of using an uninitialized var.
2729 (font_sort_entities): Mark var as initialized.
2730
2731 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2732
2733 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2734 pointers to constants.
2735 (font_parse_fcname): Remove unused vars.
2736 (font_delete_unmatched): Now static.
2737 (font_get_spec): Remove; unused.
2738 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2739 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2740 Rename or move locals to avoid shadowing.
2741
2742 * fns.c (require_nesting_list, require_unwind): Now static.
2743 (Ffillarray): Rename locals to avoid shadowing.
2744
2745 * floatfns.c (domain_error2): Define only if needed.
2746 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2747
2748 * alloc.c (mark_backtrace): Move decl from here ...
2749 * lisp.h: ... to here, so that it can be checked.
2750
2751 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2752 (Fdefvar): Rewrite so as not to use empty "else".
2753 (lisp_indirect_variable): Name an expression,
2754 to avoid gcc -Wbad-function-cast warning.
2755 (Fdefvar): Rename locals to avoid shadowing.
2756
2757 * callint.c (quotify_arg, quotify_args): Now static.
2758 (Fcall_interactively): Rename locals to avoid shadowing.
2759 Use const pointer when appropriate.
2760
2761 * lisp.h (get_system_name, get_operating_system_release):
2762 Move decls here, to check interfaces.
2763 * process.c (get_operating_system_release): Move decl to lisp.h.
2764 * xrdb.c (get_system_name): Likewise.
2765 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2766 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2767 some of which prompt warnings from gcc -Wbad-function-cast.
2768 (Fformat_time_string, Fencode_time, Finsert_char):
2769 (Ftranslate_region_internal, Fformat):
2770 Rename or remove local vars to avoid shadowing.
2771 (Ftranslate_region_internal): Mark var as initialized.
2772
2773 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2774 avoid shadowing.
2775
2776 * lisp.h (eassert): Check that the argument compiles, even if
2777 ENABLE_CHECKING is not defined.
2778
2779 * data.c (Findirect_variable): Name an expression, to avoid
2780 gcc -Wbad-function-cast warning.
2781 (default_value, arithcompare, arith_driver, arith_error): Now static.
2782 (store_symval_forwarding): Rename local to avoid shadowing.
2783 (Fmake_variable_buffer_local, Fmake_local_variable):
2784 Mark variables as initialized.
2785 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2786
2787 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2788 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2789 Rename locals to avoid shadowing.
2790 (mark_stack): Move local variables into the #ifdef region where
2791 they're used.
2792 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2793 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2794 needed otherwise.
2795 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2796 (GC_STRING_CHARS): Remove; not used.
2797 (Fmemory_limit): Cast sbrk's returned value to char *.
2798
2799 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2800 avoids undefined behavior in theory.
2801
2802 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2803
2804 Use functions, not macros, for up- and down-casing (Bug#8254).
2805 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2806 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2807 to use the following functions instead of these macros.
2808 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2809 EMACS_INT, since callers assume the returned value fits in int.
2810 (upcase1): Likewise, for UPCASE_TABLE.
2811 (uppercasep, lowercasep, upcase): New static inline functions.
2812 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2813 the race-condition problem in the old DOWNCASE.
2814
2815 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2816 Rename locals to avoid shadowing.
2817 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2818 (regex_compile, re_search_2, re_match_2_internal):
2819 Remove unused local vars.
2820 (FREE_VAR): Rewrite so as not to use empty "else",
2821 which gcc can warn about.
2822 (regex_compile, re_match_2_internal): Mark locals as initialized.
2823 (RETALLOC_IF): Define only if needed.
2824 (WORDCHAR_P): Likewise. This one is never needed, but is used
2825 only in a comment talking about a compiler bug, so put inside
2826 the #if 0 of that comment.
2827 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2828 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2829 Remove; unused.
2830
2831 * search.c (boyer_moore): Rename locals to avoid shadowing.
2832 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2833 (PREV_CHAR_BOUNDARY): Likewise.
2834
2835 * search.c (simple_search): Remove unused var.
2836
2837 * dired.c (compile_pattern): Move decl from here ...
2838 * lisp.h: ... to here, so that it can be checked.
2839 (struct re_registers): New forward decl.
2840
2841 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2842
2843 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2844 All uses changed.
2845 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2846 Rename locals to avoid shadowing.
2847 (Fvertical_motion): Mark locals as initialized.
2848
2849 * casefiddle.c (casify_object, casify_region): Now static.
2850 (casify_region): Mark local as initialized.
2851
2852 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2853
2854 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2855 New macros, so that the caller can use some names other than
2856 gcpro1, gcpro2, etc.
2857 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2858 of the new macros.
2859 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2860 argument, for consistency with GCPRO2_VAR, etc: it is now the
2861 prefix of the variable, not the variable itself. All uses
2862 changed.
2863 * dired.c (directory_files_internal, file_name_completion):
2864 Rename locals to avoid shadowing.
2865
2866 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2867 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2868 dired.c's scmp function, had undefined behavior.
2869 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2870 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2871 * buffer.h: ... to here, because these macros use current_buffer,
2872 and the new implementation with inline functions needs to have
2873 current_buffer in scope now, rather than later when the macros
2874 are used.
2875 (downcase, upcase1): New static inline functions.
2876 (DOWNCASE, UPCASE1): Reimplement using these functions.
2877 This avoids undefined behavior in expressions like
2878 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2879 from race conditions in accessing the global variables
2880 case_temp1 and case_temp2.
2881 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2882 * lisp.h (case_temp1, case_temp2): Remove their decls.
2883 * character.h (ASCII_CHAR_P): Move from here ...
2884 * lisp.h: ... to here, so that the inline functions mentioned
2885 above can use them.
2886
2887 * dired.c (directory_files_internal_unwind): Now static.
2888
2889 * fileio.c (file_name_as_directory, directory_file_name):
2890 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2891 Now static.
2892 (file_name_as_directory): Use const pointers when appropriate.
2893 (Fexpand_file_name): Likewise. In particular, newdir might
2894 point at constant storage, so make it a const pointer.
2895 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2896 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2897 signedness issues.
2898 (Fset_file_times, Finsert_file_contents, auto_save_error):
2899 Rename locals to avoid shadowing.
2900
2901 * minibuf.c (choose_minibuf_frame_1): Now static.
2902 (Ftry_completion, Fall_completions): Rename or remove locals
2903 to avoid shadowing.
2904
2905 * marker.c (bytepos_to_charpos): Remove; unused.
2906
2907 * lisp.h (verify_bytepos, count_markers): New decls,
2908 so that gcc does not warn that these functions aren't declared.
2909
2910 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2911 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2912 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2913 (copy_text): Remove unused local var.
2914
2915 * filelock.c (within_one_second): Now static.
2916 (lock_file_1): Rename local to avoid shadowing.
2917
2918 * buffer.c (fix_overlays_before): Mark locals as initialized.
2919 (fix_start_end_in_overlays): Likewise. This function should be
2920 simplified by using pointers-to-pointers, but that's a different
2921 matter.
2922 (switch_to_buffer_1): Now static.
2923 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2924 (report_overlay_modification): Rename locals to avoid shadowing.
2925
2926 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2927 Fix pointer signedness issue.
2928 (sys_subshell): Mark local as volatile if checking for lint,
2929 to suppress a gcc -Wclobbered warning that does not seem to be right.
2930 (MAXPATHLEN): Define only if needed.
2931
2932 * process.c (serial_open, serial_configure): Move decls from here ...
2933 * systty.h: ... to here, so that they can be checked.
2934
2935 * fns.c (get_random, seed_random): Move extern decls from here ...
2936 * lisp.h: ... to here, so that they can be checked.
2937
2938 * sysdep.c (reset_io): Now static.
2939 (wait_for_termination_signal): Remove; unused.
2940
2941 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2942 (copy_keymap_item, append_key, push_text_char_description):
2943 Now static.
2944 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2945 (DENSE_TABLE_SIZE): Remove; unused.
2946 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2947 (describe_map_tree):
2948 Rename locals to avoid shadowing.
2949
2950 * keyboard.c: Declare functions static if they are not used elsewhere.
2951 (echo_char, echo_dash, cmd_error, top_level_2):
2952 (poll_for_input, handle_async_input): Now static.
2953 (read_char, kbd_buffer_get_event, make_lispy_position):
2954 (make_lispy_event, make_lispy_movement, apply_modifiers):
2955 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2956 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2957 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2958 (read_key_sequence, read_char): Mark locals as initialized.
2959 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2960
2961 * keyboard.h (make_ctrl_char): New decl.
2962 (mark_kboards): Move decl here ...
2963 * alloc.c (mark_kboards): ... from here.
2964
2965 * lisp.h (force_auto_save_soon): New decl.
2966
2967 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2968 (DEFINE_DUMMY_FUNCTION): New macro.
2969 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2970 Use it.
2971 (main): Add casts to avoid warnings
2972 if GCC considers string literals to be constants.
2973
2974 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2975
2976 * dbusbind.c: Pointer signedness fixes.
2977 (xd_signature, xd_append_arg, xd_initialize):
2978 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2979 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2980 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2981 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2982
2983 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2984 if GCC considers string literals to be constants.
2985 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2986
2987 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2988
2989 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2990 (print_preprocess, print_object): New macro to fix last change.
2991
2992 * print.c (print_preprocess): Don't forget font objects.
2993
2994 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2995
2996 * emacs.c (USAGE3): Doc fixes.
2997
2998 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2999
3000 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3001 structure.
3002
3003 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3004
3005 * lisp.h (VWindow_system, Qfile_name_history):
3006 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3007 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3008 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3009
3010 * w32select.c: Don't #include "keyboard.h".
3011 (run_protected): Add extern declaration for waiting_for_input.
3012
3013 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3014 * w32console.c (detect_input_pending, read_input_pending)
3015 (encode_terminal_code):
3016 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3017 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3018 (w32_system_caret_y, Qfile_name_history):
3019 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3020 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3021 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3022 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3023 * w32proc.c (Qlocal, report_file_error):
3024 * w32term.c (Vwindow_system, updating_frame):
3025 * w32uniscribe.c (initialized, uniscribe_font_driver):
3026 Remove unneeded extern declarations.
3027
3028 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3029
3030 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3031
3032 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3033
3034 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3035 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3036 These macros can no longer be used for assignment.
3037
3038 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3039 Assign struct members directly, instead of using BUF_BEGV etc.
3040 (record_buffer_markers, fetch_buffer_markers): New functions for
3041 recording and fetching special buffer markers.
3042 (set_buffer_internal_1, set_buffer_temp): Use them.
3043
3044 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3045
3046 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3047
3048 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3049 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3050
3051 * xdisp.c (hscroll_window_tree):
3052 (reconsider_clip_changes): Use PT instead of BUF_PT.
3053
3054 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3055
3056 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3057 $(EMACS_ROOT)/lib/intprops.h.
3058
3059 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3060
3061 Fix more problems found by GCC 4.5.2's static checks.
3062
3063 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3064 to unsigned char * to avoid compiler diagnostic.
3065 (xg_free_frame_widgets): Make it clear that a local variable is
3066 needed only if USE_GTK_TOOLTIP.
3067 (gdk_window_get_screen): Make it clear that this macro is needed
3068 only if USE_GTK_TOOLTIP.
3069 (int_gtk_range_get_value): New function, which avoids a diagnostic
3070 from gcc -Wbad-function-cast.
3071 (xg_set_toolkit_scroll_bar_thumb): Use it.
3072 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3073 diagnostic from gcc -Wbad-function-cast.
3074 (get_utf8_string, xg_get_file_with_chooser):
3075 Rename locals to avoid shadowing.
3076 (create_dialog): Move locals to avoid shadowing.
3077
3078 * xgselect.c (xg_select): Remove unused var.
3079
3080 * image.c (four_corners_best): Mark locals as initialized.
3081 (gif_load): Initialize transparent_p to zero (Bug#8238).
3082 Mark another local as initialized.
3083 (my_png_error, my_error_exit): Mark with NO_RETURN.
3084
3085 * image.c (clear_image_cache): Now static.
3086 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3087 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3088 (x_edge_detection): Remove unnecessary cast that
3089 gcc -Wbad-function-cast diagnoses.
3090 (gif_load): Fix pointer signedness.
3091 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3092 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3093
3094 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3095
3096 Improve quality of tests for time stamp overflow.
3097 For example, without this patch (encode-time 0 0 0 1 1
3098 1152921504606846976) returns the obviously-bogus value (-948597
3099 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3100 reports time overflow. See
3101 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3102 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3103 * editfns.c: Include limits.h and intprops.h.
3104 (TIME_T_MIN, TIME_T_MAX): New macros.
3105 (time_overflow): Move earlier, to before first use.
3106 (hi_time, lo_time): New functions, for an accurate test for
3107 out-of-range times.
3108 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3109 (Fget_internal_run_time): Don't assume time_t fits in int.
3110 (make_time): Use list2 instead of Fcons twice.
3111 (Fdecode_time): More accurate test for out-of-range times.
3112 (check_tm_member): New function.
3113 (Fencode_time): Use it, to test for out-of-range times.
3114 (lisp_time_argument): Don't rely on undefined left-shift and
3115 right-shift behavior when checking for time stamp overflow.
3116
3117 * editfns.c (time_overflow): New function, refactoring common code.
3118 (Fformat_time_string, Fdecode_time, Fencode_time):
3119 (Fcurrent_time_string): Use it.
3120
3121 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3122 * dired.c (make_time): Move to ...
3123 * editfns.c (make_time): ... here.
3124 * systime.h: Note the move.
3125
3126 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3127
3128 * fringe.c (update_window_fringes): Remove unused variables.
3129
3130 * unexmacosx.c (copy_data_segment): Also copy __got section.
3131 (Bug#8223)
3132
3133 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3134
3135 * termcap.c [MSDOS]: Include "msdos.h".
3136 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3137 Constify `char *' arguments and their references according to
3138 prototypes in tparam.h.
3139
3140 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3141
3142 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3143 Adapt all references accordingly.
3144
3145 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3146
3147 2011-03-11 Tom Tromey <tromey@redhat.com>
3148
3149 * buffer.c (syms_of_buffer): Remove obsolete comment.
3150
3151 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3152
3153 * termhooks.h (encode_terminal_code): Declare prototype.
3154
3155 * msdos.c (encode_terminal_code): Don't declare prototype.
3156
3157 * term.c (encode_terminal_code): Now external again, used by
3158 w32console.c and msdos.c.
3159
3160 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3161 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3162
3163 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3164
3165 Fix some minor problems found by GCC 4.5.2's static checks.
3166
3167 * fringe.c (update_window_fringes): Mark locals as initialized
3168 (Bug#8227).
3169 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3170
3171 * alloc.c (mark_fringe_data): Move decl from here ...
3172 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3173 to check its interface.
3174 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3175
3176 * fontset.c (free_realized_fontset): Now static.
3177 (Fset_fontset_font): Rename local to avoid shadowing.
3178 (fontset_font): Mark local as initialized.
3179 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3180
3181 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3182
3183 * xselect.c (x_disown_buffer_selections): Remove; not used.
3184 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3185 (x_own_selection, Fx_disown_selection_internal): Rename locals
3186 to avoid shadowing.
3187 (x_handle_dnd_message): Remove local to avoid shadowing.
3188
3189 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3190 so that the caller can use some name other than gcpro1.
3191 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3192 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3193 (Fx_backspace_delete_keys_p):
3194 Use them to avoid shadowing, and rename vars to avoid shadowing.
3195 (x_decode_color, x_set_name, x_window): Now static.
3196 (Fx_create_frame): Add braces to silence GCC warning.
3197 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3198 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3199 Remove unused locals.
3200 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3201 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3202 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3203 macros.
3204
3205 * xterm.h (x_mouse_leave): New decl.
3206
3207 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3208 Remove unused functions.
3209 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3210 (x_calc_absolute_position): Now static.
3211 (XTread_socket): Don't define label "out" unless it's used.
3212 Don't declare local "event" unless it's used.
3213 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3214 unless they are used.
3215 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3216 (x_fatal_error_signal): Remove; not used.
3217 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3218 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3219 (x_error_catcher, x_connection_closed, x_error_handler):
3220 (x_error_quitter, xembed_send_message, x_iconify_frame):
3221 (my_log_handler): Rename locals to avoid shadowing.
3222 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3223 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3224
3225 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3226 Rename or move locals to avoid shadowing.
3227 (tty_defined_color, merge_face_heights): Now static.
3228 (free_realized_faces_for_fontset): Remove; not used.
3229 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3230 does not deduce is never used uninitialized.
3231 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3232 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3233
3234 * terminal.c (store_terminal_param): Now static.
3235
3236 * xmenu.c (menu_highlight_callback): Now static.
3237 (set_frame_menubar): Remove unused local.
3238 (xmenu_show): Rename parameter to avoid shadowing.
3239 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3240 since they might point to immutable storage.
3241 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3242 since it's unused otherwise.
3243
3244 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3245 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3246 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3247 avoids a gcc -Wuninitialized diagnostic.
3248 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3249 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3250 does not deduce are never used uninitialized.
3251
3252 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3253
3254 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3255 * window.c (window_loop, size_window):
3256 (run_window_configuration_change_hook, enlarge_window): Likewise.
3257
3258 * window.c (display_buffer): Now static.
3259 (size_window): Mark variables that gcc -Wuninitialized
3260 does not deduce are never used uninitialized.
3261 * window.h (check_all_windows): New decl, to forestall
3262 gcc -Wmissing-prototypes diagnostic.
3263 * dispextern.h (bidi_dump_cached_states): Likewise.
3264
3265 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3266 shadowing.
3267 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3268 Include <limits.h>.
3269 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3270 and to avoid gcc -Wuninitialized warning.
3271 (load_charset_map): Mark variables that gcc -Wuninitialized
3272 does not deduce are never used uninitialized.
3273 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3274
3275 * coding.c (coding_set_source, coding_set_destination):
3276 Use "else { /* comment */ }" rather than "else /* comment */;"
3277 for clarity, and to avoid gcc -Wempty-body warning.
3278 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3279 a block, when the outer 'i' will do.
3280 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3281 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3282 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3283 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3284 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3285 Rename locals to avoid shadowing.
3286 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3287 * coding.c (emacs_mule_char, encode_invocation_designation):
3288 Now static, since they're not used elsewhere.
3289 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3290 (decode_coding_object, encode_coding_object, detect_coding_system):
3291 (decode_coding_emacs_mule): Mark variables that gcc
3292 -Wuninitialized does not deduce are never used uninitialized.
3293 (detect_coding_iso_2022): Initialize a local variable that might
3294 be used uninitialized. Leave a FIXME because it's not clear that
3295 this initialization is needed. (Bug#8211)
3296 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3297 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3298 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3299 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3300 Remove unused macros.
3301
3302 * category.c (hash_get_category_set): Remove unused local var.
3303 (copy_category_table): Now static, since it's not used elsewhere.
3304 * character.c (string_count_byte8): Likewise.
3305
3306 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3307 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3308
3309 * chartab.c (copy_sub_char_table): Now static, since it's not used
3310 elsewhere.
3311 (sub_char_table_ref_and_range, char_table_ref_and_range):
3312 Rename locals to avoid shadowing.
3313 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3314
3315 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3316 (BIDI_BOB): Remove unused macro.
3317
3318 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3319 deduce are never used uninitialized.
3320 * term.c (encode_terminal_code): Likewise.
3321
3322 * term.c (encode_terminal_code): Now static. Remove unused local.
3323
3324 * tparam.h: New file.
3325 * term.c, tparam.h: Include it.
3326 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3327 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3328 Move these decls to tparam.h, and make them agree with what
3329 is actually in tparam.c. The previous trick of using incompatible
3330 decls in different modules does not conform to the C standard.
3331 All callers of tparam changed to use tparam's actual API.
3332 * tparam.c (tparam1, tparam, tgoto):
3333 Use const pointers where appropriate.
3334
3335 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3336 * cm.h (struct cm): Likewise.
3337 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3338 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3339 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3340 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3341 (turn_on_face, init_tty): Likewise.
3342 * termchar.h (struct tty_display_info): Likewise.
3343
3344 * term.c (term_mouse_position): Rename local to avoid shadowing.
3345
3346 * alloc.c (mark_ttys): Move decl from here ...
3347 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3348
3349 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3350
3351 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3352
3353 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3354
3355 * search.c (compile_pattern_1): Remove argument regp, unused since
3356 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3357 (compile_pattern): Don't pass it.
3358
3359 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3360
3361 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3362 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3363 for ! HAVE_GTK3.
3364 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3365
3366 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3367
3368 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3369 gdk_window_get_screen, gdk_window_get_geometry,
3370 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3371 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3372 (xg_get_pixbuf_from_pixmap): New function.
3373 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3374 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3375 Call xg_get_pixbuf_from_pixmap instead of
3376 gdk_pixbuf_get_from_drawable.
3377 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3378 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3379 (xg_check_special_colors): Use GtkStyleContext and its functions
3380 for HAVE_GTK3.
3381 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3382 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3383 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3384 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3385 Call gtk_widget_get_preferred_size.
3386 (xg_frame_resized): gdk_window_get_geometry only takes 5
3387 parameters.
3388 (xg_win_to_widget, xg_event_is_for_menubar):
3389 Call gdk_x11_window_lookup_for_display.
3390 (xg_set_widget_bg): New function.
3391 (delete_cb): New function.
3392 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3393 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3394 (xg_set_background_color): Call xg_set_widget_bg.
3395 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3396 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3397 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3398 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3399 if ! HAVE_GTK3.
3400 (update_frame_tool_bar): Call gtk_widget_hide.
3401 (xg_initialize): Use GDK_KEY_g.
3402
3403 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3404 if ! HAVE_GTK3
3405 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3406
3407 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3408 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3409 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3410
3411 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3412
3413 * w32xfns.c (select_palette): Check success of RealizePalette against
3414 GDI_ERROR, not zero.
3415
3416 See ChangeLog.11 for earlier changes.
3417
3418 ;; Local Variables:
3419 ;; coding: utf-8
3420 ;; End:
3421
3422 Copyright (C) 2011 Free Software Foundation, Inc.
3423
3424 This file is part of GNU Emacs.
3425
3426 GNU Emacs is free software: you can redistribute it and/or modify
3427 it under the terms of the GNU General Public License as published by
3428 the Free Software Foundation, either version 3 of the License, or
3429 (at your option) any later version.
3430
3431 GNU Emacs is distributed in the hope that it will be useful,
3432 but WITHOUT ANY WARRANTY; without even the implied warranty of
3433 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3434 GNU General Public License for more details.
3435
3436 You should have received a copy of the GNU General Public License
3437 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.