1 2012-05-11 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4 and right-margin display specs even if the spec is invalid or we
5 are on a TTY, and thus unable to display on the fringes. That's
6 because the text with the property will not be displayed anyway,
7 so we need to signal to the caller that this is a "replacing"
8 display spec. This fixes display when the spec is invalid or we
11 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
13 * unexaix.c (make_hdr): Fix typo in prototype.
14 This bug broke the build on AIX. Problem reported by Gilles Pion.
16 2012-05-05 Eli Zaretskii <eliz@gnu.org>
18 * w32proc.c (new_child): Force Windows to reserve only 64KB of
19 stack for each reader_thread, instead of defaulting to 8MB
20 determined by the linker. This avoids failures in creating
21 subprocesses on Windows 7, see the discussion in this thread:
22 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
24 2012-05-02 Jim Meyering <meyering@redhat.com>
26 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
28 2012-04-29 Eli Zaretskii <eliz@gnu.org>
30 * xdisp.c (pos_visible_p): If already at a newline from the
31 display string before the 'while' loop, don't walk back the glyphs
32 from it3.glyph_row. Solves assertion violation when the display
33 string begins with a newline (egg.el). (Bug#11367)
35 2012-04-24 Chong Yidong <cyd@gnu.org>
37 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
39 2012-04-23 Eli Zaretskii <eliz@gnu.org>
41 * xdisp.c (pos_visible_p): If the window start position is beyond
42 ZV, start the display from buffer beginning. Prevents assertion
43 violation in init_iterator when the minibuffer window is scrolled
46 * window.c (window_scroll_pixel_based): Likewise.
48 2012-04-23 Chong Yidong <cyd@gnu.org>
50 * keymap.c (where_is_internal): Doc fix (Bug#10872).
52 2012-04-20 Glenn Morris <rgm@gnu.org>
54 * fileio.c (Fcopy_file, Fset_file_selinux_context):
55 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
57 2012-04-20 Eli Zaretskii <eliz@gnu.org>
59 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
60 overrun array limits of glyph row's used[] array. (Bug#11288)
62 2012-04-20 Chong Yidong <cyd@gnu.org>
64 * process.c (wait_reading_process_output): If EIO occurs on a pty,
65 set the status to "failed" and ensure that sentinel is run.
67 2012-04-18 Glenn Morris <rgm@gnu.org>
69 * process.c (Fset_process_inherit_coding_system_flag)
70 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
71 (Fmake_network_process, Fmake_serial_process): Doc fix.
73 2012-04-17 Eli Zaretskii <eliz@gnu.org>
75 * xdisp.c (string_buffer_position_lim): Limit starting position to
77 (set_cursor_from_row): If called for a mode-line or header-line
78 row, return zero immediately.
79 (try_cursor_movement): If inside continuation line, don't back up
80 farther than the first row after the header line, if any. Don't
81 consider the header-line row as "partially visible", even if
82 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
84 2012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
86 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
88 2012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
90 * process.c (make_process):
91 * process.h: Add integer `gnutls_handshakes_tried' member to
94 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
95 Add convenience `GNUTLS_LOG2i' macro.
97 * gnutls.c (gnutls_log_function2i): Convenience log function.
98 (emacs_gnutls_read): Use new log functions,
99 `gnutls_handshakes_tried' process member, and
100 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
101 attempts per process (connection).
103 2012-04-09 Eli Zaretskii <eliz@gnu.org>
105 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
106 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
108 2012-04-09 Jan Djärv <jan.h.d@swipnet.se>
110 * nsterm.m (constrainFrameRect): Always constrain when there is only
111 one screen (Bug#10962).
113 2012-04-06 Eli Zaretskii <eliz@gnu.org>
115 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
116 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
117 about subtle differences between FETCH_CHAR* and STRING_CHAR*
118 macros related to unification of CJK characters. For the details,
119 see the discussion following the message here:
120 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
122 2012-04-04 Chong Yidong <cyd@gnu.org>
124 * keyboard.c (Vdelayed_warnings_list): Doc fix.
126 2012-04-01 Eli Zaretskii <eliz@gnu.org>
128 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
129 instead of alloca. (Bug#11138)
131 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
133 * w32menu.c (is_simple_dialog): Properly check lisp types.
136 2012-03-31 Eli Zaretskii <eliz@gnu.org>
138 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
139 position we get to after a call to move_it_to fails the
140 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
141 only if we wind up in a string from display property. (Bug#11063)
143 * window.c (Fdelete_other_windows_internal): Invalidate the row
144 and column information about mouse highlight, so that redisplay
145 restores it after reallocating the glyph matrices. (Bug#7464)
147 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
148 string comes from a `display' text property, use the buffer
149 position of that property as if we actually saw that position in
151 (move_it_by_lines): Remove the assertion that
152 "it->current_x == 0 && it->hpos == 0" which can be legitimately
153 violated when there's a before-string at the beginning of a line.
156 2012-03-30 Eli Zaretskii <eliz@gnu.org>
158 * xdisp.c (append_space_for_newline): If the default face was
159 remapped, use the remapped face for the appended newline.
160 (extend_face_to_end_of_line): Use the remapped default face for
161 extending the face to the end of the line.
162 (display_line): Call extend_face_to_end_of_line when the default
163 face was remapped. (Bug#11068)
165 2012-03-29 Eli Zaretskii <eliz@gnu.org>
167 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
169 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
171 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
173 2012-03-27 Glenn Morris <rgm@gnu.org>
175 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
178 2012-03-26 Kenichi Handa <handa@m17n.org>
180 * dispextern.h (struct glyph): Fix previous change. Change the
181 bit length of glyphless.ch to 25 (Bug#11082).
183 2012-03-26 Chong Yidong <cyd@gnu.org>
185 * keyboard.c (Vselection_inhibit_update_commands): New variable.
186 (command_loop_1): Use it; inhibit selection update for
187 handle-select-window too (Bug#8996).
189 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
191 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
193 2012-03-25 Kenichi Handa <handa@m17n.org>
195 * dispextern.h (struct glyph): Change the bit length of
196 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
198 2012-03-24 Eli Zaretskii <eliz@gnu.org>
200 * s/ms-w32.h (tzname): Include time.h before redirecting to
201 _tzname. Fixes the MSVC build. (Bug#9960)
203 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
205 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
208 * xterm.c (XTread_socket): Only modify handling_signal if
209 !SYNC_INPUT. (Bug#11080)
211 2012-03-23 Eli Zaretskii <eliz@gnu.org>
213 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
214 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
215 when fetching a multibyte character consumes more bytes than
216 CHAR_BYTES returns, due to unification of CJK characters in
217 string_char. (Bug#11073)
219 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
221 * process.c (wait_reading_process_output): Handle pty disconnect
222 by refraining from sending oneself a SIGCHLD (bug#10933).
224 2012-03-22 Chong Yidong <cyd@gnu.org>
226 * dispextern.h (struct it): New member string_from_prefix_prop_p.
228 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
229 Mark string as coming from a prefix property.
230 (handle_face_prop): Use default face for prefix strings (Bug#4281).
231 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
233 2012-03-21 Chong Yidong <cyd@gnu.org>
235 * xfaces.c (Vface_remapping_alist): Doc fix.
237 2012-03-20 Eli Zaretskii <eliz@gnu.org>
239 * w32proc.c (Fw32_set_console_codepage)
240 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
243 2012-03-20 Chong Yidong <cyd@gnu.org>
245 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
246 to reflect default non-nil value of redisplay-dont-pause.
248 2012-03-19 Kenichi Handa <handa@m17n.org>
250 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
251 it fit in a valid range (Bug#11003).
253 2012-03-18 Eli Zaretskii <eliz@gnu.org>
255 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
256 that is not from display property, accept the row as a "cursor
257 row" if one of the string's character has a non-nil `cursor'
258 property. Fixes cursor positioning when there are newlines in
259 overlay strings, e.g. in icomplete.el. (Bug#11035)
261 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
263 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
265 2012-03-12 Chong Yidong <cyd@gnu.org>
267 * eval.c (inhibit_lisp_code): Rename from
268 inhibit_window_configuration_change_hook; move from window.c.
270 * xfns.c (unwind_create_frame_1, Fx_create_frame):
271 * window.c (run_window_configuration_change_hook)
272 (syms_of_window): Callers changed.
274 2012-03-11 Chong Yidong <cyd@gnu.org>
276 * keymap.c (Fkey_description): Doc fix (Bug#9700).
278 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
280 2012-03-10 Chong Yidong <cyd@gnu.org>
282 * frame.c (other_visible_frames): Don't assume the selected frame
283 is visible (Bug#10955).
285 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
287 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
289 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
291 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
292 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
295 2012-03-03 Glenn Morris <rgm@gnu.org>
297 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
299 2012-03-02 Eli Zaretskii <eliz@gnu.org>
301 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
302 position past the first glyph_row that ends at ZV. (Bug#10902)
303 (redisplay_window, next_element_from_string): Fix typos in
305 (redisplay_window): Pass to move_it_vertically the margin in
306 pixels, not in screen lines.
308 2012-03-02 Glenn Morris <rgm@gnu.org>
310 * buffer.c (buffer-list-update-hook): Doc fix.
312 2012-02-29 Eli Zaretskii <eliz@gnu.org>
314 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
315 push_it before setting up the iterator for the first overlay
316 string, even if we have an empty string loaded.
317 (next_overlay_string): If there's an empty string on the iterator
318 stack, pop the stack. (Bug#10903)
320 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
322 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
323 Suggested by Stefan Monnier in
324 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
325 * alloc.c (widen_to_Lisp_Object): New static function.
326 (mark_memory): Also mark Lisp_Objects by fetching pointer words
327 and widening them to Lisp_Objects. This would work even if
328 USE_LSB_TAG is defined and wide integers are used, which might
329 happen in a future version of Emacs.
331 2012-02-25 Chong Yidong <cyd@gnu.org>
333 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
336 * xselect.c (Fx_selection_exists_p): Doc fix.
337 (x_clipboard_manager_save_all): Print an informative message
338 before saving to clipboard manager.
340 2012-02-24 Chong Yidong <cyd@gnu.org>
342 * keyboard.c (process_special_events): Handle all X selection
343 requests in kbd_buffer, not just the next one (Bug#8869).
345 2012-02-23 Chong Yidong <cyd@gnu.org>
347 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
348 call when setting menu-bar-lines and tool-bar-lines parameters.
349 (unwind_create_frame_1): New helper function.
351 * window.c (inhibit_window_configuration_change_hook): New var.
352 (run_window_configuration_change_hook): Obey it.
353 (syms_of_window): Initialize it.
355 2012-02-22 Chong Yidong <cyd@gnu.org>
357 * xterm.c (x_draw_image_relief): Add missing type check for
358 Vtool_bar_button_margin (Bug#10743).
360 2012-02-21 Chong Yidong <cyd@gnu.org>
362 * fileio.c (Vfile_name_handler_alist): Doc fix.
364 * buffer.c (Fget_file_buffer): Protect against invalid file
365 handler return value.
367 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
369 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
370 when computing $valmask.
372 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
373 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
374 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
375 It's useless in that case, and it can cause problems on hosts
376 that allocate halves of EMACS_INT values separately.
377 Reported by Dan Horák. Diagnosed by Andreas Schwab in
378 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
379 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
380 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
381 it avoids undefined behavior on hosts where shifting right by more
382 than the word width has undefined behavior.
384 2012-02-19 Chong Yidong <cyd@gnu.org>
386 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
387 (Funhandled_file_name_directory, Ffile_name_as_directory)
388 (Fdirectory_file_name, Fexpand_file_name)
389 (Fsubstitute_in_file_name): Protect against invalid file handler
390 return values (Bug#10845).
392 2012-02-18 Eli Zaretskii <eliz@gnu.org>
394 * .gdbinit (pitx): Fix incorrect references to fields of the
397 2012-02-17 Chong Yidong <cyd@gnu.org>
399 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
401 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
403 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
404 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
406 2012-02-15 Chong Yidong <cyd@gnu.org>
408 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
409 marked as special. Also, starting docstrings with * is obsolete.
411 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
413 * gnutls.c (emacs_gnutls_write): Fix last change.
415 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
417 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
420 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
422 * keymap.c (Fsingle_key_description): Handle char ranges.
424 2012-02-12 Chong Yidong <cyd@gnu.org>
426 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
427 as that creates a dangerous corner case.
429 * window.c (Fdelete_window_internal): Invalidate the mouse
430 highlight (Bug#9904).
432 2012-02-12 Glenn Morris <rgm@gnu.org>
434 * xselect.c (Fx_own_selection_internal)
435 (Fx_get_selection_internal, Fx_disown_selection_internal)
436 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
437 * nsselect.m (Fx_own_selection_internal)
438 (Fx_disown_selection_internal, Fx_selection_exists_p)
439 (Fx_selection_owner_p, Fx_get_selection_internal):
440 Sync docs and argument specs with the xselect.c versions.
442 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
444 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
446 2012-02-11 Eli Zaretskii <eliz@gnu.org>
448 * w32select.c (Fx_selection_exists_p): Sync doc string and
449 argument list with xselect.c. (Bug#10783)
451 * w16select.c (Fx_selection_exists_p): Sync doc string and
452 argument list with xselect.c. (Bug#10783)
454 2012-02-10 Glenn Morris <rgm@gnu.org>
456 * fns.c (Fsecure_hash): Doc fix.
458 2012-02-09 Kenichi Handa <handa@m17n.org>
460 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
462 2012-02-07 Chong Yidong <cyd@gnu.org>
464 * buffer.c (Fbuffer_local_variables)
465 (buffer_lisp_local_variables): Handle unbound vars correctly;
466 don't let Qunbound leak into Lisp.
468 2012-02-07 Glenn Morris <rgm@gnu.org>
470 * image.c (Fimagemagick_types): Doc fix.
472 * image.c (imagemagick-render-type): Change it from a lisp object
473 to an integer. Move the doc here from the lisp manual.
474 Treat all values not equal to 0 the same.
476 2012-02-06 Chong Yidong <cyd@gnu.org>
478 * doc.c (store_function_docstring): Avoid applying docstring of
479 alias to base function (Bug#2603).
481 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
483 * .gdbinit (pp1, pv1): Remove redundant defines.
486 2012-02-04 Chong Yidong <cyd@gnu.org>
488 * nsterm.m: Declare a global (Bug#10694).
490 2012-02-04 Eli Zaretskii <eliz@gnu.org>
492 * w32.c (get_emacs_configuration_options):
493 Include --enable-checking, if specified, in the return value.
495 2012-02-04 Martin Rudalics <rudalics@gmx.at>
497 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
498 after rounding frame sizes. (Bug#9723)
500 2012-02-04 Eli Zaretskii <eliz@gnu.org>
502 * keyboard.c (adjust_point_for_property): Don't position point
503 before BEGV. (Bug#10696)
505 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
507 Handle overflow when computing char display width (Bug#9496).
508 * character.c (char_width): Return EMACS_INT, not int.
509 (char_width, c_string_width): Check for overflow when
510 computing the width; this is possible now that individual
511 characters can have unbounded width. Problem introduced
512 by merge from Emacs 23 on 2012-01-19.
514 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
516 * dbusbind.c (Fdbus_register_method): Mention the return value
517 :ignore in the docstring.
519 2012-02-02 Glenn Morris <rgm@gnu.org>
521 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
523 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
524 Unconditionally set to t. (Bug#10673)
525 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
526 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
527 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
529 2012-02-02 Kenichi Handa <handa@m17n.org>
531 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
532 0, do not call append_composite_glyph.
534 2012-02-02 Kenichi Handa <handa@m17n.org>
536 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
538 (x_produce_glyphs): If the component of a composition is a null
539 string, set it->pixel_width to 1 to avoid zero-width glyph.
541 2012-02-01 Eli Zaretskii <eliz@gnu.org>
543 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
544 first 2 arguments are identical. This makes inserting large
545 output from a subprocess an order of magnitude faster on
546 MS-Windows, where all sbrk'ed memory is always contiguous.
548 2012-01-31 Glenn Morris <rgm@gnu.org>
550 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
551 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
552 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
554 2012-01-29 Glenn Morris <rgm@gnu.org>
556 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
558 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
560 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
562 2012-01-28 Chong Yidong <cyd@gnu.org>
564 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
566 2012-01-26 Chong Yidong <cyd@gnu.org>
568 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
570 * search.c (Fsearch_forward, Fsearch_backward): Document negative
571 repeat counts (Bug#10507).
573 2012-01-26 Glenn Morris <rgm@gnu.org>
575 * lread.c (syms_of_lread): Doc fix.
577 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
579 * coding.c (encode_designation_at_bol): Change return value to
582 2012-01-25 Chong Yidong <cyd@gnu.org>
584 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
586 2012-01-21 Chong Yidong <cyd@gnu.org>
588 * floatfns.c (Fcopysign): Make the second argument non-optional,
589 since nil is not allowed anyway.
591 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
593 * process.c (read_process_output): Use p instead of XPROCESS (proc).
594 (send_process): Likewise.
596 2012-01-19 Martin Rudalics <rudalics@gmx.at>
598 * window.c (save_window_save, Fcurrent_window_configuration)
599 (Vwindow_persistent_parameters): Do not use Qstate.
602 2012-01-19 Kenichi Handa <handa@m17n.org>
604 * character.c (char_width): New function.
605 (Fchar_width, c_string_width, lisp_string_width):
606 Use char_width (Bug#9496).
608 2012-01-16 Martin Rudalics <rudalics@gmx.at>
610 * window.c (Vwindow_persistent_parameters): New variable.
611 (Fset_window_configuration, save_window_save): Handle persistent
614 2012-01-14 Eli Zaretskii <eliz@gnu.org>
616 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
617 thrashing the stack of the thread. (Bug#9087)
619 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
621 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
623 2012-01-11 Eli Zaretskii <eliz@gnu.org>
625 * xdisp.c (rows_from_pos_range): Handle the case where the
626 highlight ends on a newline. (Bug#10464)
627 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
628 he end column for display of highlight that ends on a newline
631 2012-01-11 Glenn Morris <rgm@gnu.org>
633 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
634 from load-path also when installation-directory is nil. (Bug#10208)
636 2012-01-10 Glenn Morris <rgm@gnu.org>
638 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
640 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
641 Update template values to be closer to their typical values these days.
643 2012-01-09 Eli Zaretskii <eliz@gnu.org>
645 * xdisp.c (rows_from_pos_range): Accept additional argument
646 DISP_STRING, and accept any glyph in a row whose object is that
647 string as eligible for mouse highlight. Fixes mouse highlight of
648 display strings from overlays. (Bug#10464)
650 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
652 emacs: fix an auto-save permissions race condition (Bug#10400)
653 * fileio.c (auto_saving_dir_umask): New static var.
654 (Fmake_directory_internal): Use it.
655 (do_auto_save_make_dir): Set it, instead of invoking chmod after
656 creating the directory. The old code temporarily assigns
657 too-generous permissions to the directory.
658 (do_auto_save_eh): Clear it.
659 (Fdo_auto_save): Catch all errors, not just file errors, so
660 that the var is always cleared.
662 2012-01-07 Eli Zaretskii <eliz@gnu.org>
664 * search.c (scan_buffer): Pass character positions to
665 know_region_cache, not byte positions. (Bug#6540)
667 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
669 * w32.c (sys_rename): Report EXDEV when rename of a directory
670 fails because the target is on another logical disk. (Bug#10284)
672 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
674 * xterm.c (x_embed_request_focus): New function.
676 * xterm.h: Add prototype.
678 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
680 2012-01-05 Glenn Morris <rgm@gnu.org>
682 * emacs.c (emacs_copyright): Update short copyright year to 2012.
684 2012-01-01 Eli Zaretskii <eliz@gnu.org>
686 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
687 Load gnutls_transport_set_lowat only if GnuTLS version is below
689 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
690 GnuTLS versions below 2.11.1.
692 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
694 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
695 to the doc string advising against its use for altering the way
696 windows are scrolled.
698 2011-12-28 Kenichi Handa <handa@m17n.org>
700 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
701 coding-system ASCII compatible only when it does not produce BOM
702 on encoding (Bug#10383).
704 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
706 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
708 (create_and_show_popup_menu): Always use menu_position_func for
711 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
713 * callint.c (Fcall_interactively): Don't truncate prompt string.
715 2011-12-23 Eli Zaretskii <eliz@gnu.org>
717 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
718 property that ends at ZV, so that the bidi iteration could be
719 resumed from there (after widening). (Bug#10360)
721 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
723 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
725 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
727 * nsterm.m (x_free_frame_resources):
728 Release f->output_data.ns->miniimage.
729 (ns_index_color): Fix indentation. Do not retain
730 color_table->colors[i].
732 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
735 * nsfns.m (x_set_background_color): Assign return value from
736 ns_index_color to face-background instead of NSColor*.
737 (ns_implicitly_set_icon_type): Fix indentation.
738 Change assignment in for loop to comparison.
740 * emacs.c (ns_pool): New variable.
741 (main): Assign ns_pool.
742 (Fkill_emacs): Call ns_release_autorelease_pool.
744 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
745 autorelease fdesc, release fdAttrs and tdict.
746 (ns_get_covering_families): Release charset.
747 (ns_findfonts): Release NSFontDescriptor created with new.
748 (ns_uni_to_glyphs): Fix indentation.
749 (setString): Release attrStr before assigning new value.
751 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
753 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
755 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
756 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
758 2011-12-18 David Reitter <reitter@cmu.edu>
760 * nsterm.m (ns_term_init): Subscribe for notifications
761 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
762 to method trackingNotification in EmacsMenu.
764 * nsmenu.m (trackingMenu): New variable.
765 (trackingNotification): New method (from Aquamacs).
766 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
767 from Aquamacs (Bug#7030).
769 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
771 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
772 (symbol_to_nsstring): Fix indentation.
773 (ns_symbol_to_pb): New function.
774 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
775 (Fns_rotate_cut_buffers_internal): Remove.
776 (Fns_store_selection_internal): Rename from
777 Fns_store_cut_buffer_internal.
778 (ns_get_foreign_selection, Fx_own_selection_internal)
779 (Fx_disown_selection_internal, Fx_selection_exists_p)
780 (Fns_get_selection_internal, Fns_store_selection_internal):
781 Use ns_symbol_to_pb and check if return value is nil.
782 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
783 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
784 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
785 renamed to Sns_store_selection_internal.
786 (ns_handle_selection_request): Move code to Fx_own_selection_internal
787 and remove this function.
788 (ns_handle_selection_clear): Remove, never used.
789 (Fx_own_selection_internal): Move code from ns_handle_selection_request
792 2011-12-17 Ken Brown <kbrown@cornell.edu>
794 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
795 GID is unknown (Bug#10257).
797 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
799 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
800 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
801 which caused a build failure on GNU/Linux IA-64. This problem was
802 introduced by my 2011-10-07 patch.
804 2011-12-15 Juri Linkov <juri@jurta.org>
806 * image.c (imagemagick_error): New function. (Bug#10112)
807 (imagemagick_load_image): Comment out `MagickSetResolution' call.
808 Use `imagemagick_error' where ImageMagick functions return
810 (Fimagemagick_types): Add `Fnreverse' to return the list in the
813 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
815 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
816 fill background (Bug#8992).
818 2011-12-13 Martin Rudalics <rudalics@gmx.at>
820 * window.c (Vwindow_combination_resize)
821 (Vwindow_combination_limit): Use t instead of non-nil in
823 (Vrecenter_redisplay): Add first sentence of doc-string on
825 (Frecenter): Fix doc-string typo.
827 2011-12-11 Kenichi Handa <handa@m17n.org>
829 * coding.c (Funencodable_char_position): Pay attention to the
830 buffer text relocation (Bug#9389).
832 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
834 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
835 gtk_init (Bug#10100).
837 2011-12-10 Eli Zaretskii <eliz@gnu.org>
839 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
840 IT->string is nil. (Bug#10263)
842 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
844 * nsterm.h (x_free_frame_resources): Declare.
846 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
847 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
849 * nsterm.h (ns_get_defaults_value): Declare.
851 * nsterm.m (ns_default): Call ns_get_defaults_value.
853 2011-12-09 Eli Zaretskii <eliz@gnu.org>
855 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
858 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
860 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
861 that where the value of an _OBJC_* symbol points to is in the .bss
864 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
866 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
867 after the loop to call ccl_driver at least once (Bug#8619).
869 2011-12-08 Kenichi Handa <handa@m17n.org>
871 * ftfont.c (get_adstyle_property): Fix previous change
874 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
876 * w32.c (init_environment): If no_site_lisp, remove site-lisp
877 dirs from the default value of EMACSLOADPATH (bug#10208).
879 2011-12-07 Glenn Morris <rgm@gnu.org>
881 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
882 installation and source directories as well. (Bug#10208)
884 2011-12-06 Chong Yidong <cyd@gnu.org>
886 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
888 2011-12-06 Glenn Morris <rgm@gnu.org>
890 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
891 as an error, not just -1. (Bug#10217)
893 2011-12-05 Chong Yidong <cyd@gnu.org>
895 * keyboard.c (process_special_events): New function.
896 (swallow_events, Finput_pending_p): Use it (Bug#10195).
898 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
900 * coding.c (encode_designation_at_bol): Don't use uninitialized
901 local variable (Bug#9318).
903 2011-12-05 Kenichi Handa <handa@m17n.org>
905 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
906 return Qnil (Bug#8046, Bug#10193).
908 2011-12-05 Kenichi Handa <handa@m17n.org>
910 * coding.c (encode_designation_at_bol): New args charbuf_end and
911 dst. Return the number of produced bytes. Callers changed.
912 (coding_set_source): Return how many bytes coding->source was
914 (coding_set_destination): Return how many bytes
915 coding->destination was relocated.
916 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
917 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
919 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
921 * coding.c (CODING_CHAR_CHARSET_P): New macro.
922 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
925 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
927 The following changes are to fix Bug#9318.
929 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
930 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
931 (encode_coding_iso_2022, encode_coding_sjis)
932 (encode_coding_big5, encode_coding_charset): Use the above macros.
934 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
936 * lisp.h (process_quit_flag): Fix external declaration.
938 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
940 Don't macro-inline non-performance-critical code.
941 * eval.c (process_quit_flag): New function.
942 * lisp.h (QUIT): Use it.
944 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
946 * nsfns.m (get_geometry_from_preferences): New function.
947 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
949 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
951 * emacs.c (Qkill_emacs): Define.
952 (syms_of_emacs): Initialize it.
953 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
954 Qquit_flag to `kill-emacs' instead.
955 (quit_throw_to_read_char): Add parameter `from_signal'.
956 All callers changed. Call Fkill_emacs if requested and safe.
957 * lisp.h (QUIT): Call Fkill_emacs if requested.
959 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
961 * widget.c (update_wm_hints): Return if wmshell is null.
962 (widget_update_wm_size_hints): New function.
964 * widget.h (widget_update_wm_size_hints): Declare.
966 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
967 widget_update_wm_size_hints (Bug#10104).
969 2011-12-03 Eli Zaretskii <eliz@gnu.org>
971 * xdisp.c (handle_invisible_prop): If the invisible text ends just
972 before a newline, prepare the bidi iterator for consuming the
973 newline, and keep the current paragraph direction. (Bug#10183)
974 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
976 2011-12-02 Juri Linkov <juri@jurta.org>
978 * search.c (Fword_search_regexp): New Lisp function created from
979 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
980 (Fword_search_backward, Fword_search_forward)
981 (Fword_search_backward_lax, Fword_search_forward_lax):
982 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
983 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
985 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
987 * fileio.c (Finsert_file_contents): Move after-change-function call
988 to before the "handled:" label, since all "goto handled" appear in
989 cases where the *-change-functions have already been properly called
992 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
994 * keyboard.c (interrupt_signal): Don't call kill-emacs when
995 waiting for input. (Bug#10169)
997 2011-11-30 Eli Zaretskii <eliz@gnu.org>
999 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1000 verifies glyph row's hash code--we have just reallocated the
1001 glyphs, so their contents can be complete garbage. (Bug#10164)
1003 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1005 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1007 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1009 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1010 attributes are tested _before_ calling verify_row_hash, to protect
1011 against GCC re-ordering of the tests. (Bug#10164)
1013 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1015 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1017 * xterm.c (handle_one_xevent): Only set async_visible and friends
1018 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1019 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1020 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1022 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1024 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1025 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1026 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1027 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1028 All uses changed to use GCPRO1 etc.
1029 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1030 Revert to old implementation (i.e., before 2011-03-11).
1032 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1034 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1035 of scroll runs so as to avoid assigning disabled bogus rows and
1036 unnecessary graphics copy operations.
1038 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1040 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1041 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1042 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1043 (malloc, free, realloc, calloc): Redirect to e_* only when
1046 * lisp.h (GCTYPEBITS): Move before first use.
1047 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1048 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1049 this macro definition.
1051 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1054 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1056 * gtkutil.c (xg_create_frame_widgets):
1057 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1058 present with Gtk+ 2.0.
1060 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1062 * fileio.c (Finsert_file_contents): Undo previous change; see
1063 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1065 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1067 Rename locals to avoid shadowing.
1068 * fileio.c (Finsert_file_contents):
1069 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1070 * process.c (wait_reading_process_output):
1071 Rename inner 'proc' to 'p' to avoid shadowing.
1072 Indent for consistency with usual Emacs style.
1074 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1076 * xdisp.c (redisplay_window): If cursor row is not fully visible
1077 after recentering, and scroll-conservatively is set to a large
1078 number, scroll window by a few more lines to make the cursor fully
1079 visible and out of scroll-margin. (Bug#10105)
1080 (start_display): Don't move to the next line if the display should
1081 start at a newline that is part of a display vector or an overlay
1084 2011-11-24 Juri Linkov <juri@jurta.org>
1086 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1087 after the `MagickPingImage' call. (Bug#10112)
1089 2011-11-23 Chong Yidong <cyd@gnu.org>
1091 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1093 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1095 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1096 making another buffer current. (Bug#10114)
1098 2011-11-23 Glenn Morris <rgm@gnu.org>
1100 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1102 2011-11-23 Chong Yidong <cyd@gnu.org>
1104 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1105 using it (Bug#5984).
1107 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1109 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1110 and header-lines, as they don't have one computed for them.
1113 * .gdbinit (prow): Make displayed values more self-explaining.
1114 Add row's hash code.
1116 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1118 * process.c (wait_reading_process_output): Fix asynchrounous
1119 GnuTLS socket handling on some versions of the GnuTLS library.
1120 (wait_reading_process_output): Add comment and URL.
1122 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1124 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1126 2011-11-21 Chong Yidong <cyd@gnu.org>
1128 * window.c (Fnext_window, Fprevious_window): Doc fix.
1130 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1132 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1134 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1136 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1138 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1140 * window.c (Fset_window_combination_limit): Rename argument
1142 (Vwindow_combination_limit): Remove "status" from doc-string.
1144 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1146 * m/ibms390.h: Remove.
1147 * m/ibms390x.h: Don't include "ibms390.h".
1149 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1151 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1152 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1154 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1156 * casetab.c (Fset_case_table):
1157 * charset.c (Fcharset_after): Fix typos.
1159 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1161 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1162 Otherwise, valgrind does not work on some platforms.
1163 Problem reported by Andreas Schwab in
1164 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1165 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1166 is set, removing the need for VIRT_ADDRESS_VARIES.
1167 (PURE_P): Use a more-efficient implementation that needs just one
1168 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1169 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1170 to 4 (xorl, subq, cmpq, setbe).
1171 * alloc.c (pure): Always extern now, since that's the
1172 VIRT_ADDR_VARIES behavior.
1173 (PURE_POINTER_P): Use a single comparison, not two, for
1174 consistency with the new puresize.h.
1175 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1176 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1177 Remove VIRT_ADDR_VARIES no longer needed.
1179 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1181 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1182 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1183 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1184 behave as if the cursor position were at the window margin.
1186 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1187 and the cursor position is out of bounds, behave as if the cursor
1188 position were at the window margin. (Bug#10075)
1190 2011-11-18 Chong Yidong <cyd@gnu.org>
1192 * window.c (Fwindow_combination_limit): Make first argument
1193 non-optional, since it is meaningless for live windows like the
1196 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1198 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1200 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1202 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1203 (graft_intervals_into_buffer): Simplify.
1205 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1207 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1208 hash values of the two rows.
1209 (copy_row_except_pointers): Preserve the used[] arrays and the
1210 hash values of the two rows. (Bug#10035)
1211 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1213 * xdisp.c (row_hash): New function, body extracted from
1214 compute_line_metrics.
1215 (compute_line_metrics): Call row_hash, instead of computing the
1218 * dispnew.c (verify_row_hash): Call row_hash for computing the
1219 hash code of a row, instead of duplicating code from xdisp.c.
1221 * dispextern.h (row_hash): Add prototype.
1223 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1225 * frame.c (delete_frame): Don't delete the terminal when the last
1226 X frame is closed if emacs is built with GTK toolkit.
1228 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1230 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1232 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1234 * window.c (Vwindow_splits): Rename to
1235 Vwindow_combination_resize. Suggested by Juri Linkov.
1236 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1239 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1241 * nsfns.m (Fns_font_name):
1242 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1244 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1246 * window.h (window): Rename slot "nest" to "combination_limit".
1247 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1248 (Fset_window_nest): Rename to Fset_window_combination_limit.
1249 (Vwindow_nest): Rename to Vwindow_combination_limit.
1250 (recombine_windows, make_parent_window, make_window)
1251 (Fsplit_window_internal, saved_window)
1252 (Fset_window_configuration, save_window_save): Rename all
1253 occurrences of window_nest to window_combination_limit.
1255 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1257 * image.c (imagemagick_load_image): Fix typo.
1259 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1261 * xdisp.c (display_line): Move the call to
1262 highlight_trailing_whitespace before the call to
1263 compute_line_metrics, since the latter needs to see the final
1264 faces of all the glyphs to compute ROW's hash value.
1265 Fixes assertion violations in row_equal_p. (Bug#10035)
1267 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1269 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1270 just return (bug#10044).
1272 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1274 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1275 with user-defined heap size. Bump the default size of the temacs
1276 heap to 27MB, to avoid memory warning when running temacs.
1277 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1279 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1280 current_matrix and desired_matrix. (Bug#9990)
1281 (verify_row_hash) [XASSERTS]: New function.
1282 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1283 that the hash value of glyph rows is correct.
1285 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1287 * window.h (window): Remove splits slot.
1288 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1289 (Fdelete_other_windows_internal, make_parent_window)
1290 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1291 (Fset_window_configuration, save_window_save): Don't deal with
1292 split status of windows.
1293 (saved_window): Remove splits slot.
1294 (Vwindow_splits): Rewrite doc-string.
1296 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1298 * xfns.c (unwind_create_frame):
1299 * nsfns.m (unwind_create_frame):
1300 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1301 Vframe_list (Bug#9999).
1303 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1305 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1307 2011-11-11 Kenichi Handa <handa@m17n.org>
1309 * callproc.c (Fcall_process): Set the member dst_multibyte of
1312 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1314 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1315 avoid a crash (bug#9496).
1317 2011-11-09 Chong Yidong <cyd@gnu.org>
1319 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1320 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1322 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1324 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1326 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1328 Avoid some portability problems by eschewing 'extern inline' functions.
1329 The trivial performance wins aren't worth the portability hassles; see
1330 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1332 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1333 (window_box_width, window_box_left, window_box_left_offset)
1334 (window_box_right, window_box_right_offset): Undo previous change,
1335 by removing the "extern"s.
1336 * intervals.c (adjust_intervals_for_insertion)
1337 (adjust_intervals_for_deletion): Undo previous change,
1338 making these static again.
1339 (offset_intervals, temp_set_point_both, temp_set_point)
1340 (copy_intervals_to_string): No longer inline.
1341 * xdisp.c (window_text_bottom_y, window_box_width)
1342 (window_box_height, window_box_left_offset)
1343 (window_box_right_offset, window_box_left, window_box_right)
1344 (window_box): No longer inline.
1346 2011-11-08 Chong Yidong <cyd@gnu.org>
1348 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1349 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1350 Signal an error if not a live window.
1351 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1352 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1354 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1356 * lisp.h (syms_of_abbrev): Remove declaration.
1357 Reported by CHENG Gao <chenggao@royau.me>.
1359 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1361 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1362 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1363 of temacs in GUI mode.
1365 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1367 * window.h: Declare delete_all_child_windows instead of
1368 delete_all_subwindows.
1369 * window.c (Fwindow_nest, Fset_window_nest)
1370 (Fset_window_new_total, Fset_window_new_normal)
1371 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1372 (delete_all_subwindows): Rename to delete_all_child_windows.
1373 (Fdelete_other_windows_internal, Fset_window_configuration):
1374 Call delete_all_child_windows instead of delete_all_subwindows.
1375 * frame.c (delete_frame): Call delete_all_child_windows instead
1376 of delete_all_subwindows.
1378 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1380 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1381 This is also needed for porting to any host where GC_MARK_STACK is
1382 not GC_MAKE_GCPROS_NOOPS.
1383 (which_symbols): Use it.
1385 2011-11-07 Kenichi Handa <handa@m17n.org>
1387 * coding.c (coding_set_destination): Check coding->src_pos only
1388 when coding->src_object is a buffer (bug#9910).
1390 * process.c (send_process): Set the member src_multibyte of coding
1391 to 0 (bug#9911) when sending a unibyte text.
1393 * callproc.c (Fcall_process): Set the member src_multibyte of
1394 process_coding to 0 (bug#9912).
1396 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1398 * xmenu.c (cleanup_widget_value_tree): New function.
1399 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1400 calling free_menubar_widget_value_tree directly (Bug#9830).
1402 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1404 Fix some portability problems with 'inline'.
1405 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1406 (window_box_width, window_box_left, window_box_left_offset)
1407 (window_box_right, window_box_right_offset): Declare extern.
1408 Otherwise, these inline functions do not conform to C99 and
1409 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1410 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1411 * intervals.c (adjust_intervals_for_insertion)
1412 (adjust_intervals_for_deletion): Now extern, because otherwise the
1413 extern inline functions 'offset_intervals' couldn't refer to it.
1414 (static_offset_intervals): Remove.
1415 (offset_intervals): Rewrite using the old contents of
1416 static_offset_intervals. The old version didn't conform to C99
1417 because an extern inline function contained a reference to an
1418 identifier with static linkage.
1420 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1422 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1425 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1427 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1428 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1429 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1430 return Qleft_to_right.
1432 2011-11-06 Chong Yidong <cyd@gnu.org>
1434 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1435 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1436 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1437 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1438 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1439 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1440 (Fwindow_vscroll): Doc fix.
1441 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1442 argument, since it makes no sense to pass a live window and for
1443 consistency with window-child.
1445 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1447 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1450 2011-11-05 Jason Rumney <jasonr@gnu.org>
1452 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1453 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1455 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1456 bitwise arithmetic preventing use of unicode-sip and non-truetype
1459 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1461 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1464 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1465 initialization code to keep similarity to xfns.c after changes
1468 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1470 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1471 (unwind_create_frame): New function (Bug#9943).
1472 (Fx_create_frame): Restructure code to be more similar to the one in
1473 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1474 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1475 Move terminal->reference_count++ just before making the frame official
1478 * nsterm.m (x_free_frame_resources): New function.
1479 (x_destroy_window): Move code to x_free_frame_resources.
1481 * xfns.c (unwind_create_frame): Fix comment.
1482 (Fx_create_frame, x_create_tip_frame):
1483 Move terminal->reference_count++ just before making the frame
1484 official. Move initialization of image_cache_refcount and
1485 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1487 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1489 Support MSVC build with newer versions of Visual Studio.
1490 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1491 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1494 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1495 which are not supported by MSVC.
1496 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1497 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1499 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1501 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1503 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1505 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1507 Support MSVC build with newer versions of Visual Studio.
1508 * w32.c: Don't include w32api.h for MSVC.
1509 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1511 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1512 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1513 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1514 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1516 (alloca) [_MSC_VER]: Define to _alloca.
1518 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1520 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1522 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1524 * xdisp.c (note_mouse_highlight): If either of
1525 previous/next-single-property-change returns nil, treat that as
1526 the beginning or the end of the buffer. (Bug#9955)
1528 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1530 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1531 label is not null (Bug#9951).
1532 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1535 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1537 * window.c (Fwindow_body_size): Mention in the doc string that the
1538 return value is in frame's canonical units. (Bug#9949)
1540 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1542 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1544 * w32fns.c (unwind_create_frame): If needed, free the glyph
1545 matrices of the partially constructed frame. (Bug#9943)
1546 * xfns.c (unwind_create_frame): Likewise.
1548 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1550 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1551 Don't stop backward scan on the continuation glyph, even though
1552 its CHARPOS is positive.
1553 (mouse_face_from_buffer_pos, note_mouse_highlight):
1554 Rename cover_string to disp_string.
1556 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1558 * window.c (temp_output_buffer_show): Don't use
1559 Vtemp_buffer_show_specifiers.
1560 (Vtemp_buffer_show_specifiers): Remove unused variable.
1562 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1564 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1565 past the beginning of the current glyph matrix.
1567 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1569 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1570 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1571 HAVE_GTK3 (Bug#9869).
1573 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1574 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1576 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1578 * xterm.c: Declare x_handle_net_wm_state to return int.
1579 (handle_one_xevent): Check if we are iconified but don't have
1580 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1581 (get_current_wm_state): Return non-zero if not hidden,
1582 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1583 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1584 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1585 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1587 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1589 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1590 so that this new function doesn't get optimized away by a
1591 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1593 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1595 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1597 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1599 Fix the `xbytecode' command.
1600 * .gdbinit (xprintbytestr): New command.
1601 (xwhichsymbols): Rename from `which'; all callers changed.
1602 (xbytecode): Print the byte-code string as well.
1604 2011-10-29 Kim Storm <storm@cua.dk>
1606 * alloc.c (which_symbols): New function.
1608 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1610 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1613 2011-10-29 Glenn Morris <rgm@gnu.org>
1615 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1616 Not clear what it was for, and it causes various bugs. (Bug#9839)
1618 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1620 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1621 possible random value that matches one of those tested as
1622 condition to clear the mouse face.
1624 2011-10-28 Chong Yidong <cyd@gnu.org>
1626 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1628 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1630 * window.c (make_window): Initialize phys_cursor_on_p.
1632 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1634 * lisp.h (struct Lisp_Symbol): Update comments.
1636 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1638 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1640 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1642 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1643 <oslsachem@gmail.com> for helping to debug this.
1645 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1646 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1647 (g_b_init_get_glyph_outline_w): New static variables.
1648 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1649 (GetGlyphOutlineW_Proc): New typedefs.
1650 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1651 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1653 (w32font_open_internal, compute_metrics):
1654 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1655 instead of calling the "wide" APIs directly.
1657 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1659 * w32.h (syms_of_w32font): Add prototype.
1661 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1663 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1664 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1665 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1666 (Fmove_to_window_line): Doc fix.
1668 2011-10-27 Chong Yidong <cyd@gnu.org>
1670 * process.c (make_process): Set gnutls_state to NULL.
1672 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1673 non-NULL, regardless of GNUTLS_INITSTAGE.
1674 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1675 an error. Set process slots as soon as we allocate them.
1677 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1679 2011-10-27 Chong Yidong <cyd@gnu.org>
1681 * gnutls.c (emacs_gnutls_deinit): New function.
1682 Deallocate credentials structures as well as calling gnutls_deinit.
1683 (Fgnutls_deinit, Fgnutls_boot): Use it.
1685 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1686 (deactivate_process): Call emacs_gnutls_deinit.
1688 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1690 * image.c (x_create_x_image_and_pixmap):
1691 * w32.c (sys_rename, w32_delayed_load):
1692 * w32font.c (fill_in_logfont):
1693 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1695 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1697 * w32fns.c (w32_default_color_map): New function,
1698 extracted from Fw32_default_color_map.
1699 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1701 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1703 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1705 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1707 * keyboard.c (test_undefined): New function (bug#9751).
1708 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1710 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1712 * sysdep.c (init_sys_modes): Fix the check for the controlling
1713 terminal (Bug#6649).
1715 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1717 * dispextern.h (struct bidi_it): New member next_en_type.
1719 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1720 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1721 current character, check also for next_en_type being WEAK_EN.
1722 (bidi_resolve_weak): Don't enter the expensive loop if the current
1723 position is before next_en_pos. Record the bidi type of the first
1724 non-ET, non-BN character we find, in addition to its position.
1725 (bidi_level_of_next_char): Invalidate next_en_type when
1726 next_en_pos is over-stepped.
1728 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1730 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1731 * editfns.c: Rewrite current-time-zone so that it invokes
1732 the equivalent of (format-time-string "%Z") to get the time zone name.
1733 This fixes a bug when the time zone name contains characters that
1734 need converting from the system time locale to Emacs internal format.
1735 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1736 that patch fixed format-time-string to do the conversion, but
1737 I forgot to fix current-time-zone.
1738 (format_time_string): New function, containing most of
1739 what Fformat_time_string used to contain.
1740 (Fformat_time_string): Rewrite in terms of format_time_string.
1741 This doesn't change this function's behavior.
1742 (current-time-zone): Rewrite to use format_time_string.
1743 This fixes the bug reported by Michael Schierl in
1744 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1745 Jason Rumney's 2007-06-07 change worked around this bug, but
1747 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1749 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1751 * xdisp.c (start_display): If the character at POS is displayed
1752 via a display vector, reset IT->current.dpvec_index to zero.
1753 (try_window_reusing_current_matrix): If a line ends in a display
1754 vector or the next line starts in a display vector, continue
1755 redrawing the window even though the character position of
1756 start_row was reached.
1759 2011-10-18 Chong Yidong <cyd@gnu.org>
1761 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1762 with nobreak-char-display too.
1764 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1766 Fix part 3 of bug#9771.
1767 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1768 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1769 non-neutral characters if the current character is a paragraph
1770 separator (a.k.a. Newline). This avoids running the same
1771 expensive loop twice, once when we consume the preceding newline
1772 and the other time when the line actually needs to be displayed.
1773 Avoid the loop when we see neutrals on the base embedding level
1774 following a character whose directionality is the same as the
1775 paragraph's. This avoids running the expensive loop when a line
1776 ends in a long sequence of neutrals, like control characters.
1777 Add assertion against STRONG_AL type. Slightly rearrange code
1778 that determines the type of a neutral given the first non-neutral
1780 (bidi_level_of_next_char): Set next_en_pos to zero when
1781 invalidating its info.
1783 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1785 * xdisp.c (push_display_prop): Determine whether to record string
1786 or buffer position by IT->string, not by IT->method. Allow
1787 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1788 (move_it_vertically_backward): Don't look for character position
1789 immediately after the newline when in a continuation line.
1792 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1794 * window.c (coordinates_in_window): Rewrite and delabelize
1795 vertical border check. (Bug#5357) (Bug#9618)
1797 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1799 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1800 errors in XSetWindowBorder (bug#9310).
1802 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1804 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1805 avoid crash when xmalloc overrun checking is enabled.
1807 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1809 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1810 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1811 cursor motion with <left> and <right> arrow keys.
1813 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1814 some callers set that themselves.
1816 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1818 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1819 display string and the previous row comes from the same string and
1820 is empty. (Bug#9739) (Bug#9738)
1822 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1824 * doc.c (get_doc_string): Encode file name (bug#9735).
1826 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1828 * bidi.c (bidi_level_of_next_char):
1829 * xdisp.c (get_visually_first_element): Remove old incorrect
1830 comments regarding the Unicode Line Separator character.
1832 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1834 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1836 * alloc.c (Fgc_status): Do not access beyond zombies array
1837 boundary if nzombies > MAX_ZOMBIES.
1838 * alloc.c (dump_zombies): Add missing format specifier.
1840 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1842 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1843 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1845 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1846 Some packages use them to denote characters with modifiers.
1848 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1850 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1851 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1852 matching a pp-number. Rename parameter var to var1.
1854 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1856 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1858 2011-10-08 Glenn Morris <rgm@gnu.org>
1860 * callint.c (Fcall_interactively): Give a more explicit error for the
1861 'c' case with a non-character input. (Bug#8479)
1863 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1865 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1867 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1868 lines that are hscrolled on the left.
1870 * dispnew.c (buffer_posn_from_coords): Account for a possible
1871 presence of header-line. (Bug#4426)
1873 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1875 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1876 Don't advertise functionality which we discourage or doesn't work.
1878 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1880 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1881 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1882 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1883 this makes Emacs dump core during garbage collection on rare
1884 occasions. sizeof is obviously inferior to offsetof here, so
1885 stick with offsetof.
1886 (GC_POINTER_ALIGNMENT): New macro.
1887 (mark_memory): Omit 3rd (offset) arg; caller changed.
1888 Don't assume EMACS_INT alignment is the same as pointer alignment.
1890 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1892 * keyboard.c (read_key_sequence_remapped): New var.
1893 (read_key_sequence): Compute remapping in the right buffer.
1894 (command_loop_1): Use read_key_sequence's remapping directly.
1896 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1898 * dired.c (file_name_completion): Don't expand file name.
1899 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1900 before checking file name handler.
1902 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1903 they've been requested explicitly (bug#9591).
1905 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1907 * keymap.c (Fsingle_key_description): Use make_specified_string
1908 instead of build_string to build string from push_key_description.
1911 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1913 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1914 This fixes a Y2038 bug on 64-bit hosts.
1915 * buffer.c (reset_buffer):
1916 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1917 (Fclear_buffer_auto_save_failure):
1918 Use 0, not -1, to represent an unset failure time, since time_t
1919 might not be signed.
1921 Remove dependency on glibc malloc internals.
1922 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1923 Move back here from lisp.h, but with their new implementations.
1924 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1925 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1926 * charset.c (charset_table_init): New static var.
1927 (syms_of_charset): Use it instead of xmalloc. This removes a
1928 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1929 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1930 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1931 Move back to alloc.c.
1932 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1933 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1935 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1937 * nsterm.m (windowDidResize): Call x_set_window_size only when
1938 ns_in_resize is true. Otherwise set pixelwidth/height and
1939 call change_frame_size (Bug#9628).
1941 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1943 Port --enable-checking=all to Fedora 14 x86-64.
1944 * charset.c (syms_of_charset): Also account for glibc malloc's
1945 internal overhead when calculating the initial malloc maximum.
1947 Port --enable-checking=all to Fedora 14 x86.
1948 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1950 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1951 (overrun_check_realloc, overrun_check_free):
1952 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1953 That way, xmalloc returns a properly-aligned pointer even if
1954 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1955 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1956 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1957 into account when calculating the initial malloc maximum.
1958 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1959 Move here from alloc.c, so that charset.c can use it too.
1960 Properly align; the old code wasn't right for common 32-bit hosts
1961 when configured with --enable-checking=all.
1962 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1963 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1965 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1967 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1970 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1972 * xdisp.c (compute_display_string_end): If there's no display
1973 string at CHARPOS, return -1.
1975 * bidi.c (bidi_fetch_char): When compute_display_string_end
1976 returns a negative value, treat the character as a normal
1977 character not covered by a display string. (Bug#9624)
1979 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1981 * lread.c (Fread_from_string): Fix typo in docstring.
1983 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1985 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1986 newline, reseat the iterator instead of bidi-iterating there one
1987 character at a time. (Bug#9610)
1988 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1989 TO_CHARPOS if the bidi iterator is at base embedding level.
1991 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1993 * lread.c (readevalloop): Use correct code for NBSP.
1994 (read1): Likewise. (Bug#9608)
1996 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1998 * dbusbind.c (Fdbus_register_signal): When service is not
1999 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2001 2011-09-25 Glenn Morris <rgm@gnu.org>
2003 * buffer.c (truncate-lines): Doc fix.
2005 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2007 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2008 (Fset_window_next_buffers): Doc fix.
2010 2011-09-24 Glenn Morris <rgm@gnu.org>
2012 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2014 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2016 Fix minor problems found by static checking.
2017 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2018 * indent.c (Fvertical_motion): Fix == vs = typo.
2020 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2022 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2023 Default value is now t. Doc fix.
2025 * indent.c (Fvertical_motion): Compute and apply the overshoot
2026 logic when moving up, not only when moving down. Fix the
2027 confusing name and values of the it_overshoot_expected variable;
2028 logic changes accordingly. (Bug#9254) (Bug#9549)
2030 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2031 CHARPOS is covered by a display string which includes newlines.
2032 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2033 is covered by a display string with embedded newlines.
2035 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2037 * dbusbind.c (Fdbus_register_signal): Add match rule to
2038 Vdbus_registered_objects_table. (Bug#9581)
2039 (Fdbus_register_method, Vdbus_registered_objects_table):
2042 2011-09-24 Jim Meyering <meyering@redhat.com>
2044 do not ignore write error for any output size
2045 The previous change was incomplete.
2046 While it makes emacs --batch detect the vast majority of stdout
2047 write failures, errors were still ignored whenever the output size is
2048 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2049 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2050 && echo FAIL: ignored write error
2051 FAIL: ignored write error
2052 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2053 && echo FAIL: ignored write error
2054 FAIL: ignored write error
2055 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2057 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2059 * emacs.c (Fkill_emacs): In noninteractive mode exit
2060 non-successfully if a write error occurred on stdout. (Bug#9574)
2062 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2064 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2067 * dispextern.h (struct it): Update the comment documenting what
2070 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2072 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2073 a display string, extend search for cursor position to end of row.
2074 (find_row_edges): If the row ends in a newline from a display
2075 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2076 Handle the case of a display string with multiple newlines.
2077 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2078 non-empty line. Fixes confusing cursor motion with arrow keys at
2079 the beginning of a line that starts with whitespace.
2081 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2083 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2086 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2088 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2091 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2093 * xdisp.c (display_line): Record maximum and minimum buffer
2094 positions even if no glyphs were produced (e.g., by a zero-width
2095 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2096 buffer positions that will be removed from the glyph row because
2098 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2099 column is beyond frame width: don't subtract 1 "pixel" when
2100 computing width of the stretch.
2101 (reseat_at_next_visible_line_start): Undo the change made on
2102 2011-09-17 that saved paragraph information and restored it after
2103 the call to `reseat'. (Bug#9545)
2105 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2107 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2108 and turn window cursor on if cleared (Bug#9415).
2110 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2112 * search.c (boyer_moore): Take unibyte characters from pattern
2113 literally. (Bug#9458)
2115 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2117 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2119 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2121 Fix minor problem found by static checking.
2122 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2123 initialized, to pacify gcc -Wuninitialized.
2125 * fileio.c: Report proper errno when syscall falls.
2126 (Finsert_file_contents): Save and restore errno,
2127 so that report_file_error outputs the correct diagnostic.
2128 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2130 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2132 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2134 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2136 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2137 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2139 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2141 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2142 about the current paragraph and restore it after the call to reseat.
2144 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2145 (bidi_find_paragraph_start): Search back for paragraph beginning
2146 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2147 (bidi_move_to_visually_next): Only trigger paragraph-related
2148 computations when the last character is a newline or at EOB, not
2149 just any NEUTRAL_B. (Bug#9470)
2151 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2152 truncated lines if point is covered by a display string. (Bug#9524)
2154 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2156 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2157 (cons_to_x_long): New function.
2158 (lisp_data_to_selection_data): Use it. Correct the test for
2159 short-versus-long data; it was negated. Break out of vector
2160 loop, for efficiency, when a long datum is discovered.
2162 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2164 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2166 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2168 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2169 GCC PR/17406) by declaring this function with external scope.
2171 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2173 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2174 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2176 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2178 * editfns.c (Fformat): Correctly handle text properties on "%%".
2180 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2182 * xterm.c (x_draw_composite_glyph_string_foreground):
2183 * w32term.c (x_draw_composite_glyph_string_foreground):
2184 * term.c (encode_terminal_code):
2185 * composite.c (composition_update_it, get_composition_id):
2186 * xdisp.c (get_next_display_element)
2187 (fill_composite_glyph_string): Add comments about special meaning
2188 of TAB characters in a composition.
2190 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2192 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2193 This occurs when processing a multibyte format.
2194 Problem reported by Wolfgang Jenker.
2196 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2198 * xdisp.c (try_cursor_movement): Only check for exact match if
2199 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2201 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2203 Remove unused external symbols.
2204 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2205 * xdisp.c (calc_pixel_width_or_height): Now static.
2206 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2207 * indent.c (check_display_width):
2208 * w32term.c: Fix comment to match code.
2209 * xterm.c, xterm.h (x_catching_errors): Remove.
2211 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2213 * xselect.c: Use signed conversions more consistently (Bug#9498).
2214 (selection_data_to_lisp_data): Assume incoming selection data are
2215 signed integers, not unsigned. This is to be consistent with
2216 outgoing selection data, which was modified to use signed integers
2217 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2218 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2219 expects long, not unsigned long.
2221 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2223 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2224 computation of loop end. Reported by Johan Bockgård
2227 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2229 * frame.c (Fother_visible_frames_p): Function deleted.
2231 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2233 * indent.c (compute_motion): Process display vector front to back
2234 rather than the other way around. (Bug#2496)
2236 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2238 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2240 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2242 * minibuf.c (Fread_from_minibuffer): Doc fix.
2244 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2246 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2247 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2249 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2251 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2252 value for non-existent files.
2254 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2256 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2257 set its "size" to -1. This will set the modtime_size field of
2258 the corresponding buffer to -1, which is what
2259 verify-visited-file-modtime expects for files that do not exist.
2262 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2264 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2266 * lisp.h: ... from here. push_key_description is no longer
2267 defined in keyboard.c, so its declaration should not be in
2268 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2269 logically belongs with push_key_description.
2271 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2273 * buffer.h: Include <sys/types.h> instead of <time.h>.
2274 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2275 Problem reported by Herbert J. Skuhra.
2277 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2279 * xml.c (parse_region): Make the parsing work for
2280 non-comment-starting XML files again (bug#9144).
2282 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2284 * image.c (gif_load): Fix calculation of bottom and right corner.
2287 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2289 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2290 redisplay in small windows.
2292 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2294 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2296 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2298 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2299 Operate on live windows only.
2301 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2303 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2305 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2307 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2308 only under bidi iteration.
2310 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2312 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2314 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2316 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2317 Without this fix, the command to link temacs failed due to an
2318 undefined symbol __builtin_isnan. This is because
2319 /usr/include/iso/math_c99.h #defines isnan(x) to
2320 __builtin_isnan(x), but the bundled gcc, which identifies itself
2321 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2323 * floatfns.c (isnan): #undef, and then #define to a clone of
2325 (Fisnan): Always define, since it's always available now.
2326 (syms_of_floatfns): Always define isnan at the Lisp level.
2328 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2330 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2332 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2334 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2335 The previous code assumed that file offsets (off_t values) fit in
2336 EMACS_INT variables, which is not true on typical 32-bit hosts.
2337 The code messed up by falsely reporting buffer overflow in cases
2338 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2339 when "big" contains more than 2**29 bytes, even though this
2340 inserts just one byte and does not overflow the buffer.
2341 (Finsert_file_contents): Store file offsets as off_t
2342 values, not as EMACS_INT values. Check for overflow when
2343 converting between EMACS_INT and off_t. When checking for
2344 buffer overflow or for overlap, take the offsets into account.
2345 Don't use EMACS_INT for small values where int suffices.
2346 When checking for overlap, fix a typo: ZV was used where
2347 ZV_BYTE was intended.
2348 (Fwrite_region): Don't assume off_t fits into 'long'.
2349 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2351 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2353 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2355 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2357 sprintf-related integer and memory overflow issues (Bug#9412).
2359 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2360 (esprintf, exprintf, evxprintf): New functions.
2361 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2362 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2363 (modify_event_symbol): Do not assume that the length of
2364 name_alist_or_stem is safe to alloca and fits in int.
2365 (Fexecute_extended_command): Likewise for function name and binding.
2366 (Frecursion_depth): Wrap around reliably on integer overflow.
2367 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2368 since some callers pass EMACS_INT values.
2369 (Fsingle_key_description): Don't crash if symbol name contains more
2370 than MAX_ALLOCA bytes.
2371 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2372 (get_minibuffer): Arg is now EMACS_INT, not int.
2373 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2374 (esprintf, exprintf, evxprintf): New decls.
2375 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2377 * dbusbind.c (signature_cat): New function.
2378 (xd_signature, Fdbus_register_signal):
2379 Do not overrun buffer; instead, report string overflow.
2381 * dispnew.c (add_window_display_history): Don't overrun buffer.
2382 Truncate instead; this is OK since it's just a log.
2384 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2385 even if the time zone offset is outlandishly large.
2386 Don't mishandle offset == INT_MIN.
2388 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2389 when creating daemon; the previous buffer-overflow check was incorrect.
2391 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2392 which has the guts of the old verror function.
2394 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2395 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2397 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2398 (font_unparse_xlfd): Don't blindly alloca long strings.
2399 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2400 fits in int, when using sprintf. Use single snprintf to count
2401 length of string rather than counting it via multiple sprintfs;
2402 that's simpler and more reliable.
2403 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2404 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2405 sprintf, in case result does not fit in int.
2407 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2408 (fontset_from_font): Print it.
2410 * frame.c (tty_frame_count): Now printmax_t, not int.
2411 (make_terminal_frame, set_term_frame_name): Print it.
2412 (x_report_frame_params): In X, window IDs are unsigned long,
2413 not signed long, so print them as unsigned.
2414 (validate_x_resource_name): Check for implausibly long names,
2415 and don't assume name length fits in 'int'.
2416 (x_get_resource_string): Don't blindly alloca invocation name;
2417 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2420 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2421 (xg_check_special_colors, xg_set_geometry):
2422 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2424 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2425 Use esprintf, not sprintf, in case result does not fit in int.
2427 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2428 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2429 it as a large positive number.
2430 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2431 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2433 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2434 in case result does not fit in int.
2436 * print.c (float_to_string): Detect width overflow more reliably.
2437 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2438 buffer overrun. Don't assume list length fits in 'int'. Treat
2439 print length of 0 as 0, not as infinity; to be consistent with other
2440 uses of print length in this function. Don't overflow print length
2441 index. Don't assume hash table size fits in 'long', or that
2442 vectorlike size fits in 'unsigned long'.
2444 * process.c (make_process): Use printmax_t, not int, to format
2445 process-name gensyms.
2447 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2449 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2450 to avoid potential buffer overrun.
2452 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2453 if X resource line is longer than 512 bytes.
2455 * xfns.c (x_window): Make sprintf buffer a bit bigger
2456 to avoid potential buffer overrun.
2458 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2460 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2462 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2464 Integer overflow fixes for scrolling, etc.
2465 Without these, Emacs silently mishandles large integers sometimes.
2466 For example, "C-u 4294967297 M-x recenter" was treated as if
2467 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2469 * xdisp.c (try_window_id): Check Emacs fixnum range before
2470 converting to 'int'.
2472 * window.c (window_scroll_line_based, Frecenter):
2473 Check that an Emacs fixnum is in range before assigning it to 'int'.
2474 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2475 values converted from Emacs fixnums.
2476 (Frecenter): Don't wrap around a line count if it is out of 'int'
2477 range; instead, treat it as an extreme value.
2478 (Fset_window_configuration, compare_window_configurations):
2479 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2481 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2482 that can exceed INT_MAX. Check that EMACS_INT value is in range
2483 before assigning it to the (possibly-narrower) index.
2484 (match_limit): Don't assume that a fixnum can fit in 'int'.
2486 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2489 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2490 (Fvertical_motion): Don't wrap around LINES values that don't fit
2491 in 'int'. Instead, treat them as extreme values. This is good
2492 enough for windows, which can't have more than INT_MAX lines anyway.
2494 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2496 * Require libxml/parser.h to avoid compilation warning.
2498 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2500 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2501 since this reportedly can destroy thread storage.
2503 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2505 * syntax.c (find_defun_start): Update all cache variables if
2506 exiting early (Bug#9401).
2508 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2510 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2512 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2513 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2514 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2516 * term.c (tty_append_glyph): New function.
2517 (produce_stretch_glyph): Static function and its prototype deleted.
2519 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2522 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2524 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2525 when checking :margin (Bug#9390).
2526 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2527 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2528 so that the name doesn't mislead. All uses changed.
2530 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2532 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2535 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2537 * xdisp.c (move_it_to): Don't bail out early when reaching
2538 position beyond to_charpos, if we are scanning backwards.
2539 (move_it_vertically_backward): When DY == 0, make sure we get to
2540 the first character in the line after the newline.
2542 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2544 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2545 (ccl_driver): Do not generate an out-of-range pointer.
2546 (Fccl_execute_on_string): Remove unnecessary check for
2547 integer overflow, noted by Stefan Monnier in
2548 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2549 Remove a FIXME that didn't need fixing.
2550 Simplify the newly-introduced buffer reallocation code.
2552 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2554 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2556 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2558 Integer and memory overflow issues (Bug#9196).
2560 * doc.c (get_doc_string): Rework so that
2561 get_doc_string_buffer_size is the actual buffer size, rather than
2562 being 1 less than the actual buffer size; this makes xpalloc more
2565 * image.c (x_allocate_bitmap_record, cache_image):
2566 * xselect.c (Fx_register_dnd_atom):
2567 Simplify previous changes by using xpalloc.
2569 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2570 since either will do and ptrdiff_t is convenient with xpalloc.
2572 * charset.c (charset_table_size)
2573 (struct charset_sort_data.priority): Now ptrdiff_t.
2574 (charset_compare): Don't overflow if priorities differ greatly.
2575 (Fsort_charsets): Don't assume list length fits in int.
2576 Check for size-calculation overflow when allocating sort data.
2577 (syms_of_charset): Allocate an initial charset table that is
2578 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2580 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2582 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2583 The actual value is always <= INT_MAX, and leaving it unsigned made
2584 overflow checking harder.
2586 * dispextern.h (struct glyph_matrix.rows_allocated)
2587 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2588 with xpalloc. The values are still always <= INT_MAX.
2590 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2592 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2593 (SAFE_NALLOCA): New macro.
2595 * region-cache.c (struct boundary.pos, find_cache_boundary)
2596 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2597 (set_cache_region, invalidate_region_cache)
2598 (revalidate_region_cache, know_region_cache, region_cache_forward)
2599 (region_cache_backward, pp_cache):
2600 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2601 so that ptrdiff_t * can be passed to xpalloc.
2602 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2603 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2604 (pp_cache): Don't assume cache_len fits in int.
2605 * region-cache.h: Adjust extern decls to match.
2607 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2608 EMACS_INT, since either will do, for xpalloc.
2610 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2611 (xnmalloc, xnrealloc, xpalloc): New functions.
2613 * bidi.c (bidi_shelve_header_size): New constant.
2614 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2615 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2617 * bidi.c (bidi_cache_shrink):
2618 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2620 Don't update size of array until after memory allocation succeeds,
2621 because xmalloc/xrealloc may not return.
2622 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2623 now that we have proper integer overflow checking.
2624 (record_overlay_string, overlay_strings): Catch overflows when
2625 calculating size of overlay_str_buf.
2627 * callproc.c (Fcall_process): Check for size overflow when
2628 calculating size of args2.
2629 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2630 Normally we prefer signed values, but sticking with ptrdiff_t would
2631 require adding more-complicated checks.
2633 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2634 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2635 Redo buffer-overflow calculations to avoid integer overflow.
2636 Add a FIXME comment where memory seems to be over-allocated.
2638 * character.c (Fstring): Check for size-calculation overflow.
2640 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2641 unnecessary integer overflow. Check for size overflow.
2642 (encode_coding_object): Don't update size until xmalloc succeeds.
2644 * composite.c (get_composition_id): Check for overflow in glyph
2645 length calculations.
2647 Integer and memory overflow fixes for display code.
2648 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2649 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2650 (scrolling_window): Check for overflow in size calculations.
2651 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2652 Don't assume glyph table len fits in int.
2653 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2654 (row_table_size): Now ptrdiff_t, not int.
2655 (scrolling_window): Avoid overflow in size calculations.
2656 Don't update size until allocation succeeds.
2657 * fns.c (concat): Check for overflow in size calculations.
2658 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2659 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2660 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2662 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2663 (get_doc_string): Check for size calculation overflow.
2664 Don't update size until allocation succeeds.
2665 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2666 EMACS_INT, where ptrdiff_t will do.
2667 (Fsubstitute_command_keys): Check for string overflow.
2669 * editfns.c (set_time_zone_rule): Don't assume environment length
2671 (message_length): Now ptrdiff_t, not int.
2672 (Fmessage_box): Don't update size until allocation succeeds.
2673 Don't assume message length fits in int.
2674 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2676 * emacs.c (main): Do not reallocate argv, since there is a null at
2677 the end that can be overwritten, and this way there's no need to
2678 worry about size-calculation overflow.
2679 (sort_args): Check for size-calculation overflow.
2681 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2683 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2685 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2686 (x_set_scroll_bar_width, x_figure_window_size):
2687 Check for integer overflow.
2688 (x_set_alpha): Do not assume XINT fits in int.
2690 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2691 This is for the members text_lines, text_cols, total_lines, total_cols,
2692 where the system imposes an 'int' limit.
2694 * fringe.c (Fdefine_fringe_bitmap):
2695 Don't update size until alloc works.
2697 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2698 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2700 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2701 Check for size-calculation overflow.
2702 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2703 do, as we prefer signed integers.
2704 (id_to_widget.max_size, id_to_widget.used)
2705 (xg_store_widget_in_map, xg_remove_widget_from_map)
2706 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2707 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2708 Use and return ptrdiff_t, not int.
2709 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2710 * gtkutil.h: Change prototypes to match the above.
2712 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2713 are duplicate now that they've been promoted to lisp.h.
2714 (x_allocate_bitmap_record, x_alloc_image_color)
2715 (make_image_cache, cache_image, xpm_load):
2716 Don't update size until alloc is done.
2717 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2719 Check for size calculation overflow.
2720 (ct_colors_allocated_max): New constant.
2721 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2724 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2725 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2726 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2727 Use ptrdiff_t, not int, to count maps.
2728 (read_char_minibuf_menu_prompt): Check for overflow in size
2729 calculations. Don't update size until allocation succeeds.
2730 Redo calculations to avoid overflow.
2731 * keyboard.h: Change prototypes to match the above.
2733 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2735 (current_minor_maps): Check for size calculation overflow.
2736 * keymap.h: Change prototypes to match the above.
2738 * lread.c (read1, init_obarray): Don't update size until alloc done.
2740 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2741 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2743 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2744 Now ptrdiff_t, not int.
2745 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2746 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2748 * process.c (Fnetwork_interface_list): Check for overflow
2749 in size calculation.
2751 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2753 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2754 overflow. Don't bother calling xmalloc when xrealloc will do.
2756 * search.c (Freplace_match): Check for size calculation overflow.
2757 (Fset_match_data): Don't assume list lengths fit in 'int'.
2759 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2760 for command line length. Do not attempt to address one before the
2761 beginning of an array, as that's not portable.
2763 * term.c (max_frame_lines): Remove; unused.
2764 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2766 (encode_terminal_code, calculate_costs): Check for size
2767 calculation overflow.
2768 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2769 table lengths and related sizes. Don't update size until alloc
2770 done. Redo calculations to avoid overflow.
2771 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2773 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2774 subtracting pointers.
2775 (gobble_line): Check for overflow more carefully. Don't update size
2778 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2779 Don't update size until alloc done.
2780 Redo size calculations to avoid overflow.
2781 Check for size calculation overflow.
2782 (main) [DEBUG]: Fix typo in invoking tparam1.
2784 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2785 Use ptrdiff_t, not int, for sizes.
2786 (store_mode_line_noprop_char): Don't update size until alloc done.
2788 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2789 Use ptrdiff_t, not int, for sizes.
2790 (Finternal_make_lisp_face, cache_face):
2791 Check for size calculation overflow.
2792 (cache_face): Treat size calculation overflows as if they were
2793 memory exhaustion (the usual treatment), rather than aborting.
2795 * xfns.c (x_encode_text, x_set_name_internal)
2796 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2797 sizes, since they can exceed INT_MAX in size. Check for size
2798 calculation overflow.
2800 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2801 (xg_select): Check for size calculation overflow.
2802 Don't update size until alloc done.
2804 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2805 as sprintf is limited to int lengths.
2807 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2808 (X_LONG_MIN): New macros.
2809 Use them to make the following changes clearer.
2810 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2811 This change doesn't affect the value now, but it may help remind
2812 future maintainers not to raise the value too much later.
2813 (SELECTION_QUANTUM): Remove, replacing with ...
2814 (selection_quantum): ... new function, which avoids overflow.
2816 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2817 assumption that selection length fits in 'int'.
2818 (x_reply_selection_request, x_handle_selection_request)
2819 (x_get_window_property, receive_incremental_selection)
2820 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2821 (lisp_data_to_selection_data, clean_local_selection_data):
2822 Use ptrdiff_t, not int, to record length of selection.
2823 (x_reply_selection_request, x_get_window_property)
2824 (receive_incremental_selection, x_property_data_to_lisp):
2825 Redo calculations to avoid overflow.
2826 (x_reply_selection_request): When sending hint, ceiling it at
2827 X_LONG_MAX rather than relying on wraparound overflow to send
2829 (x_get_window_property, receive_incremental_selection)
2830 (lisp_data_to_selection_data, x_property_data_to_lisp):
2831 Check for size-calculation overflow.
2832 (x_get_window_property, receive_incremental_selection)
2833 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2834 Don't store size until memory allocation succeeds.
2835 (x_get_window_property): Plug memory leak on memory exhaustion.
2836 Don't double-block input; malloc is safe here. Don't assume 2**34
2837 - 4 fits in unsigned long. Add an xassert to check
2838 XGetWindowProperty overflow. Be more careful about overflow
2839 calculations, and distinguish size from memory overflow better.
2840 (receive_incremental_selection): When tracing, don't assume
2841 unsigned int is less than INT_MAX.
2842 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2843 harmful) conversions of unsigned short to int.
2844 (lisp_data_to_selection_data): Don't assume that integers
2845 in the range -65535 through -1 fit in an X unsigned short.
2846 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2847 result parameters unless successful. Rely on cons_to_unsigned
2848 to report problems with elements; the old code wasn't right anyway.
2849 (x_check_property_data): Check for int overflow; we cannot use
2850 a wider type due to X limits.
2851 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2853 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2855 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2856 (x_term_init): Check for size calculation overflow.
2857 (x_color_cells): Don't store size until memory allocation succeeds.
2858 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2859 Don't assume alloca size is less than MAX_ALLOCA.
2860 (x_term_init): Don't assume length fits in int (sprintf is limited
2863 Use ptrdiff_t for composition IDs.
2864 * character.c (lisp_string_width):
2865 * composite.c (composition_table_size, n_compositions)
2866 (get_composition_id, composition_gstring_from_id):
2867 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2868 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2869 * window.c (Frecenter):
2870 Use ptrdiff_t, not int, for composition IDs.
2871 * composite.c (get_composition_id): Check for integer overflow.
2872 * composite.h: Adjust prototypes to match the above changes.
2874 Use ptrdiff_t for hash table indexes.
2875 * category.c (hash_get_category_set):
2876 * ccl.c (ccl_driver):
2877 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2878 * coding.c (coding_system_charset_list, detect_coding_system):
2879 * coding.h (struct coding_system.id):
2880 * composite.c (get_composition_id, gstring_lookup_cache):
2881 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2882 * image.c (xpm_get_color_table_h):
2883 * lisp.h (hash_lookup, hash_put):
2884 * minibuf.c (Ftest_completion):
2885 Use ptrdiff_t for hash table indexes, not int (which is too
2886 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2887 32-bit --with-wide-int hosts).
2889 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2890 Add a FIXME comment about memory leaks.
2891 (syms_of_charset): Don't assume xmalloc returns.
2893 Don't assume that stated character widths fit in int.
2894 * character.c (Fchar_width, c_string_width, lisp_string_width):
2895 * character.h (CHAR_WIDTH):
2896 * indent.c (MULTIBYTE_BYTES_WIDTH):
2897 Use sanitize_char_width to avoid undefined and/or bad behavior
2898 with outlandish widths.
2899 * character.h (sanitize_tab_width): Rename from sanitize_width,
2900 now that we have two such functions. All uses changed.
2901 (sanitize_char_width): New inline function.
2903 Don't assume that tab-width fits in int.
2904 * character.h (sanitize_width): New inline function.
2905 (SANE_TAB_WIDTH): New macro.
2906 (ASCII_CHAR_WIDTH): Use it.
2907 * indent.c (sane_tab_width): Remove. All uses replaced by
2908 SANE_TAB_WIDTH (current_buffer).
2909 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2911 * fileio.c: Integer overflow issues with file modes.
2912 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2914 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2915 Remove unreachable code.
2916 (read_hex, load_charset_map_from_file): Check for integer overflow.
2918 * xterm.c: Don't go over XClientMessageEvent limit.
2919 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2920 (x_send_scroll_bar_event): Likewise. Check that the size does not
2921 exceed limits imposed by XClientMessageEvent, as well as the usual
2922 ptrdiff_t and size_t limits.
2924 * keyboard.c: Overflow, signedness and related fixes.
2925 (make_lispy_movement): Use same integer type in forward decl
2926 that is used in the definition.
2927 (read_key_sequence, keyremap_step):
2928 Change bufsize argument back to int, undoing my 2011-03-30 change.
2929 We prefer signed types, and int is wide enough here.
2930 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2931 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2932 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2933 length, not size_t. Use ptrdiff_t for index, not int.
2934 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2935 possibility of integer overflow.
2937 Overflow, signedness and related fixes for images.
2939 * dispextern.h (struct it.stack[0].u.image.image_id)
2940 (struct_it.image_id, struct image.id, struct image_cache.size)
2941 (struct image_cache.used, struct image_cache.ref_count):
2942 * gtkutil.c (update_frame_tool_bar):
2943 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2944 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2945 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2946 * nsmenu.m (update_frame_tool_bar):
2947 * xdisp.c (calc_pixel_width_or_height):
2948 * xfns.c (image_cache_refcount):
2949 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2950 on typical 64-bit hosts.
2952 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2953 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2954 Omit unnecessary casts to int.
2955 (parse_image_spec): Check that integers fall into 'int' range
2956 when the callers expect that.
2957 (image_ascent): Redo ascent calculation to avoid int overflow.
2958 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2959 (lookup_image): Remove unnecessary tests.
2960 (xbm_image_p): Locals are now of int, not EMACS_INT,
2961 since parse_image_check makes sure they fit into int.
2962 (png_load, gif_load, svg_load_image):
2963 Prefer int to unsigned where either will do.
2964 (tiff_handler): New function, combining the cores of the
2965 old tiff_error_handler and tiff_warning_handler.
2966 This function is rewritten to use vsnprintf and thereby avoid
2967 stack buffer overflows. It uses only the features of vsnprintf
2968 that are common to both POSIX and native Microsoft.
2969 (tiff_error_handler, tiff_warning_handler): Use it.
2970 (tiff_load, gif_load, imagemagick_load_image):
2971 Don't assume :index value fits in 'int'.
2972 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2973 (imagemagick_load_image): Check that crop parameters fit into
2974 the integer types that MagickCropImage accepts. Don't assume
2975 Vimagemagick_render_type has a nonnegative value. Don't assume
2976 size_t fits in 'long'.
2977 (gs_load): Use printmax_t to print the widest integers possible.
2978 Check for integer overflow when computing image height and width.
2980 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2982 * xdisp.c (redisplay_window): Don't force window start if point
2983 will be invisible in the resulting window. (Bug#9324)
2985 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2987 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2988 the display spec is of the form `(space ...)'.
2989 (handle_display_spec): Return the value returned by
2990 handle_single_display_spec, not just 1 or zero.
2991 (handle_single_display_spec): If the display spec is of the form
2992 `(space ...)', and specifies display in the text area, return 2
2994 (try_cursor_movement): Check for the need to scroll more
2995 accurately, and prefer exact match for point under bidi.
2996 Don't advance `row' beyond the last row of the window.
2998 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2999 into disp_prop; all users changed.
3001 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3002 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3003 for the text covered by the display property.
3005 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3007 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3008 Change return value to nil.
3009 (Frecord_buffer): Delete unused function.
3011 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3013 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3014 buffers, return left-to-right.
3015 (set_cursor_from_row): Consider candidate row a win if its glyph
3016 represents a newline and point is on that newline. Fixes cursor
3017 positioning on the newline at EOL of R2L text within L2R
3018 paragraph, and vice versa.
3019 (try_cursor_movement): Check continued rows, in addition to
3020 continuation rows. Fixes unwarranted scroll when point enters a
3021 continued line of R2L text within an L2R paragraph, or vice versa.
3022 (cursor_row_p): Consider the case of point being equal to
3023 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3024 from the end of a short line to the beginning of a continued line
3025 of R2L text within L2R paragraph.
3026 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3027 composed characters.
3029 * bidi.c (bidi_check_type): Use xassert.
3030 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3033 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3035 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3038 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3040 * nsfont.m (ns_otf_to_script): Fix typo.
3042 2011-08-22 Kenichi Handa <handa@m17n.org>
3044 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3045 extra slot even if the purpose is char-code-property-table.
3047 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3049 * xdisp.c (redisplay_window): When computing centering_position,
3050 account for the height of the header line. (Bug#8874)
3052 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3053 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3054 candidate is selected by the mouse, and that candidate has a
3055 composed character under the mouse.
3057 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3058 coordinates reported by pos-visible-in-window-p for a composed
3059 character in column zero.
3061 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3063 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3065 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3067 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3068 consider it a hit if to_charpos is anywhere in the range of the
3069 composed buffer positions.
3071 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3073 * image.c (gif_load): Don't assume that each subimage has the same
3074 dimensions as the base image. Handle disposal method that is
3075 "undefined" by the gif spec (Bug#9335).
3077 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3079 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3080 (Fcondition_case): Document `debug' symbol in error handler.
3082 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3084 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3085 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3086 from an Org mode buffer to a Speedbar frame.
3088 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3089 a composition, take its buffer position from IT->cmp_it.charpos.
3090 Fixes cursor positioning at the beginning of a line that begins
3091 with a composed character.
3093 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3095 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3096 character bidirectional type, use STRONG_L instead. Fixes crashes
3097 in a buffer produced by `describe-categories'.
3099 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3100 members before the level stack, so they would be saved and
3101 restored when copying iterator state. Fixes incorrect reordering
3102 around TABs covered by display properties.
3104 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3106 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3108 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3110 * eval.c (internal_condition_case, internal_condition_case_1)
3111 (internal_condition_case_2, internal_condition_case_n):
3112 Remove unnecessary aborts (Bug#9081).
3114 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3116 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3117 has no `load' handler, try opening the file locally. (Bug#9311)
3119 2011-08-16 Ken Brown <kbrown@cornell.edu>
3121 * gmalloc.c: Expand comment.
3123 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3125 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3126 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3128 2011-08-16 Ken Brown <kbrown@cornell.edu>
3130 Fix memory allocation problems in Cygwin build (Bug#9273).
3132 * unexcw.c ( __malloc_initialized): Declare external variable.
3133 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3135 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3137 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3139 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3141 [CYGWIN] (special_realloc): New function.
3142 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3143 requests to realloc storage in the static heap.
3145 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3147 * bidi.c (bidi_initialize): Remove unused local.
3149 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3152 * biditype.h: Remove file.
3153 * makefile.w32-in ($(BLD)/bidi.$(O)):
3154 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3156 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3158 * chartab.c: Improve commentary for the uniprop_table API.
3160 * bidi.c (bidi_paragraph_init): Support zero value of
3161 bidi_ignore_explicit_marks_for_paragraph_level.
3162 (bidi_initialize): Use uniprop_table instead of including
3163 biditype.h and bidimirror.h.
3165 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3166 coordinates of the iterator when restoring from ppos_it.
3169 2011-08-14 Kenichi Handa <handa@m17n.org>
3171 * process.c (create_process): Call setup_process_coding_systems
3172 after the pid of the process is set to -1 (Bug#8162).
3174 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3176 * xdisp.c (move_it_in_display_line_to): Don't invoke
3177 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3178 ppos_it. Fixes vertical cursor motion when line beginning is
3179 covered by an image. (Bug#9296)
3181 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3183 * nsterm.h (ns_run_ascript): Declare.
3184 (NSAPP_DATA2_RUNASSCRIPT): Define.
3186 * nsfns.m (as_script, as_result, as_status): New static variables.
3187 (ns_run_ascript): New function.
3188 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3189 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3190 the event loop. Get status from as_status (Bug#7276).
3192 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3193 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3194 the event loop (Bug#7276).
3196 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3198 * gnutls.c (QCgnutls_bootprop_priority)
3199 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3200 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3201 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3202 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3203 (QCgnutls_bootprop_verify_hostname_error)
3204 (QCgnutls_bootprop_callbacks_verify): Rename from
3205 Qgnutls_bootprop_..., all uses changed.
3207 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3210 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3212 * xfaces.c (Qframe_set_background_mode): Now static.
3213 * dispextern.h (Qframe_set_background_mode): Remove decl.
3215 * process.c (Fnetwork_interface_info): Declare local only if needed.
3217 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3219 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3220 (Fnetwork_interface_list): Allocate in increments of bytes instead
3221 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3222 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3224 (struct ifflag_def): notrailers is smart on OSX.
3225 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3226 Get hardware address with getifaddrs if available.
3228 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3230 * xdisp.c (iterate_out_of_display_property): xassert that
3231 IT->position is set to within IT->object's boundaries. Break from
3232 the loop as soon as EOB is reached; avoids infloops in redisplay
3233 when IT->position is set up wrongly due to some bug.
3234 Set IT->current to match the bidi iterator unconditionally.
3235 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3236 entry. Force push_it to save on the stack the current
3237 buffer/string position, to be restored by pop_it. Fix flags in
3238 the iterator structure wrt the object coming from a display
3239 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3240 properties. (Bug#9284)
3242 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3244 * fontset.c (fontset_get_font_group): Add proper type checks.
3247 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3249 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3250 and LC_VERSION_MIN_MACOSX.
3251 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3252 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3254 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3256 * xdisp.c (forward_to_next_line_start): Allow to use the
3257 no-display-properties-and-no-overlays under bidi display.
3258 Set disp_pos in the bidi iterator to avoid searches for display
3259 properties and overlays.
3261 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3263 * editfns.c (Fset_time_zone_rule): Document relationship with the
3266 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3267 the font entity extracted from the cache (Bug#8109).
3269 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3271 * composite.c (autocmp_chars): Don't reset point. That is done by
3272 restore_point_unwind (Bug#5984).
3274 2011-08-07 Juri Linkov <juri@jurta.org>
3276 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3277 to show the arg `TIME' instead of `TIMEVAL'.
3279 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3281 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3282 display property strides EOL and includes a newline, as in
3283 longlines-mode. (Bug#9254)
3284 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3285 word-wrap under bidirectional display. (Bug#9224)
3287 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3288 is non-zero, even if the data buffer is NULL. Fixes a crash in
3289 vertical-motion with longlines-mode. (Bug#9254)
3291 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3293 * bidi.c <bidi_cache_total_alloc>: Now static.
3294 (bidi_initialize): Initialize bidi_cache_total_alloc.
3296 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3299 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3300 amount allocated this far in `bidi_cache_total_alloc'.
3301 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3302 non-zero, only free the data buffer without restoring the cache
3303 contents. All callers changed.
3305 * dispextern.h (bidi_unshelve_cache): Update prototype.
3307 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3308 (move_it_in_display_line, move_it_to)
3309 (move_it_vertically_backward, move_it_by_lines): Replace the call
3310 to xfree to an equivalent call to bidi_unshelve_cache.
3311 (move_it_in_display_line_to): Fix logic of returning
3312 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3314 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3316 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3317 came from a string character with a `cursor' property. (Bug#9229)
3319 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3321 * Makefile.in (LIB_PTHREAD): New variable.
3322 (LIBES): Add LIB_PTHREAD (Bug#9216).
3324 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3325 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3327 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3329 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3331 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3333 * xterm.c (x_find_topmost_parent): New function.
3334 (x_set_frame_alpha): Find topmost parent window with
3335 x_find_topmost_parent and set the property there also (bug#9181).
3336 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3338 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3340 * callproc.c (Fcall_process): Avoid vfork clobbering
3341 the local vars buffer, coding_systems, current_dir.
3343 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3345 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3347 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3349 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3350 so that it is not optimized away.
3352 * xdisp.c (compute_display_string_pos): Remove unused local.
3354 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3356 Fix slow cursor motion and scrolling in large buffers with
3357 selective display, like Org Mode buffers. (Bug#9218)
3359 * dispextern.h (struct bidi_it): New member disp_prop_p.
3361 * xdisp.c: Remove one-slot cache of display string positions.
3362 (compute_display_string_pos): Accept an additional argument
3363 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3364 for a display string or property. If found, set DISP_PROP_P
3367 * bidi.c (bidi_fetch_char): Accept an additional argument
3368 DISP_PROP_P, and pass it to compute_display_string_pos.
3369 Only handle text covered by a display string if DISP_PROP_P is returned
3370 non-zero. All callers of bidi_fetch_char changed.
3372 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3374 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3376 2010-12-03 Don March <don@ohspite.net>
3378 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3379 last character M-[char] is translated to ESC [char] (bug#7541).
3381 2011-08-02 Kenichi Handa <handa@m17n.org>
3383 * lisp.h (uniprop_table): Extern it.
3385 * chartab.c (uniprop_table): Make it non-static.
3387 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3389 * xdisp.c (forward_to_next_line_start): Accept additional argument
3390 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3392 (reseat_at_next_visible_line_start): Use the bidi iterator state
3393 returned by forward_to_next_line_start to restore the state of
3394 it->bidi_it after backing up to previous newline. (Bug#9212)
3396 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3398 * regex.c (re_comp): Protoize.
3399 (re_exec): Fix return type.
3400 (regexec): Fix type of `ret'. (Bug#9203)
3402 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3404 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3405 This is needed if max-image-size is a floating-point number.
3407 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3409 * print.c (print_object): Print empty symbol as ##.
3411 * lread.c (read1): Read ## as empty symbol.
3413 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3415 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3416 setting frame foreground color (Bug#9175).
3417 (x_set_background_color): Likewise.
3419 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3420 contents (Bug#9176).
3421 (EmacsTooltip -init): Remove bezels and add shadows to
3424 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3425 or scroll bar (Bug#8470).
3427 * nsfont.m (nsfont_open): Remove assignment to voffset and
3428 unnecessary vars hshink, expand, hd, full_height, min_height.
3429 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3431 * nsterm.h (nsfont_info): Remove voffset field.
3433 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3435 Implement strike-through and overline on NextStep (Bug#8863).
3437 * nsfont.m (nsfont_open): Use underline position provided by font,
3438 instead of hard-coded value of 2.
3439 (nsfont_draw): Call ns_draw_text_decoration instead.
3441 * nsterm.h: Add declaration for ns_draw_text_decoration.
3443 * nsterm.m (ns_draw_text_decoration): New function for drawing
3444 underline, overline, and strike-through.
3445 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3446 ns_draw_text_decoration. Change treatment of cursor drawing to
3447 accommodate underlining, etc.
3449 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3451 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3454 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3456 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3457 Without this fix, if a signal arrives just after memory fills up,
3458 'malloc' might be invoked reentrantly.
3460 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3461 In other words, assume that every image size is allowed, on non-X
3462 hosts. This assumption is probably wrong, but it lets Emacs compile.
3464 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3466 * regex.c (re_iswctype): Convert return values to boolean.
3468 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3470 * xdisp.c (compute_display_string_pos): Don't use cached display
3471 string position if the buffer had its restriction changed.
3474 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3476 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3478 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3480 Integer signedness and overflow and related fixes. (Bug#9079)
3482 * bidi.c: Integer size and overflow fixes.
3483 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3484 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3485 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3486 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3487 (bidi_find_other_level_edge):
3488 Use ptrdiff_t instead of EMACS_INT where either will do.
3489 This works better on 32-bit hosts configured --with-wide-int.
3490 (bidi_cache_ensure_space): Check for size-calculation overflow.
3491 Use % rather than repeated addition, for better worst-case speed.
3492 Don't set bidi_cache_size until after xrealloc returns, because it
3494 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3495 (bidi_cache_ensure_space): Also check that the bidi cache size
3496 does not exceed that of the largest Lisp string or buffer. See Eli
3497 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3499 * alloc.c (__malloc_size_t): Remove.
3500 All uses replaced by size_t. See Andreas Schwab's note
3501 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3503 * image.c: Improve checking for integer overflow.
3504 (check_image_size): Assume that f is nonnull, since
3505 it is always nonnull in practice. This is one less thing to
3506 worry about when checking for integer overflow later.
3507 (x_check_image_size): New function, which checks for integer
3508 overflow issues inside X.
3509 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3510 This removes the need for a memory_full check.
3511 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3512 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3513 (xbm_read_bitmap_data): Change locals back to 'int', since
3514 their values must fit in 'int'.
3515 (xpm_load_image, png_load, tiff_load):
3516 Invoke x_create_x_image_and_pixmap earlier,
3517 to avoid much needless work if the image is too large.
3518 (tiff_load): Treat overly large images as if
3519 x_create_x_image_and_pixmap failed, not as malloc failures.
3520 (gs_load): Use x_check_image_size.
3522 * gtkutil.c: Omit integer casts.
3523 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3524 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3526 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3528 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3529 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3530 would wrongly return t on a 64-bit host.
3532 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3533 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3534 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3535 and therefore cause GCC to emit a bogus diagnostic in some cases.
3537 * image.c: Integer signedness and overflow and related fixes.
3538 This is not an exhaustive set of fixes, but it's time to
3539 record what I've got.
3540 (lookup_pixel_color, check_image_size): Remove redundant decls.
3541 (check_image_size): Don't assume that arbitrary EMACS_INT values
3542 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3543 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3544 (tiff_load, imagemagick_load_image):
3545 Check for overflow in size calculations.
3546 (x_create_x_image_and_pixmap): Remove unnecessary test for
3547 xmalloc returning NULL; that can't happen.
3548 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3549 (xpm_color_bucket): Use better integer hashing function.
3550 (xpm_cache_color): Don't possibly over-allocate memory.
3551 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3552 (gif_memory_source):
3553 Use ptrdiff_t, not int or size_t, to record sizes.
3554 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3555 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3556 either works, as we prefer signed integers.
3557 (tiff_read_from_memory, tiff_write_from_memory):
3558 Return tsize_t, not size_t, since that's what the TIFF API wants.
3559 (tiff_read_from_memory): Don't fail simply because the read would
3560 go past EOF; instead, return a short read.
3561 (tiff_load): Omit no-longer-needed casts.
3562 (Fimagemagick_types): Don't assume size fits into 'int'.
3564 Improve hashing quality when configured --with-wide-int.
3565 * fns.c (hash_string): New function, taken from sxhash_string.
3566 Do not discard information about ASCII character case; this
3567 discarding is no longer needed.
3568 (sxhash-string): Use it. Change sig to match it. Caller changed.
3569 * lisp.h: Declare it.
3570 * lread.c (hash_string): Remove, since we now use fns.c's version.
3571 The fns.c version returns a wider integer if --with-wide-int is
3572 specified, so this should help the quality of the hashing a bit.
3574 * emacs.c: Integer overflow minor fix.
3575 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3576 Define only if GNU_LINUX.
3577 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3579 * dispnew.c: Integer signedness and overflow fixes.
3580 Remove unnecessary forward decls, that were a maintenance hassle.
3581 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3583 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3584 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3585 (prepare_desired_row, line_draw_cost):
3586 Use int, not unsigned, where either works.
3587 (save_current_matrix, restore_current_matrix):
3588 Use ptrdiff_t, not size_t, where either works.
3589 (init_display): Check for overflow more accurately, and without
3590 relying on undefined behavior.
3592 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3593 Remove, replacing with the new symbols in lisp.h. All uses changed.
3594 * fileio.c (make_temp_name):
3595 * filelock.c (lock_file_1, lock_file):
3596 * xdisp.c (message_dolog):
3597 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3598 Use pMd etc. instead.
3599 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3600 replacing the pWIDE etc. symbols removed from editfns.c.
3602 * keyboard.h (num_input_events): Now uintmax_t.
3603 This is (very slightly) less likely to mess up due to wraparound.
3606 * buffer.c: Integer signedness fixes.
3607 (alloc_buffer_text, enlarge_buffer_text):
3608 Use ptrdiff_t rather than size_t when either will do, as we prefer
3611 * alloc.c: Integer signedness and overflow fixes.
3612 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3613 (__malloc_size_t): Default to size_t, not to int.
3614 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3615 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3616 Prefer ptrdiff_t to size_t when either would do, as we prefer
3618 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3619 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3620 Now const. Initialize with values that are in range even if char
3622 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3623 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3624 These functions do the right thing with sizes > 2**32.
3625 (check_depth): Now ptrdiff_t, not int.
3626 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3627 Adjust to new way of storing sizes. Check for size overflow bugs
3629 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3630 slightly wrong anyway, as it missed one instance of
3631 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3632 (refill_memory_reserve): Omit needless cast to size_t.
3633 (mark_object_loop_halt): Mark as externally visible.
3635 * xselect.c: Integer signedness and overflow fixes.
3636 (Fx_register_dnd_atom, x_handle_dnd_message):
3637 Use ptrdiff_t, not size_t, since we prefer signed.
3638 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3639 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3640 x_dnd_atoms_size and x_dnd_atoms_length.
3642 * doprnt.c: Prefer signed to unsigned when either works.
3644 * doprnt.c (doprnt):
3646 * xdisp.c (vmessage):
3647 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3648 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3649 prefer signed arithmetic to avoid comparison confusion.
3650 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3651 but is a bit tricky.
3653 Assume freestanding C89 headers, string.h, stdlib.h.
3654 * data.c, doprnt.c, floatfns.c, print.c:
3655 Include float.h unconditionally.
3656 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3657 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3658 * regex.c: Likewise for stddef.h, string.h.
3659 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3660 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3661 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3662 (STDC_HEADERS): Remove obsolete defines.
3663 * sysdep.c: Include limits.h unconditionally.
3665 Assume support for memcmp, memcpy, memmove, memset.
3666 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3667 * regex.c (memcmp, memcpy):
3668 Remove; we assume C89 now.
3670 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3671 (__malloc_safe_bcopy): Remove; no longer needed.
3673 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3674 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3675 well either way, and we prefer signed to unsigned.
3677 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3679 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3680 closes the connection while we're reading (bug#9182).
3682 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3684 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3685 are specified (Bug#9168).
3687 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3689 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3690 Found by GCC static checking and --with-wide-int on a 32-bit host.
3692 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3694 * xdisp.c (compute_display_string_pos): Fix logic of caching
3695 previous display string position. Initialize cached_prev_pos to
3696 -1. Fixes slow-down at the beginning of a buffer.
3698 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3700 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3701 for attrs[LFACE_FONTSET_INDEX].
3703 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3705 * xml.c (parse_region): Remove unused local
3706 that was recently introduced.
3708 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3710 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3711 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3713 * xdisp.c (move_it_in_display_line_to): Record the best matching
3714 position for TO_CHARPOS while scanning the line, and restore it on
3715 exit if none of the characters scanned was an exact match.
3716 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3717 when exact match is impossible due to invisible text, and the
3718 lines are truncated.
3720 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3722 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3725 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3727 Fix a significant slow-down of cursor motion with C-n, C-p,
3728 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3729 auto-repeat under bidi redisplay in fontified buffers.
3730 * xdisp.c (compute_stop_pos_backwards): New function.
3731 (next_element_from_buffer): Call compute_stop_pos_backwards to
3732 find a suitable prev_stop when we find ourselves before
3734 (reseat): Don't look for prev_stop, as that could mean a very long
3736 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3737 <cached_disp_overlay_modiff>: Cache for last found display string
3739 (compute_display_string_pos): Return the cached position if asked
3740 about the same buffer in the same area of character positions, and
3741 the buffer wasn't changed since the time the display string
3742 position was cached.
3744 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3746 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3747 is an integer, which is important for empty lines. (Bug#9149)
3749 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3751 * frame.c (Fmodify_frame_parameters): In tty case, update the
3752 default face if necessary (Bug#4238).
3754 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3756 * editfns.c (Fstring_to_char): No need to explain what a character
3757 is in the docstring (Bug#6576).
3759 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3761 * xml.c (parse_region): Make sure we always return a tree.
3763 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3765 * xml.c (parse_region): If a document contains only comments,
3768 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3770 * xml.c (make_dom): Return comments, too.
3772 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3775 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3776 and the surrounding thread.
3777 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3778 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3779 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3781 * s/openbsd.h (BROKEN_SIGIO): Define.
3782 * unexelf.c (unexec) [__OpenBSD__]:
3783 Don't update the .mdebug section of the Alpha COFF symbol table.
3785 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3787 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3790 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3792 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3793 This fixes some race conditions on the permissions of any newly
3796 * alloc.c (valid_pointer_p): Use pipe, not open.
3797 This fixes some permissions issues when debugging.
3799 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3800 If fchown fails to set both uid and gid, try to set just gid,
3801 as that is sometimes allowed. Adjust the file's mode to eliminate
3802 setuid or setgid bits that are inappropriate if fchown fails.
3804 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3806 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3807 to compare Lisp_Objects.
3808 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3809 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3810 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3812 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3814 * lread.c (read_integer): Unread even EOF character.
3815 (read1): Likewise. Properly record start position of symbol.
3817 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3818 symbol character follows.
3820 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3822 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3823 This works around a problem with the previous change to Fcopy_file.
3824 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3825 and without this change, GCC might complain about discarding
3826 fchown's return value.
3828 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3830 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3832 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3834 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3836 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3838 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3839 it's used from the C level.
3841 * process.c: Use the same condition for POLL_FOR_INPUT in both
3842 keyboard.c and process.c (bug#1858).
3844 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3846 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3847 (Fgnutls_boot): Use it.
3849 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3851 * doc.c (Fsubstitute_command_keys): Revert last change.
3853 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3855 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3856 quotes the next character, and doesn't affect other longer
3857 sequences (bug#8935).
3859 * lread.c (syms_of_lread): Clarify that is isn't only
3860 `eval-buffer' and `eval-defun' that's affected by
3861 `lexical-binding' (bug#8460).
3863 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3865 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3866 bidi redisplay when a line includes both an image and is truncated.
3868 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3870 Fix minor problems found by static checking.
3871 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3872 (elsz): Now a signed constant, not a size_t var. We prefer signed
3873 types to unsigned, to avoid integer comparison confusion. Without
3874 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3875 "cannot optimize loop, the loop counter may overflow", a symptom
3877 * indent.c (Fvertical_motion): Mark locals as initialized.
3878 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3880 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3882 * search.c (Fre_search_backward): Mention `case-fold-search' in
3883 all the re_search_* functions (bug#8138).
3885 * keyboard.c (Fopen_dribble_file): Document when the file is
3888 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3890 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3893 Support bidi reordering of display and overlay strings.
3894 * xdisp.c (compute_display_string_pos)
3895 (compute_display_string_end): Accept additional argument STRING.
3896 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3897 (reseat_to_string): Initialize bidi_it->string.s and
3898 bidi_it->string.schars.
3899 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3900 NULL (avoids a crash in bidi_paragraph_init).
3901 Initialize itb.string.lstring.
3902 (init_iterator): Call bidi_init_it only of a valid
3903 buffer position was specified. Initialize paragraph_embedding to
3905 (reseat_to_string): Initialize the bidi iterator.
3906 (display_string): If we need to ignore text properties of
3907 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3908 original value of -1 will not work with bidi.)
3909 (compute_display_string_pos): First arg is now struct
3910 `text_pos *'; all callers changed. Support display properties on
3912 (compute_display_string_end): Support display properties on Lisp
3914 (init_iterator, reseat_1, reseat_to_string): Initialize the
3915 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3916 when iterating on a string not from display properties).
3917 (compute_display_string_pos, compute_display_string_end):
3918 Fix calculation of the object to scan. Fixes an error when using
3920 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3921 base_level_stop; instead, set base_level_stop to BEGV.
3922 Fixes crashes in vertical-motion.
3923 (next_element_from_buffer): Improve commentary for when
3924 the iterator is before prev_stop.
3925 (init_iterator): Initialize bidi_p from the default value of
3926 bidi-display-reordering, not from buffer-local value. Use the
3927 buffer-local value only if initializing for buffer iteration.
3928 (handle_invisible_prop): Support invisible properties on strings
3929 that are being bidi-reordered.
3930 (set_iterator_to_next): Support bidi reordering of C strings and
3932 (next_element_from_string): Support bidi reordering of Lisp
3934 (handle_stop_backwards): Support Lisp strings as well.
3935 (display_string): Support display of R2L glyph rows.
3936 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3937 (init_iterator): Don't initialize it->bidi_p for strings
3939 (reseat_to_string): Initialize it->bidi_p for strings here.
3940 (next_element_from_string, next_element_from_c_string)
3941 (next_element_from_buffer): Add xassert's for correspondence
3942 between IT's object being iterated and it->bidi_it.string
3944 (face_before_or_after_it_pos): Support bidi iteration.
3945 (next_element_from_c_string): Handle the case of the first string
3946 character that is not the first one in the visual order.
3947 (get_visually_first_element): New function, refactored from common
3948 parts of next_element_from_buffer, next_element_from_string, and
3949 next_element_from_c_string.
3950 (tool_bar_lines_needed, redisplay_tool_bar)
3951 (display_menu_bar): Force left-to-right direction. Add a FIXME
3952 comment for making that be controlled by a user option.
3953 (push_it, pop_it): Save and restore the state of the
3954 bidi iterator. Save and restore the bidi_p flag.
3955 (pop_it): Iterate out of display property for string iteration as
3957 (iterate_out_of_display_property): Support iteration over strings.
3958 (handle_single_display_spec): Set up it->bidi_it for iteration
3959 over a display string, and call bidi_init_it.
3960 (handle_single_display_spec, next_overlay_string)
3961 (get_overlay_strings_1, push_display_prop): Set up the bidi
3962 iterator for displaying display or overlay strings.
3963 (forward_to_next_line_start): Don't use the shortcut if
3965 (back_to_previous_visible_line_start): If handle_display_prop
3966 pushed the iterator stack, restore the internal state of the bidi
3967 iterator by calling bidi_pop_it same number of times.
3968 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3969 and we are bidi-iterating, don't decrement the iterator position;
3970 instead, set the first_elt flag in the bidi iterator, to produce
3972 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3973 (push_display_prop): xassert that we are iterating a buffer.
3974 (push_it, pop_it): Save and restore paragraph_embedding member.
3975 (handle_single_display_spec, next_overlay_string)
3976 (get_overlay_strings_1, reseat_1, reseat_to_string)
3977 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3978 correctly. Don't assume unibyte strings are not bidi-reordered.
3979 (compute_display_string_pos)
3980 (compute_display_string_end): Fix handling the case of C string.
3981 (push_it, pop_it): Save and restore from_disp_prop_p.
3982 (handle_single_display_spec, push_display_prop): Set the
3983 from_disp_prop_p flag.
3984 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3985 (pop_it): Call iterate_out_of_display_property only if we are
3986 popping after iteration over a string that came from a display
3987 property. Fix a typo in popping stretch info. Add an assertion
3988 for verifying that the iterator position is in sync with the bidi
3990 (handle_single_display_spec, get_overlay_strings_1)
3991 (push_display_prop): Fix initialization of paragraph direction for
3992 string when that of the parent object is not yet determined.
3993 (reseat_1): Call bidi_init_it to resync the bidi
3994 iterator with IT's position. (Bug#7616)
3995 (find_row_edges): If ROW->start.pos gives position
3996 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3997 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3998 Reset the from_disp_prop_p flag.
3999 (SAVE_IT, RESTORE_IT): New macros.
4000 (pos_visible_p, face_before_or_after_it_pos)
4001 (back_to_previous_visible_line_start)
4002 (move_it_in_display_line_to, move_it_in_display_line)
4003 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4004 (try_scrolling, redisplay_window, display_line): Use them when
4005 saving a temporary copy of the iterator and restoring it back.
4006 (back_to_previous_visible_line_start, reseat_1)
4007 (init_iterator): Empty the bidi cache "stack".
4008 (move_it_in_display_line_to): If iterator ended up at
4009 EOL, but we never saw any buffer positions smaller than
4010 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4011 motion in bidi-reordered lines.
4012 (move_it_in_display_line_to): Record prev_method and prev_pos
4013 immediately before the call to set_iterator_to_next. Fixes cursor
4014 motion in bidi-reordered lines with stretch glyphs and strings
4015 displayed in margins. (Bug#8133) (Bug#8867)
4016 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4018 (pos_visible_p): Support positions in bidi-reordered lines.
4019 Save and restore bidi cache.
4021 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4022 (bidi_paragraph_info): Delete unused struct.
4023 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4024 (bidi_cache_start): New variable.
4025 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4027 (bidi_cache_fetch_state, bidi_cache_search)
4028 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4029 (bidi_cache_find, bidi_peek_at_next_level)
4030 (bidi_level_of_next_char, bidi_find_other_level_edge)
4031 (bidi_move_to_visually_next): Compare cache index with
4032 bidi_cache_start rather than with zero.
4033 (bidi_fetch_char): Accept new argument STRING; all callers
4034 changed. Support iteration over a string. Support strings with
4035 display properties. Support unibyte strings. Fix the type of
4036 `len' according to what STRING_CHAR_AND_LENGTH expects.
4037 (bidi_paragraph_init, bidi_resolve_explicit_1)
4038 (bidi_resolve_explicit, bidi_resolve_weak)
4039 (bidi_level_of_next_char, bidi_move_to_visually_next):
4040 Support iteration over a string.
4041 (bidi_set_sor_type, bidi_resolve_explicit_1)
4042 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4043 can now be zero (for strings); special values 0 and -1 were
4044 changed to -1 and -2, respectively.
4045 (bidi_char_at_pos): New function.
4046 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4047 Call it instead of FETCH_MULTIBYTE_CHAR.
4048 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4049 initialized to valid values.
4050 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4052 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4053 the test for valid cached positions. Fix the logic for looking up
4054 the sentinel state in the cache. GCPRO the Lisp string we are
4056 (bidi_push_it, bidi_pop_it): New functions.
4057 (bidi_initialize): Initialize the bidi cache start stack pointer.
4058 (bidi_cache_ensure_space): New function, refactored from part of
4059 bidi_cache_iterator_state. Don't assume the required size is just
4060 one BIDI_CACHE_CHUNK away.
4061 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4062 (bidi_count_bytes, bidi_char_at_pos): New functions.
4063 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4064 always valid if bidi_cache_idx is valid.
4065 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4066 is valid if it's going to be used.
4067 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4068 (bidi_cache_fetch_state, bidi_cache_search)
4069 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4070 (bidi_cache_iterator_state, bidi_cache_find)
4071 (bidi_find_other_level_edge, bidi_cache_start_stack):
4072 All variables related to cache indices are now EMACS_INT.
4074 * dispextern.h (struct bidi_string_data): New structure.
4075 (struct bidi_it): New member `string'. Make flag members be 1-bit
4076 fields, and put them last in the struct.
4077 (compute_display_string_pos, compute_display_string_end):
4079 (bidi_push_it, bidi_pop_it): Add prototypes.
4080 (struct iterator_stack_entry): New members bidi_p,
4081 paragraph_embedding, and from_disp_prop_p.
4082 (struct it): Member bidi_p is now a bit field 1 bit wide.
4083 (bidi_shelve_cache, bidi_unshelve_cache):
4086 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4087 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4088 and vector-like objects.
4090 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4091 cache around display iteration.
4093 * window.c (Fwindow_end, window_scroll_pixel_based)
4094 (displayed_window_lines, Frecenter): Save and restore the bidi
4095 cache around display iteration.
4097 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4099 * editfns.c (Fdelete_region): Clarify the use of the named
4100 parameters (bug#6788).
4102 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4104 * indent.c (Fvertical_motion): Set and restore w->pointm when
4105 saving and restoring the window's buffer (Bug#9006).
4107 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4109 * editfns.c (Fstring_to_char): Clarify just what is returned
4110 (bug#6576). Text by Eli Zaretskii.
4112 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4114 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4116 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4118 * buffer.c (mmap_find): Fix a typo.
4120 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4122 Fix execution of x selection hooks.
4123 * xselect.c (Qx_lost_selection_functions)
4124 (Qx_sent_selection_functions): New vars.
4125 (syms_of_xselect): DEFSYM them.
4126 (x_handle_selection_request): Pass Qx_sent_selection_functions
4127 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4128 (x_handle_selection_clear,x_clear_frame_selections):
4129 Pass Qx_lost_selection_functions rather than
4130 Vx_lost_selection_functions to Frun_hook_with_args.
4132 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4134 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4135 The old code sometimes used this field without initializing it.
4137 * alloc.c (gc_sweep): Don't read past end of array.
4138 In theory, the old code could also have corrupted Emacs internals,
4139 though it'd be very unlikely.
4141 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4143 * character.c (Fcharacterp): Don't advertise optional ignored
4144 argument. (Bug#4026)
4146 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4148 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4151 * window.c (Fset_window_start): Doc fix (bug#4199).
4152 (Fset_window_hscroll): Ditto.
4154 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4156 Fix minor new problems caught by GCC 4.6.1.
4157 * term.c (init_tty): Remove unused local.
4158 * xsettings.c (store_monospaced_changed): Define this function only
4159 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4162 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4164 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4166 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4168 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4169 are the mini-buffer and the echo area (bug#3320).
4171 * term.c (init_tty): Remove support for supdup, c10 and perq
4172 terminals, which are no longer supported (bug#1482).
4174 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4176 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4178 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4180 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4181 for non-popups (Bug#3642).
4183 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4185 * alloc.c (reset_malloc_hooks): Protoize.
4186 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4187 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4188 * cm.c (losecursor): Likewise.
4189 * data.c (fmod): Likewise.
4190 * dispnew.c (swap_glyphs_in_rows): Likewise.
4191 * emacs.c (memory_warning_signal): Likewise.
4192 * floatfns.c (float_error): Likewise.
4193 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4194 (otf_open, font_otf_capability, generate_otf_features)
4195 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4197 * image.c (pbm_read_file): Likewise.
4198 * indent.c (string_display_width): Likewise.
4199 * intervals.c (check_for_interval, search_for_interval)
4200 (inc_interval_count, count_intervals, root_interval)
4201 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4202 * lread.c (defalias): Likewise.
4203 * ralloc.c (r_alloc_check): Likewise.
4204 * regex.c (set_image_of_range_1, set_image_of_range)
4205 (regex_grow_registers): Likewise.
4206 * sysdep.c (strerror): Likewise.
4207 * termcap.c (valid_filename_p, tprint, main): Likewise.
4208 * tparam.c (main): Likewise.
4209 * unexhp9k800.c (run_time_remap, save_data_space)
4210 (update_file_ptrs, read_header, write_header, calculate_checksum)
4211 (copy_file, copy_rest, display_header): Likewise.
4212 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4214 * xdisp.c (check_it): Likewise.
4215 * xfaces.c (register_color, unregister_color, unregister_colors):
4217 * xfns.c (print_fontset_result): Likewise.
4218 * xrdb.c (member, fatal, main): Likewise.
4220 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4222 Fix minor problems found by static checking (Bug#9031).
4223 * chartab.c (char_table_set_range, map_sub_char_table):
4224 Remove unused locals.
4225 (uniprop_table): Now static.
4226 * composite.c (_work_char): Remove unused static var.
4228 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4230 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4232 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4234 * gtkutil.c (qttip_cb): Remove code without function.
4236 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4238 * w32.c (pthread_sigmask): New stub.
4240 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4242 Use pthread_sigmask, not sigprocmask (Bug#9010).
4243 sigprocmask is portable only for single-threaded applications, and
4244 Emacs can be multi-threaded when it uses GTK.
4245 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4247 * callproc.c (Fcall_process):
4248 * process.c (create_process):
4249 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4250 Use pthread_sigmask, not sigprocmask.
4252 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4254 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4255 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4258 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4260 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4261 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4262 (xg_hide_tooltip): Fix comment.
4264 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4265 in registerServicesMenuSendTypes.
4266 (validRequestorForSendType): Don't check ns_return_types.
4268 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4271 2011-07-08 Jason Rumney <jasonr@gnu.org>
4273 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4274 SH_SHOW for hidden windows (Bug#5482).
4276 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4277 frame struct members of non-existent frames (Bug#6284).
4279 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4281 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4282 variable firstTime not needed on OSX >= 10.6.
4283 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4284 >= 10.5. Use setKnobProportion, setDoubleValue.
4286 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4287 (MAC_OS_X_VERSION_10_5): Define if not defined.
4288 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4289 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4290 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4292 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4293 cString and lossyCString on OSX >= 10.4
4295 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4296 sizeToFit on OSX >= 10.2.
4298 * nsimage.m (allocInitFromFile): Don't use deprecated method
4299 bestRepresentationForDevice on OSX >= 10.6.
4301 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4304 * emacs.c: Declare unexec_init_emacs_zone.
4306 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4308 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4310 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4311 on svcsMenu (Bug#8842).
4313 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4315 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4317 * nsterm.m (QUTF8_STRING): Declare.
4318 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4319 (validRequestorForSendType): Return type is (id).
4320 Change indexOfObjectIdenticalTo to indexOfObject.
4321 Check if we have local selection before returning self (Bug#8842).
4322 (writeSelectionToPasteboard): Put local selection into paste board
4323 if we have a local selection (Bug#8842).
4324 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4326 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4327 (ns_get_local_selection): Declare.
4329 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4331 * keymap.c (describe_map_tree): Don't insert a double newline at
4332 the end of the buffer (bug#1169) and return whether we inserted
4335 * callint.c (Fcall_interactively): Change "reading args" to
4336 "providing args" to try to clarify what it does (bug#1010).
4338 2011-07-07 Kenichi Handa <handa@m17n.org>
4340 * composite.c (composition_compute_stop_pos): Ignore a static
4341 composition starting before CHARPOS (Bug#8915).
4343 * xdisp.c (handle_composition_prop): Likewise.
4345 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4347 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4350 2011-07-07 Kenichi Handa <handa@m17n.org>
4352 * character.h (unicode_category_t): New enum type.
4354 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4355 (Qchar_code_property_table): New variable.
4356 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4357 (UNIPROP_COMPRESSED_FORM_P): New macros.
4358 (char_table_ascii): Uncompress the compressed values.
4359 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4360 Uncompress the compressed values.
4361 (sub_char_table_ref_and_range): Likewise.
4362 (char_table_ref_and_range): Uncompress the compressed values.
4363 (sub_char_table_set): New arg is_uniprop. Callers changed.
4364 Uncompress the compressed values.
4365 (sub_char_table_set_range): Args changed. Callers changed.
4366 (char_table_set_range): Adjuted for the above change.
4367 (map_sub_char_table): Delete args default_val and parent. Add arg
4368 top. Give decoded values to a Lisp function.
4369 (map_char_table): Adjust for the above change. Give decoded
4370 values to a Lisp function. Gcpro more variables.
4371 (uniprop_table_uncompress)
4372 (uniprop_decode_value_run_length): New functions.
4373 (uniprop_decoder, uniprop_decoder_count): New variables.
4374 (uniprop_get_decoder, uniprop_encode_value_character)
4375 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4377 (uniprop_encoder, uniprop_encoder_count): New variables.
4378 (uniprop_get_encoder, uniprop_table)
4379 (Funicode_property_table_internal, Fget_unicode_property_internal)
4380 (Fput_unicode_property_internal): New functions.
4381 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4382 Sunicode_property_table_internal, Sget_unicode_property_internal,
4383 and Sput_unicode_property_internal. Defvar_lisp
4384 char-code-property-alist.
4386 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4387 Vunicode_category_table.
4389 * font.c (font_range): Adjust for the change of
4390 Vunicode_category_table.
4392 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4394 * m/iris4d.h: Remove file, move contents ...
4395 * s/irix6-5.h: ... here.
4397 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4399 Remove unportable assumption about struct layout (Bug#8884).
4400 * alloc.c (mark_buffer):
4401 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4402 (clone_per_buffer_values): Don't assume that
4403 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4404 This isn't true in general, and it's particularly not true
4405 if Emacs is configured with --with-wide-int.
4406 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4407 New macros, used in the buffer.c change.
4409 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4411 * xsettings.c: Use both GConf and GSettings if both are available.
4412 (store_config_changed_event): Add comment.
4413 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4414 (store_tool_bar_style_changed): New functions.
4415 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4416 (struct xsettings): Move font inside HAVE_XFT.
4417 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4418 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4419 Move inside HAVE_XFT.
4420 (something_changed_gsettingsCB): Rename from something_changedCB.
4421 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4423 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4424 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4425 (something_changed_gconfCB): Rename from something_changedCB.
4426 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4427 (parse_settings): Move check for font inside HAVE_XFT.
4428 (read_settings, apply_xft_settings): Add comment.
4429 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4430 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4431 call store_font_name_changed.
4432 (xft_settings_event): Add comment.
4433 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4434 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4435 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4436 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4437 (xsettings_initialize): Call init_gsettings last.
4438 (xsettings_get_system_font, xsettings_get_system_normal_font):
4441 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4443 Random fixes. E.g., (random) never returned negative values.
4444 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4445 subseconds part to the entropy, as that's a bit more random.
4446 Prefer signed to unsigned, since the signedness doesn't matter and
4447 in general we prefer signed. When given a limit, use a
4448 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4449 latter isn't right if USE_2_TAGS_FOR_INTS.
4450 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4451 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4453 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4455 * textprop.c (text_property_stickiness):
4456 Obey Vtext_property_default_nonsticky.
4457 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4458 * w32fns.c (syms_of_w32fns):
4459 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4461 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4463 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4464 This is more efficient than Ffile_directory_p and avoids a minor race.
4466 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4468 * buffer.c (Foverlay_put): Say what the return value is
4471 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4472 is a directory before asking whether to use the file name
4474 (barf_or_query_if_file_exists): Make the "File is a directory"
4475 error be more correct.
4477 * fns.c (Frequire): Remove the mention of the .gz files, since
4478 that's installation-specific, but keep the mention of
4479 `get-load-suffixes'.
4481 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4483 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4484 Report string overflow if the output is too long.
4486 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4488 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4489 (syms_of_gnutls): Remove duplicate DEFSYM for
4490 Qgnutls_bootprop_verify_hostname_error, an error for
4491 Qgnutls_bootprop_verify_error (which is no longer used).
4493 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4494 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4495 Also (re)move comments that are misplaced or no longer relevant.
4497 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4499 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4501 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4503 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4504 and background color parameters if they have been changed.
4506 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4508 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4510 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4512 * xsettings.c (SYSTEM_FONT): Define only when used.
4513 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4515 * keymap.c (access_keymap_1): Now static.
4517 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4519 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4520 leave any prefix arg for the up event (Bug#1586).
4522 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4524 * lread.c (syms_of_lread): Mention single symbols defined by
4525 `defvar' or `defconst' (bug#7154).
4527 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4528 (Frequire): Mention get-load-suffixes.
4530 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4532 * window.h (window): Remove clone_number slot.
4533 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4535 (make_parent_window, make_window, saved_window)
4536 (Fset_window_configuration, save_window_save): Don't deal with
4538 * buffer.c (Qclone_number): Remove declaration.
4539 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4541 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4543 Add multiple inheritance to keymaps.
4544 * keymap.c (Fmake_composed_keymap): New function.
4545 (Fset_keymap_parent): Simplify.
4546 (fix_submap_inheritance): Remove.
4547 (access_keymap_1): New function extracted from access_keymap to handle
4548 embedded parents and handle lists of maps.
4549 (access_keymap): Use it.
4550 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4551 (Fcopy_keymap): Handle embedded parents.
4552 (Fcommand_remapping, define_as_prefix): Simplify.
4553 (Fkey_binding): Simplify.
4554 (syms_of_keymap): Move minibuffer-local-completion-map,
4555 minibuffer-local-filename-completion-map,
4556 minibuffer-local-must-match-map, and
4557 minibuffer-local-filename-must-match-map to Elisp.
4558 (syms_of_keymap): Defsubr make-composed-keymap.
4559 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4560 (parse_menu_item): Trivial simplification.
4562 2011-07-01 Glenn Morris <rgm@gnu.org>
4564 * Makefile.in (SETTINGS_LIBS): Fix typo.
4566 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4568 * coding.c (Fencode_coding_string): Record the last coding system
4569 used, as the function doc string says (bug#8738).
4571 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4573 * xsettings.c (store_monospaced_changed): Take new font as arg and
4574 check for change against current_mono_font.
4575 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4576 (emacs_settings_constructor, emacs_settings_get_property)
4577 (emacs_settings_set_property, emacs_settings_class_init)
4578 (emacs_settings_init, gsettings_obj): Remove.
4579 (something_changedCB): New function for HAVE_GSETTINGS.
4580 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4581 with value as argument.
4582 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4583 g_settings_new (Bug#8967). Do not create gsettings_obj.
4584 Remove calls to g_settings_bind. Connect something_changedCB to
4587 * xgselect.c: Add defined (HAVE_GSETTINGS).
4588 (xgselect_initialize): Ditto.
4590 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4591 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4594 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4596 * eval.c (struct backtrace): Simplify and port the data structure.
4597 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4598 signed bit field, as this assumption is not portable and it makes
4599 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4600 "char debug_on_exit : 1" as this is not portable either; instead,
4601 use the portable "unsigned int debug_on_exit : 1". Remove unused
4602 member evalargs. Remove obsolete comments about cc bombing out.
4604 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4606 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4607 Let HAVE_GSETTINGS override HAVE_GCONF.
4608 (store_monospaced_changed): New function.
4609 (EMACS_SETTINGS): A new type derived from GObject to handle
4610 GSettings notifications.
4611 (emacs_settings_constructor, emacs_settings_get_property)
4612 (emacs_settings_set_property, emacs_settings_class_init):
4614 (gsettings_client, gsettings_obj): New variables.
4615 (GSETTINGS_SCHEMA): New define.
4616 (something_changedCB): Call store_monospaced_changed.
4617 (init_gsettings): New function.
4618 (xsettings_initialize): Call init_gsettings.
4619 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4622 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4625 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4627 * window.c (resize_root_window, grow_mini_window)
4628 (shrink_mini_window): Rename Qresize_root_window to
4629 Qwindow_resize_root_window and Qresize_root_window_vertically to
4630 Qwindow_resize_root_window_vertically.
4632 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4634 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4636 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4638 * makefile.w32-in: Redesign dependencies so they reflect more
4639 clearly which files are directly included by each source file,
4640 and not through other includes.
4642 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4644 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4645 (sort_overlays, overlay_strings): When an overlay's clone number
4646 matches the window's clone number process the overlay even if
4647 the overlay's window property doesn't match the current window.
4649 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4650 (Fwindow_hchild): Rename to Fwindow_left_child.
4651 (Fwindow_next): Rename to Fwindow_next_sibling.
4652 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4653 (resize_window_check): Rename to window_resize_check.
4654 (resize_window_apply): Rename to window_resize_apply.
4655 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4656 (Fdelete_other_windows_internal, resize_frame_windows)
4657 (Fsplit_window_internal, Fdelete_window_internal)
4658 (grow_mini_window, shrink_mini_window)
4659 (Fresize_mini_window_internal): Fix callers accordingly.
4661 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4663 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4664 (emacs_fixed_set_min_size): Remove.
4665 (emacs_fixed_new): Take frame as argument.
4667 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4668 (_EmacsFixedPrivate): Remove minwidth/height.
4669 Add struct frame *f.
4670 (emacs_fixed_init): Initialize priv->f.
4671 (get_parent_class, emacs_fixed_set_min_size): Remove.
4672 (emacs_fixed_new): Set priv->f to argument.
4673 (emacs_fixed_get_preferred_width)
4674 (emacs_fixed_get_preferred_height): Use min_width/height from
4675 frames size_hint to set minimum and natural (Bug#8919).
4676 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4677 and use min_width/height from frames size_hint to set
4678 min_width/height (Bug#8919).
4680 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4681 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4684 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4686 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4687 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4690 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4692 * process.c (wait_reading_process_output): Bypass select if
4693 waiting for a cell while ignoring keyboard input, and input is
4694 pending. Suggested by Jan Djärv (Bug#8869).
4696 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4698 Use gnulib's dup2 module instead of rolling our own.
4699 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4701 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4703 * dispnew.c (scrolling_window): Before scrolling, turn off a
4704 mouse-highlight in the window being scrolled.
4706 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4708 Move DEFSYM to lisp.h and use everywhere.
4710 * character.h (DEFSYM): Move declaration...
4711 * lisp.h (DEFSYM): ...here.
4717 * w32select.c: Don't include character.h.
4719 * alloc.c (syms_of_alloc):
4720 * buffer.c (syms_of_buffer):
4721 * bytecode.c (syms_of_bytecode):
4722 * callint.c (syms_of_callint):
4723 * casefiddle.c (syms_of_casefiddle):
4724 * casetab.c (init_casetab_once):
4725 * category.c (init_category_once, syms_of_category):
4726 * ccl.c (syms_of_ccl):
4727 * cmds.c (syms_of_cmds):
4728 * composite.c (syms_of_composite):
4729 * dbusbind.c (syms_of_dbusbind):
4730 * dired.c (syms_of_dired):
4731 * dispnew.c (syms_of_display):
4732 * doc.c (syms_of_doc):
4733 * editfns.c (syms_of_editfns):
4734 * emacs.c (syms_of_emacs):
4735 * eval.c (syms_of_eval):
4736 * fileio.c (syms_of_fileio):
4737 * fns.c (syms_of_fns):
4738 * frame.c (syms_of_frame):
4739 * fringe.c (syms_of_fringe):
4740 * insdel.c (syms_of_insdel):
4741 * keymap.c (syms_of_keymap):
4742 * lread.c (init_obarray, syms_of_lread):
4743 * macros.c (syms_of_macros):
4744 * msdos.c (syms_of_msdos):
4745 * print.c (syms_of_print):
4746 * process.c (syms_of_process):
4747 * search.c (syms_of_search):
4748 * sound.c (syms_of_sound):
4749 * syntax.c (init_syntax_once, syms_of_syntax):
4750 * terminal.c (syms_of_terminal):
4751 * textprop.c (syms_of_textprop):
4752 * undo.c (syms_of_undo):
4753 * w32.c (globals_of_w32):
4754 * window.c (syms_of_window):
4755 * xdisp.c (syms_of_xdisp):
4756 * xfaces.c (syms_of_xfaces):
4757 * xfns.c (syms_of_xfns):
4758 * xmenu.c (syms_of_xmenu):
4759 * xsettings.c (syms_of_xsettings):
4760 * xterm.c (syms_of_xterm): Use DEFSYM.
4762 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4764 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4766 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4768 Integer and buffer overflow fixes (Bug#8873).
4770 * print.c (printchar, strout): Check for string overflow.
4771 (PRINTPREPARE, printchar, strout):
4772 Don't set size unless allocation succeeds.
4774 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4775 for sizes. Check for string overflow more accurately.
4776 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4778 * macros.c: Integer and buffer overflow fixes.
4779 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4780 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4781 Use ptrdiff_t, not int, for sizes.
4782 Don't increment bufsize until after realloc succeeds.
4783 Check for size-calculation overflow.
4784 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4786 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4788 * lread.c: Integer overflow fixes.
4789 (read_integer): Radix is now EMACS_INT, not int,
4790 to improve quality of diagnostics for out-of-range radices.
4791 Calculate buffer size correctly for out-of-range radices.
4792 (read1): Check for integer overflow in radices, and in
4793 read-circle numbers.
4794 (read_escape): Avoid int overflow.
4795 (Fload, openp, read_buffer_size, read1)
4796 (substitute_object_recurse, read_vector, read_list, map_obarray):
4797 Use ptrdiff_t, not int, for sizes.
4798 (read1): Use EMACS_INT, not int, for sizes.
4799 Check for size overflow.
4801 * image.c (cache_image): Check for size arithmetic overflow.
4803 * lread.c: Integer overflow issues.
4804 (saved_doc_string_size, saved_doc_string_length)
4805 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4806 Now ptrdiff_t, not int.
4807 (read1): Don't assume doc string length fits in int. Check for
4808 out-of-range doc string lengths.
4809 (read_list): Don't assume file position fits in int.
4810 (read_escape): Check for hex character overflow.
4812 2011-06-22 Leo Liu <sdl.web@gmail.com>
4814 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4815 Move to minibuffer.el.
4817 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4819 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4820 The following patches are for when GLYPH_DEBUG && !XASSERT.
4821 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4822 * dispnew.c (flush_stdout):
4823 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4824 Mark as externally visible.
4825 * dispnew.c (check_window_matrix_pointers): Now static.
4826 * dispnew.c (window_to_frame_vpos):
4827 * xfns.c (unwind_create_frame):
4828 * xterm.c (x_check_font): Remove unused local.
4829 * scroll.c (CHECK_BOUNDS):
4830 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4831 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4832 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4833 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4834 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4836 (debug_method_add): Use va_list and vsprintf rather than relying
4837 on undefined behavior with wrong number of arguments.
4838 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4839 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4840 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4841 since we're not interested in debugging glyphs with old libraries.
4842 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4843 GCC 4.6.0's static checking.
4845 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4847 Integer overflow and signedness fixes (Bug#8873).
4848 A few related buffer overrun fixes, too.
4850 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4852 * dispextern.h (struct face.stipple):
4853 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4854 (x_bitmap_mask, x_allocate_bitmap_record)
4855 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4856 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4857 (x_create_bitmap_from_xpm_data):
4858 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4859 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4861 * xfaces.c (load_pixmap):
4862 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4863 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4864 (.bitmaps_last, struct x_output.icon_bitmap):
4865 Use ptrdiff_t, not int, for bitmap indexes.
4866 (x_allocate_bitmap_record): Check for size overflow.
4867 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4869 Use ptrdiff_t, not int, for overlay counts.
4870 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4871 * editfns.c (overlays_around, get_pos_property):
4872 * textprop.c (get_char_property_and_overlay):
4873 * xdisp.c (next_overlay_change, note_mouse_highlight):
4874 * xfaces.c (face_at_buffer_position):
4875 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4876 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4877 (Fnext_overlay_change, Fprevious_overlay_change)
4878 (mouse_face_overlay_overlaps, Foverlays_in):
4879 Use ptrdiff_t, not int, for sizes.
4880 (overlays_at, overlays_in): Check for size-calculation overflow.
4882 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4884 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4885 (x_session_initialize): Do not assume string length fits in int.
4887 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4888 This is unlikely, but can occur if DPI is outlandish.
4890 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4891 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4893 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4894 * xrdb.c (magic_file_p, search_magic_path):
4895 Omit last arg SUFFIX; it was always 0. All callers changed.
4896 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4898 * xfont.c (xfont_match): Avoid need for strlen.
4900 * xfns.c: Don't assume strlen fits in int.
4901 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4903 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4904 not unsigned long, as we prefer signed integers. All callers changed.
4905 Detect integer overflow in repeat count.
4906 (message_dolog): Don't assume print length fits in 39 bytes.
4907 (display_mode_element): Don't assume strlen fits in int.
4909 * termcap.c: Don't assume sizes fit in int and never overflow.
4910 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4911 (gobble_line): Check for size-calculation overflow.
4913 * minibuf.c (Fread_buffer):
4914 * lread.c (intern, intern_c_string):
4915 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4916 Don't assume string length fits in int.
4918 * keyboard.c (parse_tool_bar_item):
4919 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4921 * font.c: Don't assume string length fits in int.
4922 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4923 Use ptrdiff_t, not int.
4924 (font_intern_prop): Don't assume string length fits in int.
4925 Don't assume integer property fits in fixnum.
4926 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4928 * filelock.c: Fix some buffer overrun and integer overflow issues.
4929 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4930 Reformulate so as not to need the command string.
4931 Invoke gzip -cd rather than gunzip, as it's more portable.
4932 (lock_info_type, lock_file_1, lock_file):
4933 Don't assume pid_t and time_t fit in unsigned long.
4934 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4935 (current_lock_owner): Prefer signed type for sizes.
4936 Use memcpy, not strncpy, where memcpy is what is really wanted.
4937 Don't assume (via atoi) that time_t and pid_t fit in int.
4938 Check for time_t and/or pid_t out of range, e.g., via a network share.
4939 Don't alloca where an auto var works fine.
4941 * fileio.c: Fix some integer overflow issues.
4942 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4943 Don't assume string length fits in int.
4944 (directory_file_name): Don't assume string length fits in long.
4945 (make_temp_name): Don't assume pid fits in int, or that its print
4946 length is less than 20.
4948 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4950 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4952 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4954 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4955 We prefer signed integers, even for size calculations.
4957 * emacs.c: Don't assume string length fits in 'int'.
4958 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4959 (main): Don't invoke strlen when not needed.
4961 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4962 (XD_DEBUG_MESSAGE): Don't waste a byte.
4964 * callproc.c (getenv_internal_1, getenv_internal)
4966 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4968 * lread.c (invalid_syntax): Omit length argument.
4969 All uses changed. This doesn't fix a bug, but it simplifies the
4970 code away from its former Hollerith-constant appearance, and it's
4971 one less 'int' to worry about when looking at integer-overflow issues.
4972 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4974 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4975 This didn't break anything, but it didn't help either.
4976 It's confusing to put a bogus integer in a place where the actual
4977 value does not matter.
4978 (LIST_END_P): Remove unused macro and its bogus comment.
4979 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4981 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4982 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4984 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4985 We prefer signed types, and the value cannot exceed the EMACS_INT
4986 range anyway (because otherwise the length would not be representable).
4987 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4988 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4989 This avoids a GCC warning when WIDE_EMACS_INT.
4991 * indent.c (sane_tab_width): New function.
4992 (current_column, scan_for_column, Findent_to, position_indentation)
4993 (compute_motion): Use it. This is just for clarity.
4994 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4996 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4998 * lisp.h (lint_assume): New macro.
4999 * composite.c (composition_gstring_put_cache):
5000 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5002 * editfns.c, insdel.c:
5003 Omit unnecessary forward decls, to simplify future changes.
5005 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5007 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5009 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5010 Use much-faster test for byte-length change.
5011 Don't assume string byte-length fits in 'int'.
5012 Check that character arg fits in 'int'.
5013 (mapcar1): Declare byte as byte, for clarity.
5015 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5017 * fns.c (concat): Catch string overflow earlier.
5018 Do not rely on integer wraparound.
5020 * dispextern.h (struct it.overlay_strings_charpos)
5021 (struct it.selective): Now EMACS_INT, not int.
5022 * xdisp.c (forward_to_next_line_start)
5023 (back_to_previous_visible_line_start)
5024 (reseat_at_next_visible_line_start, next_element_from_buffer):
5025 Don't arbitrarily truncate the value of 'selective' to int.
5027 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5029 * composite.c: Don't truncate sizes to 'int'.
5030 (composition_gstring_p, composition_reseat_it)
5031 (composition_adjust_point): Use EMACS_INT, not int.
5032 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5033 not EMACS_UINT, for indexes.
5035 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5037 * buffer.c: Include <verify.h>.
5038 (struct sortvec.priority, struct sortstr.priority):
5039 Now EMACS_INT, not int.
5040 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5041 (struct sortstr.size, record_overlay_string)
5042 (struct sortstrlist.size, struct sortlist.used):
5043 Don't truncate size to int.
5044 (record_overlay_string): Check for size-calculation overflow.
5045 (init_buffer_once): Check at compile-time, not run-time.
5047 2011-06-22 Jim Meyering <meyering@redhat.com>
5049 Don't leak an XBM-image-sized buffer
5050 * image.c (xbm_load): Free the image buffer after using it.
5052 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5055 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5056 that Sun C diagnosed.
5057 * fns.c (secure_hash): Fix pointer signedness issue.
5058 * intervals.c (static_offset_intervals): New function.
5059 (offset_intervals): Use it.
5061 2011-06-21 Leo Liu <sdl.web@gmail.com>
5064 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5067 * fns.c (secure_hash): Rename from crypto_hash_function and change
5068 the first arg to accept symbols.
5069 (Fsecure_hash): New primitive.
5070 (syms_of_fns): New symbols.
5072 2011-06-20 Deniz Dogan <deniz@dogan.se>
5074 * process.c (Fset_process_buffer): Clarify return value in
5077 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5079 * dispnew.c (add_window_display_history): Use BVAR.
5081 * xdisp.c (debug_method_add): Use BVAR.
5082 (check_window_end, dump_glyph_matrix, dump_glyph)
5083 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5085 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5088 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5089 check till after the cache is created in init_frame_faces.
5091 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5093 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5095 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5097 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5098 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5099 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5101 Improve buffer-overflow checking (Bug#8873).
5102 * fileio.c (Finsert_file_contents):
5103 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5104 Remove the old (too-loose) buffer overflow checks.
5105 They weren't needed, since make_gap checks for buffer overflow.
5106 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5107 The old code merely checked for Emacs fixnum overflow, and relied
5108 on undefined (wraparound) behavior. The new code avoids undefined
5109 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5111 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5112 Tune. Don't use wider integers than needed. Don't use alloca.
5113 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5115 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5117 * insdel.c, lisp.h (buffer_overflow): New function.
5118 (insert_from_buffer_1, replace_range, replace_range_2):
5119 * insdel.c (make_gap_larger):
5120 * editfns.c (Finsert_char):
5121 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5123 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5125 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5127 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5129 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5130 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5132 * fileio.c: Don't assume EMACS_INT fits in off_t.
5133 (emacs_lseek): New static function.
5134 (Finsert_file_contents, Fwrite_region): Use it.
5135 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5137 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5139 * fns.c: Don't overflow int when computing a list length.
5140 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5141 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5142 truncation on 64-bit hosts. Check for QUIT every
5143 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5144 faster and is responsive enough.
5145 (Flength): Report an error instead of overflowing an integer.
5146 (Fsafe_length): Return a float if the value is not representable
5147 as a fixnum. This shouldn't happen except in contrived situations.
5148 (Fnthcdr, Fsort): Don't assume list length fits in int.
5149 (Fcopy_sequence): Don't assume vector length fits in int.
5151 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5152 (header_size, word_size): New constants.
5153 (allocate_vectorlike): Don't check size overflow here.
5154 (allocate_vector): Check it here instead, since this is the only
5155 caller of allocate_vectorlike that could cause overflow.
5156 Check that the new vector's length is representable as a fixnum.
5158 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5159 The previous code was bogus. For example, next_almost_prime (32)
5160 returned 39, which is undesirable as it is a multiple of 3; and
5161 next_almost_prime (24) returned 25, which is a multiple of 5 so
5162 why was the code bothering to check for multiples of 7?
5164 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5166 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5168 Variadic C functions now count arguments with ptrdiff_t.
5169 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5170 Back then I didn't know that the Emacs coding style prefers signed int.
5171 Also, in the meantime I found a few more instances where arguments
5172 were being counted with int, which may truncate counts on 64-bit
5173 machines, or EMACS_INT, which may be unnecessarily wide.
5174 * lisp.h (struct Lisp_Subr.function.aMANY)
5175 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5176 Arg counts are now ptrdiff_t, not size_t.
5177 All variadic functions and their callers changed accordingly.
5178 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5179 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5180 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5181 * callint.c (Fcall_interactively): Check arg count for overflow,
5182 to avoid potential buffer overrun. Use signed char, not 'int',
5183 for 'varies' array, so that we needn't bother to check its size
5184 calculation for overflow.
5185 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5186 * eval.c (apply_lambda):
5187 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5188 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5189 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5191 * callint.c (Fcall_interactively): Don't use index var as event count.
5193 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5194 * mem-limits.h (SIZE): Remove; no longer used.
5196 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5198 Remove unnecessary casts.
5199 * xterm.c (x_term_init):
5200 * xfns.c (x_set_border_pixel):
5201 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5202 These aren't needed now that we assume ANSI C.
5204 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5205 It's more likely to cause problems (due to unsigned overflow)
5208 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5210 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5212 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5214 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5216 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5218 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5220 GLYPH_CODE_FACE returns EMACS_INT, not int.
5221 * dispextern.h (merge_faces):
5222 * xfaces.c (merge_faces):
5223 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5224 Don't assume EMACS_INT fits in int.
5226 * character.h (CHAR_VALID_P): Remove unused parameter.
5227 * fontset.c, lisp.h, xdisp.c: All uses changed.
5229 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5231 * fns.c (concat): Minor tuning based on overflow analysis.
5232 This doesn't fix any bugs. Use int to hold character, instead
5233 of constantly refetching from Emacs object. Use XFASTINT, not
5234 XINT, for value known to be a character. Don't bother comparing
5235 a single byte to 0400, as it's always less.
5237 * floatfns.c (Fexpt):
5238 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5240 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5243 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5245 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5246 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5247 incorrectly succeed when S was a string, because 4294967386 was
5248 truncated before it was used.
5250 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5251 Otherwise, an out-of-range integer could cause undefined behavior
5254 * composite.c: Use int, not EMACS_INT, for characters.
5255 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5256 EMACS_INT, for values that are known to be in character range.
5257 This doesn't fix any bugs but is the usual style inside Emacs and
5258 may generate better code on 32-bit machines.
5260 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5261 This is for reasons similar to the recent CHAR_STRING fix.
5262 * charset.c (Fencode_char): Check that character arg is actually
5263 a character. Pass an int to ENCODE_CHAR.
5264 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5265 wider than 'int', as a compile-time check to prevent future regressions
5268 * character.c (char_string): Remove unnecessary casts.
5270 Make sure a 64-bit char is never passed to CHAR_STRING.
5271 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5272 by silently ignoring the top 32 bits, allowing some values
5273 that were far too large to be valid characters.
5274 * character.h: Include <verify.h>.
5275 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5276 arguments are no wider than unsigned, as a compile-time check
5277 to prevent future regressions in this area.
5279 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5280 (Fsubst_char_in_region):
5282 * xdisp.c (decode_mode_spec_coding):
5283 Adjust to CHAR_STRING's new requirement.
5284 * editfns.c (Finsert_char, Fsubst_char_in_region):
5285 * fns.c (concat): Check that character args are actually
5286 characters. Without this test, these functions did the wrong
5287 thing with wildly out-of-range values on 64-bit hosts.
5289 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5290 These casts should not be needed on 32-bit hosts, either.
5291 * keyboard.c (read_char):
5292 * lread.c (Fload): Remove casts to unsigned.
5294 * lisp.h (UNSIGNED_CMP): New macro.
5295 This fixes comparison bugs on 64-bit hosts.
5296 (ASCII_CHAR_P): Use it.
5297 * casefiddle.c (casify_object):
5298 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5299 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5300 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5301 * dispextern.h (FACE_FROM_ID):
5302 * keyboard.c (read_char): Use UNSIGNED_CMP.
5304 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5305 not to EMACS_INT, to avoid GCC warning.
5307 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5309 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5310 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5311 isn't needed on 32-bit machines.
5313 * buffer.c (Fgenerate_new_buffer_name):
5314 Use EMACS_INT for count, not int.
5315 (advance_to_char_boundary): Return EMACS_INT, not int.
5317 * data.c (Qcompiled_function): Now static.
5319 * window.c (window_body_lines): Now static.
5321 * image.c (gif_load): Rename local to avoid shadowing.
5323 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5324 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5325 * alloc.c (make_save_value): Integer argument is now of type
5327 (mark_object): Use ptrdiff_t, not int.
5328 * lisp.h (pD): New macro.
5329 * print.c (print_object): Use it.
5331 * alloc.c: Use EMACS_INT, not int, to count objects.
5332 (total_conses, total_markers, total_symbols, total_vector_size)
5333 (total_free_conses, total_free_markers, total_free_symbols)
5334 (total_free_floats, total_floats, total_free_intervals)
5335 (total_intervals, total_strings, total_free_strings):
5336 Now EMACS_INT, not int. All uses changed.
5337 (Fgarbage_collect): Compute overall total using a double, so that
5338 integer overflow is less likely to be a problem. Check for overflow
5339 when converting back to an integer.
5340 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5341 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5342 These were 'int' variables that could overflow on 64-bit hosts;
5343 they were never used, so remove them instead of repairing them.
5344 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5345 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5346 Previously, this ceilinged at INT_MAX, but that doesn't work on
5348 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5350 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5351 (allocate_vectorlike): Check for ptrdiff_t overflow.
5352 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5353 when a (possibly-narrower) signed value would do just as well.
5354 We prefer using signed arithmetic, to avoid comparison confusion.
5356 * alloc.c: Catch some string size overflows that we were missing.
5357 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5358 for convenience in STRING_BYTES_MAX.
5359 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5360 The definition here is exact; the one in lisp.h was approximate.
5361 (allocate_string_data): Check for string overflow. This catches
5362 some instances we weren't catching before. Also, it catches
5363 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5364 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5365 and ptrdiff_t and EMACS_INT are both 64 bits.
5367 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5368 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5369 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5371 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5373 * alloc.c (Fmake_string): Check for out-of-range init.
5375 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5377 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5379 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5381 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5382 xg_get_default_scrollbar_width.
5384 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5385 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5386 (style_changed_cb): Call update_theme_scrollbar_width and call
5387 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5388 all frames (Bug#8505).
5389 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5390 Call gtk_window_set_resizable if HAVE_GTK3.
5391 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5392 and height if HAVE_GTK3 (Bug#8505).
5393 (scroll_bar_width_for_theme): New variable.
5394 (update_theme_scrollbar_width): New function.
5395 (xg_get_default_scrollbar_width): Move code to
5396 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5397 (xg_initialize): Call update_theme_scrollbar_width.
5399 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5401 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5403 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5405 * frame.c (make_frame): Call other_buffer_safely instead of
5408 * window.c (temp_output_buffer_show): Call display_buffer with
5409 second argument Vtemp_buffer_show_specifiers and reset latter
5410 immediately after the call.
5411 (Vtemp_buffer_show_specifiers): New variable.
5412 (auto_window_vscroll_p, next_screen_context_lines)
5413 (Vscroll_preserve_screen_position): Remove leading asterisks from
5416 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5418 Fix minor problems found by GCC 4.6.0 static checking.
5419 * buffer.c (Qclone_number): Remove for now, as it's unused.
5420 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5421 (record_buffer): Remove unused local.
5422 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5423 (set_frame_buffer_list): Remove; unused.
5424 * frame.h (other_visible_frames): Remove decl.
5425 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5426 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5427 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5429 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5430 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5431 Define only if HAVE_GPM.
5432 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5433 (update_hints_inhibit): Remove; never set. All uses removed.
5434 * widgetprv.h (emacsFrameClassRec): Remove decl.
5435 * window.c (delete_deletable_window): Now returns void, since it
5436 wasn't returning anything.
5437 (compare_window_configurations): Remove unused locals.
5438 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5439 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5440 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5441 the same widths as pointers. This follows up on the 2011-05-06 patch.
5442 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5443 * xterm.h: Likewise.
5444 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5446 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5448 * makefile.w32-in: Update dependencies.
5449 (LISP_H): Add lib/intprops.h.
5451 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5453 * image.c (gif_load): Add animation frame delay to the metadata.
5454 (syms_of_image): Use DEFSYM. New symbol `delay'.
5456 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5458 * window.c (delete_deletable_window): Re-add.
5459 (Fset_window_configuration): Rewrite to handle dead buffers and
5460 consequently deletable windows.
5461 (window_tree, Fwindow_tree): Remove. Supply functionality in
5463 (compare_window_configurations): Simplify code.
5465 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5467 * image.c (imagemagick_load_image): Fix type mismatch.
5468 (Fimagemagick_types): Likewise.
5470 * window.h (replace_buffer_in_windows): Declare.
5472 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5474 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5475 Qclone_number. Remove external declaration of Qdelete_window.
5476 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5478 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5479 Run Qbuffer_list_update_hook if allowed.
5480 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5481 buffer list implementation.
5482 (other_buffer_safely): New function.
5483 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5484 calls to replace_buffer_in_windows and
5485 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5487 (record_buffer): Inhibit quitting and rewrite using quittable
5488 functions. Run Qbuffer_list_update_hook if allowed.
5489 (Frecord_buffer, Funrecord_buffer): New functions.
5490 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5491 Move switch-to-buffer to window.el.
5492 (bury-buffer): Move to window.el.
5493 (Vbuffer_list_update_hook): New variable.
5495 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5498 * window.h (resize_frame_windows): Move up in code.
5499 (Fwindow_frame): Remove EXFUN.
5500 (replace_buffer_in_all_windows): Remove prototype.
5501 (replace_buffer_in_windows_safely): Add prototype.
5503 * window.c: Declare Qdelete_window static again. Move down
5504 declaration of select_count.
5505 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5506 (Fother_window): Move to window.el.
5507 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5508 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5509 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5511 (replace_buffer_in_windows): Implement by calling
5512 Qreplace_buffer_in_windows.
5513 (replace_buffer_in_all_windows): Remove with some functionality
5514 moved into replace_buffer_in_windows_safely.
5515 (replace_buffer_in_windows_safely): New function.
5516 (select_window_norecord, select_frame_norecord): Move in front
5517 of run_window_configuration_change_hook. Remove now obsolete
5519 (Fset_window_buffer): Rewrite doc-string.
5520 Call Qrecord_window_buffer.
5521 (keys_of_window): Move binding for other-window to window.el.
5523 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5525 * dispextern.h (struct image): Replace data member, whose int_val
5526 and ptr_val fields were not used by anything, with a single
5529 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5530 (gif_clear_image, gif_load, imagemagick_load_image)
5531 (gs_clear_image, gs_load): Callers changed.
5533 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5535 * buffer.h: Include <time.h>, for time_t.
5536 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5538 Fix minor problems found by static checking.
5540 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5542 Make identifiers static if they are not used in other modules.
5543 * data.c (Qcompiled_function, Qframe, Qvector):
5544 * image.c (QimageMagick, Qsvg):
5545 * minibuf.c (Qmetadata):
5546 * window.c (resize_window_check, resize_root_window): Now static.
5547 * window.h (resize_window_check, resize_root_window): Remove decls.
5549 * window.c (window_deletion_count, delete_deletable_window):
5551 (window_body_lines): Now static.
5552 (Fdelete_other_windows_internal): Mark vars as initialized.
5553 Make sure 'resize_failed' is initialized.
5554 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5555 (resize_window_apply): Remove unused local.
5556 * window.h (delete_deletable_window): Remove decl.
5558 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5559 (imagemagick_load_image): Fix pointer signedness problem by changing
5560 last arg from unsigned char * to char *. All uses changed.
5561 Also, fix a local for similar reasons.
5562 Remove unused locals. Remove locals to avoid shadowing.
5563 (fn_rsvg_handle_free): Remove; unused.
5564 (svg_load, svg_load_image): Fix pointer signedness problem.
5565 (imagemagick_load_image): Don't use garbage pointer image_wand.
5567 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5569 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5571 * image.c (gif_load): Fix omitted cast error introduced by
5574 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5576 * window.h (resize_proportionally, orig_total_lines)
5577 (orig_top_line): Remove from window structure.
5578 (set_window_height, set_window_width, change_window_heights)
5579 (Fdelete_window): Remove prototypes.
5580 (resize_frame_windows): Remove duplicate declaration.
5582 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5584 * window.h (resize_frame_windows, resize_window_check)
5585 (delete_deletable_window, resize_root_window)
5586 (resize_frame_windows): Declare prototypes.
5588 * window.c (resize_window_apply): Make definition be "static" to
5589 match the prototype.
5591 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5593 * window.c: Remove declarations of Qwindow_size_fixed,
5594 window_min_size_1, window_min_size_2, window_min_size,
5595 size_window, window_fixed_size_p, enlarge_window, delete_window.
5596 Remove static from declaration of Qdelete_window, it's
5597 temporarily needed by Fbury_buffer.
5598 (replace_window): Don't assign orig_top_line and
5600 (Fdelete_window, delete_window): Remove. Window deletion is
5601 handled by window.el.
5602 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5603 Replace Fdelete_window calls with calls to Qdelete_window.
5604 (Fdelete_other_windows): Remove. Deleting other windows is
5605 handled by window.el.
5606 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5607 handled in window.el.
5608 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5609 Window minimum sizes are handled in window.el.
5610 (shrink_windows, size_window, set_window_height)
5611 (set_window_width, change_window_heights, window_height)
5612 (window_width, CURBEG, CURSIZE, enlarge_window)
5613 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5614 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5615 handled in window.el.
5616 (make_dummy_parent): Rename to make_parent_window and give it a
5617 second argument horflag.
5618 (make_window): Don't set resize_proportionally any more.
5619 (Fsplit_window): Remove. Windows are split in window.el.
5620 (save_restore_action, save_restore_orig_size)
5621 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5622 Resize mini windows in window.el.
5623 (grow_mini_window, shrink_mini_window): Implement by calling
5624 Qresize_root_window_vertically, resize_window_check and
5625 resize_window_apply.
5626 (saved_window, Fset_window_configuration, save_window_save):
5627 Do not handle orig_top_line, orig_total_lines, and
5628 resize_proportionally.
5629 (window_min_height, window_min_width): Move to window.el.
5630 (keys_of_window): Move bindings for delete-other-windows,
5631 split-window, delete-window and enlarge-window to window.el.
5633 * buffer.c: Temporarily extern Qdelete_window.
5634 (Fbury_buffer): Temporarily call Qdelete_window instead of
5635 Fdelete_window (Fbury_buffer will move to window.el soon).
5637 * frame.c (set_menu_bar_lines_1): Remove code handling
5638 orig_top_line and orig_total_lines.
5640 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5641 set_window_height but set heights directly.
5642 (change_frame_size_1): Use resize_frame_windows.
5644 * xdisp.c (init_xdisp): Don't use set_window_height but set
5647 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5648 Use resize_frame_windows instead of change_window_heights and run
5649 run_window_configuration_change_hook.
5651 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5652 instead of change_window_heights and run
5653 run_window_configuration_change_hook.
5655 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5657 * window.c (replace_window): Rename second argument REPLACEMENT to
5658 NEW. New third argument SETFLAG. Rewrite.
5659 (delete_window, make_dummy_parent): Call replace_window with
5661 (window_list_1): Move down in code.
5662 (run_window_configuration_change_hook): Move set_buffer part
5663 before select_frame_norecord part in order to unwind correctly.
5664 Rename count1 to count.
5665 (recombine_windows, delete_deletable_window, resize_root_window)
5666 (Fdelete_other_windows_internal)
5667 (Frun_window_configuration_change_hook, make_parent_window)
5668 (resize_window_check, resize_window_apply, Fresize_window_apply)
5669 (resize_frame_windows, Fsplit_window_internal)
5670 (Fdelete_window_internal, Fresize_mini_window_internal):
5672 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5674 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5676 * window.h (window): Add some new members to window structure -
5677 normal_lines, normal_cols, new_total, new_normal, clone_number,
5678 splits, nest, prev_buffers, next_buffers.
5679 (WINDOW_TOTAL_SIZE): Move here from window.c.
5680 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5682 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5684 (make_dummy_parent): Set new members of windows structure.
5685 (make_window): Move down in code. Handle new members of window
5687 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5688 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5689 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5690 (Fset_window_prev_buffers, Fwindow_next_buffers)
5691 (Fset_window_next_buffers, Fset_window_clone_number):
5693 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5694 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5696 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5697 Argument WINDOW can be now internal window too.
5698 (Fwindow_use_time): Move up in code.
5699 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5701 (Fset_window_configuration, saved_window)
5702 (Fcurrent_window_configuration, save_window_save): Handle new
5703 members of window structure.
5704 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5705 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5706 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5707 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5708 Qget_mru_window, Qresize_root_window,
5709 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5710 Qauto_buffer_name; staticpro them.
5712 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5714 * window.c (Fwindow_total_size, Fwindow_left_column)
5715 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5716 (Fwindow_list_1): New functions.
5717 (window_box_text_cols): Replace with window_body_cols.
5718 (Fwindow_width, Fscroll_left, Fscroll_right):
5719 Use window_body_cols instead of window_box_text_cols.
5720 (delete_window, Fset_window_configuration):
5721 Call delete_all_subwindows with window as argument.
5722 (delete_all_subwindows): Take a window as argument and not a
5724 (window_loop): Remove handling of GET_LRU_WINDOW and
5726 (Fget_lru_window, Fget_largest_window): Move to window.el.
5728 * window.h: Extern window_body_cols instead of
5729 window_box_text_cols. delete_all_subwindows now takes a
5730 Lisp_Object as argument.
5732 * indent.c (compute_motion, Fcompute_motion):
5733 Use window_body_cols instead of window_box_text_cols.
5735 * frame.c (delete_frame): Call delete_all_subwindows with root
5738 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5740 * fns.c (Fputhash): Document return value.
5742 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5744 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5746 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5748 Cons<->int and similar integer overflow fixes (Bug#8794).
5750 Check for overflow when converting integer to cons and back.
5751 * charset.c (Fdefine_charset_internal, Fdecode_char):
5752 Use cons_to_unsigned to catch overflow.
5753 (Fencode_char): Use INTEGER_TO_CONS.
5754 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5755 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5756 * data.c (long_to_cons, cons_to_long): Remove.
5757 (cons_to_unsigned, cons_to_signed): New functions.
5758 These signal an error for invalid or out-of-range values.
5759 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5760 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5761 * font.c (Ffont_variation_glyphs):
5762 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5763 * lisp.h: Include <intprops.h>.
5764 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5765 (cons_to_signed, cons_to_unsigned): New decls.
5766 (long_to_cons, cons_to_long): Remove decls.
5767 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5768 (Fprimitive_undo): Use CONS_TO_INTEGER.
5769 * xfns.c (Fx_window_property): Likewise.
5770 * xselect.c: Include <limits.h>.
5771 (x_own_selection, selection_data_to_lisp_data):
5772 Use INTEGER_TO_CONS.
5773 (x_handle_selection_request, x_handle_selection_clear)
5774 (x_get_foreign_selection, Fx_disown_selection_internal)
5775 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5776 (lisp_data_to_selection_data): Use cons_to_unsigned.
5777 (x_fill_property_data): Use cons_to_signed.
5778 Report values out of range.
5780 Check for buffer and string overflow more precisely.
5781 * buffer.h (BUF_BYTES_MAX): New macro.
5782 * lisp.h (STRING_BYTES_MAX): New macro.
5783 * alloc.c (Fmake_string):
5784 * character.c (string_escape_byte8):
5785 * coding.c (coding_alloc_by_realloc):
5786 * doprnt.c (doprnt):
5787 * editfns.c (Fformat):
5789 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5790 since they may not be the same number.
5791 * editfns.c (Finsert_char):
5792 * fileio.c (Finsert_file_contents):
5793 Likewise for BUF_BYTES_MAX.
5795 * image.c: Use ptrdiff_t, not int, for sizes.
5796 (slurp_file): Switch from int to ptrdiff_t.
5798 (slurp_file): Check that file size fits in both size_t (for
5799 malloc) and ptrdiff_t (for sanity and safety).
5801 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5802 if b->modtime has its maximal value.
5804 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5806 Don't assume time_t can fit into int.
5807 * buffer.h (struct buffer.modtime): Now time_t, not int.
5808 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5809 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5811 Minor fixes for signed vs unsigned integers.
5812 * character.h (MAYBE_UNIFY_CHAR):
5813 * charset.c (maybe_unify_char):
5814 * keyboard.c (read_char, reorder_modifiers):
5815 XINT -> XFASTINT, since the integer must be nonnegative.
5816 * ftfont.c (ftfont_spec_pattern):
5817 * keymap.c (access_keymap, silly_event_symbol_error):
5818 XUINT -> XFASTINT, since the integer must be nonnegative.
5819 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5820 since it makes no difference and we prefer signed.
5821 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5822 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5825 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5827 * window.h (Fwindow_frame): Declare.
5829 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5831 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5832 (SPARE_MEMORY): Always define.
5833 (LARGE_REQUEST): Remove.
5834 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5836 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5838 * lisp.h: Move EXFUNS for Fframe_root_window,
5839 Fframe_first_window and Fset_frame_selected_window to window.h.
5841 * window.h: Move EXFUNS for Fframe_root_window,
5842 Fframe_first_window and Fset_frame_selected_window here from
5845 * frame.c (Fwindow_frame, Fframe_first_window)
5846 (Fframe_root_window, Fframe_selected_window)
5847 (Fset_frame_selected_window): Move to window.c.
5848 (Factive_minibuffer_window): Move to minibuf.c.
5849 (Fother_visible_frames_p): New function.
5851 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5853 * window.c (decode_window, decode_any_window): Move up in code.
5854 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5855 (inhibit_frame_unsplittable): Remove unused variable.
5856 (Fwindow_buffer): Move up and rewrite doc-string.
5857 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5858 (Fwindow_prev): New functions.
5859 (Fwindow_frame): Move here from frame.c. Accept any window as
5861 (Fframe_root_window, Fframe_first_window)
5862 (Fframe_selected_window): Move here from frame.c. Accept frame
5863 or arbitrary window as argument. Update doc-strings.
5864 (Fminibuffer_window): Move up in code.
5865 (Fwindow_minibuffer_p): Move up in code and simplify.
5866 (Fset_frame_selected_window): Move here from frame.c.
5868 (Fselected_window, select_window, Fselect_window): Move up in
5869 code. Minor doc-string fixes.
5871 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5873 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5874 Do not assume that spare memory exists; that assumption is valid
5875 only if SYSTEM_MALLOC.
5876 (LARGE_REQUEST): New macro, so that the issue of large requests
5877 is separated from the issue of spare memory.
5879 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5881 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5884 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5886 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5889 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5891 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5893 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5895 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5896 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5898 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5900 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5902 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5904 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5905 (x_clipboard_manager_save): Add return value.
5906 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5908 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5909 Obey Vx_select_enable_clipboard_manager. Catch errors in
5910 x_clipboard_manager_save (Bug#8779).
5911 (Vx_select_enable_clipboard_manager): New variable.
5912 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5914 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5916 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5918 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5920 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5921 in the current matrix if keep_current_p is non-zero.
5923 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5925 * bidi.c (bidi_level_of_next_char): Fix last change.
5927 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5929 Support bidi reordering of text covered by display properties.
5931 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5932 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5933 (bidi_cache_search, bidi_cache_iterator_state)
5934 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5935 (bidi_level_of_next_char, bidi_move_to_visually_next):
5936 Support character positions inside a run of characters covered by a
5938 (bidi_paragraph_init, bidi_resolve_explicit_1)
5939 (bidi_level_of_next_char): Call bidi_fetch_char and
5940 bidi_fetch_char_advance instead of FETCH_CHAR and
5942 (bidi_init_it): Initialize new members.
5943 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5945 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5946 instead of using explicit *_CHAR codes.
5947 (bidi_resolve_explicit, bidi_resolve_weak):
5948 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5949 bidirectional text is supported only in multibyte buffers.
5950 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5951 it to initialize the frame_window_p member of struct bidi_it.
5952 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5953 (bidi_resolve_explicit, bidi_resolve_weak)
5954 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5955 bidi_it->nchars is non-positive.
5956 (bidi_level_of_next_char): Don't try to lookup the cache for the
5957 next/previous character if nothing is cached there yet, or if we
5958 were just reseat()'ed to a new position.
5960 * xdisp.c (set_cursor_from_row): Set start and stop points
5961 according to the row's direction when priming the loop that looks
5962 for the glyph on which to display cursor.
5963 (single_display_spec_intangible_p): Function deleted.
5964 (display_prop_intangible_p): Reimplement to call
5965 handle_display_spec instead of single_display_spec_intangible_p.
5966 Accept 3 additional arguments needed by handle_display_spec.
5967 This fixes incorrect cursor motion across display property with complex
5968 values: lists, `(when COND...)' forms, etc.
5969 (single_display_spec_string_p): Support property values that are
5970 lists with the argument STRING its top-level element.
5971 (display_prop_string_p): Fix the condition for processing a
5972 property that is a list to be consistent with handle_display_spec.
5973 (handle_display_spec): New function, refactored from the
5974 last portion of handle_display_prop.
5975 (compute_display_string_pos): Accept additional argument
5976 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5977 value of a `display' property is a "replacing spec".
5978 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5979 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5980 the display property, but just return a value indicating whether
5981 the display property will replace the characters it covers.
5982 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5983 frame_window_p members of struct bidi_it.
5984 (compute_display_string_pos, compute_display_string_end):
5986 (push_it): Accept second argument POSITION, where pop_it should
5987 jump to continue iteration.
5988 (reseat_1): Initialize bidi_it.disp_pos.
5990 * keyboard.c (adjust_point_for_property): Adjust the call to
5991 display_prop_intangible_p to its new signature.
5993 * dispextern.h (struct bidi_it): New member frame_window_p.
5994 (bidi_init_it): Update prototypes.
5995 (display_prop_intangible_p): Update prototype.
5996 (compute_display_string_pos, compute_display_string_end):
5998 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6001 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6003 Malloc failure behavior now depends on size of allocation.
6004 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6005 * lisp.h: Change signatures accordingly.
6006 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6007 All callers changed. (Bug#8762)
6009 * gnutls.c: Use Emacs's memory allocators.
6010 Without this change, the gnutls library would invoke malloc etc.
6011 directly, which causes problems on non-SYNC_INPUT hosts, and which
6012 runs afoul of improving memory_full behavior. (Bug#8761)
6013 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6014 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6015 xfree instead of the default malloc, realloc, free.
6016 (Fgnutls_boot): No need to check for memory allocation failure,
6017 since xmalloc does that for us.
6019 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6020 * category.c (hash_get_category_set):
6021 * ccl.c (ccl_driver):
6022 * charset.c (Fdefine_charset_internal):
6023 * charset.h (struct charset.hash_index):
6024 * composite.c (get_composition_id, gstring_lookup_cache)
6025 (composition_gstring_put_cache):
6026 * composite.h (struct composition.hash_index):
6027 * dispextern.h (struct image.hash):
6028 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6029 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6030 (hashfn_equal, hashfn_user_defined, make_hash_table)
6031 (maybe_resize_hash_table, hash_lookup, hash_put)
6032 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6033 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6034 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6035 * image.c (make_image, search_image_cache, lookup_image)
6036 (xpm_put_color_table_h):
6037 * lisp.h (struct Lisp_Hash_Table):
6038 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6039 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6040 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6041 * alloc.c (allocate_vectorlike):
6042 Check for overflow in vector size calculations.
6043 * ccl.c (ccl_driver):
6044 Check for overflow when converting EMACS_INT to int.
6045 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6046 need to be updated by these changes.
6047 * fns.c (make_hash_table, maybe_resize_hash_table):
6048 Check for integer overflow with large hash tables.
6049 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6050 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6051 (SXHASH_REDUCE): New macro.
6052 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6053 Use it instead of discarding useful hash info with large hash values.
6054 (sxhash_float): New function.
6055 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6056 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6057 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6058 Rewrite to use FIXNUM_BITS, as this simplifies things.
6059 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6060 Adjust signatures to match updated version of code.
6061 (consing_since_gc): Now EMACS_INT, since a single hash table can
6062 use more than INT_MAX bytes.
6064 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6066 Make it possible to build with GCC-4.6+ -O2 -flto.
6068 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6070 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6072 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6073 Call minibuffer-inactive-mode.
6075 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6077 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6078 Update dependencies.
6080 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6082 * data.c (init_data): Remove code for UTS, this system is not
6085 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6087 Don't force ./temacs to start in terminal mode.
6089 * frame.c (make_initial_frame): Initialize faces in all cases, not
6090 only when CANNOT_DUMP is defined.
6091 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6093 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6095 * dispnew.c (add_window_display_history): Use const for the string
6096 pointer. Remove declaration, not needed.
6098 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6100 Use 'inline', not 'INLINE'.
6101 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6102 * alloc.c, fontset.c (INLINE): Remove.
6103 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6104 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6105 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6106 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6107 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6109 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6111 Make it possible to run ./temacs.
6113 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6114 syms_of_callproc does the same thing. Remove test for
6115 "initialized", do it in the caller.
6116 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6118 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6120 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6121 (read_minibuf): Use get_minibuffer.
6122 (syms_of_minibuf): Use DEFSYM.
6123 (Qmetadata): New var.
6124 * data.c (Qbuffer): Don't make it static.
6125 (syms_of_data): Use DEFSYM.
6127 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6129 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6130 (CCL_CODE_MIN): New macro.
6132 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6134 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6136 * eval.c (Qdebug): Now static.
6137 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6138 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6139 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6141 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6143 * image.c: Various fixes to ImageMagick code comments.
6144 (Fimagemagick_types): Doc fix.
6146 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6148 Minor fixes prompted by GCC 4.6.0 warnings.
6150 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6152 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6153 (x_clipboard_manager_save_all): Move extern decl to ...
6154 * xterm.h: ... here, so that it can be checked for consistency.
6156 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6158 * xselect.c (x_clipboard_manager_save_frame)
6159 (x_clipboard_manager_save_all): New functions.
6160 (Fx_clipboard_manager_save): Lisp function deleted.
6162 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6163 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6165 * xterm.h: Update prototype.
6167 2011-05-28 William Xu <william.xwl@gmail.com>
6169 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6172 2011-05-28 Jim Meyering <meyering@redhat.com>
6174 Avoid a sign-extension bug in crypto_hash_function.
6175 * fns.c (to_uchar): Define.
6176 (crypto_hash_function): Use it to convert some newly-signed
6177 variables to unsigned, to avoid sign-extension bugs. For example,
6178 without this change, (md5 "truc") would evaluate to
6179 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6180 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6181 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6183 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6185 Integer overflow fixes.
6187 * dbusbind.c: Serial number integer overflow fixes.
6188 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6189 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6190 to hold a serial number that is too large for a fixnum.
6191 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6192 Check for serial numbers out of range. Decode any serial number
6193 that was so large that it became a float. (Bug#8722)
6195 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6196 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6197 Use XFASTINT rather than XUINT when numbers are nonnegative.
6198 (xd_append_arg, Fdbus_method_return_internal):
6199 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6200 arguments, check that Lisp number is nonnegative, rather than
6201 silently wrapping negative numbers around. (Bug#8722)
6202 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6205 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6207 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6209 ccl: Add integer overflow checks.
6210 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6211 (IN_INT_RANGE): New macros.
6212 (ccl_driver): Use them to check for integer overflow when
6213 decoding a CCL program. Many of the new checks are whether XINT (x)
6214 fits in int; it doesn't always, on 64-bit hosts. The new version
6215 doesn't catch all possible integer overflows, but it's an
6216 improvement. (Bug#8719)
6218 * alloc.c (make_event_array): Use XINT, not XUINT.
6219 There's no need for unsigned here.
6221 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6222 This follows up to the 2011-05-06 change that substituted uintptr_t
6223 for EMACS_INT. This case wasn't caught back then.
6225 Rework Fformat to avoid integer overflow issues.
6226 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6227 now (part of C89). Include <verify.h>.
6228 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6229 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6230 (Fformat): Avoid the prepass trying to compute sizes; it was only
6231 approximate and thus did not catch overflow reliably. Instead, walk
6232 through the format just once, formatting and computing sizes as we go,
6233 checking for integer overflow at every step, and allocating a larger
6234 buffer as needed. Keep track separately whether the format is
6235 multibyte. Keep only the most-recently calculated precision, rather
6236 than them all. Record whether each argument has been converted to
6237 string. Use EMACS_INT, not int, for byte and char and arg counts.
6238 Support field widths and precisions larger than INT_MAX. Avoid
6239 sprintf's undefined behavior with conversion specifications such as %#d
6240 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6241 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6242 formatting out-of-range floating point numbers with int
6245 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6247 * data.c: Avoid integer truncation in expressions involving floats.
6248 * data.c: Include <intprops.h>.
6249 (arith_driver): When there's an integer overflow in an expression
6250 involving floating point, convert the integers to floating point
6251 so that the resulting value does not suffer from catastrophic
6252 integer truncation. For example, on a 64-bit host (* 4
6253 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6254 Do not rely on undefined behavior after integer overflow.
6256 merge count_size_as_multibyte, parse_str_to_multibyte
6257 * character.c, character.h (count_size_as_multibyte):
6258 Rename from parse_str_to_multibyte; all uses changed.
6259 Check for integer overflow.
6260 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6261 since it's now a duplicate of the other. This is more of
6262 a character than a buffer op, so better that it's in character.c.
6263 * fns.c, print.c: Adjust to above changes.
6265 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6267 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6269 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6271 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6272 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6273 (x_clipboard_manager_save): Now static.
6274 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6276 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6277 (crypto_hash_function): Now static.
6278 Fix pointer signedness problems. Avoid unnecessary initializations.
6280 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6282 * termhooks.h (Vselection_alist): Make it terminal-local.
6284 * terminal.c (create_terminal): Initialize it.
6286 * xselect.c: Support for clipboard managers.
6287 (Vselection_alist): Move to termhooks.h as terminal-local var.
6288 (LOCAL_SELECTION): New macro.
6289 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6290 (symbol_to_x_atom): Remove gratuitous arg.
6291 (x_handle_selection_request, lisp_data_to_selection_data)
6292 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6293 (x_own_selection, x_get_local_selection, x_convert_selection):
6294 New arg, specifying work frame. Use terminal-local Vselection_alist.
6295 (some_frame_on_display): Delete unused function.
6296 (Fx_own_selection_internal, Fx_get_selection_internal)
6297 (Fx_disown_selection_internal, Fx_selection_owner_p)
6298 (Fx_selection_exists_p): New optional frame arg.
6299 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6300 (x_handle_selection_clear): Don't treat other terminals with the
6301 same keyboard specially. Use the terminal-local Vselection_alist.
6302 (x_clear_frame_selections): Use Frun_hook_with_args.
6304 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6306 * xterm.h: Add support for those atoms.
6308 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6310 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6311 (converted_selections, conversion_fail_tag): New global variables.
6312 (x_selection_request_lisp_error): Free the above.
6313 (x_get_local_selection): Remove unnecessary code.
6314 (x_reply_selection_request): Args changed; handle arbitrary array
6315 of converted selections stored in converted_selections.
6316 Separate the XChangeProperty and SelectionNotify steps.
6317 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6318 (x_convert_selection): New function.
6319 (x_handle_selection_event): Simplify.
6320 (x_get_foreign_selection): Don't ignore incoming requests while
6321 waiting for an answer; this will fail when we implement
6322 SAVE_TARGETS, and seems unnecessary anyway.
6323 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6324 (Vx_sent_selection_functions): Doc fix.
6326 2011-05-26 Leo Liu <sdl.web@gmail.com>
6328 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6330 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6332 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6334 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6335 for fringe update if it has periodic bitmap.
6336 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6337 and fringe_bitmap_periodic_p.
6339 * fringe.c (get_fringe_bitmap_data): New function.
6340 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6341 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6342 row. Mark glyph row for fringe update if periodicity changed.
6344 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6345 for fringe update unless it has periodic bitmap.
6347 2011-05-25 Kenichi Handa <handa@m17n.org>
6349 * xdisp.c (get_next_display_element): Set correct it->face_id for
6350 a static composition.
6352 2011-05-24 Leo Liu <sdl.web@gmail.com>
6355 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6357 * fns.c (crypto_hash_function, Fsha1): New function.
6358 (Fmd5): Use crypto_hash_function.
6359 (syms_of_fns): Add Ssha1.
6361 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6363 * gnutls.c: Remove unused macros.
6364 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6365 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6366 Remove macros that are defined and never used.
6367 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6369 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6371 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6372 (Fx_get_selection_internal): Minor cleanup.
6373 (Fx_own_selection_internal): Rename arguments for consistency with
6376 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6378 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6380 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6382 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6384 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6386 * dispnew.c (scrolling_window): Don't exclude the case that the
6387 last enabled row in the desired matrix touches the bottom boundary.
6389 2011-05-21 Glenn Morris <rgm@gnu.org>
6391 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6392 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6393 and add some more files.
6395 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6397 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6398 report_file_error introduced by the change from 2011-05-07.
6400 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6402 * systime.h (Time): Define only if emacs is defined.
6403 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6404 where the include path doesn't have X11/X.h by default. See
6405 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6407 2011-05-20 Kenichi Handa <handa@m17n.org>
6409 * composite.c (find_automatic_composition): Fix previous change.
6411 2011-05-20 Glenn Morris <rgm@gnu.org>
6413 * lisp.mk: New file, split from Makefile.in.
6414 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6415 (shortlisp): Remove.
6416 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6418 2011-05-19 Glenn Morris <rgm@gnu.org>
6420 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6421 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6422 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6423 (lisp): Set the order to that of loadup.el.
6424 (shortlisp): Make it a copy of $lisp.
6425 (SOME_MACHINE_LISP): Remove.
6426 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6427 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6429 2011-05-18 Kenichi Handa <handa@m17n.org>
6431 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6432 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6433 (find_automatic_composition): Mostly rewrite for efficiency.
6435 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6437 * makefile.w32-in: Update dependencies.
6439 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6441 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6442 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6444 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6446 Fix some integer overflow issues, such as string length overflow.
6448 * insdel.c (count_size_as_multibyte): Check for string overflow.
6450 * character.c (lisp_string_width): Check for string overflow.
6451 Use EMACS_INT, not int, for string indexes and lengths; in
6452 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6453 the resulting string length overflows an EMACS_INT; instead,
6454 report a string overflow if no precision given. When checking for
6455 precision exhaustion, use a check that cannot possibly have
6456 integer overflow. (Bug#8675)
6457 * character.h (lisp_string_width): Adjust to new signature.
6459 * alloc.c (string_overflow): New function.
6460 (Fmake_string): Use it. This doesn't change behavior, but saves
6461 a few bytes and will simplify future changes.
6462 * character.c (string_escape_byte8): Likewise.
6463 * lisp.h (string_overflow): New decl.
6465 Fixups, following up to the user-interface timestamp change.
6466 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6467 for UI timestamps, instead of unsigned long.
6468 * msdos.c (mouse_get_pos): Likewise.
6469 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6470 * w32gui.h (Time): Define by including "systime.h" rather than by
6471 declaring it ourselves. (Bug#8664)
6473 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6474 * image.c (clear_image_cache): Likewise.
6476 * term.c (term_mouse_position): Don't assume time_t wraparound.
6478 Be more systematic about user-interface timestamps.
6479 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6480 and sometimes 'EMACS_UINT', to represent these timestamps.
6481 This change causes it to use 'Time' uniformly, as that's what X uses.
6482 This makes the code easier to follow, and makes it easier to catch
6483 integer overflow bugs such as Bug#8664.
6484 * frame.c (Fmouse_position, Fmouse_pixel_position):
6485 Use Time, not unsigned long, for user-interface timestamps.
6486 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6487 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6488 * keyboard.h (last_event_timestamp): Likewise.
6489 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6490 * menu.h (xmenu_show): Likewise.
6491 * term.c (term_mouse_position): Likewise.
6492 * termhooks.h (struct input_event.timestamp): Likewise.
6493 (struct terminal.mouse_position_hook): Likewise.
6494 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6495 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6496 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6497 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6499 * menu.h, termhooks.h: Include "systime.h", for Time.
6501 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6502 Don't assume that the difference between two unsigned long values
6503 can fit into an integer. At this point, we know button_down_time
6504 <= event->timestamp, so the difference must be nonnegative, so
6505 there's no need to cast the result if double-click-time is
6506 nonnegative, as it should be; check that it's nonnegative, just in
6507 case. This bug is triggered when events are more than 2**31 ms
6508 apart (about 25 days). (Bug#8664)
6510 * xselect.c (last_event_timestamp): Remove duplicate decl.
6511 (x_own_selection): Remove needless cast to unsigned long.
6513 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6514 that always fit in int. Use a sentinel instead of a counter, to
6515 avoid a temp and to allay GCC's concerns about possible int overflow.
6516 * frame.h (struct frame): Use int for menu_bar_items_used
6517 instead of EMACS_INT, since it always fits in int.
6519 * menu.c (grow_menu_items): Check for int overflow.
6521 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6523 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6524 Before, the code was not consistent. These values cannot exceed
6525 2**31 - 1 so there's no need to make them unsigned.
6526 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6527 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6528 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6530 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6532 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6533 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6534 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6535 presumably because the widths might not match.
6537 * window.c (size_window): Avoid needless test at loop start.
6539 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6541 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6543 2011-05-12 Drew Adams <drew.adams@oracle.com>
6545 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6547 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6549 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6550 `width' to `bar_area_x' and `bar_area_width', respectively.
6551 (x_scroll_run): Take account of fringe background extension.
6553 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6554 Rename local vars `left' and `width' to `bar_area_x' and
6555 `bar_area_width', respectively.
6556 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6557 background extension.
6559 2011-05-10 Jim Meyering <meyering@redhat.com>
6561 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6563 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6565 * image.c (Finit_image_library): Return t for built-in image types,
6566 like pbm and xbm. (Bug#8640)
6568 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6570 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6572 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6574 * w32console.c (Fset_screen_color): Doc fix.
6575 (Fget_screen_color): New function.
6576 (syms_of_ntterm): Defsubr it.
6578 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6579 unlink the temporary file if Fcall_process didn't create it in the
6581 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6582 child process will be redirected to a file specified with `:file'.
6583 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6584 cue to call_process_cleanup not to close that handle.
6586 2011-05-07 Ben Key <bkey76@gmail.com>
6588 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6589 one of two shell specific rules, either bootstrap-temacs-CMD or
6590 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6591 to the previous implementation of the bootstrap-temacs rule.
6592 The bootstrap-temacs-CMD rule is similar to the previous
6593 implementation of the bootstrap-temacs rule except that it
6594 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6597 These changes, along with some changes to nt/configure.bat,
6598 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6599 earlier fix to add support for --cflags and --ldflags options
6600 that include quotes so that it works whether make uses cmd or
6603 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6605 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6606 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6608 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6609 a string. Handle both cases.
6610 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6611 (Fdbus_register_method): Use Qinvalid_function.
6613 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6615 * makefile.w32-in: Update dependencies.
6616 (LISP_H): Add inttypes.h and stdin.h.
6617 (PROCESS_H): Add unistd.h.
6619 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6621 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6622 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6624 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6626 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6628 * term.c (vfatal): Remove stray call to va_end.
6629 It's not needed and the C Standard doesn't allow it here anyway.
6631 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6632 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6634 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6637 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6639 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6641 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6643 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6645 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6647 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6648 * charset.c (Fdefine_charset_internal): Don't initialize
6649 charset.code_space[15]. The value was garbage, on hosts with
6650 32-bit int (Bug#8600).
6652 * lread.c (read_integer): Be more consistent with string-to-number.
6653 Use string_to_number to do the actual conversion; this avoids
6654 rounding errors and fixes some other screwups. Without this fix,
6655 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6656 (digit_to_number): Move earlier, for benefit of read_integer.
6657 Return -1 if the digit is out of range for the base, -2 if it is
6658 not a digit in any supported base. (Bug#8602)
6660 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6662 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6663 to match comment at start of function. This also removes a
6664 GCC warning about overflow in a 32+64-bit port.
6666 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6668 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6669 Reported by Stefan Monnier in
6670 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6671 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6672 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6674 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6675 (EMACS_UINTPTR): Likewise, with uintptr_t.
6677 * lisp.h: Prefer 64-bit EMACS_INT if available.
6678 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6679 on 32-bit hosts that have 64-bit int, so that they can access
6681 However, temporarily disable this change unless the temporary
6682 symbol WIDE_EMACS_INT is defined.
6684 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6686 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6687 This removes an assumption that EMACS_INT and long are the same
6688 width as pointers. The assumption is true for Emacs porting targets
6689 now, but we want to make other targets possible.
6690 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6691 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6692 In the rest of the code, change types of integers that hold casted
6693 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6694 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6695 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6696 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6697 No need to cast type when ORing.
6698 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6699 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6700 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6701 assume EMACS_INT is the same width as char *.
6702 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6703 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6704 Remove no-longer-needed casts.
6705 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6706 (xg_tool_bar_help_callback, xg_make_tool_item):
6707 Use EMACS_INTPTR to hold an integer
6708 that will be cast to void *; this can avoid a GCC warning
6709 if EMACS_INT is not the same width as void *.
6710 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6711 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6712 (current_message_1, set_message_1):
6713 Use a local to convert to proper width without a cast.
6714 * xmenu.c (dialog_selection_callback): Likewise.
6716 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6717 Also, don't assume VALBITS / RAND_BITS is less than 5,
6718 and don't rely on undefined behavior when shifting a 1 left into
6720 * lisp.h (get_random): Change signature to match.
6722 * lread.c (hash_string): Use size_t, not int, for hash computation.
6723 Normally we prefer signed values; but hashing is special, because
6724 it's better to use unsigned division on hash table sizes so that
6725 the remainder is nonnegative. Also, size_t is the natural width
6726 for hashing into memory. The previous code used 'int', which doesn't
6727 retain enough info to hash well into very large tables.
6728 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6730 * dbusbind.c: Don't possibly lose pointer info when converting.
6731 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6732 Use XPNTR rather than XHASH, so that the high-order bits of
6733 the pointer aren't lost when converting through void *.
6735 * eval.c (Fautoload): Don't double-shift a pointer.
6737 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6739 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6741 * gnutls.c (DEF_GNUTLS_FN):
6742 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6744 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6746 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6749 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6751 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6752 New version that can reserve upto 2GB of heap space.
6754 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6756 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6758 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6760 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6761 `gnutls_certificate_set_x509_key_file'.
6763 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6765 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6766 Update dependencies.
6768 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6770 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6771 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6772 Remove unused parameter `fildes'.
6773 * process.c (read_process_output, send_process): Don't pass it.
6775 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6777 Fix previous change: the library cache is defined in w32.c.
6778 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6779 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6781 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6783 Implement dynamic loading of GnuTLS on Windows.
6785 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6786 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6787 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6790 * gnutls.c (Qgnutls_dll): Define.
6791 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6792 (gnutls_*): Declare function pointers.
6793 (init_gnutls_functions): New function to initialize function pointers.
6794 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6795 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6796 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6797 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6798 (emacs_gnutls_write, emacs_gnutls_read)
6799 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6800 (Fgnutls_available_p): New function.
6801 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6802 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6803 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6805 * image.c: Include w32.h.
6806 (Vimage_type_cache): Delete.
6807 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6808 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6809 (w32_delayed_load): Move to w32.c.
6811 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6813 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6814 (w32_delayed_load): Move from image.c. When loading a library, record
6815 its filename in the :loaded-from property of the library id.
6816 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6817 Initialize and staticpro them.
6818 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6820 * process.c: Include lisp.h before w32.h, not after.
6821 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6822 instead of gnutls_record_check_pending.
6824 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6826 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6828 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6829 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6832 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6834 * xterm.c (x_set_frame_alpha): Do not set property on anything
6835 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6837 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6839 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6841 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6843 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6844 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6845 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6846 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6847 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6848 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6849 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6850 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6851 (Qgnutls_bootprop_callbacks_verify): Make static.
6853 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6855 * callproc.c: Indentation fixup.
6857 * sysdep.c (wait_for_termination_1): Make static.
6858 (wait_for_termination, interruptible_wait_for_termination):
6859 Move after wait_for_termination_1.
6861 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6863 * sysdep.c (interruptible_wait_for_termination): New function
6864 which is like wait_for_termination, but allows keyboard
6867 * callproc.c (Fcall_process): Add (:file "file") as an option for
6869 (Fcall_process_region): Ditto.
6871 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6873 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6874 rather than `XVECTOR (FOO)->size'.
6876 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6877 inttypes.h, as a gnulib replacement is used if it not available in
6880 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6882 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6883 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6884 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6886 * coding.c (coding_alloc_by_realloc): Error out if destination
6887 will grow beyond MOST_POSITIVE_FIXNUM.
6888 (decode_coding_emacs_mule): Abort if there isn't enough place in
6889 charbuf for the composition carryover bytes. Reserve an extra
6890 space for up to 2 characters produced in a loop.
6891 (decode_coding_iso_2022): Abort if there isn't enough place in
6892 charbuf for the composition carryover bytes.
6894 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6896 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6897 aborting when %lld or %lll format is passed.
6898 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6899 %llo or %llx format is passed. (Bug#8545)
6901 * window.c (window_scroll_line_based): Use a marker instead of
6902 simple variables to record original value of point. (Bug#7952)
6904 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6905 produced by %s or %c overflows available buffer space. (Bug#8545)
6907 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6909 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6910 (SIZE_MAX): Move defn after all includes, as they might #define it.
6912 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6914 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6916 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6918 * keyboard.c (Qdelayed_warnings_hook): Define.
6919 (command_loop_1): Run `delayed-warnings-hook'
6920 if Vdelayed_warnings_list is non-nil.
6921 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6922 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6924 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6926 * doprnt.c (doprnt): Don't return value smaller than the buffer
6927 size if the message was truncated. (Bug#8545).
6929 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6931 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6932 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6934 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6936 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6938 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6940 * makefile.w32-in: Update dependencies.
6942 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6944 Improve `doprnt' and its usage. (Bug#8545)
6945 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6946 `format_end'. Remove support for %l as a conversion specifier.
6947 Don't use xrealloc. Improve diagnostics when the %l size modifier
6948 is used. Update the commentary.
6950 * eval.c (verror): Simplify calculation of size_t.
6952 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6955 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6957 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6960 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6962 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6963 This makes this file independent of the recent pseudovector change.
6965 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6967 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6969 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6970 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6971 Remove unused local.
6972 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6974 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6975 GCC 4.6.0 optimizes based on type-based alias analysis.
6976 For example, if b is of type struct buffer * and v of type struct
6977 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6978 != &v->size, and therefore "v->size = 1; b->size = 2; return
6979 v->size;" must therefore return 1. This assumption is incorrect
6980 for Emacs, since it type-puns struct Lisp_Vector * with many other
6981 types. To fix this problem, this patch adds a new type struct
6982 vectorlike_header that documents the constraints on layout of vectors
6983 and pseudovectors, and helps optimizing compilers not get fooled
6984 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6985 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6986 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6988 (XSETPVECTYPE): Rewrite in terms of new macro.
6989 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6990 This is a bit clearer, and further avoids the possibility of
6991 undesirable aliasing.
6992 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6993 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6994 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6995 since Lisp_Subr is a special case (no "next" field).
6996 (ASIZE): Now uses header.size rather than size.
6997 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6998 to avoid the hassle of writing XVECTOR (foo)->header.size.
6999 (struct vectorlike_header): New type.
7000 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7001 object, to help avoid aliasing.
7002 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7003 (SUBRP): Likewise, since Lisp_Subr is a special case.
7004 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7005 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7006 (struct Lisp_Hash_Table): Combine first two members into a single
7007 struct vectorlike_header member. All uses of "size" and "next" members
7008 changed to be "header.size" and "header.next".
7009 * buffer.h (struct buffer): Likewise.
7010 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7011 * frame.h (struct frame): Likewise.
7012 * process.h (struct Lisp_Process): Likewise.
7013 * termhooks.h (struct terminal): Likewise.
7014 * window.c (struct save_window_data, struct saved_window): Likewise.
7015 * window.h (struct window): Likewise.
7016 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7017 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7018 * buffer.c (init_buffer_once): Likewise.
7019 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7021 * process.c (Fformat_network_address): Use local var for size,
7024 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7026 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7027 * data.c (atof): Remove decl; no longer used or needed.
7028 (digit_to_number): Move to lread.c.
7029 (Fstring_to_number): Use new string_to_number function, to be
7030 consistent with how the Lisp reader treats infinities and NaNs.
7031 Do not assume that floating-point numbers represent EMACS_INT
7032 without losing information; this is not true on most 64-bit hosts.
7033 Avoid double-rounding errors, by insisting on integers when
7034 parsing non-base-10 numbers, as the documentation specifies.
7035 * lisp.h (string_to_number): New decl, replacing ...
7036 (isfloat_string): Remove.
7037 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7038 (read1): Do not accept +. and -. as integers; this
7039 appears to have been a coding error. Similarly, do not accept
7040 strings like +-1e0 as floating point numbers. Do not report
7041 overflow for integer overflows unless the base is not 10 which
7042 means we have no simple and reliable way to continue.
7043 Break out the floating-point parsing into a new
7044 function string_to_number, so that Fstring_to_number parses
7045 floating point numbers consistently with the Lisp reader.
7046 (digit_to_number): Move here from data.c. Make it static inline.
7047 (E_CHAR, EXP_INT): Remove, replacing with ...
7048 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7049 (string_to_number): New function, replacing isfloat_string.
7050 This function checks for valid syntax and produces the resulting
7051 Lisp float number too. Rework it so that string-to-number
7052 no longer mishandles examples like "1.0e+". Use strtoumax,
7053 so that overflow for non-base-10 numbers is reported only when
7054 there's no portable and simple way to convert to floating point.
7056 * textprop.c (set_text_properties_1): Rewrite for clarity,
7057 and to avoid GCC warning about integer overflow.
7059 * intervals.h (struct interval): Use EMACS_INT for members
7060 where EMACS_UINT might cause problems. See
7061 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7062 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7063 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7065 (offset_intervals): Tell GCC not to worry about length overflow
7066 when negating a negative length.
7068 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7069 (overrun_check_free): Likewise.
7071 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7072 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7075 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7076 (gnutls_make_error): Rename local to avoid shadowing.
7077 (gnutls_emacs_global_deinit): ifdef out; not used.
7078 (Fgnutls_boot): Use const for pointer to readonly storage.
7079 Comment out unused local. Fix pointer signedness problems.
7081 * lread.c (openp): Don't stuff size_t into an 'int'.
7082 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7083 about possible signed overflow.
7085 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7086 (GDK_KEY_g): Don't define if already defined.
7087 (xg_prepare_tooltip): Avoid pointer signedness problem.
7088 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7090 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7091 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7093 * xfns.c (Fx_window_property): Simplify a bit,
7094 to make a bit faster and to avoid GCC 4.6.0 warning.
7095 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7097 * fns.c (internal_equal): Don't assume size_t fits in int.
7099 * alloc.c (compact_small_strings): Tighten assertion a little.
7101 Replace pEd with more-general pI, and fix some printf arg casts.
7102 * lisp.h (pI): New macro, generalizing old pEd macro to other
7103 conversion specifiers. For example, use "...%"pI"d..." rather
7104 than "...%"pEd"...".
7105 (pEd): Remove. All uses replaced with similar uses of pI.
7106 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7107 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7108 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7109 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7110 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7111 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7112 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7114 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7115 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7116 * print.c (safe_debug_print, print_object): Likewise.
7117 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7119 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7120 avoiding the 0 flag, which is not portable.
7121 * process.c (Fmake_network_process): Use pI to avoid cast.
7122 * region-cache.c (pp_cache): Likewise.
7123 * xdisp.c (decode_mode_spec): Likewise.
7124 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7125 behavior on 64-bit hosts with printf arg.
7126 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7127 (x_stop_queuing_selection_requests): Likewise.
7128 (x_get_window_property): Don't truncate byte count to an 'int'
7131 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7132 here, since it parses constructs like leading '-' and spaces,
7133 which are not wanted; and it overflows with large numbers.
7134 Instead, simply match F[0-9]+, which is what is wanted anyway.
7136 * alloc.c: Remove unportable assumptions about struct layout.
7137 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7138 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7139 (allocate_vectorlike, make_pure_vector): Use the new macros,
7140 plus offsetof, to remove unportable assumptions about struct layout.
7141 These assumptions hold on all porting targets that I know of, but
7142 they are not guaranteed, they're easy to remove, and removing them
7143 makes further changes easier.
7145 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7146 This doesn't fix a bug but makes the code clearer.
7147 (string_overrun_cookie): Now const. Use initializers that
7148 don't formally overflow signed char, to avoid warnings.
7149 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7150 can cause Emacs to crash when string overrun checking is enabled.
7151 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7152 multiple of sizeof (EMACS_INT); it need not be, if
7153 alignof(EMACS_INT) < sizeof (EMACS_INT).
7154 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7156 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7158 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7160 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7162 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7163 supposed to be handshaking. (Bug#8556)
7164 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7166 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7168 * lisp.h (Qdebug): List symbol.
7169 * eval.c (Qdebug): Restore global linkage.
7170 * keyboard.c (debug-on-event): New variable.
7171 (handle_user_signal): Break into debugger when debug-on-event
7172 matches the current signal symbol.
7174 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7176 * alloc.c (check_sblock, check_string_bytes)
7177 (check_string_free_list): Convert to standard C.
7179 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7181 * w32.c (emacs_gnutls_push): Fix typo.
7183 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7185 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7186 "cast to pointer from integer of different size".
7188 Improve doprnt and its use in verror. (Bug#8545)
7189 * doprnt.c (doprnt): Document the set of format control sequences
7190 supported by the function. Use SAFE_ALLOCA instead of always
7193 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7194 is one byte too soon. Don't use xrealloc; instead xfree and
7197 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7199 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7202 * gnutls.c: Renamed global_initialized to
7203 gnutls_global_initialized. Added internals for the
7204 :verify-hostname-error, :verify-error, and :verify-flags
7205 parameters of `gnutls-boot' and documented those parameters in the
7206 docstring. Start callback support.
7207 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7208 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7209 on error. Return error code.
7210 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7211 (emacs_gnutls_read): Likewise.
7212 (Fgnutls_boot): Return handshake error code.
7213 (emacs_gnutls_handle_error): New function.
7214 (wsaerror_to_errno): Likewise.
7216 * w32.h (emacs_gnutls_pull): Add prototype.
7217 (emacs_gnutls_push): Likewise.
7219 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7220 (emacs_gnutls_push): Likewise.
7222 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7224 * process.c (wait_reading_process_output): Check if GnuTLS
7225 buffered some data internally if no FDs are set for TLS
7228 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7229 (LIBS): Link to USER_LIBS.
7230 ($(BLD)/gnutls.$(0)): New target.
7232 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7234 * xdisp.c (handle_single_display_spec): Rename the
7235 display_replaced_before_p argument into display_replaced_p, to
7236 make it consistent with the commentary. Fix typos in the
7239 * textprop.c (syms_of_textprop): Remove dead code.
7240 (copy_text_properties): Delete obsolete commentary about an
7241 interface that was deleted long ago. Fix typos in the description
7244 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7245 to changes in oldXMenu/XMenu.h from 2011-04-16.
7246 <menu_help_message, prev_menu_help_message>: Constify.
7247 (IT_menu_make_room): menu->help_text is now `const char **';
7250 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7251 to changes in oldXMenu/XMenu.h from 2011-04-16.
7252 (struct XMenu): Declare `help_text' `const char **'.
7254 * xfaces.c <Qunspecified>: Make extern again.
7256 * syntax.c: Include sys/types.h before including regex.h, as
7259 * doc.c (get_doc_string): Improve the format passed to `error'.
7261 * doprnt.c (doprnt): Improve commentary.
7263 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7265 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7268 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7269 changes in globals.h immediately force recompilation.
7270 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7271 $(CURDIR)/s/ms-w32.h.
7272 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7274 * character.c (Fchar_direction): Function deleted.
7275 (syms_of_character): Don't defsubr it.
7276 <char-direction-table>: Deleted.
7278 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7280 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7281 * doprnt.c: Include limits.h.
7282 (SIZE_MAX): New macro.
7283 (doprnt): Return a size_t value. 2nd arg is now size_t.
7284 Many local variables are now size_t instead of int or unsigned.
7285 Improve overflow protection. Support `l' modifier for integer
7286 conversions. Support %l conversion. Don't assume an EMACS_INT
7287 argument for integer conversions and for %c.
7289 * lisp.h (doprnt): Restore prototype.
7291 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7294 * Makefile.in (base_obj): Add back doprnt.o.
7296 * deps.mk (doprnt.o): Add back prerequisites.
7297 (callint.o): Depend on character.h.
7299 * eval.c (internal_lisp_condition_case): Include the handler
7300 representation in the error message.
7301 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7302 when breaking from the loop.
7304 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7306 * callint.c (Fcall_interactively): When displaying error message
7307 about invalid control letter, pass the character's codepoint, not
7308 a pointer to its multibyte form. Improve display of the character
7309 in octal and display also its hex code.
7311 * character.c (char_string): Use %x to display the (unsigned)
7312 codepoint of an invalid character, to avoid displaying a bogus
7315 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7316 `error', not SYMBOL_NAME itself.
7318 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7319 character arguments to `error'.
7321 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7322 to `error' in error message about FINAL_CHAR argument. Make sure
7323 FINAL_CHAR is a character, and use %c when it is passed as
7324 argument to `error'.
7326 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7328 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7330 * w32.c: Include <time.h>.
7331 (sys_localtime): New function.
7333 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7335 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7337 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7339 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7341 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7344 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7346 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7347 gl_state.e_property when gl_state.object is Qt.
7349 * insdel.c (make_gap_larger): Remove limitation of buffer size
7352 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7354 * xdisp.c (lookup_glyphless_char_display)
7355 (produce_glyphless_glyph): Handle cons cell entry in
7356 glyphless-char-display.
7357 (Vglyphless_char_display): Document it.
7359 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7360 glyphless-char-display.
7362 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7364 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7366 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7368 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7369 definition for no-X builds.
7371 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7373 Static checks with GCC 4.6.0 and non-default toolkits.
7375 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7377 * process.c (keyboard_bit_set): Define only if SIGIO.
7378 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7379 (send_process): Repair possible setjmp clobbering.
7381 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7383 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7385 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7387 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7388 Define only if needed.
7390 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7391 by pacifying GCC about it. Maybe it's time to retire it?
7392 * xfaces.c (USG, __TIMEVAL__): Likewise.
7394 * dispextern.h (struct redisplay_interface): Rename param
7396 * termhooks.h (struct terminal): Likewise.
7397 * xterm.c (xembed_send_message): Likewise.
7399 * insdel.c (make_gap_smaller): Define only if
7400 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7402 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7405 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7406 so that we aren't warned about unused symbols.
7408 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7410 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7412 * xfns.c (x_real_positions): Mark locals as initialized.
7414 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7416 * xterm.c: Fix problems found by static analysis with other toolkits.
7417 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7418 (x_dispatch_event): Declare static if USE_GTK, and
7419 define if USE_GTK || USE_X_TOOLKIT.
7420 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7421 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7422 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7423 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7425 * xmenu.c (menu_help_callback): Pointer type fixes.
7426 Use const pointers when pointing at readonly data. Avoid pointer
7428 (FALSE): Remove unused macro.
7429 (update_frame_menubar): Remove unused decl.
7431 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7433 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7434 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7435 (single_menu_item): Rename local to avoid shadowing.
7437 * keyboard.c (make_lispy_event): Remove unused local var.
7439 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7440 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7442 * bitmaps: Change bitmaps from unsigned char back to the X11
7443 compatible char. Avoid the old compiler warnings about
7444 out-of-range initializers by using, for example, '\xab' rather
7447 * xgselect.c (xgselect_initialize): Check vs interface
7448 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7450 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7452 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7453 to read-only memory.
7455 * fns.c (vector): Remove; this old hack is no longer needed.
7457 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7459 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7461 * xrdb.c (x_load_resources): Omit unused local.
7463 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7464 (x_window): Rename locals to avoid shadowing.
7465 (USG): Use the kludged USG macro, to pacify gcc.
7467 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7468 (x_term_init): Remove local to avoid shadowing.
7470 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7472 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7473 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7475 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7477 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7479 Fix regex.c, syntax.c and friends for buffers > 2GB.
7480 * syntax.h (struct gl_state_s): Declare character position members
7483 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7485 * textprop.c (verify_interval_modification, interval_of):
7486 Declare arguments EMACS_INT.
7488 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7491 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7493 * indent.c (Fvertical_motion): Local variable it_start is now
7496 * regex.c (re_match, re_match_2, re_match_2_internal)
7497 (bcmp_translate, regcomp, regexec, print_double_string)
7498 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7499 (re_compile_pattern, re_exec): Declare arguments and local
7500 variables `size_t' and `ssize_t' and return values `regoff_t', as
7502 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7503 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7504 <compile_stack_type>: `size' and `avail' are now `size_t'.
7506 * regex.h <regoff_t>: Use ssize_t, not int.
7507 (re_search, re_search_2, re_match, re_match_2): Arguments that
7508 specify buffer/string position and length are now ssize_t and
7509 size_t. Return type is regoff_t.
7511 2011-04-16 Ben Key <bkey76@gmail.com>
7513 * nsfont.m: Fixed bugs in ns_get_family and
7514 ns_descriptor_to_entity that were caused by using free to
7515 deallocate memory blocks that were allocated by xmalloc (via
7516 xstrdup). This caused Emacs to crash when compiled with
7517 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7518 --enable-checking=xmallocoverrun). xfree is now used to
7519 deallocate these memory blocks.
7521 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7523 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7525 emacs_write: Accept and return EMACS_INT for sizes.
7526 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7528 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7529 Accept and return EMACS_INT.
7530 (emacs_gnutls_write): Return the number of bytes written on
7532 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7533 (emacs_read, emacs_write): Remove check for negative size, as the
7534 Emacs source code has been audited now.
7535 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7536 (emacs_read, emacs_write): Use it.
7537 * process.c (send_process): Adjust to the new signatures of
7538 emacs_write and emacs_gnutls_write. Do not attempt to store
7539 a byte offset into an 'int'; it might overflow.
7540 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7542 * sound.c: Don't assume sizes fit in 'int'.
7543 (struct sound_device.period_size, alsa_period_size):
7544 Return EMACS_INT, not int.
7545 (struct sound_device.write, vox_write, alsa_write):
7546 Accept EMACS_INT, not int.
7547 (wav_play, au_play): Use EMACS_INT to store sizes and to
7548 record read return values.
7550 2011-04-15 Ben Key <bkey76@gmail.com>
7552 * keyboard.c (Qundefined): Don't declare static since it is used
7554 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7555 static since they are used in nsfont.m.
7557 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7559 * process.c (Qprocessp): Don't declare static.
7560 * lisp.h (Qprocessp): Declare again.
7562 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7564 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7566 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7568 Improve C-level modularity by making more things 'static'.
7570 Don't publish debugger-only interfaces to other modules.
7571 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7572 (verify_bytepos, count_markers): Move decls to the only modules
7574 * region-cache.h (pp_cache): Likewise.
7575 * window.h (check_all_windows): Likewise.
7576 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7578 * sysdep.c (croak): Now static, if
7579 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7580 * syssignal.h (croak): Declare only if not static.
7582 * alloc.c (refill_memory_reserve): Now static if
7583 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7584 * lisp.h (refill_memory_reserve): Declare only if not static.
7586 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7587 Define only if USE_LUCID.
7589 * xrdb.c (x_customization_string, x_rm_string): Now static.
7591 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7592 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7594 * xdisp.c (draw_row_with_mouse_face): Now static.
7595 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7597 * window.h (check_all_windows): Mark externally visible.
7599 * window.c (window_deletion_count): Now static.
7601 * undo.c: Make symbols static if they're not exported.
7602 (last_undo_buffer, last_boundary_position, pending_boundary):
7605 * textprop.c (interval_insert_behind_hooks): Now static.
7606 (interval_insert_in_front_hooks): Likewise.
7608 * term.c: Make symbols static if they're not exported.
7609 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7610 (max_frame_lines, tty_set_terminal_modes):
7611 (tty_reset_terminal_modes, tty_turn_off_highlight):
7612 (get_tty_terminal): Now static.
7613 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7614 * termhooks.h (term_mouse_moveto): Do not declare if
7616 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7617 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7619 * sysdep.c: Make symbols static if they're not exported.
7620 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7622 (sigprocmask_set, full_mask): Remove; unused.
7623 (wait_debugging): Mark as visible.
7624 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7625 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7627 * syntax.c (syntax_temp): Define only if !__GNUC__.
7629 * sound.c (current_sound_device, current_sound): Now static.
7631 * search.c (searchbufs, searchbuf_head): Now static.
7633 * scroll.c (scroll_cost): Remove; unused.
7634 * dispextern.h (scroll_cost): Remove decl.
7636 * region-cache.h (pp_cache): Mark as externally visible.
7638 * process.c: Make symbols static if they're not exported.
7639 (process_tick, update_tick, create_process, chan_process):
7640 (Vprocess_alist, proc_buffered_char, datagram_access):
7641 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7642 (deactivate_process): Mark defn as static, as well as decl.
7643 * lisp.h (create_process): Remove decl.
7644 * process.h (chan_process, Vprocess_alist): Remove decls.
7646 * print.c: Make symbols static if they're not exported.
7647 (print_depth, new_backquote_output, being_printed, print_buffer):
7648 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7649 (print_interval, print_number_index, initial_stderr_stream):
7651 * lisp.h (Fprinc): Remove decl.
7652 (debug_output_compilation_hack): Mark as externally visible.
7654 * sysdep.c (croak): Move decl from here to syssignal.h.
7655 * syssignal.h (croak): Put it here, so the API can be checked when
7656 'croak' is called from dissociate_if_controlling_tty.
7658 * minibuf.c: Make symbols static if they're not exported.
7659 (minibuf_save_list, choose_minibuf_frame): Now static.
7660 * lisp.h (choose_minibuf_frame): Remove decl.
7662 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7664 * lread.c: Make symbols static if they're not exported.
7665 (read_objects, initial_obarray, oblookup_last_bucket_number):
7667 (make_symbol): Remove; unused.
7668 * lisp.h (initial_obarray, make_symbol): Remove decls.
7670 * keyboard.c: Make symbols static if they're not exported.
7671 (single_kboard, recent_keys_index, total_keys, recent_keys):
7672 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7673 (this_single_command_key_start, echoing, last_auto_save):
7674 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7675 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7676 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7677 (Vlispy_mouse_stem, double_click_count):
7679 (force_auto_save_soon): Define only if SIGDANGER.
7680 (ignore_mouse_drag_p): Now static if
7681 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7682 (print_help): Remove; unused.
7683 (stop_character, last_timer_event): Mark as externally visible.
7684 * keyboard.h (ignore_mouse_drag_p): Declare only if
7685 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7686 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7687 * lisp.h (echoing): Remove decl.
7688 (force_auto_save_soon): Declare only if SIGDANGER.
7689 * xdisp.c (redisplay_window): Simplify code, to make it more
7690 obvious that ignore_mouse_drag_p is not accessed if !defined
7691 USE_GTK && !defined HAVE_NS.
7693 * intervals.c: Make symbols static if they're not exported.
7694 (merge_properties_sticky, merge_interval_right, delete_interval):
7696 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7698 * insdel.c: Make symbols static if they're not exported.
7699 However, leave prepare_to_modify_buffer alone. It's never
7700 called from outside this function, but that appears to be a bug.
7701 (combine_after_change_list, combine_after_change_buffer):
7702 (adjust_after_replace, signal_before_change): Now static.
7703 (adjust_after_replace_noundo): Remove; unused.
7704 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7705 (signal_before_change): Remove decls.
7707 * indent.c (val_compute_motion, val_vmotion): Now static.
7709 * image.c: Make symbols static if they're not exported.
7710 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7712 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7713 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7715 * fringe.c (standard_bitmaps): Now static.
7716 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7718 * frame.c: Make symbols static if they're not exported.
7719 (x_report_frame_params, make_terminal_frame): Now static.
7720 (get_frame_param): Now static, unless HAVE_NS.
7721 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7722 (x_get_resource_string): Remove; not used.
7723 * frame.h (make_terminal_frame, x_report_frame_params):
7724 (x_get_resource_string); Remove decls.
7725 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7726 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7728 * font.c, fontset.c: Make symbols static if they're not exported.
7729 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7730 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7731 * font.c (font_close_object): Now static.
7732 * font.h (font_close_object): Remove.
7733 * fontset.c (FONTSET_OBJLIST): Remove.
7734 (free_realized_fontset) #if-0 the body, which does nothing.
7735 (face_suitable_for_char_p): #if-0, as it's never called.
7736 * fontset.h (face_suitable_for_char_p): Remove decl.
7737 * xfaces.c (face_at_string_position):
7738 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7739 since 0 is always ASCII.
7741 * fns.c (weak_hash_tables): Now static.
7743 * fileio.c: Make symbols static if they're not exported.
7744 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7745 (Vwrite_region_annotation_buffers): Now static.
7747 * eval.c: Make symbols static if they're not exported.
7748 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7749 * lisp.h (backtrace_list): Remove decl.
7751 * emacs.c: Make symbols static if they're not exported.
7752 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7753 (fatal_error_code, fatal_error_signal_hook, standard_args):
7755 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7756 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7757 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7758 * lisp.h (fatal_error_signal_hook): Remove decl.
7759 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7761 * editfns.c: Move a (normally-unused) function to its only use.
7762 * editfns.c, lisp.h (get_operating_system_release): Remove.
7763 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7764 worth the hassle of breaking this out.
7766 * xterm.c: Make symbols static if they're not exported.
7767 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7768 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7769 (x_destroy_window, x_delete_display):
7771 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7772 (x_mouse_leave): Remove; unused.
7773 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7774 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7775 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7777 (x_mouse_leave): Declare only if WINDOWSNT.
7778 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7779 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7782 * ftxfont.c: Make symbols static if they're not exported.
7783 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7785 * font.h (ftxfont_driver): Likewise.
7787 * xfns.c: Make symbols static if they're not exported.
7788 (x_last_font_name, x_display_info_for_name):
7789 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7790 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7791 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7792 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7793 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7794 (last_show_tip_args): Now static.
7795 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7796 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7797 (x_screen_planes): Remove; unused.
7798 * dispextern.h (x_screen_planes): Remove decl.
7800 * dispnew.c: Make symbols static if they're not exported.
7801 * dispextern.h (redraw_garbaged_frames, scrolling):
7802 (increment_row_positions): Remove.
7803 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7804 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7806 (redraw_garbaged_frames): Remove; unused.
7808 * xfaces.c: Make symbols static if they're not exported.
7809 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7811 * xterm.h (defined_color): Remove decls.
7812 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7813 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7814 (menu_face_changed_default, defined_color, free_realized_face):
7815 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7816 (ascii_face_of_lisp_face): Remove; unused.
7818 * xdisp.c: Make symbols static if they're not exported.
7819 * dispextern.h (scratch_glyph_row, window_box_edges):
7820 (glyph_to_pixel_coords, set_cursor_from_row):
7821 (get_next_display_element, set_iterator_to_next):
7822 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7823 (show_mouse_face): Remove decls
7824 * frame.h (message_buf_print): Likewise.
7825 * lisp.h (pop_message, set_message, check_point_in_composition):
7827 * xterm.h (set_vertical_scroll_bar): Likewise.
7828 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7829 (message_buf_print, scratch_glyph_row, displayed_buffer):
7830 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7831 (get_next_display_element, show_mouse_face, window_box_edges):
7832 (frame_to_window_pixel_xy, check_point_in_composition):
7833 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7834 (glyph_to_pixel_coords): Remove; unused.
7836 * dired.c (file_name_completion): Now static.
7838 * dbusbind.c (xd_in_read_queued_messages): Now static.
7840 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7841 * data.c (circular_list_error): Remove.
7843 * commands.h (last_point_position, last_point_position_buffer):
7844 (last_point_position_window): Remove decls.
7845 * keyboard.c: Make these variables static.
7847 * coding.h (coding, code_convert_region, encode_coding_gap):
7849 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7850 (iso_code_class, detect_coding, code_convert_region): Now static.
7851 (encode_coding_gap): Remove; unused.
7853 * chartab.c (chartab_chars, chartab_bits): Now static.
7855 * charset.h (charset_iso_8859_1): Remove decl.
7856 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7859 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7860 * ccl.c (Vccl_program_table): Now static.
7861 (check_ccl_update): Remove; unused.
7863 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7864 * category.h: ... from here.
7865 * category.c (check_category_table, set_category_set): Now static.
7867 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7868 * lisp.h: Remove these decls.
7870 * buffer.c (buffer_count): Remove unused var.
7872 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7873 so that it's not optimized away.
7874 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7875 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7876 exported only to the debugger.
7878 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7879 * atimer.h (run_all_atimers): Remove; not exported.
7881 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7882 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7883 was inaccessible from Lisp.
7884 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7885 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7887 alloc.c: Import and export fewer symbols, and remove unused items.
7888 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7890 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7891 it's not optimized away by whole-program optimization.
7892 (message_enable_multibyte, free_misc): Remove.
7893 (catchlist, handlerlist, mark_backtrace):
7894 Declare only if BYTE_MARK_STACK.
7895 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7896 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7897 (message_enable_multibyte): Remove decl.
7898 (free_misc, interval_free_list, float_block, float_block_index):
7899 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7900 (cons_free_list, last_marked_index):
7902 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7903 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7904 (mark_backtrace): Define only if BYTE_MARK_STACK.
7905 * xdisp.c (message_enable_multibyte): Now static.
7907 Declare Lisp_Object Q* variables to be 'static' if not exported.
7908 This makes it easier for human readers (and static analyzers)
7909 to see whether these variables are used from other modules.
7910 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7911 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7912 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7913 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7914 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7915 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7916 * xmenu.c, xselect.c:
7917 Declare Q* vars static if they are not used in other modules.
7918 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7919 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7920 Remove decls of unexported vars.
7921 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7923 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7925 Make Emacs functions such as Fatom 'static' by default.
7926 This makes it easier for human readers (and static analyzers)
7927 to see whether these functions can be called from other modules.
7928 DEFUN now defines a static function. To make the function external
7929 so that it can be used in other C modules, use the new macro DEFUE.
7930 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7931 (Finit_image_library):
7932 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7933 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7934 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7935 Remove decls, since these functions are now static.
7936 (Funintern, Fget_internal_run_time): New decls, since these functions
7937 were already external.
7939 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7940 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7941 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7942 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7943 * keyboard.c, keymap.c, lread.c:
7944 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7945 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7946 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7947 Mark functions with DEFUE instead of DEFUN,
7948 if they are used in other modules.
7949 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7950 decls for now-static functions.
7951 * buffer.h (Fdelete_overlay): Remove decl.
7952 * callproc.c (Fgetenv_internal): Mark as internal.
7953 * composite.c (Fremove_list_of_text_properties): Remove decl.
7954 (Fcomposition_get_gstring): New forward static decl.
7955 * composite.h (Fcomposite_get_gstring): Remove decl.
7956 * dired.c (Ffile_attributes): New forward static decl.
7957 * doc.c (Fdocumntation_property): New forward static decl.
7958 * eval.c (Ffetch_bytecode): New forward static decl.
7959 (Funintern): Remove extern decl; now in .h file where it belongs.
7960 * fileio.c (Fmake_symbolic_link): New forward static decl.
7961 * image.c (Finit_image_library): New forward static decl.
7962 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7963 * intervals.h (Fprevious_property_change):
7964 (Fremove_list_of_text_properties): Remove decls.
7965 * keyboard.c (Fthis_command_keys): Remove decl.
7966 (Fcommand_execute): New forward static decl.
7967 * keymap.c (Flookup_key): New forward static decl.
7968 (Fcopy_keymap): Now static.
7969 * keymap.h (Flookup_key): Remove decl.
7970 * process.c (Fget_process): New forward static decl.
7971 (Fprocess_datagram_address): Mark as internal.
7972 * syntax.c (Fsyntax_table_p): New forward static decl.
7973 (skip_chars): Remove duplicate decl.
7974 * textprop.c (Fprevious_property_change): New forward static decl.
7975 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7977 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7978 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7980 * editfns.c (Fformat): Remove unreachable code.
7982 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7984 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7987 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7989 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7990 when at ZV. (Bug#8487)
7992 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7994 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7996 * keyboard.c (parse_tool_bar_item): Likewise.
7997 * sound.c (sound_cleanup, alsa_close): Likewise.
7998 * termcap.c (tgetent): Likewise.
7999 * xfns.c (x_default_font_parameter): Likewise.
8000 * xsettings.c (read_and_apply_settings): Likewise.
8002 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8003 (overrun_check_free): Protoize.
8005 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8007 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8008 since callers should never pass a negative size.
8009 Change the signature to match that of plain 'read' and 'write'; see
8010 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8011 * lisp.h: Update prototypes of emacs_write and emacs_read.
8013 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8015 * xdisp.c (redisplay_window): Don't try to determine the character
8016 position of the scroll margin if the window start point w->startp
8017 is outside the buffer's accessible region. (Bug#8468)
8019 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8021 Fix write-region and its subroutines for buffers > 2GB.
8022 * fileio.c (a_write, e_write): Modify declaration of arguments and
8023 local variables to support buffers larger than 2GB.
8024 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8026 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8027 argument, local variables, and return value.
8029 * lisp.h: Update prototypes of emacs_write and emacs_read.
8031 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8033 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8035 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8037 Fix more problems found by GCC 4.6.0's static checks.
8039 * xdisp.c (vmessage): Use a better test for character truncation.
8041 * charset.c (load_charset_map): <, not <=, for optimization,
8042 and to avoid potential problems with integer overflow.
8043 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8044 * casetab.c (set_identity, shuffle): Likewise.
8045 * editfns.c (Fformat): Likewise.
8046 * syntax.c (skip_chars): Likewise.
8048 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8049 This also lets GCC 4.6.0 generate slightly better loop code.
8051 * callint.c (Fcall_interactively): <, not <=, for optimization.
8052 (Fcall_interactively): Count the number of arguments produced,
8053 not the number of arguments given. This is simpler and lets GCC
8054 4.6.0 generate slightly better code.
8056 * ftfont.c: Distingish more carefully between FcChar8 and char.
8057 The previous code passed unsigned char * to a functions like
8058 strlen and xstrcasecmp that expect char *, which does not
8059 conform to the C standard.
8060 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8061 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8062 char * when the C standard requires it.
8064 * keyboard.c (read_char): Remove unused var.
8066 * eval.c: Port to Windows vsnprintf (Bug#8435).
8068 (SIZE_MAX): Define if the headers do not.
8069 (verror): Do not give up if vsnprintf returns a negative count.
8070 Instead, grow the buffer. This ports to Windows vsnprintf, which
8071 does not conform to C99. Problem reported by Eli Zaretskii.
8072 Also, simplify the allocation scheme, by avoiding the need for
8073 calling realloc, and removing the ALLOCATED variable.
8075 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8077 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8078 But keep the doprint source code for now, as we might revamp it
8079 and use it again (Bug#8435).
8080 * lisp.h (doprnt): Remove.
8081 * Makefile.in (base_obj): Remove doprnt.o.
8082 * deps.mk (doprnt.o): Remove.
8084 error: Print 32- and 64-bit integers portably (Bug#8435).
8085 Without this change, on typical 64-bit hosts error ("...%d...", N)
8086 was used to print both 32- and 64-bit integers N, which relied on
8088 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8089 * lisp.h (error, verror): Mark as printf-like functions.
8090 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8091 Report overflow in size calculations when allocating printf buffer.
8092 Do not truncate output string at its first null byte.
8093 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8094 Truncate the output at a character boundary, since vsnprintf does not
8096 * charset.c (check_iso_charset_parameter): Convert internal
8097 character to string before calling 'error', since %c now has the
8099 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8100 overflow when computing char to be passed to 'error'. Do not
8101 pass Lisp_Object to 'error'; pass the integer instead.
8102 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8103 formatted with plain %d.
8105 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8107 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8109 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8111 * xterm.c (x_catch_errors): Remove duplicate declaration.
8113 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8115 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8117 2011-04-10 Jim Meyering <meyering@redhat.com>
8119 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8120 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8121 return ssize_t not "int", and use size_t as the buffer length.
8122 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8123 * gnutls.h: Update declarations.
8124 * process.c (read_process_output): Use ssize_t, to match.
8125 (send_process): Likewise.
8127 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8129 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8131 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8133 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8134 Use unsigned char, to match FcChar8 type definition.
8136 * xterm.c (handle_one_xevent):
8137 * xmenu.c (create_and_show_popup_menu):
8138 * xselect.c (x_decline_selection_request)
8139 (x_reply_selection_request): Avoid type-punned deref of X events.
8141 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8143 Fix some uses of `int' instead of EMACS_INT.
8144 * search.c (string_match_1, fast_string_match)
8145 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8146 (scan_buffer, find_next_newline_no_quit)
8147 (find_before_next_newline, search_command, Freplace_match)
8148 (Fmatch_data): Make some `int' variables be EMACS_INT.
8150 * xdisp.c (display_count_lines): 3rd argument and return value now
8151 EMACS_INT. All callers changed.
8152 (pint2hrstr): Last argument is now EMACS_INT.
8154 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8155 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8156 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8157 (decode_coding_utf_16, decode_coding_emacs_mule)
8158 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8159 (decode_coding_ccl, decode_coding_charset)
8160 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8161 (decode_coding_iso_2022, decode_coding_emacs_mule)
8162 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8163 <char_offset, last_offset>: Declare EMACS_INT.
8164 (encode_coding_utf_8, encode_coding_utf_16)
8165 (encode_coding_emacs_mule, encode_invocation_designation)
8166 (encode_designation_at_bol, encode_coding_iso_2022)
8167 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8168 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8170 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8171 (encode_invocation_designation): Last argument P_NCHARS is now
8173 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8174 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8176 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8179 * ccl.c (Fccl_execute_on_string): Declare some variables
8182 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8184 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8186 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8188 * process.c (Fformat_network_address): Doc fix.
8190 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8192 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8194 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8196 * keyboard.c (read_char): Call Lisp function help-form-show,
8197 instead of using internal_with_output_to_temp_buffer.
8198 (Qhelp_form_show): New var.
8199 (syms_of_keyboard): Use DEFSYM macro.
8201 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8203 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8205 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8207 * process.c (Flist_processes): Remove to Lisp.
8208 (list_processes_1): Delete.
8210 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8212 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8214 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8216 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8218 Fix more problems found by GCC 4.6.0's static checks.
8220 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8222 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8224 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8226 * xdisp.c (vmessage): Mark as a printf-like function.
8228 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8230 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8232 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8233 printf-like functions.
8234 (tiff_load): Add casts to remove these marks before passing them
8235 to system-supplied API.
8237 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8239 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8240 This avoids several warnings with gcc -Wstrict-overflow.
8241 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8242 directly, rather than having caller test rule sign. This avoids
8243 some unnecessary tests.
8244 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8245 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8246 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8248 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8249 (xfont_open): Avoid unnecessary tests.
8251 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8253 * composite.h, composite.c (composition_gstring_put_cache):
8254 Use EMACS_INT, not int, for length.
8256 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8257 breaking out part of COMPOSITION_DECODE_RULE.
8258 (COMPOSITION_DECODE_RULE): Use it.
8259 * composite.c (get_composition_id): Remove unused local vars,
8260 by using the new macro.
8262 * textprop.c (set_text_properties_1): Change while to do-while,
8263 since the condition is always true at first.
8265 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8266 (interval_deletion_adjustment): Return unsigned value.
8269 * process.c (list_processes_1, create_pty, read_process_output):
8270 (exec_sentinel): Remove vars that were set but not used.
8271 (create_pty): Remove unnecessary "volatile"s.
8272 (Fnetwork_interface_info): Avoid possibility of int overflow.
8273 (read_process_output): Do adaptive read buffering even if carryover.
8274 (read_process_output): Simplify nbytes computation if buffered.
8276 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8278 * syntax.c (scan_words): Remove var that was set but not used.
8279 (update_syntax_table): Use unsigned instead of int.
8281 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8282 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8283 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8285 * print.c (print_error_message): Avoid int overflow.
8287 * font.c (font_list_entities): Redo for clarity,
8288 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8290 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8291 (font_score): Avoid potential overflow in diff calculation.
8293 * fns.c (substring_both): Remove var that is set but not used.
8294 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8296 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8298 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8299 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8300 can always succeed if overflow has undefined behavior.
8302 * search.c (boyer_moore, wordify): Remove vars set but not used.
8303 (wordify): Omit three unnecessary tests.
8305 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8306 All callers changed. This avoids the need for an unused var.
8308 * casefiddle.c (casify_region): Remove var that is set but not used.
8310 * dired.c (file_name_completion): Remove var that is set but not used.
8312 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8314 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8315 (Finsert_file_contents): Remove unnecessary code checking fd.
8317 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8318 Check for integer overflow on size calculations.
8320 * buffer.c (Fprevious_overlay_change): Remove var that is set
8323 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8324 Remove vars that are set but not used.
8325 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8326 (timer_check_2): Mark vars as initialized.
8328 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8330 * image.c (lookup_image): Remove var that is set but not used.
8331 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8333 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8334 that are set but not used.
8336 * xfns.c (make_invisible_cursor): Don't return garbage
8337 if XCreateBitmapFromData fails (Bug#8410).
8339 * xselect.c (x_get_local_selection, x_handle_property_notify):
8340 Remove vars that are set but not used.
8342 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8343 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8345 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8346 Remove var that is set but not used.
8347 (scroll_bar_windows_size): Now size_t, not int.
8348 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8351 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8352 (map_tty_color) [!defined MSDOS]: Likewise.
8354 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8356 * coding.c: Remove vars that are set but not used.
8357 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8358 All callers changed.
8359 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8360 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8361 (decode_coding_charset): Remove vars that are set but not used.
8363 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8364 that is set but not used.
8366 * print.c (print_object): Remove var that is set but not used.
8368 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8369 The gnulib version avoids calling malloc in the usual case,
8370 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8371 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8372 * filelock.c (current_lock_owner): Likewise.
8373 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8374 * sysdep.c: Include allocator.h, careadlinkat.h.
8375 (emacs_no_realloc_allocator): New static constant.
8376 (emacs_readlink): New function.
8377 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8378 ../lib/careadlinkat.h.
8380 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8382 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8383 first non-nil return value).
8385 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8387 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8388 if not defined (Bug#8403).
8390 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8392 * xdisp.c (display_count_lines): Remove parameter `start',
8393 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8394 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8395 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8396 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8397 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8398 and thereabouts. All callers changed.
8399 (get_per_char_metric): Remove parameter `f', unused since
8400 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8402 2011-04-02 Jim Meyering <meyering@redhat.com>
8404 do not dereference NULL upon failed strdup
8405 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8406 (ns_get_family): Likewise.
8408 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8410 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8412 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8414 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8417 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8419 Add lexical binding.
8421 * window.c (Ftemp_output_buffer_show): New fun.
8422 (Fsave_window_excursion):
8423 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8425 * lread.c (lisp_file_lexically_bound_p): New function.
8426 (Fload): Bind Qlexical_binding.
8427 (readevalloop): Remove `evalfun' arg.
8428 Bind Qinternal_interpreter_environment.
8429 (Feval_buffer): Bind Qlexical_binding.
8430 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8432 (syms_of_lread): Declare `lexical-binding'.
8434 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8436 * keyboard.c (eval_dyn): New fun.
8437 (menu_item_eval_property): Use it.
8439 * image.c (parse_image_spec): Use Ffunctionp.
8441 * fns.c (concat, mapcar1): Accept byte-code-functions.
8443 * eval.c (Fsetq): Handle lexical vars.
8444 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8445 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8446 (FletX, Flet): Obey lexical binding.
8447 (Fcommandp): Handle closures.
8448 (Feval): New `lexical' arg.
8449 (eval_sub): New function extracted from Feval. Use it almost
8450 everywhere where Feval was used. Look up vars in lexical env.
8452 (Ffunctionp): Move from subr.el.
8453 (Ffuncall): Handle closures.
8454 (apply_lambda): Remove `eval_flags'.
8455 (funcall_lambda): Handle closures and new byte-code-functions.
8456 (Fspecial_variable_p): New function.
8457 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8458 but without exporting it to Lisp.
8460 * doc.c (Fdocumentation, store_function_docstring):
8461 * data.c (Finteractive_form): Handle closures.
8463 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8466 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8468 (exec_byte_code): New function extracted from Fbyte_code to handle new
8469 calling convention for byte-code-functions. Add new byte-codes.
8471 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8473 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8475 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8477 * xdisp.c (redisplay_internal): Fix prototype.
8479 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8481 * xdisp.c (SCROLL_LIMIT): New macro.
8482 (try_scrolling): Use it when setting scroll_limit.
8483 Limit scrolling to 100 screen lines.
8484 (redisplay_window): Even when falling back on "recentering",
8485 position point in the window according to scroll-conservatively,
8486 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8488 (try_scrolling): When point is above the window, allow searching
8489 as far as scroll_max, or one screenful, to compute vertical
8490 distance from PT to the scroll margin position. This prevents
8491 try_scrolling from unnecessarily failing when
8492 scroll-conservatively is set to a value slightly larger than the
8493 window height. Clean up the case of PT below the margin at bottom
8494 of window: scroll_max can no longer be INT_MAX. When aggressive
8495 scrolling is in use, don't let point enter the opposite scroll
8496 margin as result of the scroll.
8497 (syms_of_xdisp) <scroll-conservatively>: Document the
8498 threshold of 100 lines for never-recentering scrolling.
8500 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8502 * dispextern.h (move_it_by_lines):
8503 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8504 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8505 (message_log_check_duplicate): Remove parameters `prev_bol' and
8506 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8507 (redisplay_internal): Remove parameter `preserve_echo_area',
8508 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8510 * indent.c (Fvertical_motion):
8511 * window.c (window_scroll_pixel_based, Frecenter):
8512 Don't pass `need_y_p' to `move_it_by_lines'.
8514 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8516 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8517 steal a few bits to be more compact.
8518 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8519 Remove unneeded casts.
8521 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8523 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8525 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8526 binding" message (bug#7967).
8528 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8530 Fix more problems found by GCC 4.6.0's static checks.
8532 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8533 Remove unused local var.
8535 * editfns.c (Fmessage_box): Remove unused local var.
8537 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8538 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8539 Omit unused local vars.
8540 * window.c (shrink_windows): Omit unused local var.
8541 * menu.c (digest_single_submenu): Omit unused local var.
8542 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8543 Omit unused local var.
8545 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8546 Don't assume string length fits in int.
8547 (keyremap_step, read_key_sequence): Use size_t for sizes.
8548 (read_key_sequence): Don't check last_real_key_start redundantly.
8550 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8551 instead of alloca (Bug#8344).
8553 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8554 (Fbacktrace_frame): Don't assume nframes fits in int.
8556 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8558 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8561 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8563 * cm.c (calccost): Turn while-do into do-while, for clarity.
8565 * keyboard.c (syms_of_keyboard): Use the same style as later
8566 in this function when indexing through an array. This also
8567 works around GCC bug 48267.
8569 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8571 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8573 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8574 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8576 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8577 This avoids undefined behavior on integer overflow, and is a bit
8578 more convenient anyway since it is compared to a size_t variable.
8580 Variadic C functions now count arguments with size_t, not int.
8581 This avoids an unnecessary limitation on 64-bit machines, which
8582 caused (substring ...) to crash on large vectors (Bug#8344).
8583 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8584 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8585 All variadic functions and their callers changed accordingly.
8586 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8587 * data.c (arith_driver, float_arith_driver): Likewise.
8588 * editfns.c (general_insert_function): Likewise.
8589 * eval.c (struct backtrace.nargs, interactive_p)
8590 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8591 (funcall_lambda, mark_backtrace): Likewise.
8592 * fns.c (concat): Likewise.
8593 * frame.c (x_set_frame_parameters): Likewise.
8594 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8595 0 if not found, not -1. All callers changed.
8597 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8598 (stack_copy_size): Now size_t, not int.
8599 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8601 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8603 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8604 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8605 All callers changed.
8607 * lisp.h (multibyte_char_to_unibyte):
8608 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8609 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8610 * character.h (CHAR_TO_BYTE8):
8611 * cmds.c (internal_self_insert):
8612 * editfns.c (general_insert_function):
8613 * keymap.c (push_key_description):
8614 * search.c (Freplace_match):
8615 * xdisp.c (message_dolog, set_message_1): All callers changed.
8617 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8619 * keyboard.c (safe_run_hook_funcall): New function.
8620 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8621 don't set the hook to nil, but remove the offending function instead.
8622 (Qcommand_hook_internal): Remove, unused.
8623 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8624 Vcommand_hook_internal.
8626 * eval.c (enum run_hooks_condition): Remove.
8627 (funcall_nil, funcall_not): New functions.
8628 (run_hook_with_args): Call each function through a `funcall' argument.
8629 Remove `cond' argument, now redundant.
8630 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8631 (Frun_hook_with_args_until_failure): Adjust accordingly.
8632 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8634 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8636 * dispextern.h (string_buffer_position): Remove declaration.
8638 * print.c (strout): Remove parameter `multibyte', unused since
8639 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8641 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8642 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8643 All callers changed.
8645 * w32.c (_wsa_errlist): Use braces for struct initializers.
8647 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8648 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8649 All callers changed.
8650 (string_buffer_position): Likewise. Also, make static (it's never
8651 used outside xdisp.c).
8652 (cursor_row_p): Remove parameter `w', unused since
8653 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8654 (decode_mode_spec): Remove parameter `precision', introduced during
8655 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8656 All callers changed.
8658 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8660 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8662 2011-03-27 Anders Lindgren <andlind@gmail.com>
8664 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8665 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8666 (ns_update_auto_hide_menu_bar): New functions.
8667 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8668 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8669 ns_constrain_all_frames.
8670 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8671 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8673 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8675 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8677 2011-03-27 Glenn Morris <rgm@gnu.org>
8679 * syssignal.h: Replace RETSIGTYPE with void.
8680 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8681 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8682 Replace SIGTYPE with void everywhere.
8683 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8684 * s/template.h (SIGTYPE): Remove commented out definition.
8686 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8688 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8689 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8691 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8693 * w32.c (read_unc_volume): Use parameter `henum', instead of
8694 global variable `wget_enum_handle'.
8696 * keymap.c (describe_vector): Remove parameters `indices' and
8697 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8698 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8700 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8702 * keyboard.c (timer_check): Remove parameter `do_it_now',
8703 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8704 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8705 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8707 * keyboard.c (read_char):
8708 * w32menu.c (w32_menu_display_help):
8709 * xmenu.c (show_help_event, menu_help_callback):
8710 Adjust calls to `show_help_echo'.
8712 * gtkutil.c (xg_maybe_add_timer):
8713 * keyboard.c (readable_events):
8714 * process.c (wait_reading_process_output):
8715 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8717 * insdel.c (adjust_markers_gap_motion):
8718 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8719 (gap_left, gap_right): Don't call it.
8721 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8723 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8724 incurred during fontification.
8726 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8728 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8729 (DEFVAR_PER_BUFFER): Don't pass it.
8731 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8732 (scrolling_window): Don't pass it.
8734 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8736 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8738 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8740 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8741 of variables specific to SELinux and computation of `encoded_absname'.
8743 * image.c (XPutPixel): Remove unused variable `height'.
8745 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8747 * unexw32.c (get_section_info): Remove unused variable `section'.
8749 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8750 (system_process_attributes): Remove unused variable `sess'.
8751 (sys_read): Remove unused variable `err'.
8753 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8754 (w32_wnd_proc): Remove unused variable `isdead'.
8755 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8756 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8757 (x_create_tip_frame): Remove unused variable `tem'.
8759 * w32inevt.c (w32_console_read_socket):
8760 Remove unused variable `no_events'.
8762 * w32term.c (x_draw_composite_glyph_string_foreground):
8763 Remove unused variable `width'.
8765 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8767 * w32term.c (x_set_glyph_string_clipping):
8768 Don't pass uninitialized region to CombineRgn.
8770 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8772 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8773 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8774 (Fx_close_connection): Remove unused variable `i'.
8776 * w32font.c (w32font_draw): Return number of glyphs.
8777 (w32font_open_internal): Remove unused variable `i'.
8778 (w32font_driver): Add missing initializer.
8780 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8781 (fill_in_menu): Remove unused variable `items_added'.
8783 * w32term.c (last_mouse_press_frame): Remove static global variable.
8784 (w32_clip_to_row): Remove unused variable `f'.
8785 (x_delete_terminal): Remove unused variable `i'.
8787 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8788 (NOTHING): Remove unused static global variable.
8789 (uniscribe_check_otf): Remove unused variable `table'.
8790 (uniscribe_font_driver): Add missing initializers.
8792 2011-03-23 Julien Danjou <julien@danjou.info>
8794 * term.c (Fsuspend_tty, Fresume_tty):
8795 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8796 * window.c (temp_output_buffer_show):
8797 * insdel.c (signal_before_change):
8798 * frame.c (Fhandle_switch_frame):
8799 * fileio.c (Fdo_auto_save):
8800 * emacs.c (Fkill_emacs):
8801 * editfns.c (save_excursion_restore):
8802 * cmds.c (internal_self_insert):
8803 * callint.c (Fcall_interactively):
8804 * buffer.c (Fkill_all_local_variables):
8805 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8807 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8808 unconditionally since it does the check itself.
8810 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8812 Fix more problems found by GCC 4.5.2's static checks.
8814 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8815 the first time through the loop, since we know p0 < p1 then.
8816 This also avoids a gcc -Wstrict-overflow warning.
8818 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8819 leading to a memory leak, possible in functions like
8820 load_charset_map_from_file that can allocate an unbounded number
8821 of objects (Bug#8318).
8823 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8824 that could (at least in theory) be that large.
8826 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8827 This is less likely to overflow, and avoids undefined behavior if
8828 overflow does occur. All callers changed. Use strtoul to scan
8829 for the unsigned long integer.
8830 (pint2hrstr): Simplify and tune code slightly.
8831 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8833 * scroll.c (do_scrolling): Work around GCC bug 48228.
8834 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8836 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8837 This also avoids a warning with gcc -Wstrict-overflow.
8838 (validate_x_resource_name): Simplify count usage.
8839 This also avoids a warning with gcc -Wstrict-overflow.
8841 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8844 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8846 * process.c (Fmake_network_process): Use socklen_t, not int,
8847 where POSIX says socklen_t is required in portable programs.
8848 This fixes a porting bug on hosts like 64-bit HP-UX, where
8849 socklen_t is wider than int (Bug#8277).
8850 (Fmake_network_process, server_accept_connection):
8851 (wait_reading_process_output, read_process_output):
8854 * process.c: Rename or move locals to avoid shadowing.
8855 (list_processes_1, Fmake_network_process):
8856 (read_process_output_error_handler, exec_sentinel_error_handler):
8857 Rename or move locals.
8858 (Fmake_network_process): Define label "retry_connect" only if needed.
8859 (Fnetwork_interface_info): Fix pointer signedness.
8860 (process_send_signal): Add cast to avoid pointer signedness problem.
8861 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8862 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8864 Make tparam.h and terminfo.c consistent.
8865 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8866 Include tparam.h instead, since it declares them.
8867 * cm.h (PC): Remove extern decl; tparam.h now does this.
8868 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8869 * terminfo.c: Include tparam.h, to check interfaces.
8870 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8871 (tparam): Adjust signature to match interface in tparam.h;
8872 this removes some undefined behavior. Check that outstring and len
8873 are zero, which they always are with Emacs.
8874 * tparam.h (PC, BC, UP): New extern decls.
8876 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8877 (xftfont_open): Rename locals to avoid shadowing.
8879 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8880 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8881 (OTF_TAG_SYM): Omit macro if not needed.
8882 (ftfont_list): Remove unused local.
8883 (get_adstyle_property, ftfont_pattern_entity):
8884 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8885 Rename locals to avoid shadowing.
8887 * xfont.c (xfont_list_family): Mark var as initialized.
8889 * xml.c (make_dom): Now static.
8891 * composite.c (composition_compute_stop_pos): Rename local to
8893 (composition_reseat_it): Remove unused locals.
8894 (find_automatic_composition, composition_adjust_point): Likewise.
8895 (composition_update_it): Mark var as initialized.
8896 (find_automatic_composition): Mark vars as initialized,
8897 with a FIXME (Bug#8290).
8899 character.h: Rename locals to avoid shadowing.
8900 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8901 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8902 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8903 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8906 * textprop.c (property_change_between_p): Remove; unused.
8908 * intervals.c (interval_start_pos): Now static.
8910 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8912 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8913 Rename locals to avoid shadowing.
8915 * sound.c (wav_play, au_play, Fplay_sound_internal):
8916 Fix pointer signedness.
8917 (alsa_choose_format): Remove unused local var.
8918 (wav_play): Initialize a variable to 0, to prevent undefined
8919 behavior (Bug#8278).
8921 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8923 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8925 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8926 clobbering (Bug#8298).
8927 * sysdep.c (sys_subshell): Likewise.
8928 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8930 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8931 This should get cleaned up, so that child_setup has the
8932 same signature on all platforms.
8934 * callproc.c (call_process_cleanup): Now static.
8935 (relocate_fd): Rename locals to avoid shadowing.
8937 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8939 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8940 not to be necessary, and produces flickering.
8942 2011-03-20 Glenn Morris <rgm@gnu.org>
8944 * config.in: Remove file.
8946 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8948 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8949 are now in src/globals.h.
8950 (syms_of_minibuf): Remove spurious & from previous change.
8952 2011-03-20 Leo Liu <sdl.web@gmail.com>
8954 * minibuf.c (completing-read-function): New variable.
8955 (completing-read-default): Rename from completing-read.
8956 (completing-read): Call completing-read-function.
8958 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8960 * xfaces.c (Fx_load_color_file):
8961 Read color file from absolute filename (bug#8250).
8963 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8965 * makefile.w32-in: Update dependencies.
8967 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8969 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8971 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8973 Fix more problems found by GCC 4.5.2's static checks.
8975 * process.c (make_serial_process_unwind, send_process_trap):
8976 (sigchld_handler): Now static.
8978 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8979 That way, the code declares only the vars that it needs.
8980 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8981 * s/cygwin.h (PTY_ITERATION): Likewise.
8982 * s/darwin.h (PTY_ITERATION): Likewise.
8983 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8985 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8986 * process.c (allocate_pty): Don't declare stb unless it's needed.
8988 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8989 (CONSTANTLIM): Remove; unused.
8990 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8991 Define only if needed.
8993 * unexelf.c (unexec): Name an expression,
8994 to avoid gcc -Wbad-function-cast warning.
8995 Use a different way to cause a compilation error if anyone uses
8996 n rather than nn, a way that does not involve shadowing.
8997 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8999 * deps.mk (unexalpha.o): Remove; unused.
9001 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9002 * unexec.h: New file.
9003 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9004 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9006 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9007 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9008 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9009 Change as necessary to match prototype in unexec.h.
9011 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9013 (back_comment, skip_chars): Mark vars as initialized.
9015 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9016 Rename locals to avoid shadowing.
9018 * lread.c (read1): Rewrite so as not to use empty "else".
9019 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9021 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9023 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9024 warning when compiling print.c.
9026 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9027 instead of using an uninitialized var.
9028 (font_sort_entities): Mark var as initialized.
9030 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9032 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9033 pointers to constants.
9034 (font_parse_fcname): Remove unused vars.
9035 (font_delete_unmatched): Now static.
9036 (font_get_spec): Remove; unused.
9037 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9038 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9039 Rename or move locals to avoid shadowing.
9041 * fns.c (require_nesting_list, require_unwind): Now static.
9042 (Ffillarray): Rename locals to avoid shadowing.
9044 * floatfns.c (domain_error2): Define only if needed.
9045 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9047 * alloc.c (mark_backtrace): Move decl from here ...
9048 * lisp.h: ... to here, so that it can be checked.
9050 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9051 (Fdefvar): Rewrite so as not to use empty "else".
9052 (lisp_indirect_variable): Name an expression,
9053 to avoid gcc -Wbad-function-cast warning.
9054 (Fdefvar): Rename locals to avoid shadowing.
9056 * callint.c (quotify_arg, quotify_args): Now static.
9057 (Fcall_interactively): Rename locals to avoid shadowing.
9058 Use const pointer when appropriate.
9060 * lisp.h (get_system_name, get_operating_system_release):
9061 Move decls here, to check interfaces.
9062 * process.c (get_operating_system_release): Move decl to lisp.h.
9063 * xrdb.c (get_system_name): Likewise.
9064 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9065 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9066 some of which prompt warnings from gcc -Wbad-function-cast.
9067 (Fformat_time_string, Fencode_time, Finsert_char):
9068 (Ftranslate_region_internal, Fformat):
9069 Rename or remove local vars to avoid shadowing.
9070 (Ftranslate_region_internal): Mark var as initialized.
9072 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9075 * lisp.h (eassert): Check that the argument compiles, even if
9076 ENABLE_CHECKING is not defined.
9078 * data.c (Findirect_variable): Name an expression, to avoid
9079 gcc -Wbad-function-cast warning.
9080 (default_value, arithcompare, arith_driver, arith_error): Now static.
9081 (store_symval_forwarding): Rename local to avoid shadowing.
9082 (Fmake_variable_buffer_local, Fmake_local_variable):
9083 Mark variables as initialized.
9084 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9086 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9087 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9088 Rename locals to avoid shadowing.
9089 (mark_stack): Move local variables into the #ifdef region where
9091 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9092 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9094 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9095 (GC_STRING_CHARS): Remove; not used.
9096 (Fmemory_limit): Cast sbrk's returned value to char *.
9098 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9099 avoids undefined behavior in theory.
9101 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9103 Use functions, not macros, for up- and down-casing (Bug#8254).
9104 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9105 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9106 to use the following functions instead of these macros.
9107 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9108 EMACS_INT, since callers assume the returned value fits in int.
9109 (upcase1): Likewise, for UPCASE_TABLE.
9110 (uppercasep, lowercasep, upcase): New static inline functions.
9111 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9112 the race-condition problem in the old DOWNCASE.
9114 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9115 Rename locals to avoid shadowing.
9116 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9117 (regex_compile, re_search_2, re_match_2_internal):
9118 Remove unused local vars.
9119 (FREE_VAR): Rewrite so as not to use empty "else",
9120 which gcc can warn about.
9121 (regex_compile, re_match_2_internal): Mark locals as initialized.
9122 (RETALLOC_IF): Define only if needed.
9123 (WORDCHAR_P): Likewise. This one is never needed, but is used
9124 only in a comment talking about a compiler bug, so put inside
9125 the #if 0 of that comment.
9126 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9127 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9130 * search.c (boyer_moore): Rename locals to avoid shadowing.
9131 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9132 (PREV_CHAR_BOUNDARY): Likewise.
9134 * search.c (simple_search): Remove unused var.
9136 * dired.c (compile_pattern): Move decl from here ...
9137 * lisp.h: ... to here, so that it can be checked.
9138 (struct re_registers): New forward decl.
9140 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9142 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9144 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9145 Rename locals to avoid shadowing.
9146 (Fvertical_motion): Mark locals as initialized.
9148 * casefiddle.c (casify_object, casify_region): Now static.
9149 (casify_region): Mark local as initialized.
9151 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9153 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9154 New macros, so that the caller can use some names other than
9155 gcpro1, gcpro2, etc.
9156 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9158 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9159 argument, for consistency with GCPRO2_VAR, etc: it is now the
9160 prefix of the variable, not the variable itself. All uses
9162 * dired.c (directory_files_internal, file_name_completion):
9163 Rename locals to avoid shadowing.
9165 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9166 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9167 dired.c's scmp function, had undefined behavior.
9168 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9169 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9170 * buffer.h: ... to here, because these macros use current_buffer,
9171 and the new implementation with inline functions needs to have
9172 current_buffer in scope now, rather than later when the macros
9174 (downcase, upcase1): New static inline functions.
9175 (DOWNCASE, UPCASE1): Reimplement using these functions.
9176 This avoids undefined behavior in expressions like
9177 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9178 from race conditions in accessing the global variables
9179 case_temp1 and case_temp2.
9180 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9181 * lisp.h (case_temp1, case_temp2): Remove their decls.
9182 * character.h (ASCII_CHAR_P): Move from here ...
9183 * lisp.h: ... to here, so that the inline functions mentioned
9186 * dired.c (directory_files_internal_unwind): Now static.
9188 * fileio.c (file_name_as_directory, directory_file_name):
9189 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9191 (file_name_as_directory): Use const pointers when appropriate.
9192 (Fexpand_file_name): Likewise. In particular, newdir might
9193 point at constant storage, so make it a const pointer.
9194 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9195 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9197 (Fset_file_times, Finsert_file_contents, auto_save_error):
9198 Rename locals to avoid shadowing.
9200 * minibuf.c (choose_minibuf_frame_1): Now static.
9201 (Ftry_completion, Fall_completions): Rename or remove locals
9204 * marker.c (bytepos_to_charpos): Remove; unused.
9206 * lisp.h (verify_bytepos, count_markers): New decls,
9207 so that gcc does not warn that these functions aren't declared.
9209 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9210 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9211 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9212 (copy_text): Remove unused local var.
9214 * filelock.c (within_one_second): Now static.
9215 (lock_file_1): Rename local to avoid shadowing.
9217 * buffer.c (fix_overlays_before): Mark locals as initialized.
9218 (fix_start_end_in_overlays): Likewise. This function should be
9219 simplified by using pointers-to-pointers, but that's a different
9221 (switch_to_buffer_1): Now static.
9222 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9223 (report_overlay_modification): Rename locals to avoid shadowing.
9225 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9226 Fix pointer signedness issue.
9227 (sys_subshell): Mark local as volatile if checking for lint,
9228 to suppress a gcc -Wclobbered warning that does not seem to be right.
9229 (MAXPATHLEN): Define only if needed.
9231 * process.c (serial_open, serial_configure): Move decls from here ...
9232 * systty.h: ... to here, so that they can be checked.
9234 * fns.c (get_random, seed_random): Move extern decls from here ...
9235 * lisp.h: ... to here, so that they can be checked.
9237 * sysdep.c (reset_io): Now static.
9238 (wait_for_termination_signal): Remove; unused.
9240 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9241 (copy_keymap_item, append_key, push_text_char_description):
9243 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9244 (DENSE_TABLE_SIZE): Remove; unused.
9245 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9246 (describe_map_tree):
9247 Rename locals to avoid shadowing.
9249 * keyboard.c: Declare functions static if they are not used elsewhere.
9250 (echo_char, echo_dash, cmd_error, top_level_2):
9251 (poll_for_input, handle_async_input): Now static.
9252 (read_char, kbd_buffer_get_event, make_lispy_position):
9253 (make_lispy_event, make_lispy_movement, apply_modifiers):
9254 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9255 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9256 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9257 (read_key_sequence, read_char): Mark locals as initialized.
9258 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9260 * keyboard.h (make_ctrl_char): New decl.
9261 (mark_kboards): Move decl here ...
9262 * alloc.c (mark_kboards): ... from here.
9264 * lisp.h (force_auto_save_soon): New decl.
9266 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9267 (DEFINE_DUMMY_FUNCTION): New macro.
9268 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9270 (main): Add casts to avoid warnings
9271 if GCC considers string literals to be constants.
9273 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9275 * dbusbind.c: Pointer signedness fixes.
9276 (xd_signature, xd_append_arg, xd_initialize):
9277 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9278 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9279 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9280 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9282 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9283 if GCC considers string literals to be constants.
9284 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9286 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9288 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9289 (print_preprocess, print_object): New macro to fix last change.
9291 * print.c (print_preprocess): Don't forget font objects.
9293 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9295 * emacs.c (USAGE3): Doc fixes.
9297 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9299 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9302 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9304 * lisp.h (VWindow_system, Qfile_name_history):
9305 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9306 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9307 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9309 * w32select.c: Don't #include "keyboard.h".
9310 (run_protected): Add extern declaration for waiting_for_input.
9312 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9313 * w32console.c (detect_input_pending, read_input_pending)
9314 (encode_terminal_code):
9315 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9316 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9317 (w32_system_caret_y, Qfile_name_history):
9318 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9319 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9320 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9321 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9322 * w32proc.c (Qlocal, report_file_error):
9323 * w32term.c (Vwindow_system, updating_frame):
9324 * w32uniscribe.c (initialized, uniscribe_font_driver):
9325 Remove unneeded extern declarations.
9327 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9329 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9331 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9333 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9334 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9335 These macros can no longer be used for assignment.
9337 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9338 Assign struct members directly, instead of using BUF_BEGV etc.
9339 (record_buffer_markers, fetch_buffer_markers): New functions for
9340 recording and fetching special buffer markers.
9341 (set_buffer_internal_1, set_buffer_temp): Use them.
9343 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9345 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9347 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9348 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9350 * xdisp.c (hscroll_window_tree):
9351 (reconsider_clip_changes): Use PT instead of BUF_PT.
9353 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9355 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9356 $(EMACS_ROOT)/lib/intprops.h.
9358 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9360 Fix more problems found by GCC 4.5.2's static checks.
9362 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9363 to unsigned char * to avoid compiler diagnostic.
9364 (xg_free_frame_widgets): Make it clear that a local variable is
9365 needed only if USE_GTK_TOOLTIP.
9366 (gdk_window_get_screen): Make it clear that this macro is needed
9367 only if USE_GTK_TOOLTIP.
9368 (int_gtk_range_get_value): New function, which avoids a diagnostic
9369 from gcc -Wbad-function-cast.
9370 (xg_set_toolkit_scroll_bar_thumb): Use it.
9371 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9372 diagnostic from gcc -Wbad-function-cast.
9373 (get_utf8_string, xg_get_file_with_chooser):
9374 Rename locals to avoid shadowing.
9375 (create_dialog): Move locals to avoid shadowing.
9377 * xgselect.c (xg_select): Remove unused var.
9379 * image.c (four_corners_best): Mark locals as initialized.
9380 (gif_load): Initialize transparent_p to zero (Bug#8238).
9381 Mark another local as initialized.
9382 (my_png_error, my_error_exit): Mark with NO_RETURN.
9384 * image.c (clear_image_cache): Now static.
9385 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9386 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9387 (x_edge_detection): Remove unnecessary cast that
9388 gcc -Wbad-function-cast diagnoses.
9389 (gif_load): Fix pointer signedness.
9390 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9391 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9393 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9395 Improve quality of tests for time stamp overflow.
9396 For example, without this patch (encode-time 0 0 0 1 1
9397 1152921504606846976) returns the obviously-bogus value (-948597
9398 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9399 reports time overflow. See
9400 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9401 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9402 * editfns.c: Include limits.h and intprops.h.
9403 (TIME_T_MIN, TIME_T_MAX): New macros.
9404 (time_overflow): Move earlier, to before first use.
9405 (hi_time, lo_time): New functions, for an accurate test for
9407 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9408 (Fget_internal_run_time): Don't assume time_t fits in int.
9409 (make_time): Use list2 instead of Fcons twice.
9410 (Fdecode_time): More accurate test for out-of-range times.
9411 (check_tm_member): New function.
9412 (Fencode_time): Use it, to test for out-of-range times.
9413 (lisp_time_argument): Don't rely on undefined left-shift and
9414 right-shift behavior when checking for time stamp overflow.
9416 * editfns.c (time_overflow): New function, refactoring common code.
9417 (Fformat_time_string, Fdecode_time, Fencode_time):
9418 (Fcurrent_time_string): Use it.
9420 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9421 * dired.c (make_time): Move to ...
9422 * editfns.c (make_time): ... here.
9423 * systime.h: Note the move.
9425 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9427 * fringe.c (update_window_fringes): Remove unused variables.
9429 * unexmacosx.c (copy_data_segment): Also copy __got section.
9432 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9434 * termcap.c [MSDOS]: Include "msdos.h".
9435 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9436 Constify `char *' arguments and their references according to
9437 prototypes in tparam.h.
9439 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9441 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9442 Adapt all references accordingly.
9444 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9446 2011-03-11 Tom Tromey <tromey@redhat.com>
9448 * buffer.c (syms_of_buffer): Remove obsolete comment.
9450 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9452 * termhooks.h (encode_terminal_code): Declare prototype.
9454 * msdos.c (encode_terminal_code): Don't declare prototype.
9456 * term.c (encode_terminal_code): Now external again, used by
9457 w32console.c and msdos.c.
9459 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9460 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9462 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9464 Fix some minor problems found by GCC 4.5.2's static checks.
9466 * fringe.c (update_window_fringes): Mark locals as initialized
9468 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9470 * alloc.c (mark_fringe_data): Move decl from here ...
9471 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9472 to check its interface.
9473 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9475 * fontset.c (free_realized_fontset): Now static.
9476 (Fset_fontset_font): Rename local to avoid shadowing.
9477 (fontset_font): Mark local as initialized.
9478 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9480 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9482 * xselect.c (x_disown_buffer_selections): Remove; not used.
9483 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9484 (x_own_selection, Fx_disown_selection_internal): Rename locals
9486 (x_handle_dnd_message): Remove local to avoid shadowing.
9488 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9489 so that the caller can use some name other than gcpro1.
9490 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9491 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9492 (Fx_backspace_delete_keys_p):
9493 Use them to avoid shadowing, and rename vars to avoid shadowing.
9494 (x_decode_color, x_set_name, x_window): Now static.
9495 (Fx_create_frame): Add braces to silence GCC warning.
9496 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9497 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9498 Remove unused locals.
9499 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9500 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9501 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9504 * xterm.h (x_mouse_leave): New decl.
9506 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9507 Remove unused functions.
9508 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9509 (x_calc_absolute_position): Now static.
9510 (XTread_socket): Don't define label "out" unless it's used.
9511 Don't declare local "event" unless it's used.
9512 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9513 unless they are used.
9514 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9515 (x_fatal_error_signal): Remove; not used.
9516 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9517 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9518 (x_error_catcher, x_connection_closed, x_error_handler):
9519 (x_error_quitter, xembed_send_message, x_iconify_frame):
9520 (my_log_handler): Rename locals to avoid shadowing.
9521 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9522 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9524 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9525 Rename or move locals to avoid shadowing.
9526 (tty_defined_color, merge_face_heights): Now static.
9527 (free_realized_faces_for_fontset): Remove; not used.
9528 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9529 does not deduce is never used uninitialized.
9530 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9531 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9533 * terminal.c (store_terminal_param): Now static.
9535 * xmenu.c (menu_highlight_callback): Now static.
9536 (set_frame_menubar): Remove unused local.
9537 (xmenu_show): Rename parameter to avoid shadowing.
9538 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9539 since they might point to immutable storage.
9540 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9541 since it's unused otherwise.
9543 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9544 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9545 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9546 avoids a gcc -Wuninitialized diagnostic.
9547 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9548 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9549 does not deduce are never used uninitialized.
9551 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9553 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9554 * window.c (window_loop, size_window):
9555 (run_window_configuration_change_hook, enlarge_window): Likewise.
9557 * window.c (display_buffer): Now static.
9558 (size_window): Mark variables that gcc -Wuninitialized
9559 does not deduce are never used uninitialized.
9560 * window.h (check_all_windows): New decl, to forestall
9561 gcc -Wmissing-prototypes diagnostic.
9562 * dispextern.h (bidi_dump_cached_states): Likewise.
9564 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9566 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9568 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9569 and to avoid gcc -Wuninitialized warning.
9570 (load_charset_map): Mark variables that gcc -Wuninitialized
9571 does not deduce are never used uninitialized.
9572 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9574 * coding.c (coding_set_source, coding_set_destination):
9575 Use "else { /* comment */ }" rather than "else /* comment */;"
9576 for clarity, and to avoid gcc -Wempty-body warning.
9577 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9578 a block, when the outer 'i' will do.
9579 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9580 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9581 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9582 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9583 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9584 Rename locals to avoid shadowing.
9585 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9586 * coding.c (emacs_mule_char, encode_invocation_designation):
9587 Now static, since they're not used elsewhere.
9588 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9589 (decode_coding_object, encode_coding_object, detect_coding_system):
9590 (decode_coding_emacs_mule): Mark variables that gcc
9591 -Wuninitialized does not deduce are never used uninitialized.
9592 (detect_coding_iso_2022): Initialize a local variable that might
9593 be used uninitialized. Leave a FIXME because it's not clear that
9594 this initialization is needed. (Bug#8211)
9595 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9596 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9597 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9598 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9599 Remove unused macros.
9601 * category.c (hash_get_category_set): Remove unused local var.
9602 (copy_category_table): Now static, since it's not used elsewhere.
9603 * character.c (string_count_byte8): Likewise.
9605 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9606 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9608 * chartab.c (copy_sub_char_table): Now static, since it's not used
9610 (sub_char_table_ref_and_range, char_table_ref_and_range):
9611 Rename locals to avoid shadowing.
9612 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9614 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9615 (BIDI_BOB): Remove unused macro.
9617 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9618 deduce are never used uninitialized.
9619 * term.c (encode_terminal_code): Likewise.
9621 * term.c (encode_terminal_code): Now static. Remove unused local.
9623 * tparam.h: New file.
9624 * term.c, tparam.h: Include it.
9625 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9626 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9627 Move these decls to tparam.h, and make them agree with what
9628 is actually in tparam.c. The previous trick of using incompatible
9629 decls in different modules does not conform to the C standard.
9630 All callers of tparam changed to use tparam's actual API.
9631 * tparam.c (tparam1, tparam, tgoto):
9632 Use const pointers where appropriate.
9634 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9635 * cm.h (struct cm): Likewise.
9636 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9637 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9638 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9639 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9640 (turn_on_face, init_tty): Likewise.
9641 * termchar.h (struct tty_display_info): Likewise.
9643 * term.c (term_mouse_position): Rename local to avoid shadowing.
9645 * alloc.c (mark_ttys): Move decl from here ...
9646 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9648 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9650 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9652 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9654 * search.c (compile_pattern_1): Remove argument regp, unused since
9655 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9656 (compile_pattern): Don't pass it.
9658 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9660 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9661 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9663 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9665 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9667 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9668 gdk_window_get_screen, gdk_window_get_geometry,
9669 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9670 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9671 (xg_get_pixbuf_from_pixmap): New function.
9672 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9673 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9674 Call xg_get_pixbuf_from_pixmap instead of
9675 gdk_pixbuf_get_from_drawable.
9676 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9677 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9678 (xg_check_special_colors): Use GtkStyleContext and its functions
9680 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9681 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9682 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9683 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9684 Call gtk_widget_get_preferred_size.
9685 (xg_frame_resized): gdk_window_get_geometry only takes 5
9687 (xg_win_to_widget, xg_event_is_for_menubar):
9688 Call gdk_x11_window_lookup_for_display.
9689 (xg_set_widget_bg): New function.
9690 (delete_cb): New function.
9691 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9692 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9693 (xg_set_background_color): Call xg_set_widget_bg.
9694 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9695 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9696 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9697 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9699 (update_frame_tool_bar): Call gtk_widget_hide.
9700 (xg_initialize): Use GDK_KEY_g.
9702 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9704 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9706 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9707 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9708 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9710 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9712 * w32xfns.c (select_palette): Check success of RealizePalette against
9713 GDI_ERROR, not zero.
9715 See ChangeLog.11 for earlier changes.
9721 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9723 This file is part of GNU Emacs.
9725 GNU Emacs is free software: you can redistribute it and/or modify
9726 it under the terms of the GNU General Public License as published by
9727 the Free Software Foundation, either version 3 of the License, or
9728 (at your option) any later version.
9730 GNU Emacs is distributed in the hope that it will be useful,
9731 but WITHOUT ANY WARRANTY; without even the implied warranty of
9732 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9733 GNU General Public License for more details.
9735 You should have received a copy of the GNU General Public License
9736 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.