1 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
3 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
4 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
6 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
8 2012-07-29 Jan Djärv <jan.h.d@swipnet.se>
10 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
11 setting sitelisp (Bug#12010).
13 2012-07-29 Eli Zaretskii <eliz@gnu.org>
15 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
17 * w32heap.c (cache_system_info):
19 * w32proc.c (find_child_console, sys_kill): All users changed.
21 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
23 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
25 2012-07-29 Eli Zaretskii <eliz@gnu.org>
27 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
29 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
31 Cleanup statistics calculation in Fgarbage_collect.
32 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
33 zombies percentage calculation. Simplify elapsed time calculation.
35 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
37 Generalize marker debugging code under MARKER_DEBUG and use eassert.
38 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
39 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
40 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
41 (replace_range, replace_range_2, del_range_2): Change to eassert.
42 * marker.c (byte_char_debug_check): Adjust style.
44 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
46 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
47 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
48 long-ago-commented-out code that talks about "WIN32".
49 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
52 2012-07-28 Paul Eggert <eggert@cs.ucla.edu>
54 Use Gnulib stdalign module (Bug#9772, Bug#9960).
55 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
56 Simplify by using alignof.
57 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
58 * lisp.h: Include <stdalign.h>.
59 (GCALIGNMENT): New macro and constant.
60 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
61 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
62 (stdalign): New macro, if not already defined.
64 2012-07-28 Eli Zaretskii <eliz@gnu.org>
66 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
67 * w32inevt.c: Include w32inevt.h.
68 (w32_read_console_input): New inline function, calls either
69 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
70 w32_console_unicode_input.
71 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
72 (w32_kbd_patch_key, key_event): Use the codepage returned by
73 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
74 (key_event): use uChar.UnicodeChar only if
75 w32_console_unicode_input is non-zero.
77 * w32console.c: Include w32heap.h.
78 <w32_console_unicode_input>: New global variable.
79 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
80 family of Windows, zero otherwise.
82 * w32inevt.h: Declare w32_console_unicode_input.
84 * xdisp.c (init_iterator): Don't reference tip_frame in a build
85 --without-x. (Bug#11742)
87 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
89 Adjust GDB to reflect pvec_type changes (Bug#12036).
90 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
91 2012-07-04 changes to pseudovector representation. Problem
92 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
94 2012-07-27 Michael Albinus <michael.albinus@gmx.de>
96 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
98 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
100 2012-07-27 Eli Zaretskii <eliz@gnu.org>
102 * alloc.c (listn): Fix the order the arguments are consed onto the
105 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
106 enumeration constants, as PURE and HEAP are too general, and clash
107 with other headers and sources, such as gmalloc.c and the
108 MS-Windows system headers. All users changed.
110 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
112 Revert last save_excursion_save and save_excursion_restore changes.
113 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
114 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
116 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
118 Fix recently-introduced typos in Windows port.
119 Reported by Martin Rudalics <rudalics@gmx.at>.
120 * w32.c (init_environment): Replace comma with semicolon.
121 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
123 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
125 Improve GDB symbol export (Bug#12036).
126 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
127 arms of an 'if', not using conditional expressions; otherwise GDB
128 complains about the types in the unevaluated arm when the argument
129 is an integer literal.
130 (xgetint): Simplify expression.
131 * alloc.c (gdb_make_enums_visible): New constant. This ports to
132 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
133 Zaretskii in <http://bugs.gnu.org/12036#13>.
134 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
135 needed now that we have gdb_make_enums_visible.
136 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
137 (enum enum_USE_LSB_TAG):
138 New enum types, packaging up enums that need to be exported to GDB.
140 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
142 Utility function to make a list from specified amount of objects.
143 * lisp.h (enum constype): New datatype.
144 (listn): New prototype.
145 * alloc.c (listn): New function.
146 (Fmemory_use_count, syms_of_alloc): Use it.
147 * buffer.c (syms_of_buffer): Likewise.
148 * callint.c (syms_of_callint): Likewise.
149 * charset.c (define_charset_internal): Likewise.
150 * coding.c (syms_of_coding): Likewise.
151 * keymap.c (syms_of_keymap): Likewise.
152 * search.c (syms_of_search): Likewise.
153 * syntax.c (syms_of_syntax): Likewise.
154 * w32.c (init_environment): Likewise.
155 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
156 * xdisp.c (syms_of_xdisp): Likewise.
157 * xfns.c (syms_of_xfns): Likewise.
159 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
161 Fast save_excursion_save and save_excursion_restore.
162 * lisp.h (struct Lisp_Excursion): New data type.
163 (PVEC_EXCURSION): New pseudovector type.
164 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
165 to deal with it. Adjust comments.
166 (init_marker, attach_marker): New prototype.
167 (unchain_marker): Adjust prototype.
168 * marker.c (attach_marker): Change to global.
169 (init_marker): New function.
170 * alloc.c (Fmake_marker, build_marker): Use it.
171 (build_marker): More easserts.
172 (mark_object): Handle struct Lisp_Excursion.
173 * editfns.c (save_excursion_save, save_excursion_restore):
174 Reimplement to use struct Lisp_Excursion. Add comments.
176 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
178 Fix export of symbols to GDB (Bug#12036).
179 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
180 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
181 emacs.c, as this is a more-suitable home. Had this been done earlier
182 the fix for 12036 would have avoided some of the problems noted in
183 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
184 would have been more obvious.
185 * emacs.c: Do not include <verify.h>; no longer needed.
186 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
187 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
188 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
189 Remove; now done in lisp.h.
190 * lisp.h (PUBLISH_TO_GDB): New macro.
191 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
192 (DATA_SEG_BITS): Use it.
193 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
194 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
195 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
196 not be usable in #if. This simplifies things.
198 2012-07-26 Juanma Barranquero <lekktu@gmail.com>
200 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
202 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
204 Simplify export of symbols to GDB (Bug#12036).
205 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
206 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
207 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
208 Adjust to changes in lisp.h and emacs.c, by using
209 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
210 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
211 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
212 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
213 instead of gdb_valbits.
214 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
215 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
216 instead of gdb_array_mark_flag.
217 (xboolvector): Get size from $->size, not $->header.size.
218 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
219 (xreload, hook-run, hookpost-run): Remove.
220 * emacs.c: Include <verify.h>.
221 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
222 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
224 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
225 (gdb_USE_LSB_TAG): New enum constants.
226 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
227 Also define these as enum constants, so they're visible to GDB.
228 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
229 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
230 as constants, so they're visible to GDB.
231 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
232 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
233 Now enum constants, not macros, so they're visible to GDB.
234 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
235 more convenient now. All uses changed.
236 (VALMASK) [USE_LSB_TAG]: Also define in this case.
237 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
239 2012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
241 Explicitly free restriction data that are not needed anymore.
242 * editfns.c (save_restriction_restore): Free restriction data.
244 2012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
246 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
247 add argument, tune behavior, and adjust all callers.
249 2012-07-25 Paul Eggert <eggert@cs.ucla.edu>
251 Use typedef for EMACS_INT, EMACS_UINT.
252 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
253 than macros. This simplifies debugging in the usual case, since
254 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
255 and it allows expressions involving EMACS_INT casts.
256 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
258 2012-07-25 Jan Djärv <jan.h.d@swipnet.se>
260 * nsterm.m (ns_read_socket): Return early if there is a modal
263 2012-07-25 Martin Rudalics <rudalics@gmx.at>
265 * frame.c (Fredirect_frame_focus): In doc-string don't mention
266 that FOCUS-FRAME can be omitted.
268 2012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
270 Adjust buffer text indirection counters at the end of Fkill_buffer.
271 * buffer.c (Fkill_buffer): Adjust indirection counters when the
272 buffer is definitely dead. This should really fix an issue reported
273 by Christoph Scholtes again. (Bug#12007).
274 (init_buffer_once): Initialize indirection counters of
275 buffer_defaults and buffer_local_symbols (for sanity and safety).
277 2012-07-24 Eli Zaretskii <eliz@gnu.org>
279 * xdisp.c (init_iterator): Don't compute dimensions of truncation
280 and continuation glyphs on tooltip frames, leave them at zero.
281 Avoids continued lines in tooltips. (Bug#11832)
283 2012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
285 Simplify copy_overlay.
286 * buffer.c (copy_overlay): Simplify. Use build_marker.
287 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
289 2012-07-23 Eli Zaretskii <eliz@gnu.org>
291 * print.c (print_object): Don't crash when a frame's name is nil
292 or invalid. (Bug#12025)
294 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
295 it signals an error when a tooltip frame is being created.
297 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
299 Cleanup miscellaneous objects allocation and initialization.
300 * alloc.c (allocate_misc): Change to static. Add argument to
301 specify the subtype. Adjust comment and users.
302 (build_overlay): New function.
303 * buffer.c (copy_overlays, Fmake_overlay): Use it.
304 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
305 (allocate_misc): Remove prototype.
306 (build_overlay): Add prototype.
308 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
310 Swap buffer text indirection counters in Fbuffer_swap_text.
311 * buffer.c (Fbuffer_swap_text): Swap indirections too.
312 This avoids crash reported by Christoph Scholtes at
313 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
315 2012-07-22 Jan Djärv <jan.h.d@swipnet.se>
317 * nsmenu.m (Popdown_data): New struct.
318 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
320 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
321 (initWithContentRect): Make imgView and contentView non-static
322 and autorelease them. Also autorelease img and matrix (Bug#12005).
323 (dealloc): Remove (Bug#12005).
325 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
327 Adjust consing_since_gc when objects are explicitly freed.
328 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
329 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
330 (free_cons, free_misc): Subtract object size from consing_since_gc.
332 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
334 Simplify and cleanup markers positioning code.
335 * marker.c (attach_marker): More useful eassert.
336 (live_buffer, set_marker_internal): New function.
337 (Fset_marker, set_marker_restricted): Use set_marker_internal.
338 (set_marker_both, set_marker_restricted_both): Use live_buffer.
340 2012-07-22 Paul Eggert <eggert@cs.ucla.edu>
342 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
343 as it's limited by the amount of memory, not by INT_MAX.
345 2012-07-21 Eli Zaretskii <eliz@gnu.org>
347 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
348 in special-event-map. See the discussion at
349 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
352 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
353 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
354 Fabrice Popineau <fabrice.popineau@supelec.fr>.
356 2012-07-21 Jan Djärv <jan.h.d@swipnet.se>
358 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
359 (conversationIdentifier): Return value is NSInteger.
360 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
362 2012-07-21 Chong Yidong <cyd@gnu.org>
364 * window.c (decode_any_window): Signal an error if the window is
365 on a dead frame (Bug#11984).
367 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
369 Add indirection counting to speed up Fkill_buffer.
370 * buffer.h (struct buffer): New member.
371 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
372 (Fmake_indirect_buffer): Set indirection counter to -1, increment
373 base buffer indirection counter.
374 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
375 (Fkill_buffer): Adjust indirection counters as needed, don't walk
376 through buffer list if indirection counter is 0.
378 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
380 Extend the value returned by Fgarbage_collect with heap statistics.
381 * alloc.c (Qheap): New symbol.
382 (syms_of_alloc): DEFSYM it.
383 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
384 (Fmemory_free): Remove.
385 (syms_of_alloc): Don't defsubr it.
386 * buffer.c (Fcompact_buffer): Remove.
387 (syms_of_buffer): Don't defsubr it.
389 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
391 Make maybe_gc inline.
392 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
393 * lisp.h (consing_since_gc, gc_relative_threshold)
394 (memory_full_cons_threshold): Revert declaration.
395 (maybe_gc): Remove prototype, define as inline.
396 * alloc.c: Remove old commented-out code.
397 (consing_since_gc, gc_relative_threshold)
398 (memory_full_cons_threshold): Revert to global.
401 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
403 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
404 * lisp.h (build_unibyte_string): New function.
405 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
406 * sysdep.c, w32fns.c, xfns.c: Use it.
407 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
408 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
409 Adjust users accordingly.
410 * font.h (font_open_by_name): Adjust prototype.
412 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
414 Cleanup calls to Fgarbage_collect.
415 * lisp.h (maybe_gc): New prototype.
416 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
418 * alloc.c (maybe_gc): New function.
419 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
421 * bytecode.c (MAYBE_GC): Use maybe_gc.
422 * eval.c (eval_sub, Ffuncall): Likewise.
423 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
424 to avoid dependency from auto-save feature.
426 2012-07-19 Paul Eggert <eggert@cs.ucla.edu>
428 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
429 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
430 'for_each_per_buffer_object_at'.
431 All uses changed. It's better to use upper-case for macros that
432 cannot be implemented as functions, to give the reader a clue
433 that they're special.
435 2012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
437 * alloc.c (Fgarbage_collect): Tweak docstring.
439 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
441 Tweak the value returned from Fgarbage_collect again.
442 * alloc.c (Fgarbage_collect): New return value, as confirmed in
443 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
444 Adjust documentation.
445 (total_vector_bytes): Rename to total_vector_slots, adjust
447 (total_free_vector_bytes): Rename to total_free_vector_slots,
449 (Qstring_bytes, Qvector_slots): New symbols.
450 (syms_of_alloc): DEFSYM them.
452 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
454 Buffer compaction primitive which may be used from Lisp.
455 * buffer.c (compact_buffer, Fcompact_buffer): New function.
456 (syms_of_buffer): Register Fcompact_buffer.
457 * alloc.c (Fgarbage_collect): Use compact_buffer.
458 * buffer.h (compact_buffer): New prototype.
459 (struct buffer_text): New member.
461 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
463 New macro to iterate over all buffers, miscellaneous cleanups.
464 * lisp.h (all_buffers): Remove declaration.
465 * buffer.h (all_buffers): Add declaration, with comment.
466 (for_each_buffer): New macro.
467 * alloc.c (Fgarbage_collect, mark_object): Use it.
468 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
469 (init_buffer): Likewise.
470 * data.c (Fset_default): Likewise.
471 * coding.c (code_conversion_restore): Remove redundant check
473 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
475 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
477 Fix bug that created negative-length intervals.
478 * intervals.c (merge_interval_right, merge_interval_left):
479 Do not zero out this interval if it is absorbed by its children,
480 as this interval's total length doesn't change in that case. See
481 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
483 2012-07-18 Paul Eggert <eggert@cs.ucla.edu>
485 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
486 when invoking (make-bool-vector N t) and N is a positive
487 multiple of 8 -- the last 8 bits were mistakenly cleared.
489 Remove some struct layout assumptions in bool vectors.
490 * alloc.c (bool_header_size): New constant.
491 (header_size, word_size): Move earlier, as they're now used earlier.
492 Use 'word_size' in a few more places, where it's appropriate.
493 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
494 padding before the data member of a bool vector.
495 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
496 than doing the check by hand with an abort ().
498 2012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
500 * eval.c (Fdefvar): Don't check constants since we only set the var if
501 it's not yet defined anyway (bug#11904).
503 * lisp.h (last_undo_boundary): Declare new var.
504 * keyboard.c (command_loop_1): Set it.
505 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
506 were auto-added by the command loop (bug#11774).
508 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
510 * w32font.c (Qsymbol): Remove local definition.
511 (syms_of_w32font): Don't DEFSYM it.
513 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
515 Fix sweep_vectors to handle large bool vectors correctly.
516 * alloc.c (sweep_vectors): Account total_vector_bytes for
517 bool vectors larger than VBLOCK_BYTES_MAX.
519 2012-07-18 Chong Yidong <cyd@gnu.org>
521 * frame.c (x_set_frame_parameters): Revert bogus change introduced
522 in 2012-05-25 commit by Paul Eggert (Bug#11738).
524 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
526 Return more descriptive data from Fgarbage_collect.
527 Suggested by Stefan Monnier in
528 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
529 * alloc.c (bounded_number): New function.
530 (total_buffers, total_vectors): New variable.
531 (total_string_size): Rename to total_string_bytes, adjust users.
532 (total_vector_size): Rename to total_vector_bytes, adjust users.
533 (sweep_vectors): Account total_vectors and total_vector_bytes.
534 (Fgarbage_collect): New return value. Adjust documentation.
535 (gc_sweep): Account total_buffers.
536 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
537 (VECTOR_SIZE): Remove.
538 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
539 (Qinterval, Qmisc): New symbols.
540 (syms_of_data): Initialize them.
541 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
542 (Qcons, Qbuffer): New declarations.
544 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
546 * alloc.c (Fmemory_free): Account for memory-free's own storage.
547 Round up, not down. Improve doc.
549 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
551 Restore old code in allocate_string_data to avoid Faset breakage.
552 Reported by Julien Danjou <julien@danjou.info> in
553 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
554 * alloc.c (allocate_string_data): Restore old code with minor
555 adjustments, fix comment to explain this subtle issue.
557 2012-07-17 Eli Zaretskii <eliz@gnu.org>
559 Remove FILE_SYSTEM_CASE.
560 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
562 * fileio.c (FILE_SYSTEM_CASE): Don't define.
563 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
564 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
565 call-process-region passes it through expand-file-name.
567 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
569 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
571 Fix crash when creating indirect buffer (Bug#11917)
572 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
573 Don't handle unbound variables specially if non-zero.
574 (Fbuffer_local_variables): Pass zero.
575 (clone_per_buffer_values): Pass non-zero.
577 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
579 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
580 to make the loop interruptible.
582 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
584 * gnutls.c (emacs_gnutls_handshake): Only retry if
585 GNUTLS_E_INTERRUPTED.
587 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
589 Cleanup and convert miscellaneous checks to eassert.
590 * alloc.c (mark_interval): Fix comment, partially rephrase
591 old comment from intervals.h (see below).
592 * intervals.c (find_interval, adjust_intervals_for_insertion)
593 (delete_interval, adjust_intervals_for_deletion)
594 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
596 (adjust_intervals_for_insertion, make_new_interval):
597 Remove obsolete and unused code.
598 * intervals.h (struct interval): Remove obsolete comment.
599 * textprotp.c (erase_properties): Remove unused code.
600 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
601 (Fremove_list_of_text_properties): Convert to eassert.
603 2012-07-17 Chong Yidong <cyd@gnu.org>
605 * editfns.c (Finsert_char): Doc fix.
607 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
609 Fix previous change to make Fmemory_free always accurate.
610 * alloc.c (make_interval): Update total_free_intervals.
611 (make_float): Likewise for total_free_floats.
612 (free_cons, Fcons): Likewise for total_free_conses.
613 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
614 Likewise for total_free_vector_bytes.
615 (Fmake_symbol): Likewise for total_free_symbols.
616 (bytes_free): Remove.
618 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
620 Simple free memory accounting feature.
621 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
622 (sweep_vectors): Accumulate size of free vectors.
623 (Fgarbage_collect): Setup bytes_free.
624 (Fmemory_free): New function.
625 (syms_of_alloc): Register it.
627 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
629 Cleanup overlays checking.
630 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
631 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
632 eassert and OVERLAYP.
633 (sort_overlays): Change to use OVERLAYP.
635 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
637 * editfns.c (Finsert_char): Make it interactive, and make the
638 second arg optional. Copy interactive spec and docstring from
641 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
643 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
644 Unlike the other wrapped functions, fabs has an unspecified
647 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
649 * nsterm.m (keyDown): Interpret flags without left/right bits
650 as the left key (Bug#11670).
652 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
654 Remove empty and useless init functions.
655 * lisp.h (init_character_once, init_fns, init_image)
656 (init_filelock, init_sound): Remove prototype.
657 * character.c (init_character_once): Remove.
658 * filelock.c (init_filelock): Likewise.
659 * fns.c (init_fns): Likewise.
660 * image.c (init_image): Likewise.
661 * sound.c (init_sound): Likewise.
662 * emacs.c (main): Adjust accordingly.
664 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
666 * gtkutil.h: Tiny cleanups.
667 (use_old_gtk_file_dialog): Remove useless declaration.
668 (xg_uses_old_file_dialog): Add suggested const attribute.
670 2012-07-15 Eli Zaretskii <eliz@gnu.org>
672 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
673 (bidi_paragraph_init): Use it to limit search forward for a strong
674 directional character in abnormally large paragraphs full of
675 neutral or weak characters. (Bug#11943)
677 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
679 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
680 the toolbar (Bug#9451).
681 (xg_make_tool_item): Give the widget event box a transparent
684 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
686 Cleanup basic allocation variables and functions.
687 * alloc.c (ignore_warnings, init_intervals, init_float)
688 (init_cons, init_symbol, init_marker): Remove.
689 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
690 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
691 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
692 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
693 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
694 (staticidx, init_alloc_once, init_strings, free_ablock):
695 Remove redundant initialization.
696 * fns.c (init_weak_hash_tables): Remove.
697 * lisp.h (init_weak_hash_tables): Remove prototype.
699 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
701 Use zero_vector where appropriate.
702 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
704 * lisp.h (zero_vector): New declaration.
705 * font.c (null_vector): Remove.
706 (syms_of_font): Remove initialization and staticpro.
707 (font_list_entities, font_find_for_lface): Change to use zero_vector.
708 * keymap.c (Faccessible_keymaps): Likewise.
710 2012-07-15 Leo Liu <sdl.web@gmail.com>
712 * fringe.c: Fix typo in comments.
714 2012-07-14 Leo Liu <sdl.web@gmail.com>
716 * fringe.c: Add a new bitmap exclamation-mark.
718 2012-07-14 Eli Zaretskii <eliz@gnu.org>
720 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
722 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
723 (HAVE_MENUS): Don't define, defined by editing config.in with
725 (GMALLOC_INHIBIT_VALLOC): Don't define.
726 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
728 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
730 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
732 2012-07-14 Glenn Morris <rgm@gnu.org>
734 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
735 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
736 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
738 2012-07-13 Glenn Morris <rgm@gnu.org>
740 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
742 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
743 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
745 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
747 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
748 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
749 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
750 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
752 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
753 as boolean expression.
754 (x_set_window_size): Remove unused variable toolbar.
755 (ns_get_color_default, ns_mod_to_lisp): Remove.
756 (ns_mouse_position): Remove unused variables xchar and ychar.
757 (ns_compute_glyph_string_overhangs): Remove unused variable face.
758 (ns_set_vertical_scroll_bar): Remove unused variable count.
759 (ns_delete_terminal): Remove unused variable i.
760 (ns_term_init): Remove unused variables r, g and b.
761 (mouseDown): Remove unused variable window.
762 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
763 (initFrameFromEmacs): Remove unused variable vbextra.
764 (mouseEntered): Remove unused variables p and dpyinfo.
765 (mouseExited): Remove unused variables p and r.
766 (ns_define_frame_cursor, ns_clear_frame_area)
767 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
768 (menuDown): Assign [sender tag] to variable and cast the variable.
770 * nsterm.h (menuDown): Add id as type to argument sender.
771 (ns_display_info_for_name): Add Lisp_Object argument.
772 (ns_term_init): Add Lisp_Object argument.
773 (ns_map_event_to_object): Add void argument.
774 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
775 prototype with arguments and only declare if __OBJC__.
776 (nxatoms_of_nsselect): Add void argument.
777 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
778 (ns_alloc_autorelease_pool): Add void argument.
779 (ns_release_autorelease_pool): Add void* argument.
780 (ns_get_defaults_value): Add const char* argument.
782 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
783 (initFromContents): Use SSDATA where appropriate.
784 (ns_update_menubar): Add braces to ambigous if-else.
785 (initWithTitle): Put () around assignment in if statement.
786 (ns_menu_show): Remove unused variables window and keymap.
787 (update_frame_tool_bar): Remove unused variable selected_p.
788 (initWithContentRect): Remove unused variable this_cmd_name.
790 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
792 (setXBMColor): Remove unused variable len.
793 (setPixmapData): Put () around assignment in loop statement.
795 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
796 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
798 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
799 around assignment in loop statement.
800 (nsfont_open): Remove unused variable i.
801 (nsfont_open): Remove unused variable len.
802 (nsfont_draw): Remove unused variable cs.
804 * nsfns.m (x_set_icon_name, ns_set_name_internal)
805 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
806 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
807 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
808 (Fns_font_name, Fns_perform_service)
809 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
810 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
811 (ns_set_name): Remove unused variable view.
812 (x_set_menu_bar_lines): Remove unused variable olines.
813 (x_set_tool_bar_lines): Remove unused variable root_window.
814 (Fns_list_colors): Put () around assignment in while statement.
815 (Fns_perform_service): Remove unused variable len.
816 (Fns_display_usable_bounds): Remove unused variable top.
817 (syms_of_nsfns): Remove unused variable i.
819 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
822 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
824 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
825 and free it with DestroyExceptionInfo (Bug#11558).
827 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
829 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
830 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
831 Set here, not in nt/config.nt.
833 2012-07-13 Eli Zaretskii <eliz@gnu.org>
835 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
836 cursor overflow into the last glyph on display line when the right
837 fringe is off. (Bug#11832)
839 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
841 * xdisp.c (produce_special_glyphs): Now static.
842 * dispextern.h (produce_special_glyphs): Remove decl.
844 2012-07-13 Glenn Morris <rgm@gnu.org>
846 * s/bsd-common, s/cygwin.h: Remove empty files.
847 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
849 * s/usg5-4-common.h (USG, USG5):
850 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
851 * s/sol2-6.h (SOLARIS2):
852 * s/irix6-5.h (IRIX6_5):
853 * s/hpux10-20.h (USG, USG5, HPUX):
854 * s/gnu-linux.h (USG, GNU_LINUX):
855 * s/freebsd.h (BSD_SYSTEM):
856 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
857 * s/cygwin.h (CYGWIN):
858 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
859 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
861 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
863 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
865 2012-07-13 Glenn Morris <rgm@gnu.org>
867 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
869 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
871 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
872 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
874 2012-07-12 Glenn Morris <rgm@gnu.org>
876 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
878 * process.c (init_process_emacs): Rename from init_process.
879 The old name is also the name of a Mach system call.
880 * lisp.h, emacs.c: Update for this name change.
881 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
884 2012-07-12 Eli Zaretskii <eliz@gnu.org>
886 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
887 memmove call that removes glyphs covered by the left truncation
888 glyph. Improve commentary.
889 (display_line): Fix display of continuation glyphs on GUI frames
890 when the right fringe is turned off and variable-size fonts are
891 used in the window. Move the code that appends a stretch glyph to
892 produce_special_glyphs, so that it could be used for truncation
893 and continuation glyphs alike.
894 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
895 glyph of a suitably computed width, to align the special glyphs at
896 the window margin. Code moved from display_line. (Bug#11832)
898 2012-07-12 Glenn Morris <rgm@gnu.org>
900 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
902 * s/gnu-linux.h, s/hpux10-20.h:
903 Do not unconditionally define HAVE_XRMSETDATABASE.
905 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
907 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
909 Fix typos that broke OS X build.
910 Reported by Randal L. Schwartz in
911 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
912 * nsterm.m (ns_timeout): Add missing local decl.
913 (ns_get_color): snprintf -> sprintf, to fix typo.
915 2012-07-12 Glenn Morris <rgm@gnu.org>
917 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
918 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
919 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
920 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
922 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
923 Move PTY_OPEN to configure.
925 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
926 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
927 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
929 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
931 Use empty_unibyte_string where applicable.
932 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
933 * lread.c (read1): Likewise.
934 * xsettings.c (syms_of_xsettings): Likewise.
936 2012-07-12 Glenn Morris <rgm@gnu.org>
938 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
939 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
940 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
941 * s/hpux10-20.h (RUN_TIME_REMAP):
942 * s/bsd-common.h (TABDLY): Move to configure.
944 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
946 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
948 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
949 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
951 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
953 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
954 * s/template.h: Move NARROWPROTO to configure.
956 2012-07-11 Glenn Morris <rgm@gnu.org>
958 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
959 unused since 2011-01-17 change to systty.h.
961 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
962 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
963 Move HAVE_PTYS and HAVE_SOCKETS to configure.
965 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
967 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
969 2012-07-11 Glenn Morris <rgm@gnu.org>
971 * s/darwin.h, s/gnu-linux.h, s/template.h:
972 Move INTERRUPT_INPUT to configure.
974 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
976 Minor adjustments to interning code.
977 * lisp.h (intern, intern_c_string): Redefine as static inline
978 wrappers for intern_1 and intern_c_string_1, respectively.
979 (intern_1, intern_c_string_1): Rename prototypes.
980 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
982 * font.c (font_intern_prop): Likewise. Adjust comment.
983 * w32font.c (intern_font_name): Likewise.
985 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
987 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
989 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
990 of Fcar/Fcdr if possible.
991 * font.c (check_otf_features): Likewise.
992 * fontset.c (Fnew_fontset): Likewise.
993 * gnutls.c (Fgnutls_boot): Likewise.
994 * minibuf.c (read_minibuf): Likewise.
995 * msdos.c (IT_set_frame_parameters): Likewise.
996 * xmenu.c (Fx_popup_dialog): Likewise.
997 * w32menu.c (Fx_popup_dialog): Likewise.
999 2012-07-11 Glenn Morris <rgm@gnu.org>
1001 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1002 since nothing has defined it on these platforms.
1004 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1005 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1007 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1008 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1009 Move CLASH_DETECTION to configure.
1011 * s/gnu.h: Remove file, which is now empty.
1013 * s/gnu.h, s/gnu-linux.h:
1014 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1016 2012-07-11 John Wiegley <johnw@newartisans.com>
1018 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1019 function attribute, so we only use it if it exists in the
1022 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1024 Avoid call to strlen in fast_c_string_match_ignore_case.
1025 * search.c (fast_c_string_match_ignore_case): Change to use
1026 length argument. Adjust users accordingly.
1027 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1029 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1031 Assume mkdir, rmdir.
1032 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1033 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1036 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1039 * s/hpux10-20.h (HAVE_PERROR): Remove.
1040 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1041 Remove dummy definition, as this problem was obsolete long ago.
1044 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1046 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1048 Avoid calls to strlen in font processing functions.
1049 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
1050 (font_open_by_name): Change to use length argument. Adjust
1052 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1054 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1055 Change to return ptrdiff_t.
1056 (xfont_list_pattern, xfont_match): Use length returned by
1057 xfont_decode_coding_xlfd.
1058 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1060 2012-07-11 Glenn Morris <rgm@gnu.org>
1062 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1063 Move DONT_REOPEN_PTY to configure.
1065 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1066 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1068 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1070 Remove "#define unix" that is no longer needed (Bug#11905).
1071 * s/aix4-2.h (unix): Remove; no longer needed.
1073 EMACS_TIME simplification (Bug#11875).
1074 This replaces macros (which typically do not work in GDB)
1075 with functions, typedefs and enums, making the code easier to debug.
1076 The functional style also makes code easier to read and maintain.
1077 * systime.h: Include <sys/time.h> on all hosts, not just if
1078 WINDOWSNT, since 'struct timeval' is needed in general.
1079 (EMACS_TIME): Now a typedef, not a macro.
1080 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1082 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1083 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1084 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1085 (EMACS_TIME_LE): Now functions, not macros.
1086 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1087 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1088 which are not functions. All uses rewritten to use:
1089 (make_emacs_time): New function.
1090 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1091 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1092 not functions. All uses rewritten to use the following, respectively:
1093 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1094 (add_emacs_time, sub_emacs_time): New functions.
1095 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
1096 * fileio.c (Fcopy_file):
1097 * xterm.c (XTflash): Get the current time closer to when it's used.
1098 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1100 * bytecode.c (targets): Suppress -Woverride-init warnings.
1102 Simplify by avoiding confusing use of strncpy etc.
1103 * doc.c (Fsnarf_documentation):
1104 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1105 * frame.c (Fmake_terminal_frame):
1106 * gtkutil.c (get_utf8_string):
1108 * nsmenu.m (ns_update_menubar):
1109 * regex.c (regerror):
1110 Prefer memcpy to strncpy and strncat when either will do.
1111 * fileio.c (Fsubstitute_in_file_name):
1112 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1113 (menu_separator_name_p):
1114 * nsmenu.m (ns_update_menubar):
1115 Prefer memcmp to strncmp when either will do.
1116 * nsterm.m: Include <ftoastr.h>.
1118 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1119 Prefer snprintf to strncpy.
1120 * nsterm.m (ns_term_init):
1121 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1122 * nsterm.m (ns_term_init):
1123 Avoid the need for strncpy, by using build_string or
1124 make_unibyte_string directly. Use dtoastr, not snprintf.
1125 * process.c (Fmake_network_process): Diagnose service names that
1126 are too long, rather than silently truncating them or creating
1127 non-null-terminated names.
1128 (Fnetwork_interface_info): Likewise, for interface names.
1129 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1130 Prefer sprintf to strncat.
1131 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1132 Prefer vsnprintf to vsprintf + strncpy.
1134 2012-07-10 Glenn Morris <rgm@gnu.org>
1136 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1137 Clarify fallback case.
1139 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1141 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1142 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1143 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
1144 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
1145 where argument type is known to be a Lisp_Cons.
1147 2012-07-10 Tom Tromey <tromey@redhat.com>
1149 * bytecode.c (BYTE_CODE_THREADED): New macro.
1150 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1151 (enum byte_code_op): New type.
1152 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1153 (exec_byte_code): Use them. Use token threading when applicable.
1155 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1157 Optimize pure C strings initialization.
1158 * lisp.h (make_pure_string): Fix prototype.
1159 (build_pure_c_string): New function, defined as static inline. This
1160 provides a better opportunity to optimize away calls to strlen when
1161 the function is called with compile-time constant argument.
1162 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1163 argument, adjust users accordingly. Use build_pure_c_string where
1165 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1166 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1167 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1169 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1171 Avoid calls to strlen in miscellaneous functions.
1172 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1173 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1174 * lread.c (openp): Likewise.
1176 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1178 Avoid calls to strlen in path processing functions.
1179 * fileio.c (file_name_as_directory): Add comment. Change to add
1180 srclen argument and return the length of result. Adjust users
1182 (directory_file_name): Fix comment. Change to add srclen argument,
1183 swap 1st and 2nd arguments to obey the common convention. Adjust
1185 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1187 2012-07-10 Glenn Morris <rgm@gnu.org>
1189 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1190 Move PENDING_OUTPUT_COUNT definition to configure.
1192 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1193 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1194 * s/gnu.h (DATA_START): Move definitions to configure.
1196 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1197 We include usg5-4-common.h, which defines them both.
1199 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1200 O_RDONLY already includes it).
1202 Stop ns builds setting the EMACSLOADPATH environment variable.
1203 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1204 Now it does not set EMACSLOADPATH, just returns the load-path string.
1205 * nsterm.h: Update accordingly.
1206 * lread.c [HAVE_NS]: Include nsterm.h.
1207 (init_lread) [HAVE_NS]: Use ns_load_path.
1208 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1210 2012-07-09 Glenn Morris <rgm@gnu.org>
1212 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1213 since the included bsd-common.h does so.
1215 Stop ns builds setting the EMACSPATH environment variable.
1216 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1217 (ns_init_paths): Do not set EMACSPATH.
1218 * nsterm.h (ns_exec_path): Add it.
1219 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1222 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1224 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1226 * process.c (wait_reading_process_output): 'waitchannels' was unset
1227 when read_kbd || !NILP (wait_for_cell); fix this.
1229 Add GCC-style 'const' attribute to functions that can use it.
1230 * character.h (char_resolve_modifier_mask):
1231 * keyboard.h (make_ctrl_char):
1232 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1233 (init_character_once, next_almost_prime, init_fns, init_image)
1234 (flush_pending_output, init_sound):
1235 * mem-limits.h (start_of_data):
1236 * menu.h (finish_menu_items):
1237 Add ATTRIBUTE_CONST.
1238 * emacs.c (DEFINE_DUMMY_FUNCTION):
1239 Declare the dummy function with ATTRIBUTE_CONST.
1240 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1241 Add decls with ATTRIBUTE_CONST.
1243 Minor improvements to make_formatted_string.
1244 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1245 where int is good enough, as vsprintf returns an int.
1246 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1248 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1250 Use make_formatted_string to avoid double length calculation.
1251 * lisp.h (make_formatted_string): New prototype.
1252 * alloc.c (make_formatted_string): New function.
1253 * buffer.c (Fgenerate_new_buffer_name): Use it.
1254 * dbus.c (syms_of_dbusbind): Likewise.
1255 * editfns.c (Fcurrent_time_zone): Likewise.
1256 * filelock.c (get_boot_time): Likewise.
1257 * frame.c (make_terminal_frame, set_term_frame_name)
1258 (x_report_frame_params): Likewise.
1259 * image.c (gs_load): Likewise.
1260 * minibuf.c (get_minibuffer): Likewise.
1261 * msdos.c (dos_set_window_size): Likewise.
1262 * process.c (make_process): Likewise.
1263 * xdisp.c (ensure_echo_area_buffers): Likewise.
1264 * xsettings.c (apply_xft_settings): Likewise.
1266 2012-07-09 Glenn Morris <rgm@gnu.org>
1268 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1269 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1270 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1271 * nsterm.h (ns_etc_directory): Add it.
1272 * callproc.c [HAVE_NS]: Include nsterm.h.
1273 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1275 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1277 Move marker debugging code under MARKER_DEBUG.
1278 * marker.c (MARKER_DEBUG): Move marker debugging code under
1279 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1280 for bootstrap with --enable-checking (~3x slowdown reported
1281 by Juanma Barranquero <lekktu@gmail.com>).
1282 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1284 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1286 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1287 See <http://bugs.gnu.org/11825#29>.
1289 2012-07-08 Eli Zaretskii <eliz@gnu.org>
1291 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1292 has no font, use the frame's font. (Bug#11813)
1293 (display_line): Add commentary about displaying truncation glyphs
1295 (produce_special_glyphs): Move here from term.c.
1297 * term.c (produce_special_glyphs): Move to xdisp.c.
1299 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1302 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1304 * xdisp.c (display_line): Avoid warning about implicit declaration
1307 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1309 * lisp.h: Remove empty conditional.
1311 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1313 * lread.c (load_path_check): Now static.
1315 Fix some minor --with-ns problems found by static checking.
1316 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1317 (x_set_font) [!HAVE_X_WINDOWS]:
1318 * image.c (xpm_load_image) [HAVE_NS]:
1319 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1320 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1321 Remove unused local.
1322 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1323 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1324 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1325 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1326 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1327 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1328 Fix pointer signedness problem.
1329 * xfaces.c (FRAME_X_FONT_TABLE):
1330 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1332 2012-07-07 Glenn Morris <rgm@gnu.org>
1334 * lread.c (load_path_check): New function, split from init_lread.
1335 (init_lread): Reorganize. Motivation:
1336 If EMACSLOADPATH is set, check/warn about that rather than the
1337 defaults, which we are not going to use. Hence we can remove
1338 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1339 Don't warn if site-lisp directories are missing.
1340 If not installed, start from a blank load-path, since
1341 PATH_LOADSEARCH refers to the eventual installation directories.
1343 2012-07-07 Eli Zaretskii <eliz@gnu.org>
1345 Support truncation and continuation glyphs on GUI frames, when
1346 fringes are disabled. (Bug#11832)
1347 * xdisp.c (init_iterator): Get dimensions of truncation and
1348 continuation glyphs even if on GUI frames. Adjust
1349 it->last_visible_x on GUI frames when the left or right fringes,
1350 or both, are absent.
1351 (start_display, move_it_in_display_line_to): Handle the case of a
1352 GUI frame without a fringe to display continuation or truncation
1354 (insert_left_trunc_glyphs): Support GUI frames: make sure
1355 truncation glyphs overwrite enough glyphs from the current line to
1356 have sufficient space in pixels.
1357 (display_line): Support truncation and continuation glyphs on GUI
1358 frames. If some spare pixels are left on the line after inserting
1359 the truncation glyphs, fill that space with a stretch glyph of a
1360 suitably computed width.
1362 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1363 produce_glyphs, to support GUI sessions.
1365 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1367 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1369 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1371 Do not require float-time's arg to fit in time_t (Bug#11825).
1372 This works better on hosts where time_t is unsigned, and where
1373 float-time is applied to the (negative) difference between two times.
1374 * editfns.c (decode_time_components): Last arg is now double *,
1375 not int *, and means to store all the result as a double, without
1376 worrying about whether the seconds part fits in time_t.
1377 All callers changed.
1378 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1379 All callers changed.
1380 (Ffloat_time): Do not fail merely because the specified time falls
1381 outside of time_t range.
1383 2012-07-07 Glenn Morris <rgm@gnu.org>
1385 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1386 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1387 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1389 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
1391 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1392 Update dependencies.
1394 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1396 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1398 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1399 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1400 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1401 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1402 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1403 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1405 * xfont.c (compare_font_names): Redo to omit the need for casts.
1407 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1409 * xfns.c (Fx_change_window_property): Doc fix.
1410 * w32fns.c (Fx_change_window_property): Doc fix.
1412 * w32fns.c (Fx_window_property): Accept the same arguments as the
1413 X Windows version. Doc fix.
1414 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1416 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
1417 Eli Zaretskii <eliz@gnu.org>
1419 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1420 Windows-specific code from nt/config.nt moved here.
1421 Obsolete settings removed.
1423 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1425 * process.c: Avoid unnecessary calls to gettime.
1426 (wait_reading_process_output): Don't get the time of day
1427 when gobbling data immediately and not waiting, as there's no need
1428 for it in that case. This removes a FIXME.
1430 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1432 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1433 is defined (Bug#11768).
1435 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1437 Fix marker debugging code.
1438 * marker.c (byte_char_debug_check): Do not perform the check
1439 if buffer is not multibyte.
1440 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1441 Call byte_char_debug_check with correct arguments.
1443 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1445 Compile marker debugging code only if ENABLE_CHECKING is defined.
1446 * marker.c (byte_char_debug_check, count_markers):
1447 Use only if ENABLE_CHECKING is defined.
1448 (byte_debug_flag): Remove.
1449 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1450 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1452 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1454 Avoid code repetition in marker-related functions.
1455 * marker.c (attach_marker): New function.
1456 (Fset_marker, set_marker_restricted, set_marker_both)
1457 (set_marker_restricted_both): Use it.
1458 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1459 Consistently rename charno to charpos.
1460 (marker_position): Add eassert.
1461 (marker_byte_position): Convert to eassert.
1463 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1465 Simplify list operations in unchain_overlay and unchain_marker.
1466 * buffer.c (unchain_overlay): Simplify. Add comment.
1467 * marker.c (unchain_marker): Simplify. Fix comments.
1469 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1471 Introduce fast path for the widely used marker operation.
1472 * alloc.c (build_marker): New function.
1473 * lisp.h (build_marker): New prototype.
1474 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1475 * composite.c (autocmp_chars): Likewise.
1476 * editfns.c (buildmark): Remove.
1477 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1478 (save_restriction_save): Use build_marker.
1479 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1480 * window.c (save_window_save): Likewise.
1482 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1484 Do not use Fdelete_overlay in delete_all_overlays
1485 to avoid redundant calls to unchain_overlay.
1486 * buffer.c (drop_overlay): New function.
1487 (delete_all_overlays, Fdelete_overlay): Use it.
1488 * minibuf.c (get_minibuffer): Fix comment.
1490 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1492 Port to OpenBSD 5.1 amd64.
1493 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1494 This is needed for OpenBSD, and should be harmless on all BSD systems.
1495 Also, include <sys/sysctl.h>, as it should be available on all
1496 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1497 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1498 use p_pid member, not kp_proc.pid.
1500 2012-07-06 Glenn Morris <rgm@gnu.org>
1502 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1504 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1506 More xmalloc and related cleanup.
1507 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1508 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1509 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1510 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1511 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1512 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1513 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1514 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1515 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1517 Omit needless casts involving void * pointers and allocation.
1518 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1519 as the former is more robust if P's type is changed.
1520 Prefer xzalloc to xmalloc + memset 0.
1521 Simplify malloc-or-realloc to realloc.
1522 Don't worry about xmalloc returning a null pointer.
1523 Prefer xstrdup to xmalloc + strcpy.
1524 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1526 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1527 alloca of a constant.
1529 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1531 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1532 hscroll is larger than the line width. Fixes long and futile
1533 looping inside extend_face_to_end_of_line (on a TTY) producing
1534 glyphs that are not needed and thrown away.
1536 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1538 * marker.c (set_marker_restricted_both): Simplify by using
1541 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1543 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1545 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1547 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1548 not defined (Bug#11768).
1549 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1550 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1551 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1552 followed by gtk_box_set_homogeneous (Bug#11768).
1553 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
1554 (update_theme_scrollbar_width, xg_create_scroll_bar):
1555 Use gtk_scrollbar_new (Bug#11768).
1556 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1557 (is_box_type): New function (Bug#11768).
1558 (xg_tool_item_stale_p): Call is_box_type.
1559 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
1560 with default display (Bug#11768).
1562 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1564 * xdisp.c (window_hscroll_limited): New function.
1565 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1566 coordinates when window's hscroll is set to insanely large
1569 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
1571 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1572 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1574 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1577 * lisp.h (xzalloc): New prototype. Omit needless casts.
1578 * alloc.c (xzalloc): New function. Omit needless casts.
1579 * charset.c: Omit needless casts. Convert all calls to
1580 xmalloc with following memset to xzalloc.
1581 * dispnew.c: Likewise.
1582 * fringe.c: Likewise.
1583 * image.c: Likewise.
1584 * sound.c: Likewise.
1586 * w32fns.c: Likewise.
1587 * w32font.c: Likewise.
1588 * w32term.c: Likewise.
1589 * xfaces.c: Likewise.
1591 * xterm.c: Likewise.
1592 * atimer.c: Omit needless casts.
1593 * buffer.c: Likewise.
1594 * callproc.c: Likewise.
1596 * coding.c: Likewise.
1597 * composite.c: Likewise.
1599 * doprnt.c: Likewise.
1600 * editfns.c: Likewise.
1601 * emacs.c: Likewise.
1603 * filelock.c: Likewise.
1605 * gtkutil.c: Likewise.
1606 * keyboard.c: Likewise.
1608 * lread.c: Likewise.
1609 * minibuf.c: Likewise.
1610 * msdos.c: Likewise.
1611 * print.c: Likewise.
1612 * process.c: Likewise.
1613 * region-cache.c: Likewise.
1614 * search.c: Likewise.
1615 * sysdep.c: Likewise.
1616 * termcap.c: Likewise.
1617 * terminal.c: Likewise.
1618 * tparam.c: Likewise.
1619 * w16select.c: Likewise.
1621 * w32reg.c: Likewise.
1622 * w32select.c: Likewise.
1623 * w32uniscribe.c: Likewise.
1624 * widget.c: Likewise.
1625 * xdisp.c: Likewise.
1626 * xmenu.c: Likewise.
1628 * xselect.c: Likewise.
1630 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1632 * fileio.c (time_error_value): Check the right error number.
1633 Problem reported by Troels Nielsen in
1634 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1636 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1638 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1639 This should be fixed in a better way; see Eli Zaretskii in
1640 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1641 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1643 * fileio.c (time_error_value): Rename from special_mtime.
1644 The old name's problems were noted by Eli Zaretskii in
1645 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1647 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1648 This variable's comment says Emacs needs at least one GDB-visible
1649 symbol of type enum pvec_type, to work around GDB problems.
1650 The symbol's value doesn't matter.
1652 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1653 that causes compilation to fail on pre-C99 compilers.
1655 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
1657 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1658 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1660 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1662 * buffer.c (init_buffer_once): Fix initialization of
1663 headers for buffer_defaults and buffer_local_symbols.
1664 Reported by Juanma Barranquero <lekktu@gmail.com>.
1666 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1668 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1669 * lisp.h (enum pvec_type): Use fewer bits.
1670 (PSEUDOVECTOR_SIZE_BITS): New constant.
1671 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1672 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1673 change in pvec_type.
1674 (PSEUDOVECTOR_TYPEP): New macro.
1675 (TYPED_PSEUDOVECTORP): Use it.
1676 * fns.c (internal_equal): Adapt code to extract pvectype.
1677 * emacs.c (gdb_pvec_type): Update type.
1678 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1679 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1680 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1681 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1682 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1683 abusing vector->header.next.nbytes.
1684 (live_vector_p): Use PVEC_TYPE.
1685 (mark_object): Adapt code to extract pvectype. Use switch.
1687 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1689 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1690 Tighten new eassert a bit.
1692 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1694 Fix compilation with --enable-gcc-warnings and -O1
1696 * doprnt.c (doprnt): Change type of tem to int, initialize
1697 to avoid compiler warning. Add eassert.
1698 * search.c (simple_search): Initialize match_byte to avoid
1699 compiler warning. Add eassert.
1701 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1703 Avoid weird behavior with large horizontal scrolls.
1704 Without this change, for example, large hscroll values would
1705 mess up Emacs's display on Fedora 15 x86, presumably due to
1706 overflows in int calculations in the display code.
1707 Also, if buffers had long lines, Emacs would freeze.
1708 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1709 (set_window_hscroll): New function, containing the old guts of
1710 Fset_window_hscroll. Return the clipped value.
1711 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1712 This avoids the need to check against PTRDIFF_MAX.
1714 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1716 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1718 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1720 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1722 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1723 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1724 since GCC 4.4.6 issues a bogus warning for them.
1726 Fix bugs in file timestamp newness comparisons.
1727 * fileio.c (Ffile_newer_than_file_p):
1728 * lread.c (Fload): Use full timestamp resolution of files,
1729 not just the 1-second resolution, so that files that are only
1730 slightly newer still count as newer.
1731 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1732 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1734 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1736 * fileio.c: Improve handling of file time marker. (Bug#11852)
1737 (special_mtime): New function.
1738 (Finsert_file_contents, Fverify_visited_file_modtime):
1739 Use it to set special mtime values consistently.
1741 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1743 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1744 marker for non-existing file. (Bug#11852)
1746 2012-07-03 Glenn Morris <rgm@gnu.org>
1748 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1749 and did not make it into globals.h).
1751 2012-07-03 Tom Tromey <tromey@redhat.com>
1753 * window.c (Fset_window_margins, Fset_window_fringes)
1754 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1755 * textprop.c (Fprevious_property_change): No longer static.
1756 * syntax.c (Fsyntax_table_p): No longer static.
1757 * process.c (Fget_process, Fprocess_datagram_address): No longer
1759 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1760 * keyboard.c (Fcommand_execute): No longer static.
1762 * insdel.c (Fcombine_after_change_execute): No longer static.
1763 * image.c (Finit_image_library): No longer static.
1764 * fileio.c (Fmake_symbolic_link): No longer static.
1765 * eval.c (Ffetch_bytecode): No longer static.
1766 * editfns.c (Fuser_full_name): No longer static.
1767 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1769 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1771 * dired.c (Ffile_attributes): No longer static.
1772 * composite.c (Fcomposition_get_gstring): No longer static.
1773 * callproc.c (Fgetenv_internal): No longer static.
1775 * ccl.h: Remove EXFUNs.
1776 * buffer.h: Remove EXFUNs.
1777 * dispextern.h: Remove EXFUNs.
1778 * intervals.h: Remove EXFUNs.
1779 * fontset.h: Remove EXFUN.
1780 * font.h: Remove EXFUNs.
1781 * dosfns.c (system_process_attributes): Remove EXFUN.
1782 * keymap.h: Remove EXFUNs.
1783 * lisp.h: Remove EXFUNs.
1784 * w32term.h: Remove EXFUNs.
1785 * window.h: Remove EXFUNs.
1786 * xsettings.h: Remove EXFUN.
1787 * xterm.h: Remove EXFUN.
1789 2012-07-03 Glenn Morris <rgm@gnu.org>
1791 * lisp.h (Frandom): Make it visible to C.
1792 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1793 buffer for invisible buffers. (Bug#1229)
1795 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1797 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1798 values which aren't power of 2.
1799 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1800 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1803 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1805 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1807 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1809 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1811 * alloc.c (allocate_vector_block): Remove redundant
1812 calls to mallopt if DOUG_LEA_MALLOC is defined.
1813 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1814 avoid calls to mallopt if zero_vector is returned.
1816 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1818 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1819 is enabled, avoid dereferencing NULL current_sblock if
1822 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1824 Cleanup basic buffer management.
1825 * buffer.h (struct buffer): Change layout to use generic vector
1826 marking code. Fix some comments. Change type of 'clip_changed'
1827 to bitfield. Remove unused #ifndef old.
1828 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1829 (GET_OVERLAYS_AT): Fix indentation.
1830 (for_each_per_buffer_object_at): New macro.
1831 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1832 (Fbuffer_local_variables): Use it.
1833 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1834 * alloc.c (allocate_buffer): Adjust to match new layout of
1835 struct buffer. Fix comment.
1836 (mark_overlay): New function.
1837 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1838 Lisp area of struct buffer.
1839 (mark_object): Use it. Adjust marking of misc objects
1840 and related comments.
1842 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1844 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1845 wrapper that is not needed because the wrapped code is a no-op (zero
1846 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1847 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1849 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1851 * alloc.c (mark_buffer): Simplify. Remove prototype.
1852 (mark_object): Add comment. Reorganize marking of vector-like
1853 objects. Use CHECK_LIVE for all vector-like objects except buffers
1854 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1855 redundant calls to mark_vectorlike for bool vectors.
1857 2012-06-30 Glenn Morris <rgm@gnu.org>
1859 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1861 * epaths.in (PATH_SITELOADSEARCH): New.
1862 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1863 This is rather than relying on --enable-locallisppath elements
1864 having "site-lisp" in their names. (Bug#10208#25, 11658)
1866 2012-06-30 Eli Zaretskii <eliz@gnu.org>
1868 * w32proc.c (sys_select): Accept and ignore one more argument.
1870 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1872 * sysselect.h [DOS_NT]: Don't include sys/select.h.
1873 (pselect) [!MS_DOS]: Redirect to sys_select.
1875 * sysdep.c: Don't include dos.h and dosfns.h.
1877 * process.c (sys_select):
1878 * msdos.c (sys_select): Accept one more argument and ignore it.
1880 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1881 adapt data types and code to that.
1884 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1885 which clashes with the gnulib function of the same name.
1887 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1889 * font.c (font_style_to_value, font_style_symbolic)
1890 (font_prop_validate_style): Add type checks for values in
1893 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1895 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1898 2012-06-29 Eli Zaretskii <eliz@gnu.org>
1900 * xdisp.c (try_window_id): Undo last change.
1902 * w32.c (getwd): Adjust commentary about startup_dir.
1903 (init_environment): Always call sys_access, even in non-MSVC
1904 builds. Don't chdir to the directory of the Emacs executable.
1905 This undoes code from 1997 which was justified by the need to
1906 "avoid conflicts when removing and renaming directories". But its
1907 downside was that every relative file name was being interpreted
1908 relative to the directory of the Emacs executable, which can never
1909 be TRT. In particular, it broke sys_access when called with
1910 relative file names.
1911 (sys_access): Map GetLastError to errno.
1913 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1915 * window.h (struct window): Change type of 'fringes_outside_margins'
1916 to bitfield. Fix comment. Adjust users accordingly.
1917 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
1919 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1922 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
1924 * gnutls.c (emacs_gnutls_handshake):
1925 Add QUIT to make the loop interruptible.
1927 2012-06-29 Glenn Morris <rgm@gnu.org>
1929 * charset.c (init_charset): Make lack of etc/charsets fatal.
1931 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1933 * editfns.c (region_limit): Fix type mismatch.
1935 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1937 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1938 undefined. Convert from xassert to eassert.
1939 * nsmenu.m: Convert from xassert to eassert.
1940 * nsterm.m: Likewise.
1942 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1944 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1946 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1948 Avoid integer overflow on scroll-left and scroll-right.
1949 * window.c (HSCROLL_MAX): New macro.
1950 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1951 overflow when requested scroll falls outside ptrdiff_t range.
1953 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1955 * window.h (struct window): Change type of 'hscroll',
1956 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1957 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1958 Adjust users accordingly.
1959 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1960 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1961 from EMACS_INT to ptrdiff_t.
1962 (make_window): Omit redundant initialization.
1964 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
1966 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1968 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1970 * window.h (struct window): Change type of 'use_time' and
1971 'sequence_number' from Lisp_Object to int.
1972 * frame.c (make_frame): Adjust users accordingly.
1973 * print.c (print_object): Likewise.
1974 * window.c (select_window, Fwindow_use_time, make_parent_window)
1975 (make_window): Likewise.
1977 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1979 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1980 enabled with --enable-checking=[all,glyphs] configure option.
1981 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1982 adjust comments accordingly.
1983 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1984 undefined, adjust comments accordingly.
1985 * image.c: Likewise.
1986 * scroll.c: Likewise.
1987 * w32fns.c: Likewise.
1988 * w32term.c: Likewise.
1989 * xdisp.c: Likewise.
1990 * xfaces.c: Likewise.
1992 * xterm.c: Likewise.
1994 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1996 Generalize run-time debugging checks.
1997 * dispextern.h (XASSERTS): Remove.
1998 * fontset.c (xassert): Remove.
1999 Convert from xassert to eassert.
2000 * alloc.c: Convert from xassert to eassert.
2002 * dispnew.c: Likewise.
2004 * fringe.c: Likewise.
2005 * ftfont.c: Likewise.
2006 * gtkutil.c: Likewise.
2007 * image.c: Likewise.
2008 * keyboard.c: Likewise.
2010 * process.c: Likewise.
2011 * scroll.c: Likewise.
2012 * sound.c: Likewise.
2014 * w32console.c: Likewise.
2015 * w32fns.c: Likewise.
2016 * w32term.c: Likewise.
2017 * window.c: Likewise.
2018 * xdisp.c: Likewise.
2019 * xfaces.c: Likewise.
2021 * xselect.c: Likewise.
2022 * xterm.c: Likewise.
2024 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2026 * fns.c (maybe_resize_hash_table): Output message when growing the
2029 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2031 * alloc.c (allocate_string_data): Remove dead code.
2032 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2033 avoid GCC warning about unused macro.
2035 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2037 * alloc.c (allocate_string): Omit intervals initialization.
2038 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2039 as in make_pure_string and make_pure_c_string.
2041 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2043 * alloc.c (allocate_string): Fix last change.
2045 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2047 * alloc.c (allocate_string): Remove two redundant calls
2048 to memset, add explicit initialization where appropriate.
2050 2012-06-27 Glenn Morris <rgm@gnu.org>
2052 * lisp.mk (lisp): Remove paths.elc.
2054 2012-06-27 Chong Yidong <cyd@gnu.org>
2056 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2058 2012-06-26 John Wiegley <johnw@newartisans.com>
2060 * unexmacosx.c (copy_data_segment): Add two section names used
2061 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2063 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2064 when building with Clang.
2066 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2068 * eval.c (Fapply): Allow calling it with a single argument.
2070 2012-06-26 Eli Zaretskii <eliz@gnu.org>
2072 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2073 _stricmp and _strnicmp.
2074 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2076 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2078 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2080 (allocate_process): Likewise for new process.
2081 (allocate_terminal): Change to use offsetof.
2082 (allocate_frame): Likewise.
2083 * frame.c (make_frame): Omit redundant initialization.
2084 * window.c (make_parent_window): Use memset.
2085 (make_window): Omit redundant initialization.
2086 * process.c (make_process): Omit redundant initialization.
2087 * terminal.c (create_terminal): Likewise.
2089 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2091 * term.c (delete_tty): Remove redundant call to memset.
2093 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2095 * alloc.c: Remove build_string.
2096 * lisp.h: Define build_string as static inline. This provides
2097 a better opportunity to optimize away calls to strlen when the
2098 function is called with compile-time constant argument.
2099 * image.c (imagemagick_error): Convert to build_string.
2100 * w32proc.c (sys_spawnve): Likewise.
2101 * xterm.c (x_term_init): Likewise.
2103 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2105 Use sprintf return value instead of invoking strlen on result.
2106 In the old days this wasn't portable, since some sprintf
2107 implementations returned char *. But they died out years ago and
2108 Emacs already assumes sprintf returns int.
2109 Similarly for float_to_string.
2110 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2111 * ccl.c (ccl_driver):
2112 * character.c (string_escape_byte8):
2113 * data.c (Fnumber_to_string):
2114 * doprnt.c (doprnt):
2115 * print.c (print_object):
2116 * xdisp.c (message_dolog):
2117 * xfns.c (syms_of_xfns):
2118 Use sprintf or float_to_string result to avoid need to call strlen.
2119 * data.c (Fnumber_to_string):
2120 Use make_unibyte_string, since the string must be ASCII.
2121 * lisp.h, print.c (float_to_string): Now returns int length.
2122 * term.c (produce_glyphless_glyph):
2123 Use sprintf result rather than recomputing it.
2125 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2126 * Makefile.in (ALL_CFLAGS):
2127 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2128 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2130 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2132 * dispextern.h (xstrcasecmp): Define to library function
2133 strcasecmp if available.
2134 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2136 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2138 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2139 Avoid comma operator.
2140 * menu.c (push_submenu_start, push_submenu_end)
2141 (push_left_right_boundary, push_menu_pane): Likewise.
2142 * msdos.c (dos_rawgetc): Likewise.
2144 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2146 * xfns.c (xic_create_fontsetname): Remove redundant calls
2149 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2151 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2152 sprintf already null-terminates its output.
2154 * xfns.c (x_window): Remove redundant cast.
2156 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2158 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2159 `const char *' to `char *' to avoid compiler warning.
2161 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2163 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2164 instead of truncating it to 63 (admittedly a generous limit).
2166 * process.c: Fix spelling and caps in comments.
2168 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2170 * emacs.c (setpgrp): Remove definition, unused.
2171 * sysdep.c (setpgrp): Remove definition, not used in this file.
2173 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
2175 * makefile.w32-in: Update dependencies.
2177 2012-06-24 Eli Zaretskii <eliz@gnu.org>
2179 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2180 (SYSTIME_H): Add nt/inc/sys/time.h.
2182 * systime.h [WINDOWSNT]: Include sys/time.h.
2184 * s/ms-w32.h (struct timespec): Definition moved from
2185 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2187 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2189 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2190 * buffer.h (buffer_slot_type_mismatch):
2191 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2192 * eval.c (unwind_to_catch):
2193 * image.c (my_png_error, my_error_exit):
2194 * keyboard.c (quit_throw_to_read_char, user_error)
2195 (Fexit_recursive_edit, Fabort_recursive_edit):
2196 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2197 (wrong_type_argument, buffer_overflow, __executable_start)
2198 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2199 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2200 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2202 (child_setup) [!DOS_NT]:
2203 * lread.c (end_of_file_error, invalid_syntax):
2204 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2205 * puresize.h (pure_write_error):
2206 * search.c (matcher_overflow):
2207 * sound.c (sound_perror, alsa_sound_perror):
2208 * sysdep.c, syssignal.h (croak):
2209 * term.c (maybe_fatal, vfatal):
2210 * textprop.c (text_read_only):
2211 * undo.c (user_error):
2212 * unexmacosx.c (unexec_error):
2213 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2214 Use _Noreturn rather than NO_RETURN.
2215 No need for separate decl merely because of _Noreturn.
2216 * sound.c (sound_warning, parse_sound):
2217 Remove unnecessary forward decls.
2219 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2221 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2222 * lisp.h (WAIT_READING_MAX): New macro.
2223 * dispnew.c (Fsleep_for, sit_for):
2224 * keyboard.c (kbd_buffer_get_event):
2225 * process.c (Faccept_process_output):
2226 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2227 This improves on the previous patch, which introduced a bug
2228 when time_t is unsigned and as wide as intmax_t.
2229 See <http://bugs.gnu.org/9000#51>.
2231 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2233 * dispnew.c (sit_for, Fsleep_for):
2234 * keyboard.c (kbd_buffer_get_event):
2235 * process.c (Faccept_process_output): Avoid compiler warnings when
2236 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2238 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
2240 * makefile.w32-in: Update dependencies.
2242 * w32.c (ltime): Add return type and declare static.
2243 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2245 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2247 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2248 Privately reported by Herbert J. Skuhra.
2249 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2251 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2252 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2254 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2256 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2257 last argument of make_unibyte_string.
2259 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2260 language ID in the event parameters.
2262 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2263 event.code, not the obscure "character set ID".
2265 2012-06-23 Chong Yidong <cyd@gnu.org>
2267 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2269 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2271 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2272 * w32.c (fdutimens): New function.
2274 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2276 * s/ms-w32.h (pselect): Redirect to sys_select.
2278 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2280 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2281 in the logic of incrementing and decrementing the value of
2282 use_relocatable_buffers.
2284 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2286 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2287 Privately reported by Herbert J. Skuhra.
2288 [__FreeBSD__]: Remove "*/" typo after "#include".
2289 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2290 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2291 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2292 Don't assume EMACS_TIME and struct timeval are the same type.
2294 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2296 Support higher-resolution time stamps (Bug#9000).
2297 The time stamps are only nanosecond-resolution at the C level,
2298 since that's the best that any real-world system supports now.
2299 But they are picosecond-resolution at the Lisp level, as that's
2300 easy, and leaves room for future OS improvements.
2302 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2305 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2306 Don't get current time unless it's needed.
2308 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2309 now provides it if it's absent.
2310 (start_atimer): Port to higher-res time stamps.
2311 Check for time stamp overflow. Don't get current time more
2312 often than is needed.
2314 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2315 Include systime.h, not time.h.
2316 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2318 * dired.c: Include stat-time.h.
2319 (Ffile-attributes): File times now have higher resolution.
2321 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2322 (struct image): Timestamp now has higher resolution.
2324 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2325 has at least microseconds now. All uses removed.
2326 (update_frame, update_single_window, update_window, update_frame_1)
2327 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2329 * editfns.c (time_overflow): Now extern.
2330 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2331 (float-time, Fformat_time_string, Fcurrent_time_string)
2332 (Fcurrent_time_zone): Accept and generate higher-resolution
2334 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2335 (decode_time_components, lisp_seconds_argument): New functions.
2336 (make_time): Now static.
2337 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2338 Report an error if the time is invalid, rather than having the caller
2341 * fileio.c: Include <stat-time.h>
2342 (Fcopy_file): Copy higher-resolution time stamps.
2343 Prefer to set the time stamp via a file descriptor if that works.
2344 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2345 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2346 (Fvisited_file_modtime, Fset_visited_file_modtime):
2347 Support higher-resolution time stamps.
2349 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2351 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2353 * image.c (prepare_image_for_display, clear_image_cache)
2354 (lookup_image): Port to higer-resolution time stamps.
2356 * keyboard.c (start_polling, bind_polling_period):
2357 Check for time stamp overflow.
2358 (read_char, kbd_buffer_get_event, timer_start_idle)
2359 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2360 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2361 Port to higher-resolution time stamps. Do not assume time_t is signed.
2362 (decode_timer): New function. Timers are now vectors of length 9,
2363 not 8, to accommodate the picosecond component.
2364 (timer_check_2): Use it.
2366 * nsterm.m (select_timeout, timeval_subtract): Remove.
2367 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2368 as they're a bit more accurate and handle overflow better.
2369 (ns_select): Change prototype to be compatible with pselect.
2370 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2371 * nsterm.h (ns_select): Adjust prototype.
2373 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2374 us-resolution time stamps.
2375 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2377 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2379 * lisp.h (time_overflow): New decl.
2380 (wait_reading_process_output): First arg is now intmax_t, not int,
2381 to accommodate larger waits.
2383 * process.h (struct Lisp_Process.read_output_delay):
2384 Now counts nanoseconds, not microseconds.
2385 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2387 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2388 (wait_reading_process_output):
2389 Port to ns-resolution time stamps.
2390 (Faccept_process_output, wait_reading_process_output):
2391 Check for time stamp overflow. Do not assume time_t is signed.
2392 (select_wrapper): Remove; we now use pselect.
2393 (Fprocess_attributes): Now generates ns-resolution time stamps.
2395 * sysdep.c: Include utimens.h. Don't include utime.h
2396 or worry about struct utimbuf; gnulib does that for us now.
2397 (gettimeofday): Remove; gnulib provides a substitute.
2398 (make_timeval): New function.
2399 (set_file_times): Now sets ns-resolution time stamps.
2400 New arg FD; all uses changed.
2401 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2402 (system_process_attributes):
2403 Now returns ns-resolution time stamp. All uses changed.
2404 Check for time stamp overflow.
2406 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2407 provides a substitute now.
2409 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2410 since it guarantees struct timespec.
2411 (EMACS_TIME): Now struct timespec, so that we can support
2412 ns-resolution time stamps.
2413 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2414 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2415 (EMACS_USECS): Remove.
2416 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2417 so multiply the arg by 1000 before storing it.
2418 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2420 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2421 Port to ns-resolution time stamps.
2422 (EMACS_TIME_NEG_P): Remove; replaced by....
2423 (EMACS_TIME_SIGN): New macro.
2424 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2425 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2426 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2427 (make_timeval, make_lisp_time, decode_time_components): New decls.
2428 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2429 that it mishandled time_t overflow. You can't compare by subtracting!
2430 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2431 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2433 * term.c: Include <sys/time.h>.
2434 (timeval_to_Time): New function, for proper overflow wraparound.
2435 (term_mouse_position, term_mouse_click): Use it.
2437 * undo.c (record_first_change): Support higher-resolution time stamps
2439 (Fprimitive_undo): Use them when restoring time stamps.
2441 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2442 (w32_get_internal_run_time):
2443 Port to higher-resolution Emacs time stamps.
2444 (ltime): Now accepts single 64-bit integer, as that's more convenient
2447 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2449 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2450 for compatibility with pselect. Support ns-resolution time stamps.
2452 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2454 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2455 Check for time stamp overflow, and support ns-resolution time stamps.
2457 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2458 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2459 (timeval_subtract): Remove; no longer needed.
2460 (XTflash, XTring_bell, x_wait_for_event):
2461 Port to ns-resolution time stamps. Don't assume time_t is signed.
2463 2012-06-22 Chong Yidong <cyd@gnu.org>
2465 * xdisp.c (x_consider_frame_title): Revert last change.
2467 2012-06-22 Eli Zaretskii <eliz@gnu.org>
2469 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2470 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2471 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2472 staticidx goes up to 1597 out of 1600 = 0x640.)
2474 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2476 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2477 Otherwise, the umask might be mistakenly 0 while handling input signals.
2479 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2481 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2483 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2485 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2486 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2487 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2488 access to `contents' member of Lisp_Vector objects with AREF and ASET
2491 2012-06-19 Chong Yidong <cyd@gnu.org>
2493 * frame.c (delete_frame): When selecting a frame on a different
2494 text terminal, do not alter the terminal's top-frame.
2496 * xdisp.c (format_mode_line_unwind_data): Record the target
2497 frame's selected window and its terminal's top-frame.
2498 (unwind_format_mode_line): Restore them.
2499 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2501 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2502 since tty frames can be explicitly named.
2503 (prepare_menu_bars): Likewise.
2505 * term.c (Ftty_top_frame): New function.
2507 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2509 Port byte-code-meter to modern targets.
2510 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2511 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
2512 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
2513 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2514 (METER_1, METER_2): Simplify.
2516 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2518 * data.c (Fdefalias): Return `symbol' (bug#11686).
2520 2012-06-18 Martin Rudalics <rudalics@gmx.at>
2522 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
2523 gets killed during executing of this function (Bug#11665).
2524 Try to always return Qt when the buffer has been actually killed.
2525 (Vkill_buffer_query_functions): In doc-string say that functions
2526 run by this hook should not change the current buffer.
2528 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2530 Fix recently-introduced process.c problems found by static checking.
2531 * process.c (write_queue_push, write_queue_pop, send_process):
2532 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2533 (write_queue_pop): Fix pointer signedness problem.
2534 (send_process): Remove unused local.
2536 2012-06-17 Chong Yidong <cyd@gnu.org>
2538 * xdisp.c (redisplay_internal): No need to redisplay terminal
2539 frames that are not on top.
2541 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
2543 * process.c (make_process): Initialize write_queue.
2544 (write_queue_push, write_queue_pop): New functions.
2545 (send_process): Use them to maintain correct ordering of process
2548 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2550 * lisp.h (eassert): Assume C89 or later.
2551 This removes the need for CHECK.
2552 (CHECK): Remove. Its comments about always evaluating its
2553 argument were confusing, as 'eassert' typically does not evaluate
2556 * coding.c (produce_chars): Use ptrdiff_t, not int.
2558 * xterm.c (x_draw_underwave): Check for integer overflow.
2559 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2561 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
2563 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2564 referenced (Bug#11583).
2566 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2568 Implement wave-style variant of underlining.
2569 * dispextern.h (face_underline_type): New enum.
2570 (face): Add field for underline type.
2571 * nsterm.m (ns_draw_underwave): New function.
2572 (ns_draw_text_decoration): Use it.
2573 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2575 (x_draw_glyph_string): Use them.
2576 * xfaces.c (Qline, Qwave): New Lisp objects.
2577 (check_lface_attrs, merge_face_ref)
2578 (Finternal_set_lisp_face_attribute, realize_x_face):
2579 Handle wave-style underline face attributes.
2580 * xterm.c (x_draw_underwave): New function.
2581 (x_draw_glyph_string): Use it.
2583 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
2585 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2586 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2587 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2588 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2589 ($(BLD)/w32select.$(O)): Update dependencies.
2591 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2593 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2594 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2595 * character.c (_fetch_multibyte_char_p): Remove.
2596 * alloc.c: Include "character.h" before "buffer.h".
2598 * buffer.c: Likewise.
2599 * bytecode.c: Likewise.
2600 * callint.c: Likewise.
2601 * callproc.c: Likewise.
2602 * casefiddle.c: Likewise.
2603 * casetab.c: Likewise.
2604 * category.c: Likewise.
2606 * coding.c: Likewise.
2607 * composite.c: Likewise.
2608 * dired.c: Likewise.
2609 * dispnew.c: Likewise.
2611 * dosfns.c: Likewise.
2612 * editfns.c: Likewise.
2613 * emacs.c: Likewise.
2614 * fileio.c: Likewise.
2615 * filelock.c: Likewise.
2617 * fontset.c: Likewise.
2618 * fringe.c: Likewise.
2619 * indent.c: Likewise.
2620 * insdel.c: Likewise.
2621 * intervals.c: Likewise.
2622 * keyboard.c: Likewise.
2623 * keymap.c: Likewise.
2624 * lread.c: Likewise.
2625 * macros.c: Likewise.
2626 * marker.c: Likewise.
2627 * minibuf.c: Likewise.
2628 * nsfns.m: Likewise.
2629 * nsmenu.m: Likewise.
2630 * print.c: Likewise.
2631 * process.c: Likewise.
2632 * regex.c: Likewise.
2633 * region-cache.c: Likewise.
2634 * search.c: Likewise.
2635 * syntax.c: Likewise.
2637 * textprop.c: Likewise.
2639 * unexsol.c: Likewise.
2640 * w16select.c: Likewise.
2641 * w32fns.c: Likewise.
2642 * w32menu.c: Likewise.
2643 * window.c: Likewise.
2644 * xdisp.c: Likewise.
2646 * xmenu.c: Likewise.
2648 * xselect.c: Likewise.
2650 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2652 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2653 If all the glyphs of the glyph row came from strings, and we have no
2654 cursor positioning clues, put the cursor on the first glyph of the
2656 (handle_face_prop): Use chunk-relative overlay string index when
2657 indexing into it->string_overlays array. (Bug#11653)
2658 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2659 the rightmost. (Bug#11720)
2661 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2663 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2664 (CATEGORY_MEMBER): Enforce 1/0 value.
2665 * category.c (_temp_category_set): Remove.
2667 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2669 * window.c (Fdelete_other_windows_internal)
2670 (Fdelete_window_internal): Don't access frame's mouse highlight
2671 info of the initial frame. (Bug#11677)
2673 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2675 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2676 Assume USE_2_TAGS_FOR_INTS.
2677 (xreload): Adjust $tagmask width to match recent lisp.h change.
2679 Simplify lisp.h in minor ways that should not affect code.
2680 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2681 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2682 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2683 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2684 (INTTYPEBITS): New macro, for clarity.
2685 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
2686 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2687 Simplify now that USE_LSB_TAG is always defined.
2688 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2689 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2691 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
2693 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2695 2012-06-13 Glenn Morris <rgm@gnu.org>
2697 * s/bsd-common.h (BSD4_3):
2698 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2700 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2702 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2705 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2707 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
2708 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
2709 * alloc.c (widen_to_Lisp_Object): Remove.
2710 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2711 * frame.c (delete_frame): Remove outdated comment.
2712 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2713 USE_LISP_UNION_TYPE.
2714 (Fw32_unregister_hot_key): Likewise.
2715 (Fw32_toggle_lock_key): Likewise.
2716 * w32menu.c (add_menu_item): Likewise.
2717 (w32_menu_display_help): Use XIL instead of checking
2718 USE_LISP_UNION_TYPE.
2719 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2720 (init_heap): Likewise.
2721 * w32term.c (w32_read_socket): Update comment.
2723 2012-06-13 Glenn Morris <rgm@gnu.org>
2725 * s/usg5-4-common.h, src/s/unixware.h:
2726 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2728 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2730 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2732 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2733 * alloc.c (make_number) [!defined make_number]:
2734 Remove, as lisp.h always defines this now.
2735 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2736 (roundup_size): Verify that it is a power of 2.
2737 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2738 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2739 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2740 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2741 USE_LSB_TAG now is always defined to be either 0 or 1.
2743 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2744 code works fine either way, and efficiency is not a concern here,
2745 as the union type is for debugging, not for production.
2746 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2747 Use an inline function on all platforms when using the union type,
2748 since this is simpler and 'static inline' can be used portably
2750 (LISP_INITIALLY_ZERO): New macro.
2751 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2752 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2754 2012-06-12 Glenn Morris <rgm@gnu.org>
2756 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2758 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
2760 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2761 Move BROKEN_SIGIO to configure.
2763 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2764 Move NO_TERMIO to configure.
2766 2012-06-12 Chong Yidong <cyd@gnu.org>
2768 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2769 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2770 MagickExportImagePixels is undefined.
2772 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2774 * image.c (imagemagick_load_image): Remove unused label.
2776 2012-06-11 Glenn Morris <rgm@gnu.org>
2778 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2779 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2780 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2781 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2783 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2785 * alloc.c (make_byte_code): New function.
2786 (Fmake_byte_code): Use it. Don't purify here.
2787 * lread.c (read1): Use it as well to avoid extra allocation.
2789 2012-06-11 Chong Yidong <cyd@gnu.org>
2791 * image.c (imagemagick_load_image): Implement transparency.
2793 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2795 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2796 account for preceding backslashes. (Bug#11663)
2798 2012-06-09 Chong Yidong <cyd@gnu.org>
2800 * term.c: Support italics in capable terminals (Bug#9652).
2801 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2802 (turn_on_face): Output using TS_enter_italic_mode if available.
2803 Don't handle unused blinking and alt-charset cases.
2804 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2805 and tty_alt_charset_p cases.
2806 (tty_capable_p, init_tty): Support italics.
2808 * termchar.h (struct tty_display_info): Add field for italics.
2809 Remove unused blink field.
2811 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2814 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2815 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2816 tty_alt_charset_p. Add tty_italic_p.
2818 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
2820 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2821 dbus_type_is_basic if available.
2822 (xd_extract_signed, xd_extract_unsigned): Rename from
2823 extract_signed and extract_unsigned, respectively. Adapt callers.
2825 2012-06-09 Chong Yidong <cyd@gnu.org>
2827 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2829 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2832 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2834 * xdisp.c (vmessage): Treat frame message as multibyte.
2835 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2836 would generate the diagnostic "Making \302\247 buffer-local while
2839 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2841 * dispnew.c (showing_window_margins_p): Undo last change, which
2842 was done due to an inadvertent commit.
2843 (adjust_frame_glyphs_for_frame_redisplay): Do call
2844 showing_window_margins_p.
2846 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2848 * eval.c (Fmake_var_non_special): New primitive.
2849 (syms_of_eval): Defsubr it.
2850 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2852 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
2854 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2855 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2857 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2859 * alloc.c (allocate_vectorlike): Fix last change.
2861 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2863 Block-based vector allocation of small vectors.
2864 * lisp.h (struct vectorlike_header): New field `nbytes',
2865 adjust comment accordingly.
2866 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2867 to denote vector blocks. Adjust users (live_vector_p,
2868 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2869 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2870 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2871 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2872 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2873 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2874 (roundup_size): New constant.
2875 (struct vector_block): New data type.
2876 (vector_blocks, vector_free_lists, zero_vector): New variables.
2877 (all_vectors): Rename to `large_vectors'.
2878 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2879 (sweep_vectors): New functions.
2880 (allocate_vectorlike): Return `zero_vector' as the only vector of
2881 0 items. Allocate new vector from block if vector size is less than
2882 or equal to VBLOCK_BYTES_MAX.
2883 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2884 (init_alloc_once): Add call to init_vectors.
2886 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2888 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2890 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2892 * doprnt.c (doprnt): Truncate multibyte char correctly.
2893 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2894 would mishandle a string argument "Xc" if X was a multibyte
2895 character of length 2: it would truncate after X's first byte
2896 rather than including all of X.
2898 2012-06-06 Chong Yidong <cyd@gnu.org>
2900 * buffer.c (word_wrap): Doc fix.
2902 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2904 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2906 2012-06-03 Glenn Morris <rgm@gnu.org>
2908 * xdisp.c (tool-bar-style): Doc fix.
2910 2012-06-03 Ulrich Müller <ulm@gentoo.org>
2912 * Makefile.in (PAXCTL): Define.
2913 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2914 binary via PaX flags if the paxctl utility is available.
2915 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2916 Restore PaX flags to their default. (Bug#11398)
2918 2012-06-03 Chong Yidong <cyd@gnu.org>
2920 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2923 2012-06-03 Chong Yidong <cyd@gnu.org>
2925 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2926 (note_mode_line_or_margin_highlight): If there is no help echo,
2927 use mode-line-default-help-echo. Handle the case where the mouse
2928 position is past the end of the mode line string.
2930 * buffer.c (buffer_local_value_1): New function, split from
2931 Fbuffer_local_value; can return Qunbound.
2932 (Fbuffer_local_value): Use it.
2933 (Vmode_line_format): Docstring tweaks.
2935 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2937 * sysdep.c (system_process_attributes): Improve comment.
2939 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2941 * keyboard.c: Export real-this-command to Elisp.
2942 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2943 and DEFVAR it. Update all users.
2945 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2947 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2949 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2950 Convert pctcpu and pctmem to Lisp float properly.
2951 Let the compiler fold better, as 100.0/0x8000 is exact.
2953 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2955 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2958 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2960 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2962 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2964 For a 'struct window', replace some Lisp_Object fields to
2965 bitfields where appropriate, remove unused fields.
2966 * window.h (struct window): Remove unused 'last_mark_x' and
2967 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2968 change it's type from Lisp_Object to bitfield.
2969 Change type of 'force_start', 'optional_new_start',
2970 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2971 fields from Lisp_Object to bitfield. Adjust users accordingly.
2973 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2975 Pacify gcc -Wdouble-precision when using Xaw.
2976 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2977 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2978 Use 'float' consistently, rather than 'float' in most places
2979 and 'double' in a couple of places.
2981 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2983 * xdisp.c (handle_stop): Detect whether we have overlay strings
2984 loaded by testing it->current.overlay_string_index to be
2985 non-negative, instead of checking whether n_overlay_strings is
2986 positive. (Bug#11587)
2988 2012-05-31 Chong Yidong <cyd@gnu.org>
2990 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2992 * doc.c (Fsubstitute_command_keys): Doc fix.
2994 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2996 * search.c (search_buffer): Remove calls to
2997 r_alloc_inhibit_buffer_relocation, as it is now called by
2998 maybe_unify_char, which was the cause of relocation of buffer text
3001 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3003 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3004 for the duration of call to load_charset, to avoid problems with
3005 callers of maybe_unify_char that access buffer text through C
3008 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3009 decrement the inhibition flag, instead of just setting or
3012 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3014 Remove obsolete '#define static' cruft.
3015 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3016 This #undef was "temporary" in 2000; it is no longer needed
3017 now that '#define static' has gone away.
3018 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3019 (gray_bitmap_bits): Remove; no longer needed.
3020 All uses replaced with definiens.
3021 * xterm.c: Include "bitmaps/gray.xbm".
3023 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3025 Clean up __executable_start, monstartup when --enable-profiling.
3026 The following changes affect the code only when profiling.
3027 * dispnew.c (__executable_start): Rename from safe_bcopy.
3028 Define only on platforms that need it.
3029 * emacs.c: Include <sys/gmon.h> when profiling.
3030 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3031 (__executable_start): Remove decl, since lisp.h does it now.
3032 (safe_bcopy): Remove decl; no longer has that name.
3033 (main): Coalesce #if into single bit of code, for simplicity.
3034 Cast pointers to uintptr_t, since standard libraries want integers
3036 * lisp.h (__executable_start): New decl.
3038 2012-05-31 Glenn Morris <rgm@gnu.org>
3040 * image.c (Fimagemagick_types): Doc fix.
3042 2012-05-30 Jim Meyering <meyering@redhat.com>
3044 * callproc.c (Fcall_process_region): Include directory component
3045 in mkstemp error message (Bug#11586).
3047 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3049 * alloc.c, lisp.h (make_pure_vector): Now static.
3051 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3053 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3054 Move to byte-run.el.
3055 (Fautoload): Do the hash-doc more carefully.
3056 * data.c (Fdefalias): Purify definition, except for keymaps.
3057 (Qdefun): Move from eval.c.
3058 * lisp.h (Qdefun): Remove.
3059 * lread.c (read1): Tiny simplification.
3061 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
3063 Do not create empty overlays with the evaporate property (Bug#9642).
3064 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3065 Bug#9642, but explicitly check that the buffer the overlay would
3066 be moved to is live and rearrange lines to make sure that errors
3067 will not put the overlay in an inconsistent state.
3068 (Fdelete_overlay): Cosmetics.
3070 2012-05-28 Eli Zaretskii <eliz@gnu.org>
3072 * w32term.c (my_bring_window_to_top): New function.
3073 (x_raise_frame): Use handle returned by DeferWindowPos, which
3074 could be different from the original one.
3075 Call my_bring_window_to_top instead of my_set_foreground_window.
3078 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3079 by calling BringWindowToTop.
3081 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3082 (WM_EMACS_END): Increase by one.
3084 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3086 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3087 This avoids undefined behavior that might cause the eassert
3088 to not catch an out-of-range value.
3090 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
3092 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3093 Update dependencies.
3095 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3097 * bidi.c (bidi_mirror_char): Fix last change.
3099 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3101 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3102 when referring to sectname field in printf format.
3104 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3106 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3107 Only r_alloc_inhibit_buffer_relocation needed to be added;
3108 the others were already declared.
3110 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3111 before checking whether it's out of range. Put the check inside
3113 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3115 2012-05-27 Ken Brown <kbrown@cornell.edu>
3117 * callproc.c (Fcall_process): Restore a line that was accidentally
3118 commented out in the 2011-02-13 change (bug#11547).
3120 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3122 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3123 defined on ralloc.c.
3125 * buffer.c [REL_ALLOC]: Remove prototypes of
3126 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3127 they are now on lisp.h.
3129 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3131 * search.c (search_buffer): Use it to inhibit relocation of buffer
3132 text while re_search_2 is doing its job, because re_search_2 is
3133 passed C pointers to buffer text. (Bug#11519)
3135 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3138 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3139 state after an additional call to move_it_in_display_line_to, keep
3140 the values of it->max_ascent and it->max_descent found for the
3142 (pos_visible_p): Revert the comparison against bottom_y to what it
3143 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3146 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3148 Fix coding-related core dumps with gcc -ftrapv.
3149 The code was computing A - B, where A and B are pointers, and B is
3150 random garbage. This can lead to core dumps on platforms that
3151 have special pointer registers, and it also leads to core dumps on
3152 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3153 A - B only when B is initialized properly.
3154 * coding.c (coding_set_source, coding_set_destination): Return void.
3155 (coding_change_source, coding_change_destinations): New functions,
3156 with the old behaviors of coding_set_source and coding_set_destination.
3157 All callers that need an offset changed to use these new functions.
3159 2012-05-26 Glenn Morris <rgm@gnu.org>
3161 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3163 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3165 Extend mouse support on W32 text-mode console.
3166 * xdisp.c (draw_row_with_mouse_face):
3167 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
3169 * w32console.c: Include window.h.
3170 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3172 (initialize_w32_display): Initialize mouse-highlight data.
3174 * w32inevt.c: Include termchar.h and window.h.
3175 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3176 moves, call note_mouse_highlight. If help_echo changed, call
3177 gen_help_event to produce help-echo message in the echo area.
3178 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3181 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3183 * lread.c (read1): Simplify slightly to avoid an overflow warning
3184 with GCC 4.7.0 on x86-64.
3186 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3188 * bidi.c (bidi_mirror_char): Revert last change: an int is
3189 definitely wide enough here.
3191 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3193 Fix integer width and related bugs (Bug#9874).
3194 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
3195 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3196 (string_bytes, check_sblock, allocate_string_data):
3197 (compact_small_strings, Fmake_bool_vector, make_string)
3198 (make_unibyte_string, make_multibyte_string)
3199 (make_string_from_bytes, make_specified_string)
3200 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3201 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3203 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3204 (allocate_pseudovector):
3205 Use int, not EMACS_INT, where int is wide enough.
3206 (inhibit_garbage_collection, Fgarbage_collect):
3207 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3208 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3209 int might not be wide enough.
3210 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3211 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3212 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3213 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3214 (bidi_level_of_next_char, bidi_move_to_visually_next):
3215 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3216 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3217 (Fkill_buffer, Fset_buffer_major_mode)
3218 (advance_to_char_boundary, Fbuffer_swap_text)
3219 (Fset_buffer_multibyte, overlays_at, overlays_in)
3220 (overlay_touches_p, struct sortvec, record_overlay_string)
3221 (overlay_strings, recenter_overlay_lists)
3222 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3223 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3224 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3225 (Foverlay_recenter, last_overlay_modification_hooks_used)
3226 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3227 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3228 (validate_region): Omit unnecessary test for b <= e,
3229 since that's guaranteed by the previous test.
3230 (adjust_overlays_for_delete): Avoid pos + length overflow.
3231 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3232 (report_overlay_modification):
3233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3234 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3235 Omit pointer cast, which isn't needed anyway, and doesn't work
3236 after the EMACS_INT -> ptrdiff_t change.
3237 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
3238 * buffer.h: Adjust decls to match defn changes elsewhere.
3239 (struct buffer_text, struct buffer):
3240 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3241 Use EMACS_INT, not int, where int might not be wide enough.
3242 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3243 not int, to avoid needless 32-bit limit on 64-bit hosts.
3244 (exec_byte_code): Use tighter memory-full test, one that checks
3245 for alloca overflow. Don't compute the address of the object just
3246 before an array, as that's not portable. Use EMACS_INT, not
3247 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
3248 * callint.c (Fcall_interactively):
3249 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3250 * callproc.c (call_process_kill, Fcall_process):
3251 Don't assume pid_t fits into an Emacs fixnum.
3252 (call_process_cleanup, Fcall_process, child_setup):
3253 Don't assume pid_t fits into int.
3254 (call_process_cleanup, Fcall_process, delete_temp_file)
3255 (Fcall_process_region):
3256 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3257 (Fcall_process): Simplify handling of volatile integers.
3258 Use int, not EMACS_INT, where int will do.
3259 * casefiddle.c (casify_object, casify_region, operate_on_word)
3260 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3261 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3262 (casify_object): Avoid integer overflow when overallocating buffer.
3263 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
3264 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
3265 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3266 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3267 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3268 integers are now checked earlier. All uses replaced with XINT.
3270 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3271 For CCL_MapSingle, check that content and value are in int range.
3272 (ccl_driver, Fregister_code_conversion_map):
3273 Check that Vcode_version_map_vector is a vector.
3274 (resolve_symbol_ccl_program): Check that vector header is in range.
3275 Always copy the vector, so that we can check its contents reliably
3276 now rather than having to recheck each instruction as it's being
3277 executed. Check that vector words fit in 'int'.
3278 (ccl_get_compiled_code, Fregister_ccl_program)
3279 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3280 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3281 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3282 contents are in range.
3283 (Fccl_execute_on_string): Check that status is in range.
3284 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3285 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3286 Accept and return EMACS_INT, not int, because callers can pass values
3288 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3289 (multibyte_chars_in_text, parse_str_as_multibyte)
3290 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3291 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3292 (string_escape_byte8, Fget_byte):
3293 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3294 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
3295 avoid mishandling large integers.
3296 * character.h: Adjust decls to match defn changes elsewhere.
3297 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3298 (Ffind_charset_region):
3299 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3300 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3301 (load_charset_map_from_vector, Fdefine_charset_internal):
3302 Don't assume fixnum fits in int.
3303 (load_charset_map_from_vector, Fmap_charset_chars):
3304 Remove now-unnecessary CHECK_NATNUMs.
3305 (Fdefine_charset_internal): Check ranges here, more carefully.
3306 Don't rely on undefined behavior with signed left shift overflow.
3307 Don't assume unsigned int fits into fixnum, or that fixnum fits
3308 into unsigned int. Don't require max_code to be a valid fixnum;
3309 that's not true for gb10830 4-byte on a 32-bit host. Allow
3310 invalid_code to be a cons, for the same reason. Require code_offset
3311 to be a character. Avoid int overflow if max_char is close
3313 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3314 this is intended anyway and avoids some undefined behavior.
3315 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3316 INDEX_TO_CODE_POINT, as that's what it expects.
3317 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
3318 * charset.h (DECODE_CHAR): Return int, not unsigned;
3319 this is what was intended anyway, and it avoids undefined behavior.
3320 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3321 integer-overflow issues.
3322 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3323 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3324 where the argument is EMACS_INT, and this behavior is not intended.
3325 * chartab.c (Fmake_char_table, Fset_char_table_range)
3326 (uniprop_get_decoder, uniprop_get_encoder):
3327 Don't assume fixnum fits in int.
3328 * cmds.c (move_point): New function, that does the gist of
3329 Fforward_char and Fbackward_char, but does so while checking
3330 for integer overflow more accurately.
3331 (Fforward_char, Fbackward_char): Use it.
3332 (Fforward_line, Fend_of_line, internal_self_insert)
3333 (internal_self_insert):
3334 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3335 Fix a FIXME, by checking for integer overflow when calculating
3336 target_clm and actual_clm.
3337 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
3338 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
3339 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3340 (coding_alloc_by_making_gap, alloc_destination)
3341 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3342 (encode_coding_utf_16, detect_coding_emacs_mule)
3343 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3344 (detect_coding_iso_2022, decode_coding_iso_2022)
3345 (encode_invocation_designation, encode_designation_at_bol)
3346 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3347 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3348 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3349 (encode_coding_ccl, encode_coding_raw_text)
3350 (detect_coding_charset, decode_coding_charset)
3351 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3352 (produce_composition, produce_charset, produce_annotation)
3353 (decode_coding, handle_composition_annotation)
3354 (handle_charset_annotation, consume_chars, decode_coding_gap)
3355 (decode_coding_object, encode_coding_object, detect_coding_system)
3356 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3357 (code_convert_region, code_convert_string)
3358 (Fdefine_coding_system_internal)
3359 (coding_set_source, coding_set_destination):
3360 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3361 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3362 (Fdefine_coding_system_internal):
3363 Don't assume fixnums fit in int.
3364 (decode_coding_gap, decode_coding_object, encode_coding_object)
3365 (Fread_coding_system, Fdetect_coding_region)
3366 (Funencodable_char_position, Fcheck_coding_systems_region)
3367 (get_translation, handle_composition_annotation, consume_chars):
3368 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3369 (consume_chars): Rewrite to not calculate an address outside buffer.
3370 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
3371 Don't access memory outside of the args array.
3372 (Fdefine_coding_system_internal): Check for charset-id overflow.
3373 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3374 result of ENCODE_CHAR.
3375 * coding.h: Adjust decls to match defn changes elsewhere.
3376 (struct coding_system):
3377 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3378 * composite.c (get_composition_id, find_composition)
3379 (run_composition_function, update_compositions)
3380 (compose_text, composition_gstring_put_cache)
3381 (composition_gstring_p, composition_gstring_width)
3382 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3383 (composition_compute_stop_pos, composition_reseat_it)
3384 (composition_update_it, struct position_record)
3385 (find_automatic_composition, composition_adjust_point)
3386 (Fcomposition_get_gstring, Ffind_composition_internal):
3387 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3388 (update_compositions):
3389 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3390 * composite.h: Adjust decls to match defn changes elsewhere.
3391 (struct composition):
3392 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3393 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3394 Do not attempt to compute the address of the object just before a
3395 buffer; this is not portable.
3397 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3398 (Faset): Use int, not EMACS_INT, where int is wide enough.
3399 (Fstring_to_number): Don't assume fixnums fit in int.
3400 (Frem): Don't assume arg is nonnegative.
3401 * dbusbind.c (xd_append_arg): Check for integers out of range.
3402 (Fdbus_call_method): Don't overflow the timeout int.
3403 (extract_signed, extract_unsigned): New functions.
3404 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3405 (xd_get_connection_references): Return ptrdiff_t, not int.
3407 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3408 (xd_read_message_1):
3409 Use int, not unsigned, where the dbus API uses int.
3410 (Fdbus_message_internal): Don't overflow mtype.
3411 (syms_of_dbusbind): Allocate right-sized buffer for integers.
3412 * dired.c (directory_files_internal, file_name_completion, scmp)
3413 (file_name_completion_stat):
3414 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3415 (file_name_completion): Don't overflow matchcount.
3416 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3417 * dispextern.h: Adjust decls to match defn changes elsewhere.
3418 (struct text_pos, struct glyph, struct bidi_saved_info)
3419 (struct bidi_string_data, struct bidi_it, struct composition_it)
3421 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3422 (struct display_pos, struct composition_it, struct it):
3423 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3424 * dispnew.c (increment_matrix_positions)
3425 (increment_row_positions, mode_line_string)
3426 (marginal_area_string):
3427 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3428 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
3429 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3430 (duration_to_sec_usec): New function, to check for overflow better.
3431 (Fsleep_for, sit_for): Use it.
3432 * doc.c (get_doc_string, store_function_docstring):
3433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3434 (get_doc_string, Fsnarf_documentation):
3435 Use int, not EMACS_INT, where int is wide enough.
3437 Use SAFE_ALLOCA, not alloca.
3438 Check for overflow when converting EMACS_INT to off_t.
3439 * doprnt.c (doprnt):
3440 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3441 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3442 Don't assume uid_t fits into fixnum.
3443 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3444 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3445 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3446 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3447 (general_insert_function)
3448 (Finsert_char, make_buffer_string, make_buffer_string_both)
3449 (update_buffer_properties, Fbuffer_substring)
3450 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3451 (Fsubst_char_in_region, check_translation)
3452 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3453 (transpose_markers, Ftranspose_regions):
3454 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3455 (clip_to_bounds): Move to lisp.h as an inline function).
3456 (Fconstrain_to_field): Don't assume integers are nonnegative.
3457 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3458 (Fsubst_char_in_region, Fsave_restriction):
3459 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3460 (Femacs_pid): Don't assume pid_t fits into fixnum.
3461 (lo_time): Use int, not EMACS_INT, when int suffices.
3462 (lisp_time_argument): Check for usec out of range.
3463 (Fencode_time): Don't assume fixnum fits in int.
3464 (Fuser_login_name, Fuser_full_name): Signal an error
3465 if a uid argument is out of range, rather than relying on
3467 (Fformat_time_string): Remove now-unnecessary check.
3468 lisp_time_argument checks for out-of-range usec now.
3469 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
3470 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3471 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3472 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3473 (init_cmdargs, Fdump_emacs):
3474 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3475 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3476 the bottom (typically) 32 bits of the fixnum.
3477 * eval.c (specpdl_size, call_debugger):
3478 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3479 (when_entered_debugger, Fbacktrace_debug):
3480 Don't assume fixnum can fit in int.
3481 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3482 the object just before a buffer; this is not portable.
3483 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3484 (grow_specpdl, unbind_to):
3485 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3486 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3487 (grow_specpdl): Simplify allocation by using xpalloc.
3488 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
3489 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3490 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3491 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3492 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3494 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3495 (Fcopy_file, non_regular_nbytes, read_non_regular)
3496 (Finsert_file_contents):
3497 Use int, not EMACS_INT, where int is wide enough.
3498 (READ_BUF_SIZE): Verify that it fits in int.
3499 (Finsert_file_contents): Check that counts are in proper range,
3500 rather than assuming fixnums fit into ptrdiff_t etc.
3501 Don't assume fixnums fit into int.
3502 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
3503 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3504 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
3505 (string_char_to_byte, string_byte_to_char)
3506 (string_make_multibyte, string_to_multibyte)
3507 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3508 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3509 (substring_both, Fdelete, internal_equal, Ffillarray)
3510 (Fclear_string, mapcar1)
3511 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3512 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3513 (larger_vector, make_hash_table, maybe_resize_hash_table)
3514 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3515 (Fmaphash, secure_hash):
3516 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3517 (concat): Check for string index and length overflow.
3518 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3520 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3521 (larger_vector): New API (vec, incr_min, size_max) replaces old
3522 one (vec, new_size, init). This catches size overflow.
3523 INIT was removed because it was always Qnil.
3524 All callers changed.
3525 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3526 the upper bound on a hash table index size.
3527 (make_hash_table, maybe_resize_hash_table): Use it.
3528 (secure_hash): Computer start_byte and end_byte only after
3529 they're known to be in ptrdiff_t range.
3530 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3531 (Ffont_get_glyphs, Ffont_at):
3532 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3533 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3534 (Flist_fonts, Fopen_font):
3535 Don't assume fixnum can fit in int.
3536 (check_gstring): Don't assume index can fit in int.
3537 (font_match_p): Check that fixnum is a character, not a nonnegative
3538 fixnum, since the later code needs to stuff it into an int.
3539 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3540 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3541 conversion overflow issues.
3542 (Fopen_font): Check for integer out of range.
3543 (Ffont_get_glyphs): Don't assume index can fit in int.
3544 * font.h: Adjust decls to match defn changes elsewhere.
3545 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3547 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3548 printmax_t, where ptrdiff_t is wide enough.
3549 (Finternal_char_font):
3550 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3551 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3552 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3553 (Fset_frame_position, x_set_frame_parameters)
3554 (x_set_line_spacing, x_set_border_width)
3555 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3556 Check that fixnums are in proper range for system types.
3557 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3558 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3559 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3560 Use SAFE_ALLOCA_LISP, not alloca.
3561 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3562 intptr_t is wide enough.
3563 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3564 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3565 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3566 Check for fixnum out of range.
3567 * ftfont.c (ftfont_list): Don't assume index fits in int.
3568 Check that fixnums are in proper range for system types.
3569 (ftfont_shape_by_flt):
3570 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3571 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3572 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3573 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3574 Check that fixnums are in proper range for system types.
3575 * gnutls.h: Adjust decls to match defn changes elsewhere.
3576 * gtkutil.c (xg_dialog_run):
3577 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3578 (update_frame_tool_bar):
3579 Check that fixnums are in proper range for system types.
3580 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
3581 (lookup_image): Check that fixnums are in range for system types.
3582 * indent.c (last_known_column, last_known_column_point):
3583 (current_column_bol_cache):
3584 (skip_invisible, current_column, check_display_width):
3585 (check_display_width, scan_for_column, current_column_1)
3586 (Findent_to, Fcurrent_indentation, position_indentation)
3587 (indented_beyond_p, Fmove_to_column, compute_motion):
3588 (Fcompute_motion, Fvertical_motion):
3589 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3590 (last_known_column_modified): Use EMACS_INT, not int.
3591 (check_display_width):
3593 Check that fixnums and floats are in proper range for system types.
3594 (compute_motion): Don't assume index or fixnum fits in int.
3595 (compute_motion, Fcompute_motion):
3596 Use int, not EMACS_INT, when it is wide enough.
3597 (vmotion): Omit local var start_hpos that is always 0; that way
3598 we don't need to worry about overflow in expressions involving it.
3599 * indent.h: Adjust decls to match defn changes elsewhere.
3601 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3602 Use int, not EMACS_INT, where int is wide enough.
3603 Remove unused members ovstring_chars_done and tab_offset;
3605 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3606 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3607 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3608 (make_gap, copy_text, insert, insert_and_inherit)
3609 (insert_before_markers, insert_before_markers_and_inherit)
3610 (insert_1, count_combining_before, count_combining_after)
3611 (insert_1_both, insert_from_string)
3612 (insert_from_string_before_markers, insert_from_string_1)
3613 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3614 (adjust_after_replace, adjust_after_insert, replace_range)
3615 (replace_range_2, del_range, del_range_1, del_range_byte)
3616 (del_range_both, del_range_2, modify_region)
3617 (prepare_to_modify_buffer, signal_before_change)
3618 (signal_after_change, Fcombine_after_change_execute):
3619 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3620 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3621 (balance_an_interval, split_interval_right, split_interval_left)
3622 (find_interval, next_interval, update_interval)
3623 (adjust_intervals_for_insertion, delete_node, delete_interval)
3624 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3625 (static_offset_intervals, offset_intervals)
3626 (merge_interval_right, merge_interval_left, make_new_interval)
3627 (graft_intervals_into_buffer, temp_set_point_both)
3628 (temp_set_point, set_point, adjust_for_invis_intang)
3629 (set_point_both, move_if_not_intangible, get_property_and_range)
3630 (get_local_map, copy_intervals, copy_intervals_to_string)
3631 (compare_string_intervals, set_intervals_multibyte_1):
3632 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3633 * intervals.h: Adjust decls to match defn changes elsewhere.
3635 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3636 * keyboard.c (this_command_key_count, this_single_command_key_start)
3637 (before_command_key_count, before_command_echo_length, echo_now)
3638 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3639 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3640 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3641 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3642 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3643 (last_non_minibuf_size, last_point_position, echo_truncate)
3644 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3645 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3646 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3647 (stuff_buffered_input):
3648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3649 (last_auto_save, command_loop_1, read_char):
3650 Use EMACS_INT, not int, to avoid integer overflow.
3651 (record_char): Avoid overflow in total_keys computation.
3652 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3653 * keyboard.h: Adjust decls to match defn changes elsewhere.
3654 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3655 (Fkey_description, Fdescribe_vector, Flookup_key):
3656 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3657 (click_position): New function, to check that positions are in range.
3658 (Fcurrent_active_maps):
3660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3661 (Faccessible_keymaps, Fkey_description):
3662 (preferred_sequence_p):
3663 Don't assume fixnum can fit into int.
3664 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3665 Check for integer overflow in size calculations.
3666 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3667 avoid mishandling large integers.
3668 * lisp.h: Adjust decls to match defn changes elsewhere.
3669 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3670 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3671 (struct Lisp_Marker):
3672 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3673 (clip_to_bounds): Now an inline function, moved here from editfns.c.
3674 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3675 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3676 All callers changed.
3677 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3678 Assume the arg has valid form, since it always does.
3679 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3680 unsigned integer system type.
3681 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3682 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3683 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3684 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3685 (duration_to_sec_usec): New decl.
3686 * lread.c (read_from_string_index, read_from_string_index_byte)
3687 (read_from_string_limit, readchar, unreadchar, openp)
3688 (read_internal_start, read1, oblookup):
3689 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3690 (Fload, readevalloop, Feval_buffer, Feval_region):
3691 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3692 (openp): Check for out-of-range argument to 'access'.
3693 (read1): Use int, not EMACS_INT, where int is wide enough.
3694 Don't assume fixnum fits into int.
3695 Fix off-by-one error that can read outside a buffer.
3696 (read_filtered_event): Use duration_to_sec_usec
3697 to do proper overflow checking on durations.
3698 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3699 in size calculation.
3700 (Fexecute_kbd_macro):
3701 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3702 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3703 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3704 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3705 (set_marker_both, set_marker_restricted_both, marker_position)
3706 (marker_byte_position, Fbuffer_has_markers_at):
3707 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3708 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
3709 * menu.c (ensure_menu_items): Rename from grow_menu_items.
3710 It now merely ensures that the menu is large enough, without
3711 necessarily growing it, as this avoids some integer overflow issues.
3712 All callers changed.
3713 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3714 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3715 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3716 Use SAFE_ALLOCA_LISP, not alloca.
3717 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3718 to EMACS_INT. Check that fixnums are in proper range for system types.
3719 * minibuf.c (minibuf_prompt_width, string_to_object)
3720 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3721 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3722 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3723 (get_minibuffer, read_minibuf_unwind):
3724 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3725 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3726 this simplifies overflow checking. All callers changed.
3727 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3729 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3730 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3731 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3732 Check that fixnums are in proper range for system types.
3733 (Fx_create_frame, Fx_show_tip):
3734 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3735 * nsfont.m (ns_findfonts, nsfont_list_family):
3736 Don't assume fixnum fits in long.
3737 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3738 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3739 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3741 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
3742 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3743 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3744 (PRINTDECLARE, PRINTPREPARE):
3745 (strout, print_string):
3746 (print, print_preprocess, print_check_string_charset_prop)
3748 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3750 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3751 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3752 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
3753 (printchar, strout): Use xpalloc to catch size calculation overflow.
3754 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
3755 (print_error_message): Use SAFE_ALLOCA, not alloca.
3756 (print_object): Use int, not EMACS_INT, where int is wide enough.
3757 (print_depth, new_backquote_output, print_number_index):
3758 Use ptrdiff_t, not int, where int might not be wide enough.
3759 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3760 (Fset_process_window_size, Fformat_network_address)
3761 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
3763 Check that fixnums are in proper range for system types.
3764 (Fsignal_process): Simplify by avoiding a goto.
3765 Check for process-ids out of pid_t range rather than relying on
3767 (process_tick, update_tick): Use EMACS_INT, not int.
3768 (Fformat_network_address, read_process_output, send_process)
3769 (Fprocess_send_region, status_notify):
3770 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3771 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3772 (wait_reading_process_output, read_process_output, exec_sentinel):
3773 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3774 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3775 (Faccept_process_output): Use duration_to_sec_usec to do proper
3776 overflow checking on durations.
3777 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3778 Don't assume pid_t fits in int.
3779 * process.h (struct Lisp_Process): Members tick and update_tick
3780 are now of type EMACS_INT, not int.
3781 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3782 configured --with-wide-int.
3783 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3784 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3785 * search.c (looking_at_1, string_match_1):
3786 (fast_string_match, fast_c_string_match_ignore_case)
3787 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3788 (scan_newline, find_before_next_newline, search_command)
3789 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3790 (set_search_regs, wordify):
3793 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3794 (string_match_1, search_buffer, set_search_regs):
3796 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3797 (wordify): Check for overflow in size calculation.
3798 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3799 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3800 Check that fixnums are in proper range for system types.
3801 * sound.c (struct sound_device)
3802 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3803 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3804 (Fplay_sound_internal):
3805 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3806 * syntax.c (struct lisp_parse_state, find_start_modiff)
3807 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3808 (Fparse_partial_sexp):
3809 Don't assume fixnums can fit in int.
3810 (struct lisp_parse_state, find_start_pos, find_start_value)
3811 (find_start_value_byte, find_start_begv)
3812 (update_syntax_table, char_quoted, dec_bytepos)
3813 (find_defun_start, prev_char_comend_first, back_comment):
3814 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3815 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3816 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3817 (Finternal_describe_syntax_value): Check that match_lisp is a
3818 character, not an integer, since the code stuffs it into int.
3819 (scan_words, scan_sexps_forward):
3820 Check that fixnums are in proper range for system types.
3822 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3823 (scan_sexps_forward):
3824 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3825 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3826 * syntax.h: Adjust decls to match defn changes elsewhere.
3827 (struct gl_state_s):
3828 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3829 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3830 MOST_POSITIVE_FIXNUM.
3831 * sysdep.c (wait_for_termination_1, wait_for_termination)
3832 (interruptible_wait_for_termination, mkdir):
3833 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3834 (emacs_read, emacs_write):
3835 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3836 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3837 and double all fit in int.
3838 * term.c (set_tty_color_mode):
3839 Check that fixnums are in proper range for system types.
3840 * termhooks.h (struct input_event):
3841 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3842 * textprop.c (validate_interval_range, interval_of)
3843 (Fadd_text_properties, set_text_properties_1)
3844 (Fremove_text_properties, Fremove_list_of_text_properties)
3845 (Ftext_property_any, Ftext_property_not_all)
3846 (copy_text_properties, text_property_list, extend_property_ranges)
3847 (verify_interval_modification):
3848 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3849 (Fnext_single_char_property_change)
3850 (Fprevious_single_char_property_change):
3851 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3852 (copy_text_properties):
3853 Check for integer overflow in index calculation.
3854 * undo.c (last_boundary_position, record_point, record_insert)
3855 (record_delete, record_marker_adjustment, record_change)
3856 (record_property_change):
3857 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3858 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3859 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3860 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3861 (Fx_hide_tip, Fx_file_dialog):
3862 * w32menu.c (set_frame_menubar):
3863 Use ptrdiff_t, not int, for consistency with rest of code.
3864 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3865 (select_window, Fdelete_other_windows_internal)
3866 (window_scroll_pixel_based, window_scroll_line_based)
3867 (Frecenter, Fset_window_configuration):
3868 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3869 (Fset_window_hscroll, run_window_configuration_change_hook)
3870 (set_window_buffer, temp_output_buffer_show, scroll_command)
3871 (Fscroll_other_window, Frecenter):
3872 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3873 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3874 Don't assume fixnum fits in int.
3875 (Fset_window_scroll_bars):
3876 Check that fixnums are in proper range for system types.
3877 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3878 (string_pos, c_string_pos, number_of_chars, init_iterator)
3879 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3880 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3881 (compute_display_string_end, handle_face_prop)
3882 (face_before_or_after_it_pos, handle_invisible_prop)
3883 (handle_display_prop, handle_display_spec, handle_single_display_spec)
3884 (display_prop_intangible_p, string_buffer_position_lim)
3885 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3886 (get_overlay_strings_1, get_overlay_strings)
3887 (iterate_out_of_display_property, forward_to_next_line_start)
3888 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3889 (get_next_display_element, set_iterator_to_next)
3890 (get_visually_first_element, compute_stop_pos_backwards)
3891 (handle_stop_backwards, next_element_from_buffer)
3892 (move_it_in_display_line_to, move_it_in_display_line)
3893 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3894 (add_to_log, message_dolog, message_log_check_duplicate)
3895 (message2, message2_nolog, message3, message3_nolog
3896 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3897 (current_message_1, truncate_echo_area, truncate_message_1)
3898 (set_message, set_message_1, store_mode_line_noprop)
3899 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3900 (text_outside_line_unchanged_p, check_point_in_composition)
3901 (reconsider_clip_changes)
3902 (redisplay_internal, set_cursor_from_row, try_scrolling)
3903 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3904 (redisplay_window, find_last_unchanged_at_beg_row)
3905 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3906 (trailing_whitespace_p, find_row_edges, display_line)
3907 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3908 (display_mode_element, store_mode_line_string)
3909 (pint2str, pint2hrstr, decode_mode_spec)
3910 (display_count_lines, display_string, draw_glyphs)
3911 (x_produce_glyphs, x_insert_glyphs)
3912 (rows_from_pos_range, mouse_face_from_buffer_pos)
3913 (fast_find_string_pos, mouse_face_from_string_pos)
3914 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3915 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3916 (safe_call, init_from_display_pos, handle_fontified_prop)
3917 (handle_single_display_spec, load_overlay_strings)
3918 (with_echo_area_buffer, setup_echo_area_for_printing)
3919 (display_echo_area, echo_area_display)
3920 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3921 (update_tool_bar, hscroll_window_tree, redisplay_internal)
3922 (redisplay_window, dump_glyph_row, display_mode_line)
3923 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
3924 (handle_display_spec, display_prop_string_p):
3925 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3926 (handle_single_display_spec, build_desired_tool_bar_string)
3927 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3928 (get_specified_cursor_type):
3929 Check that fixnums are in proper range for system types.
3930 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3931 (Flookup_image_map):
3932 Don't assume fixnums fit in int.
3933 (compare_overlay_entries):
3934 Avoid mishandling comparisons due to subtraction overflow.
3935 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3936 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3937 (handle_tool_bar_click):
3938 Use int, not unsigned, since we prefer signed and the signedness
3939 doesn't matter here.
3940 (get_next_display_element, next_element_from_display_vector):
3941 Use int, not EMACS_INT, when int is wide enough.
3942 (start_hourglass): Use duration_to_sec_usec to do proper
3943 overflow checking on durations.
3944 * xfaces.c (Fbitmap_spec_p):
3945 Check that fixnums are in proper range for system types.
3946 (compare_fonts_by_sort_order):
3947 Avoid mishandling comparisons due to subtraction overflow.
3948 (Fx_family_fonts, realize_basic_faces):
3949 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3951 Don't assume fixnum fits in int.
3952 Use SAFE_ALLOCA_LISP, not alloca.
3953 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3954 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3955 (face_at_buffer_position, face_for_overlay_string)
3956 (face_at_string_position):
3957 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3958 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3959 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3961 Check that fixnums are in proper range for system types.
3962 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3963 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3964 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3965 (Fx_change_window_property): Don't assume fixnums fit in int.
3966 * xfont.c (xfont_chars_supported):
3967 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3968 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3969 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3970 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3971 * xml.c (parse_region):
3972 * xrdb.c (magic_file_p):
3973 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3974 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3975 (x_get_local_selection, x_reply_selection_request)
3976 (x_handle_selection_request, wait_for_property_change):
3977 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3978 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3979 short is wide enough.
3980 (x_send_client_event): Don't assume fixnum fits in int.
3981 * xterm.c (x_x_to_emacs_modifiers):
3982 Don't assume EMACS_INT overflows nicely into int.
3983 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3985 (handle_one_xevent): NATNUMP can eval its arg twice.
3986 (x_connection_closed):
3987 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3988 * xterm.h: Adjust decls to match defn changes elsewhere.
3989 (struct scroll_bar): Use struct vectorlike_header
3990 rather than rolling our own approximation.
3991 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3993 2012-05-25 Glenn Morris <rgm@gnu.org>
3995 * lisp.mk (lisp): Update for more files being compiled now.
3997 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3999 * lread.c: Remove `read_pure' which makes no difference.
4000 (read_pure): Remove var.
4001 (unreadpure): Remove function.
4002 (readevalloop): Don't call read_list with -1 flag.
4003 (read1, read_vector): Don't test read_pure any more.
4004 (read_list): Simplify.
4006 * fileio.c, character.h: Minor style tweaks.
4008 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4010 * window.h (clip_changed): Remove useless declaration.
4012 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
4014 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4015 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4017 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4020 This directory predates autoconf and is no longer needed nowadays.
4021 Move its few remaining bits of functionality to where they're needed.
4022 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4023 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4024 * m/template.h: Remove.
4025 * Makefile.in (M_FILE): Remove. All uses removed.
4026 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4027 * lisp.h (USE_LSB_TAG):
4028 * mem-limits.h (EXCEEDS_LISP_PTR):
4029 Use VAL_MAX, not VALBITS, in #if.
4030 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4031 (EMACS_UINT): Define unconditionally now.
4032 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4033 (BITS_PER_EMACS_INT): New constants, replacing
4034 what used to be in config.h, but not useful in #if.
4035 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4036 define them any more.
4037 (VAL_MAX): New macro.
4039 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4040 BITS_PER_EMACS_INT, in #if.
4041 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4042 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4043 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4044 * s/ms-w32.h (DATA_START):
4045 Move here from removed file m/intel386.h.
4046 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4047 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4049 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4051 Assume C89 or later.
4052 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4053 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4055 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4056 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4057 * textprop.c, tparam.c (NULL): Remove.
4058 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4059 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4060 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4061 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4062 * xterm.c (input_signal_count): Assume volatile works.
4064 2012-05-21 Ken Brown <kbrown@cornell.edu>
4066 * xgselect.c (xg_select): Fix first argument in call to 'select'
4069 2012-05-20 Ken Brown <kbrown@cornell.edu>
4071 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
4072 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
4074 2012-05-19 Ken Brown <kbrown@cornell.edu>
4076 * xfns.c (x_in_use): Remove `static' qualifier.
4077 * xterm.h (x_in_use): Declare.
4078 * xgselect.c: Include xterm.h.
4079 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4080 and `display_arg' (bug#9754).
4082 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4084 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4086 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4087 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4089 2012-05-18 Eli Zaretskii <eliz@gnu.org>
4091 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4093 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
4094 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
4096 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4097 reference to image_cache->refcount.
4098 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4100 2012-05-17 Juri Linkov <juri@jurta.org>
4102 * search.c (Fword_search_regexp, Fword_search_backward)
4103 (Fword_search_forward, Fword_search_backward_lax)
4104 (Fword_search_forward_lax): Move functions to isearch.el
4105 (bug#10145, bug#11381).
4107 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4109 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4111 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4113 * lread.c (init_obarray): Declare Qt and Qnil as special.
4115 2012-05-14 Glenn Morris <rgm@gnu.org>
4117 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
4118 Put "libexec" before "bin", for the sake of init_callproc_1.
4120 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4122 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4124 * unexaix.c: Port to more-recent AIX compilers.
4125 (report_error, report_error_1, make_hdr, copy_sym)
4126 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4127 Make arguments const char *, not char *, to avoid violations of C
4128 standard and to fix some AIX warnings reported by Gilles Pion.
4130 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4132 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4133 already have overlays loaded.
4134 (handle_single_display_spec): Before returning without displaying
4135 fringe bitmap, synchronize the bidi iterator with the main display
4136 iterator, by calling iterate_out_of_display_property.
4137 (iterate_out_of_display_property): Detect buffer iteration by
4138 testing that it->string is a Lisp string.
4139 (get_next_display_element): When the current object is exhausted,
4140 and there's something on it->stack, call set_iterator_to_next to
4141 proceed with what's on the stack, instead of returning zero.
4142 (set_iterator_to_next): If called at the end of a Lisp string,
4143 proceed to consider_string_end without incrementing string
4144 position. Don't increment display vector index past the end of
4145 the display vector. (Bug#11417)
4146 (pos_visible_p): Don't report a position visible when move_it_to
4147 stopped at the last line of window, which happens to be scanned
4148 backwards by the bidi iteration. (Bug#11464)
4150 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4152 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4153 and right-margin display specs even if the spec is invalid or we
4154 are on a TTY, and thus unable to display on the fringes.
4155 That's because the text with the property will not be displayed anyway,
4156 so we need to signal to the caller that this is a "replacing"
4157 display spec. This fixes display when the spec is invalid or we
4160 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4162 * unexaix.c (make_hdr): Fix typo in prototype.
4163 This bug broke the build on AIX. Problem reported by Gilles Pion.
4165 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
4167 * keyboard.c (kbd_buffer_get_event): Read special events also in
4168 batch mode. (Bug#11415)
4170 2012-05-12 Glenn Morris <rgm@gnu.org>
4172 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4174 2012-05-12 Eli Zaretskii <eliz@gnu.org>
4176 * lisp.mk (lisp): Add newcomment.elc.
4178 2012-05-12 Glenn Morris <rgm@gnu.org>
4180 * Makefile.in (MKDIR_P): New, set by configure.
4181 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4183 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4185 Remove unused function hourglass_started.
4186 * dispextern.h (hourglass_started):
4187 * w32fns.c (hourglass_started):
4188 * xdisp.c (hourglass_started): Remove.
4190 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
4192 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4193 Update dependencies.
4195 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4197 * xgselect.c (xg_select): Put maxfds+1 into a var.
4198 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4200 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4202 2012-05-10 Dave Abrahams <dave@boostpro.com>
4204 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4205 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4207 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
4209 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4210 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4211 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4212 Initialize xd_registered_buses.
4214 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4216 Untag more efficiently if USE_LSB_TAG.
4217 This is based on a proposal by YAMAMOTO Mitsuharu in
4218 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4219 For an admittedly artificial (nth 8000 longlist) benchmark on
4220 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4221 Emacs's overall text size by 1%.
4222 * lisp.h (XUNTAG): New macro.
4223 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4224 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4225 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4226 * eval.c (Fautoload):
4227 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4228 * frame.h (XFRAME): Use XUNTAG.
4230 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4231 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4232 Remove unportable assumptions about print widths of types like
4234 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4235 intptr_t when converting between pointer and integer, to avoid GCC
4236 warnings about wrong width.
4238 2012-05-09 Eli Zaretskii <eliz@gnu.org>
4240 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4241 stack for each reader_thread, instead of defaulting to 8MB
4242 determined by the linker. This avoids failures in creating
4243 subprocesses on Windows 7, see the discussion in this thread:
4244 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4246 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4248 Fix up display of the *Minibuf-0* buffer in the mini window.
4249 * keyboard.c (read_char): Don't clear the echo area if there's no
4251 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
4252 contents of *Minibuf-0*) if there's no message displayed in its stead.
4254 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
4256 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4259 2012-05-06 Chong Yidong <cyd@gnu.org>
4261 * lisp.mk (lisp): Update.
4263 2012-05-05 Jim Meyering <meyering@redhat.com>
4265 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4267 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4269 * data.c (PUT_ERROR): New macro.
4270 (syms_of_data): Use it. Add new error type `user-error'.
4271 * undo.c (user_error): New function.
4272 (Fprimitive_undo): Use it.
4273 * print.c (print_error_message): Adjust print style for `user-error'.
4274 * keyboard.c (user_error): New function.
4275 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4277 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4279 Do not limit current-time-string to years 1000..9999.
4280 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4281 (Fcurrent_time_string): Support any year that is supported by the
4282 underlying localtime representation. Don't use asctime, as it
4283 has undefined behavior for years outside the range -999..9999.
4285 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4287 Fix race conditions involving setenv, gmtime, localtime, asctime.
4288 Without this fix, interrupts could mess up code that uses these
4289 nonreentrant functions, since setting TZ invalidates existing
4290 tm_zone or tzname values, and since most of these functions return
4291 pointers to static storage.
4292 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4293 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4294 Grow the critical sections to include not just invoking
4295 localtime/gmtime, but also accessing these functions' results
4296 including their tm_zone values if any, and any related TZ setting.
4297 (format_time_string): Last arg is now struct tm *, not struct tm **,
4298 so that the struct tm is saved in the critical section.
4299 All callers changed. Simplify allocation of initial buffer, partly
4300 motivated by the fact that memory allocation needs to be outside
4301 the critical section.
4303 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4305 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4306 with RESET_INTERVAL.
4308 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4309 Remove duplicated buffer name initialization.
4311 2012-05-02 Jim Meyering <jim@meyering.net>
4313 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4315 * xfns.c (x_window): Use xstrdup (Bug#11375).
4317 2012-05-02 Eli Zaretskii <eliz@gnu.org>
4319 * xdisp.c (pos_visible_p): If already at a newline from the
4320 display string before the 'while' loop, don't walk back the glyphs
4321 from it3.glyph_row. Solves assertion violation when the display
4322 string begins with a newline (egg.el). (Bug#11367)
4324 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4326 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4329 2012-05-01 Glenn Morris <rgm@gnu.org>
4331 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4332 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4333 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4334 All were removed before 23.1.
4336 * dispnew.c: Remove HAVE_LIBNCURSES test;
4337 it is always true on relevant platforms.
4339 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4340 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4342 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4344 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4346 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4347 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4350 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4352 Do not avoid creating empty evaporating overlays (Bug#9642).
4353 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4354 That is, do not delete an evaporating overlay if it becomes
4355 empty after its bounds are adjusted to fit within its buffer.
4356 This fix caused other problems, and I'm reverting it until we get
4357 to the bottom of them.
4359 2012-04-27 Chong Yidong <cyd@gnu.org>
4361 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4363 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4365 * xdisp.c (pos_visible_p): If the window start position is beyond
4366 ZV, start the display from buffer beginning. Prevents assertion
4367 violation in init_iterator when the minibuffer window is scrolled
4370 * window.c (window_scroll_pixel_based): Likewise.
4372 2012-04-27 Chong Yidong <cyd@gnu.org>
4374 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4376 2012-04-27 Glenn Morris <rgm@gnu.org>
4378 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4379 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4381 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4383 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4384 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
4386 2012-04-26 Eli Zaretskii <eliz@gnu.org>
4388 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4389 display element, check also the underlying string or buffer
4390 character. (Bug#11341)
4392 * w32menu.c: Include w32heap.h.
4393 (add_menu_item): If the call to AppendMenuW (via
4394 unicode_append_menu) fails, disable Unicode menus only if we are
4395 running on Windows 9X/Me.
4397 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4399 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4400 (xgetint): Add missing shift for LSB tags.
4402 2012-04-24 Martin Rudalics <rudalics@gmx.at>
4404 * keyboard.c (read_char): Don't wipe echo area for select window
4405 events: These might get delayed via `mouse-autoselect-window'
4408 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
4410 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4411 manipulation of :loaded-from data.
4413 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
4415 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4416 now a cons (bug#11311).
4418 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4420 Do not create empty overlays with the evaporate property (Bug#9642).
4421 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4422 if it becomes empty after its bounds are adjusted to fit within
4423 its buffer. Without this fix, in a nonempty buffer (let ((o
4424 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4425 yields an empty overlay that has the evaporate property, which is
4426 not supposed to happen.
4428 Fix minor GTK3 problems found by static checking.
4429 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4430 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4431 (struct _EmacsFixedClass, emacs_fixed_get_type):
4432 Move decls here from emacsgtkfixed.h, since they needn't be public.
4433 (emacs_fixed_get_type): Now static.
4434 (emacs_fixed_class_init): Omit unused local.
4435 (emacs_fixed_child_type): Remove; unused.
4436 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4437 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4438 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4439 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4440 (EMACS_FIXED_GET_CLASS): Remove; unused.
4441 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4443 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4444 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4446 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4448 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
4449 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
4450 (__malloc_size_t, __malloc_ptrdiff_t):
4451 Remove. All uses removed, replaced by the definiens if needed,
4452 since we can assume C89 or better now.
4453 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4454 (protect_malloc_state, align, get_contiguous_space)
4455 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4456 (malloc_atfork_handler_child, malloc_enable_thread)
4457 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4458 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4459 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4460 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4461 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4462 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4463 Define using prototypes, not old style.
4464 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4465 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4466 (align): Don't assume that signed integer overflow wraps around.
4467 Omit unused local var.
4468 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4469 (_free_internal_nolock, memalign, mallochook, reallochook):
4470 Omit no-longer-needed casts.
4471 (valloc): Use getpagesize, not __getpagesize.
4472 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4473 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4475 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4477 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
4479 Move functions from C to Lisp. Make non-blocking method calls
4480 the default. Implement further D-Bus standard interfaces.
4482 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4483 (QCdbus_request_name_allow_replacement)
4484 (QCdbus_request_name_replace_existing)
4485 (QCdbus_request_name_do_not_queue)
4486 (QCdbus_request_name_reply_primary_owner)
4487 (QCdbus_request_name_reply_in_queue)
4488 (QCdbus_request_name_reply_exists)
4489 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4490 (QCdbus_registered_serial, QCdbus_registered_method)
4491 (QCdbus_registered_signal): New Lisp objects.
4492 (XD_DEBUG_MESSAGE): Use sizeof.
4493 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4494 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4495 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4496 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4497 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4498 (xd_signature, xd_append_arg): Allow float for integer types.
4499 (xd_get_connection_references): New function.
4500 (xd_get_connection_address): Rename from xd_initialize.
4501 Return cached address.
4502 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4503 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4505 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
4506 Return number of refcounts.
4507 (Fdbus_get_unique_name): Make stronger parameter check.
4508 (Fdbus_message_internal): New defun.
4509 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4510 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4511 (Fdbus_send_signal, Fdbus_register_service)
4512 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4513 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4514 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4515 (Vdbus_compiled_version, Vdbus_runtime_version)
4516 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4517 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4518 (Vdbus_message_type_signal): New defvars.
4519 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4522 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4524 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4525 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4526 Do not assume ptrdiff_t is the same width as 'int'.
4528 * alloc.c: Handle unusual debugging option combinations.
4529 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4530 since the two debugging options are incompatible.
4531 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4533 (mem_init, mem_insert, mem_insert_fixup):
4534 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4535 (NEED_MEM_INSERT): Remove; no longer needed.
4537 2012-04-22 Leo Liu <sdl.web@gmail.com>
4539 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4541 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4543 * sysdep.c [__FreeBSD__]: Minor cleanups.
4544 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4545 Use Emacs indenting style more consistently. Avoid some casts.
4546 Use 'double' consistently rather than mixing 'float' and 'double'.
4548 2012-04-21 Eduard Wiebe <usenet@pusto.de>
4550 * sysdep.c (list_system_processes, system_process_attributes):
4551 Add implementation for FreeBSD (Bug#5243).
4553 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4555 * lisp.mk (lisp): Update.
4557 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4559 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4560 It is never used otherwise.
4562 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4564 * print.c (print_preprocess): Only check print_depth if print-circle
4566 (print_object): Check for cycles even when print-circle is nil and
4567 print-gensym is t, but only check print_depth if print-circle is nil.
4569 2012-04-20 Chong Yidong <cyd@gnu.org>
4571 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4572 set the status to "failed" and ensure that sentinel is run.
4574 2012-04-20 Glenn Morris <rgm@gnu.org>
4576 * process.c (Fset_process_inherit_coding_system_flag)
4577 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4578 (Fmake_network_process, Fmake_serial_process): Doc fix.
4580 2012-04-20 Eli Zaretskii <eliz@gnu.org>
4582 * xdisp.c (string_buffer_position_lim): Limit starting position to
4584 (set_cursor_from_row): If called for a mode-line or header-line
4585 row, return zero immediately.
4586 (try_cursor_movement): If inside continuation line, don't back up
4587 farther than the first row after the header line, if any.
4588 Don't consider the header-line row as "partially visible", even if
4589 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4591 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4593 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4596 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
4597 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
4599 configure: new option --enable-gcc-warnings (Bug#11207)
4600 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4601 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4602 (ALL_CFLAGS): Use new macros rather than old.
4603 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4604 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4605 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4606 -Wunused-result, -Wunused-variable. This should go away once
4607 the Emacs and Gnulib regex code is merged.
4608 (xmalloc, xrealloc): Now static.
4610 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4612 * dired.c (Fsystem_groups): Remove unused local.
4614 2012-04-17 Glenn Morris <rgm@gnu.org>
4616 * dired.c (Fsystem_users): Doc fix.
4618 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4620 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4621 (syms_of_dired): Add them.
4623 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4625 Fix minor alloc.c problems found by static checking.
4626 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4627 New extern decls, to avoid calling undeclared functions.
4628 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4629 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4630 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4631 (NEED_MEM_INSERT): New macro.
4632 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4633 Remove one incorrect comment and fix another.
4635 Fix minor ralloc.c problems found by static checking.
4636 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4637 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4638 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4639 (r_alloc_sbrk): Now static.
4641 Improve ralloc.c interface checking.
4642 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4643 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4644 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4645 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4646 [REL_ALLOC]: ... to here, to check interface.
4647 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4648 Remove decls. This fixes an "It stinks!".
4650 * alloc.c (which_symbols): Fix alignment issue / type clash.
4652 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4654 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4655 (struct Lisp_Misc_Any): Likewise.
4656 (struct Lisp_Free): Likewise.
4657 * alloc.c (union aligned_Lisp_Symbol): Define.
4658 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4659 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4660 (union aligned_Lisp_Misc): Define.
4661 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4662 aligned_Lisp_Misc instead of union Lisp_Misc.
4663 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
4665 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4667 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4668 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4669 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4670 * s/netbsd.h, s/sol2-6.h:
4671 Remove definition of GC_MARK_STACK, since the default now works.
4672 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4673 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4674 no longer the default.
4675 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4677 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4679 * lread.c (lisp_file_lexically_bound_p):
4680 Fix hang at ";-*-\n" (bug#11238).
4682 2012-04-14 Eli Zaretskii <eliz@gnu.org>
4684 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4685 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4687 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4689 * nsterm.m (constrainFrameRect): Always constrain when there is only
4690 one screen (Bug#10962).
4692 2012-04-13 Ken Brown <kbrown@cornell.edu>
4694 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4696 2012-04-13 Reuben Thomas <rrt@sc3d.org>
4698 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4700 2012-04-11 Daniel Colascione <dancol@dancol.org>
4702 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4703 against is gone. It's better to use vfork now so that when Cygwin
4704 gains a new, working vfork, we use it automatically (bug#10398).
4706 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4708 * window.c (save_window_save): Obey window-point-insertion-type.
4710 2012-04-11 Glenn Morris <rgm@gnu.org>
4712 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4714 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4716 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4718 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
4720 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4721 (force_quit_count): New var.
4722 (handle_interrupt): Use it.
4724 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
4726 * w32.c (w32_delayed_load): Record the full path of the library
4727 being loaded (bug#10424).
4729 2012-04-09 Glenn Morris <rgm@gnu.org>
4731 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4732 not just in the obarray, before snarfing them. (Bug#11036)
4734 * Makefile.in ($(leimdir)/leim-list.el):
4735 Pass EMACS rather than BUILT_EMACS.
4737 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4739 * process.c (make_process):
4740 * process.h: Add integer `gnutls_handshakes_tried' member to
4743 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4744 Add convenience `GNUTLS_LOG2i' macro.
4746 * gnutls.c (gnutls_log_function2i): Convenience log function.
4747 (emacs_gnutls_read): Use new log functions,
4748 `gnutls_handshakes_tried' process member, and
4749 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4750 attempts per process (connection).
4752 2012-04-09 Chong Yidong <cyd@gnu.org>
4754 * eval.c (Fuser_variable_p, user_variable_p_eh)
4755 (lisp_indirect_variable): Functions deleted.
4756 (Fdefvar): Caller changed.
4758 * callint.c (Finteractive, Fcall_interactively):
4759 * minibuf.c (Fread_variable): Callers changed.
4761 2012-04-09 Eli Zaretskii <eliz@gnu.org>
4763 * xdisp.c (set_cursor_from_row): If the display string appears in
4764 the buffer at position that is closer to point than the position
4765 after the display string, display the cursor on the first glyph of
4766 the display string. Fixes cursor display when a 'display' text
4767 property immediately follows invisible text. (Bug#11094)
4769 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4771 composite.c: use 'double' consistently
4772 * composite.c (get_composition_id): Use 'double' consistently
4773 instead of converting 'float' to 'double' and vice versa; this is
4774 easier to understand and avoids a GCC warning.
4776 2012-04-09 Glenn Morris <rgm@gnu.org>
4778 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4779 preparation for dumping it with emacs. (Bug#4789)
4780 (leimdir): New variable.
4781 ($(leimdir)/leim-list.el): New rule.
4782 (emacs$(EXEEXT)): Depend on leim-list.el.
4784 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4785 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4786 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4788 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4790 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4793 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
4795 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4796 Remove unused local variable.
4798 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4800 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4801 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4802 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4803 objects, as mark_maybe_pointer will catch them otherwise.
4804 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4805 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4807 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4809 Fix typo that broke non-Windows builds.
4810 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4812 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4814 Support building on MS-Windows with libxml2.
4816 * makefile.w32-in (OBJ2): Add xml.$(O).
4817 (GLOBAL_SOURCES): Add xml.c.
4818 ($(BLD)/xml.$(O)): New dependency list.
4820 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4821 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4822 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4823 [!WINDOWSNT]: New macros.
4824 (init_libxml2_functions, libxml2_loaded_p): New functions.
4825 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4826 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4827 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4828 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4830 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4831 Call init_libxml2_functions before calling libxml2 functions.
4832 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4834 * emacs.c: Don't include libxml/parser.h.
4835 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4836 xmlCleanupParser directly.
4838 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4840 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4842 * indent.c (Fvertical_motion): If there is a display string at
4843 point, use it.vpos to compute how many lines to backtrack after
4844 move_it_to point. (Bug#11133)
4846 2012-04-06 Eli Zaretskii <eliz@gnu.org>
4848 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4849 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4850 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4851 macros related to unification of CJK characters. For the details,
4852 see the discussion following the message here:
4853 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4855 2012-04-04 Chong Yidong <cyd@gnu.org>
4857 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4859 2012-04-01 Eli Zaretskii <eliz@gnu.org>
4861 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4862 instead of alloca. (Bug#11138)
4864 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4866 * w32menu.c (is_simple_dialog): Properly check lisp types.
4869 2012-03-31 Eli Zaretskii <eliz@gnu.org>
4871 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4872 position we get to after a call to move_it_to fails the
4873 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4874 only if we wind up in a string from display property. (Bug#11063)
4876 * window.c (Fdelete_other_windows_internal): Invalidate the row
4877 and column information about mouse highlight, so that redisplay
4878 restores it after reallocating the glyph matrices. (Bug#7464)
4880 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4881 string comes from a `display' text property, use the buffer
4882 position of that property as if we actually saw that position in
4884 (move_it_by_lines): Remove the assertion that
4885 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4886 violated when there's a before-string at the beginning of a line.
4889 2012-03-30 Eli Zaretskii <eliz@gnu.org>
4891 * xdisp.c (append_space_for_newline): If the default face was
4892 remapped, use the remapped face for the appended newline.
4893 (extend_face_to_end_of_line): Use the remapped default face for
4894 extending the face to the end of the line.
4895 (display_line): Call extend_face_to_end_of_line when the default
4896 face was remapped. (Bug#11068)
4898 2012-03-29 Eli Zaretskii <eliz@gnu.org>
4900 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4902 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4904 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4906 2012-03-27 Glenn Morris <rgm@gnu.org>
4908 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4911 2012-03-26 Kenichi Handa <handa@m17n.org>
4913 * dispextern.h (struct glyph): Fix previous change. Change the
4914 bit length of glyphless.ch to 25 (Bug#11082).
4916 2012-03-26 Chong Yidong <cyd@gnu.org>
4918 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4919 (command_loop_1): Use it; inhibit selection update for
4920 handle-select-window too (Bug#8996).
4922 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4924 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
4926 2012-03-25 Kenichi Handa <handa@m17n.org>
4928 * dispextern.h (struct glyph): Change the bit length of
4929 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4931 2012-03-24 Eli Zaretskii <eliz@gnu.org>
4933 * s/ms-w32.h (tzname): Include time.h before redirecting to
4934 _tzname. Fixes the MSVC build. (Bug#9960)
4936 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4938 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4941 * xterm.c (XTread_socket): Only modify handling_signal if
4942 !SYNC_INPUT. (Bug#11080)
4944 2012-03-23 Eli Zaretskii <eliz@gnu.org>
4946 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4947 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4948 when fetching a multibyte character consumes more bytes than
4949 CHAR_BYTES returns, due to unification of CJK characters in
4950 string_char. (Bug#11073)
4952 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4954 * process.c (wait_reading_process_output): Handle pty disconnect
4955 by refraining from sending oneself a SIGCHLD (bug#10933).
4957 2012-03-22 Chong Yidong <cyd@gnu.org>
4959 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4961 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
4962 Mark string as coming from a prefix property.
4963 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4964 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4966 2012-03-21 Chong Yidong <cyd@gnu.org>
4968 * xfaces.c (Vface_remapping_alist): Doc fix.
4970 2012-03-20 Eli Zaretskii <eliz@gnu.org>
4972 * w32proc.c (Fw32_set_console_codepage)
4973 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4976 2012-03-20 Chong Yidong <cyd@gnu.org>
4978 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4979 to reflect default non-nil value of redisplay-dont-pause.
4981 2012-03-19 Kenichi Handa <handa@m17n.org>
4983 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4984 it fit in a valid range (Bug#11003).
4986 2012-03-18 Eli Zaretskii <eliz@gnu.org>
4988 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4989 that is not from display property, accept the row as a "cursor
4990 row" if one of the string's character has a non-nil `cursor'
4991 property. Fixes cursor positioning when there are newlines in
4992 overlay strings, e.g. in icomplete.el. (Bug#11035)
4994 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4996 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4998 2012-03-12 Chong Yidong <cyd@gnu.org>
5000 * eval.c (inhibit_lisp_code): Rename from
5001 inhibit_window_configuration_change_hook; move from window.c.
5003 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5004 * window.c (run_window_configuration_change_hook)
5005 (syms_of_window): Callers changed.
5007 2012-03-11 Chong Yidong <cyd@gnu.org>
5009 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5011 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5013 2012-03-10 Chong Yidong <cyd@gnu.org>
5015 * frame.c (other_visible_frames): Don't assume the selected frame
5016 is visible (Bug#10955).
5018 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5020 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5022 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5024 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5025 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5028 2012-03-03 Glenn Morris <rgm@gnu.org>
5030 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
5032 2012-03-02 Eli Zaretskii <eliz@gnu.org>
5034 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5035 position past the first glyph_row that ends at ZV. (Bug#10902)
5036 (redisplay_window, next_element_from_string): Fix typos in
5038 (redisplay_window): Pass to move_it_vertically the margin in
5039 pixels, not in screen lines.
5041 2012-03-02 Glenn Morris <rgm@gnu.org>
5043 * buffer.c (buffer-list-update-hook): Doc fix.
5045 2012-02-29 Eli Zaretskii <eliz@gnu.org>
5047 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5048 push_it before setting up the iterator for the first overlay
5049 string, even if we have an empty string loaded.
5050 (next_overlay_string): If there's an empty string on the iterator
5051 stack, pop the stack. (Bug#10903)
5053 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5055 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5056 Suggested by Stefan Monnier in
5057 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5058 * alloc.c (widen_to_Lisp_Object): New static function.
5059 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5060 and widening them to Lisp_Objects. This would work even if
5061 USE_LSB_TAG is defined and wide integers are used, which might
5062 happen in a future version of Emacs.
5064 2012-02-25 Chong Yidong <cyd@gnu.org>
5066 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5069 * xselect.c (Fx_selection_exists_p): Doc fix.
5070 (x_clipboard_manager_save_all): Print an informative message
5071 before saving to clipboard manager.
5073 2012-02-24 Chong Yidong <cyd@gnu.org>
5075 * keyboard.c (process_special_events): Handle all X selection
5076 requests in kbd_buffer, not just the next one (Bug#8869).
5078 2012-02-23 Chong Yidong <cyd@gnu.org>
5080 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5081 call when setting menu-bar-lines and tool-bar-lines parameters.
5082 (unwind_create_frame_1): New helper function.
5084 * window.c (inhibit_window_configuration_change_hook): New var.
5085 (run_window_configuration_change_hook): Obey it.
5086 (syms_of_window): Initialize it.
5088 2012-02-22 Chong Yidong <cyd@gnu.org>
5090 * xterm.c (x_draw_image_relief): Add missing type check for
5091 Vtool_bar_button_margin (Bug#10743).
5093 2012-02-21 Chong Yidong <cyd@gnu.org>
5095 * fileio.c (Vfile_name_handler_alist): Doc fix.
5097 * buffer.c (Fget_file_buffer): Protect against invalid file
5098 handler return value.
5100 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5102 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5103 when computing $valmask.
5105 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5106 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5107 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5108 It's useless in that case, and it can cause problems on hosts
5109 that allocate halves of EMACS_INT values separately.
5110 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5111 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5112 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5113 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5114 it avoids undefined behavior on hosts where shifting right by more
5115 than the word width has undefined behavior.
5117 2012-02-19 Chong Yidong <cyd@gnu.org>
5119 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5120 (Funhandled_file_name_directory, Ffile_name_as_directory)
5121 (Fdirectory_file_name, Fexpand_file_name)
5122 (Fsubstitute_in_file_name): Protect against invalid file handler
5123 return values (Bug#10845).
5125 2012-02-18 Eli Zaretskii <eliz@gnu.org>
5127 * .gdbinit (pitx): Fix incorrect references to fields of the
5130 2012-02-17 Chong Yidong <cyd@gnu.org>
5132 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5134 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5136 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5137 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5139 2012-02-15 Chong Yidong <cyd@gnu.org>
5141 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5142 marked as special. Also, starting docstrings with * is obsolete.
5144 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5146 * gnutls.c (emacs_gnutls_write): Fix last change.
5148 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5150 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5153 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5155 * keymap.c (Fsingle_key_description): Handle char ranges.
5157 2012-02-12 Chong Yidong <cyd@gnu.org>
5159 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5160 as that creates a dangerous corner case.
5162 * window.c (Fdelete_window_internal): Invalidate the mouse
5163 highlight (Bug#9904).
5165 2012-02-12 Glenn Morris <rgm@gnu.org>
5167 * xselect.c (Fx_own_selection_internal)
5168 (Fx_get_selection_internal, Fx_disown_selection_internal)
5169 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5170 * nsselect.m (Fx_own_selection_internal)
5171 (Fx_disown_selection_internal, Fx_selection_exists_p)
5172 (Fx_selection_owner_p, Fx_get_selection_internal):
5173 Sync docs and argument specs with the xselect.c versions.
5175 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5177 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5179 2012-02-11 Eli Zaretskii <eliz@gnu.org>
5181 * w32select.c (Fx_selection_exists_p): Sync doc string and
5182 argument list with xselect.c. (Bug#10783)
5184 * w16select.c (Fx_selection_exists_p): Sync doc string and
5185 argument list with xselect.c. (Bug#10783)
5187 2012-02-10 Glenn Morris <rgm@gnu.org>
5189 * fns.c (Fsecure_hash): Doc fix.
5191 2012-02-09 Kenichi Handa <handa@m17n.org>
5193 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5195 2012-02-07 Chong Yidong <cyd@gnu.org>
5197 * buffer.c (Fbuffer_local_variables)
5198 (buffer_lisp_local_variables): Handle unbound vars correctly;
5199 don't let Qunbound leak into Lisp.
5201 2012-02-07 Glenn Morris <rgm@gnu.org>
5203 * image.c (Fimagemagick_types): Doc fix.
5205 * image.c (imagemagick-render-type): Change it from a lisp object
5206 to an integer. Move the doc here from the lisp manual.
5207 Treat all values not equal to 0 the same.
5209 2012-02-06 Chong Yidong <cyd@gnu.org>
5211 * doc.c (store_function_docstring): Avoid applying docstring of
5212 alias to base function (Bug#2603).
5214 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5216 * .gdbinit (pp1, pv1): Remove redundant defines.
5219 2012-02-04 Chong Yidong <cyd@gnu.org>
5221 * nsterm.m: Declare a global (Bug#10694).
5223 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5225 * w32.c (get_emacs_configuration_options):
5226 Include --enable-checking, if specified, in the return value.
5228 2012-02-04 Martin Rudalics <rudalics@gmx.at>
5230 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5231 after rounding frame sizes. (Bug#9723)
5233 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5235 * keyboard.c (adjust_point_for_property): Don't position point
5236 before BEGV. (Bug#10696)
5238 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5240 Handle overflow when computing char display width (Bug#9496).
5241 * character.c (char_width): Return EMACS_INT, not int.
5242 (char_width, c_string_width): Check for overflow when
5243 computing the width; this is possible now that individual
5244 characters can have unbounded width. Problem introduced
5245 by merge from Emacs 23 on 2012-01-19.
5247 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
5249 * dbusbind.c (Fdbus_register_method): Mention the return value
5250 :ignore in the docstring.
5252 2012-02-02 Glenn Morris <rgm@gnu.org>
5254 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5256 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5257 Unconditionally set to t. (Bug#10673)
5258 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5259 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5260 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5262 2012-02-02 Kenichi Handa <handa@m17n.org>
5264 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5265 0, do not call append_composite_glyph.
5267 2012-02-02 Kenichi Handa <handa@m17n.org>
5269 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5271 (x_produce_glyphs): If the component of a composition is a null
5272 string, set it->pixel_width to 1 to avoid zero-width glyph.
5274 2012-02-01 Eli Zaretskii <eliz@gnu.org>
5276 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5277 first 2 arguments are identical. This makes inserting large
5278 output from a subprocess an order of magnitude faster on
5279 MS-Windows, where all sbrk'ed memory is always contiguous.
5281 2012-01-31 Glenn Morris <rgm@gnu.org>
5283 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5284 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5285 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5287 2012-01-29 Glenn Morris <rgm@gnu.org>
5289 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5291 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5293 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5295 2012-01-28 Chong Yidong <cyd@gnu.org>
5297 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5299 2012-01-26 Chong Yidong <cyd@gnu.org>
5301 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5303 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5304 repeat counts (Bug#10507).
5306 2012-01-26 Glenn Morris <rgm@gnu.org>
5308 * lread.c (syms_of_lread): Doc fix.
5310 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5312 * coding.c (encode_designation_at_bol): Change return value to
5315 2012-01-25 Chong Yidong <cyd@gnu.org>
5317 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5319 2012-01-21 Chong Yidong <cyd@gnu.org>
5321 * floatfns.c (Fcopysign): Make the second argument non-optional,
5322 since nil is not allowed anyway.
5324 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5326 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5327 (send_process): Likewise.
5329 2012-01-19 Martin Rudalics <rudalics@gmx.at>
5331 * window.c (save_window_save, Fcurrent_window_configuration)
5332 (Vwindow_persistent_parameters): Do not use Qstate.
5333 Rewrite doc-strings.
5335 2012-01-19 Kenichi Handa <handa@m17n.org>
5337 * character.c (char_width): New function.
5338 (Fchar_width, c_string_width, lisp_string_width):
5339 Use char_width (Bug#9496).
5341 2012-01-16 Martin Rudalics <rudalics@gmx.at>
5343 * window.c (Vwindow_persistent_parameters): New variable.
5344 (Fset_window_configuration, save_window_save): Handle persistent
5347 2012-01-14 Eli Zaretskii <eliz@gnu.org>
5349 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5350 thrashing the stack of the thread. (Bug#9087)
5352 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5354 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5356 2012-01-11 Eli Zaretskii <eliz@gnu.org>
5358 * xdisp.c (rows_from_pos_range): Handle the case where the
5359 highlight ends on a newline. (Bug#10464)
5360 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5361 he end column for display of highlight that ends on a newline
5364 2012-01-11 Glenn Morris <rgm@gnu.org>
5366 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5367 from load-path also when installation-directory is nil. (Bug#10208)
5369 2012-01-10 Glenn Morris <rgm@gnu.org>
5371 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5373 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5374 Update template values to be closer to their typical values these days.
5376 2012-01-09 Eli Zaretskii <eliz@gnu.org>
5378 * xdisp.c (rows_from_pos_range): Accept additional argument
5379 DISP_STRING, and accept any glyph in a row whose object is that
5380 string as eligible for mouse highlight. Fixes mouse highlight of
5381 display strings from overlays. (Bug#10464)
5383 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
5385 emacs: fix an auto-save permissions race condition (Bug#10400)
5386 * fileio.c (auto_saving_dir_umask): New static var.
5387 (Fmake_directory_internal): Use it.
5388 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5389 creating the directory. The old code temporarily assigns
5390 too-generous permissions to the directory.
5391 (do_auto_save_eh): Clear it.
5392 (Fdo_auto_save): Catch all errors, not just file errors, so
5393 that the var is always cleared.
5395 2012-01-07 Eli Zaretskii <eliz@gnu.org>
5397 * search.c (scan_buffer): Pass character positions to
5398 know_region_cache, not byte positions. (Bug#6540)
5400 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
5402 * w32.c (sys_rename): Report EXDEV when rename of a directory
5403 fails because the target is on another logical disk. (Bug#10284)
5405 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5407 * xterm.c (x_embed_request_focus): New function.
5409 * xterm.h: Add prototype.
5411 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5413 2012-01-05 Glenn Morris <rgm@gnu.org>
5415 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5417 2012-01-01 Eli Zaretskii <eliz@gnu.org>
5419 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5420 Load gnutls_transport_set_lowat only if GnuTLS version is below
5422 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5423 GnuTLS versions below 2.11.1.
5425 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5427 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5428 to the doc string advising against its use for altering the way
5429 windows are scrolled.
5431 2011-12-28 Kenichi Handa <handa@m17n.org>
5433 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5434 coding-system ASCII compatible only when it does not produce BOM
5435 on encoding (Bug#10383).
5437 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5439 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5441 (create_and_show_popup_menu): Always use menu_position_func for
5444 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5446 * callint.c (Fcall_interactively): Don't truncate prompt string.
5448 2011-12-23 Eli Zaretskii <eliz@gnu.org>
5450 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5451 property that ends at ZV, so that the bidi iteration could be
5452 resumed from there (after widening). (Bug#10360)
5454 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5456 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5458 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5460 * nsterm.m (x_free_frame_resources):
5461 Release f->output_data.ns->miniimage.
5462 (ns_index_color): Fix indentation. Do not retain
5463 color_table->colors[i].
5465 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5468 * nsfns.m (x_set_background_color): Assign return value from
5469 ns_index_color to face-background instead of NSColor*.
5470 (ns_implicitly_set_icon_type): Fix indentation.
5471 Change assignment in for loop to comparison.
5473 * emacs.c (ns_pool): New variable.
5474 (main): Assign ns_pool.
5475 (Fkill_emacs): Call ns_release_autorelease_pool.
5477 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5478 autorelease fdesc, release fdAttrs and tdict.
5479 (ns_get_covering_families): Release charset.
5480 (ns_findfonts): Release NSFontDescriptor created with new.
5481 (ns_uni_to_glyphs): Fix indentation.
5482 (setString): Release attrStr before assigning new value.
5484 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5486 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5488 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5489 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5491 2011-12-18 David Reitter <reitter@cmu.edu>
5493 * nsterm.m (ns_term_init): Subscribe for notifications
5494 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5495 to method trackingNotification in EmacsMenu.
5497 * nsmenu.m (trackingMenu): New variable.
5498 (trackingNotification): New method (from Aquamacs).
5499 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
5500 from Aquamacs (Bug#7030).
5502 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5504 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5505 (symbol_to_nsstring): Fix indentation.
5506 (ns_symbol_to_pb): New function.
5507 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5508 (Fns_rotate_cut_buffers_internal): Remove.
5509 (Fns_store_selection_internal): Rename from
5510 Fns_store_cut_buffer_internal.
5511 (ns_get_foreign_selection, Fx_own_selection_internal)
5512 (Fx_disown_selection_internal, Fx_selection_exists_p)
5513 (Fns_get_selection_internal, Fns_store_selection_internal):
5514 Use ns_symbol_to_pb and check if return value is nil.
5515 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5516 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
5517 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5518 renamed to Sns_store_selection_internal.
5519 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5520 and remove this function.
5521 (ns_handle_selection_clear): Remove, never used.
5522 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5525 2011-12-17 Ken Brown <kbrown@cornell.edu>
5527 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5528 GID is unknown (Bug#10257).
5530 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5532 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5533 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5534 which caused a build failure on GNU/Linux IA-64. This problem was
5535 introduced by my 2011-10-07 patch.
5537 2011-12-15 Juri Linkov <juri@jurta.org>
5539 * image.c (imagemagick_error): New function. (Bug#10112)
5540 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5541 Use `imagemagick_error' where ImageMagick functions return
5543 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5546 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5548 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5549 fill background (Bug#8992).
5551 2011-12-13 Martin Rudalics <rudalics@gmx.at>
5553 * window.c (Vwindow_combination_resize)
5554 (Vwindow_combination_limit): Use t instead of non-nil in
5556 (Vrecenter_redisplay): Add first sentence of doc-string on
5558 (Frecenter): Fix doc-string typo.
5560 2011-12-11 Kenichi Handa <handa@m17n.org>
5562 * coding.c (Funencodable_char_position): Pay attention to the
5563 buffer text relocation (Bug#9389).
5565 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5567 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5568 gtk_init (Bug#10100).
5570 2011-12-10 Eli Zaretskii <eliz@gnu.org>
5572 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5573 IT->string is nil. (Bug#10263)
5575 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5577 * nsterm.h (x_free_frame_resources): Declare.
5579 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5580 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5582 * nsterm.h (ns_get_defaults_value): Declare.
5584 * nsterm.m (ns_default): Call ns_get_defaults_value.
5586 2011-12-09 Eli Zaretskii <eliz@gnu.org>
5588 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5591 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5593 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5594 that where the value of an _OBJC_* symbol points to is in the .bss
5595 section (Bug#10240).
5597 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5599 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
5600 after the loop to call ccl_driver at least once (Bug#8619).
5602 2011-12-08 Kenichi Handa <handa@m17n.org>
5604 * ftfont.c (get_adstyle_property): Fix previous change
5607 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
5609 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5610 dirs from the default value of EMACSLOADPATH (bug#10208).
5612 2011-12-07 Glenn Morris <rgm@gnu.org>
5614 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5615 installation and source directories as well. (Bug#10208)
5617 2011-12-06 Chong Yidong <cyd@gnu.org>
5619 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5621 2011-12-06 Glenn Morris <rgm@gnu.org>
5623 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5624 as an error, not just -1. (Bug#10217)
5626 2011-12-05 Chong Yidong <cyd@gnu.org>
5628 * keyboard.c (process_special_events): New function.
5629 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5631 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5633 * coding.c (encode_designation_at_bol): Don't use uninitialized
5634 local variable (Bug#9318).
5636 2011-12-05 Kenichi Handa <handa@m17n.org>
5638 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5639 return Qnil (Bug#8046, Bug#10193).
5641 2011-12-05 Kenichi Handa <handa@m17n.org>
5643 * coding.c (encode_designation_at_bol): New args charbuf_end and
5644 dst. Return the number of produced bytes. Callers changed.
5645 (coding_set_source): Return how many bytes coding->source was
5647 (coding_set_destination): Return how many bytes
5648 coding->destination was relocated.
5649 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
5650 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5652 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5654 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5655 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5658 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5660 The following changes are to fix Bug#9318.
5662 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5663 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5664 (encode_coding_iso_2022, encode_coding_sjis)
5665 (encode_coding_big5, encode_coding_charset): Use the above macros.
5667 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
5669 * lisp.h (process_quit_flag): Fix external declaration.
5671 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5673 Don't macro-inline non-performance-critical code.
5674 * eval.c (process_quit_flag): New function.
5675 * lisp.h (QUIT): Use it.
5677 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5679 * nsfns.m (get_geometry_from_preferences): New function.
5680 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5682 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5684 * emacs.c (Qkill_emacs): Define.
5685 (syms_of_emacs): Initialize it.
5686 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5687 Qquit_flag to `kill-emacs' instead.
5688 (quit_throw_to_read_char): Add parameter `from_signal'.
5689 All callers changed. Call Fkill_emacs if requested and safe.
5690 * lisp.h (QUIT): Call Fkill_emacs if requested.
5692 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5694 * widget.c (update_wm_hints): Return if wmshell is null.
5695 (widget_update_wm_size_hints): New function.
5697 * widget.h (widget_update_wm_size_hints): Declare.
5699 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5700 widget_update_wm_size_hints (Bug#10104).
5702 2011-12-03 Eli Zaretskii <eliz@gnu.org>
5704 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5705 before a newline, prepare the bidi iterator for consuming the
5706 newline, and keep the current paragraph direction. (Bug#10183)
5707 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
5709 2011-12-02 Juri Linkov <juri@jurta.org>
5711 * search.c (Fword_search_regexp): New Lisp function created from
5712 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5713 (Fword_search_backward, Fword_search_forward)
5714 (Fword_search_backward_lax, Fword_search_forward_lax):
5715 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5716 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5718 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5720 * fileio.c (Finsert_file_contents): Move after-change-function call
5721 to before the "handled:" label, since all "goto handled" appear in
5722 cases where the *-change-functions have already been properly called
5725 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5727 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5728 waiting for input. (Bug#10169)
5730 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5732 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5733 verifies glyph row's hash code--we have just reallocated the
5734 glyphs, so their contents can be complete garbage. (Bug#10164)
5736 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
5738 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5740 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5742 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5743 attributes are tested _before_ calling verify_row_hash, to protect
5744 against GCC re-ordering of the tests. (Bug#10164)
5746 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5748 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5750 * xterm.c (handle_one_xevent): Only set async_visible and friends
5751 if net_wm_state_hidden_seen is non-zero (Bug#10002)
5752 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
5753 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5755 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5757 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5758 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5759 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5760 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5761 All uses changed to use GCPRO1 etc.
5762 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5763 Revert to old implementation (i.e., before 2011-03-11).
5765 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5767 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5768 of scroll runs so as to avoid assigning disabled bogus rows and
5769 unnecessary graphics copy operations.
5771 2011-11-27 Eli Zaretskii <eliz@gnu.org>
5773 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5774 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5775 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5776 (malloc, free, realloc, calloc): Redirect to e_* only when
5779 * lisp.h (GCTYPEBITS): Move before first use.
5780 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5781 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5782 this macro definition.
5784 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5787 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5789 * gtkutil.c (xg_create_frame_widgets):
5790 Call gtk_window_set_has_resize_grip (FALSE) if that function is
5791 present with Gtk+ 2.0.
5793 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5795 * fileio.c (Finsert_file_contents): Undo previous change; see
5796 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5798 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5800 Rename locals to avoid shadowing.
5801 * fileio.c (Finsert_file_contents):
5802 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5803 * process.c (wait_reading_process_output):
5804 Rename inner 'proc' to 'p' to avoid shadowing.
5805 Indent for consistency with usual Emacs style.
5807 2011-11-25 Eli Zaretskii <eliz@gnu.org>
5809 * xdisp.c (redisplay_window): If cursor row is not fully visible
5810 after recentering, and scroll-conservatively is set to a large
5811 number, scroll window by a few more lines to make the cursor fully
5812 visible and out of scroll-margin. (Bug#10105)
5813 (start_display): Don't move to the next line if the display should
5814 start at a newline that is part of a display vector or an overlay
5817 2011-11-24 Juri Linkov <juri@jurta.org>
5819 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5820 after the `MagickPingImage' call. (Bug#10112)
5822 2011-11-23 Chong Yidong <cyd@gnu.org>
5824 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5826 2011-11-23 Martin Rudalics <rudalics@gmx.at>
5828 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5829 making another buffer current. (Bug#10114)
5831 2011-11-23 Glenn Morris <rgm@gnu.org>
5833 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5835 2011-11-23 Chong Yidong <cyd@gnu.org>
5837 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5838 using it (Bug#5984).
5840 2011-11-22 Eli Zaretskii <eliz@gnu.org>
5842 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5843 and header-lines, as they don't have one computed for them.
5846 * .gdbinit (prow): Make displayed values more self-explaining.
5847 Add row's hash code.
5849 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5851 * process.c (wait_reading_process_output): Fix asynchrounous
5852 GnuTLS socket handling on some versions of the GnuTLS library.
5853 (wait_reading_process_output): Add comment and URL.
5855 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5857 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5859 2011-11-21 Chong Yidong <cyd@gnu.org>
5861 * window.c (Fnext_window, Fprevious_window): Doc fix.
5863 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5865 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5867 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5869 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5871 2011-11-20 Martin Rudalics <rudalics@gmx.at>
5873 * window.c (Fset_window_combination_limit): Rename argument
5875 (Vwindow_combination_limit): Remove "status" from doc-string.
5877 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5879 * m/ibms390.h: Remove.
5880 * m/ibms390x.h: Don't include "ibms390.h".
5882 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5884 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5885 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5887 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5889 * casetab.c (Fset_case_table):
5890 * charset.c (Fcharset_after): Fix typos.
5892 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
5894 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5895 Otherwise, valgrind does not work on some platforms.
5896 Problem reported by Andreas Schwab in
5897 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5898 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5899 is set, removing the need for VIRT_ADDRESS_VARIES.
5900 (PURE_P): Use a more-efficient implementation that needs just one
5901 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5902 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5903 to 4 (xorl, subq, cmpq, setbe).
5904 * alloc.c (pure): Always extern now, since that's the
5905 VIRT_ADDR_VARIES behavior.
5906 (PURE_POINTER_P): Use a single comparison, not two, for
5907 consistency with the new puresize.h.
5908 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5909 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5910 Remove VIRT_ADDR_VARIES no longer needed.
5912 2011-11-19 Eli Zaretskii <eliz@gnu.org>
5914 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5915 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5916 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5917 behave as if the cursor position were at the window margin.
5919 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5920 and the cursor position is out of bounds, behave as if the cursor
5921 position were at the window margin. (Bug#10075)
5923 2011-11-18 Chong Yidong <cyd@gnu.org>
5925 * window.c (Fwindow_combination_limit): Make first argument
5926 non-optional, since it is meaningless for live windows like the
5929 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5931 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5933 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5935 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5936 (graft_intervals_into_buffer): Simplify.
5938 2011-11-18 Eli Zaretskii <eliz@gnu.org>
5940 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5941 hash values of the two rows.
5942 (copy_row_except_pointers): Preserve the used[] arrays and the
5943 hash values of the two rows. (Bug#10035)
5944 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
5946 * xdisp.c (row_hash): New function, body extracted from
5947 compute_line_metrics.
5948 (compute_line_metrics): Call row_hash, instead of computing the
5951 * dispnew.c (verify_row_hash): Call row_hash for computing the
5952 hash code of a row, instead of duplicating code from xdisp.c.
5954 * dispextern.h (row_hash): Add prototype.
5956 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5958 * frame.c (delete_frame): Don't delete the terminal when the last
5959 X frame is closed if emacs is built with GTK toolkit.
5961 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
5963 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5965 2011-11-17 Martin Rudalics <rudalics@gmx.at>
5967 * window.c (Vwindow_splits): Rename to
5968 Vwindow_combination_resize. Suggested by Juri Linkov.
5969 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5972 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
5974 * nsfns.m (Fns_font_name):
5975 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
5977 2011-11-16 Martin Rudalics <rudalics@gmx.at>
5979 * window.h (window): Rename slot "nest" to "combination_limit".
5980 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5981 (Fset_window_nest): Rename to Fset_window_combination_limit.
5982 (Vwindow_nest): Rename to Vwindow_combination_limit.
5983 (recombine_windows, make_parent_window, make_window)
5984 (Fsplit_window_internal, saved_window)
5985 (Fset_window_configuration, save_window_save): Rename all
5986 occurrences of window_nest to window_combination_limit.
5988 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
5990 * image.c (imagemagick_load_image): Fix typo.
5992 2011-11-14 Eli Zaretskii <eliz@gnu.org>
5994 * xdisp.c (display_line): Move the call to
5995 highlight_trailing_whitespace before the call to
5996 compute_line_metrics, since the latter needs to see the final
5997 faces of all the glyphs to compute ROW's hash value.
5998 Fixes assertion violations in row_equal_p. (Bug#10035)
6000 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
6002 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6003 just return (bug#10044).
6005 2011-11-12 Eli Zaretskii <eliz@gnu.org>
6007 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6008 with user-defined heap size. Bump the default size of the temacs
6009 heap to 27MB, to avoid memory warning when running temacs.
6010 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6012 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6013 current_matrix and desired_matrix. (Bug#9990)
6014 (verify_row_hash) [XASSERTS]: New function.
6015 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6016 that the hash value of glyph rows is correct.
6018 2011-11-12 Martin Rudalics <rudalics@gmx.at>
6020 * window.h (window): Remove splits slot.
6021 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6022 (Fdelete_other_windows_internal, make_parent_window)
6023 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6024 (Fset_window_configuration, save_window_save): Don't deal with
6025 split status of windows.
6026 (saved_window): Remove splits slot.
6027 (Vwindow_splits): Rewrite doc-string.
6029 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6031 * xfns.c (unwind_create_frame):
6032 * nsfns.m (unwind_create_frame):
6033 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6034 Vframe_list (Bug#9999).
6036 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6038 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
6040 2011-11-11 Kenichi Handa <handa@m17n.org>
6042 * callproc.c (Fcall_process): Set the member dst_multibyte of
6045 2011-11-11 Johan Bockgård <bojohan@gnu.org>
6047 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6048 avoid a crash (bug#9496).
6050 2011-11-09 Chong Yidong <cyd@gnu.org>
6052 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6053 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6055 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6057 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6059 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6061 Avoid some portability problems by eschewing 'extern inline' functions.
6062 The trivial performance wins aren't worth the portability hassles; see
6063 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6065 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6066 (window_box_width, window_box_left, window_box_left_offset)
6067 (window_box_right, window_box_right_offset): Undo previous change,
6068 by removing the "extern"s.
6069 * intervals.c (adjust_intervals_for_insertion)
6070 (adjust_intervals_for_deletion): Undo previous change,
6071 making these static again.
6072 (offset_intervals, temp_set_point_both, temp_set_point)
6073 (copy_intervals_to_string): No longer inline.
6074 * xdisp.c (window_text_bottom_y, window_box_width)
6075 (window_box_height, window_box_left_offset)
6076 (window_box_right_offset, window_box_left, window_box_right)
6077 (window_box): No longer inline.
6079 2011-11-08 Chong Yidong <cyd@gnu.org>
6081 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6082 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6083 Signal an error if not a live window.
6084 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6085 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6087 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
6089 * lisp.h (syms_of_abbrev): Remove declaration.
6090 Reported by CHENG Gao <chenggao@royau.me>.
6092 2011-11-07 Eli Zaretskii <eliz@gnu.org>
6094 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6095 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6096 of temacs in GUI mode.
6098 2011-11-07 Martin Rudalics <rudalics@gmx.at>
6100 * window.h: Declare delete_all_child_windows instead of
6101 delete_all_subwindows.
6102 * window.c (Fwindow_nest, Fset_window_nest)
6103 (Fset_window_new_total, Fset_window_new_normal)
6104 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6105 (delete_all_subwindows): Rename to delete_all_child_windows.
6106 (Fdelete_other_windows_internal, Fset_window_configuration):
6107 Call delete_all_child_windows instead of delete_all_subwindows.
6108 * frame.c (delete_frame): Call delete_all_child_windows instead
6109 of delete_all_subwindows.
6111 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6113 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6114 This is also needed for porting to any host where GC_MARK_STACK is
6115 not GC_MAKE_GCPROS_NOOPS.
6116 (which_symbols): Use it.
6118 2011-11-07 Kenichi Handa <handa@m17n.org>
6120 * coding.c (coding_set_destination): Check coding->src_pos only
6121 when coding->src_object is a buffer (bug#9910).
6123 * process.c (send_process): Set the member src_multibyte of coding
6124 to 0 (bug#9911) when sending a unibyte text.
6126 * callproc.c (Fcall_process): Set the member src_multibyte of
6127 process_coding to 0 (bug#9912).
6129 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6131 * xmenu.c (cleanup_widget_value_tree): New function.
6132 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6133 calling free_menubar_widget_value_tree directly (Bug#9830).
6135 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6137 Fix some portability problems with 'inline'.
6138 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6139 (window_box_width, window_box_left, window_box_left_offset)
6140 (window_box_right, window_box_right_offset): Declare extern.
6141 Otherwise, these inline functions do not conform to C99 and
6142 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6143 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6144 * intervals.c (adjust_intervals_for_insertion)
6145 (adjust_intervals_for_deletion): Now extern, because otherwise the
6146 extern inline functions 'offset_intervals' couldn't refer to it.
6147 (static_offset_intervals): Remove.
6148 (offset_intervals): Rewrite using the old contents of
6149 static_offset_intervals. The old version didn't conform to C99
6150 because an extern inline function contained a reference to an
6151 identifier with static linkage.
6153 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6155 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6158 2011-11-06 Eli Zaretskii <eliz@gnu.org>
6160 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6161 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6162 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6163 return Qleft_to_right.
6165 2011-11-06 Chong Yidong <cyd@gnu.org>
6167 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6168 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6169 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6170 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6171 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6172 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6173 (Fwindow_vscroll): Doc fix.
6174 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6175 argument, since it makes no sense to pass a live window and for
6176 consistency with window-child.
6178 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6180 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6183 2011-11-05 Jason Rumney <jasonr@gnu.org>
6185 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6186 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6188 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6189 bitwise arithmetic preventing use of unicode-sip and non-truetype
6192 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6194 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6197 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6198 initialization code to keep similarity to xfns.c after changes
6201 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6203 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6204 (unwind_create_frame): New function (Bug#9943).
6205 (Fx_create_frame): Restructure code to be more similar to the one in
6206 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6207 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6208 Move terminal->reference_count++ just before making the frame official
6211 * nsterm.m (x_free_frame_resources): New function.
6212 (x_destroy_window): Move code to x_free_frame_resources.
6214 * xfns.c (unwind_create_frame): Fix comment.
6215 (Fx_create_frame, x_create_tip_frame):
6216 Move terminal->reference_count++ just before making the frame
6217 official. Move initialization of image_cache_refcount and
6218 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6220 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6222 Support MSVC build with newer versions of Visual Studio.
6223 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6224 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6227 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6228 which are not supported by MSVC.
6229 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6230 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6232 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6234 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6236 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6238 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
6240 Support MSVC build with newer versions of Visual Studio.
6241 * w32.c: Don't include w32api.h for MSVC.
6242 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6244 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6245 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6246 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6247 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6249 (alloca) [_MSC_VER]: Define to _alloca.
6251 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6253 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6255 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6257 * xdisp.c (note_mouse_highlight): If either of
6258 previous/next-single-property-change returns nil, treat that as
6259 the beginning or the end of the buffer. (Bug#9955)
6261 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6263 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
6264 label is not null (Bug#9951).
6265 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6268 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6270 * window.c (Fwindow_body_size): Mention in the doc string that the
6271 return value is in frame's canonical units. (Bug#9949)
6273 2011-11-03 Eli Zaretskii <eliz@gnu.org>
6275 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6277 * w32fns.c (unwind_create_frame): If needed, free the glyph
6278 matrices of the partially constructed frame. (Bug#9943)
6279 * xfns.c (unwind_create_frame): Likewise.
6281 2011-11-01 Eli Zaretskii <eliz@gnu.org>
6283 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6284 Don't stop backward scan on the continuation glyph, even though
6285 its CHARPOS is positive.
6286 (mouse_face_from_buffer_pos, note_mouse_highlight):
6287 Rename cover_string to disp_string.
6289 2011-11-01 Martin Rudalics <rudalics@gmx.at>
6291 * window.c (temp_output_buffer_show): Don't use
6292 Vtemp_buffer_show_specifiers.
6293 (Vtemp_buffer_show_specifiers): Remove unused variable.
6295 2011-10-30 Eli Zaretskii <eliz@gnu.org>
6297 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6298 past the beginning of the current glyph matrix.
6300 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6302 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6303 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6304 HAVE_GTK3 (Bug#9869).
6306 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6307 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6309 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6311 * xterm.c: Declare x_handle_net_wm_state to return int.
6312 (handle_one_xevent): Check if we are iconified but don't have
6313 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6314 (get_current_wm_state): Return non-zero if not hidden,
6315 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6316 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6317 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6318 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6320 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6322 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6323 so that this new function doesn't get optimized away by a
6324 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6326 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6328 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6330 2011-10-29 Eli Zaretskii <eliz@gnu.org>
6332 Fix the `xbytecode' command.
6333 * .gdbinit (xprintbytestr): New command.
6334 (xwhichsymbols): Rename from `which'; all callers changed.
6335 (xbytecode): Print the byte-code string as well.
6337 2011-10-29 Kim Storm <storm@cua.dk>
6339 * alloc.c (which_symbols): New function.
6341 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6343 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6346 2011-10-29 Glenn Morris <rgm@gnu.org>
6348 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6349 Not clear what it was for, and it causes various bugs. (Bug#9839)
6351 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6353 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6354 possible random value that matches one of those tested as
6355 condition to clear the mouse face.
6357 2011-10-28 Chong Yidong <cyd@gnu.org>
6359 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6361 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6363 * window.c (make_window): Initialize phys_cursor_on_p.
6365 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6367 * lisp.h (struct Lisp_Symbol): Update comments.
6369 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
6371 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6373 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6375 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6376 <oslsachem@gmail.com> for helping to debug this.
6378 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6379 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6380 (g_b_init_get_glyph_outline_w): New static variables.
6381 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6382 (GetGlyphOutlineW_Proc): New typedefs.
6383 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
6384 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6386 (w32font_open_internal, compute_metrics):
6387 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
6388 instead of calling the "wide" APIs directly.
6390 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6392 * w32.h (syms_of_w32font): Add prototype.
6394 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6396 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6397 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6398 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6399 (Fmove_to_window_line): Doc fix.
6401 2011-10-27 Chong Yidong <cyd@gnu.org>
6403 * process.c (make_process): Set gnutls_state to NULL.
6405 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6406 non-NULL, regardless of GNUTLS_INITSTAGE.
6407 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6408 an error. Set process slots as soon as we allocate them.
6410 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6412 2011-10-27 Chong Yidong <cyd@gnu.org>
6414 * gnutls.c (emacs_gnutls_deinit): New function.
6415 Deallocate credentials structures as well as calling gnutls_deinit.
6416 (Fgnutls_deinit, Fgnutls_boot): Use it.
6418 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6419 (deactivate_process): Call emacs_gnutls_deinit.
6421 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6423 * image.c (x_create_x_image_and_pixmap):
6424 * w32.c (sys_rename, w32_delayed_load):
6425 * w32font.c (fill_in_logfont):
6426 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6428 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
6430 * w32fns.c (w32_default_color_map): New function,
6431 extracted from Fw32_default_color_map.
6432 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
6434 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6436 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6438 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6440 * keyboard.c (test_undefined): New function (bug#9751).
6441 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6443 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6445 * sysdep.c (init_sys_modes): Fix the check for the controlling
6446 terminal (Bug#6649).
6448 2011-10-20 Eli Zaretskii <eliz@gnu.org>
6450 * dispextern.h (struct bidi_it): New member next_en_type.
6452 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6453 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6454 current character, check also for next_en_type being WEAK_EN.
6455 (bidi_resolve_weak): Don't enter the expensive loop if the current
6456 position is before next_en_pos. Record the bidi type of the first
6457 non-ET, non-BN character we find, in addition to its position.
6458 (bidi_level_of_next_char): Invalidate next_en_type when
6459 next_en_pos is over-stepped.
6461 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6463 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6464 * editfns.c: Rewrite current-time-zone so that it invokes
6465 the equivalent of (format-time-string "%Z") to get the time zone name.
6466 This fixes a bug when the time zone name contains characters that
6467 need converting from the system time locale to Emacs internal format.
6468 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6469 that patch fixed format-time-string to do the conversion, but
6470 I forgot to fix current-time-zone.
6471 (format_time_string): New function, containing most of
6472 what Fformat_time_string used to contain.
6473 (Fformat_time_string): Rewrite in terms of format_time_string.
6474 This doesn't change this function's behavior.
6475 (current-time-zone): Rewrite to use format_time_string.
6476 This fixes the bug reported by Michael Schierl in
6477 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6478 Jason Rumney's 2007-06-07 change worked around this bug, but
6480 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6482 2011-10-19 Eli Zaretskii <eliz@gnu.org>
6484 * xdisp.c (start_display): If the character at POS is displayed
6485 via a display vector, reset IT->current.dpvec_index to zero.
6486 (try_window_reusing_current_matrix): If a line ends in a display
6487 vector or the next line starts in a display vector, continue
6488 redrawing the window even though the character position of
6489 start_row was reached.
6492 2011-10-18 Chong Yidong <cyd@gnu.org>
6494 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6495 with nobreak-char-display too.
6497 2011-10-18 Eli Zaretskii <eliz@gnu.org>
6499 Fix part 3 of bug#9771.
6500 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6501 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6502 non-neutral characters if the current character is a paragraph
6503 separator (a.k.a. Newline). This avoids running the same
6504 expensive loop twice, once when we consume the preceding newline
6505 and the other time when the line actually needs to be displayed.
6506 Avoid the loop when we see neutrals on the base embedding level
6507 following a character whose directionality is the same as the
6508 paragraph's. This avoids running the expensive loop when a line
6509 ends in a long sequence of neutrals, like control characters.
6510 Add assertion against STRONG_AL type. Slightly rearrange code
6511 that determines the type of a neutral given the first non-neutral
6513 (bidi_level_of_next_char): Set next_en_pos to zero when
6514 invalidating its info.
6516 2011-10-17 Eli Zaretskii <eliz@gnu.org>
6518 * xdisp.c (push_display_prop): Determine whether to record string
6519 or buffer position by IT->string, not by IT->method. Allow
6520 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
6521 (move_it_vertically_backward): Don't look for character position
6522 immediately after the newline when in a continuation line.
6525 2011-10-15 Martin Rudalics <rudalics@gmx.at>
6527 * window.c (coordinates_in_window): Rewrite and delabelize
6528 vertical border check. (Bug#5357) (Bug#9618)
6530 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6532 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6533 errors in XSetWindowBorder (bug#9310).
6535 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6537 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6538 avoid crash when xmalloc overrun checking is enabled.
6540 2011-10-13 Eli Zaretskii <eliz@gnu.org>
6542 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6543 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6544 cursor motion with <left> and <right> arrow keys.
6546 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6547 some callers set that themselves.
6549 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6551 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6552 display string and the previous row comes from the same string and
6553 is empty. (Bug#9739) (Bug#9738)
6555 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6557 * doc.c (get_doc_string): Encode file name (bug#9735).
6559 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6561 * bidi.c (bidi_level_of_next_char):
6562 * xdisp.c (get_visually_first_element): Remove old incorrect
6563 comments regarding the Unicode Line Separator character.
6565 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6567 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6569 * alloc.c (Fgc_status): Do not access beyond zombies array
6570 boundary if nzombies > MAX_ZOMBIES.
6571 * alloc.c (dump_zombies): Add missing format specifier.
6573 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6575 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6576 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6578 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6579 Some packages use them to denote characters with modifiers.
6581 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6583 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6584 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6585 matching a pp-number. Rename parameter var to var1.
6587 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6589 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6591 2011-10-08 Glenn Morris <rgm@gnu.org>
6593 * callint.c (Fcall_interactively): Give a more explicit error for the
6594 'c' case with a non-character input. (Bug#8479)
6596 2011-10-08 Eli Zaretskii <eliz@gnu.org>
6598 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6600 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6601 lines that are hscrolled on the left.
6603 * dispnew.c (buffer_posn_from_coords): Account for a possible
6604 presence of header-line. (Bug#4426)
6606 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6608 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6609 Don't advertise functionality which we discourage or doesn't work.
6611 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6613 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6614 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6615 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6616 this makes Emacs dump core during garbage collection on rare
6617 occasions. sizeof is obviously inferior to offsetof here, so
6618 stick with offsetof.
6619 (GC_POINTER_ALIGNMENT): New macro.
6620 (mark_memory): Omit 3rd (offset) arg; caller changed.
6621 Don't assume EMACS_INT alignment is the same as pointer alignment.
6623 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6625 * keyboard.c (read_key_sequence_remapped): New var.
6626 (read_key_sequence): Compute remapping in the right buffer.
6627 (command_loop_1): Use read_key_sequence's remapping directly.
6629 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6631 * dired.c (file_name_completion): Don't expand file name.
6632 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6633 before checking file name handler.
6635 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6636 they've been requested explicitly (bug#9591).
6638 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
6640 * keymap.c (Fsingle_key_description): Use make_specified_string
6641 instead of build_string to build string from push_key_description.
6644 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6646 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6647 This fixes a Y2038 bug on 64-bit hosts.
6648 * buffer.c (reset_buffer):
6649 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6650 (Fclear_buffer_auto_save_failure):
6651 Use 0, not -1, to represent an unset failure time, since time_t
6652 might not be signed.
6654 Remove dependency on glibc malloc internals.
6655 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6656 Move back here from lisp.h, but with their new implementations.
6657 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6658 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6659 * charset.c (charset_table_init): New static var.
6660 (syms_of_charset): Use it instead of xmalloc. This removes a
6661 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6662 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6663 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6664 Move back to alloc.c.
6665 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6666 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6668 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6670 * nsterm.m (windowDidResize): Call x_set_window_size only when
6671 ns_in_resize is true. Otherwise set pixelwidth/height and
6672 call change_frame_size (Bug#9628).
6674 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6676 Port --enable-checking=all to Fedora 14 x86-64.
6677 * charset.c (syms_of_charset): Also account for glibc malloc's
6678 internal overhead when calculating the initial malloc maximum.
6680 Port --enable-checking=all to Fedora 14 x86.
6681 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6683 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6684 (overrun_check_realloc, overrun_check_free):
6685 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6686 That way, xmalloc returns a properly-aligned pointer even if
6687 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6688 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6689 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6690 into account when calculating the initial malloc maximum.
6691 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6692 Move here from alloc.c, so that charset.c can use it too.
6693 Properly align; the old code wasn't right for common 32-bit hosts
6694 when configured with --enable-checking=all.
6695 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6696 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6698 2011-09-29 Eli Zaretskii <eliz@gnu.org>
6700 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
6703 2011-09-28 Eli Zaretskii <eliz@gnu.org>
6705 * xdisp.c (compute_display_string_end): If there's no display
6706 string at CHARPOS, return -1.
6708 * bidi.c (bidi_fetch_char): When compute_display_string_end
6709 returns a negative value, treat the character as a normal
6710 character not covered by a display string. (Bug#9624)
6712 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
6714 * lread.c (Fread_from_string): Fix typo in docstring.
6716 2011-09-27 Eli Zaretskii <eliz@gnu.org>
6718 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6719 newline, reseat the iterator instead of bidi-iterating there one
6720 character at a time. (Bug#9610)
6721 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6722 TO_CHARPOS if the bidi iterator is at base embedding level.
6724 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6726 * lread.c (readevalloop): Use correct code for NBSP.
6727 (read1): Likewise. (Bug#9608)
6729 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
6731 * dbusbind.c (Fdbus_register_signal): When service is not
6732 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6734 2011-09-25 Glenn Morris <rgm@gnu.org>
6736 * buffer.c (truncate-lines): Doc fix.
6738 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
6740 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6741 (Fset_window_next_buffers): Doc fix.
6743 2011-09-24 Glenn Morris <rgm@gnu.org>
6745 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6747 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6749 Fix minor problems found by static checking.
6750 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
6751 * indent.c (Fvertical_motion): Fix == vs = typo.
6753 2011-09-24 Eli Zaretskii <eliz@gnu.org>
6755 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6756 Default value is now t. Doc fix.
6758 * indent.c (Fvertical_motion): Compute and apply the overshoot
6759 logic when moving up, not only when moving down. Fix the
6760 confusing name and values of the it_overshoot_expected variable;
6761 logic changes accordingly. (Bug#9254) (Bug#9549)
6763 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6764 CHARPOS is covered by a display string which includes newlines.
6765 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6766 is covered by a display string with embedded newlines.
6768 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
6770 * dbusbind.c (Fdbus_register_signal): Add match rule to
6771 Vdbus_registered_objects_table. (Bug#9581)
6772 (Fdbus_register_method, Vdbus_registered_objects_table):
6775 2011-09-24 Jim Meyering <meyering@redhat.com>
6777 do not ignore write error for any output size
6778 The previous change was incomplete.
6779 While it makes emacs --batch detect the vast majority of stdout
6780 write failures, errors were still ignored whenever the output size is
6781 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6782 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6783 && echo FAIL: ignored write error
6784 FAIL: ignored write error
6785 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6786 && echo FAIL: ignored write error
6787 FAIL: ignored write error
6788 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6790 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6792 * emacs.c (Fkill_emacs): In noninteractive mode exit
6793 non-successfully if a write error occurred on stdout. (Bug#9574)
6795 2011-09-21 Eli Zaretskii <eliz@gnu.org>
6797 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6800 * dispextern.h (struct it): Update the comment documenting what
6803 2011-09-20 Eli Zaretskii <eliz@gnu.org>
6805 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6806 a display string, extend search for cursor position to end of row.
6807 (find_row_edges): If the row ends in a newline from a display
6808 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6809 Handle the case of a display string with multiple newlines.
6810 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6811 non-empty line. Fixes confusing cursor motion with arrow keys at
6812 the beginning of a line that starts with whitespace.
6814 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6816 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6819 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
6821 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6824 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6826 * xdisp.c (display_line): Record maximum and minimum buffer
6827 positions even if no glyphs were produced (e.g., by a zero-width
6828 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6829 buffer positions that will be removed from the glyph row because
6831 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6832 column is beyond frame width: don't subtract 1 "pixel" when
6833 computing width of the stretch.
6834 (reseat_at_next_visible_line_start): Undo the change made on
6835 2011-09-17 that saved paragraph information and restored it after
6836 the call to `reseat'. (Bug#9545)
6838 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6840 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6841 and turn window cursor on if cleared (Bug#9415).
6843 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
6845 * search.c (boyer_moore): Take unibyte characters from pattern
6846 literally. (Bug#9458)
6848 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6850 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6852 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6854 Fix minor problem found by static checking.
6855 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6856 initialized, to pacify gcc -Wuninitialized.
6858 * fileio.c: Report proper errno when syscall falls.
6859 (Finsert_file_contents): Save and restore errno,
6860 so that report_file_error outputs the correct diagnostic.
6861 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6863 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6865 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6867 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6869 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6870 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6872 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6874 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6875 about the current paragraph and restore it after the call to reseat.
6877 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6878 (bidi_find_paragraph_start): Search back for paragraph beginning
6879 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6880 (bidi_move_to_visually_next): Only trigger paragraph-related
6881 computations when the last character is a newline or at EOB, not
6882 just any NEUTRAL_B. (Bug#9470)
6884 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6885 truncated lines if point is covered by a display string. (Bug#9524)
6887 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6889 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6890 (cons_to_x_long): New function.
6891 (lisp_data_to_selection_data): Use it. Correct the test for
6892 short-versus-long data; it was negated. Break out of vector
6893 loop, for efficiency, when a long datum is discovered.
6895 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6897 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6899 2011-09-16 Eli Zaretskii <eliz@gnu.org>
6901 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6902 GCC PR/17406) by declaring this function with external scope.
6904 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6906 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6907 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6909 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6911 * editfns.c (Fformat): Correctly handle text properties on "%%".
6913 2011-09-15 Eli Zaretskii <eliz@gnu.org>
6915 * xterm.c (x_draw_composite_glyph_string_foreground):
6916 * w32term.c (x_draw_composite_glyph_string_foreground):
6917 * term.c (encode_terminal_code):
6918 * composite.c (composition_update_it, get_composition_id):
6919 * xdisp.c (get_next_display_element)
6920 (fill_composite_glyph_string): Add comments about special meaning
6921 of TAB characters in a composition.
6923 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6925 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
6926 This occurs when processing a multibyte format.
6927 Problem reported by Wolfgang Jenker.
6929 2011-09-15 Johan Bockgård <bojohan@gnu.org>
6931 * xdisp.c (try_cursor_movement): Only check for exact match if
6932 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6934 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6936 Remove unused external symbols.
6937 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6938 * xdisp.c (calc_pixel_width_or_height): Now static.
6939 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6940 * indent.c (check_display_width):
6941 * w32term.c: Fix comment to match code.
6942 * xterm.c, xterm.h (x_catching_errors): Remove.
6944 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6946 * xselect.c: Use signed conversions more consistently (Bug#9498).
6947 (selection_data_to_lisp_data): Assume incoming selection data are
6948 signed integers, not unsigned. This is to be consistent with
6949 outgoing selection data, which was modified to use signed integers
6950 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6951 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6952 expects long, not unsigned long.
6954 2011-09-14 Eli Zaretskii <eliz@gnu.org>
6956 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6957 computation of loop end. Reported by Johan Bockgård
6960 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
6962 * frame.c (Fother_visible_frames_p): Function deleted.
6964 2011-09-12 Eli Zaretskii <eliz@gnu.org>
6966 * indent.c (compute_motion): Process display vector front to back
6967 rather than the other way around. (Bug#2496)
6969 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6971 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6973 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
6975 * minibuf.c (Fread_from_minibuffer): Doc fix.
6977 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6979 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6980 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6982 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6984 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6985 value for non-existent files.
6987 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6989 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6990 set its "size" to -1. This will set the modtime_size field of
6991 the corresponding buffer to -1, which is what
6992 verify-visited-file-modtime expects for files that do not exist.
6995 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6997 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6999 * lisp.h: ... from here. push_key_description is no longer
7000 defined in keyboard.c, so its declaration should not be in
7001 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7002 logically belongs with push_key_description.
7004 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7006 * buffer.h: Include <sys/types.h> instead of <time.h>.
7007 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7008 Problem reported by Herbert J. Skuhra.
7010 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7012 * xml.c (parse_region): Make the parsing work for
7013 non-comment-starting XML files again (bug#9144).
7015 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7017 * image.c (gif_load): Fix calculation of bottom and right corner.
7020 2011-09-10 Eli Zaretskii <eliz@gnu.org>
7022 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7023 redisplay in small windows.
7025 2011-09-09 Eli Zaretskii <eliz@gnu.org>
7027 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7029 2011-09-08 Martin Rudalics <rudalics@gmx.at>
7031 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7032 Operate on live windows only.
7034 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
7036 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7038 2011-09-07 Eli Zaretskii <eliz@gnu.org>
7040 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7041 only under bidi iteration.
7043 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7045 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7047 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7049 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7050 Without this fix, the command to link temacs failed due to an
7051 undefined symbol __builtin_isnan. This is because
7052 /usr/include/iso/math_c99.h #defines isnan(x) to
7053 __builtin_isnan(x), but the bundled gcc, which identifies itself
7054 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7056 * floatfns.c (isnan): #undef, and then #define to a clone of
7058 (Fisnan): Always define, since it's always available now.
7059 (syms_of_floatfns): Always define isnan at the Lisp level.
7061 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7063 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7065 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7067 * fileio.c: Fix bugs with large file offsets (Bug#9428).
7068 The previous code assumed that file offsets (off_t values) fit in
7069 EMACS_INT variables, which is not true on typical 32-bit hosts.
7070 The code messed up by falsely reporting buffer overflow in cases
7071 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7072 when "big" contains more than 2**29 bytes, even though this
7073 inserts just one byte and does not overflow the buffer.
7074 (Finsert_file_contents): Store file offsets as off_t
7075 values, not as EMACS_INT values. Check for overflow when
7076 converting between EMACS_INT and off_t. When checking for
7077 buffer overflow or for overlap, take the offsets into account.
7078 Don't use EMACS_INT for small values where int suffices.
7079 When checking for overlap, fix a typo: ZV was used where
7080 ZV_BYTE was intended.
7081 (Fwrite_region): Don't assume off_t fits into 'long'.
7082 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7084 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
7086 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7088 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7090 sprintf-related integer and memory overflow issues (Bug#9412).
7092 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
7093 (esprintf, exprintf, evxprintf): New functions.
7094 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
7095 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
7096 (modify_event_symbol): Do not assume that the length of
7097 name_alist_or_stem is safe to alloca and fits in int.
7098 (Fexecute_extended_command): Likewise for function name and binding.
7099 (Frecursion_depth): Wrap around reliably on integer overflow.
7100 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7101 since some callers pass EMACS_INT values.
7102 (Fsingle_key_description): Don't crash if symbol name contains more
7103 than MAX_ALLOCA bytes.
7104 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7105 (get_minibuffer): Arg is now EMACS_INT, not int.
7106 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
7107 (esprintf, exprintf, evxprintf): New decls.
7108 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7110 * dbusbind.c (signature_cat): New function.
7111 (xd_signature, Fdbus_register_signal):
7112 Do not overrun buffer; instead, report string overflow.
7114 * dispnew.c (add_window_display_history): Don't overrun buffer.
7115 Truncate instead; this is OK since it's just a log.
7117 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7118 even if the time zone offset is outlandishly large.
7119 Don't mishandle offset == INT_MIN.
7121 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7122 when creating daemon; the previous buffer-overflow check was incorrect.
7124 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7125 which has the guts of the old verror function.
7127 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7128 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7130 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7131 (font_unparse_xlfd): Don't blindly alloca long strings.
7132 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
7133 fits in int, when using sprintf. Use single snprintf to count
7134 length of string rather than counting it via multiple sprintfs;
7135 that's simpler and more reliable.
7136 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7137 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7138 sprintf, in case result does not fit in int.
7140 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7141 (fontset_from_font): Print it.
7143 * frame.c (tty_frame_count): Now printmax_t, not int.
7144 (make_terminal_frame, set_term_frame_name): Print it.
7145 (x_report_frame_params): In X, window IDs are unsigned long,
7146 not signed long, so print them as unsigned.
7147 (validate_x_resource_name): Check for implausibly long names,
7148 and don't assume name length fits in 'int'.
7149 (x_get_resource_string): Don't blindly alloca invocation name;
7150 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7153 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7154 (xg_check_special_colors, xg_set_geometry):
7155 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7157 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7158 Use esprintf, not sprintf, in case result does not fit in int.
7160 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7161 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7162 it as a large positive number.
7163 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7164 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7166 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7167 in case result does not fit in int.
7169 * print.c (float_to_string): Detect width overflow more reliably.
7170 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7171 buffer overrun. Don't assume list length fits in 'int'. Treat
7172 print length of 0 as 0, not as infinity; to be consistent with other
7173 uses of print length in this function. Don't overflow print length
7174 index. Don't assume hash table size fits in 'long', or that
7175 vectorlike size fits in 'unsigned long'.
7177 * process.c (make_process): Use printmax_t, not int, to format
7178 process-name gensyms.
7180 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7182 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7183 to avoid potential buffer overrun.
7185 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7186 if X resource line is longer than 512 bytes.
7188 * xfns.c (x_window): Make sprintf buffer a bit bigger
7189 to avoid potential buffer overrun.
7191 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7193 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7195 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7197 Integer overflow fixes for scrolling, etc.
7198 Without these, Emacs silently mishandles large integers sometimes.
7199 For example, "C-u 4294967297 M-x recenter" was treated as if
7200 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7202 * xdisp.c (try_window_id): Check Emacs fixnum range before
7203 converting to 'int'.
7205 * window.c (window_scroll_line_based, Frecenter):
7206 Check that an Emacs fixnum is in range before assigning it to 'int'.
7207 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7208 values converted from Emacs fixnums.
7209 (Frecenter): Don't wrap around a line count if it is out of 'int'
7210 range; instead, treat it as an extreme value.
7211 (Fset_window_configuration, compare_window_configurations):
7212 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7214 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7215 that can exceed INT_MAX. Check that EMACS_INT value is in range
7216 before assigning it to the (possibly-narrower) index.
7217 (match_limit): Don't assume that a fixnum can fit in 'int'.
7219 * print.c (print_object): Use ptrdiff_t, not int, for index that can
7222 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
7223 (Fvertical_motion): Don't wrap around LINES values that don't fit
7224 in 'int'. Instead, treat them as extreme values. This is good
7225 enough for windows, which can't have more than INT_MAX lines anyway.
7227 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7229 * Require libxml/parser.h to avoid compilation warning.
7231 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7233 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7234 since this reportedly can destroy thread storage.
7236 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
7238 * syntax.c (find_defun_start): Update all cache variables if
7239 exiting early (Bug#9401).
7241 2011-08-30 Eli Zaretskii <eliz@gnu.org>
7243 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7245 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7246 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7247 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7249 * term.c (tty_append_glyph): New function.
7250 (produce_stretch_glyph): Static function and its prototype deleted.
7252 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7255 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7257 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7258 when checking :margin (Bug#9390).
7259 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
7260 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
7261 so that the name doesn't mislead. All uses changed.
7263 2011-08-28 Johan Bockgård <bojohan@gnu.org>
7265 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7268 2011-08-27 Eli Zaretskii <eliz@gnu.org>
7270 * xdisp.c (move_it_to): Don't bail out early when reaching
7271 position beyond to_charpos, if we are scanning backwards.
7272 (move_it_vertically_backward): When DY == 0, make sure we get to
7273 the first character in the line after the newline.
7275 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7277 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7278 (ccl_driver): Do not generate an out-of-range pointer.
7279 (Fccl_execute_on_string): Remove unnecessary check for
7280 integer overflow, noted by Stefan Monnier in
7281 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7282 Remove a FIXME that didn't need fixing.
7283 Simplify the newly-introduced buffer reallocation code.
7285 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
7287 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7289 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
7291 Integer and memory overflow issues (Bug#9196).
7293 * doc.c (get_doc_string): Rework so that
7294 get_doc_string_buffer_size is the actual buffer size, rather than
7295 being 1 less than the actual buffer size; this makes xpalloc more
7298 * image.c (x_allocate_bitmap_record, cache_image):
7299 * xselect.c (Fx_register_dnd_atom):
7300 Simplify previous changes by using xpalloc.
7302 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7303 since either will do and ptrdiff_t is convenient with xpalloc.
7305 * charset.c (charset_table_size)
7306 (struct charset_sort_data.priority): Now ptrdiff_t.
7307 (charset_compare): Don't overflow if priorities differ greatly.
7308 (Fsort_charsets): Don't assume list length fits in int.
7309 Check for size-calculation overflow when allocating sort data.
7310 (syms_of_charset): Allocate an initial charset table that is
7311 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7313 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7315 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7316 The actual value is always <= INT_MAX, and leaving it unsigned made
7317 overflow checking harder.
7319 * dispextern.h (struct glyph_matrix.rows_allocated)
7320 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7321 with xpalloc. The values are still always <= INT_MAX.
7323 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7325 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7326 (SAFE_NALLOCA): New macro.
7328 * region-cache.c (struct boundary.pos, find_cache_boundary)
7329 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7330 (set_cache_region, invalidate_region_cache)
7331 (revalidate_region_cache, know_region_cache, region_cache_forward)
7332 (region_cache_backward, pp_cache):
7333 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7334 so that ptrdiff_t * can be passed to xpalloc.
7335 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7336 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7337 (pp_cache): Don't assume cache_len fits in int.
7338 * region-cache.h: Adjust extern decls to match.
7340 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7341 EMACS_INT, since either will do, for xpalloc.
7343 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7344 (xnmalloc, xnrealloc, xpalloc): New functions.
7346 * bidi.c (bidi_shelve_header_size): New constant.
7347 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7348 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7350 * bidi.c (bidi_cache_shrink):
7351 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7353 Don't update size of array until after memory allocation succeeds,
7354 because xmalloc/xrealloc may not return.
7355 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7356 now that we have proper integer overflow checking.
7357 (record_overlay_string, overlay_strings): Catch overflows when
7358 calculating size of overlay_str_buf.
7360 * callproc.c (Fcall_process): Check for size overflow when
7361 calculating size of args2.
7362 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7363 Normally we prefer signed values, but sticking with ptrdiff_t would
7364 require adding more-complicated checks.
7366 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7367 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7368 Redo buffer-overflow calculations to avoid integer overflow.
7369 Add a FIXME comment where memory seems to be over-allocated.
7371 * character.c (Fstring): Check for size-calculation overflow.
7373 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7374 unnecessary integer overflow. Check for size overflow.
7375 (encode_coding_object): Don't update size until xmalloc succeeds.
7377 * composite.c (get_composition_id): Check for overflow in glyph
7378 length calculations.
7380 Integer and memory overflow fixes for display code.
7381 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7382 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7383 (scrolling_window): Check for overflow in size calculations.
7384 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7385 Don't assume glyph table len fits in int.
7386 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7387 (row_table_size): Now ptrdiff_t, not int.
7388 (scrolling_window): Avoid overflow in size calculations.
7389 Don't update size until allocation succeeds.
7390 * fns.c (concat): Check for overflow in size calculations.
7391 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7392 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7393 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7395 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7396 (get_doc_string): Check for size calculation overflow.
7397 Don't update size until allocation succeeds.
7398 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7399 EMACS_INT, where ptrdiff_t will do.
7400 (Fsubstitute_command_keys): Check for string overflow.
7402 * editfns.c (set_time_zone_rule): Don't assume environment length
7404 (message_length): Now ptrdiff_t, not int.
7405 (Fmessage_box): Don't update size until allocation succeeds.
7406 Don't assume message length fits in int.
7407 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7409 * emacs.c (main): Do not reallocate argv, since there is a null at
7410 the end that can be overwritten, and this way there's no need to
7411 worry about size-calculation overflow.
7412 (sort_args): Check for size-calculation overflow.
7414 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7416 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7418 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7419 (x_set_scroll_bar_width, x_figure_window_size):
7420 Check for integer overflow.
7421 (x_set_alpha): Do not assume XINT fits in int.
7423 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7424 This is for the members text_lines, text_cols, total_lines, total_cols,
7425 where the system imposes an 'int' limit.
7427 * fringe.c (Fdefine_fringe_bitmap):
7428 Don't update size until alloc works.
7430 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7431 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7433 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7434 Check for size-calculation overflow.
7435 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7436 do, as we prefer signed integers.
7437 (id_to_widget.max_size, id_to_widget.used)
7438 (xg_store_widget_in_map, xg_remove_widget_from_map)
7439 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7440 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7441 Use and return ptrdiff_t, not int.
7442 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7443 * gtkutil.h: Change prototypes to match the above.
7445 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7446 are duplicate now that they've been promoted to lisp.h.
7447 (x_allocate_bitmap_record, x_alloc_image_color)
7448 (make_image_cache, cache_image, xpm_load):
7449 Don't update size until alloc is done.
7450 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7452 Check for size calculation overflow.
7453 (ct_colors_allocated_max): New constant.
7454 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7457 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7458 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7459 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7460 Use ptrdiff_t, not int, to count maps.
7461 (read_char_minibuf_menu_prompt): Check for overflow in size
7462 calculations. Don't update size until allocation succeeds.
7463 Redo calculations to avoid overflow.
7464 * keyboard.h: Change prototypes to match the above.
7466 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7468 (current_minor_maps): Check for size calculation overflow.
7469 * keymap.h: Change prototypes to match the above.
7471 * lread.c (read1, init_obarray): Don't update size until alloc done.
7473 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7474 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7476 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7477 Now ptrdiff_t, not int.
7478 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7479 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7481 * process.c (Fnetwork_interface_list): Check for overflow
7482 in size calculation.
7484 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7486 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7487 overflow. Don't bother calling xmalloc when xrealloc will do.
7489 * search.c (Freplace_match): Check for size calculation overflow.
7490 (Fset_match_data): Don't assume list lengths fit in 'int'.
7492 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7493 for command line length. Do not attempt to address one before the
7494 beginning of an array, as that's not portable.
7496 * term.c (max_frame_lines): Remove; unused.
7497 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7499 (encode_terminal_code, calculate_costs): Check for size
7500 calculation overflow.
7501 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7502 table lengths and related sizes. Don't update size until alloc
7503 done. Redo calculations to avoid overflow.
7504 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7506 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7507 subtracting pointers.
7508 (gobble_line): Check for overflow more carefully. Don't update size
7511 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7512 Don't update size until alloc done.
7513 Redo size calculations to avoid overflow.
7514 Check for size calculation overflow.
7515 (main) [DEBUG]: Fix typo in invoking tparam1.
7517 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7518 Use ptrdiff_t, not int, for sizes.
7519 (store_mode_line_noprop_char): Don't update size until alloc done.
7521 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7522 Use ptrdiff_t, not int, for sizes.
7523 (Finternal_make_lisp_face, cache_face):
7524 Check for size calculation overflow.
7525 (cache_face): Treat size calculation overflows as if they were
7526 memory exhaustion (the usual treatment), rather than aborting.
7528 * xfns.c (x_encode_text, x_set_name_internal)
7529 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7530 sizes, since they can exceed INT_MAX in size. Check for size
7531 calculation overflow.
7533 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7534 (xg_select): Check for size calculation overflow.
7535 Don't update size until alloc done.
7537 * xrdb.c (get_environ_db): Don't assume path length fits in int,
7538 as sprintf is limited to int lengths.
7540 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7541 (X_LONG_MIN): New macros.
7542 Use them to make the following changes clearer.
7543 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7544 This change doesn't affect the value now, but it may help remind
7545 future maintainers not to raise the value too much later.
7546 (SELECTION_QUANTUM): Remove, replacing with ...
7547 (selection_quantum): ... new function, which avoids overflow.
7549 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7550 assumption that selection length fits in 'int'.
7551 (x_reply_selection_request, x_handle_selection_request)
7552 (x_get_window_property, receive_incremental_selection)
7553 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7554 (lisp_data_to_selection_data, clean_local_selection_data):
7555 Use ptrdiff_t, not int, to record length of selection.
7556 (x_reply_selection_request, x_get_window_property)
7557 (receive_incremental_selection, x_property_data_to_lisp):
7558 Redo calculations to avoid overflow.
7559 (x_reply_selection_request): When sending hint, ceiling it at
7560 X_LONG_MAX rather than relying on wraparound overflow to send
7562 (x_get_window_property, receive_incremental_selection)
7563 (lisp_data_to_selection_data, x_property_data_to_lisp):
7564 Check for size-calculation overflow.
7565 (x_get_window_property, receive_incremental_selection)
7566 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7567 Don't store size until memory allocation succeeds.
7568 (x_get_window_property): Plug memory leak on memory exhaustion.
7569 Don't double-block input; malloc is safe here. Don't assume 2**34
7570 - 4 fits in unsigned long. Add an xassert to check
7571 XGetWindowProperty overflow. Be more careful about overflow
7572 calculations, and distinguish size from memory overflow better.
7573 (receive_incremental_selection): When tracing, don't assume
7574 unsigned int is less than INT_MAX.
7575 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7576 harmful) conversions of unsigned short to int.
7577 (lisp_data_to_selection_data): Don't assume that integers
7578 in the range -65535 through -1 fit in an X unsigned short.
7579 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7580 result parameters unless successful. Rely on cons_to_unsigned
7581 to report problems with elements; the old code wasn't right anyway.
7582 (x_check_property_data): Check for int overflow; we cannot use
7583 a wider type due to X limits.
7584 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7586 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
7588 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7589 (x_term_init): Check for size calculation overflow.
7590 (x_color_cells): Don't store size until memory allocation succeeds.
7591 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
7592 Don't assume alloca size is less than MAX_ALLOCA.
7593 (x_term_init): Don't assume length fits in int (sprintf is limited
7596 Use ptrdiff_t for composition IDs.
7597 * character.c (lisp_string_width):
7598 * composite.c (composition_table_size, n_compositions)
7599 (get_composition_id, composition_gstring_from_id):
7600 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7601 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7602 * window.c (Frecenter):
7603 Use ptrdiff_t, not int, for composition IDs.
7604 * composite.c (get_composition_id): Check for integer overflow.
7605 * composite.h: Adjust prototypes to match the above changes.
7607 Use ptrdiff_t for hash table indexes.
7608 * category.c (hash_get_category_set):
7609 * ccl.c (ccl_driver):
7610 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7611 * coding.c (coding_system_charset_list, detect_coding_system):
7612 * coding.h (struct coding_system.id):
7613 * composite.c (get_composition_id, gstring_lookup_cache):
7614 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7615 * image.c (xpm_get_color_table_h):
7616 * lisp.h (hash_lookup, hash_put):
7617 * minibuf.c (Ftest_completion):
7618 Use ptrdiff_t for hash table indexes, not int (which is too
7619 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7620 32-bit --with-wide-int hosts).
7622 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7623 Add a FIXME comment about memory leaks.
7624 (syms_of_charset): Don't assume xmalloc returns.
7626 Don't assume that stated character widths fit in int.
7627 * character.c (Fchar_width, c_string_width, lisp_string_width):
7628 * character.h (CHAR_WIDTH):
7629 * indent.c (MULTIBYTE_BYTES_WIDTH):
7630 Use sanitize_char_width to avoid undefined and/or bad behavior
7631 with outlandish widths.
7632 * character.h (sanitize_tab_width): Rename from sanitize_width,
7633 now that we have two such functions. All uses changed.
7634 (sanitize_char_width): New inline function.
7636 Don't assume that tab-width fits in int.
7637 * character.h (sanitize_width): New inline function.
7638 (SANE_TAB_WIDTH): New macro.
7639 (ASCII_CHAR_WIDTH): Use it.
7640 * indent.c (sane_tab_width): Remove. All uses replaced by
7641 SANE_TAB_WIDTH (current_buffer).
7642 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7644 * fileio.c: Integer overflow issues with file modes.
7645 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7647 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7648 Remove unreachable code.
7649 (read_hex, load_charset_map_from_file): Check for integer overflow.
7651 * xterm.c: Don't go over XClientMessageEvent limit.
7652 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7653 (x_send_scroll_bar_event): Likewise. Check that the size does not
7654 exceed limits imposed by XClientMessageEvent, as well as the usual
7655 ptrdiff_t and size_t limits.
7657 * keyboard.c: Overflow, signedness and related fixes.
7658 (make_lispy_movement): Use same integer type in forward decl
7659 that is used in the definition.
7660 (read_key_sequence, keyremap_step):
7661 Change bufsize argument back to int, undoing my 2011-03-30 change.
7662 We prefer signed types, and int is wide enough here.
7663 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7664 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7665 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7666 length, not size_t. Use ptrdiff_t for index, not int.
7667 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7668 possibility of integer overflow.
7670 Overflow, signedness and related fixes for images.
7672 * dispextern.h (struct it.stack[0].u.image.image_id)
7673 (struct_it.image_id, struct image.id, struct image_cache.size)
7674 (struct image_cache.used, struct image_cache.ref_count):
7675 * gtkutil.c (update_frame_tool_bar):
7676 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7677 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7678 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7679 * nsmenu.m (update_frame_tool_bar):
7680 * xdisp.c (calc_pixel_width_or_height):
7681 * xfns.c (image_cache_refcount):
7682 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7683 on typical 64-bit hosts.
7685 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7686 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7687 Omit unnecessary casts to int.
7688 (parse_image_spec): Check that integers fall into 'int' range
7689 when the callers expect that.
7690 (image_ascent): Redo ascent calculation to avoid int overflow.
7691 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7692 (lookup_image): Remove unnecessary tests.
7693 (xbm_image_p): Locals are now of int, not EMACS_INT,
7694 since parse_image_check makes sure they fit into int.
7695 (png_load, gif_load, svg_load_image):
7696 Prefer int to unsigned where either will do.
7697 (tiff_handler): New function, combining the cores of the
7698 old tiff_error_handler and tiff_warning_handler.
7699 This function is rewritten to use vsnprintf and thereby avoid
7700 stack buffer overflows. It uses only the features of vsnprintf
7701 that are common to both POSIX and native Microsoft.
7702 (tiff_error_handler, tiff_warning_handler): Use it.
7703 (tiff_load, gif_load, imagemagick_load_image):
7704 Don't assume :index value fits in 'int'.
7705 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7706 (imagemagick_load_image): Check that crop parameters fit into
7707 the integer types that MagickCropImage accepts. Don't assume
7708 Vimagemagick_render_type has a nonnegative value. Don't assume
7709 size_t fits in 'long'.
7710 (gs_load): Use printmax_t to print the widest integers possible.
7711 Check for integer overflow when computing image height and width.
7713 2011-08-26 Eli Zaretskii <eliz@gnu.org>
7715 * xdisp.c (redisplay_window): Don't force window start if point
7716 will be invisible in the resulting window. (Bug#9324)
7718 2011-08-25 Eli Zaretskii <eliz@gnu.org>
7720 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7721 the display spec is of the form `(space ...)'.
7722 (handle_display_spec): Return the value returned by
7723 handle_single_display_spec, not just 1 or zero.
7724 (handle_single_display_spec): If the display spec is of the form
7725 `(space ...)', and specifies display in the text area, return 2
7727 (try_cursor_movement): Check for the need to scroll more
7728 accurately, and prefer exact match for point under bidi.
7729 Don't advance `row' beyond the last row of the window.
7731 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7732 into disp_prop; all users changed.
7734 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7735 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7736 for the text covered by the display property.
7738 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
7740 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7741 Change return value to nil.
7742 (Frecord_buffer): Delete unused function.
7744 2011-08-24 Eli Zaretskii <eliz@gnu.org>
7746 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7747 buffers, return left-to-right.
7748 (set_cursor_from_row): Consider candidate row a win if its glyph
7749 represents a newline and point is on that newline. Fixes cursor
7750 positioning on the newline at EOL of R2L text within L2R
7751 paragraph, and vice versa.
7752 (try_cursor_movement): Check continued rows, in addition to
7753 continuation rows. Fixes unwarranted scroll when point enters a
7754 continued line of R2L text within an L2R paragraph, or vice versa.
7755 (cursor_row_p): Consider the case of point being equal to
7756 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7757 from the end of a short line to the beginning of a continued line
7758 of R2L text within L2R paragraph.
7759 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7760 composed characters.
7762 * bidi.c (bidi_check_type): Use xassert.
7763 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7766 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7768 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7771 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
7773 * nsfont.m (ns_otf_to_script): Fix typo.
7775 2011-08-22 Kenichi Handa <handa@m17n.org>
7777 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7778 extra slot even if the purpose is char-code-property-table.
7780 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7782 * xdisp.c (redisplay_window): When computing centering_position,
7783 account for the height of the header line. (Bug#8874)
7785 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7786 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7787 candidate is selected by the mouse, and that candidate has a
7788 composed character under the mouse.
7790 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7791 coordinates reported by pos-visible-in-window-p for a composed
7792 character in column zero.
7794 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7796 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7798 2011-08-22 Eli Zaretskii <eliz@gnu.org>
7800 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7801 consider it a hit if to_charpos is anywhere in the range of the
7802 composed buffer positions.
7804 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
7806 * image.c (gif_load): Don't assume that each subimage has the same
7807 dimensions as the base image. Handle disposal method that is
7808 "undefined" by the gif spec (Bug#9335).
7810 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
7812 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
7813 (Fcondition_case): Document `debug' symbol in error handler.
7815 2011-08-19 Eli Zaretskii <eliz@gnu.org>
7817 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7818 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7819 from an Org mode buffer to a Speedbar frame.
7821 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7822 a composition, take its buffer position from IT->cmp_it.charpos.
7823 Fixes cursor positioning at the beginning of a line that begins
7824 with a composed character.
7826 2011-08-18 Eli Zaretskii <eliz@gnu.org>
7828 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7829 character bidirectional type, use STRONG_L instead. Fixes crashes
7830 in a buffer produced by `describe-categories'.
7832 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7833 members before the level stack, so they would be saved and
7834 restored when copying iterator state. Fixes incorrect reordering
7835 around TABs covered by display properties.
7837 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7839 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
7841 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
7843 * eval.c (internal_condition_case, internal_condition_case_1)
7844 (internal_condition_case_2, internal_condition_case_n):
7845 Remove unnecessary aborts (Bug#9081).
7847 2011-08-17 Eli Zaretskii <eliz@gnu.org>
7849 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7850 has no `load' handler, try opening the file locally. (Bug#9311)
7852 2011-08-16 Ken Brown <kbrown@cornell.edu>
7854 * gmalloc.c: Expand comment.
7856 2011-08-16 Eli Zaretskii <eliz@gnu.org>
7858 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7859 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7861 2011-08-16 Ken Brown <kbrown@cornell.edu>
7863 Fix memory allocation problems in Cygwin build (Bug#9273).
7865 * unexcw.c ( __malloc_initialized): Declare external variable.
7866 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7868 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7870 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7872 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7874 [CYGWIN] (special_realloc): New function.
7875 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7876 requests to realloc storage in the static heap.
7878 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7880 * bidi.c (bidi_initialize): Remove unused local.
7882 2011-08-15 Eli Zaretskii <eliz@gnu.org>
7885 * biditype.h: Remove file.
7886 * makefile.w32-in ($(BLD)/bidi.$(O)):
7887 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
7889 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7891 * chartab.c: Improve commentary for the uniprop_table API.
7893 * bidi.c (bidi_paragraph_init): Support zero value of
7894 bidi_ignore_explicit_marks_for_paragraph_level.
7895 (bidi_initialize): Use uniprop_table instead of including
7896 biditype.h and bidimirror.h.
7898 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7899 coordinates of the iterator when restoring from ppos_it.
7902 2011-08-14 Kenichi Handa <handa@m17n.org>
7904 * process.c (create_process): Call setup_process_coding_systems
7905 after the pid of the process is set to -1 (Bug#8162).
7907 2011-08-14 Eli Zaretskii <eliz@gnu.org>
7909 * xdisp.c (move_it_in_display_line_to): Don't invoke
7910 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7911 ppos_it. Fixes vertical cursor motion when line beginning is
7912 covered by an image. (Bug#9296)
7914 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7916 * nsterm.h (ns_run_ascript): Declare.
7917 (NSAPP_DATA2_RUNASSCRIPT): Define.
7919 * nsfns.m (as_script, as_result, as_status): New static variables.
7920 (ns_run_ascript): New function.
7921 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
7922 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7923 the event loop. Get status from as_status (Bug#7276).
7925 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7926 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7927 the event loop (Bug#7276).
7929 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7931 * gnutls.c (QCgnutls_bootprop_priority)
7932 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7933 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7934 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7935 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7936 (QCgnutls_bootprop_verify_hostname_error)
7937 (QCgnutls_bootprop_callbacks_verify): Rename from
7938 Qgnutls_bootprop_..., all uses changed.
7940 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7943 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7945 * xfaces.c (Qframe_set_background_mode): Now static.
7946 * dispextern.h (Qframe_set_background_mode): Remove decl.
7948 * process.c (Fnetwork_interface_info): Declare local only if needed.
7950 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7952 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7953 (Fnetwork_interface_list): Allocate in increments of bytes instead
7954 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7955 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7957 (struct ifflag_def): notrailers is smart on OSX.
7958 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7959 Get hardware address with getifaddrs if available.
7961 2011-08-12 Eli Zaretskii <eliz@gnu.org>
7963 * xdisp.c (iterate_out_of_display_property): xassert that
7964 IT->position is set to within IT->object's boundaries. Break from
7965 the loop as soon as EOB is reached; avoids infloops in redisplay
7966 when IT->position is set up wrongly due to some bug.
7967 Set IT->current to match the bidi iterator unconditionally.
7968 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7969 entry. Force push_it to save on the stack the current
7970 buffer/string position, to be restored by pop_it. Fix flags in
7971 the iterator structure wrt the object coming from a display
7972 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7973 properties. (Bug#9284)
7975 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
7977 * fontset.c (fontset_get_font_group): Add proper type checks.
7980 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7982 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7983 and LC_VERSION_MIN_MACOSX.
7984 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7985 (dump_it) [LC_FUNCTION_STARTS]: Use it.
7987 2011-08-08 Eli Zaretskii <eliz@gnu.org>
7989 * xdisp.c (forward_to_next_line_start): Allow to use the
7990 no-display-properties-and-no-overlays under bidi display.
7991 Set disp_pos in the bidi iterator to avoid searches for display
7992 properties and overlays.
7994 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
7996 * editfns.c (Fset_time_zone_rule): Document relationship with the
7999 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8000 the font entity extracted from the cache (Bug#8109).
8002 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
8004 * composite.c (autocmp_chars): Don't reset point. That is done by
8005 restore_point_unwind (Bug#5984).
8007 2011-08-07 Juri Linkov <juri@jurta.org>
8009 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8010 to show the arg `TIME' instead of `TIMEVAL'.
8012 2011-08-06 Eli Zaretskii <eliz@gnu.org>
8014 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8015 display property strides EOL and includes a newline, as in
8016 longlines-mode. (Bug#9254)
8017 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8018 word-wrap under bidirectional display. (Bug#9224)
8020 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8021 is non-zero, even if the data buffer is NULL. Fixes a crash in
8022 vertical-motion with longlines-mode. (Bug#9254)
8024 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8026 * bidi.c <bidi_cache_total_alloc>: Now static.
8027 (bidi_initialize): Initialize bidi_cache_total_alloc.
8029 * xdisp.c (display_line): Release buffer allocated for shelved bidi
8032 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8033 amount allocated this far in `bidi_cache_total_alloc'.
8034 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8035 non-zero, only free the data buffer without restoring the cache
8036 contents. All callers changed.
8038 * dispextern.h (bidi_unshelve_cache): Update prototype.
8040 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8041 (move_it_in_display_line, move_it_to)
8042 (move_it_vertically_backward, move_it_by_lines): Replace the call
8043 to xfree to an equivalent call to bidi_unshelve_cache.
8044 (move_it_in_display_line_to): Fix logic of returning
8045 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
8047 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8049 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8050 came from a string character with a `cursor' property. (Bug#9229)
8052 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8054 * Makefile.in (LIB_PTHREAD): New variable.
8055 (LIBES): Add LIB_PTHREAD (Bug#9216).
8057 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8058 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8060 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8062 * regex.c (re_iswctype): Remove some redundant boolean conversions.
8064 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8066 * xterm.c (x_find_topmost_parent): New function.
8067 (x_set_frame_alpha): Find topmost parent window with
8068 x_find_topmost_parent and set the property there also (bug#9181).
8069 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8071 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8073 * callproc.c (Fcall_process): Avoid vfork clobbering
8074 the local vars buffer, coding_systems, current_dir.
8076 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8078 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8080 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8082 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8083 so that it is not optimized away.
8085 * xdisp.c (compute_display_string_pos): Remove unused local.
8087 2011-08-02 Eli Zaretskii <eliz@gnu.org>
8089 Fix slow cursor motion and scrolling in large buffers with
8090 selective display, like Org Mode buffers. (Bug#9218)
8092 * dispextern.h (struct bidi_it): New member disp_prop_p.
8094 * xdisp.c: Remove one-slot cache of display string positions.
8095 (compute_display_string_pos): Accept an additional argument
8096 DISP_PROP_P; callers changed. Scan at most 5K characters forward
8097 for a display string or property. If found, set DISP_PROP_P
8100 * bidi.c (bidi_fetch_char): Accept an additional argument
8101 DISP_PROP_P, and pass it to compute_display_string_pos.
8102 Only handle text covered by a display string if DISP_PROP_P is returned
8103 non-zero. All callers of bidi_fetch_char changed.
8105 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8107 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8109 2010-12-03 Don March <don@ohspite.net>
8111 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8112 last character M-[char] is translated to ESC [char] (bug#7541).
8114 2011-08-02 Kenichi Handa <handa@m17n.org>
8116 * lisp.h (uniprop_table): Extern it.
8118 * chartab.c (uniprop_table): Make it non-static.
8120 2011-08-01 Eli Zaretskii <eliz@gnu.org>
8122 * xdisp.c (forward_to_next_line_start): Accept additional argument
8123 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8125 (reseat_at_next_visible_line_start): Use the bidi iterator state
8126 returned by forward_to_next_line_start to restore the state of
8127 it->bidi_it after backing up to previous newline. (Bug#9212)
8129 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8131 * regex.c (re_comp): Protoize.
8132 (re_exec): Fix return type.
8133 (regexec): Fix type of `ret'. (Bug#9203)
8135 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8137 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8138 This is needed if max-image-size is a floating-point number.
8140 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8142 * print.c (print_object): Print empty symbol as ##.
8144 * lread.c (read1): Read ## as empty symbol.
8146 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8148 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8149 setting frame foreground color (Bug#9175).
8150 (x_set_background_color): Likewise.
8152 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8153 contents (Bug#9176).
8154 (EmacsTooltip -init): Remove bezels and add shadows to
8157 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8158 or scroll bar (Bug#8470).
8160 * nsfont.m (nsfont_open): Remove assignment to voffset and
8161 unnecessary vars hshink, expand, hd, full_height, min_height.
8162 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8164 * nsterm.h (nsfont_info): Remove voffset field.
8166 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8168 Implement strike-through and overline on NextStep (Bug#8863).
8170 * nsfont.m (nsfont_open): Use underline position provided by font,
8171 instead of hard-coded value of 2.
8172 (nsfont_draw): Call ns_draw_text_decoration instead.
8174 * nsterm.h: Add declaration for ns_draw_text_decoration.
8176 * nsterm.m (ns_draw_text_decoration): New function for drawing
8177 underline, overline, and strike-through.
8178 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8179 ns_draw_text_decoration. Change treatment of cursor drawing to
8180 accommodate underlining, etc.
8182 2011-07-28 Eli Zaretskii <eliz@gnu.org>
8184 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8187 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8189 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8190 Without this fix, if a signal arrives just after memory fills up,
8191 'malloc' might be invoked reentrantly.
8193 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8194 In other words, assume that every image size is allowed, on non-X
8195 hosts. This assumption is probably wrong, but it lets Emacs compile.
8197 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8199 * regex.c (re_iswctype): Convert return values to boolean.
8201 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8203 * xdisp.c (compute_display_string_pos): Don't use cached display
8204 string position if the buffer had its restriction changed.
8207 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8209 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8211 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8213 Integer signedness and overflow and related fixes. (Bug#9079)
8215 * bidi.c: Integer size and overflow fixes.
8216 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8217 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8218 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8219 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8220 (bidi_find_other_level_edge):
8221 Use ptrdiff_t instead of EMACS_INT where either will do.
8222 This works better on 32-bit hosts configured --with-wide-int.
8223 (bidi_cache_ensure_space): Check for size-calculation overflow.
8224 Use % rather than repeated addition, for better worst-case speed.
8225 Don't set bidi_cache_size until after xrealloc returns, because it
8227 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
8228 (bidi_cache_ensure_space): Also check that the bidi cache size
8229 does not exceed that of the largest Lisp string or buffer. See Eli
8230 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
8232 * alloc.c (__malloc_size_t): Remove.
8233 All uses replaced by size_t. See Andreas Schwab's note
8234 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8236 * image.c: Improve checking for integer overflow.
8237 (check_image_size): Assume that f is nonnull, since
8238 it is always nonnull in practice. This is one less thing to
8239 worry about when checking for integer overflow later.
8240 (x_check_image_size): New function, which checks for integer
8241 overflow issues inside X.
8242 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8243 This removes the need for a memory_full check.
8244 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8245 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8246 (xbm_read_bitmap_data): Change locals back to 'int', since
8247 their values must fit in 'int'.
8248 (xpm_load_image, png_load, tiff_load):
8249 Invoke x_create_x_image_and_pixmap earlier,
8250 to avoid much needless work if the image is too large.
8251 (tiff_load): Treat overly large images as if
8252 x_create_x_image_and_pixmap failed, not as malloc failures.
8253 (gs_load): Use x_check_image_size.
8255 * gtkutil.c: Omit integer casts.
8256 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8257 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8259 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8261 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8262 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8263 would wrongly return t on a 64-bit host.
8265 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8266 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8267 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8268 and therefore cause GCC to emit a bogus diagnostic in some cases.
8270 * image.c: Integer signedness and overflow and related fixes.
8271 This is not an exhaustive set of fixes, but it's time to
8272 record what I've got.
8273 (lookup_pixel_color, check_image_size): Remove redundant decls.
8274 (check_image_size): Don't assume that arbitrary EMACS_INT values
8275 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8276 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8277 (tiff_load, imagemagick_load_image):
8278 Check for overflow in size calculations.
8279 (x_create_x_image_and_pixmap): Remove unnecessary test for
8280 xmalloc returning NULL; that can't happen.
8281 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8282 (xpm_color_bucket): Use better integer hashing function.
8283 (xpm_cache_color): Don't possibly over-allocate memory.
8284 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8285 (gif_memory_source):
8286 Use ptrdiff_t, not int or size_t, to record sizes.
8287 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8288 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8289 either works, as we prefer signed integers.
8290 (tiff_read_from_memory, tiff_write_from_memory):
8291 Return tsize_t, not size_t, since that's what the TIFF API wants.
8292 (tiff_read_from_memory): Don't fail simply because the read would
8293 go past EOF; instead, return a short read.
8294 (tiff_load): Omit no-longer-needed casts.
8295 (Fimagemagick_types): Don't assume size fits into 'int'.
8297 Improve hashing quality when configured --with-wide-int.
8298 * fns.c (hash_string): New function, taken from sxhash_string.
8299 Do not discard information about ASCII character case; this
8300 discarding is no longer needed.
8301 (sxhash-string): Use it. Change sig to match it. Caller changed.
8302 * lisp.h: Declare it.
8303 * lread.c (hash_string): Remove, since we now use fns.c's version.
8304 The fns.c version returns a wider integer if --with-wide-int is
8305 specified, so this should help the quality of the hashing a bit.
8307 * emacs.c: Integer overflow minor fix.
8308 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8309 Define only if GNU_LINUX.
8310 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8312 * dispnew.c: Integer signedness and overflow fixes.
8313 Remove unnecessary forward decls, that were a maintenance hassle.
8314 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8316 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8317 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8318 (prepare_desired_row, line_draw_cost):
8319 Use int, not unsigned, where either works.
8320 (save_current_matrix, restore_current_matrix):
8321 Use ptrdiff_t, not size_t, where either works.
8322 (init_display): Check for overflow more accurately, and without
8323 relying on undefined behavior.
8325 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8326 Remove, replacing with the new symbols in lisp.h. All uses changed.
8327 * fileio.c (make_temp_name):
8328 * filelock.c (lock_file_1, lock_file):
8329 * xdisp.c (message_dolog):
8330 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8331 Use pMd etc. instead.
8332 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8333 replacing the pWIDE etc. symbols removed from editfns.c.
8335 * keyboard.h (num_input_events): Now uintmax_t.
8336 This is (very slightly) less likely to mess up due to wraparound.
8339 * buffer.c: Integer signedness fixes.
8340 (alloc_buffer_text, enlarge_buffer_text):
8341 Use ptrdiff_t rather than size_t when either will do, as we prefer
8344 * alloc.c: Integer signedness and overflow fixes.
8345 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8346 (__malloc_size_t): Default to size_t, not to int.
8347 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8348 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8349 Prefer ptrdiff_t to size_t when either would do, as we prefer
8351 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8352 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8353 Now const. Initialize with values that are in range even if char
8355 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8356 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8357 These functions do the right thing with sizes > 2**32.
8358 (check_depth): Now ptrdiff_t, not int.
8359 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8360 Adjust to new way of storing sizes. Check for size overflow bugs
8362 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8363 slightly wrong anyway, as it missed one instance of
8364 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8365 (refill_memory_reserve): Omit needless cast to size_t.
8366 (mark_object_loop_halt): Mark as externally visible.
8368 * xselect.c: Integer signedness and overflow fixes.
8369 (Fx_register_dnd_atom, x_handle_dnd_message):
8370 Use ptrdiff_t, not size_t, since we prefer signed.
8371 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8372 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8373 x_dnd_atoms_size and x_dnd_atoms_length.
8375 * doprnt.c: Prefer signed to unsigned when either works.
8377 * doprnt.c (doprnt):
8379 * xdisp.c (vmessage):
8380 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8381 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8382 prefer signed arithmetic to avoid comparison confusion.
8383 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8384 but is a bit tricky.
8386 Assume freestanding C89 headers, string.h, stdlib.h.
8387 * data.c, doprnt.c, floatfns.c, print.c:
8388 Include float.h unconditionally.
8389 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8390 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8391 * regex.c: Likewise for stddef.h, string.h.
8392 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8393 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8394 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8395 (STDC_HEADERS): Remove obsolete defines.
8396 * sysdep.c: Include limits.h unconditionally.
8398 Assume support for memcmp, memcpy, memmove, memset.
8399 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8400 * regex.c (memcmp, memcpy):
8401 Remove; we assume C89 now.
8403 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8404 (__malloc_safe_bcopy): Remove; no longer needed.
8406 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
8407 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8408 well either way, and we prefer signed to unsigned.
8410 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8412 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8413 closes the connection while we're reading (bug#9182).
8415 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
8417 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8418 are specified (Bug#9168).
8420 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8422 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8423 Found by GCC static checking and --with-wide-int on a 32-bit host.
8425 2011-07-25 Eli Zaretskii <eliz@gnu.org>
8427 * xdisp.c (compute_display_string_pos): Fix logic of caching
8428 previous display string position. Initialize cached_prev_pos to
8429 -1. Fixes slow-down at the beginning of a buffer.
8431 2011-07-24 Eli Zaretskii <eliz@gnu.org>
8433 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8434 for attrs[LFACE_FONTSET_INDEX].
8436 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8438 * xml.c (parse_region): Remove unused local
8439 that was recently introduced.
8441 2011-07-23 Eli Zaretskii <eliz@gnu.org>
8443 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8444 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8446 * xdisp.c (move_it_in_display_line_to): Record the best matching
8447 position for TO_CHARPOS while scanning the line, and restore it on
8448 exit if none of the characters scanned was an exact match.
8449 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
8450 when exact match is impossible due to invisible text, and the
8451 lines are truncated.
8453 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8455 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8458 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8460 Fix a significant slow-down of cursor motion with C-n, C-p,
8461 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8462 auto-repeat under bidi redisplay in fontified buffers.
8463 * xdisp.c (compute_stop_pos_backwards): New function.
8464 (next_element_from_buffer): Call compute_stop_pos_backwards to
8465 find a suitable prev_stop when we find ourselves before
8467 (reseat): Don't look for prev_stop, as that could mean a very long
8469 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8470 <cached_disp_overlay_modiff>: Cache for last found display string
8472 (compute_display_string_pos): Return the cached position if asked
8473 about the same buffer in the same area of character positions, and
8474 the buffer wasn't changed since the time the display string
8475 position was cached.
8477 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8479 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8480 is an integer, which is important for empty lines. (Bug#9149)
8482 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
8484 * frame.c (Fmodify_frame_parameters): In tty case, update the
8485 default face if necessary (Bug#4238).
8487 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
8489 * editfns.c (Fstring_to_char): No need to explain what a character
8490 is in the docstring (Bug#6576).
8492 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8494 * xml.c (parse_region): Make sure we always return a tree.
8496 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8498 * xml.c (parse_region): If a document contains only comments,
8501 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8503 * xml.c (make_dom): Return comments, too.
8505 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8508 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8509 and the surrounding thread.
8510 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8511 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8512 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8514 * s/openbsd.h (BROKEN_SIGIO): Define.
8515 * unexelf.c (unexec) [__OpenBSD__]:
8516 Don't update the .mdebug section of the Alpha COFF symbol table.
8518 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8520 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8523 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8525 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8526 This fixes some race conditions on the permissions of any newly
8529 * alloc.c (valid_pointer_p): Use pipe, not open.
8530 This fixes some permissions issues when debugging.
8532 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8533 If fchown fails to set both uid and gid, try to set just gid,
8534 as that is sometimes allowed. Adjust the file's mode to eliminate
8535 setuid or setgid bits that are inappropriate if fchown fails.
8537 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8539 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8540 to compare Lisp_Objects.
8541 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8542 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8543 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8545 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8547 * lread.c (read_integer): Unread even EOF character.
8548 (read1): Likewise. Properly record start position of symbol.
8550 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8551 symbol character follows.
8553 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8555 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8556 This works around a problem with the previous change to Fcopy_file.
8557 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8558 and without this change, GCC might complain about discarding
8559 fchown's return value.
8561 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
8563 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8565 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8567 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8569 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8571 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8572 it's used from the C level.
8574 * process.c: Use the same condition for POLL_FOR_INPUT in both
8575 keyboard.c and process.c (bug#1858).
8577 2011-07-09 Lawrence Mitchell <wence@gmx.li>
8579 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8580 (Fgnutls_boot): Use it.
8582 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8584 * doc.c (Fsubstitute_command_keys): Revert last change.
8586 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8588 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8589 quotes the next character, and doesn't affect other longer
8590 sequences (bug#8935).
8592 * lread.c (syms_of_lread): Clarify that is isn't only
8593 `eval-buffer' and `eval-defun' that's affected by
8594 `lexical-binding' (bug#8460).
8596 2011-07-15 Eli Zaretskii <eliz@gnu.org>
8598 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
8599 bidi redisplay when a line includes both an image and is truncated.
8601 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8603 Fix minor problems found by static checking.
8604 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8605 (elsz): Now a signed constant, not a size_t var. We prefer signed
8606 types to unsigned, to avoid integer comparison confusion. Without
8607 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8608 "cannot optimize loop, the loop counter may overflow", a symptom
8610 * indent.c (Fvertical_motion): Mark locals as initialized.
8611 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8613 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8615 * search.c (Fre_search_backward): Mention `case-fold-search' in
8616 all the re_search_* functions (bug#8138).
8618 * keyboard.c (Fopen_dribble_file): Document when the file is
8621 2011-07-14 Eli Zaretskii <eliz@gnu.org>
8623 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8626 Support bidi reordering of display and overlay strings.
8627 * xdisp.c (compute_display_string_pos)
8628 (compute_display_string_end): Accept additional argument STRING.
8629 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8630 (reseat_to_string): Initialize bidi_it->string.s and
8631 bidi_it->string.schars.
8632 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
8633 NULL (avoids a crash in bidi_paragraph_init).
8634 Initialize itb.string.lstring.
8635 (init_iterator): Call bidi_init_it only of a valid
8636 buffer position was specified. Initialize paragraph_embedding to
8638 (reseat_to_string): Initialize the bidi iterator.
8639 (display_string): If we need to ignore text properties of
8640 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8641 original value of -1 will not work with bidi.)
8642 (compute_display_string_pos): First arg is now struct
8643 `text_pos *'; all callers changed. Support display properties on
8645 (compute_display_string_end): Support display properties on Lisp
8647 (init_iterator, reseat_1, reseat_to_string): Initialize the
8648 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8649 when iterating on a string not from display properties).
8650 (compute_display_string_pos, compute_display_string_end):
8651 Fix calculation of the object to scan. Fixes an error when using
8653 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
8654 base_level_stop; instead, set base_level_stop to BEGV.
8655 Fixes crashes in vertical-motion.
8656 (next_element_from_buffer): Improve commentary for when
8657 the iterator is before prev_stop.
8658 (init_iterator): Initialize bidi_p from the default value of
8659 bidi-display-reordering, not from buffer-local value. Use the
8660 buffer-local value only if initializing for buffer iteration.
8661 (handle_invisible_prop): Support invisible properties on strings
8662 that are being bidi-reordered.
8663 (set_iterator_to_next): Support bidi reordering of C strings and
8665 (next_element_from_string): Support bidi reordering of Lisp
8667 (handle_stop_backwards): Support Lisp strings as well.
8668 (display_string): Support display of R2L glyph rows.
8669 Use IT_STRING_CHARPOS when displaying from a Lisp string.
8670 (init_iterator): Don't initialize it->bidi_p for strings
8672 (reseat_to_string): Initialize it->bidi_p for strings here.
8673 (next_element_from_string, next_element_from_c_string)
8674 (next_element_from_buffer): Add xassert's for correspondence
8675 between IT's object being iterated and it->bidi_it.string
8677 (face_before_or_after_it_pos): Support bidi iteration.
8678 (next_element_from_c_string): Handle the case of the first string
8679 character that is not the first one in the visual order.
8680 (get_visually_first_element): New function, refactored from common
8681 parts of next_element_from_buffer, next_element_from_string, and
8682 next_element_from_c_string.
8683 (tool_bar_lines_needed, redisplay_tool_bar)
8684 (display_menu_bar): Force left-to-right direction. Add a FIXME
8685 comment for making that be controlled by a user option.
8686 (push_it, pop_it): Save and restore the state of the
8687 bidi iterator. Save and restore the bidi_p flag.
8688 (pop_it): Iterate out of display property for string iteration as
8690 (iterate_out_of_display_property): Support iteration over strings.
8691 (handle_single_display_spec): Set up it->bidi_it for iteration
8692 over a display string, and call bidi_init_it.
8693 (handle_single_display_spec, next_overlay_string)
8694 (get_overlay_strings_1, push_display_prop): Set up the bidi
8695 iterator for displaying display or overlay strings.
8696 (forward_to_next_line_start): Don't use the shortcut if
8698 (back_to_previous_visible_line_start): If handle_display_prop
8699 pushed the iterator stack, restore the internal state of the bidi
8700 iterator by calling bidi_pop_it same number of times.
8701 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8702 and we are bidi-iterating, don't decrement the iterator position;
8703 instead, set the first_elt flag in the bidi iterator, to produce
8705 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8706 (push_display_prop): xassert that we are iterating a buffer.
8707 (push_it, pop_it): Save and restore paragraph_embedding member.
8708 (handle_single_display_spec, next_overlay_string)
8709 (get_overlay_strings_1, reseat_1, reseat_to_string)
8710 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8711 correctly. Don't assume unibyte strings are not bidi-reordered.
8712 (compute_display_string_pos)
8713 (compute_display_string_end): Fix handling the case of C string.
8714 (push_it, pop_it): Save and restore from_disp_prop_p.
8715 (handle_single_display_spec, push_display_prop): Set the
8716 from_disp_prop_p flag.
8717 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8718 (pop_it): Call iterate_out_of_display_property only if we are
8719 popping after iteration over a string that came from a display
8720 property. Fix a typo in popping stretch info. Add an assertion
8721 for verifying that the iterator position is in sync with the bidi
8723 (handle_single_display_spec, get_overlay_strings_1)
8724 (push_display_prop): Fix initialization of paragraph direction for
8725 string when that of the parent object is not yet determined.
8726 (reseat_1): Call bidi_init_it to resync the bidi
8727 iterator with IT's position. (Bug#7616)
8728 (find_row_edges): If ROW->start.pos gives position
8729 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8730 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8731 Reset the from_disp_prop_p flag.
8732 (SAVE_IT, RESTORE_IT): New macros.
8733 (pos_visible_p, face_before_or_after_it_pos)
8734 (back_to_previous_visible_line_start)
8735 (move_it_in_display_line_to, move_it_in_display_line)
8736 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8737 (try_scrolling, redisplay_window, display_line): Use them when
8738 saving a temporary copy of the iterator and restoring it back.
8739 (back_to_previous_visible_line_start, reseat_1)
8740 (init_iterator): Empty the bidi cache "stack".
8741 (move_it_in_display_line_to): If iterator ended up at
8742 EOL, but we never saw any buffer positions smaller than
8743 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8744 motion in bidi-reordered lines.
8745 (move_it_in_display_line_to): Record prev_method and prev_pos
8746 immediately before the call to set_iterator_to_next. Fixes cursor
8747 motion in bidi-reordered lines with stretch glyphs and strings
8748 displayed in margins. (Bug#8133) (Bug#8867)
8749 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8751 (pos_visible_p): Support positions in bidi-reordered lines.
8752 Save and restore bidi cache.
8754 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8755 (bidi_paragraph_info): Delete unused struct.
8756 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8757 (bidi_cache_start): New variable.
8758 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8760 (bidi_cache_fetch_state, bidi_cache_search)
8761 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8762 (bidi_cache_find, bidi_peek_at_next_level)
8763 (bidi_level_of_next_char, bidi_find_other_level_edge)
8764 (bidi_move_to_visually_next): Compare cache index with
8765 bidi_cache_start rather than with zero.
8766 (bidi_fetch_char): Accept new argument STRING; all callers
8767 changed. Support iteration over a string. Support strings with
8768 display properties. Support unibyte strings. Fix the type of
8769 `len' according to what STRING_CHAR_AND_LENGTH expects.
8770 (bidi_paragraph_init, bidi_resolve_explicit_1)
8771 (bidi_resolve_explicit, bidi_resolve_weak)
8772 (bidi_level_of_next_char, bidi_move_to_visually_next):
8773 Support iteration over a string.
8774 (bidi_set_sor_type, bidi_resolve_explicit_1)
8775 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8776 can now be zero (for strings); special values 0 and -1 were
8777 changed to -1 and -2, respectively.
8778 (bidi_char_at_pos): New function.
8779 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8780 Call it instead of FETCH_MULTIBYTE_CHAR.
8781 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8782 initialized to valid values.
8783 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8785 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8786 the test for valid cached positions. Fix the logic for looking up
8787 the sentinel state in the cache. GCPRO the Lisp string we are
8789 (bidi_push_it, bidi_pop_it): New functions.
8790 (bidi_initialize): Initialize the bidi cache start stack pointer.
8791 (bidi_cache_ensure_space): New function, refactored from part of
8792 bidi_cache_iterator_state. Don't assume the required size is just
8793 one BIDI_CACHE_CHUNK away.
8794 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8795 (bidi_count_bytes, bidi_char_at_pos): New functions.
8796 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8797 always valid if bidi_cache_idx is valid.
8798 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8799 is valid if it's going to be used.
8800 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8801 (bidi_cache_fetch_state, bidi_cache_search)
8802 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8803 (bidi_cache_iterator_state, bidi_cache_find)
8804 (bidi_find_other_level_edge, bidi_cache_start_stack):
8805 All variables related to cache indices are now EMACS_INT.
8807 * dispextern.h (struct bidi_string_data): New structure.
8808 (struct bidi_it): New member `string'. Make flag members be 1-bit
8809 fields, and put them last in the struct.
8810 (compute_display_string_pos, compute_display_string_end):
8812 (bidi_push_it, bidi_pop_it): Add prototypes.
8813 (struct iterator_stack_entry): New members bidi_p,
8814 paragraph_embedding, and from_disp_prop_p.
8815 (struct it): Member bidi_p is now a bit field 1 bit wide.
8816 (bidi_shelve_cache, bidi_unshelve_cache):
8819 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8820 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8821 and vector-like objects.
8823 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8824 cache around display iteration.
8826 * window.c (Fwindow_end, window_scroll_pixel_based)
8827 (displayed_window_lines, Frecenter): Save and restore the bidi
8828 cache around display iteration.
8830 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8832 * editfns.c (Fdelete_region): Clarify the use of the named
8833 parameters (bug#6788).
8835 2011-07-14 Martin Rudalics <rudalics@gmx.at>
8837 * indent.c (Fvertical_motion): Set and restore w->pointm when
8838 saving and restoring the window's buffer (Bug#9006).
8840 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8842 * editfns.c (Fstring_to_char): Clarify just what is returned
8843 (bug#6576). Text by Eli Zaretskii.
8845 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
8847 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8849 2011-07-13 Eli Zaretskii <eliz@gnu.org>
8851 * buffer.c (mmap_find): Fix a typo.
8853 2011-07-13 Johan Bockgård <bojohan@gnu.org>
8855 Fix execution of x selection hooks.
8856 * xselect.c (Qx_lost_selection_functions)
8857 (Qx_sent_selection_functions): New vars.
8858 (syms_of_xselect): DEFSYM them.
8859 (x_handle_selection_request): Pass Qx_sent_selection_functions
8860 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8861 (x_handle_selection_clear,x_clear_frame_selections):
8862 Pass Qx_lost_selection_functions rather than
8863 Vx_lost_selection_functions to Frun_hook_with_args.
8865 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8867 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
8868 The old code sometimes used this field without initializing it.
8870 * alloc.c (gc_sweep): Don't read past end of array.
8871 In theory, the old code could also have corrupted Emacs internals,
8872 though it'd be very unlikely.
8874 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8876 * character.c (Fcharacterp): Don't advertise optional ignored
8877 argument. (Bug#4026)
8879 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8881 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8884 * window.c (Fset_window_start): Doc fix (bug#4199).
8885 (Fset_window_hscroll): Ditto.
8887 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8889 Fix minor new problems caught by GCC 4.6.1.
8890 * term.c (init_tty): Remove unused local.
8891 * xsettings.c (store_monospaced_changed): Define this function only
8892 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
8895 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
8897 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8899 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8901 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8902 are the mini-buffer and the echo area (bug#3320).
8904 * term.c (init_tty): Remove support for supdup, c10 and perq
8905 terminals, which are no longer supported (bug#1482).
8907 2011-07-10 Johan Bockgård <bojohan@gnu.org>
8909 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8911 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8913 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8914 for non-popups (Bug#3642).
8916 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8918 * alloc.c (reset_malloc_hooks): Protoize.
8919 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
8920 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8921 * cm.c (losecursor): Likewise.
8922 * data.c (fmod): Likewise.
8923 * dispnew.c (swap_glyphs_in_rows): Likewise.
8924 * emacs.c (memory_warning_signal): Likewise.
8925 * floatfns.c (float_error): Likewise.
8926 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8927 (otf_open, font_otf_capability, generate_otf_features)
8928 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8930 * image.c (pbm_read_file): Likewise.
8931 * indent.c (string_display_width): Likewise.
8932 * intervals.c (check_for_interval, search_for_interval)
8933 (inc_interval_count, count_intervals, root_interval)
8934 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8935 * lread.c (defalias): Likewise.
8936 * ralloc.c (r_alloc_check): Likewise.
8937 * regex.c (set_image_of_range_1, set_image_of_range)
8938 (regex_grow_registers): Likewise.
8939 * sysdep.c (strerror): Likewise.
8940 * termcap.c (valid_filename_p, tprint, main): Likewise.
8941 * tparam.c (main): Likewise.
8942 * unexhp9k800.c (run_time_remap, save_data_space)
8943 (update_file_ptrs, read_header, write_header, calculate_checksum)
8944 (copy_file, copy_rest, display_header): Likewise.
8945 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8947 * xdisp.c (check_it): Likewise.
8948 * xfaces.c (register_color, unregister_color, unregister_colors):
8950 * xfns.c (print_fontset_result): Likewise.
8951 * xrdb.c (member, fatal, main): Likewise.
8953 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8955 Fix minor problems found by static checking (Bug#9031).
8956 * chartab.c (char_table_set_range, map_sub_char_table):
8957 Remove unused locals.
8958 (uniprop_table): Now static.
8959 * composite.c (_work_char): Remove unused static var.
8961 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
8963 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8965 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8967 * gtkutil.c (qttip_cb): Remove code without function.
8969 2011-07-09 Eli Zaretskii <eliz@gnu.org>
8971 * w32.c (pthread_sigmask): New stub.
8973 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
8975 Use pthread_sigmask, not sigprocmask (Bug#9010).
8976 sigprocmask is portable only for single-threaded applications, and
8977 Emacs can be multi-threaded when it uses GTK.
8978 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8980 * callproc.c (Fcall_process):
8981 * process.c (create_process):
8982 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8983 Use pthread_sigmask, not sigprocmask.
8985 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8987 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8988 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8991 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8993 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8994 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8995 (xg_hide_tooltip): Fix comment.
8997 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8998 in registerServicesMenuSendTypes.
8999 (validRequestorForSendType): Don't check ns_return_types.
9001 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9004 2011-07-08 Jason Rumney <jasonr@gnu.org>
9006 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9007 SH_SHOW for hidden windows (Bug#5482).
9009 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9010 frame struct members of non-existent frames (Bug#6284).
9012 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9014 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9015 variable firstTime not needed on OSX >= 10.6.
9016 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9017 >= 10.5. Use setKnobProportion, setDoubleValue.
9019 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9020 (MAC_OS_X_VERSION_10_5): Define if not defined.
9021 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9022 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9023 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9025 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
9026 cString and lossyCString on OSX >= 10.4.
9028 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
9029 sizeToFit on OSX >= 10.2.
9031 * nsimage.m (allocInitFromFile): Don't use deprecated method
9032 bestRepresentationForDevice on OSX >= 10.6.
9034 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9037 * emacs.c: Declare unexec_init_emacs_zone.
9039 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9041 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9043 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9044 on svcsMenu (Bug#8842).
9046 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9048 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9050 * nsterm.m (QUTF8_STRING): Declare.
9051 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9052 (validRequestorForSendType): Return type is (id).
9053 Change indexOfObjectIdenticalTo to indexOfObject.
9054 Check if we have local selection before returning self (Bug#8842).
9055 (writeSelectionToPasteboard): Put local selection into paste board
9056 if we have a local selection (Bug#8842).
9057 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9059 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9060 (ns_get_local_selection): Declare.
9062 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9064 * keymap.c (describe_map_tree): Don't insert a double newline at
9065 the end of the buffer (bug#1169) and return whether we inserted
9068 * callint.c (Fcall_interactively): Change "reading args" to
9069 "providing args" to try to clarify what it does (bug#1010).
9071 2011-07-07 Kenichi Handa <handa@m17n.org>
9073 * composite.c (composition_compute_stop_pos): Ignore a static
9074 composition starting before CHARPOS (Bug#8915).
9076 * xdisp.c (handle_composition_prop): Likewise.
9078 2011-07-07 Eli Zaretskii <eliz@gnu.org>
9080 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9083 2011-07-07 Kenichi Handa <handa@m17n.org>
9085 * character.h (unicode_category_t): New enum type.
9087 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9088 (Qchar_code_property_table): New variable.
9089 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9090 (UNIPROP_COMPRESSED_FORM_P): New macros.
9091 (char_table_ascii): Uncompress the compressed values.
9092 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9093 Uncompress the compressed values.
9094 (sub_char_table_ref_and_range): Likewise.
9095 (char_table_ref_and_range): Uncompress the compressed values.
9096 (sub_char_table_set): New arg is_uniprop. Callers changed.
9097 Uncompress the compressed values.
9098 (sub_char_table_set_range): Args changed. Callers changed.
9099 (char_table_set_range): Adjuted for the above change.
9100 (map_sub_char_table): Delete args default_val and parent. Add arg
9101 top. Give decoded values to a Lisp function.
9102 (map_char_table): Adjust for the above change. Give decoded
9103 values to a Lisp function. Gcpro more variables.
9104 (uniprop_table_uncompress)
9105 (uniprop_decode_value_run_length): New functions.
9106 (uniprop_decoder, uniprop_decoder_count): New variables.
9107 (uniprop_get_decoder, uniprop_encode_value_character)
9108 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9110 (uniprop_encoder, uniprop_encoder_count): New variables.
9111 (uniprop_get_encoder, uniprop_table)
9112 (Funicode_property_table_internal, Fget_unicode_property_internal)
9113 (Fput_unicode_property_internal): New functions.
9114 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9115 Sunicode_property_table_internal, Sget_unicode_property_internal,
9116 and Sput_unicode_property_internal. Defvar_lisp
9117 char-code-property-alist.
9119 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
9120 Vunicode_category_table.
9122 * font.c (font_range): Adjust for the change of
9123 Vunicode_category_table.
9125 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9127 * m/iris4d.h: Remove file, move contents ...
9128 * s/irix6-5.h: ... here.
9130 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9132 Remove unportable assumption about struct layout (Bug#8884).
9133 * alloc.c (mark_buffer):
9134 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9135 (clone_per_buffer_values): Don't assume that
9136 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9137 This isn't true in general, and it's particularly not true
9138 if Emacs is configured with --with-wide-int.
9139 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9140 New macros, used in the buffer.c change.
9142 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9144 * xsettings.c: Use both GConf and GSettings if both are available.
9145 (store_config_changed_event): Add comment.
9146 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9147 (store_tool_bar_style_changed): New functions.
9148 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
9149 (struct xsettings): Move font inside HAVE_XFT.
9150 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
9151 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
9152 Move inside HAVE_XFT.
9153 (something_changed_gsettingsCB): Rename from something_changedCB.
9154 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9156 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
9157 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
9158 (something_changed_gconfCB): Rename from something_changedCB.
9159 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9160 (parse_settings): Move check for font inside HAVE_XFT.
9161 (read_settings, apply_xft_settings): Add comment.
9162 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9163 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9164 call store_font_name_changed.
9165 (xft_settings_event): Add comment.
9166 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9167 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9168 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9169 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9170 (xsettings_initialize): Call init_gsettings last.
9171 (xsettings_get_system_font, xsettings_get_system_normal_font):
9174 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9176 Random fixes. E.g., (random) never returned negative values.
9177 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9178 subseconds part to the entropy, as that's a bit more random.
9179 Prefer signed to unsigned, since the signedness doesn't matter and
9180 in general we prefer signed. When given a limit, use a
9181 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9182 latter isn't right if USE_2_TAGS_FOR_INTS.
9183 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9184 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9186 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9188 * textprop.c (text_property_stickiness):
9189 Obey Vtext_property_default_nonsticky.
9190 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9191 * w32fns.c (syms_of_w32fns):
9192 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9194 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9196 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9197 This is more efficient than Ffile_directory_p and avoids a minor race.
9199 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9201 * buffer.c (Foverlay_put): Say what the return value is
9204 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9205 is a directory before asking whether to use the file name
9207 (barf_or_query_if_file_exists): Make the "File is a directory"
9208 error be more correct.
9210 * fns.c (Frequire): Remove the mention of the .gz files, since
9211 that's installation-specific, but keep the mention of
9212 `get-load-suffixes'.
9214 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9216 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9217 Report string overflow if the output is too long.
9219 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
9221 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9222 (syms_of_gnutls): Remove duplicate DEFSYM for
9223 Qgnutls_bootprop_verify_hostname_error, an error for
9224 Qgnutls_bootprop_verify_error (which is no longer used).
9226 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9227 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9228 Also (re)move comments that are misplaced or no longer relevant.
9230 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9232 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9234 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
9236 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9237 and background color parameters if they have been changed.
9239 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9241 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9243 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9245 * xsettings.c (SYSTEM_FONT): Define only when used.
9246 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9248 * keymap.c (access_keymap_1): Now static.
9250 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
9252 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9253 leave any prefix arg for the up event (Bug#1586).
9255 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9257 * lread.c (syms_of_lread): Mention single symbols defined by
9258 `defvar' or `defconst' (bug#7154).
9260 * fns.c (Frequire): Mention .el.gz files (bug#7314).
9261 (Frequire): Mention get-load-suffixes.
9263 2011-07-02 Martin Rudalics <rudalics@gmx.at>
9265 * window.h (window): Remove clone_number slot.
9266 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9268 (make_parent_window, make_window, saved_window)
9269 (Fset_window_configuration, save_window_save): Don't deal with
9271 * buffer.c (Qclone_number): Remove declaration.
9272 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9274 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9276 Add multiple inheritance to keymaps.
9277 * keymap.c (Fmake_composed_keymap): New function.
9278 (Fset_keymap_parent): Simplify.
9279 (fix_submap_inheritance): Remove.
9280 (access_keymap_1): New function extracted from access_keymap to handle
9281 embedded parents and handle lists of maps.
9282 (access_keymap): Use it.
9283 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9284 (Fcopy_keymap): Handle embedded parents.
9285 (Fcommand_remapping, define_as_prefix): Simplify.
9286 (Fkey_binding): Simplify.
9287 (syms_of_keymap): Move minibuffer-local-completion-map,
9288 minibuffer-local-filename-completion-map,
9289 minibuffer-local-must-match-map, and
9290 minibuffer-local-filename-must-match-map to Elisp.
9291 (syms_of_keymap): Defsubr make-composed-keymap.
9292 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9293 (parse_menu_item): Trivial simplification.
9295 2011-07-01 Glenn Morris <rgm@gnu.org>
9297 * Makefile.in (SETTINGS_LIBS): Fix typo.
9299 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9301 * coding.c (Fencode_coding_string): Record the last coding system
9302 used, as the function doc string says (bug#8738).
9304 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9306 * xsettings.c (store_monospaced_changed): Take new font as arg and
9307 check for change against current_mono_font.
9308 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9309 (emacs_settings_constructor, emacs_settings_get_property)
9310 (emacs_settings_set_property, emacs_settings_class_init)
9311 (emacs_settings_init, gsettings_obj): Remove.
9312 (something_changedCB): New function for HAVE_GSETTINGS.
9313 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9314 with value as argument.
9315 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9316 g_settings_new (Bug#8967). Do not create gsettings_obj.
9317 Remove calls to g_settings_bind. Connect something_changedCB to
9320 * xgselect.c: Add defined (HAVE_GSETTINGS).
9321 (xgselect_initialize): Ditto.
9323 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9324 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9327 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9329 * eval.c (struct backtrace): Simplify and port the data structure.
9330 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9331 signed bit field, as this assumption is not portable and it makes
9332 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9333 "char debug_on_exit : 1" as this is not portable either; instead,
9334 use the portable "unsigned int debug_on_exit : 1". Remove unused
9335 member evalargs. Remove obsolete comments about cc bombing out.
9337 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9339 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9340 Let HAVE_GSETTINGS override HAVE_GCONF.
9341 (store_monospaced_changed): New function.
9342 (EMACS_SETTINGS): A new type derived from GObject to handle
9343 GSettings notifications.
9344 (emacs_settings_constructor, emacs_settings_get_property)
9345 (emacs_settings_set_property, emacs_settings_class_init):
9347 (gsettings_client, gsettings_obj): New variables.
9348 (GSETTINGS_SCHEMA): New define.
9349 (something_changedCB): Call store_monospaced_changed.
9350 (init_gsettings): New function.
9351 (xsettings_initialize): Call init_gsettings.
9352 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9355 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9358 2011-06-29 Martin Rudalics <rudalics@gmx.at>
9360 * window.c (resize_root_window, grow_mini_window)
9361 (shrink_mini_window): Rename Qresize_root_window to
9362 Qwindow_resize_root_window and Qresize_root_window_vertically to
9363 Qwindow_resize_root_window_vertically.
9365 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9367 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9369 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
9371 * makefile.w32-in: Redesign dependencies so they reflect more
9372 clearly which files are directly included by each source file,
9373 and not through other includes.
9375 2011-06-27 Martin Rudalics <rudalics@gmx.at>
9377 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9378 (sort_overlays, overlay_strings): When an overlay's clone number
9379 matches the window's clone number process the overlay even if
9380 the overlay's window property doesn't match the current window.
9382 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9383 (Fwindow_hchild): Rename to Fwindow_left_child.
9384 (Fwindow_next): Rename to Fwindow_next_sibling.
9385 (Fwindow_prev): Rename to Fwindow_prev_sibling.
9386 (resize_window_check): Rename to window_resize_check.
9387 (resize_window_apply): Rename to window_resize_apply.
9388 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9389 (Fdelete_other_windows_internal, resize_frame_windows)
9390 (Fsplit_window_internal, Fdelete_window_internal)
9391 (grow_mini_window, shrink_mini_window)
9392 (Fresize_mini_window_internal): Fix callers accordingly.
9394 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9396 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9397 (emacs_fixed_set_min_size): Remove.
9398 (emacs_fixed_new): Take frame as argument.
9400 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9401 (_EmacsFixedPrivate): Remove minwidth/height.
9402 Add struct frame *f.
9403 (emacs_fixed_init): Initialize priv->f.
9404 (get_parent_class, emacs_fixed_set_min_size): Remove.
9405 (emacs_fixed_new): Set priv->f to argument.
9406 (emacs_fixed_get_preferred_width)
9407 (emacs_fixed_get_preferred_height): Use min_width/height from
9408 frames size_hint to set minimum and natural (Bug#8919).
9409 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9410 and use min_width/height from frames size_hint to set
9411 min_width/height (Bug#8919).
9413 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9414 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9417 2011-06-26 Eli Zaretskii <eliz@gnu.org>
9419 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9420 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9423 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
9425 * process.c (wait_reading_process_output): Bypass select if
9426 waiting for a cell while ignoring keyboard input, and input is
9427 pending. Suggested by Jan Djärv (Bug#8869).
9429 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9431 Use gnulib's dup2 module instead of rolling our own.
9432 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9434 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9436 * dispnew.c (scrolling_window): Before scrolling, turn off a
9437 mouse-highlight in the window being scrolled.
9439 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
9441 Move DEFSYM to lisp.h and use everywhere.
9443 * character.h (DEFSYM): Move declaration...
9444 * lisp.h (DEFSYM): ...here.
9450 * w32select.c: Don't include character.h.
9452 * alloc.c (syms_of_alloc):
9453 * buffer.c (syms_of_buffer):
9454 * bytecode.c (syms_of_bytecode):
9455 * callint.c (syms_of_callint):
9456 * casefiddle.c (syms_of_casefiddle):
9457 * casetab.c (init_casetab_once):
9458 * category.c (init_category_once, syms_of_category):
9459 * ccl.c (syms_of_ccl):
9460 * cmds.c (syms_of_cmds):
9461 * composite.c (syms_of_composite):
9462 * dbusbind.c (syms_of_dbusbind):
9463 * dired.c (syms_of_dired):
9464 * dispnew.c (syms_of_display):
9465 * doc.c (syms_of_doc):
9466 * editfns.c (syms_of_editfns):
9467 * emacs.c (syms_of_emacs):
9468 * eval.c (syms_of_eval):
9469 * fileio.c (syms_of_fileio):
9470 * fns.c (syms_of_fns):
9471 * frame.c (syms_of_frame):
9472 * fringe.c (syms_of_fringe):
9473 * insdel.c (syms_of_insdel):
9474 * keymap.c (syms_of_keymap):
9475 * lread.c (init_obarray, syms_of_lread):
9476 * macros.c (syms_of_macros):
9477 * msdos.c (syms_of_msdos):
9478 * print.c (syms_of_print):
9479 * process.c (syms_of_process):
9480 * search.c (syms_of_search):
9481 * sound.c (syms_of_sound):
9482 * syntax.c (init_syntax_once, syms_of_syntax):
9483 * terminal.c (syms_of_terminal):
9484 * textprop.c (syms_of_textprop):
9485 * undo.c (syms_of_undo):
9486 * w32.c (globals_of_w32):
9487 * window.c (syms_of_window):
9488 * xdisp.c (syms_of_xdisp):
9489 * xfaces.c (syms_of_xfaces):
9490 * xfns.c (syms_of_xfns):
9491 * xmenu.c (syms_of_xmenu):
9492 * xsettings.c (syms_of_xsettings):
9493 * xterm.c (syms_of_xterm): Use DEFSYM.
9495 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9497 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
9499 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9501 Integer and buffer overflow fixes (Bug#8873).
9503 * print.c (printchar, strout): Check for string overflow.
9504 (PRINTPREPARE, printchar, strout):
9505 Don't set size unless allocation succeeds.
9507 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9508 for sizes. Check for string overflow more accurately.
9509 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9511 * macros.c: Integer and buffer overflow fixes.
9512 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9513 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9514 Use ptrdiff_t, not int, for sizes.
9515 Don't increment bufsize until after realloc succeeds.
9516 Check for size-calculation overflow.
9517 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9519 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9521 * lread.c: Integer overflow fixes.
9522 (read_integer): Radix is now EMACS_INT, not int,
9523 to improve quality of diagnostics for out-of-range radices.
9524 Calculate buffer size correctly for out-of-range radices.
9525 (read1): Check for integer overflow in radices, and in
9526 read-circle numbers.
9527 (read_escape): Avoid int overflow.
9528 (Fload, openp, read_buffer_size, read1)
9529 (substitute_object_recurse, read_vector, read_list, map_obarray):
9530 Use ptrdiff_t, not int, for sizes.
9531 (read1): Use EMACS_INT, not int, for sizes.
9532 Check for size overflow.
9534 * image.c (cache_image): Check for size arithmetic overflow.
9536 * lread.c: Integer overflow issues.
9537 (saved_doc_string_size, saved_doc_string_length)
9538 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9539 Now ptrdiff_t, not int.
9540 (read1): Don't assume doc string length fits in int. Check for
9541 out-of-range doc string lengths.
9542 (read_list): Don't assume file position fits in int.
9543 (read_escape): Check for hex character overflow.
9545 2011-06-22 Leo Liu <sdl.web@gmail.com>
9547 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9548 Move to minibuffer.el.
9550 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9552 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
9553 The following patches are for when GLYPH_DEBUG && !XASSERT.
9554 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9555 * dispnew.c (flush_stdout):
9556 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9557 Mark as externally visible.
9558 * dispnew.c (check_window_matrix_pointers): Now static.
9559 * dispnew.c (window_to_frame_vpos):
9560 * xfns.c (unwind_create_frame):
9561 * xterm.c (x_check_font): Remove unused local.
9562 * scroll.c (CHECK_BOUNDS):
9563 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9564 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9565 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9566 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9567 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9569 (debug_method_add): Use va_list and vsprintf rather than relying
9570 on undefined behavior with wrong number of arguments.
9571 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9572 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9573 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9574 since we're not interested in debugging glyphs with old libraries.
9575 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9576 GCC 4.6.0's static checking.
9578 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9580 Integer overflow and signedness fixes (Bug#8873).
9581 A few related buffer overrun fixes, too.
9583 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9585 * dispextern.h (struct face.stipple):
9586 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9587 (x_bitmap_mask, x_allocate_bitmap_record)
9588 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9589 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9590 (x_create_bitmap_from_xpm_data):
9591 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9592 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9594 * xfaces.c (load_pixmap):
9595 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9596 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9597 (.bitmaps_last, struct x_output.icon_bitmap):
9598 Use ptrdiff_t, not int, for bitmap indexes.
9599 (x_allocate_bitmap_record): Check for size overflow.
9600 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9602 Use ptrdiff_t, not int, for overlay counts.
9603 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9604 * editfns.c (overlays_around, get_pos_property):
9605 * textprop.c (get_char_property_and_overlay):
9606 * xdisp.c (next_overlay_change, note_mouse_highlight):
9607 * xfaces.c (face_at_buffer_position):
9608 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9609 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9610 (Fnext_overlay_change, Fprevious_overlay_change)
9611 (mouse_face_overlay_overlaps, Foverlays_in):
9612 Use ptrdiff_t, not int, for sizes.
9613 (overlays_at, overlays_in): Check for size-calculation overflow.
9615 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9617 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9618 (x_session_initialize): Do not assume string length fits in int.
9620 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9621 This is unlikely, but can occur if DPI is outlandish.
9623 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
9624 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9626 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9627 * xrdb.c (magic_file_p, search_magic_path):
9628 Omit last arg SUFFIX; it was always 0. All callers changed.
9629 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9631 * xfont.c (xfont_match): Avoid need for strlen.
9633 * xfns.c: Don't assume strlen fits in int.
9634 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9636 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9637 not unsigned long, as we prefer signed integers. All callers changed.
9638 Detect integer overflow in repeat count.
9639 (message_dolog): Don't assume print length fits in 39 bytes.
9640 (display_mode_element): Don't assume strlen fits in int.
9642 * termcap.c: Don't assume sizes fit in int and never overflow.
9643 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9644 (gobble_line): Check for size-calculation overflow.
9646 * minibuf.c (Fread_buffer):
9647 * lread.c (intern, intern_c_string):
9648 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9649 Don't assume string length fits in int.
9651 * keyboard.c (parse_tool_bar_item):
9652 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9654 * font.c: Don't assume string length fits in int.
9655 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9656 Use ptrdiff_t, not int.
9657 (font_intern_prop): Don't assume string length fits in int.
9658 Don't assume integer property fits in fixnum.
9659 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
9661 * filelock.c: Fix some buffer overrun and integer overflow issues.
9662 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
9663 Reformulate so as not to need the command string.
9664 Invoke gzip -cd rather than gunzip, as it's more portable.
9665 (lock_info_type, lock_file_1, lock_file):
9666 Don't assume pid_t and time_t fit in unsigned long.
9667 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9668 (current_lock_owner): Prefer signed type for sizes.
9669 Use memcpy, not strncpy, where memcpy is what is really wanted.
9670 Don't assume (via atoi) that time_t and pid_t fit in int.
9671 Check for time_t and/or pid_t out of range, e.g., via a network share.
9672 Don't alloca where an auto var works fine.
9674 * fileio.c: Fix some integer overflow issues.
9675 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9676 Don't assume string length fits in int.
9677 (directory_file_name): Don't assume string length fits in long.
9678 (make_temp_name): Don't assume pid fits in int, or that its print
9679 length is less than 20.
9681 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9683 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9685 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9687 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9688 We prefer signed integers, even for size calculations.
9690 * emacs.c: Don't assume string length fits in 'int'.
9691 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9692 (main): Don't invoke strlen when not needed.
9694 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9695 (XD_DEBUG_MESSAGE): Don't waste a byte.
9697 * callproc.c (getenv_internal_1, getenv_internal)
9699 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9701 * lread.c (invalid_syntax): Omit length argument.
9702 All uses changed. This doesn't fix a bug, but it simplifies the
9703 code away from its former Hollerith-constant appearance, and it's
9704 one less 'int' to worry about when looking at integer-overflow issues.
9705 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
9707 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9708 This didn't break anything, but it didn't help either.
9709 It's confusing to put a bogus integer in a place where the actual
9710 value does not matter.
9711 (LIST_END_P): Remove unused macro and its bogus comment.
9712 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
9714 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9715 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9717 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9718 We prefer signed types, and the value cannot exceed the EMACS_INT
9719 range anyway (because otherwise the length would not be representable).
9720 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9721 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9722 This avoids a GCC warning when WIDE_EMACS_INT.
9724 * indent.c (sane_tab_width): New function.
9725 (current_column, scan_for_column, Findent_to, position_indentation)
9726 (compute_motion): Use it. This is just for clarity.
9727 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
9729 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
9731 * lisp.h (lint_assume): New macro.
9732 * composite.c (composition_gstring_put_cache):
9733 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9735 * editfns.c, insdel.c:
9736 Omit unnecessary forward decls, to simplify future changes.
9738 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9740 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9742 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
9743 Use much-faster test for byte-length change.
9744 Don't assume string byte-length fits in 'int'.
9745 Check that character arg fits in 'int'.
9746 (mapcar1): Declare byte as byte, for clarity.
9748 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9750 * fns.c (concat): Catch string overflow earlier.
9751 Do not rely on integer wraparound.
9753 * dispextern.h (struct it.overlay_strings_charpos)
9754 (struct it.selective): Now EMACS_INT, not int.
9755 * xdisp.c (forward_to_next_line_start)
9756 (back_to_previous_visible_line_start)
9757 (reseat_at_next_visible_line_start, next_element_from_buffer):
9758 Don't arbitrarily truncate the value of 'selective' to int.
9760 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9762 * composite.c: Don't truncate sizes to 'int'.
9763 (composition_gstring_p, composition_reseat_it)
9764 (composition_adjust_point): Use EMACS_INT, not int.
9765 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9766 not EMACS_UINT, for indexes.
9768 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9770 * buffer.c: Include <verify.h>.
9771 (struct sortvec.priority, struct sortstr.priority):
9772 Now EMACS_INT, not int.
9773 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
9774 (struct sortstr.size, record_overlay_string)
9775 (struct sortstrlist.size, struct sortlist.used):
9776 Don't truncate size to int.
9777 (record_overlay_string): Check for size-calculation overflow.
9778 (init_buffer_once): Check at compile-time, not run-time.
9780 2011-06-22 Jim Meyering <meyering@redhat.com>
9782 Don't leak an XBM-image-sized buffer
9783 * image.c (xbm_load): Free the image buffer after using it.
9785 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9788 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9789 that Sun C diagnosed.
9790 * fns.c (secure_hash): Fix pointer signedness issue.
9791 * intervals.c (static_offset_intervals): New function.
9792 (offset_intervals): Use it.
9794 2011-06-21 Leo Liu <sdl.web@gmail.com>
9797 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9800 * fns.c (secure_hash): Rename from crypto_hash_function and change
9801 the first arg to accept symbols.
9802 (Fsecure_hash): New primitive.
9803 (syms_of_fns): New symbols.
9805 2011-06-20 Deniz Dogan <deniz@dogan.se>
9807 * process.c (Fset_process_buffer): Clarify return value in
9810 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
9812 * dispnew.c (add_window_display_history): Use BVAR.
9814 * xdisp.c (debug_method_add): Use BVAR.
9815 (check_window_end, dump_glyph_matrix, dump_glyph)
9816 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9818 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9821 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9822 check till after the cache is created in init_frame_faces.
9824 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9826 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9828 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9830 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9831 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9832 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9834 Improve buffer-overflow checking (Bug#8873).
9835 * fileio.c (Finsert_file_contents):
9836 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9837 Remove the old (too-loose) buffer overflow checks.
9838 They weren't needed, since make_gap checks for buffer overflow.
9839 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9840 The old code merely checked for Emacs fixnum overflow, and relied
9841 on undefined (wraparound) behavior. The new code avoids undefined
9842 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9844 * editfns.c (Finsert_char): Don't dump core with very negative counts.
9845 Tune. Don't use wider integers than needed. Don't use alloca.
9846 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
9848 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9850 * insdel.c, lisp.h (buffer_overflow): New function.
9851 (insert_from_buffer_1, replace_range, replace_range_2):
9852 * insdel.c (make_gap_larger):
9853 * editfns.c (Finsert_char):
9854 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9856 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9858 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9860 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
9862 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9863 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9865 * fileio.c: Don't assume EMACS_INT fits in off_t.
9866 (emacs_lseek): New static function.
9867 (Finsert_file_contents, Fwrite_region): Use it.
9868 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9870 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9872 * fns.c: Don't overflow int when computing a list length.
9873 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9874 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9875 truncation on 64-bit hosts. Check for QUIT every
9876 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9877 faster and is responsive enough.
9878 (Flength): Report an error instead of overflowing an integer.
9879 (Fsafe_length): Return a float if the value is not representable
9880 as a fixnum. This shouldn't happen except in contrived situations.
9881 (Fnthcdr, Fsort): Don't assume list length fits in int.
9882 (Fcopy_sequence): Don't assume vector length fits in int.
9884 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9885 (header_size, word_size): New constants.
9886 (allocate_vectorlike): Don't check size overflow here.
9887 (allocate_vector): Check it here instead, since this is the only
9888 caller of allocate_vectorlike that could cause overflow.
9889 Check that the new vector's length is representable as a fixnum.
9891 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9892 The previous code was bogus. For example, next_almost_prime (32)
9893 returned 39, which is undesirable as it is a multiple of 3; and
9894 next_almost_prime (24) returned 25, which is a multiple of 5 so
9895 why was the code bothering to check for multiples of 7?
9897 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9899 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9901 Variadic C functions now count arguments with ptrdiff_t.
9902 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9903 Back then I didn't know that the Emacs coding style prefers signed int.
9904 Also, in the meantime I found a few more instances where arguments
9905 were being counted with int, which may truncate counts on 64-bit
9906 machines, or EMACS_INT, which may be unnecessarily wide.
9907 * lisp.h (struct Lisp_Subr.function.aMANY)
9908 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9909 Arg counts are now ptrdiff_t, not size_t.
9910 All variadic functions and their callers changed accordingly.
9911 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9912 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9913 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9914 * callint.c (Fcall_interactively): Check arg count for overflow,
9915 to avoid potential buffer overrun. Use signed char, not 'int',
9916 for 'varies' array, so that we needn't bother to check its size
9917 calculation for overflow.
9918 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9919 * eval.c (apply_lambda):
9920 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9921 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9922 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9924 * callint.c (Fcall_interactively): Don't use index var as event count.
9926 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9927 * mem-limits.h (SIZE): Remove; no longer used.
9929 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
9931 Remove unnecessary casts.
9932 * xterm.c (x_term_init):
9933 * xfns.c (x_set_border_pixel):
9934 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9935 These aren't needed now that we assume ANSI C.
9937 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9938 It's more likely to cause problems (due to unsigned overflow)
9941 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9943 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9945 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9947 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9949 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9951 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9953 GLYPH_CODE_FACE returns EMACS_INT, not int.
9954 * dispextern.h (merge_faces):
9955 * xfaces.c (merge_faces):
9956 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9957 Don't assume EMACS_INT fits in int.
9959 * character.h (CHAR_VALID_P): Remove unused parameter.
9960 * fontset.c, lisp.h, xdisp.c: All uses changed.
9962 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9964 * fns.c (concat): Minor tuning based on overflow analysis.
9965 This doesn't fix any bugs. Use int to hold character, instead
9966 of constantly refetching from Emacs object. Use XFASTINT, not
9967 XINT, for value known to be a character. Don't bother comparing
9968 a single byte to 0400, as it's always less.
9970 * floatfns.c (Fexpt):
9971 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9973 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9976 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9978 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9979 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9980 incorrectly succeed when S was a string, because 4294967386 was
9981 truncated before it was used.
9983 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9984 Otherwise, an out-of-range integer could cause undefined behavior
9987 * composite.c: Use int, not EMACS_INT, for characters.
9988 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9989 EMACS_INT, for values that are known to be in character range.
9990 This doesn't fix any bugs but is the usual style inside Emacs and
9991 may generate better code on 32-bit machines.
9993 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9994 This is for reasons similar to the recent CHAR_STRING fix.
9995 * charset.c (Fencode_char): Check that character arg is actually
9996 a character. Pass an int to ENCODE_CHAR.
9997 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9998 wider than 'int', as a compile-time check to prevent future regressions
10001 * character.c (char_string): Remove unnecessary casts.
10003 Make sure a 64-bit char is never passed to CHAR_STRING.
10004 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10005 by silently ignoring the top 32 bits, allowing some values
10006 that were far too large to be valid characters.
10007 * character.h: Include <verify.h>.
10008 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10009 arguments are no wider than unsigned, as a compile-time check
10010 to prevent future regressions in this area.
10012 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
10013 (Fsubst_char_in_region):
10015 * xdisp.c (decode_mode_spec_coding):
10016 Adjust to CHAR_STRING's new requirement.
10017 * editfns.c (Finsert_char, Fsubst_char_in_region):
10018 * fns.c (concat): Check that character args are actually
10019 characters. Without this test, these functions did the wrong
10020 thing with wildly out-of-range values on 64-bit hosts.
10022 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10023 These casts should not be needed on 32-bit hosts, either.
10024 * keyboard.c (read_char):
10025 * lread.c (Fload): Remove casts to unsigned.
10027 * lisp.h (UNSIGNED_CMP): New macro.
10028 This fixes comparison bugs on 64-bit hosts.
10029 (ASCII_CHAR_P): Use it.
10030 * casefiddle.c (casify_object):
10031 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
10032 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10033 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10034 * dispextern.h (FACE_FROM_ID):
10035 * keyboard.c (read_char): Use UNSIGNED_CMP.
10037 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10038 not to EMACS_INT, to avoid GCC warning.
10040 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10042 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10043 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10044 isn't needed on 32-bit machines.
10046 * buffer.c (Fgenerate_new_buffer_name):
10047 Use EMACS_INT for count, not int.
10048 (advance_to_char_boundary): Return EMACS_INT, not int.
10050 * data.c (Qcompiled_function): Now static.
10052 * window.c (window_body_lines): Now static.
10054 * image.c (gif_load): Rename local to avoid shadowing.
10056 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10057 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10058 * alloc.c (make_save_value): Integer argument is now of type
10059 ptrdiff_t, not int.
10060 (mark_object): Use ptrdiff_t, not int.
10061 * lisp.h (pD): New macro.
10062 * print.c (print_object): Use it.
10064 * alloc.c: Use EMACS_INT, not int, to count objects.
10065 (total_conses, total_markers, total_symbols, total_vector_size)
10066 (total_free_conses, total_free_markers, total_free_symbols)
10067 (total_free_floats, total_floats, total_free_intervals)
10068 (total_intervals, total_strings, total_free_strings):
10069 Now EMACS_INT, not int. All uses changed.
10070 (Fgarbage_collect): Compute overall total using a double, so that
10071 integer overflow is less likely to be a problem. Check for overflow
10072 when converting back to an integer.
10073 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10074 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10075 These were 'int' variables that could overflow on 64-bit hosts;
10076 they were never used, so remove them instead of repairing them.
10077 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
10078 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10079 Previously, this ceilinged at INT_MAX, but that doesn't work on
10081 (allocate_pseudovector): Don't use EMACS_INT when int would do.
10083 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
10084 (allocate_vectorlike): Check for ptrdiff_t overflow.
10085 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10086 when a (possibly-narrower) signed value would do just as well.
10087 We prefer using signed arithmetic, to avoid comparison confusion.
10089 * alloc.c: Catch some string size overflows that we were missing.
10090 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10091 for convenience in STRING_BYTES_MAX.
10092 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10093 The definition here is exact; the one in lisp.h was approximate.
10094 (allocate_string_data): Check for string overflow. This catches
10095 some instances we weren't catching before. Also, it catches
10096 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10097 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10098 and ptrdiff_t and EMACS_INT are both 64 bits.
10100 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10101 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
10102 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
10104 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10106 * alloc.c (Fmake_string): Check for out-of-range init.
10108 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10110 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10112 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10114 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10115 xg_get_default_scrollbar_width.
10117 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10118 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10119 (style_changed_cb): Call update_theme_scrollbar_width and call
10120 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10121 all frames (Bug#8505).
10122 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10123 Call gtk_window_set_resizable if HAVE_GTK3.
10124 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10125 and height if HAVE_GTK3 (Bug#8505).
10126 (scroll_bar_width_for_theme): New variable.
10127 (update_theme_scrollbar_width): New function.
10128 (xg_get_default_scrollbar_width): Move code to
10129 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10130 (xg_initialize): Call update_theme_scrollbar_width.
10132 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10134 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10136 2011-06-12 Martin Rudalics <rudalics@gmx.at>
10138 * frame.c (make_frame): Call other_buffer_safely instead of
10141 * window.c (temp_output_buffer_show): Call display_buffer with
10142 second argument Vtemp_buffer_show_specifiers and reset latter
10143 immediately after the call.
10144 (Vtemp_buffer_show_specifiers): New variable.
10145 (auto_window_vscroll_p, next_screen_context_lines)
10146 (Vscroll_preserve_screen_position): Remove leading asterisks from
10149 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
10151 Fix minor problems found by GCC 4.6.0 static checking.
10152 * buffer.c (Qclone_number): Remove for now, as it's unused.
10153 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10154 (record_buffer): Remove unused local.
10155 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10156 (set_frame_buffer_list): Remove; unused.
10157 * frame.h (other_visible_frames): Remove decl.
10158 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10159 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10160 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10162 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10163 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10164 Define only if HAVE_GPM.
10165 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10166 (update_hints_inhibit): Remove; never set. All uses removed.
10167 * widgetprv.h (emacsFrameClassRec): Remove decl.
10168 * window.c (delete_deletable_window): Now returns void, since it
10169 wasn't returning anything.
10170 (compare_window_configurations): Remove unused locals.
10171 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10172 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
10173 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10174 the same widths as pointers. This follows up on the 2011-05-06 patch.
10175 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10176 * xterm.h: Likewise.
10177 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10179 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
10181 * makefile.w32-in: Update dependencies.
10182 (LISP_H): Add lib/intprops.h.
10184 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10186 * image.c (gif_load): Add animation frame delay to the metadata.
10187 (syms_of_image): Use DEFSYM. New symbol `delay'.
10189 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10191 * window.c (delete_deletable_window): Re-add.
10192 (Fset_window_configuration): Rewrite to handle dead buffers and
10193 consequently deletable windows.
10194 (window_tree, Fwindow_tree): Remove. Supply functionality in
10196 (compare_window_configurations): Simplify code.
10198 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10200 * image.c (imagemagick_load_image): Fix type mismatch.
10201 (Fimagemagick_types): Likewise.
10203 * window.h (replace_buffer_in_windows): Declare.
10205 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10207 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10208 Qclone_number. Remove external declaration of Qdelete_window.
10209 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10211 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10212 Run Qbuffer_list_update_hook if allowed.
10213 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10214 buffer list implementation.
10215 (other_buffer_safely): New function.
10216 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10217 calls to replace_buffer_in_windows and
10218 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10220 (record_buffer): Inhibit quitting and rewrite using quittable
10221 functions. Run Qbuffer_list_update_hook if allowed.
10222 (Frecord_buffer, Funrecord_buffer): New functions.
10223 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10224 Move switch-to-buffer to window.el.
10225 (bury-buffer): Move to window.el.
10226 (Vbuffer_list_update_hook): New variable.
10228 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10231 * window.h (resize_frame_windows): Move up in code.
10232 (Fwindow_frame): Remove EXFUN.
10233 (replace_buffer_in_all_windows): Remove prototype.
10234 (replace_buffer_in_windows_safely): Add prototype.
10236 * window.c: Declare Qdelete_window static again. Move down
10237 declaration of select_count.
10238 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10239 (Fother_window): Move to window.el.
10240 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10241 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10242 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10244 (replace_buffer_in_windows): Implement by calling
10245 Qreplace_buffer_in_windows.
10246 (replace_buffer_in_all_windows): Remove with some functionality
10247 moved into replace_buffer_in_windows_safely.
10248 (replace_buffer_in_windows_safely): New function.
10249 (select_window_norecord, select_frame_norecord): Move in front
10250 of run_window_configuration_change_hook. Remove now obsolete
10252 (Fset_window_buffer): Rewrite doc-string.
10253 Call Qrecord_window_buffer.
10254 (keys_of_window): Move binding for other-window to window.el.
10256 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10258 * dispextern.h (struct image): Replace data member, whose int_val
10259 and ptr_val fields were not used by anything, with a single
10262 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10263 (gif_clear_image, gif_load, imagemagick_load_image)
10264 (gs_clear_image, gs_load): Callers changed.
10266 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10268 * buffer.h: Include <time.h>, for time_t.
10269 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10271 Fix minor problems found by static checking.
10273 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10275 Make identifiers static if they are not used in other modules.
10276 * data.c (Qcompiled_function, Qframe, Qvector):
10277 * image.c (QimageMagick, Qsvg):
10278 * minibuf.c (Qmetadata):
10279 * window.c (resize_window_check, resize_root_window): Now static.
10280 * window.h (resize_window_check, resize_root_window): Remove decls.
10282 * window.c (window_deletion_count, delete_deletable_window):
10284 (window_body_lines): Now static.
10285 (Fdelete_other_windows_internal): Mark vars as initialized.
10286 Make sure 'resize_failed' is initialized.
10287 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10288 (resize_window_apply): Remove unused local.
10289 * window.h (delete_deletable_window): Remove decl.
10291 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
10292 (imagemagick_load_image): Fix pointer signedness problem by changing
10293 last arg from unsigned char * to char *. All uses changed.
10294 Also, fix a local for similar reasons.
10295 Remove unused locals. Remove locals to avoid shadowing.
10296 (fn_rsvg_handle_free): Remove; unused.
10297 (svg_load, svg_load_image): Fix pointer signedness problem.
10298 (imagemagick_load_image): Don't use garbage pointer image_wand.
10300 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10302 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
10304 * image.c (gif_load): Fix omitted cast error introduced by
10307 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10309 * window.h (resize_proportionally, orig_total_lines)
10310 (orig_top_line): Remove from window structure.
10311 (set_window_height, set_window_width, change_window_heights)
10312 (Fdelete_window): Remove prototypes.
10313 (resize_frame_windows): Remove duplicate declaration.
10315 2011-06-10 Eli Zaretskii <eliz@gnu.org>
10317 * window.h (resize_frame_windows, resize_window_check)
10318 (delete_deletable_window, resize_root_window)
10319 (resize_frame_windows): Declare prototypes.
10321 * window.c (resize_window_apply): Make definition be "static" to
10322 match the prototype.
10324 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10326 * window.c: Remove declarations of Qwindow_size_fixed,
10327 window_min_size_1, window_min_size_2, window_min_size,
10328 size_window, window_fixed_size_p, enlarge_window, delete_window.
10329 Remove static from declaration of Qdelete_window, it's
10330 temporarily needed by Fbury_buffer.
10331 (replace_window): Don't assign orig_top_line and
10333 (Fdelete_window, delete_window): Remove. Window deletion is
10334 handled by window.el.
10335 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10336 Replace Fdelete_window calls with calls to Qdelete_window.
10337 (Fdelete_other_windows): Remove. Deleting other windows is
10338 handled by window.el.
10339 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10340 handled in window.el.
10341 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10342 Window minimum sizes are handled in window.el.
10343 (shrink_windows, size_window, set_window_height)
10344 (set_window_width, change_window_heights, window_height)
10345 (window_width, CURBEG, CURSIZE, enlarge_window)
10346 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10347 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10348 handled in window.el.
10349 (make_dummy_parent): Rename to make_parent_window and give it a
10350 second argument horflag.
10351 (make_window): Don't set resize_proportionally any more.
10352 (Fsplit_window): Remove. Windows are split in window.el.
10353 (save_restore_action, save_restore_orig_size)
10354 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10355 Resize mini windows in window.el.
10356 (grow_mini_window, shrink_mini_window): Implement by calling
10357 Qresize_root_window_vertically, resize_window_check and
10358 resize_window_apply.
10359 (saved_window, Fset_window_configuration, save_window_save):
10360 Do not handle orig_top_line, orig_total_lines, and
10361 resize_proportionally.
10362 (window_min_height, window_min_width): Move to window.el.
10363 (keys_of_window): Move bindings for delete-other-windows,
10364 split-window, delete-window and enlarge-window to window.el.
10366 * buffer.c: Temporarily extern Qdelete_window.
10367 (Fbury_buffer): Temporarily call Qdelete_window instead of
10368 Fdelete_window (Fbury_buffer will move to window.el soon).
10370 * frame.c (set_menu_bar_lines_1): Remove code handling
10371 orig_top_line and orig_total_lines.
10373 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10374 set_window_height but set heights directly.
10375 (change_frame_size_1): Use resize_frame_windows.
10377 * xdisp.c (init_xdisp): Don't use set_window_height but set
10380 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10381 Use resize_frame_windows instead of change_window_heights and run
10382 run_window_configuration_change_hook.
10384 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10385 instead of change_window_heights and run
10386 run_window_configuration_change_hook.
10388 2011-06-09 Martin Rudalics <rudalics@gmx.at>
10390 * window.c (replace_window): Rename second argument REPLACEMENT to
10391 NEW. New third argument SETFLAG. Rewrite.
10392 (delete_window, make_dummy_parent): Call replace_window with
10394 (window_list_1): Move down in code.
10395 (run_window_configuration_change_hook): Move set_buffer part
10396 before select_frame_norecord part in order to unwind correctly.
10397 Rename count1 to count.
10398 (recombine_windows, delete_deletable_window, resize_root_window)
10399 (Fdelete_other_windows_internal)
10400 (Frun_window_configuration_change_hook, make_parent_window)
10401 (resize_window_check, resize_window_apply, Fresize_window_apply)
10402 (resize_frame_windows, Fsplit_window_internal)
10403 (Fdelete_window_internal, Fresize_mini_window_internal):
10405 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10407 2011-06-08 Martin Rudalics <rudalics@gmx.at>
10409 * window.h (window): Add some new members to window structure -
10410 normal_lines, normal_cols, new_total, new_normal, clone_number,
10411 splits, nest, prev_buffers, next_buffers.
10412 (WINDOW_TOTAL_SIZE): Move here from window.c.
10413 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
10415 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10417 (make_dummy_parent): Set new members of windows structure.
10418 (make_window): Move down in code. Handle new members of window
10420 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10421 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10422 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10423 (Fset_window_prev_buffers, Fwindow_next_buffers)
10424 (Fset_window_next_buffers, Fset_window_clone_number):
10426 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10427 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10429 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10430 Argument WINDOW can be now internal window too.
10431 (Fwindow_use_time): Move up in code.
10432 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10433 Rewrite doc-string.
10434 (Fset_window_configuration, saved_window)
10435 (Fcurrent_window_configuration, save_window_save): Handle new
10436 members of window structure.
10437 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10438 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10439 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10440 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10441 Qget_mru_window, Qresize_root_window,
10442 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10443 Qauto_buffer_name; staticpro them.
10445 2011-06-07 Martin Rudalics <rudalics@gmx.at>
10447 * window.c (Fwindow_total_size, Fwindow_left_column)
10448 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10449 (Fwindow_list_1): New functions.
10450 (window_box_text_cols): Replace with window_body_cols.
10451 (Fwindow_width, Fscroll_left, Fscroll_right):
10452 Use window_body_cols instead of window_box_text_cols.
10453 (delete_window, Fset_window_configuration):
10454 Call delete_all_subwindows with window as argument.
10455 (delete_all_subwindows): Take a window as argument and not a
10456 structure. Rewrite.
10457 (window_loop): Remove handling of GET_LRU_WINDOW and
10458 GET_LARGEST_WINDOW.
10459 (Fget_lru_window, Fget_largest_window): Move to window.el.
10461 * window.h: Extern window_body_cols instead of
10462 window_box_text_cols. delete_all_subwindows now takes a
10463 Lisp_Object as argument.
10465 * indent.c (compute_motion, Fcompute_motion):
10466 Use window_body_cols instead of window_box_text_cols.
10468 * frame.c (delete_frame): Call delete_all_subwindows with root
10469 window as argument.
10471 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10473 * fns.c (Fputhash): Document return value.
10475 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
10477 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10479 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10481 Cons<->int and similar integer overflow fixes (Bug#8794).
10483 Check for overflow when converting integer to cons and back.
10484 * charset.c (Fdefine_charset_internal, Fdecode_char):
10485 Use cons_to_unsigned to catch overflow.
10486 (Fencode_char): Use INTEGER_TO_CONS.
10487 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10488 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10489 * data.c (long_to_cons, cons_to_long): Remove.
10490 (cons_to_unsigned, cons_to_signed): New functions.
10491 These signal an error for invalid or out-of-range values.
10492 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10493 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10494 * font.c (Ffont_variation_glyphs):
10495 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10496 * lisp.h: Include <intprops.h>.
10497 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10498 (cons_to_signed, cons_to_unsigned): New decls.
10499 (long_to_cons, cons_to_long): Remove decls.
10500 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10501 (Fprimitive_undo): Use CONS_TO_INTEGER.
10502 * xfns.c (Fx_window_property): Likewise.
10503 * xselect.c: Include <limits.h>.
10504 (x_own_selection, selection_data_to_lisp_data):
10505 Use INTEGER_TO_CONS.
10506 (x_handle_selection_request, x_handle_selection_clear)
10507 (x_get_foreign_selection, Fx_disown_selection_internal)
10508 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10509 (lisp_data_to_selection_data): Use cons_to_unsigned.
10510 (x_fill_property_data): Use cons_to_signed.
10511 Report values out of range.
10513 Check for buffer and string overflow more precisely.
10514 * buffer.h (BUF_BYTES_MAX): New macro.
10515 * lisp.h (STRING_BYTES_MAX): New macro.
10516 * alloc.c (Fmake_string):
10517 * character.c (string_escape_byte8):
10518 * coding.c (coding_alloc_by_realloc):
10519 * doprnt.c (doprnt):
10520 * editfns.c (Fformat):
10522 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10523 since they may not be the same number.
10524 * editfns.c (Finsert_char):
10525 * fileio.c (Finsert_file_contents):
10526 Likewise for BUF_BYTES_MAX.
10528 * image.c: Use ptrdiff_t, not int, for sizes.
10529 (slurp_file): Switch from int to ptrdiff_t.
10531 (slurp_file): Check that file size fits in both size_t (for
10532 malloc) and ptrdiff_t (for sanity and safety).
10534 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10535 if b->modtime has its maximal value.
10537 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10539 Don't assume time_t can fit into int.
10540 * buffer.h (struct buffer.modtime): Now time_t, not int.
10541 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10542 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10544 Minor fixes for signed vs unsigned integers.
10545 * character.h (MAYBE_UNIFY_CHAR):
10546 * charset.c (maybe_unify_char):
10547 * keyboard.c (read_char, reorder_modifiers):
10548 XINT -> XFASTINT, since the integer must be nonnegative.
10549 * ftfont.c (ftfont_spec_pattern):
10550 * keymap.c (access_keymap, silly_event_symbol_error):
10551 XUINT -> XFASTINT, since the integer must be nonnegative.
10552 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10553 since it makes no difference and we prefer signed.
10554 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10555 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10558 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10560 * window.h (Fwindow_frame): Declare.
10562 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10564 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10565 (SPARE_MEMORY): Always define.
10566 (LARGE_REQUEST): Remove.
10567 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10569 2011-06-06 Martin Rudalics <rudalics@gmx.at>
10571 * lisp.h: Move EXFUNS for Fframe_root_window,
10572 Fframe_first_window and Fset_frame_selected_window to window.h.
10574 * window.h: Move EXFUNS for Fframe_root_window,
10575 Fframe_first_window and Fset_frame_selected_window here from
10578 * frame.c (Fwindow_frame, Fframe_first_window)
10579 (Fframe_root_window, Fframe_selected_window)
10580 (Fset_frame_selected_window): Move to window.c.
10581 (Factive_minibuffer_window): Move to minibuf.c.
10582 (Fother_visible_frames_p): New function.
10584 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10586 * window.c (decode_window, decode_any_window): Move up in code.
10587 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10588 (inhibit_frame_unsplittable): Remove unused variable.
10589 (Fwindow_buffer): Move up and rewrite doc-string.
10590 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10591 (Fwindow_prev): New functions.
10592 (Fwindow_frame): Move here from frame.c. Accept any window as
10594 (Fframe_root_window, Fframe_first_window)
10595 (Fframe_selected_window): Move here from frame.c. Accept frame
10596 or arbitrary window as argument. Update doc-strings.
10597 (Fminibuffer_window): Move up in code.
10598 (Fwindow_minibuffer_p): Move up in code and simplify.
10599 (Fset_frame_selected_window): Move here from frame.c.
10601 (Fselected_window, select_window, Fselect_window): Move up in
10602 code. Minor doc-string fixes.
10604 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10606 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10607 Do not assume that spare memory exists; that assumption is valid
10608 only if SYSTEM_MALLOC.
10609 (LARGE_REQUEST): New macro, so that the issue of large requests
10610 is separated from the issue of spare memory.
10612 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10614 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10617 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10619 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10622 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10624 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10626 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10628 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10629 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10631 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
10633 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10635 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
10637 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10638 (x_clipboard_manager_save): Add return value.
10639 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10640 New error handlers.
10641 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10642 Obey Vx_select_enable_clipboard_manager. Catch errors in
10643 x_clipboard_manager_save (Bug#8779).
10644 (Vx_select_enable_clipboard_manager): New variable.
10645 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
10647 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
10649 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10651 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10653 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10654 in the current matrix if keep_current_p is non-zero.
10656 2011-06-04 Eli Zaretskii <eliz@gnu.org>
10658 * bidi.c (bidi_level_of_next_char): Fix last change.
10660 2011-06-03 Eli Zaretskii <eliz@gnu.org>
10662 Support bidi reordering of text covered by display properties.
10664 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10665 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10666 (bidi_cache_search, bidi_cache_iterator_state)
10667 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
10668 (bidi_level_of_next_char, bidi_move_to_visually_next):
10669 Support character positions inside a run of characters covered by a
10671 (bidi_paragraph_init, bidi_resolve_explicit_1)
10672 (bidi_level_of_next_char): Call bidi_fetch_char and
10673 bidi_fetch_char_advance instead of FETCH_CHAR and
10674 FETCH_CHAR_ADVANCE.
10675 (bidi_init_it): Initialize new members.
10676 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10678 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10679 instead of using explicit *_CHAR codes.
10680 (bidi_resolve_explicit, bidi_resolve_weak):
10681 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
10682 bidirectional text is supported only in multibyte buffers.
10683 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10684 it to initialize the frame_window_p member of struct bidi_it.
10685 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10686 (bidi_resolve_explicit, bidi_resolve_weak)
10687 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10688 bidi_it->nchars is non-positive.
10689 (bidi_level_of_next_char): Don't try to lookup the cache for the
10690 next/previous character if nothing is cached there yet, or if we
10691 were just reseat()'ed to a new position.
10693 * xdisp.c (set_cursor_from_row): Set start and stop points
10694 according to the row's direction when priming the loop that looks
10695 for the glyph on which to display cursor.
10696 (single_display_spec_intangible_p): Function deleted.
10697 (display_prop_intangible_p): Reimplement to call
10698 handle_display_spec instead of single_display_spec_intangible_p.
10699 Accept 3 additional arguments needed by handle_display_spec.
10700 This fixes incorrect cursor motion across display property with complex
10701 values: lists, `(when COND...)' forms, etc.
10702 (single_display_spec_string_p): Support property values that are
10703 lists with the argument STRING its top-level element.
10704 (display_prop_string_p): Fix the condition for processing a
10705 property that is a list to be consistent with handle_display_spec.
10706 (handle_display_spec): New function, refactored from the
10707 last portion of handle_display_prop.
10708 (compute_display_string_pos): Accept additional argument
10709 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10710 value of a `display' property is a "replacing spec".
10711 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10712 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10713 the display property, but just return a value indicating whether
10714 the display property will replace the characters it covers.
10715 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10716 frame_window_p members of struct bidi_it.
10717 (compute_display_string_pos, compute_display_string_end):
10719 (push_it): Accept second argument POSITION, where pop_it should
10720 jump to continue iteration.
10721 (reseat_1): Initialize bidi_it.disp_pos.
10723 * keyboard.c (adjust_point_for_property): Adjust the call to
10724 display_prop_intangible_p to its new signature.
10726 * dispextern.h (struct bidi_it): New member frame_window_p.
10727 (bidi_init_it): Update prototypes.
10728 (display_prop_intangible_p): Update prototype.
10729 (compute_display_string_pos, compute_display_string_end):
10730 Declare prototypes.
10731 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10734 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
10736 Malloc failure behavior now depends on size of allocation.
10737 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10738 * lisp.h: Change signatures accordingly.
10739 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10740 All callers changed. (Bug#8762)
10742 * gnutls.c: Use Emacs's memory allocators.
10743 Without this change, the gnutls library would invoke malloc etc.
10744 directly, which causes problems on non-SYNC_INPUT hosts, and which
10745 runs afoul of improving memory_full behavior. (Bug#8761)
10746 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10747 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10748 xfree instead of the default malloc, realloc, free.
10749 (Fgnutls_boot): No need to check for memory allocation failure,
10750 since xmalloc does that for us.
10752 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
10753 * category.c (hash_get_category_set):
10754 * ccl.c (ccl_driver):
10755 * charset.c (Fdefine_charset_internal):
10756 * charset.h (struct charset.hash_index):
10757 * composite.c (get_composition_id, gstring_lookup_cache)
10758 (composition_gstring_put_cache):
10759 * composite.h (struct composition.hash_index):
10760 * dispextern.h (struct image.hash):
10761 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10762 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10763 (hashfn_equal, hashfn_user_defined, make_hash_table)
10764 (maybe_resize_hash_table, hash_lookup, hash_put)
10765 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10766 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10767 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10768 * image.c (make_image, search_image_cache, lookup_image)
10769 (xpm_put_color_table_h):
10770 * lisp.h (struct Lisp_Hash_Table):
10771 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
10772 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
10773 for hashes and hash indexes, instead of 'unsigned' and 'int'.
10774 * alloc.c (allocate_vectorlike):
10775 Check for overflow in vector size calculations.
10776 * ccl.c (ccl_driver):
10777 Check for overflow when converting EMACS_INT to int.
10778 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10779 need to be updated by these changes.
10780 * fns.c (make_hash_table, maybe_resize_hash_table):
10781 Check for integer overflow with large hash tables.
10782 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10783 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10784 (SXHASH_REDUCE): New macro.
10785 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10786 Use it instead of discarding useful hash info with large hash values.
10787 (sxhash_float): New function.
10788 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10789 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
10790 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10791 Rewrite to use FIXNUM_BITS, as this simplifies things.
10792 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10793 Adjust signatures to match updated version of code.
10794 (consing_since_gc): Now EMACS_INT, since a single hash table can
10795 use more than INT_MAX bytes.
10797 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10799 Make it possible to build with GCC-4.6+ -O2 -flto.
10801 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10803 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10805 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10806 Call minibuffer-inactive-mode.
10808 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
10810 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10811 Update dependencies.
10813 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10815 * data.c (init_data): Remove code for UTS, this system is not
10818 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10820 Don't force ./temacs to start in terminal mode.
10822 * frame.c (make_initial_frame): Initialize faces in all cases, not
10823 only when CANNOT_DUMP is defined.
10824 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10826 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10828 * dispnew.c (add_window_display_history): Use const for the string
10829 pointer. Remove declaration, not needed.
10831 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10833 Use 'inline', not 'INLINE'.
10834 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
10835 * alloc.c, fontset.c (INLINE): Remove.
10836 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10837 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10838 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10839 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10840 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10842 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10844 Make it possible to run ./temacs.
10846 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10847 syms_of_callproc does the same thing. Remove test for
10848 "initialized", do it in the caller.
10849 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10851 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10853 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10854 (read_minibuf): Use get_minibuffer.
10855 (syms_of_minibuf): Use DEFSYM.
10856 (Qmetadata): New var.
10857 * data.c (Qbuffer): Don't make it static.
10858 (syms_of_data): Use DEFSYM.
10860 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10862 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10863 (CCL_CODE_MIN): New macro.
10865 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10867 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10869 * eval.c (Qdebug): Now static.
10870 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10871 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10872 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10874 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10876 * image.c: Various fixes to ImageMagick code comments.
10877 (Fimagemagick_types): Doc fix.
10879 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10881 Minor fixes prompted by GCC 4.6.0 warnings.
10883 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10885 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10886 (x_clipboard_manager_save_all): Move extern decl to ...
10887 * xterm.h: ... here, so that it can be checked for consistency.
10889 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10891 * xselect.c (x_clipboard_manager_save_frame)
10892 (x_clipboard_manager_save_all): New functions.
10893 (Fx_clipboard_manager_save): Lisp function deleted.
10895 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10896 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10898 * xterm.h: Update prototype.
10900 2011-05-28 William Xu <william.xwl@gmail.com>
10902 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10903 exiting (Bug#8239).
10905 2011-05-28 Jim Meyering <meyering@redhat.com>
10907 Avoid a sign-extension bug in crypto_hash_function.
10908 * fns.c (to_uchar): Define.
10909 (crypto_hash_function): Use it to convert some newly-signed
10910 variables to unsigned, to avoid sign-extension bugs. For example,
10911 without this change, (md5 "truc") would evaluate to
10912 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10913 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
10914 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
10916 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10918 Integer overflow fixes.
10920 * dbusbind.c: Serial number integer overflow fixes.
10921 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
10922 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10923 to hold a serial number that is too large for a fixnum.
10924 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10925 Check for serial numbers out of range. Decode any serial number
10926 that was so large that it became a float. (Bug#8722)
10928 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10929 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10930 Use XFASTINT rather than XUINT when numbers are nonnegative.
10931 (xd_append_arg, Fdbus_method_return_internal):
10932 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10933 arguments, check that Lisp number is nonnegative, rather than
10934 silently wrapping negative numbers around. (Bug#8722)
10935 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
10938 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10940 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10942 ccl: Add integer overflow checks.
10943 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10944 (IN_INT_RANGE): New macros.
10945 (ccl_driver): Use them to check for integer overflow when
10946 decoding a CCL program. Many of the new checks are whether XINT (x)
10947 fits in int; it doesn't always, on 64-bit hosts. The new version
10948 doesn't catch all possible integer overflows, but it's an
10949 improvement. (Bug#8719)
10951 * alloc.c (make_event_array): Use XINT, not XUINT.
10952 There's no need for unsigned here.
10954 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10955 This follows up to the 2011-05-06 change that substituted uintptr_t
10956 for EMACS_INT. This case wasn't caught back then.
10958 Rework Fformat to avoid integer overflow issues.
10959 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10960 now (part of C89). Include <verify.h>.
10961 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10962 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10963 (Fformat): Avoid the prepass trying to compute sizes; it was only
10964 approximate and thus did not catch overflow reliably. Instead, walk
10965 through the format just once, formatting and computing sizes as we go,
10966 checking for integer overflow at every step, and allocating a larger
10967 buffer as needed. Keep track separately whether the format is
10968 multibyte. Keep only the most-recently calculated precision, rather
10969 than them all. Record whether each argument has been converted to
10970 string. Use EMACS_INT, not int, for byte and char and arg counts.
10971 Support field widths and precisions larger than INT_MAX. Avoid
10972 sprintf's undefined behavior with conversion specifications such as %#d
10973 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10974 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10975 formatting out-of-range floating point numbers with int
10976 formats. (Bug#8668)
10978 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10980 * data.c: Avoid integer truncation in expressions involving floats.
10981 * data.c: Include <intprops.h>.
10982 (arith_driver): When there's an integer overflow in an expression
10983 involving floating point, convert the integers to floating point
10984 so that the resulting value does not suffer from catastrophic
10985 integer truncation. For example, on a 64-bit host (* 4
10986 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10987 Do not rely on undefined behavior after integer overflow.
10989 merge count_size_as_multibyte, parse_str_to_multibyte
10990 * character.c, character.h (count_size_as_multibyte):
10991 Rename from parse_str_to_multibyte; all uses changed.
10992 Check for integer overflow.
10993 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10994 since it's now a duplicate of the other. This is more of
10995 a character than a buffer op, so better that it's in character.c.
10996 * fns.c, print.c: Adjust to above changes.
10998 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11000 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11002 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11004 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11005 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11006 (x_clipboard_manager_save): Now static.
11007 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11009 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11010 (crypto_hash_function): Now static.
11011 Fix pointer signedness problems. Avoid unnecessary initializations.
11013 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
11015 * termhooks.h (Vselection_alist): Make it terminal-local.
11017 * terminal.c (create_terminal): Initialize it.
11019 * xselect.c: Support for clipboard managers.
11020 (Vselection_alist): Move to termhooks.h as terminal-local var.
11021 (LOCAL_SELECTION): New macro.
11022 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11023 (symbol_to_x_atom): Remove gratuitous arg.
11024 (x_handle_selection_request, lisp_data_to_selection_data)
11025 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
11026 (x_own_selection, x_get_local_selection, x_convert_selection):
11027 New arg, specifying work frame. Use terminal-local Vselection_alist.
11028 (some_frame_on_display): Delete unused function.
11029 (Fx_own_selection_internal, Fx_get_selection_internal)
11030 (Fx_disown_selection_internal, Fx_selection_owner_p)
11031 (Fx_selection_exists_p): New optional frame arg.
11032 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11033 (x_handle_selection_clear): Don't treat other terminals with the
11034 same keyboard specially. Use the terminal-local Vselection_alist.
11035 (x_clear_frame_selections): Use Frun_hook_with_args.
11037 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11039 * xterm.h: Add support for those atoms.
11041 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
11043 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11044 (converted_selections, conversion_fail_tag): New global variables.
11045 (x_selection_request_lisp_error): Free the above.
11046 (x_get_local_selection): Remove unnecessary code.
11047 (x_reply_selection_request): Args changed; handle arbitrary array
11048 of converted selections stored in converted_selections.
11049 Separate the XChangeProperty and SelectionNotify steps.
11050 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11051 (x_convert_selection): New function.
11052 (x_handle_selection_event): Simplify.
11053 (x_get_foreign_selection): Don't ignore incoming requests while
11054 waiting for an answer; this will fail when we implement
11055 SAVE_TARGETS, and seems unnecessary anyway.
11056 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11057 (Vx_sent_selection_functions): Doc fix.
11059 2011-05-26 Leo Liu <sdl.web@gmail.com>
11061 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11063 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11065 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11067 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11068 for fringe update if it has periodic bitmap.
11069 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
11070 and fringe_bitmap_periodic_p.
11072 * fringe.c (get_fringe_bitmap_data): New function.
11073 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11074 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11075 row. Mark glyph row for fringe update if periodicity changed.
11077 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11078 for fringe update unless it has periodic bitmap.
11080 2011-05-25 Kenichi Handa <handa@m17n.org>
11082 * xdisp.c (get_next_display_element): Set correct it->face_id for
11083 a static composition.
11085 2011-05-24 Leo Liu <sdl.web@gmail.com>
11088 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11090 * fns.c (crypto_hash_function, Fsha1): New function.
11091 (Fmd5): Use crypto_hash_function.
11092 (syms_of_fns): Add Ssha1.
11094 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11096 * gnutls.c: Remove unused macros.
11097 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11098 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11099 Remove macros that are defined and never used.
11100 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11102 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11104 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11105 (Fx_get_selection_internal): Minor cleanup.
11106 (Fx_own_selection_internal): Rename arguments for consistency with
11109 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11111 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11113 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11115 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11117 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11119 * dispnew.c (scrolling_window): Don't exclude the case that the
11120 last enabled row in the desired matrix touches the bottom boundary.
11122 2011-05-21 Glenn Morris <rgm@gnu.org>
11124 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
11125 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11126 and add some more files.
11128 2011-05-20 Eli Zaretskii <eliz@gnu.org>
11130 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11131 report_file_error introduced by the change from 2011-05-07.
11133 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11135 * systime.h (Time): Define only if emacs is defined.
11136 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11137 where the include path doesn't have X11/X.h by default. See
11138 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11140 2011-05-20 Kenichi Handa <handa@m17n.org>
11142 * composite.c (find_automatic_composition): Fix previous change.
11144 2011-05-20 Glenn Morris <rgm@gnu.org>
11146 * lisp.mk: New file, split from Makefile.in.
11147 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11148 (shortlisp): Remove.
11149 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11151 2011-05-19 Glenn Morris <rgm@gnu.org>
11153 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11154 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11155 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11156 (lisp): Set the order to that of loadup.el.
11157 (shortlisp): Make it a copy of $lisp.
11158 (SOME_MACHINE_LISP): Remove.
11159 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11160 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11162 2011-05-18 Kenichi Handa <handa@m17n.org>
11164 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11165 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11166 (find_automatic_composition): Mostly rewrite for efficiency.
11168 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
11170 * makefile.w32-in: Update dependencies.
11172 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11174 * menu.c: Include limits.h (fixes the MS-Windows build broken by
11175 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
11177 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
11179 Fix some integer overflow issues, such as string length overflow.
11181 * insdel.c (count_size_as_multibyte): Check for string overflow.
11183 * character.c (lisp_string_width): Check for string overflow.
11184 Use EMACS_INT, not int, for string indexes and lengths; in
11185 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11186 the resulting string length overflows an EMACS_INT; instead,
11187 report a string overflow if no precision given. When checking for
11188 precision exhaustion, use a check that cannot possibly have
11189 integer overflow. (Bug#8675)
11190 * character.h (lisp_string_width): Adjust to new signature.
11192 * alloc.c (string_overflow): New function.
11193 (Fmake_string): Use it. This doesn't change behavior, but saves
11194 a few bytes and will simplify future changes.
11195 * character.c (string_escape_byte8): Likewise.
11196 * lisp.h (string_overflow): New decl.
11198 Fixups, following up to the user-interface timestamp change.
11199 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11200 for UI timestamps, instead of unsigned long.
11201 * msdos.c (mouse_get_pos): Likewise.
11202 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
11203 * w32gui.h (Time): Define by including "systime.h" rather than by
11204 declaring it ourselves. (Bug#8664)
11206 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11207 * image.c (clear_image_cache): Likewise.
11209 * term.c (term_mouse_position): Don't assume time_t wraparound.
11211 Be more systematic about user-interface timestamps.
11212 Before, the code sometimes used 'Time', sometimes 'unsigned long',
11213 and sometimes 'EMACS_UINT', to represent these timestamps.
11214 This change causes it to use 'Time' uniformly, as that's what X uses.
11215 This makes the code easier to follow, and makes it easier to catch
11216 integer overflow bugs such as Bug#8664.
11217 * frame.c (Fmouse_position, Fmouse_pixel_position):
11218 Use Time, not unsigned long, for user-interface timestamps.
11219 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11220 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11221 * keyboard.h (last_event_timestamp): Likewise.
11222 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11223 * menu.h (xmenu_show): Likewise.
11224 * term.c (term_mouse_position): Likewise.
11225 * termhooks.h (struct input_event.timestamp): Likewise.
11226 (struct terminal.mouse_position_hook): Likewise.
11227 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11228 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11229 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11230 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11231 what it was before.
11232 * menu.h, termhooks.h: Include "systime.h", for Time.
11234 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11235 Don't assume that the difference between two unsigned long values
11236 can fit into an integer. At this point, we know button_down_time
11237 <= event->timestamp, so the difference must be nonnegative, so
11238 there's no need to cast the result if double-click-time is
11239 nonnegative, as it should be; check that it's nonnegative, just in
11240 case. This bug is triggered when events are more than 2**31 ms
11241 apart (about 25 days). (Bug#8664)
11243 * xselect.c (last_event_timestamp): Remove duplicate decl.
11244 (x_own_selection): Remove needless cast to unsigned long.
11246 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11247 that always fit in int. Use a sentinel instead of a counter, to
11248 avoid a temp and to allay GCC's concerns about possible int overflow.
11249 * frame.h (struct frame): Use int for menu_bar_items_used
11250 instead of EMACS_INT, since it always fits in int.
11252 * menu.c (grow_menu_items): Check for int overflow.
11254 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11256 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11257 Before, the code was not consistent. These values cannot exceed
11258 2**31 - 1 so there's no need to make them unsigned.
11259 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11260 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11261 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11263 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11265 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11266 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11267 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11268 presumably because the widths might not match.
11270 * window.c (size_window): Avoid needless test at loop start.
11272 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11274 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11276 2011-05-12 Drew Adams <drew.adams@oracle.com>
11278 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11280 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11282 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11283 `width' to `bar_area_x' and `bar_area_width', respectively.
11284 (x_scroll_run): Take account of fringe background extension.
11286 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11287 Rename local vars `left' and `width' to `bar_area_x' and
11288 `bar_area_width', respectively.
11289 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11290 background extension.
11292 2011-05-10 Jim Meyering <meyering@redhat.com>
11294 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11296 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
11298 * image.c (Finit_image_library): Return t for built-in image types,
11299 like pbm and xbm. (Bug#8640)
11301 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11303 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11305 2011-05-07 Eli Zaretskii <eliz@gnu.org>
11307 * w32console.c (Fset_screen_color): Doc fix.
11308 (Fget_screen_color): New function.
11309 (syms_of_ntterm): Defsubr it.
11311 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11312 unlink the temporary file if Fcall_process didn't create it in the
11314 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11315 child process will be redirected to a file specified with `:file'.
11316 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11317 cue to call_process_cleanup not to close that handle.
11319 2011-05-07 Ben Key <bkey76@gmail.com>
11321 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11322 one of two shell specific rules, either bootstrap-temacs-CMD or
11323 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11324 to the previous implementation of the bootstrap-temacs rule.
11325 The bootstrap-temacs-CMD rule is similar to the previous
11326 implementation of the bootstrap-temacs rule except that it
11327 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11330 These changes, along with some changes to nt/configure.bat,
11331 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11332 earlier fix to add support for --cflags and --ldflags options
11333 that include quotes so that it works whether make uses cmd or
11336 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
11338 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11339 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11341 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11342 a string. Handle both cases.
11343 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11344 (Fdbus_register_method): Use Qinvalid_function.
11346 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11348 * makefile.w32-in: Update dependencies.
11349 (LISP_H): Add inttypes.h and stdin.h.
11350 (PROCESS_H): Add unistd.h.
11352 2011-05-06 Eli Zaretskii <eliz@gnu.org>
11354 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11355 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11357 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
11359 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11361 * term.c (vfatal): Remove stray call to va_end.
11362 It's not needed and the C Standard doesn't allow it here anyway.
11364 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11365 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11367 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11370 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11372 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11374 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11376 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11378 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11380 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11381 * charset.c (Fdefine_charset_internal): Don't initialize
11382 charset.code_space[15]. The value was garbage, on hosts with
11383 32-bit int (Bug#8600).
11385 * lread.c (read_integer): Be more consistent with string-to-number.
11386 Use string_to_number to do the actual conversion; this avoids
11387 rounding errors and fixes some other screwups. Without this fix,
11388 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11389 (digit_to_number): Move earlier, for benefit of read_integer.
11390 Return -1 if the digit is out of range for the base, -2 if it is
11391 not a digit in any supported base. (Bug#8602)
11393 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11395 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11396 to match comment at start of function. This also removes a
11397 GCC warning about overflow in a 32+64-bit port.
11399 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11401 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11402 Reported by Stefan Monnier in
11403 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
11404 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11405 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
11407 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11408 (EMACS_UINTPTR): Likewise, with uintptr_t.
11410 * lisp.h: Prefer 64-bit EMACS_INT if available.
11411 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11412 on 32-bit hosts that have 64-bit int, so that they can access
11414 However, temporarily disable this change unless the temporary
11415 symbol WIDE_EMACS_INT is defined.
11417 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11419 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11420 This removes an assumption that EMACS_INT and long are the same
11421 width as pointers. The assumption is true for Emacs porting targets
11422 now, but we want to make other targets possible.
11423 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11424 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11425 In the rest of the code, change types of integers that hold casted
11426 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11427 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11428 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11429 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11430 No need to cast type when ORing.
11431 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11432 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11433 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11434 assume EMACS_INT is the same width as char *.
11435 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11436 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11437 Remove no-longer-needed casts.
11438 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11439 (xg_tool_bar_help_callback, xg_make_tool_item):
11440 Use EMACS_INTPTR to hold an integer
11441 that will be cast to void *; this can avoid a GCC warning
11442 if EMACS_INT is not the same width as void *.
11443 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11444 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11445 (current_message_1, set_message_1):
11446 Use a local to convert to proper width without a cast.
11447 * xmenu.c (dialog_selection_callback): Likewise.
11449 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11450 Also, don't assume VALBITS / RAND_BITS is less than 5,
11451 and don't rely on undefined behavior when shifting a 1 left into
11453 * lisp.h (get_random): Change signature to match.
11455 * lread.c (hash_string): Use size_t, not int, for hash computation.
11456 Normally we prefer signed values; but hashing is special, because
11457 it's better to use unsigned division on hash table sizes so that
11458 the remainder is nonnegative. Also, size_t is the natural width
11459 for hashing into memory. The previous code used 'int', which doesn't
11460 retain enough info to hash well into very large tables.
11461 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11463 * dbusbind.c: Don't possibly lose pointer info when converting.
11464 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11465 Use XPNTR rather than XHASH, so that the high-order bits of
11466 the pointer aren't lost when converting through void *.
11468 * eval.c (Fautoload): Don't double-shift a pointer.
11470 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11472 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11474 * gnutls.c (DEF_GNUTLS_FN):
11475 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11477 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11479 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11482 2011-05-05 Eli Zaretskii <eliz@gnu.org>
11484 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11485 New version that can reserve upto 2GB of heap space.
11487 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
11489 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11491 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11493 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11494 `gnutls_certificate_set_x509_key_file'.
11496 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
11498 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11499 Update dependencies.
11501 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11503 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11504 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11505 Remove unused parameter `fildes'.
11506 * process.c (read_process_output, send_process): Don't pass it.
11508 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11510 Fix previous change: the library cache is defined in w32.c.
11511 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11512 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11514 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11516 Implement dynamic loading of GnuTLS on Windows.
11518 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11519 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11520 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11523 * gnutls.c (Qgnutls_dll): Define.
11524 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11525 (gnutls_*): Declare function pointers.
11526 (init_gnutls_functions): New function to initialize function pointers.
11527 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11528 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11529 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11530 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11531 (emacs_gnutls_write, emacs_gnutls_read)
11532 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11533 (Fgnutls_available_p): New function.
11534 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11535 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11536 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11538 * image.c: Include w32.h.
11539 (Vimage_type_cache): Delete.
11540 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11541 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11542 (w32_delayed_load): Move to w32.c.
11544 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11546 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11547 (w32_delayed_load): Move from image.c. When loading a library, record
11548 its filename in the :loaded-from property of the library id.
11549 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11550 Initialize and staticpro them.
11551 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11553 * process.c: Include lisp.h before w32.h, not after.
11554 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11555 instead of gnutls_record_check_pending.
11557 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11559 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11561 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11562 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11565 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11567 * xterm.c (x_set_frame_alpha): Do not set property on anything
11568 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11570 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11572 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11574 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11576 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11577 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11578 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11579 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11580 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11581 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11582 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11583 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11584 (Qgnutls_bootprop_callbacks_verify): Make static.
11586 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11588 * callproc.c: Indentation fixup.
11590 * sysdep.c (wait_for_termination_1): Make static.
11591 (wait_for_termination, interruptible_wait_for_termination):
11592 Move after wait_for_termination_1.
11594 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11596 * sysdep.c (interruptible_wait_for_termination): New function
11597 which is like wait_for_termination, but allows keyboard
11600 * callproc.c (Fcall_process): Add (:file "file") as an option for
11602 (Fcall_process_region): Ditto.
11604 2011-04-30 Eli Zaretskii <eliz@gnu.org>
11606 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11607 rather than `XVECTOR (FOO)->size'.
11609 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11610 inttypes.h, as a gnulib replacement is used if it not available in
11613 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11615 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11616 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11617 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11619 * coding.c (coding_alloc_by_realloc): Error out if destination
11620 will grow beyond MOST_POSITIVE_FIXNUM.
11621 (decode_coding_emacs_mule): Abort if there isn't enough place in
11622 charbuf for the composition carryover bytes. Reserve an extra
11623 space for up to 2 characters produced in a loop.
11624 (decode_coding_iso_2022): Abort if there isn't enough place in
11625 charbuf for the composition carryover bytes.
11627 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11629 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11630 aborting when %lld or %lll format is passed.
11631 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11632 %llo or %llx format is passed. (Bug#8545)
11634 * window.c (window_scroll_line_based): Use a marker instead of
11635 simple variables to record original value of point. (Bug#7952)
11637 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11638 produced by %s or %c overflows available buffer space. (Bug#8545)
11640 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11642 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
11643 (SIZE_MAX): Move defn after all includes, as they might #define it.
11645 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11647 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11649 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11651 * keyboard.c (Qdelayed_warnings_hook): Define.
11652 (command_loop_1): Run `delayed-warnings-hook'
11653 if Vdelayed_warnings_list is non-nil.
11654 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11655 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11657 2011-04-28 Eli Zaretskii <eliz@gnu.org>
11659 * doprnt.c (doprnt): Don't return value smaller than the buffer
11660 size if the message was truncated. (Bug#8545).
11662 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11664 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11665 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11667 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11669 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11671 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
11673 * makefile.w32-in: Update dependencies.
11675 2011-04-27 Eli Zaretskii <eliz@gnu.org>
11677 Improve `doprnt' and its usage. (Bug#8545)
11678 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11679 `format_end'. Remove support for %l as a conversion specifier.
11680 Don't use xrealloc. Improve diagnostics when the %l size modifier
11681 is used. Update the commentary.
11683 * eval.c (verror): Simplify calculation of size_t.
11685 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11688 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11690 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11693 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11695 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11696 This makes this file independent of the recent pseudovector change.
11698 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
11700 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11702 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
11703 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
11704 Remove unused local.
11705 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
11707 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
11708 GCC 4.6.0 optimizes based on type-based alias analysis.
11709 For example, if b is of type struct buffer * and v of type struct
11710 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11711 != &v->size, and therefore "v->size = 1; b->size = 2; return
11712 v->size;" must therefore return 1. This assumption is incorrect
11713 for Emacs, since it type-puns struct Lisp_Vector * with many other
11714 types. To fix this problem, this patch adds a new type struct
11715 vectorlike_header that documents the constraints on layout of vectors
11716 and pseudovectors, and helps optimizing compilers not get fooled
11717 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11718 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
11719 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11721 (XSETPVECTYPE): Rewrite in terms of new macro.
11722 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11723 This is a bit clearer, and further avoids the possibility of
11724 undesirable aliasing.
11725 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
11726 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
11727 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11728 since Lisp_Subr is a special case (no "next" field).
11729 (ASIZE): Now uses header.size rather than size.
11730 All previous uses of XVECTOR (foo)->size replaced to use this macro,
11731 to avoid the hassle of writing XVECTOR (foo)->header.size.
11732 (struct vectorlike_header): New type.
11733 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11734 object, to help avoid aliasing.
11735 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11736 (SUBRP): Likewise, since Lisp_Subr is a special case.
11737 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11738 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11739 (struct Lisp_Hash_Table): Combine first two members into a single
11740 struct vectorlike_header member. All uses of "size" and "next" members
11741 changed to be "header.size" and "header.next".
11742 * buffer.h (struct buffer): Likewise.
11743 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11744 * frame.h (struct frame): Likewise.
11745 * process.h (struct Lisp_Process): Likewise.
11746 * termhooks.h (struct terminal): Likewise.
11747 * window.c (struct save_window_data, struct saved_window): Likewise.
11748 * window.h (struct window): Likewise.
11749 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11750 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11751 * buffer.c (init_buffer_once): Likewise.
11752 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11754 * process.c (Fformat_network_address): Use local var for size,
11757 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11759 Make the Lisp reader and string-to-float more consistent (Bug#8525)
11760 * data.c (atof): Remove decl; no longer used or needed.
11761 (digit_to_number): Move to lread.c.
11762 (Fstring_to_number): Use new string_to_number function, to be
11763 consistent with how the Lisp reader treats infinities and NaNs.
11764 Do not assume that floating-point numbers represent EMACS_INT
11765 without losing information; this is not true on most 64-bit hosts.
11766 Avoid double-rounding errors, by insisting on integers when
11767 parsing non-base-10 numbers, as the documentation specifies.
11768 * lisp.h (string_to_number): New decl, replacing ...
11769 (isfloat_string): Remove.
11770 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
11771 (read1): Do not accept +. and -. as integers; this
11772 appears to have been a coding error. Similarly, do not accept
11773 strings like +-1e0 as floating point numbers. Do not report
11774 overflow for integer overflows unless the base is not 10 which
11775 means we have no simple and reliable way to continue.
11776 Break out the floating-point parsing into a new
11777 function string_to_number, so that Fstring_to_number parses
11778 floating point numbers consistently with the Lisp reader.
11779 (digit_to_number): Move here from data.c. Make it static inline.
11780 (E_CHAR, EXP_INT): Remove, replacing with ...
11781 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11782 (string_to_number): New function, replacing isfloat_string.
11783 This function checks for valid syntax and produces the resulting
11784 Lisp float number too. Rework it so that string-to-number
11785 no longer mishandles examples like "1.0e+". Use strtoumax,
11786 so that overflow for non-base-10 numbers is reported only when
11787 there's no portable and simple way to convert to floating point.
11789 * textprop.c (set_text_properties_1): Rewrite for clarity,
11790 and to avoid GCC warning about integer overflow.
11792 * intervals.h (struct interval): Use EMACS_INT for members
11793 where EMACS_UINT might cause problems. See
11794 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11795 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11796 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11798 (offset_intervals): Tell GCC not to worry about length overflow
11799 when negating a negative length.
11801 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11802 (overrun_check_free): Likewise.
11804 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11805 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11808 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11809 (gnutls_make_error): Rename local to avoid shadowing.
11810 (gnutls_emacs_global_deinit): ifdef out; not used.
11811 (Fgnutls_boot): Use const for pointer to readonly storage.
11812 Comment out unused local. Fix pointer signedness problems.
11814 * lread.c (openp): Don't stuff size_t into an 'int'.
11815 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11816 about possible signed overflow.
11818 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11819 (GDK_KEY_g): Don't define if already defined.
11820 (xg_prepare_tooltip): Avoid pointer signedness problem.
11821 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11823 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11824 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11826 * xfns.c (Fx_window_property): Simplify a bit,
11827 to make a bit faster and to avoid GCC 4.6.0 warning.
11828 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11830 * fns.c (internal_equal): Don't assume size_t fits in int.
11832 * alloc.c (compact_small_strings): Tighten assertion a little.
11834 Replace pEd with more-general pI, and fix some printf arg casts.
11835 * lisp.h (pI): New macro, generalizing old pEd macro to other
11836 conversion specifiers. For example, use "...%"pI"d..." rather
11837 than "...%"pEd"...".
11838 (pEd): Remove. All uses replaced with similar uses of pI.
11839 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
11840 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11841 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11842 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11843 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11844 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11845 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11847 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11848 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11849 * print.c (safe_debug_print, print_object): Likewise.
11850 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11852 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11853 avoiding the 0 flag, which is not portable.
11854 * process.c (Fmake_network_process): Use pI to avoid cast.
11855 * region-cache.c (pp_cache): Likewise.
11856 * xdisp.c (decode_mode_spec): Likewise.
11857 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11858 behavior on 64-bit hosts with printf arg.
11859 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
11860 (x_stop_queuing_selection_requests): Likewise.
11861 (x_get_window_property): Don't truncate byte count to an 'int'
11864 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11865 here, since it parses constructs like leading '-' and spaces,
11866 which are not wanted; and it overflows with large numbers.
11867 Instead, simply match F[0-9]+, which is what is wanted anyway.
11869 * alloc.c: Remove unportable assumptions about struct layout.
11870 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11871 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11872 (allocate_vectorlike, make_pure_vector): Use the new macros,
11873 plus offsetof, to remove unportable assumptions about struct layout.
11874 These assumptions hold on all porting targets that I know of, but
11875 they are not guaranteed, they're easy to remove, and removing them
11876 makes further changes easier.
11878 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11879 This doesn't fix a bug but makes the code clearer.
11880 (string_overrun_cookie): Now const. Use initializers that
11881 don't formally overflow signed char, to avoid warnings.
11882 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11883 can cause Emacs to crash when string overrun checking is enabled.
11884 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11885 multiple of sizeof (EMACS_INT); it need not be, if
11886 alignof(EMACS_INT) < sizeof (EMACS_INT).
11887 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
11889 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
11891 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11893 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11895 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
11896 supposed to be handshaking. (Bug#8556)
11897 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11899 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
11901 * lisp.h (Qdebug): List symbol.
11902 * eval.c (Qdebug): Restore global linkage.
11903 * keyboard.c (debug-on-event): New variable.
11904 (handle_user_signal): Break into debugger when debug-on-event
11905 matches the current signal symbol.
11907 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11909 * alloc.c (check_sblock, check_string_bytes)
11910 (check_string_free_list): Convert to standard C.
11912 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11914 * w32.c (emacs_gnutls_push): Fix typo.
11916 2011-04-25 Eli Zaretskii <eliz@gnu.org>
11918 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11919 "cast to pointer from integer of different size".
11921 Improve doprnt and its use in verror. (Bug#8545)
11922 * doprnt.c (doprnt): Document the set of format control sequences
11923 supported by the function. Use SAFE_ALLOCA instead of always
11926 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11927 is one byte too soon. Don't use xrealloc; instead xfree and
11930 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11932 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11935 * gnutls.c: Renamed global_initialized to
11936 gnutls_global_initialized. Added internals for the
11937 :verify-hostname-error, :verify-error, and :verify-flags
11938 parameters of `gnutls-boot' and documented those parameters in the
11939 docstring. Start callback support.
11940 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11941 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11942 on error. Return error code.
11943 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11944 (emacs_gnutls_read): Likewise.
11945 (Fgnutls_boot): Return handshake error code.
11946 (emacs_gnutls_handle_error): New function.
11947 (wsaerror_to_errno): Likewise.
11949 * w32.h (emacs_gnutls_pull): Add prototype.
11950 (emacs_gnutls_push): Likewise.
11952 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11953 (emacs_gnutls_push): Likewise.
11955 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11957 * process.c (wait_reading_process_output): Check if GnuTLS
11958 buffered some data internally if no FDs are set for TLS
11961 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11962 (LIBS): Link to USER_LIBS.
11963 ($(BLD)/gnutls.$(0)): New target.
11965 2011-04-24 Eli Zaretskii <eliz@gnu.org>
11967 * xdisp.c (handle_single_display_spec): Rename the
11968 display_replaced_before_p argument into display_replaced_p, to
11969 make it consistent with the commentary. Fix typos in the
11972 * textprop.c (syms_of_textprop): Remove dead code.
11973 (copy_text_properties): Delete obsolete commentary about an
11974 interface that was deleted long ago. Fix typos in the description
11977 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11978 to changes in oldXMenu/XMenu.h from 2011-04-16.
11979 <menu_help_message, prev_menu_help_message>: Constify.
11980 (IT_menu_make_room): menu->help_text is now `const char **';
11983 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11984 to changes in oldXMenu/XMenu.h from 2011-04-16.
11985 (struct XMenu): Declare `help_text' `const char **'.
11987 * xfaces.c <Qunspecified>: Make extern again.
11989 * syntax.c: Include sys/types.h before including regex.h, as
11992 * doc.c (get_doc_string): Improve the format passed to `error'.
11994 * doprnt.c (doprnt): Improve commentary.
11996 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11998 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12001 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12002 changes in globals.h immediately force recompilation.
12003 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12004 $(CURDIR)/s/ms-w32.h.
12005 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
12007 * character.c (Fchar_direction): Function deleted.
12008 (syms_of_character): Don't defsubr it.
12009 <char-direction-table>: Deleted.
12011 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12013 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12014 * doprnt.c: Include limits.h.
12015 (SIZE_MAX): New macro.
12016 (doprnt): Return a size_t value. 2nd arg is now size_t.
12017 Many local variables are now size_t instead of int or unsigned.
12018 Improve overflow protection. Support `l' modifier for integer
12019 conversions. Support %l conversion. Don't assume an EMACS_INT
12020 argument for integer conversions and for %c.
12022 * lisp.h (doprnt): Restore prototype.
12024 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12025 $(SRC)/character.h.
12027 * Makefile.in (base_obj): Add back doprnt.o.
12029 * deps.mk (doprnt.o): Add back prerequisites.
12030 (callint.o): Depend on character.h.
12032 * eval.c (internal_lisp_condition_case): Include the handler
12033 representation in the error message.
12034 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12035 when breaking from the loop.
12037 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12039 * callint.c (Fcall_interactively): When displaying error message
12040 about invalid control letter, pass the character's codepoint, not
12041 a pointer to its multibyte form. Improve display of the character
12042 in octal and display also its hex code.
12044 * character.c (char_string): Use %x to display the (unsigned)
12045 codepoint of an invalid character, to avoid displaying a bogus
12048 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12049 `error', not SYMBOL_NAME itself.
12051 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12052 character arguments to `error'.
12054 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12055 to `error' in error message about FINAL_CHAR argument. Make sure
12056 FINAL_CHAR is a character, and use %c when it is passed as
12057 argument to `error'.
12059 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12061 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12063 * w32.c: Include <time.h>.
12064 (sys_localtime): New function.
12066 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
12068 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12070 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
12072 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
12074 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12075 zombies (Bug#8467).
12077 2011-04-19 Eli Zaretskii <eliz@gnu.org>
12079 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12080 gl_state.e_property when gl_state.object is Qt.
12082 * insdel.c (make_gap_larger): Remove limitation of buffer size
12085 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
12087 * xdisp.c (lookup_glyphless_char_display)
12088 (produce_glyphless_glyph): Handle cons cell entry in
12089 glyphless-char-display.
12090 (Vglyphless_char_display): Document it.
12092 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12093 glyphless-char-display.
12095 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
12097 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12099 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12101 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12102 definition for no-X builds.
12104 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
12106 Static checks with GCC 4.6.0 and non-default toolkits.
12108 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12110 * process.c (keyboard_bit_set): Define only if SIGIO.
12111 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12112 (send_process): Repair possible setjmp clobbering.
12114 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12116 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12118 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12120 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12121 Define only if needed.
12123 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12124 by pacifying GCC about it. Maybe it's time to retire it?
12125 * xfaces.c (USG, __TIMEVAL__): Likewise.
12127 * dispextern.h (struct redisplay_interface): Rename param
12128 to avoid shadowing.
12129 * termhooks.h (struct terminal): Likewise.
12130 * xterm.c (xembed_send_message): Likewise.
12132 * insdel.c (make_gap_smaller): Define only if
12133 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12135 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12138 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12139 so that we aren't warned about unused symbols.
12141 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12143 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
12145 * xfns.c (x_real_positions): Mark locals as initialized.
12147 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12149 * xterm.c: Fix problems found by static analysis with other toolkits.
12150 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
12151 (x_dispatch_event): Declare static if USE_GTK, and
12152 define if USE_GTK || USE_X_TOOLKIT.
12153 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
12154 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
12155 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12156 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
12158 * xmenu.c (menu_help_callback): Pointer type fixes.
12159 Use const pointers when pointing at readonly data. Avoid pointer
12160 signedness clashes.
12161 (FALSE): Remove unused macro.
12162 (update_frame_menubar): Remove unused decl.
12164 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12166 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12167 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12168 (single_menu_item): Rename local to avoid shadowing.
12170 * keyboard.c (make_lispy_event): Remove unused local var.
12172 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12173 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12175 * bitmaps: Change bitmaps from unsigned char back to the X11
12176 compatible char. Avoid the old compiler warnings about
12177 out-of-range initializers by using, for example, '\xab' rather
12180 * xgselect.c (xgselect_initialize): Check vs interface
12181 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12183 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12185 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12186 to read-only memory.
12188 * fns.c (vector): Remove; this old hack is no longer needed.
12190 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
12192 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
12194 * xrdb.c (x_load_resources): Omit unused local.
12196 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
12197 (x_window): Rename locals to avoid shadowing.
12198 (USG): Use the kludged USG macro, to pacify gcc.
12200 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
12201 (x_term_init): Remove local to avoid shadowing.
12203 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
12205 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12206 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12208 2011-04-16 Eli Zaretskii <eliz@gnu.org>
12210 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12212 Fix regex.c, syntax.c and friends for buffers > 2GB.
12213 * syntax.h (struct gl_state_s): Declare character position members
12216 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12218 * textprop.c (verify_interval_modification, interval_of):
12219 Declare arguments EMACS_INT.
12221 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12224 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12226 * indent.c (Fvertical_motion): Local variable it_start is now
12229 * regex.c (re_match, re_match_2, re_match_2_internal)
12230 (bcmp_translate, regcomp, regexec, print_double_string)
12231 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12232 (re_compile_pattern, re_exec): Declare arguments and local
12233 variables `size_t' and `ssize_t' and return values `regoff_t', as
12235 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12236 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12237 <compile_stack_type>: `size' and `avail' are now `size_t'.
12239 * regex.h <regoff_t>: Use ssize_t, not int.
12240 (re_search, re_search_2, re_match, re_match_2): Arguments that
12241 specify buffer/string position and length are now ssize_t and
12242 size_t. Return type is regoff_t.
12244 2011-04-16 Ben Key <bkey76@gmail.com>
12246 * nsfont.m: Fixed bugs in ns_get_family and
12247 ns_descriptor_to_entity that were caused by using free to
12248 deallocate memory blocks that were allocated by xmalloc (via
12249 xstrdup). This caused Emacs to crash when compiled with
12250 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12251 --enable-checking=xmallocoverrun). xfree is now used to
12252 deallocate these memory blocks.
12254 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
12256 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12258 emacs_write: Accept and return EMACS_INT for sizes.
12259 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12261 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12262 Accept and return EMACS_INT.
12263 (emacs_gnutls_write): Return the number of bytes written on
12265 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
12266 (emacs_read, emacs_write): Remove check for negative size, as the
12267 Emacs source code has been audited now.
12268 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12269 (emacs_read, emacs_write): Use it.
12270 * process.c (send_process): Adjust to the new signatures of
12271 emacs_write and emacs_gnutls_write. Do not attempt to store
12272 a byte offset into an 'int'; it might overflow.
12273 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
12275 * sound.c: Don't assume sizes fit in 'int'.
12276 (struct sound_device.period_size, alsa_period_size):
12277 Return EMACS_INT, not int.
12278 (struct sound_device.write, vox_write, alsa_write):
12279 Accept EMACS_INT, not int.
12280 (wav_play, au_play): Use EMACS_INT to store sizes and to
12281 record read return values.
12283 2011-04-15 Ben Key <bkey76@gmail.com>
12285 * keyboard.c (Qundefined): Don't declare static since it is used
12287 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12288 static since they are used in nsfont.m.
12290 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12292 * process.c (Qprocessp): Don't declare static.
12293 * lisp.h (Qprocessp): Declare again.
12295 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
12297 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12299 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12301 Improve C-level modularity by making more things 'static'.
12303 Don't publish debugger-only interfaces to other modules.
12304 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12305 (verify_bytepos, count_markers): Move decls to the only modules
12307 * region-cache.h (pp_cache): Likewise.
12308 * window.h (check_all_windows): Likewise.
12309 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12311 * sysdep.c (croak): Now static, if
12312 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12313 * syssignal.h (croak): Declare only if not static.
12315 * alloc.c (refill_memory_reserve): Now static if
12316 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12317 * lisp.h (refill_memory_reserve): Declare only if not static.
12319 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12320 Define only if USE_LUCID.
12322 * xrdb.c (x_customization_string, x_rm_string): Now static.
12324 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12325 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12327 * xdisp.c (draw_row_with_mouse_face): Now static.
12328 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12330 * window.h (check_all_windows): Mark externally visible.
12332 * window.c (window_deletion_count): Now static.
12334 * undo.c: Make symbols static if they're not exported.
12335 (last_undo_buffer, last_boundary_position, pending_boundary):
12338 * textprop.c (interval_insert_behind_hooks): Now static.
12339 (interval_insert_in_front_hooks): Likewise.
12341 * term.c: Make symbols static if they're not exported.
12342 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12343 (max_frame_lines, tty_set_terminal_modes):
12344 (tty_reset_terminal_modes, tty_turn_off_highlight):
12345 (get_tty_terminal): Now static.
12346 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12347 * termhooks.h (term_mouse_moveto): Do not declare if
12348 HAVE_WINDOW_SYSTEM.
12349 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12350 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12352 * sysdep.c: Make symbols static if they're not exported.
12353 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12355 (sigprocmask_set, full_mask): Remove; unused.
12356 (wait_debugging): Mark as visible.
12357 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12358 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12360 * syntax.c (syntax_temp): Define only if !__GNUC__.
12362 * sound.c (current_sound_device, current_sound): Now static.
12364 * search.c (searchbufs, searchbuf_head): Now static.
12366 * scroll.c (scroll_cost): Remove; unused.
12367 * dispextern.h (scroll_cost): Remove decl.
12369 * region-cache.h (pp_cache): Mark as externally visible.
12371 * process.c: Make symbols static if they're not exported.
12372 (process_tick, update_tick, create_process, chan_process):
12373 (Vprocess_alist, proc_buffered_char, datagram_access):
12374 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12375 (deactivate_process): Mark defn as static, as well as decl.
12376 * lisp.h (create_process): Remove decl.
12377 * process.h (chan_process, Vprocess_alist): Remove decls.
12379 * print.c: Make symbols static if they're not exported.
12380 (print_depth, new_backquote_output, being_printed, print_buffer):
12381 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12382 (print_interval, print_number_index, initial_stderr_stream):
12384 * lisp.h (Fprinc): Remove decl.
12385 (debug_output_compilation_hack): Mark as externally visible.
12387 * sysdep.c (croak): Move decl from here to syssignal.h.
12388 * syssignal.h (croak): Put it here, so the API can be checked when
12389 'croak' is called from dissociate_if_controlling_tty.
12391 * minibuf.c: Make symbols static if they're not exported.
12392 (minibuf_save_list, choose_minibuf_frame): Now static.
12393 * lisp.h (choose_minibuf_frame): Remove decl.
12395 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12397 * lread.c: Make symbols static if they're not exported.
12398 (read_objects, initial_obarray, oblookup_last_bucket_number):
12400 (make_symbol): Remove; unused.
12401 * lisp.h (initial_obarray, make_symbol): Remove decls.
12403 * keyboard.c: Make symbols static if they're not exported.
12404 (single_kboard, recent_keys_index, total_keys, recent_keys):
12405 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12406 (this_single_command_key_start, echoing, last_auto_save):
12407 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12408 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12409 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12410 (Vlispy_mouse_stem, double_click_count):
12412 (force_auto_save_soon): Define only if SIGDANGER.
12413 (ignore_mouse_drag_p): Now static if
12414 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12415 (print_help): Remove; unused.
12416 (stop_character, last_timer_event): Mark as externally visible.
12417 * keyboard.h (ignore_mouse_drag_p): Declare only if
12418 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12419 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12420 * lisp.h (echoing): Remove decl.
12421 (force_auto_save_soon): Declare only if SIGDANGER.
12422 * xdisp.c (redisplay_window): Simplify code, to make it more
12423 obvious that ignore_mouse_drag_p is not accessed if !defined
12424 USE_GTK && !defined HAVE_NS.
12426 * intervals.c: Make symbols static if they're not exported.
12427 (merge_properties_sticky, merge_interval_right, delete_interval):
12429 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12431 * insdel.c: Make symbols static if they're not exported.
12432 However, leave prepare_to_modify_buffer alone. It's never
12433 called from outside this function, but that appears to be a bug.
12434 (combine_after_change_list, combine_after_change_buffer):
12435 (adjust_after_replace, signal_before_change): Now static.
12436 (adjust_after_replace_noundo): Remove; unused.
12437 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
12438 (signal_before_change): Remove decls.
12440 * indent.c (val_compute_motion, val_vmotion): Now static.
12442 * image.c: Make symbols static if they're not exported.
12443 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12445 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12446 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12448 * fringe.c (standard_bitmaps): Now static.
12449 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12451 * frame.c: Make symbols static if they're not exported.
12452 (x_report_frame_params, make_terminal_frame): Now static.
12453 (get_frame_param): Now static, unless HAVE_NS.
12454 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12455 (x_get_resource_string): Remove; not used.
12456 * frame.h (make_terminal_frame, x_report_frame_params):
12457 (x_get_resource_string); Remove decls.
12458 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12459 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12461 * font.c, fontset.c: Make symbols static if they're not exported.
12462 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12463 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12464 * font.c (font_close_object): Now static.
12465 * font.h (font_close_object): Remove.
12466 * fontset.c (FONTSET_OBJLIST): Remove.
12467 (free_realized_fontset) #if-0 the body, which does nothing.
12468 (face_suitable_for_char_p): #if-0, as it's never called.
12469 * fontset.h (face_suitable_for_char_p): Remove decl.
12470 * xfaces.c (face_at_string_position):
12471 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
12472 since 0 is always ASCII.
12474 * fns.c (weak_hash_tables): Now static.
12476 * fileio.c: Make symbols static if they're not exported.
12477 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12478 (Vwrite_region_annotation_buffers): Now static.
12480 * eval.c: Make symbols static if they're not exported.
12481 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12482 * lisp.h (backtrace_list): Remove decl.
12484 * emacs.c: Make symbols static if they're not exported.
12485 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12486 (fatal_error_code, fatal_error_signal_hook, standard_args):
12488 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12489 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12490 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12491 * lisp.h (fatal_error_signal_hook): Remove decl.
12492 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12494 * editfns.c: Move a (normally-unused) function to its only use.
12495 * editfns.c, lisp.h (get_operating_system_release): Remove.
12496 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12497 worth the hassle of breaking this out.
12499 * xterm.c: Make symbols static if they're not exported.
12500 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12501 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12502 (x_destroy_window, x_delete_display):
12504 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12505 (x_mouse_leave): Remove; unused.
12506 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12507 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12508 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12510 (x_mouse_leave): Declare only if WINDOWSNT.
12511 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12512 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12515 * ftxfont.c: Make symbols static if they're not exported.
12516 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12518 * font.h (ftxfont_driver): Likewise.
12520 * xfns.c: Make symbols static if they're not exported.
12521 (x_last_font_name, x_display_info_for_name):
12522 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12523 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12524 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12525 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12526 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12527 (last_show_tip_args): Now static.
12528 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12529 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12530 (x_screen_planes): Remove; unused.
12531 * dispextern.h (x_screen_planes): Remove decl.
12533 * dispnew.c: Make symbols static if they're not exported.
12534 * dispextern.h (redraw_garbaged_frames, scrolling):
12535 (increment_row_positions): Remove.
12536 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12537 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12539 (redraw_garbaged_frames): Remove; unused.
12541 * xfaces.c: Make symbols static if they're not exported.
12542 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12544 * xterm.h (defined_color): Remove decls.
12545 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12546 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12547 (menu_face_changed_default, defined_color, free_realized_face):
12548 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12549 (ascii_face_of_lisp_face): Remove; unused.
12551 * xdisp.c: Make symbols static if they're not exported.
12552 * dispextern.h (scratch_glyph_row, window_box_edges):
12553 (glyph_to_pixel_coords, set_cursor_from_row):
12554 (get_next_display_element, set_iterator_to_next):
12555 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12556 (show_mouse_face): Remove decls
12557 * frame.h (message_buf_print): Likewise.
12558 * lisp.h (pop_message, set_message, check_point_in_composition):
12560 * xterm.h (set_vertical_scroll_bar): Likewise.
12561 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12562 (message_buf_print, scratch_glyph_row, displayed_buffer):
12563 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12564 (get_next_display_element, show_mouse_face, window_box_edges):
12565 (frame_to_window_pixel_xy, check_point_in_composition):
12566 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12567 (glyph_to_pixel_coords): Remove; unused.
12569 * dired.c (file_name_completion): Now static.
12571 * dbusbind.c (xd_in_read_queued_messages): Now static.
12573 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12574 * data.c (circular_list_error): Remove.
12576 * commands.h (last_point_position, last_point_position_buffer):
12577 (last_point_position_window): Remove decls.
12578 * keyboard.c: Make these variables static.
12580 * coding.h (coding, code_convert_region, encode_coding_gap):
12582 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12583 (iso_code_class, detect_coding, code_convert_region): Now static.
12584 (encode_coding_gap): Remove; unused.
12586 * chartab.c (chartab_chars, chartab_bits): Now static.
12588 * charset.h (charset_iso_8859_1): Remove decl.
12589 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12592 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12593 * ccl.c (Vccl_program_table): Now static.
12594 (check_ccl_update): Remove; unused.
12596 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12597 * category.h: ... from here.
12598 * category.c (check_category_table, set_category_set): Now static.
12600 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12601 * lisp.h: Remove these decls.
12603 * buffer.c (buffer_count): Remove unused var.
12605 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12606 so that it's not optimized away.
12607 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12608 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12609 exported only to the debugger.
12611 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
12612 * atimer.h (run_all_atimers): Remove; not exported.
12614 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12615 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12616 was inaccessible from Lisp.
12617 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12618 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12620 alloc.c: Import and export fewer symbols, and remove unused items.
12621 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12623 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12624 it's not optimized away by whole-program optimization.
12625 (message_enable_multibyte, free_misc): Remove.
12626 (catchlist, handlerlist, mark_backtrace):
12627 Declare only if BYTE_MARK_STACK.
12628 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12629 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12630 (message_enable_multibyte): Remove decl.
12631 (free_misc, interval_free_list, float_block, float_block_index):
12632 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12633 (cons_free_list, last_marked_index):
12635 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12636 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12637 (mark_backtrace): Define only if BYTE_MARK_STACK.
12638 * xdisp.c (message_enable_multibyte): Now static.
12640 Declare Lisp_Object Q* variables to be 'static' if not exported.
12641 This makes it easier for human readers (and static analyzers)
12642 to see whether these variables are used from other modules.
12643 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12644 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12645 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12646 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12647 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12648 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12649 * xmenu.c, xselect.c:
12650 Declare Q* vars static if they are not used in other modules.
12651 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12652 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12653 Remove decls of unexported vars.
12654 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12656 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12658 Make Emacs functions such as Fatom 'static' by default.
12659 This makes it easier for human readers (and static analyzers)
12660 to see whether these functions can be called from other modules.
12661 DEFUN now defines a static function. To make the function external
12662 so that it can be used in other C modules, use the new macro DEFUE.
12663 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12664 (Finit_image_library):
12665 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12666 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12667 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12668 Remove decls, since these functions are now static.
12669 (Funintern, Fget_internal_run_time): New decls, since these functions
12670 were already external.
12672 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12673 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12674 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12675 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12676 * keyboard.c, keymap.c, lread.c:
12677 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12678 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12679 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12680 Mark functions with DEFUE instead of DEFUN,
12681 if they are used in other modules.
12682 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12683 decls for now-static functions.
12684 * buffer.h (Fdelete_overlay): Remove decl.
12685 * callproc.c (Fgetenv_internal): Mark as internal.
12686 * composite.c (Fremove_list_of_text_properties): Remove decl.
12687 (Fcomposition_get_gstring): New forward static decl.
12688 * composite.h (Fcomposite_get_gstring): Remove decl.
12689 * dired.c (Ffile_attributes): New forward static decl.
12690 * doc.c (Fdocumntation_property): New forward static decl.
12691 * eval.c (Ffetch_bytecode): New forward static decl.
12692 (Funintern): Remove extern decl; now in .h file where it belongs.
12693 * fileio.c (Fmake_symbolic_link): New forward static decl.
12694 * image.c (Finit_image_library): New forward static decl.
12695 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12696 * intervals.h (Fprevious_property_change):
12697 (Fremove_list_of_text_properties): Remove decls.
12698 * keyboard.c (Fthis_command_keys): Remove decl.
12699 (Fcommand_execute): New forward static decl.
12700 * keymap.c (Flookup_key): New forward static decl.
12701 (Fcopy_keymap): Now static.
12702 * keymap.h (Flookup_key): Remove decl.
12703 * process.c (Fget_process): New forward static decl.
12704 (Fprocess_datagram_address): Mark as internal.
12705 * syntax.c (Fsyntax_table_p): New forward static decl.
12706 (skip_chars): Remove duplicate decl.
12707 * textprop.c (Fprevious_property_change): New forward static decl.
12708 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12710 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12711 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12713 * editfns.c (Fformat): Remove unreachable code.
12715 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12717 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12720 2011-04-13 Eli Zaretskii <eliz@gnu.org>
12722 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12723 when at ZV. (Bug#8487)
12725 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12727 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12729 * keyboard.c (parse_tool_bar_item): Likewise.
12730 * sound.c (sound_cleanup, alsa_close): Likewise.
12731 * termcap.c (tgetent): Likewise.
12732 * xfns.c (x_default_font_parameter): Likewise.
12733 * xsettings.c (read_and_apply_settings): Likewise.
12735 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12736 (overrun_check_free): Protoize.
12738 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12740 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12741 since callers should never pass a negative size.
12742 Change the signature to match that of plain 'read' and 'write'; see
12743 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12744 * lisp.h: Update prototypes of emacs_write and emacs_read.
12746 2011-04-11 Eli Zaretskii <eliz@gnu.org>
12748 * xdisp.c (redisplay_window): Don't try to determine the character
12749 position of the scroll margin if the window start point w->startp
12750 is outside the buffer's accessible region. (Bug#8468)
12752 2011-04-10 Eli Zaretskii <eliz@gnu.org>
12754 Fix write-region and its subroutines for buffers > 2GB.
12755 * fileio.c (a_write, e_write): Modify declaration of arguments and
12756 local variables to support buffers larger than 2GB.
12757 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12759 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12760 argument, local variables, and return value.
12762 * lisp.h: Update prototypes of emacs_write and emacs_read.
12764 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12766 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
12768 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12770 Fix more problems found by GCC 4.6.0's static checks.
12772 * xdisp.c (vmessage): Use a better test for character truncation.
12774 * charset.c (load_charset_map): <, not <=, for optimization,
12775 and to avoid potential problems with integer overflow.
12776 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
12777 * casetab.c (set_identity, shuffle): Likewise.
12778 * editfns.c (Fformat): Likewise.
12779 * syntax.c (skip_chars): Likewise.
12781 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12782 This also lets GCC 4.6.0 generate slightly better loop code.
12784 * callint.c (Fcall_interactively): <, not <=, for optimization.
12785 (Fcall_interactively): Count the number of arguments produced,
12786 not the number of arguments given. This is simpler and lets GCC
12787 4.6.0 generate slightly better code.
12789 * ftfont.c: Distingish more carefully between FcChar8 and char.
12790 The previous code passed unsigned char * to a functions like
12791 strlen and xstrcasecmp that expect char *, which does not
12792 conform to the C standard.
12793 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12794 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12795 char * when the C standard requires it.
12797 * keyboard.c (read_char): Remove unused var.
12799 * eval.c: Port to Windows vsnprintf (Bug#8435).
12800 Include <limits.h>.
12801 (SIZE_MAX): Define if the headers do not.
12802 (verror): Do not give up if vsnprintf returns a negative count.
12803 Instead, grow the buffer. This ports to Windows vsnprintf, which
12804 does not conform to C99. Problem reported by Eli Zaretskii.
12805 Also, simplify the allocation scheme, by avoiding the need for
12806 calling realloc, and removing the ALLOCATED variable.
12808 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12810 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12811 But keep the doprint source code for now, as we might revamp it
12812 and use it again (Bug#8435).
12813 * lisp.h (doprnt): Remove.
12814 * Makefile.in (base_obj): Remove doprnt.o.
12815 * deps.mk (doprnt.o): Remove.
12817 error: Print 32- and 64-bit integers portably (Bug#8435).
12818 Without this change, on typical 64-bit hosts error ("...%d...", N)
12819 was used to print both 32- and 64-bit integers N, which relied on
12820 undefined behavior.
12821 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
12822 * lisp.h (error, verror): Mark as printf-like functions.
12823 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12824 Report overflow in size calculations when allocating printf buffer.
12825 Do not truncate output string at its first null byte.
12826 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12827 Truncate the output at a character boundary, since vsnprintf does not
12829 * charset.c (check_iso_charset_parameter): Convert internal
12830 character to string before calling 'error', since %c now has the
12832 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12833 overflow when computing char to be passed to 'error'. Do not
12834 pass Lisp_Object to 'error'; pass the integer instead.
12835 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12836 formatted with plain %d.
12838 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12840 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12842 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12844 * xterm.c (x_catch_errors): Remove duplicate declaration.
12846 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12848 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12850 2011-04-10 Jim Meyering <meyering@redhat.com>
12852 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12853 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12854 return ssize_t not "int", and use size_t as the buffer length.
12855 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12856 * gnutls.h: Update declarations.
12857 * process.c (read_process_output): Use ssize_t, to match.
12858 (send_process): Likewise.
12860 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12862 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12864 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12866 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12867 Use unsigned char, to match FcChar8 type definition.
12869 * xterm.c (handle_one_xevent):
12870 * xmenu.c (create_and_show_popup_menu):
12871 * xselect.c (x_decline_selection_request)
12872 (x_reply_selection_request): Avoid type-punned deref of X events.
12874 2011-04-09 Eli Zaretskii <eliz@gnu.org>
12876 Fix some uses of `int' instead of EMACS_INT.
12877 * search.c (string_match_1, fast_string_match)
12878 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12879 (scan_buffer, find_next_newline_no_quit)
12880 (find_before_next_newline, search_command, Freplace_match)
12881 (Fmatch_data): Make some `int' variables be EMACS_INT.
12883 * xdisp.c (display_count_lines): 3rd argument and return value now
12884 EMACS_INT. All callers changed.
12885 (pint2hrstr): Last argument is now EMACS_INT.
12887 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12888 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12889 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12890 (decode_coding_utf_16, decode_coding_emacs_mule)
12891 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12892 (decode_coding_ccl, decode_coding_charset)
12893 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12894 (decode_coding_iso_2022, decode_coding_emacs_mule)
12895 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12896 <char_offset, last_offset>: Declare EMACS_INT.
12897 (encode_coding_utf_8, encode_coding_utf_16)
12898 (encode_coding_emacs_mule, encode_invocation_designation)
12899 (encode_designation_at_bol, encode_coding_iso_2022)
12900 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12901 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12903 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12904 (encode_invocation_designation): Last argument P_NCHARS is now
12906 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12907 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12909 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12912 * ccl.c (Fccl_execute_on_string): Declare some variables
12915 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
12917 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12919 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12921 * process.c (Fformat_network_address): Doc fix.
12923 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12925 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
12927 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
12929 * keyboard.c (read_char): Call Lisp function help-form-show,
12930 instead of using internal_with_output_to_temp_buffer.
12931 (Qhelp_form_show): New var.
12932 (syms_of_keyboard): Use DEFSYM macro.
12934 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12936 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12938 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
12940 * process.c (Flist_processes): Remove to Lisp.
12941 (list_processes_1): Delete.
12943 2011-04-06 Eli Zaretskii <eliz@gnu.org>
12945 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12947 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12949 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
12951 Fix more problems found by GCC 4.6.0's static checks.
12953 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12955 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12957 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
12959 * xdisp.c (vmessage): Mark as a printf-like function.
12961 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12963 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12965 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12966 printf-like functions.
12967 (tiff_load): Add casts to remove these marks before passing them
12968 to system-supplied API.
12970 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12972 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12973 This avoids several warnings with gcc -Wstrict-overflow.
12974 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12975 directly, rather than having caller test rule sign. This avoids
12976 some unnecessary tests.
12977 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12978 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12979 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
12981 * xfont.c (xfont_text_extents): Remove var that was set but not used.
12982 (xfont_open): Avoid unnecessary tests.
12984 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12986 * composite.h, composite.c (composition_gstring_put_cache):
12987 Use EMACS_INT, not int, for length.
12989 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12990 breaking out part of COMPOSITION_DECODE_RULE.
12991 (COMPOSITION_DECODE_RULE): Use it.
12992 * composite.c (get_composition_id): Remove unused local vars,
12993 by using the new macro.
12995 * textprop.c (set_text_properties_1): Change while to do-while,
12996 since the condition is always true at first.
12998 * intervals.c (graft_intervals_into_buffer): Mark var as used.
12999 (interval_deletion_adjustment): Return unsigned value.
13002 * process.c (list_processes_1, create_pty, read_process_output):
13003 (exec_sentinel): Remove vars that were set but not used.
13004 (create_pty): Remove unnecessary "volatile"s.
13005 (Fnetwork_interface_info): Avoid possibility of int overflow.
13006 (read_process_output): Do adaptive read buffering even if carryover.
13007 (read_process_output): Simplify nbytes computation if buffered.
13009 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13011 * syntax.c (scan_words): Remove var that was set but not used.
13012 (update_syntax_table): Use unsigned instead of int.
13014 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
13015 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
13016 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
13018 * print.c (print_error_message): Avoid int overflow.
13020 * font.c (font_list_entities): Redo for clarity,
13021 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13023 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
13024 (font_score): Avoid potential overflow in diff calculation.
13026 * fns.c (substring_both): Remove var that is set but not used.
13027 (sxhash): Redo loop for clarity and to avoid wraparound warning.
13029 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13031 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13032 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13033 can always succeed if overflow has undefined behavior.
13035 * search.c (boyer_moore, wordify): Remove vars set but not used.
13036 (wordify): Omit three unnecessary tests.
13038 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13039 All callers changed. This avoids the need for an unused var.
13041 * casefiddle.c (casify_region): Remove var that is set but not used.
13043 * dired.c (file_name_completion): Remove var that is set but not used.
13045 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13047 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
13048 (Finsert_file_contents): Remove unnecessary code checking fd.
13050 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13051 Check for integer overflow on size calculations.
13053 * buffer.c (Fprevious_overlay_change): Remove var that is set
13056 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13057 Remove vars that are set but not used.
13058 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
13059 (timer_check_2): Mark vars as initialized.
13061 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13063 * image.c (lookup_image): Remove var that is set but not used.
13064 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
13066 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13067 that are set but not used.
13069 * xfns.c (make_invisible_cursor): Don't return garbage
13070 if XCreateBitmapFromData fails (Bug#8410).
13072 * xselect.c (x_get_local_selection, x_handle_property_notify):
13073 Remove vars that are set but not used.
13075 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
13076 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
13078 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13079 Remove var that is set but not used.
13080 (scroll_bar_windows_size): Now size_t, not int.
13081 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13082 Check for overflow.
13084 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13085 (map_tty_color) [!defined MSDOS]: Likewise.
13087 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13089 * coding.c: Remove vars that are set but not used.
13090 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13091 All callers changed.
13092 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13093 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13094 (decode_coding_charset): Remove vars that are set but not used.
13096 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13097 that is set but not used.
13099 * print.c (print_object): Remove var that is set but not used.
13101 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
13102 The gnulib version avoids calling malloc in the usual case,
13103 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13104 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13105 * filelock.c (current_lock_owner): Likewise.
13106 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13107 * sysdep.c: Include allocator.h, careadlinkat.h.
13108 (emacs_no_realloc_allocator): New static constant.
13109 (emacs_readlink): New function.
13110 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13111 ../lib/careadlinkat.h.
13113 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13115 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13116 first non-nil return value).
13118 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13120 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13121 if not defined (Bug#8403).
13123 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13125 * xdisp.c (display_count_lines): Remove parameter `start',
13126 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13127 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13128 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13129 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13130 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13131 and thereabouts. All callers changed.
13132 (get_per_char_metric): Remove parameter `f', unused since
13133 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13135 2011-04-02 Jim Meyering <meyering@redhat.com>
13137 do not dereference NULL upon failed strdup
13138 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13139 (ns_get_family): Likewise.
13141 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13143 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13145 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13147 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13150 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13152 Add lexical binding.
13154 * window.c (Ftemp_output_buffer_show): New fun.
13155 (Fsave_window_excursion):
13156 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13158 * lread.c (lisp_file_lexically_bound_p): New function.
13159 (Fload): Bind Qlexical_binding.
13160 (readevalloop): Remove `evalfun' arg.
13161 Bind Qinternal_interpreter_environment.
13162 (Feval_buffer): Bind Qlexical_binding.
13163 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13165 (syms_of_lread): Declare `lexical-binding'.
13167 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13169 * keyboard.c (eval_dyn): New fun.
13170 (menu_item_eval_property): Use it.
13172 * image.c (parse_image_spec): Use Ffunctionp.
13174 * fns.c (concat, mapcar1): Accept byte-code-functions.
13176 * eval.c (Fsetq): Handle lexical vars.
13177 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13178 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13179 (FletX, Flet): Obey lexical binding.
13180 (Fcommandp): Handle closures.
13181 (Feval): New `lexical' arg.
13182 (eval_sub): New function extracted from Feval. Use it almost
13183 everywhere where Feval was used. Look up vars in lexical env.
13185 (Ffunctionp): Move from subr.el.
13186 (Ffuncall): Handle closures.
13187 (apply_lambda): Remove `eval_flags'.
13188 (funcall_lambda): Handle closures and new byte-code-functions.
13189 (Fspecial_variable_p): New function.
13190 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13191 but without exporting it to Lisp.
13193 * doc.c (Fdocumentation, store_function_docstring):
13194 * data.c (Finteractive_form): Handle closures.
13196 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13199 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13201 (exec_byte_code): New function extracted from Fbyte_code to handle new
13202 calling convention for byte-code-functions. Add new byte-codes.
13204 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
13206 * alloc.c (Fmake_symbol): Init new `declared_special' field.
13208 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13210 * xdisp.c (redisplay_internal): Fix prototype.
13212 2011-03-31 Eli Zaretskii <eliz@gnu.org>
13214 * xdisp.c (SCROLL_LIMIT): New macro.
13215 (try_scrolling): Use it when setting scroll_limit.
13216 Limit scrolling to 100 screen lines.
13217 (redisplay_window): Even when falling back on "recentering",
13218 position point in the window according to scroll-conservatively,
13219 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13221 (try_scrolling): When point is above the window, allow searching
13222 as far as scroll_max, or one screenful, to compute vertical
13223 distance from PT to the scroll margin position. This prevents
13224 try_scrolling from unnecessarily failing when
13225 scroll-conservatively is set to a value slightly larger than the
13226 window height. Clean up the case of PT below the margin at bottom
13227 of window: scroll_max can no longer be INT_MAX. When aggressive
13228 scrolling is in use, don't let point enter the opposite scroll
13229 margin as result of the scroll.
13230 (syms_of_xdisp) <scroll-conservatively>: Document the
13231 threshold of 100 lines for never-recentering scrolling.
13233 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13235 * dispextern.h (move_it_by_lines):
13236 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13237 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13238 (message_log_check_duplicate): Remove parameters `prev_bol' and
13239 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13240 (redisplay_internal): Remove parameter `preserve_echo_area',
13241 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13243 * indent.c (Fvertical_motion):
13244 * window.c (window_scroll_pixel_based, Frecenter):
13245 Don't pass `need_y_p' to `move_it_by_lines'.
13247 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13249 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13250 steal a few bits to be more compact.
13251 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13252 Remove unneeded casts.
13254 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13256 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13258 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13259 binding" message (bug#7967).
13261 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13263 Fix more problems found by GCC 4.6.0's static checks.
13265 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13266 Remove unused local var.
13268 * editfns.c (Fmessage_box): Remove unused local var.
13270 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13271 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13272 Omit unused local vars.
13273 * window.c (shrink_windows): Omit unused local var.
13274 * menu.c (digest_single_submenu): Omit unused local var.
13275 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13276 Omit unused local var.
13278 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13279 Don't assume string length fits in int.
13280 (keyremap_step, read_key_sequence): Use size_t for sizes.
13281 (read_key_sequence): Don't check last_real_key_start redundantly.
13283 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13284 instead of alloca (Bug#8344).
13286 * eval.c (Fbacktrace): Don't assume nargs fits in int.
13287 (Fbacktrace_frame): Don't assume nframes fits in int.
13289 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13291 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13294 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13296 * cm.c (calccost): Turn while-do into do-while, for clarity.
13298 * keyboard.c (syms_of_keyboard): Use the same style as later
13299 in this function when indexing through an array. This also
13300 works around GCC bug 48267.
13302 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13304 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13306 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13307 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13309 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13310 This avoids undefined behavior on integer overflow, and is a bit
13311 more convenient anyway since it is compared to a size_t variable.
13313 Variadic C functions now count arguments with size_t, not int.
13314 This avoids an unnecessary limitation on 64-bit machines, which
13315 caused (substring ...) to crash on large vectors (Bug#8344).
13316 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13317 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
13318 All variadic functions and their callers changed accordingly.
13319 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13320 * data.c (arith_driver, float_arith_driver): Likewise.
13321 * editfns.c (general_insert_function): Likewise.
13322 * eval.c (struct backtrace.nargs, interactive_p)
13323 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13324 (funcall_lambda, mark_backtrace): Likewise.
13325 * fns.c (concat): Likewise.
13326 * frame.c (x_set_frame_parameters): Likewise.
13327 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13328 0 if not found, not -1. All callers changed.
13330 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13331 (stack_copy_size): Now size_t, not int.
13332 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13334 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13336 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13337 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13338 All callers changed.
13340 * lisp.h (multibyte_char_to_unibyte):
13341 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13342 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13343 * character.h (CHAR_TO_BYTE8):
13344 * cmds.c (internal_self_insert):
13345 * editfns.c (general_insert_function):
13346 * keymap.c (push_key_description):
13347 * search.c (Freplace_match):
13348 * xdisp.c (message_dolog, set_message_1): All callers changed.
13350 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13352 * keyboard.c (safe_run_hook_funcall): New function.
13353 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13354 don't set the hook to nil, but remove the offending function instead.
13355 (Qcommand_hook_internal): Remove, unused.
13356 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13357 Vcommand_hook_internal.
13359 * eval.c (enum run_hooks_condition): Remove.
13360 (funcall_nil, funcall_not): New functions.
13361 (run_hook_with_args): Call each function through a `funcall' argument.
13362 Remove `cond' argument, now redundant.
13363 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13364 (Frun_hook_with_args_until_failure): Adjust accordingly.
13365 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13367 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13369 * dispextern.h (string_buffer_position): Remove declaration.
13371 * print.c (strout): Remove parameter `multibyte', unused since
13372 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13374 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13375 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13376 All callers changed.
13378 * w32.c (_wsa_errlist): Use braces for struct initializers.
13380 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13381 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13382 All callers changed.
13383 (string_buffer_position): Likewise. Also, make static (it's never
13384 used outside xdisp.c).
13385 (cursor_row_p): Remove parameter `w', unused since
13386 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13387 (decode_mode_spec): Remove parameter `precision', introduced during
13388 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13389 All callers changed.
13391 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13393 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13395 2011-03-27 Anders Lindgren <andlind@gmail.com>
13397 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13398 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13399 (ns_update_auto_hide_menu_bar): New functions.
13400 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13401 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13402 ns_constrain_all_frames.
13403 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13404 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13406 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13408 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13410 2011-03-27 Glenn Morris <rgm@gnu.org>
13412 * syssignal.h: Replace RETSIGTYPE with void.
13413 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13414 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13415 Replace SIGTYPE with void everywhere.
13416 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13417 * s/template.h (SIGTYPE): Remove commented out definition.
13419 2011-03-26 Eli Zaretskii <eliz@gnu.org>
13421 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13422 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13424 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
13426 * w32.c (read_unc_volume): Use parameter `henum', instead of
13427 global variable `wget_enum_handle'.
13429 * keymap.c (describe_vector): Remove parameters `indices' and
13430 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13431 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13433 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13435 * keyboard.c (timer_check): Remove parameter `do_it_now',
13436 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13437 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13438 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13440 * keyboard.c (read_char):
13441 * w32menu.c (w32_menu_display_help):
13442 * xmenu.c (show_help_event, menu_help_callback):
13443 Adjust calls to `show_help_echo'.
13445 * gtkutil.c (xg_maybe_add_timer):
13446 * keyboard.c (readable_events):
13447 * process.c (wait_reading_process_output):
13448 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13450 * insdel.c (adjust_markers_gap_motion):
13451 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13452 (gap_left, gap_right): Don't call it.
13454 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
13456 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13457 incurred during fontification.
13459 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13461 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13462 (DEFVAR_PER_BUFFER): Don't pass it.
13464 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13465 (scrolling_window): Don't pass it.
13467 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13469 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13471 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13473 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13474 of variables specific to SELinux and computation of `encoded_absname'.
13476 * image.c (XPutPixel): Remove unused variable `height'.
13478 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13480 * unexw32.c (get_section_info): Remove unused variable `section'.
13482 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13483 (system_process_attributes): Remove unused variable `sess'.
13484 (sys_read): Remove unused variable `err'.
13486 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13487 (w32_wnd_proc): Remove unused variable `isdead'.
13488 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13489 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13490 (x_create_tip_frame): Remove unused variable `tem'.
13492 * w32inevt.c (w32_console_read_socket):
13493 Remove unused variable `no_events'.
13495 * w32term.c (x_draw_composite_glyph_string_foreground):
13496 Remove unused variable `width'.
13498 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
13500 * w32term.c (x_set_glyph_string_clipping):
13501 Don't pass uninitialized region to CombineRgn.
13503 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
13505 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13506 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13507 (Fx_close_connection): Remove unused variable `i'.
13509 * w32font.c (w32font_draw): Return number of glyphs.
13510 (w32font_open_internal): Remove unused variable `i'.
13511 (w32font_driver): Add missing initializer.
13513 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13514 (fill_in_menu): Remove unused variable `items_added'.
13516 * w32term.c (last_mouse_press_frame): Remove static global variable.
13517 (w32_clip_to_row): Remove unused variable `f'.
13518 (x_delete_terminal): Remove unused variable `i'.
13520 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13521 (NOTHING): Remove unused static global variable.
13522 (uniscribe_check_otf): Remove unused variable `table'.
13523 (uniscribe_font_driver): Add missing initializers.
13525 2011-03-23 Julien Danjou <julien@danjou.info>
13527 * term.c (Fsuspend_tty, Fresume_tty):
13528 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13529 * window.c (temp_output_buffer_show):
13530 * insdel.c (signal_before_change):
13531 * frame.c (Fhandle_switch_frame):
13532 * fileio.c (Fdo_auto_save):
13533 * emacs.c (Fkill_emacs):
13534 * editfns.c (save_excursion_restore):
13535 * cmds.c (internal_self_insert):
13536 * callint.c (Fcall_interactively):
13537 * buffer.c (Fkill_all_local_variables):
13538 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13540 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
13541 unconditionally since it does the check itself.
13543 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
13545 Fix more problems found by GCC 4.5.2's static checks.
13547 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13548 the first time through the loop, since we know p0 < p1 then.
13549 This also avoids a gcc -Wstrict-overflow warning.
13551 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13552 leading to a memory leak, possible in functions like
13553 load_charset_map_from_file that can allocate an unbounded number
13554 of objects (Bug#8318).
13556 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13557 that could (at least in theory) be that large.
13559 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13560 This is less likely to overflow, and avoids undefined behavior if
13561 overflow does occur. All callers changed. Use strtoul to scan
13562 for the unsigned long integer.
13563 (pint2hrstr): Simplify and tune code slightly.
13564 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
13566 * scroll.c (do_scrolling): Work around GCC bug 48228.
13567 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13569 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13570 This also avoids a warning with gcc -Wstrict-overflow.
13571 (validate_x_resource_name): Simplify count usage.
13572 This also avoids a warning with gcc -Wstrict-overflow.
13574 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13577 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
13579 * process.c (Fmake_network_process): Use socklen_t, not int,
13580 where POSIX says socklen_t is required in portable programs.
13581 This fixes a porting bug on hosts like 64-bit HP-UX, where
13582 socklen_t is wider than int (Bug#8277).
13583 (Fmake_network_process, server_accept_connection):
13584 (wait_reading_process_output, read_process_output):
13587 * process.c: Rename or move locals to avoid shadowing.
13588 (list_processes_1, Fmake_network_process):
13589 (read_process_output_error_handler, exec_sentinel_error_handler):
13590 Rename or move locals.
13591 (Fmake_network_process): Define label "retry_connect" only if needed.
13592 (Fnetwork_interface_info): Fix pointer signedness.
13593 (process_send_signal): Add cast to avoid pointer signedness problem.
13594 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
13595 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
13597 Make tparam.h and terminfo.c consistent.
13598 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13599 Include tparam.h instead, since it declares them.
13600 * cm.h (PC): Remove extern decl; tparam.h now does this.
13601 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13602 * terminfo.c: Include tparam.h, to check interfaces.
13603 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13604 (tparam): Adjust signature to match interface in tparam.h;
13605 this removes some undefined behavior. Check that outstring and len
13606 are zero, which they always are with Emacs.
13607 * tparam.h (PC, BC, UP): New extern decls.
13609 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
13610 (xftfont_open): Rename locals to avoid shadowing.
13612 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
13613 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13614 (OTF_TAG_SYM): Omit macro if not needed.
13615 (ftfont_list): Remove unused local.
13616 (get_adstyle_property, ftfont_pattern_entity):
13617 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13618 Rename locals to avoid shadowing.
13620 * xfont.c (xfont_list_family): Mark var as initialized.
13622 * xml.c (make_dom): Now static.
13624 * composite.c (composition_compute_stop_pos): Rename local to
13626 (composition_reseat_it): Remove unused locals.
13627 (find_automatic_composition, composition_adjust_point): Likewise.
13628 (composition_update_it): Mark var as initialized.
13629 (find_automatic_composition): Mark vars as initialized,
13630 with a FIXME (Bug#8290).
13632 character.h: Rename locals to avoid shadowing.
13633 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13634 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13635 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13636 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13637 to avoid shadowing.
13639 * textprop.c (property_change_between_p): Remove; unused.
13641 * intervals.c (interval_start_pos): Now static.
13643 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13645 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13646 Rename locals to avoid shadowing.
13648 * sound.c (wav_play, au_play, Fplay_sound_internal):
13649 Fix pointer signedness.
13650 (alsa_choose_format): Remove unused local var.
13651 (wav_play): Initialize a variable to 0, to prevent undefined
13652 behavior (Bug#8278).
13654 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13656 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13658 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13659 clobbering (Bug#8298).
13660 * sysdep.c (sys_subshell): Likewise.
13661 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
13663 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13664 This should get cleaned up, so that child_setup has the
13665 same signature on all platforms.
13667 * callproc.c (call_process_cleanup): Now static.
13668 (relocate_fd): Rename locals to avoid shadowing.
13670 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
13672 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13673 not to be necessary, and produces flickering.
13675 2011-03-20 Glenn Morris <rgm@gnu.org>
13677 * config.in: Remove file.
13679 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
13681 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13682 are now in src/globals.h.
13683 (syms_of_minibuf): Remove spurious & from previous change.
13685 2011-03-20 Leo Liu <sdl.web@gmail.com>
13687 * minibuf.c (completing-read-function): New variable.
13688 (completing-read-default): Rename from completing-read.
13689 (completing-read): Call completing-read-function.
13691 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13693 * xfaces.c (Fx_load_color_file):
13694 Read color file from absolute filename (bug#8250).
13696 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13698 * makefile.w32-in: Update dependencies.
13700 2011-03-17 Eli Zaretskii <eliz@gnu.org>
13702 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13704 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13706 Fix more problems found by GCC 4.5.2's static checks.
13708 * process.c (make_serial_process_unwind, send_process_trap):
13709 (sigchld_handler): Now static.
13711 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13712 That way, the code declares only the vars that it needs.
13713 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13714 * s/cygwin.h (PTY_ITERATION): Likewise.
13715 * s/darwin.h (PTY_ITERATION): Likewise.
13716 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13718 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13719 * process.c (allocate_pty): Don't declare stb unless it's needed.
13721 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
13722 (CONSTANTLIM): Remove; unused.
13723 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13724 Define only if needed.
13726 * unexelf.c (unexec): Name an expression,
13727 to avoid gcc -Wbad-function-cast warning.
13728 Use a different way to cause a compilation error if anyone uses
13729 n rather than nn, a way that does not involve shadowing.
13730 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
13732 * deps.mk (unexalpha.o): Remove; unused.
13734 New file unexec.h, the (simple) interface for unexec (Bug#8267).
13735 * unexec.h: New file.
13736 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13737 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13738 Depend on unexec.h.
13739 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13740 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13741 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
13742 Change as necessary to match prototype in unexec.h.
13744 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13746 (back_comment, skip_chars): Mark vars as initialized.
13748 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13749 Rename locals to avoid shadowing.
13751 * lread.c (read1): Rewrite so as not to use empty "else".
13752 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
13754 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13756 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13757 warning when compiling print.c.
13759 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13760 instead of using an uninitialized var.
13761 (font_sort_entities): Mark var as initialized.
13763 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13765 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13766 pointers to constants.
13767 (font_parse_fcname): Remove unused vars.
13768 (font_delete_unmatched): Now static.
13769 (font_get_spec): Remove; unused.
13770 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13771 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13772 Rename or move locals to avoid shadowing.
13774 * fns.c (require_nesting_list, require_unwind): Now static.
13775 (Ffillarray): Rename locals to avoid shadowing.
13777 * floatfns.c (domain_error2): Define only if needed.
13778 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
13780 * alloc.c (mark_backtrace): Move decl from here ...
13781 * lisp.h: ... to here, so that it can be checked.
13783 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
13784 (Fdefvar): Rewrite so as not to use empty "else".
13785 (lisp_indirect_variable): Name an expression,
13786 to avoid gcc -Wbad-function-cast warning.
13787 (Fdefvar): Rename locals to avoid shadowing.
13789 * callint.c (quotify_arg, quotify_args): Now static.
13790 (Fcall_interactively): Rename locals to avoid shadowing.
13791 Use const pointer when appropriate.
13793 * lisp.h (get_system_name, get_operating_system_release):
13794 Move decls here, to check interfaces.
13795 * process.c (get_operating_system_release): Move decl to lisp.h.
13796 * xrdb.c (get_system_name): Likewise.
13797 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13798 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13799 some of which prompt warnings from gcc -Wbad-function-cast.
13800 (Fformat_time_string, Fencode_time, Finsert_char):
13801 (Ftranslate_region_internal, Fformat):
13802 Rename or remove local vars to avoid shadowing.
13803 (Ftranslate_region_internal): Mark var as initialized.
13805 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13808 * lisp.h (eassert): Check that the argument compiles, even if
13809 ENABLE_CHECKING is not defined.
13811 * data.c (Findirect_variable): Name an expression, to avoid
13812 gcc -Wbad-function-cast warning.
13813 (default_value, arithcompare, arith_driver, arith_error): Now static.
13814 (store_symval_forwarding): Rename local to avoid shadowing.
13815 (Fmake_variable_buffer_local, Fmake_local_variable):
13816 Mark variables as initialized.
13817 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
13819 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
13820 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13821 Rename locals to avoid shadowing.
13822 (mark_stack): Move local variables into the #ifdef region where
13824 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13825 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13827 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13828 (GC_STRING_CHARS): Remove; not used.
13829 (Fmemory_limit): Cast sbrk's returned value to char *.
13831 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13832 avoids undefined behavior in theory.
13834 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13836 Use functions, not macros, for up- and down-casing (Bug#8254).
13837 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13838 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13839 to use the following functions instead of these macros.
13840 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13841 EMACS_INT, since callers assume the returned value fits in int.
13842 (upcase1): Likewise, for UPCASE_TABLE.
13843 (uppercasep, lowercasep, upcase): New static inline functions.
13844 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
13845 the race-condition problem in the old DOWNCASE.
13847 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13848 Rename locals to avoid shadowing.
13849 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
13850 (regex_compile, re_search_2, re_match_2_internal):
13851 Remove unused local vars.
13852 (FREE_VAR): Rewrite so as not to use empty "else",
13853 which gcc can warn about.
13854 (regex_compile, re_match_2_internal): Mark locals as initialized.
13855 (RETALLOC_IF): Define only if needed.
13856 (WORDCHAR_P): Likewise. This one is never needed, but is used
13857 only in a comment talking about a compiler bug, so put inside
13858 the #if 0 of that comment.
13859 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13860 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13863 * search.c (boyer_moore): Rename locals to avoid shadowing.
13864 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13865 (PREV_CHAR_BOUNDARY): Likewise.
13867 * search.c (simple_search): Remove unused var.
13869 * dired.c (compile_pattern): Move decl from here ...
13870 * lisp.h: ... to here, so that it can be checked.
13871 (struct re_registers): New forward decl.
13873 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13875 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13877 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13878 Rename locals to avoid shadowing.
13879 (Fvertical_motion): Mark locals as initialized.
13881 * casefiddle.c (casify_object, casify_region): Now static.
13882 (casify_region): Mark local as initialized.
13884 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13886 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13887 New macros, so that the caller can use some names other than
13888 gcpro1, gcpro2, etc.
13889 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13891 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13892 argument, for consistency with GCPRO2_VAR, etc: it is now the
13893 prefix of the variable, not the variable itself. All uses
13895 * dired.c (directory_files_internal, file_name_completion):
13896 Rename locals to avoid shadowing.
13898 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13899 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13900 dired.c's scmp function, had undefined behavior.
13901 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13902 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13903 * buffer.h: ... to here, because these macros use current_buffer,
13904 and the new implementation with inline functions needs to have
13905 current_buffer in scope now, rather than later when the macros
13907 (downcase, upcase1): New static inline functions.
13908 (DOWNCASE, UPCASE1): Reimplement using these functions.
13909 This avoids undefined behavior in expressions like
13910 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13911 from race conditions in accessing the global variables
13912 case_temp1 and case_temp2.
13913 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13914 * lisp.h (case_temp1, case_temp2): Remove their decls.
13915 * character.h (ASCII_CHAR_P): Move from here ...
13916 * lisp.h: ... to here, so that the inline functions mentioned
13917 above can use them.
13919 * dired.c (directory_files_internal_unwind): Now static.
13921 * fileio.c (file_name_as_directory, directory_file_name):
13922 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13924 (file_name_as_directory): Use const pointers when appropriate.
13925 (Fexpand_file_name): Likewise. In particular, newdir might
13926 point at constant storage, so make it a const pointer.
13927 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
13928 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13930 (Fset_file_times, Finsert_file_contents, auto_save_error):
13931 Rename locals to avoid shadowing.
13933 * minibuf.c (choose_minibuf_frame_1): Now static.
13934 (Ftry_completion, Fall_completions): Rename or remove locals
13935 to avoid shadowing.
13937 * marker.c (bytepos_to_charpos): Remove; unused.
13939 * lisp.h (verify_bytepos, count_markers): New decls,
13940 so that gcc does not warn that these functions aren't declared.
13942 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13943 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
13944 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
13945 (copy_text): Remove unused local var.
13947 * filelock.c (within_one_second): Now static.
13948 (lock_file_1): Rename local to avoid shadowing.
13950 * buffer.c (fix_overlays_before): Mark locals as initialized.
13951 (fix_start_end_in_overlays): Likewise. This function should be
13952 simplified by using pointers-to-pointers, but that's a different
13954 (switch_to_buffer_1): Now static.
13955 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13956 (report_overlay_modification): Rename locals to avoid shadowing.
13958 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
13959 Fix pointer signedness issue.
13960 (sys_subshell): Mark local as volatile if checking for lint,
13961 to suppress a gcc -Wclobbered warning that does not seem to be right.
13962 (MAXPATHLEN): Define only if needed.
13964 * process.c (serial_open, serial_configure): Move decls from here ...
13965 * systty.h: ... to here, so that they can be checked.
13967 * fns.c (get_random, seed_random): Move extern decls from here ...
13968 * lisp.h: ... to here, so that they can be checked.
13970 * sysdep.c (reset_io): Now static.
13971 (wait_for_termination_signal): Remove; unused.
13973 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13974 (copy_keymap_item, append_key, push_text_char_description):
13976 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
13977 (DENSE_TABLE_SIZE): Remove; unused.
13978 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13979 (describe_map_tree):
13980 Rename locals to avoid shadowing.
13982 * keyboard.c: Declare functions static if they are not used elsewhere.
13983 (echo_char, echo_dash, cmd_error, top_level_2):
13984 (poll_for_input, handle_async_input): Now static.
13985 (read_char, kbd_buffer_get_event, make_lispy_position):
13986 (make_lispy_event, make_lispy_movement, apply_modifiers):
13987 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13988 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13989 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
13990 (read_key_sequence, read_char): Mark locals as initialized.
13991 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
13993 * keyboard.h (make_ctrl_char): New decl.
13994 (mark_kboards): Move decl here ...
13995 * alloc.c (mark_kboards): ... from here.
13997 * lisp.h (force_auto_save_soon): New decl.
13999 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
14000 (DEFINE_DUMMY_FUNCTION): New macro.
14001 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14003 (main): Add casts to avoid warnings
14004 if GCC considers string literals to be constants.
14006 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14008 * dbusbind.c: Pointer signedness fixes.
14009 (xd_signature, xd_append_arg, xd_initialize):
14010 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14011 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14012 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14013 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14015 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14016 if GCC considers string literals to be constants.
14017 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
14019 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14021 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14022 (print_preprocess, print_object): New macro to fix last change.
14024 * print.c (print_preprocess): Don't forget font objects.
14026 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
14028 * emacs.c (USAGE3): Doc fixes.
14030 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14032 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14035 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
14037 * lisp.h (VWindow_system, Qfile_name_history):
14038 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14039 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14040 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14042 * w32select.c: Don't #include "keyboard.h".
14043 (run_protected): Add extern declaration for waiting_for_input.
14045 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14046 * w32console.c (detect_input_pending, read_input_pending)
14047 (encode_terminal_code):
14048 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14049 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14050 (w32_system_caret_y, Qfile_name_history):
14051 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14052 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14053 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14054 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14055 * w32proc.c (Qlocal, report_file_error):
14056 * w32term.c (Vwindow_system, updating_frame):
14057 * w32uniscribe.c (initialized, uniscribe_font_driver):
14058 Remove unneeded extern declarations.
14060 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
14062 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
14064 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
14066 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14067 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14068 These macros can no longer be used for assignment.
14070 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14071 Assign struct members directly, instead of using BUF_BEGV etc.
14072 (record_buffer_markers, fetch_buffer_markers): New functions for
14073 recording and fetching special buffer markers.
14074 (set_buffer_internal_1, set_buffer_temp): Use them.
14076 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14078 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14080 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14081 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14083 * xdisp.c (hscroll_window_tree):
14084 (reconsider_clip_changes): Use PT instead of BUF_PT.
14086 2011-03-13 Eli Zaretskii <eliz@gnu.org>
14088 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14089 $(EMACS_ROOT)/lib/intprops.h.
14091 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14093 Fix more problems found by GCC 4.5.2's static checks.
14095 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14096 to unsigned char * to avoid compiler diagnostic.
14097 (xg_free_frame_widgets): Make it clear that a local variable is
14098 needed only if USE_GTK_TOOLTIP.
14099 (gdk_window_get_screen): Make it clear that this macro is needed
14100 only if USE_GTK_TOOLTIP.
14101 (int_gtk_range_get_value): New function, which avoids a diagnostic
14102 from gcc -Wbad-function-cast.
14103 (xg_set_toolkit_scroll_bar_thumb): Use it.
14104 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14105 diagnostic from gcc -Wbad-function-cast.
14106 (get_utf8_string, xg_get_file_with_chooser):
14107 Rename locals to avoid shadowing.
14108 (create_dialog): Move locals to avoid shadowing.
14110 * xgselect.c (xg_select): Remove unused var.
14112 * image.c (four_corners_best): Mark locals as initialized.
14113 (gif_load): Initialize transparent_p to zero (Bug#8238).
14114 Mark another local as initialized.
14115 (my_png_error, my_error_exit): Mark with NO_RETURN.
14117 * image.c (clear_image_cache): Now static.
14118 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
14119 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
14120 (x_edge_detection): Remove unnecessary cast that
14121 gcc -Wbad-function-cast diagnoses.
14122 (gif_load): Fix pointer signedness.
14123 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14124 (jpeg_load, gif_load): Rename locals to avoid shadowing.
14126 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
14128 Improve quality of tests for time stamp overflow.
14129 For example, without this patch (encode-time 0 0 0 1 1
14130 1152921504606846976) returns the obviously-bogus value (-948597
14131 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14132 reports time overflow. See
14133 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
14134 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14135 * editfns.c: Include limits.h and intprops.h.
14136 (TIME_T_MIN, TIME_T_MAX): New macros.
14137 (time_overflow): Move earlier, to before first use.
14138 (hi_time, lo_time): New functions, for an accurate test for
14139 out-of-range times.
14140 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14141 (Fget_internal_run_time): Don't assume time_t fits in int.
14142 (make_time): Use list2 instead of Fcons twice.
14143 (Fdecode_time): More accurate test for out-of-range times.
14144 (check_tm_member): New function.
14145 (Fencode_time): Use it, to test for out-of-range times.
14146 (lisp_time_argument): Don't rely on undefined left-shift and
14147 right-shift behavior when checking for time stamp overflow.
14149 * editfns.c (time_overflow): New function, refactoring common code.
14150 (Fformat_time_string, Fdecode_time, Fencode_time):
14151 (Fcurrent_time_string): Use it.
14153 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14154 * dired.c (make_time): Move to ...
14155 * editfns.c (make_time): ... here.
14156 * systime.h: Note the move.
14158 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14160 * fringe.c (update_window_fringes): Remove unused variables.
14162 * unexmacosx.c (copy_data_segment): Also copy __got section.
14165 2011-03-12 Eli Zaretskii <eliz@gnu.org>
14167 * termcap.c [MSDOS]: Include "msdos.h".
14168 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14169 Constify `char *' arguments and their references according to
14170 prototypes in tparam.h.
14172 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
14174 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14175 Adapt all references accordingly.
14177 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14179 2011-03-11 Tom Tromey <tromey@redhat.com>
14181 * buffer.c (syms_of_buffer): Remove obsolete comment.
14183 2011-03-11 Eli Zaretskii <eliz@gnu.org>
14185 * termhooks.h (encode_terminal_code): Declare prototype.
14187 * msdos.c (encode_terminal_code): Don't declare prototype.
14189 * term.c (encode_terminal_code): Now external again, used by
14190 w32console.c and msdos.c.
14192 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14193 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
14195 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
14197 Fix some minor problems found by GCC 4.5.2's static checks.
14199 * fringe.c (update_window_fringes): Mark locals as initialized
14201 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
14203 * alloc.c (mark_fringe_data): Move decl from here ...
14204 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14205 to check its interface.
14206 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14208 * fontset.c (free_realized_fontset): Now static.
14209 (Fset_fontset_font): Rename local to avoid shadowing.
14210 (fontset_font): Mark local as initialized.
14211 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
14213 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14215 * xselect.c (x_disown_buffer_selections): Remove; not used.
14216 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
14217 (x_own_selection, Fx_disown_selection_internal): Rename locals
14218 to avoid shadowing.
14219 (x_handle_dnd_message): Remove local to avoid shadowing.
14221 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14222 so that the caller can use some name other than gcpro1.
14223 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
14224 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14225 (Fx_backspace_delete_keys_p):
14226 Use them to avoid shadowing, and rename vars to avoid shadowing.
14227 (x_decode_color, x_set_name, x_window): Now static.
14228 (Fx_create_frame): Add braces to silence GCC warning.
14229 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
14230 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14231 Remove unused locals.
14232 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14233 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14234 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14237 * xterm.h (x_mouse_leave): New decl.
14239 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14240 Remove unused functions.
14241 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14242 (x_calc_absolute_position): Now static.
14243 (XTread_socket): Don't define label "out" unless it's used.
14244 Don't declare local "event" unless it's used.
14245 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14246 unless they are used.
14247 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14248 (x_fatal_error_signal): Remove; not used.
14249 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14250 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14251 (x_error_catcher, x_connection_closed, x_error_handler):
14252 (x_error_quitter, xembed_send_message, x_iconify_frame):
14253 (my_log_handler): Rename locals to avoid shadowing.
14254 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
14255 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
14257 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14258 Rename or move locals to avoid shadowing.
14259 (tty_defined_color, merge_face_heights): Now static.
14260 (free_realized_faces_for_fontset): Remove; not used.
14261 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14262 does not deduce is never used uninitialized.
14263 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14264 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
14266 * terminal.c (store_terminal_param): Now static.
14268 * xmenu.c (menu_highlight_callback): Now static.
14269 (set_frame_menubar): Remove unused local.
14270 (xmenu_show): Rename parameter to avoid shadowing.
14271 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14272 since they might point to immutable storage.
14273 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14274 since it's unused otherwise.
14276 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
14277 Add a FIXME, since the code still doesn't look right. (Bug#8215)
14278 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14279 avoids a gcc -Wuninitialized diagnostic.
14280 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
14281 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14282 does not deduce are never used uninitialized.
14284 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14286 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
14287 * window.c (window_loop, size_window):
14288 (run_window_configuration_change_hook, enlarge_window): Likewise.
14290 * window.c (display_buffer): Now static.
14291 (size_window): Mark variables that gcc -Wuninitialized
14292 does not deduce are never used uninitialized.
14293 * window.h (check_all_windows): New decl, to forestall
14294 gcc -Wmissing-prototypes diagnostic.
14295 * dispextern.h (bidi_dump_cached_states): Likewise.
14297 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14299 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
14300 Include <limits.h>.
14301 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14302 and to avoid gcc -Wuninitialized warning.
14303 (load_charset_map): Mark variables that gcc -Wuninitialized
14304 does not deduce are never used uninitialized.
14305 (load_charset): Abort instead of using uninitialized var (Bug#8229).
14307 * coding.c (coding_set_source, coding_set_destination):
14308 Use "else { /* comment */ }" rather than "else /* comment */;"
14309 for clarity, and to avoid gcc -Wempty-body warning.
14310 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14311 a block, when the outer 'i' will do.
14312 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14313 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14314 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14315 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14316 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14317 Rename locals to avoid shadowing.
14318 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
14319 * coding.c (emacs_mule_char, encode_invocation_designation):
14320 Now static, since they're not used elsewhere.
14321 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
14322 (decode_coding_object, encode_coding_object, detect_coding_system):
14323 (decode_coding_emacs_mule): Mark variables that gcc
14324 -Wuninitialized does not deduce are never used uninitialized.
14325 (detect_coding_iso_2022): Initialize a local variable that might
14326 be used uninitialized. Leave a FIXME because it's not clear that
14327 this initialization is needed. (Bug#8211)
14328 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14329 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14330 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14331 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14332 Remove unused macros.
14334 * category.c (hash_get_category_set): Remove unused local var.
14335 (copy_category_table): Now static, since it's not used elsewhere.
14336 * character.c (string_count_byte8): Likewise.
14338 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14339 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14341 * chartab.c (copy_sub_char_table): Now static, since it's not used
14343 (sub_char_table_ref_and_range, char_table_ref_and_range):
14344 Rename locals to avoid shadowing.
14345 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
14347 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
14348 (BIDI_BOB): Remove unused macro.
14350 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14351 deduce are never used uninitialized.
14352 * term.c (encode_terminal_code): Likewise.
14354 * term.c (encode_terminal_code): Now static. Remove unused local.
14356 * tparam.h: New file.
14357 * term.c, tparam.h: Include it.
14358 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14359 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14360 Move these decls to tparam.h, and make them agree with what
14361 is actually in tparam.c. The previous trick of using incompatible
14362 decls in different modules does not conform to the C standard.
14363 All callers of tparam changed to use tparam's actual API.
14364 * tparam.c (tparam1, tparam, tgoto):
14365 Use const pointers where appropriate.
14367 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14368 * cm.h (struct cm): Likewise.
14369 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14370 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14371 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14372 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14373 (turn_on_face, init_tty): Likewise.
14374 * termchar.h (struct tty_display_info): Likewise.
14376 * term.c (term_mouse_position): Rename local to avoid shadowing.
14378 * alloc.c (mark_ttys): Move decl from here ...
14379 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14381 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14383 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14385 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
14387 * search.c (compile_pattern_1): Remove argument regp, unused since
14388 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14389 (compile_pattern): Don't pass it.
14391 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14393 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14394 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14396 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14398 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14400 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14401 gdk_window_get_screen, gdk_window_get_geometry,
14402 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14403 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14404 (xg_get_pixbuf_from_pixmap): New function.
14405 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14406 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14407 Call xg_get_pixbuf_from_pixmap instead of
14408 gdk_pixbuf_get_from_drawable.
14409 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14410 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14411 (xg_check_special_colors): Use GtkStyleContext and its functions
14413 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14414 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14415 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
14416 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14417 Call gtk_widget_get_preferred_size.
14418 (xg_frame_resized): gdk_window_get_geometry only takes 5
14420 (xg_win_to_widget, xg_event_is_for_menubar):
14421 Call gdk_x11_window_lookup_for_display.
14422 (xg_set_widget_bg): New function.
14423 (delete_cb): New function.
14424 (xg_create_frame_widgets): Connect delete-event to delete_cb.
14425 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
14426 (xg_set_background_color): Call xg_set_widget_bg.
14427 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14428 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14429 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14430 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14432 (update_frame_tool_bar): Call gtk_widget_hide.
14433 (xg_initialize): Use GDK_KEY_g.
14435 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14437 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14439 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14440 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14441 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14443 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
14445 * w32xfns.c (select_palette): Check success of RealizePalette against
14446 GDI_ERROR, not zero.
14448 See ChangeLog.11 for earlier changes.
14450 ;; Local Variables:
14454 Copyright (C) 2011-2012 Free Software Foundation, Inc.
14456 This file is part of GNU Emacs.
14458 GNU Emacs is free software: you can redistribute it and/or modify
14459 it under the terms of the GNU General Public License as published by
14460 the Free Software Foundation, either version 3 of the License, or
14461 (at your option) any later version.
14463 GNU Emacs is distributed in the hope that it will be useful,
14464 but WITHOUT ANY WARRANTY; without even the implied warranty of
14465 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14466 GNU General Public License for more details.
14468 You should have received a copy of the GNU General Public License
14469 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.