1 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
3 * editfns.c (region_limit): Clip to narrowing (bug#11770).
5 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
7 Avoid integer overflow on scroll-left and scroll-right.
8 * window.c (HSCROLL_MAX): New macro.
9 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
10 overflow when requested scroll falls outside ptrdiff_t range.
12 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
14 * window.h (struct window): Change type of 'hscroll',
15 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
16 'last_modified' and 'last_overlay_modified' to EMACS_INT.
17 Adjust users accordingly.
18 * xdisp.c (try_cursor_movement): Replace type check with eassert.
19 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
20 from EMACS_INT to ptrdiff_t.
21 (make_window): Omit redundant initialization.
23 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
25 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
27 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
29 * window.h (struct window): Change type of 'use_time' and
30 'sequence_number' from Lisp_Object to int.
31 * frame.c (make_frame): Adjust users accordingly.
32 * print.c (print_object): Likewise.
33 * window.c (select_window, Fwindow_use_time, make_parent_window)
34 (make_window): Likewise.
36 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
38 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
39 enabled with --enable-checking=[all,glyphs] configure option.
40 Fix GLYPH_DEBUG usage assuming that it may be undefined,
41 adjust comments accordingly.
42 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
43 undefined, adjust comments accordingly.
47 * w32term.c: Likewise.
53 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
55 Generalize run-time debugging checks.
56 * dispextern.h (XASSERTS): Remove.
57 * fontset.c (xassert): Remove.
58 Convert from xassert to eassert.
59 * alloc.c: Convert from xassert to eassert.
61 * dispnew.c: Likewise.
65 * gtkutil.c: Likewise.
67 * keyboard.c: Likewise.
69 * process.c: Likewise.
73 * w32console.c: Likewise.
75 * w32term.c: Likewise.
80 * xselect.c: Likewise.
83 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
85 * fns.c (maybe_resize_hash_table): Output message when growing the
88 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
90 * alloc.c (allocate_string_data): Remove dead code.
91 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
92 avoid GCC warning about unused macro.
94 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
96 * alloc.c (allocate_string): Omit intervals initialization.
97 * alloc.c (make_uninit_multibyte_string): Initialize intervals
98 as in make_pure_string and make_pure_c_string.
100 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
102 * alloc.c (allocate_string): Fix last change.
104 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
106 * alloc.c (allocate_string): Remove two redundant calls
107 to memset, add explicit initialization where appropriate.
109 2012-06-27 Glenn Morris <rgm@gnu.org>
111 * lisp.mk (lisp): Remove paths.elc.
113 2012-06-27 Chong Yidong <cyd@gnu.org>
115 * doc.c (Fsubstitute_command_keys): Fix punctuation.
117 2012-06-26 John Wiegley <johnw@newartisans.com>
119 * unexmacosx.c (copy_data_segment): Add two section names used
120 on Mac OS X Lion: __mod_init_func and __mod_term_func.
122 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
123 when building with Clang.
125 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
127 * eval.c (Fapply): Allow calling it with a single argument.
129 2012-06-26 Eli Zaretskii <eliz@gnu.org>
131 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
132 _stricmp and _strnicmp.
133 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
135 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
137 * alloc.c (allocate_window): Zero out non-Lisp part of newly
139 (allocate_process): Likewise for new process.
140 (allocate_terminal): Change to use offsetof.
141 (allocate_frame): Likewise.
142 * frame.c (make_frame): Omit redundant initialization.
143 * window.c (make_parent_window): Use memset.
144 (make_window): Omit redundant initialization.
145 * process.c (make_process): Omit redundant initialization.
146 * terminal.c (create_terminal): Likewise.
148 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
150 * term.c (delete_tty): Remove redundant call to memset.
152 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
154 * alloc.c: Remove build_string.
155 * lisp.h: Define build_string as static inline. This provides
156 a better opportunity to optimize away calls to strlen when the
157 function is called with compile-time constant argument.
158 * image.c (imagemagick_error): Convert to build_string.
159 * w32proc.c (sys_spawnve): Likewise.
160 * xterm.c (x_term_init): Likewise.
162 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
164 Use sprintf return value instead of invoking strlen on result.
165 In the old days this wasn't portable, since some sprintf
166 implementations returned char *. But they died out years ago and
167 Emacs already assumes sprintf returns int.
168 Similarly for float_to_string.
169 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
170 * ccl.c (ccl_driver):
171 * character.c (string_escape_byte8):
172 * data.c (Fnumber_to_string):
174 * print.c (print_object):
175 * xdisp.c (message_dolog):
176 * xfns.c (syms_of_xfns):
177 Use sprintf or float_to_string result to avoid need to call strlen.
178 * data.c (Fnumber_to_string):
179 Use make_unibyte_string, since the string must be ASCII.
180 * lisp.h, print.c (float_to_string): Now returns int length.
181 * term.c (produce_glyphless_glyph):
182 Use sprintf result rather than recomputing it.
184 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
185 * Makefile.in (ALL_CFLAGS):
186 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
187 * gmalloc.c, regex.c: Include <config.h> unconditionally.
189 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
191 * dispextern.h (xstrcasecmp): Define to library function
192 strcasecmp if available.
193 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
195 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
197 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
198 Avoid comma operator.
199 * menu.c (push_submenu_start, push_submenu_end)
200 (push_left_right_boundary, push_menu_pane): Likewise.
201 * msdos.c (dos_rawgetc): Likewise.
203 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
205 * xfns.c (xic_create_fontsetname): Remove redundant calls
208 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
210 * gtkutil.c (get_utf8_string): Remove redundant assignment.
211 sprintf already null-terminates its output.
213 * xfns.c (x_window): Remove redundant cast.
215 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
217 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
218 `const char *' to `char *' to avoid compiler warning.
220 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
222 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
223 instead of truncating it to 63 (admittedly a generous limit).
225 * process.c: Fix spelling and caps in comments.
227 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
229 * emacs.c (setpgrp): Remove definition, unused.
230 * sysdep.c (setpgrp): Remove definition, not used in this file.
232 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
234 * makefile.w32-in: Update dependencies.
236 2012-06-24 Eli Zaretskii <eliz@gnu.org>
238 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
239 (SYSTIME_H): Add nt/inc/sys/time.h.
241 * systime.h [WINDOWSNT]: Include sys/time.h.
243 * s/ms-w32.h (struct timespec): Definition moved from
244 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
246 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
248 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
249 * buffer.h (buffer_slot_type_mismatch):
250 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
251 * eval.c (unwind_to_catch):
252 * image.c (my_png_error, my_error_exit):
253 * keyboard.c (quit_throw_to_read_char, user_error)
254 (Fexit_recursive_edit, Fabort_recursive_edit):
255 * lisp.h (die, args_out_of_range, args_out_of_range_3)
256 (wrong_type_argument, buffer_overflow, __executable_start)
257 (memory_full, buffer_memory_full, string_overflow, Fthrow)
258 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
259 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
261 (child_setup) [!DOS_NT]:
262 * lread.c (end_of_file_error, invalid_syntax):
263 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
264 * puresize.h (pure_write_error):
265 * search.c (matcher_overflow):
266 * sound.c (sound_perror, alsa_sound_perror):
267 * sysdep.c, syssignal.h (croak):
268 * term.c (maybe_fatal, vfatal):
269 * textprop.c (text_read_only):
270 * undo.c (user_error):
271 * unexmacosx.c (unexec_error):
272 * xterm.c (x_ins_del_lines, x_delete_glyphs):
273 Use _Noreturn rather than NO_RETURN.
274 No need for separate decl merely because of _Noreturn.
275 * sound.c (sound_warning, parse_sound):
276 Remove unnecessary forward decls.
278 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
280 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
281 * lisp.h (WAIT_READING_MAX): New macro.
282 * dispnew.c (Fsleep_for, sit_for):
283 * keyboard.c (kbd_buffer_get_event):
284 * process.c (Faccept_process_output):
285 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
286 This improves on the previous patch, which introduced a bug
287 when time_t is unsigned and as wide as intmax_t.
288 See <http://bugs.gnu.org/9000#51>.
290 2012-06-23 Eli Zaretskii <eliz@gnu.org>
292 * dispnew.c (sit_for, Fsleep_for):
293 * keyboard.c (kbd_buffer_get_event):
294 * process.c (Faccept_process_output): Avoid compiler warnings when
295 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
297 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
299 * makefile.w32-in: Update dependencies.
301 * w32.c (ltime): Add return type and declare static.
302 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
304 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
306 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
307 Privately reported by Herbert J. Skuhra.
308 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
310 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
311 not make_lisp_timeval, when the argument is of type EMACS_TIME.
313 2012-06-23 Eli Zaretskii <eliz@gnu.org>
315 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
316 last argument of make_unibyte_string.
318 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
319 language ID in the event parameters.
321 * w32term.c (w32_read_socket): Put the new keyboard codepage into
322 event.code, not the obscure "character set ID".
324 2012-06-23 Chong Yidong <cyd@gnu.org>
326 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
328 2012-06-23 Eli Zaretskii <eliz@gnu.org>
330 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
331 * w32.c (fdutimens): New function.
333 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
335 * s/ms-w32.h (pselect): Redirect to sys_select.
337 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
339 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
340 in the logic of incrementing and decrementing the value of
341 use_relocatable_buffers.
343 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
345 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
346 Privately reported by Herbert J. Skuhra.
347 [__FreeBSD__]: Remove "*/" typo after "#include".
348 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
349 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
350 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
351 Don't assume EMACS_TIME and struct timeval are the same type.
353 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
355 Support higher-resolution time stamps (Bug#9000).
356 The time stamps are only nanosecond-resolution at the C level,
357 since that's the best that any real-world system supports now.
358 But they are picosecond-resolution at the Lisp level, as that's
359 easy, and leaves room for future OS improvements.
361 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
364 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
365 Don't get current time unless it's needed.
367 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
368 now provides it if it's absent.
369 (start_atimer): Port to higher-res time stamps.
370 Check for time stamp overflow. Don't get current time more
371 often than is needed.
373 * buffer.h (struct buffer): Buffer modtime now has high resolution.
374 Include systime.h, not time.h.
375 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
377 * dired.c: Include stat-time.h.
378 (Ffile-attributes): File times now have higher resolution.
380 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
381 (struct image): Timestamp now has higher resolution.
383 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
384 has at least microseconds now. All uses removed.
385 (update_frame, update_single_window, update_window, update_frame_1)
386 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
388 * editfns.c (time_overflow): Now extern.
389 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
390 (float-time, Fformat_time_string, Fcurrent_time_string)
391 (Fcurrent_time_zone): Accept and generate higher-resolution
393 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
394 (decode_time_components, lisp_seconds_argument): New functions.
395 (make_time): Now static.
396 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
397 Report an error if the time is invalid, rather than having the caller
400 * fileio.c: Include <stat-time.h>
401 (Fcopy_file): Copy higher-resolution time stamps.
402 Prefer to set the time stamp via a file descriptor if that works.
403 (Fset_file_times, Finsert_file_contents, Fwrite_region)
404 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
405 (Fvisited_file_modtime, Fset_visited_file_modtime):
406 Support higher-resolution time stamps.
408 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
410 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
412 * image.c (prepare_image_for_display, clear_image_cache)
413 (lookup_image): Port to higer-resolution time stamps.
415 * keyboard.c (start_polling, bind_polling_period):
416 Check for time stamp overflow.
417 (read_char, kbd_buffer_get_event, timer_start_idle)
418 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
419 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
420 Port to higher-resolution time stamps. Do not assume time_t is signed.
421 (decode_timer): New function. Timers are now vectors of length 9,
422 not 8, to accommodate the picosecond component.
423 (timer_check_2): Use it.
425 * nsterm.m (select_timeout, timeval_subtract): Remove.
426 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
427 as they're a bit more accurate and handle overflow better.
428 (ns_select): Change prototype to be compatible with pselect.
429 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
430 * nsterm.h (ns_select): Adjust prototype.
432 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
433 us-resolution time stamps.
434 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
436 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
438 * lisp.h (time_overflow): New decl.
439 (wait_reading_process_output): First arg is now intmax_t, not int,
440 to accommodate larger waits.
442 * process.h (struct Lisp_Process.read_output_delay):
443 Now counts nanoseconds, not microseconds.
444 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
446 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
447 (wait_reading_process_output):
448 Port to ns-resolution time stamps.
449 (Faccept_process_output, wait_reading_process_output):
450 Check for time stamp overflow. Do not assume time_t is signed.
451 (select_wrapper): Remove; we now use pselect.
452 (Fprocess_attributes): Now generates ns-resolution time stamps.
454 * sysdep.c: Include utimens.h. Don't include utime.h
455 or worry about struct utimbuf; gnulib does that for us now.
456 (gettimeofday): Remove; gnulib provides a substitute.
457 (make_timeval): New function.
458 (set_file_times): Now sets ns-resolution time stamps.
459 New arg FD; all uses changed.
460 (time_from_jiffies, ltime_from_jiffies, get_up_time)
461 (system_process_attributes):
462 Now returns ns-resolution time stamp. All uses changed.
463 Check for time stamp overflow.
465 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
466 provides a substitute now.
468 * systime.h: Include timespec.h rather than sys/time.h and time.h,
469 since it guarantees struct timespec.
470 (EMACS_TIME): Now struct timespec, so that we can support
471 ns-resolution time stamps.
472 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
473 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
474 (EMACS_USECS): Remove.
475 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
476 so multiply the arg by 1000 before storing it.
477 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
479 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
480 Port to ns-resolution time stamps.
481 (EMACS_TIME_NEG_P): Remove; replaced by....
482 (EMACS_TIME_SIGN): New macro.
483 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
484 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
485 (set_file_times, make_time, lisp_time_argument): Adjust signature.
486 (make_timeval, make_lisp_time, decode_time_components): New decls.
487 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
488 that it mishandled time_t overflow. You can't compare by subtracting!
489 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
490 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
492 * term.c: Include <sys/time.h>.
493 (timeval_to_Time): New function, for proper overflow wraparound.
494 (term_mouse_position, term_mouse_click): Use it.
496 * undo.c (record_first_change): Support higher-resolution time stamps
498 (Fprimitive_undo): Use them when restoring time stamps.
500 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
501 (w32_get_internal_run_time):
502 Port to higher-resolution Emacs time stamps.
503 (ltime): Now accepts single 64-bit integer, as that's more convenient
506 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
508 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
509 for compatibility with pselect. Support ns-resolution time stamps.
511 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
513 * xselect.c (wait_for_property_change, x_get_foreign_selection):
514 Check for time stamp overflow, and support ns-resolution time stamps.
516 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
517 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
518 (timeval_subtract): Remove; no longer needed.
519 (XTflash, XTring_bell, x_wait_for_event):
520 Port to ns-resolution time stamps. Don't assume time_t is signed.
522 2012-06-22 Chong Yidong <cyd@gnu.org>
524 * xdisp.c (x_consider_frame_title): Revert last change.
526 2012-06-22 Eli Zaretskii <eliz@gnu.org>
528 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
529 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
530 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
531 staticidx goes up to 1597 out of 1600 = 0x640.)
533 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
535 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
536 Otherwise, the umask might be mistakenly 0 while handling input signals.
538 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
540 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
542 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
544 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
545 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
546 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
547 access to `contents' member of Lisp_Vector objects with AREF and ASET
550 2012-06-19 Chong Yidong <cyd@gnu.org>
552 * frame.c (delete_frame): When selecting a frame on a different
553 text terminal, do not alter the terminal's top-frame.
555 * xdisp.c (format_mode_line_unwind_data): Record the target
556 frame's selected window and its terminal's top-frame.
557 (unwind_format_mode_line): Restore them.
558 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
560 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
561 since tty frames can be explicitly named.
562 (prepare_menu_bars): Likewise.
564 * term.c (Ftty_top_frame): New function.
566 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
568 Port byte-code-meter to modern targets.
569 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
570 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
571 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
572 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
573 (METER_1, METER_2): Simplify.
575 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
577 * data.c (Fdefalias): Return `symbol' (bug#11686).
579 2012-06-18 Martin Rudalics <rudalics@gmx.at>
581 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
582 gets killed during executing of this function (Bug#11665).
583 Try to always return Qt when the buffer has been actually killed.
584 (Vkill_buffer_query_functions): In doc-string say that functions
585 run by this hook should not change the current buffer.
587 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
589 Fix recently-introduced process.c problems found by static checking.
590 * process.c (write_queue_push, write_queue_pop, send_process):
591 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
592 (write_queue_pop): Fix pointer signedness problem.
593 (send_process): Remove unused local.
595 2012-06-17 Chong Yidong <cyd@gnu.org>
597 * xdisp.c (redisplay_internal): No need to redisplay terminal
598 frames that are not on top.
600 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
602 * process.c (make_process): Initialize write_queue.
603 (write_queue_push, write_queue_pop): New functions.
604 (send_process): Use them to maintain correct ordering of process
607 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
609 * lisp.h (eassert): Assume C89 or later.
610 This removes the need for CHECK.
611 (CHECK): Remove. Its comments about always evaluating its
612 argument were confusing, as 'eassert' typically does not evaluate
615 * coding.c (produce_chars): Use ptrdiff_t, not int.
617 * xterm.c (x_draw_underwave): Check for integer overflow.
618 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
620 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
622 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
623 referenced (Bug#11583).
625 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
627 Implement wave-style variant of underlining.
628 * dispextern.h (face_underline_type): New enum.
629 (face): Add field for underline type.
630 * nsterm.m (ns_draw_underwave): New function.
631 (ns_draw_text_decoration): Use it.
632 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
634 (x_draw_glyph_string): Use them.
635 * xfaces.c (Qline, Qwave): New Lisp objects.
636 (check_lface_attrs, merge_face_ref)
637 (Finternal_set_lisp_face_attribute, realize_x_face):
638 Handle wave-style underline face attributes.
639 * xterm.c (x_draw_underwave): New function.
640 (x_draw_glyph_string): Use it.
642 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
644 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
645 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
646 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
647 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
648 ($(BLD)/w32select.$(O)): Update dependencies.
650 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
652 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
653 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
654 * character.c (_fetch_multibyte_char_p): Remove.
655 * alloc.c: Include "character.h" before "buffer.h".
657 * buffer.c: Likewise.
658 * bytecode.c: Likewise.
659 * callint.c: Likewise.
660 * callproc.c: Likewise.
661 * casefiddle.c: Likewise.
662 * casetab.c: Likewise.
663 * category.c: Likewise.
665 * coding.c: Likewise.
666 * composite.c: Likewise.
668 * dispnew.c: Likewise.
670 * dosfns.c: Likewise.
671 * editfns.c: Likewise.
673 * fileio.c: Likewise.
674 * filelock.c: Likewise.
676 * fontset.c: Likewise.
677 * fringe.c: Likewise.
678 * indent.c: Likewise.
679 * insdel.c: Likewise.
680 * intervals.c: Likewise.
681 * keyboard.c: Likewise.
682 * keymap.c: Likewise.
684 * macros.c: Likewise.
685 * marker.c: Likewise.
686 * minibuf.c: Likewise.
688 * nsmenu.m: Likewise.
690 * process.c: Likewise.
692 * region-cache.c: Likewise.
693 * search.c: Likewise.
694 * syntax.c: Likewise.
696 * textprop.c: Likewise.
698 * unexsol.c: Likewise.
699 * w16select.c: Likewise.
700 * w32fns.c: Likewise.
701 * w32menu.c: Likewise.
702 * window.c: Likewise.
707 * xselect.c: Likewise.
709 2012-06-16 Eli Zaretskii <eliz@gnu.org>
711 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
712 If all the glyphs of the glyph row came from strings, and we have no
713 cursor positioning clues, put the cursor on the first glyph of the
715 (handle_face_prop): Use chunk-relative overlay string index when
716 indexing into it->string_overlays array. (Bug#11653)
717 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
718 the rightmost. (Bug#11720)
720 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
722 * category.h (CHAR_HAS_CATEGORY): Define as inline.
723 (CATEGORY_MEMBER): Enforce 1/0 value.
724 * category.c (_temp_category_set): Remove.
726 2012-06-16 Eli Zaretskii <eliz@gnu.org>
728 * window.c (Fdelete_other_windows_internal)
729 (Fdelete_window_internal): Don't access frame's mouse highlight
730 info of the initial frame. (Bug#11677)
732 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
734 * .gdbinit (xgetint): Fix recently-introduced paren typo.
735 Assume USE_2_TAGS_FOR_INTS.
736 (xreload): Adjust $tagmask width to match recent lisp.h change.
738 Simplify lisp.h in minor ways that should not affect code.
739 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
740 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
741 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
742 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
743 (INTTYPEBITS): New macro, for clarity.
744 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
745 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
746 Simplify now that USE_LSB_TAG is always defined.
747 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
748 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
750 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
752 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
754 2012-06-13 Glenn Morris <rgm@gnu.org>
756 * s/bsd-common.h (BSD4_3):
757 * s/usg5-4-common.h (USG5_4): No longer define; unused.
759 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
761 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
764 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
766 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
767 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
768 * alloc.c (widen_to_Lisp_Object): Remove.
769 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
770 * frame.c (delete_frame): Remove outdated comment.
771 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
773 (Fw32_unregister_hot_key): Likewise.
774 (Fw32_toggle_lock_key): Likewise.
775 * w32menu.c (add_menu_item): Likewise.
776 (w32_menu_display_help): Use XIL instead of checking
778 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
779 (init_heap): Likewise.
780 * w32term.c (w32_read_socket): Update comment.
782 2012-06-13 Glenn Morris <rgm@gnu.org>
784 * s/usg5-4-common.h, src/s/unixware.h:
785 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
787 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
789 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
791 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
792 * alloc.c (make_number) [!defined make_number]:
793 Remove, as lisp.h always defines this now.
794 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
795 (roundup_size): Verify that it is a power of 2.
796 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
797 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
798 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
799 -DUSE_LSB_TAG=0, to override the automatically-selected default.
800 USE_LSB_TAG now is always defined to be either 0 or 1.
802 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
803 code works fine either way, and efficiency is not a concern here,
804 as the union type is for debugging, not for production.
805 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
806 Use an inline function on all platforms when using the union type,
807 since this is simpler and 'static inline' can be used portably
809 (LISP_INITIALLY_ZERO): New macro.
810 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
811 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
813 2012-06-12 Glenn Morris <rgm@gnu.org>
815 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
817 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
819 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
820 Move BROKEN_SIGIO to configure.
822 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
823 Move NO_TERMIO to configure.
825 2012-06-12 Chong Yidong <cyd@gnu.org>
827 * image.c (imagemagick_load_image): Use MagickFlattenImage if
828 MagickMergeImageLayers is undefined. Use pixel pusher loop if
829 MagickExportImagePixels is undefined.
831 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
833 * image.c (imagemagick_load_image): Remove unused label.
835 2012-06-11 Glenn Morris <rgm@gnu.org>
837 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
838 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
839 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
840 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
842 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
844 * alloc.c (make_byte_code): New function.
845 (Fmake_byte_code): Use it. Don't purify here.
846 * lread.c (read1): Use it as well to avoid extra allocation.
848 2012-06-11 Chong Yidong <cyd@gnu.org>
850 * image.c (imagemagick_load_image): Implement transparency.
852 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
854 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
855 account for preceding backslashes. (Bug#11663)
857 2012-06-09 Chong Yidong <cyd@gnu.org>
859 * term.c: Support italics in capable terminals (Bug#9652).
860 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
861 (turn_on_face): Output using TS_enter_italic_mode if available.
862 Don't handle unused blinking and alt-charset cases.
863 (turn_off_face): Handle italic case; discard unused tty_blinking_p
864 and tty_alt_charset_p cases.
865 (tty_capable_p, init_tty): Support italics.
867 * termchar.h (struct tty_display_info): Add field for italics.
868 Remove unused blink field.
870 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
873 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
874 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
875 tty_alt_charset_p. Add tty_italic_p.
877 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
879 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
880 dbus_type_is_basic if available.
881 (xd_extract_signed, xd_extract_unsigned): Rename from
882 extract_signed and extract_unsigned, respectively. Adapt callers.
884 2012-06-09 Chong Yidong <cyd@gnu.org>
886 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
888 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
891 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
893 * xdisp.c (vmessage): Treat frame message as multibyte.
894 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
895 would generate the diagnostic "Making \302\247 buffer-local while
898 2012-06-08 Eli Zaretskii <eliz@gnu.org>
900 * dispnew.c (showing_window_margins_p): Undo last change, which
901 was done due to an inadvertent commit.
902 (adjust_frame_glyphs_for_frame_redisplay): Do call
903 showing_window_margins_p.
905 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
907 * eval.c (Fmake_var_non_special): New primitive.
908 (syms_of_eval): Defsubr it.
909 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
911 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
913 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
914 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
916 2012-06-08 Eli Zaretskii <eliz@gnu.org>
918 * alloc.c (allocate_vectorlike): Fix last change.
920 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
922 Block-based vector allocation of small vectors.
923 * lisp.h (struct vectorlike_header): New field `nbytes',
924 adjust comment accordingly.
925 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
926 to denote vector blocks. Adjust users (live_vector_p,
927 mark_maybe_pointer, valid_lisp_object_p) accordingly.
928 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
929 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
930 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
931 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
932 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
933 (roundup_size): New constant.
934 (struct vector_block): New data type.
935 (vector_blocks, vector_free_lists, zero_vector): New variables.
936 (all_vectors): Rename to `large_vectors'.
937 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
938 (sweep_vectors): New functions.
939 (allocate_vectorlike): Return `zero_vector' as the only vector of
940 0 items. Allocate new vector from block if vector size is less than
941 or equal to VBLOCK_BYTES_MAX.
942 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
943 (init_alloc_once): Add call to init_vectors.
945 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
947 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
949 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
951 * doprnt.c (doprnt): Truncate multibyte char correctly.
952 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
953 would mishandle a string argument "Xc" if X was a multibyte
954 character of length 2: it would truncate after X's first byte
955 rather than including all of X.
957 2012-06-06 Chong Yidong <cyd@gnu.org>
959 * buffer.c (word_wrap): Doc fix.
961 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
963 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
965 2012-06-03 Glenn Morris <rgm@gnu.org>
967 * xdisp.c (tool-bar-style): Doc fix.
969 2012-06-03 Ulrich Müller <ulm@gentoo.org>
971 * Makefile.in (PAXCTL): Define.
972 (temacs$(EXEEXT)): Disable memory randomization for the temacs
973 binary via PaX flags if the paxctl utility is available.
974 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
975 Restore PaX flags to their default. (Bug#11398)
977 2012-06-03 Chong Yidong <cyd@gnu.org>
979 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
982 2012-06-03 Chong Yidong <cyd@gnu.org>
984 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
985 (note_mode_line_or_margin_highlight): If there is no help echo,
986 use mode-line-default-help-echo. Handle the case where the mouse
987 position is past the end of the mode line string.
989 * buffer.c (buffer_local_value_1): New function, split from
990 Fbuffer_local_value; can return Qunbound.
991 (Fbuffer_local_value): Use it.
992 (Vmode_line_format): Docstring tweaks.
994 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
996 * sysdep.c (system_process_attributes): Improve comment.
998 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1000 * keyboard.c: Export real-this-command to Elisp.
1001 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1002 and DEFVAR it. Update all users.
1004 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1006 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1008 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1009 Convert pctcpu and pctmem to Lisp float properly.
1010 Let the compiler fold better, as 100.0/0x8000 is exact.
1012 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1014 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1017 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1019 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1021 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1023 For a 'struct window', replace some Lisp_Object fields to
1024 bitfields where appropriate, remove unused fields.
1025 * window.h (struct window): Remove unused 'last_mark_x' and
1026 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1027 change it's type from Lisp_Object to bitfield.
1028 Change type of 'force_start', 'optional_new_start',
1029 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1030 fields from Lisp_Object to bitfield. Adjust users accordingly.
1032 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1034 Pacify gcc -Wdouble-precision when using Xaw.
1035 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1036 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1037 Use 'float' consistently, rather than 'float' in most places
1038 and 'double' in a couple of places.
1040 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1042 * xdisp.c (handle_stop): Detect whether we have overlay strings
1043 loaded by testing it->current.overlay_string_index to be
1044 non-negative, instead of checking whether n_overlay_strings is
1045 positive. (Bug#11587)
1047 2012-05-31 Chong Yidong <cyd@gnu.org>
1049 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1051 * doc.c (Fsubstitute_command_keys): Doc fix.
1053 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1055 * search.c (search_buffer): Remove calls to
1056 r_alloc_inhibit_buffer_relocation, as it is now called by
1057 maybe_unify_char, which was the cause of relocation of buffer text
1060 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1062 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1063 for the duration of call to load_charset, to avoid problems with
1064 callers of maybe_unify_char that access buffer text through C
1067 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1068 decrement the inhibition flag, instead of just setting or
1071 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1073 Remove obsolete '#define static' cruft.
1074 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1075 This #undef was "temporary" in 2000; it is no longer needed
1076 now that '#define static' has gone away.
1077 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1078 (gray_bitmap_bits): Remove; no longer needed.
1079 All uses replaced with definiens.
1080 * xterm.c: Include "bitmaps/gray.xbm".
1082 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1084 Clean up __executable_start, monstartup when --enable-profiling.
1085 The following changes affect the code only when profiling.
1086 * dispnew.c (__executable_start): Rename from safe_bcopy.
1087 Define only on platforms that need it.
1088 * emacs.c: Include <sys/gmon.h> when profiling.
1089 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1090 (__executable_start): Remove decl, since lisp.h does it now.
1091 (safe_bcopy): Remove decl; no longer has that name.
1092 (main): Coalesce #if into single bit of code, for simplicity.
1093 Cast pointers to uintptr_t, since standard libraries want integers
1095 * lisp.h (__executable_start): New decl.
1097 2012-05-31 Glenn Morris <rgm@gnu.org>
1099 * image.c (Fimagemagick_types): Doc fix.
1101 2012-05-30 Jim Meyering <meyering@redhat.com>
1103 * callproc.c (Fcall_process_region): Include directory component
1104 in mkstemp error message (Bug#11586).
1106 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1108 * alloc.c, lisp.h (make_pure_vector): Now static.
1110 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1112 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1113 Move to byte-run.el.
1114 (Fautoload): Do the hash-doc more carefully.
1115 * data.c (Fdefalias): Purify definition, except for keymaps.
1116 (Qdefun): Move from eval.c.
1117 * lisp.h (Qdefun): Remove.
1118 * lread.c (read1): Tiny simplification.
1120 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1122 Do not create empty overlays with the evaporate property (Bug#9642).
1123 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1124 Bug#9642, but explicitly check that the buffer the overlay would
1125 be moved to is live and rearrange lines to make sure that errors
1126 will not put the overlay in an inconsistent state.
1127 (Fdelete_overlay): Cosmetics.
1129 2012-05-28 Eli Zaretskii <eliz@gnu.org>
1131 * w32term.c (my_bring_window_to_top): New function.
1132 (x_raise_frame): Use handle returned by DeferWindowPos, which
1133 could be different from the original one.
1134 Call my_bring_window_to_top instead of my_set_foreground_window.
1137 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1138 by calling BringWindowToTop.
1140 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1141 (WM_EMACS_END): Increase by one.
1143 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1145 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1146 This avoids undefined behavior that might cause the eassert
1147 to not catch an out-of-range value.
1149 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1151 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1152 Update dependencies.
1154 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1156 * bidi.c (bidi_mirror_char): Fix last change.
1158 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1160 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1161 when referring to sectname field in printf format.
1163 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1165 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1166 Only r_alloc_inhibit_buffer_relocation needed to be added;
1167 the others were already declared.
1169 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1170 before checking whether it's out of range. Put the check inside
1172 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1174 2012-05-27 Ken Brown <kbrown@cornell.edu>
1176 * callproc.c (Fcall_process): Restore a line that was accidentally
1177 commented out in the 2011-02-13 change (bug#11547).
1179 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1181 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1182 defined on ralloc.c.
1184 * buffer.c [REL_ALLOC]: Remove prototypes of
1185 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1186 they are now on lisp.h.
1188 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1190 * search.c (search_buffer): Use it to inhibit relocation of buffer
1191 text while re_search_2 is doing its job, because re_search_2 is
1192 passed C pointers to buffer text. (Bug#11519)
1194 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1197 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1198 state after an additional call to move_it_in_display_line_to, keep
1199 the values of it->max_ascent and it->max_descent found for the
1201 (pos_visible_p): Revert the comparison against bottom_y to what it
1202 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1205 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1207 Fix coding-related core dumps with gcc -ftrapv.
1208 The code was computing A - B, where A and B are pointers, and B is
1209 random garbage. This can lead to core dumps on platforms that
1210 have special pointer registers, and it also leads to core dumps on
1211 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1212 A - B only when B is initialized properly.
1213 * coding.c (coding_set_source, coding_set_destination): Return void.
1214 (coding_change_source, coding_change_destinations): New functions,
1215 with the old behaviors of coding_set_source and coding_set_destination.
1216 All callers that need an offset changed to use these new functions.
1218 2012-05-26 Glenn Morris <rgm@gnu.org>
1220 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1222 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1224 Extend mouse support on W32 text-mode console.
1225 * xdisp.c (draw_row_with_mouse_face):
1226 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1228 * w32console.c: Include window.h.
1229 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1231 (initialize_w32_display): Initialize mouse-highlight data.
1233 * w32inevt.c: Include termchar.h and window.h.
1234 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1235 moves, call note_mouse_highlight. If help_echo changed, call
1236 gen_help_event to produce help-echo message in the echo area.
1237 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1240 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1242 * lread.c (read1): Simplify slightly to avoid an overflow warning
1243 with GCC 4.7.0 on x86-64.
1245 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1247 * bidi.c (bidi_mirror_char): Revert last change: an int is
1248 definitely wide enough here.
1250 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
1252 Fix integer width and related bugs (Bug#9874).
1253 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
1254 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1255 (string_bytes, check_sblock, allocate_string_data):
1256 (compact_small_strings, Fmake_bool_vector, make_string)
1257 (make_unibyte_string, make_multibyte_string)
1258 (make_string_from_bytes, make_specified_string)
1259 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1260 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1262 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1263 (allocate_pseudovector):
1264 Use int, not EMACS_INT, where int is wide enough.
1265 (inhibit_garbage_collection, Fgarbage_collect):
1266 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1267 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1268 int might not be wide enough.
1269 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1270 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1271 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1272 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1273 (bidi_level_of_next_char, bidi_move_to_visually_next):
1274 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1275 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1276 (Fkill_buffer, Fset_buffer_major_mode)
1277 (advance_to_char_boundary, Fbuffer_swap_text)
1278 (Fset_buffer_multibyte, overlays_at, overlays_in)
1279 (overlay_touches_p, struct sortvec, record_overlay_string)
1280 (overlay_strings, recenter_overlay_lists)
1281 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1282 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1283 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1284 (Foverlay_recenter, last_overlay_modification_hooks_used)
1285 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1286 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1287 (validate_region): Omit unnecessary test for b <= e,
1288 since that's guaranteed by the previous test.
1289 (adjust_overlays_for_delete): Avoid pos + length overflow.
1290 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1291 (report_overlay_modification):
1292 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1293 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1294 Omit pointer cast, which isn't needed anyway, and doesn't work
1295 after the EMACS_INT -> ptrdiff_t change.
1296 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
1297 * buffer.h: Adjust decls to match defn changes elsewhere.
1298 (struct buffer_text, struct buffer):
1299 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1300 Use EMACS_INT, not int, where int might not be wide enough.
1301 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1302 not int, to avoid needless 32-bit limit on 64-bit hosts.
1303 (exec_byte_code): Use tighter memory-full test, one that checks
1304 for alloca overflow. Don't compute the address of the object just
1305 before an array, as that's not portable. Use EMACS_INT, not
1306 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
1307 * callint.c (Fcall_interactively):
1308 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1309 * callproc.c (call_process_kill, Fcall_process):
1310 Don't assume pid_t fits into an Emacs fixnum.
1311 (call_process_cleanup, Fcall_process, child_setup):
1312 Don't assume pid_t fits into int.
1313 (call_process_cleanup, Fcall_process, delete_temp_file)
1314 (Fcall_process_region):
1315 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1316 (Fcall_process): Simplify handling of volatile integers.
1317 Use int, not EMACS_INT, where int will do.
1318 * casefiddle.c (casify_object, casify_region, operate_on_word)
1319 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1320 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1321 (casify_object): Avoid integer overflow when overallocating buffer.
1322 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
1323 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
1324 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1325 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1326 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1327 integers are now checked earlier. All uses replaced with XINT.
1329 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1330 For CCL_MapSingle, check that content and value are in int range.
1331 (ccl_driver, Fregister_code_conversion_map):
1332 Check that Vcode_version_map_vector is a vector.
1333 (resolve_symbol_ccl_program): Check that vector header is in range.
1334 Always copy the vector, so that we can check its contents reliably
1335 now rather than having to recheck each instruction as it's being
1336 executed. Check that vector words fit in 'int'.
1337 (ccl_get_compiled_code, Fregister_ccl_program)
1338 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1339 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1340 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1341 contents are in range.
1342 (Fccl_execute_on_string): Check that status is in range.
1343 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1344 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1345 Accept and return EMACS_INT, not int, because callers can pass values
1347 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1348 (multibyte_chars_in_text, parse_str_as_multibyte)
1349 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1350 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1351 (string_escape_byte8, Fget_byte):
1352 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1353 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
1354 avoid mishandling large integers.
1355 * character.h: Adjust decls to match defn changes elsewhere.
1356 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1357 (Ffind_charset_region):
1358 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1359 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1360 (load_charset_map_from_vector, Fdefine_charset_internal):
1361 Don't assume fixnum fits in int.
1362 (load_charset_map_from_vector, Fmap_charset_chars):
1363 Remove now-unnecessary CHECK_NATNUMs.
1364 (Fdefine_charset_internal): Check ranges here, more carefully.
1365 Don't rely on undefined behavior with signed left shift overflow.
1366 Don't assume unsigned int fits into fixnum, or that fixnum fits
1367 into unsigned int. Don't require max_code to be a valid fixnum;
1368 that's not true for gb10830 4-byte on a 32-bit host. Allow
1369 invalid_code to be a cons, for the same reason. Require code_offset
1370 to be a character. Avoid int overflow if max_char is close
1372 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1373 this is intended anyway and avoids some undefined behavior.
1374 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1375 INDEX_TO_CODE_POINT, as that's what it expects.
1376 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
1377 * charset.h (DECODE_CHAR): Return int, not unsigned;
1378 this is what was intended anyway, and it avoids undefined behavior.
1379 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1380 integer-overflow issues.
1381 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1382 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1383 where the argument is EMACS_INT, and this behavior is not intended.
1384 * chartab.c (Fmake_char_table, Fset_char_table_range)
1385 (uniprop_get_decoder, uniprop_get_encoder):
1386 Don't assume fixnum fits in int.
1387 * cmds.c (move_point): New function, that does the gist of
1388 Fforward_char and Fbackward_char, but does so while checking
1389 for integer overflow more accurately.
1390 (Fforward_char, Fbackward_char): Use it.
1391 (Fforward_line, Fend_of_line, internal_self_insert)
1392 (internal_self_insert):
1393 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1394 Fix a FIXME, by checking for integer overflow when calculating
1395 target_clm and actual_clm.
1396 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
1397 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
1398 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1399 (coding_alloc_by_making_gap, alloc_destination)
1400 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1401 (encode_coding_utf_16, detect_coding_emacs_mule)
1402 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1403 (detect_coding_iso_2022, decode_coding_iso_2022)
1404 (encode_invocation_designation, encode_designation_at_bol)
1405 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1406 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1407 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1408 (encode_coding_ccl, encode_coding_raw_text)
1409 (detect_coding_charset, decode_coding_charset)
1410 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1411 (produce_composition, produce_charset, produce_annotation)
1412 (decode_coding, handle_composition_annotation)
1413 (handle_charset_annotation, consume_chars, decode_coding_gap)
1414 (decode_coding_object, encode_coding_object, detect_coding_system)
1415 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1416 (code_convert_region, code_convert_string)
1417 (Fdefine_coding_system_internal)
1418 (coding_set_source, coding_set_destination):
1419 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1420 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1421 (Fdefine_coding_system_internal):
1422 Don't assume fixnums fit in int.
1423 (decode_coding_gap, decode_coding_object, encode_coding_object)
1424 (Fread_coding_system, Fdetect_coding_region)
1425 (Funencodable_char_position, Fcheck_coding_systems_region)
1426 (get_translation, handle_composition_annotation, consume_chars):
1427 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1428 (consume_chars): Rewrite to not calculate an address outside buffer.
1429 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
1430 Don't access memory outside of the args array.
1431 (Fdefine_coding_system_internal): Check for charset-id overflow.
1432 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1433 result of ENCODE_CHAR.
1434 * coding.h: Adjust decls to match defn changes elsewhere.
1435 (struct coding_system):
1436 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1437 * composite.c (get_composition_id, find_composition)
1438 (run_composition_function, update_compositions)
1439 (compose_text, composition_gstring_put_cache)
1440 (composition_gstring_p, composition_gstring_width)
1441 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1442 (composition_compute_stop_pos, composition_reseat_it)
1443 (composition_update_it, struct position_record)
1444 (find_automatic_composition, composition_adjust_point)
1445 (Fcomposition_get_gstring, Ffind_composition_internal):
1446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1447 (update_compositions):
1448 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1449 * composite.h: Adjust decls to match defn changes elsewhere.
1450 (struct composition):
1451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1452 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1453 Do not attempt to compute the address of the object just before a
1454 buffer; this is not portable.
1456 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1457 (Faset): Use int, not EMACS_INT, where int is wide enough.
1458 (Fstring_to_number): Don't assume fixnums fit in int.
1459 (Frem): Don't assume arg is nonnegative.
1460 * dbusbind.c (xd_append_arg): Check for integers out of range.
1461 (Fdbus_call_method): Don't overflow the timeout int.
1462 (extract_signed, extract_unsigned): New functions.
1463 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1464 (xd_get_connection_references): Return ptrdiff_t, not int.
1466 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1467 (xd_read_message_1):
1468 Use int, not unsigned, where the dbus API uses int.
1469 (Fdbus_message_internal): Don't overflow mtype.
1470 (syms_of_dbusbind): Allocate right-sized buffer for integers.
1471 * dired.c (directory_files_internal, file_name_completion, scmp)
1472 (file_name_completion_stat):
1473 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1474 (file_name_completion): Don't overflow matchcount.
1475 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1476 * dispextern.h: Adjust decls to match defn changes elsewhere.
1477 (struct text_pos, struct glyph, struct bidi_saved_info)
1478 (struct bidi_string_data, struct bidi_it, struct composition_it)
1480 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1481 (struct display_pos, struct composition_it, struct it):
1482 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1483 * dispnew.c (increment_matrix_positions)
1484 (increment_row_positions, mode_line_string)
1485 (marginal_area_string):
1486 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1487 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
1488 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1489 (duration_to_sec_usec): New function, to check for overflow better.
1490 (Fsleep_for, sit_for): Use it.
1491 * doc.c (get_doc_string, store_function_docstring):
1492 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1493 (get_doc_string, Fsnarf_documentation):
1494 Use int, not EMACS_INT, where int is wide enough.
1496 Use SAFE_ALLOCA, not alloca.
1497 Check for overflow when converting EMACS_INT to off_t.
1498 * doprnt.c (doprnt):
1499 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1500 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1501 Don't assume uid_t fits into fixnum.
1502 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1503 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1504 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1505 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1506 (general_insert_function)
1507 (Finsert_char, make_buffer_string, make_buffer_string_both)
1508 (update_buffer_properties, Fbuffer_substring)
1509 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1510 (Fsubst_char_in_region, check_translation)
1511 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1512 (transpose_markers, Ftranspose_regions):
1513 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1514 (clip_to_bounds): Move to lisp.h as an inline function).
1515 (Fconstrain_to_field): Don't assume integers are nonnegative.
1516 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1517 (Fsubst_char_in_region, Fsave_restriction):
1518 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1519 (Femacs_pid): Don't assume pid_t fits into fixnum.
1520 (lo_time): Use int, not EMACS_INT, when int suffices.
1521 (lisp_time_argument): Check for usec out of range.
1522 (Fencode_time): Don't assume fixnum fits in int.
1523 (Fuser_login_name, Fuser_full_name): Signal an error
1524 if a uid argument is out of range, rather than relying on
1526 (Fformat_time_string): Remove now-unnecessary check.
1527 lisp_time_argument checks for out-of-range usec now.
1528 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
1529 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1530 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1531 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1532 (init_cmdargs, Fdump_emacs):
1533 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1534 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1535 the bottom (typically) 32 bits of the fixnum.
1536 * eval.c (specpdl_size, call_debugger):
1537 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1538 (when_entered_debugger, Fbacktrace_debug):
1539 Don't assume fixnum can fit in int.
1540 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1541 the object just before a buffer; this is not portable.
1542 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1543 (grow_specpdl, unbind_to):
1544 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1545 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1546 (grow_specpdl): Simplify allocation by using xpalloc.
1547 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
1548 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1549 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1550 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1551 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1553 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1554 (Fcopy_file, non_regular_nbytes, read_non_regular)
1555 (Finsert_file_contents):
1556 Use int, not EMACS_INT, where int is wide enough.
1557 (READ_BUF_SIZE): Verify that it fits in int.
1558 (Finsert_file_contents): Check that counts are in proper range,
1559 rather than assuming fixnums fit into ptrdiff_t etc.
1560 Don't assume fixnums fit into int.
1561 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
1562 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1563 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
1564 (string_char_to_byte, string_byte_to_char)
1565 (string_make_multibyte, string_to_multibyte)
1566 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1567 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1568 (substring_both, Fdelete, internal_equal, Ffillarray)
1569 (Fclear_string, mapcar1)
1570 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1571 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1572 (larger_vector, make_hash_table, maybe_resize_hash_table)
1573 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1574 (Fmaphash, secure_hash):
1575 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1576 (concat): Check for string index and length overflow.
1577 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1579 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1580 (larger_vector): New API (vec, incr_min, size_max) replaces old
1581 one (vec, new_size, init). This catches size overflow.
1582 INIT was removed because it was always Qnil.
1583 All callers changed.
1584 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1585 the upper bound on a hash table index size.
1586 (make_hash_table, maybe_resize_hash_table): Use it.
1587 (secure_hash): Computer start_byte and end_byte only after
1588 they're known to be in ptrdiff_t range.
1589 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1590 (Ffont_get_glyphs, Ffont_at):
1591 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1592 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1593 (Flist_fonts, Fopen_font):
1594 Don't assume fixnum can fit in int.
1595 (check_gstring): Don't assume index can fit in int.
1596 (font_match_p): Check that fixnum is a character, not a nonnegative
1597 fixnum, since the later code needs to stuff it into an int.
1598 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1599 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1600 conversion overflow issues.
1601 (Fopen_font): Check for integer out of range.
1602 (Ffont_get_glyphs): Don't assume index can fit in int.
1603 * font.h: Adjust decls to match defn changes elsewhere.
1604 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1606 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1607 printmax_t, where ptrdiff_t is wide enough.
1608 (Finternal_char_font):
1609 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1610 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1611 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1612 (Fset_frame_position, x_set_frame_parameters)
1613 (x_set_line_spacing, x_set_border_width)
1614 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1615 Check that fixnums are in proper range for system types.
1616 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1617 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1618 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1619 Use SAFE_ALLOCA_LISP, not alloca.
1620 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1621 intptr_t is wide enough.
1622 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1623 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1624 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1625 Check for fixnum out of range.
1626 * ftfont.c (ftfont_list): Don't assume index fits in int.
1627 Check that fixnums are in proper range for system types.
1628 (ftfont_shape_by_flt):
1629 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1630 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1631 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1632 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1633 Check that fixnums are in proper range for system types.
1634 * gnutls.h: Adjust decls to match defn changes elsewhere.
1635 * gtkutil.c (xg_dialog_run):
1636 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1637 (update_frame_tool_bar):
1638 Check that fixnums are in proper range for system types.
1639 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
1640 (lookup_image): Check that fixnums are in range for system types.
1641 * indent.c (last_known_column, last_known_column_point):
1642 (current_column_bol_cache):
1643 (skip_invisible, current_column, check_display_width):
1644 (check_display_width, scan_for_column, current_column_1)
1645 (Findent_to, Fcurrent_indentation, position_indentation)
1646 (indented_beyond_p, Fmove_to_column, compute_motion):
1647 (Fcompute_motion, Fvertical_motion):
1648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1649 (last_known_column_modified): Use EMACS_INT, not int.
1650 (check_display_width):
1652 Check that fixnums and floats are in proper range for system types.
1653 (compute_motion): Don't assume index or fixnum fits in int.
1654 (compute_motion, Fcompute_motion):
1655 Use int, not EMACS_INT, when it is wide enough.
1656 (vmotion): Omit local var start_hpos that is always 0; that way
1657 we don't need to worry about overflow in expressions involving it.
1658 * indent.h: Adjust decls to match defn changes elsewhere.
1660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1661 Use int, not EMACS_INT, where int is wide enough.
1662 Remove unused members ovstring_chars_done and tab_offset;
1664 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1665 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1666 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1667 (make_gap, copy_text, insert, insert_and_inherit)
1668 (insert_before_markers, insert_before_markers_and_inherit)
1669 (insert_1, count_combining_before, count_combining_after)
1670 (insert_1_both, insert_from_string)
1671 (insert_from_string_before_markers, insert_from_string_1)
1672 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1673 (adjust_after_replace, adjust_after_insert, replace_range)
1674 (replace_range_2, del_range, del_range_1, del_range_byte)
1675 (del_range_both, del_range_2, modify_region)
1676 (prepare_to_modify_buffer, signal_before_change)
1677 (signal_after_change, Fcombine_after_change_execute):
1678 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1679 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1680 (balance_an_interval, split_interval_right, split_interval_left)
1681 (find_interval, next_interval, update_interval)
1682 (adjust_intervals_for_insertion, delete_node, delete_interval)
1683 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1684 (static_offset_intervals, offset_intervals)
1685 (merge_interval_right, merge_interval_left, make_new_interval)
1686 (graft_intervals_into_buffer, temp_set_point_both)
1687 (temp_set_point, set_point, adjust_for_invis_intang)
1688 (set_point_both, move_if_not_intangible, get_property_and_range)
1689 (get_local_map, copy_intervals, copy_intervals_to_string)
1690 (compare_string_intervals, set_intervals_multibyte_1):
1691 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1692 * intervals.h: Adjust decls to match defn changes elsewhere.
1694 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1695 * keyboard.c (this_command_key_count, this_single_command_key_start)
1696 (before_command_key_count, before_command_echo_length, echo_now)
1697 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1698 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1699 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1700 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1701 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1702 (last_non_minibuf_size, last_point_position, echo_truncate)
1703 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1704 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1705 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1706 (stuff_buffered_input):
1707 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1708 (last_auto_save, command_loop_1, read_char):
1709 Use EMACS_INT, not int, to avoid integer overflow.
1710 (record_char): Avoid overflow in total_keys computation.
1711 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1712 * keyboard.h: Adjust decls to match defn changes elsewhere.
1713 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1714 (Fkey_description, Fdescribe_vector, Flookup_key):
1715 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1716 (click_position): New function, to check that positions are in range.
1717 (Fcurrent_active_maps):
1719 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1720 (Faccessible_keymaps, Fkey_description):
1721 (preferred_sequence_p):
1722 Don't assume fixnum can fit into int.
1723 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1724 Check for integer overflow in size calculations.
1725 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1726 avoid mishandling large integers.
1727 * lisp.h: Adjust decls to match defn changes elsewhere.
1728 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1729 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1730 (struct Lisp_Marker):
1731 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1732 (clip_to_bounds): Now an inline function, moved here from editfns.c.
1733 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1734 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1735 All callers changed.
1736 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1737 Assume the arg has valid form, since it always does.
1738 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1739 unsigned integer system type.
1740 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1741 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1742 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1743 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1744 (duration_to_sec_usec): New decl.
1745 * lread.c (read_from_string_index, read_from_string_index_byte)
1746 (read_from_string_limit, readchar, unreadchar, openp)
1747 (read_internal_start, read1, oblookup):
1748 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1749 (Fload, readevalloop, Feval_buffer, Feval_region):
1750 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1751 (openp): Check for out-of-range argument to 'access'.
1752 (read1): Use int, not EMACS_INT, where int is wide enough.
1753 Don't assume fixnum fits into int.
1754 Fix off-by-one error that can read outside a buffer.
1755 (read_filtered_event): Use duration_to_sec_usec
1756 to do proper overflow checking on durations.
1757 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1758 in size calculation.
1759 (Fexecute_kbd_macro):
1760 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1761 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1762 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1763 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1764 (set_marker_both, set_marker_restricted_both, marker_position)
1765 (marker_byte_position, Fbuffer_has_markers_at):
1766 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1767 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
1768 * menu.c (ensure_menu_items): Rename from grow_menu_items.
1769 It now merely ensures that the menu is large enough, without
1770 necessarily growing it, as this avoids some integer overflow issues.
1771 All callers changed.
1772 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1773 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1774 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1775 Use SAFE_ALLOCA_LISP, not alloca.
1776 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1777 to EMACS_INT. Check that fixnums are in proper range for system types.
1778 * minibuf.c (minibuf_prompt_width, string_to_object)
1779 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1780 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1781 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1782 (get_minibuffer, read_minibuf_unwind):
1783 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1784 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1785 this simplifies overflow checking. All callers changed.
1786 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1788 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1789 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1790 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1791 Check that fixnums are in proper range for system types.
1792 (Fx_create_frame, Fx_show_tip):
1793 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1794 * nsfont.m (ns_findfonts, nsfont_list_family):
1795 Don't assume fixnum fits in long.
1796 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1797 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1798 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1800 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
1801 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1802 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1803 (PRINTDECLARE, PRINTPREPARE):
1804 (strout, print_string):
1805 (print, print_preprocess, print_check_string_charset_prop)
1807 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1809 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1810 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1811 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
1812 (printchar, strout): Use xpalloc to catch size calculation overflow.
1813 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
1814 (print_error_message): Use SAFE_ALLOCA, not alloca.
1815 (print_object): Use int, not EMACS_INT, where int is wide enough.
1816 (print_depth, new_backquote_output, print_number_index):
1817 Use ptrdiff_t, not int, where int might not be wide enough.
1818 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1819 (Fset_process_window_size, Fformat_network_address)
1820 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1822 Check that fixnums are in proper range for system types.
1823 (Fsignal_process): Simplify by avoiding a goto.
1824 Check for process-ids out of pid_t range rather than relying on
1826 (process_tick, update_tick): Use EMACS_INT, not int.
1827 (Fformat_network_address, read_process_output, send_process)
1828 (Fprocess_send_region, status_notify):
1829 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1830 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1831 (wait_reading_process_output, read_process_output, exec_sentinel):
1832 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1833 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1834 (Faccept_process_output): Use duration_to_sec_usec to do proper
1835 overflow checking on durations.
1836 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1837 Don't assume pid_t fits in int.
1838 * process.h (struct Lisp_Process): Members tick and update_tick
1839 are now of type EMACS_INT, not int.
1840 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1841 configured --with-wide-int.
1842 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1843 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1844 * search.c (looking_at_1, string_match_1):
1845 (fast_string_match, fast_c_string_match_ignore_case)
1846 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1847 (scan_newline, find_before_next_newline, search_command)
1848 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1849 (set_search_regs, wordify):
1852 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1853 (string_match_1, search_buffer, set_search_regs):
1855 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1856 (wordify): Check for overflow in size calculation.
1857 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1858 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1859 Check that fixnums are in proper range for system types.
1860 * sound.c (struct sound_device)
1861 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1862 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1863 (Fplay_sound_internal):
1864 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1865 * syntax.c (struct lisp_parse_state, find_start_modiff)
1866 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1867 (Fparse_partial_sexp):
1868 Don't assume fixnums can fit in int.
1869 (struct lisp_parse_state, find_start_pos, find_start_value)
1870 (find_start_value_byte, find_start_begv)
1871 (update_syntax_table, char_quoted, dec_bytepos)
1872 (find_defun_start, prev_char_comend_first, back_comment):
1873 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1874 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1875 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1876 (Finternal_describe_syntax_value): Check that match_lisp is a
1877 character, not an integer, since the code stuffs it into int.
1878 (scan_words, scan_sexps_forward):
1879 Check that fixnums are in proper range for system types.
1881 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1882 (scan_sexps_forward):
1883 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1884 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1885 * syntax.h: Adjust decls to match defn changes elsewhere.
1886 (struct gl_state_s):
1887 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1888 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1889 MOST_POSITIVE_FIXNUM.
1890 * sysdep.c (wait_for_termination_1, wait_for_termination)
1891 (interruptible_wait_for_termination, mkdir):
1892 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1893 (emacs_read, emacs_write):
1894 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1895 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1896 and double all fit in int.
1897 * term.c (set_tty_color_mode):
1898 Check that fixnums are in proper range for system types.
1899 * termhooks.h (struct input_event):
1900 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1901 * textprop.c (validate_interval_range, interval_of)
1902 (Fadd_text_properties, set_text_properties_1)
1903 (Fremove_text_properties, Fremove_list_of_text_properties)
1904 (Ftext_property_any, Ftext_property_not_all)
1905 (copy_text_properties, text_property_list, extend_property_ranges)
1906 (verify_interval_modification):
1907 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1908 (Fnext_single_char_property_change)
1909 (Fprevious_single_char_property_change):
1910 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1911 (copy_text_properties):
1912 Check for integer overflow in index calculation.
1913 * undo.c (last_boundary_position, record_point, record_insert)
1914 (record_delete, record_marker_adjustment, record_change)
1915 (record_property_change):
1916 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1917 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1918 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1919 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1920 (Fx_hide_tip, Fx_file_dialog):
1921 * w32menu.c (set_frame_menubar):
1922 Use ptrdiff_t, not int, for consistency with rest of code.
1923 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1924 (select_window, Fdelete_other_windows_internal)
1925 (window_scroll_pixel_based, window_scroll_line_based)
1926 (Frecenter, Fset_window_configuration):
1927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1928 (Fset_window_hscroll, run_window_configuration_change_hook)
1929 (set_window_buffer, temp_output_buffer_show, scroll_command)
1930 (Fscroll_other_window, Frecenter):
1931 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1932 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1933 Don't assume fixnum fits in int.
1934 (Fset_window_scroll_bars):
1935 Check that fixnums are in proper range for system types.
1936 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1937 (string_pos, c_string_pos, number_of_chars, init_iterator)
1938 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1939 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1940 (compute_display_string_end, handle_face_prop)
1941 (face_before_or_after_it_pos, handle_invisible_prop)
1942 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1943 (display_prop_intangible_p, string_buffer_position_lim)
1944 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1945 (get_overlay_strings_1, get_overlay_strings)
1946 (iterate_out_of_display_property, forward_to_next_line_start)
1947 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1948 (get_next_display_element, set_iterator_to_next)
1949 (get_visually_first_element, compute_stop_pos_backwards)
1950 (handle_stop_backwards, next_element_from_buffer)
1951 (move_it_in_display_line_to, move_it_in_display_line)
1952 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1953 (add_to_log, message_dolog, message_log_check_duplicate)
1954 (message2, message2_nolog, message3, message3_nolog
1955 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1956 (current_message_1, truncate_echo_area, truncate_message_1)
1957 (set_message, set_message_1, store_mode_line_noprop)
1958 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1959 (text_outside_line_unchanged_p, check_point_in_composition)
1960 (reconsider_clip_changes)
1961 (redisplay_internal, set_cursor_from_row, try_scrolling)
1962 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1963 (redisplay_window, find_last_unchanged_at_beg_row)
1964 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1965 (trailing_whitespace_p, find_row_edges, display_line)
1966 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1967 (display_mode_element, store_mode_line_string)
1968 (pint2str, pint2hrstr, decode_mode_spec)
1969 (display_count_lines, display_string, draw_glyphs)
1970 (x_produce_glyphs, x_insert_glyphs)
1971 (rows_from_pos_range, mouse_face_from_buffer_pos)
1972 (fast_find_string_pos, mouse_face_from_string_pos)
1973 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1974 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1975 (safe_call, init_from_display_pos, handle_fontified_prop)
1976 (handle_single_display_spec, load_overlay_strings)
1977 (with_echo_area_buffer, setup_echo_area_for_printing)
1978 (display_echo_area, echo_area_display)
1979 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1980 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1981 (redisplay_window, dump_glyph_row, display_mode_line)
1982 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1983 (handle_display_spec, display_prop_string_p):
1984 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1985 (handle_single_display_spec, build_desired_tool_bar_string)
1986 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1987 (get_specified_cursor_type):
1988 Check that fixnums are in proper range for system types.
1989 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1990 (Flookup_image_map):
1991 Don't assume fixnums fit in int.
1992 (compare_overlay_entries):
1993 Avoid mishandling comparisons due to subtraction overflow.
1994 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1995 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1996 (handle_tool_bar_click):
1997 Use int, not unsigned, since we prefer signed and the signedness
1998 doesn't matter here.
1999 (get_next_display_element, next_element_from_display_vector):
2000 Use int, not EMACS_INT, when int is wide enough.
2001 (start_hourglass): Use duration_to_sec_usec to do proper
2002 overflow checking on durations.
2003 * xfaces.c (Fbitmap_spec_p):
2004 Check that fixnums are in proper range for system types.
2005 (compare_fonts_by_sort_order):
2006 Avoid mishandling comparisons due to subtraction overflow.
2007 (Fx_family_fonts, realize_basic_faces):
2008 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2010 Don't assume fixnum fits in int.
2011 Use SAFE_ALLOCA_LISP, not alloca.
2012 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2013 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2014 (face_at_buffer_position, face_for_overlay_string)
2015 (face_at_string_position):
2016 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2017 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2018 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2020 Check that fixnums are in proper range for system types.
2021 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2022 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2023 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2024 (Fx_change_window_property): Don't assume fixnums fit in int.
2025 * xfont.c (xfont_chars_supported):
2026 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2027 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2028 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2029 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2030 * xml.c (parse_region):
2031 * xrdb.c (magic_file_p):
2032 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2033 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2034 (x_get_local_selection, x_reply_selection_request)
2035 (x_handle_selection_request, wait_for_property_change):
2036 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2037 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2038 short is wide enough.
2039 (x_send_client_event): Don't assume fixnum fits in int.
2040 * xterm.c (x_x_to_emacs_modifiers):
2041 Don't assume EMACS_INT overflows nicely into int.
2042 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2044 (handle_one_xevent): NATNUMP can eval its arg twice.
2045 (x_connection_closed):
2046 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2047 * xterm.h: Adjust decls to match defn changes elsewhere.
2048 (struct scroll_bar): Use struct vectorlike_header
2049 rather than rolling our own approximation.
2050 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2052 2012-05-25 Glenn Morris <rgm@gnu.org>
2054 * lisp.mk (lisp): Update for more files being compiled now.
2056 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2058 * lread.c: Remove `read_pure' which makes no difference.
2059 (read_pure): Remove var.
2060 (unreadpure): Remove function.
2061 (readevalloop): Don't call read_list with -1 flag.
2062 (read1, read_vector): Don't test read_pure any more.
2063 (read_list): Simplify.
2065 * fileio.c, character.h: Minor style tweaks.
2067 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2069 * window.h (clip_changed): Remove useless declaration.
2071 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2073 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2074 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2076 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2079 This directory predates autoconf and is no longer needed nowadays.
2080 Move its few remaining bits of functionality to where they're needed.
2081 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2082 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2083 * m/template.h: Remove.
2084 * Makefile.in (M_FILE): Remove. All uses removed.
2085 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2086 * lisp.h (USE_LSB_TAG):
2087 * mem-limits.h (EXCEEDS_LISP_PTR):
2088 Use VAL_MAX, not VALBITS, in #if.
2089 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2090 (EMACS_UINT): Define unconditionally now.
2091 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2092 (BITS_PER_EMACS_INT): New constants, replacing
2093 what used to be in config.h, but not useful in #if.
2094 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2095 define them any more.
2096 (VAL_MAX): New macro.
2098 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2099 BITS_PER_EMACS_INT, in #if.
2100 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2101 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2102 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2103 * s/ms-w32.h (DATA_START):
2104 Move here from removed file m/intel386.h.
2105 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2106 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2108 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2110 Assume C89 or later.
2111 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2112 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2114 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2115 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2116 * textprop.c, tparam.c (NULL): Remove.
2117 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2118 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2119 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2120 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2121 * xterm.c (input_signal_count): Assume volatile works.
2123 2012-05-21 Ken Brown <kbrown@cornell.edu>
2125 * xgselect.c (xg_select): Fix first argument in call to 'select'
2128 2012-05-20 Ken Brown <kbrown@cornell.edu>
2130 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
2131 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
2133 2012-05-19 Ken Brown <kbrown@cornell.edu>
2135 * xfns.c (x_in_use): Remove `static' qualifier.
2136 * xterm.h (x_in_use): Declare.
2137 * xgselect.c: Include xterm.h.
2138 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2139 and `display_arg' (bug#9754).
2141 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2143 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2145 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2146 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2148 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2150 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2152 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2153 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2155 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2156 reference to image_cache->refcount.
2157 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2159 2012-05-17 Juri Linkov <juri@jurta.org>
2161 * search.c (Fword_search_regexp, Fword_search_backward)
2162 (Fword_search_forward, Fword_search_backward_lax)
2163 (Fword_search_forward_lax): Move functions to isearch.el
2164 (bug#10145, bug#11381).
2166 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2168 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2170 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2172 * lread.c (init_obarray): Declare Qt and Qnil as special.
2174 2012-05-14 Glenn Morris <rgm@gnu.org>
2176 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2177 Put "libexec" before "bin", for the sake of init_callproc_1.
2179 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2181 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2183 * unexaix.c: Port to more-recent AIX compilers.
2184 (report_error, report_error_1, make_hdr, copy_sym)
2185 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2186 Make arguments const char *, not char *, to avoid violations of C
2187 standard and to fix some AIX warnings reported by Gilles Pion.
2189 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2191 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2192 already have overlays loaded.
2193 (handle_single_display_spec): Before returning without displaying
2194 fringe bitmap, synchronize the bidi iterator with the main display
2195 iterator, by calling iterate_out_of_display_property.
2196 (iterate_out_of_display_property): Detect buffer iteration by
2197 testing that it->string is a Lisp string.
2198 (get_next_display_element): When the current object is exhausted,
2199 and there's something on it->stack, call set_iterator_to_next to
2200 proceed with what's on the stack, instead of returning zero.
2201 (set_iterator_to_next): If called at the end of a Lisp string,
2202 proceed to consider_string_end without incrementing string
2203 position. Don't increment display vector index past the end of
2204 the display vector. (Bug#11417)
2205 (pos_visible_p): Don't report a position visible when move_it_to
2206 stopped at the last line of window, which happens to be scanned
2207 backwards by the bidi iteration. (Bug#11464)
2209 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2211 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2212 and right-margin display specs even if the spec is invalid or we
2213 are on a TTY, and thus unable to display on the fringes.
2214 That's because the text with the property will not be displayed anyway,
2215 so we need to signal to the caller that this is a "replacing"
2216 display spec. This fixes display when the spec is invalid or we
2219 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2221 * unexaix.c (make_hdr): Fix typo in prototype.
2222 This bug broke the build on AIX. Problem reported by Gilles Pion.
2224 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2226 * keyboard.c (kbd_buffer_get_event): Read special events also in
2227 batch mode. (Bug#11415)
2229 2012-05-12 Glenn Morris <rgm@gnu.org>
2231 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2233 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2235 * lisp.mk (lisp): Add newcomment.elc.
2237 2012-05-12 Glenn Morris <rgm@gnu.org>
2239 * Makefile.in (MKDIR_P): New, set by configure.
2240 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2242 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2244 Remove unused function hourglass_started.
2245 * dispextern.h (hourglass_started):
2246 * w32fns.c (hourglass_started):
2247 * xdisp.c (hourglass_started): Remove.
2249 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
2251 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2252 Update dependencies.
2254 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2256 * xgselect.c (xg_select): Put maxfds+1 into a var.
2257 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2259 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2261 2012-05-10 Dave Abrahams <dave@boostpro.com>
2263 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2264 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2266 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
2268 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2269 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2270 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2271 Initialize xd_registered_buses.
2273 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2275 Untag more efficiently if USE_LSB_TAG.
2276 This is based on a proposal by YAMAMOTO Mitsuharu in
2277 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2278 For an admittedly artificial (nth 8000 longlist) benchmark on
2279 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2280 Emacs's overall text size by 1%.
2281 * lisp.h (XUNTAG): New macro.
2282 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2283 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2284 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2285 * eval.c (Fautoload):
2286 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2287 * frame.h (XFRAME): Use XUNTAG.
2289 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2290 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2291 Remove unportable assumptions about print widths of types like
2293 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2294 intptr_t when converting between pointer and integer, to avoid GCC
2295 warnings about wrong width.
2297 2012-05-09 Eli Zaretskii <eliz@gnu.org>
2299 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2300 stack for each reader_thread, instead of defaulting to 8MB
2301 determined by the linker. This avoids failures in creating
2302 subprocesses on Windows 7, see the discussion in this thread:
2303 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2305 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2307 Fix up display of the *Minibuf-0* buffer in the mini window.
2308 * keyboard.c (read_char): Don't clear the echo area if there's no
2310 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2311 contents of *Minibuf-0*) if there's no message displayed in its stead.
2313 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
2315 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2318 2012-05-06 Chong Yidong <cyd@gnu.org>
2320 * lisp.mk (lisp): Update.
2322 2012-05-05 Jim Meyering <meyering@redhat.com>
2324 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2326 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2328 * data.c (PUT_ERROR): New macro.
2329 (syms_of_data): Use it. Add new error type `user-error'.
2330 * undo.c (user_error): New function.
2331 (Fprimitive_undo): Use it.
2332 * print.c (print_error_message): Adjust print style for `user-error'.
2333 * keyboard.c (user_error): New function.
2334 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2336 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2338 Do not limit current-time-string to years 1000..9999.
2339 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2340 (Fcurrent_time_string): Support any year that is supported by the
2341 underlying localtime representation. Don't use asctime, as it
2342 has undefined behavior for years outside the range -999..9999.
2344 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2346 Fix race conditions involving setenv, gmtime, localtime, asctime.
2347 Without this fix, interrupts could mess up code that uses these
2348 nonreentrant functions, since setting TZ invalidates existing
2349 tm_zone or tzname values, and since most of these functions return
2350 pointers to static storage.
2351 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2352 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2353 Grow the critical sections to include not just invoking
2354 localtime/gmtime, but also accessing these functions' results
2355 including their tm_zone values if any, and any related TZ setting.
2356 (format_time_string): Last arg is now struct tm *, not struct tm **,
2357 so that the struct tm is saved in the critical section.
2358 All callers changed. Simplify allocation of initial buffer, partly
2359 motivated by the fact that memory allocation needs to be outside
2360 the critical section.
2362 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2364 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2365 with RESET_INTERVAL.
2367 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2368 Remove duplicated buffer name initialization.
2370 2012-05-02 Jim Meyering <jim@meyering.net>
2372 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2374 * xfns.c (x_window): Use xstrdup (Bug#11375).
2376 2012-05-02 Eli Zaretskii <eliz@gnu.org>
2378 * xdisp.c (pos_visible_p): If already at a newline from the
2379 display string before the 'while' loop, don't walk back the glyphs
2380 from it3.glyph_row. Solves assertion violation when the display
2381 string begins with a newline (egg.el). (Bug#11367)
2383 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2385 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2388 2012-05-01 Glenn Morris <rgm@gnu.org>
2390 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2391 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2392 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2393 All were removed before 23.1.
2395 * dispnew.c: Remove HAVE_LIBNCURSES test;
2396 it is always true on relevant platforms.
2398 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2399 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2401 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2403 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2405 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2406 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2409 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2411 Do not avoid creating empty evaporating overlays (Bug#9642).
2412 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2413 That is, do not delete an evaporating overlay if it becomes
2414 empty after its bounds are adjusted to fit within its buffer.
2415 This fix caused other problems, and I'm reverting it until we get
2416 to the bottom of them.
2418 2012-04-27 Chong Yidong <cyd@gnu.org>
2420 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2422 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2424 * xdisp.c (pos_visible_p): If the window start position is beyond
2425 ZV, start the display from buffer beginning. Prevents assertion
2426 violation in init_iterator when the minibuffer window is scrolled
2429 * window.c (window_scroll_pixel_based): Likewise.
2431 2012-04-27 Chong Yidong <cyd@gnu.org>
2433 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2435 2012-04-27 Glenn Morris <rgm@gnu.org>
2437 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2438 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2440 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2442 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2443 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
2445 2012-04-26 Eli Zaretskii <eliz@gnu.org>
2447 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2448 display element, check also the underlying string or buffer
2449 character. (Bug#11341)
2451 * w32menu.c: Include w32heap.h.
2452 (add_menu_item): If the call to AppendMenuW (via
2453 unicode_append_menu) fails, disable Unicode menus only if we are
2454 running on Windows 9X/Me.
2456 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2458 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2459 (xgetint): Add missing shift for LSB tags.
2461 2012-04-24 Martin Rudalics <rudalics@gmx.at>
2463 * keyboard.c (read_char): Don't wipe echo area for select window
2464 events: These might get delayed via `mouse-autoselect-window'
2467 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
2469 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2470 manipulation of :loaded-from data.
2472 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
2474 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2475 now a cons (bug#11311).
2477 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2479 Do not create empty overlays with the evaporate property (Bug#9642).
2480 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2481 if it becomes empty after its bounds are adjusted to fit within
2482 its buffer. Without this fix, in a nonempty buffer (let ((o
2483 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2484 yields an empty overlay that has the evaporate property, which is
2485 not supposed to happen.
2487 Fix minor GTK3 problems found by static checking.
2488 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2489 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2490 (struct _EmacsFixedClass, emacs_fixed_get_type):
2491 Move decls here from emacsgtkfixed.h, since they needn't be public.
2492 (emacs_fixed_get_type): Now static.
2493 (emacs_fixed_class_init): Omit unused local.
2494 (emacs_fixed_child_type): Remove; unused.
2495 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2496 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2497 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2498 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2499 (EMACS_FIXED_GET_CLASS): Remove; unused.
2500 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2502 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2503 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2505 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2507 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
2508 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
2509 (__malloc_size_t, __malloc_ptrdiff_t):
2510 Remove. All uses removed, replaced by the definiens if needed,
2511 since we can assume C89 or better now.
2512 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2513 (protect_malloc_state, align, get_contiguous_space)
2514 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2515 (malloc_atfork_handler_child, malloc_enable_thread)
2516 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2517 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2518 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2519 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2520 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2521 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2522 Define using prototypes, not old style.
2523 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2524 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2525 (align): Don't assume that signed integer overflow wraps around.
2526 Omit unused local var.
2527 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2528 (_free_internal_nolock, memalign, mallochook, reallochook):
2529 Omit no-longer-needed casts.
2530 (valloc): Use getpagesize, not __getpagesize.
2531 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2532 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2534 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2536 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
2538 Move functions from C to Lisp. Make non-blocking method calls
2539 the default. Implement further D-Bus standard interfaces.
2541 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2542 (QCdbus_request_name_allow_replacement)
2543 (QCdbus_request_name_replace_existing)
2544 (QCdbus_request_name_do_not_queue)
2545 (QCdbus_request_name_reply_primary_owner)
2546 (QCdbus_request_name_reply_in_queue)
2547 (QCdbus_request_name_reply_exists)
2548 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2549 (QCdbus_registered_serial, QCdbus_registered_method)
2550 (QCdbus_registered_signal): New Lisp objects.
2551 (XD_DEBUG_MESSAGE): Use sizeof.
2552 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2553 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2554 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2555 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2556 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2557 (xd_signature, xd_append_arg): Allow float for integer types.
2558 (xd_get_connection_references): New function.
2559 (xd_get_connection_address): Rename from xd_initialize.
2560 Return cached address.
2561 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2562 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2564 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
2565 Return number of refcounts.
2566 (Fdbus_get_unique_name): Make stronger parameter check.
2567 (Fdbus_message_internal): New defun.
2568 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2569 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2570 (Fdbus_send_signal, Fdbus_register_service)
2571 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2572 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2573 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2574 (Vdbus_compiled_version, Vdbus_runtime_version)
2575 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2576 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2577 (Vdbus_message_type_signal): New defvars.
2578 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2581 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2583 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2584 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2585 Do not assume ptrdiff_t is the same width as 'int'.
2587 * alloc.c: Handle unusual debugging option combinations.
2588 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2589 since the two debugging options are incompatible.
2590 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2592 (mem_init, mem_insert, mem_insert_fixup):
2593 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2594 (NEED_MEM_INSERT): Remove; no longer needed.
2596 2012-04-22 Leo Liu <sdl.web@gmail.com>
2598 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2600 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2602 * sysdep.c [__FreeBSD__]: Minor cleanups.
2603 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2604 Use Emacs indenting style more consistently. Avoid some casts.
2605 Use 'double' consistently rather than mixing 'float' and 'double'.
2607 2012-04-21 Eduard Wiebe <usenet@pusto.de>
2609 * sysdep.c (list_system_processes, system_process_attributes):
2610 Add implementation for FreeBSD (Bug#5243).
2612 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2614 * lisp.mk (lisp): Update.
2616 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2618 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2619 It is never used otherwise.
2621 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2623 * print.c (print_preprocess): Only check print_depth if print-circle
2625 (print_object): Check for cycles even when print-circle is nil and
2626 print-gensym is t, but only check print_depth if print-circle is nil.
2628 2012-04-20 Chong Yidong <cyd@gnu.org>
2630 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2631 set the status to "failed" and ensure that sentinel is run.
2633 2012-04-20 Glenn Morris <rgm@gnu.org>
2635 * process.c (Fset_process_inherit_coding_system_flag)
2636 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
2637 (Fmake_network_process, Fmake_serial_process): Doc fix.
2639 2012-04-20 Eli Zaretskii <eliz@gnu.org>
2641 * xdisp.c (string_buffer_position_lim): Limit starting position to
2643 (set_cursor_from_row): If called for a mode-line or header-line
2644 row, return zero immediately.
2645 (try_cursor_movement): If inside continuation line, don't back up
2646 farther than the first row after the header line, if any.
2647 Don't consider the header-line row as "partially visible", even if
2648 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2650 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2652 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2655 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
2656 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
2658 configure: new option --enable-gcc-warnings (Bug#11207)
2659 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2660 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2661 (ALL_CFLAGS): Use new macros rather than old.
2662 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2663 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2664 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2665 -Wunused-result, -Wunused-variable. This should go away once
2666 the Emacs and Gnulib regex code is merged.
2667 (xmalloc, xrealloc): Now static.
2669 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2671 * dired.c (Fsystem_groups): Remove unused local.
2673 2012-04-17 Glenn Morris <rgm@gnu.org>
2675 * dired.c (Fsystem_users): Doc fix.
2677 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2679 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2680 (syms_of_dired): Add them.
2682 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2684 Fix minor alloc.c problems found by static checking.
2685 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2686 New extern decls, to avoid calling undeclared functions.
2687 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2688 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2689 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2690 (NEED_MEM_INSERT): New macro.
2691 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
2692 Remove one incorrect comment and fix another.
2694 Fix minor ralloc.c problems found by static checking.
2695 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2696 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2697 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2698 (r_alloc_sbrk): Now static.
2700 Improve ralloc.c interface checking.
2701 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2702 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2703 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2704 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2705 [REL_ALLOC]: ... to here, to check interface.
2706 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2707 Remove decls. This fixes an "It stinks!".
2709 * alloc.c (which_symbols): Fix alignment issue / type clash.
2711 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2713 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2714 (struct Lisp_Misc_Any): Likewise.
2715 (struct Lisp_Free): Likewise.
2716 * alloc.c (union aligned_Lisp_Symbol): Define.
2717 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2718 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2719 (union aligned_Lisp_Misc): Define.
2720 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2721 aligned_Lisp_Misc instead of union Lisp_Misc.
2722 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
2724 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2726 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2727 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2728 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2729 * s/netbsd.h, s/sol2-6.h:
2730 Remove definition of GC_MARK_STACK, since the default now works.
2731 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2732 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2733 no longer the default.
2734 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2736 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2738 * lread.c (lisp_file_lexically_bound_p):
2739 Fix hang at ";-*-\n" (bug#11238).
2741 2012-04-14 Eli Zaretskii <eliz@gnu.org>
2743 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2744 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2746 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2748 * nsterm.m (constrainFrameRect): Always constrain when there is only
2749 one screen (Bug#10962).
2751 2012-04-13 Ken Brown <kbrown@cornell.edu>
2753 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2755 2012-04-13 Reuben Thomas <rrt@sc3d.org>
2757 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2759 2012-04-11 Daniel Colascione <dancol@dancol.org>
2761 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2762 against is gone. It's better to use vfork now so that when Cygwin
2763 gains a new, working vfork, we use it automatically (bug#10398).
2765 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2767 * window.c (save_window_save): Obey window-point-insertion-type.
2769 2012-04-11 Glenn Morris <rgm@gnu.org>
2771 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2773 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2775 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2777 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
2779 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2780 (force_quit_count): New var.
2781 (handle_interrupt): Use it.
2783 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
2785 * w32.c (w32_delayed_load): Record the full path of the library
2786 being loaded (bug#10424).
2788 2012-04-09 Glenn Morris <rgm@gnu.org>
2790 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2791 not just in the obarray, before snarfing them. (Bug#11036)
2793 * Makefile.in ($(leimdir)/leim-list.el):
2794 Pass EMACS rather than BUILT_EMACS.
2796 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2798 * process.c (make_process):
2799 * process.h: Add integer `gnutls_handshakes_tried' member to
2802 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2803 Add convenience `GNUTLS_LOG2i' macro.
2805 * gnutls.c (gnutls_log_function2i): Convenience log function.
2806 (emacs_gnutls_read): Use new log functions,
2807 `gnutls_handshakes_tried' process member, and
2808 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2809 attempts per process (connection).
2811 2012-04-09 Chong Yidong <cyd@gnu.org>
2813 * eval.c (Fuser_variable_p, user_variable_p_eh)
2814 (lisp_indirect_variable): Functions deleted.
2815 (Fdefvar): Caller changed.
2817 * callint.c (Finteractive, Fcall_interactively):
2818 * minibuf.c (Fread_variable): Callers changed.
2820 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2822 * xdisp.c (set_cursor_from_row): If the display string appears in
2823 the buffer at position that is closer to point than the position
2824 after the display string, display the cursor on the first glyph of
2825 the display string. Fixes cursor display when a 'display' text
2826 property immediately follows invisible text. (Bug#11094)
2828 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2830 composite.c: use 'double' consistently
2831 * composite.c (get_composition_id): Use 'double' consistently
2832 instead of converting 'float' to 'double' and vice versa; this is
2833 easier to understand and avoids a GCC warning.
2835 2012-04-09 Glenn Morris <rgm@gnu.org>
2837 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2838 preparation for dumping it with emacs. (Bug#4789)
2839 (leimdir): New variable.
2840 ($(leimdir)/leim-list.el): New rule.
2841 (emacs$(EXEEXT)): Depend on leim-list.el.
2843 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2844 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2845 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2847 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2849 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2852 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2854 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2855 Remove unused local variable.
2857 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2859 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2860 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2861 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2862 objects, as mark_maybe_pointer will catch them otherwise.
2863 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2864 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2866 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2868 Fix typo that broke non-Windows builds.
2869 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2871 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2873 Support building on MS-Windows with libxml2.
2875 * makefile.w32-in (OBJ2): Add xml.$(O).
2876 (GLOBAL_SOURCES): Add xml.c.
2877 ($(BLD)/xml.$(O)): New dependency list.
2879 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2880 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2881 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2882 [!WINDOWSNT]: New macros.
2883 (init_libxml2_functions, libxml2_loaded_p): New functions.
2884 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2885 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2886 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2887 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2889 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2890 Call init_libxml2_functions before calling libxml2 functions.
2891 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2893 * emacs.c: Don't include libxml/parser.h.
2894 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2895 xmlCleanupParser directly.
2897 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2899 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2901 * indent.c (Fvertical_motion): If there is a display string at
2902 point, use it.vpos to compute how many lines to backtrack after
2903 move_it_to point. (Bug#11133)
2905 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2907 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2908 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2909 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2910 macros related to unification of CJK characters. For the details,
2911 see the discussion following the message here:
2912 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2914 2012-04-04 Chong Yidong <cyd@gnu.org>
2916 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2918 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2920 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2921 instead of alloca. (Bug#11138)
2923 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2925 * w32menu.c (is_simple_dialog): Properly check lisp types.
2928 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2930 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2931 position we get to after a call to move_it_to fails the
2932 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2933 only if we wind up in a string from display property. (Bug#11063)
2935 * window.c (Fdelete_other_windows_internal): Invalidate the row
2936 and column information about mouse highlight, so that redisplay
2937 restores it after reallocating the glyph matrices. (Bug#7464)
2939 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2940 string comes from a `display' text property, use the buffer
2941 position of that property as if we actually saw that position in
2943 (move_it_by_lines): Remove the assertion that
2944 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2945 violated when there's a before-string at the beginning of a line.
2948 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2950 * xdisp.c (append_space_for_newline): If the default face was
2951 remapped, use the remapped face for the appended newline.
2952 (extend_face_to_end_of_line): Use the remapped default face for
2953 extending the face to the end of the line.
2954 (display_line): Call extend_face_to_end_of_line when the default
2955 face was remapped. (Bug#11068)
2957 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2959 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2961 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2963 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2965 2012-03-27 Glenn Morris <rgm@gnu.org>
2967 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2970 2012-03-26 Kenichi Handa <handa@m17n.org>
2972 * dispextern.h (struct glyph): Fix previous change. Change the
2973 bit length of glyphless.ch to 25 (Bug#11082).
2975 2012-03-26 Chong Yidong <cyd@gnu.org>
2977 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2978 (command_loop_1): Use it; inhibit selection update for
2979 handle-select-window too (Bug#8996).
2981 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2983 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2985 2012-03-25 Kenichi Handa <handa@m17n.org>
2987 * dispextern.h (struct glyph): Change the bit length of
2988 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2990 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2992 * s/ms-w32.h (tzname): Include time.h before redirecting to
2993 _tzname. Fixes the MSVC build. (Bug#9960)
2995 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2997 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3000 * xterm.c (XTread_socket): Only modify handling_signal if
3001 !SYNC_INPUT. (Bug#11080)
3003 2012-03-23 Eli Zaretskii <eliz@gnu.org>
3005 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3006 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3007 when fetching a multibyte character consumes more bytes than
3008 CHAR_BYTES returns, due to unification of CJK characters in
3009 string_char. (Bug#11073)
3011 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3013 * process.c (wait_reading_process_output): Handle pty disconnect
3014 by refraining from sending oneself a SIGCHLD (bug#10933).
3016 2012-03-22 Chong Yidong <cyd@gnu.org>
3018 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3020 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
3021 Mark string as coming from a prefix property.
3022 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3023 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3025 2012-03-21 Chong Yidong <cyd@gnu.org>
3027 * xfaces.c (Vface_remapping_alist): Doc fix.
3029 2012-03-20 Eli Zaretskii <eliz@gnu.org>
3031 * w32proc.c (Fw32_set_console_codepage)
3032 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3035 2012-03-20 Chong Yidong <cyd@gnu.org>
3037 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3038 to reflect default non-nil value of redisplay-dont-pause.
3040 2012-03-19 Kenichi Handa <handa@m17n.org>
3042 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3043 it fit in a valid range (Bug#11003).
3045 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3047 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3048 that is not from display property, accept the row as a "cursor
3049 row" if one of the string's character has a non-nil `cursor'
3050 property. Fixes cursor positioning when there are newlines in
3051 overlay strings, e.g. in icomplete.el. (Bug#11035)
3053 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3055 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3057 2012-03-12 Chong Yidong <cyd@gnu.org>
3059 * eval.c (inhibit_lisp_code): Rename from
3060 inhibit_window_configuration_change_hook; move from window.c.
3062 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3063 * window.c (run_window_configuration_change_hook)
3064 (syms_of_window): Callers changed.
3066 2012-03-11 Chong Yidong <cyd@gnu.org>
3068 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3070 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3072 2012-03-10 Chong Yidong <cyd@gnu.org>
3074 * frame.c (other_visible_frames): Don't assume the selected frame
3075 is visible (Bug#10955).
3077 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3079 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3081 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3083 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3084 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3087 2012-03-03 Glenn Morris <rgm@gnu.org>
3089 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3091 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3093 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3094 position past the first glyph_row that ends at ZV. (Bug#10902)
3095 (redisplay_window, next_element_from_string): Fix typos in
3097 (redisplay_window): Pass to move_it_vertically the margin in
3098 pixels, not in screen lines.
3100 2012-03-02 Glenn Morris <rgm@gnu.org>
3102 * buffer.c (buffer-list-update-hook): Doc fix.
3104 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3106 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3107 push_it before setting up the iterator for the first overlay
3108 string, even if we have an empty string loaded.
3109 (next_overlay_string): If there's an empty string on the iterator
3110 stack, pop the stack. (Bug#10903)
3112 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3114 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3115 Suggested by Stefan Monnier in
3116 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3117 * alloc.c (widen_to_Lisp_Object): New static function.
3118 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3119 and widening them to Lisp_Objects. This would work even if
3120 USE_LSB_TAG is defined and wide integers are used, which might
3121 happen in a future version of Emacs.
3123 2012-02-25 Chong Yidong <cyd@gnu.org>
3125 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3128 * xselect.c (Fx_selection_exists_p): Doc fix.
3129 (x_clipboard_manager_save_all): Print an informative message
3130 before saving to clipboard manager.
3132 2012-02-24 Chong Yidong <cyd@gnu.org>
3134 * keyboard.c (process_special_events): Handle all X selection
3135 requests in kbd_buffer, not just the next one (Bug#8869).
3137 2012-02-23 Chong Yidong <cyd@gnu.org>
3139 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3140 call when setting menu-bar-lines and tool-bar-lines parameters.
3141 (unwind_create_frame_1): New helper function.
3143 * window.c (inhibit_window_configuration_change_hook): New var.
3144 (run_window_configuration_change_hook): Obey it.
3145 (syms_of_window): Initialize it.
3147 2012-02-22 Chong Yidong <cyd@gnu.org>
3149 * xterm.c (x_draw_image_relief): Add missing type check for
3150 Vtool_bar_button_margin (Bug#10743).
3152 2012-02-21 Chong Yidong <cyd@gnu.org>
3154 * fileio.c (Vfile_name_handler_alist): Doc fix.
3156 * buffer.c (Fget_file_buffer): Protect against invalid file
3157 handler return value.
3159 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3161 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3162 when computing $valmask.
3164 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3165 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3166 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3167 It's useless in that case, and it can cause problems on hosts
3168 that allocate halves of EMACS_INT values separately.
3169 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3170 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3171 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3172 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3173 it avoids undefined behavior on hosts where shifting right by more
3174 than the word width has undefined behavior.
3176 2012-02-19 Chong Yidong <cyd@gnu.org>
3178 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3179 (Funhandled_file_name_directory, Ffile_name_as_directory)
3180 (Fdirectory_file_name, Fexpand_file_name)
3181 (Fsubstitute_in_file_name): Protect against invalid file handler
3182 return values (Bug#10845).
3184 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3186 * .gdbinit (pitx): Fix incorrect references to fields of the
3189 2012-02-17 Chong Yidong <cyd@gnu.org>
3191 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3193 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3195 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3196 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3198 2012-02-15 Chong Yidong <cyd@gnu.org>
3200 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3201 marked as special. Also, starting docstrings with * is obsolete.
3203 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3205 * gnutls.c (emacs_gnutls_write): Fix last change.
3207 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3209 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3212 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3214 * keymap.c (Fsingle_key_description): Handle char ranges.
3216 2012-02-12 Chong Yidong <cyd@gnu.org>
3218 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3219 as that creates a dangerous corner case.
3221 * window.c (Fdelete_window_internal): Invalidate the mouse
3222 highlight (Bug#9904).
3224 2012-02-12 Glenn Morris <rgm@gnu.org>
3226 * xselect.c (Fx_own_selection_internal)
3227 (Fx_get_selection_internal, Fx_disown_selection_internal)
3228 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3229 * nsselect.m (Fx_own_selection_internal)
3230 (Fx_disown_selection_internal, Fx_selection_exists_p)
3231 (Fx_selection_owner_p, Fx_get_selection_internal):
3232 Sync docs and argument specs with the xselect.c versions.
3234 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3236 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3238 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3240 * w32select.c (Fx_selection_exists_p): Sync doc string and
3241 argument list with xselect.c. (Bug#10783)
3243 * w16select.c (Fx_selection_exists_p): Sync doc string and
3244 argument list with xselect.c. (Bug#10783)
3246 2012-02-10 Glenn Morris <rgm@gnu.org>
3248 * fns.c (Fsecure_hash): Doc fix.
3250 2012-02-09 Kenichi Handa <handa@m17n.org>
3252 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3254 2012-02-07 Chong Yidong <cyd@gnu.org>
3256 * buffer.c (Fbuffer_local_variables)
3257 (buffer_lisp_local_variables): Handle unbound vars correctly;
3258 don't let Qunbound leak into Lisp.
3260 2012-02-07 Glenn Morris <rgm@gnu.org>
3262 * image.c (Fimagemagick_types): Doc fix.
3264 * image.c (imagemagick-render-type): Change it from a lisp object
3265 to an integer. Move the doc here from the lisp manual.
3266 Treat all values not equal to 0 the same.
3268 2012-02-06 Chong Yidong <cyd@gnu.org>
3270 * doc.c (store_function_docstring): Avoid applying docstring of
3271 alias to base function (Bug#2603).
3273 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3275 * .gdbinit (pp1, pv1): Remove redundant defines.
3278 2012-02-04 Chong Yidong <cyd@gnu.org>
3280 * nsterm.m: Declare a global (Bug#10694).
3282 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3284 * w32.c (get_emacs_configuration_options):
3285 Include --enable-checking, if specified, in the return value.
3287 2012-02-04 Martin Rudalics <rudalics@gmx.at>
3289 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3290 after rounding frame sizes. (Bug#9723)
3292 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3294 * keyboard.c (adjust_point_for_property): Don't position point
3295 before BEGV. (Bug#10696)
3297 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3299 Handle overflow when computing char display width (Bug#9496).
3300 * character.c (char_width): Return EMACS_INT, not int.
3301 (char_width, c_string_width): Check for overflow when
3302 computing the width; this is possible now that individual
3303 characters can have unbounded width. Problem introduced
3304 by merge from Emacs 23 on 2012-01-19.
3306 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
3308 * dbusbind.c (Fdbus_register_method): Mention the return value
3309 :ignore in the docstring.
3311 2012-02-02 Glenn Morris <rgm@gnu.org>
3313 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3315 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3316 Unconditionally set to t. (Bug#10673)
3317 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3318 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3319 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3321 2012-02-02 Kenichi Handa <handa@m17n.org>
3323 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3324 0, do not call append_composite_glyph.
3326 2012-02-02 Kenichi Handa <handa@m17n.org>
3328 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3330 (x_produce_glyphs): If the component of a composition is a null
3331 string, set it->pixel_width to 1 to avoid zero-width glyph.
3333 2012-02-01 Eli Zaretskii <eliz@gnu.org>
3335 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3336 first 2 arguments are identical. This makes inserting large
3337 output from a subprocess an order of magnitude faster on
3338 MS-Windows, where all sbrk'ed memory is always contiguous.
3340 2012-01-31 Glenn Morris <rgm@gnu.org>
3342 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3343 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3344 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3346 2012-01-29 Glenn Morris <rgm@gnu.org>
3348 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3350 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3352 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3354 2012-01-28 Chong Yidong <cyd@gnu.org>
3356 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3358 2012-01-26 Chong Yidong <cyd@gnu.org>
3360 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3362 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3363 repeat counts (Bug#10507).
3365 2012-01-26 Glenn Morris <rgm@gnu.org>
3367 * lread.c (syms_of_lread): Doc fix.
3369 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3371 * coding.c (encode_designation_at_bol): Change return value to
3374 2012-01-25 Chong Yidong <cyd@gnu.org>
3376 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3378 2012-01-21 Chong Yidong <cyd@gnu.org>
3380 * floatfns.c (Fcopysign): Make the second argument non-optional,
3381 since nil is not allowed anyway.
3383 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3385 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3386 (send_process): Likewise.
3388 2012-01-19 Martin Rudalics <rudalics@gmx.at>
3390 * window.c (save_window_save, Fcurrent_window_configuration)
3391 (Vwindow_persistent_parameters): Do not use Qstate.
3392 Rewrite doc-strings.
3394 2012-01-19 Kenichi Handa <handa@m17n.org>
3396 * character.c (char_width): New function.
3397 (Fchar_width, c_string_width, lisp_string_width):
3398 Use char_width (Bug#9496).
3400 2012-01-16 Martin Rudalics <rudalics@gmx.at>
3402 * window.c (Vwindow_persistent_parameters): New variable.
3403 (Fset_window_configuration, save_window_save): Handle persistent
3406 2012-01-14 Eli Zaretskii <eliz@gnu.org>
3408 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3409 thrashing the stack of the thread. (Bug#9087)
3411 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3413 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3415 2012-01-11 Eli Zaretskii <eliz@gnu.org>
3417 * xdisp.c (rows_from_pos_range): Handle the case where the
3418 highlight ends on a newline. (Bug#10464)
3419 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3420 he end column for display of highlight that ends on a newline
3423 2012-01-11 Glenn Morris <rgm@gnu.org>
3425 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3426 from load-path also when installation-directory is nil. (Bug#10208)
3428 2012-01-10 Glenn Morris <rgm@gnu.org>
3430 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3432 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3433 Update template values to be closer to their typical values these days.
3435 2012-01-09 Eli Zaretskii <eliz@gnu.org>
3437 * xdisp.c (rows_from_pos_range): Accept additional argument
3438 DISP_STRING, and accept any glyph in a row whose object is that
3439 string as eligible for mouse highlight. Fixes mouse highlight of
3440 display strings from overlays. (Bug#10464)
3442 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
3444 emacs: fix an auto-save permissions race condition (Bug#10400)
3445 * fileio.c (auto_saving_dir_umask): New static var.
3446 (Fmake_directory_internal): Use it.
3447 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3448 creating the directory. The old code temporarily assigns
3449 too-generous permissions to the directory.
3450 (do_auto_save_eh): Clear it.
3451 (Fdo_auto_save): Catch all errors, not just file errors, so
3452 that the var is always cleared.
3454 2012-01-07 Eli Zaretskii <eliz@gnu.org>
3456 * search.c (scan_buffer): Pass character positions to
3457 know_region_cache, not byte positions. (Bug#6540)
3459 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
3461 * w32.c (sys_rename): Report EXDEV when rename of a directory
3462 fails because the target is on another logical disk. (Bug#10284)
3464 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3466 * xterm.c (x_embed_request_focus): New function.
3468 * xterm.h: Add prototype.
3470 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3472 2012-01-05 Glenn Morris <rgm@gnu.org>
3474 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3476 2012-01-01 Eli Zaretskii <eliz@gnu.org>
3478 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3479 Load gnutls_transport_set_lowat only if GnuTLS version is below
3481 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3482 GnuTLS versions below 2.11.1.
3484 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3486 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3487 to the doc string advising against its use for altering the way
3488 windows are scrolled.
3490 2011-12-28 Kenichi Handa <handa@m17n.org>
3492 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3493 coding-system ASCII compatible only when it does not produce BOM
3494 on encoding (Bug#10383).
3496 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3498 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3500 (create_and_show_popup_menu): Always use menu_position_func for
3503 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3505 * callint.c (Fcall_interactively): Don't truncate prompt string.
3507 2011-12-23 Eli Zaretskii <eliz@gnu.org>
3509 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3510 property that ends at ZV, so that the bidi iteration could be
3511 resumed from there (after widening). (Bug#10360)
3513 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3515 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3517 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3519 * nsterm.m (x_free_frame_resources):
3520 Release f->output_data.ns->miniimage.
3521 (ns_index_color): Fix indentation. Do not retain
3522 color_table->colors[i].
3524 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3527 * nsfns.m (x_set_background_color): Assign return value from
3528 ns_index_color to face-background instead of NSColor*.
3529 (ns_implicitly_set_icon_type): Fix indentation.
3530 Change assignment in for loop to comparison.
3532 * emacs.c (ns_pool): New variable.
3533 (main): Assign ns_pool.
3534 (Fkill_emacs): Call ns_release_autorelease_pool.
3536 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3537 autorelease fdesc, release fdAttrs and tdict.
3538 (ns_get_covering_families): Release charset.
3539 (ns_findfonts): Release NSFontDescriptor created with new.
3540 (ns_uni_to_glyphs): Fix indentation.
3541 (setString): Release attrStr before assigning new value.
3543 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3545 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3547 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3548 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3550 2011-12-18 David Reitter <reitter@cmu.edu>
3552 * nsterm.m (ns_term_init): Subscribe for notifications
3553 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3554 to method trackingNotification in EmacsMenu.
3556 * nsmenu.m (trackingMenu): New variable.
3557 (trackingNotification): New method (from Aquamacs).
3558 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3559 from Aquamacs (Bug#7030).
3561 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3563 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3564 (symbol_to_nsstring): Fix indentation.
3565 (ns_symbol_to_pb): New function.
3566 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3567 (Fns_rotate_cut_buffers_internal): Remove.
3568 (Fns_store_selection_internal): Rename from
3569 Fns_store_cut_buffer_internal.
3570 (ns_get_foreign_selection, Fx_own_selection_internal)
3571 (Fx_disown_selection_internal, Fx_selection_exists_p)
3572 (Fns_get_selection_internal, Fns_store_selection_internal):
3573 Use ns_symbol_to_pb and check if return value is nil.
3574 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3575 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
3576 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3577 renamed to Sns_store_selection_internal.
3578 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3579 and remove this function.
3580 (ns_handle_selection_clear): Remove, never used.
3581 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3584 2011-12-17 Ken Brown <kbrown@cornell.edu>
3586 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3587 GID is unknown (Bug#10257).
3589 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3591 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3592 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3593 which caused a build failure on GNU/Linux IA-64. This problem was
3594 introduced by my 2011-10-07 patch.
3596 2011-12-15 Juri Linkov <juri@jurta.org>
3598 * image.c (imagemagick_error): New function. (Bug#10112)
3599 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3600 Use `imagemagick_error' where ImageMagick functions return
3602 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3605 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3607 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3608 fill background (Bug#8992).
3610 2011-12-13 Martin Rudalics <rudalics@gmx.at>
3612 * window.c (Vwindow_combination_resize)
3613 (Vwindow_combination_limit): Use t instead of non-nil in
3615 (Vrecenter_redisplay): Add first sentence of doc-string on
3617 (Frecenter): Fix doc-string typo.
3619 2011-12-11 Kenichi Handa <handa@m17n.org>
3621 * coding.c (Funencodable_char_position): Pay attention to the
3622 buffer text relocation (Bug#9389).
3624 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3626 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3627 gtk_init (Bug#10100).
3629 2011-12-10 Eli Zaretskii <eliz@gnu.org>
3631 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3632 IT->string is nil. (Bug#10263)
3634 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3636 * nsterm.h (x_free_frame_resources): Declare.
3638 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3639 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3641 * nsterm.h (ns_get_defaults_value): Declare.
3643 * nsterm.m (ns_default): Call ns_get_defaults_value.
3645 2011-12-09 Eli Zaretskii <eliz@gnu.org>
3647 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3650 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3652 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3653 that where the value of an _OBJC_* symbol points to is in the .bss
3654 section (Bug#10240).
3656 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3658 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
3659 after the loop to call ccl_driver at least once (Bug#8619).
3661 2011-12-08 Kenichi Handa <handa@m17n.org>
3663 * ftfont.c (get_adstyle_property): Fix previous change
3666 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
3668 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3669 dirs from the default value of EMACSLOADPATH (bug#10208).
3671 2011-12-07 Glenn Morris <rgm@gnu.org>
3673 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3674 installation and source directories as well. (Bug#10208)
3676 2011-12-06 Chong Yidong <cyd@gnu.org>
3678 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3680 2011-12-06 Glenn Morris <rgm@gnu.org>
3682 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3683 as an error, not just -1. (Bug#10217)
3685 2011-12-05 Chong Yidong <cyd@gnu.org>
3687 * keyboard.c (process_special_events): New function.
3688 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3690 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3692 * coding.c (encode_designation_at_bol): Don't use uninitialized
3693 local variable (Bug#9318).
3695 2011-12-05 Kenichi Handa <handa@m17n.org>
3697 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3698 return Qnil (Bug#8046, Bug#10193).
3700 2011-12-05 Kenichi Handa <handa@m17n.org>
3702 * coding.c (encode_designation_at_bol): New args charbuf_end and
3703 dst. Return the number of produced bytes. Callers changed.
3704 (coding_set_source): Return how many bytes coding->source was
3706 (coding_set_destination): Return how many bytes
3707 coding->destination was relocated.
3708 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
3709 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
3711 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3713 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3714 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3717 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3719 The following changes are to fix Bug#9318.
3721 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
3722 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3723 (encode_coding_iso_2022, encode_coding_sjis)
3724 (encode_coding_big5, encode_coding_charset): Use the above macros.
3726 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
3728 * lisp.h (process_quit_flag): Fix external declaration.
3730 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3732 Don't macro-inline non-performance-critical code.
3733 * eval.c (process_quit_flag): New function.
3734 * lisp.h (QUIT): Use it.
3736 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3738 * nsfns.m (get_geometry_from_preferences): New function.
3739 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3741 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3743 * emacs.c (Qkill_emacs): Define.
3744 (syms_of_emacs): Initialize it.
3745 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3746 Qquit_flag to `kill-emacs' instead.
3747 (quit_throw_to_read_char): Add parameter `from_signal'.
3748 All callers changed. Call Fkill_emacs if requested and safe.
3749 * lisp.h (QUIT): Call Fkill_emacs if requested.
3751 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3753 * widget.c (update_wm_hints): Return if wmshell is null.
3754 (widget_update_wm_size_hints): New function.
3756 * widget.h (widget_update_wm_size_hints): Declare.
3758 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3759 widget_update_wm_size_hints (Bug#10104).
3761 2011-12-03 Eli Zaretskii <eliz@gnu.org>
3763 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3764 before a newline, prepare the bidi iterator for consuming the
3765 newline, and keep the current paragraph direction. (Bug#10183)
3766 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
3768 2011-12-02 Juri Linkov <juri@jurta.org>
3770 * search.c (Fword_search_regexp): New Lisp function created from
3771 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3772 (Fword_search_backward, Fword_search_forward)
3773 (Fword_search_backward_lax, Fword_search_forward_lax):
3774 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3775 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3777 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3779 * fileio.c (Finsert_file_contents): Move after-change-function call
3780 to before the "handled:" label, since all "goto handled" appear in
3781 cases where the *-change-functions have already been properly called
3784 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3786 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3787 waiting for input. (Bug#10169)
3789 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3791 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3792 verifies glyph row's hash code--we have just reallocated the
3793 glyphs, so their contents can be complete garbage. (Bug#10164)
3795 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
3797 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3799 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3801 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3802 attributes are tested _before_ calling verify_row_hash, to protect
3803 against GCC re-ordering of the tests. (Bug#10164)
3805 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3807 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3809 * xterm.c (handle_one_xevent): Only set async_visible and friends
3810 if net_wm_state_hidden_seen is non-zero (Bug#10002)
3811 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
3812 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3814 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3816 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3817 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3818 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3819 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3820 All uses changed to use GCPRO1 etc.
3821 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3822 Revert to old implementation (i.e., before 2011-03-11).
3824 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3826 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3827 of scroll runs so as to avoid assigning disabled bogus rows and
3828 unnecessary graphics copy operations.
3830 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3832 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3833 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3834 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3835 (malloc, free, realloc, calloc): Redirect to e_* only when
3838 * lisp.h (GCTYPEBITS): Move before first use.
3839 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3840 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3841 this macro definition.
3843 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3846 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3848 * gtkutil.c (xg_create_frame_widgets):
3849 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3850 present with Gtk+ 2.0.
3852 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3854 * fileio.c (Finsert_file_contents): Undo previous change; see
3855 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3857 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3859 Rename locals to avoid shadowing.
3860 * fileio.c (Finsert_file_contents):
3861 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3862 * process.c (wait_reading_process_output):
3863 Rename inner 'proc' to 'p' to avoid shadowing.
3864 Indent for consistency with usual Emacs style.
3866 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3868 * xdisp.c (redisplay_window): If cursor row is not fully visible
3869 after recentering, and scroll-conservatively is set to a large
3870 number, scroll window by a few more lines to make the cursor fully
3871 visible and out of scroll-margin. (Bug#10105)
3872 (start_display): Don't move to the next line if the display should
3873 start at a newline that is part of a display vector or an overlay
3876 2011-11-24 Juri Linkov <juri@jurta.org>
3878 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3879 after the `MagickPingImage' call. (Bug#10112)
3881 2011-11-23 Chong Yidong <cyd@gnu.org>
3883 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3885 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3887 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3888 making another buffer current. (Bug#10114)
3890 2011-11-23 Glenn Morris <rgm@gnu.org>
3892 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3894 2011-11-23 Chong Yidong <cyd@gnu.org>
3896 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3897 using it (Bug#5984).
3899 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3901 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3902 and header-lines, as they don't have one computed for them.
3905 * .gdbinit (prow): Make displayed values more self-explaining.
3906 Add row's hash code.
3908 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3910 * process.c (wait_reading_process_output): Fix asynchrounous
3911 GnuTLS socket handling on some versions of the GnuTLS library.
3912 (wait_reading_process_output): Add comment and URL.
3914 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3916 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3918 2011-11-21 Chong Yidong <cyd@gnu.org>
3920 * window.c (Fnext_window, Fprevious_window): Doc fix.
3922 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3924 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3926 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3928 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3930 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3932 * window.c (Fset_window_combination_limit): Rename argument
3934 (Vwindow_combination_limit): Remove "status" from doc-string.
3936 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3938 * m/ibms390.h: Remove.
3939 * m/ibms390x.h: Don't include "ibms390.h".
3941 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3943 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3944 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3946 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3948 * casetab.c (Fset_case_table):
3949 * charset.c (Fcharset_after): Fix typos.
3951 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3953 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3954 Otherwise, valgrind does not work on some platforms.
3955 Problem reported by Andreas Schwab in
3956 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3957 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3958 is set, removing the need for VIRT_ADDRESS_VARIES.
3959 (PURE_P): Use a more-efficient implementation that needs just one
3960 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3961 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3962 to 4 (xorl, subq, cmpq, setbe).
3963 * alloc.c (pure): Always extern now, since that's the
3964 VIRT_ADDR_VARIES behavior.
3965 (PURE_POINTER_P): Use a single comparison, not two, for
3966 consistency with the new puresize.h.
3967 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3968 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3969 Remove VIRT_ADDR_VARIES no longer needed.
3971 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3973 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3974 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3975 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3976 behave as if the cursor position were at the window margin.
3978 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3979 and the cursor position is out of bounds, behave as if the cursor
3980 position were at the window margin. (Bug#10075)
3982 2011-11-18 Chong Yidong <cyd@gnu.org>
3984 * window.c (Fwindow_combination_limit): Make first argument
3985 non-optional, since it is meaningless for live windows like the
3988 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3990 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3992 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3994 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3995 (graft_intervals_into_buffer): Simplify.
3997 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3999 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4000 hash values of the two rows.
4001 (copy_row_except_pointers): Preserve the used[] arrays and the
4002 hash values of the two rows. (Bug#10035)
4003 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
4005 * xdisp.c (row_hash): New function, body extracted from
4006 compute_line_metrics.
4007 (compute_line_metrics): Call row_hash, instead of computing the
4010 * dispnew.c (verify_row_hash): Call row_hash for computing the
4011 hash code of a row, instead of duplicating code from xdisp.c.
4013 * dispextern.h (row_hash): Add prototype.
4015 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4017 * frame.c (delete_frame): Don't delete the terminal when the last
4018 X frame is closed if emacs is built with GTK toolkit.
4020 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
4022 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4024 2011-11-17 Martin Rudalics <rudalics@gmx.at>
4026 * window.c (Vwindow_splits): Rename to
4027 Vwindow_combination_resize. Suggested by Juri Linkov.
4028 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4031 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
4033 * nsfns.m (Fns_font_name):
4034 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4036 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4038 * window.h (window): Rename slot "nest" to "combination_limit".
4039 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4040 (Fset_window_nest): Rename to Fset_window_combination_limit.
4041 (Vwindow_nest): Rename to Vwindow_combination_limit.
4042 (recombine_windows, make_parent_window, make_window)
4043 (Fsplit_window_internal, saved_window)
4044 (Fset_window_configuration, save_window_save): Rename all
4045 occurrences of window_nest to window_combination_limit.
4047 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4049 * image.c (imagemagick_load_image): Fix typo.
4051 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4053 * xdisp.c (display_line): Move the call to
4054 highlight_trailing_whitespace before the call to
4055 compute_line_metrics, since the latter needs to see the final
4056 faces of all the glyphs to compute ROW's hash value.
4057 Fixes assertion violations in row_equal_p. (Bug#10035)
4059 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4061 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4062 just return (bug#10044).
4064 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4066 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4067 with user-defined heap size. Bump the default size of the temacs
4068 heap to 27MB, to avoid memory warning when running temacs.
4069 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4071 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4072 current_matrix and desired_matrix. (Bug#9990)
4073 (verify_row_hash) [XASSERTS]: New function.
4074 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4075 that the hash value of glyph rows is correct.
4077 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4079 * window.h (window): Remove splits slot.
4080 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4081 (Fdelete_other_windows_internal, make_parent_window)
4082 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4083 (Fset_window_configuration, save_window_save): Don't deal with
4084 split status of windows.
4085 (saved_window): Remove splits slot.
4086 (Vwindow_splits): Rewrite doc-string.
4088 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4090 * xfns.c (unwind_create_frame):
4091 * nsfns.m (unwind_create_frame):
4092 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4093 Vframe_list (Bug#9999).
4095 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4097 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4099 2011-11-11 Kenichi Handa <handa@m17n.org>
4101 * callproc.c (Fcall_process): Set the member dst_multibyte of
4104 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4106 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4107 avoid a crash (bug#9496).
4109 2011-11-09 Chong Yidong <cyd@gnu.org>
4111 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4112 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4114 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4116 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4118 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4120 Avoid some portability problems by eschewing 'extern inline' functions.
4121 The trivial performance wins aren't worth the portability hassles; see
4122 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4124 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4125 (window_box_width, window_box_left, window_box_left_offset)
4126 (window_box_right, window_box_right_offset): Undo previous change,
4127 by removing the "extern"s.
4128 * intervals.c (adjust_intervals_for_insertion)
4129 (adjust_intervals_for_deletion): Undo previous change,
4130 making these static again.
4131 (offset_intervals, temp_set_point_both, temp_set_point)
4132 (copy_intervals_to_string): No longer inline.
4133 * xdisp.c (window_text_bottom_y, window_box_width)
4134 (window_box_height, window_box_left_offset)
4135 (window_box_right_offset, window_box_left, window_box_right)
4136 (window_box): No longer inline.
4138 2011-11-08 Chong Yidong <cyd@gnu.org>
4140 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4141 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4142 Signal an error if not a live window.
4143 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4144 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4146 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4148 * lisp.h (syms_of_abbrev): Remove declaration.
4149 Reported by CHENG Gao <chenggao@royau.me>.
4151 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4153 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4154 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4155 of temacs in GUI mode.
4157 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4159 * window.h: Declare delete_all_child_windows instead of
4160 delete_all_subwindows.
4161 * window.c (Fwindow_nest, Fset_window_nest)
4162 (Fset_window_new_total, Fset_window_new_normal)
4163 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4164 (delete_all_subwindows): Rename to delete_all_child_windows.
4165 (Fdelete_other_windows_internal, Fset_window_configuration):
4166 Call delete_all_child_windows instead of delete_all_subwindows.
4167 * frame.c (delete_frame): Call delete_all_child_windows instead
4168 of delete_all_subwindows.
4170 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4172 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4173 This is also needed for porting to any host where GC_MARK_STACK is
4174 not GC_MAKE_GCPROS_NOOPS.
4175 (which_symbols): Use it.
4177 2011-11-07 Kenichi Handa <handa@m17n.org>
4179 * coding.c (coding_set_destination): Check coding->src_pos only
4180 when coding->src_object is a buffer (bug#9910).
4182 * process.c (send_process): Set the member src_multibyte of coding
4183 to 0 (bug#9911) when sending a unibyte text.
4185 * callproc.c (Fcall_process): Set the member src_multibyte of
4186 process_coding to 0 (bug#9912).
4188 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4190 * xmenu.c (cleanup_widget_value_tree): New function.
4191 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4192 calling free_menubar_widget_value_tree directly (Bug#9830).
4194 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4196 Fix some portability problems with 'inline'.
4197 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4198 (window_box_width, window_box_left, window_box_left_offset)
4199 (window_box_right, window_box_right_offset): Declare extern.
4200 Otherwise, these inline functions do not conform to C99 and
4201 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4202 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4203 * intervals.c (adjust_intervals_for_insertion)
4204 (adjust_intervals_for_deletion): Now extern, because otherwise the
4205 extern inline functions 'offset_intervals' couldn't refer to it.
4206 (static_offset_intervals): Remove.
4207 (offset_intervals): Rewrite using the old contents of
4208 static_offset_intervals. The old version didn't conform to C99
4209 because an extern inline function contained a reference to an
4210 identifier with static linkage.
4212 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4214 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4217 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4219 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4220 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4221 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4222 return Qleft_to_right.
4224 2011-11-06 Chong Yidong <cyd@gnu.org>
4226 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4227 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4228 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4229 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4230 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4231 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4232 (Fwindow_vscroll): Doc fix.
4233 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4234 argument, since it makes no sense to pass a live window and for
4235 consistency with window-child.
4237 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4239 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4242 2011-11-05 Jason Rumney <jasonr@gnu.org>
4244 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4245 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4247 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4248 bitwise arithmetic preventing use of unicode-sip and non-truetype
4251 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4253 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4256 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4257 initialization code to keep similarity to xfns.c after changes
4260 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4262 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4263 (unwind_create_frame): New function (Bug#9943).
4264 (Fx_create_frame): Restructure code to be more similar to the one in
4265 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4266 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4267 Move terminal->reference_count++ just before making the frame official
4270 * nsterm.m (x_free_frame_resources): New function.
4271 (x_destroy_window): Move code to x_free_frame_resources.
4273 * xfns.c (unwind_create_frame): Fix comment.
4274 (Fx_create_frame, x_create_tip_frame):
4275 Move terminal->reference_count++ just before making the frame
4276 official. Move initialization of image_cache_refcount and
4277 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4279 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4281 Support MSVC build with newer versions of Visual Studio.
4282 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4283 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4286 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4287 which are not supported by MSVC.
4288 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4289 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4291 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4293 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4295 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4297 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
4299 Support MSVC build with newer versions of Visual Studio.
4300 * w32.c: Don't include w32api.h for MSVC.
4301 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4303 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4304 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4305 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4306 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4308 (alloca) [_MSC_VER]: Define to _alloca.
4310 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4312 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4314 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4316 * xdisp.c (note_mouse_highlight): If either of
4317 previous/next-single-property-change returns nil, treat that as
4318 the beginning or the end of the buffer. (Bug#9955)
4320 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4322 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
4323 label is not null (Bug#9951).
4324 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4327 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4329 * window.c (Fwindow_body_size): Mention in the doc string that the
4330 return value is in frame's canonical units. (Bug#9949)
4332 2011-11-03 Eli Zaretskii <eliz@gnu.org>
4334 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4336 * w32fns.c (unwind_create_frame): If needed, free the glyph
4337 matrices of the partially constructed frame. (Bug#9943)
4338 * xfns.c (unwind_create_frame): Likewise.
4340 2011-11-01 Eli Zaretskii <eliz@gnu.org>
4342 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4343 Don't stop backward scan on the continuation glyph, even though
4344 its CHARPOS is positive.
4345 (mouse_face_from_buffer_pos, note_mouse_highlight):
4346 Rename cover_string to disp_string.
4348 2011-11-01 Martin Rudalics <rudalics@gmx.at>
4350 * window.c (temp_output_buffer_show): Don't use
4351 Vtemp_buffer_show_specifiers.
4352 (Vtemp_buffer_show_specifiers): Remove unused variable.
4354 2011-10-30 Eli Zaretskii <eliz@gnu.org>
4356 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4357 past the beginning of the current glyph matrix.
4359 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
4361 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4362 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4363 HAVE_GTK3 (Bug#9869).
4365 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4366 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4368 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4370 * xterm.c: Declare x_handle_net_wm_state to return int.
4371 (handle_one_xevent): Check if we are iconified but don't have
4372 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4373 (get_current_wm_state): Return non-zero if not hidden,
4374 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4375 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4376 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4377 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4379 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4381 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4382 so that this new function doesn't get optimized away by a
4383 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4385 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4387 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4389 2011-10-29 Eli Zaretskii <eliz@gnu.org>
4391 Fix the `xbytecode' command.
4392 * .gdbinit (xprintbytestr): New command.
4393 (xwhichsymbols): Rename from `which'; all callers changed.
4394 (xbytecode): Print the byte-code string as well.
4396 2011-10-29 Kim Storm <storm@cua.dk>
4398 * alloc.c (which_symbols): New function.
4400 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4402 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4405 2011-10-29 Glenn Morris <rgm@gnu.org>
4407 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4408 Not clear what it was for, and it causes various bugs. (Bug#9839)
4410 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4412 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4413 possible random value that matches one of those tested as
4414 condition to clear the mouse face.
4416 2011-10-28 Chong Yidong <cyd@gnu.org>
4418 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4420 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4422 * window.c (make_window): Initialize phys_cursor_on_p.
4424 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4426 * lisp.h (struct Lisp_Symbol): Update comments.
4428 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
4430 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4432 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4434 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4435 <oslsachem@gmail.com> for helping to debug this.
4437 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4438 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4439 (g_b_init_get_glyph_outline_w): New static variables.
4440 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4441 (GetGlyphOutlineW_Proc): New typedefs.
4442 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
4443 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4445 (w32font_open_internal, compute_metrics):
4446 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
4447 instead of calling the "wide" APIs directly.
4449 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4451 * w32.h (syms_of_w32font): Add prototype.
4453 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4455 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4456 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4457 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4458 (Fmove_to_window_line): Doc fix.
4460 2011-10-27 Chong Yidong <cyd@gnu.org>
4462 * process.c (make_process): Set gnutls_state to NULL.
4464 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4465 non-NULL, regardless of GNUTLS_INITSTAGE.
4466 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4467 an error. Set process slots as soon as we allocate them.
4469 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4471 2011-10-27 Chong Yidong <cyd@gnu.org>
4473 * gnutls.c (emacs_gnutls_deinit): New function.
4474 Deallocate credentials structures as well as calling gnutls_deinit.
4475 (Fgnutls_deinit, Fgnutls_boot): Use it.
4477 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4478 (deactivate_process): Call emacs_gnutls_deinit.
4480 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4482 * image.c (x_create_x_image_and_pixmap):
4483 * w32.c (sys_rename, w32_delayed_load):
4484 * w32font.c (fill_in_logfont):
4485 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4487 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
4489 * w32fns.c (w32_default_color_map): New function,
4490 extracted from Fw32_default_color_map.
4491 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
4493 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4495 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4497 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4499 * keyboard.c (test_undefined): New function (bug#9751).
4500 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4502 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4504 * sysdep.c (init_sys_modes): Fix the check for the controlling
4505 terminal (Bug#6649).
4507 2011-10-20 Eli Zaretskii <eliz@gnu.org>
4509 * dispextern.h (struct bidi_it): New member next_en_type.
4511 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4512 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4513 current character, check also for next_en_type being WEAK_EN.
4514 (bidi_resolve_weak): Don't enter the expensive loop if the current
4515 position is before next_en_pos. Record the bidi type of the first
4516 non-ET, non-BN character we find, in addition to its position.
4517 (bidi_level_of_next_char): Invalidate next_en_type when
4518 next_en_pos is over-stepped.
4520 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4522 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4523 * editfns.c: Rewrite current-time-zone so that it invokes
4524 the equivalent of (format-time-string "%Z") to get the time zone name.
4525 This fixes a bug when the time zone name contains characters that
4526 need converting from the system time locale to Emacs internal format.
4527 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4528 that patch fixed format-time-string to do the conversion, but
4529 I forgot to fix current-time-zone.
4530 (format_time_string): New function, containing most of
4531 what Fformat_time_string used to contain.
4532 (Fformat_time_string): Rewrite in terms of format_time_string.
4533 This doesn't change this function's behavior.
4534 (current-time-zone): Rewrite to use format_time_string.
4535 This fixes the bug reported by Michael Schierl in
4536 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4537 Jason Rumney's 2007-06-07 change worked around this bug, but
4539 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4541 2011-10-19 Eli Zaretskii <eliz@gnu.org>
4543 * xdisp.c (start_display): If the character at POS is displayed
4544 via a display vector, reset IT->current.dpvec_index to zero.
4545 (try_window_reusing_current_matrix): If a line ends in a display
4546 vector or the next line starts in a display vector, continue
4547 redrawing the window even though the character position of
4548 start_row was reached.
4551 2011-10-18 Chong Yidong <cyd@gnu.org>
4553 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4554 with nobreak-char-display too.
4556 2011-10-18 Eli Zaretskii <eliz@gnu.org>
4558 Fix part 3 of bug#9771.
4559 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4560 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4561 non-neutral characters if the current character is a paragraph
4562 separator (a.k.a. Newline). This avoids running the same
4563 expensive loop twice, once when we consume the preceding newline
4564 and the other time when the line actually needs to be displayed.
4565 Avoid the loop when we see neutrals on the base embedding level
4566 following a character whose directionality is the same as the
4567 paragraph's. This avoids running the expensive loop when a line
4568 ends in a long sequence of neutrals, like control characters.
4569 Add assertion against STRONG_AL type. Slightly rearrange code
4570 that determines the type of a neutral given the first non-neutral
4572 (bidi_level_of_next_char): Set next_en_pos to zero when
4573 invalidating its info.
4575 2011-10-17 Eli Zaretskii <eliz@gnu.org>
4577 * xdisp.c (push_display_prop): Determine whether to record string
4578 or buffer position by IT->string, not by IT->method. Allow
4579 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
4580 (move_it_vertically_backward): Don't look for character position
4581 immediately after the newline when in a continuation line.
4584 2011-10-15 Martin Rudalics <rudalics@gmx.at>
4586 * window.c (coordinates_in_window): Rewrite and delabelize
4587 vertical border check. (Bug#5357) (Bug#9618)
4589 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4591 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4592 errors in XSetWindowBorder (bug#9310).
4594 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4596 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4597 avoid crash when xmalloc overrun checking is enabled.
4599 2011-10-13 Eli Zaretskii <eliz@gnu.org>
4601 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4602 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4603 cursor motion with <left> and <right> arrow keys.
4605 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4606 some callers set that themselves.
4608 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4610 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4611 display string and the previous row comes from the same string and
4612 is empty. (Bug#9739) (Bug#9738)
4614 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4616 * doc.c (get_doc_string): Encode file name (bug#9735).
4618 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4620 * bidi.c (bidi_level_of_next_char):
4621 * xdisp.c (get_visually_first_element): Remove old incorrect
4622 comments regarding the Unicode Line Separator character.
4624 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4626 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4628 * alloc.c (Fgc_status): Do not access beyond zombies array
4629 boundary if nzombies > MAX_ZOMBIES.
4630 * alloc.c (dump_zombies): Add missing format specifier.
4632 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4634 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4635 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4637 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4638 Some packages use them to denote characters with modifiers.
4640 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4642 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4643 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4644 matching a pp-number. Rename parameter var to var1.
4646 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4648 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4650 2011-10-08 Glenn Morris <rgm@gnu.org>
4652 * callint.c (Fcall_interactively): Give a more explicit error for the
4653 'c' case with a non-character input. (Bug#8479)
4655 2011-10-08 Eli Zaretskii <eliz@gnu.org>
4657 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4659 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4660 lines that are hscrolled on the left.
4662 * dispnew.c (buffer_posn_from_coords): Account for a possible
4663 presence of header-line. (Bug#4426)
4665 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4667 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4668 Don't advertise functionality which we discourage or doesn't work.
4670 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4672 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4673 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4674 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4675 this makes Emacs dump core during garbage collection on rare
4676 occasions. sizeof is obviously inferior to offsetof here, so
4677 stick with offsetof.
4678 (GC_POINTER_ALIGNMENT): New macro.
4679 (mark_memory): Omit 3rd (offset) arg; caller changed.
4680 Don't assume EMACS_INT alignment is the same as pointer alignment.
4682 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4684 * keyboard.c (read_key_sequence_remapped): New var.
4685 (read_key_sequence): Compute remapping in the right buffer.
4686 (command_loop_1): Use read_key_sequence's remapping directly.
4688 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4690 * dired.c (file_name_completion): Don't expand file name.
4691 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4692 before checking file name handler.
4694 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4695 they've been requested explicitly (bug#9591).
4697 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
4699 * keymap.c (Fsingle_key_description): Use make_specified_string
4700 instead of build_string to build string from push_key_description.
4703 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4705 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4706 This fixes a Y2038 bug on 64-bit hosts.
4707 * buffer.c (reset_buffer):
4708 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4709 (Fclear_buffer_auto_save_failure):
4710 Use 0, not -1, to represent an unset failure time, since time_t
4711 might not be signed.
4713 Remove dependency on glibc malloc internals.
4714 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4715 Move back here from lisp.h, but with their new implementations.
4716 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4717 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4718 * charset.c (charset_table_init): New static var.
4719 (syms_of_charset): Use it instead of xmalloc. This removes a
4720 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4721 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4722 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4723 Move back to alloc.c.
4724 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4725 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4727 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4729 * nsterm.m (windowDidResize): Call x_set_window_size only when
4730 ns_in_resize is true. Otherwise set pixelwidth/height and
4731 call change_frame_size (Bug#9628).
4733 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4735 Port --enable-checking=all to Fedora 14 x86-64.
4736 * charset.c (syms_of_charset): Also account for glibc malloc's
4737 internal overhead when calculating the initial malloc maximum.
4739 Port --enable-checking=all to Fedora 14 x86.
4740 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4742 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4743 (overrun_check_realloc, overrun_check_free):
4744 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4745 That way, xmalloc returns a properly-aligned pointer even if
4746 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4747 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4748 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4749 into account when calculating the initial malloc maximum.
4750 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4751 Move here from alloc.c, so that charset.c can use it too.
4752 Properly align; the old code wasn't right for common 32-bit hosts
4753 when configured with --enable-checking=all.
4754 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4755 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4757 2011-09-29 Eli Zaretskii <eliz@gnu.org>
4759 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
4762 2011-09-28 Eli Zaretskii <eliz@gnu.org>
4764 * xdisp.c (compute_display_string_end): If there's no display
4765 string at CHARPOS, return -1.
4767 * bidi.c (bidi_fetch_char): When compute_display_string_end
4768 returns a negative value, treat the character as a normal
4769 character not covered by a display string. (Bug#9624)
4771 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
4773 * lread.c (Fread_from_string): Fix typo in docstring.
4775 2011-09-27 Eli Zaretskii <eliz@gnu.org>
4777 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4778 newline, reseat the iterator instead of bidi-iterating there one
4779 character at a time. (Bug#9610)
4780 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4781 TO_CHARPOS if the bidi iterator is at base embedding level.
4783 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4785 * lread.c (readevalloop): Use correct code for NBSP.
4786 (read1): Likewise. (Bug#9608)
4788 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
4790 * dbusbind.c (Fdbus_register_signal): When service is not
4791 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4793 2011-09-25 Glenn Morris <rgm@gnu.org>
4795 * buffer.c (truncate-lines): Doc fix.
4797 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
4799 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4800 (Fset_window_next_buffers): Doc fix.
4802 2011-09-24 Glenn Morris <rgm@gnu.org>
4804 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4806 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4808 Fix minor problems found by static checking.
4809 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
4810 * indent.c (Fvertical_motion): Fix == vs = typo.
4812 2011-09-24 Eli Zaretskii <eliz@gnu.org>
4814 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4815 Default value is now t. Doc fix.
4817 * indent.c (Fvertical_motion): Compute and apply the overshoot
4818 logic when moving up, not only when moving down. Fix the
4819 confusing name and values of the it_overshoot_expected variable;
4820 logic changes accordingly. (Bug#9254) (Bug#9549)
4822 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4823 CHARPOS is covered by a display string which includes newlines.
4824 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4825 is covered by a display string with embedded newlines.
4827 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4829 * dbusbind.c (Fdbus_register_signal): Add match rule to
4830 Vdbus_registered_objects_table. (Bug#9581)
4831 (Fdbus_register_method, Vdbus_registered_objects_table):
4834 2011-09-24 Jim Meyering <meyering@redhat.com>
4836 do not ignore write error for any output size
4837 The previous change was incomplete.
4838 While it makes emacs --batch detect the vast majority of stdout
4839 write failures, errors were still ignored whenever the output size is
4840 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4841 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4842 && echo FAIL: ignored write error
4843 FAIL: ignored write error
4844 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4845 && echo FAIL: ignored write error
4846 FAIL: ignored write error
4847 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4849 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4851 * emacs.c (Fkill_emacs): In noninteractive mode exit
4852 non-successfully if a write error occurred on stdout. (Bug#9574)
4854 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4856 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4859 * dispextern.h (struct it): Update the comment documenting what
4862 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4864 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4865 a display string, extend search for cursor position to end of row.
4866 (find_row_edges): If the row ends in a newline from a display
4867 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4868 Handle the case of a display string with multiple newlines.
4869 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4870 non-empty line. Fixes confusing cursor motion with arrow keys at
4871 the beginning of a line that starts with whitespace.
4873 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4875 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4878 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4880 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4883 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4885 * xdisp.c (display_line): Record maximum and minimum buffer
4886 positions even if no glyphs were produced (e.g., by a zero-width
4887 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4888 buffer positions that will be removed from the glyph row because
4890 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4891 column is beyond frame width: don't subtract 1 "pixel" when
4892 computing width of the stretch.
4893 (reseat_at_next_visible_line_start): Undo the change made on
4894 2011-09-17 that saved paragraph information and restored it after
4895 the call to `reseat'. (Bug#9545)
4897 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4899 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4900 and turn window cursor on if cleared (Bug#9415).
4902 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4904 * search.c (boyer_moore): Take unibyte characters from pattern
4905 literally. (Bug#9458)
4907 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4909 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4911 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4913 Fix minor problem found by static checking.
4914 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4915 initialized, to pacify gcc -Wuninitialized.
4917 * fileio.c: Report proper errno when syscall falls.
4918 (Finsert_file_contents): Save and restore errno,
4919 so that report_file_error outputs the correct diagnostic.
4920 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4922 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4924 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4926 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4928 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4929 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4931 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4933 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4934 about the current paragraph and restore it after the call to reseat.
4936 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4937 (bidi_find_paragraph_start): Search back for paragraph beginning
4938 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4939 (bidi_move_to_visually_next): Only trigger paragraph-related
4940 computations when the last character is a newline or at EOB, not
4941 just any NEUTRAL_B. (Bug#9470)
4943 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4944 truncated lines if point is covered by a display string. (Bug#9524)
4946 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4948 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4949 (cons_to_x_long): New function.
4950 (lisp_data_to_selection_data): Use it. Correct the test for
4951 short-versus-long data; it was negated. Break out of vector
4952 loop, for efficiency, when a long datum is discovered.
4954 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4956 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4958 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4960 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4961 GCC PR/17406) by declaring this function with external scope.
4963 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4965 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4966 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4968 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4970 * editfns.c (Fformat): Correctly handle text properties on "%%".
4972 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4974 * xterm.c (x_draw_composite_glyph_string_foreground):
4975 * w32term.c (x_draw_composite_glyph_string_foreground):
4976 * term.c (encode_terminal_code):
4977 * composite.c (composition_update_it, get_composition_id):
4978 * xdisp.c (get_next_display_element)
4979 (fill_composite_glyph_string): Add comments about special meaning
4980 of TAB characters in a composition.
4982 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4984 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4985 This occurs when processing a multibyte format.
4986 Problem reported by Wolfgang Jenker.
4988 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4990 * xdisp.c (try_cursor_movement): Only check for exact match if
4991 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4993 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4995 Remove unused external symbols.
4996 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4997 * xdisp.c (calc_pixel_width_or_height): Now static.
4998 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4999 * indent.c (check_display_width):
5000 * w32term.c: Fix comment to match code.
5001 * xterm.c, xterm.h (x_catching_errors): Remove.
5003 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5005 * xselect.c: Use signed conversions more consistently (Bug#9498).
5006 (selection_data_to_lisp_data): Assume incoming selection data are
5007 signed integers, not unsigned. This is to be consistent with
5008 outgoing selection data, which was modified to use signed integers
5009 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5010 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5011 expects long, not unsigned long.
5013 2011-09-14 Eli Zaretskii <eliz@gnu.org>
5015 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5016 computation of loop end. Reported by Johan Bockgård
5019 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
5021 * frame.c (Fother_visible_frames_p): Function deleted.
5023 2011-09-12 Eli Zaretskii <eliz@gnu.org>
5025 * indent.c (compute_motion): Process display vector front to back
5026 rather than the other way around. (Bug#2496)
5028 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5030 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5032 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
5034 * minibuf.c (Fread_from_minibuffer): Doc fix.
5036 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5038 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5039 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5041 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5043 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5044 value for non-existent files.
5046 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5048 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5049 set its "size" to -1. This will set the modtime_size field of
5050 the corresponding buffer to -1, which is what
5051 verify-visited-file-modtime expects for files that do not exist.
5054 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5056 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5058 * lisp.h: ... from here. push_key_description is no longer
5059 defined in keyboard.c, so its declaration should not be in
5060 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5061 logically belongs with push_key_description.
5063 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5065 * buffer.h: Include <sys/types.h> instead of <time.h>.
5066 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5067 Problem reported by Herbert J. Skuhra.
5069 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5071 * xml.c (parse_region): Make the parsing work for
5072 non-comment-starting XML files again (bug#9144).
5074 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5076 * image.c (gif_load): Fix calculation of bottom and right corner.
5079 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5081 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5082 redisplay in small windows.
5084 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5086 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5088 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5090 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5091 Operate on live windows only.
5093 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5095 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5097 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5099 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5100 only under bidi iteration.
5102 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5104 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5106 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5108 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5109 Without this fix, the command to link temacs failed due to an
5110 undefined symbol __builtin_isnan. This is because
5111 /usr/include/iso/math_c99.h #defines isnan(x) to
5112 __builtin_isnan(x), but the bundled gcc, which identifies itself
5113 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5115 * floatfns.c (isnan): #undef, and then #define to a clone of
5117 (Fisnan): Always define, since it's always available now.
5118 (syms_of_floatfns): Always define isnan at the Lisp level.
5120 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5122 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5124 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5126 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5127 The previous code assumed that file offsets (off_t values) fit in
5128 EMACS_INT variables, which is not true on typical 32-bit hosts.
5129 The code messed up by falsely reporting buffer overflow in cases
5130 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5131 when "big" contains more than 2**29 bytes, even though this
5132 inserts just one byte and does not overflow the buffer.
5133 (Finsert_file_contents): Store file offsets as off_t
5134 values, not as EMACS_INT values. Check for overflow when
5135 converting between EMACS_INT and off_t. When checking for
5136 buffer overflow or for overlap, take the offsets into account.
5137 Don't use EMACS_INT for small values where int suffices.
5138 When checking for overlap, fix a typo: ZV was used where
5139 ZV_BYTE was intended.
5140 (Fwrite_region): Don't assume off_t fits into 'long'.
5141 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5143 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5145 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5147 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5149 sprintf-related integer and memory overflow issues (Bug#9412).
5151 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5152 (esprintf, exprintf, evxprintf): New functions.
5153 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5154 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5155 (modify_event_symbol): Do not assume that the length of
5156 name_alist_or_stem is safe to alloca and fits in int.
5157 (Fexecute_extended_command): Likewise for function name and binding.
5158 (Frecursion_depth): Wrap around reliably on integer overflow.
5159 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5160 since some callers pass EMACS_INT values.
5161 (Fsingle_key_description): Don't crash if symbol name contains more
5162 than MAX_ALLOCA bytes.
5163 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5164 (get_minibuffer): Arg is now EMACS_INT, not int.
5165 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5166 (esprintf, exprintf, evxprintf): New decls.
5167 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5169 * dbusbind.c (signature_cat): New function.
5170 (xd_signature, Fdbus_register_signal):
5171 Do not overrun buffer; instead, report string overflow.
5173 * dispnew.c (add_window_display_history): Don't overrun buffer.
5174 Truncate instead; this is OK since it's just a log.
5176 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5177 even if the time zone offset is outlandishly large.
5178 Don't mishandle offset == INT_MIN.
5180 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5181 when creating daemon; the previous buffer-overflow check was incorrect.
5183 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5184 which has the guts of the old verror function.
5186 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5187 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5189 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5190 (font_unparse_xlfd): Don't blindly alloca long strings.
5191 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5192 fits in int, when using sprintf. Use single snprintf to count
5193 length of string rather than counting it via multiple sprintfs;
5194 that's simpler and more reliable.
5195 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5196 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5197 sprintf, in case result does not fit in int.
5199 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5200 (fontset_from_font): Print it.
5202 * frame.c (tty_frame_count): Now printmax_t, not int.
5203 (make_terminal_frame, set_term_frame_name): Print it.
5204 (x_report_frame_params): In X, window IDs are unsigned long,
5205 not signed long, so print them as unsigned.
5206 (validate_x_resource_name): Check for implausibly long names,
5207 and don't assume name length fits in 'int'.
5208 (x_get_resource_string): Don't blindly alloca invocation name;
5209 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5212 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5213 (xg_check_special_colors, xg_set_geometry):
5214 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5216 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5217 Use esprintf, not sprintf, in case result does not fit in int.
5219 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5220 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5221 it as a large positive number.
5222 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5223 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5225 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5226 in case result does not fit in int.
5228 * print.c (float_to_string): Detect width overflow more reliably.
5229 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5230 buffer overrun. Don't assume list length fits in 'int'. Treat
5231 print length of 0 as 0, not as infinity; to be consistent with other
5232 uses of print length in this function. Don't overflow print length
5233 index. Don't assume hash table size fits in 'long', or that
5234 vectorlike size fits in 'unsigned long'.
5236 * process.c (make_process): Use printmax_t, not int, to format
5237 process-name gensyms.
5239 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5241 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5242 to avoid potential buffer overrun.
5244 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5245 if X resource line is longer than 512 bytes.
5247 * xfns.c (x_window): Make sprintf buffer a bit bigger
5248 to avoid potential buffer overrun.
5250 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5252 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5254 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5256 Integer overflow fixes for scrolling, etc.
5257 Without these, Emacs silently mishandles large integers sometimes.
5258 For example, "C-u 4294967297 M-x recenter" was treated as if
5259 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5261 * xdisp.c (try_window_id): Check Emacs fixnum range before
5262 converting to 'int'.
5264 * window.c (window_scroll_line_based, Frecenter):
5265 Check that an Emacs fixnum is in range before assigning it to 'int'.
5266 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5267 values converted from Emacs fixnums.
5268 (Frecenter): Don't wrap around a line count if it is out of 'int'
5269 range; instead, treat it as an extreme value.
5270 (Fset_window_configuration, compare_window_configurations):
5271 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5273 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5274 that can exceed INT_MAX. Check that EMACS_INT value is in range
5275 before assigning it to the (possibly-narrower) index.
5276 (match_limit): Don't assume that a fixnum can fit in 'int'.
5278 * print.c (print_object): Use ptrdiff_t, not int, for index that can
5281 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
5282 (Fvertical_motion): Don't wrap around LINES values that don't fit
5283 in 'int'. Instead, treat them as extreme values. This is good
5284 enough for windows, which can't have more than INT_MAX lines anyway.
5286 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5288 * Require libxml/parser.h to avoid compilation warning.
5290 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5292 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5293 since this reportedly can destroy thread storage.
5295 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
5297 * syntax.c (find_defun_start): Update all cache variables if
5298 exiting early (Bug#9401).
5300 2011-08-30 Eli Zaretskii <eliz@gnu.org>
5302 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5304 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5305 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5306 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5308 * term.c (tty_append_glyph): New function.
5309 (produce_stretch_glyph): Static function and its prototype deleted.
5311 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5314 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5316 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5317 when checking :margin (Bug#9390).
5318 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
5319 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
5320 so that the name doesn't mislead. All uses changed.
5322 2011-08-28 Johan Bockgård <bojohan@gnu.org>
5324 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5327 2011-08-27 Eli Zaretskii <eliz@gnu.org>
5329 * xdisp.c (move_it_to): Don't bail out early when reaching
5330 position beyond to_charpos, if we are scanning backwards.
5331 (move_it_vertically_backward): When DY == 0, make sure we get to
5332 the first character in the line after the newline.
5334 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5336 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5337 (ccl_driver): Do not generate an out-of-range pointer.
5338 (Fccl_execute_on_string): Remove unnecessary check for
5339 integer overflow, noted by Stefan Monnier in
5340 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5341 Remove a FIXME that didn't need fixing.
5342 Simplify the newly-introduced buffer reallocation code.
5344 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
5346 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5348 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
5350 Integer and memory overflow issues (Bug#9196).
5352 * doc.c (get_doc_string): Rework so that
5353 get_doc_string_buffer_size is the actual buffer size, rather than
5354 being 1 less than the actual buffer size; this makes xpalloc more
5357 * image.c (x_allocate_bitmap_record, cache_image):
5358 * xselect.c (Fx_register_dnd_atom):
5359 Simplify previous changes by using xpalloc.
5361 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5362 since either will do and ptrdiff_t is convenient with xpalloc.
5364 * charset.c (charset_table_size)
5365 (struct charset_sort_data.priority): Now ptrdiff_t.
5366 (charset_compare): Don't overflow if priorities differ greatly.
5367 (Fsort_charsets): Don't assume list length fits in int.
5368 Check for size-calculation overflow when allocating sort data.
5369 (syms_of_charset): Allocate an initial charset table that is
5370 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5372 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5374 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5375 The actual value is always <= INT_MAX, and leaving it unsigned made
5376 overflow checking harder.
5378 * dispextern.h (struct glyph_matrix.rows_allocated)
5379 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5380 with xpalloc. The values are still always <= INT_MAX.
5382 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5384 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5385 (SAFE_NALLOCA): New macro.
5387 * region-cache.c (struct boundary.pos, find_cache_boundary)
5388 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5389 (set_cache_region, invalidate_region_cache)
5390 (revalidate_region_cache, know_region_cache, region_cache_forward)
5391 (region_cache_backward, pp_cache):
5392 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5393 so that ptrdiff_t * can be passed to xpalloc.
5394 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5395 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5396 (pp_cache): Don't assume cache_len fits in int.
5397 * region-cache.h: Adjust extern decls to match.
5399 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5400 EMACS_INT, since either will do, for xpalloc.
5402 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5403 (xnmalloc, xnrealloc, xpalloc): New functions.
5405 * bidi.c (bidi_shelve_header_size): New constant.
5406 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5407 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5409 * bidi.c (bidi_cache_shrink):
5410 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5412 Don't update size of array until after memory allocation succeeds,
5413 because xmalloc/xrealloc may not return.
5414 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5415 now that we have proper integer overflow checking.
5416 (record_overlay_string, overlay_strings): Catch overflows when
5417 calculating size of overlay_str_buf.
5419 * callproc.c (Fcall_process): Check for size overflow when
5420 calculating size of args2.
5421 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5422 Normally we prefer signed values, but sticking with ptrdiff_t would
5423 require adding more-complicated checks.
5425 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5426 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5427 Redo buffer-overflow calculations to avoid integer overflow.
5428 Add a FIXME comment where memory seems to be over-allocated.
5430 * character.c (Fstring): Check for size-calculation overflow.
5432 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5433 unnecessary integer overflow. Check for size overflow.
5434 (encode_coding_object): Don't update size until xmalloc succeeds.
5436 * composite.c (get_composition_id): Check for overflow in glyph
5437 length calculations.
5439 Integer and memory overflow fixes for display code.
5440 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5441 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5442 (scrolling_window): Check for overflow in size calculations.
5443 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5444 Don't assume glyph table len fits in int.
5445 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5446 (row_table_size): Now ptrdiff_t, not int.
5447 (scrolling_window): Avoid overflow in size calculations.
5448 Don't update size until allocation succeeds.
5449 * fns.c (concat): Check for overflow in size calculations.
5450 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5451 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5452 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5454 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5455 (get_doc_string): Check for size calculation overflow.
5456 Don't update size until allocation succeeds.
5457 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5458 EMACS_INT, where ptrdiff_t will do.
5459 (Fsubstitute_command_keys): Check for string overflow.
5461 * editfns.c (set_time_zone_rule): Don't assume environment length
5463 (message_length): Now ptrdiff_t, not int.
5464 (Fmessage_box): Don't update size until allocation succeeds.
5465 Don't assume message length fits in int.
5466 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5468 * emacs.c (main): Do not reallocate argv, since there is a null at
5469 the end that can be overwritten, and this way there's no need to
5470 worry about size-calculation overflow.
5471 (sort_args): Check for size-calculation overflow.
5473 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5475 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5477 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5478 (x_set_scroll_bar_width, x_figure_window_size):
5479 Check for integer overflow.
5480 (x_set_alpha): Do not assume XINT fits in int.
5482 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5483 This is for the members text_lines, text_cols, total_lines, total_cols,
5484 where the system imposes an 'int' limit.
5486 * fringe.c (Fdefine_fringe_bitmap):
5487 Don't update size until alloc works.
5489 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5490 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5492 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5493 Check for size-calculation overflow.
5494 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5495 do, as we prefer signed integers.
5496 (id_to_widget.max_size, id_to_widget.used)
5497 (xg_store_widget_in_map, xg_remove_widget_from_map)
5498 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5499 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5500 Use and return ptrdiff_t, not int.
5501 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5502 * gtkutil.h: Change prototypes to match the above.
5504 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5505 are duplicate now that they've been promoted to lisp.h.
5506 (x_allocate_bitmap_record, x_alloc_image_color)
5507 (make_image_cache, cache_image, xpm_load):
5508 Don't update size until alloc is done.
5509 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5511 Check for size calculation overflow.
5512 (ct_colors_allocated_max): New constant.
5513 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5516 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5517 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5518 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5519 Use ptrdiff_t, not int, to count maps.
5520 (read_char_minibuf_menu_prompt): Check for overflow in size
5521 calculations. Don't update size until allocation succeeds.
5522 Redo calculations to avoid overflow.
5523 * keyboard.h: Change prototypes to match the above.
5525 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5527 (current_minor_maps): Check for size calculation overflow.
5528 * keymap.h: Change prototypes to match the above.
5530 * lread.c (read1, init_obarray): Don't update size until alloc done.
5532 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5533 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5535 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5536 Now ptrdiff_t, not int.
5537 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5538 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5540 * process.c (Fnetwork_interface_list): Check for overflow
5541 in size calculation.
5543 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5545 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5546 overflow. Don't bother calling xmalloc when xrealloc will do.
5548 * search.c (Freplace_match): Check for size calculation overflow.
5549 (Fset_match_data): Don't assume list lengths fit in 'int'.
5551 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5552 for command line length. Do not attempt to address one before the
5553 beginning of an array, as that's not portable.
5555 * term.c (max_frame_lines): Remove; unused.
5556 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5558 (encode_terminal_code, calculate_costs): Check for size
5559 calculation overflow.
5560 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5561 table lengths and related sizes. Don't update size until alloc
5562 done. Redo calculations to avoid overflow.
5563 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5565 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5566 subtracting pointers.
5567 (gobble_line): Check for overflow more carefully. Don't update size
5570 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5571 Don't update size until alloc done.
5572 Redo size calculations to avoid overflow.
5573 Check for size calculation overflow.
5574 (main) [DEBUG]: Fix typo in invoking tparam1.
5576 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5577 Use ptrdiff_t, not int, for sizes.
5578 (store_mode_line_noprop_char): Don't update size until alloc done.
5580 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5581 Use ptrdiff_t, not int, for sizes.
5582 (Finternal_make_lisp_face, cache_face):
5583 Check for size calculation overflow.
5584 (cache_face): Treat size calculation overflows as if they were
5585 memory exhaustion (the usual treatment), rather than aborting.
5587 * xfns.c (x_encode_text, x_set_name_internal)
5588 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5589 sizes, since they can exceed INT_MAX in size. Check for size
5590 calculation overflow.
5592 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5593 (xg_select): Check for size calculation overflow.
5594 Don't update size until alloc done.
5596 * xrdb.c (get_environ_db): Don't assume path length fits in int,
5597 as sprintf is limited to int lengths.
5599 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5600 (X_LONG_MIN): New macros.
5601 Use them to make the following changes clearer.
5602 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5603 This change doesn't affect the value now, but it may help remind
5604 future maintainers not to raise the value too much later.
5605 (SELECTION_QUANTUM): Remove, replacing with ...
5606 (selection_quantum): ... new function, which avoids overflow.
5608 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5609 assumption that selection length fits in 'int'.
5610 (x_reply_selection_request, x_handle_selection_request)
5611 (x_get_window_property, receive_incremental_selection)
5612 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5613 (lisp_data_to_selection_data, clean_local_selection_data):
5614 Use ptrdiff_t, not int, to record length of selection.
5615 (x_reply_selection_request, x_get_window_property)
5616 (receive_incremental_selection, x_property_data_to_lisp):
5617 Redo calculations to avoid overflow.
5618 (x_reply_selection_request): When sending hint, ceiling it at
5619 X_LONG_MAX rather than relying on wraparound overflow to send
5621 (x_get_window_property, receive_incremental_selection)
5622 (lisp_data_to_selection_data, x_property_data_to_lisp):
5623 Check for size-calculation overflow.
5624 (x_get_window_property, receive_incremental_selection)
5625 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5626 Don't store size until memory allocation succeeds.
5627 (x_get_window_property): Plug memory leak on memory exhaustion.
5628 Don't double-block input; malloc is safe here. Don't assume 2**34
5629 - 4 fits in unsigned long. Add an xassert to check
5630 XGetWindowProperty overflow. Be more careful about overflow
5631 calculations, and distinguish size from memory overflow better.
5632 (receive_incremental_selection): When tracing, don't assume
5633 unsigned int is less than INT_MAX.
5634 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5635 harmful) conversions of unsigned short to int.
5636 (lisp_data_to_selection_data): Don't assume that integers
5637 in the range -65535 through -1 fit in an X unsigned short.
5638 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5639 result parameters unless successful. Rely on cons_to_unsigned
5640 to report problems with elements; the old code wasn't right anyway.
5641 (x_check_property_data): Check for int overflow; we cannot use
5642 a wider type due to X limits.
5643 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5645 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
5647 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5648 (x_term_init): Check for size calculation overflow.
5649 (x_color_cells): Don't store size until memory allocation succeeds.
5650 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
5651 Don't assume alloca size is less than MAX_ALLOCA.
5652 (x_term_init): Don't assume length fits in int (sprintf is limited
5655 Use ptrdiff_t for composition IDs.
5656 * character.c (lisp_string_width):
5657 * composite.c (composition_table_size, n_compositions)
5658 (get_composition_id, composition_gstring_from_id):
5659 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5660 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5661 * window.c (Frecenter):
5662 Use ptrdiff_t, not int, for composition IDs.
5663 * composite.c (get_composition_id): Check for integer overflow.
5664 * composite.h: Adjust prototypes to match the above changes.
5666 Use ptrdiff_t for hash table indexes.
5667 * category.c (hash_get_category_set):
5668 * ccl.c (ccl_driver):
5669 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5670 * coding.c (coding_system_charset_list, detect_coding_system):
5671 * coding.h (struct coding_system.id):
5672 * composite.c (get_composition_id, gstring_lookup_cache):
5673 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5674 * image.c (xpm_get_color_table_h):
5675 * lisp.h (hash_lookup, hash_put):
5676 * minibuf.c (Ftest_completion):
5677 Use ptrdiff_t for hash table indexes, not int (which is too
5678 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5679 32-bit --with-wide-int hosts).
5681 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5682 Add a FIXME comment about memory leaks.
5683 (syms_of_charset): Don't assume xmalloc returns.
5685 Don't assume that stated character widths fit in int.
5686 * character.c (Fchar_width, c_string_width, lisp_string_width):
5687 * character.h (CHAR_WIDTH):
5688 * indent.c (MULTIBYTE_BYTES_WIDTH):
5689 Use sanitize_char_width to avoid undefined and/or bad behavior
5690 with outlandish widths.
5691 * character.h (sanitize_tab_width): Rename from sanitize_width,
5692 now that we have two such functions. All uses changed.
5693 (sanitize_char_width): New inline function.
5695 Don't assume that tab-width fits in int.
5696 * character.h (sanitize_width): New inline function.
5697 (SANE_TAB_WIDTH): New macro.
5698 (ASCII_CHAR_WIDTH): Use it.
5699 * indent.c (sane_tab_width): Remove. All uses replaced by
5700 SANE_TAB_WIDTH (current_buffer).
5701 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5703 * fileio.c: Integer overflow issues with file modes.
5704 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5706 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5707 Remove unreachable code.
5708 (read_hex, load_charset_map_from_file): Check for integer overflow.
5710 * xterm.c: Don't go over XClientMessageEvent limit.
5711 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5712 (x_send_scroll_bar_event): Likewise. Check that the size does not
5713 exceed limits imposed by XClientMessageEvent, as well as the usual
5714 ptrdiff_t and size_t limits.
5716 * keyboard.c: Overflow, signedness and related fixes.
5717 (make_lispy_movement): Use same integer type in forward decl
5718 that is used in the definition.
5719 (read_key_sequence, keyremap_step):
5720 Change bufsize argument back to int, undoing my 2011-03-30 change.
5721 We prefer signed types, and int is wide enough here.
5722 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5723 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5724 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5725 length, not size_t. Use ptrdiff_t for index, not int.
5726 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5727 possibility of integer overflow.
5729 Overflow, signedness and related fixes for images.
5731 * dispextern.h (struct it.stack[0].u.image.image_id)
5732 (struct_it.image_id, struct image.id, struct image_cache.size)
5733 (struct image_cache.used, struct image_cache.ref_count):
5734 * gtkutil.c (update_frame_tool_bar):
5735 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5736 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5737 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5738 * nsmenu.m (update_frame_tool_bar):
5739 * xdisp.c (calc_pixel_width_or_height):
5740 * xfns.c (image_cache_refcount):
5741 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5742 on typical 64-bit hosts.
5744 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5745 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5746 Omit unnecessary casts to int.
5747 (parse_image_spec): Check that integers fall into 'int' range
5748 when the callers expect that.
5749 (image_ascent): Redo ascent calculation to avoid int overflow.
5750 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5751 (lookup_image): Remove unnecessary tests.
5752 (xbm_image_p): Locals are now of int, not EMACS_INT,
5753 since parse_image_check makes sure they fit into int.
5754 (png_load, gif_load, svg_load_image):
5755 Prefer int to unsigned where either will do.
5756 (tiff_handler): New function, combining the cores of the
5757 old tiff_error_handler and tiff_warning_handler.
5758 This function is rewritten to use vsnprintf and thereby avoid
5759 stack buffer overflows. It uses only the features of vsnprintf
5760 that are common to both POSIX and native Microsoft.
5761 (tiff_error_handler, tiff_warning_handler): Use it.
5762 (tiff_load, gif_load, imagemagick_load_image):
5763 Don't assume :index value fits in 'int'.
5764 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5765 (imagemagick_load_image): Check that crop parameters fit into
5766 the integer types that MagickCropImage accepts. Don't assume
5767 Vimagemagick_render_type has a nonnegative value. Don't assume
5768 size_t fits in 'long'.
5769 (gs_load): Use printmax_t to print the widest integers possible.
5770 Check for integer overflow when computing image height and width.
5772 2011-08-26 Eli Zaretskii <eliz@gnu.org>
5774 * xdisp.c (redisplay_window): Don't force window start if point
5775 will be invisible in the resulting window. (Bug#9324)
5777 2011-08-25 Eli Zaretskii <eliz@gnu.org>
5779 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5780 the display spec is of the form `(space ...)'.
5781 (handle_display_spec): Return the value returned by
5782 handle_single_display_spec, not just 1 or zero.
5783 (handle_single_display_spec): If the display spec is of the form
5784 `(space ...)', and specifies display in the text area, return 2
5786 (try_cursor_movement): Check for the need to scroll more
5787 accurately, and prefer exact match for point under bidi.
5788 Don't advance `row' beyond the last row of the window.
5790 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5791 into disp_prop; all users changed.
5793 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5794 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5795 for the text covered by the display property.
5797 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
5799 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5800 Change return value to nil.
5801 (Frecord_buffer): Delete unused function.
5803 2011-08-24 Eli Zaretskii <eliz@gnu.org>
5805 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5806 buffers, return left-to-right.
5807 (set_cursor_from_row): Consider candidate row a win if its glyph
5808 represents a newline and point is on that newline. Fixes cursor
5809 positioning on the newline at EOL of R2L text within L2R
5810 paragraph, and vice versa.
5811 (try_cursor_movement): Check continued rows, in addition to
5812 continuation rows. Fixes unwarranted scroll when point enters a
5813 continued line of R2L text within an L2R paragraph, or vice versa.
5814 (cursor_row_p): Consider the case of point being equal to
5815 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5816 from the end of a short line to the beginning of a continued line
5817 of R2L text within L2R paragraph.
5818 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5819 composed characters.
5821 * bidi.c (bidi_check_type): Use xassert.
5822 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5825 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5827 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5830 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5832 * nsfont.m (ns_otf_to_script): Fix typo.
5834 2011-08-22 Kenichi Handa <handa@m17n.org>
5836 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5837 extra slot even if the purpose is char-code-property-table.
5839 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5841 * xdisp.c (redisplay_window): When computing centering_position,
5842 account for the height of the header line. (Bug#8874)
5844 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5845 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5846 candidate is selected by the mouse, and that candidate has a
5847 composed character under the mouse.
5849 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5850 coordinates reported by pos-visible-in-window-p for a composed
5851 character in column zero.
5853 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5855 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5857 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5859 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5860 consider it a hit if to_charpos is anywhere in the range of the
5861 composed buffer positions.
5863 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5865 * image.c (gif_load): Don't assume that each subimage has the same
5866 dimensions as the base image. Handle disposal method that is
5867 "undefined" by the gif spec (Bug#9335).
5869 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5871 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5872 (Fcondition_case): Document `debug' symbol in error handler.
5874 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5876 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5877 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5878 from an Org mode buffer to a Speedbar frame.
5880 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5881 a composition, take its buffer position from IT->cmp_it.charpos.
5882 Fixes cursor positioning at the beginning of a line that begins
5883 with a composed character.
5885 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5887 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5888 character bidirectional type, use STRONG_L instead. Fixes crashes
5889 in a buffer produced by `describe-categories'.
5891 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5892 members before the level stack, so they would be saved and
5893 restored when copying iterator state. Fixes incorrect reordering
5894 around TABs covered by display properties.
5896 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5898 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5900 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5902 * eval.c (internal_condition_case, internal_condition_case_1)
5903 (internal_condition_case_2, internal_condition_case_n):
5904 Remove unnecessary aborts (Bug#9081).
5906 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5908 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5909 has no `load' handler, try opening the file locally. (Bug#9311)
5911 2011-08-16 Ken Brown <kbrown@cornell.edu>
5913 * gmalloc.c: Expand comment.
5915 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5917 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5918 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5920 2011-08-16 Ken Brown <kbrown@cornell.edu>
5922 Fix memory allocation problems in Cygwin build (Bug#9273).
5924 * unexcw.c ( __malloc_initialized): Declare external variable.
5925 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5927 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5929 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5931 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5933 [CYGWIN] (special_realloc): New function.
5934 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5935 requests to realloc storage in the static heap.
5937 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5939 * bidi.c (bidi_initialize): Remove unused local.
5941 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5944 * biditype.h: Remove file.
5945 * makefile.w32-in ($(BLD)/bidi.$(O)):
5946 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5948 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5950 * chartab.c: Improve commentary for the uniprop_table API.
5952 * bidi.c (bidi_paragraph_init): Support zero value of
5953 bidi_ignore_explicit_marks_for_paragraph_level.
5954 (bidi_initialize): Use uniprop_table instead of including
5955 biditype.h and bidimirror.h.
5957 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5958 coordinates of the iterator when restoring from ppos_it.
5961 2011-08-14 Kenichi Handa <handa@m17n.org>
5963 * process.c (create_process): Call setup_process_coding_systems
5964 after the pid of the process is set to -1 (Bug#8162).
5966 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5968 * xdisp.c (move_it_in_display_line_to): Don't invoke
5969 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5970 ppos_it. Fixes vertical cursor motion when line beginning is
5971 covered by an image. (Bug#9296)
5973 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5975 * nsterm.h (ns_run_ascript): Declare.
5976 (NSAPP_DATA2_RUNASSCRIPT): Define.
5978 * nsfns.m (as_script, as_result, as_status): New static variables.
5979 (ns_run_ascript): New function.
5980 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5981 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5982 the event loop. Get status from as_status (Bug#7276).
5984 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5985 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5986 the event loop (Bug#7276).
5988 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5990 * gnutls.c (QCgnutls_bootprop_priority)
5991 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5992 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5993 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5994 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5995 (QCgnutls_bootprop_verify_hostname_error)
5996 (QCgnutls_bootprop_callbacks_verify): Rename from
5997 Qgnutls_bootprop_..., all uses changed.
5999 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6002 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6004 * xfaces.c (Qframe_set_background_mode): Now static.
6005 * dispextern.h (Qframe_set_background_mode): Remove decl.
6007 * process.c (Fnetwork_interface_info): Declare local only if needed.
6009 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6011 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6012 (Fnetwork_interface_list): Allocate in increments of bytes instead
6013 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6014 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6016 (struct ifflag_def): notrailers is smart on OSX.
6017 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6018 Get hardware address with getifaddrs if available.
6020 2011-08-12 Eli Zaretskii <eliz@gnu.org>
6022 * xdisp.c (iterate_out_of_display_property): xassert that
6023 IT->position is set to within IT->object's boundaries. Break from
6024 the loop as soon as EOB is reached; avoids infloops in redisplay
6025 when IT->position is set up wrongly due to some bug.
6026 Set IT->current to match the bidi iterator unconditionally.
6027 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6028 entry. Force push_it to save on the stack the current
6029 buffer/string position, to be restored by pop_it. Fix flags in
6030 the iterator structure wrt the object coming from a display
6031 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6032 properties. (Bug#9284)
6034 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6036 * fontset.c (fontset_get_font_group): Add proper type checks.
6039 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6041 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6042 and LC_VERSION_MIN_MACOSX.
6043 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6044 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6046 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6048 * xdisp.c (forward_to_next_line_start): Allow to use the
6049 no-display-properties-and-no-overlays under bidi display.
6050 Set disp_pos in the bidi iterator to avoid searches for display
6051 properties and overlays.
6053 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6055 * editfns.c (Fset_time_zone_rule): Document relationship with the
6058 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6059 the font entity extracted from the cache (Bug#8109).
6061 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6063 * composite.c (autocmp_chars): Don't reset point. That is done by
6064 restore_point_unwind (Bug#5984).
6066 2011-08-07 Juri Linkov <juri@jurta.org>
6068 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6069 to show the arg `TIME' instead of `TIMEVAL'.
6071 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6073 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6074 display property strides EOL and includes a newline, as in
6075 longlines-mode. (Bug#9254)
6076 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6077 word-wrap under bidirectional display. (Bug#9224)
6079 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6080 is non-zero, even if the data buffer is NULL. Fixes a crash in
6081 vertical-motion with longlines-mode. (Bug#9254)
6083 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6085 * bidi.c <bidi_cache_total_alloc>: Now static.
6086 (bidi_initialize): Initialize bidi_cache_total_alloc.
6088 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6091 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6092 amount allocated this far in `bidi_cache_total_alloc'.
6093 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6094 non-zero, only free the data buffer without restoring the cache
6095 contents. All callers changed.
6097 * dispextern.h (bidi_unshelve_cache): Update prototype.
6099 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6100 (move_it_in_display_line, move_it_to)
6101 (move_it_vertically_backward, move_it_by_lines): Replace the call
6102 to xfree to an equivalent call to bidi_unshelve_cache.
6103 (move_it_in_display_line_to): Fix logic of returning
6104 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6106 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6108 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6109 came from a string character with a `cursor' property. (Bug#9229)
6111 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6113 * Makefile.in (LIB_PTHREAD): New variable.
6114 (LIBES): Add LIB_PTHREAD (Bug#9216).
6116 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6117 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6119 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6121 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6123 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6125 * xterm.c (x_find_topmost_parent): New function.
6126 (x_set_frame_alpha): Find topmost parent window with
6127 x_find_topmost_parent and set the property there also (bug#9181).
6128 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6130 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6132 * callproc.c (Fcall_process): Avoid vfork clobbering
6133 the local vars buffer, coding_systems, current_dir.
6135 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6137 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6139 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6141 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6142 so that it is not optimized away.
6144 * xdisp.c (compute_display_string_pos): Remove unused local.
6146 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6148 Fix slow cursor motion and scrolling in large buffers with
6149 selective display, like Org Mode buffers. (Bug#9218)
6151 * dispextern.h (struct bidi_it): New member disp_prop_p.
6153 * xdisp.c: Remove one-slot cache of display string positions.
6154 (compute_display_string_pos): Accept an additional argument
6155 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6156 for a display string or property. If found, set DISP_PROP_P
6159 * bidi.c (bidi_fetch_char): Accept an additional argument
6160 DISP_PROP_P, and pass it to compute_display_string_pos.
6161 Only handle text covered by a display string if DISP_PROP_P is returned
6162 non-zero. All callers of bidi_fetch_char changed.
6164 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6166 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6168 2010-12-03 Don March <don@ohspite.net>
6170 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6171 last character M-[char] is translated to ESC [char] (bug#7541).
6173 2011-08-02 Kenichi Handa <handa@m17n.org>
6175 * lisp.h (uniprop_table): Extern it.
6177 * chartab.c (uniprop_table): Make it non-static.
6179 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6181 * xdisp.c (forward_to_next_line_start): Accept additional argument
6182 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6184 (reseat_at_next_visible_line_start): Use the bidi iterator state
6185 returned by forward_to_next_line_start to restore the state of
6186 it->bidi_it after backing up to previous newline. (Bug#9212)
6188 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6190 * regex.c (re_comp): Protoize.
6191 (re_exec): Fix return type.
6192 (regexec): Fix type of `ret'. (Bug#9203)
6194 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6196 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6197 This is needed if max-image-size is a floating-point number.
6199 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6201 * print.c (print_object): Print empty symbol as ##.
6203 * lread.c (read1): Read ## as empty symbol.
6205 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6207 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6208 setting frame foreground color (Bug#9175).
6209 (x_set_background_color): Likewise.
6211 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6212 contents (Bug#9176).
6213 (EmacsTooltip -init): Remove bezels and add shadows to
6216 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6217 or scroll bar (Bug#8470).
6219 * nsfont.m (nsfont_open): Remove assignment to voffset and
6220 unnecessary vars hshink, expand, hd, full_height, min_height.
6221 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6223 * nsterm.h (nsfont_info): Remove voffset field.
6225 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6227 Implement strike-through and overline on NextStep (Bug#8863).
6229 * nsfont.m (nsfont_open): Use underline position provided by font,
6230 instead of hard-coded value of 2.
6231 (nsfont_draw): Call ns_draw_text_decoration instead.
6233 * nsterm.h: Add declaration for ns_draw_text_decoration.
6235 * nsterm.m (ns_draw_text_decoration): New function for drawing
6236 underline, overline, and strike-through.
6237 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6238 ns_draw_text_decoration. Change treatment of cursor drawing to
6239 accommodate underlining, etc.
6241 2011-07-28 Eli Zaretskii <eliz@gnu.org>
6243 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6246 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6248 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6249 Without this fix, if a signal arrives just after memory fills up,
6250 'malloc' might be invoked reentrantly.
6252 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6253 In other words, assume that every image size is allowed, on non-X
6254 hosts. This assumption is probably wrong, but it lets Emacs compile.
6256 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6258 * regex.c (re_iswctype): Convert return values to boolean.
6260 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6262 * xdisp.c (compute_display_string_pos): Don't use cached display
6263 string position if the buffer had its restriction changed.
6266 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6268 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6270 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6272 Integer signedness and overflow and related fixes. (Bug#9079)
6274 * bidi.c: Integer size and overflow fixes.
6275 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6276 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6277 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6278 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6279 (bidi_find_other_level_edge):
6280 Use ptrdiff_t instead of EMACS_INT where either will do.
6281 This works better on 32-bit hosts configured --with-wide-int.
6282 (bidi_cache_ensure_space): Check for size-calculation overflow.
6283 Use % rather than repeated addition, for better worst-case speed.
6284 Don't set bidi_cache_size until after xrealloc returns, because it
6286 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
6287 (bidi_cache_ensure_space): Also check that the bidi cache size
6288 does not exceed that of the largest Lisp string or buffer. See Eli
6289 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
6291 * alloc.c (__malloc_size_t): Remove.
6292 All uses replaced by size_t. See Andreas Schwab's note
6293 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6295 * image.c: Improve checking for integer overflow.
6296 (check_image_size): Assume that f is nonnull, since
6297 it is always nonnull in practice. This is one less thing to
6298 worry about when checking for integer overflow later.
6299 (x_check_image_size): New function, which checks for integer
6300 overflow issues inside X.
6301 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6302 This removes the need for a memory_full check.
6303 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6304 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6305 (xbm_read_bitmap_data): Change locals back to 'int', since
6306 their values must fit in 'int'.
6307 (xpm_load_image, png_load, tiff_load):
6308 Invoke x_create_x_image_and_pixmap earlier,
6309 to avoid much needless work if the image is too large.
6310 (tiff_load): Treat overly large images as if
6311 x_create_x_image_and_pixmap failed, not as malloc failures.
6312 (gs_load): Use x_check_image_size.
6314 * gtkutil.c: Omit integer casts.
6315 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6316 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6318 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6320 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6321 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6322 would wrongly return t on a 64-bit host.
6324 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6325 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6326 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6327 and therefore cause GCC to emit a bogus diagnostic in some cases.
6329 * image.c: Integer signedness and overflow and related fixes.
6330 This is not an exhaustive set of fixes, but it's time to
6331 record what I've got.
6332 (lookup_pixel_color, check_image_size): Remove redundant decls.
6333 (check_image_size): Don't assume that arbitrary EMACS_INT values
6334 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6335 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6336 (tiff_load, imagemagick_load_image):
6337 Check for overflow in size calculations.
6338 (x_create_x_image_and_pixmap): Remove unnecessary test for
6339 xmalloc returning NULL; that can't happen.
6340 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6341 (xpm_color_bucket): Use better integer hashing function.
6342 (xpm_cache_color): Don't possibly over-allocate memory.
6343 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6344 (gif_memory_source):
6345 Use ptrdiff_t, not int or size_t, to record sizes.
6346 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6347 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6348 either works, as we prefer signed integers.
6349 (tiff_read_from_memory, tiff_write_from_memory):
6350 Return tsize_t, not size_t, since that's what the TIFF API wants.
6351 (tiff_read_from_memory): Don't fail simply because the read would
6352 go past EOF; instead, return a short read.
6353 (tiff_load): Omit no-longer-needed casts.
6354 (Fimagemagick_types): Don't assume size fits into 'int'.
6356 Improve hashing quality when configured --with-wide-int.
6357 * fns.c (hash_string): New function, taken from sxhash_string.
6358 Do not discard information about ASCII character case; this
6359 discarding is no longer needed.
6360 (sxhash-string): Use it. Change sig to match it. Caller changed.
6361 * lisp.h: Declare it.
6362 * lread.c (hash_string): Remove, since we now use fns.c's version.
6363 The fns.c version returns a wider integer if --with-wide-int is
6364 specified, so this should help the quality of the hashing a bit.
6366 * emacs.c: Integer overflow minor fix.
6367 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6368 Define only if GNU_LINUX.
6369 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6371 * dispnew.c: Integer signedness and overflow fixes.
6372 Remove unnecessary forward decls, that were a maintenance hassle.
6373 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6375 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6376 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6377 (prepare_desired_row, line_draw_cost):
6378 Use int, not unsigned, where either works.
6379 (save_current_matrix, restore_current_matrix):
6380 Use ptrdiff_t, not size_t, where either works.
6381 (init_display): Check for overflow more accurately, and without
6382 relying on undefined behavior.
6384 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6385 Remove, replacing with the new symbols in lisp.h. All uses changed.
6386 * fileio.c (make_temp_name):
6387 * filelock.c (lock_file_1, lock_file):
6388 * xdisp.c (message_dolog):
6389 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6390 Use pMd etc. instead.
6391 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6392 replacing the pWIDE etc. symbols removed from editfns.c.
6394 * keyboard.h (num_input_events): Now uintmax_t.
6395 This is (very slightly) less likely to mess up due to wraparound.
6398 * buffer.c: Integer signedness fixes.
6399 (alloc_buffer_text, enlarge_buffer_text):
6400 Use ptrdiff_t rather than size_t when either will do, as we prefer
6403 * alloc.c: Integer signedness and overflow fixes.
6404 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6405 (__malloc_size_t): Default to size_t, not to int.
6406 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6407 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6408 Prefer ptrdiff_t to size_t when either would do, as we prefer
6410 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6411 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6412 Now const. Initialize with values that are in range even if char
6414 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6415 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6416 These functions do the right thing with sizes > 2**32.
6417 (check_depth): Now ptrdiff_t, not int.
6418 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6419 Adjust to new way of storing sizes. Check for size overflow bugs
6421 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6422 slightly wrong anyway, as it missed one instance of
6423 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6424 (refill_memory_reserve): Omit needless cast to size_t.
6425 (mark_object_loop_halt): Mark as externally visible.
6427 * xselect.c: Integer signedness and overflow fixes.
6428 (Fx_register_dnd_atom, x_handle_dnd_message):
6429 Use ptrdiff_t, not size_t, since we prefer signed.
6430 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6431 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6432 x_dnd_atoms_size and x_dnd_atoms_length.
6434 * doprnt.c: Prefer signed to unsigned when either works.
6436 * doprnt.c (doprnt):
6438 * xdisp.c (vmessage):
6439 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6440 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6441 prefer signed arithmetic to avoid comparison confusion.
6442 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6443 but is a bit tricky.
6445 Assume freestanding C89 headers, string.h, stdlib.h.
6446 * data.c, doprnt.c, floatfns.c, print.c:
6447 Include float.h unconditionally.
6448 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6449 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6450 * regex.c: Likewise for stddef.h, string.h.
6451 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6452 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6453 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6454 (STDC_HEADERS): Remove obsolete defines.
6455 * sysdep.c: Include limits.h unconditionally.
6457 Assume support for memcmp, memcpy, memmove, memset.
6458 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6459 * regex.c (memcmp, memcpy):
6460 Remove; we assume C89 now.
6462 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6463 (__malloc_safe_bcopy): Remove; no longer needed.
6465 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6466 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6467 well either way, and we prefer signed to unsigned.
6469 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6471 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6472 closes the connection while we're reading (bug#9182).
6474 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
6476 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6477 are specified (Bug#9168).
6479 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6481 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6482 Found by GCC static checking and --with-wide-int on a 32-bit host.
6484 2011-07-25 Eli Zaretskii <eliz@gnu.org>
6486 * xdisp.c (compute_display_string_pos): Fix logic of caching
6487 previous display string position. Initialize cached_prev_pos to
6488 -1. Fixes slow-down at the beginning of a buffer.
6490 2011-07-24 Eli Zaretskii <eliz@gnu.org>
6492 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6493 for attrs[LFACE_FONTSET_INDEX].
6495 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6497 * xml.c (parse_region): Remove unused local
6498 that was recently introduced.
6500 2011-07-23 Eli Zaretskii <eliz@gnu.org>
6502 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6503 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6505 * xdisp.c (move_it_in_display_line_to): Record the best matching
6506 position for TO_CHARPOS while scanning the line, and restore it on
6507 exit if none of the characters scanned was an exact match.
6508 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
6509 when exact match is impossible due to invisible text, and the
6510 lines are truncated.
6512 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6514 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6517 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6519 Fix a significant slow-down of cursor motion with C-n, C-p,
6520 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6521 auto-repeat under bidi redisplay in fontified buffers.
6522 * xdisp.c (compute_stop_pos_backwards): New function.
6523 (next_element_from_buffer): Call compute_stop_pos_backwards to
6524 find a suitable prev_stop when we find ourselves before
6526 (reseat): Don't look for prev_stop, as that could mean a very long
6528 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6529 <cached_disp_overlay_modiff>: Cache for last found display string
6531 (compute_display_string_pos): Return the cached position if asked
6532 about the same buffer in the same area of character positions, and
6533 the buffer wasn't changed since the time the display string
6534 position was cached.
6536 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6538 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6539 is an integer, which is important for empty lines. (Bug#9149)
6541 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
6543 * frame.c (Fmodify_frame_parameters): In tty case, update the
6544 default face if necessary (Bug#4238).
6546 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
6548 * editfns.c (Fstring_to_char): No need to explain what a character
6549 is in the docstring (Bug#6576).
6551 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6553 * xml.c (parse_region): Make sure we always return a tree.
6555 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6557 * xml.c (parse_region): If a document contains only comments,
6560 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6562 * xml.c (make_dom): Return comments, too.
6564 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6567 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6568 and the surrounding thread.
6569 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6570 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6571 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6573 * s/openbsd.h (BROKEN_SIGIO): Define.
6574 * unexelf.c (unexec) [__OpenBSD__]:
6575 Don't update the .mdebug section of the Alpha COFF symbol table.
6577 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6579 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6582 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6584 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6585 This fixes some race conditions on the permissions of any newly
6588 * alloc.c (valid_pointer_p): Use pipe, not open.
6589 This fixes some permissions issues when debugging.
6591 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6592 If fchown fails to set both uid and gid, try to set just gid,
6593 as that is sometimes allowed. Adjust the file's mode to eliminate
6594 setuid or setgid bits that are inappropriate if fchown fails.
6596 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6598 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6599 to compare Lisp_Objects.
6600 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6601 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6602 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6604 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6606 * lread.c (read_integer): Unread even EOF character.
6607 (read1): Likewise. Properly record start position of symbol.
6609 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6610 symbol character follows.
6612 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6614 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6615 This works around a problem with the previous change to Fcopy_file.
6616 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6617 and without this change, GCC might complain about discarding
6618 fchown's return value.
6620 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
6622 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6624 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6626 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6628 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6630 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6631 it's used from the C level.
6633 * process.c: Use the same condition for POLL_FOR_INPUT in both
6634 keyboard.c and process.c (bug#1858).
6636 2011-07-09 Lawrence Mitchell <wence@gmx.li>
6638 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6639 (Fgnutls_boot): Use it.
6641 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6643 * doc.c (Fsubstitute_command_keys): Revert last change.
6645 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6647 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6648 quotes the next character, and doesn't affect other longer
6649 sequences (bug#8935).
6651 * lread.c (syms_of_lread): Clarify that is isn't only
6652 `eval-buffer' and `eval-defun' that's affected by
6653 `lexical-binding' (bug#8460).
6655 2011-07-15 Eli Zaretskii <eliz@gnu.org>
6657 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6658 bidi redisplay when a line includes both an image and is truncated.
6660 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6662 Fix minor problems found by static checking.
6663 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6664 (elsz): Now a signed constant, not a size_t var. We prefer signed
6665 types to unsigned, to avoid integer comparison confusion. Without
6666 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6667 "cannot optimize loop, the loop counter may overflow", a symptom
6669 * indent.c (Fvertical_motion): Mark locals as initialized.
6670 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6672 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6674 * search.c (Fre_search_backward): Mention `case-fold-search' in
6675 all the re_search_* functions (bug#8138).
6677 * keyboard.c (Fopen_dribble_file): Document when the file is
6680 2011-07-14 Eli Zaretskii <eliz@gnu.org>
6682 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6685 Support bidi reordering of display and overlay strings.
6686 * xdisp.c (compute_display_string_pos)
6687 (compute_display_string_end): Accept additional argument STRING.
6688 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6689 (reseat_to_string): Initialize bidi_it->string.s and
6690 bidi_it->string.schars.
6691 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
6692 NULL (avoids a crash in bidi_paragraph_init).
6693 Initialize itb.string.lstring.
6694 (init_iterator): Call bidi_init_it only of a valid
6695 buffer position was specified. Initialize paragraph_embedding to
6697 (reseat_to_string): Initialize the bidi iterator.
6698 (display_string): If we need to ignore text properties of
6699 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6700 original value of -1 will not work with bidi.)
6701 (compute_display_string_pos): First arg is now struct
6702 `text_pos *'; all callers changed. Support display properties on
6704 (compute_display_string_end): Support display properties on Lisp
6706 (init_iterator, reseat_1, reseat_to_string): Initialize the
6707 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6708 when iterating on a string not from display properties).
6709 (compute_display_string_pos, compute_display_string_end):
6710 Fix calculation of the object to scan. Fixes an error when using
6712 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
6713 base_level_stop; instead, set base_level_stop to BEGV.
6714 Fixes crashes in vertical-motion.
6715 (next_element_from_buffer): Improve commentary for when
6716 the iterator is before prev_stop.
6717 (init_iterator): Initialize bidi_p from the default value of
6718 bidi-display-reordering, not from buffer-local value. Use the
6719 buffer-local value only if initializing for buffer iteration.
6720 (handle_invisible_prop): Support invisible properties on strings
6721 that are being bidi-reordered.
6722 (set_iterator_to_next): Support bidi reordering of C strings and
6724 (next_element_from_string): Support bidi reordering of Lisp
6726 (handle_stop_backwards): Support Lisp strings as well.
6727 (display_string): Support display of R2L glyph rows.
6728 Use IT_STRING_CHARPOS when displaying from a Lisp string.
6729 (init_iterator): Don't initialize it->bidi_p for strings
6731 (reseat_to_string): Initialize it->bidi_p for strings here.
6732 (next_element_from_string, next_element_from_c_string)
6733 (next_element_from_buffer): Add xassert's for correspondence
6734 between IT's object being iterated and it->bidi_it.string
6736 (face_before_or_after_it_pos): Support bidi iteration.
6737 (next_element_from_c_string): Handle the case of the first string
6738 character that is not the first one in the visual order.
6739 (get_visually_first_element): New function, refactored from common
6740 parts of next_element_from_buffer, next_element_from_string, and
6741 next_element_from_c_string.
6742 (tool_bar_lines_needed, redisplay_tool_bar)
6743 (display_menu_bar): Force left-to-right direction. Add a FIXME
6744 comment for making that be controlled by a user option.
6745 (push_it, pop_it): Save and restore the state of the
6746 bidi iterator. Save and restore the bidi_p flag.
6747 (pop_it): Iterate out of display property for string iteration as
6749 (iterate_out_of_display_property): Support iteration over strings.
6750 (handle_single_display_spec): Set up it->bidi_it for iteration
6751 over a display string, and call bidi_init_it.
6752 (handle_single_display_spec, next_overlay_string)
6753 (get_overlay_strings_1, push_display_prop): Set up the bidi
6754 iterator for displaying display or overlay strings.
6755 (forward_to_next_line_start): Don't use the shortcut if
6757 (back_to_previous_visible_line_start): If handle_display_prop
6758 pushed the iterator stack, restore the internal state of the bidi
6759 iterator by calling bidi_pop_it same number of times.
6760 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6761 and we are bidi-iterating, don't decrement the iterator position;
6762 instead, set the first_elt flag in the bidi iterator, to produce
6764 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6765 (push_display_prop): xassert that we are iterating a buffer.
6766 (push_it, pop_it): Save and restore paragraph_embedding member.
6767 (handle_single_display_spec, next_overlay_string)
6768 (get_overlay_strings_1, reseat_1, reseat_to_string)
6769 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6770 correctly. Don't assume unibyte strings are not bidi-reordered.
6771 (compute_display_string_pos)
6772 (compute_display_string_end): Fix handling the case of C string.
6773 (push_it, pop_it): Save and restore from_disp_prop_p.
6774 (handle_single_display_spec, push_display_prop): Set the
6775 from_disp_prop_p flag.
6776 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6777 (pop_it): Call iterate_out_of_display_property only if we are
6778 popping after iteration over a string that came from a display
6779 property. Fix a typo in popping stretch info. Add an assertion
6780 for verifying that the iterator position is in sync with the bidi
6782 (handle_single_display_spec, get_overlay_strings_1)
6783 (push_display_prop): Fix initialization of paragraph direction for
6784 string when that of the parent object is not yet determined.
6785 (reseat_1): Call bidi_init_it to resync the bidi
6786 iterator with IT's position. (Bug#7616)
6787 (find_row_edges): If ROW->start.pos gives position
6788 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6789 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6790 Reset the from_disp_prop_p flag.
6791 (SAVE_IT, RESTORE_IT): New macros.
6792 (pos_visible_p, face_before_or_after_it_pos)
6793 (back_to_previous_visible_line_start)
6794 (move_it_in_display_line_to, move_it_in_display_line)
6795 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6796 (try_scrolling, redisplay_window, display_line): Use them when
6797 saving a temporary copy of the iterator and restoring it back.
6798 (back_to_previous_visible_line_start, reseat_1)
6799 (init_iterator): Empty the bidi cache "stack".
6800 (move_it_in_display_line_to): If iterator ended up at
6801 EOL, but we never saw any buffer positions smaller than
6802 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6803 motion in bidi-reordered lines.
6804 (move_it_in_display_line_to): Record prev_method and prev_pos
6805 immediately before the call to set_iterator_to_next. Fixes cursor
6806 motion in bidi-reordered lines with stretch glyphs and strings
6807 displayed in margins. (Bug#8133) (Bug#8867)
6808 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6810 (pos_visible_p): Support positions in bidi-reordered lines.
6811 Save and restore bidi cache.
6813 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6814 (bidi_paragraph_info): Delete unused struct.
6815 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6816 (bidi_cache_start): New variable.
6817 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6819 (bidi_cache_fetch_state, bidi_cache_search)
6820 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6821 (bidi_cache_find, bidi_peek_at_next_level)
6822 (bidi_level_of_next_char, bidi_find_other_level_edge)
6823 (bidi_move_to_visually_next): Compare cache index with
6824 bidi_cache_start rather than with zero.
6825 (bidi_fetch_char): Accept new argument STRING; all callers
6826 changed. Support iteration over a string. Support strings with
6827 display properties. Support unibyte strings. Fix the type of
6828 `len' according to what STRING_CHAR_AND_LENGTH expects.
6829 (bidi_paragraph_init, bidi_resolve_explicit_1)
6830 (bidi_resolve_explicit, bidi_resolve_weak)
6831 (bidi_level_of_next_char, bidi_move_to_visually_next):
6832 Support iteration over a string.
6833 (bidi_set_sor_type, bidi_resolve_explicit_1)
6834 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6835 can now be zero (for strings); special values 0 and -1 were
6836 changed to -1 and -2, respectively.
6837 (bidi_char_at_pos): New function.
6838 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6839 Call it instead of FETCH_MULTIBYTE_CHAR.
6840 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6841 initialized to valid values.
6842 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6844 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6845 the test for valid cached positions. Fix the logic for looking up
6846 the sentinel state in the cache. GCPRO the Lisp string we are
6848 (bidi_push_it, bidi_pop_it): New functions.
6849 (bidi_initialize): Initialize the bidi cache start stack pointer.
6850 (bidi_cache_ensure_space): New function, refactored from part of
6851 bidi_cache_iterator_state. Don't assume the required size is just
6852 one BIDI_CACHE_CHUNK away.
6853 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6854 (bidi_count_bytes, bidi_char_at_pos): New functions.
6855 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6856 always valid if bidi_cache_idx is valid.
6857 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6858 is valid if it's going to be used.
6859 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6860 (bidi_cache_fetch_state, bidi_cache_search)
6861 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6862 (bidi_cache_iterator_state, bidi_cache_find)
6863 (bidi_find_other_level_edge, bidi_cache_start_stack):
6864 All variables related to cache indices are now EMACS_INT.
6866 * dispextern.h (struct bidi_string_data): New structure.
6867 (struct bidi_it): New member `string'. Make flag members be 1-bit
6868 fields, and put them last in the struct.
6869 (compute_display_string_pos, compute_display_string_end):
6871 (bidi_push_it, bidi_pop_it): Add prototypes.
6872 (struct iterator_stack_entry): New members bidi_p,
6873 paragraph_embedding, and from_disp_prop_p.
6874 (struct it): Member bidi_p is now a bit field 1 bit wide.
6875 (bidi_shelve_cache, bidi_unshelve_cache):
6878 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6879 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6880 and vector-like objects.
6882 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6883 cache around display iteration.
6885 * window.c (Fwindow_end, window_scroll_pixel_based)
6886 (displayed_window_lines, Frecenter): Save and restore the bidi
6887 cache around display iteration.
6889 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6891 * editfns.c (Fdelete_region): Clarify the use of the named
6892 parameters (bug#6788).
6894 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6896 * indent.c (Fvertical_motion): Set and restore w->pointm when
6897 saving and restoring the window's buffer (Bug#9006).
6899 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6901 * editfns.c (Fstring_to_char): Clarify just what is returned
6902 (bug#6576). Text by Eli Zaretskii.
6904 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6906 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6908 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6910 * buffer.c (mmap_find): Fix a typo.
6912 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6914 Fix execution of x selection hooks.
6915 * xselect.c (Qx_lost_selection_functions)
6916 (Qx_sent_selection_functions): New vars.
6917 (syms_of_xselect): DEFSYM them.
6918 (x_handle_selection_request): Pass Qx_sent_selection_functions
6919 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6920 (x_handle_selection_clear,x_clear_frame_selections):
6921 Pass Qx_lost_selection_functions rather than
6922 Vx_lost_selection_functions to Frun_hook_with_args.
6924 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6926 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6927 The old code sometimes used this field without initializing it.
6929 * alloc.c (gc_sweep): Don't read past end of array.
6930 In theory, the old code could also have corrupted Emacs internals,
6931 though it'd be very unlikely.
6933 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6935 * character.c (Fcharacterp): Don't advertise optional ignored
6936 argument. (Bug#4026)
6938 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6940 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6943 * window.c (Fset_window_start): Doc fix (bug#4199).
6944 (Fset_window_hscroll): Ditto.
6946 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6948 Fix minor new problems caught by GCC 4.6.1.
6949 * term.c (init_tty): Remove unused local.
6950 * xsettings.c (store_monospaced_changed): Define this function only
6951 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6954 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6956 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6958 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6960 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6961 are the mini-buffer and the echo area (bug#3320).
6963 * term.c (init_tty): Remove support for supdup, c10 and perq
6964 terminals, which are no longer supported (bug#1482).
6966 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6968 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6970 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6972 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6973 for non-popups (Bug#3642).
6975 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6977 * alloc.c (reset_malloc_hooks): Protoize.
6978 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6979 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6980 * cm.c (losecursor): Likewise.
6981 * data.c (fmod): Likewise.
6982 * dispnew.c (swap_glyphs_in_rows): Likewise.
6983 * emacs.c (memory_warning_signal): Likewise.
6984 * floatfns.c (float_error): Likewise.
6985 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6986 (otf_open, font_otf_capability, generate_otf_features)
6987 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6989 * image.c (pbm_read_file): Likewise.
6990 * indent.c (string_display_width): Likewise.
6991 * intervals.c (check_for_interval, search_for_interval)
6992 (inc_interval_count, count_intervals, root_interval)
6993 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6994 * lread.c (defalias): Likewise.
6995 * ralloc.c (r_alloc_check): Likewise.
6996 * regex.c (set_image_of_range_1, set_image_of_range)
6997 (regex_grow_registers): Likewise.
6998 * sysdep.c (strerror): Likewise.
6999 * termcap.c (valid_filename_p, tprint, main): Likewise.
7000 * tparam.c (main): Likewise.
7001 * unexhp9k800.c (run_time_remap, save_data_space)
7002 (update_file_ptrs, read_header, write_header, calculate_checksum)
7003 (copy_file, copy_rest, display_header): Likewise.
7004 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7006 * xdisp.c (check_it): Likewise.
7007 * xfaces.c (register_color, unregister_color, unregister_colors):
7009 * xfns.c (print_fontset_result): Likewise.
7010 * xrdb.c (member, fatal, main): Likewise.
7012 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7014 Fix minor problems found by static checking (Bug#9031).
7015 * chartab.c (char_table_set_range, map_sub_char_table):
7016 Remove unused locals.
7017 (uniprop_table): Now static.
7018 * composite.c (_work_char): Remove unused static var.
7020 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
7022 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7024 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7026 * gtkutil.c (qttip_cb): Remove code without function.
7028 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7030 * w32.c (pthread_sigmask): New stub.
7032 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
7034 Use pthread_sigmask, not sigprocmask (Bug#9010).
7035 sigprocmask is portable only for single-threaded applications, and
7036 Emacs can be multi-threaded when it uses GTK.
7037 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7039 * callproc.c (Fcall_process):
7040 * process.c (create_process):
7041 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7042 Use pthread_sigmask, not sigprocmask.
7044 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7046 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7047 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7050 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7052 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7053 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7054 (xg_hide_tooltip): Fix comment.
7056 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7057 in registerServicesMenuSendTypes.
7058 (validRequestorForSendType): Don't check ns_return_types.
7060 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7063 2011-07-08 Jason Rumney <jasonr@gnu.org>
7065 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7066 SH_SHOW for hidden windows (Bug#5482).
7068 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7069 frame struct members of non-existent frames (Bug#6284).
7071 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7073 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7074 variable firstTime not needed on OSX >= 10.6.
7075 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7076 >= 10.5. Use setKnobProportion, setDoubleValue.
7078 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7079 (MAC_OS_X_VERSION_10_5): Define if not defined.
7080 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7081 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7082 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7084 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7085 cString and lossyCString on OSX >= 10.4
7087 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7088 sizeToFit on OSX >= 10.2.
7090 * nsimage.m (allocInitFromFile): Don't use deprecated method
7091 bestRepresentationForDevice on OSX >= 10.6.
7093 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7096 * emacs.c: Declare unexec_init_emacs_zone.
7098 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7100 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7102 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7103 on svcsMenu (Bug#8842).
7105 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7107 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7109 * nsterm.m (QUTF8_STRING): Declare.
7110 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7111 (validRequestorForSendType): Return type is (id).
7112 Change indexOfObjectIdenticalTo to indexOfObject.
7113 Check if we have local selection before returning self (Bug#8842).
7114 (writeSelectionToPasteboard): Put local selection into paste board
7115 if we have a local selection (Bug#8842).
7116 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7118 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7119 (ns_get_local_selection): Declare.
7121 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7123 * keymap.c (describe_map_tree): Don't insert a double newline at
7124 the end of the buffer (bug#1169) and return whether we inserted
7127 * callint.c (Fcall_interactively): Change "reading args" to
7128 "providing args" to try to clarify what it does (bug#1010).
7130 2011-07-07 Kenichi Handa <handa@m17n.org>
7132 * composite.c (composition_compute_stop_pos): Ignore a static
7133 composition starting before CHARPOS (Bug#8915).
7135 * xdisp.c (handle_composition_prop): Likewise.
7137 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7139 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7142 2011-07-07 Kenichi Handa <handa@m17n.org>
7144 * character.h (unicode_category_t): New enum type.
7146 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7147 (Qchar_code_property_table): New variable.
7148 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7149 (UNIPROP_COMPRESSED_FORM_P): New macros.
7150 (char_table_ascii): Uncompress the compressed values.
7151 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7152 Uncompress the compressed values.
7153 (sub_char_table_ref_and_range): Likewise.
7154 (char_table_ref_and_range): Uncompress the compressed values.
7155 (sub_char_table_set): New arg is_uniprop. Callers changed.
7156 Uncompress the compressed values.
7157 (sub_char_table_set_range): Args changed. Callers changed.
7158 (char_table_set_range): Adjuted for the above change.
7159 (map_sub_char_table): Delete args default_val and parent. Add arg
7160 top. Give decoded values to a Lisp function.
7161 (map_char_table): Adjust for the above change. Give decoded
7162 values to a Lisp function. Gcpro more variables.
7163 (uniprop_table_uncompress)
7164 (uniprop_decode_value_run_length): New functions.
7165 (uniprop_decoder, uniprop_decoder_count): New variables.
7166 (uniprop_get_decoder, uniprop_encode_value_character)
7167 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7169 (uniprop_encoder, uniprop_encoder_count): New variables.
7170 (uniprop_get_encoder, uniprop_table)
7171 (Funicode_property_table_internal, Fget_unicode_property_internal)
7172 (Fput_unicode_property_internal): New functions.
7173 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7174 Sunicode_property_table_internal, Sget_unicode_property_internal,
7175 and Sput_unicode_property_internal. Defvar_lisp
7176 char-code-property-alist.
7178 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7179 Vunicode_category_table.
7181 * font.c (font_range): Adjust for the change of
7182 Vunicode_category_table.
7184 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7186 * m/iris4d.h: Remove file, move contents ...
7187 * s/irix6-5.h: ... here.
7189 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7191 Remove unportable assumption about struct layout (Bug#8884).
7192 * alloc.c (mark_buffer):
7193 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7194 (clone_per_buffer_values): Don't assume that
7195 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7196 This isn't true in general, and it's particularly not true
7197 if Emacs is configured with --with-wide-int.
7198 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7199 New macros, used in the buffer.c change.
7201 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7203 * xsettings.c: Use both GConf and GSettings if both are available.
7204 (store_config_changed_event): Add comment.
7205 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7206 (store_tool_bar_style_changed): New functions.
7207 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7208 (struct xsettings): Move font inside HAVE_XFT.
7209 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7210 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7211 Move inside HAVE_XFT.
7212 (something_changed_gsettingsCB): Rename from something_changedCB.
7213 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7215 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7216 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7217 (something_changed_gconfCB): Rename from something_changedCB.
7218 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7219 (parse_settings): Move check for font inside HAVE_XFT.
7220 (read_settings, apply_xft_settings): Add comment.
7221 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7222 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7223 call store_font_name_changed.
7224 (xft_settings_event): Add comment.
7225 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7226 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7227 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7228 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7229 (xsettings_initialize): Call init_gsettings last.
7230 (xsettings_get_system_font, xsettings_get_system_normal_font):
7233 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7235 Random fixes. E.g., (random) never returned negative values.
7236 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7237 subseconds part to the entropy, as that's a bit more random.
7238 Prefer signed to unsigned, since the signedness doesn't matter and
7239 in general we prefer signed. When given a limit, use a
7240 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7241 latter isn't right if USE_2_TAGS_FOR_INTS.
7242 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7243 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7245 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7247 * textprop.c (text_property_stickiness):
7248 Obey Vtext_property_default_nonsticky.
7249 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7250 * w32fns.c (syms_of_w32fns):
7251 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7253 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7255 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7256 This is more efficient than Ffile_directory_p and avoids a minor race.
7258 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7260 * buffer.c (Foverlay_put): Say what the return value is
7263 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7264 is a directory before asking whether to use the file name
7266 (barf_or_query_if_file_exists): Make the "File is a directory"
7267 error be more correct.
7269 * fns.c (Frequire): Remove the mention of the .gz files, since
7270 that's installation-specific, but keep the mention of
7271 `get-load-suffixes'.
7273 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7275 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7276 Report string overflow if the output is too long.
7278 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
7280 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7281 (syms_of_gnutls): Remove duplicate DEFSYM for
7282 Qgnutls_bootprop_verify_hostname_error, an error for
7283 Qgnutls_bootprop_verify_error (which is no longer used).
7285 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7286 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7287 Also (re)move comments that are misplaced or no longer relevant.
7289 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7291 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7293 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
7295 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7296 and background color parameters if they have been changed.
7298 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7300 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7302 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7304 * xsettings.c (SYSTEM_FONT): Define only when used.
7305 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7307 * keymap.c (access_keymap_1): Now static.
7309 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
7311 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7312 leave any prefix arg for the up event (Bug#1586).
7314 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7316 * lread.c (syms_of_lread): Mention single symbols defined by
7317 `defvar' or `defconst' (bug#7154).
7319 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7320 (Frequire): Mention get-load-suffixes.
7322 2011-07-02 Martin Rudalics <rudalics@gmx.at>
7324 * window.h (window): Remove clone_number slot.
7325 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7327 (make_parent_window, make_window, saved_window)
7328 (Fset_window_configuration, save_window_save): Don't deal with
7330 * buffer.c (Qclone_number): Remove declaration.
7331 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7333 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7335 Add multiple inheritance to keymaps.
7336 * keymap.c (Fmake_composed_keymap): New function.
7337 (Fset_keymap_parent): Simplify.
7338 (fix_submap_inheritance): Remove.
7339 (access_keymap_1): New function extracted from access_keymap to handle
7340 embedded parents and handle lists of maps.
7341 (access_keymap): Use it.
7342 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7343 (Fcopy_keymap): Handle embedded parents.
7344 (Fcommand_remapping, define_as_prefix): Simplify.
7345 (Fkey_binding): Simplify.
7346 (syms_of_keymap): Move minibuffer-local-completion-map,
7347 minibuffer-local-filename-completion-map,
7348 minibuffer-local-must-match-map, and
7349 minibuffer-local-filename-must-match-map to Elisp.
7350 (syms_of_keymap): Defsubr make-composed-keymap.
7351 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7352 (parse_menu_item): Trivial simplification.
7354 2011-07-01 Glenn Morris <rgm@gnu.org>
7356 * Makefile.in (SETTINGS_LIBS): Fix typo.
7358 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7360 * coding.c (Fencode_coding_string): Record the last coding system
7361 used, as the function doc string says (bug#8738).
7363 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7365 * xsettings.c (store_monospaced_changed): Take new font as arg and
7366 check for change against current_mono_font.
7367 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7368 (emacs_settings_constructor, emacs_settings_get_property)
7369 (emacs_settings_set_property, emacs_settings_class_init)
7370 (emacs_settings_init, gsettings_obj): Remove.
7371 (something_changedCB): New function for HAVE_GSETTINGS.
7372 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7373 with value as argument.
7374 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7375 g_settings_new (Bug#8967). Do not create gsettings_obj.
7376 Remove calls to g_settings_bind. Connect something_changedCB to
7379 * xgselect.c: Add defined (HAVE_GSETTINGS).
7380 (xgselect_initialize): Ditto.
7382 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7383 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7386 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7388 * eval.c (struct backtrace): Simplify and port the data structure.
7389 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7390 signed bit field, as this assumption is not portable and it makes
7391 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7392 "char debug_on_exit : 1" as this is not portable either; instead,
7393 use the portable "unsigned int debug_on_exit : 1". Remove unused
7394 member evalargs. Remove obsolete comments about cc bombing out.
7396 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7398 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
7399 Let HAVE_GSETTINGS override HAVE_GCONF.
7400 (store_monospaced_changed): New function.
7401 (EMACS_SETTINGS): A new type derived from GObject to handle
7402 GSettings notifications.
7403 (emacs_settings_constructor, emacs_settings_get_property)
7404 (emacs_settings_set_property, emacs_settings_class_init):
7406 (gsettings_client, gsettings_obj): New variables.
7407 (GSETTINGS_SCHEMA): New define.
7408 (something_changedCB): Call store_monospaced_changed.
7409 (init_gsettings): New function.
7410 (xsettings_initialize): Call init_gsettings.
7411 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7414 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
7417 2011-06-29 Martin Rudalics <rudalics@gmx.at>
7419 * window.c (resize_root_window, grow_mini_window)
7420 (shrink_mini_window): Rename Qresize_root_window to
7421 Qwindow_resize_root_window and Qresize_root_window_vertically to
7422 Qwindow_resize_root_window_vertically.
7424 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7426 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7428 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
7430 * makefile.w32-in: Redesign dependencies so they reflect more
7431 clearly which files are directly included by each source file,
7432 and not through other includes.
7434 2011-06-27 Martin Rudalics <rudalics@gmx.at>
7436 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7437 (sort_overlays, overlay_strings): When an overlay's clone number
7438 matches the window's clone number process the overlay even if
7439 the overlay's window property doesn't match the current window.
7441 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7442 (Fwindow_hchild): Rename to Fwindow_left_child.
7443 (Fwindow_next): Rename to Fwindow_next_sibling.
7444 (Fwindow_prev): Rename to Fwindow_prev_sibling.
7445 (resize_window_check): Rename to window_resize_check.
7446 (resize_window_apply): Rename to window_resize_apply.
7447 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7448 (Fdelete_other_windows_internal, resize_frame_windows)
7449 (Fsplit_window_internal, Fdelete_window_internal)
7450 (grow_mini_window, shrink_mini_window)
7451 (Fresize_mini_window_internal): Fix callers accordingly.
7453 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7455 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7456 (emacs_fixed_set_min_size): Remove.
7457 (emacs_fixed_new): Take frame as argument.
7459 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7460 (_EmacsFixedPrivate): Remove minwidth/height.
7461 Add struct frame *f.
7462 (emacs_fixed_init): Initialize priv->f.
7463 (get_parent_class, emacs_fixed_set_min_size): Remove.
7464 (emacs_fixed_new): Set priv->f to argument.
7465 (emacs_fixed_get_preferred_width)
7466 (emacs_fixed_get_preferred_height): Use min_width/height from
7467 frames size_hint to set minimum and natural (Bug#8919).
7468 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7469 and use min_width/height from frames size_hint to set
7470 min_width/height (Bug#8919).
7472 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
7473 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7476 2011-06-26 Eli Zaretskii <eliz@gnu.org>
7478 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7479 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7482 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
7484 * process.c (wait_reading_process_output): Bypass select if
7485 waiting for a cell while ignoring keyboard input, and input is
7486 pending. Suggested by Jan Djärv (Bug#8869).
7488 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7490 Use gnulib's dup2 module instead of rolling our own.
7491 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7493 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7495 * dispnew.c (scrolling_window): Before scrolling, turn off a
7496 mouse-highlight in the window being scrolled.
7498 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
7500 Move DEFSYM to lisp.h and use everywhere.
7502 * character.h (DEFSYM): Move declaration...
7503 * lisp.h (DEFSYM): ...here.
7509 * w32select.c: Don't include character.h.
7511 * alloc.c (syms_of_alloc):
7512 * buffer.c (syms_of_buffer):
7513 * bytecode.c (syms_of_bytecode):
7514 * callint.c (syms_of_callint):
7515 * casefiddle.c (syms_of_casefiddle):
7516 * casetab.c (init_casetab_once):
7517 * category.c (init_category_once, syms_of_category):
7518 * ccl.c (syms_of_ccl):
7519 * cmds.c (syms_of_cmds):
7520 * composite.c (syms_of_composite):
7521 * dbusbind.c (syms_of_dbusbind):
7522 * dired.c (syms_of_dired):
7523 * dispnew.c (syms_of_display):
7524 * doc.c (syms_of_doc):
7525 * editfns.c (syms_of_editfns):
7526 * emacs.c (syms_of_emacs):
7527 * eval.c (syms_of_eval):
7528 * fileio.c (syms_of_fileio):
7529 * fns.c (syms_of_fns):
7530 * frame.c (syms_of_frame):
7531 * fringe.c (syms_of_fringe):
7532 * insdel.c (syms_of_insdel):
7533 * keymap.c (syms_of_keymap):
7534 * lread.c (init_obarray, syms_of_lread):
7535 * macros.c (syms_of_macros):
7536 * msdos.c (syms_of_msdos):
7537 * print.c (syms_of_print):
7538 * process.c (syms_of_process):
7539 * search.c (syms_of_search):
7540 * sound.c (syms_of_sound):
7541 * syntax.c (init_syntax_once, syms_of_syntax):
7542 * terminal.c (syms_of_terminal):
7543 * textprop.c (syms_of_textprop):
7544 * undo.c (syms_of_undo):
7545 * w32.c (globals_of_w32):
7546 * window.c (syms_of_window):
7547 * xdisp.c (syms_of_xdisp):
7548 * xfaces.c (syms_of_xfaces):
7549 * xfns.c (syms_of_xfns):
7550 * xmenu.c (syms_of_xmenu):
7551 * xsettings.c (syms_of_xsettings):
7552 * xterm.c (syms_of_xterm): Use DEFSYM.
7554 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7556 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
7558 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7560 Integer and buffer overflow fixes (Bug#8873).
7562 * print.c (printchar, strout): Check for string overflow.
7563 (PRINTPREPARE, printchar, strout):
7564 Don't set size unless allocation succeeds.
7566 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7567 for sizes. Check for string overflow more accurately.
7568 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7570 * macros.c: Integer and buffer overflow fixes.
7571 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7572 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7573 Use ptrdiff_t, not int, for sizes.
7574 Don't increment bufsize until after realloc succeeds.
7575 Check for size-calculation overflow.
7576 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7578 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7580 * lread.c: Integer overflow fixes.
7581 (read_integer): Radix is now EMACS_INT, not int,
7582 to improve quality of diagnostics for out-of-range radices.
7583 Calculate buffer size correctly for out-of-range radices.
7584 (read1): Check for integer overflow in radices, and in
7585 read-circle numbers.
7586 (read_escape): Avoid int overflow.
7587 (Fload, openp, read_buffer_size, read1)
7588 (substitute_object_recurse, read_vector, read_list, map_obarray):
7589 Use ptrdiff_t, not int, for sizes.
7590 (read1): Use EMACS_INT, not int, for sizes.
7591 Check for size overflow.
7593 * image.c (cache_image): Check for size arithmetic overflow.
7595 * lread.c: Integer overflow issues.
7596 (saved_doc_string_size, saved_doc_string_length)
7597 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7598 Now ptrdiff_t, not int.
7599 (read1): Don't assume doc string length fits in int. Check for
7600 out-of-range doc string lengths.
7601 (read_list): Don't assume file position fits in int.
7602 (read_escape): Check for hex character overflow.
7604 2011-06-22 Leo Liu <sdl.web@gmail.com>
7606 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7607 Move to minibuffer.el.
7609 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7611 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
7612 The following patches are for when GLYPH_DEBUG && !XASSERT.
7613 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7614 * dispnew.c (flush_stdout):
7615 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7616 Mark as externally visible.
7617 * dispnew.c (check_window_matrix_pointers): Now static.
7618 * dispnew.c (window_to_frame_vpos):
7619 * xfns.c (unwind_create_frame):
7620 * xterm.c (x_check_font): Remove unused local.
7621 * scroll.c (CHECK_BOUNDS):
7622 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7623 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7624 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7625 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7626 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7628 (debug_method_add): Use va_list and vsprintf rather than relying
7629 on undefined behavior with wrong number of arguments.
7630 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7631 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7632 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7633 since we're not interested in debugging glyphs with old libraries.
7634 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7635 GCC 4.6.0's static checking.
7637 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7639 Integer overflow and signedness fixes (Bug#8873).
7640 A few related buffer overrun fixes, too.
7642 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7644 * dispextern.h (struct face.stipple):
7645 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7646 (x_bitmap_mask, x_allocate_bitmap_record)
7647 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7648 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7649 (x_create_bitmap_from_xpm_data):
7650 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7651 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7653 * xfaces.c (load_pixmap):
7654 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7655 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7656 (.bitmaps_last, struct x_output.icon_bitmap):
7657 Use ptrdiff_t, not int, for bitmap indexes.
7658 (x_allocate_bitmap_record): Check for size overflow.
7659 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7661 Use ptrdiff_t, not int, for overlay counts.
7662 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7663 * editfns.c (overlays_around, get_pos_property):
7664 * textprop.c (get_char_property_and_overlay):
7665 * xdisp.c (next_overlay_change, note_mouse_highlight):
7666 * xfaces.c (face_at_buffer_position):
7667 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7668 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7669 (Fnext_overlay_change, Fprevious_overlay_change)
7670 (mouse_face_overlay_overlaps, Foverlays_in):
7671 Use ptrdiff_t, not int, for sizes.
7672 (overlays_at, overlays_in): Check for size-calculation overflow.
7674 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7676 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7677 (x_session_initialize): Do not assume string length fits in int.
7679 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7680 This is unlikely, but can occur if DPI is outlandish.
7682 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
7683 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7685 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7686 * xrdb.c (magic_file_p, search_magic_path):
7687 Omit last arg SUFFIX; it was always 0. All callers changed.
7688 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7690 * xfont.c (xfont_match): Avoid need for strlen.
7692 * xfns.c: Don't assume strlen fits in int.
7693 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7695 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7696 not unsigned long, as we prefer signed integers. All callers changed.
7697 Detect integer overflow in repeat count.
7698 (message_dolog): Don't assume print length fits in 39 bytes.
7699 (display_mode_element): Don't assume strlen fits in int.
7701 * termcap.c: Don't assume sizes fit in int and never overflow.
7702 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7703 (gobble_line): Check for size-calculation overflow.
7705 * minibuf.c (Fread_buffer):
7706 * lread.c (intern, intern_c_string):
7707 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7708 Don't assume string length fits in int.
7710 * keyboard.c (parse_tool_bar_item):
7711 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7713 * font.c: Don't assume string length fits in int.
7714 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7715 Use ptrdiff_t, not int.
7716 (font_intern_prop): Don't assume string length fits in int.
7717 Don't assume integer property fits in fixnum.
7718 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
7720 * filelock.c: Fix some buffer overrun and integer overflow issues.
7721 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
7722 Reformulate so as not to need the command string.
7723 Invoke gzip -cd rather than gunzip, as it's more portable.
7724 (lock_info_type, lock_file_1, lock_file):
7725 Don't assume pid_t and time_t fit in unsigned long.
7726 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7727 (current_lock_owner): Prefer signed type for sizes.
7728 Use memcpy, not strncpy, where memcpy is what is really wanted.
7729 Don't assume (via atoi) that time_t and pid_t fit in int.
7730 Check for time_t and/or pid_t out of range, e.g., via a network share.
7731 Don't alloca where an auto var works fine.
7733 * fileio.c: Fix some integer overflow issues.
7734 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7735 Don't assume string length fits in int.
7736 (directory_file_name): Don't assume string length fits in long.
7737 (make_temp_name): Don't assume pid fits in int, or that its print
7738 length is less than 20.
7740 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7742 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7744 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7746 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7747 We prefer signed integers, even for size calculations.
7749 * emacs.c: Don't assume string length fits in 'int'.
7750 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7751 (main): Don't invoke strlen when not needed.
7753 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7754 (XD_DEBUG_MESSAGE): Don't waste a byte.
7756 * callproc.c (getenv_internal_1, getenv_internal)
7758 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7760 * lread.c (invalid_syntax): Omit length argument.
7761 All uses changed. This doesn't fix a bug, but it simplifies the
7762 code away from its former Hollerith-constant appearance, and it's
7763 one less 'int' to worry about when looking at integer-overflow issues.
7764 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
7766 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7767 This didn't break anything, but it didn't help either.
7768 It's confusing to put a bogus integer in a place where the actual
7769 value does not matter.
7770 (LIST_END_P): Remove unused macro and its bogus comment.
7771 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
7773 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7774 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7776 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7777 We prefer signed types, and the value cannot exceed the EMACS_INT
7778 range anyway (because otherwise the length would not be representable).
7779 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7780 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7781 This avoids a GCC warning when WIDE_EMACS_INT.
7783 * indent.c (sane_tab_width): New function.
7784 (current_column, scan_for_column, Findent_to, position_indentation)
7785 (compute_motion): Use it. This is just for clarity.
7786 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
7788 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
7790 * lisp.h (lint_assume): New macro.
7791 * composite.c (composition_gstring_put_cache):
7792 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7794 * editfns.c, insdel.c:
7795 Omit unnecessary forward decls, to simplify future changes.
7797 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7799 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7801 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
7802 Use much-faster test for byte-length change.
7803 Don't assume string byte-length fits in 'int'.
7804 Check that character arg fits in 'int'.
7805 (mapcar1): Declare byte as byte, for clarity.
7807 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7809 * fns.c (concat): Catch string overflow earlier.
7810 Do not rely on integer wraparound.
7812 * dispextern.h (struct it.overlay_strings_charpos)
7813 (struct it.selective): Now EMACS_INT, not int.
7814 * xdisp.c (forward_to_next_line_start)
7815 (back_to_previous_visible_line_start)
7816 (reseat_at_next_visible_line_start, next_element_from_buffer):
7817 Don't arbitrarily truncate the value of 'selective' to int.
7819 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7821 * composite.c: Don't truncate sizes to 'int'.
7822 (composition_gstring_p, composition_reseat_it)
7823 (composition_adjust_point): Use EMACS_INT, not int.
7824 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7825 not EMACS_UINT, for indexes.
7827 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7829 * buffer.c: Include <verify.h>.
7830 (struct sortvec.priority, struct sortstr.priority):
7831 Now EMACS_INT, not int.
7832 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7833 (struct sortstr.size, record_overlay_string)
7834 (struct sortstrlist.size, struct sortlist.used):
7835 Don't truncate size to int.
7836 (record_overlay_string): Check for size-calculation overflow.
7837 (init_buffer_once): Check at compile-time, not run-time.
7839 2011-06-22 Jim Meyering <meyering@redhat.com>
7841 Don't leak an XBM-image-sized buffer
7842 * image.c (xbm_load): Free the image buffer after using it.
7844 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7847 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7848 that Sun C diagnosed.
7849 * fns.c (secure_hash): Fix pointer signedness issue.
7850 * intervals.c (static_offset_intervals): New function.
7851 (offset_intervals): Use it.
7853 2011-06-21 Leo Liu <sdl.web@gmail.com>
7856 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7859 * fns.c (secure_hash): Rename from crypto_hash_function and change
7860 the first arg to accept symbols.
7861 (Fsecure_hash): New primitive.
7862 (syms_of_fns): New symbols.
7864 2011-06-20 Deniz Dogan <deniz@dogan.se>
7866 * process.c (Fset_process_buffer): Clarify return value in
7869 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7871 * dispnew.c (add_window_display_history): Use BVAR.
7873 * xdisp.c (debug_method_add): Use BVAR.
7874 (check_window_end, dump_glyph_matrix, dump_glyph)
7875 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7877 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7880 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7881 check till after the cache is created in init_frame_faces.
7883 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7885 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7887 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7889 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7890 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7891 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7893 Improve buffer-overflow checking (Bug#8873).
7894 * fileio.c (Finsert_file_contents):
7895 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7896 Remove the old (too-loose) buffer overflow checks.
7897 They weren't needed, since make_gap checks for buffer overflow.
7898 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7899 The old code merely checked for Emacs fixnum overflow, and relied
7900 on undefined (wraparound) behavior. The new code avoids undefined
7901 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7903 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7904 Tune. Don't use wider integers than needed. Don't use alloca.
7905 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7907 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7909 * insdel.c, lisp.h (buffer_overflow): New function.
7910 (insert_from_buffer_1, replace_range, replace_range_2):
7911 * insdel.c (make_gap_larger):
7912 * editfns.c (Finsert_char):
7913 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7915 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7917 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7919 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7921 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7922 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7924 * fileio.c: Don't assume EMACS_INT fits in off_t.
7925 (emacs_lseek): New static function.
7926 (Finsert_file_contents, Fwrite_region): Use it.
7927 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7929 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7931 * fns.c: Don't overflow int when computing a list length.
7932 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7933 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7934 truncation on 64-bit hosts. Check for QUIT every
7935 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7936 faster and is responsive enough.
7937 (Flength): Report an error instead of overflowing an integer.
7938 (Fsafe_length): Return a float if the value is not representable
7939 as a fixnum. This shouldn't happen except in contrived situations.
7940 (Fnthcdr, Fsort): Don't assume list length fits in int.
7941 (Fcopy_sequence): Don't assume vector length fits in int.
7943 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7944 (header_size, word_size): New constants.
7945 (allocate_vectorlike): Don't check size overflow here.
7946 (allocate_vector): Check it here instead, since this is the only
7947 caller of allocate_vectorlike that could cause overflow.
7948 Check that the new vector's length is representable as a fixnum.
7950 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7951 The previous code was bogus. For example, next_almost_prime (32)
7952 returned 39, which is undesirable as it is a multiple of 3; and
7953 next_almost_prime (24) returned 25, which is a multiple of 5 so
7954 why was the code bothering to check for multiples of 7?
7956 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7958 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7960 Variadic C functions now count arguments with ptrdiff_t.
7961 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7962 Back then I didn't know that the Emacs coding style prefers signed int.
7963 Also, in the meantime I found a few more instances where arguments
7964 were being counted with int, which may truncate counts on 64-bit
7965 machines, or EMACS_INT, which may be unnecessarily wide.
7966 * lisp.h (struct Lisp_Subr.function.aMANY)
7967 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7968 Arg counts are now ptrdiff_t, not size_t.
7969 All variadic functions and their callers changed accordingly.
7970 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7971 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7972 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7973 * callint.c (Fcall_interactively): Check arg count for overflow,
7974 to avoid potential buffer overrun. Use signed char, not 'int',
7975 for 'varies' array, so that we needn't bother to check its size
7976 calculation for overflow.
7977 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7978 * eval.c (apply_lambda):
7979 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7980 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7981 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7983 * callint.c (Fcall_interactively): Don't use index var as event count.
7985 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7986 * mem-limits.h (SIZE): Remove; no longer used.
7988 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7990 Remove unnecessary casts.
7991 * xterm.c (x_term_init):
7992 * xfns.c (x_set_border_pixel):
7993 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7994 These aren't needed now that we assume ANSI C.
7996 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7997 It's more likely to cause problems (due to unsigned overflow)
8000 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8002 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8004 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8006 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8008 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8010 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8012 GLYPH_CODE_FACE returns EMACS_INT, not int.
8013 * dispextern.h (merge_faces):
8014 * xfaces.c (merge_faces):
8015 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8016 Don't assume EMACS_INT fits in int.
8018 * character.h (CHAR_VALID_P): Remove unused parameter.
8019 * fontset.c, lisp.h, xdisp.c: All uses changed.
8021 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8023 * fns.c (concat): Minor tuning based on overflow analysis.
8024 This doesn't fix any bugs. Use int to hold character, instead
8025 of constantly refetching from Emacs object. Use XFASTINT, not
8026 XINT, for value known to be a character. Don't bother comparing
8027 a single byte to 0400, as it's always less.
8029 * floatfns.c (Fexpt):
8030 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8032 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8035 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8037 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8038 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8039 incorrectly succeed when S was a string, because 4294967386 was
8040 truncated before it was used.
8042 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8043 Otherwise, an out-of-range integer could cause undefined behavior
8046 * composite.c: Use int, not EMACS_INT, for characters.
8047 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8048 EMACS_INT, for values that are known to be in character range.
8049 This doesn't fix any bugs but is the usual style inside Emacs and
8050 may generate better code on 32-bit machines.
8052 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8053 This is for reasons similar to the recent CHAR_STRING fix.
8054 * charset.c (Fencode_char): Check that character arg is actually
8055 a character. Pass an int to ENCODE_CHAR.
8056 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8057 wider than 'int', as a compile-time check to prevent future regressions
8060 * character.c (char_string): Remove unnecessary casts.
8062 Make sure a 64-bit char is never passed to CHAR_STRING.
8063 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8064 by silently ignoring the top 32 bits, allowing some values
8065 that were far too large to be valid characters.
8066 * character.h: Include <verify.h>.
8067 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8068 arguments are no wider than unsigned, as a compile-time check
8069 to prevent future regressions in this area.
8071 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8072 (Fsubst_char_in_region):
8074 * xdisp.c (decode_mode_spec_coding):
8075 Adjust to CHAR_STRING's new requirement.
8076 * editfns.c (Finsert_char, Fsubst_char_in_region):
8077 * fns.c (concat): Check that character args are actually
8078 characters. Without this test, these functions did the wrong
8079 thing with wildly out-of-range values on 64-bit hosts.
8081 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8082 These casts should not be needed on 32-bit hosts, either.
8083 * keyboard.c (read_char):
8084 * lread.c (Fload): Remove casts to unsigned.
8086 * lisp.h (UNSIGNED_CMP): New macro.
8087 This fixes comparison bugs on 64-bit hosts.
8088 (ASCII_CHAR_P): Use it.
8089 * casefiddle.c (casify_object):
8090 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8091 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8092 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8093 * dispextern.h (FACE_FROM_ID):
8094 * keyboard.c (read_char): Use UNSIGNED_CMP.
8096 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8097 not to EMACS_INT, to avoid GCC warning.
8099 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8101 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8102 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8103 isn't needed on 32-bit machines.
8105 * buffer.c (Fgenerate_new_buffer_name):
8106 Use EMACS_INT for count, not int.
8107 (advance_to_char_boundary): Return EMACS_INT, not int.
8109 * data.c (Qcompiled_function): Now static.
8111 * window.c (window_body_lines): Now static.
8113 * image.c (gif_load): Rename local to avoid shadowing.
8115 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8116 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8117 * alloc.c (make_save_value): Integer argument is now of type
8119 (mark_object): Use ptrdiff_t, not int.
8120 * lisp.h (pD): New macro.
8121 * print.c (print_object): Use it.
8123 * alloc.c: Use EMACS_INT, not int, to count objects.
8124 (total_conses, total_markers, total_symbols, total_vector_size)
8125 (total_free_conses, total_free_markers, total_free_symbols)
8126 (total_free_floats, total_floats, total_free_intervals)
8127 (total_intervals, total_strings, total_free_strings):
8128 Now EMACS_INT, not int. All uses changed.
8129 (Fgarbage_collect): Compute overall total using a double, so that
8130 integer overflow is less likely to be a problem. Check for overflow
8131 when converting back to an integer.
8132 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8133 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8134 These were 'int' variables that could overflow on 64-bit hosts;
8135 they were never used, so remove them instead of repairing them.
8136 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8137 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8138 Previously, this ceilinged at INT_MAX, but that doesn't work on
8140 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8142 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8143 (allocate_vectorlike): Check for ptrdiff_t overflow.
8144 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8145 when a (possibly-narrower) signed value would do just as well.
8146 We prefer using signed arithmetic, to avoid comparison confusion.
8148 * alloc.c: Catch some string size overflows that we were missing.
8149 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8150 for convenience in STRING_BYTES_MAX.
8151 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8152 The definition here is exact; the one in lisp.h was approximate.
8153 (allocate_string_data): Check for string overflow. This catches
8154 some instances we weren't catching before. Also, it catches
8155 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8156 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8157 and ptrdiff_t and EMACS_INT are both 64 bits.
8159 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8160 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8161 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8163 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8165 * alloc.c (Fmake_string): Check for out-of-range init.
8167 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8169 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8171 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8173 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8174 xg_get_default_scrollbar_width.
8176 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8177 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8178 (style_changed_cb): Call update_theme_scrollbar_width and call
8179 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8180 all frames (Bug#8505).
8181 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8182 Call gtk_window_set_resizable if HAVE_GTK3.
8183 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8184 and height if HAVE_GTK3 (Bug#8505).
8185 (scroll_bar_width_for_theme): New variable.
8186 (update_theme_scrollbar_width): New function.
8187 (xg_get_default_scrollbar_width): Move code to
8188 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8189 (xg_initialize): Call update_theme_scrollbar_width.
8191 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8193 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8195 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8197 * frame.c (make_frame): Call other_buffer_safely instead of
8200 * window.c (temp_output_buffer_show): Call display_buffer with
8201 second argument Vtemp_buffer_show_specifiers and reset latter
8202 immediately after the call.
8203 (Vtemp_buffer_show_specifiers): New variable.
8204 (auto_window_vscroll_p, next_screen_context_lines)
8205 (Vscroll_preserve_screen_position): Remove leading asterisks from
8208 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8210 Fix minor problems found by GCC 4.6.0 static checking.
8211 * buffer.c (Qclone_number): Remove for now, as it's unused.
8212 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8213 (record_buffer): Remove unused local.
8214 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8215 (set_frame_buffer_list): Remove; unused.
8216 * frame.h (other_visible_frames): Remove decl.
8217 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8218 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8219 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8221 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8222 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8223 Define only if HAVE_GPM.
8224 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8225 (update_hints_inhibit): Remove; never set. All uses removed.
8226 * widgetprv.h (emacsFrameClassRec): Remove decl.
8227 * window.c (delete_deletable_window): Now returns void, since it
8228 wasn't returning anything.
8229 (compare_window_configurations): Remove unused locals.
8230 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8231 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8232 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8233 the same widths as pointers. This follows up on the 2011-05-06 patch.
8234 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8235 * xterm.h: Likewise.
8236 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8238 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
8240 * makefile.w32-in: Update dependencies.
8241 (LISP_H): Add lib/intprops.h.
8243 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8245 * image.c (gif_load): Add animation frame delay to the metadata.
8246 (syms_of_image): Use DEFSYM. New symbol `delay'.
8248 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8250 * window.c (delete_deletable_window): Re-add.
8251 (Fset_window_configuration): Rewrite to handle dead buffers and
8252 consequently deletable windows.
8253 (window_tree, Fwindow_tree): Remove. Supply functionality in
8255 (compare_window_configurations): Simplify code.
8257 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8259 * image.c (imagemagick_load_image): Fix type mismatch.
8260 (Fimagemagick_types): Likewise.
8262 * window.h (replace_buffer_in_windows): Declare.
8264 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8266 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8267 Qclone_number. Remove external declaration of Qdelete_window.
8268 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8270 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8271 Run Qbuffer_list_update_hook if allowed.
8272 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8273 buffer list implementation.
8274 (other_buffer_safely): New function.
8275 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8276 calls to replace_buffer_in_windows and
8277 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8279 (record_buffer): Inhibit quitting and rewrite using quittable
8280 functions. Run Qbuffer_list_update_hook if allowed.
8281 (Frecord_buffer, Funrecord_buffer): New functions.
8282 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8283 Move switch-to-buffer to window.el.
8284 (bury-buffer): Move to window.el.
8285 (Vbuffer_list_update_hook): New variable.
8287 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8290 * window.h (resize_frame_windows): Move up in code.
8291 (Fwindow_frame): Remove EXFUN.
8292 (replace_buffer_in_all_windows): Remove prototype.
8293 (replace_buffer_in_windows_safely): Add prototype.
8295 * window.c: Declare Qdelete_window static again. Move down
8296 declaration of select_count.
8297 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8298 (Fother_window): Move to window.el.
8299 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8300 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8301 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8303 (replace_buffer_in_windows): Implement by calling
8304 Qreplace_buffer_in_windows.
8305 (replace_buffer_in_all_windows): Remove with some functionality
8306 moved into replace_buffer_in_windows_safely.
8307 (replace_buffer_in_windows_safely): New function.
8308 (select_window_norecord, select_frame_norecord): Move in front
8309 of run_window_configuration_change_hook. Remove now obsolete
8311 (Fset_window_buffer): Rewrite doc-string.
8312 Call Qrecord_window_buffer.
8313 (keys_of_window): Move binding for other-window to window.el.
8315 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8317 * dispextern.h (struct image): Replace data member, whose int_val
8318 and ptr_val fields were not used by anything, with a single
8321 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8322 (gif_clear_image, gif_load, imagemagick_load_image)
8323 (gs_clear_image, gs_load): Callers changed.
8325 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8327 * buffer.h: Include <time.h>, for time_t.
8328 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8330 Fix minor problems found by static checking.
8332 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8334 Make identifiers static if they are not used in other modules.
8335 * data.c (Qcompiled_function, Qframe, Qvector):
8336 * image.c (QimageMagick, Qsvg):
8337 * minibuf.c (Qmetadata):
8338 * window.c (resize_window_check, resize_root_window): Now static.
8339 * window.h (resize_window_check, resize_root_window): Remove decls.
8341 * window.c (window_deletion_count, delete_deletable_window):
8343 (window_body_lines): Now static.
8344 (Fdelete_other_windows_internal): Mark vars as initialized.
8345 Make sure 'resize_failed' is initialized.
8346 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8347 (resize_window_apply): Remove unused local.
8348 * window.h (delete_deletable_window): Remove decl.
8350 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
8351 (imagemagick_load_image): Fix pointer signedness problem by changing
8352 last arg from unsigned char * to char *. All uses changed.
8353 Also, fix a local for similar reasons.
8354 Remove unused locals. Remove locals to avoid shadowing.
8355 (fn_rsvg_handle_free): Remove; unused.
8356 (svg_load, svg_load_image): Fix pointer signedness problem.
8357 (imagemagick_load_image): Don't use garbage pointer image_wand.
8359 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8361 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
8363 * image.c (gif_load): Fix omitted cast error introduced by
8366 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8368 * window.h (resize_proportionally, orig_total_lines)
8369 (orig_top_line): Remove from window structure.
8370 (set_window_height, set_window_width, change_window_heights)
8371 (Fdelete_window): Remove prototypes.
8372 (resize_frame_windows): Remove duplicate declaration.
8374 2011-06-10 Eli Zaretskii <eliz@gnu.org>
8376 * window.h (resize_frame_windows, resize_window_check)
8377 (delete_deletable_window, resize_root_window)
8378 (resize_frame_windows): Declare prototypes.
8380 * window.c (resize_window_apply): Make definition be "static" to
8381 match the prototype.
8383 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8385 * window.c: Remove declarations of Qwindow_size_fixed,
8386 window_min_size_1, window_min_size_2, window_min_size,
8387 size_window, window_fixed_size_p, enlarge_window, delete_window.
8388 Remove static from declaration of Qdelete_window, it's
8389 temporarily needed by Fbury_buffer.
8390 (replace_window): Don't assign orig_top_line and
8392 (Fdelete_window, delete_window): Remove. Window deletion is
8393 handled by window.el.
8394 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8395 Replace Fdelete_window calls with calls to Qdelete_window.
8396 (Fdelete_other_windows): Remove. Deleting other windows is
8397 handled by window.el.
8398 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8399 handled in window.el.
8400 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8401 Window minimum sizes are handled in window.el.
8402 (shrink_windows, size_window, set_window_height)
8403 (set_window_width, change_window_heights, window_height)
8404 (window_width, CURBEG, CURSIZE, enlarge_window)
8405 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8406 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8407 handled in window.el.
8408 (make_dummy_parent): Rename to make_parent_window and give it a
8409 second argument horflag.
8410 (make_window): Don't set resize_proportionally any more.
8411 (Fsplit_window): Remove. Windows are split in window.el.
8412 (save_restore_action, save_restore_orig_size)
8413 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8414 Resize mini windows in window.el.
8415 (grow_mini_window, shrink_mini_window): Implement by calling
8416 Qresize_root_window_vertically, resize_window_check and
8417 resize_window_apply.
8418 (saved_window, Fset_window_configuration, save_window_save):
8419 Do not handle orig_top_line, orig_total_lines, and
8420 resize_proportionally.
8421 (window_min_height, window_min_width): Move to window.el.
8422 (keys_of_window): Move bindings for delete-other-windows,
8423 split-window, delete-window and enlarge-window to window.el.
8425 * buffer.c: Temporarily extern Qdelete_window.
8426 (Fbury_buffer): Temporarily call Qdelete_window instead of
8427 Fdelete_window (Fbury_buffer will move to window.el soon).
8429 * frame.c (set_menu_bar_lines_1): Remove code handling
8430 orig_top_line and orig_total_lines.
8432 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8433 set_window_height but set heights directly.
8434 (change_frame_size_1): Use resize_frame_windows.
8436 * xdisp.c (init_xdisp): Don't use set_window_height but set
8439 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8440 Use resize_frame_windows instead of change_window_heights and run
8441 run_window_configuration_change_hook.
8443 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8444 instead of change_window_heights and run
8445 run_window_configuration_change_hook.
8447 2011-06-09 Martin Rudalics <rudalics@gmx.at>
8449 * window.c (replace_window): Rename second argument REPLACEMENT to
8450 NEW. New third argument SETFLAG. Rewrite.
8451 (delete_window, make_dummy_parent): Call replace_window with
8453 (window_list_1): Move down in code.
8454 (run_window_configuration_change_hook): Move set_buffer part
8455 before select_frame_norecord part in order to unwind correctly.
8456 Rename count1 to count.
8457 (recombine_windows, delete_deletable_window, resize_root_window)
8458 (Fdelete_other_windows_internal)
8459 (Frun_window_configuration_change_hook, make_parent_window)
8460 (resize_window_check, resize_window_apply, Fresize_window_apply)
8461 (resize_frame_windows, Fsplit_window_internal)
8462 (Fdelete_window_internal, Fresize_mini_window_internal):
8464 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8466 2011-06-08 Martin Rudalics <rudalics@gmx.at>
8468 * window.h (window): Add some new members to window structure -
8469 normal_lines, normal_cols, new_total, new_normal, clone_number,
8470 splits, nest, prev_buffers, next_buffers.
8471 (WINDOW_TOTAL_SIZE): Move here from window.c.
8472 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
8474 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8476 (make_dummy_parent): Set new members of windows structure.
8477 (make_window): Move down in code. Handle new members of window
8479 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8480 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8481 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8482 (Fset_window_prev_buffers, Fwindow_next_buffers)
8483 (Fset_window_next_buffers, Fset_window_clone_number):
8485 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8486 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8488 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8489 Argument WINDOW can be now internal window too.
8490 (Fwindow_use_time): Move up in code.
8491 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8493 (Fset_window_configuration, saved_window)
8494 (Fcurrent_window_configuration, save_window_save): Handle new
8495 members of window structure.
8496 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8497 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8498 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8499 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8500 Qget_mru_window, Qresize_root_window,
8501 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8502 Qauto_buffer_name; staticpro them.
8504 2011-06-07 Martin Rudalics <rudalics@gmx.at>
8506 * window.c (Fwindow_total_size, Fwindow_left_column)
8507 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8508 (Fwindow_list_1): New functions.
8509 (window_box_text_cols): Replace with window_body_cols.
8510 (Fwindow_width, Fscroll_left, Fscroll_right):
8511 Use window_body_cols instead of window_box_text_cols.
8512 (delete_window, Fset_window_configuration):
8513 Call delete_all_subwindows with window as argument.
8514 (delete_all_subwindows): Take a window as argument and not a
8516 (window_loop): Remove handling of GET_LRU_WINDOW and
8518 (Fget_lru_window, Fget_largest_window): Move to window.el.
8520 * window.h: Extern window_body_cols instead of
8521 window_box_text_cols. delete_all_subwindows now takes a
8522 Lisp_Object as argument.
8524 * indent.c (compute_motion, Fcompute_motion):
8525 Use window_body_cols instead of window_box_text_cols.
8527 * frame.c (delete_frame): Call delete_all_subwindows with root
8530 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8532 * fns.c (Fputhash): Document return value.
8534 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
8536 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8538 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8540 Cons<->int and similar integer overflow fixes (Bug#8794).
8542 Check for overflow when converting integer to cons and back.
8543 * charset.c (Fdefine_charset_internal, Fdecode_char):
8544 Use cons_to_unsigned to catch overflow.
8545 (Fencode_char): Use INTEGER_TO_CONS.
8546 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8547 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8548 * data.c (long_to_cons, cons_to_long): Remove.
8549 (cons_to_unsigned, cons_to_signed): New functions.
8550 These signal an error for invalid or out-of-range values.
8551 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8552 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8553 * font.c (Ffont_variation_glyphs):
8554 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8555 * lisp.h: Include <intprops.h>.
8556 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8557 (cons_to_signed, cons_to_unsigned): New decls.
8558 (long_to_cons, cons_to_long): Remove decls.
8559 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8560 (Fprimitive_undo): Use CONS_TO_INTEGER.
8561 * xfns.c (Fx_window_property): Likewise.
8562 * xselect.c: Include <limits.h>.
8563 (x_own_selection, selection_data_to_lisp_data):
8564 Use INTEGER_TO_CONS.
8565 (x_handle_selection_request, x_handle_selection_clear)
8566 (x_get_foreign_selection, Fx_disown_selection_internal)
8567 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8568 (lisp_data_to_selection_data): Use cons_to_unsigned.
8569 (x_fill_property_data): Use cons_to_signed.
8570 Report values out of range.
8572 Check for buffer and string overflow more precisely.
8573 * buffer.h (BUF_BYTES_MAX): New macro.
8574 * lisp.h (STRING_BYTES_MAX): New macro.
8575 * alloc.c (Fmake_string):
8576 * character.c (string_escape_byte8):
8577 * coding.c (coding_alloc_by_realloc):
8578 * doprnt.c (doprnt):
8579 * editfns.c (Fformat):
8581 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8582 since they may not be the same number.
8583 * editfns.c (Finsert_char):
8584 * fileio.c (Finsert_file_contents):
8585 Likewise for BUF_BYTES_MAX.
8587 * image.c: Use ptrdiff_t, not int, for sizes.
8588 (slurp_file): Switch from int to ptrdiff_t.
8590 (slurp_file): Check that file size fits in both size_t (for
8591 malloc) and ptrdiff_t (for sanity and safety).
8593 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8594 if b->modtime has its maximal value.
8596 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8598 Don't assume time_t can fit into int.
8599 * buffer.h (struct buffer.modtime): Now time_t, not int.
8600 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8601 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8603 Minor fixes for signed vs unsigned integers.
8604 * character.h (MAYBE_UNIFY_CHAR):
8605 * charset.c (maybe_unify_char):
8606 * keyboard.c (read_char, reorder_modifiers):
8607 XINT -> XFASTINT, since the integer must be nonnegative.
8608 * ftfont.c (ftfont_spec_pattern):
8609 * keymap.c (access_keymap, silly_event_symbol_error):
8610 XUINT -> XFASTINT, since the integer must be nonnegative.
8611 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8612 since it makes no difference and we prefer signed.
8613 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8614 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8617 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8619 * window.h (Fwindow_frame): Declare.
8621 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8623 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8624 (SPARE_MEMORY): Always define.
8625 (LARGE_REQUEST): Remove.
8626 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8628 2011-06-06 Martin Rudalics <rudalics@gmx.at>
8630 * lisp.h: Move EXFUNS for Fframe_root_window,
8631 Fframe_first_window and Fset_frame_selected_window to window.h.
8633 * window.h: Move EXFUNS for Fframe_root_window,
8634 Fframe_first_window and Fset_frame_selected_window here from
8637 * frame.c (Fwindow_frame, Fframe_first_window)
8638 (Fframe_root_window, Fframe_selected_window)
8639 (Fset_frame_selected_window): Move to window.c.
8640 (Factive_minibuffer_window): Move to minibuf.c.
8641 (Fother_visible_frames_p): New function.
8643 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8645 * window.c (decode_window, decode_any_window): Move up in code.
8646 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8647 (inhibit_frame_unsplittable): Remove unused variable.
8648 (Fwindow_buffer): Move up and rewrite doc-string.
8649 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8650 (Fwindow_prev): New functions.
8651 (Fwindow_frame): Move here from frame.c. Accept any window as
8653 (Fframe_root_window, Fframe_first_window)
8654 (Fframe_selected_window): Move here from frame.c. Accept frame
8655 or arbitrary window as argument. Update doc-strings.
8656 (Fminibuffer_window): Move up in code.
8657 (Fwindow_minibuffer_p): Move up in code and simplify.
8658 (Fset_frame_selected_window): Move here from frame.c.
8660 (Fselected_window, select_window, Fselect_window): Move up in
8661 code. Minor doc-string fixes.
8663 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8665 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8666 Do not assume that spare memory exists; that assumption is valid
8667 only if SYSTEM_MALLOC.
8668 (LARGE_REQUEST): New macro, so that the issue of large requests
8669 is separated from the issue of spare memory.
8671 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8673 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8676 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8678 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8681 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8683 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8685 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8687 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8688 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8690 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
8692 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8694 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
8696 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8697 (x_clipboard_manager_save): Add return value.
8698 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8700 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8701 Obey Vx_select_enable_clipboard_manager. Catch errors in
8702 x_clipboard_manager_save (Bug#8779).
8703 (Vx_select_enable_clipboard_manager): New variable.
8704 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
8706 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8708 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8710 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8712 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8713 in the current matrix if keep_current_p is non-zero.
8715 2011-06-04 Eli Zaretskii <eliz@gnu.org>
8717 * bidi.c (bidi_level_of_next_char): Fix last change.
8719 2011-06-03 Eli Zaretskii <eliz@gnu.org>
8721 Support bidi reordering of text covered by display properties.
8723 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8724 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8725 (bidi_cache_search, bidi_cache_iterator_state)
8726 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
8727 (bidi_level_of_next_char, bidi_move_to_visually_next):
8728 Support character positions inside a run of characters covered by a
8730 (bidi_paragraph_init, bidi_resolve_explicit_1)
8731 (bidi_level_of_next_char): Call bidi_fetch_char and
8732 bidi_fetch_char_advance instead of FETCH_CHAR and
8734 (bidi_init_it): Initialize new members.
8735 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8737 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8738 instead of using explicit *_CHAR codes.
8739 (bidi_resolve_explicit, bidi_resolve_weak):
8740 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
8741 bidirectional text is supported only in multibyte buffers.
8742 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8743 it to initialize the frame_window_p member of struct bidi_it.
8744 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8745 (bidi_resolve_explicit, bidi_resolve_weak)
8746 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8747 bidi_it->nchars is non-positive.
8748 (bidi_level_of_next_char): Don't try to lookup the cache for the
8749 next/previous character if nothing is cached there yet, or if we
8750 were just reseat()'ed to a new position.
8752 * xdisp.c (set_cursor_from_row): Set start and stop points
8753 according to the row's direction when priming the loop that looks
8754 for the glyph on which to display cursor.
8755 (single_display_spec_intangible_p): Function deleted.
8756 (display_prop_intangible_p): Reimplement to call
8757 handle_display_spec instead of single_display_spec_intangible_p.
8758 Accept 3 additional arguments needed by handle_display_spec.
8759 This fixes incorrect cursor motion across display property with complex
8760 values: lists, `(when COND...)' forms, etc.
8761 (single_display_spec_string_p): Support property values that are
8762 lists with the argument STRING its top-level element.
8763 (display_prop_string_p): Fix the condition for processing a
8764 property that is a list to be consistent with handle_display_spec.
8765 (handle_display_spec): New function, refactored from the
8766 last portion of handle_display_prop.
8767 (compute_display_string_pos): Accept additional argument
8768 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8769 value of a `display' property is a "replacing spec".
8770 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8771 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8772 the display property, but just return a value indicating whether
8773 the display property will replace the characters it covers.
8774 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8775 frame_window_p members of struct bidi_it.
8776 (compute_display_string_pos, compute_display_string_end):
8778 (push_it): Accept second argument POSITION, where pop_it should
8779 jump to continue iteration.
8780 (reseat_1): Initialize bidi_it.disp_pos.
8782 * keyboard.c (adjust_point_for_property): Adjust the call to
8783 display_prop_intangible_p to its new signature.
8785 * dispextern.h (struct bidi_it): New member frame_window_p.
8786 (bidi_init_it): Update prototypes.
8787 (display_prop_intangible_p): Update prototype.
8788 (compute_display_string_pos, compute_display_string_end):
8790 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8793 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
8795 Malloc failure behavior now depends on size of allocation.
8796 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8797 * lisp.h: Change signatures accordingly.
8798 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8799 All callers changed. (Bug#8762)
8801 * gnutls.c: Use Emacs's memory allocators.
8802 Without this change, the gnutls library would invoke malloc etc.
8803 directly, which causes problems on non-SYNC_INPUT hosts, and which
8804 runs afoul of improving memory_full behavior. (Bug#8761)
8805 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8806 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8807 xfree instead of the default malloc, realloc, free.
8808 (Fgnutls_boot): No need to check for memory allocation failure,
8809 since xmalloc does that for us.
8811 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
8812 * category.c (hash_get_category_set):
8813 * ccl.c (ccl_driver):
8814 * charset.c (Fdefine_charset_internal):
8815 * charset.h (struct charset.hash_index):
8816 * composite.c (get_composition_id, gstring_lookup_cache)
8817 (composition_gstring_put_cache):
8818 * composite.h (struct composition.hash_index):
8819 * dispextern.h (struct image.hash):
8820 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8821 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8822 (hashfn_equal, hashfn_user_defined, make_hash_table)
8823 (maybe_resize_hash_table, hash_lookup, hash_put)
8824 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8825 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8826 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8827 * image.c (make_image, search_image_cache, lookup_image)
8828 (xpm_put_color_table_h):
8829 * lisp.h (struct Lisp_Hash_Table):
8830 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8831 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8832 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8833 * alloc.c (allocate_vectorlike):
8834 Check for overflow in vector size calculations.
8835 * ccl.c (ccl_driver):
8836 Check for overflow when converting EMACS_INT to int.
8837 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8838 need to be updated by these changes.
8839 * fns.c (make_hash_table, maybe_resize_hash_table):
8840 Check for integer overflow with large hash tables.
8841 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8842 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8843 (SXHASH_REDUCE): New macro.
8844 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8845 Use it instead of discarding useful hash info with large hash values.
8846 (sxhash_float): New function.
8847 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8848 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8849 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8850 Rewrite to use FIXNUM_BITS, as this simplifies things.
8851 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8852 Adjust signatures to match updated version of code.
8853 (consing_since_gc): Now EMACS_INT, since a single hash table can
8854 use more than INT_MAX bytes.
8856 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8858 Make it possible to build with GCC-4.6+ -O2 -flto.
8860 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8862 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8864 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8865 Call minibuffer-inactive-mode.
8867 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8869 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8870 Update dependencies.
8872 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8874 * data.c (init_data): Remove code for UTS, this system is not
8877 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8879 Don't force ./temacs to start in terminal mode.
8881 * frame.c (make_initial_frame): Initialize faces in all cases, not
8882 only when CANNOT_DUMP is defined.
8883 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8885 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8887 * dispnew.c (add_window_display_history): Use const for the string
8888 pointer. Remove declaration, not needed.
8890 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8892 Use 'inline', not 'INLINE'.
8893 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8894 * alloc.c, fontset.c (INLINE): Remove.
8895 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8896 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8897 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8898 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8899 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8901 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8903 Make it possible to run ./temacs.
8905 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8906 syms_of_callproc does the same thing. Remove test for
8907 "initialized", do it in the caller.
8908 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8910 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8912 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8913 (read_minibuf): Use get_minibuffer.
8914 (syms_of_minibuf): Use DEFSYM.
8915 (Qmetadata): New var.
8916 * data.c (Qbuffer): Don't make it static.
8917 (syms_of_data): Use DEFSYM.
8919 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8921 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8922 (CCL_CODE_MIN): New macro.
8924 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8926 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8928 * eval.c (Qdebug): Now static.
8929 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8930 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8931 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8933 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8935 * image.c: Various fixes to ImageMagick code comments.
8936 (Fimagemagick_types): Doc fix.
8938 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8940 Minor fixes prompted by GCC 4.6.0 warnings.
8942 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8944 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8945 (x_clipboard_manager_save_all): Move extern decl to ...
8946 * xterm.h: ... here, so that it can be checked for consistency.
8948 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8950 * xselect.c (x_clipboard_manager_save_frame)
8951 (x_clipboard_manager_save_all): New functions.
8952 (Fx_clipboard_manager_save): Lisp function deleted.
8954 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8955 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8957 * xterm.h: Update prototype.
8959 2011-05-28 William Xu <william.xwl@gmail.com>
8961 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8964 2011-05-28 Jim Meyering <meyering@redhat.com>
8966 Avoid a sign-extension bug in crypto_hash_function.
8967 * fns.c (to_uchar): Define.
8968 (crypto_hash_function): Use it to convert some newly-signed
8969 variables to unsigned, to avoid sign-extension bugs. For example,
8970 without this change, (md5 "truc") would evaluate to
8971 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8972 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8973 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8975 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8977 Integer overflow fixes.
8979 * dbusbind.c: Serial number integer overflow fixes.
8980 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8981 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8982 to hold a serial number that is too large for a fixnum.
8983 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8984 Check for serial numbers out of range. Decode any serial number
8985 that was so large that it became a float. (Bug#8722)
8987 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8988 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8989 Use XFASTINT rather than XUINT when numbers are nonnegative.
8990 (xd_append_arg, Fdbus_method_return_internal):
8991 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8992 arguments, check that Lisp number is nonnegative, rather than
8993 silently wrapping negative numbers around. (Bug#8722)
8994 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8997 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8999 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9001 ccl: Add integer overflow checks.
9002 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9003 (IN_INT_RANGE): New macros.
9004 (ccl_driver): Use them to check for integer overflow when
9005 decoding a CCL program. Many of the new checks are whether XINT (x)
9006 fits in int; it doesn't always, on 64-bit hosts. The new version
9007 doesn't catch all possible integer overflows, but it's an
9008 improvement. (Bug#8719)
9010 * alloc.c (make_event_array): Use XINT, not XUINT.
9011 There's no need for unsigned here.
9013 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9014 This follows up to the 2011-05-06 change that substituted uintptr_t
9015 for EMACS_INT. This case wasn't caught back then.
9017 Rework Fformat to avoid integer overflow issues.
9018 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9019 now (part of C89). Include <verify.h>.
9020 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9021 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9022 (Fformat): Avoid the prepass trying to compute sizes; it was only
9023 approximate and thus did not catch overflow reliably. Instead, walk
9024 through the format just once, formatting and computing sizes as we go,
9025 checking for integer overflow at every step, and allocating a larger
9026 buffer as needed. Keep track separately whether the format is
9027 multibyte. Keep only the most-recently calculated precision, rather
9028 than them all. Record whether each argument has been converted to
9029 string. Use EMACS_INT, not int, for byte and char and arg counts.
9030 Support field widths and precisions larger than INT_MAX. Avoid
9031 sprintf's undefined behavior with conversion specifications such as %#d
9032 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9033 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9034 formatting out-of-range floating point numbers with int
9037 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9039 * data.c: Avoid integer truncation in expressions involving floats.
9040 * data.c: Include <intprops.h>.
9041 (arith_driver): When there's an integer overflow in an expression
9042 involving floating point, convert the integers to floating point
9043 so that the resulting value does not suffer from catastrophic
9044 integer truncation. For example, on a 64-bit host (* 4
9045 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9046 Do not rely on undefined behavior after integer overflow.
9048 merge count_size_as_multibyte, parse_str_to_multibyte
9049 * character.c, character.h (count_size_as_multibyte):
9050 Rename from parse_str_to_multibyte; all uses changed.
9051 Check for integer overflow.
9052 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9053 since it's now a duplicate of the other. This is more of
9054 a character than a buffer op, so better that it's in character.c.
9055 * fns.c, print.c: Adjust to above changes.
9057 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9059 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9061 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9063 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9064 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9065 (x_clipboard_manager_save): Now static.
9066 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9068 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9069 (crypto_hash_function): Now static.
9070 Fix pointer signedness problems. Avoid unnecessary initializations.
9072 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9074 * termhooks.h (Vselection_alist): Make it terminal-local.
9076 * terminal.c (create_terminal): Initialize it.
9078 * xselect.c: Support for clipboard managers.
9079 (Vselection_alist): Move to termhooks.h as terminal-local var.
9080 (LOCAL_SELECTION): New macro.
9081 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9082 (symbol_to_x_atom): Remove gratuitous arg.
9083 (x_handle_selection_request, lisp_data_to_selection_data)
9084 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9085 (x_own_selection, x_get_local_selection, x_convert_selection):
9086 New arg, specifying work frame. Use terminal-local Vselection_alist.
9087 (some_frame_on_display): Delete unused function.
9088 (Fx_own_selection_internal, Fx_get_selection_internal)
9089 (Fx_disown_selection_internal, Fx_selection_owner_p)
9090 (Fx_selection_exists_p): New optional frame arg.
9091 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9092 (x_handle_selection_clear): Don't treat other terminals with the
9093 same keyboard specially. Use the terminal-local Vselection_alist.
9094 (x_clear_frame_selections): Use Frun_hook_with_args.
9096 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9098 * xterm.h: Add support for those atoms.
9100 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9102 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9103 (converted_selections, conversion_fail_tag): New global variables.
9104 (x_selection_request_lisp_error): Free the above.
9105 (x_get_local_selection): Remove unnecessary code.
9106 (x_reply_selection_request): Args changed; handle arbitrary array
9107 of converted selections stored in converted_selections.
9108 Separate the XChangeProperty and SelectionNotify steps.
9109 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9110 (x_convert_selection): New function.
9111 (x_handle_selection_event): Simplify.
9112 (x_get_foreign_selection): Don't ignore incoming requests while
9113 waiting for an answer; this will fail when we implement
9114 SAVE_TARGETS, and seems unnecessary anyway.
9115 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9116 (Vx_sent_selection_functions): Doc fix.
9118 2011-05-26 Leo Liu <sdl.web@gmail.com>
9120 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9122 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9124 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9126 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9127 for fringe update if it has periodic bitmap.
9128 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
9129 and fringe_bitmap_periodic_p.
9131 * fringe.c (get_fringe_bitmap_data): New function.
9132 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9133 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9134 row. Mark glyph row for fringe update if periodicity changed.
9136 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9137 for fringe update unless it has periodic bitmap.
9139 2011-05-25 Kenichi Handa <handa@m17n.org>
9141 * xdisp.c (get_next_display_element): Set correct it->face_id for
9142 a static composition.
9144 2011-05-24 Leo Liu <sdl.web@gmail.com>
9147 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9149 * fns.c (crypto_hash_function, Fsha1): New function.
9150 (Fmd5): Use crypto_hash_function.
9151 (syms_of_fns): Add Ssha1.
9153 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9155 * gnutls.c: Remove unused macros.
9156 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9157 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9158 Remove macros that are defined and never used.
9159 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9161 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9163 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9164 (Fx_get_selection_internal): Minor cleanup.
9165 (Fx_own_selection_internal): Rename arguments for consistency with
9168 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9170 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9172 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9174 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9176 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9178 * dispnew.c (scrolling_window): Don't exclude the case that the
9179 last enabled row in the desired matrix touches the bottom boundary.
9181 2011-05-21 Glenn Morris <rgm@gnu.org>
9183 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9184 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9185 and add some more files.
9187 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9189 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9190 report_file_error introduced by the change from 2011-05-07.
9192 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9194 * systime.h (Time): Define only if emacs is defined.
9195 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9196 where the include path doesn't have X11/X.h by default. See
9197 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9199 2011-05-20 Kenichi Handa <handa@m17n.org>
9201 * composite.c (find_automatic_composition): Fix previous change.
9203 2011-05-20 Glenn Morris <rgm@gnu.org>
9205 * lisp.mk: New file, split from Makefile.in.
9206 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9207 (shortlisp): Remove.
9208 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9210 2011-05-19 Glenn Morris <rgm@gnu.org>
9212 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9213 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9214 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9215 (lisp): Set the order to that of loadup.el.
9216 (shortlisp): Make it a copy of $lisp.
9217 (SOME_MACHINE_LISP): Remove.
9218 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9219 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9221 2011-05-18 Kenichi Handa <handa@m17n.org>
9223 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9224 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9225 (find_automatic_composition): Mostly rewrite for efficiency.
9227 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9229 * makefile.w32-in: Update dependencies.
9231 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9233 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9234 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9236 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
9238 Fix some integer overflow issues, such as string length overflow.
9240 * insdel.c (count_size_as_multibyte): Check for string overflow.
9242 * character.c (lisp_string_width): Check for string overflow.
9243 Use EMACS_INT, not int, for string indexes and lengths; in
9244 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9245 the resulting string length overflows an EMACS_INT; instead,
9246 report a string overflow if no precision given. When checking for
9247 precision exhaustion, use a check that cannot possibly have
9248 integer overflow. (Bug#8675)
9249 * character.h (lisp_string_width): Adjust to new signature.
9251 * alloc.c (string_overflow): New function.
9252 (Fmake_string): Use it. This doesn't change behavior, but saves
9253 a few bytes and will simplify future changes.
9254 * character.c (string_escape_byte8): Likewise.
9255 * lisp.h (string_overflow): New decl.
9257 Fixups, following up to the user-interface timestamp change.
9258 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9259 for UI timestamps, instead of unsigned long.
9260 * msdos.c (mouse_get_pos): Likewise.
9261 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
9262 * w32gui.h (Time): Define by including "systime.h" rather than by
9263 declaring it ourselves. (Bug#8664)
9265 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9266 * image.c (clear_image_cache): Likewise.
9268 * term.c (term_mouse_position): Don't assume time_t wraparound.
9270 Be more systematic about user-interface timestamps.
9271 Before, the code sometimes used 'Time', sometimes 'unsigned long',
9272 and sometimes 'EMACS_UINT', to represent these timestamps.
9273 This change causes it to use 'Time' uniformly, as that's what X uses.
9274 This makes the code easier to follow, and makes it easier to catch
9275 integer overflow bugs such as Bug#8664.
9276 * frame.c (Fmouse_position, Fmouse_pixel_position):
9277 Use Time, not unsigned long, for user-interface timestamps.
9278 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9279 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9280 * keyboard.h (last_event_timestamp): Likewise.
9281 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9282 * menu.h (xmenu_show): Likewise.
9283 * term.c (term_mouse_position): Likewise.
9284 * termhooks.h (struct input_event.timestamp): Likewise.
9285 (struct terminal.mouse_position_hook): Likewise.
9286 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9287 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9288 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9289 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9291 * menu.h, termhooks.h: Include "systime.h", for Time.
9293 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9294 Don't assume that the difference between two unsigned long values
9295 can fit into an integer. At this point, we know button_down_time
9296 <= event->timestamp, so the difference must be nonnegative, so
9297 there's no need to cast the result if double-click-time is
9298 nonnegative, as it should be; check that it's nonnegative, just in
9299 case. This bug is triggered when events are more than 2**31 ms
9300 apart (about 25 days). (Bug#8664)
9302 * xselect.c (last_event_timestamp): Remove duplicate decl.
9303 (x_own_selection): Remove needless cast to unsigned long.
9305 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9306 that always fit in int. Use a sentinel instead of a counter, to
9307 avoid a temp and to allay GCC's concerns about possible int overflow.
9308 * frame.h (struct frame): Use int for menu_bar_items_used
9309 instead of EMACS_INT, since it always fits in int.
9311 * menu.c (grow_menu_items): Check for int overflow.
9313 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9315 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9316 Before, the code was not consistent. These values cannot exceed
9317 2**31 - 1 so there's no need to make them unsigned.
9318 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9319 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9320 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9322 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9324 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9325 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9326 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9327 presumably because the widths might not match.
9329 * window.c (size_window): Avoid needless test at loop start.
9331 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9333 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9335 2011-05-12 Drew Adams <drew.adams@oracle.com>
9337 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9339 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9341 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9342 `width' to `bar_area_x' and `bar_area_width', respectively.
9343 (x_scroll_run): Take account of fringe background extension.
9345 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9346 Rename local vars `left' and `width' to `bar_area_x' and
9347 `bar_area_width', respectively.
9348 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9349 background extension.
9351 2011-05-10 Jim Meyering <meyering@redhat.com>
9353 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9355 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
9357 * image.c (Finit_image_library): Return t for built-in image types,
9358 like pbm and xbm. (Bug#8640)
9360 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9362 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9364 2011-05-07 Eli Zaretskii <eliz@gnu.org>
9366 * w32console.c (Fset_screen_color): Doc fix.
9367 (Fget_screen_color): New function.
9368 (syms_of_ntterm): Defsubr it.
9370 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9371 unlink the temporary file if Fcall_process didn't create it in the
9373 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9374 child process will be redirected to a file specified with `:file'.
9375 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9376 cue to call_process_cleanup not to close that handle.
9378 2011-05-07 Ben Key <bkey76@gmail.com>
9380 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9381 one of two shell specific rules, either bootstrap-temacs-CMD or
9382 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9383 to the previous implementation of the bootstrap-temacs rule.
9384 The bootstrap-temacs-CMD rule is similar to the previous
9385 implementation of the bootstrap-temacs rule except that it
9386 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9389 These changes, along with some changes to nt/configure.bat,
9390 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9391 earlier fix to add support for --cflags and --ldflags options
9392 that include quotes so that it works whether make uses cmd or
9395 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
9397 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9398 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9400 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9401 a string. Handle both cases.
9402 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9403 (Fdbus_register_method): Use Qinvalid_function.
9405 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9407 * makefile.w32-in: Update dependencies.
9408 (LISP_H): Add inttypes.h and stdin.h.
9409 (PROCESS_H): Add unistd.h.
9411 2011-05-06 Eli Zaretskii <eliz@gnu.org>
9413 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9414 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9416 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
9418 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9420 * term.c (vfatal): Remove stray call to va_end.
9421 It's not needed and the C Standard doesn't allow it here anyway.
9423 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9424 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9426 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9429 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9431 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9433 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9435 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9437 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9439 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9440 * charset.c (Fdefine_charset_internal): Don't initialize
9441 charset.code_space[15]. The value was garbage, on hosts with
9442 32-bit int (Bug#8600).
9444 * lread.c (read_integer): Be more consistent with string-to-number.
9445 Use string_to_number to do the actual conversion; this avoids
9446 rounding errors and fixes some other screwups. Without this fix,
9447 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9448 (digit_to_number): Move earlier, for benefit of read_integer.
9449 Return -1 if the digit is out of range for the base, -2 if it is
9450 not a digit in any supported base. (Bug#8602)
9452 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9454 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9455 to match comment at start of function. This also removes a
9456 GCC warning about overflow in a 32+64-bit port.
9458 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9460 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9461 Reported by Stefan Monnier in
9462 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
9463 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9464 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
9466 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9467 (EMACS_UINTPTR): Likewise, with uintptr_t.
9469 * lisp.h: Prefer 64-bit EMACS_INT if available.
9470 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9471 on 32-bit hosts that have 64-bit int, so that they can access
9473 However, temporarily disable this change unless the temporary
9474 symbol WIDE_EMACS_INT is defined.
9476 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9478 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9479 This removes an assumption that EMACS_INT and long are the same
9480 width as pointers. The assumption is true for Emacs porting targets
9481 now, but we want to make other targets possible.
9482 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9483 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9484 In the rest of the code, change types of integers that hold casted
9485 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9486 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9487 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9488 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9489 No need to cast type when ORing.
9490 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9491 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9492 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9493 assume EMACS_INT is the same width as char *.
9494 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9495 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9496 Remove no-longer-needed casts.
9497 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9498 (xg_tool_bar_help_callback, xg_make_tool_item):
9499 Use EMACS_INTPTR to hold an integer
9500 that will be cast to void *; this can avoid a GCC warning
9501 if EMACS_INT is not the same width as void *.
9502 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9503 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9504 (current_message_1, set_message_1):
9505 Use a local to convert to proper width without a cast.
9506 * xmenu.c (dialog_selection_callback): Likewise.
9508 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9509 Also, don't assume VALBITS / RAND_BITS is less than 5,
9510 and don't rely on undefined behavior when shifting a 1 left into
9512 * lisp.h (get_random): Change signature to match.
9514 * lread.c (hash_string): Use size_t, not int, for hash computation.
9515 Normally we prefer signed values; but hashing is special, because
9516 it's better to use unsigned division on hash table sizes so that
9517 the remainder is nonnegative. Also, size_t is the natural width
9518 for hashing into memory. The previous code used 'int', which doesn't
9519 retain enough info to hash well into very large tables.
9520 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9522 * dbusbind.c: Don't possibly lose pointer info when converting.
9523 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9524 Use XPNTR rather than XHASH, so that the high-order bits of
9525 the pointer aren't lost when converting through void *.
9527 * eval.c (Fautoload): Don't double-shift a pointer.
9529 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9531 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9533 * gnutls.c (DEF_GNUTLS_FN):
9534 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9536 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9538 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9541 2011-05-05 Eli Zaretskii <eliz@gnu.org>
9543 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9544 New version that can reserve upto 2GB of heap space.
9546 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
9548 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9550 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9552 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9553 `gnutls_certificate_set_x509_key_file'.
9555 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
9557 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9558 Update dependencies.
9560 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9562 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9563 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9564 Remove unused parameter `fildes'.
9565 * process.c (read_process_output, send_process): Don't pass it.
9567 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9569 Fix previous change: the library cache is defined in w32.c.
9570 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9571 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9573 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9575 Implement dynamic loading of GnuTLS on Windows.
9577 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9578 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9579 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9582 * gnutls.c (Qgnutls_dll): Define.
9583 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9584 (gnutls_*): Declare function pointers.
9585 (init_gnutls_functions): New function to initialize function pointers.
9586 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9587 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9588 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9589 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9590 (emacs_gnutls_write, emacs_gnutls_read)
9591 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9592 (Fgnutls_available_p): New function.
9593 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9594 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9595 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9597 * image.c: Include w32.h.
9598 (Vimage_type_cache): Delete.
9599 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9600 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9601 (w32_delayed_load): Move to w32.c.
9603 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9605 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9606 (w32_delayed_load): Move from image.c. When loading a library, record
9607 its filename in the :loaded-from property of the library id.
9608 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9609 Initialize and staticpro them.
9610 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9612 * process.c: Include lisp.h before w32.h, not after.
9613 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9614 instead of gnutls_record_check_pending.
9616 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9618 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9620 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9621 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9624 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9626 * xterm.c (x_set_frame_alpha): Do not set property on anything
9627 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9629 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9631 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9633 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9635 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9636 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9637 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9638 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9639 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9640 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9641 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9642 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9643 (Qgnutls_bootprop_callbacks_verify): Make static.
9645 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9647 * callproc.c: Indentation fixup.
9649 * sysdep.c (wait_for_termination_1): Make static.
9650 (wait_for_termination, interruptible_wait_for_termination):
9651 Move after wait_for_termination_1.
9653 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9655 * sysdep.c (interruptible_wait_for_termination): New function
9656 which is like wait_for_termination, but allows keyboard
9659 * callproc.c (Fcall_process): Add (:file "file") as an option for
9661 (Fcall_process_region): Ditto.
9663 2011-04-30 Eli Zaretskii <eliz@gnu.org>
9665 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9666 rather than `XVECTOR (FOO)->size'.
9668 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9669 inttypes.h, as a gnulib replacement is used if it not available in
9672 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9674 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9675 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9676 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9678 * coding.c (coding_alloc_by_realloc): Error out if destination
9679 will grow beyond MOST_POSITIVE_FIXNUM.
9680 (decode_coding_emacs_mule): Abort if there isn't enough place in
9681 charbuf for the composition carryover bytes. Reserve an extra
9682 space for up to 2 characters produced in a loop.
9683 (decode_coding_iso_2022): Abort if there isn't enough place in
9684 charbuf for the composition carryover bytes.
9686 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9688 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9689 aborting when %lld or %lll format is passed.
9690 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9691 %llo or %llx format is passed. (Bug#8545)
9693 * window.c (window_scroll_line_based): Use a marker instead of
9694 simple variables to record original value of point. (Bug#7952)
9696 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9697 produced by %s or %c overflows available buffer space. (Bug#8545)
9699 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9701 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
9702 (SIZE_MAX): Move defn after all includes, as they might #define it.
9704 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9706 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9708 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9710 * keyboard.c (Qdelayed_warnings_hook): Define.
9711 (command_loop_1): Run `delayed-warnings-hook'
9712 if Vdelayed_warnings_list is non-nil.
9713 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9714 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9716 2011-04-28 Eli Zaretskii <eliz@gnu.org>
9718 * doprnt.c (doprnt): Don't return value smaller than the buffer
9719 size if the message was truncated. (Bug#8545).
9721 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9723 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9724 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9726 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9728 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9730 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
9732 * makefile.w32-in: Update dependencies.
9734 2011-04-27 Eli Zaretskii <eliz@gnu.org>
9736 Improve `doprnt' and its usage. (Bug#8545)
9737 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9738 `format_end'. Remove support for %l as a conversion specifier.
9739 Don't use xrealloc. Improve diagnostics when the %l size modifier
9740 is used. Update the commentary.
9742 * eval.c (verror): Simplify calculation of size_t.
9744 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9747 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9749 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9752 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9754 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9755 This makes this file independent of the recent pseudovector change.
9757 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
9759 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9761 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
9762 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
9763 Remove unused local.
9764 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
9766 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
9767 GCC 4.6.0 optimizes based on type-based alias analysis.
9768 For example, if b is of type struct buffer * and v of type struct
9769 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9770 != &v->size, and therefore "v->size = 1; b->size = 2; return
9771 v->size;" must therefore return 1. This assumption is incorrect
9772 for Emacs, since it type-puns struct Lisp_Vector * with many other
9773 types. To fix this problem, this patch adds a new type struct
9774 vectorlike_header that documents the constraints on layout of vectors
9775 and pseudovectors, and helps optimizing compilers not get fooled
9776 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9777 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
9778 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9780 (XSETPVECTYPE): Rewrite in terms of new macro.
9781 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9782 This is a bit clearer, and further avoids the possibility of
9783 undesirable aliasing.
9784 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
9785 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
9786 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9787 since Lisp_Subr is a special case (no "next" field).
9788 (ASIZE): Now uses header.size rather than size.
9789 All previous uses of XVECTOR (foo)->size replaced to use this macro,
9790 to avoid the hassle of writing XVECTOR (foo)->header.size.
9791 (struct vectorlike_header): New type.
9792 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9793 object, to help avoid aliasing.
9794 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9795 (SUBRP): Likewise, since Lisp_Subr is a special case.
9796 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9797 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9798 (struct Lisp_Hash_Table): Combine first two members into a single
9799 struct vectorlike_header member. All uses of "size" and "next" members
9800 changed to be "header.size" and "header.next".
9801 * buffer.h (struct buffer): Likewise.
9802 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9803 * frame.h (struct frame): Likewise.
9804 * process.h (struct Lisp_Process): Likewise.
9805 * termhooks.h (struct terminal): Likewise.
9806 * window.c (struct save_window_data, struct saved_window): Likewise.
9807 * window.h (struct window): Likewise.
9808 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9809 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9810 * buffer.c (init_buffer_once): Likewise.
9811 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9813 * process.c (Fformat_network_address): Use local var for size,
9816 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9818 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9819 * data.c (atof): Remove decl; no longer used or needed.
9820 (digit_to_number): Move to lread.c.
9821 (Fstring_to_number): Use new string_to_number function, to be
9822 consistent with how the Lisp reader treats infinities and NaNs.
9823 Do not assume that floating-point numbers represent EMACS_INT
9824 without losing information; this is not true on most 64-bit hosts.
9825 Avoid double-rounding errors, by insisting on integers when
9826 parsing non-base-10 numbers, as the documentation specifies.
9827 * lisp.h (string_to_number): New decl, replacing ...
9828 (isfloat_string): Remove.
9829 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9830 (read1): Do not accept +. and -. as integers; this
9831 appears to have been a coding error. Similarly, do not accept
9832 strings like +-1e0 as floating point numbers. Do not report
9833 overflow for integer overflows unless the base is not 10 which
9834 means we have no simple and reliable way to continue.
9835 Break out the floating-point parsing into a new
9836 function string_to_number, so that Fstring_to_number parses
9837 floating point numbers consistently with the Lisp reader.
9838 (digit_to_number): Move here from data.c. Make it static inline.
9839 (E_CHAR, EXP_INT): Remove, replacing with ...
9840 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9841 (string_to_number): New function, replacing isfloat_string.
9842 This function checks for valid syntax and produces the resulting
9843 Lisp float number too. Rework it so that string-to-number
9844 no longer mishandles examples like "1.0e+". Use strtoumax,
9845 so that overflow for non-base-10 numbers is reported only when
9846 there's no portable and simple way to convert to floating point.
9848 * textprop.c (set_text_properties_1): Rewrite for clarity,
9849 and to avoid GCC warning about integer overflow.
9851 * intervals.h (struct interval): Use EMACS_INT for members
9852 where EMACS_UINT might cause problems. See
9853 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9854 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9855 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9857 (offset_intervals): Tell GCC not to worry about length overflow
9858 when negating a negative length.
9860 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9861 (overrun_check_free): Likewise.
9863 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9864 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9867 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9868 (gnutls_make_error): Rename local to avoid shadowing.
9869 (gnutls_emacs_global_deinit): ifdef out; not used.
9870 (Fgnutls_boot): Use const for pointer to readonly storage.
9871 Comment out unused local. Fix pointer signedness problems.
9873 * lread.c (openp): Don't stuff size_t into an 'int'.
9874 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9875 about possible signed overflow.
9877 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9878 (GDK_KEY_g): Don't define if already defined.
9879 (xg_prepare_tooltip): Avoid pointer signedness problem.
9880 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9882 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9883 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9885 * xfns.c (Fx_window_property): Simplify a bit,
9886 to make a bit faster and to avoid GCC 4.6.0 warning.
9887 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9889 * fns.c (internal_equal): Don't assume size_t fits in int.
9891 * alloc.c (compact_small_strings): Tighten assertion a little.
9893 Replace pEd with more-general pI, and fix some printf arg casts.
9894 * lisp.h (pI): New macro, generalizing old pEd macro to other
9895 conversion specifiers. For example, use "...%"pI"d..." rather
9896 than "...%"pEd"...".
9897 (pEd): Remove. All uses replaced with similar uses of pI.
9898 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9899 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9900 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9901 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9902 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9903 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9904 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9906 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9907 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9908 * print.c (safe_debug_print, print_object): Likewise.
9909 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9911 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9912 avoiding the 0 flag, which is not portable.
9913 * process.c (Fmake_network_process): Use pI to avoid cast.
9914 * region-cache.c (pp_cache): Likewise.
9915 * xdisp.c (decode_mode_spec): Likewise.
9916 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9917 behavior on 64-bit hosts with printf arg.
9918 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9919 (x_stop_queuing_selection_requests): Likewise.
9920 (x_get_window_property): Don't truncate byte count to an 'int'
9923 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9924 here, since it parses constructs like leading '-' and spaces,
9925 which are not wanted; and it overflows with large numbers.
9926 Instead, simply match F[0-9]+, which is what is wanted anyway.
9928 * alloc.c: Remove unportable assumptions about struct layout.
9929 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9930 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9931 (allocate_vectorlike, make_pure_vector): Use the new macros,
9932 plus offsetof, to remove unportable assumptions about struct layout.
9933 These assumptions hold on all porting targets that I know of, but
9934 they are not guaranteed, they're easy to remove, and removing them
9935 makes further changes easier.
9937 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9938 This doesn't fix a bug but makes the code clearer.
9939 (string_overrun_cookie): Now const. Use initializers that
9940 don't formally overflow signed char, to avoid warnings.
9941 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9942 can cause Emacs to crash when string overrun checking is enabled.
9943 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9944 multiple of sizeof (EMACS_INT); it need not be, if
9945 alignof(EMACS_INT) < sizeof (EMACS_INT).
9946 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9948 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9950 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9952 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9954 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9955 supposed to be handshaking. (Bug#8556)
9956 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9958 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9960 * lisp.h (Qdebug): List symbol.
9961 * eval.c (Qdebug): Restore global linkage.
9962 * keyboard.c (debug-on-event): New variable.
9963 (handle_user_signal): Break into debugger when debug-on-event
9964 matches the current signal symbol.
9966 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9968 * alloc.c (check_sblock, check_string_bytes)
9969 (check_string_free_list): Convert to standard C.
9971 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9973 * w32.c (emacs_gnutls_push): Fix typo.
9975 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9977 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9978 "cast to pointer from integer of different size".
9980 Improve doprnt and its use in verror. (Bug#8545)
9981 * doprnt.c (doprnt): Document the set of format control sequences
9982 supported by the function. Use SAFE_ALLOCA instead of always
9985 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9986 is one byte too soon. Don't use xrealloc; instead xfree and
9989 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9991 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9994 * gnutls.c: Renamed global_initialized to
9995 gnutls_global_initialized. Added internals for the
9996 :verify-hostname-error, :verify-error, and :verify-flags
9997 parameters of `gnutls-boot' and documented those parameters in the
9998 docstring. Start callback support.
9999 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10000 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10001 on error. Return error code.
10002 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10003 (emacs_gnutls_read): Likewise.
10004 (Fgnutls_boot): Return handshake error code.
10005 (emacs_gnutls_handle_error): New function.
10006 (wsaerror_to_errno): Likewise.
10008 * w32.h (emacs_gnutls_pull): Add prototype.
10009 (emacs_gnutls_push): Likewise.
10011 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10012 (emacs_gnutls_push): Likewise.
10014 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10016 * process.c (wait_reading_process_output): Check if GnuTLS
10017 buffered some data internally if no FDs are set for TLS
10020 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10021 (LIBS): Link to USER_LIBS.
10022 ($(BLD)/gnutls.$(0)): New target.
10024 2011-04-24 Eli Zaretskii <eliz@gnu.org>
10026 * xdisp.c (handle_single_display_spec): Rename the
10027 display_replaced_before_p argument into display_replaced_p, to
10028 make it consistent with the commentary. Fix typos in the
10031 * textprop.c (syms_of_textprop): Remove dead code.
10032 (copy_text_properties): Delete obsolete commentary about an
10033 interface that was deleted long ago. Fix typos in the description
10036 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10037 to changes in oldXMenu/XMenu.h from 2011-04-16.
10038 <menu_help_message, prev_menu_help_message>: Constify.
10039 (IT_menu_make_room): menu->help_text is now `const char **';
10042 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10043 to changes in oldXMenu/XMenu.h from 2011-04-16.
10044 (struct XMenu): Declare `help_text' `const char **'.
10046 * xfaces.c <Qunspecified>: Make extern again.
10048 * syntax.c: Include sys/types.h before including regex.h, as
10051 * doc.c (get_doc_string): Improve the format passed to `error'.
10053 * doprnt.c (doprnt): Improve commentary.
10055 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10057 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10060 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10061 changes in globals.h immediately force recompilation.
10062 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10063 $(CURDIR)/s/ms-w32.h.
10064 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10066 * character.c (Fchar_direction): Function deleted.
10067 (syms_of_character): Don't defsubr it.
10068 <char-direction-table>: Deleted.
10070 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10072 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10073 * doprnt.c: Include limits.h.
10074 (SIZE_MAX): New macro.
10075 (doprnt): Return a size_t value. 2nd arg is now size_t.
10076 Many local variables are now size_t instead of int or unsigned.
10077 Improve overflow protection. Support `l' modifier for integer
10078 conversions. Support %l conversion. Don't assume an EMACS_INT
10079 argument for integer conversions and for %c.
10081 * lisp.h (doprnt): Restore prototype.
10083 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10084 $(SRC)/character.h.
10086 * Makefile.in (base_obj): Add back doprnt.o.
10088 * deps.mk (doprnt.o): Add back prerequisites.
10089 (callint.o): Depend on character.h.
10091 * eval.c (internal_lisp_condition_case): Include the handler
10092 representation in the error message.
10093 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10094 when breaking from the loop.
10096 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10098 * callint.c (Fcall_interactively): When displaying error message
10099 about invalid control letter, pass the character's codepoint, not
10100 a pointer to its multibyte form. Improve display of the character
10101 in octal and display also its hex code.
10103 * character.c (char_string): Use %x to display the (unsigned)
10104 codepoint of an invalid character, to avoid displaying a bogus
10107 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10108 `error', not SYMBOL_NAME itself.
10110 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10111 character arguments to `error'.
10113 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10114 to `error' in error message about FINAL_CHAR argument. Make sure
10115 FINAL_CHAR is a character, and use %c when it is passed as
10116 argument to `error'.
10118 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10120 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10122 * w32.c: Include <time.h>.
10123 (sys_localtime): New function.
10125 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10127 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10129 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
10131 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
10133 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10134 zombies (Bug#8467).
10136 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10138 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10139 gl_state.e_property when gl_state.object is Qt.
10141 * insdel.c (make_gap_larger): Remove limitation of buffer size
10144 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10146 * xdisp.c (lookup_glyphless_char_display)
10147 (produce_glyphless_glyph): Handle cons cell entry in
10148 glyphless-char-display.
10149 (Vglyphless_char_display): Document it.
10151 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10152 glyphless-char-display.
10154 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10156 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10158 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10160 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10161 definition for no-X builds.
10163 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10165 Static checks with GCC 4.6.0 and non-default toolkits.
10167 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10169 * process.c (keyboard_bit_set): Define only if SIGIO.
10170 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10171 (send_process): Repair possible setjmp clobbering.
10173 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10175 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10177 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10179 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10180 Define only if needed.
10182 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10183 by pacifying GCC about it. Maybe it's time to retire it?
10184 * xfaces.c (USG, __TIMEVAL__): Likewise.
10186 * dispextern.h (struct redisplay_interface): Rename param
10187 to avoid shadowing.
10188 * termhooks.h (struct terminal): Likewise.
10189 * xterm.c (xembed_send_message): Likewise.
10191 * insdel.c (make_gap_smaller): Define only if
10192 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10194 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10197 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10198 so that we aren't warned about unused symbols.
10200 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10202 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10204 * xfns.c (x_real_positions): Mark locals as initialized.
10206 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10208 * xterm.c: Fix problems found by static analysis with other toolkits.
10209 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10210 (x_dispatch_event): Declare static if USE_GTK, and
10211 define if USE_GTK || USE_X_TOOLKIT.
10212 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10213 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10214 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10215 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10217 * xmenu.c (menu_help_callback): Pointer type fixes.
10218 Use const pointers when pointing at readonly data. Avoid pointer
10219 signedness clashes.
10220 (FALSE): Remove unused macro.
10221 (update_frame_menubar): Remove unused decl.
10223 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10225 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10226 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10227 (single_menu_item): Rename local to avoid shadowing.
10229 * keyboard.c (make_lispy_event): Remove unused local var.
10231 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10232 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10234 * bitmaps: Change bitmaps from unsigned char back to the X11
10235 compatible char. Avoid the old compiler warnings about
10236 out-of-range initializers by using, for example, '\xab' rather
10239 * xgselect.c (xgselect_initialize): Check vs interface
10240 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10242 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10244 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10245 to read-only memory.
10247 * fns.c (vector): Remove; this old hack is no longer needed.
10249 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
10251 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
10253 * xrdb.c (x_load_resources): Omit unused local.
10255 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
10256 (x_window): Rename locals to avoid shadowing.
10257 (USG): Use the kludged USG macro, to pacify gcc.
10259 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
10260 (x_term_init): Remove local to avoid shadowing.
10262 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
10264 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10265 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10267 2011-04-16 Eli Zaretskii <eliz@gnu.org>
10269 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10271 Fix regex.c, syntax.c and friends for buffers > 2GB.
10272 * syntax.h (struct gl_state_s): Declare character position members
10275 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10277 * textprop.c (verify_interval_modification, interval_of):
10278 Declare arguments EMACS_INT.
10280 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10283 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10285 * indent.c (Fvertical_motion): Local variable it_start is now
10288 * regex.c (re_match, re_match_2, re_match_2_internal)
10289 (bcmp_translate, regcomp, regexec, print_double_string)
10290 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10291 (re_compile_pattern, re_exec): Declare arguments and local
10292 variables `size_t' and `ssize_t' and return values `regoff_t', as
10294 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10295 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10296 <compile_stack_type>: `size' and `avail' are now `size_t'.
10298 * regex.h <regoff_t>: Use ssize_t, not int.
10299 (re_search, re_search_2, re_match, re_match_2): Arguments that
10300 specify buffer/string position and length are now ssize_t and
10301 size_t. Return type is regoff_t.
10303 2011-04-16 Ben Key <bkey76@gmail.com>
10305 * nsfont.m: Fixed bugs in ns_get_family and
10306 ns_descriptor_to_entity that were caused by using free to
10307 deallocate memory blocks that were allocated by xmalloc (via
10308 xstrdup). This caused Emacs to crash when compiled with
10309 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10310 --enable-checking=xmallocoverrun). xfree is now used to
10311 deallocate these memory blocks.
10313 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
10315 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10317 emacs_write: Accept and return EMACS_INT for sizes.
10318 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10320 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10321 Accept and return EMACS_INT.
10322 (emacs_gnutls_write): Return the number of bytes written on
10324 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
10325 (emacs_read, emacs_write): Remove check for negative size, as the
10326 Emacs source code has been audited now.
10327 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10328 (emacs_read, emacs_write): Use it.
10329 * process.c (send_process): Adjust to the new signatures of
10330 emacs_write and emacs_gnutls_write. Do not attempt to store
10331 a byte offset into an 'int'; it might overflow.
10332 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
10334 * sound.c: Don't assume sizes fit in 'int'.
10335 (struct sound_device.period_size, alsa_period_size):
10336 Return EMACS_INT, not int.
10337 (struct sound_device.write, vox_write, alsa_write):
10338 Accept EMACS_INT, not int.
10339 (wav_play, au_play): Use EMACS_INT to store sizes and to
10340 record read return values.
10342 2011-04-15 Ben Key <bkey76@gmail.com>
10344 * keyboard.c (Qundefined): Don't declare static since it is used
10346 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10347 static since they are used in nsfont.m.
10349 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10351 * process.c (Qprocessp): Don't declare static.
10352 * lisp.h (Qprocessp): Declare again.
10354 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
10356 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10358 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10360 Improve C-level modularity by making more things 'static'.
10362 Don't publish debugger-only interfaces to other modules.
10363 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10364 (verify_bytepos, count_markers): Move decls to the only modules
10366 * region-cache.h (pp_cache): Likewise.
10367 * window.h (check_all_windows): Likewise.
10368 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10370 * sysdep.c (croak): Now static, if
10371 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10372 * syssignal.h (croak): Declare only if not static.
10374 * alloc.c (refill_memory_reserve): Now static if
10375 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10376 * lisp.h (refill_memory_reserve): Declare only if not static.
10378 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10379 Define only if USE_LUCID.
10381 * xrdb.c (x_customization_string, x_rm_string): Now static.
10383 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10384 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10386 * xdisp.c (draw_row_with_mouse_face): Now static.
10387 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10389 * window.h (check_all_windows): Mark externally visible.
10391 * window.c (window_deletion_count): Now static.
10393 * undo.c: Make symbols static if they're not exported.
10394 (last_undo_buffer, last_boundary_position, pending_boundary):
10397 * textprop.c (interval_insert_behind_hooks): Now static.
10398 (interval_insert_in_front_hooks): Likewise.
10400 * term.c: Make symbols static if they're not exported.
10401 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10402 (max_frame_lines, tty_set_terminal_modes):
10403 (tty_reset_terminal_modes, tty_turn_off_highlight):
10404 (get_tty_terminal): Now static.
10405 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10406 * termhooks.h (term_mouse_moveto): Do not declare if
10407 HAVE_WINDOW_SYSTEM.
10408 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10409 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10411 * sysdep.c: Make symbols static if they're not exported.
10412 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10414 (sigprocmask_set, full_mask): Remove; unused.
10415 (wait_debugging): Mark as visible.
10416 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10417 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10419 * syntax.c (syntax_temp): Define only if !__GNUC__.
10421 * sound.c (current_sound_device, current_sound): Now static.
10423 * search.c (searchbufs, searchbuf_head): Now static.
10425 * scroll.c (scroll_cost): Remove; unused.
10426 * dispextern.h (scroll_cost): Remove decl.
10428 * region-cache.h (pp_cache): Mark as externally visible.
10430 * process.c: Make symbols static if they're not exported.
10431 (process_tick, update_tick, create_process, chan_process):
10432 (Vprocess_alist, proc_buffered_char, datagram_access):
10433 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10434 (deactivate_process): Mark defn as static, as well as decl.
10435 * lisp.h (create_process): Remove decl.
10436 * process.h (chan_process, Vprocess_alist): Remove decls.
10438 * print.c: Make symbols static if they're not exported.
10439 (print_depth, new_backquote_output, being_printed, print_buffer):
10440 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10441 (print_interval, print_number_index, initial_stderr_stream):
10443 * lisp.h (Fprinc): Remove decl.
10444 (debug_output_compilation_hack): Mark as externally visible.
10446 * sysdep.c (croak): Move decl from here to syssignal.h.
10447 * syssignal.h (croak): Put it here, so the API can be checked when
10448 'croak' is called from dissociate_if_controlling_tty.
10450 * minibuf.c: Make symbols static if they're not exported.
10451 (minibuf_save_list, choose_minibuf_frame): Now static.
10452 * lisp.h (choose_minibuf_frame): Remove decl.
10454 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10456 * lread.c: Make symbols static if they're not exported.
10457 (read_objects, initial_obarray, oblookup_last_bucket_number):
10459 (make_symbol): Remove; unused.
10460 * lisp.h (initial_obarray, make_symbol): Remove decls.
10462 * keyboard.c: Make symbols static if they're not exported.
10463 (single_kboard, recent_keys_index, total_keys, recent_keys):
10464 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10465 (this_single_command_key_start, echoing, last_auto_save):
10466 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10467 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10468 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10469 (Vlispy_mouse_stem, double_click_count):
10471 (force_auto_save_soon): Define only if SIGDANGER.
10472 (ignore_mouse_drag_p): Now static if
10473 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10474 (print_help): Remove; unused.
10475 (stop_character, last_timer_event): Mark as externally visible.
10476 * keyboard.h (ignore_mouse_drag_p): Declare only if
10477 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10478 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10479 * lisp.h (echoing): Remove decl.
10480 (force_auto_save_soon): Declare only if SIGDANGER.
10481 * xdisp.c (redisplay_window): Simplify code, to make it more
10482 obvious that ignore_mouse_drag_p is not accessed if !defined
10483 USE_GTK && !defined HAVE_NS.
10485 * intervals.c: Make symbols static if they're not exported.
10486 (merge_properties_sticky, merge_interval_right, delete_interval):
10488 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10490 * insdel.c: Make symbols static if they're not exported.
10491 However, leave prepare_to_modify_buffer alone. It's never
10492 called from outside this function, but that appears to be a bug.
10493 (combine_after_change_list, combine_after_change_buffer):
10494 (adjust_after_replace, signal_before_change): Now static.
10495 (adjust_after_replace_noundo): Remove; unused.
10496 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
10497 (signal_before_change): Remove decls.
10499 * indent.c (val_compute_motion, val_vmotion): Now static.
10501 * image.c: Make symbols static if they're not exported.
10502 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10504 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10505 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10507 * fringe.c (standard_bitmaps): Now static.
10508 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10510 * frame.c: Make symbols static if they're not exported.
10511 (x_report_frame_params, make_terminal_frame): Now static.
10512 (get_frame_param): Now static, unless HAVE_NS.
10513 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10514 (x_get_resource_string): Remove; not used.
10515 * frame.h (make_terminal_frame, x_report_frame_params):
10516 (x_get_resource_string); Remove decls.
10517 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10518 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10520 * font.c, fontset.c: Make symbols static if they're not exported.
10521 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10522 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10523 * font.c (font_close_object): Now static.
10524 * font.h (font_close_object): Remove.
10525 * fontset.c (FONTSET_OBJLIST): Remove.
10526 (free_realized_fontset) #if-0 the body, which does nothing.
10527 (face_suitable_for_char_p): #if-0, as it's never called.
10528 * fontset.h (face_suitable_for_char_p): Remove decl.
10529 * xfaces.c (face_at_string_position):
10530 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
10531 since 0 is always ASCII.
10533 * fns.c (weak_hash_tables): Now static.
10535 * fileio.c: Make symbols static if they're not exported.
10536 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10537 (Vwrite_region_annotation_buffers): Now static.
10539 * eval.c: Make symbols static if they're not exported.
10540 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10541 * lisp.h (backtrace_list): Remove decl.
10543 * emacs.c: Make symbols static if they're not exported.
10544 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10545 (fatal_error_code, fatal_error_signal_hook, standard_args):
10547 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10548 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10549 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10550 * lisp.h (fatal_error_signal_hook): Remove decl.
10551 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10553 * editfns.c: Move a (normally-unused) function to its only use.
10554 * editfns.c, lisp.h (get_operating_system_release): Remove.
10555 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10556 worth the hassle of breaking this out.
10558 * xterm.c: Make symbols static if they're not exported.
10559 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10560 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10561 (x_destroy_window, x_delete_display):
10563 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10564 (x_mouse_leave): Remove; unused.
10565 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10566 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10567 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10569 (x_mouse_leave): Declare only if WINDOWSNT.
10570 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10571 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10574 * ftxfont.c: Make symbols static if they're not exported.
10575 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10577 * font.h (ftxfont_driver): Likewise.
10579 * xfns.c: Make symbols static if they're not exported.
10580 (x_last_font_name, x_display_info_for_name):
10581 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10582 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10583 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10584 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10585 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10586 (last_show_tip_args): Now static.
10587 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10588 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10589 (x_screen_planes): Remove; unused.
10590 * dispextern.h (x_screen_planes): Remove decl.
10592 * dispnew.c: Make symbols static if they're not exported.
10593 * dispextern.h (redraw_garbaged_frames, scrolling):
10594 (increment_row_positions): Remove.
10595 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10596 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10598 (redraw_garbaged_frames): Remove; unused.
10600 * xfaces.c: Make symbols static if they're not exported.
10601 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10603 * xterm.h (defined_color): Remove decls.
10604 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10605 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10606 (menu_face_changed_default, defined_color, free_realized_face):
10607 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10608 (ascii_face_of_lisp_face): Remove; unused.
10610 * xdisp.c: Make symbols static if they're not exported.
10611 * dispextern.h (scratch_glyph_row, window_box_edges):
10612 (glyph_to_pixel_coords, set_cursor_from_row):
10613 (get_next_display_element, set_iterator_to_next):
10614 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10615 (show_mouse_face): Remove decls
10616 * frame.h (message_buf_print): Likewise.
10617 * lisp.h (pop_message, set_message, check_point_in_composition):
10619 * xterm.h (set_vertical_scroll_bar): Likewise.
10620 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10621 (message_buf_print, scratch_glyph_row, displayed_buffer):
10622 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10623 (get_next_display_element, show_mouse_face, window_box_edges):
10624 (frame_to_window_pixel_xy, check_point_in_composition):
10625 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10626 (glyph_to_pixel_coords): Remove; unused.
10628 * dired.c (file_name_completion): Now static.
10630 * dbusbind.c (xd_in_read_queued_messages): Now static.
10632 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10633 * data.c (circular_list_error): Remove.
10635 * commands.h (last_point_position, last_point_position_buffer):
10636 (last_point_position_window): Remove decls.
10637 * keyboard.c: Make these variables static.
10639 * coding.h (coding, code_convert_region, encode_coding_gap):
10641 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10642 (iso_code_class, detect_coding, code_convert_region): Now static.
10643 (encode_coding_gap): Remove; unused.
10645 * chartab.c (chartab_chars, chartab_bits): Now static.
10647 * charset.h (charset_iso_8859_1): Remove decl.
10648 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10651 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10652 * ccl.c (Vccl_program_table): Now static.
10653 (check_ccl_update): Remove; unused.
10655 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10656 * category.h: ... from here.
10657 * category.c (check_category_table, set_category_set): Now static.
10659 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10660 * lisp.h: Remove these decls.
10662 * buffer.c (buffer_count): Remove unused var.
10664 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10665 so that it's not optimized away.
10666 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10667 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10668 exported only to the debugger.
10670 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
10671 * atimer.h (run_all_atimers): Remove; not exported.
10673 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10674 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10675 was inaccessible from Lisp.
10676 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10677 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10679 alloc.c: Import and export fewer symbols, and remove unused items.
10680 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10682 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10683 it's not optimized away by whole-program optimization.
10684 (message_enable_multibyte, free_misc): Remove.
10685 (catchlist, handlerlist, mark_backtrace):
10686 Declare only if BYTE_MARK_STACK.
10687 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10688 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10689 (message_enable_multibyte): Remove decl.
10690 (free_misc, interval_free_list, float_block, float_block_index):
10691 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10692 (cons_free_list, last_marked_index):
10694 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10695 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10696 (mark_backtrace): Define only if BYTE_MARK_STACK.
10697 * xdisp.c (message_enable_multibyte): Now static.
10699 Declare Lisp_Object Q* variables to be 'static' if not exported.
10700 This makes it easier for human readers (and static analyzers)
10701 to see whether these variables are used from other modules.
10702 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10703 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10704 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10705 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10706 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10707 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10708 * xmenu.c, xselect.c:
10709 Declare Q* vars static if they are not used in other modules.
10710 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10711 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10712 Remove decls of unexported vars.
10713 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10715 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10717 Make Emacs functions such as Fatom 'static' by default.
10718 This makes it easier for human readers (and static analyzers)
10719 to see whether these functions can be called from other modules.
10720 DEFUN now defines a static function. To make the function external
10721 so that it can be used in other C modules, use the new macro DEFUE.
10722 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10723 (Finit_image_library):
10724 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10725 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10726 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10727 Remove decls, since these functions are now static.
10728 (Funintern, Fget_internal_run_time): New decls, since these functions
10729 were already external.
10731 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10732 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10733 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10734 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10735 * keyboard.c, keymap.c, lread.c:
10736 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10737 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10738 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10739 Mark functions with DEFUE instead of DEFUN,
10740 if they are used in other modules.
10741 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10742 decls for now-static functions.
10743 * buffer.h (Fdelete_overlay): Remove decl.
10744 * callproc.c (Fgetenv_internal): Mark as internal.
10745 * composite.c (Fremove_list_of_text_properties): Remove decl.
10746 (Fcomposition_get_gstring): New forward static decl.
10747 * composite.h (Fcomposite_get_gstring): Remove decl.
10748 * dired.c (Ffile_attributes): New forward static decl.
10749 * doc.c (Fdocumntation_property): New forward static decl.
10750 * eval.c (Ffetch_bytecode): New forward static decl.
10751 (Funintern): Remove extern decl; now in .h file where it belongs.
10752 * fileio.c (Fmake_symbolic_link): New forward static decl.
10753 * image.c (Finit_image_library): New forward static decl.
10754 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10755 * intervals.h (Fprevious_property_change):
10756 (Fremove_list_of_text_properties): Remove decls.
10757 * keyboard.c (Fthis_command_keys): Remove decl.
10758 (Fcommand_execute): New forward static decl.
10759 * keymap.c (Flookup_key): New forward static decl.
10760 (Fcopy_keymap): Now static.
10761 * keymap.h (Flookup_key): Remove decl.
10762 * process.c (Fget_process): New forward static decl.
10763 (Fprocess_datagram_address): Mark as internal.
10764 * syntax.c (Fsyntax_table_p): New forward static decl.
10765 (skip_chars): Remove duplicate decl.
10766 * textprop.c (Fprevious_property_change): New forward static decl.
10767 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10769 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10770 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10772 * editfns.c (Fformat): Remove unreachable code.
10774 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10776 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10779 2011-04-13 Eli Zaretskii <eliz@gnu.org>
10781 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10782 when at ZV. (Bug#8487)
10784 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10786 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10788 * keyboard.c (parse_tool_bar_item): Likewise.
10789 * sound.c (sound_cleanup, alsa_close): Likewise.
10790 * termcap.c (tgetent): Likewise.
10791 * xfns.c (x_default_font_parameter): Likewise.
10792 * xsettings.c (read_and_apply_settings): Likewise.
10794 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10795 (overrun_check_free): Protoize.
10797 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10799 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10800 since callers should never pass a negative size.
10801 Change the signature to match that of plain 'read' and 'write'; see
10802 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10803 * lisp.h: Update prototypes of emacs_write and emacs_read.
10805 2011-04-11 Eli Zaretskii <eliz@gnu.org>
10807 * xdisp.c (redisplay_window): Don't try to determine the character
10808 position of the scroll margin if the window start point w->startp
10809 is outside the buffer's accessible region. (Bug#8468)
10811 2011-04-10 Eli Zaretskii <eliz@gnu.org>
10813 Fix write-region and its subroutines for buffers > 2GB.
10814 * fileio.c (a_write, e_write): Modify declaration of arguments and
10815 local variables to support buffers larger than 2GB.
10816 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10818 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10819 argument, local variables, and return value.
10821 * lisp.h: Update prototypes of emacs_write and emacs_read.
10823 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10825 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10827 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10829 Fix more problems found by GCC 4.6.0's static checks.
10831 * xdisp.c (vmessage): Use a better test for character truncation.
10833 * charset.c (load_charset_map): <, not <=, for optimization,
10834 and to avoid potential problems with integer overflow.
10835 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10836 * casetab.c (set_identity, shuffle): Likewise.
10837 * editfns.c (Fformat): Likewise.
10838 * syntax.c (skip_chars): Likewise.
10840 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10841 This also lets GCC 4.6.0 generate slightly better loop code.
10843 * callint.c (Fcall_interactively): <, not <=, for optimization.
10844 (Fcall_interactively): Count the number of arguments produced,
10845 not the number of arguments given. This is simpler and lets GCC
10846 4.6.0 generate slightly better code.
10848 * ftfont.c: Distingish more carefully between FcChar8 and char.
10849 The previous code passed unsigned char * to a functions like
10850 strlen and xstrcasecmp that expect char *, which does not
10851 conform to the C standard.
10852 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10853 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10854 char * when the C standard requires it.
10856 * keyboard.c (read_char): Remove unused var.
10858 * eval.c: Port to Windows vsnprintf (Bug#8435).
10859 Include <limits.h>.
10860 (SIZE_MAX): Define if the headers do not.
10861 (verror): Do not give up if vsnprintf returns a negative count.
10862 Instead, grow the buffer. This ports to Windows vsnprintf, which
10863 does not conform to C99. Problem reported by Eli Zaretskii.
10864 Also, simplify the allocation scheme, by avoiding the need for
10865 calling realloc, and removing the ALLOCATED variable.
10867 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10869 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10870 But keep the doprint source code for now, as we might revamp it
10871 and use it again (Bug#8435).
10872 * lisp.h (doprnt): Remove.
10873 * Makefile.in (base_obj): Remove doprnt.o.
10874 * deps.mk (doprnt.o): Remove.
10876 error: Print 32- and 64-bit integers portably (Bug#8435).
10877 Without this change, on typical 64-bit hosts error ("...%d...", N)
10878 was used to print both 32- and 64-bit integers N, which relied on
10879 undefined behavior.
10880 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10881 * lisp.h (error, verror): Mark as printf-like functions.
10882 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10883 Report overflow in size calculations when allocating printf buffer.
10884 Do not truncate output string at its first null byte.
10885 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10886 Truncate the output at a character boundary, since vsnprintf does not
10888 * charset.c (check_iso_charset_parameter): Convert internal
10889 character to string before calling 'error', since %c now has the
10891 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10892 overflow when computing char to be passed to 'error'. Do not
10893 pass Lisp_Object to 'error'; pass the integer instead.
10894 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10895 formatted with plain %d.
10897 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10899 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10901 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10903 * xterm.c (x_catch_errors): Remove duplicate declaration.
10905 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10907 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10909 2011-04-10 Jim Meyering <meyering@redhat.com>
10911 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10912 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10913 return ssize_t not "int", and use size_t as the buffer length.
10914 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10915 * gnutls.h: Update declarations.
10916 * process.c (read_process_output): Use ssize_t, to match.
10917 (send_process): Likewise.
10919 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10921 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10923 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10925 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10926 Use unsigned char, to match FcChar8 type definition.
10928 * xterm.c (handle_one_xevent):
10929 * xmenu.c (create_and_show_popup_menu):
10930 * xselect.c (x_decline_selection_request)
10931 (x_reply_selection_request): Avoid type-punned deref of X events.
10933 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10935 Fix some uses of `int' instead of EMACS_INT.
10936 * search.c (string_match_1, fast_string_match)
10937 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10938 (scan_buffer, find_next_newline_no_quit)
10939 (find_before_next_newline, search_command, Freplace_match)
10940 (Fmatch_data): Make some `int' variables be EMACS_INT.
10942 * xdisp.c (display_count_lines): 3rd argument and return value now
10943 EMACS_INT. All callers changed.
10944 (pint2hrstr): Last argument is now EMACS_INT.
10946 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10947 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10948 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10949 (decode_coding_utf_16, decode_coding_emacs_mule)
10950 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10951 (decode_coding_ccl, decode_coding_charset)
10952 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10953 (decode_coding_iso_2022, decode_coding_emacs_mule)
10954 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10955 <char_offset, last_offset>: Declare EMACS_INT.
10956 (encode_coding_utf_8, encode_coding_utf_16)
10957 (encode_coding_emacs_mule, encode_invocation_designation)
10958 (encode_designation_at_bol, encode_coding_iso_2022)
10959 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10960 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10962 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10963 (encode_invocation_designation): Last argument P_NCHARS is now
10965 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10966 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10968 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10971 * ccl.c (Fccl_execute_on_string): Declare some variables
10974 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10976 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10978 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10980 * process.c (Fformat_network_address): Doc fix.
10982 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10984 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10986 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10988 * keyboard.c (read_char): Call Lisp function help-form-show,
10989 instead of using internal_with_output_to_temp_buffer.
10990 (Qhelp_form_show): New var.
10991 (syms_of_keyboard): Use DEFSYM macro.
10993 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10995 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10997 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10999 * process.c (Flist_processes): Remove to Lisp.
11000 (list_processes_1): Delete.
11002 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11004 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11006 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11008 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
11010 Fix more problems found by GCC 4.6.0's static checks.
11012 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11014 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11016 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
11018 * xdisp.c (vmessage): Mark as a printf-like function.
11020 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11022 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11024 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11025 printf-like functions.
11026 (tiff_load): Add casts to remove these marks before passing them
11027 to system-supplied API.
11029 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11031 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11032 This avoids several warnings with gcc -Wstrict-overflow.
11033 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11034 directly, rather than having caller test rule sign. This avoids
11035 some unnecessary tests.
11036 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11037 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11038 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11040 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11041 (xfont_open): Avoid unnecessary tests.
11043 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11045 * composite.h, composite.c (composition_gstring_put_cache):
11046 Use EMACS_INT, not int, for length.
11048 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11049 breaking out part of COMPOSITION_DECODE_RULE.
11050 (COMPOSITION_DECODE_RULE): Use it.
11051 * composite.c (get_composition_id): Remove unused local vars,
11052 by using the new macro.
11054 * textprop.c (set_text_properties_1): Change while to do-while,
11055 since the condition is always true at first.
11057 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11058 (interval_deletion_adjustment): Return unsigned value.
11061 * process.c (list_processes_1, create_pty, read_process_output):
11062 (exec_sentinel): Remove vars that were set but not used.
11063 (create_pty): Remove unnecessary "volatile"s.
11064 (Fnetwork_interface_info): Avoid possibility of int overflow.
11065 (read_process_output): Do adaptive read buffering even if carryover.
11066 (read_process_output): Simplify nbytes computation if buffered.
11068 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11070 * syntax.c (scan_words): Remove var that was set but not used.
11071 (update_syntax_table): Use unsigned instead of int.
11073 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11074 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11075 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11077 * print.c (print_error_message): Avoid int overflow.
11079 * font.c (font_list_entities): Redo for clarity,
11080 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11082 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11083 (font_score): Avoid potential overflow in diff calculation.
11085 * fns.c (substring_both): Remove var that is set but not used.
11086 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11088 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11090 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11091 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11092 can always succeed if overflow has undefined behavior.
11094 * search.c (boyer_moore, wordify): Remove vars set but not used.
11095 (wordify): Omit three unnecessary tests.
11097 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11098 All callers changed. This avoids the need for an unused var.
11100 * casefiddle.c (casify_region): Remove var that is set but not used.
11102 * dired.c (file_name_completion): Remove var that is set but not used.
11104 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11106 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11107 (Finsert_file_contents): Remove unnecessary code checking fd.
11109 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11110 Check for integer overflow on size calculations.
11112 * buffer.c (Fprevious_overlay_change): Remove var that is set
11115 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11116 Remove vars that are set but not used.
11117 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11118 (timer_check_2): Mark vars as initialized.
11120 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11122 * image.c (lookup_image): Remove var that is set but not used.
11123 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11125 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11126 that are set but not used.
11128 * xfns.c (make_invisible_cursor): Don't return garbage
11129 if XCreateBitmapFromData fails (Bug#8410).
11131 * xselect.c (x_get_local_selection, x_handle_property_notify):
11132 Remove vars that are set but not used.
11134 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11135 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11137 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11138 Remove var that is set but not used.
11139 (scroll_bar_windows_size): Now size_t, not int.
11140 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11141 Check for overflow.
11143 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11144 (map_tty_color) [!defined MSDOS]: Likewise.
11146 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11148 * coding.c: Remove vars that are set but not used.
11149 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11150 All callers changed.
11151 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11152 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11153 (decode_coding_charset): Remove vars that are set but not used.
11155 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11156 that is set but not used.
11158 * print.c (print_object): Remove var that is set but not used.
11160 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11161 The gnulib version avoids calling malloc in the usual case,
11162 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11163 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11164 * filelock.c (current_lock_owner): Likewise.
11165 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11166 * sysdep.c: Include allocator.h, careadlinkat.h.
11167 (emacs_no_realloc_allocator): New static constant.
11168 (emacs_readlink): New function.
11169 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11170 ../lib/careadlinkat.h.
11172 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11174 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11175 first non-nil return value).
11177 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11179 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11180 if not defined (Bug#8403).
11182 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11184 * xdisp.c (display_count_lines): Remove parameter `start',
11185 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11186 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11187 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11188 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11189 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11190 and thereabouts. All callers changed.
11191 (get_per_char_metric): Remove parameter `f', unused since
11192 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11194 2011-04-02 Jim Meyering <meyering@redhat.com>
11196 do not dereference NULL upon failed strdup
11197 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11198 (ns_get_family): Likewise.
11200 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11202 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11204 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11206 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11209 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11211 Add lexical binding.
11213 * window.c (Ftemp_output_buffer_show): New fun.
11214 (Fsave_window_excursion):
11215 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11217 * lread.c (lisp_file_lexically_bound_p): New function.
11218 (Fload): Bind Qlexical_binding.
11219 (readevalloop): Remove `evalfun' arg.
11220 Bind Qinternal_interpreter_environment.
11221 (Feval_buffer): Bind Qlexical_binding.
11222 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11224 (syms_of_lread): Declare `lexical-binding'.
11226 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11228 * keyboard.c (eval_dyn): New fun.
11229 (menu_item_eval_property): Use it.
11231 * image.c (parse_image_spec): Use Ffunctionp.
11233 * fns.c (concat, mapcar1): Accept byte-code-functions.
11235 * eval.c (Fsetq): Handle lexical vars.
11236 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11237 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11238 (FletX, Flet): Obey lexical binding.
11239 (Fcommandp): Handle closures.
11240 (Feval): New `lexical' arg.
11241 (eval_sub): New function extracted from Feval. Use it almost
11242 everywhere where Feval was used. Look up vars in lexical env.
11244 (Ffunctionp): Move from subr.el.
11245 (Ffuncall): Handle closures.
11246 (apply_lambda): Remove `eval_flags'.
11247 (funcall_lambda): Handle closures and new byte-code-functions.
11248 (Fspecial_variable_p): New function.
11249 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11250 but without exporting it to Lisp.
11252 * doc.c (Fdocumentation, store_function_docstring):
11253 * data.c (Finteractive_form): Handle closures.
11255 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11258 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11260 (exec_byte_code): New function extracted from Fbyte_code to handle new
11261 calling convention for byte-code-functions. Add new byte-codes.
11263 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
11265 * alloc.c (Fmake_symbol): Init new `declared_special' field.
11267 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11269 * xdisp.c (redisplay_internal): Fix prototype.
11271 2011-03-31 Eli Zaretskii <eliz@gnu.org>
11273 * xdisp.c (SCROLL_LIMIT): New macro.
11274 (try_scrolling): Use it when setting scroll_limit.
11275 Limit scrolling to 100 screen lines.
11276 (redisplay_window): Even when falling back on "recentering",
11277 position point in the window according to scroll-conservatively,
11278 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11280 (try_scrolling): When point is above the window, allow searching
11281 as far as scroll_max, or one screenful, to compute vertical
11282 distance from PT to the scroll margin position. This prevents
11283 try_scrolling from unnecessarily failing when
11284 scroll-conservatively is set to a value slightly larger than the
11285 window height. Clean up the case of PT below the margin at bottom
11286 of window: scroll_max can no longer be INT_MAX. When aggressive
11287 scrolling is in use, don't let point enter the opposite scroll
11288 margin as result of the scroll.
11289 (syms_of_xdisp) <scroll-conservatively>: Document the
11290 threshold of 100 lines for never-recentering scrolling.
11292 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11294 * dispextern.h (move_it_by_lines):
11295 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11296 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11297 (message_log_check_duplicate): Remove parameters `prev_bol' and
11298 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11299 (redisplay_internal): Remove parameter `preserve_echo_area',
11300 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11302 * indent.c (Fvertical_motion):
11303 * window.c (window_scroll_pixel_based, Frecenter):
11304 Don't pass `need_y_p' to `move_it_by_lines'.
11306 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11308 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11309 steal a few bits to be more compact.
11310 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11311 Remove unneeded casts.
11313 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11315 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11317 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11318 binding" message (bug#7967).
11320 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11322 Fix more problems found by GCC 4.6.0's static checks.
11324 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11325 Remove unused local var.
11327 * editfns.c (Fmessage_box): Remove unused local var.
11329 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11330 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11331 Omit unused local vars.
11332 * window.c (shrink_windows): Omit unused local var.
11333 * menu.c (digest_single_submenu): Omit unused local var.
11334 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11335 Omit unused local var.
11337 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11338 Don't assume string length fits in int.
11339 (keyremap_step, read_key_sequence): Use size_t for sizes.
11340 (read_key_sequence): Don't check last_real_key_start redundantly.
11342 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11343 instead of alloca (Bug#8344).
11345 * eval.c (Fbacktrace): Don't assume nargs fits in int.
11346 (Fbacktrace_frame): Don't assume nframes fits in int.
11348 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11350 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11353 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11355 * cm.c (calccost): Turn while-do into do-while, for clarity.
11357 * keyboard.c (syms_of_keyboard): Use the same style as later
11358 in this function when indexing through an array. This also
11359 works around GCC bug 48267.
11361 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11363 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11365 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11366 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11368 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11369 This avoids undefined behavior on integer overflow, and is a bit
11370 more convenient anyway since it is compared to a size_t variable.
11372 Variadic C functions now count arguments with size_t, not int.
11373 This avoids an unnecessary limitation on 64-bit machines, which
11374 caused (substring ...) to crash on large vectors (Bug#8344).
11375 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11376 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
11377 All variadic functions and their callers changed accordingly.
11378 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11379 * data.c (arith_driver, float_arith_driver): Likewise.
11380 * editfns.c (general_insert_function): Likewise.
11381 * eval.c (struct backtrace.nargs, interactive_p)
11382 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11383 (funcall_lambda, mark_backtrace): Likewise.
11384 * fns.c (concat): Likewise.
11385 * frame.c (x_set_frame_parameters): Likewise.
11386 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11387 0 if not found, not -1. All callers changed.
11389 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11390 (stack_copy_size): Now size_t, not int.
11391 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11393 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11395 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11396 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11397 All callers changed.
11399 * lisp.h (multibyte_char_to_unibyte):
11400 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11401 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11402 * character.h (CHAR_TO_BYTE8):
11403 * cmds.c (internal_self_insert):
11404 * editfns.c (general_insert_function):
11405 * keymap.c (push_key_description):
11406 * search.c (Freplace_match):
11407 * xdisp.c (message_dolog, set_message_1): All callers changed.
11409 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11411 * keyboard.c (safe_run_hook_funcall): New function.
11412 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11413 don't set the hook to nil, but remove the offending function instead.
11414 (Qcommand_hook_internal): Remove, unused.
11415 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11416 Vcommand_hook_internal.
11418 * eval.c (enum run_hooks_condition): Remove.
11419 (funcall_nil, funcall_not): New functions.
11420 (run_hook_with_args): Call each function through a `funcall' argument.
11421 Remove `cond' argument, now redundant.
11422 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11423 (Frun_hook_with_args_until_failure): Adjust accordingly.
11424 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11426 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11428 * dispextern.h (string_buffer_position): Remove declaration.
11430 * print.c (strout): Remove parameter `multibyte', unused since
11431 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11433 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11434 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11435 All callers changed.
11437 * w32.c (_wsa_errlist): Use braces for struct initializers.
11439 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11440 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11441 All callers changed.
11442 (string_buffer_position): Likewise. Also, make static (it's never
11443 used outside xdisp.c).
11444 (cursor_row_p): Remove parameter `w', unused since
11445 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11446 (decode_mode_spec): Remove parameter `precision', introduced during
11447 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11448 All callers changed.
11450 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11452 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11454 2011-03-27 Anders Lindgren <andlind@gmail.com>
11456 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11457 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11458 (ns_update_auto_hide_menu_bar): New functions.
11459 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11460 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11461 ns_constrain_all_frames.
11462 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11463 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11465 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11467 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11469 2011-03-27 Glenn Morris <rgm@gnu.org>
11471 * syssignal.h: Replace RETSIGTYPE with void.
11472 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11473 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11474 Replace SIGTYPE with void everywhere.
11475 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11476 * s/template.h (SIGTYPE): Remove commented out definition.
11478 2011-03-26 Eli Zaretskii <eliz@gnu.org>
11480 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11481 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11483 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
11485 * w32.c (read_unc_volume): Use parameter `henum', instead of
11486 global variable `wget_enum_handle'.
11488 * keymap.c (describe_vector): Remove parameters `indices' and
11489 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11490 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11492 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11494 * keyboard.c (timer_check): Remove parameter `do_it_now',
11495 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11496 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11497 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11499 * keyboard.c (read_char):
11500 * w32menu.c (w32_menu_display_help):
11501 * xmenu.c (show_help_event, menu_help_callback):
11502 Adjust calls to `show_help_echo'.
11504 * gtkutil.c (xg_maybe_add_timer):
11505 * keyboard.c (readable_events):
11506 * process.c (wait_reading_process_output):
11507 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11509 * insdel.c (adjust_markers_gap_motion):
11510 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11511 (gap_left, gap_right): Don't call it.
11513 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
11515 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11516 incurred during fontification.
11518 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11520 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11521 (DEFVAR_PER_BUFFER): Don't pass it.
11523 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11524 (scrolling_window): Don't pass it.
11526 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11528 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11530 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11532 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11533 of variables specific to SELinux and computation of `encoded_absname'.
11535 * image.c (XPutPixel): Remove unused variable `height'.
11537 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11539 * unexw32.c (get_section_info): Remove unused variable `section'.
11541 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11542 (system_process_attributes): Remove unused variable `sess'.
11543 (sys_read): Remove unused variable `err'.
11545 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11546 (w32_wnd_proc): Remove unused variable `isdead'.
11547 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11548 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11549 (x_create_tip_frame): Remove unused variable `tem'.
11551 * w32inevt.c (w32_console_read_socket):
11552 Remove unused variable `no_events'.
11554 * w32term.c (x_draw_composite_glyph_string_foreground):
11555 Remove unused variable `width'.
11557 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
11559 * w32term.c (x_set_glyph_string_clipping):
11560 Don't pass uninitialized region to CombineRgn.
11562 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
11564 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11565 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11566 (Fx_close_connection): Remove unused variable `i'.
11568 * w32font.c (w32font_draw): Return number of glyphs.
11569 (w32font_open_internal): Remove unused variable `i'.
11570 (w32font_driver): Add missing initializer.
11572 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11573 (fill_in_menu): Remove unused variable `items_added'.
11575 * w32term.c (last_mouse_press_frame): Remove static global variable.
11576 (w32_clip_to_row): Remove unused variable `f'.
11577 (x_delete_terminal): Remove unused variable `i'.
11579 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11580 (NOTHING): Remove unused static global variable.
11581 (uniscribe_check_otf): Remove unused variable `table'.
11582 (uniscribe_font_driver): Add missing initializers.
11584 2011-03-23 Julien Danjou <julien@danjou.info>
11586 * term.c (Fsuspend_tty, Fresume_tty):
11587 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11588 * window.c (temp_output_buffer_show):
11589 * insdel.c (signal_before_change):
11590 * frame.c (Fhandle_switch_frame):
11591 * fileio.c (Fdo_auto_save):
11592 * emacs.c (Fkill_emacs):
11593 * editfns.c (save_excursion_restore):
11594 * cmds.c (internal_self_insert):
11595 * callint.c (Fcall_interactively):
11596 * buffer.c (Fkill_all_local_variables):
11597 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11599 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
11600 unconditionally since it does the check itself.
11602 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
11604 Fix more problems found by GCC 4.5.2's static checks.
11606 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11607 the first time through the loop, since we know p0 < p1 then.
11608 This also avoids a gcc -Wstrict-overflow warning.
11610 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11611 leading to a memory leak, possible in functions like
11612 load_charset_map_from_file that can allocate an unbounded number
11613 of objects (Bug#8318).
11615 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11616 that could (at least in theory) be that large.
11618 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11619 This is less likely to overflow, and avoids undefined behavior if
11620 overflow does occur. All callers changed. Use strtoul to scan
11621 for the unsigned long integer.
11622 (pint2hrstr): Simplify and tune code slightly.
11623 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
11625 * scroll.c (do_scrolling): Work around GCC bug 48228.
11626 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11628 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11629 This also avoids a warning with gcc -Wstrict-overflow.
11630 (validate_x_resource_name): Simplify count usage.
11631 This also avoids a warning with gcc -Wstrict-overflow.
11633 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11636 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
11638 * process.c (Fmake_network_process): Use socklen_t, not int,
11639 where POSIX says socklen_t is required in portable programs.
11640 This fixes a porting bug on hosts like 64-bit HP-UX, where
11641 socklen_t is wider than int (Bug#8277).
11642 (Fmake_network_process, server_accept_connection):
11643 (wait_reading_process_output, read_process_output):
11646 * process.c: Rename or move locals to avoid shadowing.
11647 (list_processes_1, Fmake_network_process):
11648 (read_process_output_error_handler, exec_sentinel_error_handler):
11649 Rename or move locals.
11650 (Fmake_network_process): Define label "retry_connect" only if needed.
11651 (Fnetwork_interface_info): Fix pointer signedness.
11652 (process_send_signal): Add cast to avoid pointer signedness problem.
11653 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
11654 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
11656 Make tparam.h and terminfo.c consistent.
11657 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11658 Include tparam.h instead, since it declares them.
11659 * cm.h (PC): Remove extern decl; tparam.h now does this.
11660 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11661 * terminfo.c: Include tparam.h, to check interfaces.
11662 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11663 (tparam): Adjust signature to match interface in tparam.h;
11664 this removes some undefined behavior. Check that outstring and len
11665 are zero, which they always are with Emacs.
11666 * tparam.h (PC, BC, UP): New extern decls.
11668 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
11669 (xftfont_open): Rename locals to avoid shadowing.
11671 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
11672 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11673 (OTF_TAG_SYM): Omit macro if not needed.
11674 (ftfont_list): Remove unused local.
11675 (get_adstyle_property, ftfont_pattern_entity):
11676 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11677 Rename locals to avoid shadowing.
11679 * xfont.c (xfont_list_family): Mark var as initialized.
11681 * xml.c (make_dom): Now static.
11683 * composite.c (composition_compute_stop_pos): Rename local to
11685 (composition_reseat_it): Remove unused locals.
11686 (find_automatic_composition, composition_adjust_point): Likewise.
11687 (composition_update_it): Mark var as initialized.
11688 (find_automatic_composition): Mark vars as initialized,
11689 with a FIXME (Bug#8290).
11691 character.h: Rename locals to avoid shadowing.
11692 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11693 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11694 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11695 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11696 to avoid shadowing.
11698 * textprop.c (property_change_between_p): Remove; unused.
11700 * intervals.c (interval_start_pos): Now static.
11702 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11704 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11705 Rename locals to avoid shadowing.
11707 * sound.c (wav_play, au_play, Fplay_sound_internal):
11708 Fix pointer signedness.
11709 (alsa_choose_format): Remove unused local var.
11710 (wav_play): Initialize a variable to 0, to prevent undefined
11711 behavior (Bug#8278).
11713 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11715 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11717 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11718 clobbering (Bug#8298).
11719 * sysdep.c (sys_subshell): Likewise.
11720 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
11722 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11723 This should get cleaned up, so that child_setup has the
11724 same signature on all platforms.
11726 * callproc.c (call_process_cleanup): Now static.
11727 (relocate_fd): Rename locals to avoid shadowing.
11729 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
11731 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11732 not to be necessary, and produces flickering.
11734 2011-03-20 Glenn Morris <rgm@gnu.org>
11736 * config.in: Remove file.
11738 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
11740 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11741 are now in src/globals.h.
11742 (syms_of_minibuf): Remove spurious & from previous change.
11744 2011-03-20 Leo Liu <sdl.web@gmail.com>
11746 * minibuf.c (completing-read-function): New variable.
11747 (completing-read-default): Rename from completing-read.
11748 (completing-read): Call completing-read-function.
11750 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11752 * xfaces.c (Fx_load_color_file):
11753 Read color file from absolute filename (bug#8250).
11755 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11757 * makefile.w32-in: Update dependencies.
11759 2011-03-17 Eli Zaretskii <eliz@gnu.org>
11761 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11763 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11765 Fix more problems found by GCC 4.5.2's static checks.
11767 * process.c (make_serial_process_unwind, send_process_trap):
11768 (sigchld_handler): Now static.
11770 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11771 That way, the code declares only the vars that it needs.
11772 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11773 * s/cygwin.h (PTY_ITERATION): Likewise.
11774 * s/darwin.h (PTY_ITERATION): Likewise.
11775 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11777 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11778 * process.c (allocate_pty): Don't declare stb unless it's needed.
11780 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
11781 (CONSTANTLIM): Remove; unused.
11782 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11783 Define only if needed.
11785 * unexelf.c (unexec): Name an expression,
11786 to avoid gcc -Wbad-function-cast warning.
11787 Use a different way to cause a compilation error if anyone uses
11788 n rather than nn, a way that does not involve shadowing.
11789 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
11791 * deps.mk (unexalpha.o): Remove; unused.
11793 New file unexec.h, the (simple) interface for unexec (Bug#8267).
11794 * unexec.h: New file.
11795 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11796 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11797 Depend on unexec.h.
11798 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11799 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11800 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
11801 Change as necessary to match prototype in unexec.h.
11803 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11805 (back_comment, skip_chars): Mark vars as initialized.
11807 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11808 Rename locals to avoid shadowing.
11810 * lread.c (read1): Rewrite so as not to use empty "else".
11811 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
11813 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11815 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11816 warning when compiling print.c.
11818 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11819 instead of using an uninitialized var.
11820 (font_sort_entities): Mark var as initialized.
11822 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11824 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11825 pointers to constants.
11826 (font_parse_fcname): Remove unused vars.
11827 (font_delete_unmatched): Now static.
11828 (font_get_spec): Remove; unused.
11829 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11830 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11831 Rename or move locals to avoid shadowing.
11833 * fns.c (require_nesting_list, require_unwind): Now static.
11834 (Ffillarray): Rename locals to avoid shadowing.
11836 * floatfns.c (domain_error2): Define only if needed.
11837 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11839 * alloc.c (mark_backtrace): Move decl from here ...
11840 * lisp.h: ... to here, so that it can be checked.
11842 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11843 (Fdefvar): Rewrite so as not to use empty "else".
11844 (lisp_indirect_variable): Name an expression,
11845 to avoid gcc -Wbad-function-cast warning.
11846 (Fdefvar): Rename locals to avoid shadowing.
11848 * callint.c (quotify_arg, quotify_args): Now static.
11849 (Fcall_interactively): Rename locals to avoid shadowing.
11850 Use const pointer when appropriate.
11852 * lisp.h (get_system_name, get_operating_system_release):
11853 Move decls here, to check interfaces.
11854 * process.c (get_operating_system_release): Move decl to lisp.h.
11855 * xrdb.c (get_system_name): Likewise.
11856 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11857 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11858 some of which prompt warnings from gcc -Wbad-function-cast.
11859 (Fformat_time_string, Fencode_time, Finsert_char):
11860 (Ftranslate_region_internal, Fformat):
11861 Rename or remove local vars to avoid shadowing.
11862 (Ftranslate_region_internal): Mark var as initialized.
11864 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11867 * lisp.h (eassert): Check that the argument compiles, even if
11868 ENABLE_CHECKING is not defined.
11870 * data.c (Findirect_variable): Name an expression, to avoid
11871 gcc -Wbad-function-cast warning.
11872 (default_value, arithcompare, arith_driver, arith_error): Now static.
11873 (store_symval_forwarding): Rename local to avoid shadowing.
11874 (Fmake_variable_buffer_local, Fmake_local_variable):
11875 Mark variables as initialized.
11876 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11878 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11879 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11880 Rename locals to avoid shadowing.
11881 (mark_stack): Move local variables into the #ifdef region where
11883 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11884 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11886 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11887 (GC_STRING_CHARS): Remove; not used.
11888 (Fmemory_limit): Cast sbrk's returned value to char *.
11890 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11891 avoids undefined behavior in theory.
11893 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11895 Use functions, not macros, for up- and down-casing (Bug#8254).
11896 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11897 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11898 to use the following functions instead of these macros.
11899 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11900 EMACS_INT, since callers assume the returned value fits in int.
11901 (upcase1): Likewise, for UPCASE_TABLE.
11902 (uppercasep, lowercasep, upcase): New static inline functions.
11903 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11904 the race-condition problem in the old DOWNCASE.
11906 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11907 Rename locals to avoid shadowing.
11908 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11909 (regex_compile, re_search_2, re_match_2_internal):
11910 Remove unused local vars.
11911 (FREE_VAR): Rewrite so as not to use empty "else",
11912 which gcc can warn about.
11913 (regex_compile, re_match_2_internal): Mark locals as initialized.
11914 (RETALLOC_IF): Define only if needed.
11915 (WORDCHAR_P): Likewise. This one is never needed, but is used
11916 only in a comment talking about a compiler bug, so put inside
11917 the #if 0 of that comment.
11918 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11919 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11922 * search.c (boyer_moore): Rename locals to avoid shadowing.
11923 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11924 (PREV_CHAR_BOUNDARY): Likewise.
11926 * search.c (simple_search): Remove unused var.
11928 * dired.c (compile_pattern): Move decl from here ...
11929 * lisp.h: ... to here, so that it can be checked.
11930 (struct re_registers): New forward decl.
11932 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11934 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11936 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11937 Rename locals to avoid shadowing.
11938 (Fvertical_motion): Mark locals as initialized.
11940 * casefiddle.c (casify_object, casify_region): Now static.
11941 (casify_region): Mark local as initialized.
11943 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11945 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11946 New macros, so that the caller can use some names other than
11947 gcpro1, gcpro2, etc.
11948 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11950 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11951 argument, for consistency with GCPRO2_VAR, etc: it is now the
11952 prefix of the variable, not the variable itself. All uses
11954 * dired.c (directory_files_internal, file_name_completion):
11955 Rename locals to avoid shadowing.
11957 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11958 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11959 dired.c's scmp function, had undefined behavior.
11960 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11961 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11962 * buffer.h: ... to here, because these macros use current_buffer,
11963 and the new implementation with inline functions needs to have
11964 current_buffer in scope now, rather than later when the macros
11966 (downcase, upcase1): New static inline functions.
11967 (DOWNCASE, UPCASE1): Reimplement using these functions.
11968 This avoids undefined behavior in expressions like
11969 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11970 from race conditions in accessing the global variables
11971 case_temp1 and case_temp2.
11972 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11973 * lisp.h (case_temp1, case_temp2): Remove their decls.
11974 * character.h (ASCII_CHAR_P): Move from here ...
11975 * lisp.h: ... to here, so that the inline functions mentioned
11976 above can use them.
11978 * dired.c (directory_files_internal_unwind): Now static.
11980 * fileio.c (file_name_as_directory, directory_file_name):
11981 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11983 (file_name_as_directory): Use const pointers when appropriate.
11984 (Fexpand_file_name): Likewise. In particular, newdir might
11985 point at constant storage, so make it a const pointer.
11986 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11987 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11989 (Fset_file_times, Finsert_file_contents, auto_save_error):
11990 Rename locals to avoid shadowing.
11992 * minibuf.c (choose_minibuf_frame_1): Now static.
11993 (Ftry_completion, Fall_completions): Rename or remove locals
11994 to avoid shadowing.
11996 * marker.c (bytepos_to_charpos): Remove; unused.
11998 * lisp.h (verify_bytepos, count_markers): New decls,
11999 so that gcc does not warn that these functions aren't declared.
12001 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12002 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12003 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
12004 (copy_text): Remove unused local var.
12006 * filelock.c (within_one_second): Now static.
12007 (lock_file_1): Rename local to avoid shadowing.
12009 * buffer.c (fix_overlays_before): Mark locals as initialized.
12010 (fix_start_end_in_overlays): Likewise. This function should be
12011 simplified by using pointers-to-pointers, but that's a different
12013 (switch_to_buffer_1): Now static.
12014 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12015 (report_overlay_modification): Rename locals to avoid shadowing.
12017 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
12018 Fix pointer signedness issue.
12019 (sys_subshell): Mark local as volatile if checking for lint,
12020 to suppress a gcc -Wclobbered warning that does not seem to be right.
12021 (MAXPATHLEN): Define only if needed.
12023 * process.c (serial_open, serial_configure): Move decls from here ...
12024 * systty.h: ... to here, so that they can be checked.
12026 * fns.c (get_random, seed_random): Move extern decls from here ...
12027 * lisp.h: ... to here, so that they can be checked.
12029 * sysdep.c (reset_io): Now static.
12030 (wait_for_termination_signal): Remove; unused.
12032 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12033 (copy_keymap_item, append_key, push_text_char_description):
12035 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12036 (DENSE_TABLE_SIZE): Remove; unused.
12037 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12038 (describe_map_tree):
12039 Rename locals to avoid shadowing.
12041 * keyboard.c: Declare functions static if they are not used elsewhere.
12042 (echo_char, echo_dash, cmd_error, top_level_2):
12043 (poll_for_input, handle_async_input): Now static.
12044 (read_char, kbd_buffer_get_event, make_lispy_position):
12045 (make_lispy_event, make_lispy_movement, apply_modifiers):
12046 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12047 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12048 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12049 (read_key_sequence, read_char): Mark locals as initialized.
12050 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12052 * keyboard.h (make_ctrl_char): New decl.
12053 (mark_kboards): Move decl here ...
12054 * alloc.c (mark_kboards): ... from here.
12056 * lisp.h (force_auto_save_soon): New decl.
12058 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12059 (DEFINE_DUMMY_FUNCTION): New macro.
12060 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12062 (main): Add casts to avoid warnings
12063 if GCC considers string literals to be constants.
12065 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12067 * dbusbind.c: Pointer signedness fixes.
12068 (xd_signature, xd_append_arg, xd_initialize):
12069 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12070 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12071 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12072 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12074 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12075 if GCC considers string literals to be constants.
12076 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12078 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12080 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12081 (print_preprocess, print_object): New macro to fix last change.
12083 * print.c (print_preprocess): Don't forget font objects.
12085 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12087 * emacs.c (USAGE3): Doc fixes.
12089 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12091 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12094 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12096 * lisp.h (VWindow_system, Qfile_name_history):
12097 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12098 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12099 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12101 * w32select.c: Don't #include "keyboard.h".
12102 (run_protected): Add extern declaration for waiting_for_input.
12104 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12105 * w32console.c (detect_input_pending, read_input_pending)
12106 (encode_terminal_code):
12107 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12108 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12109 (w32_system_caret_y, Qfile_name_history):
12110 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12111 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12112 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12113 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12114 * w32proc.c (Qlocal, report_file_error):
12115 * w32term.c (Vwindow_system, updating_frame):
12116 * w32uniscribe.c (initialized, uniscribe_font_driver):
12117 Remove unneeded extern declarations.
12119 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12121 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12123 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12125 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12126 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12127 These macros can no longer be used for assignment.
12129 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12130 Assign struct members directly, instead of using BUF_BEGV etc.
12131 (record_buffer_markers, fetch_buffer_markers): New functions for
12132 recording and fetching special buffer markers.
12133 (set_buffer_internal_1, set_buffer_temp): Use them.
12135 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12137 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12139 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12140 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12142 * xdisp.c (hscroll_window_tree):
12143 (reconsider_clip_changes): Use PT instead of BUF_PT.
12145 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12147 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12148 $(EMACS_ROOT)/lib/intprops.h.
12150 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12152 Fix more problems found by GCC 4.5.2's static checks.
12154 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12155 to unsigned char * to avoid compiler diagnostic.
12156 (xg_free_frame_widgets): Make it clear that a local variable is
12157 needed only if USE_GTK_TOOLTIP.
12158 (gdk_window_get_screen): Make it clear that this macro is needed
12159 only if USE_GTK_TOOLTIP.
12160 (int_gtk_range_get_value): New function, which avoids a diagnostic
12161 from gcc -Wbad-function-cast.
12162 (xg_set_toolkit_scroll_bar_thumb): Use it.
12163 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12164 diagnostic from gcc -Wbad-function-cast.
12165 (get_utf8_string, xg_get_file_with_chooser):
12166 Rename locals to avoid shadowing.
12167 (create_dialog): Move locals to avoid shadowing.
12169 * xgselect.c (xg_select): Remove unused var.
12171 * image.c (four_corners_best): Mark locals as initialized.
12172 (gif_load): Initialize transparent_p to zero (Bug#8238).
12173 Mark another local as initialized.
12174 (my_png_error, my_error_exit): Mark with NO_RETURN.
12176 * image.c (clear_image_cache): Now static.
12177 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12178 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12179 (x_edge_detection): Remove unnecessary cast that
12180 gcc -Wbad-function-cast diagnoses.
12181 (gif_load): Fix pointer signedness.
12182 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12183 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12185 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12187 Improve quality of tests for time stamp overflow.
12188 For example, without this patch (encode-time 0 0 0 1 1
12189 1152921504606846976) returns the obviously-bogus value (-948597
12190 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12191 reports time overflow. See
12192 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12193 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12194 * editfns.c: Include limits.h and intprops.h.
12195 (TIME_T_MIN, TIME_T_MAX): New macros.
12196 (time_overflow): Move earlier, to before first use.
12197 (hi_time, lo_time): New functions, for an accurate test for
12198 out-of-range times.
12199 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12200 (Fget_internal_run_time): Don't assume time_t fits in int.
12201 (make_time): Use list2 instead of Fcons twice.
12202 (Fdecode_time): More accurate test for out-of-range times.
12203 (check_tm_member): New function.
12204 (Fencode_time): Use it, to test for out-of-range times.
12205 (lisp_time_argument): Don't rely on undefined left-shift and
12206 right-shift behavior when checking for time stamp overflow.
12208 * editfns.c (time_overflow): New function, refactoring common code.
12209 (Fformat_time_string, Fdecode_time, Fencode_time):
12210 (Fcurrent_time_string): Use it.
12212 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12213 * dired.c (make_time): Move to ...
12214 * editfns.c (make_time): ... here.
12215 * systime.h: Note the move.
12217 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12219 * fringe.c (update_window_fringes): Remove unused variables.
12221 * unexmacosx.c (copy_data_segment): Also copy __got section.
12224 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12226 * termcap.c [MSDOS]: Include "msdos.h".
12227 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12228 Constify `char *' arguments and their references according to
12229 prototypes in tparam.h.
12231 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12233 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12234 Adapt all references accordingly.
12236 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12238 2011-03-11 Tom Tromey <tromey@redhat.com>
12240 * buffer.c (syms_of_buffer): Remove obsolete comment.
12242 2011-03-11 Eli Zaretskii <eliz@gnu.org>
12244 * termhooks.h (encode_terminal_code): Declare prototype.
12246 * msdos.c (encode_terminal_code): Don't declare prototype.
12248 * term.c (encode_terminal_code): Now external again, used by
12249 w32console.c and msdos.c.
12251 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12252 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
12254 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
12256 Fix some minor problems found by GCC 4.5.2's static checks.
12258 * fringe.c (update_window_fringes): Mark locals as initialized
12260 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
12262 * alloc.c (mark_fringe_data): Move decl from here ...
12263 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12264 to check its interface.
12265 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12267 * fontset.c (free_realized_fontset): Now static.
12268 (Fset_fontset_font): Rename local to avoid shadowing.
12269 (fontset_font): Mark local as initialized.
12270 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
12272 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12274 * xselect.c (x_disown_buffer_selections): Remove; not used.
12275 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
12276 (x_own_selection, Fx_disown_selection_internal): Rename locals
12277 to avoid shadowing.
12278 (x_handle_dnd_message): Remove local to avoid shadowing.
12280 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12281 so that the caller can use some name other than gcpro1.
12282 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
12283 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12284 (Fx_backspace_delete_keys_p):
12285 Use them to avoid shadowing, and rename vars to avoid shadowing.
12286 (x_decode_color, x_set_name, x_window): Now static.
12287 (Fx_create_frame): Add braces to silence GCC warning.
12288 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
12289 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12290 Remove unused locals.
12291 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12292 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12293 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12296 * xterm.h (x_mouse_leave): New decl.
12298 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12299 Remove unused functions.
12300 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12301 (x_calc_absolute_position): Now static.
12302 (XTread_socket): Don't define label "out" unless it's used.
12303 Don't declare local "event" unless it's used.
12304 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12305 unless they are used.
12306 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12307 (x_fatal_error_signal): Remove; not used.
12308 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12309 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12310 (x_error_catcher, x_connection_closed, x_error_handler):
12311 (x_error_quitter, xembed_send_message, x_iconify_frame):
12312 (my_log_handler): Rename locals to avoid shadowing.
12313 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
12314 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
12316 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12317 Rename or move locals to avoid shadowing.
12318 (tty_defined_color, merge_face_heights): Now static.
12319 (free_realized_faces_for_fontset): Remove; not used.
12320 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12321 does not deduce is never used uninitialized.
12322 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12323 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
12325 * terminal.c (store_terminal_param): Now static.
12327 * xmenu.c (menu_highlight_callback): Now static.
12328 (set_frame_menubar): Remove unused local.
12329 (xmenu_show): Rename parameter to avoid shadowing.
12330 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12331 since they might point to immutable storage.
12332 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12333 since it's unused otherwise.
12335 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
12336 Add a FIXME, since the code still doesn't look right. (Bug#8215)
12337 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12338 avoids a gcc -Wuninitialized diagnostic.
12339 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
12340 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12341 does not deduce are never used uninitialized.
12343 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12345 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
12346 * window.c (window_loop, size_window):
12347 (run_window_configuration_change_hook, enlarge_window): Likewise.
12349 * window.c (display_buffer): Now static.
12350 (size_window): Mark variables that gcc -Wuninitialized
12351 does not deduce are never used uninitialized.
12352 * window.h (check_all_windows): New decl, to forestall
12353 gcc -Wmissing-prototypes diagnostic.
12354 * dispextern.h (bidi_dump_cached_states): Likewise.
12356 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12358 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
12359 Include <limits.h>.
12360 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12361 and to avoid gcc -Wuninitialized warning.
12362 (load_charset_map): Mark variables that gcc -Wuninitialized
12363 does not deduce are never used uninitialized.
12364 (load_charset): Abort instead of using uninitialized var (Bug#8229).
12366 * coding.c (coding_set_source, coding_set_destination):
12367 Use "else { /* comment */ }" rather than "else /* comment */;"
12368 for clarity, and to avoid gcc -Wempty-body warning.
12369 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12370 a block, when the outer 'i' will do.
12371 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12372 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12373 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12374 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12375 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12376 Rename locals to avoid shadowing.
12377 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
12378 * coding.c (emacs_mule_char, encode_invocation_designation):
12379 Now static, since they're not used elsewhere.
12380 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
12381 (decode_coding_object, encode_coding_object, detect_coding_system):
12382 (decode_coding_emacs_mule): Mark variables that gcc
12383 -Wuninitialized does not deduce are never used uninitialized.
12384 (detect_coding_iso_2022): Initialize a local variable that might
12385 be used uninitialized. Leave a FIXME because it's not clear that
12386 this initialization is needed. (Bug#8211)
12387 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12388 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12389 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12390 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12391 Remove unused macros.
12393 * category.c (hash_get_category_set): Remove unused local var.
12394 (copy_category_table): Now static, since it's not used elsewhere.
12395 * character.c (string_count_byte8): Likewise.
12397 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12398 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12400 * chartab.c (copy_sub_char_table): Now static, since it's not used
12402 (sub_char_table_ref_and_range, char_table_ref_and_range):
12403 Rename locals to avoid shadowing.
12404 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
12406 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
12407 (BIDI_BOB): Remove unused macro.
12409 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12410 deduce are never used uninitialized.
12411 * term.c (encode_terminal_code): Likewise.
12413 * term.c (encode_terminal_code): Now static. Remove unused local.
12415 * tparam.h: New file.
12416 * term.c, tparam.h: Include it.
12417 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12418 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12419 Move these decls to tparam.h, and make them agree with what
12420 is actually in tparam.c. The previous trick of using incompatible
12421 decls in different modules does not conform to the C standard.
12422 All callers of tparam changed to use tparam's actual API.
12423 * tparam.c (tparam1, tparam, tgoto):
12424 Use const pointers where appropriate.
12426 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12427 * cm.h (struct cm): Likewise.
12428 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12429 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12430 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12431 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12432 (turn_on_face, init_tty): Likewise.
12433 * termchar.h (struct tty_display_info): Likewise.
12435 * term.c (term_mouse_position): Rename local to avoid shadowing.
12437 * alloc.c (mark_ttys): Move decl from here ...
12438 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12440 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12442 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12444 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
12446 * search.c (compile_pattern_1): Remove argument regp, unused since
12447 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12448 (compile_pattern): Don't pass it.
12450 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12452 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12453 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12455 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12457 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12459 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12460 gdk_window_get_screen, gdk_window_get_geometry,
12461 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12462 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12463 (xg_get_pixbuf_from_pixmap): New function.
12464 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12465 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12466 Call xg_get_pixbuf_from_pixmap instead of
12467 gdk_pixbuf_get_from_drawable.
12468 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12469 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12470 (xg_check_special_colors): Use GtkStyleContext and its functions
12472 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12473 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12474 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
12475 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12476 Call gtk_widget_get_preferred_size.
12477 (xg_frame_resized): gdk_window_get_geometry only takes 5
12479 (xg_win_to_widget, xg_event_is_for_menubar):
12480 Call gdk_x11_window_lookup_for_display.
12481 (xg_set_widget_bg): New function.
12482 (delete_cb): New function.
12483 (xg_create_frame_widgets): Connect delete-event to delete_cb.
12484 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
12485 (xg_set_background_color): Call xg_set_widget_bg.
12486 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12487 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12488 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12489 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12491 (update_frame_tool_bar): Call gtk_widget_hide.
12492 (xg_initialize): Use GDK_KEY_g.
12494 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12496 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12498 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12499 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12500 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12502 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
12504 * w32xfns.c (select_palette): Check success of RealizePalette against
12505 GDI_ERROR, not zero.
12507 See ChangeLog.11 for earlier changes.
12509 ;; Local Variables:
12513 Copyright (C) 2011-2012 Free Software Foundation, Inc.
12515 This file is part of GNU Emacs.
12517 GNU Emacs is free software: you can redistribute it and/or modify
12518 it under the terms of the GNU General Public License as published by
12519 the Free Software Foundation, either version 3 of the License, or
12520 (at your option) any later version.
12522 GNU Emacs is distributed in the hope that it will be useful,
12523 but WITHOUT ANY WARRANTY; without even the implied warranty of
12524 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12525 GNU General Public License for more details.
12527 You should have received a copy of the GNU General Public License
12528 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.