1 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4 to the doc string advising against its use for altering the way
7 2011-12-28 Kenichi Handa <handa@m17n.org>
9 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
10 coding-system ASCII compatible only when it does not produce BOM
11 on encoding (Bug#10383).
13 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
15 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
17 (create_and_show_popup_menu): Always use menu_position_func for
20 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
22 * callint.c (Fcall_interactively): Don't truncate prompt string.
24 2011-12-23 Eli Zaretskii <eliz@gnu.org>
26 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
27 property that ends at ZV, so that the bidi iteration could be
28 resumed from there (after widening). (Bug#10360)
30 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
32 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
34 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
36 * nsterm.m (x_free_frame_resources): Release
37 f->output_data.ns->miniimage
38 (ns_index_color): Fix indentation. Do not retain
39 color_table->colors[i].
41 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
44 * nsfns.m (x_set_background_color): Assign return value from
45 ns_index_color to face-background instead of NSColor*.
46 (ns_implicitly_set_icon_type): Fix indentation.
47 Change assignment in for loop to comparison.
49 * emacs.c (ns_pool): New variable.
50 (main): Assign ns_pool.
51 (Fkill_emacs): Call ns_release_autorelease_pool.
53 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
54 autorelease fdesc, release fdAttrs and tdict.
55 (ns_get_covering_families): Release charset.
56 (ns_findfonts): Release NSFontDescriptor created with new.
57 (ns_uni_to_glyphs): Fix indentation.
58 (setString): Release attrStr before assigning new value.
60 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
62 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
64 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
65 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
67 2011-12-18 David Reitter <reitter@cmu.edu>
69 * nsterm.m (ns_term_init): Subscribe for notifications
70 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
71 to method trackingNotification in EmacsMenu.
73 * nsmenu.m (trackingMenu): New variable.
74 (trackingNotification): New method (from Aquamacs).
75 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
76 from Aquamacs (Bug#7030).
78 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
80 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
81 (symbol_to_nsstring): Fix indentation.
82 (ns_symbol_to_pb): New function.
83 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
84 (Fns_rotate_cut_buffers_internal): Removed.
85 (Fns_store_selection_internal): Renamed from
86 Fns_store_cut_buffer_internal.
87 (ns_get_foreign_selection, Fx_own_selection_internal)
88 (Fx_disown_selection_internal, Fx_selection_exists_p)
89 (Fns_get_selection_internal, Fns_store_selection_internal): Use
90 ns_symbol_to_pb and check if return value is nil.
91 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove
92 defsubr Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
93 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
94 renamed to Sns_store_selection_internal.
95 (ns_handle_selection_request): Move code to Fx_own_selection_internal
96 and remove this function.
97 (ns_handle_selection_clear): Remove, never used.
98 (Fx_own_selection_internal): Move code from ns_handle_selection_request
101 2011-12-17 Ken Brown <kbrown@cornell.edu>
103 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
104 GID is unknown (Bug#10257).
106 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
108 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
109 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
110 which caused a build failure on GNU/Linux IA-64. This problem was
111 introduced by my 2011-10-07 patch.
113 2011-12-15 Juri Linkov <juri@jurta.org>
115 * image.c (imagemagick_error): New function. (Bug#10112)
116 (imagemagick_load_image): Comment out `MagickSetResolution' call.
117 Use `imagemagick_error' where ImageMagick functions return
119 (Fimagemagick_types): Add `Fnreverse' to return the list in the
122 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
124 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
125 fill background (Bug#8992).
127 2011-12-13 Martin Rudalics <rudalics@gmx.at>
129 * window.c (Vwindow_combination_resize)
130 (Vwindow_combination_limit): Use t instead of non-nil in
132 (Vrecenter_redisplay): Add first sentence of doc-string on
134 (Frecenter): Fix doc-string typo.
136 2011-12-11 Kenichi Handa <handa@m17n.org>
138 * coding.c (Funencodable_char_position): Pay attention to the
139 buffer text relocation (Bug#9389).
141 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
143 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
144 gtk_init (Bug#10100).
146 2011-12-10 Eli Zaretskii <eliz@gnu.org>
148 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
149 IT->string is nil. (Bug#10263)
151 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
153 * nsterm.h (x_free_frame_resources): Declare.
155 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
156 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
158 * nsterm.h (ns_get_defaults_value): Declare.
160 * nsterm.m (ns_default): Call ns_get_defaults_value.
162 2011-12-09 Eli Zaretskii <eliz@gnu.org>
164 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
167 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
169 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
170 that where the value of an _OBJC_* symbol points to is in the .bss
173 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
175 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
176 after the loop to call ccl_driver at least once (Bug#8619).
178 2011-12-08 Kenichi Handa <handa@m17n.org>
180 * ftfont.c (get_adstyle_property): Fix previous change
183 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
185 * w32.c (init_environment): If no_site_lisp, remove site-lisp
186 dirs from the default value of EMACSLOADPATH (bug#10208).
188 2011-12-07 Glenn Morris <rgm@gnu.org>
190 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
191 installation and source directories as well. (Bug#10208)
193 2011-12-06 Chong Yidong <cyd@gnu.org>
195 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
197 2011-12-06 Glenn Morris <rgm@gnu.org>
199 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
200 as an error, not just -1. (Bug#10217)
202 2011-12-05 Chong Yidong <cyd@gnu.org>
204 * keyboard.c (process_special_events): New function.
205 (swallow_events, Finput_pending_p): Use it (Bug#10195).
207 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
209 * coding.c (encode_designation_at_bol): Don't use uninitialized
210 local variable (Bug#9318).
212 2011-12-05 Kenichi Handa <handa@m17n.org>
214 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
215 return Qnil (Bug#8046, Bug#10193).
217 2011-12-05 Kenichi Handa <handa@m17n.org>
219 * coding.c (encode_designation_at_bol): New args charbuf_end and
220 dst. Return the number of produced bytes. Callers changed.
221 (coding_set_source): Return how many bytes coding->source was
223 (coding_set_destination): Return how many bytes
224 coding->destination was relocated.
225 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
226 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
228 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
230 * coding.c (CODING_CHAR_CHARSET_P): New macro.
231 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
234 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
236 The following changes are to fix Bug#9318.
238 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
239 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
240 (encode_coding_iso_2022, encode_coding_sjis)
241 (encode_coding_big5, encode_coding_charset): Use the above macros.
243 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
245 * lisp.h (process_quit_flag): Fix external declaration.
247 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
249 Don't macro-inline non-performance-critical code.
250 * eval.c (process_quit_flag): New function.
251 * lisp.h (QUIT): Use it.
253 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
255 * nsfns.m (get_geometry_from_preferences): New function.
256 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
258 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
260 * emacs.c (Qkill_emacs): Define.
261 (syms_of_emacs): Initialize it.
262 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
263 Qquit_flag to `kill-emacs' instead.
264 (quit_throw_to_read_char): Add parameter `from_signal'.
265 All callers changed. Call Fkill_emacs if requested and safe.
266 * lisp.h (QUIT): Call Fkill_emacs if requested.
268 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
270 * widget.c (update_wm_hints): Return if wmshell is null.
271 (widget_update_wm_size_hints): New function.
273 * widget.h (widget_update_wm_size_hints): Declare.
275 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
276 widget_update_wm_size_hints (Bug#10104).
278 2011-12-03 Eli Zaretskii <eliz@gnu.org>
280 * xdisp.c (handle_invisible_prop): If the invisible text ends just
281 before a newline, prepare the bidi iterator for consuming the
282 newline, and keep the current paragraph direction. (Bug#10183)
283 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
285 2011-12-02 Juri Linkov <juri@jurta.org>
287 * search.c (Fword_search_regexp): New Lisp function created from
288 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
289 (Fword_search_backward, Fword_search_forward)
290 (Fword_search_backward_lax, Fword_search_forward_lax):
291 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
292 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
294 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
296 * fileio.c (Finsert_file_contents): Move after-change-function call
297 to before the "handled:" label, since all "goto handled" appear in
298 cases where the *-change-functions have already been properly called
301 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
303 * keyboard.c (interrupt_signal): Don't call kill-emacs when
304 waiting for input. (Bug#10169)
306 2011-11-30 Eli Zaretskii <eliz@gnu.org>
308 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
309 verifies glyph row's hash code--we have just reallocated the
310 glyphs, so their contents can be complete garbage. (Bug#10164)
312 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
314 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
316 2011-11-30 Eli Zaretskii <eliz@gnu.org>
318 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
319 attributes are tested _before_ calling verify_row_hash, to protect
320 against GCC re-ordering of the tests. (Bug#10164)
322 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
324 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
326 * xterm.c (handle_one_xevent): Only set async_visible and friends
327 if net_wm_state_hidden_seen is non-zero (Bug#10002)
328 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
329 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
331 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
333 Remove GCPRO-related macros that exist only to avoid shadowing locals.
334 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
335 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
336 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
337 All uses changed to use GCPRO1 etc.
338 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
339 Revert to old implementation (i.e., before 2011-03-11).
341 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
343 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
344 of scroll runs so as to avoid assigning disabled bogus rows and
345 unnecessary graphics copy operations.
347 2011-11-27 Eli Zaretskii <eliz@gnu.org>
349 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
350 (snprintf) [_MSC_VER]: Redirect to _snprintf.
351 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
352 (malloc, free, realloc, calloc): Redirect to e_* only when
355 * lisp.h (GCTYPEBITS): Move before first use.
356 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
357 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
358 this macro definition.
360 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
363 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
365 * gtkutil.c (xg_create_frame_widgets):
366 Call gtk_window_set_has_resize_grip (FALSE) if that function is
367 present with Gtk+ 2.0.
369 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
371 * fileio.c (Finsert_file_contents): Undo previous change; see
372 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
374 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
376 Rename locals to avoid shadowing.
377 * fileio.c (Finsert_file_contents):
378 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
379 * process.c (wait_reading_process_output):
380 Rename inner 'proc' to 'p' to avoid shadowing.
381 Indent for consistency with usual Emacs style.
383 2011-11-25 Eli Zaretskii <eliz@gnu.org>
385 * xdisp.c (redisplay_window): If cursor row is not fully visible
386 after recentering, and scroll-conservatively is set to a large
387 number, scroll window by a few more lines to make the cursor fully
388 visible and out of scroll-margin. (Bug#10105)
389 (start_display): Don't move to the next line if the display should
390 start at a newline that is part of a display vector or an overlay
393 2011-11-24 Juri Linkov <juri@jurta.org>
395 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
396 after the `MagickPingImage' call. (Bug#10112)
398 2011-11-23 Chong Yidong <cyd@gnu.org>
400 * window.c (Fcoordinates_in_window_p): Accept only live windows.
402 2011-11-23 Martin Rudalics <rudalics@gmx.at>
404 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
405 making another buffer current. (Bug#10114)
407 2011-11-23 Glenn Morris <rgm@gnu.org>
409 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
411 2011-11-23 Chong Yidong <cyd@gnu.org>
413 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
416 2011-11-22 Eli Zaretskii <eliz@gnu.org>
418 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
419 and header-lines, as they don't have one computed for them.
422 * .gdbinit (prow): Make displayed values more self-explaining.
425 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
427 * process.c (wait_reading_process_output): Fix asynchrounous
428 GnuTLS socket handling on some versions of the GnuTLS library.
429 (wait_reading_process_output): Add comment and URL.
431 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
433 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
435 2011-11-21 Chong Yidong <cyd@gnu.org>
437 * window.c (Fnext_window, Fprevious_window): Doc fix.
439 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
441 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
443 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
445 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
447 2011-11-20 Martin Rudalics <rudalics@gmx.at>
449 * window.c (Fset_window_combination_limit): Rename argument
451 (Vwindow_combination_limit): Remove "status" from doc-string.
453 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
455 * m/ibms390.h: Remove.
456 * m/ibms390x.h: Don't include "ibms390.h".
458 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
460 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
461 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
463 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
465 * casetab.c (Fset_case_table):
466 * charset.c (Fcharset_after): Fix typos.
468 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
470 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
471 Otherwise, valgrind does not work on some platforms.
472 Problem reported by Andreas Schwab in
473 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
474 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
475 is set, removing the need for VIRT_ADDRESS_VARIES.
476 (PURE_P): Use a more-efficient implementation that needs just one
477 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
478 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
479 to 4 (xorl, subq, cmpq, setbe).
480 * alloc.c (pure): Always extern now, since that's the
481 VIRT_ADDR_VARIES behavior.
482 (PURE_POINTER_P): Use a single comparison, not two, for
483 consistency with the new puresize.h.
484 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
485 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
486 Remove VIRT_ADDR_VARIES no longer needed.
488 2011-11-19 Eli Zaretskii <eliz@gnu.org>
490 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
491 (erase_phys_cursor, update_window_cursor, show_mouse_face)
492 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
493 behave as if the cursor position were at the window margin.
495 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
496 and the cursor position is out of bounds, behave as if the cursor
497 position were at the window margin. (Bug#10075)
499 2011-11-18 Chong Yidong <cyd@gnu.org>
501 * window.c (Fwindow_combination_limit): Make first argument
502 non-optional, since it is meaningless for live windows like the
505 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
507 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
509 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
511 * intervals.c: Fix grafting over the whole buffer (bug#10071).
512 (graft_intervals_into_buffer): Simplify.
514 2011-11-18 Eli Zaretskii <eliz@gnu.org>
516 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
517 hash values of the two rows.
518 (copy_row_except_pointers): Preserve the used[] arrays and the
519 hash values of the two rows. (Bug#10035)
520 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
522 * xdisp.c (row_hash): New function, body extracted from
523 compute_line_metrics.
524 (compute_line_metrics): Call row_hash, instead of computing the
527 * dispnew.c (verify_row_hash): Call row_hash for computing the
528 hash code of a row, instead of duplicating code from xdisp.c.
530 * dispextern.h (row_hash): Add prototype.
532 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
534 * frame.c (delete_frame): Don't delete the terminal when the last
535 X frame is closed if emacs is built with GTK toolkit.
537 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
539 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
541 2011-11-17 Martin Rudalics <rudalics@gmx.at>
543 * window.c (Vwindow_splits): Rename to
544 Vwindow_combination_resize. Suggested by Juri Linkov.
545 (Fsplit_window_internal): Use Vwindow_combination_resize instead
548 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
550 * nsfns.m (Fns_font_name):
551 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
553 2011-11-16 Martin Rudalics <rudalics@gmx.at>
555 * window.h (window): Rename slot "nest" to "combination_limit".
556 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
557 (Fset_window_nest): Rename to Fset_window_combination_limit.
558 (Vwindow_nest): Rename to Vwindow_combination_limit.
559 (recombine_windows, make_parent_window, make_window)
560 (Fsplit_window_internal, saved_window)
561 (Fset_window_configuration, save_window_save): Rename all
562 occurrences of window_nest to window_combination_limit.
564 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
566 * image.c (imagemagick_load_image): Fix typo.
568 2011-11-14 Eli Zaretskii <eliz@gnu.org>
570 * xdisp.c (display_line): Move the call to
571 highlight_trailing_whitespace before the call to
572 compute_line_metrics, since the latter needs to see the final
573 faces of all the glyphs to compute ROW's hash value.
574 Fixes assertion violations in row_equal_p. (Bug#10035)
576 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
578 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
579 just return (bug#10044).
581 2011-11-12 Eli Zaretskii <eliz@gnu.org>
583 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
584 with user-defined heap size. Bump the default size of the temacs
585 heap to 27MB, to avoid memory warning when running temacs.
586 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
588 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
589 current_matrix and desired_matrix. (Bug#9990)
590 (verify_row_hash) [XASSERTS]: New function.
591 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
592 that the hash value of glyph rows is correct.
594 2011-11-12 Martin Rudalics <rudalics@gmx.at>
596 * window.h (window): Remove splits slot.
597 * window.c (Fwindow_splits, Fset_window_splits): Remove.
598 (Fdelete_other_windows_internal, make_parent_window)
599 (make_window, Fsplit_window_internal, Fdelete_window_internal)
600 (Fset_window_configuration, save_window_save): Don't deal with
601 split status of windows.
602 (saved_window): Remove splits slot.
603 (Vwindow_splits): Rewrite doc-string.
605 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
607 * xfns.c (unwind_create_frame):
608 * nsfns.m (unwind_create_frame):
609 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
610 Vframe_list (Bug#9999).
612 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
614 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
616 2011-11-11 Kenichi Handa <handa@m17n.org>
618 * callproc.c (Fcall_process): Set the member dst_multibyte of
621 2011-11-11 Johan Bockgård <bojohan@gnu.org>
623 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
624 avoid a crash (bug#9496).
626 2011-11-09 Chong Yidong <cyd@gnu.org>
628 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
629 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
631 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
633 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
635 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
637 Avoid some portability problems by eschewing 'extern inline' functions.
638 The trivial performance wins aren't worth the portability hassles; see
639 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
641 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
642 (window_box_width, window_box_left, window_box_left_offset)
643 (window_box_right, window_box_right_offset): Undo previous change,
644 by removing the "extern"s.
645 * intervals.c (adjust_intervals_for_insertion)
646 (adjust_intervals_for_deletion): Undo previous change,
647 making these static again.
648 (offset_intervals, temp_set_point_both, temp_set_point)
649 (copy_intervals_to_string): No longer inline.
650 * xdisp.c (window_text_bottom_y, window_box_width)
651 (window_box_height, window_box_left_offset)
652 (window_box_right_offset, window_box_left, window_box_right)
653 (window_box): No longer inline.
655 2011-11-08 Chong Yidong <cyd@gnu.org>
657 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
658 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
659 Signal an error if not a live window.
660 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
661 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
663 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
665 * lisp.h (syms_of_abbrev): Remove declaration.
666 Reported by CHENG Gao <chenggao@royau.me>.
668 2011-11-07 Eli Zaretskii <eliz@gnu.org>
670 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
671 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
672 of temacs in GUI mode.
674 2011-11-07 Martin Rudalics <rudalics@gmx.at>
676 * window.h: Declare delete_all_child_windows instead of
677 delete_all_subwindows.
678 * window.c (Fwindow_nest, Fset_window_nest)
679 (Fset_window_new_total, Fset_window_new_normal)
680 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
681 (delete_all_subwindows): Rename to delete_all_child_windows.
682 (Fdelete_other_windows_internal, Fset_window_configuration):
683 Call delete_all_child_windows instead of delete_all_subwindows.
684 * frame.c (delete_frame): Call delete_all_child_windows instead
685 of delete_all_subwindows.
687 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
689 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
690 This is also needed for porting to any host where GC_MARK_STACK is
691 not GC_MAKE_GCPROS_NOOPS.
692 (which_symbols): Use it.
694 2011-11-07 Kenichi Handa <handa@m17n.org>
696 * coding.c (coding_set_destination): Check coding->src_pos only
697 when coding->src_object is a buffer (bug#9910).
699 * process.c (send_process): Set the member src_multibyte of coding
700 to 0 (bug#9911) when sending a unibyte text.
702 * callproc.c (Fcall_process): Set the member src_multibyte of
703 process_coding to 0 (bug#9912).
705 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
707 * xmenu.c (cleanup_widget_value_tree): New function.
708 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
709 calling free_menubar_widget_value_tree directly (Bug#9830).
711 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
713 Fix some portability problems with 'inline'.
714 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
715 (window_box_width, window_box_left, window_box_left_offset)
716 (window_box_right, window_box_right_offset): Declare extern.
717 Otherwise, these inline functions do not conform to C99 and
718 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
719 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
720 * intervals.c (adjust_intervals_for_insertion)
721 (adjust_intervals_for_deletion): Now extern, because otherwise the
722 extern inline functions 'offset_intervals' couldn't refer to it.
723 (static_offset_intervals): Remove.
724 (offset_intervals): Rewrite using the old contents of
725 static_offset_intervals. The old version didn't conform to C99
726 because an extern inline function contained a reference to an
727 identifier with static linkage.
729 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
731 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
734 2011-11-06 Eli Zaretskii <eliz@gnu.org>
736 * xdisp.c (init_iterator, reseat_to_string): Don't set the
737 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
738 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
739 return Qleft_to_right.
741 2011-11-06 Chong Yidong <cyd@gnu.org>
743 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
744 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
745 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
746 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
747 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
748 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
749 (Fwindow_vscroll): Doc fix.
750 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
751 argument, since it makes no sense to pass a live window and for
752 consistency with window-child.
754 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
756 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
759 2011-11-05 Jason Rumney <jasonr@gnu.org>
761 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
762 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
764 (add_font_entity_to_list): Fix logic errors in mixed boolean and
765 bitwise arithmetic preventing use of unicode-sip and non-truetype
768 2011-11-05 Eli Zaretskii <eliz@gnu.org>
770 * s/ms-w32.h (fstat, stat, utime): Move redirections to
773 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
774 initialization code to keep similarity to xfns.c after changes
777 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
779 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
780 (unwind_create_frame): New function (Bug#9943).
781 (Fx_create_frame): Restructure code to be more similar to the one in
782 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
783 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
784 Move terminal->reference_count++ just before making the frame official
787 * nsterm.m (x_free_frame_resources): New function.
788 (x_destroy_window): Move code to x_free_frame_resources.
790 * xfns.c (unwind_create_frame): Fix comment.
791 (Fx_create_frame, x_create_tip_frame):
792 Move terminal->reference_count++ just before making the frame
793 official. Move initialization of image_cache_refcount and
794 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
796 2011-11-05 Eli Zaretskii <eliz@gnu.org>
798 Support MSVC build with newer versions of Visual Studio.
799 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
800 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
803 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
804 which are not supported by MSVC.
805 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
806 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
808 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
810 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
812 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
814 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
816 Support MSVC build with newer versions of Visual Studio.
817 * w32.c: Don't include w32api.h for MSVC.
818 (init_environment) [_MSC_VER]: Call sys_access, not _access.
820 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
821 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
822 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
823 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
825 (alloca) [_MSC_VER]: Define to _alloca.
827 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
829 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
831 2011-11-04 Eli Zaretskii <eliz@gnu.org>
833 * xdisp.c (note_mouse_highlight): If either of
834 previous/next-single-property-change returns nil, treat that as
835 the beginning or the end of the buffer. (Bug#9955)
837 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
839 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
840 label is not null (Bug#9951).
841 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
844 2011-11-04 Eli Zaretskii <eliz@gnu.org>
846 * window.c (Fwindow_body_size): Mention in the doc string that the
847 return value is in frame's canonical units. (Bug#9949)
849 2011-11-03 Eli Zaretskii <eliz@gnu.org>
851 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
853 * w32fns.c (unwind_create_frame): If needed, free the glyph
854 matrices of the partially constructed frame. (Bug#9943)
855 * xfns.c (unwind_create_frame): Likewise.
857 2011-11-01 Eli Zaretskii <eliz@gnu.org>
859 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
860 Don't stop backward scan on the continuation glyph, even though
861 its CHARPOS is positive.
862 (mouse_face_from_buffer_pos, note_mouse_highlight):
863 Rename cover_string to disp_string.
865 2011-11-01 Martin Rudalics <rudalics@gmx.at>
867 * window.c (temp_output_buffer_show): Don't use
868 Vtemp_buffer_show_specifiers.
869 (Vtemp_buffer_show_specifiers): Remove unused variable.
871 2011-10-30 Eli Zaretskii <eliz@gnu.org>
873 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
874 past the beginning of the current glyph matrix.
876 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
878 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
879 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
880 HAVE_GTK3 (Bug#9869).
882 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
883 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
885 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
887 * xterm.c: Declare x_handle_net_wm_state to return int.
888 (handle_one_xevent): Check if we are iconified but don't have
889 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
890 (get_current_wm_state): Return non-zero if not hidden,
891 check for _NET_WM_STATE_HIDDEN (Bug#9893).
892 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
893 (x_handle_net_wm_state): Return what get_current_wm_state returns.
894 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
896 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
898 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
899 so that this new function doesn't get optimized away by a
900 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
902 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
904 * frame.h (MOUSE_HL_INFO): Remove excess parens.
906 2011-10-29 Eli Zaretskii <eliz@gnu.org>
908 Fix the `xbytecode' command.
909 * .gdbinit (xprintbytestr): New command.
910 (xwhichsymbols): Rename from `which'; all callers changed.
911 (xbytecode): Print the byte-code string as well.
913 2011-10-29 Kim Storm <storm@cua.dk>
915 * alloc.c (which_symbols): New function.
917 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
919 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
922 2011-10-29 Glenn Morris <rgm@gnu.org>
924 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
925 Not clear what it was for, and it causes various bugs. (Bug#9839)
927 2011-10-28 Eli Zaretskii <eliz@gnu.org>
929 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
930 possible random value that matches one of those tested as
931 condition to clear the mouse face.
933 2011-10-28 Chong Yidong <cyd@gnu.org>
935 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
937 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
939 * window.c (make_window): Initialize phys_cursor_on_p.
941 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
943 * lisp.h (struct Lisp_Symbol): Update comments.
945 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
947 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
949 2011-10-28 Eli Zaretskii <eliz@gnu.org>
951 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
952 <oslsachem@gmail.com> for helping to debug this.
954 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
955 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
956 (g_b_init_get_glyph_outline_w): New static variables.
957 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
958 (GetGlyphOutlineW_Proc): New typedefs.
959 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
960 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
962 (w32font_open_internal, compute_metrics):
963 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
964 instead of calling the "wide" APIs directly.
966 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
968 * w32.h (syms_of_w32font): Add prototype.
970 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
972 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
973 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
974 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
975 (Fmove_to_window_line): Doc fix.
977 2011-10-27 Chong Yidong <cyd@gnu.org>
979 * process.c (make_process): Set gnutls_state to NULL.
981 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
982 non-NULL, regardless of GNUTLS_INITSTAGE.
983 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
984 an error. Set process slots as soon as we allocate them.
986 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
988 2011-10-27 Chong Yidong <cyd@gnu.org>
990 * gnutls.c (emacs_gnutls_deinit): New function.
991 Deallocate credentials structures as well as calling gnutls_deinit.
992 (Fgnutls_deinit, Fgnutls_boot): Use it.
994 * process.c (make_process): Initialize GnuTLS credentials to NULL.
995 (deactivate_process): Call emacs_gnutls_deinit.
997 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
999 * image.c (x_create_x_image_and_pixmap):
1000 * w32.c (sys_rename, w32_delayed_load):
1001 * w32font.c (fill_in_logfont):
1002 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1004 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1006 * w32fns.c (w32_default_color_map): New function,
1007 extracted from Fw32_default_color_map.
1008 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1010 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1012 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1014 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1016 * keyboard.c (test_undefined): New function (bug#9751).
1017 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1019 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1021 * sysdep.c (init_sys_modes): Fix the check for the controlling
1022 terminal (Bug#6649).
1024 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1026 * dispextern.h (struct bidi_it): New member next_en_type.
1028 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1029 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1030 current character, check also for next_en_type being WEAK_EN.
1031 (bidi_resolve_weak): Don't enter the expensive loop if the current
1032 position is before next_en_pos. Record the bidi type of the first
1033 non-ET, non-BN character we find, in addition to its position.
1034 (bidi_level_of_next_char): Invalidate next_en_type when
1035 next_en_pos is over-stepped.
1037 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1039 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1040 * editfns.c: Rewrite current-time-zone so that it invokes
1041 the equivalent of (format-time-string "%Z") to get the time zone name.
1042 This fixes a bug when the time zone name contains characters that
1043 need converting from the system time locale to Emacs internal format.
1044 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1045 that patch fixed format-time-string to do the conversion, but
1046 I forgot to fix current-time-zone.
1047 (format_time_string): New function, containing most of
1048 what Fformat_time_string used to contain.
1049 (Fformat_time_string): Rewrite in terms of format_time_string.
1050 This doesn't change this function's behavior.
1051 (current-time-zone): Rewrite to use format_time_string.
1052 This fixes the bug reported by Michael Schierl in
1053 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1054 Jason Rumney's 2007-06-07 change worked around this bug, but
1056 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1058 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1060 * xdisp.c (start_display): If the character at POS is displayed
1061 via a display vector, reset IT->current.dpvec_index to zero.
1062 (try_window_reusing_current_matrix): If a line ends in a display
1063 vector or the next line starts in a display vector, continue
1064 redrawing the window even though the character position of
1065 start_row was reached.
1068 2011-10-18 Chong Yidong <cyd@gnu.org>
1070 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1071 with nobreak-char-display too.
1073 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1075 Fix part 3 of bug#9771.
1076 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1077 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1078 non-neutral characters if the current character is a paragraph
1079 separator (a.k.a. Newline). This avoids running the same
1080 expensive loop twice, once when we consume the preceding newline
1081 and the other time when the line actually needs to be displayed.
1082 Avoid the loop when we see neutrals on the base embedding level
1083 following a character whose directionality is the same as the
1084 paragraph's. This avoids running the expensive loop when a line
1085 ends in a long sequence of neutrals, like control characters.
1086 Add assertion against STRONG_AL type. Slightly rearrange code
1087 that determines the type of a neutral given the first non-neutral
1089 (bidi_level_of_next_char): Set next_en_pos to zero when
1090 invalidating its info.
1092 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1094 * xdisp.c (push_display_prop): Determine whether to record string
1095 or buffer position by IT->string, not by IT->method. Allow
1096 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1097 (move_it_vertically_backward): Don't look for character position
1098 immediately after the newline when in a continuation line.
1101 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1103 * window.c (coordinates_in_window): Rewrite and delabelize
1104 vertical border check. (Bug#5357) (Bug#9618)
1106 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1108 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1109 errors in XSetWindowBorder (bug#9310).
1111 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1113 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1114 avoid crash when xmalloc overrun checking is enabled.
1116 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1118 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1119 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1120 cursor motion with <left> and <right> arrow keys.
1122 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1123 some callers set that themselves.
1125 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1127 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1128 display string and the previous row comes from the same string and
1129 is empty. (Bug#9739) (Bug#9738)
1131 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1133 * doc.c (get_doc_string): Encode file name (bug#9735).
1135 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1137 * bidi.c (bidi_level_of_next_char):
1138 * xdisp.c (get_visually_first_element): Remove old incorrect
1139 comments regarding the Unicode Line Separator character.
1141 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1143 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1145 * alloc.c (Fgc_status): Do not access beyond zombies array
1146 boundary if nzombies > MAX_ZOMBIES.
1147 * alloc.c (dump_zombies): Add missing format specifier.
1149 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1151 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1152 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1154 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1155 Some packages use them to denote characters with modifiers.
1157 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1159 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1160 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1161 matching a pp-number. Rename parameter var to var1.
1163 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1165 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1167 2011-10-08 Glenn Morris <rgm@gnu.org>
1169 * callint.c (Fcall_interactively): Give a more explicit error for the
1170 'c' case with a non-character input. (Bug#8479)
1172 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1174 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1176 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1177 lines that are hscrolled on the left.
1179 * dispnew.c (buffer_posn_from_coords): Account for a possible
1180 presence of header-line. (Bug#4426)
1182 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1184 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1185 Don't advertise functionality which we discourage or doesn't work.
1187 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1189 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1190 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1191 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1192 this makes Emacs dump core during garbage collection on rare
1193 occasions. sizeof is obviously inferior to offsetof here, so
1194 stick with offsetof.
1195 (GC_POINTER_ALIGNMENT): New macro.
1196 (mark_memory): Omit 3rd (offset) arg; caller changed.
1197 Don't assume EMACS_INT alignment is the same as pointer alignment.
1199 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1201 * keyboard.c (read_key_sequence_remapped): New var.
1202 (read_key_sequence): Compute remapping in the right buffer.
1203 (command_loop_1): Use read_key_sequence's remapping directly.
1205 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1207 * dired.c (file_name_completion): Don't expand file name.
1208 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1209 before checking file name handler.
1211 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1212 they've been requested explicitly (bug#9591).
1214 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1216 * keymap.c (Fsingle_key_description): Use make_specified_string
1217 instead of build_string to build string from push_key_description.
1220 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1222 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1223 This fixes a Y2038 bug on 64-bit hosts.
1224 * buffer.c (reset_buffer):
1225 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1226 (Fclear_buffer_auto_save_failure):
1227 Use 0, not -1, to represent an unset failure time, since time_t
1228 might not be signed.
1230 Remove dependency on glibc malloc internals.
1231 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1232 Move back here from lisp.h, but with their new implementations.
1233 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1234 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1235 * charset.c (charset_table_init): New static var.
1236 (syms_of_charset): Use it instead of xmalloc. This removes a
1237 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1238 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1239 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1240 Move back to alloc.c.
1241 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1242 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1244 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1246 * nsterm.m (windowDidResize): Call x_set_window_size only when
1247 ns_in_resize is true. Otherwise set pixelwidth/height and
1248 call change_frame_size (Bug#9628).
1250 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1252 Port --enable-checking=all to Fedora 14 x86-64.
1253 * charset.c (syms_of_charset): Also account for glibc malloc's
1254 internal overhead when calculating the initial malloc maximum.
1256 Port --enable-checking=all to Fedora 14 x86.
1257 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1259 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1260 (overrun_check_realloc, overrun_check_free):
1261 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1262 That way, xmalloc returns a properly-aligned pointer even if
1263 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1264 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1265 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1266 into account when calculating the initial malloc maximum.
1267 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1268 Move here from alloc.c, so that charset.c can use it too.
1269 Properly align; the old code wasn't right for common 32-bit hosts
1270 when configured with --enable-checking=all.
1271 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1272 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1274 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1276 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1279 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1281 * xdisp.c (compute_display_string_end): If there's no display
1282 string at CHARPOS, return -1.
1284 * bidi.c (bidi_fetch_char): When compute_display_string_end
1285 returns a negative value, treat the character as a normal
1286 character not covered by a display string. (Bug#9624)
1288 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1290 * lread.c (Fread_from_string): Fix typo in docstring.
1292 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1294 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1295 newline, reseat the iterator instead of bidi-iterating there one
1296 character at a time. (Bug#9610)
1297 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1298 TO_CHARPOS if the bidi iterator is at base embedding level.
1300 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1302 * lread.c (readevalloop): Use correct code for NBSP.
1303 (read1): Likewise. (Bug#9608)
1305 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1307 * dbusbind.c (Fdbus_register_signal): When service is not
1308 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1310 2011-09-25 Glenn Morris <rgm@gnu.org>
1312 * buffer.c (truncate-lines): Doc fix.
1314 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1316 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1317 (Fset_window_next_buffers): Doc fix.
1319 2011-09-24 Glenn Morris <rgm@gnu.org>
1321 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1323 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1325 Fix minor problems found by static checking.
1326 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1327 * indent.c (Fvertical_motion): Fix == vs = typo.
1329 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1331 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1332 Default value is now t. Doc fix.
1334 * indent.c (Fvertical_motion): Compute and apply the overshoot
1335 logic when moving up, not only when moving down. Fix the
1336 confusing name and values of the it_overshoot_expected variable;
1337 logic changes accordingly. (Bug#9254) (Bug#9549)
1339 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1340 CHARPOS is covered by a display string which includes newlines.
1341 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1342 is covered by a display string with embedded newlines.
1344 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1346 * dbusbind.c (Fdbus_register_signal): Add match rule to
1347 Vdbus_registered_objects_table. (Bug#9581)
1348 (Fdbus_register_method, Vdbus_registered_objects_table):
1351 2011-09-24 Jim Meyering <meyering@redhat.com>
1353 do not ignore write error for any output size
1354 The previous change was incomplete.
1355 While it makes emacs --batch detect the vast majority of stdout
1356 write failures, errors were still ignored whenever the output size is
1357 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1358 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1359 && echo FAIL: ignored write error
1360 FAIL: ignored write error
1361 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1362 && echo FAIL: ignored write error
1363 FAIL: ignored write error
1364 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1366 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1368 * emacs.c (Fkill_emacs): In noninteractive mode exit
1369 non-successfully if a write error occurred on stdout. (Bug#9574)
1371 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1373 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1376 * dispextern.h (struct it): Update the comment documenting what
1379 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1381 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1382 a display string, extend search for cursor position to end of row.
1383 (find_row_edges): If the row ends in a newline from a display
1384 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1385 Handle the case of a display string with multiple newlines.
1386 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1387 non-empty line. Fixes confusing cursor motion with arrow keys at
1388 the beginning of a line that starts with whitespace.
1390 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1392 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1395 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1397 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1400 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1402 * xdisp.c (display_line): Record maximum and minimum buffer
1403 positions even if no glyphs were produced (e.g., by a zero-width
1404 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1405 buffer positions that will be removed from the glyph row because
1407 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1408 column is beyond frame width: don't subtract 1 "pixel" when
1409 computing width of the stretch.
1410 (reseat_at_next_visible_line_start): Undo the change made on
1411 2011-09-17 that saved paragraph information and restored it after
1412 the call to `reseat'. (Bug#9545)
1414 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1416 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1417 and turn window cursor on if cleared (Bug#9415).
1419 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1421 * search.c (boyer_moore): Take unibyte characters from pattern
1422 literally. (Bug#9458)
1424 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1426 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1428 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1430 Fix minor problem found by static checking.
1431 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1432 initialized, to pacify gcc -Wuninitialized.
1434 * fileio.c: Report proper errno when syscall falls.
1435 (Finsert_file_contents): Save and restore errno,
1436 so that report_file_error outputs the correct diagnostic.
1437 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1439 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1441 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1443 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1445 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1446 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1448 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1450 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1451 about the current paragraph and restore it after the call to reseat.
1453 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1454 (bidi_find_paragraph_start): Search back for paragraph beginning
1455 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1456 (bidi_move_to_visually_next): Only trigger paragraph-related
1457 computations when the last character is a newline or at EOB, not
1458 just any NEUTRAL_B. (Bug#9470)
1460 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1461 truncated lines if point is covered by a display string. (Bug#9524)
1463 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1465 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1466 (cons_to_x_long): New function.
1467 (lisp_data_to_selection_data): Use it. Correct the test for
1468 short-versus-long data; it was negated. Break out of vector
1469 loop, for efficiency, when a long datum is discovered.
1471 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1473 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1475 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1477 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1478 GCC PR/17406) by declaring this function with external scope.
1480 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1482 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1483 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1485 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1487 * editfns.c (Fformat): Correctly handle text properties on "%%".
1489 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1491 * xterm.c (x_draw_composite_glyph_string_foreground):
1492 * w32term.c (x_draw_composite_glyph_string_foreground):
1493 * term.c (encode_terminal_code):
1494 * composite.c (composition_update_it, get_composition_id):
1495 * xdisp.c (get_next_display_element)
1496 (fill_composite_glyph_string): Add comments about special meaning
1497 of TAB characters in a composition.
1499 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1501 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1502 This occurs when processing a multibyte format.
1503 Problem reported by Wolfgang Jenker.
1505 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1507 * xdisp.c (try_cursor_movement): Only check for exact match if
1508 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1510 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1512 Remove unused external symbols.
1513 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1514 * xdisp.c (calc_pixel_width_or_height): Now static.
1515 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1516 * indent.c (check_display_width):
1517 * w32term.c: Fix comment to match code.
1518 * xterm.c, xterm.h (x_catching_errors): Remove.
1520 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1522 * xselect.c: Use signed conversions more consistently (Bug#9498).
1523 (selection_data_to_lisp_data): Assume incoming selection data are
1524 signed integers, not unsigned. This is to be consistent with
1525 outgoing selection data, which was modified to use signed integers
1526 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1527 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1528 expects long, not unsigned long.
1530 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1532 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1533 computation of loop end. Reported by Johan Bockgård
1536 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1538 * frame.c (Fother_visible_frames_p): Function deleted.
1540 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1542 * indent.c (compute_motion): Process display vector front to back
1543 rather than the other way around. (Bug#2496)
1545 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1547 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1549 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1551 * minibuf.c (Fread_from_minibuffer): Doc fix.
1553 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1555 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1556 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1558 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1560 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1561 value for non-existent files.
1563 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1565 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1566 set its "size" to -1. This will set the modtime_size field of
1567 the corresponding buffer to -1, which is what
1568 verify-visited-file-modtime expects for files that do not exist.
1571 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1573 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1575 * lisp.h: ... from here. push_key_description is no longer
1576 defined in keyboard.c, so its declaration should not be in
1577 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1578 logically belongs with push_key_description.
1580 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1582 * buffer.h: Include <sys/types.h> instead of <time.h>.
1583 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1584 Problem reported by Herbert J. Skuhra.
1586 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1588 * xml.c (parse_region): Make the parsing work for
1589 non-comment-starting XML files again (bug#9144).
1591 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1593 * image.c (gif_load): Fix calculation of bottom and right corner.
1596 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1598 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1599 redisplay in small windows.
1601 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1603 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1605 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1607 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1608 Operate on live windows only.
1610 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1612 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1614 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1616 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1617 only under bidi iteration.
1619 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1621 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1623 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1625 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1626 Without this fix, the command to link temacs failed due to an
1627 undefined symbol __builtin_isnan. This is because
1628 /usr/include/iso/math_c99.h #defines isnan(x) to
1629 __builtin_isnan(x), but the bundled gcc, which identifies itself
1630 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1632 * floatfns.c (isnan): #undef, and then #define to a clone of
1634 (Fisnan): Always define, since it's always available now.
1635 (syms_of_floatfns): Always define isnan at the Lisp level.
1637 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1639 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1641 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1643 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1644 The previous code assumed that file offsets (off_t values) fit in
1645 EMACS_INT variables, which is not true on typical 32-bit hosts.
1646 The code messed up by falsely reporting buffer overflow in cases
1647 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1648 when "big" contains more than 2**29 bytes, even though this
1649 inserts just one byte and does not overflow the buffer.
1650 (Finsert_file_contents): Store file offsets as off_t
1651 values, not as EMACS_INT values. Check for overflow when
1652 converting between EMACS_INT and off_t. When checking for
1653 buffer overflow or for overlap, take the offsets into account.
1654 Don't use EMACS_INT for small values where int suffices.
1655 When checking for overlap, fix a typo: ZV was used where
1656 ZV_BYTE was intended.
1657 (Fwrite_region): Don't assume off_t fits into 'long'.
1658 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1660 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1662 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1664 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1666 sprintf-related integer and memory overflow issues (Bug#9412).
1668 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1669 (esprintf, exprintf, evxprintf): New functions.
1670 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1671 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1672 (modify_event_symbol): Do not assume that the length of
1673 name_alist_or_stem is safe to alloca and fits in int.
1674 (Fexecute_extended_command): Likewise for function name and binding.
1675 (Frecursion_depth): Wrap around reliably on integer overflow.
1676 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1677 since some callers pass EMACS_INT values.
1678 (Fsingle_key_description): Don't crash if symbol name contains more
1679 than MAX_ALLOCA bytes.
1680 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1681 (get_minibuffer): Arg is now EMACS_INT, not int.
1682 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1683 (esprintf, exprintf, evxprintf): New decls.
1684 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1686 * dbusbind.c (signature_cat): New function.
1687 (xd_signature, Fdbus_register_signal):
1688 Do not overrun buffer; instead, report string overflow.
1690 * dispnew.c (add_window_display_history): Don't overrun buffer.
1691 Truncate instead; this is OK since it's just a log.
1693 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1694 even if the time zone offset is outlandishly large.
1695 Don't mishandle offset == INT_MIN.
1697 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1698 when creating daemon; the previous buffer-overflow check was incorrect.
1700 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1701 which has the guts of the old verror function.
1703 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1704 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1706 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1707 (font_unparse_xlfd): Don't blindly alloca long strings.
1708 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1709 fits in int, when using sprintf. Use single snprintf to count
1710 length of string rather than counting it via multiple sprintfs;
1711 that's simpler and more reliable.
1712 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1713 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1714 sprintf, in case result does not fit in int.
1716 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1717 (fontset_from_font): Print it.
1719 * frame.c (tty_frame_count): Now printmax_t, not int.
1720 (make_terminal_frame, set_term_frame_name): Print it.
1721 (x_report_frame_params): In X, window IDs are unsigned long,
1722 not signed long, so print them as unsigned.
1723 (validate_x_resource_name): Check for implausibly long names,
1724 and don't assume name length fits in 'int'.
1725 (x_get_resource_string): Don't blindly alloca invocation name;
1726 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1729 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1730 (xg_check_special_colors, xg_set_geometry):
1731 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1733 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1734 Use esprintf, not sprintf, in case result does not fit in int.
1736 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1737 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1738 it as a large positive number.
1739 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1740 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1742 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1743 in case result does not fit in int.
1745 * print.c (float_to_string): Detect width overflow more reliably.
1746 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1747 buffer overrun. Don't assume list length fits in 'int'. Treat
1748 print length of 0 as 0, not as infinity; to be consistent with other
1749 uses of print length in this function. Don't overflow print length
1750 index. Don't assume hash table size fits in 'long', or that
1751 vectorlike size fits in 'unsigned long'.
1753 * process.c (make_process): Use printmax_t, not int, to format
1754 process-name gensyms.
1756 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1758 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1759 to avoid potential buffer overrun.
1761 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1762 if X resource line is longer than 512 bytes.
1764 * xfns.c (x_window): Make sprintf buffer a bit bigger
1765 to avoid potential buffer overrun.
1767 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1769 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1771 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1773 Integer overflow fixes for scrolling, etc.
1774 Without these, Emacs silently mishandles large integers sometimes.
1775 For example, "C-u 4294967297 M-x recenter" was treated as if
1776 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1778 * xdisp.c (try_window_id): Check Emacs fixnum range before
1779 converting to 'int'.
1781 * window.c (window_scroll_line_based, Frecenter):
1782 Check that an Emacs fixnum is in range before assigning it to 'int'.
1783 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1784 values converted from Emacs fixnums.
1785 (Frecenter): Don't wrap around a line count if it is out of 'int'
1786 range; instead, treat it as an extreme value.
1787 (Fset_window_configuration, compare_window_configurations):
1788 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1790 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1791 that can exceed INT_MAX. Check that EMACS_INT value is in range
1792 before assigning it to the (possibly-narrower) index.
1793 (match_limit): Don't assume that a fixnum can fit in 'int'.
1795 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1798 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1799 (Fvertical_motion): Don't wrap around LINES values that don't fit
1800 in 'int'. Instead, treat them as extreme values. This is good
1801 enough for windows, which can't have more than INT_MAX lines anyway.
1803 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1805 * Require libxml/parser.h to avoid compilation warning.
1807 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1809 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1810 since this reportedly can destroy thread storage.
1812 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1814 * syntax.c (find_defun_start): Update all cache variables if
1815 exiting early (Bug#9401).
1817 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1819 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1821 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1822 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1823 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1825 * term.c (tty_append_glyph): New function.
1826 (produce_stretch_glyph): Static function and its prototype deleted.
1828 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1831 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1833 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1834 when checking :margin (Bug#9390).
1835 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1836 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1837 so that the name doesn't mislead. All uses changed.
1839 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1841 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1844 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1846 * xdisp.c (move_it_to): Don't bail out early when reaching
1847 position beyond to_charpos, if we are scanning backwards.
1848 (move_it_vertically_backward): When DY == 0, make sure we get to
1849 the first character in the line after the newline.
1851 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1853 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1854 (ccl_driver): Do not generate an out-of-range pointer.
1855 (Fccl_execute_on_string): Remove unnecessary check for
1856 integer overflow, noted by Stefan Monnier in
1857 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1858 Remove a FIXME that didn't need fixing.
1859 Simplify the newly-introduced buffer reallocation code.
1861 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1863 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1865 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1867 Integer and memory overflow issues (Bug#9196).
1869 * doc.c (get_doc_string): Rework so that
1870 get_doc_string_buffer_size is the actual buffer size, rather than
1871 being 1 less than the actual buffer size; this makes xpalloc more
1874 * image.c (x_allocate_bitmap_record, cache_image):
1875 * xselect.c (Fx_register_dnd_atom):
1876 Simplify previous changes by using xpalloc.
1878 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1879 since either will do and ptrdiff_t is convenient with xpalloc.
1881 * charset.c (charset_table_size)
1882 (struct charset_sort_data.priority): Now ptrdiff_t.
1883 (charset_compare): Don't overflow if priorities differ greatly.
1884 (Fsort_charsets): Don't assume list length fits in int.
1885 Check for size-calculation overflow when allocating sort data.
1886 (syms_of_charset): Allocate an initial charset table that is
1887 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1889 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1891 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1892 The actual value is always <= INT_MAX, and leaving it unsigned made
1893 overflow checking harder.
1895 * dispextern.h (struct glyph_matrix.rows_allocated)
1896 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1897 with xpalloc. The values are still always <= INT_MAX.
1899 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1901 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1902 (SAFE_NALLOCA): New macro.
1904 * region-cache.c (struct boundary.pos, find_cache_boundary)
1905 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1906 (set_cache_region, invalidate_region_cache)
1907 (revalidate_region_cache, know_region_cache, region_cache_forward)
1908 (region_cache_backward, pp_cache):
1909 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1910 so that ptrdiff_t * can be passed to xpalloc.
1911 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1912 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1913 (pp_cache): Don't assume cache_len fits in int.
1914 * region-cache.h: Adjust extern decls to match.
1916 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1917 EMACS_INT, since either will do, for xpalloc.
1919 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1920 (xnmalloc, xnrealloc, xpalloc): New functions.
1922 * bidi.c (bidi_shelve_header_size): New constant.
1923 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1924 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1926 * bidi.c (bidi_cache_shrink):
1927 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1929 Don't update size of array until after memory allocation succeeds,
1930 because xmalloc/xrealloc may not return.
1931 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1932 now that we have proper integer overflow checking.
1933 (record_overlay_string, overlay_strings): Catch overflows when
1934 calculating size of overlay_str_buf.
1936 * callproc.c (Fcall_process): Check for size overflow when
1937 calculating size of args2.
1938 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1939 Normally we prefer signed values, but sticking with ptrdiff_t would
1940 require adding more-complicated checks.
1942 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1943 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1944 Redo buffer-overflow calculations to avoid integer overflow.
1945 Add a FIXME comment where memory seems to be over-allocated.
1947 * character.c (Fstring): Check for size-calculation overflow.
1949 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1950 unnecessary integer overflow. Check for size overflow.
1951 (encode_coding_object): Don't update size until xmalloc succeeds.
1953 * composite.c (get_composition_id): Check for overflow in glyph
1954 length calculations.
1956 Integer and memory overflow fixes for display code.
1957 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1958 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1959 (scrolling_window): Check for overflow in size calculations.
1960 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1961 Don't assume glyph table len fits in int.
1962 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1963 (row_table_size): Now ptrdiff_t, not int.
1964 (scrolling_window): Avoid overflow in size calculations.
1965 Don't update size until allocation succeeds.
1966 * fns.c (concat): Check for overflow in size calculations.
1967 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1968 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1969 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1971 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1972 (get_doc_string): Check for size calculation overflow.
1973 Don't update size until allocation succeeds.
1974 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1975 EMACS_INT, where ptrdiff_t will do.
1976 (Fsubstitute_command_keys): Check for string overflow.
1978 * editfns.c (set_time_zone_rule): Don't assume environment length
1980 (message_length): Now ptrdiff_t, not int.
1981 (Fmessage_box): Don't update size until allocation succeeds.
1982 Don't assume message length fits in int.
1983 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1985 * emacs.c (main): Do not reallocate argv, since there is a null at
1986 the end that can be overwritten, and this way there's no need to
1987 worry about size-calculation overflow.
1988 (sort_args): Check for size-calculation overflow.
1990 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1992 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1994 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1995 (x_set_scroll_bar_width, x_figure_window_size):
1996 Check for integer overflow.
1997 (x_set_alpha): Do not assume XINT fits in int.
1999 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2000 This is for the members text_lines, text_cols, total_lines, total_cols,
2001 where the system imposes an 'int' limit.
2003 * fringe.c (Fdefine_fringe_bitmap):
2004 Don't update size until alloc works.
2006 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2007 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2009 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2010 Check for size-calculation overflow.
2011 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2012 do, as we prefer signed integers.
2013 (id_to_widget.max_size, id_to_widget.used)
2014 (xg_store_widget_in_map, xg_remove_widget_from_map)
2015 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2016 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2017 Use and return ptrdiff_t, not int.
2018 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2019 * gtkutil.h: Change prototypes to match the above.
2021 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2022 are duplicate now that they've been promoted to lisp.h.
2023 (x_allocate_bitmap_record, x_alloc_image_color)
2024 (make_image_cache, cache_image, xpm_load):
2025 Don't update size until alloc is done.
2026 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2028 Check for size calculation overflow.
2029 (ct_colors_allocated_max): New constant.
2030 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2033 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2034 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2035 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2036 Use ptrdiff_t, not int, to count maps.
2037 (read_char_minibuf_menu_prompt): Check for overflow in size
2038 calculations. Don't update size until allocation succeeds.
2039 Redo calculations to avoid overflow.
2040 * keyboard.h: Change prototypes to match the above.
2042 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2044 (current_minor_maps): Check for size calculation overflow.
2045 * keymap.h: Change prototypes to match the above.
2047 * lread.c (read1, init_obarray): Don't update size until alloc done.
2049 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2050 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2052 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2053 Now ptrdiff_t, not int.
2054 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2055 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2057 * process.c (Fnetwork_interface_list): Check for overflow
2058 in size calculation.
2060 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2062 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2063 overflow. Don't bother calling xmalloc when xrealloc will do.
2065 * search.c (Freplace_match): Check for size calculation overflow.
2066 (Fset_match_data): Don't assume list lengths fit in 'int'.
2068 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2069 for command line length. Do not attempt to address one before the
2070 beginning of an array, as that's not portable.
2072 * term.c (max_frame_lines): Remove; unused.
2073 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2075 (encode_terminal_code, calculate_costs): Check for size
2076 calculation overflow.
2077 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2078 table lengths and related sizes. Don't update size until alloc
2079 done. Redo calculations to avoid overflow.
2080 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2082 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2083 subtracting pointers.
2084 (gobble_line): Check for overflow more carefully. Don't update size
2087 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2088 Don't update size until alloc done.
2089 Redo size calculations to avoid overflow.
2090 Check for size calculation overflow.
2091 (main) [DEBUG]: Fix typo in invoking tparam1.
2093 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2094 Use ptrdiff_t, not int, for sizes.
2095 (store_mode_line_noprop_char): Don't update size until alloc done.
2097 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2098 Use ptrdiff_t, not int, for sizes.
2099 (Finternal_make_lisp_face, cache_face):
2100 Check for size calculation overflow.
2101 (cache_face): Treat size calculation overflows as if they were
2102 memory exhaustion (the usual treatment), rather than aborting.
2104 * xfns.c (x_encode_text, x_set_name_internal)
2105 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2106 sizes, since they can exceed INT_MAX in size. Check for size
2107 calculation overflow.
2109 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2110 (xg_select): Check for size calculation overflow.
2111 Don't update size until alloc done.
2113 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2114 as sprintf is limited to int lengths.
2116 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2117 (X_LONG_MIN): New macros.
2118 Use them to make the following changes clearer.
2119 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2120 This change doesn't affect the value now, but it may help remind
2121 future maintainers not to raise the value too much later.
2122 (SELECTION_QUANTUM): Remove, replacing with ...
2123 (selection_quantum): ... new function, which avoids overflow.
2125 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2126 assumption that selection length fits in 'int'.
2127 (x_reply_selection_request, x_handle_selection_request)
2128 (x_get_window_property, receive_incremental_selection)
2129 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2130 (lisp_data_to_selection_data, clean_local_selection_data):
2131 Use ptrdiff_t, not int, to record length of selection.
2132 (x_reply_selection_request, x_get_window_property)
2133 (receive_incremental_selection, x_property_data_to_lisp):
2134 Redo calculations to avoid overflow.
2135 (x_reply_selection_request): When sending hint, ceiling it at
2136 X_LONG_MAX rather than relying on wraparound overflow to send
2138 (x_get_window_property, receive_incremental_selection)
2139 (lisp_data_to_selection_data, x_property_data_to_lisp):
2140 Check for size-calculation overflow.
2141 (x_get_window_property, receive_incremental_selection)
2142 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2143 Don't store size until memory allocation succeeds.
2144 (x_get_window_property): Plug memory leak on memory exhaustion.
2145 Don't double-block input; malloc is safe here. Don't assume 2**34
2146 - 4 fits in unsigned long. Add an xassert to check
2147 XGetWindowProperty overflow. Be more careful about overflow
2148 calculations, and distinguish size from memory overflow better.
2149 (receive_incremental_selection): When tracing, don't assume
2150 unsigned int is less than INT_MAX.
2151 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2152 harmful) conversions of unsigned short to int.
2153 (lisp_data_to_selection_data): Don't assume that integers
2154 in the range -65535 through -1 fit in an X unsigned short.
2155 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2156 result parameters unless successful. Rely on cons_to_unsigned
2157 to report problems with elements; the old code wasn't right anyway.
2158 (x_check_property_data): Check for int overflow; we cannot use
2159 a wider type due to X limits.
2160 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2162 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2164 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2165 (x_term_init): Check for size calculation overflow.
2166 (x_color_cells): Don't store size until memory allocation succeeds.
2167 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2168 Don't assume alloca size is less than MAX_ALLOCA.
2169 (x_term_init): Don't assume length fits in int (sprintf is limited
2172 Use ptrdiff_t for composition IDs.
2173 * character.c (lisp_string_width):
2174 * composite.c (composition_table_size, n_compositions)
2175 (get_composition_id, composition_gstring_from_id):
2176 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2177 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2178 * window.c (Frecenter):
2179 Use ptrdiff_t, not int, for composition IDs.
2180 * composite.c (get_composition_id): Check for integer overflow.
2181 * composite.h: Adjust prototypes to match the above changes.
2183 Use ptrdiff_t for hash table indexes.
2184 * category.c (hash_get_category_set):
2185 * ccl.c (ccl_driver):
2186 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2187 * coding.c (coding_system_charset_list, detect_coding_system):
2188 * coding.h (struct coding_system.id):
2189 * composite.c (get_composition_id, gstring_lookup_cache):
2190 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2191 * image.c (xpm_get_color_table_h):
2192 * lisp.h (hash_lookup, hash_put):
2193 * minibuf.c (Ftest_completion):
2194 Use ptrdiff_t for hash table indexes, not int (which is too
2195 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2196 32-bit --with-wide-int hosts).
2198 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2199 Add a FIXME comment about memory leaks.
2200 (syms_of_charset): Don't assume xmalloc returns.
2202 Don't assume that stated character widths fit in int.
2203 * character.c (Fchar_width, c_string_width, lisp_string_width):
2204 * character.h (CHAR_WIDTH):
2205 * indent.c (MULTIBYTE_BYTES_WIDTH):
2206 Use sanitize_char_width to avoid undefined and/or bad behavior
2207 with outlandish widths.
2208 * character.h (sanitize_tab_width): Rename from sanitize_width,
2209 now that we have two such functions. All uses changed.
2210 (sanitize_char_width): New inline function.
2212 Don't assume that tab-width fits in int.
2213 * character.h (sanitize_width): New inline function.
2214 (SANE_TAB_WIDTH): New macro.
2215 (ASCII_CHAR_WIDTH): Use it.
2216 * indent.c (sane_tab_width): Remove. All uses replaced by
2217 SANE_TAB_WIDTH (current_buffer).
2218 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2220 * fileio.c: Integer overflow issues with file modes.
2221 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2223 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2224 Remove unreachable code.
2225 (read_hex, load_charset_map_from_file): Check for integer overflow.
2227 * xterm.c: don't go over XClientMessageEvent limit
2228 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2229 (x_send_scroll_bar_event): Likewise. Check that the size does not
2230 exceed limits imposed by XClientMessageEvent, as well as the usual
2231 ptrdiff_t and size_t limits.
2233 * keyboard.c: Overflow, signedness and related fixes.
2234 (make_lispy_movement): Use same integer type in forward decl
2235 that is used in the definition.
2236 (read_key_sequence, keyremap_step):
2237 Change bufsize argument back to int, undoing my 2011-03-30 change.
2238 We prefer signed types, and int is wide enough here.
2239 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2240 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2241 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2242 length, not size_t. Use ptrdiff_t for index, not int.
2243 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2244 possibility of integer overflow.
2246 Overflow, signedness and related fixes for images.
2248 * dispextern.h (struct it.stack[0].u.image.image_id)
2249 (struct_it.image_id, struct image.id, struct image_cache.size)
2250 (struct image_cache.used, struct image_cache.ref_count):
2251 * gtkutil.c (update_frame_tool_bar):
2252 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2253 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2254 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2255 * nsmenu.m (update_frame_tool_bar):
2256 * xdisp.c (calc_pixel_width_or_height):
2257 * xfns.c (image_cache_refcount):
2258 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2259 on typical 64-bit hosts.
2261 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2262 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2263 Omit unnecessary casts to int.
2264 (parse_image_spec): Check that integers fall into 'int' range
2265 when the callers expect that.
2266 (image_ascent): Redo ascent calculation to avoid int overflow.
2267 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2268 (lookup_image): Remove unnecessary tests.
2269 (xbm_image_p): Locals are now of int, not EMACS_INT,
2270 since parse_image_check makes sure they fit into int.
2271 (png_load, gif_load, svg_load_image):
2272 Prefer int to unsigned where either will do.
2273 (tiff_handler): New function, combining the cores of the
2274 old tiff_error_handler and tiff_warning_handler.
2275 This function is rewritten to use vsnprintf and thereby avoid
2276 stack buffer overflows. It uses only the features of vsnprintf
2277 that are common to both POSIX and native Microsoft.
2278 (tiff_error_handler, tiff_warning_handler): Use it.
2279 (tiff_load, gif_load, imagemagick_load_image):
2280 Don't assume :index value fits in 'int'.
2281 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2282 (imagemagick_load_image): Check that crop parameters fit into
2283 the integer types that MagickCropImage accepts. Don't assume
2284 Vimagemagick_render_type has a nonnegative value. Don't assume
2285 size_t fits in 'long'.
2286 (gs_load): Use printmax_t to print the widest integers possible.
2287 Check for integer overflow when computing image height and width.
2289 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2291 * xdisp.c (redisplay_window): Don't force window start if point
2292 will be invisible in the resulting window. (Bug#9324)
2294 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2296 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2297 the display spec is of the form `(space ...)'.
2298 (handle_display_spec): Return the value returned by
2299 handle_single_display_spec, not just 1 or zero.
2300 (handle_single_display_spec): If the display spec is of the form
2301 `(space ...)', and specifies display in the text area, return 2
2303 (try_cursor_movement): Check for the need to scroll more
2304 accurately, and prefer exact match for point under bidi.
2305 Don't advance `row' beyond the last row of the window.
2307 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2308 into disp_prop; all users changed.
2310 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2311 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2312 for the text covered by the display property.
2314 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2316 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2317 Change return value to nil.
2318 (Frecord_buffer): Delete unused function.
2320 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2322 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2323 buffers, return left-to-right.
2324 (set_cursor_from_row): Consider candidate row a win if its glyph
2325 represents a newline and point is on that newline. Fixes cursor
2326 positioning on the newline at EOL of R2L text within L2R
2327 paragraph, and vice versa.
2328 (try_cursor_movement): Check continued rows, in addition to
2329 continuation rows. Fixes unwarranted scroll when point enters a
2330 continued line of R2L text within an L2R paragraph, or vice versa.
2331 (cursor_row_p): Consider the case of point being equal to
2332 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2333 from the end of a short line to the beginning of a continued line
2334 of R2L text within L2R paragraph.
2335 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2336 composed characters.
2338 * bidi.c (bidi_check_type): Use xassert.
2339 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2342 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2344 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2347 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2349 * nsfont.m (ns_otf_to_script): Fix typo.
2351 2011-08-22 Kenichi Handa <handa@m17n.org>
2353 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2354 extra slot even if the purpose is char-code-property-table.
2356 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2358 * xdisp.c (redisplay_window): When computing centering_position,
2359 account for the height of the header line. (Bug#8874)
2361 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2362 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2363 candidate is selected by the mouse, and that candidate has a
2364 composed character under the mouse.
2366 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2367 coordinates reported by pos-visible-in-window-p for a composed
2368 character in column zero.
2370 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2372 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2374 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2376 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2377 consider it a hit if to_charpos is anywhere in the range of the
2378 composed buffer positions.
2380 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2382 * image.c (gif_load): Don't assume that each subimage has the same
2383 dimensions as the base image. Handle disposal method that is
2384 "undefined" by the gif spec (Bug#9335).
2386 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2388 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2389 (Fcondition_case): Document `debug' symbol in error handler.
2391 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2393 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2394 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2395 from an Org mode buffer to a Speedbar frame.
2397 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2398 a composition, take its buffer position from IT->cmp_it.charpos.
2399 Fixes cursor positioning at the beginning of a line that begins
2400 with a composed character.
2402 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2404 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2405 character bidirectional type, use STRONG_L instead. Fixes crashes
2406 in a buffer produced by `describe-categories'.
2408 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2409 members before the level stack, so they would be saved and
2410 restored when copying iterator state. Fixes incorrect reordering
2411 around TABs covered by display properties.
2413 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2415 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2417 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2419 * eval.c (internal_condition_case, internal_condition_case_1)
2420 (internal_condition_case_2, internal_condition_case_n):
2421 Remove unnecessary aborts (Bug#9081).
2423 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2425 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2426 has no `load' handler, try opening the file locally. (Bug#9311)
2428 2011-08-16 Ken Brown <kbrown@cornell.edu>
2430 * gmalloc.c: Expand comment.
2432 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2434 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2435 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2437 2011-08-16 Ken Brown <kbrown@cornell.edu>
2439 Fix memory allocation problems in Cygwin build (Bug#9273).
2441 * unexcw.c ( __malloc_initialized): Declare external variable.
2442 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2444 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2446 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2448 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2450 [CYGWIN] (special_realloc): New function.
2451 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2452 requests to realloc storage in the static heap.
2454 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2456 * bidi.c (bidi_initialize): Remove unused local.
2458 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2461 * biditype.h: Remove file.
2462 * makefile.w32-in ($(BLD)/bidi.$(O)):
2463 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2465 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2467 * chartab.c: Improve commentary for the uniprop_table API.
2469 * bidi.c (bidi_paragraph_init): Support zero value of
2470 bidi_ignore_explicit_marks_for_paragraph_level.
2471 (bidi_initialize): Use uniprop_table instead of including
2472 biditype.h and bidimirror.h.
2474 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2475 coordinates of the iterator when restoring from ppos_it.
2478 2011-08-14 Kenichi Handa <handa@m17n.org>
2480 * process.c (create_process): Call setup_process_coding_systems
2481 after the pid of the process is set to -1 (Bug#8162).
2483 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2485 * xdisp.c (move_it_in_display_line_to): Don't invoke
2486 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2487 ppos_it. Fixes vertical cursor motion when line beginning is
2488 covered by an image. (Bug#9296)
2490 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2492 * nsterm.h (ns_run_ascript): Declare.
2493 (NSAPP_DATA2_RUNASSCRIPT): Define.
2495 * nsfns.m (as_script, as_result, as_status): New static variables.
2496 (ns_run_ascript): New function.
2497 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2498 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2499 the event loop. Get status from as_status (Bug#7276).
2501 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2502 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2503 the event loop (Bug#7276).
2505 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2507 * gnutls.c (QCgnutls_bootprop_priority)
2508 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2509 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2510 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2511 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2512 (QCgnutls_bootprop_verify_hostname_error)
2513 (QCgnutls_bootprop_callbacks_verify): Rename from
2514 Qgnutls_bootprop_..., all uses changed.
2516 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2519 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2521 * xfaces.c (Qframe_set_background_mode): Now static.
2522 * dispextern.h (Qframe_set_background_mode): Remove decl.
2524 * process.c (Fnetwork_interface_info): Declare local only if needed.
2526 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2528 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2529 (Fnetwork_interface_list): Allocate in increments of bytes instead
2530 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2531 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2533 (struct ifflag_def): notrailers is smart on OSX.
2534 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2535 Get hardware address with getifaddrs if available.
2537 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2539 * xdisp.c (iterate_out_of_display_property): xassert that
2540 IT->position is set to within IT->object's boundaries. Break from
2541 the loop as soon as EOB is reached; avoids infloops in redisplay
2542 when IT->position is set up wrongly due to some bug.
2543 Set IT->current to match the bidi iterator unconditionally.
2544 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2545 entry. Force push_it to save on the stack the current
2546 buffer/string position, to be restored by pop_it. Fix flags in
2547 the iterator structure wrt the object coming from a display
2548 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2549 properties. (Bug#9284)
2551 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2553 * fontset.c (fontset_get_font_group): Add proper type checks.
2556 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2558 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2559 and LC_VERSION_MIN_MACOSX.
2560 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2561 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2563 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2565 * xdisp.c (forward_to_next_line_start): Allow to use the
2566 no-display-properties-and-no-overlays under bidi display.
2567 Set disp_pos in the bidi iterator to avoid searches for display
2568 properties and overlays.
2570 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2572 * editfns.c (Fset_time_zone_rule): Document relationship with the
2575 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2576 the font entity extracted from the cache (Bug#8109).
2578 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2580 * composite.c (autocmp_chars): Don't reset point. That is done by
2581 restore_point_unwind (Bug#5984).
2583 2011-08-07 Juri Linkov <juri@jurta.org>
2585 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2586 to show the arg `TIME' instead of `TIMEVAL'.
2588 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2590 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2591 display property strides EOL and includes a newline, as in
2592 longlines-mode. (Bug#9254)
2593 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2594 word-wrap under bidirectional display. (Bug#9224)
2596 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2597 is non-zero, even if the data buffer is NULL. Fixes a crash in
2598 vertical-motion with longlines-mode. (Bug#9254)
2600 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2602 * bidi.c <bidi_cache_total_alloc>: Now static.
2603 (bidi_initialize): Initialize bidi_cache_total_alloc.
2605 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2608 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2609 amount allocated this far in `bidi_cache_total_alloc'.
2610 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2611 non-zero, only free the data buffer without restoring the cache
2612 contents. All callers changed.
2614 * dispextern.h (bidi_unshelve_cache): Update prototype.
2616 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2617 (move_it_in_display_line, move_it_to)
2618 (move_it_vertically_backward, move_it_by_lines): Replace the call
2619 to xfree to an equivalent call to bidi_unshelve_cache.
2620 (move_it_in_display_line_to): Fix logic of returning
2621 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2623 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2625 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2626 came from a string character with a `cursor' property. (Bug#9229)
2628 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2630 * Makefile.in (LIB_PTHREAD): New variable.
2631 (LIBES): Add LIB_PTHREAD (Bug#9216).
2633 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2634 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2636 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2638 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2640 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2642 * xterm.c (x_find_topmost_parent): New function.
2643 (x_set_frame_alpha): Find topmost parent window with
2644 x_find_topmost_parent and set the property there also (bug#9181).
2645 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2647 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2649 * callproc.c (Fcall_process): Avoid vfork clobbering
2650 the local vars buffer, coding_systems, current_dir.
2652 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2654 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2656 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2658 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2659 so that it is not optimized away.
2661 * xdisp.c (compute_display_string_pos): Remove unused local.
2663 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2665 Fix slow cursor motion and scrolling in large buffers with
2666 selective display, like Org Mode buffers. (Bug#9218)
2668 * dispextern.h (struct bidi_it): New member disp_prop_p.
2670 * xdisp.c: Remove one-slot cache of display string positions.
2671 (compute_display_string_pos): Accept an additional argument
2672 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2673 for a display string or property. If found, set DISP_PROP_P
2676 * bidi.c (bidi_fetch_char): Accept an additional argument
2677 DISP_PROP_P, and pass it to compute_display_string_pos.
2678 Only handle text covered by a display string if DISP_PROP_P is returned
2679 non-zero. All callers of bidi_fetch_char changed.
2681 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2683 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2685 2010-12-03 Don March <don@ohspite.net>
2687 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2688 last character M-[char] is translated to ESC [char] (bug#7541).
2690 2011-08-02 Kenichi Handa <handa@m17n.org>
2692 * lisp.h (uniprop_table): Extern it.
2694 * chartab.c (uniprop_table): Make it non-static.
2696 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2698 * xdisp.c (forward_to_next_line_start): Accept additional argument
2699 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2701 (reseat_at_next_visible_line_start): Use the bidi iterator state
2702 returned by forward_to_next_line_start to restore the state of
2703 it->bidi_it after backing up to previous newline. (Bug#9212)
2705 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2707 * regex.c (re_comp): Protoize.
2708 (re_exec): Fix return type.
2709 (regexec): Fix type of `ret'. (Bug#9203)
2711 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2713 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2714 This is needed if max-image-size is a floating-point number.
2716 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2718 * print.c (print_object): Print empty symbol as ##.
2720 * lread.c (read1): Read ## as empty symbol.
2722 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2724 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2725 setting frame foreground color (Bug#9175).
2726 (x_set_background_color): Likewise.
2728 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2729 contents (Bug#9176).
2730 (EmacsTooltip -init): Remove bezels and add shadows to
2733 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2734 or scroll bar (Bug#8470).
2736 * nsfont.m (nsfont_open): Remove assignment to voffset and
2737 unnecessary vars hshink, expand, hd, full_height, min_height.
2738 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2740 * nsterm.h (nsfont_info): Remove voffset field.
2742 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2744 Implement strike-through and overline on NextStep (Bug#8863).
2746 * nsfont.m (nsfont_open): Use underline position provided by font,
2747 instead of hard-coded value of 2.
2748 (nsfont_draw): Call ns_draw_text_decoration instead.
2750 * nsterm.h: Add declaration for ns_draw_text_decoration.
2752 * nsterm.m (ns_draw_text_decoration): New function for drawing
2753 underline, overline, and strike-through.
2754 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2755 ns_draw_text_decoration. Change treatment of cursor drawing to
2756 accommodate underlining, etc.
2758 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2760 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2763 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2765 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2766 Without this fix, if a signal arrives just after memory fills up,
2767 'malloc' might be invoked reentrantly.
2769 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2770 In other words, assume that every image size is allowed, on non-X
2771 hosts. This assumption is probably wrong, but it lets Emacs compile.
2773 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2775 * regex.c (re_iswctype): Convert return values to boolean.
2777 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2779 * xdisp.c (compute_display_string_pos): Don't use cached display
2780 string position if the buffer had its restriction changed.
2783 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2785 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2787 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2789 Integer signedness and overflow and related fixes. (Bug#9079)
2791 * bidi.c: Integer size and overflow fixes.
2792 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2793 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2794 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2795 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2796 (bidi_find_other_level_edge):
2797 Use ptrdiff_t instead of EMACS_INT where either will do.
2798 This works better on 32-bit hosts configured --with-wide-int.
2799 (bidi_cache_ensure_space): Check for size-calculation overflow.
2800 Use % rather than repeated addition, for better worst-case speed.
2801 Don't set bidi_cache_size until after xrealloc returns, because it
2803 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2804 (bidi_cache_ensure_space): Also check that the bidi cache size
2805 does not exceed that of the largest Lisp string or buffer. See Eli
2806 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2808 * alloc.c (__malloc_size_t): Remove.
2809 All uses replaced by size_t. See Andreas Schwab's note
2810 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2812 * image.c: Improve checking for integer overflow.
2813 (check_image_size): Assume that f is nonnull, since
2814 it is always nonnull in practice. This is one less thing to
2815 worry about when checking for integer overflow later.
2816 (x_check_image_size): New function, which checks for integer
2817 overflow issues inside X.
2818 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2819 This removes the need for a memory_full check.
2820 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2821 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2822 (xbm_read_bitmap_data): Change locals back to 'int', since
2823 their values must fit in 'int'.
2824 (xpm_load_image, png_load, tiff_load):
2825 Invoke x_create_x_image_and_pixmap earlier,
2826 to avoid much needless work if the image is too large.
2827 (tiff_load): Treat overly large images as if
2828 x_create_x_image_and_pixmap failed, not as malloc failures.
2829 (gs_load): Use x_check_image_size.
2831 * gtkutil.c: Omit integer casts.
2832 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2833 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2835 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2837 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2838 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2839 would wrongly return t on a 64-bit host.
2841 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2842 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2843 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2844 and therefore cause GCC to emit a bogus diagnostic in some cases.
2846 * image.c: Integer signedness and overflow and related fixes.
2847 This is not an exhaustive set of fixes, but it's time to
2848 record what I've got.
2849 (lookup_pixel_color, check_image_size): Remove redundant decls.
2850 (check_image_size): Don't assume that arbitrary EMACS_INT values
2851 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2852 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2853 (tiff_load, imagemagick_load_image):
2854 Check for overflow in size calculations.
2855 (x_create_x_image_and_pixmap): Remove unnecessary test for
2856 xmalloc returning NULL; that can't happen.
2857 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2858 (xpm_color_bucket): Use better integer hashing function.
2859 (xpm_cache_color): Don't possibly over-allocate memory.
2860 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2861 (gif_memory_source):
2862 Use ptrdiff_t, not int or size_t, to record sizes.
2863 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2864 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2865 either works, as we prefer signed integers.
2866 (tiff_read_from_memory, tiff_write_from_memory):
2867 Return tsize_t, not size_t, since that's what the TIFF API wants.
2868 (tiff_read_from_memory): Don't fail simply because the read would
2869 go past EOF; instead, return a short read.
2870 (tiff_load): Omit no-longer-needed casts.
2871 (Fimagemagick_types): Don't assume size fits into 'int'.
2873 Improve hashing quality when configured --with-wide-int.
2874 * fns.c (hash_string): New function, taken from sxhash_string.
2875 Do not discard information about ASCII character case; this
2876 discarding is no longer needed.
2877 (sxhash-string): Use it. Change sig to match it. Caller changed.
2878 * lisp.h: Declare it.
2879 * lread.c (hash_string): Remove, since we now use fns.c's version.
2880 The fns.c version returns a wider integer if --with-wide-int is
2881 specified, so this should help the quality of the hashing a bit.
2883 * emacs.c: Integer overflow minor fix.
2884 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2885 Define only if GNU_LINUX.
2886 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2888 * dispnew.c: Integer signedness and overflow fixes.
2889 Remove unnecessary forward decls, that were a maintenance hassle.
2890 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2892 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2893 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2894 (prepare_desired_row, line_draw_cost):
2895 Use int, not unsigned, where either works.
2896 (save_current_matrix, restore_current_matrix):
2897 Use ptrdiff_t, not size_t, where either works.
2898 (init_display): Check for overflow more accurately, and without
2899 relying on undefined behavior.
2901 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2902 Remove, replacing with the new symbols in lisp.h. All uses changed.
2903 * fileio.c (make_temp_name):
2904 * filelock.c (lock_file_1, lock_file):
2905 * xdisp.c (message_dolog):
2906 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2907 Use pMd etc. instead.
2908 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2909 replacing the pWIDE etc. symbols removed from editfns.c.
2911 * keyboard.h (num_input_events): Now uintmax_t.
2912 This is (very slightly) less likely to mess up due to wraparound.
2915 * buffer.c: Integer signedness fixes.
2916 (alloc_buffer_text, enlarge_buffer_text):
2917 Use ptrdiff_t rather than size_t when either will do, as we prefer
2920 * alloc.c: Integer signedness and overflow fixes.
2921 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2922 (__malloc_size_t): Default to size_t, not to int.
2923 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2924 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2925 Prefer ptrdiff_t to size_t when either would do, as we prefer
2927 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2928 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2929 Now const. Initialize with values that are in range even if char
2931 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2932 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2933 These functions do the right thing with sizes > 2**32.
2934 (check_depth): Now ptrdiff_t, not int.
2935 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2936 Adjust to new way of storing sizes. Check for size overflow bugs
2938 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2939 slightly wrong anyway, as it missed one instance of
2940 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2941 (refill_memory_reserve): Omit needless cast to size_t.
2942 (mark_object_loop_halt): Mark as externally visible.
2944 * xselect.c: Integer signedness and overflow fixes.
2945 (Fx_register_dnd_atom, x_handle_dnd_message):
2946 Use ptrdiff_t, not size_t, since we prefer signed.
2947 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2948 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2949 x_dnd_atoms_size and x_dnd_atoms_length.
2951 * doprnt.c: Prefer signed to unsigned when either works.
2953 * doprnt.c (doprnt):
2955 * xdisp.c (vmessage):
2956 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2957 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2958 prefer signed arithmetic to avoid comparison confusion.
2959 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2960 but is a bit tricky.
2962 Assume freestanding C89 headers, string.h, stdlib.h.
2963 * data.c, doprnt.c, floatfns.c, print.c:
2964 Include float.h unconditionally.
2965 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2966 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2967 * regex.c: Likewise for stddef.h, string.h.
2968 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2969 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2970 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2971 (STDC_HEADERS): Remove obsolete defines.
2972 * sysdep.c: Include limits.h unconditionally.
2974 Assume support for memcmp, memcpy, memmove, memset.
2975 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2976 * regex.c (memcmp, memcpy):
2977 Remove; we assume C89 now.
2979 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2980 (__malloc_safe_bcopy): Remove; no longer needed.
2982 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2983 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2984 well either way, and we prefer signed to unsigned.
2986 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2988 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2989 closes the connection while we're reading (bug#9182).
2991 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2993 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2994 are specified (Bug#9168).
2996 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2998 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2999 Found by GCC static checking and --with-wide-int on a 32-bit host.
3001 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3003 * xdisp.c (compute_display_string_pos): Fix logic of caching
3004 previous display string position. Initialize cached_prev_pos to
3005 -1. Fixes slow-down at the beginning of a buffer.
3007 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3009 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3010 for attrs[LFACE_FONTSET_INDEX].
3012 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3014 * xml.c (parse_region): Remove unused local
3015 that was recently introduced.
3017 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3019 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3020 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3022 * xdisp.c (move_it_in_display_line_to): Record the best matching
3023 position for TO_CHARPOS while scanning the line, and restore it on
3024 exit if none of the characters scanned was an exact match.
3025 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3026 when exact match is impossible due to invisible text, and the
3027 lines are truncated.
3029 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3031 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3034 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3036 Fix a significant slow-down of cursor motion with C-n, C-p,
3037 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3038 auto-repeat under bidi redisplay in fontified buffers.
3039 * xdisp.c (compute_stop_pos_backwards): New function.
3040 (next_element_from_buffer): Call compute_stop_pos_backwards to
3041 find a suitable prev_stop when we find ourselves before
3043 (reseat): Don't look for prev_stop, as that could mean a very long
3045 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3046 <cached_disp_overlay_modiff>: Cache for last found display string
3048 (compute_display_string_pos): Return the cached position if asked
3049 about the same buffer in the same area of character positions, and
3050 the buffer wasn't changed since the time the display string
3051 position was cached.
3053 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3055 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3056 is an integer, which is important for empty lines. (Bug#9149)
3058 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3060 * frame.c (Fmodify_frame_parameters): In tty case, update the
3061 default face if necessary (Bug#4238).
3063 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3065 * editfns.c (Fstring_to_char): No need to explain what a character
3066 is in the docstring (Bug#6576).
3068 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3070 * xml.c (parse_region): Make sure we always return a tree.
3072 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3074 * xml.c (parse_region): If a document contains only comments,
3077 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3079 * xml.c (make_dom): Return comments, too.
3081 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3084 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3085 and the surrounding thread.
3086 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3087 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3088 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3090 * s/openbsd.h (BROKEN_SIGIO): Define.
3091 * unexelf.c (unexec) [__OpenBSD__]:
3092 Don't update the .mdebug section of the Alpha COFF symbol table.
3094 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3096 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3099 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3101 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3102 This fixes some race conditions on the permissions of any newly
3105 * alloc.c (valid_pointer_p): Use pipe, not open.
3106 This fixes some permissions issues when debugging.
3108 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3109 If fchown fails to set both uid and gid, try to set just gid,
3110 as that is sometimes allowed. Adjust the file's mode to eliminate
3111 setuid or setgid bits that are inappropriate if fchown fails.
3113 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3115 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3116 to compare Lisp_Objects.
3117 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3118 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3119 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3121 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3123 * lread.c (read_integer): Unread even EOF character.
3124 (read1): Likewise. Properly record start position of symbol.
3126 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3127 symbol character follows.
3129 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3131 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3132 This works around a problem with the previous change to Fcopy_file.
3133 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3134 and without this change, GCC might complain about discarding
3135 fchown's return value.
3137 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3139 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3141 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3143 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3145 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3147 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3148 it's used from the C level.
3150 * process.c: Use the same condition for POLL_FOR_INPUT in both
3151 keyboard.c and process.c (bug#1858).
3153 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3155 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3156 (Fgnutls_boot): Use it.
3158 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3160 * doc.c (Fsubstitute_command_keys): Revert last change.
3162 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3164 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3165 quotes the next character, and doesn't affect other longer
3166 sequences (bug#8935).
3168 * lread.c (syms_of_lread): Clarify that is isn't only
3169 `eval-buffer' and `eval-defun' that's affected by
3170 `lexical-binding' (bug#8460).
3172 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3174 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3175 bidi redisplay when a line includes both an image and is truncated.
3177 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3179 Fix minor problems found by static checking.
3180 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3181 (elsz): Now a signed constant, not a size_t var. We prefer signed
3182 types to unsigned, to avoid integer comparison confusion. Without
3183 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3184 "cannot optimize loop, the loop counter may overflow", a symptom
3186 * indent.c (Fvertical_motion): Mark locals as initialized.
3187 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3189 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3191 * search.c (Fre_search_backward): Mention `case-fold-search' in
3192 all the re_search_* functions (bug#8138).
3194 * keyboard.c (Fopen_dribble_file): Document when the file is
3197 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3199 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3202 Support bidi reordering of display and overlay strings.
3203 * xdisp.c (compute_display_string_pos)
3204 (compute_display_string_end): Accept additional argument STRING.
3205 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3206 (reseat_to_string): Initialize bidi_it->string.s and
3207 bidi_it->string.schars.
3208 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3209 NULL (avoids a crash in bidi_paragraph_init).
3210 Initialize itb.string.lstring.
3211 (init_iterator): Call bidi_init_it only of a valid
3212 buffer position was specified. Initialize paragraph_embedding to
3214 (reseat_to_string): Initialize the bidi iterator.
3215 (display_string): If we need to ignore text properties of
3216 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3217 original value of -1 will not work with bidi.)
3218 (compute_display_string_pos): First arg is now struct
3219 `text_pos *'; all callers changed. Support display properties on
3221 (compute_display_string_end): Support display properties on Lisp
3223 (init_iterator, reseat_1, reseat_to_string): Initialize the
3224 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3225 when iterating on a string not from display properties).
3226 (compute_display_string_pos, compute_display_string_end):
3227 Fix calculation of the object to scan. Fixes an error when using
3229 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3230 base_level_stop; instead, set base_level_stop to BEGV.
3231 Fixes crashes in vertical-motion.
3232 (next_element_from_buffer): Improve commentary for when
3233 the iterator is before prev_stop.
3234 (init_iterator): Initialize bidi_p from the default value of
3235 bidi-display-reordering, not from buffer-local value. Use the
3236 buffer-local value only if initializing for buffer iteration.
3237 (handle_invisible_prop): Support invisible properties on strings
3238 that are being bidi-reordered.
3239 (set_iterator_to_next): Support bidi reordering of C strings and
3241 (next_element_from_string): Support bidi reordering of Lisp
3243 (handle_stop_backwards): Support Lisp strings as well.
3244 (display_string): Support display of R2L glyph rows.
3245 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3246 (init_iterator): Don't initialize it->bidi_p for strings
3248 (reseat_to_string): Initialize it->bidi_p for strings here.
3249 (next_element_from_string, next_element_from_c_string)
3250 (next_element_from_buffer): Add xassert's for correspondence
3251 between IT's object being iterated and it->bidi_it.string
3253 (face_before_or_after_it_pos): Support bidi iteration.
3254 (next_element_from_c_string): Handle the case of the first string
3255 character that is not the first one in the visual order.
3256 (get_visually_first_element): New function, refactored from common
3257 parts of next_element_from_buffer, next_element_from_string, and
3258 next_element_from_c_string.
3259 (tool_bar_lines_needed, redisplay_tool_bar)
3260 (display_menu_bar): Force left-to-right direction. Add a FIXME
3261 comment for making that be controlled by a user option.
3262 (push_it, pop_it): Save and restore the state of the
3263 bidi iterator. Save and restore the bidi_p flag.
3264 (pop_it): Iterate out of display property for string iteration as
3266 (iterate_out_of_display_property): Support iteration over strings.
3267 (handle_single_display_spec): Set up it->bidi_it for iteration
3268 over a display string, and call bidi_init_it.
3269 (handle_single_display_spec, next_overlay_string)
3270 (get_overlay_strings_1, push_display_prop): Set up the bidi
3271 iterator for displaying display or overlay strings.
3272 (forward_to_next_line_start): Don't use the shortcut if
3274 (back_to_previous_visible_line_start): If handle_display_prop
3275 pushed the iterator stack, restore the internal state of the bidi
3276 iterator by calling bidi_pop_it same number of times.
3277 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3278 and we are bidi-iterating, don't decrement the iterator position;
3279 instead, set the first_elt flag in the bidi iterator, to produce
3281 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3282 (push_display_prop): xassert that we are iterating a buffer.
3283 (push_it, pop_it): Save and restore paragraph_embedding member.
3284 (handle_single_display_spec, next_overlay_string)
3285 (get_overlay_strings_1, reseat_1, reseat_to_string)
3286 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3287 correctly. Don't assume unibyte strings are not bidi-reordered.
3288 (compute_display_string_pos)
3289 (compute_display_string_end): Fix handling the case of C string.
3290 (push_it, pop_it): Save and restore from_disp_prop_p.
3291 (handle_single_display_spec, push_display_prop): Set the
3292 from_disp_prop_p flag.
3293 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3294 (pop_it): Call iterate_out_of_display_property only if we are
3295 popping after iteration over a string that came from a display
3296 property. Fix a typo in popping stretch info. Add an assertion
3297 for verifying that the iterator position is in sync with the bidi
3299 (handle_single_display_spec, get_overlay_strings_1)
3300 (push_display_prop): Fix initialization of paragraph direction for
3301 string when that of the parent object is not yet determined.
3302 (reseat_1): Call bidi_init_it to resync the bidi
3303 iterator with IT's position. (Bug#7616)
3304 (find_row_edges): If ROW->start.pos gives position
3305 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3306 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3307 Reset the from_disp_prop_p flag.
3308 (SAVE_IT, RESTORE_IT): New macros.
3309 (pos_visible_p, face_before_or_after_it_pos)
3310 (back_to_previous_visible_line_start)
3311 (move_it_in_display_line_to, move_it_in_display_line)
3312 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3313 (try_scrolling, redisplay_window, display_line): Use them when
3314 saving a temporary copy of the iterator and restoring it back.
3315 (back_to_previous_visible_line_start, reseat_1)
3316 (init_iterator): Empty the bidi cache "stack".
3317 (move_it_in_display_line_to): If iterator ended up at
3318 EOL, but we never saw any buffer positions smaller than
3319 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3320 motion in bidi-reordered lines.
3321 (move_it_in_display_line_to): Record prev_method and prev_pos
3322 immediately before the call to set_iterator_to_next. Fixes cursor
3323 motion in bidi-reordered lines with stretch glyphs and strings
3324 displayed in margins. (Bug#8133) (Bug#8867)
3325 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3327 (pos_visible_p): Support positions in bidi-reordered lines.
3328 Save and restore bidi cache.
3330 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3331 (bidi_paragraph_info): Delete unused struct.
3332 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3333 (bidi_cache_start): New variable.
3334 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3336 (bidi_cache_fetch_state, bidi_cache_search)
3337 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3338 (bidi_cache_find, bidi_peek_at_next_level)
3339 (bidi_level_of_next_char, bidi_find_other_level_edge)
3340 (bidi_move_to_visually_next): Compare cache index with
3341 bidi_cache_start rather than with zero.
3342 (bidi_fetch_char): Accept new argument STRING; all callers
3343 changed. Support iteration over a string. Support strings with
3344 display properties. Support unibyte strings. Fix the type of
3345 `len' according to what STRING_CHAR_AND_LENGTH expects.
3346 (bidi_paragraph_init, bidi_resolve_explicit_1)
3347 (bidi_resolve_explicit, bidi_resolve_weak)
3348 (bidi_level_of_next_char, bidi_move_to_visually_next):
3349 Support iteration over a string.
3350 (bidi_set_sor_type, bidi_resolve_explicit_1)
3351 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3352 can now be zero (for strings); special values 0 and -1 were
3353 changed to -1 and -2, respectively.
3354 (bidi_char_at_pos): New function.
3355 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3356 Call it instead of FETCH_MULTIBYTE_CHAR.
3357 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3358 initialized to valid values.
3359 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3361 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3362 the test for valid cached positions. Fix the logic for looking up
3363 the sentinel state in the cache. GCPRO the Lisp string we are
3365 (bidi_push_it, bidi_pop_it): New functions.
3366 (bidi_initialize): Initialize the bidi cache start stack pointer.
3367 (bidi_cache_ensure_space): New function, refactored from part of
3368 bidi_cache_iterator_state. Don't assume the required size is just
3369 one BIDI_CACHE_CHUNK away.
3370 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3371 (bidi_count_bytes, bidi_char_at_pos): New functions.
3372 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3373 always valid if bidi_cache_idx is valid.
3374 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3375 is valid if it's going to be used.
3376 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3377 (bidi_cache_fetch_state, bidi_cache_search)
3378 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3379 (bidi_cache_iterator_state, bidi_cache_find)
3380 (bidi_find_other_level_edge, bidi_cache_start_stack):
3381 All variables related to cache indices are now EMACS_INT.
3383 * dispextern.h (struct bidi_string_data): New structure.
3384 (struct bidi_it): New member `string'. Make flag members be 1-bit
3385 fields, and put them last in the struct.
3386 (compute_display_string_pos, compute_display_string_end):
3388 (bidi_push_it, bidi_pop_it): Add prototypes.
3389 (struct iterator_stack_entry): New members bidi_p,
3390 paragraph_embedding, and from_disp_prop_p.
3391 (struct it): Member bidi_p is now a bit field 1 bit wide.
3392 (bidi_shelve_cache, bidi_unshelve_cache):
3395 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3396 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3397 and vector-like objects.
3399 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3400 cache around display iteration.
3402 * window.c (Fwindow_end, window_scroll_pixel_based)
3403 (displayed_window_lines, Frecenter): Save and restore the bidi
3404 cache around display iteration.
3406 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3408 * editfns.c (Fdelete_region): Clarify the use of the named
3409 parameters (bug#6788).
3411 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3413 * indent.c (Fvertical_motion): Set and restore w->pointm when
3414 saving and restoring the window's buffer (Bug#9006).
3416 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3418 * editfns.c (Fstring_to_char): Clarify just what is returned
3419 (bug#6576). Text by Eli Zaretskii.
3421 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3423 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3425 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3427 * buffer.c (mmap_find): Fix a typo.
3429 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3431 Fix execution of x selection hooks.
3432 * xselect.c (Qx_lost_selection_functions)
3433 (Qx_sent_selection_functions): New vars.
3434 (syms_of_xselect): DEFSYM them.
3435 (x_handle_selection_request): Pass Qx_sent_selection_functions
3436 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3437 (x_handle_selection_clear,x_clear_frame_selections):
3438 Pass Qx_lost_selection_functions rather than
3439 Vx_lost_selection_functions to Frun_hook_with_args.
3441 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3443 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3444 The old code sometimes used this field without initializing it.
3446 * alloc.c (gc_sweep): Don't read past end of array.
3447 In theory, the old code could also have corrupted Emacs internals,
3448 though it'd be very unlikely.
3450 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3452 * character.c (Fcharacterp): Don't advertise optional ignored
3453 argument. (Bug#4026)
3455 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3457 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3460 * window.c (Fset_window_start): Doc fix (bug#4199).
3461 (Fset_window_hscroll): Ditto.
3463 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3465 Fix minor new problems caught by GCC 4.6.1.
3466 * term.c (init_tty): Remove unused local.
3467 * xsettings.c (store_monospaced_changed): Define this function only
3468 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3471 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3473 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3475 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3477 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3478 are the mini-buffer and the echo area (bug#3320).
3480 * term.c (init_tty): Remove support for supdup, c10 and perq
3481 terminals, which are no longer supported (bug#1482).
3483 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3485 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3487 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3489 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3490 for non-popups (Bug#3642).
3492 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3494 * alloc.c (reset_malloc_hooks): Protoize.
3495 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3496 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3497 * cm.c (losecursor): Likewise.
3498 * data.c (fmod): Likewise.
3499 * dispnew.c (swap_glyphs_in_rows): Likewise.
3500 * emacs.c (memory_warning_signal): Likewise.
3501 * floatfns.c (float_error): Likewise.
3502 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3503 (otf_open, font_otf_capability, generate_otf_features)
3504 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3506 * image.c (pbm_read_file): Likewise.
3507 * indent.c (string_display_width): Likewise.
3508 * intervals.c (check_for_interval, search_for_interval)
3509 (inc_interval_count, count_intervals, root_interval)
3510 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3511 * lread.c (defalias): Likewise.
3512 * ralloc.c (r_alloc_check): Likewise.
3513 * regex.c (set_image_of_range_1, set_image_of_range)
3514 (regex_grow_registers): Likewise.
3515 * sysdep.c (strerror): Likewise.
3516 * termcap.c (valid_filename_p, tprint, main): Likewise.
3517 * tparam.c (main): Likewise.
3518 * unexhp9k800.c (run_time_remap, save_data_space)
3519 (update_file_ptrs, read_header, write_header, calculate_checksum)
3520 (copy_file, copy_rest, display_header): Likewise.
3521 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3523 * xdisp.c (check_it): Likewise.
3524 * xfaces.c (register_color, unregister_color, unregister_colors):
3526 * xfns.c (print_fontset_result): Likewise.
3527 * xrdb.c (member, fatal, main): Likewise.
3529 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3531 Fix minor problems found by static checking (Bug#9031).
3532 * chartab.c (char_table_set_range, map_sub_char_table):
3533 Remove unused locals.
3534 (uniprop_table): Now static.
3535 * composite.c (_work_char): Remove unused static var.
3537 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3539 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3541 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3543 * gtkutil.c (qttip_cb): Remove code without function.
3545 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3547 * w32.c (pthread_sigmask): New stub.
3549 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3551 Use pthread_sigmask, not sigprocmask (Bug#9010).
3552 sigprocmask is portable only for single-threaded applications, and
3553 Emacs can be multi-threaded when it uses GTK.
3554 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3556 * callproc.c (Fcall_process):
3557 * process.c (create_process):
3558 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3559 Use pthread_sigmask, not sigprocmask.
3561 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3563 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3564 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3567 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3569 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3570 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3571 (xg_hide_tooltip): Fix comment.
3573 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3574 in registerServicesMenuSendTypes.
3575 (validRequestorForSendType): Don't check ns_return_types.
3577 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3580 2011-07-08 Jason Rumney <jasonr@gnu.org>
3582 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3583 SH_SHOW for hidden windows (Bug#5482).
3585 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3586 frame struct members of non-existent frames (Bug#6284).
3588 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3590 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3591 variable firstTime not needed on OSX >= 10.6.
3592 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3593 >= 10.5. Use setKnobProportion, setDoubleValue.
3595 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3596 (MAC_OS_X_VERSION_10_5): Define if not defined.
3597 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3598 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3599 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3601 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3602 cString and lossyCString on OSX >= 10.4
3604 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3605 sizeToFit on OSX >= 10.2.
3607 * nsimage.m (allocInitFromFile): Don't use deprecated method
3608 bestRepresentationForDevice on OSX >= 10.6.
3610 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3613 * emacs.c: Declare unexec_init_emacs_zone.
3615 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3617 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3619 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3620 on svcsMenu (Bug#8842).
3622 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3624 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3626 * nsterm.m (QUTF8_STRING): Declare.
3627 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3628 (validRequestorForSendType): Return type is (id).
3629 Change indexOfObjectIdenticalTo to indexOfObject.
3630 Check if we have local selection before returning self (Bug#8842).
3631 (writeSelectionToPasteboard): Put local selection into paste board
3632 if we have a local selection (Bug#8842).
3633 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3635 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3636 (ns_get_local_selection): Declare.
3638 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3640 * keymap.c (describe_map_tree): Don't insert a double newline at
3641 the end of the buffer (bug#1169) and return whether we inserted
3644 * callint.c (Fcall_interactively): Change "reading args" to
3645 "providing args" to try to clarify what it does (bug#1010).
3647 2011-07-07 Kenichi Handa <handa@m17n.org>
3649 * composite.c (composition_compute_stop_pos): Ignore a static
3650 composition starting before CHARPOS (Bug#8915).
3652 * xdisp.c (handle_composition_prop): Likewise.
3654 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3656 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3659 2011-07-07 Kenichi Handa <handa@m17n.org>
3661 * character.h (unicode_category_t): New enum type.
3663 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3664 (Qchar_code_property_table): New variable.
3665 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3666 (UNIPROP_COMPRESSED_FORM_P): New macros.
3667 (char_table_ascii): Uncompress the compressed values.
3668 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3669 Uncompress the compressed values.
3670 (sub_char_table_ref_and_range): Likewise.
3671 (char_table_ref_and_range): Uncompress the compressed values.
3672 (sub_char_table_set): New arg is_uniprop. Callers changed.
3673 Uncompress the compressed values.
3674 (sub_char_table_set_range): Args changed. Callers changed.
3675 (char_table_set_range): Adjuted for the above change.
3676 (map_sub_char_table): Delete args default_val and parent. Add arg
3677 top. Give decoded values to a Lisp function.
3678 (map_char_table): Adjust for the above change. Give decoded
3679 values to a Lisp function. Gcpro more variables.
3680 (uniprop_table_uncompress)
3681 (uniprop_decode_value_run_length): New functions.
3682 (uniprop_decoder, uniprop_decoder_count): New variables.
3683 (uniprop_get_decoder, uniprop_encode_value_character)
3684 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3686 (uniprop_encoder, uniprop_encoder_count): New variables.
3687 (uniprop_get_encoder, uniprop_table)
3688 (Funicode_property_table_internal, Fget_unicode_property_internal)
3689 (Fput_unicode_property_internal): New functions.
3690 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3691 Sunicode_property_table_internal, Sget_unicode_property_internal,
3692 and Sput_unicode_property_internal. Defvar_lisp
3693 char-code-property-alist.
3695 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3696 Vunicode_category_table.
3698 * font.c (font_range): Adjust for the change of
3699 Vunicode_category_table.
3701 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3703 * m/iris4d.h: Remove file, move contents ...
3704 * s/irix6-5.h: ... here.
3706 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3708 Remove unportable assumption about struct layout (Bug#8884).
3709 * alloc.c (mark_buffer):
3710 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3711 (clone_per_buffer_values): Don't assume that
3712 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3713 This isn't true in general, and it's particularly not true
3714 if Emacs is configured with --with-wide-int.
3715 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3716 New macros, used in the buffer.c change.
3718 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3720 * xsettings.c: Use both GConf and GSettings if both are available.
3721 (store_config_changed_event): Add comment.
3722 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3723 (store_tool_bar_style_changed): New functions.
3724 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3725 (struct xsettings): Move font inside HAVE_XFT.
3726 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3727 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3728 Move inside HAVE_XFT.
3729 (something_changed_gsettingsCB): Rename from something_changedCB.
3730 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3732 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3733 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3734 (something_changed_gconfCB): Rename from something_changedCB.
3735 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3736 (parse_settings): Move check for font inside HAVE_XFT.
3737 (read_settings, apply_xft_settings): Add comment.
3738 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3739 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3740 call store_font_name_changed.
3741 (xft_settings_event): Add comment.
3742 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3743 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3744 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3745 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3746 (xsettings_initialize): Call init_gsettings last.
3747 (xsettings_get_system_font, xsettings_get_system_normal_font):
3750 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3752 Random fixes. E.g., (random) never returned negative values.
3753 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3754 subseconds part to the entropy, as that's a bit more random.
3755 Prefer signed to unsigned, since the signedness doesn't matter and
3756 in general we prefer signed. When given a limit, use a
3757 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3758 latter isn't right if USE_2_TAGS_FOR_INTS.
3759 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3760 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3762 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3764 * textprop.c (text_property_stickiness):
3765 Obey Vtext_property_default_nonsticky.
3766 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3767 * w32fns.c (syms_of_w32fns):
3768 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3770 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3772 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3773 This is more efficient than Ffile_directory_p and avoids a minor race.
3775 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3777 * buffer.c (Foverlay_put): Say what the return value is
3780 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3781 is a directory before asking whether to use the file name
3783 (barf_or_query_if_file_exists): Make the "File is a directory"
3784 error be more correct.
3786 * fns.c (Frequire): Remove the mention of the .gz files, since
3787 that's installation-specific, but keep the mention of
3788 `get-load-suffixes'.
3790 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3792 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3793 Report string overflow if the output is too long.
3795 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3797 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3798 (syms_of_gnutls): Remove duplicate DEFSYM for
3799 Qgnutls_bootprop_verify_hostname_error, an error for
3800 Qgnutls_bootprop_verify_error (which is no longer used).
3802 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3803 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3804 Also (re)move comments that are misplaced or no longer relevant.
3806 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3808 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3810 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3812 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3813 and background color parameters if they have been changed.
3815 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3817 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3819 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3821 * xsettings.c (SYSTEM_FONT): Define only when used.
3822 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3824 * keymap.c (access_keymap_1): Now static.
3826 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3828 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3829 leave any prefix arg for the up event (Bug#1586).
3831 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3833 * lread.c (syms_of_lread): Mention single symbols defined by
3834 `defvar' or `defconst' (bug#7154).
3836 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3837 (Frequire): Mention get-load-suffixes.
3839 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3841 * window.h (window): Remove clone_number slot.
3842 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3844 (make_parent_window, make_window, saved_window)
3845 (Fset_window_configuration, save_window_save): Don't deal with
3847 * buffer.c (Qclone_number): Remove declaration.
3848 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3850 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3852 Add multiple inheritance to keymaps.
3853 * keymap.c (Fmake_composed_keymap): New function.
3854 (Fset_keymap_parent): Simplify.
3855 (fix_submap_inheritance): Remove.
3856 (access_keymap_1): New function extracted from access_keymap to handle
3857 embedded parents and handle lists of maps.
3858 (access_keymap): Use it.
3859 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3860 (Fcopy_keymap): Handle embedded parents.
3861 (Fcommand_remapping, define_as_prefix): Simplify.
3862 (Fkey_binding): Simplify.
3863 (syms_of_keymap): Move minibuffer-local-completion-map,
3864 minibuffer-local-filename-completion-map,
3865 minibuffer-local-must-match-map, and
3866 minibuffer-local-filename-must-match-map to Elisp.
3867 (syms_of_keymap): Defsubr make-composed-keymap.
3868 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3869 (parse_menu_item): Trivial simplification.
3871 2011-07-01 Glenn Morris <rgm@gnu.org>
3873 * Makefile.in (SETTINGS_LIBS): Fix typo.
3875 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3877 * coding.c (Fencode_coding_string): Record the last coding system
3878 used, as the function doc string says (bug#8738).
3880 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3882 * xsettings.c (store_monospaced_changed): Take new font as arg and
3883 check for change against current_mono_font.
3884 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3885 (emacs_settings_constructor, emacs_settings_get_property)
3886 (emacs_settings_set_property, emacs_settings_class_init)
3887 (emacs_settings_init, gsettings_obj): Remove.
3888 (something_changedCB): New function for HAVE_GSETTINGS.
3889 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3890 with value as argument.
3891 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3892 g_settings_new (Bug#8967). Do not create gsettings_obj.
3893 Remove calls to g_settings_bind. Connect something_changedCB to
3896 * xgselect.c: Add defined (HAVE_GSETTINGS).
3897 (xgselect_initialize): Ditto.
3899 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3900 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3903 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3905 * eval.c (struct backtrace): Simplify and port the data structure.
3906 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3907 signed bit field, as this assumption is not portable and it makes
3908 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3909 "char debug_on_exit : 1" as this is not portable either; instead,
3910 use the portable "unsigned int debug_on_exit : 1". Remove unused
3911 member evalargs. Remove obsolete comments about cc bombing out.
3913 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3915 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3916 Let HAVE_GSETTINGS override HAVE_GCONF.
3917 (store_monospaced_changed): New function.
3918 (EMACS_SETTINGS): A new type derived from GObject to handle
3919 GSettings notifications.
3920 (emacs_settings_constructor, emacs_settings_get_property)
3921 (emacs_settings_set_property, emacs_settings_class_init):
3923 (gsettings_client, gsettings_obj): New variables.
3924 (GSETTINGS_SCHEMA): New define.
3925 (something_changedCB): Call store_monospaced_changed.
3926 (init_gsettings): New function.
3927 (xsettings_initialize): Call init_gsettings.
3928 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3931 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3934 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3936 * window.c (resize_root_window, grow_mini_window)
3937 (shrink_mini_window): Rename Qresize_root_window to
3938 Qwindow_resize_root_window and Qresize_root_window_vertically to
3939 Qwindow_resize_root_window_vertically.
3941 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3943 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3945 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3947 * makefile.w32-in: Redesign dependencies so they reflect more
3948 clearly which files are directly included by each source file,
3949 and not through other includes.
3951 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3953 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3954 (sort_overlays, overlay_strings): When an overlay's clone number
3955 matches the window's clone number process the overlay even if
3956 the overlay's window property doesn't match the current window.
3958 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3959 (Fwindow_hchild): Rename to Fwindow_left_child.
3960 (Fwindow_next): Rename to Fwindow_next_sibling.
3961 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3962 (resize_window_check): Rename to window_resize_check.
3963 (resize_window_apply): Rename to window_resize_apply.
3964 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3965 (Fdelete_other_windows_internal, resize_frame_windows)
3966 (Fsplit_window_internal, Fdelete_window_internal)
3967 (grow_mini_window, shrink_mini_window)
3968 (Fresize_mini_window_internal): Fix callers accordingly.
3970 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3972 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3973 (emacs_fixed_set_min_size): Remove.
3974 (emacs_fixed_new): Take frame as argument.
3976 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3977 (_EmacsFixedPrivate): Remove minwidth/height.
3978 Add struct frame *f.
3979 (emacs_fixed_init): Initialize priv->f.
3980 (get_parent_class, emacs_fixed_set_min_size): Remove.
3981 (emacs_fixed_new): Set priv->f to argument.
3982 (emacs_fixed_get_preferred_width)
3983 (emacs_fixed_get_preferred_height): Use min_width/height from
3984 frames size_hint to set minimum and natural (Bug#8919).
3985 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3986 and use min_width/height from frames size_hint to set
3987 min_width/height (Bug#8919).
3989 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3990 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3993 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3995 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3996 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3999 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4001 * process.c (wait_reading_process_output): Bypass select if
4002 waiting for a cell while ignoring keyboard input, and input is
4003 pending. Suggested by Jan Djärv (Bug#8869).
4005 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4007 Use gnulib's dup2 module instead of rolling our own.
4008 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4010 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4012 * dispnew.c (scrolling_window): Before scrolling, turn off a
4013 mouse-highlight in the window being scrolled.
4015 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4017 Move DEFSYM to lisp.h and use everywhere.
4019 * character.h (DEFSYM): Move declaration...
4020 * lisp.h (DEFSYM): ...here.
4026 * w32select.c: Don't include character.h.
4028 * alloc.c (syms_of_alloc):
4029 * buffer.c (syms_of_buffer):
4030 * bytecode.c (syms_of_bytecode):
4031 * callint.c (syms_of_callint):
4032 * casefiddle.c (syms_of_casefiddle):
4033 * casetab.c (init_casetab_once):
4034 * category.c (init_category_once, syms_of_category):
4035 * ccl.c (syms_of_ccl):
4036 * cmds.c (syms_of_cmds):
4037 * composite.c (syms_of_composite):
4038 * dbusbind.c (syms_of_dbusbind):
4039 * dired.c (syms_of_dired):
4040 * dispnew.c (syms_of_display):
4041 * doc.c (syms_of_doc):
4042 * editfns.c (syms_of_editfns):
4043 * emacs.c (syms_of_emacs):
4044 * eval.c (syms_of_eval):
4045 * fileio.c (syms_of_fileio):
4046 * fns.c (syms_of_fns):
4047 * frame.c (syms_of_frame):
4048 * fringe.c (syms_of_fringe):
4049 * insdel.c (syms_of_insdel):
4050 * keymap.c (syms_of_keymap):
4051 * lread.c (init_obarray, syms_of_lread):
4052 * macros.c (syms_of_macros):
4053 * msdos.c (syms_of_msdos):
4054 * print.c (syms_of_print):
4055 * process.c (syms_of_process):
4056 * search.c (syms_of_search):
4057 * sound.c (syms_of_sound):
4058 * syntax.c (init_syntax_once, syms_of_syntax):
4059 * terminal.c (syms_of_terminal):
4060 * textprop.c (syms_of_textprop):
4061 * undo.c (syms_of_undo):
4062 * w32.c (globals_of_w32):
4063 * window.c (syms_of_window):
4064 * xdisp.c (syms_of_xdisp):
4065 * xfaces.c (syms_of_xfaces):
4066 * xfns.c (syms_of_xfns):
4067 * xmenu.c (syms_of_xmenu):
4068 * xsettings.c (syms_of_xsettings):
4069 * xterm.c (syms_of_xterm): Use DEFSYM.
4071 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4073 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4075 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4077 Integer and buffer overflow fixes (Bug#8873).
4079 * print.c (printchar, strout): Check for string overflow.
4080 (PRINTPREPARE, printchar, strout):
4081 Don't set size unless allocation succeeds.
4083 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4084 for sizes. Check for string overflow more accurately.
4085 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4087 * macros.c: Integer and buffer overflow fixes.
4088 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4089 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4090 Use ptrdiff_t, not int, for sizes.
4091 Don't increment bufsize until after realloc succeeds.
4092 Check for size-calculation overflow.
4093 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4095 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4097 * lread.c: Integer overflow fixes.
4098 (read_integer): Radix is now EMACS_INT, not int,
4099 to improve quality of diagnostics for out-of-range radices.
4100 Calculate buffer size correctly for out-of-range radices.
4101 (read1): Check for integer overflow in radices, and in
4102 read-circle numbers.
4103 (read_escape): Avoid int overflow.
4104 (Fload, openp, read_buffer_size, read1)
4105 (substitute_object_recurse, read_vector, read_list, map_obarray):
4106 Use ptrdiff_t, not int, for sizes.
4107 (read1): Use EMACS_INT, not int, for sizes.
4108 Check for size overflow.
4110 * image.c (cache_image): Check for size arithmetic overflow.
4112 * lread.c: Integer overflow issues.
4113 (saved_doc_string_size, saved_doc_string_length)
4114 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4115 Now ptrdiff_t, not int.
4116 (read1): Don't assume doc string length fits in int. Check for
4117 out-of-range doc string lengths.
4118 (read_list): Don't assume file position fits in int.
4119 (read_escape): Check for hex character overflow.
4121 2011-06-22 Leo Liu <sdl.web@gmail.com>
4123 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4124 Move to minibuffer.el.
4126 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4128 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4129 The following patches are for when GLYPH_DEBUG && !XASSERT.
4130 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4131 * dispnew.c (flush_stdout):
4132 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4133 Mark as externally visible.
4134 * dispnew.c (check_window_matrix_pointers): Now static.
4135 * dispnew.c (window_to_frame_vpos):
4136 * xfns.c (unwind_create_frame):
4137 * xterm.c (x_check_font): Remove unused local.
4138 * scroll.c (CHECK_BOUNDS):
4139 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4140 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4141 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4142 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4143 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4145 (debug_method_add): Use va_list and vsprintf rather than relying
4146 on undefined behavior with wrong number of arguments.
4147 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4148 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4149 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4150 since we're not interested in debugging glyphs with old libraries.
4151 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4152 GCC 4.6.0's static checking.
4154 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4156 Integer overflow and signedness fixes (Bug#8873).
4157 A few related buffer overrun fixes, too.
4159 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4161 * dispextern.h (struct face.stipple):
4162 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4163 (x_bitmap_mask, x_allocate_bitmap_record)
4164 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4165 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4166 (x_create_bitmap_from_xpm_data):
4167 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4168 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4170 * xfaces.c (load_pixmap):
4171 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4172 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4173 (.bitmaps_last, struct x_output.icon_bitmap):
4174 Use ptrdiff_t, not int, for bitmap indexes.
4175 (x_allocate_bitmap_record): Check for size overflow.
4176 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4178 Use ptrdiff_t, not int, for overlay counts.
4179 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4180 * editfns.c (overlays_around, get_pos_property):
4181 * textprop.c (get_char_property_and_overlay):
4182 * xdisp.c (next_overlay_change, note_mouse_highlight):
4183 * xfaces.c (face_at_buffer_position):
4184 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4185 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4186 (Fnext_overlay_change, Fprevious_overlay_change)
4187 (mouse_face_overlay_overlaps, Foverlays_in):
4188 Use ptrdiff_t, not int, for sizes.
4189 (overlays_at, overlays_in): Check for size-calculation overflow.
4191 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4193 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4194 (x_session_initialize): Do not assume string length fits in int.
4196 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4197 This is unlikely, but can occur if DPI is outlandish.
4199 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4200 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4202 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4203 * xrdb.c (magic_file_p, search_magic_path):
4204 Omit last arg SUFFIX; it was always 0. All callers changed.
4205 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4207 * xfont.c (xfont_match): Avoid need for strlen.
4209 * xfns.c: Don't assume strlen fits in int.
4210 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4212 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4213 not unsigned long, as we prefer signed integers. All callers changed.
4214 Detect integer overflow in repeat count.
4215 (message_dolog): Don't assume print length fits in 39 bytes.
4216 (display_mode_element): Don't assume strlen fits in int.
4218 * termcap.c: Don't assume sizes fit in int and never overflow.
4219 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4220 (gobble_line): Check for size-calculation overflow.
4222 * minibuf.c (Fread_buffer):
4223 * lread.c (intern, intern_c_string):
4224 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4225 Don't assume string length fits in int.
4227 * keyboard.c (parse_tool_bar_item):
4228 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4230 * font.c: Don't assume string length fits in int.
4231 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4232 Use ptrdiff_t, not int.
4233 (font_intern_prop): Don't assume string length fits in int.
4234 Don't assume integer property fits in fixnum.
4235 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4237 * filelock.c: Fix some buffer overrun and integer overflow issues.
4238 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4239 Reformulate so as not to need the command string.
4240 Invoke gzip -cd rather than gunzip, as it's more portable.
4241 (lock_info_type, lock_file_1, lock_file):
4242 Don't assume pid_t and time_t fit in unsigned long.
4243 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4244 (current_lock_owner): Prefer signed type for sizes.
4245 Use memcpy, not strncpy, where memcpy is what is really wanted.
4246 Don't assume (via atoi) that time_t and pid_t fit in int.
4247 Check for time_t and/or pid_t out of range, e.g., via a network share.
4248 Don't alloca where an auto var works fine.
4250 * fileio.c: Fix some integer overflow issues.
4251 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4252 Don't assume string length fits in int.
4253 (directory_file_name): Don't assume string length fits in long.
4254 (make_temp_name): Don't assume pid fits in int, or that its print
4255 length is less than 20.
4257 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4259 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4261 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4263 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4264 We prefer signed integers, even for size calculations.
4266 * emacs.c: Don't assume string length fits in 'int'.
4267 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4268 (main): Don't invoke strlen when not needed.
4270 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4271 (XD_DEBUG_MESSAGE): Don't waste a byte.
4273 * callproc.c (getenv_internal_1, getenv_internal)
4275 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4277 * lread.c (invalid_syntax): Omit length argument.
4278 All uses changed. This doesn't fix a bug, but it simplifies the
4279 code away from its former Hollerith-constant appearance, and it's
4280 one less 'int' to worry about when looking at integer-overflow issues.
4281 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4283 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4284 This didn't break anything, but it didn't help either.
4285 It's confusing to put a bogus integer in a place where the actual
4286 value does not matter.
4287 (LIST_END_P): Remove unused macro and its bogus comment.
4288 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4290 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4291 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4293 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4294 We prefer signed types, and the value cannot exceed the EMACS_INT
4295 range anyway (because otherwise the length would not be representable).
4296 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4297 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4298 This avoids a GCC warning when WIDE_EMACS_INT.
4300 * indent.c (sane_tab_width): New function.
4301 (current_column, scan_for_column, Findent_to, position_indentation)
4302 (compute_motion): Use it. This is just for clarity.
4303 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4305 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4307 * lisp.h (lint_assume): New macro.
4308 * composite.c (composition_gstring_put_cache):
4309 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4311 * editfns.c, insdel.c:
4312 Omit unnecessary forward decls, to simplify future changes.
4314 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4316 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4318 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4319 Use much-faster test for byte-length change.
4320 Don't assume string byte-length fits in 'int'.
4321 Check that character arg fits in 'int'.
4322 (mapcar1): Declare byte as byte, for clarity.
4324 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4326 * fns.c (concat): Catch string overflow earlier.
4327 Do not rely on integer wraparound.
4329 * dispextern.h (struct it.overlay_strings_charpos)
4330 (struct it.selective): Now EMACS_INT, not int.
4331 * xdisp.c (forward_to_next_line_start)
4332 (back_to_previous_visible_line_start)
4333 (reseat_at_next_visible_line_start, next_element_from_buffer):
4334 Don't arbitrarily truncate the value of 'selective' to int.
4336 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4338 * composite.c: Don't truncate sizes to 'int'.
4339 (composition_gstring_p, composition_reseat_it)
4340 (composition_adjust_point): Use EMACS_INT, not int.
4341 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4342 not EMACS_UINT, for indexes.
4344 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4346 * buffer.c: Include <verify.h>.
4347 (struct sortvec.priority, struct sortstr.priority):
4348 Now EMACS_INT, not int.
4349 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4350 (struct sortstr.size, record_overlay_string)
4351 (struct sortstrlist.size, struct sortlist.used):
4352 Don't truncate size to int.
4353 (record_overlay_string): Check for size-calculation overflow.
4354 (init_buffer_once): Check at compile-time, not run-time.
4356 2011-06-22 Jim Meyering <meyering@redhat.com>
4358 Don't leak an XBM-image-sized buffer
4359 * image.c (xbm_load): Free the image buffer after using it.
4361 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4364 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4365 that Sun C diagnosed.
4366 * fns.c (secure_hash): Fix pointer signedness issue.
4367 * intervals.c (static_offset_intervals): New function.
4368 (offset_intervals): Use it.
4370 2011-06-21 Leo Liu <sdl.web@gmail.com>
4373 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4376 * fns.c (secure_hash): Rename from crypto_hash_function and change
4377 the first arg to accept symbols.
4378 (Fsecure_hash): New primitive.
4379 (syms_of_fns): New symbols.
4381 2011-06-20 Deniz Dogan <deniz@dogan.se>
4383 * process.c (Fset_process_buffer): Clarify return value in
4386 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4388 * dispnew.c (add_window_display_history): Use BVAR.
4390 * xdisp.c (debug_method_add): Use BVAR.
4391 (check_window_end, dump_glyph_matrix, dump_glyph)
4392 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4394 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4397 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4398 check till after the cache is created in init_frame_faces.
4400 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4402 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4404 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4406 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4407 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4408 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4410 Improve buffer-overflow checking (Bug#8873).
4411 * fileio.c (Finsert_file_contents):
4412 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4413 Remove the old (too-loose) buffer overflow checks.
4414 They weren't needed, since make_gap checks for buffer overflow.
4415 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4416 The old code merely checked for Emacs fixnum overflow, and relied
4417 on undefined (wraparound) behavior. The new code avoids undefined
4418 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4420 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4421 Tune. Don't use wider integers than needed. Don't use alloca.
4422 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4424 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4426 * insdel.c, lisp.h (buffer_overflow): New function.
4427 (insert_from_buffer_1, replace_range, replace_range_2):
4428 * insdel.c (make_gap_larger):
4429 * editfns.c (Finsert_char):
4430 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4432 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4434 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4436 Integer overflow and signedness fixes (Bug#8873).
4438 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4439 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4441 * fileio.c: Don't assume EMACS_INT fits in off_t.
4442 (emacs_lseek): New static function.
4443 (Finsert_file_contents, Fwrite_region): Use it.
4444 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4446 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4448 * fns.c: Don't overflow int when computing a list length.
4449 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4450 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4451 truncation on 64-bit hosts. Check for QUIT every
4452 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4453 faster and is responsive enough.
4454 (Flength): Report an error instead of overflowing an integer.
4455 (Fsafe_length): Return a float if the value is not representable
4456 as a fixnum. This shouldn't happen except in contrived situations.
4457 (Fnthcdr, Fsort): Don't assume list length fits in int.
4458 (Fcopy_sequence): Don't assume vector length fits in int.
4460 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4461 (header_size, word_size): New constants.
4462 (allocate_vectorlike): Don't check size overflow here.
4463 (allocate_vector): Check it here instead, since this is the only
4464 caller of allocate_vectorlike that could cause overflow.
4465 Check that the new vector's length is representable as a fixnum.
4467 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4468 The previous code was bogus. For example, next_almost_prime (32)
4469 returned 39, which is undesirable as it is a multiple of 3; and
4470 next_almost_prime (24) returned 25, which is a multiple of 5 so
4471 why was the code bothering to check for multiples of 7?
4473 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4475 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4477 Variadic C functions now count arguments with ptrdiff_t.
4478 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4479 Back then I didn't know that the Emacs coding style prefers signed int.
4480 Also, in the meantime I found a few more instances where arguments
4481 were being counted with int, which may truncate counts on 64-bit
4482 machines, or EMACS_INT, which may be unnecessarily wide.
4483 * lisp.h (struct Lisp_Subr.function.aMANY)
4484 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4485 Arg counts are now ptrdiff_t, not size_t.
4486 All variadic functions and their callers changed accordingly.
4487 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4488 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4489 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4490 * callint.c (Fcall_interactively): Check arg count for overflow,
4491 to avoid potential buffer overrun. Use signed char, not 'int',
4492 for 'varies' array, so that we needn't bother to check its size
4493 calculation for overflow.
4494 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4495 * eval.c (apply_lambda):
4496 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4497 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4498 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4500 * callint.c (Fcall_interactively): Don't use index var as event count.
4502 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4503 * mem-limits.h (SIZE): Remove; no longer used.
4505 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4507 Remove unnecessary casts.
4508 * xterm.c (x_term_init):
4509 * xfns.c (x_set_border_pixel):
4510 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4511 These aren't needed now that we assume ANSI C.
4513 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4514 It's more likely to cause problems (due to unsigned overflow)
4517 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4519 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4521 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4523 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4525 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4527 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4529 GLYPH_CODE_FACE returns EMACS_INT, not int.
4530 * dispextern.h (merge_faces):
4531 * xfaces.c (merge_faces):
4532 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4533 Don't assume EMACS_INT fits in int.
4535 * character.h (CHAR_VALID_P): Remove unused parameter.
4536 * fontset.c, lisp.h, xdisp.c: All uses changed.
4538 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4540 * fns.c (concat): Minor tuning based on overflow analysis.
4541 This doesn't fix any bugs. Use int to hold character, instead
4542 of constantly refetching from Emacs object. Use XFASTINT, not
4543 XINT, for value known to be a character. Don't bother comparing
4544 a single byte to 0400, as it's always less.
4546 * floatfns.c (Fexpt):
4547 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4549 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4552 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4554 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4555 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4556 incorrectly succeed when S was a string, because 4294967386 was
4557 truncated before it was used.
4559 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4560 Otherwise, an out-of-range integer could cause undefined behavior
4563 * composite.c: Use int, not EMACS_INT, for characters.
4564 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4565 EMACS_INT, for values that are known to be in character range.
4566 This doesn't fix any bugs but is the usual style inside Emacs and
4567 may generate better code on 32-bit machines.
4569 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4570 This is for reasons similar to the recent CHAR_STRING fix.
4571 * charset.c (Fencode_char): Check that character arg is actually
4572 a character. Pass an int to ENCODE_CHAR.
4573 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4574 wider than 'int', as a compile-time check to prevent future regressions
4577 * character.c (char_string): Remove unnecessary casts.
4579 Make sure a 64-bit char is never passed to CHAR_STRING.
4580 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4581 by silently ignoring the top 32 bits, allowing some values
4582 that were far too large to be valid characters.
4583 * character.h: Include <verify.h>.
4584 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4585 arguments are no wider than unsigned, as a compile-time check
4586 to prevent future regressions in this area.
4588 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4589 (Fsubst_char_in_region):
4591 * xdisp.c (decode_mode_spec_coding):
4592 Adjust to CHAR_STRING's new requirement.
4593 * editfns.c (Finsert_char, Fsubst_char_in_region):
4594 * fns.c (concat): Check that character args are actually
4595 characters. Without this test, these functions did the wrong
4596 thing with wildly out-of-range values on 64-bit hosts.
4598 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4599 These casts should not be needed on 32-bit hosts, either.
4600 * keyboard.c (read_char):
4601 * lread.c (Fload): Remove casts to unsigned.
4603 * lisp.h (UNSIGNED_CMP): New macro.
4604 This fixes comparison bugs on 64-bit hosts.
4605 (ASCII_CHAR_P): Use it.
4606 * casefiddle.c (casify_object):
4607 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4608 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4609 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4610 * dispextern.h (FACE_FROM_ID):
4611 * keyboard.c (read_char): Use UNSIGNED_CMP.
4613 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4614 not to EMACS_INT, to avoid GCC warning.
4616 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4618 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4619 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4620 isn't needed on 32-bit machines.
4622 * buffer.c (Fgenerate_new_buffer_name):
4623 Use EMACS_INT for count, not int.
4624 (advance_to_char_boundary): Return EMACS_INT, not int.
4626 * data.c (Qcompiled_function): Now static.
4628 * window.c (window_body_lines): Now static.
4630 * image.c (gif_load): Rename local to avoid shadowing.
4632 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4633 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4634 * alloc.c (make_save_value): Integer argument is now of type
4636 (mark_object): Use ptrdiff_t, not int.
4637 * lisp.h (pD): New macro.
4638 * print.c (print_object): Use it.
4640 * alloc.c: Use EMACS_INT, not int, to count objects.
4641 (total_conses, total_markers, total_symbols, total_vector_size)
4642 (total_free_conses, total_free_markers, total_free_symbols)
4643 (total_free_floats, total_floats, total_free_intervals)
4644 (total_intervals, total_strings, total_free_strings):
4645 Now EMACS_INT, not int. All uses changed.
4646 (Fgarbage_collect): Compute overall total using a double, so that
4647 integer overflow is less likely to be a problem. Check for overflow
4648 when converting back to an integer.
4649 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4650 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4651 These were 'int' variables that could overflow on 64-bit hosts;
4652 they were never used, so remove them instead of repairing them.
4653 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4654 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4655 Previously, this ceilinged at INT_MAX, but that doesn't work on
4657 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4659 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4660 (allocate_vectorlike): Check for ptrdiff_t overflow.
4661 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4662 when a (possibly-narrower) signed value would do just as well.
4663 We prefer using signed arithmetic, to avoid comparison confusion.
4665 * alloc.c: Catch some string size overflows that we were missing.
4666 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4667 for convenience in STRING_BYTES_MAX.
4668 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4669 The definition here is exact; the one in lisp.h was approximate.
4670 (allocate_string_data): Check for string overflow. This catches
4671 some instances we weren't catching before. Also, it catches
4672 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4673 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4674 and ptrdiff_t and EMACS_INT are both 64 bits.
4676 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4677 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4678 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4680 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4682 * alloc.c (Fmake_string): Check for out-of-range init.
4684 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4686 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4688 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4690 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4691 xg_get_default_scrollbar_width.
4693 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4694 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4695 (style_changed_cb): Call update_theme_scrollbar_width and call
4696 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4697 all frames (Bug#8505).
4698 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4699 Call gtk_window_set_resizable if HAVE_GTK3.
4700 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4701 and height if HAVE_GTK3 (Bug#8505).
4702 (scroll_bar_width_for_theme): New variable.
4703 (update_theme_scrollbar_width): New function.
4704 (xg_get_default_scrollbar_width): Move code to
4705 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4706 (xg_initialize): Call update_theme_scrollbar_width.
4708 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4710 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4712 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4714 * frame.c (make_frame): Call other_buffer_safely instead of
4717 * window.c (temp_output_buffer_show): Call display_buffer with
4718 second argument Vtemp_buffer_show_specifiers and reset latter
4719 immediately after the call.
4720 (Vtemp_buffer_show_specifiers): New variable.
4721 (auto_window_vscroll_p, next_screen_context_lines)
4722 (Vscroll_preserve_screen_position): Remove leading asterisks from
4725 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4727 Fix minor problems found by GCC 4.6.0 static checking.
4728 * buffer.c (Qclone_number): Remove for now, as it's unused.
4729 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4730 (record_buffer): Remove unused local.
4731 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4732 (set_frame_buffer_list): Remove; unused.
4733 * frame.h (other_visible_frames): Remove decl.
4734 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4735 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4736 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4738 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4739 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4740 Define only if HAVE_GPM.
4741 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4742 (update_hints_inhibit): Remove; never set. All uses removed.
4743 * widgetprv.h (emacsFrameClassRec): Remove decl.
4744 * window.c (delete_deletable_window): Now returns void, since it
4745 wasn't returning anything.
4746 (compare_window_configurations): Remove unused locals.
4747 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4748 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4749 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4750 the same widths as pointers. This follows up on the 2011-05-06 patch.
4751 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4752 * xterm.h: Likewise.
4753 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4755 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4757 * makefile.w32-in: Update dependencies.
4758 (LISP_H): Add lib/intprops.h.
4760 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4762 * image.c (gif_load): Add animation frame delay to the metadata.
4763 (syms_of_image): Use DEFSYM. New symbol `delay'.
4765 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4767 * window.c (delete_deletable_window): Re-add.
4768 (Fset_window_configuration): Rewrite to handle dead buffers and
4769 consequently deletable windows.
4770 (window_tree, Fwindow_tree): Remove. Supply functionality in
4772 (compare_window_configurations): Simplify code.
4774 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4776 * image.c (imagemagick_load_image): Fix type mismatch.
4777 (Fimagemagick_types): Likewise.
4779 * window.h (replace_buffer_in_windows): Declare.
4781 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4783 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4784 Qclone_number. Remove external declaration of Qdelete_window.
4785 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4787 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4788 Run Qbuffer_list_update_hook if allowed.
4789 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4790 buffer list implementation.
4791 (other_buffer_safely): New function.
4792 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4793 calls to replace_buffer_in_windows and
4794 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4796 (record_buffer): Inhibit quitting and rewrite using quittable
4797 functions. Run Qbuffer_list_update_hook if allowed.
4798 (Frecord_buffer, Funrecord_buffer): New functions.
4799 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4800 Move switch-to-buffer to window.el.
4801 (bury-buffer): Move to window.el.
4802 (Vbuffer_list_update_hook): New variable.
4804 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4807 * window.h (resize_frame_windows): Move up in code.
4808 (Fwindow_frame): Remove EXFUN.
4809 (replace_buffer_in_all_windows): Remove prototype.
4810 (replace_buffer_in_windows_safely): Add prototype.
4812 * window.c: Declare Qdelete_window static again. Move down
4813 declaration of select_count.
4814 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4815 (Fother_window): Move to window.el.
4816 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4817 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4818 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4820 (replace_buffer_in_windows): Implement by calling
4821 Qreplace_buffer_in_windows.
4822 (replace_buffer_in_all_windows): Remove with some functionality
4823 moved into replace_buffer_in_windows_safely.
4824 (replace_buffer_in_windows_safely): New function.
4825 (select_window_norecord, select_frame_norecord): Move in front
4826 of run_window_configuration_change_hook. Remove now obsolete
4828 (Fset_window_buffer): Rewrite doc-string.
4829 Call Qrecord_window_buffer.
4830 (keys_of_window): Move binding for other-window to window.el.
4832 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4834 * dispextern.h (struct image): Replace data member, whose int_val
4835 and ptr_val fields were not used by anything, with a single
4838 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4839 (gif_clear_image, gif_load, imagemagick_load_image)
4840 (gs_clear_image, gs_load): Callers changed.
4842 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4844 * buffer.h: Include <time.h>, for time_t.
4845 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4847 Fix minor problems found by static checking.
4849 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4851 Make identifiers static if they are not used in other modules.
4852 * data.c (Qcompiled_function, Qframe, Qvector):
4853 * image.c (QimageMagick, Qsvg):
4854 * minibuf.c (Qmetadata):
4855 * window.c (resize_window_check, resize_root_window): Now static.
4856 * window.h (resize_window_check, resize_root_window): Remove decls.
4858 * window.c (window_deletion_count, delete_deletable_window):
4860 (window_body_lines): Now static.
4861 (Fdelete_other_windows_internal): Mark vars as initialized.
4862 Make sure 'resize_failed' is initialized.
4863 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4864 (resize_window_apply): Remove unused local.
4865 * window.h (delete_deletable_window): Remove decl.
4867 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4868 (imagemagick_load_image): Fix pointer signedness problem by changing
4869 last arg from unsigned char * to char *. All uses changed.
4870 Also, fix a local for similar reasons.
4871 Remove unused locals. Remove locals to avoid shadowing.
4872 (fn_rsvg_handle_free): Remove; unused.
4873 (svg_load, svg_load_image): Fix pointer signedness problem.
4874 (imagemagick_load_image): Don't use garbage pointer image_wand.
4876 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4878 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4880 * image.c (gif_load): Fix omitted cast error introduced by
4883 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4885 * window.h (resize_proportionally, orig_total_lines)
4886 (orig_top_line): Remove from window structure.
4887 (set_window_height, set_window_width, change_window_heights)
4888 (Fdelete_window): Remove prototypes.
4889 (resize_frame_windows): Remove duplicate declaration.
4891 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4893 * window.h (resize_frame_windows, resize_window_check)
4894 (delete_deletable_window, resize_root_window)
4895 (resize_frame_windows): Declare prototypes.
4897 * window.c (resize_window_apply): Make definition be "static" to
4898 match the prototype.
4900 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4902 * window.c: Remove declarations of Qwindow_size_fixed,
4903 window_min_size_1, window_min_size_2, window_min_size,
4904 size_window, window_fixed_size_p, enlarge_window, delete_window.
4905 Remove static from declaration of Qdelete_window, it's
4906 temporarily needed by Fbury_buffer.
4907 (replace_window): Don't assign orig_top_line and
4909 (Fdelete_window, delete_window): Remove. Window deletion is
4910 handled by window.el.
4911 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4912 Replace Fdelete_window calls with calls to Qdelete_window.
4913 (Fdelete_other_windows): Remove. Deleting other windows is
4914 handled by window.el.
4915 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4916 handled in window.el.
4917 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4918 Window minimum sizes are handled in window.el.
4919 (shrink_windows, size_window, set_window_height)
4920 (set_window_width, change_window_heights, window_height)
4921 (window_width, CURBEG, CURSIZE, enlarge_window)
4922 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4923 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4924 handled in window.el.
4925 (make_dummy_parent): Rename to make_parent_window and give it a
4926 second argument horflag.
4927 (make_window): Don't set resize_proportionally any more.
4928 (Fsplit_window): Remove. Windows are split in window.el.
4929 (save_restore_action, save_restore_orig_size)
4930 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4931 Resize mini windows in window.el.
4932 (grow_mini_window, shrink_mini_window): Implement by calling
4933 Qresize_root_window_vertically, resize_window_check and
4934 resize_window_apply.
4935 (saved_window, Fset_window_configuration, save_window_save):
4936 Do not handle orig_top_line, orig_total_lines, and
4937 resize_proportionally.
4938 (window_min_height, window_min_width): Move to window.el.
4939 (keys_of_window): Move bindings for delete-other-windows,
4940 split-window, delete-window and enlarge-window to window.el.
4942 * buffer.c: Temporarily extern Qdelete_window.
4943 (Fbury_buffer): Temporarily call Qdelete_window instead of
4944 Fdelete_window (Fbury_buffer will move to window.el soon).
4946 * frame.c (set_menu_bar_lines_1): Remove code handling
4947 orig_top_line and orig_total_lines.
4949 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4950 set_window_height but set heights directly.
4951 (change_frame_size_1): Use resize_frame_windows.
4953 * xdisp.c (init_xdisp): Don't use set_window_height but set
4956 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4957 Use resize_frame_windows instead of change_window_heights and run
4958 run_window_configuration_change_hook.
4960 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4961 instead of change_window_heights and run
4962 run_window_configuration_change_hook.
4964 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4966 * window.c (replace_window): Rename second argument REPLACEMENT to
4967 NEW. New third argument SETFLAG. Rewrite.
4968 (delete_window, make_dummy_parent): Call replace_window with
4970 (window_list_1): Move down in code.
4971 (run_window_configuration_change_hook): Move set_buffer part
4972 before select_frame_norecord part in order to unwind correctly.
4973 Rename count1 to count.
4974 (recombine_windows, delete_deletable_window, resize_root_window)
4975 (Fdelete_other_windows_internal)
4976 (Frun_window_configuration_change_hook, make_parent_window)
4977 (resize_window_check, resize_window_apply, Fresize_window_apply)
4978 (resize_frame_windows, Fsplit_window_internal)
4979 (Fdelete_window_internal, Fresize_mini_window_internal):
4981 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4983 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4985 * window.h (window): Add some new members to window structure -
4986 normal_lines, normal_cols, new_total, new_normal, clone_number,
4987 splits, nest, prev_buffers, next_buffers.
4988 (WINDOW_TOTAL_SIZE): Move here from window.c.
4989 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4991 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4993 (make_dummy_parent): Set new members of windows structure.
4994 (make_window): Move down in code. Handle new members of window
4996 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4997 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4998 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4999 (Fset_window_prev_buffers, Fwindow_next_buffers)
5000 (Fset_window_next_buffers, Fset_window_clone_number):
5002 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5003 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5005 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5006 Argument WINDOW can be now internal window too.
5007 (Fwindow_use_time): Move up in code.
5008 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5010 (Fset_window_configuration, saved_window)
5011 (Fcurrent_window_configuration, save_window_save): Handle new
5012 members of window structure.
5013 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5014 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5015 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5016 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5017 Qget_mru_window, Qresize_root_window,
5018 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5019 Qauto_buffer_name; staticpro them.
5021 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5023 * window.c (Fwindow_total_size, Fwindow_left_column)
5024 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5025 (Fwindow_list_1): New functions.
5026 (window_box_text_cols): Replace with window_body_cols.
5027 (Fwindow_width, Fscroll_left, Fscroll_right):
5028 Use window_body_cols instead of window_box_text_cols.
5029 (delete_window, Fset_window_configuration):
5030 Call delete_all_subwindows with window as argument.
5031 (delete_all_subwindows): Take a window as argument and not a
5033 (window_loop): Remove handling of GET_LRU_WINDOW and
5035 (Fget_lru_window, Fget_largest_window): Move to window.el.
5037 * window.h: Extern window_body_cols instead of
5038 window_box_text_cols. delete_all_subwindows now takes a
5039 Lisp_Object as argument.
5041 * indent.c (compute_motion, Fcompute_motion):
5042 Use window_body_cols instead of window_box_text_cols.
5044 * frame.c (delete_frame): Call delete_all_subwindows with root
5047 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5049 * fns.c (Fputhash): Document return value.
5051 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5053 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5055 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5057 Cons<->int and similar integer overflow fixes (Bug#8794).
5059 Check for overflow when converting integer to cons and back.
5060 * charset.c (Fdefine_charset_internal, Fdecode_char):
5061 Use cons_to_unsigned to catch overflow.
5062 (Fencode_char): Use INTEGER_TO_CONS.
5063 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5064 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5065 * data.c (long_to_cons, cons_to_long): Remove.
5066 (cons_to_unsigned, cons_to_signed): New functions.
5067 These signal an error for invalid or out-of-range values.
5068 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5069 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5070 * font.c (Ffont_variation_glyphs):
5071 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5072 * lisp.h: Include <intprops.h>.
5073 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5074 (cons_to_signed, cons_to_unsigned): New decls.
5075 (long_to_cons, cons_to_long): Remove decls.
5076 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5077 (Fprimitive_undo): Use CONS_TO_INTEGER.
5078 * xfns.c (Fx_window_property): Likewise.
5079 * xselect.c: Include <limits.h>.
5080 (x_own_selection, selection_data_to_lisp_data):
5081 Use INTEGER_TO_CONS.
5082 (x_handle_selection_request, x_handle_selection_clear)
5083 (x_get_foreign_selection, Fx_disown_selection_internal)
5084 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5085 (lisp_data_to_selection_data): Use cons_to_unsigned.
5086 (x_fill_property_data): Use cons_to_signed.
5087 Report values out of range.
5089 Check for buffer and string overflow more precisely.
5090 * buffer.h (BUF_BYTES_MAX): New macro.
5091 * lisp.h (STRING_BYTES_MAX): New macro.
5092 * alloc.c (Fmake_string):
5093 * character.c (string_escape_byte8):
5094 * coding.c (coding_alloc_by_realloc):
5095 * doprnt.c (doprnt):
5096 * editfns.c (Fformat):
5098 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5099 since they may not be the same number.
5100 * editfns.c (Finsert_char):
5101 * fileio.c (Finsert_file_contents):
5102 Likewise for BUF_BYTES_MAX.
5104 * image.c: Use ptrdiff_t, not int, for sizes.
5105 (slurp_file): Switch from int to ptrdiff_t.
5107 (slurp_file): Check that file size fits in both size_t (for
5108 malloc) and ptrdiff_t (for sanity and safety).
5110 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5111 if b->modtime has its maximal value.
5113 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5115 Don't assume time_t can fit into int.
5116 * buffer.h (struct buffer.modtime): Now time_t, not int.
5117 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5118 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5120 Minor fixes for signed vs unsigned integers.
5121 * character.h (MAYBE_UNIFY_CHAR):
5122 * charset.c (maybe_unify_char):
5123 * keyboard.c (read_char, reorder_modifiers):
5124 XINT -> XFASTINT, since the integer must be nonnegative.
5125 * ftfont.c (ftfont_spec_pattern):
5126 * keymap.c (access_keymap, silly_event_symbol_error):
5127 XUINT -> XFASTINT, since the integer must be nonnegative.
5128 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5129 since it makes no difference and we prefer signed.
5130 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5131 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5134 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5136 * window.h (Fwindow_frame): Declare.
5138 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5140 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5141 (SPARE_MEMORY): Always define.
5142 (LARGE_REQUEST): Remove.
5143 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5145 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5147 * lisp.h: Move EXFUNS for Fframe_root_window,
5148 Fframe_first_window and Fset_frame_selected_window to window.h.
5150 * window.h: Move EXFUNS for Fframe_root_window,
5151 Fframe_first_window and Fset_frame_selected_window here from
5154 * frame.c (Fwindow_frame, Fframe_first_window)
5155 (Fframe_root_window, Fframe_selected_window)
5156 (Fset_frame_selected_window): Move to window.c.
5157 (Factive_minibuffer_window): Move to minibuf.c.
5158 (Fother_visible_frames_p): New function.
5160 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5162 * window.c (decode_window, decode_any_window): Move up in code.
5163 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5164 (inhibit_frame_unsplittable): Remove unused variable.
5165 (Fwindow_buffer): Move up and rewrite doc-string.
5166 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5167 (Fwindow_prev): New functions.
5168 (Fwindow_frame): Move here from frame.c. Accept any window as
5170 (Fframe_root_window, Fframe_first_window)
5171 (Fframe_selected_window): Move here from frame.c. Accept frame
5172 or arbitrary window as argument. Update doc-strings.
5173 (Fminibuffer_window): Move up in code.
5174 (Fwindow_minibuffer_p): Move up in code and simplify.
5175 (Fset_frame_selected_window): Move here from frame.c.
5177 (Fselected_window, select_window, Fselect_window): Move up in
5178 code. Minor doc-string fixes.
5180 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5182 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5183 Do not assume that spare memory exists; that assumption is valid
5184 only if SYSTEM_MALLOC.
5185 (LARGE_REQUEST): New macro, so that the issue of large requests
5186 is separated from the issue of spare memory.
5188 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5190 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5193 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5195 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5198 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5200 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5202 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5204 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5205 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5207 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5209 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5211 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5213 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5214 (x_clipboard_manager_save): Add return value.
5215 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5217 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5218 Obey Vx_select_enable_clipboard_manager. Catch errors in
5219 x_clipboard_manager_save (Bug#8779).
5220 (Vx_select_enable_clipboard_manager): New variable.
5221 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5223 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5225 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5227 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5229 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5230 in the current matrix if keep_current_p is non-zero.
5232 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5234 * bidi.c (bidi_level_of_next_char): Fix last change.
5236 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5238 Support bidi reordering of text covered by display properties.
5240 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5241 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5242 (bidi_cache_search, bidi_cache_iterator_state)
5243 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5244 (bidi_level_of_next_char, bidi_move_to_visually_next):
5245 Support character positions inside a run of characters covered by a
5247 (bidi_paragraph_init, bidi_resolve_explicit_1)
5248 (bidi_level_of_next_char): Call bidi_fetch_char and
5249 bidi_fetch_char_advance instead of FETCH_CHAR and
5251 (bidi_init_it): Initialize new members.
5252 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5254 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5255 instead of using explicit *_CHAR codes.
5256 (bidi_resolve_explicit, bidi_resolve_weak):
5257 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5258 bidirectional text is supported only in multibyte buffers.
5259 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5260 it to initialize the frame_window_p member of struct bidi_it.
5261 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5262 (bidi_resolve_explicit, bidi_resolve_weak)
5263 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5264 bidi_it->nchars is non-positive.
5265 (bidi_level_of_next_char): Don't try to lookup the cache for the
5266 next/previous character if nothing is cached there yet, or if we
5267 were just reseat()'ed to a new position.
5269 * xdisp.c (set_cursor_from_row): Set start and stop points
5270 according to the row's direction when priming the loop that looks
5271 for the glyph on which to display cursor.
5272 (single_display_spec_intangible_p): Function deleted.
5273 (display_prop_intangible_p): Reimplement to call
5274 handle_display_spec instead of single_display_spec_intangible_p.
5275 Accept 3 additional arguments needed by handle_display_spec.
5276 This fixes incorrect cursor motion across display property with complex
5277 values: lists, `(when COND...)' forms, etc.
5278 (single_display_spec_string_p): Support property values that are
5279 lists with the argument STRING its top-level element.
5280 (display_prop_string_p): Fix the condition for processing a
5281 property that is a list to be consistent with handle_display_spec.
5282 (handle_display_spec): New function, refactored from the
5283 last portion of handle_display_prop.
5284 (compute_display_string_pos): Accept additional argument
5285 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5286 value of a `display' property is a "replacing spec".
5287 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5288 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5289 the display property, but just return a value indicating whether
5290 the display property will replace the characters it covers.
5291 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5292 frame_window_p members of struct bidi_it.
5293 (compute_display_string_pos, compute_display_string_end):
5295 (push_it): Accept second argument POSITION, where pop_it should
5296 jump to continue iteration.
5297 (reseat_1): Initialize bidi_it.disp_pos.
5299 * keyboard.c (adjust_point_for_property): Adjust the call to
5300 display_prop_intangible_p to its new signature.
5302 * dispextern.h (struct bidi_it): New member frame_window_p.
5303 (bidi_init_it): Update prototypes.
5304 (display_prop_intangible_p): Update prototype.
5305 (compute_display_string_pos, compute_display_string_end):
5307 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5310 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5312 Malloc failure behavior now depends on size of allocation.
5313 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5314 * lisp.h: Change signatures accordingly.
5315 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5316 All callers changed. (Bug#8762)
5318 * gnutls.c: Use Emacs's memory allocators.
5319 Without this change, the gnutls library would invoke malloc etc.
5320 directly, which causes problems on non-SYNC_INPUT hosts, and which
5321 runs afoul of improving memory_full behavior. (Bug#8761)
5322 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5323 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5324 xfree instead of the default malloc, realloc, free.
5325 (Fgnutls_boot): No need to check for memory allocation failure,
5326 since xmalloc does that for us.
5328 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5329 * category.c (hash_get_category_set):
5330 * ccl.c (ccl_driver):
5331 * charset.c (Fdefine_charset_internal):
5332 * charset.h (struct charset.hash_index):
5333 * composite.c (get_composition_id, gstring_lookup_cache)
5334 (composition_gstring_put_cache):
5335 * composite.h (struct composition.hash_index):
5336 * dispextern.h (struct image.hash):
5337 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5338 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5339 (hashfn_equal, hashfn_user_defined, make_hash_table)
5340 (maybe_resize_hash_table, hash_lookup, hash_put)
5341 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5342 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5343 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5344 * image.c (make_image, search_image_cache, lookup_image)
5345 (xpm_put_color_table_h):
5346 * lisp.h (struct Lisp_Hash_Table):
5347 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5348 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5349 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5350 * alloc.c (allocate_vectorlike):
5351 Check for overflow in vector size calculations.
5352 * ccl.c (ccl_driver):
5353 Check for overflow when converting EMACS_INT to int.
5354 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5355 need to be updated by these changes.
5356 * fns.c (make_hash_table, maybe_resize_hash_table):
5357 Check for integer overflow with large hash tables.
5358 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5359 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5360 (SXHASH_REDUCE): New macro.
5361 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5362 Use it instead of discarding useful hash info with large hash values.
5363 (sxhash_float): New function.
5364 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5365 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5366 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5367 Rewrite to use FIXNUM_BITS, as this simplifies things.
5368 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5369 Adjust signatures to match updated version of code.
5370 (consing_since_gc): Now EMACS_INT, since a single hash table can
5371 use more than INT_MAX bytes.
5373 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5375 Make it possible to build with GCC-4.6+ -O2 -flto.
5377 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5379 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5381 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5382 Call minibuffer-inactive-mode.
5384 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5386 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5387 Update dependencies.
5389 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5391 * data.c (init_data): Remove code for UTS, this system is not
5394 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5396 Don't force ./temacs to start in terminal mode.
5398 * frame.c (make_initial_frame): Initialize faces in all cases, not
5399 only when CANNOT_DUMP is defined.
5400 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5402 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5404 * dispnew.c (add_window_display_history): Use const for the string
5405 pointer. Remove declaration, not needed.
5407 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5409 Use 'inline', not 'INLINE'.
5410 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5411 * alloc.c, fontset.c (INLINE): Remove.
5412 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5413 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5414 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5415 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5416 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5418 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5420 Make it possible to run ./temacs.
5422 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5423 syms_of_callproc does the same thing. Remove test for
5424 "initialized", do it in the caller.
5425 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5427 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5429 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5430 (read_minibuf): Use get_minibuffer.
5431 (syms_of_minibuf): Use DEFSYM.
5432 (Qmetadata): New var.
5433 * data.c (Qbuffer): Don't make it static.
5434 (syms_of_data): Use DEFSYM.
5436 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5438 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5439 (CCL_CODE_MIN): New macro.
5441 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5443 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5445 * eval.c (Qdebug): Now static.
5446 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5447 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5448 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5450 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5452 * image.c: Various fixes to ImageMagick code comments.
5453 (Fimagemagick_types): Doc fix.
5455 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5457 Minor fixes prompted by GCC 4.6.0 warnings.
5459 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5461 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5462 (x_clipboard_manager_save_all): Move extern decl to ...
5463 * xterm.h: ... here, so that it can be checked for consistency.
5465 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5467 * xselect.c (x_clipboard_manager_save_frame)
5468 (x_clipboard_manager_save_all): New functions.
5469 (Fx_clipboard_manager_save): Lisp function deleted.
5471 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5472 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5474 * xterm.h: Update prototype.
5476 2011-05-28 William Xu <william.xwl@gmail.com>
5478 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5481 2011-05-28 Jim Meyering <meyering@redhat.com>
5483 Avoid a sign-extension bug in crypto_hash_function.
5484 * fns.c (to_uchar): Define.
5485 (crypto_hash_function): Use it to convert some newly-signed
5486 variables to unsigned, to avoid sign-extension bugs. For example,
5487 without this change, (md5 "truc") would evaluate to
5488 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5489 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5490 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5492 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5494 Integer overflow fixes.
5496 * dbusbind.c: Serial number integer overflow fixes.
5497 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5498 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5499 to hold a serial number that is too large for a fixnum.
5500 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5501 Check for serial numbers out of range. Decode any serial number
5502 that was so large that it became a float. (Bug#8722)
5504 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5505 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5506 Use XFASTINT rather than XUINT when numbers are nonnegative.
5507 (xd_append_arg, Fdbus_method_return_internal):
5508 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5509 arguments, check that Lisp number is nonnegative, rather than
5510 silently wrapping negative numbers around. (Bug#8722)
5511 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5514 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5516 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5518 ccl: add integer overflow checks
5519 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5520 (IN_INT_RANGE): New macros.
5521 (ccl_driver): Use them to check for integer overflow when
5522 decoding a CCL program. Many of the new checks are whether XINT (x)
5523 fits in int; it doesn't always, on 64-bit hosts. The new version
5524 doesn't catch all possible integer overflows, but it's an
5525 improvement. (Bug#8719)
5527 * alloc.c (make_event_array): Use XINT, not XUINT.
5528 There's no need for unsigned here.
5530 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5531 This follows up to the 2011-05-06 change that substituted uintptr_t
5532 for EMACS_INT. This case wasn't caught back then.
5534 Rework Fformat to avoid integer overflow issues.
5535 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5536 now (part of C89). Include <verify.h>.
5537 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5538 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5539 (Fformat): Avoid the prepass trying to compute sizes; it was only
5540 approximate and thus did not catch overflow reliably. Instead, walk
5541 through the format just once, formatting and computing sizes as we go,
5542 checking for integer overflow at every step, and allocating a larger
5543 buffer as needed. Keep track separately whether the format is
5544 multibyte. Keep only the most-recently calculated precision, rather
5545 than them all. Record whether each argument has been converted to
5546 string. Use EMACS_INT, not int, for byte and char and arg counts.
5547 Support field widths and precisions larger than INT_MAX. Avoid
5548 sprintf's undefined behavior with conversion specifications such as %#d
5549 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5550 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5551 formatting out-of-range floating point numbers with int
5554 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5556 * data.c: Avoid integer truncation in expressions involving floats.
5557 * data.c: Include <intprops.h>.
5558 (arith_driver): When there's an integer overflow in an expression
5559 involving floating point, convert the integers to floating point
5560 so that the resulting value does not suffer from catastrophic
5561 integer truncation. For example, on a 64-bit host (* 4
5562 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5563 Do not rely on undefined behavior after integer overflow.
5565 merge count_size_as_multibyte, parse_str_to_multibyte
5566 * character.c, character.h (count_size_as_multibyte):
5567 Rename from parse_str_to_multibyte; all uses changed.
5568 Check for integer overflow.
5569 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5570 since it's now a duplicate of the other. This is more of
5571 a character than a buffer op, so better that it's in character.c.
5572 * fns.c, print.c: Adjust to above changes.
5574 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5576 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5578 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5580 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5581 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5582 (x_clipboard_manager_save): Now static.
5583 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5585 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5586 (crypto_hash_function): Now static.
5587 Fix pointer signedness problems. Avoid unnecessary initializations.
5589 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5591 * termhooks.h (Vselection_alist): Make it terminal-local.
5593 * terminal.c (create_terminal): Initialize it.
5595 * xselect.c: Support for clipboard managers.
5596 (Vselection_alist): Move to termhooks.h as terminal-local var.
5597 (LOCAL_SELECTION): New macro.
5598 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5599 (symbol_to_x_atom): Remove gratuitous arg.
5600 (x_handle_selection_request, lisp_data_to_selection_data)
5601 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5602 (x_own_selection, x_get_local_selection, x_convert_selection):
5603 New arg, specifying work frame. Use terminal-local Vselection_alist.
5604 (some_frame_on_display): Delete unused function.
5605 (Fx_own_selection_internal, Fx_get_selection_internal)
5606 (Fx_disown_selection_internal, Fx_selection_owner_p)
5607 (Fx_selection_exists_p): New optional frame arg.
5608 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5609 (x_handle_selection_clear): Don't treat other terminals with the
5610 same keyboard specially. Use the terminal-local Vselection_alist.
5611 (x_clear_frame_selections): Use Frun_hook_with_args.
5613 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5615 * xterm.h: Add support for those atoms.
5617 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5619 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5620 (converted_selections, conversion_fail_tag): New global variables.
5621 (x_selection_request_lisp_error): Free the above.
5622 (x_get_local_selection): Remove unnecessary code.
5623 (x_reply_selection_request): Args changed; handle arbitrary array
5624 of converted selections stored in converted_selections.
5625 Separate the XChangeProperty and SelectionNotify steps.
5626 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5627 (x_convert_selection): New function.
5628 (x_handle_selection_event): Simplify.
5629 (x_get_foreign_selection): Don't ignore incoming requests while
5630 waiting for an answer; this will fail when we implement
5631 SAVE_TARGETS, and seems unnecessary anyway.
5632 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5633 (Vx_sent_selection_functions): Doc fix.
5635 2011-05-26 Leo Liu <sdl.web@gmail.com>
5637 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5639 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5641 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5643 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5644 for fringe update if it has periodic bitmap.
5645 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5646 and fringe_bitmap_periodic_p.
5648 * fringe.c (get_fringe_bitmap_data): New function.
5649 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5650 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5651 row. Mark glyph row for fringe update if periodicity changed.
5653 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5654 for fringe update unless it has periodic bitmap.
5656 2011-05-25 Kenichi Handa <handa@m17n.org>
5658 * xdisp.c (get_next_display_element): Set correct it->face_id for
5659 a static composition.
5661 2011-05-24 Leo Liu <sdl.web@gmail.com>
5664 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5666 * fns.c (crypto_hash_function, Fsha1): New function.
5667 (Fmd5): Use crypto_hash_function.
5668 (syms_of_fns): Add Ssha1.
5670 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5672 * gnutls.c: Remove unused macros.
5673 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5674 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5675 Remove macros that are defined and never used.
5676 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5678 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5680 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5681 (Fx_get_selection_internal): Minor cleanup.
5682 (Fx_own_selection_internal): Rename arguments for consistency with
5685 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5687 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5689 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5691 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5693 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5695 * dispnew.c (scrolling_window): Don't exclude the case that the
5696 last enabled row in the desired matrix touches the bottom boundary.
5698 2011-05-21 Glenn Morris <rgm@gnu.org>
5700 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5701 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5702 and add some more files.
5704 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5706 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5707 report_file_error introduced by the change from 2011-05-07.
5709 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5711 * systime.h (Time): Define only if emacs is defined.
5712 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5713 where the include path doesn't have X11/X.h by default. See
5714 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5716 2011-05-20 Kenichi Handa <handa@m17n.org>
5718 * composite.c (find_automatic_composition): Fix previous change.
5720 2011-05-20 Glenn Morris <rgm@gnu.org>
5722 * lisp.mk: New file, split from Makefile.in.
5723 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5724 (shortlisp): Remove.
5725 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5727 2011-05-19 Glenn Morris <rgm@gnu.org>
5729 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5730 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5731 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5732 (lisp): Set the order to that of loadup.el.
5733 (shortlisp): Make it a copy of $lisp.
5734 (SOME_MACHINE_LISP): Remove.
5735 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5736 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5738 2011-05-18 Kenichi Handa <handa@m17n.org>
5740 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5741 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5742 (find_automatic_composition): Mostly rewrite for efficiency.
5744 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5746 * makefile.w32-in: Update dependencies.
5748 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5750 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5751 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5753 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5755 Fix some integer overflow issues, such as string length overflow.
5757 * insdel.c (count_size_as_multibyte): Check for string overflow.
5759 * character.c (lisp_string_width): Check for string overflow.
5760 Use EMACS_INT, not int, for string indexes and lengths; in
5761 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5762 the resulting string length overflows an EMACS_INT; instead,
5763 report a string overflow if no precision given. When checking for
5764 precision exhaustion, use a check that cannot possibly have
5765 integer overflow. (Bug#8675)
5766 * character.h (lisp_string_width): Adjust to new signature.
5768 * alloc.c (string_overflow): New function.
5769 (Fmake_string): Use it. This doesn't change behavior, but saves
5770 a few bytes and will simplify future changes.
5771 * character.c (string_escape_byte8): Likewise.
5772 * lisp.h (string_overflow): New decl.
5774 Fixups, following up to the user-interface timestamp change.
5775 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5776 for UI timestamps, instead of unsigned long.
5777 * msdos.c (mouse_get_pos): Likewise.
5778 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5779 * w32gui.h (Time): Define by including "systime.h" rather than by
5780 declaring it ourselves. (Bug#8664)
5782 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5783 * image.c (clear_image_cache): Likewise.
5785 * term.c (term_mouse_position): Don't assume time_t wraparound.
5787 Be more systematic about user-interface timestamps.
5788 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5789 and sometimes 'EMACS_UINT', to represent these timestamps.
5790 This change causes it to use 'Time' uniformly, as that's what X uses.
5791 This makes the code easier to follow, and makes it easier to catch
5792 integer overflow bugs such as Bug#8664.
5793 * frame.c (Fmouse_position, Fmouse_pixel_position):
5794 Use Time, not unsigned long, for user-interface timestamps.
5795 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5796 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5797 * keyboard.h (last_event_timestamp): Likewise.
5798 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5799 * menu.h (xmenu_show): Likewise.
5800 * term.c (term_mouse_position): Likewise.
5801 * termhooks.h (struct input_event.timestamp): Likewise.
5802 (struct terminal.mouse_position_hook): Likewise.
5803 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5804 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5805 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5806 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5808 * menu.h, termhooks.h: Include "systime.h", for Time.
5810 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5811 Don't assume that the difference between two unsigned long values
5812 can fit into an integer. At this point, we know button_down_time
5813 <= event->timestamp, so the difference must be nonnegative, so
5814 there's no need to cast the result if double-click-time is
5815 nonnegative, as it should be; check that it's nonnegative, just in
5816 case. This bug is triggered when events are more than 2**31 ms
5817 apart (about 25 days). (Bug#8664)
5819 * xselect.c (last_event_timestamp): Remove duplicate decl.
5820 (x_own_selection): Remove needless cast to unsigned long.
5822 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5823 that always fit in int. Use a sentinel instead of a counter, to
5824 avoid a temp and to allay GCC's concerns about possible int overflow.
5825 * frame.h (struct frame): Use int for menu_bar_items_used
5826 instead of EMACS_INT, since it always fits in int.
5828 * menu.c (grow_menu_items): Check for int overflow.
5830 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5832 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5833 Before, the code was not consistent. These values cannot exceed
5834 2**31 - 1 so there's no need to make them unsigned.
5835 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5836 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5837 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5839 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5841 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5842 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5843 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5844 presumably because the widths might not match.
5846 * window.c (size_window): Avoid needless test at loop start.
5848 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5850 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5852 2011-05-12 Drew Adams <drew.adams@oracle.com>
5854 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5856 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5858 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5859 `width' to `bar_area_x' and `bar_area_width', respectively.
5860 (x_scroll_run): Take account of fringe background extension.
5862 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5863 Rename local vars `left' and `width' to `bar_area_x' and
5864 `bar_area_width', respectively.
5865 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5866 background extension.
5868 2011-05-10 Jim Meyering <meyering@redhat.com>
5870 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5872 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5874 * image.c (Finit_image_library): Return t for built-in image types,
5875 like pbm and xbm. (Bug#8640)
5877 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5879 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5881 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5883 * w32console.c (Fset_screen_color): Doc fix.
5884 (Fget_screen_color): New function.
5885 (syms_of_ntterm): Defsubr it.
5887 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5888 unlink the temporary file if Fcall_process didn't create it in the
5890 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5891 child process will be redirected to a file specified with `:file'.
5892 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5893 cue to call_process_cleanup not to close that handle.
5895 2011-05-07 Ben Key <bkey76@gmail.com>
5897 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5898 one of two shell specific rules, either bootstrap-temacs-CMD or
5899 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5900 to the previous implementation of the bootstrap-temacs rule.
5901 The bootstrap-temacs-CMD rule is similar to the previous
5902 implementation of the bootstrap-temacs rule except that it
5903 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5906 These changes, along with some changes to nt/configure.bat,
5907 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5908 earlier fix to add support for --cflags and --ldflags options
5909 that include quotes so that it works whether make uses cmd or
5912 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5914 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5915 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5917 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5918 a string. Handle both cases.
5919 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5920 (Fdbus_register_method): Use Qinvalid_function.
5922 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5924 * makefile.w32-in: Update dependencies.
5925 (LISP_H): Add inttypes.h and stdin.h.
5926 (PROCESS_H): Add unistd.h.
5928 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5930 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5931 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5933 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5935 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5937 * term.c (vfatal): Remove stray call to va_end.
5938 It's not needed and the C Standard doesn't allow it here anyway.
5940 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5941 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5943 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5946 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5948 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5950 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5952 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5954 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5956 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5957 * charset.c (Fdefine_charset_internal): Don't initialize
5958 charset.code_space[15]. The value was garbage, on hosts with
5959 32-bit int (Bug#8600).
5961 * lread.c (read_integer): Be more consistent with string-to-number.
5962 Use string_to_number to do the actual conversion; this avoids
5963 rounding errors and fixes some other screwups. Without this fix,
5964 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5965 (digit_to_number): Move earlier, for benefit of read_integer.
5966 Return -1 if the digit is out of range for the base, -2 if it is
5967 not a digit in any supported base. (Bug#8602)
5969 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5971 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5972 to match comment at start of function. This also removes a
5973 GCC warning about overflow in a 32+64-bit port.
5975 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5977 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5978 Reported by Stefan Monnier in
5979 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5980 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5981 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5983 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5984 (EMACS_UINTPTR): Likewise, with uintptr_t.
5986 * lisp.h: Prefer 64-bit EMACS_INT if available.
5987 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5988 on 32-bit hosts that have 64-bit int, so that they can access
5990 However, temporarily disable this change unless the temporary
5991 symbol WIDE_EMACS_INT is defined.
5993 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5995 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5996 This removes an assumption that EMACS_INT and long are the same
5997 width as pointers. The assumption is true for Emacs porting targets
5998 now, but we want to make other targets possible.
5999 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6000 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6001 In the rest of the code, change types of integers that hold casted
6002 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6003 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6004 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6005 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6006 No need to cast type when ORing.
6007 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6008 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6009 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6010 assume EMACS_INT is the same width as char *.
6011 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6012 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6013 Remove no-longer-needed casts.
6014 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6015 (xg_tool_bar_help_callback, xg_make_tool_item):
6016 Use EMACS_INTPTR to hold an integer
6017 that will be cast to void *; this can avoid a GCC warning
6018 if EMACS_INT is not the same width as void *.
6019 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6020 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6021 (current_message_1, set_message_1):
6022 Use a local to convert to proper width without a cast.
6023 * xmenu.c (dialog_selection_callback): Likewise.
6025 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6026 Also, don't assume VALBITS / RAND_BITS is less than 5,
6027 and don't rely on undefined behavior when shifting a 1 left into
6029 * lisp.h (get_random): Change signature to match.
6031 * lread.c (hash_string): Use size_t, not int, for hash computation.
6032 Normally we prefer signed values; but hashing is special, because
6033 it's better to use unsigned division on hash table sizes so that
6034 the remainder is nonnegative. Also, size_t is the natural width
6035 for hashing into memory. The previous code used 'int', which doesn't
6036 retain enough info to hash well into very large tables.
6037 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6039 * dbusbind.c: Don't possibly lose pointer info when converting.
6040 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6041 Use XPNTR rather than XHASH, so that the high-order bits of
6042 the pointer aren't lost when converting through void *.
6044 * eval.c (Fautoload): Don't double-shift a pointer.
6046 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6048 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6050 * gnutls.c (DEF_GNUTLS_FN):
6051 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6053 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6055 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6058 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6060 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6061 New version that can reserve upto 2GB of heap space.
6063 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6065 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6067 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6069 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6070 `gnutls_certificate_set_x509_key_file'.
6072 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6074 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6075 Update dependencies.
6077 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6079 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6080 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6081 Remove unused parameter `fildes'.
6082 * process.c (read_process_output, send_process): Don't pass it.
6084 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6086 Fix previous change: the library cache is defined in w32.c.
6087 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6088 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6090 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6092 Implement dynamic loading of GnuTLS on Windows.
6094 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6095 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6096 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6099 * gnutls.c (Qgnutls_dll): Define.
6100 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6101 (gnutls_*): Declare function pointers.
6102 (init_gnutls_functions): New function to initialize function pointers.
6103 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6104 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6105 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6106 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6107 (emacs_gnutls_write, emacs_gnutls_read)
6108 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6109 (Fgnutls_available_p): New function.
6110 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6111 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6112 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6114 * image.c: Include w32.h.
6115 (Vimage_type_cache): Delete.
6116 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6117 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6118 (w32_delayed_load): Move to w32.c.
6120 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6122 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6123 (w32_delayed_load): Move from image.c. When loading a library, record
6124 its filename in the :loaded-from property of the library id.
6125 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6126 Initialize and staticpro them.
6127 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6129 * process.c: Include lisp.h before w32.h, not after.
6130 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6131 instead of gnutls_record_check_pending.
6133 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6135 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6137 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6138 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6141 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6143 * xterm.c (x_set_frame_alpha): Do not set property on anything
6144 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6146 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6148 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6150 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6152 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6153 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6154 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6155 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6156 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6157 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6158 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6159 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6160 (Qgnutls_bootprop_callbacks_verify): Make static.
6162 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6164 * callproc.c: Indentation fixup.
6166 * sysdep.c (wait_for_termination_1): Make static.
6167 (wait_for_termination, interruptible_wait_for_termination):
6168 Move after wait_for_termination_1.
6170 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6172 * sysdep.c (interruptible_wait_for_termination): New function
6173 which is like wait_for_termination, but allows keyboard
6176 * callproc.c (Fcall_process): Add (:file "file") as an option for
6178 (Fcall_process_region): Ditto.
6180 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6182 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6183 rather than `XVECTOR (FOO)->size'.
6185 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6186 inttypes.h, as a gnulib replacement is used if it not available in
6189 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6191 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6192 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6193 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6195 * coding.c (coding_alloc_by_realloc): Error out if destination
6196 will grow beyond MOST_POSITIVE_FIXNUM.
6197 (decode_coding_emacs_mule): Abort if there isn't enough place in
6198 charbuf for the composition carryover bytes. Reserve an extra
6199 space for up to 2 characters produced in a loop.
6200 (decode_coding_iso_2022): Abort if there isn't enough place in
6201 charbuf for the composition carryover bytes.
6203 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6205 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6206 aborting when %lld or %lll format is passed.
6207 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6208 %llo or %llx format is passed. (Bug#8545)
6210 * window.c (window_scroll_line_based): Use a marker instead of
6211 simple variables to record original value of point. (Bug#7952)
6213 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6214 produced by %s or %c overflows available buffer space. (Bug#8545)
6216 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6218 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6219 (SIZE_MAX): Move defn after all includes, as they might #define it.
6221 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6223 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6225 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6227 * keyboard.c (Qdelayed_warnings_hook): Define.
6228 (command_loop_1): Run `delayed-warnings-hook'
6229 if Vdelayed_warnings_list is non-nil.
6230 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6231 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6233 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6235 * doprnt.c (doprnt): Don't return value smaller than the buffer
6236 size if the message was truncated. (Bug#8545).
6238 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6240 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6241 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6243 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6245 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6247 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6249 * makefile.w32-in: Update dependencies.
6251 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6253 Improve `doprnt' and its usage. (Bug#8545)
6254 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6255 `format_end'. Remove support for %l as a conversion specifier.
6256 Don't use xrealloc. Improve diagnostics when the %l size modifier
6257 is used. Update the commentary.
6259 * eval.c (verror): Simplify calculation of size_t.
6261 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6264 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6266 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6269 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6271 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6272 This makes this file independent of the recent pseudovector change.
6274 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6276 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6278 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6279 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6280 Remove unused local.
6281 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6283 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6284 GCC 4.6.0 optimizes based on type-based alias analysis.
6285 For example, if b is of type struct buffer * and v of type struct
6286 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6287 != &v->size, and therefore "v->size = 1; b->size = 2; return
6288 v->size;" must therefore return 1. This assumption is incorrect
6289 for Emacs, since it type-puns struct Lisp_Vector * with many other
6290 types. To fix this problem, this patch adds a new type struct
6291 vectorlike_header that documents the constraints on layout of vectors
6292 and pseudovectors, and helps optimizing compilers not get fooled
6293 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6294 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6295 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6297 (XSETPVECTYPE): Rewrite in terms of new macro.
6298 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6299 This is a bit clearer, and further avoids the possibility of
6300 undesirable aliasing.
6301 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6302 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6303 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6304 since Lisp_Subr is a special case (no "next" field).
6305 (ASIZE): Now uses header.size rather than size.
6306 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6307 to avoid the hassle of writing XVECTOR (foo)->header.size.
6308 (struct vectorlike_header): New type.
6309 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6310 object, to help avoid aliasing.
6311 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6312 (SUBRP): Likewise, since Lisp_Subr is a special case.
6313 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6314 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6315 (struct Lisp_Hash_Table): Combine first two members into a single
6316 struct vectorlike_header member. All uses of "size" and "next" members
6317 changed to be "header.size" and "header.next".
6318 * buffer.h (struct buffer): Likewise.
6319 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6320 * frame.h (struct frame): Likewise.
6321 * process.h (struct Lisp_Process): Likewise.
6322 * termhooks.h (struct terminal): Likewise.
6323 * window.c (struct save_window_data, struct saved_window): Likewise.
6324 * window.h (struct window): Likewise.
6325 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6326 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6327 * buffer.c (init_buffer_once): Likewise.
6328 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6330 * process.c (Fformat_network_address): Use local var for size,
6333 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6335 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6336 * data.c (atof): Remove decl; no longer used or needed.
6337 (digit_to_number): Move to lread.c.
6338 (Fstring_to_number): Use new string_to_number function, to be
6339 consistent with how the Lisp reader treats infinities and NaNs.
6340 Do not assume that floating-point numbers represent EMACS_INT
6341 without losing information; this is not true on most 64-bit hosts.
6342 Avoid double-rounding errors, by insisting on integers when
6343 parsing non-base-10 numbers, as the documentation specifies.
6344 * lisp.h (string_to_number): New decl, replacing ...
6345 (isfloat_string): Remove.
6346 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6347 (read1): Do not accept +. and -. as integers; this
6348 appears to have been a coding error. Similarly, do not accept
6349 strings like +-1e0 as floating point numbers. Do not report
6350 overflow for integer overflows unless the base is not 10 which
6351 means we have no simple and reliable way to continue.
6352 Break out the floating-point parsing into a new
6353 function string_to_number, so that Fstring_to_number parses
6354 floating point numbers consistently with the Lisp reader.
6355 (digit_to_number): Move here from data.c. Make it static inline.
6356 (E_CHAR, EXP_INT): Remove, replacing with ...
6357 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6358 (string_to_number): New function, replacing isfloat_string.
6359 This function checks for valid syntax and produces the resulting
6360 Lisp float number too. Rework it so that string-to-number
6361 no longer mishandles examples like "1.0e+". Use strtoumax,
6362 so that overflow for non-base-10 numbers is reported only when
6363 there's no portable and simple way to convert to floating point.
6365 * textprop.c (set_text_properties_1): Rewrite for clarity,
6366 and to avoid GCC warning about integer overflow.
6368 * intervals.h (struct interval): Use EMACS_INT for members
6369 where EMACS_UINT might cause problems. See
6370 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6371 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6372 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6374 (offset_intervals): Tell GCC not to worry about length overflow
6375 when negating a negative length.
6377 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6378 (overrun_check_free): Likewise.
6380 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6381 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6384 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6385 (gnutls_make_error): Rename local to avoid shadowing.
6386 (gnutls_emacs_global_deinit): ifdef out; not used.
6387 (Fgnutls_boot): Use const for pointer to readonly storage.
6388 Comment out unused local. Fix pointer signedness problems.
6390 * lread.c (openp): Don't stuff size_t into an 'int'.
6391 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6392 about possible signed overflow.
6394 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6395 (GDK_KEY_g): Don't define if already defined.
6396 (xg_prepare_tooltip): Avoid pointer signedness problem.
6397 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6399 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6400 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6402 * xfns.c (Fx_window_property): Simplify a bit,
6403 to make a bit faster and to avoid GCC 4.6.0 warning.
6404 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6406 * fns.c (internal_equal): Don't assume size_t fits in int.
6408 * alloc.c (compact_small_strings): Tighten assertion a little.
6410 Replace pEd with more-general pI, and fix some printf arg casts.
6411 * lisp.h (pI): New macro, generalizing old pEd macro to other
6412 conversion specifiers. For example, use "...%"pI"d..." rather
6413 than "...%"pEd"...".
6414 (pEd): Remove. All uses replaced with similar uses of pI.
6415 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6416 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6417 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6418 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6419 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6420 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6421 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6423 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6424 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6425 * print.c (safe_debug_print, print_object): Likewise.
6426 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6428 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6429 avoiding the 0 flag, which is not portable.
6430 * process.c (Fmake_network_process): Use pI to avoid cast.
6431 * region-cache.c (pp_cache): Likewise.
6432 * xdisp.c (decode_mode_spec): Likewise.
6433 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6434 behavior on 64-bit hosts with printf arg.
6435 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6436 (x_stop_queuing_selection_requests): Likewise.
6437 (x_get_window_property): Don't truncate byte count to an 'int'
6440 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6441 here, since it parses constructs like leading '-' and spaces,
6442 which are not wanted; and it overflows with large numbers.
6443 Instead, simply match F[0-9]+, which is what is wanted anyway.
6445 * alloc.c: Remove unportable assumptions about struct layout.
6446 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6447 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6448 (allocate_vectorlike, make_pure_vector): Use the new macros,
6449 plus offsetof, to remove unportable assumptions about struct layout.
6450 These assumptions hold on all porting targets that I know of, but
6451 they are not guaranteed, they're easy to remove, and removing them
6452 makes further changes easier.
6454 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6455 This doesn't fix a bug but makes the code clearer.
6456 (string_overrun_cookie): Now const. Use initializers that
6457 don't formally overflow signed char, to avoid warnings.
6458 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6459 can cause Emacs to crash when string overrun checking is enabled.
6460 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6461 multiple of sizeof (EMACS_INT); it need not be, if
6462 alignof(EMACS_INT) < sizeof (EMACS_INT).
6463 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6465 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6467 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6469 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6471 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6472 supposed to be handshaking. (Bug#8556)
6473 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6475 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6477 * lisp.h (Qdebug): List symbol.
6478 * eval.c (Qdebug): Restore global linkage.
6479 * keyboard.c (debug-on-event): New variable.
6480 (handle_user_signal): Break into debugger when debug-on-event
6481 matches the current signal symbol.
6483 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6485 * alloc.c (check_sblock, check_string_bytes)
6486 (check_string_free_list): Convert to standard C.
6488 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6490 * w32.c (emacs_gnutls_push): Fix typo.
6492 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6494 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6495 "cast to pointer from integer of different size".
6497 Improve doprnt and its use in verror. (Bug#8545)
6498 * doprnt.c (doprnt): Document the set of format control sequences
6499 supported by the function. Use SAFE_ALLOCA instead of always
6502 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6503 is one byte too soon. Don't use xrealloc; instead xfree and
6506 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6508 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6511 * gnutls.c: Renamed global_initialized to
6512 gnutls_global_initialized. Added internals for the
6513 :verify-hostname-error, :verify-error, and :verify-flags
6514 parameters of `gnutls-boot' and documented those parameters in the
6515 docstring. Start callback support.
6516 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6517 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6518 on error. Return error code.
6519 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6520 (emacs_gnutls_read): Likewise.
6521 (Fgnutls_boot): Return handshake error code.
6522 (emacs_gnutls_handle_error): New function.
6523 (wsaerror_to_errno): Likewise.
6525 * w32.h (emacs_gnutls_pull): Add prototype.
6526 (emacs_gnutls_push): Likewise.
6528 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6529 (emacs_gnutls_push): Likewise.
6531 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6533 * process.c (wait_reading_process_output): Check if GnuTLS
6534 buffered some data internally if no FDs are set for TLS
6537 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6538 (LIBS): Link to USER_LIBS.
6539 ($(BLD)/gnutls.$(0)): New target.
6541 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6543 * xdisp.c (handle_single_display_spec): Rename the
6544 display_replaced_before_p argument into display_replaced_p, to
6545 make it consistent with the commentary. Fix typos in the
6548 * textprop.c (syms_of_textprop): Remove dead code.
6549 (copy_text_properties): Delete obsolete commentary about an
6550 interface that was deleted long ago. Fix typos in the description
6553 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6554 to changes in oldXMenu/XMenu.h from 2011-04-16.
6555 <menu_help_message, prev_menu_help_message>: Constify.
6556 (IT_menu_make_room): menu->help_text is now `const char **';
6559 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6560 to changes in oldXMenu/XMenu.h from 2011-04-16.
6561 (struct XMenu): Declare `help_text' `const char **'.
6563 * xfaces.c <Qunspecified>: Make extern again.
6565 * syntax.c: Include sys/types.h before including regex.h, as
6568 * doc.c (get_doc_string): Improve the format passed to `error'.
6570 * doprnt.c (doprnt): Improve commentary.
6572 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6574 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6577 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6578 changes in globals.h immediately force recompilation.
6579 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6580 $(CURDIR)/s/ms-w32.h.
6581 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6583 * character.c (Fchar_direction): Function deleted.
6584 (syms_of_character): Don't defsubr it.
6585 <char-direction-table>: Deleted.
6587 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6589 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6590 * doprnt.c: Include limits.h.
6591 (SIZE_MAX): New macro.
6592 (doprnt): Return a size_t value. 2nd arg is now size_t.
6593 Many local variables are now size_t instead of int or unsigned.
6594 Improve overflow protection. Support `l' modifier for integer
6595 conversions. Support %l conversion. Don't assume an EMACS_INT
6596 argument for integer conversions and for %c.
6598 * lisp.h (doprnt): Restore prototype.
6600 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6603 * Makefile.in (base_obj): Add back doprnt.o.
6605 * deps.mk (doprnt.o): Add back prerequisites.
6606 (callint.o): Depend on character.h.
6608 * eval.c (internal_lisp_condition_case): Include the handler
6609 representation in the error message.
6610 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6611 when breaking from the loop.
6613 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6615 * callint.c (Fcall_interactively): When displaying error message
6616 about invalid control letter, pass the character's codepoint, not
6617 a pointer to its multibyte form. Improve display of the character
6618 in octal and display also its hex code.
6620 * character.c (char_string): Use %x to display the (unsigned)
6621 codepoint of an invalid character, to avoid displaying a bogus
6624 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6625 `error', not SYMBOL_NAME itself.
6627 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6628 character arguments to `error'.
6630 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6631 to `error' in error message about FINAL_CHAR argument. Make sure
6632 FINAL_CHAR is a character, and use %c when it is passed as
6633 argument to `error'.
6635 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6637 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6639 * w32.c: Include <time.h>.
6640 (sys_localtime): New function.
6642 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6644 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6646 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6648 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6650 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6653 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6655 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6656 gl_state.e_property when gl_state.object is Qt.
6658 * insdel.c (make_gap_larger): Remove limitation of buffer size
6661 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6663 * xdisp.c (lookup_glyphless_char_display)
6664 (produce_glyphless_glyph): Handle cons cell entry in
6665 glyphless-char-display.
6666 (Vglyphless_char_display): Document it.
6668 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6669 glyphless-char-display.
6671 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6673 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6675 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6677 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6678 definition for no-X builds.
6680 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6682 Static checks with GCC 4.6.0 and non-default toolkits.
6684 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6686 * process.c (keyboard_bit_set): Define only if SIGIO.
6687 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6688 (send_process): Repair possible setjmp clobbering.
6690 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6692 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6694 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6696 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6697 Define only if needed.
6699 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6700 by pacifying GCC about it. Maybe it's time to retire it?
6701 * xfaces.c (USG, __TIMEVAL__): Likewise.
6703 * dispextern.h (struct redisplay_interface): Rename param
6705 * termhooks.h (struct terminal): Likewise.
6706 * xterm.c (xembed_send_message): Likewise.
6708 * insdel.c (make_gap_smaller): Define only if
6709 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6711 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6714 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6715 so that we aren't warned about unused symbols.
6717 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6719 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6721 * xfns.c (x_real_positions): Mark locals as initialized.
6723 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6725 * xterm.c: Fix problems found by static analysis with other toolkits.
6726 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6727 (x_dispatch_event): Declare static if USE_GTK, and
6728 define if USE_GTK || USE_X_TOOLKIT.
6729 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6730 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6731 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6732 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6734 * xmenu.c (menu_help_callback): Pointer type fixes.
6735 Use const pointers when pointing at readonly data. Avoid pointer
6737 (FALSE): Remove unused macro.
6738 (update_frame_menubar): Remove unused decl.
6740 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6742 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6743 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6744 (single_menu_item): Rename local to avoid shadowing.
6746 * keyboard.c (make_lispy_event): Remove unused local var.
6748 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6749 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6751 * bitmaps: Change bitmaps from unsigned char back to the X11
6752 compatible char. Avoid the old compiler warnings about
6753 out-of-range initializers by using, for example, '\xab' rather
6756 * xgselect.c (xgselect_initialize): Check vs interface
6757 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6759 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6761 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6762 to read-only memory.
6764 * fns.c (vector): Remove; this old hack is no longer needed.
6766 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6768 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6770 * xrdb.c (x_load_resources): Omit unused local.
6772 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6773 (x_window): Rename locals to avoid shadowing.
6774 (USG): Use the kludged USG macro, to pacify gcc.
6776 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6777 (x_term_init): Remove local to avoid shadowing.
6779 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6781 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6782 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6784 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6786 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6788 Fix regex.c, syntax.c and friends for buffers > 2GB.
6789 * syntax.h (struct gl_state_s): Declare character position members
6792 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6794 * textprop.c (verify_interval_modification, interval_of):
6795 Declare arguments EMACS_INT.
6797 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6800 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6802 * indent.c (Fvertical_motion): Local variable it_start is now
6805 * regex.c (re_match, re_match_2, re_match_2_internal)
6806 (bcmp_translate, regcomp, regexec, print_double_string)
6807 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6808 (re_compile_pattern, re_exec): Declare arguments and local
6809 variables `size_t' and `ssize_t' and return values `regoff_t', as
6811 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6812 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6813 <compile_stack_type>: `size' and `avail' are now `size_t'.
6815 * regex.h <regoff_t>: Use ssize_t, not int.
6816 (re_search, re_search_2, re_match, re_match_2): Arguments that
6817 specify buffer/string position and length are now ssize_t and
6818 size_t. Return type is regoff_t.
6820 2011-04-16 Ben Key <bkey76@gmail.com>
6822 * nsfont.m: Fixed bugs in ns_get_family and
6823 ns_descriptor_to_entity that were caused by using free to
6824 deallocate memory blocks that were allocated by xmalloc (via
6825 xstrdup). This caused Emacs to crash when compiled with
6826 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6827 --enable-checking=xmallocoverrun). xfree is now used to
6828 deallocate these memory blocks.
6830 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6832 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6834 emacs_write: Accept and return EMACS_INT for sizes.
6835 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6837 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6838 Accept and return EMACS_INT.
6839 (emacs_gnutls_write): Return the number of bytes written on
6841 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6842 (emacs_read, emacs_write): Remove check for negative size, as the
6843 Emacs source code has been audited now.
6844 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6845 (emacs_read, emacs_write): Use it.
6846 * process.c (send_process): Adjust to the new signatures of
6847 emacs_write and emacs_gnutls_write. Do not attempt to store
6848 a byte offset into an 'int'; it might overflow.
6849 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6851 * sound.c: Don't assume sizes fit in 'int'.
6852 (struct sound_device.period_size, alsa_period_size):
6853 Return EMACS_INT, not int.
6854 (struct sound_device.write, vox_write, alsa_write):
6855 Accept EMACS_INT, not int.
6856 (wav_play, au_play): Use EMACS_INT to store sizes and to
6857 record read return values.
6859 2011-04-15 Ben Key <bkey76@gmail.com>
6861 * keyboard.c (Qundefined): Don't declare static since it is used
6863 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6864 static since they are used in nsfont.m.
6866 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6868 * process.c (Qprocessp): Don't declare static.
6869 * lisp.h (Qprocessp): Declare again.
6871 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6873 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6875 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6877 Improve C-level modularity by making more things 'static'.
6879 Don't publish debugger-only interfaces to other modules.
6880 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6881 (verify_bytepos, count_markers): Move decls to the only modules
6883 * region-cache.h (pp_cache): Likewise.
6884 * window.h (check_all_windows): Likewise.
6885 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6887 * sysdep.c (croak): Now static, if
6888 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6889 * syssignal.h (croak): Declare only if not static.
6891 * alloc.c (refill_memory_reserve): Now static if
6892 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6893 * lisp.h (refill_memory_reserve): Declare only if not static.
6895 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6896 Define only if USE_LUCID.
6898 * xrdb.c (x_customization_string, x_rm_string): Now static.
6900 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6901 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6903 * xdisp.c (draw_row_with_mouse_face): Now static.
6904 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6906 * window.h (check_all_windows): Mark externally visible.
6908 * window.c (window_deletion_count): Now static.
6910 * undo.c: Make symbols static if they're not exported.
6911 (last_undo_buffer, last_boundary_position, pending_boundary):
6914 * textprop.c (interval_insert_behind_hooks): Now static.
6915 (interval_insert_in_front_hooks): Likewise.
6917 * term.c: Make symbols static if they're not exported.
6918 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6919 (max_frame_lines, tty_set_terminal_modes):
6920 (tty_reset_terminal_modes, tty_turn_off_highlight):
6921 (get_tty_terminal): Now static.
6922 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6923 * termhooks.h (term_mouse_moveto): Do not declare if
6925 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6926 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6928 * sysdep.c: Make symbols static if they're not exported.
6929 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6931 (sigprocmask_set, full_mask): Remove; unused.
6932 (wait_debugging): Mark as visible.
6933 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6934 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6936 * syntax.c (syntax_temp): Define only if !__GNUC__.
6938 * sound.c (current_sound_device, current_sound): Now static.
6940 * search.c (searchbufs, searchbuf_head): Now static.
6942 * scroll.c (scroll_cost): Remove; unused.
6943 * dispextern.h (scroll_cost): Remove decl.
6945 * region-cache.h (pp_cache): Mark as externally visible.
6947 * process.c: Make symbols static if they're not exported.
6948 (process_tick, update_tick, create_process, chan_process):
6949 (Vprocess_alist, proc_buffered_char, datagram_access):
6950 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6951 (deactivate_process): Mark defn as static, as well as decl.
6952 * lisp.h (create_process): Remove decl.
6953 * process.h (chan_process, Vprocess_alist): Remove decls.
6955 * print.c: Make symbols static if they're not exported.
6956 (print_depth, new_backquote_output, being_printed, print_buffer):
6957 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6958 (print_interval, print_number_index, initial_stderr_stream):
6960 * lisp.h (Fprinc): Remove decl.
6961 (debug_output_compilation_hack): Mark as externally visible.
6963 * sysdep.c (croak): Move decl from here to syssignal.h.
6964 * syssignal.h (croak): Put it here, so the API can be checked when
6965 'croak' is called from dissociate_if_controlling_tty.
6967 * minibuf.c: Make symbols static if they're not exported.
6968 (minibuf_save_list, choose_minibuf_frame): Now static.
6969 * lisp.h (choose_minibuf_frame): Remove decl.
6971 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6973 * lread.c: Make symbols static if they're not exported.
6974 (read_objects, initial_obarray, oblookup_last_bucket_number):
6976 (make_symbol): Remove; unused.
6977 * lisp.h (initial_obarray, make_symbol): Remove decls.
6979 * keyboard.c: Make symbols static if they're not exported.
6980 (single_kboard, recent_keys_index, total_keys, recent_keys):
6981 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6982 (this_single_command_key_start, echoing, last_auto_save):
6983 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6984 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6985 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6986 (Vlispy_mouse_stem, double_click_count):
6988 (force_auto_save_soon): Define only if SIGDANGER.
6989 (ignore_mouse_drag_p): Now static if
6990 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6991 (print_help): Remove; unused.
6992 (stop_character, last_timer_event): Mark as externally visible.
6993 * keyboard.h (ignore_mouse_drag_p): Declare only if
6994 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6995 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6996 * lisp.h (echoing): Remove decl.
6997 (force_auto_save_soon): Declare only if SIGDANGER.
6998 * xdisp.c (redisplay_window): Simplify code, to make it more
6999 obvious that ignore_mouse_drag_p is not accessed if !defined
7000 USE_GTK && !defined HAVE_NS.
7002 * intervals.c: Make symbols static if they're not exported.
7003 (merge_properties_sticky, merge_interval_right, delete_interval):
7005 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7007 * insdel.c: Make symbols static if they're not exported.
7008 However, leave prepare_to_modify_buffer alone. It's never
7009 called from outside this function, but that appears to be a bug.
7010 (combine_after_change_list, combine_after_change_buffer):
7011 (adjust_after_replace, signal_before_change): Now static.
7012 (adjust_after_replace_noundo): Remove; unused.
7013 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7014 (signal_before_change): Remove decls.
7016 * indent.c (val_compute_motion, val_vmotion): Now static.
7018 * image.c: Make symbols static if they're not exported.
7019 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7021 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7022 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7024 * fringe.c (standard_bitmaps): Now static.
7025 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7027 * frame.c: Make symbols static if they're not exported.
7028 (x_report_frame_params, make_terminal_frame): Now static.
7029 (get_frame_param): Now static, unless HAVE_NS.
7030 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7031 (x_get_resource_string): Remove; not used.
7032 * frame.h (make_terminal_frame, x_report_frame_params):
7033 (x_get_resource_string); Remove decls.
7034 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7035 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7037 * font.c, fontset.c: Make symbols static if they're not exported.
7038 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7039 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7040 * font.c (font_close_object): Now static.
7041 * font.h (font_close_object): Remove.
7042 * fontset.c (FONTSET_OBJLIST): Remove.
7043 (free_realized_fontset) #if-0 the body, which does nothing.
7044 (face_suitable_for_char_p): #if-0, as it's never called.
7045 * fontset.h (face_suitable_for_char_p): Remove decl.
7046 * xfaces.c (face_at_string_position):
7047 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7048 since 0 is always ASCII.
7050 * fns.c (weak_hash_tables): Now static.
7052 * fileio.c: Make symbols static if they're not exported.
7053 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7054 (Vwrite_region_annotation_buffers): Now static.
7056 * eval.c: Make symbols static if they're not exported.
7057 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7058 * lisp.h (backtrace_list): Remove decl.
7060 * emacs.c: Make symbols static if they're not exported.
7061 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7062 (fatal_error_code, fatal_error_signal_hook, standard_args):
7064 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7065 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7066 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7067 * lisp.h (fatal_error_signal_hook): Remove decl.
7068 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7070 * editfns.c: Move a (normally-unused) function to its only use.
7071 * editfns.c, lisp.h (get_operating_system_release): Remove.
7072 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7073 worth the hassle of breaking this out.
7075 * xterm.c: Make symbols static if they're not exported.
7076 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7077 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7078 (x_destroy_window, x_delete_display):
7080 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7081 (x_mouse_leave): Remove; unused.
7082 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7083 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7084 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7086 (x_mouse_leave): Declare only if WINDOWSNT.
7087 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7088 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7091 * ftxfont.c: Make symbols static if they're not exported.
7092 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7094 * font.h (ftxfont_driver): Likewise.
7096 * xfns.c: Make symbols static if they're not exported.
7097 (x_last_font_name, x_display_info_for_name):
7098 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7099 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7100 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7101 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7102 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7103 (last_show_tip_args): Now static.
7104 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7105 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7106 (x_screen_planes): Remove; unused.
7107 * dispextern.h (x_screen_planes): Remove decl.
7109 * dispnew.c: Make symbols static if they're not exported.
7110 * dispextern.h (redraw_garbaged_frames, scrolling):
7111 (increment_row_positions): Remove.
7112 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7113 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7115 (redraw_garbaged_frames): Remove; unused.
7117 * xfaces.c: Make symbols static if they're not exported.
7118 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7120 * xterm.h (defined_color): Remove decls.
7121 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7122 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7123 (menu_face_changed_default, defined_color, free_realized_face):
7124 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7125 (ascii_face_of_lisp_face): Remove; unused.
7127 * xdisp.c: Make symbols static if they're not exported.
7128 * dispextern.h (scratch_glyph_row, window_box_edges):
7129 (glyph_to_pixel_coords, set_cursor_from_row):
7130 (get_next_display_element, set_iterator_to_next):
7131 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7132 (show_mouse_face): Remove decls
7133 * frame.h (message_buf_print): Likewise.
7134 * lisp.h (pop_message, set_message, check_point_in_composition):
7136 * xterm.h (set_vertical_scroll_bar): Likewise.
7137 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7138 (message_buf_print, scratch_glyph_row, displayed_buffer):
7139 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7140 (get_next_display_element, show_mouse_face, window_box_edges):
7141 (frame_to_window_pixel_xy, check_point_in_composition):
7142 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7143 (glyph_to_pixel_coords): Remove; unused.
7145 * dired.c (file_name_completion): Now static.
7147 * dbusbind.c (xd_in_read_queued_messages): Now static.
7149 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7150 * data.c (circular_list_error): Remove.
7152 * commands.h (last_point_position, last_point_position_buffer):
7153 (last_point_position_window): Remove decls.
7154 * keyboard.c: Make these variables static.
7156 * coding.h (coding, code_convert_region, encode_coding_gap):
7158 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7159 (iso_code_class, detect_coding, code_convert_region): Now static.
7160 (encode_coding_gap): Remove; unused.
7162 * chartab.c (chartab_chars, chartab_bits): Now static.
7164 * charset.h (charset_iso_8859_1): Remove decl.
7165 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7168 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7169 * ccl.c (Vccl_program_table): Now static.
7170 (check_ccl_update): Remove; unused.
7172 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7173 * category.h: ... from here.
7174 * category.c (check_category_table, set_category_set): Now static.
7176 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7177 * lisp.h: Remove these decls.
7179 * buffer.c (buffer_count): Remove unused var.
7181 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7182 so that it's not optimized away.
7183 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7184 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7185 exported only to the debugger.
7187 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7188 * atimer.h (run_all_atimers): Remove; not exported.
7190 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7191 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7192 was inaccessible from Lisp.
7193 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7194 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7196 alloc.c: Import and export fewer symbols, and remove unused items.
7197 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7199 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7200 it's not optimized away by whole-program optimization.
7201 (message_enable_multibyte, free_misc): Remove.
7202 (catchlist, handlerlist, mark_backtrace):
7203 Declare only if BYTE_MARK_STACK.
7204 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7205 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7206 (message_enable_multibyte): Remove decl.
7207 (free_misc, interval_free_list, float_block, float_block_index):
7208 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7209 (cons_free_list, last_marked_index):
7211 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7212 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7213 (mark_backtrace): Define only if BYTE_MARK_STACK.
7214 * xdisp.c (message_enable_multibyte): Now static.
7216 Declare Lisp_Object Q* variables to be 'static' if not exported.
7217 This makes it easier for human readers (and static analyzers)
7218 to see whether these variables are used from other modules.
7219 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7220 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7221 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7222 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7223 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7224 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7225 * xmenu.c, xselect.c:
7226 Declare Q* vars static if they are not used in other modules.
7227 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7228 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7229 Remove decls of unexported vars.
7230 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7232 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7234 Make Emacs functions such as Fatom 'static' by default.
7235 This makes it easier for human readers (and static analyzers)
7236 to see whether these functions can be called from other modules.
7237 DEFUN now defines a static function. To make the function external
7238 so that it can be used in other C modules, use the new macro DEFUE.
7239 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7240 (Finit_image_library):
7241 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7242 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7243 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7244 Remove decls, since these functions are now static.
7245 (Funintern, Fget_internal_run_time): New decls, since these functions
7246 were already external.
7248 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7249 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7250 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7251 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7252 * keyboard.c, keymap.c, lread.c:
7253 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7254 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7255 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7256 Mark functions with DEFUE instead of DEFUN,
7257 if they are used in other modules.
7258 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7259 decls for now-static functions.
7260 * buffer.h (Fdelete_overlay): Remove decl.
7261 * callproc.c (Fgetenv_internal): Mark as internal.
7262 * composite.c (Fremove_list_of_text_properties): Remove decl.
7263 (Fcomposition_get_gstring): New forward static decl.
7264 * composite.h (Fcomposite_get_gstring): Remove decl.
7265 * dired.c (Ffile_attributes): New forward static decl.
7266 * doc.c (Fdocumntation_property): New forward static decl.
7267 * eval.c (Ffetch_bytecode): New forward static decl.
7268 (Funintern): Remove extern decl; now in .h file where it belongs.
7269 * fileio.c (Fmake_symbolic_link): New forward static decl.
7270 * image.c (Finit_image_library): New forward static decl.
7271 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7272 * intervals.h (Fprevious_property_change):
7273 (Fremove_list_of_text_properties): Remove decls.
7274 * keyboard.c (Fthis_command_keys): Remove decl.
7275 (Fcommand_execute): New forward static decl.
7276 * keymap.c (Flookup_key): New forward static decl.
7277 (Fcopy_keymap): Now static.
7278 * keymap.h (Flookup_key): Remove decl.
7279 * process.c (Fget_process): New forward static decl.
7280 (Fprocess_datagram_address): Mark as internal.
7281 * syntax.c (Fsyntax_table_p): New forward static decl.
7282 (skip_chars): Remove duplicate decl.
7283 * textprop.c (Fprevious_property_change): New forward static decl.
7284 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7286 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7287 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7289 * editfns.c (Fformat): Remove unreachable code.
7291 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7293 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7296 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7298 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7299 when at ZV. (Bug#8487)
7301 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7303 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7305 * keyboard.c (parse_tool_bar_item): Likewise.
7306 * sound.c (sound_cleanup, alsa_close): Likewise.
7307 * termcap.c (tgetent): Likewise.
7308 * xfns.c (x_default_font_parameter): Likewise.
7309 * xsettings.c (read_and_apply_settings): Likewise.
7311 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7312 (overrun_check_free): Protoize.
7314 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7316 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7317 since callers should never pass a negative size.
7318 Change the signature to match that of plain 'read' and 'write'; see
7319 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7320 * lisp.h: Update prototypes of emacs_write and emacs_read.
7322 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7324 * xdisp.c (redisplay_window): Don't try to determine the character
7325 position of the scroll margin if the window start point w->startp
7326 is outside the buffer's accessible region. (Bug#8468)
7328 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7330 Fix write-region and its subroutines for buffers > 2GB.
7331 * fileio.c (a_write, e_write): Modify declaration of arguments and
7332 local variables to support buffers larger than 2GB.
7333 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7335 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7336 argument, local variables, and return value.
7338 * lisp.h: Update prototypes of emacs_write and emacs_read.
7340 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7342 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7344 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7346 Fix more problems found by GCC 4.6.0's static checks.
7348 * xdisp.c (vmessage): Use a better test for character truncation.
7350 * charset.c (load_charset_map): <, not <=, for optimization,
7351 and to avoid potential problems with integer overflow.
7352 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7353 * casetab.c (set_identity, shuffle): Likewise.
7354 * editfns.c (Fformat): Likewise.
7355 * syntax.c (skip_chars): Likewise.
7357 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7358 This also lets GCC 4.6.0 generate slightly better loop code.
7360 * callint.c (Fcall_interactively): <, not <=, for optimization.
7361 (Fcall_interactively): Count the number of arguments produced,
7362 not the number of arguments given. This is simpler and lets GCC
7363 4.6.0 generate slightly better code.
7365 * ftfont.c: Distingish more carefully between FcChar8 and char.
7366 The previous code passed unsigned char * to a functions like
7367 strlen and xstrcasecmp that expect char *, which does not
7368 conform to the C standard.
7369 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7370 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7371 char * when the C standard requires it.
7373 * keyboard.c (read_char): Remove unused var.
7375 * eval.c: Port to Windows vsnprintf (Bug#8435).
7377 (SIZE_MAX): Define if the headers do not.
7378 (verror): Do not give up if vsnprintf returns a negative count.
7379 Instead, grow the buffer. This ports to Windows vsnprintf, which
7380 does not conform to C99. Problem reported by Eli Zaretskii.
7381 Also, simplify the allocation scheme, by avoiding the need for
7382 calling realloc, and removing the ALLOCATED variable.
7384 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7386 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7387 But keep the doprint source code for now, as we might revamp it
7388 and use it again (Bug#8435).
7389 * lisp.h (doprnt): Remove.
7390 * Makefile.in (base_obj): Remove doprnt.o.
7391 * deps.mk (doprnt.o): Remove.
7393 error: Print 32- and 64-bit integers portably (Bug#8435).
7394 Without this change, on typical 64-bit hosts error ("...%d...", N)
7395 was used to print both 32- and 64-bit integers N, which relied on
7397 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7399 * lisp.h (error, verror): Mark as printf-like functions.
7400 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7401 Report overflow in size calculations when allocating printf buffer.
7402 Do not truncate output string at its first null byte.
7403 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7404 Truncate the output at a character boundary, since vsnprintf does not
7406 * charset.c (check_iso_charset_parameter): Convert internal
7407 character to string before calling 'error', since %c now has the
7409 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7410 overflow when computing char to be passed to 'error'. Do not
7411 pass Lisp_Object to 'error'; pass the integer instead.
7412 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7413 formatted with plain %d.
7415 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7417 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7419 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7421 * xterm.c (x_catch_errors): Remove duplicate declaration.
7423 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7425 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7427 2011-04-10 Jim Meyering <meyering@redhat.com>
7429 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7430 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7431 return ssize_t not "int", and use size_t as the buffer length.
7432 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7433 * gnutls.h: Update declarations.
7434 * process.c (read_process_output): Use ssize_t, to match.
7435 (send_process): Likewise.
7437 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7439 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7441 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7443 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7444 Use unsigned char, to match FcChar8 type definition.
7446 * xterm.c (handle_one_xevent):
7447 * xmenu.c (create_and_show_popup_menu):
7448 * xselect.c (x_decline_selection_request)
7449 (x_reply_selection_request): Avoid type-punned deref of X events.
7451 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7453 Fix some uses of `int' instead of EMACS_INT.
7454 * search.c (string_match_1, fast_string_match)
7455 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7456 (scan_buffer, find_next_newline_no_quit)
7457 (find_before_next_newline, search_command, Freplace_match)
7458 (Fmatch_data): Make some `int' variables be EMACS_INT.
7460 * xdisp.c (display_count_lines): 3rd argument and return value now
7461 EMACS_INT. All callers changed.
7462 (pint2hrstr): Last argument is now EMACS_INT.
7464 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7465 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7466 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7467 (decode_coding_utf_16, decode_coding_emacs_mule)
7468 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7469 (decode_coding_ccl, decode_coding_charset)
7470 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7471 (decode_coding_iso_2022, decode_coding_emacs_mule)
7472 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7473 <char_offset, last_offset>: Declare EMACS_INT.
7474 (encode_coding_utf_8, encode_coding_utf_16)
7475 (encode_coding_emacs_mule, encode_invocation_designation)
7476 (encode_designation_at_bol, encode_coding_iso_2022)
7477 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7478 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7480 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7481 (encode_invocation_designation): Last argument P_NCHARS is now
7483 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7484 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7486 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7489 * ccl.c (Fccl_execute_on_string): Declare some variables
7492 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7494 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7496 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7498 * process.c (Fformat_network_address): Doc fix.
7500 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7502 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7504 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7506 * keyboard.c (read_char): Call Lisp function help-form-show,
7507 instead of using internal_with_output_to_temp_buffer.
7508 (Qhelp_form_show): New var.
7509 (syms_of_keyboard): Use DEFSYM macro.
7511 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7513 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7515 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7517 * process.c (Flist_processes): Remove to Lisp.
7518 (list_processes_1): Delete.
7520 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7522 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7524 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7526 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7528 Fix more problems found by GCC 4.6.0's static checks.
7530 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7532 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7534 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7536 * xdisp.c (vmessage): Mark as a printf-like function.
7538 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7540 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7542 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7543 printf-like functions.
7544 (tiff_load): Add casts to remove these marks before passing them
7545 to system-supplied API.
7547 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7549 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7550 This avoids several warnings with gcc -Wstrict-overflow.
7551 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7552 directly, rather than having caller test rule sign. This avoids
7553 some unnecessary tests.
7554 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7555 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7556 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7558 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7559 (xfont_open): Avoid unnecessary tests.
7561 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7563 * composite.h, composite.c (composition_gstring_put_cache):
7564 Use EMACS_INT, not int, for length.
7566 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7567 breaking out part of COMPOSITION_DECODE_RULE.
7568 (COMPOSITION_DECODE_RULE): Use it.
7569 * composite.c (get_composition_id): Remove unused local vars,
7570 by using the new macro.
7572 * textprop.c (set_text_properties_1): Change while to do-while,
7573 since the condition is always true at first.
7575 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7576 (interval_deletion_adjustment): Return unsigned value.
7579 * process.c (list_processes_1, create_pty, read_process_output):
7580 (exec_sentinel): Remove vars that were set but not used.
7581 (create_pty): Remove unnecessary "volatile"s.
7582 (Fnetwork_interface_info): Avoid possibility of int overflow.
7583 (read_process_output): Do adaptive read buffering even if carryover.
7584 (read_process_output): Simplify nbytes computation if buffered.
7586 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7588 * syntax.c (scan_words): Remove var that was set but not used.
7589 (update_syntax_table): Use unsigned instead of int.
7591 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7592 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7593 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7595 * print.c (print_error_message): Avoid int overflow.
7597 * font.c (font_list_entities): Redo for clarity,
7598 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7600 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7601 (font_score): Avoid potential overflow in diff calculation.
7603 * fns.c (substring_both): Remove var that is set but not used.
7604 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7606 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7608 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7609 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7610 can always succeed if overflow has undefined behavior.
7612 * search.c (boyer_moore, wordify): Remove vars set but not used.
7613 (wordify): Omit three unnecessary tests.
7615 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7616 All callers changed. This avoids the need for an unused var.
7618 * casefiddle.c (casify_region): Remove var that is set but not used.
7620 * dired.c (file_name_completion): Remove var that is set but not used.
7622 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7624 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7625 (Finsert_file_contents): Remove unnecessary code checking fd.
7627 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7628 Check for integer overflow on size calculations.
7630 * buffer.c (Fprevious_overlay_change): Remove var that is set
7633 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7634 Remove vars that are set but not used.
7635 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7636 (timer_check_2): Mark vars as initialized.
7638 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7640 * image.c (lookup_image): Remove var that is set but not used.
7641 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7643 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7644 that are set but not used.
7646 * xfns.c (make_invisible_cursor): Don't return garbage
7647 if XCreateBitmapFromData fails (Bug#8410).
7649 * xselect.c (x_get_local_selection, x_handle_property_notify):
7650 Remove vars that are set but not used.
7652 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7653 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7655 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7656 Remove var that is set but not used.
7657 (scroll_bar_windows_size): Now size_t, not int.
7658 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7661 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7662 (map_tty_color) [!defined MSDOS]: Likewise.
7664 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7666 * coding.c: Remove vars that are set but not used.
7667 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7668 All callers changed.
7669 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7670 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7671 (decode_coding_charset): Remove vars that are set but not used.
7673 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7674 that is set but not used.
7676 * print.c (print_object): Remove var that is set but not used.
7678 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7679 The gnulib version avoids calling malloc in the usual case,
7680 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7681 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7682 * filelock.c (current_lock_owner): Likewise.
7683 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7684 * sysdep.c: Include allocator.h, careadlinkat.h.
7685 (emacs_no_realloc_allocator): New static constant.
7686 (emacs_readlink): New function.
7687 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7688 ../lib/careadlinkat.h.
7690 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7692 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7693 first non-nil return value).
7695 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7697 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7698 if not defined (Bug#8403).
7700 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7702 * xdisp.c (display_count_lines): Remove parameter `start',
7703 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7704 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7705 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7706 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7707 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7708 and thereabouts. All callers changed.
7709 (get_per_char_metric): Remove parameter `f', unused since
7710 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7712 2011-04-02 Jim Meyering <meyering@redhat.com>
7714 do not dereference NULL upon failed strdup
7715 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7716 (ns_get_family): Likewise.
7718 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7720 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7722 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7724 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7727 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7729 Add lexical binding.
7731 * window.c (Ftemp_output_buffer_show): New fun.
7732 (Fsave_window_excursion):
7733 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7735 * lread.c (lisp_file_lexically_bound_p): New function.
7736 (Fload): Bind Qlexical_binding.
7737 (readevalloop): Remove `evalfun' arg.
7738 Bind Qinternal_interpreter_environment.
7739 (Feval_buffer): Bind Qlexical_binding.
7740 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7742 (syms_of_lread): Declare `lexical-binding'.
7744 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7746 * keyboard.c (eval_dyn): New fun.
7747 (menu_item_eval_property): Use it.
7749 * image.c (parse_image_spec): Use Ffunctionp.
7751 * fns.c (concat, mapcar1): Accept byte-code-functions.
7753 * eval.c (Fsetq): Handle lexical vars.
7754 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7755 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7756 (FletX, Flet): Obey lexical binding.
7757 (Fcommandp): Handle closures.
7758 (Feval): New `lexical' arg.
7759 (eval_sub): New function extracted from Feval. Use it almost
7760 everywhere where Feval was used. Look up vars in lexical env.
7762 (Ffunctionp): Move from subr.el.
7763 (Ffuncall): Handle closures.
7764 (apply_lambda): Remove `eval_flags'.
7765 (funcall_lambda): Handle closures and new byte-code-functions.
7766 (Fspecial_variable_p): New function.
7767 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7768 but without exporting it to Lisp.
7770 * doc.c (Fdocumentation, store_function_docstring):
7771 * data.c (Finteractive_form): Handle closures.
7773 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7776 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7778 (exec_byte_code): New function extracted from Fbyte_code to handle new
7779 calling convention for byte-code-functions. Add new byte-codes.
7781 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7783 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7785 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7787 * xdisp.c (redisplay_internal): Fix prototype.
7789 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7791 * xdisp.c (SCROLL_LIMIT): New macro.
7792 (try_scrolling): Use it when setting scroll_limit.
7793 Limit scrolling to 100 screen lines.
7794 (redisplay_window): Even when falling back on "recentering",
7795 position point in the window according to scroll-conservatively,
7796 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7798 (try_scrolling): When point is above the window, allow searching
7799 as far as scroll_max, or one screenful, to compute vertical
7800 distance from PT to the scroll margin position. This prevents
7801 try_scrolling from unnecessarily failing when
7802 scroll-conservatively is set to a value slightly larger than the
7803 window height. Clean up the case of PT below the margin at bottom
7804 of window: scroll_max can no longer be INT_MAX. When aggressive
7805 scrolling is in use, don't let point enter the opposite scroll
7806 margin as result of the scroll.
7807 (syms_of_xdisp) <scroll-conservatively>: Document the
7808 threshold of 100 lines for never-recentering scrolling.
7810 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7812 * dispextern.h (move_it_by_lines):
7813 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7814 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7815 (message_log_check_duplicate): Remove parameters `prev_bol' and
7816 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7817 (redisplay_internal): Remove parameter `preserve_echo_area',
7818 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7820 * indent.c (Fvertical_motion):
7821 * window.c (window_scroll_pixel_based, Frecenter):
7822 Don't pass `need_y_p' to `move_it_by_lines'.
7824 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7826 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7827 steal a few bits to be more compact.
7828 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7829 Remove unneeded casts.
7831 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7833 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7835 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7836 binding" message (bug#7967).
7838 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7840 Fix more problems found by GCC 4.6.0's static checks.
7842 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7843 Remove unused local var.
7845 * editfns.c (Fmessage_box): Remove unused local var.
7847 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7848 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7849 Omit unused local vars.
7850 * window.c (shrink_windows): Omit unused local var.
7851 * menu.c (digest_single_submenu): Omit unused local var.
7852 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7853 Omit unused local var.
7855 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7856 Don't assume string length fits in int.
7857 (keyremap_step, read_key_sequence): Use size_t for sizes.
7858 (read_key_sequence): Don't check last_real_key_start redundantly.
7860 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7861 instead of alloca (Bug#8344).
7863 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7864 (Fbacktrace_frame): Don't assume nframes fits in int.
7866 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7868 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7871 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7873 * cm.c (calccost): Turn while-do into do-while, for clarity.
7875 * keyboard.c (syms_of_keyboard): Use the same style as later
7876 in this function when indexing through an array. This also
7877 works around GCC bug 48267.
7879 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7881 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7883 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7884 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7886 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7887 This avoids undefined behavior on integer overflow, and is a bit
7888 more convenient anyway since it is compared to a size_t variable.
7890 Variadic C functions now count arguments with size_t, not int.
7891 This avoids an unnecessary limitation on 64-bit machines, which
7892 caused (substring ...) to crash on large vectors (Bug#8344).
7893 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7894 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7895 All variadic functions and their callers changed accordingly.
7896 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7897 * data.c (arith_driver, float_arith_driver): Likewise.
7898 * editfns.c (general_insert_function): Likewise.
7899 * eval.c (struct backtrace.nargs, interactive_p)
7900 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7901 (funcall_lambda, mark_backtrace): Likewise.
7902 * fns.c (concat): Likewise.
7903 * frame.c (x_set_frame_parameters): Likewise.
7904 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7905 0 if not found, not -1. All callers changed.
7907 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7908 (stack_copy_size): Now size_t, not int.
7909 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7911 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7913 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7914 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7915 All callers changed.
7917 * lisp.h (multibyte_char_to_unibyte):
7918 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7919 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7920 * character.h (CHAR_TO_BYTE8):
7921 * cmds.c (internal_self_insert):
7922 * editfns.c (general_insert_function):
7923 * keymap.c (push_key_description):
7924 * search.c (Freplace_match):
7925 * xdisp.c (message_dolog, set_message_1): All callers changed.
7927 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7929 * keyboard.c (safe_run_hook_funcall): New function.
7930 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7931 don't set the hook to nil, but remove the offending function instead.
7932 (Qcommand_hook_internal): Remove, unused.
7933 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7934 Vcommand_hook_internal.
7936 * eval.c (enum run_hooks_condition): Remove.
7937 (funcall_nil, funcall_not): New functions.
7938 (run_hook_with_args): Call each function through a `funcall' argument.
7939 Remove `cond' argument, now redundant.
7940 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7941 (Frun_hook_with_args_until_failure): Adjust accordingly.
7942 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7944 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7946 * dispextern.h (string_buffer_position): Remove declaration.
7948 * print.c (strout): Remove parameter `multibyte', unused since
7949 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7951 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7952 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7953 All callers changed.
7955 * w32.c (_wsa_errlist): Use braces for struct initializers.
7957 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7958 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7959 All callers changed.
7960 (string_buffer_position): Likewise. Also, make static (it's never
7961 used outside xdisp.c).
7962 (cursor_row_p): Remove parameter `w', unused since
7963 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7964 (decode_mode_spec): Remove parameter `precision', introduced during
7965 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7966 All callers changed.
7968 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7970 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7972 2011-03-27 Anders Lindgren <andlind@gmail.com>
7974 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7975 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7976 (ns_update_auto_hide_menu_bar): New functions.
7977 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7978 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7979 ns_constrain_all_frames.
7980 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7981 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7983 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7985 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7987 2011-03-27 Glenn Morris <rgm@gnu.org>
7989 * syssignal.h: Replace RETSIGTYPE with void.
7990 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7991 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7992 Replace SIGTYPE with void everywhere.
7993 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7994 * s/template.h (SIGTYPE): Remove commented out definition.
7996 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7998 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7999 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8001 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8003 * w32.c (read_unc_volume): Use parameter `henum', instead of
8004 global variable `wget_enum_handle'.
8006 * keymap.c (describe_vector): Remove parameters `indices' and
8007 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8008 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8010 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8012 * keyboard.c (timer_check): Remove parameter `do_it_now',
8013 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8014 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8015 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8017 * keyboard.c (read_char):
8018 * w32menu.c (w32_menu_display_help):
8019 * xmenu.c (show_help_event, menu_help_callback):
8020 Adjust calls to `show_help_echo'.
8022 * gtkutil.c (xg_maybe_add_timer):
8023 * keyboard.c (readable_events):
8024 * process.c (wait_reading_process_output):
8025 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8027 * insdel.c (adjust_markers_gap_motion):
8028 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8029 (gap_left, gap_right): Don't call it.
8031 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8033 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8034 incurred during fontification.
8036 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8038 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8039 (DEFVAR_PER_BUFFER): Don't pass it.
8041 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8042 (scrolling_window): Don't pass it.
8044 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8046 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8048 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8050 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8051 of variables specific to SELinux and computation of `encoded_absname'.
8053 * image.c (XPutPixel): Remove unused variable `height'.
8055 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8057 * unexw32.c (get_section_info): Remove unused variable `section'.
8059 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8060 (system_process_attributes): Remove unused variable `sess'.
8061 (sys_read): Remove unused variable `err'.
8063 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8064 (w32_wnd_proc): Remove unused variable `isdead'.
8065 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8066 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8067 (x_create_tip_frame): Remove unused variable `tem'.
8069 * w32inevt.c (w32_console_read_socket):
8070 Remove unused variable `no_events'.
8072 * w32term.c (x_draw_composite_glyph_string_foreground):
8073 Remove unused variable `width'.
8075 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8077 * w32term.c (x_set_glyph_string_clipping):
8078 Don't pass uninitialized region to CombineRgn.
8080 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8082 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8083 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8084 (Fx_close_connection): Remove unused variable `i'.
8086 * w32font.c (w32font_draw): Return number of glyphs.
8087 (w32font_open_internal): Remove unused variable `i'.
8088 (w32font_driver): Add missing initializer.
8090 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8091 (fill_in_menu): Remove unused variable `items_added'.
8093 * w32term.c (last_mouse_press_frame): Remove static global variable.
8094 (w32_clip_to_row): Remove unused variable `f'.
8095 (x_delete_terminal): Remove unused variable `i'.
8097 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8098 (NOTHING): Remove unused static global variable.
8099 (uniscribe_check_otf): Remove unused variable `table'.
8100 (uniscribe_font_driver): Add missing initializers.
8102 2011-03-23 Julien Danjou <julien@danjou.info>
8104 * term.c (Fsuspend_tty, Fresume_tty):
8105 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8106 * window.c (temp_output_buffer_show):
8107 * insdel.c (signal_before_change):
8108 * frame.c (Fhandle_switch_frame):
8109 * fileio.c (Fdo_auto_save):
8110 * emacs.c (Fkill_emacs):
8111 * editfns.c (save_excursion_restore):
8112 * cmds.c (internal_self_insert):
8113 * callint.c (Fcall_interactively):
8114 * buffer.c (Fkill_all_local_variables):
8115 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8117 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8118 unconditionally since it does the check itself.
8120 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8122 Fix more problems found by GCC 4.5.2's static checks.
8124 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8125 the first time through the loop, since we know p0 < p1 then.
8126 This also avoids a gcc -Wstrict-overflow warning.
8128 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8129 leading to a memory leak, possible in functions like
8130 load_charset_map_from_file that can allocate an unbounded number
8131 of objects (Bug#8318).
8133 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8134 that could (at least in theory) be that large.
8136 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8137 This is less likely to overflow, and avoids undefined behavior if
8138 overflow does occur. All callers changed. Use strtoul to scan
8139 for the unsigned long integer.
8140 (pint2hrstr): Simplify and tune code slightly.
8141 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8143 * scroll.c (do_scrolling): Work around GCC bug 48228.
8144 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8146 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8147 This also avoids a warning with gcc -Wstrict-overflow.
8148 (validate_x_resource_name): Simplify count usage.
8149 This also avoids a warning with gcc -Wstrict-overflow.
8151 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8154 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8156 * process.c (Fmake_network_process): Use socklen_t, not int,
8157 where POSIX says socklen_t is required in portable programs.
8158 This fixes a porting bug on hosts like 64-bit HP-UX, where
8159 socklen_t is wider than int (Bug#8277).
8160 (Fmake_network_process, server_accept_connection):
8161 (wait_reading_process_output, read_process_output):
8164 * process.c: Rename or move locals to avoid shadowing.
8165 (list_processes_1, Fmake_network_process):
8166 (read_process_output_error_handler, exec_sentinel_error_handler):
8167 Rename or move locals.
8168 (Fmake_network_process): Define label "retry_connect" only if needed.
8169 (Fnetwork_interface_info): Fix pointer signedness.
8170 (process_send_signal): Add cast to avoid pointer signedness problem.
8171 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8172 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8174 Make tparam.h and terminfo.c consistent.
8175 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8176 Include tparam.h instead, since it declares them.
8177 * cm.h (PC): Remove extern decl; tparam.h now does this.
8178 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8179 * terminfo.c: Include tparam.h, to check interfaces.
8180 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8181 (tparam): Adjust signature to match interface in tparam.h;
8182 this removes some undefined behavior. Check that outstring and len
8183 are zero, which they always are with Emacs.
8184 * tparam.h (PC, BC, UP): New extern decls.
8186 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8187 (xftfont_open): Rename locals to avoid shadowing.
8189 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8190 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8191 (OTF_TAG_SYM): Omit macro if not needed.
8192 (ftfont_list): Remove unused local.
8193 (get_adstyle_property, ftfont_pattern_entity):
8194 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8195 Rename locals to avoid shadowing.
8197 * xfont.c (xfont_list_family): Mark var as initialized.
8199 * xml.c (make_dom): Now static.
8201 * composite.c (composition_compute_stop_pos): Rename local to
8203 (composition_reseat_it): Remove unused locals.
8204 (find_automatic_composition, composition_adjust_point): Likewise.
8205 (composition_update_it): Mark var as initialized.
8206 (find_automatic_composition): Mark vars as initialized,
8207 with a FIXME (Bug#8290).
8209 character.h: Rename locals to avoid shadowing.
8210 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8211 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8212 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8213 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8216 * textprop.c (property_change_between_p): Remove; unused.
8218 * intervals.c (interval_start_pos): Now static.
8220 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8222 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8223 Rename locals to avoid shadowing.
8225 * sound.c (wav_play, au_play, Fplay_sound_internal):
8226 Fix pointer signedness.
8227 (alsa_choose_format): Remove unused local var.
8228 (wav_play): Initialize a variable to 0, to prevent undefined
8229 behavior (Bug#8278).
8231 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8233 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8235 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8236 clobbering (Bug#8298).
8237 * sysdep.c (sys_subshell): Likewise.
8238 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8240 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8241 This should get cleaned up, so that child_setup has the
8242 same signature on all platforms.
8244 * callproc.c (call_process_cleanup): Now static.
8245 (relocate_fd): Rename locals to avoid shadowing.
8247 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8249 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8250 not to be necessary, and produces flickering.
8252 2011-03-20 Glenn Morris <rgm@gnu.org>
8254 * config.in: Remove file.
8256 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8258 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8259 are now in src/globals.h.
8260 (syms_of_minibuf): Remove spurious & from previous change.
8262 2011-03-20 Leo <sdl.web@gmail.com>
8264 * minibuf.c (completing-read-function): New variable.
8265 (completing-read-default): Rename from completing-read.
8266 (completing-read): Call completing-read-function.
8268 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8270 * xfaces.c (Fx_load_color_file):
8271 Read color file from absolute filename (bug#8250).
8273 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8275 * makefile.w32-in: Update dependencies.
8277 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8279 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8281 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8283 Fix more problems found by GCC 4.5.2's static checks.
8285 * process.c (make_serial_process_unwind, send_process_trap):
8286 (sigchld_handler): Now static.
8288 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8289 That way, the code declares only the vars that it needs.
8290 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8291 * s/cygwin.h (PTY_ITERATION): Likewise.
8292 * s/darwin.h (PTY_ITERATION): Likewise.
8293 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8295 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8296 * process.c (allocate_pty): Don't declare stb unless it's needed.
8298 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8299 (CONSTANTLIM): Remove; unused.
8300 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8301 Define only if needed.
8303 * unexelf.c (unexec): Name an expression,
8304 to avoid gcc -Wbad-function-cast warning.
8305 Use a different way to cause a compilation error if anyone uses
8306 n rather than nn, a way that does not involve shadowing.
8307 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8309 * deps.mk (unexalpha.o): Remove; unused.
8311 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8312 * unexec.h: New file.
8313 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8314 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8316 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8317 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8318 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8319 Change as necessary to match prototype in unexec.h.
8321 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8323 (back_comment, skip_chars): Mark vars as initialized.
8325 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8326 Rename locals to avoid shadowing.
8328 * lread.c (read1): Rewrite so as not to use empty "else".
8329 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8331 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8333 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8334 warning when compiling print.c.
8336 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8337 instead of using an uninitialized var.
8338 (font_sort_entities): Mark var as initialized.
8340 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8342 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8343 pointers to constants.
8344 (font_parse_fcname): Remove unused vars.
8345 (font_delete_unmatched): Now static.
8346 (font_get_spec): Remove; unused.
8347 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8348 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8349 Rename or move locals to avoid shadowing.
8351 * fns.c (require_nesting_list, require_unwind): Now static.
8352 (Ffillarray): Rename locals to avoid shadowing.
8354 * floatfns.c (domain_error2): Define only if needed.
8355 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8357 * alloc.c (mark_backtrace): Move decl from here ...
8358 * lisp.h: ... to here, so that it can be checked.
8360 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8361 (Fdefvar): Rewrite so as not to use empty "else".
8362 (lisp_indirect_variable): Name an expression,
8363 to avoid gcc -Wbad-function-cast warning.
8364 (Fdefvar): Rename locals to avoid shadowing.
8366 * callint.c (quotify_arg, quotify_args): Now static.
8367 (Fcall_interactively): Rename locals to avoid shadowing.
8368 Use const pointer when appropriate.
8370 * lisp.h (get_system_name, get_operating_system_release):
8371 Move decls here, to check interfaces.
8372 * process.c (get_operating_system_release): Move decl to lisp.h.
8373 * xrdb.c (get_system_name): Likewise.
8374 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8375 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8376 some of which prompt warnings from gcc -Wbad-function-cast.
8377 (Fformat_time_string, Fencode_time, Finsert_char):
8378 (Ftranslate_region_internal, Fformat):
8379 Rename or remove local vars to avoid shadowing.
8380 (Ftranslate_region_internal): Mark var as initialized.
8382 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8385 * lisp.h (eassert): Check that the argument compiles, even if
8386 ENABLE_CHECKING is not defined.
8388 * data.c (Findirect_variable): Name an expression, to avoid
8389 gcc -Wbad-function-cast warning.
8390 (default_value, arithcompare, arith_driver, arith_error): Now static.
8391 (store_symval_forwarding): Rename local to avoid shadowing.
8392 (Fmake_variable_buffer_local, Fmake_local_variable):
8393 Mark variables as initialized.
8394 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8396 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8397 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8398 Rename locals to avoid shadowing.
8399 (mark_stack): Move local variables into the #ifdef region where
8401 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8402 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8404 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8405 (GC_STRING_CHARS): Remove; not used.
8406 (Fmemory_limit): Cast sbrk's returned value to char *.
8408 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8409 avoids undefined behavior in theory.
8411 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8413 Use functions, not macros, for up- and down-casing (Bug#8254).
8414 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8415 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8416 to use the following functions instead of these macros.
8417 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8418 EMACS_INT, since callers assume the returned value fits in int.
8419 (upcase1): Likewise, for UPCASE_TABLE.
8420 (uppercasep, lowercasep, upcase): New static inline functions.
8421 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8422 the race-condition problem in the old DOWNCASE.
8424 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8425 Rename locals to avoid shadowing.
8426 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8427 (regex_compile, re_search_2, re_match_2_internal):
8428 Remove unused local vars.
8429 (FREE_VAR): Rewrite so as not to use empty "else",
8430 which gcc can warn about.
8431 (regex_compile, re_match_2_internal): Mark locals as initialized.
8432 (RETALLOC_IF): Define only if needed.
8433 (WORDCHAR_P): Likewise. This one is never needed, but is used
8434 only in a comment talking about a compiler bug, so put inside
8435 the #if 0 of that comment.
8436 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8437 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8440 * search.c (boyer_moore): Rename locals to avoid shadowing.
8441 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8442 (PREV_CHAR_BOUNDARY): Likewise.
8444 * search.c (simple_search): Remove unused var.
8446 * dired.c (compile_pattern): Move decl from here ...
8447 * lisp.h: ... to here, so that it can be checked.
8448 (struct re_registers): New forward decl.
8450 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8452 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8454 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8455 Rename locals to avoid shadowing.
8456 (Fvertical_motion): Mark locals as initialized.
8458 * casefiddle.c (casify_object, casify_region): Now static.
8459 (casify_region): Mark local as initialized.
8461 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8463 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8464 New macros, so that the caller can use some names other than
8465 gcpro1, gcpro2, etc.
8466 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8468 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8469 argument, for consistency with GCPRO2_VAR, etc: it is now the
8470 prefix of the variable, not the variable itself. All uses
8472 * dired.c (directory_files_internal, file_name_completion):
8473 Rename locals to avoid shadowing.
8475 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8476 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8477 dired.c's scmp function, had undefined behavior.
8478 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8479 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8480 * buffer.h: ... to here, because these macros use current_buffer,
8481 and the new implementation with inline functions needs to have
8482 current_buffer in scope now, rather than later when the macros
8484 (downcase, upcase1): New static inline functions.
8485 (DOWNCASE, UPCASE1): Reimplement using these functions.
8486 This avoids undefined behavior in expressions like
8487 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8488 from race conditions in accessing the global variables
8489 case_temp1 and case_temp2.
8490 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8491 * lisp.h (case_temp1, case_temp2): Remove their decls.
8492 * character.h (ASCII_CHAR_P): Move from here ...
8493 * lisp.h: ... to here, so that the inline functions mentioned
8496 * dired.c (directory_files_internal_unwind): Now static.
8498 * fileio.c (file_name_as_directory, directory_file_name):
8499 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8501 (file_name_as_directory): Use const pointers when appropriate.
8502 (Fexpand_file_name): Likewise. In particular, newdir might
8503 point at constant storage, so make it a const pointer.
8504 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8505 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8507 (Fset_file_times, Finsert_file_contents, auto_save_error):
8508 Rename locals to avoid shadowing.
8510 * minibuf.c (choose_minibuf_frame_1): Now static.
8511 (Ftry_completion, Fall_completions): Rename or remove locals
8514 * marker.c (bytepos_to_charpos): Remove; unused.
8516 * lisp.h (verify_bytepos, count_markers): New decls,
8517 so that gcc does not warn that these functions aren't declared.
8519 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8520 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8521 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8522 (copy_text): Remove unused local var.
8524 * filelock.c (within_one_second): Now static.
8525 (lock_file_1): Rename local to avoid shadowing.
8527 * buffer.c (fix_overlays_before): Mark locals as initialized.
8528 (fix_start_end_in_overlays): Likewise. This function should be
8529 simplified by using pointers-to-pointers, but that's a different
8531 (switch_to_buffer_1): Now static.
8532 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8533 (report_overlay_modification): Rename locals to avoid shadowing.
8535 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8536 Fix pointer signedness issue.
8537 (sys_subshell): Mark local as volatile if checking for lint,
8538 to suppress a gcc -Wclobbered warning that does not seem to be right.
8539 (MAXPATHLEN): Define only if needed.
8541 * process.c (serial_open, serial_configure): Move decls from here ...
8542 * systty.h: ... to here, so that they can be checked.
8544 * fns.c (get_random, seed_random): Move extern decls from here ...
8545 * lisp.h: ... to here, so that they can be checked.
8547 * sysdep.c (reset_io): Now static.
8548 (wait_for_termination_signal): Remove; unused.
8550 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8551 (copy_keymap_item, append_key, push_text_char_description):
8553 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8554 (DENSE_TABLE_SIZE): Remove; unused.
8555 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8556 (describe_map_tree):
8557 Rename locals to avoid shadowing.
8559 * keyboard.c: Declare functions static if they are not used elsewhere.
8560 (echo_char, echo_dash, cmd_error, top_level_2):
8561 (poll_for_input, handle_async_input): Now static.
8562 (read_char, kbd_buffer_get_event, make_lispy_position):
8563 (make_lispy_event, make_lispy_movement, apply_modifiers):
8564 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8565 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8566 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8567 (read_key_sequence, read_char): Mark locals as initialized.
8568 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8570 * keyboard.h (make_ctrl_char): New decl.
8571 (mark_kboards): Move decl here ...
8572 * alloc.c (mark_kboards): ... from here.
8574 * lisp.h (force_auto_save_soon): New decl.
8576 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8577 (DEFINE_DUMMY_FUNCTION): New macro.
8578 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8580 (main): Add casts to avoid warnings
8581 if GCC considers string literals to be constants.
8583 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8585 * dbusbind.c: Pointer signedness fixes.
8586 (xd_signature, xd_append_arg, xd_initialize):
8587 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8588 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8589 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8590 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8592 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8593 if GCC considers string literals to be constants.
8594 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8596 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8598 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8599 (print_preprocess, print_object): New macro to fix last change.
8601 * print.c (print_preprocess): Don't forget font objects.
8603 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8605 * emacs.c (USAGE3): Doc fixes.
8607 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8609 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8612 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8614 * lisp.h (VWindow_system, Qfile_name_history):
8615 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8616 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8617 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8619 * w32select.c: Don't #include "keyboard.h".
8620 (run_protected): Add extern declaration for waiting_for_input.
8622 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8623 * w32console.c (detect_input_pending, read_input_pending)
8624 (encode_terminal_code):
8625 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8626 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8627 (w32_system_caret_y, Qfile_name_history):
8628 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8629 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8630 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8631 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8632 * w32proc.c (Qlocal, report_file_error):
8633 * w32term.c (Vwindow_system, updating_frame):
8634 * w32uniscribe.c (initialized, uniscribe_font_driver):
8635 Remove unneeded extern declarations.
8637 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8639 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8641 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8643 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8644 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8645 These macros can no longer be used for assignment.
8647 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8648 Assign struct members directly, instead of using BUF_BEGV etc.
8649 (record_buffer_markers, fetch_buffer_markers): New functions for
8650 recording and fetching special buffer markers.
8651 (set_buffer_internal_1, set_buffer_temp): Use them.
8653 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8655 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8657 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8658 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8660 * xdisp.c (hscroll_window_tree):
8661 (reconsider_clip_changes): Use PT instead of BUF_PT.
8663 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8665 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8666 $(EMACS_ROOT)/lib/intprops.h.
8668 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8670 Fix more problems found by GCC 4.5.2's static checks.
8672 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8673 to unsigned char * to avoid compiler diagnostic.
8674 (xg_free_frame_widgets): Make it clear that a local variable is
8675 needed only if USE_GTK_TOOLTIP.
8676 (gdk_window_get_screen): Make it clear that this macro is needed
8677 only if USE_GTK_TOOLTIP.
8678 (int_gtk_range_get_value): New function, which avoids a diagnostic
8679 from gcc -Wbad-function-cast.
8680 (xg_set_toolkit_scroll_bar_thumb): Use it.
8681 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8682 diagnostic from gcc -Wbad-function-cast.
8683 (get_utf8_string, xg_get_file_with_chooser):
8684 Rename locals to avoid shadowing.
8685 (create_dialog): Move locals to avoid shadowing.
8687 * xgselect.c (xg_select): Remove unused var.
8689 * image.c (four_corners_best): Mark locals as initialized.
8690 (gif_load): Initialize transparent_p to zero (Bug#8238).
8691 Mark another local as initialized.
8692 (my_png_error, my_error_exit): Mark with NO_RETURN.
8694 * image.c (clear_image_cache): Now static.
8695 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8696 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8697 (x_edge_detection): Remove unnecessary cast that
8698 gcc -Wbad-function-cast diagnoses.
8699 (gif_load): Fix pointer signedness.
8700 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8701 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8703 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8705 Improve quality of tests for time stamp overflow.
8706 For example, without this patch (encode-time 0 0 0 1 1
8707 1152921504606846976) returns the obviously-bogus value (-948597
8708 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8709 reports time overflow. See
8710 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8711 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8712 * editfns.c: Include limits.h and intprops.h.
8713 (TIME_T_MIN, TIME_T_MAX): New macros.
8714 (time_overflow): Move earlier, to before first use.
8715 (hi_time, lo_time): New functions, for an accurate test for
8717 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8718 (Fget_internal_run_time): Don't assume time_t fits in int.
8719 (make_time): Use list2 instead of Fcons twice.
8720 (Fdecode_time): More accurate test for out-of-range times.
8721 (check_tm_member): New function.
8722 (Fencode_time): Use it, to test for out-of-range times.
8723 (lisp_time_argument): Don't rely on undefined left-shift and
8724 right-shift behavior when checking for time stamp overflow.
8726 * editfns.c (time_overflow): New function, refactoring common code.
8727 (Fformat_time_string, Fdecode_time, Fencode_time):
8728 (Fcurrent_time_string): Use it.
8730 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8731 * dired.c (make_time): Move to ...
8732 * editfns.c (make_time): ... here.
8733 * systime.h: Note the move.
8735 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8737 * fringe.c (update_window_fringes): Remove unused variables.
8739 * unexmacosx.c (copy_data_segment): Also copy __got section.
8742 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8744 * termcap.c [MSDOS]: Include "msdos.h".
8745 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8746 Constify `char *' arguments and their references according to
8747 prototypes in tparam.h.
8749 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8751 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8752 Adapt all references accordingly.
8754 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8756 2011-03-11 Tom Tromey <tromey@redhat.com>
8758 * buffer.c (syms_of_buffer): Remove obsolete comment.
8760 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8762 * termhooks.h (encode_terminal_code): Declare prototype.
8764 * msdos.c (encode_terminal_code): Don't declare prototype.
8766 * term.c (encode_terminal_code): Now external again, used by
8767 w32console.c and msdos.c.
8769 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8770 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8772 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8774 Fix some minor problems found by GCC 4.5.2's static checks.
8776 * fringe.c (update_window_fringes): Mark locals as initialized
8778 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8780 * alloc.c (mark_fringe_data): Move decl from here ...
8781 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8782 to check its interface.
8783 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8785 * fontset.c (free_realized_fontset): Now static.
8786 (Fset_fontset_font): Rename local to avoid shadowing.
8787 (fontset_font): Mark local as initialized.
8788 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8790 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8792 * xselect.c (x_disown_buffer_selections): Remove; not used.
8793 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8794 (x_own_selection, Fx_disown_selection_internal): Rename locals
8796 (x_handle_dnd_message): Remove local to avoid shadowing.
8798 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8799 so that the caller can use some name other than gcpro1.
8800 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8801 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8802 (Fx_backspace_delete_keys_p):
8803 Use them to avoid shadowing, and rename vars to avoid shadowing.
8804 (x_decode_color, x_set_name, x_window): Now static.
8805 (Fx_create_frame): Add braces to silence GCC warning.
8806 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8807 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8808 Remove unused locals.
8809 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8810 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8811 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8814 * xterm.h (x_mouse_leave): New decl.
8816 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8817 Remove unused functions.
8818 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8819 (x_calc_absolute_position): Now static.
8820 (XTread_socket): Don't define label "out" unless it's used.
8821 Don't declare local "event" unless it's used.
8822 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8823 unless they are used.
8824 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8825 (x_fatal_error_signal): Remove; not used.
8826 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8827 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8828 (x_error_catcher, x_connection_closed, x_error_handler):
8829 (x_error_quitter, xembed_send_message, x_iconify_frame):
8830 (my_log_handler): Rename locals to avoid shadowing.
8831 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8832 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8834 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8835 Rename or move locals to avoid shadowing.
8836 (tty_defined_color, merge_face_heights): Now static.
8837 (free_realized_faces_for_fontset): Remove; not used.
8838 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8839 does not deduce is never used uninitialized.
8840 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8841 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8843 * terminal.c (store_terminal_param): Now static.
8845 * xmenu.c (menu_highlight_callback): Now static.
8846 (set_frame_menubar): Remove unused local.
8847 (xmenu_show): Rename parameter to avoid shadowing.
8848 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8849 since they might point to immutable storage.
8850 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8851 since it's unused otherwise.
8853 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8854 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8855 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8856 avoids a gcc -Wuninitialized diagnostic.
8857 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8858 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8859 does not deduce are never used uninitialized.
8861 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8863 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8864 * window.c (window_loop, size_window):
8865 (run_window_configuration_change_hook, enlarge_window): Likewise.
8867 * window.c (display_buffer): Now static.
8868 (size_window): Mark variables that gcc -Wuninitialized
8869 does not deduce are never used uninitialized.
8870 * window.h (check_all_windows): New decl, to forestall
8871 gcc -Wmissing-prototypes diagnostic.
8872 * dispextern.h (bidi_dump_cached_states): Likewise.
8874 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8876 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8878 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8879 and to avoid gcc -Wuninitialized warning.
8880 (load_charset_map): Mark variables that gcc -Wuninitialized
8881 does not deduce are never used uninitialized.
8882 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8884 * coding.c (coding_set_source, coding_set_destination):
8885 Use "else { /* comment */ }" rather than "else /* comment */;"
8886 for clarity, and to avoid gcc -Wempty-body warning.
8887 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8888 a block, when the outer 'i' will do.
8889 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8890 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8891 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8892 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8893 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8894 Rename locals to avoid shadowing.
8895 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8896 * coding.c (emacs_mule_char, encode_invocation_designation):
8897 Now static, since they're not used elsewhere.
8898 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8899 (decode_coding_object, encode_coding_object, detect_coding_system):
8900 (decode_coding_emacs_mule): Mark variables that gcc
8901 -Wuninitialized does not deduce are never used uninitialized.
8902 (detect_coding_iso_2022): Initialize a local variable that might
8903 be used uninitialized. Leave a FIXME because it's not clear that
8904 this initialization is needed. (Bug#8211)
8905 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8906 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8907 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8908 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8909 Remove unused macros.
8911 * category.c (hash_get_category_set): Remove unused local var.
8912 (copy_category_table): Now static, since it's not used elsewhere.
8913 * character.c (string_count_byte8): Likewise.
8915 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8916 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8918 * chartab.c (copy_sub_char_table): Now static, since it's not used
8920 (sub_char_table_ref_and_range, char_table_ref_and_range):
8921 Rename locals to avoid shadowing.
8922 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8924 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8925 (BIDI_BOB): Remove unused macro.
8927 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8928 deduce are never used uninitialized.
8929 * term.c (encode_terminal_code): Likewise.
8931 * term.c (encode_terminal_code): Now static. Remove unused local.
8933 * tparam.h: New file.
8934 * term.c, tparam.h: Include it.
8935 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8936 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8937 Move these decls to tparam.h, and make them agree with what
8938 is actually in tparam.c. The previous trick of using incompatible
8939 decls in different modules does not conform to the C standard.
8940 All callers of tparam changed to use tparam's actual API.
8941 * tparam.c (tparam1, tparam, tgoto):
8942 Use const pointers where appropriate.
8944 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8945 * cm.h (struct cm): Likewise.
8946 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8947 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8948 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8949 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8950 (turn_on_face, init_tty): Likewise.
8951 * termchar.h (struct tty_display_info): Likewise.
8953 * term.c (term_mouse_position): Rename local to avoid shadowing.
8955 * alloc.c (mark_ttys): Move decl from here ...
8956 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8958 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8960 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8962 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8964 * search.c (compile_pattern_1): Remove argument regp, unused since
8965 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8966 (compile_pattern): Don't pass it.
8968 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8970 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8971 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8973 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8975 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8977 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8978 gdk_window_get_screen, gdk_window_get_geometry,
8979 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8980 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8981 (xg_get_pixbuf_from_pixmap): New function.
8982 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8983 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8984 Call xg_get_pixbuf_from_pixmap instead of
8985 gdk_pixbuf_get_from_drawable.
8986 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8987 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8988 (xg_check_special_colors): Use GtkStyleContext and its functions
8990 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8991 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8992 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8993 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8994 Call gtk_widget_get_preferred_size.
8995 (xg_frame_resized): gdk_window_get_geometry only takes 5
8997 (xg_win_to_widget, xg_event_is_for_menubar):
8998 Call gdk_x11_window_lookup_for_display.
8999 (xg_set_widget_bg): New function.
9000 (delete_cb): New function.
9001 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9002 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9003 (xg_set_background_color): Call xg_set_widget_bg.
9004 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9005 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9006 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9007 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9009 (update_frame_tool_bar): Call gtk_widget_hide.
9010 (xg_initialize): Use GDK_KEY_g.
9012 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9014 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9016 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9017 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9018 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9020 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9022 * w32xfns.c (select_palette): Check success of RealizePalette against
9023 GDI_ERROR, not zero.
9025 See ChangeLog.11 for earlier changes.
9031 Copyright (C) 2011 Free Software Foundation, Inc.
9033 This file is part of GNU Emacs.
9035 GNU Emacs is free software: you can redistribute it and/or modify
9036 it under the terms of the GNU General Public License as published by
9037 the Free Software Foundation, either version 3 of the License, or
9038 (at your option) any later version.
9040 GNU Emacs is distributed in the hope that it will be useful,
9041 but WITHOUT ANY WARRANTY; without even the implied warranty of
9042 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9043 GNU General Public License for more details.
9045 You should have received a copy of the GNU General Public License
9046 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.