1 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
3 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
4 Unlike the other wrapped functions, fabs has an unspecified
7 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
9 * nsterm.m (keyDown): Interpret flags without left/right bits
10 as the left key (Bug#11670).
12 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
14 Remove empty and useless init functions.
15 * lisp.h (init_character_once, init_fns, init_image)
16 (init_filelock, init_sound): Remove prototype.
17 * character.c (init_character_once): Remove.
18 * filelock.c (init_filelock): Likewise.
19 * fns.c (init_fns): Likewise.
20 * image.c (init_image): Likewise.
21 * sound.c (init_sound): Likewise.
22 * emacs.c (main): Adjust accordingly.
24 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
26 * gtkutil.h: Tiny cleanups.
27 (use_old_gtk_file_dialog): Remove useless declaration.
28 (xg_uses_old_file_dialog): Add suggested const attribute.
30 2012-07-15 Eli Zaretskii <eliz@gnu.org>
32 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
33 (bidi_paragraph_init): Use it to limit search forward for a strong
34 directional character in abnormally large paragraphs full of
35 neutral or weak characters. (Bug#11943)
37 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
39 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
40 the toolbar (Bug#9451).
41 (xg_make_tool_item): Give the widget event box a transparent
44 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
46 Cleanup basic allocation variables and functions.
47 * alloc.c (ignore_warnings, init_intervals, init_float)
48 (init_cons, init_symbol, init_marker): Remove.
49 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
50 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
51 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
52 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
53 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
54 (staticidx, init_alloc_once, init_strings, free_ablock):
55 Remove redundant initialization.
56 * fns.c (init_weak_hash_tables): Remove.
57 * lisp.h (init_weak_hash_tables): Remove prototype.
59 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
61 Use zero_vector where appropriate.
62 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
64 * lisp.h (zero_vector): New declaration.
65 * font.c (null_vector): Remove.
66 (syms_of_font): Remove initialization and staticpro.
67 (font_list_entities, font_find_for_lface): Change to use zero_vector.
68 * keymap.c (Faccessible_keymaps): Likewise.
70 2012-07-15 Leo Liu <sdl.web@gmail.com>
72 * fringe.c: Fix typo in comments.
74 2012-07-14 Leo Liu <sdl.web@gmail.com>
76 * fringe.c: Add a new bitmap exclamation-mark.
78 2012-07-14 Eli Zaretskii <eliz@gnu.org>
80 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
82 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
83 (HAVE_MENUS): Don't define, defined by editing config.in with
85 (GMALLOC_INHIBIT_VALLOC): Don't define.
86 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
88 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
90 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
92 2012-07-14 Glenn Morris <rgm@gnu.org>
94 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
95 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
96 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
98 2012-07-13 Glenn Morris <rgm@gnu.org>
100 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
102 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
103 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
105 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
107 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
108 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
109 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
110 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
112 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
113 as boolean expression.
114 (x_set_window_size): Remove unused variable toolbar.
115 (ns_get_color_default, ns_mod_to_lisp): Remove.
116 (ns_mouse_position): Remove unused variables xchar and ychar.
117 (ns_compute_glyph_string_overhangs): Remove unused variable face.
118 (ns_set_vertical_scroll_bar): Remove unused variable count.
119 (ns_delete_terminal): Remove unused variable i.
120 (ns_term_init): Remove unused variables r, g and b.
121 (mouseDown): Remove unused variable window.
122 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
123 (initFrameFromEmacs): Remove unused variable vbextra.
124 (mouseEntered): Remove unused variables p and dpyinfo.
125 (mouseExited): Remove unused variables p and r.
126 (ns_define_frame_cursor, ns_clear_frame_area)
127 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
128 (menuDown): Assign [sender tag] to variable and cast the variable.
130 * nsterm.h (menuDown): Add id as type to argument sender.
131 (ns_display_info_for_name): Add Lisp_Object argument.
132 (ns_term_init): Add Lisp_Object argument.
133 (ns_map_event_to_object): Add void argument.
134 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
135 prototype with arguments and only declare if __OBJC__.
136 (nxatoms_of_nsselect): Add void argument.
137 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
138 (ns_alloc_autorelease_pool): Add void argument.
139 (ns_release_autorelease_pool): Add void* argument.
140 (ns_get_defaults_value): Add const char* argument.
142 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
143 (initFromContents): Use SSDATA where appropriate.
144 (ns_update_menubar): Add braces to ambigous if-else.
145 (initWithTitle): Put () around assignment in if statement.
146 (ns_menu_show): Remove unused variables window and keymap.
147 (update_frame_tool_bar): Remove unused variable selected_p.
148 (initWithContentRect): Remove unused variable this_cmd_name.
150 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
152 (setXBMColor): Remove unused variable len.
153 (setPixmapData): Put () around assignment in loop statement.
155 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
156 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
158 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
159 around assignment in loop statement.
160 (nsfont_open): Remove unused variable i.
161 (nsfont_open): Remove unused variable len.
162 (nsfont_draw): Remove unused variable cs.
164 * nsfns.m (x_set_icon_name, ns_set_name_internal)
165 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
166 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
167 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
168 (Fns_font_name, Fns_perform_service)
169 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
170 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
171 (ns_set_name): Remove unused variable view.
172 (x_set_menu_bar_lines): Remove unused variable olines.
173 (x_set_tool_bar_lines): Remove unused variable root_window.
174 (Fns_list_colors): Put () around assignment in while statement.
175 (Fns_perform_service): Remove unused variable len.
176 (Fns_display_usable_bounds): Remove unused variable top.
177 (syms_of_nsfns): Remove unused variable i.
179 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
182 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
184 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
185 and free it with DestroyExceptionInfo (Bug#11558).
187 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
189 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
190 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
191 Set here, not in nt/config.nt.
193 2012-07-13 Eli Zaretskii <eliz@gnu.org>
195 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
196 cursor overflow into the last glyph on display line when the right
197 fringe is off. (Bug#11832)
199 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
201 * xdisp.c (produce_special_glyphs): Now static.
202 * dispextern.h (produce_special_glyphs): Remove decl.
204 2012-07-13 Glenn Morris <rgm@gnu.org>
206 * s/bsd-common, s/cygwin.h: Remove empty files.
207 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
209 * s/usg5-4-common.h (USG, USG5):
210 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
211 * s/sol2-6.h (SOLARIS2):
212 * s/irix6-5.h (IRIX6_5):
213 * s/hpux10-20.h (USG, USG5, HPUX):
214 * s/gnu-linux.h (USG, GNU_LINUX):
215 * s/freebsd.h (BSD_SYSTEM):
216 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
217 * s/cygwin.h (CYGWIN):
218 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
219 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
221 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
223 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
225 2012-07-13 Glenn Morris <rgm@gnu.org>
227 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
229 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
231 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
232 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
234 2012-07-12 Glenn Morris <rgm@gnu.org>
236 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
238 * process.c (init_process_emacs): Rename from init_process.
239 The old name is also the name of a Mach system call.
240 * lisp.h, emacs.c: Update for this name change.
241 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
244 2012-07-12 Eli Zaretskii <eliz@gnu.org>
246 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
247 memmove call that removes glyphs covered by the left truncation
248 glyph. Improve commentary.
249 (display_line): Fix display of continuation glyphs on GUI frames
250 when the right fringe is turned off and variable-size fonts are
251 used in the window. Move the code that appends a stretch glyph to
252 produce_special_glyphs, so that it could be used for truncation
253 and continuation glyphs alike.
254 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
255 glyph of a suitably computed width, to align the special glyphs at
256 the window margin. Code moved from display_line. (Bug#11832)
258 2012-07-12 Glenn Morris <rgm@gnu.org>
260 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
262 * s/gnu-linux.h, s/hpux10-20.h:
263 Do not unconditionally define HAVE_XRMSETDATABASE.
265 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
267 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
269 Fix typos that broke OS X build.
270 Reported by Randal L. Schwartz in
271 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
272 * nsterm.m (ns_timeout): Add missing local decl.
273 (ns_get_color): snprintf -> sprintf, to fix typo.
275 2012-07-12 Glenn Morris <rgm@gnu.org>
277 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
278 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
279 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
280 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
282 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
283 Move PTY_OPEN to configure.
285 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
286 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
287 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
289 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
291 Use empty_unibyte_string where applicable.
292 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
293 * lread.c (read1): Likewise.
294 * xsettings.c (syms_of_xsettings): Likewise.
296 2012-07-12 Glenn Morris <rgm@gnu.org>
298 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
299 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
300 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
301 * s/hpux10-20.h (RUN_TIME_REMAP):
302 * s/bsd-common.h (TABDLY): Move to configure.
304 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
306 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
308 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
309 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
311 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
313 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
314 * s/template.h: Move NARROWPROTO to configure.
316 2012-07-11 Glenn Morris <rgm@gnu.org>
318 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
319 unused since 2011-01-17 change to systty.h.
321 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
322 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
323 Move HAVE_PTYS and HAVE_SOCKETS to configure.
325 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
327 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
329 2012-07-11 Glenn Morris <rgm@gnu.org>
331 * s/darwin.h, s/gnu-linux.h, s/template.h:
332 Move INTERRUPT_INPUT to configure.
334 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
336 Minor adjustments to interning code.
337 * lisp.h (intern, intern_c_string): Redefine as static inline
338 wrappers for intern_1 and intern_c_string_1, respectively.
339 (intern_1, intern_c_string_1): Rename prototypes.
340 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
342 * font.c (font_intern_prop): Likewise. Adjust comment.
343 * w32font.c (intern_font_name): Likewise.
345 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
347 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
349 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
350 of Fcar/Fcdr if possible.
351 * font.c (check_otf_features): Likewise.
352 * fontset.c (Fnew_fontset): Likewise.
353 * gnutls.c (Fgnutls_boot): Likewise.
354 * minibuf.c (read_minibuf): Likewise.
355 * msdos.c (IT_set_frame_parameters): Likewise.
356 * xmenu.c (Fx_popup_dialog): Likewise.
357 * w32menu.c (Fx_popup_dialog): Likewise.
359 2012-07-11 Glenn Morris <rgm@gnu.org>
361 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
362 since nothing has defined it on these platforms.
364 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
365 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
367 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
368 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
369 Move CLASH_DETECTION to configure.
371 * s/gnu.h: Remove file, which is now empty.
373 * s/gnu.h, s/gnu-linux.h:
374 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
376 2012-07-11 John Wiegley <johnw@newartisans.com>
378 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
379 function attribute, so we only use it if it exists in the
382 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
384 Avoid call to strlen in fast_c_string_match_ignore_case.
385 * search.c (fast_c_string_match_ignore_case): Change to use
386 length argument. Adjust users accordingly.
387 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
389 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
392 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
393 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
396 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
399 * s/hpux10-20.h (HAVE_PERROR): Remove.
400 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
401 Remove dummy definition, as this problem was obsolete long ago.
404 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
406 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
408 Avoid calls to strlen in font processing functions.
409 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
410 (font_open_by_name): Change to use length argument. Adjust
412 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
414 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
415 Change to return ptrdiff_t.
416 (xfont_list_pattern, xfont_match): Use length returned by
417 xfont_decode_coding_xlfd.
418 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
420 2012-07-11 Glenn Morris <rgm@gnu.org>
422 * s/darwin.h, s/freebsd.h, s/netbsd.h:
423 Move DONT_REOPEN_PTY to configure.
425 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
426 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
428 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
430 Remove "#define unix" that is no longer needed (Bug#11905).
431 * s/aix4-2.h (unix): Remove; no longer needed.
433 EMACS_TIME simplification (Bug#11875).
434 This replaces macros (which typically do not work in GDB)
435 with functions, typedefs and enums, making the code easier to debug.
436 The functional style also makes code easier to read and maintain.
437 * systime.h: Include <sys/time.h> on all hosts, not just if
438 WINDOWSNT, since 'struct timeval' is needed in general.
439 (EMACS_TIME): Now a typedef, not a macro.
440 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
442 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
443 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
444 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
445 (EMACS_TIME_LE): Now functions, not macros.
446 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
447 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
448 which are not functions. All uses rewritten to use:
449 (make_emacs_time): New function.
450 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
451 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
452 not functions. All uses rewritten to use the following, respectively:
453 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
454 (add_emacs_time, sub_emacs_time): New functions.
455 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
456 * fileio.c (Fcopy_file):
457 * xterm.c (XTflash): Get the current time closer to when it's used.
458 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
460 * bytecode.c (targets): Suppress -Woverride-init warnings.
462 Simplify by avoiding confusing use of strncpy etc.
463 * doc.c (Fsnarf_documentation):
464 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
465 * frame.c (Fmake_terminal_frame):
466 * gtkutil.c (get_utf8_string):
468 * nsmenu.m (ns_update_menubar):
469 * regex.c (regerror):
470 Prefer memcpy to strncpy and strncat when either will do.
471 * fileio.c (Fsubstitute_in_file_name):
472 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
473 (menu_separator_name_p):
474 * nsmenu.m (ns_update_menubar):
475 Prefer memcmp to strncmp when either will do.
476 * nsterm.m: Include <ftoastr.h>.
478 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
479 Prefer snprintf to strncpy.
480 * nsterm.m (ns_term_init):
481 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
482 * nsterm.m (ns_term_init):
483 Avoid the need for strncpy, by using build_string or
484 make_unibyte_string directly. Use dtoastr, not snprintf.
485 * process.c (Fmake_network_process): Diagnose service names that
486 are too long, rather than silently truncating them or creating
487 non-null-terminated names.
488 (Fnetwork_interface_info): Likewise, for interface names.
489 * sysdep.c (system_process_attributes) [GNU_LINUX]:
490 Prefer sprintf to strncat.
491 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
492 Prefer vsnprintf to vsprintf + strncpy.
494 2012-07-10 Glenn Morris <rgm@gnu.org>
496 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
497 Clarify fallback case.
499 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
501 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
502 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
503 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
504 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
505 where argument type is known to be a Lisp_Cons.
507 2012-07-10 Tom Tromey <tromey@redhat.com>
509 * bytecode.c (BYTE_CODE_THREADED): New macro.
510 (BYTE_CODES): New macro. Replaces all old byte-code defines.
511 (enum byte_code_op): New type.
512 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
513 (exec_byte_code): Use them. Use token threading when applicable.
515 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
517 Optimize pure C strings initialization.
518 * lisp.h (make_pure_string): Fix prototype.
519 (build_pure_c_string): New function, defined as static inline. This
520 provides a better opportunity to optimize away calls to strlen when
521 the function is called with compile-time constant argument.
522 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
523 argument, adjust users accordingly. Use build_pure_c_string where
525 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
526 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
527 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
529 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
531 Avoid calls to strlen in miscellaneous functions.
532 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
533 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
534 * lread.c (openp): Likewise.
536 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
538 Avoid calls to strlen in path processing functions.
539 * fileio.c (file_name_as_directory): Add comment. Change to add
540 srclen argument and return the length of result. Adjust users
542 (directory_file_name): Fix comment. Change to add srclen argument,
543 swap 1st and 2nd arguments to obey the common convention. Adjust
545 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
547 2012-07-10 Glenn Morris <rgm@gnu.org>
549 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
550 Move PENDING_OUTPUT_COUNT definition to configure.
552 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
553 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
554 * s/gnu.h (DATA_START): Move definitions to configure.
556 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
557 We include usg5-4-common.h, which defines them both.
559 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
560 O_RDONLY already includes it).
562 Stop ns builds setting the EMACSLOADPATH environment variable.
563 * nsterm.m (ns_load_path): Rename from ns_init_paths.
564 Now it does not set EMACSLOADPATH, just returns the load-path string.
565 * nsterm.h: Update accordingly.
566 * lread.c [HAVE_NS]: Include nsterm.h.
567 (init_lread) [HAVE_NS]: Use ns_load_path.
568 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
570 2012-07-09 Glenn Morris <rgm@gnu.org>
572 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
573 since the included bsd-common.h does so.
575 Stop ns builds setting the EMACSPATH environment variable.
576 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
577 (ns_init_paths): Do not set EMACSPATH.
578 * nsterm.h (ns_exec_path): Add it.
579 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
582 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
584 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
586 * process.c (wait_reading_process_output): 'waitchannels' was unset
587 when read_kbd || !NILP (wait_for_cell); fix this.
589 Add GCC-style 'const' attribute to functions that can use it.
590 * character.h (char_resolve_modifier_mask):
591 * keyboard.h (make_ctrl_char):
592 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
593 (init_character_once, next_almost_prime, init_fns, init_image)
594 (flush_pending_output, init_sound):
595 * mem-limits.h (start_of_data):
596 * menu.h (finish_menu_items):
598 * emacs.c (DEFINE_DUMMY_FUNCTION):
599 Declare the dummy function with ATTRIBUTE_CONST.
600 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
601 Add decls with ATTRIBUTE_CONST.
603 Minor improvements to make_formatted_string.
604 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
605 where int is good enough, as vsprintf returns an int.
606 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
608 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
610 Use make_formatted_string to avoid double length calculation.
611 * lisp.h (make_formatted_string): New prototype.
612 * alloc.c (make_formatted_string): New function.
613 * buffer.c (Fgenerate_new_buffer_name): Use it.
614 * dbus.c (syms_of_dbusbind): Likewise.
615 * editfns.c (Fcurrent_time_zone): Likewise.
616 * filelock.c (get_boot_time): Likewise.
617 * frame.c (make_terminal_frame, set_term_frame_name)
618 (x_report_frame_params): Likewise.
619 * image.c (gs_load): Likewise.
620 * minibuf.c (get_minibuffer): Likewise.
621 * msdos.c (dos_set_window_size): Likewise.
622 * process.c (make_process): Likewise.
623 * xdisp.c (ensure_echo_area_buffers): Likewise.
624 * xsettings.c (apply_xft_settings): Likewise.
626 2012-07-09 Glenn Morris <rgm@gnu.org>
628 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
629 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
630 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
631 * nsterm.h (ns_etc_directory): Add it.
632 * callproc.c [HAVE_NS]: Include nsterm.h.
633 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
635 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
637 Move marker debugging code under MARKER_DEBUG.
638 * marker.c (MARKER_DEBUG): Move marker debugging code under
639 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
640 for bootstrap with --enable-checking (~3x slowdown reported
641 by Juanma Barranquero <lekktu@gmail.com>).
642 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
644 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
646 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
647 See <http://bugs.gnu.org/11825#29>.
649 2012-07-08 Eli Zaretskii <eliz@gnu.org>
651 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
652 has no font, use the frame's font. (Bug#11813)
653 (display_line): Add commentary about displaying truncation glyphs
655 (produce_special_glyphs): Move here from term.c.
657 * term.c (produce_special_glyphs): Move to xdisp.c.
659 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
662 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
664 * xdisp.c (display_line): Avoid warning about implicit declaration
667 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
669 * lisp.h: Remove empty conditional.
671 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
673 * lread.c (load_path_check): Now static.
675 Fix some minor --with-ns problems found by static checking.
676 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
677 (x_set_font) [!HAVE_X_WINDOWS]:
678 * image.c (xpm_load_image) [HAVE_NS]:
679 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
680 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
682 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
683 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
684 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
685 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
686 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
687 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
688 Fix pointer signedness problem.
689 * xfaces.c (FRAME_X_FONT_TABLE):
690 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
692 2012-07-07 Glenn Morris <rgm@gnu.org>
694 * lread.c (load_path_check): New function, split from init_lread.
695 (init_lread): Reorganize. Motivation:
696 If EMACSLOADPATH is set, check/warn about that rather than the
697 defaults, which we are not going to use. Hence we can remove
698 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
699 Don't warn if site-lisp directories are missing.
700 If not installed, start from a blank load-path, since
701 PATH_LOADSEARCH refers to the eventual installation directories.
703 2012-07-07 Eli Zaretskii <eliz@gnu.org>
705 Support truncation and continuation glyphs on GUI frames, when
706 fringes are disabled. (Bug#11832)
707 * xdisp.c (init_iterator): Get dimensions of truncation and
708 continuation glyphs even if on GUI frames. Adjust
709 it->last_visible_x on GUI frames when the left or right fringes,
711 (start_display, move_it_in_display_line_to): Handle the case of a
712 GUI frame without a fringe to display continuation or truncation
714 (insert_left_trunc_glyphs): Support GUI frames: make sure
715 truncation glyphs overwrite enough glyphs from the current line to
716 have sufficient space in pixels.
717 (display_line): Support truncation and continuation glyphs on GUI
718 frames. If some spare pixels are left on the line after inserting
719 the truncation glyphs, fill that space with a stretch glyph of a
720 suitably computed width.
722 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
723 produce_glyphs, to support GUI sessions.
725 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
727 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
729 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
731 Do not require float-time's arg to fit in time_t (Bug#11825).
732 This works better on hosts where time_t is unsigned, and where
733 float-time is applied to the (negative) difference between two times.
734 * editfns.c (decode_time_components): Last arg is now double *,
735 not int *, and means to store all the result as a double, without
736 worrying about whether the seconds part fits in time_t.
738 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
740 (Ffloat_time): Do not fail merely because the specified time falls
741 outside of time_t range.
743 2012-07-07 Glenn Morris <rgm@gnu.org>
745 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
746 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
747 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
749 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
751 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
754 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
756 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
758 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
759 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
760 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
761 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
762 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
763 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
765 * xfont.c (compare_font_names): Redo to omit the need for casts.
767 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
769 * xfns.c (Fx_change_window_property): Doc fix.
770 * w32fns.c (Fx_change_window_property): Doc fix.
772 * w32fns.c (Fx_window_property): Accept the same arguments as the
773 X Windows version. Doc fix.
774 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
776 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
777 Eli Zaretskii <eliz@gnu.org>
779 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
780 Windows-specific code from nt/config.nt moved here.
781 Obsolete settings removed.
783 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
785 * process.c: Avoid unnecessary calls to gettime.
786 (wait_reading_process_output): Don't get the time of day
787 when gobbling data immediately and not waiting, as there's no need
788 for it in that case. This removes a FIXME.
790 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
792 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
793 is defined (Bug#11768).
795 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
797 Fix marker debugging code.
798 * marker.c (byte_char_debug_check): Do not perform the check
799 if buffer is not multibyte.
800 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
801 Call byte_char_debug_check with correct arguments.
803 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
805 Compile marker debugging code only if ENABLE_CHECKING is defined.
806 * marker.c (byte_char_debug_check, count_markers):
807 Use only if ENABLE_CHECKING is defined.
808 (byte_debug_flag): Remove.
809 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
810 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
812 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
814 Avoid code repetition in marker-related functions.
815 * marker.c (attach_marker): New function.
816 (Fset_marker, set_marker_restricted, set_marker_both)
817 (set_marker_restricted_both): Use it.
818 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
819 Consistently rename charno to charpos.
820 (marker_position): Add eassert.
821 (marker_byte_position): Convert to eassert.
823 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
825 Simplify list operations in unchain_overlay and unchain_marker.
826 * buffer.c (unchain_overlay): Simplify. Add comment.
827 * marker.c (unchain_marker): Simplify. Fix comments.
829 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
831 Introduce fast path for the widely used marker operation.
832 * alloc.c (build_marker): New function.
833 * lisp.h (build_marker): New prototype.
834 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
835 * composite.c (autocmp_chars): Likewise.
836 * editfns.c (buildmark): Remove.
837 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
838 (save_restriction_save): Use build_marker.
839 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
840 * window.c (save_window_save): Likewise.
842 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
844 Do not use Fdelete_overlay in delete_all_overlays
845 to avoid redundant calls to unchain_overlay.
846 * buffer.c (drop_overlay): New function.
847 (delete_all_overlays, Fdelete_overlay): Use it.
848 * minibuf.c (get_minibuffer): Fix comment.
850 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
852 Port to OpenBSD 5.1 amd64.
853 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
854 This is needed for OpenBSD, and should be harmless on all BSD systems.
855 Also, include <sys/sysctl.h>, as it should be available on all
856 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
857 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
858 use p_pid member, not kp_proc.pid.
860 2012-07-06 Glenn Morris <rgm@gnu.org>
862 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
864 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
866 More xmalloc and related cleanup.
867 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
868 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
869 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
870 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
871 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
872 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
873 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
874 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
875 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
877 Omit needless casts involving void * pointers and allocation.
878 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
879 as the former is more robust if P's type is changed.
880 Prefer xzalloc to xmalloc + memset 0.
881 Simplify malloc-or-realloc to realloc.
882 Don't worry about xmalloc returning a null pointer.
883 Prefer xstrdup to xmalloc + strcpy.
884 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
886 * keyboard.c (apply_modifiers_uncached): Prefer local array to
887 alloca of a constant.
889 2012-07-05 Eli Zaretskii <eliz@gnu.org>
891 * xdisp.c (display_line): Fix horizontal pixel coordinates when
892 hscroll is larger than the line width. Fixes long and futile
893 looping inside extend_face_to_end_of_line (on a TTY) producing
894 glyphs that are not needed and thrown away.
896 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
898 * marker.c (set_marker_restricted_both): Simplify by using
901 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
903 * editfns.c (region_limit): Simplify by using clip_to_bounds.
905 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
907 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
908 not defined (Bug#11768).
909 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
910 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
911 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
912 followed by gtk_box_set_homogeneous (Bug#11768).
913 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
914 (update_theme_scrollbar_width, xg_create_scroll_bar):
915 Use gtk_scrollbar_new (Bug#11768).
916 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
917 (is_box_type): New function (Bug#11768).
918 (xg_tool_item_stale_p): Call is_box_type.
919 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
920 with default display (Bug#11768).
922 2012-07-05 Eli Zaretskii <eliz@gnu.org>
924 * xdisp.c (window_hscroll_limited): New function.
925 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
926 coordinates when window's hscroll is set to insanely large
929 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
931 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
932 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
934 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
937 * lisp.h (xzalloc): New prototype. Omit needless casts.
938 * alloc.c (xzalloc): New function. Omit needless casts.
939 * charset.c: Omit needless casts. Convert all calls to
940 xmalloc with following memset to xzalloc.
941 * dispnew.c: Likewise.
942 * fringe.c: Likewise.
946 * w32fns.c: Likewise.
947 * w32font.c: Likewise.
948 * w32term.c: Likewise.
949 * xfaces.c: Likewise.
952 * atimer.c: Omit needless casts.
953 * buffer.c: Likewise.
954 * callproc.c: Likewise.
956 * coding.c: Likewise.
957 * composite.c: Likewise.
959 * doprnt.c: Likewise.
960 * editfns.c: Likewise.
963 * filelock.c: Likewise.
965 * gtkutil.c: Likewise.
966 * keyboard.c: Likewise.
969 * minibuf.c: Likewise.
972 * process.c: Likewise.
973 * region-cache.c: Likewise.
974 * search.c: Likewise.
975 * sysdep.c: Likewise.
976 * termcap.c: Likewise.
977 * terminal.c: Likewise.
978 * tparam.c: Likewise.
979 * w16select.c: Likewise.
981 * w32reg.c: Likewise.
982 * w32select.c: Likewise.
983 * w32uniscribe.c: Likewise.
984 * widget.c: Likewise.
988 * xselect.c: Likewise.
990 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
992 * fileio.c (time_error_value): Check the right error number.
993 Problem reported by Troels Nielsen in
994 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
996 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
998 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
999 This should be fixed in a better way; see Eli Zaretskii in
1000 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1001 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1003 * fileio.c (time_error_value): Rename from special_mtime.
1004 The old name's problems were noted by Eli Zaretskii in
1005 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1007 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1008 This variable's comment says Emacs needs at least one GDB-visible
1009 symbol of type enum pvec_type, to work around GDB problems.
1010 The symbol's value doesn't matter.
1012 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1013 that causes compilation to fail on pre-C99 compilers.
1015 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
1017 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1018 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1020 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1022 * buffer.c (init_buffer_once): Fix initialization of
1023 headers for buffer_defaults and buffer_local_symbols.
1024 Reported by Juanma Barranquero <lekktu@gmail.com>.
1026 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1028 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1029 * lisp.h (enum pvec_type): Use fewer bits.
1030 (PSEUDOVECTOR_SIZE_BITS): New constant.
1031 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1032 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1033 change in pvec_type.
1034 (PSEUDOVECTOR_TYPEP): New macro.
1035 (TYPED_PSEUDOVECTORP): Use it.
1036 * fns.c (internal_equal): Adapt code to extract pvectype.
1037 * emacs.c (gdb_pvec_type): Update type.
1038 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1039 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1040 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1041 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1042 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1043 abusing vector->header.next.nbytes.
1044 (live_vector_p): Use PVEC_TYPE.
1045 (mark_object): Adapt code to extract pvectype. Use switch.
1047 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1049 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1050 Tighten new eassert a bit.
1052 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1054 Fix compilation with --enable-gcc-warnings and -O1
1056 * doprnt.c (doprnt): Change type of tem to int, initialize
1057 to avoid compiler warning. Add eassert.
1058 * search.c (simple_search): Initialize match_byte to avoid
1059 compiler warning. Add eassert.
1061 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1063 Avoid weird behavior with large horizontal scrolls.
1064 Without this change, for example, large hscroll values would
1065 mess up Emacs's display on Fedora 15 x86, presumably due to
1066 overflows in int calculations in the display code.
1067 Also, if buffers had long lines, Emacs would freeze.
1068 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1069 (set_window_hscroll): New function, containing the old guts of
1070 Fset_window_hscroll. Return the clipped value.
1071 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1072 This avoids the need to check against PTRDIFF_MAX.
1074 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1076 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1078 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1080 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1082 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1083 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1084 since GCC 4.4.6 issues a bogus warning for them.
1086 Fix bugs in file timestamp newness comparisons.
1087 * fileio.c (Ffile_newer_than_file_p):
1088 * lread.c (Fload): Use full timestamp resolution of files,
1089 not just the 1-second resolution, so that files that are only
1090 slightly newer still count as newer.
1091 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1092 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1094 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1096 * fileio.c: Improve handling of file time marker. (Bug#11852)
1097 (special_mtime): New function.
1098 (Finsert_file_contents, Fverify_visited_file_modtime):
1099 Use it to set special mtime values consistently.
1101 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1103 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1104 marker for non-existing file. (Bug#11852)
1106 2012-07-03 Glenn Morris <rgm@gnu.org>
1108 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1109 and did not make it into globals.h).
1111 2012-07-03 Tom Tromey <tromey@redhat.com>
1113 * window.c (Fset_window_margins, Fset_window_fringes)
1114 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1115 * textprop.c (Fprevious_property_change): No longer static.
1116 * syntax.c (Fsyntax_table_p): No longer static.
1117 * process.c (Fget_process, Fprocess_datagram_address): No longer
1119 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1120 * keyboard.c (Fcommand_execute): No longer static.
1122 * insdel.c (Fcombine_after_change_execute): No longer static.
1123 * image.c (Finit_image_library): No longer static.
1124 * fileio.c (Fmake_symbolic_link): No longer static.
1125 * eval.c (Ffetch_bytecode): No longer static.
1126 * editfns.c (Fuser_full_name): No longer static.
1127 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1129 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1131 * dired.c (Ffile_attributes): No longer static.
1132 * composite.c (Fcomposition_get_gstring): No longer static.
1133 * callproc.c (Fgetenv_internal): No longer static.
1135 * ccl.h: Remove EXFUNs.
1136 * buffer.h: Remove EXFUNs.
1137 * dispextern.h: Remove EXFUNs.
1138 * intervals.h: Remove EXFUNs.
1139 * fontset.h: Remove EXFUN.
1140 * font.h: Remove EXFUNs.
1141 * dosfns.c (system_process_attributes): Remove EXFUN.
1142 * keymap.h: Remove EXFUNs.
1143 * lisp.h: Remove EXFUNs.
1144 * w32term.h: Remove EXFUNs.
1145 * window.h: Remove EXFUNs.
1146 * xsettings.h: Remove EXFUN.
1147 * xterm.h: Remove EXFUN.
1149 2012-07-03 Glenn Morris <rgm@gnu.org>
1151 * lisp.h (Frandom): Make it visible to C.
1152 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1153 buffer for invisible buffers. (Bug#1229)
1155 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1157 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1158 values which aren't power of 2.
1159 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1160 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1163 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1165 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1167 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1169 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1171 * alloc.c (allocate_vector_block): Remove redundant
1172 calls to mallopt if DOUG_LEA_MALLOC is defined.
1173 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1174 avoid calls to mallopt if zero_vector is returned.
1176 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1178 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1179 is enabled, avoid dereferencing NULL current_sblock if
1182 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1184 Cleanup basic buffer management.
1185 * buffer.h (struct buffer): Change layout to use generic vector
1186 marking code. Fix some comments. Change type of 'clip_changed'
1187 to bitfield. Remove unused #ifndef old.
1188 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1189 (GET_OVERLAYS_AT): Fix indentation.
1190 (for_each_per_buffer_object_at): New macro.
1191 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1192 (Fbuffer_local_variables): Use it.
1193 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1194 * alloc.c (allocate_buffer): Adjust to match new layout of
1195 struct buffer. Fix comment.
1196 (mark_overlay): New function.
1197 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1198 Lisp area of struct buffer.
1199 (mark_object): Use it. Adjust marking of misc objects
1200 and related comments.
1202 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1204 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1205 wrapper that is not needed because the wrapped code is a no-op (zero
1206 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1207 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1209 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1211 * alloc.c (mark_buffer): Simplify. Remove prototype.
1212 (mark_object): Add comment. Reorganize marking of vector-like
1213 objects. Use CHECK_LIVE for all vector-like objects except buffers
1214 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1215 redundant calls to mark_vectorlike for bool vectors.
1217 2012-06-30 Glenn Morris <rgm@gnu.org>
1219 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1221 * epaths.in (PATH_SITELOADSEARCH): New.
1222 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1223 This is rather than relying on --enable-locallisppath elements
1224 having "site-lisp" in their names. (Bug#10208#25, 11658)
1226 2012-06-30 Eli Zaretskii <eliz@gnu.org>
1228 * w32proc.c (sys_select): Accept and ignore one more argument.
1230 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1232 * sysselect.h [DOS_NT]: Don't include sys/select.h.
1233 (pselect) [!MS_DOS]: Redirect to sys_select.
1235 * sysdep.c: Don't include dos.h and dosfns.h.
1237 * process.c (sys_select):
1238 * msdos.c (sys_select): Accept one more argument and ignore it.
1240 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1241 adapt data types and code to that.
1244 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1245 which clashes with the gnulib function of the same name.
1247 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1249 * font.c (font_style_to_value, font_style_symbolic)
1250 (font_prop_validate_style): Add type checks for values in
1253 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1255 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1258 2012-06-29 Eli Zaretskii <eliz@gnu.org>
1260 * xdisp.c (try_window_id): Undo last change.
1262 * w32.c (getwd): Adjust commentary about startup_dir.
1263 (init_environment): Always call sys_access, even in non-MSVC
1264 builds. Don't chdir to the directory of the Emacs executable.
1265 This undoes code from 1997 which was justified by the need to
1266 "avoid conflicts when removing and renaming directories". But its
1267 downside was that every relative file name was being interpreted
1268 relative to the directory of the Emacs executable, which can never
1269 be TRT. In particular, it broke sys_access when called with
1270 relative file names.
1271 (sys_access): Map GetLastError to errno.
1273 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1275 * window.h (struct window): Change type of 'fringes_outside_margins'
1276 to bitfield. Fix comment. Adjust users accordingly.
1277 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
1279 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1282 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
1284 * gnutls.c (emacs_gnutls_handshake):
1285 Add QUIT to make the loop interruptible.
1287 2012-06-29 Glenn Morris <rgm@gnu.org>
1289 * charset.c (init_charset): Make lack of etc/charsets fatal.
1291 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1293 * editfns.c (region_limit): Fix type mismatch.
1295 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1297 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1298 undefined. Convert from xassert to eassert.
1299 * nsmenu.m: Convert from xassert to eassert.
1300 * nsterm.m: Likewise.
1302 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1304 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1306 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1308 Avoid integer overflow on scroll-left and scroll-right.
1309 * window.c (HSCROLL_MAX): New macro.
1310 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1311 overflow when requested scroll falls outside ptrdiff_t range.
1313 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1315 * window.h (struct window): Change type of 'hscroll',
1316 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1317 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1318 Adjust users accordingly.
1319 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1320 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1321 from EMACS_INT to ptrdiff_t.
1322 (make_window): Omit redundant initialization.
1324 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
1326 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1328 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1330 * window.h (struct window): Change type of 'use_time' and
1331 'sequence_number' from Lisp_Object to int.
1332 * frame.c (make_frame): Adjust users accordingly.
1333 * print.c (print_object): Likewise.
1334 * window.c (select_window, Fwindow_use_time, make_parent_window)
1335 (make_window): Likewise.
1337 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1339 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1340 enabled with --enable-checking=[all,glyphs] configure option.
1341 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1342 adjust comments accordingly.
1343 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1344 undefined, adjust comments accordingly.
1345 * image.c: Likewise.
1346 * scroll.c: Likewise.
1347 * w32fns.c: Likewise.
1348 * w32term.c: Likewise.
1349 * xdisp.c: Likewise.
1350 * xfaces.c: Likewise.
1352 * xterm.c: Likewise.
1354 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1356 Generalize run-time debugging checks.
1357 * dispextern.h (XASSERTS): Remove.
1358 * fontset.c (xassert): Remove.
1359 Convert from xassert to eassert.
1360 * alloc.c: Convert from xassert to eassert.
1362 * dispnew.c: Likewise.
1364 * fringe.c: Likewise.
1365 * ftfont.c: Likewise.
1366 * gtkutil.c: Likewise.
1367 * image.c: Likewise.
1368 * keyboard.c: Likewise.
1370 * process.c: Likewise.
1371 * scroll.c: Likewise.
1372 * sound.c: Likewise.
1374 * w32console.c: Likewise.
1375 * w32fns.c: Likewise.
1376 * w32term.c: Likewise.
1377 * window.c: Likewise.
1378 * xdisp.c: Likewise.
1379 * xfaces.c: Likewise.
1381 * xselect.c: Likewise.
1382 * xterm.c: Likewise.
1384 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1386 * fns.c (maybe_resize_hash_table): Output message when growing the
1389 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1391 * alloc.c (allocate_string_data): Remove dead code.
1392 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1393 avoid GCC warning about unused macro.
1395 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1397 * alloc.c (allocate_string): Omit intervals initialization.
1398 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1399 as in make_pure_string and make_pure_c_string.
1401 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1403 * alloc.c (allocate_string): Fix last change.
1405 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1407 * alloc.c (allocate_string): Remove two redundant calls
1408 to memset, add explicit initialization where appropriate.
1410 2012-06-27 Glenn Morris <rgm@gnu.org>
1412 * lisp.mk (lisp): Remove paths.elc.
1414 2012-06-27 Chong Yidong <cyd@gnu.org>
1416 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1418 2012-06-26 John Wiegley <johnw@newartisans.com>
1420 * unexmacosx.c (copy_data_segment): Add two section names used
1421 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1423 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1424 when building with Clang.
1426 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1428 * eval.c (Fapply): Allow calling it with a single argument.
1430 2012-06-26 Eli Zaretskii <eliz@gnu.org>
1432 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1433 _stricmp and _strnicmp.
1434 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1436 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1438 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1440 (allocate_process): Likewise for new process.
1441 (allocate_terminal): Change to use offsetof.
1442 (allocate_frame): Likewise.
1443 * frame.c (make_frame): Omit redundant initialization.
1444 * window.c (make_parent_window): Use memset.
1445 (make_window): Omit redundant initialization.
1446 * process.c (make_process): Omit redundant initialization.
1447 * terminal.c (create_terminal): Likewise.
1449 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1451 * term.c (delete_tty): Remove redundant call to memset.
1453 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1455 * alloc.c: Remove build_string.
1456 * lisp.h: Define build_string as static inline. This provides
1457 a better opportunity to optimize away calls to strlen when the
1458 function is called with compile-time constant argument.
1459 * image.c (imagemagick_error): Convert to build_string.
1460 * w32proc.c (sys_spawnve): Likewise.
1461 * xterm.c (x_term_init): Likewise.
1463 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1465 Use sprintf return value instead of invoking strlen on result.
1466 In the old days this wasn't portable, since some sprintf
1467 implementations returned char *. But they died out years ago and
1468 Emacs already assumes sprintf returns int.
1469 Similarly for float_to_string.
1470 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1471 * ccl.c (ccl_driver):
1472 * character.c (string_escape_byte8):
1473 * data.c (Fnumber_to_string):
1474 * doprnt.c (doprnt):
1475 * print.c (print_object):
1476 * xdisp.c (message_dolog):
1477 * xfns.c (syms_of_xfns):
1478 Use sprintf or float_to_string result to avoid need to call strlen.
1479 * data.c (Fnumber_to_string):
1480 Use make_unibyte_string, since the string must be ASCII.
1481 * lisp.h, print.c (float_to_string): Now returns int length.
1482 * term.c (produce_glyphless_glyph):
1483 Use sprintf result rather than recomputing it.
1485 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1486 * Makefile.in (ALL_CFLAGS):
1487 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1488 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1490 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1492 * dispextern.h (xstrcasecmp): Define to library function
1493 strcasecmp if available.
1494 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1496 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1498 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1499 Avoid comma operator.
1500 * menu.c (push_submenu_start, push_submenu_end)
1501 (push_left_right_boundary, push_menu_pane): Likewise.
1502 * msdos.c (dos_rawgetc): Likewise.
1504 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1506 * xfns.c (xic_create_fontsetname): Remove redundant calls
1509 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1511 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1512 sprintf already null-terminates its output.
1514 * xfns.c (x_window): Remove redundant cast.
1516 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1518 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1519 `const char *' to `char *' to avoid compiler warning.
1521 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1523 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1524 instead of truncating it to 63 (admittedly a generous limit).
1526 * process.c: Fix spelling and caps in comments.
1528 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1530 * emacs.c (setpgrp): Remove definition, unused.
1531 * sysdep.c (setpgrp): Remove definition, not used in this file.
1533 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
1535 * makefile.w32-in: Update dependencies.
1537 2012-06-24 Eli Zaretskii <eliz@gnu.org>
1539 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1540 (SYSTIME_H): Add nt/inc/sys/time.h.
1542 * systime.h [WINDOWSNT]: Include sys/time.h.
1544 * s/ms-w32.h (struct timespec): Definition moved from
1545 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1547 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1549 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1550 * buffer.h (buffer_slot_type_mismatch):
1551 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1552 * eval.c (unwind_to_catch):
1553 * image.c (my_png_error, my_error_exit):
1554 * keyboard.c (quit_throw_to_read_char, user_error)
1555 (Fexit_recursive_edit, Fabort_recursive_edit):
1556 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1557 (wrong_type_argument, buffer_overflow, __executable_start)
1558 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1559 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1560 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1562 (child_setup) [!DOS_NT]:
1563 * lread.c (end_of_file_error, invalid_syntax):
1564 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1565 * puresize.h (pure_write_error):
1566 * search.c (matcher_overflow):
1567 * sound.c (sound_perror, alsa_sound_perror):
1568 * sysdep.c, syssignal.h (croak):
1569 * term.c (maybe_fatal, vfatal):
1570 * textprop.c (text_read_only):
1571 * undo.c (user_error):
1572 * unexmacosx.c (unexec_error):
1573 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1574 Use _Noreturn rather than NO_RETURN.
1575 No need for separate decl merely because of _Noreturn.
1576 * sound.c (sound_warning, parse_sound):
1577 Remove unnecessary forward decls.
1579 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1581 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1582 * lisp.h (WAIT_READING_MAX): New macro.
1583 * dispnew.c (Fsleep_for, sit_for):
1584 * keyboard.c (kbd_buffer_get_event):
1585 * process.c (Faccept_process_output):
1586 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1587 This improves on the previous patch, which introduced a bug
1588 when time_t is unsigned and as wide as intmax_t.
1589 See <http://bugs.gnu.org/9000#51>.
1591 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1593 * dispnew.c (sit_for, Fsleep_for):
1594 * keyboard.c (kbd_buffer_get_event):
1595 * process.c (Faccept_process_output): Avoid compiler warnings when
1596 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1598 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
1600 * makefile.w32-in: Update dependencies.
1602 * w32.c (ltime): Add return type and declare static.
1603 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1605 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1607 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1608 Privately reported by Herbert J. Skuhra.
1609 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1611 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1612 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1614 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1616 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1617 last argument of make_unibyte_string.
1619 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1620 language ID in the event parameters.
1622 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1623 event.code, not the obscure "character set ID".
1625 2012-06-23 Chong Yidong <cyd@gnu.org>
1627 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1629 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1631 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1632 * w32.c (fdutimens): New function.
1634 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1636 * s/ms-w32.h (pselect): Redirect to sys_select.
1638 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1640 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1641 in the logic of incrementing and decrementing the value of
1642 use_relocatable_buffers.
1644 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1646 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1647 Privately reported by Herbert J. Skuhra.
1648 [__FreeBSD__]: Remove "*/" typo after "#include".
1649 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1650 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1651 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1652 Don't assume EMACS_TIME and struct timeval are the same type.
1654 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1656 Support higher-resolution time stamps (Bug#9000).
1657 The time stamps are only nanosecond-resolution at the C level,
1658 since that's the best that any real-world system supports now.
1659 But they are picosecond-resolution at the Lisp level, as that's
1660 easy, and leaves room for future OS improvements.
1662 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1665 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1666 Don't get current time unless it's needed.
1668 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1669 now provides it if it's absent.
1670 (start_atimer): Port to higher-res time stamps.
1671 Check for time stamp overflow. Don't get current time more
1672 often than is needed.
1674 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1675 Include systime.h, not time.h.
1676 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1678 * dired.c: Include stat-time.h.
1679 (Ffile-attributes): File times now have higher resolution.
1681 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1682 (struct image): Timestamp now has higher resolution.
1684 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1685 has at least microseconds now. All uses removed.
1686 (update_frame, update_single_window, update_window, update_frame_1)
1687 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1689 * editfns.c (time_overflow): Now extern.
1690 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1691 (float-time, Fformat_time_string, Fcurrent_time_string)
1692 (Fcurrent_time_zone): Accept and generate higher-resolution
1694 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1695 (decode_time_components, lisp_seconds_argument): New functions.
1696 (make_time): Now static.
1697 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1698 Report an error if the time is invalid, rather than having the caller
1701 * fileio.c: Include <stat-time.h>
1702 (Fcopy_file): Copy higher-resolution time stamps.
1703 Prefer to set the time stamp via a file descriptor if that works.
1704 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1705 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1706 (Fvisited_file_modtime, Fset_visited_file_modtime):
1707 Support higher-resolution time stamps.
1709 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1711 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1713 * image.c (prepare_image_for_display, clear_image_cache)
1714 (lookup_image): Port to higer-resolution time stamps.
1716 * keyboard.c (start_polling, bind_polling_period):
1717 Check for time stamp overflow.
1718 (read_char, kbd_buffer_get_event, timer_start_idle)
1719 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1720 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1721 Port to higher-resolution time stamps. Do not assume time_t is signed.
1722 (decode_timer): New function. Timers are now vectors of length 9,
1723 not 8, to accommodate the picosecond component.
1724 (timer_check_2): Use it.
1726 * nsterm.m (select_timeout, timeval_subtract): Remove.
1727 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1728 as they're a bit more accurate and handle overflow better.
1729 (ns_select): Change prototype to be compatible with pselect.
1730 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1731 * nsterm.h (ns_select): Adjust prototype.
1733 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1734 us-resolution time stamps.
1735 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1737 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1739 * lisp.h (time_overflow): New decl.
1740 (wait_reading_process_output): First arg is now intmax_t, not int,
1741 to accommodate larger waits.
1743 * process.h (struct Lisp_Process.read_output_delay):
1744 Now counts nanoseconds, not microseconds.
1745 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1747 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1748 (wait_reading_process_output):
1749 Port to ns-resolution time stamps.
1750 (Faccept_process_output, wait_reading_process_output):
1751 Check for time stamp overflow. Do not assume time_t is signed.
1752 (select_wrapper): Remove; we now use pselect.
1753 (Fprocess_attributes): Now generates ns-resolution time stamps.
1755 * sysdep.c: Include utimens.h. Don't include utime.h
1756 or worry about struct utimbuf; gnulib does that for us now.
1757 (gettimeofday): Remove; gnulib provides a substitute.
1758 (make_timeval): New function.
1759 (set_file_times): Now sets ns-resolution time stamps.
1760 New arg FD; all uses changed.
1761 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1762 (system_process_attributes):
1763 Now returns ns-resolution time stamp. All uses changed.
1764 Check for time stamp overflow.
1766 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1767 provides a substitute now.
1769 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1770 since it guarantees struct timespec.
1771 (EMACS_TIME): Now struct timespec, so that we can support
1772 ns-resolution time stamps.
1773 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1774 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1775 (EMACS_USECS): Remove.
1776 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1777 so multiply the arg by 1000 before storing it.
1778 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1780 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1781 Port to ns-resolution time stamps.
1782 (EMACS_TIME_NEG_P): Remove; replaced by....
1783 (EMACS_TIME_SIGN): New macro.
1784 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1785 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1786 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1787 (make_timeval, make_lisp_time, decode_time_components): New decls.
1788 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1789 that it mishandled time_t overflow. You can't compare by subtracting!
1790 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1791 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1793 * term.c: Include <sys/time.h>.
1794 (timeval_to_Time): New function, for proper overflow wraparound.
1795 (term_mouse_position, term_mouse_click): Use it.
1797 * undo.c (record_first_change): Support higher-resolution time stamps
1799 (Fprimitive_undo): Use them when restoring time stamps.
1801 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1802 (w32_get_internal_run_time):
1803 Port to higher-resolution Emacs time stamps.
1804 (ltime): Now accepts single 64-bit integer, as that's more convenient
1807 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1809 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1810 for compatibility with pselect. Support ns-resolution time stamps.
1812 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1814 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1815 Check for time stamp overflow, and support ns-resolution time stamps.
1817 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1818 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1819 (timeval_subtract): Remove; no longer needed.
1820 (XTflash, XTring_bell, x_wait_for_event):
1821 Port to ns-resolution time stamps. Don't assume time_t is signed.
1823 2012-06-22 Chong Yidong <cyd@gnu.org>
1825 * xdisp.c (x_consider_frame_title): Revert last change.
1827 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1829 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1830 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1831 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1832 staticidx goes up to 1597 out of 1600 = 0x640.)
1834 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1836 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1837 Otherwise, the umask might be mistakenly 0 while handling input signals.
1839 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1841 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1843 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1845 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1846 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1847 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1848 access to `contents' member of Lisp_Vector objects with AREF and ASET
1851 2012-06-19 Chong Yidong <cyd@gnu.org>
1853 * frame.c (delete_frame): When selecting a frame on a different
1854 text terminal, do not alter the terminal's top-frame.
1856 * xdisp.c (format_mode_line_unwind_data): Record the target
1857 frame's selected window and its terminal's top-frame.
1858 (unwind_format_mode_line): Restore them.
1859 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1861 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1862 since tty frames can be explicitly named.
1863 (prepare_menu_bars): Likewise.
1865 * term.c (Ftty_top_frame): New function.
1867 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1869 Port byte-code-meter to modern targets.
1870 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1871 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
1872 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
1873 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1874 (METER_1, METER_2): Simplify.
1876 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1878 * data.c (Fdefalias): Return `symbol' (bug#11686).
1880 2012-06-18 Martin Rudalics <rudalics@gmx.at>
1882 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1883 gets killed during executing of this function (Bug#11665).
1884 Try to always return Qt when the buffer has been actually killed.
1885 (Vkill_buffer_query_functions): In doc-string say that functions
1886 run by this hook should not change the current buffer.
1888 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1890 Fix recently-introduced process.c problems found by static checking.
1891 * process.c (write_queue_push, write_queue_pop, send_process):
1892 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1893 (write_queue_pop): Fix pointer signedness problem.
1894 (send_process): Remove unused local.
1896 2012-06-17 Chong Yidong <cyd@gnu.org>
1898 * xdisp.c (redisplay_internal): No need to redisplay terminal
1899 frames that are not on top.
1901 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1903 * process.c (make_process): Initialize write_queue.
1904 (write_queue_push, write_queue_pop): New functions.
1905 (send_process): Use them to maintain correct ordering of process
1908 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1910 * lisp.h (eassert): Assume C89 or later.
1911 This removes the need for CHECK.
1912 (CHECK): Remove. Its comments about always evaluating its
1913 argument were confusing, as 'eassert' typically does not evaluate
1916 * coding.c (produce_chars): Use ptrdiff_t, not int.
1918 * xterm.c (x_draw_underwave): Check for integer overflow.
1919 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1921 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
1923 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1924 referenced (Bug#11583).
1926 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1928 Implement wave-style variant of underlining.
1929 * dispextern.h (face_underline_type): New enum.
1930 (face): Add field for underline type.
1931 * nsterm.m (ns_draw_underwave): New function.
1932 (ns_draw_text_decoration): Use it.
1933 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1935 (x_draw_glyph_string): Use them.
1936 * xfaces.c (Qline, Qwave): New Lisp objects.
1937 (check_lface_attrs, merge_face_ref)
1938 (Finternal_set_lisp_face_attribute, realize_x_face):
1939 Handle wave-style underline face attributes.
1940 * xterm.c (x_draw_underwave): New function.
1941 (x_draw_glyph_string): Use it.
1943 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
1945 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1946 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1947 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1948 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1949 ($(BLD)/w32select.$(O)): Update dependencies.
1951 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1953 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1954 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1955 * character.c (_fetch_multibyte_char_p): Remove.
1956 * alloc.c: Include "character.h" before "buffer.h".
1958 * buffer.c: Likewise.
1959 * bytecode.c: Likewise.
1960 * callint.c: Likewise.
1961 * callproc.c: Likewise.
1962 * casefiddle.c: Likewise.
1963 * casetab.c: Likewise.
1964 * category.c: Likewise.
1966 * coding.c: Likewise.
1967 * composite.c: Likewise.
1968 * dired.c: Likewise.
1969 * dispnew.c: Likewise.
1971 * dosfns.c: Likewise.
1972 * editfns.c: Likewise.
1973 * emacs.c: Likewise.
1974 * fileio.c: Likewise.
1975 * filelock.c: Likewise.
1977 * fontset.c: Likewise.
1978 * fringe.c: Likewise.
1979 * indent.c: Likewise.
1980 * insdel.c: Likewise.
1981 * intervals.c: Likewise.
1982 * keyboard.c: Likewise.
1983 * keymap.c: Likewise.
1984 * lread.c: Likewise.
1985 * macros.c: Likewise.
1986 * marker.c: Likewise.
1987 * minibuf.c: Likewise.
1988 * nsfns.m: Likewise.
1989 * nsmenu.m: Likewise.
1990 * print.c: Likewise.
1991 * process.c: Likewise.
1992 * regex.c: Likewise.
1993 * region-cache.c: Likewise.
1994 * search.c: Likewise.
1995 * syntax.c: Likewise.
1997 * textprop.c: Likewise.
1999 * unexsol.c: Likewise.
2000 * w16select.c: Likewise.
2001 * w32fns.c: Likewise.
2002 * w32menu.c: Likewise.
2003 * window.c: Likewise.
2004 * xdisp.c: Likewise.
2006 * xmenu.c: Likewise.
2008 * xselect.c: Likewise.
2010 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2012 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2013 If all the glyphs of the glyph row came from strings, and we have no
2014 cursor positioning clues, put the cursor on the first glyph of the
2016 (handle_face_prop): Use chunk-relative overlay string index when
2017 indexing into it->string_overlays array. (Bug#11653)
2018 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2019 the rightmost. (Bug#11720)
2021 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2023 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2024 (CATEGORY_MEMBER): Enforce 1/0 value.
2025 * category.c (_temp_category_set): Remove.
2027 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2029 * window.c (Fdelete_other_windows_internal)
2030 (Fdelete_window_internal): Don't access frame's mouse highlight
2031 info of the initial frame. (Bug#11677)
2033 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2035 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2036 Assume USE_2_TAGS_FOR_INTS.
2037 (xreload): Adjust $tagmask width to match recent lisp.h change.
2039 Simplify lisp.h in minor ways that should not affect code.
2040 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2041 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2042 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2043 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2044 (INTTYPEBITS): New macro, for clarity.
2045 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
2046 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2047 Simplify now that USE_LSB_TAG is always defined.
2048 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2049 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2051 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
2053 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2055 2012-06-13 Glenn Morris <rgm@gnu.org>
2057 * s/bsd-common.h (BSD4_3):
2058 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2060 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2062 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2065 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2067 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
2068 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
2069 * alloc.c (widen_to_Lisp_Object): Remove.
2070 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2071 * frame.c (delete_frame): Remove outdated comment.
2072 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2073 USE_LISP_UNION_TYPE.
2074 (Fw32_unregister_hot_key): Likewise.
2075 (Fw32_toggle_lock_key): Likewise.
2076 * w32menu.c (add_menu_item): Likewise.
2077 (w32_menu_display_help): Use XIL instead of checking
2078 USE_LISP_UNION_TYPE.
2079 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2080 (init_heap): Likewise.
2081 * w32term.c (w32_read_socket): Update comment.
2083 2012-06-13 Glenn Morris <rgm@gnu.org>
2085 * s/usg5-4-common.h, src/s/unixware.h:
2086 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2088 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2090 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2092 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2093 * alloc.c (make_number) [!defined make_number]:
2094 Remove, as lisp.h always defines this now.
2095 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2096 (roundup_size): Verify that it is a power of 2.
2097 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2098 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2099 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2100 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2101 USE_LSB_TAG now is always defined to be either 0 or 1.
2103 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2104 code works fine either way, and efficiency is not a concern here,
2105 as the union type is for debugging, not for production.
2106 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2107 Use an inline function on all platforms when using the union type,
2108 since this is simpler and 'static inline' can be used portably
2110 (LISP_INITIALLY_ZERO): New macro.
2111 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2112 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2114 2012-06-12 Glenn Morris <rgm@gnu.org>
2116 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2118 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
2120 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2121 Move BROKEN_SIGIO to configure.
2123 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2124 Move NO_TERMIO to configure.
2126 2012-06-12 Chong Yidong <cyd@gnu.org>
2128 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2129 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2130 MagickExportImagePixels is undefined.
2132 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2134 * image.c (imagemagick_load_image): Remove unused label.
2136 2012-06-11 Glenn Morris <rgm@gnu.org>
2138 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2139 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2140 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2141 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2143 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2145 * alloc.c (make_byte_code): New function.
2146 (Fmake_byte_code): Use it. Don't purify here.
2147 * lread.c (read1): Use it as well to avoid extra allocation.
2149 2012-06-11 Chong Yidong <cyd@gnu.org>
2151 * image.c (imagemagick_load_image): Implement transparency.
2153 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2155 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2156 account for preceding backslashes. (Bug#11663)
2158 2012-06-09 Chong Yidong <cyd@gnu.org>
2160 * term.c: Support italics in capable terminals (Bug#9652).
2161 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2162 (turn_on_face): Output using TS_enter_italic_mode if available.
2163 Don't handle unused blinking and alt-charset cases.
2164 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2165 and tty_alt_charset_p cases.
2166 (tty_capable_p, init_tty): Support italics.
2168 * termchar.h (struct tty_display_info): Add field for italics.
2169 Remove unused blink field.
2171 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2174 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2175 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2176 tty_alt_charset_p. Add tty_italic_p.
2178 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
2180 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2181 dbus_type_is_basic if available.
2182 (xd_extract_signed, xd_extract_unsigned): Rename from
2183 extract_signed and extract_unsigned, respectively. Adapt callers.
2185 2012-06-09 Chong Yidong <cyd@gnu.org>
2187 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2189 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2192 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2194 * xdisp.c (vmessage): Treat frame message as multibyte.
2195 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2196 would generate the diagnostic "Making \302\247 buffer-local while
2199 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2201 * dispnew.c (showing_window_margins_p): Undo last change, which
2202 was done due to an inadvertent commit.
2203 (adjust_frame_glyphs_for_frame_redisplay): Do call
2204 showing_window_margins_p.
2206 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2208 * eval.c (Fmake_var_non_special): New primitive.
2209 (syms_of_eval): Defsubr it.
2210 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2212 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
2214 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2215 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2217 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2219 * alloc.c (allocate_vectorlike): Fix last change.
2221 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2223 Block-based vector allocation of small vectors.
2224 * lisp.h (struct vectorlike_header): New field `nbytes',
2225 adjust comment accordingly.
2226 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2227 to denote vector blocks. Adjust users (live_vector_p,
2228 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2229 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2230 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2231 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2232 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2233 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2234 (roundup_size): New constant.
2235 (struct vector_block): New data type.
2236 (vector_blocks, vector_free_lists, zero_vector): New variables.
2237 (all_vectors): Rename to `large_vectors'.
2238 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2239 (sweep_vectors): New functions.
2240 (allocate_vectorlike): Return `zero_vector' as the only vector of
2241 0 items. Allocate new vector from block if vector size is less than
2242 or equal to VBLOCK_BYTES_MAX.
2243 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2244 (init_alloc_once): Add call to init_vectors.
2246 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2248 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2250 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2252 * doprnt.c (doprnt): Truncate multibyte char correctly.
2253 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2254 would mishandle a string argument "Xc" if X was a multibyte
2255 character of length 2: it would truncate after X's first byte
2256 rather than including all of X.
2258 2012-06-06 Chong Yidong <cyd@gnu.org>
2260 * buffer.c (word_wrap): Doc fix.
2262 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2264 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2266 2012-06-03 Glenn Morris <rgm@gnu.org>
2268 * xdisp.c (tool-bar-style): Doc fix.
2270 2012-06-03 Ulrich Müller <ulm@gentoo.org>
2272 * Makefile.in (PAXCTL): Define.
2273 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2274 binary via PaX flags if the paxctl utility is available.
2275 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2276 Restore PaX flags to their default. (Bug#11398)
2278 2012-06-03 Chong Yidong <cyd@gnu.org>
2280 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2283 2012-06-03 Chong Yidong <cyd@gnu.org>
2285 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2286 (note_mode_line_or_margin_highlight): If there is no help echo,
2287 use mode-line-default-help-echo. Handle the case where the mouse
2288 position is past the end of the mode line string.
2290 * buffer.c (buffer_local_value_1): New function, split from
2291 Fbuffer_local_value; can return Qunbound.
2292 (Fbuffer_local_value): Use it.
2293 (Vmode_line_format): Docstring tweaks.
2295 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2297 * sysdep.c (system_process_attributes): Improve comment.
2299 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2301 * keyboard.c: Export real-this-command to Elisp.
2302 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2303 and DEFVAR it. Update all users.
2305 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2307 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2309 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2310 Convert pctcpu and pctmem to Lisp float properly.
2311 Let the compiler fold better, as 100.0/0x8000 is exact.
2313 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2315 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2318 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2320 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2322 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2324 For a 'struct window', replace some Lisp_Object fields to
2325 bitfields where appropriate, remove unused fields.
2326 * window.h (struct window): Remove unused 'last_mark_x' and
2327 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2328 change it's type from Lisp_Object to bitfield.
2329 Change type of 'force_start', 'optional_new_start',
2330 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2331 fields from Lisp_Object to bitfield. Adjust users accordingly.
2333 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2335 Pacify gcc -Wdouble-precision when using Xaw.
2336 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2337 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2338 Use 'float' consistently, rather than 'float' in most places
2339 and 'double' in a couple of places.
2341 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2343 * xdisp.c (handle_stop): Detect whether we have overlay strings
2344 loaded by testing it->current.overlay_string_index to be
2345 non-negative, instead of checking whether n_overlay_strings is
2346 positive. (Bug#11587)
2348 2012-05-31 Chong Yidong <cyd@gnu.org>
2350 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2352 * doc.c (Fsubstitute_command_keys): Doc fix.
2354 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2356 * search.c (search_buffer): Remove calls to
2357 r_alloc_inhibit_buffer_relocation, as it is now called by
2358 maybe_unify_char, which was the cause of relocation of buffer text
2361 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2363 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2364 for the duration of call to load_charset, to avoid problems with
2365 callers of maybe_unify_char that access buffer text through C
2368 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2369 decrement the inhibition flag, instead of just setting or
2372 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2374 Remove obsolete '#define static' cruft.
2375 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2376 This #undef was "temporary" in 2000; it is no longer needed
2377 now that '#define static' has gone away.
2378 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2379 (gray_bitmap_bits): Remove; no longer needed.
2380 All uses replaced with definiens.
2381 * xterm.c: Include "bitmaps/gray.xbm".
2383 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2385 Clean up __executable_start, monstartup when --enable-profiling.
2386 The following changes affect the code only when profiling.
2387 * dispnew.c (__executable_start): Rename from safe_bcopy.
2388 Define only on platforms that need it.
2389 * emacs.c: Include <sys/gmon.h> when profiling.
2390 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2391 (__executable_start): Remove decl, since lisp.h does it now.
2392 (safe_bcopy): Remove decl; no longer has that name.
2393 (main): Coalesce #if into single bit of code, for simplicity.
2394 Cast pointers to uintptr_t, since standard libraries want integers
2396 * lisp.h (__executable_start): New decl.
2398 2012-05-31 Glenn Morris <rgm@gnu.org>
2400 * image.c (Fimagemagick_types): Doc fix.
2402 2012-05-30 Jim Meyering <meyering@redhat.com>
2404 * callproc.c (Fcall_process_region): Include directory component
2405 in mkstemp error message (Bug#11586).
2407 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2409 * alloc.c, lisp.h (make_pure_vector): Now static.
2411 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2413 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2414 Move to byte-run.el.
2415 (Fautoload): Do the hash-doc more carefully.
2416 * data.c (Fdefalias): Purify definition, except for keymaps.
2417 (Qdefun): Move from eval.c.
2418 * lisp.h (Qdefun): Remove.
2419 * lread.c (read1): Tiny simplification.
2421 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
2423 Do not create empty overlays with the evaporate property (Bug#9642).
2424 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2425 Bug#9642, but explicitly check that the buffer the overlay would
2426 be moved to is live and rearrange lines to make sure that errors
2427 will not put the overlay in an inconsistent state.
2428 (Fdelete_overlay): Cosmetics.
2430 2012-05-28 Eli Zaretskii <eliz@gnu.org>
2432 * w32term.c (my_bring_window_to_top): New function.
2433 (x_raise_frame): Use handle returned by DeferWindowPos, which
2434 could be different from the original one.
2435 Call my_bring_window_to_top instead of my_set_foreground_window.
2438 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2439 by calling BringWindowToTop.
2441 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2442 (WM_EMACS_END): Increase by one.
2444 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2446 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2447 This avoids undefined behavior that might cause the eassert
2448 to not catch an out-of-range value.
2450 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
2452 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2453 Update dependencies.
2455 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2457 * bidi.c (bidi_mirror_char): Fix last change.
2459 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2461 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2462 when referring to sectname field in printf format.
2464 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2466 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2467 Only r_alloc_inhibit_buffer_relocation needed to be added;
2468 the others were already declared.
2470 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2471 before checking whether it's out of range. Put the check inside
2473 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2475 2012-05-27 Ken Brown <kbrown@cornell.edu>
2477 * callproc.c (Fcall_process): Restore a line that was accidentally
2478 commented out in the 2011-02-13 change (bug#11547).
2480 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2482 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2483 defined on ralloc.c.
2485 * buffer.c [REL_ALLOC]: Remove prototypes of
2486 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2487 they are now on lisp.h.
2489 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2491 * search.c (search_buffer): Use it to inhibit relocation of buffer
2492 text while re_search_2 is doing its job, because re_search_2 is
2493 passed C pointers to buffer text. (Bug#11519)
2495 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2498 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2499 state after an additional call to move_it_in_display_line_to, keep
2500 the values of it->max_ascent and it->max_descent found for the
2502 (pos_visible_p): Revert the comparison against bottom_y to what it
2503 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2506 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2508 Fix coding-related core dumps with gcc -ftrapv.
2509 The code was computing A - B, where A and B are pointers, and B is
2510 random garbage. This can lead to core dumps on platforms that
2511 have special pointer registers, and it also leads to core dumps on
2512 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2513 A - B only when B is initialized properly.
2514 * coding.c (coding_set_source, coding_set_destination): Return void.
2515 (coding_change_source, coding_change_destinations): New functions,
2516 with the old behaviors of coding_set_source and coding_set_destination.
2517 All callers that need an offset changed to use these new functions.
2519 2012-05-26 Glenn Morris <rgm@gnu.org>
2521 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2523 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2525 Extend mouse support on W32 text-mode console.
2526 * xdisp.c (draw_row_with_mouse_face):
2527 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
2529 * w32console.c: Include window.h.
2530 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2532 (initialize_w32_display): Initialize mouse-highlight data.
2534 * w32inevt.c: Include termchar.h and window.h.
2535 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2536 moves, call note_mouse_highlight. If help_echo changed, call
2537 gen_help_event to produce help-echo message in the echo area.
2538 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2541 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2543 * lread.c (read1): Simplify slightly to avoid an overflow warning
2544 with GCC 4.7.0 on x86-64.
2546 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2548 * bidi.c (bidi_mirror_char): Revert last change: an int is
2549 definitely wide enough here.
2551 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
2553 Fix integer width and related bugs (Bug#9874).
2554 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
2555 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2556 (string_bytes, check_sblock, allocate_string_data):
2557 (compact_small_strings, Fmake_bool_vector, make_string)
2558 (make_unibyte_string, make_multibyte_string)
2559 (make_string_from_bytes, make_specified_string)
2560 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2561 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2563 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2564 (allocate_pseudovector):
2565 Use int, not EMACS_INT, where int is wide enough.
2566 (inhibit_garbage_collection, Fgarbage_collect):
2567 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2568 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2569 int might not be wide enough.
2570 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2571 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2572 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2573 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2574 (bidi_level_of_next_char, bidi_move_to_visually_next):
2575 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2576 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2577 (Fkill_buffer, Fset_buffer_major_mode)
2578 (advance_to_char_boundary, Fbuffer_swap_text)
2579 (Fset_buffer_multibyte, overlays_at, overlays_in)
2580 (overlay_touches_p, struct sortvec, record_overlay_string)
2581 (overlay_strings, recenter_overlay_lists)
2582 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2583 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2584 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2585 (Foverlay_recenter, last_overlay_modification_hooks_used)
2586 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2587 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2588 (validate_region): Omit unnecessary test for b <= e,
2589 since that's guaranteed by the previous test.
2590 (adjust_overlays_for_delete): Avoid pos + length overflow.
2591 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2592 (report_overlay_modification):
2593 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2594 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2595 Omit pointer cast, which isn't needed anyway, and doesn't work
2596 after the EMACS_INT -> ptrdiff_t change.
2597 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
2598 * buffer.h: Adjust decls to match defn changes elsewhere.
2599 (struct buffer_text, struct buffer):
2600 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2601 Use EMACS_INT, not int, where int might not be wide enough.
2602 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2603 not int, to avoid needless 32-bit limit on 64-bit hosts.
2604 (exec_byte_code): Use tighter memory-full test, one that checks
2605 for alloca overflow. Don't compute the address of the object just
2606 before an array, as that's not portable. Use EMACS_INT, not
2607 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
2608 * callint.c (Fcall_interactively):
2609 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2610 * callproc.c (call_process_kill, Fcall_process):
2611 Don't assume pid_t fits into an Emacs fixnum.
2612 (call_process_cleanup, Fcall_process, child_setup):
2613 Don't assume pid_t fits into int.
2614 (call_process_cleanup, Fcall_process, delete_temp_file)
2615 (Fcall_process_region):
2616 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2617 (Fcall_process): Simplify handling of volatile integers.
2618 Use int, not EMACS_INT, where int will do.
2619 * casefiddle.c (casify_object, casify_region, operate_on_word)
2620 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2621 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2622 (casify_object): Avoid integer overflow when overallocating buffer.
2623 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
2624 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
2625 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2626 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2627 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2628 integers are now checked earlier. All uses replaced with XINT.
2630 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2631 For CCL_MapSingle, check that content and value are in int range.
2632 (ccl_driver, Fregister_code_conversion_map):
2633 Check that Vcode_version_map_vector is a vector.
2634 (resolve_symbol_ccl_program): Check that vector header is in range.
2635 Always copy the vector, so that we can check its contents reliably
2636 now rather than having to recheck each instruction as it's being
2637 executed. Check that vector words fit in 'int'.
2638 (ccl_get_compiled_code, Fregister_ccl_program)
2639 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2640 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2641 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2642 contents are in range.
2643 (Fccl_execute_on_string): Check that status is in range.
2644 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2645 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2646 Accept and return EMACS_INT, not int, because callers can pass values
2648 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2649 (multibyte_chars_in_text, parse_str_as_multibyte)
2650 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2651 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2652 (string_escape_byte8, Fget_byte):
2653 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2654 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
2655 avoid mishandling large integers.
2656 * character.h: Adjust decls to match defn changes elsewhere.
2657 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2658 (Ffind_charset_region):
2659 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2660 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2661 (load_charset_map_from_vector, Fdefine_charset_internal):
2662 Don't assume fixnum fits in int.
2663 (load_charset_map_from_vector, Fmap_charset_chars):
2664 Remove now-unnecessary CHECK_NATNUMs.
2665 (Fdefine_charset_internal): Check ranges here, more carefully.
2666 Don't rely on undefined behavior with signed left shift overflow.
2667 Don't assume unsigned int fits into fixnum, or that fixnum fits
2668 into unsigned int. Don't require max_code to be a valid fixnum;
2669 that's not true for gb10830 4-byte on a 32-bit host. Allow
2670 invalid_code to be a cons, for the same reason. Require code_offset
2671 to be a character. Avoid int overflow if max_char is close
2673 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2674 this is intended anyway and avoids some undefined behavior.
2675 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2676 INDEX_TO_CODE_POINT, as that's what it expects.
2677 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
2678 * charset.h (DECODE_CHAR): Return int, not unsigned;
2679 this is what was intended anyway, and it avoids undefined behavior.
2680 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2681 integer-overflow issues.
2682 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2683 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2684 where the argument is EMACS_INT, and this behavior is not intended.
2685 * chartab.c (Fmake_char_table, Fset_char_table_range)
2686 (uniprop_get_decoder, uniprop_get_encoder):
2687 Don't assume fixnum fits in int.
2688 * cmds.c (move_point): New function, that does the gist of
2689 Fforward_char and Fbackward_char, but does so while checking
2690 for integer overflow more accurately.
2691 (Fforward_char, Fbackward_char): Use it.
2692 (Fforward_line, Fend_of_line, internal_self_insert)
2693 (internal_self_insert):
2694 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2695 Fix a FIXME, by checking for integer overflow when calculating
2696 target_clm and actual_clm.
2697 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
2698 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
2699 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2700 (coding_alloc_by_making_gap, alloc_destination)
2701 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2702 (encode_coding_utf_16, detect_coding_emacs_mule)
2703 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2704 (detect_coding_iso_2022, decode_coding_iso_2022)
2705 (encode_invocation_designation, encode_designation_at_bol)
2706 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2707 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2708 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2709 (encode_coding_ccl, encode_coding_raw_text)
2710 (detect_coding_charset, decode_coding_charset)
2711 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2712 (produce_composition, produce_charset, produce_annotation)
2713 (decode_coding, handle_composition_annotation)
2714 (handle_charset_annotation, consume_chars, decode_coding_gap)
2715 (decode_coding_object, encode_coding_object, detect_coding_system)
2716 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2717 (code_convert_region, code_convert_string)
2718 (Fdefine_coding_system_internal)
2719 (coding_set_source, coding_set_destination):
2720 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2721 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2722 (Fdefine_coding_system_internal):
2723 Don't assume fixnums fit in int.
2724 (decode_coding_gap, decode_coding_object, encode_coding_object)
2725 (Fread_coding_system, Fdetect_coding_region)
2726 (Funencodable_char_position, Fcheck_coding_systems_region)
2727 (get_translation, handle_composition_annotation, consume_chars):
2728 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2729 (consume_chars): Rewrite to not calculate an address outside buffer.
2730 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
2731 Don't access memory outside of the args array.
2732 (Fdefine_coding_system_internal): Check for charset-id overflow.
2733 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2734 result of ENCODE_CHAR.
2735 * coding.h: Adjust decls to match defn changes elsewhere.
2736 (struct coding_system):
2737 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2738 * composite.c (get_composition_id, find_composition)
2739 (run_composition_function, update_compositions)
2740 (compose_text, composition_gstring_put_cache)
2741 (composition_gstring_p, composition_gstring_width)
2742 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2743 (composition_compute_stop_pos, composition_reseat_it)
2744 (composition_update_it, struct position_record)
2745 (find_automatic_composition, composition_adjust_point)
2746 (Fcomposition_get_gstring, Ffind_composition_internal):
2747 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2748 (update_compositions):
2749 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2750 * composite.h: Adjust decls to match defn changes elsewhere.
2751 (struct composition):
2752 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2753 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2754 Do not attempt to compute the address of the object just before a
2755 buffer; this is not portable.
2757 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2758 (Faset): Use int, not EMACS_INT, where int is wide enough.
2759 (Fstring_to_number): Don't assume fixnums fit in int.
2760 (Frem): Don't assume arg is nonnegative.
2761 * dbusbind.c (xd_append_arg): Check for integers out of range.
2762 (Fdbus_call_method): Don't overflow the timeout int.
2763 (extract_signed, extract_unsigned): New functions.
2764 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2765 (xd_get_connection_references): Return ptrdiff_t, not int.
2767 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2768 (xd_read_message_1):
2769 Use int, not unsigned, where the dbus API uses int.
2770 (Fdbus_message_internal): Don't overflow mtype.
2771 (syms_of_dbusbind): Allocate right-sized buffer for integers.
2772 * dired.c (directory_files_internal, file_name_completion, scmp)
2773 (file_name_completion_stat):
2774 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2775 (file_name_completion): Don't overflow matchcount.
2776 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2777 * dispextern.h: Adjust decls to match defn changes elsewhere.
2778 (struct text_pos, struct glyph, struct bidi_saved_info)
2779 (struct bidi_string_data, struct bidi_it, struct composition_it)
2781 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2782 (struct display_pos, struct composition_it, struct it):
2783 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2784 * dispnew.c (increment_matrix_positions)
2785 (increment_row_positions, mode_line_string)
2786 (marginal_area_string):
2787 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2788 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
2789 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2790 (duration_to_sec_usec): New function, to check for overflow better.
2791 (Fsleep_for, sit_for): Use it.
2792 * doc.c (get_doc_string, store_function_docstring):
2793 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2794 (get_doc_string, Fsnarf_documentation):
2795 Use int, not EMACS_INT, where int is wide enough.
2797 Use SAFE_ALLOCA, not alloca.
2798 Check for overflow when converting EMACS_INT to off_t.
2799 * doprnt.c (doprnt):
2800 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2801 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2802 Don't assume uid_t fits into fixnum.
2803 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2804 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2805 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2806 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2807 (general_insert_function)
2808 (Finsert_char, make_buffer_string, make_buffer_string_both)
2809 (update_buffer_properties, Fbuffer_substring)
2810 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2811 (Fsubst_char_in_region, check_translation)
2812 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2813 (transpose_markers, Ftranspose_regions):
2814 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2815 (clip_to_bounds): Move to lisp.h as an inline function).
2816 (Fconstrain_to_field): Don't assume integers are nonnegative.
2817 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2818 (Fsubst_char_in_region, Fsave_restriction):
2819 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2820 (Femacs_pid): Don't assume pid_t fits into fixnum.
2821 (lo_time): Use int, not EMACS_INT, when int suffices.
2822 (lisp_time_argument): Check for usec out of range.
2823 (Fencode_time): Don't assume fixnum fits in int.
2824 (Fuser_login_name, Fuser_full_name): Signal an error
2825 if a uid argument is out of range, rather than relying on
2827 (Fformat_time_string): Remove now-unnecessary check.
2828 lisp_time_argument checks for out-of-range usec now.
2829 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2830 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2831 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2832 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2833 (init_cmdargs, Fdump_emacs):
2834 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2835 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2836 the bottom (typically) 32 bits of the fixnum.
2837 * eval.c (specpdl_size, call_debugger):
2838 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2839 (when_entered_debugger, Fbacktrace_debug):
2840 Don't assume fixnum can fit in int.
2841 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2842 the object just before a buffer; this is not portable.
2843 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2844 (grow_specpdl, unbind_to):
2845 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2846 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2847 (grow_specpdl): Simplify allocation by using xpalloc.
2848 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2849 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2850 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2851 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2852 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2854 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2855 (Fcopy_file, non_regular_nbytes, read_non_regular)
2856 (Finsert_file_contents):
2857 Use int, not EMACS_INT, where int is wide enough.
2858 (READ_BUF_SIZE): Verify that it fits in int.
2859 (Finsert_file_contents): Check that counts are in proper range,
2860 rather than assuming fixnums fit into ptrdiff_t etc.
2861 Don't assume fixnums fit into int.
2862 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2863 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2864 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2865 (string_char_to_byte, string_byte_to_char)
2866 (string_make_multibyte, string_to_multibyte)
2867 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2868 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2869 (substring_both, Fdelete, internal_equal, Ffillarray)
2870 (Fclear_string, mapcar1)
2871 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2872 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2873 (larger_vector, make_hash_table, maybe_resize_hash_table)
2874 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2875 (Fmaphash, secure_hash):
2876 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2877 (concat): Check for string index and length overflow.
2878 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2880 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2881 (larger_vector): New API (vec, incr_min, size_max) replaces old
2882 one (vec, new_size, init). This catches size overflow.
2883 INIT was removed because it was always Qnil.
2884 All callers changed.
2885 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2886 the upper bound on a hash table index size.
2887 (make_hash_table, maybe_resize_hash_table): Use it.
2888 (secure_hash): Computer start_byte and end_byte only after
2889 they're known to be in ptrdiff_t range.
2890 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2891 (Ffont_get_glyphs, Ffont_at):
2892 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2893 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2894 (Flist_fonts, Fopen_font):
2895 Don't assume fixnum can fit in int.
2896 (check_gstring): Don't assume index can fit in int.
2897 (font_match_p): Check that fixnum is a character, not a nonnegative
2898 fixnum, since the later code needs to stuff it into an int.
2899 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2900 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2901 conversion overflow issues.
2902 (Fopen_font): Check for integer out of range.
2903 (Ffont_get_glyphs): Don't assume index can fit in int.
2904 * font.h: Adjust decls to match defn changes elsewhere.
2905 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2907 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2908 printmax_t, where ptrdiff_t is wide enough.
2909 (Finternal_char_font):
2910 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2911 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2912 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2913 (Fset_frame_position, x_set_frame_parameters)
2914 (x_set_line_spacing, x_set_border_width)
2915 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2916 Check that fixnums are in proper range for system types.
2917 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2918 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2919 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2920 Use SAFE_ALLOCA_LISP, not alloca.
2921 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2922 intptr_t is wide enough.
2923 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2924 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2925 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2926 Check for fixnum out of range.
2927 * ftfont.c (ftfont_list): Don't assume index fits in int.
2928 Check that fixnums are in proper range for system types.
2929 (ftfont_shape_by_flt):
2930 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2931 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2932 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2933 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2934 Check that fixnums are in proper range for system types.
2935 * gnutls.h: Adjust decls to match defn changes elsewhere.
2936 * gtkutil.c (xg_dialog_run):
2937 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2938 (update_frame_tool_bar):
2939 Check that fixnums are in proper range for system types.
2940 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
2941 (lookup_image): Check that fixnums are in range for system types.
2942 * indent.c (last_known_column, last_known_column_point):
2943 (current_column_bol_cache):
2944 (skip_invisible, current_column, check_display_width):
2945 (check_display_width, scan_for_column, current_column_1)
2946 (Findent_to, Fcurrent_indentation, position_indentation)
2947 (indented_beyond_p, Fmove_to_column, compute_motion):
2948 (Fcompute_motion, Fvertical_motion):
2949 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2950 (last_known_column_modified): Use EMACS_INT, not int.
2951 (check_display_width):
2953 Check that fixnums and floats are in proper range for system types.
2954 (compute_motion): Don't assume index or fixnum fits in int.
2955 (compute_motion, Fcompute_motion):
2956 Use int, not EMACS_INT, when it is wide enough.
2957 (vmotion): Omit local var start_hpos that is always 0; that way
2958 we don't need to worry about overflow in expressions involving it.
2959 * indent.h: Adjust decls to match defn changes elsewhere.
2961 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2962 Use int, not EMACS_INT, where int is wide enough.
2963 Remove unused members ovstring_chars_done and tab_offset;
2965 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2966 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2967 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2968 (make_gap, copy_text, insert, insert_and_inherit)
2969 (insert_before_markers, insert_before_markers_and_inherit)
2970 (insert_1, count_combining_before, count_combining_after)
2971 (insert_1_both, insert_from_string)
2972 (insert_from_string_before_markers, insert_from_string_1)
2973 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2974 (adjust_after_replace, adjust_after_insert, replace_range)
2975 (replace_range_2, del_range, del_range_1, del_range_byte)
2976 (del_range_both, del_range_2, modify_region)
2977 (prepare_to_modify_buffer, signal_before_change)
2978 (signal_after_change, Fcombine_after_change_execute):
2979 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2980 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2981 (balance_an_interval, split_interval_right, split_interval_left)
2982 (find_interval, next_interval, update_interval)
2983 (adjust_intervals_for_insertion, delete_node, delete_interval)
2984 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2985 (static_offset_intervals, offset_intervals)
2986 (merge_interval_right, merge_interval_left, make_new_interval)
2987 (graft_intervals_into_buffer, temp_set_point_both)
2988 (temp_set_point, set_point, adjust_for_invis_intang)
2989 (set_point_both, move_if_not_intangible, get_property_and_range)
2990 (get_local_map, copy_intervals, copy_intervals_to_string)
2991 (compare_string_intervals, set_intervals_multibyte_1):
2992 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2993 * intervals.h: Adjust decls to match defn changes elsewhere.
2995 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2996 * keyboard.c (this_command_key_count, this_single_command_key_start)
2997 (before_command_key_count, before_command_echo_length, echo_now)
2998 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2999 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3000 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3001 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3002 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3003 (last_non_minibuf_size, last_point_position, echo_truncate)
3004 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3005 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3006 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3007 (stuff_buffered_input):
3008 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3009 (last_auto_save, command_loop_1, read_char):
3010 Use EMACS_INT, not int, to avoid integer overflow.
3011 (record_char): Avoid overflow in total_keys computation.
3012 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3013 * keyboard.h: Adjust decls to match defn changes elsewhere.
3014 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3015 (Fkey_description, Fdescribe_vector, Flookup_key):
3016 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3017 (click_position): New function, to check that positions are in range.
3018 (Fcurrent_active_maps):
3020 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3021 (Faccessible_keymaps, Fkey_description):
3022 (preferred_sequence_p):
3023 Don't assume fixnum can fit into int.
3024 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3025 Check for integer overflow in size calculations.
3026 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3027 avoid mishandling large integers.
3028 * lisp.h: Adjust decls to match defn changes elsewhere.
3029 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3030 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3031 (struct Lisp_Marker):
3032 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3033 (clip_to_bounds): Now an inline function, moved here from editfns.c.
3034 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3035 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3036 All callers changed.
3037 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3038 Assume the arg has valid form, since it always does.
3039 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3040 unsigned integer system type.
3041 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3042 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3043 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3044 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3045 (duration_to_sec_usec): New decl.
3046 * lread.c (read_from_string_index, read_from_string_index_byte)
3047 (read_from_string_limit, readchar, unreadchar, openp)
3048 (read_internal_start, read1, oblookup):
3049 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3050 (Fload, readevalloop, Feval_buffer, Feval_region):
3051 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3052 (openp): Check for out-of-range argument to 'access'.
3053 (read1): Use int, not EMACS_INT, where int is wide enough.
3054 Don't assume fixnum fits into int.
3055 Fix off-by-one error that can read outside a buffer.
3056 (read_filtered_event): Use duration_to_sec_usec
3057 to do proper overflow checking on durations.
3058 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3059 in size calculation.
3060 (Fexecute_kbd_macro):
3061 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3062 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3063 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3064 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3065 (set_marker_both, set_marker_restricted_both, marker_position)
3066 (marker_byte_position, Fbuffer_has_markers_at):
3067 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3068 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
3069 * menu.c (ensure_menu_items): Rename from grow_menu_items.
3070 It now merely ensures that the menu is large enough, without
3071 necessarily growing it, as this avoids some integer overflow issues.
3072 All callers changed.
3073 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3074 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3075 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3076 Use SAFE_ALLOCA_LISP, not alloca.
3077 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3078 to EMACS_INT. Check that fixnums are in proper range for system types.
3079 * minibuf.c (minibuf_prompt_width, string_to_object)
3080 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3081 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3082 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3083 (get_minibuffer, read_minibuf_unwind):
3084 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3085 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3086 this simplifies overflow checking. All callers changed.
3087 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3089 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3090 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3091 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3092 Check that fixnums are in proper range for system types.
3093 (Fx_create_frame, Fx_show_tip):
3094 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3095 * nsfont.m (ns_findfonts, nsfont_list_family):
3096 Don't assume fixnum fits in long.
3097 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3098 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3099 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3101 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
3102 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3103 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3104 (PRINTDECLARE, PRINTPREPARE):
3105 (strout, print_string):
3106 (print, print_preprocess, print_check_string_charset_prop)
3108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3110 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3111 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3112 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
3113 (printchar, strout): Use xpalloc to catch size calculation overflow.
3114 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
3115 (print_error_message): Use SAFE_ALLOCA, not alloca.
3116 (print_object): Use int, not EMACS_INT, where int is wide enough.
3117 (print_depth, new_backquote_output, print_number_index):
3118 Use ptrdiff_t, not int, where int might not be wide enough.
3119 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3120 (Fset_process_window_size, Fformat_network_address)
3121 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
3123 Check that fixnums are in proper range for system types.
3124 (Fsignal_process): Simplify by avoiding a goto.
3125 Check for process-ids out of pid_t range rather than relying on
3127 (process_tick, update_tick): Use EMACS_INT, not int.
3128 (Fformat_network_address, read_process_output, send_process)
3129 (Fprocess_send_region, status_notify):
3130 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3131 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3132 (wait_reading_process_output, read_process_output, exec_sentinel):
3133 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3134 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3135 (Faccept_process_output): Use duration_to_sec_usec to do proper
3136 overflow checking on durations.
3137 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3138 Don't assume pid_t fits in int.
3139 * process.h (struct Lisp_Process): Members tick and update_tick
3140 are now of type EMACS_INT, not int.
3141 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3142 configured --with-wide-int.
3143 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3144 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3145 * search.c (looking_at_1, string_match_1):
3146 (fast_string_match, fast_c_string_match_ignore_case)
3147 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3148 (scan_newline, find_before_next_newline, search_command)
3149 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3150 (set_search_regs, wordify):
3153 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3154 (string_match_1, search_buffer, set_search_regs):
3156 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3157 (wordify): Check for overflow in size calculation.
3158 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3159 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3160 Check that fixnums are in proper range for system types.
3161 * sound.c (struct sound_device)
3162 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3163 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3164 (Fplay_sound_internal):
3165 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3166 * syntax.c (struct lisp_parse_state, find_start_modiff)
3167 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3168 (Fparse_partial_sexp):
3169 Don't assume fixnums can fit in int.
3170 (struct lisp_parse_state, find_start_pos, find_start_value)
3171 (find_start_value_byte, find_start_begv)
3172 (update_syntax_table, char_quoted, dec_bytepos)
3173 (find_defun_start, prev_char_comend_first, back_comment):
3174 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3175 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3176 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3177 (Finternal_describe_syntax_value): Check that match_lisp is a
3178 character, not an integer, since the code stuffs it into int.
3179 (scan_words, scan_sexps_forward):
3180 Check that fixnums are in proper range for system types.
3182 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3183 (scan_sexps_forward):
3184 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3185 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3186 * syntax.h: Adjust decls to match defn changes elsewhere.
3187 (struct gl_state_s):
3188 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3189 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3190 MOST_POSITIVE_FIXNUM.
3191 * sysdep.c (wait_for_termination_1, wait_for_termination)
3192 (interruptible_wait_for_termination, mkdir):
3193 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3194 (emacs_read, emacs_write):
3195 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3196 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3197 and double all fit in int.
3198 * term.c (set_tty_color_mode):
3199 Check that fixnums are in proper range for system types.
3200 * termhooks.h (struct input_event):
3201 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3202 * textprop.c (validate_interval_range, interval_of)
3203 (Fadd_text_properties, set_text_properties_1)
3204 (Fremove_text_properties, Fremove_list_of_text_properties)
3205 (Ftext_property_any, Ftext_property_not_all)
3206 (copy_text_properties, text_property_list, extend_property_ranges)
3207 (verify_interval_modification):
3208 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3209 (Fnext_single_char_property_change)
3210 (Fprevious_single_char_property_change):
3211 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3212 (copy_text_properties):
3213 Check for integer overflow in index calculation.
3214 * undo.c (last_boundary_position, record_point, record_insert)
3215 (record_delete, record_marker_adjustment, record_change)
3216 (record_property_change):
3217 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3218 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3219 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3220 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3221 (Fx_hide_tip, Fx_file_dialog):
3222 * w32menu.c (set_frame_menubar):
3223 Use ptrdiff_t, not int, for consistency with rest of code.
3224 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3225 (select_window, Fdelete_other_windows_internal)
3226 (window_scroll_pixel_based, window_scroll_line_based)
3227 (Frecenter, Fset_window_configuration):
3228 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3229 (Fset_window_hscroll, run_window_configuration_change_hook)
3230 (set_window_buffer, temp_output_buffer_show, scroll_command)
3231 (Fscroll_other_window, Frecenter):
3232 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3233 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3234 Don't assume fixnum fits in int.
3235 (Fset_window_scroll_bars):
3236 Check that fixnums are in proper range for system types.
3237 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3238 (string_pos, c_string_pos, number_of_chars, init_iterator)
3239 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3240 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3241 (compute_display_string_end, handle_face_prop)
3242 (face_before_or_after_it_pos, handle_invisible_prop)
3243 (handle_display_prop, handle_display_spec, handle_single_display_spec)
3244 (display_prop_intangible_p, string_buffer_position_lim)
3245 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3246 (get_overlay_strings_1, get_overlay_strings)
3247 (iterate_out_of_display_property, forward_to_next_line_start)
3248 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3249 (get_next_display_element, set_iterator_to_next)
3250 (get_visually_first_element, compute_stop_pos_backwards)
3251 (handle_stop_backwards, next_element_from_buffer)
3252 (move_it_in_display_line_to, move_it_in_display_line)
3253 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3254 (add_to_log, message_dolog, message_log_check_duplicate)
3255 (message2, message2_nolog, message3, message3_nolog
3256 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3257 (current_message_1, truncate_echo_area, truncate_message_1)
3258 (set_message, set_message_1, store_mode_line_noprop)
3259 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3260 (text_outside_line_unchanged_p, check_point_in_composition)
3261 (reconsider_clip_changes)
3262 (redisplay_internal, set_cursor_from_row, try_scrolling)
3263 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3264 (redisplay_window, find_last_unchanged_at_beg_row)
3265 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3266 (trailing_whitespace_p, find_row_edges, display_line)
3267 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3268 (display_mode_element, store_mode_line_string)
3269 (pint2str, pint2hrstr, decode_mode_spec)
3270 (display_count_lines, display_string, draw_glyphs)
3271 (x_produce_glyphs, x_insert_glyphs)
3272 (rows_from_pos_range, mouse_face_from_buffer_pos)
3273 (fast_find_string_pos, mouse_face_from_string_pos)
3274 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3275 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3276 (safe_call, init_from_display_pos, handle_fontified_prop)
3277 (handle_single_display_spec, load_overlay_strings)
3278 (with_echo_area_buffer, setup_echo_area_for_printing)
3279 (display_echo_area, echo_area_display)
3280 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3281 (update_tool_bar, hscroll_window_tree, redisplay_internal)
3282 (redisplay_window, dump_glyph_row, display_mode_line)
3283 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
3284 (handle_display_spec, display_prop_string_p):
3285 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3286 (handle_single_display_spec, build_desired_tool_bar_string)
3287 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3288 (get_specified_cursor_type):
3289 Check that fixnums are in proper range for system types.
3290 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3291 (Flookup_image_map):
3292 Don't assume fixnums fit in int.
3293 (compare_overlay_entries):
3294 Avoid mishandling comparisons due to subtraction overflow.
3295 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3296 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3297 (handle_tool_bar_click):
3298 Use int, not unsigned, since we prefer signed and the signedness
3299 doesn't matter here.
3300 (get_next_display_element, next_element_from_display_vector):
3301 Use int, not EMACS_INT, when int is wide enough.
3302 (start_hourglass): Use duration_to_sec_usec to do proper
3303 overflow checking on durations.
3304 * xfaces.c (Fbitmap_spec_p):
3305 Check that fixnums are in proper range for system types.
3306 (compare_fonts_by_sort_order):
3307 Avoid mishandling comparisons due to subtraction overflow.
3308 (Fx_family_fonts, realize_basic_faces):
3309 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3311 Don't assume fixnum fits in int.
3312 Use SAFE_ALLOCA_LISP, not alloca.
3313 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3314 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3315 (face_at_buffer_position, face_for_overlay_string)
3316 (face_at_string_position):
3317 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3318 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3319 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3321 Check that fixnums are in proper range for system types.
3322 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3323 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3324 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3325 (Fx_change_window_property): Don't assume fixnums fit in int.
3326 * xfont.c (xfont_chars_supported):
3327 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3328 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3329 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3330 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3331 * xml.c (parse_region):
3332 * xrdb.c (magic_file_p):
3333 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3334 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3335 (x_get_local_selection, x_reply_selection_request)
3336 (x_handle_selection_request, wait_for_property_change):
3337 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3338 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3339 short is wide enough.
3340 (x_send_client_event): Don't assume fixnum fits in int.
3341 * xterm.c (x_x_to_emacs_modifiers):
3342 Don't assume EMACS_INT overflows nicely into int.
3343 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3345 (handle_one_xevent): NATNUMP can eval its arg twice.
3346 (x_connection_closed):
3347 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3348 * xterm.h: Adjust decls to match defn changes elsewhere.
3349 (struct scroll_bar): Use struct vectorlike_header
3350 rather than rolling our own approximation.
3351 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3353 2012-05-25 Glenn Morris <rgm@gnu.org>
3355 * lisp.mk (lisp): Update for more files being compiled now.
3357 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3359 * lread.c: Remove `read_pure' which makes no difference.
3360 (read_pure): Remove var.
3361 (unreadpure): Remove function.
3362 (readevalloop): Don't call read_list with -1 flag.
3363 (read1, read_vector): Don't test read_pure any more.
3364 (read_list): Simplify.
3366 * fileio.c, character.h: Minor style tweaks.
3368 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3370 * window.h (clip_changed): Remove useless declaration.
3372 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
3374 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3375 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3377 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3380 This directory predates autoconf and is no longer needed nowadays.
3381 Move its few remaining bits of functionality to where they're needed.
3382 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3383 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3384 * m/template.h: Remove.
3385 * Makefile.in (M_FILE): Remove. All uses removed.
3386 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3387 * lisp.h (USE_LSB_TAG):
3388 * mem-limits.h (EXCEEDS_LISP_PTR):
3389 Use VAL_MAX, not VALBITS, in #if.
3390 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3391 (EMACS_UINT): Define unconditionally now.
3392 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3393 (BITS_PER_EMACS_INT): New constants, replacing
3394 what used to be in config.h, but not useful in #if.
3395 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3396 define them any more.
3397 (VAL_MAX): New macro.
3399 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3400 BITS_PER_EMACS_INT, in #if.
3401 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3402 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3403 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3404 * s/ms-w32.h (DATA_START):
3405 Move here from removed file m/intel386.h.
3406 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3407 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3409 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3411 Assume C89 or later.
3412 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3413 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3415 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3416 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3417 * textprop.c, tparam.c (NULL): Remove.
3418 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3419 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3420 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3421 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3422 * xterm.c (input_signal_count): Assume volatile works.
3424 2012-05-21 Ken Brown <kbrown@cornell.edu>
3426 * xgselect.c (xg_select): Fix first argument in call to 'select'
3429 2012-05-20 Ken Brown <kbrown@cornell.edu>
3431 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
3432 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
3434 2012-05-19 Ken Brown <kbrown@cornell.edu>
3436 * xfns.c (x_in_use): Remove `static' qualifier.
3437 * xterm.h (x_in_use): Declare.
3438 * xgselect.c: Include xterm.h.
3439 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3440 and `display_arg' (bug#9754).
3442 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3444 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3446 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3447 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3449 2012-05-18 Eli Zaretskii <eliz@gnu.org>
3451 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3453 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
3454 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
3456 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3457 reference to image_cache->refcount.
3458 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3460 2012-05-17 Juri Linkov <juri@jurta.org>
3462 * search.c (Fword_search_regexp, Fword_search_backward)
3463 (Fword_search_forward, Fword_search_backward_lax)
3464 (Fword_search_forward_lax): Move functions to isearch.el
3465 (bug#10145, bug#11381).
3467 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3469 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3471 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3473 * lread.c (init_obarray): Declare Qt and Qnil as special.
3475 2012-05-14 Glenn Morris <rgm@gnu.org>
3477 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
3478 Put "libexec" before "bin", for the sake of init_callproc_1.
3480 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3482 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3484 * unexaix.c: Port to more-recent AIX compilers.
3485 (report_error, report_error_1, make_hdr, copy_sym)
3486 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3487 Make arguments const char *, not char *, to avoid violations of C
3488 standard and to fix some AIX warnings reported by Gilles Pion.
3490 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3492 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3493 already have overlays loaded.
3494 (handle_single_display_spec): Before returning without displaying
3495 fringe bitmap, synchronize the bidi iterator with the main display
3496 iterator, by calling iterate_out_of_display_property.
3497 (iterate_out_of_display_property): Detect buffer iteration by
3498 testing that it->string is a Lisp string.
3499 (get_next_display_element): When the current object is exhausted,
3500 and there's something on it->stack, call set_iterator_to_next to
3501 proceed with what's on the stack, instead of returning zero.
3502 (set_iterator_to_next): If called at the end of a Lisp string,
3503 proceed to consider_string_end without incrementing string
3504 position. Don't increment display vector index past the end of
3505 the display vector. (Bug#11417)
3506 (pos_visible_p): Don't report a position visible when move_it_to
3507 stopped at the last line of window, which happens to be scanned
3508 backwards by the bidi iteration. (Bug#11464)
3510 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3512 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3513 and right-margin display specs even if the spec is invalid or we
3514 are on a TTY, and thus unable to display on the fringes.
3515 That's because the text with the property will not be displayed anyway,
3516 so we need to signal to the caller that this is a "replacing"
3517 display spec. This fixes display when the spec is invalid or we
3520 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3522 * unexaix.c (make_hdr): Fix typo in prototype.
3523 This bug broke the build on AIX. Problem reported by Gilles Pion.
3525 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
3527 * keyboard.c (kbd_buffer_get_event): Read special events also in
3528 batch mode. (Bug#11415)
3530 2012-05-12 Glenn Morris <rgm@gnu.org>
3532 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3534 2012-05-12 Eli Zaretskii <eliz@gnu.org>
3536 * lisp.mk (lisp): Add newcomment.elc.
3538 2012-05-12 Glenn Morris <rgm@gnu.org>
3540 * Makefile.in (MKDIR_P): New, set by configure.
3541 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3543 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3545 Remove unused function hourglass_started.
3546 * dispextern.h (hourglass_started):
3547 * w32fns.c (hourglass_started):
3548 * xdisp.c (hourglass_started): Remove.
3550 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
3552 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3553 Update dependencies.
3555 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3557 * xgselect.c (xg_select): Put maxfds+1 into a var.
3558 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3560 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3562 2012-05-10 Dave Abrahams <dave@boostpro.com>
3564 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3565 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3567 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
3569 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3570 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3571 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3572 Initialize xd_registered_buses.
3574 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3576 Untag more efficiently if USE_LSB_TAG.
3577 This is based on a proposal by YAMAMOTO Mitsuharu in
3578 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3579 For an admittedly artificial (nth 8000 longlist) benchmark on
3580 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3581 Emacs's overall text size by 1%.
3582 * lisp.h (XUNTAG): New macro.
3583 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3584 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3585 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3586 * eval.c (Fautoload):
3587 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3588 * frame.h (XFRAME): Use XUNTAG.
3590 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3591 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3592 Remove unportable assumptions about print widths of types like
3594 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3595 intptr_t when converting between pointer and integer, to avoid GCC
3596 warnings about wrong width.
3598 2012-05-09 Eli Zaretskii <eliz@gnu.org>
3600 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3601 stack for each reader_thread, instead of defaulting to 8MB
3602 determined by the linker. This avoids failures in creating
3603 subprocesses on Windows 7, see the discussion in this thread:
3604 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3606 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3608 Fix up display of the *Minibuf-0* buffer in the mini window.
3609 * keyboard.c (read_char): Don't clear the echo area if there's no
3611 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
3612 contents of *Minibuf-0*) if there's no message displayed in its stead.
3614 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
3616 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3619 2012-05-06 Chong Yidong <cyd@gnu.org>
3621 * lisp.mk (lisp): Update.
3623 2012-05-05 Jim Meyering <meyering@redhat.com>
3625 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3627 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3629 * data.c (PUT_ERROR): New macro.
3630 (syms_of_data): Use it. Add new error type `user-error'.
3631 * undo.c (user_error): New function.
3632 (Fprimitive_undo): Use it.
3633 * print.c (print_error_message): Adjust print style for `user-error'.
3634 * keyboard.c (user_error): New function.
3635 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3637 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3639 Do not limit current-time-string to years 1000..9999.
3640 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3641 (Fcurrent_time_string): Support any year that is supported by the
3642 underlying localtime representation. Don't use asctime, as it
3643 has undefined behavior for years outside the range -999..9999.
3645 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3647 Fix race conditions involving setenv, gmtime, localtime, asctime.
3648 Without this fix, interrupts could mess up code that uses these
3649 nonreentrant functions, since setting TZ invalidates existing
3650 tm_zone or tzname values, and since most of these functions return
3651 pointers to static storage.
3652 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3653 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3654 Grow the critical sections to include not just invoking
3655 localtime/gmtime, but also accessing these functions' results
3656 including their tm_zone values if any, and any related TZ setting.
3657 (format_time_string): Last arg is now struct tm *, not struct tm **,
3658 so that the struct tm is saved in the critical section.
3659 All callers changed. Simplify allocation of initial buffer, partly
3660 motivated by the fact that memory allocation needs to be outside
3661 the critical section.
3663 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3665 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3666 with RESET_INTERVAL.
3668 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3669 Remove duplicated buffer name initialization.
3671 2012-05-02 Jim Meyering <jim@meyering.net>
3673 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3675 * xfns.c (x_window): Use xstrdup (Bug#11375).
3677 2012-05-02 Eli Zaretskii <eliz@gnu.org>
3679 * xdisp.c (pos_visible_p): If already at a newline from the
3680 display string before the 'while' loop, don't walk back the glyphs
3681 from it3.glyph_row. Solves assertion violation when the display
3682 string begins with a newline (egg.el). (Bug#11367)
3684 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3686 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3689 2012-05-01 Glenn Morris <rgm@gnu.org>
3691 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3692 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3693 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3694 All were removed before 23.1.
3696 * dispnew.c: Remove HAVE_LIBNCURSES test;
3697 it is always true on relevant platforms.
3699 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3700 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3702 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3704 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3706 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3707 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3710 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3712 Do not avoid creating empty evaporating overlays (Bug#9642).
3713 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3714 That is, do not delete an evaporating overlay if it becomes
3715 empty after its bounds are adjusted to fit within its buffer.
3716 This fix caused other problems, and I'm reverting it until we get
3717 to the bottom of them.
3719 2012-04-27 Chong Yidong <cyd@gnu.org>
3721 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3723 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3725 * xdisp.c (pos_visible_p): If the window start position is beyond
3726 ZV, start the display from buffer beginning. Prevents assertion
3727 violation in init_iterator when the minibuffer window is scrolled
3730 * window.c (window_scroll_pixel_based): Likewise.
3732 2012-04-27 Chong Yidong <cyd@gnu.org>
3734 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3736 2012-04-27 Glenn Morris <rgm@gnu.org>
3738 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3739 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3741 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3743 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3744 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
3746 2012-04-26 Eli Zaretskii <eliz@gnu.org>
3748 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3749 display element, check also the underlying string or buffer
3750 character. (Bug#11341)
3752 * w32menu.c: Include w32heap.h.
3753 (add_menu_item): If the call to AppendMenuW (via
3754 unicode_append_menu) fails, disable Unicode menus only if we are
3755 running on Windows 9X/Me.
3757 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3759 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3760 (xgetint): Add missing shift for LSB tags.
3762 2012-04-24 Martin Rudalics <rudalics@gmx.at>
3764 * keyboard.c (read_char): Don't wipe echo area for select window
3765 events: These might get delayed via `mouse-autoselect-window'
3768 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
3770 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3771 manipulation of :loaded-from data.
3773 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
3775 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3776 now a cons (bug#11311).
3778 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3780 Do not create empty overlays with the evaporate property (Bug#9642).
3781 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3782 if it becomes empty after its bounds are adjusted to fit within
3783 its buffer. Without this fix, in a nonempty buffer (let ((o
3784 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3785 yields an empty overlay that has the evaporate property, which is
3786 not supposed to happen.
3788 Fix minor GTK3 problems found by static checking.
3789 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3790 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3791 (struct _EmacsFixedClass, emacs_fixed_get_type):
3792 Move decls here from emacsgtkfixed.h, since they needn't be public.
3793 (emacs_fixed_get_type): Now static.
3794 (emacs_fixed_class_init): Omit unused local.
3795 (emacs_fixed_child_type): Remove; unused.
3796 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3797 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3798 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3799 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3800 (EMACS_FIXED_GET_CLASS): Remove; unused.
3801 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3803 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3804 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3806 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3808 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3809 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3810 (__malloc_size_t, __malloc_ptrdiff_t):
3811 Remove. All uses removed, replaced by the definiens if needed,
3812 since we can assume C89 or better now.
3813 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3814 (protect_malloc_state, align, get_contiguous_space)
3815 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3816 (malloc_atfork_handler_child, malloc_enable_thread)
3817 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3818 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3819 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3820 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3821 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3822 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3823 Define using prototypes, not old style.
3824 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3825 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3826 (align): Don't assume that signed integer overflow wraps around.
3827 Omit unused local var.
3828 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3829 (_free_internal_nolock, memalign, mallochook, reallochook):
3830 Omit no-longer-needed casts.
3831 (valloc): Use getpagesize, not __getpagesize.
3832 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3833 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3835 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3837 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3839 Move functions from C to Lisp. Make non-blocking method calls
3840 the default. Implement further D-Bus standard interfaces.
3842 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3843 (QCdbus_request_name_allow_replacement)
3844 (QCdbus_request_name_replace_existing)
3845 (QCdbus_request_name_do_not_queue)
3846 (QCdbus_request_name_reply_primary_owner)
3847 (QCdbus_request_name_reply_in_queue)
3848 (QCdbus_request_name_reply_exists)
3849 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3850 (QCdbus_registered_serial, QCdbus_registered_method)
3851 (QCdbus_registered_signal): New Lisp objects.
3852 (XD_DEBUG_MESSAGE): Use sizeof.
3853 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3854 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3855 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3856 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3857 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3858 (xd_signature, xd_append_arg): Allow float for integer types.
3859 (xd_get_connection_references): New function.
3860 (xd_get_connection_address): Rename from xd_initialize.
3861 Return cached address.
3862 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3863 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3865 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
3866 Return number of refcounts.
3867 (Fdbus_get_unique_name): Make stronger parameter check.
3868 (Fdbus_message_internal): New defun.
3869 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3870 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3871 (Fdbus_send_signal, Fdbus_register_service)
3872 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3873 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3874 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3875 (Vdbus_compiled_version, Vdbus_runtime_version)
3876 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3877 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3878 (Vdbus_message_type_signal): New defvars.
3879 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3882 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3884 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3885 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3886 Do not assume ptrdiff_t is the same width as 'int'.
3888 * alloc.c: Handle unusual debugging option combinations.
3889 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3890 since the two debugging options are incompatible.
3891 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3893 (mem_init, mem_insert, mem_insert_fixup):
3894 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3895 (NEED_MEM_INSERT): Remove; no longer needed.
3897 2012-04-22 Leo Liu <sdl.web@gmail.com>
3899 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3901 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3903 * sysdep.c [__FreeBSD__]: Minor cleanups.
3904 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3905 Use Emacs indenting style more consistently. Avoid some casts.
3906 Use 'double' consistently rather than mixing 'float' and 'double'.
3908 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3910 * sysdep.c (list_system_processes, system_process_attributes):
3911 Add implementation for FreeBSD (Bug#5243).
3913 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3915 * lisp.mk (lisp): Update.
3917 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3919 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3920 It is never used otherwise.
3922 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3924 * print.c (print_preprocess): Only check print_depth if print-circle
3926 (print_object): Check for cycles even when print-circle is nil and
3927 print-gensym is t, but only check print_depth if print-circle is nil.
3929 2012-04-20 Chong Yidong <cyd@gnu.org>
3931 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3932 set the status to "failed" and ensure that sentinel is run.
3934 2012-04-20 Glenn Morris <rgm@gnu.org>
3936 * process.c (Fset_process_inherit_coding_system_flag)
3937 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
3938 (Fmake_network_process, Fmake_serial_process): Doc fix.
3940 2012-04-20 Eli Zaretskii <eliz@gnu.org>
3942 * xdisp.c (string_buffer_position_lim): Limit starting position to
3944 (set_cursor_from_row): If called for a mode-line or header-line
3945 row, return zero immediately.
3946 (try_cursor_movement): If inside continuation line, don't back up
3947 farther than the first row after the header line, if any.
3948 Don't consider the header-line row as "partially visible", even if
3949 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3951 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3953 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3956 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
3957 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
3959 configure: new option --enable-gcc-warnings (Bug#11207)
3960 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3961 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3962 (ALL_CFLAGS): Use new macros rather than old.
3963 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3964 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3965 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3966 -Wunused-result, -Wunused-variable. This should go away once
3967 the Emacs and Gnulib regex code is merged.
3968 (xmalloc, xrealloc): Now static.
3970 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3972 * dired.c (Fsystem_groups): Remove unused local.
3974 2012-04-17 Glenn Morris <rgm@gnu.org>
3976 * dired.c (Fsystem_users): Doc fix.
3978 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3980 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3981 (syms_of_dired): Add them.
3983 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3985 Fix minor alloc.c problems found by static checking.
3986 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3987 New extern decls, to avoid calling undeclared functions.
3988 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3989 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3990 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3991 (NEED_MEM_INSERT): New macro.
3992 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
3993 Remove one incorrect comment and fix another.
3995 Fix minor ralloc.c problems found by static checking.
3996 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3997 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3998 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3999 (r_alloc_sbrk): Now static.
4001 Improve ralloc.c interface checking.
4002 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4003 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4004 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4005 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4006 [REL_ALLOC]: ... to here, to check interface.
4007 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4008 Remove decls. This fixes an "It stinks!".
4010 * alloc.c (which_symbols): Fix alignment issue / type clash.
4012 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4014 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4015 (struct Lisp_Misc_Any): Likewise.
4016 (struct Lisp_Free): Likewise.
4017 * alloc.c (union aligned_Lisp_Symbol): Define.
4018 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4019 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4020 (union aligned_Lisp_Misc): Define.
4021 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4022 aligned_Lisp_Misc instead of union Lisp_Misc.
4023 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
4025 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4027 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4028 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4029 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4030 * s/netbsd.h, s/sol2-6.h:
4031 Remove definition of GC_MARK_STACK, since the default now works.
4032 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4033 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4034 no longer the default.
4035 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4037 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4039 * lread.c (lisp_file_lexically_bound_p):
4040 Fix hang at ";-*-\n" (bug#11238).
4042 2012-04-14 Eli Zaretskii <eliz@gnu.org>
4044 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4045 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4047 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4049 * nsterm.m (constrainFrameRect): Always constrain when there is only
4050 one screen (Bug#10962).
4052 2012-04-13 Ken Brown <kbrown@cornell.edu>
4054 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4056 2012-04-13 Reuben Thomas <rrt@sc3d.org>
4058 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4060 2012-04-11 Daniel Colascione <dancol@dancol.org>
4062 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4063 against is gone. It's better to use vfork now so that when Cygwin
4064 gains a new, working vfork, we use it automatically (bug#10398).
4066 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4068 * window.c (save_window_save): Obey window-point-insertion-type.
4070 2012-04-11 Glenn Morris <rgm@gnu.org>
4072 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4074 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4076 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4078 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
4080 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4081 (force_quit_count): New var.
4082 (handle_interrupt): Use it.
4084 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
4086 * w32.c (w32_delayed_load): Record the full path of the library
4087 being loaded (bug#10424).
4089 2012-04-09 Glenn Morris <rgm@gnu.org>
4091 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4092 not just in the obarray, before snarfing them. (Bug#11036)
4094 * Makefile.in ($(leimdir)/leim-list.el):
4095 Pass EMACS rather than BUILT_EMACS.
4097 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4099 * process.c (make_process):
4100 * process.h: Add integer `gnutls_handshakes_tried' member to
4103 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4104 Add convenience `GNUTLS_LOG2i' macro.
4106 * gnutls.c (gnutls_log_function2i): Convenience log function.
4107 (emacs_gnutls_read): Use new log functions,
4108 `gnutls_handshakes_tried' process member, and
4109 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4110 attempts per process (connection).
4112 2012-04-09 Chong Yidong <cyd@gnu.org>
4114 * eval.c (Fuser_variable_p, user_variable_p_eh)
4115 (lisp_indirect_variable): Functions deleted.
4116 (Fdefvar): Caller changed.
4118 * callint.c (Finteractive, Fcall_interactively):
4119 * minibuf.c (Fread_variable): Callers changed.
4121 2012-04-09 Eli Zaretskii <eliz@gnu.org>
4123 * xdisp.c (set_cursor_from_row): If the display string appears in
4124 the buffer at position that is closer to point than the position
4125 after the display string, display the cursor on the first glyph of
4126 the display string. Fixes cursor display when a 'display' text
4127 property immediately follows invisible text. (Bug#11094)
4129 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4131 composite.c: use 'double' consistently
4132 * composite.c (get_composition_id): Use 'double' consistently
4133 instead of converting 'float' to 'double' and vice versa; this is
4134 easier to understand and avoids a GCC warning.
4136 2012-04-09 Glenn Morris <rgm@gnu.org>
4138 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4139 preparation for dumping it with emacs. (Bug#4789)
4140 (leimdir): New variable.
4141 ($(leimdir)/leim-list.el): New rule.
4142 (emacs$(EXEEXT)): Depend on leim-list.el.
4144 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4145 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4146 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4148 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4150 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4153 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
4155 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4156 Remove unused local variable.
4158 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4160 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4161 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4162 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4163 objects, as mark_maybe_pointer will catch them otherwise.
4164 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4165 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4167 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4169 Fix typo that broke non-Windows builds.
4170 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4172 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4174 Support building on MS-Windows with libxml2.
4176 * makefile.w32-in (OBJ2): Add xml.$(O).
4177 (GLOBAL_SOURCES): Add xml.c.
4178 ($(BLD)/xml.$(O)): New dependency list.
4180 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4181 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4182 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4183 [!WINDOWSNT]: New macros.
4184 (init_libxml2_functions, libxml2_loaded_p): New functions.
4185 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4186 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4187 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4188 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4190 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4191 Call init_libxml2_functions before calling libxml2 functions.
4192 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4194 * emacs.c: Don't include libxml/parser.h.
4195 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4196 xmlCleanupParser directly.
4198 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4200 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4202 * indent.c (Fvertical_motion): If there is a display string at
4203 point, use it.vpos to compute how many lines to backtrack after
4204 move_it_to point. (Bug#11133)
4206 2012-04-06 Eli Zaretskii <eliz@gnu.org>
4208 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4209 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4210 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4211 macros related to unification of CJK characters. For the details,
4212 see the discussion following the message here:
4213 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4215 2012-04-04 Chong Yidong <cyd@gnu.org>
4217 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4219 2012-04-01 Eli Zaretskii <eliz@gnu.org>
4221 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4222 instead of alloca. (Bug#11138)
4224 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4226 * w32menu.c (is_simple_dialog): Properly check lisp types.
4229 2012-03-31 Eli Zaretskii <eliz@gnu.org>
4231 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4232 position we get to after a call to move_it_to fails the
4233 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4234 only if we wind up in a string from display property. (Bug#11063)
4236 * window.c (Fdelete_other_windows_internal): Invalidate the row
4237 and column information about mouse highlight, so that redisplay
4238 restores it after reallocating the glyph matrices. (Bug#7464)
4240 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4241 string comes from a `display' text property, use the buffer
4242 position of that property as if we actually saw that position in
4244 (move_it_by_lines): Remove the assertion that
4245 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4246 violated when there's a before-string at the beginning of a line.
4249 2012-03-30 Eli Zaretskii <eliz@gnu.org>
4251 * xdisp.c (append_space_for_newline): If the default face was
4252 remapped, use the remapped face for the appended newline.
4253 (extend_face_to_end_of_line): Use the remapped default face for
4254 extending the face to the end of the line.
4255 (display_line): Call extend_face_to_end_of_line when the default
4256 face was remapped. (Bug#11068)
4258 2012-03-29 Eli Zaretskii <eliz@gnu.org>
4260 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4262 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4264 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4266 2012-03-27 Glenn Morris <rgm@gnu.org>
4268 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4271 2012-03-26 Kenichi Handa <handa@m17n.org>
4273 * dispextern.h (struct glyph): Fix previous change. Change the
4274 bit length of glyphless.ch to 25 (Bug#11082).
4276 2012-03-26 Chong Yidong <cyd@gnu.org>
4278 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4279 (command_loop_1): Use it; inhibit selection update for
4280 handle-select-window too (Bug#8996).
4282 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4284 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
4286 2012-03-25 Kenichi Handa <handa@m17n.org>
4288 * dispextern.h (struct glyph): Change the bit length of
4289 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4291 2012-03-24 Eli Zaretskii <eliz@gnu.org>
4293 * s/ms-w32.h (tzname): Include time.h before redirecting to
4294 _tzname. Fixes the MSVC build. (Bug#9960)
4296 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4298 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4301 * xterm.c (XTread_socket): Only modify handling_signal if
4302 !SYNC_INPUT. (Bug#11080)
4304 2012-03-23 Eli Zaretskii <eliz@gnu.org>
4306 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4307 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4308 when fetching a multibyte character consumes more bytes than
4309 CHAR_BYTES returns, due to unification of CJK characters in
4310 string_char. (Bug#11073)
4312 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4314 * process.c (wait_reading_process_output): Handle pty disconnect
4315 by refraining from sending oneself a SIGCHLD (bug#10933).
4317 2012-03-22 Chong Yidong <cyd@gnu.org>
4319 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4321 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
4322 Mark string as coming from a prefix property.
4323 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4324 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4326 2012-03-21 Chong Yidong <cyd@gnu.org>
4328 * xfaces.c (Vface_remapping_alist): Doc fix.
4330 2012-03-20 Eli Zaretskii <eliz@gnu.org>
4332 * w32proc.c (Fw32_set_console_codepage)
4333 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4336 2012-03-20 Chong Yidong <cyd@gnu.org>
4338 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4339 to reflect default non-nil value of redisplay-dont-pause.
4341 2012-03-19 Kenichi Handa <handa@m17n.org>
4343 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4344 it fit in a valid range (Bug#11003).
4346 2012-03-18 Eli Zaretskii <eliz@gnu.org>
4348 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4349 that is not from display property, accept the row as a "cursor
4350 row" if one of the string's character has a non-nil `cursor'
4351 property. Fixes cursor positioning when there are newlines in
4352 overlay strings, e.g. in icomplete.el. (Bug#11035)
4354 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4356 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4358 2012-03-12 Chong Yidong <cyd@gnu.org>
4360 * eval.c (inhibit_lisp_code): Rename from
4361 inhibit_window_configuration_change_hook; move from window.c.
4363 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4364 * window.c (run_window_configuration_change_hook)
4365 (syms_of_window): Callers changed.
4367 2012-03-11 Chong Yidong <cyd@gnu.org>
4369 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4371 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4373 2012-03-10 Chong Yidong <cyd@gnu.org>
4375 * frame.c (other_visible_frames): Don't assume the selected frame
4376 is visible (Bug#10955).
4378 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4380 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4382 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4384 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4385 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4388 2012-03-03 Glenn Morris <rgm@gnu.org>
4390 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
4392 2012-03-02 Eli Zaretskii <eliz@gnu.org>
4394 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4395 position past the first glyph_row that ends at ZV. (Bug#10902)
4396 (redisplay_window, next_element_from_string): Fix typos in
4398 (redisplay_window): Pass to move_it_vertically the margin in
4399 pixels, not in screen lines.
4401 2012-03-02 Glenn Morris <rgm@gnu.org>
4403 * buffer.c (buffer-list-update-hook): Doc fix.
4405 2012-02-29 Eli Zaretskii <eliz@gnu.org>
4407 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4408 push_it before setting up the iterator for the first overlay
4409 string, even if we have an empty string loaded.
4410 (next_overlay_string): If there's an empty string on the iterator
4411 stack, pop the stack. (Bug#10903)
4413 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4415 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4416 Suggested by Stefan Monnier in
4417 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4418 * alloc.c (widen_to_Lisp_Object): New static function.
4419 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4420 and widening them to Lisp_Objects. This would work even if
4421 USE_LSB_TAG is defined and wide integers are used, which might
4422 happen in a future version of Emacs.
4424 2012-02-25 Chong Yidong <cyd@gnu.org>
4426 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4429 * xselect.c (Fx_selection_exists_p): Doc fix.
4430 (x_clipboard_manager_save_all): Print an informative message
4431 before saving to clipboard manager.
4433 2012-02-24 Chong Yidong <cyd@gnu.org>
4435 * keyboard.c (process_special_events): Handle all X selection
4436 requests in kbd_buffer, not just the next one (Bug#8869).
4438 2012-02-23 Chong Yidong <cyd@gnu.org>
4440 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4441 call when setting menu-bar-lines and tool-bar-lines parameters.
4442 (unwind_create_frame_1): New helper function.
4444 * window.c (inhibit_window_configuration_change_hook): New var.
4445 (run_window_configuration_change_hook): Obey it.
4446 (syms_of_window): Initialize it.
4448 2012-02-22 Chong Yidong <cyd@gnu.org>
4450 * xterm.c (x_draw_image_relief): Add missing type check for
4451 Vtool_bar_button_margin (Bug#10743).
4453 2012-02-21 Chong Yidong <cyd@gnu.org>
4455 * fileio.c (Vfile_name_handler_alist): Doc fix.
4457 * buffer.c (Fget_file_buffer): Protect against invalid file
4458 handler return value.
4460 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4462 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4463 when computing $valmask.
4465 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4466 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4467 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4468 It's useless in that case, and it can cause problems on hosts
4469 that allocate halves of EMACS_INT values separately.
4470 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4471 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4472 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4473 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4474 it avoids undefined behavior on hosts where shifting right by more
4475 than the word width has undefined behavior.
4477 2012-02-19 Chong Yidong <cyd@gnu.org>
4479 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4480 (Funhandled_file_name_directory, Ffile_name_as_directory)
4481 (Fdirectory_file_name, Fexpand_file_name)
4482 (Fsubstitute_in_file_name): Protect against invalid file handler
4483 return values (Bug#10845).
4485 2012-02-18 Eli Zaretskii <eliz@gnu.org>
4487 * .gdbinit (pitx): Fix incorrect references to fields of the
4490 2012-02-17 Chong Yidong <cyd@gnu.org>
4492 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4494 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4496 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4497 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4499 2012-02-15 Chong Yidong <cyd@gnu.org>
4501 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4502 marked as special. Also, starting docstrings with * is obsolete.
4504 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4506 * gnutls.c (emacs_gnutls_write): Fix last change.
4508 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4510 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4513 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4515 * keymap.c (Fsingle_key_description): Handle char ranges.
4517 2012-02-12 Chong Yidong <cyd@gnu.org>
4519 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4520 as that creates a dangerous corner case.
4522 * window.c (Fdelete_window_internal): Invalidate the mouse
4523 highlight (Bug#9904).
4525 2012-02-12 Glenn Morris <rgm@gnu.org>
4527 * xselect.c (Fx_own_selection_internal)
4528 (Fx_get_selection_internal, Fx_disown_selection_internal)
4529 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4530 * nsselect.m (Fx_own_selection_internal)
4531 (Fx_disown_selection_internal, Fx_selection_exists_p)
4532 (Fx_selection_owner_p, Fx_get_selection_internal):
4533 Sync docs and argument specs with the xselect.c versions.
4535 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4537 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4539 2012-02-11 Eli Zaretskii <eliz@gnu.org>
4541 * w32select.c (Fx_selection_exists_p): Sync doc string and
4542 argument list with xselect.c. (Bug#10783)
4544 * w16select.c (Fx_selection_exists_p): Sync doc string and
4545 argument list with xselect.c. (Bug#10783)
4547 2012-02-10 Glenn Morris <rgm@gnu.org>
4549 * fns.c (Fsecure_hash): Doc fix.
4551 2012-02-09 Kenichi Handa <handa@m17n.org>
4553 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4555 2012-02-07 Chong Yidong <cyd@gnu.org>
4557 * buffer.c (Fbuffer_local_variables)
4558 (buffer_lisp_local_variables): Handle unbound vars correctly;
4559 don't let Qunbound leak into Lisp.
4561 2012-02-07 Glenn Morris <rgm@gnu.org>
4563 * image.c (Fimagemagick_types): Doc fix.
4565 * image.c (imagemagick-render-type): Change it from a lisp object
4566 to an integer. Move the doc here from the lisp manual.
4567 Treat all values not equal to 0 the same.
4569 2012-02-06 Chong Yidong <cyd@gnu.org>
4571 * doc.c (store_function_docstring): Avoid applying docstring of
4572 alias to base function (Bug#2603).
4574 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4576 * .gdbinit (pp1, pv1): Remove redundant defines.
4579 2012-02-04 Chong Yidong <cyd@gnu.org>
4581 * nsterm.m: Declare a global (Bug#10694).
4583 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4585 * w32.c (get_emacs_configuration_options):
4586 Include --enable-checking, if specified, in the return value.
4588 2012-02-04 Martin Rudalics <rudalics@gmx.at>
4590 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4591 after rounding frame sizes. (Bug#9723)
4593 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4595 * keyboard.c (adjust_point_for_property): Don't position point
4596 before BEGV. (Bug#10696)
4598 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4600 Handle overflow when computing char display width (Bug#9496).
4601 * character.c (char_width): Return EMACS_INT, not int.
4602 (char_width, c_string_width): Check for overflow when
4603 computing the width; this is possible now that individual
4604 characters can have unbounded width. Problem introduced
4605 by merge from Emacs 23 on 2012-01-19.
4607 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
4609 * dbusbind.c (Fdbus_register_method): Mention the return value
4610 :ignore in the docstring.
4612 2012-02-02 Glenn Morris <rgm@gnu.org>
4614 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4616 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4617 Unconditionally set to t. (Bug#10673)
4618 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4619 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4620 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4622 2012-02-02 Kenichi Handa <handa@m17n.org>
4624 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4625 0, do not call append_composite_glyph.
4627 2012-02-02 Kenichi Handa <handa@m17n.org>
4629 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4631 (x_produce_glyphs): If the component of a composition is a null
4632 string, set it->pixel_width to 1 to avoid zero-width glyph.
4634 2012-02-01 Eli Zaretskii <eliz@gnu.org>
4636 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4637 first 2 arguments are identical. This makes inserting large
4638 output from a subprocess an order of magnitude faster on
4639 MS-Windows, where all sbrk'ed memory is always contiguous.
4641 2012-01-31 Glenn Morris <rgm@gnu.org>
4643 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4644 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4645 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4647 2012-01-29 Glenn Morris <rgm@gnu.org>
4649 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4651 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4653 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4655 2012-01-28 Chong Yidong <cyd@gnu.org>
4657 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4659 2012-01-26 Chong Yidong <cyd@gnu.org>
4661 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4663 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4664 repeat counts (Bug#10507).
4666 2012-01-26 Glenn Morris <rgm@gnu.org>
4668 * lread.c (syms_of_lread): Doc fix.
4670 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4672 * coding.c (encode_designation_at_bol): Change return value to
4675 2012-01-25 Chong Yidong <cyd@gnu.org>
4677 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4679 2012-01-21 Chong Yidong <cyd@gnu.org>
4681 * floatfns.c (Fcopysign): Make the second argument non-optional,
4682 since nil is not allowed anyway.
4684 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4686 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4687 (send_process): Likewise.
4689 2012-01-19 Martin Rudalics <rudalics@gmx.at>
4691 * window.c (save_window_save, Fcurrent_window_configuration)
4692 (Vwindow_persistent_parameters): Do not use Qstate.
4693 Rewrite doc-strings.
4695 2012-01-19 Kenichi Handa <handa@m17n.org>
4697 * character.c (char_width): New function.
4698 (Fchar_width, c_string_width, lisp_string_width):
4699 Use char_width (Bug#9496).
4701 2012-01-16 Martin Rudalics <rudalics@gmx.at>
4703 * window.c (Vwindow_persistent_parameters): New variable.
4704 (Fset_window_configuration, save_window_save): Handle persistent
4707 2012-01-14 Eli Zaretskii <eliz@gnu.org>
4709 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4710 thrashing the stack of the thread. (Bug#9087)
4712 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4714 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4716 2012-01-11 Eli Zaretskii <eliz@gnu.org>
4718 * xdisp.c (rows_from_pos_range): Handle the case where the
4719 highlight ends on a newline. (Bug#10464)
4720 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4721 he end column for display of highlight that ends on a newline
4724 2012-01-11 Glenn Morris <rgm@gnu.org>
4726 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4727 from load-path also when installation-directory is nil. (Bug#10208)
4729 2012-01-10 Glenn Morris <rgm@gnu.org>
4731 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4733 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4734 Update template values to be closer to their typical values these days.
4736 2012-01-09 Eli Zaretskii <eliz@gnu.org>
4738 * xdisp.c (rows_from_pos_range): Accept additional argument
4739 DISP_STRING, and accept any glyph in a row whose object is that
4740 string as eligible for mouse highlight. Fixes mouse highlight of
4741 display strings from overlays. (Bug#10464)
4743 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
4745 emacs: fix an auto-save permissions race condition (Bug#10400)
4746 * fileio.c (auto_saving_dir_umask): New static var.
4747 (Fmake_directory_internal): Use it.
4748 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4749 creating the directory. The old code temporarily assigns
4750 too-generous permissions to the directory.
4751 (do_auto_save_eh): Clear it.
4752 (Fdo_auto_save): Catch all errors, not just file errors, so
4753 that the var is always cleared.
4755 2012-01-07 Eli Zaretskii <eliz@gnu.org>
4757 * search.c (scan_buffer): Pass character positions to
4758 know_region_cache, not byte positions. (Bug#6540)
4760 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
4762 * w32.c (sys_rename): Report EXDEV when rename of a directory
4763 fails because the target is on another logical disk. (Bug#10284)
4765 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4767 * xterm.c (x_embed_request_focus): New function.
4769 * xterm.h: Add prototype.
4771 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4773 2012-01-05 Glenn Morris <rgm@gnu.org>
4775 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4777 2012-01-01 Eli Zaretskii <eliz@gnu.org>
4779 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4780 Load gnutls_transport_set_lowat only if GnuTLS version is below
4782 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4783 GnuTLS versions below 2.11.1.
4785 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4787 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4788 to the doc string advising against its use for altering the way
4789 windows are scrolled.
4791 2011-12-28 Kenichi Handa <handa@m17n.org>
4793 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4794 coding-system ASCII compatible only when it does not produce BOM
4795 on encoding (Bug#10383).
4797 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4799 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4801 (create_and_show_popup_menu): Always use menu_position_func for
4804 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4806 * callint.c (Fcall_interactively): Don't truncate prompt string.
4808 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4810 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4811 property that ends at ZV, so that the bidi iteration could be
4812 resumed from there (after widening). (Bug#10360)
4814 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4816 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4818 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4820 * nsterm.m (x_free_frame_resources):
4821 Release f->output_data.ns->miniimage.
4822 (ns_index_color): Fix indentation. Do not retain
4823 color_table->colors[i].
4825 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4828 * nsfns.m (x_set_background_color): Assign return value from
4829 ns_index_color to face-background instead of NSColor*.
4830 (ns_implicitly_set_icon_type): Fix indentation.
4831 Change assignment in for loop to comparison.
4833 * emacs.c (ns_pool): New variable.
4834 (main): Assign ns_pool.
4835 (Fkill_emacs): Call ns_release_autorelease_pool.
4837 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4838 autorelease fdesc, release fdAttrs and tdict.
4839 (ns_get_covering_families): Release charset.
4840 (ns_findfonts): Release NSFontDescriptor created with new.
4841 (ns_uni_to_glyphs): Fix indentation.
4842 (setString): Release attrStr before assigning new value.
4844 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4846 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4848 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4849 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4851 2011-12-18 David Reitter <reitter@cmu.edu>
4853 * nsterm.m (ns_term_init): Subscribe for notifications
4854 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4855 to method trackingNotification in EmacsMenu.
4857 * nsmenu.m (trackingMenu): New variable.
4858 (trackingNotification): New method (from Aquamacs).
4859 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4860 from Aquamacs (Bug#7030).
4862 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4864 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4865 (symbol_to_nsstring): Fix indentation.
4866 (ns_symbol_to_pb): New function.
4867 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4868 (Fns_rotate_cut_buffers_internal): Remove.
4869 (Fns_store_selection_internal): Rename from
4870 Fns_store_cut_buffer_internal.
4871 (ns_get_foreign_selection, Fx_own_selection_internal)
4872 (Fx_disown_selection_internal, Fx_selection_exists_p)
4873 (Fns_get_selection_internal, Fns_store_selection_internal):
4874 Use ns_symbol_to_pb and check if return value is nil.
4875 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4876 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
4877 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4878 renamed to Sns_store_selection_internal.
4879 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4880 and remove this function.
4881 (ns_handle_selection_clear): Remove, never used.
4882 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4885 2011-12-17 Ken Brown <kbrown@cornell.edu>
4887 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4888 GID is unknown (Bug#10257).
4890 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4892 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4893 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4894 which caused a build failure on GNU/Linux IA-64. This problem was
4895 introduced by my 2011-10-07 patch.
4897 2011-12-15 Juri Linkov <juri@jurta.org>
4899 * image.c (imagemagick_error): New function. (Bug#10112)
4900 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4901 Use `imagemagick_error' where ImageMagick functions return
4903 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4906 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4908 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4909 fill background (Bug#8992).
4911 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4913 * window.c (Vwindow_combination_resize)
4914 (Vwindow_combination_limit): Use t instead of non-nil in
4916 (Vrecenter_redisplay): Add first sentence of doc-string on
4918 (Frecenter): Fix doc-string typo.
4920 2011-12-11 Kenichi Handa <handa@m17n.org>
4922 * coding.c (Funencodable_char_position): Pay attention to the
4923 buffer text relocation (Bug#9389).
4925 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4927 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4928 gtk_init (Bug#10100).
4930 2011-12-10 Eli Zaretskii <eliz@gnu.org>
4932 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4933 IT->string is nil. (Bug#10263)
4935 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4937 * nsterm.h (x_free_frame_resources): Declare.
4939 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4940 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4942 * nsterm.h (ns_get_defaults_value): Declare.
4944 * nsterm.m (ns_default): Call ns_get_defaults_value.
4946 2011-12-09 Eli Zaretskii <eliz@gnu.org>
4948 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4951 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4953 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4954 that where the value of an _OBJC_* symbol points to is in the .bss
4955 section (Bug#10240).
4957 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4959 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
4960 after the loop to call ccl_driver at least once (Bug#8619).
4962 2011-12-08 Kenichi Handa <handa@m17n.org>
4964 * ftfont.c (get_adstyle_property): Fix previous change
4967 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
4969 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4970 dirs from the default value of EMACSLOADPATH (bug#10208).
4972 2011-12-07 Glenn Morris <rgm@gnu.org>
4974 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4975 installation and source directories as well. (Bug#10208)
4977 2011-12-06 Chong Yidong <cyd@gnu.org>
4979 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4981 2011-12-06 Glenn Morris <rgm@gnu.org>
4983 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4984 as an error, not just -1. (Bug#10217)
4986 2011-12-05 Chong Yidong <cyd@gnu.org>
4988 * keyboard.c (process_special_events): New function.
4989 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4991 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4993 * coding.c (encode_designation_at_bol): Don't use uninitialized
4994 local variable (Bug#9318).
4996 2011-12-05 Kenichi Handa <handa@m17n.org>
4998 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4999 return Qnil (Bug#8046, Bug#10193).
5001 2011-12-05 Kenichi Handa <handa@m17n.org>
5003 * coding.c (encode_designation_at_bol): New args charbuf_end and
5004 dst. Return the number of produced bytes. Callers changed.
5005 (coding_set_source): Return how many bytes coding->source was
5007 (coding_set_destination): Return how many bytes
5008 coding->destination was relocated.
5009 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
5010 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5012 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5014 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5015 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5018 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5020 The following changes are to fix Bug#9318.
5022 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5023 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5024 (encode_coding_iso_2022, encode_coding_sjis)
5025 (encode_coding_big5, encode_coding_charset): Use the above macros.
5027 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
5029 * lisp.h (process_quit_flag): Fix external declaration.
5031 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5033 Don't macro-inline non-performance-critical code.
5034 * eval.c (process_quit_flag): New function.
5035 * lisp.h (QUIT): Use it.
5037 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5039 * nsfns.m (get_geometry_from_preferences): New function.
5040 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5042 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5044 * emacs.c (Qkill_emacs): Define.
5045 (syms_of_emacs): Initialize it.
5046 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5047 Qquit_flag to `kill-emacs' instead.
5048 (quit_throw_to_read_char): Add parameter `from_signal'.
5049 All callers changed. Call Fkill_emacs if requested and safe.
5050 * lisp.h (QUIT): Call Fkill_emacs if requested.
5052 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5054 * widget.c (update_wm_hints): Return if wmshell is null.
5055 (widget_update_wm_size_hints): New function.
5057 * widget.h (widget_update_wm_size_hints): Declare.
5059 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5060 widget_update_wm_size_hints (Bug#10104).
5062 2011-12-03 Eli Zaretskii <eliz@gnu.org>
5064 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5065 before a newline, prepare the bidi iterator for consuming the
5066 newline, and keep the current paragraph direction. (Bug#10183)
5067 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
5069 2011-12-02 Juri Linkov <juri@jurta.org>
5071 * search.c (Fword_search_regexp): New Lisp function created from
5072 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5073 (Fword_search_backward, Fword_search_forward)
5074 (Fword_search_backward_lax, Fword_search_forward_lax):
5075 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5076 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5078 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5080 * fileio.c (Finsert_file_contents): Move after-change-function call
5081 to before the "handled:" label, since all "goto handled" appear in
5082 cases where the *-change-functions have already been properly called
5085 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5087 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5088 waiting for input. (Bug#10169)
5090 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5092 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5093 verifies glyph row's hash code--we have just reallocated the
5094 glyphs, so their contents can be complete garbage. (Bug#10164)
5096 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
5098 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5100 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5102 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5103 attributes are tested _before_ calling verify_row_hash, to protect
5104 against GCC re-ordering of the tests. (Bug#10164)
5106 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5108 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5110 * xterm.c (handle_one_xevent): Only set async_visible and friends
5111 if net_wm_state_hidden_seen is non-zero (Bug#10002)
5112 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
5113 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5115 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5117 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5118 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5119 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5120 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5121 All uses changed to use GCPRO1 etc.
5122 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5123 Revert to old implementation (i.e., before 2011-03-11).
5125 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5127 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5128 of scroll runs so as to avoid assigning disabled bogus rows and
5129 unnecessary graphics copy operations.
5131 2011-11-27 Eli Zaretskii <eliz@gnu.org>
5133 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5134 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5135 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5136 (malloc, free, realloc, calloc): Redirect to e_* only when
5139 * lisp.h (GCTYPEBITS): Move before first use.
5140 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5141 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5142 this macro definition.
5144 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5147 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5149 * gtkutil.c (xg_create_frame_widgets):
5150 Call gtk_window_set_has_resize_grip (FALSE) if that function is
5151 present with Gtk+ 2.0.
5153 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5155 * fileio.c (Finsert_file_contents): Undo previous change; see
5156 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5158 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5160 Rename locals to avoid shadowing.
5161 * fileio.c (Finsert_file_contents):
5162 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5163 * process.c (wait_reading_process_output):
5164 Rename inner 'proc' to 'p' to avoid shadowing.
5165 Indent for consistency with usual Emacs style.
5167 2011-11-25 Eli Zaretskii <eliz@gnu.org>
5169 * xdisp.c (redisplay_window): If cursor row is not fully visible
5170 after recentering, and scroll-conservatively is set to a large
5171 number, scroll window by a few more lines to make the cursor fully
5172 visible and out of scroll-margin. (Bug#10105)
5173 (start_display): Don't move to the next line if the display should
5174 start at a newline that is part of a display vector or an overlay
5177 2011-11-24 Juri Linkov <juri@jurta.org>
5179 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5180 after the `MagickPingImage' call. (Bug#10112)
5182 2011-11-23 Chong Yidong <cyd@gnu.org>
5184 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5186 2011-11-23 Martin Rudalics <rudalics@gmx.at>
5188 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5189 making another buffer current. (Bug#10114)
5191 2011-11-23 Glenn Morris <rgm@gnu.org>
5193 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5195 2011-11-23 Chong Yidong <cyd@gnu.org>
5197 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5198 using it (Bug#5984).
5200 2011-11-22 Eli Zaretskii <eliz@gnu.org>
5202 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5203 and header-lines, as they don't have one computed for them.
5206 * .gdbinit (prow): Make displayed values more self-explaining.
5207 Add row's hash code.
5209 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5211 * process.c (wait_reading_process_output): Fix asynchrounous
5212 GnuTLS socket handling on some versions of the GnuTLS library.
5213 (wait_reading_process_output): Add comment and URL.
5215 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5217 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5219 2011-11-21 Chong Yidong <cyd@gnu.org>
5221 * window.c (Fnext_window, Fprevious_window): Doc fix.
5223 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5225 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5227 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5229 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5231 2011-11-20 Martin Rudalics <rudalics@gmx.at>
5233 * window.c (Fset_window_combination_limit): Rename argument
5235 (Vwindow_combination_limit): Remove "status" from doc-string.
5237 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5239 * m/ibms390.h: Remove.
5240 * m/ibms390x.h: Don't include "ibms390.h".
5242 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5244 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5245 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5247 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5249 * casetab.c (Fset_case_table):
5250 * charset.c (Fcharset_after): Fix typos.
5252 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
5254 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5255 Otherwise, valgrind does not work on some platforms.
5256 Problem reported by Andreas Schwab in
5257 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5258 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5259 is set, removing the need for VIRT_ADDRESS_VARIES.
5260 (PURE_P): Use a more-efficient implementation that needs just one
5261 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5262 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5263 to 4 (xorl, subq, cmpq, setbe).
5264 * alloc.c (pure): Always extern now, since that's the
5265 VIRT_ADDR_VARIES behavior.
5266 (PURE_POINTER_P): Use a single comparison, not two, for
5267 consistency with the new puresize.h.
5268 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5269 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5270 Remove VIRT_ADDR_VARIES no longer needed.
5272 2011-11-19 Eli Zaretskii <eliz@gnu.org>
5274 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5275 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5276 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5277 behave as if the cursor position were at the window margin.
5279 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5280 and the cursor position is out of bounds, behave as if the cursor
5281 position were at the window margin. (Bug#10075)
5283 2011-11-18 Chong Yidong <cyd@gnu.org>
5285 * window.c (Fwindow_combination_limit): Make first argument
5286 non-optional, since it is meaningless for live windows like the
5289 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5291 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5293 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5295 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5296 (graft_intervals_into_buffer): Simplify.
5298 2011-11-18 Eli Zaretskii <eliz@gnu.org>
5300 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5301 hash values of the two rows.
5302 (copy_row_except_pointers): Preserve the used[] arrays and the
5303 hash values of the two rows. (Bug#10035)
5304 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
5306 * xdisp.c (row_hash): New function, body extracted from
5307 compute_line_metrics.
5308 (compute_line_metrics): Call row_hash, instead of computing the
5311 * dispnew.c (verify_row_hash): Call row_hash for computing the
5312 hash code of a row, instead of duplicating code from xdisp.c.
5314 * dispextern.h (row_hash): Add prototype.
5316 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5318 * frame.c (delete_frame): Don't delete the terminal when the last
5319 X frame is closed if emacs is built with GTK toolkit.
5321 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
5323 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5325 2011-11-17 Martin Rudalics <rudalics@gmx.at>
5327 * window.c (Vwindow_splits): Rename to
5328 Vwindow_combination_resize. Suggested by Juri Linkov.
5329 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5332 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
5334 * nsfns.m (Fns_font_name):
5335 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
5337 2011-11-16 Martin Rudalics <rudalics@gmx.at>
5339 * window.h (window): Rename slot "nest" to "combination_limit".
5340 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5341 (Fset_window_nest): Rename to Fset_window_combination_limit.
5342 (Vwindow_nest): Rename to Vwindow_combination_limit.
5343 (recombine_windows, make_parent_window, make_window)
5344 (Fsplit_window_internal, saved_window)
5345 (Fset_window_configuration, save_window_save): Rename all
5346 occurrences of window_nest to window_combination_limit.
5348 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
5350 * image.c (imagemagick_load_image): Fix typo.
5352 2011-11-14 Eli Zaretskii <eliz@gnu.org>
5354 * xdisp.c (display_line): Move the call to
5355 highlight_trailing_whitespace before the call to
5356 compute_line_metrics, since the latter needs to see the final
5357 faces of all the glyphs to compute ROW's hash value.
5358 Fixes assertion violations in row_equal_p. (Bug#10035)
5360 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
5362 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5363 just return (bug#10044).
5365 2011-11-12 Eli Zaretskii <eliz@gnu.org>
5367 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5368 with user-defined heap size. Bump the default size of the temacs
5369 heap to 27MB, to avoid memory warning when running temacs.
5370 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5372 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5373 current_matrix and desired_matrix. (Bug#9990)
5374 (verify_row_hash) [XASSERTS]: New function.
5375 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5376 that the hash value of glyph rows is correct.
5378 2011-11-12 Martin Rudalics <rudalics@gmx.at>
5380 * window.h (window): Remove splits slot.
5381 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5382 (Fdelete_other_windows_internal, make_parent_window)
5383 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5384 (Fset_window_configuration, save_window_save): Don't deal with
5385 split status of windows.
5386 (saved_window): Remove splits slot.
5387 (Vwindow_splits): Rewrite doc-string.
5389 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5391 * xfns.c (unwind_create_frame):
5392 * nsfns.m (unwind_create_frame):
5393 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5394 Vframe_list (Bug#9999).
5396 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5398 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
5400 2011-11-11 Kenichi Handa <handa@m17n.org>
5402 * callproc.c (Fcall_process): Set the member dst_multibyte of
5405 2011-11-11 Johan Bockgård <bojohan@gnu.org>
5407 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5408 avoid a crash (bug#9496).
5410 2011-11-09 Chong Yidong <cyd@gnu.org>
5412 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5413 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5415 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5417 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5419 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5421 Avoid some portability problems by eschewing 'extern inline' functions.
5422 The trivial performance wins aren't worth the portability hassles; see
5423 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5425 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5426 (window_box_width, window_box_left, window_box_left_offset)
5427 (window_box_right, window_box_right_offset): Undo previous change,
5428 by removing the "extern"s.
5429 * intervals.c (adjust_intervals_for_insertion)
5430 (adjust_intervals_for_deletion): Undo previous change,
5431 making these static again.
5432 (offset_intervals, temp_set_point_both, temp_set_point)
5433 (copy_intervals_to_string): No longer inline.
5434 * xdisp.c (window_text_bottom_y, window_box_width)
5435 (window_box_height, window_box_left_offset)
5436 (window_box_right_offset, window_box_left, window_box_right)
5437 (window_box): No longer inline.
5439 2011-11-08 Chong Yidong <cyd@gnu.org>
5441 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
5442 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5443 Signal an error if not a live window.
5444 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5445 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5447 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
5449 * lisp.h (syms_of_abbrev): Remove declaration.
5450 Reported by CHENG Gao <chenggao@royau.me>.
5452 2011-11-07 Eli Zaretskii <eliz@gnu.org>
5454 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5455 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5456 of temacs in GUI mode.
5458 2011-11-07 Martin Rudalics <rudalics@gmx.at>
5460 * window.h: Declare delete_all_child_windows instead of
5461 delete_all_subwindows.
5462 * window.c (Fwindow_nest, Fset_window_nest)
5463 (Fset_window_new_total, Fset_window_new_normal)
5464 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5465 (delete_all_subwindows): Rename to delete_all_child_windows.
5466 (Fdelete_other_windows_internal, Fset_window_configuration):
5467 Call delete_all_child_windows instead of delete_all_subwindows.
5468 * frame.c (delete_frame): Call delete_all_child_windows instead
5469 of delete_all_subwindows.
5471 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5473 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5474 This is also needed for porting to any host where GC_MARK_STACK is
5475 not GC_MAKE_GCPROS_NOOPS.
5476 (which_symbols): Use it.
5478 2011-11-07 Kenichi Handa <handa@m17n.org>
5480 * coding.c (coding_set_destination): Check coding->src_pos only
5481 when coding->src_object is a buffer (bug#9910).
5483 * process.c (send_process): Set the member src_multibyte of coding
5484 to 0 (bug#9911) when sending a unibyte text.
5486 * callproc.c (Fcall_process): Set the member src_multibyte of
5487 process_coding to 0 (bug#9912).
5489 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5491 * xmenu.c (cleanup_widget_value_tree): New function.
5492 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5493 calling free_menubar_widget_value_tree directly (Bug#9830).
5495 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5497 Fix some portability problems with 'inline'.
5498 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5499 (window_box_width, window_box_left, window_box_left_offset)
5500 (window_box_right, window_box_right_offset): Declare extern.
5501 Otherwise, these inline functions do not conform to C99 and
5502 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5503 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5504 * intervals.c (adjust_intervals_for_insertion)
5505 (adjust_intervals_for_deletion): Now extern, because otherwise the
5506 extern inline functions 'offset_intervals' couldn't refer to it.
5507 (static_offset_intervals): Remove.
5508 (offset_intervals): Rewrite using the old contents of
5509 static_offset_intervals. The old version didn't conform to C99
5510 because an extern inline function contained a reference to an
5511 identifier with static linkage.
5513 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5515 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5518 2011-11-06 Eli Zaretskii <eliz@gnu.org>
5520 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5521 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5522 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5523 return Qleft_to_right.
5525 2011-11-06 Chong Yidong <cyd@gnu.org>
5527 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5528 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5529 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5530 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5531 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5532 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5533 (Fwindow_vscroll): Doc fix.
5534 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5535 argument, since it makes no sense to pass a live window and for
5536 consistency with window-child.
5538 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5540 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5543 2011-11-05 Jason Rumney <jasonr@gnu.org>
5545 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5546 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5548 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5549 bitwise arithmetic preventing use of unicode-sip and non-truetype
5552 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5554 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5557 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5558 initialization code to keep similarity to xfns.c after changes
5561 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5563 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5564 (unwind_create_frame): New function (Bug#9943).
5565 (Fx_create_frame): Restructure code to be more similar to the one in
5566 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5567 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5568 Move terminal->reference_count++ just before making the frame official
5571 * nsterm.m (x_free_frame_resources): New function.
5572 (x_destroy_window): Move code to x_free_frame_resources.
5574 * xfns.c (unwind_create_frame): Fix comment.
5575 (Fx_create_frame, x_create_tip_frame):
5576 Move terminal->reference_count++ just before making the frame
5577 official. Move initialization of image_cache_refcount and
5578 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5580 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5582 Support MSVC build with newer versions of Visual Studio.
5583 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5584 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5587 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5588 which are not supported by MSVC.
5589 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5590 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5592 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5594 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5596 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5598 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
5600 Support MSVC build with newer versions of Visual Studio.
5601 * w32.c: Don't include w32api.h for MSVC.
5602 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5604 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5605 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5606 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5607 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5609 (alloca) [_MSC_VER]: Define to _alloca.
5611 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5613 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5615 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5617 * xdisp.c (note_mouse_highlight): If either of
5618 previous/next-single-property-change returns nil, treat that as
5619 the beginning or the end of the buffer. (Bug#9955)
5621 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5623 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
5624 label is not null (Bug#9951).
5625 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5628 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5630 * window.c (Fwindow_body_size): Mention in the doc string that the
5631 return value is in frame's canonical units. (Bug#9949)
5633 2011-11-03 Eli Zaretskii <eliz@gnu.org>
5635 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5637 * w32fns.c (unwind_create_frame): If needed, free the glyph
5638 matrices of the partially constructed frame. (Bug#9943)
5639 * xfns.c (unwind_create_frame): Likewise.
5641 2011-11-01 Eli Zaretskii <eliz@gnu.org>
5643 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5644 Don't stop backward scan on the continuation glyph, even though
5645 its CHARPOS is positive.
5646 (mouse_face_from_buffer_pos, note_mouse_highlight):
5647 Rename cover_string to disp_string.
5649 2011-11-01 Martin Rudalics <rudalics@gmx.at>
5651 * window.c (temp_output_buffer_show): Don't use
5652 Vtemp_buffer_show_specifiers.
5653 (Vtemp_buffer_show_specifiers): Remove unused variable.
5655 2011-10-30 Eli Zaretskii <eliz@gnu.org>
5657 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5658 past the beginning of the current glyph matrix.
5660 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
5662 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5663 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5664 HAVE_GTK3 (Bug#9869).
5666 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5667 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5669 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5671 * xterm.c: Declare x_handle_net_wm_state to return int.
5672 (handle_one_xevent): Check if we are iconified but don't have
5673 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5674 (get_current_wm_state): Return non-zero if not hidden,
5675 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5676 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5677 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5678 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5680 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5682 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5683 so that this new function doesn't get optimized away by a
5684 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5686 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5688 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5690 2011-10-29 Eli Zaretskii <eliz@gnu.org>
5692 Fix the `xbytecode' command.
5693 * .gdbinit (xprintbytestr): New command.
5694 (xwhichsymbols): Rename from `which'; all callers changed.
5695 (xbytecode): Print the byte-code string as well.
5697 2011-10-29 Kim Storm <storm@cua.dk>
5699 * alloc.c (which_symbols): New function.
5701 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5703 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5706 2011-10-29 Glenn Morris <rgm@gnu.org>
5708 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5709 Not clear what it was for, and it causes various bugs. (Bug#9839)
5711 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5713 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5714 possible random value that matches one of those tested as
5715 condition to clear the mouse face.
5717 2011-10-28 Chong Yidong <cyd@gnu.org>
5719 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5721 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5723 * window.c (make_window): Initialize phys_cursor_on_p.
5725 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5727 * lisp.h (struct Lisp_Symbol): Update comments.
5729 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
5731 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5733 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5735 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5736 <oslsachem@gmail.com> for helping to debug this.
5738 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5739 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5740 (g_b_init_get_glyph_outline_w): New static variables.
5741 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5742 (GetGlyphOutlineW_Proc): New typedefs.
5743 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
5744 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5746 (w32font_open_internal, compute_metrics):
5747 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
5748 instead of calling the "wide" APIs directly.
5750 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5752 * w32.h (syms_of_w32font): Add prototype.
5754 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5756 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5757 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5758 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5759 (Fmove_to_window_line): Doc fix.
5761 2011-10-27 Chong Yidong <cyd@gnu.org>
5763 * process.c (make_process): Set gnutls_state to NULL.
5765 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5766 non-NULL, regardless of GNUTLS_INITSTAGE.
5767 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5768 an error. Set process slots as soon as we allocate them.
5770 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5772 2011-10-27 Chong Yidong <cyd@gnu.org>
5774 * gnutls.c (emacs_gnutls_deinit): New function.
5775 Deallocate credentials structures as well as calling gnutls_deinit.
5776 (Fgnutls_deinit, Fgnutls_boot): Use it.
5778 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5779 (deactivate_process): Call emacs_gnutls_deinit.
5781 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5783 * image.c (x_create_x_image_and_pixmap):
5784 * w32.c (sys_rename, w32_delayed_load):
5785 * w32font.c (fill_in_logfont):
5786 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5788 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
5790 * w32fns.c (w32_default_color_map): New function,
5791 extracted from Fw32_default_color_map.
5792 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5794 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5796 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5798 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5800 * keyboard.c (test_undefined): New function (bug#9751).
5801 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5803 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5805 * sysdep.c (init_sys_modes): Fix the check for the controlling
5806 terminal (Bug#6649).
5808 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5810 * dispextern.h (struct bidi_it): New member next_en_type.
5812 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5813 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5814 current character, check also for next_en_type being WEAK_EN.
5815 (bidi_resolve_weak): Don't enter the expensive loop if the current
5816 position is before next_en_pos. Record the bidi type of the first
5817 non-ET, non-BN character we find, in addition to its position.
5818 (bidi_level_of_next_char): Invalidate next_en_type when
5819 next_en_pos is over-stepped.
5821 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5823 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5824 * editfns.c: Rewrite current-time-zone so that it invokes
5825 the equivalent of (format-time-string "%Z") to get the time zone name.
5826 This fixes a bug when the time zone name contains characters that
5827 need converting from the system time locale to Emacs internal format.
5828 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5829 that patch fixed format-time-string to do the conversion, but
5830 I forgot to fix current-time-zone.
5831 (format_time_string): New function, containing most of
5832 what Fformat_time_string used to contain.
5833 (Fformat_time_string): Rewrite in terms of format_time_string.
5834 This doesn't change this function's behavior.
5835 (current-time-zone): Rewrite to use format_time_string.
5836 This fixes the bug reported by Michael Schierl in
5837 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5838 Jason Rumney's 2007-06-07 change worked around this bug, but
5840 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5842 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5844 * xdisp.c (start_display): If the character at POS is displayed
5845 via a display vector, reset IT->current.dpvec_index to zero.
5846 (try_window_reusing_current_matrix): If a line ends in a display
5847 vector or the next line starts in a display vector, continue
5848 redrawing the window even though the character position of
5849 start_row was reached.
5852 2011-10-18 Chong Yidong <cyd@gnu.org>
5854 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5855 with nobreak-char-display too.
5857 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5859 Fix part 3 of bug#9771.
5860 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5861 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5862 non-neutral characters if the current character is a paragraph
5863 separator (a.k.a. Newline). This avoids running the same
5864 expensive loop twice, once when we consume the preceding newline
5865 and the other time when the line actually needs to be displayed.
5866 Avoid the loop when we see neutrals on the base embedding level
5867 following a character whose directionality is the same as the
5868 paragraph's. This avoids running the expensive loop when a line
5869 ends in a long sequence of neutrals, like control characters.
5870 Add assertion against STRONG_AL type. Slightly rearrange code
5871 that determines the type of a neutral given the first non-neutral
5873 (bidi_level_of_next_char): Set next_en_pos to zero when
5874 invalidating its info.
5876 2011-10-17 Eli Zaretskii <eliz@gnu.org>
5878 * xdisp.c (push_display_prop): Determine whether to record string
5879 or buffer position by IT->string, not by IT->method. Allow
5880 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
5881 (move_it_vertically_backward): Don't look for character position
5882 immediately after the newline when in a continuation line.
5885 2011-10-15 Martin Rudalics <rudalics@gmx.at>
5887 * window.c (coordinates_in_window): Rewrite and delabelize
5888 vertical border check. (Bug#5357) (Bug#9618)
5890 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5892 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5893 errors in XSetWindowBorder (bug#9310).
5895 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5897 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5898 avoid crash when xmalloc overrun checking is enabled.
5900 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5902 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5903 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5904 cursor motion with <left> and <right> arrow keys.
5906 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5907 some callers set that themselves.
5909 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5911 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5912 display string and the previous row comes from the same string and
5913 is empty. (Bug#9739) (Bug#9738)
5915 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5917 * doc.c (get_doc_string): Encode file name (bug#9735).
5919 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5921 * bidi.c (bidi_level_of_next_char):
5922 * xdisp.c (get_visually_first_element): Remove old incorrect
5923 comments regarding the Unicode Line Separator character.
5925 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5927 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5929 * alloc.c (Fgc_status): Do not access beyond zombies array
5930 boundary if nzombies > MAX_ZOMBIES.
5931 * alloc.c (dump_zombies): Add missing format specifier.
5933 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5935 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5936 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5938 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5939 Some packages use them to denote characters with modifiers.
5941 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5943 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5944 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5945 matching a pp-number. Rename parameter var to var1.
5947 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5949 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5951 2011-10-08 Glenn Morris <rgm@gnu.org>
5953 * callint.c (Fcall_interactively): Give a more explicit error for the
5954 'c' case with a non-character input. (Bug#8479)
5956 2011-10-08 Eli Zaretskii <eliz@gnu.org>
5958 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5960 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5961 lines that are hscrolled on the left.
5963 * dispnew.c (buffer_posn_from_coords): Account for a possible
5964 presence of header-line. (Bug#4426)
5966 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5968 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5969 Don't advertise functionality which we discourage or doesn't work.
5971 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5973 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5974 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5975 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5976 this makes Emacs dump core during garbage collection on rare
5977 occasions. sizeof is obviously inferior to offsetof here, so
5978 stick with offsetof.
5979 (GC_POINTER_ALIGNMENT): New macro.
5980 (mark_memory): Omit 3rd (offset) arg; caller changed.
5981 Don't assume EMACS_INT alignment is the same as pointer alignment.
5983 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5985 * keyboard.c (read_key_sequence_remapped): New var.
5986 (read_key_sequence): Compute remapping in the right buffer.
5987 (command_loop_1): Use read_key_sequence's remapping directly.
5989 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5991 * dired.c (file_name_completion): Don't expand file name.
5992 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5993 before checking file name handler.
5995 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5996 they've been requested explicitly (bug#9591).
5998 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
6000 * keymap.c (Fsingle_key_description): Use make_specified_string
6001 instead of build_string to build string from push_key_description.
6004 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6006 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6007 This fixes a Y2038 bug on 64-bit hosts.
6008 * buffer.c (reset_buffer):
6009 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6010 (Fclear_buffer_auto_save_failure):
6011 Use 0, not -1, to represent an unset failure time, since time_t
6012 might not be signed.
6014 Remove dependency on glibc malloc internals.
6015 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6016 Move back here from lisp.h, but with their new implementations.
6017 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6018 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6019 * charset.c (charset_table_init): New static var.
6020 (syms_of_charset): Use it instead of xmalloc. This removes a
6021 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6022 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6023 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6024 Move back to alloc.c.
6025 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6026 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6028 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6030 * nsterm.m (windowDidResize): Call x_set_window_size only when
6031 ns_in_resize is true. Otherwise set pixelwidth/height and
6032 call change_frame_size (Bug#9628).
6034 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6036 Port --enable-checking=all to Fedora 14 x86-64.
6037 * charset.c (syms_of_charset): Also account for glibc malloc's
6038 internal overhead when calculating the initial malloc maximum.
6040 Port --enable-checking=all to Fedora 14 x86.
6041 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6043 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6044 (overrun_check_realloc, overrun_check_free):
6045 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6046 That way, xmalloc returns a properly-aligned pointer even if
6047 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6048 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6049 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6050 into account when calculating the initial malloc maximum.
6051 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6052 Move here from alloc.c, so that charset.c can use it too.
6053 Properly align; the old code wasn't right for common 32-bit hosts
6054 when configured with --enable-checking=all.
6055 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6056 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6058 2011-09-29 Eli Zaretskii <eliz@gnu.org>
6060 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
6063 2011-09-28 Eli Zaretskii <eliz@gnu.org>
6065 * xdisp.c (compute_display_string_end): If there's no display
6066 string at CHARPOS, return -1.
6068 * bidi.c (bidi_fetch_char): When compute_display_string_end
6069 returns a negative value, treat the character as a normal
6070 character not covered by a display string. (Bug#9624)
6072 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
6074 * lread.c (Fread_from_string): Fix typo in docstring.
6076 2011-09-27 Eli Zaretskii <eliz@gnu.org>
6078 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6079 newline, reseat the iterator instead of bidi-iterating there one
6080 character at a time. (Bug#9610)
6081 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6082 TO_CHARPOS if the bidi iterator is at base embedding level.
6084 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6086 * lread.c (readevalloop): Use correct code for NBSP.
6087 (read1): Likewise. (Bug#9608)
6089 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
6091 * dbusbind.c (Fdbus_register_signal): When service is not
6092 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6094 2011-09-25 Glenn Morris <rgm@gnu.org>
6096 * buffer.c (truncate-lines): Doc fix.
6098 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
6100 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6101 (Fset_window_next_buffers): Doc fix.
6103 2011-09-24 Glenn Morris <rgm@gnu.org>
6105 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6107 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6109 Fix minor problems found by static checking.
6110 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
6111 * indent.c (Fvertical_motion): Fix == vs = typo.
6113 2011-09-24 Eli Zaretskii <eliz@gnu.org>
6115 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6116 Default value is now t. Doc fix.
6118 * indent.c (Fvertical_motion): Compute and apply the overshoot
6119 logic when moving up, not only when moving down. Fix the
6120 confusing name and values of the it_overshoot_expected variable;
6121 logic changes accordingly. (Bug#9254) (Bug#9549)
6123 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6124 CHARPOS is covered by a display string which includes newlines.
6125 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6126 is covered by a display string with embedded newlines.
6128 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
6130 * dbusbind.c (Fdbus_register_signal): Add match rule to
6131 Vdbus_registered_objects_table. (Bug#9581)
6132 (Fdbus_register_method, Vdbus_registered_objects_table):
6135 2011-09-24 Jim Meyering <meyering@redhat.com>
6137 do not ignore write error for any output size
6138 The previous change was incomplete.
6139 While it makes emacs --batch detect the vast majority of stdout
6140 write failures, errors were still ignored whenever the output size is
6141 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6142 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6143 && echo FAIL: ignored write error
6144 FAIL: ignored write error
6145 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6146 && echo FAIL: ignored write error
6147 FAIL: ignored write error
6148 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6150 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6152 * emacs.c (Fkill_emacs): In noninteractive mode exit
6153 non-successfully if a write error occurred on stdout. (Bug#9574)
6155 2011-09-21 Eli Zaretskii <eliz@gnu.org>
6157 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6160 * dispextern.h (struct it): Update the comment documenting what
6163 2011-09-20 Eli Zaretskii <eliz@gnu.org>
6165 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6166 a display string, extend search for cursor position to end of row.
6167 (find_row_edges): If the row ends in a newline from a display
6168 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6169 Handle the case of a display string with multiple newlines.
6170 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6171 non-empty line. Fixes confusing cursor motion with arrow keys at
6172 the beginning of a line that starts with whitespace.
6174 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6176 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6179 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
6181 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6184 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6186 * xdisp.c (display_line): Record maximum and minimum buffer
6187 positions even if no glyphs were produced (e.g., by a zero-width
6188 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6189 buffer positions that will be removed from the glyph row because
6191 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6192 column is beyond frame width: don't subtract 1 "pixel" when
6193 computing width of the stretch.
6194 (reseat_at_next_visible_line_start): Undo the change made on
6195 2011-09-17 that saved paragraph information and restored it after
6196 the call to `reseat'. (Bug#9545)
6198 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6200 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6201 and turn window cursor on if cleared (Bug#9415).
6203 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
6205 * search.c (boyer_moore): Take unibyte characters from pattern
6206 literally. (Bug#9458)
6208 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6210 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6212 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6214 Fix minor problem found by static checking.
6215 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6216 initialized, to pacify gcc -Wuninitialized.
6218 * fileio.c: Report proper errno when syscall falls.
6219 (Finsert_file_contents): Save and restore errno,
6220 so that report_file_error outputs the correct diagnostic.
6221 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6223 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6225 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6227 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6229 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6230 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6232 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6234 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6235 about the current paragraph and restore it after the call to reseat.
6237 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6238 (bidi_find_paragraph_start): Search back for paragraph beginning
6239 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6240 (bidi_move_to_visually_next): Only trigger paragraph-related
6241 computations when the last character is a newline or at EOB, not
6242 just any NEUTRAL_B. (Bug#9470)
6244 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6245 truncated lines if point is covered by a display string. (Bug#9524)
6247 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6249 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6250 (cons_to_x_long): New function.
6251 (lisp_data_to_selection_data): Use it. Correct the test for
6252 short-versus-long data; it was negated. Break out of vector
6253 loop, for efficiency, when a long datum is discovered.
6255 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6257 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6259 2011-09-16 Eli Zaretskii <eliz@gnu.org>
6261 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6262 GCC PR/17406) by declaring this function with external scope.
6264 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6266 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6267 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6269 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6271 * editfns.c (Fformat): Correctly handle text properties on "%%".
6273 2011-09-15 Eli Zaretskii <eliz@gnu.org>
6275 * xterm.c (x_draw_composite_glyph_string_foreground):
6276 * w32term.c (x_draw_composite_glyph_string_foreground):
6277 * term.c (encode_terminal_code):
6278 * composite.c (composition_update_it, get_composition_id):
6279 * xdisp.c (get_next_display_element)
6280 (fill_composite_glyph_string): Add comments about special meaning
6281 of TAB characters in a composition.
6283 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6285 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
6286 This occurs when processing a multibyte format.
6287 Problem reported by Wolfgang Jenker.
6289 2011-09-15 Johan Bockgård <bojohan@gnu.org>
6291 * xdisp.c (try_cursor_movement): Only check for exact match if
6292 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6294 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6296 Remove unused external symbols.
6297 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6298 * xdisp.c (calc_pixel_width_or_height): Now static.
6299 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6300 * indent.c (check_display_width):
6301 * w32term.c: Fix comment to match code.
6302 * xterm.c, xterm.h (x_catching_errors): Remove.
6304 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6306 * xselect.c: Use signed conversions more consistently (Bug#9498).
6307 (selection_data_to_lisp_data): Assume incoming selection data are
6308 signed integers, not unsigned. This is to be consistent with
6309 outgoing selection data, which was modified to use signed integers
6310 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6311 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6312 expects long, not unsigned long.
6314 2011-09-14 Eli Zaretskii <eliz@gnu.org>
6316 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6317 computation of loop end. Reported by Johan Bockgård
6320 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
6322 * frame.c (Fother_visible_frames_p): Function deleted.
6324 2011-09-12 Eli Zaretskii <eliz@gnu.org>
6326 * indent.c (compute_motion): Process display vector front to back
6327 rather than the other way around. (Bug#2496)
6329 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6331 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6333 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
6335 * minibuf.c (Fread_from_minibuffer): Doc fix.
6337 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6339 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6340 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6342 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6344 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6345 value for non-existent files.
6347 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6349 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6350 set its "size" to -1. This will set the modtime_size field of
6351 the corresponding buffer to -1, which is what
6352 verify-visited-file-modtime expects for files that do not exist.
6355 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6357 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6359 * lisp.h: ... from here. push_key_description is no longer
6360 defined in keyboard.c, so its declaration should not be in
6361 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6362 logically belongs with push_key_description.
6364 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6366 * buffer.h: Include <sys/types.h> instead of <time.h>.
6367 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6368 Problem reported by Herbert J. Skuhra.
6370 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6372 * xml.c (parse_region): Make the parsing work for
6373 non-comment-starting XML files again (bug#9144).
6375 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6377 * image.c (gif_load): Fix calculation of bottom and right corner.
6380 2011-09-10 Eli Zaretskii <eliz@gnu.org>
6382 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6383 redisplay in small windows.
6385 2011-09-09 Eli Zaretskii <eliz@gnu.org>
6387 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6389 2011-09-08 Martin Rudalics <rudalics@gmx.at>
6391 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6392 Operate on live windows only.
6394 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
6396 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6398 2011-09-07 Eli Zaretskii <eliz@gnu.org>
6400 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6401 only under bidi iteration.
6403 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6405 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6407 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6409 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6410 Without this fix, the command to link temacs failed due to an
6411 undefined symbol __builtin_isnan. This is because
6412 /usr/include/iso/math_c99.h #defines isnan(x) to
6413 __builtin_isnan(x), but the bundled gcc, which identifies itself
6414 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6416 * floatfns.c (isnan): #undef, and then #define to a clone of
6418 (Fisnan): Always define, since it's always available now.
6419 (syms_of_floatfns): Always define isnan at the Lisp level.
6421 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6423 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6425 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6427 * fileio.c: Fix bugs with large file offsets (Bug#9428).
6428 The previous code assumed that file offsets (off_t values) fit in
6429 EMACS_INT variables, which is not true on typical 32-bit hosts.
6430 The code messed up by falsely reporting buffer overflow in cases
6431 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6432 when "big" contains more than 2**29 bytes, even though this
6433 inserts just one byte and does not overflow the buffer.
6434 (Finsert_file_contents): Store file offsets as off_t
6435 values, not as EMACS_INT values. Check for overflow when
6436 converting between EMACS_INT and off_t. When checking for
6437 buffer overflow or for overlap, take the offsets into account.
6438 Don't use EMACS_INT for small values where int suffices.
6439 When checking for overlap, fix a typo: ZV was used where
6440 ZV_BYTE was intended.
6441 (Fwrite_region): Don't assume off_t fits into 'long'.
6442 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6444 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
6446 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6448 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6450 sprintf-related integer and memory overflow issues (Bug#9412).
6452 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6453 (esprintf, exprintf, evxprintf): New functions.
6454 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6455 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
6456 (modify_event_symbol): Do not assume that the length of
6457 name_alist_or_stem is safe to alloca and fits in int.
6458 (Fexecute_extended_command): Likewise for function name and binding.
6459 (Frecursion_depth): Wrap around reliably on integer overflow.
6460 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6461 since some callers pass EMACS_INT values.
6462 (Fsingle_key_description): Don't crash if symbol name contains more
6463 than MAX_ALLOCA bytes.
6464 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6465 (get_minibuffer): Arg is now EMACS_INT, not int.
6466 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
6467 (esprintf, exprintf, evxprintf): New decls.
6468 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6470 * dbusbind.c (signature_cat): New function.
6471 (xd_signature, Fdbus_register_signal):
6472 Do not overrun buffer; instead, report string overflow.
6474 * dispnew.c (add_window_display_history): Don't overrun buffer.
6475 Truncate instead; this is OK since it's just a log.
6477 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6478 even if the time zone offset is outlandishly large.
6479 Don't mishandle offset == INT_MIN.
6481 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6482 when creating daemon; the previous buffer-overflow check was incorrect.
6484 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6485 which has the guts of the old verror function.
6487 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6488 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6490 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6491 (font_unparse_xlfd): Don't blindly alloca long strings.
6492 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
6493 fits in int, when using sprintf. Use single snprintf to count
6494 length of string rather than counting it via multiple sprintfs;
6495 that's simpler and more reliable.
6496 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6497 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6498 sprintf, in case result does not fit in int.
6500 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6501 (fontset_from_font): Print it.
6503 * frame.c (tty_frame_count): Now printmax_t, not int.
6504 (make_terminal_frame, set_term_frame_name): Print it.
6505 (x_report_frame_params): In X, window IDs are unsigned long,
6506 not signed long, so print them as unsigned.
6507 (validate_x_resource_name): Check for implausibly long names,
6508 and don't assume name length fits in 'int'.
6509 (x_get_resource_string): Don't blindly alloca invocation name;
6510 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6513 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6514 (xg_check_special_colors, xg_set_geometry):
6515 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6517 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6518 Use esprintf, not sprintf, in case result does not fit in int.
6520 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6521 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6522 it as a large positive number.
6523 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6524 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6526 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6527 in case result does not fit in int.
6529 * print.c (float_to_string): Detect width overflow more reliably.
6530 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6531 buffer overrun. Don't assume list length fits in 'int'. Treat
6532 print length of 0 as 0, not as infinity; to be consistent with other
6533 uses of print length in this function. Don't overflow print length
6534 index. Don't assume hash table size fits in 'long', or that
6535 vectorlike size fits in 'unsigned long'.
6537 * process.c (make_process): Use printmax_t, not int, to format
6538 process-name gensyms.
6540 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6542 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6543 to avoid potential buffer overrun.
6545 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6546 if X resource line is longer than 512 bytes.
6548 * xfns.c (x_window): Make sprintf buffer a bit bigger
6549 to avoid potential buffer overrun.
6551 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6553 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6555 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6557 Integer overflow fixes for scrolling, etc.
6558 Without these, Emacs silently mishandles large integers sometimes.
6559 For example, "C-u 4294967297 M-x recenter" was treated as if
6560 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6562 * xdisp.c (try_window_id): Check Emacs fixnum range before
6563 converting to 'int'.
6565 * window.c (window_scroll_line_based, Frecenter):
6566 Check that an Emacs fixnum is in range before assigning it to 'int'.
6567 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6568 values converted from Emacs fixnums.
6569 (Frecenter): Don't wrap around a line count if it is out of 'int'
6570 range; instead, treat it as an extreme value.
6571 (Fset_window_configuration, compare_window_configurations):
6572 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6574 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6575 that can exceed INT_MAX. Check that EMACS_INT value is in range
6576 before assigning it to the (possibly-narrower) index.
6577 (match_limit): Don't assume that a fixnum can fit in 'int'.
6579 * print.c (print_object): Use ptrdiff_t, not int, for index that can
6582 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
6583 (Fvertical_motion): Don't wrap around LINES values that don't fit
6584 in 'int'. Instead, treat them as extreme values. This is good
6585 enough for windows, which can't have more than INT_MAX lines anyway.
6587 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6589 * Require libxml/parser.h to avoid compilation warning.
6591 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6593 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6594 since this reportedly can destroy thread storage.
6596 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
6598 * syntax.c (find_defun_start): Update all cache variables if
6599 exiting early (Bug#9401).
6601 2011-08-30 Eli Zaretskii <eliz@gnu.org>
6603 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6605 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6606 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6607 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6609 * term.c (tty_append_glyph): New function.
6610 (produce_stretch_glyph): Static function and its prototype deleted.
6612 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6615 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6617 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6618 when checking :margin (Bug#9390).
6619 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
6620 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
6621 so that the name doesn't mislead. All uses changed.
6623 2011-08-28 Johan Bockgård <bojohan@gnu.org>
6625 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6628 2011-08-27 Eli Zaretskii <eliz@gnu.org>
6630 * xdisp.c (move_it_to): Don't bail out early when reaching
6631 position beyond to_charpos, if we are scanning backwards.
6632 (move_it_vertically_backward): When DY == 0, make sure we get to
6633 the first character in the line after the newline.
6635 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6637 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6638 (ccl_driver): Do not generate an out-of-range pointer.
6639 (Fccl_execute_on_string): Remove unnecessary check for
6640 integer overflow, noted by Stefan Monnier in
6641 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6642 Remove a FIXME that didn't need fixing.
6643 Simplify the newly-introduced buffer reallocation code.
6645 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
6647 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6649 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
6651 Integer and memory overflow issues (Bug#9196).
6653 * doc.c (get_doc_string): Rework so that
6654 get_doc_string_buffer_size is the actual buffer size, rather than
6655 being 1 less than the actual buffer size; this makes xpalloc more
6658 * image.c (x_allocate_bitmap_record, cache_image):
6659 * xselect.c (Fx_register_dnd_atom):
6660 Simplify previous changes by using xpalloc.
6662 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6663 since either will do and ptrdiff_t is convenient with xpalloc.
6665 * charset.c (charset_table_size)
6666 (struct charset_sort_data.priority): Now ptrdiff_t.
6667 (charset_compare): Don't overflow if priorities differ greatly.
6668 (Fsort_charsets): Don't assume list length fits in int.
6669 Check for size-calculation overflow when allocating sort data.
6670 (syms_of_charset): Allocate an initial charset table that is
6671 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6673 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6675 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6676 The actual value is always <= INT_MAX, and leaving it unsigned made
6677 overflow checking harder.
6679 * dispextern.h (struct glyph_matrix.rows_allocated)
6680 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6681 with xpalloc. The values are still always <= INT_MAX.
6683 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6685 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6686 (SAFE_NALLOCA): New macro.
6688 * region-cache.c (struct boundary.pos, find_cache_boundary)
6689 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6690 (set_cache_region, invalidate_region_cache)
6691 (revalidate_region_cache, know_region_cache, region_cache_forward)
6692 (region_cache_backward, pp_cache):
6693 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6694 so that ptrdiff_t * can be passed to xpalloc.
6695 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6696 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6697 (pp_cache): Don't assume cache_len fits in int.
6698 * region-cache.h: Adjust extern decls to match.
6700 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6701 EMACS_INT, since either will do, for xpalloc.
6703 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6704 (xnmalloc, xnrealloc, xpalloc): New functions.
6706 * bidi.c (bidi_shelve_header_size): New constant.
6707 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6708 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6710 * bidi.c (bidi_cache_shrink):
6711 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6713 Don't update size of array until after memory allocation succeeds,
6714 because xmalloc/xrealloc may not return.
6715 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6716 now that we have proper integer overflow checking.
6717 (record_overlay_string, overlay_strings): Catch overflows when
6718 calculating size of overlay_str_buf.
6720 * callproc.c (Fcall_process): Check for size overflow when
6721 calculating size of args2.
6722 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6723 Normally we prefer signed values, but sticking with ptrdiff_t would
6724 require adding more-complicated checks.
6726 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6727 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6728 Redo buffer-overflow calculations to avoid integer overflow.
6729 Add a FIXME comment where memory seems to be over-allocated.
6731 * character.c (Fstring): Check for size-calculation overflow.
6733 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6734 unnecessary integer overflow. Check for size overflow.
6735 (encode_coding_object): Don't update size until xmalloc succeeds.
6737 * composite.c (get_composition_id): Check for overflow in glyph
6738 length calculations.
6740 Integer and memory overflow fixes for display code.
6741 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6742 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6743 (scrolling_window): Check for overflow in size calculations.
6744 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6745 Don't assume glyph table len fits in int.
6746 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6747 (row_table_size): Now ptrdiff_t, not int.
6748 (scrolling_window): Avoid overflow in size calculations.
6749 Don't update size until allocation succeeds.
6750 * fns.c (concat): Check for overflow in size calculations.
6751 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6752 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6753 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6755 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6756 (get_doc_string): Check for size calculation overflow.
6757 Don't update size until allocation succeeds.
6758 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6759 EMACS_INT, where ptrdiff_t will do.
6760 (Fsubstitute_command_keys): Check for string overflow.
6762 * editfns.c (set_time_zone_rule): Don't assume environment length
6764 (message_length): Now ptrdiff_t, not int.
6765 (Fmessage_box): Don't update size until allocation succeeds.
6766 Don't assume message length fits in int.
6767 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6769 * emacs.c (main): Do not reallocate argv, since there is a null at
6770 the end that can be overwritten, and this way there's no need to
6771 worry about size-calculation overflow.
6772 (sort_args): Check for size-calculation overflow.
6774 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6776 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6778 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6779 (x_set_scroll_bar_width, x_figure_window_size):
6780 Check for integer overflow.
6781 (x_set_alpha): Do not assume XINT fits in int.
6783 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6784 This is for the members text_lines, text_cols, total_lines, total_cols,
6785 where the system imposes an 'int' limit.
6787 * fringe.c (Fdefine_fringe_bitmap):
6788 Don't update size until alloc works.
6790 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6791 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6793 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6794 Check for size-calculation overflow.
6795 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6796 do, as we prefer signed integers.
6797 (id_to_widget.max_size, id_to_widget.used)
6798 (xg_store_widget_in_map, xg_remove_widget_from_map)
6799 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6800 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6801 Use and return ptrdiff_t, not int.
6802 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6803 * gtkutil.h: Change prototypes to match the above.
6805 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6806 are duplicate now that they've been promoted to lisp.h.
6807 (x_allocate_bitmap_record, x_alloc_image_color)
6808 (make_image_cache, cache_image, xpm_load):
6809 Don't update size until alloc is done.
6810 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6812 Check for size calculation overflow.
6813 (ct_colors_allocated_max): New constant.
6814 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6817 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6818 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6819 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6820 Use ptrdiff_t, not int, to count maps.
6821 (read_char_minibuf_menu_prompt): Check for overflow in size
6822 calculations. Don't update size until allocation succeeds.
6823 Redo calculations to avoid overflow.
6824 * keyboard.h: Change prototypes to match the above.
6826 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6828 (current_minor_maps): Check for size calculation overflow.
6829 * keymap.h: Change prototypes to match the above.
6831 * lread.c (read1, init_obarray): Don't update size until alloc done.
6833 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6834 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6836 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6837 Now ptrdiff_t, not int.
6838 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6839 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6841 * process.c (Fnetwork_interface_list): Check for overflow
6842 in size calculation.
6844 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6846 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6847 overflow. Don't bother calling xmalloc when xrealloc will do.
6849 * search.c (Freplace_match): Check for size calculation overflow.
6850 (Fset_match_data): Don't assume list lengths fit in 'int'.
6852 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6853 for command line length. Do not attempt to address one before the
6854 beginning of an array, as that's not portable.
6856 * term.c (max_frame_lines): Remove; unused.
6857 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6859 (encode_terminal_code, calculate_costs): Check for size
6860 calculation overflow.
6861 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6862 table lengths and related sizes. Don't update size until alloc
6863 done. Redo calculations to avoid overflow.
6864 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6866 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6867 subtracting pointers.
6868 (gobble_line): Check for overflow more carefully. Don't update size
6871 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6872 Don't update size until alloc done.
6873 Redo size calculations to avoid overflow.
6874 Check for size calculation overflow.
6875 (main) [DEBUG]: Fix typo in invoking tparam1.
6877 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6878 Use ptrdiff_t, not int, for sizes.
6879 (store_mode_line_noprop_char): Don't update size until alloc done.
6881 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6882 Use ptrdiff_t, not int, for sizes.
6883 (Finternal_make_lisp_face, cache_face):
6884 Check for size calculation overflow.
6885 (cache_face): Treat size calculation overflows as if they were
6886 memory exhaustion (the usual treatment), rather than aborting.
6888 * xfns.c (x_encode_text, x_set_name_internal)
6889 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6890 sizes, since they can exceed INT_MAX in size. Check for size
6891 calculation overflow.
6893 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6894 (xg_select): Check for size calculation overflow.
6895 Don't update size until alloc done.
6897 * xrdb.c (get_environ_db): Don't assume path length fits in int,
6898 as sprintf is limited to int lengths.
6900 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6901 (X_LONG_MIN): New macros.
6902 Use them to make the following changes clearer.
6903 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6904 This change doesn't affect the value now, but it may help remind
6905 future maintainers not to raise the value too much later.
6906 (SELECTION_QUANTUM): Remove, replacing with ...
6907 (selection_quantum): ... new function, which avoids overflow.
6909 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6910 assumption that selection length fits in 'int'.
6911 (x_reply_selection_request, x_handle_selection_request)
6912 (x_get_window_property, receive_incremental_selection)
6913 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6914 (lisp_data_to_selection_data, clean_local_selection_data):
6915 Use ptrdiff_t, not int, to record length of selection.
6916 (x_reply_selection_request, x_get_window_property)
6917 (receive_incremental_selection, x_property_data_to_lisp):
6918 Redo calculations to avoid overflow.
6919 (x_reply_selection_request): When sending hint, ceiling it at
6920 X_LONG_MAX rather than relying on wraparound overflow to send
6922 (x_get_window_property, receive_incremental_selection)
6923 (lisp_data_to_selection_data, x_property_data_to_lisp):
6924 Check for size-calculation overflow.
6925 (x_get_window_property, receive_incremental_selection)
6926 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6927 Don't store size until memory allocation succeeds.
6928 (x_get_window_property): Plug memory leak on memory exhaustion.
6929 Don't double-block input; malloc is safe here. Don't assume 2**34
6930 - 4 fits in unsigned long. Add an xassert to check
6931 XGetWindowProperty overflow. Be more careful about overflow
6932 calculations, and distinguish size from memory overflow better.
6933 (receive_incremental_selection): When tracing, don't assume
6934 unsigned int is less than INT_MAX.
6935 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6936 harmful) conversions of unsigned short to int.
6937 (lisp_data_to_selection_data): Don't assume that integers
6938 in the range -65535 through -1 fit in an X unsigned short.
6939 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6940 result parameters unless successful. Rely on cons_to_unsigned
6941 to report problems with elements; the old code wasn't right anyway.
6942 (x_check_property_data): Check for int overflow; we cannot use
6943 a wider type due to X limits.
6944 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6946 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
6948 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6949 (x_term_init): Check for size calculation overflow.
6950 (x_color_cells): Don't store size until memory allocation succeeds.
6951 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
6952 Don't assume alloca size is less than MAX_ALLOCA.
6953 (x_term_init): Don't assume length fits in int (sprintf is limited
6956 Use ptrdiff_t for composition IDs.
6957 * character.c (lisp_string_width):
6958 * composite.c (composition_table_size, n_compositions)
6959 (get_composition_id, composition_gstring_from_id):
6960 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6961 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6962 * window.c (Frecenter):
6963 Use ptrdiff_t, not int, for composition IDs.
6964 * composite.c (get_composition_id): Check for integer overflow.
6965 * composite.h: Adjust prototypes to match the above changes.
6967 Use ptrdiff_t for hash table indexes.
6968 * category.c (hash_get_category_set):
6969 * ccl.c (ccl_driver):
6970 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6971 * coding.c (coding_system_charset_list, detect_coding_system):
6972 * coding.h (struct coding_system.id):
6973 * composite.c (get_composition_id, gstring_lookup_cache):
6974 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6975 * image.c (xpm_get_color_table_h):
6976 * lisp.h (hash_lookup, hash_put):
6977 * minibuf.c (Ftest_completion):
6978 Use ptrdiff_t for hash table indexes, not int (which is too
6979 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6980 32-bit --with-wide-int hosts).
6982 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6983 Add a FIXME comment about memory leaks.
6984 (syms_of_charset): Don't assume xmalloc returns.
6986 Don't assume that stated character widths fit in int.
6987 * character.c (Fchar_width, c_string_width, lisp_string_width):
6988 * character.h (CHAR_WIDTH):
6989 * indent.c (MULTIBYTE_BYTES_WIDTH):
6990 Use sanitize_char_width to avoid undefined and/or bad behavior
6991 with outlandish widths.
6992 * character.h (sanitize_tab_width): Rename from sanitize_width,
6993 now that we have two such functions. All uses changed.
6994 (sanitize_char_width): New inline function.
6996 Don't assume that tab-width fits in int.
6997 * character.h (sanitize_width): New inline function.
6998 (SANE_TAB_WIDTH): New macro.
6999 (ASCII_CHAR_WIDTH): Use it.
7000 * indent.c (sane_tab_width): Remove. All uses replaced by
7001 SANE_TAB_WIDTH (current_buffer).
7002 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7004 * fileio.c: Integer overflow issues with file modes.
7005 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7007 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7008 Remove unreachable code.
7009 (read_hex, load_charset_map_from_file): Check for integer overflow.
7011 * xterm.c: Don't go over XClientMessageEvent limit.
7012 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7013 (x_send_scroll_bar_event): Likewise. Check that the size does not
7014 exceed limits imposed by XClientMessageEvent, as well as the usual
7015 ptrdiff_t and size_t limits.
7017 * keyboard.c: Overflow, signedness and related fixes.
7018 (make_lispy_movement): Use same integer type in forward decl
7019 that is used in the definition.
7020 (read_key_sequence, keyremap_step):
7021 Change bufsize argument back to int, undoing my 2011-03-30 change.
7022 We prefer signed types, and int is wide enough here.
7023 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7024 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7025 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7026 length, not size_t. Use ptrdiff_t for index, not int.
7027 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7028 possibility of integer overflow.
7030 Overflow, signedness and related fixes for images.
7032 * dispextern.h (struct it.stack[0].u.image.image_id)
7033 (struct_it.image_id, struct image.id, struct image_cache.size)
7034 (struct image_cache.used, struct image_cache.ref_count):
7035 * gtkutil.c (update_frame_tool_bar):
7036 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7037 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7038 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7039 * nsmenu.m (update_frame_tool_bar):
7040 * xdisp.c (calc_pixel_width_or_height):
7041 * xfns.c (image_cache_refcount):
7042 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7043 on typical 64-bit hosts.
7045 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7046 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7047 Omit unnecessary casts to int.
7048 (parse_image_spec): Check that integers fall into 'int' range
7049 when the callers expect that.
7050 (image_ascent): Redo ascent calculation to avoid int overflow.
7051 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7052 (lookup_image): Remove unnecessary tests.
7053 (xbm_image_p): Locals are now of int, not EMACS_INT,
7054 since parse_image_check makes sure they fit into int.
7055 (png_load, gif_load, svg_load_image):
7056 Prefer int to unsigned where either will do.
7057 (tiff_handler): New function, combining the cores of the
7058 old tiff_error_handler and tiff_warning_handler.
7059 This function is rewritten to use vsnprintf and thereby avoid
7060 stack buffer overflows. It uses only the features of vsnprintf
7061 that are common to both POSIX and native Microsoft.
7062 (tiff_error_handler, tiff_warning_handler): Use it.
7063 (tiff_load, gif_load, imagemagick_load_image):
7064 Don't assume :index value fits in 'int'.
7065 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7066 (imagemagick_load_image): Check that crop parameters fit into
7067 the integer types that MagickCropImage accepts. Don't assume
7068 Vimagemagick_render_type has a nonnegative value. Don't assume
7069 size_t fits in 'long'.
7070 (gs_load): Use printmax_t to print the widest integers possible.
7071 Check for integer overflow when computing image height and width.
7073 2011-08-26 Eli Zaretskii <eliz@gnu.org>
7075 * xdisp.c (redisplay_window): Don't force window start if point
7076 will be invisible in the resulting window. (Bug#9324)
7078 2011-08-25 Eli Zaretskii <eliz@gnu.org>
7080 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7081 the display spec is of the form `(space ...)'.
7082 (handle_display_spec): Return the value returned by
7083 handle_single_display_spec, not just 1 or zero.
7084 (handle_single_display_spec): If the display spec is of the form
7085 `(space ...)', and specifies display in the text area, return 2
7087 (try_cursor_movement): Check for the need to scroll more
7088 accurately, and prefer exact match for point under bidi.
7089 Don't advance `row' beyond the last row of the window.
7091 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7092 into disp_prop; all users changed.
7094 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7095 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7096 for the text covered by the display property.
7098 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
7100 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7101 Change return value to nil.
7102 (Frecord_buffer): Delete unused function.
7104 2011-08-24 Eli Zaretskii <eliz@gnu.org>
7106 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7107 buffers, return left-to-right.
7108 (set_cursor_from_row): Consider candidate row a win if its glyph
7109 represents a newline and point is on that newline. Fixes cursor
7110 positioning on the newline at EOL of R2L text within L2R
7111 paragraph, and vice versa.
7112 (try_cursor_movement): Check continued rows, in addition to
7113 continuation rows. Fixes unwarranted scroll when point enters a
7114 continued line of R2L text within an L2R paragraph, or vice versa.
7115 (cursor_row_p): Consider the case of point being equal to
7116 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7117 from the end of a short line to the beginning of a continued line
7118 of R2L text within L2R paragraph.
7119 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7120 composed characters.
7122 * bidi.c (bidi_check_type): Use xassert.
7123 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7126 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7128 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7131 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
7133 * nsfont.m (ns_otf_to_script): Fix typo.
7135 2011-08-22 Kenichi Handa <handa@m17n.org>
7137 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7138 extra slot even if the purpose is char-code-property-table.
7140 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7142 * xdisp.c (redisplay_window): When computing centering_position,
7143 account for the height of the header line. (Bug#8874)
7145 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7146 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7147 candidate is selected by the mouse, and that candidate has a
7148 composed character under the mouse.
7150 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7151 coordinates reported by pos-visible-in-window-p for a composed
7152 character in column zero.
7154 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7156 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7158 2011-08-22 Eli Zaretskii <eliz@gnu.org>
7160 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7161 consider it a hit if to_charpos is anywhere in the range of the
7162 composed buffer positions.
7164 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
7166 * image.c (gif_load): Don't assume that each subimage has the same
7167 dimensions as the base image. Handle disposal method that is
7168 "undefined" by the gif spec (Bug#9335).
7170 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
7172 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
7173 (Fcondition_case): Document `debug' symbol in error handler.
7175 2011-08-19 Eli Zaretskii <eliz@gnu.org>
7177 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7178 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7179 from an Org mode buffer to a Speedbar frame.
7181 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7182 a composition, take its buffer position from IT->cmp_it.charpos.
7183 Fixes cursor positioning at the beginning of a line that begins
7184 with a composed character.
7186 2011-08-18 Eli Zaretskii <eliz@gnu.org>
7188 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7189 character bidirectional type, use STRONG_L instead. Fixes crashes
7190 in a buffer produced by `describe-categories'.
7192 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7193 members before the level stack, so they would be saved and
7194 restored when copying iterator state. Fixes incorrect reordering
7195 around TABs covered by display properties.
7197 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7199 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
7201 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
7203 * eval.c (internal_condition_case, internal_condition_case_1)
7204 (internal_condition_case_2, internal_condition_case_n):
7205 Remove unnecessary aborts (Bug#9081).
7207 2011-08-17 Eli Zaretskii <eliz@gnu.org>
7209 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7210 has no `load' handler, try opening the file locally. (Bug#9311)
7212 2011-08-16 Ken Brown <kbrown@cornell.edu>
7214 * gmalloc.c: Expand comment.
7216 2011-08-16 Eli Zaretskii <eliz@gnu.org>
7218 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7219 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7221 2011-08-16 Ken Brown <kbrown@cornell.edu>
7223 Fix memory allocation problems in Cygwin build (Bug#9273).
7225 * unexcw.c ( __malloc_initialized): Declare external variable.
7226 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7228 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7230 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7232 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7234 [CYGWIN] (special_realloc): New function.
7235 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7236 requests to realloc storage in the static heap.
7238 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7240 * bidi.c (bidi_initialize): Remove unused local.
7242 2011-08-15 Eli Zaretskii <eliz@gnu.org>
7245 * biditype.h: Remove file.
7246 * makefile.w32-in ($(BLD)/bidi.$(O)):
7247 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
7249 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7251 * chartab.c: Improve commentary for the uniprop_table API.
7253 * bidi.c (bidi_paragraph_init): Support zero value of
7254 bidi_ignore_explicit_marks_for_paragraph_level.
7255 (bidi_initialize): Use uniprop_table instead of including
7256 biditype.h and bidimirror.h.
7258 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7259 coordinates of the iterator when restoring from ppos_it.
7262 2011-08-14 Kenichi Handa <handa@m17n.org>
7264 * process.c (create_process): Call setup_process_coding_systems
7265 after the pid of the process is set to -1 (Bug#8162).
7267 2011-08-14 Eli Zaretskii <eliz@gnu.org>
7269 * xdisp.c (move_it_in_display_line_to): Don't invoke
7270 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7271 ppos_it. Fixes vertical cursor motion when line beginning is
7272 covered by an image. (Bug#9296)
7274 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7276 * nsterm.h (ns_run_ascript): Declare.
7277 (NSAPP_DATA2_RUNASSCRIPT): Define.
7279 * nsfns.m (as_script, as_result, as_status): New static variables.
7280 (ns_run_ascript): New function.
7281 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
7282 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7283 the event loop. Get status from as_status (Bug#7276).
7285 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7286 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7287 the event loop (Bug#7276).
7289 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7291 * gnutls.c (QCgnutls_bootprop_priority)
7292 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7293 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7294 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7295 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7296 (QCgnutls_bootprop_verify_hostname_error)
7297 (QCgnutls_bootprop_callbacks_verify): Rename from
7298 Qgnutls_bootprop_..., all uses changed.
7300 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7303 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7305 * xfaces.c (Qframe_set_background_mode): Now static.
7306 * dispextern.h (Qframe_set_background_mode): Remove decl.
7308 * process.c (Fnetwork_interface_info): Declare local only if needed.
7310 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7312 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7313 (Fnetwork_interface_list): Allocate in increments of bytes instead
7314 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7315 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7317 (struct ifflag_def): notrailers is smart on OSX.
7318 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7319 Get hardware address with getifaddrs if available.
7321 2011-08-12 Eli Zaretskii <eliz@gnu.org>
7323 * xdisp.c (iterate_out_of_display_property): xassert that
7324 IT->position is set to within IT->object's boundaries. Break from
7325 the loop as soon as EOB is reached; avoids infloops in redisplay
7326 when IT->position is set up wrongly due to some bug.
7327 Set IT->current to match the bidi iterator unconditionally.
7328 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7329 entry. Force push_it to save on the stack the current
7330 buffer/string position, to be restored by pop_it. Fix flags in
7331 the iterator structure wrt the object coming from a display
7332 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7333 properties. (Bug#9284)
7335 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
7337 * fontset.c (fontset_get_font_group): Add proper type checks.
7340 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7342 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7343 and LC_VERSION_MIN_MACOSX.
7344 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7345 (dump_it) [LC_FUNCTION_STARTS]: Use it.
7347 2011-08-08 Eli Zaretskii <eliz@gnu.org>
7349 * xdisp.c (forward_to_next_line_start): Allow to use the
7350 no-display-properties-and-no-overlays under bidi display.
7351 Set disp_pos in the bidi iterator to avoid searches for display
7352 properties and overlays.
7354 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
7356 * editfns.c (Fset_time_zone_rule): Document relationship with the
7359 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7360 the font entity extracted from the cache (Bug#8109).
7362 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
7364 * composite.c (autocmp_chars): Don't reset point. That is done by
7365 restore_point_unwind (Bug#5984).
7367 2011-08-07 Juri Linkov <juri@jurta.org>
7369 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7370 to show the arg `TIME' instead of `TIMEVAL'.
7372 2011-08-06 Eli Zaretskii <eliz@gnu.org>
7374 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7375 display property strides EOL and includes a newline, as in
7376 longlines-mode. (Bug#9254)
7377 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7378 word-wrap under bidirectional display. (Bug#9224)
7380 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7381 is non-zero, even if the data buffer is NULL. Fixes a crash in
7382 vertical-motion with longlines-mode. (Bug#9254)
7384 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7386 * bidi.c <bidi_cache_total_alloc>: Now static.
7387 (bidi_initialize): Initialize bidi_cache_total_alloc.
7389 * xdisp.c (display_line): Release buffer allocated for shelved bidi
7392 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7393 amount allocated this far in `bidi_cache_total_alloc'.
7394 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7395 non-zero, only free the data buffer without restoring the cache
7396 contents. All callers changed.
7398 * dispextern.h (bidi_unshelve_cache): Update prototype.
7400 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7401 (move_it_in_display_line, move_it_to)
7402 (move_it_vertically_backward, move_it_by_lines): Replace the call
7403 to xfree to an equivalent call to bidi_unshelve_cache.
7404 (move_it_in_display_line_to): Fix logic of returning
7405 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
7407 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7409 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7410 came from a string character with a `cursor' property. (Bug#9229)
7412 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7414 * Makefile.in (LIB_PTHREAD): New variable.
7415 (LIBES): Add LIB_PTHREAD (Bug#9216).
7417 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7418 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7420 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7422 * regex.c (re_iswctype): Remove some redundant boolean conversions.
7424 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7426 * xterm.c (x_find_topmost_parent): New function.
7427 (x_set_frame_alpha): Find topmost parent window with
7428 x_find_topmost_parent and set the property there also (bug#9181).
7429 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7431 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7433 * callproc.c (Fcall_process): Avoid vfork clobbering
7434 the local vars buffer, coding_systems, current_dir.
7436 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7438 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7440 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7442 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7443 so that it is not optimized away.
7445 * xdisp.c (compute_display_string_pos): Remove unused local.
7447 2011-08-02 Eli Zaretskii <eliz@gnu.org>
7449 Fix slow cursor motion and scrolling in large buffers with
7450 selective display, like Org Mode buffers. (Bug#9218)
7452 * dispextern.h (struct bidi_it): New member disp_prop_p.
7454 * xdisp.c: Remove one-slot cache of display string positions.
7455 (compute_display_string_pos): Accept an additional argument
7456 DISP_PROP_P; callers changed. Scan at most 5K characters forward
7457 for a display string or property. If found, set DISP_PROP_P
7460 * bidi.c (bidi_fetch_char): Accept an additional argument
7461 DISP_PROP_P, and pass it to compute_display_string_pos.
7462 Only handle text covered by a display string if DISP_PROP_P is returned
7463 non-zero. All callers of bidi_fetch_char changed.
7465 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7467 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7469 2010-12-03 Don March <don@ohspite.net>
7471 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7472 last character M-[char] is translated to ESC [char] (bug#7541).
7474 2011-08-02 Kenichi Handa <handa@m17n.org>
7476 * lisp.h (uniprop_table): Extern it.
7478 * chartab.c (uniprop_table): Make it non-static.
7480 2011-08-01 Eli Zaretskii <eliz@gnu.org>
7482 * xdisp.c (forward_to_next_line_start): Accept additional argument
7483 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7485 (reseat_at_next_visible_line_start): Use the bidi iterator state
7486 returned by forward_to_next_line_start to restore the state of
7487 it->bidi_it after backing up to previous newline. (Bug#9212)
7489 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7491 * regex.c (re_comp): Protoize.
7492 (re_exec): Fix return type.
7493 (regexec): Fix type of `ret'. (Bug#9203)
7495 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7497 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7498 This is needed if max-image-size is a floating-point number.
7500 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7502 * print.c (print_object): Print empty symbol as ##.
7504 * lread.c (read1): Read ## as empty symbol.
7506 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7508 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7509 setting frame foreground color (Bug#9175).
7510 (x_set_background_color): Likewise.
7512 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7513 contents (Bug#9176).
7514 (EmacsTooltip -init): Remove bezels and add shadows to
7517 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7518 or scroll bar (Bug#8470).
7520 * nsfont.m (nsfont_open): Remove assignment to voffset and
7521 unnecessary vars hshink, expand, hd, full_height, min_height.
7522 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7524 * nsterm.h (nsfont_info): Remove voffset field.
7526 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7528 Implement strike-through and overline on NextStep (Bug#8863).
7530 * nsfont.m (nsfont_open): Use underline position provided by font,
7531 instead of hard-coded value of 2.
7532 (nsfont_draw): Call ns_draw_text_decoration instead.
7534 * nsterm.h: Add declaration for ns_draw_text_decoration.
7536 * nsterm.m (ns_draw_text_decoration): New function for drawing
7537 underline, overline, and strike-through.
7538 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7539 ns_draw_text_decoration. Change treatment of cursor drawing to
7540 accommodate underlining, etc.
7542 2011-07-28 Eli Zaretskii <eliz@gnu.org>
7544 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7547 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7549 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7550 Without this fix, if a signal arrives just after memory fills up,
7551 'malloc' might be invoked reentrantly.
7553 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7554 In other words, assume that every image size is allowed, on non-X
7555 hosts. This assumption is probably wrong, but it lets Emacs compile.
7557 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7559 * regex.c (re_iswctype): Convert return values to boolean.
7561 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7563 * xdisp.c (compute_display_string_pos): Don't use cached display
7564 string position if the buffer had its restriction changed.
7567 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7569 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7571 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7573 Integer signedness and overflow and related fixes. (Bug#9079)
7575 * bidi.c: Integer size and overflow fixes.
7576 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7577 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7578 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7579 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7580 (bidi_find_other_level_edge):
7581 Use ptrdiff_t instead of EMACS_INT where either will do.
7582 This works better on 32-bit hosts configured --with-wide-int.
7583 (bidi_cache_ensure_space): Check for size-calculation overflow.
7584 Use % rather than repeated addition, for better worst-case speed.
7585 Don't set bidi_cache_size until after xrealloc returns, because it
7587 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
7588 (bidi_cache_ensure_space): Also check that the bidi cache size
7589 does not exceed that of the largest Lisp string or buffer. See Eli
7590 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
7592 * alloc.c (__malloc_size_t): Remove.
7593 All uses replaced by size_t. See Andreas Schwab's note
7594 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7596 * image.c: Improve checking for integer overflow.
7597 (check_image_size): Assume that f is nonnull, since
7598 it is always nonnull in practice. This is one less thing to
7599 worry about when checking for integer overflow later.
7600 (x_check_image_size): New function, which checks for integer
7601 overflow issues inside X.
7602 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7603 This removes the need for a memory_full check.
7604 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7605 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7606 (xbm_read_bitmap_data): Change locals back to 'int', since
7607 their values must fit in 'int'.
7608 (xpm_load_image, png_load, tiff_load):
7609 Invoke x_create_x_image_and_pixmap earlier,
7610 to avoid much needless work if the image is too large.
7611 (tiff_load): Treat overly large images as if
7612 x_create_x_image_and_pixmap failed, not as malloc failures.
7613 (gs_load): Use x_check_image_size.
7615 * gtkutil.c: Omit integer casts.
7616 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7617 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7619 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7621 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7622 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7623 would wrongly return t on a 64-bit host.
7625 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7626 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7627 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7628 and therefore cause GCC to emit a bogus diagnostic in some cases.
7630 * image.c: Integer signedness and overflow and related fixes.
7631 This is not an exhaustive set of fixes, but it's time to
7632 record what I've got.
7633 (lookup_pixel_color, check_image_size): Remove redundant decls.
7634 (check_image_size): Don't assume that arbitrary EMACS_INT values
7635 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7636 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7637 (tiff_load, imagemagick_load_image):
7638 Check for overflow in size calculations.
7639 (x_create_x_image_and_pixmap): Remove unnecessary test for
7640 xmalloc returning NULL; that can't happen.
7641 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7642 (xpm_color_bucket): Use better integer hashing function.
7643 (xpm_cache_color): Don't possibly over-allocate memory.
7644 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7645 (gif_memory_source):
7646 Use ptrdiff_t, not int or size_t, to record sizes.
7647 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7648 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7649 either works, as we prefer signed integers.
7650 (tiff_read_from_memory, tiff_write_from_memory):
7651 Return tsize_t, not size_t, since that's what the TIFF API wants.
7652 (tiff_read_from_memory): Don't fail simply because the read would
7653 go past EOF; instead, return a short read.
7654 (tiff_load): Omit no-longer-needed casts.
7655 (Fimagemagick_types): Don't assume size fits into 'int'.
7657 Improve hashing quality when configured --with-wide-int.
7658 * fns.c (hash_string): New function, taken from sxhash_string.
7659 Do not discard information about ASCII character case; this
7660 discarding is no longer needed.
7661 (sxhash-string): Use it. Change sig to match it. Caller changed.
7662 * lisp.h: Declare it.
7663 * lread.c (hash_string): Remove, since we now use fns.c's version.
7664 The fns.c version returns a wider integer if --with-wide-int is
7665 specified, so this should help the quality of the hashing a bit.
7667 * emacs.c: Integer overflow minor fix.
7668 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7669 Define only if GNU_LINUX.
7670 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7672 * dispnew.c: Integer signedness and overflow fixes.
7673 Remove unnecessary forward decls, that were a maintenance hassle.
7674 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7676 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7677 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7678 (prepare_desired_row, line_draw_cost):
7679 Use int, not unsigned, where either works.
7680 (save_current_matrix, restore_current_matrix):
7681 Use ptrdiff_t, not size_t, where either works.
7682 (init_display): Check for overflow more accurately, and without
7683 relying on undefined behavior.
7685 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7686 Remove, replacing with the new symbols in lisp.h. All uses changed.
7687 * fileio.c (make_temp_name):
7688 * filelock.c (lock_file_1, lock_file):
7689 * xdisp.c (message_dolog):
7690 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7691 Use pMd etc. instead.
7692 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7693 replacing the pWIDE etc. symbols removed from editfns.c.
7695 * keyboard.h (num_input_events): Now uintmax_t.
7696 This is (very slightly) less likely to mess up due to wraparound.
7699 * buffer.c: Integer signedness fixes.
7700 (alloc_buffer_text, enlarge_buffer_text):
7701 Use ptrdiff_t rather than size_t when either will do, as we prefer
7704 * alloc.c: Integer signedness and overflow fixes.
7705 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7706 (__malloc_size_t): Default to size_t, not to int.
7707 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7708 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7709 Prefer ptrdiff_t to size_t when either would do, as we prefer
7711 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7712 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7713 Now const. Initialize with values that are in range even if char
7715 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7716 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7717 These functions do the right thing with sizes > 2**32.
7718 (check_depth): Now ptrdiff_t, not int.
7719 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7720 Adjust to new way of storing sizes. Check for size overflow bugs
7722 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7723 slightly wrong anyway, as it missed one instance of
7724 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7725 (refill_memory_reserve): Omit needless cast to size_t.
7726 (mark_object_loop_halt): Mark as externally visible.
7728 * xselect.c: Integer signedness and overflow fixes.
7729 (Fx_register_dnd_atom, x_handle_dnd_message):
7730 Use ptrdiff_t, not size_t, since we prefer signed.
7731 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7732 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7733 x_dnd_atoms_size and x_dnd_atoms_length.
7735 * doprnt.c: Prefer signed to unsigned when either works.
7737 * doprnt.c (doprnt):
7739 * xdisp.c (vmessage):
7740 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7741 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7742 prefer signed arithmetic to avoid comparison confusion.
7743 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7744 but is a bit tricky.
7746 Assume freestanding C89 headers, string.h, stdlib.h.
7747 * data.c, doprnt.c, floatfns.c, print.c:
7748 Include float.h unconditionally.
7749 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7750 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7751 * regex.c: Likewise for stddef.h, string.h.
7752 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7753 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7754 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7755 (STDC_HEADERS): Remove obsolete defines.
7756 * sysdep.c: Include limits.h unconditionally.
7758 Assume support for memcmp, memcpy, memmove, memset.
7759 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7760 * regex.c (memcmp, memcpy):
7761 Remove; we assume C89 now.
7763 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7764 (__malloc_safe_bcopy): Remove; no longer needed.
7766 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
7767 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7768 well either way, and we prefer signed to unsigned.
7770 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7772 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7773 closes the connection while we're reading (bug#9182).
7775 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
7777 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7778 are specified (Bug#9168).
7780 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7782 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7783 Found by GCC static checking and --with-wide-int on a 32-bit host.
7785 2011-07-25 Eli Zaretskii <eliz@gnu.org>
7787 * xdisp.c (compute_display_string_pos): Fix logic of caching
7788 previous display string position. Initialize cached_prev_pos to
7789 -1. Fixes slow-down at the beginning of a buffer.
7791 2011-07-24 Eli Zaretskii <eliz@gnu.org>
7793 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7794 for attrs[LFACE_FONTSET_INDEX].
7796 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7798 * xml.c (parse_region): Remove unused local
7799 that was recently introduced.
7801 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7803 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7804 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7806 * xdisp.c (move_it_in_display_line_to): Record the best matching
7807 position for TO_CHARPOS while scanning the line, and restore it on
7808 exit if none of the characters scanned was an exact match.
7809 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7810 when exact match is impossible due to invisible text, and the
7811 lines are truncated.
7813 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7815 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7818 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7820 Fix a significant slow-down of cursor motion with C-n, C-p,
7821 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7822 auto-repeat under bidi redisplay in fontified buffers.
7823 * xdisp.c (compute_stop_pos_backwards): New function.
7824 (next_element_from_buffer): Call compute_stop_pos_backwards to
7825 find a suitable prev_stop when we find ourselves before
7827 (reseat): Don't look for prev_stop, as that could mean a very long
7829 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7830 <cached_disp_overlay_modiff>: Cache for last found display string
7832 (compute_display_string_pos): Return the cached position if asked
7833 about the same buffer in the same area of character positions, and
7834 the buffer wasn't changed since the time the display string
7835 position was cached.
7837 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7839 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7840 is an integer, which is important for empty lines. (Bug#9149)
7842 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7844 * frame.c (Fmodify_frame_parameters): In tty case, update the
7845 default face if necessary (Bug#4238).
7847 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7849 * editfns.c (Fstring_to_char): No need to explain what a character
7850 is in the docstring (Bug#6576).
7852 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7854 * xml.c (parse_region): Make sure we always return a tree.
7856 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7858 * xml.c (parse_region): If a document contains only comments,
7861 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7863 * xml.c (make_dom): Return comments, too.
7865 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7868 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7869 and the surrounding thread.
7870 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7871 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7872 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7874 * s/openbsd.h (BROKEN_SIGIO): Define.
7875 * unexelf.c (unexec) [__OpenBSD__]:
7876 Don't update the .mdebug section of the Alpha COFF symbol table.
7878 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7880 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7883 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7885 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7886 This fixes some race conditions on the permissions of any newly
7889 * alloc.c (valid_pointer_p): Use pipe, not open.
7890 This fixes some permissions issues when debugging.
7892 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7893 If fchown fails to set both uid and gid, try to set just gid,
7894 as that is sometimes allowed. Adjust the file's mode to eliminate
7895 setuid or setgid bits that are inappropriate if fchown fails.
7897 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7899 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7900 to compare Lisp_Objects.
7901 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7902 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7903 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7905 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7907 * lread.c (read_integer): Unread even EOF character.
7908 (read1): Likewise. Properly record start position of symbol.
7910 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7911 symbol character follows.
7913 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7915 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7916 This works around a problem with the previous change to Fcopy_file.
7917 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7918 and without this change, GCC might complain about discarding
7919 fchown's return value.
7921 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
7923 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7925 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7927 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7929 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7931 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7932 it's used from the C level.
7934 * process.c: Use the same condition for POLL_FOR_INPUT in both
7935 keyboard.c and process.c (bug#1858).
7937 2011-07-09 Lawrence Mitchell <wence@gmx.li>
7939 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7940 (Fgnutls_boot): Use it.
7942 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7944 * doc.c (Fsubstitute_command_keys): Revert last change.
7946 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7948 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7949 quotes the next character, and doesn't affect other longer
7950 sequences (bug#8935).
7952 * lread.c (syms_of_lread): Clarify that is isn't only
7953 `eval-buffer' and `eval-defun' that's affected by
7954 `lexical-binding' (bug#8460).
7956 2011-07-15 Eli Zaretskii <eliz@gnu.org>
7958 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
7959 bidi redisplay when a line includes both an image and is truncated.
7961 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7963 Fix minor problems found by static checking.
7964 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7965 (elsz): Now a signed constant, not a size_t var. We prefer signed
7966 types to unsigned, to avoid integer comparison confusion. Without
7967 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7968 "cannot optimize loop, the loop counter may overflow", a symptom
7970 * indent.c (Fvertical_motion): Mark locals as initialized.
7971 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7973 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7975 * search.c (Fre_search_backward): Mention `case-fold-search' in
7976 all the re_search_* functions (bug#8138).
7978 * keyboard.c (Fopen_dribble_file): Document when the file is
7981 2011-07-14 Eli Zaretskii <eliz@gnu.org>
7983 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7986 Support bidi reordering of display and overlay strings.
7987 * xdisp.c (compute_display_string_pos)
7988 (compute_display_string_end): Accept additional argument STRING.
7989 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7990 (reseat_to_string): Initialize bidi_it->string.s and
7991 bidi_it->string.schars.
7992 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
7993 NULL (avoids a crash in bidi_paragraph_init).
7994 Initialize itb.string.lstring.
7995 (init_iterator): Call bidi_init_it only of a valid
7996 buffer position was specified. Initialize paragraph_embedding to
7998 (reseat_to_string): Initialize the bidi iterator.
7999 (display_string): If we need to ignore text properties of
8000 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8001 original value of -1 will not work with bidi.)
8002 (compute_display_string_pos): First arg is now struct
8003 `text_pos *'; all callers changed. Support display properties on
8005 (compute_display_string_end): Support display properties on Lisp
8007 (init_iterator, reseat_1, reseat_to_string): Initialize the
8008 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8009 when iterating on a string not from display properties).
8010 (compute_display_string_pos, compute_display_string_end):
8011 Fix calculation of the object to scan. Fixes an error when using
8013 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
8014 base_level_stop; instead, set base_level_stop to BEGV.
8015 Fixes crashes in vertical-motion.
8016 (next_element_from_buffer): Improve commentary for when
8017 the iterator is before prev_stop.
8018 (init_iterator): Initialize bidi_p from the default value of
8019 bidi-display-reordering, not from buffer-local value. Use the
8020 buffer-local value only if initializing for buffer iteration.
8021 (handle_invisible_prop): Support invisible properties on strings
8022 that are being bidi-reordered.
8023 (set_iterator_to_next): Support bidi reordering of C strings and
8025 (next_element_from_string): Support bidi reordering of Lisp
8027 (handle_stop_backwards): Support Lisp strings as well.
8028 (display_string): Support display of R2L glyph rows.
8029 Use IT_STRING_CHARPOS when displaying from a Lisp string.
8030 (init_iterator): Don't initialize it->bidi_p for strings
8032 (reseat_to_string): Initialize it->bidi_p for strings here.
8033 (next_element_from_string, next_element_from_c_string)
8034 (next_element_from_buffer): Add xassert's for correspondence
8035 between IT's object being iterated and it->bidi_it.string
8037 (face_before_or_after_it_pos): Support bidi iteration.
8038 (next_element_from_c_string): Handle the case of the first string
8039 character that is not the first one in the visual order.
8040 (get_visually_first_element): New function, refactored from common
8041 parts of next_element_from_buffer, next_element_from_string, and
8042 next_element_from_c_string.
8043 (tool_bar_lines_needed, redisplay_tool_bar)
8044 (display_menu_bar): Force left-to-right direction. Add a FIXME
8045 comment for making that be controlled by a user option.
8046 (push_it, pop_it): Save and restore the state of the
8047 bidi iterator. Save and restore the bidi_p flag.
8048 (pop_it): Iterate out of display property for string iteration as
8050 (iterate_out_of_display_property): Support iteration over strings.
8051 (handle_single_display_spec): Set up it->bidi_it for iteration
8052 over a display string, and call bidi_init_it.
8053 (handle_single_display_spec, next_overlay_string)
8054 (get_overlay_strings_1, push_display_prop): Set up the bidi
8055 iterator for displaying display or overlay strings.
8056 (forward_to_next_line_start): Don't use the shortcut if
8058 (back_to_previous_visible_line_start): If handle_display_prop
8059 pushed the iterator stack, restore the internal state of the bidi
8060 iterator by calling bidi_pop_it same number of times.
8061 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8062 and we are bidi-iterating, don't decrement the iterator position;
8063 instead, set the first_elt flag in the bidi iterator, to produce
8065 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8066 (push_display_prop): xassert that we are iterating a buffer.
8067 (push_it, pop_it): Save and restore paragraph_embedding member.
8068 (handle_single_display_spec, next_overlay_string)
8069 (get_overlay_strings_1, reseat_1, reseat_to_string)
8070 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8071 correctly. Don't assume unibyte strings are not bidi-reordered.
8072 (compute_display_string_pos)
8073 (compute_display_string_end): Fix handling the case of C string.
8074 (push_it, pop_it): Save and restore from_disp_prop_p.
8075 (handle_single_display_spec, push_display_prop): Set the
8076 from_disp_prop_p flag.
8077 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8078 (pop_it): Call iterate_out_of_display_property only if we are
8079 popping after iteration over a string that came from a display
8080 property. Fix a typo in popping stretch info. Add an assertion
8081 for verifying that the iterator position is in sync with the bidi
8083 (handle_single_display_spec, get_overlay_strings_1)
8084 (push_display_prop): Fix initialization of paragraph direction for
8085 string when that of the parent object is not yet determined.
8086 (reseat_1): Call bidi_init_it to resync the bidi
8087 iterator with IT's position. (Bug#7616)
8088 (find_row_edges): If ROW->start.pos gives position
8089 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8090 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8091 Reset the from_disp_prop_p flag.
8092 (SAVE_IT, RESTORE_IT): New macros.
8093 (pos_visible_p, face_before_or_after_it_pos)
8094 (back_to_previous_visible_line_start)
8095 (move_it_in_display_line_to, move_it_in_display_line)
8096 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8097 (try_scrolling, redisplay_window, display_line): Use them when
8098 saving a temporary copy of the iterator and restoring it back.
8099 (back_to_previous_visible_line_start, reseat_1)
8100 (init_iterator): Empty the bidi cache "stack".
8101 (move_it_in_display_line_to): If iterator ended up at
8102 EOL, but we never saw any buffer positions smaller than
8103 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8104 motion in bidi-reordered lines.
8105 (move_it_in_display_line_to): Record prev_method and prev_pos
8106 immediately before the call to set_iterator_to_next. Fixes cursor
8107 motion in bidi-reordered lines with stretch glyphs and strings
8108 displayed in margins. (Bug#8133) (Bug#8867)
8109 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8111 (pos_visible_p): Support positions in bidi-reordered lines.
8112 Save and restore bidi cache.
8114 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8115 (bidi_paragraph_info): Delete unused struct.
8116 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8117 (bidi_cache_start): New variable.
8118 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8120 (bidi_cache_fetch_state, bidi_cache_search)
8121 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8122 (bidi_cache_find, bidi_peek_at_next_level)
8123 (bidi_level_of_next_char, bidi_find_other_level_edge)
8124 (bidi_move_to_visually_next): Compare cache index with
8125 bidi_cache_start rather than with zero.
8126 (bidi_fetch_char): Accept new argument STRING; all callers
8127 changed. Support iteration over a string. Support strings with
8128 display properties. Support unibyte strings. Fix the type of
8129 `len' according to what STRING_CHAR_AND_LENGTH expects.
8130 (bidi_paragraph_init, bidi_resolve_explicit_1)
8131 (bidi_resolve_explicit, bidi_resolve_weak)
8132 (bidi_level_of_next_char, bidi_move_to_visually_next):
8133 Support iteration over a string.
8134 (bidi_set_sor_type, bidi_resolve_explicit_1)
8135 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8136 can now be zero (for strings); special values 0 and -1 were
8137 changed to -1 and -2, respectively.
8138 (bidi_char_at_pos): New function.
8139 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8140 Call it instead of FETCH_MULTIBYTE_CHAR.
8141 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8142 initialized to valid values.
8143 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8145 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8146 the test for valid cached positions. Fix the logic for looking up
8147 the sentinel state in the cache. GCPRO the Lisp string we are
8149 (bidi_push_it, bidi_pop_it): New functions.
8150 (bidi_initialize): Initialize the bidi cache start stack pointer.
8151 (bidi_cache_ensure_space): New function, refactored from part of
8152 bidi_cache_iterator_state. Don't assume the required size is just
8153 one BIDI_CACHE_CHUNK away.
8154 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8155 (bidi_count_bytes, bidi_char_at_pos): New functions.
8156 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8157 always valid if bidi_cache_idx is valid.
8158 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8159 is valid if it's going to be used.
8160 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8161 (bidi_cache_fetch_state, bidi_cache_search)
8162 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8163 (bidi_cache_iterator_state, bidi_cache_find)
8164 (bidi_find_other_level_edge, bidi_cache_start_stack):
8165 All variables related to cache indices are now EMACS_INT.
8167 * dispextern.h (struct bidi_string_data): New structure.
8168 (struct bidi_it): New member `string'. Make flag members be 1-bit
8169 fields, and put them last in the struct.
8170 (compute_display_string_pos, compute_display_string_end):
8172 (bidi_push_it, bidi_pop_it): Add prototypes.
8173 (struct iterator_stack_entry): New members bidi_p,
8174 paragraph_embedding, and from_disp_prop_p.
8175 (struct it): Member bidi_p is now a bit field 1 bit wide.
8176 (bidi_shelve_cache, bidi_unshelve_cache):
8179 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8180 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8181 and vector-like objects.
8183 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8184 cache around display iteration.
8186 * window.c (Fwindow_end, window_scroll_pixel_based)
8187 (displayed_window_lines, Frecenter): Save and restore the bidi
8188 cache around display iteration.
8190 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8192 * editfns.c (Fdelete_region): Clarify the use of the named
8193 parameters (bug#6788).
8195 2011-07-14 Martin Rudalics <rudalics@gmx.at>
8197 * indent.c (Fvertical_motion): Set and restore w->pointm when
8198 saving and restoring the window's buffer (Bug#9006).
8200 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8202 * editfns.c (Fstring_to_char): Clarify just what is returned
8203 (bug#6576). Text by Eli Zaretskii.
8205 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
8207 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8209 2011-07-13 Eli Zaretskii <eliz@gnu.org>
8211 * buffer.c (mmap_find): Fix a typo.
8213 2011-07-13 Johan Bockgård <bojohan@gnu.org>
8215 Fix execution of x selection hooks.
8216 * xselect.c (Qx_lost_selection_functions)
8217 (Qx_sent_selection_functions): New vars.
8218 (syms_of_xselect): DEFSYM them.
8219 (x_handle_selection_request): Pass Qx_sent_selection_functions
8220 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8221 (x_handle_selection_clear,x_clear_frame_selections):
8222 Pass Qx_lost_selection_functions rather than
8223 Vx_lost_selection_functions to Frun_hook_with_args.
8225 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8227 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
8228 The old code sometimes used this field without initializing it.
8230 * alloc.c (gc_sweep): Don't read past end of array.
8231 In theory, the old code could also have corrupted Emacs internals,
8232 though it'd be very unlikely.
8234 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8236 * character.c (Fcharacterp): Don't advertise optional ignored
8237 argument. (Bug#4026)
8239 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8241 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8244 * window.c (Fset_window_start): Doc fix (bug#4199).
8245 (Fset_window_hscroll): Ditto.
8247 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8249 Fix minor new problems caught by GCC 4.6.1.
8250 * term.c (init_tty): Remove unused local.
8251 * xsettings.c (store_monospaced_changed): Define this function only
8252 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
8255 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
8257 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8259 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8261 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8262 are the mini-buffer and the echo area (bug#3320).
8264 * term.c (init_tty): Remove support for supdup, c10 and perq
8265 terminals, which are no longer supported (bug#1482).
8267 2011-07-10 Johan Bockgård <bojohan@gnu.org>
8269 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8271 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8273 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8274 for non-popups (Bug#3642).
8276 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8278 * alloc.c (reset_malloc_hooks): Protoize.
8279 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
8280 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8281 * cm.c (losecursor): Likewise.
8282 * data.c (fmod): Likewise.
8283 * dispnew.c (swap_glyphs_in_rows): Likewise.
8284 * emacs.c (memory_warning_signal): Likewise.
8285 * floatfns.c (float_error): Likewise.
8286 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8287 (otf_open, font_otf_capability, generate_otf_features)
8288 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8290 * image.c (pbm_read_file): Likewise.
8291 * indent.c (string_display_width): Likewise.
8292 * intervals.c (check_for_interval, search_for_interval)
8293 (inc_interval_count, count_intervals, root_interval)
8294 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8295 * lread.c (defalias): Likewise.
8296 * ralloc.c (r_alloc_check): Likewise.
8297 * regex.c (set_image_of_range_1, set_image_of_range)
8298 (regex_grow_registers): Likewise.
8299 * sysdep.c (strerror): Likewise.
8300 * termcap.c (valid_filename_p, tprint, main): Likewise.
8301 * tparam.c (main): Likewise.
8302 * unexhp9k800.c (run_time_remap, save_data_space)
8303 (update_file_ptrs, read_header, write_header, calculate_checksum)
8304 (copy_file, copy_rest, display_header): Likewise.
8305 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8307 * xdisp.c (check_it): Likewise.
8308 * xfaces.c (register_color, unregister_color, unregister_colors):
8310 * xfns.c (print_fontset_result): Likewise.
8311 * xrdb.c (member, fatal, main): Likewise.
8313 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8315 Fix minor problems found by static checking (Bug#9031).
8316 * chartab.c (char_table_set_range, map_sub_char_table):
8317 Remove unused locals.
8318 (uniprop_table): Now static.
8319 * composite.c (_work_char): Remove unused static var.
8321 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
8323 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8325 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8327 * gtkutil.c (qttip_cb): Remove code without function.
8329 2011-07-09 Eli Zaretskii <eliz@gnu.org>
8331 * w32.c (pthread_sigmask): New stub.
8333 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
8335 Use pthread_sigmask, not sigprocmask (Bug#9010).
8336 sigprocmask is portable only for single-threaded applications, and
8337 Emacs can be multi-threaded when it uses GTK.
8338 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8340 * callproc.c (Fcall_process):
8341 * process.c (create_process):
8342 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8343 Use pthread_sigmask, not sigprocmask.
8345 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8347 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8348 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8351 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8353 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8354 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8355 (xg_hide_tooltip): Fix comment.
8357 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8358 in registerServicesMenuSendTypes.
8359 (validRequestorForSendType): Don't check ns_return_types.
8361 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8364 2011-07-08 Jason Rumney <jasonr@gnu.org>
8366 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8367 SH_SHOW for hidden windows (Bug#5482).
8369 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8370 frame struct members of non-existent frames (Bug#6284).
8372 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8374 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8375 variable firstTime not needed on OSX >= 10.6.
8376 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8377 >= 10.5. Use setKnobProportion, setDoubleValue.
8379 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8380 (MAC_OS_X_VERSION_10_5): Define if not defined.
8381 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8382 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8383 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8385 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
8386 cString and lossyCString on OSX >= 10.4.
8388 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
8389 sizeToFit on OSX >= 10.2.
8391 * nsimage.m (allocInitFromFile): Don't use deprecated method
8392 bestRepresentationForDevice on OSX >= 10.6.
8394 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8397 * emacs.c: Declare unexec_init_emacs_zone.
8399 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8401 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8403 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8404 on svcsMenu (Bug#8842).
8406 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8408 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8410 * nsterm.m (QUTF8_STRING): Declare.
8411 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8412 (validRequestorForSendType): Return type is (id).
8413 Change indexOfObjectIdenticalTo to indexOfObject.
8414 Check if we have local selection before returning self (Bug#8842).
8415 (writeSelectionToPasteboard): Put local selection into paste board
8416 if we have a local selection (Bug#8842).
8417 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8419 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8420 (ns_get_local_selection): Declare.
8422 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8424 * keymap.c (describe_map_tree): Don't insert a double newline at
8425 the end of the buffer (bug#1169) and return whether we inserted
8428 * callint.c (Fcall_interactively): Change "reading args" to
8429 "providing args" to try to clarify what it does (bug#1010).
8431 2011-07-07 Kenichi Handa <handa@m17n.org>
8433 * composite.c (composition_compute_stop_pos): Ignore a static
8434 composition starting before CHARPOS (Bug#8915).
8436 * xdisp.c (handle_composition_prop): Likewise.
8438 2011-07-07 Eli Zaretskii <eliz@gnu.org>
8440 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8443 2011-07-07 Kenichi Handa <handa@m17n.org>
8445 * character.h (unicode_category_t): New enum type.
8447 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8448 (Qchar_code_property_table): New variable.
8449 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8450 (UNIPROP_COMPRESSED_FORM_P): New macros.
8451 (char_table_ascii): Uncompress the compressed values.
8452 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8453 Uncompress the compressed values.
8454 (sub_char_table_ref_and_range): Likewise.
8455 (char_table_ref_and_range): Uncompress the compressed values.
8456 (sub_char_table_set): New arg is_uniprop. Callers changed.
8457 Uncompress the compressed values.
8458 (sub_char_table_set_range): Args changed. Callers changed.
8459 (char_table_set_range): Adjuted for the above change.
8460 (map_sub_char_table): Delete args default_val and parent. Add arg
8461 top. Give decoded values to a Lisp function.
8462 (map_char_table): Adjust for the above change. Give decoded
8463 values to a Lisp function. Gcpro more variables.
8464 (uniprop_table_uncompress)
8465 (uniprop_decode_value_run_length): New functions.
8466 (uniprop_decoder, uniprop_decoder_count): New variables.
8467 (uniprop_get_decoder, uniprop_encode_value_character)
8468 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8470 (uniprop_encoder, uniprop_encoder_count): New variables.
8471 (uniprop_get_encoder, uniprop_table)
8472 (Funicode_property_table_internal, Fget_unicode_property_internal)
8473 (Fput_unicode_property_internal): New functions.
8474 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8475 Sunicode_property_table_internal, Sget_unicode_property_internal,
8476 and Sput_unicode_property_internal. Defvar_lisp
8477 char-code-property-alist.
8479 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
8480 Vunicode_category_table.
8482 * font.c (font_range): Adjust for the change of
8483 Vunicode_category_table.
8485 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8487 * m/iris4d.h: Remove file, move contents ...
8488 * s/irix6-5.h: ... here.
8490 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8492 Remove unportable assumption about struct layout (Bug#8884).
8493 * alloc.c (mark_buffer):
8494 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8495 (clone_per_buffer_values): Don't assume that
8496 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8497 This isn't true in general, and it's particularly not true
8498 if Emacs is configured with --with-wide-int.
8499 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8500 New macros, used in the buffer.c change.
8502 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8504 * xsettings.c: Use both GConf and GSettings if both are available.
8505 (store_config_changed_event): Add comment.
8506 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8507 (store_tool_bar_style_changed): New functions.
8508 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
8509 (struct xsettings): Move font inside HAVE_XFT.
8510 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
8511 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
8512 Move inside HAVE_XFT.
8513 (something_changed_gsettingsCB): Rename from something_changedCB.
8514 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8516 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
8517 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
8518 (something_changed_gconfCB): Rename from something_changedCB.
8519 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8520 (parse_settings): Move check for font inside HAVE_XFT.
8521 (read_settings, apply_xft_settings): Add comment.
8522 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8523 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8524 call store_font_name_changed.
8525 (xft_settings_event): Add comment.
8526 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8527 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8528 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8529 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8530 (xsettings_initialize): Call init_gsettings last.
8531 (xsettings_get_system_font, xsettings_get_system_normal_font):
8534 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8536 Random fixes. E.g., (random) never returned negative values.
8537 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8538 subseconds part to the entropy, as that's a bit more random.
8539 Prefer signed to unsigned, since the signedness doesn't matter and
8540 in general we prefer signed. When given a limit, use a
8541 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8542 latter isn't right if USE_2_TAGS_FOR_INTS.
8543 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8544 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8546 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8548 * textprop.c (text_property_stickiness):
8549 Obey Vtext_property_default_nonsticky.
8550 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8551 * w32fns.c (syms_of_w32fns):
8552 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8554 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8556 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8557 This is more efficient than Ffile_directory_p and avoids a minor race.
8559 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8561 * buffer.c (Foverlay_put): Say what the return value is
8564 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8565 is a directory before asking whether to use the file name
8567 (barf_or_query_if_file_exists): Make the "File is a directory"
8568 error be more correct.
8570 * fns.c (Frequire): Remove the mention of the .gz files, since
8571 that's installation-specific, but keep the mention of
8572 `get-load-suffixes'.
8574 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8576 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8577 Report string overflow if the output is too long.
8579 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
8581 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8582 (syms_of_gnutls): Remove duplicate DEFSYM for
8583 Qgnutls_bootprop_verify_hostname_error, an error for
8584 Qgnutls_bootprop_verify_error (which is no longer used).
8586 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8587 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8588 Also (re)move comments that are misplaced or no longer relevant.
8590 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8592 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8594 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
8596 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8597 and background color parameters if they have been changed.
8599 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8601 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8603 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8605 * xsettings.c (SYSTEM_FONT): Define only when used.
8606 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8608 * keymap.c (access_keymap_1): Now static.
8610 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
8612 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8613 leave any prefix arg for the up event (Bug#1586).
8615 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8617 * lread.c (syms_of_lread): Mention single symbols defined by
8618 `defvar' or `defconst' (bug#7154).
8620 * fns.c (Frequire): Mention .el.gz files (bug#7314).
8621 (Frequire): Mention get-load-suffixes.
8623 2011-07-02 Martin Rudalics <rudalics@gmx.at>
8625 * window.h (window): Remove clone_number slot.
8626 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8628 (make_parent_window, make_window, saved_window)
8629 (Fset_window_configuration, save_window_save): Don't deal with
8631 * buffer.c (Qclone_number): Remove declaration.
8632 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8634 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8636 Add multiple inheritance to keymaps.
8637 * keymap.c (Fmake_composed_keymap): New function.
8638 (Fset_keymap_parent): Simplify.
8639 (fix_submap_inheritance): Remove.
8640 (access_keymap_1): New function extracted from access_keymap to handle
8641 embedded parents and handle lists of maps.
8642 (access_keymap): Use it.
8643 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8644 (Fcopy_keymap): Handle embedded parents.
8645 (Fcommand_remapping, define_as_prefix): Simplify.
8646 (Fkey_binding): Simplify.
8647 (syms_of_keymap): Move minibuffer-local-completion-map,
8648 minibuffer-local-filename-completion-map,
8649 minibuffer-local-must-match-map, and
8650 minibuffer-local-filename-must-match-map to Elisp.
8651 (syms_of_keymap): Defsubr make-composed-keymap.
8652 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8653 (parse_menu_item): Trivial simplification.
8655 2011-07-01 Glenn Morris <rgm@gnu.org>
8657 * Makefile.in (SETTINGS_LIBS): Fix typo.
8659 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8661 * coding.c (Fencode_coding_string): Record the last coding system
8662 used, as the function doc string says (bug#8738).
8664 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8666 * xsettings.c (store_monospaced_changed): Take new font as arg and
8667 check for change against current_mono_font.
8668 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8669 (emacs_settings_constructor, emacs_settings_get_property)
8670 (emacs_settings_set_property, emacs_settings_class_init)
8671 (emacs_settings_init, gsettings_obj): Remove.
8672 (something_changedCB): New function for HAVE_GSETTINGS.
8673 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8674 with value as argument.
8675 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8676 g_settings_new (Bug#8967). Do not create gsettings_obj.
8677 Remove calls to g_settings_bind. Connect something_changedCB to
8680 * xgselect.c: Add defined (HAVE_GSETTINGS).
8681 (xgselect_initialize): Ditto.
8683 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8684 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8687 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8689 * eval.c (struct backtrace): Simplify and port the data structure.
8690 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8691 signed bit field, as this assumption is not portable and it makes
8692 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8693 "char debug_on_exit : 1" as this is not portable either; instead,
8694 use the portable "unsigned int debug_on_exit : 1". Remove unused
8695 member evalargs. Remove obsolete comments about cc bombing out.
8697 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8699 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
8700 Let HAVE_GSETTINGS override HAVE_GCONF.
8701 (store_monospaced_changed): New function.
8702 (EMACS_SETTINGS): A new type derived from GObject to handle
8703 GSettings notifications.
8704 (emacs_settings_constructor, emacs_settings_get_property)
8705 (emacs_settings_set_property, emacs_settings_class_init):
8707 (gsettings_client, gsettings_obj): New variables.
8708 (GSETTINGS_SCHEMA): New define.
8709 (something_changedCB): Call store_monospaced_changed.
8710 (init_gsettings): New function.
8711 (xsettings_initialize): Call init_gsettings.
8712 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8715 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
8718 2011-06-29 Martin Rudalics <rudalics@gmx.at>
8720 * window.c (resize_root_window, grow_mini_window)
8721 (shrink_mini_window): Rename Qresize_root_window to
8722 Qwindow_resize_root_window and Qresize_root_window_vertically to
8723 Qwindow_resize_root_window_vertically.
8725 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8727 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8729 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
8731 * makefile.w32-in: Redesign dependencies so they reflect more
8732 clearly which files are directly included by each source file,
8733 and not through other includes.
8735 2011-06-27 Martin Rudalics <rudalics@gmx.at>
8737 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8738 (sort_overlays, overlay_strings): When an overlay's clone number
8739 matches the window's clone number process the overlay even if
8740 the overlay's window property doesn't match the current window.
8742 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8743 (Fwindow_hchild): Rename to Fwindow_left_child.
8744 (Fwindow_next): Rename to Fwindow_next_sibling.
8745 (Fwindow_prev): Rename to Fwindow_prev_sibling.
8746 (resize_window_check): Rename to window_resize_check.
8747 (resize_window_apply): Rename to window_resize_apply.
8748 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8749 (Fdelete_other_windows_internal, resize_frame_windows)
8750 (Fsplit_window_internal, Fdelete_window_internal)
8751 (grow_mini_window, shrink_mini_window)
8752 (Fresize_mini_window_internal): Fix callers accordingly.
8754 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8756 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8757 (emacs_fixed_set_min_size): Remove.
8758 (emacs_fixed_new): Take frame as argument.
8760 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8761 (_EmacsFixedPrivate): Remove minwidth/height.
8762 Add struct frame *f.
8763 (emacs_fixed_init): Initialize priv->f.
8764 (get_parent_class, emacs_fixed_set_min_size): Remove.
8765 (emacs_fixed_new): Set priv->f to argument.
8766 (emacs_fixed_get_preferred_width)
8767 (emacs_fixed_get_preferred_height): Use min_width/height from
8768 frames size_hint to set minimum and natural (Bug#8919).
8769 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8770 and use min_width/height from frames size_hint to set
8771 min_width/height (Bug#8919).
8773 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
8774 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8777 2011-06-26 Eli Zaretskii <eliz@gnu.org>
8779 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8780 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8783 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
8785 * process.c (wait_reading_process_output): Bypass select if
8786 waiting for a cell while ignoring keyboard input, and input is
8787 pending. Suggested by Jan Djärv (Bug#8869).
8789 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8791 Use gnulib's dup2 module instead of rolling our own.
8792 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8794 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8796 * dispnew.c (scrolling_window): Before scrolling, turn off a
8797 mouse-highlight in the window being scrolled.
8799 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8801 Move DEFSYM to lisp.h and use everywhere.
8803 * character.h (DEFSYM): Move declaration...
8804 * lisp.h (DEFSYM): ...here.
8810 * w32select.c: Don't include character.h.
8812 * alloc.c (syms_of_alloc):
8813 * buffer.c (syms_of_buffer):
8814 * bytecode.c (syms_of_bytecode):
8815 * callint.c (syms_of_callint):
8816 * casefiddle.c (syms_of_casefiddle):
8817 * casetab.c (init_casetab_once):
8818 * category.c (init_category_once, syms_of_category):
8819 * ccl.c (syms_of_ccl):
8820 * cmds.c (syms_of_cmds):
8821 * composite.c (syms_of_composite):
8822 * dbusbind.c (syms_of_dbusbind):
8823 * dired.c (syms_of_dired):
8824 * dispnew.c (syms_of_display):
8825 * doc.c (syms_of_doc):
8826 * editfns.c (syms_of_editfns):
8827 * emacs.c (syms_of_emacs):
8828 * eval.c (syms_of_eval):
8829 * fileio.c (syms_of_fileio):
8830 * fns.c (syms_of_fns):
8831 * frame.c (syms_of_frame):
8832 * fringe.c (syms_of_fringe):
8833 * insdel.c (syms_of_insdel):
8834 * keymap.c (syms_of_keymap):
8835 * lread.c (init_obarray, syms_of_lread):
8836 * macros.c (syms_of_macros):
8837 * msdos.c (syms_of_msdos):
8838 * print.c (syms_of_print):
8839 * process.c (syms_of_process):
8840 * search.c (syms_of_search):
8841 * sound.c (syms_of_sound):
8842 * syntax.c (init_syntax_once, syms_of_syntax):
8843 * terminal.c (syms_of_terminal):
8844 * textprop.c (syms_of_textprop):
8845 * undo.c (syms_of_undo):
8846 * w32.c (globals_of_w32):
8847 * window.c (syms_of_window):
8848 * xdisp.c (syms_of_xdisp):
8849 * xfaces.c (syms_of_xfaces):
8850 * xfns.c (syms_of_xfns):
8851 * xmenu.c (syms_of_xmenu):
8852 * xsettings.c (syms_of_xsettings):
8853 * xterm.c (syms_of_xterm): Use DEFSYM.
8855 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8857 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8859 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8861 Integer and buffer overflow fixes (Bug#8873).
8863 * print.c (printchar, strout): Check for string overflow.
8864 (PRINTPREPARE, printchar, strout):
8865 Don't set size unless allocation succeeds.
8867 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8868 for sizes. Check for string overflow more accurately.
8869 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8871 * macros.c: Integer and buffer overflow fixes.
8872 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8873 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8874 Use ptrdiff_t, not int, for sizes.
8875 Don't increment bufsize until after realloc succeeds.
8876 Check for size-calculation overflow.
8877 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8879 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8881 * lread.c: Integer overflow fixes.
8882 (read_integer): Radix is now EMACS_INT, not int,
8883 to improve quality of diagnostics for out-of-range radices.
8884 Calculate buffer size correctly for out-of-range radices.
8885 (read1): Check for integer overflow in radices, and in
8886 read-circle numbers.
8887 (read_escape): Avoid int overflow.
8888 (Fload, openp, read_buffer_size, read1)
8889 (substitute_object_recurse, read_vector, read_list, map_obarray):
8890 Use ptrdiff_t, not int, for sizes.
8891 (read1): Use EMACS_INT, not int, for sizes.
8892 Check for size overflow.
8894 * image.c (cache_image): Check for size arithmetic overflow.
8896 * lread.c: Integer overflow issues.
8897 (saved_doc_string_size, saved_doc_string_length)
8898 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8899 Now ptrdiff_t, not int.
8900 (read1): Don't assume doc string length fits in int. Check for
8901 out-of-range doc string lengths.
8902 (read_list): Don't assume file position fits in int.
8903 (read_escape): Check for hex character overflow.
8905 2011-06-22 Leo Liu <sdl.web@gmail.com>
8907 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8908 Move to minibuffer.el.
8910 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8912 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8913 The following patches are for when GLYPH_DEBUG && !XASSERT.
8914 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8915 * dispnew.c (flush_stdout):
8916 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8917 Mark as externally visible.
8918 * dispnew.c (check_window_matrix_pointers): Now static.
8919 * dispnew.c (window_to_frame_vpos):
8920 * xfns.c (unwind_create_frame):
8921 * xterm.c (x_check_font): Remove unused local.
8922 * scroll.c (CHECK_BOUNDS):
8923 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8924 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8925 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8926 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8927 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8929 (debug_method_add): Use va_list and vsprintf rather than relying
8930 on undefined behavior with wrong number of arguments.
8931 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8932 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8933 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8934 since we're not interested in debugging glyphs with old libraries.
8935 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8936 GCC 4.6.0's static checking.
8938 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8940 Integer overflow and signedness fixes (Bug#8873).
8941 A few related buffer overrun fixes, too.
8943 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8945 * dispextern.h (struct face.stipple):
8946 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8947 (x_bitmap_mask, x_allocate_bitmap_record)
8948 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8949 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8950 (x_create_bitmap_from_xpm_data):
8951 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8952 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8954 * xfaces.c (load_pixmap):
8955 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8956 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8957 (.bitmaps_last, struct x_output.icon_bitmap):
8958 Use ptrdiff_t, not int, for bitmap indexes.
8959 (x_allocate_bitmap_record): Check for size overflow.
8960 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8962 Use ptrdiff_t, not int, for overlay counts.
8963 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8964 * editfns.c (overlays_around, get_pos_property):
8965 * textprop.c (get_char_property_and_overlay):
8966 * xdisp.c (next_overlay_change, note_mouse_highlight):
8967 * xfaces.c (face_at_buffer_position):
8968 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8969 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8970 (Fnext_overlay_change, Fprevious_overlay_change)
8971 (mouse_face_overlay_overlaps, Foverlays_in):
8972 Use ptrdiff_t, not int, for sizes.
8973 (overlays_at, overlays_in): Check for size-calculation overflow.
8975 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8977 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8978 (x_session_initialize): Do not assume string length fits in int.
8980 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8981 This is unlikely, but can occur if DPI is outlandish.
8983 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
8984 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8986 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8987 * xrdb.c (magic_file_p, search_magic_path):
8988 Omit last arg SUFFIX; it was always 0. All callers changed.
8989 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8991 * xfont.c (xfont_match): Avoid need for strlen.
8993 * xfns.c: Don't assume strlen fits in int.
8994 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8996 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8997 not unsigned long, as we prefer signed integers. All callers changed.
8998 Detect integer overflow in repeat count.
8999 (message_dolog): Don't assume print length fits in 39 bytes.
9000 (display_mode_element): Don't assume strlen fits in int.
9002 * termcap.c: Don't assume sizes fit in int and never overflow.
9003 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9004 (gobble_line): Check for size-calculation overflow.
9006 * minibuf.c (Fread_buffer):
9007 * lread.c (intern, intern_c_string):
9008 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9009 Don't assume string length fits in int.
9011 * keyboard.c (parse_tool_bar_item):
9012 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9014 * font.c: Don't assume string length fits in int.
9015 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9016 Use ptrdiff_t, not int.
9017 (font_intern_prop): Don't assume string length fits in int.
9018 Don't assume integer property fits in fixnum.
9019 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
9021 * filelock.c: Fix some buffer overrun and integer overflow issues.
9022 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
9023 Reformulate so as not to need the command string.
9024 Invoke gzip -cd rather than gunzip, as it's more portable.
9025 (lock_info_type, lock_file_1, lock_file):
9026 Don't assume pid_t and time_t fit in unsigned long.
9027 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9028 (current_lock_owner): Prefer signed type for sizes.
9029 Use memcpy, not strncpy, where memcpy is what is really wanted.
9030 Don't assume (via atoi) that time_t and pid_t fit in int.
9031 Check for time_t and/or pid_t out of range, e.g., via a network share.
9032 Don't alloca where an auto var works fine.
9034 * fileio.c: Fix some integer overflow issues.
9035 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9036 Don't assume string length fits in int.
9037 (directory_file_name): Don't assume string length fits in long.
9038 (make_temp_name): Don't assume pid fits in int, or that its print
9039 length is less than 20.
9041 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9043 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9045 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9047 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9048 We prefer signed integers, even for size calculations.
9050 * emacs.c: Don't assume string length fits in 'int'.
9051 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9052 (main): Don't invoke strlen when not needed.
9054 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9055 (XD_DEBUG_MESSAGE): Don't waste a byte.
9057 * callproc.c (getenv_internal_1, getenv_internal)
9059 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9061 * lread.c (invalid_syntax): Omit length argument.
9062 All uses changed. This doesn't fix a bug, but it simplifies the
9063 code away from its former Hollerith-constant appearance, and it's
9064 one less 'int' to worry about when looking at integer-overflow issues.
9065 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
9067 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9068 This didn't break anything, but it didn't help either.
9069 It's confusing to put a bogus integer in a place where the actual
9070 value does not matter.
9071 (LIST_END_P): Remove unused macro and its bogus comment.
9072 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
9074 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9075 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9077 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9078 We prefer signed types, and the value cannot exceed the EMACS_INT
9079 range anyway (because otherwise the length would not be representable).
9080 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9081 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9082 This avoids a GCC warning when WIDE_EMACS_INT.
9084 * indent.c (sane_tab_width): New function.
9085 (current_column, scan_for_column, Findent_to, position_indentation)
9086 (compute_motion): Use it. This is just for clarity.
9087 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
9089 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
9091 * lisp.h (lint_assume): New macro.
9092 * composite.c (composition_gstring_put_cache):
9093 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9095 * editfns.c, insdel.c:
9096 Omit unnecessary forward decls, to simplify future changes.
9098 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9100 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9102 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
9103 Use much-faster test for byte-length change.
9104 Don't assume string byte-length fits in 'int'.
9105 Check that character arg fits in 'int'.
9106 (mapcar1): Declare byte as byte, for clarity.
9108 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9110 * fns.c (concat): Catch string overflow earlier.
9111 Do not rely on integer wraparound.
9113 * dispextern.h (struct it.overlay_strings_charpos)
9114 (struct it.selective): Now EMACS_INT, not int.
9115 * xdisp.c (forward_to_next_line_start)
9116 (back_to_previous_visible_line_start)
9117 (reseat_at_next_visible_line_start, next_element_from_buffer):
9118 Don't arbitrarily truncate the value of 'selective' to int.
9120 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9122 * composite.c: Don't truncate sizes to 'int'.
9123 (composition_gstring_p, composition_reseat_it)
9124 (composition_adjust_point): Use EMACS_INT, not int.
9125 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9126 not EMACS_UINT, for indexes.
9128 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9130 * buffer.c: Include <verify.h>.
9131 (struct sortvec.priority, struct sortstr.priority):
9132 Now EMACS_INT, not int.
9133 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
9134 (struct sortstr.size, record_overlay_string)
9135 (struct sortstrlist.size, struct sortlist.used):
9136 Don't truncate size to int.
9137 (record_overlay_string): Check for size-calculation overflow.
9138 (init_buffer_once): Check at compile-time, not run-time.
9140 2011-06-22 Jim Meyering <meyering@redhat.com>
9142 Don't leak an XBM-image-sized buffer
9143 * image.c (xbm_load): Free the image buffer after using it.
9145 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9148 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9149 that Sun C diagnosed.
9150 * fns.c (secure_hash): Fix pointer signedness issue.
9151 * intervals.c (static_offset_intervals): New function.
9152 (offset_intervals): Use it.
9154 2011-06-21 Leo Liu <sdl.web@gmail.com>
9157 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9160 * fns.c (secure_hash): Rename from crypto_hash_function and change
9161 the first arg to accept symbols.
9162 (Fsecure_hash): New primitive.
9163 (syms_of_fns): New symbols.
9165 2011-06-20 Deniz Dogan <deniz@dogan.se>
9167 * process.c (Fset_process_buffer): Clarify return value in
9170 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
9172 * dispnew.c (add_window_display_history): Use BVAR.
9174 * xdisp.c (debug_method_add): Use BVAR.
9175 (check_window_end, dump_glyph_matrix, dump_glyph)
9176 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9178 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9181 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9182 check till after the cache is created in init_frame_faces.
9184 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9186 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9188 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9190 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9191 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9192 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9194 Improve buffer-overflow checking (Bug#8873).
9195 * fileio.c (Finsert_file_contents):
9196 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9197 Remove the old (too-loose) buffer overflow checks.
9198 They weren't needed, since make_gap checks for buffer overflow.
9199 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9200 The old code merely checked for Emacs fixnum overflow, and relied
9201 on undefined (wraparound) behavior. The new code avoids undefined
9202 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9204 * editfns.c (Finsert_char): Don't dump core with very negative counts.
9205 Tune. Don't use wider integers than needed. Don't use alloca.
9206 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
9208 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9210 * insdel.c, lisp.h (buffer_overflow): New function.
9211 (insert_from_buffer_1, replace_range, replace_range_2):
9212 * insdel.c (make_gap_larger):
9213 * editfns.c (Finsert_char):
9214 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9216 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9218 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9220 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
9222 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9223 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9225 * fileio.c: Don't assume EMACS_INT fits in off_t.
9226 (emacs_lseek): New static function.
9227 (Finsert_file_contents, Fwrite_region): Use it.
9228 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9230 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9232 * fns.c: Don't overflow int when computing a list length.
9233 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9234 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9235 truncation on 64-bit hosts. Check for QUIT every
9236 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9237 faster and is responsive enough.
9238 (Flength): Report an error instead of overflowing an integer.
9239 (Fsafe_length): Return a float if the value is not representable
9240 as a fixnum. This shouldn't happen except in contrived situations.
9241 (Fnthcdr, Fsort): Don't assume list length fits in int.
9242 (Fcopy_sequence): Don't assume vector length fits in int.
9244 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9245 (header_size, word_size): New constants.
9246 (allocate_vectorlike): Don't check size overflow here.
9247 (allocate_vector): Check it here instead, since this is the only
9248 caller of allocate_vectorlike that could cause overflow.
9249 Check that the new vector's length is representable as a fixnum.
9251 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9252 The previous code was bogus. For example, next_almost_prime (32)
9253 returned 39, which is undesirable as it is a multiple of 3; and
9254 next_almost_prime (24) returned 25, which is a multiple of 5 so
9255 why was the code bothering to check for multiples of 7?
9257 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9259 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9261 Variadic C functions now count arguments with ptrdiff_t.
9262 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9263 Back then I didn't know that the Emacs coding style prefers signed int.
9264 Also, in the meantime I found a few more instances where arguments
9265 were being counted with int, which may truncate counts on 64-bit
9266 machines, or EMACS_INT, which may be unnecessarily wide.
9267 * lisp.h (struct Lisp_Subr.function.aMANY)
9268 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9269 Arg counts are now ptrdiff_t, not size_t.
9270 All variadic functions and their callers changed accordingly.
9271 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9272 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9273 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9274 * callint.c (Fcall_interactively): Check arg count for overflow,
9275 to avoid potential buffer overrun. Use signed char, not 'int',
9276 for 'varies' array, so that we needn't bother to check its size
9277 calculation for overflow.
9278 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9279 * eval.c (apply_lambda):
9280 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9281 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9282 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9284 * callint.c (Fcall_interactively): Don't use index var as event count.
9286 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9287 * mem-limits.h (SIZE): Remove; no longer used.
9289 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
9291 Remove unnecessary casts.
9292 * xterm.c (x_term_init):
9293 * xfns.c (x_set_border_pixel):
9294 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9295 These aren't needed now that we assume ANSI C.
9297 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9298 It's more likely to cause problems (due to unsigned overflow)
9301 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9303 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9305 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9307 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9309 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9311 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9313 GLYPH_CODE_FACE returns EMACS_INT, not int.
9314 * dispextern.h (merge_faces):
9315 * xfaces.c (merge_faces):
9316 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9317 Don't assume EMACS_INT fits in int.
9319 * character.h (CHAR_VALID_P): Remove unused parameter.
9320 * fontset.c, lisp.h, xdisp.c: All uses changed.
9322 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9324 * fns.c (concat): Minor tuning based on overflow analysis.
9325 This doesn't fix any bugs. Use int to hold character, instead
9326 of constantly refetching from Emacs object. Use XFASTINT, not
9327 XINT, for value known to be a character. Don't bother comparing
9328 a single byte to 0400, as it's always less.
9330 * floatfns.c (Fexpt):
9331 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9333 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9336 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9338 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9339 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9340 incorrectly succeed when S was a string, because 4294967386 was
9341 truncated before it was used.
9343 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9344 Otherwise, an out-of-range integer could cause undefined behavior
9347 * composite.c: Use int, not EMACS_INT, for characters.
9348 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9349 EMACS_INT, for values that are known to be in character range.
9350 This doesn't fix any bugs but is the usual style inside Emacs and
9351 may generate better code on 32-bit machines.
9353 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9354 This is for reasons similar to the recent CHAR_STRING fix.
9355 * charset.c (Fencode_char): Check that character arg is actually
9356 a character. Pass an int to ENCODE_CHAR.
9357 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9358 wider than 'int', as a compile-time check to prevent future regressions
9361 * character.c (char_string): Remove unnecessary casts.
9363 Make sure a 64-bit char is never passed to CHAR_STRING.
9364 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9365 by silently ignoring the top 32 bits, allowing some values
9366 that were far too large to be valid characters.
9367 * character.h: Include <verify.h>.
9368 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9369 arguments are no wider than unsigned, as a compile-time check
9370 to prevent future regressions in this area.
9372 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
9373 (Fsubst_char_in_region):
9375 * xdisp.c (decode_mode_spec_coding):
9376 Adjust to CHAR_STRING's new requirement.
9377 * editfns.c (Finsert_char, Fsubst_char_in_region):
9378 * fns.c (concat): Check that character args are actually
9379 characters. Without this test, these functions did the wrong
9380 thing with wildly out-of-range values on 64-bit hosts.
9382 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9383 These casts should not be needed on 32-bit hosts, either.
9384 * keyboard.c (read_char):
9385 * lread.c (Fload): Remove casts to unsigned.
9387 * lisp.h (UNSIGNED_CMP): New macro.
9388 This fixes comparison bugs on 64-bit hosts.
9389 (ASCII_CHAR_P): Use it.
9390 * casefiddle.c (casify_object):
9391 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
9392 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9393 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9394 * dispextern.h (FACE_FROM_ID):
9395 * keyboard.c (read_char): Use UNSIGNED_CMP.
9397 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9398 not to EMACS_INT, to avoid GCC warning.
9400 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9402 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9403 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9404 isn't needed on 32-bit machines.
9406 * buffer.c (Fgenerate_new_buffer_name):
9407 Use EMACS_INT for count, not int.
9408 (advance_to_char_boundary): Return EMACS_INT, not int.
9410 * data.c (Qcompiled_function): Now static.
9412 * window.c (window_body_lines): Now static.
9414 * image.c (gif_load): Rename local to avoid shadowing.
9416 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9417 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9418 * alloc.c (make_save_value): Integer argument is now of type
9420 (mark_object): Use ptrdiff_t, not int.
9421 * lisp.h (pD): New macro.
9422 * print.c (print_object): Use it.
9424 * alloc.c: Use EMACS_INT, not int, to count objects.
9425 (total_conses, total_markers, total_symbols, total_vector_size)
9426 (total_free_conses, total_free_markers, total_free_symbols)
9427 (total_free_floats, total_floats, total_free_intervals)
9428 (total_intervals, total_strings, total_free_strings):
9429 Now EMACS_INT, not int. All uses changed.
9430 (Fgarbage_collect): Compute overall total using a double, so that
9431 integer overflow is less likely to be a problem. Check for overflow
9432 when converting back to an integer.
9433 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9434 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9435 These were 'int' variables that could overflow on 64-bit hosts;
9436 they were never used, so remove them instead of repairing them.
9437 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
9438 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9439 Previously, this ceilinged at INT_MAX, but that doesn't work on
9441 (allocate_pseudovector): Don't use EMACS_INT when int would do.
9443 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
9444 (allocate_vectorlike): Check for ptrdiff_t overflow.
9445 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9446 when a (possibly-narrower) signed value would do just as well.
9447 We prefer using signed arithmetic, to avoid comparison confusion.
9449 * alloc.c: Catch some string size overflows that we were missing.
9450 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9451 for convenience in STRING_BYTES_MAX.
9452 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9453 The definition here is exact; the one in lisp.h was approximate.
9454 (allocate_string_data): Check for string overflow. This catches
9455 some instances we weren't catching before. Also, it catches
9456 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9457 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9458 and ptrdiff_t and EMACS_INT are both 64 bits.
9460 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9461 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
9462 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
9464 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9466 * alloc.c (Fmake_string): Check for out-of-range init.
9468 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9470 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9472 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9474 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9475 xg_get_default_scrollbar_width.
9477 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9478 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9479 (style_changed_cb): Call update_theme_scrollbar_width and call
9480 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9481 all frames (Bug#8505).
9482 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9483 Call gtk_window_set_resizable if HAVE_GTK3.
9484 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9485 and height if HAVE_GTK3 (Bug#8505).
9486 (scroll_bar_width_for_theme): New variable.
9487 (update_theme_scrollbar_width): New function.
9488 (xg_get_default_scrollbar_width): Move code to
9489 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9490 (xg_initialize): Call update_theme_scrollbar_width.
9492 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9494 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9496 2011-06-12 Martin Rudalics <rudalics@gmx.at>
9498 * frame.c (make_frame): Call other_buffer_safely instead of
9501 * window.c (temp_output_buffer_show): Call display_buffer with
9502 second argument Vtemp_buffer_show_specifiers and reset latter
9503 immediately after the call.
9504 (Vtemp_buffer_show_specifiers): New variable.
9505 (auto_window_vscroll_p, next_screen_context_lines)
9506 (Vscroll_preserve_screen_position): Remove leading asterisks from
9509 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
9511 Fix minor problems found by GCC 4.6.0 static checking.
9512 * buffer.c (Qclone_number): Remove for now, as it's unused.
9513 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9514 (record_buffer): Remove unused local.
9515 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9516 (set_frame_buffer_list): Remove; unused.
9517 * frame.h (other_visible_frames): Remove decl.
9518 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9519 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9520 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9522 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9523 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9524 Define only if HAVE_GPM.
9525 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9526 (update_hints_inhibit): Remove; never set. All uses removed.
9527 * widgetprv.h (emacsFrameClassRec): Remove decl.
9528 * window.c (delete_deletable_window): Now returns void, since it
9529 wasn't returning anything.
9530 (compare_window_configurations): Remove unused locals.
9531 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9532 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
9533 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9534 the same widths as pointers. This follows up on the 2011-05-06 patch.
9535 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9536 * xterm.h: Likewise.
9537 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9539 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
9541 * makefile.w32-in: Update dependencies.
9542 (LISP_H): Add lib/intprops.h.
9544 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9546 * image.c (gif_load): Add animation frame delay to the metadata.
9547 (syms_of_image): Use DEFSYM. New symbol `delay'.
9549 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9551 * window.c (delete_deletable_window): Re-add.
9552 (Fset_window_configuration): Rewrite to handle dead buffers and
9553 consequently deletable windows.
9554 (window_tree, Fwindow_tree): Remove. Supply functionality in
9556 (compare_window_configurations): Simplify code.
9558 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9560 * image.c (imagemagick_load_image): Fix type mismatch.
9561 (Fimagemagick_types): Likewise.
9563 * window.h (replace_buffer_in_windows): Declare.
9565 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9567 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9568 Qclone_number. Remove external declaration of Qdelete_window.
9569 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9571 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9572 Run Qbuffer_list_update_hook if allowed.
9573 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9574 buffer list implementation.
9575 (other_buffer_safely): New function.
9576 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9577 calls to replace_buffer_in_windows and
9578 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9580 (record_buffer): Inhibit quitting and rewrite using quittable
9581 functions. Run Qbuffer_list_update_hook if allowed.
9582 (Frecord_buffer, Funrecord_buffer): New functions.
9583 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9584 Move switch-to-buffer to window.el.
9585 (bury-buffer): Move to window.el.
9586 (Vbuffer_list_update_hook): New variable.
9588 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9591 * window.h (resize_frame_windows): Move up in code.
9592 (Fwindow_frame): Remove EXFUN.
9593 (replace_buffer_in_all_windows): Remove prototype.
9594 (replace_buffer_in_windows_safely): Add prototype.
9596 * window.c: Declare Qdelete_window static again. Move down
9597 declaration of select_count.
9598 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9599 (Fother_window): Move to window.el.
9600 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9601 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9602 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9604 (replace_buffer_in_windows): Implement by calling
9605 Qreplace_buffer_in_windows.
9606 (replace_buffer_in_all_windows): Remove with some functionality
9607 moved into replace_buffer_in_windows_safely.
9608 (replace_buffer_in_windows_safely): New function.
9609 (select_window_norecord, select_frame_norecord): Move in front
9610 of run_window_configuration_change_hook. Remove now obsolete
9612 (Fset_window_buffer): Rewrite doc-string.
9613 Call Qrecord_window_buffer.
9614 (keys_of_window): Move binding for other-window to window.el.
9616 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9618 * dispextern.h (struct image): Replace data member, whose int_val
9619 and ptr_val fields were not used by anything, with a single
9622 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9623 (gif_clear_image, gif_load, imagemagick_load_image)
9624 (gs_clear_image, gs_load): Callers changed.
9626 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9628 * buffer.h: Include <time.h>, for time_t.
9629 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9631 Fix minor problems found by static checking.
9633 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9635 Make identifiers static if they are not used in other modules.
9636 * data.c (Qcompiled_function, Qframe, Qvector):
9637 * image.c (QimageMagick, Qsvg):
9638 * minibuf.c (Qmetadata):
9639 * window.c (resize_window_check, resize_root_window): Now static.
9640 * window.h (resize_window_check, resize_root_window): Remove decls.
9642 * window.c (window_deletion_count, delete_deletable_window):
9644 (window_body_lines): Now static.
9645 (Fdelete_other_windows_internal): Mark vars as initialized.
9646 Make sure 'resize_failed' is initialized.
9647 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9648 (resize_window_apply): Remove unused local.
9649 * window.h (delete_deletable_window): Remove decl.
9651 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
9652 (imagemagick_load_image): Fix pointer signedness problem by changing
9653 last arg from unsigned char * to char *. All uses changed.
9654 Also, fix a local for similar reasons.
9655 Remove unused locals. Remove locals to avoid shadowing.
9656 (fn_rsvg_handle_free): Remove; unused.
9657 (svg_load, svg_load_image): Fix pointer signedness problem.
9658 (imagemagick_load_image): Don't use garbage pointer image_wand.
9660 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9662 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
9664 * image.c (gif_load): Fix omitted cast error introduced by
9667 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9669 * window.h (resize_proportionally, orig_total_lines)
9670 (orig_top_line): Remove from window structure.
9671 (set_window_height, set_window_width, change_window_heights)
9672 (Fdelete_window): Remove prototypes.
9673 (resize_frame_windows): Remove duplicate declaration.
9675 2011-06-10 Eli Zaretskii <eliz@gnu.org>
9677 * window.h (resize_frame_windows, resize_window_check)
9678 (delete_deletable_window, resize_root_window)
9679 (resize_frame_windows): Declare prototypes.
9681 * window.c (resize_window_apply): Make definition be "static" to
9682 match the prototype.
9684 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9686 * window.c: Remove declarations of Qwindow_size_fixed,
9687 window_min_size_1, window_min_size_2, window_min_size,
9688 size_window, window_fixed_size_p, enlarge_window, delete_window.
9689 Remove static from declaration of Qdelete_window, it's
9690 temporarily needed by Fbury_buffer.
9691 (replace_window): Don't assign orig_top_line and
9693 (Fdelete_window, delete_window): Remove. Window deletion is
9694 handled by window.el.
9695 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9696 Replace Fdelete_window calls with calls to Qdelete_window.
9697 (Fdelete_other_windows): Remove. Deleting other windows is
9698 handled by window.el.
9699 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9700 handled in window.el.
9701 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9702 Window minimum sizes are handled in window.el.
9703 (shrink_windows, size_window, set_window_height)
9704 (set_window_width, change_window_heights, window_height)
9705 (window_width, CURBEG, CURSIZE, enlarge_window)
9706 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9707 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9708 handled in window.el.
9709 (make_dummy_parent): Rename to make_parent_window and give it a
9710 second argument horflag.
9711 (make_window): Don't set resize_proportionally any more.
9712 (Fsplit_window): Remove. Windows are split in window.el.
9713 (save_restore_action, save_restore_orig_size)
9714 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9715 Resize mini windows in window.el.
9716 (grow_mini_window, shrink_mini_window): Implement by calling
9717 Qresize_root_window_vertically, resize_window_check and
9718 resize_window_apply.
9719 (saved_window, Fset_window_configuration, save_window_save):
9720 Do not handle orig_top_line, orig_total_lines, and
9721 resize_proportionally.
9722 (window_min_height, window_min_width): Move to window.el.
9723 (keys_of_window): Move bindings for delete-other-windows,
9724 split-window, delete-window and enlarge-window to window.el.
9726 * buffer.c: Temporarily extern Qdelete_window.
9727 (Fbury_buffer): Temporarily call Qdelete_window instead of
9728 Fdelete_window (Fbury_buffer will move to window.el soon).
9730 * frame.c (set_menu_bar_lines_1): Remove code handling
9731 orig_top_line and orig_total_lines.
9733 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9734 set_window_height but set heights directly.
9735 (change_frame_size_1): Use resize_frame_windows.
9737 * xdisp.c (init_xdisp): Don't use set_window_height but set
9740 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9741 Use resize_frame_windows instead of change_window_heights and run
9742 run_window_configuration_change_hook.
9744 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9745 instead of change_window_heights and run
9746 run_window_configuration_change_hook.
9748 2011-06-09 Martin Rudalics <rudalics@gmx.at>
9750 * window.c (replace_window): Rename second argument REPLACEMENT to
9751 NEW. New third argument SETFLAG. Rewrite.
9752 (delete_window, make_dummy_parent): Call replace_window with
9754 (window_list_1): Move down in code.
9755 (run_window_configuration_change_hook): Move set_buffer part
9756 before select_frame_norecord part in order to unwind correctly.
9757 Rename count1 to count.
9758 (recombine_windows, delete_deletable_window, resize_root_window)
9759 (Fdelete_other_windows_internal)
9760 (Frun_window_configuration_change_hook, make_parent_window)
9761 (resize_window_check, resize_window_apply, Fresize_window_apply)
9762 (resize_frame_windows, Fsplit_window_internal)
9763 (Fdelete_window_internal, Fresize_mini_window_internal):
9765 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9767 2011-06-08 Martin Rudalics <rudalics@gmx.at>
9769 * window.h (window): Add some new members to window structure -
9770 normal_lines, normal_cols, new_total, new_normal, clone_number,
9771 splits, nest, prev_buffers, next_buffers.
9772 (WINDOW_TOTAL_SIZE): Move here from window.c.
9773 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
9775 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9777 (make_dummy_parent): Set new members of windows structure.
9778 (make_window): Move down in code. Handle new members of window
9780 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9781 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9782 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9783 (Fset_window_prev_buffers, Fwindow_next_buffers)
9784 (Fset_window_next_buffers, Fset_window_clone_number):
9786 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9787 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9789 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9790 Argument WINDOW can be now internal window too.
9791 (Fwindow_use_time): Move up in code.
9792 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9794 (Fset_window_configuration, saved_window)
9795 (Fcurrent_window_configuration, save_window_save): Handle new
9796 members of window structure.
9797 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9798 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9799 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9800 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9801 Qget_mru_window, Qresize_root_window,
9802 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9803 Qauto_buffer_name; staticpro them.
9805 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9807 * window.c (Fwindow_total_size, Fwindow_left_column)
9808 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9809 (Fwindow_list_1): New functions.
9810 (window_box_text_cols): Replace with window_body_cols.
9811 (Fwindow_width, Fscroll_left, Fscroll_right):
9812 Use window_body_cols instead of window_box_text_cols.
9813 (delete_window, Fset_window_configuration):
9814 Call delete_all_subwindows with window as argument.
9815 (delete_all_subwindows): Take a window as argument and not a
9817 (window_loop): Remove handling of GET_LRU_WINDOW and
9819 (Fget_lru_window, Fget_largest_window): Move to window.el.
9821 * window.h: Extern window_body_cols instead of
9822 window_box_text_cols. delete_all_subwindows now takes a
9823 Lisp_Object as argument.
9825 * indent.c (compute_motion, Fcompute_motion):
9826 Use window_body_cols instead of window_box_text_cols.
9828 * frame.c (delete_frame): Call delete_all_subwindows with root
9831 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9833 * fns.c (Fputhash): Document return value.
9835 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9837 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9839 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9841 Cons<->int and similar integer overflow fixes (Bug#8794).
9843 Check for overflow when converting integer to cons and back.
9844 * charset.c (Fdefine_charset_internal, Fdecode_char):
9845 Use cons_to_unsigned to catch overflow.
9846 (Fencode_char): Use INTEGER_TO_CONS.
9847 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9848 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9849 * data.c (long_to_cons, cons_to_long): Remove.
9850 (cons_to_unsigned, cons_to_signed): New functions.
9851 These signal an error for invalid or out-of-range values.
9852 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9853 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9854 * font.c (Ffont_variation_glyphs):
9855 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9856 * lisp.h: Include <intprops.h>.
9857 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9858 (cons_to_signed, cons_to_unsigned): New decls.
9859 (long_to_cons, cons_to_long): Remove decls.
9860 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9861 (Fprimitive_undo): Use CONS_TO_INTEGER.
9862 * xfns.c (Fx_window_property): Likewise.
9863 * xselect.c: Include <limits.h>.
9864 (x_own_selection, selection_data_to_lisp_data):
9865 Use INTEGER_TO_CONS.
9866 (x_handle_selection_request, x_handle_selection_clear)
9867 (x_get_foreign_selection, Fx_disown_selection_internal)
9868 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9869 (lisp_data_to_selection_data): Use cons_to_unsigned.
9870 (x_fill_property_data): Use cons_to_signed.
9871 Report values out of range.
9873 Check for buffer and string overflow more precisely.
9874 * buffer.h (BUF_BYTES_MAX): New macro.
9875 * lisp.h (STRING_BYTES_MAX): New macro.
9876 * alloc.c (Fmake_string):
9877 * character.c (string_escape_byte8):
9878 * coding.c (coding_alloc_by_realloc):
9879 * doprnt.c (doprnt):
9880 * editfns.c (Fformat):
9882 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9883 since they may not be the same number.
9884 * editfns.c (Finsert_char):
9885 * fileio.c (Finsert_file_contents):
9886 Likewise for BUF_BYTES_MAX.
9888 * image.c: Use ptrdiff_t, not int, for sizes.
9889 (slurp_file): Switch from int to ptrdiff_t.
9891 (slurp_file): Check that file size fits in both size_t (for
9892 malloc) and ptrdiff_t (for sanity and safety).
9894 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9895 if b->modtime has its maximal value.
9897 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9899 Don't assume time_t can fit into int.
9900 * buffer.h (struct buffer.modtime): Now time_t, not int.
9901 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9902 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9904 Minor fixes for signed vs unsigned integers.
9905 * character.h (MAYBE_UNIFY_CHAR):
9906 * charset.c (maybe_unify_char):
9907 * keyboard.c (read_char, reorder_modifiers):
9908 XINT -> XFASTINT, since the integer must be nonnegative.
9909 * ftfont.c (ftfont_spec_pattern):
9910 * keymap.c (access_keymap, silly_event_symbol_error):
9911 XUINT -> XFASTINT, since the integer must be nonnegative.
9912 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9913 since it makes no difference and we prefer signed.
9914 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9915 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9918 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9920 * window.h (Fwindow_frame): Declare.
9922 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9924 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9925 (SPARE_MEMORY): Always define.
9926 (LARGE_REQUEST): Remove.
9927 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9929 2011-06-06 Martin Rudalics <rudalics@gmx.at>
9931 * lisp.h: Move EXFUNS for Fframe_root_window,
9932 Fframe_first_window and Fset_frame_selected_window to window.h.
9934 * window.h: Move EXFUNS for Fframe_root_window,
9935 Fframe_first_window and Fset_frame_selected_window here from
9938 * frame.c (Fwindow_frame, Fframe_first_window)
9939 (Fframe_root_window, Fframe_selected_window)
9940 (Fset_frame_selected_window): Move to window.c.
9941 (Factive_minibuffer_window): Move to minibuf.c.
9942 (Fother_visible_frames_p): New function.
9944 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9946 * window.c (decode_window, decode_any_window): Move up in code.
9947 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9948 (inhibit_frame_unsplittable): Remove unused variable.
9949 (Fwindow_buffer): Move up and rewrite doc-string.
9950 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9951 (Fwindow_prev): New functions.
9952 (Fwindow_frame): Move here from frame.c. Accept any window as
9954 (Fframe_root_window, Fframe_first_window)
9955 (Fframe_selected_window): Move here from frame.c. Accept frame
9956 or arbitrary window as argument. Update doc-strings.
9957 (Fminibuffer_window): Move up in code.
9958 (Fwindow_minibuffer_p): Move up in code and simplify.
9959 (Fset_frame_selected_window): Move here from frame.c.
9961 (Fselected_window, select_window, Fselect_window): Move up in
9962 code. Minor doc-string fixes.
9964 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9966 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9967 Do not assume that spare memory exists; that assumption is valid
9968 only if SYSTEM_MALLOC.
9969 (LARGE_REQUEST): New macro, so that the issue of large requests
9970 is separated from the issue of spare memory.
9972 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9974 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9977 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9979 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9982 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9984 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9986 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9988 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9989 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9991 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
9993 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9995 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
9997 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9998 (x_clipboard_manager_save): Add return value.
9999 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10000 New error handlers.
10001 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10002 Obey Vx_select_enable_clipboard_manager. Catch errors in
10003 x_clipboard_manager_save (Bug#8779).
10004 (Vx_select_enable_clipboard_manager): New variable.
10005 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
10007 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
10009 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10011 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10013 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10014 in the current matrix if keep_current_p is non-zero.
10016 2011-06-04 Eli Zaretskii <eliz@gnu.org>
10018 * bidi.c (bidi_level_of_next_char): Fix last change.
10020 2011-06-03 Eli Zaretskii <eliz@gnu.org>
10022 Support bidi reordering of text covered by display properties.
10024 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10025 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10026 (bidi_cache_search, bidi_cache_iterator_state)
10027 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
10028 (bidi_level_of_next_char, bidi_move_to_visually_next):
10029 Support character positions inside a run of characters covered by a
10031 (bidi_paragraph_init, bidi_resolve_explicit_1)
10032 (bidi_level_of_next_char): Call bidi_fetch_char and
10033 bidi_fetch_char_advance instead of FETCH_CHAR and
10034 FETCH_CHAR_ADVANCE.
10035 (bidi_init_it): Initialize new members.
10036 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10038 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10039 instead of using explicit *_CHAR codes.
10040 (bidi_resolve_explicit, bidi_resolve_weak):
10041 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
10042 bidirectional text is supported only in multibyte buffers.
10043 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10044 it to initialize the frame_window_p member of struct bidi_it.
10045 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10046 (bidi_resolve_explicit, bidi_resolve_weak)
10047 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10048 bidi_it->nchars is non-positive.
10049 (bidi_level_of_next_char): Don't try to lookup the cache for the
10050 next/previous character if nothing is cached there yet, or if we
10051 were just reseat()'ed to a new position.
10053 * xdisp.c (set_cursor_from_row): Set start and stop points
10054 according to the row's direction when priming the loop that looks
10055 for the glyph on which to display cursor.
10056 (single_display_spec_intangible_p): Function deleted.
10057 (display_prop_intangible_p): Reimplement to call
10058 handle_display_spec instead of single_display_spec_intangible_p.
10059 Accept 3 additional arguments needed by handle_display_spec.
10060 This fixes incorrect cursor motion across display property with complex
10061 values: lists, `(when COND...)' forms, etc.
10062 (single_display_spec_string_p): Support property values that are
10063 lists with the argument STRING its top-level element.
10064 (display_prop_string_p): Fix the condition for processing a
10065 property that is a list to be consistent with handle_display_spec.
10066 (handle_display_spec): New function, refactored from the
10067 last portion of handle_display_prop.
10068 (compute_display_string_pos): Accept additional argument
10069 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10070 value of a `display' property is a "replacing spec".
10071 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10072 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10073 the display property, but just return a value indicating whether
10074 the display property will replace the characters it covers.
10075 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10076 frame_window_p members of struct bidi_it.
10077 (compute_display_string_pos, compute_display_string_end):
10079 (push_it): Accept second argument POSITION, where pop_it should
10080 jump to continue iteration.
10081 (reseat_1): Initialize bidi_it.disp_pos.
10083 * keyboard.c (adjust_point_for_property): Adjust the call to
10084 display_prop_intangible_p to its new signature.
10086 * dispextern.h (struct bidi_it): New member frame_window_p.
10087 (bidi_init_it): Update prototypes.
10088 (display_prop_intangible_p): Update prototype.
10089 (compute_display_string_pos, compute_display_string_end):
10090 Declare prototypes.
10091 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10094 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
10096 Malloc failure behavior now depends on size of allocation.
10097 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10098 * lisp.h: Change signatures accordingly.
10099 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10100 All callers changed. (Bug#8762)
10102 * gnutls.c: Use Emacs's memory allocators.
10103 Without this change, the gnutls library would invoke malloc etc.
10104 directly, which causes problems on non-SYNC_INPUT hosts, and which
10105 runs afoul of improving memory_full behavior. (Bug#8761)
10106 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10107 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10108 xfree instead of the default malloc, realloc, free.
10109 (Fgnutls_boot): No need to check for memory allocation failure,
10110 since xmalloc does that for us.
10112 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
10113 * category.c (hash_get_category_set):
10114 * ccl.c (ccl_driver):
10115 * charset.c (Fdefine_charset_internal):
10116 * charset.h (struct charset.hash_index):
10117 * composite.c (get_composition_id, gstring_lookup_cache)
10118 (composition_gstring_put_cache):
10119 * composite.h (struct composition.hash_index):
10120 * dispextern.h (struct image.hash):
10121 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10122 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10123 (hashfn_equal, hashfn_user_defined, make_hash_table)
10124 (maybe_resize_hash_table, hash_lookup, hash_put)
10125 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10126 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10127 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10128 * image.c (make_image, search_image_cache, lookup_image)
10129 (xpm_put_color_table_h):
10130 * lisp.h (struct Lisp_Hash_Table):
10131 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
10132 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
10133 for hashes and hash indexes, instead of 'unsigned' and 'int'.
10134 * alloc.c (allocate_vectorlike):
10135 Check for overflow in vector size calculations.
10136 * ccl.c (ccl_driver):
10137 Check for overflow when converting EMACS_INT to int.
10138 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10139 need to be updated by these changes.
10140 * fns.c (make_hash_table, maybe_resize_hash_table):
10141 Check for integer overflow with large hash tables.
10142 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10143 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10144 (SXHASH_REDUCE): New macro.
10145 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10146 Use it instead of discarding useful hash info with large hash values.
10147 (sxhash_float): New function.
10148 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10149 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
10150 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10151 Rewrite to use FIXNUM_BITS, as this simplifies things.
10152 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10153 Adjust signatures to match updated version of code.
10154 (consing_since_gc): Now EMACS_INT, since a single hash table can
10155 use more than INT_MAX bytes.
10157 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10159 Make it possible to build with GCC-4.6+ -O2 -flto.
10161 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10163 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10165 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10166 Call minibuffer-inactive-mode.
10168 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
10170 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10171 Update dependencies.
10173 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10175 * data.c (init_data): Remove code for UTS, this system is not
10178 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10180 Don't force ./temacs to start in terminal mode.
10182 * frame.c (make_initial_frame): Initialize faces in all cases, not
10183 only when CANNOT_DUMP is defined.
10184 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10186 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10188 * dispnew.c (add_window_display_history): Use const for the string
10189 pointer. Remove declaration, not needed.
10191 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10193 Use 'inline', not 'INLINE'.
10194 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
10195 * alloc.c, fontset.c (INLINE): Remove.
10196 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10197 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10198 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10199 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10200 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10202 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10204 Make it possible to run ./temacs.
10206 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10207 syms_of_callproc does the same thing. Remove test for
10208 "initialized", do it in the caller.
10209 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10211 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10213 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10214 (read_minibuf): Use get_minibuffer.
10215 (syms_of_minibuf): Use DEFSYM.
10216 (Qmetadata): New var.
10217 * data.c (Qbuffer): Don't make it static.
10218 (syms_of_data): Use DEFSYM.
10220 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10222 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10223 (CCL_CODE_MIN): New macro.
10225 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10227 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10229 * eval.c (Qdebug): Now static.
10230 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10231 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10232 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10234 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10236 * image.c: Various fixes to ImageMagick code comments.
10237 (Fimagemagick_types): Doc fix.
10239 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10241 Minor fixes prompted by GCC 4.6.0 warnings.
10243 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10245 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10246 (x_clipboard_manager_save_all): Move extern decl to ...
10247 * xterm.h: ... here, so that it can be checked for consistency.
10249 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10251 * xselect.c (x_clipboard_manager_save_frame)
10252 (x_clipboard_manager_save_all): New functions.
10253 (Fx_clipboard_manager_save): Lisp function deleted.
10255 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10256 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10258 * xterm.h: Update prototype.
10260 2011-05-28 William Xu <william.xwl@gmail.com>
10262 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10263 exiting (Bug#8239).
10265 2011-05-28 Jim Meyering <meyering@redhat.com>
10267 Avoid a sign-extension bug in crypto_hash_function.
10268 * fns.c (to_uchar): Define.
10269 (crypto_hash_function): Use it to convert some newly-signed
10270 variables to unsigned, to avoid sign-extension bugs. For example,
10271 without this change, (md5 "truc") would evaluate to
10272 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10273 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
10274 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
10276 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10278 Integer overflow fixes.
10280 * dbusbind.c: Serial number integer overflow fixes.
10281 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
10282 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10283 to hold a serial number that is too large for a fixnum.
10284 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10285 Check for serial numbers out of range. Decode any serial number
10286 that was so large that it became a float. (Bug#8722)
10288 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10289 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10290 Use XFASTINT rather than XUINT when numbers are nonnegative.
10291 (xd_append_arg, Fdbus_method_return_internal):
10292 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10293 arguments, check that Lisp number is nonnegative, rather than
10294 silently wrapping negative numbers around. (Bug#8722)
10295 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
10298 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10300 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10302 ccl: Add integer overflow checks.
10303 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10304 (IN_INT_RANGE): New macros.
10305 (ccl_driver): Use them to check for integer overflow when
10306 decoding a CCL program. Many of the new checks are whether XINT (x)
10307 fits in int; it doesn't always, on 64-bit hosts. The new version
10308 doesn't catch all possible integer overflows, but it's an
10309 improvement. (Bug#8719)
10311 * alloc.c (make_event_array): Use XINT, not XUINT.
10312 There's no need for unsigned here.
10314 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10315 This follows up to the 2011-05-06 change that substituted uintptr_t
10316 for EMACS_INT. This case wasn't caught back then.
10318 Rework Fformat to avoid integer overflow issues.
10319 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10320 now (part of C89). Include <verify.h>.
10321 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10322 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10323 (Fformat): Avoid the prepass trying to compute sizes; it was only
10324 approximate and thus did not catch overflow reliably. Instead, walk
10325 through the format just once, formatting and computing sizes as we go,
10326 checking for integer overflow at every step, and allocating a larger
10327 buffer as needed. Keep track separately whether the format is
10328 multibyte. Keep only the most-recently calculated precision, rather
10329 than them all. Record whether each argument has been converted to
10330 string. Use EMACS_INT, not int, for byte and char and arg counts.
10331 Support field widths and precisions larger than INT_MAX. Avoid
10332 sprintf's undefined behavior with conversion specifications such as %#d
10333 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10334 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10335 formatting out-of-range floating point numbers with int
10336 formats. (Bug#8668)
10338 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10340 * data.c: Avoid integer truncation in expressions involving floats.
10341 * data.c: Include <intprops.h>.
10342 (arith_driver): When there's an integer overflow in an expression
10343 involving floating point, convert the integers to floating point
10344 so that the resulting value does not suffer from catastrophic
10345 integer truncation. For example, on a 64-bit host (* 4
10346 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10347 Do not rely on undefined behavior after integer overflow.
10349 merge count_size_as_multibyte, parse_str_to_multibyte
10350 * character.c, character.h (count_size_as_multibyte):
10351 Rename from parse_str_to_multibyte; all uses changed.
10352 Check for integer overflow.
10353 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10354 since it's now a duplicate of the other. This is more of
10355 a character than a buffer op, so better that it's in character.c.
10356 * fns.c, print.c: Adjust to above changes.
10358 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10360 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10362 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10364 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10365 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10366 (x_clipboard_manager_save): Now static.
10367 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10369 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10370 (crypto_hash_function): Now static.
10371 Fix pointer signedness problems. Avoid unnecessary initializations.
10373 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
10375 * termhooks.h (Vselection_alist): Make it terminal-local.
10377 * terminal.c (create_terminal): Initialize it.
10379 * xselect.c: Support for clipboard managers.
10380 (Vselection_alist): Move to termhooks.h as terminal-local var.
10381 (LOCAL_SELECTION): New macro.
10382 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10383 (symbol_to_x_atom): Remove gratuitous arg.
10384 (x_handle_selection_request, lisp_data_to_selection_data)
10385 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
10386 (x_own_selection, x_get_local_selection, x_convert_selection):
10387 New arg, specifying work frame. Use terminal-local Vselection_alist.
10388 (some_frame_on_display): Delete unused function.
10389 (Fx_own_selection_internal, Fx_get_selection_internal)
10390 (Fx_disown_selection_internal, Fx_selection_owner_p)
10391 (Fx_selection_exists_p): New optional frame arg.
10392 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10393 (x_handle_selection_clear): Don't treat other terminals with the
10394 same keyboard specially. Use the terminal-local Vselection_alist.
10395 (x_clear_frame_selections): Use Frun_hook_with_args.
10397 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10399 * xterm.h: Add support for those atoms.
10401 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
10403 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10404 (converted_selections, conversion_fail_tag): New global variables.
10405 (x_selection_request_lisp_error): Free the above.
10406 (x_get_local_selection): Remove unnecessary code.
10407 (x_reply_selection_request): Args changed; handle arbitrary array
10408 of converted selections stored in converted_selections.
10409 Separate the XChangeProperty and SelectionNotify steps.
10410 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10411 (x_convert_selection): New function.
10412 (x_handle_selection_event): Simplify.
10413 (x_get_foreign_selection): Don't ignore incoming requests while
10414 waiting for an answer; this will fail when we implement
10415 SAVE_TARGETS, and seems unnecessary anyway.
10416 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10417 (Vx_sent_selection_functions): Doc fix.
10419 2011-05-26 Leo Liu <sdl.web@gmail.com>
10421 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10423 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10425 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10427 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10428 for fringe update if it has periodic bitmap.
10429 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
10430 and fringe_bitmap_periodic_p.
10432 * fringe.c (get_fringe_bitmap_data): New function.
10433 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10434 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10435 row. Mark glyph row for fringe update if periodicity changed.
10437 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10438 for fringe update unless it has periodic bitmap.
10440 2011-05-25 Kenichi Handa <handa@m17n.org>
10442 * xdisp.c (get_next_display_element): Set correct it->face_id for
10443 a static composition.
10445 2011-05-24 Leo Liu <sdl.web@gmail.com>
10448 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10450 * fns.c (crypto_hash_function, Fsha1): New function.
10451 (Fmd5): Use crypto_hash_function.
10452 (syms_of_fns): Add Ssha1.
10454 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10456 * gnutls.c: Remove unused macros.
10457 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10458 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10459 Remove macros that are defined and never used.
10460 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10462 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10464 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10465 (Fx_get_selection_internal): Minor cleanup.
10466 (Fx_own_selection_internal): Rename arguments for consistency with
10469 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10471 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10473 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10475 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10477 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10479 * dispnew.c (scrolling_window): Don't exclude the case that the
10480 last enabled row in the desired matrix touches the bottom boundary.
10482 2011-05-21 Glenn Morris <rgm@gnu.org>
10484 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
10485 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10486 and add some more files.
10488 2011-05-20 Eli Zaretskii <eliz@gnu.org>
10490 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10491 report_file_error introduced by the change from 2011-05-07.
10493 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10495 * systime.h (Time): Define only if emacs is defined.
10496 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10497 where the include path doesn't have X11/X.h by default. See
10498 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10500 2011-05-20 Kenichi Handa <handa@m17n.org>
10502 * composite.c (find_automatic_composition): Fix previous change.
10504 2011-05-20 Glenn Morris <rgm@gnu.org>
10506 * lisp.mk: New file, split from Makefile.in.
10507 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10508 (shortlisp): Remove.
10509 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10511 2011-05-19 Glenn Morris <rgm@gnu.org>
10513 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10514 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10515 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10516 (lisp): Set the order to that of loadup.el.
10517 (shortlisp): Make it a copy of $lisp.
10518 (SOME_MACHINE_LISP): Remove.
10519 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10520 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10522 2011-05-18 Kenichi Handa <handa@m17n.org>
10524 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10525 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10526 (find_automatic_composition): Mostly rewrite for efficiency.
10528 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
10530 * makefile.w32-in: Update dependencies.
10532 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10534 * menu.c: Include limits.h (fixes the MS-Windows build broken by
10535 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
10537 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
10539 Fix some integer overflow issues, such as string length overflow.
10541 * insdel.c (count_size_as_multibyte): Check for string overflow.
10543 * character.c (lisp_string_width): Check for string overflow.
10544 Use EMACS_INT, not int, for string indexes and lengths; in
10545 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10546 the resulting string length overflows an EMACS_INT; instead,
10547 report a string overflow if no precision given. When checking for
10548 precision exhaustion, use a check that cannot possibly have
10549 integer overflow. (Bug#8675)
10550 * character.h (lisp_string_width): Adjust to new signature.
10552 * alloc.c (string_overflow): New function.
10553 (Fmake_string): Use it. This doesn't change behavior, but saves
10554 a few bytes and will simplify future changes.
10555 * character.c (string_escape_byte8): Likewise.
10556 * lisp.h (string_overflow): New decl.
10558 Fixups, following up to the user-interface timestamp change.
10559 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10560 for UI timestamps, instead of unsigned long.
10561 * msdos.c (mouse_get_pos): Likewise.
10562 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
10563 * w32gui.h (Time): Define by including "systime.h" rather than by
10564 declaring it ourselves. (Bug#8664)
10566 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10567 * image.c (clear_image_cache): Likewise.
10569 * term.c (term_mouse_position): Don't assume time_t wraparound.
10571 Be more systematic about user-interface timestamps.
10572 Before, the code sometimes used 'Time', sometimes 'unsigned long',
10573 and sometimes 'EMACS_UINT', to represent these timestamps.
10574 This change causes it to use 'Time' uniformly, as that's what X uses.
10575 This makes the code easier to follow, and makes it easier to catch
10576 integer overflow bugs such as Bug#8664.
10577 * frame.c (Fmouse_position, Fmouse_pixel_position):
10578 Use Time, not unsigned long, for user-interface timestamps.
10579 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10580 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10581 * keyboard.h (last_event_timestamp): Likewise.
10582 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10583 * menu.h (xmenu_show): Likewise.
10584 * term.c (term_mouse_position): Likewise.
10585 * termhooks.h (struct input_event.timestamp): Likewise.
10586 (struct terminal.mouse_position_hook): Likewise.
10587 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10588 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10589 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10590 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10591 what it was before.
10592 * menu.h, termhooks.h: Include "systime.h", for Time.
10594 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10595 Don't assume that the difference between two unsigned long values
10596 can fit into an integer. At this point, we know button_down_time
10597 <= event->timestamp, so the difference must be nonnegative, so
10598 there's no need to cast the result if double-click-time is
10599 nonnegative, as it should be; check that it's nonnegative, just in
10600 case. This bug is triggered when events are more than 2**31 ms
10601 apart (about 25 days). (Bug#8664)
10603 * xselect.c (last_event_timestamp): Remove duplicate decl.
10604 (x_own_selection): Remove needless cast to unsigned long.
10606 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10607 that always fit in int. Use a sentinel instead of a counter, to
10608 avoid a temp and to allay GCC's concerns about possible int overflow.
10609 * frame.h (struct frame): Use int for menu_bar_items_used
10610 instead of EMACS_INT, since it always fits in int.
10612 * menu.c (grow_menu_items): Check for int overflow.
10614 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10616 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10617 Before, the code was not consistent. These values cannot exceed
10618 2**31 - 1 so there's no need to make them unsigned.
10619 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10620 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10621 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10623 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10625 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10626 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10627 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10628 presumably because the widths might not match.
10630 * window.c (size_window): Avoid needless test at loop start.
10632 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10634 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10636 2011-05-12 Drew Adams <drew.adams@oracle.com>
10638 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10640 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10642 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10643 `width' to `bar_area_x' and `bar_area_width', respectively.
10644 (x_scroll_run): Take account of fringe background extension.
10646 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10647 Rename local vars `left' and `width' to `bar_area_x' and
10648 `bar_area_width', respectively.
10649 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10650 background extension.
10652 2011-05-10 Jim Meyering <meyering@redhat.com>
10654 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10656 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
10658 * image.c (Finit_image_library): Return t for built-in image types,
10659 like pbm and xbm. (Bug#8640)
10661 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10663 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10665 2011-05-07 Eli Zaretskii <eliz@gnu.org>
10667 * w32console.c (Fset_screen_color): Doc fix.
10668 (Fget_screen_color): New function.
10669 (syms_of_ntterm): Defsubr it.
10671 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10672 unlink the temporary file if Fcall_process didn't create it in the
10674 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10675 child process will be redirected to a file specified with `:file'.
10676 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10677 cue to call_process_cleanup not to close that handle.
10679 2011-05-07 Ben Key <bkey76@gmail.com>
10681 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10682 one of two shell specific rules, either bootstrap-temacs-CMD or
10683 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10684 to the previous implementation of the bootstrap-temacs rule.
10685 The bootstrap-temacs-CMD rule is similar to the previous
10686 implementation of the bootstrap-temacs rule except that it
10687 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10690 These changes, along with some changes to nt/configure.bat,
10691 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10692 earlier fix to add support for --cflags and --ldflags options
10693 that include quotes so that it works whether make uses cmd or
10696 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
10698 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10699 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10701 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10702 a string. Handle both cases.
10703 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10704 (Fdbus_register_method): Use Qinvalid_function.
10706 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10708 * makefile.w32-in: Update dependencies.
10709 (LISP_H): Add inttypes.h and stdin.h.
10710 (PROCESS_H): Add unistd.h.
10712 2011-05-06 Eli Zaretskii <eliz@gnu.org>
10714 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10715 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10717 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
10719 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10721 * term.c (vfatal): Remove stray call to va_end.
10722 It's not needed and the C Standard doesn't allow it here anyway.
10724 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10725 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10727 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10730 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10732 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10734 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10736 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10738 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10740 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10741 * charset.c (Fdefine_charset_internal): Don't initialize
10742 charset.code_space[15]. The value was garbage, on hosts with
10743 32-bit int (Bug#8600).
10745 * lread.c (read_integer): Be more consistent with string-to-number.
10746 Use string_to_number to do the actual conversion; this avoids
10747 rounding errors and fixes some other screwups. Without this fix,
10748 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10749 (digit_to_number): Move earlier, for benefit of read_integer.
10750 Return -1 if the digit is out of range for the base, -2 if it is
10751 not a digit in any supported base. (Bug#8602)
10753 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10755 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10756 to match comment at start of function. This also removes a
10757 GCC warning about overflow in a 32+64-bit port.
10759 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10761 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10762 Reported by Stefan Monnier in
10763 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
10764 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10765 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
10767 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10768 (EMACS_UINTPTR): Likewise, with uintptr_t.
10770 * lisp.h: Prefer 64-bit EMACS_INT if available.
10771 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10772 on 32-bit hosts that have 64-bit int, so that they can access
10774 However, temporarily disable this change unless the temporary
10775 symbol WIDE_EMACS_INT is defined.
10777 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10779 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10780 This removes an assumption that EMACS_INT and long are the same
10781 width as pointers. The assumption is true for Emacs porting targets
10782 now, but we want to make other targets possible.
10783 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10784 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10785 In the rest of the code, change types of integers that hold casted
10786 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10787 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10788 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10789 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10790 No need to cast type when ORing.
10791 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10792 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10793 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10794 assume EMACS_INT is the same width as char *.
10795 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10796 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10797 Remove no-longer-needed casts.
10798 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10799 (xg_tool_bar_help_callback, xg_make_tool_item):
10800 Use EMACS_INTPTR to hold an integer
10801 that will be cast to void *; this can avoid a GCC warning
10802 if EMACS_INT is not the same width as void *.
10803 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10804 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10805 (current_message_1, set_message_1):
10806 Use a local to convert to proper width without a cast.
10807 * xmenu.c (dialog_selection_callback): Likewise.
10809 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10810 Also, don't assume VALBITS / RAND_BITS is less than 5,
10811 and don't rely on undefined behavior when shifting a 1 left into
10813 * lisp.h (get_random): Change signature to match.
10815 * lread.c (hash_string): Use size_t, not int, for hash computation.
10816 Normally we prefer signed values; but hashing is special, because
10817 it's better to use unsigned division on hash table sizes so that
10818 the remainder is nonnegative. Also, size_t is the natural width
10819 for hashing into memory. The previous code used 'int', which doesn't
10820 retain enough info to hash well into very large tables.
10821 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10823 * dbusbind.c: Don't possibly lose pointer info when converting.
10824 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10825 Use XPNTR rather than XHASH, so that the high-order bits of
10826 the pointer aren't lost when converting through void *.
10828 * eval.c (Fautoload): Don't double-shift a pointer.
10830 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10832 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10834 * gnutls.c (DEF_GNUTLS_FN):
10835 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10837 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10839 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10842 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10844 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10845 New version that can reserve upto 2GB of heap space.
10847 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10849 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10851 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10853 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10854 `gnutls_certificate_set_x509_key_file'.
10856 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10858 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10859 Update dependencies.
10861 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10863 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10864 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10865 Remove unused parameter `fildes'.
10866 * process.c (read_process_output, send_process): Don't pass it.
10868 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10870 Fix previous change: the library cache is defined in w32.c.
10871 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10872 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10874 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10876 Implement dynamic loading of GnuTLS on Windows.
10878 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10879 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10880 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10883 * gnutls.c (Qgnutls_dll): Define.
10884 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10885 (gnutls_*): Declare function pointers.
10886 (init_gnutls_functions): New function to initialize function pointers.
10887 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10888 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10889 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10890 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10891 (emacs_gnutls_write, emacs_gnutls_read)
10892 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10893 (Fgnutls_available_p): New function.
10894 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10895 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10896 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10898 * image.c: Include w32.h.
10899 (Vimage_type_cache): Delete.
10900 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10901 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10902 (w32_delayed_load): Move to w32.c.
10904 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10906 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10907 (w32_delayed_load): Move from image.c. When loading a library, record
10908 its filename in the :loaded-from property of the library id.
10909 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10910 Initialize and staticpro them.
10911 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10913 * process.c: Include lisp.h before w32.h, not after.
10914 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10915 instead of gnutls_record_check_pending.
10917 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10919 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10921 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10922 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10925 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10927 * xterm.c (x_set_frame_alpha): Do not set property on anything
10928 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10930 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10932 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10934 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10936 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10937 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10938 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10939 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10940 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10941 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10942 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10943 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10944 (Qgnutls_bootprop_callbacks_verify): Make static.
10946 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10948 * callproc.c: Indentation fixup.
10950 * sysdep.c (wait_for_termination_1): Make static.
10951 (wait_for_termination, interruptible_wait_for_termination):
10952 Move after wait_for_termination_1.
10954 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10956 * sysdep.c (interruptible_wait_for_termination): New function
10957 which is like wait_for_termination, but allows keyboard
10960 * callproc.c (Fcall_process): Add (:file "file") as an option for
10962 (Fcall_process_region): Ditto.
10964 2011-04-30 Eli Zaretskii <eliz@gnu.org>
10966 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10967 rather than `XVECTOR (FOO)->size'.
10969 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10970 inttypes.h, as a gnulib replacement is used if it not available in
10973 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10975 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10976 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10977 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10979 * coding.c (coding_alloc_by_realloc): Error out if destination
10980 will grow beyond MOST_POSITIVE_FIXNUM.
10981 (decode_coding_emacs_mule): Abort if there isn't enough place in
10982 charbuf for the composition carryover bytes. Reserve an extra
10983 space for up to 2 characters produced in a loop.
10984 (decode_coding_iso_2022): Abort if there isn't enough place in
10985 charbuf for the composition carryover bytes.
10987 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10989 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10990 aborting when %lld or %lll format is passed.
10991 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10992 %llo or %llx format is passed. (Bug#8545)
10994 * window.c (window_scroll_line_based): Use a marker instead of
10995 simple variables to record original value of point. (Bug#7952)
10997 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10998 produced by %s or %c overflows available buffer space. (Bug#8545)
11000 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11002 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
11003 (SIZE_MAX): Move defn after all includes, as they might #define it.
11005 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11007 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11009 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11011 * keyboard.c (Qdelayed_warnings_hook): Define.
11012 (command_loop_1): Run `delayed-warnings-hook'
11013 if Vdelayed_warnings_list is non-nil.
11014 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11015 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11017 2011-04-28 Eli Zaretskii <eliz@gnu.org>
11019 * doprnt.c (doprnt): Don't return value smaller than the buffer
11020 size if the message was truncated. (Bug#8545).
11022 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11024 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11025 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11027 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11029 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11031 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
11033 * makefile.w32-in: Update dependencies.
11035 2011-04-27 Eli Zaretskii <eliz@gnu.org>
11037 Improve `doprnt' and its usage. (Bug#8545)
11038 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11039 `format_end'. Remove support for %l as a conversion specifier.
11040 Don't use xrealloc. Improve diagnostics when the %l size modifier
11041 is used. Update the commentary.
11043 * eval.c (verror): Simplify calculation of size_t.
11045 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11048 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11050 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11053 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11055 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11056 This makes this file independent of the recent pseudovector change.
11058 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
11060 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11062 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
11063 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
11064 Remove unused local.
11065 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
11067 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
11068 GCC 4.6.0 optimizes based on type-based alias analysis.
11069 For example, if b is of type struct buffer * and v of type struct
11070 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11071 != &v->size, and therefore "v->size = 1; b->size = 2; return
11072 v->size;" must therefore return 1. This assumption is incorrect
11073 for Emacs, since it type-puns struct Lisp_Vector * with many other
11074 types. To fix this problem, this patch adds a new type struct
11075 vectorlike_header that documents the constraints on layout of vectors
11076 and pseudovectors, and helps optimizing compilers not get fooled
11077 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11078 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
11079 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11081 (XSETPVECTYPE): Rewrite in terms of new macro.
11082 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11083 This is a bit clearer, and further avoids the possibility of
11084 undesirable aliasing.
11085 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
11086 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
11087 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11088 since Lisp_Subr is a special case (no "next" field).
11089 (ASIZE): Now uses header.size rather than size.
11090 All previous uses of XVECTOR (foo)->size replaced to use this macro,
11091 to avoid the hassle of writing XVECTOR (foo)->header.size.
11092 (struct vectorlike_header): New type.
11093 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11094 object, to help avoid aliasing.
11095 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11096 (SUBRP): Likewise, since Lisp_Subr is a special case.
11097 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11098 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11099 (struct Lisp_Hash_Table): Combine first two members into a single
11100 struct vectorlike_header member. All uses of "size" and "next" members
11101 changed to be "header.size" and "header.next".
11102 * buffer.h (struct buffer): Likewise.
11103 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11104 * frame.h (struct frame): Likewise.
11105 * process.h (struct Lisp_Process): Likewise.
11106 * termhooks.h (struct terminal): Likewise.
11107 * window.c (struct save_window_data, struct saved_window): Likewise.
11108 * window.h (struct window): Likewise.
11109 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11110 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11111 * buffer.c (init_buffer_once): Likewise.
11112 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11114 * process.c (Fformat_network_address): Use local var for size,
11117 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11119 Make the Lisp reader and string-to-float more consistent (Bug#8525)
11120 * data.c (atof): Remove decl; no longer used or needed.
11121 (digit_to_number): Move to lread.c.
11122 (Fstring_to_number): Use new string_to_number function, to be
11123 consistent with how the Lisp reader treats infinities and NaNs.
11124 Do not assume that floating-point numbers represent EMACS_INT
11125 without losing information; this is not true on most 64-bit hosts.
11126 Avoid double-rounding errors, by insisting on integers when
11127 parsing non-base-10 numbers, as the documentation specifies.
11128 * lisp.h (string_to_number): New decl, replacing ...
11129 (isfloat_string): Remove.
11130 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
11131 (read1): Do not accept +. and -. as integers; this
11132 appears to have been a coding error. Similarly, do not accept
11133 strings like +-1e0 as floating point numbers. Do not report
11134 overflow for integer overflows unless the base is not 10 which
11135 means we have no simple and reliable way to continue.
11136 Break out the floating-point parsing into a new
11137 function string_to_number, so that Fstring_to_number parses
11138 floating point numbers consistently with the Lisp reader.
11139 (digit_to_number): Move here from data.c. Make it static inline.
11140 (E_CHAR, EXP_INT): Remove, replacing with ...
11141 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11142 (string_to_number): New function, replacing isfloat_string.
11143 This function checks for valid syntax and produces the resulting
11144 Lisp float number too. Rework it so that string-to-number
11145 no longer mishandles examples like "1.0e+". Use strtoumax,
11146 so that overflow for non-base-10 numbers is reported only when
11147 there's no portable and simple way to convert to floating point.
11149 * textprop.c (set_text_properties_1): Rewrite for clarity,
11150 and to avoid GCC warning about integer overflow.
11152 * intervals.h (struct interval): Use EMACS_INT for members
11153 where EMACS_UINT might cause problems. See
11154 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11155 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11156 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11158 (offset_intervals): Tell GCC not to worry about length overflow
11159 when negating a negative length.
11161 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11162 (overrun_check_free): Likewise.
11164 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11165 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11168 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11169 (gnutls_make_error): Rename local to avoid shadowing.
11170 (gnutls_emacs_global_deinit): ifdef out; not used.
11171 (Fgnutls_boot): Use const for pointer to readonly storage.
11172 Comment out unused local. Fix pointer signedness problems.
11174 * lread.c (openp): Don't stuff size_t into an 'int'.
11175 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11176 about possible signed overflow.
11178 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11179 (GDK_KEY_g): Don't define if already defined.
11180 (xg_prepare_tooltip): Avoid pointer signedness problem.
11181 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11183 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11184 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11186 * xfns.c (Fx_window_property): Simplify a bit,
11187 to make a bit faster and to avoid GCC 4.6.0 warning.
11188 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11190 * fns.c (internal_equal): Don't assume size_t fits in int.
11192 * alloc.c (compact_small_strings): Tighten assertion a little.
11194 Replace pEd with more-general pI, and fix some printf arg casts.
11195 * lisp.h (pI): New macro, generalizing old pEd macro to other
11196 conversion specifiers. For example, use "...%"pI"d..." rather
11197 than "...%"pEd"...".
11198 (pEd): Remove. All uses replaced with similar uses of pI.
11199 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
11200 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11201 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11202 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11203 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11204 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11205 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11207 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11208 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11209 * print.c (safe_debug_print, print_object): Likewise.
11210 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11212 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11213 avoiding the 0 flag, which is not portable.
11214 * process.c (Fmake_network_process): Use pI to avoid cast.
11215 * region-cache.c (pp_cache): Likewise.
11216 * xdisp.c (decode_mode_spec): Likewise.
11217 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11218 behavior on 64-bit hosts with printf arg.
11219 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
11220 (x_stop_queuing_selection_requests): Likewise.
11221 (x_get_window_property): Don't truncate byte count to an 'int'
11224 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11225 here, since it parses constructs like leading '-' and spaces,
11226 which are not wanted; and it overflows with large numbers.
11227 Instead, simply match F[0-9]+, which is what is wanted anyway.
11229 * alloc.c: Remove unportable assumptions about struct layout.
11230 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11231 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11232 (allocate_vectorlike, make_pure_vector): Use the new macros,
11233 plus offsetof, to remove unportable assumptions about struct layout.
11234 These assumptions hold on all porting targets that I know of, but
11235 they are not guaranteed, they're easy to remove, and removing them
11236 makes further changes easier.
11238 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11239 This doesn't fix a bug but makes the code clearer.
11240 (string_overrun_cookie): Now const. Use initializers that
11241 don't formally overflow signed char, to avoid warnings.
11242 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11243 can cause Emacs to crash when string overrun checking is enabled.
11244 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11245 multiple of sizeof (EMACS_INT); it need not be, if
11246 alignof(EMACS_INT) < sizeof (EMACS_INT).
11247 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
11249 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
11251 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11253 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11255 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
11256 supposed to be handshaking. (Bug#8556)
11257 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11259 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
11261 * lisp.h (Qdebug): List symbol.
11262 * eval.c (Qdebug): Restore global linkage.
11263 * keyboard.c (debug-on-event): New variable.
11264 (handle_user_signal): Break into debugger when debug-on-event
11265 matches the current signal symbol.
11267 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11269 * alloc.c (check_sblock, check_string_bytes)
11270 (check_string_free_list): Convert to standard C.
11272 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11274 * w32.c (emacs_gnutls_push): Fix typo.
11276 2011-04-25 Eli Zaretskii <eliz@gnu.org>
11278 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11279 "cast to pointer from integer of different size".
11281 Improve doprnt and its use in verror. (Bug#8545)
11282 * doprnt.c (doprnt): Document the set of format control sequences
11283 supported by the function. Use SAFE_ALLOCA instead of always
11286 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11287 is one byte too soon. Don't use xrealloc; instead xfree and
11290 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11292 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11295 * gnutls.c: Renamed global_initialized to
11296 gnutls_global_initialized. Added internals for the
11297 :verify-hostname-error, :verify-error, and :verify-flags
11298 parameters of `gnutls-boot' and documented those parameters in the
11299 docstring. Start callback support.
11300 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11301 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11302 on error. Return error code.
11303 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11304 (emacs_gnutls_read): Likewise.
11305 (Fgnutls_boot): Return handshake error code.
11306 (emacs_gnutls_handle_error): New function.
11307 (wsaerror_to_errno): Likewise.
11309 * w32.h (emacs_gnutls_pull): Add prototype.
11310 (emacs_gnutls_push): Likewise.
11312 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11313 (emacs_gnutls_push): Likewise.
11315 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11317 * process.c (wait_reading_process_output): Check if GnuTLS
11318 buffered some data internally if no FDs are set for TLS
11321 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11322 (LIBS): Link to USER_LIBS.
11323 ($(BLD)/gnutls.$(0)): New target.
11325 2011-04-24 Eli Zaretskii <eliz@gnu.org>
11327 * xdisp.c (handle_single_display_spec): Rename the
11328 display_replaced_before_p argument into display_replaced_p, to
11329 make it consistent with the commentary. Fix typos in the
11332 * textprop.c (syms_of_textprop): Remove dead code.
11333 (copy_text_properties): Delete obsolete commentary about an
11334 interface that was deleted long ago. Fix typos in the description
11337 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11338 to changes in oldXMenu/XMenu.h from 2011-04-16.
11339 <menu_help_message, prev_menu_help_message>: Constify.
11340 (IT_menu_make_room): menu->help_text is now `const char **';
11343 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11344 to changes in oldXMenu/XMenu.h from 2011-04-16.
11345 (struct XMenu): Declare `help_text' `const char **'.
11347 * xfaces.c <Qunspecified>: Make extern again.
11349 * syntax.c: Include sys/types.h before including regex.h, as
11352 * doc.c (get_doc_string): Improve the format passed to `error'.
11354 * doprnt.c (doprnt): Improve commentary.
11356 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11358 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11361 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11362 changes in globals.h immediately force recompilation.
11363 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11364 $(CURDIR)/s/ms-w32.h.
11365 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
11367 * character.c (Fchar_direction): Function deleted.
11368 (syms_of_character): Don't defsubr it.
11369 <char-direction-table>: Deleted.
11371 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11373 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11374 * doprnt.c: Include limits.h.
11375 (SIZE_MAX): New macro.
11376 (doprnt): Return a size_t value. 2nd arg is now size_t.
11377 Many local variables are now size_t instead of int or unsigned.
11378 Improve overflow protection. Support `l' modifier for integer
11379 conversions. Support %l conversion. Don't assume an EMACS_INT
11380 argument for integer conversions and for %c.
11382 * lisp.h (doprnt): Restore prototype.
11384 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11385 $(SRC)/character.h.
11387 * Makefile.in (base_obj): Add back doprnt.o.
11389 * deps.mk (doprnt.o): Add back prerequisites.
11390 (callint.o): Depend on character.h.
11392 * eval.c (internal_lisp_condition_case): Include the handler
11393 representation in the error message.
11394 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11395 when breaking from the loop.
11397 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11399 * callint.c (Fcall_interactively): When displaying error message
11400 about invalid control letter, pass the character's codepoint, not
11401 a pointer to its multibyte form. Improve display of the character
11402 in octal and display also its hex code.
11404 * character.c (char_string): Use %x to display the (unsigned)
11405 codepoint of an invalid character, to avoid displaying a bogus
11408 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11409 `error', not SYMBOL_NAME itself.
11411 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11412 character arguments to `error'.
11414 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11415 to `error' in error message about FINAL_CHAR argument. Make sure
11416 FINAL_CHAR is a character, and use %c when it is passed as
11417 argument to `error'.
11419 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11421 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11423 * w32.c: Include <time.h>.
11424 (sys_localtime): New function.
11426 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
11428 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11430 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
11432 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
11434 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11435 zombies (Bug#8467).
11437 2011-04-19 Eli Zaretskii <eliz@gnu.org>
11439 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11440 gl_state.e_property when gl_state.object is Qt.
11442 * insdel.c (make_gap_larger): Remove limitation of buffer size
11445 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
11447 * xdisp.c (lookup_glyphless_char_display)
11448 (produce_glyphless_glyph): Handle cons cell entry in
11449 glyphless-char-display.
11450 (Vglyphless_char_display): Document it.
11452 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11453 glyphless-char-display.
11455 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
11457 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11459 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11461 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11462 definition for no-X builds.
11464 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
11466 Static checks with GCC 4.6.0 and non-default toolkits.
11468 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11470 * process.c (keyboard_bit_set): Define only if SIGIO.
11471 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11472 (send_process): Repair possible setjmp clobbering.
11474 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11476 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11478 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11480 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11481 Define only if needed.
11483 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11484 by pacifying GCC about it. Maybe it's time to retire it?
11485 * xfaces.c (USG, __TIMEVAL__): Likewise.
11487 * dispextern.h (struct redisplay_interface): Rename param
11488 to avoid shadowing.
11489 * termhooks.h (struct terminal): Likewise.
11490 * xterm.c (xembed_send_message): Likewise.
11492 * insdel.c (make_gap_smaller): Define only if
11493 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11495 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11498 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11499 so that we aren't warned about unused symbols.
11501 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11503 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
11505 * xfns.c (x_real_positions): Mark locals as initialized.
11507 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11509 * xterm.c: Fix problems found by static analysis with other toolkits.
11510 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
11511 (x_dispatch_event): Declare static if USE_GTK, and
11512 define if USE_GTK || USE_X_TOOLKIT.
11513 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
11514 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
11515 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11516 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
11518 * xmenu.c (menu_help_callback): Pointer type fixes.
11519 Use const pointers when pointing at readonly data. Avoid pointer
11520 signedness clashes.
11521 (FALSE): Remove unused macro.
11522 (update_frame_menubar): Remove unused decl.
11524 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11526 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11527 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11528 (single_menu_item): Rename local to avoid shadowing.
11530 * keyboard.c (make_lispy_event): Remove unused local var.
11532 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11533 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11535 * bitmaps: Change bitmaps from unsigned char back to the X11
11536 compatible char. Avoid the old compiler warnings about
11537 out-of-range initializers by using, for example, '\xab' rather
11540 * xgselect.c (xgselect_initialize): Check vs interface
11541 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11543 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11545 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11546 to read-only memory.
11548 * fns.c (vector): Remove; this old hack is no longer needed.
11550 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
11552 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
11554 * xrdb.c (x_load_resources): Omit unused local.
11556 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
11557 (x_window): Rename locals to avoid shadowing.
11558 (USG): Use the kludged USG macro, to pacify gcc.
11560 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
11561 (x_term_init): Remove local to avoid shadowing.
11563 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
11565 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11566 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11568 2011-04-16 Eli Zaretskii <eliz@gnu.org>
11570 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11572 Fix regex.c, syntax.c and friends for buffers > 2GB.
11573 * syntax.h (struct gl_state_s): Declare character position members
11576 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11578 * textprop.c (verify_interval_modification, interval_of):
11579 Declare arguments EMACS_INT.
11581 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11584 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11586 * indent.c (Fvertical_motion): Local variable it_start is now
11589 * regex.c (re_match, re_match_2, re_match_2_internal)
11590 (bcmp_translate, regcomp, regexec, print_double_string)
11591 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11592 (re_compile_pattern, re_exec): Declare arguments and local
11593 variables `size_t' and `ssize_t' and return values `regoff_t', as
11595 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11596 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11597 <compile_stack_type>: `size' and `avail' are now `size_t'.
11599 * regex.h <regoff_t>: Use ssize_t, not int.
11600 (re_search, re_search_2, re_match, re_match_2): Arguments that
11601 specify buffer/string position and length are now ssize_t and
11602 size_t. Return type is regoff_t.
11604 2011-04-16 Ben Key <bkey76@gmail.com>
11606 * nsfont.m: Fixed bugs in ns_get_family and
11607 ns_descriptor_to_entity that were caused by using free to
11608 deallocate memory blocks that were allocated by xmalloc (via
11609 xstrdup). This caused Emacs to crash when compiled with
11610 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11611 --enable-checking=xmallocoverrun). xfree is now used to
11612 deallocate these memory blocks.
11614 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
11616 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11618 emacs_write: Accept and return EMACS_INT for sizes.
11619 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11621 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11622 Accept and return EMACS_INT.
11623 (emacs_gnutls_write): Return the number of bytes written on
11625 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
11626 (emacs_read, emacs_write): Remove check for negative size, as the
11627 Emacs source code has been audited now.
11628 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11629 (emacs_read, emacs_write): Use it.
11630 * process.c (send_process): Adjust to the new signatures of
11631 emacs_write and emacs_gnutls_write. Do not attempt to store
11632 a byte offset into an 'int'; it might overflow.
11633 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
11635 * sound.c: Don't assume sizes fit in 'int'.
11636 (struct sound_device.period_size, alsa_period_size):
11637 Return EMACS_INT, not int.
11638 (struct sound_device.write, vox_write, alsa_write):
11639 Accept EMACS_INT, not int.
11640 (wav_play, au_play): Use EMACS_INT to store sizes and to
11641 record read return values.
11643 2011-04-15 Ben Key <bkey76@gmail.com>
11645 * keyboard.c (Qundefined): Don't declare static since it is used
11647 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11648 static since they are used in nsfont.m.
11650 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11652 * process.c (Qprocessp): Don't declare static.
11653 * lisp.h (Qprocessp): Declare again.
11655 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
11657 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11659 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11661 Improve C-level modularity by making more things 'static'.
11663 Don't publish debugger-only interfaces to other modules.
11664 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11665 (verify_bytepos, count_markers): Move decls to the only modules
11667 * region-cache.h (pp_cache): Likewise.
11668 * window.h (check_all_windows): Likewise.
11669 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11671 * sysdep.c (croak): Now static, if
11672 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11673 * syssignal.h (croak): Declare only if not static.
11675 * alloc.c (refill_memory_reserve): Now static if
11676 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11677 * lisp.h (refill_memory_reserve): Declare only if not static.
11679 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11680 Define only if USE_LUCID.
11682 * xrdb.c (x_customization_string, x_rm_string): Now static.
11684 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11685 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11687 * xdisp.c (draw_row_with_mouse_face): Now static.
11688 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11690 * window.h (check_all_windows): Mark externally visible.
11692 * window.c (window_deletion_count): Now static.
11694 * undo.c: Make symbols static if they're not exported.
11695 (last_undo_buffer, last_boundary_position, pending_boundary):
11698 * textprop.c (interval_insert_behind_hooks): Now static.
11699 (interval_insert_in_front_hooks): Likewise.
11701 * term.c: Make symbols static if they're not exported.
11702 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11703 (max_frame_lines, tty_set_terminal_modes):
11704 (tty_reset_terminal_modes, tty_turn_off_highlight):
11705 (get_tty_terminal): Now static.
11706 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11707 * termhooks.h (term_mouse_moveto): Do not declare if
11708 HAVE_WINDOW_SYSTEM.
11709 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11710 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11712 * sysdep.c: Make symbols static if they're not exported.
11713 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11715 (sigprocmask_set, full_mask): Remove; unused.
11716 (wait_debugging): Mark as visible.
11717 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11718 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11720 * syntax.c (syntax_temp): Define only if !__GNUC__.
11722 * sound.c (current_sound_device, current_sound): Now static.
11724 * search.c (searchbufs, searchbuf_head): Now static.
11726 * scroll.c (scroll_cost): Remove; unused.
11727 * dispextern.h (scroll_cost): Remove decl.
11729 * region-cache.h (pp_cache): Mark as externally visible.
11731 * process.c: Make symbols static if they're not exported.
11732 (process_tick, update_tick, create_process, chan_process):
11733 (Vprocess_alist, proc_buffered_char, datagram_access):
11734 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11735 (deactivate_process): Mark defn as static, as well as decl.
11736 * lisp.h (create_process): Remove decl.
11737 * process.h (chan_process, Vprocess_alist): Remove decls.
11739 * print.c: Make symbols static if they're not exported.
11740 (print_depth, new_backquote_output, being_printed, print_buffer):
11741 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11742 (print_interval, print_number_index, initial_stderr_stream):
11744 * lisp.h (Fprinc): Remove decl.
11745 (debug_output_compilation_hack): Mark as externally visible.
11747 * sysdep.c (croak): Move decl from here to syssignal.h.
11748 * syssignal.h (croak): Put it here, so the API can be checked when
11749 'croak' is called from dissociate_if_controlling_tty.
11751 * minibuf.c: Make symbols static if they're not exported.
11752 (minibuf_save_list, choose_minibuf_frame): Now static.
11753 * lisp.h (choose_minibuf_frame): Remove decl.
11755 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11757 * lread.c: Make symbols static if they're not exported.
11758 (read_objects, initial_obarray, oblookup_last_bucket_number):
11760 (make_symbol): Remove; unused.
11761 * lisp.h (initial_obarray, make_symbol): Remove decls.
11763 * keyboard.c: Make symbols static if they're not exported.
11764 (single_kboard, recent_keys_index, total_keys, recent_keys):
11765 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11766 (this_single_command_key_start, echoing, last_auto_save):
11767 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11768 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11769 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11770 (Vlispy_mouse_stem, double_click_count):
11772 (force_auto_save_soon): Define only if SIGDANGER.
11773 (ignore_mouse_drag_p): Now static if
11774 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11775 (print_help): Remove; unused.
11776 (stop_character, last_timer_event): Mark as externally visible.
11777 * keyboard.h (ignore_mouse_drag_p): Declare only if
11778 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11779 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11780 * lisp.h (echoing): Remove decl.
11781 (force_auto_save_soon): Declare only if SIGDANGER.
11782 * xdisp.c (redisplay_window): Simplify code, to make it more
11783 obvious that ignore_mouse_drag_p is not accessed if !defined
11784 USE_GTK && !defined HAVE_NS.
11786 * intervals.c: Make symbols static if they're not exported.
11787 (merge_properties_sticky, merge_interval_right, delete_interval):
11789 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11791 * insdel.c: Make symbols static if they're not exported.
11792 However, leave prepare_to_modify_buffer alone. It's never
11793 called from outside this function, but that appears to be a bug.
11794 (combine_after_change_list, combine_after_change_buffer):
11795 (adjust_after_replace, signal_before_change): Now static.
11796 (adjust_after_replace_noundo): Remove; unused.
11797 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11798 (signal_before_change): Remove decls.
11800 * indent.c (val_compute_motion, val_vmotion): Now static.
11802 * image.c: Make symbols static if they're not exported.
11803 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11805 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11806 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11808 * fringe.c (standard_bitmaps): Now static.
11809 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11811 * frame.c: Make symbols static if they're not exported.
11812 (x_report_frame_params, make_terminal_frame): Now static.
11813 (get_frame_param): Now static, unless HAVE_NS.
11814 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11815 (x_get_resource_string): Remove; not used.
11816 * frame.h (make_terminal_frame, x_report_frame_params):
11817 (x_get_resource_string); Remove decls.
11818 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11819 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11821 * font.c, fontset.c: Make symbols static if they're not exported.
11822 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11823 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11824 * font.c (font_close_object): Now static.
11825 * font.h (font_close_object): Remove.
11826 * fontset.c (FONTSET_OBJLIST): Remove.
11827 (free_realized_fontset) #if-0 the body, which does nothing.
11828 (face_suitable_for_char_p): #if-0, as it's never called.
11829 * fontset.h (face_suitable_for_char_p): Remove decl.
11830 * xfaces.c (face_at_string_position):
11831 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11832 since 0 is always ASCII.
11834 * fns.c (weak_hash_tables): Now static.
11836 * fileio.c: Make symbols static if they're not exported.
11837 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11838 (Vwrite_region_annotation_buffers): Now static.
11840 * eval.c: Make symbols static if they're not exported.
11841 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11842 * lisp.h (backtrace_list): Remove decl.
11844 * emacs.c: Make symbols static if they're not exported.
11845 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11846 (fatal_error_code, fatal_error_signal_hook, standard_args):
11848 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11849 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11850 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11851 * lisp.h (fatal_error_signal_hook): Remove decl.
11852 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11854 * editfns.c: Move a (normally-unused) function to its only use.
11855 * editfns.c, lisp.h (get_operating_system_release): Remove.
11856 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11857 worth the hassle of breaking this out.
11859 * xterm.c: Make symbols static if they're not exported.
11860 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11861 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11862 (x_destroy_window, x_delete_display):
11864 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11865 (x_mouse_leave): Remove; unused.
11866 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11867 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11868 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11870 (x_mouse_leave): Declare only if WINDOWSNT.
11871 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11872 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11875 * ftxfont.c: Make symbols static if they're not exported.
11876 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11878 * font.h (ftxfont_driver): Likewise.
11880 * xfns.c: Make symbols static if they're not exported.
11881 (x_last_font_name, x_display_info_for_name):
11882 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11883 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11884 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11885 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11886 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11887 (last_show_tip_args): Now static.
11888 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11889 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11890 (x_screen_planes): Remove; unused.
11891 * dispextern.h (x_screen_planes): Remove decl.
11893 * dispnew.c: Make symbols static if they're not exported.
11894 * dispextern.h (redraw_garbaged_frames, scrolling):
11895 (increment_row_positions): Remove.
11896 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11897 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11899 (redraw_garbaged_frames): Remove; unused.
11901 * xfaces.c: Make symbols static if they're not exported.
11902 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11904 * xterm.h (defined_color): Remove decls.
11905 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11906 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11907 (menu_face_changed_default, defined_color, free_realized_face):
11908 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11909 (ascii_face_of_lisp_face): Remove; unused.
11911 * xdisp.c: Make symbols static if they're not exported.
11912 * dispextern.h (scratch_glyph_row, window_box_edges):
11913 (glyph_to_pixel_coords, set_cursor_from_row):
11914 (get_next_display_element, set_iterator_to_next):
11915 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11916 (show_mouse_face): Remove decls
11917 * frame.h (message_buf_print): Likewise.
11918 * lisp.h (pop_message, set_message, check_point_in_composition):
11920 * xterm.h (set_vertical_scroll_bar): Likewise.
11921 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11922 (message_buf_print, scratch_glyph_row, displayed_buffer):
11923 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11924 (get_next_display_element, show_mouse_face, window_box_edges):
11925 (frame_to_window_pixel_xy, check_point_in_composition):
11926 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11927 (glyph_to_pixel_coords): Remove; unused.
11929 * dired.c (file_name_completion): Now static.
11931 * dbusbind.c (xd_in_read_queued_messages): Now static.
11933 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11934 * data.c (circular_list_error): Remove.
11936 * commands.h (last_point_position, last_point_position_buffer):
11937 (last_point_position_window): Remove decls.
11938 * keyboard.c: Make these variables static.
11940 * coding.h (coding, code_convert_region, encode_coding_gap):
11942 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11943 (iso_code_class, detect_coding, code_convert_region): Now static.
11944 (encode_coding_gap): Remove; unused.
11946 * chartab.c (chartab_chars, chartab_bits): Now static.
11948 * charset.h (charset_iso_8859_1): Remove decl.
11949 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11952 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11953 * ccl.c (Vccl_program_table): Now static.
11954 (check_ccl_update): Remove; unused.
11956 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11957 * category.h: ... from here.
11958 * category.c (check_category_table, set_category_set): Now static.
11960 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11961 * lisp.h: Remove these decls.
11963 * buffer.c (buffer_count): Remove unused var.
11965 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11966 so that it's not optimized away.
11967 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11968 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11969 exported only to the debugger.
11971 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
11972 * atimer.h (run_all_atimers): Remove; not exported.
11974 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11975 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11976 was inaccessible from Lisp.
11977 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11978 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11980 alloc.c: Import and export fewer symbols, and remove unused items.
11981 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11983 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11984 it's not optimized away by whole-program optimization.
11985 (message_enable_multibyte, free_misc): Remove.
11986 (catchlist, handlerlist, mark_backtrace):
11987 Declare only if BYTE_MARK_STACK.
11988 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11989 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11990 (message_enable_multibyte): Remove decl.
11991 (free_misc, interval_free_list, float_block, float_block_index):
11992 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11993 (cons_free_list, last_marked_index):
11995 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11996 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11997 (mark_backtrace): Define only if BYTE_MARK_STACK.
11998 * xdisp.c (message_enable_multibyte): Now static.
12000 Declare Lisp_Object Q* variables to be 'static' if not exported.
12001 This makes it easier for human readers (and static analyzers)
12002 to see whether these variables are used from other modules.
12003 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12004 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12005 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12006 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12007 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12008 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12009 * xmenu.c, xselect.c:
12010 Declare Q* vars static if they are not used in other modules.
12011 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12012 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12013 Remove decls of unexported vars.
12014 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12016 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12018 Make Emacs functions such as Fatom 'static' by default.
12019 This makes it easier for human readers (and static analyzers)
12020 to see whether these functions can be called from other modules.
12021 DEFUN now defines a static function. To make the function external
12022 so that it can be used in other C modules, use the new macro DEFUE.
12023 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12024 (Finit_image_library):
12025 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12026 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12027 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12028 Remove decls, since these functions are now static.
12029 (Funintern, Fget_internal_run_time): New decls, since these functions
12030 were already external.
12032 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12033 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12034 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12035 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12036 * keyboard.c, keymap.c, lread.c:
12037 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12038 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12039 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12040 Mark functions with DEFUE instead of DEFUN,
12041 if they are used in other modules.
12042 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12043 decls for now-static functions.
12044 * buffer.h (Fdelete_overlay): Remove decl.
12045 * callproc.c (Fgetenv_internal): Mark as internal.
12046 * composite.c (Fremove_list_of_text_properties): Remove decl.
12047 (Fcomposition_get_gstring): New forward static decl.
12048 * composite.h (Fcomposite_get_gstring): Remove decl.
12049 * dired.c (Ffile_attributes): New forward static decl.
12050 * doc.c (Fdocumntation_property): New forward static decl.
12051 * eval.c (Ffetch_bytecode): New forward static decl.
12052 (Funintern): Remove extern decl; now in .h file where it belongs.
12053 * fileio.c (Fmake_symbolic_link): New forward static decl.
12054 * image.c (Finit_image_library): New forward static decl.
12055 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12056 * intervals.h (Fprevious_property_change):
12057 (Fremove_list_of_text_properties): Remove decls.
12058 * keyboard.c (Fthis_command_keys): Remove decl.
12059 (Fcommand_execute): New forward static decl.
12060 * keymap.c (Flookup_key): New forward static decl.
12061 (Fcopy_keymap): Now static.
12062 * keymap.h (Flookup_key): Remove decl.
12063 * process.c (Fget_process): New forward static decl.
12064 (Fprocess_datagram_address): Mark as internal.
12065 * syntax.c (Fsyntax_table_p): New forward static decl.
12066 (skip_chars): Remove duplicate decl.
12067 * textprop.c (Fprevious_property_change): New forward static decl.
12068 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12070 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12071 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12073 * editfns.c (Fformat): Remove unreachable code.
12075 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12077 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12080 2011-04-13 Eli Zaretskii <eliz@gnu.org>
12082 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12083 when at ZV. (Bug#8487)
12085 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12087 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12089 * keyboard.c (parse_tool_bar_item): Likewise.
12090 * sound.c (sound_cleanup, alsa_close): Likewise.
12091 * termcap.c (tgetent): Likewise.
12092 * xfns.c (x_default_font_parameter): Likewise.
12093 * xsettings.c (read_and_apply_settings): Likewise.
12095 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12096 (overrun_check_free): Protoize.
12098 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12100 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12101 since callers should never pass a negative size.
12102 Change the signature to match that of plain 'read' and 'write'; see
12103 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12104 * lisp.h: Update prototypes of emacs_write and emacs_read.
12106 2011-04-11 Eli Zaretskii <eliz@gnu.org>
12108 * xdisp.c (redisplay_window): Don't try to determine the character
12109 position of the scroll margin if the window start point w->startp
12110 is outside the buffer's accessible region. (Bug#8468)
12112 2011-04-10 Eli Zaretskii <eliz@gnu.org>
12114 Fix write-region and its subroutines for buffers > 2GB.
12115 * fileio.c (a_write, e_write): Modify declaration of arguments and
12116 local variables to support buffers larger than 2GB.
12117 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12119 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12120 argument, local variables, and return value.
12122 * lisp.h: Update prototypes of emacs_write and emacs_read.
12124 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12126 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
12128 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12130 Fix more problems found by GCC 4.6.0's static checks.
12132 * xdisp.c (vmessage): Use a better test for character truncation.
12134 * charset.c (load_charset_map): <, not <=, for optimization,
12135 and to avoid potential problems with integer overflow.
12136 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
12137 * casetab.c (set_identity, shuffle): Likewise.
12138 * editfns.c (Fformat): Likewise.
12139 * syntax.c (skip_chars): Likewise.
12141 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12142 This also lets GCC 4.6.0 generate slightly better loop code.
12144 * callint.c (Fcall_interactively): <, not <=, for optimization.
12145 (Fcall_interactively): Count the number of arguments produced,
12146 not the number of arguments given. This is simpler and lets GCC
12147 4.6.0 generate slightly better code.
12149 * ftfont.c: Distingish more carefully between FcChar8 and char.
12150 The previous code passed unsigned char * to a functions like
12151 strlen and xstrcasecmp that expect char *, which does not
12152 conform to the C standard.
12153 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12154 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12155 char * when the C standard requires it.
12157 * keyboard.c (read_char): Remove unused var.
12159 * eval.c: Port to Windows vsnprintf (Bug#8435).
12160 Include <limits.h>.
12161 (SIZE_MAX): Define if the headers do not.
12162 (verror): Do not give up if vsnprintf returns a negative count.
12163 Instead, grow the buffer. This ports to Windows vsnprintf, which
12164 does not conform to C99. Problem reported by Eli Zaretskii.
12165 Also, simplify the allocation scheme, by avoiding the need for
12166 calling realloc, and removing the ALLOCATED variable.
12168 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12170 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12171 But keep the doprint source code for now, as we might revamp it
12172 and use it again (Bug#8435).
12173 * lisp.h (doprnt): Remove.
12174 * Makefile.in (base_obj): Remove doprnt.o.
12175 * deps.mk (doprnt.o): Remove.
12177 error: Print 32- and 64-bit integers portably (Bug#8435).
12178 Without this change, on typical 64-bit hosts error ("...%d...", N)
12179 was used to print both 32- and 64-bit integers N, which relied on
12180 undefined behavior.
12181 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
12182 * lisp.h (error, verror): Mark as printf-like functions.
12183 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12184 Report overflow in size calculations when allocating printf buffer.
12185 Do not truncate output string at its first null byte.
12186 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12187 Truncate the output at a character boundary, since vsnprintf does not
12189 * charset.c (check_iso_charset_parameter): Convert internal
12190 character to string before calling 'error', since %c now has the
12192 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12193 overflow when computing char to be passed to 'error'. Do not
12194 pass Lisp_Object to 'error'; pass the integer instead.
12195 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12196 formatted with plain %d.
12198 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12200 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12202 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12204 * xterm.c (x_catch_errors): Remove duplicate declaration.
12206 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12208 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12210 2011-04-10 Jim Meyering <meyering@redhat.com>
12212 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12213 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12214 return ssize_t not "int", and use size_t as the buffer length.
12215 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12216 * gnutls.h: Update declarations.
12217 * process.c (read_process_output): Use ssize_t, to match.
12218 (send_process): Likewise.
12220 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12222 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12224 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12226 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12227 Use unsigned char, to match FcChar8 type definition.
12229 * xterm.c (handle_one_xevent):
12230 * xmenu.c (create_and_show_popup_menu):
12231 * xselect.c (x_decline_selection_request)
12232 (x_reply_selection_request): Avoid type-punned deref of X events.
12234 2011-04-09 Eli Zaretskii <eliz@gnu.org>
12236 Fix some uses of `int' instead of EMACS_INT.
12237 * search.c (string_match_1, fast_string_match)
12238 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12239 (scan_buffer, find_next_newline_no_quit)
12240 (find_before_next_newline, search_command, Freplace_match)
12241 (Fmatch_data): Make some `int' variables be EMACS_INT.
12243 * xdisp.c (display_count_lines): 3rd argument and return value now
12244 EMACS_INT. All callers changed.
12245 (pint2hrstr): Last argument is now EMACS_INT.
12247 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12248 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12249 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12250 (decode_coding_utf_16, decode_coding_emacs_mule)
12251 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12252 (decode_coding_ccl, decode_coding_charset)
12253 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12254 (decode_coding_iso_2022, decode_coding_emacs_mule)
12255 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12256 <char_offset, last_offset>: Declare EMACS_INT.
12257 (encode_coding_utf_8, encode_coding_utf_16)
12258 (encode_coding_emacs_mule, encode_invocation_designation)
12259 (encode_designation_at_bol, encode_coding_iso_2022)
12260 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12261 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12263 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12264 (encode_invocation_designation): Last argument P_NCHARS is now
12266 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12267 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12269 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12272 * ccl.c (Fccl_execute_on_string): Declare some variables
12275 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
12277 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12279 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12281 * process.c (Fformat_network_address): Doc fix.
12283 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12285 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
12287 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
12289 * keyboard.c (read_char): Call Lisp function help-form-show,
12290 instead of using internal_with_output_to_temp_buffer.
12291 (Qhelp_form_show): New var.
12292 (syms_of_keyboard): Use DEFSYM macro.
12294 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12296 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12298 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
12300 * process.c (Flist_processes): Remove to Lisp.
12301 (list_processes_1): Delete.
12303 2011-04-06 Eli Zaretskii <eliz@gnu.org>
12305 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12307 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12309 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
12311 Fix more problems found by GCC 4.6.0's static checks.
12313 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12315 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12317 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
12319 * xdisp.c (vmessage): Mark as a printf-like function.
12321 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12323 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12325 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12326 printf-like functions.
12327 (tiff_load): Add casts to remove these marks before passing them
12328 to system-supplied API.
12330 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12332 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12333 This avoids several warnings with gcc -Wstrict-overflow.
12334 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12335 directly, rather than having caller test rule sign. This avoids
12336 some unnecessary tests.
12337 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12338 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12339 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
12341 * xfont.c (xfont_text_extents): Remove var that was set but not used.
12342 (xfont_open): Avoid unnecessary tests.
12344 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12346 * composite.h, composite.c (composition_gstring_put_cache):
12347 Use EMACS_INT, not int, for length.
12349 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12350 breaking out part of COMPOSITION_DECODE_RULE.
12351 (COMPOSITION_DECODE_RULE): Use it.
12352 * composite.c (get_composition_id): Remove unused local vars,
12353 by using the new macro.
12355 * textprop.c (set_text_properties_1): Change while to do-while,
12356 since the condition is always true at first.
12358 * intervals.c (graft_intervals_into_buffer): Mark var as used.
12359 (interval_deletion_adjustment): Return unsigned value.
12362 * process.c (list_processes_1, create_pty, read_process_output):
12363 (exec_sentinel): Remove vars that were set but not used.
12364 (create_pty): Remove unnecessary "volatile"s.
12365 (Fnetwork_interface_info): Avoid possibility of int overflow.
12366 (read_process_output): Do adaptive read buffering even if carryover.
12367 (read_process_output): Simplify nbytes computation if buffered.
12369 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12371 * syntax.c (scan_words): Remove var that was set but not used.
12372 (update_syntax_table): Use unsigned instead of int.
12374 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
12375 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
12376 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
12378 * print.c (print_error_message): Avoid int overflow.
12380 * font.c (font_list_entities): Redo for clarity,
12381 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12383 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
12384 (font_score): Avoid potential overflow in diff calculation.
12386 * fns.c (substring_both): Remove var that is set but not used.
12387 (sxhash): Redo loop for clarity and to avoid wraparound warning.
12389 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12391 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12392 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12393 can always succeed if overflow has undefined behavior.
12395 * search.c (boyer_moore, wordify): Remove vars set but not used.
12396 (wordify): Omit three unnecessary tests.
12398 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12399 All callers changed. This avoids the need for an unused var.
12401 * casefiddle.c (casify_region): Remove var that is set but not used.
12403 * dired.c (file_name_completion): Remove var that is set but not used.
12405 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12407 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
12408 (Finsert_file_contents): Remove unnecessary code checking fd.
12410 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12411 Check for integer overflow on size calculations.
12413 * buffer.c (Fprevious_overlay_change): Remove var that is set
12416 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12417 Remove vars that are set but not used.
12418 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
12419 (timer_check_2): Mark vars as initialized.
12421 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12423 * image.c (lookup_image): Remove var that is set but not used.
12424 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
12426 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12427 that are set but not used.
12429 * xfns.c (make_invisible_cursor): Don't return garbage
12430 if XCreateBitmapFromData fails (Bug#8410).
12432 * xselect.c (x_get_local_selection, x_handle_property_notify):
12433 Remove vars that are set but not used.
12435 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
12436 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
12438 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12439 Remove var that is set but not used.
12440 (scroll_bar_windows_size): Now size_t, not int.
12441 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12442 Check for overflow.
12444 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12445 (map_tty_color) [!defined MSDOS]: Likewise.
12447 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12449 * coding.c: Remove vars that are set but not used.
12450 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12451 All callers changed.
12452 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12453 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12454 (decode_coding_charset): Remove vars that are set but not used.
12456 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12457 that is set but not used.
12459 * print.c (print_object): Remove var that is set but not used.
12461 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
12462 The gnulib version avoids calling malloc in the usual case,
12463 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12464 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12465 * filelock.c (current_lock_owner): Likewise.
12466 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12467 * sysdep.c: Include allocator.h, careadlinkat.h.
12468 (emacs_no_realloc_allocator): New static constant.
12469 (emacs_readlink): New function.
12470 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12471 ../lib/careadlinkat.h.
12473 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12475 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12476 first non-nil return value).
12478 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12480 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12481 if not defined (Bug#8403).
12483 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12485 * xdisp.c (display_count_lines): Remove parameter `start',
12486 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12487 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12488 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12489 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12490 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12491 and thereabouts. All callers changed.
12492 (get_per_char_metric): Remove parameter `f', unused since
12493 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12495 2011-04-02 Jim Meyering <meyering@redhat.com>
12497 do not dereference NULL upon failed strdup
12498 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12499 (ns_get_family): Likewise.
12501 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12503 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12505 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12507 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12510 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12512 Add lexical binding.
12514 * window.c (Ftemp_output_buffer_show): New fun.
12515 (Fsave_window_excursion):
12516 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12518 * lread.c (lisp_file_lexically_bound_p): New function.
12519 (Fload): Bind Qlexical_binding.
12520 (readevalloop): Remove `evalfun' arg.
12521 Bind Qinternal_interpreter_environment.
12522 (Feval_buffer): Bind Qlexical_binding.
12523 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12525 (syms_of_lread): Declare `lexical-binding'.
12527 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12529 * keyboard.c (eval_dyn): New fun.
12530 (menu_item_eval_property): Use it.
12532 * image.c (parse_image_spec): Use Ffunctionp.
12534 * fns.c (concat, mapcar1): Accept byte-code-functions.
12536 * eval.c (Fsetq): Handle lexical vars.
12537 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12538 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12539 (FletX, Flet): Obey lexical binding.
12540 (Fcommandp): Handle closures.
12541 (Feval): New `lexical' arg.
12542 (eval_sub): New function extracted from Feval. Use it almost
12543 everywhere where Feval was used. Look up vars in lexical env.
12545 (Ffunctionp): Move from subr.el.
12546 (Ffuncall): Handle closures.
12547 (apply_lambda): Remove `eval_flags'.
12548 (funcall_lambda): Handle closures and new byte-code-functions.
12549 (Fspecial_variable_p): New function.
12550 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12551 but without exporting it to Lisp.
12553 * doc.c (Fdocumentation, store_function_docstring):
12554 * data.c (Finteractive_form): Handle closures.
12556 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12559 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12561 (exec_byte_code): New function extracted from Fbyte_code to handle new
12562 calling convention for byte-code-functions. Add new byte-codes.
12564 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
12566 * alloc.c (Fmake_symbol): Init new `declared_special' field.
12568 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12570 * xdisp.c (redisplay_internal): Fix prototype.
12572 2011-03-31 Eli Zaretskii <eliz@gnu.org>
12574 * xdisp.c (SCROLL_LIMIT): New macro.
12575 (try_scrolling): Use it when setting scroll_limit.
12576 Limit scrolling to 100 screen lines.
12577 (redisplay_window): Even when falling back on "recentering",
12578 position point in the window according to scroll-conservatively,
12579 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12581 (try_scrolling): When point is above the window, allow searching
12582 as far as scroll_max, or one screenful, to compute vertical
12583 distance from PT to the scroll margin position. This prevents
12584 try_scrolling from unnecessarily failing when
12585 scroll-conservatively is set to a value slightly larger than the
12586 window height. Clean up the case of PT below the margin at bottom
12587 of window: scroll_max can no longer be INT_MAX. When aggressive
12588 scrolling is in use, don't let point enter the opposite scroll
12589 margin as result of the scroll.
12590 (syms_of_xdisp) <scroll-conservatively>: Document the
12591 threshold of 100 lines for never-recentering scrolling.
12593 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12595 * dispextern.h (move_it_by_lines):
12596 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12597 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12598 (message_log_check_duplicate): Remove parameters `prev_bol' and
12599 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12600 (redisplay_internal): Remove parameter `preserve_echo_area',
12601 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12603 * indent.c (Fvertical_motion):
12604 * window.c (window_scroll_pixel_based, Frecenter):
12605 Don't pass `need_y_p' to `move_it_by_lines'.
12607 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12609 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12610 steal a few bits to be more compact.
12611 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12612 Remove unneeded casts.
12614 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12616 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12618 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12619 binding" message (bug#7967).
12621 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12623 Fix more problems found by GCC 4.6.0's static checks.
12625 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12626 Remove unused local var.
12628 * editfns.c (Fmessage_box): Remove unused local var.
12630 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12631 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12632 Omit unused local vars.
12633 * window.c (shrink_windows): Omit unused local var.
12634 * menu.c (digest_single_submenu): Omit unused local var.
12635 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12636 Omit unused local var.
12638 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12639 Don't assume string length fits in int.
12640 (keyremap_step, read_key_sequence): Use size_t for sizes.
12641 (read_key_sequence): Don't check last_real_key_start redundantly.
12643 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12644 instead of alloca (Bug#8344).
12646 * eval.c (Fbacktrace): Don't assume nargs fits in int.
12647 (Fbacktrace_frame): Don't assume nframes fits in int.
12649 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12651 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12654 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12656 * cm.c (calccost): Turn while-do into do-while, for clarity.
12658 * keyboard.c (syms_of_keyboard): Use the same style as later
12659 in this function when indexing through an array. This also
12660 works around GCC bug 48267.
12662 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12664 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12666 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12667 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12669 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12670 This avoids undefined behavior on integer overflow, and is a bit
12671 more convenient anyway since it is compared to a size_t variable.
12673 Variadic C functions now count arguments with size_t, not int.
12674 This avoids an unnecessary limitation on 64-bit machines, which
12675 caused (substring ...) to crash on large vectors (Bug#8344).
12676 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12677 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
12678 All variadic functions and their callers changed accordingly.
12679 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12680 * data.c (arith_driver, float_arith_driver): Likewise.
12681 * editfns.c (general_insert_function): Likewise.
12682 * eval.c (struct backtrace.nargs, interactive_p)
12683 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12684 (funcall_lambda, mark_backtrace): Likewise.
12685 * fns.c (concat): Likewise.
12686 * frame.c (x_set_frame_parameters): Likewise.
12687 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12688 0 if not found, not -1. All callers changed.
12690 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12691 (stack_copy_size): Now size_t, not int.
12692 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12694 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12696 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12697 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12698 All callers changed.
12700 * lisp.h (multibyte_char_to_unibyte):
12701 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12702 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12703 * character.h (CHAR_TO_BYTE8):
12704 * cmds.c (internal_self_insert):
12705 * editfns.c (general_insert_function):
12706 * keymap.c (push_key_description):
12707 * search.c (Freplace_match):
12708 * xdisp.c (message_dolog, set_message_1): All callers changed.
12710 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12712 * keyboard.c (safe_run_hook_funcall): New function.
12713 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12714 don't set the hook to nil, but remove the offending function instead.
12715 (Qcommand_hook_internal): Remove, unused.
12716 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12717 Vcommand_hook_internal.
12719 * eval.c (enum run_hooks_condition): Remove.
12720 (funcall_nil, funcall_not): New functions.
12721 (run_hook_with_args): Call each function through a `funcall' argument.
12722 Remove `cond' argument, now redundant.
12723 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12724 (Frun_hook_with_args_until_failure): Adjust accordingly.
12725 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12727 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12729 * dispextern.h (string_buffer_position): Remove declaration.
12731 * print.c (strout): Remove parameter `multibyte', unused since
12732 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12734 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12735 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12736 All callers changed.
12738 * w32.c (_wsa_errlist): Use braces for struct initializers.
12740 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12741 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12742 All callers changed.
12743 (string_buffer_position): Likewise. Also, make static (it's never
12744 used outside xdisp.c).
12745 (cursor_row_p): Remove parameter `w', unused since
12746 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12747 (decode_mode_spec): Remove parameter `precision', introduced during
12748 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12749 All callers changed.
12751 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12753 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12755 2011-03-27 Anders Lindgren <andlind@gmail.com>
12757 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12758 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12759 (ns_update_auto_hide_menu_bar): New functions.
12760 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12761 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12762 ns_constrain_all_frames.
12763 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12764 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12766 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12768 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12770 2011-03-27 Glenn Morris <rgm@gnu.org>
12772 * syssignal.h: Replace RETSIGTYPE with void.
12773 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12774 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12775 Replace SIGTYPE with void everywhere.
12776 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12777 * s/template.h (SIGTYPE): Remove commented out definition.
12779 2011-03-26 Eli Zaretskii <eliz@gnu.org>
12781 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12782 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12784 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
12786 * w32.c (read_unc_volume): Use parameter `henum', instead of
12787 global variable `wget_enum_handle'.
12789 * keymap.c (describe_vector): Remove parameters `indices' and
12790 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12791 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12793 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12795 * keyboard.c (timer_check): Remove parameter `do_it_now',
12796 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12797 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12798 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12800 * keyboard.c (read_char):
12801 * w32menu.c (w32_menu_display_help):
12802 * xmenu.c (show_help_event, menu_help_callback):
12803 Adjust calls to `show_help_echo'.
12805 * gtkutil.c (xg_maybe_add_timer):
12806 * keyboard.c (readable_events):
12807 * process.c (wait_reading_process_output):
12808 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12810 * insdel.c (adjust_markers_gap_motion):
12811 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12812 (gap_left, gap_right): Don't call it.
12814 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12816 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12817 incurred during fontification.
12819 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12821 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12822 (DEFVAR_PER_BUFFER): Don't pass it.
12824 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12825 (scrolling_window): Don't pass it.
12827 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12829 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12831 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12833 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12834 of variables specific to SELinux and computation of `encoded_absname'.
12836 * image.c (XPutPixel): Remove unused variable `height'.
12838 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12840 * unexw32.c (get_section_info): Remove unused variable `section'.
12842 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12843 (system_process_attributes): Remove unused variable `sess'.
12844 (sys_read): Remove unused variable `err'.
12846 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12847 (w32_wnd_proc): Remove unused variable `isdead'.
12848 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12849 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12850 (x_create_tip_frame): Remove unused variable `tem'.
12852 * w32inevt.c (w32_console_read_socket):
12853 Remove unused variable `no_events'.
12855 * w32term.c (x_draw_composite_glyph_string_foreground):
12856 Remove unused variable `width'.
12858 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12860 * w32term.c (x_set_glyph_string_clipping):
12861 Don't pass uninitialized region to CombineRgn.
12863 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12865 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12866 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12867 (Fx_close_connection): Remove unused variable `i'.
12869 * w32font.c (w32font_draw): Return number of glyphs.
12870 (w32font_open_internal): Remove unused variable `i'.
12871 (w32font_driver): Add missing initializer.
12873 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12874 (fill_in_menu): Remove unused variable `items_added'.
12876 * w32term.c (last_mouse_press_frame): Remove static global variable.
12877 (w32_clip_to_row): Remove unused variable `f'.
12878 (x_delete_terminal): Remove unused variable `i'.
12880 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12881 (NOTHING): Remove unused static global variable.
12882 (uniscribe_check_otf): Remove unused variable `table'.
12883 (uniscribe_font_driver): Add missing initializers.
12885 2011-03-23 Julien Danjou <julien@danjou.info>
12887 * term.c (Fsuspend_tty, Fresume_tty):
12888 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12889 * window.c (temp_output_buffer_show):
12890 * insdel.c (signal_before_change):
12891 * frame.c (Fhandle_switch_frame):
12892 * fileio.c (Fdo_auto_save):
12893 * emacs.c (Fkill_emacs):
12894 * editfns.c (save_excursion_restore):
12895 * cmds.c (internal_self_insert):
12896 * callint.c (Fcall_interactively):
12897 * buffer.c (Fkill_all_local_variables):
12898 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12900 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12901 unconditionally since it does the check itself.
12903 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12905 Fix more problems found by GCC 4.5.2's static checks.
12907 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12908 the first time through the loop, since we know p0 < p1 then.
12909 This also avoids a gcc -Wstrict-overflow warning.
12911 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12912 leading to a memory leak, possible in functions like
12913 load_charset_map_from_file that can allocate an unbounded number
12914 of objects (Bug#8318).
12916 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12917 that could (at least in theory) be that large.
12919 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12920 This is less likely to overflow, and avoids undefined behavior if
12921 overflow does occur. All callers changed. Use strtoul to scan
12922 for the unsigned long integer.
12923 (pint2hrstr): Simplify and tune code slightly.
12924 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
12926 * scroll.c (do_scrolling): Work around GCC bug 48228.
12927 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12929 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12930 This also avoids a warning with gcc -Wstrict-overflow.
12931 (validate_x_resource_name): Simplify count usage.
12932 This also avoids a warning with gcc -Wstrict-overflow.
12934 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12937 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
12939 * process.c (Fmake_network_process): Use socklen_t, not int,
12940 where POSIX says socklen_t is required in portable programs.
12941 This fixes a porting bug on hosts like 64-bit HP-UX, where
12942 socklen_t is wider than int (Bug#8277).
12943 (Fmake_network_process, server_accept_connection):
12944 (wait_reading_process_output, read_process_output):
12947 * process.c: Rename or move locals to avoid shadowing.
12948 (list_processes_1, Fmake_network_process):
12949 (read_process_output_error_handler, exec_sentinel_error_handler):
12950 Rename or move locals.
12951 (Fmake_network_process): Define label "retry_connect" only if needed.
12952 (Fnetwork_interface_info): Fix pointer signedness.
12953 (process_send_signal): Add cast to avoid pointer signedness problem.
12954 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
12955 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
12957 Make tparam.h and terminfo.c consistent.
12958 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12959 Include tparam.h instead, since it declares them.
12960 * cm.h (PC): Remove extern decl; tparam.h now does this.
12961 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12962 * terminfo.c: Include tparam.h, to check interfaces.
12963 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12964 (tparam): Adjust signature to match interface in tparam.h;
12965 this removes some undefined behavior. Check that outstring and len
12966 are zero, which they always are with Emacs.
12967 * tparam.h (PC, BC, UP): New extern decls.
12969 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
12970 (xftfont_open): Rename locals to avoid shadowing.
12972 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
12973 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12974 (OTF_TAG_SYM): Omit macro if not needed.
12975 (ftfont_list): Remove unused local.
12976 (get_adstyle_property, ftfont_pattern_entity):
12977 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12978 Rename locals to avoid shadowing.
12980 * xfont.c (xfont_list_family): Mark var as initialized.
12982 * xml.c (make_dom): Now static.
12984 * composite.c (composition_compute_stop_pos): Rename local to
12986 (composition_reseat_it): Remove unused locals.
12987 (find_automatic_composition, composition_adjust_point): Likewise.
12988 (composition_update_it): Mark var as initialized.
12989 (find_automatic_composition): Mark vars as initialized,
12990 with a FIXME (Bug#8290).
12992 character.h: Rename locals to avoid shadowing.
12993 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12994 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12995 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12996 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12997 to avoid shadowing.
12999 * textprop.c (property_change_between_p): Remove; unused.
13001 * intervals.c (interval_start_pos): Now static.
13003 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13005 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13006 Rename locals to avoid shadowing.
13008 * sound.c (wav_play, au_play, Fplay_sound_internal):
13009 Fix pointer signedness.
13010 (alsa_choose_format): Remove unused local var.
13011 (wav_play): Initialize a variable to 0, to prevent undefined
13012 behavior (Bug#8278).
13014 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13016 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13018 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13019 clobbering (Bug#8298).
13020 * sysdep.c (sys_subshell): Likewise.
13021 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
13023 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13024 This should get cleaned up, so that child_setup has the
13025 same signature on all platforms.
13027 * callproc.c (call_process_cleanup): Now static.
13028 (relocate_fd): Rename locals to avoid shadowing.
13030 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
13032 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13033 not to be necessary, and produces flickering.
13035 2011-03-20 Glenn Morris <rgm@gnu.org>
13037 * config.in: Remove file.
13039 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
13041 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13042 are now in src/globals.h.
13043 (syms_of_minibuf): Remove spurious & from previous change.
13045 2011-03-20 Leo Liu <sdl.web@gmail.com>
13047 * minibuf.c (completing-read-function): New variable.
13048 (completing-read-default): Rename from completing-read.
13049 (completing-read): Call completing-read-function.
13051 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13053 * xfaces.c (Fx_load_color_file):
13054 Read color file from absolute filename (bug#8250).
13056 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13058 * makefile.w32-in: Update dependencies.
13060 2011-03-17 Eli Zaretskii <eliz@gnu.org>
13062 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13064 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13066 Fix more problems found by GCC 4.5.2's static checks.
13068 * process.c (make_serial_process_unwind, send_process_trap):
13069 (sigchld_handler): Now static.
13071 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13072 That way, the code declares only the vars that it needs.
13073 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13074 * s/cygwin.h (PTY_ITERATION): Likewise.
13075 * s/darwin.h (PTY_ITERATION): Likewise.
13076 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13078 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13079 * process.c (allocate_pty): Don't declare stb unless it's needed.
13081 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
13082 (CONSTANTLIM): Remove; unused.
13083 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13084 Define only if needed.
13086 * unexelf.c (unexec): Name an expression,
13087 to avoid gcc -Wbad-function-cast warning.
13088 Use a different way to cause a compilation error if anyone uses
13089 n rather than nn, a way that does not involve shadowing.
13090 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
13092 * deps.mk (unexalpha.o): Remove; unused.
13094 New file unexec.h, the (simple) interface for unexec (Bug#8267).
13095 * unexec.h: New file.
13096 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13097 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13098 Depend on unexec.h.
13099 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13100 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13101 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
13102 Change as necessary to match prototype in unexec.h.
13104 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13106 (back_comment, skip_chars): Mark vars as initialized.
13108 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13109 Rename locals to avoid shadowing.
13111 * lread.c (read1): Rewrite so as not to use empty "else".
13112 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
13114 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13116 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13117 warning when compiling print.c.
13119 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13120 instead of using an uninitialized var.
13121 (font_sort_entities): Mark var as initialized.
13123 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13125 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13126 pointers to constants.
13127 (font_parse_fcname): Remove unused vars.
13128 (font_delete_unmatched): Now static.
13129 (font_get_spec): Remove; unused.
13130 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13131 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13132 Rename or move locals to avoid shadowing.
13134 * fns.c (require_nesting_list, require_unwind): Now static.
13135 (Ffillarray): Rename locals to avoid shadowing.
13137 * floatfns.c (domain_error2): Define only if needed.
13138 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
13140 * alloc.c (mark_backtrace): Move decl from here ...
13141 * lisp.h: ... to here, so that it can be checked.
13143 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
13144 (Fdefvar): Rewrite so as not to use empty "else".
13145 (lisp_indirect_variable): Name an expression,
13146 to avoid gcc -Wbad-function-cast warning.
13147 (Fdefvar): Rename locals to avoid shadowing.
13149 * callint.c (quotify_arg, quotify_args): Now static.
13150 (Fcall_interactively): Rename locals to avoid shadowing.
13151 Use const pointer when appropriate.
13153 * lisp.h (get_system_name, get_operating_system_release):
13154 Move decls here, to check interfaces.
13155 * process.c (get_operating_system_release): Move decl to lisp.h.
13156 * xrdb.c (get_system_name): Likewise.
13157 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13158 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13159 some of which prompt warnings from gcc -Wbad-function-cast.
13160 (Fformat_time_string, Fencode_time, Finsert_char):
13161 (Ftranslate_region_internal, Fformat):
13162 Rename or remove local vars to avoid shadowing.
13163 (Ftranslate_region_internal): Mark var as initialized.
13165 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13168 * lisp.h (eassert): Check that the argument compiles, even if
13169 ENABLE_CHECKING is not defined.
13171 * data.c (Findirect_variable): Name an expression, to avoid
13172 gcc -Wbad-function-cast warning.
13173 (default_value, arithcompare, arith_driver, arith_error): Now static.
13174 (store_symval_forwarding): Rename local to avoid shadowing.
13175 (Fmake_variable_buffer_local, Fmake_local_variable):
13176 Mark variables as initialized.
13177 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
13179 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
13180 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13181 Rename locals to avoid shadowing.
13182 (mark_stack): Move local variables into the #ifdef region where
13184 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13185 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13187 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13188 (GC_STRING_CHARS): Remove; not used.
13189 (Fmemory_limit): Cast sbrk's returned value to char *.
13191 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13192 avoids undefined behavior in theory.
13194 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13196 Use functions, not macros, for up- and down-casing (Bug#8254).
13197 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13198 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13199 to use the following functions instead of these macros.
13200 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13201 EMACS_INT, since callers assume the returned value fits in int.
13202 (upcase1): Likewise, for UPCASE_TABLE.
13203 (uppercasep, lowercasep, upcase): New static inline functions.
13204 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
13205 the race-condition problem in the old DOWNCASE.
13207 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13208 Rename locals to avoid shadowing.
13209 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
13210 (regex_compile, re_search_2, re_match_2_internal):
13211 Remove unused local vars.
13212 (FREE_VAR): Rewrite so as not to use empty "else",
13213 which gcc can warn about.
13214 (regex_compile, re_match_2_internal): Mark locals as initialized.
13215 (RETALLOC_IF): Define only if needed.
13216 (WORDCHAR_P): Likewise. This one is never needed, but is used
13217 only in a comment talking about a compiler bug, so put inside
13218 the #if 0 of that comment.
13219 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13220 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13223 * search.c (boyer_moore): Rename locals to avoid shadowing.
13224 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13225 (PREV_CHAR_BOUNDARY): Likewise.
13227 * search.c (simple_search): Remove unused var.
13229 * dired.c (compile_pattern): Move decl from here ...
13230 * lisp.h: ... to here, so that it can be checked.
13231 (struct re_registers): New forward decl.
13233 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13235 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13237 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13238 Rename locals to avoid shadowing.
13239 (Fvertical_motion): Mark locals as initialized.
13241 * casefiddle.c (casify_object, casify_region): Now static.
13242 (casify_region): Mark local as initialized.
13244 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13246 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13247 New macros, so that the caller can use some names other than
13248 gcpro1, gcpro2, etc.
13249 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13251 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13252 argument, for consistency with GCPRO2_VAR, etc: it is now the
13253 prefix of the variable, not the variable itself. All uses
13255 * dired.c (directory_files_internal, file_name_completion):
13256 Rename locals to avoid shadowing.
13258 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13259 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13260 dired.c's scmp function, had undefined behavior.
13261 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13262 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13263 * buffer.h: ... to here, because these macros use current_buffer,
13264 and the new implementation with inline functions needs to have
13265 current_buffer in scope now, rather than later when the macros
13267 (downcase, upcase1): New static inline functions.
13268 (DOWNCASE, UPCASE1): Reimplement using these functions.
13269 This avoids undefined behavior in expressions like
13270 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13271 from race conditions in accessing the global variables
13272 case_temp1 and case_temp2.
13273 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13274 * lisp.h (case_temp1, case_temp2): Remove their decls.
13275 * character.h (ASCII_CHAR_P): Move from here ...
13276 * lisp.h: ... to here, so that the inline functions mentioned
13277 above can use them.
13279 * dired.c (directory_files_internal_unwind): Now static.
13281 * fileio.c (file_name_as_directory, directory_file_name):
13282 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13284 (file_name_as_directory): Use const pointers when appropriate.
13285 (Fexpand_file_name): Likewise. In particular, newdir might
13286 point at constant storage, so make it a const pointer.
13287 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
13288 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13290 (Fset_file_times, Finsert_file_contents, auto_save_error):
13291 Rename locals to avoid shadowing.
13293 * minibuf.c (choose_minibuf_frame_1): Now static.
13294 (Ftry_completion, Fall_completions): Rename or remove locals
13295 to avoid shadowing.
13297 * marker.c (bytepos_to_charpos): Remove; unused.
13299 * lisp.h (verify_bytepos, count_markers): New decls,
13300 so that gcc does not warn that these functions aren't declared.
13302 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13303 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
13304 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
13305 (copy_text): Remove unused local var.
13307 * filelock.c (within_one_second): Now static.
13308 (lock_file_1): Rename local to avoid shadowing.
13310 * buffer.c (fix_overlays_before): Mark locals as initialized.
13311 (fix_start_end_in_overlays): Likewise. This function should be
13312 simplified by using pointers-to-pointers, but that's a different
13314 (switch_to_buffer_1): Now static.
13315 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13316 (report_overlay_modification): Rename locals to avoid shadowing.
13318 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
13319 Fix pointer signedness issue.
13320 (sys_subshell): Mark local as volatile if checking for lint,
13321 to suppress a gcc -Wclobbered warning that does not seem to be right.
13322 (MAXPATHLEN): Define only if needed.
13324 * process.c (serial_open, serial_configure): Move decls from here ...
13325 * systty.h: ... to here, so that they can be checked.
13327 * fns.c (get_random, seed_random): Move extern decls from here ...
13328 * lisp.h: ... to here, so that they can be checked.
13330 * sysdep.c (reset_io): Now static.
13331 (wait_for_termination_signal): Remove; unused.
13333 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13334 (copy_keymap_item, append_key, push_text_char_description):
13336 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
13337 (DENSE_TABLE_SIZE): Remove; unused.
13338 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13339 (describe_map_tree):
13340 Rename locals to avoid shadowing.
13342 * keyboard.c: Declare functions static if they are not used elsewhere.
13343 (echo_char, echo_dash, cmd_error, top_level_2):
13344 (poll_for_input, handle_async_input): Now static.
13345 (read_char, kbd_buffer_get_event, make_lispy_position):
13346 (make_lispy_event, make_lispy_movement, apply_modifiers):
13347 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13348 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13349 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
13350 (read_key_sequence, read_char): Mark locals as initialized.
13351 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
13353 * keyboard.h (make_ctrl_char): New decl.
13354 (mark_kboards): Move decl here ...
13355 * alloc.c (mark_kboards): ... from here.
13357 * lisp.h (force_auto_save_soon): New decl.
13359 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
13360 (DEFINE_DUMMY_FUNCTION): New macro.
13361 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13363 (main): Add casts to avoid warnings
13364 if GCC considers string literals to be constants.
13366 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13368 * dbusbind.c: Pointer signedness fixes.
13369 (xd_signature, xd_append_arg, xd_initialize):
13370 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13371 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13372 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13373 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13375 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13376 if GCC considers string literals to be constants.
13377 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
13379 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13381 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13382 (print_preprocess, print_object): New macro to fix last change.
13384 * print.c (print_preprocess): Don't forget font objects.
13386 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
13388 * emacs.c (USAGE3): Doc fixes.
13390 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13392 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13395 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
13397 * lisp.h (VWindow_system, Qfile_name_history):
13398 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13399 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13400 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13402 * w32select.c: Don't #include "keyboard.h".
13403 (run_protected): Add extern declaration for waiting_for_input.
13405 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13406 * w32console.c (detect_input_pending, read_input_pending)
13407 (encode_terminal_code):
13408 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13409 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13410 (w32_system_caret_y, Qfile_name_history):
13411 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13412 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13413 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13414 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13415 * w32proc.c (Qlocal, report_file_error):
13416 * w32term.c (Vwindow_system, updating_frame):
13417 * w32uniscribe.c (initialized, uniscribe_font_driver):
13418 Remove unneeded extern declarations.
13420 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
13422 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
13424 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
13426 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13427 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13428 These macros can no longer be used for assignment.
13430 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13431 Assign struct members directly, instead of using BUF_BEGV etc.
13432 (record_buffer_markers, fetch_buffer_markers): New functions for
13433 recording and fetching special buffer markers.
13434 (set_buffer_internal_1, set_buffer_temp): Use them.
13436 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13438 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13440 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13441 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13443 * xdisp.c (hscroll_window_tree):
13444 (reconsider_clip_changes): Use PT instead of BUF_PT.
13446 2011-03-13 Eli Zaretskii <eliz@gnu.org>
13448 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13449 $(EMACS_ROOT)/lib/intprops.h.
13451 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13453 Fix more problems found by GCC 4.5.2's static checks.
13455 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13456 to unsigned char * to avoid compiler diagnostic.
13457 (xg_free_frame_widgets): Make it clear that a local variable is
13458 needed only if USE_GTK_TOOLTIP.
13459 (gdk_window_get_screen): Make it clear that this macro is needed
13460 only if USE_GTK_TOOLTIP.
13461 (int_gtk_range_get_value): New function, which avoids a diagnostic
13462 from gcc -Wbad-function-cast.
13463 (xg_set_toolkit_scroll_bar_thumb): Use it.
13464 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13465 diagnostic from gcc -Wbad-function-cast.
13466 (get_utf8_string, xg_get_file_with_chooser):
13467 Rename locals to avoid shadowing.
13468 (create_dialog): Move locals to avoid shadowing.
13470 * xgselect.c (xg_select): Remove unused var.
13472 * image.c (four_corners_best): Mark locals as initialized.
13473 (gif_load): Initialize transparent_p to zero (Bug#8238).
13474 Mark another local as initialized.
13475 (my_png_error, my_error_exit): Mark with NO_RETURN.
13477 * image.c (clear_image_cache): Now static.
13478 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
13479 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
13480 (x_edge_detection): Remove unnecessary cast that
13481 gcc -Wbad-function-cast diagnoses.
13482 (gif_load): Fix pointer signedness.
13483 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13484 (jpeg_load, gif_load): Rename locals to avoid shadowing.
13486 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
13488 Improve quality of tests for time stamp overflow.
13489 For example, without this patch (encode-time 0 0 0 1 1
13490 1152921504606846976) returns the obviously-bogus value (-948597
13491 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13492 reports time overflow. See
13493 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
13494 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13495 * editfns.c: Include limits.h and intprops.h.
13496 (TIME_T_MIN, TIME_T_MAX): New macros.
13497 (time_overflow): Move earlier, to before first use.
13498 (hi_time, lo_time): New functions, for an accurate test for
13499 out-of-range times.
13500 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13501 (Fget_internal_run_time): Don't assume time_t fits in int.
13502 (make_time): Use list2 instead of Fcons twice.
13503 (Fdecode_time): More accurate test for out-of-range times.
13504 (check_tm_member): New function.
13505 (Fencode_time): Use it, to test for out-of-range times.
13506 (lisp_time_argument): Don't rely on undefined left-shift and
13507 right-shift behavior when checking for time stamp overflow.
13509 * editfns.c (time_overflow): New function, refactoring common code.
13510 (Fformat_time_string, Fdecode_time, Fencode_time):
13511 (Fcurrent_time_string): Use it.
13513 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13514 * dired.c (make_time): Move to ...
13515 * editfns.c (make_time): ... here.
13516 * systime.h: Note the move.
13518 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13520 * fringe.c (update_window_fringes): Remove unused variables.
13522 * unexmacosx.c (copy_data_segment): Also copy __got section.
13525 2011-03-12 Eli Zaretskii <eliz@gnu.org>
13527 * termcap.c [MSDOS]: Include "msdos.h".
13528 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13529 Constify `char *' arguments and their references according to
13530 prototypes in tparam.h.
13532 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
13534 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13535 Adapt all references accordingly.
13537 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13539 2011-03-11 Tom Tromey <tromey@redhat.com>
13541 * buffer.c (syms_of_buffer): Remove obsolete comment.
13543 2011-03-11 Eli Zaretskii <eliz@gnu.org>
13545 * termhooks.h (encode_terminal_code): Declare prototype.
13547 * msdos.c (encode_terminal_code): Don't declare prototype.
13549 * term.c (encode_terminal_code): Now external again, used by
13550 w32console.c and msdos.c.
13552 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13553 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
13555 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
13557 Fix some minor problems found by GCC 4.5.2's static checks.
13559 * fringe.c (update_window_fringes): Mark locals as initialized
13561 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
13563 * alloc.c (mark_fringe_data): Move decl from here ...
13564 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13565 to check its interface.
13566 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13568 * fontset.c (free_realized_fontset): Now static.
13569 (Fset_fontset_font): Rename local to avoid shadowing.
13570 (fontset_font): Mark local as initialized.
13571 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
13573 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13575 * xselect.c (x_disown_buffer_selections): Remove; not used.
13576 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
13577 (x_own_selection, Fx_disown_selection_internal): Rename locals
13578 to avoid shadowing.
13579 (x_handle_dnd_message): Remove local to avoid shadowing.
13581 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13582 so that the caller can use some name other than gcpro1.
13583 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
13584 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13585 (Fx_backspace_delete_keys_p):
13586 Use them to avoid shadowing, and rename vars to avoid shadowing.
13587 (x_decode_color, x_set_name, x_window): Now static.
13588 (Fx_create_frame): Add braces to silence GCC warning.
13589 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
13590 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13591 Remove unused locals.
13592 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13593 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13594 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13597 * xterm.h (x_mouse_leave): New decl.
13599 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13600 Remove unused functions.
13601 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13602 (x_calc_absolute_position): Now static.
13603 (XTread_socket): Don't define label "out" unless it's used.
13604 Don't declare local "event" unless it's used.
13605 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13606 unless they are used.
13607 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13608 (x_fatal_error_signal): Remove; not used.
13609 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13610 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13611 (x_error_catcher, x_connection_closed, x_error_handler):
13612 (x_error_quitter, xembed_send_message, x_iconify_frame):
13613 (my_log_handler): Rename locals to avoid shadowing.
13614 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
13615 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
13617 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13618 Rename or move locals to avoid shadowing.
13619 (tty_defined_color, merge_face_heights): Now static.
13620 (free_realized_faces_for_fontset): Remove; not used.
13621 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13622 does not deduce is never used uninitialized.
13623 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13624 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
13626 * terminal.c (store_terminal_param): Now static.
13628 * xmenu.c (menu_highlight_callback): Now static.
13629 (set_frame_menubar): Remove unused local.
13630 (xmenu_show): Rename parameter to avoid shadowing.
13631 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13632 since they might point to immutable storage.
13633 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13634 since it's unused otherwise.
13636 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
13637 Add a FIXME, since the code still doesn't look right. (Bug#8215)
13638 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13639 avoids a gcc -Wuninitialized diagnostic.
13640 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
13641 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13642 does not deduce are never used uninitialized.
13644 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13646 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
13647 * window.c (window_loop, size_window):
13648 (run_window_configuration_change_hook, enlarge_window): Likewise.
13650 * window.c (display_buffer): Now static.
13651 (size_window): Mark variables that gcc -Wuninitialized
13652 does not deduce are never used uninitialized.
13653 * window.h (check_all_windows): New decl, to forestall
13654 gcc -Wmissing-prototypes diagnostic.
13655 * dispextern.h (bidi_dump_cached_states): Likewise.
13657 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13659 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
13660 Include <limits.h>.
13661 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13662 and to avoid gcc -Wuninitialized warning.
13663 (load_charset_map): Mark variables that gcc -Wuninitialized
13664 does not deduce are never used uninitialized.
13665 (load_charset): Abort instead of using uninitialized var (Bug#8229).
13667 * coding.c (coding_set_source, coding_set_destination):
13668 Use "else { /* comment */ }" rather than "else /* comment */;"
13669 for clarity, and to avoid gcc -Wempty-body warning.
13670 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13671 a block, when the outer 'i' will do.
13672 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13673 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13674 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13675 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13676 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13677 Rename locals to avoid shadowing.
13678 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
13679 * coding.c (emacs_mule_char, encode_invocation_designation):
13680 Now static, since they're not used elsewhere.
13681 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
13682 (decode_coding_object, encode_coding_object, detect_coding_system):
13683 (decode_coding_emacs_mule): Mark variables that gcc
13684 -Wuninitialized does not deduce are never used uninitialized.
13685 (detect_coding_iso_2022): Initialize a local variable that might
13686 be used uninitialized. Leave a FIXME because it's not clear that
13687 this initialization is needed. (Bug#8211)
13688 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13689 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13690 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13691 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13692 Remove unused macros.
13694 * category.c (hash_get_category_set): Remove unused local var.
13695 (copy_category_table): Now static, since it's not used elsewhere.
13696 * character.c (string_count_byte8): Likewise.
13698 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13699 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13701 * chartab.c (copy_sub_char_table): Now static, since it's not used
13703 (sub_char_table_ref_and_range, char_table_ref_and_range):
13704 Rename locals to avoid shadowing.
13705 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
13707 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
13708 (BIDI_BOB): Remove unused macro.
13710 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13711 deduce are never used uninitialized.
13712 * term.c (encode_terminal_code): Likewise.
13714 * term.c (encode_terminal_code): Now static. Remove unused local.
13716 * tparam.h: New file.
13717 * term.c, tparam.h: Include it.
13718 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13719 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13720 Move these decls to tparam.h, and make them agree with what
13721 is actually in tparam.c. The previous trick of using incompatible
13722 decls in different modules does not conform to the C standard.
13723 All callers of tparam changed to use tparam's actual API.
13724 * tparam.c (tparam1, tparam, tgoto):
13725 Use const pointers where appropriate.
13727 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13728 * cm.h (struct cm): Likewise.
13729 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13730 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13731 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13732 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13733 (turn_on_face, init_tty): Likewise.
13734 * termchar.h (struct tty_display_info): Likewise.
13736 * term.c (term_mouse_position): Rename local to avoid shadowing.
13738 * alloc.c (mark_ttys): Move decl from here ...
13739 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13741 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13743 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13745 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
13747 * search.c (compile_pattern_1): Remove argument regp, unused since
13748 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13749 (compile_pattern): Don't pass it.
13751 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13753 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13754 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13756 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13758 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13760 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13761 gdk_window_get_screen, gdk_window_get_geometry,
13762 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13763 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13764 (xg_get_pixbuf_from_pixmap): New function.
13765 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13766 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13767 Call xg_get_pixbuf_from_pixmap instead of
13768 gdk_pixbuf_get_from_drawable.
13769 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13770 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13771 (xg_check_special_colors): Use GtkStyleContext and its functions
13773 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13774 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13775 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
13776 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13777 Call gtk_widget_get_preferred_size.
13778 (xg_frame_resized): gdk_window_get_geometry only takes 5
13780 (xg_win_to_widget, xg_event_is_for_menubar):
13781 Call gdk_x11_window_lookup_for_display.
13782 (xg_set_widget_bg): New function.
13783 (delete_cb): New function.
13784 (xg_create_frame_widgets): Connect delete-event to delete_cb.
13785 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
13786 (xg_set_background_color): Call xg_set_widget_bg.
13787 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13788 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13789 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13790 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13792 (update_frame_tool_bar): Call gtk_widget_hide.
13793 (xg_initialize): Use GDK_KEY_g.
13795 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13797 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13799 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13800 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13801 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13803 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13805 * w32xfns.c (select_palette): Check success of RealizePalette against
13806 GDI_ERROR, not zero.
13808 See ChangeLog.11 for earlier changes.
13810 ;; Local Variables:
13814 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13816 This file is part of GNU Emacs.
13818 GNU Emacs is free software: you can redistribute it and/or modify
13819 it under the terms of the GNU General Public License as published by
13820 the Free Software Foundation, either version 3 of the License, or
13821 (at your option) any later version.
13823 GNU Emacs is distributed in the hope that it will be useful,
13824 but WITHOUT ANY WARRANTY; without even the implied warranty of
13825 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13826 GNU General Public License for more details.
13828 You should have received a copy of the GNU General Public License
13829 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.
HCoop / bpt / emacs.git / blob