1 2012-01-17 Paul Eggert <eggert@cs.ucla.edu>
3 Fix integer width and related bugs (Bug#9874).
4 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
5 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
6 (string_bytes, check_sblock, allocate_string_data):
7 (compact_small_strings, Fmake_bool_vector, make_string)
8 (make_unibyte_string, make_multibyte_string)
9 (make_string_from_bytes, make_specified_string)
10 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
11 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
13 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
14 (allocate_pseudovector):
15 Use int, not EMACS_INT, where int is wide enough.
16 (inhibit_garbage_collection, Fgarbage_collect):
17 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
18 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
19 int might not be wide enough.
20 (bidi_cache_search, bidi_cache_find, bidi_init_it)
21 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
22 (bidi_at_paragraph_end, bidi_find_paragraph_start)
23 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
24 (bidi_level_of_next_char, bidi_move_to_visually_next):
25 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
26 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
27 (Fkill_buffer, Fset_buffer_major_mode)
28 (advance_to_char_boundary, Fbuffer_swap_text)
29 (Fset_buffer_multibyte, overlays_at, overlays_in)
30 (overlay_touches_p, struct sortvec, record_overlay_string)
31 (overlay_strings, recenter_overlay_lists)
32 (adjust_overlays_for_insert, adjust_overlays_for_delete)
33 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
34 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
35 (Foverlay_recenter, last_overlay_modification_hooks_used)
36 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
37 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
38 (validate_region): Omit unnecessary test for b <= e,
39 since that's guaranteed by the previous test.
40 (adjust_overlays_for_delete): Avoid pos + length overflow.
41 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
42 (report_overlay_modification):
43 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
44 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
45 Omit pointer cast, which isn't needed anyway, and doesn't work
46 after the EMACS_INT -> ptrdiff_t change.
47 (Fmove_overlay): Delete an evaporating overlay
48 if it becomes empty after its bounds are adjusted to fit within
49 its buffer. Without this fix, in a nonempty buffer (let ((o
50 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
51 yields an empty overlay that has the evaporate property, which is
52 not supposed to happen. (Bug#9642)
53 * buffer.h: Adjust decls to match defn changes elsewhere.
54 (struct buffer_text, struct buffer):
55 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
56 Use EMACS_INT, not int, where int might not be wide enough.
57 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
58 not int, to avoid needless 32-bit limit on 64-bit hosts.
59 (exec_byte_code): Use tighter memory-full test, one that checks
60 for alloca overflow. Don't compute the address of the object just
61 before an array, as that's not portable. Use EMACS_INT, not
62 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
63 * callint.c (Fcall_interactively):
64 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
65 * callproc.c (call_process_kill, Fcall_process):
66 Don't assume pid_t fits into an Emacs fixnum.
67 (call_process_cleanup, Fcall_process, child_setup):
68 Don't assume pid_t fits into int.
69 (call_process_cleanup, Fcall_process, delete_temp_file)
70 (Fcall_process_region):
71 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
72 (Fcall_process): Simplify handling of volatile integers.
73 Use int, not EMACS_INT, where int will do.
74 * casefiddle.c (casify_object, casify_region, operate_on_word)
75 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
76 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
77 (casify_object): Avoid integer overflow when overallocating buffer.
78 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
79 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
80 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
81 * category.h (CATEGORYP): Don't assume arg is nonnegative.
82 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
83 integers are now checked earlier. All uses replaced with XINT.
85 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
86 For CCL_MapSingle, check that content and value are in int range.
87 (ccl_driver, Fregister_code_conversion_map):
88 Check that Vcode_version_map_vector is a vector.
89 (resolve_symbol_ccl_program): Check that vector header is in range.
90 Always copy the vector, so that we can check its contents reliably
91 now rather than having to recheck each instruction as it's being
92 executed. Check that vector words fit in 'int'.
93 (ccl_get_compiled_code, Fregister_ccl_program)
94 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
95 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
96 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
97 contents are in range.
98 (Fccl_execute_on_string): Check that status is in range.
99 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
100 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
101 Accept and return EMACS_INT, not int, because callers can pass values
103 (c_string_width, strwidth, lisp_string_width, chars_in_text)
104 (multibyte_chars_in_text, parse_str_as_multibyte)
105 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
106 (str_as_unibyte, str_to_unibyte, string_count_byte8)
107 (string_escape_byte8, Fget_byte):
108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
109 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
110 avoid mishandling large integers.
111 * character.h: Adjust decls to match defn changes elsewhere.
112 * charset.c (load_charset_map_from_file, find_charsets_in_text)
113 (Ffind_charset_region):
114 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
115 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
116 (load_charset_map_from_vector, Fdefine_charset_internal):
117 Don't assume fixnum fits in int.
118 (load_charset_map_from_vector, Fmap_charset_chars):
119 Remove now-unnecessary CHECK_NATNUMs.
120 (Fdefine_charset_internal): Check ranges here, more carefully.
121 Don't rely on undefined behavior with signed left shift overflow.
122 Don't assume unsigned int fits into fixnum, or that fixnum fits
123 into unsigned int. Don't require max_code to be a valid fixnum;
124 that's not true for gb10830 4-byte on a 32-bit host. Allow
125 invalid_code to be a cons, for the same reason. Require code_offset
126 to be a character. Avoid int overflow if max_char is close
128 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
129 this is intended anyway and avoids some undefined behavior.
130 (load_charset_map): Pass unsigned, not int, as 2nd arg of
131 INDEX_TO_CODE_POINT, as that's what it expects.
132 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
133 * charset.h (DECODE_CHAR): Return int, not unsigned;
134 this is what was intended anyway, and it avoids undefined behavior.
135 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
136 integer-overflow issues.
137 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
138 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
139 where the argument is EMACS_INT, and this behavior is not intended.
140 * chartab.c (Fmake_char_table, Fset_char_table_range)
141 (uniprop_get_decoder, uniprop_get_encoder):
142 Don't assume fixnum fits in int.
143 * cmds.c (move_point): New function, that does the gist of
144 Fforward_char and Fbackward_char, but does so while checking
145 for integer overflow more accurately.
146 (Fforward_char, Fbackward_char): Use it.
147 (Fforward_line, Fend_of_line, internal_self_insert)
148 (internal_self_insert):
149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
150 Fix a FIXME, by checking for integer overflow when calculating
151 target_clm and actual_clm.
152 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
153 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
154 (ASSURE_DESTINATION, coding_alloc_by_realloc)
155 (coding_alloc_by_making_gap, alloc_destination)
156 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
157 (encode_coding_utf_16, detect_coding_emacs_mule)
158 (decode_coding_emacs_mule, encode_coding_emacs_mule)
159 (detect_coding_iso_2022, decode_coding_iso_2022)
160 (encode_invocation_designation, encode_designation_at_bol)
161 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
162 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
163 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
164 (encode_coding_ccl, encode_coding_raw_text)
165 (detect_coding_charset, decode_coding_charset)
166 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
167 (produce_composition, produce_charset, produce_annotation)
168 (decode_coding, handle_composition_annotation)
169 (handle_charset_annotation, consume_chars, decode_coding_gap)
170 (decode_coding_object, encode_coding_object, detect_coding_system)
171 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
172 (code_convert_region, code_convert_string)
173 (Fdefine_coding_system_internal)
174 (coding_set_source, coding_set_destination):
175 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
176 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
177 (Fdefine_coding_system_internal):
178 Don't assume fixnums fit in int.
179 (decode_coding_gap, decode_coding_object, encode_coding_object)
180 (Fread_coding_system, Fdetect_coding_region)
181 (Funencodable_char_position, Fcheck_coding_systems_region)
182 (get_translation, handle_composition_annotation, consume_chars):
183 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
184 (consume_chars): Rewrite to not calculate an address outside buffer.
185 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
186 Don't access memory outside of the args array.
187 (Fdefine_coding_system_internal): Check for charset-id overflow.
188 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
189 result of ENCODE_CHAR.
190 * coding.h: Adjust decls to match defn changes elsewhere.
191 (struct coding_system):
192 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
193 * composite.c (get_composition_id, find_composition)
194 (run_composition_function, update_compositions)
195 (compose_text, composition_gstring_put_cache)
196 (composition_gstring_p, composition_gstring_width)
197 (fill_gstring_header, fill_gstring_body, autocmp_chars)
198 (composition_compute_stop_pos, composition_reseat_it)
199 (composition_update_it, struct position_record)
200 (find_automatic_composition, composition_adjust_point)
201 (Fcomposition_get_gstring, Ffind_composition_internal):
202 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
203 (update_compositions):
204 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
205 * composite.h: Adjust decls to match defn changes elsewhere.
206 (struct composition):
207 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
208 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
209 Do not attempt to compute the address of the object just before a
210 buffer; this is not portable.
212 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
213 (Faset): Use int, not EMACS_INT, where int is wide enough.
214 (Fstring_to_number): Don't assume fixnums fit in int.
215 (Frem): Don't assume arg is nonnegative.
216 * dbusbind.c (xd_append_arg): Check for integers out of range.
217 (Fdbus_call_method): Don't overflow the timeout int.
218 * dired.c (directory_files_internal, file_name_completion, scmp)
219 (file_name_completion_stat):
220 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
221 (file_name_completion): Don't overflow matchcount.
222 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
223 * dispextern.h: Adjust decls to match defn changes elsewhere.
224 (struct text_pos, struct glyph, struct bidi_saved_info)
225 (struct bidi_string_data, struct bidi_it, struct composition_it)
227 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
228 (struct display_pos, struct composition_it, struct it):
229 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
230 * dispnew.c (increment_matrix_positions)
231 (increment_row_positions, mode_line_string)
232 (marginal_area_string):
233 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
234 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
235 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
236 (duration_to_sec_usec): New function, to check for overflow better.
237 (Fsleep_for, sit_for): Use it.
238 * doc.c (get_doc_string, store_function_docstring):
239 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
240 (get_doc_string, Fsnarf_documentation):
241 Use int, not EMACS_INT, where int is wide enough.
243 Use SAFE_ALLOCA, not alloca.
244 Check for overflow when converting EMACS_INT to off_t.
246 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
247 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
248 Don't assume uid_t fits into fixnum.
249 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
250 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
251 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
252 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
253 (general_insert_function)
254 (Finsert_char, make_buffer_string, make_buffer_string_both)
255 (update_buffer_properties, Fbuffer_substring)
256 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
257 (Fsubst_char_in_region, check_translation)
258 (Ftranslate_region_internal, save_restriction_restore, Fformat)
259 (transpose_markers, Ftranspose_regions):
260 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
261 (clip_to_bounds): Move to lisp.h as an inline function).
262 (Fconstrain_to_field): Don't assume integers are nonnegative.
263 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
264 (Fsubst_char_in_region, Fsave_restriction):
265 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
266 (Femacs_pid): Don't assume pid_t fits into fixnum.
267 (lo_time): Use int, not EMACS_INT, when int suffices.
268 (lisp_time_argument): Check for usec out of range.
269 (Fencode_time): Don't assume fixnum fits in int.
270 (Fuser_login_name, Fuser_full_name): Signal an error
271 if a uid argument is out of range, rather than relying on
273 (Fformat_time_string): Remove now-unnecessary check.
274 lisp_time_argument checks for out-of-range usec now.
275 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
276 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
277 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
278 (init_cmdargs, Fdump_emacs):
279 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
280 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
281 the bottom (typically) 32 bits of the fixnum.
282 * eval.c (specpdl_size, call_debugger):
283 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
284 (when_entered_debugger, Fbacktrace_debug):
285 Don't assume fixnum can fit in int.
286 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
287 the object just before a buffer; this is not portable.
288 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
289 (grow_specpdl, unbind_to):
290 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
291 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
292 (grow_specpdl): Simplify allocation by using xpalloc.
293 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
294 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
295 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
296 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
297 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
299 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
300 (Fcopy_file, non_regular_nbytes, read_non_regular)
301 (Finsert_file_contents):
302 Use int, not EMACS_INT, where int is wide enough.
303 (READ_BUF_SIZE): Verify that it fits in int.
304 (Finsert_file_contents): Check that counts are in proper range,
305 rather than assuming fixnums fit into ptrdiff_t etc.
306 Don't assume fixnums fit into int.
307 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
308 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
309 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
310 (string_char_to_byte, string_byte_to_char)
311 (string_make_multibyte, string_to_multibyte)
312 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
313 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
314 (substring_both, Fdelete, internal_equal, Ffillarray)
315 (Fclear_string, mapcar1)
316 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
317 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
318 (larger_vector, make_hash_table, maybe_resize_hash_table)
319 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
320 (Fmaphash, secure_hash):
321 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
322 (concat): Check for string index and length overflow.
323 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
325 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
326 (larger_vector): New API (vec, incr_min, size_max) replaces old
327 one (vec, new_size, init). This catches size overflow.
328 INIT was removed because it was always Qnil.
330 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
331 the upper bound on a hash table index size.
332 (make_hash_table, maybe_resize_hash_table): Use it.
333 (secure_hash): Computer start_byte and end_byte only after
334 they're known to be in ptrdiff_t range.
335 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
336 (Ffont_get_glyphs, Ffont_at):
337 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
338 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
339 (Flist_fonts, Fopen_font):
340 Don't assume fixnum can fit in int.
341 (check_gstring): Don't assume index can fit in int.
342 (font_match_p): Check that fixnum is a character, not a nonnegative
343 fixnum, since the later code needs to stuff it into an int.
344 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
345 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
346 conversion overflow issues.
347 (Fopen_font): Check for integer out of range.
348 (Ffont_get_glyphs): Don't assume index can fit in int.
349 * font.h: Adjust decls to match defn changes elsewhere.
350 * fontset.c (reorder_font_vector): Redo score calculation to avoid
352 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
353 printmax_t, where ptrdiff_t is wide enough.
354 (Finternal_char_font):
355 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
356 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
357 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
358 (Fset_frame_position, x_set_frame_parameters)
359 (x_set_line_spacing, x_set_border_width)
360 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
361 Check that fixnums are in proper range for system types.
362 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
363 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
364 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
365 Use SAFE_ALLOCA_LISP, not alloca.
366 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
367 intptr_t is wide enough.
368 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
369 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
370 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
371 Check for fixnum out of range.
372 * ftfont.c (ftfont_list): Don't assume index fits in int.
373 Check that fixnums are in proper range for system types.
374 (ftfont_shape_by_flt):
375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
376 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
377 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
378 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
379 Check that fixnums are in proper range for system types.
380 * gnutls.h: Adjust decls to match defn changes elsewhere.
381 * gtkutil.c (xg_dialog_run):
382 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
383 (update_frame_tool_bar):
384 Check that fixnums are in proper range for system types.
385 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
386 (lookup_image): Check that fixnums are in range for system types.
387 * indent.c (last_known_column, last_known_column_point):
388 (current_column_bol_cache):
389 (skip_invisible, current_column, check_display_width):
390 (check_display_width, scan_for_column, current_column_1)
391 (Findent_to, Fcurrent_indentation, position_indentation)
392 (indented_beyond_p, Fmove_to_column, compute_motion):
393 (Fcompute_motion, Fvertical_motion):
394 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
395 (last_known_column_modified): Use EMACS_INT, not int.
396 (check_display_width):
398 Check that fixnums and floats are in proper range for system types.
399 (compute_motion): Don't assume index or fixnum fits in int.
400 (compute_motion, Fcompute_motion):
401 Use int, not EMACS_INT, when it is wide enough.
402 (vmotion): Omit local var start_hpos that is always 0; that way
403 we don't need to worry about overflow in expressions involving it.
404 * indent.h: Adjust decls to match defn changes elsewhere.
406 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
407 Use int, not EMACS_INT, where int is wide enough.
408 Remove unused members ovstring_chars_done and tab_offset;
410 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
411 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
412 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
413 (make_gap, copy_text, insert, insert_and_inherit)
414 (insert_before_markers, insert_before_markers_and_inherit)
415 (insert_1, count_combining_before, count_combining_after)
416 (insert_1_both, insert_from_string)
417 (insert_from_string_before_markers, insert_from_string_1)
418 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
419 (adjust_after_replace, adjust_after_insert, replace_range)
420 (replace_range_2, del_range, del_range_1, del_range_byte)
421 (del_range_both, del_range_2, modify_region)
422 (prepare_to_modify_buffer, signal_before_change)
423 (signal_after_change, Fcombine_after_change_execute):
424 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
425 * intervals.c (traverse_intervals, rotate_right, rotate_left)
426 (balance_an_interval, split_interval_right, split_interval_left)
427 (find_interval, next_interval, update_interval)
428 (adjust_intervals_for_insertion, delete_node, delete_interval)
429 (interval_deletion_adjustment, adjust_intervals_for_deletion)
430 (static_offset_intervals, offset_intervals)
431 (merge_interval_right, merge_interval_left, make_new_interval)
432 (graft_intervals_into_buffer, temp_set_point_both)
433 (temp_set_point, set_point, adjust_for_invis_intang)
434 (set_point_both, move_if_not_intangible, get_property_and_range)
435 (get_local_map, copy_intervals, copy_intervals_to_string)
436 (compare_string_intervals, set_intervals_multibyte_1):
437 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
438 * intervals.h: Adjust decls to match defn changes elsewhere.
440 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
441 * keyboard.c (this_command_key_count, this_single_command_key_start)
442 (before_command_key_count, before_command_echo_length, echo_now)
443 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
444 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
445 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
446 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
447 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
448 (last_non_minibuf_size, last_point_position, echo_truncate)
449 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
450 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
451 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
452 (stuff_buffered_input):
453 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
454 (last_auto_save, command_loop_1, read_char):
455 Use EMACS_INT, not int, to avoid integer overflow.
456 (record_char): Avoid overflow in total_keys computation.
457 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
458 * keyboard.h: Adjust decls to match defn changes elsewhere.
459 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
460 (Fkey_description, Fdescribe_vector, Flookup_key):
461 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
462 (click_position): New function, to check that positions are in range.
463 (Fcurrent_active_maps):
465 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
466 (Faccessible_keymaps, Fkey_description):
467 (preferred_sequence_p):
468 Don't assume fixnum can fit into int.
469 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
470 Check for integer overflow in size calculations.
471 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
472 avoid mishandling large integers.
473 * lisp.h: Adjust decls to match defn changes elsewhere.
474 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
475 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
476 (struct Lisp_Marker):
477 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
478 (clip_to_bounds): Now an inline function, moved here from editfns.c.
479 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
480 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
482 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
483 Assume the arg has valid form, since it always does.
484 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
485 unsigned integer system type.
486 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
487 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
488 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
489 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
490 (duration_to_sec_usec): New decl.
491 * lread.c (read_from_string_index, read_from_string_index_byte)
492 (read_from_string_limit, readchar, unreadchar, openp)
493 (read_internal_start, read1, oblookup):
494 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
495 (Fload, readevalloop, Feval_buffer, Feval_region):
496 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
497 (openp): Check for out-of-range argument to 'access'.
498 (read1): Use int, not EMACS_INT, where int is wide enough.
499 Don't assume fixnum fits into int.
500 Fix off-by-one error that can read outside a buffer.
501 (read_filtered_event): Use duration_to_sec_usec
502 to do proper overflow checking on durations.
503 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
505 (Fexecute_kbd_macro):
506 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
507 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
508 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
509 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
510 (set_marker_both, set_marker_restricted_both, marker_position)
511 (marker_byte_position, Fbuffer_has_markers_at):
512 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
513 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
514 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
515 It now merely ensures that the menu is large enough, without
516 necessarily growing it, as this avoids some integer overflow issues.
518 (keymap_panes, parse_single_submenu, Fx_popup_menu):
519 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
520 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
521 Use SAFE_ALLOCA_LISP, not alloca.
522 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
523 to EMACS_INT. Check that fixnums are in proper range for system types.
524 * minibuf.c (minibuf_prompt_width, string_to_object)
525 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
526 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
527 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
528 (get_minibuffer, read_minibuf_unwind):
529 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
530 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
531 this simplifies overflow checking. All callers changed.
532 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
534 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
535 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
536 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
537 Check that fixnums are in proper range for system types.
538 (Fx_create_frame, Fx_show_tip):
539 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
540 * nsfont.m (ns_findfonts, nsfont_list_family):
541 Don't assume fixnum fits in long.
542 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
543 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
544 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
546 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
547 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
548 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
549 (PRINTDECLARE, PRINTPREPARE):
550 (strout, print_string):
551 (print, print_preprocess, print_check_string_charset_prop)
553 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
555 (temp_output_buffer_setup, Fprin1_to_string, print_object):
556 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
557 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
558 (printchar, strout): Use xpalloc to catch size calculation overflow.
559 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
560 (print_error_message): Use SAFE_ALLOCA, not alloca.
561 (print_object): Use int, not EMACS_INT, where int is wide enough.
562 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
563 (Fset_process_window_size, Fformat_network_address)
564 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
566 Check that fixnums are in proper range for system types.
567 (Fsignal_process): Simplify by avoiding a goto.
568 Check for process-ids out of pid_t range rather than relying on
570 (Fformat_network_address, read_process_output, send_process)
571 (Fprocess_send_region, status_notify):
572 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
573 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
574 (wait_reading_process_output, read_process_output, exec_sentinel):
575 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
576 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
577 (Faccept_process_output): Use duration_to_sec_usec to do proper
578 overflow checking on durations.
579 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
580 Don't assume pid_t fits in int.
581 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
582 configured --with-wide-int.
583 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
584 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
585 * search.c (looking_at_1, string_match_1):
586 (fast_string_match, fast_c_string_match_ignore_case)
587 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
588 (scan_newline, find_before_next_newline, search_command)
589 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
590 (set_search_regs, wordify):
593 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
594 (string_match_1, search_buffer, set_search_regs):
596 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
597 (wordify): Check for overflow in size calculation.
598 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
599 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
600 Check that fixnums are in proper range for system types.
601 * sound.c (struct sound_device)
602 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
603 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
604 (Fplay_sound_internal):
605 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
606 * syntax.c (struct lisp_parse_state, find_start_modiff)
607 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
608 (Fparse_partial_sexp):
609 Don't assume fixnums can fit in int.
610 (struct lisp_parse_state, find_start_pos, find_start_value)
611 (find_start_value_byte, find_start_begv)
612 (update_syntax_table, char_quoted, dec_bytepos)
613 (find_defun_start, prev_char_comend_first, back_comment):
614 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
615 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
616 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
617 (Finternal_describe_syntax_value): Check that match_lisp is a
618 character, not an integer, since the code stuffs it into int.
619 (scan_words, scan_sexps_forward):
620 Check that fixnums are in proper range for system types.
622 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
623 (scan_sexps_forward):
624 Use CHARACTERP, not INTEGERP, since the value must fit into int.
625 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
626 * syntax.h: Adjust decls to match defn changes elsewhere.
628 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
629 * sysdep.c (wait_for_termination_1, wait_for_termination)
630 (interruptible_wait_for_termination, mkdir):
631 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
632 (emacs_read, emacs_write):
633 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
634 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
635 and double all fit in int.
636 * term.c (set_tty_color_mode):
637 Check that fixnums are in proper range for system types.
638 * termhooks.h (struct input_event):
639 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
640 * textprop.c (validate_interval_range, interval_of)
641 (Fadd_text_properties, set_text_properties_1)
642 (Fremove_text_properties, Fremove_list_of_text_properties)
643 (Ftext_property_any, Ftext_property_not_all)
644 (copy_text_properties, text_property_list, extend_property_ranges)
645 (verify_interval_modification):
646 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
647 (Fnext_single_char_property_change)
648 (Fprevious_single_char_property_change):
649 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
650 (copy_text_properties):
651 Check for integer overflow in index calculation.
652 * undo.c (last_boundary_position, record_point, record_insert)
653 (record_delete, record_marker_adjustment, record_change)
654 (record_property_change):
655 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
656 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
657 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
658 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
659 (Fx_hide_tip, Fx_file_dialog):
660 * w32menu.c (set_frame_menubar):
661 Use ptrdiff_t, not int, for consistency with rest of code.
662 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
663 (select_window, Fdelete_other_windows_internal)
664 (window_scroll_pixel_based, window_scroll_line_based)
665 (Frecenter, Fset_window_configuration):
666 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
667 (Fset_window_hscroll, run_window_configuration_change_hook)
668 (set_window_buffer, temp_output_buffer_show, scroll_command)
669 (Fscroll_other_window, Frecenter):
670 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
671 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
672 Don't assume fixnum fits in int.
673 (Fset_window_scroll_bars):
674 Check that fixnums are in proper range for system types.
675 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
676 (string_pos, c_string_pos, number_of_chars, init_iterator)
677 (in_ellipses_for_invisible_text_p, init_from_display_pos)
678 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
679 (compute_display_string_end, handle_face_prop)
680 (face_before_or_after_it_pos, handle_invisible_prop)
681 (handle_display_prop, handle_display_spec, handle_single_display_spec)
682 (display_prop_intangible_p, string_buffer_position_lim)
683 (string_buffer_position, handle_composition_prop, load_overlay_strings)
684 (get_overlay_strings_1, get_overlay_strings)
685 (iterate_out_of_display_property, forward_to_next_line_start)
686 (back_to_previous_visible_line_start, reseat, reseat_to_string)
687 (get_next_display_element, set_iterator_to_next)
688 (get_visually_first_element, compute_stop_pos_backwards)
689 (handle_stop_backwards, next_element_from_buffer)
690 (move_it_in_display_line_to, move_it_in_display_line)
691 (move_it_to, move_it_vertically_backward, move_it_by_lines)
692 (add_to_log, message_dolog, message_log_check_duplicate)
693 (message2, message2_nolog, message3, message3_nolog
694 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
695 (current_message_1, truncate_echo_area, truncate_message_1)
696 (set_message, set_message_1, store_mode_line_noprop)
697 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
698 (text_outside_line_unchanged_p, check_point_in_composition)
699 (reconsider_clip_changes)
700 (redisplay_internal, set_cursor_from_row, try_scrolling)
701 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
702 (redisplay_window, find_last_unchanged_at_beg_row)
703 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
704 (trailing_whitespace_p, find_row_edges, display_line)
705 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
706 (display_mode_element, store_mode_line_string)
707 (pint2str, pint2hrstr, decode_mode_spec)
708 (display_count_lines, display_string, draw_glyphs)
709 (x_produce_glyphs, x_insert_glyphs)
710 (rows_from_pos_range, mouse_face_from_buffer_pos)
711 (fast_find_string_pos, mouse_face_from_string_pos)
712 (note_mode_line_or_margin_highlight, note_mouse_highlight):
713 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
714 (safe_call, init_from_display_pos, handle_fontified_prop)
715 (handle_single_display_spec, load_overlay_strings)
716 (with_echo_area_buffer, setup_echo_area_for_printing)
717 (display_echo_area, echo_area_display)
718 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
719 (update_tool_bar, hscroll_window_tree, redisplay_internal)
720 (redisplay_window, dump_glyph_row, display_mode_line)
721 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
722 (handle_display_spec, display_prop_string_p):
723 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
724 (handle_single_display_spec, build_desired_tool_bar_string)
725 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
726 (get_specified_cursor_type):
727 Check that fixnums are in proper range for system types.
728 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
730 Don't assume fixnums fit in int.
731 (compare_overlay_entries):
732 Avoid mishandling comparisons due to subtraction overflow.
733 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
734 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
735 (handle_tool_bar_click):
736 Use int, not unsigned, since we prefer signed and the signedness
738 (get_next_display_element, next_element_from_display_vector):
739 Use int, not EMACS_INT, when int is wide enough.
740 (start_hourglass): Use duration_to_sec_usec to do proper
741 overflow checking on durations.
742 * xfaces.c (Fbitmap_spec_p):
743 Check that fixnums are in proper range for system types.
744 (compare_fonts_by_sort_order):
745 Avoid mishandling comparisons due to subtraction overflow.
746 (Fx_family_fonts, realize_basic_faces):
747 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
749 Don't assume fixnum fits in int.
750 Use SAFE_ALLOCA_LISP, not alloca.
751 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
752 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
753 (face_at_buffer_position, face_for_overlay_string)
754 (face_at_string_position):
755 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
756 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
757 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
759 Check that fixnums are in proper range for system types.
760 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
761 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
762 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
763 (Fx_change_window_property): Don't assume fixnums fit in int.
764 * xfont.c (xfont_chars_supported):
765 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
766 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
767 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
768 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
769 * xml.c (parse_region):
770 * xrdb.c (magic_file_p):
771 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
772 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
773 (x_get_local_selection, x_reply_selection_request)
774 (x_handle_selection_request, wait_for_property_change):
775 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
776 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
777 short is wide enough.
778 (x_send_client_event): Don't assume fixnum fits in int.
779 * xterm.c (x_x_to_emacs_modifiers):
780 Don't assume EMACS_INT overflows nicely into int.
781 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
783 (handle_one_xevent): NATNUMP can eval its arg twice.
784 (x_connection_closed):
785 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
786 * xterm.h: Adjust decls to match defn changes elsewhere.
787 (struct scroll_bar): Use struct vectorlike_header
788 rather than rolling our own approximation.
789 (SCROLL_BAR_VEC_SIZE): Remove; not used.
791 2012-01-16 Martin Rudalics <rudalics@gmx.at>
793 * window.c (Vwindow_persistent_parameters): New variable.
794 (Fset_window_configuration, save_window_save): Handle persistent
797 2012-01-14 Eli Zaretskii <eliz@gnu.org>
799 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
800 thrashing the stack of the thread. (Bug#9087)
802 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
804 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
806 2012-01-11 Eli Zaretskii <eliz@gnu.org>
808 * xdisp.c (rows_from_pos_range): Handle the case where the
809 highlight ends on a newline. (Bug#10464)
810 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
811 he end column for display of highlight that ends on a newline
814 2012-01-11 Glenn Morris <rgm@gnu.org>
816 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
817 from load-path also when installation-directory is nil. (Bug#10208)
819 2012-01-10 Glenn Morris <rgm@gnu.org>
821 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
823 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
824 Update template values to be closer to their typical values these days.
826 2012-01-09 Eli Zaretskii <eliz@gnu.org>
828 * xdisp.c (rows_from_pos_range): Accept additional argument
829 DISP_STRING, and accept any glyph in a row whose object is that
830 string as eligible for mouse highlight. Fixes mouse highlight of
831 display strings from overlays. (Bug#10464)
833 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
835 emacs: fix an auto-save permissions race condition (Bug#10400)
836 * fileio.c (auto_saving_dir_umask): New static var.
837 (Fmake_directory_internal): Use it.
838 (do_auto_save_make_dir): Set it, instead of invoking chmod after
839 creating the directory. The old code temporarily assigns
840 too-generous permissions to the directory.
841 (do_auto_save_eh): Clear it.
842 (Fdo_auto_save): Catch all errors, not just file errors, so
843 that the var is always cleared.
845 2012-01-07 Eli Zaretskii <eliz@gnu.org>
847 * search.c (scan_buffer): Pass character positions to
848 know_region_cache, not byte positions. (Bug#6540)
850 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
852 * w32.c (sys_rename): Report EXDEV when rename of a directory
853 fails because the target is on another logical disk. (Bug#10284)
855 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
857 * xterm.c (x_embed_request_focus): New function.
859 * xterm.h: Add prototype.
861 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
863 2012-01-05 Glenn Morris <rgm@gnu.org>
865 * emacs.c (emacs_copyright): Update short copyright year to 2012.
867 2012-01-01 Eli Zaretskii <eliz@gnu.org>
869 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
870 Load gnutls_transport_set_lowat only if GnuTLS version is below
872 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
873 GnuTLS versions below 2.11.1.
875 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
877 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
878 to the doc string advising against its use for altering the way
879 windows are scrolled.
881 2011-12-28 Kenichi Handa <handa@m17n.org>
883 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
884 coding-system ASCII compatible only when it does not produce BOM
885 on encoding (Bug#10383).
887 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
889 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
891 (create_and_show_popup_menu): Always use menu_position_func for
894 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
896 * callint.c (Fcall_interactively): Don't truncate prompt string.
898 2011-12-23 Eli Zaretskii <eliz@gnu.org>
900 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
901 property that ends at ZV, so that the bidi iteration could be
902 resumed from there (after widening). (Bug#10360)
904 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
906 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
908 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
910 * nsterm.m (x_free_frame_resources):
911 Release f->output_data.ns->miniimage.
912 (ns_index_color): Fix indentation. Do not retain
913 color_table->colors[i].
915 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
918 * nsfns.m (x_set_background_color): Assign return value from
919 ns_index_color to face-background instead of NSColor*.
920 (ns_implicitly_set_icon_type): Fix indentation.
921 Change assignment in for loop to comparison.
923 * emacs.c (ns_pool): New variable.
924 (main): Assign ns_pool.
925 (Fkill_emacs): Call ns_release_autorelease_pool.
927 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
928 autorelease fdesc, release fdAttrs and tdict.
929 (ns_get_covering_families): Release charset.
930 (ns_findfonts): Release NSFontDescriptor created with new.
931 (ns_uni_to_glyphs): Fix indentation.
932 (setString): Release attrStr before assigning new value.
934 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
936 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
938 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
939 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
941 2011-12-18 David Reitter <reitter@cmu.edu>
943 * nsterm.m (ns_term_init): Subscribe for notifications
944 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
945 to method trackingNotification in EmacsMenu.
947 * nsmenu.m (trackingMenu): New variable.
948 (trackingNotification): New method (from Aquamacs).
949 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
950 from Aquamacs (Bug#7030).
952 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
954 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
955 (symbol_to_nsstring): Fix indentation.
956 (ns_symbol_to_pb): New function.
957 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
958 (Fns_rotate_cut_buffers_internal): Removed.
959 (Fns_store_selection_internal): Renamed from
960 Fns_store_cut_buffer_internal.
961 (ns_get_foreign_selection, Fx_own_selection_internal)
962 (Fx_disown_selection_internal, Fx_selection_exists_p)
963 (Fns_get_selection_internal, Fns_store_selection_internal):
964 Use ns_symbol_to_pb and check if return value is nil.
965 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
966 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
967 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
968 renamed to Sns_store_selection_internal.
969 (ns_handle_selection_request): Move code to Fx_own_selection_internal
970 and remove this function.
971 (ns_handle_selection_clear): Remove, never used.
972 (Fx_own_selection_internal): Move code from ns_handle_selection_request
975 2011-12-17 Ken Brown <kbrown@cornell.edu>
977 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
978 GID is unknown (Bug#10257).
980 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
982 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
983 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
984 which caused a build failure on GNU/Linux IA-64. This problem was
985 introduced by my 2011-10-07 patch.
987 2011-12-15 Juri Linkov <juri@jurta.org>
989 * image.c (imagemagick_error): New function. (Bug#10112)
990 (imagemagick_load_image): Comment out `MagickSetResolution' call.
991 Use `imagemagick_error' where ImageMagick functions return
993 (Fimagemagick_types): Add `Fnreverse' to return the list in the
996 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
998 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
999 fill background (Bug#8992).
1001 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1003 * window.c (Vwindow_combination_resize)
1004 (Vwindow_combination_limit): Use t instead of non-nil in
1006 (Vrecenter_redisplay): Add first sentence of doc-string on
1008 (Frecenter): Fix doc-string typo.
1010 2011-12-11 Kenichi Handa <handa@m17n.org>
1012 * coding.c (Funencodable_char_position): Pay attention to the
1013 buffer text relocation (Bug#9389).
1015 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1017 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1018 gtk_init (Bug#10100).
1020 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1022 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1023 IT->string is nil. (Bug#10263)
1025 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1027 * nsterm.h (x_free_frame_resources): Declare.
1029 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1030 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1032 * nsterm.h (ns_get_defaults_value): Declare.
1034 * nsterm.m (ns_default): Call ns_get_defaults_value.
1036 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1038 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1041 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1043 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1044 that where the value of an _OBJC_* symbol points to is in the .bss
1045 section (Bug#10240).
1047 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1049 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1050 after the loop to call ccl_driver at least once (Bug#8619).
1052 2011-12-08 Kenichi Handa <handa@m17n.org>
1054 * ftfont.c (get_adstyle_property): Fix previous change
1057 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1059 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1060 dirs from the default value of EMACSLOADPATH (bug#10208).
1062 2011-12-07 Glenn Morris <rgm@gnu.org>
1064 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1065 installation and source directories as well. (Bug#10208)
1067 2011-12-06 Chong Yidong <cyd@gnu.org>
1069 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1071 2011-12-06 Glenn Morris <rgm@gnu.org>
1073 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1074 as an error, not just -1. (Bug#10217)
1076 2011-12-05 Chong Yidong <cyd@gnu.org>
1078 * keyboard.c (process_special_events): New function.
1079 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1081 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1083 * coding.c (encode_designation_at_bol): Don't use uninitialized
1084 local variable (Bug#9318).
1086 2011-12-05 Kenichi Handa <handa@m17n.org>
1088 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1089 return Qnil (Bug#8046, Bug#10193).
1091 2011-12-05 Kenichi Handa <handa@m17n.org>
1093 * coding.c (encode_designation_at_bol): New args charbuf_end and
1094 dst. Return the number of produced bytes. Callers changed.
1095 (coding_set_source): Return how many bytes coding->source was
1097 (coding_set_destination): Return how many bytes
1098 coding->destination was relocated.
1099 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1100 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
1102 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1104 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1105 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1108 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1110 The following changes are to fix Bug#9318.
1112 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1113 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1114 (encode_coding_iso_2022, encode_coding_sjis)
1115 (encode_coding_big5, encode_coding_charset): Use the above macros.
1117 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1119 * lisp.h (process_quit_flag): Fix external declaration.
1121 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1123 Don't macro-inline non-performance-critical code.
1124 * eval.c (process_quit_flag): New function.
1125 * lisp.h (QUIT): Use it.
1127 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1129 * nsfns.m (get_geometry_from_preferences): New function.
1130 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1132 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1134 * emacs.c (Qkill_emacs): Define.
1135 (syms_of_emacs): Initialize it.
1136 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1137 Qquit_flag to `kill-emacs' instead.
1138 (quit_throw_to_read_char): Add parameter `from_signal'.
1139 All callers changed. Call Fkill_emacs if requested and safe.
1140 * lisp.h (QUIT): Call Fkill_emacs if requested.
1142 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1144 * widget.c (update_wm_hints): Return if wmshell is null.
1145 (widget_update_wm_size_hints): New function.
1147 * widget.h (widget_update_wm_size_hints): Declare.
1149 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1150 widget_update_wm_size_hints (Bug#10104).
1152 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1154 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1155 before a newline, prepare the bidi iterator for consuming the
1156 newline, and keep the current paragraph direction. (Bug#10183)
1157 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1159 2011-12-02 Juri Linkov <juri@jurta.org>
1161 * search.c (Fword_search_regexp): New Lisp function created from
1162 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1163 (Fword_search_backward, Fword_search_forward)
1164 (Fword_search_backward_lax, Fword_search_forward_lax):
1165 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1166 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1168 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1170 * fileio.c (Finsert_file_contents): Move after-change-function call
1171 to before the "handled:" label, since all "goto handled" appear in
1172 cases where the *-change-functions have already been properly called
1175 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1177 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1178 waiting for input. (Bug#10169)
1180 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1182 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1183 verifies glyph row's hash code--we have just reallocated the
1184 glyphs, so their contents can be complete garbage. (Bug#10164)
1186 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1188 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1190 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1192 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1193 attributes are tested _before_ calling verify_row_hash, to protect
1194 against GCC re-ordering of the tests. (Bug#10164)
1196 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1198 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1200 * xterm.c (handle_one_xevent): Only set async_visible and friends
1201 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1202 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1203 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1205 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1207 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1208 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1209 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1210 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1211 All uses changed to use GCPRO1 etc.
1212 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1213 Revert to old implementation (i.e., before 2011-03-11).
1215 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1217 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1218 of scroll runs so as to avoid assigning disabled bogus rows and
1219 unnecessary graphics copy operations.
1221 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1223 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1224 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1225 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1226 (malloc, free, realloc, calloc): Redirect to e_* only when
1229 * lisp.h (GCTYPEBITS): Move before first use.
1230 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1231 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1232 this macro definition.
1234 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1237 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1239 * gtkutil.c (xg_create_frame_widgets):
1240 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1241 present with Gtk+ 2.0.
1243 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1245 * fileio.c (Finsert_file_contents): Undo previous change; see
1246 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1248 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1250 Rename locals to avoid shadowing.
1251 * fileio.c (Finsert_file_contents):
1252 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1253 * process.c (wait_reading_process_output):
1254 Rename inner 'proc' to 'p' to avoid shadowing.
1255 Indent for consistency with usual Emacs style.
1257 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1259 * xdisp.c (redisplay_window): If cursor row is not fully visible
1260 after recentering, and scroll-conservatively is set to a large
1261 number, scroll window by a few more lines to make the cursor fully
1262 visible and out of scroll-margin. (Bug#10105)
1263 (start_display): Don't move to the next line if the display should
1264 start at a newline that is part of a display vector or an overlay
1267 2011-11-24 Juri Linkov <juri@jurta.org>
1269 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1270 after the `MagickPingImage' call. (Bug#10112)
1272 2011-11-23 Chong Yidong <cyd@gnu.org>
1274 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1276 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1278 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1279 making another buffer current. (Bug#10114)
1281 2011-11-23 Glenn Morris <rgm@gnu.org>
1283 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1285 2011-11-23 Chong Yidong <cyd@gnu.org>
1287 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1288 using it (Bug#5984).
1290 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1292 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1293 and header-lines, as they don't have one computed for them.
1296 * .gdbinit (prow): Make displayed values more self-explaining.
1297 Add row's hash code.
1299 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1301 * process.c (wait_reading_process_output): Fix asynchrounous
1302 GnuTLS socket handling on some versions of the GnuTLS library.
1303 (wait_reading_process_output): Add comment and URL.
1305 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1307 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1309 2011-11-21 Chong Yidong <cyd@gnu.org>
1311 * window.c (Fnext_window, Fprevious_window): Doc fix.
1313 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1315 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1317 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1319 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1321 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1323 * window.c (Fset_window_combination_limit): Rename argument
1325 (Vwindow_combination_limit): Remove "status" from doc-string.
1327 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1329 * m/ibms390.h: Remove.
1330 * m/ibms390x.h: Don't include "ibms390.h".
1332 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1334 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1335 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1337 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1339 * casetab.c (Fset_case_table):
1340 * charset.c (Fcharset_after): Fix typos.
1342 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1344 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1345 Otherwise, valgrind does not work on some platforms.
1346 Problem reported by Andreas Schwab in
1347 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1348 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1349 is set, removing the need for VIRT_ADDRESS_VARIES.
1350 (PURE_P): Use a more-efficient implementation that needs just one
1351 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1352 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1353 to 4 (xorl, subq, cmpq, setbe).
1354 * alloc.c (pure): Always extern now, since that's the
1355 VIRT_ADDR_VARIES behavior.
1356 (PURE_POINTER_P): Use a single comparison, not two, for
1357 consistency with the new puresize.h.
1358 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1359 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1360 Remove VIRT_ADDR_VARIES no longer needed.
1362 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1364 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1365 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1366 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1367 behave as if the cursor position were at the window margin.
1369 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1370 and the cursor position is out of bounds, behave as if the cursor
1371 position were at the window margin. (Bug#10075)
1373 2011-11-18 Chong Yidong <cyd@gnu.org>
1375 * window.c (Fwindow_combination_limit): Make first argument
1376 non-optional, since it is meaningless for live windows like the
1379 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1381 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1383 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1385 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1386 (graft_intervals_into_buffer): Simplify.
1388 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1390 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1391 hash values of the two rows.
1392 (copy_row_except_pointers): Preserve the used[] arrays and the
1393 hash values of the two rows. (Bug#10035)
1394 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1396 * xdisp.c (row_hash): New function, body extracted from
1397 compute_line_metrics.
1398 (compute_line_metrics): Call row_hash, instead of computing the
1401 * dispnew.c (verify_row_hash): Call row_hash for computing the
1402 hash code of a row, instead of duplicating code from xdisp.c.
1404 * dispextern.h (row_hash): Add prototype.
1406 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1408 * frame.c (delete_frame): Don't delete the terminal when the last
1409 X frame is closed if emacs is built with GTK toolkit.
1411 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1413 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1415 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1417 * window.c (Vwindow_splits): Rename to
1418 Vwindow_combination_resize. Suggested by Juri Linkov.
1419 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1422 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1424 * nsfns.m (Fns_font_name):
1425 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1427 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1429 * window.h (window): Rename slot "nest" to "combination_limit".
1430 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1431 (Fset_window_nest): Rename to Fset_window_combination_limit.
1432 (Vwindow_nest): Rename to Vwindow_combination_limit.
1433 (recombine_windows, make_parent_window, make_window)
1434 (Fsplit_window_internal, saved_window)
1435 (Fset_window_configuration, save_window_save): Rename all
1436 occurrences of window_nest to window_combination_limit.
1438 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1440 * image.c (imagemagick_load_image): Fix typo.
1442 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1444 * xdisp.c (display_line): Move the call to
1445 highlight_trailing_whitespace before the call to
1446 compute_line_metrics, since the latter needs to see the final
1447 faces of all the glyphs to compute ROW's hash value.
1448 Fixes assertion violations in row_equal_p. (Bug#10035)
1450 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1452 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1453 just return (bug#10044).
1455 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1457 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1458 with user-defined heap size. Bump the default size of the temacs
1459 heap to 27MB, to avoid memory warning when running temacs.
1460 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1462 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1463 current_matrix and desired_matrix. (Bug#9990)
1464 (verify_row_hash) [XASSERTS]: New function.
1465 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1466 that the hash value of glyph rows is correct.
1468 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1470 * window.h (window): Remove splits slot.
1471 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1472 (Fdelete_other_windows_internal, make_parent_window)
1473 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1474 (Fset_window_configuration, save_window_save): Don't deal with
1475 split status of windows.
1476 (saved_window): Remove splits slot.
1477 (Vwindow_splits): Rewrite doc-string.
1479 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1481 * xfns.c (unwind_create_frame):
1482 * nsfns.m (unwind_create_frame):
1483 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1484 Vframe_list (Bug#9999).
1486 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1488 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1490 2011-11-11 Kenichi Handa <handa@m17n.org>
1492 * callproc.c (Fcall_process): Set the member dst_multibyte of
1495 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1497 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1498 avoid a crash (bug#9496).
1500 2011-11-09 Chong Yidong <cyd@gnu.org>
1502 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1503 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1505 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1507 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1509 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1511 Avoid some portability problems by eschewing 'extern inline' functions.
1512 The trivial performance wins aren't worth the portability hassles; see
1513 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1515 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1516 (window_box_width, window_box_left, window_box_left_offset)
1517 (window_box_right, window_box_right_offset): Undo previous change,
1518 by removing the "extern"s.
1519 * intervals.c (adjust_intervals_for_insertion)
1520 (adjust_intervals_for_deletion): Undo previous change,
1521 making these static again.
1522 (offset_intervals, temp_set_point_both, temp_set_point)
1523 (copy_intervals_to_string): No longer inline.
1524 * xdisp.c (window_text_bottom_y, window_box_width)
1525 (window_box_height, window_box_left_offset)
1526 (window_box_right_offset, window_box_left, window_box_right)
1527 (window_box): No longer inline.
1529 2011-11-08 Chong Yidong <cyd@gnu.org>
1531 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1532 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1533 Signal an error if not a live window.
1534 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1535 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1537 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1539 * lisp.h (syms_of_abbrev): Remove declaration.
1540 Reported by CHENG Gao <chenggao@royau.me>.
1542 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1544 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1545 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1546 of temacs in GUI mode.
1548 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1550 * window.h: Declare delete_all_child_windows instead of
1551 delete_all_subwindows.
1552 * window.c (Fwindow_nest, Fset_window_nest)
1553 (Fset_window_new_total, Fset_window_new_normal)
1554 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1555 (delete_all_subwindows): Rename to delete_all_child_windows.
1556 (Fdelete_other_windows_internal, Fset_window_configuration):
1557 Call delete_all_child_windows instead of delete_all_subwindows.
1558 * frame.c (delete_frame): Call delete_all_child_windows instead
1559 of delete_all_subwindows.
1561 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1563 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1564 This is also needed for porting to any host where GC_MARK_STACK is
1565 not GC_MAKE_GCPROS_NOOPS.
1566 (which_symbols): Use it.
1568 2011-11-07 Kenichi Handa <handa@m17n.org>
1570 * coding.c (coding_set_destination): Check coding->src_pos only
1571 when coding->src_object is a buffer (bug#9910).
1573 * process.c (send_process): Set the member src_multibyte of coding
1574 to 0 (bug#9911) when sending a unibyte text.
1576 * callproc.c (Fcall_process): Set the member src_multibyte of
1577 process_coding to 0 (bug#9912).
1579 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1581 * xmenu.c (cleanup_widget_value_tree): New function.
1582 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1583 calling free_menubar_widget_value_tree directly (Bug#9830).
1585 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1587 Fix some portability problems with 'inline'.
1588 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1589 (window_box_width, window_box_left, window_box_left_offset)
1590 (window_box_right, window_box_right_offset): Declare extern.
1591 Otherwise, these inline functions do not conform to C99 and
1592 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1593 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1594 * intervals.c (adjust_intervals_for_insertion)
1595 (adjust_intervals_for_deletion): Now extern, because otherwise the
1596 extern inline functions 'offset_intervals' couldn't refer to it.
1597 (static_offset_intervals): Remove.
1598 (offset_intervals): Rewrite using the old contents of
1599 static_offset_intervals. The old version didn't conform to C99
1600 because an extern inline function contained a reference to an
1601 identifier with static linkage.
1603 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1605 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1608 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1610 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1611 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1612 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1613 return Qleft_to_right.
1615 2011-11-06 Chong Yidong <cyd@gnu.org>
1617 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1618 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1619 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1620 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1621 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1622 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1623 (Fwindow_vscroll): Doc fix.
1624 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1625 argument, since it makes no sense to pass a live window and for
1626 consistency with window-child.
1628 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1630 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1633 2011-11-05 Jason Rumney <jasonr@gnu.org>
1635 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1636 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1638 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1639 bitwise arithmetic preventing use of unicode-sip and non-truetype
1642 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1644 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1647 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1648 initialization code to keep similarity to xfns.c after changes
1651 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1653 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1654 (unwind_create_frame): New function (Bug#9943).
1655 (Fx_create_frame): Restructure code to be more similar to the one in
1656 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1657 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1658 Move terminal->reference_count++ just before making the frame official
1661 * nsterm.m (x_free_frame_resources): New function.
1662 (x_destroy_window): Move code to x_free_frame_resources.
1664 * xfns.c (unwind_create_frame): Fix comment.
1665 (Fx_create_frame, x_create_tip_frame):
1666 Move terminal->reference_count++ just before making the frame
1667 official. Move initialization of image_cache_refcount and
1668 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1670 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1672 Support MSVC build with newer versions of Visual Studio.
1673 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1674 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1677 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1678 which are not supported by MSVC.
1679 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1680 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1682 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1684 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1686 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1688 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1690 Support MSVC build with newer versions of Visual Studio.
1691 * w32.c: Don't include w32api.h for MSVC.
1692 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1694 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1695 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1696 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1697 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1699 (alloca) [_MSC_VER]: Define to _alloca.
1701 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1703 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1705 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1707 * xdisp.c (note_mouse_highlight): If either of
1708 previous/next-single-property-change returns nil, treat that as
1709 the beginning or the end of the buffer. (Bug#9955)
1711 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1713 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1714 label is not null (Bug#9951).
1715 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1718 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1720 * window.c (Fwindow_body_size): Mention in the doc string that the
1721 return value is in frame's canonical units. (Bug#9949)
1723 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1725 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1727 * w32fns.c (unwind_create_frame): If needed, free the glyph
1728 matrices of the partially constructed frame. (Bug#9943)
1729 * xfns.c (unwind_create_frame): Likewise.
1731 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1733 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1734 Don't stop backward scan on the continuation glyph, even though
1735 its CHARPOS is positive.
1736 (mouse_face_from_buffer_pos, note_mouse_highlight):
1737 Rename cover_string to disp_string.
1739 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1741 * window.c (temp_output_buffer_show): Don't use
1742 Vtemp_buffer_show_specifiers.
1743 (Vtemp_buffer_show_specifiers): Remove unused variable.
1745 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1747 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1748 past the beginning of the current glyph matrix.
1750 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1752 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1753 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1754 HAVE_GTK3 (Bug#9869).
1756 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1757 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1759 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1761 * xterm.c: Declare x_handle_net_wm_state to return int.
1762 (handle_one_xevent): Check if we are iconified but don't have
1763 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1764 (get_current_wm_state): Return non-zero if not hidden,
1765 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1766 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1767 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1768 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1770 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1772 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1773 so that this new function doesn't get optimized away by a
1774 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1776 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1778 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1780 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1782 Fix the `xbytecode' command.
1783 * .gdbinit (xprintbytestr): New command.
1784 (xwhichsymbols): Rename from `which'; all callers changed.
1785 (xbytecode): Print the byte-code string as well.
1787 2011-10-29 Kim Storm <storm@cua.dk>
1789 * alloc.c (which_symbols): New function.
1791 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1793 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1796 2011-10-29 Glenn Morris <rgm@gnu.org>
1798 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1799 Not clear what it was for, and it causes various bugs. (Bug#9839)
1801 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1803 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1804 possible random value that matches one of those tested as
1805 condition to clear the mouse face.
1807 2011-10-28 Chong Yidong <cyd@gnu.org>
1809 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1811 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1813 * window.c (make_window): Initialize phys_cursor_on_p.
1815 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1817 * lisp.h (struct Lisp_Symbol): Update comments.
1819 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1821 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1823 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1825 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1826 <oslsachem@gmail.com> for helping to debug this.
1828 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1829 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1830 (g_b_init_get_glyph_outline_w): New static variables.
1831 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1832 (GetGlyphOutlineW_Proc): New typedefs.
1833 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1834 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1836 (w32font_open_internal, compute_metrics):
1837 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1838 instead of calling the "wide" APIs directly.
1840 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1842 * w32.h (syms_of_w32font): Add prototype.
1844 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1846 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1847 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1848 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1849 (Fmove_to_window_line): Doc fix.
1851 2011-10-27 Chong Yidong <cyd@gnu.org>
1853 * process.c (make_process): Set gnutls_state to NULL.
1855 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1856 non-NULL, regardless of GNUTLS_INITSTAGE.
1857 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1858 an error. Set process slots as soon as we allocate them.
1860 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1862 2011-10-27 Chong Yidong <cyd@gnu.org>
1864 * gnutls.c (emacs_gnutls_deinit): New function.
1865 Deallocate credentials structures as well as calling gnutls_deinit.
1866 (Fgnutls_deinit, Fgnutls_boot): Use it.
1868 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1869 (deactivate_process): Call emacs_gnutls_deinit.
1871 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1873 * image.c (x_create_x_image_and_pixmap):
1874 * w32.c (sys_rename, w32_delayed_load):
1875 * w32font.c (fill_in_logfont):
1876 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1878 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1880 * w32fns.c (w32_default_color_map): New function,
1881 extracted from Fw32_default_color_map.
1882 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1884 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1886 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1888 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1890 * keyboard.c (test_undefined): New function (bug#9751).
1891 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1893 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1895 * sysdep.c (init_sys_modes): Fix the check for the controlling
1896 terminal (Bug#6649).
1898 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1900 * dispextern.h (struct bidi_it): New member next_en_type.
1902 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1903 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1904 current character, check also for next_en_type being WEAK_EN.
1905 (bidi_resolve_weak): Don't enter the expensive loop if the current
1906 position is before next_en_pos. Record the bidi type of the first
1907 non-ET, non-BN character we find, in addition to its position.
1908 (bidi_level_of_next_char): Invalidate next_en_type when
1909 next_en_pos is over-stepped.
1911 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1913 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1914 * editfns.c: Rewrite current-time-zone so that it invokes
1915 the equivalent of (format-time-string "%Z") to get the time zone name.
1916 This fixes a bug when the time zone name contains characters that
1917 need converting from the system time locale to Emacs internal format.
1918 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1919 that patch fixed format-time-string to do the conversion, but
1920 I forgot to fix current-time-zone.
1921 (format_time_string): New function, containing most of
1922 what Fformat_time_string used to contain.
1923 (Fformat_time_string): Rewrite in terms of format_time_string.
1924 This doesn't change this function's behavior.
1925 (current-time-zone): Rewrite to use format_time_string.
1926 This fixes the bug reported by Michael Schierl in
1927 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1928 Jason Rumney's 2007-06-07 change worked around this bug, but
1930 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1932 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1934 * xdisp.c (start_display): If the character at POS is displayed
1935 via a display vector, reset IT->current.dpvec_index to zero.
1936 (try_window_reusing_current_matrix): If a line ends in a display
1937 vector or the next line starts in a display vector, continue
1938 redrawing the window even though the character position of
1939 start_row was reached.
1942 2011-10-18 Chong Yidong <cyd@gnu.org>
1944 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1945 with nobreak-char-display too.
1947 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1949 Fix part 3 of bug#9771.
1950 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1951 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1952 non-neutral characters if the current character is a paragraph
1953 separator (a.k.a. Newline). This avoids running the same
1954 expensive loop twice, once when we consume the preceding newline
1955 and the other time when the line actually needs to be displayed.
1956 Avoid the loop when we see neutrals on the base embedding level
1957 following a character whose directionality is the same as the
1958 paragraph's. This avoids running the expensive loop when a line
1959 ends in a long sequence of neutrals, like control characters.
1960 Add assertion against STRONG_AL type. Slightly rearrange code
1961 that determines the type of a neutral given the first non-neutral
1963 (bidi_level_of_next_char): Set next_en_pos to zero when
1964 invalidating its info.
1966 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1968 * xdisp.c (push_display_prop): Determine whether to record string
1969 or buffer position by IT->string, not by IT->method. Allow
1970 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1971 (move_it_vertically_backward): Don't look for character position
1972 immediately after the newline when in a continuation line.
1975 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1977 * window.c (coordinates_in_window): Rewrite and delabelize
1978 vertical border check. (Bug#5357) (Bug#9618)
1980 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1982 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1983 errors in XSetWindowBorder (bug#9310).
1985 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1987 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1988 avoid crash when xmalloc overrun checking is enabled.
1990 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1992 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1993 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1994 cursor motion with <left> and <right> arrow keys.
1996 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1997 some callers set that themselves.
1999 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2001 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2002 display string and the previous row comes from the same string and
2003 is empty. (Bug#9739) (Bug#9738)
2005 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2007 * doc.c (get_doc_string): Encode file name (bug#9735).
2009 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2011 * bidi.c (bidi_level_of_next_char):
2012 * xdisp.c (get_visually_first_element): Remove old incorrect
2013 comments regarding the Unicode Line Separator character.
2015 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2017 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2019 * alloc.c (Fgc_status): Do not access beyond zombies array
2020 boundary if nzombies > MAX_ZOMBIES.
2021 * alloc.c (dump_zombies): Add missing format specifier.
2023 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2025 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2026 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2028 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2029 Some packages use them to denote characters with modifiers.
2031 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2033 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2034 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2035 matching a pp-number. Rename parameter var to var1.
2037 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2039 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2041 2011-10-08 Glenn Morris <rgm@gnu.org>
2043 * callint.c (Fcall_interactively): Give a more explicit error for the
2044 'c' case with a non-character input. (Bug#8479)
2046 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2048 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2050 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2051 lines that are hscrolled on the left.
2053 * dispnew.c (buffer_posn_from_coords): Account for a possible
2054 presence of header-line. (Bug#4426)
2056 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2058 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2059 Don't advertise functionality which we discourage or doesn't work.
2061 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2063 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2064 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2065 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2066 this makes Emacs dump core during garbage collection on rare
2067 occasions. sizeof is obviously inferior to offsetof here, so
2068 stick with offsetof.
2069 (GC_POINTER_ALIGNMENT): New macro.
2070 (mark_memory): Omit 3rd (offset) arg; caller changed.
2071 Don't assume EMACS_INT alignment is the same as pointer alignment.
2073 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2075 * keyboard.c (read_key_sequence_remapped): New var.
2076 (read_key_sequence): Compute remapping in the right buffer.
2077 (command_loop_1): Use read_key_sequence's remapping directly.
2079 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2081 * dired.c (file_name_completion): Don't expand file name.
2082 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2083 before checking file name handler.
2085 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2086 they've been requested explicitly (bug#9591).
2088 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2090 * keymap.c (Fsingle_key_description): Use make_specified_string
2091 instead of build_string to build string from push_key_description.
2094 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2096 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2097 This fixes a Y2038 bug on 64-bit hosts.
2098 * buffer.c (reset_buffer):
2099 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2100 (Fclear_buffer_auto_save_failure):
2101 Use 0, not -1, to represent an unset failure time, since time_t
2102 might not be signed.
2104 Remove dependency on glibc malloc internals.
2105 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2106 Move back here from lisp.h, but with their new implementations.
2107 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2108 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2109 * charset.c (charset_table_init): New static var.
2110 (syms_of_charset): Use it instead of xmalloc. This removes a
2111 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2112 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2113 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2114 Move back to alloc.c.
2115 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2116 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2118 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2120 * nsterm.m (windowDidResize): Call x_set_window_size only when
2121 ns_in_resize is true. Otherwise set pixelwidth/height and
2122 call change_frame_size (Bug#9628).
2124 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2126 Port --enable-checking=all to Fedora 14 x86-64.
2127 * charset.c (syms_of_charset): Also account for glibc malloc's
2128 internal overhead when calculating the initial malloc maximum.
2130 Port --enable-checking=all to Fedora 14 x86.
2131 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2133 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2134 (overrun_check_realloc, overrun_check_free):
2135 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2136 That way, xmalloc returns a properly-aligned pointer even if
2137 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2138 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2139 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2140 into account when calculating the initial malloc maximum.
2141 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2142 Move here from alloc.c, so that charset.c can use it too.
2143 Properly align; the old code wasn't right for common 32-bit hosts
2144 when configured with --enable-checking=all.
2145 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2146 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2148 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2150 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2153 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2155 * xdisp.c (compute_display_string_end): If there's no display
2156 string at CHARPOS, return -1.
2158 * bidi.c (bidi_fetch_char): When compute_display_string_end
2159 returns a negative value, treat the character as a normal
2160 character not covered by a display string. (Bug#9624)
2162 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2164 * lread.c (Fread_from_string): Fix typo in docstring.
2166 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2168 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2169 newline, reseat the iterator instead of bidi-iterating there one
2170 character at a time. (Bug#9610)
2171 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2172 TO_CHARPOS if the bidi iterator is at base embedding level.
2174 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2176 * lread.c (readevalloop): Use correct code for NBSP.
2177 (read1): Likewise. (Bug#9608)
2179 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2181 * dbusbind.c (Fdbus_register_signal): When service is not
2182 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2184 2011-09-25 Glenn Morris <rgm@gnu.org>
2186 * buffer.c (truncate-lines): Doc fix.
2188 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2190 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2191 (Fset_window_next_buffers): Doc fix.
2193 2011-09-24 Glenn Morris <rgm@gnu.org>
2195 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2197 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2199 Fix minor problems found by static checking.
2200 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2201 * indent.c (Fvertical_motion): Fix == vs = typo.
2203 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2205 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2206 Default value is now t. Doc fix.
2208 * indent.c (Fvertical_motion): Compute and apply the overshoot
2209 logic when moving up, not only when moving down. Fix the
2210 confusing name and values of the it_overshoot_expected variable;
2211 logic changes accordingly. (Bug#9254) (Bug#9549)
2213 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2214 CHARPOS is covered by a display string which includes newlines.
2215 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2216 is covered by a display string with embedded newlines.
2218 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2220 * dbusbind.c (Fdbus_register_signal): Add match rule to
2221 Vdbus_registered_objects_table. (Bug#9581)
2222 (Fdbus_register_method, Vdbus_registered_objects_table):
2225 2011-09-24 Jim Meyering <meyering@redhat.com>
2227 do not ignore write error for any output size
2228 The previous change was incomplete.
2229 While it makes emacs --batch detect the vast majority of stdout
2230 write failures, errors were still ignored whenever the output size is
2231 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2232 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2233 && echo FAIL: ignored write error
2234 FAIL: ignored write error
2235 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2236 && echo FAIL: ignored write error
2237 FAIL: ignored write error
2238 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2240 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2242 * emacs.c (Fkill_emacs): In noninteractive mode exit
2243 non-successfully if a write error occurred on stdout. (Bug#9574)
2245 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2247 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2250 * dispextern.h (struct it): Update the comment documenting what
2253 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2255 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2256 a display string, extend search for cursor position to end of row.
2257 (find_row_edges): If the row ends in a newline from a display
2258 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2259 Handle the case of a display string with multiple newlines.
2260 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2261 non-empty line. Fixes confusing cursor motion with arrow keys at
2262 the beginning of a line that starts with whitespace.
2264 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2266 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2269 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2271 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2274 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2276 * xdisp.c (display_line): Record maximum and minimum buffer
2277 positions even if no glyphs were produced (e.g., by a zero-width
2278 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2279 buffer positions that will be removed from the glyph row because
2281 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2282 column is beyond frame width: don't subtract 1 "pixel" when
2283 computing width of the stretch.
2284 (reseat_at_next_visible_line_start): Undo the change made on
2285 2011-09-17 that saved paragraph information and restored it after
2286 the call to `reseat'. (Bug#9545)
2288 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2290 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2291 and turn window cursor on if cleared (Bug#9415).
2293 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2295 * search.c (boyer_moore): Take unibyte characters from pattern
2296 literally. (Bug#9458)
2298 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2300 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2302 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2304 Fix minor problem found by static checking.
2305 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2306 initialized, to pacify gcc -Wuninitialized.
2308 * fileio.c: Report proper errno when syscall falls.
2309 (Finsert_file_contents): Save and restore errno,
2310 so that report_file_error outputs the correct diagnostic.
2311 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2313 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2315 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2317 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2319 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2320 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2322 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2324 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2325 about the current paragraph and restore it after the call to reseat.
2327 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2328 (bidi_find_paragraph_start): Search back for paragraph beginning
2329 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2330 (bidi_move_to_visually_next): Only trigger paragraph-related
2331 computations when the last character is a newline or at EOB, not
2332 just any NEUTRAL_B. (Bug#9470)
2334 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2335 truncated lines if point is covered by a display string. (Bug#9524)
2337 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2339 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2340 (cons_to_x_long): New function.
2341 (lisp_data_to_selection_data): Use it. Correct the test for
2342 short-versus-long data; it was negated. Break out of vector
2343 loop, for efficiency, when a long datum is discovered.
2345 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2347 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2349 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2351 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2352 GCC PR/17406) by declaring this function with external scope.
2354 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2356 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2357 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2359 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2361 * editfns.c (Fformat): Correctly handle text properties on "%%".
2363 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2365 * xterm.c (x_draw_composite_glyph_string_foreground):
2366 * w32term.c (x_draw_composite_glyph_string_foreground):
2367 * term.c (encode_terminal_code):
2368 * composite.c (composition_update_it, get_composition_id):
2369 * xdisp.c (get_next_display_element)
2370 (fill_composite_glyph_string): Add comments about special meaning
2371 of TAB characters in a composition.
2373 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2375 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2376 This occurs when processing a multibyte format.
2377 Problem reported by Wolfgang Jenker.
2379 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2381 * xdisp.c (try_cursor_movement): Only check for exact match if
2382 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2384 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2386 Remove unused external symbols.
2387 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2388 * xdisp.c (calc_pixel_width_or_height): Now static.
2389 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2390 * indent.c (check_display_width):
2391 * w32term.c: Fix comment to match code.
2392 * xterm.c, xterm.h (x_catching_errors): Remove.
2394 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2396 * xselect.c: Use signed conversions more consistently (Bug#9498).
2397 (selection_data_to_lisp_data): Assume incoming selection data are
2398 signed integers, not unsigned. This is to be consistent with
2399 outgoing selection data, which was modified to use signed integers
2400 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2401 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2402 expects long, not unsigned long.
2404 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2406 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2407 computation of loop end. Reported by Johan Bockgård
2410 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2412 * frame.c (Fother_visible_frames_p): Function deleted.
2414 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2416 * indent.c (compute_motion): Process display vector front to back
2417 rather than the other way around. (Bug#2496)
2419 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2421 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2423 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2425 * minibuf.c (Fread_from_minibuffer): Doc fix.
2427 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2429 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2430 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2432 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2434 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2435 value for non-existent files.
2437 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2439 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2440 set its "size" to -1. This will set the modtime_size field of
2441 the corresponding buffer to -1, which is what
2442 verify-visited-file-modtime expects for files that do not exist.
2445 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2447 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2449 * lisp.h: ... from here. push_key_description is no longer
2450 defined in keyboard.c, so its declaration should not be in
2451 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2452 logically belongs with push_key_description.
2454 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2456 * buffer.h: Include <sys/types.h> instead of <time.h>.
2457 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2458 Problem reported by Herbert J. Skuhra.
2460 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2462 * xml.c (parse_region): Make the parsing work for
2463 non-comment-starting XML files again (bug#9144).
2465 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2467 * image.c (gif_load): Fix calculation of bottom and right corner.
2470 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2472 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2473 redisplay in small windows.
2475 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2477 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2479 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2481 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2482 Operate on live windows only.
2484 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2486 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2488 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2490 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2491 only under bidi iteration.
2493 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2495 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2497 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2499 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2500 Without this fix, the command to link temacs failed due to an
2501 undefined symbol __builtin_isnan. This is because
2502 /usr/include/iso/math_c99.h #defines isnan(x) to
2503 __builtin_isnan(x), but the bundled gcc, which identifies itself
2504 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2506 * floatfns.c (isnan): #undef, and then #define to a clone of
2508 (Fisnan): Always define, since it's always available now.
2509 (syms_of_floatfns): Always define isnan at the Lisp level.
2511 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2513 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2515 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2517 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2518 The previous code assumed that file offsets (off_t values) fit in
2519 EMACS_INT variables, which is not true on typical 32-bit hosts.
2520 The code messed up by falsely reporting buffer overflow in cases
2521 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2522 when "big" contains more than 2**29 bytes, even though this
2523 inserts just one byte and does not overflow the buffer.
2524 (Finsert_file_contents): Store file offsets as off_t
2525 values, not as EMACS_INT values. Check for overflow when
2526 converting between EMACS_INT and off_t. When checking for
2527 buffer overflow or for overlap, take the offsets into account.
2528 Don't use EMACS_INT for small values where int suffices.
2529 When checking for overlap, fix a typo: ZV was used where
2530 ZV_BYTE was intended.
2531 (Fwrite_region): Don't assume off_t fits into 'long'.
2532 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2534 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2536 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2538 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2540 sprintf-related integer and memory overflow issues (Bug#9412).
2542 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2543 (esprintf, exprintf, evxprintf): New functions.
2544 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2545 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2546 (modify_event_symbol): Do not assume that the length of
2547 name_alist_or_stem is safe to alloca and fits in int.
2548 (Fexecute_extended_command): Likewise for function name and binding.
2549 (Frecursion_depth): Wrap around reliably on integer overflow.
2550 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2551 since some callers pass EMACS_INT values.
2552 (Fsingle_key_description): Don't crash if symbol name contains more
2553 than MAX_ALLOCA bytes.
2554 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2555 (get_minibuffer): Arg is now EMACS_INT, not int.
2556 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2557 (esprintf, exprintf, evxprintf): New decls.
2558 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2560 * dbusbind.c (signature_cat): New function.
2561 (xd_signature, Fdbus_register_signal):
2562 Do not overrun buffer; instead, report string overflow.
2564 * dispnew.c (add_window_display_history): Don't overrun buffer.
2565 Truncate instead; this is OK since it's just a log.
2567 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2568 even if the time zone offset is outlandishly large.
2569 Don't mishandle offset == INT_MIN.
2571 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2572 when creating daemon; the previous buffer-overflow check was incorrect.
2574 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2575 which has the guts of the old verror function.
2577 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2578 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2580 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2581 (font_unparse_xlfd): Don't blindly alloca long strings.
2582 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2583 fits in int, when using sprintf. Use single snprintf to count
2584 length of string rather than counting it via multiple sprintfs;
2585 that's simpler and more reliable.
2586 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2587 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2588 sprintf, in case result does not fit in int.
2590 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2591 (fontset_from_font): Print it.
2593 * frame.c (tty_frame_count): Now printmax_t, not int.
2594 (make_terminal_frame, set_term_frame_name): Print it.
2595 (x_report_frame_params): In X, window IDs are unsigned long,
2596 not signed long, so print them as unsigned.
2597 (validate_x_resource_name): Check for implausibly long names,
2598 and don't assume name length fits in 'int'.
2599 (x_get_resource_string): Don't blindly alloca invocation name;
2600 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2603 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2604 (xg_check_special_colors, xg_set_geometry):
2605 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2607 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2608 Use esprintf, not sprintf, in case result does not fit in int.
2610 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2611 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2612 it as a large positive number.
2613 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2614 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2616 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2617 in case result does not fit in int.
2619 * print.c (float_to_string): Detect width overflow more reliably.
2620 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2621 buffer overrun. Don't assume list length fits in 'int'. Treat
2622 print length of 0 as 0, not as infinity; to be consistent with other
2623 uses of print length in this function. Don't overflow print length
2624 index. Don't assume hash table size fits in 'long', or that
2625 vectorlike size fits in 'unsigned long'.
2627 * process.c (make_process): Use printmax_t, not int, to format
2628 process-name gensyms.
2630 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2632 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2633 to avoid potential buffer overrun.
2635 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2636 if X resource line is longer than 512 bytes.
2638 * xfns.c (x_window): Make sprintf buffer a bit bigger
2639 to avoid potential buffer overrun.
2641 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2643 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2645 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2647 Integer overflow fixes for scrolling, etc.
2648 Without these, Emacs silently mishandles large integers sometimes.
2649 For example, "C-u 4294967297 M-x recenter" was treated as if
2650 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2652 * xdisp.c (try_window_id): Check Emacs fixnum range before
2653 converting to 'int'.
2655 * window.c (window_scroll_line_based, Frecenter):
2656 Check that an Emacs fixnum is in range before assigning it to 'int'.
2657 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2658 values converted from Emacs fixnums.
2659 (Frecenter): Don't wrap around a line count if it is out of 'int'
2660 range; instead, treat it as an extreme value.
2661 (Fset_window_configuration, compare_window_configurations):
2662 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2664 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2665 that can exceed INT_MAX. Check that EMACS_INT value is in range
2666 before assigning it to the (possibly-narrower) index.
2667 (match_limit): Don't assume that a fixnum can fit in 'int'.
2669 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2672 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2673 (Fvertical_motion): Don't wrap around LINES values that don't fit
2674 in 'int'. Instead, treat them as extreme values. This is good
2675 enough for windows, which can't have more than INT_MAX lines anyway.
2677 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2679 * Require libxml/parser.h to avoid compilation warning.
2681 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2683 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2684 since this reportedly can destroy thread storage.
2686 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2688 * syntax.c (find_defun_start): Update all cache variables if
2689 exiting early (Bug#9401).
2691 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2693 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2695 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2696 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2697 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2699 * term.c (tty_append_glyph): New function.
2700 (produce_stretch_glyph): Static function and its prototype deleted.
2702 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2705 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2707 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2708 when checking :margin (Bug#9390).
2709 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2710 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2711 so that the name doesn't mislead. All uses changed.
2713 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2715 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2718 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2720 * xdisp.c (move_it_to): Don't bail out early when reaching
2721 position beyond to_charpos, if we are scanning backwards.
2722 (move_it_vertically_backward): When DY == 0, make sure we get to
2723 the first character in the line after the newline.
2725 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2727 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2728 (ccl_driver): Do not generate an out-of-range pointer.
2729 (Fccl_execute_on_string): Remove unnecessary check for
2730 integer overflow, noted by Stefan Monnier in
2731 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2732 Remove a FIXME that didn't need fixing.
2733 Simplify the newly-introduced buffer reallocation code.
2735 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2737 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2739 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2741 Integer and memory overflow issues (Bug#9196).
2743 * doc.c (get_doc_string): Rework so that
2744 get_doc_string_buffer_size is the actual buffer size, rather than
2745 being 1 less than the actual buffer size; this makes xpalloc more
2748 * image.c (x_allocate_bitmap_record, cache_image):
2749 * xselect.c (Fx_register_dnd_atom):
2750 Simplify previous changes by using xpalloc.
2752 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2753 since either will do and ptrdiff_t is convenient with xpalloc.
2755 * charset.c (charset_table_size)
2756 (struct charset_sort_data.priority): Now ptrdiff_t.
2757 (charset_compare): Don't overflow if priorities differ greatly.
2758 (Fsort_charsets): Don't assume list length fits in int.
2759 Check for size-calculation overflow when allocating sort data.
2760 (syms_of_charset): Allocate an initial charset table that is
2761 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2763 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2765 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2766 The actual value is always <= INT_MAX, and leaving it unsigned made
2767 overflow checking harder.
2769 * dispextern.h (struct glyph_matrix.rows_allocated)
2770 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2771 with xpalloc. The values are still always <= INT_MAX.
2773 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2775 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2776 (SAFE_NALLOCA): New macro.
2778 * region-cache.c (struct boundary.pos, find_cache_boundary)
2779 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2780 (set_cache_region, invalidate_region_cache)
2781 (revalidate_region_cache, know_region_cache, region_cache_forward)
2782 (region_cache_backward, pp_cache):
2783 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2784 so that ptrdiff_t * can be passed to xpalloc.
2785 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2786 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2787 (pp_cache): Don't assume cache_len fits in int.
2788 * region-cache.h: Adjust extern decls to match.
2790 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2791 EMACS_INT, since either will do, for xpalloc.
2793 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2794 (xnmalloc, xnrealloc, xpalloc): New functions.
2796 * bidi.c (bidi_shelve_header_size): New constant.
2797 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2798 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2800 * bidi.c (bidi_cache_shrink):
2801 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2803 Don't update size of array until after memory allocation succeeds,
2804 because xmalloc/xrealloc may not return.
2805 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2806 now that we have proper integer overflow checking.
2807 (record_overlay_string, overlay_strings): Catch overflows when
2808 calculating size of overlay_str_buf.
2810 * callproc.c (Fcall_process): Check for size overflow when
2811 calculating size of args2.
2812 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2813 Normally we prefer signed values, but sticking with ptrdiff_t would
2814 require adding more-complicated checks.
2816 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2817 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2818 Redo buffer-overflow calculations to avoid integer overflow.
2819 Add a FIXME comment where memory seems to be over-allocated.
2821 * character.c (Fstring): Check for size-calculation overflow.
2823 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2824 unnecessary integer overflow. Check for size overflow.
2825 (encode_coding_object): Don't update size until xmalloc succeeds.
2827 * composite.c (get_composition_id): Check for overflow in glyph
2828 length calculations.
2830 Integer and memory overflow fixes for display code.
2831 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2832 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2833 (scrolling_window): Check for overflow in size calculations.
2834 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2835 Don't assume glyph table len fits in int.
2836 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2837 (row_table_size): Now ptrdiff_t, not int.
2838 (scrolling_window): Avoid overflow in size calculations.
2839 Don't update size until allocation succeeds.
2840 * fns.c (concat): Check for overflow in size calculations.
2841 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2842 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2843 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2845 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2846 (get_doc_string): Check for size calculation overflow.
2847 Don't update size until allocation succeeds.
2848 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2849 EMACS_INT, where ptrdiff_t will do.
2850 (Fsubstitute_command_keys): Check for string overflow.
2852 * editfns.c (set_time_zone_rule): Don't assume environment length
2854 (message_length): Now ptrdiff_t, not int.
2855 (Fmessage_box): Don't update size until allocation succeeds.
2856 Don't assume message length fits in int.
2857 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2859 * emacs.c (main): Do not reallocate argv, since there is a null at
2860 the end that can be overwritten, and this way there's no need to
2861 worry about size-calculation overflow.
2862 (sort_args): Check for size-calculation overflow.
2864 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2866 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2868 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2869 (x_set_scroll_bar_width, x_figure_window_size):
2870 Check for integer overflow.
2871 (x_set_alpha): Do not assume XINT fits in int.
2873 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2874 This is for the members text_lines, text_cols, total_lines, total_cols,
2875 where the system imposes an 'int' limit.
2877 * fringe.c (Fdefine_fringe_bitmap):
2878 Don't update size until alloc works.
2880 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2881 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2883 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2884 Check for size-calculation overflow.
2885 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2886 do, as we prefer signed integers.
2887 (id_to_widget.max_size, id_to_widget.used)
2888 (xg_store_widget_in_map, xg_remove_widget_from_map)
2889 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2890 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2891 Use and return ptrdiff_t, not int.
2892 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2893 * gtkutil.h: Change prototypes to match the above.
2895 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2896 are duplicate now that they've been promoted to lisp.h.
2897 (x_allocate_bitmap_record, x_alloc_image_color)
2898 (make_image_cache, cache_image, xpm_load):
2899 Don't update size until alloc is done.
2900 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2902 Check for size calculation overflow.
2903 (ct_colors_allocated_max): New constant.
2904 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2907 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2908 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2909 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2910 Use ptrdiff_t, not int, to count maps.
2911 (read_char_minibuf_menu_prompt): Check for overflow in size
2912 calculations. Don't update size until allocation succeeds.
2913 Redo calculations to avoid overflow.
2914 * keyboard.h: Change prototypes to match the above.
2916 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2918 (current_minor_maps): Check for size calculation overflow.
2919 * keymap.h: Change prototypes to match the above.
2921 * lread.c (read1, init_obarray): Don't update size until alloc done.
2923 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2924 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2926 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2927 Now ptrdiff_t, not int.
2928 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2929 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2931 * process.c (Fnetwork_interface_list): Check for overflow
2932 in size calculation.
2934 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2936 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2937 overflow. Don't bother calling xmalloc when xrealloc will do.
2939 * search.c (Freplace_match): Check for size calculation overflow.
2940 (Fset_match_data): Don't assume list lengths fit in 'int'.
2942 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2943 for command line length. Do not attempt to address one before the
2944 beginning of an array, as that's not portable.
2946 * term.c (max_frame_lines): Remove; unused.
2947 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2949 (encode_terminal_code, calculate_costs): Check for size
2950 calculation overflow.
2951 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2952 table lengths and related sizes. Don't update size until alloc
2953 done. Redo calculations to avoid overflow.
2954 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2956 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2957 subtracting pointers.
2958 (gobble_line): Check for overflow more carefully. Don't update size
2961 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2962 Don't update size until alloc done.
2963 Redo size calculations to avoid overflow.
2964 Check for size calculation overflow.
2965 (main) [DEBUG]: Fix typo in invoking tparam1.
2967 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2968 Use ptrdiff_t, not int, for sizes.
2969 (store_mode_line_noprop_char): Don't update size until alloc done.
2971 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2972 Use ptrdiff_t, not int, for sizes.
2973 (Finternal_make_lisp_face, cache_face):
2974 Check for size calculation overflow.
2975 (cache_face): Treat size calculation overflows as if they were
2976 memory exhaustion (the usual treatment), rather than aborting.
2978 * xfns.c (x_encode_text, x_set_name_internal)
2979 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2980 sizes, since they can exceed INT_MAX in size. Check for size
2981 calculation overflow.
2983 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2984 (xg_select): Check for size calculation overflow.
2985 Don't update size until alloc done.
2987 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2988 as sprintf is limited to int lengths.
2990 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2991 (X_LONG_MIN): New macros.
2992 Use them to make the following changes clearer.
2993 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2994 This change doesn't affect the value now, but it may help remind
2995 future maintainers not to raise the value too much later.
2996 (SELECTION_QUANTUM): Remove, replacing with ...
2997 (selection_quantum): ... new function, which avoids overflow.
2999 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3000 assumption that selection length fits in 'int'.
3001 (x_reply_selection_request, x_handle_selection_request)
3002 (x_get_window_property, receive_incremental_selection)
3003 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3004 (lisp_data_to_selection_data, clean_local_selection_data):
3005 Use ptrdiff_t, not int, to record length of selection.
3006 (x_reply_selection_request, x_get_window_property)
3007 (receive_incremental_selection, x_property_data_to_lisp):
3008 Redo calculations to avoid overflow.
3009 (x_reply_selection_request): When sending hint, ceiling it at
3010 X_LONG_MAX rather than relying on wraparound overflow to send
3012 (x_get_window_property, receive_incremental_selection)
3013 (lisp_data_to_selection_data, x_property_data_to_lisp):
3014 Check for size-calculation overflow.
3015 (x_get_window_property, receive_incremental_selection)
3016 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3017 Don't store size until memory allocation succeeds.
3018 (x_get_window_property): Plug memory leak on memory exhaustion.
3019 Don't double-block input; malloc is safe here. Don't assume 2**34
3020 - 4 fits in unsigned long. Add an xassert to check
3021 XGetWindowProperty overflow. Be more careful about overflow
3022 calculations, and distinguish size from memory overflow better.
3023 (receive_incremental_selection): When tracing, don't assume
3024 unsigned int is less than INT_MAX.
3025 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3026 harmful) conversions of unsigned short to int.
3027 (lisp_data_to_selection_data): Don't assume that integers
3028 in the range -65535 through -1 fit in an X unsigned short.
3029 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3030 result parameters unless successful. Rely on cons_to_unsigned
3031 to report problems with elements; the old code wasn't right anyway.
3032 (x_check_property_data): Check for int overflow; we cannot use
3033 a wider type due to X limits.
3034 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3036 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3038 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3039 (x_term_init): Check for size calculation overflow.
3040 (x_color_cells): Don't store size until memory allocation succeeds.
3041 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3042 Don't assume alloca size is less than MAX_ALLOCA.
3043 (x_term_init): Don't assume length fits in int (sprintf is limited
3046 Use ptrdiff_t for composition IDs.
3047 * character.c (lisp_string_width):
3048 * composite.c (composition_table_size, n_compositions)
3049 (get_composition_id, composition_gstring_from_id):
3050 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3051 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3052 * window.c (Frecenter):
3053 Use ptrdiff_t, not int, for composition IDs.
3054 * composite.c (get_composition_id): Check for integer overflow.
3055 * composite.h: Adjust prototypes to match the above changes.
3057 Use ptrdiff_t for hash table indexes.
3058 * category.c (hash_get_category_set):
3059 * ccl.c (ccl_driver):
3060 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3061 * coding.c (coding_system_charset_list, detect_coding_system):
3062 * coding.h (struct coding_system.id):
3063 * composite.c (get_composition_id, gstring_lookup_cache):
3064 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3065 * image.c (xpm_get_color_table_h):
3066 * lisp.h (hash_lookup, hash_put):
3067 * minibuf.c (Ftest_completion):
3068 Use ptrdiff_t for hash table indexes, not int (which is too
3069 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3070 32-bit --with-wide-int hosts).
3072 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3073 Add a FIXME comment about memory leaks.
3074 (syms_of_charset): Don't assume xmalloc returns.
3076 Don't assume that stated character widths fit in int.
3077 * character.c (Fchar_width, c_string_width, lisp_string_width):
3078 * character.h (CHAR_WIDTH):
3079 * indent.c (MULTIBYTE_BYTES_WIDTH):
3080 Use sanitize_char_width to avoid undefined and/or bad behavior
3081 with outlandish widths.
3082 * character.h (sanitize_tab_width): Rename from sanitize_width,
3083 now that we have two such functions. All uses changed.
3084 (sanitize_char_width): New inline function.
3086 Don't assume that tab-width fits in int.
3087 * character.h (sanitize_width): New inline function.
3088 (SANE_TAB_WIDTH): New macro.
3089 (ASCII_CHAR_WIDTH): Use it.
3090 * indent.c (sane_tab_width): Remove. All uses replaced by
3091 SANE_TAB_WIDTH (current_buffer).
3092 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3094 * fileio.c: Integer overflow issues with file modes.
3095 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3097 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3098 Remove unreachable code.
3099 (read_hex, load_charset_map_from_file): Check for integer overflow.
3101 * xterm.c: don't go over XClientMessageEvent limit
3102 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3103 (x_send_scroll_bar_event): Likewise. Check that the size does not
3104 exceed limits imposed by XClientMessageEvent, as well as the usual
3105 ptrdiff_t and size_t limits.
3107 * keyboard.c: Overflow, signedness and related fixes.
3108 (make_lispy_movement): Use same integer type in forward decl
3109 that is used in the definition.
3110 (read_key_sequence, keyremap_step):
3111 Change bufsize argument back to int, undoing my 2011-03-30 change.
3112 We prefer signed types, and int is wide enough here.
3113 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3114 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3115 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3116 length, not size_t. Use ptrdiff_t for index, not int.
3117 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3118 possibility of integer overflow.
3120 Overflow, signedness and related fixes for images.
3122 * dispextern.h (struct it.stack[0].u.image.image_id)
3123 (struct_it.image_id, struct image.id, struct image_cache.size)
3124 (struct image_cache.used, struct image_cache.ref_count):
3125 * gtkutil.c (update_frame_tool_bar):
3126 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3127 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3128 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3129 * nsmenu.m (update_frame_tool_bar):
3130 * xdisp.c (calc_pixel_width_or_height):
3131 * xfns.c (image_cache_refcount):
3132 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3133 on typical 64-bit hosts.
3135 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3136 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3137 Omit unnecessary casts to int.
3138 (parse_image_spec): Check that integers fall into 'int' range
3139 when the callers expect that.
3140 (image_ascent): Redo ascent calculation to avoid int overflow.
3141 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3142 (lookup_image): Remove unnecessary tests.
3143 (xbm_image_p): Locals are now of int, not EMACS_INT,
3144 since parse_image_check makes sure they fit into int.
3145 (png_load, gif_load, svg_load_image):
3146 Prefer int to unsigned where either will do.
3147 (tiff_handler): New function, combining the cores of the
3148 old tiff_error_handler and tiff_warning_handler.
3149 This function is rewritten to use vsnprintf and thereby avoid
3150 stack buffer overflows. It uses only the features of vsnprintf
3151 that are common to both POSIX and native Microsoft.
3152 (tiff_error_handler, tiff_warning_handler): Use it.
3153 (tiff_load, gif_load, imagemagick_load_image):
3154 Don't assume :index value fits in 'int'.
3155 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3156 (imagemagick_load_image): Check that crop parameters fit into
3157 the integer types that MagickCropImage accepts. Don't assume
3158 Vimagemagick_render_type has a nonnegative value. Don't assume
3159 size_t fits in 'long'.
3160 (gs_load): Use printmax_t to print the widest integers possible.
3161 Check for integer overflow when computing image height and width.
3163 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3165 * xdisp.c (redisplay_window): Don't force window start if point
3166 will be invisible in the resulting window. (Bug#9324)
3168 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3170 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3171 the display spec is of the form `(space ...)'.
3172 (handle_display_spec): Return the value returned by
3173 handle_single_display_spec, not just 1 or zero.
3174 (handle_single_display_spec): If the display spec is of the form
3175 `(space ...)', and specifies display in the text area, return 2
3177 (try_cursor_movement): Check for the need to scroll more
3178 accurately, and prefer exact match for point under bidi.
3179 Don't advance `row' beyond the last row of the window.
3181 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3182 into disp_prop; all users changed.
3184 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3185 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3186 for the text covered by the display property.
3188 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3190 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3191 Change return value to nil.
3192 (Frecord_buffer): Delete unused function.
3194 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3196 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3197 buffers, return left-to-right.
3198 (set_cursor_from_row): Consider candidate row a win if its glyph
3199 represents a newline and point is on that newline. Fixes cursor
3200 positioning on the newline at EOL of R2L text within L2R
3201 paragraph, and vice versa.
3202 (try_cursor_movement): Check continued rows, in addition to
3203 continuation rows. Fixes unwarranted scroll when point enters a
3204 continued line of R2L text within an L2R paragraph, or vice versa.
3205 (cursor_row_p): Consider the case of point being equal to
3206 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3207 from the end of a short line to the beginning of a continued line
3208 of R2L text within L2R paragraph.
3209 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3210 composed characters.
3212 * bidi.c (bidi_check_type): Use xassert.
3213 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3216 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3218 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3221 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3223 * nsfont.m (ns_otf_to_script): Fix typo.
3225 2011-08-22 Kenichi Handa <handa@m17n.org>
3227 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3228 extra slot even if the purpose is char-code-property-table.
3230 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3232 * xdisp.c (redisplay_window): When computing centering_position,
3233 account for the height of the header line. (Bug#8874)
3235 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3236 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3237 candidate is selected by the mouse, and that candidate has a
3238 composed character under the mouse.
3240 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3241 coordinates reported by pos-visible-in-window-p for a composed
3242 character in column zero.
3244 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3246 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3248 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3250 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3251 consider it a hit if to_charpos is anywhere in the range of the
3252 composed buffer positions.
3254 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3256 * image.c (gif_load): Don't assume that each subimage has the same
3257 dimensions as the base image. Handle disposal method that is
3258 "undefined" by the gif spec (Bug#9335).
3260 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3262 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3263 (Fcondition_case): Document `debug' symbol in error handler.
3265 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3267 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3268 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3269 from an Org mode buffer to a Speedbar frame.
3271 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3272 a composition, take its buffer position from IT->cmp_it.charpos.
3273 Fixes cursor positioning at the beginning of a line that begins
3274 with a composed character.
3276 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3278 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3279 character bidirectional type, use STRONG_L instead. Fixes crashes
3280 in a buffer produced by `describe-categories'.
3282 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3283 members before the level stack, so they would be saved and
3284 restored when copying iterator state. Fixes incorrect reordering
3285 around TABs covered by display properties.
3287 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3289 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3291 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3293 * eval.c (internal_condition_case, internal_condition_case_1)
3294 (internal_condition_case_2, internal_condition_case_n):
3295 Remove unnecessary aborts (Bug#9081).
3297 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3299 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3300 has no `load' handler, try opening the file locally. (Bug#9311)
3302 2011-08-16 Ken Brown <kbrown@cornell.edu>
3304 * gmalloc.c: Expand comment.
3306 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3308 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3309 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3311 2011-08-16 Ken Brown <kbrown@cornell.edu>
3313 Fix memory allocation problems in Cygwin build (Bug#9273).
3315 * unexcw.c ( __malloc_initialized): Declare external variable.
3316 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3318 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3320 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3322 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3324 [CYGWIN] (special_realloc): New function.
3325 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3326 requests to realloc storage in the static heap.
3328 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3330 * bidi.c (bidi_initialize): Remove unused local.
3332 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3335 * biditype.h: Remove file.
3336 * makefile.w32-in ($(BLD)/bidi.$(O)):
3337 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3339 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3341 * chartab.c: Improve commentary for the uniprop_table API.
3343 * bidi.c (bidi_paragraph_init): Support zero value of
3344 bidi_ignore_explicit_marks_for_paragraph_level.
3345 (bidi_initialize): Use uniprop_table instead of including
3346 biditype.h and bidimirror.h.
3348 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3349 coordinates of the iterator when restoring from ppos_it.
3352 2011-08-14 Kenichi Handa <handa@m17n.org>
3354 * process.c (create_process): Call setup_process_coding_systems
3355 after the pid of the process is set to -1 (Bug#8162).
3357 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3359 * xdisp.c (move_it_in_display_line_to): Don't invoke
3360 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3361 ppos_it. Fixes vertical cursor motion when line beginning is
3362 covered by an image. (Bug#9296)
3364 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3366 * nsterm.h (ns_run_ascript): Declare.
3367 (NSAPP_DATA2_RUNASSCRIPT): Define.
3369 * nsfns.m (as_script, as_result, as_status): New static variables.
3370 (ns_run_ascript): New function.
3371 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3372 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3373 the event loop. Get status from as_status (Bug#7276).
3375 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3376 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3377 the event loop (Bug#7276).
3379 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3381 * gnutls.c (QCgnutls_bootprop_priority)
3382 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3383 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3384 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3385 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3386 (QCgnutls_bootprop_verify_hostname_error)
3387 (QCgnutls_bootprop_callbacks_verify): Rename from
3388 Qgnutls_bootprop_..., all uses changed.
3390 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3393 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3395 * xfaces.c (Qframe_set_background_mode): Now static.
3396 * dispextern.h (Qframe_set_background_mode): Remove decl.
3398 * process.c (Fnetwork_interface_info): Declare local only if needed.
3400 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3402 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3403 (Fnetwork_interface_list): Allocate in increments of bytes instead
3404 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3405 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3407 (struct ifflag_def): notrailers is smart on OSX.
3408 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3409 Get hardware address with getifaddrs if available.
3411 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3413 * xdisp.c (iterate_out_of_display_property): xassert that
3414 IT->position is set to within IT->object's boundaries. Break from
3415 the loop as soon as EOB is reached; avoids infloops in redisplay
3416 when IT->position is set up wrongly due to some bug.
3417 Set IT->current to match the bidi iterator unconditionally.
3418 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3419 entry. Force push_it to save on the stack the current
3420 buffer/string position, to be restored by pop_it. Fix flags in
3421 the iterator structure wrt the object coming from a display
3422 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3423 properties. (Bug#9284)
3425 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3427 * fontset.c (fontset_get_font_group): Add proper type checks.
3430 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3432 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3433 and LC_VERSION_MIN_MACOSX.
3434 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3435 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3437 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3439 * xdisp.c (forward_to_next_line_start): Allow to use the
3440 no-display-properties-and-no-overlays under bidi display.
3441 Set disp_pos in the bidi iterator to avoid searches for display
3442 properties and overlays.
3444 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3446 * editfns.c (Fset_time_zone_rule): Document relationship with the
3449 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3450 the font entity extracted from the cache (Bug#8109).
3452 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3454 * composite.c (autocmp_chars): Don't reset point. That is done by
3455 restore_point_unwind (Bug#5984).
3457 2011-08-07 Juri Linkov <juri@jurta.org>
3459 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3460 to show the arg `TIME' instead of `TIMEVAL'.
3462 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3464 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3465 display property strides EOL and includes a newline, as in
3466 longlines-mode. (Bug#9254)
3467 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3468 word-wrap under bidirectional display. (Bug#9224)
3470 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3471 is non-zero, even if the data buffer is NULL. Fixes a crash in
3472 vertical-motion with longlines-mode. (Bug#9254)
3474 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3476 * bidi.c <bidi_cache_total_alloc>: Now static.
3477 (bidi_initialize): Initialize bidi_cache_total_alloc.
3479 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3482 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3483 amount allocated this far in `bidi_cache_total_alloc'.
3484 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3485 non-zero, only free the data buffer without restoring the cache
3486 contents. All callers changed.
3488 * dispextern.h (bidi_unshelve_cache): Update prototype.
3490 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3491 (move_it_in_display_line, move_it_to)
3492 (move_it_vertically_backward, move_it_by_lines): Replace the call
3493 to xfree to an equivalent call to bidi_unshelve_cache.
3494 (move_it_in_display_line_to): Fix logic of returning
3495 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3497 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3499 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3500 came from a string character with a `cursor' property. (Bug#9229)
3502 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3504 * Makefile.in (LIB_PTHREAD): New variable.
3505 (LIBES): Add LIB_PTHREAD (Bug#9216).
3507 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3508 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3510 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3512 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3514 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3516 * xterm.c (x_find_topmost_parent): New function.
3517 (x_set_frame_alpha): Find topmost parent window with
3518 x_find_topmost_parent and set the property there also (bug#9181).
3519 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3521 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3523 * callproc.c (Fcall_process): Avoid vfork clobbering
3524 the local vars buffer, coding_systems, current_dir.
3526 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3528 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3530 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3532 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3533 so that it is not optimized away.
3535 * xdisp.c (compute_display_string_pos): Remove unused local.
3537 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3539 Fix slow cursor motion and scrolling in large buffers with
3540 selective display, like Org Mode buffers. (Bug#9218)
3542 * dispextern.h (struct bidi_it): New member disp_prop_p.
3544 * xdisp.c: Remove one-slot cache of display string positions.
3545 (compute_display_string_pos): Accept an additional argument
3546 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3547 for a display string or property. If found, set DISP_PROP_P
3550 * bidi.c (bidi_fetch_char): Accept an additional argument
3551 DISP_PROP_P, and pass it to compute_display_string_pos.
3552 Only handle text covered by a display string if DISP_PROP_P is returned
3553 non-zero. All callers of bidi_fetch_char changed.
3555 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3557 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3559 2010-12-03 Don March <don@ohspite.net>
3561 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3562 last character M-[char] is translated to ESC [char] (bug#7541).
3564 2011-08-02 Kenichi Handa <handa@m17n.org>
3566 * lisp.h (uniprop_table): Extern it.
3568 * chartab.c (uniprop_table): Make it non-static.
3570 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3572 * xdisp.c (forward_to_next_line_start): Accept additional argument
3573 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3575 (reseat_at_next_visible_line_start): Use the bidi iterator state
3576 returned by forward_to_next_line_start to restore the state of
3577 it->bidi_it after backing up to previous newline. (Bug#9212)
3579 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3581 * regex.c (re_comp): Protoize.
3582 (re_exec): Fix return type.
3583 (regexec): Fix type of `ret'. (Bug#9203)
3585 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3587 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3588 This is needed if max-image-size is a floating-point number.
3590 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3592 * print.c (print_object): Print empty symbol as ##.
3594 * lread.c (read1): Read ## as empty symbol.
3596 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3598 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3599 setting frame foreground color (Bug#9175).
3600 (x_set_background_color): Likewise.
3602 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3603 contents (Bug#9176).
3604 (EmacsTooltip -init): Remove bezels and add shadows to
3607 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3608 or scroll bar (Bug#8470).
3610 * nsfont.m (nsfont_open): Remove assignment to voffset and
3611 unnecessary vars hshink, expand, hd, full_height, min_height.
3612 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3614 * nsterm.h (nsfont_info): Remove voffset field.
3616 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3618 Implement strike-through and overline on NextStep (Bug#8863).
3620 * nsfont.m (nsfont_open): Use underline position provided by font,
3621 instead of hard-coded value of 2.
3622 (nsfont_draw): Call ns_draw_text_decoration instead.
3624 * nsterm.h: Add declaration for ns_draw_text_decoration.
3626 * nsterm.m (ns_draw_text_decoration): New function for drawing
3627 underline, overline, and strike-through.
3628 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3629 ns_draw_text_decoration. Change treatment of cursor drawing to
3630 accommodate underlining, etc.
3632 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3634 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3637 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3639 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3640 Without this fix, if a signal arrives just after memory fills up,
3641 'malloc' might be invoked reentrantly.
3643 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3644 In other words, assume that every image size is allowed, on non-X
3645 hosts. This assumption is probably wrong, but it lets Emacs compile.
3647 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3649 * regex.c (re_iswctype): Convert return values to boolean.
3651 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3653 * xdisp.c (compute_display_string_pos): Don't use cached display
3654 string position if the buffer had its restriction changed.
3657 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3659 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3661 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3663 Integer signedness and overflow and related fixes. (Bug#9079)
3665 * bidi.c: Integer size and overflow fixes.
3666 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3667 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3668 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3669 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3670 (bidi_find_other_level_edge):
3671 Use ptrdiff_t instead of EMACS_INT where either will do.
3672 This works better on 32-bit hosts configured --with-wide-int.
3673 (bidi_cache_ensure_space): Check for size-calculation overflow.
3674 Use % rather than repeated addition, for better worst-case speed.
3675 Don't set bidi_cache_size until after xrealloc returns, because it
3677 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3678 (bidi_cache_ensure_space): Also check that the bidi cache size
3679 does not exceed that of the largest Lisp string or buffer. See Eli
3680 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3682 * alloc.c (__malloc_size_t): Remove.
3683 All uses replaced by size_t. See Andreas Schwab's note
3684 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3686 * image.c: Improve checking for integer overflow.
3687 (check_image_size): Assume that f is nonnull, since
3688 it is always nonnull in practice. This is one less thing to
3689 worry about when checking for integer overflow later.
3690 (x_check_image_size): New function, which checks for integer
3691 overflow issues inside X.
3692 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3693 This removes the need for a memory_full check.
3694 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3695 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3696 (xbm_read_bitmap_data): Change locals back to 'int', since
3697 their values must fit in 'int'.
3698 (xpm_load_image, png_load, tiff_load):
3699 Invoke x_create_x_image_and_pixmap earlier,
3700 to avoid much needless work if the image is too large.
3701 (tiff_load): Treat overly large images as if
3702 x_create_x_image_and_pixmap failed, not as malloc failures.
3703 (gs_load): Use x_check_image_size.
3705 * gtkutil.c: Omit integer casts.
3706 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3707 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3709 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3711 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3712 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3713 would wrongly return t on a 64-bit host.
3715 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3716 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3717 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3718 and therefore cause GCC to emit a bogus diagnostic in some cases.
3720 * image.c: Integer signedness and overflow and related fixes.
3721 This is not an exhaustive set of fixes, but it's time to
3722 record what I've got.
3723 (lookup_pixel_color, check_image_size): Remove redundant decls.
3724 (check_image_size): Don't assume that arbitrary EMACS_INT values
3725 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3726 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3727 (tiff_load, imagemagick_load_image):
3728 Check for overflow in size calculations.
3729 (x_create_x_image_and_pixmap): Remove unnecessary test for
3730 xmalloc returning NULL; that can't happen.
3731 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3732 (xpm_color_bucket): Use better integer hashing function.
3733 (xpm_cache_color): Don't possibly over-allocate memory.
3734 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3735 (gif_memory_source):
3736 Use ptrdiff_t, not int or size_t, to record sizes.
3737 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3738 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3739 either works, as we prefer signed integers.
3740 (tiff_read_from_memory, tiff_write_from_memory):
3741 Return tsize_t, not size_t, since that's what the TIFF API wants.
3742 (tiff_read_from_memory): Don't fail simply because the read would
3743 go past EOF; instead, return a short read.
3744 (tiff_load): Omit no-longer-needed casts.
3745 (Fimagemagick_types): Don't assume size fits into 'int'.
3747 Improve hashing quality when configured --with-wide-int.
3748 * fns.c (hash_string): New function, taken from sxhash_string.
3749 Do not discard information about ASCII character case; this
3750 discarding is no longer needed.
3751 (sxhash-string): Use it. Change sig to match it. Caller changed.
3752 * lisp.h: Declare it.
3753 * lread.c (hash_string): Remove, since we now use fns.c's version.
3754 The fns.c version returns a wider integer if --with-wide-int is
3755 specified, so this should help the quality of the hashing a bit.
3757 * emacs.c: Integer overflow minor fix.
3758 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3759 Define only if GNU_LINUX.
3760 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3762 * dispnew.c: Integer signedness and overflow fixes.
3763 Remove unnecessary forward decls, that were a maintenance hassle.
3764 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3766 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3767 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3768 (prepare_desired_row, line_draw_cost):
3769 Use int, not unsigned, where either works.
3770 (save_current_matrix, restore_current_matrix):
3771 Use ptrdiff_t, not size_t, where either works.
3772 (init_display): Check for overflow more accurately, and without
3773 relying on undefined behavior.
3775 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3776 Remove, replacing with the new symbols in lisp.h. All uses changed.
3777 * fileio.c (make_temp_name):
3778 * filelock.c (lock_file_1, lock_file):
3779 * xdisp.c (message_dolog):
3780 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3781 Use pMd etc. instead.
3782 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3783 replacing the pWIDE etc. symbols removed from editfns.c.
3785 * keyboard.h (num_input_events): Now uintmax_t.
3786 This is (very slightly) less likely to mess up due to wraparound.
3789 * buffer.c: Integer signedness fixes.
3790 (alloc_buffer_text, enlarge_buffer_text):
3791 Use ptrdiff_t rather than size_t when either will do, as we prefer
3794 * alloc.c: Integer signedness and overflow fixes.
3795 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3796 (__malloc_size_t): Default to size_t, not to int.
3797 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3798 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3799 Prefer ptrdiff_t to size_t when either would do, as we prefer
3801 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3802 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3803 Now const. Initialize with values that are in range even if char
3805 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3806 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3807 These functions do the right thing with sizes > 2**32.
3808 (check_depth): Now ptrdiff_t, not int.
3809 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3810 Adjust to new way of storing sizes. Check for size overflow bugs
3812 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3813 slightly wrong anyway, as it missed one instance of
3814 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3815 (refill_memory_reserve): Omit needless cast to size_t.
3816 (mark_object_loop_halt): Mark as externally visible.
3818 * xselect.c: Integer signedness and overflow fixes.
3819 (Fx_register_dnd_atom, x_handle_dnd_message):
3820 Use ptrdiff_t, not size_t, since we prefer signed.
3821 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3822 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3823 x_dnd_atoms_size and x_dnd_atoms_length.
3825 * doprnt.c: Prefer signed to unsigned when either works.
3827 * doprnt.c (doprnt):
3829 * xdisp.c (vmessage):
3830 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3831 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3832 prefer signed arithmetic to avoid comparison confusion.
3833 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3834 but is a bit tricky.
3836 Assume freestanding C89 headers, string.h, stdlib.h.
3837 * data.c, doprnt.c, floatfns.c, print.c:
3838 Include float.h unconditionally.
3839 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3840 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3841 * regex.c: Likewise for stddef.h, string.h.
3842 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3843 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3844 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3845 (STDC_HEADERS): Remove obsolete defines.
3846 * sysdep.c: Include limits.h unconditionally.
3848 Assume support for memcmp, memcpy, memmove, memset.
3849 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3850 * regex.c (memcmp, memcpy):
3851 Remove; we assume C89 now.
3853 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3854 (__malloc_safe_bcopy): Remove; no longer needed.
3856 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3857 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3858 well either way, and we prefer signed to unsigned.
3860 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3862 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3863 closes the connection while we're reading (bug#9182).
3865 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3867 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3868 are specified (Bug#9168).
3870 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3872 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3873 Found by GCC static checking and --with-wide-int on a 32-bit host.
3875 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3877 * xdisp.c (compute_display_string_pos): Fix logic of caching
3878 previous display string position. Initialize cached_prev_pos to
3879 -1. Fixes slow-down at the beginning of a buffer.
3881 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3883 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3884 for attrs[LFACE_FONTSET_INDEX].
3886 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3888 * xml.c (parse_region): Remove unused local
3889 that was recently introduced.
3891 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3893 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3894 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3896 * xdisp.c (move_it_in_display_line_to): Record the best matching
3897 position for TO_CHARPOS while scanning the line, and restore it on
3898 exit if none of the characters scanned was an exact match.
3899 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3900 when exact match is impossible due to invisible text, and the
3901 lines are truncated.
3903 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3905 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3908 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3910 Fix a significant slow-down of cursor motion with C-n, C-p,
3911 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3912 auto-repeat under bidi redisplay in fontified buffers.
3913 * xdisp.c (compute_stop_pos_backwards): New function.
3914 (next_element_from_buffer): Call compute_stop_pos_backwards to
3915 find a suitable prev_stop when we find ourselves before
3917 (reseat): Don't look for prev_stop, as that could mean a very long
3919 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3920 <cached_disp_overlay_modiff>: Cache for last found display string
3922 (compute_display_string_pos): Return the cached position if asked
3923 about the same buffer in the same area of character positions, and
3924 the buffer wasn't changed since the time the display string
3925 position was cached.
3927 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3929 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3930 is an integer, which is important for empty lines. (Bug#9149)
3932 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3934 * frame.c (Fmodify_frame_parameters): In tty case, update the
3935 default face if necessary (Bug#4238).
3937 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3939 * editfns.c (Fstring_to_char): No need to explain what a character
3940 is in the docstring (Bug#6576).
3942 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3944 * xml.c (parse_region): Make sure we always return a tree.
3946 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3948 * xml.c (parse_region): If a document contains only comments,
3951 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3953 * xml.c (make_dom): Return comments, too.
3955 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3958 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3959 and the surrounding thread.
3960 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3961 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3962 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3964 * s/openbsd.h (BROKEN_SIGIO): Define.
3965 * unexelf.c (unexec) [__OpenBSD__]:
3966 Don't update the .mdebug section of the Alpha COFF symbol table.
3968 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3970 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3973 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3975 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3976 This fixes some race conditions on the permissions of any newly
3979 * alloc.c (valid_pointer_p): Use pipe, not open.
3980 This fixes some permissions issues when debugging.
3982 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3983 If fchown fails to set both uid and gid, try to set just gid,
3984 as that is sometimes allowed. Adjust the file's mode to eliminate
3985 setuid or setgid bits that are inappropriate if fchown fails.
3987 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3989 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3990 to compare Lisp_Objects.
3991 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3992 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3993 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3995 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3997 * lread.c (read_integer): Unread even EOF character.
3998 (read1): Likewise. Properly record start position of symbol.
4000 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4001 symbol character follows.
4003 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4005 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4006 This works around a problem with the previous change to Fcopy_file.
4007 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4008 and without this change, GCC might complain about discarding
4009 fchown's return value.
4011 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4013 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4015 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4017 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4019 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4021 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4022 it's used from the C level.
4024 * process.c: Use the same condition for POLL_FOR_INPUT in both
4025 keyboard.c and process.c (bug#1858).
4027 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4029 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4030 (Fgnutls_boot): Use it.
4032 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4034 * doc.c (Fsubstitute_command_keys): Revert last change.
4036 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4038 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4039 quotes the next character, and doesn't affect other longer
4040 sequences (bug#8935).
4042 * lread.c (syms_of_lread): Clarify that is isn't only
4043 `eval-buffer' and `eval-defun' that's affected by
4044 `lexical-binding' (bug#8460).
4046 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4048 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4049 bidi redisplay when a line includes both an image and is truncated.
4051 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4053 Fix minor problems found by static checking.
4054 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4055 (elsz): Now a signed constant, not a size_t var. We prefer signed
4056 types to unsigned, to avoid integer comparison confusion. Without
4057 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4058 "cannot optimize loop, the loop counter may overflow", a symptom
4060 * indent.c (Fvertical_motion): Mark locals as initialized.
4061 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4063 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4065 * search.c (Fre_search_backward): Mention `case-fold-search' in
4066 all the re_search_* functions (bug#8138).
4068 * keyboard.c (Fopen_dribble_file): Document when the file is
4071 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4073 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4076 Support bidi reordering of display and overlay strings.
4077 * xdisp.c (compute_display_string_pos)
4078 (compute_display_string_end): Accept additional argument STRING.
4079 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4080 (reseat_to_string): Initialize bidi_it->string.s and
4081 bidi_it->string.schars.
4082 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4083 NULL (avoids a crash in bidi_paragraph_init).
4084 Initialize itb.string.lstring.
4085 (init_iterator): Call bidi_init_it only of a valid
4086 buffer position was specified. Initialize paragraph_embedding to
4088 (reseat_to_string): Initialize the bidi iterator.
4089 (display_string): If we need to ignore text properties of
4090 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4091 original value of -1 will not work with bidi.)
4092 (compute_display_string_pos): First arg is now struct
4093 `text_pos *'; all callers changed. Support display properties on
4095 (compute_display_string_end): Support display properties on Lisp
4097 (init_iterator, reseat_1, reseat_to_string): Initialize the
4098 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4099 when iterating on a string not from display properties).
4100 (compute_display_string_pos, compute_display_string_end):
4101 Fix calculation of the object to scan. Fixes an error when using
4103 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4104 base_level_stop; instead, set base_level_stop to BEGV.
4105 Fixes crashes in vertical-motion.
4106 (next_element_from_buffer): Improve commentary for when
4107 the iterator is before prev_stop.
4108 (init_iterator): Initialize bidi_p from the default value of
4109 bidi-display-reordering, not from buffer-local value. Use the
4110 buffer-local value only if initializing for buffer iteration.
4111 (handle_invisible_prop): Support invisible properties on strings
4112 that are being bidi-reordered.
4113 (set_iterator_to_next): Support bidi reordering of C strings and
4115 (next_element_from_string): Support bidi reordering of Lisp
4117 (handle_stop_backwards): Support Lisp strings as well.
4118 (display_string): Support display of R2L glyph rows.
4119 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4120 (init_iterator): Don't initialize it->bidi_p for strings
4122 (reseat_to_string): Initialize it->bidi_p for strings here.
4123 (next_element_from_string, next_element_from_c_string)
4124 (next_element_from_buffer): Add xassert's for correspondence
4125 between IT's object being iterated and it->bidi_it.string
4127 (face_before_or_after_it_pos): Support bidi iteration.
4128 (next_element_from_c_string): Handle the case of the first string
4129 character that is not the first one in the visual order.
4130 (get_visually_first_element): New function, refactored from common
4131 parts of next_element_from_buffer, next_element_from_string, and
4132 next_element_from_c_string.
4133 (tool_bar_lines_needed, redisplay_tool_bar)
4134 (display_menu_bar): Force left-to-right direction. Add a FIXME
4135 comment for making that be controlled by a user option.
4136 (push_it, pop_it): Save and restore the state of the
4137 bidi iterator. Save and restore the bidi_p flag.
4138 (pop_it): Iterate out of display property for string iteration as
4140 (iterate_out_of_display_property): Support iteration over strings.
4141 (handle_single_display_spec): Set up it->bidi_it for iteration
4142 over a display string, and call bidi_init_it.
4143 (handle_single_display_spec, next_overlay_string)
4144 (get_overlay_strings_1, push_display_prop): Set up the bidi
4145 iterator for displaying display or overlay strings.
4146 (forward_to_next_line_start): Don't use the shortcut if
4148 (back_to_previous_visible_line_start): If handle_display_prop
4149 pushed the iterator stack, restore the internal state of the bidi
4150 iterator by calling bidi_pop_it same number of times.
4151 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4152 and we are bidi-iterating, don't decrement the iterator position;
4153 instead, set the first_elt flag in the bidi iterator, to produce
4155 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4156 (push_display_prop): xassert that we are iterating a buffer.
4157 (push_it, pop_it): Save and restore paragraph_embedding member.
4158 (handle_single_display_spec, next_overlay_string)
4159 (get_overlay_strings_1, reseat_1, reseat_to_string)
4160 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4161 correctly. Don't assume unibyte strings are not bidi-reordered.
4162 (compute_display_string_pos)
4163 (compute_display_string_end): Fix handling the case of C string.
4164 (push_it, pop_it): Save and restore from_disp_prop_p.
4165 (handle_single_display_spec, push_display_prop): Set the
4166 from_disp_prop_p flag.
4167 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4168 (pop_it): Call iterate_out_of_display_property only if we are
4169 popping after iteration over a string that came from a display
4170 property. Fix a typo in popping stretch info. Add an assertion
4171 for verifying that the iterator position is in sync with the bidi
4173 (handle_single_display_spec, get_overlay_strings_1)
4174 (push_display_prop): Fix initialization of paragraph direction for
4175 string when that of the parent object is not yet determined.
4176 (reseat_1): Call bidi_init_it to resync the bidi
4177 iterator with IT's position. (Bug#7616)
4178 (find_row_edges): If ROW->start.pos gives position
4179 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4180 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4181 Reset the from_disp_prop_p flag.
4182 (SAVE_IT, RESTORE_IT): New macros.
4183 (pos_visible_p, face_before_or_after_it_pos)
4184 (back_to_previous_visible_line_start)
4185 (move_it_in_display_line_to, move_it_in_display_line)
4186 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4187 (try_scrolling, redisplay_window, display_line): Use them when
4188 saving a temporary copy of the iterator and restoring it back.
4189 (back_to_previous_visible_line_start, reseat_1)
4190 (init_iterator): Empty the bidi cache "stack".
4191 (move_it_in_display_line_to): If iterator ended up at
4192 EOL, but we never saw any buffer positions smaller than
4193 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4194 motion in bidi-reordered lines.
4195 (move_it_in_display_line_to): Record prev_method and prev_pos
4196 immediately before the call to set_iterator_to_next. Fixes cursor
4197 motion in bidi-reordered lines with stretch glyphs and strings
4198 displayed in margins. (Bug#8133) (Bug#8867)
4199 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4201 (pos_visible_p): Support positions in bidi-reordered lines.
4202 Save and restore bidi cache.
4204 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4205 (bidi_paragraph_info): Delete unused struct.
4206 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4207 (bidi_cache_start): New variable.
4208 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4210 (bidi_cache_fetch_state, bidi_cache_search)
4211 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4212 (bidi_cache_find, bidi_peek_at_next_level)
4213 (bidi_level_of_next_char, bidi_find_other_level_edge)
4214 (bidi_move_to_visually_next): Compare cache index with
4215 bidi_cache_start rather than with zero.
4216 (bidi_fetch_char): Accept new argument STRING; all callers
4217 changed. Support iteration over a string. Support strings with
4218 display properties. Support unibyte strings. Fix the type of
4219 `len' according to what STRING_CHAR_AND_LENGTH expects.
4220 (bidi_paragraph_init, bidi_resolve_explicit_1)
4221 (bidi_resolve_explicit, bidi_resolve_weak)
4222 (bidi_level_of_next_char, bidi_move_to_visually_next):
4223 Support iteration over a string.
4224 (bidi_set_sor_type, bidi_resolve_explicit_1)
4225 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4226 can now be zero (for strings); special values 0 and -1 were
4227 changed to -1 and -2, respectively.
4228 (bidi_char_at_pos): New function.
4229 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4230 Call it instead of FETCH_MULTIBYTE_CHAR.
4231 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4232 initialized to valid values.
4233 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4235 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4236 the test for valid cached positions. Fix the logic for looking up
4237 the sentinel state in the cache. GCPRO the Lisp string we are
4239 (bidi_push_it, bidi_pop_it): New functions.
4240 (bidi_initialize): Initialize the bidi cache start stack pointer.
4241 (bidi_cache_ensure_space): New function, refactored from part of
4242 bidi_cache_iterator_state. Don't assume the required size is just
4243 one BIDI_CACHE_CHUNK away.
4244 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4245 (bidi_count_bytes, bidi_char_at_pos): New functions.
4246 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4247 always valid if bidi_cache_idx is valid.
4248 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4249 is valid if it's going to be used.
4250 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4251 (bidi_cache_fetch_state, bidi_cache_search)
4252 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4253 (bidi_cache_iterator_state, bidi_cache_find)
4254 (bidi_find_other_level_edge, bidi_cache_start_stack):
4255 All variables related to cache indices are now EMACS_INT.
4257 * dispextern.h (struct bidi_string_data): New structure.
4258 (struct bidi_it): New member `string'. Make flag members be 1-bit
4259 fields, and put them last in the struct.
4260 (compute_display_string_pos, compute_display_string_end):
4262 (bidi_push_it, bidi_pop_it): Add prototypes.
4263 (struct iterator_stack_entry): New members bidi_p,
4264 paragraph_embedding, and from_disp_prop_p.
4265 (struct it): Member bidi_p is now a bit field 1 bit wide.
4266 (bidi_shelve_cache, bidi_unshelve_cache):
4269 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4270 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4271 and vector-like objects.
4273 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4274 cache around display iteration.
4276 * window.c (Fwindow_end, window_scroll_pixel_based)
4277 (displayed_window_lines, Frecenter): Save and restore the bidi
4278 cache around display iteration.
4280 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4282 * editfns.c (Fdelete_region): Clarify the use of the named
4283 parameters (bug#6788).
4285 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4287 * indent.c (Fvertical_motion): Set and restore w->pointm when
4288 saving and restoring the window's buffer (Bug#9006).
4290 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4292 * editfns.c (Fstring_to_char): Clarify just what is returned
4293 (bug#6576). Text by Eli Zaretskii.
4295 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4297 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4299 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4301 * buffer.c (mmap_find): Fix a typo.
4303 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4305 Fix execution of x selection hooks.
4306 * xselect.c (Qx_lost_selection_functions)
4307 (Qx_sent_selection_functions): New vars.
4308 (syms_of_xselect): DEFSYM them.
4309 (x_handle_selection_request): Pass Qx_sent_selection_functions
4310 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4311 (x_handle_selection_clear,x_clear_frame_selections):
4312 Pass Qx_lost_selection_functions rather than
4313 Vx_lost_selection_functions to Frun_hook_with_args.
4315 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4317 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4318 The old code sometimes used this field without initializing it.
4320 * alloc.c (gc_sweep): Don't read past end of array.
4321 In theory, the old code could also have corrupted Emacs internals,
4322 though it'd be very unlikely.
4324 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4326 * character.c (Fcharacterp): Don't advertise optional ignored
4327 argument. (Bug#4026)
4329 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4331 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4334 * window.c (Fset_window_start): Doc fix (bug#4199).
4335 (Fset_window_hscroll): Ditto.
4337 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4339 Fix minor new problems caught by GCC 4.6.1.
4340 * term.c (init_tty): Remove unused local.
4341 * xsettings.c (store_monospaced_changed): Define this function only
4342 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4345 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4347 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4349 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4351 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4352 are the mini-buffer and the echo area (bug#3320).
4354 * term.c (init_tty): Remove support for supdup, c10 and perq
4355 terminals, which are no longer supported (bug#1482).
4357 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4359 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4361 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4363 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4364 for non-popups (Bug#3642).
4366 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4368 * alloc.c (reset_malloc_hooks): Protoize.
4369 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4370 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4371 * cm.c (losecursor): Likewise.
4372 * data.c (fmod): Likewise.
4373 * dispnew.c (swap_glyphs_in_rows): Likewise.
4374 * emacs.c (memory_warning_signal): Likewise.
4375 * floatfns.c (float_error): Likewise.
4376 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4377 (otf_open, font_otf_capability, generate_otf_features)
4378 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4380 * image.c (pbm_read_file): Likewise.
4381 * indent.c (string_display_width): Likewise.
4382 * intervals.c (check_for_interval, search_for_interval)
4383 (inc_interval_count, count_intervals, root_interval)
4384 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4385 * lread.c (defalias): Likewise.
4386 * ralloc.c (r_alloc_check): Likewise.
4387 * regex.c (set_image_of_range_1, set_image_of_range)
4388 (regex_grow_registers): Likewise.
4389 * sysdep.c (strerror): Likewise.
4390 * termcap.c (valid_filename_p, tprint, main): Likewise.
4391 * tparam.c (main): Likewise.
4392 * unexhp9k800.c (run_time_remap, save_data_space)
4393 (update_file_ptrs, read_header, write_header, calculate_checksum)
4394 (copy_file, copy_rest, display_header): Likewise.
4395 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4397 * xdisp.c (check_it): Likewise.
4398 * xfaces.c (register_color, unregister_color, unregister_colors):
4400 * xfns.c (print_fontset_result): Likewise.
4401 * xrdb.c (member, fatal, main): Likewise.
4403 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4405 Fix minor problems found by static checking (Bug#9031).
4406 * chartab.c (char_table_set_range, map_sub_char_table):
4407 Remove unused locals.
4408 (uniprop_table): Now static.
4409 * composite.c (_work_char): Remove unused static var.
4411 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4413 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4415 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4417 * gtkutil.c (qttip_cb): Remove code without function.
4419 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4421 * w32.c (pthread_sigmask): New stub.
4423 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4425 Use pthread_sigmask, not sigprocmask (Bug#9010).
4426 sigprocmask is portable only for single-threaded applications, and
4427 Emacs can be multi-threaded when it uses GTK.
4428 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4430 * callproc.c (Fcall_process):
4431 * process.c (create_process):
4432 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4433 Use pthread_sigmask, not sigprocmask.
4435 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4437 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4438 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4441 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4443 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4444 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4445 (xg_hide_tooltip): Fix comment.
4447 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4448 in registerServicesMenuSendTypes.
4449 (validRequestorForSendType): Don't check ns_return_types.
4451 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4454 2011-07-08 Jason Rumney <jasonr@gnu.org>
4456 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4457 SH_SHOW for hidden windows (Bug#5482).
4459 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4460 frame struct members of non-existent frames (Bug#6284).
4462 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4464 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4465 variable firstTime not needed on OSX >= 10.6.
4466 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4467 >= 10.5. Use setKnobProportion, setDoubleValue.
4469 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4470 (MAC_OS_X_VERSION_10_5): Define if not defined.
4471 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4472 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4473 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4475 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4476 cString and lossyCString on OSX >= 10.4
4478 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4479 sizeToFit on OSX >= 10.2.
4481 * nsimage.m (allocInitFromFile): Don't use deprecated method
4482 bestRepresentationForDevice on OSX >= 10.6.
4484 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4487 * emacs.c: Declare unexec_init_emacs_zone.
4489 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4491 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4493 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4494 on svcsMenu (Bug#8842).
4496 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4498 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4500 * nsterm.m (QUTF8_STRING): Declare.
4501 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4502 (validRequestorForSendType): Return type is (id).
4503 Change indexOfObjectIdenticalTo to indexOfObject.
4504 Check if we have local selection before returning self (Bug#8842).
4505 (writeSelectionToPasteboard): Put local selection into paste board
4506 if we have a local selection (Bug#8842).
4507 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4509 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4510 (ns_get_local_selection): Declare.
4512 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4514 * keymap.c (describe_map_tree): Don't insert a double newline at
4515 the end of the buffer (bug#1169) and return whether we inserted
4518 * callint.c (Fcall_interactively): Change "reading args" to
4519 "providing args" to try to clarify what it does (bug#1010).
4521 2011-07-07 Kenichi Handa <handa@m17n.org>
4523 * composite.c (composition_compute_stop_pos): Ignore a static
4524 composition starting before CHARPOS (Bug#8915).
4526 * xdisp.c (handle_composition_prop): Likewise.
4528 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4530 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4533 2011-07-07 Kenichi Handa <handa@m17n.org>
4535 * character.h (unicode_category_t): New enum type.
4537 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4538 (Qchar_code_property_table): New variable.
4539 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4540 (UNIPROP_COMPRESSED_FORM_P): New macros.
4541 (char_table_ascii): Uncompress the compressed values.
4542 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4543 Uncompress the compressed values.
4544 (sub_char_table_ref_and_range): Likewise.
4545 (char_table_ref_and_range): Uncompress the compressed values.
4546 (sub_char_table_set): New arg is_uniprop. Callers changed.
4547 Uncompress the compressed values.
4548 (sub_char_table_set_range): Args changed. Callers changed.
4549 (char_table_set_range): Adjuted for the above change.
4550 (map_sub_char_table): Delete args default_val and parent. Add arg
4551 top. Give decoded values to a Lisp function.
4552 (map_char_table): Adjust for the above change. Give decoded
4553 values to a Lisp function. Gcpro more variables.
4554 (uniprop_table_uncompress)
4555 (uniprop_decode_value_run_length): New functions.
4556 (uniprop_decoder, uniprop_decoder_count): New variables.
4557 (uniprop_get_decoder, uniprop_encode_value_character)
4558 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4560 (uniprop_encoder, uniprop_encoder_count): New variables.
4561 (uniprop_get_encoder, uniprop_table)
4562 (Funicode_property_table_internal, Fget_unicode_property_internal)
4563 (Fput_unicode_property_internal): New functions.
4564 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4565 Sunicode_property_table_internal, Sget_unicode_property_internal,
4566 and Sput_unicode_property_internal. Defvar_lisp
4567 char-code-property-alist.
4569 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4570 Vunicode_category_table.
4572 * font.c (font_range): Adjust for the change of
4573 Vunicode_category_table.
4575 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4577 * m/iris4d.h: Remove file, move contents ...
4578 * s/irix6-5.h: ... here.
4580 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4582 Remove unportable assumption about struct layout (Bug#8884).
4583 * alloc.c (mark_buffer):
4584 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4585 (clone_per_buffer_values): Don't assume that
4586 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4587 This isn't true in general, and it's particularly not true
4588 if Emacs is configured with --with-wide-int.
4589 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4590 New macros, used in the buffer.c change.
4592 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4594 * xsettings.c: Use both GConf and GSettings if both are available.
4595 (store_config_changed_event): Add comment.
4596 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4597 (store_tool_bar_style_changed): New functions.
4598 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4599 (struct xsettings): Move font inside HAVE_XFT.
4600 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4601 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4602 Move inside HAVE_XFT.
4603 (something_changed_gsettingsCB): Rename from something_changedCB.
4604 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4606 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4607 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4608 (something_changed_gconfCB): Rename from something_changedCB.
4609 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4610 (parse_settings): Move check for font inside HAVE_XFT.
4611 (read_settings, apply_xft_settings): Add comment.
4612 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4613 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4614 call store_font_name_changed.
4615 (xft_settings_event): Add comment.
4616 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4617 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4618 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4619 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4620 (xsettings_initialize): Call init_gsettings last.
4621 (xsettings_get_system_font, xsettings_get_system_normal_font):
4624 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4626 Random fixes. E.g., (random) never returned negative values.
4627 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4628 subseconds part to the entropy, as that's a bit more random.
4629 Prefer signed to unsigned, since the signedness doesn't matter and
4630 in general we prefer signed. When given a limit, use a
4631 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4632 latter isn't right if USE_2_TAGS_FOR_INTS.
4633 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4634 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4636 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4638 * textprop.c (text_property_stickiness):
4639 Obey Vtext_property_default_nonsticky.
4640 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4641 * w32fns.c (syms_of_w32fns):
4642 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4644 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4646 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4647 This is more efficient than Ffile_directory_p and avoids a minor race.
4649 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4651 * buffer.c (Foverlay_put): Say what the return value is
4654 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4655 is a directory before asking whether to use the file name
4657 (barf_or_query_if_file_exists): Make the "File is a directory"
4658 error be more correct.
4660 * fns.c (Frequire): Remove the mention of the .gz files, since
4661 that's installation-specific, but keep the mention of
4662 `get-load-suffixes'.
4664 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4666 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4667 Report string overflow if the output is too long.
4669 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4671 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4672 (syms_of_gnutls): Remove duplicate DEFSYM for
4673 Qgnutls_bootprop_verify_hostname_error, an error for
4674 Qgnutls_bootprop_verify_error (which is no longer used).
4676 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4677 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4678 Also (re)move comments that are misplaced or no longer relevant.
4680 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4682 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4684 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4686 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4687 and background color parameters if they have been changed.
4689 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4691 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4693 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4695 * xsettings.c (SYSTEM_FONT): Define only when used.
4696 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4698 * keymap.c (access_keymap_1): Now static.
4700 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4702 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4703 leave any prefix arg for the up event (Bug#1586).
4705 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4707 * lread.c (syms_of_lread): Mention single symbols defined by
4708 `defvar' or `defconst' (bug#7154).
4710 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4711 (Frequire): Mention get-load-suffixes.
4713 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4715 * window.h (window): Remove clone_number slot.
4716 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4718 (make_parent_window, make_window, saved_window)
4719 (Fset_window_configuration, save_window_save): Don't deal with
4721 * buffer.c (Qclone_number): Remove declaration.
4722 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4724 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4726 Add multiple inheritance to keymaps.
4727 * keymap.c (Fmake_composed_keymap): New function.
4728 (Fset_keymap_parent): Simplify.
4729 (fix_submap_inheritance): Remove.
4730 (access_keymap_1): New function extracted from access_keymap to handle
4731 embedded parents and handle lists of maps.
4732 (access_keymap): Use it.
4733 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4734 (Fcopy_keymap): Handle embedded parents.
4735 (Fcommand_remapping, define_as_prefix): Simplify.
4736 (Fkey_binding): Simplify.
4737 (syms_of_keymap): Move minibuffer-local-completion-map,
4738 minibuffer-local-filename-completion-map,
4739 minibuffer-local-must-match-map, and
4740 minibuffer-local-filename-must-match-map to Elisp.
4741 (syms_of_keymap): Defsubr make-composed-keymap.
4742 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4743 (parse_menu_item): Trivial simplification.
4745 2011-07-01 Glenn Morris <rgm@gnu.org>
4747 * Makefile.in (SETTINGS_LIBS): Fix typo.
4749 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4751 * coding.c (Fencode_coding_string): Record the last coding system
4752 used, as the function doc string says (bug#8738).
4754 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4756 * xsettings.c (store_monospaced_changed): Take new font as arg and
4757 check for change against current_mono_font.
4758 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4759 (emacs_settings_constructor, emacs_settings_get_property)
4760 (emacs_settings_set_property, emacs_settings_class_init)
4761 (emacs_settings_init, gsettings_obj): Remove.
4762 (something_changedCB): New function for HAVE_GSETTINGS.
4763 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4764 with value as argument.
4765 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4766 g_settings_new (Bug#8967). Do not create gsettings_obj.
4767 Remove calls to g_settings_bind. Connect something_changedCB to
4770 * xgselect.c: Add defined (HAVE_GSETTINGS).
4771 (xgselect_initialize): Ditto.
4773 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4774 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4777 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4779 * eval.c (struct backtrace): Simplify and port the data structure.
4780 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4781 signed bit field, as this assumption is not portable and it makes
4782 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4783 "char debug_on_exit : 1" as this is not portable either; instead,
4784 use the portable "unsigned int debug_on_exit : 1". Remove unused
4785 member evalargs. Remove obsolete comments about cc bombing out.
4787 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4789 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4790 Let HAVE_GSETTINGS override HAVE_GCONF.
4791 (store_monospaced_changed): New function.
4792 (EMACS_SETTINGS): A new type derived from GObject to handle
4793 GSettings notifications.
4794 (emacs_settings_constructor, emacs_settings_get_property)
4795 (emacs_settings_set_property, emacs_settings_class_init):
4797 (gsettings_client, gsettings_obj): New variables.
4798 (GSETTINGS_SCHEMA): New define.
4799 (something_changedCB): Call store_monospaced_changed.
4800 (init_gsettings): New function.
4801 (xsettings_initialize): Call init_gsettings.
4802 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4805 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4808 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4810 * window.c (resize_root_window, grow_mini_window)
4811 (shrink_mini_window): Rename Qresize_root_window to
4812 Qwindow_resize_root_window and Qresize_root_window_vertically to
4813 Qwindow_resize_root_window_vertically.
4815 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4817 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4819 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4821 * makefile.w32-in: Redesign dependencies so they reflect more
4822 clearly which files are directly included by each source file,
4823 and not through other includes.
4825 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4827 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4828 (sort_overlays, overlay_strings): When an overlay's clone number
4829 matches the window's clone number process the overlay even if
4830 the overlay's window property doesn't match the current window.
4832 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4833 (Fwindow_hchild): Rename to Fwindow_left_child.
4834 (Fwindow_next): Rename to Fwindow_next_sibling.
4835 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4836 (resize_window_check): Rename to window_resize_check.
4837 (resize_window_apply): Rename to window_resize_apply.
4838 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4839 (Fdelete_other_windows_internal, resize_frame_windows)
4840 (Fsplit_window_internal, Fdelete_window_internal)
4841 (grow_mini_window, shrink_mini_window)
4842 (Fresize_mini_window_internal): Fix callers accordingly.
4844 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4846 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4847 (emacs_fixed_set_min_size): Remove.
4848 (emacs_fixed_new): Take frame as argument.
4850 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4851 (_EmacsFixedPrivate): Remove minwidth/height.
4852 Add struct frame *f.
4853 (emacs_fixed_init): Initialize priv->f.
4854 (get_parent_class, emacs_fixed_set_min_size): Remove.
4855 (emacs_fixed_new): Set priv->f to argument.
4856 (emacs_fixed_get_preferred_width)
4857 (emacs_fixed_get_preferred_height): Use min_width/height from
4858 frames size_hint to set minimum and natural (Bug#8919).
4859 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4860 and use min_width/height from frames size_hint to set
4861 min_width/height (Bug#8919).
4863 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4864 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4867 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4869 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4870 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4873 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4875 * process.c (wait_reading_process_output): Bypass select if
4876 waiting for a cell while ignoring keyboard input, and input is
4877 pending. Suggested by Jan Djärv (Bug#8869).
4879 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4881 Use gnulib's dup2 module instead of rolling our own.
4882 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4884 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4886 * dispnew.c (scrolling_window): Before scrolling, turn off a
4887 mouse-highlight in the window being scrolled.
4889 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4891 Move DEFSYM to lisp.h and use everywhere.
4893 * character.h (DEFSYM): Move declaration...
4894 * lisp.h (DEFSYM): ...here.
4900 * w32select.c: Don't include character.h.
4902 * alloc.c (syms_of_alloc):
4903 * buffer.c (syms_of_buffer):
4904 * bytecode.c (syms_of_bytecode):
4905 * callint.c (syms_of_callint):
4906 * casefiddle.c (syms_of_casefiddle):
4907 * casetab.c (init_casetab_once):
4908 * category.c (init_category_once, syms_of_category):
4909 * ccl.c (syms_of_ccl):
4910 * cmds.c (syms_of_cmds):
4911 * composite.c (syms_of_composite):
4912 * dbusbind.c (syms_of_dbusbind):
4913 * dired.c (syms_of_dired):
4914 * dispnew.c (syms_of_display):
4915 * doc.c (syms_of_doc):
4916 * editfns.c (syms_of_editfns):
4917 * emacs.c (syms_of_emacs):
4918 * eval.c (syms_of_eval):
4919 * fileio.c (syms_of_fileio):
4920 * fns.c (syms_of_fns):
4921 * frame.c (syms_of_frame):
4922 * fringe.c (syms_of_fringe):
4923 * insdel.c (syms_of_insdel):
4924 * keymap.c (syms_of_keymap):
4925 * lread.c (init_obarray, syms_of_lread):
4926 * macros.c (syms_of_macros):
4927 * msdos.c (syms_of_msdos):
4928 * print.c (syms_of_print):
4929 * process.c (syms_of_process):
4930 * search.c (syms_of_search):
4931 * sound.c (syms_of_sound):
4932 * syntax.c (init_syntax_once, syms_of_syntax):
4933 * terminal.c (syms_of_terminal):
4934 * textprop.c (syms_of_textprop):
4935 * undo.c (syms_of_undo):
4936 * w32.c (globals_of_w32):
4937 * window.c (syms_of_window):
4938 * xdisp.c (syms_of_xdisp):
4939 * xfaces.c (syms_of_xfaces):
4940 * xfns.c (syms_of_xfns):
4941 * xmenu.c (syms_of_xmenu):
4942 * xsettings.c (syms_of_xsettings):
4943 * xterm.c (syms_of_xterm): Use DEFSYM.
4945 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4947 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4949 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4951 Integer and buffer overflow fixes (Bug#8873).
4953 * print.c (printchar, strout): Check for string overflow.
4954 (PRINTPREPARE, printchar, strout):
4955 Don't set size unless allocation succeeds.
4957 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4958 for sizes. Check for string overflow more accurately.
4959 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4961 * macros.c: Integer and buffer overflow fixes.
4962 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4963 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4964 Use ptrdiff_t, not int, for sizes.
4965 Don't increment bufsize until after realloc succeeds.
4966 Check for size-calculation overflow.
4967 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4969 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4971 * lread.c: Integer overflow fixes.
4972 (read_integer): Radix is now EMACS_INT, not int,
4973 to improve quality of diagnostics for out-of-range radices.
4974 Calculate buffer size correctly for out-of-range radices.
4975 (read1): Check for integer overflow in radices, and in
4976 read-circle numbers.
4977 (read_escape): Avoid int overflow.
4978 (Fload, openp, read_buffer_size, read1)
4979 (substitute_object_recurse, read_vector, read_list, map_obarray):
4980 Use ptrdiff_t, not int, for sizes.
4981 (read1): Use EMACS_INT, not int, for sizes.
4982 Check for size overflow.
4984 * image.c (cache_image): Check for size arithmetic overflow.
4986 * lread.c: Integer overflow issues.
4987 (saved_doc_string_size, saved_doc_string_length)
4988 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4989 Now ptrdiff_t, not int.
4990 (read1): Don't assume doc string length fits in int. Check for
4991 out-of-range doc string lengths.
4992 (read_list): Don't assume file position fits in int.
4993 (read_escape): Check for hex character overflow.
4995 2011-06-22 Leo Liu <sdl.web@gmail.com>
4997 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4998 Move to minibuffer.el.
5000 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5002 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5003 The following patches are for when GLYPH_DEBUG && !XASSERT.
5004 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5005 * dispnew.c (flush_stdout):
5006 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5007 Mark as externally visible.
5008 * dispnew.c (check_window_matrix_pointers): Now static.
5009 * dispnew.c (window_to_frame_vpos):
5010 * xfns.c (unwind_create_frame):
5011 * xterm.c (x_check_font): Remove unused local.
5012 * scroll.c (CHECK_BOUNDS):
5013 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5014 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5015 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5016 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5017 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5019 (debug_method_add): Use va_list and vsprintf rather than relying
5020 on undefined behavior with wrong number of arguments.
5021 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5022 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5023 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5024 since we're not interested in debugging glyphs with old libraries.
5025 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5026 GCC 4.6.0's static checking.
5028 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5030 Integer overflow and signedness fixes (Bug#8873).
5031 A few related buffer overrun fixes, too.
5033 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5035 * dispextern.h (struct face.stipple):
5036 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5037 (x_bitmap_mask, x_allocate_bitmap_record)
5038 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5039 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5040 (x_create_bitmap_from_xpm_data):
5041 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5042 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5044 * xfaces.c (load_pixmap):
5045 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5046 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5047 (.bitmaps_last, struct x_output.icon_bitmap):
5048 Use ptrdiff_t, not int, for bitmap indexes.
5049 (x_allocate_bitmap_record): Check for size overflow.
5050 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5052 Use ptrdiff_t, not int, for overlay counts.
5053 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5054 * editfns.c (overlays_around, get_pos_property):
5055 * textprop.c (get_char_property_and_overlay):
5056 * xdisp.c (next_overlay_change, note_mouse_highlight):
5057 * xfaces.c (face_at_buffer_position):
5058 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5059 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5060 (Fnext_overlay_change, Fprevious_overlay_change)
5061 (mouse_face_overlay_overlaps, Foverlays_in):
5062 Use ptrdiff_t, not int, for sizes.
5063 (overlays_at, overlays_in): Check for size-calculation overflow.
5065 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5067 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5068 (x_session_initialize): Do not assume string length fits in int.
5070 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5071 This is unlikely, but can occur if DPI is outlandish.
5073 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5074 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5076 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5077 * xrdb.c (magic_file_p, search_magic_path):
5078 Omit last arg SUFFIX; it was always 0. All callers changed.
5079 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5081 * xfont.c (xfont_match): Avoid need for strlen.
5083 * xfns.c: Don't assume strlen fits in int.
5084 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5086 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5087 not unsigned long, as we prefer signed integers. All callers changed.
5088 Detect integer overflow in repeat count.
5089 (message_dolog): Don't assume print length fits in 39 bytes.
5090 (display_mode_element): Don't assume strlen fits in int.
5092 * termcap.c: Don't assume sizes fit in int and never overflow.
5093 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5094 (gobble_line): Check for size-calculation overflow.
5096 * minibuf.c (Fread_buffer):
5097 * lread.c (intern, intern_c_string):
5098 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5099 Don't assume string length fits in int.
5101 * keyboard.c (parse_tool_bar_item):
5102 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5104 * font.c: Don't assume string length fits in int.
5105 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5106 Use ptrdiff_t, not int.
5107 (font_intern_prop): Don't assume string length fits in int.
5108 Don't assume integer property fits in fixnum.
5109 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5111 * filelock.c: Fix some buffer overrun and integer overflow issues.
5112 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5113 Reformulate so as not to need the command string.
5114 Invoke gzip -cd rather than gunzip, as it's more portable.
5115 (lock_info_type, lock_file_1, lock_file):
5116 Don't assume pid_t and time_t fit in unsigned long.
5117 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5118 (current_lock_owner): Prefer signed type for sizes.
5119 Use memcpy, not strncpy, where memcpy is what is really wanted.
5120 Don't assume (via atoi) that time_t and pid_t fit in int.
5121 Check for time_t and/or pid_t out of range, e.g., via a network share.
5122 Don't alloca where an auto var works fine.
5124 * fileio.c: Fix some integer overflow issues.
5125 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5126 Don't assume string length fits in int.
5127 (directory_file_name): Don't assume string length fits in long.
5128 (make_temp_name): Don't assume pid fits in int, or that its print
5129 length is less than 20.
5131 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5133 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5135 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5137 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5138 We prefer signed integers, even for size calculations.
5140 * emacs.c: Don't assume string length fits in 'int'.
5141 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5142 (main): Don't invoke strlen when not needed.
5144 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5145 (XD_DEBUG_MESSAGE): Don't waste a byte.
5147 * callproc.c (getenv_internal_1, getenv_internal)
5149 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5151 * lread.c (invalid_syntax): Omit length argument.
5152 All uses changed. This doesn't fix a bug, but it simplifies the
5153 code away from its former Hollerith-constant appearance, and it's
5154 one less 'int' to worry about when looking at integer-overflow issues.
5155 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5157 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5158 This didn't break anything, but it didn't help either.
5159 It's confusing to put a bogus integer in a place where the actual
5160 value does not matter.
5161 (LIST_END_P): Remove unused macro and its bogus comment.
5162 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5164 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5165 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5167 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5168 We prefer signed types, and the value cannot exceed the EMACS_INT
5169 range anyway (because otherwise the length would not be representable).
5170 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5171 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5172 This avoids a GCC warning when WIDE_EMACS_INT.
5174 * indent.c (sane_tab_width): New function.
5175 (current_column, scan_for_column, Findent_to, position_indentation)
5176 (compute_motion): Use it. This is just for clarity.
5177 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5179 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5181 * lisp.h (lint_assume): New macro.
5182 * composite.c (composition_gstring_put_cache):
5183 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5185 * editfns.c, insdel.c:
5186 Omit unnecessary forward decls, to simplify future changes.
5188 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5190 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5192 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5193 Use much-faster test for byte-length change.
5194 Don't assume string byte-length fits in 'int'.
5195 Check that character arg fits in 'int'.
5196 (mapcar1): Declare byte as byte, for clarity.
5198 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5200 * fns.c (concat): Catch string overflow earlier.
5201 Do not rely on integer wraparound.
5203 * dispextern.h (struct it.overlay_strings_charpos)
5204 (struct it.selective): Now EMACS_INT, not int.
5205 * xdisp.c (forward_to_next_line_start)
5206 (back_to_previous_visible_line_start)
5207 (reseat_at_next_visible_line_start, next_element_from_buffer):
5208 Don't arbitrarily truncate the value of 'selective' to int.
5210 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5212 * composite.c: Don't truncate sizes to 'int'.
5213 (composition_gstring_p, composition_reseat_it)
5214 (composition_adjust_point): Use EMACS_INT, not int.
5215 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5216 not EMACS_UINT, for indexes.
5218 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5220 * buffer.c: Include <verify.h>.
5221 (struct sortvec.priority, struct sortstr.priority):
5222 Now EMACS_INT, not int.
5223 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5224 (struct sortstr.size, record_overlay_string)
5225 (struct sortstrlist.size, struct sortlist.used):
5226 Don't truncate size to int.
5227 (record_overlay_string): Check for size-calculation overflow.
5228 (init_buffer_once): Check at compile-time, not run-time.
5230 2011-06-22 Jim Meyering <meyering@redhat.com>
5232 Don't leak an XBM-image-sized buffer
5233 * image.c (xbm_load): Free the image buffer after using it.
5235 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5238 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5239 that Sun C diagnosed.
5240 * fns.c (secure_hash): Fix pointer signedness issue.
5241 * intervals.c (static_offset_intervals): New function.
5242 (offset_intervals): Use it.
5244 2011-06-21 Leo Liu <sdl.web@gmail.com>
5247 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5250 * fns.c (secure_hash): Rename from crypto_hash_function and change
5251 the first arg to accept symbols.
5252 (Fsecure_hash): New primitive.
5253 (syms_of_fns): New symbols.
5255 2011-06-20 Deniz Dogan <deniz@dogan.se>
5257 * process.c (Fset_process_buffer): Clarify return value in
5260 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5262 * dispnew.c (add_window_display_history): Use BVAR.
5264 * xdisp.c (debug_method_add): Use BVAR.
5265 (check_window_end, dump_glyph_matrix, dump_glyph)
5266 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5268 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5271 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5272 check till after the cache is created in init_frame_faces.
5274 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5276 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5278 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5280 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5281 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5282 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5284 Improve buffer-overflow checking (Bug#8873).
5285 * fileio.c (Finsert_file_contents):
5286 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5287 Remove the old (too-loose) buffer overflow checks.
5288 They weren't needed, since make_gap checks for buffer overflow.
5289 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5290 The old code merely checked for Emacs fixnum overflow, and relied
5291 on undefined (wraparound) behavior. The new code avoids undefined
5292 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5294 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5295 Tune. Don't use wider integers than needed. Don't use alloca.
5296 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5298 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5300 * insdel.c, lisp.h (buffer_overflow): New function.
5301 (insert_from_buffer_1, replace_range, replace_range_2):
5302 * insdel.c (make_gap_larger):
5303 * editfns.c (Finsert_char):
5304 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5306 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5308 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5310 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5312 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5313 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5315 * fileio.c: Don't assume EMACS_INT fits in off_t.
5316 (emacs_lseek): New static function.
5317 (Finsert_file_contents, Fwrite_region): Use it.
5318 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5320 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5322 * fns.c: Don't overflow int when computing a list length.
5323 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5324 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5325 truncation on 64-bit hosts. Check for QUIT every
5326 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5327 faster and is responsive enough.
5328 (Flength): Report an error instead of overflowing an integer.
5329 (Fsafe_length): Return a float if the value is not representable
5330 as a fixnum. This shouldn't happen except in contrived situations.
5331 (Fnthcdr, Fsort): Don't assume list length fits in int.
5332 (Fcopy_sequence): Don't assume vector length fits in int.
5334 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5335 (header_size, word_size): New constants.
5336 (allocate_vectorlike): Don't check size overflow here.
5337 (allocate_vector): Check it here instead, since this is the only
5338 caller of allocate_vectorlike that could cause overflow.
5339 Check that the new vector's length is representable as a fixnum.
5341 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5342 The previous code was bogus. For example, next_almost_prime (32)
5343 returned 39, which is undesirable as it is a multiple of 3; and
5344 next_almost_prime (24) returned 25, which is a multiple of 5 so
5345 why was the code bothering to check for multiples of 7?
5347 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5349 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5351 Variadic C functions now count arguments with ptrdiff_t.
5352 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5353 Back then I didn't know that the Emacs coding style prefers signed int.
5354 Also, in the meantime I found a few more instances where arguments
5355 were being counted with int, which may truncate counts on 64-bit
5356 machines, or EMACS_INT, which may be unnecessarily wide.
5357 * lisp.h (struct Lisp_Subr.function.aMANY)
5358 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5359 Arg counts are now ptrdiff_t, not size_t.
5360 All variadic functions and their callers changed accordingly.
5361 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5362 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5363 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5364 * callint.c (Fcall_interactively): Check arg count for overflow,
5365 to avoid potential buffer overrun. Use signed char, not 'int',
5366 for 'varies' array, so that we needn't bother to check its size
5367 calculation for overflow.
5368 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5369 * eval.c (apply_lambda):
5370 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5371 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5372 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5374 * callint.c (Fcall_interactively): Don't use index var as event count.
5376 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5377 * mem-limits.h (SIZE): Remove; no longer used.
5379 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5381 Remove unnecessary casts.
5382 * xterm.c (x_term_init):
5383 * xfns.c (x_set_border_pixel):
5384 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5385 These aren't needed now that we assume ANSI C.
5387 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5388 It's more likely to cause problems (due to unsigned overflow)
5391 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5393 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5395 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5397 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5399 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5401 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5403 GLYPH_CODE_FACE returns EMACS_INT, not int.
5404 * dispextern.h (merge_faces):
5405 * xfaces.c (merge_faces):
5406 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5407 Don't assume EMACS_INT fits in int.
5409 * character.h (CHAR_VALID_P): Remove unused parameter.
5410 * fontset.c, lisp.h, xdisp.c: All uses changed.
5412 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5414 * fns.c (concat): Minor tuning based on overflow analysis.
5415 This doesn't fix any bugs. Use int to hold character, instead
5416 of constantly refetching from Emacs object. Use XFASTINT, not
5417 XINT, for value known to be a character. Don't bother comparing
5418 a single byte to 0400, as it's always less.
5420 * floatfns.c (Fexpt):
5421 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5423 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5426 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5428 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5429 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5430 incorrectly succeed when S was a string, because 4294967386 was
5431 truncated before it was used.
5433 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5434 Otherwise, an out-of-range integer could cause undefined behavior
5437 * composite.c: Use int, not EMACS_INT, for characters.
5438 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5439 EMACS_INT, for values that are known to be in character range.
5440 This doesn't fix any bugs but is the usual style inside Emacs and
5441 may generate better code on 32-bit machines.
5443 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5444 This is for reasons similar to the recent CHAR_STRING fix.
5445 * charset.c (Fencode_char): Check that character arg is actually
5446 a character. Pass an int to ENCODE_CHAR.
5447 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5448 wider than 'int', as a compile-time check to prevent future regressions
5451 * character.c (char_string): Remove unnecessary casts.
5453 Make sure a 64-bit char is never passed to CHAR_STRING.
5454 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5455 by silently ignoring the top 32 bits, allowing some values
5456 that were far too large to be valid characters.
5457 * character.h: Include <verify.h>.
5458 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5459 arguments are no wider than unsigned, as a compile-time check
5460 to prevent future regressions in this area.
5462 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5463 (Fsubst_char_in_region):
5465 * xdisp.c (decode_mode_spec_coding):
5466 Adjust to CHAR_STRING's new requirement.
5467 * editfns.c (Finsert_char, Fsubst_char_in_region):
5468 * fns.c (concat): Check that character args are actually
5469 characters. Without this test, these functions did the wrong
5470 thing with wildly out-of-range values on 64-bit hosts.
5472 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5473 These casts should not be needed on 32-bit hosts, either.
5474 * keyboard.c (read_char):
5475 * lread.c (Fload): Remove casts to unsigned.
5477 * lisp.h (UNSIGNED_CMP): New macro.
5478 This fixes comparison bugs on 64-bit hosts.
5479 (ASCII_CHAR_P): Use it.
5480 * casefiddle.c (casify_object):
5481 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5482 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5483 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5484 * dispextern.h (FACE_FROM_ID):
5485 * keyboard.c (read_char): Use UNSIGNED_CMP.
5487 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5488 not to EMACS_INT, to avoid GCC warning.
5490 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5492 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5493 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5494 isn't needed on 32-bit machines.
5496 * buffer.c (Fgenerate_new_buffer_name):
5497 Use EMACS_INT for count, not int.
5498 (advance_to_char_boundary): Return EMACS_INT, not int.
5500 * data.c (Qcompiled_function): Now static.
5502 * window.c (window_body_lines): Now static.
5504 * image.c (gif_load): Rename local to avoid shadowing.
5506 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5507 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5508 * alloc.c (make_save_value): Integer argument is now of type
5510 (mark_object): Use ptrdiff_t, not int.
5511 * lisp.h (pD): New macro.
5512 * print.c (print_object): Use it.
5514 * alloc.c: Use EMACS_INT, not int, to count objects.
5515 (total_conses, total_markers, total_symbols, total_vector_size)
5516 (total_free_conses, total_free_markers, total_free_symbols)
5517 (total_free_floats, total_floats, total_free_intervals)
5518 (total_intervals, total_strings, total_free_strings):
5519 Now EMACS_INT, not int. All uses changed.
5520 (Fgarbage_collect): Compute overall total using a double, so that
5521 integer overflow is less likely to be a problem. Check for overflow
5522 when converting back to an integer.
5523 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5524 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5525 These were 'int' variables that could overflow on 64-bit hosts;
5526 they were never used, so remove them instead of repairing them.
5527 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5528 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5529 Previously, this ceilinged at INT_MAX, but that doesn't work on
5531 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5533 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5534 (allocate_vectorlike): Check for ptrdiff_t overflow.
5535 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5536 when a (possibly-narrower) signed value would do just as well.
5537 We prefer using signed arithmetic, to avoid comparison confusion.
5539 * alloc.c: Catch some string size overflows that we were missing.
5540 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5541 for convenience in STRING_BYTES_MAX.
5542 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5543 The definition here is exact; the one in lisp.h was approximate.
5544 (allocate_string_data): Check for string overflow. This catches
5545 some instances we weren't catching before. Also, it catches
5546 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5547 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5548 and ptrdiff_t and EMACS_INT are both 64 bits.
5550 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5551 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5552 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5554 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5556 * alloc.c (Fmake_string): Check for out-of-range init.
5558 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5560 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5562 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5564 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5565 xg_get_default_scrollbar_width.
5567 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5568 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5569 (style_changed_cb): Call update_theme_scrollbar_width and call
5570 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5571 all frames (Bug#8505).
5572 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5573 Call gtk_window_set_resizable if HAVE_GTK3.
5574 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5575 and height if HAVE_GTK3 (Bug#8505).
5576 (scroll_bar_width_for_theme): New variable.
5577 (update_theme_scrollbar_width): New function.
5578 (xg_get_default_scrollbar_width): Move code to
5579 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5580 (xg_initialize): Call update_theme_scrollbar_width.
5582 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5584 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5586 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5588 * frame.c (make_frame): Call other_buffer_safely instead of
5591 * window.c (temp_output_buffer_show): Call display_buffer with
5592 second argument Vtemp_buffer_show_specifiers and reset latter
5593 immediately after the call.
5594 (Vtemp_buffer_show_specifiers): New variable.
5595 (auto_window_vscroll_p, next_screen_context_lines)
5596 (Vscroll_preserve_screen_position): Remove leading asterisks from
5599 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5601 Fix minor problems found by GCC 4.6.0 static checking.
5602 * buffer.c (Qclone_number): Remove for now, as it's unused.
5603 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5604 (record_buffer): Remove unused local.
5605 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5606 (set_frame_buffer_list): Remove; unused.
5607 * frame.h (other_visible_frames): Remove decl.
5608 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5609 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5610 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5612 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5613 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5614 Define only if HAVE_GPM.
5615 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5616 (update_hints_inhibit): Remove; never set. All uses removed.
5617 * widgetprv.h (emacsFrameClassRec): Remove decl.
5618 * window.c (delete_deletable_window): Now returns void, since it
5619 wasn't returning anything.
5620 (compare_window_configurations): Remove unused locals.
5621 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5622 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5623 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5624 the same widths as pointers. This follows up on the 2011-05-06 patch.
5625 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5626 * xterm.h: Likewise.
5627 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5629 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5631 * makefile.w32-in: Update dependencies.
5632 (LISP_H): Add lib/intprops.h.
5634 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5636 * image.c (gif_load): Add animation frame delay to the metadata.
5637 (syms_of_image): Use DEFSYM. New symbol `delay'.
5639 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5641 * window.c (delete_deletable_window): Re-add.
5642 (Fset_window_configuration): Rewrite to handle dead buffers and
5643 consequently deletable windows.
5644 (window_tree, Fwindow_tree): Remove. Supply functionality in
5646 (compare_window_configurations): Simplify code.
5648 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5650 * image.c (imagemagick_load_image): Fix type mismatch.
5651 (Fimagemagick_types): Likewise.
5653 * window.h (replace_buffer_in_windows): Declare.
5655 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5657 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5658 Qclone_number. Remove external declaration of Qdelete_window.
5659 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5661 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5662 Run Qbuffer_list_update_hook if allowed.
5663 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5664 buffer list implementation.
5665 (other_buffer_safely): New function.
5666 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5667 calls to replace_buffer_in_windows and
5668 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5670 (record_buffer): Inhibit quitting and rewrite using quittable
5671 functions. Run Qbuffer_list_update_hook if allowed.
5672 (Frecord_buffer, Funrecord_buffer): New functions.
5673 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5674 Move switch-to-buffer to window.el.
5675 (bury-buffer): Move to window.el.
5676 (Vbuffer_list_update_hook): New variable.
5678 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5681 * window.h (resize_frame_windows): Move up in code.
5682 (Fwindow_frame): Remove EXFUN.
5683 (replace_buffer_in_all_windows): Remove prototype.
5684 (replace_buffer_in_windows_safely): Add prototype.
5686 * window.c: Declare Qdelete_window static again. Move down
5687 declaration of select_count.
5688 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5689 (Fother_window): Move to window.el.
5690 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5691 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5692 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5694 (replace_buffer_in_windows): Implement by calling
5695 Qreplace_buffer_in_windows.
5696 (replace_buffer_in_all_windows): Remove with some functionality
5697 moved into replace_buffer_in_windows_safely.
5698 (replace_buffer_in_windows_safely): New function.
5699 (select_window_norecord, select_frame_norecord): Move in front
5700 of run_window_configuration_change_hook. Remove now obsolete
5702 (Fset_window_buffer): Rewrite doc-string.
5703 Call Qrecord_window_buffer.
5704 (keys_of_window): Move binding for other-window to window.el.
5706 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5708 * dispextern.h (struct image): Replace data member, whose int_val
5709 and ptr_val fields were not used by anything, with a single
5712 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5713 (gif_clear_image, gif_load, imagemagick_load_image)
5714 (gs_clear_image, gs_load): Callers changed.
5716 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5718 * buffer.h: Include <time.h>, for time_t.
5719 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5721 Fix minor problems found by static checking.
5723 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5725 Make identifiers static if they are not used in other modules.
5726 * data.c (Qcompiled_function, Qframe, Qvector):
5727 * image.c (QimageMagick, Qsvg):
5728 * minibuf.c (Qmetadata):
5729 * window.c (resize_window_check, resize_root_window): Now static.
5730 * window.h (resize_window_check, resize_root_window): Remove decls.
5732 * window.c (window_deletion_count, delete_deletable_window):
5734 (window_body_lines): Now static.
5735 (Fdelete_other_windows_internal): Mark vars as initialized.
5736 Make sure 'resize_failed' is initialized.
5737 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5738 (resize_window_apply): Remove unused local.
5739 * window.h (delete_deletable_window): Remove decl.
5741 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5742 (imagemagick_load_image): Fix pointer signedness problem by changing
5743 last arg from unsigned char * to char *. All uses changed.
5744 Also, fix a local for similar reasons.
5745 Remove unused locals. Remove locals to avoid shadowing.
5746 (fn_rsvg_handle_free): Remove; unused.
5747 (svg_load, svg_load_image): Fix pointer signedness problem.
5748 (imagemagick_load_image): Don't use garbage pointer image_wand.
5750 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5752 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5754 * image.c (gif_load): Fix omitted cast error introduced by
5757 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5759 * window.h (resize_proportionally, orig_total_lines)
5760 (orig_top_line): Remove from window structure.
5761 (set_window_height, set_window_width, change_window_heights)
5762 (Fdelete_window): Remove prototypes.
5763 (resize_frame_windows): Remove duplicate declaration.
5765 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5767 * window.h (resize_frame_windows, resize_window_check)
5768 (delete_deletable_window, resize_root_window)
5769 (resize_frame_windows): Declare prototypes.
5771 * window.c (resize_window_apply): Make definition be "static" to
5772 match the prototype.
5774 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5776 * window.c: Remove declarations of Qwindow_size_fixed,
5777 window_min_size_1, window_min_size_2, window_min_size,
5778 size_window, window_fixed_size_p, enlarge_window, delete_window.
5779 Remove static from declaration of Qdelete_window, it's
5780 temporarily needed by Fbury_buffer.
5781 (replace_window): Don't assign orig_top_line and
5783 (Fdelete_window, delete_window): Remove. Window deletion is
5784 handled by window.el.
5785 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5786 Replace Fdelete_window calls with calls to Qdelete_window.
5787 (Fdelete_other_windows): Remove. Deleting other windows is
5788 handled by window.el.
5789 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5790 handled in window.el.
5791 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5792 Window minimum sizes are handled in window.el.
5793 (shrink_windows, size_window, set_window_height)
5794 (set_window_width, change_window_heights, window_height)
5795 (window_width, CURBEG, CURSIZE, enlarge_window)
5796 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5797 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5798 handled in window.el.
5799 (make_dummy_parent): Rename to make_parent_window and give it a
5800 second argument horflag.
5801 (make_window): Don't set resize_proportionally any more.
5802 (Fsplit_window): Remove. Windows are split in window.el.
5803 (save_restore_action, save_restore_orig_size)
5804 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5805 Resize mini windows in window.el.
5806 (grow_mini_window, shrink_mini_window): Implement by calling
5807 Qresize_root_window_vertically, resize_window_check and
5808 resize_window_apply.
5809 (saved_window, Fset_window_configuration, save_window_save):
5810 Do not handle orig_top_line, orig_total_lines, and
5811 resize_proportionally.
5812 (window_min_height, window_min_width): Move to window.el.
5813 (keys_of_window): Move bindings for delete-other-windows,
5814 split-window, delete-window and enlarge-window to window.el.
5816 * buffer.c: Temporarily extern Qdelete_window.
5817 (Fbury_buffer): Temporarily call Qdelete_window instead of
5818 Fdelete_window (Fbury_buffer will move to window.el soon).
5820 * frame.c (set_menu_bar_lines_1): Remove code handling
5821 orig_top_line and orig_total_lines.
5823 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5824 set_window_height but set heights directly.
5825 (change_frame_size_1): Use resize_frame_windows.
5827 * xdisp.c (init_xdisp): Don't use set_window_height but set
5830 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5831 Use resize_frame_windows instead of change_window_heights and run
5832 run_window_configuration_change_hook.
5834 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5835 instead of change_window_heights and run
5836 run_window_configuration_change_hook.
5838 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5840 * window.c (replace_window): Rename second argument REPLACEMENT to
5841 NEW. New third argument SETFLAG. Rewrite.
5842 (delete_window, make_dummy_parent): Call replace_window with
5844 (window_list_1): Move down in code.
5845 (run_window_configuration_change_hook): Move set_buffer part
5846 before select_frame_norecord part in order to unwind correctly.
5847 Rename count1 to count.
5848 (recombine_windows, delete_deletable_window, resize_root_window)
5849 (Fdelete_other_windows_internal)
5850 (Frun_window_configuration_change_hook, make_parent_window)
5851 (resize_window_check, resize_window_apply, Fresize_window_apply)
5852 (resize_frame_windows, Fsplit_window_internal)
5853 (Fdelete_window_internal, Fresize_mini_window_internal):
5855 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5857 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5859 * window.h (window): Add some new members to window structure -
5860 normal_lines, normal_cols, new_total, new_normal, clone_number,
5861 splits, nest, prev_buffers, next_buffers.
5862 (WINDOW_TOTAL_SIZE): Move here from window.c.
5863 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5865 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5867 (make_dummy_parent): Set new members of windows structure.
5868 (make_window): Move down in code. Handle new members of window
5870 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5871 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5872 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5873 (Fset_window_prev_buffers, Fwindow_next_buffers)
5874 (Fset_window_next_buffers, Fset_window_clone_number):
5876 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5877 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5879 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5880 Argument WINDOW can be now internal window too.
5881 (Fwindow_use_time): Move up in code.
5882 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5884 (Fset_window_configuration, saved_window)
5885 (Fcurrent_window_configuration, save_window_save): Handle new
5886 members of window structure.
5887 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5888 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5889 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5890 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5891 Qget_mru_window, Qresize_root_window,
5892 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5893 Qauto_buffer_name; staticpro them.
5895 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5897 * window.c (Fwindow_total_size, Fwindow_left_column)
5898 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5899 (Fwindow_list_1): New functions.
5900 (window_box_text_cols): Replace with window_body_cols.
5901 (Fwindow_width, Fscroll_left, Fscroll_right):
5902 Use window_body_cols instead of window_box_text_cols.
5903 (delete_window, Fset_window_configuration):
5904 Call delete_all_subwindows with window as argument.
5905 (delete_all_subwindows): Take a window as argument and not a
5907 (window_loop): Remove handling of GET_LRU_WINDOW and
5909 (Fget_lru_window, Fget_largest_window): Move to window.el.
5911 * window.h: Extern window_body_cols instead of
5912 window_box_text_cols. delete_all_subwindows now takes a
5913 Lisp_Object as argument.
5915 * indent.c (compute_motion, Fcompute_motion):
5916 Use window_body_cols instead of window_box_text_cols.
5918 * frame.c (delete_frame): Call delete_all_subwindows with root
5921 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5923 * fns.c (Fputhash): Document return value.
5925 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5927 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5929 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5931 Cons<->int and similar integer overflow fixes (Bug#8794).
5933 Check for overflow when converting integer to cons and back.
5934 * charset.c (Fdefine_charset_internal, Fdecode_char):
5935 Use cons_to_unsigned to catch overflow.
5936 (Fencode_char): Use INTEGER_TO_CONS.
5937 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5938 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5939 * data.c (long_to_cons, cons_to_long): Remove.
5940 (cons_to_unsigned, cons_to_signed): New functions.
5941 These signal an error for invalid or out-of-range values.
5942 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5943 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5944 * font.c (Ffont_variation_glyphs):
5945 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5946 * lisp.h: Include <intprops.h>.
5947 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5948 (cons_to_signed, cons_to_unsigned): New decls.
5949 (long_to_cons, cons_to_long): Remove decls.
5950 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5951 (Fprimitive_undo): Use CONS_TO_INTEGER.
5952 * xfns.c (Fx_window_property): Likewise.
5953 * xselect.c: Include <limits.h>.
5954 (x_own_selection, selection_data_to_lisp_data):
5955 Use INTEGER_TO_CONS.
5956 (x_handle_selection_request, x_handle_selection_clear)
5957 (x_get_foreign_selection, Fx_disown_selection_internal)
5958 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5959 (lisp_data_to_selection_data): Use cons_to_unsigned.
5960 (x_fill_property_data): Use cons_to_signed.
5961 Report values out of range.
5963 Check for buffer and string overflow more precisely.
5964 * buffer.h (BUF_BYTES_MAX): New macro.
5965 * lisp.h (STRING_BYTES_MAX): New macro.
5966 * alloc.c (Fmake_string):
5967 * character.c (string_escape_byte8):
5968 * coding.c (coding_alloc_by_realloc):
5969 * doprnt.c (doprnt):
5970 * editfns.c (Fformat):
5972 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5973 since they may not be the same number.
5974 * editfns.c (Finsert_char):
5975 * fileio.c (Finsert_file_contents):
5976 Likewise for BUF_BYTES_MAX.
5978 * image.c: Use ptrdiff_t, not int, for sizes.
5979 (slurp_file): Switch from int to ptrdiff_t.
5981 (slurp_file): Check that file size fits in both size_t (for
5982 malloc) and ptrdiff_t (for sanity and safety).
5984 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5985 if b->modtime has its maximal value.
5987 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5989 Don't assume time_t can fit into int.
5990 * buffer.h (struct buffer.modtime): Now time_t, not int.
5991 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5992 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5994 Minor fixes for signed vs unsigned integers.
5995 * character.h (MAYBE_UNIFY_CHAR):
5996 * charset.c (maybe_unify_char):
5997 * keyboard.c (read_char, reorder_modifiers):
5998 XINT -> XFASTINT, since the integer must be nonnegative.
5999 * ftfont.c (ftfont_spec_pattern):
6000 * keymap.c (access_keymap, silly_event_symbol_error):
6001 XUINT -> XFASTINT, since the integer must be nonnegative.
6002 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6003 since it makes no difference and we prefer signed.
6004 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6005 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6008 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6010 * window.h (Fwindow_frame): Declare.
6012 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6014 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6015 (SPARE_MEMORY): Always define.
6016 (LARGE_REQUEST): Remove.
6017 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6019 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6021 * lisp.h: Move EXFUNS for Fframe_root_window,
6022 Fframe_first_window and Fset_frame_selected_window to window.h.
6024 * window.h: Move EXFUNS for Fframe_root_window,
6025 Fframe_first_window and Fset_frame_selected_window here from
6028 * frame.c (Fwindow_frame, Fframe_first_window)
6029 (Fframe_root_window, Fframe_selected_window)
6030 (Fset_frame_selected_window): Move to window.c.
6031 (Factive_minibuffer_window): Move to minibuf.c.
6032 (Fother_visible_frames_p): New function.
6034 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6036 * window.c (decode_window, decode_any_window): Move up in code.
6037 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6038 (inhibit_frame_unsplittable): Remove unused variable.
6039 (Fwindow_buffer): Move up and rewrite doc-string.
6040 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6041 (Fwindow_prev): New functions.
6042 (Fwindow_frame): Move here from frame.c. Accept any window as
6044 (Fframe_root_window, Fframe_first_window)
6045 (Fframe_selected_window): Move here from frame.c. Accept frame
6046 or arbitrary window as argument. Update doc-strings.
6047 (Fminibuffer_window): Move up in code.
6048 (Fwindow_minibuffer_p): Move up in code and simplify.
6049 (Fset_frame_selected_window): Move here from frame.c.
6051 (Fselected_window, select_window, Fselect_window): Move up in
6052 code. Minor doc-string fixes.
6054 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6056 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6057 Do not assume that spare memory exists; that assumption is valid
6058 only if SYSTEM_MALLOC.
6059 (LARGE_REQUEST): New macro, so that the issue of large requests
6060 is separated from the issue of spare memory.
6062 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6064 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6067 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6069 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6072 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6074 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6076 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6078 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6079 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6081 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6083 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6085 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6087 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6088 (x_clipboard_manager_save): Add return value.
6089 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6091 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6092 Obey Vx_select_enable_clipboard_manager. Catch errors in
6093 x_clipboard_manager_save (Bug#8779).
6094 (Vx_select_enable_clipboard_manager): New variable.
6095 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6097 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6099 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6101 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6103 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6104 in the current matrix if keep_current_p is non-zero.
6106 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6108 * bidi.c (bidi_level_of_next_char): Fix last change.
6110 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6112 Support bidi reordering of text covered by display properties.
6114 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6115 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6116 (bidi_cache_search, bidi_cache_iterator_state)
6117 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6118 (bidi_level_of_next_char, bidi_move_to_visually_next):
6119 Support character positions inside a run of characters covered by a
6121 (bidi_paragraph_init, bidi_resolve_explicit_1)
6122 (bidi_level_of_next_char): Call bidi_fetch_char and
6123 bidi_fetch_char_advance instead of FETCH_CHAR and
6125 (bidi_init_it): Initialize new members.
6126 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6128 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6129 instead of using explicit *_CHAR codes.
6130 (bidi_resolve_explicit, bidi_resolve_weak):
6131 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6132 bidirectional text is supported only in multibyte buffers.
6133 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6134 it to initialize the frame_window_p member of struct bidi_it.
6135 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6136 (bidi_resolve_explicit, bidi_resolve_weak)
6137 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6138 bidi_it->nchars is non-positive.
6139 (bidi_level_of_next_char): Don't try to lookup the cache for the
6140 next/previous character if nothing is cached there yet, or if we
6141 were just reseat()'ed to a new position.
6143 * xdisp.c (set_cursor_from_row): Set start and stop points
6144 according to the row's direction when priming the loop that looks
6145 for the glyph on which to display cursor.
6146 (single_display_spec_intangible_p): Function deleted.
6147 (display_prop_intangible_p): Reimplement to call
6148 handle_display_spec instead of single_display_spec_intangible_p.
6149 Accept 3 additional arguments needed by handle_display_spec.
6150 This fixes incorrect cursor motion across display property with complex
6151 values: lists, `(when COND...)' forms, etc.
6152 (single_display_spec_string_p): Support property values that are
6153 lists with the argument STRING its top-level element.
6154 (display_prop_string_p): Fix the condition for processing a
6155 property that is a list to be consistent with handle_display_spec.
6156 (handle_display_spec): New function, refactored from the
6157 last portion of handle_display_prop.
6158 (compute_display_string_pos): Accept additional argument
6159 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6160 value of a `display' property is a "replacing spec".
6161 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6162 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6163 the display property, but just return a value indicating whether
6164 the display property will replace the characters it covers.
6165 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6166 frame_window_p members of struct bidi_it.
6167 (compute_display_string_pos, compute_display_string_end):
6169 (push_it): Accept second argument POSITION, where pop_it should
6170 jump to continue iteration.
6171 (reseat_1): Initialize bidi_it.disp_pos.
6173 * keyboard.c (adjust_point_for_property): Adjust the call to
6174 display_prop_intangible_p to its new signature.
6176 * dispextern.h (struct bidi_it): New member frame_window_p.
6177 (bidi_init_it): Update prototypes.
6178 (display_prop_intangible_p): Update prototype.
6179 (compute_display_string_pos, compute_display_string_end):
6181 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6184 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6186 Malloc failure behavior now depends on size of allocation.
6187 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6188 * lisp.h: Change signatures accordingly.
6189 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6190 All callers changed. (Bug#8762)
6192 * gnutls.c: Use Emacs's memory allocators.
6193 Without this change, the gnutls library would invoke malloc etc.
6194 directly, which causes problems on non-SYNC_INPUT hosts, and which
6195 runs afoul of improving memory_full behavior. (Bug#8761)
6196 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6197 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6198 xfree instead of the default malloc, realloc, free.
6199 (Fgnutls_boot): No need to check for memory allocation failure,
6200 since xmalloc does that for us.
6202 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6203 * category.c (hash_get_category_set):
6204 * ccl.c (ccl_driver):
6205 * charset.c (Fdefine_charset_internal):
6206 * charset.h (struct charset.hash_index):
6207 * composite.c (get_composition_id, gstring_lookup_cache)
6208 (composition_gstring_put_cache):
6209 * composite.h (struct composition.hash_index):
6210 * dispextern.h (struct image.hash):
6211 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6212 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6213 (hashfn_equal, hashfn_user_defined, make_hash_table)
6214 (maybe_resize_hash_table, hash_lookup, hash_put)
6215 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6216 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6217 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6218 * image.c (make_image, search_image_cache, lookup_image)
6219 (xpm_put_color_table_h):
6220 * lisp.h (struct Lisp_Hash_Table):
6221 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6222 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6223 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6224 * alloc.c (allocate_vectorlike):
6225 Check for overflow in vector size calculations.
6226 * ccl.c (ccl_driver):
6227 Check for overflow when converting EMACS_INT to int.
6228 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6229 need to be updated by these changes.
6230 * fns.c (make_hash_table, maybe_resize_hash_table):
6231 Check for integer overflow with large hash tables.
6232 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6233 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6234 (SXHASH_REDUCE): New macro.
6235 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6236 Use it instead of discarding useful hash info with large hash values.
6237 (sxhash_float): New function.
6238 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6239 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6240 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6241 Rewrite to use FIXNUM_BITS, as this simplifies things.
6242 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6243 Adjust signatures to match updated version of code.
6244 (consing_since_gc): Now EMACS_INT, since a single hash table can
6245 use more than INT_MAX bytes.
6247 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6249 Make it possible to build with GCC-4.6+ -O2 -flto.
6251 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6253 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6255 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6256 Call minibuffer-inactive-mode.
6258 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6260 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6261 Update dependencies.
6263 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6265 * data.c (init_data): Remove code for UTS, this system is not
6268 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6270 Don't force ./temacs to start in terminal mode.
6272 * frame.c (make_initial_frame): Initialize faces in all cases, not
6273 only when CANNOT_DUMP is defined.
6274 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6276 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6278 * dispnew.c (add_window_display_history): Use const for the string
6279 pointer. Remove declaration, not needed.
6281 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6283 Use 'inline', not 'INLINE'.
6284 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6285 * alloc.c, fontset.c (INLINE): Remove.
6286 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6287 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6288 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6289 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6290 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6292 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6294 Make it possible to run ./temacs.
6296 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6297 syms_of_callproc does the same thing. Remove test for
6298 "initialized", do it in the caller.
6299 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6301 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6303 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6304 (read_minibuf): Use get_minibuffer.
6305 (syms_of_minibuf): Use DEFSYM.
6306 (Qmetadata): New var.
6307 * data.c (Qbuffer): Don't make it static.
6308 (syms_of_data): Use DEFSYM.
6310 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6312 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6313 (CCL_CODE_MIN): New macro.
6315 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6317 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6319 * eval.c (Qdebug): Now static.
6320 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6321 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6322 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6324 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6326 * image.c: Various fixes to ImageMagick code comments.
6327 (Fimagemagick_types): Doc fix.
6329 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6331 Minor fixes prompted by GCC 4.6.0 warnings.
6333 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6335 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6336 (x_clipboard_manager_save_all): Move extern decl to ...
6337 * xterm.h: ... here, so that it can be checked for consistency.
6339 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6341 * xselect.c (x_clipboard_manager_save_frame)
6342 (x_clipboard_manager_save_all): New functions.
6343 (Fx_clipboard_manager_save): Lisp function deleted.
6345 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6346 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6348 * xterm.h: Update prototype.
6350 2011-05-28 William Xu <william.xwl@gmail.com>
6352 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6355 2011-05-28 Jim Meyering <meyering@redhat.com>
6357 Avoid a sign-extension bug in crypto_hash_function.
6358 * fns.c (to_uchar): Define.
6359 (crypto_hash_function): Use it to convert some newly-signed
6360 variables to unsigned, to avoid sign-extension bugs. For example,
6361 without this change, (md5 "truc") would evaluate to
6362 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6363 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6364 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6366 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6368 Integer overflow fixes.
6370 * dbusbind.c: Serial number integer overflow fixes.
6371 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6372 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6373 to hold a serial number that is too large for a fixnum.
6374 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6375 Check for serial numbers out of range. Decode any serial number
6376 that was so large that it became a float. (Bug#8722)
6378 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6379 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6380 Use XFASTINT rather than XUINT when numbers are nonnegative.
6381 (xd_append_arg, Fdbus_method_return_internal):
6382 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6383 arguments, check that Lisp number is nonnegative, rather than
6384 silently wrapping negative numbers around. (Bug#8722)
6385 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6388 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6390 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6392 ccl: add integer overflow checks
6393 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6394 (IN_INT_RANGE): New macros.
6395 (ccl_driver): Use them to check for integer overflow when
6396 decoding a CCL program. Many of the new checks are whether XINT (x)
6397 fits in int; it doesn't always, on 64-bit hosts. The new version
6398 doesn't catch all possible integer overflows, but it's an
6399 improvement. (Bug#8719)
6401 * alloc.c (make_event_array): Use XINT, not XUINT.
6402 There's no need for unsigned here.
6404 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6405 This follows up to the 2011-05-06 change that substituted uintptr_t
6406 for EMACS_INT. This case wasn't caught back then.
6408 Rework Fformat to avoid integer overflow issues.
6409 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6410 now (part of C89). Include <verify.h>.
6411 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6412 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6413 (Fformat): Avoid the prepass trying to compute sizes; it was only
6414 approximate and thus did not catch overflow reliably. Instead, walk
6415 through the format just once, formatting and computing sizes as we go,
6416 checking for integer overflow at every step, and allocating a larger
6417 buffer as needed. Keep track separately whether the format is
6418 multibyte. Keep only the most-recently calculated precision, rather
6419 than them all. Record whether each argument has been converted to
6420 string. Use EMACS_INT, not int, for byte and char and arg counts.
6421 Support field widths and precisions larger than INT_MAX. Avoid
6422 sprintf's undefined behavior with conversion specifications such as %#d
6423 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6424 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6425 formatting out-of-range floating point numbers with int
6428 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6430 * data.c: Avoid integer truncation in expressions involving floats.
6431 * data.c: Include <intprops.h>.
6432 (arith_driver): When there's an integer overflow in an expression
6433 involving floating point, convert the integers to floating point
6434 so that the resulting value does not suffer from catastrophic
6435 integer truncation. For example, on a 64-bit host (* 4
6436 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6437 Do not rely on undefined behavior after integer overflow.
6439 merge count_size_as_multibyte, parse_str_to_multibyte
6440 * character.c, character.h (count_size_as_multibyte):
6441 Rename from parse_str_to_multibyte; all uses changed.
6442 Check for integer overflow.
6443 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6444 since it's now a duplicate of the other. This is more of
6445 a character than a buffer op, so better that it's in character.c.
6446 * fns.c, print.c: Adjust to above changes.
6448 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6450 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6452 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6454 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6455 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6456 (x_clipboard_manager_save): Now static.
6457 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6459 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6460 (crypto_hash_function): Now static.
6461 Fix pointer signedness problems. Avoid unnecessary initializations.
6463 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6465 * termhooks.h (Vselection_alist): Make it terminal-local.
6467 * terminal.c (create_terminal): Initialize it.
6469 * xselect.c: Support for clipboard managers.
6470 (Vselection_alist): Move to termhooks.h as terminal-local var.
6471 (LOCAL_SELECTION): New macro.
6472 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6473 (symbol_to_x_atom): Remove gratuitous arg.
6474 (x_handle_selection_request, lisp_data_to_selection_data)
6475 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6476 (x_own_selection, x_get_local_selection, x_convert_selection):
6477 New arg, specifying work frame. Use terminal-local Vselection_alist.
6478 (some_frame_on_display): Delete unused function.
6479 (Fx_own_selection_internal, Fx_get_selection_internal)
6480 (Fx_disown_selection_internal, Fx_selection_owner_p)
6481 (Fx_selection_exists_p): New optional frame arg.
6482 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6483 (x_handle_selection_clear): Don't treat other terminals with the
6484 same keyboard specially. Use the terminal-local Vselection_alist.
6485 (x_clear_frame_selections): Use Frun_hook_with_args.
6487 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6489 * xterm.h: Add support for those atoms.
6491 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6493 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6494 (converted_selections, conversion_fail_tag): New global variables.
6495 (x_selection_request_lisp_error): Free the above.
6496 (x_get_local_selection): Remove unnecessary code.
6497 (x_reply_selection_request): Args changed; handle arbitrary array
6498 of converted selections stored in converted_selections.
6499 Separate the XChangeProperty and SelectionNotify steps.
6500 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6501 (x_convert_selection): New function.
6502 (x_handle_selection_event): Simplify.
6503 (x_get_foreign_selection): Don't ignore incoming requests while
6504 waiting for an answer; this will fail when we implement
6505 SAVE_TARGETS, and seems unnecessary anyway.
6506 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6507 (Vx_sent_selection_functions): Doc fix.
6509 2011-05-26 Leo Liu <sdl.web@gmail.com>
6511 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6513 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6515 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6517 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6518 for fringe update if it has periodic bitmap.
6519 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6520 and fringe_bitmap_periodic_p.
6522 * fringe.c (get_fringe_bitmap_data): New function.
6523 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6524 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6525 row. Mark glyph row for fringe update if periodicity changed.
6527 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6528 for fringe update unless it has periodic bitmap.
6530 2011-05-25 Kenichi Handa <handa@m17n.org>
6532 * xdisp.c (get_next_display_element): Set correct it->face_id for
6533 a static composition.
6535 2011-05-24 Leo Liu <sdl.web@gmail.com>
6538 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6540 * fns.c (crypto_hash_function, Fsha1): New function.
6541 (Fmd5): Use crypto_hash_function.
6542 (syms_of_fns): Add Ssha1.
6544 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6546 * gnutls.c: Remove unused macros.
6547 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6548 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6549 Remove macros that are defined and never used.
6550 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6552 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6554 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6555 (Fx_get_selection_internal): Minor cleanup.
6556 (Fx_own_selection_internal): Rename arguments for consistency with
6559 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6561 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6563 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6565 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6567 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6569 * dispnew.c (scrolling_window): Don't exclude the case that the
6570 last enabled row in the desired matrix touches the bottom boundary.
6572 2011-05-21 Glenn Morris <rgm@gnu.org>
6574 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6575 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6576 and add some more files.
6578 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6580 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6581 report_file_error introduced by the change from 2011-05-07.
6583 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6585 * systime.h (Time): Define only if emacs is defined.
6586 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6587 where the include path doesn't have X11/X.h by default. See
6588 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6590 2011-05-20 Kenichi Handa <handa@m17n.org>
6592 * composite.c (find_automatic_composition): Fix previous change.
6594 2011-05-20 Glenn Morris <rgm@gnu.org>
6596 * lisp.mk: New file, split from Makefile.in.
6597 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6598 (shortlisp): Remove.
6599 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6601 2011-05-19 Glenn Morris <rgm@gnu.org>
6603 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6604 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6605 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6606 (lisp): Set the order to that of loadup.el.
6607 (shortlisp): Make it a copy of $lisp.
6608 (SOME_MACHINE_LISP): Remove.
6609 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6610 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6612 2011-05-18 Kenichi Handa <handa@m17n.org>
6614 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6615 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6616 (find_automatic_composition): Mostly rewrite for efficiency.
6618 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6620 * makefile.w32-in: Update dependencies.
6622 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6624 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6625 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6627 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6629 Fix some integer overflow issues, such as string length overflow.
6631 * insdel.c (count_size_as_multibyte): Check for string overflow.
6633 * character.c (lisp_string_width): Check for string overflow.
6634 Use EMACS_INT, not int, for string indexes and lengths; in
6635 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6636 the resulting string length overflows an EMACS_INT; instead,
6637 report a string overflow if no precision given. When checking for
6638 precision exhaustion, use a check that cannot possibly have
6639 integer overflow. (Bug#8675)
6640 * character.h (lisp_string_width): Adjust to new signature.
6642 * alloc.c (string_overflow): New function.
6643 (Fmake_string): Use it. This doesn't change behavior, but saves
6644 a few bytes and will simplify future changes.
6645 * character.c (string_escape_byte8): Likewise.
6646 * lisp.h (string_overflow): New decl.
6648 Fixups, following up to the user-interface timestamp change.
6649 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6650 for UI timestamps, instead of unsigned long.
6651 * msdos.c (mouse_get_pos): Likewise.
6652 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6653 * w32gui.h (Time): Define by including "systime.h" rather than by
6654 declaring it ourselves. (Bug#8664)
6656 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6657 * image.c (clear_image_cache): Likewise.
6659 * term.c (term_mouse_position): Don't assume time_t wraparound.
6661 Be more systematic about user-interface timestamps.
6662 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6663 and sometimes 'EMACS_UINT', to represent these timestamps.
6664 This change causes it to use 'Time' uniformly, as that's what X uses.
6665 This makes the code easier to follow, and makes it easier to catch
6666 integer overflow bugs such as Bug#8664.
6667 * frame.c (Fmouse_position, Fmouse_pixel_position):
6668 Use Time, not unsigned long, for user-interface timestamps.
6669 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6670 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6671 * keyboard.h (last_event_timestamp): Likewise.
6672 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6673 * menu.h (xmenu_show): Likewise.
6674 * term.c (term_mouse_position): Likewise.
6675 * termhooks.h (struct input_event.timestamp): Likewise.
6676 (struct terminal.mouse_position_hook): Likewise.
6677 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6678 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6679 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6680 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6682 * menu.h, termhooks.h: Include "systime.h", for Time.
6684 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6685 Don't assume that the difference between two unsigned long values
6686 can fit into an integer. At this point, we know button_down_time
6687 <= event->timestamp, so the difference must be nonnegative, so
6688 there's no need to cast the result if double-click-time is
6689 nonnegative, as it should be; check that it's nonnegative, just in
6690 case. This bug is triggered when events are more than 2**31 ms
6691 apart (about 25 days). (Bug#8664)
6693 * xselect.c (last_event_timestamp): Remove duplicate decl.
6694 (x_own_selection): Remove needless cast to unsigned long.
6696 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6697 that always fit in int. Use a sentinel instead of a counter, to
6698 avoid a temp and to allay GCC's concerns about possible int overflow.
6699 * frame.h (struct frame): Use int for menu_bar_items_used
6700 instead of EMACS_INT, since it always fits in int.
6702 * menu.c (grow_menu_items): Check for int overflow.
6704 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6706 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6707 Before, the code was not consistent. These values cannot exceed
6708 2**31 - 1 so there's no need to make them unsigned.
6709 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6710 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6711 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6713 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6715 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6716 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6717 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6718 presumably because the widths might not match.
6720 * window.c (size_window): Avoid needless test at loop start.
6722 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6724 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6726 2011-05-12 Drew Adams <drew.adams@oracle.com>
6728 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6730 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6732 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6733 `width' to `bar_area_x' and `bar_area_width', respectively.
6734 (x_scroll_run): Take account of fringe background extension.
6736 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6737 Rename local vars `left' and `width' to `bar_area_x' and
6738 `bar_area_width', respectively.
6739 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6740 background extension.
6742 2011-05-10 Jim Meyering <meyering@redhat.com>
6744 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6746 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6748 * image.c (Finit_image_library): Return t for built-in image types,
6749 like pbm and xbm. (Bug#8640)
6751 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6753 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6755 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6757 * w32console.c (Fset_screen_color): Doc fix.
6758 (Fget_screen_color): New function.
6759 (syms_of_ntterm): Defsubr it.
6761 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6762 unlink the temporary file if Fcall_process didn't create it in the
6764 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6765 child process will be redirected to a file specified with `:file'.
6766 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6767 cue to call_process_cleanup not to close that handle.
6769 2011-05-07 Ben Key <bkey76@gmail.com>
6771 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6772 one of two shell specific rules, either bootstrap-temacs-CMD or
6773 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6774 to the previous implementation of the bootstrap-temacs rule.
6775 The bootstrap-temacs-CMD rule is similar to the previous
6776 implementation of the bootstrap-temacs rule except that it
6777 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6780 These changes, along with some changes to nt/configure.bat,
6781 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6782 earlier fix to add support for --cflags and --ldflags options
6783 that include quotes so that it works whether make uses cmd or
6786 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6788 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6789 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6791 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6792 a string. Handle both cases.
6793 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6794 (Fdbus_register_method): Use Qinvalid_function.
6796 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6798 * makefile.w32-in: Update dependencies.
6799 (LISP_H): Add inttypes.h and stdin.h.
6800 (PROCESS_H): Add unistd.h.
6802 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6804 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6805 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6807 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6809 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6811 * term.c (vfatal): Remove stray call to va_end.
6812 It's not needed and the C Standard doesn't allow it here anyway.
6814 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6815 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6817 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6820 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6822 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6824 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6826 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6828 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6830 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6831 * charset.c (Fdefine_charset_internal): Don't initialize
6832 charset.code_space[15]. The value was garbage, on hosts with
6833 32-bit int (Bug#8600).
6835 * lread.c (read_integer): Be more consistent with string-to-number.
6836 Use string_to_number to do the actual conversion; this avoids
6837 rounding errors and fixes some other screwups. Without this fix,
6838 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6839 (digit_to_number): Move earlier, for benefit of read_integer.
6840 Return -1 if the digit is out of range for the base, -2 if it is
6841 not a digit in any supported base. (Bug#8602)
6843 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6845 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6846 to match comment at start of function. This also removes a
6847 GCC warning about overflow in a 32+64-bit port.
6849 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6851 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6852 Reported by Stefan Monnier in
6853 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6854 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6855 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6857 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6858 (EMACS_UINTPTR): Likewise, with uintptr_t.
6860 * lisp.h: Prefer 64-bit EMACS_INT if available.
6861 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6862 on 32-bit hosts that have 64-bit int, so that they can access
6864 However, temporarily disable this change unless the temporary
6865 symbol WIDE_EMACS_INT is defined.
6867 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6869 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6870 This removes an assumption that EMACS_INT and long are the same
6871 width as pointers. The assumption is true for Emacs porting targets
6872 now, but we want to make other targets possible.
6873 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6874 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6875 In the rest of the code, change types of integers that hold casted
6876 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6877 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6878 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6879 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6880 No need to cast type when ORing.
6881 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6882 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6883 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6884 assume EMACS_INT is the same width as char *.
6885 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6886 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6887 Remove no-longer-needed casts.
6888 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6889 (xg_tool_bar_help_callback, xg_make_tool_item):
6890 Use EMACS_INTPTR to hold an integer
6891 that will be cast to void *; this can avoid a GCC warning
6892 if EMACS_INT is not the same width as void *.
6893 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6894 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6895 (current_message_1, set_message_1):
6896 Use a local to convert to proper width without a cast.
6897 * xmenu.c (dialog_selection_callback): Likewise.
6899 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6900 Also, don't assume VALBITS / RAND_BITS is less than 5,
6901 and don't rely on undefined behavior when shifting a 1 left into
6903 * lisp.h (get_random): Change signature to match.
6905 * lread.c (hash_string): Use size_t, not int, for hash computation.
6906 Normally we prefer signed values; but hashing is special, because
6907 it's better to use unsigned division on hash table sizes so that
6908 the remainder is nonnegative. Also, size_t is the natural width
6909 for hashing into memory. The previous code used 'int', which doesn't
6910 retain enough info to hash well into very large tables.
6911 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6913 * dbusbind.c: Don't possibly lose pointer info when converting.
6914 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6915 Use XPNTR rather than XHASH, so that the high-order bits of
6916 the pointer aren't lost when converting through void *.
6918 * eval.c (Fautoload): Don't double-shift a pointer.
6920 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6922 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6924 * gnutls.c (DEF_GNUTLS_FN):
6925 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6927 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6929 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6932 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6934 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6935 New version that can reserve upto 2GB of heap space.
6937 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6939 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6941 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6943 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6944 `gnutls_certificate_set_x509_key_file'.
6946 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6948 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6949 Update dependencies.
6951 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6953 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6954 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6955 Remove unused parameter `fildes'.
6956 * process.c (read_process_output, send_process): Don't pass it.
6958 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6960 Fix previous change: the library cache is defined in w32.c.
6961 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6962 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6964 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6966 Implement dynamic loading of GnuTLS on Windows.
6968 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6969 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6970 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6973 * gnutls.c (Qgnutls_dll): Define.
6974 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6975 (gnutls_*): Declare function pointers.
6976 (init_gnutls_functions): New function to initialize function pointers.
6977 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6978 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6979 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6980 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6981 (emacs_gnutls_write, emacs_gnutls_read)
6982 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6983 (Fgnutls_available_p): New function.
6984 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6985 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6986 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6988 * image.c: Include w32.h.
6989 (Vimage_type_cache): Delete.
6990 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6991 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6992 (w32_delayed_load): Move to w32.c.
6994 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6996 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6997 (w32_delayed_load): Move from image.c. When loading a library, record
6998 its filename in the :loaded-from property of the library id.
6999 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7000 Initialize and staticpro them.
7001 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7003 * process.c: Include lisp.h before w32.h, not after.
7004 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7005 instead of gnutls_record_check_pending.
7007 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7009 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7011 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7012 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7015 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7017 * xterm.c (x_set_frame_alpha): Do not set property on anything
7018 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7020 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7022 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7024 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7026 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7027 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7028 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7029 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7030 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7031 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7032 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7033 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7034 (Qgnutls_bootprop_callbacks_verify): Make static.
7036 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7038 * callproc.c: Indentation fixup.
7040 * sysdep.c (wait_for_termination_1): Make static.
7041 (wait_for_termination, interruptible_wait_for_termination):
7042 Move after wait_for_termination_1.
7044 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7046 * sysdep.c (interruptible_wait_for_termination): New function
7047 which is like wait_for_termination, but allows keyboard
7050 * callproc.c (Fcall_process): Add (:file "file") as an option for
7052 (Fcall_process_region): Ditto.
7054 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7056 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7057 rather than `XVECTOR (FOO)->size'.
7059 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7060 inttypes.h, as a gnulib replacement is used if it not available in
7063 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7065 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7066 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7067 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7069 * coding.c (coding_alloc_by_realloc): Error out if destination
7070 will grow beyond MOST_POSITIVE_FIXNUM.
7071 (decode_coding_emacs_mule): Abort if there isn't enough place in
7072 charbuf for the composition carryover bytes. Reserve an extra
7073 space for up to 2 characters produced in a loop.
7074 (decode_coding_iso_2022): Abort if there isn't enough place in
7075 charbuf for the composition carryover bytes.
7077 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7079 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7080 aborting when %lld or %lll format is passed.
7081 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7082 %llo or %llx format is passed. (Bug#8545)
7084 * window.c (window_scroll_line_based): Use a marker instead of
7085 simple variables to record original value of point. (Bug#7952)
7087 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7088 produced by %s or %c overflows available buffer space. (Bug#8545)
7090 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7092 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7093 (SIZE_MAX): Move defn after all includes, as they might #define it.
7095 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7097 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7099 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7101 * keyboard.c (Qdelayed_warnings_hook): Define.
7102 (command_loop_1): Run `delayed-warnings-hook'
7103 if Vdelayed_warnings_list is non-nil.
7104 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7105 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7107 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7109 * doprnt.c (doprnt): Don't return value smaller than the buffer
7110 size if the message was truncated. (Bug#8545).
7112 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7114 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7115 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7117 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7119 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7121 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7123 * makefile.w32-in: Update dependencies.
7125 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7127 Improve `doprnt' and its usage. (Bug#8545)
7128 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7129 `format_end'. Remove support for %l as a conversion specifier.
7130 Don't use xrealloc. Improve diagnostics when the %l size modifier
7131 is used. Update the commentary.
7133 * eval.c (verror): Simplify calculation of size_t.
7135 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7138 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7140 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7143 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7145 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7146 This makes this file independent of the recent pseudovector change.
7148 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7150 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7152 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7153 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7154 Remove unused local.
7155 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7157 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7158 GCC 4.6.0 optimizes based on type-based alias analysis.
7159 For example, if b is of type struct buffer * and v of type struct
7160 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7161 != &v->size, and therefore "v->size = 1; b->size = 2; return
7162 v->size;" must therefore return 1. This assumption is incorrect
7163 for Emacs, since it type-puns struct Lisp_Vector * with many other
7164 types. To fix this problem, this patch adds a new type struct
7165 vectorlike_header that documents the constraints on layout of vectors
7166 and pseudovectors, and helps optimizing compilers not get fooled
7167 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7168 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7169 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7171 (XSETPVECTYPE): Rewrite in terms of new macro.
7172 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7173 This is a bit clearer, and further avoids the possibility of
7174 undesirable aliasing.
7175 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7176 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7177 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7178 since Lisp_Subr is a special case (no "next" field).
7179 (ASIZE): Now uses header.size rather than size.
7180 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7181 to avoid the hassle of writing XVECTOR (foo)->header.size.
7182 (struct vectorlike_header): New type.
7183 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7184 object, to help avoid aliasing.
7185 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7186 (SUBRP): Likewise, since Lisp_Subr is a special case.
7187 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7188 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7189 (struct Lisp_Hash_Table): Combine first two members into a single
7190 struct vectorlike_header member. All uses of "size" and "next" members
7191 changed to be "header.size" and "header.next".
7192 * buffer.h (struct buffer): Likewise.
7193 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7194 * frame.h (struct frame): Likewise.
7195 * process.h (struct Lisp_Process): Likewise.
7196 * termhooks.h (struct terminal): Likewise.
7197 * window.c (struct save_window_data, struct saved_window): Likewise.
7198 * window.h (struct window): Likewise.
7199 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7200 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7201 * buffer.c (init_buffer_once): Likewise.
7202 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7204 * process.c (Fformat_network_address): Use local var for size,
7207 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7209 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7210 * data.c (atof): Remove decl; no longer used or needed.
7211 (digit_to_number): Move to lread.c.
7212 (Fstring_to_number): Use new string_to_number function, to be
7213 consistent with how the Lisp reader treats infinities and NaNs.
7214 Do not assume that floating-point numbers represent EMACS_INT
7215 without losing information; this is not true on most 64-bit hosts.
7216 Avoid double-rounding errors, by insisting on integers when
7217 parsing non-base-10 numbers, as the documentation specifies.
7218 * lisp.h (string_to_number): New decl, replacing ...
7219 (isfloat_string): Remove.
7220 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7221 (read1): Do not accept +. and -. as integers; this
7222 appears to have been a coding error. Similarly, do not accept
7223 strings like +-1e0 as floating point numbers. Do not report
7224 overflow for integer overflows unless the base is not 10 which
7225 means we have no simple and reliable way to continue.
7226 Break out the floating-point parsing into a new
7227 function string_to_number, so that Fstring_to_number parses
7228 floating point numbers consistently with the Lisp reader.
7229 (digit_to_number): Move here from data.c. Make it static inline.
7230 (E_CHAR, EXP_INT): Remove, replacing with ...
7231 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7232 (string_to_number): New function, replacing isfloat_string.
7233 This function checks for valid syntax and produces the resulting
7234 Lisp float number too. Rework it so that string-to-number
7235 no longer mishandles examples like "1.0e+". Use strtoumax,
7236 so that overflow for non-base-10 numbers is reported only when
7237 there's no portable and simple way to convert to floating point.
7239 * textprop.c (set_text_properties_1): Rewrite for clarity,
7240 and to avoid GCC warning about integer overflow.
7242 * intervals.h (struct interval): Use EMACS_INT for members
7243 where EMACS_UINT might cause problems. See
7244 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7245 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7246 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7248 (offset_intervals): Tell GCC not to worry about length overflow
7249 when negating a negative length.
7251 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7252 (overrun_check_free): Likewise.
7254 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7255 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7258 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7259 (gnutls_make_error): Rename local to avoid shadowing.
7260 (gnutls_emacs_global_deinit): ifdef out; not used.
7261 (Fgnutls_boot): Use const for pointer to readonly storage.
7262 Comment out unused local. Fix pointer signedness problems.
7264 * lread.c (openp): Don't stuff size_t into an 'int'.
7265 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7266 about possible signed overflow.
7268 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7269 (GDK_KEY_g): Don't define if already defined.
7270 (xg_prepare_tooltip): Avoid pointer signedness problem.
7271 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7273 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7274 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7276 * xfns.c (Fx_window_property): Simplify a bit,
7277 to make a bit faster and to avoid GCC 4.6.0 warning.
7278 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7280 * fns.c (internal_equal): Don't assume size_t fits in int.
7282 * alloc.c (compact_small_strings): Tighten assertion a little.
7284 Replace pEd with more-general pI, and fix some printf arg casts.
7285 * lisp.h (pI): New macro, generalizing old pEd macro to other
7286 conversion specifiers. For example, use "...%"pI"d..." rather
7287 than "...%"pEd"...".
7288 (pEd): Remove. All uses replaced with similar uses of pI.
7289 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
7290 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7291 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7292 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7293 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7294 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7295 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7297 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7298 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7299 * print.c (safe_debug_print, print_object): Likewise.
7300 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7302 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7303 avoiding the 0 flag, which is not portable.
7304 * process.c (Fmake_network_process): Use pI to avoid cast.
7305 * region-cache.c (pp_cache): Likewise.
7306 * xdisp.c (decode_mode_spec): Likewise.
7307 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7308 behavior on 64-bit hosts with printf arg.
7309 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7310 (x_stop_queuing_selection_requests): Likewise.
7311 (x_get_window_property): Don't truncate byte count to an 'int'
7314 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7315 here, since it parses constructs like leading '-' and spaces,
7316 which are not wanted; and it overflows with large numbers.
7317 Instead, simply match F[0-9]+, which is what is wanted anyway.
7319 * alloc.c: Remove unportable assumptions about struct layout.
7320 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7321 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7322 (allocate_vectorlike, make_pure_vector): Use the new macros,
7323 plus offsetof, to remove unportable assumptions about struct layout.
7324 These assumptions hold on all porting targets that I know of, but
7325 they are not guaranteed, they're easy to remove, and removing them
7326 makes further changes easier.
7328 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7329 This doesn't fix a bug but makes the code clearer.
7330 (string_overrun_cookie): Now const. Use initializers that
7331 don't formally overflow signed char, to avoid warnings.
7332 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7333 can cause Emacs to crash when string overrun checking is enabled.
7334 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7335 multiple of sizeof (EMACS_INT); it need not be, if
7336 alignof(EMACS_INT) < sizeof (EMACS_INT).
7337 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7339 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7341 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7343 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7345 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7346 supposed to be handshaking. (Bug#8556)
7347 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7349 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7351 * lisp.h (Qdebug): List symbol.
7352 * eval.c (Qdebug): Restore global linkage.
7353 * keyboard.c (debug-on-event): New variable.
7354 (handle_user_signal): Break into debugger when debug-on-event
7355 matches the current signal symbol.
7357 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7359 * alloc.c (check_sblock, check_string_bytes)
7360 (check_string_free_list): Convert to standard C.
7362 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7364 * w32.c (emacs_gnutls_push): Fix typo.
7366 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7368 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7369 "cast to pointer from integer of different size".
7371 Improve doprnt and its use in verror. (Bug#8545)
7372 * doprnt.c (doprnt): Document the set of format control sequences
7373 supported by the function. Use SAFE_ALLOCA instead of always
7376 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7377 is one byte too soon. Don't use xrealloc; instead xfree and
7380 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7382 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7385 * gnutls.c: Renamed global_initialized to
7386 gnutls_global_initialized. Added internals for the
7387 :verify-hostname-error, :verify-error, and :verify-flags
7388 parameters of `gnutls-boot' and documented those parameters in the
7389 docstring. Start callback support.
7390 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7391 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7392 on error. Return error code.
7393 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7394 (emacs_gnutls_read): Likewise.
7395 (Fgnutls_boot): Return handshake error code.
7396 (emacs_gnutls_handle_error): New function.
7397 (wsaerror_to_errno): Likewise.
7399 * w32.h (emacs_gnutls_pull): Add prototype.
7400 (emacs_gnutls_push): Likewise.
7402 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7403 (emacs_gnutls_push): Likewise.
7405 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7407 * process.c (wait_reading_process_output): Check if GnuTLS
7408 buffered some data internally if no FDs are set for TLS
7411 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7412 (LIBS): Link to USER_LIBS.
7413 ($(BLD)/gnutls.$(0)): New target.
7415 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7417 * xdisp.c (handle_single_display_spec): Rename the
7418 display_replaced_before_p argument into display_replaced_p, to
7419 make it consistent with the commentary. Fix typos in the
7422 * textprop.c (syms_of_textprop): Remove dead code.
7423 (copy_text_properties): Delete obsolete commentary about an
7424 interface that was deleted long ago. Fix typos in the description
7427 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7428 to changes in oldXMenu/XMenu.h from 2011-04-16.
7429 <menu_help_message, prev_menu_help_message>: Constify.
7430 (IT_menu_make_room): menu->help_text is now `const char **';
7433 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7434 to changes in oldXMenu/XMenu.h from 2011-04-16.
7435 (struct XMenu): Declare `help_text' `const char **'.
7437 * xfaces.c <Qunspecified>: Make extern again.
7439 * syntax.c: Include sys/types.h before including regex.h, as
7442 * doc.c (get_doc_string): Improve the format passed to `error'.
7444 * doprnt.c (doprnt): Improve commentary.
7446 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7448 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7451 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7452 changes in globals.h immediately force recompilation.
7453 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7454 $(CURDIR)/s/ms-w32.h.
7455 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7457 * character.c (Fchar_direction): Function deleted.
7458 (syms_of_character): Don't defsubr it.
7459 <char-direction-table>: Deleted.
7461 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7463 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7464 * doprnt.c: Include limits.h.
7465 (SIZE_MAX): New macro.
7466 (doprnt): Return a size_t value. 2nd arg is now size_t.
7467 Many local variables are now size_t instead of int or unsigned.
7468 Improve overflow protection. Support `l' modifier for integer
7469 conversions. Support %l conversion. Don't assume an EMACS_INT
7470 argument for integer conversions and for %c.
7472 * lisp.h (doprnt): Restore prototype.
7474 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7477 * Makefile.in (base_obj): Add back doprnt.o.
7479 * deps.mk (doprnt.o): Add back prerequisites.
7480 (callint.o): Depend on character.h.
7482 * eval.c (internal_lisp_condition_case): Include the handler
7483 representation in the error message.
7484 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7485 when breaking from the loop.
7487 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7489 * callint.c (Fcall_interactively): When displaying error message
7490 about invalid control letter, pass the character's codepoint, not
7491 a pointer to its multibyte form. Improve display of the character
7492 in octal and display also its hex code.
7494 * character.c (char_string): Use %x to display the (unsigned)
7495 codepoint of an invalid character, to avoid displaying a bogus
7498 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7499 `error', not SYMBOL_NAME itself.
7501 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7502 character arguments to `error'.
7504 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7505 to `error' in error message about FINAL_CHAR argument. Make sure
7506 FINAL_CHAR is a character, and use %c when it is passed as
7507 argument to `error'.
7509 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7511 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7513 * w32.c: Include <time.h>.
7514 (sys_localtime): New function.
7516 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7518 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7520 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7522 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7524 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7527 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7529 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7530 gl_state.e_property when gl_state.object is Qt.
7532 * insdel.c (make_gap_larger): Remove limitation of buffer size
7535 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7537 * xdisp.c (lookup_glyphless_char_display)
7538 (produce_glyphless_glyph): Handle cons cell entry in
7539 glyphless-char-display.
7540 (Vglyphless_char_display): Document it.
7542 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7543 glyphless-char-display.
7545 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7547 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7549 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7551 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7552 definition for no-X builds.
7554 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7556 Static checks with GCC 4.6.0 and non-default toolkits.
7558 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7560 * process.c (keyboard_bit_set): Define only if SIGIO.
7561 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7562 (send_process): Repair possible setjmp clobbering.
7564 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7566 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7568 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7570 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7571 Define only if needed.
7573 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7574 by pacifying GCC about it. Maybe it's time to retire it?
7575 * xfaces.c (USG, __TIMEVAL__): Likewise.
7577 * dispextern.h (struct redisplay_interface): Rename param
7579 * termhooks.h (struct terminal): Likewise.
7580 * xterm.c (xembed_send_message): Likewise.
7582 * insdel.c (make_gap_smaller): Define only if
7583 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7585 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7588 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7589 so that we aren't warned about unused symbols.
7591 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7593 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7595 * xfns.c (x_real_positions): Mark locals as initialized.
7597 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7599 * xterm.c: Fix problems found by static analysis with other toolkits.
7600 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7601 (x_dispatch_event): Declare static if USE_GTK, and
7602 define if USE_GTK || USE_X_TOOLKIT.
7603 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7604 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7605 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7606 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7608 * xmenu.c (menu_help_callback): Pointer type fixes.
7609 Use const pointers when pointing at readonly data. Avoid pointer
7611 (FALSE): Remove unused macro.
7612 (update_frame_menubar): Remove unused decl.
7614 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7616 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7617 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7618 (single_menu_item): Rename local to avoid shadowing.
7620 * keyboard.c (make_lispy_event): Remove unused local var.
7622 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7623 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7625 * bitmaps: Change bitmaps from unsigned char back to the X11
7626 compatible char. Avoid the old compiler warnings about
7627 out-of-range initializers by using, for example, '\xab' rather
7630 * xgselect.c (xgselect_initialize): Check vs interface
7631 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7633 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7635 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7636 to read-only memory.
7638 * fns.c (vector): Remove; this old hack is no longer needed.
7640 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7642 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7644 * xrdb.c (x_load_resources): Omit unused local.
7646 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7647 (x_window): Rename locals to avoid shadowing.
7648 (USG): Use the kludged USG macro, to pacify gcc.
7650 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7651 (x_term_init): Remove local to avoid shadowing.
7653 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7655 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7656 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7658 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7660 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7662 Fix regex.c, syntax.c and friends for buffers > 2GB.
7663 * syntax.h (struct gl_state_s): Declare character position members
7666 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7668 * textprop.c (verify_interval_modification, interval_of):
7669 Declare arguments EMACS_INT.
7671 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7674 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7676 * indent.c (Fvertical_motion): Local variable it_start is now
7679 * regex.c (re_match, re_match_2, re_match_2_internal)
7680 (bcmp_translate, regcomp, regexec, print_double_string)
7681 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7682 (re_compile_pattern, re_exec): Declare arguments and local
7683 variables `size_t' and `ssize_t' and return values `regoff_t', as
7685 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7686 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7687 <compile_stack_type>: `size' and `avail' are now `size_t'.
7689 * regex.h <regoff_t>: Use ssize_t, not int.
7690 (re_search, re_search_2, re_match, re_match_2): Arguments that
7691 specify buffer/string position and length are now ssize_t and
7692 size_t. Return type is regoff_t.
7694 2011-04-16 Ben Key <bkey76@gmail.com>
7696 * nsfont.m: Fixed bugs in ns_get_family and
7697 ns_descriptor_to_entity that were caused by using free to
7698 deallocate memory blocks that were allocated by xmalloc (via
7699 xstrdup). This caused Emacs to crash when compiled with
7700 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7701 --enable-checking=xmallocoverrun). xfree is now used to
7702 deallocate these memory blocks.
7704 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7706 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7708 emacs_write: Accept and return EMACS_INT for sizes.
7709 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7711 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7712 Accept and return EMACS_INT.
7713 (emacs_gnutls_write): Return the number of bytes written on
7715 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7716 (emacs_read, emacs_write): Remove check for negative size, as the
7717 Emacs source code has been audited now.
7718 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7719 (emacs_read, emacs_write): Use it.
7720 * process.c (send_process): Adjust to the new signatures of
7721 emacs_write and emacs_gnutls_write. Do not attempt to store
7722 a byte offset into an 'int'; it might overflow.
7723 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7725 * sound.c: Don't assume sizes fit in 'int'.
7726 (struct sound_device.period_size, alsa_period_size):
7727 Return EMACS_INT, not int.
7728 (struct sound_device.write, vox_write, alsa_write):
7729 Accept EMACS_INT, not int.
7730 (wav_play, au_play): Use EMACS_INT to store sizes and to
7731 record read return values.
7733 2011-04-15 Ben Key <bkey76@gmail.com>
7735 * keyboard.c (Qundefined): Don't declare static since it is used
7737 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7738 static since they are used in nsfont.m.
7740 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7742 * process.c (Qprocessp): Don't declare static.
7743 * lisp.h (Qprocessp): Declare again.
7745 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7747 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7749 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7751 Improve C-level modularity by making more things 'static'.
7753 Don't publish debugger-only interfaces to other modules.
7754 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7755 (verify_bytepos, count_markers): Move decls to the only modules
7757 * region-cache.h (pp_cache): Likewise.
7758 * window.h (check_all_windows): Likewise.
7759 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7761 * sysdep.c (croak): Now static, if
7762 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7763 * syssignal.h (croak): Declare only if not static.
7765 * alloc.c (refill_memory_reserve): Now static if
7766 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7767 * lisp.h (refill_memory_reserve): Declare only if not static.
7769 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7770 Define only if USE_LUCID.
7772 * xrdb.c (x_customization_string, x_rm_string): Now static.
7774 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7775 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7777 * xdisp.c (draw_row_with_mouse_face): Now static.
7778 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7780 * window.h (check_all_windows): Mark externally visible.
7782 * window.c (window_deletion_count): Now static.
7784 * undo.c: Make symbols static if they're not exported.
7785 (last_undo_buffer, last_boundary_position, pending_boundary):
7788 * textprop.c (interval_insert_behind_hooks): Now static.
7789 (interval_insert_in_front_hooks): Likewise.
7791 * term.c: Make symbols static if they're not exported.
7792 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7793 (max_frame_lines, tty_set_terminal_modes):
7794 (tty_reset_terminal_modes, tty_turn_off_highlight):
7795 (get_tty_terminal): Now static.
7796 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7797 * termhooks.h (term_mouse_moveto): Do not declare if
7799 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7800 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7802 * sysdep.c: Make symbols static if they're not exported.
7803 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7805 (sigprocmask_set, full_mask): Remove; unused.
7806 (wait_debugging): Mark as visible.
7807 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7808 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7810 * syntax.c (syntax_temp): Define only if !__GNUC__.
7812 * sound.c (current_sound_device, current_sound): Now static.
7814 * search.c (searchbufs, searchbuf_head): Now static.
7816 * scroll.c (scroll_cost): Remove; unused.
7817 * dispextern.h (scroll_cost): Remove decl.
7819 * region-cache.h (pp_cache): Mark as externally visible.
7821 * process.c: Make symbols static if they're not exported.
7822 (process_tick, update_tick, create_process, chan_process):
7823 (Vprocess_alist, proc_buffered_char, datagram_access):
7824 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7825 (deactivate_process): Mark defn as static, as well as decl.
7826 * lisp.h (create_process): Remove decl.
7827 * process.h (chan_process, Vprocess_alist): Remove decls.
7829 * print.c: Make symbols static if they're not exported.
7830 (print_depth, new_backquote_output, being_printed, print_buffer):
7831 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7832 (print_interval, print_number_index, initial_stderr_stream):
7834 * lisp.h (Fprinc): Remove decl.
7835 (debug_output_compilation_hack): Mark as externally visible.
7837 * sysdep.c (croak): Move decl from here to syssignal.h.
7838 * syssignal.h (croak): Put it here, so the API can be checked when
7839 'croak' is called from dissociate_if_controlling_tty.
7841 * minibuf.c: Make symbols static if they're not exported.
7842 (minibuf_save_list, choose_minibuf_frame): Now static.
7843 * lisp.h (choose_minibuf_frame): Remove decl.
7845 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7847 * lread.c: Make symbols static if they're not exported.
7848 (read_objects, initial_obarray, oblookup_last_bucket_number):
7850 (make_symbol): Remove; unused.
7851 * lisp.h (initial_obarray, make_symbol): Remove decls.
7853 * keyboard.c: Make symbols static if they're not exported.
7854 (single_kboard, recent_keys_index, total_keys, recent_keys):
7855 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7856 (this_single_command_key_start, echoing, last_auto_save):
7857 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7858 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7859 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7860 (Vlispy_mouse_stem, double_click_count):
7862 (force_auto_save_soon): Define only if SIGDANGER.
7863 (ignore_mouse_drag_p): Now static if
7864 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7865 (print_help): Remove; unused.
7866 (stop_character, last_timer_event): Mark as externally visible.
7867 * keyboard.h (ignore_mouse_drag_p): Declare only if
7868 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7869 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7870 * lisp.h (echoing): Remove decl.
7871 (force_auto_save_soon): Declare only if SIGDANGER.
7872 * xdisp.c (redisplay_window): Simplify code, to make it more
7873 obvious that ignore_mouse_drag_p is not accessed if !defined
7874 USE_GTK && !defined HAVE_NS.
7876 * intervals.c: Make symbols static if they're not exported.
7877 (merge_properties_sticky, merge_interval_right, delete_interval):
7879 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7881 * insdel.c: Make symbols static if they're not exported.
7882 However, leave prepare_to_modify_buffer alone. It's never
7883 called from outside this function, but that appears to be a bug.
7884 (combine_after_change_list, combine_after_change_buffer):
7885 (adjust_after_replace, signal_before_change): Now static.
7886 (adjust_after_replace_noundo): Remove; unused.
7887 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7888 (signal_before_change): Remove decls.
7890 * indent.c (val_compute_motion, val_vmotion): Now static.
7892 * image.c: Make symbols static if they're not exported.
7893 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7895 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7896 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7898 * fringe.c (standard_bitmaps): Now static.
7899 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7901 * frame.c: Make symbols static if they're not exported.
7902 (x_report_frame_params, make_terminal_frame): Now static.
7903 (get_frame_param): Now static, unless HAVE_NS.
7904 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7905 (x_get_resource_string): Remove; not used.
7906 * frame.h (make_terminal_frame, x_report_frame_params):
7907 (x_get_resource_string); Remove decls.
7908 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7909 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7911 * font.c, fontset.c: Make symbols static if they're not exported.
7912 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7913 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7914 * font.c (font_close_object): Now static.
7915 * font.h (font_close_object): Remove.
7916 * fontset.c (FONTSET_OBJLIST): Remove.
7917 (free_realized_fontset) #if-0 the body, which does nothing.
7918 (face_suitable_for_char_p): #if-0, as it's never called.
7919 * fontset.h (face_suitable_for_char_p): Remove decl.
7920 * xfaces.c (face_at_string_position):
7921 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7922 since 0 is always ASCII.
7924 * fns.c (weak_hash_tables): Now static.
7926 * fileio.c: Make symbols static if they're not exported.
7927 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7928 (Vwrite_region_annotation_buffers): Now static.
7930 * eval.c: Make symbols static if they're not exported.
7931 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7932 * lisp.h (backtrace_list): Remove decl.
7934 * emacs.c: Make symbols static if they're not exported.
7935 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7936 (fatal_error_code, fatal_error_signal_hook, standard_args):
7938 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7939 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7940 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7941 * lisp.h (fatal_error_signal_hook): Remove decl.
7942 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7944 * editfns.c: Move a (normally-unused) function to its only use.
7945 * editfns.c, lisp.h (get_operating_system_release): Remove.
7946 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7947 worth the hassle of breaking this out.
7949 * xterm.c: Make symbols static if they're not exported.
7950 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7951 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7952 (x_destroy_window, x_delete_display):
7954 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7955 (x_mouse_leave): Remove; unused.
7956 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7957 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7958 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7960 (x_mouse_leave): Declare only if WINDOWSNT.
7961 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7962 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7965 * ftxfont.c: Make symbols static if they're not exported.
7966 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7968 * font.h (ftxfont_driver): Likewise.
7970 * xfns.c: Make symbols static if they're not exported.
7971 (x_last_font_name, x_display_info_for_name):
7972 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7973 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7974 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7975 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7976 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7977 (last_show_tip_args): Now static.
7978 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7979 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7980 (x_screen_planes): Remove; unused.
7981 * dispextern.h (x_screen_planes): Remove decl.
7983 * dispnew.c: Make symbols static if they're not exported.
7984 * dispextern.h (redraw_garbaged_frames, scrolling):
7985 (increment_row_positions): Remove.
7986 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7987 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7989 (redraw_garbaged_frames): Remove; unused.
7991 * xfaces.c: Make symbols static if they're not exported.
7992 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7994 * xterm.h (defined_color): Remove decls.
7995 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7996 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7997 (menu_face_changed_default, defined_color, free_realized_face):
7998 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7999 (ascii_face_of_lisp_face): Remove; unused.
8001 * xdisp.c: Make symbols static if they're not exported.
8002 * dispextern.h (scratch_glyph_row, window_box_edges):
8003 (glyph_to_pixel_coords, set_cursor_from_row):
8004 (get_next_display_element, set_iterator_to_next):
8005 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8006 (show_mouse_face): Remove decls
8007 * frame.h (message_buf_print): Likewise.
8008 * lisp.h (pop_message, set_message, check_point_in_composition):
8010 * xterm.h (set_vertical_scroll_bar): Likewise.
8011 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8012 (message_buf_print, scratch_glyph_row, displayed_buffer):
8013 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8014 (get_next_display_element, show_mouse_face, window_box_edges):
8015 (frame_to_window_pixel_xy, check_point_in_composition):
8016 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8017 (glyph_to_pixel_coords): Remove; unused.
8019 * dired.c (file_name_completion): Now static.
8021 * dbusbind.c (xd_in_read_queued_messages): Now static.
8023 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8024 * data.c (circular_list_error): Remove.
8026 * commands.h (last_point_position, last_point_position_buffer):
8027 (last_point_position_window): Remove decls.
8028 * keyboard.c: Make these variables static.
8030 * coding.h (coding, code_convert_region, encode_coding_gap):
8032 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8033 (iso_code_class, detect_coding, code_convert_region): Now static.
8034 (encode_coding_gap): Remove; unused.
8036 * chartab.c (chartab_chars, chartab_bits): Now static.
8038 * charset.h (charset_iso_8859_1): Remove decl.
8039 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8042 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8043 * ccl.c (Vccl_program_table): Now static.
8044 (check_ccl_update): Remove; unused.
8046 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8047 * category.h: ... from here.
8048 * category.c (check_category_table, set_category_set): Now static.
8050 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8051 * lisp.h: Remove these decls.
8053 * buffer.c (buffer_count): Remove unused var.
8055 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8056 so that it's not optimized away.
8057 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8058 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8059 exported only to the debugger.
8061 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8062 * atimer.h (run_all_atimers): Remove; not exported.
8064 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8065 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8066 was inaccessible from Lisp.
8067 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8068 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8070 alloc.c: Import and export fewer symbols, and remove unused items.
8071 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8073 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8074 it's not optimized away by whole-program optimization.
8075 (message_enable_multibyte, free_misc): Remove.
8076 (catchlist, handlerlist, mark_backtrace):
8077 Declare only if BYTE_MARK_STACK.
8078 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8079 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8080 (message_enable_multibyte): Remove decl.
8081 (free_misc, interval_free_list, float_block, float_block_index):
8082 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8083 (cons_free_list, last_marked_index):
8085 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8086 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8087 (mark_backtrace): Define only if BYTE_MARK_STACK.
8088 * xdisp.c (message_enable_multibyte): Now static.
8090 Declare Lisp_Object Q* variables to be 'static' if not exported.
8091 This makes it easier for human readers (and static analyzers)
8092 to see whether these variables are used from other modules.
8093 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8094 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8095 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8096 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8097 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8098 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8099 * xmenu.c, xselect.c:
8100 Declare Q* vars static if they are not used in other modules.
8101 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8102 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8103 Remove decls of unexported vars.
8104 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8106 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8108 Make Emacs functions such as Fatom 'static' by default.
8109 This makes it easier for human readers (and static analyzers)
8110 to see whether these functions can be called from other modules.
8111 DEFUN now defines a static function. To make the function external
8112 so that it can be used in other C modules, use the new macro DEFUE.
8113 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8114 (Finit_image_library):
8115 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8116 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8117 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8118 Remove decls, since these functions are now static.
8119 (Funintern, Fget_internal_run_time): New decls, since these functions
8120 were already external.
8122 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8123 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8124 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8125 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8126 * keyboard.c, keymap.c, lread.c:
8127 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8128 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8129 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8130 Mark functions with DEFUE instead of DEFUN,
8131 if they are used in other modules.
8132 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8133 decls for now-static functions.
8134 * buffer.h (Fdelete_overlay): Remove decl.
8135 * callproc.c (Fgetenv_internal): Mark as internal.
8136 * composite.c (Fremove_list_of_text_properties): Remove decl.
8137 (Fcomposition_get_gstring): New forward static decl.
8138 * composite.h (Fcomposite_get_gstring): Remove decl.
8139 * dired.c (Ffile_attributes): New forward static decl.
8140 * doc.c (Fdocumntation_property): New forward static decl.
8141 * eval.c (Ffetch_bytecode): New forward static decl.
8142 (Funintern): Remove extern decl; now in .h file where it belongs.
8143 * fileio.c (Fmake_symbolic_link): New forward static decl.
8144 * image.c (Finit_image_library): New forward static decl.
8145 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8146 * intervals.h (Fprevious_property_change):
8147 (Fremove_list_of_text_properties): Remove decls.
8148 * keyboard.c (Fthis_command_keys): Remove decl.
8149 (Fcommand_execute): New forward static decl.
8150 * keymap.c (Flookup_key): New forward static decl.
8151 (Fcopy_keymap): Now static.
8152 * keymap.h (Flookup_key): Remove decl.
8153 * process.c (Fget_process): New forward static decl.
8154 (Fprocess_datagram_address): Mark as internal.
8155 * syntax.c (Fsyntax_table_p): New forward static decl.
8156 (skip_chars): Remove duplicate decl.
8157 * textprop.c (Fprevious_property_change): New forward static decl.
8158 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8160 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8161 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8163 * editfns.c (Fformat): Remove unreachable code.
8165 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8167 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8170 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8172 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8173 when at ZV. (Bug#8487)
8175 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8177 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8179 * keyboard.c (parse_tool_bar_item): Likewise.
8180 * sound.c (sound_cleanup, alsa_close): Likewise.
8181 * termcap.c (tgetent): Likewise.
8182 * xfns.c (x_default_font_parameter): Likewise.
8183 * xsettings.c (read_and_apply_settings): Likewise.
8185 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8186 (overrun_check_free): Protoize.
8188 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8190 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8191 since callers should never pass a negative size.
8192 Change the signature to match that of plain 'read' and 'write'; see
8193 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8194 * lisp.h: Update prototypes of emacs_write and emacs_read.
8196 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8198 * xdisp.c (redisplay_window): Don't try to determine the character
8199 position of the scroll margin if the window start point w->startp
8200 is outside the buffer's accessible region. (Bug#8468)
8202 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8204 Fix write-region and its subroutines for buffers > 2GB.
8205 * fileio.c (a_write, e_write): Modify declaration of arguments and
8206 local variables to support buffers larger than 2GB.
8207 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8209 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8210 argument, local variables, and return value.
8212 * lisp.h: Update prototypes of emacs_write and emacs_read.
8214 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8216 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8218 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8220 Fix more problems found by GCC 4.6.0's static checks.
8222 * xdisp.c (vmessage): Use a better test for character truncation.
8224 * charset.c (load_charset_map): <, not <=, for optimization,
8225 and to avoid potential problems with integer overflow.
8226 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8227 * casetab.c (set_identity, shuffle): Likewise.
8228 * editfns.c (Fformat): Likewise.
8229 * syntax.c (skip_chars): Likewise.
8231 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8232 This also lets GCC 4.6.0 generate slightly better loop code.
8234 * callint.c (Fcall_interactively): <, not <=, for optimization.
8235 (Fcall_interactively): Count the number of arguments produced,
8236 not the number of arguments given. This is simpler and lets GCC
8237 4.6.0 generate slightly better code.
8239 * ftfont.c: Distingish more carefully between FcChar8 and char.
8240 The previous code passed unsigned char * to a functions like
8241 strlen and xstrcasecmp that expect char *, which does not
8242 conform to the C standard.
8243 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8244 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8245 char * when the C standard requires it.
8247 * keyboard.c (read_char): Remove unused var.
8249 * eval.c: Port to Windows vsnprintf (Bug#8435).
8251 (SIZE_MAX): Define if the headers do not.
8252 (verror): Do not give up if vsnprintf returns a negative count.
8253 Instead, grow the buffer. This ports to Windows vsnprintf, which
8254 does not conform to C99. Problem reported by Eli Zaretskii.
8255 Also, simplify the allocation scheme, by avoiding the need for
8256 calling realloc, and removing the ALLOCATED variable.
8258 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8260 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8261 But keep the doprint source code for now, as we might revamp it
8262 and use it again (Bug#8435).
8263 * lisp.h (doprnt): Remove.
8264 * Makefile.in (base_obj): Remove doprnt.o.
8265 * deps.mk (doprnt.o): Remove.
8267 error: Print 32- and 64-bit integers portably (Bug#8435).
8268 Without this change, on typical 64-bit hosts error ("...%d...", N)
8269 was used to print both 32- and 64-bit integers N, which relied on
8271 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
8273 * lisp.h (error, verror): Mark as printf-like functions.
8274 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8275 Report overflow in size calculations when allocating printf buffer.
8276 Do not truncate output string at its first null byte.
8277 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8278 Truncate the output at a character boundary, since vsnprintf does not
8280 * charset.c (check_iso_charset_parameter): Convert internal
8281 character to string before calling 'error', since %c now has the
8283 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8284 overflow when computing char to be passed to 'error'. Do not
8285 pass Lisp_Object to 'error'; pass the integer instead.
8286 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8287 formatted with plain %d.
8289 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8291 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8293 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8295 * xterm.c (x_catch_errors): Remove duplicate declaration.
8297 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8299 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8301 2011-04-10 Jim Meyering <meyering@redhat.com>
8303 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8304 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8305 return ssize_t not "int", and use size_t as the buffer length.
8306 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8307 * gnutls.h: Update declarations.
8308 * process.c (read_process_output): Use ssize_t, to match.
8309 (send_process): Likewise.
8311 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8313 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8315 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8317 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8318 Use unsigned char, to match FcChar8 type definition.
8320 * xterm.c (handle_one_xevent):
8321 * xmenu.c (create_and_show_popup_menu):
8322 * xselect.c (x_decline_selection_request)
8323 (x_reply_selection_request): Avoid type-punned deref of X events.
8325 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8327 Fix some uses of `int' instead of EMACS_INT.
8328 * search.c (string_match_1, fast_string_match)
8329 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8330 (scan_buffer, find_next_newline_no_quit)
8331 (find_before_next_newline, search_command, Freplace_match)
8332 (Fmatch_data): Make some `int' variables be EMACS_INT.
8334 * xdisp.c (display_count_lines): 3rd argument and return value now
8335 EMACS_INT. All callers changed.
8336 (pint2hrstr): Last argument is now EMACS_INT.
8338 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8339 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8340 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8341 (decode_coding_utf_16, decode_coding_emacs_mule)
8342 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8343 (decode_coding_ccl, decode_coding_charset)
8344 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8345 (decode_coding_iso_2022, decode_coding_emacs_mule)
8346 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8347 <char_offset, last_offset>: Declare EMACS_INT.
8348 (encode_coding_utf_8, encode_coding_utf_16)
8349 (encode_coding_emacs_mule, encode_invocation_designation)
8350 (encode_designation_at_bol, encode_coding_iso_2022)
8351 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8352 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8354 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8355 (encode_invocation_designation): Last argument P_NCHARS is now
8357 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8358 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8360 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8363 * ccl.c (Fccl_execute_on_string): Declare some variables
8366 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8368 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8370 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8372 * process.c (Fformat_network_address): Doc fix.
8374 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8376 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8378 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8380 * keyboard.c (read_char): Call Lisp function help-form-show,
8381 instead of using internal_with_output_to_temp_buffer.
8382 (Qhelp_form_show): New var.
8383 (syms_of_keyboard): Use DEFSYM macro.
8385 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8387 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8389 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8391 * process.c (Flist_processes): Remove to Lisp.
8392 (list_processes_1): Delete.
8394 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8396 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8398 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8400 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8402 Fix more problems found by GCC 4.6.0's static checks.
8404 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8406 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8408 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8410 * xdisp.c (vmessage): Mark as a printf-like function.
8412 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8414 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8416 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8417 printf-like functions.
8418 (tiff_load): Add casts to remove these marks before passing them
8419 to system-supplied API.
8421 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8423 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8424 This avoids several warnings with gcc -Wstrict-overflow.
8425 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8426 directly, rather than having caller test rule sign. This avoids
8427 some unnecessary tests.
8428 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8429 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8430 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8432 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8433 (xfont_open): Avoid unnecessary tests.
8435 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8437 * composite.h, composite.c (composition_gstring_put_cache):
8438 Use EMACS_INT, not int, for length.
8440 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8441 breaking out part of COMPOSITION_DECODE_RULE.
8442 (COMPOSITION_DECODE_RULE): Use it.
8443 * composite.c (get_composition_id): Remove unused local vars,
8444 by using the new macro.
8446 * textprop.c (set_text_properties_1): Change while to do-while,
8447 since the condition is always true at first.
8449 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8450 (interval_deletion_adjustment): Return unsigned value.
8453 * process.c (list_processes_1, create_pty, read_process_output):
8454 (exec_sentinel): Remove vars that were set but not used.
8455 (create_pty): Remove unnecessary "volatile"s.
8456 (Fnetwork_interface_info): Avoid possibility of int overflow.
8457 (read_process_output): Do adaptive read buffering even if carryover.
8458 (read_process_output): Simplify nbytes computation if buffered.
8460 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8462 * syntax.c (scan_words): Remove var that was set but not used.
8463 (update_syntax_table): Use unsigned instead of int.
8465 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8466 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8467 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8469 * print.c (print_error_message): Avoid int overflow.
8471 * font.c (font_list_entities): Redo for clarity,
8472 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8474 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8475 (font_score): Avoid potential overflow in diff calculation.
8477 * fns.c (substring_both): Remove var that is set but not used.
8478 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8480 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8482 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8483 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8484 can always succeed if overflow has undefined behavior.
8486 * search.c (boyer_moore, wordify): Remove vars set but not used.
8487 (wordify): Omit three unnecessary tests.
8489 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8490 All callers changed. This avoids the need for an unused var.
8492 * casefiddle.c (casify_region): Remove var that is set but not used.
8494 * dired.c (file_name_completion): Remove var that is set but not used.
8496 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8498 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8499 (Finsert_file_contents): Remove unnecessary code checking fd.
8501 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8502 Check for integer overflow on size calculations.
8504 * buffer.c (Fprevious_overlay_change): Remove var that is set
8507 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8508 Remove vars that are set but not used.
8509 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8510 (timer_check_2): Mark vars as initialized.
8512 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8514 * image.c (lookup_image): Remove var that is set but not used.
8515 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8517 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8518 that are set but not used.
8520 * xfns.c (make_invisible_cursor): Don't return garbage
8521 if XCreateBitmapFromData fails (Bug#8410).
8523 * xselect.c (x_get_local_selection, x_handle_property_notify):
8524 Remove vars that are set but not used.
8526 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8527 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8529 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8530 Remove var that is set but not used.
8531 (scroll_bar_windows_size): Now size_t, not int.
8532 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8535 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8536 (map_tty_color) [!defined MSDOS]: Likewise.
8538 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8540 * coding.c: Remove vars that are set but not used.
8541 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8542 All callers changed.
8543 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8544 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8545 (decode_coding_charset): Remove vars that are set but not used.
8547 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8548 that is set but not used.
8550 * print.c (print_object): Remove var that is set but not used.
8552 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8553 The gnulib version avoids calling malloc in the usual case,
8554 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8555 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8556 * filelock.c (current_lock_owner): Likewise.
8557 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8558 * sysdep.c: Include allocator.h, careadlinkat.h.
8559 (emacs_no_realloc_allocator): New static constant.
8560 (emacs_readlink): New function.
8561 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8562 ../lib/careadlinkat.h.
8564 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8566 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8567 first non-nil return value).
8569 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8571 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8572 if not defined (Bug#8403).
8574 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8576 * xdisp.c (display_count_lines): Remove parameter `start',
8577 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8578 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8579 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8580 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8581 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8582 and thereabouts. All callers changed.
8583 (get_per_char_metric): Remove parameter `f', unused since
8584 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8586 2011-04-02 Jim Meyering <meyering@redhat.com>
8588 do not dereference NULL upon failed strdup
8589 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8590 (ns_get_family): Likewise.
8592 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8594 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8596 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8598 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8601 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8603 Add lexical binding.
8605 * window.c (Ftemp_output_buffer_show): New fun.
8606 (Fsave_window_excursion):
8607 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8609 * lread.c (lisp_file_lexically_bound_p): New function.
8610 (Fload): Bind Qlexical_binding.
8611 (readevalloop): Remove `evalfun' arg.
8612 Bind Qinternal_interpreter_environment.
8613 (Feval_buffer): Bind Qlexical_binding.
8614 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8616 (syms_of_lread): Declare `lexical-binding'.
8618 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8620 * keyboard.c (eval_dyn): New fun.
8621 (menu_item_eval_property): Use it.
8623 * image.c (parse_image_spec): Use Ffunctionp.
8625 * fns.c (concat, mapcar1): Accept byte-code-functions.
8627 * eval.c (Fsetq): Handle lexical vars.
8628 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8629 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8630 (FletX, Flet): Obey lexical binding.
8631 (Fcommandp): Handle closures.
8632 (Feval): New `lexical' arg.
8633 (eval_sub): New function extracted from Feval. Use it almost
8634 everywhere where Feval was used. Look up vars in lexical env.
8636 (Ffunctionp): Move from subr.el.
8637 (Ffuncall): Handle closures.
8638 (apply_lambda): Remove `eval_flags'.
8639 (funcall_lambda): Handle closures and new byte-code-functions.
8640 (Fspecial_variable_p): New function.
8641 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8642 but without exporting it to Lisp.
8644 * doc.c (Fdocumentation, store_function_docstring):
8645 * data.c (Finteractive_form): Handle closures.
8647 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8650 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8652 (exec_byte_code): New function extracted from Fbyte_code to handle new
8653 calling convention for byte-code-functions. Add new byte-codes.
8655 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8657 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8659 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8661 * xdisp.c (redisplay_internal): Fix prototype.
8663 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8665 * xdisp.c (SCROLL_LIMIT): New macro.
8666 (try_scrolling): Use it when setting scroll_limit.
8667 Limit scrolling to 100 screen lines.
8668 (redisplay_window): Even when falling back on "recentering",
8669 position point in the window according to scroll-conservatively,
8670 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8672 (try_scrolling): When point is above the window, allow searching
8673 as far as scroll_max, or one screenful, to compute vertical
8674 distance from PT to the scroll margin position. This prevents
8675 try_scrolling from unnecessarily failing when
8676 scroll-conservatively is set to a value slightly larger than the
8677 window height. Clean up the case of PT below the margin at bottom
8678 of window: scroll_max can no longer be INT_MAX. When aggressive
8679 scrolling is in use, don't let point enter the opposite scroll
8680 margin as result of the scroll.
8681 (syms_of_xdisp) <scroll-conservatively>: Document the
8682 threshold of 100 lines for never-recentering scrolling.
8684 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8686 * dispextern.h (move_it_by_lines):
8687 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8688 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8689 (message_log_check_duplicate): Remove parameters `prev_bol' and
8690 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8691 (redisplay_internal): Remove parameter `preserve_echo_area',
8692 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8694 * indent.c (Fvertical_motion):
8695 * window.c (window_scroll_pixel_based, Frecenter):
8696 Don't pass `need_y_p' to `move_it_by_lines'.
8698 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8700 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8701 steal a few bits to be more compact.
8702 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8703 Remove unneeded casts.
8705 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8707 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8709 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8710 binding" message (bug#7967).
8712 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8714 Fix more problems found by GCC 4.6.0's static checks.
8716 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8717 Remove unused local var.
8719 * editfns.c (Fmessage_box): Remove unused local var.
8721 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8722 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8723 Omit unused local vars.
8724 * window.c (shrink_windows): Omit unused local var.
8725 * menu.c (digest_single_submenu): Omit unused local var.
8726 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8727 Omit unused local var.
8729 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8730 Don't assume string length fits in int.
8731 (keyremap_step, read_key_sequence): Use size_t for sizes.
8732 (read_key_sequence): Don't check last_real_key_start redundantly.
8734 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8735 instead of alloca (Bug#8344).
8737 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8738 (Fbacktrace_frame): Don't assume nframes fits in int.
8740 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8742 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8745 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8747 * cm.c (calccost): Turn while-do into do-while, for clarity.
8749 * keyboard.c (syms_of_keyboard): Use the same style as later
8750 in this function when indexing through an array. This also
8751 works around GCC bug 48267.
8753 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8755 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8757 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8758 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8760 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8761 This avoids undefined behavior on integer overflow, and is a bit
8762 more convenient anyway since it is compared to a size_t variable.
8764 Variadic C functions now count arguments with size_t, not int.
8765 This avoids an unnecessary limitation on 64-bit machines, which
8766 caused (substring ...) to crash on large vectors (Bug#8344).
8767 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8768 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8769 All variadic functions and their callers changed accordingly.
8770 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8771 * data.c (arith_driver, float_arith_driver): Likewise.
8772 * editfns.c (general_insert_function): Likewise.
8773 * eval.c (struct backtrace.nargs, interactive_p)
8774 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8775 (funcall_lambda, mark_backtrace): Likewise.
8776 * fns.c (concat): Likewise.
8777 * frame.c (x_set_frame_parameters): Likewise.
8778 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8779 0 if not found, not -1. All callers changed.
8781 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8782 (stack_copy_size): Now size_t, not int.
8783 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8785 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8787 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8788 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8789 All callers changed.
8791 * lisp.h (multibyte_char_to_unibyte):
8792 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8793 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8794 * character.h (CHAR_TO_BYTE8):
8795 * cmds.c (internal_self_insert):
8796 * editfns.c (general_insert_function):
8797 * keymap.c (push_key_description):
8798 * search.c (Freplace_match):
8799 * xdisp.c (message_dolog, set_message_1): All callers changed.
8801 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8803 * keyboard.c (safe_run_hook_funcall): New function.
8804 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8805 don't set the hook to nil, but remove the offending function instead.
8806 (Qcommand_hook_internal): Remove, unused.
8807 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8808 Vcommand_hook_internal.
8810 * eval.c (enum run_hooks_condition): Remove.
8811 (funcall_nil, funcall_not): New functions.
8812 (run_hook_with_args): Call each function through a `funcall' argument.
8813 Remove `cond' argument, now redundant.
8814 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8815 (Frun_hook_with_args_until_failure): Adjust accordingly.
8816 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8818 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8820 * dispextern.h (string_buffer_position): Remove declaration.
8822 * print.c (strout): Remove parameter `multibyte', unused since
8823 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8825 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8826 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8827 All callers changed.
8829 * w32.c (_wsa_errlist): Use braces for struct initializers.
8831 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8832 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8833 All callers changed.
8834 (string_buffer_position): Likewise. Also, make static (it's never
8835 used outside xdisp.c).
8836 (cursor_row_p): Remove parameter `w', unused since
8837 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8838 (decode_mode_spec): Remove parameter `precision', introduced during
8839 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8840 All callers changed.
8842 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8844 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8846 2011-03-27 Anders Lindgren <andlind@gmail.com>
8848 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8849 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8850 (ns_update_auto_hide_menu_bar): New functions.
8851 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8852 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8853 ns_constrain_all_frames.
8854 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8855 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8857 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8859 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8861 2011-03-27 Glenn Morris <rgm@gnu.org>
8863 * syssignal.h: Replace RETSIGTYPE with void.
8864 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8865 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8866 Replace SIGTYPE with void everywhere.
8867 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8868 * s/template.h (SIGTYPE): Remove commented out definition.
8870 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8872 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8873 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8875 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8877 * w32.c (read_unc_volume): Use parameter `henum', instead of
8878 global variable `wget_enum_handle'.
8880 * keymap.c (describe_vector): Remove parameters `indices' and
8881 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8882 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8884 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8886 * keyboard.c (timer_check): Remove parameter `do_it_now',
8887 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8888 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8889 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8891 * keyboard.c (read_char):
8892 * w32menu.c (w32_menu_display_help):
8893 * xmenu.c (show_help_event, menu_help_callback):
8894 Adjust calls to `show_help_echo'.
8896 * gtkutil.c (xg_maybe_add_timer):
8897 * keyboard.c (readable_events):
8898 * process.c (wait_reading_process_output):
8899 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8901 * insdel.c (adjust_markers_gap_motion):
8902 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8903 (gap_left, gap_right): Don't call it.
8905 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8907 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8908 incurred during fontification.
8910 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8912 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8913 (DEFVAR_PER_BUFFER): Don't pass it.
8915 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8916 (scrolling_window): Don't pass it.
8918 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8920 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8922 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8924 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8925 of variables specific to SELinux and computation of `encoded_absname'.
8927 * image.c (XPutPixel): Remove unused variable `height'.
8929 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8931 * unexw32.c (get_section_info): Remove unused variable `section'.
8933 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8934 (system_process_attributes): Remove unused variable `sess'.
8935 (sys_read): Remove unused variable `err'.
8937 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8938 (w32_wnd_proc): Remove unused variable `isdead'.
8939 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8940 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8941 (x_create_tip_frame): Remove unused variable `tem'.
8943 * w32inevt.c (w32_console_read_socket):
8944 Remove unused variable `no_events'.
8946 * w32term.c (x_draw_composite_glyph_string_foreground):
8947 Remove unused variable `width'.
8949 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8951 * w32term.c (x_set_glyph_string_clipping):
8952 Don't pass uninitialized region to CombineRgn.
8954 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8956 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8957 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8958 (Fx_close_connection): Remove unused variable `i'.
8960 * w32font.c (w32font_draw): Return number of glyphs.
8961 (w32font_open_internal): Remove unused variable `i'.
8962 (w32font_driver): Add missing initializer.
8964 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8965 (fill_in_menu): Remove unused variable `items_added'.
8967 * w32term.c (last_mouse_press_frame): Remove static global variable.
8968 (w32_clip_to_row): Remove unused variable `f'.
8969 (x_delete_terminal): Remove unused variable `i'.
8971 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8972 (NOTHING): Remove unused static global variable.
8973 (uniscribe_check_otf): Remove unused variable `table'.
8974 (uniscribe_font_driver): Add missing initializers.
8976 2011-03-23 Julien Danjou <julien@danjou.info>
8978 * term.c (Fsuspend_tty, Fresume_tty):
8979 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8980 * window.c (temp_output_buffer_show):
8981 * insdel.c (signal_before_change):
8982 * frame.c (Fhandle_switch_frame):
8983 * fileio.c (Fdo_auto_save):
8984 * emacs.c (Fkill_emacs):
8985 * editfns.c (save_excursion_restore):
8986 * cmds.c (internal_self_insert):
8987 * callint.c (Fcall_interactively):
8988 * buffer.c (Fkill_all_local_variables):
8989 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8991 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8992 unconditionally since it does the check itself.
8994 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8996 Fix more problems found by GCC 4.5.2's static checks.
8998 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8999 the first time through the loop, since we know p0 < p1 then.
9000 This also avoids a gcc -Wstrict-overflow warning.
9002 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9003 leading to a memory leak, possible in functions like
9004 load_charset_map_from_file that can allocate an unbounded number
9005 of objects (Bug#8318).
9007 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9008 that could (at least in theory) be that large.
9010 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9011 This is less likely to overflow, and avoids undefined behavior if
9012 overflow does occur. All callers changed. Use strtoul to scan
9013 for the unsigned long integer.
9014 (pint2hrstr): Simplify and tune code slightly.
9015 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9017 * scroll.c (do_scrolling): Work around GCC bug 48228.
9018 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9020 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9021 This also avoids a warning with gcc -Wstrict-overflow.
9022 (validate_x_resource_name): Simplify count usage.
9023 This also avoids a warning with gcc -Wstrict-overflow.
9025 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9028 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9030 * process.c (Fmake_network_process): Use socklen_t, not int,
9031 where POSIX says socklen_t is required in portable programs.
9032 This fixes a porting bug on hosts like 64-bit HP-UX, where
9033 socklen_t is wider than int (Bug#8277).
9034 (Fmake_network_process, server_accept_connection):
9035 (wait_reading_process_output, read_process_output):
9038 * process.c: Rename or move locals to avoid shadowing.
9039 (list_processes_1, Fmake_network_process):
9040 (read_process_output_error_handler, exec_sentinel_error_handler):
9041 Rename or move locals.
9042 (Fmake_network_process): Define label "retry_connect" only if needed.
9043 (Fnetwork_interface_info): Fix pointer signedness.
9044 (process_send_signal): Add cast to avoid pointer signedness problem.
9045 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9046 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9048 Make tparam.h and terminfo.c consistent.
9049 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9050 Include tparam.h instead, since it declares them.
9051 * cm.h (PC): Remove extern decl; tparam.h now does this.
9052 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9053 * terminfo.c: Include tparam.h, to check interfaces.
9054 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9055 (tparam): Adjust signature to match interface in tparam.h;
9056 this removes some undefined behavior. Check that outstring and len
9057 are zero, which they always are with Emacs.
9058 * tparam.h (PC, BC, UP): New extern decls.
9060 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9061 (xftfont_open): Rename locals to avoid shadowing.
9063 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9064 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9065 (OTF_TAG_SYM): Omit macro if not needed.
9066 (ftfont_list): Remove unused local.
9067 (get_adstyle_property, ftfont_pattern_entity):
9068 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9069 Rename locals to avoid shadowing.
9071 * xfont.c (xfont_list_family): Mark var as initialized.
9073 * xml.c (make_dom): Now static.
9075 * composite.c (composition_compute_stop_pos): Rename local to
9077 (composition_reseat_it): Remove unused locals.
9078 (find_automatic_composition, composition_adjust_point): Likewise.
9079 (composition_update_it): Mark var as initialized.
9080 (find_automatic_composition): Mark vars as initialized,
9081 with a FIXME (Bug#8290).
9083 character.h: Rename locals to avoid shadowing.
9084 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9085 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9086 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9087 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9090 * textprop.c (property_change_between_p): Remove; unused.
9092 * intervals.c (interval_start_pos): Now static.
9094 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9096 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9097 Rename locals to avoid shadowing.
9099 * sound.c (wav_play, au_play, Fplay_sound_internal):
9100 Fix pointer signedness.
9101 (alsa_choose_format): Remove unused local var.
9102 (wav_play): Initialize a variable to 0, to prevent undefined
9103 behavior (Bug#8278).
9105 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9107 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9109 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9110 clobbering (Bug#8298).
9111 * sysdep.c (sys_subshell): Likewise.
9112 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9114 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9115 This should get cleaned up, so that child_setup has the
9116 same signature on all platforms.
9118 * callproc.c (call_process_cleanup): Now static.
9119 (relocate_fd): Rename locals to avoid shadowing.
9121 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9123 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9124 not to be necessary, and produces flickering.
9126 2011-03-20 Glenn Morris <rgm@gnu.org>
9128 * config.in: Remove file.
9130 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9132 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9133 are now in src/globals.h.
9134 (syms_of_minibuf): Remove spurious & from previous change.
9136 2011-03-20 Leo Liu <sdl.web@gmail.com>
9138 * minibuf.c (completing-read-function): New variable.
9139 (completing-read-default): Rename from completing-read.
9140 (completing-read): Call completing-read-function.
9142 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9144 * xfaces.c (Fx_load_color_file):
9145 Read color file from absolute filename (bug#8250).
9147 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9149 * makefile.w32-in: Update dependencies.
9151 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9153 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9155 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9157 Fix more problems found by GCC 4.5.2's static checks.
9159 * process.c (make_serial_process_unwind, send_process_trap):
9160 (sigchld_handler): Now static.
9162 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9163 That way, the code declares only the vars that it needs.
9164 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9165 * s/cygwin.h (PTY_ITERATION): Likewise.
9166 * s/darwin.h (PTY_ITERATION): Likewise.
9167 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9169 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9170 * process.c (allocate_pty): Don't declare stb unless it's needed.
9172 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9173 (CONSTANTLIM): Remove; unused.
9174 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9175 Define only if needed.
9177 * unexelf.c (unexec): Name an expression,
9178 to avoid gcc -Wbad-function-cast warning.
9179 Use a different way to cause a compilation error if anyone uses
9180 n rather than nn, a way that does not involve shadowing.
9181 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9183 * deps.mk (unexalpha.o): Remove; unused.
9185 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9186 * unexec.h: New file.
9187 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9188 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9190 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9191 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9192 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9193 Change as necessary to match prototype in unexec.h.
9195 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9197 (back_comment, skip_chars): Mark vars as initialized.
9199 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9200 Rename locals to avoid shadowing.
9202 * lread.c (read1): Rewrite so as not to use empty "else".
9203 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9205 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9207 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9208 warning when compiling print.c.
9210 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9211 instead of using an uninitialized var.
9212 (font_sort_entities): Mark var as initialized.
9214 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9216 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9217 pointers to constants.
9218 (font_parse_fcname): Remove unused vars.
9219 (font_delete_unmatched): Now static.
9220 (font_get_spec): Remove; unused.
9221 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9222 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9223 Rename or move locals to avoid shadowing.
9225 * fns.c (require_nesting_list, require_unwind): Now static.
9226 (Ffillarray): Rename locals to avoid shadowing.
9228 * floatfns.c (domain_error2): Define only if needed.
9229 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9231 * alloc.c (mark_backtrace): Move decl from here ...
9232 * lisp.h: ... to here, so that it can be checked.
9234 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9235 (Fdefvar): Rewrite so as not to use empty "else".
9236 (lisp_indirect_variable): Name an expression,
9237 to avoid gcc -Wbad-function-cast warning.
9238 (Fdefvar): Rename locals to avoid shadowing.
9240 * callint.c (quotify_arg, quotify_args): Now static.
9241 (Fcall_interactively): Rename locals to avoid shadowing.
9242 Use const pointer when appropriate.
9244 * lisp.h (get_system_name, get_operating_system_release):
9245 Move decls here, to check interfaces.
9246 * process.c (get_operating_system_release): Move decl to lisp.h.
9247 * xrdb.c (get_system_name): Likewise.
9248 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9249 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9250 some of which prompt warnings from gcc -Wbad-function-cast.
9251 (Fformat_time_string, Fencode_time, Finsert_char):
9252 (Ftranslate_region_internal, Fformat):
9253 Rename or remove local vars to avoid shadowing.
9254 (Ftranslate_region_internal): Mark var as initialized.
9256 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9259 * lisp.h (eassert): Check that the argument compiles, even if
9260 ENABLE_CHECKING is not defined.
9262 * data.c (Findirect_variable): Name an expression, to avoid
9263 gcc -Wbad-function-cast warning.
9264 (default_value, arithcompare, arith_driver, arith_error): Now static.
9265 (store_symval_forwarding): Rename local to avoid shadowing.
9266 (Fmake_variable_buffer_local, Fmake_local_variable):
9267 Mark variables as initialized.
9268 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9270 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9271 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9272 Rename locals to avoid shadowing.
9273 (mark_stack): Move local variables into the #ifdef region where
9275 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9276 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9278 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9279 (GC_STRING_CHARS): Remove; not used.
9280 (Fmemory_limit): Cast sbrk's returned value to char *.
9282 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9283 avoids undefined behavior in theory.
9285 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9287 Use functions, not macros, for up- and down-casing (Bug#8254).
9288 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9289 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9290 to use the following functions instead of these macros.
9291 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9292 EMACS_INT, since callers assume the returned value fits in int.
9293 (upcase1): Likewise, for UPCASE_TABLE.
9294 (uppercasep, lowercasep, upcase): New static inline functions.
9295 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9296 the race-condition problem in the old DOWNCASE.
9298 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9299 Rename locals to avoid shadowing.
9300 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9301 (regex_compile, re_search_2, re_match_2_internal):
9302 Remove unused local vars.
9303 (FREE_VAR): Rewrite so as not to use empty "else",
9304 which gcc can warn about.
9305 (regex_compile, re_match_2_internal): Mark locals as initialized.
9306 (RETALLOC_IF): Define only if needed.
9307 (WORDCHAR_P): Likewise. This one is never needed, but is used
9308 only in a comment talking about a compiler bug, so put inside
9309 the #if 0 of that comment.
9310 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9311 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9314 * search.c (boyer_moore): Rename locals to avoid shadowing.
9315 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9316 (PREV_CHAR_BOUNDARY): Likewise.
9318 * search.c (simple_search): Remove unused var.
9320 * dired.c (compile_pattern): Move decl from here ...
9321 * lisp.h: ... to here, so that it can be checked.
9322 (struct re_registers): New forward decl.
9324 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9326 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9328 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9329 Rename locals to avoid shadowing.
9330 (Fvertical_motion): Mark locals as initialized.
9332 * casefiddle.c (casify_object, casify_region): Now static.
9333 (casify_region): Mark local as initialized.
9335 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9337 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9338 New macros, so that the caller can use some names other than
9339 gcpro1, gcpro2, etc.
9340 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9342 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9343 argument, for consistency with GCPRO2_VAR, etc: it is now the
9344 prefix of the variable, not the variable itself. All uses
9346 * dired.c (directory_files_internal, file_name_completion):
9347 Rename locals to avoid shadowing.
9349 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9350 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9351 dired.c's scmp function, had undefined behavior.
9352 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9353 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9354 * buffer.h: ... to here, because these macros use current_buffer,
9355 and the new implementation with inline functions needs to have
9356 current_buffer in scope now, rather than later when the macros
9358 (downcase, upcase1): New static inline functions.
9359 (DOWNCASE, UPCASE1): Reimplement using these functions.
9360 This avoids undefined behavior in expressions like
9361 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9362 from race conditions in accessing the global variables
9363 case_temp1 and case_temp2.
9364 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9365 * lisp.h (case_temp1, case_temp2): Remove their decls.
9366 * character.h (ASCII_CHAR_P): Move from here ...
9367 * lisp.h: ... to here, so that the inline functions mentioned
9370 * dired.c (directory_files_internal_unwind): Now static.
9372 * fileio.c (file_name_as_directory, directory_file_name):
9373 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9375 (file_name_as_directory): Use const pointers when appropriate.
9376 (Fexpand_file_name): Likewise. In particular, newdir might
9377 point at constant storage, so make it a const pointer.
9378 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9379 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9381 (Fset_file_times, Finsert_file_contents, auto_save_error):
9382 Rename locals to avoid shadowing.
9384 * minibuf.c (choose_minibuf_frame_1): Now static.
9385 (Ftry_completion, Fall_completions): Rename or remove locals
9388 * marker.c (bytepos_to_charpos): Remove; unused.
9390 * lisp.h (verify_bytepos, count_markers): New decls,
9391 so that gcc does not warn that these functions aren't declared.
9393 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9394 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9395 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9396 (copy_text): Remove unused local var.
9398 * filelock.c (within_one_second): Now static.
9399 (lock_file_1): Rename local to avoid shadowing.
9401 * buffer.c (fix_overlays_before): Mark locals as initialized.
9402 (fix_start_end_in_overlays): Likewise. This function should be
9403 simplified by using pointers-to-pointers, but that's a different
9405 (switch_to_buffer_1): Now static.
9406 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9407 (report_overlay_modification): Rename locals to avoid shadowing.
9409 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9410 Fix pointer signedness issue.
9411 (sys_subshell): Mark local as volatile if checking for lint,
9412 to suppress a gcc -Wclobbered warning that does not seem to be right.
9413 (MAXPATHLEN): Define only if needed.
9415 * process.c (serial_open, serial_configure): Move decls from here ...
9416 * systty.h: ... to here, so that they can be checked.
9418 * fns.c (get_random, seed_random): Move extern decls from here ...
9419 * lisp.h: ... to here, so that they can be checked.
9421 * sysdep.c (reset_io): Now static.
9422 (wait_for_termination_signal): Remove; unused.
9424 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9425 (copy_keymap_item, append_key, push_text_char_description):
9427 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9428 (DENSE_TABLE_SIZE): Remove; unused.
9429 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9430 (describe_map_tree):
9431 Rename locals to avoid shadowing.
9433 * keyboard.c: Declare functions static if they are not used elsewhere.
9434 (echo_char, echo_dash, cmd_error, top_level_2):
9435 (poll_for_input, handle_async_input): Now static.
9436 (read_char, kbd_buffer_get_event, make_lispy_position):
9437 (make_lispy_event, make_lispy_movement, apply_modifiers):
9438 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9439 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9440 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9441 (read_key_sequence, read_char): Mark locals as initialized.
9442 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9444 * keyboard.h (make_ctrl_char): New decl.
9445 (mark_kboards): Move decl here ...
9446 * alloc.c (mark_kboards): ... from here.
9448 * lisp.h (force_auto_save_soon): New decl.
9450 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9451 (DEFINE_DUMMY_FUNCTION): New macro.
9452 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9454 (main): Add casts to avoid warnings
9455 if GCC considers string literals to be constants.
9457 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9459 * dbusbind.c: Pointer signedness fixes.
9460 (xd_signature, xd_append_arg, xd_initialize):
9461 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9462 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9463 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9464 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9466 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9467 if GCC considers string literals to be constants.
9468 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9470 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9472 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9473 (print_preprocess, print_object): New macro to fix last change.
9475 * print.c (print_preprocess): Don't forget font objects.
9477 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9479 * emacs.c (USAGE3): Doc fixes.
9481 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9483 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9486 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9488 * lisp.h (VWindow_system, Qfile_name_history):
9489 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9490 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9491 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9493 * w32select.c: Don't #include "keyboard.h".
9494 (run_protected): Add extern declaration for waiting_for_input.
9496 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9497 * w32console.c (detect_input_pending, read_input_pending)
9498 (encode_terminal_code):
9499 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9500 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9501 (w32_system_caret_y, Qfile_name_history):
9502 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9503 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9504 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9505 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9506 * w32proc.c (Qlocal, report_file_error):
9507 * w32term.c (Vwindow_system, updating_frame):
9508 * w32uniscribe.c (initialized, uniscribe_font_driver):
9509 Remove unneeded extern declarations.
9511 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9513 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9515 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9517 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9518 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9519 These macros can no longer be used for assignment.
9521 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9522 Assign struct members directly, instead of using BUF_BEGV etc.
9523 (record_buffer_markers, fetch_buffer_markers): New functions for
9524 recording and fetching special buffer markers.
9525 (set_buffer_internal_1, set_buffer_temp): Use them.
9527 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9529 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9531 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9532 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9534 * xdisp.c (hscroll_window_tree):
9535 (reconsider_clip_changes): Use PT instead of BUF_PT.
9537 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9539 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9540 $(EMACS_ROOT)/lib/intprops.h.
9542 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9544 Fix more problems found by GCC 4.5.2's static checks.
9546 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9547 to unsigned char * to avoid compiler diagnostic.
9548 (xg_free_frame_widgets): Make it clear that a local variable is
9549 needed only if USE_GTK_TOOLTIP.
9550 (gdk_window_get_screen): Make it clear that this macro is needed
9551 only if USE_GTK_TOOLTIP.
9552 (int_gtk_range_get_value): New function, which avoids a diagnostic
9553 from gcc -Wbad-function-cast.
9554 (xg_set_toolkit_scroll_bar_thumb): Use it.
9555 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9556 diagnostic from gcc -Wbad-function-cast.
9557 (get_utf8_string, xg_get_file_with_chooser):
9558 Rename locals to avoid shadowing.
9559 (create_dialog): Move locals to avoid shadowing.
9561 * xgselect.c (xg_select): Remove unused var.
9563 * image.c (four_corners_best): Mark locals as initialized.
9564 (gif_load): Initialize transparent_p to zero (Bug#8238).
9565 Mark another local as initialized.
9566 (my_png_error, my_error_exit): Mark with NO_RETURN.
9568 * image.c (clear_image_cache): Now static.
9569 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9570 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9571 (x_edge_detection): Remove unnecessary cast that
9572 gcc -Wbad-function-cast diagnoses.
9573 (gif_load): Fix pointer signedness.
9574 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9575 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9577 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9579 Improve quality of tests for time stamp overflow.
9580 For example, without this patch (encode-time 0 0 0 1 1
9581 1152921504606846976) returns the obviously-bogus value (-948597
9582 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9583 reports time overflow. See
9584 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9585 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9586 * editfns.c: Include limits.h and intprops.h.
9587 (TIME_T_MIN, TIME_T_MAX): New macros.
9588 (time_overflow): Move earlier, to before first use.
9589 (hi_time, lo_time): New functions, for an accurate test for
9591 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9592 (Fget_internal_run_time): Don't assume time_t fits in int.
9593 (make_time): Use list2 instead of Fcons twice.
9594 (Fdecode_time): More accurate test for out-of-range times.
9595 (check_tm_member): New function.
9596 (Fencode_time): Use it, to test for out-of-range times.
9597 (lisp_time_argument): Don't rely on undefined left-shift and
9598 right-shift behavior when checking for time stamp overflow.
9600 * editfns.c (time_overflow): New function, refactoring common code.
9601 (Fformat_time_string, Fdecode_time, Fencode_time):
9602 (Fcurrent_time_string): Use it.
9604 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9605 * dired.c (make_time): Move to ...
9606 * editfns.c (make_time): ... here.
9607 * systime.h: Note the move.
9609 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9611 * fringe.c (update_window_fringes): Remove unused variables.
9613 * unexmacosx.c (copy_data_segment): Also copy __got section.
9616 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9618 * termcap.c [MSDOS]: Include "msdos.h".
9619 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9620 Constify `char *' arguments and their references according to
9621 prototypes in tparam.h.
9623 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9625 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9626 Adapt all references accordingly.
9628 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9630 2011-03-11 Tom Tromey <tromey@redhat.com>
9632 * buffer.c (syms_of_buffer): Remove obsolete comment.
9634 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9636 * termhooks.h (encode_terminal_code): Declare prototype.
9638 * msdos.c (encode_terminal_code): Don't declare prototype.
9640 * term.c (encode_terminal_code): Now external again, used by
9641 w32console.c and msdos.c.
9643 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9644 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9646 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9648 Fix some minor problems found by GCC 4.5.2's static checks.
9650 * fringe.c (update_window_fringes): Mark locals as initialized
9652 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9654 * alloc.c (mark_fringe_data): Move decl from here ...
9655 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9656 to check its interface.
9657 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9659 * fontset.c (free_realized_fontset): Now static.
9660 (Fset_fontset_font): Rename local to avoid shadowing.
9661 (fontset_font): Mark local as initialized.
9662 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9664 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9666 * xselect.c (x_disown_buffer_selections): Remove; not used.
9667 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9668 (x_own_selection, Fx_disown_selection_internal): Rename locals
9670 (x_handle_dnd_message): Remove local to avoid shadowing.
9672 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9673 so that the caller can use some name other than gcpro1.
9674 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9675 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9676 (Fx_backspace_delete_keys_p):
9677 Use them to avoid shadowing, and rename vars to avoid shadowing.
9678 (x_decode_color, x_set_name, x_window): Now static.
9679 (Fx_create_frame): Add braces to silence GCC warning.
9680 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9681 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9682 Remove unused locals.
9683 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9684 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9685 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9688 * xterm.h (x_mouse_leave): New decl.
9690 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9691 Remove unused functions.
9692 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9693 (x_calc_absolute_position): Now static.
9694 (XTread_socket): Don't define label "out" unless it's used.
9695 Don't declare local "event" unless it's used.
9696 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9697 unless they are used.
9698 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9699 (x_fatal_error_signal): Remove; not used.
9700 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9701 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9702 (x_error_catcher, x_connection_closed, x_error_handler):
9703 (x_error_quitter, xembed_send_message, x_iconify_frame):
9704 (my_log_handler): Rename locals to avoid shadowing.
9705 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9706 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9708 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9709 Rename or move locals to avoid shadowing.
9710 (tty_defined_color, merge_face_heights): Now static.
9711 (free_realized_faces_for_fontset): Remove; not used.
9712 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9713 does not deduce is never used uninitialized.
9714 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9715 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9717 * terminal.c (store_terminal_param): Now static.
9719 * xmenu.c (menu_highlight_callback): Now static.
9720 (set_frame_menubar): Remove unused local.
9721 (xmenu_show): Rename parameter to avoid shadowing.
9722 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9723 since they might point to immutable storage.
9724 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9725 since it's unused otherwise.
9727 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9728 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9729 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9730 avoids a gcc -Wuninitialized diagnostic.
9731 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9732 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9733 does not deduce are never used uninitialized.
9735 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9737 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9738 * window.c (window_loop, size_window):
9739 (run_window_configuration_change_hook, enlarge_window): Likewise.
9741 * window.c (display_buffer): Now static.
9742 (size_window): Mark variables that gcc -Wuninitialized
9743 does not deduce are never used uninitialized.
9744 * window.h (check_all_windows): New decl, to forestall
9745 gcc -Wmissing-prototypes diagnostic.
9746 * dispextern.h (bidi_dump_cached_states): Likewise.
9748 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9750 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9752 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9753 and to avoid gcc -Wuninitialized warning.
9754 (load_charset_map): Mark variables that gcc -Wuninitialized
9755 does not deduce are never used uninitialized.
9756 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9758 * coding.c (coding_set_source, coding_set_destination):
9759 Use "else { /* comment */ }" rather than "else /* comment */;"
9760 for clarity, and to avoid gcc -Wempty-body warning.
9761 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9762 a block, when the outer 'i' will do.
9763 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9764 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9765 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9766 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9767 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9768 Rename locals to avoid shadowing.
9769 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9770 * coding.c (emacs_mule_char, encode_invocation_designation):
9771 Now static, since they're not used elsewhere.
9772 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9773 (decode_coding_object, encode_coding_object, detect_coding_system):
9774 (decode_coding_emacs_mule): Mark variables that gcc
9775 -Wuninitialized does not deduce are never used uninitialized.
9776 (detect_coding_iso_2022): Initialize a local variable that might
9777 be used uninitialized. Leave a FIXME because it's not clear that
9778 this initialization is needed. (Bug#8211)
9779 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9780 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9781 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9782 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9783 Remove unused macros.
9785 * category.c (hash_get_category_set): Remove unused local var.
9786 (copy_category_table): Now static, since it's not used elsewhere.
9787 * character.c (string_count_byte8): Likewise.
9789 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9790 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9792 * chartab.c (copy_sub_char_table): Now static, since it's not used
9794 (sub_char_table_ref_and_range, char_table_ref_and_range):
9795 Rename locals to avoid shadowing.
9796 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9798 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9799 (BIDI_BOB): Remove unused macro.
9801 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9802 deduce are never used uninitialized.
9803 * term.c (encode_terminal_code): Likewise.
9805 * term.c (encode_terminal_code): Now static. Remove unused local.
9807 * tparam.h: New file.
9808 * term.c, tparam.h: Include it.
9809 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9810 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9811 Move these decls to tparam.h, and make them agree with what
9812 is actually in tparam.c. The previous trick of using incompatible
9813 decls in different modules does not conform to the C standard.
9814 All callers of tparam changed to use tparam's actual API.
9815 * tparam.c (tparam1, tparam, tgoto):
9816 Use const pointers where appropriate.
9818 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9819 * cm.h (struct cm): Likewise.
9820 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9821 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9822 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9823 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9824 (turn_on_face, init_tty): Likewise.
9825 * termchar.h (struct tty_display_info): Likewise.
9827 * term.c (term_mouse_position): Rename local to avoid shadowing.
9829 * alloc.c (mark_ttys): Move decl from here ...
9830 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9832 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9834 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9836 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9838 * search.c (compile_pattern_1): Remove argument regp, unused since
9839 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9840 (compile_pattern): Don't pass it.
9842 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9844 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9845 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9847 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9849 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9851 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9852 gdk_window_get_screen, gdk_window_get_geometry,
9853 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9854 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9855 (xg_get_pixbuf_from_pixmap): New function.
9856 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9857 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9858 Call xg_get_pixbuf_from_pixmap instead of
9859 gdk_pixbuf_get_from_drawable.
9860 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9861 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9862 (xg_check_special_colors): Use GtkStyleContext and its functions
9864 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9865 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9866 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9867 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9868 Call gtk_widget_get_preferred_size.
9869 (xg_frame_resized): gdk_window_get_geometry only takes 5
9871 (xg_win_to_widget, xg_event_is_for_menubar):
9872 Call gdk_x11_window_lookup_for_display.
9873 (xg_set_widget_bg): New function.
9874 (delete_cb): New function.
9875 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9876 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9877 (xg_set_background_color): Call xg_set_widget_bg.
9878 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9879 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9880 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9881 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9883 (update_frame_tool_bar): Call gtk_widget_hide.
9884 (xg_initialize): Use GDK_KEY_g.
9886 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9888 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9890 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9891 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9892 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9894 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9896 * w32xfns.c (select_palette): Check success of RealizePalette against
9897 GDI_ERROR, not zero.
9899 See ChangeLog.11 for earlier changes.
9905 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9907 This file is part of GNU Emacs.
9909 GNU Emacs is free software: you can redistribute it and/or modify
9910 it under the terms of the GNU General Public License as published by
9911 the Free Software Foundation, either version 3 of the License, or
9912 (at your option) any later version.
9914 GNU Emacs is distributed in the hope that it will be useful,
9915 but WITHOUT ANY WARRANTY; without even the implied warranty of
9916 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9917 GNU General Public License for more details.
9919 You should have received a copy of the GNU General Public License
9920 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.