1 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3 * doc.c (get_doc_string): Improve the format passed to `error'.
5 * doprnt.c (doprnt): Improve commentary.
7 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
13 changes in globals.h immediately force recompilation.
14 (TAGS): Depend on $(CURDIR)/m/intel386.h and
16 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
18 * character.c (Fchar_direction): Function deleted.
19 (syms_of_character): Don't defsubr it.
20 <char-direction-table>: Deleted.
22 2011-04-23 Eli Zaretskii <eliz@gnu.org>
24 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
25 * doprnt.c: Include limits.h.
26 (SIZE_MAX): New macro.
27 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
28 local variables are now size_t instead of int or unsigned.
29 Improve overflow protection. Support `l' modifier for integer
30 conversions. Support %l conversion. Don't assume an EMACS_INT
31 argument for integer conversions and for %c.
33 * lisp.h (doprnt): Restore prototype.
35 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
38 * Makefile.in (base_obj): Add back doprnt.o.
40 * deps.mk (doprnt.o): Add back prerequisites.
41 (callint.o): Depend on character.h.
43 * eval.c (internal_lisp_condition_case): Include the handler
44 representation in the error message.
45 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
46 when breaking from the loop.
48 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
50 * callint.c (Fcall_interactively): When displaying error message
51 about invalid control letter, pass the character's codepoint, not
52 a pointer to its multibyte form. Improve display of the character
53 in octal and display also its hex code.
55 * character.c (char_string): Use %x to display the (unsigned)
56 codepoint of an invalid character, to avoid displaying a bogus
59 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
60 `error', not SYMBOL_NAME itself.
62 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
63 character arguments to `error'.
65 * charset.c (check_iso_charset_parameter): Fix incorrect argument
66 to `error' in error message about FINAL_CHAR argument. Make sure
67 FINAL_CHAR is a character, and use %c when it is passed as
70 2011-04-23 Eli Zaretskii <eliz@gnu.org>
72 * s/ms-w32.h (localtime): Redirect to sys_localtime.
74 * w32.c: Include <time.h>.
75 (sys_localtime): New function.
77 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
79 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
81 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
83 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
85 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
88 2011-04-19 Eli Zaretskii <eliz@gnu.org>
90 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
91 gl_state.e_property when gl_state.object is Qt.
93 * insdel.c (make_gap_larger): Remove limitation of buffer size
96 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
98 * xdisp.c (lookup_glyphless_char_display)
99 (produce_glyphless_glyph): Handle cons cell entry in
100 glyphless-char-display.
101 (Vglyphless_char_display): Document it.
103 * term.c (produce_glyphless_glyph): Handle cons cell entry in
104 glyphless-char-display.
106 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
108 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
110 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
112 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
113 definition for no-X builds.
115 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
117 Static checks with GCC 4.6.0 and non-default toolkits.
119 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
121 * process.c (keyboard_bit_set): Define only if SIGIO.
122 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
123 (send_process): Repair possible setjmp clobbering.
125 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
127 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
129 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
131 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
132 Define only if needed.
134 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
135 by pacifying GCC about it. Maybe it's time to retire it?
136 * xfaces.c (USG, __TIMEVAL__): Likewise.
138 * dispextern.h (struct redisplay_interface): Rename param
140 * termhooks.h (struct terminal): Likewise.
141 * xterm.c (xembed_send_message): Likewise.
143 * insdel.c (make_gap_smaller): Define only if
144 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
146 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
149 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
150 so that we aren't warned about unused symbols.
152 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
154 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
156 * xfns.c (x_real_positions): Mark locals as initialized.
158 * xmenu.c (xmenu_show): Don't use uninitialized vars.
160 * xterm.c: Fix problems found by static analysis with other toolkits.
161 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
162 (x_dispatch_event): Declare static if USE_GTK, and
163 define if USE_GTK || USE_X_TOOLKIT.
164 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
165 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
166 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
167 defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
169 * xmenu.c (menu_help_callback): Pointer type fixes.
170 Use const pointers when pointing at readonly data. Avoid pointer
172 (FALSE): Remove unused macro.
173 (update_frame_menubar): Remove unused decl.
175 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
177 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
178 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
179 (single_menu_item): Rename local to avoid shadowing.
181 * keyboard.c (make_lispy_event): Remove unused local var.
183 * frame.c, frame.h (x_get_resource_string): Bring this back, but
184 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
186 * bitmaps: Change bitmaps from unsigned char back to the X11
187 compatible char. Avoid the old compiler warnings about
188 out-of-range initializers by using, for example, '\xab' rather
191 * xgselect.c (xgselect_initialize): Check vs interface
192 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
194 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
196 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
199 * fns.c (vector): Remove; this old hack is no longer needed.
201 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
203 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
205 * xrdb.c (x_load_resources): Omit unused local.
207 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
208 (x_window): Rename locals to avoid shadowing.
209 (USG): Use the kludged USG macro, to pacify gcc.
211 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
212 (x_term_init): Remove local to avoid shadowing.
214 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
216 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
217 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
219 2011-04-16 Eli Zaretskii <eliz@gnu.org>
221 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
223 Fix regex.c, syntax.c and friends for buffers > 2GB.
224 * syntax.h (struct gl_state_s): Declare character position members
227 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
229 * textprop.c (verify_interval_modification, interval_of): Declare
232 * intervals.c (adjust_intervals_for_insertion): Declare arguments
235 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
237 * indent.c (Fvertical_motion): Local variable it_start is now
240 * regex.c (re_match, re_match_2, re_match_2_internal)
241 (bcmp_translate, regcomp, regexec, print_double_string)
242 (group_in_compile_stack, re_search, re_search_2, regex_compile)
243 (re_compile_pattern, re_exec): Declare arguments and local
244 variables `size_t' and `ssize_t' and return values `regoff_t', as
246 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
247 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
248 <compile_stack_type>: `size' and `avail' are now `size_t'.
250 * regex.h <regoff_t>: Use ssize_t, not int.
251 (re_search, re_search_2, re_match, re_match_2): Arguments that
252 specify buffer/string position and length are now ssize_t and
253 size_t. Return type is regoff_t.
255 2011-04-16 Ben Key <bkey76@gmail.com>
257 * nsfont.m: Fixed bugs in ns_get_family and
258 ns_descriptor_to_entity that were caused by using free to
259 deallocate memory blocks that were allocated by xmalloc (via
260 xstrdup). This caused Emacs to crash when compiled with
261 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
262 --enable-checking=xmallocoverrun). xfree is now used to
263 deallocate these memory blocks.
265 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
267 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
269 emacs_write: Accept and return EMACS_INT for sizes.
270 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
272 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
273 Accept and return EMACS_INT.
274 (emacs_gnutls_write): Return the number of bytes written on
276 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
277 (emacs_read, emacs_write): Remove check for negative size, as the
278 Emacs source code has been audited now.
279 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
280 (emacs_read, emacs_write): Use it.
281 * process.c (send_process): Adjust to the new signatures of
282 emacs_write and emacs_gnutls_write. Do not attempt to store
283 a byte offset into an 'int'; it might overflow.
284 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
286 * sound.c: Don't assume sizes fit in 'int'.
287 (struct sound_device.period_size, alsa_period_size):
288 Return EMACS_INT, not int.
289 (struct sound_device.write, vox_write, alsa_write):
290 Accept EMACS_INT, not int.
291 (wav_play, au_play): Use EMACS_INT to store sizes and to
292 record read return values.
294 2011-04-15 Ben Key <bkey76@gmail.com>
296 * keyboard.c (Qundefined): Don't declare static since it is used
298 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
299 static since they are used in nsfont.m.
301 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
303 * process.c (Qprocessp): Don't declare static.
304 * lisp.h (Qprocessp): Declare again.
306 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
308 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
310 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
312 Improve C-level modularity by making more things 'static'.
314 Don't publish debugger-only interfaces to other modules.
315 * lisp.h (safe_debug_print, debug_output_compilation_hack):
316 (verify_bytepos, count_markers): Move decls to the only modules
318 * region-cache.h (pp_cache): Likewise.
319 * window.h (check_all_windows): Likewise.
320 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
322 * sysdep.c (croak): Now static, if
323 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
324 * syssignal.h (croak): Declare only if not static.
326 * alloc.c (refill_memory_reserve): Now static if
327 !defined REL_ALLOC || defined SYSTEM_MALLOC.
328 * lisp.h (refill_memory_reserve): Declare only if not static.
330 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
331 Define only if USE_LUCID.
333 * xrdb.c (x_customization_string, x_rm_string): Now static.
335 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
336 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
338 * xdisp.c (draw_row_with_mouse_face): Now static.
339 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
341 * window.h (check_all_windows): Mark externally visible.
343 * window.c (window_deletion_count): Now static.
345 * undo.c: Make symbols static if they're not exported.
346 (last_undo_buffer, last_boundary_position, pending_boundary):
349 * textprop.c (interval_insert_behind_hooks): Now static.
350 (interval_insert_in_front_hooks): Likewise.
352 * term.c: Make symbols static if they're not exported.
353 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
354 (max_frame_lines, tty_set_terminal_modes):
355 (tty_reset_terminal_modes, tty_turn_off_highlight):
356 (get_tty_terminal): Now static.
357 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
358 * termhooks.h (term_mouse_moveto): Do not declare if
360 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
361 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
363 * sysdep.c: Make symbols static if they're not exported.
364 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
366 (sigprocmask_set, full_mask): Remove; unused.
367 (wait_debugging): Mark as visible.
368 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
369 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
371 * syntax.c (syntax_temp): Define only if !__GNUC__.
373 * sound.c (current_sound_device, current_sound): Now static.
375 * search.c (searchbufs, searchbuf_head): Now static.
377 * scroll.c (scroll_cost): Remove; unused.
378 * dispextern.h (scroll_cost): Remove decl.
380 * region-cache.h (pp_cache): Mark as externally visible.
382 * process.c: Make symbols static if they're not exported.
383 (process_tick, update_tick, create_process, chan_process):
384 (Vprocess_alist, proc_buffered_char, datagram_access):
385 (fd_callback_data, send_process_frame, process_sent_to): Now static.
386 (deactivate_process): Mark defn as static, as well as decl.
387 * lisp.h (create_process): Remove decl.
388 * process.h (chan_process, Vprocess_alist): Remove decls.
390 * print.c: Make symbols static if they're not exported.
391 (print_depth, new_backquote_output, being_printed, print_buffer):
392 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
393 (print_interval, print_number_index, initial_stderr_stream):
395 * lisp.h (Fprinc): Remove decl.
396 (debug_output_compilation_hack): Mark as externally visible.
398 * sysdep.c (croak): Move decl from here to syssignal.h.
399 * syssignal.h (croak): Put it here, so the API can be checked when
400 'croak' is called from dissociate_if_controlling_tty.
402 * minibuf.c: Make symbols static if they're not exported.
403 (minibuf_save_list, choose_minibuf_frame): Now static.
404 * lisp.h (choose_minibuf_frame): Remove decl.
406 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
408 * lread.c: Make symbols static if they're not exported.
409 (read_objects, initial_obarray, oblookup_last_bucket_number):
411 (make_symbol): Remove; unused.
412 * lisp.h (initial_obarray, make_symbol): Remove decls.
414 * keyboard.c: Make symbols static if they're not exported.
415 (single_kboard, recent_keys_index, total_keys, recent_keys):
416 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
417 (this_single_command_key_start, echoing, last_auto_save):
418 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
419 (command_loop, echo_now, keyboard_init_hook, help_char_p):
420 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
421 (Vlispy_mouse_stem, double_click_count):
423 (force_auto_save_soon): Define only if SIGDANGER.
424 (ignore_mouse_drag_p): Now static if
425 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
426 (print_help): Remove; unused.
427 (stop_character, last_timer_event): Mark as externally visible.
428 * keyboard.h (ignore_mouse_drag_p): Declare only if
429 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
430 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
431 * lisp.h (echoing): Remove decl.
432 (force_auto_save_soon): Declare only if SIGDANGER.
433 * xdisp.c (redisplay_window): Simplify code, to make it more
434 obvious that ignore_mouse_drag_p is not accessed if !defined
435 USE_GTK && !defined HAVE_NS.
437 * intervals.c: Make symbols static if they're not exported.
438 (merge_properties_sticky, merge_interval_right, delete_interval):
440 * intervals.h (merge_interval_right, delete_interval): Remove decls.
442 * insdel.c: Make symbols static if they're not exported.
443 However, leave prepare_to_modify_buffer alone. It's never
444 called from outside this function, but that appears to be a bug.
445 (combine_after_change_list, combine_after_change_buffer):
446 (adjust_after_replace, signal_before_change): Now static.
447 (adjust_after_replace_noundo): Remove; unused.
448 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
449 (signal_before_change): Remove decls.
451 * indent.c (val_compute_motion, val_vmotion): Now static.
453 * image.c: Make symbols static if they're not exported.
454 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
456 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
457 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
459 * fringe.c (standard_bitmaps): Now static.
460 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
462 * frame.c: Make symbols static if they're not exported.
463 (x_report_frame_params, make_terminal_frame): Now static.
464 (get_frame_param): Now static, unless HAVE_NS.
465 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
466 (x_get_resource_string): Remove; not used.
467 * frame.h (make_terminal_frame, x_report_frame_params):
468 (x_get_resource_string); Remove decls.
469 (x_fullscreen_adjust): Declare only if WINDOWSNT.
470 * lisp.h (get_frame_param): Declare only if HAVE_NS.
472 * font.c, fontset.c: Make symbols static if they're not exported.
473 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
474 (FACE_SUITABLE_FOR_CHAR_P): Use it.
475 * font.c (font_close_object): Now static.
476 * font.h (font_close_object): Remove.
477 * fontset.c (FONTSET_OBJLIST): Remove.
478 (free_realized_fontset) #if-0 the body, which does nothing.
479 (face_suitable_for_char_p): #if-0, as it's never called.
480 * fontset.h (face_suitable_for_char_p): Remove decl.
481 * xfaces.c (face_at_string_position): Use
482 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
483 since 0 is always ASCII.
485 * fns.c (weak_hash_tables): Now static.
487 * fileio.c: Make symbols static if they're not exported.
488 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
489 (Vwrite_region_annotation_buffers): Now static.
491 * eval.c: Make symbols static if they're not exported.
492 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
493 * lisp.h (backtrace_list): Remove decl.
495 * emacs.c: Make symbols static if they're not exported.
496 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
497 (fatal_error_code, fatal_error_signal_hook, standard_args):
499 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
500 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
501 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
502 * lisp.h (fatal_error_signal_hook): Remove decl.
503 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
505 * editfns.c: Move a (normally-unused) function to its only use.
506 * editfns.c, lisp.h (get_operating_system_release): Remove.
507 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
508 worth the hassle of breaking this out.
510 * xterm.c: Make symbols static if they're not exported.
511 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
512 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
513 (x_destroy_window, x_delete_display):
515 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
516 (x_mouse_leave): Remove; unused.
517 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
518 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
519 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
521 (x_mouse_leave): Declare only if WINDOWSNT.
522 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
523 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
526 * ftxfont.c: Make symbols static if they're not exported.
527 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
529 * font.h (ftxfont_driver): Likewise.
531 * xfns.c: Make symbols static if they're not exported.
532 (x_last_font_name, x_display_info_for_name):
533 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
534 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
535 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
536 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
537 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
538 (last_show_tip_args): Now static.
539 (xic_defaut_fontset, xic_create_fontsetname): Define only if
540 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
541 (x_screen_planes): Remove; unused.
542 * dispextern.h (x_screen_planes): Remove decl.
544 * dispnew.c: Make symbols static if they're not exported.
545 * dispextern.h (redraw_garbaged_frames, scrolling):
546 (increment_row_positions): Remove.
547 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
548 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
550 (redraw_garbaged_frames): Remove; unused.
552 * xfaces.c: Make symbols static if they're not exported.
553 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
555 * xterm.h (defined_color): Remove decls.
556 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
557 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
558 (menu_face_changed_default, defined_color, free_realized_face):
559 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
560 (ascii_face_of_lisp_face): Remove; unused.
562 * xdisp.c: Make symbols static if they're not exported.
563 * dispextern.h (scratch_glyph_row, window_box_edges):
564 (glyph_to_pixel_coords, set_cursor_from_row):
565 (get_next_display_element, set_iterator_to_next):
566 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
567 (show_mouse_face): Remove decls
568 * frame.h (message_buf_print): Likewise.
569 * lisp.h (pop_message, set_message, check_point_in_composition):
571 * xterm.h (set_vertical_scroll_bar): Likewise.
572 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
573 (message_buf_print, scratch_glyph_row, displayed_buffer):
574 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
575 (get_next_display_element, show_mouse_face, window_box_edges):
576 (frame_to_window_pixel_xy, check_point_in_composition):
577 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
578 (glyph_to_pixel_coords): Remove; unused.
580 * dired.c (file_name_completion): Now static.
582 * dbusbind.c (xd_in_read_queued_messages): Now static.
584 * lisp.h (circular_list_error, FOREACH): Remove; unused.
585 * data.c (circular_list_error): Remove.
587 * commands.h (last_point_position, last_point_position_buffer):
588 (last_point_position_window): Remove decls.
589 * keyboard.c: Make these variables static.
591 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
593 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
594 (iso_code_class, detect_coding, code_convert_region): Now static.
595 (encode_coding_gap): Remove; unused.
597 * chartab.c (chartab_chars, chartab_bits): Now static.
599 * charset.h (charset_iso_8859_1): Remove decl.
600 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
603 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
604 * ccl.c (Vccl_program_table): Now static.
605 (check_ccl_update): Remove; unused.
607 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
608 * category.h: ... from here.
609 * category.c (check_category_table, set_category_set): Now static.
611 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
612 * lisp.h: Remove these decls.
614 * buffer.c (buffer_count): Remove unused var.
616 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
617 so that it's not optimized away.
618 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
619 * dispextern.h (bidi_dump_cached_states): Remove, since it's
620 exported only to the debugger.
622 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
623 * atimer.h (run_all_atimers): Removed; not exported.
625 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
626 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
627 was inaccessible from Lisp.
628 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
629 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
631 alloc.c: Import and export fewer symbols, and remove unused items.
632 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
634 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
635 it's not optimized away by whole-program optimization.
636 (message_enable_multibyte, free_misc): Remove.
637 (catchlist, handlerlist, mark_backtrace):
638 Declare only if BYTE_MARK_STACK.
639 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
640 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
641 (message_enable_multibyte): Remove decl.
642 (free_misc, interval_free_list, float_block, float_block_index):
643 (n_float_blocks, float_free_list, cons_block, cons_block_index):
644 (cons_free_list, last_marked_index):
646 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
647 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
648 (mark_backtrace): Define only if BYTE_MARK_STACK.
649 * xdisp.c (message_enable_multibyte): Now static.
651 Declare Lisp_Object Q* variables to be 'static' if not exported.
652 This makes it easier for human readers (and static analyzers)
653 to see whether these variables are used from other modules.
654 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
655 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
656 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
657 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
658 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
659 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
660 * xmenu.c, xselect.c:
661 Declare Q* vars static if they are not used in other modules.
662 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
663 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
664 Remove decls of unexported vars.
665 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
667 * lisp.h (DEFINE_FUNC): Make sname 'static'.
669 Make Emacs functions such as Fatom 'static' by default.
670 This makes it easier for human readers (and static analyzers)
671 to see whether these functions can be called from other modules.
672 DEFUN now defines a static function. To make the function external
673 so that it can be used in other C modules, use the new macro DEFUE.
674 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
675 (Finit_image_library):
676 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
677 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
678 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
679 Remove decls, since these functions are now static.
680 (Funintern, Fget_internal_run_time): New decls, since these functions
681 were already external.
683 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
684 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
685 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
686 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
687 * keyboard.c, keymap.c, lread.c:
688 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
689 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
690 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
691 Mark functions with DEFUE instead of DEFUN,
692 if they are used in other modules.
693 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
694 decls for now-static functions.
695 * buffer.h (Fdelete_overlay): Remove decl.
696 * callproc.c (Fgetenv_internal): Mark as internal.
697 * composite.c (Fremove_list_of_text_properties): Remove decl.
698 (Fcomposition_get_gstring): New forward static decl.
699 * composite.h (Fcomposite_get_gstring): Remove decl.
700 * dired.c (Ffile_attributes): New forward static decl.
701 * doc.c (Fdocumntation_property): New forward static decl.
702 * eval.c (Ffetch_bytecode): New forward static decl.
703 (Funintern): Remove extern decl; now in .h file where it belongs.
704 * fileio.c (Fmake_symbolic_link): New forward static decl.
705 * image.c (Finit_image_library): New forward static decl.
706 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
707 * intervals.h (Fprevious_property_change):
708 (Fremove_list_of_text_properties): Remove decls.
709 * keyboard.c (Fthis_command_keys): Remove decl.
710 (Fcommand_execute): New forward static decl.
711 * keymap.c (Flookup_key): New forward static decl.
712 (Fcopy_keymap): Now static.
713 * keymap.h (Flookup_key): Remove decl.
714 * process.c (Fget_process): New forward static decl.
715 (Fprocess_datagram_address): Mark as internal.
716 * syntax.c (Fsyntax_table_p): New forward static decl.
717 (skip_chars): Remove duplicate decl.
718 * textprop.c (Fprevious_property_change): New forward static decl.
719 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
721 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
722 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
724 * editfns.c (Fformat): Remove unreachable code.
726 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
728 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
731 2011-04-13 Eli Zaretskii <eliz@gnu.org>
733 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
734 when at ZV. (Bug#8487)
736 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
738 * charset.c (Fclear_charset_maps): Use xfree instead of free.
740 * keyboard.c (parse_tool_bar_item): Likewise.
741 * sound.c (sound_cleanup, alsa_close): Likewise.
742 * termcap.c (tgetent): Likewise.
743 * xfns.c (x_default_font_parameter): Likewise.
744 * xsettings.c (read_and_apply_settings): Likewise.
746 * alloc.c (overrun_check_malloc, overrun_check_realloc)
747 (overrun_check_free): Protoize.
749 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
751 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
752 since callers should never pass a negative size.
753 Change the signature to match that of plain 'read' and 'write'; see
754 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
755 * lisp.h: Update prototypes of emacs_write and emacs_read.
757 2011-04-11 Eli Zaretskii <eliz@gnu.org>
759 * xdisp.c (redisplay_window): Don't try to determine the character
760 position of the scroll margin if the window start point w->startp
761 is outside the buffer's accessible region. (Bug#8468)
763 2011-04-10 Eli Zaretskii <eliz@gnu.org>
765 Fix write-region and its subroutines for buffers > 2GB.
766 * fileio.c (a_write, e_write): Modify declaration of arguments and
767 local variables to support buffers larger than 2GB.
768 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
770 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
771 argument, local variables, and return value.
773 * lisp.h: Update prototypes of emacs_write and emacs_read.
775 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
777 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
779 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
781 Fix more problems found by GCC 4.6.0's static checks.
783 * xdisp.c (vmessage): Use a better test for character truncation.
785 * charset.c (load_charset_map): <, not <=, for optimization,
786 and to avoid potential problems with integer overflow.
787 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
788 * casetab.c (set_identity, shuffle): Likewise.
789 * editfns.c (Fformat): Likewise.
790 * syntax.c (skip_chars): Likewise.
792 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
793 This also lets GCC 4.6.0 generate slightly better loop code.
795 * callint.c (Fcall_interactively): <, not <=, for optimization.
796 (Fcall_interactively): Count the number of arguments produced,
797 not the number of arguments given. This is simpler and lets GCC
798 4.6.0 generate slightly better code.
800 * ftfont.c: Distingish more carefully between FcChar8 and char.
801 The previous code passed unsigned char * to a functions like
802 strlen and xstrcasecmp that expect char *, which does not
803 conform to the C standard.
804 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
805 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
806 char * when the C standard requires it.
808 * keyboard.c (read_char): Remove unused var.
810 * eval.c: Port to Windows vsnprintf (Bug#8435).
812 (SIZE_MAX): Define if the headers do not.
813 (verror): Do not give up if vsnprintf returns a negative count.
814 Instead, grow the buffer. This ports to Windows vsnprintf, which
815 does not conform to C99. Problem reported by Eli Zaretskii.
816 Also, simplify the allocation scheme, by avoiding the need for
817 calling realloc, and removing the ALLOCATED variable.
819 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
821 Remove invocations of doprnt, as Emacs now uses vsnprintf.
822 But keep the doprint source code for now, as we might revamp it
823 and use it again (Bug#8435).
824 * lisp.h (doprnt): Remove.
825 * Makefile.in (base_obj): Remove doprnt.o.
826 * deps.mk (doprnt.o): Remove.
828 error: Print 32- and 64-bit integers portably (Bug#8435).
829 Without this change, on typical 64-bit hosts error ("...%d...", N)
830 was used to print both 32- and 64-bit integers N, which relied on
832 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
834 * lisp.h (error, verror): Mark as printf-like functions.
835 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
836 Report overflow in size calculations when allocating printf buffer.
837 Do not truncate output string at its first null byte.
838 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
839 Truncate the output at a character boundary, since vsnprintf does not
841 * charset.c (check_iso_charset_parameter): Convert internal
842 character to string before calling 'error', since %c now has the
844 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
845 overflow when computing char to be passed to 'error'. Do not
846 pass Lisp_Object to 'error'; pass the integer instead.
847 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
848 formatted with plain %d.
850 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
852 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
854 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
856 * xterm.c (x_catch_errors): Remove duplicate declaration.
858 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
860 * xdisp.c, lisp.h (message_nolog): Remove; unused.
862 2011-04-10 Jim Meyering <meyering@redhat.com>
864 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
865 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
866 return ssize_t not "int", and use size_t as the buffer length.
867 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
868 * gnutls.h: Update declarations.
869 * process.c (read_process_output): Use ssize_t, to match.
870 (send_process): Likewise.
872 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
874 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
876 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
878 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
879 unsigned char, to match FcChar8 type definition.
881 * xterm.c (handle_one_xevent):
882 * xmenu.c (create_and_show_popup_menu):
883 * xselect.c (x_decline_selection_request)
884 (x_reply_selection_request): Avoid type-punned deref of X events.
886 2011-04-09 Eli Zaretskii <eliz@gnu.org>
888 Fix some uses of `int' instead of EMACS_INT.
889 * search.c (string_match_1, fast_string_match)
890 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
891 (scan_buffer, find_next_newline_no_quit)
892 (find_before_next_newline, search_command, Freplace_match)
893 (Fmatch_data): Make some `int' variables be EMACS_INT.
895 * xdisp.c (display_count_lines): 3rd argument and return value now
896 EMACS_INT. All callers changed.
897 (pint2hrstr): Last argument is now EMACS_INT.
899 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
900 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
901 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
902 (decode_coding_utf_16, decode_coding_emacs_mule)
903 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
904 (decode_coding_ccl, decode_coding_charset)
905 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
906 (decode_coding_iso_2022, decode_coding_emacs_mule)
907 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
908 <char_offset, last_offset>: Declare EMACS_INT.
909 (encode_coding_utf_8, encode_coding_utf_16)
910 (encode_coding_emacs_mule, encode_invocation_designation)
911 (encode_designation_at_bol, encode_coding_iso_2022)
912 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
913 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
915 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
916 (encode_invocation_designation): Last argument P_NCHARS is now
918 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
919 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
921 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
924 * ccl.c (Fccl_execute_on_string): Declare some variables
927 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
929 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
931 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
933 * process.c (Fformat_network_address): Doc fix.
935 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
937 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
939 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
941 * keyboard.c (read_char): Call Lisp function help-form-show,
942 instead of using internal_with_output_to_temp_buffer.
943 (Qhelp_form_show): New var.
944 (syms_of_keyboard): Use DEFSYM macro.
946 * print.c (internal_with_output_to_temp_buffer): Function deleted.
948 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
950 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
952 * process.c (Flist_processes): Removed to Lisp.
953 (list_processes_1): Deleted.
955 2011-04-06 Eli Zaretskii <eliz@gnu.org>
957 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
959 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
961 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
963 Fix more problems found by GCC 4.6.0's static checks.
965 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
967 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
969 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
971 * xdisp.c (vmessage): Mark as a printf-like function.
973 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
975 * sound.c (sound_warning): Don't crash if arg contains a printf format.
977 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
978 printf-like functions.
979 (tiff_load): Add casts to remove these marks before passing them
980 to system-supplied API.
982 * eval.c (Fsignal): Remove excess argument to 'fatal'.
984 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
985 This avoids several warnings with gcc -Wstrict-overflow.
986 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
987 directly, rather than having caller test rule sign. This avoids
988 some unnecessary tests.
989 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
990 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
991 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
993 * xfont.c (xfont_text_extents): Remove var that was set but not used.
994 (xfont_open): Avoid unnecessary tests.
996 * composite.c (composition_gstring_put_cache): Use unsigned integer.
998 * composite.h, composite.c (composition_gstring_put_cache):
999 Use EMACS_INT, not int, for length.
1001 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1002 breaking out part of COMPOSITION_DECODE_RULE.
1003 (COMPOSITION_DECODE_RULE): Use it.
1004 * composite.c (get_composition_id): Remove unused local vars,
1005 by using the new macro.
1007 * textprop.c (set_text_properties_1): Change while to do-while,
1008 since the condition is always true at first.
1010 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1011 (interval_deletion_adjustment): Return unsigned value.
1014 * process.c (list_processes_1, create_pty, read_process_output):
1015 (exec_sentinel): Remove vars that were set but not used.
1016 (create_pty): Remove unnecessary "volatile"s.
1017 (Fnetwork_interface_info): Avoid possibility of int overflow.
1018 (read_process_output): Do adaptive read buffering even if carryover.
1019 (read_process_output): Simplify nbytes computation if buffered.
1021 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1023 * syntax.c (scan_words): Remove var that was set but not used.
1024 (update_syntax_table): Use unsigned instead of int.
1026 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1027 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1028 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1030 * print.c (print_error_message): Avoid int overflow.
1032 * font.c (font_list_entities): Redo for clarity,
1033 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1035 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1036 (font_score): Avoid potential overflow in diff calculation.
1038 * fns.c (substring_both): Remove var that is set but not used.
1039 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1041 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1043 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1044 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1045 can always succeed if overflow has undefined behavior.
1047 * search.c (boyer_moore, wordify): Remove vars set but not used.
1048 (wordify): Omit three unnecessary tests.
1050 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1051 All callers changed. This avoids the need for an unused var.
1053 * casefiddle.c (casify_region): Remove var that is set but not used.
1055 * dired.c (file_name_completion): Remove var that is set but not used.
1057 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1059 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1060 (Finsert_file_contents): Remove unnecessary code checking fd.
1062 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1063 Check for integer overflow on size calculations.
1065 * buffer.c (Fprevious_overlay_change): Remove var that is set
1068 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1069 Remove vars that are set but not used.
1070 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1071 (timer_check_2): Mark vars as initialized.
1073 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1075 * image.c (lookup_image): Remove var that is set but not used.
1076 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1078 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1079 that are set but not used.
1081 * xfns.c (make_invisible_cursor): Don't return garbage
1082 if XCreateBitmapFromData fails (Bug#8410).
1084 * xselect.c (x_get_local_selection, x_handle_property_notify):
1085 Remove vars that are set but not used.
1087 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1088 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1090 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1091 Remove var that is set but not used.
1092 (scroll_bar_windows_size): Now size_t, not int.
1093 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1096 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1097 (map_tty_color) [!defined MSDOS]: Likewise.
1099 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1101 * coding.c: Remove vars that are set but not used.
1102 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1103 All callers changed.
1104 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1105 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1106 (decode_coding_charset): Remove vars that are set but not used.
1108 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1109 that is set but not used.
1111 * print.c (print_object): Remove var that is set but not used.
1113 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1114 The gnulib version avoids calling malloc in the usual case,
1115 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1116 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1117 * filelock.c (current_lock_owner): Likewise.
1118 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1119 * sysdep.c: Include allocator.h, careadlinkat.h.
1120 (emacs_no_realloc_allocator): New static constant.
1121 (emacs_readlink): New function.
1122 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1123 ../lib/careadlinkat.h.
1125 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1127 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1128 first non-nil return value).
1130 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1132 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1133 if not defined (Bug#8403).
1135 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1137 * xdisp.c (display_count_lines): Remove parameter `start',
1138 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1139 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1140 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1141 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1142 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1143 and thereabouts. All callers changed.
1144 (get_per_char_metric): Remove parameter `f', unused since
1145 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1147 2011-04-02 Jim Meyering <meyering@redhat.com>
1149 do not dereference NULL upon failed strdup
1150 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1151 (ns_get_family): Likewise.
1153 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1155 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1157 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1159 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1162 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1164 Add lexical binding.
1166 * window.c (Ftemp_output_buffer_show): New fun.
1167 (Fsave_window_excursion):
1168 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1170 * lread.c (lisp_file_lexically_bound_p): New function.
1171 (Fload): Bind Qlexical_binding.
1172 (readevalloop): Remove `evalfun' arg.
1173 Bind Qinternal_interpreter_environment.
1174 (Feval_buffer): Bind Qlexical_binding.
1175 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1177 (syms_of_lread): Declare `lexical-binding'.
1179 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1181 * keyboard.c (eval_dyn): New fun.
1182 (menu_item_eval_property): Use it.
1184 * image.c (parse_image_spec): Use Ffunctionp.
1186 * fns.c (concat, mapcar1): Accept byte-code-functions.
1188 * eval.c (Fsetq): Handle lexical vars.
1189 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1190 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1191 (FletX, Flet): Obey lexical binding.
1192 (Fcommandp): Handle closures.
1193 (Feval): New `lexical' arg.
1194 (eval_sub): New function extracted from Feval. Use it almost
1195 everywhere where Feval was used. Look up vars in lexical env.
1197 (Ffunctionp): Move from subr.el.
1198 (Ffuncall): Handle closures.
1199 (apply_lambda): Remove `eval_flags'.
1200 (funcall_lambda): Handle closures and new byte-code-functions.
1201 (Fspecial_variable_p): New function.
1202 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1203 but without exporting it to Lisp.
1205 * doc.c (Fdocumentation, store_function_docstring):
1206 * data.c (Finteractive_form): Handle closures.
1208 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1211 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1213 (exec_byte_code): New function extracted from Fbyte_code to handle new
1214 calling convention for byte-code-functions. Add new byte-codes.
1216 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1218 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1220 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1222 * xdisp.c (redisplay_internal): Fix prototype.
1224 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1226 * xdisp.c (SCROLL_LIMIT): New macro.
1227 (try_scrolling): Use it when setting scroll_limit. Limit
1228 scrolling to 100 screen lines.
1229 (redisplay_window): Even when falling back on "recentering",
1230 position point in the window according to scroll-conservatively,
1231 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1233 (try_scrolling): When point is above the window, allow searching
1234 as far as scroll_max, or one screenful, to compute vertical
1235 distance from PT to the scroll margin position. This prevents
1236 try_scrolling from unnecessarily failing when
1237 scroll-conservatively is set to a value slightly larger than the
1238 window height. Clean up the case of PT below the margin at bottom
1239 of window: scroll_max can no longer be INT_MAX. When aggressive
1240 scrolling is in use, don't let point enter the opposite scroll
1241 margin as result of the scroll.
1242 (syms_of_xdisp) <scroll-conservatively>: Document the
1243 threshold of 100 lines for never-recentering scrolling.
1245 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1247 * dispextern.h (move_it_by_lines):
1248 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1249 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1250 (message_log_check_duplicate): Remove parameters `prev_bol' and
1251 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1252 (redisplay_internal): Remove parameter `preserve_echo_area',
1253 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1255 * indent.c (Fvertical_motion):
1256 * window.c (window_scroll_pixel_based, Frecenter):
1257 Don't pass `need_y_p' to `move_it_by_lines'.
1259 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1261 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1262 steal a few bits to be more compact.
1263 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1264 Remove unneeded casts.
1266 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1268 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1270 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1271 binding" message (bug#7967).
1273 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1275 Fix more problems found by GCC 4.6.0's static checks.
1277 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1278 Remove unused local var.
1280 * editfns.c (Fmessage_box): Remove unused local var.
1282 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1283 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1284 Omit unused local vars.
1285 * window.c (shrink_windows): Omit unused local var.
1286 * menu.c (digest_single_submenu): Omit unused local var.
1287 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1288 Omit unused local var.
1290 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1291 Don't assume string length fits in int.
1292 (keyremap_step, read_key_sequence): Use size_t for sizes.
1293 (read_key_sequence): Don't check last_real_key_start redundantly.
1295 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1296 instead of alloca (Bug#8344).
1298 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1299 (Fbacktrace_frame): Don't assume nframes fits in int.
1301 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1303 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1306 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1308 * cm.c (calccost): Turn while-do into do-while, for clarity.
1310 * keyboard.c (syms_of_keyboard): Use the same style as later
1311 in this function when indexing through an array. This also
1312 works around GCC bug 48267.
1314 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1316 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1318 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1319 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1321 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1322 This avoids undefined behavior on integer overflow, and is a bit
1323 more convenient anyway since it is compared to a size_t variable.
1325 Variadic C functions now count arguments with size_t, not int.
1326 This avoids an unnecessary limitation on 64-bit machines, which
1327 caused (substring ...) to crash on large vectors (Bug#8344).
1328 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1329 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1330 All variadic functions and their callers changed accordingly.
1331 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1332 * data.c (arith_driver, float_arith_driver): Likewise.
1333 * editfns.c (general_insert_function): Likewise.
1334 * eval.c (struct backtrace.nargs, interactive_p)
1335 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1336 (funcall_lambda, mark_backtrace): Likewise.
1337 * fns.c (concat): Likewise.
1338 * frame.c (x_set_frame_parameters): Likewise.
1339 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1340 0 if not found, not -1. All callers changed.
1342 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1343 (stack_copy_size): Now size_t, not int.
1344 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1346 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1348 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1349 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1350 All callers changed.
1352 * lisp.h (multibyte_char_to_unibyte):
1353 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1354 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1355 * character.h (CHAR_TO_BYTE8):
1356 * cmds.c (internal_self_insert):
1357 * editfns.c (general_insert_function):
1358 * keymap.c (push_key_description):
1359 * search.c (Freplace_match):
1360 * xdisp.c (message_dolog, set_message_1): All callers changed.
1362 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1364 * keyboard.c (safe_run_hook_funcall): New function.
1365 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1366 don't set the hook to nil, but remove the offending function instead.
1367 (Qcommand_hook_internal): Remove, unused.
1368 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1369 Vcommand_hook_internal.
1371 * eval.c (enum run_hooks_condition): Remove.
1372 (funcall_nil, funcall_not): New functions.
1373 (run_hook_with_args): Call each function through a `funcall' argument.
1374 Remove `cond' argument, now redundant.
1375 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1376 (Frun_hook_with_args_until_failure): Adjust accordingly.
1377 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1379 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1381 * dispextern.h (string_buffer_position): Remove declaration.
1383 * print.c (strout): Remove parameter `multibyte', unused since
1384 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1386 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1387 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1388 All callers changed.
1390 * w32.c (_wsa_errlist): Use braces for struct initializers.
1392 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1393 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1394 All callers changed.
1395 (string_buffer_position): Likewise. Also, make static (it's never
1396 used outside xdisp.c).
1397 (cursor_row_p): Remove parameter `w', unused since
1398 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1399 (decode_mode_spec): Remove parameter `precision', introduced during
1400 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1401 All callers changed.
1403 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1405 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1407 2011-03-27 Anders Lindgren <andlind@gmail.com>
1409 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1410 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1411 (ns_update_auto_hide_menu_bar): New functions.
1412 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1413 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1414 ns_constrain_all_frames.
1415 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1416 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1418 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1420 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1422 2011-03-27 Glenn Morris <rgm@gnu.org>
1424 * syssignal.h: Replace RETSIGTYPE with void.
1425 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1426 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1427 Replace SIGTYPE with void everywhere.
1428 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1429 * s/template.h (SIGTYPE): Remove commented out definition.
1431 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1433 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1434 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1436 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1438 * w32.c (read_unc_volume): Use parameter `henum', instead of
1439 global variable `wget_enum_handle'.
1441 * keymap.c (describe_vector): Remove parameters `indices' and
1442 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1443 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1445 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1447 * keyboard.c (timer_check): Remove parameter `do_it_now',
1448 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1449 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1450 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1452 * keyboard.c (read_char):
1453 * w32menu.c (w32_menu_display_help):
1454 * xmenu.c (show_help_event, menu_help_callback):
1455 Adjust calls to `show_help_echo'.
1457 * gtkutil.c (xg_maybe_add_timer):
1458 * keyboard.c (readable_events):
1459 * process.c (wait_reading_process_output):
1460 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1462 * insdel.c (adjust_markers_gap_motion):
1463 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1464 (gap_left, gap_right): Don't call it.
1466 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1468 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1469 incurred during fontification.
1471 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1473 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1474 (DEFVAR_PER_BUFFER): Don't pass it.
1476 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1477 (scrolling_window): Don't pass it.
1479 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1481 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1483 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1485 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1486 of variables specific to SELinux and computation of `encoded_absname'.
1488 * image.c (XPutPixel): Remove unused variable `height'.
1490 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1492 * unexw32.c (get_section_info): Remove unused variable `section'.
1494 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1495 (system_process_attributes): Remove unused variable `sess'.
1496 (sys_read): Remove unused variable `err'.
1498 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1499 (w32_wnd_proc): Remove unused variable `isdead'.
1500 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1501 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1502 (x_create_tip_frame): Remove unused variable `tem'.
1504 * w32inevt.c (w32_console_read_socket):
1505 Remove unused variable `no_events'.
1507 * w32term.c (x_draw_composite_glyph_string_foreground):
1508 Remove unused variable `width'.
1510 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
1512 * w32term.c (x_set_glyph_string_clipping):
1513 Don't pass uninitialized region to CombineRgn.
1515 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
1517 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1518 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1519 (Fx_close_connection): Remove unused variable `i'.
1521 * w32font.c (w32font_draw): Return number of glyphs.
1522 (w32font_open_internal): Remove unused variable `i'.
1523 (w32font_driver): Add missing initializer.
1525 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1526 (fill_in_menu): Remove unused variable `items_added'.
1528 * w32term.c (last_mouse_press_frame): Remove static global variable.
1529 (w32_clip_to_row): Remove unused variable `f'.
1530 (x_delete_terminal): Remove unused variable `i'.
1532 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1533 (NOTHING): Remove unused static global variable.
1534 (uniscribe_check_otf): Remove unused variable `table'.
1535 (uniscribe_font_driver): Add missing initializers.
1537 2011-03-23 Julien Danjou <julien@danjou.info>
1539 * term.c (Fsuspend_tty, Fresume_tty):
1540 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1541 * window.c (temp_output_buffer_show):
1542 * insdel.c (signal_before_change):
1543 * frame.c (Fhandle_switch_frame):
1544 * fileio.c (Fdo_auto_save):
1545 * emacs.c (Fkill_emacs):
1546 * editfns.c (save_excursion_restore):
1547 * cmds.c (internal_self_insert):
1548 * callint.c (Fcall_interactively):
1549 * buffer.c (Fkill_all_local_variables):
1550 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1552 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
1553 unconditionnaly since it does the check itself.
1555 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
1557 Fix more problems found by GCC 4.5.2's static checks.
1559 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1560 the first time through the loop, since we know p0 < p1 then.
1561 This also avoids a gcc -Wstrict-overflow warning.
1563 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1564 leading to a memory leak, possible in functions like
1565 load_charset_map_from_file that can allocate an unbounded number
1566 of objects (Bug#8318).
1568 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1569 that could (at least in theory) be that large.
1571 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1572 This is less likely to overflow, and avoids undefined behavior if
1573 overflow does occur. All callers changed. Use strtoul to scan
1574 for the unsigned long integer.
1575 (pint2hrstr): Simplify and tune code slightly.
1576 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1578 * scroll.c (do_scrolling): Work around GCC bug 48228.
1579 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1581 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1582 This also avoids a warning with gcc -Wstrict-overflow.
1583 (validate_x_resource_name): Simplify count usage.
1584 This also avoids a warning with gcc -Wstrict-overflow.
1586 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1589 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1591 * process.c (Fmake_network_process): Use socklen_t, not int,
1592 where POSIX says socklen_t is required in portable programs.
1593 This fixes a porting bug on hosts like 64-bit HP-UX, where
1594 socklen_t is wider than int (Bug#8277).
1595 (Fmake_network_process, server_accept_connection):
1596 (wait_reading_process_output, read_process_output):
1599 * process.c: Rename or move locals to avoid shadowing.
1600 (list_processes_1, Fmake_network_process):
1601 (read_process_output_error_handler, exec_sentinel_error_handler):
1602 Rename or move locals.
1603 (Fmake_network_process): Define label "retry_connect" only if needed.
1604 (Fnetwork_interface_info): Fix pointer signedness.
1605 (process_send_signal): Add cast to avoid pointer signedness problem.
1606 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
1607 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
1609 Make tparam.h and terminfo.c consistent.
1610 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1611 Include tparam.h instead, since it declares them.
1612 * cm.h (PC): Remove extern decl; tparam.h now does this.
1613 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1614 * terminfo.c: Include tparam.h, to check interfaces.
1615 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1616 (tparam): Adjust signature to match interface in tparam.h;
1617 this removes some undefined behavior. Check that outstring and len
1618 are zero, which they always are with Emacs.
1619 * tparam.h (PC, BC, UP): New extern decls.
1621 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
1622 (xftfont_open): Rename locals to avoid shadowing.
1624 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
1625 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1626 (OTF_TAG_SYM): Omit macro if not needed.
1627 (ftfont_list): Remove unused local.
1628 (get_adstyle_property, ftfont_pattern_entity):
1629 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1630 Rename locals to avoid shadowing.
1632 * xfont.c (xfont_list_family): Mark var as initialized.
1634 * xml.c (make_dom): Now static.
1636 * composite.c (composition_compute_stop_pos): Rename local to
1638 (composition_reseat_it): Remove unused locals.
1639 (find_automatic_composition, composition_adjust_point): Likewise.
1640 (composition_update_it): Mark var as initialized.
1641 (find_automatic_composition): Mark vars as initialized,
1642 with a FIXME (Bug#8290).
1644 character.h: Rename locals to avoid shadowing.
1645 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1646 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1647 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1648 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1651 * textprop.c (property_change_between_p): Remove; unused.
1653 * intervals.c (interval_start_pos): Now static.
1655 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1657 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1658 Rename locals to avoid shadowing.
1660 * sound.c (wav_play, au_play, Fplay_sound_internal):
1661 Fix pointer signedness.
1662 (alsa_choose_format): Remove unused local var.
1663 (wav_play): Initialize a variable to 0, to prevent undefined
1664 behavior (Bug#8278).
1666 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1668 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1670 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1671 clobbering (Bug#8298).
1672 * sysdep.c (sys_subshell): Likewise.
1673 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
1675 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1676 This should get cleaned up, so that child_setup has the
1677 same signature on all platforms.
1679 * callproc.c (call_process_cleanup): Now static.
1680 (relocate_fd): Rename locals to avoid shadowing.
1682 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
1684 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1685 not to be necessary, and produces flickering.
1687 2011-03-20 Glenn Morris <rgm@gnu.org>
1689 * config.in: Remove file.
1691 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
1693 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1694 are now in src/globals.h.
1695 (syms_of_minibuf): Remove spurious & from previous change.
1697 2011-03-20 Leo <sdl.web@gmail.com>
1699 * minibuf.c (completing-read-function): New variable.
1700 (completing-read-default): Rename from completing-read.
1701 (completing-read): Call completing-read-function.
1703 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1705 * xfaces.c (Fx_load_color_file):
1706 Read color file from absolute filename (bug#8250).
1708 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1710 * makefile.w32-in: Update dependencies.
1712 2011-03-17 Eli Zaretskii <eliz@gnu.org>
1714 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1716 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1718 Fix more problems found by GCC 4.5.2's static checks.
1720 * process.c (make_serial_process_unwind, send_process_trap):
1721 (sigchld_handler): Now static.
1723 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1724 That way, the code declares only the vars that it needs.
1725 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1726 * s/cygwin.h (PTY_ITERATION): Likewise.
1727 * s/darwin.h (PTY_ITERATION): Likewise.
1728 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1730 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1731 * process.c (allocate_pty): Don't declare stb unless it's needed.
1733 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
1734 (CONSTANTLIM): Remove; unused.
1735 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1736 Define only if needed.
1738 * unexelf.c (unexec): Name an expression,
1739 to avoid gcc -Wbad-function-cast warning.
1740 Use a different way to cause a compilation error if anyone uses
1741 n rather than nn, a way that does not involve shadowing.
1742 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
1744 * deps.mk (unexalpha.o): Remove; unused.
1746 New file unexec.h, the (simple) interface for unexec (Bug#8267).
1747 * unexec.h: New file.
1748 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1749 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1751 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1752 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1753 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
1754 Change as necessary to match prototype in unexec.h.
1756 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1758 (back_comment, skip_chars): Mark vars as initialized.
1760 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1761 Rename locals to avoid shadowing.
1763 * lread.c (read1): Rewrite so as not to use empty "else".
1764 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
1766 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1768 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1769 warning when compiling print.c.
1771 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1772 instead of using an uninitialized var.
1773 (font_sort_entities): Mark var as initialized.
1775 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1777 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1778 pointers to constants.
1779 (font_parse_fcname): Remove unused vars.
1780 (font_delete_unmatched): Now static.
1781 (font_get_spec): Remove; unused.
1782 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1783 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1784 Rename or move locals to avoid shadowing.
1786 * fns.c (require_nesting_list, require_unwind): Now static.
1787 (Ffillarray): Rename locals to avoid shadowing.
1789 * floatfns.c (domain_error2): Define only if needed.
1790 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1792 * alloc.c (mark_backtrace): Move decl from here ...
1793 * lisp.h: ... to here, so that it can be checked.
1795 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
1796 (Fdefvar): Rewrite so as not to use empty "else".
1797 (lisp_indirect_variable): Name an expression,
1798 to avoid gcc -Wbad-function-cast warning.
1799 (Fdefvar): Rename locals to avoid shadowing.
1801 * callint.c (quotify_arg, quotify_args): Now static.
1802 (Fcall_interactively): Rename locals to avoid shadowing.
1803 Use const pointer when appropriate.
1805 * lisp.h (get_system_name, get_operating_system_release):
1806 Move decls here, to check interfaces.
1807 * process.c (get_operating_system_release): Move decl to lisp.h.
1808 * xrdb.c (get_system_name): Likewise.
1809 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1810 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1811 some of which prompt warnings from gcc -Wbad-function-cast.
1812 (Fformat_time_string, Fencode_time, Finsert_char):
1813 (Ftranslate_region_internal, Fformat):
1814 Rename or remove local vars to avoid shadowing.
1815 (Ftranslate_region_internal): Mark var as initialized.
1817 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1820 * lisp.h (eassert): Check that the argument compiles, even if
1821 ENABLE_CHECKING is not defined.
1823 * data.c (Findirect_variable): Name an expression, to avoid
1824 gcc -Wbad-function-cast warning.
1825 (default_value, arithcompare, arith_driver, arith_error): Now static.
1826 (store_symval_forwarding): Rename local to avoid shadowing.
1827 (Fmake_variable_buffer_local, Fmake_local_variable):
1828 Mark variables as initialized.
1829 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
1831 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
1832 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1833 Rename locals to avoid shadowing.
1834 (mark_stack): Move local variables into the #ifdef region where
1836 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1837 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1839 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1840 (GC_STRING_CHARS): Remove; not used.
1841 (Fmemory_limit): Cast sbrk's returned value to char *.
1843 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1844 avoids undefined behavior in theory.
1846 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1848 Use functions, not macros, for up- and down-casing (Bug#8254).
1849 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1850 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1851 to use the following functions instead of these macros.
1852 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1853 EMACS_INT, since callers assume the returned value fits in int.
1854 (upcase1): Likewise, for UPCASE_TABLE.
1855 (uppercasep, lowercasep, upcase): New static inline functions.
1856 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
1857 the race-condition problem in the old DOWNCASE.
1859 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1860 Rename locals to avoid shadowing.
1861 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
1862 (regex_compile, re_search_2, re_match_2_internal):
1863 Remove unused local vars.
1864 (FREE_VAR): Rewrite so as not to use empty "else",
1865 which gcc can warn about.
1866 (regex_compile, re_match_2_internal): Mark locals as initialized.
1867 (RETALLOC_IF): Define only if needed.
1868 (WORDCHAR_P): Likewise. This one is never needed, but is used
1869 only in a comment talking about a compiler bug, so put inside
1870 the #if 0 of that comment.
1871 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1872 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1875 * search.c (boyer_moore): Rename locals to avoid shadowing.
1876 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1877 (PREV_CHAR_BOUNDARY): Likewise.
1879 * search.c (simple_search): Remove unused var.
1881 * dired.c (compile_pattern): Move decl from here ...
1882 * lisp.h: ... to here, so that it can be checked.
1883 (struct re_registers): New forward decl.
1885 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1887 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1889 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1890 Rename locals to avoid shadowing.
1891 (Fvertical_motion): Mark locals as initialized.
1893 * casefiddle.c (casify_object, casify_region): Now static.
1894 (casify_region): Mark local as initialized.
1896 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1898 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1899 New macros, so that the caller can use some names other than
1900 gcpro1, gcpro2, etc.
1901 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1903 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1904 argument, for consistency with GCPRO2_VAR, etc: it is now the
1905 prefix of the variable, not the variable itself. All uses
1907 * dired.c (directory_files_internal, file_name_completion):
1908 Rename locals to avoid shadowing.
1910 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1911 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1912 dired.c's scmp function, had undefined behavior.
1913 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1914 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1915 * buffer.h: ... to here, because these macros use current_buffer,
1916 and the new implementation with inline functions needs to have
1917 current_buffer in scope now, rather than later when the macros
1919 (downcase, upcase1): New static inline functions.
1920 (DOWNCASE, UPCASE1): Reimplement using these functions.
1921 This avoids undefined behavior in expressions like
1922 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1923 from race conditions in accessing the global variables
1924 case_temp1 and case_temp2.
1925 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1926 * lisp.h (case_temp1, case_temp2): Remove their decls.
1927 * character.h (ASCII_CHAR_P): Move from here ...
1928 * lisp.h: ... to here, so that the inline functions mentioned
1931 * dired.c (directory_files_internal_unwind): Now static.
1933 * fileio.c (file_name_as_directory, directory_file_name):
1934 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1936 (file_name_as_directory): Use const pointers when appropriate.
1937 (Fexpand_file_name): Likewise. In particular, newdir might
1938 point at constant storage, so make it a const pointer.
1939 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
1940 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1942 (Fset_file_times, Finsert_file_contents, auto_save_error):
1943 Rename locals to avoid shadowing.
1945 * minibuf.c (choose_minibuf_frame_1): Now static.
1946 (Ftry_completion, Fall_completions): Rename or remove locals
1949 * marker.c (bytepos_to_charpos): Remove; unused.
1951 * lisp.h (verify_bytepos, count_markers): New decls,
1952 so that gcc does not warn that these functions aren't declared.
1954 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1955 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
1956 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
1957 (copy_text): Remove unused local var.
1959 * filelock.c (within_one_second): Now static.
1960 (lock_file_1): Rename local to avoid shadowing.
1962 * buffer.c (fix_overlays_before): Mark locals as initialized.
1963 (fix_start_end_in_overlays): Likewise. This function should be
1964 simplified by using pointers-to-pointers, but that's a different
1966 (switch_to_buffer_1): Now static.
1967 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1968 (report_overlay_modification): Rename locals to avoid shadowing.
1970 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
1971 Fix pointer signedness issue.
1972 (sys_subshell): Mark local as volatile if checking for lint,
1973 to suppress a gcc -Wclobbered warning that does not seem to be right.
1974 (MAXPATHLEN): Define only if needed.
1976 * process.c (serial_open, serial_configure): Move decls from here ...
1977 * systty.h: ... to here, so that they can be checked.
1979 * fns.c (get_random, seed_random): Move extern decls from here ...
1980 * lisp.h: ... to here, so that they can be checked.
1982 * sysdep.c (reset_io): Now static.
1983 (wait_for_termination_signal): Remove; unused.
1985 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1986 (copy_keymap_item, append_key, push_text_char_description):
1988 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
1989 (DENSE_TABLE_SIZE): Remove; unused.
1990 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1991 (describe_map_tree):
1992 Rename locals to avoid shadowing.
1994 * keyboard.c: Declare functions static if they are not used elsewhere.
1995 (echo_char, echo_dash, cmd_error, top_level_2):
1996 (poll_for_input, handle_async_input): Now static.
1997 (read_char, kbd_buffer_get_event, make_lispy_position):
1998 (make_lispy_event, make_lispy_movement, apply_modifiers):
1999 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2000 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2001 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2002 (read_key_sequence, read_char): Mark locals as initialized.
2003 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2005 * keyboard.h (make_ctrl_char): New decl.
2006 (mark_kboards): Move decl here ...
2007 * alloc.c (mark_kboards): ... from here.
2009 * lisp.h (force_auto_save_soon): New decl.
2011 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2012 (DEFINE_DUMMY_FUNCTION): New macro.
2013 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2015 (main): Add casts to avoid warnings
2016 if GCC considers string literals to be constants.
2018 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2020 * dbusbind.c: Pointer signedness fixes.
2021 (xd_signature, xd_append_arg, xd_initialize):
2022 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2023 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2024 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2025 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2027 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2028 if GCC considers string literals to be constants.
2029 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2031 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2033 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2034 (print_preprocess, print_object): New macro to fix last change.
2036 * print.c (print_preprocess): Don't forget font objects.
2038 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2040 * emacs.c (USAGE3): Doc fixes.
2042 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2044 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2047 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2049 * lisp.h (VWindow_system, Qfile_name_history):
2050 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2051 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2052 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2054 * w32select.c: Don't #include "keyboard.h".
2055 (run_protected): Add extern declaration for waiting_for_input.
2057 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2058 * w32console.c (detect_input_pending, read_input_pending)
2059 (encode_terminal_code):
2060 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2061 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2062 (w32_system_caret_y, Qfile_name_history):
2063 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2064 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2065 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2066 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2067 * w32proc.c (Qlocal, report_file_error):
2068 * w32term.c (Vwindow_system, updating_frame):
2069 * w32uniscribe.c (initialized, uniscribe_font_driver):
2070 Remove unneeded extern declarations.
2072 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2074 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2076 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2078 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2079 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2080 These macros can no longer be used for assignment.
2082 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2083 Assign struct members directly, instead of using BUF_BEGV etc.
2084 (record_buffer_markers, fetch_buffer_markers): New functions for
2085 recording and fetching special buffer markers.
2086 (set_buffer_internal_1, set_buffer_temp): Use them.
2088 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2090 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2092 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2093 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2095 * xdisp.c (hscroll_window_tree):
2096 (reconsider_clip_changes): Use PT instead of BUF_PT.
2098 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2100 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2101 $(EMACS_ROOT)/lib/intprops.h.
2103 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2105 Fix more problems found by GCC 4.5.2's static checks.
2107 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2108 to unsigned char * to avoid compiler diagnostic.
2109 (xg_free_frame_widgets): Make it clear that a local variable is
2110 needed only if USE_GTK_TOOLTIP.
2111 (gdk_window_get_screen): Make it clear that this macro is needed
2112 only if USE_GTK_TOOLTIP.
2113 (int_gtk_range_get_value): New function, which avoids a diagnostic
2114 from gcc -Wbad-function-cast.
2115 (xg_set_toolkit_scroll_bar_thumb): Use it.
2116 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2117 diagnostic from gcc -Wbad-function-cast.
2118 (get_utf8_string, xg_get_file_with_chooser):
2119 Rename locals to avoid shadowing.
2120 (create_dialog): Move locals to avoid shadowing.
2122 * xgselect.c (xg_select): Remove unused var.
2124 * image.c (four_corners_best): Mark locals as initialized.
2125 (gif_load): Initialize transparent_p to zero (Bug#8238).
2126 Mark another local as initialized.
2127 (my_png_error, my_error_exit): Mark with NO_RETURN.
2129 * image.c (clear_image_cache): Now static.
2130 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2131 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2132 (x_edge_detection): Remove unnecessary cast that
2133 gcc -Wbad-function-cast diagnoses.
2134 (gif_load): Fix pointer signedness.
2135 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2136 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2138 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2140 Improve quality of tests for time stamp overflow.
2141 For example, without this patch (encode-time 0 0 0 1 1
2142 1152921504606846976) returns the obviously-bogus value (-948597
2143 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2144 reports time overflow. See
2145 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2146 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2147 * editfns.c: Include limits.h and intprops.h.
2148 (TIME_T_MIN, TIME_T_MAX): New macros.
2149 (time_overflow): Move earlier, to before first use.
2150 (hi_time, lo_time): New functions, for an accurate test for
2152 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2153 (Fget_internal_run_time): Don't assume time_t fits in int.
2154 (make_time): Use list2 instead of Fcons twice.
2155 (Fdecode_time): More accurate test for out-of-range times.
2156 (check_tm_member): New function.
2157 (Fencode_time): Use it, to test for out-of-range times.
2158 (lisp_time_argument): Don't rely on undefined left-shift and
2159 right-shift behavior when checking for time stamp overflow.
2161 * editfns.c (time_overflow): New function, refactoring common code.
2162 (Fformat_time_string, Fdecode_time, Fencode_time):
2163 (Fcurrent_time_string): Use it.
2165 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2166 * dired.c (make_time): Move to ...
2167 * editfns.c (make_time): ... here.
2168 * systime.h: Note the move.
2170 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2172 * fringe.c (update_window_fringes): Remove unused variables.
2174 * unexmacosx.c (copy_data_segment): Also copy __got section.
2177 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2179 * termcap.c [MSDOS]: Include "msdos.h".
2180 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2181 Constify `char *' arguments and their references according to
2182 prototypes in tparam.h.
2184 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2186 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2187 Adapt all references accordingly.
2189 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2191 2011-03-11 Tom Tromey <tromey@redhat.com>
2193 * buffer.c (syms_of_buffer): Remove obsolete comment.
2195 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2197 * termhooks.h (encode_terminal_code): Declare prototype.
2199 * msdos.c (encode_terminal_code): Don't declare prototype.
2201 * term.c (encode_terminal_code): Now external again, used by
2202 w32console.c and msdos.c.
2204 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2205 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2207 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2209 Fix some minor problems found by GCC 4.5.2's static checks.
2211 * fringe.c (update_window_fringes): Mark locals as initialized
2213 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2215 * alloc.c (mark_fringe_data): Move decl from here ...
2216 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2217 to check its interface.
2218 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2220 * fontset.c (free_realized_fontset): Now static.
2221 (Fset_fontset_font): Rename local to avoid shadowing.
2222 (fontset_font): Mark local as initialized.
2223 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2225 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2227 * xselect.c (x_disown_buffer_selections): Remove; not used.
2228 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2229 (x_own_selection, Fx_disown_selection_internal): Rename locals
2231 (x_handle_dnd_message): Remove local to avoid shadowing.
2233 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2234 so that the caller can use some name other than gcpro1.
2235 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2236 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2237 (Fx_backspace_delete_keys_p):
2238 Use them to avoid shadowing, and rename vars to avoid shadowing.
2239 (x_decode_color, x_set_name, x_window): Now static.
2240 (Fx_create_frame): Add braces to silence GCC warning.
2241 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2242 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2243 Remove unused locals.
2244 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2245 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2246 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2249 * xterm.h (x_mouse_leave): New decl.
2251 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2252 Remove unused functions.
2253 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2254 (x_calc_absolute_position): Now static.
2255 (XTread_socket): Don't define label "out" unless it's used.
2256 Don't declare local "event" unless it's used.
2257 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2258 unless they are used.
2259 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2260 (x_fatal_error_signal): Remove; not used.
2261 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2262 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2263 (x_error_catcher, x_connection_closed, x_error_handler):
2264 (x_error_quitter, xembed_send_message, x_iconify_frame):
2265 (my_log_handler): Rename locals to avoid shadowing.
2266 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2267 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2269 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2270 Rename or move locals to avoid shadowing.
2271 (tty_defined_color, merge_face_heights): Now static.
2272 (free_realized_faces_for_fontset): Remove; not used.
2273 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2274 does not deduce is never used uninitialized.
2275 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2276 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2278 * terminal.c (store_terminal_param): Now static.
2280 * xmenu.c (menu_highlight_callback): Now static.
2281 (set_frame_menubar): Remove unused local.
2282 (xmenu_show): Rename parameter to avoid shadowing.
2283 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2284 since they might point to immutable storage.
2285 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2286 since it's unused otherwise.
2288 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2289 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2290 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2291 avoids a gcc -Wuninitialized diagnostic.
2292 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2293 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2294 does not deduce are never used uninitialized.
2296 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2298 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2299 * window.c (window_loop, size_window):
2300 (run_window_configuration_change_hook, enlarge_window): Likewise.
2302 * window.c (display_buffer): Now static.
2303 (size_window): Mark variables that gcc -Wuninitialized
2304 does not deduce are never used uninitialized.
2305 * window.h (check_all_windows): New decl, to forestall
2306 gcc -Wmissing-prototypes diagnostic.
2307 * dispextern.h (bidi_dump_cached_states): Likewise.
2309 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2311 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2313 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2314 and to avoid gcc -Wuninitialized warning.
2315 (load_charset_map): Mark variables that gcc -Wuninitialized
2316 does not deduce are never used uninitialized.
2317 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2319 * coding.c (coding_set_source, coding_set_destination):
2320 Use "else { /* comment */ }" rather than "else /* comment */;"
2321 for clarity, and to avoid gcc -Wempty-body warning.
2322 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2323 a block, when the outer 'i' will do.
2324 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2325 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2326 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2327 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2328 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2329 Rename locals to avoid shadowing.
2330 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2331 * coding.c (emacs_mule_char, encode_invocation_designation):
2332 Now static, since they're not used elsewhere.
2333 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2334 (decode_coding_object, encode_coding_object, detect_coding_system):
2335 (decode_coding_emacs_mule): Mark variables that gcc
2336 -Wuninitialized does not deduce are never used uninitialized.
2337 (detect_coding_iso_2022): Initialize a local variable that might
2338 be used uninitialized. Leave a FIXME because it's not clear that
2339 this initialization is needed. (Bug#8211)
2340 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2341 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2342 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2343 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2344 Remove unused macros.
2346 * category.c (hash_get_category_set): Remove unused local var.
2347 (copy_category_table): Now static, since it's not used elsewhere.
2348 * character.c (string_count_byte8): Likewise.
2350 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2351 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2353 * chartab.c (copy_sub_char_table): Now static, since it's not used
2355 (sub_char_table_ref_and_range, char_table_ref_and_range):
2356 Rename locals to avoid shadowing.
2357 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2359 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2360 (BIDI_BOB): Remove unused macro.
2362 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2363 deduce are never used uninitialized.
2364 * term.c (encode_terminal_code): Likewise.
2366 * term.c (encode_terminal_code): Now static. Remove unused local.
2368 * tparam.h: New file.
2369 * term.c, tparam.h: Include it.
2370 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2371 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2372 Move these decls to tparam.h, and make them agree with what
2373 is actually in tparam.c. The previous trick of using incompatible
2374 decls in different modules does not conform to the C standard.
2375 All callers of tparam changed to use tparam's actual API.
2376 * tparam.c (tparam1, tparam, tgoto):
2377 Use const pointers where appropriate.
2379 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2380 * cm.h (struct cm): Likewise.
2381 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2382 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2383 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2384 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2385 (turn_on_face, init_tty): Likewise.
2386 * termchar.h (struct tty_display_info): Likewise.
2388 * term.c (term_mouse_position): Rename local to avoid shadowing.
2390 * alloc.c (mark_ttys): Move decl from here ...
2391 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2393 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2395 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2397 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2399 * search.c (compile_pattern_1): Remove argument regp, unused since
2400 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2401 (compile_pattern): Don't pass it.
2403 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2405 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2406 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2408 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2410 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2412 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2413 gdk_window_get_screen, gdk_window_get_geometry,
2414 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2415 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2416 (xg_get_pixbuf_from_pixmap): New function.
2417 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2418 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2419 Call xg_get_pixbuf_from_pixmap instead of
2420 gdk_pixbuf_get_from_drawable.
2421 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2422 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2423 (xg_check_special_colors): Use GtkStyleContext and its functions
2425 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2426 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2427 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2428 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2429 Call gtk_widget_get_preferred_size.
2430 (xg_frame_resized): gdk_window_get_geometry only takes 5
2432 (xg_win_to_widget, xg_event_is_for_menubar):
2433 Call gdk_x11_window_lookup_for_display.
2434 (xg_set_widget_bg): New function.
2435 (delete_cb): New function.
2436 (xg_create_frame_widgets): connect delete-event to delete_cb.
2437 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2438 (xg_set_background_color): Call xg_set_widget_bg.
2439 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2440 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2441 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2442 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2444 (update_frame_tool_bar): Call gtk_widget_hide.
2445 (xg_initialize): Use GDK_KEY_g.
2447 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2449 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2451 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2452 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2453 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2455 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2457 * w32xfns.c (select_palette): Check success of RealizePalette against
2458 GDI_ERROR, not zero.
2460 See ChangeLog.11 for earlier changes.
2466 Copyright (C) 2011 Free Software Foundation, Inc.
2468 This file is part of GNU Emacs.
2470 GNU Emacs is free software: you can redistribute it and/or modify
2471 it under the terms of the GNU General Public License as published by
2472 the Free Software Foundation, either version 3 of the License, or
2473 (at your option) any later version.
2475 GNU Emacs is distributed in the hope that it will be useful,
2476 but WITHOUT ANY WARRANTY; without even the implied warranty of
2477 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2478 GNU General Public License for more details.
2480 You should have received a copy of the GNU General Public License
2481 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.