* src/process.c (Fset_process_buffer): Clarify return value in docstring.
[bpt/emacs.git] / src / ChangeLog
1 2011-06-20 Deniz Dogan <deniz@dogan.se>
2
3 * process.c (Fset_process_buffer): Clarify return value in
4 docstring.
5
6 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7
8 * dispnew.c (add_window_display_history): Use BVAR.
9
10 * xdisp.c (debug_method_add): Use BVAR.
11 (check_window_end, dump_glyph_matrix, dump_glyph)
12 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
13
14 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
15 Likewise.
16
17 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
18 check till after the cache is created in init_frame_faces.
19
20 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
21
22 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
23
24 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
25
26 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
27 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
28 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
29
30 Improve buffer-overflow checking (Bug#8873).
31 * fileio.c (Finsert_file_contents):
32 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
33 Remove the old (too-loose) buffer overflow checks.
34 They weren't needed, since make_gap checks for buffer overflow.
35 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
36 The old code merely checked for Emacs fixnum overflow, and relied
37 on undefined (wraparound) behavior. The new code avoids undefined
38 behavior, and also checks for ptrdiff_t and/or size_t overflow.
39
40 * editfns.c (Finsert_char): Don't dump core with very negative counts.
41 Tune. Don't use wider integers than needed. Don't use alloca.
42 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
43
44 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
45
46 * insdel.c, lisp.h (buffer_overflow): New function.
47 (insert_from_buffer_1, replace_range, replace_range_2):
48 * insdel.c (make_gap_larger):
49 * editfns.c (Finsert_char):
50 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
51
52 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
53
54 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
55
56 Integer overflow and signedness fixes (Bug#8873).
57
58 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
59 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
60
61 * fileio.c: Don't assume EMACS_INT fits in off_t.
62 (emacs_lseek): New static function.
63 (Finsert_file_contents, Fwrite_region): Use it.
64 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
65
66 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
67
68 * fns.c: Don't overflow int when computing a list length.
69 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
70 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
71 truncation on 64-bit hosts. Check for QUIT every
72 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
73 faster and is responsive enough.
74 (Flength): Report an error instead of overflowing an integer.
75 (Fsafe_length): Return a float if the value is not representable
76 as a fixnum. This shouldn't happen except in contrived situations.
77 (Fnthcdr, Fsort): Don't assume list length fits in int.
78 (Fcopy_sequence): Don't assume vector length fits in int.
79
80 * alloc.c: Check that resized vectors' lengths fit in fixnums.
81 (header_size, word_size): New constants.
82 (allocate_vectorlike): Don't check size overflow here.
83 (allocate_vector): Check it here instead, since this is the only
84 caller of allocate_vectorlike that could cause overflow.
85 Check that the new vector's length is representable as a fixnum.
86
87 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
88 The previous code was bogus. For example, next_almost_prime (32)
89 returned 39, which is undesirable as it is a multiple of 3; and
90 next_almost_prime (24) returned 25, which is a multiple of 5 so
91 why was the code bothering to check for multiples of 7?
92
93 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
94
95 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
96
97 Variadic C functions now count arguments with ptrdiff_t.
98 This partly undoes my 2011-03-30 change, which replaced int with size_t.
99 Back then I didn't know that the Emacs coding style prefers signed int.
100 Also, in the meantime I found a few more instances where arguments
101 were being counted with int, which may truncate counts on 64-bit
102 machines, or EMACS_INT, which may be unnecessarily wide.
103 * lisp.h (struct Lisp_Subr.function.aMANY)
104 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
105 Arg counts are now ptrdiff_t, not size_t.
106 All variadic functions and their callers changed accordingly.
107 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
108 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
109 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
110 * callint.c (Fcall_interactively): Check arg count for overflow,
111 to avoid potential buffer overrun. Use signed char, not 'int',
112 for 'varies' array, so that we needn't bother to check its size
113 calculation for overflow.
114 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
115 * eval.c (apply_lambda):
116 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
117 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
118 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
119
120 * callint.c (Fcall_interactively): Don't use index var as event count.
121
122 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
123 * mem-limits.h (SIZE): Remove; no longer used.
124
125 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
126
127 Remove unnecessary casts.
128 * xterm.c (x_term_init):
129 * xfns.c (x_set_border_pixel):
130 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
131 These aren't needed now that we assume ANSI C.
132
133 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
134 It's more likely to cause problems (due to unsigned overflow)
135 than to cure them.
136
137 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
138
139 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
140
141 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
142
143 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
144
145 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
146
147 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
148
149 GLYPH_CODE_FACE returns EMACS_INT, not int.
150 * dispextern.h (merge_faces):
151 * xfaces.c (merge_faces):
152 * xdisp.c (get_next_display_element, next_element_from_display_vector):
153 Don't assume EMACS_INT fits in int.
154
155 * character.h (CHAR_VALID_P): Remove unused parameter.
156 * fontset.c, lisp.h, xdisp.c: All uses changed.
157
158 * editfns.c (Ftranslate_region_internal): Omit redundant test.
159
160 * fns.c (concat): Minor tuning based on overflow analysis.
161 This doesn't fix any bugs. Use int to hold character, instead
162 of constantly refetching from Emacs object. Use XFASTINT, not
163 XINT, for value known to be a character. Don't bother comparing
164 a single byte to 0400, as it's always less.
165
166 * floatfns.c (Fexpt):
167 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
168
169 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
170 for characters.
171
172 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
173
174 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
175 Without this fix, on a 64-bit host (aset S 0 4294967386) would
176 incorrectly succeed when S was a string, because 4294967386 was
177 truncated before it was used.
178
179 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
180 Otherwise, an out-of-range integer could cause undefined behavior
181 on a 64-bit host.
182
183 * composite.c: Use int, not EMACS_INT, for characters.
184 (fill_gstring_body, composition_compute_stop_pos): Use int, not
185 EMACS_INT, for values that are known to be in character range.
186 This doesn't fix any bugs but is the usual style inside Emacs and
187 may generate better code on 32-bit machines.
188
189 Make sure a 64-bit char is never passed to ENCODE_CHAR.
190 This is for reasons similar to the recent CHAR_STRING fix.
191 * charset.c (Fencode_char): Check that character arg is actually
192 a character. Pass an int to ENCODE_CHAR.
193 * charset.h (ENCODE_CHAR): Verify that the character argument is no
194 wider than 'int', as a compile-time check to prevent future regressions
195 in this area.
196
197 * character.c (char_string): Remove unnecessary casts.
198
199 Make sure a 64-bit char is never passed to CHAR_STRING.
200 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
201 by silently ignoring the top 32 bits, allowing some values
202 that were far too large to be valid characters.
203 * character.h: Include <verify.h>.
204 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
205 arguments are no wider than unsigned, as a compile-time check
206 to prevent future regressions in this area.
207 * data.c (Faset):
208 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
209 (Fsubst_char_in_region):
210 * fns.c (concat):
211 * xdisp.c (decode_mode_spec_coding):
212 Adjust to CHAR_STRING's new requirement.
213 * editfns.c (Finsert_char, Fsubst_char_in_region):
214 * fns.c (concat): Check that character args are actually
215 characters. Without this test, these functions did the wrong
216 thing with wildly out-of-range values on 64-bit hosts.
217
218 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
219 These casts should not be needed on 32-bit hosts, either.
220 * keyboard.c (read_char):
221 * lread.c (Fload): Remove casts to unsigned.
222
223 * lisp.h (UNSIGNED_CMP): New macro.
224 This fixes comparison bugs on 64-bit hosts.
225 (ASCII_CHAR_P): Use it.
226 * casefiddle.c (casify_object):
227 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
228 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
229 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
230 * dispextern.h (FACE_FROM_ID):
231 * keyboard.c (read_char): Use UNSIGNED_CMP.
232
233 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
234 not to EMACS_INT, to avoid GCC warning.
235
236 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
237
238 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
239 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
240 isn't needed on 32-bit machines.
241
242 * buffer.c (Fgenerate_new_buffer_name):
243 Use EMACS_INT for count, not int.
244 (advance_to_char_boundary): Return EMACS_INT, not int.
245
246 * data.c (Qcompiled_function): Now static.
247
248 * window.c (window_body_lines): Now static.
249
250 * image.c (gif_load): Rename local to avoid shadowing.
251
252 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
253 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
254 * alloc.c (make_save_value): Integer argument is now of type
255 ptrdiff_t, not int.
256 (mark_object): Use ptrdiff_t, not int.
257 * lisp.h (pD): New macro.
258 * print.c (print_object): Use it.
259
260 * alloc.c: Use EMACS_INT, not int, to count objects.
261 (total_conses, total_markers, total_symbols, total_vector_size)
262 (total_free_conses, total_free_markers, total_free_symbols)
263 (total_free_floats, total_floats, total_free_intervals)
264 (total_intervals, total_strings, total_free_strings):
265 Now EMACS_INT, not int. All uses changed.
266 (Fgarbage_collect): Compute overall total using a double, so that
267 integer overflow is less likely to be a problem. Check for overflow
268 when converting back to an integer.
269 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
270 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
271 These were 'int' variables that could overflow on 64-bit hosts;
272 they were never used, so remove them instead of repairing them.
273 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
274 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
275 Previously, this ceilinged at INT_MAX, but that doesn't work on
276 64-bit machines.
277 (allocate_pseudovector): Don't use EMACS_INT when int would do.
278
279 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
280 (allocate_vectorlike): Check for ptrdiff_t overflow.
281 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
282 when a (possibly-narrower) signed value would do just as well.
283 We prefer using signed arithmetic, to avoid comparison confusion.
284
285 * alloc.c: Catch some string size overflows that we were missing.
286 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
287 for convenience in STRING_BYTES_MAX.
288 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
289 The definition here is exact; the one in lisp.h was approximate.
290 (allocate_string_data): Check for string overflow. This catches
291 some instances we weren't catching before. Also, it catches
292 size_t overflow on (unusual) hosts where SIZE_MAX <= min
293 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
294 and ptrdiff_t and EMACS_INT are both 64 bits.
295
296 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
297 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
298 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
299
300 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
301
302 * alloc.c (Fmake_string): Check for out-of-range init.
303
304 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
305
306 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
307
308 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
309
310 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
311 xg_get_default_scrollbar_width.
312
313 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
314 (int_gtk_range_get_value): Move to the scroll bar part of the file.
315 (style_changed_cb): Call update_theme_scrollbar_width and call
316 x_set_scroll_bar_default_width and xg_frame_set_char_size for
317 all frames (Bug#8505).
318 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
319 Call gtk_window_set_resizable if HAVE_GTK3.
320 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
321 and height if HAVE_GTK3 (Bug#8505).
322 (scroll_bar_width_for_theme): New variable.
323 (update_theme_scrollbar_width): New function.
324 (xg_get_default_scrollbar_width): Move code to
325 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
326 (xg_initialize): Call update_theme_scrollbar_width.
327
328 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
329
330 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
331
332 2011-06-12 Martin Rudalics <rudalics@gmx.at>
333
334 * frame.c (make_frame): Call other_buffer_safely instead of
335 other_buffer.
336
337 * window.c (temp_output_buffer_show): Call display_buffer with
338 second argument Vtemp_buffer_show_specifiers and reset latter
339 immediately after the call.
340 (Vtemp_buffer_show_specifiers): New variable.
341 (auto_window_vscroll_p, next_screen_context_lines)
342 (Vscroll_preserve_screen_position): Remove leading asterisks from
343 doc-strings.
344
345 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
346
347 Fix minor problems found by GCC 4.6.0 static checking.
348 * buffer.c (Qclone_number): Remove for now, as it's unused.
349 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
350 (record_buffer): Remove unused local.
351 * frame.c (other_visible_frames, frame_buffer_list): Now static.
352 (set_frame_buffer_list): Remove; unused.
353 * frame.h (other_visible_frames): Remove decl.
354 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
355 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
356 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
357 if HAVE_GPM.
358 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
359 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
360 Define only if HAVE_GPM.
361 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
362 (update_hints_inhibit): Remove; never set. All uses removed.
363 * widgetprv.h (emacsFrameClassRec): Remove decl.
364 * window.c (delete_deletable_window): Now returns void, since it
365 wasn't returning anything.
366 (compare_window_configurations): Remove unused locals.
367 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
368 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
369 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
370 the same widths as pointers. This follows up on the 2011-05-06 patch.
371 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
372 * xterm.h: Likewise.
373 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
374
375 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
376
377 * makefile.w32-in: Update dependencies.
378 (LISP_H): Add lib/intprops.h.
379
380 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
381
382 * image.c (gif_load): Add animation frame delay to the metadata.
383 (syms_of_image): Use DEFSYM. New symbol `delay'.
384
385 2011-06-11 Martin Rudalics <rudalics@gmx.at>
386
387 * window.c (delete_deletable_window): Re-add.
388 (Fset_window_configuration): Rewrite to handle dead buffers and
389 consequently deletable windows.
390 (window_tree, Fwindow_tree): Remove. Supply functionality in
391 window.el.
392 (compare_window_configurations): Simplify code.
393
394 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
395
396 * image.c (imagemagick_load_image): Fix type mismatch.
397 (Fimagemagick_types): Likewise.
398
399 * window.h (replace_buffer_in_windows): Declare.
400
401 2011-06-11 Martin Rudalics <rudalics@gmx.at>
402
403 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
404 Qclone_number. Remove external declaration of Qdelete_window.
405 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
406 code.
407 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
408 Qbuffer_list_update_hook if allowed.
409 (Fother_buffer): Rewrite doc-string. Major rewrite for new
410 buffer list implementation.
411 (other_buffer_safely): New function.
412 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
413 calls to replace_buffer_in_windows and
414 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
415 if allowed.
416 (record_buffer): Inhibit quitting and rewrite using quittable
417 functions. Run Qbuffer_list_update_hook if allowed.
418 (Frecord_buffer, Funrecord_buffer): New functions.
419 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
420 switch-to-buffer to window.el.
421 (bury-buffer): Move to window.el.
422 (Vbuffer_list_update_hook): New variable.
423
424 * lisp.h (other_buffer_safely): Add prototype in buffer.c
425 section.
426
427 * window.h (resize_frame_windows): Move up in code.
428 (Fwindow_frame): Remove EXFUN.
429 (replace_buffer_in_all_windows): Remove prototype.
430 (replace_buffer_in_windows_safely): Add prototype.
431
432 * window.c: Declare Qdelete_window static again. Move down
433 declaration of select_count.
434 (Fnext_window, Fprevious_window): Rewrite doc-strings.
435 (Fother_window): Move to window.el.
436 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
437 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
438 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
439 window.el.
440 (replace_buffer_in_windows): Implement by calling
441 Qreplace_buffer_in_windows.
442 (replace_buffer_in_all_windows): Remove with some functionality
443 moved into replace_buffer_in_windows_safely.
444 (replace_buffer_in_windows_safely): New function.
445 (select_window_norecord, select_frame_norecord): Move in front
446 of run_window_configuration_change_hook. Remove now obsolete
447 declarations.
448 (Fset_window_buffer): Rewrite doc-string. Call
449 Qrecord_window_buffer.
450 (keys_of_window): Move binding for other-window to window.el.
451
452 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
453
454 * dispextern.h (struct image): Replace data member, whose int_val
455 and ptr_val fields were not used by anything, with a single
456 lisp_val object.
457
458 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
459 (gif_clear_image, gif_load, imagemagick_load_image)
460 (gs_clear_image, gs_load): Callers changed.
461
462 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
463
464 * buffer.h: Include <time.h>, for time_t.
465 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
466
467 Fix minor problems found by static checking.
468
469 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
470
471 Make identifiers static if they are not used in other modules.
472 * data.c (Qcompiled_function, Qframe, Qvector):
473 * image.c (QimageMagick, Qsvg):
474 * minibuf.c (Qmetadata):
475 * window.c (resize_window_check, resize_root_window): Now static.
476 * window.h (resize_window_check, resize_root_window): Remove decls.
477
478 * window.c (window_deletion_count, delete_deletable_window):
479 Remove; unused.
480 (window_body_lines): Now static.
481 (Fdelete_other_windows_internal): Mark vars as initialized.
482 Make sure 'resize_failed' is initialized.
483 (run_window_configuration_change_hook): Rename local to avoid shadowing.
484 (resize_window_apply): Remove unused local.
485 * window.h (delete_deletable_window): Remove decl.
486
487 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
488 (imagemagick_load_image): Fix pointer signedness problem by changing
489 last arg from unsigned char * to char *. All uses changed.
490 Also, fix a local for similar reasons.
491 Remove unused locals. Remove locals to avoid shadowing.
492 (fn_rsvg_handle_free): Remove; unused.
493 (svg_load, svg_load_image): Fix pointer signedness problem.
494 (imagemagick_load_image): Don't use garbage pointer image_wand.
495
496 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
497
498 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
499
500 * image.c (gif_load): Fix omitted cast error introduced by
501 2011-06-06 change.
502
503 2011-06-10 Martin Rudalics <rudalics@gmx.at>
504
505 * window.h (resize_proportionally, orig_total_lines)
506 (orig_top_line): Remove from window structure.
507 (set_window_height, set_window_width, change_window_heights)
508 (Fdelete_window): Remove prototypes.
509 (resize_frame_windows): Remove duplicate declaration.
510
511 2011-06-10 Eli Zaretskii <eliz@gnu.org>
512
513 * window.h (resize_frame_windows, resize_window_check)
514 (delete_deletable_window, resize_root_window)
515 (resize_frame_windows): Declare prototypes.
516
517 * window.c (resize_window_apply): Make definition be "static" to
518 match the prototype.
519
520 2011-06-10 Martin Rudalics <rudalics@gmx.at>
521
522 * window.c: Remove declarations of Qwindow_size_fixed,
523 window_min_size_1, window_min_size_2, window_min_size,
524 size_window, window_fixed_size_p, enlarge_window, delete_window.
525 Remove static from declaration of Qdelete_window, it's
526 temporarily needed by Fbury_buffer.
527 (replace_window): Don't assign orig_top_line and
528 orig_total_lines.
529 (Fdelete_window, delete_window): Remove. Window deletion is
530 handled by window.el.
531 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
532 Fdelete_window calls with calls to Qdelete_window.
533 (Fdelete_other_windows): Remove. Deleting other windows is
534 handled by window.el.
535 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
536 handled in window.el.
537 (window_min_size_2, window_min_size_1, window_min_size): Remove.
538 Window minimum sizes are handled in window.el.
539 (shrink_windows, size_window, set_window_height)
540 (set_window_width, change_window_heights, window_height)
541 (window_width, CURBEG, CURSIZE, enlarge_window)
542 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
543 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
544 handled in window.el.
545 (make_dummy_parent): Rename to make_parent_window and give it a
546 second argument horflag.
547 (make_window): Don't set resize_proportionally any more.
548 (Fsplit_window): Remove. Windows are split in window.el.
549 (save_restore_action, save_restore_orig_size)
550 (shrink_window_lowest_first, save_restore_orig_size): Remove.
551 Resize mini windows in window.el.
552 (grow_mini_window, shrink_mini_window): Implement by calling
553 Qresize_root_window_vertically, resize_window_check and
554 resize_window_apply.
555 (saved_window, Fset_window_configuration, save_window_save): Do
556 not handle orig_top_line, orig_total_lines, and
557 resize_proportionally.
558 (window_min_height, window_min_width): Move to window.el.
559 (keys_of_window): Move bindings for delete-other-windows,
560 split-window, delete-window and enlarge-window to window.el.
561
562 * buffer.c: Temporarily extern Qdelete_window.
563 (Fbury_buffer): Temporarily call Qdelete_window instead of
564 Fdelete_window (Fbury_buffer will move to window.el soon).
565
566 * frame.c (set_menu_bar_lines_1): Remove code handling
567 orig_top_line and orig_total_lines.
568
569 * dispnew.c (adjust_frame_glyphs_initially): Don't use
570 set_window_height but set heights directly.
571 (change_frame_size_1): Use resize_frame_windows.
572
573 * xdisp.c (init_xdisp): Don't use set_window_height but set
574 heights directly.
575
576 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
577 resize_frame_windows instead of change_window_heights and run
578 run_window_configuration_change_hook.
579
580 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
581 instead of change_window_heights and run
582 run_window_configuration_change_hook.
583
584 2011-06-09 Martin Rudalics <rudalics@gmx.at>
585
586 * window.c (replace_window): Rename second argument REPLACEMENT to
587 NEW. New third argument SETFLAG. Rewrite.
588 (delete_window, make_dummy_parent): Call replace_window with
589 third argument 1.
590 (window_list_1): Move down in code.
591 (run_window_configuration_change_hook): Move set_buffer part
592 before select_frame_norecord part in order to unwind correctly.
593 Rename count1 to count.
594 (recombine_windows, delete_deletable_window, resize_root_window)
595 (Fdelete_other_windows_internal)
596 (Frun_window_configuration_change_hook, make_parent_window)
597 (resize_window_check, resize_window_apply, Fresize_window_apply)
598 (resize_frame_windows, Fsplit_window_internal)
599 (Fdelete_window_internal, Fresize_mini_window_internal): New
600 functions.
601 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
602
603 2011-06-08 Martin Rudalics <rudalics@gmx.at>
604
605 * window.h (window): Add some new members to window structure -
606 normal_lines, normal_cols, new_total, new_normal, clone_number,
607 splits, nest, prev_buffers, next_buffers.
608 (WINDOW_TOTAL_SIZE): Move here from window.c.
609 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
610
611 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
612 Remove.
613 (make_dummy_parent): Set new members of windows structure.
614 (make_window): Move down in code. Handle new members of window
615 structure.
616 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
617 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
618 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
619 (Fset_window_prev_buffers, Fwindow_next_buffers)
620 (Fset_window_next_buffers, Fset_window_clone_number): New
621 functions.
622 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
623 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
624 Doc-string fixes.
625 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
626 Argument WINDOW can be now internal window too.
627 (Fwindow_use_time): Move up in code.
628 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
629 Rewrite doc-string.
630 (Fset_window_configuration, saved_window)
631 (Fcurrent_window_configuration, save_window_save): Handle new
632 members of window structure.
633 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
634 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
635 (syms_of_window): New Lisp objects Qrecord_window_buffer,
636 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
637 Qget_mru_window, Qresize_root_window,
638 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
639 Qauto_buffer_name; staticpro them.
640
641 2011-06-07 Martin Rudalics <rudalics@gmx.at>
642
643 * window.c (Fwindow_total_size, Fwindow_left_column)
644 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
645 (Fwindow_list_1): New functions.
646 (window_box_text_cols): Replace with window_body_cols.
647 (Fwindow_width, Fscroll_left, Fscroll_right): Use
648 window_body_cols instead of window_box_text_cols.
649 (delete_window, Fset_window_configuration): Call
650 delete_all_subwindows with window as argument.
651 (delete_all_subwindows): Take a window as argument and not a
652 structure. Rewrite.
653 (window_loop): Remove handling of GET_LRU_WINDOW and
654 GET_LARGEST_WINDOW.
655 (Fget_lru_window, Fget_largest_window): Move to window.el.
656
657 * window.h: Extern window_body_cols instead of
658 window_box_text_cols. delete_all_subwindows now takes a
659 Lisp_Object as argument.
660
661 * indent.c (compute_motion, Fcompute_motion): Use
662 window_body_cols instead of window_box_text_cols.
663
664 * frame.c (delete_frame): Call delete_all_subwindows with root
665 window as argument.
666
667 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
668
669 * fns.c (Fputhash): Document return value.
670
671 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
672
673 * image.c (gif_load): Implement gif89a spec "no disposal" method.
674
675 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
676
677 Cons<->int and similar integer overflow fixes (Bug#8794).
678
679 Check for overflow when converting integer to cons and back.
680 * charset.c (Fdefine_charset_internal, Fdecode_char):
681 Use cons_to_unsigned to catch overflow.
682 (Fencode_char): Use INTEGER_TO_CONS.
683 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
684 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
685 * data.c (long_to_cons, cons_to_long): Remove.
686 (cons_to_unsigned, cons_to_signed): New functions.
687 These signal an error for invalid or out-of-range values.
688 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
689 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
690 * font.c (Ffont_variation_glyphs):
691 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
692 * lisp.h: Include <intprops.h>.
693 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
694 (cons_to_signed, cons_to_unsigned): New decls.
695 (long_to_cons, cons_to_long): Remove decls.
696 * undo.c (record_first_change): Use INTEGER_TO_CONS.
697 (Fprimitive_undo): Use CONS_TO_INTEGER.
698 * xfns.c (Fx_window_property): Likewise.
699 * xselect.c: Include <limits.h>.
700 (x_own_selection, selection_data_to_lisp_data):
701 Use INTEGER_TO_CONS.
702 (x_handle_selection_request, x_handle_selection_clear)
703 (x_get_foreign_selection, Fx_disown_selection_internal)
704 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
705 (lisp_data_to_selection_data): Use cons_to_unsigned.
706 (x_fill_property_data): Use cons_to_signed.
707 Report values out of range.
708
709 Check for buffer and string overflow more precisely.
710 * buffer.h (BUF_BYTES_MAX): New macro.
711 * lisp.h (STRING_BYTES_MAX): New macro.
712 * alloc.c (Fmake_string):
713 * character.c (string_escape_byte8):
714 * coding.c (coding_alloc_by_realloc):
715 * doprnt.c (doprnt):
716 * editfns.c (Fformat):
717 * eval.c (verror):
718 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
719 since they may not be the same number.
720 * editfns.c (Finsert_char):
721 * fileio.c (Finsert_file_contents):
722 Likewise for BUF_BYTES_MAX.
723
724 * image.c: Use ptrdiff_t, not int, for sizes.
725 (slurp_file): Switch from int to ptrdiff_t.
726 All uses changed.
727 (slurp_file): Check that file size fits in both size_t (for
728 malloc) and ptrdiff_t (for sanity and safety).
729
730 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
731 if b->modtime has its maximal value.
732
733 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
734
735 Don't assume time_t can fit into int.
736 * buffer.h (struct buffer.modtime): Now time_t, not int.
737 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
738 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
739
740 Minor fixes for signed vs unsigned integers.
741 * character.h (MAYBE_UNIFY_CHAR):
742 * charset.c (maybe_unify_char):
743 * keyboard.c (read_char, reorder_modifiers):
744 XINT -> XFASTINT, since the integer must be nonnegative.
745 * ftfont.c (ftfont_spec_pattern):
746 * keymap.c (access_keymap, silly_event_symbol_error):
747 XUINT -> XFASTINT, since the integer must be nonnegative.
748 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
749 since it makes no difference and we prefer signed.
750 * keyboard.c (record_char): Use XUINT when all the neighbors do.
751 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
752 nonnegative.
753
754 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
755
756 * window.h (Fwindow_frame): Declare.
757
758 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
759
760 * alloc.c: Simplify handling of large-request failures (Bug#8800).
761 (SPARE_MEMORY): Always define.
762 (LARGE_REQUEST): Remove.
763 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
764
765 2011-06-06 Martin Rudalics <rudalics@gmx.at>
766
767 * lisp.h: Move EXFUNS for Fframe_root_window,
768 Fframe_first_window and Fset_frame_selected_window to window.h.
769
770 * window.h: Move EXFUNS for Fframe_root_window,
771 Fframe_first_window and Fset_frame_selected_window here from
772 lisp.h.
773
774 * frame.c (Fwindow_frame, Fframe_first_window)
775 (Fframe_root_window, Fframe_selected_window)
776 (Fset_frame_selected_window): Move to window.c.
777 (Factive_minibuffer_window): Move to minibuf.c.
778 (Fother_visible_frames_p): New function.
779
780 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
781
782 * window.c (decode_window, decode_any_window): Move up in code.
783 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
784 (inhibit_frame_unsplittable): Remove unused variable.
785 (Fwindow_buffer): Move up and rewrite doc-string.
786 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
787 (Fwindow_prev): New functions.
788 (Fwindow_frame): Move here from frame.c. Accept any window as
789 argument.
790 (Fframe_root_window, Fframe_first_window)
791 (Fframe_selected_window): Move here from frame.c. Accept frame
792 or arbitrary window as argument. Update doc-strings.
793 (Fminibuffer_window): Move up in code.
794 (Fwindow_minibuffer_p): Move up in code and simplify.
795 (Fset_frame_selected_window): Move here from frame.c.
796 Marginal rewrite.
797 (Fselected_window, select_window, Fselect_window): Move up in
798 code. Minor doc-string fixes.
799
800 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
801
802 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
803 Do not assume that spare memory exists; that assumption is valid
804 only if SYSTEM_MALLOC.
805 (LARGE_REQUEST): New macro, so that the issue of large requests
806 is separated from the issue of spare memory.
807
808 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
809
810 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
811 format. (Bug#8806)
812
813 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
814
815 * xfns.c (x_set_scroll_bar_default_width): Move declarations
816 before statements.
817
818 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
819
820 * gtkutil.c (xg_get_default_scrollbar_width): New function.
821
822 * gtkutil.h: Declare xg_get_default_scrollbar_width.
823
824 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
825 min width by calling x_set_scroll_bar_default_width (Bug#8505).
826
827 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
828
829 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
830
831 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
832
833 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
834 (x_clipboard_manager_save): Add return value.
835 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
836 New error handlers.
837 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
838 Obey Vx_select_enable_clipboard_manager. Catch errors in
839 x_clipboard_manager_save (Bug#8779).
840 (Vx_select_enable_clipboard_manager): New variable.
841 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
842
843 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
844
845 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
846
847 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
848
849 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
850 in the current matrix if keep_current_p is non-zero.
851
852 2011-06-04 Eli Zaretskii <eliz@gnu.org>
853
854 * bidi.c (bidi_level_of_next_char): Fix last change.
855
856 2011-06-03 Eli Zaretskii <eliz@gnu.org>
857
858 Support bidi reordering of text covered by display properties.
859
860 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
861 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
862 (bidi_cache_search, bidi_cache_iterator_state)
863 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
864 (bidi_level_of_next_char, bidi_move_to_visually_next):
865 Support character positions inside a run of characters covered by a
866 display string.
867 (bidi_paragraph_init, bidi_resolve_explicit_1)
868 (bidi_level_of_next_char): Call bidi_fetch_char and
869 bidi_fetch_char_advance instead of FETCH_CHAR and
870 FETCH_CHAR_ADVANCE.
871 (bidi_init_it): Initialize new members.
872 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
873 definitions.
874 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
875 instead of using explicit *_CHAR codes.
876 (bidi_resolve_explicit, bidi_resolve_weak):
877 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
878 bidirectional text is supported only in multibyte buffers.
879 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
880 it to initialize the frame_window_p member of struct bidi_it.
881 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
882 (bidi_resolve_explicit, bidi_resolve_weak)
883 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
884 bidi_it->nchars is non-positive.
885 (bidi_level_of_next_char): Don't try to lookup the cache for the
886 next/previous character if nothing is cached there yet, or if we
887 were just reseat()'ed to a new position.
888
889 * xdisp.c (set_cursor_from_row): Set start and stop points
890 according to the row's direction when priming the loop that looks
891 for the glyph on which to display cursor.
892 (single_display_spec_intangible_p): Function deleted.
893 (display_prop_intangible_p): Reimplement to call
894 handle_display_spec instead of single_display_spec_intangible_p.
895 Accept 3 additional arguments needed by handle_display_spec.
896 This fixes incorrect cursor motion across display property with complex
897 values: lists, `(when COND...)' forms, etc.
898 (single_display_spec_string_p): Support property values that are
899 lists with the argument STRING its top-level element.
900 (display_prop_string_p): Fix the condition for processing a
901 property that is a list to be consistent with handle_display_spec.
902 (handle_display_spec): New function, refactored from the
903 last portion of handle_display_prop.
904 (compute_display_string_pos): Accept additional argument
905 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
906 value of a `display' property is a "replacing spec".
907 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
908 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
909 the display property, but just return a value indicating whether
910 the display property will replace the characters it covers.
911 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
912 frame_window_p members of struct bidi_it.
913 (compute_display_string_pos, compute_display_string_end):
914 New functions.
915 (push_it): Accept second argument POSITION, where pop_it should
916 jump to continue iteration.
917 (reseat_1): Initialize bidi_it.disp_pos.
918
919 * keyboard.c (adjust_point_for_property): Adjust the call to
920 display_prop_intangible_p to its new signature.
921
922 * dispextern.h (struct bidi_it): New member frame_window_p.
923 (bidi_init_it): Update prototypes.
924 (display_prop_intangible_p): Update prototype.
925 (compute_display_string_pos, compute_display_string_end):
926 Declare prototypes.
927 (struct bidi_it): New members nchars and disp_pos. ch_len is now
928 EMACS_INT.
929
930 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
931
932 Malloc failure behavior now depends on size of allocation.
933 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
934 * lisp.h: Change signatures accordingly.
935 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
936 All callers changed. (Bug#8762)
937
938 * gnutls.c: Use Emacs's memory allocators.
939 Without this change, the gnutls library would invoke malloc etc.
940 directly, which causes problems on non-SYNC_INPUT hosts, and which
941 runs afoul of improving memory_full behavior. (Bug#8761)
942 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
943 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
944 xfree instead of the default malloc, realloc, free.
945 (Fgnutls_boot): No need to check for memory allocation failure,
946 since xmalloc does that for us.
947
948 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
949 * category.c (hash_get_category_set):
950 * ccl.c (ccl_driver):
951 * charset.c (Fdefine_charset_internal):
952 * charset.h (struct charset.hash_index):
953 * composite.c (get_composition_id, gstring_lookup_cache)
954 (composition_gstring_put_cache):
955 * composite.h (struct composition.hash_index):
956 * dispextern.h (struct image.hash):
957 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
958 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
959 (hashfn_equal, hashfn_user_defined, make_hash_table)
960 (maybe_resize_hash_table, hash_lookup, hash_put)
961 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
962 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
963 (Fsxhash, Fgethash, Fputhash, Fmaphash):
964 * image.c (make_image, search_image_cache, lookup_image)
965 (xpm_put_color_table_h):
966 * lisp.h (struct Lisp_Hash_Table):
967 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
968 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
969 for hashes and hash indexes, instead of 'unsigned' and 'int'.
970 * alloc.c (allocate_vectorlike):
971 Check for overflow in vector size calculations.
972 * ccl.c (ccl_driver):
973 Check for overflow when converting EMACS_INT to int.
974 * fns.c, image.c: Remove unnecessary static decls that would otherwise
975 need to be updated by these changes.
976 * fns.c (make_hash_table, maybe_resize_hash_table):
977 Check for integer overflow with large hash tables.
978 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
979 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
980 (SXHASH_REDUCE): New macro.
981 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
982 Use it instead of discarding useful hash info with large hash values.
983 (sxhash_float): New function.
984 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
985 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
986 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
987 Rewrite to use FIXNUM_BITS, as this simplifies things.
988 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
989 Adjust signatures to match updated version of code.
990 (consing_since_gc): Now EMACS_INT, since a single hash table can
991 use more than INT_MAX bytes.
992
993 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
994
995 Make it possible to build with GCC-4.6+ -O2 -flto.
996
997 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
998
999 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1000
1001 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1002 Call minibuffer-inactive-mode.
1003
1004 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1005
1006 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1007 Update dependencies.
1008
1009 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1010
1011 * data.c (init_data): Remove code for UTS, this system is not
1012 supported anymore.
1013
1014 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1015
1016 Don't force ./temacs to start in terminal mode.
1017
1018 * frame.c (make_initial_frame): Initialize faces in all cases, not
1019 only when CANNOT_DUMP is defined.
1020 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1021
1022 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1023
1024 * dispnew.c (add_window_display_history): Use const for the string
1025 pointer. Remove declaration, not needed.
1026
1027 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1028
1029 Use 'inline', not 'INLINE'.
1030 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1031 * alloc.c, fontset.c (INLINE): Remove.
1032 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1033 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1034 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1035 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1036 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1037
1038 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1039
1040 Make it possible to run ./temacs.
1041
1042 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1043 syms_of_callproc does the same thing. Remove test for
1044 "initialized", do it in the caller.
1045 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1046
1047 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1048
1049 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1050 (read_minibuf): Use get_minibuffer.
1051 (syms_of_minibuf): Use DEFSYM.
1052 (Qmetadata): New var.
1053 * data.c (Qbuffer): Don't make it static.
1054 (syms_of_data): Use DEFSYM.
1055
1056 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1057
1058 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1059 (CCL_CODE_MIN): New macro.
1060
1061 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1062
1063 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1064
1065 * eval.c (Qdebug): Now static.
1066 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1067 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1068 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1069
1070 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1071
1072 * image.c: Various fixes to ImageMagick code comments.
1073 (Fimagemagick_types): Doc fix.
1074
1075 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1076
1077 Minor fixes prompted by GCC 4.6.0 warnings.
1078
1079 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1080
1081 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1082 (x_clipboard_manager_save_all): Move extern decl to ...
1083 * xterm.h: ... here, so that it can be checked for consistency.
1084
1085 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1086
1087 * xselect.c (x_clipboard_manager_save_frame)
1088 (x_clipboard_manager_save_all): New functions.
1089 (Fx_clipboard_manager_save): Lisp function deleted.
1090
1091 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1092 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1093
1094 * xterm.h: Update prototype.
1095
1096 2011-05-28 William Xu <william.xwl@gmail.com>
1097
1098 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1099 exiting (Bug#8239).
1100
1101 2011-05-28 Jim Meyering <meyering@redhat.com>
1102
1103 Avoid a sign-extension bug in crypto_hash_function.
1104 * fns.c (to_uchar): Define.
1105 (crypto_hash_function): Use it to convert some newly-signed
1106 variables to unsigned, to avoid sign-extension bugs. For example,
1107 without this change, (md5 "truc") would evaluate to
1108 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1109 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1110 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1111
1112 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1113
1114 Integer overflow fixes.
1115
1116 * dbusbind.c: Serial number integer overflow fixes.
1117 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1118 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1119 to hold a serial number that is too large for a fixnum.
1120 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1121 Check for serial numbers out of range. Decode any serial number
1122 that was so large that it became a float. (Bug#8722)
1123
1124 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1125 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1126 Use XFASTINT rather than XUINT when numbers are nonnegative.
1127 (xd_append_arg, Fdbus_method_return_internal):
1128 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1129 arguments, check that Lisp number is nonnegative, rather than
1130 silently wrapping negative numbers around. (Bug#8722)
1131 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1132 (Bug#8722)
1133
1134 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1135
1136 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1137
1138 ccl: add integer overflow checks
1139 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1140 (IN_INT_RANGE): New macros.
1141 (ccl_driver): Use them to check for integer overflow when
1142 decoding a CCL program. Many of the new checks are whether XINT (x)
1143 fits in int; it doesn't always, on 64-bit hosts. The new version
1144 doesn't catch all possible integer overflows, but it's an
1145 improvement. (Bug#8719)
1146
1147 * alloc.c (make_event_array): Use XINT, not XUINT.
1148 There's no need for unsigned here.
1149
1150 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1151 This follows up to the 2011-05-06 change that substituted uintptr_t
1152 for EMACS_INT. This case wasn't caught back then.
1153
1154 Rework Fformat to avoid integer overflow issues.
1155 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1156 now (part of C89). Include <verify.h>.
1157 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1158 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1159 (Fformat): Avoid the prepass trying to compute sizes; it was only
1160 approximate and thus did not catch overflow reliably. Instead, walk
1161 through the format just once, formatting and computing sizes as we go,
1162 checking for integer overflow at every step, and allocating a larger
1163 buffer as needed. Keep track separately whether the format is
1164 multibyte. Keep only the most-recently calculated precision, rather
1165 than them all. Record whether each argument has been converted to
1166 string. Use EMACS_INT, not int, for byte and char and arg counts.
1167 Support field widths and precisions larger than INT_MAX. Avoid
1168 sprintf's undefined behavior with conversion specifications such as %#d
1169 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1170 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1171 formatting out-of-range floating point numbers with int
1172 formats. (Bug#8668)
1173
1174 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1175
1176 * data.c: Avoid integer truncation in expressions involving floats.
1177 * data.c: Include <intprops.h>.
1178 (arith_driver): When there's an integer overflow in an expression
1179 involving floating point, convert the integers to floating point
1180 so that the resulting value does not suffer from catastrophic
1181 integer truncation. For example, on a 64-bit host (* 4
1182 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1183 Do not rely on undefined behavior after integer overflow.
1184
1185 merge count_size_as_multibyte, parse_str_to_multibyte
1186 * character.c, character.h (count_size_as_multibyte):
1187 Rename from parse_str_to_multibyte; all uses changed.
1188 Check for integer overflow.
1189 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1190 since it's now a duplicate of the other. This is more of
1191 a character than a buffer op, so better that it's in character.c.
1192 * fns.c, print.c: Adjust to above changes.
1193
1194 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1195
1196 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1197
1198 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1199
1200 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1201 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1202 (x_clipboard_manager_save): Now static.
1203 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1204
1205 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1206 (crypto_hash_function): Now static.
1207 Fix pointer signedness problems. Avoid unnecessary initializations.
1208
1209 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1210
1211 * termhooks.h (Vselection_alist): Make it terminal-local.
1212
1213 * terminal.c (create_terminal): Initialize it.
1214
1215 * xselect.c: Support for clipboard managers.
1216 (Vselection_alist): Move to termhooks.h as terminal-local var.
1217 (LOCAL_SELECTION): New macro.
1218 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1219 (symbol_to_x_atom): Remove gratuitous arg.
1220 (x_handle_selection_request, lisp_data_to_selection_data)
1221 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1222 (x_own_selection, x_get_local_selection, x_convert_selection):
1223 New arg, specifying work frame. Use terminal-local Vselection_alist.
1224 (some_frame_on_display): Delete unused function.
1225 (Fx_own_selection_internal, Fx_get_selection_internal)
1226 (Fx_disown_selection_internal, Fx_selection_owner_p)
1227 (Fx_selection_exists_p): New optional frame arg.
1228 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1229 (x_handle_selection_clear): Don't treat other terminals with the
1230 same keyboard specially. Use the terminal-local Vselection_alist.
1231 (x_clear_frame_selections): Use Frun_hook_with_args.
1232
1233 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1234
1235 * xterm.h: Add support for those atoms.
1236
1237 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1238
1239 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1240 (converted_selections, conversion_fail_tag): New global variables.
1241 (x_selection_request_lisp_error): Free the above.
1242 (x_get_local_selection): Remove unnecessary code.
1243 (x_reply_selection_request): Args changed; handle arbitrary array
1244 of converted selections stored in converted_selections.
1245 Separate the XChangeProperty and SelectionNotify steps.
1246 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1247 (x_convert_selection): New function.
1248 (x_handle_selection_event): Simplify.
1249 (x_get_foreign_selection): Don't ignore incoming requests while
1250 waiting for an answer; this will fail when we implement
1251 SAVE_TARGETS, and seems unnecessary anyway.
1252 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1253 (Vx_sent_selection_functions): Doc fix.
1254
1255 2011-05-26 Leo Liu <sdl.web@gmail.com>
1256
1257 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1258
1259 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1260
1261 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1262
1263 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1264 for fringe update if it has periodic bitmap.
1265 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1266 and fringe_bitmap_periodic_p.
1267
1268 * fringe.c (get_fringe_bitmap_data): New function.
1269 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1270 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1271 row. Mark glyph row for fringe update if periodicity changed.
1272
1273 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1274 for fringe update unless it has periodic bitmap.
1275
1276 2011-05-25 Kenichi Handa <handa@m17n.org>
1277
1278 * xdisp.c (get_next_display_element): Set correct it->face_id for
1279 a static composition.
1280
1281 2011-05-24 Leo Liu <sdl.web@gmail.com>
1282
1283 * deps.mk (fns.o):
1284 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1285
1286 * fns.c (crypto_hash_function, Fsha1): New function.
1287 (Fmd5): Use crypto_hash_function.
1288 (syms_of_fns): Add Ssha1.
1289
1290 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1291
1292 * gnutls.c: Remove unused macros.
1293 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1294 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1295 Remove macros that are defined and never used.
1296 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1297
1298 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1299
1300 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1301 (Fx_get_selection_internal): Minor cleanup.
1302 (Fx_own_selection_internal): Rename arguments for consistency with
1303 select.el.
1304
1305 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1306
1307 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1308
1309 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1310
1311 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1312
1313 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1314
1315 * dispnew.c (scrolling_window): Don't exclude the case that the
1316 last enabled row in the desired matrix touches the bottom boundary.
1317
1318 2011-05-21 Glenn Morris <rgm@gnu.org>
1319
1320 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1321 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1322 and add some more files.
1323
1324 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1325
1326 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1327 report_file_error introduced by the change from 2011-05-07.
1328
1329 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1330
1331 * systime.h (Time): Define only if emacs is defined.
1332 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1333 where the include path doesn't have X11/X.h by default. See
1334 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1335
1336 2011-05-20 Kenichi Handa <handa@m17n.org>
1337
1338 * composite.c (find_automatic_composition): Fix previous change.
1339
1340 2011-05-20 Glenn Morris <rgm@gnu.org>
1341
1342 * lisp.mk: New file, split from Makefile.in.
1343 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1344 (shortlisp): Remove.
1345 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1346
1347 2011-05-19 Glenn Morris <rgm@gnu.org>
1348
1349 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1350 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1351 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1352 (lisp): Set the order to that of loadup.el.
1353 (shortlisp): Make it a copy of $lisp.
1354 (SOME_MACHINE_LISP): Remove.
1355 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1356 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1357
1358 2011-05-18 Kenichi Handa <handa@m17n.org>
1359
1360 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1361 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1362 (find_automatic_composition): Mostly rewrite for efficiency.
1363
1364 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1365
1366 * makefile.w32-in: Update dependencies.
1367
1368 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1369
1370 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1371 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1372
1373 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1374
1375 Fix some integer overflow issues, such as string length overflow.
1376
1377 * insdel.c (count_size_as_multibyte): Check for string overflow.
1378
1379 * character.c (lisp_string_width): Check for string overflow.
1380 Use EMACS_INT, not int, for string indexes and lengths; in
1381 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1382 the resulting string length overflows an EMACS_INT; instead,
1383 report a string overflow if no precision given. When checking for
1384 precision exhaustion, use a check that cannot possibly have
1385 integer overflow. (Bug#8675)
1386 * character.h (lisp_string_width): Adjust to new signature.
1387
1388 * alloc.c (string_overflow): New function.
1389 (Fmake_string): Use it. This doesn't change behavior, but saves
1390 a few bytes and will simplify future changes.
1391 * character.c (string_escape_byte8): Likewise.
1392 * lisp.h (string_overflow): New decl.
1393
1394 Fixups, following up to the user-interface timestamp change.
1395 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1396 for UI timestamps, instead of unsigned long.
1397 * msdos.c (mouse_get_pos): Likewise.
1398 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1399 * w32gui.h (Time): Define by including "systime.h" rather than by
1400 declaring it ourselves. (Bug#8664)
1401
1402 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1403 * image.c (clear_image_cache): Likewise.
1404
1405 * term.c (term_mouse_position): Don't assume time_t wraparound.
1406
1407 Be more systematic about user-interface timestamps.
1408 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1409 and sometimes 'EMACS_UINT', to represent these timestamps.
1410 This change causes it to use 'Time' uniformly, as that's what X uses.
1411 This makes the code easier to follow, and makes it easier to catch
1412 integer overflow bugs such as Bug#8664.
1413 * frame.c (Fmouse_position, Fmouse_pixel_position):
1414 Use Time, not unsigned long, for user-interface timestamps.
1415 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1416 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1417 * keyboard.h (last_event_timestamp): Likewise.
1418 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1419 * menu.h (xmenu_show): Likewise.
1420 * term.c (term_mouse_position): Likewise.
1421 * termhooks.h (struct input_event.timestamp): Likewise.
1422 (struct terminal.mouse_position_hook): Likewise.
1423 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1424 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1425 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1426 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1427 what it was before.
1428 * menu.h, termhooks.h: Include "systime.h", for Time.
1429
1430 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1431 Don't assume that the difference between two unsigned long values
1432 can fit into an integer. At this point, we know button_down_time
1433 <= event->timestamp, so the difference must be nonnegative, so
1434 there's no need to cast the result if double-click-time is
1435 nonnegative, as it should be; check that it's nonnegative, just in
1436 case. This bug is triggered when events are more than 2**31 ms
1437 apart (about 25 days). (Bug#8664)
1438
1439 * xselect.c (last_event_timestamp): Remove duplicate decl.
1440 (x_own_selection): Remove needless cast to unsigned long.
1441
1442 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1443 that always fit in int. Use a sentinel instead of a counter, to
1444 avoid a temp and to allay GCC's concerns about possible int overflow.
1445 * frame.h (struct frame): Use int for menu_bar_items_used
1446 instead of EMACS_INT, since it always fits in int.
1447
1448 * menu.c (grow_menu_items): Check for int overflow.
1449
1450 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1451
1452 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1453 Before, the code was not consistent. These values cannot exceed
1454 2**31 - 1 so there's no need to make them unsigned.
1455 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1456 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1457 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1458 as modifiers.
1459 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1460
1461 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1462 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1463 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1464 presumably because the widths might not match.
1465
1466 * window.c (size_window): Avoid needless test at loop start.
1467
1468 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1469
1470 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1471
1472 2011-05-12 Drew Adams <drew.adams@oracle.com>
1473
1474 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1475
1476 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1477
1478 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1479 `width' to `bar_area_x' and `bar_area_width', respectively.
1480 (x_scroll_run): Take account of fringe background extension.
1481
1482 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1483 Rename local vars `left' and `width' to `bar_area_x' and
1484 `bar_area_width', respectively.
1485 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1486 background extension.
1487
1488 2011-05-10 Jim Meyering <meyering@redhat.com>
1489
1490 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1491
1492 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1493
1494 * image.c (Finit_image_library): Return t for built-in image types,
1495 like pbm and xbm. (Bug#8640)
1496
1497 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1498
1499 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1500
1501 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1502
1503 * w32console.c (Fset_screen_color): Doc fix.
1504 (Fget_screen_color): New function.
1505 (syms_of_ntterm): Defsubr it.
1506
1507 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1508 unlink the temporary file if Fcall_process didn't create it in the
1509 first place.
1510 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1511 child process will be redirected to a file specified with `:file'.
1512 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1513 cue to call_process_cleanup not to close that handle.
1514
1515 2011-05-07 Ben Key <bkey76@gmail.com>
1516
1517 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1518 one of two shell specific rules, either bootstrap-temacs-CMD or
1519 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1520 to the previous implementation of the bootstrap-temacs rule.
1521 The bootstrap-temacs-CMD rule is similar to the previous
1522 implementation of the bootstrap-temacs rule except that it
1523 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1524 variable.
1525
1526 These changes, along with some changes to nt/configure.bat,
1527 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1528 earlier fix to add support for --cflags and --ldflags options
1529 that include quotes so that it works whether make uses cmd or
1530 sh as the shell.
1531
1532 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1533
1534 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1535 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1536 is a constant.
1537 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1538 a string. Handle both cases.
1539 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1540 (Fdbus_register_method): Use Qinvalid_function.
1541
1542 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1543
1544 * makefile.w32-in: Update dependencies.
1545 (LISP_H): Add inttypes.h and stdin.h.
1546 (PROCESS_H): Add unistd.h.
1547
1548 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1549
1550 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1551 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1552
1553 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1554
1555 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1556
1557 * term.c (vfatal): Remove stray call to va_end.
1558 It's not needed and the C Standard doesn't allow it here anyway.
1559
1560 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1561 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1562
1563 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1564 bytes.
1565
1566 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1567
1568 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1569
1570 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1571
1572 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1573
1574 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1575
1576 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1577 * charset.c (Fdefine_charset_internal): Don't initialize
1578 charset.code_space[15]. The value was garbage, on hosts with
1579 32-bit int (Bug#8600).
1580
1581 * lread.c (read_integer): Be more consistent with string-to-number.
1582 Use string_to_number to do the actual conversion; this avoids
1583 rounding errors and fixes some other screwups. Without this fix,
1584 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1585 (digit_to_number): Move earlier, for benefit of read_integer.
1586 Return -1 if the digit is out of range for the base, -2 if it is
1587 not a digit in any supported base. (Bug#8602)
1588
1589 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1590
1591 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1592 to match comment at start of function. This also removes a
1593 GCC warning about overflow in a 32+64-bit port.
1594
1595 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1596
1597 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1598 Reported by Stefan Monnier in
1599 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1600 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1601 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1602
1603 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1604 (EMACS_UINTPTR): Likewise, with uintptr_t.
1605
1606 * lisp.h: Prefer 64-bit EMACS_INT if available.
1607 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1608 on 32-bit hosts that have 64-bit int, so that they can access
1609 large files.
1610 However, temporarily disable this change unless the temporary
1611 symbol WIDE_EMACS_INT is defined.
1612
1613 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1614
1615 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1616 This removes an assumption that EMACS_INT and long are the same
1617 width as pointers. The assumption is true for Emacs porting targets
1618 now, but we want to make other targets possible.
1619 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1620 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1621 In the rest of the code, change types of integers that hold casted
1622 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1623 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1624 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1625 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1626 No need to cast type when ORing.
1627 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1628 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1629 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1630 assume EMACS_INT is the same width as char *.
1631 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1632 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1633 Remove no-longer-needed casts.
1634 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1635 (xg_tool_bar_help_callback, xg_make_tool_item):
1636 Use EMACS_INTPTR to hold an integer
1637 that will be cast to void *; this can avoid a GCC warning
1638 if EMACS_INT is not the same width as void *.
1639 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1640 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1641 (current_message_1, set_message_1):
1642 Use a local to convert to proper width without a cast.
1643 * xmenu.c (dialog_selection_callback): Likewise.
1644
1645 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1646 Also, don't assume VALBITS / RAND_BITS is less than 5,
1647 and don't rely on undefined behavior when shifting a 1 left into
1648 the sign bit.
1649 * lisp.h (get_random): Change signature to match.
1650
1651 * lread.c (hash_string): Use size_t, not int, for hash computation.
1652 Normally we prefer signed values; but hashing is special, because
1653 it's better to use unsigned division on hash table sizes so that
1654 the remainder is nonnegative. Also, size_t is the natural width
1655 for hashing into memory. The previous code used 'int', which doesn't
1656 retain enough info to hash well into very large tables.
1657 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1658
1659 * dbusbind.c: Don't possibly lose pointer info when converting.
1660 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1661 Use XPNTR rather than XHASH, so that the high-order bits of
1662 the pointer aren't lost when converting through void *.
1663
1664 * eval.c (Fautoload): Don't double-shift a pointer.
1665
1666 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1667
1668 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1669
1670 * gnutls.c (DEF_GNUTLS_FN):
1671 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1672
1673 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1674
1675 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1676 marker. (Bug#8610)
1677
1678 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1679
1680 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1681 New version that can reserve upto 2GB of heap space.
1682
1683 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1684
1685 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1686
1687 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1688
1689 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1690 `gnutls_certificate_set_x509_key_file'.
1691
1692 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1693
1694 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1695 Update dependencies.
1696
1697 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1698
1699 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1700 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1701 Remove unused parameter `fildes'.
1702 * process.c (read_process_output, send_process): Don't pass it.
1703
1704 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1705
1706 Fix previous change: the library cache is defined in w32.c.
1707 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1708 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1709
1710 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1711
1712 Implement dynamic loading of GnuTLS on Windows.
1713
1714 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1715 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1716 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1717 Declare.
1718
1719 * gnutls.c (Qgnutls_dll): Define.
1720 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1721 (gnutls_*): Declare function pointers.
1722 (init_gnutls_functions): New function to initialize function pointers.
1723 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1724 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1725 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1726 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1727 (emacs_gnutls_write, emacs_gnutls_read)
1728 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1729 (Fgnutls_available_p): New function.
1730 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1731 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1732 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1733
1734 * image.c: Include w32.h.
1735 (Vimage_type_cache): Delete.
1736 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1737 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1738 (w32_delayed_load): Move to w32.c.
1739
1740 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1741
1742 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1743 (w32_delayed_load): Move from image.c. When loading a library, record
1744 its filename in the :loaded-from property of the library id.
1745 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1746 Initialize and staticpro them.
1747 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1748
1749 * process.c: Include lisp.h before w32.h, not after.
1750 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1751 instead of gnutls_record_check_pending.
1752
1753 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1754
1755 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1756
1757 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1758 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1759 as passed in.
1760
1761 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1762
1763 * xterm.c (x_set_frame_alpha): Do not set property on anything
1764 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1765
1766 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1767
1768 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1769
1770 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1771
1772 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1773 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1774 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1775 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1776 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1777 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1778 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1779 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1780 (Qgnutls_bootprop_callbacks_verify): Make static.
1781
1782 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1783
1784 * callproc.c: Indentation fixup.
1785
1786 * sysdep.c (wait_for_termination_1): Make static.
1787 (wait_for_termination, interruptible_wait_for_termination):
1788 Move after wait_for_termination_1.
1789
1790 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1791
1792 * sysdep.c (interruptible_wait_for_termination): New function
1793 which is like wait_for_termination, but allows keyboard
1794 interruptions.
1795
1796 * callproc.c (Fcall_process): Add (:file "file") as an option for
1797 the STDOUT buffer.
1798 (Fcall_process_region): Ditto.
1799
1800 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1801
1802 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1803 rather than `XVECTOR (FOO)->size'.
1804
1805 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1806 inttypes.h, as a gnulib replacement is used if it not available in
1807 system headers.
1808
1809 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1810
1811 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1812 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1813 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1814
1815 * coding.c (coding_alloc_by_realloc): Error out if destination
1816 will grow beyond MOST_POSITIVE_FIXNUM.
1817 (decode_coding_emacs_mule): Abort if there isn't enough place in
1818 charbuf for the composition carryover bytes. Reserve an extra
1819 space for up to 2 characters produced in a loop.
1820 (decode_coding_iso_2022): Abort if there isn't enough place in
1821 charbuf for the composition carryover bytes.
1822
1823 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1824
1825 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1826 aborting when %lld or %lll format is passed.
1827 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1828 %llo or %llx format is passed. (Bug#8545)
1829
1830 * window.c (window_scroll_line_based): Use a marker instead of
1831 simple variables to record original value of point. (Bug#7952)
1832
1833 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1834 produced by %s or %c overflows available buffer space. (Bug#8545)
1835
1836 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1837
1838 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1839 (SIZE_MAX): Move defn after all includes, as they might #define it.
1840
1841 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1842
1843 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1844
1845 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1846
1847 * keyboard.c (Qdelayed_warnings_hook): Define.
1848 (command_loop_1): Run `delayed-warnings-hook'
1849 if Vdelayed_warnings_list is non-nil.
1850 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1851 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1852
1853 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1854
1855 * doprnt.c (doprnt): Don't return value smaller than the buffer
1856 size if the message was truncated. (Bug#8545).
1857
1858 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1859
1860 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1861 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1862
1863 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1864
1865 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1866
1867 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1868
1869 * makefile.w32-in: Update dependencies.
1870
1871 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1872
1873 Improve `doprnt' and its usage. (Bug#8545)
1874 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1875 `format_end'. Remove support for %l as a conversion specifier.
1876 Don't use xrealloc. Improve diagnostics when the %l size modifier
1877 is used. Update the commentary.
1878
1879 * eval.c (verror): Simplify calculation of size_t.
1880
1881 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1882 messages.
1883
1884 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1885
1886 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1887 change.
1888
1889 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1890
1891 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1892 This makes this file independent of the recent pseudovector change.
1893
1894 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1895
1896 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1897
1898 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1899 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1900 Remove unused local.
1901 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1902
1903 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1904 GCC 4.6.0 optimizes based on type-based alias analysis.
1905 For example, if b is of type struct buffer * and v of type struct
1906 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1907 != &v->size, and therefore "v->size = 1; b->size = 2; return
1908 v->size;" must therefore return 1. This assumption is incorrect
1909 for Emacs, since it type-puns struct Lisp_Vector * with many other
1910 types. To fix this problem, this patch adds a new type struct
1911 vectorlike_header that documents the constraints on layout of vectors
1912 and pseudovectors, and helps optimizing compilers not get fooled
1913 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1914 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1915 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1916 the size member.
1917 (XSETPVECTYPE): Rewrite in terms of new macro.
1918 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1919 This is a bit clearer, and further avoids the possibility of
1920 undesirable aliasing.
1921 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1922 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1923 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1924 since Lisp_Subr is a special case (no "next" field).
1925 (ASIZE): Now uses header.size rather than size.
1926 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1927 to avoid the hassle of writing XVECTOR (foo)->header.size.
1928 (struct vectorlike_header): New type.
1929 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1930 object, to help avoid aliasing.
1931 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1932 (SUBRP): Likewise, since Lisp_Subr is a special case.
1933 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1934 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1935 (struct Lisp_Hash_Table): Combine first two members into a single
1936 struct vectorlike_header member. All uses of "size" and "next" members
1937 changed to be "header.size" and "header.next".
1938 * buffer.h (struct buffer): Likewise.
1939 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1940 * frame.h (struct frame): Likewise.
1941 * process.h (struct Lisp_Process): Likewise.
1942 * termhooks.h (struct terminal): Likewise.
1943 * window.c (struct save_window_data, struct saved_window): Likewise.
1944 * window.h (struct window): Likewise.
1945 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1946 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1947 * buffer.c (init_buffer_once): Likewise.
1948 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1949 special case.
1950 * process.c (Fformat_network_address): Use local var for size,
1951 for brevity.
1952
1953 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1954
1955 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1956 * data.c (atof): Remove decl; no longer used or needed.
1957 (digit_to_number): Move to lread.c.
1958 (Fstring_to_number): Use new string_to_number function, to be
1959 consistent with how the Lisp reader treats infinities and NaNs.
1960 Do not assume that floating-point numbers represent EMACS_INT
1961 without losing information; this is not true on most 64-bit hosts.
1962 Avoid double-rounding errors, by insisting on integers when
1963 parsing non-base-10 numbers, as the documentation specifies.
1964 * lisp.h (string_to_number): New decl, replacing ...
1965 (isfloat_string): Remove.
1966 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1967 (read1): Do not accept +. and -. as integers; this
1968 appears to have been a coding error. Similarly, do not accept
1969 strings like +-1e0 as floating point numbers. Do not report
1970 overflow for integer overflows unless the base is not 10 which
1971 means we have no simple and reliable way to continue.
1972 Break out the floating-point parsing into a new
1973 function string_to_number, so that Fstring_to_number parses
1974 floating point numbers consistently with the Lisp reader.
1975 (digit_to_number): Move here from data.c. Make it static inline.
1976 (E_CHAR, EXP_INT): Remove, replacing with ...
1977 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1978 (string_to_number): New function, replacing isfloat_string.
1979 This function checks for valid syntax and produces the resulting
1980 Lisp float number too. Rework it so that string-to-number
1981 no longer mishandles examples like "1.0e+". Use strtoumax,
1982 so that overflow for non-base-10 numbers is reported only when
1983 there's no portable and simple way to convert to floating point.
1984
1985 * textprop.c (set_text_properties_1): Rewrite for clarity,
1986 and to avoid GCC warning about integer overflow.
1987
1988 * intervals.h (struct interval): Use EMACS_INT for members
1989 where EMACS_UINT might cause problems. See
1990 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1991 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1992 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1993 All uses changed.
1994 (offset_intervals): Tell GCC not to worry about length overflow
1995 when negating a negative length.
1996
1997 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1998 (overrun_check_free): Likewise.
1999
2000 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2001 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2002 word size.
2003
2004 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2005 (gnutls_make_error): Rename local to avoid shadowing.
2006 (gnutls_emacs_global_deinit): ifdef out; not used.
2007 (Fgnutls_boot): Use const for pointer to readonly storage.
2008 Comment out unused local. Fix pointer signedness problems.
2009
2010 * lread.c (openp): Don't stuff size_t into an 'int'.
2011 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2012 about possible signed overflow.
2013
2014 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2015 (GDK_KEY_g): Don't define if already defined.
2016 (xg_prepare_tooltip): Avoid pointer signedness problem.
2017 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2018
2019 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2020 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2021
2022 * xfns.c (Fx_window_property): Simplify a bit,
2023 to make a bit faster and to avoid GCC 4.6.0 warning.
2024 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2025
2026 * fns.c (internal_equal): Don't assume size_t fits in int.
2027
2028 * alloc.c (compact_small_strings): Tighten assertion a little.
2029
2030 Replace pEd with more-general pI, and fix some printf arg casts.
2031 * lisp.h (pI): New macro, generalizing old pEd macro to other
2032 conversion specifiers. For example, use "...%"pI"d..." rather
2033 than "...%"pEd"...".
2034 (pEd): Remove. All uses replaced with similar uses of pI.
2035 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2036 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2037 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2038 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2039 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2040 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2041 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2042 64-bit hosts.
2043 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2044 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2045 * print.c (safe_debug_print, print_object): Likewise.
2046 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2047 to int.
2048 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2049 avoiding the 0 flag, which is not portable.
2050 * process.c (Fmake_network_process): Use pI to avoid cast.
2051 * region-cache.c (pp_cache): Likewise.
2052 * xdisp.c (decode_mode_spec): Likewise.
2053 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2054 behavior on 64-bit hosts with printf arg.
2055 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2056 (x_stop_queuing_selection_requests): Likewise.
2057 (x_get_window_property): Don't truncate byte count to an 'int'
2058 when tracing.
2059
2060 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2061 here, since it parses constructs like leading '-' and spaces,
2062 which are not wanted; and it overflows with large numbers.
2063 Instead, simply match F[0-9]+, which is what is wanted anyway.
2064
2065 * alloc.c: Remove unportable assumptions about struct layout.
2066 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2067 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2068 (allocate_vectorlike, make_pure_vector): Use the new macros,
2069 plus offsetof, to remove unportable assumptions about struct layout.
2070 These assumptions hold on all porting targets that I know of, but
2071 they are not guaranteed, they're easy to remove, and removing them
2072 makes further changes easier.
2073
2074 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2075 This doesn't fix a bug but makes the code clearer.
2076 (string_overrun_cookie): Now const. Use initializers that
2077 don't formally overflow signed char, to avoid warnings.
2078 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2079 can cause Emacs to crash when string overrun checking is enabled.
2080 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2081 multiple of sizeof (EMACS_INT); it need not be, if
2082 alignof(EMACS_INT) < sizeof (EMACS_INT).
2083 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2084
2085 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2086
2087 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2088
2089 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2090
2091 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2092 supposed to be handshaking. (Bug#8556)
2093 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2094
2095 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2096
2097 * lisp.h (Qdebug): List symbol.
2098 * eval.c (Qdebug): Restore global linkage.
2099 * keyboard.c (debug-on-event): New variable.
2100 (handle_user_signal): Break into debugger when debug-on-event
2101 matches the current signal symbol.
2102
2103 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2104
2105 * alloc.c (check_sblock, check_string_bytes)
2106 (check_string_free_list): Convert to standard C.
2107
2108 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2109
2110 * w32.c (emacs_gnutls_push): Fix typo.
2111
2112 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2113
2114 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2115 "cast to pointer from integer of different size".
2116
2117 Improve doprnt and its use in verror. (Bug#8545)
2118 * doprnt.c (doprnt): Document the set of format control sequences
2119 supported by the function. Use SAFE_ALLOCA instead of always
2120 using `alloca'.
2121
2122 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2123 is one byte too soon. Don't use xrealloc; instead xfree and
2124 xmalloc anew.
2125
2126 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2127
2128 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2129 callbacks stage.
2130
2131 * gnutls.c: Renamed global_initialized to
2132 gnutls_global_initialized. Added internals for the
2133 :verify-hostname-error, :verify-error, and :verify-flags
2134 parameters of `gnutls-boot' and documented those parameters in the
2135 docstring. Start callback support.
2136 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2137 unless a fatal error occured. Call gnutls_alert_send_appropriate
2138 on error. Return error code.
2139 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2140 (emacs_gnutls_read): Likewise.
2141 (Fgnutls_boot): Return handshake error code.
2142 (emacs_gnutls_handle_error): New function.
2143 (wsaerror_to_errno): Likewise.
2144
2145 * w32.h (emacs_gnutls_pull): Add prototype.
2146 (emacs_gnutls_push): Likewise.
2147
2148 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2149 (emacs_gnutls_push): Likewise.
2150
2151 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2152
2153 * process.c (wait_reading_process_output): Check if GnuTLS
2154 buffered some data internally if no FDs are set for TLS
2155 connections.
2156
2157 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2158 (LIBS): Link to USER_LIBS.
2159 ($(BLD)/gnutls.$(0)): New target.
2160
2161 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2162
2163 * xdisp.c (handle_single_display_spec): Rename the
2164 display_replaced_before_p argument into display_replaced_p, to
2165 make it consistent with the commentary. Fix typos in the
2166 commentary.
2167
2168 * textprop.c (syms_of_textprop): Remove dead code.
2169 (copy_text_properties): Delete obsolete commentary about an
2170 interface that was deleted long ago. Fix typos in the description
2171 of arguments.
2172
2173 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2174 to changes in oldXMenu/XMenu.h from 2011-04-16.
2175 <menu_help_message, prev_menu_help_message>: Constify.
2176 (IT_menu_make_room): menu->help_text is now `const char **';
2177 adjust.
2178
2179 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2180 to changes in oldXMenu/XMenu.h from 2011-04-16.
2181 (struct XMenu): Declare `help_text' `const char **'.
2182
2183 * xfaces.c <Qunspecified>: Make extern again.
2184
2185 * syntax.c: Include sys/types.h before including regex.h, as
2186 required by Posix.
2187
2188 * doc.c (get_doc_string): Improve the format passed to `error'.
2189
2190 * doprnt.c (doprnt): Improve commentary.
2191
2192 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2193
2194 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2195 them with etags.
2196
2197 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2198 changes in globals.h immediately force recompilation.
2199 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2200 $(CURDIR)/s/ms-w32.h.
2201 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2202
2203 * character.c (Fchar_direction): Function deleted.
2204 (syms_of_character): Don't defsubr it.
2205 <char-direction-table>: Deleted.
2206
2207 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2208
2209 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2210 * doprnt.c: Include limits.h.
2211 (SIZE_MAX): New macro.
2212 (doprnt): Return a size_t value. 2nd arg is now size_t.
2213 Many local variables are now size_t instead of int or unsigned.
2214 Improve overflow protection. Support `l' modifier for integer
2215 conversions. Support %l conversion. Don't assume an EMACS_INT
2216 argument for integer conversions and for %c.
2217
2218 * lisp.h (doprnt): Restore prototype.
2219
2220 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2221 $(SRC)/character.h.
2222
2223 * Makefile.in (base_obj): Add back doprnt.o.
2224
2225 * deps.mk (doprnt.o): Add back prerequisites.
2226 (callint.o): Depend on character.h.
2227
2228 * eval.c (internal_lisp_condition_case): Include the handler
2229 representation in the error message.
2230 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2231 when breaking from the loop.
2232
2233 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2234
2235 * callint.c (Fcall_interactively): When displaying error message
2236 about invalid control letter, pass the character's codepoint, not
2237 a pointer to its multibyte form. Improve display of the character
2238 in octal and display also its hex code.
2239
2240 * character.c (char_string): Use %x to display the (unsigned)
2241 codepoint of an invalid character, to avoid displaying a bogus
2242 negative value.
2243
2244 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2245 `error', not SYMBOL_NAME itself.
2246
2247 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2248 character arguments to `error'.
2249
2250 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2251 to `error' in error message about FINAL_CHAR argument. Make sure
2252 FINAL_CHAR is a character, and use %c when it is passed as
2253 argument to `error'.
2254
2255 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2256
2257 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2258
2259 * w32.c: Include <time.h>.
2260 (sys_localtime): New function.
2261
2262 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2263
2264 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2265
2266 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2267
2268 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2269
2270 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2271 zombies (Bug#8467).
2272
2273 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2274
2275 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2276 gl_state.e_property when gl_state.object is Qt.
2277
2278 * insdel.c (make_gap_larger): Remove limitation of buffer size
2279 to <= INT_MAX.
2280
2281 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2282
2283 * xdisp.c (lookup_glyphless_char_display)
2284 (produce_glyphless_glyph): Handle cons cell entry in
2285 glyphless-char-display.
2286 (Vglyphless_char_display): Document it.
2287
2288 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2289 glyphless-char-display.
2290
2291 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2292
2293 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2294
2295 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2296
2297 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2298 definition for no-X builds.
2299
2300 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2301
2302 Static checks with GCC 4.6.0 and non-default toolkits.
2303
2304 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2305
2306 * process.c (keyboard_bit_set): Define only if SIGIO.
2307 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2308 (send_process): Repair possible setjmp clobbering.
2309
2310 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2311
2312 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2313
2314 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2315
2316 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2317 Define only if needed.
2318
2319 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2320 by pacifying GCC about it. Maybe it's time to retire it?
2321 * xfaces.c (USG, __TIMEVAL__): Likewise.
2322
2323 * dispextern.h (struct redisplay_interface): Rename param
2324 to avoid shadowing.
2325 * termhooks.h (struct terminal): Likewise.
2326 * xterm.c (xembed_send_message): Likewise.
2327
2328 * insdel.c (make_gap_smaller): Define only if
2329 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2330
2331 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2332 it.
2333
2334 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2335 so that we aren't warned about unused symbols.
2336
2337 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2338
2339 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2340
2341 * xfns.c (x_real_positions): Mark locals as initialized.
2342
2343 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2344
2345 * xterm.c: Fix problems found by static analysis with other toolkits.
2346 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2347 (x_dispatch_event): Declare static if USE_GTK, and
2348 define if USE_GTK || USE_X_TOOLKIT.
2349 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2350 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2351 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2352 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2353
2354 * xmenu.c (menu_help_callback): Pointer type fixes.
2355 Use const pointers when pointing at readonly data. Avoid pointer
2356 signedness clashes.
2357 (FALSE): Remove unused macro.
2358 (update_frame_menubar): Remove unused decl.
2359
2360 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2361
2362 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2363 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2364 (single_menu_item): Rename local to avoid shadowing.
2365
2366 * keyboard.c (make_lispy_event): Remove unused local var.
2367
2368 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2369 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2370
2371 * bitmaps: Change bitmaps from unsigned char back to the X11
2372 compatible char. Avoid the old compiler warnings about
2373 out-of-range initializers by using, for example, '\xab' rather
2374 than 0xab.
2375
2376 * xgselect.c (xgselect_initialize): Check vs interface
2377 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2378
2379 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2380
2381 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2382 to read-only memory.
2383
2384 * fns.c (vector): Remove; this old hack is no longer needed.
2385
2386 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2387 Remove unused var.
2388 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2389
2390 * xrdb.c (x_load_resources): Omit unused local.
2391
2392 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2393 (x_window): Rename locals to avoid shadowing.
2394 (USG): Use the kludged USG macro, to pacify gcc.
2395
2396 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2397 (x_term_init): Remove local to avoid shadowing.
2398
2399 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2400
2401 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2402 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2403
2404 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2405
2406 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2407
2408 Fix regex.c, syntax.c and friends for buffers > 2GB.
2409 * syntax.h (struct gl_state_s): Declare character position members
2410 EMACS_INT.
2411
2412 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2413
2414 * textprop.c (verify_interval_modification, interval_of):
2415 Declare arguments EMACS_INT.
2416
2417 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2418 EMACS_INT.
2419
2420 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2421
2422 * indent.c (Fvertical_motion): Local variable it_start is now
2423 EMACS_INT.
2424
2425 * regex.c (re_match, re_match_2, re_match_2_internal)
2426 (bcmp_translate, regcomp, regexec, print_double_string)
2427 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2428 (re_compile_pattern, re_exec): Declare arguments and local
2429 variables `size_t' and `ssize_t' and return values `regoff_t', as
2430 appropriate.
2431 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2432 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2433 <compile_stack_type>: `size' and `avail' are now `size_t'.
2434
2435 * regex.h <regoff_t>: Use ssize_t, not int.
2436 (re_search, re_search_2, re_match, re_match_2): Arguments that
2437 specify buffer/string position and length are now ssize_t and
2438 size_t. Return type is regoff_t.
2439
2440 2011-04-16 Ben Key <bkey76@gmail.com>
2441
2442 * nsfont.m: Fixed bugs in ns_get_family and
2443 ns_descriptor_to_entity that were caused by using free to
2444 deallocate memory blocks that were allocated by xmalloc (via
2445 xstrdup). This caused Emacs to crash when compiled with
2446 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2447 --enable-checking=xmallocoverrun). xfree is now used to
2448 deallocate these memory blocks.
2449
2450 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2451
2452 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2453
2454 emacs_write: Accept and return EMACS_INT for sizes.
2455 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2456 et seq.
2457 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2458 Accept and return EMACS_INT.
2459 (emacs_gnutls_write): Return the number of bytes written on
2460 partial writes.
2461 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2462 (emacs_read, emacs_write): Remove check for negative size, as the
2463 Emacs source code has been audited now.
2464 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2465 (emacs_read, emacs_write): Use it.
2466 * process.c (send_process): Adjust to the new signatures of
2467 emacs_write and emacs_gnutls_write. Do not attempt to store
2468 a byte offset into an 'int'; it might overflow.
2469 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2470
2471 * sound.c: Don't assume sizes fit in 'int'.
2472 (struct sound_device.period_size, alsa_period_size):
2473 Return EMACS_INT, not int.
2474 (struct sound_device.write, vox_write, alsa_write):
2475 Accept EMACS_INT, not int.
2476 (wav_play, au_play): Use EMACS_INT to store sizes and to
2477 record read return values.
2478
2479 2011-04-15 Ben Key <bkey76@gmail.com>
2480
2481 * keyboard.c (Qundefined): Don't declare static since it is used
2482 in nsfns.m.
2483 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2484 static since they are used in nsfont.m.
2485
2486 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2487
2488 * process.c (Qprocessp): Don't declare static.
2489 * lisp.h (Qprocessp): Declare again.
2490
2491 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2492
2493 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2494
2495 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2496
2497 Improve C-level modularity by making more things 'static'.
2498
2499 Don't publish debugger-only interfaces to other modules.
2500 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2501 (verify_bytepos, count_markers): Move decls to the only modules
2502 that need them.
2503 * region-cache.h (pp_cache): Likewise.
2504 * window.h (check_all_windows): Likewise.
2505 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2506
2507 * sysdep.c (croak): Now static, if
2508 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2509 * syssignal.h (croak): Declare only if not static.
2510
2511 * alloc.c (refill_memory_reserve): Now static if
2512 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2513 * lisp.h (refill_memory_reserve): Declare only if not static.
2514
2515 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2516 Define only if USE_LUCID.
2517
2518 * xrdb.c (x_customization_string, x_rm_string): Now static.
2519
2520 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2521 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2522
2523 * xdisp.c (draw_row_with_mouse_face): Now static.
2524 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2525
2526 * window.h (check_all_windows): Mark externally visible.
2527
2528 * window.c (window_deletion_count): Now static.
2529
2530 * undo.c: Make symbols static if they're not exported.
2531 (last_undo_buffer, last_boundary_position, pending_boundary):
2532 Now static.
2533
2534 * textprop.c (interval_insert_behind_hooks): Now static.
2535 (interval_insert_in_front_hooks): Likewise.
2536
2537 * term.c: Make symbols static if they're not exported.
2538 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2539 (max_frame_lines, tty_set_terminal_modes):
2540 (tty_reset_terminal_modes, tty_turn_off_highlight):
2541 (get_tty_terminal): Now static.
2542 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2543 * termhooks.h (term_mouse_moveto): Do not declare if
2544 HAVE_WINDOW_SYSTEM.
2545 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2546 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2547
2548 * sysdep.c: Make symbols static if they're not exported.
2549 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2550 Now static.
2551 (sigprocmask_set, full_mask): Remove; unused.
2552 (wait_debugging): Mark as visible.
2553 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2554 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2555
2556 * syntax.c (syntax_temp): Define only if !__GNUC__.
2557
2558 * sound.c (current_sound_device, current_sound): Now static.
2559
2560 * search.c (searchbufs, searchbuf_head): Now static.
2561
2562 * scroll.c (scroll_cost): Remove; unused.
2563 * dispextern.h (scroll_cost): Remove decl.
2564
2565 * region-cache.h (pp_cache): Mark as externally visible.
2566
2567 * process.c: Make symbols static if they're not exported.
2568 (process_tick, update_tick, create_process, chan_process):
2569 (Vprocess_alist, proc_buffered_char, datagram_access):
2570 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2571 (deactivate_process): Mark defn as static, as well as decl.
2572 * lisp.h (create_process): Remove decl.
2573 * process.h (chan_process, Vprocess_alist): Remove decls.
2574
2575 * print.c: Make symbols static if they're not exported.
2576 (print_depth, new_backquote_output, being_printed, print_buffer):
2577 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2578 (print_interval, print_number_index, initial_stderr_stream):
2579 Now static.
2580 * lisp.h (Fprinc): Remove decl.
2581 (debug_output_compilation_hack): Mark as externally visible.
2582
2583 * sysdep.c (croak): Move decl from here to syssignal.h.
2584 * syssignal.h (croak): Put it here, so the API can be checked when
2585 'croak' is called from dissociate_if_controlling_tty.
2586
2587 * minibuf.c: Make symbols static if they're not exported.
2588 (minibuf_save_list, choose_minibuf_frame): Now static.
2589 * lisp.h (choose_minibuf_frame): Remove decl.
2590
2591 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2592
2593 * lread.c: Make symbols static if they're not exported.
2594 (read_objects, initial_obarray, oblookup_last_bucket_number):
2595 Now static.
2596 (make_symbol): Remove; unused.
2597 * lisp.h (initial_obarray, make_symbol): Remove decls.
2598
2599 * keyboard.c: Make symbols static if they're not exported.
2600 (single_kboard, recent_keys_index, total_keys, recent_keys):
2601 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2602 (this_single_command_key_start, echoing, last_auto_save):
2603 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2604 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2605 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2606 (Vlispy_mouse_stem, double_click_count):
2607 Now static.
2608 (force_auto_save_soon): Define only if SIGDANGER.
2609 (ignore_mouse_drag_p): Now static if
2610 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2611 (print_help): Remove; unused.
2612 (stop_character, last_timer_event): Mark as externally visible.
2613 * keyboard.h (ignore_mouse_drag_p): Declare only if
2614 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2615 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2616 * lisp.h (echoing): Remove decl.
2617 (force_auto_save_soon): Declare only if SIGDANGER.
2618 * xdisp.c (redisplay_window): Simplify code, to make it more
2619 obvious that ignore_mouse_drag_p is not accessed if !defined
2620 USE_GTK && !defined HAVE_NS.
2621
2622 * intervals.c: Make symbols static if they're not exported.
2623 (merge_properties_sticky, merge_interval_right, delete_interval):
2624 Now static.
2625 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2626
2627 * insdel.c: Make symbols static if they're not exported.
2628 However, leave prepare_to_modify_buffer alone. It's never
2629 called from outside this function, but that appears to be a bug.
2630 (combine_after_change_list, combine_after_change_buffer):
2631 (adjust_after_replace, signal_before_change): Now static.
2632 (adjust_after_replace_noundo): Remove; unused.
2633 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2634 (signal_before_change): Remove decls.
2635
2636 * indent.c (val_compute_motion, val_vmotion): Now static.
2637
2638 * image.c: Make symbols static if they're not exported.
2639 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2640 if USE_GTK.
2641 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2642 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2643
2644 * fringe.c (standard_bitmaps): Now static.
2645 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2646
2647 * frame.c: Make symbols static if they're not exported.
2648 (x_report_frame_params, make_terminal_frame): Now static.
2649 (get_frame_param): Now static, unless HAVE_NS.
2650 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2651 (x_get_resource_string): Remove; not used.
2652 * frame.h (make_terminal_frame, x_report_frame_params):
2653 (x_get_resource_string); Remove decls.
2654 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2655 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2656
2657 * font.c, fontset.c: Make symbols static if they're not exported.
2658 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2659 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2660 * font.c (font_close_object): Now static.
2661 * font.h (font_close_object): Remove.
2662 * fontset.c (FONTSET_OBJLIST): Remove.
2663 (free_realized_fontset) #if-0 the body, which does nothing.
2664 (face_suitable_for_char_p): #if-0, as it's never called.
2665 * fontset.h (face_suitable_for_char_p): Remove decl.
2666 * xfaces.c (face_at_string_position):
2667 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2668 since 0 is always ASCII.
2669
2670 * fns.c (weak_hash_tables): Now static.
2671
2672 * fileio.c: Make symbols static if they're not exported.
2673 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2674 (Vwrite_region_annotation_buffers): Now static.
2675
2676 * eval.c: Make symbols static if they're not exported.
2677 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2678 * lisp.h (backtrace_list): Remove decl.
2679
2680 * emacs.c: Make symbols static if they're not exported.
2681 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2682 (fatal_error_code, fatal_error_signal_hook, standard_args):
2683 Now static.
2684 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2685 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2686 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2687 * lisp.h (fatal_error_signal_hook): Remove decl.
2688 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2689
2690 * editfns.c: Move a (normally-unused) function to its only use.
2691 * editfns.c, lisp.h (get_operating_system_release): Remove.
2692 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2693 worth the hassle of breaking this out.
2694
2695 * xterm.c: Make symbols static if they're not exported.
2696 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2697 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2698 (x_destroy_window, x_delete_display):
2699 Now static.
2700 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2701 (x_mouse_leave): Remove; unused.
2702 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2703 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2704 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2705 Remove decls.
2706 (x_mouse_leave): Declare only if WINDOWSNT.
2707 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2708 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2709 USE_X_TOOLKIT.
2710
2711 * ftxfont.c: Make symbols static if they're not exported.
2712 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2713 HAVE_FREETYPE.
2714 * font.h (ftxfont_driver): Likewise.
2715
2716 * xfns.c: Make symbols static if they're not exported.
2717 (x_last_font_name, x_display_info_for_name):
2718 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2719 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2720 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2721 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2722 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2723 (last_show_tip_args): Now static.
2724 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2725 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2726 (x_screen_planes): Remove; unused.
2727 * dispextern.h (x_screen_planes): Remove decl.
2728
2729 * dispnew.c: Make symbols static if they're not exported.
2730 * dispextern.h (redraw_garbaged_frames, scrolling):
2731 (increment_row_positions): Remove.
2732 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2733 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2734 Now static.
2735 (redraw_garbaged_frames): Remove; unused.
2736
2737 * xfaces.c: Make symbols static if they're not exported.
2738 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2739 Remove decls.
2740 * xterm.h (defined_color): Remove decls.
2741 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2742 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2743 (menu_face_changed_default, defined_color, free_realized_face):
2744 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2745 (ascii_face_of_lisp_face): Remove; unused.
2746
2747 * xdisp.c: Make symbols static if they're not exported.
2748 * dispextern.h (scratch_glyph_row, window_box_edges):
2749 (glyph_to_pixel_coords, set_cursor_from_row):
2750 (get_next_display_element, set_iterator_to_next):
2751 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2752 (show_mouse_face): Remove decls
2753 * frame.h (message_buf_print): Likewise.
2754 * lisp.h (pop_message, set_message, check_point_in_composition):
2755 Likewise.
2756 * xterm.h (set_vertical_scroll_bar): Likewise.
2757 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2758 (message_buf_print, scratch_glyph_row, displayed_buffer):
2759 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2760 (get_next_display_element, show_mouse_face, window_box_edges):
2761 (frame_to_window_pixel_xy, check_point_in_composition):
2762 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2763 (glyph_to_pixel_coords): Remove; unused.
2764
2765 * dired.c (file_name_completion): Now static.
2766
2767 * dbusbind.c (xd_in_read_queued_messages): Now static.
2768
2769 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2770 * data.c (circular_list_error): Remove.
2771
2772 * commands.h (last_point_position, last_point_position_buffer):
2773 (last_point_position_window): Remove decls.
2774 * keyboard.c: Make these variables static.
2775
2776 * coding.h (coding, code_convert_region, encode_coding_gap):
2777 Remove decls.
2778 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2779 (iso_code_class, detect_coding, code_convert_region): Now static.
2780 (encode_coding_gap): Remove; unused.
2781
2782 * chartab.c (chartab_chars, chartab_bits): Now static.
2783
2784 * charset.h (charset_iso_8859_1): Remove decl.
2785 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2786 Now static.
2787
2788 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2789 * ccl.c (Vccl_program_table): Now static.
2790 (check_ccl_update): Remove; unused.
2791
2792 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2793 * category.h: ... from here.
2794 * category.c (check_category_table, set_category_set): Now static.
2795
2796 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2797 * lisp.h: Remove these decls.
2798
2799 * buffer.c (buffer_count): Remove unused var.
2800
2801 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2802 so that it's not optimized away.
2803 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2804 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2805 exported only to the debugger.
2806
2807 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2808 * atimer.h (run_all_atimers): Remove; not exported.
2809
2810 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2811 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2812 was inaccessible from Lisp.
2813 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2814 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2815
2816 alloc.c: Import and export fewer symbols, and remove unused items.
2817 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2818 is defined.
2819 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2820 it's not optimized away by whole-program optimization.
2821 (message_enable_multibyte, free_misc): Remove.
2822 (catchlist, handlerlist, mark_backtrace):
2823 Declare only if BYTE_MARK_STACK.
2824 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2825 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2826 (message_enable_multibyte): Remove decl.
2827 (free_misc, interval_free_list, float_block, float_block_index):
2828 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2829 (cons_free_list, last_marked_index):
2830 Now static.
2831 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2832 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2833 (mark_backtrace): Define only if BYTE_MARK_STACK.
2834 * xdisp.c (message_enable_multibyte): Now static.
2835
2836 Declare Lisp_Object Q* variables to be 'static' if not exported.
2837 This makes it easier for human readers (and static analyzers)
2838 to see whether these variables are used from other modules.
2839 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2840 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2841 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2842 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2843 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2844 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2845 * xmenu.c, xselect.c:
2846 Declare Q* vars static if they are not used in other modules.
2847 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2848 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2849 Remove decls of unexported vars.
2850 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2851
2852 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2853
2854 Make Emacs functions such as Fatom 'static' by default.
2855 This makes it easier for human readers (and static analyzers)
2856 to see whether these functions can be called from other modules.
2857 DEFUN now defines a static function. To make the function external
2858 so that it can be used in other C modules, use the new macro DEFUE.
2859 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2860 (Finit_image_library):
2861 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2862 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2863 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2864 Remove decls, since these functions are now static.
2865 (Funintern, Fget_internal_run_time): New decls, since these functions
2866 were already external.
2867
2868 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2869 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2870 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2871 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2872 * keyboard.c, keymap.c, lread.c:
2873 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2874 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2875 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2876 Mark functions with DEFUE instead of DEFUN,
2877 if they are used in other modules.
2878 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2879 decls for now-static functions.
2880 * buffer.h (Fdelete_overlay): Remove decl.
2881 * callproc.c (Fgetenv_internal): Mark as internal.
2882 * composite.c (Fremove_list_of_text_properties): Remove decl.
2883 (Fcomposition_get_gstring): New forward static decl.
2884 * composite.h (Fcomposite_get_gstring): Remove decl.
2885 * dired.c (Ffile_attributes): New forward static decl.
2886 * doc.c (Fdocumntation_property): New forward static decl.
2887 * eval.c (Ffetch_bytecode): New forward static decl.
2888 (Funintern): Remove extern decl; now in .h file where it belongs.
2889 * fileio.c (Fmake_symbolic_link): New forward static decl.
2890 * image.c (Finit_image_library): New forward static decl.
2891 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2892 * intervals.h (Fprevious_property_change):
2893 (Fremove_list_of_text_properties): Remove decls.
2894 * keyboard.c (Fthis_command_keys): Remove decl.
2895 (Fcommand_execute): New forward static decl.
2896 * keymap.c (Flookup_key): New forward static decl.
2897 (Fcopy_keymap): Now static.
2898 * keymap.h (Flookup_key): Remove decl.
2899 * process.c (Fget_process): New forward static decl.
2900 (Fprocess_datagram_address): Mark as internal.
2901 * syntax.c (Fsyntax_table_p): New forward static decl.
2902 (skip_chars): Remove duplicate decl.
2903 * textprop.c (Fprevious_property_change): New forward static decl.
2904 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2905 Now internal.
2906 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2907 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2908
2909 * editfns.c (Fformat): Remove unreachable code.
2910
2911 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2912
2913 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2914 change. (Bug#8496)
2915
2916 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2917
2918 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2919 when at ZV. (Bug#8487)
2920
2921 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2922
2923 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2924 (Bug#8437)
2925 * keyboard.c (parse_tool_bar_item): Likewise.
2926 * sound.c (sound_cleanup, alsa_close): Likewise.
2927 * termcap.c (tgetent): Likewise.
2928 * xfns.c (x_default_font_parameter): Likewise.
2929 * xsettings.c (read_and_apply_settings): Likewise.
2930
2931 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2932 (overrun_check_free): Protoize.
2933
2934 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2935
2936 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2937 since callers should never pass a negative size.
2938 Change the signature to match that of plain 'read' and 'write'; see
2939 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2940 * lisp.h: Update prototypes of emacs_write and emacs_read.
2941
2942 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2943
2944 * xdisp.c (redisplay_window): Don't try to determine the character
2945 position of the scroll margin if the window start point w->startp
2946 is outside the buffer's accessible region. (Bug#8468)
2947
2948 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2949
2950 Fix write-region and its subroutines for buffers > 2GB.
2951 * fileio.c (a_write, e_write): Modify declaration of arguments and
2952 local variables to support buffers larger than 2GB.
2953 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2954
2955 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2956 argument, local variables, and return value.
2957
2958 * lisp.h: Update prototypes of emacs_write and emacs_read.
2959
2960 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2961
2962 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2963
2964 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2965
2966 Fix more problems found by GCC 4.6.0's static checks.
2967
2968 * xdisp.c (vmessage): Use a better test for character truncation.
2969
2970 * charset.c (load_charset_map): <, not <=, for optimization,
2971 and to avoid potential problems with integer overflow.
2972 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2973 * casetab.c (set_identity, shuffle): Likewise.
2974 * editfns.c (Fformat): Likewise.
2975 * syntax.c (skip_chars): Likewise.
2976
2977 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2978 This also lets GCC 4.6.0 generate slightly better loop code.
2979
2980 * callint.c (Fcall_interactively): <, not <=, for optimization.
2981 (Fcall_interactively): Count the number of arguments produced,
2982 not the number of arguments given. This is simpler and lets GCC
2983 4.6.0 generate slightly better code.
2984
2985 * ftfont.c: Distingish more carefully between FcChar8 and char.
2986 The previous code passed unsigned char * to a functions like
2987 strlen and xstrcasecmp that expect char *, which does not
2988 conform to the C standard.
2989 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2990 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2991 char * when the C standard requires it.
2992
2993 * keyboard.c (read_char): Remove unused var.
2994
2995 * eval.c: Port to Windows vsnprintf (Bug#8435).
2996 Include <limits.h>.
2997 (SIZE_MAX): Define if the headers do not.
2998 (verror): Do not give up if vsnprintf returns a negative count.
2999 Instead, grow the buffer. This ports to Windows vsnprintf, which
3000 does not conform to C99. Problem reported by Eli Zaretskii.
3001 Also, simplify the allocation scheme, by avoiding the need for
3002 calling realloc, and removing the ALLOCATED variable.
3003
3004 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3005
3006 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3007 But keep the doprint source code for now, as we might revamp it
3008 and use it again (Bug#8435).
3009 * lisp.h (doprnt): Remove.
3010 * Makefile.in (base_obj): Remove doprnt.o.
3011 * deps.mk (doprnt.o): Remove.
3012
3013 error: Print 32- and 64-bit integers portably (Bug#8435).
3014 Without this change, on typical 64-bit hosts error ("...%d...", N)
3015 was used to print both 32- and 64-bit integers N, which relied on
3016 undefined behavior.
3017 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3018 New macro.
3019 * lisp.h (error, verror): Mark as printf-like functions.
3020 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3021 Report overflow in size calculations when allocating printf buffer.
3022 Do not truncate output string at its first null byte.
3023 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3024 Truncate the output at a character boundary, since vsnprintf does not
3025 do that.
3026 * charset.c (check_iso_charset_parameter): Convert internal
3027 character to string before calling 'error', since %c now has the
3028 printf meaning.
3029 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3030 overflow when computing char to be passed to 'error'. Do not
3031 pass Lisp_Object to 'error'; pass the integer instead.
3032 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3033 formatted with plain %d.
3034
3035 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3036
3037 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3038
3039 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3040
3041 * xterm.c (x_catch_errors): Remove duplicate declaration.
3042
3043 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3044
3045 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3046
3047 2011-04-10 Jim Meyering <meyering@redhat.com>
3048
3049 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3050 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3051 return ssize_t not "int", and use size_t as the buffer length.
3052 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3053 * gnutls.h: Update declarations.
3054 * process.c (read_process_output): Use ssize_t, to match.
3055 (send_process): Likewise.
3056
3057 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3058
3059 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3060
3061 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3062
3063 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3064 Use unsigned char, to match FcChar8 type definition.
3065
3066 * xterm.c (handle_one_xevent):
3067 * xmenu.c (create_and_show_popup_menu):
3068 * xselect.c (x_decline_selection_request)
3069 (x_reply_selection_request): Avoid type-punned deref of X events.
3070
3071 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3072
3073 Fix some uses of `int' instead of EMACS_INT.
3074 * search.c (string_match_1, fast_string_match)
3075 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3076 (scan_buffer, find_next_newline_no_quit)
3077 (find_before_next_newline, search_command, Freplace_match)
3078 (Fmatch_data): Make some `int' variables be EMACS_INT.
3079
3080 * xdisp.c (display_count_lines): 3rd argument and return value now
3081 EMACS_INT. All callers changed.
3082 (pint2hrstr): Last argument is now EMACS_INT.
3083
3084 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3085 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3086 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3087 (decode_coding_utf_16, decode_coding_emacs_mule)
3088 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3089 (decode_coding_ccl, decode_coding_charset)
3090 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3091 (decode_coding_iso_2022, decode_coding_emacs_mule)
3092 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3093 <char_offset, last_offset>: Declare EMACS_INT.
3094 (encode_coding_utf_8, encode_coding_utf_16)
3095 (encode_coding_emacs_mule, encode_invocation_designation)
3096 (encode_designation_at_bol, encode_coding_iso_2022)
3097 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3098 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3099 Declare EMACS_INT.
3100 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3101 (encode_invocation_designation): Last argument P_NCHARS is now
3102 EMACS_INT.
3103 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3104 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3105
3106 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3107 All users changed.
3108
3109 * ccl.c (Fccl_execute_on_string): Declare some variables
3110 EMACS_INT.
3111
3112 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3113
3114 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3115
3116 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3117
3118 * process.c (Fformat_network_address): Doc fix.
3119
3120 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3121
3122 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3123
3124 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3125
3126 * keyboard.c (read_char): Call Lisp function help-form-show,
3127 instead of using internal_with_output_to_temp_buffer.
3128 (Qhelp_form_show): New var.
3129 (syms_of_keyboard): Use DEFSYM macro.
3130
3131 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3132
3133 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3134
3135 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3136
3137 * process.c (Flist_processes): Remove to Lisp.
3138 (list_processes_1): Delete.
3139
3140 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3141
3142 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3143
3144 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3145
3146 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3147
3148 Fix more problems found by GCC 4.6.0's static checks.
3149
3150 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3151
3152 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3153
3154 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3155
3156 * xdisp.c (vmessage): Mark as a printf-like function.
3157
3158 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3159
3160 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3161
3162 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3163 printf-like functions.
3164 (tiff_load): Add casts to remove these marks before passing them
3165 to system-supplied API.
3166
3167 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3168
3169 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3170 This avoids several warnings with gcc -Wstrict-overflow.
3171 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3172 directly, rather than having caller test rule sign. This avoids
3173 some unnecessary tests.
3174 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3175 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3176 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3177
3178 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3179 (xfont_open): Avoid unnecessary tests.
3180
3181 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3182
3183 * composite.h, composite.c (composition_gstring_put_cache):
3184 Use EMACS_INT, not int, for length.
3185
3186 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3187 breaking out part of COMPOSITION_DECODE_RULE.
3188 (COMPOSITION_DECODE_RULE): Use it.
3189 * composite.c (get_composition_id): Remove unused local vars,
3190 by using the new macro.
3191
3192 * textprop.c (set_text_properties_1): Change while to do-while,
3193 since the condition is always true at first.
3194
3195 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3196 (interval_deletion_adjustment): Return unsigned value.
3197 All uses changed.
3198
3199 * process.c (list_processes_1, create_pty, read_process_output):
3200 (exec_sentinel): Remove vars that were set but not used.
3201 (create_pty): Remove unnecessary "volatile"s.
3202 (Fnetwork_interface_info): Avoid possibility of int overflow.
3203 (read_process_output): Do adaptive read buffering even if carryover.
3204 (read_process_output): Simplify nbytes computation if buffered.
3205
3206 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3207
3208 * syntax.c (scan_words): Remove var that was set but not used.
3209 (update_syntax_table): Use unsigned instead of int.
3210
3211 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3212 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3213 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3214
3215 * print.c (print_error_message): Avoid int overflow.
3216
3217 * font.c (font_list_entities): Redo for clarity,
3218 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3219
3220 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3221 (font_score): Avoid potential overflow in diff calculation.
3222
3223 * fns.c (substring_both): Remove var that is set but not used.
3224 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3225
3226 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3227
3228 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3229 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3230 can always succeed if overflow has undefined behavior.
3231
3232 * search.c (boyer_moore, wordify): Remove vars set but not used.
3233 (wordify): Omit three unnecessary tests.
3234
3235 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3236 All callers changed. This avoids the need for an unused var.
3237
3238 * casefiddle.c (casify_region): Remove var that is set but not used.
3239
3240 * dired.c (file_name_completion): Remove var that is set but not used.
3241
3242 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3243
3244 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3245 (Finsert_file_contents): Remove unnecessary code checking fd.
3246
3247 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3248 Check for integer overflow on size calculations.
3249
3250 * buffer.c (Fprevious_overlay_change): Remove var that is set
3251 but not used.
3252
3253 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3254 Remove vars that are set but not used.
3255 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3256 (timer_check_2): Mark vars as initialized.
3257
3258 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3259
3260 * image.c (lookup_image): Remove var that is set but not used.
3261 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3262
3263 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3264 that are set but not used.
3265
3266 * xfns.c (make_invisible_cursor): Don't return garbage
3267 if XCreateBitmapFromData fails (Bug#8410).
3268
3269 * xselect.c (x_get_local_selection, x_handle_property_notify):
3270 Remove vars that are set but not used.
3271
3272 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3273 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3274
3275 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3276 Remove var that is set but not used.
3277 (scroll_bar_windows_size): Now size_t, not int.
3278 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3279 Check for overflow.
3280
3281 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3282 (map_tty_color) [!defined MSDOS]: Likewise.
3283
3284 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3285
3286 * coding.c: Remove vars that are set but not used.
3287 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3288 All callers changed.
3289 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3290 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3291 (decode_coding_charset): Remove vars that are set but not used.
3292
3293 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3294 that is set but not used.
3295
3296 * print.c (print_object): Remove var that is set but not used.
3297
3298 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3299 The gnulib version avoids calling malloc in the usual case,
3300 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3301 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3302 * filelock.c (current_lock_owner): Likewise.
3303 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3304 * sysdep.c: Include allocator.h, careadlinkat.h.
3305 (emacs_no_realloc_allocator): New static constant.
3306 (emacs_readlink): New function.
3307 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3308 ../lib/careadlinkat.h.
3309
3310 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3311
3312 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3313 first non-nil return value).
3314
3315 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3316
3317 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3318 if not defined (Bug#8403).
3319
3320 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3321
3322 * xdisp.c (display_count_lines): Remove parameter `start',
3323 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3324 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3325 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3326 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3327 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3328 and thereabouts. All callers changed.
3329 (get_per_char_metric): Remove parameter `f', unused since
3330 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3331
3332 2011-04-02 Jim Meyering <meyering@redhat.com>
3333
3334 do not dereference NULL upon failed strdup
3335 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3336 (ns_get_family): Likewise.
3337
3338 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3339
3340 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3341
3342 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3343
3344 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3345 later (Bug#8403).
3346
3347 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3348
3349 Add lexical binding.
3350
3351 * window.c (Ftemp_output_buffer_show): New fun.
3352 (Fsave_window_excursion):
3353 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3354
3355 * lread.c (lisp_file_lexically_bound_p): New function.
3356 (Fload): Bind Qlexical_binding.
3357 (readevalloop): Remove `evalfun' arg.
3358 Bind Qinternal_interpreter_environment.
3359 (Feval_buffer): Bind Qlexical_binding.
3360 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3361 Mark as dynamic.
3362 (syms_of_lread): Declare `lexical-binding'.
3363
3364 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3365
3366 * keyboard.c (eval_dyn): New fun.
3367 (menu_item_eval_property): Use it.
3368
3369 * image.c (parse_image_spec): Use Ffunctionp.
3370
3371 * fns.c (concat, mapcar1): Accept byte-code-functions.
3372
3373 * eval.c (Fsetq): Handle lexical vars.
3374 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3375 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3376 (FletX, Flet): Obey lexical binding.
3377 (Fcommandp): Handle closures.
3378 (Feval): New `lexical' arg.
3379 (eval_sub): New function extracted from Feval. Use it almost
3380 everywhere where Feval was used. Look up vars in lexical env.
3381 Handle closures.
3382 (Ffunctionp): Move from subr.el.
3383 (Ffuncall): Handle closures.
3384 (apply_lambda): Remove `eval_flags'.
3385 (funcall_lambda): Handle closures and new byte-code-functions.
3386 (Fspecial_variable_p): New function.
3387 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3388 but without exporting it to Lisp.
3389
3390 * doc.c (Fdocumentation, store_function_docstring):
3391 * data.c (Finteractive_form): Handle closures.
3392
3393 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3394 interactive spec.
3395
3396 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3397 New byte-codes.
3398 (exec_byte_code): New function extracted from Fbyte_code to handle new
3399 calling convention for byte-code-functions. Add new byte-codes.
3400
3401 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3402
3403 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3404
3405 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3406
3407 * xdisp.c (redisplay_internal): Fix prototype.
3408
3409 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3410
3411 * xdisp.c (SCROLL_LIMIT): New macro.
3412 (try_scrolling): Use it when setting scroll_limit.
3413 Limit scrolling to 100 screen lines.
3414 (redisplay_window): Even when falling back on "recentering",
3415 position point in the window according to scroll-conservatively,
3416 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3417
3418 (try_scrolling): When point is above the window, allow searching
3419 as far as scroll_max, or one screenful, to compute vertical
3420 distance from PT to the scroll margin position. This prevents
3421 try_scrolling from unnecessarily failing when
3422 scroll-conservatively is set to a value slightly larger than the
3423 window height. Clean up the case of PT below the margin at bottom
3424 of window: scroll_max can no longer be INT_MAX. When aggressive
3425 scrolling is in use, don't let point enter the opposite scroll
3426 margin as result of the scroll.
3427 (syms_of_xdisp) <scroll-conservatively>: Document the
3428 threshold of 100 lines for never-recentering scrolling.
3429
3430 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3431
3432 * dispextern.h (move_it_by_lines):
3433 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3434 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3435 (message_log_check_duplicate): Remove parameters `prev_bol' and
3436 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3437 (redisplay_internal): Remove parameter `preserve_echo_area',
3438 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3439
3440 * indent.c (Fvertical_motion):
3441 * window.c (window_scroll_pixel_based, Frecenter):
3442 Don't pass `need_y_p' to `move_it_by_lines'.
3443
3444 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3445
3446 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3447 steal a few bits to be more compact.
3448 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3449 Remove unneeded casts.
3450
3451 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3452
3453 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3454
3455 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3456 binding" message (bug#7967).
3457
3458 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3459
3460 Fix more problems found by GCC 4.6.0's static checks.
3461
3462 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3463 Remove unused local var.
3464
3465 * editfns.c (Fmessage_box): Remove unused local var.
3466
3467 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3468 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3469 Omit unused local vars.
3470 * window.c (shrink_windows): Omit unused local var.
3471 * menu.c (digest_single_submenu): Omit unused local var.
3472 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3473 Omit unused local var.
3474
3475 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3476 Don't assume string length fits in int.
3477 (keyremap_step, read_key_sequence): Use size_t for sizes.
3478 (read_key_sequence): Don't check last_real_key_start redundantly.
3479
3480 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3481 instead of alloca (Bug#8344).
3482
3483 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3484 (Fbacktrace_frame): Don't assume nframes fits in int.
3485
3486 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3487
3488 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3489 concerns.
3490
3491 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3492
3493 * cm.c (calccost): Turn while-do into do-while, for clarity.
3494
3495 * keyboard.c (syms_of_keyboard): Use the same style as later
3496 in this function when indexing through an array. This also
3497 works around GCC bug 48267.
3498
3499 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3500
3501 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3502
3503 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3504 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3505
3506 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3507 This avoids undefined behavior on integer overflow, and is a bit
3508 more convenient anyway since it is compared to a size_t variable.
3509
3510 Variadic C functions now count arguments with size_t, not int.
3511 This avoids an unnecessary limitation on 64-bit machines, which
3512 caused (substring ...) to crash on large vectors (Bug#8344).
3513 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3514 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3515 All variadic functions and their callers changed accordingly.
3516 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3517 * data.c (arith_driver, float_arith_driver): Likewise.
3518 * editfns.c (general_insert_function): Likewise.
3519 * eval.c (struct backtrace.nargs, interactive_p)
3520 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3521 (funcall_lambda, mark_backtrace): Likewise.
3522 * fns.c (concat): Likewise.
3523 * frame.c (x_set_frame_parameters): Likewise.
3524 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3525 0 if not found, not -1. All callers changed.
3526
3527 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3528 (stack_copy_size): Now size_t, not int.
3529 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3530
3531 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3532
3533 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3534 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3535 All callers changed.
3536
3537 * lisp.h (multibyte_char_to_unibyte):
3538 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3539 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3540 * character.h (CHAR_TO_BYTE8):
3541 * cmds.c (internal_self_insert):
3542 * editfns.c (general_insert_function):
3543 * keymap.c (push_key_description):
3544 * search.c (Freplace_match):
3545 * xdisp.c (message_dolog, set_message_1): All callers changed.
3546
3547 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3548
3549 * keyboard.c (safe_run_hook_funcall): New function.
3550 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3551 don't set the hook to nil, but remove the offending function instead.
3552 (Qcommand_hook_internal): Remove, unused.
3553 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3554 Vcommand_hook_internal.
3555
3556 * eval.c (enum run_hooks_condition): Remove.
3557 (funcall_nil, funcall_not): New functions.
3558 (run_hook_with_args): Call each function through a `funcall' argument.
3559 Remove `cond' argument, now redundant.
3560 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3561 (Frun_hook_with_args_until_failure): Adjust accordingly.
3562 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3563
3564 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3565
3566 * dispextern.h (string_buffer_position): Remove declaration.
3567
3568 * print.c (strout): Remove parameter `multibyte', unused since
3569 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3570
3571 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3572 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3573 All callers changed.
3574
3575 * w32.c (_wsa_errlist): Use braces for struct initializers.
3576
3577 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3578 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3579 All callers changed.
3580 (string_buffer_position): Likewise. Also, make static (it's never
3581 used outside xdisp.c).
3582 (cursor_row_p): Remove parameter `w', unused since
3583 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3584 (decode_mode_spec): Remove parameter `precision', introduced during
3585 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3586 All callers changed.
3587
3588 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3589
3590 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3591
3592 2011-03-27 Anders Lindgren <andlind@gmail.com>
3593
3594 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3595 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3596 (ns_update_auto_hide_menu_bar): New functions.
3597 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3598 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3599 ns_constrain_all_frames.
3600 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3601 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3602
3603 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3604
3605 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3606
3607 2011-03-27 Glenn Morris <rgm@gnu.org>
3608
3609 * syssignal.h: Replace RETSIGTYPE with void.
3610 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3611 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3612 Replace SIGTYPE with void everywhere.
3613 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3614 * s/template.h (SIGTYPE): Remove commented out definition.
3615
3616 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3617
3618 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3619 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3620
3621 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3622
3623 * w32.c (read_unc_volume): Use parameter `henum', instead of
3624 global variable `wget_enum_handle'.
3625
3626 * keymap.c (describe_vector): Remove parameters `indices' and
3627 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3628 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3629
3630 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3631
3632 * keyboard.c (timer_check): Remove parameter `do_it_now',
3633 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3634 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3635 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3636
3637 * keyboard.c (read_char):
3638 * w32menu.c (w32_menu_display_help):
3639 * xmenu.c (show_help_event, menu_help_callback):
3640 Adjust calls to `show_help_echo'.
3641
3642 * gtkutil.c (xg_maybe_add_timer):
3643 * keyboard.c (readable_events):
3644 * process.c (wait_reading_process_output):
3645 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3646
3647 * insdel.c (adjust_markers_gap_motion):
3648 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3649 (gap_left, gap_right): Don't call it.
3650
3651 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3652
3653 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3654 incurred during fontification.
3655
3656 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3657
3658 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3659 (DEFVAR_PER_BUFFER): Don't pass it.
3660
3661 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3662 (scrolling_window): Don't pass it.
3663
3664 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3665
3666 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3667
3668 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3669 and `suffix'.
3670 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3671 of variables specific to SELinux and computation of `encoded_absname'.
3672
3673 * image.c (XPutPixel): Remove unused variable `height'.
3674
3675 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3676
3677 * unexw32.c (get_section_info): Remove unused variable `section'.
3678
3679 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3680 (system_process_attributes): Remove unused variable `sess'.
3681 (sys_read): Remove unused variable `err'.
3682
3683 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3684 (w32_wnd_proc): Remove unused variable `isdead'.
3685 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3686 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3687 (x_create_tip_frame): Remove unused variable `tem'.
3688
3689 * w32inevt.c (w32_console_read_socket):
3690 Remove unused variable `no_events'.
3691
3692 * w32term.c (x_draw_composite_glyph_string_foreground):
3693 Remove unused variable `width'.
3694
3695 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3696
3697 * w32term.c (x_set_glyph_string_clipping):
3698 Don't pass uninitialized region to CombineRgn.
3699
3700 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3701
3702 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3703 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3704 (Fx_close_connection): Remove unused variable `i'.
3705
3706 * w32font.c (w32font_draw): Return number of glyphs.
3707 (w32font_open_internal): Remove unused variable `i'.
3708 (w32font_driver): Add missing initializer.
3709
3710 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3711 (fill_in_menu): Remove unused variable `items_added'.
3712
3713 * w32term.c (last_mouse_press_frame): Remove static global variable.
3714 (w32_clip_to_row): Remove unused variable `f'.
3715 (x_delete_terminal): Remove unused variable `i'.
3716
3717 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3718 (NOTHING): Remove unused static global variable.
3719 (uniscribe_check_otf): Remove unused variable `table'.
3720 (uniscribe_font_driver): Add missing initializers.
3721
3722 2011-03-23 Julien Danjou <julien@danjou.info>
3723
3724 * term.c (Fsuspend_tty, Fresume_tty):
3725 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3726 * window.c (temp_output_buffer_show):
3727 * insdel.c (signal_before_change):
3728 * frame.c (Fhandle_switch_frame):
3729 * fileio.c (Fdo_auto_save):
3730 * emacs.c (Fkill_emacs):
3731 * editfns.c (save_excursion_restore):
3732 * cmds.c (internal_self_insert):
3733 * callint.c (Fcall_interactively):
3734 * buffer.c (Fkill_all_local_variables):
3735 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3736 Use Frun_hooks.
3737 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3738 unconditionnaly since it does the check itself.
3739
3740 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3741
3742 Fix more problems found by GCC 4.5.2's static checks.
3743
3744 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3745 the first time through the loop, since we know p0 < p1 then.
3746 This also avoids a gcc -Wstrict-overflow warning.
3747
3748 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3749 leading to a memory leak, possible in functions like
3750 load_charset_map_from_file that can allocate an unbounded number
3751 of objects (Bug#8318).
3752
3753 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3754 that could (at least in theory) be that large.
3755
3756 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3757 This is less likely to overflow, and avoids undefined behavior if
3758 overflow does occur. All callers changed. Use strtoul to scan
3759 for the unsigned long integer.
3760 (pint2hrstr): Simplify and tune code slightly.
3761 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3762
3763 * scroll.c (do_scrolling): Work around GCC bug 48228.
3764 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3765
3766 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3767 This also avoids a warning with gcc -Wstrict-overflow.
3768 (validate_x_resource_name): Simplify count usage.
3769 This also avoids a warning with gcc -Wstrict-overflow.
3770
3771 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3772 fail (Bug#8306).
3773
3774 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3775
3776 * process.c (Fmake_network_process): Use socklen_t, not int,
3777 where POSIX says socklen_t is required in portable programs.
3778 This fixes a porting bug on hosts like 64-bit HP-UX, where
3779 socklen_t is wider than int (Bug#8277).
3780 (Fmake_network_process, server_accept_connection):
3781 (wait_reading_process_output, read_process_output):
3782 Likewise.
3783
3784 * process.c: Rename or move locals to avoid shadowing.
3785 (list_processes_1, Fmake_network_process):
3786 (read_process_output_error_handler, exec_sentinel_error_handler):
3787 Rename or move locals.
3788 (Fmake_network_process): Define label "retry_connect" only if needed.
3789 (Fnetwork_interface_info): Fix pointer signedness.
3790 (process_send_signal): Add cast to avoid pointer signedness problem.
3791 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3792 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3793
3794 Make tparam.h and terminfo.c consistent.
3795 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3796 Include tparam.h instead, since it declares them.
3797 * cm.h (PC): Remove extern decl; tparam.h now does this.
3798 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3799 * terminfo.c: Include tparam.h, to check interfaces.
3800 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3801 (tparam): Adjust signature to match interface in tparam.h;
3802 this removes some undefined behavior. Check that outstring and len
3803 are zero, which they always are with Emacs.
3804 * tparam.h (PC, BC, UP): New extern decls.
3805
3806 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3807 (xftfont_open): Rename locals to avoid shadowing.
3808
3809 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3810 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3811 (OTF_TAG_SYM): Omit macro if not needed.
3812 (ftfont_list): Remove unused local.
3813 (get_adstyle_property, ftfont_pattern_entity):
3814 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3815 Rename locals to avoid shadowing.
3816
3817 * xfont.c (xfont_list_family): Mark var as initialized.
3818
3819 * xml.c (make_dom): Now static.
3820
3821 * composite.c (composition_compute_stop_pos): Rename local to
3822 avoid shadowing.
3823 (composition_reseat_it): Remove unused locals.
3824 (find_automatic_composition, composition_adjust_point): Likewise.
3825 (composition_update_it): Mark var as initialized.
3826 (find_automatic_composition): Mark vars as initialized,
3827 with a FIXME (Bug#8290).
3828
3829 character.h: Rename locals to avoid shadowing.
3830 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3831 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3832 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3833 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3834 to avoid shadowing.
3835
3836 * textprop.c (property_change_between_p): Remove; unused.
3837
3838 * intervals.c (interval_start_pos): Now static.
3839
3840 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3841
3842 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3843 Rename locals to avoid shadowing.
3844
3845 * sound.c (wav_play, au_play, Fplay_sound_internal):
3846 Fix pointer signedness.
3847 (alsa_choose_format): Remove unused local var.
3848 (wav_play): Initialize a variable to 0, to prevent undefined
3849 behavior (Bug#8278).
3850
3851 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3852
3853 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3854
3855 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3856 clobbering (Bug#8298).
3857 * sysdep.c (sys_subshell): Likewise.
3858 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3859
3860 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3861 This should get cleaned up, so that child_setup has the
3862 same signature on all platforms.
3863
3864 * callproc.c (call_process_cleanup): Now static.
3865 (relocate_fd): Rename locals to avoid shadowing.
3866
3867 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3868
3869 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3870 not to be necessary, and produces flickering.
3871
3872 2011-03-20 Glenn Morris <rgm@gnu.org>
3873
3874 * config.in: Remove file.
3875
3876 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3877
3878 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3879 are now in src/globals.h.
3880 (syms_of_minibuf): Remove spurious & from previous change.
3881
3882 2011-03-20 Leo <sdl.web@gmail.com>
3883
3884 * minibuf.c (completing-read-function): New variable.
3885 (completing-read-default): Rename from completing-read.
3886 (completing-read): Call completing-read-function.
3887
3888 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3889
3890 * xfaces.c (Fx_load_color_file):
3891 Read color file from absolute filename (bug#8250).
3892
3893 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3894
3895 * makefile.w32-in: Update dependencies.
3896
3897 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3898
3899 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3900
3901 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3902
3903 Fix more problems found by GCC 4.5.2's static checks.
3904
3905 * process.c (make_serial_process_unwind, send_process_trap):
3906 (sigchld_handler): Now static.
3907
3908 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3909 That way, the code declares only the vars that it needs.
3910 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3911 * s/cygwin.h (PTY_ITERATION): Likewise.
3912 * s/darwin.h (PTY_ITERATION): Likewise.
3913 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3914
3915 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3916 * process.c (allocate_pty): Don't declare stb unless it's needed.
3917
3918 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3919 (CONSTANTLIM): Remove; unused.
3920 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3921 Define only if needed.
3922
3923 * unexelf.c (unexec): Name an expression,
3924 to avoid gcc -Wbad-function-cast warning.
3925 Use a different way to cause a compilation error if anyone uses
3926 n rather than nn, a way that does not involve shadowing.
3927 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3928
3929 * deps.mk (unexalpha.o): Remove; unused.
3930
3931 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3932 * unexec.h: New file.
3933 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3934 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3935 Depend on unexec.h.
3936 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3937 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3938 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3939 Change as necessary to match prototype in unexec.h.
3940
3941 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3942 shadowing.
3943 (back_comment, skip_chars): Mark vars as initialized.
3944
3945 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3946 Rename locals to avoid shadowing.
3947
3948 * lread.c (read1): Rewrite so as not to use empty "else".
3949 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3950
3951 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3952
3953 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3954 warning when compiling print.c.
3955
3956 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3957 instead of using an uninitialized var.
3958 (font_sort_entities): Mark var as initialized.
3959
3960 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3961
3962 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3963 pointers to constants.
3964 (font_parse_fcname): Remove unused vars.
3965 (font_delete_unmatched): Now static.
3966 (font_get_spec): Remove; unused.
3967 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3968 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3969 Rename or move locals to avoid shadowing.
3970
3971 * fns.c (require_nesting_list, require_unwind): Now static.
3972 (Ffillarray): Rename locals to avoid shadowing.
3973
3974 * floatfns.c (domain_error2): Define only if needed.
3975 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3976
3977 * alloc.c (mark_backtrace): Move decl from here ...
3978 * lisp.h: ... to here, so that it can be checked.
3979
3980 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3981 (Fdefvar): Rewrite so as not to use empty "else".
3982 (lisp_indirect_variable): Name an expression,
3983 to avoid gcc -Wbad-function-cast warning.
3984 (Fdefvar): Rename locals to avoid shadowing.
3985
3986 * callint.c (quotify_arg, quotify_args): Now static.
3987 (Fcall_interactively): Rename locals to avoid shadowing.
3988 Use const pointer when appropriate.
3989
3990 * lisp.h (get_system_name, get_operating_system_release):
3991 Move decls here, to check interfaces.
3992 * process.c (get_operating_system_release): Move decl to lisp.h.
3993 * xrdb.c (get_system_name): Likewise.
3994 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3995 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3996 some of which prompt warnings from gcc -Wbad-function-cast.
3997 (Fformat_time_string, Fencode_time, Finsert_char):
3998 (Ftranslate_region_internal, Fformat):
3999 Rename or remove local vars to avoid shadowing.
4000 (Ftranslate_region_internal): Mark var as initialized.
4001
4002 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4003 avoid shadowing.
4004
4005 * lisp.h (eassert): Check that the argument compiles, even if
4006 ENABLE_CHECKING is not defined.
4007
4008 * data.c (Findirect_variable): Name an expression, to avoid
4009 gcc -Wbad-function-cast warning.
4010 (default_value, arithcompare, arith_driver, arith_error): Now static.
4011 (store_symval_forwarding): Rename local to avoid shadowing.
4012 (Fmake_variable_buffer_local, Fmake_local_variable):
4013 Mark variables as initialized.
4014 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4015
4016 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4017 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4018 Rename locals to avoid shadowing.
4019 (mark_stack): Move local variables into the #ifdef region where
4020 they're used.
4021 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4022 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4023 needed otherwise.
4024 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4025 (GC_STRING_CHARS): Remove; not used.
4026 (Fmemory_limit): Cast sbrk's returned value to char *.
4027
4028 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4029 avoids undefined behavior in theory.
4030
4031 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4032
4033 Use functions, not macros, for up- and down-casing (Bug#8254).
4034 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4035 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4036 to use the following functions instead of these macros.
4037 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4038 EMACS_INT, since callers assume the returned value fits in int.
4039 (upcase1): Likewise, for UPCASE_TABLE.
4040 (uppercasep, lowercasep, upcase): New static inline functions.
4041 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4042 the race-condition problem in the old DOWNCASE.
4043
4044 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4045 Rename locals to avoid shadowing.
4046 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4047 (regex_compile, re_search_2, re_match_2_internal):
4048 Remove unused local vars.
4049 (FREE_VAR): Rewrite so as not to use empty "else",
4050 which gcc can warn about.
4051 (regex_compile, re_match_2_internal): Mark locals as initialized.
4052 (RETALLOC_IF): Define only if needed.
4053 (WORDCHAR_P): Likewise. This one is never needed, but is used
4054 only in a comment talking about a compiler bug, so put inside
4055 the #if 0 of that comment.
4056 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4057 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4058 Remove; unused.
4059
4060 * search.c (boyer_moore): Rename locals to avoid shadowing.
4061 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4062 (PREV_CHAR_BOUNDARY): Likewise.
4063
4064 * search.c (simple_search): Remove unused var.
4065
4066 * dired.c (compile_pattern): Move decl from here ...
4067 * lisp.h: ... to here, so that it can be checked.
4068 (struct re_registers): New forward decl.
4069
4070 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4071
4072 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4073 All uses changed.
4074 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4075 Rename locals to avoid shadowing.
4076 (Fvertical_motion): Mark locals as initialized.
4077
4078 * casefiddle.c (casify_object, casify_region): Now static.
4079 (casify_region): Mark local as initialized.
4080
4081 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4082
4083 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4084 New macros, so that the caller can use some names other than
4085 gcpro1, gcpro2, etc.
4086 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4087 of the new macros.
4088 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4089 argument, for consistency with GCPRO2_VAR, etc: it is now the
4090 prefix of the variable, not the variable itself. All uses
4091 changed.
4092 * dired.c (directory_files_internal, file_name_completion):
4093 Rename locals to avoid shadowing.
4094
4095 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4096 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4097 dired.c's scmp function, had undefined behavior.
4098 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4099 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4100 * buffer.h: ... to here, because these macros use current_buffer,
4101 and the new implementation with inline functions needs to have
4102 current_buffer in scope now, rather than later when the macros
4103 are used.
4104 (downcase, upcase1): New static inline functions.
4105 (DOWNCASE, UPCASE1): Reimplement using these functions.
4106 This avoids undefined behavior in expressions like
4107 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4108 from race conditions in accessing the global variables
4109 case_temp1 and case_temp2.
4110 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4111 * lisp.h (case_temp1, case_temp2): Remove their decls.
4112 * character.h (ASCII_CHAR_P): Move from here ...
4113 * lisp.h: ... to here, so that the inline functions mentioned
4114 above can use them.
4115
4116 * dired.c (directory_files_internal_unwind): Now static.
4117
4118 * fileio.c (file_name_as_directory, directory_file_name):
4119 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4120 Now static.
4121 (file_name_as_directory): Use const pointers when appropriate.
4122 (Fexpand_file_name): Likewise. In particular, newdir might
4123 point at constant storage, so make it a const pointer.
4124 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4125 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4126 signedness issues.
4127 (Fset_file_times, Finsert_file_contents, auto_save_error):
4128 Rename locals to avoid shadowing.
4129
4130 * minibuf.c (choose_minibuf_frame_1): Now static.
4131 (Ftry_completion, Fall_completions): Rename or remove locals
4132 to avoid shadowing.
4133
4134 * marker.c (bytepos_to_charpos): Remove; unused.
4135
4136 * lisp.h (verify_bytepos, count_markers): New decls,
4137 so that gcc does not warn that these functions aren't declared.
4138
4139 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4140 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4141 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4142 (copy_text): Remove unused local var.
4143
4144 * filelock.c (within_one_second): Now static.
4145 (lock_file_1): Rename local to avoid shadowing.
4146
4147 * buffer.c (fix_overlays_before): Mark locals as initialized.
4148 (fix_start_end_in_overlays): Likewise. This function should be
4149 simplified by using pointers-to-pointers, but that's a different
4150 matter.
4151 (switch_to_buffer_1): Now static.
4152 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4153 (report_overlay_modification): Rename locals to avoid shadowing.
4154
4155 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4156 Fix pointer signedness issue.
4157 (sys_subshell): Mark local as volatile if checking for lint,
4158 to suppress a gcc -Wclobbered warning that does not seem to be right.
4159 (MAXPATHLEN): Define only if needed.
4160
4161 * process.c (serial_open, serial_configure): Move decls from here ...
4162 * systty.h: ... to here, so that they can be checked.
4163
4164 * fns.c (get_random, seed_random): Move extern decls from here ...
4165 * lisp.h: ... to here, so that they can be checked.
4166
4167 * sysdep.c (reset_io): Now static.
4168 (wait_for_termination_signal): Remove; unused.
4169
4170 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4171 (copy_keymap_item, append_key, push_text_char_description):
4172 Now static.
4173 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4174 (DENSE_TABLE_SIZE): Remove; unused.
4175 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4176 (describe_map_tree):
4177 Rename locals to avoid shadowing.
4178
4179 * keyboard.c: Declare functions static if they are not used elsewhere.
4180 (echo_char, echo_dash, cmd_error, top_level_2):
4181 (poll_for_input, handle_async_input): Now static.
4182 (read_char, kbd_buffer_get_event, make_lispy_position):
4183 (make_lispy_event, make_lispy_movement, apply_modifiers):
4184 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4185 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4186 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4187 (read_key_sequence, read_char): Mark locals as initialized.
4188 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4189
4190 * keyboard.h (make_ctrl_char): New decl.
4191 (mark_kboards): Move decl here ...
4192 * alloc.c (mark_kboards): ... from here.
4193
4194 * lisp.h (force_auto_save_soon): New decl.
4195
4196 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4197 (DEFINE_DUMMY_FUNCTION): New macro.
4198 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4199 Use it.
4200 (main): Add casts to avoid warnings
4201 if GCC considers string literals to be constants.
4202
4203 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4204
4205 * dbusbind.c: Pointer signedness fixes.
4206 (xd_signature, xd_append_arg, xd_initialize):
4207 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4208 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4209 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4210 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4211
4212 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4213 if GCC considers string literals to be constants.
4214 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4215
4216 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4217
4218 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4219 (print_preprocess, print_object): New macro to fix last change.
4220
4221 * print.c (print_preprocess): Don't forget font objects.
4222
4223 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4224
4225 * emacs.c (USAGE3): Doc fixes.
4226
4227 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4228
4229 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4230 structure.
4231
4232 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4233
4234 * lisp.h (VWindow_system, Qfile_name_history):
4235 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4236 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4237 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4238
4239 * w32select.c: Don't #include "keyboard.h".
4240 (run_protected): Add extern declaration for waiting_for_input.
4241
4242 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4243 * w32console.c (detect_input_pending, read_input_pending)
4244 (encode_terminal_code):
4245 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4246 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4247 (w32_system_caret_y, Qfile_name_history):
4248 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4249 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4250 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4251 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4252 * w32proc.c (Qlocal, report_file_error):
4253 * w32term.c (Vwindow_system, updating_frame):
4254 * w32uniscribe.c (initialized, uniscribe_font_driver):
4255 Remove unneeded extern declarations.
4256
4257 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4258
4259 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4260
4261 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4262
4263 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4264 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4265 These macros can no longer be used for assignment.
4266
4267 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4268 Assign struct members directly, instead of using BUF_BEGV etc.
4269 (record_buffer_markers, fetch_buffer_markers): New functions for
4270 recording and fetching special buffer markers.
4271 (set_buffer_internal_1, set_buffer_temp): Use them.
4272
4273 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4274
4275 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4276
4277 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4278 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4279
4280 * xdisp.c (hscroll_window_tree):
4281 (reconsider_clip_changes): Use PT instead of BUF_PT.
4282
4283 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4284
4285 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4286 $(EMACS_ROOT)/lib/intprops.h.
4287
4288 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4289
4290 Fix more problems found by GCC 4.5.2's static checks.
4291
4292 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4293 to unsigned char * to avoid compiler diagnostic.
4294 (xg_free_frame_widgets): Make it clear that a local variable is
4295 needed only if USE_GTK_TOOLTIP.
4296 (gdk_window_get_screen): Make it clear that this macro is needed
4297 only if USE_GTK_TOOLTIP.
4298 (int_gtk_range_get_value): New function, which avoids a diagnostic
4299 from gcc -Wbad-function-cast.
4300 (xg_set_toolkit_scroll_bar_thumb): Use it.
4301 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4302 diagnostic from gcc -Wbad-function-cast.
4303 (get_utf8_string, xg_get_file_with_chooser):
4304 Rename locals to avoid shadowing.
4305 (create_dialog): Move locals to avoid shadowing.
4306
4307 * xgselect.c (xg_select): Remove unused var.
4308
4309 * image.c (four_corners_best): Mark locals as initialized.
4310 (gif_load): Initialize transparent_p to zero (Bug#8238).
4311 Mark another local as initialized.
4312 (my_png_error, my_error_exit): Mark with NO_RETURN.
4313
4314 * image.c (clear_image_cache): Now static.
4315 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4316 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4317 (x_edge_detection): Remove unnecessary cast that
4318 gcc -Wbad-function-cast diagnoses.
4319 (gif_load): Fix pointer signedness.
4320 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4321 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4322
4323 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4324
4325 Improve quality of tests for time stamp overflow.
4326 For example, without this patch (encode-time 0 0 0 1 1
4327 1152921504606846976) returns the obviously-bogus value (-948597
4328 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4329 reports time overflow. See
4330 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4331 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4332 * editfns.c: Include limits.h and intprops.h.
4333 (TIME_T_MIN, TIME_T_MAX): New macros.
4334 (time_overflow): Move earlier, to before first use.
4335 (hi_time, lo_time): New functions, for an accurate test for
4336 out-of-range times.
4337 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4338 (Fget_internal_run_time): Don't assume time_t fits in int.
4339 (make_time): Use list2 instead of Fcons twice.
4340 (Fdecode_time): More accurate test for out-of-range times.
4341 (check_tm_member): New function.
4342 (Fencode_time): Use it, to test for out-of-range times.
4343 (lisp_time_argument): Don't rely on undefined left-shift and
4344 right-shift behavior when checking for time stamp overflow.
4345
4346 * editfns.c (time_overflow): New function, refactoring common code.
4347 (Fformat_time_string, Fdecode_time, Fencode_time):
4348 (Fcurrent_time_string): Use it.
4349
4350 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4351 * dired.c (make_time): Move to ...
4352 * editfns.c (make_time): ... here.
4353 * systime.h: Note the move.
4354
4355 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4356
4357 * fringe.c (update_window_fringes): Remove unused variables.
4358
4359 * unexmacosx.c (copy_data_segment): Also copy __got section.
4360 (Bug#8223)
4361
4362 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4363
4364 * termcap.c [MSDOS]: Include "msdos.h".
4365 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4366 Constify `char *' arguments and their references according to
4367 prototypes in tparam.h.
4368
4369 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4370
4371 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4372 Adapt all references accordingly.
4373
4374 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4375
4376 2011-03-11 Tom Tromey <tromey@redhat.com>
4377
4378 * buffer.c (syms_of_buffer): Remove obsolete comment.
4379
4380 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4381
4382 * termhooks.h (encode_terminal_code): Declare prototype.
4383
4384 * msdos.c (encode_terminal_code): Don't declare prototype.
4385
4386 * term.c (encode_terminal_code): Now external again, used by
4387 w32console.c and msdos.c.
4388
4389 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4390 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4391
4392 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4393
4394 Fix some minor problems found by GCC 4.5.2's static checks.
4395
4396 * fringe.c (update_window_fringes): Mark locals as initialized
4397 (Bug#8227).
4398 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4399
4400 * alloc.c (mark_fringe_data): Move decl from here ...
4401 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4402 to check its interface.
4403 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4404
4405 * fontset.c (free_realized_fontset): Now static.
4406 (Fset_fontset_font): Rename local to avoid shadowing.
4407 (fontset_font): Mark local as initialized.
4408 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4409
4410 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4411
4412 * xselect.c (x_disown_buffer_selections): Remove; not used.
4413 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4414 (x_own_selection, Fx_disown_selection_internal): Rename locals
4415 to avoid shadowing.
4416 (x_handle_dnd_message): Remove local to avoid shadowing.
4417
4418 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4419 so that the caller can use some name other than gcpro1.
4420 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4421 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4422 (Fx_backspace_delete_keys_p):
4423 Use them to avoid shadowing, and rename vars to avoid shadowing.
4424 (x_decode_color, x_set_name, x_window): Now static.
4425 (Fx_create_frame): Add braces to silence GCC warning.
4426 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4427 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4428 Remove unused locals.
4429 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4430 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4431 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4432 macros.
4433
4434 * xterm.h (x_mouse_leave): New decl.
4435
4436 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4437 Remove unused functions.
4438 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4439 (x_calc_absolute_position): Now static.
4440 (XTread_socket): Don't define label "out" unless it's used.
4441 Don't declare local "event" unless it's used.
4442 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4443 unless they are used.
4444 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4445 (x_fatal_error_signal): Remove; not used.
4446 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4447 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4448 (x_error_catcher, x_connection_closed, x_error_handler):
4449 (x_error_quitter, xembed_send_message, x_iconify_frame):
4450 (my_log_handler): Rename locals to avoid shadowing.
4451 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4452 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4453
4454 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4455 Rename or move locals to avoid shadowing.
4456 (tty_defined_color, merge_face_heights): Now static.
4457 (free_realized_faces_for_fontset): Remove; not used.
4458 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4459 does not deduce is never used uninitialized.
4460 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4461 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4462
4463 * terminal.c (store_terminal_param): Now static.
4464
4465 * xmenu.c (menu_highlight_callback): Now static.
4466 (set_frame_menubar): Remove unused local.
4467 (xmenu_show): Rename parameter to avoid shadowing.
4468 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4469 since they might point to immutable storage.
4470 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4471 since it's unused otherwise.
4472
4473 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4474 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4475 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4476 avoids a gcc -Wuninitialized diagnostic.
4477 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4478 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4479 does not deduce are never used uninitialized.
4480
4481 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4482
4483 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4484 * window.c (window_loop, size_window):
4485 (run_window_configuration_change_hook, enlarge_window): Likewise.
4486
4487 * window.c (display_buffer): Now static.
4488 (size_window): Mark variables that gcc -Wuninitialized
4489 does not deduce are never used uninitialized.
4490 * window.h (check_all_windows): New decl, to forestall
4491 gcc -Wmissing-prototypes diagnostic.
4492 * dispextern.h (bidi_dump_cached_states): Likewise.
4493
4494 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4495 shadowing.
4496 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4497 Include <limits.h>.
4498 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4499 and to avoid gcc -Wuninitialized warning.
4500 (load_charset_map): Mark variables that gcc -Wuninitialized
4501 does not deduce are never used uninitialized.
4502 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4503
4504 * coding.c (coding_set_source, coding_set_destination):
4505 Use "else { /* comment */ }" rather than "else /* comment */;"
4506 for clarity, and to avoid gcc -Wempty-body warning.
4507 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4508 a block, when the outer 'i' will do.
4509 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4510 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4511 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4512 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4513 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4514 Rename locals to avoid shadowing.
4515 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4516 * coding.c (emacs_mule_char, encode_invocation_designation):
4517 Now static, since they're not used elsewhere.
4518 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4519 (decode_coding_object, encode_coding_object, detect_coding_system):
4520 (decode_coding_emacs_mule): Mark variables that gcc
4521 -Wuninitialized does not deduce are never used uninitialized.
4522 (detect_coding_iso_2022): Initialize a local variable that might
4523 be used uninitialized. Leave a FIXME because it's not clear that
4524 this initialization is needed. (Bug#8211)
4525 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4526 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4527 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4528 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4529 Remove unused macros.
4530
4531 * category.c (hash_get_category_set): Remove unused local var.
4532 (copy_category_table): Now static, since it's not used elsewhere.
4533 * character.c (string_count_byte8): Likewise.
4534
4535 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4536 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4537
4538 * chartab.c (copy_sub_char_table): Now static, since it's not used
4539 elsewhere.
4540 (sub_char_table_ref_and_range, char_table_ref_and_range):
4541 Rename locals to avoid shadowing.
4542 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4543
4544 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4545 (BIDI_BOB): Remove unused macro.
4546
4547 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4548 deduce are never used uninitialized.
4549 * term.c (encode_terminal_code): Likewise.
4550
4551 * term.c (encode_terminal_code): Now static. Remove unused local.
4552
4553 * tparam.h: New file.
4554 * term.c, tparam.h: Include it.
4555 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4556 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4557 Move these decls to tparam.h, and make them agree with what
4558 is actually in tparam.c. The previous trick of using incompatible
4559 decls in different modules does not conform to the C standard.
4560 All callers of tparam changed to use tparam's actual API.
4561 * tparam.c (tparam1, tparam, tgoto):
4562 Use const pointers where appropriate.
4563
4564 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4565 * cm.h (struct cm): Likewise.
4566 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4567 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4568 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4569 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4570 (turn_on_face, init_tty): Likewise.
4571 * termchar.h (struct tty_display_info): Likewise.
4572
4573 * term.c (term_mouse_position): Rename local to avoid shadowing.
4574
4575 * alloc.c (mark_ttys): Move decl from here ...
4576 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4577
4578 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4579
4580 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4581
4582 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4583
4584 * search.c (compile_pattern_1): Remove argument regp, unused since
4585 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4586 (compile_pattern): Don't pass it.
4587
4588 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4589
4590 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4591 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4592 for ! HAVE_GTK3.
4593 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4594
4595 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4596
4597 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4598 gdk_window_get_screen, gdk_window_get_geometry,
4599 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4600 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4601 (xg_get_pixbuf_from_pixmap): New function.
4602 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4603 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4604 Call xg_get_pixbuf_from_pixmap instead of
4605 gdk_pixbuf_get_from_drawable.
4606 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4607 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4608 (xg_check_special_colors): Use GtkStyleContext and its functions
4609 for HAVE_GTK3.
4610 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4611 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4612 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4613 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4614 Call gtk_widget_get_preferred_size.
4615 (xg_frame_resized): gdk_window_get_geometry only takes 5
4616 parameters.
4617 (xg_win_to_widget, xg_event_is_for_menubar):
4618 Call gdk_x11_window_lookup_for_display.
4619 (xg_set_widget_bg): New function.
4620 (delete_cb): New function.
4621 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4622 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4623 (xg_set_background_color): Call xg_set_widget_bg.
4624 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4625 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4626 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4627 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4628 if ! HAVE_GTK3.
4629 (update_frame_tool_bar): Call gtk_widget_hide.
4630 (xg_initialize): Use GDK_KEY_g.
4631
4632 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4633 if ! HAVE_GTK3
4634 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4635
4636 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4637 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4638 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4639
4640 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4641
4642 * w32xfns.c (select_palette): Check success of RealizePalette against
4643 GDI_ERROR, not zero.
4644
4645 See ChangeLog.11 for earlier changes.
4646
4647 ;; Local Variables:
4648 ;; coding: utf-8
4649 ;; End:
4650
4651 Copyright (C) 2011 Free Software Foundation, Inc.
4652
4653 This file is part of GNU Emacs.
4654
4655 GNU Emacs is free software: you can redistribute it and/or modify
4656 it under the terms of the GNU General Public License as published by
4657 the Free Software Foundation, either version 3 of the License, or
4658 (at your option) any later version.
4659
4660 GNU Emacs is distributed in the hope that it will be useful,
4661 but WITHOUT ANY WARRANTY; without even the implied warranty of
4662 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4663 GNU General Public License for more details.
4664
4665 You should have received a copy of the GNU General Public License
4666 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.