Fix ChangeLog typos.
[bpt/emacs.git] / src / ChangeLog
1 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2
3 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
6 * s/netbsd.h, s/sol2-6.h:
7 Remove definition of GC_MARK_STACK, since the default now works.
8 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
9 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
10 no longer the default.
11 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
12
13 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
14
15 * lread.c (lisp_file_lexically_bound_p):
16 Fix hang at ";-*-\n" (bug#11238).
17
18 2012-04-14 Eli Zaretskii <eliz@gnu.org>
19
20 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
21 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
22
23 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
24
25 * nsterm.m (constrainFrameRect): Always constrain when there is only
26 one screen (Bug#10962).
27
28 2012-04-13 Ken Brown <kbrown@cornell.edu>
29
30 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
31
32 2012-04-13 Reuben Thomas <rrt@sc3d.org>
33
34 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
35
36 2012-04-11 Daniel Colascione <dancol@dancol.org>
37
38 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
39 against is gone. It's better to use vfork now so that when Cygwin
40 gains a new, working vfork, we use it automatically (bug#10398).
41
42 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
43
44 * window.c (save_window_save): Obey window-point-insertion-type.
45
46 2012-04-11 Glenn Morris <rgm@gnu.org>
47
48 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
49
50 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
51
52 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
53
54 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
55
56 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
57 (force_quit_count): New var.
58 (handle_interrupt): Use it.
59
60 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
61
62 * w32.c (w32_delayed_load): Record the full path of the library
63 being loaded (bug#10424).
64
65 2012-04-09 Glenn Morris <rgm@gnu.org>
66
67 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
68 not just in the obarray, before snarfing them. (Bug#11036)
69
70 * Makefile.in ($(leimdir)/leim-list.el):
71 Pass EMACS rather than BUILT_EMACS.
72
73 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
74
75 * process.c (make_process):
76 * process.h: Add integer `gnutls_handshakes_tried' member to
77 process struct.
78
79 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
80 Add convenience `GNUTLS_LOG2i' macro.
81
82 * gnutls.c (gnutls_log_function2i): Convenience log function.
83 (emacs_gnutls_read): Use new log functions,
84 `gnutls_handshakes_tried' process member, and
85 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
86 attempts per process (connection).
87
88 2012-04-09 Chong Yidong <cyd@gnu.org>
89
90 * eval.c (Fuser_variable_p, user_variable_p_eh)
91 (lisp_indirect_variable): Functions deleted.
92 (Fdefvar): Caller changed.
93
94 * callint.c (Finteractive, Fcall_interactively):
95 * minibuf.c (Fread_variable): Callers changed.
96
97 2012-04-09 Eli Zaretskii <eliz@gnu.org>
98
99 * xdisp.c (set_cursor_from_row): If the display string appears in
100 the buffer at position that is closer to point than the position
101 after the display string, display the cursor on the first glyph of
102 the display string. Fixes cursor display when a 'display' text
103 property immediately follows invisible text. (Bug#11094)
104
105 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
106
107 composite.c: use 'double' consistently
108 * composite.c (get_composition_id): Use 'double' consistently
109 instead of converting 'float' to 'double' and vice versa; this is
110 easier to understand and avoids a GCC warning.
111
112 2012-04-09 Glenn Morris <rgm@gnu.org>
113
114 * Makefile.in: Generate leim-list with bootstrap-emacs, in
115 preparation for dumping it with emacs. (Bug#4789)
116 (leimdir): New variable.
117 ($(leimdir)/leim-list.el): New rule.
118 (emacs$(EXEEXT)): Depend on leim-list.el.
119
120 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
121 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
122 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
123
124 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
125
126 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
127 proper alignment.
128
129 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
130
131 * xml.c (init_libxml2_functions) [WINDOWSNT]:
132 Remove unused local variable.
133
134 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
135
136 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
137 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
138 (mark_memory): Mark Lisp_Objects only if pointers might hide in
139 objects, as mark_maybe_pointer will catch them otherwise.
140 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
141 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
142
143 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
144
145 Fix typo that broke non-Windows builds.
146 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
147
148 2012-04-07 Eli Zaretskii <eliz@gnu.org>
149
150 Support building on MS-Windows with libxml2.
151
152 * makefile.w32-in (OBJ2): Add xml.$(O).
153 (GLOBAL_SOURCES): Add xml.c.
154 ($(BLD)/xml.$(O)): New dependency list.
155
156 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
157 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
158 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
159 [!WINDOWSNT]: New macros.
160 (init_libxml2_functions, libxml2_loaded_p): New functions.
161 (parse_region): Call fn_xmlCheckVersion instead of using the macro
162 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
163 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
164 Calls xmlCleanupParser only if libxml2 was loaded (or statically
165 linked in).
166 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
167 Call init_libxml2_functions before calling libxml2 functions.
168 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
169
170 * emacs.c: Don't include libxml/parser.h.
171 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
172 xmlCleanupParser directly.
173
174 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
175
176 2012-04-07 Eli Zaretskii <eliz@gnu.org>
177
178 * indent.c (Fvertical_motion): If there is a display string at
179 point, use it.vpos to compute how many lines to backtrack after
180 move_it_to point. (Bug#11133)
181
182 2012-04-06 Eli Zaretskii <eliz@gnu.org>
183
184 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
185 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
186 about subtle differences between FETCH_CHAR* and STRING_CHAR*
187 macros related to unification of CJK characters. For the details,
188 see the discussion following the message here:
189 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
190
191 2012-04-04 Chong Yidong <cyd@gnu.org>
192
193 * keyboard.c (Vdelayed_warnings_list): Doc fix.
194
195 2012-04-01 Eli Zaretskii <eliz@gnu.org>
196
197 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
198 instead of alloca. (Bug#11138)
199
200 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
201
202 * w32menu.c (is_simple_dialog): Properly check lisp types.
203 (Bug#11141)
204
205 2012-03-31 Eli Zaretskii <eliz@gnu.org>
206
207 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
208 position we get to after a call to move_it_to fails the
209 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
210 only if we wind up in a string from display property. (Bug#11063)
211
212 * window.c (Fdelete_other_windows_internal): Invalidate the row
213 and column information about mouse highlight, so that redisplay
214 restores it after reallocating the glyph matrices. (Bug#7464)
215
216 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
217 string comes from a `display' text property, use the buffer
218 position of that property as if we actually saw that position in
219 the row's glyphs.
220 (move_it_by_lines): Remove the assertion that
221 "it->current_x == 0 && it->hpos == 0" which can be legitimately
222 violated when there's a before-string at the beginning of a line.
223 (Bug#11063)
224
225 2012-03-30 Eli Zaretskii <eliz@gnu.org>
226
227 * xdisp.c (append_space_for_newline): If the default face was
228 remapped, use the remapped face for the appended newline.
229 (extend_face_to_end_of_line): Use the remapped default face for
230 extending the face to the end of the line.
231 (display_line): Call extend_face_to_end_of_line when the default
232 face was remapped. (Bug#11068)
233
234 2012-03-29 Eli Zaretskii <eliz@gnu.org>
235
236 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
237
238 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
239
240 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
241
242 2012-03-27 Glenn Morris <rgm@gnu.org>
243
244 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
245 Doc fixes.
246
247 2012-03-26 Kenichi Handa <handa@m17n.org>
248
249 * dispextern.h (struct glyph): Fix previous change. Change the
250 bit length of glyphless.ch to 25 (Bug#11082).
251
252 2012-03-26 Chong Yidong <cyd@gnu.org>
253
254 * keyboard.c (Vselection_inhibit_update_commands): New variable.
255 (command_loop_1): Use it; inhibit selection update for
256 handle-select-window too (Bug#8996).
257
258 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
259
260 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
261
262 2012-03-25 Kenichi Handa <handa@m17n.org>
263
264 * dispextern.h (struct glyph): Change the bit length of
265 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
266
267 2012-03-24 Eli Zaretskii <eliz@gnu.org>
268
269 * s/ms-w32.h (tzname): Include time.h before redirecting to
270 _tzname. Fixes the MSVC build. (Bug#9960)
271
272 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
273
274 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
275 characters.
276
277 * xterm.c (XTread_socket): Only modify handling_signal if
278 !SYNC_INPUT. (Bug#11080)
279
280 2012-03-23 Eli Zaretskii <eliz@gnu.org>
281
282 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
283 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
284 when fetching a multibyte character consumes more bytes than
285 CHAR_BYTES returns, due to unification of CJK characters in
286 string_char. (Bug#11073)
287
288 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
289
290 * process.c (wait_reading_process_output): Handle pty disconnect
291 by refraining from sending oneself a SIGCHLD (bug#10933).
292
293 2012-03-22 Chong Yidong <cyd@gnu.org>
294
295 * dispextern.h (struct it): New member string_from_prefix_prop_p.
296
297 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
298 Mark string as coming from a prefix property.
299 (handle_face_prop): Use default face for prefix strings (Bug#4281).
300 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
301
302 2012-03-21 Chong Yidong <cyd@gnu.org>
303
304 * xfaces.c (Vface_remapping_alist): Doc fix.
305
306 2012-03-20 Eli Zaretskii <eliz@gnu.org>
307
308 * w32proc.c (Fw32_set_console_codepage)
309 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
310 Doc fixes.
311
312 2012-03-20 Chong Yidong <cyd@gnu.org>
313
314 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
315 to reflect default non-nil value of redisplay-dont-pause.
316
317 2012-03-19 Kenichi Handa <handa@m17n.org>
318
319 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
320 it fit in a valid range (Bug#11003).
321
322 2012-03-18 Eli Zaretskii <eliz@gnu.org>
323
324 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
325 that is not from display property, accept the row as a "cursor
326 row" if one of the string's character has a non-nil `cursor'
327 property. Fixes cursor positioning when there are newlines in
328 overlay strings, e.g. in icomplete.el. (Bug#11035)
329
330 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
331
332 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
333
334 2012-03-12 Chong Yidong <cyd@gnu.org>
335
336 * eval.c (inhibit_lisp_code): Rename from
337 inhibit_window_configuration_change_hook; move from window.c.
338
339 * xfns.c (unwind_create_frame_1, Fx_create_frame):
340 * window.c (run_window_configuration_change_hook)
341 (syms_of_window): Callers changed.
342
343 2012-03-11 Chong Yidong <cyd@gnu.org>
344
345 * keymap.c (Fkey_description): Doc fix (Bug#9700).
346
347 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
348
349 2012-03-10 Chong Yidong <cyd@gnu.org>
350
351 * frame.c (other_visible_frames): Don't assume the selected frame
352 is visible (Bug#10955).
353
354 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
355
356 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
357
358 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
359
360 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
361 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
362 zero (Bug#10954).
363
364 2012-03-03 Glenn Morris <rgm@gnu.org>
365
366 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
367
368 2012-03-02 Eli Zaretskii <eliz@gnu.org>
369
370 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
371 position past the first glyph_row that ends at ZV. (Bug#10902)
372 (redisplay_window, next_element_from_string): Fix typos in
373 comments.
374 (redisplay_window): Pass to move_it_vertically the margin in
375 pixels, not in screen lines.
376
377 2012-03-02 Glenn Morris <rgm@gnu.org>
378
379 * buffer.c (buffer-list-update-hook): Doc fix.
380
381 2012-02-29 Eli Zaretskii <eliz@gnu.org>
382
383 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
384 push_it before setting up the iterator for the first overlay
385 string, even if we have an empty string loaded.
386 (next_overlay_string): If there's an empty string on the iterator
387 stack, pop the stack. (Bug#10903)
388
389 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
390
391 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
392 Suggested by Stefan Monnier in
393 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
394 * alloc.c (widen_to_Lisp_Object): New static function.
395 (mark_memory): Also mark Lisp_Objects by fetching pointer words
396 and widening them to Lisp_Objects. This would work even if
397 USE_LSB_TAG is defined and wide integers are used, which might
398 happen in a future version of Emacs.
399
400 2012-02-25 Chong Yidong <cyd@gnu.org>
401
402 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
403 Doc fix.
404
405 * xselect.c (Fx_selection_exists_p): Doc fix.
406 (x_clipboard_manager_save_all): Print an informative message
407 before saving to clipboard manager.
408
409 2012-02-24 Chong Yidong <cyd@gnu.org>
410
411 * keyboard.c (process_special_events): Handle all X selection
412 requests in kbd_buffer, not just the next one (Bug#8869).
413
414 2012-02-23 Chong Yidong <cyd@gnu.org>
415
416 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
417 call when setting menu-bar-lines and tool-bar-lines parameters.
418 (unwind_create_frame_1): New helper function.
419
420 * window.c (inhibit_window_configuration_change_hook): New var.
421 (run_window_configuration_change_hook): Obey it.
422 (syms_of_window): Initialize it.
423
424 2012-02-22 Chong Yidong <cyd@gnu.org>
425
426 * xterm.c (x_draw_image_relief): Add missing type check for
427 Vtool_bar_button_margin (Bug#10743).
428
429 2012-02-21 Chong Yidong <cyd@gnu.org>
430
431 * fileio.c (Vfile_name_handler_alist): Doc fix.
432
433 * buffer.c (Fget_file_buffer): Protect against invalid file
434 handler return value.
435
436 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
437
438 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
439 when computing $valmask.
440
441 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
442 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
443 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
444 It's useless in that case, and it can cause problems on hosts
445 that allocate halves of EMACS_INT values separately.
446 Reported by Dan Horák. Diagnosed by Andreas Schwab in
447 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
448 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
449 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
450 it avoids undefined behavior on hosts where shifting right by more
451 than the word width has undefined behavior.
452
453 2012-02-19 Chong Yidong <cyd@gnu.org>
454
455 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
456 (Funhandled_file_name_directory, Ffile_name_as_directory)
457 (Fdirectory_file_name, Fexpand_file_name)
458 (Fsubstitute_in_file_name): Protect against invalid file handler
459 return values (Bug#10845).
460
461 2012-02-18 Eli Zaretskii <eliz@gnu.org>
462
463 * .gdbinit (pitx): Fix incorrect references to fields of the
464 iterator stack.
465
466 2012-02-17 Chong Yidong <cyd@gnu.org>
467
468 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
469
470 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
471
472 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
473 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
474
475 2012-02-15 Chong Yidong <cyd@gnu.org>
476
477 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
478 marked as special. Also, starting docstrings with * is obsolete.
479
480 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
481
482 * gnutls.c (emacs_gnutls_write): Fix last change.
483
484 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
485
486 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
487 send_process.
488
489 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
490
491 * keymap.c (Fsingle_key_description): Handle char ranges.
492
493 2012-02-12 Chong Yidong <cyd@gnu.org>
494
495 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
496 as that creates a dangerous corner case.
497
498 * window.c (Fdelete_window_internal): Invalidate the mouse
499 highlight (Bug#9904).
500
501 2012-02-12 Glenn Morris <rgm@gnu.org>
502
503 * xselect.c (Fx_own_selection_internal)
504 (Fx_get_selection_internal, Fx_disown_selection_internal)
505 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
506 * nsselect.m (Fx_own_selection_internal)
507 (Fx_disown_selection_internal, Fx_selection_exists_p)
508 (Fx_selection_owner_p, Fx_get_selection_internal):
509 Sync docs and argument specs with the xselect.c versions.
510
511 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
512
513 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
514
515 2012-02-11 Eli Zaretskii <eliz@gnu.org>
516
517 * w32select.c (Fx_selection_exists_p): Sync doc string and
518 argument list with xselect.c. (Bug#10783)
519
520 * w16select.c (Fx_selection_exists_p): Sync doc string and
521 argument list with xselect.c. (Bug#10783)
522
523 2012-02-10 Glenn Morris <rgm@gnu.org>
524
525 * fns.c (Fsecure_hash): Doc fix.
526
527 2012-02-09 Kenichi Handa <handa@m17n.org>
528
529 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
530
531 2012-02-07 Chong Yidong <cyd@gnu.org>
532
533 * buffer.c (Fbuffer_local_variables)
534 (buffer_lisp_local_variables): Handle unbound vars correctly;
535 don't let Qunbound leak into Lisp.
536
537 2012-02-07 Glenn Morris <rgm@gnu.org>
538
539 * image.c (Fimagemagick_types): Doc fix.
540
541 * image.c (imagemagick-render-type): Change it from a lisp object
542 to an integer. Move the doc here from the lisp manual.
543 Treat all values not equal to 0 the same.
544
545 2012-02-06 Chong Yidong <cyd@gnu.org>
546
547 * doc.c (store_function_docstring): Avoid applying docstring of
548 alias to base function (Bug#2603).
549
550 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
551
552 * .gdbinit (pp1, pv1): Remove redundant defines.
553 (pr): Use pp.
554
555 2012-02-04 Chong Yidong <cyd@gnu.org>
556
557 * nsterm.m: Declare a global (Bug#10694).
558
559 2012-02-04 Eli Zaretskii <eliz@gnu.org>
560
561 * w32.c (get_emacs_configuration_options):
562 Include --enable-checking, if specified, in the return value.
563
564 2012-02-04 Martin Rudalics <rudalics@gmx.at>
565
566 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
567 after rounding frame sizes. (Bug#9723)
568
569 2012-02-04 Eli Zaretskii <eliz@gnu.org>
570
571 * keyboard.c (adjust_point_for_property): Don't position point
572 before BEGV. (Bug#10696)
573
574 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
575
576 Handle overflow when computing char display width (Bug#9496).
577 * character.c (char_width): Return EMACS_INT, not int.
578 (char_width, c_string_width): Check for overflow when
579 computing the width; this is possible now that individual
580 characters can have unbounded width. Problem introduced
581 by merge from Emacs 23 on 2012-01-19.
582
583 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
584
585 * dbusbind.c (Fdbus_register_method): Mention the return value
586 :ignore in the docstring.
587
588 2012-02-02 Glenn Morris <rgm@gnu.org>
589
590 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
591
592 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
593 Unconditionally set to t. (Bug#10673)
594 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
595 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
596 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
597
598 2012-02-02 Kenichi Handa <handa@m17n.org>
599
600 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
601 0, do not call append_composite_glyph.
602
603 2012-02-02 Kenichi Handa <handa@m17n.org>
604
605 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
606 NULL (Bug#6988).
607 (x_produce_glyphs): If the component of a composition is a null
608 string, set it->pixel_width to 1 to avoid zero-width glyph.
609
610 2012-02-01 Eli Zaretskii <eliz@gnu.org>
611
612 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
613 first 2 arguments are identical. This makes inserting large
614 output from a subprocess an order of magnitude faster on
615 MS-Windows, where all sbrk'ed memory is always contiguous.
616
617 2012-01-31 Glenn Morris <rgm@gnu.org>
618
619 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
620 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
621 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
622
623 2012-01-29 Glenn Morris <rgm@gnu.org>
624
625 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
626
627 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
628
629 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
630
631 2012-01-28 Chong Yidong <cyd@gnu.org>
632
633 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
634
635 2012-01-26 Chong Yidong <cyd@gnu.org>
636
637 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
638
639 * search.c (Fsearch_forward, Fsearch_backward): Document negative
640 repeat counts (Bug#10507).
641
642 2012-01-26 Glenn Morris <rgm@gnu.org>
643
644 * lread.c (syms_of_lread): Doc fix.
645
646 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
647
648 * coding.c (encode_designation_at_bol): Change return value to
649 EMACS_INT.
650
651 2012-01-25 Chong Yidong <cyd@gnu.org>
652
653 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
654
655 2012-01-21 Chong Yidong <cyd@gnu.org>
656
657 * floatfns.c (Fcopysign): Make the second argument non-optional,
658 since nil is not allowed anyway.
659
660 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
661
662 * process.c (read_process_output): Use p instead of XPROCESS (proc).
663 (send_process): Likewise.
664
665 2012-01-19 Martin Rudalics <rudalics@gmx.at>
666
667 * window.c (save_window_save, Fcurrent_window_configuration)
668 (Vwindow_persistent_parameters): Do not use Qstate.
669 Rewrite doc-strings.
670
671 2012-01-19 Kenichi Handa <handa@m17n.org>
672
673 * character.c (char_width): New function.
674 (Fchar_width, c_string_width, lisp_string_width):
675 Use char_width (Bug#9496).
676
677 2012-01-16 Martin Rudalics <rudalics@gmx.at>
678
679 * window.c (Vwindow_persistent_parameters): New variable.
680 (Fset_window_configuration, save_window_save): Handle persistent
681 window parameters.
682
683 2012-01-14 Eli Zaretskii <eliz@gnu.org>
684
685 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
686 thrashing the stack of the thread. (Bug#9087)
687
688 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
689
690 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
691
692 2012-01-11 Eli Zaretskii <eliz@gnu.org>
693
694 * xdisp.c (rows_from_pos_range): Handle the case where the
695 highlight ends on a newline. (Bug#10464)
696 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
697 he end column for display of highlight that ends on a newline
698 before a R2L line.
699
700 2012-01-11 Glenn Morris <rgm@gnu.org>
701
702 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
703 from load-path also when installation-directory is nil. (Bug#10208)
704
705 2012-01-10 Glenn Morris <rgm@gnu.org>
706
707 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
708
709 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
710 Update template values to be closer to their typical values these days.
711
712 2012-01-09 Eli Zaretskii <eliz@gnu.org>
713
714 * xdisp.c (rows_from_pos_range): Accept additional argument
715 DISP_STRING, and accept any glyph in a row whose object is that
716 string as eligible for mouse highlight. Fixes mouse highlight of
717 display strings from overlays. (Bug#10464)
718
719 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
720
721 emacs: fix an auto-save permissions race condition (Bug#10400)
722 * fileio.c (auto_saving_dir_umask): New static var.
723 (Fmake_directory_internal): Use it.
724 (do_auto_save_make_dir): Set it, instead of invoking chmod after
725 creating the directory. The old code temporarily assigns
726 too-generous permissions to the directory.
727 (do_auto_save_eh): Clear it.
728 (Fdo_auto_save): Catch all errors, not just file errors, so
729 that the var is always cleared.
730
731 2012-01-07 Eli Zaretskii <eliz@gnu.org>
732
733 * search.c (scan_buffer): Pass character positions to
734 know_region_cache, not byte positions. (Bug#6540)
735
736 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
737
738 * w32.c (sys_rename): Report EXDEV when rename of a directory
739 fails because the target is on another logical disk. (Bug#10284)
740
741 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
742
743 * xterm.c (x_embed_request_focus): New function.
744
745 * xterm.h: Add prototype.
746
747 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
748
749 2012-01-05 Glenn Morris <rgm@gnu.org>
750
751 * emacs.c (emacs_copyright): Update short copyright year to 2012.
752
753 2012-01-01 Eli Zaretskii <eliz@gnu.org>
754
755 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
756 Load gnutls_transport_set_lowat only if GnuTLS version is below
757 2.11.1.
758 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
759 GnuTLS versions below 2.11.1.
760
761 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
762
763 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
764 to the doc string advising against its use for altering the way
765 windows are scrolled.
766
767 2011-12-28 Kenichi Handa <handa@m17n.org>
768
769 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
770 coding-system ASCII compatible only when it does not produce BOM
771 on encoding (Bug#10383).
772
773 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
774
775 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
776 can scroll.
777 (create_and_show_popup_menu): Always use menu_position_func for
778 Gtk3 (Bug#10361).
779
780 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
781
782 * callint.c (Fcall_interactively): Don't truncate prompt string.
783
784 2011-12-23 Eli Zaretskii <eliz@gnu.org>
785
786 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
787 property that ends at ZV, so that the bidi iteration could be
788 resumed from there (after widening). (Bug#10360)
789
790 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
791
792 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
793
794 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
795
796 * nsterm.m (x_free_frame_resources):
797 Release f->output_data.ns->miniimage.
798 (ns_index_color): Fix indentation. Do not retain
799 color_table->colors[i].
800
801 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
802 before returning.
803
804 * nsfns.m (x_set_background_color): Assign return value from
805 ns_index_color to face-background instead of NSColor*.
806 (ns_implicitly_set_icon_type): Fix indentation.
807 Change assignment in for loop to comparison.
808
809 * emacs.c (ns_pool): New variable.
810 (main): Assign ns_pool.
811 (Fkill_emacs): Call ns_release_autorelease_pool.
812
813 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
814 autorelease fdesc, release fdAttrs and tdict.
815 (ns_get_covering_families): Release charset.
816 (ns_findfonts): Release NSFontDescriptor created with new.
817 (ns_uni_to_glyphs): Fix indentation.
818 (setString): Release attrStr before assigning new value.
819
820 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
821
822 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
823 and NS_IMPL_COCOA.
824 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
825 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
826
827 2011-12-18 David Reitter <reitter@cmu.edu>
828
829 * nsterm.m (ns_term_init): Subscribe for notifications
830 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
831 to method trackingNotification in EmacsMenu.
832
833 * nsmenu.m (trackingMenu): New variable.
834 (trackingNotification): New method (from Aquamacs).
835 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
836 from Aquamacs (Bug#7030).
837
838 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
839
840 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
841 (symbol_to_nsstring): Fix indentation.
842 (ns_symbol_to_pb): New function.
843 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
844 (Fns_rotate_cut_buffers_internal): Remove.
845 (Fns_store_selection_internal): Rename from
846 Fns_store_cut_buffer_internal.
847 (ns_get_foreign_selection, Fx_own_selection_internal)
848 (Fx_disown_selection_internal, Fx_selection_exists_p)
849 (Fns_get_selection_internal, Fns_store_selection_internal):
850 Use ns_symbol_to_pb and check if return value is nil.
851 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
852 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
853 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
854 renamed to Sns_store_selection_internal.
855 (ns_handle_selection_request): Move code to Fx_own_selection_internal
856 and remove this function.
857 (ns_handle_selection_clear): Remove, never used.
858 (Fx_own_selection_internal): Move code from ns_handle_selection_request
859 here.
860
861 2011-12-17 Ken Brown <kbrown@cornell.edu>
862
863 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
864 GID is unknown (Bug#10257).
865
866 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
867
868 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
869 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
870 which caused a build failure on GNU/Linux IA-64. This problem was
871 introduced by my 2011-10-07 patch.
872
873 2011-12-15 Juri Linkov <juri@jurta.org>
874
875 * image.c (imagemagick_error): New function. (Bug#10112)
876 (imagemagick_load_image): Comment out `MagickSetResolution' call.
877 Use `imagemagick_error' where ImageMagick functions return
878 `MagickFalse'.
879 (Fimagemagick_types): Add `Fnreverse' to return the list in the
880 proper order.
881
882 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
883
884 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
885 fill background (Bug#8992).
886
887 2011-12-13 Martin Rudalics <rudalics@gmx.at>
888
889 * window.c (Vwindow_combination_resize)
890 (Vwindow_combination_limit): Use t instead of non-nil in
891 doc-strings.
892 (Vrecenter_redisplay): Add first sentence of doc-string on
893 separate line.
894 (Frecenter): Fix doc-string typo.
895
896 2011-12-11 Kenichi Handa <handa@m17n.org>
897
898 * coding.c (Funencodable_char_position): Pay attention to the
899 buffer text relocation (Bug#9389).
900
901 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
902
903 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
904 gtk_init (Bug#10100).
905
906 2011-12-10 Eli Zaretskii <eliz@gnu.org>
907
908 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
909 IT->string is nil. (Bug#10263)
910
911 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
912
913 * nsterm.h (x_free_frame_resources): Declare.
914
915 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
916 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
917
918 * nsterm.h (ns_get_defaults_value): Declare.
919
920 * nsterm.m (ns_default): Call ns_get_defaults_value.
921
922 2011-12-09 Eli Zaretskii <eliz@gnu.org>
923
924 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
925 (Bug#10170)
926
927 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
928
929 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
930 that where the value of an _OBJC_* symbol points to is in the .bss
931 section (Bug#10240).
932
933 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
934
935 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
936 after the loop to call ccl_driver at least once (Bug#8619).
937
938 2011-12-08 Kenichi Handa <handa@m17n.org>
939
940 * ftfont.c (get_adstyle_property): Fix previous change
941 (Bug#10233).
942
943 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
944
945 * w32.c (init_environment): If no_site_lisp, remove site-lisp
946 dirs from the default value of EMACSLOADPATH (bug#10208).
947
948 2011-12-07 Glenn Morris <rgm@gnu.org>
949
950 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
951 installation and source directories as well. (Bug#10208)
952
953 2011-12-06 Chong Yidong <cyd@gnu.org>
954
955 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
956
957 2011-12-06 Glenn Morris <rgm@gnu.org>
958
959 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
960 as an error, not just -1. (Bug#10217)
961
962 2011-12-05 Chong Yidong <cyd@gnu.org>
963
964 * keyboard.c (process_special_events): New function.
965 (swallow_events, Finput_pending_p): Use it (Bug#10195).
966
967 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
968
969 * coding.c (encode_designation_at_bol): Don't use uninitialized
970 local variable (Bug#9318).
971
972 2011-12-05 Kenichi Handa <handa@m17n.org>
973
974 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
975 return Qnil (Bug#8046, Bug#10193).
976
977 2011-12-05 Kenichi Handa <handa@m17n.org>
978
979 * coding.c (encode_designation_at_bol): New args charbuf_end and
980 dst. Return the number of produced bytes. Callers changed.
981 (coding_set_source): Return how many bytes coding->source was
982 relocated.
983 (coding_set_destination): Return how many bytes
984 coding->destination was relocated.
985 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
986 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
987
988 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
989
990 * coding.c (CODING_CHAR_CHARSET_P): New macro.
991 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
992 macro (Bug#9318).
993
994 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
995
996 The following changes are to fix Bug#9318.
997
998 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
999 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1000 (encode_coding_iso_2022, encode_coding_sjis)
1001 (encode_coding_big5, encode_coding_charset): Use the above macros.
1002
1003 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1004
1005 * lisp.h (process_quit_flag): Fix external declaration.
1006
1007 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1008
1009 Don't macro-inline non-performance-critical code.
1010 * eval.c (process_quit_flag): New function.
1011 * lisp.h (QUIT): Use it.
1012
1013 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1014
1015 * nsfns.m (get_geometry_from_preferences): New function.
1016 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1017
1018 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1019
1020 * emacs.c (Qkill_emacs): Define.
1021 (syms_of_emacs): Initialize it.
1022 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1023 Qquit_flag to `kill-emacs' instead.
1024 (quit_throw_to_read_char): Add parameter `from_signal'.
1025 All callers changed. Call Fkill_emacs if requested and safe.
1026 * lisp.h (QUIT): Call Fkill_emacs if requested.
1027
1028 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1029
1030 * widget.c (update_wm_hints): Return if wmshell is null.
1031 (widget_update_wm_size_hints): New function.
1032
1033 * widget.h (widget_update_wm_size_hints): Declare.
1034
1035 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1036 widget_update_wm_size_hints (Bug#10104).
1037
1038 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1039
1040 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1041 before a newline, prepare the bidi iterator for consuming the
1042 newline, and keep the current paragraph direction. (Bug#10183)
1043 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1044
1045 2011-12-02 Juri Linkov <juri@jurta.org>
1046
1047 * search.c (Fword_search_regexp): New Lisp function created from
1048 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1049 (Fword_search_backward, Fword_search_forward)
1050 (Fword_search_backward_lax, Fword_search_forward_lax):
1051 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1052 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1053
1054 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1055
1056 * fileio.c (Finsert_file_contents): Move after-change-function call
1057 to before the "handled:" label, since all "goto handled" appear in
1058 cases where the *-change-functions have already been properly called
1059 (bug#10117).
1060
1061 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1062
1063 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1064 waiting for input. (Bug#10169)
1065
1066 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1067
1068 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1069 verifies glyph row's hash code--we have just reallocated the
1070 glyphs, so their contents can be complete garbage. (Bug#10164)
1071
1072 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1073
1074 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1075
1076 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1077
1078 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1079 attributes are tested _before_ calling verify_row_hash, to protect
1080 against GCC re-ordering of the tests. (Bug#10164)
1081
1082 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1083
1084 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1085
1086 * xterm.c (handle_one_xevent): Only set async_visible and friends
1087 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1088 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1089 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1090
1091 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1092
1093 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1094 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1095 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1096 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1097 All uses changed to use GCPRO1 etc.
1098 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1099 Revert to old implementation (i.e., before 2011-03-11).
1100
1101 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1102
1103 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1104 of scroll runs so as to avoid assigning disabled bogus rows and
1105 unnecessary graphics copy operations.
1106
1107 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1108
1109 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1110 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1111 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1112 (malloc, free, realloc, calloc): Redirect to e_* only when
1113 compiling Emacs.
1114
1115 * lisp.h (GCTYPEBITS): Move before first use.
1116 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1117 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1118 this macro definition.
1119
1120 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1121 _MSC_VER.
1122
1123 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1124
1125 * gtkutil.c (xg_create_frame_widgets):
1126 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1127 present with Gtk+ 2.0.
1128
1129 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1130
1131 * fileio.c (Finsert_file_contents): Undo previous change; see
1132 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1133
1134 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1135
1136 Rename locals to avoid shadowing.
1137 * fileio.c (Finsert_file_contents):
1138 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1139 * process.c (wait_reading_process_output):
1140 Rename inner 'proc' to 'p' to avoid shadowing.
1141 Indent for consistency with usual Emacs style.
1142
1143 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1144
1145 * xdisp.c (redisplay_window): If cursor row is not fully visible
1146 after recentering, and scroll-conservatively is set to a large
1147 number, scroll window by a few more lines to make the cursor fully
1148 visible and out of scroll-margin. (Bug#10105)
1149 (start_display): Don't move to the next line if the display should
1150 start at a newline that is part of a display vector or an overlay
1151 string. (Bug#10119)
1152
1153 2011-11-24 Juri Linkov <juri@jurta.org>
1154
1155 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1156 after the `MagickPingImage' call. (Bug#10112)
1157
1158 2011-11-23 Chong Yidong <cyd@gnu.org>
1159
1160 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1161
1162 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1163
1164 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1165 making another buffer current. (Bug#10114)
1166
1167 2011-11-23 Glenn Morris <rgm@gnu.org>
1168
1169 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1170
1171 2011-11-23 Chong Yidong <cyd@gnu.org>
1172
1173 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1174 using it (Bug#5984).
1175
1176 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1177
1178 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1179 and header-lines, as they don't have one computed for them.
1180 (Bug#10098)
1181
1182 * .gdbinit (prow): Make displayed values more self-explaining.
1183 Add row's hash code.
1184
1185 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1186
1187 * process.c (wait_reading_process_output): Fix asynchrounous
1188 GnuTLS socket handling on some versions of the GnuTLS library.
1189 (wait_reading_process_output): Add comment and URL.
1190
1191 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1192
1193 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1194
1195 2011-11-21 Chong Yidong <cyd@gnu.org>
1196
1197 * window.c (Fnext_window, Fprevious_window): Doc fix.
1198
1199 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1200
1201 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1202
1203 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1204
1205 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1206
1207 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1208
1209 * window.c (Fset_window_combination_limit): Rename argument
1210 STATUS to LIMIT.
1211 (Vwindow_combination_limit): Remove "status" from doc-string.
1212
1213 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1214
1215 * m/ibms390.h: Remove.
1216 * m/ibms390x.h: Don't include "ibms390.h".
1217
1218 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1219
1220 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1221 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1222
1223 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1224
1225 * casetab.c (Fset_case_table):
1226 * charset.c (Fcharset_after): Fix typos.
1227
1228 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1229
1230 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1231 Otherwise, valgrind does not work on some platforms.
1232 Problem reported by Andreas Schwab in
1233 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1234 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1235 is set, removing the need for VIRT_ADDRESS_VARIES.
1236 (PURE_P): Use a more-efficient implementation that needs just one
1237 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1238 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1239 to 4 (xorl, subq, cmpq, setbe).
1240 * alloc.c (pure): Always extern now, since that's the
1241 VIRT_ADDR_VARIES behavior.
1242 (PURE_POINTER_P): Use a single comparison, not two, for
1243 consistency with the new puresize.h.
1244 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1245 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1246 Remove VIRT_ADDR_VARIES no longer needed.
1247
1248 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1249
1250 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1251 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1252 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1253 behave as if the cursor position were at the window margin.
1254
1255 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1256 and the cursor position is out of bounds, behave as if the cursor
1257 position were at the window margin. (Bug#10075)
1258
1259 2011-11-18 Chong Yidong <cyd@gnu.org>
1260
1261 * window.c (Fwindow_combination_limit): Make first argument
1262 non-optional, since it is meaningless for live windows like the
1263 selected window.
1264
1265 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1266
1267 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1268
1269 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1270
1271 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1272 (graft_intervals_into_buffer): Simplify.
1273
1274 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1275
1276 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1277 hash values of the two rows.
1278 (copy_row_except_pointers): Preserve the used[] arrays and the
1279 hash values of the two rows. (Bug#10035)
1280 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1281
1282 * xdisp.c (row_hash): New function, body extracted from
1283 compute_line_metrics.
1284 (compute_line_metrics): Call row_hash, instead of computing the
1285 hash code inline.
1286
1287 * dispnew.c (verify_row_hash): Call row_hash for computing the
1288 hash code of a row, instead of duplicating code from xdisp.c.
1289
1290 * dispextern.h (row_hash): Add prototype.
1291
1292 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1293
1294 * frame.c (delete_frame): Don't delete the terminal when the last
1295 X frame is closed if emacs is built with GTK toolkit.
1296
1297 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1298
1299 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1300
1301 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1302
1303 * window.c (Vwindow_splits): Rename to
1304 Vwindow_combination_resize. Suggested by Juri Linkov.
1305 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1306 of Vwindow_splits.
1307
1308 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1309
1310 * nsfns.m (Fns_font_name):
1311 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1312
1313 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1314
1315 * window.h (window): Rename slot "nest" to "combination_limit".
1316 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1317 (Fset_window_nest): Rename to Fset_window_combination_limit.
1318 (Vwindow_nest): Rename to Vwindow_combination_limit.
1319 (recombine_windows, make_parent_window, make_window)
1320 (Fsplit_window_internal, saved_window)
1321 (Fset_window_configuration, save_window_save): Rename all
1322 occurrences of window_nest to window_combination_limit.
1323
1324 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1325
1326 * image.c (imagemagick_load_image): Fix typo.
1327
1328 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1329
1330 * xdisp.c (display_line): Move the call to
1331 highlight_trailing_whitespace before the call to
1332 compute_line_metrics, since the latter needs to see the final
1333 faces of all the glyphs to compute ROW's hash value.
1334 Fixes assertion violations in row_equal_p. (Bug#10035)
1335
1336 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1337
1338 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1339 just return (bug#10044).
1340
1341 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1342
1343 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1344 with user-defined heap size. Bump the default size of the temacs
1345 heap to 27MB, to avoid memory warning when running temacs.
1346 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1347
1348 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1349 current_matrix and desired_matrix. (Bug#9990)
1350 (verify_row_hash) [XASSERTS]: New function.
1351 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1352 that the hash value of glyph rows is correct.
1353
1354 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1355
1356 * window.h (window): Remove splits slot.
1357 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1358 (Fdelete_other_windows_internal, make_parent_window)
1359 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1360 (Fset_window_configuration, save_window_save): Don't deal with
1361 split status of windows.
1362 (saved_window): Remove splits slot.
1363 (Vwindow_splits): Rewrite doc-string.
1364
1365 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1366
1367 * xfns.c (unwind_create_frame):
1368 * nsfns.m (unwind_create_frame):
1369 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1370 Vframe_list (Bug#9999).
1371
1372 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1373
1374 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1375
1376 2011-11-11 Kenichi Handa <handa@m17n.org>
1377
1378 * callproc.c (Fcall_process): Set the member dst_multibyte of
1379 process_coding.
1380
1381 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1382
1383 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1384 avoid a crash (bug#9496).
1385
1386 2011-11-09 Chong Yidong <cyd@gnu.org>
1387
1388 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1389 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1390
1391 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1392
1393 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1394
1395 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1396
1397 Avoid some portability problems by eschewing 'extern inline' functions.
1398 The trivial performance wins aren't worth the portability hassles; see
1399 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1400 et seq.
1401 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1402 (window_box_width, window_box_left, window_box_left_offset)
1403 (window_box_right, window_box_right_offset): Undo previous change,
1404 by removing the "extern"s.
1405 * intervals.c (adjust_intervals_for_insertion)
1406 (adjust_intervals_for_deletion): Undo previous change,
1407 making these static again.
1408 (offset_intervals, temp_set_point_both, temp_set_point)
1409 (copy_intervals_to_string): No longer inline.
1410 * xdisp.c (window_text_bottom_y, window_box_width)
1411 (window_box_height, window_box_left_offset)
1412 (window_box_right_offset, window_box_left, window_box_right)
1413 (window_box): No longer inline.
1414
1415 2011-11-08 Chong Yidong <cyd@gnu.org>
1416
1417 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1418 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1419 Signal an error if not a live window.
1420 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1421 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1422
1423 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1424
1425 * lisp.h (syms_of_abbrev): Remove declaration.
1426 Reported by CHENG Gao <chenggao@royau.me>.
1427
1428 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1429
1430 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1431 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1432 of temacs in GUI mode.
1433
1434 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1435
1436 * window.h: Declare delete_all_child_windows instead of
1437 delete_all_subwindows.
1438 * window.c (Fwindow_nest, Fset_window_nest)
1439 (Fset_window_new_total, Fset_window_new_normal)
1440 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1441 (delete_all_subwindows): Rename to delete_all_child_windows.
1442 (Fdelete_other_windows_internal, Fset_window_configuration):
1443 Call delete_all_child_windows instead of delete_all_subwindows.
1444 * frame.c (delete_frame): Call delete_all_child_windows instead
1445 of delete_all_subwindows.
1446
1447 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1448
1449 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1450 This is also needed for porting to any host where GC_MARK_STACK is
1451 not GC_MAKE_GCPROS_NOOPS.
1452 (which_symbols): Use it.
1453
1454 2011-11-07 Kenichi Handa <handa@m17n.org>
1455
1456 * coding.c (coding_set_destination): Check coding->src_pos only
1457 when coding->src_object is a buffer (bug#9910).
1458
1459 * process.c (send_process): Set the member src_multibyte of coding
1460 to 0 (bug#9911) when sending a unibyte text.
1461
1462 * callproc.c (Fcall_process): Set the member src_multibyte of
1463 process_coding to 0 (bug#9912).
1464
1465 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1466
1467 * xmenu.c (cleanup_widget_value_tree): New function.
1468 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1469 calling free_menubar_widget_value_tree directly (Bug#9830).
1470
1471 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1472
1473 Fix some portability problems with 'inline'.
1474 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1475 (window_box_width, window_box_left, window_box_left_offset)
1476 (window_box_right, window_box_right_offset): Declare extern.
1477 Otherwise, these inline functions do not conform to C99 and
1478 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1479 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1480 * intervals.c (adjust_intervals_for_insertion)
1481 (adjust_intervals_for_deletion): Now extern, because otherwise the
1482 extern inline functions 'offset_intervals' couldn't refer to it.
1483 (static_offset_intervals): Remove.
1484 (offset_intervals): Rewrite using the old contents of
1485 static_offset_intervals. The old version didn't conform to C99
1486 because an extern inline function contained a reference to an
1487 identifier with static linkage.
1488
1489 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1490
1491 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1492 GC.
1493
1494 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1495
1496 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1497 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1498 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1499 return Qleft_to_right.
1500
1501 2011-11-06 Chong Yidong <cyd@gnu.org>
1502
1503 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1504 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1505 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1506 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1507 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1508 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1509 (Fwindow_vscroll): Doc fix.
1510 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1511 argument, since it makes no sense to pass a live window and for
1512 consistency with window-child.
1513
1514 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1515
1516 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1517 support MSVC.
1518
1519 2011-11-05 Jason Rumney <jasonr@gnu.org>
1520
1521 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1522 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1523 fonts (Bug#6029).
1524 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1525 bitwise arithmetic preventing use of unicode-sip and non-truetype
1526 opentype fonts.
1527
1528 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1529
1530 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1531 "emacs"-only part.
1532
1533 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1534 initialization code to keep similarity to xfns.c after changes
1535 from 2011-11-05.
1536
1537 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1538
1539 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1540 (unwind_create_frame): New function (Bug#9943).
1541 (Fx_create_frame): Restructure code to be more similar to the one in
1542 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1543 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1544 Move terminal->reference_count++ just before making the frame official
1545 (Bug#9943).
1546
1547 * nsterm.m (x_free_frame_resources): New function.
1548 (x_destroy_window): Move code to x_free_frame_resources.
1549
1550 * xfns.c (unwind_create_frame): Fix comment.
1551 (Fx_create_frame, x_create_tip_frame):
1552 Move terminal->reference_count++ just before making the frame
1553 official. Move initialization of image_cache_refcount and
1554 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1555
1556 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1557
1558 Support MSVC build with newer versions of Visual Studio.
1559 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1560 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1561 nt/gmake.defs.
1562
1563 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1564 which are not supported by MSVC.
1565 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1566 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1567 bitfields.
1568 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1569 types in bitfields.
1570 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1571
1572 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1573
1574 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1575
1576 Support MSVC build with newer versions of Visual Studio.
1577 * w32.c: Don't include w32api.h for MSVC.
1578 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1579
1580 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1581 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1582 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1583 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1584 e_* cousins.
1585 (alloca) [_MSC_VER]: Define to _alloca.
1586
1587 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1588
1589 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1590
1591 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1592
1593 * xdisp.c (note_mouse_highlight): If either of
1594 previous/next-single-property-change returns nil, treat that as
1595 the beginning or the end of the buffer. (Bug#9955)
1596
1597 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1598
1599 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1600 label is not null (Bug#9951).
1601 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1602 may be NULL.
1603
1604 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1605
1606 * window.c (Fwindow_body_size): Mention in the doc string that the
1607 return value is in frame's canonical units. (Bug#9949)
1608
1609 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1610
1611 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1612
1613 * w32fns.c (unwind_create_frame): If needed, free the glyph
1614 matrices of the partially constructed frame. (Bug#9943)
1615 * xfns.c (unwind_create_frame): Likewise.
1616
1617 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1618
1619 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1620 Don't stop backward scan on the continuation glyph, even though
1621 its CHARPOS is positive.
1622 (mouse_face_from_buffer_pos, note_mouse_highlight):
1623 Rename cover_string to disp_string.
1624
1625 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1626
1627 * window.c (temp_output_buffer_show): Don't use
1628 Vtemp_buffer_show_specifiers.
1629 (Vtemp_buffer_show_specifiers): Remove unused variable.
1630
1631 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1632
1633 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1634 past the beginning of the current glyph matrix.
1635
1636 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1637
1638 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1639 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1640 HAVE_GTK3 (Bug#9869).
1641
1642 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1643 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1644
1645 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1646
1647 * xterm.c: Declare x_handle_net_wm_state to return int.
1648 (handle_one_xevent): Check if we are iconified but don't have
1649 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1650 (get_current_wm_state): Return non-zero if not hidden,
1651 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1652 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1653 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1654 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1655
1656 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1657
1658 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1659 so that this new function doesn't get optimized away by a
1660 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1661
1662 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1663
1664 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1665
1666 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1667
1668 Fix the `xbytecode' command.
1669 * .gdbinit (xprintbytestr): New command.
1670 (xwhichsymbols): Rename from `which'; all callers changed.
1671 (xbytecode): Print the byte-code string as well.
1672
1673 2011-10-29 Kim Storm <storm@cua.dk>
1674
1675 * alloc.c (which_symbols): New function.
1676
1677 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1678
1679 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1680 line. (Bug#9903)
1681
1682 2011-10-29 Glenn Morris <rgm@gnu.org>
1683
1684 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1685 Not clear what it was for, and it causes various bugs. (Bug#9839)
1686
1687 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1688
1689 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1690 possible random value that matches one of those tested as
1691 condition to clear the mouse face.
1692
1693 2011-10-28 Chong Yidong <cyd@gnu.org>
1694
1695 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1696
1697 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1698
1699 * window.c (make_window): Initialize phys_cursor_on_p.
1700
1701 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1702
1703 * lisp.h (struct Lisp_Symbol): Update comments.
1704
1705 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1706
1707 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1708
1709 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1710
1711 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1712 <oslsachem@gmail.com> for helping to debug this.
1713
1714 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1715 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1716 (g_b_init_get_glyph_outline_w): New static variables.
1717 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1718 (GetGlyphOutlineW_Proc): New typedefs.
1719 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1720 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1721 New functions.
1722 (w32font_open_internal, compute_metrics):
1723 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1724 instead of calling the "wide" APIs directly.
1725
1726 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1727
1728 * w32.h (syms_of_w32font): Add prototype.
1729
1730 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1731
1732 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1733 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1734 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1735 (Fmove_to_window_line): Doc fix.
1736
1737 2011-10-27 Chong Yidong <cyd@gnu.org>
1738
1739 * process.c (make_process): Set gnutls_state to NULL.
1740
1741 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1742 non-NULL, regardless of GNUTLS_INITSTAGE.
1743 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1744 an error. Set process slots as soon as we allocate them.
1745
1746 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1747
1748 2011-10-27 Chong Yidong <cyd@gnu.org>
1749
1750 * gnutls.c (emacs_gnutls_deinit): New function.
1751 Deallocate credentials structures as well as calling gnutls_deinit.
1752 (Fgnutls_deinit, Fgnutls_boot): Use it.
1753
1754 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1755 (deactivate_process): Call emacs_gnutls_deinit.
1756
1757 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1758
1759 * image.c (x_create_x_image_and_pixmap):
1760 * w32.c (sys_rename, w32_delayed_load):
1761 * w32font.c (fill_in_logfont):
1762 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1763
1764 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1765
1766 * w32fns.c (w32_default_color_map): New function,
1767 extracted from Fw32_default_color_map.
1768 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1769
1770 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1771
1772 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1773
1774 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1775
1776 * keyboard.c (test_undefined): New function (bug#9751).
1777 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1778
1779 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1780
1781 * sysdep.c (init_sys_modes): Fix the check for the controlling
1782 terminal (Bug#6649).
1783
1784 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1785
1786 * dispextern.h (struct bidi_it): New member next_en_type.
1787
1788 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1789 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1790 current character, check also for next_en_type being WEAK_EN.
1791 (bidi_resolve_weak): Don't enter the expensive loop if the current
1792 position is before next_en_pos. Record the bidi type of the first
1793 non-ET, non-BN character we find, in addition to its position.
1794 (bidi_level_of_next_char): Invalidate next_en_type when
1795 next_en_pos is over-stepped.
1796
1797 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1798
1799 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1800 * editfns.c: Rewrite current-time-zone so that it invokes
1801 the equivalent of (format-time-string "%Z") to get the time zone name.
1802 This fixes a bug when the time zone name contains characters that
1803 need converting from the system time locale to Emacs internal format.
1804 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1805 that patch fixed format-time-string to do the conversion, but
1806 I forgot to fix current-time-zone.
1807 (format_time_string): New function, containing most of
1808 what Fformat_time_string used to contain.
1809 (Fformat_time_string): Rewrite in terms of format_time_string.
1810 This doesn't change this function's behavior.
1811 (current-time-zone): Rewrite to use format_time_string.
1812 This fixes the bug reported by Michael Schierl in
1813 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1814 Jason Rumney's 2007-06-07 change worked around this bug, but
1815 didn't fix it.
1816 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1817
1818 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1819
1820 * xdisp.c (start_display): If the character at POS is displayed
1821 via a display vector, reset IT->current.dpvec_index to zero.
1822 (try_window_reusing_current_matrix): If a line ends in a display
1823 vector or the next line starts in a display vector, continue
1824 redrawing the window even though the character position of
1825 start_row was reached.
1826 (Bug#9771, part 2)
1827
1828 2011-10-18 Chong Yidong <cyd@gnu.org>
1829
1830 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1831 with nobreak-char-display too.
1832
1833 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1834
1835 Fix part 3 of bug#9771.
1836 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1837 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1838 non-neutral characters if the current character is a paragraph
1839 separator (a.k.a. Newline). This avoids running the same
1840 expensive loop twice, once when we consume the preceding newline
1841 and the other time when the line actually needs to be displayed.
1842 Avoid the loop when we see neutrals on the base embedding level
1843 following a character whose directionality is the same as the
1844 paragraph's. This avoids running the expensive loop when a line
1845 ends in a long sequence of neutrals, like control characters.
1846 Add assertion against STRONG_AL type. Slightly rearrange code
1847 that determines the type of a neutral given the first non-neutral
1848 that follows it.
1849 (bidi_level_of_next_char): Set next_en_pos to zero when
1850 invalidating its info.
1851
1852 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1853
1854 * xdisp.c (push_display_prop): Determine whether to record string
1855 or buffer position by IT->string, not by IT->method. Allow
1856 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1857 (move_it_vertically_backward): Don't look for character position
1858 immediately after the newline when in a continuation line.
1859 (Bug#9771, part 1)
1860
1861 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1862
1863 * window.c (coordinates_in_window): Rewrite and delabelize
1864 vertical border check. (Bug#5357) (Bug#9618)
1865
1866 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1867
1868 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1869 errors in XSetWindowBorder (bug#9310).
1870
1871 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1872
1873 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1874 avoid crash when xmalloc overrun checking is enabled.
1875
1876 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1877
1878 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1879 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1880 cursor motion with <left> and <right> arrow keys.
1881
1882 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1883 some callers set that themselves.
1884
1885 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1886
1887 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1888 display string and the previous row comes from the same string and
1889 is empty. (Bug#9739) (Bug#9738)
1890
1891 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1892
1893 * doc.c (get_doc_string): Encode file name (bug#9735).
1894
1895 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1896
1897 * bidi.c (bidi_level_of_next_char):
1898 * xdisp.c (get_visually_first_element): Remove old incorrect
1899 comments regarding the Unicode Line Separator character.
1900
1901 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1902
1903 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1904
1905 * alloc.c (Fgc_status): Do not access beyond zombies array
1906 boundary if nzombies > MAX_ZOMBIES.
1907 * alloc.c (dump_zombies): Add missing format specifier.
1908
1909 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1910
1911 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1912 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1913
1914 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1915 Some packages use them to denote characters with modifiers.
1916
1917 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1918
1919 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1920 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1921 matching a pp-number. Rename parameter var to var1.
1922
1923 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1924
1925 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1926
1927 2011-10-08 Glenn Morris <rgm@gnu.org>
1928
1929 * callint.c (Fcall_interactively): Give a more explicit error for the
1930 'c' case with a non-character input. (Bug#8479)
1931
1932 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1933
1934 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1935 lines.
1936 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1937 lines that are hscrolled on the left.
1938
1939 * dispnew.c (buffer_posn_from_coords): Account for a possible
1940 presence of header-line. (Bug#4426)
1941
1942 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1943
1944 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1945 Don't advertise functionality which we discourage or doesn't work.
1946
1947 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1948
1949 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1950 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1951 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1952 this makes Emacs dump core during garbage collection on rare
1953 occasions. sizeof is obviously inferior to offsetof here, so
1954 stick with offsetof.
1955 (GC_POINTER_ALIGNMENT): New macro.
1956 (mark_memory): Omit 3rd (offset) arg; caller changed.
1957 Don't assume EMACS_INT alignment is the same as pointer alignment.
1958
1959 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1960
1961 * keyboard.c (read_key_sequence_remapped): New var.
1962 (read_key_sequence): Compute remapping in the right buffer.
1963 (command_loop_1): Use read_key_sequence's remapping directly.
1964
1965 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1966
1967 * dired.c (file_name_completion): Don't expand file name.
1968 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1969 before checking file name handler.
1970
1971 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1972 they've been requested explicitly (bug#9591).
1973
1974 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1975
1976 * keymap.c (Fsingle_key_description): Use make_specified_string
1977 instead of build_string to build string from push_key_description.
1978 (Bug#5193)
1979
1980 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1981
1982 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1983 This fixes a Y2038 bug on 64-bit hosts.
1984 * buffer.c (reset_buffer):
1985 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1986 (Fclear_buffer_auto_save_failure):
1987 Use 0, not -1, to represent an unset failure time, since time_t
1988 might not be signed.
1989
1990 Remove dependency on glibc malloc internals.
1991 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1992 Move back here from lisp.h, but with their new implementations.
1993 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1994 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1995 * charset.c (charset_table_init): New static var.
1996 (syms_of_charset): Use it instead of xmalloc. This removes a
1997 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1998 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1999 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2000 Move back to alloc.c.
2001 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2002 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2003
2004 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2005
2006 * nsterm.m (windowDidResize): Call x_set_window_size only when
2007 ns_in_resize is true. Otherwise set pixelwidth/height and
2008 call change_frame_size (Bug#9628).
2009
2010 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2011
2012 Port --enable-checking=all to Fedora 14 x86-64.
2013 * charset.c (syms_of_charset): Also account for glibc malloc's
2014 internal overhead when calculating the initial malloc maximum.
2015
2016 Port --enable-checking=all to Fedora 14 x86.
2017 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2018 Move to lisp.h.
2019 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2020 (overrun_check_realloc, overrun_check_free):
2021 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2022 That way, xmalloc returns a properly-aligned pointer even if
2023 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2024 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2025 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2026 into account when calculating the initial malloc maximum.
2027 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2028 Move here from alloc.c, so that charset.c can use it too.
2029 Properly align; the old code wasn't right for common 32-bit hosts
2030 when configured with --enable-checking=all.
2031 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2032 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2033
2034 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2035
2036 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2037 use EDOM.
2038
2039 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2040
2041 * xdisp.c (compute_display_string_end): If there's no display
2042 string at CHARPOS, return -1.
2043
2044 * bidi.c (bidi_fetch_char): When compute_display_string_end
2045 returns a negative value, treat the character as a normal
2046 character not covered by a display string. (Bug#9624)
2047
2048 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2049
2050 * lread.c (Fread_from_string): Fix typo in docstring.
2051
2052 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2053
2054 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2055 newline, reseat the iterator instead of bidi-iterating there one
2056 character at a time. (Bug#9610)
2057 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2058 TO_CHARPOS if the bidi iterator is at base embedding level.
2059
2060 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2061
2062 * lread.c (readevalloop): Use correct code for NBSP.
2063 (read1): Likewise. (Bug#9608)
2064
2065 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2066
2067 * dbusbind.c (Fdbus_register_signal): When service is not
2068 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2069
2070 2011-09-25 Glenn Morris <rgm@gnu.org>
2071
2072 * buffer.c (truncate-lines): Doc fix.
2073
2074 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2075
2076 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2077 (Fset_window_next_buffers): Doc fix.
2078
2079 2011-09-24 Glenn Morris <rgm@gnu.org>
2080
2081 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2082
2083 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2084
2085 Fix minor problems found by static checking.
2086 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2087 * indent.c (Fvertical_motion): Fix == vs = typo.
2088
2089 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2090
2091 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2092 Default value is now t. Doc fix.
2093
2094 * indent.c (Fvertical_motion): Compute and apply the overshoot
2095 logic when moving up, not only when moving down. Fix the
2096 confusing name and values of the it_overshoot_expected variable;
2097 logic changes accordingly. (Bug#9254) (Bug#9549)
2098
2099 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2100 CHARPOS is covered by a display string which includes newlines.
2101 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2102 is covered by a display string with embedded newlines.
2103
2104 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2105
2106 * dbusbind.c (Fdbus_register_signal): Add match rule to
2107 Vdbus_registered_objects_table. (Bug#9581)
2108 (Fdbus_register_method, Vdbus_registered_objects_table):
2109 Fix docstring.
2110
2111 2011-09-24 Jim Meyering <meyering@redhat.com>
2112
2113 do not ignore write error for any output size
2114 The previous change was incomplete.
2115 While it makes emacs --batch detect the vast majority of stdout
2116 write failures, errors were still ignored whenever the output size is
2117 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2118 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2119 && echo FAIL: ignored write error
2120 FAIL: ignored write error
2121 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2122 && echo FAIL: ignored write error
2123 FAIL: ignored write error
2124 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2125
2126 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2127
2128 * emacs.c (Fkill_emacs): In noninteractive mode exit
2129 non-successfully if a write error occurred on stdout. (Bug#9574)
2130
2131 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2132
2133 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2134 the xassert test.
2135
2136 * dispextern.h (struct it): Update the comment documenting what
2137 can it->OBJECT be.
2138
2139 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2140
2141 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2142 a display string, extend search for cursor position to end of row.
2143 (find_row_edges): If the row ends in a newline from a display
2144 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2145 Handle the case of a display string with multiple newlines.
2146 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2147 non-empty line. Fixes confusing cursor motion with arrow keys at
2148 the beginning of a line that starts with whitespace.
2149
2150 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2151
2152 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2153 (bug#9493).
2154
2155 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2156
2157 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2158 boolean (Bug#9154).
2159
2160 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2161
2162 * xdisp.c (display_line): Record maximum and minimum buffer
2163 positions even if no glyphs were produced (e.g., by a zero-width
2164 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2165 buffer positions that will be removed from the glyph row because
2166 they don't fit.
2167 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2168 column is beyond frame width: don't subtract 1 "pixel" when
2169 computing width of the stretch.
2170 (reseat_at_next_visible_line_start): Undo the change made on
2171 2011-09-17 that saved paragraph information and restored it after
2172 the call to `reseat'. (Bug#9545)
2173
2174 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2175
2176 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2177 and turn window cursor on if cleared (Bug#9415).
2178
2179 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2180
2181 * search.c (boyer_moore): Take unibyte characters from pattern
2182 literally. (Bug#9458)
2183
2184 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2185
2186 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2187
2188 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2189
2190 Fix minor problem found by static checking.
2191 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2192 initialized, to pacify gcc -Wuninitialized.
2193
2194 * fileio.c: Report proper errno when syscall falls.
2195 (Finsert_file_contents): Save and restore errno,
2196 so that report_file_error outputs the correct diagnostic.
2197 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2198
2199 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2200
2201 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2202
2203 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2204
2205 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2206 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2207
2208 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2209
2210 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2211 about the current paragraph and restore it after the call to reseat.
2212
2213 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2214 (bidi_find_paragraph_start): Search back for paragraph beginning
2215 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2216 (bidi_move_to_visually_next): Only trigger paragraph-related
2217 computations when the last character is a newline or at EOB, not
2218 just any NEUTRAL_B. (Bug#9470)
2219
2220 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2221 truncated lines if point is covered by a display string. (Bug#9524)
2222
2223 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2224
2225 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2226 (cons_to_x_long): New function.
2227 (lisp_data_to_selection_data): Use it. Correct the test for
2228 short-versus-long data; it was negated. Break out of vector
2229 loop, for efficiency, when a long datum is discovered.
2230
2231 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2232
2233 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2234
2235 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2236
2237 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2238 GCC PR/17406) by declaring this function with external scope.
2239
2240 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2241
2242 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2243 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2244
2245 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2246
2247 * editfns.c (Fformat): Correctly handle text properties on "%%".
2248
2249 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2250
2251 * xterm.c (x_draw_composite_glyph_string_foreground):
2252 * w32term.c (x_draw_composite_glyph_string_foreground):
2253 * term.c (encode_terminal_code):
2254 * composite.c (composition_update_it, get_composition_id):
2255 * xdisp.c (get_next_display_element)
2256 (fill_composite_glyph_string): Add comments about special meaning
2257 of TAB characters in a composition.
2258
2259 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2260
2261 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2262 This occurs when processing a multibyte format.
2263 Problem reported by Wolfgang Jenker.
2264
2265 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2266
2267 * xdisp.c (try_cursor_movement): Only check for exact match if
2268 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2269
2270 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2271
2272 Remove unused external symbols.
2273 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2274 * xdisp.c (calc_pixel_width_or_height): Now static.
2275 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2276 * indent.c (check_display_width):
2277 * w32term.c: Fix comment to match code.
2278 * xterm.c, xterm.h (x_catching_errors): Remove.
2279
2280 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2281
2282 * xselect.c: Use signed conversions more consistently (Bug#9498).
2283 (selection_data_to_lisp_data): Assume incoming selection data are
2284 signed integers, not unsigned. This is to be consistent with
2285 outgoing selection data, which was modified to use signed integers
2286 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2287 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2288 expects long, not unsigned long.
2289
2290 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2291
2292 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2293 computation of loop end. Reported by Johan Bockgård
2294 <bojohan@gnu.org>.
2295
2296 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2297
2298 * frame.c (Fother_visible_frames_p): Function deleted.
2299
2300 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2301
2302 * indent.c (compute_motion): Process display vector front to back
2303 rather than the other way around. (Bug#2496)
2304
2305 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2306
2307 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2308
2309 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2310
2311 * minibuf.c (Fread_from_minibuffer): Doc fix.
2312
2313 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2314
2315 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2316 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2317
2318 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2319
2320 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2321 value for non-existent files.
2322
2323 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2324
2325 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2326 set its "size" to -1. This will set the modtime_size field of
2327 the corresponding buffer to -1, which is what
2328 verify-visited-file-modtime expects for files that do not exist.
2329 (Bug#9139)
2330
2331 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2332
2333 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2334 here ...
2335 * lisp.h: ... from here. push_key_description is no longer
2336 defined in keyboard.c, so its declaration should not be in
2337 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2338 logically belongs with push_key_description.
2339
2340 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2341
2342 * buffer.h: Include <sys/types.h> instead of <time.h>.
2343 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2344 Problem reported by Herbert J. Skuhra.
2345
2346 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2347
2348 * xml.c (parse_region): Make the parsing work for
2349 non-comment-starting XML files again (bug#9144).
2350
2351 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2352
2353 * image.c (gif_load): Fix calculation of bottom and right corner.
2354 (Bug#9468)
2355
2356 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2357
2358 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2359 redisplay in small windows.
2360
2361 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2362
2363 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2364
2365 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2366
2367 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2368 Operate on live windows only.
2369
2370 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2371
2372 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2373
2374 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2375
2376 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2377 only under bidi iteration.
2378
2379 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2380
2381 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2382
2383 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2384
2385 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2386 Without this fix, the command to link temacs failed due to an
2387 undefined symbol __builtin_isnan. This is because
2388 /usr/include/iso/math_c99.h #defines isnan(x) to
2389 __builtin_isnan(x), but the bundled gcc, which identifies itself
2390 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2391 a __builtin_isnan.
2392 * floatfns.c (isnan): #undef, and then #define to a clone of
2393 what's in data.c.
2394 (Fisnan): Always define, since it's always available now.
2395 (syms_of_floatfns): Always define isnan at the Lisp level.
2396
2397 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2398
2399 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2400
2401 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2402
2403 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2404 The previous code assumed that file offsets (off_t values) fit in
2405 EMACS_INT variables, which is not true on typical 32-bit hosts.
2406 The code messed up by falsely reporting buffer overflow in cases
2407 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2408 when "big" contains more than 2**29 bytes, even though this
2409 inserts just one byte and does not overflow the buffer.
2410 (Finsert_file_contents): Store file offsets as off_t
2411 values, not as EMACS_INT values. Check for overflow when
2412 converting between EMACS_INT and off_t. When checking for
2413 buffer overflow or for overlap, take the offsets into account.
2414 Don't use EMACS_INT for small values where int suffices.
2415 When checking for overlap, fix a typo: ZV was used where
2416 ZV_BYTE was intended.
2417 (Fwrite_region): Don't assume off_t fits into 'long'.
2418 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2419
2420 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2421
2422 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2423
2424 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2425
2426 sprintf-related integer and memory overflow issues (Bug#9412).
2427
2428 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2429 (esprintf, exprintf, evxprintf): New functions.
2430 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2431 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2432 (modify_event_symbol): Do not assume that the length of
2433 name_alist_or_stem is safe to alloca and fits in int.
2434 (Fexecute_extended_command): Likewise for function name and binding.
2435 (Frecursion_depth): Wrap around reliably on integer overflow.
2436 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2437 since some callers pass EMACS_INT values.
2438 (Fsingle_key_description): Don't crash if symbol name contains more
2439 than MAX_ALLOCA bytes.
2440 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2441 (get_minibuffer): Arg is now EMACS_INT, not int.
2442 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2443 (esprintf, exprintf, evxprintf): New decls.
2444 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2445
2446 * dbusbind.c (signature_cat): New function.
2447 (xd_signature, Fdbus_register_signal):
2448 Do not overrun buffer; instead, report string overflow.
2449
2450 * dispnew.c (add_window_display_history): Don't overrun buffer.
2451 Truncate instead; this is OK since it's just a log.
2452
2453 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2454 even if the time zone offset is outlandishly large.
2455 Don't mishandle offset == INT_MIN.
2456
2457 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2458 when creating daemon; the previous buffer-overflow check was incorrect.
2459
2460 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2461 which has the guts of the old verror function.
2462
2463 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2464 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2465
2466 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2467 (font_unparse_xlfd): Don't blindly alloca long strings.
2468 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2469 fits in int, when using sprintf. Use single snprintf to count
2470 length of string rather than counting it via multiple sprintfs;
2471 that's simpler and more reliable.
2472 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2473 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2474 sprintf, in case result does not fit in int.
2475
2476 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2477 (fontset_from_font): Print it.
2478
2479 * frame.c (tty_frame_count): Now printmax_t, not int.
2480 (make_terminal_frame, set_term_frame_name): Print it.
2481 (x_report_frame_params): In X, window IDs are unsigned long,
2482 not signed long, so print them as unsigned.
2483 (validate_x_resource_name): Check for implausibly long names,
2484 and don't assume name length fits in 'int'.
2485 (x_get_resource_string): Don't blindly alloca invocation name;
2486 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2487 not fit in int.
2488
2489 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2490 (xg_check_special_colors, xg_set_geometry):
2491 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2492
2493 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2494 Use esprintf, not sprintf, in case result does not fit in int.
2495
2496 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2497 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2498 it as a large positive number.
2499 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2500 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2501
2502 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2503 in case result does not fit in int.
2504
2505 * print.c (float_to_string): Detect width overflow more reliably.
2506 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2507 buffer overrun. Don't assume list length fits in 'int'. Treat
2508 print length of 0 as 0, not as infinity; to be consistent with other
2509 uses of print length in this function. Don't overflow print length
2510 index. Don't assume hash table size fits in 'long', or that
2511 vectorlike size fits in 'unsigned long'.
2512
2513 * process.c (make_process): Use printmax_t, not int, to format
2514 process-name gensyms.
2515
2516 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2517
2518 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2519 to avoid potential buffer overrun.
2520
2521 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2522 if X resource line is longer than 512 bytes.
2523
2524 * xfns.c (x_window): Make sprintf buffer a bit bigger
2525 to avoid potential buffer overrun.
2526
2527 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2528
2529 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2530
2531 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2532
2533 Integer overflow fixes for scrolling, etc.
2534 Without these, Emacs silently mishandles large integers sometimes.
2535 For example, "C-u 4294967297 M-x recenter" was treated as if
2536 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2537
2538 * xdisp.c (try_window_id): Check Emacs fixnum range before
2539 converting to 'int'.
2540
2541 * window.c (window_scroll_line_based, Frecenter):
2542 Check that an Emacs fixnum is in range before assigning it to 'int'.
2543 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2544 values converted from Emacs fixnums.
2545 (Frecenter): Don't wrap around a line count if it is out of 'int'
2546 range; instead, treat it as an extreme value.
2547 (Fset_window_configuration, compare_window_configurations):
2548 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2549
2550 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2551 that can exceed INT_MAX. Check that EMACS_INT value is in range
2552 before assigning it to the (possibly-narrower) index.
2553 (match_limit): Don't assume that a fixnum can fit in 'int'.
2554
2555 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2556 exceed INT_MAX.
2557
2558 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2559 (Fvertical_motion): Don't wrap around LINES values that don't fit
2560 in 'int'. Instead, treat them as extreme values. This is good
2561 enough for windows, which can't have more than INT_MAX lines anyway.
2562
2563 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2564
2565 * Require libxml/parser.h to avoid compilation warning.
2566
2567 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2568
2569 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2570 since this reportedly can destroy thread storage.
2571
2572 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2573
2574 * syntax.c (find_defun_start): Update all cache variables if
2575 exiting early (Bug#9401).
2576
2577 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2578
2579 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2580
2581 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2582 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2583 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2584
2585 * term.c (tty_append_glyph): New function.
2586 (produce_stretch_glyph): Static function and its prototype deleted.
2587
2588 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2589 Add prototypes.
2590
2591 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2592
2593 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2594 when checking :margin (Bug#9390).
2595 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2596 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2597 so that the name doesn't mislead. All uses changed.
2598
2599 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2600
2601 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2602 set_tty_hooks.
2603
2604 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2605
2606 * xdisp.c (move_it_to): Don't bail out early when reaching
2607 position beyond to_charpos, if we are scanning backwards.
2608 (move_it_vertically_backward): When DY == 0, make sure we get to
2609 the first character in the line after the newline.
2610
2611 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2612
2613 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2614 (ccl_driver): Do not generate an out-of-range pointer.
2615 (Fccl_execute_on_string): Remove unnecessary check for
2616 integer overflow, noted by Stefan Monnier in
2617 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2618 Remove a FIXME that didn't need fixing.
2619 Simplify the newly-introduced buffer reallocation code.
2620
2621 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2622
2623 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2624
2625 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2626
2627 Integer and memory overflow issues (Bug#9196).
2628
2629 * doc.c (get_doc_string): Rework so that
2630 get_doc_string_buffer_size is the actual buffer size, rather than
2631 being 1 less than the actual buffer size; this makes xpalloc more
2632 convenient.
2633
2634 * image.c (x_allocate_bitmap_record, cache_image):
2635 * xselect.c (Fx_register_dnd_atom):
2636 Simplify previous changes by using xpalloc.
2637
2638 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2639 since either will do and ptrdiff_t is convenient with xpalloc.
2640
2641 * charset.c (charset_table_size)
2642 (struct charset_sort_data.priority): Now ptrdiff_t.
2643 (charset_compare): Don't overflow if priorities differ greatly.
2644 (Fsort_charsets): Don't assume list length fits in int.
2645 Check for size-calculation overflow when allocating sort data.
2646 (syms_of_charset): Allocate an initial charset table that is
2647 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2648
2649 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2650
2651 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2652 The actual value is always <= INT_MAX, and leaving it unsigned made
2653 overflow checking harder.
2654
2655 * dispextern.h (struct glyph_matrix.rows_allocated)
2656 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2657 with xpalloc. The values are still always <= INT_MAX.
2658
2659 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2660
2661 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2662 (SAFE_NALLOCA): New macro.
2663
2664 * region-cache.c (struct boundary.pos, find_cache_boundary)
2665 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2666 (set_cache_region, invalidate_region_cache)
2667 (revalidate_region_cache, know_region_cache, region_cache_forward)
2668 (region_cache_backward, pp_cache):
2669 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2670 so that ptrdiff_t * can be passed to xpalloc.
2671 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2672 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2673 (pp_cache): Don't assume cache_len fits in int.
2674 * region-cache.h: Adjust extern decls to match.
2675
2676 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2677 EMACS_INT, since either will do, for xpalloc.
2678
2679 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2680 (xnmalloc, xnrealloc, xpalloc): New functions.
2681
2682 * bidi.c (bidi_shelve_header_size): New constant.
2683 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2684 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2685
2686 * bidi.c (bidi_cache_shrink):
2687 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2688 (overlay_strings):
2689 Don't update size of array until after memory allocation succeeds,
2690 because xmalloc/xrealloc may not return.
2691 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2692 now that we have proper integer overflow checking.
2693 (record_overlay_string, overlay_strings): Catch overflows when
2694 calculating size of overlay_str_buf.
2695
2696 * callproc.c (Fcall_process): Check for size overflow when
2697 calculating size of args2.
2698 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2699 Normally we prefer signed values, but sticking with ptrdiff_t would
2700 require adding more-complicated checks.
2701
2702 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2703 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2704 Redo buffer-overflow calculations to avoid integer overflow.
2705 Add a FIXME comment where memory seems to be over-allocated.
2706
2707 * character.c (Fstring): Check for size-calculation overflow.
2708
2709 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2710 unnecessary integer overflow. Check for size overflow.
2711 (encode_coding_object): Don't update size until xmalloc succeeds.
2712
2713 * composite.c (get_composition_id): Check for overflow in glyph
2714 length calculations.
2715
2716 Integer and memory overflow fixes for display code.
2717 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2718 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2719 (scrolling_window): Check for overflow in size calculations.
2720 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2721 Don't assume glyph table len fits in int.
2722 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2723 (row_table_size): Now ptrdiff_t, not int.
2724 (scrolling_window): Avoid overflow in size calculations.
2725 Don't update size until allocation succeeds.
2726 * fns.c (concat): Check for overflow in size calculations.
2727 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2728 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2729 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2730
2731 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2732 (get_doc_string): Check for size calculation overflow.
2733 Don't update size until allocation succeeds.
2734 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2735 EMACS_INT, where ptrdiff_t will do.
2736 (Fsubstitute_command_keys): Check for string overflow.
2737
2738 * editfns.c (set_time_zone_rule): Don't assume environment length
2739 fits in int.
2740 (message_length): Now ptrdiff_t, not int.
2741 (Fmessage_box): Don't update size until allocation succeeds.
2742 Don't assume message length fits in int.
2743 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2744
2745 * emacs.c (main): Do not reallocate argv, since there is a null at
2746 the end that can be overwritten, and this way there's no need to
2747 worry about size-calculation overflow.
2748 (sort_args): Check for size-calculation overflow.
2749
2750 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2751 alloc succeeds.
2752 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2753
2754 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2755 (x_set_scroll_bar_width, x_figure_window_size):
2756 Check for integer overflow.
2757 (x_set_alpha): Do not assume XINT fits in int.
2758
2759 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2760 This is for the members text_lines, text_cols, total_lines, total_cols,
2761 where the system imposes an 'int' limit.
2762
2763 * fringe.c (Fdefine_fringe_bitmap):
2764 Don't update size until alloc works.
2765
2766 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2767 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2768
2769 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2770 Check for size-calculation overflow.
2771 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2772 do, as we prefer signed integers.
2773 (id_to_widget.max_size, id_to_widget.used)
2774 (xg_store_widget_in_map, xg_remove_widget_from_map)
2775 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2776 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2777 Use and return ptrdiff_t, not int.
2778 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2779 * gtkutil.h: Change prototypes to match the above.
2780
2781 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2782 are duplicate now that they've been promoted to lisp.h.
2783 (x_allocate_bitmap_record, x_alloc_image_color)
2784 (make_image_cache, cache_image, xpm_load):
2785 Don't update size until alloc is done.
2786 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2787 (x_detect_edges):
2788 Check for size calculation overflow.
2789 (ct_colors_allocated_max): New constant.
2790 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2791 overflow.
2792
2793 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2794 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2795 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2796 Use ptrdiff_t, not int, to count maps.
2797 (read_char_minibuf_menu_prompt): Check for overflow in size
2798 calculations. Don't update size until allocation succeeds.
2799 Redo calculations to avoid overflow.
2800 * keyboard.h: Change prototypes to match the above.
2801
2802 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2803 to count maps.
2804 (current_minor_maps): Check for size calculation overflow.
2805 * keymap.h: Change prototypes to match the above.
2806
2807 * lread.c (read1, init_obarray): Don't update size until alloc done.
2808
2809 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2810 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2811
2812 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2813 Now ptrdiff_t, not int.
2814 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2815 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2816
2817 * process.c (Fnetwork_interface_list): Check for overflow
2818 in size calculation.
2819
2820 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2821
2822 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2823 overflow. Don't bother calling xmalloc when xrealloc will do.
2824
2825 * search.c (Freplace_match): Check for size calculation overflow.
2826 (Fset_match_data): Don't assume list lengths fit in 'int'.
2827
2828 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2829 for command line length. Do not attempt to address one before the
2830 beginning of an array, as that's not portable.
2831
2832 * term.c (max_frame_lines): Remove; unused.
2833 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2834 not int.
2835 (encode_terminal_code, calculate_costs): Check for size
2836 calculation overflow.
2837 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2838 table lengths and related sizes. Don't update size until alloc
2839 done. Redo calculations to avoid overflow.
2840 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2841
2842 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2843 subtracting pointers.
2844 (gobble_line): Check for overflow more carefully. Don't update size
2845 until alloc done.
2846
2847 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2848 Don't update size until alloc done.
2849 Redo size calculations to avoid overflow.
2850 Check for size calculation overflow.
2851 (main) [DEBUG]: Fix typo in invoking tparam1.
2852
2853 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2854 Use ptrdiff_t, not int, for sizes.
2855 (store_mode_line_noprop_char): Don't update size until alloc done.
2856
2857 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2858 Use ptrdiff_t, not int, for sizes.
2859 (Finternal_make_lisp_face, cache_face):
2860 Check for size calculation overflow.
2861 (cache_face): Treat size calculation overflows as if they were
2862 memory exhaustion (the usual treatment), rather than aborting.
2863
2864 * xfns.c (x_encode_text, x_set_name_internal)
2865 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2866 sizes, since they can exceed INT_MAX in size. Check for size
2867 calculation overflow.
2868
2869 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2870 (xg_select): Check for size calculation overflow.
2871 Don't update size until alloc done.
2872
2873 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2874 as sprintf is limited to int lengths.
2875
2876 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2877 (X_LONG_MIN): New macros.
2878 Use them to make the following changes clearer.
2879 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2880 This change doesn't affect the value now, but it may help remind
2881 future maintainers not to raise the value too much later.
2882 (SELECTION_QUANTUM): Remove, replacing with ...
2883 (selection_quantum): ... new function, which avoids overflow.
2884 All uses changed.
2885 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2886 assumption that selection length fits in 'int'.
2887 (x_reply_selection_request, x_handle_selection_request)
2888 (x_get_window_property, receive_incremental_selection)
2889 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2890 (lisp_data_to_selection_data, clean_local_selection_data):
2891 Use ptrdiff_t, not int, to record length of selection.
2892 (x_reply_selection_request, x_get_window_property)
2893 (receive_incremental_selection, x_property_data_to_lisp):
2894 Redo calculations to avoid overflow.
2895 (x_reply_selection_request): When sending hint, ceiling it at
2896 X_LONG_MAX rather than relying on wraparound overflow to send
2897 something.
2898 (x_get_window_property, receive_incremental_selection)
2899 (lisp_data_to_selection_data, x_property_data_to_lisp):
2900 Check for size-calculation overflow.
2901 (x_get_window_property, receive_incremental_selection)
2902 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2903 Don't store size until memory allocation succeeds.
2904 (x_get_window_property): Plug memory leak on memory exhaustion.
2905 Don't double-block input; malloc is safe here. Don't assume 2**34
2906 - 4 fits in unsigned long. Add an xassert to check
2907 XGetWindowProperty overflow. Be more careful about overflow
2908 calculations, and distinguish size from memory overflow better.
2909 (receive_incremental_selection): When tracing, don't assume
2910 unsigned int is less than INT_MAX.
2911 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2912 harmful) conversions of unsigned short to int.
2913 (lisp_data_to_selection_data): Don't assume that integers
2914 in the range -65535 through -1 fit in an X unsigned short.
2915 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2916 result parameters unless successful. Rely on cons_to_unsigned
2917 to report problems with elements; the old code wasn't right anyway.
2918 (x_check_property_data): Check for int overflow; we cannot use
2919 a wider type due to X limits.
2920 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2921
2922 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2923
2924 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2925 (x_term_init): Check for size calculation overflow.
2926 (x_color_cells): Don't store size until memory allocation succeeds.
2927 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2928 Don't assume alloca size is less than MAX_ALLOCA.
2929 (x_term_init): Don't assume length fits in int (sprintf is limited
2930 to int size).
2931
2932 Use ptrdiff_t for composition IDs.
2933 * character.c (lisp_string_width):
2934 * composite.c (composition_table_size, n_compositions)
2935 (get_composition_id, composition_gstring_from_id):
2936 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2937 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2938 * window.c (Frecenter):
2939 Use ptrdiff_t, not int, for composition IDs.
2940 * composite.c (get_composition_id): Check for integer overflow.
2941 * composite.h: Adjust prototypes to match the above changes.
2942
2943 Use ptrdiff_t for hash table indexes.
2944 * category.c (hash_get_category_set):
2945 * ccl.c (ccl_driver):
2946 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2947 * coding.c (coding_system_charset_list, detect_coding_system):
2948 * coding.h (struct coding_system.id):
2949 * composite.c (get_composition_id, gstring_lookup_cache):
2950 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2951 * image.c (xpm_get_color_table_h):
2952 * lisp.h (hash_lookup, hash_put):
2953 * minibuf.c (Ftest_completion):
2954 Use ptrdiff_t for hash table indexes, not int (which is too
2955 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2956 32-bit --with-wide-int hosts).
2957
2958 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2959 Add a FIXME comment about memory leaks.
2960 (syms_of_charset): Don't assume xmalloc returns.
2961
2962 Don't assume that stated character widths fit in int.
2963 * character.c (Fchar_width, c_string_width, lisp_string_width):
2964 * character.h (CHAR_WIDTH):
2965 * indent.c (MULTIBYTE_BYTES_WIDTH):
2966 Use sanitize_char_width to avoid undefined and/or bad behavior
2967 with outlandish widths.
2968 * character.h (sanitize_tab_width): Rename from sanitize_width,
2969 now that we have two such functions. All uses changed.
2970 (sanitize_char_width): New inline function.
2971
2972 Don't assume that tab-width fits in int.
2973 * character.h (sanitize_width): New inline function.
2974 (SANE_TAB_WIDTH): New macro.
2975 (ASCII_CHAR_WIDTH): Use it.
2976 * indent.c (sane_tab_width): Remove. All uses replaced by
2977 SANE_TAB_WIDTH (current_buffer).
2978 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2979
2980 * fileio.c: Integer overflow issues with file modes.
2981 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2982
2983 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2984 Remove unreachable code.
2985 (read_hex, load_charset_map_from_file): Check for integer overflow.
2986
2987 * xterm.c: Don't go over XClientMessageEvent limit.
2988 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2989 (x_send_scroll_bar_event): Likewise. Check that the size does not
2990 exceed limits imposed by XClientMessageEvent, as well as the usual
2991 ptrdiff_t and size_t limits.
2992
2993 * keyboard.c: Overflow, signedness and related fixes.
2994 (make_lispy_movement): Use same integer type in forward decl
2995 that is used in the definition.
2996 (read_key_sequence, keyremap_step):
2997 Change bufsize argument back to int, undoing my 2011-03-30 change.
2998 We prefer signed types, and int is wide enough here.
2999 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3000 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3001 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3002 length, not size_t. Use ptrdiff_t for index, not int.
3003 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3004 possibility of integer overflow.
3005
3006 Overflow, signedness and related fixes for images.
3007
3008 * dispextern.h (struct it.stack[0].u.image.image_id)
3009 (struct_it.image_id, struct image.id, struct image_cache.size)
3010 (struct image_cache.used, struct image_cache.ref_count):
3011 * gtkutil.c (update_frame_tool_bar):
3012 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3013 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3014 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3015 * nsmenu.m (update_frame_tool_bar):
3016 * xdisp.c (calc_pixel_width_or_height):
3017 * xfns.c (image_cache_refcount):
3018 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3019 on typical 64-bit hosts.
3020
3021 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3022 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3023 Omit unnecessary casts to int.
3024 (parse_image_spec): Check that integers fall into 'int' range
3025 when the callers expect that.
3026 (image_ascent): Redo ascent calculation to avoid int overflow.
3027 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3028 (lookup_image): Remove unnecessary tests.
3029 (xbm_image_p): Locals are now of int, not EMACS_INT,
3030 since parse_image_check makes sure they fit into int.
3031 (png_load, gif_load, svg_load_image):
3032 Prefer int to unsigned where either will do.
3033 (tiff_handler): New function, combining the cores of the
3034 old tiff_error_handler and tiff_warning_handler.
3035 This function is rewritten to use vsnprintf and thereby avoid
3036 stack buffer overflows. It uses only the features of vsnprintf
3037 that are common to both POSIX and native Microsoft.
3038 (tiff_error_handler, tiff_warning_handler): Use it.
3039 (tiff_load, gif_load, imagemagick_load_image):
3040 Don't assume :index value fits in 'int'.
3041 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3042 (imagemagick_load_image): Check that crop parameters fit into
3043 the integer types that MagickCropImage accepts. Don't assume
3044 Vimagemagick_render_type has a nonnegative value. Don't assume
3045 size_t fits in 'long'.
3046 (gs_load): Use printmax_t to print the widest integers possible.
3047 Check for integer overflow when computing image height and width.
3048
3049 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3050
3051 * xdisp.c (redisplay_window): Don't force window start if point
3052 will be invisible in the resulting window. (Bug#9324)
3053
3054 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3055
3056 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3057 the display spec is of the form `(space ...)'.
3058 (handle_display_spec): Return the value returned by
3059 handle_single_display_spec, not just 1 or zero.
3060 (handle_single_display_spec): If the display spec is of the form
3061 `(space ...)', and specifies display in the text area, return 2
3062 rather than 1.
3063 (try_cursor_movement): Check for the need to scroll more
3064 accurately, and prefer exact match for point under bidi.
3065 Don't advance `row' beyond the last row of the window.
3066
3067 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3068 into disp_prop; all users changed.
3069
3070 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3071 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3072 for the text covered by the display property.
3073
3074 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3075
3076 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3077 Change return value to nil.
3078 (Frecord_buffer): Delete unused function.
3079
3080 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3081
3082 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3083 buffers, return left-to-right.
3084 (set_cursor_from_row): Consider candidate row a win if its glyph
3085 represents a newline and point is on that newline. Fixes cursor
3086 positioning on the newline at EOL of R2L text within L2R
3087 paragraph, and vice versa.
3088 (try_cursor_movement): Check continued rows, in addition to
3089 continuation rows. Fixes unwarranted scroll when point enters a
3090 continued line of R2L text within an L2R paragraph, or vice versa.
3091 (cursor_row_p): Consider the case of point being equal to
3092 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3093 from the end of a short line to the beginning of a continued line
3094 of R2L text within L2R paragraph.
3095 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3096 composed characters.
3097
3098 * bidi.c (bidi_check_type): Use xassert.
3099 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3100 members.
3101
3102 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3103
3104 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3105 a character.
3106
3107 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3108
3109 * nsfont.m (ns_otf_to_script): Fix typo.
3110
3111 2011-08-22 Kenichi Handa <handa@m17n.org>
3112
3113 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3114 extra slot even if the purpose is char-code-property-table.
3115
3116 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3117
3118 * xdisp.c (redisplay_window): When computing centering_position,
3119 account for the height of the header line. (Bug#8874)
3120
3121 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3122 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3123 candidate is selected by the mouse, and that candidate has a
3124 composed character under the mouse.
3125
3126 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3127 coordinates reported by pos-visible-in-window-p for a composed
3128 character in column zero.
3129
3130 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3131
3132 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3133
3134 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3135
3136 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3137 consider it a hit if to_charpos is anywhere in the range of the
3138 composed buffer positions.
3139
3140 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3141
3142 * image.c (gif_load): Don't assume that each subimage has the same
3143 dimensions as the base image. Handle disposal method that is
3144 "undefined" by the gif spec (Bug#9335).
3145
3146 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3147
3148 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3149 (Fcondition_case): Document `debug' symbol in error handler.
3150
3151 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3152
3153 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3154 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3155 from an Org mode buffer to a Speedbar frame.
3156
3157 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3158 a composition, take its buffer position from IT->cmp_it.charpos.
3159 Fixes cursor positioning at the beginning of a line that begins
3160 with a composed character.
3161
3162 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3163
3164 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3165 character bidirectional type, use STRONG_L instead. Fixes crashes
3166 in a buffer produced by `describe-categories'.
3167
3168 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3169 members before the level stack, so they would be saved and
3170 restored when copying iterator state. Fixes incorrect reordering
3171 around TABs covered by display properties.
3172
3173 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3174
3175 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3176
3177 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3178
3179 * eval.c (internal_condition_case, internal_condition_case_1)
3180 (internal_condition_case_2, internal_condition_case_n):
3181 Remove unnecessary aborts (Bug#9081).
3182
3183 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3184
3185 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3186 has no `load' handler, try opening the file locally. (Bug#9311)
3187
3188 2011-08-16 Ken Brown <kbrown@cornell.edu>
3189
3190 * gmalloc.c: Expand comment.
3191
3192 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3193
3194 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3195 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3196
3197 2011-08-16 Ken Brown <kbrown@cornell.edu>
3198
3199 Fix memory allocation problems in Cygwin build (Bug#9273).
3200
3201 * unexcw.c ( __malloc_initialized): Declare external variable.
3202 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3203
3204 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3205 New variables.
3206 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3207 dumped emacs.
3208 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3209 in the static heap.
3210 [CYGWIN] (special_realloc): New function.
3211 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3212 requests to realloc storage in the static heap.
3213
3214 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3215
3216 * bidi.c (bidi_initialize): Remove unused local.
3217
3218 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3219
3220 * bidimirror.h:
3221 * biditype.h: Remove file.
3222 * makefile.w32-in ($(BLD)/bidi.$(O)):
3223 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3224
3225 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3226
3227 * chartab.c: Improve commentary for the uniprop_table API.
3228
3229 * bidi.c (bidi_paragraph_init): Support zero value of
3230 bidi_ignore_explicit_marks_for_paragraph_level.
3231 (bidi_initialize): Use uniprop_table instead of including
3232 biditype.h and bidimirror.h.
3233
3234 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3235 coordinates of the iterator when restoring from ppos_it.
3236 (Bug#9296)
3237
3238 2011-08-14 Kenichi Handa <handa@m17n.org>
3239
3240 * process.c (create_process): Call setup_process_coding_systems
3241 after the pid of the process is set to -1 (Bug#8162).
3242
3243 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3244
3245 * xdisp.c (move_it_in_display_line_to): Don't invoke
3246 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3247 ppos_it. Fixes vertical cursor motion when line beginning is
3248 covered by an image. (Bug#9296)
3249
3250 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3251
3252 * nsterm.h (ns_run_ascript): Declare.
3253 (NSAPP_DATA2_RUNASSCRIPT): Define.
3254
3255 * nsfns.m (as_script, as_result, as_status): New static variables.
3256 (ns_run_ascript): New function.
3257 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3258 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3259 the event loop. Get status from as_status (Bug#7276).
3260
3261 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3262 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3263 the event loop (Bug#7276).
3264
3265 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3266
3267 * gnutls.c (QCgnutls_bootprop_priority)
3268 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3269 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3270 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3271 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3272 (QCgnutls_bootprop_verify_hostname_error)
3273 (QCgnutls_bootprop_callbacks_verify): Rename from
3274 Qgnutls_bootprop_..., all uses changed.
3275
3276 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3277 uses changed.
3278
3279 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3280
3281 * xfaces.c (Qframe_set_background_mode): Now static.
3282 * dispextern.h (Qframe_set_background_mode): Remove decl.
3283
3284 * process.c (Fnetwork_interface_info): Declare local only if needed.
3285
3286 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3287
3288 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3289 (Fnetwork_interface_list): Allocate in increments of bytes instead
3290 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3291 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3292 sockaddr.
3293 (struct ifflag_def): notrailers is smart on OSX.
3294 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3295 Get hardware address with getifaddrs if available.
3296
3297 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3298
3299 * xdisp.c (iterate_out_of_display_property): xassert that
3300 IT->position is set to within IT->object's boundaries. Break from
3301 the loop as soon as EOB is reached; avoids infloops in redisplay
3302 when IT->position is set up wrongly due to some bug.
3303 Set IT->current to match the bidi iterator unconditionally.
3304 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3305 entry. Force push_it to save on the stack the current
3306 buffer/string position, to be restored by pop_it. Fix flags in
3307 the iterator structure wrt the object coming from a display
3308 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3309 properties. (Bug#9284)
3310
3311 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3312
3313 * fontset.c (fontset_get_font_group): Add proper type checks.
3314 (Bug#9172)
3315
3316 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3317
3318 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3319 and LC_VERSION_MIN_MACOSX.
3320 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3321 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3322
3323 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3324
3325 * xdisp.c (forward_to_next_line_start): Allow to use the
3326 no-display-properties-and-no-overlays under bidi display.
3327 Set disp_pos in the bidi iterator to avoid searches for display
3328 properties and overlays.
3329
3330 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3331
3332 * editfns.c (Fset_time_zone_rule): Document relationship with the
3333 setenv function.
3334
3335 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3336 the font entity extracted from the cache (Bug#8109).
3337
3338 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3339
3340 * composite.c (autocmp_chars): Don't reset point. That is done by
3341 restore_point_unwind (Bug#5984).
3342
3343 2011-08-07 Juri Linkov <juri@jurta.org>
3344
3345 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3346 to show the arg `TIME' instead of `TIMEVAL'.
3347
3348 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3349
3350 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3351 display property strides EOL and includes a newline, as in
3352 longlines-mode. (Bug#9254)
3353 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3354 word-wrap under bidirectional display. (Bug#9224)
3355
3356 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3357 is non-zero, even if the data buffer is NULL. Fixes a crash in
3358 vertical-motion with longlines-mode. (Bug#9254)
3359
3360 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3361
3362 * bidi.c <bidi_cache_total_alloc>: Now static.
3363 (bidi_initialize): Initialize bidi_cache_total_alloc.
3364
3365 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3366 cache. (Bug#9221)
3367
3368 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3369 amount allocated this far in `bidi_cache_total_alloc'.
3370 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3371 non-zero, only free the data buffer without restoring the cache
3372 contents. All callers changed.
3373
3374 * dispextern.h (bidi_unshelve_cache): Update prototype.
3375
3376 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3377 (move_it_in_display_line, move_it_to)
3378 (move_it_vertically_backward, move_it_by_lines): Replace the call
3379 to xfree to an equivalent call to bidi_unshelve_cache.
3380 (move_it_in_display_line_to): Fix logic of returning
3381 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3382
3383 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3384
3385 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3386 came from a string character with a `cursor' property. (Bug#9229)
3387
3388 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3389
3390 * Makefile.in (LIB_PTHREAD): New variable.
3391 (LIBES): Add LIB_PTHREAD (Bug#9216).
3392
3393 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3394 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3395
3396 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3397
3398 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3399
3400 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3401
3402 * xterm.c (x_find_topmost_parent): New function.
3403 (x_set_frame_alpha): Find topmost parent window with
3404 x_find_topmost_parent and set the property there also (bug#9181).
3405 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3406
3407 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3408
3409 * callproc.c (Fcall_process): Avoid vfork clobbering
3410 the local vars buffer, coding_systems, current_dir.
3411
3412 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3413
3414 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3415
3416 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3417
3418 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3419 so that it is not optimized away.
3420
3421 * xdisp.c (compute_display_string_pos): Remove unused local.
3422
3423 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3424
3425 Fix slow cursor motion and scrolling in large buffers with
3426 selective display, like Org Mode buffers. (Bug#9218)
3427
3428 * dispextern.h (struct bidi_it): New member disp_prop_p.
3429
3430 * xdisp.c: Remove one-slot cache of display string positions.
3431 (compute_display_string_pos): Accept an additional argument
3432 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3433 for a display string or property. If found, set DISP_PROP_P
3434 non-zero.
3435
3436 * bidi.c (bidi_fetch_char): Accept an additional argument
3437 DISP_PROP_P, and pass it to compute_display_string_pos.
3438 Only handle text covered by a display string if DISP_PROP_P is returned
3439 non-zero. All callers of bidi_fetch_char changed.
3440
3441 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3442
3443 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3444
3445 2010-12-03 Don March <don@ohspite.net>
3446
3447 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3448 last character M-[char] is translated to ESC [char] (bug#7541).
3449
3450 2011-08-02 Kenichi Handa <handa@m17n.org>
3451
3452 * lisp.h (uniprop_table): Extern it.
3453
3454 * chartab.c (uniprop_table): Make it non-static.
3455
3456 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3457
3458 * xdisp.c (forward_to_next_line_start): Accept additional argument
3459 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3460 on the newline.
3461 (reseat_at_next_visible_line_start): Use the bidi iterator state
3462 returned by forward_to_next_line_start to restore the state of
3463 it->bidi_it after backing up to previous newline. (Bug#9212)
3464
3465 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3466
3467 * regex.c (re_comp): Protoize.
3468 (re_exec): Fix return type.
3469 (regexec): Fix type of `ret'. (Bug#9203)
3470
3471 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3472
3473 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3474 This is needed if max-image-size is a floating-point number.
3475
3476 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3477
3478 * print.c (print_object): Print empty symbol as ##.
3479
3480 * lread.c (read1): Read ## as empty symbol.
3481
3482 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3483
3484 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3485 setting frame foreground color (Bug#9175).
3486 (x_set_background_color): Likewise.
3487
3488 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3489 contents (Bug#9176).
3490 (EmacsTooltip -init): Remove bezels and add shadows to
3491 tooltip windows.
3492
3493 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3494 or scroll bar (Bug#8470).
3495
3496 * nsfont.m (nsfont_open): Remove assignment to voffset and
3497 unnecessary vars hshink, expand, hd, full_height, min_height.
3498 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3499
3500 * nsterm.h (nsfont_info): Remove voffset field.
3501
3502 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3503
3504 Implement strike-through and overline on NextStep (Bug#8863).
3505
3506 * nsfont.m (nsfont_open): Use underline position provided by font,
3507 instead of hard-coded value of 2.
3508 (nsfont_draw): Call ns_draw_text_decoration instead.
3509
3510 * nsterm.h: Add declaration for ns_draw_text_decoration.
3511
3512 * nsterm.m (ns_draw_text_decoration): New function for drawing
3513 underline, overline, and strike-through.
3514 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3515 ns_draw_text_decoration. Change treatment of cursor drawing to
3516 accommodate underlining, etc.
3517
3518 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3519
3520 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3521 default.
3522
3523 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3524
3525 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3526 Without this fix, if a signal arrives just after memory fills up,
3527 'malloc' might be invoked reentrantly.
3528
3529 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3530 In other words, assume that every image size is allowed, on non-X
3531 hosts. This assumption is probably wrong, but it lets Emacs compile.
3532
3533 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3534
3535 * regex.c (re_iswctype): Convert return values to boolean.
3536
3537 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3538
3539 * xdisp.c (compute_display_string_pos): Don't use cached display
3540 string position if the buffer had its restriction changed.
3541 (Bug#9184)
3542
3543 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3544
3545 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3546
3547 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3548
3549 Integer signedness and overflow and related fixes. (Bug#9079)
3550
3551 * bidi.c: Integer size and overflow fixes.
3552 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3553 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3554 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3555 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3556 (bidi_find_other_level_edge):
3557 Use ptrdiff_t instead of EMACS_INT where either will do.
3558 This works better on 32-bit hosts configured --with-wide-int.
3559 (bidi_cache_ensure_space): Check for size-calculation overflow.
3560 Use % rather than repeated addition, for better worst-case speed.
3561 Don't set bidi_cache_size until after xrealloc returns, because it
3562 might not return.
3563 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3564 (bidi_cache_ensure_space): Also check that the bidi cache size
3565 does not exceed that of the largest Lisp string or buffer. See Eli
3566 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3567
3568 * alloc.c (__malloc_size_t): Remove.
3569 All uses replaced by size_t. See Andreas Schwab's note
3570 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3571
3572 * image.c: Improve checking for integer overflow.
3573 (check_image_size): Assume that f is nonnull, since
3574 it is always nonnull in practice. This is one less thing to
3575 worry about when checking for integer overflow later.
3576 (x_check_image_size): New function, which checks for integer
3577 overflow issues inside X.
3578 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3579 This removes the need for a memory_full check.
3580 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3581 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3582 (xbm_read_bitmap_data): Change locals back to 'int', since
3583 their values must fit in 'int'.
3584 (xpm_load_image, png_load, tiff_load):
3585 Invoke x_create_x_image_and_pixmap earlier,
3586 to avoid much needless work if the image is too large.
3587 (tiff_load): Treat overly large images as if
3588 x_create_x_image_and_pixmap failed, not as malloc failures.
3589 (gs_load): Use x_check_image_size.
3590
3591 * gtkutil.c: Omit integer casts.
3592 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3593 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3594
3595 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3596
3597 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3598 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3599 would wrongly return t on a 64-bit host.
3600
3601 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3602 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3603 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3604 and therefore cause GCC to emit a bogus diagnostic in some cases.
3605
3606 * image.c: Integer signedness and overflow and related fixes.
3607 This is not an exhaustive set of fixes, but it's time to
3608 record what I've got.
3609 (lookup_pixel_color, check_image_size): Remove redundant decls.
3610 (check_image_size): Don't assume that arbitrary EMACS_INT values
3611 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3612 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3613 (tiff_load, imagemagick_load_image):
3614 Check for overflow in size calculations.
3615 (x_create_x_image_and_pixmap): Remove unnecessary test for
3616 xmalloc returning NULL; that can't happen.
3617 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3618 (xpm_color_bucket): Use better integer hashing function.
3619 (xpm_cache_color): Don't possibly over-allocate memory.
3620 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3621 (gif_memory_source):
3622 Use ptrdiff_t, not int or size_t, to record sizes.
3623 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3624 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3625 either works, as we prefer signed integers.
3626 (tiff_read_from_memory, tiff_write_from_memory):
3627 Return tsize_t, not size_t, since that's what the TIFF API wants.
3628 (tiff_read_from_memory): Don't fail simply because the read would
3629 go past EOF; instead, return a short read.
3630 (tiff_load): Omit no-longer-needed casts.
3631 (Fimagemagick_types): Don't assume size fits into 'int'.
3632
3633 Improve hashing quality when configured --with-wide-int.
3634 * fns.c (hash_string): New function, taken from sxhash_string.
3635 Do not discard information about ASCII character case; this
3636 discarding is no longer needed.
3637 (sxhash-string): Use it. Change sig to match it. Caller changed.
3638 * lisp.h: Declare it.
3639 * lread.c (hash_string): Remove, since we now use fns.c's version.
3640 The fns.c version returns a wider integer if --with-wide-int is
3641 specified, so this should help the quality of the hashing a bit.
3642
3643 * emacs.c: Integer overflow minor fix.
3644 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3645 Define only if GNU_LINUX.
3646 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3647
3648 * dispnew.c: Integer signedness and overflow fixes.
3649 Remove unnecessary forward decls, that were a maintenance hassle.
3650 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3651 All uses changed.
3652 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3653 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3654 (prepare_desired_row, line_draw_cost):
3655 Use int, not unsigned, where either works.
3656 (save_current_matrix, restore_current_matrix):
3657 Use ptrdiff_t, not size_t, where either works.
3658 (init_display): Check for overflow more accurately, and without
3659 relying on undefined behavior.
3660
3661 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3662 Remove, replacing with the new symbols in lisp.h. All uses changed.
3663 * fileio.c (make_temp_name):
3664 * filelock.c (lock_file_1, lock_file):
3665 * xdisp.c (message_dolog):
3666 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3667 Use pMd etc. instead.
3668 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3669 replacing the pWIDE etc. symbols removed from editfns.c.
3670
3671 * keyboard.h (num_input_events): Now uintmax_t.
3672 This is (very slightly) less likely to mess up due to wraparound.
3673 All uses changed.
3674
3675 * buffer.c: Integer signedness fixes.
3676 (alloc_buffer_text, enlarge_buffer_text):
3677 Use ptrdiff_t rather than size_t when either will do, as we prefer
3678 signed integers.
3679
3680 * alloc.c: Integer signedness and overflow fixes.
3681 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3682 (__malloc_size_t): Default to size_t, not to int.
3683 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3684 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3685 Prefer ptrdiff_t to size_t when either would do, as we prefer
3686 signed integers.
3687 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3688 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3689 Now const. Initialize with values that are in range even if char
3690 is signed.
3691 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3692 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3693 These functions do the right thing with sizes > 2**32.
3694 (check_depth): Now ptrdiff_t, not int.
3695 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3696 Adjust to new way of storing sizes. Check for size overflow bugs
3697 in rest of code.
3698 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3699 slightly wrong anyway, as it missed one instance of
3700 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3701 (refill_memory_reserve): Omit needless cast to size_t.
3702 (mark_object_loop_halt): Mark as externally visible.
3703
3704 * xselect.c: Integer signedness and overflow fixes.
3705 (Fx_register_dnd_atom, x_handle_dnd_message):
3706 Use ptrdiff_t, not size_t, since we prefer signed.
3707 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3708 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3709 x_dnd_atoms_size and x_dnd_atoms_length.
3710
3711 * doprnt.c: Prefer signed to unsigned when either works.
3712 * eval.c (verror):
3713 * doprnt.c (doprnt):
3714 * lisp.h (doprnt):
3715 * xdisp.c (vmessage):
3716 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3717 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3718 prefer signed arithmetic to avoid comparison confusion.
3719 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3720 but is a bit tricky.
3721
3722 Assume freestanding C89 headers, string.h, stdlib.h.
3723 * data.c, doprnt.c, floatfns.c, print.c:
3724 Include float.h unconditionally.
3725 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3726 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3727 * regex.c: Likewise for stddef.h, string.h.
3728 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3729 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3730 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3731 (STDC_HEADERS): Remove obsolete defines.
3732 * sysdep.c: Include limits.h unconditionally.
3733
3734 Assume support for memcmp, memcpy, memmove, memset.
3735 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3736 * regex.c (memcmp, memcpy):
3737 Remove; we assume C89 now.
3738
3739 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3740 (__malloc_safe_bcopy): Remove; no longer needed.
3741
3742 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3743 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3744 well either way, and we prefer signed to unsigned.
3745
3746 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3747
3748 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3749 closes the connection while we're reading (bug#9182).
3750
3751 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3752
3753 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3754 are specified (Bug#9168).
3755
3756 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3757
3758 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3759 Found by GCC static checking and --with-wide-int on a 32-bit host.
3760
3761 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3762
3763 * xdisp.c (compute_display_string_pos): Fix logic of caching
3764 previous display string position. Initialize cached_prev_pos to
3765 -1. Fixes slow-down at the beginning of a buffer.
3766
3767 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3768
3769 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3770 for attrs[LFACE_FONTSET_INDEX].
3771
3772 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3773
3774 * xml.c (parse_region): Remove unused local
3775 that was recently introduced.
3776
3777 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3778
3779 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3780 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3781
3782 * xdisp.c (move_it_in_display_line_to): Record the best matching
3783 position for TO_CHARPOS while scanning the line, and restore it on
3784 exit if none of the characters scanned was an exact match.
3785 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3786 when exact match is impossible due to invisible text, and the
3787 lines are truncated.
3788
3789 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3790
3791 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3792 for OSX >= 10.7.
3793
3794 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3795
3796 Fix a significant slow-down of cursor motion with C-n, C-p,
3797 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3798 auto-repeat under bidi redisplay in fontified buffers.
3799 * xdisp.c (compute_stop_pos_backwards): New function.
3800 (next_element_from_buffer): Call compute_stop_pos_backwards to
3801 find a suitable prev_stop when we find ourselves before
3802 base_level_stop.
3803 (reseat): Don't look for prev_stop, as that could mean a very long
3804 run.
3805 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3806 <cached_disp_overlay_modiff>: Cache for last found display string
3807 position.
3808 (compute_display_string_pos): Return the cached position if asked
3809 about the same buffer in the same area of character positions, and
3810 the buffer wasn't changed since the time the display string
3811 position was cached.
3812
3813 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3814
3815 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3816 is an integer, which is important for empty lines. (Bug#9149)
3817
3818 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3819
3820 * frame.c (Fmodify_frame_parameters): In tty case, update the
3821 default face if necessary (Bug#4238).
3822
3823 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3824
3825 * editfns.c (Fstring_to_char): No need to explain what a character
3826 is in the docstring (Bug#6576).
3827
3828 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3829
3830 * xml.c (parse_region): Make sure we always return a tree.
3831
3832 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3833
3834 * xml.c (parse_region): If a document contains only comments,
3835 return that, too.
3836
3837 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3838
3839 * xml.c (make_dom): Return comments, too.
3840
3841 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3842
3843 Port to OpenBSD.
3844 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3845 and the surrounding thread.
3846 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3847 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3848 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3849 timer goes off.
3850 * s/openbsd.h (BROKEN_SIGIO): Define.
3851 * unexelf.c (unexec) [__OpenBSD__]:
3852 Don't update the .mdebug section of the Alpha COFF symbol table.
3853
3854 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3855
3856 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3857 (bug#8460).
3858
3859 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3860
3861 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3862 This fixes some race conditions on the permissions of any newly
3863 created file.
3864
3865 * alloc.c (valid_pointer_p): Use pipe, not open.
3866 This fixes some permissions issues when debugging.
3867
3868 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3869 If fchown fails to set both uid and gid, try to set just gid,
3870 as that is sometimes allowed. Adjust the file's mode to eliminate
3871 setuid or setgid bits that are inappropriate if fchown fails.
3872
3873 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3874
3875 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3876 to compare Lisp_Objects.
3877 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3878 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3879 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3880
3881 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3882
3883 * lread.c (read_integer): Unread even EOF character.
3884 (read1): Likewise. Properly record start position of symbol.
3885
3886 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3887 symbol character follows.
3888
3889 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3890
3891 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3892 This works around a problem with the previous change to Fcopy_file.
3893 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3894 and without this change, GCC might complain about discarding
3895 fchown's return value.
3896
3897 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3898
3899 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3900
3901 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3902
3903 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3904
3905 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3906
3907 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3908 it's used from the C level.
3909
3910 * process.c: Use the same condition for POLL_FOR_INPUT in both
3911 keyboard.c and process.c (bug#1858).
3912
3913 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3914
3915 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3916 (Fgnutls_boot): Use it.
3917
3918 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3919
3920 * doc.c (Fsubstitute_command_keys): Revert last change.
3921
3922 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3923
3924 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3925 quotes the next character, and doesn't affect other longer
3926 sequences (bug#8935).
3927
3928 * lread.c (syms_of_lread): Clarify that is isn't only
3929 `eval-buffer' and `eval-defun' that's affected by
3930 `lexical-binding' (bug#8460).
3931
3932 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3933
3934 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3935 bidi redisplay when a line includes both an image and is truncated.
3936
3937 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3938
3939 Fix minor problems found by static checking.
3940 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3941 (elsz): Now a signed constant, not a size_t var. We prefer signed
3942 types to unsigned, to avoid integer comparison confusion. Without
3943 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3944 "cannot optimize loop, the loop counter may overflow", a symptom
3945 of the confusion.
3946 * indent.c (Fvertical_motion): Mark locals as initialized.
3947 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3948
3949 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3950
3951 * search.c (Fre_search_backward): Mention `case-fold-search' in
3952 all the re_search_* functions (bug#8138).
3953
3954 * keyboard.c (Fopen_dribble_file): Document when the file is
3955 closed (bug#8056).
3956
3957 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3958
3959 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3960 bidi_cache_idx.
3961
3962 Support bidi reordering of display and overlay strings.
3963 * xdisp.c (compute_display_string_pos)
3964 (compute_display_string_end): Accept additional argument STRING.
3965 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3966 (reseat_to_string): Initialize bidi_it->string.s and
3967 bidi_it->string.schars.
3968 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3969 NULL (avoids a crash in bidi_paragraph_init).
3970 Initialize itb.string.lstring.
3971 (init_iterator): Call bidi_init_it only of a valid
3972 buffer position was specified. Initialize paragraph_embedding to
3973 L2R.
3974 (reseat_to_string): Initialize the bidi iterator.
3975 (display_string): If we need to ignore text properties of
3976 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3977 original value of -1 will not work with bidi.)
3978 (compute_display_string_pos): First arg is now struct
3979 `text_pos *'; all callers changed. Support display properties on
3980 Lisp strings.
3981 (compute_display_string_end): Support display properties on Lisp
3982 strings.
3983 (init_iterator, reseat_1, reseat_to_string): Initialize the
3984 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3985 when iterating on a string not from display properties).
3986 (compute_display_string_pos, compute_display_string_end):
3987 Fix calculation of the object to scan. Fixes an error when using
3988 arrow keys.
3989 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3990 base_level_stop; instead, set base_level_stop to BEGV.
3991 Fixes crashes in vertical-motion.
3992 (next_element_from_buffer): Improve commentary for when
3993 the iterator is before prev_stop.
3994 (init_iterator): Initialize bidi_p from the default value of
3995 bidi-display-reordering, not from buffer-local value. Use the
3996 buffer-local value only if initializing for buffer iteration.
3997 (handle_invisible_prop): Support invisible properties on strings
3998 that are being bidi-reordered.
3999 (set_iterator_to_next): Support bidi reordering of C strings and
4000 Lisp strings.
4001 (next_element_from_string): Support bidi reordering of Lisp
4002 strings.
4003 (handle_stop_backwards): Support Lisp strings as well.
4004 (display_string): Support display of R2L glyph rows.
4005 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4006 (init_iterator): Don't initialize it->bidi_p for strings
4007 here.
4008 (reseat_to_string): Initialize it->bidi_p for strings here.
4009 (next_element_from_string, next_element_from_c_string)
4010 (next_element_from_buffer): Add xassert's for correspondence
4011 between IT's object being iterated and it->bidi_it.string
4012 structure.
4013 (face_before_or_after_it_pos): Support bidi iteration.
4014 (next_element_from_c_string): Handle the case of the first string
4015 character that is not the first one in the visual order.
4016 (get_visually_first_element): New function, refactored from common
4017 parts of next_element_from_buffer, next_element_from_string, and
4018 next_element_from_c_string.
4019 (tool_bar_lines_needed, redisplay_tool_bar)
4020 (display_menu_bar): Force left-to-right direction. Add a FIXME
4021 comment for making that be controlled by a user option.
4022 (push_it, pop_it): Save and restore the state of the
4023 bidi iterator. Save and restore the bidi_p flag.
4024 (pop_it): Iterate out of display property for string iteration as
4025 well.
4026 (iterate_out_of_display_property): Support iteration over strings.
4027 (handle_single_display_spec): Set up it->bidi_it for iteration
4028 over a display string, and call bidi_init_it.
4029 (handle_single_display_spec, next_overlay_string)
4030 (get_overlay_strings_1, push_display_prop): Set up the bidi
4031 iterator for displaying display or overlay strings.
4032 (forward_to_next_line_start): Don't use the shortcut if
4033 bidi-iterating.
4034 (back_to_previous_visible_line_start): If handle_display_prop
4035 pushed the iterator stack, restore the internal state of the bidi
4036 iterator by calling bidi_pop_it same number of times.
4037 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4038 and we are bidi-iterating, don't decrement the iterator position;
4039 instead, set the first_elt flag in the bidi iterator, to produce
4040 the same effect.
4041 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4042 (push_display_prop): xassert that we are iterating a buffer.
4043 (push_it, pop_it): Save and restore paragraph_embedding member.
4044 (handle_single_display_spec, next_overlay_string)
4045 (get_overlay_strings_1, reseat_1, reseat_to_string)
4046 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4047 correctly. Don't assume unibyte strings are not bidi-reordered.
4048 (compute_display_string_pos)
4049 (compute_display_string_end): Fix handling the case of C string.
4050 (push_it, pop_it): Save and restore from_disp_prop_p.
4051 (handle_single_display_spec, push_display_prop): Set the
4052 from_disp_prop_p flag.
4053 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4054 (pop_it): Call iterate_out_of_display_property only if we are
4055 popping after iteration over a string that came from a display
4056 property. Fix a typo in popping stretch info. Add an assertion
4057 for verifying that the iterator position is in sync with the bidi
4058 iterator.
4059 (handle_single_display_spec, get_overlay_strings_1)
4060 (push_display_prop): Fix initialization of paragraph direction for
4061 string when that of the parent object is not yet determined.
4062 (reseat_1): Call bidi_init_it to resync the bidi
4063 iterator with IT's position. (Bug#7616)
4064 (find_row_edges): If ROW->start.pos gives position
4065 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4066 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4067 Reset the from_disp_prop_p flag.
4068 (SAVE_IT, RESTORE_IT): New macros.
4069 (pos_visible_p, face_before_or_after_it_pos)
4070 (back_to_previous_visible_line_start)
4071 (move_it_in_display_line_to, move_it_in_display_line)
4072 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4073 (try_scrolling, redisplay_window, display_line): Use them when
4074 saving a temporary copy of the iterator and restoring it back.
4075 (back_to_previous_visible_line_start, reseat_1)
4076 (init_iterator): Empty the bidi cache "stack".
4077 (move_it_in_display_line_to): If iterator ended up at
4078 EOL, but we never saw any buffer positions smaller than
4079 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4080 motion in bidi-reordered lines.
4081 (move_it_in_display_line_to): Record prev_method and prev_pos
4082 immediately before the call to set_iterator_to_next. Fixes cursor
4083 motion in bidi-reordered lines with stretch glyphs and strings
4084 displayed in margins. (Bug#8133) (Bug#8867)
4085 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4086 TO_CHARPOS.
4087 (pos_visible_p): Support positions in bidi-reordered lines.
4088 Save and restore bidi cache.
4089
4090 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4091 (bidi_paragraph_info): Delete unused struct.
4092 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4093 (bidi_cache_start): New variable.
4094 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4095 to zero.
4096 (bidi_cache_fetch_state, bidi_cache_search)
4097 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4098 (bidi_cache_find, bidi_peek_at_next_level)
4099 (bidi_level_of_next_char, bidi_find_other_level_edge)
4100 (bidi_move_to_visually_next): Compare cache index with
4101 bidi_cache_start rather than with zero.
4102 (bidi_fetch_char): Accept new argument STRING; all callers
4103 changed. Support iteration over a string. Support strings with
4104 display properties. Support unibyte strings. Fix the type of
4105 `len' according to what STRING_CHAR_AND_LENGTH expects.
4106 (bidi_paragraph_init, bidi_resolve_explicit_1)
4107 (bidi_resolve_explicit, bidi_resolve_weak)
4108 (bidi_level_of_next_char, bidi_move_to_visually_next):
4109 Support iteration over a string.
4110 (bidi_set_sor_type, bidi_resolve_explicit_1)
4111 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4112 can now be zero (for strings); special values 0 and -1 were
4113 changed to -1 and -2, respectively.
4114 (bidi_char_at_pos): New function.
4115 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4116 Call it instead of FETCH_MULTIBYTE_CHAR.
4117 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4118 initialized to valid values.
4119 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4120 values.
4121 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4122 the test for valid cached positions. Fix the logic for looking up
4123 the sentinel state in the cache. GCPRO the Lisp string we are
4124 iterating.
4125 (bidi_push_it, bidi_pop_it): New functions.
4126 (bidi_initialize): Initialize the bidi cache start stack pointer.
4127 (bidi_cache_ensure_space): New function, refactored from part of
4128 bidi_cache_iterator_state. Don't assume the required size is just
4129 one BIDI_CACHE_CHUNK away.
4130 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4131 (bidi_count_bytes, bidi_char_at_pos): New functions.
4132 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4133 always valid if bidi_cache_idx is valid.
4134 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4135 is valid if it's going to be used.
4136 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4137 (bidi_cache_fetch_state, bidi_cache_search)
4138 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4139 (bidi_cache_iterator_state, bidi_cache_find)
4140 (bidi_find_other_level_edge, bidi_cache_start_stack):
4141 All variables related to cache indices are now EMACS_INT.
4142
4143 * dispextern.h (struct bidi_string_data): New structure.
4144 (struct bidi_it): New member `string'. Make flag members be 1-bit
4145 fields, and put them last in the struct.
4146 (compute_display_string_pos, compute_display_string_end):
4147 Update prototypes.
4148 (bidi_push_it, bidi_pop_it): Add prototypes.
4149 (struct iterator_stack_entry): New members bidi_p,
4150 paragraph_embedding, and from_disp_prop_p.
4151 (struct it): Member bidi_p is now a bit field 1 bit wide.
4152 (bidi_shelve_cache, bidi_unshelve_cache):
4153 Declare prototypes.
4154
4155 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4156 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4157 and vector-like objects.
4158
4159 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4160 cache around display iteration.
4161
4162 * window.c (Fwindow_end, window_scroll_pixel_based)
4163 (displayed_window_lines, Frecenter): Save and restore the bidi
4164 cache around display iteration.
4165
4166 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4167
4168 * editfns.c (Fdelete_region): Clarify the use of the named
4169 parameters (bug#6788).
4170
4171 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4172
4173 * indent.c (Fvertical_motion): Set and restore w->pointm when
4174 saving and restoring the window's buffer (Bug#9006).
4175
4176 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4177
4178 * editfns.c (Fstring_to_char): Clarify just what is returned
4179 (bug#6576). Text by Eli Zaretskii.
4180
4181 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4182
4183 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4184
4185 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4186
4187 * buffer.c (mmap_find): Fix a typo.
4188
4189 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4190
4191 Fix execution of x selection hooks.
4192 * xselect.c (Qx_lost_selection_functions)
4193 (Qx_sent_selection_functions): New vars.
4194 (syms_of_xselect): DEFSYM them.
4195 (x_handle_selection_request): Pass Qx_sent_selection_functions
4196 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4197 (x_handle_selection_clear,x_clear_frame_selections):
4198 Pass Qx_lost_selection_functions rather than
4199 Vx_lost_selection_functions to Frun_hook_with_args.
4200
4201 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4202
4203 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4204 The old code sometimes used this field without initializing it.
4205
4206 * alloc.c (gc_sweep): Don't read past end of array.
4207 In theory, the old code could also have corrupted Emacs internals,
4208 though it'd be very unlikely.
4209
4210 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4211
4212 * character.c (Fcharacterp): Don't advertise optional ignored
4213 argument. (Bug#4026)
4214
4215 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4216
4217 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4218 key" (bug#4257).
4219
4220 * window.c (Fset_window_start): Doc fix (bug#4199).
4221 (Fset_window_hscroll): Ditto.
4222
4223 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4224
4225 Fix minor new problems caught by GCC 4.6.1.
4226 * term.c (init_tty): Remove unused local.
4227 * xsettings.c (store_monospaced_changed): Define this function only
4228 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4229 not used otherwise.
4230
4231 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4232
4233 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4234
4235 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4236
4237 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4238 are the mini-buffer and the echo area (bug#3320).
4239
4240 * term.c (init_tty): Remove support for supdup, c10 and perq
4241 terminals, which are no longer supported (bug#1482).
4242
4243 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4244
4245 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4246
4247 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4248
4249 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4250 for non-popups (Bug#3642).
4251
4252 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4253
4254 * alloc.c (reset_malloc_hooks): Protoize.
4255 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4256 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4257 * cm.c (losecursor): Likewise.
4258 * data.c (fmod): Likewise.
4259 * dispnew.c (swap_glyphs_in_rows): Likewise.
4260 * emacs.c (memory_warning_signal): Likewise.
4261 * floatfns.c (float_error): Likewise.
4262 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4263 (otf_open, font_otf_capability, generate_otf_features)
4264 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4265 Likewise.
4266 * image.c (pbm_read_file): Likewise.
4267 * indent.c (string_display_width): Likewise.
4268 * intervals.c (check_for_interval, search_for_interval)
4269 (inc_interval_count, count_intervals, root_interval)
4270 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4271 * lread.c (defalias): Likewise.
4272 * ralloc.c (r_alloc_check): Likewise.
4273 * regex.c (set_image_of_range_1, set_image_of_range)
4274 (regex_grow_registers): Likewise.
4275 * sysdep.c (strerror): Likewise.
4276 * termcap.c (valid_filename_p, tprint, main): Likewise.
4277 * tparam.c (main): Likewise.
4278 * unexhp9k800.c (run_time_remap, save_data_space)
4279 (update_file_ptrs, read_header, write_header, calculate_checksum)
4280 (copy_file, copy_rest, display_header): Likewise.
4281 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4282 Likewise.
4283 * xdisp.c (check_it): Likewise.
4284 * xfaces.c (register_color, unregister_color, unregister_colors):
4285 Likewise.
4286 * xfns.c (print_fontset_result): Likewise.
4287 * xrdb.c (member, fatal, main): Likewise.
4288
4289 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4290
4291 Fix minor problems found by static checking (Bug#9031).
4292 * chartab.c (char_table_set_range, map_sub_char_table):
4293 Remove unused locals.
4294 (uniprop_table): Now static.
4295 * composite.c (_work_char): Remove unused static var.
4296
4297 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4298
4299 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4300
4301 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4302
4303 * gtkutil.c (qttip_cb): Remove code without function.
4304
4305 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4306
4307 * w32.c (pthread_sigmask): New stub.
4308
4309 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4310
4311 Use pthread_sigmask, not sigprocmask (Bug#9010).
4312 sigprocmask is portable only for single-threaded applications, and
4313 Emacs can be multi-threaded when it uses GTK.
4314 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4315 (LIBES): Use it.
4316 * callproc.c (Fcall_process):
4317 * process.c (create_process):
4318 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4319 Use pthread_sigmask, not sigprocmask.
4320
4321 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4322
4323 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4324 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4325 wrong (Bug#8591).
4326
4327 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4328
4329 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4330 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4331 (xg_hide_tooltip): Fix comment.
4332
4333 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4334 in registerServicesMenuSendTypes.
4335 (validRequestorForSendType): Don't check ns_return_types.
4336
4337 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4338 ns_return_type.
4339
4340 2011-07-08 Jason Rumney <jasonr@gnu.org>
4341
4342 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4343 SH_SHOW for hidden windows (Bug#5482).
4344
4345 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4346 frame struct members of non-existent frames (Bug#6284).
4347
4348 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4349
4350 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4351 variable firstTime not needed on OSX >= 10.6.
4352 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4353 >= 10.5. Use setKnobProportion, setDoubleValue.
4354
4355 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4356 (MAC_OS_X_VERSION_10_5): Define if not defined.
4357 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4358 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4359 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4360
4361 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4362 cString and lossyCString on OSX >= 10.4
4363
4364 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4365 sizeToFit on OSX >= 10.2.
4366
4367 * nsimage.m (allocInitFromFile): Don't use deprecated method
4368 bestRepresentationForDevice on OSX >= 10.6.
4369
4370 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4371 to avoid warning.
4372
4373 * emacs.c: Declare unexec_init_emacs_zone.
4374
4375 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4376
4377 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4378
4379 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4380 on svcsMenu (Bug#8842).
4381
4382 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4383 ns_return_types.
4384 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4385
4386 * nsterm.m (QUTF8_STRING): Declare.
4387 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4388 (validRequestorForSendType): Return type is (id).
4389 Change indexOfObjectIdenticalTo to indexOfObject.
4390 Check if we have local selection before returning self (Bug#8842).
4391 (writeSelectionToPasteboard): Put local selection into paste board
4392 if we have a local selection (Bug#8842).
4393 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4394
4395 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4396 (ns_get_local_selection): Declare.
4397
4398 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4399
4400 * keymap.c (describe_map_tree): Don't insert a double newline at
4401 the end of the buffer (bug#1169) and return whether we inserted
4402 something.
4403
4404 * callint.c (Fcall_interactively): Change "reading args" to
4405 "providing args" to try to clarify what it does (bug#1010).
4406
4407 2011-07-07 Kenichi Handa <handa@m17n.org>
4408
4409 * composite.c (composition_compute_stop_pos): Ignore a static
4410 composition starting before CHARPOS (Bug#8915).
4411
4412 * xdisp.c (handle_composition_prop): Likewise.
4413
4414 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4415
4416 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4417 (Bug#9015)
4418
4419 2011-07-07 Kenichi Handa <handa@m17n.org>
4420
4421 * character.h (unicode_category_t): New enum type.
4422
4423 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4424 (Qchar_code_property_table): New variable.
4425 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4426 (UNIPROP_COMPRESSED_FORM_P): New macros.
4427 (char_table_ascii): Uncompress the compressed values.
4428 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4429 Uncompress the compressed values.
4430 (sub_char_table_ref_and_range): Likewise.
4431 (char_table_ref_and_range): Uncompress the compressed values.
4432 (sub_char_table_set): New arg is_uniprop. Callers changed.
4433 Uncompress the compressed values.
4434 (sub_char_table_set_range): Args changed. Callers changed.
4435 (char_table_set_range): Adjuted for the above change.
4436 (map_sub_char_table): Delete args default_val and parent. Add arg
4437 top. Give decoded values to a Lisp function.
4438 (map_char_table): Adjust for the above change. Give decoded
4439 values to a Lisp function. Gcpro more variables.
4440 (uniprop_table_uncompress)
4441 (uniprop_decode_value_run_length): New functions.
4442 (uniprop_decoder, uniprop_decoder_count): New variables.
4443 (uniprop_get_decoder, uniprop_encode_value_character)
4444 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4445 New functions.
4446 (uniprop_encoder, uniprop_encoder_count): New variables.
4447 (uniprop_get_encoder, uniprop_table)
4448 (Funicode_property_table_internal, Fget_unicode_property_internal)
4449 (Fput_unicode_property_internal): New functions.
4450 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4451 Sunicode_property_table_internal, Sget_unicode_property_internal,
4452 and Sput_unicode_property_internal. Defvar_lisp
4453 char-code-property-alist.
4454
4455 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4456 Vunicode_category_table.
4457
4458 * font.c (font_range): Adjust for the change of
4459 Vunicode_category_table.
4460
4461 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4462
4463 * m/iris4d.h: Remove file, move contents ...
4464 * s/irix6-5.h: ... here.
4465
4466 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4467
4468 Remove unportable assumption about struct layout (Bug#8884).
4469 * alloc.c (mark_buffer):
4470 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4471 (clone_per_buffer_values): Don't assume that
4472 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4473 This isn't true in general, and it's particularly not true
4474 if Emacs is configured with --with-wide-int.
4475 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4476 New macros, used in the buffer.c change.
4477
4478 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4479
4480 * xsettings.c: Use both GConf and GSettings if both are available.
4481 (store_config_changed_event): Add comment.
4482 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4483 (store_tool_bar_style_changed): New functions.
4484 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4485 (struct xsettings): Move font inside HAVE_XFT.
4486 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4487 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4488 Move inside HAVE_XFT.
4489 (something_changed_gsettingsCB): Rename from something_changedCB.
4490 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4491 also.
4492 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4493 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4494 (something_changed_gconfCB): Rename from something_changedCB.
4495 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4496 (parse_settings): Move check for font inside HAVE_XFT.
4497 (read_settings, apply_xft_settings): Add comment.
4498 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4499 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4500 call store_font_name_changed.
4501 (xft_settings_event): Add comment.
4502 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4503 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4504 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4505 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4506 (xsettings_initialize): Call init_gsettings last.
4507 (xsettings_get_system_font, xsettings_get_system_normal_font):
4508 Add comment.
4509
4510 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4511
4512 Random fixes. E.g., (random) never returned negative values.
4513 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4514 subseconds part to the entropy, as that's a bit more random.
4515 Prefer signed to unsigned, since the signedness doesn't matter and
4516 in general we prefer signed. When given a limit, use a
4517 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4518 latter isn't right if USE_2_TAGS_FOR_INTS.
4519 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4520 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4521
4522 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4523
4524 * textprop.c (text_property_stickiness):
4525 Obey Vtext_property_default_nonsticky.
4526 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4527 * w32fns.c (syms_of_w32fns):
4528 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4529
4530 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4531
4532 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4533 This is more efficient than Ffile_directory_p and avoids a minor race.
4534
4535 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4536
4537 * buffer.c (Foverlay_put): Say what the return value is
4538 (bug#7835).
4539
4540 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4541 is a directory before asking whether to use the file name
4542 (bug#7564).
4543 (barf_or_query_if_file_exists): Make the "File is a directory"
4544 error be more correct.
4545
4546 * fns.c (Frequire): Remove the mention of the .gz files, since
4547 that's installation-specific, but keep the mention of
4548 `get-load-suffixes'.
4549
4550 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4551
4552 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4553 Report string overflow if the output is too long.
4554
4555 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4556
4557 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4558 (syms_of_gnutls): Remove duplicate DEFSYM for
4559 Qgnutls_bootprop_verify_hostname_error, an error for
4560 Qgnutls_bootprop_verify_error (which is no longer used).
4561
4562 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4563 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4564 Also (re)move comments that are misplaced or no longer relevant.
4565
4566 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4567
4568 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4569
4570 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4571
4572 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4573 and background color parameters if they have been changed.
4574
4575 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4576
4577 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4578
4579 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4580
4581 * xsettings.c (SYSTEM_FONT): Define only when used.
4582 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4583
4584 * keymap.c (access_keymap_1): Now static.
4585
4586 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4587
4588 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4589 leave any prefix arg for the up event (Bug#1586).
4590
4591 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4592
4593 * lread.c (syms_of_lread): Mention single symbols defined by
4594 `defvar' or `defconst' (bug#7154).
4595
4596 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4597 (Frequire): Mention get-load-suffixes.
4598
4599 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4600
4601 * window.h (window): Remove clone_number slot.
4602 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4603 Remove.
4604 (make_parent_window, make_window, saved_window)
4605 (Fset_window_configuration, save_window_save): Don't deal with
4606 clone numbers.
4607 * buffer.c (Qclone_number): Remove declaration.
4608 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4609
4610 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4611
4612 Add multiple inheritance to keymaps.
4613 * keymap.c (Fmake_composed_keymap): New function.
4614 (Fset_keymap_parent): Simplify.
4615 (fix_submap_inheritance): Remove.
4616 (access_keymap_1): New function extracted from access_keymap to handle
4617 embedded parents and handle lists of maps.
4618 (access_keymap): Use it.
4619 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4620 (Fcopy_keymap): Handle embedded parents.
4621 (Fcommand_remapping, define_as_prefix): Simplify.
4622 (Fkey_binding): Simplify.
4623 (syms_of_keymap): Move minibuffer-local-completion-map,
4624 minibuffer-local-filename-completion-map,
4625 minibuffer-local-must-match-map, and
4626 minibuffer-local-filename-must-match-map to Elisp.
4627 (syms_of_keymap): Defsubr make-composed-keymap.
4628 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4629 (parse_menu_item): Trivial simplification.
4630
4631 2011-07-01 Glenn Morris <rgm@gnu.org>
4632
4633 * Makefile.in (SETTINGS_LIBS): Fix typo.
4634
4635 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4636
4637 * coding.c (Fencode_coding_string): Record the last coding system
4638 used, as the function doc string says (bug#8738).
4639
4640 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4641
4642 * xsettings.c (store_monospaced_changed): Take new font as arg and
4643 check for change against current_mono_font.
4644 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4645 (emacs_settings_constructor, emacs_settings_get_property)
4646 (emacs_settings_set_property, emacs_settings_class_init)
4647 (emacs_settings_init, gsettings_obj): Remove.
4648 (something_changedCB): New function for HAVE_GSETTINGS.
4649 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4650 with value as argument.
4651 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4652 g_settings_new (Bug#8967). Do not create gsettings_obj.
4653 Remove calls to g_settings_bind. Connect something_changedCB to
4654 "changed".
4655
4656 * xgselect.c: Add defined (HAVE_GSETTINGS).
4657 (xgselect_initialize): Ditto.
4658
4659 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4660 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4661 xg_select.
4662
4663 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4664
4665 * eval.c (struct backtrace): Simplify and port the data structure.
4666 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4667 signed bit field, as this assumption is not portable and it makes
4668 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4669 "char debug_on_exit : 1" as this is not portable either; instead,
4670 use the portable "unsigned int debug_on_exit : 1". Remove unused
4671 member evalargs. Remove obsolete comments about cc bombing out.
4672
4673 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4674
4675 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4676 Let HAVE_GSETTINGS override HAVE_GCONF.
4677 (store_monospaced_changed): New function.
4678 (EMACS_SETTINGS): A new type derived from GObject to handle
4679 GSettings notifications.
4680 (emacs_settings_constructor, emacs_settings_get_property)
4681 (emacs_settings_set_property, emacs_settings_class_init):
4682 New functions.
4683 (gsettings_client, gsettings_obj): New variables.
4684 (GSETTINGS_SCHEMA): New define.
4685 (something_changedCB): Call store_monospaced_changed.
4686 (init_gsettings): New function.
4687 (xsettings_initialize): Call init_gsettings.
4688 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4689 to NULL.
4690
4691 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4692 GCONF_CFLAGS/LIBS.
4693
4694 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4695
4696 * window.c (resize_root_window, grow_mini_window)
4697 (shrink_mini_window): Rename Qresize_root_window to
4698 Qwindow_resize_root_window and Qresize_root_window_vertically to
4699 Qwindow_resize_root_window_vertically.
4700
4701 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4702
4703 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4704
4705 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4706
4707 * makefile.w32-in: Redesign dependencies so they reflect more
4708 clearly which files are directly included by each source file,
4709 and not through other includes.
4710
4711 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4712
4713 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4714 (sort_overlays, overlay_strings): When an overlay's clone number
4715 matches the window's clone number process the overlay even if
4716 the overlay's window property doesn't match the current window.
4717
4718 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4719 (Fwindow_hchild): Rename to Fwindow_left_child.
4720 (Fwindow_next): Rename to Fwindow_next_sibling.
4721 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4722 (resize_window_check): Rename to window_resize_check.
4723 (resize_window_apply): Rename to window_resize_apply.
4724 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4725 (Fdelete_other_windows_internal, resize_frame_windows)
4726 (Fsplit_window_internal, Fdelete_window_internal)
4727 (grow_mini_window, shrink_mini_window)
4728 (Fresize_mini_window_internal): Fix callers accordingly.
4729
4730 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4731
4732 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4733 (emacs_fixed_set_min_size): Remove.
4734 (emacs_fixed_new): Take frame as argument.
4735
4736 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4737 (_EmacsFixedPrivate): Remove minwidth/height.
4738 Add struct frame *f.
4739 (emacs_fixed_init): Initialize priv->f.
4740 (get_parent_class, emacs_fixed_set_min_size): Remove.
4741 (emacs_fixed_new): Set priv->f to argument.
4742 (emacs_fixed_get_preferred_width)
4743 (emacs_fixed_get_preferred_height): Use min_width/height from
4744 frames size_hint to set minimum and natural (Bug#8919).
4745 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4746 and use min_width/height from frames size_hint to set
4747 min_width/height (Bug#8919).
4748
4749 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4750 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4751 Fix indentation.
4752
4753 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4754
4755 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4756 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4757 called at ZV.
4758
4759 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4760
4761 * process.c (wait_reading_process_output): Bypass select if
4762 waiting for a cell while ignoring keyboard input, and input is
4763 pending. Suggested by Jan Djärv (Bug#8869).
4764
4765 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4766
4767 Use gnulib's dup2 module instead of rolling our own.
4768 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4769
4770 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4771
4772 * dispnew.c (scrolling_window): Before scrolling, turn off a
4773 mouse-highlight in the window being scrolled.
4774
4775 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4776
4777 Move DEFSYM to lisp.h and use everywhere.
4778
4779 * character.h (DEFSYM): Move declaration...
4780 * lisp.h (DEFSYM): ...here.
4781
4782 * gnutls.c:
4783 * minibuf.c:
4784 * w32menu.c:
4785 * w32proc.c:
4786 * w32select.c: Don't include character.h.
4787
4788 * alloc.c (syms_of_alloc):
4789 * buffer.c (syms_of_buffer):
4790 * bytecode.c (syms_of_bytecode):
4791 * callint.c (syms_of_callint):
4792 * casefiddle.c (syms_of_casefiddle):
4793 * casetab.c (init_casetab_once):
4794 * category.c (init_category_once, syms_of_category):
4795 * ccl.c (syms_of_ccl):
4796 * cmds.c (syms_of_cmds):
4797 * composite.c (syms_of_composite):
4798 * dbusbind.c (syms_of_dbusbind):
4799 * dired.c (syms_of_dired):
4800 * dispnew.c (syms_of_display):
4801 * doc.c (syms_of_doc):
4802 * editfns.c (syms_of_editfns):
4803 * emacs.c (syms_of_emacs):
4804 * eval.c (syms_of_eval):
4805 * fileio.c (syms_of_fileio):
4806 * fns.c (syms_of_fns):
4807 * frame.c (syms_of_frame):
4808 * fringe.c (syms_of_fringe):
4809 * insdel.c (syms_of_insdel):
4810 * keymap.c (syms_of_keymap):
4811 * lread.c (init_obarray, syms_of_lread):
4812 * macros.c (syms_of_macros):
4813 * msdos.c (syms_of_msdos):
4814 * print.c (syms_of_print):
4815 * process.c (syms_of_process):
4816 * search.c (syms_of_search):
4817 * sound.c (syms_of_sound):
4818 * syntax.c (init_syntax_once, syms_of_syntax):
4819 * terminal.c (syms_of_terminal):
4820 * textprop.c (syms_of_textprop):
4821 * undo.c (syms_of_undo):
4822 * w32.c (globals_of_w32):
4823 * window.c (syms_of_window):
4824 * xdisp.c (syms_of_xdisp):
4825 * xfaces.c (syms_of_xfaces):
4826 * xfns.c (syms_of_xfns):
4827 * xmenu.c (syms_of_xmenu):
4828 * xsettings.c (syms_of_xsettings):
4829 * xterm.c (syms_of_xterm): Use DEFSYM.
4830
4831 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4832
4833 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4834
4835 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4836
4837 Integer and buffer overflow fixes (Bug#8873).
4838
4839 * print.c (printchar, strout): Check for string overflow.
4840 (PRINTPREPARE, printchar, strout):
4841 Don't set size unless allocation succeeds.
4842
4843 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4844 for sizes. Check for string overflow more accurately.
4845 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4846
4847 * macros.c: Integer and buffer overflow fixes.
4848 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4849 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4850 Use ptrdiff_t, not int, for sizes.
4851 Don't increment bufsize until after realloc succeeds.
4852 Check for size-calculation overflow.
4853 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4854
4855 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4856
4857 * lread.c: Integer overflow fixes.
4858 (read_integer): Radix is now EMACS_INT, not int,
4859 to improve quality of diagnostics for out-of-range radices.
4860 Calculate buffer size correctly for out-of-range radices.
4861 (read1): Check for integer overflow in radices, and in
4862 read-circle numbers.
4863 (read_escape): Avoid int overflow.
4864 (Fload, openp, read_buffer_size, read1)
4865 (substitute_object_recurse, read_vector, read_list, map_obarray):
4866 Use ptrdiff_t, not int, for sizes.
4867 (read1): Use EMACS_INT, not int, for sizes.
4868 Check for size overflow.
4869
4870 * image.c (cache_image): Check for size arithmetic overflow.
4871
4872 * lread.c: Integer overflow issues.
4873 (saved_doc_string_size, saved_doc_string_length)
4874 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4875 Now ptrdiff_t, not int.
4876 (read1): Don't assume doc string length fits in int. Check for
4877 out-of-range doc string lengths.
4878 (read_list): Don't assume file position fits in int.
4879 (read_escape): Check for hex character overflow.
4880
4881 2011-06-22 Leo Liu <sdl.web@gmail.com>
4882
4883 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4884 Move to minibuffer.el.
4885
4886 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4887
4888 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4889 The following patches are for when GLYPH_DEBUG && !XASSERT.
4890 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4891 * dispnew.c (flush_stdout):
4892 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4893 Mark as externally visible.
4894 * dispnew.c (check_window_matrix_pointers): Now static.
4895 * dispnew.c (window_to_frame_vpos):
4896 * xfns.c (unwind_create_frame):
4897 * xterm.c (x_check_font): Remove unused local.
4898 * scroll.c (CHECK_BOUNDS):
4899 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4900 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4901 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4902 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4903 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4904 Now static.
4905 (debug_method_add): Use va_list and vsprintf rather than relying
4906 on undefined behavior with wrong number of arguments.
4907 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4908 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4909 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4910 since we're not interested in debugging glyphs with old libraries.
4911 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4912 GCC 4.6.0's static checking.
4913
4914 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4915
4916 Integer overflow and signedness fixes (Bug#8873).
4917 A few related buffer overrun fixes, too.
4918
4919 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4920
4921 * dispextern.h (struct face.stipple):
4922 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4923 (x_bitmap_mask, x_allocate_bitmap_record)
4924 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4925 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4926 (x_create_bitmap_from_xpm_data):
4927 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4928 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4929 (.bitmaps_last):
4930 * xfaces.c (load_pixmap):
4931 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4932 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4933 (.bitmaps_last, struct x_output.icon_bitmap):
4934 Use ptrdiff_t, not int, for bitmap indexes.
4935 (x_allocate_bitmap_record): Check for size overflow.
4936 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4937
4938 Use ptrdiff_t, not int, for overlay counts.
4939 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4940 * editfns.c (overlays_around, get_pos_property):
4941 * textprop.c (get_char_property_and_overlay):
4942 * xdisp.c (next_overlay_change, note_mouse_highlight):
4943 * xfaces.c (face_at_buffer_position):
4944 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4945 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4946 (Fnext_overlay_change, Fprevious_overlay_change)
4947 (mouse_face_overlay_overlaps, Foverlays_in):
4948 Use ptrdiff_t, not int, for sizes.
4949 (overlays_at, overlays_in): Check for size-calculation overflow.
4950
4951 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4952
4953 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4954 (x_session_initialize): Do not assume string length fits in int.
4955
4956 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4957 This is unlikely, but can occur if DPI is outlandish.
4958
4959 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4960 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4961
4962 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4963 * xrdb.c (magic_file_p, search_magic_path):
4964 Omit last arg SUFFIX; it was always 0. All callers changed.
4965 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4966
4967 * xfont.c (xfont_match): Avoid need for strlen.
4968
4969 * xfns.c: Don't assume strlen fits in int.
4970 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4971
4972 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4973 not unsigned long, as we prefer signed integers. All callers changed.
4974 Detect integer overflow in repeat count.
4975 (message_dolog): Don't assume print length fits in 39 bytes.
4976 (display_mode_element): Don't assume strlen fits in int.
4977
4978 * termcap.c: Don't assume sizes fit in int and never overflow.
4979 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4980 (gobble_line): Check for size-calculation overflow.
4981
4982 * minibuf.c (Fread_buffer):
4983 * lread.c (intern, intern_c_string):
4984 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4985 Don't assume string length fits in int.
4986
4987 * keyboard.c (parse_tool_bar_item):
4988 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4989
4990 * font.c: Don't assume string length fits in int.
4991 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4992 Use ptrdiff_t, not int.
4993 (font_intern_prop): Don't assume string length fits in int.
4994 Don't assume integer property fits in fixnum.
4995 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4996
4997 * filelock.c: Fix some buffer overrun and integer overflow issues.
4998 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4999 Reformulate so as not to need the command string.
5000 Invoke gzip -cd rather than gunzip, as it's more portable.
5001 (lock_info_type, lock_file_1, lock_file):
5002 Don't assume pid_t and time_t fit in unsigned long.
5003 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5004 (current_lock_owner): Prefer signed type for sizes.
5005 Use memcpy, not strncpy, where memcpy is what is really wanted.
5006 Don't assume (via atoi) that time_t and pid_t fit in int.
5007 Check for time_t and/or pid_t out of range, e.g., via a network share.
5008 Don't alloca where an auto var works fine.
5009
5010 * fileio.c: Fix some integer overflow issues.
5011 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5012 Don't assume string length fits in int.
5013 (directory_file_name): Don't assume string length fits in long.
5014 (make_temp_name): Don't assume pid fits in int, or that its print
5015 length is less than 20.
5016
5017 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5018
5019 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5020
5021 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5022
5023 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5024 We prefer signed integers, even for size calculations.
5025
5026 * emacs.c: Don't assume string length fits in 'int'.
5027 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5028 (main): Don't invoke strlen when not needed.
5029
5030 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5031 (XD_DEBUG_MESSAGE): Don't waste a byte.
5032
5033 * callproc.c (getenv_internal_1, getenv_internal)
5034 (Fgetenv_internal):
5035 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5036
5037 * lread.c (invalid_syntax): Omit length argument.
5038 All uses changed. This doesn't fix a bug, but it simplifies the
5039 code away from its former Hollerith-constant appearance, and it's
5040 one less 'int' to worry about when looking at integer-overflow issues.
5041 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5042
5043 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5044 This didn't break anything, but it didn't help either.
5045 It's confusing to put a bogus integer in a place where the actual
5046 value does not matter.
5047 (LIST_END_P): Remove unused macro and its bogus comment.
5048 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5049
5050 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5051 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5052 implementation.
5053 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5054 We prefer signed types, and the value cannot exceed the EMACS_INT
5055 range anyway (because otherwise the length would not be representable).
5056 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5057 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5058 This avoids a GCC warning when WIDE_EMACS_INT.
5059
5060 * indent.c (sane_tab_width): New function.
5061 (current_column, scan_for_column, Findent_to, position_indentation)
5062 (compute_motion): Use it. This is just for clarity.
5063 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5064
5065 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5066
5067 * lisp.h (lint_assume): New macro.
5068 * composite.c (composition_gstring_put_cache):
5069 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5070
5071 * editfns.c, insdel.c:
5072 Omit unnecessary forward decls, to simplify future changes.
5073
5074 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5075
5076 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5077
5078 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5079 Use much-faster test for byte-length change.
5080 Don't assume string byte-length fits in 'int'.
5081 Check that character arg fits in 'int'.
5082 (mapcar1): Declare byte as byte, for clarity.
5083
5084 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5085
5086 * fns.c (concat): Catch string overflow earlier.
5087 Do not rely on integer wraparound.
5088
5089 * dispextern.h (struct it.overlay_strings_charpos)
5090 (struct it.selective): Now EMACS_INT, not int.
5091 * xdisp.c (forward_to_next_line_start)
5092 (back_to_previous_visible_line_start)
5093 (reseat_at_next_visible_line_start, next_element_from_buffer):
5094 Don't arbitrarily truncate the value of 'selective' to int.
5095
5096 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5097
5098 * composite.c: Don't truncate sizes to 'int'.
5099 (composition_gstring_p, composition_reseat_it)
5100 (composition_adjust_point): Use EMACS_INT, not int.
5101 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5102 not EMACS_UINT, for indexes.
5103
5104 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5105
5106 * buffer.c: Include <verify.h>.
5107 (struct sortvec.priority, struct sortstr.priority):
5108 Now EMACS_INT, not int.
5109 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5110 (struct sortstr.size, record_overlay_string)
5111 (struct sortstrlist.size, struct sortlist.used):
5112 Don't truncate size to int.
5113 (record_overlay_string): Check for size-calculation overflow.
5114 (init_buffer_once): Check at compile-time, not run-time.
5115
5116 2011-06-22 Jim Meyering <meyering@redhat.com>
5117
5118 Don't leak an XBM-image-sized buffer
5119 * image.c (xbm_load): Free the image buffer after using it.
5120
5121 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5122
5123 Port to Sun C.
5124 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5125 that Sun C diagnosed.
5126 * fns.c (secure_hash): Fix pointer signedness issue.
5127 * intervals.c (static_offset_intervals): New function.
5128 (offset_intervals): Use it.
5129
5130 2011-06-21 Leo Liu <sdl.web@gmail.com>
5131
5132 * deps.mk (fns.o):
5133 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5134 sha512.h.
5135
5136 * fns.c (secure_hash): Rename from crypto_hash_function and change
5137 the first arg to accept symbols.
5138 (Fsecure_hash): New primitive.
5139 (syms_of_fns): New symbols.
5140
5141 2011-06-20 Deniz Dogan <deniz@dogan.se>
5142
5143 * process.c (Fset_process_buffer): Clarify return value in
5144 docstring.
5145
5146 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5147
5148 * dispnew.c (add_window_display_history): Use BVAR.
5149
5150 * xdisp.c (debug_method_add): Use BVAR.
5151 (check_window_end, dump_glyph_matrix, dump_glyph)
5152 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5153
5154 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5155 Likewise.
5156
5157 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5158 check till after the cache is created in init_frame_faces.
5159
5160 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5161
5162 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5163
5164 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5165
5166 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5167 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5168 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5169
5170 Improve buffer-overflow checking (Bug#8873).
5171 * fileio.c (Finsert_file_contents):
5172 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5173 Remove the old (too-loose) buffer overflow checks.
5174 They weren't needed, since make_gap checks for buffer overflow.
5175 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5176 The old code merely checked for Emacs fixnum overflow, and relied
5177 on undefined (wraparound) behavior. The new code avoids undefined
5178 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5179
5180 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5181 Tune. Don't use wider integers than needed. Don't use alloca.
5182 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5183
5184 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5185
5186 * insdel.c, lisp.h (buffer_overflow): New function.
5187 (insert_from_buffer_1, replace_range, replace_range_2):
5188 * insdel.c (make_gap_larger):
5189 * editfns.c (Finsert_char):
5190 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5191
5192 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5193
5194 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5195
5196 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5197
5198 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5199 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5200
5201 * fileio.c: Don't assume EMACS_INT fits in off_t.
5202 (emacs_lseek): New static function.
5203 (Finsert_file_contents, Fwrite_region): Use it.
5204 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5205
5206 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5207
5208 * fns.c: Don't overflow int when computing a list length.
5209 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5210 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5211 truncation on 64-bit hosts. Check for QUIT every
5212 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5213 faster and is responsive enough.
5214 (Flength): Report an error instead of overflowing an integer.
5215 (Fsafe_length): Return a float if the value is not representable
5216 as a fixnum. This shouldn't happen except in contrived situations.
5217 (Fnthcdr, Fsort): Don't assume list length fits in int.
5218 (Fcopy_sequence): Don't assume vector length fits in int.
5219
5220 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5221 (header_size, word_size): New constants.
5222 (allocate_vectorlike): Don't check size overflow here.
5223 (allocate_vector): Check it here instead, since this is the only
5224 caller of allocate_vectorlike that could cause overflow.
5225 Check that the new vector's length is representable as a fixnum.
5226
5227 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5228 The previous code was bogus. For example, next_almost_prime (32)
5229 returned 39, which is undesirable as it is a multiple of 3; and
5230 next_almost_prime (24) returned 25, which is a multiple of 5 so
5231 why was the code bothering to check for multiples of 7?
5232
5233 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5234
5235 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5236
5237 Variadic C functions now count arguments with ptrdiff_t.
5238 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5239 Back then I didn't know that the Emacs coding style prefers signed int.
5240 Also, in the meantime I found a few more instances where arguments
5241 were being counted with int, which may truncate counts on 64-bit
5242 machines, or EMACS_INT, which may be unnecessarily wide.
5243 * lisp.h (struct Lisp_Subr.function.aMANY)
5244 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5245 Arg counts are now ptrdiff_t, not size_t.
5246 All variadic functions and their callers changed accordingly.
5247 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5248 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5249 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5250 * callint.c (Fcall_interactively): Check arg count for overflow,
5251 to avoid potential buffer overrun. Use signed char, not 'int',
5252 for 'varies' array, so that we needn't bother to check its size
5253 calculation for overflow.
5254 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5255 * eval.c (apply_lambda):
5256 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5257 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5258 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5259
5260 * callint.c (Fcall_interactively): Don't use index var as event count.
5261
5262 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5263 * mem-limits.h (SIZE): Remove; no longer used.
5264
5265 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5266
5267 Remove unnecessary casts.
5268 * xterm.c (x_term_init):
5269 * xfns.c (x_set_border_pixel):
5270 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5271 These aren't needed now that we assume ANSI C.
5272
5273 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5274 It's more likely to cause problems (due to unsigned overflow)
5275 than to cure them.
5276
5277 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5278
5279 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5280
5281 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5282
5283 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5284
5285 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5286
5287 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5288
5289 GLYPH_CODE_FACE returns EMACS_INT, not int.
5290 * dispextern.h (merge_faces):
5291 * xfaces.c (merge_faces):
5292 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5293 Don't assume EMACS_INT fits in int.
5294
5295 * character.h (CHAR_VALID_P): Remove unused parameter.
5296 * fontset.c, lisp.h, xdisp.c: All uses changed.
5297
5298 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5299
5300 * fns.c (concat): Minor tuning based on overflow analysis.
5301 This doesn't fix any bugs. Use int to hold character, instead
5302 of constantly refetching from Emacs object. Use XFASTINT, not
5303 XINT, for value known to be a character. Don't bother comparing
5304 a single byte to 0400, as it's always less.
5305
5306 * floatfns.c (Fexpt):
5307 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5308
5309 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5310 for characters.
5311
5312 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5313
5314 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5315 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5316 incorrectly succeed when S was a string, because 4294967386 was
5317 truncated before it was used.
5318
5319 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5320 Otherwise, an out-of-range integer could cause undefined behavior
5321 on a 64-bit host.
5322
5323 * composite.c: Use int, not EMACS_INT, for characters.
5324 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5325 EMACS_INT, for values that are known to be in character range.
5326 This doesn't fix any bugs but is the usual style inside Emacs and
5327 may generate better code on 32-bit machines.
5328
5329 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5330 This is for reasons similar to the recent CHAR_STRING fix.
5331 * charset.c (Fencode_char): Check that character arg is actually
5332 a character. Pass an int to ENCODE_CHAR.
5333 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5334 wider than 'int', as a compile-time check to prevent future regressions
5335 in this area.
5336
5337 * character.c (char_string): Remove unnecessary casts.
5338
5339 Make sure a 64-bit char is never passed to CHAR_STRING.
5340 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5341 by silently ignoring the top 32 bits, allowing some values
5342 that were far too large to be valid characters.
5343 * character.h: Include <verify.h>.
5344 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5345 arguments are no wider than unsigned, as a compile-time check
5346 to prevent future regressions in this area.
5347 * data.c (Faset):
5348 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5349 (Fsubst_char_in_region):
5350 * fns.c (concat):
5351 * xdisp.c (decode_mode_spec_coding):
5352 Adjust to CHAR_STRING's new requirement.
5353 * editfns.c (Finsert_char, Fsubst_char_in_region):
5354 * fns.c (concat): Check that character args are actually
5355 characters. Without this test, these functions did the wrong
5356 thing with wildly out-of-range values on 64-bit hosts.
5357
5358 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5359 These casts should not be needed on 32-bit hosts, either.
5360 * keyboard.c (read_char):
5361 * lread.c (Fload): Remove casts to unsigned.
5362
5363 * lisp.h (UNSIGNED_CMP): New macro.
5364 This fixes comparison bugs on 64-bit hosts.
5365 (ASCII_CHAR_P): Use it.
5366 * casefiddle.c (casify_object):
5367 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5368 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5369 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5370 * dispextern.h (FACE_FROM_ID):
5371 * keyboard.c (read_char): Use UNSIGNED_CMP.
5372
5373 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5374 not to EMACS_INT, to avoid GCC warning.
5375
5376 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5377
5378 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5379 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5380 isn't needed on 32-bit machines.
5381
5382 * buffer.c (Fgenerate_new_buffer_name):
5383 Use EMACS_INT for count, not int.
5384 (advance_to_char_boundary): Return EMACS_INT, not int.
5385
5386 * data.c (Qcompiled_function): Now static.
5387
5388 * window.c (window_body_lines): Now static.
5389
5390 * image.c (gif_load): Rename local to avoid shadowing.
5391
5392 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5393 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5394 * alloc.c (make_save_value): Integer argument is now of type
5395 ptrdiff_t, not int.
5396 (mark_object): Use ptrdiff_t, not int.
5397 * lisp.h (pD): New macro.
5398 * print.c (print_object): Use it.
5399
5400 * alloc.c: Use EMACS_INT, not int, to count objects.
5401 (total_conses, total_markers, total_symbols, total_vector_size)
5402 (total_free_conses, total_free_markers, total_free_symbols)
5403 (total_free_floats, total_floats, total_free_intervals)
5404 (total_intervals, total_strings, total_free_strings):
5405 Now EMACS_INT, not int. All uses changed.
5406 (Fgarbage_collect): Compute overall total using a double, so that
5407 integer overflow is less likely to be a problem. Check for overflow
5408 when converting back to an integer.
5409 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5410 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5411 These were 'int' variables that could overflow on 64-bit hosts;
5412 they were never used, so remove them instead of repairing them.
5413 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5414 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5415 Previously, this ceilinged at INT_MAX, but that doesn't work on
5416 64-bit machines.
5417 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5418
5419 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5420 (allocate_vectorlike): Check for ptrdiff_t overflow.
5421 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5422 when a (possibly-narrower) signed value would do just as well.
5423 We prefer using signed arithmetic, to avoid comparison confusion.
5424
5425 * alloc.c: Catch some string size overflows that we were missing.
5426 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5427 for convenience in STRING_BYTES_MAX.
5428 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5429 The definition here is exact; the one in lisp.h was approximate.
5430 (allocate_string_data): Check for string overflow. This catches
5431 some instances we weren't catching before. Also, it catches
5432 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5433 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5434 and ptrdiff_t and EMACS_INT are both 64 bits.
5435
5436 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5437 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5438 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5439
5440 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5441
5442 * alloc.c (Fmake_string): Check for out-of-range init.
5443
5444 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5445
5446 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5447
5448 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5449
5450 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5451 xg_get_default_scrollbar_width.
5452
5453 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5454 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5455 (style_changed_cb): Call update_theme_scrollbar_width and call
5456 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5457 all frames (Bug#8505).
5458 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5459 Call gtk_window_set_resizable if HAVE_GTK3.
5460 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5461 and height if HAVE_GTK3 (Bug#8505).
5462 (scroll_bar_width_for_theme): New variable.
5463 (update_theme_scrollbar_width): New function.
5464 (xg_get_default_scrollbar_width): Move code to
5465 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5466 (xg_initialize): Call update_theme_scrollbar_width.
5467
5468 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5469
5470 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5471
5472 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5473
5474 * frame.c (make_frame): Call other_buffer_safely instead of
5475 other_buffer.
5476
5477 * window.c (temp_output_buffer_show): Call display_buffer with
5478 second argument Vtemp_buffer_show_specifiers and reset latter
5479 immediately after the call.
5480 (Vtemp_buffer_show_specifiers): New variable.
5481 (auto_window_vscroll_p, next_screen_context_lines)
5482 (Vscroll_preserve_screen_position): Remove leading asterisks from
5483 doc-strings.
5484
5485 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5486
5487 Fix minor problems found by GCC 4.6.0 static checking.
5488 * buffer.c (Qclone_number): Remove for now, as it's unused.
5489 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5490 (record_buffer): Remove unused local.
5491 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5492 (set_frame_buffer_list): Remove; unused.
5493 * frame.h (other_visible_frames): Remove decl.
5494 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5495 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5496 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5497 if HAVE_GPM.
5498 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5499 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5500 Define only if HAVE_GPM.
5501 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5502 (update_hints_inhibit): Remove; never set. All uses removed.
5503 * widgetprv.h (emacsFrameClassRec): Remove decl.
5504 * window.c (delete_deletable_window): Now returns void, since it
5505 wasn't returning anything.
5506 (compare_window_configurations): Remove unused locals.
5507 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5508 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5509 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5510 the same widths as pointers. This follows up on the 2011-05-06 patch.
5511 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5512 * xterm.h: Likewise.
5513 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5514
5515 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5516
5517 * makefile.w32-in: Update dependencies.
5518 (LISP_H): Add lib/intprops.h.
5519
5520 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5521
5522 * image.c (gif_load): Add animation frame delay to the metadata.
5523 (syms_of_image): Use DEFSYM. New symbol `delay'.
5524
5525 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5526
5527 * window.c (delete_deletable_window): Re-add.
5528 (Fset_window_configuration): Rewrite to handle dead buffers and
5529 consequently deletable windows.
5530 (window_tree, Fwindow_tree): Remove. Supply functionality in
5531 window.el.
5532 (compare_window_configurations): Simplify code.
5533
5534 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5535
5536 * image.c (imagemagick_load_image): Fix type mismatch.
5537 (Fimagemagick_types): Likewise.
5538
5539 * window.h (replace_buffer_in_windows): Declare.
5540
5541 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5542
5543 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5544 Qclone_number. Remove external declaration of Qdelete_window.
5545 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5546 code.
5547 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5548 Run Qbuffer_list_update_hook if allowed.
5549 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5550 buffer list implementation.
5551 (other_buffer_safely): New function.
5552 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5553 calls to replace_buffer_in_windows and
5554 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5555 if allowed.
5556 (record_buffer): Inhibit quitting and rewrite using quittable
5557 functions. Run Qbuffer_list_update_hook if allowed.
5558 (Frecord_buffer, Funrecord_buffer): New functions.
5559 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5560 Move switch-to-buffer to window.el.
5561 (bury-buffer): Move to window.el.
5562 (Vbuffer_list_update_hook): New variable.
5563
5564 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5565 section.
5566
5567 * window.h (resize_frame_windows): Move up in code.
5568 (Fwindow_frame): Remove EXFUN.
5569 (replace_buffer_in_all_windows): Remove prototype.
5570 (replace_buffer_in_windows_safely): Add prototype.
5571
5572 * window.c: Declare Qdelete_window static again. Move down
5573 declaration of select_count.
5574 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5575 (Fother_window): Move to window.el.
5576 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5577 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5578 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5579 window.el.
5580 (replace_buffer_in_windows): Implement by calling
5581 Qreplace_buffer_in_windows.
5582 (replace_buffer_in_all_windows): Remove with some functionality
5583 moved into replace_buffer_in_windows_safely.
5584 (replace_buffer_in_windows_safely): New function.
5585 (select_window_norecord, select_frame_norecord): Move in front
5586 of run_window_configuration_change_hook. Remove now obsolete
5587 declarations.
5588 (Fset_window_buffer): Rewrite doc-string.
5589 Call Qrecord_window_buffer.
5590 (keys_of_window): Move binding for other-window to window.el.
5591
5592 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5593
5594 * dispextern.h (struct image): Replace data member, whose int_val
5595 and ptr_val fields were not used by anything, with a single
5596 lisp_val object.
5597
5598 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5599 (gif_clear_image, gif_load, imagemagick_load_image)
5600 (gs_clear_image, gs_load): Callers changed.
5601
5602 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5603
5604 * buffer.h: Include <time.h>, for time_t.
5605 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5606
5607 Fix minor problems found by static checking.
5608
5609 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5610
5611 Make identifiers static if they are not used in other modules.
5612 * data.c (Qcompiled_function, Qframe, Qvector):
5613 * image.c (QimageMagick, Qsvg):
5614 * minibuf.c (Qmetadata):
5615 * window.c (resize_window_check, resize_root_window): Now static.
5616 * window.h (resize_window_check, resize_root_window): Remove decls.
5617
5618 * window.c (window_deletion_count, delete_deletable_window):
5619 Remove; unused.
5620 (window_body_lines): Now static.
5621 (Fdelete_other_windows_internal): Mark vars as initialized.
5622 Make sure 'resize_failed' is initialized.
5623 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5624 (resize_window_apply): Remove unused local.
5625 * window.h (delete_deletable_window): Remove decl.
5626
5627 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5628 (imagemagick_load_image): Fix pointer signedness problem by changing
5629 last arg from unsigned char * to char *. All uses changed.
5630 Also, fix a local for similar reasons.
5631 Remove unused locals. Remove locals to avoid shadowing.
5632 (fn_rsvg_handle_free): Remove; unused.
5633 (svg_load, svg_load_image): Fix pointer signedness problem.
5634 (imagemagick_load_image): Don't use garbage pointer image_wand.
5635
5636 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5637
5638 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5639
5640 * image.c (gif_load): Fix omitted cast error introduced by
5641 2011-06-06 change.
5642
5643 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5644
5645 * window.h (resize_proportionally, orig_total_lines)
5646 (orig_top_line): Remove from window structure.
5647 (set_window_height, set_window_width, change_window_heights)
5648 (Fdelete_window): Remove prototypes.
5649 (resize_frame_windows): Remove duplicate declaration.
5650
5651 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5652
5653 * window.h (resize_frame_windows, resize_window_check)
5654 (delete_deletable_window, resize_root_window)
5655 (resize_frame_windows): Declare prototypes.
5656
5657 * window.c (resize_window_apply): Make definition be "static" to
5658 match the prototype.
5659
5660 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5661
5662 * window.c: Remove declarations of Qwindow_size_fixed,
5663 window_min_size_1, window_min_size_2, window_min_size,
5664 size_window, window_fixed_size_p, enlarge_window, delete_window.
5665 Remove static from declaration of Qdelete_window, it's
5666 temporarily needed by Fbury_buffer.
5667 (replace_window): Don't assign orig_top_line and
5668 orig_total_lines.
5669 (Fdelete_window, delete_window): Remove. Window deletion is
5670 handled by window.el.
5671 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5672 Replace Fdelete_window calls with calls to Qdelete_window.
5673 (Fdelete_other_windows): Remove. Deleting other windows is
5674 handled by window.el.
5675 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5676 handled in window.el.
5677 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5678 Window minimum sizes are handled in window.el.
5679 (shrink_windows, size_window, set_window_height)
5680 (set_window_width, change_window_heights, window_height)
5681 (window_width, CURBEG, CURSIZE, enlarge_window)
5682 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5683 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5684 handled in window.el.
5685 (make_dummy_parent): Rename to make_parent_window and give it a
5686 second argument horflag.
5687 (make_window): Don't set resize_proportionally any more.
5688 (Fsplit_window): Remove. Windows are split in window.el.
5689 (save_restore_action, save_restore_orig_size)
5690 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5691 Resize mini windows in window.el.
5692 (grow_mini_window, shrink_mini_window): Implement by calling
5693 Qresize_root_window_vertically, resize_window_check and
5694 resize_window_apply.
5695 (saved_window, Fset_window_configuration, save_window_save):
5696 Do not handle orig_top_line, orig_total_lines, and
5697 resize_proportionally.
5698 (window_min_height, window_min_width): Move to window.el.
5699 (keys_of_window): Move bindings for delete-other-windows,
5700 split-window, delete-window and enlarge-window to window.el.
5701
5702 * buffer.c: Temporarily extern Qdelete_window.
5703 (Fbury_buffer): Temporarily call Qdelete_window instead of
5704 Fdelete_window (Fbury_buffer will move to window.el soon).
5705
5706 * frame.c (set_menu_bar_lines_1): Remove code handling
5707 orig_top_line and orig_total_lines.
5708
5709 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5710 set_window_height but set heights directly.
5711 (change_frame_size_1): Use resize_frame_windows.
5712
5713 * xdisp.c (init_xdisp): Don't use set_window_height but set
5714 heights directly.
5715
5716 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5717 Use resize_frame_windows instead of change_window_heights and run
5718 run_window_configuration_change_hook.
5719
5720 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5721 instead of change_window_heights and run
5722 run_window_configuration_change_hook.
5723
5724 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5725
5726 * window.c (replace_window): Rename second argument REPLACEMENT to
5727 NEW. New third argument SETFLAG. Rewrite.
5728 (delete_window, make_dummy_parent): Call replace_window with
5729 third argument 1.
5730 (window_list_1): Move down in code.
5731 (run_window_configuration_change_hook): Move set_buffer part
5732 before select_frame_norecord part in order to unwind correctly.
5733 Rename count1 to count.
5734 (recombine_windows, delete_deletable_window, resize_root_window)
5735 (Fdelete_other_windows_internal)
5736 (Frun_window_configuration_change_hook, make_parent_window)
5737 (resize_window_check, resize_window_apply, Fresize_window_apply)
5738 (resize_frame_windows, Fsplit_window_internal)
5739 (Fdelete_window_internal, Fresize_mini_window_internal):
5740 New functions.
5741 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5742
5743 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5744
5745 * window.h (window): Add some new members to window structure -
5746 normal_lines, normal_cols, new_total, new_normal, clone_number,
5747 splits, nest, prev_buffers, next_buffers.
5748 (WINDOW_TOTAL_SIZE): Move here from window.c.
5749 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5750
5751 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5752 Remove.
5753 (make_dummy_parent): Set new members of windows structure.
5754 (make_window): Move down in code. Handle new members of window
5755 structure.
5756 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5757 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5758 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5759 (Fset_window_prev_buffers, Fwindow_next_buffers)
5760 (Fset_window_next_buffers, Fset_window_clone_number):
5761 New functions.
5762 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5763 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5764 Doc-string fixes.
5765 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5766 Argument WINDOW can be now internal window too.
5767 (Fwindow_use_time): Move up in code.
5768 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5769 Rewrite doc-string.
5770 (Fset_window_configuration, saved_window)
5771 (Fcurrent_window_configuration, save_window_save): Handle new
5772 members of window structure.
5773 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5774 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5775 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5776 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5777 Qget_mru_window, Qresize_root_window,
5778 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5779 Qauto_buffer_name; staticpro them.
5780
5781 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5782
5783 * window.c (Fwindow_total_size, Fwindow_left_column)
5784 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5785 (Fwindow_list_1): New functions.
5786 (window_box_text_cols): Replace with window_body_cols.
5787 (Fwindow_width, Fscroll_left, Fscroll_right):
5788 Use window_body_cols instead of window_box_text_cols.
5789 (delete_window, Fset_window_configuration):
5790 Call delete_all_subwindows with window as argument.
5791 (delete_all_subwindows): Take a window as argument and not a
5792 structure. Rewrite.
5793 (window_loop): Remove handling of GET_LRU_WINDOW and
5794 GET_LARGEST_WINDOW.
5795 (Fget_lru_window, Fget_largest_window): Move to window.el.
5796
5797 * window.h: Extern window_body_cols instead of
5798 window_box_text_cols. delete_all_subwindows now takes a
5799 Lisp_Object as argument.
5800
5801 * indent.c (compute_motion, Fcompute_motion):
5802 Use window_body_cols instead of window_box_text_cols.
5803
5804 * frame.c (delete_frame): Call delete_all_subwindows with root
5805 window as argument.
5806
5807 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5808
5809 * fns.c (Fputhash): Document return value.
5810
5811 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5812
5813 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5814
5815 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5816
5817 Cons<->int and similar integer overflow fixes (Bug#8794).
5818
5819 Check for overflow when converting integer to cons and back.
5820 * charset.c (Fdefine_charset_internal, Fdecode_char):
5821 Use cons_to_unsigned to catch overflow.
5822 (Fencode_char): Use INTEGER_TO_CONS.
5823 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5824 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5825 * data.c (long_to_cons, cons_to_long): Remove.
5826 (cons_to_unsigned, cons_to_signed): New functions.
5827 These signal an error for invalid or out-of-range values.
5828 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5829 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5830 * font.c (Ffont_variation_glyphs):
5831 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5832 * lisp.h: Include <intprops.h>.
5833 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5834 (cons_to_signed, cons_to_unsigned): New decls.
5835 (long_to_cons, cons_to_long): Remove decls.
5836 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5837 (Fprimitive_undo): Use CONS_TO_INTEGER.
5838 * xfns.c (Fx_window_property): Likewise.
5839 * xselect.c: Include <limits.h>.
5840 (x_own_selection, selection_data_to_lisp_data):
5841 Use INTEGER_TO_CONS.
5842 (x_handle_selection_request, x_handle_selection_clear)
5843 (x_get_foreign_selection, Fx_disown_selection_internal)
5844 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5845 (lisp_data_to_selection_data): Use cons_to_unsigned.
5846 (x_fill_property_data): Use cons_to_signed.
5847 Report values out of range.
5848
5849 Check for buffer and string overflow more precisely.
5850 * buffer.h (BUF_BYTES_MAX): New macro.
5851 * lisp.h (STRING_BYTES_MAX): New macro.
5852 * alloc.c (Fmake_string):
5853 * character.c (string_escape_byte8):
5854 * coding.c (coding_alloc_by_realloc):
5855 * doprnt.c (doprnt):
5856 * editfns.c (Fformat):
5857 * eval.c (verror):
5858 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5859 since they may not be the same number.
5860 * editfns.c (Finsert_char):
5861 * fileio.c (Finsert_file_contents):
5862 Likewise for BUF_BYTES_MAX.
5863
5864 * image.c: Use ptrdiff_t, not int, for sizes.
5865 (slurp_file): Switch from int to ptrdiff_t.
5866 All uses changed.
5867 (slurp_file): Check that file size fits in both size_t (for
5868 malloc) and ptrdiff_t (for sanity and safety).
5869
5870 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5871 if b->modtime has its maximal value.
5872
5873 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5874
5875 Don't assume time_t can fit into int.
5876 * buffer.h (struct buffer.modtime): Now time_t, not int.
5877 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5878 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5879
5880 Minor fixes for signed vs unsigned integers.
5881 * character.h (MAYBE_UNIFY_CHAR):
5882 * charset.c (maybe_unify_char):
5883 * keyboard.c (read_char, reorder_modifiers):
5884 XINT -> XFASTINT, since the integer must be nonnegative.
5885 * ftfont.c (ftfont_spec_pattern):
5886 * keymap.c (access_keymap, silly_event_symbol_error):
5887 XUINT -> XFASTINT, since the integer must be nonnegative.
5888 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5889 since it makes no difference and we prefer signed.
5890 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5891 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5892 nonnegative.
5893
5894 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5895
5896 * window.h (Fwindow_frame): Declare.
5897
5898 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5899
5900 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5901 (SPARE_MEMORY): Always define.
5902 (LARGE_REQUEST): Remove.
5903 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5904
5905 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5906
5907 * lisp.h: Move EXFUNS for Fframe_root_window,
5908 Fframe_first_window and Fset_frame_selected_window to window.h.
5909
5910 * window.h: Move EXFUNS for Fframe_root_window,
5911 Fframe_first_window and Fset_frame_selected_window here from
5912 lisp.h.
5913
5914 * frame.c (Fwindow_frame, Fframe_first_window)
5915 (Fframe_root_window, Fframe_selected_window)
5916 (Fset_frame_selected_window): Move to window.c.
5917 (Factive_minibuffer_window): Move to minibuf.c.
5918 (Fother_visible_frames_p): New function.
5919
5920 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5921
5922 * window.c (decode_window, decode_any_window): Move up in code.
5923 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5924 (inhibit_frame_unsplittable): Remove unused variable.
5925 (Fwindow_buffer): Move up and rewrite doc-string.
5926 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5927 (Fwindow_prev): New functions.
5928 (Fwindow_frame): Move here from frame.c. Accept any window as
5929 argument.
5930 (Fframe_root_window, Fframe_first_window)
5931 (Fframe_selected_window): Move here from frame.c. Accept frame
5932 or arbitrary window as argument. Update doc-strings.
5933 (Fminibuffer_window): Move up in code.
5934 (Fwindow_minibuffer_p): Move up in code and simplify.
5935 (Fset_frame_selected_window): Move here from frame.c.
5936 Marginal rewrite.
5937 (Fselected_window, select_window, Fselect_window): Move up in
5938 code. Minor doc-string fixes.
5939
5940 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5941
5942 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5943 Do not assume that spare memory exists; that assumption is valid
5944 only if SYSTEM_MALLOC.
5945 (LARGE_REQUEST): New macro, so that the issue of large requests
5946 is separated from the issue of spare memory.
5947
5948 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5949
5950 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5951 format. (Bug#8806)
5952
5953 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5954
5955 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5956 before statements.
5957
5958 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5959
5960 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5961
5962 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5963
5964 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5965 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5966
5967 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5968
5969 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5970
5971 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5972
5973 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5974 (x_clipboard_manager_save): Add return value.
5975 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5976 New error handlers.
5977 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5978 Obey Vx_select_enable_clipboard_manager. Catch errors in
5979 x_clipboard_manager_save (Bug#8779).
5980 (Vx_select_enable_clipboard_manager): New variable.
5981 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5982
5983 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5984
5985 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5986
5987 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5988
5989 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5990 in the current matrix if keep_current_p is non-zero.
5991
5992 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5993
5994 * bidi.c (bidi_level_of_next_char): Fix last change.
5995
5996 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5997
5998 Support bidi reordering of text covered by display properties.
5999
6000 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6001 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6002 (bidi_cache_search, bidi_cache_iterator_state)
6003 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6004 (bidi_level_of_next_char, bidi_move_to_visually_next):
6005 Support character positions inside a run of characters covered by a
6006 display string.
6007 (bidi_paragraph_init, bidi_resolve_explicit_1)
6008 (bidi_level_of_next_char): Call bidi_fetch_char and
6009 bidi_fetch_char_advance instead of FETCH_CHAR and
6010 FETCH_CHAR_ADVANCE.
6011 (bidi_init_it): Initialize new members.
6012 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6013 definitions.
6014 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6015 instead of using explicit *_CHAR codes.
6016 (bidi_resolve_explicit, bidi_resolve_weak):
6017 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6018 bidirectional text is supported only in multibyte buffers.
6019 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6020 it to initialize the frame_window_p member of struct bidi_it.
6021 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6022 (bidi_resolve_explicit, bidi_resolve_weak)
6023 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6024 bidi_it->nchars is non-positive.
6025 (bidi_level_of_next_char): Don't try to lookup the cache for the
6026 next/previous character if nothing is cached there yet, or if we
6027 were just reseat()'ed to a new position.
6028
6029 * xdisp.c (set_cursor_from_row): Set start and stop points
6030 according to the row's direction when priming the loop that looks
6031 for the glyph on which to display cursor.
6032 (single_display_spec_intangible_p): Function deleted.
6033 (display_prop_intangible_p): Reimplement to call
6034 handle_display_spec instead of single_display_spec_intangible_p.
6035 Accept 3 additional arguments needed by handle_display_spec.
6036 This fixes incorrect cursor motion across display property with complex
6037 values: lists, `(when COND...)' forms, etc.
6038 (single_display_spec_string_p): Support property values that are
6039 lists with the argument STRING its top-level element.
6040 (display_prop_string_p): Fix the condition for processing a
6041 property that is a list to be consistent with handle_display_spec.
6042 (handle_display_spec): New function, refactored from the
6043 last portion of handle_display_prop.
6044 (compute_display_string_pos): Accept additional argument
6045 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6046 value of a `display' property is a "replacing spec".
6047 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6048 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6049 the display property, but just return a value indicating whether
6050 the display property will replace the characters it covers.
6051 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6052 frame_window_p members of struct bidi_it.
6053 (compute_display_string_pos, compute_display_string_end):
6054 New functions.
6055 (push_it): Accept second argument POSITION, where pop_it should
6056 jump to continue iteration.
6057 (reseat_1): Initialize bidi_it.disp_pos.
6058
6059 * keyboard.c (adjust_point_for_property): Adjust the call to
6060 display_prop_intangible_p to its new signature.
6061
6062 * dispextern.h (struct bidi_it): New member frame_window_p.
6063 (bidi_init_it): Update prototypes.
6064 (display_prop_intangible_p): Update prototype.
6065 (compute_display_string_pos, compute_display_string_end):
6066 Declare prototypes.
6067 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6068 EMACS_INT.
6069
6070 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6071
6072 Malloc failure behavior now depends on size of allocation.
6073 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6074 * lisp.h: Change signatures accordingly.
6075 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6076 All callers changed. (Bug#8762)
6077
6078 * gnutls.c: Use Emacs's memory allocators.
6079 Without this change, the gnutls library would invoke malloc etc.
6080 directly, which causes problems on non-SYNC_INPUT hosts, and which
6081 runs afoul of improving memory_full behavior. (Bug#8761)
6082 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6083 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6084 xfree instead of the default malloc, realloc, free.
6085 (Fgnutls_boot): No need to check for memory allocation failure,
6086 since xmalloc does that for us.
6087
6088 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6089 * category.c (hash_get_category_set):
6090 * ccl.c (ccl_driver):
6091 * charset.c (Fdefine_charset_internal):
6092 * charset.h (struct charset.hash_index):
6093 * composite.c (get_composition_id, gstring_lookup_cache)
6094 (composition_gstring_put_cache):
6095 * composite.h (struct composition.hash_index):
6096 * dispextern.h (struct image.hash):
6097 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6098 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6099 (hashfn_equal, hashfn_user_defined, make_hash_table)
6100 (maybe_resize_hash_table, hash_lookup, hash_put)
6101 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6102 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6103 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6104 * image.c (make_image, search_image_cache, lookup_image)
6105 (xpm_put_color_table_h):
6106 * lisp.h (struct Lisp_Hash_Table):
6107 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6108 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6109 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6110 * alloc.c (allocate_vectorlike):
6111 Check for overflow in vector size calculations.
6112 * ccl.c (ccl_driver):
6113 Check for overflow when converting EMACS_INT to int.
6114 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6115 need to be updated by these changes.
6116 * fns.c (make_hash_table, maybe_resize_hash_table):
6117 Check for integer overflow with large hash tables.
6118 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6119 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6120 (SXHASH_REDUCE): New macro.
6121 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6122 Use it instead of discarding useful hash info with large hash values.
6123 (sxhash_float): New function.
6124 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6125 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6126 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6127 Rewrite to use FIXNUM_BITS, as this simplifies things.
6128 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6129 Adjust signatures to match updated version of code.
6130 (consing_since_gc): Now EMACS_INT, since a single hash table can
6131 use more than INT_MAX bytes.
6132
6133 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6134
6135 Make it possible to build with GCC-4.6+ -O2 -flto.
6136
6137 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6138
6139 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6140
6141 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6142 Call minibuffer-inactive-mode.
6143
6144 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6145
6146 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6147 Update dependencies.
6148
6149 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6150
6151 * data.c (init_data): Remove code for UTS, this system is not
6152 supported anymore.
6153
6154 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6155
6156 Don't force ./temacs to start in terminal mode.
6157
6158 * frame.c (make_initial_frame): Initialize faces in all cases, not
6159 only when CANNOT_DUMP is defined.
6160 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6161
6162 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6163
6164 * dispnew.c (add_window_display_history): Use const for the string
6165 pointer. Remove declaration, not needed.
6166
6167 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6168
6169 Use 'inline', not 'INLINE'.
6170 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6171 * alloc.c, fontset.c (INLINE): Remove.
6172 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6173 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6174 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6175 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6176 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6177
6178 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6179
6180 Make it possible to run ./temacs.
6181
6182 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6183 syms_of_callproc does the same thing. Remove test for
6184 "initialized", do it in the caller.
6185 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6186
6187 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6188
6189 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6190 (read_minibuf): Use get_minibuffer.
6191 (syms_of_minibuf): Use DEFSYM.
6192 (Qmetadata): New var.
6193 * data.c (Qbuffer): Don't make it static.
6194 (syms_of_data): Use DEFSYM.
6195
6196 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6197
6198 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6199 (CCL_CODE_MIN): New macro.
6200
6201 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6202
6203 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6204
6205 * eval.c (Qdebug): Now static.
6206 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6207 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6208 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6209
6210 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6211
6212 * image.c: Various fixes to ImageMagick code comments.
6213 (Fimagemagick_types): Doc fix.
6214
6215 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6216
6217 Minor fixes prompted by GCC 4.6.0 warnings.
6218
6219 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6220
6221 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6222 (x_clipboard_manager_save_all): Move extern decl to ...
6223 * xterm.h: ... here, so that it can be checked for consistency.
6224
6225 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6226
6227 * xselect.c (x_clipboard_manager_save_frame)
6228 (x_clipboard_manager_save_all): New functions.
6229 (Fx_clipboard_manager_save): Lisp function deleted.
6230
6231 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6232 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6233
6234 * xterm.h: Update prototype.
6235
6236 2011-05-28 William Xu <william.xwl@gmail.com>
6237
6238 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6239 exiting (Bug#8239).
6240
6241 2011-05-28 Jim Meyering <meyering@redhat.com>
6242
6243 Avoid a sign-extension bug in crypto_hash_function.
6244 * fns.c (to_uchar): Define.
6245 (crypto_hash_function): Use it to convert some newly-signed
6246 variables to unsigned, to avoid sign-extension bugs. For example,
6247 without this change, (md5 "truc") would evaluate to
6248 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6249 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6250 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6251
6252 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6253
6254 Integer overflow fixes.
6255
6256 * dbusbind.c: Serial number integer overflow fixes.
6257 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6258 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6259 to hold a serial number that is too large for a fixnum.
6260 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6261 Check for serial numbers out of range. Decode any serial number
6262 that was so large that it became a float. (Bug#8722)
6263
6264 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6265 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6266 Use XFASTINT rather than XUINT when numbers are nonnegative.
6267 (xd_append_arg, Fdbus_method_return_internal):
6268 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6269 arguments, check that Lisp number is nonnegative, rather than
6270 silently wrapping negative numbers around. (Bug#8722)
6271 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6272 (Bug#8722)
6273
6274 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6275
6276 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6277
6278 ccl: Add integer overflow checks.
6279 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6280 (IN_INT_RANGE): New macros.
6281 (ccl_driver): Use them to check for integer overflow when
6282 decoding a CCL program. Many of the new checks are whether XINT (x)
6283 fits in int; it doesn't always, on 64-bit hosts. The new version
6284 doesn't catch all possible integer overflows, but it's an
6285 improvement. (Bug#8719)
6286
6287 * alloc.c (make_event_array): Use XINT, not XUINT.
6288 There's no need for unsigned here.
6289
6290 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6291 This follows up to the 2011-05-06 change that substituted uintptr_t
6292 for EMACS_INT. This case wasn't caught back then.
6293
6294 Rework Fformat to avoid integer overflow issues.
6295 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6296 now (part of C89). Include <verify.h>.
6297 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6298 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6299 (Fformat): Avoid the prepass trying to compute sizes; it was only
6300 approximate and thus did not catch overflow reliably. Instead, walk
6301 through the format just once, formatting and computing sizes as we go,
6302 checking for integer overflow at every step, and allocating a larger
6303 buffer as needed. Keep track separately whether the format is
6304 multibyte. Keep only the most-recently calculated precision, rather
6305 than them all. Record whether each argument has been converted to
6306 string. Use EMACS_INT, not int, for byte and char and arg counts.
6307 Support field widths and precisions larger than INT_MAX. Avoid
6308 sprintf's undefined behavior with conversion specifications such as %#d
6309 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6310 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6311 formatting out-of-range floating point numbers with int
6312 formats. (Bug#8668)
6313
6314 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6315
6316 * data.c: Avoid integer truncation in expressions involving floats.
6317 * data.c: Include <intprops.h>.
6318 (arith_driver): When there's an integer overflow in an expression
6319 involving floating point, convert the integers to floating point
6320 so that the resulting value does not suffer from catastrophic
6321 integer truncation. For example, on a 64-bit host (* 4
6322 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6323 Do not rely on undefined behavior after integer overflow.
6324
6325 merge count_size_as_multibyte, parse_str_to_multibyte
6326 * character.c, character.h (count_size_as_multibyte):
6327 Rename from parse_str_to_multibyte; all uses changed.
6328 Check for integer overflow.
6329 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6330 since it's now a duplicate of the other. This is more of
6331 a character than a buffer op, so better that it's in character.c.
6332 * fns.c, print.c: Adjust to above changes.
6333
6334 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6335
6336 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6337
6338 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6339
6340 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6341 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6342 (x_clipboard_manager_save): Now static.
6343 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6344
6345 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6346 (crypto_hash_function): Now static.
6347 Fix pointer signedness problems. Avoid unnecessary initializations.
6348
6349 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6350
6351 * termhooks.h (Vselection_alist): Make it terminal-local.
6352
6353 * terminal.c (create_terminal): Initialize it.
6354
6355 * xselect.c: Support for clipboard managers.
6356 (Vselection_alist): Move to termhooks.h as terminal-local var.
6357 (LOCAL_SELECTION): New macro.
6358 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6359 (symbol_to_x_atom): Remove gratuitous arg.
6360 (x_handle_selection_request, lisp_data_to_selection_data)
6361 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6362 (x_own_selection, x_get_local_selection, x_convert_selection):
6363 New arg, specifying work frame. Use terminal-local Vselection_alist.
6364 (some_frame_on_display): Delete unused function.
6365 (Fx_own_selection_internal, Fx_get_selection_internal)
6366 (Fx_disown_selection_internal, Fx_selection_owner_p)
6367 (Fx_selection_exists_p): New optional frame arg.
6368 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6369 (x_handle_selection_clear): Don't treat other terminals with the
6370 same keyboard specially. Use the terminal-local Vselection_alist.
6371 (x_clear_frame_selections): Use Frun_hook_with_args.
6372
6373 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6374
6375 * xterm.h: Add support for those atoms.
6376
6377 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6378
6379 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6380 (converted_selections, conversion_fail_tag): New global variables.
6381 (x_selection_request_lisp_error): Free the above.
6382 (x_get_local_selection): Remove unnecessary code.
6383 (x_reply_selection_request): Args changed; handle arbitrary array
6384 of converted selections stored in converted_selections.
6385 Separate the XChangeProperty and SelectionNotify steps.
6386 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6387 (x_convert_selection): New function.
6388 (x_handle_selection_event): Simplify.
6389 (x_get_foreign_selection): Don't ignore incoming requests while
6390 waiting for an answer; this will fail when we implement
6391 SAVE_TARGETS, and seems unnecessary anyway.
6392 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6393 (Vx_sent_selection_functions): Doc fix.
6394
6395 2011-05-26 Leo Liu <sdl.web@gmail.com>
6396
6397 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6398
6399 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6400
6401 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6402
6403 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6404 for fringe update if it has periodic bitmap.
6405 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6406 and fringe_bitmap_periodic_p.
6407
6408 * fringe.c (get_fringe_bitmap_data): New function.
6409 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6410 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6411 row. Mark glyph row for fringe update if periodicity changed.
6412
6413 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6414 for fringe update unless it has periodic bitmap.
6415
6416 2011-05-25 Kenichi Handa <handa@m17n.org>
6417
6418 * xdisp.c (get_next_display_element): Set correct it->face_id for
6419 a static composition.
6420
6421 2011-05-24 Leo Liu <sdl.web@gmail.com>
6422
6423 * deps.mk (fns.o):
6424 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6425
6426 * fns.c (crypto_hash_function, Fsha1): New function.
6427 (Fmd5): Use crypto_hash_function.
6428 (syms_of_fns): Add Ssha1.
6429
6430 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6431
6432 * gnutls.c: Remove unused macros.
6433 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6434 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6435 Remove macros that are defined and never used.
6436 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6437
6438 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6439
6440 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6441 (Fx_get_selection_internal): Minor cleanup.
6442 (Fx_own_selection_internal): Rename arguments for consistency with
6443 select.el.
6444
6445 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6446
6447 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6448
6449 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6450
6451 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6452
6453 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6454
6455 * dispnew.c (scrolling_window): Don't exclude the case that the
6456 last enabled row in the desired matrix touches the bottom boundary.
6457
6458 2011-05-21 Glenn Morris <rgm@gnu.org>
6459
6460 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6461 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6462 and add some more files.
6463
6464 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6465
6466 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6467 report_file_error introduced by the change from 2011-05-07.
6468
6469 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6470
6471 * systime.h (Time): Define only if emacs is defined.
6472 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6473 where the include path doesn't have X11/X.h by default. See
6474 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6475
6476 2011-05-20 Kenichi Handa <handa@m17n.org>
6477
6478 * composite.c (find_automatic_composition): Fix previous change.
6479
6480 2011-05-20 Glenn Morris <rgm@gnu.org>
6481
6482 * lisp.mk: New file, split from Makefile.in.
6483 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6484 (shortlisp): Remove.
6485 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6486
6487 2011-05-19 Glenn Morris <rgm@gnu.org>
6488
6489 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6490 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6491 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6492 (lisp): Set the order to that of loadup.el.
6493 (shortlisp): Make it a copy of $lisp.
6494 (SOME_MACHINE_LISP): Remove.
6495 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6496 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6497
6498 2011-05-18 Kenichi Handa <handa@m17n.org>
6499
6500 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6501 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6502 (find_automatic_composition): Mostly rewrite for efficiency.
6503
6504 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6505
6506 * makefile.w32-in: Update dependencies.
6507
6508 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6509
6510 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6511 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6512
6513 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6514
6515 Fix some integer overflow issues, such as string length overflow.
6516
6517 * insdel.c (count_size_as_multibyte): Check for string overflow.
6518
6519 * character.c (lisp_string_width): Check for string overflow.
6520 Use EMACS_INT, not int, for string indexes and lengths; in
6521 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6522 the resulting string length overflows an EMACS_INT; instead,
6523 report a string overflow if no precision given. When checking for
6524 precision exhaustion, use a check that cannot possibly have
6525 integer overflow. (Bug#8675)
6526 * character.h (lisp_string_width): Adjust to new signature.
6527
6528 * alloc.c (string_overflow): New function.
6529 (Fmake_string): Use it. This doesn't change behavior, but saves
6530 a few bytes and will simplify future changes.
6531 * character.c (string_escape_byte8): Likewise.
6532 * lisp.h (string_overflow): New decl.
6533
6534 Fixups, following up to the user-interface timestamp change.
6535 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6536 for UI timestamps, instead of unsigned long.
6537 * msdos.c (mouse_get_pos): Likewise.
6538 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6539 * w32gui.h (Time): Define by including "systime.h" rather than by
6540 declaring it ourselves. (Bug#8664)
6541
6542 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6543 * image.c (clear_image_cache): Likewise.
6544
6545 * term.c (term_mouse_position): Don't assume time_t wraparound.
6546
6547 Be more systematic about user-interface timestamps.
6548 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6549 and sometimes 'EMACS_UINT', to represent these timestamps.
6550 This change causes it to use 'Time' uniformly, as that's what X uses.
6551 This makes the code easier to follow, and makes it easier to catch
6552 integer overflow bugs such as Bug#8664.
6553 * frame.c (Fmouse_position, Fmouse_pixel_position):
6554 Use Time, not unsigned long, for user-interface timestamps.
6555 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6556 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6557 * keyboard.h (last_event_timestamp): Likewise.
6558 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6559 * menu.h (xmenu_show): Likewise.
6560 * term.c (term_mouse_position): Likewise.
6561 * termhooks.h (struct input_event.timestamp): Likewise.
6562 (struct terminal.mouse_position_hook): Likewise.
6563 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6564 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6565 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6566 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6567 what it was before.
6568 * menu.h, termhooks.h: Include "systime.h", for Time.
6569
6570 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6571 Don't assume that the difference between two unsigned long values
6572 can fit into an integer. At this point, we know button_down_time
6573 <= event->timestamp, so the difference must be nonnegative, so
6574 there's no need to cast the result if double-click-time is
6575 nonnegative, as it should be; check that it's nonnegative, just in
6576 case. This bug is triggered when events are more than 2**31 ms
6577 apart (about 25 days). (Bug#8664)
6578
6579 * xselect.c (last_event_timestamp): Remove duplicate decl.
6580 (x_own_selection): Remove needless cast to unsigned long.
6581
6582 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6583 that always fit in int. Use a sentinel instead of a counter, to
6584 avoid a temp and to allay GCC's concerns about possible int overflow.
6585 * frame.h (struct frame): Use int for menu_bar_items_used
6586 instead of EMACS_INT, since it always fits in int.
6587
6588 * menu.c (grow_menu_items): Check for int overflow.
6589
6590 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6591
6592 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6593 Before, the code was not consistent. These values cannot exceed
6594 2**31 - 1 so there's no need to make them unsigned.
6595 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6596 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6597 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6598 as modifiers.
6599 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6600
6601 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6602 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6603 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6604 presumably because the widths might not match.
6605
6606 * window.c (size_window): Avoid needless test at loop start.
6607
6608 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6609
6610 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6611
6612 2011-05-12 Drew Adams <drew.adams@oracle.com>
6613
6614 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6615
6616 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6617
6618 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6619 `width' to `bar_area_x' and `bar_area_width', respectively.
6620 (x_scroll_run): Take account of fringe background extension.
6621
6622 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6623 Rename local vars `left' and `width' to `bar_area_x' and
6624 `bar_area_width', respectively.
6625 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6626 background extension.
6627
6628 2011-05-10 Jim Meyering <meyering@redhat.com>
6629
6630 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6631
6632 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6633
6634 * image.c (Finit_image_library): Return t for built-in image types,
6635 like pbm and xbm. (Bug#8640)
6636
6637 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6638
6639 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6640
6641 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6642
6643 * w32console.c (Fset_screen_color): Doc fix.
6644 (Fget_screen_color): New function.
6645 (syms_of_ntterm): Defsubr it.
6646
6647 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6648 unlink the temporary file if Fcall_process didn't create it in the
6649 first place.
6650 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6651 child process will be redirected to a file specified with `:file'.
6652 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6653 cue to call_process_cleanup not to close that handle.
6654
6655 2011-05-07 Ben Key <bkey76@gmail.com>
6656
6657 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6658 one of two shell specific rules, either bootstrap-temacs-CMD or
6659 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6660 to the previous implementation of the bootstrap-temacs rule.
6661 The bootstrap-temacs-CMD rule is similar to the previous
6662 implementation of the bootstrap-temacs rule except that it
6663 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6664 variable.
6665
6666 These changes, along with some changes to nt/configure.bat,
6667 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6668 earlier fix to add support for --cflags and --ldflags options
6669 that include quotes so that it works whether make uses cmd or
6670 sh as the shell.
6671
6672 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6673
6674 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6675 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6676 is a constant.
6677 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6678 a string. Handle both cases.
6679 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6680 (Fdbus_register_method): Use Qinvalid_function.
6681
6682 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6683
6684 * makefile.w32-in: Update dependencies.
6685 (LISP_H): Add inttypes.h and stdin.h.
6686 (PROCESS_H): Add unistd.h.
6687
6688 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6689
6690 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6691 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6692
6693 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6694
6695 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6696
6697 * term.c (vfatal): Remove stray call to va_end.
6698 It's not needed and the C Standard doesn't allow it here anyway.
6699
6700 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6701 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6702
6703 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6704 bytes.
6705
6706 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6707
6708 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6709
6710 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6711
6712 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6713
6714 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6715
6716 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6717 * charset.c (Fdefine_charset_internal): Don't initialize
6718 charset.code_space[15]. The value was garbage, on hosts with
6719 32-bit int (Bug#8600).
6720
6721 * lread.c (read_integer): Be more consistent with string-to-number.
6722 Use string_to_number to do the actual conversion; this avoids
6723 rounding errors and fixes some other screwups. Without this fix,
6724 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6725 (digit_to_number): Move earlier, for benefit of read_integer.
6726 Return -1 if the digit is out of range for the base, -2 if it is
6727 not a digit in any supported base. (Bug#8602)
6728
6729 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6730
6731 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6732 to match comment at start of function. This also removes a
6733 GCC warning about overflow in a 32+64-bit port.
6734
6735 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6736
6737 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6738 Reported by Stefan Monnier in
6739 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6740 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6741 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6742
6743 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6744 (EMACS_UINTPTR): Likewise, with uintptr_t.
6745
6746 * lisp.h: Prefer 64-bit EMACS_INT if available.
6747 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6748 on 32-bit hosts that have 64-bit int, so that they can access
6749 large files.
6750 However, temporarily disable this change unless the temporary
6751 symbol WIDE_EMACS_INT is defined.
6752
6753 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6754
6755 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6756 This removes an assumption that EMACS_INT and long are the same
6757 width as pointers. The assumption is true for Emacs porting targets
6758 now, but we want to make other targets possible.
6759 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6760 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6761 In the rest of the code, change types of integers that hold casted
6762 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6763 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6764 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6765 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6766 No need to cast type when ORing.
6767 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6768 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6769 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6770 assume EMACS_INT is the same width as char *.
6771 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6772 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6773 Remove no-longer-needed casts.
6774 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6775 (xg_tool_bar_help_callback, xg_make_tool_item):
6776 Use EMACS_INTPTR to hold an integer
6777 that will be cast to void *; this can avoid a GCC warning
6778 if EMACS_INT is not the same width as void *.
6779 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6780 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6781 (current_message_1, set_message_1):
6782 Use a local to convert to proper width without a cast.
6783 * xmenu.c (dialog_selection_callback): Likewise.
6784
6785 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6786 Also, don't assume VALBITS / RAND_BITS is less than 5,
6787 and don't rely on undefined behavior when shifting a 1 left into
6788 the sign bit.
6789 * lisp.h (get_random): Change signature to match.
6790
6791 * lread.c (hash_string): Use size_t, not int, for hash computation.
6792 Normally we prefer signed values; but hashing is special, because
6793 it's better to use unsigned division on hash table sizes so that
6794 the remainder is nonnegative. Also, size_t is the natural width
6795 for hashing into memory. The previous code used 'int', which doesn't
6796 retain enough info to hash well into very large tables.
6797 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6798
6799 * dbusbind.c: Don't possibly lose pointer info when converting.
6800 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6801 Use XPNTR rather than XHASH, so that the high-order bits of
6802 the pointer aren't lost when converting through void *.
6803
6804 * eval.c (Fautoload): Don't double-shift a pointer.
6805
6806 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6807
6808 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6809
6810 * gnutls.c (DEF_GNUTLS_FN):
6811 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6812
6813 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6814
6815 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6816 marker. (Bug#8610)
6817
6818 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6819
6820 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6821 New version that can reserve upto 2GB of heap space.
6822
6823 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6824
6825 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6826
6827 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6828
6829 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6830 `gnutls_certificate_set_x509_key_file'.
6831
6832 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6833
6834 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6835 Update dependencies.
6836
6837 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6838
6839 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6840 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6841 Remove unused parameter `fildes'.
6842 * process.c (read_process_output, send_process): Don't pass it.
6843
6844 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6845
6846 Fix previous change: the library cache is defined in w32.c.
6847 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6848 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6849
6850 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6851
6852 Implement dynamic loading of GnuTLS on Windows.
6853
6854 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6855 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6856 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6857 Declare.
6858
6859 * gnutls.c (Qgnutls_dll): Define.
6860 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6861 (gnutls_*): Declare function pointers.
6862 (init_gnutls_functions): New function to initialize function pointers.
6863 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6864 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6865 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6866 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6867 (emacs_gnutls_write, emacs_gnutls_read)
6868 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6869 (Fgnutls_available_p): New function.
6870 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6871 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6872 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6873
6874 * image.c: Include w32.h.
6875 (Vimage_type_cache): Delete.
6876 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6877 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6878 (w32_delayed_load): Move to w32.c.
6879
6880 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6881
6882 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6883 (w32_delayed_load): Move from image.c. When loading a library, record
6884 its filename in the :loaded-from property of the library id.
6885 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6886 Initialize and staticpro them.
6887 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6888
6889 * process.c: Include lisp.h before w32.h, not after.
6890 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6891 instead of gnutls_record_check_pending.
6892
6893 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6894
6895 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6896
6897 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6898 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6899 as passed in.
6900
6901 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6902
6903 * xterm.c (x_set_frame_alpha): Do not set property on anything
6904 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6905
6906 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6907
6908 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6909
6910 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6911
6912 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6913 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6914 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6915 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6916 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6917 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6918 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6919 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6920 (Qgnutls_bootprop_callbacks_verify): Make static.
6921
6922 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6923
6924 * callproc.c: Indentation fixup.
6925
6926 * sysdep.c (wait_for_termination_1): Make static.
6927 (wait_for_termination, interruptible_wait_for_termination):
6928 Move after wait_for_termination_1.
6929
6930 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6931
6932 * sysdep.c (interruptible_wait_for_termination): New function
6933 which is like wait_for_termination, but allows keyboard
6934 interruptions.
6935
6936 * callproc.c (Fcall_process): Add (:file "file") as an option for
6937 the STDOUT buffer.
6938 (Fcall_process_region): Ditto.
6939
6940 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6941
6942 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6943 rather than `XVECTOR (FOO)->size'.
6944
6945 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6946 inttypes.h, as a gnulib replacement is used if it not available in
6947 system headers.
6948
6949 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6950
6951 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6952 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6953 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6954
6955 * coding.c (coding_alloc_by_realloc): Error out if destination
6956 will grow beyond MOST_POSITIVE_FIXNUM.
6957 (decode_coding_emacs_mule): Abort if there isn't enough place in
6958 charbuf for the composition carryover bytes. Reserve an extra
6959 space for up to 2 characters produced in a loop.
6960 (decode_coding_iso_2022): Abort if there isn't enough place in
6961 charbuf for the composition carryover bytes.
6962
6963 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6964
6965 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6966 aborting when %lld or %lll format is passed.
6967 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6968 %llo or %llx format is passed. (Bug#8545)
6969
6970 * window.c (window_scroll_line_based): Use a marker instead of
6971 simple variables to record original value of point. (Bug#7952)
6972
6973 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6974 produced by %s or %c overflows available buffer space. (Bug#8545)
6975
6976 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6977
6978 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6979 (SIZE_MAX): Move defn after all includes, as they might #define it.
6980
6981 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6982
6983 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6984
6985 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6986
6987 * keyboard.c (Qdelayed_warnings_hook): Define.
6988 (command_loop_1): Run `delayed-warnings-hook'
6989 if Vdelayed_warnings_list is non-nil.
6990 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6991 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6992
6993 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6994
6995 * doprnt.c (doprnt): Don't return value smaller than the buffer
6996 size if the message was truncated. (Bug#8545).
6997
6998 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6999
7000 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7001 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7002
7003 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7004
7005 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7006
7007 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7008
7009 * makefile.w32-in: Update dependencies.
7010
7011 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7012
7013 Improve `doprnt' and its usage. (Bug#8545)
7014 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7015 `format_end'. Remove support for %l as a conversion specifier.
7016 Don't use xrealloc. Improve diagnostics when the %l size modifier
7017 is used. Update the commentary.
7018
7019 * eval.c (verror): Simplify calculation of size_t.
7020
7021 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7022 messages.
7023
7024 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7025
7026 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7027 change.
7028
7029 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7030
7031 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7032 This makes this file independent of the recent pseudovector change.
7033
7034 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7035
7036 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7037
7038 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7039 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7040 Remove unused local.
7041 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7042
7043 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7044 GCC 4.6.0 optimizes based on type-based alias analysis.
7045 For example, if b is of type struct buffer * and v of type struct
7046 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7047 != &v->size, and therefore "v->size = 1; b->size = 2; return
7048 v->size;" must therefore return 1. This assumption is incorrect
7049 for Emacs, since it type-puns struct Lisp_Vector * with many other
7050 types. To fix this problem, this patch adds a new type struct
7051 vectorlike_header that documents the constraints on layout of vectors
7052 and pseudovectors, and helps optimizing compilers not get fooled
7053 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7054 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7055 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7056 the size member.
7057 (XSETPVECTYPE): Rewrite in terms of new macro.
7058 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7059 This is a bit clearer, and further avoids the possibility of
7060 undesirable aliasing.
7061 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7062 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7063 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7064 since Lisp_Subr is a special case (no "next" field).
7065 (ASIZE): Now uses header.size rather than size.
7066 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7067 to avoid the hassle of writing XVECTOR (foo)->header.size.
7068 (struct vectorlike_header): New type.
7069 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7070 object, to help avoid aliasing.
7071 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7072 (SUBRP): Likewise, since Lisp_Subr is a special case.
7073 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7074 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7075 (struct Lisp_Hash_Table): Combine first two members into a single
7076 struct vectorlike_header member. All uses of "size" and "next" members
7077 changed to be "header.size" and "header.next".
7078 * buffer.h (struct buffer): Likewise.
7079 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7080 * frame.h (struct frame): Likewise.
7081 * process.h (struct Lisp_Process): Likewise.
7082 * termhooks.h (struct terminal): Likewise.
7083 * window.c (struct save_window_data, struct saved_window): Likewise.
7084 * window.h (struct window): Likewise.
7085 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7086 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7087 * buffer.c (init_buffer_once): Likewise.
7088 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7089 special case.
7090 * process.c (Fformat_network_address): Use local var for size,
7091 for brevity.
7092
7093 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7094
7095 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7096 * data.c (atof): Remove decl; no longer used or needed.
7097 (digit_to_number): Move to lread.c.
7098 (Fstring_to_number): Use new string_to_number function, to be
7099 consistent with how the Lisp reader treats infinities and NaNs.
7100 Do not assume that floating-point numbers represent EMACS_INT
7101 without losing information; this is not true on most 64-bit hosts.
7102 Avoid double-rounding errors, by insisting on integers when
7103 parsing non-base-10 numbers, as the documentation specifies.
7104 * lisp.h (string_to_number): New decl, replacing ...
7105 (isfloat_string): Remove.
7106 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7107 (read1): Do not accept +. and -. as integers; this
7108 appears to have been a coding error. Similarly, do not accept
7109 strings like +-1e0 as floating point numbers. Do not report
7110 overflow for integer overflows unless the base is not 10 which
7111 means we have no simple and reliable way to continue.
7112 Break out the floating-point parsing into a new
7113 function string_to_number, so that Fstring_to_number parses
7114 floating point numbers consistently with the Lisp reader.
7115 (digit_to_number): Move here from data.c. Make it static inline.
7116 (E_CHAR, EXP_INT): Remove, replacing with ...
7117 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7118 (string_to_number): New function, replacing isfloat_string.
7119 This function checks for valid syntax and produces the resulting
7120 Lisp float number too. Rework it so that string-to-number
7121 no longer mishandles examples like "1.0e+". Use strtoumax,
7122 so that overflow for non-base-10 numbers is reported only when
7123 there's no portable and simple way to convert to floating point.
7124
7125 * textprop.c (set_text_properties_1): Rewrite for clarity,
7126 and to avoid GCC warning about integer overflow.
7127
7128 * intervals.h (struct interval): Use EMACS_INT for members
7129 where EMACS_UINT might cause problems. See
7130 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7131 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7132 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7133 All uses changed.
7134 (offset_intervals): Tell GCC not to worry about length overflow
7135 when negating a negative length.
7136
7137 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7138 (overrun_check_free): Likewise.
7139
7140 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7141 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7142 word size.
7143
7144 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7145 (gnutls_make_error): Rename local to avoid shadowing.
7146 (gnutls_emacs_global_deinit): ifdef out; not used.
7147 (Fgnutls_boot): Use const for pointer to readonly storage.
7148 Comment out unused local. Fix pointer signedness problems.
7149
7150 * lread.c (openp): Don't stuff size_t into an 'int'.
7151 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7152 about possible signed overflow.
7153
7154 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7155 (GDK_KEY_g): Don't define if already defined.
7156 (xg_prepare_tooltip): Avoid pointer signedness problem.
7157 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7158
7159 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7160 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7161
7162 * xfns.c (Fx_window_property): Simplify a bit,
7163 to make a bit faster and to avoid GCC 4.6.0 warning.
7164 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7165
7166 * fns.c (internal_equal): Don't assume size_t fits in int.
7167
7168 * alloc.c (compact_small_strings): Tighten assertion a little.
7169
7170 Replace pEd with more-general pI, and fix some printf arg casts.
7171 * lisp.h (pI): New macro, generalizing old pEd macro to other
7172 conversion specifiers. For example, use "...%"pI"d..." rather
7173 than "...%"pEd"...".
7174 (pEd): Remove. All uses replaced with similar uses of pI.
7175 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7176 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7177 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7178 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7179 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7180 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7181 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7182 64-bit hosts.
7183 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7184 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7185 * print.c (safe_debug_print, print_object): Likewise.
7186 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7187 to int.
7188 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7189 avoiding the 0 flag, which is not portable.
7190 * process.c (Fmake_network_process): Use pI to avoid cast.
7191 * region-cache.c (pp_cache): Likewise.
7192 * xdisp.c (decode_mode_spec): Likewise.
7193 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7194 behavior on 64-bit hosts with printf arg.
7195 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7196 (x_stop_queuing_selection_requests): Likewise.
7197 (x_get_window_property): Don't truncate byte count to an 'int'
7198 when tracing.
7199
7200 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7201 here, since it parses constructs like leading '-' and spaces,
7202 which are not wanted; and it overflows with large numbers.
7203 Instead, simply match F[0-9]+, which is what is wanted anyway.
7204
7205 * alloc.c: Remove unportable assumptions about struct layout.
7206 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7207 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7208 (allocate_vectorlike, make_pure_vector): Use the new macros,
7209 plus offsetof, to remove unportable assumptions about struct layout.
7210 These assumptions hold on all porting targets that I know of, but
7211 they are not guaranteed, they're easy to remove, and removing them
7212 makes further changes easier.
7213
7214 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7215 This doesn't fix a bug but makes the code clearer.
7216 (string_overrun_cookie): Now const. Use initializers that
7217 don't formally overflow signed char, to avoid warnings.
7218 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7219 can cause Emacs to crash when string overrun checking is enabled.
7220 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7221 multiple of sizeof (EMACS_INT); it need not be, if
7222 alignof(EMACS_INT) < sizeof (EMACS_INT).
7223 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7224
7225 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7226
7227 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7228
7229 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7230
7231 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7232 supposed to be handshaking. (Bug#8556)
7233 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7234
7235 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7236
7237 * lisp.h (Qdebug): List symbol.
7238 * eval.c (Qdebug): Restore global linkage.
7239 * keyboard.c (debug-on-event): New variable.
7240 (handle_user_signal): Break into debugger when debug-on-event
7241 matches the current signal symbol.
7242
7243 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7244
7245 * alloc.c (check_sblock, check_string_bytes)
7246 (check_string_free_list): Convert to standard C.
7247
7248 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7249
7250 * w32.c (emacs_gnutls_push): Fix typo.
7251
7252 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7253
7254 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7255 "cast to pointer from integer of different size".
7256
7257 Improve doprnt and its use in verror. (Bug#8545)
7258 * doprnt.c (doprnt): Document the set of format control sequences
7259 supported by the function. Use SAFE_ALLOCA instead of always
7260 using `alloca'.
7261
7262 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7263 is one byte too soon. Don't use xrealloc; instead xfree and
7264 xmalloc anew.
7265
7266 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7267
7268 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7269 callbacks stage.
7270
7271 * gnutls.c: Renamed global_initialized to
7272 gnutls_global_initialized. Added internals for the
7273 :verify-hostname-error, :verify-error, and :verify-flags
7274 parameters of `gnutls-boot' and documented those parameters in the
7275 docstring. Start callback support.
7276 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7277 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7278 on error. Return error code.
7279 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7280 (emacs_gnutls_read): Likewise.
7281 (Fgnutls_boot): Return handshake error code.
7282 (emacs_gnutls_handle_error): New function.
7283 (wsaerror_to_errno): Likewise.
7284
7285 * w32.h (emacs_gnutls_pull): Add prototype.
7286 (emacs_gnutls_push): Likewise.
7287
7288 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7289 (emacs_gnutls_push): Likewise.
7290
7291 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7292
7293 * process.c (wait_reading_process_output): Check if GnuTLS
7294 buffered some data internally if no FDs are set for TLS
7295 connections.
7296
7297 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7298 (LIBS): Link to USER_LIBS.
7299 ($(BLD)/gnutls.$(0)): New target.
7300
7301 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7302
7303 * xdisp.c (handle_single_display_spec): Rename the
7304 display_replaced_before_p argument into display_replaced_p, to
7305 make it consistent with the commentary. Fix typos in the
7306 commentary.
7307
7308 * textprop.c (syms_of_textprop): Remove dead code.
7309 (copy_text_properties): Delete obsolete commentary about an
7310 interface that was deleted long ago. Fix typos in the description
7311 of arguments.
7312
7313 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7314 to changes in oldXMenu/XMenu.h from 2011-04-16.
7315 <menu_help_message, prev_menu_help_message>: Constify.
7316 (IT_menu_make_room): menu->help_text is now `const char **';
7317 adjust.
7318
7319 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7320 to changes in oldXMenu/XMenu.h from 2011-04-16.
7321 (struct XMenu): Declare `help_text' `const char **'.
7322
7323 * xfaces.c <Qunspecified>: Make extern again.
7324
7325 * syntax.c: Include sys/types.h before including regex.h, as
7326 required by POSIX.
7327
7328 * doc.c (get_doc_string): Improve the format passed to `error'.
7329
7330 * doprnt.c (doprnt): Improve commentary.
7331
7332 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7333
7334 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7335 them with etags.
7336
7337 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7338 changes in globals.h immediately force recompilation.
7339 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7340 $(CURDIR)/s/ms-w32.h.
7341 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7342
7343 * character.c (Fchar_direction): Function deleted.
7344 (syms_of_character): Don't defsubr it.
7345 <char-direction-table>: Deleted.
7346
7347 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7348
7349 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7350 * doprnt.c: Include limits.h.
7351 (SIZE_MAX): New macro.
7352 (doprnt): Return a size_t value. 2nd arg is now size_t.
7353 Many local variables are now size_t instead of int or unsigned.
7354 Improve overflow protection. Support `l' modifier for integer
7355 conversions. Support %l conversion. Don't assume an EMACS_INT
7356 argument for integer conversions and for %c.
7357
7358 * lisp.h (doprnt): Restore prototype.
7359
7360 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7361 $(SRC)/character.h.
7362
7363 * Makefile.in (base_obj): Add back doprnt.o.
7364
7365 * deps.mk (doprnt.o): Add back prerequisites.
7366 (callint.o): Depend on character.h.
7367
7368 * eval.c (internal_lisp_condition_case): Include the handler
7369 representation in the error message.
7370 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7371 when breaking from the loop.
7372
7373 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7374
7375 * callint.c (Fcall_interactively): When displaying error message
7376 about invalid control letter, pass the character's codepoint, not
7377 a pointer to its multibyte form. Improve display of the character
7378 in octal and display also its hex code.
7379
7380 * character.c (char_string): Use %x to display the (unsigned)
7381 codepoint of an invalid character, to avoid displaying a bogus
7382 negative value.
7383
7384 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7385 `error', not SYMBOL_NAME itself.
7386
7387 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7388 character arguments to `error'.
7389
7390 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7391 to `error' in error message about FINAL_CHAR argument. Make sure
7392 FINAL_CHAR is a character, and use %c when it is passed as
7393 argument to `error'.
7394
7395 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7396
7397 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7398
7399 * w32.c: Include <time.h>.
7400 (sys_localtime): New function.
7401
7402 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7403
7404 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7405
7406 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7407
7408 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7409
7410 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7411 zombies (Bug#8467).
7412
7413 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7414
7415 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7416 gl_state.e_property when gl_state.object is Qt.
7417
7418 * insdel.c (make_gap_larger): Remove limitation of buffer size
7419 to <= INT_MAX.
7420
7421 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7422
7423 * xdisp.c (lookup_glyphless_char_display)
7424 (produce_glyphless_glyph): Handle cons cell entry in
7425 glyphless-char-display.
7426 (Vglyphless_char_display): Document it.
7427
7428 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7429 glyphless-char-display.
7430
7431 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7432
7433 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7434
7435 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7436
7437 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7438 definition for no-X builds.
7439
7440 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7441
7442 Static checks with GCC 4.6.0 and non-default toolkits.
7443
7444 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7445
7446 * process.c (keyboard_bit_set): Define only if SIGIO.
7447 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7448 (send_process): Repair possible setjmp clobbering.
7449
7450 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7451
7452 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7453
7454 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7455
7456 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7457 Define only if needed.
7458
7459 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7460 by pacifying GCC about it. Maybe it's time to retire it?
7461 * xfaces.c (USG, __TIMEVAL__): Likewise.
7462
7463 * dispextern.h (struct redisplay_interface): Rename param
7464 to avoid shadowing.
7465 * termhooks.h (struct terminal): Likewise.
7466 * xterm.c (xembed_send_message): Likewise.
7467
7468 * insdel.c (make_gap_smaller): Define only if
7469 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7470
7471 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7472 it.
7473
7474 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7475 so that we aren't warned about unused symbols.
7476
7477 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7478
7479 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7480
7481 * xfns.c (x_real_positions): Mark locals as initialized.
7482
7483 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7484
7485 * xterm.c: Fix problems found by static analysis with other toolkits.
7486 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7487 (x_dispatch_event): Declare static if USE_GTK, and
7488 define if USE_GTK || USE_X_TOOLKIT.
7489 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7490 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7491 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7492 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7493
7494 * xmenu.c (menu_help_callback): Pointer type fixes.
7495 Use const pointers when pointing at readonly data. Avoid pointer
7496 signedness clashes.
7497 (FALSE): Remove unused macro.
7498 (update_frame_menubar): Remove unused decl.
7499
7500 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7501
7502 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7503 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7504 (single_menu_item): Rename local to avoid shadowing.
7505
7506 * keyboard.c (make_lispy_event): Remove unused local var.
7507
7508 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7509 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7510
7511 * bitmaps: Change bitmaps from unsigned char back to the X11
7512 compatible char. Avoid the old compiler warnings about
7513 out-of-range initializers by using, for example, '\xab' rather
7514 than 0xab.
7515
7516 * xgselect.c (xgselect_initialize): Check vs interface
7517 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7518
7519 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7520
7521 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7522 to read-only memory.
7523
7524 * fns.c (vector): Remove; this old hack is no longer needed.
7525
7526 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7527 Remove unused var.
7528 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7529
7530 * xrdb.c (x_load_resources): Omit unused local.
7531
7532 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7533 (x_window): Rename locals to avoid shadowing.
7534 (USG): Use the kludged USG macro, to pacify gcc.
7535
7536 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7537 (x_term_init): Remove local to avoid shadowing.
7538
7539 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7540
7541 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7542 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7543
7544 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7545
7546 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7547
7548 Fix regex.c, syntax.c and friends for buffers > 2GB.
7549 * syntax.h (struct gl_state_s): Declare character position members
7550 EMACS_INT.
7551
7552 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7553
7554 * textprop.c (verify_interval_modification, interval_of):
7555 Declare arguments EMACS_INT.
7556
7557 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7558 EMACS_INT.
7559
7560 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7561
7562 * indent.c (Fvertical_motion): Local variable it_start is now
7563 EMACS_INT.
7564
7565 * regex.c (re_match, re_match_2, re_match_2_internal)
7566 (bcmp_translate, regcomp, regexec, print_double_string)
7567 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7568 (re_compile_pattern, re_exec): Declare arguments and local
7569 variables `size_t' and `ssize_t' and return values `regoff_t', as
7570 appropriate.
7571 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7572 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7573 <compile_stack_type>: `size' and `avail' are now `size_t'.
7574
7575 * regex.h <regoff_t>: Use ssize_t, not int.
7576 (re_search, re_search_2, re_match, re_match_2): Arguments that
7577 specify buffer/string position and length are now ssize_t and
7578 size_t. Return type is regoff_t.
7579
7580 2011-04-16 Ben Key <bkey76@gmail.com>
7581
7582 * nsfont.m: Fixed bugs in ns_get_family and
7583 ns_descriptor_to_entity that were caused by using free to
7584 deallocate memory blocks that were allocated by xmalloc (via
7585 xstrdup). This caused Emacs to crash when compiled with
7586 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7587 --enable-checking=xmallocoverrun). xfree is now used to
7588 deallocate these memory blocks.
7589
7590 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7591
7592 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7593
7594 emacs_write: Accept and return EMACS_INT for sizes.
7595 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7596 et seq.
7597 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7598 Accept and return EMACS_INT.
7599 (emacs_gnutls_write): Return the number of bytes written on
7600 partial writes.
7601 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7602 (emacs_read, emacs_write): Remove check for negative size, as the
7603 Emacs source code has been audited now.
7604 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7605 (emacs_read, emacs_write): Use it.
7606 * process.c (send_process): Adjust to the new signatures of
7607 emacs_write and emacs_gnutls_write. Do not attempt to store
7608 a byte offset into an 'int'; it might overflow.
7609 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7610
7611 * sound.c: Don't assume sizes fit in 'int'.
7612 (struct sound_device.period_size, alsa_period_size):
7613 Return EMACS_INT, not int.
7614 (struct sound_device.write, vox_write, alsa_write):
7615 Accept EMACS_INT, not int.
7616 (wav_play, au_play): Use EMACS_INT to store sizes and to
7617 record read return values.
7618
7619 2011-04-15 Ben Key <bkey76@gmail.com>
7620
7621 * keyboard.c (Qundefined): Don't declare static since it is used
7622 in nsfns.m.
7623 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7624 static since they are used in nsfont.m.
7625
7626 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7627
7628 * process.c (Qprocessp): Don't declare static.
7629 * lisp.h (Qprocessp): Declare again.
7630
7631 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7632
7633 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7634
7635 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7636
7637 Improve C-level modularity by making more things 'static'.
7638
7639 Don't publish debugger-only interfaces to other modules.
7640 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7641 (verify_bytepos, count_markers): Move decls to the only modules
7642 that need them.
7643 * region-cache.h (pp_cache): Likewise.
7644 * window.h (check_all_windows): Likewise.
7645 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7646
7647 * sysdep.c (croak): Now static, if
7648 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7649 * syssignal.h (croak): Declare only if not static.
7650
7651 * alloc.c (refill_memory_reserve): Now static if
7652 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7653 * lisp.h (refill_memory_reserve): Declare only if not static.
7654
7655 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7656 Define only if USE_LUCID.
7657
7658 * xrdb.c (x_customization_string, x_rm_string): Now static.
7659
7660 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7661 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7662
7663 * xdisp.c (draw_row_with_mouse_face): Now static.
7664 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7665
7666 * window.h (check_all_windows): Mark externally visible.
7667
7668 * window.c (window_deletion_count): Now static.
7669
7670 * undo.c: Make symbols static if they're not exported.
7671 (last_undo_buffer, last_boundary_position, pending_boundary):
7672 Now static.
7673
7674 * textprop.c (interval_insert_behind_hooks): Now static.
7675 (interval_insert_in_front_hooks): Likewise.
7676
7677 * term.c: Make symbols static if they're not exported.
7678 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7679 (max_frame_lines, tty_set_terminal_modes):
7680 (tty_reset_terminal_modes, tty_turn_off_highlight):
7681 (get_tty_terminal): Now static.
7682 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7683 * termhooks.h (term_mouse_moveto): Do not declare if
7684 HAVE_WINDOW_SYSTEM.
7685 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7686 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7687
7688 * sysdep.c: Make symbols static if they're not exported.
7689 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7690 Now static.
7691 (sigprocmask_set, full_mask): Remove; unused.
7692 (wait_debugging): Mark as visible.
7693 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7694 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7695
7696 * syntax.c (syntax_temp): Define only if !__GNUC__.
7697
7698 * sound.c (current_sound_device, current_sound): Now static.
7699
7700 * search.c (searchbufs, searchbuf_head): Now static.
7701
7702 * scroll.c (scroll_cost): Remove; unused.
7703 * dispextern.h (scroll_cost): Remove decl.
7704
7705 * region-cache.h (pp_cache): Mark as externally visible.
7706
7707 * process.c: Make symbols static if they're not exported.
7708 (process_tick, update_tick, create_process, chan_process):
7709 (Vprocess_alist, proc_buffered_char, datagram_access):
7710 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7711 (deactivate_process): Mark defn as static, as well as decl.
7712 * lisp.h (create_process): Remove decl.
7713 * process.h (chan_process, Vprocess_alist): Remove decls.
7714
7715 * print.c: Make symbols static if they're not exported.
7716 (print_depth, new_backquote_output, being_printed, print_buffer):
7717 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7718 (print_interval, print_number_index, initial_stderr_stream):
7719 Now static.
7720 * lisp.h (Fprinc): Remove decl.
7721 (debug_output_compilation_hack): Mark as externally visible.
7722
7723 * sysdep.c (croak): Move decl from here to syssignal.h.
7724 * syssignal.h (croak): Put it here, so the API can be checked when
7725 'croak' is called from dissociate_if_controlling_tty.
7726
7727 * minibuf.c: Make symbols static if they're not exported.
7728 (minibuf_save_list, choose_minibuf_frame): Now static.
7729 * lisp.h (choose_minibuf_frame): Remove decl.
7730
7731 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7732
7733 * lread.c: Make symbols static if they're not exported.
7734 (read_objects, initial_obarray, oblookup_last_bucket_number):
7735 Now static.
7736 (make_symbol): Remove; unused.
7737 * lisp.h (initial_obarray, make_symbol): Remove decls.
7738
7739 * keyboard.c: Make symbols static if they're not exported.
7740 (single_kboard, recent_keys_index, total_keys, recent_keys):
7741 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7742 (this_single_command_key_start, echoing, last_auto_save):
7743 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7744 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7745 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7746 (Vlispy_mouse_stem, double_click_count):
7747 Now static.
7748 (force_auto_save_soon): Define only if SIGDANGER.
7749 (ignore_mouse_drag_p): Now static if
7750 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7751 (print_help): Remove; unused.
7752 (stop_character, last_timer_event): Mark as externally visible.
7753 * keyboard.h (ignore_mouse_drag_p): Declare only if
7754 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7755 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7756 * lisp.h (echoing): Remove decl.
7757 (force_auto_save_soon): Declare only if SIGDANGER.
7758 * xdisp.c (redisplay_window): Simplify code, to make it more
7759 obvious that ignore_mouse_drag_p is not accessed if !defined
7760 USE_GTK && !defined HAVE_NS.
7761
7762 * intervals.c: Make symbols static if they're not exported.
7763 (merge_properties_sticky, merge_interval_right, delete_interval):
7764 Now static.
7765 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7766
7767 * insdel.c: Make symbols static if they're not exported.
7768 However, leave prepare_to_modify_buffer alone. It's never
7769 called from outside this function, but that appears to be a bug.
7770 (combine_after_change_list, combine_after_change_buffer):
7771 (adjust_after_replace, signal_before_change): Now static.
7772 (adjust_after_replace_noundo): Remove; unused.
7773 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7774 (signal_before_change): Remove decls.
7775
7776 * indent.c (val_compute_motion, val_vmotion): Now static.
7777
7778 * image.c: Make symbols static if they're not exported.
7779 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7780 if USE_GTK.
7781 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7782 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7783
7784 * fringe.c (standard_bitmaps): Now static.
7785 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7786
7787 * frame.c: Make symbols static if they're not exported.
7788 (x_report_frame_params, make_terminal_frame): Now static.
7789 (get_frame_param): Now static, unless HAVE_NS.
7790 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7791 (x_get_resource_string): Remove; not used.
7792 * frame.h (make_terminal_frame, x_report_frame_params):
7793 (x_get_resource_string); Remove decls.
7794 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7795 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7796
7797 * font.c, fontset.c: Make symbols static if they're not exported.
7798 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7799 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7800 * font.c (font_close_object): Now static.
7801 * font.h (font_close_object): Remove.
7802 * fontset.c (FONTSET_OBJLIST): Remove.
7803 (free_realized_fontset) #if-0 the body, which does nothing.
7804 (face_suitable_for_char_p): #if-0, as it's never called.
7805 * fontset.h (face_suitable_for_char_p): Remove decl.
7806 * xfaces.c (face_at_string_position):
7807 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7808 since 0 is always ASCII.
7809
7810 * fns.c (weak_hash_tables): Now static.
7811
7812 * fileio.c: Make symbols static if they're not exported.
7813 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7814 (Vwrite_region_annotation_buffers): Now static.
7815
7816 * eval.c: Make symbols static if they're not exported.
7817 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7818 * lisp.h (backtrace_list): Remove decl.
7819
7820 * emacs.c: Make symbols static if they're not exported.
7821 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7822 (fatal_error_code, fatal_error_signal_hook, standard_args):
7823 Now static.
7824 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7825 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7826 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7827 * lisp.h (fatal_error_signal_hook): Remove decl.
7828 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7829
7830 * editfns.c: Move a (normally-unused) function to its only use.
7831 * editfns.c, lisp.h (get_operating_system_release): Remove.
7832 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7833 worth the hassle of breaking this out.
7834
7835 * xterm.c: Make symbols static if they're not exported.
7836 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7837 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7838 (x_destroy_window, x_delete_display):
7839 Now static.
7840 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7841 (x_mouse_leave): Remove; unused.
7842 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7843 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7844 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7845 Remove decls.
7846 (x_mouse_leave): Declare only if WINDOWSNT.
7847 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7848 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7849 USE_X_TOOLKIT.
7850
7851 * ftxfont.c: Make symbols static if they're not exported.
7852 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7853 HAVE_FREETYPE.
7854 * font.h (ftxfont_driver): Likewise.
7855
7856 * xfns.c: Make symbols static if they're not exported.
7857 (x_last_font_name, x_display_info_for_name):
7858 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7859 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7860 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7861 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7862 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7863 (last_show_tip_args): Now static.
7864 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7865 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7866 (x_screen_planes): Remove; unused.
7867 * dispextern.h (x_screen_planes): Remove decl.
7868
7869 * dispnew.c: Make symbols static if they're not exported.
7870 * dispextern.h (redraw_garbaged_frames, scrolling):
7871 (increment_row_positions): Remove.
7872 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7873 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7874 Now static.
7875 (redraw_garbaged_frames): Remove; unused.
7876
7877 * xfaces.c: Make symbols static if they're not exported.
7878 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7879 Remove decls.
7880 * xterm.h (defined_color): Remove decls.
7881 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7882 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7883 (menu_face_changed_default, defined_color, free_realized_face):
7884 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7885 (ascii_face_of_lisp_face): Remove; unused.
7886
7887 * xdisp.c: Make symbols static if they're not exported.
7888 * dispextern.h (scratch_glyph_row, window_box_edges):
7889 (glyph_to_pixel_coords, set_cursor_from_row):
7890 (get_next_display_element, set_iterator_to_next):
7891 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7892 (show_mouse_face): Remove decls
7893 * frame.h (message_buf_print): Likewise.
7894 * lisp.h (pop_message, set_message, check_point_in_composition):
7895 Likewise.
7896 * xterm.h (set_vertical_scroll_bar): Likewise.
7897 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7898 (message_buf_print, scratch_glyph_row, displayed_buffer):
7899 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7900 (get_next_display_element, show_mouse_face, window_box_edges):
7901 (frame_to_window_pixel_xy, check_point_in_composition):
7902 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7903 (glyph_to_pixel_coords): Remove; unused.
7904
7905 * dired.c (file_name_completion): Now static.
7906
7907 * dbusbind.c (xd_in_read_queued_messages): Now static.
7908
7909 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7910 * data.c (circular_list_error): Remove.
7911
7912 * commands.h (last_point_position, last_point_position_buffer):
7913 (last_point_position_window): Remove decls.
7914 * keyboard.c: Make these variables static.
7915
7916 * coding.h (coding, code_convert_region, encode_coding_gap):
7917 Remove decls.
7918 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7919 (iso_code_class, detect_coding, code_convert_region): Now static.
7920 (encode_coding_gap): Remove; unused.
7921
7922 * chartab.c (chartab_chars, chartab_bits): Now static.
7923
7924 * charset.h (charset_iso_8859_1): Remove decl.
7925 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7926 Now static.
7927
7928 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7929 * ccl.c (Vccl_program_table): Now static.
7930 (check_ccl_update): Remove; unused.
7931
7932 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7933 * category.h: ... from here.
7934 * category.c (check_category_table, set_category_set): Now static.
7935
7936 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7937 * lisp.h: Remove these decls.
7938
7939 * buffer.c (buffer_count): Remove unused var.
7940
7941 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7942 so that it's not optimized away.
7943 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7944 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7945 exported only to the debugger.
7946
7947 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7948 * atimer.h (run_all_atimers): Remove; not exported.
7949
7950 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7951 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7952 was inaccessible from Lisp.
7953 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7954 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7955
7956 alloc.c: Import and export fewer symbols, and remove unused items.
7957 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7958 is defined.
7959 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7960 it's not optimized away by whole-program optimization.
7961 (message_enable_multibyte, free_misc): Remove.
7962 (catchlist, handlerlist, mark_backtrace):
7963 Declare only if BYTE_MARK_STACK.
7964 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7965 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7966 (message_enable_multibyte): Remove decl.
7967 (free_misc, interval_free_list, float_block, float_block_index):
7968 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7969 (cons_free_list, last_marked_index):
7970 Now static.
7971 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7972 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7973 (mark_backtrace): Define only if BYTE_MARK_STACK.
7974 * xdisp.c (message_enable_multibyte): Now static.
7975
7976 Declare Lisp_Object Q* variables to be 'static' if not exported.
7977 This makes it easier for human readers (and static analyzers)
7978 to see whether these variables are used from other modules.
7979 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7980 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7981 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7982 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7983 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7984 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7985 * xmenu.c, xselect.c:
7986 Declare Q* vars static if they are not used in other modules.
7987 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7988 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7989 Remove decls of unexported vars.
7990 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7991
7992 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7993
7994 Make Emacs functions such as Fatom 'static' by default.
7995 This makes it easier for human readers (and static analyzers)
7996 to see whether these functions can be called from other modules.
7997 DEFUN now defines a static function. To make the function external
7998 so that it can be used in other C modules, use the new macro DEFUE.
7999 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8000 (Finit_image_library):
8001 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8002 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8003 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8004 Remove decls, since these functions are now static.
8005 (Funintern, Fget_internal_run_time): New decls, since these functions
8006 were already external.
8007
8008 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8009 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8010 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8011 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8012 * keyboard.c, keymap.c, lread.c:
8013 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8014 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8015 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8016 Mark functions with DEFUE instead of DEFUN,
8017 if they are used in other modules.
8018 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8019 decls for now-static functions.
8020 * buffer.h (Fdelete_overlay): Remove decl.
8021 * callproc.c (Fgetenv_internal): Mark as internal.
8022 * composite.c (Fremove_list_of_text_properties): Remove decl.
8023 (Fcomposition_get_gstring): New forward static decl.
8024 * composite.h (Fcomposite_get_gstring): Remove decl.
8025 * dired.c (Ffile_attributes): New forward static decl.
8026 * doc.c (Fdocumntation_property): New forward static decl.
8027 * eval.c (Ffetch_bytecode): New forward static decl.
8028 (Funintern): Remove extern decl; now in .h file where it belongs.
8029 * fileio.c (Fmake_symbolic_link): New forward static decl.
8030 * image.c (Finit_image_library): New forward static decl.
8031 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8032 * intervals.h (Fprevious_property_change):
8033 (Fremove_list_of_text_properties): Remove decls.
8034 * keyboard.c (Fthis_command_keys): Remove decl.
8035 (Fcommand_execute): New forward static decl.
8036 * keymap.c (Flookup_key): New forward static decl.
8037 (Fcopy_keymap): Now static.
8038 * keymap.h (Flookup_key): Remove decl.
8039 * process.c (Fget_process): New forward static decl.
8040 (Fprocess_datagram_address): Mark as internal.
8041 * syntax.c (Fsyntax_table_p): New forward static decl.
8042 (skip_chars): Remove duplicate decl.
8043 * textprop.c (Fprevious_property_change): New forward static decl.
8044 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8045 Now internal.
8046 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8047 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8048
8049 * editfns.c (Fformat): Remove unreachable code.
8050
8051 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8052
8053 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8054 change. (Bug#8496)
8055
8056 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8057
8058 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8059 when at ZV. (Bug#8487)
8060
8061 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8062
8063 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8064 (Bug#8437)
8065 * keyboard.c (parse_tool_bar_item): Likewise.
8066 * sound.c (sound_cleanup, alsa_close): Likewise.
8067 * termcap.c (tgetent): Likewise.
8068 * xfns.c (x_default_font_parameter): Likewise.
8069 * xsettings.c (read_and_apply_settings): Likewise.
8070
8071 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8072 (overrun_check_free): Protoize.
8073
8074 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8075
8076 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8077 since callers should never pass a negative size.
8078 Change the signature to match that of plain 'read' and 'write'; see
8079 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8080 * lisp.h: Update prototypes of emacs_write and emacs_read.
8081
8082 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8083
8084 * xdisp.c (redisplay_window): Don't try to determine the character
8085 position of the scroll margin if the window start point w->startp
8086 is outside the buffer's accessible region. (Bug#8468)
8087
8088 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8089
8090 Fix write-region and its subroutines for buffers > 2GB.
8091 * fileio.c (a_write, e_write): Modify declaration of arguments and
8092 local variables to support buffers larger than 2GB.
8093 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8094
8095 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8096 argument, local variables, and return value.
8097
8098 * lisp.h: Update prototypes of emacs_write and emacs_read.
8099
8100 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8101
8102 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8103
8104 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8105
8106 Fix more problems found by GCC 4.6.0's static checks.
8107
8108 * xdisp.c (vmessage): Use a better test for character truncation.
8109
8110 * charset.c (load_charset_map): <, not <=, for optimization,
8111 and to avoid potential problems with integer overflow.
8112 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8113 * casetab.c (set_identity, shuffle): Likewise.
8114 * editfns.c (Fformat): Likewise.
8115 * syntax.c (skip_chars): Likewise.
8116
8117 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8118 This also lets GCC 4.6.0 generate slightly better loop code.
8119
8120 * callint.c (Fcall_interactively): <, not <=, for optimization.
8121 (Fcall_interactively): Count the number of arguments produced,
8122 not the number of arguments given. This is simpler and lets GCC
8123 4.6.0 generate slightly better code.
8124
8125 * ftfont.c: Distingish more carefully between FcChar8 and char.
8126 The previous code passed unsigned char * to a functions like
8127 strlen and xstrcasecmp that expect char *, which does not
8128 conform to the C standard.
8129 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8130 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8131 char * when the C standard requires it.
8132
8133 * keyboard.c (read_char): Remove unused var.
8134
8135 * eval.c: Port to Windows vsnprintf (Bug#8435).
8136 Include <limits.h>.
8137 (SIZE_MAX): Define if the headers do not.
8138 (verror): Do not give up if vsnprintf returns a negative count.
8139 Instead, grow the buffer. This ports to Windows vsnprintf, which
8140 does not conform to C99. Problem reported by Eli Zaretskii.
8141 Also, simplify the allocation scheme, by avoiding the need for
8142 calling realloc, and removing the ALLOCATED variable.
8143
8144 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8145
8146 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8147 But keep the doprint source code for now, as we might revamp it
8148 and use it again (Bug#8435).
8149 * lisp.h (doprnt): Remove.
8150 * Makefile.in (base_obj): Remove doprnt.o.
8151 * deps.mk (doprnt.o): Remove.
8152
8153 error: Print 32- and 64-bit integers portably (Bug#8435).
8154 Without this change, on typical 64-bit hosts error ("...%d...", N)
8155 was used to print both 32- and 64-bit integers N, which relied on
8156 undefined behavior.
8157 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8158 * lisp.h (error, verror): Mark as printf-like functions.
8159 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8160 Report overflow in size calculations when allocating printf buffer.
8161 Do not truncate output string at its first null byte.
8162 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8163 Truncate the output at a character boundary, since vsnprintf does not
8164 do that.
8165 * charset.c (check_iso_charset_parameter): Convert internal
8166 character to string before calling 'error', since %c now has the
8167 printf meaning.
8168 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8169 overflow when computing char to be passed to 'error'. Do not
8170 pass Lisp_Object to 'error'; pass the integer instead.
8171 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8172 formatted with plain %d.
8173
8174 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8175
8176 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8177
8178 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8179
8180 * xterm.c (x_catch_errors): Remove duplicate declaration.
8181
8182 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8183
8184 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8185
8186 2011-04-10 Jim Meyering <meyering@redhat.com>
8187
8188 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8189 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8190 return ssize_t not "int", and use size_t as the buffer length.
8191 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8192 * gnutls.h: Update declarations.
8193 * process.c (read_process_output): Use ssize_t, to match.
8194 (send_process): Likewise.
8195
8196 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8197
8198 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8199
8200 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8201
8202 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8203 Use unsigned char, to match FcChar8 type definition.
8204
8205 * xterm.c (handle_one_xevent):
8206 * xmenu.c (create_and_show_popup_menu):
8207 * xselect.c (x_decline_selection_request)
8208 (x_reply_selection_request): Avoid type-punned deref of X events.
8209
8210 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8211
8212 Fix some uses of `int' instead of EMACS_INT.
8213 * search.c (string_match_1, fast_string_match)
8214 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8215 (scan_buffer, find_next_newline_no_quit)
8216 (find_before_next_newline, search_command, Freplace_match)
8217 (Fmatch_data): Make some `int' variables be EMACS_INT.
8218
8219 * xdisp.c (display_count_lines): 3rd argument and return value now
8220 EMACS_INT. All callers changed.
8221 (pint2hrstr): Last argument is now EMACS_INT.
8222
8223 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8224 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8225 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8226 (decode_coding_utf_16, decode_coding_emacs_mule)
8227 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8228 (decode_coding_ccl, decode_coding_charset)
8229 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8230 (decode_coding_iso_2022, decode_coding_emacs_mule)
8231 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8232 <char_offset, last_offset>: Declare EMACS_INT.
8233 (encode_coding_utf_8, encode_coding_utf_16)
8234 (encode_coding_emacs_mule, encode_invocation_designation)
8235 (encode_designation_at_bol, encode_coding_iso_2022)
8236 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8237 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8238 Declare EMACS_INT.
8239 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8240 (encode_invocation_designation): Last argument P_NCHARS is now
8241 EMACS_INT.
8242 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8243 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8244
8245 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8246 All users changed.
8247
8248 * ccl.c (Fccl_execute_on_string): Declare some variables
8249 EMACS_INT.
8250
8251 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8252
8253 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8254
8255 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8256
8257 * process.c (Fformat_network_address): Doc fix.
8258
8259 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8260
8261 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8262
8263 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8264
8265 * keyboard.c (read_char): Call Lisp function help-form-show,
8266 instead of using internal_with_output_to_temp_buffer.
8267 (Qhelp_form_show): New var.
8268 (syms_of_keyboard): Use DEFSYM macro.
8269
8270 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8271
8272 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8273
8274 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8275
8276 * process.c (Flist_processes): Remove to Lisp.
8277 (list_processes_1): Delete.
8278
8279 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8280
8281 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8282
8283 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8284
8285 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8286
8287 Fix more problems found by GCC 4.6.0's static checks.
8288
8289 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8290
8291 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8292
8293 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8294
8295 * xdisp.c (vmessage): Mark as a printf-like function.
8296
8297 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8298
8299 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8300
8301 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8302 printf-like functions.
8303 (tiff_load): Add casts to remove these marks before passing them
8304 to system-supplied API.
8305
8306 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8307
8308 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8309 This avoids several warnings with gcc -Wstrict-overflow.
8310 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8311 directly, rather than having caller test rule sign. This avoids
8312 some unnecessary tests.
8313 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8314 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8315 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8316
8317 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8318 (xfont_open): Avoid unnecessary tests.
8319
8320 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8321
8322 * composite.h, composite.c (composition_gstring_put_cache):
8323 Use EMACS_INT, not int, for length.
8324
8325 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8326 breaking out part of COMPOSITION_DECODE_RULE.
8327 (COMPOSITION_DECODE_RULE): Use it.
8328 * composite.c (get_composition_id): Remove unused local vars,
8329 by using the new macro.
8330
8331 * textprop.c (set_text_properties_1): Change while to do-while,
8332 since the condition is always true at first.
8333
8334 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8335 (interval_deletion_adjustment): Return unsigned value.
8336 All uses changed.
8337
8338 * process.c (list_processes_1, create_pty, read_process_output):
8339 (exec_sentinel): Remove vars that were set but not used.
8340 (create_pty): Remove unnecessary "volatile"s.
8341 (Fnetwork_interface_info): Avoid possibility of int overflow.
8342 (read_process_output): Do adaptive read buffering even if carryover.
8343 (read_process_output): Simplify nbytes computation if buffered.
8344
8345 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8346
8347 * syntax.c (scan_words): Remove var that was set but not used.
8348 (update_syntax_table): Use unsigned instead of int.
8349
8350 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8351 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8352 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8353
8354 * print.c (print_error_message): Avoid int overflow.
8355
8356 * font.c (font_list_entities): Redo for clarity,
8357 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8358
8359 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8360 (font_score): Avoid potential overflow in diff calculation.
8361
8362 * fns.c (substring_both): Remove var that is set but not used.
8363 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8364
8365 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8366
8367 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8368 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8369 can always succeed if overflow has undefined behavior.
8370
8371 * search.c (boyer_moore, wordify): Remove vars set but not used.
8372 (wordify): Omit three unnecessary tests.
8373
8374 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8375 All callers changed. This avoids the need for an unused var.
8376
8377 * casefiddle.c (casify_region): Remove var that is set but not used.
8378
8379 * dired.c (file_name_completion): Remove var that is set but not used.
8380
8381 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8382
8383 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8384 (Finsert_file_contents): Remove unnecessary code checking fd.
8385
8386 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8387 Check for integer overflow on size calculations.
8388
8389 * buffer.c (Fprevious_overlay_change): Remove var that is set
8390 but not used.
8391
8392 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8393 Remove vars that are set but not used.
8394 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8395 (timer_check_2): Mark vars as initialized.
8396
8397 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8398
8399 * image.c (lookup_image): Remove var that is set but not used.
8400 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8401
8402 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8403 that are set but not used.
8404
8405 * xfns.c (make_invisible_cursor): Don't return garbage
8406 if XCreateBitmapFromData fails (Bug#8410).
8407
8408 * xselect.c (x_get_local_selection, x_handle_property_notify):
8409 Remove vars that are set but not used.
8410
8411 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8412 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8413
8414 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8415 Remove var that is set but not used.
8416 (scroll_bar_windows_size): Now size_t, not int.
8417 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8418 Check for overflow.
8419
8420 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8421 (map_tty_color) [!defined MSDOS]: Likewise.
8422
8423 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8424
8425 * coding.c: Remove vars that are set but not used.
8426 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8427 All callers changed.
8428 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8429 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8430 (decode_coding_charset): Remove vars that are set but not used.
8431
8432 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8433 that is set but not used.
8434
8435 * print.c (print_object): Remove var that is set but not used.
8436
8437 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8438 The gnulib version avoids calling malloc in the usual case,
8439 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8440 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8441 * filelock.c (current_lock_owner): Likewise.
8442 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8443 * sysdep.c: Include allocator.h, careadlinkat.h.
8444 (emacs_no_realloc_allocator): New static constant.
8445 (emacs_readlink): New function.
8446 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8447 ../lib/careadlinkat.h.
8448
8449 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8450
8451 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8452 first non-nil return value).
8453
8454 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8455
8456 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8457 if not defined (Bug#8403).
8458
8459 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8460
8461 * xdisp.c (display_count_lines): Remove parameter `start',
8462 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8463 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8464 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8465 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8466 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8467 and thereabouts. All callers changed.
8468 (get_per_char_metric): Remove parameter `f', unused since
8469 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8470
8471 2011-04-02 Jim Meyering <meyering@redhat.com>
8472
8473 do not dereference NULL upon failed strdup
8474 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8475 (ns_get_family): Likewise.
8476
8477 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8478
8479 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8480
8481 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8482
8483 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8484 later (Bug#8403).
8485
8486 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8487
8488 Add lexical binding.
8489
8490 * window.c (Ftemp_output_buffer_show): New fun.
8491 (Fsave_window_excursion):
8492 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8493
8494 * lread.c (lisp_file_lexically_bound_p): New function.
8495 (Fload): Bind Qlexical_binding.
8496 (readevalloop): Remove `evalfun' arg.
8497 Bind Qinternal_interpreter_environment.
8498 (Feval_buffer): Bind Qlexical_binding.
8499 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8500 Mark as dynamic.
8501 (syms_of_lread): Declare `lexical-binding'.
8502
8503 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8504
8505 * keyboard.c (eval_dyn): New fun.
8506 (menu_item_eval_property): Use it.
8507
8508 * image.c (parse_image_spec): Use Ffunctionp.
8509
8510 * fns.c (concat, mapcar1): Accept byte-code-functions.
8511
8512 * eval.c (Fsetq): Handle lexical vars.
8513 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8514 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8515 (FletX, Flet): Obey lexical binding.
8516 (Fcommandp): Handle closures.
8517 (Feval): New `lexical' arg.
8518 (eval_sub): New function extracted from Feval. Use it almost
8519 everywhere where Feval was used. Look up vars in lexical env.
8520 Handle closures.
8521 (Ffunctionp): Move from subr.el.
8522 (Ffuncall): Handle closures.
8523 (apply_lambda): Remove `eval_flags'.
8524 (funcall_lambda): Handle closures and new byte-code-functions.
8525 (Fspecial_variable_p): New function.
8526 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8527 but without exporting it to Lisp.
8528
8529 * doc.c (Fdocumentation, store_function_docstring):
8530 * data.c (Finteractive_form): Handle closures.
8531
8532 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8533 interactive spec.
8534
8535 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8536 New byte-codes.
8537 (exec_byte_code): New function extracted from Fbyte_code to handle new
8538 calling convention for byte-code-functions. Add new byte-codes.
8539
8540 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8541
8542 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8543
8544 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8545
8546 * xdisp.c (redisplay_internal): Fix prototype.
8547
8548 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8549
8550 * xdisp.c (SCROLL_LIMIT): New macro.
8551 (try_scrolling): Use it when setting scroll_limit.
8552 Limit scrolling to 100 screen lines.
8553 (redisplay_window): Even when falling back on "recentering",
8554 position point in the window according to scroll-conservatively,
8555 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8556
8557 (try_scrolling): When point is above the window, allow searching
8558 as far as scroll_max, or one screenful, to compute vertical
8559 distance from PT to the scroll margin position. This prevents
8560 try_scrolling from unnecessarily failing when
8561 scroll-conservatively is set to a value slightly larger than the
8562 window height. Clean up the case of PT below the margin at bottom
8563 of window: scroll_max can no longer be INT_MAX. When aggressive
8564 scrolling is in use, don't let point enter the opposite scroll
8565 margin as result of the scroll.
8566 (syms_of_xdisp) <scroll-conservatively>: Document the
8567 threshold of 100 lines for never-recentering scrolling.
8568
8569 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8570
8571 * dispextern.h (move_it_by_lines):
8572 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8573 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8574 (message_log_check_duplicate): Remove parameters `prev_bol' and
8575 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8576 (redisplay_internal): Remove parameter `preserve_echo_area',
8577 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8578
8579 * indent.c (Fvertical_motion):
8580 * window.c (window_scroll_pixel_based, Frecenter):
8581 Don't pass `need_y_p' to `move_it_by_lines'.
8582
8583 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8584
8585 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8586 steal a few bits to be more compact.
8587 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8588 Remove unneeded casts.
8589
8590 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8591
8592 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8593
8594 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8595 binding" message (bug#7967).
8596
8597 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8598
8599 Fix more problems found by GCC 4.6.0's static checks.
8600
8601 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8602 Remove unused local var.
8603
8604 * editfns.c (Fmessage_box): Remove unused local var.
8605
8606 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8607 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8608 Omit unused local vars.
8609 * window.c (shrink_windows): Omit unused local var.
8610 * menu.c (digest_single_submenu): Omit unused local var.
8611 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8612 Omit unused local var.
8613
8614 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8615 Don't assume string length fits in int.
8616 (keyremap_step, read_key_sequence): Use size_t for sizes.
8617 (read_key_sequence): Don't check last_real_key_start redundantly.
8618
8619 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8620 instead of alloca (Bug#8344).
8621
8622 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8623 (Fbacktrace_frame): Don't assume nframes fits in int.
8624
8625 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8626
8627 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8628 concerns.
8629
8630 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8631
8632 * cm.c (calccost): Turn while-do into do-while, for clarity.
8633
8634 * keyboard.c (syms_of_keyboard): Use the same style as later
8635 in this function when indexing through an array. This also
8636 works around GCC bug 48267.
8637
8638 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8639
8640 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8641
8642 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8643 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8644
8645 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8646 This avoids undefined behavior on integer overflow, and is a bit
8647 more convenient anyway since it is compared to a size_t variable.
8648
8649 Variadic C functions now count arguments with size_t, not int.
8650 This avoids an unnecessary limitation on 64-bit machines, which
8651 caused (substring ...) to crash on large vectors (Bug#8344).
8652 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8653 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8654 All variadic functions and their callers changed accordingly.
8655 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8656 * data.c (arith_driver, float_arith_driver): Likewise.
8657 * editfns.c (general_insert_function): Likewise.
8658 * eval.c (struct backtrace.nargs, interactive_p)
8659 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8660 (funcall_lambda, mark_backtrace): Likewise.
8661 * fns.c (concat): Likewise.
8662 * frame.c (x_set_frame_parameters): Likewise.
8663 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8664 0 if not found, not -1. All callers changed.
8665
8666 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8667 (stack_copy_size): Now size_t, not int.
8668 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8669
8670 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8671
8672 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8673 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8674 All callers changed.
8675
8676 * lisp.h (multibyte_char_to_unibyte):
8677 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8678 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8679 * character.h (CHAR_TO_BYTE8):
8680 * cmds.c (internal_self_insert):
8681 * editfns.c (general_insert_function):
8682 * keymap.c (push_key_description):
8683 * search.c (Freplace_match):
8684 * xdisp.c (message_dolog, set_message_1): All callers changed.
8685
8686 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8687
8688 * keyboard.c (safe_run_hook_funcall): New function.
8689 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8690 don't set the hook to nil, but remove the offending function instead.
8691 (Qcommand_hook_internal): Remove, unused.
8692 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8693 Vcommand_hook_internal.
8694
8695 * eval.c (enum run_hooks_condition): Remove.
8696 (funcall_nil, funcall_not): New functions.
8697 (run_hook_with_args): Call each function through a `funcall' argument.
8698 Remove `cond' argument, now redundant.
8699 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8700 (Frun_hook_with_args_until_failure): Adjust accordingly.
8701 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8702
8703 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8704
8705 * dispextern.h (string_buffer_position): Remove declaration.
8706
8707 * print.c (strout): Remove parameter `multibyte', unused since
8708 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8709
8710 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8711 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8712 All callers changed.
8713
8714 * w32.c (_wsa_errlist): Use braces for struct initializers.
8715
8716 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8717 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8718 All callers changed.
8719 (string_buffer_position): Likewise. Also, make static (it's never
8720 used outside xdisp.c).
8721 (cursor_row_p): Remove parameter `w', unused since
8722 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8723 (decode_mode_spec): Remove parameter `precision', introduced during
8724 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8725 All callers changed.
8726
8727 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8728
8729 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8730
8731 2011-03-27 Anders Lindgren <andlind@gmail.com>
8732
8733 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8734 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8735 (ns_update_auto_hide_menu_bar): New functions.
8736 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8737 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8738 ns_constrain_all_frames.
8739 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8740 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8741
8742 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8743
8744 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8745
8746 2011-03-27 Glenn Morris <rgm@gnu.org>
8747
8748 * syssignal.h: Replace RETSIGTYPE with void.
8749 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8750 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8751 Replace SIGTYPE with void everywhere.
8752 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8753 * s/template.h (SIGTYPE): Remove commented out definition.
8754
8755 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8756
8757 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8758 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8759
8760 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8761
8762 * w32.c (read_unc_volume): Use parameter `henum', instead of
8763 global variable `wget_enum_handle'.
8764
8765 * keymap.c (describe_vector): Remove parameters `indices' and
8766 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8767 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8768
8769 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8770
8771 * keyboard.c (timer_check): Remove parameter `do_it_now',
8772 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8773 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8774 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8775
8776 * keyboard.c (read_char):
8777 * w32menu.c (w32_menu_display_help):
8778 * xmenu.c (show_help_event, menu_help_callback):
8779 Adjust calls to `show_help_echo'.
8780
8781 * gtkutil.c (xg_maybe_add_timer):
8782 * keyboard.c (readable_events):
8783 * process.c (wait_reading_process_output):
8784 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8785
8786 * insdel.c (adjust_markers_gap_motion):
8787 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8788 (gap_left, gap_right): Don't call it.
8789
8790 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8791
8792 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8793 incurred during fontification.
8794
8795 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8796
8797 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8798 (DEFVAR_PER_BUFFER): Don't pass it.
8799
8800 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8801 (scrolling_window): Don't pass it.
8802
8803 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8804
8805 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8806
8807 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8808 and `suffix'.
8809 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8810 of variables specific to SELinux and computation of `encoded_absname'.
8811
8812 * image.c (XPutPixel): Remove unused variable `height'.
8813
8814 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8815
8816 * unexw32.c (get_section_info): Remove unused variable `section'.
8817
8818 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8819 (system_process_attributes): Remove unused variable `sess'.
8820 (sys_read): Remove unused variable `err'.
8821
8822 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8823 (w32_wnd_proc): Remove unused variable `isdead'.
8824 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8825 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8826 (x_create_tip_frame): Remove unused variable `tem'.
8827
8828 * w32inevt.c (w32_console_read_socket):
8829 Remove unused variable `no_events'.
8830
8831 * w32term.c (x_draw_composite_glyph_string_foreground):
8832 Remove unused variable `width'.
8833
8834 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8835
8836 * w32term.c (x_set_glyph_string_clipping):
8837 Don't pass uninitialized region to CombineRgn.
8838
8839 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8840
8841 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8842 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8843 (Fx_close_connection): Remove unused variable `i'.
8844
8845 * w32font.c (w32font_draw): Return number of glyphs.
8846 (w32font_open_internal): Remove unused variable `i'.
8847 (w32font_driver): Add missing initializer.
8848
8849 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8850 (fill_in_menu): Remove unused variable `items_added'.
8851
8852 * w32term.c (last_mouse_press_frame): Remove static global variable.
8853 (w32_clip_to_row): Remove unused variable `f'.
8854 (x_delete_terminal): Remove unused variable `i'.
8855
8856 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8857 (NOTHING): Remove unused static global variable.
8858 (uniscribe_check_otf): Remove unused variable `table'.
8859 (uniscribe_font_driver): Add missing initializers.
8860
8861 2011-03-23 Julien Danjou <julien@danjou.info>
8862
8863 * term.c (Fsuspend_tty, Fresume_tty):
8864 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8865 * window.c (temp_output_buffer_show):
8866 * insdel.c (signal_before_change):
8867 * frame.c (Fhandle_switch_frame):
8868 * fileio.c (Fdo_auto_save):
8869 * emacs.c (Fkill_emacs):
8870 * editfns.c (save_excursion_restore):
8871 * cmds.c (internal_self_insert):
8872 * callint.c (Fcall_interactively):
8873 * buffer.c (Fkill_all_local_variables):
8874 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8875 Use Frun_hooks.
8876 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8877 unconditionally since it does the check itself.
8878
8879 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8880
8881 Fix more problems found by GCC 4.5.2's static checks.
8882
8883 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8884 the first time through the loop, since we know p0 < p1 then.
8885 This also avoids a gcc -Wstrict-overflow warning.
8886
8887 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8888 leading to a memory leak, possible in functions like
8889 load_charset_map_from_file that can allocate an unbounded number
8890 of objects (Bug#8318).
8891
8892 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8893 that could (at least in theory) be that large.
8894
8895 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8896 This is less likely to overflow, and avoids undefined behavior if
8897 overflow does occur. All callers changed. Use strtoul to scan
8898 for the unsigned long integer.
8899 (pint2hrstr): Simplify and tune code slightly.
8900 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8901
8902 * scroll.c (do_scrolling): Work around GCC bug 48228.
8903 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8904
8905 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8906 This also avoids a warning with gcc -Wstrict-overflow.
8907 (validate_x_resource_name): Simplify count usage.
8908 This also avoids a warning with gcc -Wstrict-overflow.
8909
8910 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8911 fail (Bug#8306).
8912
8913 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8914
8915 * process.c (Fmake_network_process): Use socklen_t, not int,
8916 where POSIX says socklen_t is required in portable programs.
8917 This fixes a porting bug on hosts like 64-bit HP-UX, where
8918 socklen_t is wider than int (Bug#8277).
8919 (Fmake_network_process, server_accept_connection):
8920 (wait_reading_process_output, read_process_output):
8921 Likewise.
8922
8923 * process.c: Rename or move locals to avoid shadowing.
8924 (list_processes_1, Fmake_network_process):
8925 (read_process_output_error_handler, exec_sentinel_error_handler):
8926 Rename or move locals.
8927 (Fmake_network_process): Define label "retry_connect" only if needed.
8928 (Fnetwork_interface_info): Fix pointer signedness.
8929 (process_send_signal): Add cast to avoid pointer signedness problem.
8930 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8931 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8932
8933 Make tparam.h and terminfo.c consistent.
8934 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8935 Include tparam.h instead, since it declares them.
8936 * cm.h (PC): Remove extern decl; tparam.h now does this.
8937 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8938 * terminfo.c: Include tparam.h, to check interfaces.
8939 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8940 (tparam): Adjust signature to match interface in tparam.h;
8941 this removes some undefined behavior. Check that outstring and len
8942 are zero, which they always are with Emacs.
8943 * tparam.h (PC, BC, UP): New extern decls.
8944
8945 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8946 (xftfont_open): Rename locals to avoid shadowing.
8947
8948 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8949 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8950 (OTF_TAG_SYM): Omit macro if not needed.
8951 (ftfont_list): Remove unused local.
8952 (get_adstyle_property, ftfont_pattern_entity):
8953 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8954 Rename locals to avoid shadowing.
8955
8956 * xfont.c (xfont_list_family): Mark var as initialized.
8957
8958 * xml.c (make_dom): Now static.
8959
8960 * composite.c (composition_compute_stop_pos): Rename local to
8961 avoid shadowing.
8962 (composition_reseat_it): Remove unused locals.
8963 (find_automatic_composition, composition_adjust_point): Likewise.
8964 (composition_update_it): Mark var as initialized.
8965 (find_automatic_composition): Mark vars as initialized,
8966 with a FIXME (Bug#8290).
8967
8968 character.h: Rename locals to avoid shadowing.
8969 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8970 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8971 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8972 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8973 to avoid shadowing.
8974
8975 * textprop.c (property_change_between_p): Remove; unused.
8976
8977 * intervals.c (interval_start_pos): Now static.
8978
8979 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8980
8981 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8982 Rename locals to avoid shadowing.
8983
8984 * sound.c (wav_play, au_play, Fplay_sound_internal):
8985 Fix pointer signedness.
8986 (alsa_choose_format): Remove unused local var.
8987 (wav_play): Initialize a variable to 0, to prevent undefined
8988 behavior (Bug#8278).
8989
8990 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8991
8992 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8993
8994 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8995 clobbering (Bug#8298).
8996 * sysdep.c (sys_subshell): Likewise.
8997 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8998
8999 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9000 This should get cleaned up, so that child_setup has the
9001 same signature on all platforms.
9002
9003 * callproc.c (call_process_cleanup): Now static.
9004 (relocate_fd): Rename locals to avoid shadowing.
9005
9006 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9007
9008 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9009 not to be necessary, and produces flickering.
9010
9011 2011-03-20 Glenn Morris <rgm@gnu.org>
9012
9013 * config.in: Remove file.
9014
9015 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9016
9017 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9018 are now in src/globals.h.
9019 (syms_of_minibuf): Remove spurious & from previous change.
9020
9021 2011-03-20 Leo Liu <sdl.web@gmail.com>
9022
9023 * minibuf.c (completing-read-function): New variable.
9024 (completing-read-default): Rename from completing-read.
9025 (completing-read): Call completing-read-function.
9026
9027 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9028
9029 * xfaces.c (Fx_load_color_file):
9030 Read color file from absolute filename (bug#8250).
9031
9032 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9033
9034 * makefile.w32-in: Update dependencies.
9035
9036 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9037
9038 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9039
9040 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9041
9042 Fix more problems found by GCC 4.5.2's static checks.
9043
9044 * process.c (make_serial_process_unwind, send_process_trap):
9045 (sigchld_handler): Now static.
9046
9047 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9048 That way, the code declares only the vars that it needs.
9049 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9050 * s/cygwin.h (PTY_ITERATION): Likewise.
9051 * s/darwin.h (PTY_ITERATION): Likewise.
9052 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9053
9054 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9055 * process.c (allocate_pty): Don't declare stb unless it's needed.
9056
9057 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9058 (CONSTANTLIM): Remove; unused.
9059 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9060 Define only if needed.
9061
9062 * unexelf.c (unexec): Name an expression,
9063 to avoid gcc -Wbad-function-cast warning.
9064 Use a different way to cause a compilation error if anyone uses
9065 n rather than nn, a way that does not involve shadowing.
9066 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9067
9068 * deps.mk (unexalpha.o): Remove; unused.
9069
9070 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9071 * unexec.h: New file.
9072 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9073 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9074 Depend on unexec.h.
9075 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9076 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9077 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9078 Change as necessary to match prototype in unexec.h.
9079
9080 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9081 shadowing.
9082 (back_comment, skip_chars): Mark vars as initialized.
9083
9084 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9085 Rename locals to avoid shadowing.
9086
9087 * lread.c (read1): Rewrite so as not to use empty "else".
9088 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9089
9090 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9091
9092 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9093 warning when compiling print.c.
9094
9095 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9096 instead of using an uninitialized var.
9097 (font_sort_entities): Mark var as initialized.
9098
9099 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9100
9101 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9102 pointers to constants.
9103 (font_parse_fcname): Remove unused vars.
9104 (font_delete_unmatched): Now static.
9105 (font_get_spec): Remove; unused.
9106 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9107 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9108 Rename or move locals to avoid shadowing.
9109
9110 * fns.c (require_nesting_list, require_unwind): Now static.
9111 (Ffillarray): Rename locals to avoid shadowing.
9112
9113 * floatfns.c (domain_error2): Define only if needed.
9114 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9115
9116 * alloc.c (mark_backtrace): Move decl from here ...
9117 * lisp.h: ... to here, so that it can be checked.
9118
9119 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9120 (Fdefvar): Rewrite so as not to use empty "else".
9121 (lisp_indirect_variable): Name an expression,
9122 to avoid gcc -Wbad-function-cast warning.
9123 (Fdefvar): Rename locals to avoid shadowing.
9124
9125 * callint.c (quotify_arg, quotify_args): Now static.
9126 (Fcall_interactively): Rename locals to avoid shadowing.
9127 Use const pointer when appropriate.
9128
9129 * lisp.h (get_system_name, get_operating_system_release):
9130 Move decls here, to check interfaces.
9131 * process.c (get_operating_system_release): Move decl to lisp.h.
9132 * xrdb.c (get_system_name): Likewise.
9133 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9134 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9135 some of which prompt warnings from gcc -Wbad-function-cast.
9136 (Fformat_time_string, Fencode_time, Finsert_char):
9137 (Ftranslate_region_internal, Fformat):
9138 Rename or remove local vars to avoid shadowing.
9139 (Ftranslate_region_internal): Mark var as initialized.
9140
9141 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9142 avoid shadowing.
9143
9144 * lisp.h (eassert): Check that the argument compiles, even if
9145 ENABLE_CHECKING is not defined.
9146
9147 * data.c (Findirect_variable): Name an expression, to avoid
9148 gcc -Wbad-function-cast warning.
9149 (default_value, arithcompare, arith_driver, arith_error): Now static.
9150 (store_symval_forwarding): Rename local to avoid shadowing.
9151 (Fmake_variable_buffer_local, Fmake_local_variable):
9152 Mark variables as initialized.
9153 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9154
9155 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9156 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9157 Rename locals to avoid shadowing.
9158 (mark_stack): Move local variables into the #ifdef region where
9159 they're used.
9160 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9161 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9162 needed otherwise.
9163 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9164 (GC_STRING_CHARS): Remove; not used.
9165 (Fmemory_limit): Cast sbrk's returned value to char *.
9166
9167 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9168 avoids undefined behavior in theory.
9169
9170 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9171
9172 Use functions, not macros, for up- and down-casing (Bug#8254).
9173 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9174 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9175 to use the following functions instead of these macros.
9176 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9177 EMACS_INT, since callers assume the returned value fits in int.
9178 (upcase1): Likewise, for UPCASE_TABLE.
9179 (uppercasep, lowercasep, upcase): New static inline functions.
9180 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9181 the race-condition problem in the old DOWNCASE.
9182
9183 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9184 Rename locals to avoid shadowing.
9185 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9186 (regex_compile, re_search_2, re_match_2_internal):
9187 Remove unused local vars.
9188 (FREE_VAR): Rewrite so as not to use empty "else",
9189 which gcc can warn about.
9190 (regex_compile, re_match_2_internal): Mark locals as initialized.
9191 (RETALLOC_IF): Define only if needed.
9192 (WORDCHAR_P): Likewise. This one is never needed, but is used
9193 only in a comment talking about a compiler bug, so put inside
9194 the #if 0 of that comment.
9195 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9196 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9197 Remove; unused.
9198
9199 * search.c (boyer_moore): Rename locals to avoid shadowing.
9200 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9201 (PREV_CHAR_BOUNDARY): Likewise.
9202
9203 * search.c (simple_search): Remove unused var.
9204
9205 * dired.c (compile_pattern): Move decl from here ...
9206 * lisp.h: ... to here, so that it can be checked.
9207 (struct re_registers): New forward decl.
9208
9209 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9210
9211 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9212 All uses changed.
9213 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9214 Rename locals to avoid shadowing.
9215 (Fvertical_motion): Mark locals as initialized.
9216
9217 * casefiddle.c (casify_object, casify_region): Now static.
9218 (casify_region): Mark local as initialized.
9219
9220 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9221
9222 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9223 New macros, so that the caller can use some names other than
9224 gcpro1, gcpro2, etc.
9225 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9226 of the new macros.
9227 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9228 argument, for consistency with GCPRO2_VAR, etc: it is now the
9229 prefix of the variable, not the variable itself. All uses
9230 changed.
9231 * dired.c (directory_files_internal, file_name_completion):
9232 Rename locals to avoid shadowing.
9233
9234 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9235 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9236 dired.c's scmp function, had undefined behavior.
9237 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9238 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9239 * buffer.h: ... to here, because these macros use current_buffer,
9240 and the new implementation with inline functions needs to have
9241 current_buffer in scope now, rather than later when the macros
9242 are used.
9243 (downcase, upcase1): New static inline functions.
9244 (DOWNCASE, UPCASE1): Reimplement using these functions.
9245 This avoids undefined behavior in expressions like
9246 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9247 from race conditions in accessing the global variables
9248 case_temp1 and case_temp2.
9249 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9250 * lisp.h (case_temp1, case_temp2): Remove their decls.
9251 * character.h (ASCII_CHAR_P): Move from here ...
9252 * lisp.h: ... to here, so that the inline functions mentioned
9253 above can use them.
9254
9255 * dired.c (directory_files_internal_unwind): Now static.
9256
9257 * fileio.c (file_name_as_directory, directory_file_name):
9258 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9259 Now static.
9260 (file_name_as_directory): Use const pointers when appropriate.
9261 (Fexpand_file_name): Likewise. In particular, newdir might
9262 point at constant storage, so make it a const pointer.
9263 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9264 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9265 signedness issues.
9266 (Fset_file_times, Finsert_file_contents, auto_save_error):
9267 Rename locals to avoid shadowing.
9268
9269 * minibuf.c (choose_minibuf_frame_1): Now static.
9270 (Ftry_completion, Fall_completions): Rename or remove locals
9271 to avoid shadowing.
9272
9273 * marker.c (bytepos_to_charpos): Remove; unused.
9274
9275 * lisp.h (verify_bytepos, count_markers): New decls,
9276 so that gcc does not warn that these functions aren't declared.
9277
9278 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9279 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9280 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9281 (copy_text): Remove unused local var.
9282
9283 * filelock.c (within_one_second): Now static.
9284 (lock_file_1): Rename local to avoid shadowing.
9285
9286 * buffer.c (fix_overlays_before): Mark locals as initialized.
9287 (fix_start_end_in_overlays): Likewise. This function should be
9288 simplified by using pointers-to-pointers, but that's a different
9289 matter.
9290 (switch_to_buffer_1): Now static.
9291 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9292 (report_overlay_modification): Rename locals to avoid shadowing.
9293
9294 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9295 Fix pointer signedness issue.
9296 (sys_subshell): Mark local as volatile if checking for lint,
9297 to suppress a gcc -Wclobbered warning that does not seem to be right.
9298 (MAXPATHLEN): Define only if needed.
9299
9300 * process.c (serial_open, serial_configure): Move decls from here ...
9301 * systty.h: ... to here, so that they can be checked.
9302
9303 * fns.c (get_random, seed_random): Move extern decls from here ...
9304 * lisp.h: ... to here, so that they can be checked.
9305
9306 * sysdep.c (reset_io): Now static.
9307 (wait_for_termination_signal): Remove; unused.
9308
9309 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9310 (copy_keymap_item, append_key, push_text_char_description):
9311 Now static.
9312 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9313 (DENSE_TABLE_SIZE): Remove; unused.
9314 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9315 (describe_map_tree):
9316 Rename locals to avoid shadowing.
9317
9318 * keyboard.c: Declare functions static if they are not used elsewhere.
9319 (echo_char, echo_dash, cmd_error, top_level_2):
9320 (poll_for_input, handle_async_input): Now static.
9321 (read_char, kbd_buffer_get_event, make_lispy_position):
9322 (make_lispy_event, make_lispy_movement, apply_modifiers):
9323 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9324 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9325 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9326 (read_key_sequence, read_char): Mark locals as initialized.
9327 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9328
9329 * keyboard.h (make_ctrl_char): New decl.
9330 (mark_kboards): Move decl here ...
9331 * alloc.c (mark_kboards): ... from here.
9332
9333 * lisp.h (force_auto_save_soon): New decl.
9334
9335 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9336 (DEFINE_DUMMY_FUNCTION): New macro.
9337 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9338 Use it.
9339 (main): Add casts to avoid warnings
9340 if GCC considers string literals to be constants.
9341
9342 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9343
9344 * dbusbind.c: Pointer signedness fixes.
9345 (xd_signature, xd_append_arg, xd_initialize):
9346 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9347 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9348 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9349 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9350
9351 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9352 if GCC considers string literals to be constants.
9353 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9354
9355 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9356
9357 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9358 (print_preprocess, print_object): New macro to fix last change.
9359
9360 * print.c (print_preprocess): Don't forget font objects.
9361
9362 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9363
9364 * emacs.c (USAGE3): Doc fixes.
9365
9366 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9367
9368 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9369 structure.
9370
9371 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9372
9373 * lisp.h (VWindow_system, Qfile_name_history):
9374 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9375 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9376 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9377
9378 * w32select.c: Don't #include "keyboard.h".
9379 (run_protected): Add extern declaration for waiting_for_input.
9380
9381 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9382 * w32console.c (detect_input_pending, read_input_pending)
9383 (encode_terminal_code):
9384 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9385 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9386 (w32_system_caret_y, Qfile_name_history):
9387 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9388 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9389 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9390 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9391 * w32proc.c (Qlocal, report_file_error):
9392 * w32term.c (Vwindow_system, updating_frame):
9393 * w32uniscribe.c (initialized, uniscribe_font_driver):
9394 Remove unneeded extern declarations.
9395
9396 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9397
9398 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9399
9400 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9401
9402 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9403 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9404 These macros can no longer be used for assignment.
9405
9406 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9407 Assign struct members directly, instead of using BUF_BEGV etc.
9408 (record_buffer_markers, fetch_buffer_markers): New functions for
9409 recording and fetching special buffer markers.
9410 (set_buffer_internal_1, set_buffer_temp): Use them.
9411
9412 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9413
9414 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9415
9416 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9417 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9418
9419 * xdisp.c (hscroll_window_tree):
9420 (reconsider_clip_changes): Use PT instead of BUF_PT.
9421
9422 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9423
9424 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9425 $(EMACS_ROOT)/lib/intprops.h.
9426
9427 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9428
9429 Fix more problems found by GCC 4.5.2's static checks.
9430
9431 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9432 to unsigned char * to avoid compiler diagnostic.
9433 (xg_free_frame_widgets): Make it clear that a local variable is
9434 needed only if USE_GTK_TOOLTIP.
9435 (gdk_window_get_screen): Make it clear that this macro is needed
9436 only if USE_GTK_TOOLTIP.
9437 (int_gtk_range_get_value): New function, which avoids a diagnostic
9438 from gcc -Wbad-function-cast.
9439 (xg_set_toolkit_scroll_bar_thumb): Use it.
9440 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9441 diagnostic from gcc -Wbad-function-cast.
9442 (get_utf8_string, xg_get_file_with_chooser):
9443 Rename locals to avoid shadowing.
9444 (create_dialog): Move locals to avoid shadowing.
9445
9446 * xgselect.c (xg_select): Remove unused var.
9447
9448 * image.c (four_corners_best): Mark locals as initialized.
9449 (gif_load): Initialize transparent_p to zero (Bug#8238).
9450 Mark another local as initialized.
9451 (my_png_error, my_error_exit): Mark with NO_RETURN.
9452
9453 * image.c (clear_image_cache): Now static.
9454 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9455 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9456 (x_edge_detection): Remove unnecessary cast that
9457 gcc -Wbad-function-cast diagnoses.
9458 (gif_load): Fix pointer signedness.
9459 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9460 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9461
9462 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9463
9464 Improve quality of tests for time stamp overflow.
9465 For example, without this patch (encode-time 0 0 0 1 1
9466 1152921504606846976) returns the obviously-bogus value (-948597
9467 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9468 reports time overflow. See
9469 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9470 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9471 * editfns.c: Include limits.h and intprops.h.
9472 (TIME_T_MIN, TIME_T_MAX): New macros.
9473 (time_overflow): Move earlier, to before first use.
9474 (hi_time, lo_time): New functions, for an accurate test for
9475 out-of-range times.
9476 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9477 (Fget_internal_run_time): Don't assume time_t fits in int.
9478 (make_time): Use list2 instead of Fcons twice.
9479 (Fdecode_time): More accurate test for out-of-range times.
9480 (check_tm_member): New function.
9481 (Fencode_time): Use it, to test for out-of-range times.
9482 (lisp_time_argument): Don't rely on undefined left-shift and
9483 right-shift behavior when checking for time stamp overflow.
9484
9485 * editfns.c (time_overflow): New function, refactoring common code.
9486 (Fformat_time_string, Fdecode_time, Fencode_time):
9487 (Fcurrent_time_string): Use it.
9488
9489 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9490 * dired.c (make_time): Move to ...
9491 * editfns.c (make_time): ... here.
9492 * systime.h: Note the move.
9493
9494 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9495
9496 * fringe.c (update_window_fringes): Remove unused variables.
9497
9498 * unexmacosx.c (copy_data_segment): Also copy __got section.
9499 (Bug#8223)
9500
9501 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9502
9503 * termcap.c [MSDOS]: Include "msdos.h".
9504 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9505 Constify `char *' arguments and their references according to
9506 prototypes in tparam.h.
9507
9508 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9509
9510 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9511 Adapt all references accordingly.
9512
9513 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9514
9515 2011-03-11 Tom Tromey <tromey@redhat.com>
9516
9517 * buffer.c (syms_of_buffer): Remove obsolete comment.
9518
9519 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9520
9521 * termhooks.h (encode_terminal_code): Declare prototype.
9522
9523 * msdos.c (encode_terminal_code): Don't declare prototype.
9524
9525 * term.c (encode_terminal_code): Now external again, used by
9526 w32console.c and msdos.c.
9527
9528 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9529 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9530
9531 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9532
9533 Fix some minor problems found by GCC 4.5.2's static checks.
9534
9535 * fringe.c (update_window_fringes): Mark locals as initialized
9536 (Bug#8227).
9537 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9538
9539 * alloc.c (mark_fringe_data): Move decl from here ...
9540 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9541 to check its interface.
9542 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9543
9544 * fontset.c (free_realized_fontset): Now static.
9545 (Fset_fontset_font): Rename local to avoid shadowing.
9546 (fontset_font): Mark local as initialized.
9547 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9548
9549 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9550
9551 * xselect.c (x_disown_buffer_selections): Remove; not used.
9552 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9553 (x_own_selection, Fx_disown_selection_internal): Rename locals
9554 to avoid shadowing.
9555 (x_handle_dnd_message): Remove local to avoid shadowing.
9556
9557 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9558 so that the caller can use some name other than gcpro1.
9559 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9560 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9561 (Fx_backspace_delete_keys_p):
9562 Use them to avoid shadowing, and rename vars to avoid shadowing.
9563 (x_decode_color, x_set_name, x_window): Now static.
9564 (Fx_create_frame): Add braces to silence GCC warning.
9565 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9566 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9567 Remove unused locals.
9568 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9569 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9570 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9571 macros.
9572
9573 * xterm.h (x_mouse_leave): New decl.
9574
9575 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9576 Remove unused functions.
9577 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9578 (x_calc_absolute_position): Now static.
9579 (XTread_socket): Don't define label "out" unless it's used.
9580 Don't declare local "event" unless it's used.
9581 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9582 unless they are used.
9583 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9584 (x_fatal_error_signal): Remove; not used.
9585 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9586 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9587 (x_error_catcher, x_connection_closed, x_error_handler):
9588 (x_error_quitter, xembed_send_message, x_iconify_frame):
9589 (my_log_handler): Rename locals to avoid shadowing.
9590 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9591 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9592
9593 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9594 Rename or move locals to avoid shadowing.
9595 (tty_defined_color, merge_face_heights): Now static.
9596 (free_realized_faces_for_fontset): Remove; not used.
9597 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9598 does not deduce is never used uninitialized.
9599 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9600 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9601
9602 * terminal.c (store_terminal_param): Now static.
9603
9604 * xmenu.c (menu_highlight_callback): Now static.
9605 (set_frame_menubar): Remove unused local.
9606 (xmenu_show): Rename parameter to avoid shadowing.
9607 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9608 since they might point to immutable storage.
9609 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9610 since it's unused otherwise.
9611
9612 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9613 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9614 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9615 avoids a gcc -Wuninitialized diagnostic.
9616 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9617 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9618 does not deduce are never used uninitialized.
9619
9620 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9621
9622 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9623 * window.c (window_loop, size_window):
9624 (run_window_configuration_change_hook, enlarge_window): Likewise.
9625
9626 * window.c (display_buffer): Now static.
9627 (size_window): Mark variables that gcc -Wuninitialized
9628 does not deduce are never used uninitialized.
9629 * window.h (check_all_windows): New decl, to forestall
9630 gcc -Wmissing-prototypes diagnostic.
9631 * dispextern.h (bidi_dump_cached_states): Likewise.
9632
9633 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9634 shadowing.
9635 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9636 Include <limits.h>.
9637 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9638 and to avoid gcc -Wuninitialized warning.
9639 (load_charset_map): Mark variables that gcc -Wuninitialized
9640 does not deduce are never used uninitialized.
9641 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9642
9643 * coding.c (coding_set_source, coding_set_destination):
9644 Use "else { /* comment */ }" rather than "else /* comment */;"
9645 for clarity, and to avoid gcc -Wempty-body warning.
9646 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9647 a block, when the outer 'i' will do.
9648 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9649 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9650 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9651 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9652 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9653 Rename locals to avoid shadowing.
9654 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9655 * coding.c (emacs_mule_char, encode_invocation_designation):
9656 Now static, since they're not used elsewhere.
9657 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9658 (decode_coding_object, encode_coding_object, detect_coding_system):
9659 (decode_coding_emacs_mule): Mark variables that gcc
9660 -Wuninitialized does not deduce are never used uninitialized.
9661 (detect_coding_iso_2022): Initialize a local variable that might
9662 be used uninitialized. Leave a FIXME because it's not clear that
9663 this initialization is needed. (Bug#8211)
9664 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9665 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9666 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9667 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9668 Remove unused macros.
9669
9670 * category.c (hash_get_category_set): Remove unused local var.
9671 (copy_category_table): Now static, since it's not used elsewhere.
9672 * character.c (string_count_byte8): Likewise.
9673
9674 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9675 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9676
9677 * chartab.c (copy_sub_char_table): Now static, since it's not used
9678 elsewhere.
9679 (sub_char_table_ref_and_range, char_table_ref_and_range):
9680 Rename locals to avoid shadowing.
9681 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9682
9683 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9684 (BIDI_BOB): Remove unused macro.
9685
9686 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9687 deduce are never used uninitialized.
9688 * term.c (encode_terminal_code): Likewise.
9689
9690 * term.c (encode_terminal_code): Now static. Remove unused local.
9691
9692 * tparam.h: New file.
9693 * term.c, tparam.h: Include it.
9694 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9695 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9696 Move these decls to tparam.h, and make them agree with what
9697 is actually in tparam.c. The previous trick of using incompatible
9698 decls in different modules does not conform to the C standard.
9699 All callers of tparam changed to use tparam's actual API.
9700 * tparam.c (tparam1, tparam, tgoto):
9701 Use const pointers where appropriate.
9702
9703 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9704 * cm.h (struct cm): Likewise.
9705 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9706 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9707 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9708 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9709 (turn_on_face, init_tty): Likewise.
9710 * termchar.h (struct tty_display_info): Likewise.
9711
9712 * term.c (term_mouse_position): Rename local to avoid shadowing.
9713
9714 * alloc.c (mark_ttys): Move decl from here ...
9715 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9716
9717 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9718
9719 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9720
9721 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9722
9723 * search.c (compile_pattern_1): Remove argument regp, unused since
9724 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9725 (compile_pattern): Don't pass it.
9726
9727 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9728
9729 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9730 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9731 for ! HAVE_GTK3.
9732 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9733
9734 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9735
9736 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9737 gdk_window_get_screen, gdk_window_get_geometry,
9738 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9739 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9740 (xg_get_pixbuf_from_pixmap): New function.
9741 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9742 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9743 Call xg_get_pixbuf_from_pixmap instead of
9744 gdk_pixbuf_get_from_drawable.
9745 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9746 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9747 (xg_check_special_colors): Use GtkStyleContext and its functions
9748 for HAVE_GTK3.
9749 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9750 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9751 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9752 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9753 Call gtk_widget_get_preferred_size.
9754 (xg_frame_resized): gdk_window_get_geometry only takes 5
9755 parameters.
9756 (xg_win_to_widget, xg_event_is_for_menubar):
9757 Call gdk_x11_window_lookup_for_display.
9758 (xg_set_widget_bg): New function.
9759 (delete_cb): New function.
9760 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9761 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9762 (xg_set_background_color): Call xg_set_widget_bg.
9763 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9764 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9765 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9766 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9767 if ! HAVE_GTK3.
9768 (update_frame_tool_bar): Call gtk_widget_hide.
9769 (xg_initialize): Use GDK_KEY_g.
9770
9771 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9772 if ! HAVE_GTK3
9773 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9774
9775 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9776 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9777 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9778
9779 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9780
9781 * w32xfns.c (select_palette): Check success of RealizePalette against
9782 GDI_ERROR, not zero.
9783
9784 See ChangeLog.11 for earlier changes.
9785
9786 ;; Local Variables:
9787 ;; coding: utf-8
9788 ;; End:
9789
9790 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9791
9792 This file is part of GNU Emacs.
9793
9794 GNU Emacs is free software: you can redistribute it and/or modify
9795 it under the terms of the GNU General Public License as published by
9796 the Free Software Foundation, either version 3 of the License, or
9797 (at your option) any later version.
9798
9799 GNU Emacs is distributed in the hope that it will be useful,
9800 but WITHOUT ANY WARRANTY; without even the implied warranty of
9801 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9802 GNU General Public License for more details.
9803
9804 You should have received a copy of the GNU General Public License
9805 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.