1 2011-12-08 Kenichi Handa <handa@m17n.org>
3 * ftfont.c (get_adstyle_property): Fix previous change
6 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
8 * w32.c (init_environment): If no_site_lisp, remove site-lisp
9 dirs from the default value of EMACSLOADPATH (bug#10208).
11 2011-12-07 Glenn Morris <rgm@gnu.org>
13 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
14 installation and source directories as well. (Bug#10208)
16 2011-12-06 Chong Yidong <cyd@gnu.org>
18 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
20 2011-12-06 Glenn Morris <rgm@gnu.org>
22 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
23 as an error, not just -1. (Bug#10217)
25 2011-12-05 Chong Yidong <cyd@gnu.org>
27 * keyboard.c (process_special_events): New function.
28 (swallow_events, Finput_pending_p): Use it (Bug#10195).
30 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
32 * coding.c (encode_designation_at_bol): Don't use uninitialized
33 local variable (Bug#9318).
35 2011-12-05 Kenichi Handa <handa@m17n.org>
37 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
38 return Qnil (Bug#8046, Bug#10193).
40 2011-12-05 Kenichi Handa <handa@m17n.org>
42 * coding.c (encode_designation_at_bol): New args charbuf_end and
43 dst. Return the number of produced bytes. Callers changed.
44 (coding_set_source): Return how many bytes coding->source was
46 (coding_set_destination): Return how many bytes
47 coding->destination was relocated.
48 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
49 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
51 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
53 * coding.c (CODING_CHAR_CHARSET_P): New macro.
54 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
57 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
59 The following changes are to fix Bug#9318.
61 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
62 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
63 (encode_coding_iso_2022, encode_coding_sjis)
64 (encode_coding_big5, encode_coding_charset): Use the above macros.
66 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
68 * lisp.h (process_quit_flag): Fix external declaration.
70 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
72 Don't macro-inline non-performance-critical code.
73 * eval.c (process_quit_flag): New function.
74 * lisp.h (QUIT): Use it.
76 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
78 * nsfns.m (get_geometry_from_preferences): New function.
79 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
81 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
83 * emacs.c (Qkill_emacs): Define.
84 (syms_of_emacs): Initialize it.
85 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
86 Qquit_flag to `kill-emacs' instead.
87 (quit_throw_to_read_char): Add parameter `from_signal'.
88 All callers changed. Call Fkill_emacs if requested and safe.
89 * lisp.h (QUIT): Call Fkill_emacs if requested.
91 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
93 * widget.c (update_wm_hints): Return if wmshell is null.
94 (widget_update_wm_size_hints): New function.
96 * widget.h (widget_update_wm_size_hints): Declare.
98 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
99 widget_update_wm_size_hints (Bug#10104).
101 2011-12-03 Eli Zaretskii <eliz@gnu.org>
103 * xdisp.c (handle_invisible_prop): If the invisible text ends just
104 before a newline, prepare the bidi iterator for consuming the
105 newline, and keep the current paragraph direction. (Bug#10183)
106 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
108 2011-12-02 Juri Linkov <juri@jurta.org>
110 * search.c (Fword_search_regexp): New Lisp function created from
111 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
112 (Fword_search_backward, Fword_search_forward)
113 (Fword_search_backward_lax, Fword_search_forward_lax):
114 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
115 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
117 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
119 * fileio.c (Finsert_file_contents): Move after-change-function call
120 to before the "handled:" label, since all "goto handled" appear in
121 cases where the *-change-functions have already been properly called
124 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
126 * keyboard.c (interrupt_signal): Don't call kill-emacs when
127 waiting for input. (Bug#10169)
129 2011-11-30 Eli Zaretskii <eliz@gnu.org>
131 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
132 verifies glyph row's hash code--we have just reallocated the
133 glyphs, so their contents can be complete garbage. (Bug#10164)
135 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
137 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
139 2011-11-30 Eli Zaretskii <eliz@gnu.org>
141 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
142 attributes are tested _before_ calling verify_row_hash, to protect
143 against GCC re-ordering of the tests. (Bug#10164)
145 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
147 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
149 * xterm.c (handle_one_xevent): Only set async_visible and friends
150 if net_wm_state_hidden_seen is non-zero (Bug#10002)
151 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
152 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
154 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
156 Remove GCPRO-related macros that exist only to avoid shadowing locals.
157 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
158 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
159 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
160 All uses changed to use GCPRO1 etc.
161 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
162 Revert to old implementation (i.e., before 2011-03-11).
164 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
166 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
167 of scroll runs so as to avoid assigning disabled bogus rows and
168 unnecessary graphics copy operations.
170 2011-11-27 Eli Zaretskii <eliz@gnu.org>
172 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
173 (snprintf) [_MSC_VER]: Redirect to _snprintf.
174 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
175 (malloc, free, realloc, calloc): Redirect to e_* only when
178 * lisp.h (GCTYPEBITS): Move before first use.
179 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
180 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
181 this macro definition.
183 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
186 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
188 * gtkutil.c (xg_create_frame_widgets):
189 Call gtk_window_set_has_resize_grip (FALSE) if that function is
190 present with Gtk+ 2.0.
192 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
194 * fileio.c (Finsert_file_contents): Undo previous change; see
195 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
197 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
199 Rename locals to avoid shadowing.
200 * fileio.c (Finsert_file_contents):
201 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
202 * process.c (wait_reading_process_output):
203 Rename inner 'proc' to 'p' to avoid shadowing.
204 Indent for consistency with usual Emacs style.
206 2011-11-25 Eli Zaretskii <eliz@gnu.org>
208 * xdisp.c (redisplay_window): If cursor row is not fully visible
209 after recentering, and scroll-conservatively is set to a large
210 number, scroll window by a few more lines to make the cursor fully
211 visible and out of scroll-margin. (Bug#10105)
212 (start_display): Don't move to the next line if the display should
213 start at a newline that is part of a display vector or an overlay
216 2011-11-24 Juri Linkov <juri@jurta.org>
218 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
219 after the `MagickPingImage' call. (Bug#10112)
221 2011-11-23 Chong Yidong <cyd@gnu.org>
223 * window.c (Fcoordinates_in_window_p): Accept only live windows.
225 2011-11-23 Martin Rudalics <rudalics@gmx.at>
227 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
228 making another buffer current. (Bug#10114)
230 2011-11-23 Glenn Morris <rgm@gnu.org>
232 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
234 2011-11-23 Chong Yidong <cyd@gnu.org>
236 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
239 2011-11-22 Eli Zaretskii <eliz@gnu.org>
241 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
242 and header-lines, as they don't have one computed for them.
245 * .gdbinit (prow): Make displayed values more self-explaining.
248 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
250 * process.c (wait_reading_process_output): Fix asynchrounous
251 GnuTLS socket handling on some versions of the GnuTLS library.
252 (wait_reading_process_output): Add comment and URL.
254 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
256 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
258 2011-11-21 Chong Yidong <cyd@gnu.org>
260 * window.c (Fnext_window, Fprevious_window): Doc fix.
262 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
264 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
266 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
268 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
270 2011-11-20 Martin Rudalics <rudalics@gmx.at>
272 * window.c (Fset_window_combination_limit): Rename argument
274 (Vwindow_combination_limit): Remove "status" from doc-string.
276 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
278 * m/ibms390.h: Remove.
279 * m/ibms390x.h: Don't include "ibms390.h".
281 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
283 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
284 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
286 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
288 * casetab.c (Fset_case_table):
289 * charset.c (Fcharset_after): Fix typos.
291 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
293 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
294 Otherwise, valgrind does not work on some platforms.
295 Problem reported by Andreas Schwab in
296 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
297 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
298 is set, removing the need for VIRT_ADDRESS_VARIES.
299 (PURE_P): Use a more-efficient implementation that needs just one
300 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
301 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
302 to 4 (xorl, subq, cmpq, setbe).
303 * alloc.c (pure): Always extern now, since that's the
304 VIRT_ADDR_VARIES behavior.
305 (PURE_POINTER_P): Use a single comparison, not two, for
306 consistency with the new puresize.h.
307 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
308 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
309 Remove VIRT_ADDR_VARIES no longer needed.
311 2011-11-19 Eli Zaretskii <eliz@gnu.org>
313 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
314 (erase_phys_cursor, update_window_cursor, show_mouse_face)
315 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
316 behave as if the cursor position were at the window margin.
318 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
319 and the cursor position is out of bounds, behave as if the cursor
320 position were at the window margin. (Bug#10075)
322 2011-11-18 Chong Yidong <cyd@gnu.org>
324 * window.c (Fwindow_combination_limit): Make first argument
325 non-optional, since it is meaningless for live windows like the
328 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
330 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
332 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
334 * intervals.c: Fix grafting over the whole buffer (bug#10071).
335 (graft_intervals_into_buffer): Simplify.
337 2011-11-18 Eli Zaretskii <eliz@gnu.org>
339 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
340 hash values of the two rows.
341 (copy_row_except_pointers): Preserve the used[] arrays and the
342 hash values of the two rows. (Bug#10035)
343 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
345 * xdisp.c (row_hash): New function, body extracted from
346 compute_line_metrics.
347 (compute_line_metrics): Call row_hash, instead of computing the
350 * dispnew.c (verify_row_hash): Call row_hash for computing the
351 hash code of a row, instead of duplicating code from xdisp.c.
353 * dispextern.h (row_hash): Add prototype.
355 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
357 * frame.c (delete_frame): Don't delete the terminal when the last
358 X frame is closed if emacs is built with GTK toolkit.
360 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
362 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
364 2011-11-17 Martin Rudalics <rudalics@gmx.at>
366 * window.c (Vwindow_splits): Rename to
367 Vwindow_combination_resize. Suggested by Juri Linkov.
368 (Fsplit_window_internal): Use Vwindow_combination_resize instead
371 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
373 * nsfns.m (Fns_font_name):
374 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
376 2011-11-16 Martin Rudalics <rudalics@gmx.at>
378 * window.h (window): Rename slot "nest" to "combination_limit".
379 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
380 (Fset_window_nest): Rename to Fset_window_combination_limit.
381 (Vwindow_nest): Rename to Vwindow_combination_limit.
382 (recombine_windows, make_parent_window, make_window)
383 (Fsplit_window_internal, saved_window)
384 (Fset_window_configuration, save_window_save): Rename all
385 occurrences of window_nest to window_combination_limit.
387 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
389 * image.c (imagemagick_load_image): Fix typo.
391 2011-11-14 Eli Zaretskii <eliz@gnu.org>
393 * xdisp.c (display_line): Move the call to
394 highlight_trailing_whitespace before the call to
395 compute_line_metrics, since the latter needs to see the final
396 faces of all the glyphs to compute ROW's hash value.
397 Fixes assertion violations in row_equal_p. (Bug#10035)
399 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
401 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
402 just return (bug#10044).
404 2011-11-12 Eli Zaretskii <eliz@gnu.org>
406 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
407 with user-defined heap size. Bump the default size of the temacs
408 heap to 27MB, to avoid memory warning when running temacs.
409 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
411 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
412 current_matrix and desired_matrix. (Bug#9990)
413 (verify_row_hash) [XASSERTS]: New function.
414 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
415 that the hash value of glyph rows is correct.
417 2011-11-12 Martin Rudalics <rudalics@gmx.at>
419 * window.h (window): Remove splits slot.
420 * window.c (Fwindow_splits, Fset_window_splits): Remove.
421 (Fdelete_other_windows_internal, make_parent_window)
422 (make_window, Fsplit_window_internal, Fdelete_window_internal)
423 (Fset_window_configuration, save_window_save): Don't deal with
424 split status of windows.
425 (saved_window): Remove splits slot.
426 (Vwindow_splits): Rewrite doc-string.
428 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
430 * xfns.c (unwind_create_frame):
431 * nsfns.m (unwind_create_frame):
432 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
433 Vframe_list (Bug#9999).
435 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
437 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
439 2011-11-11 Kenichi Handa <handa@m17n.org>
441 * callproc.c (Fcall_process): Set the member dst_multibyte of
444 2011-11-11 Johan Bockgård <bojohan@gnu.org>
446 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
447 avoid a crash (bug#9496).
449 2011-11-09 Chong Yidong <cyd@gnu.org>
451 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
452 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
454 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
456 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
458 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
460 Avoid some portability problems by eschewing 'extern inline' functions.
461 The trivial performance wins aren't worth the portability hassles; see
462 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
464 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
465 (window_box_width, window_box_left, window_box_left_offset)
466 (window_box_right, window_box_right_offset): Undo previous change,
467 by removing the "extern"s.
468 * intervals.c (adjust_intervals_for_insertion)
469 (adjust_intervals_for_deletion): Undo previous change,
470 making these static again.
471 (offset_intervals, temp_set_point_both, temp_set_point)
472 (copy_intervals_to_string): No longer inline.
473 * xdisp.c (window_text_bottom_y, window_box_width)
474 (window_box_height, window_box_left_offset)
475 (window_box_right_offset, window_box_left, window_box_right)
476 (window_box): No longer inline.
478 2011-11-08 Chong Yidong <cyd@gnu.org>
480 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
481 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
482 Signal an error if not a live window.
483 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
484 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
486 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
488 * lisp.h (syms_of_abbrev): Remove declaration.
489 Reported by CHENG Gao <chenggao@royau.me>.
491 2011-11-07 Eli Zaretskii <eliz@gnu.org>
493 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
494 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
495 of temacs in GUI mode.
497 2011-11-07 Martin Rudalics <rudalics@gmx.at>
499 * window.h: Declare delete_all_child_windows instead of
500 delete_all_subwindows.
501 * window.c (Fwindow_nest, Fset_window_nest)
502 (Fset_window_new_total, Fset_window_new_normal)
503 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
504 (delete_all_subwindows): Rename to delete_all_child_windows.
505 (Fdelete_other_windows_internal, Fset_window_configuration):
506 Call delete_all_child_windows instead of delete_all_subwindows.
507 * frame.c (delete_frame): Call delete_all_child_windows instead
508 of delete_all_subwindows.
510 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
512 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
513 This is also needed for porting to any host where GC_MARK_STACK is
514 not GC_MAKE_GCPROS_NOOPS.
515 (which_symbols): Use it.
517 2011-11-07 Kenichi Handa <handa@m17n.org>
519 * coding.c (coding_set_destination): Check coding->src_pos only
520 when coding->src_object is a buffer (bug#9910).
522 * process.c (send_process): Set the member src_multibyte of coding
523 to 0 (bug#9911) when sending a unibyte text.
525 * callproc.c (Fcall_process): Set the member src_multibyte of
526 process_coding to 0 (bug#9912).
528 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
530 * xmenu.c (cleanup_widget_value_tree): New function.
531 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
532 calling free_menubar_widget_value_tree directly (Bug#9830).
534 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
536 Fix some portability problems with 'inline'.
537 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
538 (window_box_width, window_box_left, window_box_left_offset)
539 (window_box_right, window_box_right_offset): Declare extern.
540 Otherwise, these inline functions do not conform to C99 and
541 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
542 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
543 * intervals.c (adjust_intervals_for_insertion)
544 (adjust_intervals_for_deletion): Now extern, because otherwise the
545 extern inline functions 'offset_intervals' couldn't refer to it.
546 (static_offset_intervals): Remove.
547 (offset_intervals): Rewrite using the old contents of
548 static_offset_intervals. The old version didn't conform to C99
549 because an extern inline function contained a reference to an
550 identifier with static linkage.
552 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
554 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
557 2011-11-06 Eli Zaretskii <eliz@gnu.org>
559 * xdisp.c (init_iterator, reseat_to_string): Don't set the
560 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
561 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
562 return Qleft_to_right.
564 2011-11-06 Chong Yidong <cyd@gnu.org>
566 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
567 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
568 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
569 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
570 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
571 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
572 (Fwindow_vscroll): Doc fix.
573 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
574 argument, since it makes no sense to pass a live window and for
575 consistency with window-child.
577 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
579 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
582 2011-11-05 Jason Rumney <jasonr@gnu.org>
584 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
585 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
587 (add_font_entity_to_list): Fix logic errors in mixed boolean and
588 bitwise arithmetic preventing use of unicode-sip and non-truetype
591 2011-11-05 Eli Zaretskii <eliz@gnu.org>
593 * s/ms-w32.h (fstat, stat, utime): Move redirections to
596 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
597 initialization code to keep similarity to xfns.c after changes
600 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
602 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
603 (unwind_create_frame): New function (Bug#9943).
604 (Fx_create_frame): Restructure code to be more similar to the one in
605 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
606 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
607 Move terminal->reference_count++ just before making the frame official
610 * nsterm.m (x_free_frame_resources): New function.
611 (x_destroy_window): Move code to x_free_frame_resources.
613 * xfns.c (unwind_create_frame): Fix comment.
614 (Fx_create_frame, x_create_tip_frame):
615 Move terminal->reference_count++ just before making the frame
616 official. Move initialization of image_cache_refcount and
617 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
619 2011-11-05 Eli Zaretskii <eliz@gnu.org>
621 Support MSVC build with newer versions of Visual Studio.
622 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
623 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
626 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
627 which are not supported by MSVC.
628 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
629 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
631 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
633 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
635 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
637 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
639 Support MSVC build with newer versions of Visual Studio.
640 * w32.c: Don't include w32api.h for MSVC.
641 (init_environment) [_MSC_VER]: Call sys_access, not _access.
643 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
644 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
645 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
646 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
648 (alloca) [_MSC_VER]: Define to _alloca.
650 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
652 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
654 2011-11-04 Eli Zaretskii <eliz@gnu.org>
656 * xdisp.c (note_mouse_highlight): If either of
657 previous/next-single-property-change returns nil, treat that as
658 the beginning or the end of the buffer. (Bug#9955)
660 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
662 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
663 label is not null (Bug#9951).
664 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
667 2011-11-04 Eli Zaretskii <eliz@gnu.org>
669 * window.c (Fwindow_body_size): Mention in the doc string that the
670 return value is in frame's canonical units. (Bug#9949)
672 2011-11-03 Eli Zaretskii <eliz@gnu.org>
674 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
676 * w32fns.c (unwind_create_frame): If needed, free the glyph
677 matrices of the partially constructed frame. (Bug#9943)
678 * xfns.c (unwind_create_frame): Likewise.
680 2011-11-01 Eli Zaretskii <eliz@gnu.org>
682 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
683 Don't stop backward scan on the continuation glyph, even though
684 its CHARPOS is positive.
685 (mouse_face_from_buffer_pos, note_mouse_highlight):
686 Rename cover_string to disp_string.
688 2011-11-01 Martin Rudalics <rudalics@gmx.at>
690 * window.c (temp_output_buffer_show): Don't use
691 Vtemp_buffer_show_specifiers.
692 (Vtemp_buffer_show_specifiers): Remove unused variable.
694 2011-10-30 Eli Zaretskii <eliz@gnu.org>
696 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
697 past the beginning of the current glyph matrix.
699 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
701 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
702 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
703 HAVE_GTK3 (Bug#9869).
705 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
706 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
708 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
710 * xterm.c: Declare x_handle_net_wm_state to return int.
711 (handle_one_xevent): Check if we are iconified but don't have
712 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
713 (get_current_wm_state): Return non-zero if not hidden,
714 check for _NET_WM_STATE_HIDDEN (Bug#9893).
715 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
716 (x_handle_net_wm_state): Return what get_current_wm_state returns.
717 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
719 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
721 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
722 so that this new function doesn't get optimized away by a
723 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
725 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
727 * frame.h (MOUSE_HL_INFO): Remove excess parens.
729 2011-10-29 Eli Zaretskii <eliz@gnu.org>
731 Fix the `xbytecode' command.
732 * .gdbinit (xprintbytestr): New command.
733 (xwhichsymbols): Rename from `which'; all callers changed.
734 (xbytecode): Print the byte-code string as well.
736 2011-10-29 Kim Storm <storm@cua.dk>
738 * alloc.c (which_symbols): New function.
740 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
742 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
745 2011-10-29 Glenn Morris <rgm@gnu.org>
747 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
748 Not clear what it was for, and it causes various bugs. (Bug#9839)
750 2011-10-28 Eli Zaretskii <eliz@gnu.org>
752 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
753 possible random value that matches one of those tested as
754 condition to clear the mouse face.
756 2011-10-28 Chong Yidong <cyd@gnu.org>
758 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
760 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
762 * window.c (make_window): Initialize phys_cursor_on_p.
764 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
766 * lisp.h (struct Lisp_Symbol): Update comments.
768 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
770 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
772 2011-10-28 Eli Zaretskii <eliz@gnu.org>
774 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
775 <oslsachem@gmail.com> for helping to debug this.
777 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
778 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
779 (g_b_init_get_glyph_outline_w): New static variables.
780 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
781 (GetGlyphOutlineW_Proc): New typedefs.
782 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
783 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
785 (w32font_open_internal, compute_metrics):
786 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
787 instead of calling the "wide" APIs directly.
789 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
791 * w32.h (syms_of_w32font): Add prototype.
793 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
795 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
796 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
797 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
798 (Fmove_to_window_line): Doc fix.
800 2011-10-27 Chong Yidong <cyd@gnu.org>
802 * process.c (make_process): Set gnutls_state to NULL.
804 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
805 non-NULL, regardless of GNUTLS_INITSTAGE.
806 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
807 an error. Set process slots as soon as we allocate them.
809 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
811 2011-10-27 Chong Yidong <cyd@gnu.org>
813 * gnutls.c (emacs_gnutls_deinit): New function.
814 Deallocate credentials structures as well as calling gnutls_deinit.
815 (Fgnutls_deinit, Fgnutls_boot): Use it.
817 * process.c (make_process): Initialize GnuTLS credentials to NULL.
818 (deactivate_process): Call emacs_gnutls_deinit.
820 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
822 * image.c (x_create_x_image_and_pixmap):
823 * w32.c (sys_rename, w32_delayed_load):
824 * w32font.c (fill_in_logfont):
825 * w32reg.c (x_get_string_resource): Silence compiler warnings.
827 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
829 * w32fns.c (w32_default_color_map): New function,
830 extracted from Fw32_default_color_map.
831 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
833 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
835 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
837 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
839 * keyboard.c (test_undefined): New function (bug#9751).
840 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
842 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
844 * sysdep.c (init_sys_modes): Fix the check for the controlling
847 2011-10-20 Eli Zaretskii <eliz@gnu.org>
849 * dispextern.h (struct bidi_it): New member next_en_type.
851 * bidi.c (bidi_line_init): Initialize the next_en_type member.
852 (bidi_resolve_explicit_1): When next_en_pos is valid for the
853 current character, check also for next_en_type being WEAK_EN.
854 (bidi_resolve_weak): Don't enter the expensive loop if the current
855 position is before next_en_pos. Record the bidi type of the first
856 non-ET, non-BN character we find, in addition to its position.
857 (bidi_level_of_next_char): Invalidate next_en_type when
858 next_en_pos is over-stepped.
860 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
862 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
863 * editfns.c: Rewrite current-time-zone so that it invokes
864 the equivalent of (format-time-string "%Z") to get the time zone name.
865 This fixes a bug when the time zone name contains characters that
866 need converting from the system time locale to Emacs internal format.
867 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
868 that patch fixed format-time-string to do the conversion, but
869 I forgot to fix current-time-zone.
870 (format_time_string): New function, containing most of
871 what Fformat_time_string used to contain.
872 (Fformat_time_string): Rewrite in terms of format_time_string.
873 This doesn't change this function's behavior.
874 (current-time-zone): Rewrite to use format_time_string.
875 This fixes the bug reported by Michael Schierl in
876 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
877 Jason Rumney's 2007-06-07 change worked around this bug, but
879 * systime.h (tzname, timezone): Remove no-longer-used declarations.
881 2011-10-19 Eli Zaretskii <eliz@gnu.org>
883 * xdisp.c (start_display): If the character at POS is displayed
884 via a display vector, reset IT->current.dpvec_index to zero.
885 (try_window_reusing_current_matrix): If a line ends in a display
886 vector or the next line starts in a display vector, continue
887 redrawing the window even though the character position of
888 start_row was reached.
891 2011-10-18 Chong Yidong <cyd@gnu.org>
893 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
894 with nobreak-char-display too.
896 2011-10-18 Eli Zaretskii <eliz@gnu.org>
898 Fix part 3 of bug#9771.
899 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
900 (bidi_resolve_neutral): Don't enter the expensive loop looking for
901 non-neutral characters if the current character is a paragraph
902 separator (a.k.a. Newline). This avoids running the same
903 expensive loop twice, once when we consume the preceding newline
904 and the other time when the line actually needs to be displayed.
905 Avoid the loop when we see neutrals on the base embedding level
906 following a character whose directionality is the same as the
907 paragraph's. This avoids running the expensive loop when a line
908 ends in a long sequence of neutrals, like control characters.
909 Add assertion against STRONG_AL type. Slightly rearrange code
910 that determines the type of a neutral given the first non-neutral
912 (bidi_level_of_next_char): Set next_en_pos to zero when
913 invalidating its info.
915 2011-10-17 Eli Zaretskii <eliz@gnu.org>
917 * xdisp.c (push_display_prop): Determine whether to record string
918 or buffer position by IT->string, not by IT->method. Allow
919 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
920 (move_it_vertically_backward): Don't look for character position
921 immediately after the newline when in a continuation line.
924 2011-10-15 Martin Rudalics <rudalics@gmx.at>
926 * window.c (coordinates_in_window): Rewrite and delabelize
927 vertical border check. (Bug#5357) (Bug#9618)
929 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
931 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
932 errors in XSetWindowBorder (bug#9310).
934 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
936 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
937 avoid crash when xmalloc overrun checking is enabled.
939 2011-10-13 Eli Zaretskii <eliz@gnu.org>
941 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
942 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
943 cursor motion with <left> and <right> arrow keys.
945 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
946 some callers set that themselves.
948 2011-10-12 Eli Zaretskii <eliz@gnu.org>
950 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
951 display string and the previous row comes from the same string and
952 is empty. (Bug#9739) (Bug#9738)
954 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
956 * doc.c (get_doc_string): Encode file name (bug#9735).
958 2011-10-12 Eli Zaretskii <eliz@gnu.org>
960 * bidi.c (bidi_level_of_next_char):
961 * xdisp.c (get_visually_first_element): Remove old incorrect
962 comments regarding the Unicode Line Separator character.
964 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
966 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
968 * alloc.c (Fgc_status): Do not access beyond zombies array
969 boundary if nzombies > MAX_ZOMBIES.
970 * alloc.c (dump_zombies): Add missing format specifier.
972 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
974 * xdisp.c (set_cursor_from_row): Simplify conditionals,
975 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
977 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
978 Some packages use them to denote characters with modifiers.
980 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
982 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
983 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
984 matching a pp-number. Rename parameter var to var1.
986 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
988 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
990 2011-10-08 Glenn Morris <rgm@gnu.org>
992 * callint.c (Fcall_interactively): Give a more explicit error for the
993 'c' case with a non-character input. (Bug#8479)
995 2011-10-08 Eli Zaretskii <eliz@gnu.org>
997 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
999 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1000 lines that are hscrolled on the left.
1002 * dispnew.c (buffer_posn_from_coords): Account for a possible
1003 presence of header-line. (Bug#4426)
1005 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1007 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1008 Don't advertise functionality which we discourage or doesn't work.
1010 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1012 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1013 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1014 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1015 this makes Emacs dump core during garbage collection on rare
1016 occasions. sizeof is obviously inferior to offsetof here, so
1017 stick with offsetof.
1018 (GC_POINTER_ALIGNMENT): New macro.
1019 (mark_memory): Omit 3rd (offset) arg; caller changed.
1020 Don't assume EMACS_INT alignment is the same as pointer alignment.
1022 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1024 * keyboard.c (read_key_sequence_remapped): New var.
1025 (read_key_sequence): Compute remapping in the right buffer.
1026 (command_loop_1): Use read_key_sequence's remapping directly.
1028 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1030 * dired.c (file_name_completion): Don't expand file name.
1031 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1032 before checking file name handler.
1034 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1035 they've been requested explicitly (bug#9591).
1037 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1039 * keymap.c (Fsingle_key_description): Use make_specified_string
1040 instead of build_string to build string from push_key_description.
1043 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1045 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1046 This fixes a Y2038 bug on 64-bit hosts.
1047 * buffer.c (reset_buffer):
1048 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1049 (Fclear_buffer_auto_save_failure):
1050 Use 0, not -1, to represent an unset failure time, since time_t
1051 might not be signed.
1053 Remove dependency on glibc malloc internals.
1054 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1055 Move back here from lisp.h, but with their new implementations.
1056 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1057 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1058 * charset.c (charset_table_init): New static var.
1059 (syms_of_charset): Use it instead of xmalloc. This removes a
1060 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1061 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1062 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1063 Move back to alloc.c.
1064 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1065 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1067 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1069 * nsterm.m (windowDidResize): Call x_set_window_size only when
1070 ns_in_resize is true. Otherwise set pixelwidth/height and
1071 call change_frame_size (Bug#9628).
1073 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1075 Port --enable-checking=all to Fedora 14 x86-64.
1076 * charset.c (syms_of_charset): Also account for glibc malloc's
1077 internal overhead when calculating the initial malloc maximum.
1079 Port --enable-checking=all to Fedora 14 x86.
1080 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1082 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1083 (overrun_check_realloc, overrun_check_free):
1084 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1085 That way, xmalloc returns a properly-aligned pointer even if
1086 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1087 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1088 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1089 into account when calculating the initial malloc maximum.
1090 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1091 Move here from alloc.c, so that charset.c can use it too.
1092 Properly align; the old code wasn't right for common 32-bit hosts
1093 when configured with --enable-checking=all.
1094 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1095 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1097 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1099 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1102 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1104 * xdisp.c (compute_display_string_end): If there's no display
1105 string at CHARPOS, return -1.
1107 * bidi.c (bidi_fetch_char): When compute_display_string_end
1108 returns a negative value, treat the character as a normal
1109 character not covered by a display string. (Bug#9624)
1111 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1113 * lread.c (Fread_from_string): Fix typo in docstring.
1115 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1117 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1118 newline, reseat the iterator instead of bidi-iterating there one
1119 character at a time. (Bug#9610)
1120 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1121 TO_CHARPOS if the bidi iterator is at base embedding level.
1123 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1125 * lread.c (readevalloop): Use correct code for NBSP.
1126 (read1): Likewise. (Bug#9608)
1128 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1130 * dbusbind.c (Fdbus_register_signal): When service is not
1131 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1133 2011-09-25 Glenn Morris <rgm@gnu.org>
1135 * buffer.c (truncate-lines): Doc fix.
1137 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1139 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1140 (Fset_window_next_buffers): Doc fix.
1142 2011-09-24 Glenn Morris <rgm@gnu.org>
1144 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1146 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1148 Fix minor problems found by static checking.
1149 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1150 * indent.c (Fvertical_motion): Fix == vs = typo.
1152 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1154 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1155 Default value is now t. Doc fix.
1157 * indent.c (Fvertical_motion): Compute and apply the overshoot
1158 logic when moving up, not only when moving down. Fix the
1159 confusing name and values of the it_overshoot_expected variable;
1160 logic changes accordingly. (Bug#9254) (Bug#9549)
1162 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1163 CHARPOS is covered by a display string which includes newlines.
1164 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1165 is covered by a display string with embedded newlines.
1167 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1169 * dbusbind.c (Fdbus_register_signal): Add match rule to
1170 Vdbus_registered_objects_table. (Bug#9581)
1171 (Fdbus_register_method, Vdbus_registered_objects_table):
1174 2011-09-24 Jim Meyering <meyering@redhat.com>
1176 do not ignore write error for any output size
1177 The previous change was incomplete.
1178 While it makes emacs --batch detect the vast majority of stdout
1179 write failures, errors were still ignored whenever the output size is
1180 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1181 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1182 && echo FAIL: ignored write error
1183 FAIL: ignored write error
1184 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1185 && echo FAIL: ignored write error
1186 FAIL: ignored write error
1187 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1189 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1191 * emacs.c (Fkill_emacs): In noninteractive mode exit
1192 non-successfully if a write error occurred on stdout. (Bug#9574)
1194 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1196 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1199 * dispextern.h (struct it): Update the comment documenting what
1202 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1204 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1205 a display string, extend search for cursor position to end of row.
1206 (find_row_edges): If the row ends in a newline from a display
1207 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1208 Handle the case of a display string with multiple newlines.
1209 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1210 non-empty line. Fixes confusing cursor motion with arrow keys at
1211 the beginning of a line that starts with whitespace.
1213 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1215 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1218 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1220 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1223 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1225 * xdisp.c (display_line): Record maximum and minimum buffer
1226 positions even if no glyphs were produced (e.g., by a zero-width
1227 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1228 buffer positions that will be removed from the glyph row because
1230 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1231 column is beyond frame width: don't subtract 1 "pixel" when
1232 computing width of the stretch.
1233 (reseat_at_next_visible_line_start): Undo the change made on
1234 2011-09-17 that saved paragraph information and restored it after
1235 the call to `reseat'. (Bug#9545)
1237 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1239 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1240 and turn window cursor on if cleared (Bug#9415).
1242 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1244 * search.c (boyer_moore): Take unibyte characters from pattern
1245 literally. (Bug#9458)
1247 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1249 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1251 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1253 Fix minor problem found by static checking.
1254 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1255 initialized, to pacify gcc -Wuninitialized.
1257 * fileio.c: Report proper errno when syscall falls.
1258 (Finsert_file_contents): Save and restore errno,
1259 so that report_file_error outputs the correct diagnostic.
1260 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1262 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1264 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1266 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1268 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1269 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1271 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1273 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1274 about the current paragraph and restore it after the call to reseat.
1276 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1277 (bidi_find_paragraph_start): Search back for paragraph beginning
1278 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1279 (bidi_move_to_visually_next): Only trigger paragraph-related
1280 computations when the last character is a newline or at EOB, not
1281 just any NEUTRAL_B. (Bug#9470)
1283 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1284 truncated lines if point is covered by a display string. (Bug#9524)
1286 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1288 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1289 (cons_to_x_long): New function.
1290 (lisp_data_to_selection_data): Use it. Correct the test for
1291 short-versus-long data; it was negated. Break out of vector
1292 loop, for efficiency, when a long datum is discovered.
1294 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1296 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1298 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1300 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1301 GCC PR/17406) by declaring this function with external scope.
1303 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1305 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1306 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1308 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1310 * editfns.c (Fformat): Correctly handle text properties on "%%".
1312 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1314 * xterm.c (x_draw_composite_glyph_string_foreground):
1315 * w32term.c (x_draw_composite_glyph_string_foreground):
1316 * term.c (encode_terminal_code):
1317 * composite.c (composition_update_it, get_composition_id):
1318 * xdisp.c (get_next_display_element)
1319 (fill_composite_glyph_string): Add comments about special meaning
1320 of TAB characters in a composition.
1322 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1324 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1325 This occurs when processing a multibyte format.
1326 Problem reported by Wolfgang Jenker.
1328 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1330 * xdisp.c (try_cursor_movement): Only check for exact match if
1331 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1333 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1335 Remove unused external symbols.
1336 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1337 * xdisp.c (calc_pixel_width_or_height): Now static.
1338 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1339 * indent.c (check_display_width):
1340 * w32term.c: Fix comment to match code.
1341 * xterm.c, xterm.h (x_catching_errors): Remove.
1343 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1345 * xselect.c: Use signed conversions more consistently (Bug#9498).
1346 (selection_data_to_lisp_data): Assume incoming selection data are
1347 signed integers, not unsigned. This is to be consistent with
1348 outgoing selection data, which was modified to use signed integers
1349 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1350 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1351 expects long, not unsigned long.
1353 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1355 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1356 computation of loop end. Reported by Johan Bockgård
1359 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1361 * frame.c (Fother_visible_frames_p): Function deleted.
1363 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1365 * indent.c (compute_motion): Process display vector front to back
1366 rather than the other way around. (Bug#2496)
1368 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1370 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1372 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1374 * minibuf.c (Fread_from_minibuffer): Doc fix.
1376 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1378 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1379 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1381 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1383 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1384 value for non-existent files.
1386 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1388 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1389 set its "size" to -1. This will set the modtime_size field of
1390 the corresponding buffer to -1, which is what
1391 verify-visited-file-modtime expects for files that do not exist.
1394 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1396 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1398 * lisp.h: ... from here. push_key_description is no longer
1399 defined in keyboard.c, so its declaration should not be in
1400 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1401 logically belongs with push_key_description.
1403 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1405 * buffer.h: Include <sys/types.h> instead of <time.h>.
1406 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1407 Problem reported by Herbert J. Skuhra.
1409 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1411 * xml.c (parse_region): Make the parsing work for
1412 non-comment-starting XML files again (bug#9144).
1414 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1416 * image.c (gif_load): Fix calculation of bottom and right corner.
1419 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1421 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1422 redisplay in small windows.
1424 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1426 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1428 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1430 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1431 Operate on live windows only.
1433 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1435 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1437 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1439 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1440 only under bidi iteration.
1442 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1444 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1446 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1448 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1449 Without this fix, the command to link temacs failed due to an
1450 undefined symbol __builtin_isnan. This is because
1451 /usr/include/iso/math_c99.h #defines isnan(x) to
1452 __builtin_isnan(x), but the bundled gcc, which identifies itself
1453 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1455 * floatfns.c (isnan): #undef, and then #define to a clone of
1457 (Fisnan): Always define, since it's always available now.
1458 (syms_of_floatfns): Always define isnan at the Lisp level.
1460 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1462 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1464 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1466 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1467 The previous code assumed that file offsets (off_t values) fit in
1468 EMACS_INT variables, which is not true on typical 32-bit hosts.
1469 The code messed up by falsely reporting buffer overflow in cases
1470 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1471 when "big" contains more than 2**29 bytes, even though this
1472 inserts just one byte and does not overflow the buffer.
1473 (Finsert_file_contents): Store file offsets as off_t
1474 values, not as EMACS_INT values. Check for overflow when
1475 converting between EMACS_INT and off_t. When checking for
1476 buffer overflow or for overlap, take the offsets into account.
1477 Don't use EMACS_INT for small values where int suffices.
1478 When checking for overlap, fix a typo: ZV was used where
1479 ZV_BYTE was intended.
1480 (Fwrite_region): Don't assume off_t fits into 'long'.
1481 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1483 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1485 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1487 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1489 sprintf-related integer and memory overflow issues (Bug#9412).
1491 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1492 (esprintf, exprintf, evxprintf): New functions.
1493 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1494 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1495 (modify_event_symbol): Do not assume that the length of
1496 name_alist_or_stem is safe to alloca and fits in int.
1497 (Fexecute_extended_command): Likewise for function name and binding.
1498 (Frecursion_depth): Wrap around reliably on integer overflow.
1499 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1500 since some callers pass EMACS_INT values.
1501 (Fsingle_key_description): Don't crash if symbol name contains more
1502 than MAX_ALLOCA bytes.
1503 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1504 (get_minibuffer): Arg is now EMACS_INT, not int.
1505 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1506 (esprintf, exprintf, evxprintf): New decls.
1507 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1509 * dbusbind.c (signature_cat): New function.
1510 (xd_signature, Fdbus_register_signal):
1511 Do not overrun buffer; instead, report string overflow.
1513 * dispnew.c (add_window_display_history): Don't overrun buffer.
1514 Truncate instead; this is OK since it's just a log.
1516 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1517 even if the time zone offset is outlandishly large.
1518 Don't mishandle offset == INT_MIN.
1520 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1521 when creating daemon; the previous buffer-overflow check was incorrect.
1523 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1524 which has the guts of the old verror function.
1526 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1527 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1529 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1530 (font_unparse_xlfd): Don't blindly alloca long strings.
1531 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1532 fits in int, when using sprintf. Use single snprintf to count
1533 length of string rather than counting it via multiple sprintfs;
1534 that's simpler and more reliable.
1535 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1536 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1537 sprintf, in case result does not fit in int.
1539 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1540 (fontset_from_font): Print it.
1542 * frame.c (tty_frame_count): Now printmax_t, not int.
1543 (make_terminal_frame, set_term_frame_name): Print it.
1544 (x_report_frame_params): In X, window IDs are unsigned long,
1545 not signed long, so print them as unsigned.
1546 (validate_x_resource_name): Check for implausibly long names,
1547 and don't assume name length fits in 'int'.
1548 (x_get_resource_string): Don't blindly alloca invocation name;
1549 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1552 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1553 (xg_check_special_colors, xg_set_geometry):
1554 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1556 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1557 Use esprintf, not sprintf, in case result does not fit in int.
1559 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1560 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1561 it as a large positive number.
1562 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1563 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1565 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1566 in case result does not fit in int.
1568 * print.c (float_to_string): Detect width overflow more reliably.
1569 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1570 buffer overrun. Don't assume list length fits in 'int'. Treat
1571 print length of 0 as 0, not as infinity; to be consistent with other
1572 uses of print length in this function. Don't overflow print length
1573 index. Don't assume hash table size fits in 'long', or that
1574 vectorlike size fits in 'unsigned long'.
1576 * process.c (make_process): Use printmax_t, not int, to format
1577 process-name gensyms.
1579 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1581 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1582 to avoid potential buffer overrun.
1584 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1585 if X resource line is longer than 512 bytes.
1587 * xfns.c (x_window): Make sprintf buffer a bit bigger
1588 to avoid potential buffer overrun.
1590 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1592 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1594 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1596 Integer overflow fixes for scrolling, etc.
1597 Without these, Emacs silently mishandles large integers sometimes.
1598 For example, "C-u 4294967297 M-x recenter" was treated as if
1599 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1601 * xdisp.c (try_window_id): Check Emacs fixnum range before
1602 converting to 'int'.
1604 * window.c (window_scroll_line_based, Frecenter):
1605 Check that an Emacs fixnum is in range before assigning it to 'int'.
1606 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1607 values converted from Emacs fixnums.
1608 (Frecenter): Don't wrap around a line count if it is out of 'int'
1609 range; instead, treat it as an extreme value.
1610 (Fset_window_configuration, compare_window_configurations):
1611 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1613 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1614 that can exceed INT_MAX. Check that EMACS_INT value is in range
1615 before assigning it to the (possibly-narrower) index.
1616 (match_limit): Don't assume that a fixnum can fit in 'int'.
1618 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1621 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1622 (Fvertical_motion): Don't wrap around LINES values that don't fit
1623 in 'int'. Instead, treat them as extreme values. This is good
1624 enough for windows, which can't have more than INT_MAX lines anyway.
1626 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1628 * Require libxml/parser.h to avoid compilation warning.
1630 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1632 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1633 since this reportedly can destroy thread storage.
1635 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1637 * syntax.c (find_defun_start): Update all cache variables if
1638 exiting early (Bug#9401).
1640 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1642 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1644 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1645 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1646 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1648 * term.c (tty_append_glyph): New function.
1649 (produce_stretch_glyph): Static function and its prototype deleted.
1651 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1654 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1656 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1657 when checking :margin (Bug#9390).
1658 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1659 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1660 so that the name doesn't mislead. All uses changed.
1662 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1664 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1667 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1669 * xdisp.c (move_it_to): Don't bail out early when reaching
1670 position beyond to_charpos, if we are scanning backwards.
1671 (move_it_vertically_backward): When DY == 0, make sure we get to
1672 the first character in the line after the newline.
1674 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1676 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1677 (ccl_driver): Do not generate an out-of-range pointer.
1678 (Fccl_execute_on_string): Remove unnecessary check for
1679 integer overflow, noted by Stefan Monnier in
1680 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1681 Remove a FIXME that didn't need fixing.
1682 Simplify the newly-introduced buffer reallocation code.
1684 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1686 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1688 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1690 Integer and memory overflow issues (Bug#9196).
1692 * doc.c (get_doc_string): Rework so that
1693 get_doc_string_buffer_size is the actual buffer size, rather than
1694 being 1 less than the actual buffer size; this makes xpalloc more
1697 * image.c (x_allocate_bitmap_record, cache_image):
1698 * xselect.c (Fx_register_dnd_atom):
1699 Simplify previous changes by using xpalloc.
1701 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1702 since either will do and ptrdiff_t is convenient with xpalloc.
1704 * charset.c (charset_table_size)
1705 (struct charset_sort_data.priority): Now ptrdiff_t.
1706 (charset_compare): Don't overflow if priorities differ greatly.
1707 (Fsort_charsets): Don't assume list length fits in int.
1708 Check for size-calculation overflow when allocating sort data.
1709 (syms_of_charset): Allocate an initial charset table that is
1710 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1712 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1714 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1715 The actual value is always <= INT_MAX, and leaving it unsigned made
1716 overflow checking harder.
1718 * dispextern.h (struct glyph_matrix.rows_allocated)
1719 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1720 with xpalloc. The values are still always <= INT_MAX.
1722 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1724 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1725 (SAFE_NALLOCA): New macro.
1727 * region-cache.c (struct boundary.pos, find_cache_boundary)
1728 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1729 (set_cache_region, invalidate_region_cache)
1730 (revalidate_region_cache, know_region_cache, region_cache_forward)
1731 (region_cache_backward, pp_cache):
1732 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1733 so that ptrdiff_t * can be passed to xpalloc.
1734 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1735 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1736 (pp_cache): Don't assume cache_len fits in int.
1737 * region-cache.h: Adjust extern decls to match.
1739 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1740 EMACS_INT, since either will do, for xpalloc.
1742 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1743 (xnmalloc, xnrealloc, xpalloc): New functions.
1745 * bidi.c (bidi_shelve_header_size): New constant.
1746 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1747 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1749 * bidi.c (bidi_cache_shrink):
1750 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1752 Don't update size of array until after memory allocation succeeds,
1753 because xmalloc/xrealloc may not return.
1754 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1755 now that we have proper integer overflow checking.
1756 (record_overlay_string, overlay_strings): Catch overflows when
1757 calculating size of overlay_str_buf.
1759 * callproc.c (Fcall_process): Check for size overflow when
1760 calculating size of args2.
1761 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1762 Normally we prefer signed values, but sticking with ptrdiff_t would
1763 require adding more-complicated checks.
1765 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1766 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1767 Redo buffer-overflow calculations to avoid integer overflow.
1768 Add a FIXME comment where memory seems to be over-allocated.
1770 * character.c (Fstring): Check for size-calculation overflow.
1772 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1773 unnecessary integer overflow. Check for size overflow.
1774 (encode_coding_object): Don't update size until xmalloc succeeds.
1776 * composite.c (get_composition_id): Check for overflow in glyph
1777 length calculations.
1779 Integer and memory overflow fixes for display code.
1780 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1781 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1782 (scrolling_window): Check for overflow in size calculations.
1783 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1784 Don't assume glyph table len fits in int.
1785 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1786 (row_table_size): Now ptrdiff_t, not int.
1787 (scrolling_window): Avoid overflow in size calculations.
1788 Don't update size until allocation succeeds.
1789 * fns.c (concat): Check for overflow in size calculations.
1790 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1791 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1792 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1794 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1795 (get_doc_string): Check for size calculation overflow.
1796 Don't update size until allocation succeeds.
1797 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1798 EMACS_INT, where ptrdiff_t will do.
1799 (Fsubstitute_command_keys): Check for string overflow.
1801 * editfns.c (set_time_zone_rule): Don't assume environment length
1803 (message_length): Now ptrdiff_t, not int.
1804 (Fmessage_box): Don't update size until allocation succeeds.
1805 Don't assume message length fits in int.
1806 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1808 * emacs.c (main): Do not reallocate argv, since there is a null at
1809 the end that can be overwritten, and this way there's no need to
1810 worry about size-calculation overflow.
1811 (sort_args): Check for size-calculation overflow.
1813 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1815 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1817 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1818 (x_set_scroll_bar_width, x_figure_window_size):
1819 Check for integer overflow.
1820 (x_set_alpha): Do not assume XINT fits in int.
1822 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1823 This is for the members text_lines, text_cols, total_lines, total_cols,
1824 where the system imposes an 'int' limit.
1826 * fringe.c (Fdefine_fringe_bitmap):
1827 Don't update size until alloc works.
1829 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1830 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1832 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1833 Check for size-calculation overflow.
1834 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1835 do, as we prefer signed integers.
1836 (id_to_widget.max_size, id_to_widget.used)
1837 (xg_store_widget_in_map, xg_remove_widget_from_map)
1838 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1839 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1840 Use and return ptrdiff_t, not int.
1841 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1842 * gtkutil.h: Change prototypes to match the above.
1844 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1845 are duplicate now that they've been promoted to lisp.h.
1846 (x_allocate_bitmap_record, x_alloc_image_color)
1847 (make_image_cache, cache_image, xpm_load):
1848 Don't update size until alloc is done.
1849 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1851 Check for size calculation overflow.
1852 (ct_colors_allocated_max): New constant.
1853 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1856 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1857 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1858 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1859 Use ptrdiff_t, not int, to count maps.
1860 (read_char_minibuf_menu_prompt): Check for overflow in size
1861 calculations. Don't update size until allocation succeeds.
1862 Redo calculations to avoid overflow.
1863 * keyboard.h: Change prototypes to match the above.
1865 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1867 (current_minor_maps): Check for size calculation overflow.
1868 * keymap.h: Change prototypes to match the above.
1870 * lread.c (read1, init_obarray): Don't update size until alloc done.
1872 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1873 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1875 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1876 Now ptrdiff_t, not int.
1877 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1878 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1880 * process.c (Fnetwork_interface_list): Check for overflow
1881 in size calculation.
1883 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1885 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1886 overflow. Don't bother calling xmalloc when xrealloc will do.
1888 * search.c (Freplace_match): Check for size calculation overflow.
1889 (Fset_match_data): Don't assume list lengths fit in 'int'.
1891 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1892 for command line length. Do not attempt to address one before the
1893 beginning of an array, as that's not portable.
1895 * term.c (max_frame_lines): Remove; unused.
1896 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1898 (encode_terminal_code, calculate_costs): Check for size
1899 calculation overflow.
1900 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1901 table lengths and related sizes. Don't update size until alloc
1902 done. Redo calculations to avoid overflow.
1903 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1905 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1906 subtracting pointers.
1907 (gobble_line): Check for overflow more carefully. Don't update size
1910 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1911 Don't update size until alloc done.
1912 Redo size calculations to avoid overflow.
1913 Check for size calculation overflow.
1914 (main) [DEBUG]: Fix typo in invoking tparam1.
1916 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1917 Use ptrdiff_t, not int, for sizes.
1918 (store_mode_line_noprop_char): Don't update size until alloc done.
1920 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1921 Use ptrdiff_t, not int, for sizes.
1922 (Finternal_make_lisp_face, cache_face):
1923 Check for size calculation overflow.
1924 (cache_face): Treat size calculation overflows as if they were
1925 memory exhaustion (the usual treatment), rather than aborting.
1927 * xfns.c (x_encode_text, x_set_name_internal)
1928 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1929 sizes, since they can exceed INT_MAX in size. Check for size
1930 calculation overflow.
1932 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1933 (xg_select): Check for size calculation overflow.
1934 Don't update size until alloc done.
1936 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1937 as sprintf is limited to int lengths.
1939 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1940 (X_LONG_MIN): New macros.
1941 Use them to make the following changes clearer.
1942 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1943 This change doesn't affect the value now, but it may help remind
1944 future maintainers not to raise the value too much later.
1945 (SELECTION_QUANTUM): Remove, replacing with ...
1946 (selection_quantum): ... new function, which avoids overflow.
1948 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1949 assumption that selection length fits in 'int'.
1950 (x_reply_selection_request, x_handle_selection_request)
1951 (x_get_window_property, receive_incremental_selection)
1952 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1953 (lisp_data_to_selection_data, clean_local_selection_data):
1954 Use ptrdiff_t, not int, to record length of selection.
1955 (x_reply_selection_request, x_get_window_property)
1956 (receive_incremental_selection, x_property_data_to_lisp):
1957 Redo calculations to avoid overflow.
1958 (x_reply_selection_request): When sending hint, ceiling it at
1959 X_LONG_MAX rather than relying on wraparound overflow to send
1961 (x_get_window_property, receive_incremental_selection)
1962 (lisp_data_to_selection_data, x_property_data_to_lisp):
1963 Check for size-calculation overflow.
1964 (x_get_window_property, receive_incremental_selection)
1965 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1966 Don't store size until memory allocation succeeds.
1967 (x_get_window_property): Plug memory leak on memory exhaustion.
1968 Don't double-block input; malloc is safe here. Don't assume 2**34
1969 - 4 fits in unsigned long. Add an xassert to check
1970 XGetWindowProperty overflow. Be more careful about overflow
1971 calculations, and distinguish size from memory overflow better.
1972 (receive_incremental_selection): When tracing, don't assume
1973 unsigned int is less than INT_MAX.
1974 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1975 harmful) conversions of unsigned short to int.
1976 (lisp_data_to_selection_data): Don't assume that integers
1977 in the range -65535 through -1 fit in an X unsigned short.
1978 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1979 result parameters unless successful. Rely on cons_to_unsigned
1980 to report problems with elements; the old code wasn't right anyway.
1981 (x_check_property_data): Check for int overflow; we cannot use
1982 a wider type due to X limits.
1983 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1985 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1987 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1988 (x_term_init): Check for size calculation overflow.
1989 (x_color_cells): Don't store size until memory allocation succeeds.
1990 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1991 Don't assume alloca size is less than MAX_ALLOCA.
1992 (x_term_init): Don't assume length fits in int (sprintf is limited
1995 Use ptrdiff_t for composition IDs.
1996 * character.c (lisp_string_width):
1997 * composite.c (composition_table_size, n_compositions)
1998 (get_composition_id, composition_gstring_from_id):
1999 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2000 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2001 * window.c (Frecenter):
2002 Use ptrdiff_t, not int, for composition IDs.
2003 * composite.c (get_composition_id): Check for integer overflow.
2004 * composite.h: Adjust prototypes to match the above changes.
2006 Use ptrdiff_t for hash table indexes.
2007 * category.c (hash_get_category_set):
2008 * ccl.c (ccl_driver):
2009 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2010 * coding.c (coding_system_charset_list, detect_coding_system):
2011 * coding.h (struct coding_system.id):
2012 * composite.c (get_composition_id, gstring_lookup_cache):
2013 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2014 * image.c (xpm_get_color_table_h):
2015 * lisp.h (hash_lookup, hash_put):
2016 * minibuf.c (Ftest_completion):
2017 Use ptrdiff_t for hash table indexes, not int (which is too
2018 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2019 32-bit --with-wide-int hosts).
2021 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2022 Add a FIXME comment about memory leaks.
2023 (syms_of_charset): Don't assume xmalloc returns.
2025 Don't assume that stated character widths fit in int.
2026 * character.c (Fchar_width, c_string_width, lisp_string_width):
2027 * character.h (CHAR_WIDTH):
2028 * indent.c (MULTIBYTE_BYTES_WIDTH):
2029 Use sanitize_char_width to avoid undefined and/or bad behavior
2030 with outlandish widths.
2031 * character.h (sanitize_tab_width): Rename from sanitize_width,
2032 now that we have two such functions. All uses changed.
2033 (sanitize_char_width): New inline function.
2035 Don't assume that tab-width fits in int.
2036 * character.h (sanitize_width): New inline function.
2037 (SANE_TAB_WIDTH): New macro.
2038 (ASCII_CHAR_WIDTH): Use it.
2039 * indent.c (sane_tab_width): Remove. All uses replaced by
2040 SANE_TAB_WIDTH (current_buffer).
2041 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2043 * fileio.c: Integer overflow issues with file modes.
2044 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2046 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2047 Remove unreachable code.
2048 (read_hex, load_charset_map_from_file): Check for integer overflow.
2050 * xterm.c: don't go over XClientMessageEvent limit
2051 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2052 (x_send_scroll_bar_event): Likewise. Check that the size does not
2053 exceed limits imposed by XClientMessageEvent, as well as the usual
2054 ptrdiff_t and size_t limits.
2056 * keyboard.c: Overflow, signedness and related fixes.
2057 (make_lispy_movement): Use same integer type in forward decl
2058 that is used in the definition.
2059 (read_key_sequence, keyremap_step):
2060 Change bufsize argument back to int, undoing my 2011-03-30 change.
2061 We prefer signed types, and int is wide enough here.
2062 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2063 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2064 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2065 length, not size_t. Use ptrdiff_t for index, not int.
2066 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2067 possibility of integer overflow.
2069 Overflow, signedness and related fixes for images.
2071 * dispextern.h (struct it.stack[0].u.image.image_id)
2072 (struct_it.image_id, struct image.id, struct image_cache.size)
2073 (struct image_cache.used, struct image_cache.ref_count):
2074 * gtkutil.c (update_frame_tool_bar):
2075 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2076 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2077 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2078 * nsmenu.m (update_frame_tool_bar):
2079 * xdisp.c (calc_pixel_width_or_height):
2080 * xfns.c (image_cache_refcount):
2081 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2082 on typical 64-bit hosts.
2084 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2085 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2086 Omit unnecessary casts to int.
2087 (parse_image_spec): Check that integers fall into 'int' range
2088 when the callers expect that.
2089 (image_ascent): Redo ascent calculation to avoid int overflow.
2090 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2091 (lookup_image): Remove unnecessary tests.
2092 (xbm_image_p): Locals are now of int, not EMACS_INT,
2093 since parse_image_check makes sure they fit into int.
2094 (png_load, gif_load, svg_load_image):
2095 Prefer int to unsigned where either will do.
2096 (tiff_handler): New function, combining the cores of the
2097 old tiff_error_handler and tiff_warning_handler.
2098 This function is rewritten to use vsnprintf and thereby avoid
2099 stack buffer overflows. It uses only the features of vsnprintf
2100 that are common to both POSIX and native Microsoft.
2101 (tiff_error_handler, tiff_warning_handler): Use it.
2102 (tiff_load, gif_load, imagemagick_load_image):
2103 Don't assume :index value fits in 'int'.
2104 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2105 (imagemagick_load_image): Check that crop parameters fit into
2106 the integer types that MagickCropImage accepts. Don't assume
2107 Vimagemagick_render_type has a nonnegative value. Don't assume
2108 size_t fits in 'long'.
2109 (gs_load): Use printmax_t to print the widest integers possible.
2110 Check for integer overflow when computing image height and width.
2112 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2114 * xdisp.c (redisplay_window): Don't force window start if point
2115 will be invisible in the resulting window. (Bug#9324)
2117 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2119 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2120 the display spec is of the form `(space ...)'.
2121 (handle_display_spec): Return the value returned by
2122 handle_single_display_spec, not just 1 or zero.
2123 (handle_single_display_spec): If the display spec is of the form
2124 `(space ...)', and specifies display in the text area, return 2
2126 (try_cursor_movement): Check for the need to scroll more
2127 accurately, and prefer exact match for point under bidi.
2128 Don't advance `row' beyond the last row of the window.
2130 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2131 into disp_prop; all users changed.
2133 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2134 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2135 for the text covered by the display property.
2137 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2139 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2140 Change return value to nil.
2141 (Frecord_buffer): Delete unused function.
2143 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2145 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2146 buffers, return left-to-right.
2147 (set_cursor_from_row): Consider candidate row a win if its glyph
2148 represents a newline and point is on that newline. Fixes cursor
2149 positioning on the newline at EOL of R2L text within L2R
2150 paragraph, and vice versa.
2151 (try_cursor_movement): Check continued rows, in addition to
2152 continuation rows. Fixes unwarranted scroll when point enters a
2153 continued line of R2L text within an L2R paragraph, or vice versa.
2154 (cursor_row_p): Consider the case of point being equal to
2155 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2156 from the end of a short line to the beginning of a continued line
2157 of R2L text within L2R paragraph.
2158 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2159 composed characters.
2161 * bidi.c (bidi_check_type): Use xassert.
2162 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2165 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2167 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2170 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2172 * nsfont.m (ns_otf_to_script): Fix typo.
2174 2011-08-22 Kenichi Handa <handa@m17n.org>
2176 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2177 extra slot even if the purpose is char-code-property-table.
2179 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2181 * xdisp.c (redisplay_window): When computing centering_position,
2182 account for the height of the header line. (Bug#8874)
2184 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2185 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2186 candidate is selected by the mouse, and that candidate has a
2187 composed character under the mouse.
2189 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2190 coordinates reported by pos-visible-in-window-p for a composed
2191 character in column zero.
2193 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2195 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2197 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2199 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2200 consider it a hit if to_charpos is anywhere in the range of the
2201 composed buffer positions.
2203 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2205 * image.c (gif_load): Don't assume that each subimage has the same
2206 dimensions as the base image. Handle disposal method that is
2207 "undefined" by the gif spec (Bug#9335).
2209 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2211 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2212 (Fcondition_case): Document `debug' symbol in error handler.
2214 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2216 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2217 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2218 from an Org mode buffer to a Speedbar frame.
2220 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2221 a composition, take its buffer position from IT->cmp_it.charpos.
2222 Fixes cursor positioning at the beginning of a line that begins
2223 with a composed character.
2225 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2227 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2228 character bidirectional type, use STRONG_L instead. Fixes crashes
2229 in a buffer produced by `describe-categories'.
2231 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2232 members before the level stack, so they would be saved and
2233 restored when copying iterator state. Fixes incorrect reordering
2234 around TABs covered by display properties.
2236 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2238 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2240 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2242 * eval.c (internal_condition_case, internal_condition_case_1)
2243 (internal_condition_case_2, internal_condition_case_n):
2244 Remove unnecessary aborts (Bug#9081).
2246 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2248 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2249 has no `load' handler, try opening the file locally. (Bug#9311)
2251 2011-08-16 Ken Brown <kbrown@cornell.edu>
2253 * gmalloc.c: Expand comment.
2255 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2257 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2258 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2260 2011-08-16 Ken Brown <kbrown@cornell.edu>
2262 Fix memory allocation problems in Cygwin build (Bug#9273).
2264 * unexcw.c ( __malloc_initialized): Declare external variable.
2265 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2267 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2269 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2271 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2273 [CYGWIN] (special_realloc): New function.
2274 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2275 requests to realloc storage in the static heap.
2277 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2279 * bidi.c (bidi_initialize): Remove unused local.
2281 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2284 * biditype.h: Remove file.
2285 * makefile.w32-in ($(BLD)/bidi.$(O)):
2286 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2288 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2290 * chartab.c: Improve commentary for the uniprop_table API.
2292 * bidi.c (bidi_paragraph_init): Support zero value of
2293 bidi_ignore_explicit_marks_for_paragraph_level.
2294 (bidi_initialize): Use uniprop_table instead of including
2295 biditype.h and bidimirror.h.
2297 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2298 coordinates of the iterator when restoring from ppos_it.
2301 2011-08-14 Kenichi Handa <handa@m17n.org>
2303 * process.c (create_process): Call setup_process_coding_systems
2304 after the pid of the process is set to -1 (Bug#8162).
2306 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2308 * xdisp.c (move_it_in_display_line_to): Don't invoke
2309 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2310 ppos_it. Fixes vertical cursor motion when line beginning is
2311 covered by an image. (Bug#9296)
2313 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2315 * nsterm.h (ns_run_ascript): Declare.
2316 (NSAPP_DATA2_RUNASSCRIPT): Define.
2318 * nsfns.m (as_script, as_result, as_status): New static variables.
2319 (ns_run_ascript): New function.
2320 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2321 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2322 the event loop. Get status from as_status (Bug#7276).
2324 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2325 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2326 the event loop (Bug#7276).
2328 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2330 * gnutls.c (QCgnutls_bootprop_priority)
2331 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2332 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2333 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2334 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2335 (QCgnutls_bootprop_verify_hostname_error)
2336 (QCgnutls_bootprop_callbacks_verify): Rename from
2337 Qgnutls_bootprop_..., all uses changed.
2339 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2342 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2344 * xfaces.c (Qframe_set_background_mode): Now static.
2345 * dispextern.h (Qframe_set_background_mode): Remove decl.
2347 * process.c (Fnetwork_interface_info): Declare local only if needed.
2349 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2351 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2352 (Fnetwork_interface_list): Allocate in increments of bytes instead
2353 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2354 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2356 (struct ifflag_def): notrailers is smart on OSX.
2357 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2358 Get hardware address with getifaddrs if available.
2360 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2362 * xdisp.c (iterate_out_of_display_property): xassert that
2363 IT->position is set to within IT->object's boundaries. Break from
2364 the loop as soon as EOB is reached; avoids infloops in redisplay
2365 when IT->position is set up wrongly due to some bug.
2366 Set IT->current to match the bidi iterator unconditionally.
2367 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2368 entry. Force push_it to save on the stack the current
2369 buffer/string position, to be restored by pop_it. Fix flags in
2370 the iterator structure wrt the object coming from a display
2371 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2372 properties. (Bug#9284)
2374 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2376 * fontset.c (fontset_get_font_group): Add proper type checks.
2379 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2381 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2382 and LC_VERSION_MIN_MACOSX.
2383 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2384 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2386 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2388 * xdisp.c (forward_to_next_line_start): Allow to use the
2389 no-display-properties-and-no-overlays under bidi display.
2390 Set disp_pos in the bidi iterator to avoid searches for display
2391 properties and overlays.
2393 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2395 * editfns.c (Fset_time_zone_rule): Document relationship with the
2398 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2399 the font entity extracted from the cache (Bug#8109).
2401 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2403 * composite.c (autocmp_chars): Don't reset point. That is done by
2404 restore_point_unwind (Bug#5984).
2406 2011-08-07 Juri Linkov <juri@jurta.org>
2408 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2409 to show the arg `TIME' instead of `TIMEVAL'.
2411 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2413 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2414 display property strides EOL and includes a newline, as in
2415 longlines-mode. (Bug#9254)
2416 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2417 word-wrap under bidirectional display. (Bug#9224)
2419 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2420 is non-zero, even if the data buffer is NULL. Fixes a crash in
2421 vertical-motion with longlines-mode. (Bug#9254)
2423 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2425 * bidi.c <bidi_cache_total_alloc>: Now static.
2426 (bidi_initialize): Initialize bidi_cache_total_alloc.
2428 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2431 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2432 amount allocated this far in `bidi_cache_total_alloc'.
2433 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2434 non-zero, only free the data buffer without restoring the cache
2435 contents. All callers changed.
2437 * dispextern.h (bidi_unshelve_cache): Update prototype.
2439 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2440 (move_it_in_display_line, move_it_to)
2441 (move_it_vertically_backward, move_it_by_lines): Replace the call
2442 to xfree to an equivalent call to bidi_unshelve_cache.
2443 (move_it_in_display_line_to): Fix logic of returning
2444 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2446 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2448 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2449 came from a string character with a `cursor' property. (Bug#9229)
2451 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2453 * Makefile.in (LIB_PTHREAD): New variable.
2454 (LIBES): Add LIB_PTHREAD (Bug#9216).
2456 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2457 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2459 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2461 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2463 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2465 * xterm.c (x_find_topmost_parent): New function.
2466 (x_set_frame_alpha): Find topmost parent window with
2467 x_find_topmost_parent and set the property there also (bug#9181).
2468 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2470 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2472 * callproc.c (Fcall_process): Avoid vfork clobbering
2473 the local vars buffer, coding_systems, current_dir.
2475 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2477 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2479 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2481 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2482 so that it is not optimized away.
2484 * xdisp.c (compute_display_string_pos): Remove unused local.
2486 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2488 Fix slow cursor motion and scrolling in large buffers with
2489 selective display, like Org Mode buffers. (Bug#9218)
2491 * dispextern.h (struct bidi_it): New member disp_prop_p.
2493 * xdisp.c: Remove one-slot cache of display string positions.
2494 (compute_display_string_pos): Accept an additional argument
2495 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2496 for a display string or property. If found, set DISP_PROP_P
2499 * bidi.c (bidi_fetch_char): Accept an additional argument
2500 DISP_PROP_P, and pass it to compute_display_string_pos.
2501 Only handle text covered by a display string if DISP_PROP_P is returned
2502 non-zero. All callers of bidi_fetch_char changed.
2504 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2506 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2508 2010-12-03 Don March <don@ohspite.net>
2510 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2511 last character M-[char] is translated to ESC [char] (bug#7541).
2513 2011-08-02 Kenichi Handa <handa@m17n.org>
2515 * lisp.h (uniprop_table): Extern it.
2517 * chartab.c (uniprop_table): Make it non-static.
2519 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2521 * xdisp.c (forward_to_next_line_start): Accept additional argument
2522 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2524 (reseat_at_next_visible_line_start): Use the bidi iterator state
2525 returned by forward_to_next_line_start to restore the state of
2526 it->bidi_it after backing up to previous newline. (Bug#9212)
2528 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2530 * regex.c (re_comp): Protoize.
2531 (re_exec): Fix return type.
2532 (regexec): Fix type of `ret'. (Bug#9203)
2534 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2536 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2537 This is needed if max-image-size is a floating-point number.
2539 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2541 * print.c (print_object): Print empty symbol as ##.
2543 * lread.c (read1): Read ## as empty symbol.
2545 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2547 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2548 setting frame foreground color (Bug#9175).
2549 (x_set_background_color): Likewise.
2551 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2552 contents (Bug#9176).
2553 (EmacsTooltip -init): Remove bezels and add shadows to
2556 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2557 or scroll bar (Bug#8470).
2559 * nsfont.m (nsfont_open): Remove assignment to voffset and
2560 unnecessary vars hshink, expand, hd, full_height, min_height.
2561 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2563 * nsterm.h (nsfont_info): Remove voffset field.
2565 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2567 Implement strike-through and overline on NextStep (Bug#8863).
2569 * nsfont.m (nsfont_open): Use underline position provided by font,
2570 instead of hard-coded value of 2.
2571 (nsfont_draw): Call ns_draw_text_decoration instead.
2573 * nsterm.h: Add declaration for ns_draw_text_decoration.
2575 * nsterm.m (ns_draw_text_decoration): New function for drawing
2576 underline, overline, and strike-through.
2577 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2578 ns_draw_text_decoration. Change treatment of cursor drawing to
2579 accommodate underlining, etc.
2581 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2583 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2586 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2588 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2589 Without this fix, if a signal arrives just after memory fills up,
2590 'malloc' might be invoked reentrantly.
2592 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2593 In other words, assume that every image size is allowed, on non-X
2594 hosts. This assumption is probably wrong, but it lets Emacs compile.
2596 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2598 * regex.c (re_iswctype): Convert return values to boolean.
2600 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2602 * xdisp.c (compute_display_string_pos): Don't use cached display
2603 string position if the buffer had its restriction changed.
2606 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2608 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2610 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2612 Integer signedness and overflow and related fixes. (Bug#9079)
2614 * bidi.c: Integer size and overflow fixes.
2615 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2616 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2617 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2618 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2619 (bidi_find_other_level_edge):
2620 Use ptrdiff_t instead of EMACS_INT where either will do.
2621 This works better on 32-bit hosts configured --with-wide-int.
2622 (bidi_cache_ensure_space): Check for size-calculation overflow.
2623 Use % rather than repeated addition, for better worst-case speed.
2624 Don't set bidi_cache_size until after xrealloc returns, because it
2626 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2627 (bidi_cache_ensure_space): Also check that the bidi cache size
2628 does not exceed that of the largest Lisp string or buffer. See Eli
2629 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2631 * alloc.c (__malloc_size_t): Remove.
2632 All uses replaced by size_t. See Andreas Schwab's note
2633 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2635 * image.c: Improve checking for integer overflow.
2636 (check_image_size): Assume that f is nonnull, since
2637 it is always nonnull in practice. This is one less thing to
2638 worry about when checking for integer overflow later.
2639 (x_check_image_size): New function, which checks for integer
2640 overflow issues inside X.
2641 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2642 This removes the need for a memory_full check.
2643 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2644 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2645 (xbm_read_bitmap_data): Change locals back to 'int', since
2646 their values must fit in 'int'.
2647 (xpm_load_image, png_load, tiff_load):
2648 Invoke x_create_x_image_and_pixmap earlier,
2649 to avoid much needless work if the image is too large.
2650 (tiff_load): Treat overly large images as if
2651 x_create_x_image_and_pixmap failed, not as malloc failures.
2652 (gs_load): Use x_check_image_size.
2654 * gtkutil.c: Omit integer casts.
2655 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2656 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2658 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2660 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2661 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2662 would wrongly return t on a 64-bit host.
2664 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2665 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2666 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2667 and therefore cause GCC to emit a bogus diagnostic in some cases.
2669 * image.c: Integer signedness and overflow and related fixes.
2670 This is not an exhaustive set of fixes, but it's time to
2671 record what I've got.
2672 (lookup_pixel_color, check_image_size): Remove redundant decls.
2673 (check_image_size): Don't assume that arbitrary EMACS_INT values
2674 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2675 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2676 (tiff_load, imagemagick_load_image):
2677 Check for overflow in size calculations.
2678 (x_create_x_image_and_pixmap): Remove unnecessary test for
2679 xmalloc returning NULL; that can't happen.
2680 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2681 (xpm_color_bucket): Use better integer hashing function.
2682 (xpm_cache_color): Don't possibly over-allocate memory.
2683 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2684 (gif_memory_source):
2685 Use ptrdiff_t, not int or size_t, to record sizes.
2686 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2687 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2688 either works, as we prefer signed integers.
2689 (tiff_read_from_memory, tiff_write_from_memory):
2690 Return tsize_t, not size_t, since that's what the TIFF API wants.
2691 (tiff_read_from_memory): Don't fail simply because the read would
2692 go past EOF; instead, return a short read.
2693 (tiff_load): Omit no-longer-needed casts.
2694 (Fimagemagick_types): Don't assume size fits into 'int'.
2696 Improve hashing quality when configured --with-wide-int.
2697 * fns.c (hash_string): New function, taken from sxhash_string.
2698 Do not discard information about ASCII character case; this
2699 discarding is no longer needed.
2700 (sxhash-string): Use it. Change sig to match it. Caller changed.
2701 * lisp.h: Declare it.
2702 * lread.c (hash_string): Remove, since we now use fns.c's version.
2703 The fns.c version returns a wider integer if --with-wide-int is
2704 specified, so this should help the quality of the hashing a bit.
2706 * emacs.c: Integer overflow minor fix.
2707 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2708 Define only if GNU_LINUX.
2709 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2711 * dispnew.c: Integer signedness and overflow fixes.
2712 Remove unnecessary forward decls, that were a maintenance hassle.
2713 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2715 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2716 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2717 (prepare_desired_row, line_draw_cost):
2718 Use int, not unsigned, where either works.
2719 (save_current_matrix, restore_current_matrix):
2720 Use ptrdiff_t, not size_t, where either works.
2721 (init_display): Check for overflow more accurately, and without
2722 relying on undefined behavior.
2724 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2725 Remove, replacing with the new symbols in lisp.h. All uses changed.
2726 * fileio.c (make_temp_name):
2727 * filelock.c (lock_file_1, lock_file):
2728 * xdisp.c (message_dolog):
2729 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2730 Use pMd etc. instead.
2731 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2732 replacing the pWIDE etc. symbols removed from editfns.c.
2734 * keyboard.h (num_input_events): Now uintmax_t.
2735 This is (very slightly) less likely to mess up due to wraparound.
2738 * buffer.c: Integer signedness fixes.
2739 (alloc_buffer_text, enlarge_buffer_text):
2740 Use ptrdiff_t rather than size_t when either will do, as we prefer
2743 * alloc.c: Integer signedness and overflow fixes.
2744 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2745 (__malloc_size_t): Default to size_t, not to int.
2746 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2747 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2748 Prefer ptrdiff_t to size_t when either would do, as we prefer
2750 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2751 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2752 Now const. Initialize with values that are in range even if char
2754 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2755 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2756 These functions do the right thing with sizes > 2**32.
2757 (check_depth): Now ptrdiff_t, not int.
2758 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2759 Adjust to new way of storing sizes. Check for size overflow bugs
2761 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2762 slightly wrong anyway, as it missed one instance of
2763 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2764 (refill_memory_reserve): Omit needless cast to size_t.
2765 (mark_object_loop_halt): Mark as externally visible.
2767 * xselect.c: Integer signedness and overflow fixes.
2768 (Fx_register_dnd_atom, x_handle_dnd_message):
2769 Use ptrdiff_t, not size_t, since we prefer signed.
2770 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2771 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2772 x_dnd_atoms_size and x_dnd_atoms_length.
2774 * doprnt.c: Prefer signed to unsigned when either works.
2776 * doprnt.c (doprnt):
2778 * xdisp.c (vmessage):
2779 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2780 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2781 prefer signed arithmetic to avoid comparison confusion.
2782 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2783 but is a bit tricky.
2785 Assume freestanding C89 headers, string.h, stdlib.h.
2786 * data.c, doprnt.c, floatfns.c, print.c:
2787 Include float.h unconditionally.
2788 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2789 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2790 * regex.c: Likewise for stddef.h, string.h.
2791 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2792 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2793 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2794 (STDC_HEADERS): Remove obsolete defines.
2795 * sysdep.c: Include limits.h unconditionally.
2797 Assume support for memcmp, memcpy, memmove, memset.
2798 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2799 * regex.c (memcmp, memcpy):
2800 Remove; we assume C89 now.
2802 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2803 (__malloc_safe_bcopy): Remove; no longer needed.
2805 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2806 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2807 well either way, and we prefer signed to unsigned.
2809 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2811 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2812 closes the connection while we're reading (bug#9182).
2814 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2816 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2817 are specified (Bug#9168).
2819 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2821 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2822 Found by GCC static checking and --with-wide-int on a 32-bit host.
2824 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2826 * xdisp.c (compute_display_string_pos): Fix logic of caching
2827 previous display string position. Initialize cached_prev_pos to
2828 -1. Fixes slow-down at the beginning of a buffer.
2830 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2832 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2833 for attrs[LFACE_FONTSET_INDEX].
2835 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2837 * xml.c (parse_region): Remove unused local
2838 that was recently introduced.
2840 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2842 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2843 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2845 * xdisp.c (move_it_in_display_line_to): Record the best matching
2846 position for TO_CHARPOS while scanning the line, and restore it on
2847 exit if none of the characters scanned was an exact match.
2848 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2849 when exact match is impossible due to invisible text, and the
2850 lines are truncated.
2852 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2854 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2857 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2859 Fix a significant slow-down of cursor motion with C-n, C-p,
2860 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2861 auto-repeat under bidi redisplay in fontified buffers.
2862 * xdisp.c (compute_stop_pos_backwards): New function.
2863 (next_element_from_buffer): Call compute_stop_pos_backwards to
2864 find a suitable prev_stop when we find ourselves before
2866 (reseat): Don't look for prev_stop, as that could mean a very long
2868 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2869 <cached_disp_overlay_modiff>: Cache for last found display string
2871 (compute_display_string_pos): Return the cached position if asked
2872 about the same buffer in the same area of character positions, and
2873 the buffer wasn't changed since the time the display string
2874 position was cached.
2876 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2878 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2879 is an integer, which is important for empty lines. (Bug#9149)
2881 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2883 * frame.c (Fmodify_frame_parameters): In tty case, update the
2884 default face if necessary (Bug#4238).
2886 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2888 * editfns.c (Fstring_to_char): No need to explain what a character
2889 is in the docstring (Bug#6576).
2891 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2893 * xml.c (parse_region): Make sure we always return a tree.
2895 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2897 * xml.c (parse_region): If a document contains only comments,
2900 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2902 * xml.c (make_dom): Return comments, too.
2904 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2907 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2908 and the surrounding thread.
2909 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2910 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2911 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2913 * s/openbsd.h (BROKEN_SIGIO): Define.
2914 * unexelf.c (unexec) [__OpenBSD__]:
2915 Don't update the .mdebug section of the Alpha COFF symbol table.
2917 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2919 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2922 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2924 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2925 This fixes some race conditions on the permissions of any newly
2928 * alloc.c (valid_pointer_p): Use pipe, not open.
2929 This fixes some permissions issues when debugging.
2931 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2932 If fchown fails to set both uid and gid, try to set just gid,
2933 as that is sometimes allowed. Adjust the file's mode to eliminate
2934 setuid or setgid bits that are inappropriate if fchown fails.
2936 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2938 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2939 to compare Lisp_Objects.
2940 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2941 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2942 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2944 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2946 * lread.c (read_integer): Unread even EOF character.
2947 (read1): Likewise. Properly record start position of symbol.
2949 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2950 symbol character follows.
2952 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2954 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2955 This works around a problem with the previous change to Fcopy_file.
2956 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2957 and without this change, GCC might complain about discarding
2958 fchown's return value.
2960 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2962 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2964 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2966 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2968 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2970 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2971 it's used from the C level.
2973 * process.c: Use the same condition for POLL_FOR_INPUT in both
2974 keyboard.c and process.c (bug#1858).
2976 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2978 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2979 (Fgnutls_boot): Use it.
2981 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2983 * doc.c (Fsubstitute_command_keys): Revert last change.
2985 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2987 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2988 quotes the next character, and doesn't affect other longer
2989 sequences (bug#8935).
2991 * lread.c (syms_of_lread): Clarify that is isn't only
2992 `eval-buffer' and `eval-defun' that's affected by
2993 `lexical-binding' (bug#8460).
2995 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2997 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2998 bidi redisplay when a line includes both an image and is truncated.
3000 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3002 Fix minor problems found by static checking.
3003 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3004 (elsz): Now a signed constant, not a size_t var. We prefer signed
3005 types to unsigned, to avoid integer comparison confusion. Without
3006 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3007 "cannot optimize loop, the loop counter may overflow", a symptom
3009 * indent.c (Fvertical_motion): Mark locals as initialized.
3010 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3012 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3014 * search.c (Fre_search_backward): Mention `case-fold-search' in
3015 all the re_search_* functions (bug#8138).
3017 * keyboard.c (Fopen_dribble_file): Document when the file is
3020 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3022 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3025 Support bidi reordering of display and overlay strings.
3026 * xdisp.c (compute_display_string_pos)
3027 (compute_display_string_end): Accept additional argument STRING.
3028 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3029 (reseat_to_string): Initialize bidi_it->string.s and
3030 bidi_it->string.schars.
3031 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3032 NULL (avoids a crash in bidi_paragraph_init).
3033 Initialize itb.string.lstring.
3034 (init_iterator): Call bidi_init_it only of a valid
3035 buffer position was specified. Initialize paragraph_embedding to
3037 (reseat_to_string): Initialize the bidi iterator.
3038 (display_string): If we need to ignore text properties of
3039 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3040 original value of -1 will not work with bidi.)
3041 (compute_display_string_pos): First arg is now struct
3042 `text_pos *'; all callers changed. Support display properties on
3044 (compute_display_string_end): Support display properties on Lisp
3046 (init_iterator, reseat_1, reseat_to_string): Initialize the
3047 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3048 when iterating on a string not from display properties).
3049 (compute_display_string_pos, compute_display_string_end):
3050 Fix calculation of the object to scan. Fixes an error when using
3052 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3053 base_level_stop; instead, set base_level_stop to BEGV.
3054 Fixes crashes in vertical-motion.
3055 (next_element_from_buffer): Improve commentary for when
3056 the iterator is before prev_stop.
3057 (init_iterator): Initialize bidi_p from the default value of
3058 bidi-display-reordering, not from buffer-local value. Use the
3059 buffer-local value only if initializing for buffer iteration.
3060 (handle_invisible_prop): Support invisible properties on strings
3061 that are being bidi-reordered.
3062 (set_iterator_to_next): Support bidi reordering of C strings and
3064 (next_element_from_string): Support bidi reordering of Lisp
3066 (handle_stop_backwards): Support Lisp strings as well.
3067 (display_string): Support display of R2L glyph rows.
3068 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3069 (init_iterator): Don't initialize it->bidi_p for strings
3071 (reseat_to_string): Initialize it->bidi_p for strings here.
3072 (next_element_from_string, next_element_from_c_string)
3073 (next_element_from_buffer): Add xassert's for correspondence
3074 between IT's object being iterated and it->bidi_it.string
3076 (face_before_or_after_it_pos): Support bidi iteration.
3077 (next_element_from_c_string): Handle the case of the first string
3078 character that is not the first one in the visual order.
3079 (get_visually_first_element): New function, refactored from common
3080 parts of next_element_from_buffer, next_element_from_string, and
3081 next_element_from_c_string.
3082 (tool_bar_lines_needed, redisplay_tool_bar)
3083 (display_menu_bar): Force left-to-right direction. Add a FIXME
3084 comment for making that be controlled by a user option.
3085 (push_it, pop_it): Save and restore the state of the
3086 bidi iterator. Save and restore the bidi_p flag.
3087 (pop_it): Iterate out of display property for string iteration as
3089 (iterate_out_of_display_property): Support iteration over strings.
3090 (handle_single_display_spec): Set up it->bidi_it for iteration
3091 over a display string, and call bidi_init_it.
3092 (handle_single_display_spec, next_overlay_string)
3093 (get_overlay_strings_1, push_display_prop): Set up the bidi
3094 iterator for displaying display or overlay strings.
3095 (forward_to_next_line_start): Don't use the shortcut if
3097 (back_to_previous_visible_line_start): If handle_display_prop
3098 pushed the iterator stack, restore the internal state of the bidi
3099 iterator by calling bidi_pop_it same number of times.
3100 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3101 and we are bidi-iterating, don't decrement the iterator position;
3102 instead, set the first_elt flag in the bidi iterator, to produce
3104 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3105 (push_display_prop): xassert that we are iterating a buffer.
3106 (push_it, pop_it): Save and restore paragraph_embedding member.
3107 (handle_single_display_spec, next_overlay_string)
3108 (get_overlay_strings_1, reseat_1, reseat_to_string)
3109 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3110 correctly. Don't assume unibyte strings are not bidi-reordered.
3111 (compute_display_string_pos)
3112 (compute_display_string_end): Fix handling the case of C string.
3113 (push_it, pop_it): Save and restore from_disp_prop_p.
3114 (handle_single_display_spec, push_display_prop): Set the
3115 from_disp_prop_p flag.
3116 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3117 (pop_it): Call iterate_out_of_display_property only if we are
3118 popping after iteration over a string that came from a display
3119 property. Fix a typo in popping stretch info. Add an assertion
3120 for verifying that the iterator position is in sync with the bidi
3122 (handle_single_display_spec, get_overlay_strings_1)
3123 (push_display_prop): Fix initialization of paragraph direction for
3124 string when that of the parent object is not yet determined.
3125 (reseat_1): Call bidi_init_it to resync the bidi
3126 iterator with IT's position. (Bug#7616)
3127 (find_row_edges): If ROW->start.pos gives position
3128 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3129 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3130 Reset the from_disp_prop_p flag.
3131 (SAVE_IT, RESTORE_IT): New macros.
3132 (pos_visible_p, face_before_or_after_it_pos)
3133 (back_to_previous_visible_line_start)
3134 (move_it_in_display_line_to, move_it_in_display_line)
3135 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3136 (try_scrolling, redisplay_window, display_line): Use them when
3137 saving a temporary copy of the iterator and restoring it back.
3138 (back_to_previous_visible_line_start, reseat_1)
3139 (init_iterator): Empty the bidi cache "stack".
3140 (move_it_in_display_line_to): If iterator ended up at
3141 EOL, but we never saw any buffer positions smaller than
3142 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3143 motion in bidi-reordered lines.
3144 (move_it_in_display_line_to): Record prev_method and prev_pos
3145 immediately before the call to set_iterator_to_next. Fixes cursor
3146 motion in bidi-reordered lines with stretch glyphs and strings
3147 displayed in margins. (Bug#8133) (Bug#8867)
3148 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3150 (pos_visible_p): Support positions in bidi-reordered lines.
3151 Save and restore bidi cache.
3153 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3154 (bidi_paragraph_info): Delete unused struct.
3155 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3156 (bidi_cache_start): New variable.
3157 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3159 (bidi_cache_fetch_state, bidi_cache_search)
3160 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3161 (bidi_cache_find, bidi_peek_at_next_level)
3162 (bidi_level_of_next_char, bidi_find_other_level_edge)
3163 (bidi_move_to_visually_next): Compare cache index with
3164 bidi_cache_start rather than with zero.
3165 (bidi_fetch_char): Accept new argument STRING; all callers
3166 changed. Support iteration over a string. Support strings with
3167 display properties. Support unibyte strings. Fix the type of
3168 `len' according to what STRING_CHAR_AND_LENGTH expects.
3169 (bidi_paragraph_init, bidi_resolve_explicit_1)
3170 (bidi_resolve_explicit, bidi_resolve_weak)
3171 (bidi_level_of_next_char, bidi_move_to_visually_next):
3172 Support iteration over a string.
3173 (bidi_set_sor_type, bidi_resolve_explicit_1)
3174 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3175 can now be zero (for strings); special values 0 and -1 were
3176 changed to -1 and -2, respectively.
3177 (bidi_char_at_pos): New function.
3178 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3179 Call it instead of FETCH_MULTIBYTE_CHAR.
3180 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3181 initialized to valid values.
3182 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3184 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3185 the test for valid cached positions. Fix the logic for looking up
3186 the sentinel state in the cache. GCPRO the Lisp string we are
3188 (bidi_push_it, bidi_pop_it): New functions.
3189 (bidi_initialize): Initialize the bidi cache start stack pointer.
3190 (bidi_cache_ensure_space): New function, refactored from part of
3191 bidi_cache_iterator_state. Don't assume the required size is just
3192 one BIDI_CACHE_CHUNK away.
3193 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3194 (bidi_count_bytes, bidi_char_at_pos): New functions.
3195 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3196 always valid if bidi_cache_idx is valid.
3197 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3198 is valid if it's going to be used.
3199 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3200 (bidi_cache_fetch_state, bidi_cache_search)
3201 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3202 (bidi_cache_iterator_state, bidi_cache_find)
3203 (bidi_find_other_level_edge, bidi_cache_start_stack):
3204 All variables related to cache indices are now EMACS_INT.
3206 * dispextern.h (struct bidi_string_data): New structure.
3207 (struct bidi_it): New member `string'. Make flag members be 1-bit
3208 fields, and put them last in the struct.
3209 (compute_display_string_pos, compute_display_string_end):
3211 (bidi_push_it, bidi_pop_it): Add prototypes.
3212 (struct iterator_stack_entry): New members bidi_p,
3213 paragraph_embedding, and from_disp_prop_p.
3214 (struct it): Member bidi_p is now a bit field 1 bit wide.
3215 (bidi_shelve_cache, bidi_unshelve_cache):
3218 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3219 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3220 and vector-like objects.
3222 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3223 cache around display iteration.
3225 * window.c (Fwindow_end, window_scroll_pixel_based)
3226 (displayed_window_lines, Frecenter): Save and restore the bidi
3227 cache around display iteration.
3229 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3231 * editfns.c (Fdelete_region): Clarify the use of the named
3232 parameters (bug#6788).
3234 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3236 * indent.c (Fvertical_motion): Set and restore w->pointm when
3237 saving and restoring the window's buffer (Bug#9006).
3239 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3241 * editfns.c (Fstring_to_char): Clarify just what is returned
3242 (bug#6576). Text by Eli Zaretskii.
3244 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3246 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3248 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3250 * buffer.c (mmap_find): Fix a typo.
3252 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3254 Fix execution of x selection hooks.
3255 * xselect.c (Qx_lost_selection_functions)
3256 (Qx_sent_selection_functions): New vars.
3257 (syms_of_xselect): DEFSYM them.
3258 (x_handle_selection_request): Pass Qx_sent_selection_functions
3259 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3260 (x_handle_selection_clear,x_clear_frame_selections):
3261 Pass Qx_lost_selection_functions rather than
3262 Vx_lost_selection_functions to Frun_hook_with_args.
3264 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3266 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3267 The old code sometimes used this field without initializing it.
3269 * alloc.c (gc_sweep): Don't read past end of array.
3270 In theory, the old code could also have corrupted Emacs internals,
3271 though it'd be very unlikely.
3273 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3275 * character.c (Fcharacterp): Don't advertise optional ignored
3276 argument. (Bug#4026)
3278 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3280 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3283 * window.c (Fset_window_start): Doc fix (bug#4199).
3284 (Fset_window_hscroll): Ditto.
3286 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3288 Fix minor new problems caught by GCC 4.6.1.
3289 * term.c (init_tty): Remove unused local.
3290 * xsettings.c (store_monospaced_changed): Define this function only
3291 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3294 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3296 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3298 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3300 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3301 are the mini-buffer and the echo area (bug#3320).
3303 * term.c (init_tty): Remove support for supdup, c10 and perq
3304 terminals, which are no longer supported (bug#1482).
3306 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3308 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3310 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3312 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3313 for non-popups (Bug#3642).
3315 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3317 * alloc.c (reset_malloc_hooks): Protoize.
3318 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3319 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3320 * cm.c (losecursor): Likewise.
3321 * data.c (fmod): Likewise.
3322 * dispnew.c (swap_glyphs_in_rows): Likewise.
3323 * emacs.c (memory_warning_signal): Likewise.
3324 * floatfns.c (float_error): Likewise.
3325 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3326 (otf_open, font_otf_capability, generate_otf_features)
3327 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3329 * image.c (pbm_read_file): Likewise.
3330 * indent.c (string_display_width): Likewise.
3331 * intervals.c (check_for_interval, search_for_interval)
3332 (inc_interval_count, count_intervals, root_interval)
3333 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3334 * lread.c (defalias): Likewise.
3335 * ralloc.c (r_alloc_check): Likewise.
3336 * regex.c (set_image_of_range_1, set_image_of_range)
3337 (regex_grow_registers): Likewise.
3338 * sysdep.c (strerror): Likewise.
3339 * termcap.c (valid_filename_p, tprint, main): Likewise.
3340 * tparam.c (main): Likewise.
3341 * unexhp9k800.c (run_time_remap, save_data_space)
3342 (update_file_ptrs, read_header, write_header, calculate_checksum)
3343 (copy_file, copy_rest, display_header): Likewise.
3344 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3346 * xdisp.c (check_it): Likewise.
3347 * xfaces.c (register_color, unregister_color, unregister_colors):
3349 * xfns.c (print_fontset_result): Likewise.
3350 * xrdb.c (member, fatal, main): Likewise.
3352 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3354 Fix minor problems found by static checking (Bug#9031).
3355 * chartab.c (char_table_set_range, map_sub_char_table):
3356 Remove unused locals.
3357 (uniprop_table): Now static.
3358 * composite.c (_work_char): Remove unused static var.
3360 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3362 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3364 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3366 * gtkutil.c (qttip_cb): Remove code without function.
3368 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3370 * w32.c (pthread_sigmask): New stub.
3372 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3374 Use pthread_sigmask, not sigprocmask (Bug#9010).
3375 sigprocmask is portable only for single-threaded applications, and
3376 Emacs can be multi-threaded when it uses GTK.
3377 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3379 * callproc.c (Fcall_process):
3380 * process.c (create_process):
3381 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3382 Use pthread_sigmask, not sigprocmask.
3384 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3386 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3387 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3390 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3392 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3393 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3394 (xg_hide_tooltip): Fix comment.
3396 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3397 in registerServicesMenuSendTypes.
3398 (validRequestorForSendType): Don't check ns_return_types.
3400 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3403 2011-07-08 Jason Rumney <jasonr@gnu.org>
3405 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3406 SH_SHOW for hidden windows (Bug#5482).
3408 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3409 frame struct members of non-existent frames (Bug#6284).
3411 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3413 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3414 variable firstTime not needed on OSX >= 10.6.
3415 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3416 >= 10.5. Use setKnobProportion, setDoubleValue.
3418 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3419 (MAC_OS_X_VERSION_10_5): Define if not defined.
3420 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3421 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3422 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3424 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3425 cString and lossyCString on OSX >= 10.4
3427 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3428 sizeToFit on OSX >= 10.2.
3430 * nsimage.m (allocInitFromFile): Don't use deprecated method
3431 bestRepresentationForDevice on OSX >= 10.6.
3433 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3436 * emacs.c: Declare unexec_init_emacs_zone.
3438 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3440 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3442 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3443 on svcsMenu (Bug#8842).
3445 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3447 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3449 * nsterm.m (QUTF8_STRING): Declare.
3450 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3451 (validRequestorForSendType): Return type is (id).
3452 Change indexOfObjectIdenticalTo to indexOfObject.
3453 Check if we have local selection before returning self (Bug#8842).
3454 (writeSelectionToPasteboard): Put local selection into paste board
3455 if we have a local selection (Bug#8842).
3456 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3458 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3459 (ns_get_local_selection): Declare.
3461 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3463 * keymap.c (describe_map_tree): Don't insert a double newline at
3464 the end of the buffer (bug#1169) and return whether we inserted
3467 * callint.c (Fcall_interactively): Change "reading args" to
3468 "providing args" to try to clarify what it does (bug#1010).
3470 2011-07-07 Kenichi Handa <handa@m17n.org>
3472 * composite.c (composition_compute_stop_pos): Ignore a static
3473 composition starting before CHARPOS (Bug#8915).
3475 * xdisp.c (handle_composition_prop): Likewise.
3477 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3479 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3482 2011-07-07 Kenichi Handa <handa@m17n.org>
3484 * character.h (unicode_category_t): New enum type.
3486 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3487 (Qchar_code_property_table): New variable.
3488 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3489 (UNIPROP_COMPRESSED_FORM_P): New macros.
3490 (char_table_ascii): Uncompress the compressed values.
3491 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3492 Uncompress the compressed values.
3493 (sub_char_table_ref_and_range): Likewise.
3494 (char_table_ref_and_range): Uncompress the compressed values.
3495 (sub_char_table_set): New arg is_uniprop. Callers changed.
3496 Uncompress the compressed values.
3497 (sub_char_table_set_range): Args changed. Callers changed.
3498 (char_table_set_range): Adjuted for the above change.
3499 (map_sub_char_table): Delete args default_val and parent. Add arg
3500 top. Give decoded values to a Lisp function.
3501 (map_char_table): Adjust for the above change. Give decoded
3502 values to a Lisp function. Gcpro more variables.
3503 (uniprop_table_uncompress)
3504 (uniprop_decode_value_run_length): New functions.
3505 (uniprop_decoder, uniprop_decoder_count): New variables.
3506 (uniprop_get_decoder, uniprop_encode_value_character)
3507 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3509 (uniprop_encoder, uniprop_encoder_count): New variables.
3510 (uniprop_get_encoder, uniprop_table)
3511 (Funicode_property_table_internal, Fget_unicode_property_internal)
3512 (Fput_unicode_property_internal): New functions.
3513 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3514 Sunicode_property_table_internal, Sget_unicode_property_internal,
3515 and Sput_unicode_property_internal. Defvar_lisp
3516 char-code-property-alist.
3518 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3519 Vunicode_category_table.
3521 * font.c (font_range): Adjust for the change of
3522 Vunicode_category_table.
3524 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3526 * m/iris4d.h: Remove file, move contents ...
3527 * s/irix6-5.h: ... here.
3529 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3531 Remove unportable assumption about struct layout (Bug#8884).
3532 * alloc.c (mark_buffer):
3533 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3534 (clone_per_buffer_values): Don't assume that
3535 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3536 This isn't true in general, and it's particularly not true
3537 if Emacs is configured with --with-wide-int.
3538 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3539 New macros, used in the buffer.c change.
3541 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3543 * xsettings.c: Use both GConf and GSettings if both are available.
3544 (store_config_changed_event): Add comment.
3545 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3546 (store_tool_bar_style_changed): New functions.
3547 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3548 (struct xsettings): Move font inside HAVE_XFT.
3549 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3550 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3551 Move inside HAVE_XFT.
3552 (something_changed_gsettingsCB): Rename from something_changedCB.
3553 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3555 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3556 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3557 (something_changed_gconfCB): Rename from something_changedCB.
3558 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3559 (parse_settings): Move check for font inside HAVE_XFT.
3560 (read_settings, apply_xft_settings): Add comment.
3561 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3562 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3563 call store_font_name_changed.
3564 (xft_settings_event): Add comment.
3565 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3566 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3567 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3568 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3569 (xsettings_initialize): Call init_gsettings last.
3570 (xsettings_get_system_font, xsettings_get_system_normal_font):
3573 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3575 Random fixes. E.g., (random) never returned negative values.
3576 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3577 subseconds part to the entropy, as that's a bit more random.
3578 Prefer signed to unsigned, since the signedness doesn't matter and
3579 in general we prefer signed. When given a limit, use a
3580 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3581 latter isn't right if USE_2_TAGS_FOR_INTS.
3582 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3583 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3585 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3587 * textprop.c (text_property_stickiness):
3588 Obey Vtext_property_default_nonsticky.
3589 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3590 * w32fns.c (syms_of_w32fns):
3591 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3593 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3595 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3596 This is more efficient than Ffile_directory_p and avoids a minor race.
3598 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3600 * buffer.c (Foverlay_put): Say what the return value is
3603 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3604 is a directory before asking whether to use the file name
3606 (barf_or_query_if_file_exists): Make the "File is a directory"
3607 error be more correct.
3609 * fns.c (Frequire): Remove the mention of the .gz files, since
3610 that's installation-specific, but keep the mention of
3611 `get-load-suffixes'.
3613 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3615 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3616 Report string overflow if the output is too long.
3618 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3620 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3621 (syms_of_gnutls): Remove duplicate DEFSYM for
3622 Qgnutls_bootprop_verify_hostname_error, an error for
3623 Qgnutls_bootprop_verify_error (which is no longer used).
3625 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3626 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3627 Also (re)move comments that are misplaced or no longer relevant.
3629 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3631 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3633 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3635 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3636 and background color parameters if they have been changed.
3638 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3640 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3642 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3644 * xsettings.c (SYSTEM_FONT): Define only when used.
3645 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3647 * keymap.c (access_keymap_1): Now static.
3649 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3651 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3652 leave any prefix arg for the up event (Bug#1586).
3654 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3656 * lread.c (syms_of_lread): Mention single symbols defined by
3657 `defvar' or `defconst' (bug#7154).
3659 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3660 (Frequire): Mention get-load-suffixes.
3662 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3664 * window.h (window): Remove clone_number slot.
3665 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3667 (make_parent_window, make_window, saved_window)
3668 (Fset_window_configuration, save_window_save): Don't deal with
3670 * buffer.c (Qclone_number): Remove declaration.
3671 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3673 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3675 Add multiple inheritance to keymaps.
3676 * keymap.c (Fmake_composed_keymap): New function.
3677 (Fset_keymap_parent): Simplify.
3678 (fix_submap_inheritance): Remove.
3679 (access_keymap_1): New function extracted from access_keymap to handle
3680 embedded parents and handle lists of maps.
3681 (access_keymap): Use it.
3682 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3683 (Fcopy_keymap): Handle embedded parents.
3684 (Fcommand_remapping, define_as_prefix): Simplify.
3685 (Fkey_binding): Simplify.
3686 (syms_of_keymap): Move minibuffer-local-completion-map,
3687 minibuffer-local-filename-completion-map,
3688 minibuffer-local-must-match-map, and
3689 minibuffer-local-filename-must-match-map to Elisp.
3690 (syms_of_keymap): Defsubr make-composed-keymap.
3691 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3692 (parse_menu_item): Trivial simplification.
3694 2011-07-01 Glenn Morris <rgm@gnu.org>
3696 * Makefile.in (SETTINGS_LIBS): Fix typo.
3698 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3700 * coding.c (Fencode_coding_string): Record the last coding system
3701 used, as the function doc string says (bug#8738).
3703 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3705 * xsettings.c (store_monospaced_changed): Take new font as arg and
3706 check for change against current_mono_font.
3707 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3708 (emacs_settings_constructor, emacs_settings_get_property)
3709 (emacs_settings_set_property, emacs_settings_class_init)
3710 (emacs_settings_init, gsettings_obj): Remove.
3711 (something_changedCB): New function for HAVE_GSETTINGS.
3712 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3713 with value as argument.
3714 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3715 g_settings_new (Bug#8967). Do not create gsettings_obj.
3716 Remove calls to g_settings_bind. Connect something_changedCB to
3719 * xgselect.c: Add defined (HAVE_GSETTINGS).
3720 (xgselect_initialize): Ditto.
3722 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3723 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3726 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3728 * eval.c (struct backtrace): Simplify and port the data structure.
3729 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3730 signed bit field, as this assumption is not portable and it makes
3731 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3732 "char debug_on_exit : 1" as this is not portable either; instead,
3733 use the portable "unsigned int debug_on_exit : 1". Remove unused
3734 member evalargs. Remove obsolete comments about cc bombing out.
3736 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3738 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3739 Let HAVE_GSETTINGS override HAVE_GCONF.
3740 (store_monospaced_changed): New function.
3741 (EMACS_SETTINGS): A new type derived from GObject to handle
3742 GSettings notifications.
3743 (emacs_settings_constructor, emacs_settings_get_property)
3744 (emacs_settings_set_property, emacs_settings_class_init):
3746 (gsettings_client, gsettings_obj): New variables.
3747 (GSETTINGS_SCHEMA): New define.
3748 (something_changedCB): Call store_monospaced_changed.
3749 (init_gsettings): New function.
3750 (xsettings_initialize): Call init_gsettings.
3751 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3754 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3757 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3759 * window.c (resize_root_window, grow_mini_window)
3760 (shrink_mini_window): Rename Qresize_root_window to
3761 Qwindow_resize_root_window and Qresize_root_window_vertically to
3762 Qwindow_resize_root_window_vertically.
3764 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3766 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3768 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3770 * makefile.w32-in: Redesign dependencies so they reflect more
3771 clearly which files are directly included by each source file,
3772 and not through other includes.
3774 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3776 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3777 (sort_overlays, overlay_strings): When an overlay's clone number
3778 matches the window's clone number process the overlay even if
3779 the overlay's window property doesn't match the current window.
3781 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3782 (Fwindow_hchild): Rename to Fwindow_left_child.
3783 (Fwindow_next): Rename to Fwindow_next_sibling.
3784 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3785 (resize_window_check): Rename to window_resize_check.
3786 (resize_window_apply): Rename to window_resize_apply.
3787 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3788 (Fdelete_other_windows_internal, resize_frame_windows)
3789 (Fsplit_window_internal, Fdelete_window_internal)
3790 (grow_mini_window, shrink_mini_window)
3791 (Fresize_mini_window_internal): Fix callers accordingly.
3793 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3795 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3796 (emacs_fixed_set_min_size): Remove.
3797 (emacs_fixed_new): Take frame as argument.
3799 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3800 (_EmacsFixedPrivate): Remove minwidth/height.
3801 Add struct frame *f.
3802 (emacs_fixed_init): Initialize priv->f.
3803 (get_parent_class, emacs_fixed_set_min_size): Remove.
3804 (emacs_fixed_new): Set priv->f to argument.
3805 (emacs_fixed_get_preferred_width)
3806 (emacs_fixed_get_preferred_height): Use min_width/height from
3807 frames size_hint to set minimum and natural (Bug#8919).
3808 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3809 and use min_width/height from frames size_hint to set
3810 min_width/height (Bug#8919).
3812 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3813 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3816 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3818 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3819 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3822 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3824 * process.c (wait_reading_process_output): Bypass select if
3825 waiting for a cell while ignoring keyboard input, and input is
3826 pending. Suggested by Jan Djärv (Bug#8869).
3828 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3830 Use gnulib's dup2 module instead of rolling our own.
3831 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3833 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3835 * dispnew.c (scrolling_window): Before scrolling, turn off a
3836 mouse-highlight in the window being scrolled.
3838 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3840 Move DEFSYM to lisp.h and use everywhere.
3842 * character.h (DEFSYM): Move declaration...
3843 * lisp.h (DEFSYM): ...here.
3849 * w32select.c: Don't include character.h.
3851 * alloc.c (syms_of_alloc):
3852 * buffer.c (syms_of_buffer):
3853 * bytecode.c (syms_of_bytecode):
3854 * callint.c (syms_of_callint):
3855 * casefiddle.c (syms_of_casefiddle):
3856 * casetab.c (init_casetab_once):
3857 * category.c (init_category_once, syms_of_category):
3858 * ccl.c (syms_of_ccl):
3859 * cmds.c (syms_of_cmds):
3860 * composite.c (syms_of_composite):
3861 * dbusbind.c (syms_of_dbusbind):
3862 * dired.c (syms_of_dired):
3863 * dispnew.c (syms_of_display):
3864 * doc.c (syms_of_doc):
3865 * editfns.c (syms_of_editfns):
3866 * emacs.c (syms_of_emacs):
3867 * eval.c (syms_of_eval):
3868 * fileio.c (syms_of_fileio):
3869 * fns.c (syms_of_fns):
3870 * frame.c (syms_of_frame):
3871 * fringe.c (syms_of_fringe):
3872 * insdel.c (syms_of_insdel):
3873 * keymap.c (syms_of_keymap):
3874 * lread.c (init_obarray, syms_of_lread):
3875 * macros.c (syms_of_macros):
3876 * msdos.c (syms_of_msdos):
3877 * print.c (syms_of_print):
3878 * process.c (syms_of_process):
3879 * search.c (syms_of_search):
3880 * sound.c (syms_of_sound):
3881 * syntax.c (init_syntax_once, syms_of_syntax):
3882 * terminal.c (syms_of_terminal):
3883 * textprop.c (syms_of_textprop):
3884 * undo.c (syms_of_undo):
3885 * w32.c (globals_of_w32):
3886 * window.c (syms_of_window):
3887 * xdisp.c (syms_of_xdisp):
3888 * xfaces.c (syms_of_xfaces):
3889 * xfns.c (syms_of_xfns):
3890 * xmenu.c (syms_of_xmenu):
3891 * xsettings.c (syms_of_xsettings):
3892 * xterm.c (syms_of_xterm): Use DEFSYM.
3894 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3896 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3898 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3900 Integer and buffer overflow fixes (Bug#8873).
3902 * print.c (printchar, strout): Check for string overflow.
3903 (PRINTPREPARE, printchar, strout):
3904 Don't set size unless allocation succeeds.
3906 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3907 for sizes. Check for string overflow more accurately.
3908 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3910 * macros.c: Integer and buffer overflow fixes.
3911 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3912 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3913 Use ptrdiff_t, not int, for sizes.
3914 Don't increment bufsize until after realloc succeeds.
3915 Check for size-calculation overflow.
3916 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3918 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3920 * lread.c: Integer overflow fixes.
3921 (read_integer): Radix is now EMACS_INT, not int,
3922 to improve quality of diagnostics for out-of-range radices.
3923 Calculate buffer size correctly for out-of-range radices.
3924 (read1): Check for integer overflow in radices, and in
3925 read-circle numbers.
3926 (read_escape): Avoid int overflow.
3927 (Fload, openp, read_buffer_size, read1)
3928 (substitute_object_recurse, read_vector, read_list, map_obarray):
3929 Use ptrdiff_t, not int, for sizes.
3930 (read1): Use EMACS_INT, not int, for sizes.
3931 Check for size overflow.
3933 * image.c (cache_image): Check for size arithmetic overflow.
3935 * lread.c: Integer overflow issues.
3936 (saved_doc_string_size, saved_doc_string_length)
3937 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3938 Now ptrdiff_t, not int.
3939 (read1): Don't assume doc string length fits in int. Check for
3940 out-of-range doc string lengths.
3941 (read_list): Don't assume file position fits in int.
3942 (read_escape): Check for hex character overflow.
3944 2011-06-22 Leo Liu <sdl.web@gmail.com>
3946 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3947 Move to minibuffer.el.
3949 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3951 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3952 The following patches are for when GLYPH_DEBUG && !XASSERT.
3953 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3954 * dispnew.c (flush_stdout):
3955 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3956 Mark as externally visible.
3957 * dispnew.c (check_window_matrix_pointers): Now static.
3958 * dispnew.c (window_to_frame_vpos):
3959 * xfns.c (unwind_create_frame):
3960 * xterm.c (x_check_font): Remove unused local.
3961 * scroll.c (CHECK_BOUNDS):
3962 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3963 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3964 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3965 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3966 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3968 (debug_method_add): Use va_list and vsprintf rather than relying
3969 on undefined behavior with wrong number of arguments.
3970 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3971 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3972 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3973 since we're not interested in debugging glyphs with old libraries.
3974 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3975 GCC 4.6.0's static checking.
3977 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3979 Integer overflow and signedness fixes (Bug#8873).
3980 A few related buffer overrun fixes, too.
3982 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3984 * dispextern.h (struct face.stipple):
3985 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3986 (x_bitmap_mask, x_allocate_bitmap_record)
3987 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3988 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3989 (x_create_bitmap_from_xpm_data):
3990 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3991 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3993 * xfaces.c (load_pixmap):
3994 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3995 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3996 (.bitmaps_last, struct x_output.icon_bitmap):
3997 Use ptrdiff_t, not int, for bitmap indexes.
3998 (x_allocate_bitmap_record): Check for size overflow.
3999 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4001 Use ptrdiff_t, not int, for overlay counts.
4002 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4003 * editfns.c (overlays_around, get_pos_property):
4004 * textprop.c (get_char_property_and_overlay):
4005 * xdisp.c (next_overlay_change, note_mouse_highlight):
4006 * xfaces.c (face_at_buffer_position):
4007 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4008 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4009 (Fnext_overlay_change, Fprevious_overlay_change)
4010 (mouse_face_overlay_overlaps, Foverlays_in):
4011 Use ptrdiff_t, not int, for sizes.
4012 (overlays_at, overlays_in): Check for size-calculation overflow.
4014 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4016 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4017 (x_session_initialize): Do not assume string length fits in int.
4019 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4020 This is unlikely, but can occur if DPI is outlandish.
4022 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4023 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4025 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4026 * xrdb.c (magic_file_p, search_magic_path):
4027 Omit last arg SUFFIX; it was always 0. All callers changed.
4028 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4030 * xfont.c (xfont_match): Avoid need for strlen.
4032 * xfns.c: Don't assume strlen fits in int.
4033 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4035 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4036 not unsigned long, as we prefer signed integers. All callers changed.
4037 Detect integer overflow in repeat count.
4038 (message_dolog): Don't assume print length fits in 39 bytes.
4039 (display_mode_element): Don't assume strlen fits in int.
4041 * termcap.c: Don't assume sizes fit in int and never overflow.
4042 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4043 (gobble_line): Check for size-calculation overflow.
4045 * minibuf.c (Fread_buffer):
4046 * lread.c (intern, intern_c_string):
4047 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4048 Don't assume string length fits in int.
4050 * keyboard.c (parse_tool_bar_item):
4051 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4053 * font.c: Don't assume string length fits in int.
4054 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4055 Use ptrdiff_t, not int.
4056 (font_intern_prop): Don't assume string length fits in int.
4057 Don't assume integer property fits in fixnum.
4058 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4060 * filelock.c: Fix some buffer overrun and integer overflow issues.
4061 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4062 Reformulate so as not to need the command string.
4063 Invoke gzip -cd rather than gunzip, as it's more portable.
4064 (lock_info_type, lock_file_1, lock_file):
4065 Don't assume pid_t and time_t fit in unsigned long.
4066 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4067 (current_lock_owner): Prefer signed type for sizes.
4068 Use memcpy, not strncpy, where memcpy is what is really wanted.
4069 Don't assume (via atoi) that time_t and pid_t fit in int.
4070 Check for time_t and/or pid_t out of range, e.g., via a network share.
4071 Don't alloca where an auto var works fine.
4073 * fileio.c: Fix some integer overflow issues.
4074 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4075 Don't assume string length fits in int.
4076 (directory_file_name): Don't assume string length fits in long.
4077 (make_temp_name): Don't assume pid fits in int, or that its print
4078 length is less than 20.
4080 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4082 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4084 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4086 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4087 We prefer signed integers, even for size calculations.
4089 * emacs.c: Don't assume string length fits in 'int'.
4090 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4091 (main): Don't invoke strlen when not needed.
4093 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4094 (XD_DEBUG_MESSAGE): Don't waste a byte.
4096 * callproc.c (getenv_internal_1, getenv_internal)
4098 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4100 * lread.c (invalid_syntax): Omit length argument.
4101 All uses changed. This doesn't fix a bug, but it simplifies the
4102 code away from its former Hollerith-constant appearance, and it's
4103 one less 'int' to worry about when looking at integer-overflow issues.
4104 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4106 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4107 This didn't break anything, but it didn't help either.
4108 It's confusing to put a bogus integer in a place where the actual
4109 value does not matter.
4110 (LIST_END_P): Remove unused macro and its bogus comment.
4111 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4113 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4114 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4116 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4117 We prefer signed types, and the value cannot exceed the EMACS_INT
4118 range anyway (because otherwise the length would not be representable).
4119 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4120 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4121 This avoids a GCC warning when WIDE_EMACS_INT.
4123 * indent.c (sane_tab_width): New function.
4124 (current_column, scan_for_column, Findent_to, position_indentation)
4125 (compute_motion): Use it. This is just for clarity.
4126 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4128 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4130 * lisp.h (lint_assume): New macro.
4131 * composite.c (composition_gstring_put_cache):
4132 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4134 * editfns.c, insdel.c:
4135 Omit unnecessary forward decls, to simplify future changes.
4137 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4139 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4141 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4142 Use much-faster test for byte-length change.
4143 Don't assume string byte-length fits in 'int'.
4144 Check that character arg fits in 'int'.
4145 (mapcar1): Declare byte as byte, for clarity.
4147 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4149 * fns.c (concat): Catch string overflow earlier.
4150 Do not rely on integer wraparound.
4152 * dispextern.h (struct it.overlay_strings_charpos)
4153 (struct it.selective): Now EMACS_INT, not int.
4154 * xdisp.c (forward_to_next_line_start)
4155 (back_to_previous_visible_line_start)
4156 (reseat_at_next_visible_line_start, next_element_from_buffer):
4157 Don't arbitrarily truncate the value of 'selective' to int.
4159 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4161 * composite.c: Don't truncate sizes to 'int'.
4162 (composition_gstring_p, composition_reseat_it)
4163 (composition_adjust_point): Use EMACS_INT, not int.
4164 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4165 not EMACS_UINT, for indexes.
4167 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4169 * buffer.c: Include <verify.h>.
4170 (struct sortvec.priority, struct sortstr.priority):
4171 Now EMACS_INT, not int.
4172 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4173 (struct sortstr.size, record_overlay_string)
4174 (struct sortstrlist.size, struct sortlist.used):
4175 Don't truncate size to int.
4176 (record_overlay_string): Check for size-calculation overflow.
4177 (init_buffer_once): Check at compile-time, not run-time.
4179 2011-06-22 Jim Meyering <meyering@redhat.com>
4181 Don't leak an XBM-image-sized buffer
4182 * image.c (xbm_load): Free the image buffer after using it.
4184 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4187 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4188 that Sun C diagnosed.
4189 * fns.c (secure_hash): Fix pointer signedness issue.
4190 * intervals.c (static_offset_intervals): New function.
4191 (offset_intervals): Use it.
4193 2011-06-21 Leo Liu <sdl.web@gmail.com>
4196 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4199 * fns.c (secure_hash): Rename from crypto_hash_function and change
4200 the first arg to accept symbols.
4201 (Fsecure_hash): New primitive.
4202 (syms_of_fns): New symbols.
4204 2011-06-20 Deniz Dogan <deniz@dogan.se>
4206 * process.c (Fset_process_buffer): Clarify return value in
4209 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4211 * dispnew.c (add_window_display_history): Use BVAR.
4213 * xdisp.c (debug_method_add): Use BVAR.
4214 (check_window_end, dump_glyph_matrix, dump_glyph)
4215 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4217 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4220 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4221 check till after the cache is created in init_frame_faces.
4223 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4225 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4227 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4229 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4230 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4231 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4233 Improve buffer-overflow checking (Bug#8873).
4234 * fileio.c (Finsert_file_contents):
4235 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4236 Remove the old (too-loose) buffer overflow checks.
4237 They weren't needed, since make_gap checks for buffer overflow.
4238 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4239 The old code merely checked for Emacs fixnum overflow, and relied
4240 on undefined (wraparound) behavior. The new code avoids undefined
4241 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4243 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4244 Tune. Don't use wider integers than needed. Don't use alloca.
4245 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4247 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4249 * insdel.c, lisp.h (buffer_overflow): New function.
4250 (insert_from_buffer_1, replace_range, replace_range_2):
4251 * insdel.c (make_gap_larger):
4252 * editfns.c (Finsert_char):
4253 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4255 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4257 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4259 Integer overflow and signedness fixes (Bug#8873).
4261 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4262 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4264 * fileio.c: Don't assume EMACS_INT fits in off_t.
4265 (emacs_lseek): New static function.
4266 (Finsert_file_contents, Fwrite_region): Use it.
4267 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4269 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4271 * fns.c: Don't overflow int when computing a list length.
4272 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4273 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4274 truncation on 64-bit hosts. Check for QUIT every
4275 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4276 faster and is responsive enough.
4277 (Flength): Report an error instead of overflowing an integer.
4278 (Fsafe_length): Return a float if the value is not representable
4279 as a fixnum. This shouldn't happen except in contrived situations.
4280 (Fnthcdr, Fsort): Don't assume list length fits in int.
4281 (Fcopy_sequence): Don't assume vector length fits in int.
4283 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4284 (header_size, word_size): New constants.
4285 (allocate_vectorlike): Don't check size overflow here.
4286 (allocate_vector): Check it here instead, since this is the only
4287 caller of allocate_vectorlike that could cause overflow.
4288 Check that the new vector's length is representable as a fixnum.
4290 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4291 The previous code was bogus. For example, next_almost_prime (32)
4292 returned 39, which is undesirable as it is a multiple of 3; and
4293 next_almost_prime (24) returned 25, which is a multiple of 5 so
4294 why was the code bothering to check for multiples of 7?
4296 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4298 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4300 Variadic C functions now count arguments with ptrdiff_t.
4301 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4302 Back then I didn't know that the Emacs coding style prefers signed int.
4303 Also, in the meantime I found a few more instances where arguments
4304 were being counted with int, which may truncate counts on 64-bit
4305 machines, or EMACS_INT, which may be unnecessarily wide.
4306 * lisp.h (struct Lisp_Subr.function.aMANY)
4307 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4308 Arg counts are now ptrdiff_t, not size_t.
4309 All variadic functions and their callers changed accordingly.
4310 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4311 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4312 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4313 * callint.c (Fcall_interactively): Check arg count for overflow,
4314 to avoid potential buffer overrun. Use signed char, not 'int',
4315 for 'varies' array, so that we needn't bother to check its size
4316 calculation for overflow.
4317 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4318 * eval.c (apply_lambda):
4319 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4320 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4321 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4323 * callint.c (Fcall_interactively): Don't use index var as event count.
4325 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4326 * mem-limits.h (SIZE): Remove; no longer used.
4328 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4330 Remove unnecessary casts.
4331 * xterm.c (x_term_init):
4332 * xfns.c (x_set_border_pixel):
4333 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4334 These aren't needed now that we assume ANSI C.
4336 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4337 It's more likely to cause problems (due to unsigned overflow)
4340 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4342 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4344 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4346 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4348 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4350 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4352 GLYPH_CODE_FACE returns EMACS_INT, not int.
4353 * dispextern.h (merge_faces):
4354 * xfaces.c (merge_faces):
4355 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4356 Don't assume EMACS_INT fits in int.
4358 * character.h (CHAR_VALID_P): Remove unused parameter.
4359 * fontset.c, lisp.h, xdisp.c: All uses changed.
4361 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4363 * fns.c (concat): Minor tuning based on overflow analysis.
4364 This doesn't fix any bugs. Use int to hold character, instead
4365 of constantly refetching from Emacs object. Use XFASTINT, not
4366 XINT, for value known to be a character. Don't bother comparing
4367 a single byte to 0400, as it's always less.
4369 * floatfns.c (Fexpt):
4370 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4372 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4375 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4377 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4378 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4379 incorrectly succeed when S was a string, because 4294967386 was
4380 truncated before it was used.
4382 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4383 Otherwise, an out-of-range integer could cause undefined behavior
4386 * composite.c: Use int, not EMACS_INT, for characters.
4387 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4388 EMACS_INT, for values that are known to be in character range.
4389 This doesn't fix any bugs but is the usual style inside Emacs and
4390 may generate better code on 32-bit machines.
4392 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4393 This is for reasons similar to the recent CHAR_STRING fix.
4394 * charset.c (Fencode_char): Check that character arg is actually
4395 a character. Pass an int to ENCODE_CHAR.
4396 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4397 wider than 'int', as a compile-time check to prevent future regressions
4400 * character.c (char_string): Remove unnecessary casts.
4402 Make sure a 64-bit char is never passed to CHAR_STRING.
4403 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4404 by silently ignoring the top 32 bits, allowing some values
4405 that were far too large to be valid characters.
4406 * character.h: Include <verify.h>.
4407 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4408 arguments are no wider than unsigned, as a compile-time check
4409 to prevent future regressions in this area.
4411 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4412 (Fsubst_char_in_region):
4414 * xdisp.c (decode_mode_spec_coding):
4415 Adjust to CHAR_STRING's new requirement.
4416 * editfns.c (Finsert_char, Fsubst_char_in_region):
4417 * fns.c (concat): Check that character args are actually
4418 characters. Without this test, these functions did the wrong
4419 thing with wildly out-of-range values on 64-bit hosts.
4421 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4422 These casts should not be needed on 32-bit hosts, either.
4423 * keyboard.c (read_char):
4424 * lread.c (Fload): Remove casts to unsigned.
4426 * lisp.h (UNSIGNED_CMP): New macro.
4427 This fixes comparison bugs on 64-bit hosts.
4428 (ASCII_CHAR_P): Use it.
4429 * casefiddle.c (casify_object):
4430 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4431 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4432 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4433 * dispextern.h (FACE_FROM_ID):
4434 * keyboard.c (read_char): Use UNSIGNED_CMP.
4436 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4437 not to EMACS_INT, to avoid GCC warning.
4439 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4441 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4442 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4443 isn't needed on 32-bit machines.
4445 * buffer.c (Fgenerate_new_buffer_name):
4446 Use EMACS_INT for count, not int.
4447 (advance_to_char_boundary): Return EMACS_INT, not int.
4449 * data.c (Qcompiled_function): Now static.
4451 * window.c (window_body_lines): Now static.
4453 * image.c (gif_load): Rename local to avoid shadowing.
4455 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4456 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4457 * alloc.c (make_save_value): Integer argument is now of type
4459 (mark_object): Use ptrdiff_t, not int.
4460 * lisp.h (pD): New macro.
4461 * print.c (print_object): Use it.
4463 * alloc.c: Use EMACS_INT, not int, to count objects.
4464 (total_conses, total_markers, total_symbols, total_vector_size)
4465 (total_free_conses, total_free_markers, total_free_symbols)
4466 (total_free_floats, total_floats, total_free_intervals)
4467 (total_intervals, total_strings, total_free_strings):
4468 Now EMACS_INT, not int. All uses changed.
4469 (Fgarbage_collect): Compute overall total using a double, so that
4470 integer overflow is less likely to be a problem. Check for overflow
4471 when converting back to an integer.
4472 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4473 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4474 These were 'int' variables that could overflow on 64-bit hosts;
4475 they were never used, so remove them instead of repairing them.
4476 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4477 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4478 Previously, this ceilinged at INT_MAX, but that doesn't work on
4480 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4482 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4483 (allocate_vectorlike): Check for ptrdiff_t overflow.
4484 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4485 when a (possibly-narrower) signed value would do just as well.
4486 We prefer using signed arithmetic, to avoid comparison confusion.
4488 * alloc.c: Catch some string size overflows that we were missing.
4489 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4490 for convenience in STRING_BYTES_MAX.
4491 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4492 The definition here is exact; the one in lisp.h was approximate.
4493 (allocate_string_data): Check for string overflow. This catches
4494 some instances we weren't catching before. Also, it catches
4495 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4496 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4497 and ptrdiff_t and EMACS_INT are both 64 bits.
4499 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4500 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4501 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4503 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4505 * alloc.c (Fmake_string): Check for out-of-range init.
4507 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4509 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4511 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4513 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4514 xg_get_default_scrollbar_width.
4516 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4517 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4518 (style_changed_cb): Call update_theme_scrollbar_width and call
4519 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4520 all frames (Bug#8505).
4521 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4522 Call gtk_window_set_resizable if HAVE_GTK3.
4523 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4524 and height if HAVE_GTK3 (Bug#8505).
4525 (scroll_bar_width_for_theme): New variable.
4526 (update_theme_scrollbar_width): New function.
4527 (xg_get_default_scrollbar_width): Move code to
4528 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4529 (xg_initialize): Call update_theme_scrollbar_width.
4531 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4533 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4535 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4537 * frame.c (make_frame): Call other_buffer_safely instead of
4540 * window.c (temp_output_buffer_show): Call display_buffer with
4541 second argument Vtemp_buffer_show_specifiers and reset latter
4542 immediately after the call.
4543 (Vtemp_buffer_show_specifiers): New variable.
4544 (auto_window_vscroll_p, next_screen_context_lines)
4545 (Vscroll_preserve_screen_position): Remove leading asterisks from
4548 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4550 Fix minor problems found by GCC 4.6.0 static checking.
4551 * buffer.c (Qclone_number): Remove for now, as it's unused.
4552 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4553 (record_buffer): Remove unused local.
4554 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4555 (set_frame_buffer_list): Remove; unused.
4556 * frame.h (other_visible_frames): Remove decl.
4557 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4558 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4559 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4561 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4562 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4563 Define only if HAVE_GPM.
4564 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4565 (update_hints_inhibit): Remove; never set. All uses removed.
4566 * widgetprv.h (emacsFrameClassRec): Remove decl.
4567 * window.c (delete_deletable_window): Now returns void, since it
4568 wasn't returning anything.
4569 (compare_window_configurations): Remove unused locals.
4570 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4571 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4572 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4573 the same widths as pointers. This follows up on the 2011-05-06 patch.
4574 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4575 * xterm.h: Likewise.
4576 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4578 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4580 * makefile.w32-in: Update dependencies.
4581 (LISP_H): Add lib/intprops.h.
4583 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4585 * image.c (gif_load): Add animation frame delay to the metadata.
4586 (syms_of_image): Use DEFSYM. New symbol `delay'.
4588 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4590 * window.c (delete_deletable_window): Re-add.
4591 (Fset_window_configuration): Rewrite to handle dead buffers and
4592 consequently deletable windows.
4593 (window_tree, Fwindow_tree): Remove. Supply functionality in
4595 (compare_window_configurations): Simplify code.
4597 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4599 * image.c (imagemagick_load_image): Fix type mismatch.
4600 (Fimagemagick_types): Likewise.
4602 * window.h (replace_buffer_in_windows): Declare.
4604 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4606 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4607 Qclone_number. Remove external declaration of Qdelete_window.
4608 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4610 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4611 Run Qbuffer_list_update_hook if allowed.
4612 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4613 buffer list implementation.
4614 (other_buffer_safely): New function.
4615 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4616 calls to replace_buffer_in_windows and
4617 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4619 (record_buffer): Inhibit quitting and rewrite using quittable
4620 functions. Run Qbuffer_list_update_hook if allowed.
4621 (Frecord_buffer, Funrecord_buffer): New functions.
4622 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4623 Move switch-to-buffer to window.el.
4624 (bury-buffer): Move to window.el.
4625 (Vbuffer_list_update_hook): New variable.
4627 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4630 * window.h (resize_frame_windows): Move up in code.
4631 (Fwindow_frame): Remove EXFUN.
4632 (replace_buffer_in_all_windows): Remove prototype.
4633 (replace_buffer_in_windows_safely): Add prototype.
4635 * window.c: Declare Qdelete_window static again. Move down
4636 declaration of select_count.
4637 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4638 (Fother_window): Move to window.el.
4639 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4640 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4641 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4643 (replace_buffer_in_windows): Implement by calling
4644 Qreplace_buffer_in_windows.
4645 (replace_buffer_in_all_windows): Remove with some functionality
4646 moved into replace_buffer_in_windows_safely.
4647 (replace_buffer_in_windows_safely): New function.
4648 (select_window_norecord, select_frame_norecord): Move in front
4649 of run_window_configuration_change_hook. Remove now obsolete
4651 (Fset_window_buffer): Rewrite doc-string.
4652 Call Qrecord_window_buffer.
4653 (keys_of_window): Move binding for other-window to window.el.
4655 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4657 * dispextern.h (struct image): Replace data member, whose int_val
4658 and ptr_val fields were not used by anything, with a single
4661 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4662 (gif_clear_image, gif_load, imagemagick_load_image)
4663 (gs_clear_image, gs_load): Callers changed.
4665 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4667 * buffer.h: Include <time.h>, for time_t.
4668 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4670 Fix minor problems found by static checking.
4672 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4674 Make identifiers static if they are not used in other modules.
4675 * data.c (Qcompiled_function, Qframe, Qvector):
4676 * image.c (QimageMagick, Qsvg):
4677 * minibuf.c (Qmetadata):
4678 * window.c (resize_window_check, resize_root_window): Now static.
4679 * window.h (resize_window_check, resize_root_window): Remove decls.
4681 * window.c (window_deletion_count, delete_deletable_window):
4683 (window_body_lines): Now static.
4684 (Fdelete_other_windows_internal): Mark vars as initialized.
4685 Make sure 'resize_failed' is initialized.
4686 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4687 (resize_window_apply): Remove unused local.
4688 * window.h (delete_deletable_window): Remove decl.
4690 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4691 (imagemagick_load_image): Fix pointer signedness problem by changing
4692 last arg from unsigned char * to char *. All uses changed.
4693 Also, fix a local for similar reasons.
4694 Remove unused locals. Remove locals to avoid shadowing.
4695 (fn_rsvg_handle_free): Remove; unused.
4696 (svg_load, svg_load_image): Fix pointer signedness problem.
4697 (imagemagick_load_image): Don't use garbage pointer image_wand.
4699 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4701 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4703 * image.c (gif_load): Fix omitted cast error introduced by
4706 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4708 * window.h (resize_proportionally, orig_total_lines)
4709 (orig_top_line): Remove from window structure.
4710 (set_window_height, set_window_width, change_window_heights)
4711 (Fdelete_window): Remove prototypes.
4712 (resize_frame_windows): Remove duplicate declaration.
4714 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4716 * window.h (resize_frame_windows, resize_window_check)
4717 (delete_deletable_window, resize_root_window)
4718 (resize_frame_windows): Declare prototypes.
4720 * window.c (resize_window_apply): Make definition be "static" to
4721 match the prototype.
4723 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4725 * window.c: Remove declarations of Qwindow_size_fixed,
4726 window_min_size_1, window_min_size_2, window_min_size,
4727 size_window, window_fixed_size_p, enlarge_window, delete_window.
4728 Remove static from declaration of Qdelete_window, it's
4729 temporarily needed by Fbury_buffer.
4730 (replace_window): Don't assign orig_top_line and
4732 (Fdelete_window, delete_window): Remove. Window deletion is
4733 handled by window.el.
4734 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4735 Replace Fdelete_window calls with calls to Qdelete_window.
4736 (Fdelete_other_windows): Remove. Deleting other windows is
4737 handled by window.el.
4738 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4739 handled in window.el.
4740 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4741 Window minimum sizes are handled in window.el.
4742 (shrink_windows, size_window, set_window_height)
4743 (set_window_width, change_window_heights, window_height)
4744 (window_width, CURBEG, CURSIZE, enlarge_window)
4745 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4746 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4747 handled in window.el.
4748 (make_dummy_parent): Rename to make_parent_window and give it a
4749 second argument horflag.
4750 (make_window): Don't set resize_proportionally any more.
4751 (Fsplit_window): Remove. Windows are split in window.el.
4752 (save_restore_action, save_restore_orig_size)
4753 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4754 Resize mini windows in window.el.
4755 (grow_mini_window, shrink_mini_window): Implement by calling
4756 Qresize_root_window_vertically, resize_window_check and
4757 resize_window_apply.
4758 (saved_window, Fset_window_configuration, save_window_save):
4759 Do not handle orig_top_line, orig_total_lines, and
4760 resize_proportionally.
4761 (window_min_height, window_min_width): Move to window.el.
4762 (keys_of_window): Move bindings for delete-other-windows,
4763 split-window, delete-window and enlarge-window to window.el.
4765 * buffer.c: Temporarily extern Qdelete_window.
4766 (Fbury_buffer): Temporarily call Qdelete_window instead of
4767 Fdelete_window (Fbury_buffer will move to window.el soon).
4769 * frame.c (set_menu_bar_lines_1): Remove code handling
4770 orig_top_line and orig_total_lines.
4772 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4773 set_window_height but set heights directly.
4774 (change_frame_size_1): Use resize_frame_windows.
4776 * xdisp.c (init_xdisp): Don't use set_window_height but set
4779 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4780 Use resize_frame_windows instead of change_window_heights and run
4781 run_window_configuration_change_hook.
4783 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4784 instead of change_window_heights and run
4785 run_window_configuration_change_hook.
4787 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4789 * window.c (replace_window): Rename second argument REPLACEMENT to
4790 NEW. New third argument SETFLAG. Rewrite.
4791 (delete_window, make_dummy_parent): Call replace_window with
4793 (window_list_1): Move down in code.
4794 (run_window_configuration_change_hook): Move set_buffer part
4795 before select_frame_norecord part in order to unwind correctly.
4796 Rename count1 to count.
4797 (recombine_windows, delete_deletable_window, resize_root_window)
4798 (Fdelete_other_windows_internal)
4799 (Frun_window_configuration_change_hook, make_parent_window)
4800 (resize_window_check, resize_window_apply, Fresize_window_apply)
4801 (resize_frame_windows, Fsplit_window_internal)
4802 (Fdelete_window_internal, Fresize_mini_window_internal):
4804 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4806 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4808 * window.h (window): Add some new members to window structure -
4809 normal_lines, normal_cols, new_total, new_normal, clone_number,
4810 splits, nest, prev_buffers, next_buffers.
4811 (WINDOW_TOTAL_SIZE): Move here from window.c.
4812 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4814 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4816 (make_dummy_parent): Set new members of windows structure.
4817 (make_window): Move down in code. Handle new members of window
4819 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4820 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4821 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4822 (Fset_window_prev_buffers, Fwindow_next_buffers)
4823 (Fset_window_next_buffers, Fset_window_clone_number):
4825 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4826 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4828 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4829 Argument WINDOW can be now internal window too.
4830 (Fwindow_use_time): Move up in code.
4831 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4833 (Fset_window_configuration, saved_window)
4834 (Fcurrent_window_configuration, save_window_save): Handle new
4835 members of window structure.
4836 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4837 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4838 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4839 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4840 Qget_mru_window, Qresize_root_window,
4841 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4842 Qauto_buffer_name; staticpro them.
4844 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4846 * window.c (Fwindow_total_size, Fwindow_left_column)
4847 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4848 (Fwindow_list_1): New functions.
4849 (window_box_text_cols): Replace with window_body_cols.
4850 (Fwindow_width, Fscroll_left, Fscroll_right):
4851 Use window_body_cols instead of window_box_text_cols.
4852 (delete_window, Fset_window_configuration):
4853 Call delete_all_subwindows with window as argument.
4854 (delete_all_subwindows): Take a window as argument and not a
4856 (window_loop): Remove handling of GET_LRU_WINDOW and
4858 (Fget_lru_window, Fget_largest_window): Move to window.el.
4860 * window.h: Extern window_body_cols instead of
4861 window_box_text_cols. delete_all_subwindows now takes a
4862 Lisp_Object as argument.
4864 * indent.c (compute_motion, Fcompute_motion):
4865 Use window_body_cols instead of window_box_text_cols.
4867 * frame.c (delete_frame): Call delete_all_subwindows with root
4870 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4872 * fns.c (Fputhash): Document return value.
4874 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4876 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4878 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4880 Cons<->int and similar integer overflow fixes (Bug#8794).
4882 Check for overflow when converting integer to cons and back.
4883 * charset.c (Fdefine_charset_internal, Fdecode_char):
4884 Use cons_to_unsigned to catch overflow.
4885 (Fencode_char): Use INTEGER_TO_CONS.
4886 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4887 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4888 * data.c (long_to_cons, cons_to_long): Remove.
4889 (cons_to_unsigned, cons_to_signed): New functions.
4890 These signal an error for invalid or out-of-range values.
4891 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4892 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4893 * font.c (Ffont_variation_glyphs):
4894 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4895 * lisp.h: Include <intprops.h>.
4896 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4897 (cons_to_signed, cons_to_unsigned): New decls.
4898 (long_to_cons, cons_to_long): Remove decls.
4899 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4900 (Fprimitive_undo): Use CONS_TO_INTEGER.
4901 * xfns.c (Fx_window_property): Likewise.
4902 * xselect.c: Include <limits.h>.
4903 (x_own_selection, selection_data_to_lisp_data):
4904 Use INTEGER_TO_CONS.
4905 (x_handle_selection_request, x_handle_selection_clear)
4906 (x_get_foreign_selection, Fx_disown_selection_internal)
4907 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4908 (lisp_data_to_selection_data): Use cons_to_unsigned.
4909 (x_fill_property_data): Use cons_to_signed.
4910 Report values out of range.
4912 Check for buffer and string overflow more precisely.
4913 * buffer.h (BUF_BYTES_MAX): New macro.
4914 * lisp.h (STRING_BYTES_MAX): New macro.
4915 * alloc.c (Fmake_string):
4916 * character.c (string_escape_byte8):
4917 * coding.c (coding_alloc_by_realloc):
4918 * doprnt.c (doprnt):
4919 * editfns.c (Fformat):
4921 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4922 since they may not be the same number.
4923 * editfns.c (Finsert_char):
4924 * fileio.c (Finsert_file_contents):
4925 Likewise for BUF_BYTES_MAX.
4927 * image.c: Use ptrdiff_t, not int, for sizes.
4928 (slurp_file): Switch from int to ptrdiff_t.
4930 (slurp_file): Check that file size fits in both size_t (for
4931 malloc) and ptrdiff_t (for sanity and safety).
4933 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4934 if b->modtime has its maximal value.
4936 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4938 Don't assume time_t can fit into int.
4939 * buffer.h (struct buffer.modtime): Now time_t, not int.
4940 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4941 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4943 Minor fixes for signed vs unsigned integers.
4944 * character.h (MAYBE_UNIFY_CHAR):
4945 * charset.c (maybe_unify_char):
4946 * keyboard.c (read_char, reorder_modifiers):
4947 XINT -> XFASTINT, since the integer must be nonnegative.
4948 * ftfont.c (ftfont_spec_pattern):
4949 * keymap.c (access_keymap, silly_event_symbol_error):
4950 XUINT -> XFASTINT, since the integer must be nonnegative.
4951 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4952 since it makes no difference and we prefer signed.
4953 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4954 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4957 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4959 * window.h (Fwindow_frame): Declare.
4961 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4963 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4964 (SPARE_MEMORY): Always define.
4965 (LARGE_REQUEST): Remove.
4966 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4968 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4970 * lisp.h: Move EXFUNS for Fframe_root_window,
4971 Fframe_first_window and Fset_frame_selected_window to window.h.
4973 * window.h: Move EXFUNS for Fframe_root_window,
4974 Fframe_first_window and Fset_frame_selected_window here from
4977 * frame.c (Fwindow_frame, Fframe_first_window)
4978 (Fframe_root_window, Fframe_selected_window)
4979 (Fset_frame_selected_window): Move to window.c.
4980 (Factive_minibuffer_window): Move to minibuf.c.
4981 (Fother_visible_frames_p): New function.
4983 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4985 * window.c (decode_window, decode_any_window): Move up in code.
4986 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4987 (inhibit_frame_unsplittable): Remove unused variable.
4988 (Fwindow_buffer): Move up and rewrite doc-string.
4989 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4990 (Fwindow_prev): New functions.
4991 (Fwindow_frame): Move here from frame.c. Accept any window as
4993 (Fframe_root_window, Fframe_first_window)
4994 (Fframe_selected_window): Move here from frame.c. Accept frame
4995 or arbitrary window as argument. Update doc-strings.
4996 (Fminibuffer_window): Move up in code.
4997 (Fwindow_minibuffer_p): Move up in code and simplify.
4998 (Fset_frame_selected_window): Move here from frame.c.
5000 (Fselected_window, select_window, Fselect_window): Move up in
5001 code. Minor doc-string fixes.
5003 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5005 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5006 Do not assume that spare memory exists; that assumption is valid
5007 only if SYSTEM_MALLOC.
5008 (LARGE_REQUEST): New macro, so that the issue of large requests
5009 is separated from the issue of spare memory.
5011 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5013 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5016 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5018 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5021 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5023 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5025 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5027 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5028 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5030 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5032 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5034 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5036 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5037 (x_clipboard_manager_save): Add return value.
5038 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5040 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5041 Obey Vx_select_enable_clipboard_manager. Catch errors in
5042 x_clipboard_manager_save (Bug#8779).
5043 (Vx_select_enable_clipboard_manager): New variable.
5044 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5046 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5048 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5050 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5052 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5053 in the current matrix if keep_current_p is non-zero.
5055 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5057 * bidi.c (bidi_level_of_next_char): Fix last change.
5059 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5061 Support bidi reordering of text covered by display properties.
5063 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5064 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5065 (bidi_cache_search, bidi_cache_iterator_state)
5066 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5067 (bidi_level_of_next_char, bidi_move_to_visually_next):
5068 Support character positions inside a run of characters covered by a
5070 (bidi_paragraph_init, bidi_resolve_explicit_1)
5071 (bidi_level_of_next_char): Call bidi_fetch_char and
5072 bidi_fetch_char_advance instead of FETCH_CHAR and
5074 (bidi_init_it): Initialize new members.
5075 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5077 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5078 instead of using explicit *_CHAR codes.
5079 (bidi_resolve_explicit, bidi_resolve_weak):
5080 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5081 bidirectional text is supported only in multibyte buffers.
5082 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5083 it to initialize the frame_window_p member of struct bidi_it.
5084 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5085 (bidi_resolve_explicit, bidi_resolve_weak)
5086 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5087 bidi_it->nchars is non-positive.
5088 (bidi_level_of_next_char): Don't try to lookup the cache for the
5089 next/previous character if nothing is cached there yet, or if we
5090 were just reseat()'ed to a new position.
5092 * xdisp.c (set_cursor_from_row): Set start and stop points
5093 according to the row's direction when priming the loop that looks
5094 for the glyph on which to display cursor.
5095 (single_display_spec_intangible_p): Function deleted.
5096 (display_prop_intangible_p): Reimplement to call
5097 handle_display_spec instead of single_display_spec_intangible_p.
5098 Accept 3 additional arguments needed by handle_display_spec.
5099 This fixes incorrect cursor motion across display property with complex
5100 values: lists, `(when COND...)' forms, etc.
5101 (single_display_spec_string_p): Support property values that are
5102 lists with the argument STRING its top-level element.
5103 (display_prop_string_p): Fix the condition for processing a
5104 property that is a list to be consistent with handle_display_spec.
5105 (handle_display_spec): New function, refactored from the
5106 last portion of handle_display_prop.
5107 (compute_display_string_pos): Accept additional argument
5108 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5109 value of a `display' property is a "replacing spec".
5110 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5111 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5112 the display property, but just return a value indicating whether
5113 the display property will replace the characters it covers.
5114 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5115 frame_window_p members of struct bidi_it.
5116 (compute_display_string_pos, compute_display_string_end):
5118 (push_it): Accept second argument POSITION, where pop_it should
5119 jump to continue iteration.
5120 (reseat_1): Initialize bidi_it.disp_pos.
5122 * keyboard.c (adjust_point_for_property): Adjust the call to
5123 display_prop_intangible_p to its new signature.
5125 * dispextern.h (struct bidi_it): New member frame_window_p.
5126 (bidi_init_it): Update prototypes.
5127 (display_prop_intangible_p): Update prototype.
5128 (compute_display_string_pos, compute_display_string_end):
5130 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5133 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5135 Malloc failure behavior now depends on size of allocation.
5136 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5137 * lisp.h: Change signatures accordingly.
5138 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5139 All callers changed. (Bug#8762)
5141 * gnutls.c: Use Emacs's memory allocators.
5142 Without this change, the gnutls library would invoke malloc etc.
5143 directly, which causes problems on non-SYNC_INPUT hosts, and which
5144 runs afoul of improving memory_full behavior. (Bug#8761)
5145 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5146 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5147 xfree instead of the default malloc, realloc, free.
5148 (Fgnutls_boot): No need to check for memory allocation failure,
5149 since xmalloc does that for us.
5151 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5152 * category.c (hash_get_category_set):
5153 * ccl.c (ccl_driver):
5154 * charset.c (Fdefine_charset_internal):
5155 * charset.h (struct charset.hash_index):
5156 * composite.c (get_composition_id, gstring_lookup_cache)
5157 (composition_gstring_put_cache):
5158 * composite.h (struct composition.hash_index):
5159 * dispextern.h (struct image.hash):
5160 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5161 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5162 (hashfn_equal, hashfn_user_defined, make_hash_table)
5163 (maybe_resize_hash_table, hash_lookup, hash_put)
5164 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5165 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5166 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5167 * image.c (make_image, search_image_cache, lookup_image)
5168 (xpm_put_color_table_h):
5169 * lisp.h (struct Lisp_Hash_Table):
5170 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5171 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5172 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5173 * alloc.c (allocate_vectorlike):
5174 Check for overflow in vector size calculations.
5175 * ccl.c (ccl_driver):
5176 Check for overflow when converting EMACS_INT to int.
5177 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5178 need to be updated by these changes.
5179 * fns.c (make_hash_table, maybe_resize_hash_table):
5180 Check for integer overflow with large hash tables.
5181 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5182 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5183 (SXHASH_REDUCE): New macro.
5184 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5185 Use it instead of discarding useful hash info with large hash values.
5186 (sxhash_float): New function.
5187 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5188 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5189 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5190 Rewrite to use FIXNUM_BITS, as this simplifies things.
5191 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5192 Adjust signatures to match updated version of code.
5193 (consing_since_gc): Now EMACS_INT, since a single hash table can
5194 use more than INT_MAX bytes.
5196 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5198 Make it possible to build with GCC-4.6+ -O2 -flto.
5200 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5202 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5204 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5205 Call minibuffer-inactive-mode.
5207 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5209 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5210 Update dependencies.
5212 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5214 * data.c (init_data): Remove code for UTS, this system is not
5217 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5219 Don't force ./temacs to start in terminal mode.
5221 * frame.c (make_initial_frame): Initialize faces in all cases, not
5222 only when CANNOT_DUMP is defined.
5223 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5225 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5227 * dispnew.c (add_window_display_history): Use const for the string
5228 pointer. Remove declaration, not needed.
5230 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5232 Use 'inline', not 'INLINE'.
5233 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5234 * alloc.c, fontset.c (INLINE): Remove.
5235 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5236 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5237 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5238 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5239 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5241 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5243 Make it possible to run ./temacs.
5245 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5246 syms_of_callproc does the same thing. Remove test for
5247 "initialized", do it in the caller.
5248 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5250 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5252 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5253 (read_minibuf): Use get_minibuffer.
5254 (syms_of_minibuf): Use DEFSYM.
5255 (Qmetadata): New var.
5256 * data.c (Qbuffer): Don't make it static.
5257 (syms_of_data): Use DEFSYM.
5259 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5261 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5262 (CCL_CODE_MIN): New macro.
5264 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5266 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5268 * eval.c (Qdebug): Now static.
5269 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5270 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5271 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5273 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5275 * image.c: Various fixes to ImageMagick code comments.
5276 (Fimagemagick_types): Doc fix.
5278 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5280 Minor fixes prompted by GCC 4.6.0 warnings.
5282 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5284 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5285 (x_clipboard_manager_save_all): Move extern decl to ...
5286 * xterm.h: ... here, so that it can be checked for consistency.
5288 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5290 * xselect.c (x_clipboard_manager_save_frame)
5291 (x_clipboard_manager_save_all): New functions.
5292 (Fx_clipboard_manager_save): Lisp function deleted.
5294 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5295 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5297 * xterm.h: Update prototype.
5299 2011-05-28 William Xu <william.xwl@gmail.com>
5301 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5304 2011-05-28 Jim Meyering <meyering@redhat.com>
5306 Avoid a sign-extension bug in crypto_hash_function.
5307 * fns.c (to_uchar): Define.
5308 (crypto_hash_function): Use it to convert some newly-signed
5309 variables to unsigned, to avoid sign-extension bugs. For example,
5310 without this change, (md5 "truc") would evaluate to
5311 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5312 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5313 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5315 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5317 Integer overflow fixes.
5319 * dbusbind.c: Serial number integer overflow fixes.
5320 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5321 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5322 to hold a serial number that is too large for a fixnum.
5323 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5324 Check for serial numbers out of range. Decode any serial number
5325 that was so large that it became a float. (Bug#8722)
5327 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5328 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5329 Use XFASTINT rather than XUINT when numbers are nonnegative.
5330 (xd_append_arg, Fdbus_method_return_internal):
5331 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5332 arguments, check that Lisp number is nonnegative, rather than
5333 silently wrapping negative numbers around. (Bug#8722)
5334 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5337 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5339 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5341 ccl: add integer overflow checks
5342 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5343 (IN_INT_RANGE): New macros.
5344 (ccl_driver): Use them to check for integer overflow when
5345 decoding a CCL program. Many of the new checks are whether XINT (x)
5346 fits in int; it doesn't always, on 64-bit hosts. The new version
5347 doesn't catch all possible integer overflows, but it's an
5348 improvement. (Bug#8719)
5350 * alloc.c (make_event_array): Use XINT, not XUINT.
5351 There's no need for unsigned here.
5353 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5354 This follows up to the 2011-05-06 change that substituted uintptr_t
5355 for EMACS_INT. This case wasn't caught back then.
5357 Rework Fformat to avoid integer overflow issues.
5358 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5359 now (part of C89). Include <verify.h>.
5360 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5361 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5362 (Fformat): Avoid the prepass trying to compute sizes; it was only
5363 approximate and thus did not catch overflow reliably. Instead, walk
5364 through the format just once, formatting and computing sizes as we go,
5365 checking for integer overflow at every step, and allocating a larger
5366 buffer as needed. Keep track separately whether the format is
5367 multibyte. Keep only the most-recently calculated precision, rather
5368 than them all. Record whether each argument has been converted to
5369 string. Use EMACS_INT, not int, for byte and char and arg counts.
5370 Support field widths and precisions larger than INT_MAX. Avoid
5371 sprintf's undefined behavior with conversion specifications such as %#d
5372 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5373 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5374 formatting out-of-range floating point numbers with int
5377 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5379 * data.c: Avoid integer truncation in expressions involving floats.
5380 * data.c: Include <intprops.h>.
5381 (arith_driver): When there's an integer overflow in an expression
5382 involving floating point, convert the integers to floating point
5383 so that the resulting value does not suffer from catastrophic
5384 integer truncation. For example, on a 64-bit host (* 4
5385 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5386 Do not rely on undefined behavior after integer overflow.
5388 merge count_size_as_multibyte, parse_str_to_multibyte
5389 * character.c, character.h (count_size_as_multibyte):
5390 Rename from parse_str_to_multibyte; all uses changed.
5391 Check for integer overflow.
5392 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5393 since it's now a duplicate of the other. This is more of
5394 a character than a buffer op, so better that it's in character.c.
5395 * fns.c, print.c: Adjust to above changes.
5397 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5399 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5401 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5403 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5404 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5405 (x_clipboard_manager_save): Now static.
5406 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5408 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5409 (crypto_hash_function): Now static.
5410 Fix pointer signedness problems. Avoid unnecessary initializations.
5412 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5414 * termhooks.h (Vselection_alist): Make it terminal-local.
5416 * terminal.c (create_terminal): Initialize it.
5418 * xselect.c: Support for clipboard managers.
5419 (Vselection_alist): Move to termhooks.h as terminal-local var.
5420 (LOCAL_SELECTION): New macro.
5421 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5422 (symbol_to_x_atom): Remove gratuitous arg.
5423 (x_handle_selection_request, lisp_data_to_selection_data)
5424 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5425 (x_own_selection, x_get_local_selection, x_convert_selection):
5426 New arg, specifying work frame. Use terminal-local Vselection_alist.
5427 (some_frame_on_display): Delete unused function.
5428 (Fx_own_selection_internal, Fx_get_selection_internal)
5429 (Fx_disown_selection_internal, Fx_selection_owner_p)
5430 (Fx_selection_exists_p): New optional frame arg.
5431 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5432 (x_handle_selection_clear): Don't treat other terminals with the
5433 same keyboard specially. Use the terminal-local Vselection_alist.
5434 (x_clear_frame_selections): Use Frun_hook_with_args.
5436 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5438 * xterm.h: Add support for those atoms.
5440 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5442 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5443 (converted_selections, conversion_fail_tag): New global variables.
5444 (x_selection_request_lisp_error): Free the above.
5445 (x_get_local_selection): Remove unnecessary code.
5446 (x_reply_selection_request): Args changed; handle arbitrary array
5447 of converted selections stored in converted_selections.
5448 Separate the XChangeProperty and SelectionNotify steps.
5449 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5450 (x_convert_selection): New function.
5451 (x_handle_selection_event): Simplify.
5452 (x_get_foreign_selection): Don't ignore incoming requests while
5453 waiting for an answer; this will fail when we implement
5454 SAVE_TARGETS, and seems unnecessary anyway.
5455 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5456 (Vx_sent_selection_functions): Doc fix.
5458 2011-05-26 Leo Liu <sdl.web@gmail.com>
5460 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5462 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5464 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5466 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5467 for fringe update if it has periodic bitmap.
5468 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5469 and fringe_bitmap_periodic_p.
5471 * fringe.c (get_fringe_bitmap_data): New function.
5472 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5473 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5474 row. Mark glyph row for fringe update if periodicity changed.
5476 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5477 for fringe update unless it has periodic bitmap.
5479 2011-05-25 Kenichi Handa <handa@m17n.org>
5481 * xdisp.c (get_next_display_element): Set correct it->face_id for
5482 a static composition.
5484 2011-05-24 Leo Liu <sdl.web@gmail.com>
5487 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5489 * fns.c (crypto_hash_function, Fsha1): New function.
5490 (Fmd5): Use crypto_hash_function.
5491 (syms_of_fns): Add Ssha1.
5493 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5495 * gnutls.c: Remove unused macros.
5496 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5497 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5498 Remove macros that are defined and never used.
5499 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5501 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5503 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5504 (Fx_get_selection_internal): Minor cleanup.
5505 (Fx_own_selection_internal): Rename arguments for consistency with
5508 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5510 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5512 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5514 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5516 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5518 * dispnew.c (scrolling_window): Don't exclude the case that the
5519 last enabled row in the desired matrix touches the bottom boundary.
5521 2011-05-21 Glenn Morris <rgm@gnu.org>
5523 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5524 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5525 and add some more files.
5527 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5529 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5530 report_file_error introduced by the change from 2011-05-07.
5532 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5534 * systime.h (Time): Define only if emacs is defined.
5535 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5536 where the include path doesn't have X11/X.h by default. See
5537 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5539 2011-05-20 Kenichi Handa <handa@m17n.org>
5541 * composite.c (find_automatic_composition): Fix previous change.
5543 2011-05-20 Glenn Morris <rgm@gnu.org>
5545 * lisp.mk: New file, split from Makefile.in.
5546 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5547 (shortlisp): Remove.
5548 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5550 2011-05-19 Glenn Morris <rgm@gnu.org>
5552 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5553 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5554 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5555 (lisp): Set the order to that of loadup.el.
5556 (shortlisp): Make it a copy of $lisp.
5557 (SOME_MACHINE_LISP): Remove.
5558 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5559 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5561 2011-05-18 Kenichi Handa <handa@m17n.org>
5563 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5564 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5565 (find_automatic_composition): Mostly rewrite for efficiency.
5567 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5569 * makefile.w32-in: Update dependencies.
5571 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5573 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5574 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5576 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5578 Fix some integer overflow issues, such as string length overflow.
5580 * insdel.c (count_size_as_multibyte): Check for string overflow.
5582 * character.c (lisp_string_width): Check for string overflow.
5583 Use EMACS_INT, not int, for string indexes and lengths; in
5584 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5585 the resulting string length overflows an EMACS_INT; instead,
5586 report a string overflow if no precision given. When checking for
5587 precision exhaustion, use a check that cannot possibly have
5588 integer overflow. (Bug#8675)
5589 * character.h (lisp_string_width): Adjust to new signature.
5591 * alloc.c (string_overflow): New function.
5592 (Fmake_string): Use it. This doesn't change behavior, but saves
5593 a few bytes and will simplify future changes.
5594 * character.c (string_escape_byte8): Likewise.
5595 * lisp.h (string_overflow): New decl.
5597 Fixups, following up to the user-interface timestamp change.
5598 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5599 for UI timestamps, instead of unsigned long.
5600 * msdos.c (mouse_get_pos): Likewise.
5601 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5602 * w32gui.h (Time): Define by including "systime.h" rather than by
5603 declaring it ourselves. (Bug#8664)
5605 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5606 * image.c (clear_image_cache): Likewise.
5608 * term.c (term_mouse_position): Don't assume time_t wraparound.
5610 Be more systematic about user-interface timestamps.
5611 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5612 and sometimes 'EMACS_UINT', to represent these timestamps.
5613 This change causes it to use 'Time' uniformly, as that's what X uses.
5614 This makes the code easier to follow, and makes it easier to catch
5615 integer overflow bugs such as Bug#8664.
5616 * frame.c (Fmouse_position, Fmouse_pixel_position):
5617 Use Time, not unsigned long, for user-interface timestamps.
5618 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5619 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5620 * keyboard.h (last_event_timestamp): Likewise.
5621 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5622 * menu.h (xmenu_show): Likewise.
5623 * term.c (term_mouse_position): Likewise.
5624 * termhooks.h (struct input_event.timestamp): Likewise.
5625 (struct terminal.mouse_position_hook): Likewise.
5626 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5627 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5628 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5629 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5631 * menu.h, termhooks.h: Include "systime.h", for Time.
5633 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5634 Don't assume that the difference between two unsigned long values
5635 can fit into an integer. At this point, we know button_down_time
5636 <= event->timestamp, so the difference must be nonnegative, so
5637 there's no need to cast the result if double-click-time is
5638 nonnegative, as it should be; check that it's nonnegative, just in
5639 case. This bug is triggered when events are more than 2**31 ms
5640 apart (about 25 days). (Bug#8664)
5642 * xselect.c (last_event_timestamp): Remove duplicate decl.
5643 (x_own_selection): Remove needless cast to unsigned long.
5645 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5646 that always fit in int. Use a sentinel instead of a counter, to
5647 avoid a temp and to allay GCC's concerns about possible int overflow.
5648 * frame.h (struct frame): Use int for menu_bar_items_used
5649 instead of EMACS_INT, since it always fits in int.
5651 * menu.c (grow_menu_items): Check for int overflow.
5653 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5655 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5656 Before, the code was not consistent. These values cannot exceed
5657 2**31 - 1 so there's no need to make them unsigned.
5658 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5659 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5660 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5662 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5664 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5665 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5666 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5667 presumably because the widths might not match.
5669 * window.c (size_window): Avoid needless test at loop start.
5671 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5673 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5675 2011-05-12 Drew Adams <drew.adams@oracle.com>
5677 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5679 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5681 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5682 `width' to `bar_area_x' and `bar_area_width', respectively.
5683 (x_scroll_run): Take account of fringe background extension.
5685 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5686 Rename local vars `left' and `width' to `bar_area_x' and
5687 `bar_area_width', respectively.
5688 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5689 background extension.
5691 2011-05-10 Jim Meyering <meyering@redhat.com>
5693 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5695 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5697 * image.c (Finit_image_library): Return t for built-in image types,
5698 like pbm and xbm. (Bug#8640)
5700 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5702 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5704 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5706 * w32console.c (Fset_screen_color): Doc fix.
5707 (Fget_screen_color): New function.
5708 (syms_of_ntterm): Defsubr it.
5710 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5711 unlink the temporary file if Fcall_process didn't create it in the
5713 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5714 child process will be redirected to a file specified with `:file'.
5715 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5716 cue to call_process_cleanup not to close that handle.
5718 2011-05-07 Ben Key <bkey76@gmail.com>
5720 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5721 one of two shell specific rules, either bootstrap-temacs-CMD or
5722 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5723 to the previous implementation of the bootstrap-temacs rule.
5724 The bootstrap-temacs-CMD rule is similar to the previous
5725 implementation of the bootstrap-temacs rule except that it
5726 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5729 These changes, along with some changes to nt/configure.bat,
5730 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5731 earlier fix to add support for --cflags and --ldflags options
5732 that include quotes so that it works whether make uses cmd or
5735 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5737 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5738 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5740 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5741 a string. Handle both cases.
5742 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5743 (Fdbus_register_method): Use Qinvalid_function.
5745 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5747 * makefile.w32-in: Update dependencies.
5748 (LISP_H): Add inttypes.h and stdin.h.
5749 (PROCESS_H): Add unistd.h.
5751 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5753 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5754 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5756 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5758 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5760 * term.c (vfatal): Remove stray call to va_end.
5761 It's not needed and the C Standard doesn't allow it here anyway.
5763 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5764 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5766 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5769 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5771 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5773 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5775 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5777 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5779 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5780 * charset.c (Fdefine_charset_internal): Don't initialize
5781 charset.code_space[15]. The value was garbage, on hosts with
5782 32-bit int (Bug#8600).
5784 * lread.c (read_integer): Be more consistent with string-to-number.
5785 Use string_to_number to do the actual conversion; this avoids
5786 rounding errors and fixes some other screwups. Without this fix,
5787 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5788 (digit_to_number): Move earlier, for benefit of read_integer.
5789 Return -1 if the digit is out of range for the base, -2 if it is
5790 not a digit in any supported base. (Bug#8602)
5792 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5794 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5795 to match comment at start of function. This also removes a
5796 GCC warning about overflow in a 32+64-bit port.
5798 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5800 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5801 Reported by Stefan Monnier in
5802 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5803 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5804 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5806 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5807 (EMACS_UINTPTR): Likewise, with uintptr_t.
5809 * lisp.h: Prefer 64-bit EMACS_INT if available.
5810 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5811 on 32-bit hosts that have 64-bit int, so that they can access
5813 However, temporarily disable this change unless the temporary
5814 symbol WIDE_EMACS_INT is defined.
5816 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5818 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5819 This removes an assumption that EMACS_INT and long are the same
5820 width as pointers. The assumption is true for Emacs porting targets
5821 now, but we want to make other targets possible.
5822 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5823 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5824 In the rest of the code, change types of integers that hold casted
5825 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5826 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5827 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5828 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5829 No need to cast type when ORing.
5830 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5831 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5832 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5833 assume EMACS_INT is the same width as char *.
5834 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5835 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5836 Remove no-longer-needed casts.
5837 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5838 (xg_tool_bar_help_callback, xg_make_tool_item):
5839 Use EMACS_INTPTR to hold an integer
5840 that will be cast to void *; this can avoid a GCC warning
5841 if EMACS_INT is not the same width as void *.
5842 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5843 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5844 (current_message_1, set_message_1):
5845 Use a local to convert to proper width without a cast.
5846 * xmenu.c (dialog_selection_callback): Likewise.
5848 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5849 Also, don't assume VALBITS / RAND_BITS is less than 5,
5850 and don't rely on undefined behavior when shifting a 1 left into
5852 * lisp.h (get_random): Change signature to match.
5854 * lread.c (hash_string): Use size_t, not int, for hash computation.
5855 Normally we prefer signed values; but hashing is special, because
5856 it's better to use unsigned division on hash table sizes so that
5857 the remainder is nonnegative. Also, size_t is the natural width
5858 for hashing into memory. The previous code used 'int', which doesn't
5859 retain enough info to hash well into very large tables.
5860 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5862 * dbusbind.c: Don't possibly lose pointer info when converting.
5863 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5864 Use XPNTR rather than XHASH, so that the high-order bits of
5865 the pointer aren't lost when converting through void *.
5867 * eval.c (Fautoload): Don't double-shift a pointer.
5869 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5871 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5873 * gnutls.c (DEF_GNUTLS_FN):
5874 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5876 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5878 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5881 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5883 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5884 New version that can reserve upto 2GB of heap space.
5886 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5888 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5890 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5892 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5893 `gnutls_certificate_set_x509_key_file'.
5895 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5897 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5898 Update dependencies.
5900 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5902 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5903 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5904 Remove unused parameter `fildes'.
5905 * process.c (read_process_output, send_process): Don't pass it.
5907 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5909 Fix previous change: the library cache is defined in w32.c.
5910 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5911 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5913 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5915 Implement dynamic loading of GnuTLS on Windows.
5917 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5918 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5919 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5922 * gnutls.c (Qgnutls_dll): Define.
5923 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5924 (gnutls_*): Declare function pointers.
5925 (init_gnutls_functions): New function to initialize function pointers.
5926 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5927 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5928 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5929 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5930 (emacs_gnutls_write, emacs_gnutls_read)
5931 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5932 (Fgnutls_available_p): New function.
5933 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5934 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5935 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5937 * image.c: Include w32.h.
5938 (Vimage_type_cache): Delete.
5939 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5940 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5941 (w32_delayed_load): Move to w32.c.
5943 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5945 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5946 (w32_delayed_load): Move from image.c. When loading a library, record
5947 its filename in the :loaded-from property of the library id.
5948 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5949 Initialize and staticpro them.
5950 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5952 * process.c: Include lisp.h before w32.h, not after.
5953 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5954 instead of gnutls_record_check_pending.
5956 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5958 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5960 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5961 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5964 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5966 * xterm.c (x_set_frame_alpha): Do not set property on anything
5967 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5969 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5971 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5973 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5975 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5976 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5977 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5978 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5979 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5980 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5981 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5982 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5983 (Qgnutls_bootprop_callbacks_verify): Make static.
5985 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5987 * callproc.c: Indentation fixup.
5989 * sysdep.c (wait_for_termination_1): Make static.
5990 (wait_for_termination, interruptible_wait_for_termination):
5991 Move after wait_for_termination_1.
5993 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5995 * sysdep.c (interruptible_wait_for_termination): New function
5996 which is like wait_for_termination, but allows keyboard
5999 * callproc.c (Fcall_process): Add (:file "file") as an option for
6001 (Fcall_process_region): Ditto.
6003 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6005 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6006 rather than `XVECTOR (FOO)->size'.
6008 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6009 inttypes.h, as a gnulib replacement is used if it not available in
6012 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6014 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6015 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6016 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6018 * coding.c (coding_alloc_by_realloc): Error out if destination
6019 will grow beyond MOST_POSITIVE_FIXNUM.
6020 (decode_coding_emacs_mule): Abort if there isn't enough place in
6021 charbuf for the composition carryover bytes. Reserve an extra
6022 space for up to 2 characters produced in a loop.
6023 (decode_coding_iso_2022): Abort if there isn't enough place in
6024 charbuf for the composition carryover bytes.
6026 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6028 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6029 aborting when %lld or %lll format is passed.
6030 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6031 %llo or %llx format is passed. (Bug#8545)
6033 * window.c (window_scroll_line_based): Use a marker instead of
6034 simple variables to record original value of point. (Bug#7952)
6036 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6037 produced by %s or %c overflows available buffer space. (Bug#8545)
6039 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6041 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6042 (SIZE_MAX): Move defn after all includes, as they might #define it.
6044 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6046 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6048 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6050 * keyboard.c (Qdelayed_warnings_hook): Define.
6051 (command_loop_1): Run `delayed-warnings-hook'
6052 if Vdelayed_warnings_list is non-nil.
6053 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6054 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6056 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6058 * doprnt.c (doprnt): Don't return value smaller than the buffer
6059 size if the message was truncated. (Bug#8545).
6061 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6063 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6064 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6066 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6068 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6070 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6072 * makefile.w32-in: Update dependencies.
6074 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6076 Improve `doprnt' and its usage. (Bug#8545)
6077 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6078 `format_end'. Remove support for %l as a conversion specifier.
6079 Don't use xrealloc. Improve diagnostics when the %l size modifier
6080 is used. Update the commentary.
6082 * eval.c (verror): Simplify calculation of size_t.
6084 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6087 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6089 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6092 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6094 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6095 This makes this file independent of the recent pseudovector change.
6097 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6099 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6101 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6102 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6103 Remove unused local.
6104 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6106 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6107 GCC 4.6.0 optimizes based on type-based alias analysis.
6108 For example, if b is of type struct buffer * and v of type struct
6109 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6110 != &v->size, and therefore "v->size = 1; b->size = 2; return
6111 v->size;" must therefore return 1. This assumption is incorrect
6112 for Emacs, since it type-puns struct Lisp_Vector * with many other
6113 types. To fix this problem, this patch adds a new type struct
6114 vectorlike_header that documents the constraints on layout of vectors
6115 and pseudovectors, and helps optimizing compilers not get fooled
6116 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6117 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6118 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6120 (XSETPVECTYPE): Rewrite in terms of new macro.
6121 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6122 This is a bit clearer, and further avoids the possibility of
6123 undesirable aliasing.
6124 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6125 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6126 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6127 since Lisp_Subr is a special case (no "next" field).
6128 (ASIZE): Now uses header.size rather than size.
6129 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6130 to avoid the hassle of writing XVECTOR (foo)->header.size.
6131 (struct vectorlike_header): New type.
6132 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6133 object, to help avoid aliasing.
6134 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6135 (SUBRP): Likewise, since Lisp_Subr is a special case.
6136 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6137 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6138 (struct Lisp_Hash_Table): Combine first two members into a single
6139 struct vectorlike_header member. All uses of "size" and "next" members
6140 changed to be "header.size" and "header.next".
6141 * buffer.h (struct buffer): Likewise.
6142 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6143 * frame.h (struct frame): Likewise.
6144 * process.h (struct Lisp_Process): Likewise.
6145 * termhooks.h (struct terminal): Likewise.
6146 * window.c (struct save_window_data, struct saved_window): Likewise.
6147 * window.h (struct window): Likewise.
6148 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6149 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6150 * buffer.c (init_buffer_once): Likewise.
6151 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6153 * process.c (Fformat_network_address): Use local var for size,
6156 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6158 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6159 * data.c (atof): Remove decl; no longer used or needed.
6160 (digit_to_number): Move to lread.c.
6161 (Fstring_to_number): Use new string_to_number function, to be
6162 consistent with how the Lisp reader treats infinities and NaNs.
6163 Do not assume that floating-point numbers represent EMACS_INT
6164 without losing information; this is not true on most 64-bit hosts.
6165 Avoid double-rounding errors, by insisting on integers when
6166 parsing non-base-10 numbers, as the documentation specifies.
6167 * lisp.h (string_to_number): New decl, replacing ...
6168 (isfloat_string): Remove.
6169 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6170 (read1): Do not accept +. and -. as integers; this
6171 appears to have been a coding error. Similarly, do not accept
6172 strings like +-1e0 as floating point numbers. Do not report
6173 overflow for integer overflows unless the base is not 10 which
6174 means we have no simple and reliable way to continue.
6175 Break out the floating-point parsing into a new
6176 function string_to_number, so that Fstring_to_number parses
6177 floating point numbers consistently with the Lisp reader.
6178 (digit_to_number): Move here from data.c. Make it static inline.
6179 (E_CHAR, EXP_INT): Remove, replacing with ...
6180 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6181 (string_to_number): New function, replacing isfloat_string.
6182 This function checks for valid syntax and produces the resulting
6183 Lisp float number too. Rework it so that string-to-number
6184 no longer mishandles examples like "1.0e+". Use strtoumax,
6185 so that overflow for non-base-10 numbers is reported only when
6186 there's no portable and simple way to convert to floating point.
6188 * textprop.c (set_text_properties_1): Rewrite for clarity,
6189 and to avoid GCC warning about integer overflow.
6191 * intervals.h (struct interval): Use EMACS_INT for members
6192 where EMACS_UINT might cause problems. See
6193 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6194 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6195 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6197 (offset_intervals): Tell GCC not to worry about length overflow
6198 when negating a negative length.
6200 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6201 (overrun_check_free): Likewise.
6203 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6204 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6207 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6208 (gnutls_make_error): Rename local to avoid shadowing.
6209 (gnutls_emacs_global_deinit): ifdef out; not used.
6210 (Fgnutls_boot): Use const for pointer to readonly storage.
6211 Comment out unused local. Fix pointer signedness problems.
6213 * lread.c (openp): Don't stuff size_t into an 'int'.
6214 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6215 about possible signed overflow.
6217 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6218 (GDK_KEY_g): Don't define if already defined.
6219 (xg_prepare_tooltip): Avoid pointer signedness problem.
6220 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6222 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6223 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6225 * xfns.c (Fx_window_property): Simplify a bit,
6226 to make a bit faster and to avoid GCC 4.6.0 warning.
6227 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6229 * fns.c (internal_equal): Don't assume size_t fits in int.
6231 * alloc.c (compact_small_strings): Tighten assertion a little.
6233 Replace pEd with more-general pI, and fix some printf arg casts.
6234 * lisp.h (pI): New macro, generalizing old pEd macro to other
6235 conversion specifiers. For example, use "...%"pI"d..." rather
6236 than "...%"pEd"...".
6237 (pEd): Remove. All uses replaced with similar uses of pI.
6238 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6239 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6240 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6241 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6242 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6243 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6244 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6246 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6247 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6248 * print.c (safe_debug_print, print_object): Likewise.
6249 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6251 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6252 avoiding the 0 flag, which is not portable.
6253 * process.c (Fmake_network_process): Use pI to avoid cast.
6254 * region-cache.c (pp_cache): Likewise.
6255 * xdisp.c (decode_mode_spec): Likewise.
6256 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6257 behavior on 64-bit hosts with printf arg.
6258 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6259 (x_stop_queuing_selection_requests): Likewise.
6260 (x_get_window_property): Don't truncate byte count to an 'int'
6263 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6264 here, since it parses constructs like leading '-' and spaces,
6265 which are not wanted; and it overflows with large numbers.
6266 Instead, simply match F[0-9]+, which is what is wanted anyway.
6268 * alloc.c: Remove unportable assumptions about struct layout.
6269 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6270 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6271 (allocate_vectorlike, make_pure_vector): Use the new macros,
6272 plus offsetof, to remove unportable assumptions about struct layout.
6273 These assumptions hold on all porting targets that I know of, but
6274 they are not guaranteed, they're easy to remove, and removing them
6275 makes further changes easier.
6277 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6278 This doesn't fix a bug but makes the code clearer.
6279 (string_overrun_cookie): Now const. Use initializers that
6280 don't formally overflow signed char, to avoid warnings.
6281 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6282 can cause Emacs to crash when string overrun checking is enabled.
6283 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6284 multiple of sizeof (EMACS_INT); it need not be, if
6285 alignof(EMACS_INT) < sizeof (EMACS_INT).
6286 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6288 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6290 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6292 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6294 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6295 supposed to be handshaking. (Bug#8556)
6296 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6298 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6300 * lisp.h (Qdebug): List symbol.
6301 * eval.c (Qdebug): Restore global linkage.
6302 * keyboard.c (debug-on-event): New variable.
6303 (handle_user_signal): Break into debugger when debug-on-event
6304 matches the current signal symbol.
6306 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6308 * alloc.c (check_sblock, check_string_bytes)
6309 (check_string_free_list): Convert to standard C.
6311 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6313 * w32.c (emacs_gnutls_push): Fix typo.
6315 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6317 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6318 "cast to pointer from integer of different size".
6320 Improve doprnt and its use in verror. (Bug#8545)
6321 * doprnt.c (doprnt): Document the set of format control sequences
6322 supported by the function. Use SAFE_ALLOCA instead of always
6325 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6326 is one byte too soon. Don't use xrealloc; instead xfree and
6329 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6331 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6334 * gnutls.c: Renamed global_initialized to
6335 gnutls_global_initialized. Added internals for the
6336 :verify-hostname-error, :verify-error, and :verify-flags
6337 parameters of `gnutls-boot' and documented those parameters in the
6338 docstring. Start callback support.
6339 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6340 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6341 on error. Return error code.
6342 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6343 (emacs_gnutls_read): Likewise.
6344 (Fgnutls_boot): Return handshake error code.
6345 (emacs_gnutls_handle_error): New function.
6346 (wsaerror_to_errno): Likewise.
6348 * w32.h (emacs_gnutls_pull): Add prototype.
6349 (emacs_gnutls_push): Likewise.
6351 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6352 (emacs_gnutls_push): Likewise.
6354 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6356 * process.c (wait_reading_process_output): Check if GnuTLS
6357 buffered some data internally if no FDs are set for TLS
6360 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6361 (LIBS): Link to USER_LIBS.
6362 ($(BLD)/gnutls.$(0)): New target.
6364 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6366 * xdisp.c (handle_single_display_spec): Rename the
6367 display_replaced_before_p argument into display_replaced_p, to
6368 make it consistent with the commentary. Fix typos in the
6371 * textprop.c (syms_of_textprop): Remove dead code.
6372 (copy_text_properties): Delete obsolete commentary about an
6373 interface that was deleted long ago. Fix typos in the description
6376 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6377 to changes in oldXMenu/XMenu.h from 2011-04-16.
6378 <menu_help_message, prev_menu_help_message>: Constify.
6379 (IT_menu_make_room): menu->help_text is now `const char **';
6382 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6383 to changes in oldXMenu/XMenu.h from 2011-04-16.
6384 (struct XMenu): Declare `help_text' `const char **'.
6386 * xfaces.c <Qunspecified>: Make extern again.
6388 * syntax.c: Include sys/types.h before including regex.h, as
6391 * doc.c (get_doc_string): Improve the format passed to `error'.
6393 * doprnt.c (doprnt): Improve commentary.
6395 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6397 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6400 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6401 changes in globals.h immediately force recompilation.
6402 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6403 $(CURDIR)/s/ms-w32.h.
6404 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6406 * character.c (Fchar_direction): Function deleted.
6407 (syms_of_character): Don't defsubr it.
6408 <char-direction-table>: Deleted.
6410 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6412 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6413 * doprnt.c: Include limits.h.
6414 (SIZE_MAX): New macro.
6415 (doprnt): Return a size_t value. 2nd arg is now size_t.
6416 Many local variables are now size_t instead of int or unsigned.
6417 Improve overflow protection. Support `l' modifier for integer
6418 conversions. Support %l conversion. Don't assume an EMACS_INT
6419 argument for integer conversions and for %c.
6421 * lisp.h (doprnt): Restore prototype.
6423 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6426 * Makefile.in (base_obj): Add back doprnt.o.
6428 * deps.mk (doprnt.o): Add back prerequisites.
6429 (callint.o): Depend on character.h.
6431 * eval.c (internal_lisp_condition_case): Include the handler
6432 representation in the error message.
6433 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6434 when breaking from the loop.
6436 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6438 * callint.c (Fcall_interactively): When displaying error message
6439 about invalid control letter, pass the character's codepoint, not
6440 a pointer to its multibyte form. Improve display of the character
6441 in octal and display also its hex code.
6443 * character.c (char_string): Use %x to display the (unsigned)
6444 codepoint of an invalid character, to avoid displaying a bogus
6447 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6448 `error', not SYMBOL_NAME itself.
6450 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6451 character arguments to `error'.
6453 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6454 to `error' in error message about FINAL_CHAR argument. Make sure
6455 FINAL_CHAR is a character, and use %c when it is passed as
6456 argument to `error'.
6458 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6460 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6462 * w32.c: Include <time.h>.
6463 (sys_localtime): New function.
6465 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6467 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6469 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6471 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6473 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6476 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6478 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6479 gl_state.e_property when gl_state.object is Qt.
6481 * insdel.c (make_gap_larger): Remove limitation of buffer size
6484 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6486 * xdisp.c (lookup_glyphless_char_display)
6487 (produce_glyphless_glyph): Handle cons cell entry in
6488 glyphless-char-display.
6489 (Vglyphless_char_display): Document it.
6491 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6492 glyphless-char-display.
6494 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6496 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6498 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6500 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6501 definition for no-X builds.
6503 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6505 Static checks with GCC 4.6.0 and non-default toolkits.
6507 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6509 * process.c (keyboard_bit_set): Define only if SIGIO.
6510 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6511 (send_process): Repair possible setjmp clobbering.
6513 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6515 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6517 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6519 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6520 Define only if needed.
6522 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6523 by pacifying GCC about it. Maybe it's time to retire it?
6524 * xfaces.c (USG, __TIMEVAL__): Likewise.
6526 * dispextern.h (struct redisplay_interface): Rename param
6528 * termhooks.h (struct terminal): Likewise.
6529 * xterm.c (xembed_send_message): Likewise.
6531 * insdel.c (make_gap_smaller): Define only if
6532 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6534 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6537 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6538 so that we aren't warned about unused symbols.
6540 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6542 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6544 * xfns.c (x_real_positions): Mark locals as initialized.
6546 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6548 * xterm.c: Fix problems found by static analysis with other toolkits.
6549 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6550 (x_dispatch_event): Declare static if USE_GTK, and
6551 define if USE_GTK || USE_X_TOOLKIT.
6552 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6553 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6554 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6555 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6557 * xmenu.c (menu_help_callback): Pointer type fixes.
6558 Use const pointers when pointing at readonly data. Avoid pointer
6560 (FALSE): Remove unused macro.
6561 (update_frame_menubar): Remove unused decl.
6563 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6565 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6566 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6567 (single_menu_item): Rename local to avoid shadowing.
6569 * keyboard.c (make_lispy_event): Remove unused local var.
6571 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6572 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6574 * bitmaps: Change bitmaps from unsigned char back to the X11
6575 compatible char. Avoid the old compiler warnings about
6576 out-of-range initializers by using, for example, '\xab' rather
6579 * xgselect.c (xgselect_initialize): Check vs interface
6580 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6582 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6584 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6585 to read-only memory.
6587 * fns.c (vector): Remove; this old hack is no longer needed.
6589 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6591 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6593 * xrdb.c (x_load_resources): Omit unused local.
6595 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6596 (x_window): Rename locals to avoid shadowing.
6597 (USG): Use the kludged USG macro, to pacify gcc.
6599 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6600 (x_term_init): Remove local to avoid shadowing.
6602 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6604 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6605 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6607 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6609 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6611 Fix regex.c, syntax.c and friends for buffers > 2GB.
6612 * syntax.h (struct gl_state_s): Declare character position members
6615 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6617 * textprop.c (verify_interval_modification, interval_of):
6618 Declare arguments EMACS_INT.
6620 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6623 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6625 * indent.c (Fvertical_motion): Local variable it_start is now
6628 * regex.c (re_match, re_match_2, re_match_2_internal)
6629 (bcmp_translate, regcomp, regexec, print_double_string)
6630 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6631 (re_compile_pattern, re_exec): Declare arguments and local
6632 variables `size_t' and `ssize_t' and return values `regoff_t', as
6634 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6635 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6636 <compile_stack_type>: `size' and `avail' are now `size_t'.
6638 * regex.h <regoff_t>: Use ssize_t, not int.
6639 (re_search, re_search_2, re_match, re_match_2): Arguments that
6640 specify buffer/string position and length are now ssize_t and
6641 size_t. Return type is regoff_t.
6643 2011-04-16 Ben Key <bkey76@gmail.com>
6645 * nsfont.m: Fixed bugs in ns_get_family and
6646 ns_descriptor_to_entity that were caused by using free to
6647 deallocate memory blocks that were allocated by xmalloc (via
6648 xstrdup). This caused Emacs to crash when compiled with
6649 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6650 --enable-checking=xmallocoverrun). xfree is now used to
6651 deallocate these memory blocks.
6653 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6655 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6657 emacs_write: Accept and return EMACS_INT for sizes.
6658 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6660 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6661 Accept and return EMACS_INT.
6662 (emacs_gnutls_write): Return the number of bytes written on
6664 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6665 (emacs_read, emacs_write): Remove check for negative size, as the
6666 Emacs source code has been audited now.
6667 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6668 (emacs_read, emacs_write): Use it.
6669 * process.c (send_process): Adjust to the new signatures of
6670 emacs_write and emacs_gnutls_write. Do not attempt to store
6671 a byte offset into an 'int'; it might overflow.
6672 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6674 * sound.c: Don't assume sizes fit in 'int'.
6675 (struct sound_device.period_size, alsa_period_size):
6676 Return EMACS_INT, not int.
6677 (struct sound_device.write, vox_write, alsa_write):
6678 Accept EMACS_INT, not int.
6679 (wav_play, au_play): Use EMACS_INT to store sizes and to
6680 record read return values.
6682 2011-04-15 Ben Key <bkey76@gmail.com>
6684 * keyboard.c (Qundefined): Don't declare static since it is used
6686 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6687 static since they are used in nsfont.m.
6689 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6691 * process.c (Qprocessp): Don't declare static.
6692 * lisp.h (Qprocessp): Declare again.
6694 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6696 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6698 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6700 Improve C-level modularity by making more things 'static'.
6702 Don't publish debugger-only interfaces to other modules.
6703 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6704 (verify_bytepos, count_markers): Move decls to the only modules
6706 * region-cache.h (pp_cache): Likewise.
6707 * window.h (check_all_windows): Likewise.
6708 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6710 * sysdep.c (croak): Now static, if
6711 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6712 * syssignal.h (croak): Declare only if not static.
6714 * alloc.c (refill_memory_reserve): Now static if
6715 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6716 * lisp.h (refill_memory_reserve): Declare only if not static.
6718 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6719 Define only if USE_LUCID.
6721 * xrdb.c (x_customization_string, x_rm_string): Now static.
6723 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6724 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6726 * xdisp.c (draw_row_with_mouse_face): Now static.
6727 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6729 * window.h (check_all_windows): Mark externally visible.
6731 * window.c (window_deletion_count): Now static.
6733 * undo.c: Make symbols static if they're not exported.
6734 (last_undo_buffer, last_boundary_position, pending_boundary):
6737 * textprop.c (interval_insert_behind_hooks): Now static.
6738 (interval_insert_in_front_hooks): Likewise.
6740 * term.c: Make symbols static if they're not exported.
6741 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6742 (max_frame_lines, tty_set_terminal_modes):
6743 (tty_reset_terminal_modes, tty_turn_off_highlight):
6744 (get_tty_terminal): Now static.
6745 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6746 * termhooks.h (term_mouse_moveto): Do not declare if
6748 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6749 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6751 * sysdep.c: Make symbols static if they're not exported.
6752 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6754 (sigprocmask_set, full_mask): Remove; unused.
6755 (wait_debugging): Mark as visible.
6756 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6757 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6759 * syntax.c (syntax_temp): Define only if !__GNUC__.
6761 * sound.c (current_sound_device, current_sound): Now static.
6763 * search.c (searchbufs, searchbuf_head): Now static.
6765 * scroll.c (scroll_cost): Remove; unused.
6766 * dispextern.h (scroll_cost): Remove decl.
6768 * region-cache.h (pp_cache): Mark as externally visible.
6770 * process.c: Make symbols static if they're not exported.
6771 (process_tick, update_tick, create_process, chan_process):
6772 (Vprocess_alist, proc_buffered_char, datagram_access):
6773 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6774 (deactivate_process): Mark defn as static, as well as decl.
6775 * lisp.h (create_process): Remove decl.
6776 * process.h (chan_process, Vprocess_alist): Remove decls.
6778 * print.c: Make symbols static if they're not exported.
6779 (print_depth, new_backquote_output, being_printed, print_buffer):
6780 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6781 (print_interval, print_number_index, initial_stderr_stream):
6783 * lisp.h (Fprinc): Remove decl.
6784 (debug_output_compilation_hack): Mark as externally visible.
6786 * sysdep.c (croak): Move decl from here to syssignal.h.
6787 * syssignal.h (croak): Put it here, so the API can be checked when
6788 'croak' is called from dissociate_if_controlling_tty.
6790 * minibuf.c: Make symbols static if they're not exported.
6791 (minibuf_save_list, choose_minibuf_frame): Now static.
6792 * lisp.h (choose_minibuf_frame): Remove decl.
6794 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6796 * lread.c: Make symbols static if they're not exported.
6797 (read_objects, initial_obarray, oblookup_last_bucket_number):
6799 (make_symbol): Remove; unused.
6800 * lisp.h (initial_obarray, make_symbol): Remove decls.
6802 * keyboard.c: Make symbols static if they're not exported.
6803 (single_kboard, recent_keys_index, total_keys, recent_keys):
6804 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6805 (this_single_command_key_start, echoing, last_auto_save):
6806 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6807 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6808 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6809 (Vlispy_mouse_stem, double_click_count):
6811 (force_auto_save_soon): Define only if SIGDANGER.
6812 (ignore_mouse_drag_p): Now static if
6813 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6814 (print_help): Remove; unused.
6815 (stop_character, last_timer_event): Mark as externally visible.
6816 * keyboard.h (ignore_mouse_drag_p): Declare only if
6817 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6818 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6819 * lisp.h (echoing): Remove decl.
6820 (force_auto_save_soon): Declare only if SIGDANGER.
6821 * xdisp.c (redisplay_window): Simplify code, to make it more
6822 obvious that ignore_mouse_drag_p is not accessed if !defined
6823 USE_GTK && !defined HAVE_NS.
6825 * intervals.c: Make symbols static if they're not exported.
6826 (merge_properties_sticky, merge_interval_right, delete_interval):
6828 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6830 * insdel.c: Make symbols static if they're not exported.
6831 However, leave prepare_to_modify_buffer alone. It's never
6832 called from outside this function, but that appears to be a bug.
6833 (combine_after_change_list, combine_after_change_buffer):
6834 (adjust_after_replace, signal_before_change): Now static.
6835 (adjust_after_replace_noundo): Remove; unused.
6836 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6837 (signal_before_change): Remove decls.
6839 * indent.c (val_compute_motion, val_vmotion): Now static.
6841 * image.c: Make symbols static if they're not exported.
6842 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6844 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6845 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6847 * fringe.c (standard_bitmaps): Now static.
6848 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6850 * frame.c: Make symbols static if they're not exported.
6851 (x_report_frame_params, make_terminal_frame): Now static.
6852 (get_frame_param): Now static, unless HAVE_NS.
6853 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6854 (x_get_resource_string): Remove; not used.
6855 * frame.h (make_terminal_frame, x_report_frame_params):
6856 (x_get_resource_string); Remove decls.
6857 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6858 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6860 * font.c, fontset.c: Make symbols static if they're not exported.
6861 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6862 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6863 * font.c (font_close_object): Now static.
6864 * font.h (font_close_object): Remove.
6865 * fontset.c (FONTSET_OBJLIST): Remove.
6866 (free_realized_fontset) #if-0 the body, which does nothing.
6867 (face_suitable_for_char_p): #if-0, as it's never called.
6868 * fontset.h (face_suitable_for_char_p): Remove decl.
6869 * xfaces.c (face_at_string_position):
6870 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6871 since 0 is always ASCII.
6873 * fns.c (weak_hash_tables): Now static.
6875 * fileio.c: Make symbols static if they're not exported.
6876 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6877 (Vwrite_region_annotation_buffers): Now static.
6879 * eval.c: Make symbols static if they're not exported.
6880 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6881 * lisp.h (backtrace_list): Remove decl.
6883 * emacs.c: Make symbols static if they're not exported.
6884 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6885 (fatal_error_code, fatal_error_signal_hook, standard_args):
6887 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6888 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6889 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6890 * lisp.h (fatal_error_signal_hook): Remove decl.
6891 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6893 * editfns.c: Move a (normally-unused) function to its only use.
6894 * editfns.c, lisp.h (get_operating_system_release): Remove.
6895 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6896 worth the hassle of breaking this out.
6898 * xterm.c: Make symbols static if they're not exported.
6899 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6900 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6901 (x_destroy_window, x_delete_display):
6903 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6904 (x_mouse_leave): Remove; unused.
6905 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6906 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6907 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6909 (x_mouse_leave): Declare only if WINDOWSNT.
6910 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6911 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6914 * ftxfont.c: Make symbols static if they're not exported.
6915 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6917 * font.h (ftxfont_driver): Likewise.
6919 * xfns.c: Make symbols static if they're not exported.
6920 (x_last_font_name, x_display_info_for_name):
6921 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6922 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6923 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6924 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6925 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6926 (last_show_tip_args): Now static.
6927 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6928 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6929 (x_screen_planes): Remove; unused.
6930 * dispextern.h (x_screen_planes): Remove decl.
6932 * dispnew.c: Make symbols static if they're not exported.
6933 * dispextern.h (redraw_garbaged_frames, scrolling):
6934 (increment_row_positions): Remove.
6935 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6936 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6938 (redraw_garbaged_frames): Remove; unused.
6940 * xfaces.c: Make symbols static if they're not exported.
6941 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6943 * xterm.h (defined_color): Remove decls.
6944 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6945 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6946 (menu_face_changed_default, defined_color, free_realized_face):
6947 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6948 (ascii_face_of_lisp_face): Remove; unused.
6950 * xdisp.c: Make symbols static if they're not exported.
6951 * dispextern.h (scratch_glyph_row, window_box_edges):
6952 (glyph_to_pixel_coords, set_cursor_from_row):
6953 (get_next_display_element, set_iterator_to_next):
6954 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6955 (show_mouse_face): Remove decls
6956 * frame.h (message_buf_print): Likewise.
6957 * lisp.h (pop_message, set_message, check_point_in_composition):
6959 * xterm.h (set_vertical_scroll_bar): Likewise.
6960 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6961 (message_buf_print, scratch_glyph_row, displayed_buffer):
6962 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6963 (get_next_display_element, show_mouse_face, window_box_edges):
6964 (frame_to_window_pixel_xy, check_point_in_composition):
6965 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6966 (glyph_to_pixel_coords): Remove; unused.
6968 * dired.c (file_name_completion): Now static.
6970 * dbusbind.c (xd_in_read_queued_messages): Now static.
6972 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6973 * data.c (circular_list_error): Remove.
6975 * commands.h (last_point_position, last_point_position_buffer):
6976 (last_point_position_window): Remove decls.
6977 * keyboard.c: Make these variables static.
6979 * coding.h (coding, code_convert_region, encode_coding_gap):
6981 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6982 (iso_code_class, detect_coding, code_convert_region): Now static.
6983 (encode_coding_gap): Remove; unused.
6985 * chartab.c (chartab_chars, chartab_bits): Now static.
6987 * charset.h (charset_iso_8859_1): Remove decl.
6988 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6991 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6992 * ccl.c (Vccl_program_table): Now static.
6993 (check_ccl_update): Remove; unused.
6995 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6996 * category.h: ... from here.
6997 * category.c (check_category_table, set_category_set): Now static.
6999 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7000 * lisp.h: Remove these decls.
7002 * buffer.c (buffer_count): Remove unused var.
7004 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7005 so that it's not optimized away.
7006 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7007 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7008 exported only to the debugger.
7010 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7011 * atimer.h (run_all_atimers): Remove; not exported.
7013 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7014 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7015 was inaccessible from Lisp.
7016 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7017 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7019 alloc.c: Import and export fewer symbols, and remove unused items.
7020 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7022 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7023 it's not optimized away by whole-program optimization.
7024 (message_enable_multibyte, free_misc): Remove.
7025 (catchlist, handlerlist, mark_backtrace):
7026 Declare only if BYTE_MARK_STACK.
7027 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7028 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7029 (message_enable_multibyte): Remove decl.
7030 (free_misc, interval_free_list, float_block, float_block_index):
7031 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7032 (cons_free_list, last_marked_index):
7034 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7035 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7036 (mark_backtrace): Define only if BYTE_MARK_STACK.
7037 * xdisp.c (message_enable_multibyte): Now static.
7039 Declare Lisp_Object Q* variables to be 'static' if not exported.
7040 This makes it easier for human readers (and static analyzers)
7041 to see whether these variables are used from other modules.
7042 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7043 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7044 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7045 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7046 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7047 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7048 * xmenu.c, xselect.c:
7049 Declare Q* vars static if they are not used in other modules.
7050 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7051 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7052 Remove decls of unexported vars.
7053 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7055 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7057 Make Emacs functions such as Fatom 'static' by default.
7058 This makes it easier for human readers (and static analyzers)
7059 to see whether these functions can be called from other modules.
7060 DEFUN now defines a static function. To make the function external
7061 so that it can be used in other C modules, use the new macro DEFUE.
7062 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7063 (Finit_image_library):
7064 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7065 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7066 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7067 Remove decls, since these functions are now static.
7068 (Funintern, Fget_internal_run_time): New decls, since these functions
7069 were already external.
7071 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7072 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7073 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7074 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7075 * keyboard.c, keymap.c, lread.c:
7076 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7077 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7078 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7079 Mark functions with DEFUE instead of DEFUN,
7080 if they are used in other modules.
7081 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7082 decls for now-static functions.
7083 * buffer.h (Fdelete_overlay): Remove decl.
7084 * callproc.c (Fgetenv_internal): Mark as internal.
7085 * composite.c (Fremove_list_of_text_properties): Remove decl.
7086 (Fcomposition_get_gstring): New forward static decl.
7087 * composite.h (Fcomposite_get_gstring): Remove decl.
7088 * dired.c (Ffile_attributes): New forward static decl.
7089 * doc.c (Fdocumntation_property): New forward static decl.
7090 * eval.c (Ffetch_bytecode): New forward static decl.
7091 (Funintern): Remove extern decl; now in .h file where it belongs.
7092 * fileio.c (Fmake_symbolic_link): New forward static decl.
7093 * image.c (Finit_image_library): New forward static decl.
7094 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7095 * intervals.h (Fprevious_property_change):
7096 (Fremove_list_of_text_properties): Remove decls.
7097 * keyboard.c (Fthis_command_keys): Remove decl.
7098 (Fcommand_execute): New forward static decl.
7099 * keymap.c (Flookup_key): New forward static decl.
7100 (Fcopy_keymap): Now static.
7101 * keymap.h (Flookup_key): Remove decl.
7102 * process.c (Fget_process): New forward static decl.
7103 (Fprocess_datagram_address): Mark as internal.
7104 * syntax.c (Fsyntax_table_p): New forward static decl.
7105 (skip_chars): Remove duplicate decl.
7106 * textprop.c (Fprevious_property_change): New forward static decl.
7107 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7109 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7110 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7112 * editfns.c (Fformat): Remove unreachable code.
7114 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7116 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7119 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7121 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7122 when at ZV. (Bug#8487)
7124 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7126 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7128 * keyboard.c (parse_tool_bar_item): Likewise.
7129 * sound.c (sound_cleanup, alsa_close): Likewise.
7130 * termcap.c (tgetent): Likewise.
7131 * xfns.c (x_default_font_parameter): Likewise.
7132 * xsettings.c (read_and_apply_settings): Likewise.
7134 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7135 (overrun_check_free): Protoize.
7137 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7139 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7140 since callers should never pass a negative size.
7141 Change the signature to match that of plain 'read' and 'write'; see
7142 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7143 * lisp.h: Update prototypes of emacs_write and emacs_read.
7145 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7147 * xdisp.c (redisplay_window): Don't try to determine the character
7148 position of the scroll margin if the window start point w->startp
7149 is outside the buffer's accessible region. (Bug#8468)
7151 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7153 Fix write-region and its subroutines for buffers > 2GB.
7154 * fileio.c (a_write, e_write): Modify declaration of arguments and
7155 local variables to support buffers larger than 2GB.
7156 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7158 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7159 argument, local variables, and return value.
7161 * lisp.h: Update prototypes of emacs_write and emacs_read.
7163 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7165 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7167 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7169 Fix more problems found by GCC 4.6.0's static checks.
7171 * xdisp.c (vmessage): Use a better test for character truncation.
7173 * charset.c (load_charset_map): <, not <=, for optimization,
7174 and to avoid potential problems with integer overflow.
7175 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7176 * casetab.c (set_identity, shuffle): Likewise.
7177 * editfns.c (Fformat): Likewise.
7178 * syntax.c (skip_chars): Likewise.
7180 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7181 This also lets GCC 4.6.0 generate slightly better loop code.
7183 * callint.c (Fcall_interactively): <, not <=, for optimization.
7184 (Fcall_interactively): Count the number of arguments produced,
7185 not the number of arguments given. This is simpler and lets GCC
7186 4.6.0 generate slightly better code.
7188 * ftfont.c: Distingish more carefully between FcChar8 and char.
7189 The previous code passed unsigned char * to a functions like
7190 strlen and xstrcasecmp that expect char *, which does not
7191 conform to the C standard.
7192 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7193 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7194 char * when the C standard requires it.
7196 * keyboard.c (read_char): Remove unused var.
7198 * eval.c: Port to Windows vsnprintf (Bug#8435).
7200 (SIZE_MAX): Define if the headers do not.
7201 (verror): Do not give up if vsnprintf returns a negative count.
7202 Instead, grow the buffer. This ports to Windows vsnprintf, which
7203 does not conform to C99. Problem reported by Eli Zaretskii.
7204 Also, simplify the allocation scheme, by avoiding the need for
7205 calling realloc, and removing the ALLOCATED variable.
7207 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7209 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7210 But keep the doprint source code for now, as we might revamp it
7211 and use it again (Bug#8435).
7212 * lisp.h (doprnt): Remove.
7213 * Makefile.in (base_obj): Remove doprnt.o.
7214 * deps.mk (doprnt.o): Remove.
7216 error: Print 32- and 64-bit integers portably (Bug#8435).
7217 Without this change, on typical 64-bit hosts error ("...%d...", N)
7218 was used to print both 32- and 64-bit integers N, which relied on
7220 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7222 * lisp.h (error, verror): Mark as printf-like functions.
7223 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7224 Report overflow in size calculations when allocating printf buffer.
7225 Do not truncate output string at its first null byte.
7226 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7227 Truncate the output at a character boundary, since vsnprintf does not
7229 * charset.c (check_iso_charset_parameter): Convert internal
7230 character to string before calling 'error', since %c now has the
7232 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7233 overflow when computing char to be passed to 'error'. Do not
7234 pass Lisp_Object to 'error'; pass the integer instead.
7235 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7236 formatted with plain %d.
7238 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7240 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7242 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7244 * xterm.c (x_catch_errors): Remove duplicate declaration.
7246 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7248 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7250 2011-04-10 Jim Meyering <meyering@redhat.com>
7252 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7253 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7254 return ssize_t not "int", and use size_t as the buffer length.
7255 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7256 * gnutls.h: Update declarations.
7257 * process.c (read_process_output): Use ssize_t, to match.
7258 (send_process): Likewise.
7260 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7262 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7264 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7266 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7267 Use unsigned char, to match FcChar8 type definition.
7269 * xterm.c (handle_one_xevent):
7270 * xmenu.c (create_and_show_popup_menu):
7271 * xselect.c (x_decline_selection_request)
7272 (x_reply_selection_request): Avoid type-punned deref of X events.
7274 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7276 Fix some uses of `int' instead of EMACS_INT.
7277 * search.c (string_match_1, fast_string_match)
7278 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7279 (scan_buffer, find_next_newline_no_quit)
7280 (find_before_next_newline, search_command, Freplace_match)
7281 (Fmatch_data): Make some `int' variables be EMACS_INT.
7283 * xdisp.c (display_count_lines): 3rd argument and return value now
7284 EMACS_INT. All callers changed.
7285 (pint2hrstr): Last argument is now EMACS_INT.
7287 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7288 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7289 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7290 (decode_coding_utf_16, decode_coding_emacs_mule)
7291 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7292 (decode_coding_ccl, decode_coding_charset)
7293 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7294 (decode_coding_iso_2022, decode_coding_emacs_mule)
7295 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7296 <char_offset, last_offset>: Declare EMACS_INT.
7297 (encode_coding_utf_8, encode_coding_utf_16)
7298 (encode_coding_emacs_mule, encode_invocation_designation)
7299 (encode_designation_at_bol, encode_coding_iso_2022)
7300 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7301 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7303 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7304 (encode_invocation_designation): Last argument P_NCHARS is now
7306 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7307 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7309 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7312 * ccl.c (Fccl_execute_on_string): Declare some variables
7315 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7317 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7319 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7321 * process.c (Fformat_network_address): Doc fix.
7323 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7325 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7327 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7329 * keyboard.c (read_char): Call Lisp function help-form-show,
7330 instead of using internal_with_output_to_temp_buffer.
7331 (Qhelp_form_show): New var.
7332 (syms_of_keyboard): Use DEFSYM macro.
7334 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7336 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7338 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7340 * process.c (Flist_processes): Remove to Lisp.
7341 (list_processes_1): Delete.
7343 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7345 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7347 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7349 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7351 Fix more problems found by GCC 4.6.0's static checks.
7353 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7355 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7357 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7359 * xdisp.c (vmessage): Mark as a printf-like function.
7361 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7363 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7365 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7366 printf-like functions.
7367 (tiff_load): Add casts to remove these marks before passing them
7368 to system-supplied API.
7370 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7372 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7373 This avoids several warnings with gcc -Wstrict-overflow.
7374 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7375 directly, rather than having caller test rule sign. This avoids
7376 some unnecessary tests.
7377 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7378 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7379 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7381 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7382 (xfont_open): Avoid unnecessary tests.
7384 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7386 * composite.h, composite.c (composition_gstring_put_cache):
7387 Use EMACS_INT, not int, for length.
7389 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7390 breaking out part of COMPOSITION_DECODE_RULE.
7391 (COMPOSITION_DECODE_RULE): Use it.
7392 * composite.c (get_composition_id): Remove unused local vars,
7393 by using the new macro.
7395 * textprop.c (set_text_properties_1): Change while to do-while,
7396 since the condition is always true at first.
7398 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7399 (interval_deletion_adjustment): Return unsigned value.
7402 * process.c (list_processes_1, create_pty, read_process_output):
7403 (exec_sentinel): Remove vars that were set but not used.
7404 (create_pty): Remove unnecessary "volatile"s.
7405 (Fnetwork_interface_info): Avoid possibility of int overflow.
7406 (read_process_output): Do adaptive read buffering even if carryover.
7407 (read_process_output): Simplify nbytes computation if buffered.
7409 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7411 * syntax.c (scan_words): Remove var that was set but not used.
7412 (update_syntax_table): Use unsigned instead of int.
7414 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7415 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7416 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7418 * print.c (print_error_message): Avoid int overflow.
7420 * font.c (font_list_entities): Redo for clarity,
7421 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7423 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7424 (font_score): Avoid potential overflow in diff calculation.
7426 * fns.c (substring_both): Remove var that is set but not used.
7427 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7429 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7431 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7432 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7433 can always succeed if overflow has undefined behavior.
7435 * search.c (boyer_moore, wordify): Remove vars set but not used.
7436 (wordify): Omit three unnecessary tests.
7438 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7439 All callers changed. This avoids the need for an unused var.
7441 * casefiddle.c (casify_region): Remove var that is set but not used.
7443 * dired.c (file_name_completion): Remove var that is set but not used.
7445 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7447 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7448 (Finsert_file_contents): Remove unnecessary code checking fd.
7450 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7451 Check for integer overflow on size calculations.
7453 * buffer.c (Fprevious_overlay_change): Remove var that is set
7456 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7457 Remove vars that are set but not used.
7458 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7459 (timer_check_2): Mark vars as initialized.
7461 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7463 * image.c (lookup_image): Remove var that is set but not used.
7464 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7466 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7467 that are set but not used.
7469 * xfns.c (make_invisible_cursor): Don't return garbage
7470 if XCreateBitmapFromData fails (Bug#8410).
7472 * xselect.c (x_get_local_selection, x_handle_property_notify):
7473 Remove vars that are set but not used.
7475 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7476 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7478 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7479 Remove var that is set but not used.
7480 (scroll_bar_windows_size): Now size_t, not int.
7481 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7484 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7485 (map_tty_color) [!defined MSDOS]: Likewise.
7487 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7489 * coding.c: Remove vars that are set but not used.
7490 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7491 All callers changed.
7492 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7493 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7494 (decode_coding_charset): Remove vars that are set but not used.
7496 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7497 that is set but not used.
7499 * print.c (print_object): Remove var that is set but not used.
7501 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7502 The gnulib version avoids calling malloc in the usual case,
7503 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7504 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7505 * filelock.c (current_lock_owner): Likewise.
7506 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7507 * sysdep.c: Include allocator.h, careadlinkat.h.
7508 (emacs_no_realloc_allocator): New static constant.
7509 (emacs_readlink): New function.
7510 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7511 ../lib/careadlinkat.h.
7513 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7515 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7516 first non-nil return value).
7518 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7520 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7521 if not defined (Bug#8403).
7523 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7525 * xdisp.c (display_count_lines): Remove parameter `start',
7526 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7527 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7528 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7529 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7530 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7531 and thereabouts. All callers changed.
7532 (get_per_char_metric): Remove parameter `f', unused since
7533 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7535 2011-04-02 Jim Meyering <meyering@redhat.com>
7537 do not dereference NULL upon failed strdup
7538 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7539 (ns_get_family): Likewise.
7541 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7543 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7545 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7547 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7550 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7552 Add lexical binding.
7554 * window.c (Ftemp_output_buffer_show): New fun.
7555 (Fsave_window_excursion):
7556 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7558 * lread.c (lisp_file_lexically_bound_p): New function.
7559 (Fload): Bind Qlexical_binding.
7560 (readevalloop): Remove `evalfun' arg.
7561 Bind Qinternal_interpreter_environment.
7562 (Feval_buffer): Bind Qlexical_binding.
7563 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7565 (syms_of_lread): Declare `lexical-binding'.
7567 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7569 * keyboard.c (eval_dyn): New fun.
7570 (menu_item_eval_property): Use it.
7572 * image.c (parse_image_spec): Use Ffunctionp.
7574 * fns.c (concat, mapcar1): Accept byte-code-functions.
7576 * eval.c (Fsetq): Handle lexical vars.
7577 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7578 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7579 (FletX, Flet): Obey lexical binding.
7580 (Fcommandp): Handle closures.
7581 (Feval): New `lexical' arg.
7582 (eval_sub): New function extracted from Feval. Use it almost
7583 everywhere where Feval was used. Look up vars in lexical env.
7585 (Ffunctionp): Move from subr.el.
7586 (Ffuncall): Handle closures.
7587 (apply_lambda): Remove `eval_flags'.
7588 (funcall_lambda): Handle closures and new byte-code-functions.
7589 (Fspecial_variable_p): New function.
7590 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7591 but without exporting it to Lisp.
7593 * doc.c (Fdocumentation, store_function_docstring):
7594 * data.c (Finteractive_form): Handle closures.
7596 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7599 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7601 (exec_byte_code): New function extracted from Fbyte_code to handle new
7602 calling convention for byte-code-functions. Add new byte-codes.
7604 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7606 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7608 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7610 * xdisp.c (redisplay_internal): Fix prototype.
7612 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7614 * xdisp.c (SCROLL_LIMIT): New macro.
7615 (try_scrolling): Use it when setting scroll_limit.
7616 Limit scrolling to 100 screen lines.
7617 (redisplay_window): Even when falling back on "recentering",
7618 position point in the window according to scroll-conservatively,
7619 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7621 (try_scrolling): When point is above the window, allow searching
7622 as far as scroll_max, or one screenful, to compute vertical
7623 distance from PT to the scroll margin position. This prevents
7624 try_scrolling from unnecessarily failing when
7625 scroll-conservatively is set to a value slightly larger than the
7626 window height. Clean up the case of PT below the margin at bottom
7627 of window: scroll_max can no longer be INT_MAX. When aggressive
7628 scrolling is in use, don't let point enter the opposite scroll
7629 margin as result of the scroll.
7630 (syms_of_xdisp) <scroll-conservatively>: Document the
7631 threshold of 100 lines for never-recentering scrolling.
7633 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7635 * dispextern.h (move_it_by_lines):
7636 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7637 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7638 (message_log_check_duplicate): Remove parameters `prev_bol' and
7639 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7640 (redisplay_internal): Remove parameter `preserve_echo_area',
7641 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7643 * indent.c (Fvertical_motion):
7644 * window.c (window_scroll_pixel_based, Frecenter):
7645 Don't pass `need_y_p' to `move_it_by_lines'.
7647 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7649 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7650 steal a few bits to be more compact.
7651 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7652 Remove unneeded casts.
7654 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7656 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7658 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7659 binding" message (bug#7967).
7661 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7663 Fix more problems found by GCC 4.6.0's static checks.
7665 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7666 Remove unused local var.
7668 * editfns.c (Fmessage_box): Remove unused local var.
7670 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7671 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7672 Omit unused local vars.
7673 * window.c (shrink_windows): Omit unused local var.
7674 * menu.c (digest_single_submenu): Omit unused local var.
7675 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7676 Omit unused local var.
7678 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7679 Don't assume string length fits in int.
7680 (keyremap_step, read_key_sequence): Use size_t for sizes.
7681 (read_key_sequence): Don't check last_real_key_start redundantly.
7683 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7684 instead of alloca (Bug#8344).
7686 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7687 (Fbacktrace_frame): Don't assume nframes fits in int.
7689 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7691 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7694 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7696 * cm.c (calccost): Turn while-do into do-while, for clarity.
7698 * keyboard.c (syms_of_keyboard): Use the same style as later
7699 in this function when indexing through an array. This also
7700 works around GCC bug 48267.
7702 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7704 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7706 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7707 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7709 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7710 This avoids undefined behavior on integer overflow, and is a bit
7711 more convenient anyway since it is compared to a size_t variable.
7713 Variadic C functions now count arguments with size_t, not int.
7714 This avoids an unnecessary limitation on 64-bit machines, which
7715 caused (substring ...) to crash on large vectors (Bug#8344).
7716 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7717 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7718 All variadic functions and their callers changed accordingly.
7719 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7720 * data.c (arith_driver, float_arith_driver): Likewise.
7721 * editfns.c (general_insert_function): Likewise.
7722 * eval.c (struct backtrace.nargs, interactive_p)
7723 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7724 (funcall_lambda, mark_backtrace): Likewise.
7725 * fns.c (concat): Likewise.
7726 * frame.c (x_set_frame_parameters): Likewise.
7727 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7728 0 if not found, not -1. All callers changed.
7730 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7731 (stack_copy_size): Now size_t, not int.
7732 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7734 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7736 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7737 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7738 All callers changed.
7740 * lisp.h (multibyte_char_to_unibyte):
7741 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7742 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7743 * character.h (CHAR_TO_BYTE8):
7744 * cmds.c (internal_self_insert):
7745 * editfns.c (general_insert_function):
7746 * keymap.c (push_key_description):
7747 * search.c (Freplace_match):
7748 * xdisp.c (message_dolog, set_message_1): All callers changed.
7750 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7752 * keyboard.c (safe_run_hook_funcall): New function.
7753 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7754 don't set the hook to nil, but remove the offending function instead.
7755 (Qcommand_hook_internal): Remove, unused.
7756 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7757 Vcommand_hook_internal.
7759 * eval.c (enum run_hooks_condition): Remove.
7760 (funcall_nil, funcall_not): New functions.
7761 (run_hook_with_args): Call each function through a `funcall' argument.
7762 Remove `cond' argument, now redundant.
7763 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7764 (Frun_hook_with_args_until_failure): Adjust accordingly.
7765 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7767 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7769 * dispextern.h (string_buffer_position): Remove declaration.
7771 * print.c (strout): Remove parameter `multibyte', unused since
7772 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7774 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7775 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7776 All callers changed.
7778 * w32.c (_wsa_errlist): Use braces for struct initializers.
7780 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7781 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7782 All callers changed.
7783 (string_buffer_position): Likewise. Also, make static (it's never
7784 used outside xdisp.c).
7785 (cursor_row_p): Remove parameter `w', unused since
7786 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7787 (decode_mode_spec): Remove parameter `precision', introduced during
7788 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7789 All callers changed.
7791 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7793 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7795 2011-03-27 Anders Lindgren <andlind@gmail.com>
7797 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7798 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7799 (ns_update_auto_hide_menu_bar): New functions.
7800 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7801 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7802 ns_constrain_all_frames.
7803 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7804 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7806 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7808 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7810 2011-03-27 Glenn Morris <rgm@gnu.org>
7812 * syssignal.h: Replace RETSIGTYPE with void.
7813 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7814 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7815 Replace SIGTYPE with void everywhere.
7816 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7817 * s/template.h (SIGTYPE): Remove commented out definition.
7819 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7821 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7822 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7824 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7826 * w32.c (read_unc_volume): Use parameter `henum', instead of
7827 global variable `wget_enum_handle'.
7829 * keymap.c (describe_vector): Remove parameters `indices' and
7830 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7831 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7833 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7835 * keyboard.c (timer_check): Remove parameter `do_it_now',
7836 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7837 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7838 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7840 * keyboard.c (read_char):
7841 * w32menu.c (w32_menu_display_help):
7842 * xmenu.c (show_help_event, menu_help_callback):
7843 Adjust calls to `show_help_echo'.
7845 * gtkutil.c (xg_maybe_add_timer):
7846 * keyboard.c (readable_events):
7847 * process.c (wait_reading_process_output):
7848 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7850 * insdel.c (adjust_markers_gap_motion):
7851 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7852 (gap_left, gap_right): Don't call it.
7854 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7856 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7857 incurred during fontification.
7859 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7861 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7862 (DEFVAR_PER_BUFFER): Don't pass it.
7864 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7865 (scrolling_window): Don't pass it.
7867 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7869 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7871 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7873 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7874 of variables specific to SELinux and computation of `encoded_absname'.
7876 * image.c (XPutPixel): Remove unused variable `height'.
7878 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7880 * unexw32.c (get_section_info): Remove unused variable `section'.
7882 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7883 (system_process_attributes): Remove unused variable `sess'.
7884 (sys_read): Remove unused variable `err'.
7886 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7887 (w32_wnd_proc): Remove unused variable `isdead'.
7888 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7889 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7890 (x_create_tip_frame): Remove unused variable `tem'.
7892 * w32inevt.c (w32_console_read_socket):
7893 Remove unused variable `no_events'.
7895 * w32term.c (x_draw_composite_glyph_string_foreground):
7896 Remove unused variable `width'.
7898 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7900 * w32term.c (x_set_glyph_string_clipping):
7901 Don't pass uninitialized region to CombineRgn.
7903 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7905 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7906 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7907 (Fx_close_connection): Remove unused variable `i'.
7909 * w32font.c (w32font_draw): Return number of glyphs.
7910 (w32font_open_internal): Remove unused variable `i'.
7911 (w32font_driver): Add missing initializer.
7913 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7914 (fill_in_menu): Remove unused variable `items_added'.
7916 * w32term.c (last_mouse_press_frame): Remove static global variable.
7917 (w32_clip_to_row): Remove unused variable `f'.
7918 (x_delete_terminal): Remove unused variable `i'.
7920 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7921 (NOTHING): Remove unused static global variable.
7922 (uniscribe_check_otf): Remove unused variable `table'.
7923 (uniscribe_font_driver): Add missing initializers.
7925 2011-03-23 Julien Danjou <julien@danjou.info>
7927 * term.c (Fsuspend_tty, Fresume_tty):
7928 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7929 * window.c (temp_output_buffer_show):
7930 * insdel.c (signal_before_change):
7931 * frame.c (Fhandle_switch_frame):
7932 * fileio.c (Fdo_auto_save):
7933 * emacs.c (Fkill_emacs):
7934 * editfns.c (save_excursion_restore):
7935 * cmds.c (internal_self_insert):
7936 * callint.c (Fcall_interactively):
7937 * buffer.c (Fkill_all_local_variables):
7938 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7940 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7941 unconditionally since it does the check itself.
7943 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7945 Fix more problems found by GCC 4.5.2's static checks.
7947 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7948 the first time through the loop, since we know p0 < p1 then.
7949 This also avoids a gcc -Wstrict-overflow warning.
7951 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7952 leading to a memory leak, possible in functions like
7953 load_charset_map_from_file that can allocate an unbounded number
7954 of objects (Bug#8318).
7956 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7957 that could (at least in theory) be that large.
7959 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7960 This is less likely to overflow, and avoids undefined behavior if
7961 overflow does occur. All callers changed. Use strtoul to scan
7962 for the unsigned long integer.
7963 (pint2hrstr): Simplify and tune code slightly.
7964 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7966 * scroll.c (do_scrolling): Work around GCC bug 48228.
7967 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7969 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7970 This also avoids a warning with gcc -Wstrict-overflow.
7971 (validate_x_resource_name): Simplify count usage.
7972 This also avoids a warning with gcc -Wstrict-overflow.
7974 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7977 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7979 * process.c (Fmake_network_process): Use socklen_t, not int,
7980 where POSIX says socklen_t is required in portable programs.
7981 This fixes a porting bug on hosts like 64-bit HP-UX, where
7982 socklen_t is wider than int (Bug#8277).
7983 (Fmake_network_process, server_accept_connection):
7984 (wait_reading_process_output, read_process_output):
7987 * process.c: Rename or move locals to avoid shadowing.
7988 (list_processes_1, Fmake_network_process):
7989 (read_process_output_error_handler, exec_sentinel_error_handler):
7990 Rename or move locals.
7991 (Fmake_network_process): Define label "retry_connect" only if needed.
7992 (Fnetwork_interface_info): Fix pointer signedness.
7993 (process_send_signal): Add cast to avoid pointer signedness problem.
7994 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7995 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7997 Make tparam.h and terminfo.c consistent.
7998 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7999 Include tparam.h instead, since it declares them.
8000 * cm.h (PC): Remove extern decl; tparam.h now does this.
8001 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8002 * terminfo.c: Include tparam.h, to check interfaces.
8003 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8004 (tparam): Adjust signature to match interface in tparam.h;
8005 this removes some undefined behavior. Check that outstring and len
8006 are zero, which they always are with Emacs.
8007 * tparam.h (PC, BC, UP): New extern decls.
8009 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8010 (xftfont_open): Rename locals to avoid shadowing.
8012 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8013 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8014 (OTF_TAG_SYM): Omit macro if not needed.
8015 (ftfont_list): Remove unused local.
8016 (get_adstyle_property, ftfont_pattern_entity):
8017 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8018 Rename locals to avoid shadowing.
8020 * xfont.c (xfont_list_family): Mark var as initialized.
8022 * xml.c (make_dom): Now static.
8024 * composite.c (composition_compute_stop_pos): Rename local to
8026 (composition_reseat_it): Remove unused locals.
8027 (find_automatic_composition, composition_adjust_point): Likewise.
8028 (composition_update_it): Mark var as initialized.
8029 (find_automatic_composition): Mark vars as initialized,
8030 with a FIXME (Bug#8290).
8032 character.h: Rename locals to avoid shadowing.
8033 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8034 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8035 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8036 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8039 * textprop.c (property_change_between_p): Remove; unused.
8041 * intervals.c (interval_start_pos): Now static.
8043 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8045 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8046 Rename locals to avoid shadowing.
8048 * sound.c (wav_play, au_play, Fplay_sound_internal):
8049 Fix pointer signedness.
8050 (alsa_choose_format): Remove unused local var.
8051 (wav_play): Initialize a variable to 0, to prevent undefined
8052 behavior (Bug#8278).
8054 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8056 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8058 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8059 clobbering (Bug#8298).
8060 * sysdep.c (sys_subshell): Likewise.
8061 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8063 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8064 This should get cleaned up, so that child_setup has the
8065 same signature on all platforms.
8067 * callproc.c (call_process_cleanup): Now static.
8068 (relocate_fd): Rename locals to avoid shadowing.
8070 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8072 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8073 not to be necessary, and produces flickering.
8075 2011-03-20 Glenn Morris <rgm@gnu.org>
8077 * config.in: Remove file.
8079 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8081 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8082 are now in src/globals.h.
8083 (syms_of_minibuf): Remove spurious & from previous change.
8085 2011-03-20 Leo <sdl.web@gmail.com>
8087 * minibuf.c (completing-read-function): New variable.
8088 (completing-read-default): Rename from completing-read.
8089 (completing-read): Call completing-read-function.
8091 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8093 * xfaces.c (Fx_load_color_file):
8094 Read color file from absolute filename (bug#8250).
8096 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8098 * makefile.w32-in: Update dependencies.
8100 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8102 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8104 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8106 Fix more problems found by GCC 4.5.2's static checks.
8108 * process.c (make_serial_process_unwind, send_process_trap):
8109 (sigchld_handler): Now static.
8111 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8112 That way, the code declares only the vars that it needs.
8113 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8114 * s/cygwin.h (PTY_ITERATION): Likewise.
8115 * s/darwin.h (PTY_ITERATION): Likewise.
8116 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8118 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8119 * process.c (allocate_pty): Don't declare stb unless it's needed.
8121 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8122 (CONSTANTLIM): Remove; unused.
8123 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8124 Define only if needed.
8126 * unexelf.c (unexec): Name an expression,
8127 to avoid gcc -Wbad-function-cast warning.
8128 Use a different way to cause a compilation error if anyone uses
8129 n rather than nn, a way that does not involve shadowing.
8130 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8132 * deps.mk (unexalpha.o): Remove; unused.
8134 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8135 * unexec.h: New file.
8136 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8137 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8139 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8140 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8141 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8142 Change as necessary to match prototype in unexec.h.
8144 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8146 (back_comment, skip_chars): Mark vars as initialized.
8148 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8149 Rename locals to avoid shadowing.
8151 * lread.c (read1): Rewrite so as not to use empty "else".
8152 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8154 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8156 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8157 warning when compiling print.c.
8159 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8160 instead of using an uninitialized var.
8161 (font_sort_entities): Mark var as initialized.
8163 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8165 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8166 pointers to constants.
8167 (font_parse_fcname): Remove unused vars.
8168 (font_delete_unmatched): Now static.
8169 (font_get_spec): Remove; unused.
8170 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8171 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8172 Rename or move locals to avoid shadowing.
8174 * fns.c (require_nesting_list, require_unwind): Now static.
8175 (Ffillarray): Rename locals to avoid shadowing.
8177 * floatfns.c (domain_error2): Define only if needed.
8178 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8180 * alloc.c (mark_backtrace): Move decl from here ...
8181 * lisp.h: ... to here, so that it can be checked.
8183 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8184 (Fdefvar): Rewrite so as not to use empty "else".
8185 (lisp_indirect_variable): Name an expression,
8186 to avoid gcc -Wbad-function-cast warning.
8187 (Fdefvar): Rename locals to avoid shadowing.
8189 * callint.c (quotify_arg, quotify_args): Now static.
8190 (Fcall_interactively): Rename locals to avoid shadowing.
8191 Use const pointer when appropriate.
8193 * lisp.h (get_system_name, get_operating_system_release):
8194 Move decls here, to check interfaces.
8195 * process.c (get_operating_system_release): Move decl to lisp.h.
8196 * xrdb.c (get_system_name): Likewise.
8197 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8198 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8199 some of which prompt warnings from gcc -Wbad-function-cast.
8200 (Fformat_time_string, Fencode_time, Finsert_char):
8201 (Ftranslate_region_internal, Fformat):
8202 Rename or remove local vars to avoid shadowing.
8203 (Ftranslate_region_internal): Mark var as initialized.
8205 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8208 * lisp.h (eassert): Check that the argument compiles, even if
8209 ENABLE_CHECKING is not defined.
8211 * data.c (Findirect_variable): Name an expression, to avoid
8212 gcc -Wbad-function-cast warning.
8213 (default_value, arithcompare, arith_driver, arith_error): Now static.
8214 (store_symval_forwarding): Rename local to avoid shadowing.
8215 (Fmake_variable_buffer_local, Fmake_local_variable):
8216 Mark variables as initialized.
8217 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8219 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8220 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8221 Rename locals to avoid shadowing.
8222 (mark_stack): Move local variables into the #ifdef region where
8224 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8225 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8227 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8228 (GC_STRING_CHARS): Remove; not used.
8229 (Fmemory_limit): Cast sbrk's returned value to char *.
8231 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8232 avoids undefined behavior in theory.
8234 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8236 Use functions, not macros, for up- and down-casing (Bug#8254).
8237 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8238 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8239 to use the following functions instead of these macros.
8240 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8241 EMACS_INT, since callers assume the returned value fits in int.
8242 (upcase1): Likewise, for UPCASE_TABLE.
8243 (uppercasep, lowercasep, upcase): New static inline functions.
8244 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8245 the race-condition problem in the old DOWNCASE.
8247 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8248 Rename locals to avoid shadowing.
8249 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8250 (regex_compile, re_search_2, re_match_2_internal):
8251 Remove unused local vars.
8252 (FREE_VAR): Rewrite so as not to use empty "else",
8253 which gcc can warn about.
8254 (regex_compile, re_match_2_internal): Mark locals as initialized.
8255 (RETALLOC_IF): Define only if needed.
8256 (WORDCHAR_P): Likewise. This one is never needed, but is used
8257 only in a comment talking about a compiler bug, so put inside
8258 the #if 0 of that comment.
8259 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8260 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8263 * search.c (boyer_moore): Rename locals to avoid shadowing.
8264 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8265 (PREV_CHAR_BOUNDARY): Likewise.
8267 * search.c (simple_search): Remove unused var.
8269 * dired.c (compile_pattern): Move decl from here ...
8270 * lisp.h: ... to here, so that it can be checked.
8271 (struct re_registers): New forward decl.
8273 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8275 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8277 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8278 Rename locals to avoid shadowing.
8279 (Fvertical_motion): Mark locals as initialized.
8281 * casefiddle.c (casify_object, casify_region): Now static.
8282 (casify_region): Mark local as initialized.
8284 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8286 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8287 New macros, so that the caller can use some names other than
8288 gcpro1, gcpro2, etc.
8289 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8291 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8292 argument, for consistency with GCPRO2_VAR, etc: it is now the
8293 prefix of the variable, not the variable itself. All uses
8295 * dired.c (directory_files_internal, file_name_completion):
8296 Rename locals to avoid shadowing.
8298 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8299 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8300 dired.c's scmp function, had undefined behavior.
8301 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8302 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8303 * buffer.h: ... to here, because these macros use current_buffer,
8304 and the new implementation with inline functions needs to have
8305 current_buffer in scope now, rather than later when the macros
8307 (downcase, upcase1): New static inline functions.
8308 (DOWNCASE, UPCASE1): Reimplement using these functions.
8309 This avoids undefined behavior in expressions like
8310 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8311 from race conditions in accessing the global variables
8312 case_temp1 and case_temp2.
8313 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8314 * lisp.h (case_temp1, case_temp2): Remove their decls.
8315 * character.h (ASCII_CHAR_P): Move from here ...
8316 * lisp.h: ... to here, so that the inline functions mentioned
8319 * dired.c (directory_files_internal_unwind): Now static.
8321 * fileio.c (file_name_as_directory, directory_file_name):
8322 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8324 (file_name_as_directory): Use const pointers when appropriate.
8325 (Fexpand_file_name): Likewise. In particular, newdir might
8326 point at constant storage, so make it a const pointer.
8327 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8328 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8330 (Fset_file_times, Finsert_file_contents, auto_save_error):
8331 Rename locals to avoid shadowing.
8333 * minibuf.c (choose_minibuf_frame_1): Now static.
8334 (Ftry_completion, Fall_completions): Rename or remove locals
8337 * marker.c (bytepos_to_charpos): Remove; unused.
8339 * lisp.h (verify_bytepos, count_markers): New decls,
8340 so that gcc does not warn that these functions aren't declared.
8342 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8343 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8344 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8345 (copy_text): Remove unused local var.
8347 * filelock.c (within_one_second): Now static.
8348 (lock_file_1): Rename local to avoid shadowing.
8350 * buffer.c (fix_overlays_before): Mark locals as initialized.
8351 (fix_start_end_in_overlays): Likewise. This function should be
8352 simplified by using pointers-to-pointers, but that's a different
8354 (switch_to_buffer_1): Now static.
8355 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8356 (report_overlay_modification): Rename locals to avoid shadowing.
8358 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8359 Fix pointer signedness issue.
8360 (sys_subshell): Mark local as volatile if checking for lint,
8361 to suppress a gcc -Wclobbered warning that does not seem to be right.
8362 (MAXPATHLEN): Define only if needed.
8364 * process.c (serial_open, serial_configure): Move decls from here ...
8365 * systty.h: ... to here, so that they can be checked.
8367 * fns.c (get_random, seed_random): Move extern decls from here ...
8368 * lisp.h: ... to here, so that they can be checked.
8370 * sysdep.c (reset_io): Now static.
8371 (wait_for_termination_signal): Remove; unused.
8373 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8374 (copy_keymap_item, append_key, push_text_char_description):
8376 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8377 (DENSE_TABLE_SIZE): Remove; unused.
8378 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8379 (describe_map_tree):
8380 Rename locals to avoid shadowing.
8382 * keyboard.c: Declare functions static if they are not used elsewhere.
8383 (echo_char, echo_dash, cmd_error, top_level_2):
8384 (poll_for_input, handle_async_input): Now static.
8385 (read_char, kbd_buffer_get_event, make_lispy_position):
8386 (make_lispy_event, make_lispy_movement, apply_modifiers):
8387 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8388 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8389 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8390 (read_key_sequence, read_char): Mark locals as initialized.
8391 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8393 * keyboard.h (make_ctrl_char): New decl.
8394 (mark_kboards): Move decl here ...
8395 * alloc.c (mark_kboards): ... from here.
8397 * lisp.h (force_auto_save_soon): New decl.
8399 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8400 (DEFINE_DUMMY_FUNCTION): New macro.
8401 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8403 (main): Add casts to avoid warnings
8404 if GCC considers string literals to be constants.
8406 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8408 * dbusbind.c: Pointer signedness fixes.
8409 (xd_signature, xd_append_arg, xd_initialize):
8410 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8411 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8412 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8413 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8415 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8416 if GCC considers string literals to be constants.
8417 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8419 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8421 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8422 (print_preprocess, print_object): New macro to fix last change.
8424 * print.c (print_preprocess): Don't forget font objects.
8426 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8428 * emacs.c (USAGE3): Doc fixes.
8430 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8432 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8435 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8437 * lisp.h (VWindow_system, Qfile_name_history):
8438 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8439 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8440 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8442 * w32select.c: Don't #include "keyboard.h".
8443 (run_protected): Add extern declaration for waiting_for_input.
8445 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8446 * w32console.c (detect_input_pending, read_input_pending)
8447 (encode_terminal_code):
8448 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8449 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8450 (w32_system_caret_y, Qfile_name_history):
8451 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8452 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8453 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8454 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8455 * w32proc.c (Qlocal, report_file_error):
8456 * w32term.c (Vwindow_system, updating_frame):
8457 * w32uniscribe.c (initialized, uniscribe_font_driver):
8458 Remove unneeded extern declarations.
8460 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8462 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8464 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8466 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8467 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8468 These macros can no longer be used for assignment.
8470 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8471 Assign struct members directly, instead of using BUF_BEGV etc.
8472 (record_buffer_markers, fetch_buffer_markers): New functions for
8473 recording and fetching special buffer markers.
8474 (set_buffer_internal_1, set_buffer_temp): Use them.
8476 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8478 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8480 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8481 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8483 * xdisp.c (hscroll_window_tree):
8484 (reconsider_clip_changes): Use PT instead of BUF_PT.
8486 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8488 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8489 $(EMACS_ROOT)/lib/intprops.h.
8491 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8493 Fix more problems found by GCC 4.5.2's static checks.
8495 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8496 to unsigned char * to avoid compiler diagnostic.
8497 (xg_free_frame_widgets): Make it clear that a local variable is
8498 needed only if USE_GTK_TOOLTIP.
8499 (gdk_window_get_screen): Make it clear that this macro is needed
8500 only if USE_GTK_TOOLTIP.
8501 (int_gtk_range_get_value): New function, which avoids a diagnostic
8502 from gcc -Wbad-function-cast.
8503 (xg_set_toolkit_scroll_bar_thumb): Use it.
8504 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8505 diagnostic from gcc -Wbad-function-cast.
8506 (get_utf8_string, xg_get_file_with_chooser):
8507 Rename locals to avoid shadowing.
8508 (create_dialog): Move locals to avoid shadowing.
8510 * xgselect.c (xg_select): Remove unused var.
8512 * image.c (four_corners_best): Mark locals as initialized.
8513 (gif_load): Initialize transparent_p to zero (Bug#8238).
8514 Mark another local as initialized.
8515 (my_png_error, my_error_exit): Mark with NO_RETURN.
8517 * image.c (clear_image_cache): Now static.
8518 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8519 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8520 (x_edge_detection): Remove unnecessary cast that
8521 gcc -Wbad-function-cast diagnoses.
8522 (gif_load): Fix pointer signedness.
8523 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8524 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8526 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8528 Improve quality of tests for time stamp overflow.
8529 For example, without this patch (encode-time 0 0 0 1 1
8530 1152921504606846976) returns the obviously-bogus value (-948597
8531 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8532 reports time overflow. See
8533 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8534 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8535 * editfns.c: Include limits.h and intprops.h.
8536 (TIME_T_MIN, TIME_T_MAX): New macros.
8537 (time_overflow): Move earlier, to before first use.
8538 (hi_time, lo_time): New functions, for an accurate test for
8540 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8541 (Fget_internal_run_time): Don't assume time_t fits in int.
8542 (make_time): Use list2 instead of Fcons twice.
8543 (Fdecode_time): More accurate test for out-of-range times.
8544 (check_tm_member): New function.
8545 (Fencode_time): Use it, to test for out-of-range times.
8546 (lisp_time_argument): Don't rely on undefined left-shift and
8547 right-shift behavior when checking for time stamp overflow.
8549 * editfns.c (time_overflow): New function, refactoring common code.
8550 (Fformat_time_string, Fdecode_time, Fencode_time):
8551 (Fcurrent_time_string): Use it.
8553 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8554 * dired.c (make_time): Move to ...
8555 * editfns.c (make_time): ... here.
8556 * systime.h: Note the move.
8558 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8560 * fringe.c (update_window_fringes): Remove unused variables.
8562 * unexmacosx.c (copy_data_segment): Also copy __got section.
8565 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8567 * termcap.c [MSDOS]: Include "msdos.h".
8568 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8569 Constify `char *' arguments and their references according to
8570 prototypes in tparam.h.
8572 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8574 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8575 Adapt all references accordingly.
8577 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8579 2011-03-11 Tom Tromey <tromey@redhat.com>
8581 * buffer.c (syms_of_buffer): Remove obsolete comment.
8583 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8585 * termhooks.h (encode_terminal_code): Declare prototype.
8587 * msdos.c (encode_terminal_code): Don't declare prototype.
8589 * term.c (encode_terminal_code): Now external again, used by
8590 w32console.c and msdos.c.
8592 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8593 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8595 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8597 Fix some minor problems found by GCC 4.5.2's static checks.
8599 * fringe.c (update_window_fringes): Mark locals as initialized
8601 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8603 * alloc.c (mark_fringe_data): Move decl from here ...
8604 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8605 to check its interface.
8606 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8608 * fontset.c (free_realized_fontset): Now static.
8609 (Fset_fontset_font): Rename local to avoid shadowing.
8610 (fontset_font): Mark local as initialized.
8611 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8613 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8615 * xselect.c (x_disown_buffer_selections): Remove; not used.
8616 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8617 (x_own_selection, Fx_disown_selection_internal): Rename locals
8619 (x_handle_dnd_message): Remove local to avoid shadowing.
8621 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8622 so that the caller can use some name other than gcpro1.
8623 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8624 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8625 (Fx_backspace_delete_keys_p):
8626 Use them to avoid shadowing, and rename vars to avoid shadowing.
8627 (x_decode_color, x_set_name, x_window): Now static.
8628 (Fx_create_frame): Add braces to silence GCC warning.
8629 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8630 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8631 Remove unused locals.
8632 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8633 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8634 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8637 * xterm.h (x_mouse_leave): New decl.
8639 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8640 Remove unused functions.
8641 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8642 (x_calc_absolute_position): Now static.
8643 (XTread_socket): Don't define label "out" unless it's used.
8644 Don't declare local "event" unless it's used.
8645 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8646 unless they are used.
8647 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8648 (x_fatal_error_signal): Remove; not used.
8649 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8650 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8651 (x_error_catcher, x_connection_closed, x_error_handler):
8652 (x_error_quitter, xembed_send_message, x_iconify_frame):
8653 (my_log_handler): Rename locals to avoid shadowing.
8654 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8655 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8657 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8658 Rename or move locals to avoid shadowing.
8659 (tty_defined_color, merge_face_heights): Now static.
8660 (free_realized_faces_for_fontset): Remove; not used.
8661 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8662 does not deduce is never used uninitialized.
8663 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8664 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8666 * terminal.c (store_terminal_param): Now static.
8668 * xmenu.c (menu_highlight_callback): Now static.
8669 (set_frame_menubar): Remove unused local.
8670 (xmenu_show): Rename parameter to avoid shadowing.
8671 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8672 since they might point to immutable storage.
8673 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8674 since it's unused otherwise.
8676 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8677 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8678 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8679 avoids a gcc -Wuninitialized diagnostic.
8680 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8681 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8682 does not deduce are never used uninitialized.
8684 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8686 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8687 * window.c (window_loop, size_window):
8688 (run_window_configuration_change_hook, enlarge_window): Likewise.
8690 * window.c (display_buffer): Now static.
8691 (size_window): Mark variables that gcc -Wuninitialized
8692 does not deduce are never used uninitialized.
8693 * window.h (check_all_windows): New decl, to forestall
8694 gcc -Wmissing-prototypes diagnostic.
8695 * dispextern.h (bidi_dump_cached_states): Likewise.
8697 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8699 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8701 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8702 and to avoid gcc -Wuninitialized warning.
8703 (load_charset_map): Mark variables that gcc -Wuninitialized
8704 does not deduce are never used uninitialized.
8705 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8707 * coding.c (coding_set_source, coding_set_destination):
8708 Use "else { /* comment */ }" rather than "else /* comment */;"
8709 for clarity, and to avoid gcc -Wempty-body warning.
8710 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8711 a block, when the outer 'i' will do.
8712 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8713 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8714 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8715 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8716 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8717 Rename locals to avoid shadowing.
8718 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8719 * coding.c (emacs_mule_char, encode_invocation_designation):
8720 Now static, since they're not used elsewhere.
8721 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8722 (decode_coding_object, encode_coding_object, detect_coding_system):
8723 (decode_coding_emacs_mule): Mark variables that gcc
8724 -Wuninitialized does not deduce are never used uninitialized.
8725 (detect_coding_iso_2022): Initialize a local variable that might
8726 be used uninitialized. Leave a FIXME because it's not clear that
8727 this initialization is needed. (Bug#8211)
8728 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8729 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8730 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8731 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8732 Remove unused macros.
8734 * category.c (hash_get_category_set): Remove unused local var.
8735 (copy_category_table): Now static, since it's not used elsewhere.
8736 * character.c (string_count_byte8): Likewise.
8738 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8739 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8741 * chartab.c (copy_sub_char_table): Now static, since it's not used
8743 (sub_char_table_ref_and_range, char_table_ref_and_range):
8744 Rename locals to avoid shadowing.
8745 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8747 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8748 (BIDI_BOB): Remove unused macro.
8750 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8751 deduce are never used uninitialized.
8752 * term.c (encode_terminal_code): Likewise.
8754 * term.c (encode_terminal_code): Now static. Remove unused local.
8756 * tparam.h: New file.
8757 * term.c, tparam.h: Include it.
8758 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8759 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8760 Move these decls to tparam.h, and make them agree with what
8761 is actually in tparam.c. The previous trick of using incompatible
8762 decls in different modules does not conform to the C standard.
8763 All callers of tparam changed to use tparam's actual API.
8764 * tparam.c (tparam1, tparam, tgoto):
8765 Use const pointers where appropriate.
8767 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8768 * cm.h (struct cm): Likewise.
8769 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8770 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8771 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8772 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8773 (turn_on_face, init_tty): Likewise.
8774 * termchar.h (struct tty_display_info): Likewise.
8776 * term.c (term_mouse_position): Rename local to avoid shadowing.
8778 * alloc.c (mark_ttys): Move decl from here ...
8779 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8781 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8783 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8785 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8787 * search.c (compile_pattern_1): Remove argument regp, unused since
8788 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8789 (compile_pattern): Don't pass it.
8791 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8793 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8794 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8796 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8798 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8800 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8801 gdk_window_get_screen, gdk_window_get_geometry,
8802 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8803 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8804 (xg_get_pixbuf_from_pixmap): New function.
8805 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8806 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8807 Call xg_get_pixbuf_from_pixmap instead of
8808 gdk_pixbuf_get_from_drawable.
8809 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8810 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8811 (xg_check_special_colors): Use GtkStyleContext and its functions
8813 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8814 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8815 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8816 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8817 Call gtk_widget_get_preferred_size.
8818 (xg_frame_resized): gdk_window_get_geometry only takes 5
8820 (xg_win_to_widget, xg_event_is_for_menubar):
8821 Call gdk_x11_window_lookup_for_display.
8822 (xg_set_widget_bg): New function.
8823 (delete_cb): New function.
8824 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8825 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
8826 (xg_set_background_color): Call xg_set_widget_bg.
8827 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8828 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8829 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8830 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8832 (update_frame_tool_bar): Call gtk_widget_hide.
8833 (xg_initialize): Use GDK_KEY_g.
8835 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8837 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8839 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8840 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8841 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8843 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8845 * w32xfns.c (select_palette): Check success of RealizePalette against
8846 GDI_ERROR, not zero.
8848 See ChangeLog.11 for earlier changes.
8854 Copyright (C) 2011 Free Software Foundation, Inc.
8856 This file is part of GNU Emacs.
8858 GNU Emacs is free software: you can redistribute it and/or modify
8859 it under the terms of the GNU General Public License as published by
8860 the Free Software Foundation, either version 3 of the License, or
8861 (at your option) any later version.
8863 GNU Emacs is distributed in the hope that it will be useful,
8864 but WITHOUT ANY WARRANTY; without even the implied warranty of
8865 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8866 GNU General Public License for more details.
8868 You should have received a copy of the GNU General Public License
8869 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.