* net/tramp.el (top): Don't require 'shell.
[bpt/emacs.git] / src / ChangeLog
1 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2
3 Fix minor problem found by static checking.
4 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5 initialized, to pacify gcc -Wuninitialized.
6
7 * fileio.c: Report proper errno when syscall falls.
8 (Finsert_file_contents): Save and restore errno,
9 so that report_file_error outputs the correct diagnostic.
10 (Fwrite_region) [CLASH_DETECTION]: Likewise.
11
12 2011-09-18 Eli Zaretskii <eliz@gnu.org>
13
14 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
15
16 2011-09-17 Eli Zaretskii <eliz@gnu.org>
17
18 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
19 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
20
21 2011-09-17 Eli Zaretskii <eliz@gnu.org>
22
23 * xdisp.c (reseat_at_next_visible_line_start): Keep information
24 about the current paragraph and restore it after the call to
25 reseat.
26
27 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
28 (bidi_find_paragraph_start): Search back for paragraph beginning
29 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
30 (bidi_move_to_visually_next): Only trigger paragraph-related
31 computations when the last character is a newline or at EOB, not
32 just any NEUTRAL_B. (Bug#9470)
33
34 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
35 truncated lines if point is covered by a display string. (Bug#9524)
36
37 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
38
39 * xselect.c: Relax test for outgoing X longs (Bug#9498).
40 (cons_to_x_long): New function.
41 (lisp_data_to_selection_data): Use it. Correct the test for
42 short-versus-long data; it was negated. Break out of vector
43 loop, for efficiency, when a long datum is discovered.
44
45 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
46
47 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
48
49 2011-09-16 Eli Zaretskii <eliz@gnu.org>
50
51 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
52 GCC PR/17406) by declaring this function with external scope.
53
54 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
55
56 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
57 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
58
59 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
60
61 * editfns.c (Fformat): Correctly handle text properties on "%%".
62
63 2011-09-15 Eli Zaretskii <eliz@gnu.org>
64
65 * xterm.c (x_draw_composite_glyph_string_foreground):
66 * w32term.c (x_draw_composite_glyph_string_foreground):
67 * term.c (encode_terminal_code):
68 * composite.c (composition_update_it, get_composition_id):
69 * xdisp.c (get_next_display_element)
70 (fill_composite_glyph_string): Add comments about special meaning
71 of TAB characters in a composition.
72
73 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
74
75 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
76 This occurs when processing a multibyte format.
77 Problem reported by Wolfgang Jenker.
78
79 2011-09-15 Johan Bockgård <bojohan@gnu.org>
80
81 * xdisp.c (try_cursor_movement): Only check for exact match if
82 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
83
84 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
85
86 Remove unused external symbols.
87 * dispextern.h (calc_pixel_width_or_height): Remove decl.
88 * xdisp.c (calc_pixel_width_or_height): Now static.
89 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
90 * indent.c (check_display_width):
91 * w32term.c: Fix comment to match code.
92 * xterm.c, xterm.h (x_catching_errors): Remove.
93
94 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
95
96 * xselect.c: Use signed conversions more consistently (Bug#9498).
97 (selection_data_to_lisp_data): Assume incoming selection data are
98 signed integers, not unsigned. This is to be consistent with
99 outgoing selection data, which was modified to use signed integers
100 in as part of the fix to Bug#9196 in response to Jan D.'s comment
101 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
102 expects long, not unsigned long.
103
104 2011-09-14 Eli Zaretskii <eliz@gnu.org>
105
106 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
107 computation of loop end. Reported by Johan Bockgård
108 <bojohan@gnu.org>.
109
110 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
111
112 * frame.c (Fother_visible_frames_p): Function deleted.
113
114 2011-09-12 Eli Zaretskii <eliz@gnu.org>
115
116 * indent.c (compute_motion): Process display vector front to back
117 rather than the other way around. (Bug#2496)
118
119 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
120
121 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
122
123 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
124
125 * minibuf.c (Fread_from_minibuffer): Doc fix.
126
127 2011-09-11 Eli Zaretskii <eliz@gnu.org>
128
129 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
130 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
131
132 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
133
134 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
135 value for non-existent files.
136
137 2011-09-11 Eli Zaretskii <eliz@gnu.org>
138
139 * fileio.c (Finsert_file_contents): If the file cannot be opened,
140 set its "size" to -1. This will set the modtime_size field of
141 the corresponding buffer to -1, which is what
142 verify-visited-file-modtime expects for files that do not exist.
143 (Bug#9139)
144
145 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
146
147 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
148 here ...
149 * lisp.h: ... from here. push_key_description is no longer
150 defined in keyboard.c, so its declaration should not be in
151 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
152 logically belongs with push_key_description.
153
154 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
155
156 * buffer.h: Include <sys/types.h> instead of <time.h>.
157 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
158 Problem reported by Herbert J. Skuhra.
159
160 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
161
162 * xml.c (parse_region): Make the parsing work for
163 non-comment-starting XML files again (bug#9144).
164
165 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
166
167 * image.c (gif_load): Fix calculation of bottom and right corner.
168 (Bug#9468)
169
170 2011-09-10 Eli Zaretskii <eliz@gnu.org>
171
172 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
173 redisplay in small windows.
174
175 2011-09-09 Eli Zaretskii <eliz@gnu.org>
176
177 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
178
179 2011-09-08 Martin Rudalics <rudalics@gmx.at>
180
181 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
182 Operate on live windows only.
183
184 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
185
186 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
187
188 2011-09-07 Eli Zaretskii <eliz@gnu.org>
189
190 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
191 only under bidi iteration.
192
193 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
194
195 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
196
197 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
198
199 isnan: Fix porting problem to Solaris 10 with bundled gcc.
200 Without this fix, the command to link temacs failed due to an
201 undefined symbol __builtin_isnan. This is because
202 /usr/include/iso/math_c99.h #defines isnan(x) to
203 __builtin_isnan(x), but the bundled gcc, which identifies itself
204 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
205 a __builtin_isnan.
206 * floatfns.c (isnan): #undef, and then #define to a clone of
207 what's in data.c.
208 (Fisnan): Always define, since it's always available now.
209 (syms_of_floatfns): Always define isnan at the Lisp level.
210
211 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
212
213 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
214
215 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
216
217 * fileio.c: Fix bugs with large file offsets (Bug#9428).
218 The previous code assumed that file offsets (off_t values) fit in
219 EMACS_INT variables, which is not true on typical 32-bit hosts.
220 The code messed up by falsely reporting buffer overflow in cases
221 such as (insert-file-contents "big" nil 1 2) into an empty buffer
222 when "big" contains more than 2**29 bytes, even though this
223 inserts just one byte and does not overflow the buffer.
224 (Finsert_file_contents): Store file offsets as off_t
225 values, not as EMACS_INT values. Check for overflow when
226 converting between EMACS_INT and off_t. When checking for
227 buffer overflow or for overlap, take the offsets into account.
228 Don't use EMACS_INT for small values where int suffices.
229 When checking for overlap, fix a typo: ZV was used where
230 ZV_BYTE was intended.
231 (Fwrite_region): Don't assume off_t fits into 'long'.
232 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
233
234 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
235
236 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
237
238 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
239
240 sprintf-related integer and memory overflow issues (Bug#9412).
241
242 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
243 (esprintf, exprintf, evxprintf): New functions.
244 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
245 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
246 (modify_event_symbol): Do not assume that the length of
247 name_alist_or_stem is safe to alloca and fits in int.
248 (Fexecute_extended_command): Likewise for function name and binding.
249 (Frecursion_depth): Wrap around reliably on integer overflow.
250 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
251 since some callers pass EMACS_INT values.
252 (Fsingle_key_description): Don't crash if symbol name contains more
253 than MAX_ALLOCA bytes.
254 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
255 (get_minibuffer): Arg is now EMACS_INT, not int.
256 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
257 (esprintf, exprintf, evxprintf): New decls.
258 * window.h (command_loop_level, minibuf_level): Reflect API changes.
259
260 * dbusbind.c (signature_cat): New function.
261 (xd_signature, Fdbus_register_signal):
262 Do not overrun buffer; instead, report string overflow.
263
264 * dispnew.c (add_window_display_history): Don't overrun buffer.
265 Truncate instead; this is OK since it's just a log.
266
267 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
268 even if the time zone offset is outlandishly large.
269 Don't mishandle offset == INT_MIN.
270
271 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
272 when creating daemon; the previous buffer-overflow check was incorrect.
273
274 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
275 which has the guts of the old verror function.
276
277 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
278 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
279
280 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
281 (font_unparse_xlfd): Don't blindly alloca long strings.
282 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
283 fits in int, when using sprintf. Use single snprintf to count
284 length of string rather than counting it via multiple sprintfs;
285 that's simpler and more reliable.
286 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
287 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
288 sprintf, in case result does not fit in int.
289
290 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
291 (fontset_from_font): Print it.
292
293 * frame.c (tty_frame_count): Now printmax_t, not int.
294 (make_terminal_frame, set_term_frame_name): Print it.
295 (x_report_frame_params): In X, window IDs are unsigned long,
296 not signed long, so print them as unsigned.
297 (validate_x_resource_name): Check for implausibly long names,
298 and don't assume name length fits in 'int'.
299 (x_get_resource_string): Don't blindly alloca invocation name;
300 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
301 not fit in int.
302
303 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
304 (xg_check_special_colors, xg_set_geometry):
305 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
306
307 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
308 Use esprintf, not sprintf, in case result does not fit in int.
309
310 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
311 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
312 it as a large positive number.
313 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
314 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
315
316 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
317 in case result does not fit in int.
318
319 * print.c (float_to_string): Detect width overflow more reliably.
320 (print_object): Make sprintf buffer a bit bigger, to avoid potential
321 buffer overrun. Don't assume list length fits in 'int'. Treat
322 print length of 0 as 0, not as infinity; to be consistent with other
323 uses of print length in this function. Don't overflow print length
324 index. Don't assume hash table size fits in 'long', or that
325 vectorlike size fits in 'unsigned long'.
326
327 * process.c (make_process): Use printmax_t, not int, to format
328 process-name gensyms.
329
330 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
331
332 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
333 to avoid potential buffer overrun.
334
335 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
336 if X resource line is longer than 512 bytes.
337
338 * xfns.c (x_window): Make sprintf buffer a bit bigger
339 to avoid potential buffer overrun.
340
341 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
342
343 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
344
345 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
346
347 Integer overflow fixes for scrolling, etc.
348 Without these, Emacs silently mishandles large integers sometimes.
349 For example, "C-u 4294967297 M-x recenter" was treated as if
350 it were "C-u 1 M-x recenter" on a typical 64-bit host.
351
352 * xdisp.c (try_window_id): Check Emacs fixnum range before
353 converting to 'int'.
354
355 * window.c (window_scroll_line_based, Frecenter):
356 Check that an Emacs fixnum is in range before assigning it to 'int'.
357 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
358 values converted from Emacs fixnums.
359 (Frecenter): Don't wrap around a line count if it is out of 'int'
360 range; instead, treat it as an extreme value.
361 (Fset_window_configuration, compare_window_configurations):
362 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
363
364 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
365 that can exceed INT_MAX. Check that EMACS_INT value is in range
366 before assigning it to the (possibly-narrower) index.
367 (match_limit): Don't assume that a fixnum can fit in 'int'.
368
369 * print.c (print_object): Use ptrdiff_t, not int, for index that can
370 exceed INT_MAX.
371
372 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
373 (Fvertical_motion): Don't wrap around LINES values that don't fit
374 in 'int'. Instead, treat them as extreme values. This is good
375 enough for windows, which can't have more than INT_MAX lines anyway.
376
377 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
378
379 * Require libxml/parser.h to avoid compilation warning.
380
381 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
382
383 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
384 since this reportedly can destroy thread storage.
385
386 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
387
388 * syntax.c (find_defun_start): Update all cache variables if
389 exiting early (Bug#9401).
390
391 2011-08-30 Eli Zaretskii <eliz@gnu.org>
392
393 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
394
395 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
396 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
397 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
398
399 * term.c (tty_append_glyph): New function.
400 (produce_stretch_glyph): Static function and its prototype deleted.
401
402 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
403 prototypes.
404
405 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
406
407 * image.c (parse_image_spec): Check for nonnegative, not for positive,
408 when checking :margin (Bug#9390).
409 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
410 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
411 so that the name doesn't mislead. All uses changed.
412
413 2011-08-28 Johan Bockgård <bojohan@gnu.org>
414
415 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
416 set_tty_hooks.
417
418 2011-08-27 Eli Zaretskii <eliz@gnu.org>
419
420 * xdisp.c (move_it_to): Don't bail out early when reaching
421 position beyond to_charpos, if we are scanning backwards.
422 (move_it_vertically_backward): When DY == 0, make sure we get to
423 the first character in the line after the newline.
424
425 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
426
427 * ccl.c: Improve and simplify overflow checking (Bug#9196).
428 (ccl_driver): Do not generate an out-of-range pointer.
429 (Fccl_execute_on_string): Remove unnecessary check for
430 integer overflow, noted by Stefan Monnier in
431 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
432 Remove a FIXME that didn't need fixing.
433 Simplify the newly-introduced buffer reallocation code.
434
435 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
436
437 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
438
439 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
440
441 Integer and memory overflow issues (Bug#9196).
442
443 * doc.c (get_doc_string): Rework so that
444 get_doc_string_buffer_size is the actual buffer size, rather than
445 being 1 less than the actual buffer size; this makes xpalloc more
446 convenient.
447
448 * image.c (x_allocate_bitmap_record, cache_image):
449 * xselect.c (Fx_register_dnd_atom):
450 Simplify previous changes by using xpalloc.
451
452 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
453 since either will do and ptrdiff_t is convenient with xpalloc.
454
455 * charset.c (charset_table_size)
456 (struct charset_sort_data.priority): Now ptrdiff_t.
457 (charset_compare): Don't overflow if priorities differ greatly.
458 (Fsort_charsets): Don't assume list length fits in int.
459 Check for size-calculation overflow when allocating sort data.
460 (syms_of_charset): Allocate an initial charset table that is
461 just under 64 KiB, to avoid problems with glibc malloc and mmap.
462
463 * cmds.c (internal_self_insert): Check for size-calculation overflow.
464
465 * composite.h (struct composition.glyph_len): Now int, not unsigned.
466 The actual value is always <= INT_MAX, and leaving it unsigned made
467 overflow checking harder.
468
469 * dispextern.h (struct glyph_matrix.rows_allocated)
470 (struct face_cache.size): Now ptrdiff_t, for convenience in use
471 with xpalloc. The values are still always <= INT_MAX.
472
473 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
474
475 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
476 (SAFE_NALLOCA): New macro.
477
478 * region-cache.c (struct boundary.pos, find_cache_boundary)
479 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
480 (set_cache_region, invalidate_region_cache)
481 (revalidate_region_cache, know_region_cache, region_cache_forward)
482 (region_cache_backward, pp_cache):
483 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
484 so that ptrdiff_t * can be passed to xpalloc.
485 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
486 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
487 (pp_cache): Don't assume cache_len fits in int.
488 * region-cache.h: Adjust extern decls to match.
489
490 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
491 EMACS_INT, since either will do, for xpalloc.
492
493 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
494 (xnmalloc, xnrealloc, xpalloc): New functions.
495
496 * bidi.c (bidi_shelve_header_size): New constant.
497 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
498 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
499
500 * bidi.c (bidi_cache_shrink):
501 * buffer.c (overlays_at, overlays_in, record_overlay_string)
502 (overlay_strings):
503 Don't update size of array until after memory allocation succeeds,
504 because xmalloc/xrealloc may not return.
505 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
506 now that we have proper integer overflow checking.
507 (record_overlay_string, overlay_strings): Catch overflows when
508 calculating size of overlay_str_buf.
509
510 * callproc.c (Fcall_process): Check for size overflow when
511 calculating size of args2.
512 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
513 Normally we prefer signed values, but sticking with ptrdiff_t would
514 require adding more-complicated checks.
515
516 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
517 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
518 Redo buffer-overflow calculations to avoid integer overflow.
519 Add a FIXME comment where memory seems to be over-allocated.
520
521 * character.c (Fstring): Check for size-calculation overflow.
522
523 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
524 unnecessary integer overflow. Check for size overflow.
525 (encode_coding_object): Don't update size until xmalloc succeeds.
526
527 * composite.c (get_composition_id): Check for overflow in glyph
528 length calculations.
529
530 Integer and memory overflow fixes for display code.
531 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
532 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
533 (scrolling_window): Check for overflow in size calculations.
534 (line_draw_cost, realloc_glyph_pool, add_row_entry):
535 Don't assume glyph table len fits in int.
536 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
537 (row_table_size): Now ptrdiff_t, not int.
538 (scrolling_window): Avoid overflow in size calculations.
539 Don't update size until allocation succeeds.
540 * fns.c (concat): Check for overflow in size calculations.
541 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
542 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
543 (NEXT_ALMOST_PRIME_LIMIT): New constant.
544
545 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
546 (get_doc_string): Check for size calculation overflow.
547 Don't update size until allocation succeeds.
548 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
549 EMACS_INT, where ptrdiff_t will do.
550 (Fsubstitute_command_keys): Check for string overflow.
551
552 * editfns.c (set_time_zone_rule): Don't assume environment length
553 fits in int.
554 (message_length): Now ptrdiff_t, not int.
555 (Fmessage_box): Don't update size until allocation succeeds.
556 Don't assume message length fits in int.
557 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
558
559 * emacs.c (main): Do not reallocate argv, since there is a null at
560 the end that can be overwritten, and this way there's no need to
561 worry about size-calculation overflow.
562 (sort_args): Check for size-calculation overflow.
563
564 * eval.c (init_eval_once, grow_specpdl): Don't update size until
565 alloc succeeds.
566 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
567
568 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
569 (x_set_scroll_bar_width, x_figure_window_size):
570 Check for integer overflow.
571 (x_set_alpha): Do not assume XINT fits in int.
572
573 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
574 This is for the members text_lines, text_cols, total_lines, total_cols,
575 where the system imposes an 'int' limit.
576
577 * fringe.c (Fdefine_fringe_bitmap):
578 Don't update size until alloc works.
579
580 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
581 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
582
583 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
584 Check for size-calculation overflow.
585 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
586 do, as we prefer signed integers.
587 (id_to_widget.max_size, id_to_widget.used)
588 (xg_store_widget_in_map, xg_remove_widget_from_map)
589 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
590 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
591 Use and return ptrdiff_t, not int.
592 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
593 * gtkutil.h: Change prototypes to match the above.
594
595 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
596 are duplicate now that they've been promoted to lisp.h.
597 (x_allocate_bitmap_record, x_alloc_image_color)
598 (make_image_cache, cache_image, xpm_load):
599 Don't update size until alloc is done.
600 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
601 (x_detect_edges):
602 Check for size calculation overflow.
603 (ct_colors_allocated_max): New constant.
604 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
605 overflow.
606
607 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
608 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
609 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
610 Use ptrdiff_t, not int, to count maps.
611 (read_char_minibuf_menu_prompt): Check for overflow in size
612 calculations. Don't update size until allocation succeeds. Redo
613 calculations to avoid overflow.
614 * keyboard.h: Change prototypes to match the above.
615
616 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
617 to count maps.
618 (current_minor_maps): Check for size calculation overflow.
619 * keymap.h: Change prototypes to match the above.
620
621 * lread.c (read1, init_obarray): Don't update size until alloc done.
622
623 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
624 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
625
626 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
627 Now ptrdiff_t, not int.
628 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
629 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
630
631 * process.c (Fnetwork_interface_list): Check for overflow
632 in size calculation.
633
634 * region-cache.c (move_cache_gap): Check for size calculation overflow.
635
636 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
637 overflow. Don't bother calling xmalloc when xrealloc will do.
638
639 * search.c (Freplace_match): Check for size calculation overflow.
640 (Fset_match_data): Don't assume list lengths fit in 'int'.
641
642 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
643 for command line length. Do not attempt to address one before the
644 beginning of an array, as that's not portable.
645
646 * term.c (max_frame_lines): Remove; unused.
647 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
648 not int.
649 (encode_terminal_code, calculate_costs): Check for size
650 calculation overflow.
651 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
652 table lengths and related sizes. Don't update size until alloc
653 done. Redo calculations to avoid overflow.
654 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
655
656 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
657 subtracting pointers.
658 (gobble_line): Check for overflow more carefully. Don't update size
659 until alloc done.
660
661 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
662 Don't update size until alloc done.
663 Redo size calculations to avoid overflow.
664 Check for size calculation overflow.
665 (main) [DEBUG]: Fix typo in invoking tparam1.
666
667 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
668 Use ptrdiff_t, not int, for sizes.
669 (store_mode_line_noprop_char): Don't update size until alloc done.
670
671 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
672 Use ptrdiff_t, not int, for sizes.
673 (Finternal_make_lisp_face, cache_face):
674 Check for size calculation overflow.
675 (cache_face): Treat size calculation overflows as if they were
676 memory exhaustion (the usual treatment), rather than aborting.
677
678 * xfns.c (x_encode_text, x_set_name_internal)
679 (Fx_change_window_property): Use ptrdiff_t, not int, to count
680 sizes, since they can exceed INT_MAX in size. Check for size
681 calculation overflow.
682
683 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
684 (xg_select): Check for size calculation overflow.
685 Don't update size until alloc done.
686
687 * xrdb.c (get_environ_db): Don't assume path length fits in int,
688 as sprintf is limited to int lengths.
689
690 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
691 (X_LONG_MIN): New macros.
692 Use them to make the following changes clearer.
693 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
694 This change doesn't affect the value now, but it may help remind
695 future maintainers not to raise the value too much later.
696 (SELECTION_QUANTUM): Remove, replacing with ...
697 (selection_quantum): ... new function, which avoids overflow.
698 All uses changed.
699 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
700 assumption that selection length fits in 'int'.
701 (x_reply_selection_request, x_handle_selection_request)
702 (x_get_window_property, receive_incremental_selection)
703 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
704 (lisp_data_to_selection_data, clean_local_selection_data):
705 Use ptrdiff_t, not int, to record length of selection.
706 (x_reply_selection_request, x_get_window_property)
707 (receive_incremental_selection, x_property_data_to_lisp):
708 Redo calculations to avoid overflow.
709 (x_reply_selection_request): When sending hint, ceiling it at
710 X_LONG_MAX rather than relying on wraparound overflow to send
711 something.
712 (x_get_window_property, receive_incremental_selection)
713 (lisp_data_to_selection_data, x_property_data_to_lisp):
714 Check for size-calculation overflow.
715 (x_get_window_property, receive_incremental_selection)
716 (lisp_data_to_selection_data, Fx_register_dnd_atom):
717 Don't store size until memory allocation succeeds.
718 (x_get_window_property): Plug memory leak on memory exhaustion.
719 Don't double-block input; malloc is safe here. Don't assume 2**34
720 - 4 fits in unsigned long. Add an xassert to check
721 XGetWindowProperty overflow. Be more careful about overflow
722 calculations, and distinguish size from memory overflow better.
723 (receive_incremental_selection): When tracing, don't assume
724 unsigned int is less than INT_MAX.
725 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
726 harmful) conversions of unsigned short to int.
727 (lisp_data_to_selection_data): Don't assume that integers
728 in the range -65535 through -1 fit in an X unsigned short.
729 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
730 result parameters unless successful. Rely on cons_to_unsigned
731 to report problems with elements; the old code wasn't right anyway.
732 (x_check_property_data): Check for int overflow; we cannot use
733 a wider type due to X limits.
734 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
735
736 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
737
738 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
739 (x_term_init): Check for size calculation overflow.
740 (x_color_cells): Don't store size until memory allocation succeeds.
741 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
742 Don't assume alloca size is less than MAX_ALLOCA.
743 (x_term_init): Don't assume length fits in int (sprintf is limited
744 to int size).
745
746 Use ptrdiff_t for composition IDs.
747 * character.c (lisp_string_width):
748 * composite.c (composition_table_size, n_compositions)
749 (get_composition_id, composition_gstring_from_id):
750 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
751 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
752 * window.c (Frecenter):
753 Use ptrdiff_t, not int, for composition IDs.
754 * composite.c (get_composition_id): Check for integer overflow.
755 * composite.h: Adjust prototypes to match the above changes.
756
757 Use ptrdiff_t for hash table indexes.
758 * category.c (hash_get_category_set):
759 * ccl.c (ccl_driver):
760 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
761 * coding.c (coding_system_charset_list, detect_coding_system):
762 * coding.h (struct coding_system.id):
763 * composite.c (get_composition_id, gstring_lookup_cache):
764 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
765 * image.c (xpm_get_color_table_h):
766 * lisp.h (hash_lookup, hash_put):
767 * minibuf.c (Ftest_completion):
768 Use ptrdiff_t for hash table indexes, not int (which is too
769 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
770 32-bit --with-wide-int hosts).
771
772 * charset.c (Fdefine_charset_internal): Check for integer overflow.
773 Add a FIXME comment about memory leaks.
774 (syms_of_charset): Don't assume xmalloc returns.
775
776 Don't assume that stated character widths fit in int.
777 * character.c (Fchar_width, c_string_width, lisp_string_width):
778 * character.h (CHAR_WIDTH):
779 * indent.c (MULTIBYTE_BYTES_WIDTH):
780 Use sanitize_char_width to avoid undefined and/or bad behavior
781 with outlandish widths.
782 * character.h (sanitize_tab_width): Renamed from sanitize_width,
783 now that we have two such functions. All uses changed.
784 (sanitize_char_width): New inline function.
785
786 Don't assume that tab-width fits in int.
787 * character.h (sanitize_width): New inline function.
788 (SANE_TAB_WIDTH): New macro.
789 (ASCII_CHAR_WIDTH): Use it.
790 * indent.c (sane_tab_width): Remove. All uses replaced by
791 SANE_TAB_WIDTH (current_buffer).
792 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
793
794 * fileio.c: Integer overflow issues with file modes.
795 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
796
797 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
798 Remove unreachable code.
799 (read_hex, load_charset_map_from_file): Check for integer overflow.
800
801 * xterm.c: don't go over XClientMessageEvent limit
802 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
803 (x_send_scroll_bar_event): Likewise. Check that the size does not
804 exceed limits imposed by XClientMessageEvent, as well as the usual
805 ptrdiff_t and size_t limits.
806
807 * keyboard.c: Overflow, signedness and related fixes.
808 (make_lispy_movement): Use same integer type in forward decl
809 that is used in the definition.
810 (read_key_sequence, keyremap_step):
811 Change bufsize argument back to int, undoing my 2011-03-30 change.
812 We prefer signed types, and int is wide enough here.
813 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
814 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
815 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
816 length, not size_t. Use ptrdiff_t for index, not int.
817 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
818 possibility of integer overflow.
819
820 Overflow, signedness and related fixes for images.
821
822 * dispextern.h (struct it.stack[0].u.image.image_id)
823 (struct_it.image_id, struct image.id, struct image_cache.size)
824 (struct image_cache.used, struct image_cache.ref_count):
825 * gtkutil.c (update_frame_tool_bar):
826 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
827 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
828 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
829 * nsmenu.m (update_frame_tool_bar):
830 * xdisp.c (calc_pixel_width_or_height):
831 * xfns.c (image_cache_refcount):
832 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
833 on typical 64-bit hosts.
834
835 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
836 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
837 Omit unnecessary casts to int.
838 (parse_image_spec): Check that integers fall into 'int' range
839 when the callers expect that.
840 (image_ascent): Redo ascent calculation to avoid int overflow.
841 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
842 (lookup_image): Remove unnecessary tests.
843 (xbm_image_p): Locals are now of int, not EMACS_INT,
844 since parse_image_check makes sure they fit into int.
845 (png_load, gif_load, svg_load_image):
846 Prefer int to unsigned where either will do.
847 (tiff_handler): New function, combining the cores of the
848 old tiff_error_handler and tiff_warning_handler. This
849 function is rewritten to use vsnprintf and thereby avoid
850 stack buffer overflows. It uses only the features of vsnprintf
851 that are common to both POSIX and native Microsoft.
852 (tiff_error_handler, tiff_warning_handler): Use it.
853 (tiff_load, gif_load, imagemagick_load_image):
854 Don't assume :index value fits in 'int'.
855 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
856 (imagemagick_load_image): Check that crop parameters fit into
857 the integer types that MagickCropImage accepts. Don't assume
858 Vimagemagick_render_type has a nonnegative value. Don't assume
859 size_t fits in 'long'.
860 (gs_load): Use printmax_t to print the widest integers possible.
861 Check for integer overflow when computing image height and width.
862
863 2011-08-26 Eli Zaretskii <eliz@gnu.org>
864
865 * xdisp.c (redisplay_window): Don't force window start if point
866 will be invisible in the resulting window. (Bug#9324)
867
868 2011-08-25 Eli Zaretskii <eliz@gnu.org>
869
870 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
871 the display spec is of the form `(space ...)'.
872 (handle_display_spec): Return the value returned by
873 handle_single_display_spec, not just 1 or zero.
874 (handle_single_display_spec): If the display spec is of the form
875 `(space ...)', and specifies display in the text area, return 2
876 rather than 1.
877 (try_cursor_movement): Check for the need to scroll more
878 accurately, and prefer exact match for point under bidi. Don't
879 advance `row' beyond the last row of the window.
880
881 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
882 into disp_prop; all users changed.
883
884 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
885 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
886 for the text covered by the display property.
887
888 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
889
890 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
891 Change return value to nil.
892 (Frecord_buffer): Delete unused function.
893
894 2011-08-24 Eli Zaretskii <eliz@gnu.org>
895
896 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
897 buffers, return left-to-right.
898 (set_cursor_from_row): Consider candidate row a win if its glyph
899 represents a newline and point is on that newline. Fixes cursor
900 positioning on the newline at EOL of R2L text within L2R
901 paragraph, and vice versa.
902 (try_cursor_movement): Check continued rows, in addition to
903 continuation rows. Fixes unwarranted scroll when point enters a
904 continued line of R2L text within an L2R paragraph, or vice versa.
905 (cursor_row_p): Consider the case of point being equal to
906 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
907 from the end of a short line to the beginning of a continued line
908 of R2L text within L2R paragraph.
909 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
910 composed characters.
911
912 * bidi.c (bidi_check_type): Use xassert.
913 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
914 members.
915
916 2011-08-23 Eli Zaretskii <eliz@gnu.org>
917
918 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
919 a character.
920
921 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
922
923 * nsfont.m (ns_otf_to_script): Fix typo.
924
925 2011-08-22 Kenichi Handa <handa@m17n.org>
926
927 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
928 extra slot even if the purpose is char-code-property-table.
929
930 2011-08-23 Eli Zaretskii <eliz@gnu.org>
931
932 * xdisp.c (redisplay_window): When computing centering_position,
933 account for the height of the header line. (Bug#8874)
934
935 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
936 instead of CHAR_TO_BYTE. Fixes a crash when a completion
937 candidate is selected by the mouse, and that candidate has a
938 composed character under the mouse.
939
940 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
941 coordinates reported by pos-visible-in-window-p for a composed
942 character in column zero.
943
944 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
945
946 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
947
948 2011-08-22 Eli Zaretskii <eliz@gnu.org>
949
950 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
951 consider it a hit if to_charpos is anywhere in the range of the
952 composed buffer positions.
953
954 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
955
956 * image.c (gif_load): Don't assume that each subimage has the same
957 dimensions as the base image. Handle disposal method that is
958 "undefined" by the gif spec (Bug#9335).
959
960 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
961
962 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
963 (Fcondition_case): Document `debug' symbol in error handler.
964
965 2011-08-19 Eli Zaretskii <eliz@gnu.org>
966
967 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
968 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
969 from an Org mode buffer to a Speedbar frame.
970
971 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
972 a composition, take its buffer position from IT->cmp_it.charpos.
973 Fixes cursor positioning at the beginning of a line that begins
974 with a composed character.
975
976 2011-08-18 Eli Zaretskii <eliz@gnu.org>
977
978 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
979 character bidirectional type, use STRONG_L instead. Fixes crashes
980 in a buffer produced by `describe-categories'.
981
982 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
983 members before the level stack, so they would be saved and
984 restored when copying iterator state. Fixes incorrect reordering
985 around TABs covered by display properties.
986
987 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
988
989 * process.c (Fnetwork_interface_list): Correctly determine buffer
990 size.
991
992 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
993
994 * eval.c (internal_condition_case, internal_condition_case_1)
995 (internal_condition_case_2, internal_condition_case_n):
996 Remove unnecessary aborts (Bug#9081).
997
998 2011-08-17 Eli Zaretskii <eliz@gnu.org>
999
1000 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1001 has no `load' handler, try opening the file locally. (Bug#9311)
1002
1003 2011-08-16 Ken Brown <kbrown@cornell.edu>
1004
1005 * gmalloc.c: Expand comment.
1006
1007 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1008
1009 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1010 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1011
1012 2011-08-16 Ken Brown <kbrown@cornell.edu>
1013
1014 Fix memory allocation problems in Cygwin build (Bug#9273).
1015
1016 * unexcw.c ( __malloc_initialized): Declare external variable.
1017 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1018
1019 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1020 New variables.
1021 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1022 dumped emacs.
1023 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1024 in the static heap.
1025 [CYGWIN] (special_realloc): New function.
1026 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1027 requests to realloc storage in the static heap.
1028
1029 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1030
1031 * bidi.c (bidi_initialize): Remove unused local.
1032
1033 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1034
1035 * biditype.h: File removed.
1036
1037 * bidimirror.h: File removed.
1038
1039 * deps.mk (bidi.o): Remove biditype.h and
1040 bidimirror.h.
1041
1042 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1043 bidimirror.h.
1044
1045 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1046
1047 * chartab.c: Improve commentary for the uniprop_table API.
1048
1049 * bidi.c (bidi_paragraph_init): Support zero value of
1050 bidi_ignore_explicit_marks_for_paragraph_level.
1051 (bidi_initialize): Use uniprop_table instead of including
1052 biditype.h and bidimirror.h.
1053
1054 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1055 coordinates of the iterator when restoring from ppos_it.
1056 (Bug#9296)
1057
1058 2011-08-14 Kenichi Handa <handa@m17n.org>
1059
1060 * process.c (create_process): Call setup_process_coding_systems
1061 after the pid of the process is set to -1 (Bug#8162).
1062
1063 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1064
1065 * xdisp.c (move_it_in_display_line_to): Don't invoke
1066 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1067 ppos_it. Fixes vertical cursor motion when line beginning is
1068 covered by an image. (Bug#9296)
1069
1070 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1071
1072 * nsterm.h (ns_run_ascript): Declare.
1073 (NSAPP_DATA2_RUNASSCRIPT): Define.
1074
1075 * nsfns.m (as_script, as_result, as_status): New static variables.
1076 (ns_run_ascript): New function.
1077 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1078 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1079 the event loop. Get status from as_status (Bug#7276).
1080
1081 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1082 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1083 the event loop (Bug#7276).
1084
1085 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1086
1087 * gnutls.c (QCgnutls_bootprop_priority)
1088 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1089 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1090 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1091 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1092 (QCgnutls_bootprop_verify_hostname_error)
1093 (QCgnutls_bootprop_callbacks_verify): Rename from
1094 Qgnutls_bootprop_..., all uses changed.
1095
1096 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1097 uses changed.
1098
1099 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1100
1101 * xfaces.c (Qframe_set_background_mode): Now static.
1102 * dispextern.h (Qframe_set_background_mode): Remove decl.
1103
1104 * process.c (Fnetwork_interface_info): Declare local only if needed.
1105
1106 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1107
1108 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1109 (Fnetwork_interface_list): Allocate in increments of bytes instead
1110 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1111 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1112 sockaddr.
1113 (struct ifflag_def): notrailers is smart on OSX.
1114 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1115 Get hardware address with getifaddrs if available.
1116
1117 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1118
1119 * xdisp.c (iterate_out_of_display_property): xassert that
1120 IT->position is set to within IT->object's boundaries. Break from
1121 the loop as soon as EOB is reached; avoids infloops in redisplay
1122 when IT->position is set up wrongly due to some bug.
1123 Set IT->current to match the bidi iterator unconditionally.
1124 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1125 entry. Force push_it to save on the stack the current
1126 buffer/string position, to be restored by pop_it. Fix flags in
1127 the iterator structure wrt the object coming from a display
1128 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1129 properties. (Bug#9284)
1130
1131 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1132
1133 * fontset.c (fontset_get_font_group): Add proper type checks.
1134 (Bug#9172)
1135
1136 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1137
1138 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1139 and LC_VERSION_MIN_MACOSX.
1140 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1141 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1142
1143 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1144
1145 * xdisp.c (forward_to_next_line_start): Allow to use the
1146 no-display-properties-and-no-overlays under bidi display.
1147 Set disp_pos in the bidi iterator to avoid searches for display
1148 properties and overlays.
1149
1150 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1151
1152 * editfns.c (Fset_time_zone_rule): Document relationship with the
1153 setenv function.
1154
1155 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1156 the font entity extracted from the cache (Bug#8109).
1157
1158 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1159
1160 * composite.c (autocmp_chars): Don't reset point. That is done by
1161 restore_point_unwind (Bug#5984).
1162
1163 2011-08-07 Juri Linkov <juri@jurta.org>
1164
1165 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1166 to show the arg `TIME' instead of `TIMEVAL'.
1167
1168 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1169
1170 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1171 display property strides EOL and includes a newline, as in
1172 longlines-mode. (Bug#9254)
1173 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1174 word-wrap under bidirectional display. (Bug#9224)
1175
1176 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1177 is non-zero, even if the data buffer is NULL. Fixes a crash in
1178 vertical-motion with longlines-mode. (Bug#9254)
1179
1180 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1181
1182 * bidi.c <bidi_cache_total_alloc>: Now static.
1183 (bidi_initialize): Initialize bidi_cache_total_alloc.
1184
1185 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1186 cache. (Bug#9221)
1187
1188 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1189 amount allocated this far in `bidi_cache_total_alloc'.
1190 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1191 non-zero, only free the data buffer without restoring the cache
1192 contents. All callers changed.
1193
1194 * dispextern.h (bidi_unshelve_cache): Update prototype.
1195
1196 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1197 (move_it_in_display_line, move_it_to)
1198 (move_it_vertically_backward, move_it_by_lines): Replace the call
1199 to xfree to an equivalent call to bidi_unshelve_cache.
1200 (move_it_in_display_line_to): Fix logic of returning
1201 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1202
1203 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1204
1205 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1206 came from a string character with a `cursor' property. (Bug#9229)
1207
1208 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1209
1210 * Makefile.in (LIB_PTHREAD): New variable.
1211 (LIBES): Add LIB_PTHREAD (Bug#9216).
1212
1213 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1214 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1215
1216 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1217
1218 * regex.c (re_iswctype): Remove some redundant boolean
1219 conversions.
1220
1221 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1222
1223 * xterm.c (x_find_topmost_parent): New function.
1224 (x_set_frame_alpha): Find topmost parent window with
1225 x_find_topmost_parent and set the property there also (bug#9181).
1226 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1227
1228 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1229
1230 * callproc.c (Fcall_process): Avoid vfork clobbering
1231 the local vars buffer, coding_systems, current_dir.
1232
1233 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1234
1235 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1236
1237 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1238
1239 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1240 so that it is not optimized away.
1241
1242 * xdisp.c (compute_display_string_pos): Remove unused local.
1243
1244 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1245
1246 Fix slow cursor motion and scrolling in large buffers with
1247 selective display, like Org Mode buffers. (Bug#9218)
1248
1249 * dispextern.h (struct bidi_it): New member disp_prop_p.
1250
1251 * xdisp.c: Remove one-slot cache of display string positions.
1252 (compute_display_string_pos): Accept an additional argument
1253 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1254 for a display string or property. If found, set DISP_PROP_P
1255 non-zero.
1256
1257 * bidi.c (bidi_fetch_char): Accept an additional argument
1258 DISP_PROP_P, and pass it to compute_display_string_pos.
1259 Only handle text covered by a display string if DISP_PROP_P is returned
1260 non-zero. All callers of bidi_fetch_char changed.
1261
1262 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1263
1264 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1265
1266 2010-12-03 Don March <don@ohspite.net>
1267
1268 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1269 last character M-[char] is translated to ESC [char] (bug#7541).
1270
1271 2011-08-02 Kenichi Handa <handa@m17n.org>
1272
1273 * lisp.h (uniprop_table): Extern it.
1274
1275 * chartab.c (uniprop_table): Make it non-static.
1276
1277 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1278
1279 * xdisp.c (forward_to_next_line_start): Accept additional argument
1280 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1281 on the newline.
1282 (reseat_at_next_visible_line_start): Use the bidi iterator state
1283 returned by forward_to_next_line_start to restore the state of
1284 it->bidi_it after backing up to previous newline. (Bug#9212)
1285
1286 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1287
1288 * regex.c (re_comp): Protoize.
1289 (re_exec): Fix return type.
1290 (regexec): Fix type of `ret'. (Bug#9203)
1291
1292 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1293
1294 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1295 This is needed if max-image-size is a floating-point number.
1296
1297 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1298
1299 * print.c (print_object): Print empty symbol as ##.
1300
1301 * lread.c (read1): Read ## as empty symbol.
1302
1303 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1304
1305 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1306 setting frame foreground color (Bug#9175).
1307 (x_set_background_color): Likewise.
1308
1309 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1310 contents (Bug#9176).
1311 (EmacsTooltip -init): Remove bezels and add shadows to
1312 tooltip windows.
1313
1314 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1315 or scroll bar (Bug#8470).
1316
1317 * nsfont.m (nsfont_open): Remove assignment to voffset and
1318 unnecessary vars hshink, expand, hd, full_height, min_height.
1319 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1320
1321 * nsterm.h (nsfont_info): Remove voffset field.
1322
1323 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1324
1325 Implement strike-through and overline on NextStep (Bug#8863).
1326
1327 * nsfont.m (nsfont_open): Use underline position provided by font,
1328 instead of hard-coded value of 2.
1329 (nsfont_draw): Call ns_draw_text_decoration instead.
1330
1331 * nsterm.h: Add declaration for ns_draw_text_decoration.
1332
1333 * nsterm.m (ns_draw_text_decoration): New function for drawing
1334 underline, overline, and strike-through.
1335 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1336 ns_draw_text_decoration. Change treatment of cursor drawing to
1337 accommodate underlining, etc.
1338
1339 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1340
1341 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1342 default.
1343
1344 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1345
1346 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1347 Without this fix, if a signal arrives just after memory fills up,
1348 'malloc' might be invoked reentrantly.
1349
1350 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1351 In other words, assume that every image size is allowed, on non-X
1352 hosts. This assumption is probably wrong, but it lets Emacs compile.
1353
1354 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1355
1356 * regex.c (re_iswctype): Convert return values to boolean.
1357
1358 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1359
1360 * xdisp.c (compute_display_string_pos): Don't use cached display
1361 string position if the buffer had its restriction changed.
1362 (Bug#9184)
1363
1364 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1365
1366 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1367
1368 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1369
1370 Integer signedness and overflow and related fixes. (Bug#9079)
1371
1372 * bidi.c: Integer size and overflow fixes.
1373 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1374 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1375 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1376 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1377 (bidi_find_other_level_edge):
1378 Use ptrdiff_t instead of EMACS_INT where either will do.
1379 This works better on 32-bit hosts configured --with-wide-int.
1380 (bidi_cache_ensure_space): Check for size-calculation overflow.
1381 Use % rather than repeated addition, for better worst-case speed.
1382 Don't set bidi_cache_size until after xrealloc returns, because it
1383 might not return.
1384 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1385 (bidi_cache_ensure_space): Also check that the bidi cache size
1386 does not exceed that of the largest Lisp string or buffer. See Eli
1387 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1388
1389 * alloc.c (__malloc_size_t): Remove.
1390 All uses replaced by size_t. See Andreas Schwab's note
1391 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1392
1393 * image.c: Improve checking for integer overflow.
1394 (check_image_size): Assume that f is nonnull, since
1395 it is always nonnull in practice. This is one less thing to
1396 worry about when checking for integer overflow later.
1397 (x_check_image_size): New function, which checks for integer
1398 overflow issues inside X.
1399 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1400 This removes the need for a memory_full check.
1401 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1402 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1403 (xbm_read_bitmap_data): Change locals back to 'int', since
1404 their values must fit in 'int'.
1405 (xpm_load_image, png_load, tiff_load):
1406 Invoke x_create_x_image_and_pixmap earlier,
1407 to avoid much needless work if the image is too large.
1408 (tiff_load): Treat overly large images as if
1409 x_create_x_image_and_pixmap failed, not as malloc failures.
1410 (gs_load): Use x_check_image_size.
1411
1412 * gtkutil.c: Omit integer casts.
1413 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1414 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1415
1416 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1417
1418 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1419 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1420 would wrongly return t on a 64-bit host.
1421
1422 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1423 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1424 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1425 and therefore cause GCC to emit a bogus diagnostic in some cases.
1426
1427 * image.c: Integer signedness and overflow and related fixes.
1428 This is not an exhaustive set of fixes, but it's time to
1429 record what I've got.
1430 (lookup_pixel_color, check_image_size): Remove redundant decls.
1431 (check_image_size): Don't assume that arbitrary EMACS_INT values
1432 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1433 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1434 (tiff_load, imagemagick_load_image):
1435 Check for overflow in size calculations.
1436 (x_create_x_image_and_pixmap): Remove unnecessary test for
1437 xmalloc returning NULL; that can't happen.
1438 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1439 (xpm_color_bucket): Use better integer hashing function.
1440 (xpm_cache_color): Don't possibly over-allocate memory.
1441 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1442 (gif_memory_source):
1443 Use ptrdiff_t, not int or size_t, to record sizes.
1444 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1445 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1446 either works, as we prefer signed integers.
1447 (tiff_read_from_memory, tiff_write_from_memory):
1448 Return tsize_t, not size_t, since that's what the TIFF API wants.
1449 (tiff_read_from_memory): Don't fail simply because the read would
1450 go past EOF; instead, return a short read.
1451 (tiff_load): Omit no-longer-needed casts.
1452 (Fimagemagick_types): Don't assume size fits into 'int'.
1453
1454 Improve hashing quality when configured --with-wide-int.
1455 * fns.c (hash_string): New function, taken from sxhash_string.
1456 Do not discard information about ASCII character case; this
1457 discarding is no longer needed.
1458 (sxhash-string): Use it. Change sig to match it. Caller changed.
1459 * lisp.h: Declare it.
1460 * lread.c (hash_string): Remove, since we now use fns.c's version.
1461 The fns.c version returns a wider integer if --with-wide-int is
1462 specified, so this should help the quality of the hashing a bit.
1463
1464 * emacs.c: Integer overflow minor fix.
1465 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1466 Define only if GNU_LINUX.
1467 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1468
1469 * dispnew.c: Integer signedness and overflow fixes.
1470 Remove unnecessary forward decls, that were a maintenance hassle.
1471 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1472 All uses changed.
1473 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1474 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1475 (prepare_desired_row, line_draw_cost):
1476 Use int, not unsigned, where either works.
1477 (save_current_matrix, restore_current_matrix):
1478 Use ptrdiff_t, not size_t, where either works.
1479 (init_display): Check for overflow more accurately, and without
1480 relying on undefined behavior.
1481
1482 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1483 Remove, replacing with the new symbols in lisp.h. All uses changed.
1484 * fileio.c (make_temp_name):
1485 * filelock.c (lock_file_1, lock_file):
1486 * xdisp.c (message_dolog):
1487 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1488 Use pMd etc. instead.
1489 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1490 replacing the pWIDE etc. symbols removed from editfns.c.
1491
1492 * keyboard.h (num_input_events): Now uintmax_t.
1493 This is (very slightly) less likely to mess up due to wraparound.
1494 All uses changed.
1495
1496 * buffer.c: Integer signedness fixes.
1497 (alloc_buffer_text, enlarge_buffer_text):
1498 Use ptrdiff_t rather than size_t when either will do, as we prefer
1499 signed integers.
1500
1501 * alloc.c: Integer signedness and overflow fixes.
1502 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1503 (__malloc_size_t): Default to size_t, not to int.
1504 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1505 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1506 Prefer ptrdiff_t to size_t when either would do, as we prefer
1507 signed integers.
1508 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1509 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1510 Now const. Initialize with values that are in range even if char
1511 is signed.
1512 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1513 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1514 These functions do the right thing with sizes > 2**32.
1515 (check_depth): Now ptrdiff_t, not int.
1516 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1517 Adjust to new way of storing sizes. Check for size overflow bugs
1518 in rest of code.
1519 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1520 slightly wrong anyway, as it missed one instance of
1521 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1522 (refill_memory_reserve): Omit needless cast to size_t.
1523 (mark_object_loop_halt): Mark as externally visible.
1524
1525 * xselect.c: Integer signedness and overflow fixes.
1526 (Fx_register_dnd_atom, x_handle_dnd_message):
1527 Use ptrdiff_t, not size_t, since we prefer signed.
1528 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1529 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1530 x_dnd_atoms_size and x_dnd_atoms_length.
1531
1532 * doprnt.c: Prefer signed to unsigned when either works.
1533 * eval.c (verror):
1534 * doprnt.c (doprnt):
1535 * lisp.h (doprnt):
1536 * xdisp.c (vmessage):
1537 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1538 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1539 prefer signed arithmetic to avoid comparison confusion.
1540 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1541 but is a bit tricky.
1542
1543 Assume freestanding C89 headers, string.h, stdlib.h.
1544 * data.c, doprnt.c, floatfns.c, print.c:
1545 Include float.h unconditionally.
1546 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1547 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1548 * regex.c: Likewise for stddef.h, string.h.
1549 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1550 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1551 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1552 (STDC_HEADERS): Remove obsolete defines.
1553 * sysdep.c: Include limits.h unconditionally.
1554
1555 Assume support for memcmp, memcpy, memmove, memset.
1556 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1557 * regex.c (memcmp, memcpy):
1558 Remove; we assume C89 now.
1559
1560 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1561 (__malloc_safe_bcopy): Remove; no longer needed.
1562
1563 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1564 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1565 well either way, and we prefer signed to unsigned.
1566
1567 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1568
1569 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1570 closes the connection while we're reading (bug#9182).
1571
1572 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1573
1574 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1575 are specified (Bug#9168).
1576
1577 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1578
1579 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1580 Found by GCC static checking and --with-wide-int on a 32-bit host.
1581
1582 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1583
1584 * xdisp.c (compute_display_string_pos): Fix logic of caching
1585 previous display string position. Initialize cached_prev_pos to
1586 -1. Fixes slow-down at the beginning of a buffer.
1587
1588 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1589
1590 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1591 for attrs[LFACE_FONTSET_INDEX].
1592
1593 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1594
1595 * xml.c (parse_region): Remove unused local
1596 that was recently introduced.
1597
1598 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1599
1600 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1601 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1602
1603 * xdisp.c (move_it_in_display_line_to): Record the best matching
1604 position for TO_CHARPOS while scanning the line, and restore it on
1605 exit if none of the characters scanned was an exact match.
1606 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1607 when exact match is impossible due to invisible text, and the
1608 lines are truncated.
1609
1610 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1611
1612 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1613 for OSX >= 10.7.
1614
1615 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1616
1617 Fix a significant slow-down of cursor motion with C-n, C-p,
1618 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1619 auto-repeat under bidi redisplay in fontified buffers.
1620 * xdisp.c (compute_stop_pos_backwards): New function.
1621 (next_element_from_buffer): Call compute_stop_pos_backwards to
1622 find a suitable prev_stop when we find ourselves before
1623 base_level_stop.
1624 (reseat): Don't look for prev_stop, as that could mean a very long
1625 run.
1626 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1627 <cached_disp_overlay_modiff>: Cache for last found display string
1628 position.
1629 (compute_display_string_pos): Return the cached position if asked
1630 about the same buffer in the same area of character positions, and
1631 the buffer wasn't changed since the time the display string
1632 position was cached.
1633
1634 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1635
1636 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1637 is an integer, which is important for empty lines. (Bug#9149)
1638
1639 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1640
1641 * frame.c (Fmodify_frame_parameters): In tty case, update the
1642 default face if necessary (Bug#4238).
1643
1644 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1645
1646 * editfns.c (Fstring_to_char): No need to explain what a character
1647 is in the docstring (Bug#6576).
1648
1649 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1650
1651 * xml.c (parse_region): Make sure we always return a tree.
1652
1653 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1654
1655 * xml.c (parse_region): If a document contains only comments,
1656 return that, too.
1657
1658 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1659
1660 * xml.c (make_dom): Return comments, too.
1661
1662 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1663
1664 Port to OpenBSD.
1665 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1666 and the surrounding thread.
1667 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1668 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1669 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1670 timer goes off.
1671 * s/openbsd.h (BROKEN_SIGIO): Define.
1672 * unexelf.c (unexec) [__OpenBSD__]:
1673 Don't update the .mdebug section of the Alpha COFF symbol table.
1674
1675 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1676
1677 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1678 (bug#8460).
1679
1680 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1681
1682 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1683 This fixes some race conditions on the permissions of any newly
1684 created file.
1685
1686 * alloc.c (valid_pointer_p): Use pipe, not open.
1687 This fixes some permissions issues when debugging.
1688
1689 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1690 If fchown fails to set both uid and gid, try to set just gid,
1691 as that is sometimes allowed. Adjust the file's mode to eliminate
1692 setuid or setgid bits that are inappropriate if fchown fails.
1693
1694 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1695
1696 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1697 to compare Lisp_Objects.
1698 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1699 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1700 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1701
1702 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1703
1704 * lread.c (read_integer): Unread even EOF character.
1705 (read1): Likewise. Properly record start position of symbol.
1706
1707 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1708 symbol character follows.
1709
1710 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1711
1712 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1713 This works around a problem with the previous change to Fcopy_file.
1714 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1715 and without this change, GCC might complain about discarding
1716 fchown's return value.
1717
1718 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1719
1720 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1721
1722 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1723
1724 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1725
1726 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1727
1728 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1729 it's used from the C level.
1730
1731 * process.c: Use the same condition for POLL_FOR_INPUT in both
1732 keyboard.c and process.c (bug#1858).
1733
1734 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1735
1736 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1737 (Fgnutls_boot): Use it.
1738
1739 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1740
1741 * doc.c (Fsubstitute_command_keys): Revert last change.
1742
1743 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1744
1745 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1746 quotes the next character, and doesn't affect other longer
1747 sequences (bug#8935).
1748
1749 * lread.c (syms_of_lread): Clarify that is isn't only
1750 `eval-buffer' and `eval-defun' that's affected by
1751 `lexical-binding' (bug#8460).
1752
1753 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1754
1755 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1756 bidi redisplay when a line includes both an image and is
1757 truncated.
1758
1759 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1760
1761 Fix minor problems found by static checking.
1762 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1763 (elsz): Now a signed constant, not a size_t var. We prefer signed
1764 types to unsigned, to avoid integer comparison confusion. Without
1765 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1766 "cannot optimize loop, the loop counter may overflow", a symptom
1767 of the confusion.
1768 * indent.c (Fvertical_motion): Mark locals as initialized.
1769 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1770
1771 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1772
1773 * search.c (Fre_search_backward): Mention `case-fold-search' in
1774 all the re_search_* functions (bug#8138).
1775
1776 * keyboard.c (Fopen_dribble_file): Document when the file is
1777 closed (bug#8056).
1778
1779 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1780
1781 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1782 bidi_cache_idx.
1783
1784 Support bidi reordering of display and overlay strings.
1785 * xdisp.c (compute_display_string_pos)
1786 (compute_display_string_end): Accept additional argument STRING.
1787 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1788 (reseat_to_string): Initialize bidi_it->string.s and
1789 bidi_it->string.schars.
1790 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1791 NULL (avoids a crash in bidi_paragraph_init).
1792 Initialize itb.string.lstring.
1793 (init_iterator): Call bidi_init_it only of a valid
1794 buffer position was specified. Initialize paragraph_embedding to
1795 L2R.
1796 (reseat_to_string): Initialize the bidi iterator.
1797 (display_string): If we need to ignore text properties of
1798 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1799 original value of -1 will not work with bidi.)
1800 (compute_display_string_pos): First arg is now struct
1801 `text_pos *'; all callers changed. Support display properties on
1802 Lisp strings.
1803 (compute_display_string_end): Support display properties on Lisp
1804 strings.
1805 (init_iterator, reseat_1, reseat_to_string): Initialize the
1806 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1807 when iterating on a string not from display properties).
1808 (compute_display_string_pos, compute_display_string_end):
1809 Fix calculation of the object to scan. Fixes an error when using
1810 arrow keys.
1811 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1812 base_level_stop; instead, set base_level_stop to BEGV.
1813 Fixes crashes in vertical-motion.
1814 (next_element_from_buffer): Improve commentary for when
1815 the iterator is before prev_stop.
1816 (init_iterator): Initialize bidi_p from the default value of
1817 bidi-display-reordering, not from buffer-local value. Use the
1818 buffer-local value only if initializing for buffer iteration.
1819 (handle_invisible_prop): Support invisible properties on strings
1820 that are being bidi-reordered.
1821 (set_iterator_to_next): Support bidi reordering of C strings and
1822 Lisp strings.
1823 (next_element_from_string): Support bidi reordering of Lisp
1824 strings.
1825 (handle_stop_backwards): Support Lisp strings as well.
1826 (display_string): Support display of R2L glyph rows.
1827 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1828 (init_iterator): Don't initialize it->bidi_p for strings
1829 here.
1830 (reseat_to_string): Initialize it->bidi_p for strings here.
1831 (next_element_from_string, next_element_from_c_string)
1832 (next_element_from_buffer): Add xassert's for correspondence
1833 between IT's object being iterated and it->bidi_it.string
1834 structure.
1835 (face_before_or_after_it_pos): Support bidi iteration.
1836 (next_element_from_c_string): Handle the case of the first string
1837 character that is not the first one in the visual order.
1838 (get_visually_first_element): New function, refactored from common
1839 parts of next_element_from_buffer, next_element_from_string, and
1840 next_element_from_c_string.
1841 (tool_bar_lines_needed, redisplay_tool_bar)
1842 (display_menu_bar): Force left-to-right direction. Add a FIXME
1843 comment for making that be controlled by a user option.
1844 (push_it, pop_it): Save and restore the state of the
1845 bidi iterator. Save and restore the bidi_p flag.
1846 (pop_it): Iterate out of display property for string iteration as
1847 well.
1848 (iterate_out_of_display_property): Support iteration over strings.
1849 (handle_single_display_spec): Set up it->bidi_it for iteration
1850 over a display string, and call bidi_init_it.
1851 (handle_single_display_spec, next_overlay_string)
1852 (get_overlay_strings_1, push_display_prop): Set up the bidi
1853 iterator for displaying display or overlay strings.
1854 (forward_to_next_line_start): Don't use the shortcut if
1855 bidi-iterating.
1856 (back_to_previous_visible_line_start): If handle_display_prop
1857 pushed the iterator stack, restore the internal state of the bidi
1858 iterator by calling bidi_pop_it same number of times.
1859 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1860 and we are bidi-iterating, don't decrement the iterator position;
1861 instead, set the first_elt flag in the bidi iterator, to produce
1862 the same effect.
1863 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1864 (push_display_prop): xassert that we are iterating a buffer.
1865 (push_it, pop_it): Save and restore paragraph_embedding member.
1866 (handle_single_display_spec, next_overlay_string)
1867 (get_overlay_strings_1, reseat_1, reseat_to_string)
1868 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1869 correctly. Don't assume unibyte strings are not bidi-reordered.
1870 (compute_display_string_pos)
1871 (compute_display_string_end): Fix handling the case of C string.
1872 (push_it, pop_it): Save and restore from_disp_prop_p.
1873 (handle_single_display_spec, push_display_prop): Set the
1874 from_disp_prop_p flag.
1875 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1876 (pop_it): Call iterate_out_of_display_property only if we are
1877 popping after iteration over a string that came from a display
1878 property. Fix a typo in popping stretch info. Add an assertion
1879 for verifying that the iterator position is in sync with the bidi
1880 iterator.
1881 (handle_single_display_spec, get_overlay_strings_1)
1882 (push_display_prop): Fix initialization of paragraph direction for
1883 string when that of the parent object is not yet determined.
1884 (reseat_1): Call bidi_init_it to resync the bidi
1885 iterator with IT's position. (Bug#7616)
1886 (find_row_edges): If ROW->start.pos gives position
1887 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1888 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1889 Reset the from_disp_prop_p flag.
1890 (SAVE_IT, RESTORE_IT): New macros.
1891 (pos_visible_p, face_before_or_after_it_pos)
1892 (back_to_previous_visible_line_start)
1893 (move_it_in_display_line_to, move_it_in_display_line)
1894 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1895 (try_scrolling, redisplay_window, display_line): Use them when
1896 saving a temporary copy of the iterator and restoring it back.
1897 (back_to_previous_visible_line_start, reseat_1)
1898 (init_iterator): Empty the bidi cache "stack".
1899 (move_it_in_display_line_to): If iterator ended up at
1900 EOL, but we never saw any buffer positions smaller than
1901 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1902 motion in bidi-reordered lines.
1903 (move_it_in_display_line_to): Record prev_method and prev_pos
1904 immediately before the call to set_iterator_to_next. Fixes cursor
1905 motion in bidi-reordered lines with stretch glyphs and strings
1906 displayed in margins. (Bug#8133) (Bug#8867)
1907 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1908 TO_CHARPOS.
1909 (pos_visible_p): Support positions in bidi-reordered lines.
1910 Save and restore bidi cache.
1911
1912 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1913 (bidi_paragraph_info): Delete unused struct.
1914 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1915 (bidi_cache_start): New variable.
1916 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1917 to zero.
1918 (bidi_cache_fetch_state, bidi_cache_search)
1919 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1920 (bidi_cache_find, bidi_peek_at_next_level)
1921 (bidi_level_of_next_char, bidi_find_other_level_edge)
1922 (bidi_move_to_visually_next): Compare cache index with
1923 bidi_cache_start rather than with zero.
1924 (bidi_fetch_char): Accept new argument STRING; all callers
1925 changed. Support iteration over a string. Support strings with
1926 display properties. Support unibyte strings. Fix the type of
1927 `len' according to what STRING_CHAR_AND_LENGTH expects.
1928 (bidi_paragraph_init, bidi_resolve_explicit_1)
1929 (bidi_resolve_explicit, bidi_resolve_weak)
1930 (bidi_level_of_next_char, bidi_move_to_visually_next):
1931 Support iteration over a string.
1932 (bidi_set_sor_type, bidi_resolve_explicit_1)
1933 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1934 can now be zero (for strings); special values 0 and -1 were
1935 changed to -1 and -2, respectively.
1936 (bidi_char_at_pos): New function.
1937 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1938 Call it instead of FETCH_MULTIBYTE_CHAR.
1939 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1940 initialized to valid values.
1941 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1942 values.
1943 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1944 the test for valid cached positions. Fix the logic for looking up
1945 the sentinel state in the cache. GCPRO the Lisp string we are
1946 iterating.
1947 (bidi_push_it, bidi_pop_it): New functions.
1948 (bidi_initialize): Initialize the bidi cache start stack pointer.
1949 (bidi_cache_ensure_space): New function, refactored from part of
1950 bidi_cache_iterator_state. Don't assume the required size is just
1951 one BIDI_CACHE_CHUNK away.
1952 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1953 (bidi_count_bytes, bidi_char_at_pos): New functions.
1954 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1955 always valid if bidi_cache_idx is valid.
1956 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1957 is valid if it's going to be used.
1958 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1959 (bidi_cache_fetch_state, bidi_cache_search)
1960 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1961 (bidi_cache_iterator_state, bidi_cache_find)
1962 (bidi_find_other_level_edge, bidi_cache_start_stack):
1963 All variables related to cache indices are now EMACS_INT.
1964
1965 * dispextern.h (struct bidi_string_data): New structure.
1966 (struct bidi_it): New member `string'. Make flag members be 1-bit
1967 fields, and put them last in the struct.
1968 (compute_display_string_pos, compute_display_string_end):
1969 Update prototypes.
1970 (bidi_push_it, bidi_pop_it): Add prototypes.
1971 (struct iterator_stack_entry): New members bidi_p,
1972 paragraph_embedding, and from_disp_prop_p.
1973 (struct it): Member bidi_p is now a bit field 1 bit wide.
1974 (bidi_shelve_cache, bidi_unshelve_cache):
1975 Declare prototypes.
1976
1977 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1978 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1979 and vector-like objects.
1980
1981 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1982 cache around display iteration.
1983
1984 * window.c (Fwindow_end, window_scroll_pixel_based)
1985 (displayed_window_lines, Frecenter): Save and restore the bidi
1986 cache around display iteration.
1987
1988 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1989
1990 * editfns.c (Fdelete_region): Clarify the use of the named
1991 parameters (bug#6788).
1992
1993 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1994
1995 * indent.c (Fvertical_motion): Set and restore w->pointm when
1996 saving and restoring the window's buffer (Bug#9006).
1997
1998 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1999
2000 * editfns.c (Fstring_to_char): Clarify just what is returned
2001 (bug#6576). Text by Eli Zaretskii.
2002
2003 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2004
2005 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2006
2007 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2008
2009 * buffer.c (mmap_find): Fix a typo.
2010
2011 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2012
2013 Fix execution of x selection hooks.
2014 * xselect.c (Qx_lost_selection_functions)
2015 (Qx_sent_selection_functions): New vars.
2016 (syms_of_xselect): DEFSYM them.
2017 (x_handle_selection_request): Pass Qx_sent_selection_functions
2018 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2019 (x_handle_selection_clear,x_clear_frame_selections):
2020 Pass Qx_lost_selection_functions rather than
2021 Vx_lost_selection_functions to Frun_hook_with_args.
2022
2023 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2024
2025 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2026 The old code sometimes used this field without initializing it.
2027
2028 * alloc.c (gc_sweep): Don't read past end of array.
2029 In theory, the old code could also have corrupted Emacs internals,
2030 though it'd be very unlikely.
2031
2032 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2033
2034 * character.c (Fcharacterp): Don't advertise optional ignored
2035 argument. (Bug#4026)
2036
2037 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2038
2039 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2040 key" (bug#4257).
2041
2042 * window.c (Fset_window_start): Doc fix (bug#4199).
2043 (Fset_window_hscroll): Ditto.
2044
2045 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2046
2047 Fix minor new problems caught by GCC 4.6.1.
2048 * term.c (init_tty): Remove unused local.
2049 * xsettings.c (store_monospaced_changed): Define this function only
2050 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2051 not used otherwise.
2052
2053 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2054
2055 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2056
2057 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2058
2059 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2060 are the mini-buffer and the echo area (bug#3320).
2061
2062 * term.c (init_tty): Remove support for supdup, c10 and perq
2063 terminals, which are no longer supported (bug#1482).
2064
2065 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2066
2067 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2068
2069 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2070
2071 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2072 for non-popups (Bug#3642).
2073
2074 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2075
2076 * alloc.c (reset_malloc_hooks): Protoize.
2077 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2078 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2079 * cm.c (losecursor): Likewise.
2080 * data.c (fmod): Likewise.
2081 * dispnew.c (swap_glyphs_in_rows): Likewise.
2082 * emacs.c (memory_warning_signal): Likewise.
2083 * floatfns.c (float_error): Likewise.
2084 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2085 (otf_open, font_otf_capability, generate_otf_features)
2086 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2087 Likewise.
2088 * image.c (pbm_read_file): Likewise.
2089 * indent.c (string_display_width): Likewise.
2090 * intervals.c (check_for_interval, search_for_interval)
2091 (inc_interval_count, count_intervals, root_interval)
2092 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2093 * lread.c (defalias): Likewise.
2094 * ralloc.c (r_alloc_check): Likewise.
2095 * regex.c (set_image_of_range_1, set_image_of_range)
2096 (regex_grow_registers): Likewise.
2097 * sysdep.c (strerror): Likewise.
2098 * termcap.c (valid_filename_p, tprint, main): Likewise.
2099 * tparam.c (main): Likewise.
2100 * unexhp9k800.c (run_time_remap, save_data_space)
2101 (update_file_ptrs, read_header, write_header, calculate_checksum)
2102 (copy_file, copy_rest, display_header): Likewise.
2103 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2104 Likewise.
2105 * xdisp.c (check_it): Likewise.
2106 * xfaces.c (register_color, unregister_color, unregister_colors):
2107 Likewise.
2108 * xfns.c (print_fontset_result): Likewise.
2109 * xrdb.c (member, fatal, main): Likewise.
2110
2111 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2112
2113 Fix minor problems found by static checking (Bug#9031).
2114 * chartab.c (char_table_set_range, map_sub_char_table):
2115 Remove unused locals.
2116 (uniprop_table): Now static.
2117 * composite.c (_work_char): Remove unused static var.
2118
2119 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2120
2121 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2122
2123 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2124
2125 * gtkutil.c (qttip_cb): Remove code without function.
2126
2127 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2128
2129 * w32.c (pthread_sigmask): New stub.
2130
2131 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2132
2133 Use pthread_sigmask, not sigprocmask (Bug#9010).
2134 sigprocmask is portable only for single-threaded applications, and
2135 Emacs can be multi-threaded when it uses GTK.
2136 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2137 (LIBES): Use it.
2138 * callproc.c (Fcall_process):
2139 * process.c (create_process):
2140 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2141 Use pthread_sigmask, not sigprocmask.
2142
2143 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2144
2145 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2146 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2147 wrong (Bug#8591).
2148
2149 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2150
2151 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2152 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2153 (xg_hide_tooltip): Fix comment.
2154
2155 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2156 in registerServicesMenuSendTypes.
2157 (validRequestorForSendType): Don't check ns_return_types.
2158
2159 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2160 ns_return_type.
2161
2162 2011-07-08 Jason Rumney <jasonr@gnu.org>
2163
2164 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2165 frame struct members of non-existent frames (Bug#6284).
2166
2167 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2168
2169 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2170 variable firstTime not needed on OSX >= 10.6.
2171 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2172 >= 10.5. Use setKnobProportion, setDoubleValue.
2173
2174 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2175 (MAC_OS_X_VERSION_10_5): Define if not defined.
2176 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2177 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2178 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2179
2180 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2181 cString and lossyCString on OSX >= 10.4
2182
2183 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2184 sizeToFit on OSX >= 10.2.
2185
2186 * nsimage.m (allocInitFromFile): Don't use deprecated method
2187 bestRepresentationForDevice on OSX >= 10.6.
2188
2189 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2190 to avoid warning.
2191
2192 * emacs.c: Declare unexec_init_emacs_zone.
2193
2194 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2195
2196 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2197
2198 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2199 on svcsMenu (Bug#8842).
2200
2201 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2202 ns_return_types.
2203 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2204
2205 * nsterm.m (QUTF8_STRING): Declare.
2206 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2207 (validRequestorForSendType): Return type is (id).
2208 Change indexOfObjectIdenticalTo to indexOfObject.
2209 Check if we have local selection before returning self (Bug#8842).
2210 (writeSelectionToPasteboard): Put local selection into paste board
2211 if we have a local selection (Bug#8842).
2212 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2213
2214 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2215 (ns_get_local_selection): Declare.
2216
2217 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2218
2219 * keymap.c (describe_map_tree): Don't insert a double newline at
2220 the end of the buffer (bug#1169) and return whether we inserted
2221 something.
2222
2223 * callint.c (Fcall_interactively): Change "reading args" to
2224 "providing args" to try to clarify what it does (bug#1010).
2225
2226 2011-07-07 Kenichi Handa <handa@m17n.org>
2227
2228 * composite.c (composition_compute_stop_pos): Ignore a static
2229 composition starting before CHARPOS (Bug#8915).
2230
2231 * xdisp.c (handle_composition_prop): Likewise.
2232
2233 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2234
2235 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2236 (Bug#9015)
2237
2238 2011-07-07 Kenichi Handa <handa@m17n.org>
2239
2240 * character.h (unicode_category_t): New enum type.
2241
2242 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2243 (Qchar_code_property_table): New variable.
2244 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2245 (UNIPROP_COMPRESSED_FORM_P): New macros.
2246 (char_table_ascii): Uncompress the compressed values.
2247 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2248 Uncompress the compressed values.
2249 (sub_char_table_ref_and_range): Likewise.
2250 (char_table_ref_and_range): Uncompress the compressed values.
2251 (sub_char_table_set): New arg is_uniprop. Callers changed.
2252 Uncompress the compressed values.
2253 (sub_char_table_set_range): Args changed. Callers changed.
2254 (char_table_set_range): Adjuted for the above change.
2255 (map_sub_char_table): Delete args default_val and parent. Add arg
2256 top. Give decoded values to a Lisp function.
2257 (map_char_table): Adjust for the above change. Give decoded
2258 values to a Lisp function. Gcpro more variables.
2259 (uniprop_table_uncompress)
2260 (uniprop_decode_value_run_length): New functions.
2261 (uniprop_decoder, uniprop_decoder_count): New variables.
2262 (uniprop_get_decoder, uniprop_encode_value_character)
2263 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2264 New functions.
2265 (uniprop_encoder, uniprop_encoder_count): New variables.
2266 (uniprop_get_encoder, uniprop_table)
2267 (Funicode_property_table_internal, Fget_unicode_property_internal)
2268 (Fput_unicode_property_internal): New functions.
2269 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2270 Sunicode_property_table_internal, Sget_unicode_property_internal,
2271 and Sput_unicode_property_internal. Defvar_lisp
2272 char-code-property-alist.
2273
2274 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2275 Vunicode_category_table.
2276
2277 * font.c (font_range): Adjust for the change of
2278 Vunicode_category_table.
2279
2280 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2281
2282 * m/iris4d.h: Remove file, move contents ...
2283 * s/irix6-5.h: ... here.
2284
2285 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2286
2287 Remove unportable assumption about struct layout (Bug#8884).
2288 * alloc.c (mark_buffer):
2289 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2290 (clone_per_buffer_values): Don't assume that
2291 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2292 This isn't true in general, and it's particularly not true
2293 if Emacs is configured with --with-wide-int.
2294 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2295 New macros, used in the buffer.c change.
2296
2297 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2298
2299 * xsettings.c: Use both GConf and GSettings if both are available.
2300 (store_config_changed_event): Add comment.
2301 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2302 (store_tool_bar_style_changed): New functions.
2303 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2304 (struct xsettings): Move font inside HAVE_XFT.
2305 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2306 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2307 Move inside HAVE_XFT.
2308 (something_changed_gsettingsCB): Rename from something_changedCB.
2309 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2310 also.
2311 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2312 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2313 (something_changed_gconfCB): Rename from something_changedCB.
2314 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2315 (parse_settings): Move check for font inside HAVE_XFT.
2316 (read_settings, apply_xft_settings): Add comment.
2317 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2318 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2319 call store_font_name_changed.
2320 (xft_settings_event): Add comment.
2321 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2322 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2323 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2324 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2325 (xsettings_initialize): Call init_gsettings last.
2326 (xsettings_get_system_font, xsettings_get_system_normal_font):
2327 Add comment.
2328
2329 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2330
2331 Random fixes. E.g., (random) never returned negative values.
2332 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2333 subseconds part to the entropy, as that's a bit more random.
2334 Prefer signed to unsigned, since the signedness doesn't matter and
2335 in general we prefer signed. When given a limit, use a
2336 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2337 latter isn't right if USE_2_TAGS_FOR_INTS.
2338 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2339 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2340
2341 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2342
2343 * textprop.c (text_property_stickiness):
2344 Obey Vtext_property_default_nonsticky.
2345 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2346 * w32fns.c (syms_of_w32fns):
2347 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2348
2349 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2350
2351 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2352 This is more efficient than Ffile_directory_p and avoids a minor race.
2353
2354 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2355
2356 * buffer.c (Foverlay_put): Say what the return value is
2357 (bug#7835).
2358
2359 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2360 is a directory before asking whether to use the file name
2361 (bug#7564).
2362 (barf_or_query_if_file_exists): Make the "File is a directory"
2363 error be more correct.
2364
2365 * fns.c (Frequire): Remove the mention of the .gz files, since
2366 that's installation-specific, but keep the mention of
2367 `get-load-suffixes'.
2368
2369 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2370
2371 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2372 Report string overflow if the output is too long.
2373
2374 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2375
2376 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2377 (syms_of_gnutls): Remove duplicate DEFSYM for
2378 Qgnutls_bootprop_verify_hostname_error, an error for
2379 Qgnutls_bootprop_verify_error (which is no longer used).
2380
2381 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2382 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2383 Also (re)move comments that are misplaced or no longer relevant.
2384
2385 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2386
2387 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2388
2389 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2390
2391 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2392 and background color parameters if they have been changed.
2393
2394 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2395
2396 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2397
2398 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2399
2400 * xsettings.c (SYSTEM_FONT): Define only when used.
2401 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2402
2403 * keymap.c (access_keymap_1): Now static.
2404
2405 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2406
2407 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2408 leave any prefix arg for the up event (Bug#1586).
2409
2410 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2411
2412 * lread.c (syms_of_lread): Mention single symbols defined by
2413 `defvar' or `defconst' (bug#7154).
2414
2415 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2416 (Frequire): Mention get-load-suffixes.
2417
2418 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2419
2420 * window.h (window): Remove clone_number slot.
2421 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2422 Remove.
2423 (make_parent_window, make_window, saved_window)
2424 (Fset_window_configuration, save_window_save): Don't deal with
2425 clone numbers.
2426 * buffer.c (Qclone_number): Remove declaration.
2427 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2428
2429 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2430
2431 Add multiple inheritance to keymaps.
2432 * keymap.c (Fmake_composed_keymap): New function.
2433 (Fset_keymap_parent): Simplify.
2434 (fix_submap_inheritance): Remove.
2435 (access_keymap_1): New function extracted from access_keymap to handle
2436 embedded parents and handle lists of maps.
2437 (access_keymap): Use it.
2438 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2439 (Fcopy_keymap): Handle embedded parents.
2440 (Fcommand_remapping, define_as_prefix): Simplify.
2441 (Fkey_binding): Simplify.
2442 (syms_of_keymap): Move minibuffer-local-completion-map,
2443 minibuffer-local-filename-completion-map,
2444 minibuffer-local-must-match-map, and
2445 minibuffer-local-filename-must-match-map to Elisp.
2446 (syms_of_keymap): Defsubr make-composed-keymap.
2447 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2448 (parse_menu_item): Trivial simplification.
2449
2450 2011-07-01 Glenn Morris <rgm@gnu.org>
2451
2452 * Makefile.in (SETTINGS_LIBS): Fix typo.
2453
2454 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2455
2456 * coding.c (Fencode_coding_string): Record the last coding system
2457 used, as the function doc string says (bug#8738).
2458
2459 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2460
2461 * xsettings.c (store_monospaced_changed): Take new font as arg and
2462 check for change against current_mono_font.
2463 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2464 (emacs_settings_constructor, emacs_settings_get_property)
2465 (emacs_settings_set_property, emacs_settings_class_init)
2466 (emacs_settings_init, gsettings_obj): Remove.
2467 (something_changedCB): New function for HAVE_GSETTINGS.
2468 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2469 with value as argument.
2470 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2471 g_settings_new (Bug#8967). Do not create gsettings_obj.
2472 Remove calls to g_settings_bind. Connect something_changedCB to
2473 "changed".
2474
2475 * xgselect.c: Add defined (HAVE_GSETTINGS).
2476 (xgselect_initialize): Ditto.
2477
2478 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2479 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2480 xg_select.
2481
2482 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2483
2484 * eval.c (struct backtrace): Simplify and port the data structure.
2485 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2486 signed bit field, as this assumption is not portable and it makes
2487 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2488 "char debug_on_exit : 1" as this is not portable either; instead,
2489 use the portable "unsigned int debug_on_exit : 1". Remove unused
2490 member evalargs. Remove obsolete comments about cc bombing out.
2491
2492 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2493
2494 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2495 Let HAVE_GSETTINGS override HAVE_GCONF.
2496 (store_monospaced_changed): New function.
2497 (EMACS_SETTINGS): A new type derived from GObject to handle
2498 GSettings notifications.
2499 (emacs_settings_constructor, emacs_settings_get_property)
2500 (emacs_settings_set_property, emacs_settings_class_init):
2501 New functions.
2502 (gsettings_client, gsettings_obj): New variables.
2503 (GSETTINGS_SCHEMA): New define.
2504 (something_changedCB): Call store_monospaced_changed.
2505 (init_gsettings): New function.
2506 (xsettings_initialize): Call init_gsettings.
2507 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2508 to NULL.
2509
2510 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2511 GCONF_CFLAGS/LIBS.
2512
2513 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2514
2515 * window.c (resize_root_window, grow_mini_window)
2516 (shrink_mini_window): Rename Qresize_root_window to
2517 Qwindow_resize_root_window and Qresize_root_window_vertically to
2518 Qwindow_resize_root_window_vertically.
2519
2520 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2521
2522 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2523
2524 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2525
2526 * makefile.w32-in: Redesign dependencies so they reflect more
2527 clearly which files are directly included by each source file,
2528 and not through other includes.
2529
2530 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2531
2532 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2533 (sort_overlays, overlay_strings): When an overlay's clone number
2534 matches the window's clone number process the overlay even if
2535 the overlay's window property doesn't match the current window.
2536
2537 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2538 (Fwindow_hchild): Rename to Fwindow_left_child.
2539 (Fwindow_next): Rename to Fwindow_next_sibling.
2540 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2541 (resize_window_check): Rename to window_resize_check.
2542 (resize_window_apply): Rename to window_resize_apply.
2543 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2544 (Fdelete_other_windows_internal, resize_frame_windows)
2545 (Fsplit_window_internal, Fdelete_window_internal)
2546 (grow_mini_window, shrink_mini_window)
2547 (Fresize_mini_window_internal): Fix callers accordingly.
2548
2549 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2550
2551 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2552 (emacs_fixed_set_min_size): Remove.
2553 (emacs_fixed_new): Take frame as argument.
2554
2555 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2556 (_EmacsFixedPrivate): Remove minwidth/height.
2557 Add struct frame *f.
2558 (emacs_fixed_init): Initialize priv->f.
2559 (get_parent_class, emacs_fixed_set_min_size): Remove.
2560 (emacs_fixed_new): Set priv->f to argument.
2561 (emacs_fixed_get_preferred_width)
2562 (emacs_fixed_get_preferred_height): Use min_width/height from
2563 frames size_hint to set minimum and natural (Bug#8919).
2564 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2565 and use min_width/height from frames size_hint to set
2566 min_width/height (Bug#8919).
2567
2568 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2569 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2570 Fix indentation.
2571
2572 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2573
2574 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2575 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2576 called at ZV.
2577
2578 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2579
2580 * process.c (wait_reading_process_output): Bypass select if
2581 waiting for a cell while ignoring keyboard input, and input is
2582 pending. Suggested by Jan Djärv (Bug#8869).
2583
2584 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2585
2586 Use gnulib's dup2 module instead of rolling our own.
2587 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2588
2589 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2590
2591 * dispnew.c (scrolling_window): Before scrolling, turn off a
2592 mouse-highlight in the window being scrolled.
2593
2594 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2595
2596 Move DEFSYM to lisp.h and use everywhere.
2597
2598 * character.h (DEFSYM): Move declaration...
2599 * lisp.h (DEFSYM): ...here.
2600
2601 * gnutls.c:
2602 * minibuf.c:
2603 * w32menu.c:
2604 * w32proc.c:
2605 * w32select.c: Don't include character.h.
2606
2607 * alloc.c (syms_of_alloc):
2608 * buffer.c (syms_of_buffer):
2609 * bytecode.c (syms_of_bytecode):
2610 * callint.c (syms_of_callint):
2611 * casefiddle.c (syms_of_casefiddle):
2612 * casetab.c (init_casetab_once):
2613 * category.c (init_category_once, syms_of_category):
2614 * ccl.c (syms_of_ccl):
2615 * cmds.c (syms_of_cmds):
2616 * composite.c (syms_of_composite):
2617 * dbusbind.c (syms_of_dbusbind):
2618 * dired.c (syms_of_dired):
2619 * dispnew.c (syms_of_display):
2620 * doc.c (syms_of_doc):
2621 * editfns.c (syms_of_editfns):
2622 * emacs.c (syms_of_emacs):
2623 * eval.c (syms_of_eval):
2624 * fileio.c (syms_of_fileio):
2625 * fns.c (syms_of_fns):
2626 * frame.c (syms_of_frame):
2627 * fringe.c (syms_of_fringe):
2628 * insdel.c (syms_of_insdel):
2629 * keymap.c (syms_of_keymap):
2630 * lread.c (init_obarray, syms_of_lread):
2631 * macros.c (syms_of_macros):
2632 * msdos.c (syms_of_msdos):
2633 * print.c (syms_of_print):
2634 * process.c (syms_of_process):
2635 * search.c (syms_of_search):
2636 * sound.c (syms_of_sound):
2637 * syntax.c (init_syntax_once, syms_of_syntax):
2638 * terminal.c (syms_of_terminal):
2639 * textprop.c (syms_of_textprop):
2640 * undo.c (syms_of_undo):
2641 * w32.c (globals_of_w32):
2642 * window.c (syms_of_window):
2643 * xdisp.c (syms_of_xdisp):
2644 * xfaces.c (syms_of_xfaces):
2645 * xfns.c (syms_of_xfns):
2646 * xmenu.c (syms_of_xmenu):
2647 * xsettings.c (syms_of_xsettings):
2648 * xterm.c (syms_of_xterm): Use DEFSYM.
2649
2650 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2651
2652 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2653
2654 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2655
2656 Integer and buffer overflow fixes (Bug#8873).
2657
2658 * print.c (printchar, strout): Check for string overflow.
2659 (PRINTPREPARE, printchar, strout):
2660 Don't set size unless allocation succeeds.
2661
2662 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2663 for sizes. Check for string overflow more accurately.
2664 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2665
2666 * macros.c: Integer and buffer overflow fixes.
2667 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2668 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2669 Use ptrdiff_t, not int, for sizes.
2670 Don't increment bufsize until after realloc succeeds.
2671 Check for size-calculation overflow.
2672 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2673
2674 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2675
2676 * lread.c: Integer overflow fixes.
2677 (read_integer): Radix is now EMACS_INT, not int,
2678 to improve quality of diagnostics for out-of-range radices.
2679 Calculate buffer size correctly for out-of-range radices.
2680 (read1): Check for integer overflow in radices, and in
2681 read-circle numbers.
2682 (read_escape): Avoid int overflow.
2683 (Fload, openp, read_buffer_size, read1)
2684 (substitute_object_recurse, read_vector, read_list, map_obarray):
2685 Use ptrdiff_t, not int, for sizes.
2686 (read1): Use EMACS_INT, not int, for sizes.
2687 Check for size overflow.
2688
2689 * image.c (cache_image): Check for size arithmetic overflow.
2690
2691 * lread.c: Integer overflow issues.
2692 (saved_doc_string_size, saved_doc_string_length)
2693 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2694 Now ptrdiff_t, not int.
2695 (read1): Don't assume doc string length fits in int. Check for
2696 out-of-range doc string lengths.
2697 (read_list): Don't assume file position fits in int.
2698 (read_escape): Check for hex character overflow.
2699
2700 2011-06-22 Leo Liu <sdl.web@gmail.com>
2701
2702 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2703 Move to minibuffer.el.
2704
2705 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2706
2707 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2708 The following patches are for when GLYPH_DEBUG && !XASSERT.
2709 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2710 * dispnew.c (flush_stdout):
2711 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2712 Mark as externally visible.
2713 * dispnew.c (check_window_matrix_pointers): Now static.
2714 * dispnew.c (window_to_frame_vpos):
2715 * xfns.c (unwind_create_frame):
2716 * xterm.c (x_check_font): Remove unused local.
2717 * scroll.c (CHECK_BOUNDS):
2718 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2719 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2720 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2721 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2722 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2723 Now static.
2724 (debug_method_add): Use va_list and vsprintf rather than relying
2725 on undefined behavior with wrong number of arguments.
2726 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2727 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2728 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2729 since we're not interested in debugging glyphs with old libraries.
2730 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2731 GCC 4.6.0's static checking.
2732
2733 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2734
2735 Integer overflow and signedness fixes (Bug#8873).
2736 A few related buffer overrun fixes, too.
2737
2738 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2739
2740 * dispextern.h (struct face.stipple):
2741 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2742 (x_bitmap_mask, x_allocate_bitmap_record)
2743 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2744 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2745 (x_create_bitmap_from_xpm_data):
2746 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2747 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2748 (.bitmaps_last):
2749 * xfaces.c (load_pixmap):
2750 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2751 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2752 (.bitmaps_last, struct x_output.icon_bitmap):
2753 Use ptrdiff_t, not int, for bitmap indexes.
2754 (x_allocate_bitmap_record): Check for size overflow.
2755 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2756
2757 Use ptrdiff_t, not int, for overlay counts.
2758 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2759 * editfns.c (overlays_around, get_pos_property):
2760 * textprop.c (get_char_property_and_overlay):
2761 * xdisp.c (next_overlay_change, note_mouse_highlight):
2762 * xfaces.c (face_at_buffer_position):
2763 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2764 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2765 (Fnext_overlay_change, Fprevious_overlay_change)
2766 (mouse_face_overlay_overlaps, Foverlays_in):
2767 Use ptrdiff_t, not int, for sizes.
2768 (overlays_at, overlays_in): Check for size-calculation overflow.
2769
2770 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2771
2772 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2773 (x_session_initialize): Do not assume string length fits in int.
2774
2775 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2776 This is unlikely, but can occur if DPI is outlandish.
2777
2778 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2779 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2780
2781 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2782 * xrdb.c (magic_file_p, search_magic_path):
2783 Omit last arg SUFFIX; it was always 0. All callers changed.
2784 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2785
2786 * xfont.c (xfont_match): Avoid need for strlen.
2787
2788 * xfns.c: Don't assume strlen fits in int.
2789 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2790
2791 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2792 not unsigned long, as we prefer signed integers. All callers changed.
2793 Detect integer overflow in repeat count.
2794 (message_dolog): Don't assume print length fits in 39 bytes.
2795 (display_mode_element): Don't assume strlen fits in int.
2796
2797 * termcap.c: Don't assume sizes fit in int and never overflow.
2798 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2799 (gobble_line): Check for size-calculation overflow.
2800
2801 * minibuf.c (Fread_buffer):
2802 * lread.c (intern, intern_c_string):
2803 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2804 Don't assume string length fits in int.
2805
2806 * keyboard.c (parse_tool_bar_item):
2807 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2808
2809 * font.c: Don't assume string length fits in int.
2810 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2811 Use ptrdiff_t, not int.
2812 (font_intern_prop): Don't assume string length fits in int.
2813 Don't assume integer property fits in fixnum.
2814 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2815
2816 * filelock.c: Fix some buffer overrun and integer overflow issues.
2817 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2818 Reformulate so as not to need the command string.
2819 Invoke gzip -cd rather than gunzip, as it's more portable.
2820 (lock_info_type, lock_file_1, lock_file):
2821 Don't assume pid_t and time_t fit in unsigned long.
2822 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2823 (current_lock_owner): Prefer signed type for sizes.
2824 Use memcpy, not strncpy, where memcpy is what is really wanted.
2825 Don't assume (via atoi) that time_t and pid_t fit in int.
2826 Check for time_t and/or pid_t out of range, e.g., via a network share.
2827 Don't alloca where an auto var works fine.
2828
2829 * fileio.c: Fix some integer overflow issues.
2830 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2831 Don't assume string length fits in int.
2832 (directory_file_name): Don't assume string length fits in long.
2833 (make_temp_name): Don't assume pid fits in int, or that its print
2834 length is less than 20.
2835
2836 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2837
2838 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2839
2840 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2841
2842 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2843 We prefer signed integers, even for size calculations.
2844
2845 * emacs.c: Don't assume string length fits in 'int'.
2846 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2847 (main): Don't invoke strlen when not needed.
2848
2849 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2850 (XD_DEBUG_MESSAGE): Don't waste a byte.
2851
2852 * callproc.c (getenv_internal_1, getenv_internal)
2853 (Fgetenv_internal):
2854 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2855
2856 * lread.c (invalid_syntax): Omit length argument.
2857 All uses changed. This doesn't fix a bug, but it simplifies the
2858 code away from its former Hollerith-constant appearance, and it's
2859 one less 'int' to worry about when looking at integer-overflow issues.
2860 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2861
2862 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2863 This didn't break anything, but it didn't help either.
2864 It's confusing to put a bogus integer in a place where the actual
2865 value does not matter.
2866 (LIST_END_P): Remove unused macro and its bogus comment.
2867 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2868
2869 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2870 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2871 implementation.
2872 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2873 We prefer signed types, and the value cannot exceed the EMACS_INT
2874 range anyway (because otherwise the length would not be representable).
2875 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2876 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2877 This avoids a GCC warning when WIDE_EMACS_INT.
2878
2879 * indent.c (sane_tab_width): New function.
2880 (current_column, scan_for_column, Findent_to, position_indentation)
2881 (compute_motion): Use it. This is just for clarity.
2882 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2883
2884 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2885
2886 * lisp.h (lint_assume): New macro.
2887 * composite.c (composition_gstring_put_cache):
2888 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2889
2890 * editfns.c, insdel.c:
2891 Omit unnecessary forward decls, to simplify future changes.
2892
2893 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2894
2895 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2896
2897 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2898 Use much-faster test for byte-length change.
2899 Don't assume string byte-length fits in 'int'.
2900 Check that character arg fits in 'int'.
2901 (mapcar1): Declare byte as byte, for clarity.
2902
2903 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2904
2905 * fns.c (concat): Catch string overflow earlier.
2906 Do not rely on integer wraparound.
2907
2908 * dispextern.h (struct it.overlay_strings_charpos)
2909 (struct it.selective): Now EMACS_INT, not int.
2910 * xdisp.c (forward_to_next_line_start)
2911 (back_to_previous_visible_line_start)
2912 (reseat_at_next_visible_line_start, next_element_from_buffer):
2913 Don't arbitrarily truncate the value of 'selective' to int.
2914
2915 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2916
2917 * composite.c: Don't truncate sizes to 'int'.
2918 (composition_gstring_p, composition_reseat_it)
2919 (composition_adjust_point): Use EMACS_INT, not int.
2920 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2921 not EMACS_UINT, for indexes.
2922
2923 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2924
2925 * buffer.c: Include <verify.h>.
2926 (struct sortvec.priority, struct sortstr.priority):
2927 Now EMACS_INT, not int.
2928 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2929 (struct sortstr.size, record_overlay_string)
2930 (struct sortstrlist.size, struct sortlist.used):
2931 Don't truncate size to int.
2932 (record_overlay_string): Check for size-calculation overflow.
2933 (init_buffer_once): Check at compile-time, not run-time.
2934
2935 2011-06-22 Jim Meyering <meyering@redhat.com>
2936
2937 Don't leak an XBM-image-sized buffer
2938 * image.c (xbm_load): Free the image buffer after using it.
2939
2940 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2941
2942 Port to Sun C.
2943 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2944 that Sun C diagnosed.
2945 * fns.c (secure_hash): Fix pointer signedness issue.
2946 * intervals.c (static_offset_intervals): New function.
2947 (offset_intervals): Use it.
2948
2949 2011-06-21 Leo Liu <sdl.web@gmail.com>
2950
2951 * deps.mk (fns.o):
2952 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2953 sha512.h.
2954
2955 * fns.c (secure_hash): Rename from crypto_hash_function and change
2956 the first arg to accept symbols.
2957 (Fsecure_hash): New primitive.
2958 (syms_of_fns): New symbols.
2959
2960 2011-06-20 Deniz Dogan <deniz@dogan.se>
2961
2962 * process.c (Fset_process_buffer): Clarify return value in
2963 docstring.
2964
2965 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2966
2967 * dispnew.c (add_window_display_history): Use BVAR.
2968
2969 * xdisp.c (debug_method_add): Use BVAR.
2970 (check_window_end, dump_glyph_matrix, dump_glyph)
2971 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2972
2973 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2974 Likewise.
2975
2976 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2977 check till after the cache is created in init_frame_faces.
2978
2979 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2980
2981 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2982
2983 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2984
2985 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2986 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2987 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2988
2989 Improve buffer-overflow checking (Bug#8873).
2990 * fileio.c (Finsert_file_contents):
2991 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2992 Remove the old (too-loose) buffer overflow checks.
2993 They weren't needed, since make_gap checks for buffer overflow.
2994 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2995 The old code merely checked for Emacs fixnum overflow, and relied
2996 on undefined (wraparound) behavior. The new code avoids undefined
2997 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2998
2999 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3000 Tune. Don't use wider integers than needed. Don't use alloca.
3001 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3002
3003 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3004
3005 * insdel.c, lisp.h (buffer_overflow): New function.
3006 (insert_from_buffer_1, replace_range, replace_range_2):
3007 * insdel.c (make_gap_larger):
3008 * editfns.c (Finsert_char):
3009 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3010
3011 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3012
3013 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3014
3015 Integer overflow and signedness fixes (Bug#8873).
3016
3017 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3018 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3019
3020 * fileio.c: Don't assume EMACS_INT fits in off_t.
3021 (emacs_lseek): New static function.
3022 (Finsert_file_contents, Fwrite_region): Use it.
3023 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3024
3025 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3026
3027 * fns.c: Don't overflow int when computing a list length.
3028 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3029 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3030 truncation on 64-bit hosts. Check for QUIT every
3031 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3032 faster and is responsive enough.
3033 (Flength): Report an error instead of overflowing an integer.
3034 (Fsafe_length): Return a float if the value is not representable
3035 as a fixnum. This shouldn't happen except in contrived situations.
3036 (Fnthcdr, Fsort): Don't assume list length fits in int.
3037 (Fcopy_sequence): Don't assume vector length fits in int.
3038
3039 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3040 (header_size, word_size): New constants.
3041 (allocate_vectorlike): Don't check size overflow here.
3042 (allocate_vector): Check it here instead, since this is the only
3043 caller of allocate_vectorlike that could cause overflow.
3044 Check that the new vector's length is representable as a fixnum.
3045
3046 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3047 The previous code was bogus. For example, next_almost_prime (32)
3048 returned 39, which is undesirable as it is a multiple of 3; and
3049 next_almost_prime (24) returned 25, which is a multiple of 5 so
3050 why was the code bothering to check for multiples of 7?
3051
3052 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3053
3054 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3055
3056 Variadic C functions now count arguments with ptrdiff_t.
3057 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3058 Back then I didn't know that the Emacs coding style prefers signed int.
3059 Also, in the meantime I found a few more instances where arguments
3060 were being counted with int, which may truncate counts on 64-bit
3061 machines, or EMACS_INT, which may be unnecessarily wide.
3062 * lisp.h (struct Lisp_Subr.function.aMANY)
3063 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3064 Arg counts are now ptrdiff_t, not size_t.
3065 All variadic functions and their callers changed accordingly.
3066 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3067 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3068 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3069 * callint.c (Fcall_interactively): Check arg count for overflow,
3070 to avoid potential buffer overrun. Use signed char, not 'int',
3071 for 'varies' array, so that we needn't bother to check its size
3072 calculation for overflow.
3073 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3074 * eval.c (apply_lambda):
3075 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3076 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3077 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3078
3079 * callint.c (Fcall_interactively): Don't use index var as event count.
3080
3081 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3082 * mem-limits.h (SIZE): Remove; no longer used.
3083
3084 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3085
3086 Remove unnecessary casts.
3087 * xterm.c (x_term_init):
3088 * xfns.c (x_set_border_pixel):
3089 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3090 These aren't needed now that we assume ANSI C.
3091
3092 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3093 It's more likely to cause problems (due to unsigned overflow)
3094 than to cure them.
3095
3096 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3097
3098 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3099
3100 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3101
3102 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3103
3104 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3105
3106 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3107
3108 GLYPH_CODE_FACE returns EMACS_INT, not int.
3109 * dispextern.h (merge_faces):
3110 * xfaces.c (merge_faces):
3111 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3112 Don't assume EMACS_INT fits in int.
3113
3114 * character.h (CHAR_VALID_P): Remove unused parameter.
3115 * fontset.c, lisp.h, xdisp.c: All uses changed.
3116
3117 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3118
3119 * fns.c (concat): Minor tuning based on overflow analysis.
3120 This doesn't fix any bugs. Use int to hold character, instead
3121 of constantly refetching from Emacs object. Use XFASTINT, not
3122 XINT, for value known to be a character. Don't bother comparing
3123 a single byte to 0400, as it's always less.
3124
3125 * floatfns.c (Fexpt):
3126 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3127
3128 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3129 for characters.
3130
3131 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3132
3133 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3134 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3135 incorrectly succeed when S was a string, because 4294967386 was
3136 truncated before it was used.
3137
3138 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3139 Otherwise, an out-of-range integer could cause undefined behavior
3140 on a 64-bit host.
3141
3142 * composite.c: Use int, not EMACS_INT, for characters.
3143 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3144 EMACS_INT, for values that are known to be in character range.
3145 This doesn't fix any bugs but is the usual style inside Emacs and
3146 may generate better code on 32-bit machines.
3147
3148 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3149 This is for reasons similar to the recent CHAR_STRING fix.
3150 * charset.c (Fencode_char): Check that character arg is actually
3151 a character. Pass an int to ENCODE_CHAR.
3152 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3153 wider than 'int', as a compile-time check to prevent future regressions
3154 in this area.
3155
3156 * character.c (char_string): Remove unnecessary casts.
3157
3158 Make sure a 64-bit char is never passed to CHAR_STRING.
3159 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3160 by silently ignoring the top 32 bits, allowing some values
3161 that were far too large to be valid characters.
3162 * character.h: Include <verify.h>.
3163 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3164 arguments are no wider than unsigned, as a compile-time check
3165 to prevent future regressions in this area.
3166 * data.c (Faset):
3167 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3168 (Fsubst_char_in_region):
3169 * fns.c (concat):
3170 * xdisp.c (decode_mode_spec_coding):
3171 Adjust to CHAR_STRING's new requirement.
3172 * editfns.c (Finsert_char, Fsubst_char_in_region):
3173 * fns.c (concat): Check that character args are actually
3174 characters. Without this test, these functions did the wrong
3175 thing with wildly out-of-range values on 64-bit hosts.
3176
3177 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3178 These casts should not be needed on 32-bit hosts, either.
3179 * keyboard.c (read_char):
3180 * lread.c (Fload): Remove casts to unsigned.
3181
3182 * lisp.h (UNSIGNED_CMP): New macro.
3183 This fixes comparison bugs on 64-bit hosts.
3184 (ASCII_CHAR_P): Use it.
3185 * casefiddle.c (casify_object):
3186 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3187 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3188 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3189 * dispextern.h (FACE_FROM_ID):
3190 * keyboard.c (read_char): Use UNSIGNED_CMP.
3191
3192 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3193 not to EMACS_INT, to avoid GCC warning.
3194
3195 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3196
3197 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3198 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3199 isn't needed on 32-bit machines.
3200
3201 * buffer.c (Fgenerate_new_buffer_name):
3202 Use EMACS_INT for count, not int.
3203 (advance_to_char_boundary): Return EMACS_INT, not int.
3204
3205 * data.c (Qcompiled_function): Now static.
3206
3207 * window.c (window_body_lines): Now static.
3208
3209 * image.c (gif_load): Rename local to avoid shadowing.
3210
3211 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3212 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3213 * alloc.c (make_save_value): Integer argument is now of type
3214 ptrdiff_t, not int.
3215 (mark_object): Use ptrdiff_t, not int.
3216 * lisp.h (pD): New macro.
3217 * print.c (print_object): Use it.
3218
3219 * alloc.c: Use EMACS_INT, not int, to count objects.
3220 (total_conses, total_markers, total_symbols, total_vector_size)
3221 (total_free_conses, total_free_markers, total_free_symbols)
3222 (total_free_floats, total_floats, total_free_intervals)
3223 (total_intervals, total_strings, total_free_strings):
3224 Now EMACS_INT, not int. All uses changed.
3225 (Fgarbage_collect): Compute overall total using a double, so that
3226 integer overflow is less likely to be a problem. Check for overflow
3227 when converting back to an integer.
3228 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3229 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3230 These were 'int' variables that could overflow on 64-bit hosts;
3231 they were never used, so remove them instead of repairing them.
3232 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3233 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3234 Previously, this ceilinged at INT_MAX, but that doesn't work on
3235 64-bit machines.
3236 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3237
3238 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3239 (allocate_vectorlike): Check for ptrdiff_t overflow.
3240 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3241 when a (possibly-narrower) signed value would do just as well.
3242 We prefer using signed arithmetic, to avoid comparison confusion.
3243
3244 * alloc.c: Catch some string size overflows that we were missing.
3245 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3246 for convenience in STRING_BYTES_MAX.
3247 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3248 The definition here is exact; the one in lisp.h was approximate.
3249 (allocate_string_data): Check for string overflow. This catches
3250 some instances we weren't catching before. Also, it catches
3251 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3252 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3253 and ptrdiff_t and EMACS_INT are both 64 bits.
3254
3255 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3256 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3257 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3258
3259 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3260
3261 * alloc.c (Fmake_string): Check for out-of-range init.
3262
3263 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3264
3265 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3266
3267 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3268
3269 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3270 xg_get_default_scrollbar_width.
3271
3272 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3273 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3274 (style_changed_cb): Call update_theme_scrollbar_width and call
3275 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3276 all frames (Bug#8505).
3277 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3278 Call gtk_window_set_resizable if HAVE_GTK3.
3279 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3280 and height if HAVE_GTK3 (Bug#8505).
3281 (scroll_bar_width_for_theme): New variable.
3282 (update_theme_scrollbar_width): New function.
3283 (xg_get_default_scrollbar_width): Move code to
3284 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3285 (xg_initialize): Call update_theme_scrollbar_width.
3286
3287 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3288
3289 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3290
3291 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3292
3293 * frame.c (make_frame): Call other_buffer_safely instead of
3294 other_buffer.
3295
3296 * window.c (temp_output_buffer_show): Call display_buffer with
3297 second argument Vtemp_buffer_show_specifiers and reset latter
3298 immediately after the call.
3299 (Vtemp_buffer_show_specifiers): New variable.
3300 (auto_window_vscroll_p, next_screen_context_lines)
3301 (Vscroll_preserve_screen_position): Remove leading asterisks from
3302 doc-strings.
3303
3304 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3305
3306 Fix minor problems found by GCC 4.6.0 static checking.
3307 * buffer.c (Qclone_number): Remove for now, as it's unused.
3308 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3309 (record_buffer): Remove unused local.
3310 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3311 (set_frame_buffer_list): Remove; unused.
3312 * frame.h (other_visible_frames): Remove decl.
3313 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3314 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3315 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3316 if HAVE_GPM.
3317 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3318 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3319 Define only if HAVE_GPM.
3320 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3321 (update_hints_inhibit): Remove; never set. All uses removed.
3322 * widgetprv.h (emacsFrameClassRec): Remove decl.
3323 * window.c (delete_deletable_window): Now returns void, since it
3324 wasn't returning anything.
3325 (compare_window_configurations): Remove unused locals.
3326 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3327 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3328 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3329 the same widths as pointers. This follows up on the 2011-05-06 patch.
3330 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3331 * xterm.h: Likewise.
3332 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3333
3334 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3335
3336 * makefile.w32-in: Update dependencies.
3337 (LISP_H): Add lib/intprops.h.
3338
3339 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3340
3341 * image.c (gif_load): Add animation frame delay to the metadata.
3342 (syms_of_image): Use DEFSYM. New symbol `delay'.
3343
3344 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3345
3346 * window.c (delete_deletable_window): Re-add.
3347 (Fset_window_configuration): Rewrite to handle dead buffers and
3348 consequently deletable windows.
3349 (window_tree, Fwindow_tree): Remove. Supply functionality in
3350 window.el.
3351 (compare_window_configurations): Simplify code.
3352
3353 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3354
3355 * image.c (imagemagick_load_image): Fix type mismatch.
3356 (Fimagemagick_types): Likewise.
3357
3358 * window.h (replace_buffer_in_windows): Declare.
3359
3360 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3361
3362 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3363 Qclone_number. Remove external declaration of Qdelete_window.
3364 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3365 code.
3366 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3367 Run Qbuffer_list_update_hook if allowed.
3368 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3369 buffer list implementation.
3370 (other_buffer_safely): New function.
3371 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3372 calls to replace_buffer_in_windows and
3373 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3374 if allowed.
3375 (record_buffer): Inhibit quitting and rewrite using quittable
3376 functions. Run Qbuffer_list_update_hook if allowed.
3377 (Frecord_buffer, Funrecord_buffer): New functions.
3378 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3379 Move switch-to-buffer to window.el.
3380 (bury-buffer): Move to window.el.
3381 (Vbuffer_list_update_hook): New variable.
3382
3383 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3384 section.
3385
3386 * window.h (resize_frame_windows): Move up in code.
3387 (Fwindow_frame): Remove EXFUN.
3388 (replace_buffer_in_all_windows): Remove prototype.
3389 (replace_buffer_in_windows_safely): Add prototype.
3390
3391 * window.c: Declare Qdelete_window static again. Move down
3392 declaration of select_count.
3393 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3394 (Fother_window): Move to window.el.
3395 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3396 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3397 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3398 window.el.
3399 (replace_buffer_in_windows): Implement by calling
3400 Qreplace_buffer_in_windows.
3401 (replace_buffer_in_all_windows): Remove with some functionality
3402 moved into replace_buffer_in_windows_safely.
3403 (replace_buffer_in_windows_safely): New function.
3404 (select_window_norecord, select_frame_norecord): Move in front
3405 of run_window_configuration_change_hook. Remove now obsolete
3406 declarations.
3407 (Fset_window_buffer): Rewrite doc-string.
3408 Call Qrecord_window_buffer.
3409 (keys_of_window): Move binding for other-window to window.el.
3410
3411 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3412
3413 * dispextern.h (struct image): Replace data member, whose int_val
3414 and ptr_val fields were not used by anything, with a single
3415 lisp_val object.
3416
3417 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3418 (gif_clear_image, gif_load, imagemagick_load_image)
3419 (gs_clear_image, gs_load): Callers changed.
3420
3421 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3422
3423 * buffer.h: Include <time.h>, for time_t.
3424 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3425
3426 Fix minor problems found by static checking.
3427
3428 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3429
3430 Make identifiers static if they are not used in other modules.
3431 * data.c (Qcompiled_function, Qframe, Qvector):
3432 * image.c (QimageMagick, Qsvg):
3433 * minibuf.c (Qmetadata):
3434 * window.c (resize_window_check, resize_root_window): Now static.
3435 * window.h (resize_window_check, resize_root_window): Remove decls.
3436
3437 * window.c (window_deletion_count, delete_deletable_window):
3438 Remove; unused.
3439 (window_body_lines): Now static.
3440 (Fdelete_other_windows_internal): Mark vars as initialized.
3441 Make sure 'resize_failed' is initialized.
3442 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3443 (resize_window_apply): Remove unused local.
3444 * window.h (delete_deletable_window): Remove decl.
3445
3446 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3447 (imagemagick_load_image): Fix pointer signedness problem by changing
3448 last arg from unsigned char * to char *. All uses changed.
3449 Also, fix a local for similar reasons.
3450 Remove unused locals. Remove locals to avoid shadowing.
3451 (fn_rsvg_handle_free): Remove; unused.
3452 (svg_load, svg_load_image): Fix pointer signedness problem.
3453 (imagemagick_load_image): Don't use garbage pointer image_wand.
3454
3455 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3456
3457 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3458
3459 * image.c (gif_load): Fix omitted cast error introduced by
3460 2011-06-06 change.
3461
3462 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3463
3464 * window.h (resize_proportionally, orig_total_lines)
3465 (orig_top_line): Remove from window structure.
3466 (set_window_height, set_window_width, change_window_heights)
3467 (Fdelete_window): Remove prototypes.
3468 (resize_frame_windows): Remove duplicate declaration.
3469
3470 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3471
3472 * window.h (resize_frame_windows, resize_window_check)
3473 (delete_deletable_window, resize_root_window)
3474 (resize_frame_windows): Declare prototypes.
3475
3476 * window.c (resize_window_apply): Make definition be "static" to
3477 match the prototype.
3478
3479 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3480
3481 * window.c: Remove declarations of Qwindow_size_fixed,
3482 window_min_size_1, window_min_size_2, window_min_size,
3483 size_window, window_fixed_size_p, enlarge_window, delete_window.
3484 Remove static from declaration of Qdelete_window, it's
3485 temporarily needed by Fbury_buffer.
3486 (replace_window): Don't assign orig_top_line and
3487 orig_total_lines.
3488 (Fdelete_window, delete_window): Remove. Window deletion is
3489 handled by window.el.
3490 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3491 Replace Fdelete_window calls with calls to Qdelete_window.
3492 (Fdelete_other_windows): Remove. Deleting other windows is
3493 handled by window.el.
3494 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3495 handled in window.el.
3496 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3497 Window minimum sizes are handled in window.el.
3498 (shrink_windows, size_window, set_window_height)
3499 (set_window_width, change_window_heights, window_height)
3500 (window_width, CURBEG, CURSIZE, enlarge_window)
3501 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3502 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3503 handled in window.el.
3504 (make_dummy_parent): Rename to make_parent_window and give it a
3505 second argument horflag.
3506 (make_window): Don't set resize_proportionally any more.
3507 (Fsplit_window): Remove. Windows are split in window.el.
3508 (save_restore_action, save_restore_orig_size)
3509 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3510 Resize mini windows in window.el.
3511 (grow_mini_window, shrink_mini_window): Implement by calling
3512 Qresize_root_window_vertically, resize_window_check and
3513 resize_window_apply.
3514 (saved_window, Fset_window_configuration, save_window_save):
3515 Do not handle orig_top_line, orig_total_lines, and
3516 resize_proportionally.
3517 (window_min_height, window_min_width): Move to window.el.
3518 (keys_of_window): Move bindings for delete-other-windows,
3519 split-window, delete-window and enlarge-window to window.el.
3520
3521 * buffer.c: Temporarily extern Qdelete_window.
3522 (Fbury_buffer): Temporarily call Qdelete_window instead of
3523 Fdelete_window (Fbury_buffer will move to window.el soon).
3524
3525 * frame.c (set_menu_bar_lines_1): Remove code handling
3526 orig_top_line and orig_total_lines.
3527
3528 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3529 set_window_height but set heights directly.
3530 (change_frame_size_1): Use resize_frame_windows.
3531
3532 * xdisp.c (init_xdisp): Don't use set_window_height but set
3533 heights directly.
3534
3535 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3536 Use resize_frame_windows instead of change_window_heights and run
3537 run_window_configuration_change_hook.
3538
3539 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3540 instead of change_window_heights and run
3541 run_window_configuration_change_hook.
3542
3543 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3544
3545 * window.c (replace_window): Rename second argument REPLACEMENT to
3546 NEW. New third argument SETFLAG. Rewrite.
3547 (delete_window, make_dummy_parent): Call replace_window with
3548 third argument 1.
3549 (window_list_1): Move down in code.
3550 (run_window_configuration_change_hook): Move set_buffer part
3551 before select_frame_norecord part in order to unwind correctly.
3552 Rename count1 to count.
3553 (recombine_windows, delete_deletable_window, resize_root_window)
3554 (Fdelete_other_windows_internal)
3555 (Frun_window_configuration_change_hook, make_parent_window)
3556 (resize_window_check, resize_window_apply, Fresize_window_apply)
3557 (resize_frame_windows, Fsplit_window_internal)
3558 (Fdelete_window_internal, Fresize_mini_window_internal):
3559 New functions.
3560 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3561
3562 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3563
3564 * window.h (window): Add some new members to window structure -
3565 normal_lines, normal_cols, new_total, new_normal, clone_number,
3566 splits, nest, prev_buffers, next_buffers.
3567 (WINDOW_TOTAL_SIZE): Move here from window.c.
3568 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3569
3570 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3571 Remove.
3572 (make_dummy_parent): Set new members of windows structure.
3573 (make_window): Move down in code. Handle new members of window
3574 structure.
3575 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3576 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3577 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3578 (Fset_window_prev_buffers, Fwindow_next_buffers)
3579 (Fset_window_next_buffers, Fset_window_clone_number):
3580 New functions.
3581 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3582 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3583 Doc-string fixes.
3584 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3585 Argument WINDOW can be now internal window too.
3586 (Fwindow_use_time): Move up in code.
3587 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3588 Rewrite doc-string.
3589 (Fset_window_configuration, saved_window)
3590 (Fcurrent_window_configuration, save_window_save): Handle new
3591 members of window structure.
3592 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3593 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3594 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3595 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3596 Qget_mru_window, Qresize_root_window,
3597 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3598 Qauto_buffer_name; staticpro them.
3599
3600 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3601
3602 * window.c (Fwindow_total_size, Fwindow_left_column)
3603 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3604 (Fwindow_list_1): New functions.
3605 (window_box_text_cols): Replace with window_body_cols.
3606 (Fwindow_width, Fscroll_left, Fscroll_right):
3607 Use window_body_cols instead of window_box_text_cols.
3608 (delete_window, Fset_window_configuration):
3609 Call delete_all_subwindows with window as argument.
3610 (delete_all_subwindows): Take a window as argument and not a
3611 structure. Rewrite.
3612 (window_loop): Remove handling of GET_LRU_WINDOW and
3613 GET_LARGEST_WINDOW.
3614 (Fget_lru_window, Fget_largest_window): Move to window.el.
3615
3616 * window.h: Extern window_body_cols instead of
3617 window_box_text_cols. delete_all_subwindows now takes a
3618 Lisp_Object as argument.
3619
3620 * indent.c (compute_motion, Fcompute_motion):
3621 Use window_body_cols instead of window_box_text_cols.
3622
3623 * frame.c (delete_frame): Call delete_all_subwindows with root
3624 window as argument.
3625
3626 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3627
3628 * fns.c (Fputhash): Document return value.
3629
3630 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3631
3632 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3633
3634 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3635
3636 Cons<->int and similar integer overflow fixes (Bug#8794).
3637
3638 Check for overflow when converting integer to cons and back.
3639 * charset.c (Fdefine_charset_internal, Fdecode_char):
3640 Use cons_to_unsigned to catch overflow.
3641 (Fencode_char): Use INTEGER_TO_CONS.
3642 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3643 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3644 * data.c (long_to_cons, cons_to_long): Remove.
3645 (cons_to_unsigned, cons_to_signed): New functions.
3646 These signal an error for invalid or out-of-range values.
3647 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3648 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3649 * font.c (Ffont_variation_glyphs):
3650 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3651 * lisp.h: Include <intprops.h>.
3652 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3653 (cons_to_signed, cons_to_unsigned): New decls.
3654 (long_to_cons, cons_to_long): Remove decls.
3655 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3656 (Fprimitive_undo): Use CONS_TO_INTEGER.
3657 * xfns.c (Fx_window_property): Likewise.
3658 * xselect.c: Include <limits.h>.
3659 (x_own_selection, selection_data_to_lisp_data):
3660 Use INTEGER_TO_CONS.
3661 (x_handle_selection_request, x_handle_selection_clear)
3662 (x_get_foreign_selection, Fx_disown_selection_internal)
3663 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3664 (lisp_data_to_selection_data): Use cons_to_unsigned.
3665 (x_fill_property_data): Use cons_to_signed.
3666 Report values out of range.
3667
3668 Check for buffer and string overflow more precisely.
3669 * buffer.h (BUF_BYTES_MAX): New macro.
3670 * lisp.h (STRING_BYTES_MAX): New macro.
3671 * alloc.c (Fmake_string):
3672 * character.c (string_escape_byte8):
3673 * coding.c (coding_alloc_by_realloc):
3674 * doprnt.c (doprnt):
3675 * editfns.c (Fformat):
3676 * eval.c (verror):
3677 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3678 since they may not be the same number.
3679 * editfns.c (Finsert_char):
3680 * fileio.c (Finsert_file_contents):
3681 Likewise for BUF_BYTES_MAX.
3682
3683 * image.c: Use ptrdiff_t, not int, for sizes.
3684 (slurp_file): Switch from int to ptrdiff_t.
3685 All uses changed.
3686 (slurp_file): Check that file size fits in both size_t (for
3687 malloc) and ptrdiff_t (for sanity and safety).
3688
3689 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3690 if b->modtime has its maximal value.
3691
3692 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3693
3694 Don't assume time_t can fit into int.
3695 * buffer.h (struct buffer.modtime): Now time_t, not int.
3696 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3697 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3698
3699 Minor fixes for signed vs unsigned integers.
3700 * character.h (MAYBE_UNIFY_CHAR):
3701 * charset.c (maybe_unify_char):
3702 * keyboard.c (read_char, reorder_modifiers):
3703 XINT -> XFASTINT, since the integer must be nonnegative.
3704 * ftfont.c (ftfont_spec_pattern):
3705 * keymap.c (access_keymap, silly_event_symbol_error):
3706 XUINT -> XFASTINT, since the integer must be nonnegative.
3707 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3708 since it makes no difference and we prefer signed.
3709 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3710 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3711 nonnegative.
3712
3713 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3714
3715 * window.h (Fwindow_frame): Declare.
3716
3717 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3718
3719 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3720 (SPARE_MEMORY): Always define.
3721 (LARGE_REQUEST): Remove.
3722 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3723
3724 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3725
3726 * lisp.h: Move EXFUNS for Fframe_root_window,
3727 Fframe_first_window and Fset_frame_selected_window to window.h.
3728
3729 * window.h: Move EXFUNS for Fframe_root_window,
3730 Fframe_first_window and Fset_frame_selected_window here from
3731 lisp.h.
3732
3733 * frame.c (Fwindow_frame, Fframe_first_window)
3734 (Fframe_root_window, Fframe_selected_window)
3735 (Fset_frame_selected_window): Move to window.c.
3736 (Factive_minibuffer_window): Move to minibuf.c.
3737 (Fother_visible_frames_p): New function.
3738
3739 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3740
3741 * window.c (decode_window, decode_any_window): Move up in code.
3742 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3743 (inhibit_frame_unsplittable): Remove unused variable.
3744 (Fwindow_buffer): Move up and rewrite doc-string.
3745 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3746 (Fwindow_prev): New functions.
3747 (Fwindow_frame): Move here from frame.c. Accept any window as
3748 argument.
3749 (Fframe_root_window, Fframe_first_window)
3750 (Fframe_selected_window): Move here from frame.c. Accept frame
3751 or arbitrary window as argument. Update doc-strings.
3752 (Fminibuffer_window): Move up in code.
3753 (Fwindow_minibuffer_p): Move up in code and simplify.
3754 (Fset_frame_selected_window): Move here from frame.c.
3755 Marginal rewrite.
3756 (Fselected_window, select_window, Fselect_window): Move up in
3757 code. Minor doc-string fixes.
3758
3759 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3760
3761 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3762 Do not assume that spare memory exists; that assumption is valid
3763 only if SYSTEM_MALLOC.
3764 (LARGE_REQUEST): New macro, so that the issue of large requests
3765 is separated from the issue of spare memory.
3766
3767 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3768
3769 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3770 format. (Bug#8806)
3771
3772 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3773
3774 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3775 before statements.
3776
3777 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3778
3779 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3780
3781 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3782
3783 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3784 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3785
3786 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3787
3788 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3789
3790 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3791
3792 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3793 (x_clipboard_manager_save): Add return value.
3794 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3795 New error handlers.
3796 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3797 Obey Vx_select_enable_clipboard_manager. Catch errors in
3798 x_clipboard_manager_save (Bug#8779).
3799 (Vx_select_enable_clipboard_manager): New variable.
3800 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3801
3802 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3803
3804 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3805
3806 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3807
3808 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3809 in the current matrix if keep_current_p is non-zero.
3810
3811 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3812
3813 * bidi.c (bidi_level_of_next_char): Fix last change.
3814
3815 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3816
3817 Support bidi reordering of text covered by display properties.
3818
3819 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3820 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3821 (bidi_cache_search, bidi_cache_iterator_state)
3822 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3823 (bidi_level_of_next_char, bidi_move_to_visually_next):
3824 Support character positions inside a run of characters covered by a
3825 display string.
3826 (bidi_paragraph_init, bidi_resolve_explicit_1)
3827 (bidi_level_of_next_char): Call bidi_fetch_char and
3828 bidi_fetch_char_advance instead of FETCH_CHAR and
3829 FETCH_CHAR_ADVANCE.
3830 (bidi_init_it): Initialize new members.
3831 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3832 definitions.
3833 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3834 instead of using explicit *_CHAR codes.
3835 (bidi_resolve_explicit, bidi_resolve_weak):
3836 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3837 bidirectional text is supported only in multibyte buffers.
3838 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3839 it to initialize the frame_window_p member of struct bidi_it.
3840 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3841 (bidi_resolve_explicit, bidi_resolve_weak)
3842 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3843 bidi_it->nchars is non-positive.
3844 (bidi_level_of_next_char): Don't try to lookup the cache for the
3845 next/previous character if nothing is cached there yet, or if we
3846 were just reseat()'ed to a new position.
3847
3848 * xdisp.c (set_cursor_from_row): Set start and stop points
3849 according to the row's direction when priming the loop that looks
3850 for the glyph on which to display cursor.
3851 (single_display_spec_intangible_p): Function deleted.
3852 (display_prop_intangible_p): Reimplement to call
3853 handle_display_spec instead of single_display_spec_intangible_p.
3854 Accept 3 additional arguments needed by handle_display_spec.
3855 This fixes incorrect cursor motion across display property with complex
3856 values: lists, `(when COND...)' forms, etc.
3857 (single_display_spec_string_p): Support property values that are
3858 lists with the argument STRING its top-level element.
3859 (display_prop_string_p): Fix the condition for processing a
3860 property that is a list to be consistent with handle_display_spec.
3861 (handle_display_spec): New function, refactored from the
3862 last portion of handle_display_prop.
3863 (compute_display_string_pos): Accept additional argument
3864 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3865 value of a `display' property is a "replacing spec".
3866 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3867 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3868 the display property, but just return a value indicating whether
3869 the display property will replace the characters it covers.
3870 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3871 frame_window_p members of struct bidi_it.
3872 (compute_display_string_pos, compute_display_string_end):
3873 New functions.
3874 (push_it): Accept second argument POSITION, where pop_it should
3875 jump to continue iteration.
3876 (reseat_1): Initialize bidi_it.disp_pos.
3877
3878 * keyboard.c (adjust_point_for_property): Adjust the call to
3879 display_prop_intangible_p to its new signature.
3880
3881 * dispextern.h (struct bidi_it): New member frame_window_p.
3882 (bidi_init_it): Update prototypes.
3883 (display_prop_intangible_p): Update prototype.
3884 (compute_display_string_pos, compute_display_string_end):
3885 Declare prototypes.
3886 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3887 EMACS_INT.
3888
3889 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3890
3891 Malloc failure behavior now depends on size of allocation.
3892 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3893 * lisp.h: Change signatures accordingly.
3894 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3895 All callers changed. (Bug#8762)
3896
3897 * gnutls.c: Use Emacs's memory allocators.
3898 Without this change, the gnutls library would invoke malloc etc.
3899 directly, which causes problems on non-SYNC_INPUT hosts, and which
3900 runs afoul of improving memory_full behavior. (Bug#8761)
3901 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3902 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3903 xfree instead of the default malloc, realloc, free.
3904 (Fgnutls_boot): No need to check for memory allocation failure,
3905 since xmalloc does that for us.
3906
3907 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3908 * category.c (hash_get_category_set):
3909 * ccl.c (ccl_driver):
3910 * charset.c (Fdefine_charset_internal):
3911 * charset.h (struct charset.hash_index):
3912 * composite.c (get_composition_id, gstring_lookup_cache)
3913 (composition_gstring_put_cache):
3914 * composite.h (struct composition.hash_index):
3915 * dispextern.h (struct image.hash):
3916 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3917 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3918 (hashfn_equal, hashfn_user_defined, make_hash_table)
3919 (maybe_resize_hash_table, hash_lookup, hash_put)
3920 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3921 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3922 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3923 * image.c (make_image, search_image_cache, lookup_image)
3924 (xpm_put_color_table_h):
3925 * lisp.h (struct Lisp_Hash_Table):
3926 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3927 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3928 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3929 * alloc.c (allocate_vectorlike):
3930 Check for overflow in vector size calculations.
3931 * ccl.c (ccl_driver):
3932 Check for overflow when converting EMACS_INT to int.
3933 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3934 need to be updated by these changes.
3935 * fns.c (make_hash_table, maybe_resize_hash_table):
3936 Check for integer overflow with large hash tables.
3937 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3938 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3939 (SXHASH_REDUCE): New macro.
3940 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3941 Use it instead of discarding useful hash info with large hash values.
3942 (sxhash_float): New function.
3943 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3944 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3945 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3946 Rewrite to use FIXNUM_BITS, as this simplifies things.
3947 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3948 Adjust signatures to match updated version of code.
3949 (consing_since_gc): Now EMACS_INT, since a single hash table can
3950 use more than INT_MAX bytes.
3951
3952 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3953
3954 Make it possible to build with GCC-4.6+ -O2 -flto.
3955
3956 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3957
3958 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3959
3960 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3961 Call minibuffer-inactive-mode.
3962
3963 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3964
3965 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3966 Update dependencies.
3967
3968 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3969
3970 * data.c (init_data): Remove code for UTS, this system is not
3971 supported anymore.
3972
3973 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3974
3975 Don't force ./temacs to start in terminal mode.
3976
3977 * frame.c (make_initial_frame): Initialize faces in all cases, not
3978 only when CANNOT_DUMP is defined.
3979 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3980
3981 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3982
3983 * dispnew.c (add_window_display_history): Use const for the string
3984 pointer. Remove declaration, not needed.
3985
3986 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3987
3988 Use 'inline', not 'INLINE'.
3989 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3990 * alloc.c, fontset.c (INLINE): Remove.
3991 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3992 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3993 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3994 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3995 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3996
3997 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3998
3999 Make it possible to run ./temacs.
4000
4001 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4002 syms_of_callproc does the same thing. Remove test for
4003 "initialized", do it in the caller.
4004 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4005
4006 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4007
4008 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4009 (read_minibuf): Use get_minibuffer.
4010 (syms_of_minibuf): Use DEFSYM.
4011 (Qmetadata): New var.
4012 * data.c (Qbuffer): Don't make it static.
4013 (syms_of_data): Use DEFSYM.
4014
4015 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4016
4017 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4018 (CCL_CODE_MIN): New macro.
4019
4020 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4021
4022 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4023
4024 * eval.c (Qdebug): Now static.
4025 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4026 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4027 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4028
4029 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4030
4031 * image.c: Various fixes to ImageMagick code comments.
4032 (Fimagemagick_types): Doc fix.
4033
4034 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4035
4036 Minor fixes prompted by GCC 4.6.0 warnings.
4037
4038 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4039
4040 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4041 (x_clipboard_manager_save_all): Move extern decl to ...
4042 * xterm.h: ... here, so that it can be checked for consistency.
4043
4044 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4045
4046 * xselect.c (x_clipboard_manager_save_frame)
4047 (x_clipboard_manager_save_all): New functions.
4048 (Fx_clipboard_manager_save): Lisp function deleted.
4049
4050 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4051 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4052
4053 * xterm.h: Update prototype.
4054
4055 2011-05-28 William Xu <william.xwl@gmail.com>
4056
4057 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4058 exiting (Bug#8239).
4059
4060 2011-05-28 Jim Meyering <meyering@redhat.com>
4061
4062 Avoid a sign-extension bug in crypto_hash_function.
4063 * fns.c (to_uchar): Define.
4064 (crypto_hash_function): Use it to convert some newly-signed
4065 variables to unsigned, to avoid sign-extension bugs. For example,
4066 without this change, (md5 "truc") would evaluate to
4067 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4068 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4069 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4070
4071 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4072
4073 Integer overflow fixes.
4074
4075 * dbusbind.c: Serial number integer overflow fixes.
4076 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4077 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4078 to hold a serial number that is too large for a fixnum.
4079 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4080 Check for serial numbers out of range. Decode any serial number
4081 that was so large that it became a float. (Bug#8722)
4082
4083 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4084 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4085 Use XFASTINT rather than XUINT when numbers are nonnegative.
4086 (xd_append_arg, Fdbus_method_return_internal):
4087 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4088 arguments, check that Lisp number is nonnegative, rather than
4089 silently wrapping negative numbers around. (Bug#8722)
4090 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4091 (Bug#8722)
4092
4093 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4094
4095 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4096
4097 ccl: add integer overflow checks
4098 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4099 (IN_INT_RANGE): New macros.
4100 (ccl_driver): Use them to check for integer overflow when
4101 decoding a CCL program. Many of the new checks are whether XINT (x)
4102 fits in int; it doesn't always, on 64-bit hosts. The new version
4103 doesn't catch all possible integer overflows, but it's an
4104 improvement. (Bug#8719)
4105
4106 * alloc.c (make_event_array): Use XINT, not XUINT.
4107 There's no need for unsigned here.
4108
4109 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4110 This follows up to the 2011-05-06 change that substituted uintptr_t
4111 for EMACS_INT. This case wasn't caught back then.
4112
4113 Rework Fformat to avoid integer overflow issues.
4114 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4115 now (part of C89). Include <verify.h>.
4116 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4117 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4118 (Fformat): Avoid the prepass trying to compute sizes; it was only
4119 approximate and thus did not catch overflow reliably. Instead, walk
4120 through the format just once, formatting and computing sizes as we go,
4121 checking for integer overflow at every step, and allocating a larger
4122 buffer as needed. Keep track separately whether the format is
4123 multibyte. Keep only the most-recently calculated precision, rather
4124 than them all. Record whether each argument has been converted to
4125 string. Use EMACS_INT, not int, for byte and char and arg counts.
4126 Support field widths and precisions larger than INT_MAX. Avoid
4127 sprintf's undefined behavior with conversion specifications such as %#d
4128 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4129 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4130 formatting out-of-range floating point numbers with int
4131 formats. (Bug#8668)
4132
4133 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4134
4135 * data.c: Avoid integer truncation in expressions involving floats.
4136 * data.c: Include <intprops.h>.
4137 (arith_driver): When there's an integer overflow in an expression
4138 involving floating point, convert the integers to floating point
4139 so that the resulting value does not suffer from catastrophic
4140 integer truncation. For example, on a 64-bit host (* 4
4141 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4142 Do not rely on undefined behavior after integer overflow.
4143
4144 merge count_size_as_multibyte, parse_str_to_multibyte
4145 * character.c, character.h (count_size_as_multibyte):
4146 Rename from parse_str_to_multibyte; all uses changed.
4147 Check for integer overflow.
4148 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4149 since it's now a duplicate of the other. This is more of
4150 a character than a buffer op, so better that it's in character.c.
4151 * fns.c, print.c: Adjust to above changes.
4152
4153 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4154
4155 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4156
4157 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4158
4159 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4160 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4161 (x_clipboard_manager_save): Now static.
4162 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4163
4164 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4165 (crypto_hash_function): Now static.
4166 Fix pointer signedness problems. Avoid unnecessary initializations.
4167
4168 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4169
4170 * termhooks.h (Vselection_alist): Make it terminal-local.
4171
4172 * terminal.c (create_terminal): Initialize it.
4173
4174 * xselect.c: Support for clipboard managers.
4175 (Vselection_alist): Move to termhooks.h as terminal-local var.
4176 (LOCAL_SELECTION): New macro.
4177 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4178 (symbol_to_x_atom): Remove gratuitous arg.
4179 (x_handle_selection_request, lisp_data_to_selection_data)
4180 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4181 (x_own_selection, x_get_local_selection, x_convert_selection):
4182 New arg, specifying work frame. Use terminal-local Vselection_alist.
4183 (some_frame_on_display): Delete unused function.
4184 (Fx_own_selection_internal, Fx_get_selection_internal)
4185 (Fx_disown_selection_internal, Fx_selection_owner_p)
4186 (Fx_selection_exists_p): New optional frame arg.
4187 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4188 (x_handle_selection_clear): Don't treat other terminals with the
4189 same keyboard specially. Use the terminal-local Vselection_alist.
4190 (x_clear_frame_selections): Use Frun_hook_with_args.
4191
4192 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4193
4194 * xterm.h: Add support for those atoms.
4195
4196 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4197
4198 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4199 (converted_selections, conversion_fail_tag): New global variables.
4200 (x_selection_request_lisp_error): Free the above.
4201 (x_get_local_selection): Remove unnecessary code.
4202 (x_reply_selection_request): Args changed; handle arbitrary array
4203 of converted selections stored in converted_selections.
4204 Separate the XChangeProperty and SelectionNotify steps.
4205 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4206 (x_convert_selection): New function.
4207 (x_handle_selection_event): Simplify.
4208 (x_get_foreign_selection): Don't ignore incoming requests while
4209 waiting for an answer; this will fail when we implement
4210 SAVE_TARGETS, and seems unnecessary anyway.
4211 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4212 (Vx_sent_selection_functions): Doc fix.
4213
4214 2011-05-26 Leo Liu <sdl.web@gmail.com>
4215
4216 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4217
4218 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4219
4220 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4221
4222 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4223 for fringe update if it has periodic bitmap.
4224 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4225 and fringe_bitmap_periodic_p.
4226
4227 * fringe.c (get_fringe_bitmap_data): New function.
4228 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4229 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4230 row. Mark glyph row for fringe update if periodicity changed.
4231
4232 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4233 for fringe update unless it has periodic bitmap.
4234
4235 2011-05-25 Kenichi Handa <handa@m17n.org>
4236
4237 * xdisp.c (get_next_display_element): Set correct it->face_id for
4238 a static composition.
4239
4240 2011-05-24 Leo Liu <sdl.web@gmail.com>
4241
4242 * deps.mk (fns.o):
4243 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4244
4245 * fns.c (crypto_hash_function, Fsha1): New function.
4246 (Fmd5): Use crypto_hash_function.
4247 (syms_of_fns): Add Ssha1.
4248
4249 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4250
4251 * gnutls.c: Remove unused macros.
4252 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4253 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4254 Remove macros that are defined and never used.
4255 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4256
4257 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4258
4259 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4260 (Fx_get_selection_internal): Minor cleanup.
4261 (Fx_own_selection_internal): Rename arguments for consistency with
4262 select.el.
4263
4264 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4265
4266 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4267
4268 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4269
4270 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4271
4272 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4273
4274 * dispnew.c (scrolling_window): Don't exclude the case that the
4275 last enabled row in the desired matrix touches the bottom boundary.
4276
4277 2011-05-21 Glenn Morris <rgm@gnu.org>
4278
4279 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4280 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4281 and add some more files.
4282
4283 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4284
4285 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4286 report_file_error introduced by the change from 2011-05-07.
4287
4288 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4289
4290 * systime.h (Time): Define only if emacs is defined.
4291 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4292 where the include path doesn't have X11/X.h by default. See
4293 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4294
4295 2011-05-20 Kenichi Handa <handa@m17n.org>
4296
4297 * composite.c (find_automatic_composition): Fix previous change.
4298
4299 2011-05-20 Glenn Morris <rgm@gnu.org>
4300
4301 * lisp.mk: New file, split from Makefile.in.
4302 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4303 (shortlisp): Remove.
4304 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4305
4306 2011-05-19 Glenn Morris <rgm@gnu.org>
4307
4308 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4309 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4310 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4311 (lisp): Set the order to that of loadup.el.
4312 (shortlisp): Make it a copy of $lisp.
4313 (SOME_MACHINE_LISP): Remove.
4314 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4315 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4316
4317 2011-05-18 Kenichi Handa <handa@m17n.org>
4318
4319 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4320 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4321 (find_automatic_composition): Mostly rewrite for efficiency.
4322
4323 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4324
4325 * makefile.w32-in: Update dependencies.
4326
4327 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4328
4329 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4330 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4331
4332 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4333
4334 Fix some integer overflow issues, such as string length overflow.
4335
4336 * insdel.c (count_size_as_multibyte): Check for string overflow.
4337
4338 * character.c (lisp_string_width): Check for string overflow.
4339 Use EMACS_INT, not int, for string indexes and lengths; in
4340 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4341 the resulting string length overflows an EMACS_INT; instead,
4342 report a string overflow if no precision given. When checking for
4343 precision exhaustion, use a check that cannot possibly have
4344 integer overflow. (Bug#8675)
4345 * character.h (lisp_string_width): Adjust to new signature.
4346
4347 * alloc.c (string_overflow): New function.
4348 (Fmake_string): Use it. This doesn't change behavior, but saves
4349 a few bytes and will simplify future changes.
4350 * character.c (string_escape_byte8): Likewise.
4351 * lisp.h (string_overflow): New decl.
4352
4353 Fixups, following up to the user-interface timestamp change.
4354 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4355 for UI timestamps, instead of unsigned long.
4356 * msdos.c (mouse_get_pos): Likewise.
4357 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4358 * w32gui.h (Time): Define by including "systime.h" rather than by
4359 declaring it ourselves. (Bug#8664)
4360
4361 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4362 * image.c (clear_image_cache): Likewise.
4363
4364 * term.c (term_mouse_position): Don't assume time_t wraparound.
4365
4366 Be more systematic about user-interface timestamps.
4367 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4368 and sometimes 'EMACS_UINT', to represent these timestamps.
4369 This change causes it to use 'Time' uniformly, as that's what X uses.
4370 This makes the code easier to follow, and makes it easier to catch
4371 integer overflow bugs such as Bug#8664.
4372 * frame.c (Fmouse_position, Fmouse_pixel_position):
4373 Use Time, not unsigned long, for user-interface timestamps.
4374 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4375 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4376 * keyboard.h (last_event_timestamp): Likewise.
4377 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4378 * menu.h (xmenu_show): Likewise.
4379 * term.c (term_mouse_position): Likewise.
4380 * termhooks.h (struct input_event.timestamp): Likewise.
4381 (struct terminal.mouse_position_hook): Likewise.
4382 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4383 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4384 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4385 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4386 what it was before.
4387 * menu.h, termhooks.h: Include "systime.h", for Time.
4388
4389 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4390 Don't assume that the difference between two unsigned long values
4391 can fit into an integer. At this point, we know button_down_time
4392 <= event->timestamp, so the difference must be nonnegative, so
4393 there's no need to cast the result if double-click-time is
4394 nonnegative, as it should be; check that it's nonnegative, just in
4395 case. This bug is triggered when events are more than 2**31 ms
4396 apart (about 25 days). (Bug#8664)
4397
4398 * xselect.c (last_event_timestamp): Remove duplicate decl.
4399 (x_own_selection): Remove needless cast to unsigned long.
4400
4401 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4402 that always fit in int. Use a sentinel instead of a counter, to
4403 avoid a temp and to allay GCC's concerns about possible int overflow.
4404 * frame.h (struct frame): Use int for menu_bar_items_used
4405 instead of EMACS_INT, since it always fits in int.
4406
4407 * menu.c (grow_menu_items): Check for int overflow.
4408
4409 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4410
4411 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4412 Before, the code was not consistent. These values cannot exceed
4413 2**31 - 1 so there's no need to make them unsigned.
4414 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4415 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4416 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4417 as modifiers.
4418 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4419
4420 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4421 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4422 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4423 presumably because the widths might not match.
4424
4425 * window.c (size_window): Avoid needless test at loop start.
4426
4427 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4428
4429 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4430
4431 2011-05-12 Drew Adams <drew.adams@oracle.com>
4432
4433 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4434
4435 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4436
4437 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4438 `width' to `bar_area_x' and `bar_area_width', respectively.
4439 (x_scroll_run): Take account of fringe background extension.
4440
4441 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4442 Rename local vars `left' and `width' to `bar_area_x' and
4443 `bar_area_width', respectively.
4444 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4445 background extension.
4446
4447 2011-05-10 Jim Meyering <meyering@redhat.com>
4448
4449 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4450
4451 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4452
4453 * image.c (Finit_image_library): Return t for built-in image types,
4454 like pbm and xbm. (Bug#8640)
4455
4456 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4457
4458 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4459
4460 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4461
4462 * w32console.c (Fset_screen_color): Doc fix.
4463 (Fget_screen_color): New function.
4464 (syms_of_ntterm): Defsubr it.
4465
4466 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4467 unlink the temporary file if Fcall_process didn't create it in the
4468 first place.
4469 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4470 child process will be redirected to a file specified with `:file'.
4471 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4472 cue to call_process_cleanup not to close that handle.
4473
4474 2011-05-07 Ben Key <bkey76@gmail.com>
4475
4476 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4477 one of two shell specific rules, either bootstrap-temacs-CMD or
4478 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4479 to the previous implementation of the bootstrap-temacs rule.
4480 The bootstrap-temacs-CMD rule is similar to the previous
4481 implementation of the bootstrap-temacs rule except that it
4482 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4483 variable.
4484
4485 These changes, along with some changes to nt/configure.bat,
4486 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4487 earlier fix to add support for --cflags and --ldflags options
4488 that include quotes so that it works whether make uses cmd or
4489 sh as the shell.
4490
4491 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4492
4493 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4494 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4495 is a constant.
4496 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4497 a string. Handle both cases.
4498 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4499 (Fdbus_register_method): Use Qinvalid_function.
4500
4501 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4502
4503 * makefile.w32-in: Update dependencies.
4504 (LISP_H): Add inttypes.h and stdin.h.
4505 (PROCESS_H): Add unistd.h.
4506
4507 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4508
4509 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4510 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4511
4512 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4513
4514 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4515
4516 * term.c (vfatal): Remove stray call to va_end.
4517 It's not needed and the C Standard doesn't allow it here anyway.
4518
4519 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4520 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4521
4522 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4523 bytes.
4524
4525 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4526
4527 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4528
4529 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4530
4531 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4532
4533 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4534
4535 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4536 * charset.c (Fdefine_charset_internal): Don't initialize
4537 charset.code_space[15]. The value was garbage, on hosts with
4538 32-bit int (Bug#8600).
4539
4540 * lread.c (read_integer): Be more consistent with string-to-number.
4541 Use string_to_number to do the actual conversion; this avoids
4542 rounding errors and fixes some other screwups. Without this fix,
4543 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4544 (digit_to_number): Move earlier, for benefit of read_integer.
4545 Return -1 if the digit is out of range for the base, -2 if it is
4546 not a digit in any supported base. (Bug#8602)
4547
4548 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4549
4550 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4551 to match comment at start of function. This also removes a
4552 GCC warning about overflow in a 32+64-bit port.
4553
4554 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4555
4556 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4557 Reported by Stefan Monnier in
4558 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4559 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4560 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4561
4562 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4563 (EMACS_UINTPTR): Likewise, with uintptr_t.
4564
4565 * lisp.h: Prefer 64-bit EMACS_INT if available.
4566 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4567 on 32-bit hosts that have 64-bit int, so that they can access
4568 large files.
4569 However, temporarily disable this change unless the temporary
4570 symbol WIDE_EMACS_INT is defined.
4571
4572 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4573
4574 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4575 This removes an assumption that EMACS_INT and long are the same
4576 width as pointers. The assumption is true for Emacs porting targets
4577 now, but we want to make other targets possible.
4578 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4579 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4580 In the rest of the code, change types of integers that hold casted
4581 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4582 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4583 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4584 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4585 No need to cast type when ORing.
4586 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4587 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4588 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4589 assume EMACS_INT is the same width as char *.
4590 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4591 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4592 Remove no-longer-needed casts.
4593 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4594 (xg_tool_bar_help_callback, xg_make_tool_item):
4595 Use EMACS_INTPTR to hold an integer
4596 that will be cast to void *; this can avoid a GCC warning
4597 if EMACS_INT is not the same width as void *.
4598 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4599 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4600 (current_message_1, set_message_1):
4601 Use a local to convert to proper width without a cast.
4602 * xmenu.c (dialog_selection_callback): Likewise.
4603
4604 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4605 Also, don't assume VALBITS / RAND_BITS is less than 5,
4606 and don't rely on undefined behavior when shifting a 1 left into
4607 the sign bit.
4608 * lisp.h (get_random): Change signature to match.
4609
4610 * lread.c (hash_string): Use size_t, not int, for hash computation.
4611 Normally we prefer signed values; but hashing is special, because
4612 it's better to use unsigned division on hash table sizes so that
4613 the remainder is nonnegative. Also, size_t is the natural width
4614 for hashing into memory. The previous code used 'int', which doesn't
4615 retain enough info to hash well into very large tables.
4616 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4617
4618 * dbusbind.c: Don't possibly lose pointer info when converting.
4619 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4620 Use XPNTR rather than XHASH, so that the high-order bits of
4621 the pointer aren't lost when converting through void *.
4622
4623 * eval.c (Fautoload): Don't double-shift a pointer.
4624
4625 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4626
4627 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4628
4629 * gnutls.c (DEF_GNUTLS_FN):
4630 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4631
4632 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4633
4634 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4635 marker. (Bug#8610)
4636
4637 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4638
4639 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4640 New version that can reserve upto 2GB of heap space.
4641
4642 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4643
4644 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4645
4646 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4647
4648 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4649 `gnutls_certificate_set_x509_key_file'.
4650
4651 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4652
4653 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4654 Update dependencies.
4655
4656 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4657
4658 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4659 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4660 Remove unused parameter `fildes'.
4661 * process.c (read_process_output, send_process): Don't pass it.
4662
4663 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4664
4665 Fix previous change: the library cache is defined in w32.c.
4666 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4667 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4668
4669 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4670
4671 Implement dynamic loading of GnuTLS on Windows.
4672
4673 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4674 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4675 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4676 Declare.
4677
4678 * gnutls.c (Qgnutls_dll): Define.
4679 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4680 (gnutls_*): Declare function pointers.
4681 (init_gnutls_functions): New function to initialize function pointers.
4682 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4683 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4684 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4685 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4686 (emacs_gnutls_write, emacs_gnutls_read)
4687 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4688 (Fgnutls_available_p): New function.
4689 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4690 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4691 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4692
4693 * image.c: Include w32.h.
4694 (Vimage_type_cache): Delete.
4695 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4696 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4697 (w32_delayed_load): Move to w32.c.
4698
4699 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4700
4701 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4702 (w32_delayed_load): Move from image.c. When loading a library, record
4703 its filename in the :loaded-from property of the library id.
4704 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4705 Initialize and staticpro them.
4706 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4707
4708 * process.c: Include lisp.h before w32.h, not after.
4709 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4710 instead of gnutls_record_check_pending.
4711
4712 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4713
4714 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4715
4716 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4717 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4718 as passed in.
4719
4720 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4721
4722 * xterm.c (x_set_frame_alpha): Do not set property on anything
4723 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4724
4725 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4726
4727 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4728
4729 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4730
4731 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4732 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4733 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4734 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4735 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4736 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4737 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4738 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4739 (Qgnutls_bootprop_callbacks_verify): Make static.
4740
4741 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4742
4743 * callproc.c: Indentation fixup.
4744
4745 * sysdep.c (wait_for_termination_1): Make static.
4746 (wait_for_termination, interruptible_wait_for_termination):
4747 Move after wait_for_termination_1.
4748
4749 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4750
4751 * sysdep.c (interruptible_wait_for_termination): New function
4752 which is like wait_for_termination, but allows keyboard
4753 interruptions.
4754
4755 * callproc.c (Fcall_process): Add (:file "file") as an option for
4756 the STDOUT buffer.
4757 (Fcall_process_region): Ditto.
4758
4759 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4760
4761 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4762 rather than `XVECTOR (FOO)->size'.
4763
4764 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4765 inttypes.h, as a gnulib replacement is used if it not available in
4766 system headers.
4767
4768 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4769
4770 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4771 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4772 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4773
4774 * coding.c (coding_alloc_by_realloc): Error out if destination
4775 will grow beyond MOST_POSITIVE_FIXNUM.
4776 (decode_coding_emacs_mule): Abort if there isn't enough place in
4777 charbuf for the composition carryover bytes. Reserve an extra
4778 space for up to 2 characters produced in a loop.
4779 (decode_coding_iso_2022): Abort if there isn't enough place in
4780 charbuf for the composition carryover bytes.
4781
4782 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4783
4784 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4785 aborting when %lld or %lll format is passed.
4786 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4787 %llo or %llx format is passed. (Bug#8545)
4788
4789 * window.c (window_scroll_line_based): Use a marker instead of
4790 simple variables to record original value of point. (Bug#7952)
4791
4792 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4793 produced by %s or %c overflows available buffer space. (Bug#8545)
4794
4795 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4796
4797 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4798 (SIZE_MAX): Move defn after all includes, as they might #define it.
4799
4800 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4801
4802 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4803
4804 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4805
4806 * keyboard.c (Qdelayed_warnings_hook): Define.
4807 (command_loop_1): Run `delayed-warnings-hook'
4808 if Vdelayed_warnings_list is non-nil.
4809 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4810 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4811
4812 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4813
4814 * doprnt.c (doprnt): Don't return value smaller than the buffer
4815 size if the message was truncated. (Bug#8545).
4816
4817 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4818
4819 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4820 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4821
4822 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4823
4824 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4825
4826 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4827
4828 * makefile.w32-in: Update dependencies.
4829
4830 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4831
4832 Improve `doprnt' and its usage. (Bug#8545)
4833 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4834 `format_end'. Remove support for %l as a conversion specifier.
4835 Don't use xrealloc. Improve diagnostics when the %l size modifier
4836 is used. Update the commentary.
4837
4838 * eval.c (verror): Simplify calculation of size_t.
4839
4840 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4841 messages.
4842
4843 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4844
4845 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4846 change.
4847
4848 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4849
4850 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4851 This makes this file independent of the recent pseudovector change.
4852
4853 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4854
4855 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4856
4857 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4858 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4859 Remove unused local.
4860 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4861
4862 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4863 GCC 4.6.0 optimizes based on type-based alias analysis.
4864 For example, if b is of type struct buffer * and v of type struct
4865 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4866 != &v->size, and therefore "v->size = 1; b->size = 2; return
4867 v->size;" must therefore return 1. This assumption is incorrect
4868 for Emacs, since it type-puns struct Lisp_Vector * with many other
4869 types. To fix this problem, this patch adds a new type struct
4870 vectorlike_header that documents the constraints on layout of vectors
4871 and pseudovectors, and helps optimizing compilers not get fooled
4872 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4873 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4874 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4875 the size member.
4876 (XSETPVECTYPE): Rewrite in terms of new macro.
4877 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4878 This is a bit clearer, and further avoids the possibility of
4879 undesirable aliasing.
4880 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4881 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4882 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4883 since Lisp_Subr is a special case (no "next" field).
4884 (ASIZE): Now uses header.size rather than size.
4885 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4886 to avoid the hassle of writing XVECTOR (foo)->header.size.
4887 (struct vectorlike_header): New type.
4888 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4889 object, to help avoid aliasing.
4890 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4891 (SUBRP): Likewise, since Lisp_Subr is a special case.
4892 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4893 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4894 (struct Lisp_Hash_Table): Combine first two members into a single
4895 struct vectorlike_header member. All uses of "size" and "next" members
4896 changed to be "header.size" and "header.next".
4897 * buffer.h (struct buffer): Likewise.
4898 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4899 * frame.h (struct frame): Likewise.
4900 * process.h (struct Lisp_Process): Likewise.
4901 * termhooks.h (struct terminal): Likewise.
4902 * window.c (struct save_window_data, struct saved_window): Likewise.
4903 * window.h (struct window): Likewise.
4904 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4905 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4906 * buffer.c (init_buffer_once): Likewise.
4907 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4908 special case.
4909 * process.c (Fformat_network_address): Use local var for size,
4910 for brevity.
4911
4912 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4913
4914 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4915 * data.c (atof): Remove decl; no longer used or needed.
4916 (digit_to_number): Move to lread.c.
4917 (Fstring_to_number): Use new string_to_number function, to be
4918 consistent with how the Lisp reader treats infinities and NaNs.
4919 Do not assume that floating-point numbers represent EMACS_INT
4920 without losing information; this is not true on most 64-bit hosts.
4921 Avoid double-rounding errors, by insisting on integers when
4922 parsing non-base-10 numbers, as the documentation specifies.
4923 * lisp.h (string_to_number): New decl, replacing ...
4924 (isfloat_string): Remove.
4925 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4926 (read1): Do not accept +. and -. as integers; this
4927 appears to have been a coding error. Similarly, do not accept
4928 strings like +-1e0 as floating point numbers. Do not report
4929 overflow for integer overflows unless the base is not 10 which
4930 means we have no simple and reliable way to continue.
4931 Break out the floating-point parsing into a new
4932 function string_to_number, so that Fstring_to_number parses
4933 floating point numbers consistently with the Lisp reader.
4934 (digit_to_number): Move here from data.c. Make it static inline.
4935 (E_CHAR, EXP_INT): Remove, replacing with ...
4936 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4937 (string_to_number): New function, replacing isfloat_string.
4938 This function checks for valid syntax and produces the resulting
4939 Lisp float number too. Rework it so that string-to-number
4940 no longer mishandles examples like "1.0e+". Use strtoumax,
4941 so that overflow for non-base-10 numbers is reported only when
4942 there's no portable and simple way to convert to floating point.
4943
4944 * textprop.c (set_text_properties_1): Rewrite for clarity,
4945 and to avoid GCC warning about integer overflow.
4946
4947 * intervals.h (struct interval): Use EMACS_INT for members
4948 where EMACS_UINT might cause problems. See
4949 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4950 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4951 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4952 All uses changed.
4953 (offset_intervals): Tell GCC not to worry about length overflow
4954 when negating a negative length.
4955
4956 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4957 (overrun_check_free): Likewise.
4958
4959 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4960 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4961 word size.
4962
4963 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4964 (gnutls_make_error): Rename local to avoid shadowing.
4965 (gnutls_emacs_global_deinit): ifdef out; not used.
4966 (Fgnutls_boot): Use const for pointer to readonly storage.
4967 Comment out unused local. Fix pointer signedness problems.
4968
4969 * lread.c (openp): Don't stuff size_t into an 'int'.
4970 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4971 about possible signed overflow.
4972
4973 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4974 (GDK_KEY_g): Don't define if already defined.
4975 (xg_prepare_tooltip): Avoid pointer signedness problem.
4976 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4977
4978 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4979 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4980
4981 * xfns.c (Fx_window_property): Simplify a bit,
4982 to make a bit faster and to avoid GCC 4.6.0 warning.
4983 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4984
4985 * fns.c (internal_equal): Don't assume size_t fits in int.
4986
4987 * alloc.c (compact_small_strings): Tighten assertion a little.
4988
4989 Replace pEd with more-general pI, and fix some printf arg casts.
4990 * lisp.h (pI): New macro, generalizing old pEd macro to other
4991 conversion specifiers. For example, use "...%"pI"d..." rather
4992 than "...%"pEd"...".
4993 (pEd): Remove. All uses replaced with similar uses of pI.
4994 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4995 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4996 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4997 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4998 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4999 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5000 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5001 64-bit hosts.
5002 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5003 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5004 * print.c (safe_debug_print, print_object): Likewise.
5005 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5006 to int.
5007 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5008 avoiding the 0 flag, which is not portable.
5009 * process.c (Fmake_network_process): Use pI to avoid cast.
5010 * region-cache.c (pp_cache): Likewise.
5011 * xdisp.c (decode_mode_spec): Likewise.
5012 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5013 behavior on 64-bit hosts with printf arg.
5014 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5015 (x_stop_queuing_selection_requests): Likewise.
5016 (x_get_window_property): Don't truncate byte count to an 'int'
5017 when tracing.
5018
5019 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5020 here, since it parses constructs like leading '-' and spaces,
5021 which are not wanted; and it overflows with large numbers.
5022 Instead, simply match F[0-9]+, which is what is wanted anyway.
5023
5024 * alloc.c: Remove unportable assumptions about struct layout.
5025 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5026 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5027 (allocate_vectorlike, make_pure_vector): Use the new macros,
5028 plus offsetof, to remove unportable assumptions about struct layout.
5029 These assumptions hold on all porting targets that I know of, but
5030 they are not guaranteed, they're easy to remove, and removing them
5031 makes further changes easier.
5032
5033 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5034 This doesn't fix a bug but makes the code clearer.
5035 (string_overrun_cookie): Now const. Use initializers that
5036 don't formally overflow signed char, to avoid warnings.
5037 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5038 can cause Emacs to crash when string overrun checking is enabled.
5039 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5040 multiple of sizeof (EMACS_INT); it need not be, if
5041 alignof(EMACS_INT) < sizeof (EMACS_INT).
5042 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5043
5044 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5045
5046 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5047
5048 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5049
5050 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5051 supposed to be handshaking. (Bug#8556)
5052 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5053
5054 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5055
5056 * lisp.h (Qdebug): List symbol.
5057 * eval.c (Qdebug): Restore global linkage.
5058 * keyboard.c (debug-on-event): New variable.
5059 (handle_user_signal): Break into debugger when debug-on-event
5060 matches the current signal symbol.
5061
5062 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5063
5064 * alloc.c (check_sblock, check_string_bytes)
5065 (check_string_free_list): Convert to standard C.
5066
5067 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5068
5069 * w32.c (emacs_gnutls_push): Fix typo.
5070
5071 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5072
5073 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5074 "cast to pointer from integer of different size".
5075
5076 Improve doprnt and its use in verror. (Bug#8545)
5077 * doprnt.c (doprnt): Document the set of format control sequences
5078 supported by the function. Use SAFE_ALLOCA instead of always
5079 using `alloca'.
5080
5081 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5082 is one byte too soon. Don't use xrealloc; instead xfree and
5083 xmalloc anew.
5084
5085 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5086
5087 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5088 callbacks stage.
5089
5090 * gnutls.c: Renamed global_initialized to
5091 gnutls_global_initialized. Added internals for the
5092 :verify-hostname-error, :verify-error, and :verify-flags
5093 parameters of `gnutls-boot' and documented those parameters in the
5094 docstring. Start callback support.
5095 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5096 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5097 on error. Return error code.
5098 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5099 (emacs_gnutls_read): Likewise.
5100 (Fgnutls_boot): Return handshake error code.
5101 (emacs_gnutls_handle_error): New function.
5102 (wsaerror_to_errno): Likewise.
5103
5104 * w32.h (emacs_gnutls_pull): Add prototype.
5105 (emacs_gnutls_push): Likewise.
5106
5107 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5108 (emacs_gnutls_push): Likewise.
5109
5110 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5111
5112 * process.c (wait_reading_process_output): Check if GnuTLS
5113 buffered some data internally if no FDs are set for TLS
5114 connections.
5115
5116 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5117 (LIBS): Link to USER_LIBS.
5118 ($(BLD)/gnutls.$(0)): New target.
5119
5120 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5121
5122 * xdisp.c (handle_single_display_spec): Rename the
5123 display_replaced_before_p argument into display_replaced_p, to
5124 make it consistent with the commentary. Fix typos in the
5125 commentary.
5126
5127 * textprop.c (syms_of_textprop): Remove dead code.
5128 (copy_text_properties): Delete obsolete commentary about an
5129 interface that was deleted long ago. Fix typos in the description
5130 of arguments.
5131
5132 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5133 to changes in oldXMenu/XMenu.h from 2011-04-16.
5134 <menu_help_message, prev_menu_help_message>: Constify.
5135 (IT_menu_make_room): menu->help_text is now `const char **';
5136 adjust.
5137
5138 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5139 to changes in oldXMenu/XMenu.h from 2011-04-16.
5140 (struct XMenu): Declare `help_text' `const char **'.
5141
5142 * xfaces.c <Qunspecified>: Make extern again.
5143
5144 * syntax.c: Include sys/types.h before including regex.h, as
5145 required by Posix.
5146
5147 * doc.c (get_doc_string): Improve the format passed to `error'.
5148
5149 * doprnt.c (doprnt): Improve commentary.
5150
5151 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5152
5153 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5154 them with etags.
5155
5156 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5157 changes in globals.h immediately force recompilation.
5158 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5159 $(CURDIR)/s/ms-w32.h.
5160 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5161
5162 * character.c (Fchar_direction): Function deleted.
5163 (syms_of_character): Don't defsubr it.
5164 <char-direction-table>: Deleted.
5165
5166 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5167
5168 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5169 * doprnt.c: Include limits.h.
5170 (SIZE_MAX): New macro.
5171 (doprnt): Return a size_t value. 2nd arg is now size_t.
5172 Many local variables are now size_t instead of int or unsigned.
5173 Improve overflow protection. Support `l' modifier for integer
5174 conversions. Support %l conversion. Don't assume an EMACS_INT
5175 argument for integer conversions and for %c.
5176
5177 * lisp.h (doprnt): Restore prototype.
5178
5179 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5180 $(SRC)/character.h.
5181
5182 * Makefile.in (base_obj): Add back doprnt.o.
5183
5184 * deps.mk (doprnt.o): Add back prerequisites.
5185 (callint.o): Depend on character.h.
5186
5187 * eval.c (internal_lisp_condition_case): Include the handler
5188 representation in the error message.
5189 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5190 when breaking from the loop.
5191
5192 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5193
5194 * callint.c (Fcall_interactively): When displaying error message
5195 about invalid control letter, pass the character's codepoint, not
5196 a pointer to its multibyte form. Improve display of the character
5197 in octal and display also its hex code.
5198
5199 * character.c (char_string): Use %x to display the (unsigned)
5200 codepoint of an invalid character, to avoid displaying a bogus
5201 negative value.
5202
5203 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5204 `error', not SYMBOL_NAME itself.
5205
5206 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5207 character arguments to `error'.
5208
5209 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5210 to `error' in error message about FINAL_CHAR argument. Make sure
5211 FINAL_CHAR is a character, and use %c when it is passed as
5212 argument to `error'.
5213
5214 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5215
5216 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5217
5218 * w32.c: Include <time.h>.
5219 (sys_localtime): New function.
5220
5221 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5222
5223 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5224
5225 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5226
5227 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5228
5229 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5230 zombies (Bug#8467).
5231
5232 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5233
5234 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5235 gl_state.e_property when gl_state.object is Qt.
5236
5237 * insdel.c (make_gap_larger): Remove limitation of buffer size
5238 to <= INT_MAX.
5239
5240 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5241
5242 * xdisp.c (lookup_glyphless_char_display)
5243 (produce_glyphless_glyph): Handle cons cell entry in
5244 glyphless-char-display.
5245 (Vglyphless_char_display): Document it.
5246
5247 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5248 glyphless-char-display.
5249
5250 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5251
5252 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5253
5254 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5255
5256 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5257 definition for no-X builds.
5258
5259 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5260
5261 Static checks with GCC 4.6.0 and non-default toolkits.
5262
5263 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5264
5265 * process.c (keyboard_bit_set): Define only if SIGIO.
5266 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5267 (send_process): Repair possible setjmp clobbering.
5268
5269 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5270
5271 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5272
5273 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5274
5275 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5276 Define only if needed.
5277
5278 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5279 by pacifying GCC about it. Maybe it's time to retire it?
5280 * xfaces.c (USG, __TIMEVAL__): Likewise.
5281
5282 * dispextern.h (struct redisplay_interface): Rename param
5283 to avoid shadowing.
5284 * termhooks.h (struct terminal): Likewise.
5285 * xterm.c (xembed_send_message): Likewise.
5286
5287 * insdel.c (make_gap_smaller): Define only if
5288 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5289
5290 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5291 it.
5292
5293 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5294 so that we aren't warned about unused symbols.
5295
5296 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5297
5298 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5299
5300 * xfns.c (x_real_positions): Mark locals as initialized.
5301
5302 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5303
5304 * xterm.c: Fix problems found by static analysis with other toolkits.
5305 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5306 (x_dispatch_event): Declare static if USE_GTK, and
5307 define if USE_GTK || USE_X_TOOLKIT.
5308 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5309 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5310 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5311 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5312
5313 * xmenu.c (menu_help_callback): Pointer type fixes.
5314 Use const pointers when pointing at readonly data. Avoid pointer
5315 signedness clashes.
5316 (FALSE): Remove unused macro.
5317 (update_frame_menubar): Remove unused decl.
5318
5319 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5320
5321 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5322 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5323 (single_menu_item): Rename local to avoid shadowing.
5324
5325 * keyboard.c (make_lispy_event): Remove unused local var.
5326
5327 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5328 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5329
5330 * bitmaps: Change bitmaps from unsigned char back to the X11
5331 compatible char. Avoid the old compiler warnings about
5332 out-of-range initializers by using, for example, '\xab' rather
5333 than 0xab.
5334
5335 * xgselect.c (xgselect_initialize): Check vs interface
5336 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5337
5338 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5339
5340 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5341 to read-only memory.
5342
5343 * fns.c (vector): Remove; this old hack is no longer needed.
5344
5345 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5346 Remove unused var.
5347 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5348
5349 * xrdb.c (x_load_resources): Omit unused local.
5350
5351 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5352 (x_window): Rename locals to avoid shadowing.
5353 (USG): Use the kludged USG macro, to pacify gcc.
5354
5355 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5356 (x_term_init): Remove local to avoid shadowing.
5357
5358 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5359
5360 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5361 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5362
5363 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5364
5365 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5366
5367 Fix regex.c, syntax.c and friends for buffers > 2GB.
5368 * syntax.h (struct gl_state_s): Declare character position members
5369 EMACS_INT.
5370
5371 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5372
5373 * textprop.c (verify_interval_modification, interval_of):
5374 Declare arguments EMACS_INT.
5375
5376 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5377 EMACS_INT.
5378
5379 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5380
5381 * indent.c (Fvertical_motion): Local variable it_start is now
5382 EMACS_INT.
5383
5384 * regex.c (re_match, re_match_2, re_match_2_internal)
5385 (bcmp_translate, regcomp, regexec, print_double_string)
5386 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5387 (re_compile_pattern, re_exec): Declare arguments and local
5388 variables `size_t' and `ssize_t' and return values `regoff_t', as
5389 appropriate.
5390 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5391 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5392 <compile_stack_type>: `size' and `avail' are now `size_t'.
5393
5394 * regex.h <regoff_t>: Use ssize_t, not int.
5395 (re_search, re_search_2, re_match, re_match_2): Arguments that
5396 specify buffer/string position and length are now ssize_t and
5397 size_t. Return type is regoff_t.
5398
5399 2011-04-16 Ben Key <bkey76@gmail.com>
5400
5401 * nsfont.m: Fixed bugs in ns_get_family and
5402 ns_descriptor_to_entity that were caused by using free to
5403 deallocate memory blocks that were allocated by xmalloc (via
5404 xstrdup). This caused Emacs to crash when compiled with
5405 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5406 --enable-checking=xmallocoverrun). xfree is now used to
5407 deallocate these memory blocks.
5408
5409 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5410
5411 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5412
5413 emacs_write: Accept and return EMACS_INT for sizes.
5414 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5415 et seq.
5416 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5417 Accept and return EMACS_INT.
5418 (emacs_gnutls_write): Return the number of bytes written on
5419 partial writes.
5420 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5421 (emacs_read, emacs_write): Remove check for negative size, as the
5422 Emacs source code has been audited now.
5423 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5424 (emacs_read, emacs_write): Use it.
5425 * process.c (send_process): Adjust to the new signatures of
5426 emacs_write and emacs_gnutls_write. Do not attempt to store
5427 a byte offset into an 'int'; it might overflow.
5428 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5429
5430 * sound.c: Don't assume sizes fit in 'int'.
5431 (struct sound_device.period_size, alsa_period_size):
5432 Return EMACS_INT, not int.
5433 (struct sound_device.write, vox_write, alsa_write):
5434 Accept EMACS_INT, not int.
5435 (wav_play, au_play): Use EMACS_INT to store sizes and to
5436 record read return values.
5437
5438 2011-04-15 Ben Key <bkey76@gmail.com>
5439
5440 * keyboard.c (Qundefined): Don't declare static since it is used
5441 in nsfns.m.
5442 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5443 static since they are used in nsfont.m.
5444
5445 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5446
5447 * process.c (Qprocessp): Don't declare static.
5448 * lisp.h (Qprocessp): Declare again.
5449
5450 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5451
5452 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5453
5454 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5455
5456 Improve C-level modularity by making more things 'static'.
5457
5458 Don't publish debugger-only interfaces to other modules.
5459 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5460 (verify_bytepos, count_markers): Move decls to the only modules
5461 that need them.
5462 * region-cache.h (pp_cache): Likewise.
5463 * window.h (check_all_windows): Likewise.
5464 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5465
5466 * sysdep.c (croak): Now static, if
5467 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5468 * syssignal.h (croak): Declare only if not static.
5469
5470 * alloc.c (refill_memory_reserve): Now static if
5471 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5472 * lisp.h (refill_memory_reserve): Declare only if not static.
5473
5474 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5475 Define only if USE_LUCID.
5476
5477 * xrdb.c (x_customization_string, x_rm_string): Now static.
5478
5479 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5480 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5481
5482 * xdisp.c (draw_row_with_mouse_face): Now static.
5483 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5484
5485 * window.h (check_all_windows): Mark externally visible.
5486
5487 * window.c (window_deletion_count): Now static.
5488
5489 * undo.c: Make symbols static if they're not exported.
5490 (last_undo_buffer, last_boundary_position, pending_boundary):
5491 Now static.
5492
5493 * textprop.c (interval_insert_behind_hooks): Now static.
5494 (interval_insert_in_front_hooks): Likewise.
5495
5496 * term.c: Make symbols static if they're not exported.
5497 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5498 (max_frame_lines, tty_set_terminal_modes):
5499 (tty_reset_terminal_modes, tty_turn_off_highlight):
5500 (get_tty_terminal): Now static.
5501 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5502 * termhooks.h (term_mouse_moveto): Do not declare if
5503 HAVE_WINDOW_SYSTEM.
5504 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5505 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5506
5507 * sysdep.c: Make symbols static if they're not exported.
5508 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5509 Now static.
5510 (sigprocmask_set, full_mask): Remove; unused.
5511 (wait_debugging): Mark as visible.
5512 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5513 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5514
5515 * syntax.c (syntax_temp): Define only if !__GNUC__.
5516
5517 * sound.c (current_sound_device, current_sound): Now static.
5518
5519 * search.c (searchbufs, searchbuf_head): Now static.
5520
5521 * scroll.c (scroll_cost): Remove; unused.
5522 * dispextern.h (scroll_cost): Remove decl.
5523
5524 * region-cache.h (pp_cache): Mark as externally visible.
5525
5526 * process.c: Make symbols static if they're not exported.
5527 (process_tick, update_tick, create_process, chan_process):
5528 (Vprocess_alist, proc_buffered_char, datagram_access):
5529 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5530 (deactivate_process): Mark defn as static, as well as decl.
5531 * lisp.h (create_process): Remove decl.
5532 * process.h (chan_process, Vprocess_alist): Remove decls.
5533
5534 * print.c: Make symbols static if they're not exported.
5535 (print_depth, new_backquote_output, being_printed, print_buffer):
5536 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5537 (print_interval, print_number_index, initial_stderr_stream):
5538 Now static.
5539 * lisp.h (Fprinc): Remove decl.
5540 (debug_output_compilation_hack): Mark as externally visible.
5541
5542 * sysdep.c (croak): Move decl from here to syssignal.h.
5543 * syssignal.h (croak): Put it here, so the API can be checked when
5544 'croak' is called from dissociate_if_controlling_tty.
5545
5546 * minibuf.c: Make symbols static if they're not exported.
5547 (minibuf_save_list, choose_minibuf_frame): Now static.
5548 * lisp.h (choose_minibuf_frame): Remove decl.
5549
5550 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5551
5552 * lread.c: Make symbols static if they're not exported.
5553 (read_objects, initial_obarray, oblookup_last_bucket_number):
5554 Now static.
5555 (make_symbol): Remove; unused.
5556 * lisp.h (initial_obarray, make_symbol): Remove decls.
5557
5558 * keyboard.c: Make symbols static if they're not exported.
5559 (single_kboard, recent_keys_index, total_keys, recent_keys):
5560 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5561 (this_single_command_key_start, echoing, last_auto_save):
5562 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5563 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5564 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5565 (Vlispy_mouse_stem, double_click_count):
5566 Now static.
5567 (force_auto_save_soon): Define only if SIGDANGER.
5568 (ignore_mouse_drag_p): Now static if
5569 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5570 (print_help): Remove; unused.
5571 (stop_character, last_timer_event): Mark as externally visible.
5572 * keyboard.h (ignore_mouse_drag_p): Declare only if
5573 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5574 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5575 * lisp.h (echoing): Remove decl.
5576 (force_auto_save_soon): Declare only if SIGDANGER.
5577 * xdisp.c (redisplay_window): Simplify code, to make it more
5578 obvious that ignore_mouse_drag_p is not accessed if !defined
5579 USE_GTK && !defined HAVE_NS.
5580
5581 * intervals.c: Make symbols static if they're not exported.
5582 (merge_properties_sticky, merge_interval_right, delete_interval):
5583 Now static.
5584 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5585
5586 * insdel.c: Make symbols static if they're not exported.
5587 However, leave prepare_to_modify_buffer alone. It's never
5588 called from outside this function, but that appears to be a bug.
5589 (combine_after_change_list, combine_after_change_buffer):
5590 (adjust_after_replace, signal_before_change): Now static.
5591 (adjust_after_replace_noundo): Remove; unused.
5592 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5593 (signal_before_change): Remove decls.
5594
5595 * indent.c (val_compute_motion, val_vmotion): Now static.
5596
5597 * image.c: Make symbols static if they're not exported.
5598 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5599 if USE_GTK.
5600 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5601 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5602
5603 * fringe.c (standard_bitmaps): Now static.
5604 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5605
5606 * frame.c: Make symbols static if they're not exported.
5607 (x_report_frame_params, make_terminal_frame): Now static.
5608 (get_frame_param): Now static, unless HAVE_NS.
5609 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5610 (x_get_resource_string): Remove; not used.
5611 * frame.h (make_terminal_frame, x_report_frame_params):
5612 (x_get_resource_string); Remove decls.
5613 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5614 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5615
5616 * font.c, fontset.c: Make symbols static if they're not exported.
5617 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5618 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5619 * font.c (font_close_object): Now static.
5620 * font.h (font_close_object): Remove.
5621 * fontset.c (FONTSET_OBJLIST): Remove.
5622 (free_realized_fontset) #if-0 the body, which does nothing.
5623 (face_suitable_for_char_p): #if-0, as it's never called.
5624 * fontset.h (face_suitable_for_char_p): Remove decl.
5625 * xfaces.c (face_at_string_position):
5626 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5627 since 0 is always ASCII.
5628
5629 * fns.c (weak_hash_tables): Now static.
5630
5631 * fileio.c: Make symbols static if they're not exported.
5632 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5633 (Vwrite_region_annotation_buffers): Now static.
5634
5635 * eval.c: Make symbols static if they're not exported.
5636 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5637 * lisp.h (backtrace_list): Remove decl.
5638
5639 * emacs.c: Make symbols static if they're not exported.
5640 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5641 (fatal_error_code, fatal_error_signal_hook, standard_args):
5642 Now static.
5643 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5644 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5645 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5646 * lisp.h (fatal_error_signal_hook): Remove decl.
5647 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5648
5649 * editfns.c: Move a (normally-unused) function to its only use.
5650 * editfns.c, lisp.h (get_operating_system_release): Remove.
5651 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5652 worth the hassle of breaking this out.
5653
5654 * xterm.c: Make symbols static if they're not exported.
5655 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5656 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5657 (x_destroy_window, x_delete_display):
5658 Now static.
5659 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5660 (x_mouse_leave): Remove; unused.
5661 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5662 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5663 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5664 Remove decls.
5665 (x_mouse_leave): Declare only if WINDOWSNT.
5666 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5667 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5668 USE_X_TOOLKIT.
5669
5670 * ftxfont.c: Make symbols static if they're not exported.
5671 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5672 HAVE_FREETYPE.
5673 * font.h (ftxfont_driver): Likewise.
5674
5675 * xfns.c: Make symbols static if they're not exported.
5676 (x_last_font_name, x_display_info_for_name):
5677 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5678 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5679 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5680 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5681 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5682 (last_show_tip_args): Now static.
5683 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5684 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5685 (x_screen_planes): Remove; unused.
5686 * dispextern.h (x_screen_planes): Remove decl.
5687
5688 * dispnew.c: Make symbols static if they're not exported.
5689 * dispextern.h (redraw_garbaged_frames, scrolling):
5690 (increment_row_positions): Remove.
5691 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5692 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5693 Now static.
5694 (redraw_garbaged_frames): Remove; unused.
5695
5696 * xfaces.c: Make symbols static if they're not exported.
5697 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5698 Remove decls.
5699 * xterm.h (defined_color): Remove decls.
5700 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5701 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5702 (menu_face_changed_default, defined_color, free_realized_face):
5703 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5704 (ascii_face_of_lisp_face): Remove; unused.
5705
5706 * xdisp.c: Make symbols static if they're not exported.
5707 * dispextern.h (scratch_glyph_row, window_box_edges):
5708 (glyph_to_pixel_coords, set_cursor_from_row):
5709 (get_next_display_element, set_iterator_to_next):
5710 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5711 (show_mouse_face): Remove decls
5712 * frame.h (message_buf_print): Likewise.
5713 * lisp.h (pop_message, set_message, check_point_in_composition):
5714 Likewise.
5715 * xterm.h (set_vertical_scroll_bar): Likewise.
5716 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5717 (message_buf_print, scratch_glyph_row, displayed_buffer):
5718 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5719 (get_next_display_element, show_mouse_face, window_box_edges):
5720 (frame_to_window_pixel_xy, check_point_in_composition):
5721 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5722 (glyph_to_pixel_coords): Remove; unused.
5723
5724 * dired.c (file_name_completion): Now static.
5725
5726 * dbusbind.c (xd_in_read_queued_messages): Now static.
5727
5728 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5729 * data.c (circular_list_error): Remove.
5730
5731 * commands.h (last_point_position, last_point_position_buffer):
5732 (last_point_position_window): Remove decls.
5733 * keyboard.c: Make these variables static.
5734
5735 * coding.h (coding, code_convert_region, encode_coding_gap):
5736 Remove decls.
5737 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5738 (iso_code_class, detect_coding, code_convert_region): Now static.
5739 (encode_coding_gap): Remove; unused.
5740
5741 * chartab.c (chartab_chars, chartab_bits): Now static.
5742
5743 * charset.h (charset_iso_8859_1): Remove decl.
5744 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5745 Now static.
5746
5747 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5748 * ccl.c (Vccl_program_table): Now static.
5749 (check_ccl_update): Remove; unused.
5750
5751 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5752 * category.h: ... from here.
5753 * category.c (check_category_table, set_category_set): Now static.
5754
5755 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5756 * lisp.h: Remove these decls.
5757
5758 * buffer.c (buffer_count): Remove unused var.
5759
5760 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5761 so that it's not optimized away.
5762 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5763 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5764 exported only to the debugger.
5765
5766 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5767 * atimer.h (run_all_atimers): Remove; not exported.
5768
5769 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5770 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5771 was inaccessible from Lisp.
5772 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5773 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5774
5775 alloc.c: Import and export fewer symbols, and remove unused items.
5776 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5777 is defined.
5778 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5779 it's not optimized away by whole-program optimization.
5780 (message_enable_multibyte, free_misc): Remove.
5781 (catchlist, handlerlist, mark_backtrace):
5782 Declare only if BYTE_MARK_STACK.
5783 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5784 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5785 (message_enable_multibyte): Remove decl.
5786 (free_misc, interval_free_list, float_block, float_block_index):
5787 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5788 (cons_free_list, last_marked_index):
5789 Now static.
5790 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5791 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5792 (mark_backtrace): Define only if BYTE_MARK_STACK.
5793 * xdisp.c (message_enable_multibyte): Now static.
5794
5795 Declare Lisp_Object Q* variables to be 'static' if not exported.
5796 This makes it easier for human readers (and static analyzers)
5797 to see whether these variables are used from other modules.
5798 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5799 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5800 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5801 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5802 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5803 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5804 * xmenu.c, xselect.c:
5805 Declare Q* vars static if they are not used in other modules.
5806 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5807 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5808 Remove decls of unexported vars.
5809 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5810
5811 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5812
5813 Make Emacs functions such as Fatom 'static' by default.
5814 This makes it easier for human readers (and static analyzers)
5815 to see whether these functions can be called from other modules.
5816 DEFUN now defines a static function. To make the function external
5817 so that it can be used in other C modules, use the new macro DEFUE.
5818 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5819 (Finit_image_library):
5820 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5821 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5822 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5823 Remove decls, since these functions are now static.
5824 (Funintern, Fget_internal_run_time): New decls, since these functions
5825 were already external.
5826
5827 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5828 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5829 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5830 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5831 * keyboard.c, keymap.c, lread.c:
5832 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5833 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5834 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5835 Mark functions with DEFUE instead of DEFUN,
5836 if they are used in other modules.
5837 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5838 decls for now-static functions.
5839 * buffer.h (Fdelete_overlay): Remove decl.
5840 * callproc.c (Fgetenv_internal): Mark as internal.
5841 * composite.c (Fremove_list_of_text_properties): Remove decl.
5842 (Fcomposition_get_gstring): New forward static decl.
5843 * composite.h (Fcomposite_get_gstring): Remove decl.
5844 * dired.c (Ffile_attributes): New forward static decl.
5845 * doc.c (Fdocumntation_property): New forward static decl.
5846 * eval.c (Ffetch_bytecode): New forward static decl.
5847 (Funintern): Remove extern decl; now in .h file where it belongs.
5848 * fileio.c (Fmake_symbolic_link): New forward static decl.
5849 * image.c (Finit_image_library): New forward static decl.
5850 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5851 * intervals.h (Fprevious_property_change):
5852 (Fremove_list_of_text_properties): Remove decls.
5853 * keyboard.c (Fthis_command_keys): Remove decl.
5854 (Fcommand_execute): New forward static decl.
5855 * keymap.c (Flookup_key): New forward static decl.
5856 (Fcopy_keymap): Now static.
5857 * keymap.h (Flookup_key): Remove decl.
5858 * process.c (Fget_process): New forward static decl.
5859 (Fprocess_datagram_address): Mark as internal.
5860 * syntax.c (Fsyntax_table_p): New forward static decl.
5861 (skip_chars): Remove duplicate decl.
5862 * textprop.c (Fprevious_property_change): New forward static decl.
5863 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5864 Now internal.
5865 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5866 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5867
5868 * editfns.c (Fformat): Remove unreachable code.
5869
5870 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5871
5872 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5873 change. (Bug#8496)
5874
5875 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5876
5877 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5878 when at ZV. (Bug#8487)
5879
5880 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5881
5882 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5883 (Bug#8437)
5884 * keyboard.c (parse_tool_bar_item): Likewise.
5885 * sound.c (sound_cleanup, alsa_close): Likewise.
5886 * termcap.c (tgetent): Likewise.
5887 * xfns.c (x_default_font_parameter): Likewise.
5888 * xsettings.c (read_and_apply_settings): Likewise.
5889
5890 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5891 (overrun_check_free): Protoize.
5892
5893 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5894
5895 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5896 since callers should never pass a negative size.
5897 Change the signature to match that of plain 'read' and 'write'; see
5898 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5899 * lisp.h: Update prototypes of emacs_write and emacs_read.
5900
5901 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5902
5903 * xdisp.c (redisplay_window): Don't try to determine the character
5904 position of the scroll margin if the window start point w->startp
5905 is outside the buffer's accessible region. (Bug#8468)
5906
5907 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5908
5909 Fix write-region and its subroutines for buffers > 2GB.
5910 * fileio.c (a_write, e_write): Modify declaration of arguments and
5911 local variables to support buffers larger than 2GB.
5912 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5913
5914 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5915 argument, local variables, and return value.
5916
5917 * lisp.h: Update prototypes of emacs_write and emacs_read.
5918
5919 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5920
5921 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5922
5923 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5924
5925 Fix more problems found by GCC 4.6.0's static checks.
5926
5927 * xdisp.c (vmessage): Use a better test for character truncation.
5928
5929 * charset.c (load_charset_map): <, not <=, for optimization,
5930 and to avoid potential problems with integer overflow.
5931 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5932 * casetab.c (set_identity, shuffle): Likewise.
5933 * editfns.c (Fformat): Likewise.
5934 * syntax.c (skip_chars): Likewise.
5935
5936 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5937 This also lets GCC 4.6.0 generate slightly better loop code.
5938
5939 * callint.c (Fcall_interactively): <, not <=, for optimization.
5940 (Fcall_interactively): Count the number of arguments produced,
5941 not the number of arguments given. This is simpler and lets GCC
5942 4.6.0 generate slightly better code.
5943
5944 * ftfont.c: Distingish more carefully between FcChar8 and char.
5945 The previous code passed unsigned char * to a functions like
5946 strlen and xstrcasecmp that expect char *, which does not
5947 conform to the C standard.
5948 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5949 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5950 char * when the C standard requires it.
5951
5952 * keyboard.c (read_char): Remove unused var.
5953
5954 * eval.c: Port to Windows vsnprintf (Bug#8435).
5955 Include <limits.h>.
5956 (SIZE_MAX): Define if the headers do not.
5957 (verror): Do not give up if vsnprintf returns a negative count.
5958 Instead, grow the buffer. This ports to Windows vsnprintf, which
5959 does not conform to C99. Problem reported by Eli Zaretskii.
5960 Also, simplify the allocation scheme, by avoiding the need for
5961 calling realloc, and removing the ALLOCATED variable.
5962
5963 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5964
5965 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5966 But keep the doprint source code for now, as we might revamp it
5967 and use it again (Bug#8435).
5968 * lisp.h (doprnt): Remove.
5969 * Makefile.in (base_obj): Remove doprnt.o.
5970 * deps.mk (doprnt.o): Remove.
5971
5972 error: Print 32- and 64-bit integers portably (Bug#8435).
5973 Without this change, on typical 64-bit hosts error ("...%d...", N)
5974 was used to print both 32- and 64-bit integers N, which relied on
5975 undefined behavior.
5976 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5977 New macro.
5978 * lisp.h (error, verror): Mark as printf-like functions.
5979 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5980 Report overflow in size calculations when allocating printf buffer.
5981 Do not truncate output string at its first null byte.
5982 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5983 Truncate the output at a character boundary, since vsnprintf does not
5984 do that.
5985 * charset.c (check_iso_charset_parameter): Convert internal
5986 character to string before calling 'error', since %c now has the
5987 printf meaning.
5988 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5989 overflow when computing char to be passed to 'error'. Do not
5990 pass Lisp_Object to 'error'; pass the integer instead.
5991 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5992 formatted with plain %d.
5993
5994 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5995
5996 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5997
5998 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5999
6000 * xterm.c (x_catch_errors): Remove duplicate declaration.
6001
6002 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6003
6004 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6005
6006 2011-04-10 Jim Meyering <meyering@redhat.com>
6007
6008 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6009 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6010 return ssize_t not "int", and use size_t as the buffer length.
6011 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6012 * gnutls.h: Update declarations.
6013 * process.c (read_process_output): Use ssize_t, to match.
6014 (send_process): Likewise.
6015
6016 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6017
6018 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6019
6020 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6021
6022 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6023 Use unsigned char, to match FcChar8 type definition.
6024
6025 * xterm.c (handle_one_xevent):
6026 * xmenu.c (create_and_show_popup_menu):
6027 * xselect.c (x_decline_selection_request)
6028 (x_reply_selection_request): Avoid type-punned deref of X events.
6029
6030 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6031
6032 Fix some uses of `int' instead of EMACS_INT.
6033 * search.c (string_match_1, fast_string_match)
6034 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6035 (scan_buffer, find_next_newline_no_quit)
6036 (find_before_next_newline, search_command, Freplace_match)
6037 (Fmatch_data): Make some `int' variables be EMACS_INT.
6038
6039 * xdisp.c (display_count_lines): 3rd argument and return value now
6040 EMACS_INT. All callers changed.
6041 (pint2hrstr): Last argument is now EMACS_INT.
6042
6043 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6044 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6045 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6046 (decode_coding_utf_16, decode_coding_emacs_mule)
6047 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6048 (decode_coding_ccl, decode_coding_charset)
6049 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6050 (decode_coding_iso_2022, decode_coding_emacs_mule)
6051 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6052 <char_offset, last_offset>: Declare EMACS_INT.
6053 (encode_coding_utf_8, encode_coding_utf_16)
6054 (encode_coding_emacs_mule, encode_invocation_designation)
6055 (encode_designation_at_bol, encode_coding_iso_2022)
6056 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6057 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6058 Declare EMACS_INT.
6059 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6060 (encode_invocation_designation): Last argument P_NCHARS is now
6061 EMACS_INT.
6062 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6063 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6064
6065 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6066 All users changed.
6067
6068 * ccl.c (Fccl_execute_on_string): Declare some variables
6069 EMACS_INT.
6070
6071 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6072
6073 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6074
6075 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6076
6077 * process.c (Fformat_network_address): Doc fix.
6078
6079 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6080
6081 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6082
6083 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6084
6085 * keyboard.c (read_char): Call Lisp function help-form-show,
6086 instead of using internal_with_output_to_temp_buffer.
6087 (Qhelp_form_show): New var.
6088 (syms_of_keyboard): Use DEFSYM macro.
6089
6090 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6091
6092 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6093
6094 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6095
6096 * process.c (Flist_processes): Remove to Lisp.
6097 (list_processes_1): Delete.
6098
6099 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6100
6101 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6102
6103 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6104
6105 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6106
6107 Fix more problems found by GCC 4.6.0's static checks.
6108
6109 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6110
6111 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6112
6113 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6114
6115 * xdisp.c (vmessage): Mark as a printf-like function.
6116
6117 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6118
6119 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6120
6121 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6122 printf-like functions.
6123 (tiff_load): Add casts to remove these marks before passing them
6124 to system-supplied API.
6125
6126 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6127
6128 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6129 This avoids several warnings with gcc -Wstrict-overflow.
6130 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6131 directly, rather than having caller test rule sign. This avoids
6132 some unnecessary tests.
6133 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6134 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6135 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6136
6137 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6138 (xfont_open): Avoid unnecessary tests.
6139
6140 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6141
6142 * composite.h, composite.c (composition_gstring_put_cache):
6143 Use EMACS_INT, not int, for length.
6144
6145 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6146 breaking out part of COMPOSITION_DECODE_RULE.
6147 (COMPOSITION_DECODE_RULE): Use it.
6148 * composite.c (get_composition_id): Remove unused local vars,
6149 by using the new macro.
6150
6151 * textprop.c (set_text_properties_1): Change while to do-while,
6152 since the condition is always true at first.
6153
6154 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6155 (interval_deletion_adjustment): Return unsigned value.
6156 All uses changed.
6157
6158 * process.c (list_processes_1, create_pty, read_process_output):
6159 (exec_sentinel): Remove vars that were set but not used.
6160 (create_pty): Remove unnecessary "volatile"s.
6161 (Fnetwork_interface_info): Avoid possibility of int overflow.
6162 (read_process_output): Do adaptive read buffering even if carryover.
6163 (read_process_output): Simplify nbytes computation if buffered.
6164
6165 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6166
6167 * syntax.c (scan_words): Remove var that was set but not used.
6168 (update_syntax_table): Use unsigned instead of int.
6169
6170 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6171 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6172 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6173
6174 * print.c (print_error_message): Avoid int overflow.
6175
6176 * font.c (font_list_entities): Redo for clarity,
6177 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6178
6179 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6180 (font_score): Avoid potential overflow in diff calculation.
6181
6182 * fns.c (substring_both): Remove var that is set but not used.
6183 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6184
6185 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6186
6187 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6188 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6189 can always succeed if overflow has undefined behavior.
6190
6191 * search.c (boyer_moore, wordify): Remove vars set but not used.
6192 (wordify): Omit three unnecessary tests.
6193
6194 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6195 All callers changed. This avoids the need for an unused var.
6196
6197 * casefiddle.c (casify_region): Remove var that is set but not used.
6198
6199 * dired.c (file_name_completion): Remove var that is set but not used.
6200
6201 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6202
6203 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6204 (Finsert_file_contents): Remove unnecessary code checking fd.
6205
6206 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6207 Check for integer overflow on size calculations.
6208
6209 * buffer.c (Fprevious_overlay_change): Remove var that is set
6210 but not used.
6211
6212 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6213 Remove vars that are set but not used.
6214 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6215 (timer_check_2): Mark vars as initialized.
6216
6217 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6218
6219 * image.c (lookup_image): Remove var that is set but not used.
6220 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6221
6222 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6223 that are set but not used.
6224
6225 * xfns.c (make_invisible_cursor): Don't return garbage
6226 if XCreateBitmapFromData fails (Bug#8410).
6227
6228 * xselect.c (x_get_local_selection, x_handle_property_notify):
6229 Remove vars that are set but not used.
6230
6231 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6232 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6233
6234 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6235 Remove var that is set but not used.
6236 (scroll_bar_windows_size): Now size_t, not int.
6237 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6238 Check for overflow.
6239
6240 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6241 (map_tty_color) [!defined MSDOS]: Likewise.
6242
6243 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6244
6245 * coding.c: Remove vars that are set but not used.
6246 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6247 All callers changed.
6248 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6249 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6250 (decode_coding_charset): Remove vars that are set but not used.
6251
6252 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6253 that is set but not used.
6254
6255 * print.c (print_object): Remove var that is set but not used.
6256
6257 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6258 The gnulib version avoids calling malloc in the usual case,
6259 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6260 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6261 * filelock.c (current_lock_owner): Likewise.
6262 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6263 * sysdep.c: Include allocator.h, careadlinkat.h.
6264 (emacs_no_realloc_allocator): New static constant.
6265 (emacs_readlink): New function.
6266 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6267 ../lib/careadlinkat.h.
6268
6269 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6270
6271 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6272 first non-nil return value).
6273
6274 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6275
6276 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6277 if not defined (Bug#8403).
6278
6279 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6280
6281 * xdisp.c (display_count_lines): Remove parameter `start',
6282 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6283 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6284 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6285 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6286 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6287 and thereabouts. All callers changed.
6288 (get_per_char_metric): Remove parameter `f', unused since
6289 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6290
6291 2011-04-02 Jim Meyering <meyering@redhat.com>
6292
6293 do not dereference NULL upon failed strdup
6294 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6295 (ns_get_family): Likewise.
6296
6297 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6298
6299 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6300
6301 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6302
6303 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6304 later (Bug#8403).
6305
6306 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6307
6308 Add lexical binding.
6309
6310 * window.c (Ftemp_output_buffer_show): New fun.
6311 (Fsave_window_excursion):
6312 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6313
6314 * lread.c (lisp_file_lexically_bound_p): New function.
6315 (Fload): Bind Qlexical_binding.
6316 (readevalloop): Remove `evalfun' arg.
6317 Bind Qinternal_interpreter_environment.
6318 (Feval_buffer): Bind Qlexical_binding.
6319 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6320 Mark as dynamic.
6321 (syms_of_lread): Declare `lexical-binding'.
6322
6323 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6324
6325 * keyboard.c (eval_dyn): New fun.
6326 (menu_item_eval_property): Use it.
6327
6328 * image.c (parse_image_spec): Use Ffunctionp.
6329
6330 * fns.c (concat, mapcar1): Accept byte-code-functions.
6331
6332 * eval.c (Fsetq): Handle lexical vars.
6333 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6334 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6335 (FletX, Flet): Obey lexical binding.
6336 (Fcommandp): Handle closures.
6337 (Feval): New `lexical' arg.
6338 (eval_sub): New function extracted from Feval. Use it almost
6339 everywhere where Feval was used. Look up vars in lexical env.
6340 Handle closures.
6341 (Ffunctionp): Move from subr.el.
6342 (Ffuncall): Handle closures.
6343 (apply_lambda): Remove `eval_flags'.
6344 (funcall_lambda): Handle closures and new byte-code-functions.
6345 (Fspecial_variable_p): New function.
6346 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6347 but without exporting it to Lisp.
6348
6349 * doc.c (Fdocumentation, store_function_docstring):
6350 * data.c (Finteractive_form): Handle closures.
6351
6352 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6353 interactive spec.
6354
6355 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6356 New byte-codes.
6357 (exec_byte_code): New function extracted from Fbyte_code to handle new
6358 calling convention for byte-code-functions. Add new byte-codes.
6359
6360 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6361
6362 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6363
6364 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6365
6366 * xdisp.c (redisplay_internal): Fix prototype.
6367
6368 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6369
6370 * xdisp.c (SCROLL_LIMIT): New macro.
6371 (try_scrolling): Use it when setting scroll_limit.
6372 Limit scrolling to 100 screen lines.
6373 (redisplay_window): Even when falling back on "recentering",
6374 position point in the window according to scroll-conservatively,
6375 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6376
6377 (try_scrolling): When point is above the window, allow searching
6378 as far as scroll_max, or one screenful, to compute vertical
6379 distance from PT to the scroll margin position. This prevents
6380 try_scrolling from unnecessarily failing when
6381 scroll-conservatively is set to a value slightly larger than the
6382 window height. Clean up the case of PT below the margin at bottom
6383 of window: scroll_max can no longer be INT_MAX. When aggressive
6384 scrolling is in use, don't let point enter the opposite scroll
6385 margin as result of the scroll.
6386 (syms_of_xdisp) <scroll-conservatively>: Document the
6387 threshold of 100 lines for never-recentering scrolling.
6388
6389 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6390
6391 * dispextern.h (move_it_by_lines):
6392 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6393 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6394 (message_log_check_duplicate): Remove parameters `prev_bol' and
6395 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6396 (redisplay_internal): Remove parameter `preserve_echo_area',
6397 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6398
6399 * indent.c (Fvertical_motion):
6400 * window.c (window_scroll_pixel_based, Frecenter):
6401 Don't pass `need_y_p' to `move_it_by_lines'.
6402
6403 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6404
6405 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6406 steal a few bits to be more compact.
6407 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6408 Remove unneeded casts.
6409
6410 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6411
6412 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6413
6414 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6415 binding" message (bug#7967).
6416
6417 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6418
6419 Fix more problems found by GCC 4.6.0's static checks.
6420
6421 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6422 Remove unused local var.
6423
6424 * editfns.c (Fmessage_box): Remove unused local var.
6425
6426 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6427 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6428 Omit unused local vars.
6429 * window.c (shrink_windows): Omit unused local var.
6430 * menu.c (digest_single_submenu): Omit unused local var.
6431 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6432 Omit unused local var.
6433
6434 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6435 Don't assume string length fits in int.
6436 (keyremap_step, read_key_sequence): Use size_t for sizes.
6437 (read_key_sequence): Don't check last_real_key_start redundantly.
6438
6439 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6440 instead of alloca (Bug#8344).
6441
6442 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6443 (Fbacktrace_frame): Don't assume nframes fits in int.
6444
6445 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6446
6447 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6448 concerns.
6449
6450 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6451
6452 * cm.c (calccost): Turn while-do into do-while, for clarity.
6453
6454 * keyboard.c (syms_of_keyboard): Use the same style as later
6455 in this function when indexing through an array. This also
6456 works around GCC bug 48267.
6457
6458 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6459
6460 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6461
6462 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6463 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6464
6465 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6466 This avoids undefined behavior on integer overflow, and is a bit
6467 more convenient anyway since it is compared to a size_t variable.
6468
6469 Variadic C functions now count arguments with size_t, not int.
6470 This avoids an unnecessary limitation on 64-bit machines, which
6471 caused (substring ...) to crash on large vectors (Bug#8344).
6472 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6473 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6474 All variadic functions and their callers changed accordingly.
6475 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6476 * data.c (arith_driver, float_arith_driver): Likewise.
6477 * editfns.c (general_insert_function): Likewise.
6478 * eval.c (struct backtrace.nargs, interactive_p)
6479 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6480 (funcall_lambda, mark_backtrace): Likewise.
6481 * fns.c (concat): Likewise.
6482 * frame.c (x_set_frame_parameters): Likewise.
6483 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6484 0 if not found, not -1. All callers changed.
6485
6486 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6487 (stack_copy_size): Now size_t, not int.
6488 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6489
6490 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6491
6492 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6493 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6494 All callers changed.
6495
6496 * lisp.h (multibyte_char_to_unibyte):
6497 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6498 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6499 * character.h (CHAR_TO_BYTE8):
6500 * cmds.c (internal_self_insert):
6501 * editfns.c (general_insert_function):
6502 * keymap.c (push_key_description):
6503 * search.c (Freplace_match):
6504 * xdisp.c (message_dolog, set_message_1): All callers changed.
6505
6506 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6507
6508 * keyboard.c (safe_run_hook_funcall): New function.
6509 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6510 don't set the hook to nil, but remove the offending function instead.
6511 (Qcommand_hook_internal): Remove, unused.
6512 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6513 Vcommand_hook_internal.
6514
6515 * eval.c (enum run_hooks_condition): Remove.
6516 (funcall_nil, funcall_not): New functions.
6517 (run_hook_with_args): Call each function through a `funcall' argument.
6518 Remove `cond' argument, now redundant.
6519 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6520 (Frun_hook_with_args_until_failure): Adjust accordingly.
6521 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6522
6523 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6524
6525 * dispextern.h (string_buffer_position): Remove declaration.
6526
6527 * print.c (strout): Remove parameter `multibyte', unused since
6528 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6529
6530 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6531 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6532 All callers changed.
6533
6534 * w32.c (_wsa_errlist): Use braces for struct initializers.
6535
6536 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6537 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6538 All callers changed.
6539 (string_buffer_position): Likewise. Also, make static (it's never
6540 used outside xdisp.c).
6541 (cursor_row_p): Remove parameter `w', unused since
6542 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6543 (decode_mode_spec): Remove parameter `precision', introduced during
6544 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6545 All callers changed.
6546
6547 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6548
6549 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6550
6551 2011-03-27 Anders Lindgren <andlind@gmail.com>
6552
6553 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6554 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6555 (ns_update_auto_hide_menu_bar): New functions.
6556 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6557 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6558 ns_constrain_all_frames.
6559 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6560 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6561
6562 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6563
6564 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6565
6566 2011-03-27 Glenn Morris <rgm@gnu.org>
6567
6568 * syssignal.h: Replace RETSIGTYPE with void.
6569 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6570 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6571 Replace SIGTYPE with void everywhere.
6572 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6573 * s/template.h (SIGTYPE): Remove commented out definition.
6574
6575 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6576
6577 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6578 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6579
6580 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6581
6582 * w32.c (read_unc_volume): Use parameter `henum', instead of
6583 global variable `wget_enum_handle'.
6584
6585 * keymap.c (describe_vector): Remove parameters `indices' and
6586 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6587 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6588
6589 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6590
6591 * keyboard.c (timer_check): Remove parameter `do_it_now',
6592 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6593 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6594 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6595
6596 * keyboard.c (read_char):
6597 * w32menu.c (w32_menu_display_help):
6598 * xmenu.c (show_help_event, menu_help_callback):
6599 Adjust calls to `show_help_echo'.
6600
6601 * gtkutil.c (xg_maybe_add_timer):
6602 * keyboard.c (readable_events):
6603 * process.c (wait_reading_process_output):
6604 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6605
6606 * insdel.c (adjust_markers_gap_motion):
6607 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6608 (gap_left, gap_right): Don't call it.
6609
6610 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6611
6612 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6613 incurred during fontification.
6614
6615 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6616
6617 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6618 (DEFVAR_PER_BUFFER): Don't pass it.
6619
6620 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6621 (scrolling_window): Don't pass it.
6622
6623 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6624
6625 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6626
6627 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6628 and `suffix'.
6629 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6630 of variables specific to SELinux and computation of `encoded_absname'.
6631
6632 * image.c (XPutPixel): Remove unused variable `height'.
6633
6634 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6635
6636 * unexw32.c (get_section_info): Remove unused variable `section'.
6637
6638 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6639 (system_process_attributes): Remove unused variable `sess'.
6640 (sys_read): Remove unused variable `err'.
6641
6642 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6643 (w32_wnd_proc): Remove unused variable `isdead'.
6644 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6645 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6646 (x_create_tip_frame): Remove unused variable `tem'.
6647
6648 * w32inevt.c (w32_console_read_socket):
6649 Remove unused variable `no_events'.
6650
6651 * w32term.c (x_draw_composite_glyph_string_foreground):
6652 Remove unused variable `width'.
6653
6654 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6655
6656 * w32term.c (x_set_glyph_string_clipping):
6657 Don't pass uninitialized region to CombineRgn.
6658
6659 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6660
6661 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6662 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6663 (Fx_close_connection): Remove unused variable `i'.
6664
6665 * w32font.c (w32font_draw): Return number of glyphs.
6666 (w32font_open_internal): Remove unused variable `i'.
6667 (w32font_driver): Add missing initializer.
6668
6669 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6670 (fill_in_menu): Remove unused variable `items_added'.
6671
6672 * w32term.c (last_mouse_press_frame): Remove static global variable.
6673 (w32_clip_to_row): Remove unused variable `f'.
6674 (x_delete_terminal): Remove unused variable `i'.
6675
6676 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6677 (NOTHING): Remove unused static global variable.
6678 (uniscribe_check_otf): Remove unused variable `table'.
6679 (uniscribe_font_driver): Add missing initializers.
6680
6681 2011-03-23 Julien Danjou <julien@danjou.info>
6682
6683 * term.c (Fsuspend_tty, Fresume_tty):
6684 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6685 * window.c (temp_output_buffer_show):
6686 * insdel.c (signal_before_change):
6687 * frame.c (Fhandle_switch_frame):
6688 * fileio.c (Fdo_auto_save):
6689 * emacs.c (Fkill_emacs):
6690 * editfns.c (save_excursion_restore):
6691 * cmds.c (internal_self_insert):
6692 * callint.c (Fcall_interactively):
6693 * buffer.c (Fkill_all_local_variables):
6694 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6695 Use Frun_hooks.
6696 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6697 unconditionnaly since it does the check itself.
6698
6699 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6700
6701 Fix more problems found by GCC 4.5.2's static checks.
6702
6703 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6704 the first time through the loop, since we know p0 < p1 then.
6705 This also avoids a gcc -Wstrict-overflow warning.
6706
6707 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6708 leading to a memory leak, possible in functions like
6709 load_charset_map_from_file that can allocate an unbounded number
6710 of objects (Bug#8318).
6711
6712 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6713 that could (at least in theory) be that large.
6714
6715 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6716 This is less likely to overflow, and avoids undefined behavior if
6717 overflow does occur. All callers changed. Use strtoul to scan
6718 for the unsigned long integer.
6719 (pint2hrstr): Simplify and tune code slightly.
6720 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6721
6722 * scroll.c (do_scrolling): Work around GCC bug 48228.
6723 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6724
6725 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6726 This also avoids a warning with gcc -Wstrict-overflow.
6727 (validate_x_resource_name): Simplify count usage.
6728 This also avoids a warning with gcc -Wstrict-overflow.
6729
6730 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6731 fail (Bug#8306).
6732
6733 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6734
6735 * process.c (Fmake_network_process): Use socklen_t, not int,
6736 where POSIX says socklen_t is required in portable programs.
6737 This fixes a porting bug on hosts like 64-bit HP-UX, where
6738 socklen_t is wider than int (Bug#8277).
6739 (Fmake_network_process, server_accept_connection):
6740 (wait_reading_process_output, read_process_output):
6741 Likewise.
6742
6743 * process.c: Rename or move locals to avoid shadowing.
6744 (list_processes_1, Fmake_network_process):
6745 (read_process_output_error_handler, exec_sentinel_error_handler):
6746 Rename or move locals.
6747 (Fmake_network_process): Define label "retry_connect" only if needed.
6748 (Fnetwork_interface_info): Fix pointer signedness.
6749 (process_send_signal): Add cast to avoid pointer signedness problem.
6750 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6751 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6752
6753 Make tparam.h and terminfo.c consistent.
6754 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6755 Include tparam.h instead, since it declares them.
6756 * cm.h (PC): Remove extern decl; tparam.h now does this.
6757 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6758 * terminfo.c: Include tparam.h, to check interfaces.
6759 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6760 (tparam): Adjust signature to match interface in tparam.h;
6761 this removes some undefined behavior. Check that outstring and len
6762 are zero, which they always are with Emacs.
6763 * tparam.h (PC, BC, UP): New extern decls.
6764
6765 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6766 (xftfont_open): Rename locals to avoid shadowing.
6767
6768 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6769 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6770 (OTF_TAG_SYM): Omit macro if not needed.
6771 (ftfont_list): Remove unused local.
6772 (get_adstyle_property, ftfont_pattern_entity):
6773 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6774 Rename locals to avoid shadowing.
6775
6776 * xfont.c (xfont_list_family): Mark var as initialized.
6777
6778 * xml.c (make_dom): Now static.
6779
6780 * composite.c (composition_compute_stop_pos): Rename local to
6781 avoid shadowing.
6782 (composition_reseat_it): Remove unused locals.
6783 (find_automatic_composition, composition_adjust_point): Likewise.
6784 (composition_update_it): Mark var as initialized.
6785 (find_automatic_composition): Mark vars as initialized,
6786 with a FIXME (Bug#8290).
6787
6788 character.h: Rename locals to avoid shadowing.
6789 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6790 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6791 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6792 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6793 to avoid shadowing.
6794
6795 * textprop.c (property_change_between_p): Remove; unused.
6796
6797 * intervals.c (interval_start_pos): Now static.
6798
6799 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6800
6801 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6802 Rename locals to avoid shadowing.
6803
6804 * sound.c (wav_play, au_play, Fplay_sound_internal):
6805 Fix pointer signedness.
6806 (alsa_choose_format): Remove unused local var.
6807 (wav_play): Initialize a variable to 0, to prevent undefined
6808 behavior (Bug#8278).
6809
6810 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6811
6812 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6813
6814 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6815 clobbering (Bug#8298).
6816 * sysdep.c (sys_subshell): Likewise.
6817 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6818
6819 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6820 This should get cleaned up, so that child_setup has the
6821 same signature on all platforms.
6822
6823 * callproc.c (call_process_cleanup): Now static.
6824 (relocate_fd): Rename locals to avoid shadowing.
6825
6826 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6827
6828 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6829 not to be necessary, and produces flickering.
6830
6831 2011-03-20 Glenn Morris <rgm@gnu.org>
6832
6833 * config.in: Remove file.
6834
6835 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6836
6837 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6838 are now in src/globals.h.
6839 (syms_of_minibuf): Remove spurious & from previous change.
6840
6841 2011-03-20 Leo <sdl.web@gmail.com>
6842
6843 * minibuf.c (completing-read-function): New variable.
6844 (completing-read-default): Rename from completing-read.
6845 (completing-read): Call completing-read-function.
6846
6847 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6848
6849 * xfaces.c (Fx_load_color_file):
6850 Read color file from absolute filename (bug#8250).
6851
6852 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6853
6854 * makefile.w32-in: Update dependencies.
6855
6856 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6857
6858 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6859
6860 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6861
6862 Fix more problems found by GCC 4.5.2's static checks.
6863
6864 * process.c (make_serial_process_unwind, send_process_trap):
6865 (sigchld_handler): Now static.
6866
6867 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6868 That way, the code declares only the vars that it needs.
6869 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6870 * s/cygwin.h (PTY_ITERATION): Likewise.
6871 * s/darwin.h (PTY_ITERATION): Likewise.
6872 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6873
6874 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6875 * process.c (allocate_pty): Don't declare stb unless it's needed.
6876
6877 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6878 (CONSTANTLIM): Remove; unused.
6879 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6880 Define only if needed.
6881
6882 * unexelf.c (unexec): Name an expression,
6883 to avoid gcc -Wbad-function-cast warning.
6884 Use a different way to cause a compilation error if anyone uses
6885 n rather than nn, a way that does not involve shadowing.
6886 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6887
6888 * deps.mk (unexalpha.o): Remove; unused.
6889
6890 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6891 * unexec.h: New file.
6892 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6893 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6894 Depend on unexec.h.
6895 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6896 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6897 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6898 Change as necessary to match prototype in unexec.h.
6899
6900 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6901 shadowing.
6902 (back_comment, skip_chars): Mark vars as initialized.
6903
6904 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6905 Rename locals to avoid shadowing.
6906
6907 * lread.c (read1): Rewrite so as not to use empty "else".
6908 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6909
6910 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6911
6912 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6913 warning when compiling print.c.
6914
6915 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6916 instead of using an uninitialized var.
6917 (font_sort_entities): Mark var as initialized.
6918
6919 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6920
6921 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6922 pointers to constants.
6923 (font_parse_fcname): Remove unused vars.
6924 (font_delete_unmatched): Now static.
6925 (font_get_spec): Remove; unused.
6926 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6927 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6928 Rename or move locals to avoid shadowing.
6929
6930 * fns.c (require_nesting_list, require_unwind): Now static.
6931 (Ffillarray): Rename locals to avoid shadowing.
6932
6933 * floatfns.c (domain_error2): Define only if needed.
6934 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6935
6936 * alloc.c (mark_backtrace): Move decl from here ...
6937 * lisp.h: ... to here, so that it can be checked.
6938
6939 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6940 (Fdefvar): Rewrite so as not to use empty "else".
6941 (lisp_indirect_variable): Name an expression,
6942 to avoid gcc -Wbad-function-cast warning.
6943 (Fdefvar): Rename locals to avoid shadowing.
6944
6945 * callint.c (quotify_arg, quotify_args): Now static.
6946 (Fcall_interactively): Rename locals to avoid shadowing.
6947 Use const pointer when appropriate.
6948
6949 * lisp.h (get_system_name, get_operating_system_release):
6950 Move decls here, to check interfaces.
6951 * process.c (get_operating_system_release): Move decl to lisp.h.
6952 * xrdb.c (get_system_name): Likewise.
6953 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6954 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6955 some of which prompt warnings from gcc -Wbad-function-cast.
6956 (Fformat_time_string, Fencode_time, Finsert_char):
6957 (Ftranslate_region_internal, Fformat):
6958 Rename or remove local vars to avoid shadowing.
6959 (Ftranslate_region_internal): Mark var as initialized.
6960
6961 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6962 avoid shadowing.
6963
6964 * lisp.h (eassert): Check that the argument compiles, even if
6965 ENABLE_CHECKING is not defined.
6966
6967 * data.c (Findirect_variable): Name an expression, to avoid
6968 gcc -Wbad-function-cast warning.
6969 (default_value, arithcompare, arith_driver, arith_error): Now static.
6970 (store_symval_forwarding): Rename local to avoid shadowing.
6971 (Fmake_variable_buffer_local, Fmake_local_variable):
6972 Mark variables as initialized.
6973 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6974
6975 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6976 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6977 Rename locals to avoid shadowing.
6978 (mark_stack): Move local variables into the #ifdef region where
6979 they're used.
6980 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6981 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6982 needed otherwise.
6983 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6984 (GC_STRING_CHARS): Remove; not used.
6985 (Fmemory_limit): Cast sbrk's returned value to char *.
6986
6987 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6988 avoids undefined behavior in theory.
6989
6990 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6991
6992 Use functions, not macros, for up- and down-casing (Bug#8254).
6993 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6994 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6995 to use the following functions instead of these macros.
6996 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6997 EMACS_INT, since callers assume the returned value fits in int.
6998 (upcase1): Likewise, for UPCASE_TABLE.
6999 (uppercasep, lowercasep, upcase): New static inline functions.
7000 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7001 the race-condition problem in the old DOWNCASE.
7002
7003 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7004 Rename locals to avoid shadowing.
7005 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7006 (regex_compile, re_search_2, re_match_2_internal):
7007 Remove unused local vars.
7008 (FREE_VAR): Rewrite so as not to use empty "else",
7009 which gcc can warn about.
7010 (regex_compile, re_match_2_internal): Mark locals as initialized.
7011 (RETALLOC_IF): Define only if needed.
7012 (WORDCHAR_P): Likewise. This one is never needed, but is used
7013 only in a comment talking about a compiler bug, so put inside
7014 the #if 0 of that comment.
7015 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7016 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7017 Remove; unused.
7018
7019 * search.c (boyer_moore): Rename locals to avoid shadowing.
7020 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7021 (PREV_CHAR_BOUNDARY): Likewise.
7022
7023 * search.c (simple_search): Remove unused var.
7024
7025 * dired.c (compile_pattern): Move decl from here ...
7026 * lisp.h: ... to here, so that it can be checked.
7027 (struct re_registers): New forward decl.
7028
7029 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7030
7031 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7032 All uses changed.
7033 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7034 Rename locals to avoid shadowing.
7035 (Fvertical_motion): Mark locals as initialized.
7036
7037 * casefiddle.c (casify_object, casify_region): Now static.
7038 (casify_region): Mark local as initialized.
7039
7040 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7041
7042 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7043 New macros, so that the caller can use some names other than
7044 gcpro1, gcpro2, etc.
7045 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7046 of the new macros.
7047 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7048 argument, for consistency with GCPRO2_VAR, etc: it is now the
7049 prefix of the variable, not the variable itself. All uses
7050 changed.
7051 * dired.c (directory_files_internal, file_name_completion):
7052 Rename locals to avoid shadowing.
7053
7054 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7055 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7056 dired.c's scmp function, had undefined behavior.
7057 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7058 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7059 * buffer.h: ... to here, because these macros use current_buffer,
7060 and the new implementation with inline functions needs to have
7061 current_buffer in scope now, rather than later when the macros
7062 are used.
7063 (downcase, upcase1): New static inline functions.
7064 (DOWNCASE, UPCASE1): Reimplement using these functions.
7065 This avoids undefined behavior in expressions like
7066 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7067 from race conditions in accessing the global variables
7068 case_temp1 and case_temp2.
7069 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7070 * lisp.h (case_temp1, case_temp2): Remove their decls.
7071 * character.h (ASCII_CHAR_P): Move from here ...
7072 * lisp.h: ... to here, so that the inline functions mentioned
7073 above can use them.
7074
7075 * dired.c (directory_files_internal_unwind): Now static.
7076
7077 * fileio.c (file_name_as_directory, directory_file_name):
7078 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7079 Now static.
7080 (file_name_as_directory): Use const pointers when appropriate.
7081 (Fexpand_file_name): Likewise. In particular, newdir might
7082 point at constant storage, so make it a const pointer.
7083 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7084 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7085 signedness issues.
7086 (Fset_file_times, Finsert_file_contents, auto_save_error):
7087 Rename locals to avoid shadowing.
7088
7089 * minibuf.c (choose_minibuf_frame_1): Now static.
7090 (Ftry_completion, Fall_completions): Rename or remove locals
7091 to avoid shadowing.
7092
7093 * marker.c (bytepos_to_charpos): Remove; unused.
7094
7095 * lisp.h (verify_bytepos, count_markers): New decls,
7096 so that gcc does not warn that these functions aren't declared.
7097
7098 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7099 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7100 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7101 (copy_text): Remove unused local var.
7102
7103 * filelock.c (within_one_second): Now static.
7104 (lock_file_1): Rename local to avoid shadowing.
7105
7106 * buffer.c (fix_overlays_before): Mark locals as initialized.
7107 (fix_start_end_in_overlays): Likewise. This function should be
7108 simplified by using pointers-to-pointers, but that's a different
7109 matter.
7110 (switch_to_buffer_1): Now static.
7111 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7112 (report_overlay_modification): Rename locals to avoid shadowing.
7113
7114 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7115 Fix pointer signedness issue.
7116 (sys_subshell): Mark local as volatile if checking for lint,
7117 to suppress a gcc -Wclobbered warning that does not seem to be right.
7118 (MAXPATHLEN): Define only if needed.
7119
7120 * process.c (serial_open, serial_configure): Move decls from here ...
7121 * systty.h: ... to here, so that they can be checked.
7122
7123 * fns.c (get_random, seed_random): Move extern decls from here ...
7124 * lisp.h: ... to here, so that they can be checked.
7125
7126 * sysdep.c (reset_io): Now static.
7127 (wait_for_termination_signal): Remove; unused.
7128
7129 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7130 (copy_keymap_item, append_key, push_text_char_description):
7131 Now static.
7132 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7133 (DENSE_TABLE_SIZE): Remove; unused.
7134 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7135 (describe_map_tree):
7136 Rename locals to avoid shadowing.
7137
7138 * keyboard.c: Declare functions static if they are not used elsewhere.
7139 (echo_char, echo_dash, cmd_error, top_level_2):
7140 (poll_for_input, handle_async_input): Now static.
7141 (read_char, kbd_buffer_get_event, make_lispy_position):
7142 (make_lispy_event, make_lispy_movement, apply_modifiers):
7143 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7144 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7145 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7146 (read_key_sequence, read_char): Mark locals as initialized.
7147 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7148
7149 * keyboard.h (make_ctrl_char): New decl.
7150 (mark_kboards): Move decl here ...
7151 * alloc.c (mark_kboards): ... from here.
7152
7153 * lisp.h (force_auto_save_soon): New decl.
7154
7155 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7156 (DEFINE_DUMMY_FUNCTION): New macro.
7157 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7158 Use it.
7159 (main): Add casts to avoid warnings
7160 if GCC considers string literals to be constants.
7161
7162 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7163
7164 * dbusbind.c: Pointer signedness fixes.
7165 (xd_signature, xd_append_arg, xd_initialize):
7166 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7167 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7168 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7169 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7170
7171 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7172 if GCC considers string literals to be constants.
7173 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7174
7175 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7176
7177 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7178 (print_preprocess, print_object): New macro to fix last change.
7179
7180 * print.c (print_preprocess): Don't forget font objects.
7181
7182 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7183
7184 * emacs.c (USAGE3): Doc fixes.
7185
7186 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7187
7188 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7189 structure.
7190
7191 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7192
7193 * lisp.h (VWindow_system, Qfile_name_history):
7194 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7195 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7196 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7197
7198 * w32select.c: Don't #include "keyboard.h".
7199 (run_protected): Add extern declaration for waiting_for_input.
7200
7201 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7202 * w32console.c (detect_input_pending, read_input_pending)
7203 (encode_terminal_code):
7204 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7205 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7206 (w32_system_caret_y, Qfile_name_history):
7207 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7208 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7209 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7210 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7211 * w32proc.c (Qlocal, report_file_error):
7212 * w32term.c (Vwindow_system, updating_frame):
7213 * w32uniscribe.c (initialized, uniscribe_font_driver):
7214 Remove unneeded extern declarations.
7215
7216 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7217
7218 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7219
7220 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7221
7222 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7223 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7224 These macros can no longer be used for assignment.
7225
7226 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7227 Assign struct members directly, instead of using BUF_BEGV etc.
7228 (record_buffer_markers, fetch_buffer_markers): New functions for
7229 recording and fetching special buffer markers.
7230 (set_buffer_internal_1, set_buffer_temp): Use them.
7231
7232 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7233
7234 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7235
7236 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7237 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7238
7239 * xdisp.c (hscroll_window_tree):
7240 (reconsider_clip_changes): Use PT instead of BUF_PT.
7241
7242 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7243
7244 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7245 $(EMACS_ROOT)/lib/intprops.h.
7246
7247 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7248
7249 Fix more problems found by GCC 4.5.2's static checks.
7250
7251 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7252 to unsigned char * to avoid compiler diagnostic.
7253 (xg_free_frame_widgets): Make it clear that a local variable is
7254 needed only if USE_GTK_TOOLTIP.
7255 (gdk_window_get_screen): Make it clear that this macro is needed
7256 only if USE_GTK_TOOLTIP.
7257 (int_gtk_range_get_value): New function, which avoids a diagnostic
7258 from gcc -Wbad-function-cast.
7259 (xg_set_toolkit_scroll_bar_thumb): Use it.
7260 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7261 diagnostic from gcc -Wbad-function-cast.
7262 (get_utf8_string, xg_get_file_with_chooser):
7263 Rename locals to avoid shadowing.
7264 (create_dialog): Move locals to avoid shadowing.
7265
7266 * xgselect.c (xg_select): Remove unused var.
7267
7268 * image.c (four_corners_best): Mark locals as initialized.
7269 (gif_load): Initialize transparent_p to zero (Bug#8238).
7270 Mark another local as initialized.
7271 (my_png_error, my_error_exit): Mark with NO_RETURN.
7272
7273 * image.c (clear_image_cache): Now static.
7274 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7275 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7276 (x_edge_detection): Remove unnecessary cast that
7277 gcc -Wbad-function-cast diagnoses.
7278 (gif_load): Fix pointer signedness.
7279 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7280 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7281
7282 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7283
7284 Improve quality of tests for time stamp overflow.
7285 For example, without this patch (encode-time 0 0 0 1 1
7286 1152921504606846976) returns the obviously-bogus value (-948597
7287 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7288 reports time overflow. See
7289 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7290 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7291 * editfns.c: Include limits.h and intprops.h.
7292 (TIME_T_MIN, TIME_T_MAX): New macros.
7293 (time_overflow): Move earlier, to before first use.
7294 (hi_time, lo_time): New functions, for an accurate test for
7295 out-of-range times.
7296 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7297 (Fget_internal_run_time): Don't assume time_t fits in int.
7298 (make_time): Use list2 instead of Fcons twice.
7299 (Fdecode_time): More accurate test for out-of-range times.
7300 (check_tm_member): New function.
7301 (Fencode_time): Use it, to test for out-of-range times.
7302 (lisp_time_argument): Don't rely on undefined left-shift and
7303 right-shift behavior when checking for time stamp overflow.
7304
7305 * editfns.c (time_overflow): New function, refactoring common code.
7306 (Fformat_time_string, Fdecode_time, Fencode_time):
7307 (Fcurrent_time_string): Use it.
7308
7309 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7310 * dired.c (make_time): Move to ...
7311 * editfns.c (make_time): ... here.
7312 * systime.h: Note the move.
7313
7314 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7315
7316 * fringe.c (update_window_fringes): Remove unused variables.
7317
7318 * unexmacosx.c (copy_data_segment): Also copy __got section.
7319 (Bug#8223)
7320
7321 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7322
7323 * termcap.c [MSDOS]: Include "msdos.h".
7324 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7325 Constify `char *' arguments and their references according to
7326 prototypes in tparam.h.
7327
7328 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7329
7330 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7331 Adapt all references accordingly.
7332
7333 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7334
7335 2011-03-11 Tom Tromey <tromey@redhat.com>
7336
7337 * buffer.c (syms_of_buffer): Remove obsolete comment.
7338
7339 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7340
7341 * termhooks.h (encode_terminal_code): Declare prototype.
7342
7343 * msdos.c (encode_terminal_code): Don't declare prototype.
7344
7345 * term.c (encode_terminal_code): Now external again, used by
7346 w32console.c and msdos.c.
7347
7348 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7349 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7350
7351 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7352
7353 Fix some minor problems found by GCC 4.5.2's static checks.
7354
7355 * fringe.c (update_window_fringes): Mark locals as initialized
7356 (Bug#8227).
7357 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7358
7359 * alloc.c (mark_fringe_data): Move decl from here ...
7360 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7361 to check its interface.
7362 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7363
7364 * fontset.c (free_realized_fontset): Now static.
7365 (Fset_fontset_font): Rename local to avoid shadowing.
7366 (fontset_font): Mark local as initialized.
7367 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7368
7369 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7370
7371 * xselect.c (x_disown_buffer_selections): Remove; not used.
7372 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7373 (x_own_selection, Fx_disown_selection_internal): Rename locals
7374 to avoid shadowing.
7375 (x_handle_dnd_message): Remove local to avoid shadowing.
7376
7377 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7378 so that the caller can use some name other than gcpro1.
7379 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7380 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7381 (Fx_backspace_delete_keys_p):
7382 Use them to avoid shadowing, and rename vars to avoid shadowing.
7383 (x_decode_color, x_set_name, x_window): Now static.
7384 (Fx_create_frame): Add braces to silence GCC warning.
7385 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7386 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7387 Remove unused locals.
7388 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7389 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7390 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7391 macros.
7392
7393 * xterm.h (x_mouse_leave): New decl.
7394
7395 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7396 Remove unused functions.
7397 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7398 (x_calc_absolute_position): Now static.
7399 (XTread_socket): Don't define label "out" unless it's used.
7400 Don't declare local "event" unless it's used.
7401 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7402 unless they are used.
7403 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7404 (x_fatal_error_signal): Remove; not used.
7405 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7406 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7407 (x_error_catcher, x_connection_closed, x_error_handler):
7408 (x_error_quitter, xembed_send_message, x_iconify_frame):
7409 (my_log_handler): Rename locals to avoid shadowing.
7410 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7411 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7412
7413 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7414 Rename or move locals to avoid shadowing.
7415 (tty_defined_color, merge_face_heights): Now static.
7416 (free_realized_faces_for_fontset): Remove; not used.
7417 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7418 does not deduce is never used uninitialized.
7419 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7420 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7421
7422 * terminal.c (store_terminal_param): Now static.
7423
7424 * xmenu.c (menu_highlight_callback): Now static.
7425 (set_frame_menubar): Remove unused local.
7426 (xmenu_show): Rename parameter to avoid shadowing.
7427 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7428 since they might point to immutable storage.
7429 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7430 since it's unused otherwise.
7431
7432 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7433 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7434 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7435 avoids a gcc -Wuninitialized diagnostic.
7436 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7437 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7438 does not deduce are never used uninitialized.
7439
7440 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7441
7442 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7443 * window.c (window_loop, size_window):
7444 (run_window_configuration_change_hook, enlarge_window): Likewise.
7445
7446 * window.c (display_buffer): Now static.
7447 (size_window): Mark variables that gcc -Wuninitialized
7448 does not deduce are never used uninitialized.
7449 * window.h (check_all_windows): New decl, to forestall
7450 gcc -Wmissing-prototypes diagnostic.
7451 * dispextern.h (bidi_dump_cached_states): Likewise.
7452
7453 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7454 shadowing.
7455 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7456 Include <limits.h>.
7457 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7458 and to avoid gcc -Wuninitialized warning.
7459 (load_charset_map): Mark variables that gcc -Wuninitialized
7460 does not deduce are never used uninitialized.
7461 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7462
7463 * coding.c (coding_set_source, coding_set_destination):
7464 Use "else { /* comment */ }" rather than "else /* comment */;"
7465 for clarity, and to avoid gcc -Wempty-body warning.
7466 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7467 a block, when the outer 'i' will do.
7468 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7469 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7470 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7471 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7472 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7473 Rename locals to avoid shadowing.
7474 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7475 * coding.c (emacs_mule_char, encode_invocation_designation):
7476 Now static, since they're not used elsewhere.
7477 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7478 (decode_coding_object, encode_coding_object, detect_coding_system):
7479 (decode_coding_emacs_mule): Mark variables that gcc
7480 -Wuninitialized does not deduce are never used uninitialized.
7481 (detect_coding_iso_2022): Initialize a local variable that might
7482 be used uninitialized. Leave a FIXME because it's not clear that
7483 this initialization is needed. (Bug#8211)
7484 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7485 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7486 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7487 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7488 Remove unused macros.
7489
7490 * category.c (hash_get_category_set): Remove unused local var.
7491 (copy_category_table): Now static, since it's not used elsewhere.
7492 * character.c (string_count_byte8): Likewise.
7493
7494 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7495 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7496
7497 * chartab.c (copy_sub_char_table): Now static, since it's not used
7498 elsewhere.
7499 (sub_char_table_ref_and_range, char_table_ref_and_range):
7500 Rename locals to avoid shadowing.
7501 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7502
7503 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7504 (BIDI_BOB): Remove unused macro.
7505
7506 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7507 deduce are never used uninitialized.
7508 * term.c (encode_terminal_code): Likewise.
7509
7510 * term.c (encode_terminal_code): Now static. Remove unused local.
7511
7512 * tparam.h: New file.
7513 * term.c, tparam.h: Include it.
7514 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7515 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7516 Move these decls to tparam.h, and make them agree with what
7517 is actually in tparam.c. The previous trick of using incompatible
7518 decls in different modules does not conform to the C standard.
7519 All callers of tparam changed to use tparam's actual API.
7520 * tparam.c (tparam1, tparam, tgoto):
7521 Use const pointers where appropriate.
7522
7523 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7524 * cm.h (struct cm): Likewise.
7525 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7526 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7527 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7528 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7529 (turn_on_face, init_tty): Likewise.
7530 * termchar.h (struct tty_display_info): Likewise.
7531
7532 * term.c (term_mouse_position): Rename local to avoid shadowing.
7533
7534 * alloc.c (mark_ttys): Move decl from here ...
7535 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7536
7537 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7538
7539 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7540
7541 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7542
7543 * search.c (compile_pattern_1): Remove argument regp, unused since
7544 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7545 (compile_pattern): Don't pass it.
7546
7547 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7548
7549 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7550 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7551 for ! HAVE_GTK3.
7552 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7553
7554 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7555
7556 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7557 gdk_window_get_screen, gdk_window_get_geometry,
7558 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7559 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7560 (xg_get_pixbuf_from_pixmap): New function.
7561 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7562 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7563 Call xg_get_pixbuf_from_pixmap instead of
7564 gdk_pixbuf_get_from_drawable.
7565 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7566 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7567 (xg_check_special_colors): Use GtkStyleContext and its functions
7568 for HAVE_GTK3.
7569 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7570 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7571 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7572 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7573 Call gtk_widget_get_preferred_size.
7574 (xg_frame_resized): gdk_window_get_geometry only takes 5
7575 parameters.
7576 (xg_win_to_widget, xg_event_is_for_menubar):
7577 Call gdk_x11_window_lookup_for_display.
7578 (xg_set_widget_bg): New function.
7579 (delete_cb): New function.
7580 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7581 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7582 (xg_set_background_color): Call xg_set_widget_bg.
7583 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7584 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7585 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7586 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7587 if ! HAVE_GTK3.
7588 (update_frame_tool_bar): Call gtk_widget_hide.
7589 (xg_initialize): Use GDK_KEY_g.
7590
7591 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7592 if ! HAVE_GTK3
7593 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7594
7595 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7596 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7597 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7598
7599 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7600
7601 * w32xfns.c (select_palette): Check success of RealizePalette against
7602 GDI_ERROR, not zero.
7603
7604 See ChangeLog.11 for earlier changes.
7605
7606 ;; Local Variables:
7607 ;; coding: utf-8
7608 ;; End:
7609
7610 Copyright (C) 2011 Free Software Foundation, Inc.
7611
7612 This file is part of GNU Emacs.
7613
7614 GNU Emacs is free software: you can redistribute it and/or modify
7615 it under the terms of the GNU General Public License as published by
7616 the Free Software Foundation, either version 3 of the License, or
7617 (at your option) any later version.
7618
7619 GNU Emacs is distributed in the hope that it will be useful,
7620 but WITHOUT ANY WARRANTY; without even the implied warranty of
7621 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7622 GNU General Public License for more details.
7623
7624 You should have received a copy of the GNU General Public License
7625 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.