* fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2
3 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4 This is more efficient than Ffile_directory_p and avoids a minor race.
5
6 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7
8 * buffer.c (Foverlay_put): Say what the return value is
9 (bug#7835).
10
11 * fileio.c (barf_or_query_if_file_exists): Check first if the file
12 is a directory before asking whether to use the file name
13 (bug#7564).
14 (barf_or_query_if_file_exists): Make the "File is a directory"
15 error be more correct.
16
17 * fns.c (Frequire): Remove the mention of the .gz files, since
18 that's installation-specific, but keep the mention of
19 `get-load-suffixes'.
20
21 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
22
23 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
24 Report string overflow if the output is too long.
25
26 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
27
28 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
29 (syms_of_gnutls): Remove duplicate DEFSYM for
30 Qgnutls_bootprop_verify_hostname_error, an error for
31 Qgnutls_bootprop_verify_error (which is no longer used).
32
33 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
34 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
35 Also (re)move comments that are misplaced or no longer relevant.
36
37 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
38
39 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
40
41 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
42
43 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
44 and background color parameters if they have been changed.
45
46 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
47
48 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
49
50 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
51
52 * xsettings.c (SYSTEM_FONT): Define only when used.
53 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
54
55 * keymap.c (access_keymap_1): Now static.
56
57 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
58
59 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
60 leave any prefix arg for the up event (Bug#1586).
61
62 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
63
64 * lread.c (syms_of_lread): Mention single symbols defined by
65 `defvar' or `defconst' (bug#7154).
66
67 * fns.c (Frequire): Mention .el.gz files (bug#7314).
68 (Frequire): Mention get-load-suffixes.
69
70 2011-07-02 Martin Rudalics <rudalics@gmx.at>
71
72 * window.h (window): Remove clone_number slot.
73 * window.c (Fwindow_clone_number, Fset_window_clone_number):
74 Remove.
75 (make_parent_window, make_window, saved_window)
76 (Fset_window_configuration, save_window_save): Don't deal with
77 clone numbers.
78 * buffer.c (Qclone_number): Remove declaration.
79 (sort_overlays, overlay_strings): Don't deal with clone numbers.
80
81 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
82
83 Add multiple inheritance to keymaps.
84 * keymap.c (Fmake_composed_keymap): New function.
85 (Fset_keymap_parent): Simplify.
86 (fix_submap_inheritance): Remove.
87 (access_keymap_1): New function extracted from access_keymap to handle
88 embedded parents and handle lists of maps.
89 (access_keymap): Use it.
90 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
91 (Fcopy_keymap): Handle embedded parents.
92 (Fcommand_remapping, define_as_prefix): Simplify.
93 (Fkey_binding): Simplify.
94 (syms_of_keymap): Move minibuffer-local-completion-map,
95 minibuffer-local-filename-completion-map,
96 minibuffer-local-must-match-map, and
97 minibuffer-local-filename-must-match-map to Elisp.
98 (syms_of_keymap): Defsubr make-composed-keymap.
99 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
100 (parse_menu_item): Trivial simplification.
101
102 2011-07-01 Glenn Morris <rgm@gnu.org>
103
104 * Makefile.in (SETTINGS_LIBS): Fix typo.
105
106 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
107
108 * coding.c (Fencode_coding_string): Record the last coding system
109 used, as the function doc string says (bug#8738).
110
111 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
112
113 * xsettings.c (store_monospaced_changed): Take new font as arg and
114 check for change against current_mono_font.
115 (EMACS_TYPE_SETTINGS): Remove this and related defines.
116 (emacs_settings_constructor, emacs_settings_get_property)
117 (emacs_settings_set_property, emacs_settings_class_init)
118 (emacs_settings_init, gsettings_obj): Remove.
119 (something_changedCB): New function for HAVE_GSETTINGS.
120 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
121 with value as argument.
122 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
123 g_settings_new (Bug#8967). Do not create gsettings_obj.
124 Remove calls to g_settings_bind. Connect something_changedCB to
125 "changed".
126
127 * xgselect.c: Add defined (HAVE_GSETTINGS).
128 (xgselect_initialize): Ditto.
129
130 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
131 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
132 xg_select.
133
134 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
135
136 * eval.c (struct backtrace): Simplify and port the data structure.
137 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
138 signed bit field, as this assumption is not portable and it makes
139 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
140 "char debug_on_exit : 1" as this is not portable either; instead,
141 use the portable "unsigned int debug_on_exit : 1". Remove unused
142 member evalargs. Remove obsolete comments about cc bombing out.
143
144 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
145
146 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
147 Let HAVE_GSETTINGS override HAVE_GCONF.
148 (store_monospaced_changed): New function.
149 (EMACS_SETTINGS): A new type derived from GObject to handle
150 GSettings notifications.
151 (emacs_settings_constructor, emacs_settings_get_property)
152 (emacs_settings_set_property, emacs_settings_class_init):
153 New functions.
154 (gsettings_client, gsettings_obj): New variables.
155 (GSETTINGS_SCHEMA): New define.
156 (something_changedCB): Call store_monospaced_changed.
157 (init_gsettings): New function.
158 (xsettings_initialize): Call init_gsettings.
159 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
160 to NULL.
161
162 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
163 GCONF_CFLAGS/LIBS.
164
165 2011-06-29 Martin Rudalics <rudalics@gmx.at>
166
167 * window.c (resize_root_window, grow_mini_window)
168 (shrink_mini_window): Rename Qresize_root_window to
169 Qwindow_resize_root_window and Qresize_root_window_vertically to
170 Qwindow_resize_root_window_vertically.
171
172 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
173
174 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
175
176 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
177
178 * makefile.w32-in: Redesign dependencies so they reflect more
179 clearly which files are directly included by each source file,
180 and not through other includes.
181
182 2011-06-27 Martin Rudalics <rudalics@gmx.at>
183
184 * buffer.c (Qclone_number): Declare static and DEFSYM it.
185 (sort_overlays, overlay_strings): When an overlay's clone number
186 matches the window's clone number process the overlay even if
187 the overlay's window property doesn't match the current window.
188
189 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
190 (Fwindow_hchild): Rename to Fwindow_left_child.
191 (Fwindow_next): Rename to Fwindow_next_sibling.
192 (Fwindow_prev): Rename to Fwindow_prev_sibling.
193 (resize_window_check): Rename to window_resize_check.
194 (resize_window_apply): Rename to window_resize_apply.
195 (Fresize_window_apply): Rename to Fwindow_resize_apply.
196 (Fdelete_other_windows_internal, resize_frame_windows)
197 (Fsplit_window_internal, Fdelete_window_internal)
198 (grow_mini_window, shrink_mini_window)
199 (Fresize_mini_window_internal): Fix callers accordingly.
200
201 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
202
203 * emacsgtkfixed.h: State that this is only used with Gtk+3.
204 (emacs_fixed_set_min_size): Remove.
205 (emacs_fixed_new): Take frame as argument.
206
207 * emacsgtkfixed.c: State that this is only used with Gtk+3.
208 (_EmacsFixedPrivate): Remove minwidth/height.
209 Add struct frame *f.
210 (emacs_fixed_init): Initialize priv->f.
211 (get_parent_class, emacs_fixed_set_min_size): Remove.
212 (emacs_fixed_new): Set priv->f to argument.
213 (emacs_fixed_get_preferred_width)
214 (emacs_fixed_get_preferred_height): Use min_width/height from
215 frames size_hint to set minimum and natural (Bug#8919).
216 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
217 and use min_width/height from frames size_hint to set
218 min_width/height (Bug#8919).
219
220 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
221 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. Fix
222 indentation.
223
224 2011-06-26 Eli Zaretskii <eliz@gnu.org>
225
226 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
227 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
228 called at ZV.
229
230 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
231
232 * process.c (wait_reading_process_output): Bypass select if
233 waiting for a cell while ignoring keyboard input, and input is
234 pending. Suggested by Jan Djärv (Bug#8869).
235
236 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
237
238 Use gnulib's dup2 module instead of rolling our own.
239 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
240
241 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
242
243 * dispnew.c (scrolling_window): Before scrolling, turn off a
244 mouse-highlight in the window being scrolled.
245
246 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
247
248 Move DEFSYM to lisp.h and use everywhere.
249
250 * character.h (DEFSYM): Move declaration...
251 * lisp.h (DEFSYM): ...here.
252
253 * gnutls.c:
254 * minibuf.c:
255 * w32menu.c:
256 * w32proc.c:
257 * w32select.c: Don't include character.h.
258
259 * alloc.c (syms_of_alloc):
260 * buffer.c (syms_of_buffer):
261 * bytecode.c (syms_of_bytecode):
262 * callint.c (syms_of_callint):
263 * casefiddle.c (syms_of_casefiddle):
264 * casetab.c (init_casetab_once):
265 * category.c (init_category_once, syms_of_category):
266 * ccl.c (syms_of_ccl):
267 * cmds.c (syms_of_cmds):
268 * composite.c (syms_of_composite):
269 * dbusbind.c (syms_of_dbusbind):
270 * dired.c (syms_of_dired):
271 * dispnew.c (syms_of_display):
272 * doc.c (syms_of_doc):
273 * editfns.c (syms_of_editfns):
274 * emacs.c (syms_of_emacs):
275 * eval.c (syms_of_eval):
276 * fileio.c (syms_of_fileio):
277 * fns.c (syms_of_fns):
278 * frame.c (syms_of_frame):
279 * fringe.c (syms_of_fringe):
280 * insdel.c (syms_of_insdel):
281 * keymap.c (syms_of_keymap):
282 * lread.c (init_obarray, syms_of_lread):
283 * macros.c (syms_of_macros):
284 * msdos.c (syms_of_msdos):
285 * print.c (syms_of_print):
286 * process.c (syms_of_process):
287 * search.c (syms_of_search):
288 * sound.c (syms_of_sound):
289 * syntax.c (init_syntax_once, syms_of_syntax):
290 * terminal.c (syms_of_terminal):
291 * textprop.c (syms_of_textprop):
292 * undo.c (syms_of_undo):
293 * w32.c (globals_of_w32):
294 * window.c (syms_of_window):
295 * xdisp.c (syms_of_xdisp):
296 * xfaces.c (syms_of_xfaces):
297 * xfns.c (syms_of_xfns):
298 * xmenu.c (syms_of_xmenu):
299 * xsettings.c (syms_of_xsettings):
300 * xterm.c (syms_of_xterm): Use DEFSYM.
301
302 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
303
304 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
305
306 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
307
308 Integer and buffer overflow fixes (Bug#8873).
309
310 * print.c (printchar, strout): Check for string overflow.
311 (PRINTPREPARE, printchar, strout):
312 Don't set size unless allocation succeeds.
313
314 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
315 for sizes. Check for string overflow more accurately.
316 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
317
318 * macros.c: Integer and buffer overflow fixes.
319 * keyboard.h (struct keyboard.kbd_macro_bufsize):
320 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
321 Use ptrdiff_t, not int, for sizes.
322 Don't increment bufsize until after realloc succeeds.
323 Check for size-calculation overflow.
324 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
325
326 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
327
328 * lread.c: Integer overflow fixes.
329 (read_integer): Radix is now EMACS_INT, not int,
330 to improve quality of diagnostics for out-of-range radices.
331 Calculate buffer size correctly for out-of-range radices.
332 (read1): Check for integer overflow in radices, and in
333 read-circle numbers.
334 (read_escape): Avoid int overflow.
335 (Fload, openp, read_buffer_size, read1)
336 (substitute_object_recurse, read_vector, read_list, map_obarray):
337 Use ptrdiff_t, not int, for sizes.
338 (read1): Use EMACS_INT, not int, for sizes.
339 Check for size overflow.
340
341 * image.c (cache_image): Check for size arithmetic overflow.
342
343 * lread.c: Integer overflow issues.
344 (saved_doc_string_size, saved_doc_string_length)
345 (prev_saved_doc_string_size, prev_saved_doc_string_length):
346 Now ptrdiff_t, not int.
347 (read1): Don't assume doc string length fits in int. Check for
348 out-of-range doc string lengths.
349 (read_list): Don't assume file position fits in int.
350 (read_escape): Check for hex character overflow.
351
352 2011-06-22 Leo Liu <sdl.web@gmail.com>
353
354 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
355 Move to minibuffer.el.
356
357 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
358
359 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
360 The following patches are for when GLYPH_DEBUG && !XASSERT.
361 * dispextern.h (trace_redisplay_p, dump_glyph_string):
362 * dispnew.c (flush_stdout):
363 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
364 Mark as externally visible.
365 * dispnew.c (check_window_matrix_pointers): Now static.
366 * dispnew.c (window_to_frame_vpos):
367 * xfns.c (unwind_create_frame):
368 * xterm.c (x_check_font): Remove unused local.
369 * scroll.c (CHECK_BOUNDS):
370 * xfaces.c (cache_fache): Rename local to avoid shadowing.
371 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
372 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
373 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
374 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
375 Now static.
376 (debug_method_add): Use va_list and vsprintf rather than relying
377 on undefined behavior with wrong number of arguments.
378 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
379 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
380 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
381 since we're not interested in debugging glyphs with old libraries.
382 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
383 GCC 4.6.0's static checking.
384
385 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
386
387 Integer overflow and signedness fixes (Bug#8873).
388 A few related buffer overrun fixes, too.
389
390 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
391
392 * dispextern.h (struct face.stipple):
393 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
394 (x_bitmap_mask, x_allocate_bitmap_record)
395 (x_create_bitmap_from_data, x_create_bitmap_from_file)
396 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
397 (x_create_bitmap_from_xpm_data):
398 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
399 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
400 (.bitmaps_last):
401 * xfaces.c (load_pixmap):
402 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
403 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
404 (.bitmaps_last, struct x_output.icon_bitmap):
405 Use ptrdiff_t, not int, for bitmap indexes.
406 (x_allocate_bitmap_record): Check for size overflow.
407 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
408
409 Use ptrdiff_t, not int, for overlay counts.
410 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
411 * editfns.c (overlays_around, get_pos_property):
412 * textprop.c (get_char_property_and_overlay):
413 * xdisp.c (next_overlay_change, note_mouse_highlight):
414 * xfaces.c (face_at_buffer_position):
415 * buffer.c (OVERLAY_COUNT_MAX): New macro.
416 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
417 (Fnext_overlay_change, Fprevious_overlay_change)
418 (mouse_face_overlay_overlaps, Foverlays_in):
419 Use ptrdiff_t, not int, for sizes.
420 (overlays_at, overlays_in): Check for size-calculation overflow.
421
422 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
423
424 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
425 (x_session_initialize): Do not assume string length fits in int.
426
427 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
428 This is unlikely, but can occur if DPI is outlandish.
429
430 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
431 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
432
433 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
434 * xrdb.c (magic_file_p, search_magic_path):
435 Omit last arg SUFFIX; it was always 0. All callers changed.
436 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
437
438 * xfont.c (xfont_match): Avoid need for strlen.
439
440 * xfns.c: Don't assume strlen fits in int.
441 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
442
443 * xdisp.c (message_log_check_duplicate): Return intmax_t,
444 not unsigned long, as we prefer signed integers. All callers changed.
445 Detect integer overflow in repeat count.
446 (message_dolog): Don't assume print length fits in 39 bytes.
447 (display_mode_element): Don't assume strlen fits in int.
448
449 * termcap.c: Don't assume sizes fit in int and never overflow.
450 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
451 (gobble_line): Check for size-calculation overflow.
452
453 * minibuf.c (Fread_buffer):
454 * lread.c (intern, intern_c_string):
455 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
456 Don't assume string length fits in int.
457
458 * keyboard.c (parse_tool_bar_item):
459 * gtkutil.c (style_changed_cb): Avoid need for strlen.
460
461 * font.c: Don't assume string length fits in int.
462 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
463 Use ptrdiff_t, not int.
464 (font_intern_prop): Don't assume string length fits in int.
465 Don't assume integer property fits in fixnum.
466 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
467
468 * filelock.c: Fix some buffer overrun and integer overflow issues.
469 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
470 Reformulate so as not to need the command string.
471 Invoke gzip -cd rather than gunzip, as it's more portable.
472 (lock_info_type, lock_file_1, lock_file):
473 Don't assume pid_t and time_t fit in unsigned long.
474 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
475 (current_lock_owner): Prefer signed type for sizes.
476 Use memcpy, not strncpy, where memcpy is what is really wanted.
477 Don't assume (via atoi) that time_t and pid_t fit in int.
478 Check for time_t and/or pid_t out of range, e.g., via a network share.
479 Don't alloca where an auto var works fine.
480
481 * fileio.c: Fix some integer overflow issues.
482 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
483 Don't assume string length fits in int.
484 (directory_file_name): Don't assume string length fits in long.
485 (make_temp_name): Don't assume pid fits in int, or that its print
486 length is less than 20.
487
488 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
489
490 * coding.c (make_subsidiaries): Don't assume string length fits in int.
491
492 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
493
494 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
495 We prefer signed integers, even for size calculations.
496
497 * emacs.c: Don't assume string length fits in 'int'.
498 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
499 (main): Don't invoke strlen when not needed.
500
501 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
502 (XD_DEBUG_MESSAGE): Don't waste a byte.
503
504 * callproc.c (getenv_internal_1, getenv_internal)
505 (Fgetenv_internal):
506 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
507
508 * lread.c (invalid_syntax): Omit length argument.
509 All uses changed. This doesn't fix a bug, but it simplifies the
510 code away from its former Hollerith-constant appearance, and it's
511 one less 'int' to worry about when looking at integer-overflow issues.
512 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
513
514 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
515 This didn't break anything, but it didn't help either.
516 It's confusing to put a bogus integer in a place where the actual
517 value does not matter.
518 (LIST_END_P): Remove unused macro and its bogus comment.
519 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
520
521 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
522 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
523 implementation.
524 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
525 We prefer signed types, and the value cannot exceed the EMACS_INT
526 range anyway (because otherwise the length would not be representable).
527 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
528 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
529 This avoids a GCC warning when WIDE_EMACS_INT.
530
531 * indent.c (sane_tab_width): New function.
532 (current_column, scan_for_column, Findent_to, position_indentation)
533 (compute_motion): Use it. This is just for clarity.
534 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
535
536 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
537
538 * lisp.h (lint_assume): New macro.
539 * composite.c (composition_gstring_put_cache):
540 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
541
542 * editfns.c, insdel.c:
543 Omit unnecessary forward decls, to simplify future changes.
544
545 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
546
547 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
548
549 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
550 Use much-faster test for byte-length change.
551 Don't assume string byte-length fits in 'int'.
552 Check that character arg fits in 'int'.
553 (mapcar1): Declare byte as byte, for clarity.
554
555 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
556
557 * fns.c (concat): Catch string overflow earlier.
558 Do not rely on integer wraparound.
559
560 * dispextern.h (struct it.overlay_strings_charpos)
561 (struct it.selective): Now EMACS_INT, not int.
562 * xdisp.c (forward_to_next_line_start)
563 (back_to_previous_visible_line_start)
564 (reseat_at_next_visible_line_start, next_element_from_buffer):
565 Don't arbitrarily truncate the value of 'selective' to int.
566
567 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
568
569 * composite.c: Don't truncate sizes to 'int'.
570 (composition_gstring_p, composition_reseat_it)
571 (composition_adjust_point): Use EMACS_INT, not int.
572 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
573 not EMACS_UINT, for indexes.
574
575 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
576
577 * buffer.c: Include <verify.h>.
578 (struct sortvec.priority, struct sortstr.priority):
579 Now EMACS_INT, not int.
580 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
581 (struct sortstr.size, record_overlay_string)
582 (struct sortstrlist.size, struct sortlist.used):
583 Don't truncate size to int.
584 (record_overlay_string): Check for size-calculation overflow.
585 (init_buffer_once): Check at compile-time, not run-time.
586
587 2011-06-22 Jim Meyering <meyering@redhat.com>
588
589 Don't leak an XBM-image-sized buffer
590 * image.c (xbm_load): Free the image buffer after using it.
591
592 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
593
594 Port to Sun C.
595 * composite.c (find_automatic_composition): Omit needless 'return 0;'
596 that Sun C diagnosed.
597 * fns.c (secure_hash): Fix pointer signedness issue.
598 * intervals.c (static_offset_intervals): New function.
599 (offset_intervals): Use it.
600
601 2011-06-21 Leo Liu <sdl.web@gmail.com>
602
603 * deps.mk (fns.o):
604 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
605 sha512.h.
606
607 * fns.c (secure_hash): Rename from crypto_hash_function and change
608 the first arg to accept symbols.
609 (Fsecure_hash): New primitive.
610 (syms_of_fns): New symbols.
611
612 2011-06-20 Deniz Dogan <deniz@dogan.se>
613
614 * process.c (Fset_process_buffer): Clarify return value in
615 docstring.
616
617 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
618
619 * dispnew.c (add_window_display_history): Use BVAR.
620
621 * xdisp.c (debug_method_add): Use BVAR.
622 (check_window_end, dump_glyph_matrix, dump_glyph)
623 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
624
625 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
626 Likewise.
627
628 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
629 check till after the cache is created in init_frame_faces.
630
631 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
632
633 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
634
635 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
636
637 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
638 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
639 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
640
641 Improve buffer-overflow checking (Bug#8873).
642 * fileio.c (Finsert_file_contents):
643 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
644 Remove the old (too-loose) buffer overflow checks.
645 They weren't needed, since make_gap checks for buffer overflow.
646 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
647 The old code merely checked for Emacs fixnum overflow, and relied
648 on undefined (wraparound) behavior. The new code avoids undefined
649 behavior, and also checks for ptrdiff_t and/or size_t overflow.
650
651 * editfns.c (Finsert_char): Don't dump core with very negative counts.
652 Tune. Don't use wider integers than needed. Don't use alloca.
653 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
654
655 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
656
657 * insdel.c, lisp.h (buffer_overflow): New function.
658 (insert_from_buffer_1, replace_range, replace_range_2):
659 * insdel.c (make_gap_larger):
660 * editfns.c (Finsert_char):
661 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
662
663 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
664
665 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
666
667 Integer overflow and signedness fixes (Bug#8873).
668
669 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
670 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
671
672 * fileio.c: Don't assume EMACS_INT fits in off_t.
673 (emacs_lseek): New static function.
674 (Finsert_file_contents, Fwrite_region): Use it.
675 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
676
677 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
678
679 * fns.c: Don't overflow int when computing a list length.
680 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
681 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
682 truncation on 64-bit hosts. Check for QUIT every
683 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
684 faster and is responsive enough.
685 (Flength): Report an error instead of overflowing an integer.
686 (Fsafe_length): Return a float if the value is not representable
687 as a fixnum. This shouldn't happen except in contrived situations.
688 (Fnthcdr, Fsort): Don't assume list length fits in int.
689 (Fcopy_sequence): Don't assume vector length fits in int.
690
691 * alloc.c: Check that resized vectors' lengths fit in fixnums.
692 (header_size, word_size): New constants.
693 (allocate_vectorlike): Don't check size overflow here.
694 (allocate_vector): Check it here instead, since this is the only
695 caller of allocate_vectorlike that could cause overflow.
696 Check that the new vector's length is representable as a fixnum.
697
698 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
699 The previous code was bogus. For example, next_almost_prime (32)
700 returned 39, which is undesirable as it is a multiple of 3; and
701 next_almost_prime (24) returned 25, which is a multiple of 5 so
702 why was the code bothering to check for multiples of 7?
703
704 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
705
706 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
707
708 Variadic C functions now count arguments with ptrdiff_t.
709 This partly undoes my 2011-03-30 change, which replaced int with size_t.
710 Back then I didn't know that the Emacs coding style prefers signed int.
711 Also, in the meantime I found a few more instances where arguments
712 were being counted with int, which may truncate counts on 64-bit
713 machines, or EMACS_INT, which may be unnecessarily wide.
714 * lisp.h (struct Lisp_Subr.function.aMANY)
715 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
716 Arg counts are now ptrdiff_t, not size_t.
717 All variadic functions and their callers changed accordingly.
718 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
719 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
720 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
721 * callint.c (Fcall_interactively): Check arg count for overflow,
722 to avoid potential buffer overrun. Use signed char, not 'int',
723 for 'varies' array, so that we needn't bother to check its size
724 calculation for overflow.
725 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
726 * eval.c (apply_lambda):
727 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
728 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
729 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
730
731 * callint.c (Fcall_interactively): Don't use index var as event count.
732
733 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
734 * mem-limits.h (SIZE): Remove; no longer used.
735
736 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
737
738 Remove unnecessary casts.
739 * xterm.c (x_term_init):
740 * xfns.c (x_set_border_pixel):
741 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
742 These aren't needed now that we assume ANSI C.
743
744 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
745 It's more likely to cause problems (due to unsigned overflow)
746 than to cure them.
747
748 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
749
750 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
751
752 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
753
754 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
755
756 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
757
758 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
759
760 GLYPH_CODE_FACE returns EMACS_INT, not int.
761 * dispextern.h (merge_faces):
762 * xfaces.c (merge_faces):
763 * xdisp.c (get_next_display_element, next_element_from_display_vector):
764 Don't assume EMACS_INT fits in int.
765
766 * character.h (CHAR_VALID_P): Remove unused parameter.
767 * fontset.c, lisp.h, xdisp.c: All uses changed.
768
769 * editfns.c (Ftranslate_region_internal): Omit redundant test.
770
771 * fns.c (concat): Minor tuning based on overflow analysis.
772 This doesn't fix any bugs. Use int to hold character, instead
773 of constantly refetching from Emacs object. Use XFASTINT, not
774 XINT, for value known to be a character. Don't bother comparing
775 a single byte to 0400, as it's always less.
776
777 * floatfns.c (Fexpt):
778 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
779
780 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
781 for characters.
782
783 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
784
785 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
786 Without this fix, on a 64-bit host (aset S 0 4294967386) would
787 incorrectly succeed when S was a string, because 4294967386 was
788 truncated before it was used.
789
790 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
791 Otherwise, an out-of-range integer could cause undefined behavior
792 on a 64-bit host.
793
794 * composite.c: Use int, not EMACS_INT, for characters.
795 (fill_gstring_body, composition_compute_stop_pos): Use int, not
796 EMACS_INT, for values that are known to be in character range.
797 This doesn't fix any bugs but is the usual style inside Emacs and
798 may generate better code on 32-bit machines.
799
800 Make sure a 64-bit char is never passed to ENCODE_CHAR.
801 This is for reasons similar to the recent CHAR_STRING fix.
802 * charset.c (Fencode_char): Check that character arg is actually
803 a character. Pass an int to ENCODE_CHAR.
804 * charset.h (ENCODE_CHAR): Verify that the character argument is no
805 wider than 'int', as a compile-time check to prevent future regressions
806 in this area.
807
808 * character.c (char_string): Remove unnecessary casts.
809
810 Make sure a 64-bit char is never passed to CHAR_STRING.
811 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
812 by silently ignoring the top 32 bits, allowing some values
813 that were far too large to be valid characters.
814 * character.h: Include <verify.h>.
815 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
816 arguments are no wider than unsigned, as a compile-time check
817 to prevent future regressions in this area.
818 * data.c (Faset):
819 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
820 (Fsubst_char_in_region):
821 * fns.c (concat):
822 * xdisp.c (decode_mode_spec_coding):
823 Adjust to CHAR_STRING's new requirement.
824 * editfns.c (Finsert_char, Fsubst_char_in_region):
825 * fns.c (concat): Check that character args are actually
826 characters. Without this test, these functions did the wrong
827 thing with wildly out-of-range values on 64-bit hosts.
828
829 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
830 These casts should not be needed on 32-bit hosts, either.
831 * keyboard.c (read_char):
832 * lread.c (Fload): Remove casts to unsigned.
833
834 * lisp.h (UNSIGNED_CMP): New macro.
835 This fixes comparison bugs on 64-bit hosts.
836 (ASCII_CHAR_P): Use it.
837 * casefiddle.c (casify_object):
838 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
839 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
840 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
841 * dispextern.h (FACE_FROM_ID):
842 * keyboard.c (read_char): Use UNSIGNED_CMP.
843
844 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
845 not to EMACS_INT, to avoid GCC warning.
846
847 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
848
849 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
850 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
851 isn't needed on 32-bit machines.
852
853 * buffer.c (Fgenerate_new_buffer_name):
854 Use EMACS_INT for count, not int.
855 (advance_to_char_boundary): Return EMACS_INT, not int.
856
857 * data.c (Qcompiled_function): Now static.
858
859 * window.c (window_body_lines): Now static.
860
861 * image.c (gif_load): Rename local to avoid shadowing.
862
863 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
864 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
865 * alloc.c (make_save_value): Integer argument is now of type
866 ptrdiff_t, not int.
867 (mark_object): Use ptrdiff_t, not int.
868 * lisp.h (pD): New macro.
869 * print.c (print_object): Use it.
870
871 * alloc.c: Use EMACS_INT, not int, to count objects.
872 (total_conses, total_markers, total_symbols, total_vector_size)
873 (total_free_conses, total_free_markers, total_free_symbols)
874 (total_free_floats, total_floats, total_free_intervals)
875 (total_intervals, total_strings, total_free_strings):
876 Now EMACS_INT, not int. All uses changed.
877 (Fgarbage_collect): Compute overall total using a double, so that
878 integer overflow is less likely to be a problem. Check for overflow
879 when converting back to an integer.
880 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
881 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
882 These were 'int' variables that could overflow on 64-bit hosts;
883 they were never used, so remove them instead of repairing them.
884 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
885 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
886 Previously, this ceilinged at INT_MAX, but that doesn't work on
887 64-bit machines.
888 (allocate_pseudovector): Don't use EMACS_INT when int would do.
889
890 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
891 (allocate_vectorlike): Check for ptrdiff_t overflow.
892 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
893 when a (possibly-narrower) signed value would do just as well.
894 We prefer using signed arithmetic, to avoid comparison confusion.
895
896 * alloc.c: Catch some string size overflows that we were missing.
897 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
898 for convenience in STRING_BYTES_MAX.
899 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
900 The definition here is exact; the one in lisp.h was approximate.
901 (allocate_string_data): Check for string overflow. This catches
902 some instances we weren't catching before. Also, it catches
903 size_t overflow on (unusual) hosts where SIZE_MAX <= min
904 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
905 and ptrdiff_t and EMACS_INT are both 64 bits.
906
907 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
908 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
909 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
910
911 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
912
913 * alloc.c (Fmake_string): Check for out-of-range init.
914
915 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
916
917 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
918
919 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
920
921 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
922 xg_get_default_scrollbar_width.
923
924 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
925 (int_gtk_range_get_value): Move to the scroll bar part of the file.
926 (style_changed_cb): Call update_theme_scrollbar_width and call
927 x_set_scroll_bar_default_width and xg_frame_set_char_size for
928 all frames (Bug#8505).
929 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
930 Call gtk_window_set_resizable if HAVE_GTK3.
931 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
932 and height if HAVE_GTK3 (Bug#8505).
933 (scroll_bar_width_for_theme): New variable.
934 (update_theme_scrollbar_width): New function.
935 (xg_get_default_scrollbar_width): Move code to
936 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
937 (xg_initialize): Call update_theme_scrollbar_width.
938
939 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
940
941 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
942
943 2011-06-12 Martin Rudalics <rudalics@gmx.at>
944
945 * frame.c (make_frame): Call other_buffer_safely instead of
946 other_buffer.
947
948 * window.c (temp_output_buffer_show): Call display_buffer with
949 second argument Vtemp_buffer_show_specifiers and reset latter
950 immediately after the call.
951 (Vtemp_buffer_show_specifiers): New variable.
952 (auto_window_vscroll_p, next_screen_context_lines)
953 (Vscroll_preserve_screen_position): Remove leading asterisks from
954 doc-strings.
955
956 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
957
958 Fix minor problems found by GCC 4.6.0 static checking.
959 * buffer.c (Qclone_number): Remove for now, as it's unused.
960 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
961 (record_buffer): Remove unused local.
962 * frame.c (other_visible_frames, frame_buffer_list): Now static.
963 (set_frame_buffer_list): Remove; unused.
964 * frame.h (other_visible_frames): Remove decl.
965 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
966 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
967 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
968 if HAVE_GPM.
969 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
970 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
971 Define only if HAVE_GPM.
972 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
973 (update_hints_inhibit): Remove; never set. All uses removed.
974 * widgetprv.h (emacsFrameClassRec): Remove decl.
975 * window.c (delete_deletable_window): Now returns void, since it
976 wasn't returning anything.
977 (compare_window_configurations): Remove unused locals.
978 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
979 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
980 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
981 the same widths as pointers. This follows up on the 2011-05-06 patch.
982 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
983 * xterm.h: Likewise.
984 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
985
986 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
987
988 * makefile.w32-in: Update dependencies.
989 (LISP_H): Add lib/intprops.h.
990
991 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
992
993 * image.c (gif_load): Add animation frame delay to the metadata.
994 (syms_of_image): Use DEFSYM. New symbol `delay'.
995
996 2011-06-11 Martin Rudalics <rudalics@gmx.at>
997
998 * window.c (delete_deletable_window): Re-add.
999 (Fset_window_configuration): Rewrite to handle dead buffers and
1000 consequently deletable windows.
1001 (window_tree, Fwindow_tree): Remove. Supply functionality in
1002 window.el.
1003 (compare_window_configurations): Simplify code.
1004
1005 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1006
1007 * image.c (imagemagick_load_image): Fix type mismatch.
1008 (Fimagemagick_types): Likewise.
1009
1010 * window.h (replace_buffer_in_windows): Declare.
1011
1012 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1013
1014 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1015 Qclone_number. Remove external declaration of Qdelete_window.
1016 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1017 code.
1018 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1019 Qbuffer_list_update_hook if allowed.
1020 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1021 buffer list implementation.
1022 (other_buffer_safely): New function.
1023 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1024 calls to replace_buffer_in_windows and
1025 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1026 if allowed.
1027 (record_buffer): Inhibit quitting and rewrite using quittable
1028 functions. Run Qbuffer_list_update_hook if allowed.
1029 (Frecord_buffer, Funrecord_buffer): New functions.
1030 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1031 switch-to-buffer to window.el.
1032 (bury-buffer): Move to window.el.
1033 (Vbuffer_list_update_hook): New variable.
1034
1035 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1036 section.
1037
1038 * window.h (resize_frame_windows): Move up in code.
1039 (Fwindow_frame): Remove EXFUN.
1040 (replace_buffer_in_all_windows): Remove prototype.
1041 (replace_buffer_in_windows_safely): Add prototype.
1042
1043 * window.c: Declare Qdelete_window static again. Move down
1044 declaration of select_count.
1045 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1046 (Fother_window): Move to window.el.
1047 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1048 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1049 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1050 window.el.
1051 (replace_buffer_in_windows): Implement by calling
1052 Qreplace_buffer_in_windows.
1053 (replace_buffer_in_all_windows): Remove with some functionality
1054 moved into replace_buffer_in_windows_safely.
1055 (replace_buffer_in_windows_safely): New function.
1056 (select_window_norecord, select_frame_norecord): Move in front
1057 of run_window_configuration_change_hook. Remove now obsolete
1058 declarations.
1059 (Fset_window_buffer): Rewrite doc-string. Call
1060 Qrecord_window_buffer.
1061 (keys_of_window): Move binding for other-window to window.el.
1062
1063 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1064
1065 * dispextern.h (struct image): Replace data member, whose int_val
1066 and ptr_val fields were not used by anything, with a single
1067 lisp_val object.
1068
1069 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1070 (gif_clear_image, gif_load, imagemagick_load_image)
1071 (gs_clear_image, gs_load): Callers changed.
1072
1073 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1074
1075 * buffer.h: Include <time.h>, for time_t.
1076 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1077
1078 Fix minor problems found by static checking.
1079
1080 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1081
1082 Make identifiers static if they are not used in other modules.
1083 * data.c (Qcompiled_function, Qframe, Qvector):
1084 * image.c (QimageMagick, Qsvg):
1085 * minibuf.c (Qmetadata):
1086 * window.c (resize_window_check, resize_root_window): Now static.
1087 * window.h (resize_window_check, resize_root_window): Remove decls.
1088
1089 * window.c (window_deletion_count, delete_deletable_window):
1090 Remove; unused.
1091 (window_body_lines): Now static.
1092 (Fdelete_other_windows_internal): Mark vars as initialized.
1093 Make sure 'resize_failed' is initialized.
1094 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1095 (resize_window_apply): Remove unused local.
1096 * window.h (delete_deletable_window): Remove decl.
1097
1098 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1099 (imagemagick_load_image): Fix pointer signedness problem by changing
1100 last arg from unsigned char * to char *. All uses changed.
1101 Also, fix a local for similar reasons.
1102 Remove unused locals. Remove locals to avoid shadowing.
1103 (fn_rsvg_handle_free): Remove; unused.
1104 (svg_load, svg_load_image): Fix pointer signedness problem.
1105 (imagemagick_load_image): Don't use garbage pointer image_wand.
1106
1107 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1108
1109 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1110
1111 * image.c (gif_load): Fix omitted cast error introduced by
1112 2011-06-06 change.
1113
1114 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1115
1116 * window.h (resize_proportionally, orig_total_lines)
1117 (orig_top_line): Remove from window structure.
1118 (set_window_height, set_window_width, change_window_heights)
1119 (Fdelete_window): Remove prototypes.
1120 (resize_frame_windows): Remove duplicate declaration.
1121
1122 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1123
1124 * window.h (resize_frame_windows, resize_window_check)
1125 (delete_deletable_window, resize_root_window)
1126 (resize_frame_windows): Declare prototypes.
1127
1128 * window.c (resize_window_apply): Make definition be "static" to
1129 match the prototype.
1130
1131 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1132
1133 * window.c: Remove declarations of Qwindow_size_fixed,
1134 window_min_size_1, window_min_size_2, window_min_size,
1135 size_window, window_fixed_size_p, enlarge_window, delete_window.
1136 Remove static from declaration of Qdelete_window, it's
1137 temporarily needed by Fbury_buffer.
1138 (replace_window): Don't assign orig_top_line and
1139 orig_total_lines.
1140 (Fdelete_window, delete_window): Remove. Window deletion is
1141 handled by window.el.
1142 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1143 Fdelete_window calls with calls to Qdelete_window.
1144 (Fdelete_other_windows): Remove. Deleting other windows is
1145 handled by window.el.
1146 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1147 handled in window.el.
1148 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1149 Window minimum sizes are handled in window.el.
1150 (shrink_windows, size_window, set_window_height)
1151 (set_window_width, change_window_heights, window_height)
1152 (window_width, CURBEG, CURSIZE, enlarge_window)
1153 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1154 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1155 handled in window.el.
1156 (make_dummy_parent): Rename to make_parent_window and give it a
1157 second argument horflag.
1158 (make_window): Don't set resize_proportionally any more.
1159 (Fsplit_window): Remove. Windows are split in window.el.
1160 (save_restore_action, save_restore_orig_size)
1161 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1162 Resize mini windows in window.el.
1163 (grow_mini_window, shrink_mini_window): Implement by calling
1164 Qresize_root_window_vertically, resize_window_check and
1165 resize_window_apply.
1166 (saved_window, Fset_window_configuration, save_window_save): Do
1167 not handle orig_top_line, orig_total_lines, and
1168 resize_proportionally.
1169 (window_min_height, window_min_width): Move to window.el.
1170 (keys_of_window): Move bindings for delete-other-windows,
1171 split-window, delete-window and enlarge-window to window.el.
1172
1173 * buffer.c: Temporarily extern Qdelete_window.
1174 (Fbury_buffer): Temporarily call Qdelete_window instead of
1175 Fdelete_window (Fbury_buffer will move to window.el soon).
1176
1177 * frame.c (set_menu_bar_lines_1): Remove code handling
1178 orig_top_line and orig_total_lines.
1179
1180 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1181 set_window_height but set heights directly.
1182 (change_frame_size_1): Use resize_frame_windows.
1183
1184 * xdisp.c (init_xdisp): Don't use set_window_height but set
1185 heights directly.
1186
1187 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1188 resize_frame_windows instead of change_window_heights and run
1189 run_window_configuration_change_hook.
1190
1191 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1192 instead of change_window_heights and run
1193 run_window_configuration_change_hook.
1194
1195 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1196
1197 * window.c (replace_window): Rename second argument REPLACEMENT to
1198 NEW. New third argument SETFLAG. Rewrite.
1199 (delete_window, make_dummy_parent): Call replace_window with
1200 third argument 1.
1201 (window_list_1): Move down in code.
1202 (run_window_configuration_change_hook): Move set_buffer part
1203 before select_frame_norecord part in order to unwind correctly.
1204 Rename count1 to count.
1205 (recombine_windows, delete_deletable_window, resize_root_window)
1206 (Fdelete_other_windows_internal)
1207 (Frun_window_configuration_change_hook, make_parent_window)
1208 (resize_window_check, resize_window_apply, Fresize_window_apply)
1209 (resize_frame_windows, Fsplit_window_internal)
1210 (Fdelete_window_internal, Fresize_mini_window_internal): New
1211 functions.
1212 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1213
1214 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1215
1216 * window.h (window): Add some new members to window structure -
1217 normal_lines, normal_cols, new_total, new_normal, clone_number,
1218 splits, nest, prev_buffers, next_buffers.
1219 (WINDOW_TOTAL_SIZE): Move here from window.c.
1220 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1221
1222 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1223 Remove.
1224 (make_dummy_parent): Set new members of windows structure.
1225 (make_window): Move down in code. Handle new members of window
1226 structure.
1227 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1228 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1229 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1230 (Fset_window_prev_buffers, Fwindow_next_buffers)
1231 (Fset_window_next_buffers, Fset_window_clone_number): New
1232 functions.
1233 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1234 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1235 Doc-string fixes.
1236 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1237 Argument WINDOW can be now internal window too.
1238 (Fwindow_use_time): Move up in code.
1239 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1240 Rewrite doc-string.
1241 (Fset_window_configuration, saved_window)
1242 (Fcurrent_window_configuration, save_window_save): Handle new
1243 members of window structure.
1244 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1245 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1246 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1247 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1248 Qget_mru_window, Qresize_root_window,
1249 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1250 Qauto_buffer_name; staticpro them.
1251
1252 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1253
1254 * window.c (Fwindow_total_size, Fwindow_left_column)
1255 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1256 (Fwindow_list_1): New functions.
1257 (window_box_text_cols): Replace with window_body_cols.
1258 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1259 window_body_cols instead of window_box_text_cols.
1260 (delete_window, Fset_window_configuration): Call
1261 delete_all_subwindows with window as argument.
1262 (delete_all_subwindows): Take a window as argument and not a
1263 structure. Rewrite.
1264 (window_loop): Remove handling of GET_LRU_WINDOW and
1265 GET_LARGEST_WINDOW.
1266 (Fget_lru_window, Fget_largest_window): Move to window.el.
1267
1268 * window.h: Extern window_body_cols instead of
1269 window_box_text_cols. delete_all_subwindows now takes a
1270 Lisp_Object as argument.
1271
1272 * indent.c (compute_motion, Fcompute_motion): Use
1273 window_body_cols instead of window_box_text_cols.
1274
1275 * frame.c (delete_frame): Call delete_all_subwindows with root
1276 window as argument.
1277
1278 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1279
1280 * fns.c (Fputhash): Document return value.
1281
1282 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1283
1284 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1285
1286 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1287
1288 Cons<->int and similar integer overflow fixes (Bug#8794).
1289
1290 Check for overflow when converting integer to cons and back.
1291 * charset.c (Fdefine_charset_internal, Fdecode_char):
1292 Use cons_to_unsigned to catch overflow.
1293 (Fencode_char): Use INTEGER_TO_CONS.
1294 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1295 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1296 * data.c (long_to_cons, cons_to_long): Remove.
1297 (cons_to_unsigned, cons_to_signed): New functions.
1298 These signal an error for invalid or out-of-range values.
1299 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1300 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1301 * font.c (Ffont_variation_glyphs):
1302 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1303 * lisp.h: Include <intprops.h>.
1304 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1305 (cons_to_signed, cons_to_unsigned): New decls.
1306 (long_to_cons, cons_to_long): Remove decls.
1307 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1308 (Fprimitive_undo): Use CONS_TO_INTEGER.
1309 * xfns.c (Fx_window_property): Likewise.
1310 * xselect.c: Include <limits.h>.
1311 (x_own_selection, selection_data_to_lisp_data):
1312 Use INTEGER_TO_CONS.
1313 (x_handle_selection_request, x_handle_selection_clear)
1314 (x_get_foreign_selection, Fx_disown_selection_internal)
1315 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1316 (lisp_data_to_selection_data): Use cons_to_unsigned.
1317 (x_fill_property_data): Use cons_to_signed.
1318 Report values out of range.
1319
1320 Check for buffer and string overflow more precisely.
1321 * buffer.h (BUF_BYTES_MAX): New macro.
1322 * lisp.h (STRING_BYTES_MAX): New macro.
1323 * alloc.c (Fmake_string):
1324 * character.c (string_escape_byte8):
1325 * coding.c (coding_alloc_by_realloc):
1326 * doprnt.c (doprnt):
1327 * editfns.c (Fformat):
1328 * eval.c (verror):
1329 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1330 since they may not be the same number.
1331 * editfns.c (Finsert_char):
1332 * fileio.c (Finsert_file_contents):
1333 Likewise for BUF_BYTES_MAX.
1334
1335 * image.c: Use ptrdiff_t, not int, for sizes.
1336 (slurp_file): Switch from int to ptrdiff_t.
1337 All uses changed.
1338 (slurp_file): Check that file size fits in both size_t (for
1339 malloc) and ptrdiff_t (for sanity and safety).
1340
1341 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1342 if b->modtime has its maximal value.
1343
1344 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1345
1346 Don't assume time_t can fit into int.
1347 * buffer.h (struct buffer.modtime): Now time_t, not int.
1348 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1349 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1350
1351 Minor fixes for signed vs unsigned integers.
1352 * character.h (MAYBE_UNIFY_CHAR):
1353 * charset.c (maybe_unify_char):
1354 * keyboard.c (read_char, reorder_modifiers):
1355 XINT -> XFASTINT, since the integer must be nonnegative.
1356 * ftfont.c (ftfont_spec_pattern):
1357 * keymap.c (access_keymap, silly_event_symbol_error):
1358 XUINT -> XFASTINT, since the integer must be nonnegative.
1359 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1360 since it makes no difference and we prefer signed.
1361 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1362 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1363 nonnegative.
1364
1365 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1366
1367 * window.h (Fwindow_frame): Declare.
1368
1369 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1370
1371 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1372 (SPARE_MEMORY): Always define.
1373 (LARGE_REQUEST): Remove.
1374 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1375
1376 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1377
1378 * lisp.h: Move EXFUNS for Fframe_root_window,
1379 Fframe_first_window and Fset_frame_selected_window to window.h.
1380
1381 * window.h: Move EXFUNS for Fframe_root_window,
1382 Fframe_first_window and Fset_frame_selected_window here from
1383 lisp.h.
1384
1385 * frame.c (Fwindow_frame, Fframe_first_window)
1386 (Fframe_root_window, Fframe_selected_window)
1387 (Fset_frame_selected_window): Move to window.c.
1388 (Factive_minibuffer_window): Move to minibuf.c.
1389 (Fother_visible_frames_p): New function.
1390
1391 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1392
1393 * window.c (decode_window, decode_any_window): Move up in code.
1394 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1395 (inhibit_frame_unsplittable): Remove unused variable.
1396 (Fwindow_buffer): Move up and rewrite doc-string.
1397 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1398 (Fwindow_prev): New functions.
1399 (Fwindow_frame): Move here from frame.c. Accept any window as
1400 argument.
1401 (Fframe_root_window, Fframe_first_window)
1402 (Fframe_selected_window): Move here from frame.c. Accept frame
1403 or arbitrary window as argument. Update doc-strings.
1404 (Fminibuffer_window): Move up in code.
1405 (Fwindow_minibuffer_p): Move up in code and simplify.
1406 (Fset_frame_selected_window): Move here from frame.c.
1407 Marginal rewrite.
1408 (Fselected_window, select_window, Fselect_window): Move up in
1409 code. Minor doc-string fixes.
1410
1411 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1412
1413 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1414 Do not assume that spare memory exists; that assumption is valid
1415 only if SYSTEM_MALLOC.
1416 (LARGE_REQUEST): New macro, so that the issue of large requests
1417 is separated from the issue of spare memory.
1418
1419 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1420
1421 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1422 format. (Bug#8806)
1423
1424 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1425
1426 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1427 before statements.
1428
1429 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1430
1431 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1432
1433 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1434
1435 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1436 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1437
1438 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1439
1440 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1441
1442 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1443
1444 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1445 (x_clipboard_manager_save): Add return value.
1446 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1447 New error handlers.
1448 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1449 Obey Vx_select_enable_clipboard_manager. Catch errors in
1450 x_clipboard_manager_save (Bug#8779).
1451 (Vx_select_enable_clipboard_manager): New variable.
1452 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1453
1454 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1455
1456 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1457
1458 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1459
1460 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1461 in the current matrix if keep_current_p is non-zero.
1462
1463 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1464
1465 * bidi.c (bidi_level_of_next_char): Fix last change.
1466
1467 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1468
1469 Support bidi reordering of text covered by display properties.
1470
1471 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1472 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1473 (bidi_cache_search, bidi_cache_iterator_state)
1474 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1475 (bidi_level_of_next_char, bidi_move_to_visually_next):
1476 Support character positions inside a run of characters covered by a
1477 display string.
1478 (bidi_paragraph_init, bidi_resolve_explicit_1)
1479 (bidi_level_of_next_char): Call bidi_fetch_char and
1480 bidi_fetch_char_advance instead of FETCH_CHAR and
1481 FETCH_CHAR_ADVANCE.
1482 (bidi_init_it): Initialize new members.
1483 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1484 definitions.
1485 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1486 instead of using explicit *_CHAR codes.
1487 (bidi_resolve_explicit, bidi_resolve_weak):
1488 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1489 bidirectional text is supported only in multibyte buffers.
1490 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1491 it to initialize the frame_window_p member of struct bidi_it.
1492 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1493 (bidi_resolve_explicit, bidi_resolve_weak)
1494 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1495 bidi_it->nchars is non-positive.
1496 (bidi_level_of_next_char): Don't try to lookup the cache for the
1497 next/previous character if nothing is cached there yet, or if we
1498 were just reseat()'ed to a new position.
1499
1500 * xdisp.c (set_cursor_from_row): Set start and stop points
1501 according to the row's direction when priming the loop that looks
1502 for the glyph on which to display cursor.
1503 (single_display_spec_intangible_p): Function deleted.
1504 (display_prop_intangible_p): Reimplement to call
1505 handle_display_spec instead of single_display_spec_intangible_p.
1506 Accept 3 additional arguments needed by handle_display_spec.
1507 This fixes incorrect cursor motion across display property with complex
1508 values: lists, `(when COND...)' forms, etc.
1509 (single_display_spec_string_p): Support property values that are
1510 lists with the argument STRING its top-level element.
1511 (display_prop_string_p): Fix the condition for processing a
1512 property that is a list to be consistent with handle_display_spec.
1513 (handle_display_spec): New function, refactored from the
1514 last portion of handle_display_prop.
1515 (compute_display_string_pos): Accept additional argument
1516 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1517 value of a `display' property is a "replacing spec".
1518 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1519 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1520 the display property, but just return a value indicating whether
1521 the display property will replace the characters it covers.
1522 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1523 frame_window_p members of struct bidi_it.
1524 (compute_display_string_pos, compute_display_string_end):
1525 New functions.
1526 (push_it): Accept second argument POSITION, where pop_it should
1527 jump to continue iteration.
1528 (reseat_1): Initialize bidi_it.disp_pos.
1529
1530 * keyboard.c (adjust_point_for_property): Adjust the call to
1531 display_prop_intangible_p to its new signature.
1532
1533 * dispextern.h (struct bidi_it): New member frame_window_p.
1534 (bidi_init_it): Update prototypes.
1535 (display_prop_intangible_p): Update prototype.
1536 (compute_display_string_pos, compute_display_string_end):
1537 Declare prototypes.
1538 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1539 EMACS_INT.
1540
1541 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1542
1543 Malloc failure behavior now depends on size of allocation.
1544 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1545 * lisp.h: Change signatures accordingly.
1546 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1547 All callers changed. (Bug#8762)
1548
1549 * gnutls.c: Use Emacs's memory allocators.
1550 Without this change, the gnutls library would invoke malloc etc.
1551 directly, which causes problems on non-SYNC_INPUT hosts, and which
1552 runs afoul of improving memory_full behavior. (Bug#8761)
1553 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1554 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1555 xfree instead of the default malloc, realloc, free.
1556 (Fgnutls_boot): No need to check for memory allocation failure,
1557 since xmalloc does that for us.
1558
1559 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1560 * category.c (hash_get_category_set):
1561 * ccl.c (ccl_driver):
1562 * charset.c (Fdefine_charset_internal):
1563 * charset.h (struct charset.hash_index):
1564 * composite.c (get_composition_id, gstring_lookup_cache)
1565 (composition_gstring_put_cache):
1566 * composite.h (struct composition.hash_index):
1567 * dispextern.h (struct image.hash):
1568 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1569 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1570 (hashfn_equal, hashfn_user_defined, make_hash_table)
1571 (maybe_resize_hash_table, hash_lookup, hash_put)
1572 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1573 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1574 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1575 * image.c (make_image, search_image_cache, lookup_image)
1576 (xpm_put_color_table_h):
1577 * lisp.h (struct Lisp_Hash_Table):
1578 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1579 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1580 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1581 * alloc.c (allocate_vectorlike):
1582 Check for overflow in vector size calculations.
1583 * ccl.c (ccl_driver):
1584 Check for overflow when converting EMACS_INT to int.
1585 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1586 need to be updated by these changes.
1587 * fns.c (make_hash_table, maybe_resize_hash_table):
1588 Check for integer overflow with large hash tables.
1589 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1590 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1591 (SXHASH_REDUCE): New macro.
1592 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1593 Use it instead of discarding useful hash info with large hash values.
1594 (sxhash_float): New function.
1595 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1596 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1597 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1598 Rewrite to use FIXNUM_BITS, as this simplifies things.
1599 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1600 Adjust signatures to match updated version of code.
1601 (consing_since_gc): Now EMACS_INT, since a single hash table can
1602 use more than INT_MAX bytes.
1603
1604 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1605
1606 Make it possible to build with GCC-4.6+ -O2 -flto.
1607
1608 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1609
1610 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1611
1612 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1613 Call minibuffer-inactive-mode.
1614
1615 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1616
1617 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1618 Update dependencies.
1619
1620 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1621
1622 * data.c (init_data): Remove code for UTS, this system is not
1623 supported anymore.
1624
1625 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1626
1627 Don't force ./temacs to start in terminal mode.
1628
1629 * frame.c (make_initial_frame): Initialize faces in all cases, not
1630 only when CANNOT_DUMP is defined.
1631 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1632
1633 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1634
1635 * dispnew.c (add_window_display_history): Use const for the string
1636 pointer. Remove declaration, not needed.
1637
1638 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1639
1640 Use 'inline', not 'INLINE'.
1641 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1642 * alloc.c, fontset.c (INLINE): Remove.
1643 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1644 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1645 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1646 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1647 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1648
1649 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1650
1651 Make it possible to run ./temacs.
1652
1653 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1654 syms_of_callproc does the same thing. Remove test for
1655 "initialized", do it in the caller.
1656 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1657
1658 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1659
1660 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1661 (read_minibuf): Use get_minibuffer.
1662 (syms_of_minibuf): Use DEFSYM.
1663 (Qmetadata): New var.
1664 * data.c (Qbuffer): Don't make it static.
1665 (syms_of_data): Use DEFSYM.
1666
1667 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1668
1669 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1670 (CCL_CODE_MIN): New macro.
1671
1672 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1673
1674 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1675
1676 * eval.c (Qdebug): Now static.
1677 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1678 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1679 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1680
1681 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1682
1683 * image.c: Various fixes to ImageMagick code comments.
1684 (Fimagemagick_types): Doc fix.
1685
1686 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1687
1688 Minor fixes prompted by GCC 4.6.0 warnings.
1689
1690 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1691
1692 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1693 (x_clipboard_manager_save_all): Move extern decl to ...
1694 * xterm.h: ... here, so that it can be checked for consistency.
1695
1696 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1697
1698 * xselect.c (x_clipboard_manager_save_frame)
1699 (x_clipboard_manager_save_all): New functions.
1700 (Fx_clipboard_manager_save): Lisp function deleted.
1701
1702 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1703 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1704
1705 * xterm.h: Update prototype.
1706
1707 2011-05-28 William Xu <william.xwl@gmail.com>
1708
1709 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1710 exiting (Bug#8239).
1711
1712 2011-05-28 Jim Meyering <meyering@redhat.com>
1713
1714 Avoid a sign-extension bug in crypto_hash_function.
1715 * fns.c (to_uchar): Define.
1716 (crypto_hash_function): Use it to convert some newly-signed
1717 variables to unsigned, to avoid sign-extension bugs. For example,
1718 without this change, (md5 "truc") would evaluate to
1719 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1720 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1721 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1722
1723 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1724
1725 Integer overflow fixes.
1726
1727 * dbusbind.c: Serial number integer overflow fixes.
1728 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1729 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1730 to hold a serial number that is too large for a fixnum.
1731 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1732 Check for serial numbers out of range. Decode any serial number
1733 that was so large that it became a float. (Bug#8722)
1734
1735 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1736 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1737 Use XFASTINT rather than XUINT when numbers are nonnegative.
1738 (xd_append_arg, Fdbus_method_return_internal):
1739 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1740 arguments, check that Lisp number is nonnegative, rather than
1741 silently wrapping negative numbers around. (Bug#8722)
1742 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1743 (Bug#8722)
1744
1745 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1746
1747 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1748
1749 ccl: add integer overflow checks
1750 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1751 (IN_INT_RANGE): New macros.
1752 (ccl_driver): Use them to check for integer overflow when
1753 decoding a CCL program. Many of the new checks are whether XINT (x)
1754 fits in int; it doesn't always, on 64-bit hosts. The new version
1755 doesn't catch all possible integer overflows, but it's an
1756 improvement. (Bug#8719)
1757
1758 * alloc.c (make_event_array): Use XINT, not XUINT.
1759 There's no need for unsigned here.
1760
1761 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1762 This follows up to the 2011-05-06 change that substituted uintptr_t
1763 for EMACS_INT. This case wasn't caught back then.
1764
1765 Rework Fformat to avoid integer overflow issues.
1766 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1767 now (part of C89). Include <verify.h>.
1768 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1769 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1770 (Fformat): Avoid the prepass trying to compute sizes; it was only
1771 approximate and thus did not catch overflow reliably. Instead, walk
1772 through the format just once, formatting and computing sizes as we go,
1773 checking for integer overflow at every step, and allocating a larger
1774 buffer as needed. Keep track separately whether the format is
1775 multibyte. Keep only the most-recently calculated precision, rather
1776 than them all. Record whether each argument has been converted to
1777 string. Use EMACS_INT, not int, for byte and char and arg counts.
1778 Support field widths and precisions larger than INT_MAX. Avoid
1779 sprintf's undefined behavior with conversion specifications such as %#d
1780 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1781 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1782 formatting out-of-range floating point numbers with int
1783 formats. (Bug#8668)
1784
1785 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1786
1787 * data.c: Avoid integer truncation in expressions involving floats.
1788 * data.c: Include <intprops.h>.
1789 (arith_driver): When there's an integer overflow in an expression
1790 involving floating point, convert the integers to floating point
1791 so that the resulting value does not suffer from catastrophic
1792 integer truncation. For example, on a 64-bit host (* 4
1793 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1794 Do not rely on undefined behavior after integer overflow.
1795
1796 merge count_size_as_multibyte, parse_str_to_multibyte
1797 * character.c, character.h (count_size_as_multibyte):
1798 Rename from parse_str_to_multibyte; all uses changed.
1799 Check for integer overflow.
1800 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1801 since it's now a duplicate of the other. This is more of
1802 a character than a buffer op, so better that it's in character.c.
1803 * fns.c, print.c: Adjust to above changes.
1804
1805 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1806
1807 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1808
1809 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1810
1811 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1812 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1813 (x_clipboard_manager_save): Now static.
1814 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1815
1816 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1817 (crypto_hash_function): Now static.
1818 Fix pointer signedness problems. Avoid unnecessary initializations.
1819
1820 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1821
1822 * termhooks.h (Vselection_alist): Make it terminal-local.
1823
1824 * terminal.c (create_terminal): Initialize it.
1825
1826 * xselect.c: Support for clipboard managers.
1827 (Vselection_alist): Move to termhooks.h as terminal-local var.
1828 (LOCAL_SELECTION): New macro.
1829 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1830 (symbol_to_x_atom): Remove gratuitous arg.
1831 (x_handle_selection_request, lisp_data_to_selection_data)
1832 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1833 (x_own_selection, x_get_local_selection, x_convert_selection):
1834 New arg, specifying work frame. Use terminal-local Vselection_alist.
1835 (some_frame_on_display): Delete unused function.
1836 (Fx_own_selection_internal, Fx_get_selection_internal)
1837 (Fx_disown_selection_internal, Fx_selection_owner_p)
1838 (Fx_selection_exists_p): New optional frame arg.
1839 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1840 (x_handle_selection_clear): Don't treat other terminals with the
1841 same keyboard specially. Use the terminal-local Vselection_alist.
1842 (x_clear_frame_selections): Use Frun_hook_with_args.
1843
1844 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1845
1846 * xterm.h: Add support for those atoms.
1847
1848 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1849
1850 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1851 (converted_selections, conversion_fail_tag): New global variables.
1852 (x_selection_request_lisp_error): Free the above.
1853 (x_get_local_selection): Remove unnecessary code.
1854 (x_reply_selection_request): Args changed; handle arbitrary array
1855 of converted selections stored in converted_selections.
1856 Separate the XChangeProperty and SelectionNotify steps.
1857 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1858 (x_convert_selection): New function.
1859 (x_handle_selection_event): Simplify.
1860 (x_get_foreign_selection): Don't ignore incoming requests while
1861 waiting for an answer; this will fail when we implement
1862 SAVE_TARGETS, and seems unnecessary anyway.
1863 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1864 (Vx_sent_selection_functions): Doc fix.
1865
1866 2011-05-26 Leo Liu <sdl.web@gmail.com>
1867
1868 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1869
1870 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1871
1872 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1873
1874 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1875 for fringe update if it has periodic bitmap.
1876 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1877 and fringe_bitmap_periodic_p.
1878
1879 * fringe.c (get_fringe_bitmap_data): New function.
1880 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1881 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1882 row. Mark glyph row for fringe update if periodicity changed.
1883
1884 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1885 for fringe update unless it has periodic bitmap.
1886
1887 2011-05-25 Kenichi Handa <handa@m17n.org>
1888
1889 * xdisp.c (get_next_display_element): Set correct it->face_id for
1890 a static composition.
1891
1892 2011-05-24 Leo Liu <sdl.web@gmail.com>
1893
1894 * deps.mk (fns.o):
1895 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1896
1897 * fns.c (crypto_hash_function, Fsha1): New function.
1898 (Fmd5): Use crypto_hash_function.
1899 (syms_of_fns): Add Ssha1.
1900
1901 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1902
1903 * gnutls.c: Remove unused macros.
1904 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1905 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1906 Remove macros that are defined and never used.
1907 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1908
1909 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1910
1911 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1912 (Fx_get_selection_internal): Minor cleanup.
1913 (Fx_own_selection_internal): Rename arguments for consistency with
1914 select.el.
1915
1916 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1917
1918 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1919
1920 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1921
1922 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1923
1924 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1925
1926 * dispnew.c (scrolling_window): Don't exclude the case that the
1927 last enabled row in the desired matrix touches the bottom boundary.
1928
1929 2011-05-21 Glenn Morris <rgm@gnu.org>
1930
1931 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1932 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1933 and add some more files.
1934
1935 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1936
1937 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1938 report_file_error introduced by the change from 2011-05-07.
1939
1940 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1941
1942 * systime.h (Time): Define only if emacs is defined.
1943 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1944 where the include path doesn't have X11/X.h by default. See
1945 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1946
1947 2011-05-20 Kenichi Handa <handa@m17n.org>
1948
1949 * composite.c (find_automatic_composition): Fix previous change.
1950
1951 2011-05-20 Glenn Morris <rgm@gnu.org>
1952
1953 * lisp.mk: New file, split from Makefile.in.
1954 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1955 (shortlisp): Remove.
1956 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1957
1958 2011-05-19 Glenn Morris <rgm@gnu.org>
1959
1960 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1961 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1962 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1963 (lisp): Set the order to that of loadup.el.
1964 (shortlisp): Make it a copy of $lisp.
1965 (SOME_MACHINE_LISP): Remove.
1966 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1967 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1968
1969 2011-05-18 Kenichi Handa <handa@m17n.org>
1970
1971 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1972 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1973 (find_automatic_composition): Mostly rewrite for efficiency.
1974
1975 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1976
1977 * makefile.w32-in: Update dependencies.
1978
1979 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1980
1981 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1982 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1983
1984 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1985
1986 Fix some integer overflow issues, such as string length overflow.
1987
1988 * insdel.c (count_size_as_multibyte): Check for string overflow.
1989
1990 * character.c (lisp_string_width): Check for string overflow.
1991 Use EMACS_INT, not int, for string indexes and lengths; in
1992 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1993 the resulting string length overflows an EMACS_INT; instead,
1994 report a string overflow if no precision given. When checking for
1995 precision exhaustion, use a check that cannot possibly have
1996 integer overflow. (Bug#8675)
1997 * character.h (lisp_string_width): Adjust to new signature.
1998
1999 * alloc.c (string_overflow): New function.
2000 (Fmake_string): Use it. This doesn't change behavior, but saves
2001 a few bytes and will simplify future changes.
2002 * character.c (string_escape_byte8): Likewise.
2003 * lisp.h (string_overflow): New decl.
2004
2005 Fixups, following up to the user-interface timestamp change.
2006 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2007 for UI timestamps, instead of unsigned long.
2008 * msdos.c (mouse_get_pos): Likewise.
2009 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2010 * w32gui.h (Time): Define by including "systime.h" rather than by
2011 declaring it ourselves. (Bug#8664)
2012
2013 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2014 * image.c (clear_image_cache): Likewise.
2015
2016 * term.c (term_mouse_position): Don't assume time_t wraparound.
2017
2018 Be more systematic about user-interface timestamps.
2019 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2020 and sometimes 'EMACS_UINT', to represent these timestamps.
2021 This change causes it to use 'Time' uniformly, as that's what X uses.
2022 This makes the code easier to follow, and makes it easier to catch
2023 integer overflow bugs such as Bug#8664.
2024 * frame.c (Fmouse_position, Fmouse_pixel_position):
2025 Use Time, not unsigned long, for user-interface timestamps.
2026 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2027 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2028 * keyboard.h (last_event_timestamp): Likewise.
2029 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2030 * menu.h (xmenu_show): Likewise.
2031 * term.c (term_mouse_position): Likewise.
2032 * termhooks.h (struct input_event.timestamp): Likewise.
2033 (struct terminal.mouse_position_hook): Likewise.
2034 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2035 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2036 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2037 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2038 what it was before.
2039 * menu.h, termhooks.h: Include "systime.h", for Time.
2040
2041 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2042 Don't assume that the difference between two unsigned long values
2043 can fit into an integer. At this point, we know button_down_time
2044 <= event->timestamp, so the difference must be nonnegative, so
2045 there's no need to cast the result if double-click-time is
2046 nonnegative, as it should be; check that it's nonnegative, just in
2047 case. This bug is triggered when events are more than 2**31 ms
2048 apart (about 25 days). (Bug#8664)
2049
2050 * xselect.c (last_event_timestamp): Remove duplicate decl.
2051 (x_own_selection): Remove needless cast to unsigned long.
2052
2053 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2054 that always fit in int. Use a sentinel instead of a counter, to
2055 avoid a temp and to allay GCC's concerns about possible int overflow.
2056 * frame.h (struct frame): Use int for menu_bar_items_used
2057 instead of EMACS_INT, since it always fits in int.
2058
2059 * menu.c (grow_menu_items): Check for int overflow.
2060
2061 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2062
2063 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2064 Before, the code was not consistent. These values cannot exceed
2065 2**31 - 1 so there's no need to make them unsigned.
2066 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2067 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2068 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2069 as modifiers.
2070 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2071
2072 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2073 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2074 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2075 presumably because the widths might not match.
2076
2077 * window.c (size_window): Avoid needless test at loop start.
2078
2079 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2080
2081 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2082
2083 2011-05-12 Drew Adams <drew.adams@oracle.com>
2084
2085 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2086
2087 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2088
2089 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2090 `width' to `bar_area_x' and `bar_area_width', respectively.
2091 (x_scroll_run): Take account of fringe background extension.
2092
2093 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2094 Rename local vars `left' and `width' to `bar_area_x' and
2095 `bar_area_width', respectively.
2096 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2097 background extension.
2098
2099 2011-05-10 Jim Meyering <meyering@redhat.com>
2100
2101 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2102
2103 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2104
2105 * image.c (Finit_image_library): Return t for built-in image types,
2106 like pbm and xbm. (Bug#8640)
2107
2108 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2109
2110 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2111
2112 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2113
2114 * w32console.c (Fset_screen_color): Doc fix.
2115 (Fget_screen_color): New function.
2116 (syms_of_ntterm): Defsubr it.
2117
2118 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2119 unlink the temporary file if Fcall_process didn't create it in the
2120 first place.
2121 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2122 child process will be redirected to a file specified with `:file'.
2123 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2124 cue to call_process_cleanup not to close that handle.
2125
2126 2011-05-07 Ben Key <bkey76@gmail.com>
2127
2128 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2129 one of two shell specific rules, either bootstrap-temacs-CMD or
2130 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2131 to the previous implementation of the bootstrap-temacs rule.
2132 The bootstrap-temacs-CMD rule is similar to the previous
2133 implementation of the bootstrap-temacs rule except that it
2134 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2135 variable.
2136
2137 These changes, along with some changes to nt/configure.bat,
2138 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2139 earlier fix to add support for --cflags and --ldflags options
2140 that include quotes so that it works whether make uses cmd or
2141 sh as the shell.
2142
2143 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2144
2145 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2146 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2147 is a constant.
2148 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2149 a string. Handle both cases.
2150 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2151 (Fdbus_register_method): Use Qinvalid_function.
2152
2153 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2154
2155 * makefile.w32-in: Update dependencies.
2156 (LISP_H): Add inttypes.h and stdin.h.
2157 (PROCESS_H): Add unistd.h.
2158
2159 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2160
2161 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2162 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2163
2164 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2165
2166 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2167
2168 * term.c (vfatal): Remove stray call to va_end.
2169 It's not needed and the C Standard doesn't allow it here anyway.
2170
2171 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2172 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2173
2174 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2175 bytes.
2176
2177 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2178
2179 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2180
2181 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2182
2183 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2184
2185 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2186
2187 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2188 * charset.c (Fdefine_charset_internal): Don't initialize
2189 charset.code_space[15]. The value was garbage, on hosts with
2190 32-bit int (Bug#8600).
2191
2192 * lread.c (read_integer): Be more consistent with string-to-number.
2193 Use string_to_number to do the actual conversion; this avoids
2194 rounding errors and fixes some other screwups. Without this fix,
2195 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2196 (digit_to_number): Move earlier, for benefit of read_integer.
2197 Return -1 if the digit is out of range for the base, -2 if it is
2198 not a digit in any supported base. (Bug#8602)
2199
2200 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2201
2202 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2203 to match comment at start of function. This also removes a
2204 GCC warning about overflow in a 32+64-bit port.
2205
2206 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2207
2208 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2209 Reported by Stefan Monnier in
2210 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2211 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2212 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2213
2214 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2215 (EMACS_UINTPTR): Likewise, with uintptr_t.
2216
2217 * lisp.h: Prefer 64-bit EMACS_INT if available.
2218 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2219 on 32-bit hosts that have 64-bit int, so that they can access
2220 large files.
2221 However, temporarily disable this change unless the temporary
2222 symbol WIDE_EMACS_INT is defined.
2223
2224 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2225
2226 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2227 This removes an assumption that EMACS_INT and long are the same
2228 width as pointers. The assumption is true for Emacs porting targets
2229 now, but we want to make other targets possible.
2230 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2231 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2232 In the rest of the code, change types of integers that hold casted
2233 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2234 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2235 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2236 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2237 No need to cast type when ORing.
2238 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2239 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2240 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2241 assume EMACS_INT is the same width as char *.
2242 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2243 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2244 Remove no-longer-needed casts.
2245 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2246 (xg_tool_bar_help_callback, xg_make_tool_item):
2247 Use EMACS_INTPTR to hold an integer
2248 that will be cast to void *; this can avoid a GCC warning
2249 if EMACS_INT is not the same width as void *.
2250 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2251 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2252 (current_message_1, set_message_1):
2253 Use a local to convert to proper width without a cast.
2254 * xmenu.c (dialog_selection_callback): Likewise.
2255
2256 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2257 Also, don't assume VALBITS / RAND_BITS is less than 5,
2258 and don't rely on undefined behavior when shifting a 1 left into
2259 the sign bit.
2260 * lisp.h (get_random): Change signature to match.
2261
2262 * lread.c (hash_string): Use size_t, not int, for hash computation.
2263 Normally we prefer signed values; but hashing is special, because
2264 it's better to use unsigned division on hash table sizes so that
2265 the remainder is nonnegative. Also, size_t is the natural width
2266 for hashing into memory. The previous code used 'int', which doesn't
2267 retain enough info to hash well into very large tables.
2268 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2269
2270 * dbusbind.c: Don't possibly lose pointer info when converting.
2271 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2272 Use XPNTR rather than XHASH, so that the high-order bits of
2273 the pointer aren't lost when converting through void *.
2274
2275 * eval.c (Fautoload): Don't double-shift a pointer.
2276
2277 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2278
2279 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2280
2281 * gnutls.c (DEF_GNUTLS_FN):
2282 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2283
2284 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2285
2286 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2287 marker. (Bug#8610)
2288
2289 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2290
2291 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2292 New version that can reserve upto 2GB of heap space.
2293
2294 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2295
2296 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2297
2298 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2299
2300 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2301 `gnutls_certificate_set_x509_key_file'.
2302
2303 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2304
2305 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2306 Update dependencies.
2307
2308 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2309
2310 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2311 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2312 Remove unused parameter `fildes'.
2313 * process.c (read_process_output, send_process): Don't pass it.
2314
2315 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2316
2317 Fix previous change: the library cache is defined in w32.c.
2318 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2319 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2320
2321 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2322
2323 Implement dynamic loading of GnuTLS on Windows.
2324
2325 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2326 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2327 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2328 Declare.
2329
2330 * gnutls.c (Qgnutls_dll): Define.
2331 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2332 (gnutls_*): Declare function pointers.
2333 (init_gnutls_functions): New function to initialize function pointers.
2334 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2335 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2336 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2337 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2338 (emacs_gnutls_write, emacs_gnutls_read)
2339 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2340 (Fgnutls_available_p): New function.
2341 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2342 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2343 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2344
2345 * image.c: Include w32.h.
2346 (Vimage_type_cache): Delete.
2347 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2348 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2349 (w32_delayed_load): Move to w32.c.
2350
2351 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2352
2353 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2354 (w32_delayed_load): Move from image.c. When loading a library, record
2355 its filename in the :loaded-from property of the library id.
2356 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2357 Initialize and staticpro them.
2358 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2359
2360 * process.c: Include lisp.h before w32.h, not after.
2361 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2362 instead of gnutls_record_check_pending.
2363
2364 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2365
2366 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2367
2368 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2369 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2370 as passed in.
2371
2372 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2373
2374 * xterm.c (x_set_frame_alpha): Do not set property on anything
2375 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2376
2377 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2378
2379 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2380
2381 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2382
2383 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2384 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2385 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2386 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2387 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2388 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2389 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2390 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2391 (Qgnutls_bootprop_callbacks_verify): Make static.
2392
2393 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2394
2395 * callproc.c: Indentation fixup.
2396
2397 * sysdep.c (wait_for_termination_1): Make static.
2398 (wait_for_termination, interruptible_wait_for_termination):
2399 Move after wait_for_termination_1.
2400
2401 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2402
2403 * sysdep.c (interruptible_wait_for_termination): New function
2404 which is like wait_for_termination, but allows keyboard
2405 interruptions.
2406
2407 * callproc.c (Fcall_process): Add (:file "file") as an option for
2408 the STDOUT buffer.
2409 (Fcall_process_region): Ditto.
2410
2411 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2412
2413 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2414 rather than `XVECTOR (FOO)->size'.
2415
2416 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2417 inttypes.h, as a gnulib replacement is used if it not available in
2418 system headers.
2419
2420 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2421
2422 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2423 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2424 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2425
2426 * coding.c (coding_alloc_by_realloc): Error out if destination
2427 will grow beyond MOST_POSITIVE_FIXNUM.
2428 (decode_coding_emacs_mule): Abort if there isn't enough place in
2429 charbuf for the composition carryover bytes. Reserve an extra
2430 space for up to 2 characters produced in a loop.
2431 (decode_coding_iso_2022): Abort if there isn't enough place in
2432 charbuf for the composition carryover bytes.
2433
2434 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2435
2436 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2437 aborting when %lld or %lll format is passed.
2438 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2439 %llo or %llx format is passed. (Bug#8545)
2440
2441 * window.c (window_scroll_line_based): Use a marker instead of
2442 simple variables to record original value of point. (Bug#7952)
2443
2444 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2445 produced by %s or %c overflows available buffer space. (Bug#8545)
2446
2447 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2448
2449 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2450 (SIZE_MAX): Move defn after all includes, as they might #define it.
2451
2452 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2453
2454 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2455
2456 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2457
2458 * keyboard.c (Qdelayed_warnings_hook): Define.
2459 (command_loop_1): Run `delayed-warnings-hook'
2460 if Vdelayed_warnings_list is non-nil.
2461 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2462 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2463
2464 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2465
2466 * doprnt.c (doprnt): Don't return value smaller than the buffer
2467 size if the message was truncated. (Bug#8545).
2468
2469 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2470
2471 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2472 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2473
2474 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2475
2476 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2477
2478 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2479
2480 * makefile.w32-in: Update dependencies.
2481
2482 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2483
2484 Improve `doprnt' and its usage. (Bug#8545)
2485 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2486 `format_end'. Remove support for %l as a conversion specifier.
2487 Don't use xrealloc. Improve diagnostics when the %l size modifier
2488 is used. Update the commentary.
2489
2490 * eval.c (verror): Simplify calculation of size_t.
2491
2492 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2493 messages.
2494
2495 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2496
2497 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2498 change.
2499
2500 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2501
2502 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2503 This makes this file independent of the recent pseudovector change.
2504
2505 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2506
2507 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2508
2509 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2510 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2511 Remove unused local.
2512 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2513
2514 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2515 GCC 4.6.0 optimizes based on type-based alias analysis.
2516 For example, if b is of type struct buffer * and v of type struct
2517 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2518 != &v->size, and therefore "v->size = 1; b->size = 2; return
2519 v->size;" must therefore return 1. This assumption is incorrect
2520 for Emacs, since it type-puns struct Lisp_Vector * with many other
2521 types. To fix this problem, this patch adds a new type struct
2522 vectorlike_header that documents the constraints on layout of vectors
2523 and pseudovectors, and helps optimizing compilers not get fooled
2524 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2525 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2526 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2527 the size member.
2528 (XSETPVECTYPE): Rewrite in terms of new macro.
2529 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2530 This is a bit clearer, and further avoids the possibility of
2531 undesirable aliasing.
2532 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2533 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2534 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2535 since Lisp_Subr is a special case (no "next" field).
2536 (ASIZE): Now uses header.size rather than size.
2537 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2538 to avoid the hassle of writing XVECTOR (foo)->header.size.
2539 (struct vectorlike_header): New type.
2540 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2541 object, to help avoid aliasing.
2542 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2543 (SUBRP): Likewise, since Lisp_Subr is a special case.
2544 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2545 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2546 (struct Lisp_Hash_Table): Combine first two members into a single
2547 struct vectorlike_header member. All uses of "size" and "next" members
2548 changed to be "header.size" and "header.next".
2549 * buffer.h (struct buffer): Likewise.
2550 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2551 * frame.h (struct frame): Likewise.
2552 * process.h (struct Lisp_Process): Likewise.
2553 * termhooks.h (struct terminal): Likewise.
2554 * window.c (struct save_window_data, struct saved_window): Likewise.
2555 * window.h (struct window): Likewise.
2556 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2557 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2558 * buffer.c (init_buffer_once): Likewise.
2559 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2560 special case.
2561 * process.c (Fformat_network_address): Use local var for size,
2562 for brevity.
2563
2564 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2565
2566 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2567 * data.c (atof): Remove decl; no longer used or needed.
2568 (digit_to_number): Move to lread.c.
2569 (Fstring_to_number): Use new string_to_number function, to be
2570 consistent with how the Lisp reader treats infinities and NaNs.
2571 Do not assume that floating-point numbers represent EMACS_INT
2572 without losing information; this is not true on most 64-bit hosts.
2573 Avoid double-rounding errors, by insisting on integers when
2574 parsing non-base-10 numbers, as the documentation specifies.
2575 * lisp.h (string_to_number): New decl, replacing ...
2576 (isfloat_string): Remove.
2577 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2578 (read1): Do not accept +. and -. as integers; this
2579 appears to have been a coding error. Similarly, do not accept
2580 strings like +-1e0 as floating point numbers. Do not report
2581 overflow for integer overflows unless the base is not 10 which
2582 means we have no simple and reliable way to continue.
2583 Break out the floating-point parsing into a new
2584 function string_to_number, so that Fstring_to_number parses
2585 floating point numbers consistently with the Lisp reader.
2586 (digit_to_number): Move here from data.c. Make it static inline.
2587 (E_CHAR, EXP_INT): Remove, replacing with ...
2588 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2589 (string_to_number): New function, replacing isfloat_string.
2590 This function checks for valid syntax and produces the resulting
2591 Lisp float number too. Rework it so that string-to-number
2592 no longer mishandles examples like "1.0e+". Use strtoumax,
2593 so that overflow for non-base-10 numbers is reported only when
2594 there's no portable and simple way to convert to floating point.
2595
2596 * textprop.c (set_text_properties_1): Rewrite for clarity,
2597 and to avoid GCC warning about integer overflow.
2598
2599 * intervals.h (struct interval): Use EMACS_INT for members
2600 where EMACS_UINT might cause problems. See
2601 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2602 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2603 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2604 All uses changed.
2605 (offset_intervals): Tell GCC not to worry about length overflow
2606 when negating a negative length.
2607
2608 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2609 (overrun_check_free): Likewise.
2610
2611 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2612 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2613 word size.
2614
2615 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2616 (gnutls_make_error): Rename local to avoid shadowing.
2617 (gnutls_emacs_global_deinit): ifdef out; not used.
2618 (Fgnutls_boot): Use const for pointer to readonly storage.
2619 Comment out unused local. Fix pointer signedness problems.
2620
2621 * lread.c (openp): Don't stuff size_t into an 'int'.
2622 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2623 about possible signed overflow.
2624
2625 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2626 (GDK_KEY_g): Don't define if already defined.
2627 (xg_prepare_tooltip): Avoid pointer signedness problem.
2628 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2629
2630 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2631 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2632
2633 * xfns.c (Fx_window_property): Simplify a bit,
2634 to make a bit faster and to avoid GCC 4.6.0 warning.
2635 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2636
2637 * fns.c (internal_equal): Don't assume size_t fits in int.
2638
2639 * alloc.c (compact_small_strings): Tighten assertion a little.
2640
2641 Replace pEd with more-general pI, and fix some printf arg casts.
2642 * lisp.h (pI): New macro, generalizing old pEd macro to other
2643 conversion specifiers. For example, use "...%"pI"d..." rather
2644 than "...%"pEd"...".
2645 (pEd): Remove. All uses replaced with similar uses of pI.
2646 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2647 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2648 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2649 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2650 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2651 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2652 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2653 64-bit hosts.
2654 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2655 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2656 * print.c (safe_debug_print, print_object): Likewise.
2657 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2658 to int.
2659 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2660 avoiding the 0 flag, which is not portable.
2661 * process.c (Fmake_network_process): Use pI to avoid cast.
2662 * region-cache.c (pp_cache): Likewise.
2663 * xdisp.c (decode_mode_spec): Likewise.
2664 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2665 behavior on 64-bit hosts with printf arg.
2666 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2667 (x_stop_queuing_selection_requests): Likewise.
2668 (x_get_window_property): Don't truncate byte count to an 'int'
2669 when tracing.
2670
2671 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2672 here, since it parses constructs like leading '-' and spaces,
2673 which are not wanted; and it overflows with large numbers.
2674 Instead, simply match F[0-9]+, which is what is wanted anyway.
2675
2676 * alloc.c: Remove unportable assumptions about struct layout.
2677 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2678 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2679 (allocate_vectorlike, make_pure_vector): Use the new macros,
2680 plus offsetof, to remove unportable assumptions about struct layout.
2681 These assumptions hold on all porting targets that I know of, but
2682 they are not guaranteed, they're easy to remove, and removing them
2683 makes further changes easier.
2684
2685 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2686 This doesn't fix a bug but makes the code clearer.
2687 (string_overrun_cookie): Now const. Use initializers that
2688 don't formally overflow signed char, to avoid warnings.
2689 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2690 can cause Emacs to crash when string overrun checking is enabled.
2691 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2692 multiple of sizeof (EMACS_INT); it need not be, if
2693 alignof(EMACS_INT) < sizeof (EMACS_INT).
2694 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2695
2696 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2697
2698 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2699
2700 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2701
2702 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2703 supposed to be handshaking. (Bug#8556)
2704 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2705
2706 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2707
2708 * lisp.h (Qdebug): List symbol.
2709 * eval.c (Qdebug): Restore global linkage.
2710 * keyboard.c (debug-on-event): New variable.
2711 (handle_user_signal): Break into debugger when debug-on-event
2712 matches the current signal symbol.
2713
2714 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2715
2716 * alloc.c (check_sblock, check_string_bytes)
2717 (check_string_free_list): Convert to standard C.
2718
2719 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2720
2721 * w32.c (emacs_gnutls_push): Fix typo.
2722
2723 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2724
2725 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2726 "cast to pointer from integer of different size".
2727
2728 Improve doprnt and its use in verror. (Bug#8545)
2729 * doprnt.c (doprnt): Document the set of format control sequences
2730 supported by the function. Use SAFE_ALLOCA instead of always
2731 using `alloca'.
2732
2733 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2734 is one byte too soon. Don't use xrealloc; instead xfree and
2735 xmalloc anew.
2736
2737 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2738
2739 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2740 callbacks stage.
2741
2742 * gnutls.c: Renamed global_initialized to
2743 gnutls_global_initialized. Added internals for the
2744 :verify-hostname-error, :verify-error, and :verify-flags
2745 parameters of `gnutls-boot' and documented those parameters in the
2746 docstring. Start callback support.
2747 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2748 unless a fatal error occured. Call gnutls_alert_send_appropriate
2749 on error. Return error code.
2750 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2751 (emacs_gnutls_read): Likewise.
2752 (Fgnutls_boot): Return handshake error code.
2753 (emacs_gnutls_handle_error): New function.
2754 (wsaerror_to_errno): Likewise.
2755
2756 * w32.h (emacs_gnutls_pull): Add prototype.
2757 (emacs_gnutls_push): Likewise.
2758
2759 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2760 (emacs_gnutls_push): Likewise.
2761
2762 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2763
2764 * process.c (wait_reading_process_output): Check if GnuTLS
2765 buffered some data internally if no FDs are set for TLS
2766 connections.
2767
2768 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2769 (LIBS): Link to USER_LIBS.
2770 ($(BLD)/gnutls.$(0)): New target.
2771
2772 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2773
2774 * xdisp.c (handle_single_display_spec): Rename the
2775 display_replaced_before_p argument into display_replaced_p, to
2776 make it consistent with the commentary. Fix typos in the
2777 commentary.
2778
2779 * textprop.c (syms_of_textprop): Remove dead code.
2780 (copy_text_properties): Delete obsolete commentary about an
2781 interface that was deleted long ago. Fix typos in the description
2782 of arguments.
2783
2784 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2785 to changes in oldXMenu/XMenu.h from 2011-04-16.
2786 <menu_help_message, prev_menu_help_message>: Constify.
2787 (IT_menu_make_room): menu->help_text is now `const char **';
2788 adjust.
2789
2790 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2791 to changes in oldXMenu/XMenu.h from 2011-04-16.
2792 (struct XMenu): Declare `help_text' `const char **'.
2793
2794 * xfaces.c <Qunspecified>: Make extern again.
2795
2796 * syntax.c: Include sys/types.h before including regex.h, as
2797 required by Posix.
2798
2799 * doc.c (get_doc_string): Improve the format passed to `error'.
2800
2801 * doprnt.c (doprnt): Improve commentary.
2802
2803 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2804
2805 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2806 them with etags.
2807
2808 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2809 changes in globals.h immediately force recompilation.
2810 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2811 $(CURDIR)/s/ms-w32.h.
2812 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2813
2814 * character.c (Fchar_direction): Function deleted.
2815 (syms_of_character): Don't defsubr it.
2816 <char-direction-table>: Deleted.
2817
2818 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2819
2820 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2821 * doprnt.c: Include limits.h.
2822 (SIZE_MAX): New macro.
2823 (doprnt): Return a size_t value. 2nd arg is now size_t.
2824 Many local variables are now size_t instead of int or unsigned.
2825 Improve overflow protection. Support `l' modifier for integer
2826 conversions. Support %l conversion. Don't assume an EMACS_INT
2827 argument for integer conversions and for %c.
2828
2829 * lisp.h (doprnt): Restore prototype.
2830
2831 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2832 $(SRC)/character.h.
2833
2834 * Makefile.in (base_obj): Add back doprnt.o.
2835
2836 * deps.mk (doprnt.o): Add back prerequisites.
2837 (callint.o): Depend on character.h.
2838
2839 * eval.c (internal_lisp_condition_case): Include the handler
2840 representation in the error message.
2841 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2842 when breaking from the loop.
2843
2844 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2845
2846 * callint.c (Fcall_interactively): When displaying error message
2847 about invalid control letter, pass the character's codepoint, not
2848 a pointer to its multibyte form. Improve display of the character
2849 in octal and display also its hex code.
2850
2851 * character.c (char_string): Use %x to display the (unsigned)
2852 codepoint of an invalid character, to avoid displaying a bogus
2853 negative value.
2854
2855 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2856 `error', not SYMBOL_NAME itself.
2857
2858 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2859 character arguments to `error'.
2860
2861 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2862 to `error' in error message about FINAL_CHAR argument. Make sure
2863 FINAL_CHAR is a character, and use %c when it is passed as
2864 argument to `error'.
2865
2866 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2867
2868 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2869
2870 * w32.c: Include <time.h>.
2871 (sys_localtime): New function.
2872
2873 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2874
2875 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2876
2877 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2878
2879 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2880
2881 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2882 zombies (Bug#8467).
2883
2884 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2885
2886 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2887 gl_state.e_property when gl_state.object is Qt.
2888
2889 * insdel.c (make_gap_larger): Remove limitation of buffer size
2890 to <= INT_MAX.
2891
2892 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2893
2894 * xdisp.c (lookup_glyphless_char_display)
2895 (produce_glyphless_glyph): Handle cons cell entry in
2896 glyphless-char-display.
2897 (Vglyphless_char_display): Document it.
2898
2899 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2900 glyphless-char-display.
2901
2902 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2903
2904 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2905
2906 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2907
2908 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2909 definition for no-X builds.
2910
2911 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2912
2913 Static checks with GCC 4.6.0 and non-default toolkits.
2914
2915 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2916
2917 * process.c (keyboard_bit_set): Define only if SIGIO.
2918 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2919 (send_process): Repair possible setjmp clobbering.
2920
2921 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2922
2923 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2924
2925 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2926
2927 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2928 Define only if needed.
2929
2930 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2931 by pacifying GCC about it. Maybe it's time to retire it?
2932 * xfaces.c (USG, __TIMEVAL__): Likewise.
2933
2934 * dispextern.h (struct redisplay_interface): Rename param
2935 to avoid shadowing.
2936 * termhooks.h (struct terminal): Likewise.
2937 * xterm.c (xembed_send_message): Likewise.
2938
2939 * insdel.c (make_gap_smaller): Define only if
2940 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2941
2942 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2943 it.
2944
2945 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2946 so that we aren't warned about unused symbols.
2947
2948 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2949
2950 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2951
2952 * xfns.c (x_real_positions): Mark locals as initialized.
2953
2954 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2955
2956 * xterm.c: Fix problems found by static analysis with other toolkits.
2957 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2958 (x_dispatch_event): Declare static if USE_GTK, and
2959 define if USE_GTK || USE_X_TOOLKIT.
2960 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2961 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2962 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2963 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2964
2965 * xmenu.c (menu_help_callback): Pointer type fixes.
2966 Use const pointers when pointing at readonly data. Avoid pointer
2967 signedness clashes.
2968 (FALSE): Remove unused macro.
2969 (update_frame_menubar): Remove unused decl.
2970
2971 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2972
2973 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2974 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2975 (single_menu_item): Rename local to avoid shadowing.
2976
2977 * keyboard.c (make_lispy_event): Remove unused local var.
2978
2979 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2980 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2981
2982 * bitmaps: Change bitmaps from unsigned char back to the X11
2983 compatible char. Avoid the old compiler warnings about
2984 out-of-range initializers by using, for example, '\xab' rather
2985 than 0xab.
2986
2987 * xgselect.c (xgselect_initialize): Check vs interface
2988 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2989
2990 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2991
2992 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2993 to read-only memory.
2994
2995 * fns.c (vector): Remove; this old hack is no longer needed.
2996
2997 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2998 Remove unused var.
2999 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3000
3001 * xrdb.c (x_load_resources): Omit unused local.
3002
3003 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3004 (x_window): Rename locals to avoid shadowing.
3005 (USG): Use the kludged USG macro, to pacify gcc.
3006
3007 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3008 (x_term_init): Remove local to avoid shadowing.
3009
3010 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3011
3012 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3013 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3014
3015 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3016
3017 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3018
3019 Fix regex.c, syntax.c and friends for buffers > 2GB.
3020 * syntax.h (struct gl_state_s): Declare character position members
3021 EMACS_INT.
3022
3023 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3024
3025 * textprop.c (verify_interval_modification, interval_of):
3026 Declare arguments EMACS_INT.
3027
3028 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3029 EMACS_INT.
3030
3031 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3032
3033 * indent.c (Fvertical_motion): Local variable it_start is now
3034 EMACS_INT.
3035
3036 * regex.c (re_match, re_match_2, re_match_2_internal)
3037 (bcmp_translate, regcomp, regexec, print_double_string)
3038 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3039 (re_compile_pattern, re_exec): Declare arguments and local
3040 variables `size_t' and `ssize_t' and return values `regoff_t', as
3041 appropriate.
3042 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3043 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3044 <compile_stack_type>: `size' and `avail' are now `size_t'.
3045
3046 * regex.h <regoff_t>: Use ssize_t, not int.
3047 (re_search, re_search_2, re_match, re_match_2): Arguments that
3048 specify buffer/string position and length are now ssize_t and
3049 size_t. Return type is regoff_t.
3050
3051 2011-04-16 Ben Key <bkey76@gmail.com>
3052
3053 * nsfont.m: Fixed bugs in ns_get_family and
3054 ns_descriptor_to_entity that were caused by using free to
3055 deallocate memory blocks that were allocated by xmalloc (via
3056 xstrdup). This caused Emacs to crash when compiled with
3057 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3058 --enable-checking=xmallocoverrun). xfree is now used to
3059 deallocate these memory blocks.
3060
3061 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3062
3063 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3064
3065 emacs_write: Accept and return EMACS_INT for sizes.
3066 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3067 et seq.
3068 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3069 Accept and return EMACS_INT.
3070 (emacs_gnutls_write): Return the number of bytes written on
3071 partial writes.
3072 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3073 (emacs_read, emacs_write): Remove check for negative size, as the
3074 Emacs source code has been audited now.
3075 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3076 (emacs_read, emacs_write): Use it.
3077 * process.c (send_process): Adjust to the new signatures of
3078 emacs_write and emacs_gnutls_write. Do not attempt to store
3079 a byte offset into an 'int'; it might overflow.
3080 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3081
3082 * sound.c: Don't assume sizes fit in 'int'.
3083 (struct sound_device.period_size, alsa_period_size):
3084 Return EMACS_INT, not int.
3085 (struct sound_device.write, vox_write, alsa_write):
3086 Accept EMACS_INT, not int.
3087 (wav_play, au_play): Use EMACS_INT to store sizes and to
3088 record read return values.
3089
3090 2011-04-15 Ben Key <bkey76@gmail.com>
3091
3092 * keyboard.c (Qundefined): Don't declare static since it is used
3093 in nsfns.m.
3094 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3095 static since they are used in nsfont.m.
3096
3097 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3098
3099 * process.c (Qprocessp): Don't declare static.
3100 * lisp.h (Qprocessp): Declare again.
3101
3102 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3103
3104 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3105
3106 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3107
3108 Improve C-level modularity by making more things 'static'.
3109
3110 Don't publish debugger-only interfaces to other modules.
3111 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3112 (verify_bytepos, count_markers): Move decls to the only modules
3113 that need them.
3114 * region-cache.h (pp_cache): Likewise.
3115 * window.h (check_all_windows): Likewise.
3116 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3117
3118 * sysdep.c (croak): Now static, if
3119 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3120 * syssignal.h (croak): Declare only if not static.
3121
3122 * alloc.c (refill_memory_reserve): Now static if
3123 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3124 * lisp.h (refill_memory_reserve): Declare only if not static.
3125
3126 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3127 Define only if USE_LUCID.
3128
3129 * xrdb.c (x_customization_string, x_rm_string): Now static.
3130
3131 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3132 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3133
3134 * xdisp.c (draw_row_with_mouse_face): Now static.
3135 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3136
3137 * window.h (check_all_windows): Mark externally visible.
3138
3139 * window.c (window_deletion_count): Now static.
3140
3141 * undo.c: Make symbols static if they're not exported.
3142 (last_undo_buffer, last_boundary_position, pending_boundary):
3143 Now static.
3144
3145 * textprop.c (interval_insert_behind_hooks): Now static.
3146 (interval_insert_in_front_hooks): Likewise.
3147
3148 * term.c: Make symbols static if they're not exported.
3149 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3150 (max_frame_lines, tty_set_terminal_modes):
3151 (tty_reset_terminal_modes, tty_turn_off_highlight):
3152 (get_tty_terminal): Now static.
3153 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3154 * termhooks.h (term_mouse_moveto): Do not declare if
3155 HAVE_WINDOW_SYSTEM.
3156 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3157 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3158
3159 * sysdep.c: Make symbols static if they're not exported.
3160 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3161 Now static.
3162 (sigprocmask_set, full_mask): Remove; unused.
3163 (wait_debugging): Mark as visible.
3164 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3165 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3166
3167 * syntax.c (syntax_temp): Define only if !__GNUC__.
3168
3169 * sound.c (current_sound_device, current_sound): Now static.
3170
3171 * search.c (searchbufs, searchbuf_head): Now static.
3172
3173 * scroll.c (scroll_cost): Remove; unused.
3174 * dispextern.h (scroll_cost): Remove decl.
3175
3176 * region-cache.h (pp_cache): Mark as externally visible.
3177
3178 * process.c: Make symbols static if they're not exported.
3179 (process_tick, update_tick, create_process, chan_process):
3180 (Vprocess_alist, proc_buffered_char, datagram_access):
3181 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3182 (deactivate_process): Mark defn as static, as well as decl.
3183 * lisp.h (create_process): Remove decl.
3184 * process.h (chan_process, Vprocess_alist): Remove decls.
3185
3186 * print.c: Make symbols static if they're not exported.
3187 (print_depth, new_backquote_output, being_printed, print_buffer):
3188 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3189 (print_interval, print_number_index, initial_stderr_stream):
3190 Now static.
3191 * lisp.h (Fprinc): Remove decl.
3192 (debug_output_compilation_hack): Mark as externally visible.
3193
3194 * sysdep.c (croak): Move decl from here to syssignal.h.
3195 * syssignal.h (croak): Put it here, so the API can be checked when
3196 'croak' is called from dissociate_if_controlling_tty.
3197
3198 * minibuf.c: Make symbols static if they're not exported.
3199 (minibuf_save_list, choose_minibuf_frame): Now static.
3200 * lisp.h (choose_minibuf_frame): Remove decl.
3201
3202 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3203
3204 * lread.c: Make symbols static if they're not exported.
3205 (read_objects, initial_obarray, oblookup_last_bucket_number):
3206 Now static.
3207 (make_symbol): Remove; unused.
3208 * lisp.h (initial_obarray, make_symbol): Remove decls.
3209
3210 * keyboard.c: Make symbols static if they're not exported.
3211 (single_kboard, recent_keys_index, total_keys, recent_keys):
3212 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3213 (this_single_command_key_start, echoing, last_auto_save):
3214 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3215 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3216 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3217 (Vlispy_mouse_stem, double_click_count):
3218 Now static.
3219 (force_auto_save_soon): Define only if SIGDANGER.
3220 (ignore_mouse_drag_p): Now static if
3221 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3222 (print_help): Remove; unused.
3223 (stop_character, last_timer_event): Mark as externally visible.
3224 * keyboard.h (ignore_mouse_drag_p): Declare only if
3225 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3226 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3227 * lisp.h (echoing): Remove decl.
3228 (force_auto_save_soon): Declare only if SIGDANGER.
3229 * xdisp.c (redisplay_window): Simplify code, to make it more
3230 obvious that ignore_mouse_drag_p is not accessed if !defined
3231 USE_GTK && !defined HAVE_NS.
3232
3233 * intervals.c: Make symbols static if they're not exported.
3234 (merge_properties_sticky, merge_interval_right, delete_interval):
3235 Now static.
3236 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3237
3238 * insdel.c: Make symbols static if they're not exported.
3239 However, leave prepare_to_modify_buffer alone. It's never
3240 called from outside this function, but that appears to be a bug.
3241 (combine_after_change_list, combine_after_change_buffer):
3242 (adjust_after_replace, signal_before_change): Now static.
3243 (adjust_after_replace_noundo): Remove; unused.
3244 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3245 (signal_before_change): Remove decls.
3246
3247 * indent.c (val_compute_motion, val_vmotion): Now static.
3248
3249 * image.c: Make symbols static if they're not exported.
3250 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3251 if USE_GTK.
3252 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3253 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3254
3255 * fringe.c (standard_bitmaps): Now static.
3256 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3257
3258 * frame.c: Make symbols static if they're not exported.
3259 (x_report_frame_params, make_terminal_frame): Now static.
3260 (get_frame_param): Now static, unless HAVE_NS.
3261 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3262 (x_get_resource_string): Remove; not used.
3263 * frame.h (make_terminal_frame, x_report_frame_params):
3264 (x_get_resource_string); Remove decls.
3265 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3266 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3267
3268 * font.c, fontset.c: Make symbols static if they're not exported.
3269 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3270 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3271 * font.c (font_close_object): Now static.
3272 * font.h (font_close_object): Remove.
3273 * fontset.c (FONTSET_OBJLIST): Remove.
3274 (free_realized_fontset) #if-0 the body, which does nothing.
3275 (face_suitable_for_char_p): #if-0, as it's never called.
3276 * fontset.h (face_suitable_for_char_p): Remove decl.
3277 * xfaces.c (face_at_string_position):
3278 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3279 since 0 is always ASCII.
3280
3281 * fns.c (weak_hash_tables): Now static.
3282
3283 * fileio.c: Make symbols static if they're not exported.
3284 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3285 (Vwrite_region_annotation_buffers): Now static.
3286
3287 * eval.c: Make symbols static if they're not exported.
3288 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3289 * lisp.h (backtrace_list): Remove decl.
3290
3291 * emacs.c: Make symbols static if they're not exported.
3292 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3293 (fatal_error_code, fatal_error_signal_hook, standard_args):
3294 Now static.
3295 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3296 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3297 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3298 * lisp.h (fatal_error_signal_hook): Remove decl.
3299 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3300
3301 * editfns.c: Move a (normally-unused) function to its only use.
3302 * editfns.c, lisp.h (get_operating_system_release): Remove.
3303 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3304 worth the hassle of breaking this out.
3305
3306 * xterm.c: Make symbols static if they're not exported.
3307 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3308 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3309 (x_destroy_window, x_delete_display):
3310 Now static.
3311 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3312 (x_mouse_leave): Remove; unused.
3313 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3314 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3315 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3316 Remove decls.
3317 (x_mouse_leave): Declare only if WINDOWSNT.
3318 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3319 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3320 USE_X_TOOLKIT.
3321
3322 * ftxfont.c: Make symbols static if they're not exported.
3323 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3324 HAVE_FREETYPE.
3325 * font.h (ftxfont_driver): Likewise.
3326
3327 * xfns.c: Make symbols static if they're not exported.
3328 (x_last_font_name, x_display_info_for_name):
3329 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3330 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3331 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3332 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3333 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3334 (last_show_tip_args): Now static.
3335 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3336 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3337 (x_screen_planes): Remove; unused.
3338 * dispextern.h (x_screen_planes): Remove decl.
3339
3340 * dispnew.c: Make symbols static if they're not exported.
3341 * dispextern.h (redraw_garbaged_frames, scrolling):
3342 (increment_row_positions): Remove.
3343 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3344 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3345 Now static.
3346 (redraw_garbaged_frames): Remove; unused.
3347
3348 * xfaces.c: Make symbols static if they're not exported.
3349 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3350 Remove decls.
3351 * xterm.h (defined_color): Remove decls.
3352 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3353 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3354 (menu_face_changed_default, defined_color, free_realized_face):
3355 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3356 (ascii_face_of_lisp_face): Remove; unused.
3357
3358 * xdisp.c: Make symbols static if they're not exported.
3359 * dispextern.h (scratch_glyph_row, window_box_edges):
3360 (glyph_to_pixel_coords, set_cursor_from_row):
3361 (get_next_display_element, set_iterator_to_next):
3362 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3363 (show_mouse_face): Remove decls
3364 * frame.h (message_buf_print): Likewise.
3365 * lisp.h (pop_message, set_message, check_point_in_composition):
3366 Likewise.
3367 * xterm.h (set_vertical_scroll_bar): Likewise.
3368 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3369 (message_buf_print, scratch_glyph_row, displayed_buffer):
3370 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3371 (get_next_display_element, show_mouse_face, window_box_edges):
3372 (frame_to_window_pixel_xy, check_point_in_composition):
3373 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3374 (glyph_to_pixel_coords): Remove; unused.
3375
3376 * dired.c (file_name_completion): Now static.
3377
3378 * dbusbind.c (xd_in_read_queued_messages): Now static.
3379
3380 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3381 * data.c (circular_list_error): Remove.
3382
3383 * commands.h (last_point_position, last_point_position_buffer):
3384 (last_point_position_window): Remove decls.
3385 * keyboard.c: Make these variables static.
3386
3387 * coding.h (coding, code_convert_region, encode_coding_gap):
3388 Remove decls.
3389 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3390 (iso_code_class, detect_coding, code_convert_region): Now static.
3391 (encode_coding_gap): Remove; unused.
3392
3393 * chartab.c (chartab_chars, chartab_bits): Now static.
3394
3395 * charset.h (charset_iso_8859_1): Remove decl.
3396 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3397 Now static.
3398
3399 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3400 * ccl.c (Vccl_program_table): Now static.
3401 (check_ccl_update): Remove; unused.
3402
3403 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3404 * category.h: ... from here.
3405 * category.c (check_category_table, set_category_set): Now static.
3406
3407 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3408 * lisp.h: Remove these decls.
3409
3410 * buffer.c (buffer_count): Remove unused var.
3411
3412 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3413 so that it's not optimized away.
3414 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3415 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3416 exported only to the debugger.
3417
3418 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3419 * atimer.h (run_all_atimers): Remove; not exported.
3420
3421 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3422 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3423 was inaccessible from Lisp.
3424 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3425 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3426
3427 alloc.c: Import and export fewer symbols, and remove unused items.
3428 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3429 is defined.
3430 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3431 it's not optimized away by whole-program optimization.
3432 (message_enable_multibyte, free_misc): Remove.
3433 (catchlist, handlerlist, mark_backtrace):
3434 Declare only if BYTE_MARK_STACK.
3435 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3436 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3437 (message_enable_multibyte): Remove decl.
3438 (free_misc, interval_free_list, float_block, float_block_index):
3439 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3440 (cons_free_list, last_marked_index):
3441 Now static.
3442 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3443 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3444 (mark_backtrace): Define only if BYTE_MARK_STACK.
3445 * xdisp.c (message_enable_multibyte): Now static.
3446
3447 Declare Lisp_Object Q* variables to be 'static' if not exported.
3448 This makes it easier for human readers (and static analyzers)
3449 to see whether these variables are used from other modules.
3450 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3451 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3452 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3453 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3454 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3455 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3456 * xmenu.c, xselect.c:
3457 Declare Q* vars static if they are not used in other modules.
3458 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3459 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3460 Remove decls of unexported vars.
3461 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3462
3463 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3464
3465 Make Emacs functions such as Fatom 'static' by default.
3466 This makes it easier for human readers (and static analyzers)
3467 to see whether these functions can be called from other modules.
3468 DEFUN now defines a static function. To make the function external
3469 so that it can be used in other C modules, use the new macro DEFUE.
3470 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3471 (Finit_image_library):
3472 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3473 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3474 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3475 Remove decls, since these functions are now static.
3476 (Funintern, Fget_internal_run_time): New decls, since these functions
3477 were already external.
3478
3479 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3480 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3481 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3482 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3483 * keyboard.c, keymap.c, lread.c:
3484 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3485 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3486 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3487 Mark functions with DEFUE instead of DEFUN,
3488 if they are used in other modules.
3489 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3490 decls for now-static functions.
3491 * buffer.h (Fdelete_overlay): Remove decl.
3492 * callproc.c (Fgetenv_internal): Mark as internal.
3493 * composite.c (Fremove_list_of_text_properties): Remove decl.
3494 (Fcomposition_get_gstring): New forward static decl.
3495 * composite.h (Fcomposite_get_gstring): Remove decl.
3496 * dired.c (Ffile_attributes): New forward static decl.
3497 * doc.c (Fdocumntation_property): New forward static decl.
3498 * eval.c (Ffetch_bytecode): New forward static decl.
3499 (Funintern): Remove extern decl; now in .h file where it belongs.
3500 * fileio.c (Fmake_symbolic_link): New forward static decl.
3501 * image.c (Finit_image_library): New forward static decl.
3502 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3503 * intervals.h (Fprevious_property_change):
3504 (Fremove_list_of_text_properties): Remove decls.
3505 * keyboard.c (Fthis_command_keys): Remove decl.
3506 (Fcommand_execute): New forward static decl.
3507 * keymap.c (Flookup_key): New forward static decl.
3508 (Fcopy_keymap): Now static.
3509 * keymap.h (Flookup_key): Remove decl.
3510 * process.c (Fget_process): New forward static decl.
3511 (Fprocess_datagram_address): Mark as internal.
3512 * syntax.c (Fsyntax_table_p): New forward static decl.
3513 (skip_chars): Remove duplicate decl.
3514 * textprop.c (Fprevious_property_change): New forward static decl.
3515 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3516 Now internal.
3517 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3518 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3519
3520 * editfns.c (Fformat): Remove unreachable code.
3521
3522 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3523
3524 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3525 change. (Bug#8496)
3526
3527 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3528
3529 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3530 when at ZV. (Bug#8487)
3531
3532 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3533
3534 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3535 (Bug#8437)
3536 * keyboard.c (parse_tool_bar_item): Likewise.
3537 * sound.c (sound_cleanup, alsa_close): Likewise.
3538 * termcap.c (tgetent): Likewise.
3539 * xfns.c (x_default_font_parameter): Likewise.
3540 * xsettings.c (read_and_apply_settings): Likewise.
3541
3542 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3543 (overrun_check_free): Protoize.
3544
3545 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3546
3547 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3548 since callers should never pass a negative size.
3549 Change the signature to match that of plain 'read' and 'write'; see
3550 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3551 * lisp.h: Update prototypes of emacs_write and emacs_read.
3552
3553 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3554
3555 * xdisp.c (redisplay_window): Don't try to determine the character
3556 position of the scroll margin if the window start point w->startp
3557 is outside the buffer's accessible region. (Bug#8468)
3558
3559 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3560
3561 Fix write-region and its subroutines for buffers > 2GB.
3562 * fileio.c (a_write, e_write): Modify declaration of arguments and
3563 local variables to support buffers larger than 2GB.
3564 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3565
3566 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3567 argument, local variables, and return value.
3568
3569 * lisp.h: Update prototypes of emacs_write and emacs_read.
3570
3571 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3572
3573 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3574
3575 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3576
3577 Fix more problems found by GCC 4.6.0's static checks.
3578
3579 * xdisp.c (vmessage): Use a better test for character truncation.
3580
3581 * charset.c (load_charset_map): <, not <=, for optimization,
3582 and to avoid potential problems with integer overflow.
3583 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3584 * casetab.c (set_identity, shuffle): Likewise.
3585 * editfns.c (Fformat): Likewise.
3586 * syntax.c (skip_chars): Likewise.
3587
3588 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3589 This also lets GCC 4.6.0 generate slightly better loop code.
3590
3591 * callint.c (Fcall_interactively): <, not <=, for optimization.
3592 (Fcall_interactively): Count the number of arguments produced,
3593 not the number of arguments given. This is simpler and lets GCC
3594 4.6.0 generate slightly better code.
3595
3596 * ftfont.c: Distingish more carefully between FcChar8 and char.
3597 The previous code passed unsigned char * to a functions like
3598 strlen and xstrcasecmp that expect char *, which does not
3599 conform to the C standard.
3600 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3601 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3602 char * when the C standard requires it.
3603
3604 * keyboard.c (read_char): Remove unused var.
3605
3606 * eval.c: Port to Windows vsnprintf (Bug#8435).
3607 Include <limits.h>.
3608 (SIZE_MAX): Define if the headers do not.
3609 (verror): Do not give up if vsnprintf returns a negative count.
3610 Instead, grow the buffer. This ports to Windows vsnprintf, which
3611 does not conform to C99. Problem reported by Eli Zaretskii.
3612 Also, simplify the allocation scheme, by avoiding the need for
3613 calling realloc, and removing the ALLOCATED variable.
3614
3615 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3616
3617 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3618 But keep the doprint source code for now, as we might revamp it
3619 and use it again (Bug#8435).
3620 * lisp.h (doprnt): Remove.
3621 * Makefile.in (base_obj): Remove doprnt.o.
3622 * deps.mk (doprnt.o): Remove.
3623
3624 error: Print 32- and 64-bit integers portably (Bug#8435).
3625 Without this change, on typical 64-bit hosts error ("...%d...", N)
3626 was used to print both 32- and 64-bit integers N, which relied on
3627 undefined behavior.
3628 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3629 New macro.
3630 * lisp.h (error, verror): Mark as printf-like functions.
3631 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3632 Report overflow in size calculations when allocating printf buffer.
3633 Do not truncate output string at its first null byte.
3634 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3635 Truncate the output at a character boundary, since vsnprintf does not
3636 do that.
3637 * charset.c (check_iso_charset_parameter): Convert internal
3638 character to string before calling 'error', since %c now has the
3639 printf meaning.
3640 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3641 overflow when computing char to be passed to 'error'. Do not
3642 pass Lisp_Object to 'error'; pass the integer instead.
3643 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3644 formatted with plain %d.
3645
3646 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3647
3648 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3649
3650 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3651
3652 * xterm.c (x_catch_errors): Remove duplicate declaration.
3653
3654 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3655
3656 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3657
3658 2011-04-10 Jim Meyering <meyering@redhat.com>
3659
3660 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3661 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3662 return ssize_t not "int", and use size_t as the buffer length.
3663 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3664 * gnutls.h: Update declarations.
3665 * process.c (read_process_output): Use ssize_t, to match.
3666 (send_process): Likewise.
3667
3668 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3669
3670 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3671
3672 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3673
3674 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3675 Use unsigned char, to match FcChar8 type definition.
3676
3677 * xterm.c (handle_one_xevent):
3678 * xmenu.c (create_and_show_popup_menu):
3679 * xselect.c (x_decline_selection_request)
3680 (x_reply_selection_request): Avoid type-punned deref of X events.
3681
3682 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3683
3684 Fix some uses of `int' instead of EMACS_INT.
3685 * search.c (string_match_1, fast_string_match)
3686 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3687 (scan_buffer, find_next_newline_no_quit)
3688 (find_before_next_newline, search_command, Freplace_match)
3689 (Fmatch_data): Make some `int' variables be EMACS_INT.
3690
3691 * xdisp.c (display_count_lines): 3rd argument and return value now
3692 EMACS_INT. All callers changed.
3693 (pint2hrstr): Last argument is now EMACS_INT.
3694
3695 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3696 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3697 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3698 (decode_coding_utf_16, decode_coding_emacs_mule)
3699 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3700 (decode_coding_ccl, decode_coding_charset)
3701 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3702 (decode_coding_iso_2022, decode_coding_emacs_mule)
3703 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3704 <char_offset, last_offset>: Declare EMACS_INT.
3705 (encode_coding_utf_8, encode_coding_utf_16)
3706 (encode_coding_emacs_mule, encode_invocation_designation)
3707 (encode_designation_at_bol, encode_coding_iso_2022)
3708 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3709 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3710 Declare EMACS_INT.
3711 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3712 (encode_invocation_designation): Last argument P_NCHARS is now
3713 EMACS_INT.
3714 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3715 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3716
3717 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3718 All users changed.
3719
3720 * ccl.c (Fccl_execute_on_string): Declare some variables
3721 EMACS_INT.
3722
3723 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3724
3725 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3726
3727 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3728
3729 * process.c (Fformat_network_address): Doc fix.
3730
3731 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3732
3733 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3734
3735 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3736
3737 * keyboard.c (read_char): Call Lisp function help-form-show,
3738 instead of using internal_with_output_to_temp_buffer.
3739 (Qhelp_form_show): New var.
3740 (syms_of_keyboard): Use DEFSYM macro.
3741
3742 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3743
3744 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3745
3746 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3747
3748 * process.c (Flist_processes): Remove to Lisp.
3749 (list_processes_1): Delete.
3750
3751 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3752
3753 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3754
3755 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3756
3757 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3758
3759 Fix more problems found by GCC 4.6.0's static checks.
3760
3761 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3762
3763 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3764
3765 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3766
3767 * xdisp.c (vmessage): Mark as a printf-like function.
3768
3769 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3770
3771 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3772
3773 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3774 printf-like functions.
3775 (tiff_load): Add casts to remove these marks before passing them
3776 to system-supplied API.
3777
3778 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3779
3780 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3781 This avoids several warnings with gcc -Wstrict-overflow.
3782 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3783 directly, rather than having caller test rule sign. This avoids
3784 some unnecessary tests.
3785 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3786 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3787 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3788
3789 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3790 (xfont_open): Avoid unnecessary tests.
3791
3792 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3793
3794 * composite.h, composite.c (composition_gstring_put_cache):
3795 Use EMACS_INT, not int, for length.
3796
3797 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3798 breaking out part of COMPOSITION_DECODE_RULE.
3799 (COMPOSITION_DECODE_RULE): Use it.
3800 * composite.c (get_composition_id): Remove unused local vars,
3801 by using the new macro.
3802
3803 * textprop.c (set_text_properties_1): Change while to do-while,
3804 since the condition is always true at first.
3805
3806 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3807 (interval_deletion_adjustment): Return unsigned value.
3808 All uses changed.
3809
3810 * process.c (list_processes_1, create_pty, read_process_output):
3811 (exec_sentinel): Remove vars that were set but not used.
3812 (create_pty): Remove unnecessary "volatile"s.
3813 (Fnetwork_interface_info): Avoid possibility of int overflow.
3814 (read_process_output): Do adaptive read buffering even if carryover.
3815 (read_process_output): Simplify nbytes computation if buffered.
3816
3817 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3818
3819 * syntax.c (scan_words): Remove var that was set but not used.
3820 (update_syntax_table): Use unsigned instead of int.
3821
3822 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3823 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3824 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3825
3826 * print.c (print_error_message): Avoid int overflow.
3827
3828 * font.c (font_list_entities): Redo for clarity,
3829 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3830
3831 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3832 (font_score): Avoid potential overflow in diff calculation.
3833
3834 * fns.c (substring_both): Remove var that is set but not used.
3835 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3836
3837 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3838
3839 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3840 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3841 can always succeed if overflow has undefined behavior.
3842
3843 * search.c (boyer_moore, wordify): Remove vars set but not used.
3844 (wordify): Omit three unnecessary tests.
3845
3846 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3847 All callers changed. This avoids the need for an unused var.
3848
3849 * casefiddle.c (casify_region): Remove var that is set but not used.
3850
3851 * dired.c (file_name_completion): Remove var that is set but not used.
3852
3853 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3854
3855 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3856 (Finsert_file_contents): Remove unnecessary code checking fd.
3857
3858 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3859 Check for integer overflow on size calculations.
3860
3861 * buffer.c (Fprevious_overlay_change): Remove var that is set
3862 but not used.
3863
3864 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3865 Remove vars that are set but not used.
3866 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3867 (timer_check_2): Mark vars as initialized.
3868
3869 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3870
3871 * image.c (lookup_image): Remove var that is set but not used.
3872 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3873
3874 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3875 that are set but not used.
3876
3877 * xfns.c (make_invisible_cursor): Don't return garbage
3878 if XCreateBitmapFromData fails (Bug#8410).
3879
3880 * xselect.c (x_get_local_selection, x_handle_property_notify):
3881 Remove vars that are set but not used.
3882
3883 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3884 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3885
3886 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3887 Remove var that is set but not used.
3888 (scroll_bar_windows_size): Now size_t, not int.
3889 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3890 Check for overflow.
3891
3892 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3893 (map_tty_color) [!defined MSDOS]: Likewise.
3894
3895 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3896
3897 * coding.c: Remove vars that are set but not used.
3898 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3899 All callers changed.
3900 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3901 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3902 (decode_coding_charset): Remove vars that are set but not used.
3903
3904 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3905 that is set but not used.
3906
3907 * print.c (print_object): Remove var that is set but not used.
3908
3909 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3910 The gnulib version avoids calling malloc in the usual case,
3911 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3912 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3913 * filelock.c (current_lock_owner): Likewise.
3914 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3915 * sysdep.c: Include allocator.h, careadlinkat.h.
3916 (emacs_no_realloc_allocator): New static constant.
3917 (emacs_readlink): New function.
3918 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3919 ../lib/careadlinkat.h.
3920
3921 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3922
3923 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3924 first non-nil return value).
3925
3926 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3927
3928 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3929 if not defined (Bug#8403).
3930
3931 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3932
3933 * xdisp.c (display_count_lines): Remove parameter `start',
3934 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3935 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3936 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3937 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3938 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3939 and thereabouts. All callers changed.
3940 (get_per_char_metric): Remove parameter `f', unused since
3941 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3942
3943 2011-04-02 Jim Meyering <meyering@redhat.com>
3944
3945 do not dereference NULL upon failed strdup
3946 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3947 (ns_get_family): Likewise.
3948
3949 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3950
3951 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3952
3953 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3954
3955 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3956 later (Bug#8403).
3957
3958 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3959
3960 Add lexical binding.
3961
3962 * window.c (Ftemp_output_buffer_show): New fun.
3963 (Fsave_window_excursion):
3964 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3965
3966 * lread.c (lisp_file_lexically_bound_p): New function.
3967 (Fload): Bind Qlexical_binding.
3968 (readevalloop): Remove `evalfun' arg.
3969 Bind Qinternal_interpreter_environment.
3970 (Feval_buffer): Bind Qlexical_binding.
3971 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3972 Mark as dynamic.
3973 (syms_of_lread): Declare `lexical-binding'.
3974
3975 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3976
3977 * keyboard.c (eval_dyn): New fun.
3978 (menu_item_eval_property): Use it.
3979
3980 * image.c (parse_image_spec): Use Ffunctionp.
3981
3982 * fns.c (concat, mapcar1): Accept byte-code-functions.
3983
3984 * eval.c (Fsetq): Handle lexical vars.
3985 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3986 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3987 (FletX, Flet): Obey lexical binding.
3988 (Fcommandp): Handle closures.
3989 (Feval): New `lexical' arg.
3990 (eval_sub): New function extracted from Feval. Use it almost
3991 everywhere where Feval was used. Look up vars in lexical env.
3992 Handle closures.
3993 (Ffunctionp): Move from subr.el.
3994 (Ffuncall): Handle closures.
3995 (apply_lambda): Remove `eval_flags'.
3996 (funcall_lambda): Handle closures and new byte-code-functions.
3997 (Fspecial_variable_p): New function.
3998 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3999 but without exporting it to Lisp.
4000
4001 * doc.c (Fdocumentation, store_function_docstring):
4002 * data.c (Finteractive_form): Handle closures.
4003
4004 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4005 interactive spec.
4006
4007 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4008 New byte-codes.
4009 (exec_byte_code): New function extracted from Fbyte_code to handle new
4010 calling convention for byte-code-functions. Add new byte-codes.
4011
4012 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4013
4014 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4015
4016 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4017
4018 * xdisp.c (redisplay_internal): Fix prototype.
4019
4020 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4021
4022 * xdisp.c (SCROLL_LIMIT): New macro.
4023 (try_scrolling): Use it when setting scroll_limit.
4024 Limit scrolling to 100 screen lines.
4025 (redisplay_window): Even when falling back on "recentering",
4026 position point in the window according to scroll-conservatively,
4027 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4028
4029 (try_scrolling): When point is above the window, allow searching
4030 as far as scroll_max, or one screenful, to compute vertical
4031 distance from PT to the scroll margin position. This prevents
4032 try_scrolling from unnecessarily failing when
4033 scroll-conservatively is set to a value slightly larger than the
4034 window height. Clean up the case of PT below the margin at bottom
4035 of window: scroll_max can no longer be INT_MAX. When aggressive
4036 scrolling is in use, don't let point enter the opposite scroll
4037 margin as result of the scroll.
4038 (syms_of_xdisp) <scroll-conservatively>: Document the
4039 threshold of 100 lines for never-recentering scrolling.
4040
4041 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4042
4043 * dispextern.h (move_it_by_lines):
4044 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4045 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4046 (message_log_check_duplicate): Remove parameters `prev_bol' and
4047 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4048 (redisplay_internal): Remove parameter `preserve_echo_area',
4049 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4050
4051 * indent.c (Fvertical_motion):
4052 * window.c (window_scroll_pixel_based, Frecenter):
4053 Don't pass `need_y_p' to `move_it_by_lines'.
4054
4055 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4056
4057 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4058 steal a few bits to be more compact.
4059 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4060 Remove unneeded casts.
4061
4062 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4063
4064 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4065
4066 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4067 binding" message (bug#7967).
4068
4069 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4070
4071 Fix more problems found by GCC 4.6.0's static checks.
4072
4073 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4074 Remove unused local var.
4075
4076 * editfns.c (Fmessage_box): Remove unused local var.
4077
4078 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4079 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4080 Omit unused local vars.
4081 * window.c (shrink_windows): Omit unused local var.
4082 * menu.c (digest_single_submenu): Omit unused local var.
4083 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4084 Omit unused local var.
4085
4086 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4087 Don't assume string length fits in int.
4088 (keyremap_step, read_key_sequence): Use size_t for sizes.
4089 (read_key_sequence): Don't check last_real_key_start redundantly.
4090
4091 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4092 instead of alloca (Bug#8344).
4093
4094 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4095 (Fbacktrace_frame): Don't assume nframes fits in int.
4096
4097 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4098
4099 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4100 concerns.
4101
4102 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4103
4104 * cm.c (calccost): Turn while-do into do-while, for clarity.
4105
4106 * keyboard.c (syms_of_keyboard): Use the same style as later
4107 in this function when indexing through an array. This also
4108 works around GCC bug 48267.
4109
4110 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4111
4112 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4113
4114 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4115 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4116
4117 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4118 This avoids undefined behavior on integer overflow, and is a bit
4119 more convenient anyway since it is compared to a size_t variable.
4120
4121 Variadic C functions now count arguments with size_t, not int.
4122 This avoids an unnecessary limitation on 64-bit machines, which
4123 caused (substring ...) to crash on large vectors (Bug#8344).
4124 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4125 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4126 All variadic functions and their callers changed accordingly.
4127 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4128 * data.c (arith_driver, float_arith_driver): Likewise.
4129 * editfns.c (general_insert_function): Likewise.
4130 * eval.c (struct backtrace.nargs, interactive_p)
4131 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4132 (funcall_lambda, mark_backtrace): Likewise.
4133 * fns.c (concat): Likewise.
4134 * frame.c (x_set_frame_parameters): Likewise.
4135 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4136 0 if not found, not -1. All callers changed.
4137
4138 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4139 (stack_copy_size): Now size_t, not int.
4140 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4141
4142 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4143
4144 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4145 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4146 All callers changed.
4147
4148 * lisp.h (multibyte_char_to_unibyte):
4149 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4150 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4151 * character.h (CHAR_TO_BYTE8):
4152 * cmds.c (internal_self_insert):
4153 * editfns.c (general_insert_function):
4154 * keymap.c (push_key_description):
4155 * search.c (Freplace_match):
4156 * xdisp.c (message_dolog, set_message_1): All callers changed.
4157
4158 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4159
4160 * keyboard.c (safe_run_hook_funcall): New function.
4161 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4162 don't set the hook to nil, but remove the offending function instead.
4163 (Qcommand_hook_internal): Remove, unused.
4164 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4165 Vcommand_hook_internal.
4166
4167 * eval.c (enum run_hooks_condition): Remove.
4168 (funcall_nil, funcall_not): New functions.
4169 (run_hook_with_args): Call each function through a `funcall' argument.
4170 Remove `cond' argument, now redundant.
4171 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4172 (Frun_hook_with_args_until_failure): Adjust accordingly.
4173 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4174
4175 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4176
4177 * dispextern.h (string_buffer_position): Remove declaration.
4178
4179 * print.c (strout): Remove parameter `multibyte', unused since
4180 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4181
4182 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4183 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4184 All callers changed.
4185
4186 * w32.c (_wsa_errlist): Use braces for struct initializers.
4187
4188 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4189 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4190 All callers changed.
4191 (string_buffer_position): Likewise. Also, make static (it's never
4192 used outside xdisp.c).
4193 (cursor_row_p): Remove parameter `w', unused since
4194 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4195 (decode_mode_spec): Remove parameter `precision', introduced during
4196 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4197 All callers changed.
4198
4199 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4200
4201 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4202
4203 2011-03-27 Anders Lindgren <andlind@gmail.com>
4204
4205 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4206 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4207 (ns_update_auto_hide_menu_bar): New functions.
4208 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4209 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4210 ns_constrain_all_frames.
4211 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4212 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4213
4214 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4215
4216 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4217
4218 2011-03-27 Glenn Morris <rgm@gnu.org>
4219
4220 * syssignal.h: Replace RETSIGTYPE with void.
4221 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4222 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4223 Replace SIGTYPE with void everywhere.
4224 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4225 * s/template.h (SIGTYPE): Remove commented out definition.
4226
4227 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4228
4229 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4230 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4231
4232 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4233
4234 * w32.c (read_unc_volume): Use parameter `henum', instead of
4235 global variable `wget_enum_handle'.
4236
4237 * keymap.c (describe_vector): Remove parameters `indices' and
4238 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4239 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4240
4241 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4242
4243 * keyboard.c (timer_check): Remove parameter `do_it_now',
4244 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4245 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4246 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4247
4248 * keyboard.c (read_char):
4249 * w32menu.c (w32_menu_display_help):
4250 * xmenu.c (show_help_event, menu_help_callback):
4251 Adjust calls to `show_help_echo'.
4252
4253 * gtkutil.c (xg_maybe_add_timer):
4254 * keyboard.c (readable_events):
4255 * process.c (wait_reading_process_output):
4256 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4257
4258 * insdel.c (adjust_markers_gap_motion):
4259 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4260 (gap_left, gap_right): Don't call it.
4261
4262 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4263
4264 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4265 incurred during fontification.
4266
4267 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4268
4269 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4270 (DEFVAR_PER_BUFFER): Don't pass it.
4271
4272 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4273 (scrolling_window): Don't pass it.
4274
4275 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4276
4277 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4278
4279 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4280 and `suffix'.
4281 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4282 of variables specific to SELinux and computation of `encoded_absname'.
4283
4284 * image.c (XPutPixel): Remove unused variable `height'.
4285
4286 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4287
4288 * unexw32.c (get_section_info): Remove unused variable `section'.
4289
4290 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4291 (system_process_attributes): Remove unused variable `sess'.
4292 (sys_read): Remove unused variable `err'.
4293
4294 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4295 (w32_wnd_proc): Remove unused variable `isdead'.
4296 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4297 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4298 (x_create_tip_frame): Remove unused variable `tem'.
4299
4300 * w32inevt.c (w32_console_read_socket):
4301 Remove unused variable `no_events'.
4302
4303 * w32term.c (x_draw_composite_glyph_string_foreground):
4304 Remove unused variable `width'.
4305
4306 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4307
4308 * w32term.c (x_set_glyph_string_clipping):
4309 Don't pass uninitialized region to CombineRgn.
4310
4311 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4312
4313 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4314 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4315 (Fx_close_connection): Remove unused variable `i'.
4316
4317 * w32font.c (w32font_draw): Return number of glyphs.
4318 (w32font_open_internal): Remove unused variable `i'.
4319 (w32font_driver): Add missing initializer.
4320
4321 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4322 (fill_in_menu): Remove unused variable `items_added'.
4323
4324 * w32term.c (last_mouse_press_frame): Remove static global variable.
4325 (w32_clip_to_row): Remove unused variable `f'.
4326 (x_delete_terminal): Remove unused variable `i'.
4327
4328 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4329 (NOTHING): Remove unused static global variable.
4330 (uniscribe_check_otf): Remove unused variable `table'.
4331 (uniscribe_font_driver): Add missing initializers.
4332
4333 2011-03-23 Julien Danjou <julien@danjou.info>
4334
4335 * term.c (Fsuspend_tty, Fresume_tty):
4336 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4337 * window.c (temp_output_buffer_show):
4338 * insdel.c (signal_before_change):
4339 * frame.c (Fhandle_switch_frame):
4340 * fileio.c (Fdo_auto_save):
4341 * emacs.c (Fkill_emacs):
4342 * editfns.c (save_excursion_restore):
4343 * cmds.c (internal_self_insert):
4344 * callint.c (Fcall_interactively):
4345 * buffer.c (Fkill_all_local_variables):
4346 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4347 Use Frun_hooks.
4348 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4349 unconditionnaly since it does the check itself.
4350
4351 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4352
4353 Fix more problems found by GCC 4.5.2's static checks.
4354
4355 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4356 the first time through the loop, since we know p0 < p1 then.
4357 This also avoids a gcc -Wstrict-overflow warning.
4358
4359 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4360 leading to a memory leak, possible in functions like
4361 load_charset_map_from_file that can allocate an unbounded number
4362 of objects (Bug#8318).
4363
4364 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4365 that could (at least in theory) be that large.
4366
4367 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4368 This is less likely to overflow, and avoids undefined behavior if
4369 overflow does occur. All callers changed. Use strtoul to scan
4370 for the unsigned long integer.
4371 (pint2hrstr): Simplify and tune code slightly.
4372 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4373
4374 * scroll.c (do_scrolling): Work around GCC bug 48228.
4375 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4376
4377 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4378 This also avoids a warning with gcc -Wstrict-overflow.
4379 (validate_x_resource_name): Simplify count usage.
4380 This also avoids a warning with gcc -Wstrict-overflow.
4381
4382 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4383 fail (Bug#8306).
4384
4385 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4386
4387 * process.c (Fmake_network_process): Use socklen_t, not int,
4388 where POSIX says socklen_t is required in portable programs.
4389 This fixes a porting bug on hosts like 64-bit HP-UX, where
4390 socklen_t is wider than int (Bug#8277).
4391 (Fmake_network_process, server_accept_connection):
4392 (wait_reading_process_output, read_process_output):
4393 Likewise.
4394
4395 * process.c: Rename or move locals to avoid shadowing.
4396 (list_processes_1, Fmake_network_process):
4397 (read_process_output_error_handler, exec_sentinel_error_handler):
4398 Rename or move locals.
4399 (Fmake_network_process): Define label "retry_connect" only if needed.
4400 (Fnetwork_interface_info): Fix pointer signedness.
4401 (process_send_signal): Add cast to avoid pointer signedness problem.
4402 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4403 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4404
4405 Make tparam.h and terminfo.c consistent.
4406 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4407 Include tparam.h instead, since it declares them.
4408 * cm.h (PC): Remove extern decl; tparam.h now does this.
4409 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4410 * terminfo.c: Include tparam.h, to check interfaces.
4411 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4412 (tparam): Adjust signature to match interface in tparam.h;
4413 this removes some undefined behavior. Check that outstring and len
4414 are zero, which they always are with Emacs.
4415 * tparam.h (PC, BC, UP): New extern decls.
4416
4417 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4418 (xftfont_open): Rename locals to avoid shadowing.
4419
4420 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4421 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4422 (OTF_TAG_SYM): Omit macro if not needed.
4423 (ftfont_list): Remove unused local.
4424 (get_adstyle_property, ftfont_pattern_entity):
4425 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4426 Rename locals to avoid shadowing.
4427
4428 * xfont.c (xfont_list_family): Mark var as initialized.
4429
4430 * xml.c (make_dom): Now static.
4431
4432 * composite.c (composition_compute_stop_pos): Rename local to
4433 avoid shadowing.
4434 (composition_reseat_it): Remove unused locals.
4435 (find_automatic_composition, composition_adjust_point): Likewise.
4436 (composition_update_it): Mark var as initialized.
4437 (find_automatic_composition): Mark vars as initialized,
4438 with a FIXME (Bug#8290).
4439
4440 character.h: Rename locals to avoid shadowing.
4441 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4442 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4443 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4444 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4445 to avoid shadowing.
4446
4447 * textprop.c (property_change_between_p): Remove; unused.
4448
4449 * intervals.c (interval_start_pos): Now static.
4450
4451 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4452
4453 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4454 Rename locals to avoid shadowing.
4455
4456 * sound.c (wav_play, au_play, Fplay_sound_internal):
4457 Fix pointer signedness.
4458 (alsa_choose_format): Remove unused local var.
4459 (wav_play): Initialize a variable to 0, to prevent undefined
4460 behavior (Bug#8278).
4461
4462 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4463
4464 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4465
4466 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4467 clobbering (Bug#8298).
4468 * sysdep.c (sys_subshell): Likewise.
4469 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4470
4471 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4472 This should get cleaned up, so that child_setup has the
4473 same signature on all platforms.
4474
4475 * callproc.c (call_process_cleanup): Now static.
4476 (relocate_fd): Rename locals to avoid shadowing.
4477
4478 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4479
4480 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4481 not to be necessary, and produces flickering.
4482
4483 2011-03-20 Glenn Morris <rgm@gnu.org>
4484
4485 * config.in: Remove file.
4486
4487 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4488
4489 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4490 are now in src/globals.h.
4491 (syms_of_minibuf): Remove spurious & from previous change.
4492
4493 2011-03-20 Leo <sdl.web@gmail.com>
4494
4495 * minibuf.c (completing-read-function): New variable.
4496 (completing-read-default): Rename from completing-read.
4497 (completing-read): Call completing-read-function.
4498
4499 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4500
4501 * xfaces.c (Fx_load_color_file):
4502 Read color file from absolute filename (bug#8250).
4503
4504 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4505
4506 * makefile.w32-in: Update dependencies.
4507
4508 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4509
4510 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4511
4512 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4513
4514 Fix more problems found by GCC 4.5.2's static checks.
4515
4516 * process.c (make_serial_process_unwind, send_process_trap):
4517 (sigchld_handler): Now static.
4518
4519 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4520 That way, the code declares only the vars that it needs.
4521 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4522 * s/cygwin.h (PTY_ITERATION): Likewise.
4523 * s/darwin.h (PTY_ITERATION): Likewise.
4524 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4525
4526 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4527 * process.c (allocate_pty): Don't declare stb unless it's needed.
4528
4529 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4530 (CONSTANTLIM): Remove; unused.
4531 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4532 Define only if needed.
4533
4534 * unexelf.c (unexec): Name an expression,
4535 to avoid gcc -Wbad-function-cast warning.
4536 Use a different way to cause a compilation error if anyone uses
4537 n rather than nn, a way that does not involve shadowing.
4538 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4539
4540 * deps.mk (unexalpha.o): Remove; unused.
4541
4542 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4543 * unexec.h: New file.
4544 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4545 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4546 Depend on unexec.h.
4547 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4548 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4549 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4550 Change as necessary to match prototype in unexec.h.
4551
4552 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4553 shadowing.
4554 (back_comment, skip_chars): Mark vars as initialized.
4555
4556 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4557 Rename locals to avoid shadowing.
4558
4559 * lread.c (read1): Rewrite so as not to use empty "else".
4560 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4561
4562 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4563
4564 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4565 warning when compiling print.c.
4566
4567 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4568 instead of using an uninitialized var.
4569 (font_sort_entities): Mark var as initialized.
4570
4571 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4572
4573 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4574 pointers to constants.
4575 (font_parse_fcname): Remove unused vars.
4576 (font_delete_unmatched): Now static.
4577 (font_get_spec): Remove; unused.
4578 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4579 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4580 Rename or move locals to avoid shadowing.
4581
4582 * fns.c (require_nesting_list, require_unwind): Now static.
4583 (Ffillarray): Rename locals to avoid shadowing.
4584
4585 * floatfns.c (domain_error2): Define only if needed.
4586 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4587
4588 * alloc.c (mark_backtrace): Move decl from here ...
4589 * lisp.h: ... to here, so that it can be checked.
4590
4591 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4592 (Fdefvar): Rewrite so as not to use empty "else".
4593 (lisp_indirect_variable): Name an expression,
4594 to avoid gcc -Wbad-function-cast warning.
4595 (Fdefvar): Rename locals to avoid shadowing.
4596
4597 * callint.c (quotify_arg, quotify_args): Now static.
4598 (Fcall_interactively): Rename locals to avoid shadowing.
4599 Use const pointer when appropriate.
4600
4601 * lisp.h (get_system_name, get_operating_system_release):
4602 Move decls here, to check interfaces.
4603 * process.c (get_operating_system_release): Move decl to lisp.h.
4604 * xrdb.c (get_system_name): Likewise.
4605 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4606 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4607 some of which prompt warnings from gcc -Wbad-function-cast.
4608 (Fformat_time_string, Fencode_time, Finsert_char):
4609 (Ftranslate_region_internal, Fformat):
4610 Rename or remove local vars to avoid shadowing.
4611 (Ftranslate_region_internal): Mark var as initialized.
4612
4613 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4614 avoid shadowing.
4615
4616 * lisp.h (eassert): Check that the argument compiles, even if
4617 ENABLE_CHECKING is not defined.
4618
4619 * data.c (Findirect_variable): Name an expression, to avoid
4620 gcc -Wbad-function-cast warning.
4621 (default_value, arithcompare, arith_driver, arith_error): Now static.
4622 (store_symval_forwarding): Rename local to avoid shadowing.
4623 (Fmake_variable_buffer_local, Fmake_local_variable):
4624 Mark variables as initialized.
4625 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4626
4627 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4628 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4629 Rename locals to avoid shadowing.
4630 (mark_stack): Move local variables into the #ifdef region where
4631 they're used.
4632 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4633 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4634 needed otherwise.
4635 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4636 (GC_STRING_CHARS): Remove; not used.
4637 (Fmemory_limit): Cast sbrk's returned value to char *.
4638
4639 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4640 avoids undefined behavior in theory.
4641
4642 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4643
4644 Use functions, not macros, for up- and down-casing (Bug#8254).
4645 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4646 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4647 to use the following functions instead of these macros.
4648 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4649 EMACS_INT, since callers assume the returned value fits in int.
4650 (upcase1): Likewise, for UPCASE_TABLE.
4651 (uppercasep, lowercasep, upcase): New static inline functions.
4652 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4653 the race-condition problem in the old DOWNCASE.
4654
4655 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4656 Rename locals to avoid shadowing.
4657 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4658 (regex_compile, re_search_2, re_match_2_internal):
4659 Remove unused local vars.
4660 (FREE_VAR): Rewrite so as not to use empty "else",
4661 which gcc can warn about.
4662 (regex_compile, re_match_2_internal): Mark locals as initialized.
4663 (RETALLOC_IF): Define only if needed.
4664 (WORDCHAR_P): Likewise. This one is never needed, but is used
4665 only in a comment talking about a compiler bug, so put inside
4666 the #if 0 of that comment.
4667 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4668 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4669 Remove; unused.
4670
4671 * search.c (boyer_moore): Rename locals to avoid shadowing.
4672 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4673 (PREV_CHAR_BOUNDARY): Likewise.
4674
4675 * search.c (simple_search): Remove unused var.
4676
4677 * dired.c (compile_pattern): Move decl from here ...
4678 * lisp.h: ... to here, so that it can be checked.
4679 (struct re_registers): New forward decl.
4680
4681 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4682
4683 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4684 All uses changed.
4685 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4686 Rename locals to avoid shadowing.
4687 (Fvertical_motion): Mark locals as initialized.
4688
4689 * casefiddle.c (casify_object, casify_region): Now static.
4690 (casify_region): Mark local as initialized.
4691
4692 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4693
4694 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4695 New macros, so that the caller can use some names other than
4696 gcpro1, gcpro2, etc.
4697 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4698 of the new macros.
4699 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4700 argument, for consistency with GCPRO2_VAR, etc: it is now the
4701 prefix of the variable, not the variable itself. All uses
4702 changed.
4703 * dired.c (directory_files_internal, file_name_completion):
4704 Rename locals to avoid shadowing.
4705
4706 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4707 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4708 dired.c's scmp function, had undefined behavior.
4709 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4710 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4711 * buffer.h: ... to here, because these macros use current_buffer,
4712 and the new implementation with inline functions needs to have
4713 current_buffer in scope now, rather than later when the macros
4714 are used.
4715 (downcase, upcase1): New static inline functions.
4716 (DOWNCASE, UPCASE1): Reimplement using these functions.
4717 This avoids undefined behavior in expressions like
4718 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4719 from race conditions in accessing the global variables
4720 case_temp1 and case_temp2.
4721 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4722 * lisp.h (case_temp1, case_temp2): Remove their decls.
4723 * character.h (ASCII_CHAR_P): Move from here ...
4724 * lisp.h: ... to here, so that the inline functions mentioned
4725 above can use them.
4726
4727 * dired.c (directory_files_internal_unwind): Now static.
4728
4729 * fileio.c (file_name_as_directory, directory_file_name):
4730 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4731 Now static.
4732 (file_name_as_directory): Use const pointers when appropriate.
4733 (Fexpand_file_name): Likewise. In particular, newdir might
4734 point at constant storage, so make it a const pointer.
4735 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4736 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4737 signedness issues.
4738 (Fset_file_times, Finsert_file_contents, auto_save_error):
4739 Rename locals to avoid shadowing.
4740
4741 * minibuf.c (choose_minibuf_frame_1): Now static.
4742 (Ftry_completion, Fall_completions): Rename or remove locals
4743 to avoid shadowing.
4744
4745 * marker.c (bytepos_to_charpos): Remove; unused.
4746
4747 * lisp.h (verify_bytepos, count_markers): New decls,
4748 so that gcc does not warn that these functions aren't declared.
4749
4750 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4751 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4752 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4753 (copy_text): Remove unused local var.
4754
4755 * filelock.c (within_one_second): Now static.
4756 (lock_file_1): Rename local to avoid shadowing.
4757
4758 * buffer.c (fix_overlays_before): Mark locals as initialized.
4759 (fix_start_end_in_overlays): Likewise. This function should be
4760 simplified by using pointers-to-pointers, but that's a different
4761 matter.
4762 (switch_to_buffer_1): Now static.
4763 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4764 (report_overlay_modification): Rename locals to avoid shadowing.
4765
4766 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4767 Fix pointer signedness issue.
4768 (sys_subshell): Mark local as volatile if checking for lint,
4769 to suppress a gcc -Wclobbered warning that does not seem to be right.
4770 (MAXPATHLEN): Define only if needed.
4771
4772 * process.c (serial_open, serial_configure): Move decls from here ...
4773 * systty.h: ... to here, so that they can be checked.
4774
4775 * fns.c (get_random, seed_random): Move extern decls from here ...
4776 * lisp.h: ... to here, so that they can be checked.
4777
4778 * sysdep.c (reset_io): Now static.
4779 (wait_for_termination_signal): Remove; unused.
4780
4781 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4782 (copy_keymap_item, append_key, push_text_char_description):
4783 Now static.
4784 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4785 (DENSE_TABLE_SIZE): Remove; unused.
4786 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4787 (describe_map_tree):
4788 Rename locals to avoid shadowing.
4789
4790 * keyboard.c: Declare functions static if they are not used elsewhere.
4791 (echo_char, echo_dash, cmd_error, top_level_2):
4792 (poll_for_input, handle_async_input): Now static.
4793 (read_char, kbd_buffer_get_event, make_lispy_position):
4794 (make_lispy_event, make_lispy_movement, apply_modifiers):
4795 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4796 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4797 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4798 (read_key_sequence, read_char): Mark locals as initialized.
4799 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4800
4801 * keyboard.h (make_ctrl_char): New decl.
4802 (mark_kboards): Move decl here ...
4803 * alloc.c (mark_kboards): ... from here.
4804
4805 * lisp.h (force_auto_save_soon): New decl.
4806
4807 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4808 (DEFINE_DUMMY_FUNCTION): New macro.
4809 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4810 Use it.
4811 (main): Add casts to avoid warnings
4812 if GCC considers string literals to be constants.
4813
4814 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4815
4816 * dbusbind.c: Pointer signedness fixes.
4817 (xd_signature, xd_append_arg, xd_initialize):
4818 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4819 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4820 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4821 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4822
4823 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4824 if GCC considers string literals to be constants.
4825 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4826
4827 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4828
4829 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4830 (print_preprocess, print_object): New macro to fix last change.
4831
4832 * print.c (print_preprocess): Don't forget font objects.
4833
4834 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4835
4836 * emacs.c (USAGE3): Doc fixes.
4837
4838 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4839
4840 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4841 structure.
4842
4843 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4844
4845 * lisp.h (VWindow_system, Qfile_name_history):
4846 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4847 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4848 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4849
4850 * w32select.c: Don't #include "keyboard.h".
4851 (run_protected): Add extern declaration for waiting_for_input.
4852
4853 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4854 * w32console.c (detect_input_pending, read_input_pending)
4855 (encode_terminal_code):
4856 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4857 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4858 (w32_system_caret_y, Qfile_name_history):
4859 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4860 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4861 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4862 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4863 * w32proc.c (Qlocal, report_file_error):
4864 * w32term.c (Vwindow_system, updating_frame):
4865 * w32uniscribe.c (initialized, uniscribe_font_driver):
4866 Remove unneeded extern declarations.
4867
4868 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4869
4870 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4871
4872 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4873
4874 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4875 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4876 These macros can no longer be used for assignment.
4877
4878 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4879 Assign struct members directly, instead of using BUF_BEGV etc.
4880 (record_buffer_markers, fetch_buffer_markers): New functions for
4881 recording and fetching special buffer markers.
4882 (set_buffer_internal_1, set_buffer_temp): Use them.
4883
4884 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4885
4886 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4887
4888 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4889 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4890
4891 * xdisp.c (hscroll_window_tree):
4892 (reconsider_clip_changes): Use PT instead of BUF_PT.
4893
4894 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4895
4896 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4897 $(EMACS_ROOT)/lib/intprops.h.
4898
4899 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4900
4901 Fix more problems found by GCC 4.5.2's static checks.
4902
4903 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4904 to unsigned char * to avoid compiler diagnostic.
4905 (xg_free_frame_widgets): Make it clear that a local variable is
4906 needed only if USE_GTK_TOOLTIP.
4907 (gdk_window_get_screen): Make it clear that this macro is needed
4908 only if USE_GTK_TOOLTIP.
4909 (int_gtk_range_get_value): New function, which avoids a diagnostic
4910 from gcc -Wbad-function-cast.
4911 (xg_set_toolkit_scroll_bar_thumb): Use it.
4912 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4913 diagnostic from gcc -Wbad-function-cast.
4914 (get_utf8_string, xg_get_file_with_chooser):
4915 Rename locals to avoid shadowing.
4916 (create_dialog): Move locals to avoid shadowing.
4917
4918 * xgselect.c (xg_select): Remove unused var.
4919
4920 * image.c (four_corners_best): Mark locals as initialized.
4921 (gif_load): Initialize transparent_p to zero (Bug#8238).
4922 Mark another local as initialized.
4923 (my_png_error, my_error_exit): Mark with NO_RETURN.
4924
4925 * image.c (clear_image_cache): Now static.
4926 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4927 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4928 (x_edge_detection): Remove unnecessary cast that
4929 gcc -Wbad-function-cast diagnoses.
4930 (gif_load): Fix pointer signedness.
4931 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4932 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4933
4934 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4935
4936 Improve quality of tests for time stamp overflow.
4937 For example, without this patch (encode-time 0 0 0 1 1
4938 1152921504606846976) returns the obviously-bogus value (-948597
4939 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4940 reports time overflow. See
4941 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4942 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4943 * editfns.c: Include limits.h and intprops.h.
4944 (TIME_T_MIN, TIME_T_MAX): New macros.
4945 (time_overflow): Move earlier, to before first use.
4946 (hi_time, lo_time): New functions, for an accurate test for
4947 out-of-range times.
4948 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4949 (Fget_internal_run_time): Don't assume time_t fits in int.
4950 (make_time): Use list2 instead of Fcons twice.
4951 (Fdecode_time): More accurate test for out-of-range times.
4952 (check_tm_member): New function.
4953 (Fencode_time): Use it, to test for out-of-range times.
4954 (lisp_time_argument): Don't rely on undefined left-shift and
4955 right-shift behavior when checking for time stamp overflow.
4956
4957 * editfns.c (time_overflow): New function, refactoring common code.
4958 (Fformat_time_string, Fdecode_time, Fencode_time):
4959 (Fcurrent_time_string): Use it.
4960
4961 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4962 * dired.c (make_time): Move to ...
4963 * editfns.c (make_time): ... here.
4964 * systime.h: Note the move.
4965
4966 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4967
4968 * fringe.c (update_window_fringes): Remove unused variables.
4969
4970 * unexmacosx.c (copy_data_segment): Also copy __got section.
4971 (Bug#8223)
4972
4973 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4974
4975 * termcap.c [MSDOS]: Include "msdos.h".
4976 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4977 Constify `char *' arguments and their references according to
4978 prototypes in tparam.h.
4979
4980 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4981
4982 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4983 Adapt all references accordingly.
4984
4985 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4986
4987 2011-03-11 Tom Tromey <tromey@redhat.com>
4988
4989 * buffer.c (syms_of_buffer): Remove obsolete comment.
4990
4991 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4992
4993 * termhooks.h (encode_terminal_code): Declare prototype.
4994
4995 * msdos.c (encode_terminal_code): Don't declare prototype.
4996
4997 * term.c (encode_terminal_code): Now external again, used by
4998 w32console.c and msdos.c.
4999
5000 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5001 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5002
5003 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5004
5005 Fix some minor problems found by GCC 4.5.2's static checks.
5006
5007 * fringe.c (update_window_fringes): Mark locals as initialized
5008 (Bug#8227).
5009 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5010
5011 * alloc.c (mark_fringe_data): Move decl from here ...
5012 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5013 to check its interface.
5014 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5015
5016 * fontset.c (free_realized_fontset): Now static.
5017 (Fset_fontset_font): Rename local to avoid shadowing.
5018 (fontset_font): Mark local as initialized.
5019 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5020
5021 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5022
5023 * xselect.c (x_disown_buffer_selections): Remove; not used.
5024 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5025 (x_own_selection, Fx_disown_selection_internal): Rename locals
5026 to avoid shadowing.
5027 (x_handle_dnd_message): Remove local to avoid shadowing.
5028
5029 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5030 so that the caller can use some name other than gcpro1.
5031 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5032 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5033 (Fx_backspace_delete_keys_p):
5034 Use them to avoid shadowing, and rename vars to avoid shadowing.
5035 (x_decode_color, x_set_name, x_window): Now static.
5036 (Fx_create_frame): Add braces to silence GCC warning.
5037 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5038 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5039 Remove unused locals.
5040 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5041 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5042 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5043 macros.
5044
5045 * xterm.h (x_mouse_leave): New decl.
5046
5047 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5048 Remove unused functions.
5049 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5050 (x_calc_absolute_position): Now static.
5051 (XTread_socket): Don't define label "out" unless it's used.
5052 Don't declare local "event" unless it's used.
5053 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5054 unless they are used.
5055 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5056 (x_fatal_error_signal): Remove; not used.
5057 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5058 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5059 (x_error_catcher, x_connection_closed, x_error_handler):
5060 (x_error_quitter, xembed_send_message, x_iconify_frame):
5061 (my_log_handler): Rename locals to avoid shadowing.
5062 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5063 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5064
5065 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5066 Rename or move locals to avoid shadowing.
5067 (tty_defined_color, merge_face_heights): Now static.
5068 (free_realized_faces_for_fontset): Remove; not used.
5069 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5070 does not deduce is never used uninitialized.
5071 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5072 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5073
5074 * terminal.c (store_terminal_param): Now static.
5075
5076 * xmenu.c (menu_highlight_callback): Now static.
5077 (set_frame_menubar): Remove unused local.
5078 (xmenu_show): Rename parameter to avoid shadowing.
5079 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5080 since they might point to immutable storage.
5081 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5082 since it's unused otherwise.
5083
5084 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5085 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5086 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5087 avoids a gcc -Wuninitialized diagnostic.
5088 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5089 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5090 does not deduce are never used uninitialized.
5091
5092 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5093
5094 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5095 * window.c (window_loop, size_window):
5096 (run_window_configuration_change_hook, enlarge_window): Likewise.
5097
5098 * window.c (display_buffer): Now static.
5099 (size_window): Mark variables that gcc -Wuninitialized
5100 does not deduce are never used uninitialized.
5101 * window.h (check_all_windows): New decl, to forestall
5102 gcc -Wmissing-prototypes diagnostic.
5103 * dispextern.h (bidi_dump_cached_states): Likewise.
5104
5105 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5106 shadowing.
5107 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5108 Include <limits.h>.
5109 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5110 and to avoid gcc -Wuninitialized warning.
5111 (load_charset_map): Mark variables that gcc -Wuninitialized
5112 does not deduce are never used uninitialized.
5113 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5114
5115 * coding.c (coding_set_source, coding_set_destination):
5116 Use "else { /* comment */ }" rather than "else /* comment */;"
5117 for clarity, and to avoid gcc -Wempty-body warning.
5118 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5119 a block, when the outer 'i' will do.
5120 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5121 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5122 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5123 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5124 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5125 Rename locals to avoid shadowing.
5126 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5127 * coding.c (emacs_mule_char, encode_invocation_designation):
5128 Now static, since they're not used elsewhere.
5129 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5130 (decode_coding_object, encode_coding_object, detect_coding_system):
5131 (decode_coding_emacs_mule): Mark variables that gcc
5132 -Wuninitialized does not deduce are never used uninitialized.
5133 (detect_coding_iso_2022): Initialize a local variable that might
5134 be used uninitialized. Leave a FIXME because it's not clear that
5135 this initialization is needed. (Bug#8211)
5136 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5137 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5138 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5139 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5140 Remove unused macros.
5141
5142 * category.c (hash_get_category_set): Remove unused local var.
5143 (copy_category_table): Now static, since it's not used elsewhere.
5144 * character.c (string_count_byte8): Likewise.
5145
5146 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5147 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5148
5149 * chartab.c (copy_sub_char_table): Now static, since it's not used
5150 elsewhere.
5151 (sub_char_table_ref_and_range, char_table_ref_and_range):
5152 Rename locals to avoid shadowing.
5153 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5154
5155 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5156 (BIDI_BOB): Remove unused macro.
5157
5158 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5159 deduce are never used uninitialized.
5160 * term.c (encode_terminal_code): Likewise.
5161
5162 * term.c (encode_terminal_code): Now static. Remove unused local.
5163
5164 * tparam.h: New file.
5165 * term.c, tparam.h: Include it.
5166 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5167 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5168 Move these decls to tparam.h, and make them agree with what
5169 is actually in tparam.c. The previous trick of using incompatible
5170 decls in different modules does not conform to the C standard.
5171 All callers of tparam changed to use tparam's actual API.
5172 * tparam.c (tparam1, tparam, tgoto):
5173 Use const pointers where appropriate.
5174
5175 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5176 * cm.h (struct cm): Likewise.
5177 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5178 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5179 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5180 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5181 (turn_on_face, init_tty): Likewise.
5182 * termchar.h (struct tty_display_info): Likewise.
5183
5184 * term.c (term_mouse_position): Rename local to avoid shadowing.
5185
5186 * alloc.c (mark_ttys): Move decl from here ...
5187 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5188
5189 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5190
5191 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5192
5193 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5194
5195 * search.c (compile_pattern_1): Remove argument regp, unused since
5196 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5197 (compile_pattern): Don't pass it.
5198
5199 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5200
5201 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5202 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5203 for ! HAVE_GTK3.
5204 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5205
5206 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5207
5208 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5209 gdk_window_get_screen, gdk_window_get_geometry,
5210 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5211 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5212 (xg_get_pixbuf_from_pixmap): New function.
5213 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5214 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5215 Call xg_get_pixbuf_from_pixmap instead of
5216 gdk_pixbuf_get_from_drawable.
5217 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5218 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5219 (xg_check_special_colors): Use GtkStyleContext and its functions
5220 for HAVE_GTK3.
5221 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5222 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5223 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5224 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5225 Call gtk_widget_get_preferred_size.
5226 (xg_frame_resized): gdk_window_get_geometry only takes 5
5227 parameters.
5228 (xg_win_to_widget, xg_event_is_for_menubar):
5229 Call gdk_x11_window_lookup_for_display.
5230 (xg_set_widget_bg): New function.
5231 (delete_cb): New function.
5232 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5233 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5234 (xg_set_background_color): Call xg_set_widget_bg.
5235 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5236 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5237 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5238 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5239 if ! HAVE_GTK3.
5240 (update_frame_tool_bar): Call gtk_widget_hide.
5241 (xg_initialize): Use GDK_KEY_g.
5242
5243 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5244 if ! HAVE_GTK3
5245 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5246
5247 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5248 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5249 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5250
5251 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5252
5253 * w32xfns.c (select_palette): Check success of RealizePalette against
5254 GDI_ERROR, not zero.
5255
5256 See ChangeLog.11 for earlier changes.
5257
5258 ;; Local Variables:
5259 ;; coding: utf-8
5260 ;; End:
5261
5262 Copyright (C) 2011 Free Software Foundation, Inc.
5263
5264 This file is part of GNU Emacs.
5265
5266 GNU Emacs is free software: you can redistribute it and/or modify
5267 it under the terms of the GNU General Public License as published by
5268 the Free Software Foundation, either version 3 of the License, or
5269 (at your option) any later version.
5270
5271 GNU Emacs is distributed in the hope that it will be useful,
5272 but WITHOUT ANY WARRANTY; without even the implied warranty of
5273 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5274 GNU General Public License for more details.
5275
5276 You should have received a copy of the GNU General Public License
5277 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.