* lread.c (intern, intern_c_string): Don't assume strlen fits in int.
[bpt/emacs.git] / src / ChangeLog
1 2011-06-20 Paul Eggert <eggert@cs.ucla.edu>
2
3 * lread.c (intern, intern_c_string):
4 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5 Don't assume string length fits in int.
6
7 * keyboard.c (parse_tool_bar_item):
8 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9
10 * font.c: Don't assume string length fits in int.
11 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
12 Use ptrdiff_t, not int.
13 (font_intern_prop): Don't assume string length fits in int.
14 Don't assume integer property fits in fixnum.
15 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
16
17 * filelock.c: Fix some buffer overrun and integer overflow issues.
18 (get_boot_time): Don't assume that gzip command string fits in 100 bytes.
19 Reformulate so as not to need the command string.
20 Invoke gzip -cd rather than gunzip, as it's more portable.
21 (lock_info_type, lock_file_1, lock_file):
22 Don't assume pid_t and time_t fit in unsigned long.
23 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
24 (current_lock_owner): Prefer signed type for sizes.
25 Use memcpy, not strncpy, where memcpy is what is really wanted.
26 Don't assume (via atoi) that time_t and pid_t fit in int.
27 Check for time_t and/or pid_t out of range, e.g., via a network share.
28 Don't alloca where an auto var works fine.
29
30 2011-06-19 Paul Eggert <eggert@cs.ucla.edu>
31
32 * fileio.c: Fix some integer overflow issues.
33 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
34 Don't assume string length fits in int.
35 (directory_file_name): Don't assume string length fits in long.
36 (make_temp_name): Don't assume pid fits in int, or that its print
37 length is less than 20.
38
39 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
40
41 * coding.c (make_subsidiaries): Don't assume string length fits in int.
42
43 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
44
45 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
46 We prefer signed integers, even for size calculations.
47
48 * emacs.c: Don't assume string length fits in 'int'.
49 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
50 (main): Don't invoke strlen when not needed.
51
52 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
53 (XD_DEBUG_MESSAGE): Don't waste a byte.
54
55 * callproc.c (getenv_internal_1, getenv_internal)
56 (Fgetenv_internal):
57 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
58
59 * lread.c (invalid_syntax): Omit length argument.
60 All uses changed. This doesn't fix a bug, but it simplifies the
61 code away from its former Hollerith-constant appearance, and it's
62 one less 'int' to worry about when looking at integer-overflow issues.
63 (string_to_number): Simplify the 2011-04-26 change by invoking xsignal1.
64
65 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
66 This didn't break anything, but it didn't help either.
67 It's confusing to put a bogus integer in a place where the actual
68 value does not matter.
69 (LIST_END_P): Remove unused macro and its bogus comment.
70 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
71
72 2011-06-18 Paul Eggert <eggert@cs.ucla.edu>
73
74 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
75 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
76 implementation.
77 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
78 We prefer signed types, and the value cannot exceed the EMACS_INT
79 range anyway (because otherwise the length would not be representable).
80 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
81 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
82 This avoids a GCC warning when WIDE_EMACS_INT.
83
84 * indent.c (sane_tab_width): New function.
85 (current_column, scan_for_column, Findent_to, position_indentation)
86 (compute_motion): Use it. This is just for clarity.
87 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
88
89 * image.c (xbm_image_p): Don't assume stated width and height fit in int.
90
91 * lisp.h (lint_assume): New macro.
92 * composite.c (composition_gstring_put_cache):
93 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
94
95 * editfns.c, insdel.c:
96 Omit unnecessary forward decls, to simplify future changes.
97
98 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
99
100 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
101
102 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
103 Use much-faster test for byte-length change.
104 Don't assume string byte-length fits in 'int'.
105 Check that character arg fits in 'int'.
106 (mapcar1): Declare byte as byte, for clarity.
107
108 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
109
110 * fns.c (concat): Catch string overflow earlier.
111 Do not rely on integer wraparound.
112
113 * dispextern.h (struct it.overlay_strings_charpos): EMACS_INT, not int.
114
115 2011-06-17 Paul Eggert <eggert@cs.ucla.edu>
116
117 * dispextern.h (struct it.selective): Now EMACS_INT, not int.
118 * xdisp.c (forward_to_next_line_start)
119 (back_to_previous_visible_line_start)
120 (reseat_at_next_visible_line_start, next_element_from_buffer):
121 Don't arbitrarily truncate the value of 'selective' to int.
122
123 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
124
125 * composite.c: Don't truncate sizes to 'int'.
126 (composition_gstring_p, composition_reseat_it)
127 (composition_adjust_point): Use EMACS_INT, not int.
128 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
129 not EMACS_UINT, for indexes.
130
131 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
132
133 * buffer.c: Include <verify.h>.
134 (struct sortvec.priority, struct sortstr.priority):
135 Now EMACS_INT, not int.
136 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
137 (struct sortstr.size, record_overlay_string)
138 (struct sortstrlist.size, struct sortlist.used):
139 Don't truncate size to int.
140 (record_overlay_string): Check for size-calculation overflow.
141 (init_buffer_once): Check at compile-time, not run-time.
142
143 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
144
145 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
146 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
147 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
148
149 Improve buffer-overflow checking (Bug#8873).
150 * fileio.c (Finsert_file_contents):
151 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
152 Remove the old (too-loose) buffer overflow checks.
153 They weren't needed, since make_gap checks for buffer overflow.
154 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
155 The old code merely checked for Emacs fixnum overflow, and relied
156 on undefined (wraparound) behavior. The new code avoids undefined
157 behavior, and also checks for ptrdiff_t and/or size_t overflow.
158
159 * editfns.c (Finsert_char): Don't dump core with very negative counts.
160 Tune. Don't use wider integers than needed. Don't use alloca.
161 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
162
163 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
164
165 * insdel.c, lisp.h (buffer_overflow): New function.
166 (insert_from_buffer_1, replace_range, replace_range_2):
167 * insdel.c (make_gap_larger):
168 * editfns.c (Finsert_char):
169 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
170
171 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
172
173 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
174
175 Integer overflow and signedness fixes (Bug#8873).
176
177 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
178 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
179
180 * fileio.c: Don't assume EMACS_INT fits in off_t.
181 (emacs_lseek): New static function.
182 (Finsert_file_contents, Fwrite_region): Use it.
183 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
184
185 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
186
187 * fns.c: Don't overflow int when computing a list length.
188 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
189 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
190 truncation on 64-bit hosts. Check for QUIT every
191 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
192 faster and is responsive enough.
193 (Flength): Report an error instead of overflowing an integer.
194 (Fsafe_length): Return a float if the value is not representable
195 as a fixnum. This shouldn't happen except in contrived situations.
196 (Fnthcdr, Fsort): Don't assume list length fits in int.
197 (Fcopy_sequence): Don't assume vector length fits in int.
198
199 * alloc.c: Check that resized vectors' lengths fit in fixnums.
200 (header_size, word_size): New constants.
201 (allocate_vectorlike): Don't check size overflow here.
202 (allocate_vector): Check it here instead, since this is the only
203 caller of allocate_vectorlike that could cause overflow.
204 Check that the new vector's length is representable as a fixnum.
205
206 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
207 The previous code was bogus. For example, next_almost_prime (32)
208 returned 39, which is undesirable as it is a multiple of 3; and
209 next_almost_prime (24) returned 25, which is a multiple of 5 so
210 why was the code bothering to check for multiples of 7?
211
212 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
213
214 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
215
216 Variadic C functions now count arguments with ptrdiff_t.
217 This partly undoes my 2011-03-30 change, which replaced int with size_t.
218 Back then I didn't know that the Emacs coding style prefers signed int.
219 Also, in the meantime I found a few more instances where arguments
220 were being counted with int, which may truncate counts on 64-bit
221 machines, or EMACS_INT, which may be unnecessarily wide.
222 * lisp.h (struct Lisp_Subr.function.aMANY)
223 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
224 Arg counts are now ptrdiff_t, not size_t.
225 All variadic functions and their callers changed accordingly.
226 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
227 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
228 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
229 * callint.c (Fcall_interactively): Check arg count for overflow,
230 to avoid potential buffer overrun. Use signed char, not 'int',
231 for 'varies' array, so that we needn't bother to check its size
232 calculation for overflow.
233 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
234 * eval.c (apply_lambda):
235 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
236 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
237 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
238
239 * callint.c (Fcall_interactively): Don't use index var as event count.
240
241 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
242 * mem-limits.h (SIZE): Remove; no longer used.
243
244 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
245
246 Remove unnecessary casts.
247 * xterm.c (x_term_init):
248 * xfns.c (x_set_border_pixel):
249 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
250 These aren't needed now that we assume ANSI C.
251
252 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
253 It's more likely to cause problems (due to unsigned overflow)
254 than to cure them.
255
256 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
257
258 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
259
260 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
261
262 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
263
264 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
265
266 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
267
268 GLYPH_CODE_FACE returns EMACS_INT, not int.
269 * dispextern.h (merge_faces):
270 * xfaces.c (merge_faces):
271 * xdisp.c (get_next_display_element, next_element_from_display_vector):
272 Don't assume EMACS_INT fits in int.
273
274 * character.h (CHAR_VALID_P): Remove unused parameter.
275 * fontset.c, lisp.h, xdisp.c: All uses changed.
276
277 * editfns.c (Ftranslate_region_internal): Omit redundant test.
278
279 * fns.c (concat): Minor tuning based on overflow analysis.
280 This doesn't fix any bugs. Use int to hold character, instead
281 of constantly refetching from Emacs object. Use XFASTINT, not
282 XINT, for value known to be a character. Don't bother comparing
283 a single byte to 0400, as it's always less.
284
285 * floatfns.c (Fexpt):
286 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
287
288 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
289 for characters.
290
291 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
292
293 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
294 Without this fix, on a 64-bit host (aset S 0 4294967386) would
295 incorrectly succeed when S was a string, because 4294967386 was
296 truncated before it was used.
297
298 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
299 Otherwise, an out-of-range integer could cause undefined behavior
300 on a 64-bit host.
301
302 * composite.c: Use int, not EMACS_INT, for characters.
303 (fill_gstring_body, composition_compute_stop_pos): Use int, not
304 EMACS_INT, for values that are known to be in character range.
305 This doesn't fix any bugs but is the usual style inside Emacs and
306 may generate better code on 32-bit machines.
307
308 Make sure a 64-bit char is never passed to ENCODE_CHAR.
309 This is for reasons similar to the recent CHAR_STRING fix.
310 * charset.c (Fencode_char): Check that character arg is actually
311 a character. Pass an int to ENCODE_CHAR.
312 * charset.h (ENCODE_CHAR): Verify that the character argument is no
313 wider than 'int', as a compile-time check to prevent future regressions
314 in this area.
315
316 * character.c (char_string): Remove unnecessary casts.
317
318 Make sure a 64-bit char is never passed to CHAR_STRING.
319 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
320 by silently ignoring the top 32 bits, allowing some values
321 that were far too large to be valid characters.
322 * character.h: Include <verify.h>.
323 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
324 arguments are no wider than unsigned, as a compile-time check
325 to prevent future regressions in this area.
326 * data.c (Faset):
327 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
328 (Fsubst_char_in_region):
329 * fns.c (concat):
330 * xdisp.c (decode_mode_spec_coding):
331 Adjust to CHAR_STRING's new requirement.
332 * editfns.c (Finsert_char, Fsubst_char_in_region):
333 * fns.c (concat): Check that character args are actually
334 characters. Without this test, these functions did the wrong
335 thing with wildly out-of-range values on 64-bit hosts.
336
337 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
338 These casts should not be needed on 32-bit hosts, either.
339 * keyboard.c (read_char):
340 * lread.c (Fload): Remove casts to unsigned.
341
342 * lisp.h (UNSIGNED_CMP): New macro.
343 This fixes comparison bugs on 64-bit hosts.
344 (ASCII_CHAR_P): Use it.
345 * casefiddle.c (casify_object):
346 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
347 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
348 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
349 * dispextern.h (FACE_FROM_ID):
350 * keyboard.c (read_char): Use UNSIGNED_CMP.
351
352 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
353 not to EMACS_INT, to avoid GCC warning.
354
355 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
356
357 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
358 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
359 isn't needed on 32-bit machines.
360
361 * buffer.c (Fgenerate_new_buffer_name):
362 Use EMACS_INT for count, not int.
363 (advance_to_char_boundary): Return EMACS_INT, not int.
364
365 * data.c (Qcompiled_function): Now static.
366
367 * window.c (window_body_lines): Now static.
368
369 * image.c (gif_load): Rename local to avoid shadowing.
370
371 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
372 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
373 * alloc.c (make_save_value): Integer argument is now of type
374 ptrdiff_t, not int.
375 (mark_object): Use ptrdiff_t, not int.
376 * lisp.h (pD): New macro.
377 * print.c (print_object): Use it.
378
379 * alloc.c: Use EMACS_INT, not int, to count objects.
380 (total_conses, total_markers, total_symbols, total_vector_size)
381 (total_free_conses, total_free_markers, total_free_symbols)
382 (total_free_floats, total_floats, total_free_intervals)
383 (total_intervals, total_strings, total_free_strings):
384 Now EMACS_INT, not int. All uses changed.
385 (Fgarbage_collect): Compute overall total using a double, so that
386 integer overflow is less likely to be a problem. Check for overflow
387 when converting back to an integer.
388 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
389 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
390 These were 'int' variables that could overflow on 64-bit hosts;
391 they were never used, so remove them instead of repairing them.
392 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
393 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
394 Previously, this ceilinged at INT_MAX, but that doesn't work on
395 64-bit machines.
396 (allocate_pseudovector): Don't use EMACS_INT when int would do.
397
398 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
399 (allocate_vectorlike): Check for ptrdiff_t overflow.
400 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
401 when a (possibly-narrower) signed value would do just as well.
402 We prefer using signed arithmetic, to avoid comparison confusion.
403
404 * alloc.c: Catch some string size overflows that we were missing.
405 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
406 for convenience in STRING_BYTES_MAX.
407 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
408 The definition here is exact; the one in lisp.h was approximate.
409 (allocate_string_data): Check for string overflow. This catches
410 some instances we weren't catching before. Also, it catches
411 size_t overflow on (unusual) hosts where SIZE_MAX <= min
412 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
413 and ptrdiff_t and EMACS_INT are both 64 bits.
414
415 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
416 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
417 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
418
419 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
420
421 * alloc.c (Fmake_string): Check for out-of-range init.
422
423 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
424
425 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
426
427 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
428
429 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
430 xg_get_default_scrollbar_width.
431
432 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
433 (int_gtk_range_get_value): Move to the scroll bar part of the file.
434 (style_changed_cb): Call update_theme_scrollbar_width and call
435 x_set_scroll_bar_default_width and xg_frame_set_char_size for
436 all frames (Bug#8505).
437 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
438 Call gtk_window_set_resizable if HAVE_GTK3.
439 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
440 and height if HAVE_GTK3 (Bug#8505).
441 (scroll_bar_width_for_theme): New variable.
442 (update_theme_scrollbar_width): New function.
443 (xg_get_default_scrollbar_width): Move code to
444 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
445 (xg_initialize): Call update_theme_scrollbar_width.
446
447 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
448
449 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
450
451 2011-06-12 Martin Rudalics <rudalics@gmx.at>
452
453 * frame.c (make_frame): Call other_buffer_safely instead of
454 other_buffer.
455
456 * window.c (temp_output_buffer_show): Call display_buffer with
457 second argument Vtemp_buffer_show_specifiers and reset latter
458 immediately after the call.
459 (Vtemp_buffer_show_specifiers): New variable.
460 (auto_window_vscroll_p, next_screen_context_lines)
461 (Vscroll_preserve_screen_position): Remove leading asterisks from
462 doc-strings.
463
464 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
465
466 Fix minor problems found by GCC 4.6.0 static checking.
467 * buffer.c (Qclone_number): Remove for now, as it's unused.
468 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
469 (record_buffer): Remove unused local.
470 * frame.c (other_visible_frames, frame_buffer_list): Now static.
471 (set_frame_buffer_list): Remove; unused.
472 * frame.h (other_visible_frames): Remove decl.
473 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
474 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
475 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
476 if HAVE_GPM.
477 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
478 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
479 Define only if HAVE_GPM.
480 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
481 (update_hints_inhibit): Remove; never set. All uses removed.
482 * widgetprv.h (emacsFrameClassRec): Remove decl.
483 * window.c (delete_deletable_window): Now returns void, since it
484 wasn't returning anything.
485 (compare_window_configurations): Remove unused locals.
486 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
487 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
488 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
489 the same widths as pointers. This follows up on the 2011-05-06 patch.
490 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
491 * xterm.h: Likewise.
492 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
493
494 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
495
496 * makefile.w32-in: Update dependencies.
497 (LISP_H): Add lib/intprops.h.
498
499 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
500
501 * image.c (gif_load): Add animation frame delay to the metadata.
502 (syms_of_image): Use DEFSYM. New symbol `delay'.
503
504 2011-06-11 Martin Rudalics <rudalics@gmx.at>
505
506 * window.c (delete_deletable_window): Re-add.
507 (Fset_window_configuration): Rewrite to handle dead buffers and
508 consequently deletable windows.
509 (window_tree, Fwindow_tree): Remove. Supply functionality in
510 window.el.
511 (compare_window_configurations): Simplify code.
512
513 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
514
515 * image.c (imagemagick_load_image): Fix type mismatch.
516 (Fimagemagick_types): Likewise.
517
518 * window.h (replace_buffer_in_windows): Declare.
519
520 2011-06-11 Martin Rudalics <rudalics@gmx.at>
521
522 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
523 Qclone_number. Remove external declaration of Qdelete_window.
524 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
525 code.
526 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
527 Qbuffer_list_update_hook if allowed.
528 (Fother_buffer): Rewrite doc-string. Major rewrite for new
529 buffer list implementation.
530 (other_buffer_safely): New function.
531 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
532 calls to replace_buffer_in_windows and
533 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
534 if allowed.
535 (record_buffer): Inhibit quitting and rewrite using quittable
536 functions. Run Qbuffer_list_update_hook if allowed.
537 (Frecord_buffer, Funrecord_buffer): New functions.
538 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
539 switch-to-buffer to window.el.
540 (bury-buffer): Move to window.el.
541 (Vbuffer_list_update_hook): New variable.
542
543 * lisp.h (other_buffer_safely): Add prototype in buffer.c
544 section.
545
546 * window.h (resize_frame_windows): Move up in code.
547 (Fwindow_frame): Remove EXFUN.
548 (replace_buffer_in_all_windows): Remove prototype.
549 (replace_buffer_in_windows_safely): Add prototype.
550
551 * window.c: Declare Qdelete_window static again. Move down
552 declaration of select_count.
553 (Fnext_window, Fprevious_window): Rewrite doc-strings.
554 (Fother_window): Move to window.el.
555 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
556 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
557 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
558 window.el.
559 (replace_buffer_in_windows): Implement by calling
560 Qreplace_buffer_in_windows.
561 (replace_buffer_in_all_windows): Remove with some functionality
562 moved into replace_buffer_in_windows_safely.
563 (replace_buffer_in_windows_safely): New function.
564 (select_window_norecord, select_frame_norecord): Move in front
565 of run_window_configuration_change_hook. Remove now obsolete
566 declarations.
567 (Fset_window_buffer): Rewrite doc-string. Call
568 Qrecord_window_buffer.
569 (keys_of_window): Move binding for other-window to window.el.
570
571 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
572
573 * dispextern.h (struct image): Replace data member, whose int_val
574 and ptr_val fields were not used by anything, with a single
575 lisp_val object.
576
577 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
578 (gif_clear_image, gif_load, imagemagick_load_image)
579 (gs_clear_image, gs_load): Callers changed.
580
581 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
582
583 * buffer.h: Include <time.h>, for time_t.
584 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
585
586 Fix minor problems found by static checking.
587
588 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
589
590 Make identifiers static if they are not used in other modules.
591 * data.c (Qcompiled_function, Qframe, Qvector):
592 * image.c (QimageMagick, Qsvg):
593 * minibuf.c (Qmetadata):
594 * window.c (resize_window_check, resize_root_window): Now static.
595 * window.h (resize_window_check, resize_root_window): Remove decls.
596
597 * window.c (window_deletion_count, delete_deletable_window):
598 Remove; unused.
599 (window_body_lines): Now static.
600 (Fdelete_other_windows_internal): Mark vars as initialized.
601 Make sure 'resize_failed' is initialized.
602 (run_window_configuration_change_hook): Rename local to avoid shadowing.
603 (resize_window_apply): Remove unused local.
604 * window.h (delete_deletable_window): Remove decl.
605
606 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
607 (imagemagick_load_image): Fix pointer signedness problem by changing
608 last arg from unsigned char * to char *. All uses changed.
609 Also, fix a local for similar reasons.
610 Remove unused locals. Remove locals to avoid shadowing.
611 (fn_rsvg_handle_free): Remove; unused.
612 (svg_load, svg_load_image): Fix pointer signedness problem.
613 (imagemagick_load_image): Don't use garbage pointer image_wand.
614
615 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
616
617 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
618
619 * image.c (gif_load): Fix omitted cast error introduced by
620 2011-06-06 change.
621
622 2011-06-10 Martin Rudalics <rudalics@gmx.at>
623
624 * window.h (resize_proportionally, orig_total_lines)
625 (orig_top_line): Remove from window structure.
626 (set_window_height, set_window_width, change_window_heights)
627 (Fdelete_window): Remove prototypes.
628 (resize_frame_windows): Remove duplicate declaration.
629
630 2011-06-10 Eli Zaretskii <eliz@gnu.org>
631
632 * window.h (resize_frame_windows, resize_window_check)
633 (delete_deletable_window, resize_root_window)
634 (resize_frame_windows): Declare prototypes.
635
636 * window.c (resize_window_apply): Make definition be "static" to
637 match the prototype.
638
639 2011-06-10 Martin Rudalics <rudalics@gmx.at>
640
641 * window.c: Remove declarations of Qwindow_size_fixed,
642 window_min_size_1, window_min_size_2, window_min_size,
643 size_window, window_fixed_size_p, enlarge_window, delete_window.
644 Remove static from declaration of Qdelete_window, it's
645 temporarily needed by Fbury_buffer.
646 (replace_window): Don't assign orig_top_line and
647 orig_total_lines.
648 (Fdelete_window, delete_window): Remove. Window deletion is
649 handled by window.el.
650 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
651 Fdelete_window calls with calls to Qdelete_window.
652 (Fdelete_other_windows): Remove. Deleting other windows is
653 handled by window.el.
654 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
655 handled in window.el.
656 (window_min_size_2, window_min_size_1, window_min_size): Remove.
657 Window minimum sizes are handled in window.el.
658 (shrink_windows, size_window, set_window_height)
659 (set_window_width, change_window_heights, window_height)
660 (window_width, CURBEG, CURSIZE, enlarge_window)
661 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
662 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
663 handled in window.el.
664 (make_dummy_parent): Rename to make_parent_window and give it a
665 second argument horflag.
666 (make_window): Don't set resize_proportionally any more.
667 (Fsplit_window): Remove. Windows are split in window.el.
668 (save_restore_action, save_restore_orig_size)
669 (shrink_window_lowest_first, save_restore_orig_size): Remove.
670 Resize mini windows in window.el.
671 (grow_mini_window, shrink_mini_window): Implement by calling
672 Qresize_root_window_vertically, resize_window_check and
673 resize_window_apply.
674 (saved_window, Fset_window_configuration, save_window_save): Do
675 not handle orig_top_line, orig_total_lines, and
676 resize_proportionally.
677 (window_min_height, window_min_width): Move to window.el.
678 (keys_of_window): Move bindings for delete-other-windows,
679 split-window, delete-window and enlarge-window to window.el.
680
681 * buffer.c: Temporarily extern Qdelete_window.
682 (Fbury_buffer): Temporarily call Qdelete_window instead of
683 Fdelete_window (Fbury_buffer will move to window.el soon).
684
685 * frame.c (set_menu_bar_lines_1): Remove code handling
686 orig_top_line and orig_total_lines.
687
688 * dispnew.c (adjust_frame_glyphs_initially): Don't use
689 set_window_height but set heights directly.
690 (change_frame_size_1): Use resize_frame_windows.
691
692 * xdisp.c (init_xdisp): Don't use set_window_height but set
693 heights directly.
694
695 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
696 resize_frame_windows instead of change_window_heights and run
697 run_window_configuration_change_hook.
698
699 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
700 instead of change_window_heights and run
701 run_window_configuration_change_hook.
702
703 2011-06-09 Martin Rudalics <rudalics@gmx.at>
704
705 * window.c (replace_window): Rename second argument REPLACEMENT to
706 NEW. New third argument SETFLAG. Rewrite.
707 (delete_window, make_dummy_parent): Call replace_window with
708 third argument 1.
709 (window_list_1): Move down in code.
710 (run_window_configuration_change_hook): Move set_buffer part
711 before select_frame_norecord part in order to unwind correctly.
712 Rename count1 to count.
713 (recombine_windows, delete_deletable_window, resize_root_window)
714 (Fdelete_other_windows_internal)
715 (Frun_window_configuration_change_hook, make_parent_window)
716 (resize_window_check, resize_window_apply, Fresize_window_apply)
717 (resize_frame_windows, Fsplit_window_internal)
718 (Fdelete_window_internal, Fresize_mini_window_internal): New
719 functions.
720 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
721
722 2011-06-08 Martin Rudalics <rudalics@gmx.at>
723
724 * window.h (window): Add some new members to window structure -
725 normal_lines, normal_cols, new_total, new_normal, clone_number,
726 splits, nest, prev_buffers, next_buffers.
727 (WINDOW_TOTAL_SIZE): Move here from window.c.
728 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
729
730 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
731 Remove.
732 (make_dummy_parent): Set new members of windows structure.
733 (make_window): Move down in code. Handle new members of window
734 structure.
735 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
736 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
737 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
738 (Fset_window_prev_buffers, Fwindow_next_buffers)
739 (Fset_window_next_buffers, Fset_window_clone_number): New
740 functions.
741 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
742 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
743 Doc-string fixes.
744 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
745 Argument WINDOW can be now internal window too.
746 (Fwindow_use_time): Move up in code.
747 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
748 Rewrite doc-string.
749 (Fset_window_configuration, saved_window)
750 (Fcurrent_window_configuration, save_window_save): Handle new
751 members of window structure.
752 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
753 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
754 (syms_of_window): New Lisp objects Qrecord_window_buffer,
755 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
756 Qget_mru_window, Qresize_root_window,
757 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
758 Qauto_buffer_name; staticpro them.
759
760 2011-06-07 Martin Rudalics <rudalics@gmx.at>
761
762 * window.c (Fwindow_total_size, Fwindow_left_column)
763 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
764 (Fwindow_list_1): New functions.
765 (window_box_text_cols): Replace with window_body_cols.
766 (Fwindow_width, Fscroll_left, Fscroll_right): Use
767 window_body_cols instead of window_box_text_cols.
768 (delete_window, Fset_window_configuration): Call
769 delete_all_subwindows with window as argument.
770 (delete_all_subwindows): Take a window as argument and not a
771 structure. Rewrite.
772 (window_loop): Remove handling of GET_LRU_WINDOW and
773 GET_LARGEST_WINDOW.
774 (Fget_lru_window, Fget_largest_window): Move to window.el.
775
776 * window.h: Extern window_body_cols instead of
777 window_box_text_cols. delete_all_subwindows now takes a
778 Lisp_Object as argument.
779
780 * indent.c (compute_motion, Fcompute_motion): Use
781 window_body_cols instead of window_box_text_cols.
782
783 * frame.c (delete_frame): Call delete_all_subwindows with root
784 window as argument.
785
786 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
787
788 * fns.c (Fputhash): Document return value.
789
790 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
791
792 * image.c (gif_load): Implement gif89a spec "no disposal" method.
793
794 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
795
796 Cons<->int and similar integer overflow fixes (Bug#8794).
797
798 Check for overflow when converting integer to cons and back.
799 * charset.c (Fdefine_charset_internal, Fdecode_char):
800 Use cons_to_unsigned to catch overflow.
801 (Fencode_char): Use INTEGER_TO_CONS.
802 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
803 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
804 * data.c (long_to_cons, cons_to_long): Remove.
805 (cons_to_unsigned, cons_to_signed): New functions.
806 These signal an error for invalid or out-of-range values.
807 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
808 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
809 * font.c (Ffont_variation_glyphs):
810 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
811 * lisp.h: Include <intprops.h>.
812 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
813 (cons_to_signed, cons_to_unsigned): New decls.
814 (long_to_cons, cons_to_long): Remove decls.
815 * undo.c (record_first_change): Use INTEGER_TO_CONS.
816 (Fprimitive_undo): Use CONS_TO_INTEGER.
817 * xfns.c (Fx_window_property): Likewise.
818 * xselect.c: Include <limits.h>.
819 (x_own_selection, selection_data_to_lisp_data):
820 Use INTEGER_TO_CONS.
821 (x_handle_selection_request, x_handle_selection_clear)
822 (x_get_foreign_selection, Fx_disown_selection_internal)
823 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
824 (lisp_data_to_selection_data): Use cons_to_unsigned.
825 (x_fill_property_data): Use cons_to_signed.
826 Report values out of range.
827
828 Check for buffer and string overflow more precisely.
829 * buffer.h (BUF_BYTES_MAX): New macro.
830 * lisp.h (STRING_BYTES_MAX): New macro.
831 * alloc.c (Fmake_string):
832 * character.c (string_escape_byte8):
833 * coding.c (coding_alloc_by_realloc):
834 * doprnt.c (doprnt):
835 * editfns.c (Fformat):
836 * eval.c (verror):
837 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
838 since they may not be the same number.
839 * editfns.c (Finsert_char):
840 * fileio.c (Finsert_file_contents):
841 Likewise for BUF_BYTES_MAX.
842
843 * image.c: Use ptrdiff_t, not int, for sizes.
844 (slurp_file): Switch from int to ptrdiff_t.
845 All uses changed.
846 (slurp_file): Check that file size fits in both size_t (for
847 malloc) and ptrdiff_t (for sanity and safety).
848
849 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
850 if b->modtime has its maximal value.
851
852 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
853
854 Don't assume time_t can fit into int.
855 * buffer.h (struct buffer.modtime): Now time_t, not int.
856 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
857 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
858
859 Minor fixes for signed vs unsigned integers.
860 * character.h (MAYBE_UNIFY_CHAR):
861 * charset.c (maybe_unify_char):
862 * keyboard.c (read_char, reorder_modifiers):
863 XINT -> XFASTINT, since the integer must be nonnegative.
864 * ftfont.c (ftfont_spec_pattern):
865 * keymap.c (access_keymap, silly_event_symbol_error):
866 XUINT -> XFASTINT, since the integer must be nonnegative.
867 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
868 since it makes no difference and we prefer signed.
869 * keyboard.c (record_char): Use XUINT when all the neighbors do.
870 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
871 nonnegative.
872
873 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
874
875 * window.h (Fwindow_frame): Declare.
876
877 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
878
879 * alloc.c: Simplify handling of large-request failures (Bug#8800).
880 (SPARE_MEMORY): Always define.
881 (LARGE_REQUEST): Remove.
882 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
883
884 2011-06-06 Martin Rudalics <rudalics@gmx.at>
885
886 * lisp.h: Move EXFUNS for Fframe_root_window,
887 Fframe_first_window and Fset_frame_selected_window to window.h.
888
889 * window.h: Move EXFUNS for Fframe_root_window,
890 Fframe_first_window and Fset_frame_selected_window here from
891 lisp.h.
892
893 * frame.c (Fwindow_frame, Fframe_first_window)
894 (Fframe_root_window, Fframe_selected_window)
895 (Fset_frame_selected_window): Move to window.c.
896 (Factive_minibuffer_window): Move to minibuf.c.
897 (Fother_visible_frames_p): New function.
898
899 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
900
901 * window.c (decode_window, decode_any_window): Move up in code.
902 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
903 (inhibit_frame_unsplittable): Remove unused variable.
904 (Fwindow_buffer): Move up and rewrite doc-string.
905 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
906 (Fwindow_prev): New functions.
907 (Fwindow_frame): Move here from frame.c. Accept any window as
908 argument.
909 (Fframe_root_window, Fframe_first_window)
910 (Fframe_selected_window): Move here from frame.c. Accept frame
911 or arbitrary window as argument. Update doc-strings.
912 (Fminibuffer_window): Move up in code.
913 (Fwindow_minibuffer_p): Move up in code and simplify.
914 (Fset_frame_selected_window): Move here from frame.c.
915 Marginal rewrite.
916 (Fselected_window, select_window, Fselect_window): Move up in
917 code. Minor doc-string fixes.
918
919 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
920
921 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
922 Do not assume that spare memory exists; that assumption is valid
923 only if SYSTEM_MALLOC.
924 (LARGE_REQUEST): New macro, so that the issue of large requests
925 is separated from the issue of spare memory.
926
927 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
928
929 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
930 format. (Bug#8806)
931
932 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
933
934 * xfns.c (x_set_scroll_bar_default_width): Move declarations
935 before statements.
936
937 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
938
939 * gtkutil.c (xg_get_default_scrollbar_width): New function.
940
941 * gtkutil.h: Declare xg_get_default_scrollbar_width.
942
943 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
944 min width by calling x_set_scroll_bar_default_width (Bug#8505).
945
946 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
947
948 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
949
950 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
951
952 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
953 (x_clipboard_manager_save): Add return value.
954 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
955 New error handlers.
956 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
957 Obey Vx_select_enable_clipboard_manager. Catch errors in
958 x_clipboard_manager_save (Bug#8779).
959 (Vx_select_enable_clipboard_manager): New variable.
960 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
961
962 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
963
964 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
965
966 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
967
968 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
969 in the current matrix if keep_current_p is non-zero.
970
971 2011-06-04 Eli Zaretskii <eliz@gnu.org>
972
973 * bidi.c (bidi_level_of_next_char): Fix last change.
974
975 2011-06-03 Eli Zaretskii <eliz@gnu.org>
976
977 Support bidi reordering of text covered by display properties.
978
979 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
980 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
981 (bidi_cache_search, bidi_cache_iterator_state)
982 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
983 (bidi_level_of_next_char, bidi_move_to_visually_next):
984 Support character positions inside a run of characters covered by a
985 display string.
986 (bidi_paragraph_init, bidi_resolve_explicit_1)
987 (bidi_level_of_next_char): Call bidi_fetch_char and
988 bidi_fetch_char_advance instead of FETCH_CHAR and
989 FETCH_CHAR_ADVANCE.
990 (bidi_init_it): Initialize new members.
991 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
992 definitions.
993 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
994 instead of using explicit *_CHAR codes.
995 (bidi_resolve_explicit, bidi_resolve_weak):
996 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
997 bidirectional text is supported only in multibyte buffers.
998 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
999 it to initialize the frame_window_p member of struct bidi_it.
1000 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1001 (bidi_resolve_explicit, bidi_resolve_weak)
1002 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1003 bidi_it->nchars is non-positive.
1004 (bidi_level_of_next_char): Don't try to lookup the cache for the
1005 next/previous character if nothing is cached there yet, or if we
1006 were just reseat()'ed to a new position.
1007
1008 * xdisp.c (set_cursor_from_row): Set start and stop points
1009 according to the row's direction when priming the loop that looks
1010 for the glyph on which to display cursor.
1011 (single_display_spec_intangible_p): Function deleted.
1012 (display_prop_intangible_p): Reimplement to call
1013 handle_display_spec instead of single_display_spec_intangible_p.
1014 Accept 3 additional arguments needed by handle_display_spec.
1015 This fixes incorrect cursor motion across display property with complex
1016 values: lists, `(when COND...)' forms, etc.
1017 (single_display_spec_string_p): Support property values that are
1018 lists with the argument STRING its top-level element.
1019 (display_prop_string_p): Fix the condition for processing a
1020 property that is a list to be consistent with handle_display_spec.
1021 (handle_display_spec): New function, refactored from the
1022 last portion of handle_display_prop.
1023 (compute_display_string_pos): Accept additional argument
1024 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1025 value of a `display' property is a "replacing spec".
1026 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1027 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1028 the display property, but just return a value indicating whether
1029 the display property will replace the characters it covers.
1030 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1031 frame_window_p members of struct bidi_it.
1032 (compute_display_string_pos, compute_display_string_end):
1033 New functions.
1034 (push_it): Accept second argument POSITION, where pop_it should
1035 jump to continue iteration.
1036 (reseat_1): Initialize bidi_it.disp_pos.
1037
1038 * keyboard.c (adjust_point_for_property): Adjust the call to
1039 display_prop_intangible_p to its new signature.
1040
1041 * dispextern.h (struct bidi_it): New member frame_window_p.
1042 (bidi_init_it): Update prototypes.
1043 (display_prop_intangible_p): Update prototype.
1044 (compute_display_string_pos, compute_display_string_end):
1045 Declare prototypes.
1046 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1047 EMACS_INT.
1048
1049 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1050
1051 Malloc failure behavior now depends on size of allocation.
1052 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1053 * lisp.h: Change signatures accordingly.
1054 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1055 All callers changed. (Bug#8762)
1056
1057 * gnutls.c: Use Emacs's memory allocators.
1058 Without this change, the gnutls library would invoke malloc etc.
1059 directly, which causes problems on non-SYNC_INPUT hosts, and which
1060 runs afoul of improving memory_full behavior. (Bug#8761)
1061 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1062 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1063 xfree instead of the default malloc, realloc, free.
1064 (Fgnutls_boot): No need to check for memory allocation failure,
1065 since xmalloc does that for us.
1066
1067 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1068 * category.c (hash_get_category_set):
1069 * ccl.c (ccl_driver):
1070 * charset.c (Fdefine_charset_internal):
1071 * charset.h (struct charset.hash_index):
1072 * composite.c (get_composition_id, gstring_lookup_cache)
1073 (composition_gstring_put_cache):
1074 * composite.h (struct composition.hash_index):
1075 * dispextern.h (struct image.hash):
1076 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1077 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1078 (hashfn_equal, hashfn_user_defined, make_hash_table)
1079 (maybe_resize_hash_table, hash_lookup, hash_put)
1080 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1081 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1082 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1083 * image.c (make_image, search_image_cache, lookup_image)
1084 (xpm_put_color_table_h):
1085 * lisp.h (struct Lisp_Hash_Table):
1086 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1087 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1088 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1089 * alloc.c (allocate_vectorlike):
1090 Check for overflow in vector size calculations.
1091 * ccl.c (ccl_driver):
1092 Check for overflow when converting EMACS_INT to int.
1093 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1094 need to be updated by these changes.
1095 * fns.c (make_hash_table, maybe_resize_hash_table):
1096 Check for integer overflow with large hash tables.
1097 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1098 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1099 (SXHASH_REDUCE): New macro.
1100 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1101 Use it instead of discarding useful hash info with large hash values.
1102 (sxhash_float): New function.
1103 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1104 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1105 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1106 Rewrite to use FIXNUM_BITS, as this simplifies things.
1107 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1108 Adjust signatures to match updated version of code.
1109 (consing_since_gc): Now EMACS_INT, since a single hash table can
1110 use more than INT_MAX bytes.
1111
1112 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1113
1114 Make it possible to build with GCC-4.6+ -O2 -flto.
1115
1116 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1117
1118 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1119
1120 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1121 Call minibuffer-inactive-mode.
1122
1123 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1124
1125 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1126 Update dependencies.
1127
1128 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1129
1130 * data.c (init_data): Remove code for UTS, this system is not
1131 supported anymore.
1132
1133 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1134
1135 Don't force ./temacs to start in terminal mode.
1136
1137 * frame.c (make_initial_frame): Initialize faces in all cases, not
1138 only when CANNOT_DUMP is defined.
1139 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1140
1141 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1142
1143 * dispnew.c (add_window_display_history): Use const for the string
1144 pointer. Remove declaration, not needed.
1145
1146 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1147
1148 Use 'inline', not 'INLINE'.
1149 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1150 * alloc.c, fontset.c (INLINE): Remove.
1151 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1152 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1153 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1154 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1155 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1156
1157 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1158
1159 Make it possible to run ./temacs.
1160
1161 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1162 syms_of_callproc does the same thing. Remove test for
1163 "initialized", do it in the caller.
1164 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1165
1166 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1167
1168 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1169 (read_minibuf): Use get_minibuffer.
1170 (syms_of_minibuf): Use DEFSYM.
1171 (Qmetadata): New var.
1172 * data.c (Qbuffer): Don't make it static.
1173 (syms_of_data): Use DEFSYM.
1174
1175 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1176
1177 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1178 (CCL_CODE_MIN): New macro.
1179
1180 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1181
1182 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1183
1184 * eval.c (Qdebug): Now static.
1185 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1186 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1187 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1188
1189 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1190
1191 * image.c: Various fixes to ImageMagick code comments.
1192 (Fimagemagick_types): Doc fix.
1193
1194 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1195
1196 Minor fixes prompted by GCC 4.6.0 warnings.
1197
1198 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1199
1200 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1201 (x_clipboard_manager_save_all): Move extern decl to ...
1202 * xterm.h: ... here, so that it can be checked for consistency.
1203
1204 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1205
1206 * xselect.c (x_clipboard_manager_save_frame)
1207 (x_clipboard_manager_save_all): New functions.
1208 (Fx_clipboard_manager_save): Lisp function deleted.
1209
1210 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1211 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1212
1213 * xterm.h: Update prototype.
1214
1215 2011-05-28 William Xu <william.xwl@gmail.com>
1216
1217 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1218 exiting (Bug#8239).
1219
1220 2011-05-28 Jim Meyering <meyering@redhat.com>
1221
1222 Avoid a sign-extension bug in crypto_hash_function.
1223 * fns.c (to_uchar): Define.
1224 (crypto_hash_function): Use it to convert some newly-signed
1225 variables to unsigned, to avoid sign-extension bugs. For example,
1226 without this change, (md5 "truc") would evaluate to
1227 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1228 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1229 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1230
1231 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1232
1233 Integer overflow fixes.
1234
1235 * dbusbind.c: Serial number integer overflow fixes.
1236 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1237 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1238 to hold a serial number that is too large for a fixnum.
1239 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1240 Check for serial numbers out of range. Decode any serial number
1241 that was so large that it became a float. (Bug#8722)
1242
1243 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1244 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1245 Use XFASTINT rather than XUINT when numbers are nonnegative.
1246 (xd_append_arg, Fdbus_method_return_internal):
1247 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1248 arguments, check that Lisp number is nonnegative, rather than
1249 silently wrapping negative numbers around. (Bug#8722)
1250 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1251 (Bug#8722)
1252
1253 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1254
1255 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1256
1257 ccl: add integer overflow checks
1258 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1259 (IN_INT_RANGE): New macros.
1260 (ccl_driver): Use them to check for integer overflow when
1261 decoding a CCL program. Many of the new checks are whether XINT (x)
1262 fits in int; it doesn't always, on 64-bit hosts. The new version
1263 doesn't catch all possible integer overflows, but it's an
1264 improvement. (Bug#8719)
1265
1266 * alloc.c (make_event_array): Use XINT, not XUINT.
1267 There's no need for unsigned here.
1268
1269 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1270 This follows up to the 2011-05-06 change that substituted uintptr_t
1271 for EMACS_INT. This case wasn't caught back then.
1272
1273 Rework Fformat to avoid integer overflow issues.
1274 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1275 now (part of C89). Include <verify.h>.
1276 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1277 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1278 (Fformat): Avoid the prepass trying to compute sizes; it was only
1279 approximate and thus did not catch overflow reliably. Instead, walk
1280 through the format just once, formatting and computing sizes as we go,
1281 checking for integer overflow at every step, and allocating a larger
1282 buffer as needed. Keep track separately whether the format is
1283 multibyte. Keep only the most-recently calculated precision, rather
1284 than them all. Record whether each argument has been converted to
1285 string. Use EMACS_INT, not int, for byte and char and arg counts.
1286 Support field widths and precisions larger than INT_MAX. Avoid
1287 sprintf's undefined behavior with conversion specifications such as %#d
1288 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1289 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1290 formatting out-of-range floating point numbers with int
1291 formats. (Bug#8668)
1292
1293 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1294
1295 * data.c: Avoid integer truncation in expressions involving floats.
1296 * data.c: Include <intprops.h>.
1297 (arith_driver): When there's an integer overflow in an expression
1298 involving floating point, convert the integers to floating point
1299 so that the resulting value does not suffer from catastrophic
1300 integer truncation. For example, on a 64-bit host (* 4
1301 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1302 Do not rely on undefined behavior after integer overflow.
1303
1304 merge count_size_as_multibyte, parse_str_to_multibyte
1305 * character.c, character.h (count_size_as_multibyte):
1306 Rename from parse_str_to_multibyte; all uses changed.
1307 Check for integer overflow.
1308 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1309 since it's now a duplicate of the other. This is more of
1310 a character than a buffer op, so better that it's in character.c.
1311 * fns.c, print.c: Adjust to above changes.
1312
1313 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1314
1315 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1316
1317 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1318
1319 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1320 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1321 (x_clipboard_manager_save): Now static.
1322 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1323
1324 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1325 (crypto_hash_function): Now static.
1326 Fix pointer signedness problems. Avoid unnecessary initializations.
1327
1328 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1329
1330 * termhooks.h (Vselection_alist): Make it terminal-local.
1331
1332 * terminal.c (create_terminal): Initialize it.
1333
1334 * xselect.c: Support for clipboard managers.
1335 (Vselection_alist): Move to termhooks.h as terminal-local var.
1336 (LOCAL_SELECTION): New macro.
1337 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1338 (symbol_to_x_atom): Remove gratuitous arg.
1339 (x_handle_selection_request, lisp_data_to_selection_data)
1340 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1341 (x_own_selection, x_get_local_selection, x_convert_selection):
1342 New arg, specifying work frame. Use terminal-local Vselection_alist.
1343 (some_frame_on_display): Delete unused function.
1344 (Fx_own_selection_internal, Fx_get_selection_internal)
1345 (Fx_disown_selection_internal, Fx_selection_owner_p)
1346 (Fx_selection_exists_p): New optional frame arg.
1347 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1348 (x_handle_selection_clear): Don't treat other terminals with the
1349 same keyboard specially. Use the terminal-local Vselection_alist.
1350 (x_clear_frame_selections): Use Frun_hook_with_args.
1351
1352 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1353
1354 * xterm.h: Add support for those atoms.
1355
1356 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1357
1358 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1359 (converted_selections, conversion_fail_tag): New global variables.
1360 (x_selection_request_lisp_error): Free the above.
1361 (x_get_local_selection): Remove unnecessary code.
1362 (x_reply_selection_request): Args changed; handle arbitrary array
1363 of converted selections stored in converted_selections.
1364 Separate the XChangeProperty and SelectionNotify steps.
1365 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1366 (x_convert_selection): New function.
1367 (x_handle_selection_event): Simplify.
1368 (x_get_foreign_selection): Don't ignore incoming requests while
1369 waiting for an answer; this will fail when we implement
1370 SAVE_TARGETS, and seems unnecessary anyway.
1371 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1372 (Vx_sent_selection_functions): Doc fix.
1373
1374 2011-05-26 Leo Liu <sdl.web@gmail.com>
1375
1376 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1377
1378 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1379
1380 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1381
1382 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1383 for fringe update if it has periodic bitmap.
1384 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1385 and fringe_bitmap_periodic_p.
1386
1387 * fringe.c (get_fringe_bitmap_data): New function.
1388 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1389 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1390 row. Mark glyph row for fringe update if periodicity changed.
1391
1392 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1393 for fringe update unless it has periodic bitmap.
1394
1395 2011-05-25 Kenichi Handa <handa@m17n.org>
1396
1397 * xdisp.c (get_next_display_element): Set correct it->face_id for
1398 a static composition.
1399
1400 2011-05-24 Leo Liu <sdl.web@gmail.com>
1401
1402 * deps.mk (fns.o):
1403 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1404
1405 * fns.c (crypto_hash_function, Fsha1): New function.
1406 (Fmd5): Use crypto_hash_function.
1407 (syms_of_fns): Add Ssha1.
1408
1409 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1410
1411 * gnutls.c: Remove unused macros.
1412 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1413 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1414 Remove macros that are defined and never used.
1415 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1416
1417 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1418
1419 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1420 (Fx_get_selection_internal): Minor cleanup.
1421 (Fx_own_selection_internal): Rename arguments for consistency with
1422 select.el.
1423
1424 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1425
1426 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1427
1428 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1429
1430 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1431
1432 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1433
1434 * dispnew.c (scrolling_window): Don't exclude the case that the
1435 last enabled row in the desired matrix touches the bottom boundary.
1436
1437 2011-05-21 Glenn Morris <rgm@gnu.org>
1438
1439 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1440 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1441 and add some more files.
1442
1443 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1444
1445 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1446 report_file_error introduced by the change from 2011-05-07.
1447
1448 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1449
1450 * systime.h (Time): Define only if emacs is defined.
1451 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1452 where the include path doesn't have X11/X.h by default. See
1453 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1454
1455 2011-05-20 Kenichi Handa <handa@m17n.org>
1456
1457 * composite.c (find_automatic_composition): Fix previous change.
1458
1459 2011-05-20 Glenn Morris <rgm@gnu.org>
1460
1461 * lisp.mk: New file, split from Makefile.in.
1462 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1463 (shortlisp): Remove.
1464 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1465
1466 2011-05-19 Glenn Morris <rgm@gnu.org>
1467
1468 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1469 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1470 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1471 (lisp): Set the order to that of loadup.el.
1472 (shortlisp): Make it a copy of $lisp.
1473 (SOME_MACHINE_LISP): Remove.
1474 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1475 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1476
1477 2011-05-18 Kenichi Handa <handa@m17n.org>
1478
1479 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1480 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1481 (find_automatic_composition): Mostly rewrite for efficiency.
1482
1483 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1484
1485 * makefile.w32-in: Update dependencies.
1486
1487 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1488
1489 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1490 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1491
1492 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1493
1494 Fix some integer overflow issues, such as string length overflow.
1495
1496 * insdel.c (count_size_as_multibyte): Check for string overflow.
1497
1498 * character.c (lisp_string_width): Check for string overflow.
1499 Use EMACS_INT, not int, for string indexes and lengths; in
1500 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1501 the resulting string length overflows an EMACS_INT; instead,
1502 report a string overflow if no precision given. When checking for
1503 precision exhaustion, use a check that cannot possibly have
1504 integer overflow. (Bug#8675)
1505 * character.h (lisp_string_width): Adjust to new signature.
1506
1507 * alloc.c (string_overflow): New function.
1508 (Fmake_string): Use it. This doesn't change behavior, but saves
1509 a few bytes and will simplify future changes.
1510 * character.c (string_escape_byte8): Likewise.
1511 * lisp.h (string_overflow): New decl.
1512
1513 Fixups, following up to the user-interface timestamp change.
1514 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1515 for UI timestamps, instead of unsigned long.
1516 * msdos.c (mouse_get_pos): Likewise.
1517 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1518 * w32gui.h (Time): Define by including "systime.h" rather than by
1519 declaring it ourselves. (Bug#8664)
1520
1521 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1522 * image.c (clear_image_cache): Likewise.
1523
1524 * term.c (term_mouse_position): Don't assume time_t wraparound.
1525
1526 Be more systematic about user-interface timestamps.
1527 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1528 and sometimes 'EMACS_UINT', to represent these timestamps.
1529 This change causes it to use 'Time' uniformly, as that's what X uses.
1530 This makes the code easier to follow, and makes it easier to catch
1531 integer overflow bugs such as Bug#8664.
1532 * frame.c (Fmouse_position, Fmouse_pixel_position):
1533 Use Time, not unsigned long, for user-interface timestamps.
1534 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1535 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1536 * keyboard.h (last_event_timestamp): Likewise.
1537 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1538 * menu.h (xmenu_show): Likewise.
1539 * term.c (term_mouse_position): Likewise.
1540 * termhooks.h (struct input_event.timestamp): Likewise.
1541 (struct terminal.mouse_position_hook): Likewise.
1542 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1543 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1544 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1545 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1546 what it was before.
1547 * menu.h, termhooks.h: Include "systime.h", for Time.
1548
1549 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1550 Don't assume that the difference between two unsigned long values
1551 can fit into an integer. At this point, we know button_down_time
1552 <= event->timestamp, so the difference must be nonnegative, so
1553 there's no need to cast the result if double-click-time is
1554 nonnegative, as it should be; check that it's nonnegative, just in
1555 case. This bug is triggered when events are more than 2**31 ms
1556 apart (about 25 days). (Bug#8664)
1557
1558 * xselect.c (last_event_timestamp): Remove duplicate decl.
1559 (x_own_selection): Remove needless cast to unsigned long.
1560
1561 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1562 that always fit in int. Use a sentinel instead of a counter, to
1563 avoid a temp and to allay GCC's concerns about possible int overflow.
1564 * frame.h (struct frame): Use int for menu_bar_items_used
1565 instead of EMACS_INT, since it always fits in int.
1566
1567 * menu.c (grow_menu_items): Check for int overflow.
1568
1569 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1570
1571 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1572 Before, the code was not consistent. These values cannot exceed
1573 2**31 - 1 so there's no need to make them unsigned.
1574 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1575 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1576 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1577 as modifiers.
1578 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1579
1580 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1581 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1582 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1583 presumably because the widths might not match.
1584
1585 * window.c (size_window): Avoid needless test at loop start.
1586
1587 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1588
1589 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1590
1591 2011-05-12 Drew Adams <drew.adams@oracle.com>
1592
1593 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1594
1595 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1596
1597 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1598 `width' to `bar_area_x' and `bar_area_width', respectively.
1599 (x_scroll_run): Take account of fringe background extension.
1600
1601 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1602 Rename local vars `left' and `width' to `bar_area_x' and
1603 `bar_area_width', respectively.
1604 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1605 background extension.
1606
1607 2011-05-10 Jim Meyering <meyering@redhat.com>
1608
1609 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1610
1611 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1612
1613 * image.c (Finit_image_library): Return t for built-in image types,
1614 like pbm and xbm. (Bug#8640)
1615
1616 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1617
1618 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1619
1620 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1621
1622 * w32console.c (Fset_screen_color): Doc fix.
1623 (Fget_screen_color): New function.
1624 (syms_of_ntterm): Defsubr it.
1625
1626 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1627 unlink the temporary file if Fcall_process didn't create it in the
1628 first place.
1629 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1630 child process will be redirected to a file specified with `:file'.
1631 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1632 cue to call_process_cleanup not to close that handle.
1633
1634 2011-05-07 Ben Key <bkey76@gmail.com>
1635
1636 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1637 one of two shell specific rules, either bootstrap-temacs-CMD or
1638 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1639 to the previous implementation of the bootstrap-temacs rule.
1640 The bootstrap-temacs-CMD rule is similar to the previous
1641 implementation of the bootstrap-temacs rule except that it
1642 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1643 variable.
1644
1645 These changes, along with some changes to nt/configure.bat,
1646 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1647 earlier fix to add support for --cflags and --ldflags options
1648 that include quotes so that it works whether make uses cmd or
1649 sh as the shell.
1650
1651 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1652
1653 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1654 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1655 is a constant.
1656 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1657 a string. Handle both cases.
1658 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1659 (Fdbus_register_method): Use Qinvalid_function.
1660
1661 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1662
1663 * makefile.w32-in: Update dependencies.
1664 (LISP_H): Add inttypes.h and stdin.h.
1665 (PROCESS_H): Add unistd.h.
1666
1667 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1668
1669 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1670 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1671
1672 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1673
1674 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1675
1676 * term.c (vfatal): Remove stray call to va_end.
1677 It's not needed and the C Standard doesn't allow it here anyway.
1678
1679 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1680 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1681
1682 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1683 bytes.
1684
1685 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1686
1687 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1688
1689 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1690
1691 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1692
1693 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1694
1695 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1696 * charset.c (Fdefine_charset_internal): Don't initialize
1697 charset.code_space[15]. The value was garbage, on hosts with
1698 32-bit int (Bug#8600).
1699
1700 * lread.c (read_integer): Be more consistent with string-to-number.
1701 Use string_to_number to do the actual conversion; this avoids
1702 rounding errors and fixes some other screwups. Without this fix,
1703 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1704 (digit_to_number): Move earlier, for benefit of read_integer.
1705 Return -1 if the digit is out of range for the base, -2 if it is
1706 not a digit in any supported base. (Bug#8602)
1707
1708 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1709
1710 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1711 to match comment at start of function. This also removes a
1712 GCC warning about overflow in a 32+64-bit port.
1713
1714 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1715
1716 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1717 Reported by Stefan Monnier in
1718 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1719 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1720 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1721
1722 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1723 (EMACS_UINTPTR): Likewise, with uintptr_t.
1724
1725 * lisp.h: Prefer 64-bit EMACS_INT if available.
1726 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1727 on 32-bit hosts that have 64-bit int, so that they can access
1728 large files.
1729 However, temporarily disable this change unless the temporary
1730 symbol WIDE_EMACS_INT is defined.
1731
1732 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1733
1734 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1735 This removes an assumption that EMACS_INT and long are the same
1736 width as pointers. The assumption is true for Emacs porting targets
1737 now, but we want to make other targets possible.
1738 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1739 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1740 In the rest of the code, change types of integers that hold casted
1741 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1742 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1743 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1744 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1745 No need to cast type when ORing.
1746 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1747 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1748 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1749 assume EMACS_INT is the same width as char *.
1750 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1751 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1752 Remove no-longer-needed casts.
1753 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1754 (xg_tool_bar_help_callback, xg_make_tool_item):
1755 Use EMACS_INTPTR to hold an integer
1756 that will be cast to void *; this can avoid a GCC warning
1757 if EMACS_INT is not the same width as void *.
1758 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1759 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1760 (current_message_1, set_message_1):
1761 Use a local to convert to proper width without a cast.
1762 * xmenu.c (dialog_selection_callback): Likewise.
1763
1764 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1765 Also, don't assume VALBITS / RAND_BITS is less than 5,
1766 and don't rely on undefined behavior when shifting a 1 left into
1767 the sign bit.
1768 * lisp.h (get_random): Change signature to match.
1769
1770 * lread.c (hash_string): Use size_t, not int, for hash computation.
1771 Normally we prefer signed values; but hashing is special, because
1772 it's better to use unsigned division on hash table sizes so that
1773 the remainder is nonnegative. Also, size_t is the natural width
1774 for hashing into memory. The previous code used 'int', which doesn't
1775 retain enough info to hash well into very large tables.
1776 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1777
1778 * dbusbind.c: Don't possibly lose pointer info when converting.
1779 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1780 Use XPNTR rather than XHASH, so that the high-order bits of
1781 the pointer aren't lost when converting through void *.
1782
1783 * eval.c (Fautoload): Don't double-shift a pointer.
1784
1785 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1786
1787 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1788
1789 * gnutls.c (DEF_GNUTLS_FN):
1790 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1791
1792 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1793
1794 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1795 marker. (Bug#8610)
1796
1797 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1798
1799 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1800 New version that can reserve upto 2GB of heap space.
1801
1802 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1803
1804 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1805
1806 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1807
1808 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1809 `gnutls_certificate_set_x509_key_file'.
1810
1811 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1812
1813 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1814 Update dependencies.
1815
1816 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1817
1818 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1819 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1820 Remove unused parameter `fildes'.
1821 * process.c (read_process_output, send_process): Don't pass it.
1822
1823 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1824
1825 Fix previous change: the library cache is defined in w32.c.
1826 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1827 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1828
1829 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1830
1831 Implement dynamic loading of GnuTLS on Windows.
1832
1833 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1834 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1835 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1836 Declare.
1837
1838 * gnutls.c (Qgnutls_dll): Define.
1839 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1840 (gnutls_*): Declare function pointers.
1841 (init_gnutls_functions): New function to initialize function pointers.
1842 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1843 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1844 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1845 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1846 (emacs_gnutls_write, emacs_gnutls_read)
1847 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1848 (Fgnutls_available_p): New function.
1849 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1850 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1851 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1852
1853 * image.c: Include w32.h.
1854 (Vimage_type_cache): Delete.
1855 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1856 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1857 (w32_delayed_load): Move to w32.c.
1858
1859 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1860
1861 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1862 (w32_delayed_load): Move from image.c. When loading a library, record
1863 its filename in the :loaded-from property of the library id.
1864 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1865 Initialize and staticpro them.
1866 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1867
1868 * process.c: Include lisp.h before w32.h, not after.
1869 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1870 instead of gnutls_record_check_pending.
1871
1872 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1873
1874 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1875
1876 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1877 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1878 as passed in.
1879
1880 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1881
1882 * xterm.c (x_set_frame_alpha): Do not set property on anything
1883 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1884
1885 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1886
1887 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1888
1889 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1890
1891 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1892 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1893 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1894 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1895 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1896 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1897 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1898 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1899 (Qgnutls_bootprop_callbacks_verify): Make static.
1900
1901 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1902
1903 * callproc.c: Indentation fixup.
1904
1905 * sysdep.c (wait_for_termination_1): Make static.
1906 (wait_for_termination, interruptible_wait_for_termination):
1907 Move after wait_for_termination_1.
1908
1909 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1910
1911 * sysdep.c (interruptible_wait_for_termination): New function
1912 which is like wait_for_termination, but allows keyboard
1913 interruptions.
1914
1915 * callproc.c (Fcall_process): Add (:file "file") as an option for
1916 the STDOUT buffer.
1917 (Fcall_process_region): Ditto.
1918
1919 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1920
1921 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1922 rather than `XVECTOR (FOO)->size'.
1923
1924 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1925 inttypes.h, as a gnulib replacement is used if it not available in
1926 system headers.
1927
1928 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1929
1930 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1931 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1932 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1933
1934 * coding.c (coding_alloc_by_realloc): Error out if destination
1935 will grow beyond MOST_POSITIVE_FIXNUM.
1936 (decode_coding_emacs_mule): Abort if there isn't enough place in
1937 charbuf for the composition carryover bytes. Reserve an extra
1938 space for up to 2 characters produced in a loop.
1939 (decode_coding_iso_2022): Abort if there isn't enough place in
1940 charbuf for the composition carryover bytes.
1941
1942 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1943
1944 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1945 aborting when %lld or %lll format is passed.
1946 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1947 %llo or %llx format is passed. (Bug#8545)
1948
1949 * window.c (window_scroll_line_based): Use a marker instead of
1950 simple variables to record original value of point. (Bug#7952)
1951
1952 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1953 produced by %s or %c overflows available buffer space. (Bug#8545)
1954
1955 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1956
1957 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1958 (SIZE_MAX): Move defn after all includes, as they might #define it.
1959
1960 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1961
1962 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1963
1964 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1965
1966 * keyboard.c (Qdelayed_warnings_hook): Define.
1967 (command_loop_1): Run `delayed-warnings-hook'
1968 if Vdelayed_warnings_list is non-nil.
1969 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1970 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1971
1972 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1973
1974 * doprnt.c (doprnt): Don't return value smaller than the buffer
1975 size if the message was truncated. (Bug#8545).
1976
1977 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1978
1979 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1980 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1981
1982 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1983
1984 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1985
1986 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1987
1988 * makefile.w32-in: Update dependencies.
1989
1990 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1991
1992 Improve `doprnt' and its usage. (Bug#8545)
1993 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1994 `format_end'. Remove support for %l as a conversion specifier.
1995 Don't use xrealloc. Improve diagnostics when the %l size modifier
1996 is used. Update the commentary.
1997
1998 * eval.c (verror): Simplify calculation of size_t.
1999
2000 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2001 messages.
2002
2003 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2004
2005 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2006 change.
2007
2008 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2009
2010 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2011 This makes this file independent of the recent pseudovector change.
2012
2013 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2014
2015 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2016
2017 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2018 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2019 Remove unused local.
2020 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2021
2022 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2023 GCC 4.6.0 optimizes based on type-based alias analysis.
2024 For example, if b is of type struct buffer * and v of type struct
2025 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2026 != &v->size, and therefore "v->size = 1; b->size = 2; return
2027 v->size;" must therefore return 1. This assumption is incorrect
2028 for Emacs, since it type-puns struct Lisp_Vector * with many other
2029 types. To fix this problem, this patch adds a new type struct
2030 vectorlike_header that documents the constraints on layout of vectors
2031 and pseudovectors, and helps optimizing compilers not get fooled
2032 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2033 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2034 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2035 the size member.
2036 (XSETPVECTYPE): Rewrite in terms of new macro.
2037 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2038 This is a bit clearer, and further avoids the possibility of
2039 undesirable aliasing.
2040 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2041 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2042 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2043 since Lisp_Subr is a special case (no "next" field).
2044 (ASIZE): Now uses header.size rather than size.
2045 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2046 to avoid the hassle of writing XVECTOR (foo)->header.size.
2047 (struct vectorlike_header): New type.
2048 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2049 object, to help avoid aliasing.
2050 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2051 (SUBRP): Likewise, since Lisp_Subr is a special case.
2052 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2053 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2054 (struct Lisp_Hash_Table): Combine first two members into a single
2055 struct vectorlike_header member. All uses of "size" and "next" members
2056 changed to be "header.size" and "header.next".
2057 * buffer.h (struct buffer): Likewise.
2058 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2059 * frame.h (struct frame): Likewise.
2060 * process.h (struct Lisp_Process): Likewise.
2061 * termhooks.h (struct terminal): Likewise.
2062 * window.c (struct save_window_data, struct saved_window): Likewise.
2063 * window.h (struct window): Likewise.
2064 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2065 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2066 * buffer.c (init_buffer_once): Likewise.
2067 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2068 special case.
2069 * process.c (Fformat_network_address): Use local var for size,
2070 for brevity.
2071
2072 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2073
2074 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2075 * data.c (atof): Remove decl; no longer used or needed.
2076 (digit_to_number): Move to lread.c.
2077 (Fstring_to_number): Use new string_to_number function, to be
2078 consistent with how the Lisp reader treats infinities and NaNs.
2079 Do not assume that floating-point numbers represent EMACS_INT
2080 without losing information; this is not true on most 64-bit hosts.
2081 Avoid double-rounding errors, by insisting on integers when
2082 parsing non-base-10 numbers, as the documentation specifies.
2083 * lisp.h (string_to_number): New decl, replacing ...
2084 (isfloat_string): Remove.
2085 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2086 (read1): Do not accept +. and -. as integers; this
2087 appears to have been a coding error. Similarly, do not accept
2088 strings like +-1e0 as floating point numbers. Do not report
2089 overflow for integer overflows unless the base is not 10 which
2090 means we have no simple and reliable way to continue.
2091 Break out the floating-point parsing into a new
2092 function string_to_number, so that Fstring_to_number parses
2093 floating point numbers consistently with the Lisp reader.
2094 (digit_to_number): Move here from data.c. Make it static inline.
2095 (E_CHAR, EXP_INT): Remove, replacing with ...
2096 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2097 (string_to_number): New function, replacing isfloat_string.
2098 This function checks for valid syntax and produces the resulting
2099 Lisp float number too. Rework it so that string-to-number
2100 no longer mishandles examples like "1.0e+". Use strtoumax,
2101 so that overflow for non-base-10 numbers is reported only when
2102 there's no portable and simple way to convert to floating point.
2103
2104 * textprop.c (set_text_properties_1): Rewrite for clarity,
2105 and to avoid GCC warning about integer overflow.
2106
2107 * intervals.h (struct interval): Use EMACS_INT for members
2108 where EMACS_UINT might cause problems. See
2109 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2110 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2111 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2112 All uses changed.
2113 (offset_intervals): Tell GCC not to worry about length overflow
2114 when negating a negative length.
2115
2116 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2117 (overrun_check_free): Likewise.
2118
2119 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2120 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2121 word size.
2122
2123 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2124 (gnutls_make_error): Rename local to avoid shadowing.
2125 (gnutls_emacs_global_deinit): ifdef out; not used.
2126 (Fgnutls_boot): Use const for pointer to readonly storage.
2127 Comment out unused local. Fix pointer signedness problems.
2128
2129 * lread.c (openp): Don't stuff size_t into an 'int'.
2130 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2131 about possible signed overflow.
2132
2133 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2134 (GDK_KEY_g): Don't define if already defined.
2135 (xg_prepare_tooltip): Avoid pointer signedness problem.
2136 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2137
2138 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2139 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2140
2141 * xfns.c (Fx_window_property): Simplify a bit,
2142 to make a bit faster and to avoid GCC 4.6.0 warning.
2143 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2144
2145 * fns.c (internal_equal): Don't assume size_t fits in int.
2146
2147 * alloc.c (compact_small_strings): Tighten assertion a little.
2148
2149 Replace pEd with more-general pI, and fix some printf arg casts.
2150 * lisp.h (pI): New macro, generalizing old pEd macro to other
2151 conversion specifiers. For example, use "...%"pI"d..." rather
2152 than "...%"pEd"...".
2153 (pEd): Remove. All uses replaced with similar uses of pI.
2154 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2155 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2156 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2157 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2158 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2159 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2160 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2161 64-bit hosts.
2162 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2163 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2164 * print.c (safe_debug_print, print_object): Likewise.
2165 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2166 to int.
2167 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2168 avoiding the 0 flag, which is not portable.
2169 * process.c (Fmake_network_process): Use pI to avoid cast.
2170 * region-cache.c (pp_cache): Likewise.
2171 * xdisp.c (decode_mode_spec): Likewise.
2172 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2173 behavior on 64-bit hosts with printf arg.
2174 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2175 (x_stop_queuing_selection_requests): Likewise.
2176 (x_get_window_property): Don't truncate byte count to an 'int'
2177 when tracing.
2178
2179 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2180 here, since it parses constructs like leading '-' and spaces,
2181 which are not wanted; and it overflows with large numbers.
2182 Instead, simply match F[0-9]+, which is what is wanted anyway.
2183
2184 * alloc.c: Remove unportable assumptions about struct layout.
2185 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2186 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2187 (allocate_vectorlike, make_pure_vector): Use the new macros,
2188 plus offsetof, to remove unportable assumptions about struct layout.
2189 These assumptions hold on all porting targets that I know of, but
2190 they are not guaranteed, they're easy to remove, and removing them
2191 makes further changes easier.
2192
2193 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2194 This doesn't fix a bug but makes the code clearer.
2195 (string_overrun_cookie): Now const. Use initializers that
2196 don't formally overflow signed char, to avoid warnings.
2197 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2198 can cause Emacs to crash when string overrun checking is enabled.
2199 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2200 multiple of sizeof (EMACS_INT); it need not be, if
2201 alignof(EMACS_INT) < sizeof (EMACS_INT).
2202 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2203
2204 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2205
2206 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2207
2208 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2209
2210 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2211 supposed to be handshaking. (Bug#8556)
2212 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2213
2214 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2215
2216 * lisp.h (Qdebug): List symbol.
2217 * eval.c (Qdebug): Restore global linkage.
2218 * keyboard.c (debug-on-event): New variable.
2219 (handle_user_signal): Break into debugger when debug-on-event
2220 matches the current signal symbol.
2221
2222 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2223
2224 * alloc.c (check_sblock, check_string_bytes)
2225 (check_string_free_list): Convert to standard C.
2226
2227 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2228
2229 * w32.c (emacs_gnutls_push): Fix typo.
2230
2231 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2232
2233 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2234 "cast to pointer from integer of different size".
2235
2236 Improve doprnt and its use in verror. (Bug#8545)
2237 * doprnt.c (doprnt): Document the set of format control sequences
2238 supported by the function. Use SAFE_ALLOCA instead of always
2239 using `alloca'.
2240
2241 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2242 is one byte too soon. Don't use xrealloc; instead xfree and
2243 xmalloc anew.
2244
2245 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2246
2247 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2248 callbacks stage.
2249
2250 * gnutls.c: Renamed global_initialized to
2251 gnutls_global_initialized. Added internals for the
2252 :verify-hostname-error, :verify-error, and :verify-flags
2253 parameters of `gnutls-boot' and documented those parameters in the
2254 docstring. Start callback support.
2255 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2256 unless a fatal error occured. Call gnutls_alert_send_appropriate
2257 on error. Return error code.
2258 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2259 (emacs_gnutls_read): Likewise.
2260 (Fgnutls_boot): Return handshake error code.
2261 (emacs_gnutls_handle_error): New function.
2262 (wsaerror_to_errno): Likewise.
2263
2264 * w32.h (emacs_gnutls_pull): Add prototype.
2265 (emacs_gnutls_push): Likewise.
2266
2267 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2268 (emacs_gnutls_push): Likewise.
2269
2270 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2271
2272 * process.c (wait_reading_process_output): Check if GnuTLS
2273 buffered some data internally if no FDs are set for TLS
2274 connections.
2275
2276 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2277 (LIBS): Link to USER_LIBS.
2278 ($(BLD)/gnutls.$(0)): New target.
2279
2280 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2281
2282 * xdisp.c (handle_single_display_spec): Rename the
2283 display_replaced_before_p argument into display_replaced_p, to
2284 make it consistent with the commentary. Fix typos in the
2285 commentary.
2286
2287 * textprop.c (syms_of_textprop): Remove dead code.
2288 (copy_text_properties): Delete obsolete commentary about an
2289 interface that was deleted long ago. Fix typos in the description
2290 of arguments.
2291
2292 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2293 to changes in oldXMenu/XMenu.h from 2011-04-16.
2294 <menu_help_message, prev_menu_help_message>: Constify.
2295 (IT_menu_make_room): menu->help_text is now `const char **';
2296 adjust.
2297
2298 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2299 to changes in oldXMenu/XMenu.h from 2011-04-16.
2300 (struct XMenu): Declare `help_text' `const char **'.
2301
2302 * xfaces.c <Qunspecified>: Make extern again.
2303
2304 * syntax.c: Include sys/types.h before including regex.h, as
2305 required by Posix.
2306
2307 * doc.c (get_doc_string): Improve the format passed to `error'.
2308
2309 * doprnt.c (doprnt): Improve commentary.
2310
2311 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2312
2313 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2314 them with etags.
2315
2316 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2317 changes in globals.h immediately force recompilation.
2318 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2319 $(CURDIR)/s/ms-w32.h.
2320 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2321
2322 * character.c (Fchar_direction): Function deleted.
2323 (syms_of_character): Don't defsubr it.
2324 <char-direction-table>: Deleted.
2325
2326 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2327
2328 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2329 * doprnt.c: Include limits.h.
2330 (SIZE_MAX): New macro.
2331 (doprnt): Return a size_t value. 2nd arg is now size_t.
2332 Many local variables are now size_t instead of int or unsigned.
2333 Improve overflow protection. Support `l' modifier for integer
2334 conversions. Support %l conversion. Don't assume an EMACS_INT
2335 argument for integer conversions and for %c.
2336
2337 * lisp.h (doprnt): Restore prototype.
2338
2339 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2340 $(SRC)/character.h.
2341
2342 * Makefile.in (base_obj): Add back doprnt.o.
2343
2344 * deps.mk (doprnt.o): Add back prerequisites.
2345 (callint.o): Depend on character.h.
2346
2347 * eval.c (internal_lisp_condition_case): Include the handler
2348 representation in the error message.
2349 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2350 when breaking from the loop.
2351
2352 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2353
2354 * callint.c (Fcall_interactively): When displaying error message
2355 about invalid control letter, pass the character's codepoint, not
2356 a pointer to its multibyte form. Improve display of the character
2357 in octal and display also its hex code.
2358
2359 * character.c (char_string): Use %x to display the (unsigned)
2360 codepoint of an invalid character, to avoid displaying a bogus
2361 negative value.
2362
2363 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2364 `error', not SYMBOL_NAME itself.
2365
2366 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2367 character arguments to `error'.
2368
2369 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2370 to `error' in error message about FINAL_CHAR argument. Make sure
2371 FINAL_CHAR is a character, and use %c when it is passed as
2372 argument to `error'.
2373
2374 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2375
2376 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2377
2378 * w32.c: Include <time.h>.
2379 (sys_localtime): New function.
2380
2381 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2382
2383 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2384
2385 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2386
2387 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2388
2389 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2390 zombies (Bug#8467).
2391
2392 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2393
2394 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2395 gl_state.e_property when gl_state.object is Qt.
2396
2397 * insdel.c (make_gap_larger): Remove limitation of buffer size
2398 to <= INT_MAX.
2399
2400 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2401
2402 * xdisp.c (lookup_glyphless_char_display)
2403 (produce_glyphless_glyph): Handle cons cell entry in
2404 glyphless-char-display.
2405 (Vglyphless_char_display): Document it.
2406
2407 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2408 glyphless-char-display.
2409
2410 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2411
2412 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2413
2414 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2415
2416 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2417 definition for no-X builds.
2418
2419 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2420
2421 Static checks with GCC 4.6.0 and non-default toolkits.
2422
2423 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2424
2425 * process.c (keyboard_bit_set): Define only if SIGIO.
2426 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2427 (send_process): Repair possible setjmp clobbering.
2428
2429 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2430
2431 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2432
2433 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2434
2435 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2436 Define only if needed.
2437
2438 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2439 by pacifying GCC about it. Maybe it's time to retire it?
2440 * xfaces.c (USG, __TIMEVAL__): Likewise.
2441
2442 * dispextern.h (struct redisplay_interface): Rename param
2443 to avoid shadowing.
2444 * termhooks.h (struct terminal): Likewise.
2445 * xterm.c (xembed_send_message): Likewise.
2446
2447 * insdel.c (make_gap_smaller): Define only if
2448 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2449
2450 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2451 it.
2452
2453 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2454 so that we aren't warned about unused symbols.
2455
2456 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2457
2458 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2459
2460 * xfns.c (x_real_positions): Mark locals as initialized.
2461
2462 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2463
2464 * xterm.c: Fix problems found by static analysis with other toolkits.
2465 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2466 (x_dispatch_event): Declare static if USE_GTK, and
2467 define if USE_GTK || USE_X_TOOLKIT.
2468 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2469 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2470 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2471 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2472
2473 * xmenu.c (menu_help_callback): Pointer type fixes.
2474 Use const pointers when pointing at readonly data. Avoid pointer
2475 signedness clashes.
2476 (FALSE): Remove unused macro.
2477 (update_frame_menubar): Remove unused decl.
2478
2479 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2480
2481 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2482 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2483 (single_menu_item): Rename local to avoid shadowing.
2484
2485 * keyboard.c (make_lispy_event): Remove unused local var.
2486
2487 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2488 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2489
2490 * bitmaps: Change bitmaps from unsigned char back to the X11
2491 compatible char. Avoid the old compiler warnings about
2492 out-of-range initializers by using, for example, '\xab' rather
2493 than 0xab.
2494
2495 * xgselect.c (xgselect_initialize): Check vs interface
2496 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2497
2498 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2499
2500 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2501 to read-only memory.
2502
2503 * fns.c (vector): Remove; this old hack is no longer needed.
2504
2505 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2506 Remove unused var.
2507 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2508
2509 * xrdb.c (x_load_resources): Omit unused local.
2510
2511 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2512 (x_window): Rename locals to avoid shadowing.
2513 (USG): Use the kludged USG macro, to pacify gcc.
2514
2515 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2516 (x_term_init): Remove local to avoid shadowing.
2517
2518 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2519
2520 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2521 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2522
2523 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2524
2525 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2526
2527 Fix regex.c, syntax.c and friends for buffers > 2GB.
2528 * syntax.h (struct gl_state_s): Declare character position members
2529 EMACS_INT.
2530
2531 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2532
2533 * textprop.c (verify_interval_modification, interval_of):
2534 Declare arguments EMACS_INT.
2535
2536 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2537 EMACS_INT.
2538
2539 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2540
2541 * indent.c (Fvertical_motion): Local variable it_start is now
2542 EMACS_INT.
2543
2544 * regex.c (re_match, re_match_2, re_match_2_internal)
2545 (bcmp_translate, regcomp, regexec, print_double_string)
2546 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2547 (re_compile_pattern, re_exec): Declare arguments and local
2548 variables `size_t' and `ssize_t' and return values `regoff_t', as
2549 appropriate.
2550 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2551 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2552 <compile_stack_type>: `size' and `avail' are now `size_t'.
2553
2554 * regex.h <regoff_t>: Use ssize_t, not int.
2555 (re_search, re_search_2, re_match, re_match_2): Arguments that
2556 specify buffer/string position and length are now ssize_t and
2557 size_t. Return type is regoff_t.
2558
2559 2011-04-16 Ben Key <bkey76@gmail.com>
2560
2561 * nsfont.m: Fixed bugs in ns_get_family and
2562 ns_descriptor_to_entity that were caused by using free to
2563 deallocate memory blocks that were allocated by xmalloc (via
2564 xstrdup). This caused Emacs to crash when compiled with
2565 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2566 --enable-checking=xmallocoverrun). xfree is now used to
2567 deallocate these memory blocks.
2568
2569 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2570
2571 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2572
2573 emacs_write: Accept and return EMACS_INT for sizes.
2574 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2575 et seq.
2576 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2577 Accept and return EMACS_INT.
2578 (emacs_gnutls_write): Return the number of bytes written on
2579 partial writes.
2580 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2581 (emacs_read, emacs_write): Remove check for negative size, as the
2582 Emacs source code has been audited now.
2583 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2584 (emacs_read, emacs_write): Use it.
2585 * process.c (send_process): Adjust to the new signatures of
2586 emacs_write and emacs_gnutls_write. Do not attempt to store
2587 a byte offset into an 'int'; it might overflow.
2588 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2589
2590 * sound.c: Don't assume sizes fit in 'int'.
2591 (struct sound_device.period_size, alsa_period_size):
2592 Return EMACS_INT, not int.
2593 (struct sound_device.write, vox_write, alsa_write):
2594 Accept EMACS_INT, not int.
2595 (wav_play, au_play): Use EMACS_INT to store sizes and to
2596 record read return values.
2597
2598 2011-04-15 Ben Key <bkey76@gmail.com>
2599
2600 * keyboard.c (Qundefined): Don't declare static since it is used
2601 in nsfns.m.
2602 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2603 static since they are used in nsfont.m.
2604
2605 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2606
2607 * process.c (Qprocessp): Don't declare static.
2608 * lisp.h (Qprocessp): Declare again.
2609
2610 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2611
2612 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2613
2614 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2615
2616 Improve C-level modularity by making more things 'static'.
2617
2618 Don't publish debugger-only interfaces to other modules.
2619 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2620 (verify_bytepos, count_markers): Move decls to the only modules
2621 that need them.
2622 * region-cache.h (pp_cache): Likewise.
2623 * window.h (check_all_windows): Likewise.
2624 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2625
2626 * sysdep.c (croak): Now static, if
2627 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2628 * syssignal.h (croak): Declare only if not static.
2629
2630 * alloc.c (refill_memory_reserve): Now static if
2631 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2632 * lisp.h (refill_memory_reserve): Declare only if not static.
2633
2634 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2635 Define only if USE_LUCID.
2636
2637 * xrdb.c (x_customization_string, x_rm_string): Now static.
2638
2639 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2640 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2641
2642 * xdisp.c (draw_row_with_mouse_face): Now static.
2643 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2644
2645 * window.h (check_all_windows): Mark externally visible.
2646
2647 * window.c (window_deletion_count): Now static.
2648
2649 * undo.c: Make symbols static if they're not exported.
2650 (last_undo_buffer, last_boundary_position, pending_boundary):
2651 Now static.
2652
2653 * textprop.c (interval_insert_behind_hooks): Now static.
2654 (interval_insert_in_front_hooks): Likewise.
2655
2656 * term.c: Make symbols static if they're not exported.
2657 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2658 (max_frame_lines, tty_set_terminal_modes):
2659 (tty_reset_terminal_modes, tty_turn_off_highlight):
2660 (get_tty_terminal): Now static.
2661 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2662 * termhooks.h (term_mouse_moveto): Do not declare if
2663 HAVE_WINDOW_SYSTEM.
2664 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2665 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2666
2667 * sysdep.c: Make symbols static if they're not exported.
2668 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2669 Now static.
2670 (sigprocmask_set, full_mask): Remove; unused.
2671 (wait_debugging): Mark as visible.
2672 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2673 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2674
2675 * syntax.c (syntax_temp): Define only if !__GNUC__.
2676
2677 * sound.c (current_sound_device, current_sound): Now static.
2678
2679 * search.c (searchbufs, searchbuf_head): Now static.
2680
2681 * scroll.c (scroll_cost): Remove; unused.
2682 * dispextern.h (scroll_cost): Remove decl.
2683
2684 * region-cache.h (pp_cache): Mark as externally visible.
2685
2686 * process.c: Make symbols static if they're not exported.
2687 (process_tick, update_tick, create_process, chan_process):
2688 (Vprocess_alist, proc_buffered_char, datagram_access):
2689 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2690 (deactivate_process): Mark defn as static, as well as decl.
2691 * lisp.h (create_process): Remove decl.
2692 * process.h (chan_process, Vprocess_alist): Remove decls.
2693
2694 * print.c: Make symbols static if they're not exported.
2695 (print_depth, new_backquote_output, being_printed, print_buffer):
2696 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2697 (print_interval, print_number_index, initial_stderr_stream):
2698 Now static.
2699 * lisp.h (Fprinc): Remove decl.
2700 (debug_output_compilation_hack): Mark as externally visible.
2701
2702 * sysdep.c (croak): Move decl from here to syssignal.h.
2703 * syssignal.h (croak): Put it here, so the API can be checked when
2704 'croak' is called from dissociate_if_controlling_tty.
2705
2706 * minibuf.c: Make symbols static if they're not exported.
2707 (minibuf_save_list, choose_minibuf_frame): Now static.
2708 * lisp.h (choose_minibuf_frame): Remove decl.
2709
2710 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2711
2712 * lread.c: Make symbols static if they're not exported.
2713 (read_objects, initial_obarray, oblookup_last_bucket_number):
2714 Now static.
2715 (make_symbol): Remove; unused.
2716 * lisp.h (initial_obarray, make_symbol): Remove decls.
2717
2718 * keyboard.c: Make symbols static if they're not exported.
2719 (single_kboard, recent_keys_index, total_keys, recent_keys):
2720 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2721 (this_single_command_key_start, echoing, last_auto_save):
2722 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2723 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2724 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2725 (Vlispy_mouse_stem, double_click_count):
2726 Now static.
2727 (force_auto_save_soon): Define only if SIGDANGER.
2728 (ignore_mouse_drag_p): Now static if
2729 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2730 (print_help): Remove; unused.
2731 (stop_character, last_timer_event): Mark as externally visible.
2732 * keyboard.h (ignore_mouse_drag_p): Declare only if
2733 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2734 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2735 * lisp.h (echoing): Remove decl.
2736 (force_auto_save_soon): Declare only if SIGDANGER.
2737 * xdisp.c (redisplay_window): Simplify code, to make it more
2738 obvious that ignore_mouse_drag_p is not accessed if !defined
2739 USE_GTK && !defined HAVE_NS.
2740
2741 * intervals.c: Make symbols static if they're not exported.
2742 (merge_properties_sticky, merge_interval_right, delete_interval):
2743 Now static.
2744 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2745
2746 * insdel.c: Make symbols static if they're not exported.
2747 However, leave prepare_to_modify_buffer alone. It's never
2748 called from outside this function, but that appears to be a bug.
2749 (combine_after_change_list, combine_after_change_buffer):
2750 (adjust_after_replace, signal_before_change): Now static.
2751 (adjust_after_replace_noundo): Remove; unused.
2752 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2753 (signal_before_change): Remove decls.
2754
2755 * indent.c (val_compute_motion, val_vmotion): Now static.
2756
2757 * image.c: Make symbols static if they're not exported.
2758 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2759 if USE_GTK.
2760 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2761 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2762
2763 * fringe.c (standard_bitmaps): Now static.
2764 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2765
2766 * frame.c: Make symbols static if they're not exported.
2767 (x_report_frame_params, make_terminal_frame): Now static.
2768 (get_frame_param): Now static, unless HAVE_NS.
2769 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2770 (x_get_resource_string): Remove; not used.
2771 * frame.h (make_terminal_frame, x_report_frame_params):
2772 (x_get_resource_string); Remove decls.
2773 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2774 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2775
2776 * font.c, fontset.c: Make symbols static if they're not exported.
2777 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2778 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2779 * font.c (font_close_object): Now static.
2780 * font.h (font_close_object): Remove.
2781 * fontset.c (FONTSET_OBJLIST): Remove.
2782 (free_realized_fontset) #if-0 the body, which does nothing.
2783 (face_suitable_for_char_p): #if-0, as it's never called.
2784 * fontset.h (face_suitable_for_char_p): Remove decl.
2785 * xfaces.c (face_at_string_position):
2786 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2787 since 0 is always ASCII.
2788
2789 * fns.c (weak_hash_tables): Now static.
2790
2791 * fileio.c: Make symbols static if they're not exported.
2792 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2793 (Vwrite_region_annotation_buffers): Now static.
2794
2795 * eval.c: Make symbols static if they're not exported.
2796 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2797 * lisp.h (backtrace_list): Remove decl.
2798
2799 * emacs.c: Make symbols static if they're not exported.
2800 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2801 (fatal_error_code, fatal_error_signal_hook, standard_args):
2802 Now static.
2803 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2804 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2805 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2806 * lisp.h (fatal_error_signal_hook): Remove decl.
2807 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2808
2809 * editfns.c: Move a (normally-unused) function to its only use.
2810 * editfns.c, lisp.h (get_operating_system_release): Remove.
2811 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2812 worth the hassle of breaking this out.
2813
2814 * xterm.c: Make symbols static if they're not exported.
2815 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2816 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2817 (x_destroy_window, x_delete_display):
2818 Now static.
2819 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2820 (x_mouse_leave): Remove; unused.
2821 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2822 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2823 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2824 Remove decls.
2825 (x_mouse_leave): Declare only if WINDOWSNT.
2826 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2827 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2828 USE_X_TOOLKIT.
2829
2830 * ftxfont.c: Make symbols static if they're not exported.
2831 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2832 HAVE_FREETYPE.
2833 * font.h (ftxfont_driver): Likewise.
2834
2835 * xfns.c: Make symbols static if they're not exported.
2836 (x_last_font_name, x_display_info_for_name):
2837 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2838 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2839 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2840 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2841 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2842 (last_show_tip_args): Now static.
2843 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2844 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2845 (x_screen_planes): Remove; unused.
2846 * dispextern.h (x_screen_planes): Remove decl.
2847
2848 * dispnew.c: Make symbols static if they're not exported.
2849 * dispextern.h (redraw_garbaged_frames, scrolling):
2850 (increment_row_positions): Remove.
2851 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2852 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2853 Now static.
2854 (redraw_garbaged_frames): Remove; unused.
2855
2856 * xfaces.c: Make symbols static if they're not exported.
2857 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2858 Remove decls.
2859 * xterm.h (defined_color): Remove decls.
2860 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2861 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2862 (menu_face_changed_default, defined_color, free_realized_face):
2863 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2864 (ascii_face_of_lisp_face): Remove; unused.
2865
2866 * xdisp.c: Make symbols static if they're not exported.
2867 * dispextern.h (scratch_glyph_row, window_box_edges):
2868 (glyph_to_pixel_coords, set_cursor_from_row):
2869 (get_next_display_element, set_iterator_to_next):
2870 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2871 (show_mouse_face): Remove decls
2872 * frame.h (message_buf_print): Likewise.
2873 * lisp.h (pop_message, set_message, check_point_in_composition):
2874 Likewise.
2875 * xterm.h (set_vertical_scroll_bar): Likewise.
2876 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2877 (message_buf_print, scratch_glyph_row, displayed_buffer):
2878 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2879 (get_next_display_element, show_mouse_face, window_box_edges):
2880 (frame_to_window_pixel_xy, check_point_in_composition):
2881 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2882 (glyph_to_pixel_coords): Remove; unused.
2883
2884 * dired.c (file_name_completion): Now static.
2885
2886 * dbusbind.c (xd_in_read_queued_messages): Now static.
2887
2888 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2889 * data.c (circular_list_error): Remove.
2890
2891 * commands.h (last_point_position, last_point_position_buffer):
2892 (last_point_position_window): Remove decls.
2893 * keyboard.c: Make these variables static.
2894
2895 * coding.h (coding, code_convert_region, encode_coding_gap):
2896 Remove decls.
2897 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2898 (iso_code_class, detect_coding, code_convert_region): Now static.
2899 (encode_coding_gap): Remove; unused.
2900
2901 * chartab.c (chartab_chars, chartab_bits): Now static.
2902
2903 * charset.h (charset_iso_8859_1): Remove decl.
2904 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2905 Now static.
2906
2907 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2908 * ccl.c (Vccl_program_table): Now static.
2909 (check_ccl_update): Remove; unused.
2910
2911 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2912 * category.h: ... from here.
2913 * category.c (check_category_table, set_category_set): Now static.
2914
2915 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2916 * lisp.h: Remove these decls.
2917
2918 * buffer.c (buffer_count): Remove unused var.
2919
2920 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2921 so that it's not optimized away.
2922 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2923 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2924 exported only to the debugger.
2925
2926 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2927 * atimer.h (run_all_atimers): Remove; not exported.
2928
2929 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2930 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2931 was inaccessible from Lisp.
2932 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2933 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2934
2935 alloc.c: Import and export fewer symbols, and remove unused items.
2936 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2937 is defined.
2938 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2939 it's not optimized away by whole-program optimization.
2940 (message_enable_multibyte, free_misc): Remove.
2941 (catchlist, handlerlist, mark_backtrace):
2942 Declare only if BYTE_MARK_STACK.
2943 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2944 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2945 (message_enable_multibyte): Remove decl.
2946 (free_misc, interval_free_list, float_block, float_block_index):
2947 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2948 (cons_free_list, last_marked_index):
2949 Now static.
2950 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2951 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2952 (mark_backtrace): Define only if BYTE_MARK_STACK.
2953 * xdisp.c (message_enable_multibyte): Now static.
2954
2955 Declare Lisp_Object Q* variables to be 'static' if not exported.
2956 This makes it easier for human readers (and static analyzers)
2957 to see whether these variables are used from other modules.
2958 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2959 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2960 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2961 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2962 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2963 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2964 * xmenu.c, xselect.c:
2965 Declare Q* vars static if they are not used in other modules.
2966 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2967 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2968 Remove decls of unexported vars.
2969 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2970
2971 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2972
2973 Make Emacs functions such as Fatom 'static' by default.
2974 This makes it easier for human readers (and static analyzers)
2975 to see whether these functions can be called from other modules.
2976 DEFUN now defines a static function. To make the function external
2977 so that it can be used in other C modules, use the new macro DEFUE.
2978 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2979 (Finit_image_library):
2980 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2981 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2982 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2983 Remove decls, since these functions are now static.
2984 (Funintern, Fget_internal_run_time): New decls, since these functions
2985 were already external.
2986
2987 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2988 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2989 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2990 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2991 * keyboard.c, keymap.c, lread.c:
2992 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2993 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2994 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2995 Mark functions with DEFUE instead of DEFUN,
2996 if they are used in other modules.
2997 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2998 decls for now-static functions.
2999 * buffer.h (Fdelete_overlay): Remove decl.
3000 * callproc.c (Fgetenv_internal): Mark as internal.
3001 * composite.c (Fremove_list_of_text_properties): Remove decl.
3002 (Fcomposition_get_gstring): New forward static decl.
3003 * composite.h (Fcomposite_get_gstring): Remove decl.
3004 * dired.c (Ffile_attributes): New forward static decl.
3005 * doc.c (Fdocumntation_property): New forward static decl.
3006 * eval.c (Ffetch_bytecode): New forward static decl.
3007 (Funintern): Remove extern decl; now in .h file where it belongs.
3008 * fileio.c (Fmake_symbolic_link): New forward static decl.
3009 * image.c (Finit_image_library): New forward static decl.
3010 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3011 * intervals.h (Fprevious_property_change):
3012 (Fremove_list_of_text_properties): Remove decls.
3013 * keyboard.c (Fthis_command_keys): Remove decl.
3014 (Fcommand_execute): New forward static decl.
3015 * keymap.c (Flookup_key): New forward static decl.
3016 (Fcopy_keymap): Now static.
3017 * keymap.h (Flookup_key): Remove decl.
3018 * process.c (Fget_process): New forward static decl.
3019 (Fprocess_datagram_address): Mark as internal.
3020 * syntax.c (Fsyntax_table_p): New forward static decl.
3021 (skip_chars): Remove duplicate decl.
3022 * textprop.c (Fprevious_property_change): New forward static decl.
3023 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3024 Now internal.
3025 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3026 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3027
3028 * editfns.c (Fformat): Remove unreachable code.
3029
3030 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3031
3032 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3033 change. (Bug#8496)
3034
3035 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3036
3037 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3038 when at ZV. (Bug#8487)
3039
3040 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3041
3042 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3043 (Bug#8437)
3044 * keyboard.c (parse_tool_bar_item): Likewise.
3045 * sound.c (sound_cleanup, alsa_close): Likewise.
3046 * termcap.c (tgetent): Likewise.
3047 * xfns.c (x_default_font_parameter): Likewise.
3048 * xsettings.c (read_and_apply_settings): Likewise.
3049
3050 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3051 (overrun_check_free): Protoize.
3052
3053 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3054
3055 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3056 since callers should never pass a negative size.
3057 Change the signature to match that of plain 'read' and 'write'; see
3058 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3059 * lisp.h: Update prototypes of emacs_write and emacs_read.
3060
3061 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3062
3063 * xdisp.c (redisplay_window): Don't try to determine the character
3064 position of the scroll margin if the window start point w->startp
3065 is outside the buffer's accessible region. (Bug#8468)
3066
3067 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3068
3069 Fix write-region and its subroutines for buffers > 2GB.
3070 * fileio.c (a_write, e_write): Modify declaration of arguments and
3071 local variables to support buffers larger than 2GB.
3072 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3073
3074 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3075 argument, local variables, and return value.
3076
3077 * lisp.h: Update prototypes of emacs_write and emacs_read.
3078
3079 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3080
3081 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3082
3083 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3084
3085 Fix more problems found by GCC 4.6.0's static checks.
3086
3087 * xdisp.c (vmessage): Use a better test for character truncation.
3088
3089 * charset.c (load_charset_map): <, not <=, for optimization,
3090 and to avoid potential problems with integer overflow.
3091 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3092 * casetab.c (set_identity, shuffle): Likewise.
3093 * editfns.c (Fformat): Likewise.
3094 * syntax.c (skip_chars): Likewise.
3095
3096 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3097 This also lets GCC 4.6.0 generate slightly better loop code.
3098
3099 * callint.c (Fcall_interactively): <, not <=, for optimization.
3100 (Fcall_interactively): Count the number of arguments produced,
3101 not the number of arguments given. This is simpler and lets GCC
3102 4.6.0 generate slightly better code.
3103
3104 * ftfont.c: Distingish more carefully between FcChar8 and char.
3105 The previous code passed unsigned char * to a functions like
3106 strlen and xstrcasecmp that expect char *, which does not
3107 conform to the C standard.
3108 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3109 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3110 char * when the C standard requires it.
3111
3112 * keyboard.c (read_char): Remove unused var.
3113
3114 * eval.c: Port to Windows vsnprintf (Bug#8435).
3115 Include <limits.h>.
3116 (SIZE_MAX): Define if the headers do not.
3117 (verror): Do not give up if vsnprintf returns a negative count.
3118 Instead, grow the buffer. This ports to Windows vsnprintf, which
3119 does not conform to C99. Problem reported by Eli Zaretskii.
3120 Also, simplify the allocation scheme, by avoiding the need for
3121 calling realloc, and removing the ALLOCATED variable.
3122
3123 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3124
3125 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3126 But keep the doprint source code for now, as we might revamp it
3127 and use it again (Bug#8435).
3128 * lisp.h (doprnt): Remove.
3129 * Makefile.in (base_obj): Remove doprnt.o.
3130 * deps.mk (doprnt.o): Remove.
3131
3132 error: Print 32- and 64-bit integers portably (Bug#8435).
3133 Without this change, on typical 64-bit hosts error ("...%d...", N)
3134 was used to print both 32- and 64-bit integers N, which relied on
3135 undefined behavior.
3136 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3137 New macro.
3138 * lisp.h (error, verror): Mark as printf-like functions.
3139 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3140 Report overflow in size calculations when allocating printf buffer.
3141 Do not truncate output string at its first null byte.
3142 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3143 Truncate the output at a character boundary, since vsnprintf does not
3144 do that.
3145 * charset.c (check_iso_charset_parameter): Convert internal
3146 character to string before calling 'error', since %c now has the
3147 printf meaning.
3148 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3149 overflow when computing char to be passed to 'error'. Do not
3150 pass Lisp_Object to 'error'; pass the integer instead.
3151 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3152 formatted with plain %d.
3153
3154 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3155
3156 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3157
3158 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3159
3160 * xterm.c (x_catch_errors): Remove duplicate declaration.
3161
3162 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3163
3164 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3165
3166 2011-04-10 Jim Meyering <meyering@redhat.com>
3167
3168 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3169 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3170 return ssize_t not "int", and use size_t as the buffer length.
3171 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3172 * gnutls.h: Update declarations.
3173 * process.c (read_process_output): Use ssize_t, to match.
3174 (send_process): Likewise.
3175
3176 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3177
3178 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3179
3180 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3181
3182 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3183 Use unsigned char, to match FcChar8 type definition.
3184
3185 * xterm.c (handle_one_xevent):
3186 * xmenu.c (create_and_show_popup_menu):
3187 * xselect.c (x_decline_selection_request)
3188 (x_reply_selection_request): Avoid type-punned deref of X events.
3189
3190 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3191
3192 Fix some uses of `int' instead of EMACS_INT.
3193 * search.c (string_match_1, fast_string_match)
3194 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3195 (scan_buffer, find_next_newline_no_quit)
3196 (find_before_next_newline, search_command, Freplace_match)
3197 (Fmatch_data): Make some `int' variables be EMACS_INT.
3198
3199 * xdisp.c (display_count_lines): 3rd argument and return value now
3200 EMACS_INT. All callers changed.
3201 (pint2hrstr): Last argument is now EMACS_INT.
3202
3203 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3204 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3205 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3206 (decode_coding_utf_16, decode_coding_emacs_mule)
3207 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3208 (decode_coding_ccl, decode_coding_charset)
3209 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3210 (decode_coding_iso_2022, decode_coding_emacs_mule)
3211 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3212 <char_offset, last_offset>: Declare EMACS_INT.
3213 (encode_coding_utf_8, encode_coding_utf_16)
3214 (encode_coding_emacs_mule, encode_invocation_designation)
3215 (encode_designation_at_bol, encode_coding_iso_2022)
3216 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3217 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3218 Declare EMACS_INT.
3219 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3220 (encode_invocation_designation): Last argument P_NCHARS is now
3221 EMACS_INT.
3222 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3223 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3224
3225 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3226 All users changed.
3227
3228 * ccl.c (Fccl_execute_on_string): Declare some variables
3229 EMACS_INT.
3230
3231 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3232
3233 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3234
3235 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3236
3237 * process.c (Fformat_network_address): Doc fix.
3238
3239 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3240
3241 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3242
3243 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3244
3245 * keyboard.c (read_char): Call Lisp function help-form-show,
3246 instead of using internal_with_output_to_temp_buffer.
3247 (Qhelp_form_show): New var.
3248 (syms_of_keyboard): Use DEFSYM macro.
3249
3250 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3251
3252 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3253
3254 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3255
3256 * process.c (Flist_processes): Remove to Lisp.
3257 (list_processes_1): Delete.
3258
3259 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3260
3261 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3262
3263 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3264
3265 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3266
3267 Fix more problems found by GCC 4.6.0's static checks.
3268
3269 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3270
3271 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3272
3273 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3274
3275 * xdisp.c (vmessage): Mark as a printf-like function.
3276
3277 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3278
3279 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3280
3281 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3282 printf-like functions.
3283 (tiff_load): Add casts to remove these marks before passing them
3284 to system-supplied API.
3285
3286 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3287
3288 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3289 This avoids several warnings with gcc -Wstrict-overflow.
3290 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3291 directly, rather than having caller test rule sign. This avoids
3292 some unnecessary tests.
3293 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3294 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3295 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3296
3297 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3298 (xfont_open): Avoid unnecessary tests.
3299
3300 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3301
3302 * composite.h, composite.c (composition_gstring_put_cache):
3303 Use EMACS_INT, not int, for length.
3304
3305 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3306 breaking out part of COMPOSITION_DECODE_RULE.
3307 (COMPOSITION_DECODE_RULE): Use it.
3308 * composite.c (get_composition_id): Remove unused local vars,
3309 by using the new macro.
3310
3311 * textprop.c (set_text_properties_1): Change while to do-while,
3312 since the condition is always true at first.
3313
3314 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3315 (interval_deletion_adjustment): Return unsigned value.
3316 All uses changed.
3317
3318 * process.c (list_processes_1, create_pty, read_process_output):
3319 (exec_sentinel): Remove vars that were set but not used.
3320 (create_pty): Remove unnecessary "volatile"s.
3321 (Fnetwork_interface_info): Avoid possibility of int overflow.
3322 (read_process_output): Do adaptive read buffering even if carryover.
3323 (read_process_output): Simplify nbytes computation if buffered.
3324
3325 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3326
3327 * syntax.c (scan_words): Remove var that was set but not used.
3328 (update_syntax_table): Use unsigned instead of int.
3329
3330 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3331 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3332 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3333
3334 * print.c (print_error_message): Avoid int overflow.
3335
3336 * font.c (font_list_entities): Redo for clarity,
3337 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3338
3339 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3340 (font_score): Avoid potential overflow in diff calculation.
3341
3342 * fns.c (substring_both): Remove var that is set but not used.
3343 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3344
3345 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3346
3347 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3348 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3349 can always succeed if overflow has undefined behavior.
3350
3351 * search.c (boyer_moore, wordify): Remove vars set but not used.
3352 (wordify): Omit three unnecessary tests.
3353
3354 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3355 All callers changed. This avoids the need for an unused var.
3356
3357 * casefiddle.c (casify_region): Remove var that is set but not used.
3358
3359 * dired.c (file_name_completion): Remove var that is set but not used.
3360
3361 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3362
3363 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3364 (Finsert_file_contents): Remove unnecessary code checking fd.
3365
3366 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3367 Check for integer overflow on size calculations.
3368
3369 * buffer.c (Fprevious_overlay_change): Remove var that is set
3370 but not used.
3371
3372 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3373 Remove vars that are set but not used.
3374 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3375 (timer_check_2): Mark vars as initialized.
3376
3377 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3378
3379 * image.c (lookup_image): Remove var that is set but not used.
3380 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3381
3382 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3383 that are set but not used.
3384
3385 * xfns.c (make_invisible_cursor): Don't return garbage
3386 if XCreateBitmapFromData fails (Bug#8410).
3387
3388 * xselect.c (x_get_local_selection, x_handle_property_notify):
3389 Remove vars that are set but not used.
3390
3391 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3392 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3393
3394 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3395 Remove var that is set but not used.
3396 (scroll_bar_windows_size): Now size_t, not int.
3397 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3398 Check for overflow.
3399
3400 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3401 (map_tty_color) [!defined MSDOS]: Likewise.
3402
3403 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3404
3405 * coding.c: Remove vars that are set but not used.
3406 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3407 All callers changed.
3408 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3409 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3410 (decode_coding_charset): Remove vars that are set but not used.
3411
3412 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3413 that is set but not used.
3414
3415 * print.c (print_object): Remove var that is set but not used.
3416
3417 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3418 The gnulib version avoids calling malloc in the usual case,
3419 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3420 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3421 * filelock.c (current_lock_owner): Likewise.
3422 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3423 * sysdep.c: Include allocator.h, careadlinkat.h.
3424 (emacs_no_realloc_allocator): New static constant.
3425 (emacs_readlink): New function.
3426 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3427 ../lib/careadlinkat.h.
3428
3429 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3430
3431 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3432 first non-nil return value).
3433
3434 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3435
3436 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3437 if not defined (Bug#8403).
3438
3439 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3440
3441 * xdisp.c (display_count_lines): Remove parameter `start',
3442 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3443 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3444 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3445 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3446 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3447 and thereabouts. All callers changed.
3448 (get_per_char_metric): Remove parameter `f', unused since
3449 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3450
3451 2011-04-02 Jim Meyering <meyering@redhat.com>
3452
3453 do not dereference NULL upon failed strdup
3454 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3455 (ns_get_family): Likewise.
3456
3457 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3458
3459 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3460
3461 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3462
3463 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3464 later (Bug#8403).
3465
3466 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3467
3468 Add lexical binding.
3469
3470 * window.c (Ftemp_output_buffer_show): New fun.
3471 (Fsave_window_excursion):
3472 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3473
3474 * lread.c (lisp_file_lexically_bound_p): New function.
3475 (Fload): Bind Qlexical_binding.
3476 (readevalloop): Remove `evalfun' arg.
3477 Bind Qinternal_interpreter_environment.
3478 (Feval_buffer): Bind Qlexical_binding.
3479 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3480 Mark as dynamic.
3481 (syms_of_lread): Declare `lexical-binding'.
3482
3483 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3484
3485 * keyboard.c (eval_dyn): New fun.
3486 (menu_item_eval_property): Use it.
3487
3488 * image.c (parse_image_spec): Use Ffunctionp.
3489
3490 * fns.c (concat, mapcar1): Accept byte-code-functions.
3491
3492 * eval.c (Fsetq): Handle lexical vars.
3493 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3494 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3495 (FletX, Flet): Obey lexical binding.
3496 (Fcommandp): Handle closures.
3497 (Feval): New `lexical' arg.
3498 (eval_sub): New function extracted from Feval. Use it almost
3499 everywhere where Feval was used. Look up vars in lexical env.
3500 Handle closures.
3501 (Ffunctionp): Move from subr.el.
3502 (Ffuncall): Handle closures.
3503 (apply_lambda): Remove `eval_flags'.
3504 (funcall_lambda): Handle closures and new byte-code-functions.
3505 (Fspecial_variable_p): New function.
3506 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3507 but without exporting it to Lisp.
3508
3509 * doc.c (Fdocumentation, store_function_docstring):
3510 * data.c (Finteractive_form): Handle closures.
3511
3512 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3513 interactive spec.
3514
3515 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3516 New byte-codes.
3517 (exec_byte_code): New function extracted from Fbyte_code to handle new
3518 calling convention for byte-code-functions. Add new byte-codes.
3519
3520 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3521
3522 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3523
3524 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3525
3526 * xdisp.c (redisplay_internal): Fix prototype.
3527
3528 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3529
3530 * xdisp.c (SCROLL_LIMIT): New macro.
3531 (try_scrolling): Use it when setting scroll_limit.
3532 Limit scrolling to 100 screen lines.
3533 (redisplay_window): Even when falling back on "recentering",
3534 position point in the window according to scroll-conservatively,
3535 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3536
3537 (try_scrolling): When point is above the window, allow searching
3538 as far as scroll_max, or one screenful, to compute vertical
3539 distance from PT to the scroll margin position. This prevents
3540 try_scrolling from unnecessarily failing when
3541 scroll-conservatively is set to a value slightly larger than the
3542 window height. Clean up the case of PT below the margin at bottom
3543 of window: scroll_max can no longer be INT_MAX. When aggressive
3544 scrolling is in use, don't let point enter the opposite scroll
3545 margin as result of the scroll.
3546 (syms_of_xdisp) <scroll-conservatively>: Document the
3547 threshold of 100 lines for never-recentering scrolling.
3548
3549 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3550
3551 * dispextern.h (move_it_by_lines):
3552 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3553 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3554 (message_log_check_duplicate): Remove parameters `prev_bol' and
3555 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3556 (redisplay_internal): Remove parameter `preserve_echo_area',
3557 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3558
3559 * indent.c (Fvertical_motion):
3560 * window.c (window_scroll_pixel_based, Frecenter):
3561 Don't pass `need_y_p' to `move_it_by_lines'.
3562
3563 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3564
3565 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3566 steal a few bits to be more compact.
3567 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3568 Remove unneeded casts.
3569
3570 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3571
3572 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3573
3574 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3575 binding" message (bug#7967).
3576
3577 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3578
3579 Fix more problems found by GCC 4.6.0's static checks.
3580
3581 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3582 Remove unused local var.
3583
3584 * editfns.c (Fmessage_box): Remove unused local var.
3585
3586 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3587 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3588 Omit unused local vars.
3589 * window.c (shrink_windows): Omit unused local var.
3590 * menu.c (digest_single_submenu): Omit unused local var.
3591 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3592 Omit unused local var.
3593
3594 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3595 Don't assume string length fits in int.
3596 (keyremap_step, read_key_sequence): Use size_t for sizes.
3597 (read_key_sequence): Don't check last_real_key_start redundantly.
3598
3599 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3600 instead of alloca (Bug#8344).
3601
3602 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3603 (Fbacktrace_frame): Don't assume nframes fits in int.
3604
3605 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3606
3607 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3608 concerns.
3609
3610 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3611
3612 * cm.c (calccost): Turn while-do into do-while, for clarity.
3613
3614 * keyboard.c (syms_of_keyboard): Use the same style as later
3615 in this function when indexing through an array. This also
3616 works around GCC bug 48267.
3617
3618 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3619
3620 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3621
3622 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3623 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3624
3625 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3626 This avoids undefined behavior on integer overflow, and is a bit
3627 more convenient anyway since it is compared to a size_t variable.
3628
3629 Variadic C functions now count arguments with size_t, not int.
3630 This avoids an unnecessary limitation on 64-bit machines, which
3631 caused (substring ...) to crash on large vectors (Bug#8344).
3632 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3633 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3634 All variadic functions and their callers changed accordingly.
3635 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3636 * data.c (arith_driver, float_arith_driver): Likewise.
3637 * editfns.c (general_insert_function): Likewise.
3638 * eval.c (struct backtrace.nargs, interactive_p)
3639 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3640 (funcall_lambda, mark_backtrace): Likewise.
3641 * fns.c (concat): Likewise.
3642 * frame.c (x_set_frame_parameters): Likewise.
3643 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3644 0 if not found, not -1. All callers changed.
3645
3646 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3647 (stack_copy_size): Now size_t, not int.
3648 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3649
3650 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3651
3652 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3653 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3654 All callers changed.
3655
3656 * lisp.h (multibyte_char_to_unibyte):
3657 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3658 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3659 * character.h (CHAR_TO_BYTE8):
3660 * cmds.c (internal_self_insert):
3661 * editfns.c (general_insert_function):
3662 * keymap.c (push_key_description):
3663 * search.c (Freplace_match):
3664 * xdisp.c (message_dolog, set_message_1): All callers changed.
3665
3666 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3667
3668 * keyboard.c (safe_run_hook_funcall): New function.
3669 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3670 don't set the hook to nil, but remove the offending function instead.
3671 (Qcommand_hook_internal): Remove, unused.
3672 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3673 Vcommand_hook_internal.
3674
3675 * eval.c (enum run_hooks_condition): Remove.
3676 (funcall_nil, funcall_not): New functions.
3677 (run_hook_with_args): Call each function through a `funcall' argument.
3678 Remove `cond' argument, now redundant.
3679 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3680 (Frun_hook_with_args_until_failure): Adjust accordingly.
3681 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3682
3683 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3684
3685 * dispextern.h (string_buffer_position): Remove declaration.
3686
3687 * print.c (strout): Remove parameter `multibyte', unused since
3688 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3689
3690 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3691 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3692 All callers changed.
3693
3694 * w32.c (_wsa_errlist): Use braces for struct initializers.
3695
3696 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3697 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3698 All callers changed.
3699 (string_buffer_position): Likewise. Also, make static (it's never
3700 used outside xdisp.c).
3701 (cursor_row_p): Remove parameter `w', unused since
3702 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3703 (decode_mode_spec): Remove parameter `precision', introduced during
3704 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3705 All callers changed.
3706
3707 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3708
3709 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3710
3711 2011-03-27 Anders Lindgren <andlind@gmail.com>
3712
3713 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3714 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3715 (ns_update_auto_hide_menu_bar): New functions.
3716 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3717 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3718 ns_constrain_all_frames.
3719 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3720 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3721
3722 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3723
3724 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3725
3726 2011-03-27 Glenn Morris <rgm@gnu.org>
3727
3728 * syssignal.h: Replace RETSIGTYPE with void.
3729 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3730 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3731 Replace SIGTYPE with void everywhere.
3732 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3733 * s/template.h (SIGTYPE): Remove commented out definition.
3734
3735 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3736
3737 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3738 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3739
3740 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3741
3742 * w32.c (read_unc_volume): Use parameter `henum', instead of
3743 global variable `wget_enum_handle'.
3744
3745 * keymap.c (describe_vector): Remove parameters `indices' and
3746 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3747 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3748
3749 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3750
3751 * keyboard.c (timer_check): Remove parameter `do_it_now',
3752 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3753 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3754 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3755
3756 * keyboard.c (read_char):
3757 * w32menu.c (w32_menu_display_help):
3758 * xmenu.c (show_help_event, menu_help_callback):
3759 Adjust calls to `show_help_echo'.
3760
3761 * gtkutil.c (xg_maybe_add_timer):
3762 * keyboard.c (readable_events):
3763 * process.c (wait_reading_process_output):
3764 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3765
3766 * insdel.c (adjust_markers_gap_motion):
3767 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3768 (gap_left, gap_right): Don't call it.
3769
3770 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3771
3772 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3773 incurred during fontification.
3774
3775 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3776
3777 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3778 (DEFVAR_PER_BUFFER): Don't pass it.
3779
3780 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3781 (scrolling_window): Don't pass it.
3782
3783 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3784
3785 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3786
3787 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3788 and `suffix'.
3789 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3790 of variables specific to SELinux and computation of `encoded_absname'.
3791
3792 * image.c (XPutPixel): Remove unused variable `height'.
3793
3794 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3795
3796 * unexw32.c (get_section_info): Remove unused variable `section'.
3797
3798 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3799 (system_process_attributes): Remove unused variable `sess'.
3800 (sys_read): Remove unused variable `err'.
3801
3802 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3803 (w32_wnd_proc): Remove unused variable `isdead'.
3804 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3805 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3806 (x_create_tip_frame): Remove unused variable `tem'.
3807
3808 * w32inevt.c (w32_console_read_socket):
3809 Remove unused variable `no_events'.
3810
3811 * w32term.c (x_draw_composite_glyph_string_foreground):
3812 Remove unused variable `width'.
3813
3814 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3815
3816 * w32term.c (x_set_glyph_string_clipping):
3817 Don't pass uninitialized region to CombineRgn.
3818
3819 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3820
3821 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3822 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3823 (Fx_close_connection): Remove unused variable `i'.
3824
3825 * w32font.c (w32font_draw): Return number of glyphs.
3826 (w32font_open_internal): Remove unused variable `i'.
3827 (w32font_driver): Add missing initializer.
3828
3829 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3830 (fill_in_menu): Remove unused variable `items_added'.
3831
3832 * w32term.c (last_mouse_press_frame): Remove static global variable.
3833 (w32_clip_to_row): Remove unused variable `f'.
3834 (x_delete_terminal): Remove unused variable `i'.
3835
3836 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3837 (NOTHING): Remove unused static global variable.
3838 (uniscribe_check_otf): Remove unused variable `table'.
3839 (uniscribe_font_driver): Add missing initializers.
3840
3841 2011-03-23 Julien Danjou <julien@danjou.info>
3842
3843 * term.c (Fsuspend_tty, Fresume_tty):
3844 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3845 * window.c (temp_output_buffer_show):
3846 * insdel.c (signal_before_change):
3847 * frame.c (Fhandle_switch_frame):
3848 * fileio.c (Fdo_auto_save):
3849 * emacs.c (Fkill_emacs):
3850 * editfns.c (save_excursion_restore):
3851 * cmds.c (internal_self_insert):
3852 * callint.c (Fcall_interactively):
3853 * buffer.c (Fkill_all_local_variables):
3854 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3855 Use Frun_hooks.
3856 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3857 unconditionnaly since it does the check itself.
3858
3859 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3860
3861 Fix more problems found by GCC 4.5.2's static checks.
3862
3863 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3864 the first time through the loop, since we know p0 < p1 then.
3865 This also avoids a gcc -Wstrict-overflow warning.
3866
3867 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3868 leading to a memory leak, possible in functions like
3869 load_charset_map_from_file that can allocate an unbounded number
3870 of objects (Bug#8318).
3871
3872 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3873 that could (at least in theory) be that large.
3874
3875 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3876 This is less likely to overflow, and avoids undefined behavior if
3877 overflow does occur. All callers changed. Use strtoul to scan
3878 for the unsigned long integer.
3879 (pint2hrstr): Simplify and tune code slightly.
3880 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3881
3882 * scroll.c (do_scrolling): Work around GCC bug 48228.
3883 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3884
3885 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3886 This also avoids a warning with gcc -Wstrict-overflow.
3887 (validate_x_resource_name): Simplify count usage.
3888 This also avoids a warning with gcc -Wstrict-overflow.
3889
3890 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3891 fail (Bug#8306).
3892
3893 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3894
3895 * process.c (Fmake_network_process): Use socklen_t, not int,
3896 where POSIX says socklen_t is required in portable programs.
3897 This fixes a porting bug on hosts like 64-bit HP-UX, where
3898 socklen_t is wider than int (Bug#8277).
3899 (Fmake_network_process, server_accept_connection):
3900 (wait_reading_process_output, read_process_output):
3901 Likewise.
3902
3903 * process.c: Rename or move locals to avoid shadowing.
3904 (list_processes_1, Fmake_network_process):
3905 (read_process_output_error_handler, exec_sentinel_error_handler):
3906 Rename or move locals.
3907 (Fmake_network_process): Define label "retry_connect" only if needed.
3908 (Fnetwork_interface_info): Fix pointer signedness.
3909 (process_send_signal): Add cast to avoid pointer signedness problem.
3910 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3911 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3912
3913 Make tparam.h and terminfo.c consistent.
3914 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3915 Include tparam.h instead, since it declares them.
3916 * cm.h (PC): Remove extern decl; tparam.h now does this.
3917 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3918 * terminfo.c: Include tparam.h, to check interfaces.
3919 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3920 (tparam): Adjust signature to match interface in tparam.h;
3921 this removes some undefined behavior. Check that outstring and len
3922 are zero, which they always are with Emacs.
3923 * tparam.h (PC, BC, UP): New extern decls.
3924
3925 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3926 (xftfont_open): Rename locals to avoid shadowing.
3927
3928 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3929 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3930 (OTF_TAG_SYM): Omit macro if not needed.
3931 (ftfont_list): Remove unused local.
3932 (get_adstyle_property, ftfont_pattern_entity):
3933 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3934 Rename locals to avoid shadowing.
3935
3936 * xfont.c (xfont_list_family): Mark var as initialized.
3937
3938 * xml.c (make_dom): Now static.
3939
3940 * composite.c (composition_compute_stop_pos): Rename local to
3941 avoid shadowing.
3942 (composition_reseat_it): Remove unused locals.
3943 (find_automatic_composition, composition_adjust_point): Likewise.
3944 (composition_update_it): Mark var as initialized.
3945 (find_automatic_composition): Mark vars as initialized,
3946 with a FIXME (Bug#8290).
3947
3948 character.h: Rename locals to avoid shadowing.
3949 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3950 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3951 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3952 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3953 to avoid shadowing.
3954
3955 * textprop.c (property_change_between_p): Remove; unused.
3956
3957 * intervals.c (interval_start_pos): Now static.
3958
3959 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3960
3961 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3962 Rename locals to avoid shadowing.
3963
3964 * sound.c (wav_play, au_play, Fplay_sound_internal):
3965 Fix pointer signedness.
3966 (alsa_choose_format): Remove unused local var.
3967 (wav_play): Initialize a variable to 0, to prevent undefined
3968 behavior (Bug#8278).
3969
3970 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3971
3972 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3973
3974 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3975 clobbering (Bug#8298).
3976 * sysdep.c (sys_subshell): Likewise.
3977 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3978
3979 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3980 This should get cleaned up, so that child_setup has the
3981 same signature on all platforms.
3982
3983 * callproc.c (call_process_cleanup): Now static.
3984 (relocate_fd): Rename locals to avoid shadowing.
3985
3986 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3987
3988 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3989 not to be necessary, and produces flickering.
3990
3991 2011-03-20 Glenn Morris <rgm@gnu.org>
3992
3993 * config.in: Remove file.
3994
3995 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3996
3997 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3998 are now in src/globals.h.
3999 (syms_of_minibuf): Remove spurious & from previous change.
4000
4001 2011-03-20 Leo <sdl.web@gmail.com>
4002
4003 * minibuf.c (completing-read-function): New variable.
4004 (completing-read-default): Rename from completing-read.
4005 (completing-read): Call completing-read-function.
4006
4007 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4008
4009 * xfaces.c (Fx_load_color_file):
4010 Read color file from absolute filename (bug#8250).
4011
4012 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4013
4014 * makefile.w32-in: Update dependencies.
4015
4016 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4017
4018 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4019
4020 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4021
4022 Fix more problems found by GCC 4.5.2's static checks.
4023
4024 * process.c (make_serial_process_unwind, send_process_trap):
4025 (sigchld_handler): Now static.
4026
4027 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4028 That way, the code declares only the vars that it needs.
4029 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4030 * s/cygwin.h (PTY_ITERATION): Likewise.
4031 * s/darwin.h (PTY_ITERATION): Likewise.
4032 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4033
4034 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4035 * process.c (allocate_pty): Don't declare stb unless it's needed.
4036
4037 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4038 (CONSTANTLIM): Remove; unused.
4039 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4040 Define only if needed.
4041
4042 * unexelf.c (unexec): Name an expression,
4043 to avoid gcc -Wbad-function-cast warning.
4044 Use a different way to cause a compilation error if anyone uses
4045 n rather than nn, a way that does not involve shadowing.
4046 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4047
4048 * deps.mk (unexalpha.o): Remove; unused.
4049
4050 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4051 * unexec.h: New file.
4052 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4053 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4054 Depend on unexec.h.
4055 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4056 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4057 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4058 Change as necessary to match prototype in unexec.h.
4059
4060 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4061 shadowing.
4062 (back_comment, skip_chars): Mark vars as initialized.
4063
4064 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4065 Rename locals to avoid shadowing.
4066
4067 * lread.c (read1): Rewrite so as not to use empty "else".
4068 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4069
4070 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4071
4072 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4073 warning when compiling print.c.
4074
4075 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4076 instead of using an uninitialized var.
4077 (font_sort_entities): Mark var as initialized.
4078
4079 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4080
4081 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4082 pointers to constants.
4083 (font_parse_fcname): Remove unused vars.
4084 (font_delete_unmatched): Now static.
4085 (font_get_spec): Remove; unused.
4086 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4087 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4088 Rename or move locals to avoid shadowing.
4089
4090 * fns.c (require_nesting_list, require_unwind): Now static.
4091 (Ffillarray): Rename locals to avoid shadowing.
4092
4093 * floatfns.c (domain_error2): Define only if needed.
4094 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4095
4096 * alloc.c (mark_backtrace): Move decl from here ...
4097 * lisp.h: ... to here, so that it can be checked.
4098
4099 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4100 (Fdefvar): Rewrite so as not to use empty "else".
4101 (lisp_indirect_variable): Name an expression,
4102 to avoid gcc -Wbad-function-cast warning.
4103 (Fdefvar): Rename locals to avoid shadowing.
4104
4105 * callint.c (quotify_arg, quotify_args): Now static.
4106 (Fcall_interactively): Rename locals to avoid shadowing.
4107 Use const pointer when appropriate.
4108
4109 * lisp.h (get_system_name, get_operating_system_release):
4110 Move decls here, to check interfaces.
4111 * process.c (get_operating_system_release): Move decl to lisp.h.
4112 * xrdb.c (get_system_name): Likewise.
4113 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4114 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4115 some of which prompt warnings from gcc -Wbad-function-cast.
4116 (Fformat_time_string, Fencode_time, Finsert_char):
4117 (Ftranslate_region_internal, Fformat):
4118 Rename or remove local vars to avoid shadowing.
4119 (Ftranslate_region_internal): Mark var as initialized.
4120
4121 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4122 avoid shadowing.
4123
4124 * lisp.h (eassert): Check that the argument compiles, even if
4125 ENABLE_CHECKING is not defined.
4126
4127 * data.c (Findirect_variable): Name an expression, to avoid
4128 gcc -Wbad-function-cast warning.
4129 (default_value, arithcompare, arith_driver, arith_error): Now static.
4130 (store_symval_forwarding): Rename local to avoid shadowing.
4131 (Fmake_variable_buffer_local, Fmake_local_variable):
4132 Mark variables as initialized.
4133 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4134
4135 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4136 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4137 Rename locals to avoid shadowing.
4138 (mark_stack): Move local variables into the #ifdef region where
4139 they're used.
4140 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4141 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4142 needed otherwise.
4143 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4144 (GC_STRING_CHARS): Remove; not used.
4145 (Fmemory_limit): Cast sbrk's returned value to char *.
4146
4147 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4148 avoids undefined behavior in theory.
4149
4150 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4151
4152 Use functions, not macros, for up- and down-casing (Bug#8254).
4153 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4154 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4155 to use the following functions instead of these macros.
4156 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4157 EMACS_INT, since callers assume the returned value fits in int.
4158 (upcase1): Likewise, for UPCASE_TABLE.
4159 (uppercasep, lowercasep, upcase): New static inline functions.
4160 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4161 the race-condition problem in the old DOWNCASE.
4162
4163 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4164 Rename locals to avoid shadowing.
4165 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4166 (regex_compile, re_search_2, re_match_2_internal):
4167 Remove unused local vars.
4168 (FREE_VAR): Rewrite so as not to use empty "else",
4169 which gcc can warn about.
4170 (regex_compile, re_match_2_internal): Mark locals as initialized.
4171 (RETALLOC_IF): Define only if needed.
4172 (WORDCHAR_P): Likewise. This one is never needed, but is used
4173 only in a comment talking about a compiler bug, so put inside
4174 the #if 0 of that comment.
4175 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4176 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4177 Remove; unused.
4178
4179 * search.c (boyer_moore): Rename locals to avoid shadowing.
4180 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4181 (PREV_CHAR_BOUNDARY): Likewise.
4182
4183 * search.c (simple_search): Remove unused var.
4184
4185 * dired.c (compile_pattern): Move decl from here ...
4186 * lisp.h: ... to here, so that it can be checked.
4187 (struct re_registers): New forward decl.
4188
4189 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4190
4191 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4192 All uses changed.
4193 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4194 Rename locals to avoid shadowing.
4195 (Fvertical_motion): Mark locals as initialized.
4196
4197 * casefiddle.c (casify_object, casify_region): Now static.
4198 (casify_region): Mark local as initialized.
4199
4200 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4201
4202 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4203 New macros, so that the caller can use some names other than
4204 gcpro1, gcpro2, etc.
4205 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4206 of the new macros.
4207 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4208 argument, for consistency with GCPRO2_VAR, etc: it is now the
4209 prefix of the variable, not the variable itself. All uses
4210 changed.
4211 * dired.c (directory_files_internal, file_name_completion):
4212 Rename locals to avoid shadowing.
4213
4214 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4215 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4216 dired.c's scmp function, had undefined behavior.
4217 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4218 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4219 * buffer.h: ... to here, because these macros use current_buffer,
4220 and the new implementation with inline functions needs to have
4221 current_buffer in scope now, rather than later when the macros
4222 are used.
4223 (downcase, upcase1): New static inline functions.
4224 (DOWNCASE, UPCASE1): Reimplement using these functions.
4225 This avoids undefined behavior in expressions like
4226 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4227 from race conditions in accessing the global variables
4228 case_temp1 and case_temp2.
4229 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4230 * lisp.h (case_temp1, case_temp2): Remove their decls.
4231 * character.h (ASCII_CHAR_P): Move from here ...
4232 * lisp.h: ... to here, so that the inline functions mentioned
4233 above can use them.
4234
4235 * dired.c (directory_files_internal_unwind): Now static.
4236
4237 * fileio.c (file_name_as_directory, directory_file_name):
4238 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4239 Now static.
4240 (file_name_as_directory): Use const pointers when appropriate.
4241 (Fexpand_file_name): Likewise. In particular, newdir might
4242 point at constant storage, so make it a const pointer.
4243 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4244 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4245 signedness issues.
4246 (Fset_file_times, Finsert_file_contents, auto_save_error):
4247 Rename locals to avoid shadowing.
4248
4249 * minibuf.c (choose_minibuf_frame_1): Now static.
4250 (Ftry_completion, Fall_completions): Rename or remove locals
4251 to avoid shadowing.
4252
4253 * marker.c (bytepos_to_charpos): Remove; unused.
4254
4255 * lisp.h (verify_bytepos, count_markers): New decls,
4256 so that gcc does not warn that these functions aren't declared.
4257
4258 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4259 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4260 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4261 (copy_text): Remove unused local var.
4262
4263 * filelock.c (within_one_second): Now static.
4264 (lock_file_1): Rename local to avoid shadowing.
4265
4266 * buffer.c (fix_overlays_before): Mark locals as initialized.
4267 (fix_start_end_in_overlays): Likewise. This function should be
4268 simplified by using pointers-to-pointers, but that's a different
4269 matter.
4270 (switch_to_buffer_1): Now static.
4271 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4272 (report_overlay_modification): Rename locals to avoid shadowing.
4273
4274 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4275 Fix pointer signedness issue.
4276 (sys_subshell): Mark local as volatile if checking for lint,
4277 to suppress a gcc -Wclobbered warning that does not seem to be right.
4278 (MAXPATHLEN): Define only if needed.
4279
4280 * process.c (serial_open, serial_configure): Move decls from here ...
4281 * systty.h: ... to here, so that they can be checked.
4282
4283 * fns.c (get_random, seed_random): Move extern decls from here ...
4284 * lisp.h: ... to here, so that they can be checked.
4285
4286 * sysdep.c (reset_io): Now static.
4287 (wait_for_termination_signal): Remove; unused.
4288
4289 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4290 (copy_keymap_item, append_key, push_text_char_description):
4291 Now static.
4292 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4293 (DENSE_TABLE_SIZE): Remove; unused.
4294 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4295 (describe_map_tree):
4296 Rename locals to avoid shadowing.
4297
4298 * keyboard.c: Declare functions static if they are not used elsewhere.
4299 (echo_char, echo_dash, cmd_error, top_level_2):
4300 (poll_for_input, handle_async_input): Now static.
4301 (read_char, kbd_buffer_get_event, make_lispy_position):
4302 (make_lispy_event, make_lispy_movement, apply_modifiers):
4303 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4304 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4305 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4306 (read_key_sequence, read_char): Mark locals as initialized.
4307 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4308
4309 * keyboard.h (make_ctrl_char): New decl.
4310 (mark_kboards): Move decl here ...
4311 * alloc.c (mark_kboards): ... from here.
4312
4313 * lisp.h (force_auto_save_soon): New decl.
4314
4315 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4316 (DEFINE_DUMMY_FUNCTION): New macro.
4317 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4318 Use it.
4319 (main): Add casts to avoid warnings
4320 if GCC considers string literals to be constants.
4321
4322 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4323
4324 * dbusbind.c: Pointer signedness fixes.
4325 (xd_signature, xd_append_arg, xd_initialize):
4326 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4327 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4328 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4329 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4330
4331 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4332 if GCC considers string literals to be constants.
4333 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4334
4335 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4336
4337 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4338 (print_preprocess, print_object): New macro to fix last change.
4339
4340 * print.c (print_preprocess): Don't forget font objects.
4341
4342 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4343
4344 * emacs.c (USAGE3): Doc fixes.
4345
4346 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4347
4348 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4349 structure.
4350
4351 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4352
4353 * lisp.h (VWindow_system, Qfile_name_history):
4354 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4355 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4356 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4357
4358 * w32select.c: Don't #include "keyboard.h".
4359 (run_protected): Add extern declaration for waiting_for_input.
4360
4361 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4362 * w32console.c (detect_input_pending, read_input_pending)
4363 (encode_terminal_code):
4364 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4365 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4366 (w32_system_caret_y, Qfile_name_history):
4367 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4368 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4369 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4370 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4371 * w32proc.c (Qlocal, report_file_error):
4372 * w32term.c (Vwindow_system, updating_frame):
4373 * w32uniscribe.c (initialized, uniscribe_font_driver):
4374 Remove unneeded extern declarations.
4375
4376 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4377
4378 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4379
4380 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4381
4382 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4383 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4384 These macros can no longer be used for assignment.
4385
4386 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4387 Assign struct members directly, instead of using BUF_BEGV etc.
4388 (record_buffer_markers, fetch_buffer_markers): New functions for
4389 recording and fetching special buffer markers.
4390 (set_buffer_internal_1, set_buffer_temp): Use them.
4391
4392 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4393
4394 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4395
4396 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4397 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4398
4399 * xdisp.c (hscroll_window_tree):
4400 (reconsider_clip_changes): Use PT instead of BUF_PT.
4401
4402 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4403
4404 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4405 $(EMACS_ROOT)/lib/intprops.h.
4406
4407 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4408
4409 Fix more problems found by GCC 4.5.2's static checks.
4410
4411 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4412 to unsigned char * to avoid compiler diagnostic.
4413 (xg_free_frame_widgets): Make it clear that a local variable is
4414 needed only if USE_GTK_TOOLTIP.
4415 (gdk_window_get_screen): Make it clear that this macro is needed
4416 only if USE_GTK_TOOLTIP.
4417 (int_gtk_range_get_value): New function, which avoids a diagnostic
4418 from gcc -Wbad-function-cast.
4419 (xg_set_toolkit_scroll_bar_thumb): Use it.
4420 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4421 diagnostic from gcc -Wbad-function-cast.
4422 (get_utf8_string, xg_get_file_with_chooser):
4423 Rename locals to avoid shadowing.
4424 (create_dialog): Move locals to avoid shadowing.
4425
4426 * xgselect.c (xg_select): Remove unused var.
4427
4428 * image.c (four_corners_best): Mark locals as initialized.
4429 (gif_load): Initialize transparent_p to zero (Bug#8238).
4430 Mark another local as initialized.
4431 (my_png_error, my_error_exit): Mark with NO_RETURN.
4432
4433 * image.c (clear_image_cache): Now static.
4434 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4435 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4436 (x_edge_detection): Remove unnecessary cast that
4437 gcc -Wbad-function-cast diagnoses.
4438 (gif_load): Fix pointer signedness.
4439 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4440 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4441
4442 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4443
4444 Improve quality of tests for time stamp overflow.
4445 For example, without this patch (encode-time 0 0 0 1 1
4446 1152921504606846976) returns the obviously-bogus value (-948597
4447 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4448 reports time overflow. See
4449 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4450 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4451 * editfns.c: Include limits.h and intprops.h.
4452 (TIME_T_MIN, TIME_T_MAX): New macros.
4453 (time_overflow): Move earlier, to before first use.
4454 (hi_time, lo_time): New functions, for an accurate test for
4455 out-of-range times.
4456 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4457 (Fget_internal_run_time): Don't assume time_t fits in int.
4458 (make_time): Use list2 instead of Fcons twice.
4459 (Fdecode_time): More accurate test for out-of-range times.
4460 (check_tm_member): New function.
4461 (Fencode_time): Use it, to test for out-of-range times.
4462 (lisp_time_argument): Don't rely on undefined left-shift and
4463 right-shift behavior when checking for time stamp overflow.
4464
4465 * editfns.c (time_overflow): New function, refactoring common code.
4466 (Fformat_time_string, Fdecode_time, Fencode_time):
4467 (Fcurrent_time_string): Use it.
4468
4469 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4470 * dired.c (make_time): Move to ...
4471 * editfns.c (make_time): ... here.
4472 * systime.h: Note the move.
4473
4474 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4475
4476 * fringe.c (update_window_fringes): Remove unused variables.
4477
4478 * unexmacosx.c (copy_data_segment): Also copy __got section.
4479 (Bug#8223)
4480
4481 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4482
4483 * termcap.c [MSDOS]: Include "msdos.h".
4484 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4485 Constify `char *' arguments and their references according to
4486 prototypes in tparam.h.
4487
4488 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4489
4490 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4491 Adapt all references accordingly.
4492
4493 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4494
4495 2011-03-11 Tom Tromey <tromey@redhat.com>
4496
4497 * buffer.c (syms_of_buffer): Remove obsolete comment.
4498
4499 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4500
4501 * termhooks.h (encode_terminal_code): Declare prototype.
4502
4503 * msdos.c (encode_terminal_code): Don't declare prototype.
4504
4505 * term.c (encode_terminal_code): Now external again, used by
4506 w32console.c and msdos.c.
4507
4508 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4509 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4510
4511 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4512
4513 Fix some minor problems found by GCC 4.5.2's static checks.
4514
4515 * fringe.c (update_window_fringes): Mark locals as initialized
4516 (Bug#8227).
4517 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4518
4519 * alloc.c (mark_fringe_data): Move decl from here ...
4520 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4521 to check its interface.
4522 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4523
4524 * fontset.c (free_realized_fontset): Now static.
4525 (Fset_fontset_font): Rename local to avoid shadowing.
4526 (fontset_font): Mark local as initialized.
4527 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4528
4529 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4530
4531 * xselect.c (x_disown_buffer_selections): Remove; not used.
4532 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4533 (x_own_selection, Fx_disown_selection_internal): Rename locals
4534 to avoid shadowing.
4535 (x_handle_dnd_message): Remove local to avoid shadowing.
4536
4537 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4538 so that the caller can use some name other than gcpro1.
4539 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4540 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4541 (Fx_backspace_delete_keys_p):
4542 Use them to avoid shadowing, and rename vars to avoid shadowing.
4543 (x_decode_color, x_set_name, x_window): Now static.
4544 (Fx_create_frame): Add braces to silence GCC warning.
4545 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4546 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4547 Remove unused locals.
4548 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4549 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4550 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4551 macros.
4552
4553 * xterm.h (x_mouse_leave): New decl.
4554
4555 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4556 Remove unused functions.
4557 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4558 (x_calc_absolute_position): Now static.
4559 (XTread_socket): Don't define label "out" unless it's used.
4560 Don't declare local "event" unless it's used.
4561 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4562 unless they are used.
4563 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4564 (x_fatal_error_signal): Remove; not used.
4565 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4566 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4567 (x_error_catcher, x_connection_closed, x_error_handler):
4568 (x_error_quitter, xembed_send_message, x_iconify_frame):
4569 (my_log_handler): Rename locals to avoid shadowing.
4570 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4571 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4572
4573 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4574 Rename or move locals to avoid shadowing.
4575 (tty_defined_color, merge_face_heights): Now static.
4576 (free_realized_faces_for_fontset): Remove; not used.
4577 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4578 does not deduce is never used uninitialized.
4579 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4580 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4581
4582 * terminal.c (store_terminal_param): Now static.
4583
4584 * xmenu.c (menu_highlight_callback): Now static.
4585 (set_frame_menubar): Remove unused local.
4586 (xmenu_show): Rename parameter to avoid shadowing.
4587 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4588 since they might point to immutable storage.
4589 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4590 since it's unused otherwise.
4591
4592 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4593 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4594 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4595 avoids a gcc -Wuninitialized diagnostic.
4596 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4597 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4598 does not deduce are never used uninitialized.
4599
4600 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4601
4602 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4603 * window.c (window_loop, size_window):
4604 (run_window_configuration_change_hook, enlarge_window): Likewise.
4605
4606 * window.c (display_buffer): Now static.
4607 (size_window): Mark variables that gcc -Wuninitialized
4608 does not deduce are never used uninitialized.
4609 * window.h (check_all_windows): New decl, to forestall
4610 gcc -Wmissing-prototypes diagnostic.
4611 * dispextern.h (bidi_dump_cached_states): Likewise.
4612
4613 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4614 shadowing.
4615 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4616 Include <limits.h>.
4617 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4618 and to avoid gcc -Wuninitialized warning.
4619 (load_charset_map): Mark variables that gcc -Wuninitialized
4620 does not deduce are never used uninitialized.
4621 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4622
4623 * coding.c (coding_set_source, coding_set_destination):
4624 Use "else { /* comment */ }" rather than "else /* comment */;"
4625 for clarity, and to avoid gcc -Wempty-body warning.
4626 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4627 a block, when the outer 'i' will do.
4628 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4629 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4630 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4631 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4632 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4633 Rename locals to avoid shadowing.
4634 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4635 * coding.c (emacs_mule_char, encode_invocation_designation):
4636 Now static, since they're not used elsewhere.
4637 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4638 (decode_coding_object, encode_coding_object, detect_coding_system):
4639 (decode_coding_emacs_mule): Mark variables that gcc
4640 -Wuninitialized does not deduce are never used uninitialized.
4641 (detect_coding_iso_2022): Initialize a local variable that might
4642 be used uninitialized. Leave a FIXME because it's not clear that
4643 this initialization is needed. (Bug#8211)
4644 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4645 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4646 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4647 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4648 Remove unused macros.
4649
4650 * category.c (hash_get_category_set): Remove unused local var.
4651 (copy_category_table): Now static, since it's not used elsewhere.
4652 * character.c (string_count_byte8): Likewise.
4653
4654 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4655 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4656
4657 * chartab.c (copy_sub_char_table): Now static, since it's not used
4658 elsewhere.
4659 (sub_char_table_ref_and_range, char_table_ref_and_range):
4660 Rename locals to avoid shadowing.
4661 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4662
4663 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4664 (BIDI_BOB): Remove unused macro.
4665
4666 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4667 deduce are never used uninitialized.
4668 * term.c (encode_terminal_code): Likewise.
4669
4670 * term.c (encode_terminal_code): Now static. Remove unused local.
4671
4672 * tparam.h: New file.
4673 * term.c, tparam.h: Include it.
4674 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4675 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4676 Move these decls to tparam.h, and make them agree with what
4677 is actually in tparam.c. The previous trick of using incompatible
4678 decls in different modules does not conform to the C standard.
4679 All callers of tparam changed to use tparam's actual API.
4680 * tparam.c (tparam1, tparam, tgoto):
4681 Use const pointers where appropriate.
4682
4683 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4684 * cm.h (struct cm): Likewise.
4685 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4686 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4687 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4688 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4689 (turn_on_face, init_tty): Likewise.
4690 * termchar.h (struct tty_display_info): Likewise.
4691
4692 * term.c (term_mouse_position): Rename local to avoid shadowing.
4693
4694 * alloc.c (mark_ttys): Move decl from here ...
4695 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4696
4697 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4698
4699 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4700
4701 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4702
4703 * search.c (compile_pattern_1): Remove argument regp, unused since
4704 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4705 (compile_pattern): Don't pass it.
4706
4707 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4708
4709 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4710 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4711 for ! HAVE_GTK3.
4712 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4713
4714 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4715
4716 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4717 gdk_window_get_screen, gdk_window_get_geometry,
4718 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4719 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4720 (xg_get_pixbuf_from_pixmap): New function.
4721 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4722 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4723 Call xg_get_pixbuf_from_pixmap instead of
4724 gdk_pixbuf_get_from_drawable.
4725 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4726 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4727 (xg_check_special_colors): Use GtkStyleContext and its functions
4728 for HAVE_GTK3.
4729 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4730 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4731 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4732 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4733 Call gtk_widget_get_preferred_size.
4734 (xg_frame_resized): gdk_window_get_geometry only takes 5
4735 parameters.
4736 (xg_win_to_widget, xg_event_is_for_menubar):
4737 Call gdk_x11_window_lookup_for_display.
4738 (xg_set_widget_bg): New function.
4739 (delete_cb): New function.
4740 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4741 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4742 (xg_set_background_color): Call xg_set_widget_bg.
4743 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4744 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4745 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4746 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4747 if ! HAVE_GTK3.
4748 (update_frame_tool_bar): Call gtk_widget_hide.
4749 (xg_initialize): Use GDK_KEY_g.
4750
4751 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4752 if ! HAVE_GTK3
4753 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4754
4755 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4756 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4757 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4758
4759 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4760
4761 * w32xfns.c (select_palette): Check success of RealizePalette against
4762 GDI_ERROR, not zero.
4763
4764 See ChangeLog.11 for earlier changes.
4765
4766 ;; Local Variables:
4767 ;; coding: utf-8
4768 ;; End:
4769
4770 Copyright (C) 2011 Free Software Foundation, Inc.
4771
4772 This file is part of GNU Emacs.
4773
4774 GNU Emacs is free software: you can redistribute it and/or modify
4775 it under the terms of the GNU General Public License as published by
4776 the Free Software Foundation, either version 3 of the License, or
4777 (at your option) any later version.
4778
4779 GNU Emacs is distributed in the hope that it will be useful,
4780 but WITHOUT ANY WARRANTY; without even the implied warranty of
4781 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4782 GNU General Public License for more details.
4783
4784 You should have received a copy of the GNU General Public License
4785 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.