1 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3 * buffer.c: Memory overflow fixes.
4 (overlays_at, overlays_in, record_overlay_string, overlay_strings):
5 Don't update size of array until after memory allocation succeeds,
6 because xmalloc/xrealloc may not return.
8 * bidi.c: Integer overflow fix.
9 (bidi_shelve_header_size): New constant.
10 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
11 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
13 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
15 Use ptrdiff_t for composition IDs.
16 * character.c (lisp_string_width):
17 * composite.c (composition_table_size, n_compositions)
18 (get_composition_id, composition_gstring_from_id):
19 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
20 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
21 * window.c (Frecenter):
22 Use ptrdiff_t, not int, for composition IDs.
23 * composite.c (get_composition_id): Check for integer overflow.
24 * composite.h: Adjust prototypes to match the above changes.
26 Use ptrdiff_t for hash table indexes.
27 * category.c (hash_get_category_set):
29 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
30 * coding.c (coding_system_charset_list, detect_coding_system):
31 * coding.h (struct coding_system.id):
32 * composite.c (get_composition_id, gstring_lookup_cache):
33 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
34 * image.c (xpm_get_color_table_h):
35 * lisp.h (hash_lookup, hash_put):
36 * minibuf.c (Ftest_completion):
37 Use ptrdiff_t for hash table indexes, not int (which is too
38 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
39 32-bit --with-wide-int hosts).
41 * charset.c (Fdefine_charset_internal): Check for integer overflow.
42 Add a FIXME comment about memory leaks.
43 (syms_of_charset): Don't assume xmalloc returns.
45 Don't assume that stated character widths fit in int.
46 * character.c (Fchar_width, c_string_width, lisp_string_width):
47 * character.h (CHAR_WIDTH):
48 * indent.c (MULTIBYTE_BYTES_WIDTH):
49 Use sanitize_char_width to avoid undefined and/or bad behavior
50 with outlandish widths.
51 * character.h (sanitize_tab_width): Renamed from sanitize_width,
52 now that we have two such functions. All uses changed.
53 (sanitize_char_width): New inline function.
55 Don't assume that tab-width fits in int.
56 * character.h (sanitize_width): New inline function.
57 (SANE_TAB_WIDTH): New macro.
58 (ASCII_CHAR_WIDTH): Use it.
59 * indent.c (sane_tab_width): Remove. All uses replaced by
60 SANE_TAB_WIDTH (current_buffer).
61 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
63 * fileio.c: Integer overflow issues with file modes.
64 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
66 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
67 Remove unreachable code.
68 (read_hex, load_charset_map_from_file): Check for integer overflow.
70 * xterm.c: don't go over XClientMessageEvent limit
71 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
72 (x_send_scroll_bar_event): Likewise. Check that the size does not
73 exceed limits imposed by XClientMessageEvent, as well as the usual
74 ptrdiff_t and size_t limits.
76 * keyboard.c: Overflow, signedness and related fixes.
77 (make_lispy_movement): Use same integer type in forward decl
78 that is used in the definition.
79 (read_key_sequence, keyremap_step):
80 Change bufsize argument back to int, undoing my 2011-03-30 change.
81 We prefer signed types, and int is wide enough here.
82 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
83 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
84 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
85 length, not size_t. Use ptrdiff_t for index, not int.
86 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
87 possibility of integer overflow.
89 Overflow, signedness and related fixes for images.
91 * dispextern.h (struct it.stack[0].u.image.image_id)
92 (struct_it.image_id, struct image.id, struct image_cache.size)
93 (struct image_cache.used, struct image_cache.ref_count):
94 * gtkutil.c (update_frame_tool_bar):
95 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
96 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
97 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
98 * nsmenu.m (update_frame_tool_bar):
99 * xdisp.c (calc_pixel_width_or_height):
100 * xfns.c (image_cache_refcount):
101 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
102 on typical 64-bit hosts.
104 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
105 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
106 Omit unnecessary casts to int.
107 (parse_image_spec): Check that integers fall into 'int' range
108 when the callers expect that.
109 (image_ascent): Redo ascent calculation to avoid int overflow.
110 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
111 (lookup_image): Remove unnecessary tests.
112 (xbm_image_p): Locals are now of int, not EMACS_INT,
113 since parse_image_check makes sure they fit into int.
114 (png_load, gif_load, svg_load_image):
115 Prefer int to unsigned where either will do.
116 (tiff_handler): New function, combining the cores of the
117 old tiff_error_handler and tiff_warning_handler. This
118 function is rewritten to use vsnprintf and thereby avoid
119 stack buffer overflows. It uses only the features of vsnprintf
120 that are common to both POSIX and native Microsoft.
121 (tiff_error_handler, tiff_warning_handler): Use it.
122 (tiff_load, gif_load, imagemagick_load_image):
123 Don't assume :index value fits in 'int'.
124 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
125 (imagemagick_load_image): Check that crop parameters fit into
126 the integer types that MagickCropImage accepts. Don't assume
127 Vimagemagick_render_type has a nonnegative value. Don't assume
128 size_t fits in 'long'.
129 (gs_load): Use printmax_t to print the widest integers possible.
130 Check for integer overflow when computing image height and width.
132 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
134 Integer signedness and overflow and related fixes. (Bug#9079)
136 * bidi.c: Integer size and overflow fixes.
137 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
138 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
139 (bidi_cache_find_level_change, bidi_cache_ensure_space)
140 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
141 (bidi_find_other_level_edge):
142 Use ptrdiff_t instead of EMACS_INT where either will do.
143 This works better on 32-bit hosts configured --with-wide-int.
144 (bidi_cache_ensure_space): Check for size-calculation overflow.
145 Use % rather than repeated addition, for better worst-case speed.
146 Don't set bidi_cache_size until after xrealloc returns, because it
148 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
149 (bidi_cache_ensure_space): Also check that the bidi cache size
150 does not exceed that of the largest Lisp string or buffer. See Eli
151 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
153 * alloc.c (__malloc_size_t): Remove.
154 All uses replaced by size_t. See Andreas Schwab's note
155 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
157 * image.c: Improve checking for integer overflow.
158 (check_image_size): Assume that f is nonnull, since
159 it is always nonnull in practice. This is one less thing to
160 worry about when checking for integer overflow later.
161 (x_check_image_size): New function, which checks for integer
162 overflow issues inside X.
163 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
164 This removes the need for a memory_full check.
165 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
166 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
167 (xbm_read_bitmap_data): Change locals back to 'int', since
168 their values must fit in 'int'.
169 (xpm_load_image, png_load, tiff_load):
170 Invoke x_create_x_image_and_pixmap earlier,
171 to avoid much needless work if the image is too large.
172 (tiff_load): Treat overly large images as if
173 x_create_x_image_and_pixmap failed, not as malloc failures.
174 (gs_load): Use x_check_image_size.
176 * gtkutil.c: Omit integer casts.
177 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
178 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
180 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
182 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
183 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
184 would wrongly return t on a 64-bit host.
186 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
187 The plain *_OVERFLOW macros run afoul of GCC bug 49705
188 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
189 and therefore cause GCC to emit a bogus diagnostic in some cases.
191 * image.c: Integer signedness and overflow and related fixes.
192 This is not an exhaustive set of fixes, but it's time to
193 record what I've got.
194 (lookup_pixel_color, check_image_size): Remove redundant decls.
195 (check_image_size): Don't assume that arbitrary EMACS_INT values
196 fit in 'int', or that arbitrary 'double' values fit in 'int'.
197 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
198 (tiff_load, imagemagick_load_image):
199 Check for overflow in size calculations.
200 (x_create_x_image_and_pixmap): Remove unnecessary test for
201 xmalloc returning NULL; that can't happen.
202 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
203 (xpm_color_bucket): Use better integer hashing function.
204 (xpm_cache_color): Don't possibly over-allocate memory.
205 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
207 Use ptrdiff_t, not int or size_t, to record sizes.
208 (png_load): Don't assume values greater than 2**31 fit in 'int'.
209 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
210 either works, as we prefer signed integers.
211 (tiff_read_from_memory, tiff_write_from_memory):
212 Return tsize_t, not size_t, since that's what the TIFF API wants.
213 (tiff_read_from_memory): Don't fail simply because the read would
214 go past EOF; instead, return a short read.
215 (tiff_load): Omit no-longer-needed casts.
216 (Fimagemagick_types): Don't assume size fits into 'int'.
218 Improve hashing quality when configured --with-wide-int.
219 * fns.c (hash_string): New function, taken from sxhash_string.
220 Do not discard information about ASCII character case; this
221 discarding is no longer needed.
222 (sxhash-string): Use it. Change sig to match it. Caller changed.
223 * lisp.h: Declare it.
224 * lread.c (hash_string): Remove, since we now use fns.c's version.
225 The fns.c version returns a wider integer if --with-wide-int is
226 specified, so this should help the quality of the hashing a bit.
228 * emacs.c: Integer overflow minor fix.
229 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
230 Define only if GNU_LINUX.
231 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
233 * dispnew.c: Integer signedness and overflow fixes.
234 Remove unnecessary forward decls, that were a maintenance hassle.
235 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
237 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
238 (scrolling_window): Use ptrdiff_t, not int, for byte count.
239 (prepare_desired_row, line_draw_cost):
240 Use int, not unsigned, where either works.
241 (save_current_matrix, restore_current_matrix):
242 Use ptrdiff_t, not size_t, where either works.
243 (init_display): Check for overflow more accurately, and without
244 relying on undefined behavior.
246 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
247 Remove, replacing with the new symbols in lisp.h. All uses changed.
248 * fileio.c (make_temp_name):
249 * filelock.c (lock_file_1, lock_file):
250 * xdisp.c (message_dolog):
251 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
252 Use pMd etc. instead.
253 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
254 replacing the pWIDE etc. symbols removed from editfns.c.
256 * keyboard.h (num_input_events): Now uintmax_t.
257 This is (very slightly) less likely to mess up due to wraparound.
260 * buffer.c: Integer signedness fixes.
261 (alloc_buffer_text, enlarge_buffer_text):
262 Use ptrdiff_t rather than size_t when either will do, as we prefer
265 * alloc.c: Integer signedness and overflow fixes.
266 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
267 (__malloc_size_t): Default to size_t, not to int.
268 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
269 (Fgarbage_collect, mark_object_loop_halt, mark_object):
270 Prefer ptrdiff_t to size_t when either would do, as we prefer
272 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
273 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
274 Now const. Initialize with values that are in range even if char
276 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
277 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
278 These functions do the right thing with sizes > 2**32.
279 (check_depth): Now ptrdiff_t, not int.
280 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
281 Adjust to new way of storing sizes. Check for size overflow bugs
283 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
284 slightly wrong anyway, as it missed one instance of
285 XMALLOC_OVERRUN_CHECK_OVERHEAD.
286 (refill_memory_reserve): Omit needless cast to size_t.
287 (mark_object_loop_halt): Mark as externally visible.
289 * xselect.c: Integer signedness and overflow fixes.
290 (Fx_register_dnd_atom, x_handle_dnd_message):
291 Use ptrdiff_t, not size_t, since we prefer signed.
292 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
293 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
294 x_dnd_atoms_size and x_dnd_atoms_length.
296 * doprnt.c: Prefer signed to unsigned when either works.
300 * xdisp.c (vmessage):
301 Use ptrdiff_t, not size_t, when using or implementing doprnt,
302 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
303 prefer signed arithmetic to avoid comparison confusion.
304 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
307 Assume freestanding C89 headers, string.h, stdlib.h.
308 * data.c, doprnt.c, floatfns.c, print.c:
309 Include float.h unconditionally.
310 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
311 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
312 * regex.c: Likewise for stddef.h, string.h.
313 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
314 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
315 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
316 (STDC_HEADERS): Remove obsolete defines.
317 * sysdep.c: Include limits.h unconditionally.
319 Assume support for memcmp, memcpy, memmove, memset.
320 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
321 * regex.c (memcmp, memcpy):
322 Remove; we assume C89 now.
324 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
325 (__malloc_safe_bcopy): Remove; no longer needed.
327 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
328 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
329 well either way, and we prefer signed to unsigned.
331 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
334 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
335 and the surrounding thread.
336 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
337 rather than fgets, and retry after EINTR. Otherwise, 'emacs
338 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
340 * s/openbsd.h (BROKEN_SIGIO): Define.
341 * unexelf.c (unexec) [__OpenBSD__]:
342 Don't update the .mdebug section of the Alpha COFF symbol table.
344 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
346 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
349 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
351 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
352 This fixes some race conditions on the permissions of any newly
355 * alloc.c (valid_pointer_p): Use pipe, not open.
356 This fixes some permissions issues when debugging.
358 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
359 If fchown fails to set both uid and gid, try to set just gid,
360 as that is sometimes allowed. Adjust the file's mode to eliminate
361 setuid or setgid bits that are inappropriate if fchown fails.
363 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
365 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
366 to compare Lisp_Objects.
367 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
368 global_gnutls_log_level, don't mistake it for a Lisp_Object.
369 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
371 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
373 * lread.c (read_integer): Unread even EOF character.
374 (read1): Likewise. Properly record start position of symbol.
376 * lread.c (read1): Read `#:' as empty uninterned symbol if no
377 symbol character follows.
379 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
381 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
382 This works around a problem with the previous change to Fcopy_file.
383 Recent glibc declares fchown with __attribute__((warn_unused_result)),
384 and without this change, GCC might complain about discarding
385 fchown's return value.
387 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
389 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
391 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
393 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
395 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
397 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
398 it's used from the C level.
400 * process.c: Use the same condition for POLL_FOR_INPUT in both
401 keyboard.c and process.c (bug#1858).
403 2011-07-09 Lawrence Mitchell <wence@gmx.li>
405 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
406 (Fgnutls_boot): Use it.
408 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
410 * doc.c (Fsubstitute_command_keys): Revert last change.
412 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
414 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
415 quotes the next character, and doesn't affect other longer
416 sequences (bug#8935).
418 * lread.c (syms_of_lread): Clarify that is isn't only
419 `eval-buffer' and `eval-defun' that's affected by
420 `lexical-binding' (bug#8460).
422 2011-07-15 Eli Zaretskii <eliz@gnu.org>
424 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
425 bidi redisplay when a line includes both an image and is
428 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
430 Fix minor problems found by static checking.
431 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
432 (elsz): Now a signed constant, not a size_t var. We prefer signed
433 types to unsigned, to avoid integer comparison confusion. Without
434 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
435 "cannot optimize loop, the loop counter may overflow", a symptom
437 * indent.c (Fvertical_motion): Mark locals as initialized.
438 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
440 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
442 * search.c (Fre_search_backward): Mention `case-fold-search' in
443 all the re_search_* functions (bug#8138).
445 * keyboard.c (Fopen_dribble_file): Document when the file is
448 2011-07-14 Eli Zaretskii <eliz@gnu.org>
450 * bidi.c (bidi_dump_cached_states): Fix format of displaying
453 Support bidi reordering of display and overlay strings.
454 * xdisp.c (compute_display_string_pos)
455 (compute_display_string_end): Accept additional argument STRING.
456 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
457 (reseat_to_string): Initialize bidi_it->string.s and
458 bidi_it->string.schars.
459 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
460 NULL (avoids a crash in bidi_paragraph_init). Initialize
462 (init_iterator): Call bidi_init_it only of a valid
463 buffer position was specified. Initialize paragraph_embedding to
465 (reseat_to_string): Initialize the bidi iterator.
466 (display_string): If we need to ignore text properties of
467 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
468 original value of -1 will not work with bidi.)
469 (compute_display_string_pos): First arg is now struct
470 `text_pos *'; all callers changed. Support display properties on
472 (compute_display_string_end): Support display properties on Lisp
474 (init_iterator, reseat_1, reseat_to_string): Initialize the
475 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
476 when iterating on a string not from display properties).
477 (compute_display_string_pos, compute_display_string_end): Fix
478 calculation of the object to scan. Fixes an error when using
480 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
481 base_level_stop; instead, set base_level_stop to BEGV. Fixes
482 crashes in vertical-motion.
483 (next_element_from_buffer): Improve commentary for when
484 the iterator is before prev_stop.
485 (init_iterator): Initialize bidi_p from the default value of
486 bidi-display-reordering, not from buffer-local value. Use the
487 buffer-local value only if initializing for buffer iteration.
488 (handle_invisible_prop): Support invisible properties on strings
489 that are being bidi-reordered.
490 (set_iterator_to_next): Support bidi reordering of C strings and
492 (next_element_from_string): Support bidi reordering of Lisp
494 (handle_stop_backwards): Support Lisp strings as well.
495 (display_string): Support display of R2L glyph rows. Use
496 IT_STRING_CHARPOS when displaying from a Lisp string.
497 (init_iterator): Don't initialize it->bidi_p for strings
499 (reseat_to_string): Initialize it->bidi_p for strings here.
500 (next_element_from_string, next_element_from_c_string)
501 (next_element_from_buffer): Add xassert's for correspondence
502 between IT's object being iterated and it->bidi_it.string
504 (face_before_or_after_it_pos): Support bidi iteration.
505 (next_element_from_c_string): Handle the case of the first string
506 character that is not the first one in the visual order.
507 (get_visually_first_element): New function, refactored from common
508 parts of next_element_from_buffer, next_element_from_string, and
509 next_element_from_c_string.
510 (tool_bar_lines_needed, redisplay_tool_bar)
511 (display_menu_bar): Force left-to-right direction. Add a FIXME
512 comment for making that be controlled by a user option.
513 (push_it, pop_it): Save and restore the state of the
514 bidi iterator. Save and restore the bidi_p flag.
515 (pop_it): Iterate out of display property for string iteration as
517 (iterate_out_of_display_property): Support iteration over strings.
518 (handle_single_display_spec): Set up it->bidi_it for iteration
519 over a display string, and call bidi_init_it.
520 (handle_single_display_spec, next_overlay_string)
521 (get_overlay_strings_1, push_display_prop): Set up the bidi
522 iterator for displaying display or overlay strings.
523 (forward_to_next_line_start): Don't use the shortcut if
525 (back_to_previous_visible_line_start): If handle_display_prop
526 pushed the iterator stack, restore the internal state of the bidi
527 iterator by calling bidi_pop_it same number of times.
528 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
529 and we are bidi-iterating, don't decrement the iterator position;
530 instead, set the first_elt flag in the bidi iterator, to produce
532 (reseat_1): Remove redundant setting of string_from_display_prop_p.
533 (push_display_prop): xassert that we are iterating a buffer.
534 (push_it, pop_it): Save and restore paragraph_embedding member.
535 (handle_single_display_spec, next_overlay_string)
536 (get_overlay_strings_1, reseat_1, reseat_to_string)
537 (push_display_prop): Set up the `unibyte' member of bidi_it.string
538 correctly. Don't assume unibyte strings are not bidi-reordered.
539 (compute_display_string_pos)
540 (compute_display_string_end): Fix handling the case of C string.
541 (push_it, pop_it): Save and restore from_disp_prop_p.
542 (handle_single_display_spec, push_display_prop): Set the
543 from_disp_prop_p flag.
544 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
545 (pop_it): Call iterate_out_of_display_property only if we are
546 popping after iteration over a string that came from a display
547 property. Fix a typo in popping stretch info. Add an assertion
548 for verifying that the iterator position is in sync with the bidi
550 (handle_single_display_spec, get_overlay_strings_1)
551 (push_display_prop): Fix initialization of paragraph direction for
552 string when that of the parent object is not yet determined.
553 (reseat_1): Call bidi_init_it to resync the bidi
554 iterator with IT's position. (Bug#7616)
555 (find_row_edges): If ROW->start.pos gives position
556 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
557 (handle_stop, back_to_previous_visible_line_start, reseat_1):
558 Reset the from_disp_prop_p flag.
559 (SAVE_IT, RESTORE_IT): New macros.
560 (pos_visible_p, face_before_or_after_it_pos)
561 (back_to_previous_visible_line_start)
562 (move_it_in_display_line_to, move_it_in_display_line)
563 (move_it_to, move_it_vertically_backward, move_it_by_lines)
564 (try_scrolling, redisplay_window, display_line): Use them when
565 saving a temporary copy of the iterator and restoring it back.
566 (back_to_previous_visible_line_start, reseat_1)
567 (init_iterator): Empty the bidi cache "stack".
568 (move_it_in_display_line_to): If iterator ended up at
569 EOL, but we never saw any buffer positions smaller than
570 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
571 motion in bidi-reordered lines.
572 (move_it_in_display_line_to): Record prev_method and prev_pos
573 immediately before the call to set_iterator_to_next. Fixes cursor
574 motion in bidi-reordered lines with stretch glyphs and strings
575 displayed in margins. (Bug#8133) (Bug#8867)
576 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
578 (pos_visible_p): Support positions in bidi-reordered lines. Save
579 and restore bidi cache.
581 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
582 (bidi_paragraph_info): Delete unused struct.
583 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
584 (bidi_cache_start): New variable.
585 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
587 (bidi_cache_fetch_state, bidi_cache_search)
588 (bidi_cache_find_level_change, bidi_cache_iterator_state)
589 (bidi_cache_find, bidi_peek_at_next_level)
590 (bidi_level_of_next_char, bidi_find_other_level_edge)
591 (bidi_move_to_visually_next): Compare cache index with
592 bidi_cache_start rather than with zero.
593 (bidi_fetch_char): Accept new argument STRING; all callers
594 changed. Support iteration over a string. Support strings with
595 display properties. Support unibyte strings. Fix the type of
596 `len' according to what STRING_CHAR_AND_LENGTH expects.
597 (bidi_paragraph_init, bidi_resolve_explicit_1)
598 (bidi_resolve_explicit, bidi_resolve_weak)
599 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
600 iteration over a string.
601 (bidi_set_sor_type, bidi_resolve_explicit_1)
602 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
603 can now be zero (for strings); special values 0 and -1 were
604 changed to -1 and -2, respectively.
605 (bidi_char_at_pos): New function.
606 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
607 Call it instead of FETCH_MULTIBYTE_CHAR.
608 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
609 initialized to valid values.
610 (bidi_init_it): Don't initialize charpos and bytepos with invalid
612 (bidi_level_of_next_char): Allow the sentinel "position" to pass
613 the test for valid cached positions. Fix the logic for looking up
614 the sentinel state in the cache. GCPRO the Lisp string we are
616 (bidi_push_it, bidi_pop_it): New functions.
617 (bidi_initialize): Initialize the bidi cache start stack pointer.
618 (bidi_cache_ensure_space): New function, refactored from part of
619 bidi_cache_iterator_state. Don't assume the required size is just
620 one BIDI_CACHE_CHUNK away.
621 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
622 (bidi_count_bytes, bidi_char_at_pos): New functions.
623 (bidi_cache_search): Don't assume bidi_cache_last_idx is
624 always valid if bidi_cache_idx is valid.
625 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
626 is valid if it's going to be used.
627 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
628 (bidi_cache_fetch_state, bidi_cache_search)
629 (bidi_cache_find_level_change, bidi_cache_ensure_space)
630 (bidi_cache_iterator_state, bidi_cache_find)
631 (bidi_find_other_level_edge, bidi_cache_start_stack): All
632 variables related to cache indices are now EMACS_INT.
634 * dispextern.h (struct bidi_string_data): New structure.
635 (struct bidi_it): New member `string'. Make flag members be 1-bit
636 fields, and put them last in the struct.
637 (compute_display_string_pos, compute_display_string_end): Update
639 (bidi_push_it, bidi_pop_it): Add prototypes.
640 (struct iterator_stack_entry): New members bidi_p,
641 paragraph_embedding, and from_disp_prop_p.
642 (struct it): Member bidi_p is now a bit field 1 bit wide.
643 (bidi_shelve_cache, bidi_unshelve_cache): Declare
646 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
647 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
648 and vector-like objects.
650 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
651 cache around display iteration.
653 * window.c (Fwindow_end, window_scroll_pixel_based)
654 (displayed_window_lines, Frecenter): Save and restore the bidi
655 cache around display iteration.
657 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
659 * editfns.c (Fdelete_region): Clarify the use of the named
660 parameters (bug#6788).
662 2011-07-14 Martin Rudalics <rudalics@gmx.at>
664 * indent.c (Fvertical_motion): Set and restore w->pointm when
665 saving and restoring the window's buffer (Bug#9006).
667 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
669 * editfns.c (Fstring_to_char): Clarify just what is returned
670 (bug#6576). Text by Eli Zaretskii.
672 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
674 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
676 2011-07-13 Eli Zaretskii <eliz@gnu.org>
678 * buffer.c (mmap_find): Fix a typo.
680 2011-07-13 Johan Bockgård <bojohan@gnu.org>
682 Fix execution of x selection hooks.
683 * xselect.c (Qx_lost_selection_functions)
684 (Qx_sent_selection_functions): New vars.
685 (syms_of_xselect): DEFSYM them.
686 (x_handle_selection_request): Pass Qx_sent_selection_functions
687 rather than Vx_sent_selection_functions to Frun_hook_with_args.
688 (x_handle_selection_clear,x_clear_frame_selections):
689 Pass Qx_lost_selection_functions rather than
690 Vx_lost_selection_functions to Frun_hook_with_args.
692 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
694 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
695 The old code sometimes used this field without initializing it.
697 * alloc.c (gc_sweep): Don't read past end of array.
698 In theory, the old code could also have corrupted Emacs internals,
699 though it'd be very unlikely.
701 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
703 * character.c (Fcharacterp): Don't advertise optional ignored
706 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
708 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
711 * window.c (Fset_window_start): Doc fix (bug#4199).
712 (Fset_window_hscroll): Ditto.
714 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
716 Fix minor new problems caught by GCC 4.6.1.
717 * term.c (init_tty): Remove unused local.
718 * xsettings.c (store_monospaced_changed): Define this function only
719 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
722 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
724 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
726 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
728 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
729 are the mini-buffer and the echo area (bug#3320).
731 * term.c (init_tty): Remove support for supdup, c10 and perq
732 terminals, which are no longer supported (bug#1482).
734 2011-07-10 Johan Bockgård <bojohan@gnu.org>
736 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
738 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
740 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
741 for non-popups (Bug#3642).
743 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
745 * alloc.c (reset_malloc_hooks): Protoize.
746 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
747 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
748 * cm.c (losecursor): Likewise.
749 * data.c (fmod): Likewise.
750 * dispnew.c (swap_glyphs_in_rows): Likewise.
751 * emacs.c (memory_warning_signal): Likewise.
752 * floatfns.c (float_error): Likewise.
753 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
754 (otf_open, font_otf_capability, generate_otf_features)
755 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
757 * image.c (pbm_read_file): Likewise.
758 * indent.c (string_display_width): Likewise.
759 * intervals.c (check_for_interval, search_for_interval)
760 (inc_interval_count, count_intervals, root_interval)
761 (adjust_intervals_for_insertion, make_new_interval): Likewise.
762 * lread.c (defalias): Likewise.
763 * ralloc.c (r_alloc_check): Likewise.
764 * regex.c (set_image_of_range_1, set_image_of_range)
765 (regex_grow_registers): Likewise.
766 * sysdep.c (strerror): Likewise.
767 * termcap.c (valid_filename_p, tprint, main): Likewise.
768 * tparam.c (main): Likewise.
769 * unexhp9k800.c (run_time_remap, save_data_space)
770 (update_file_ptrs, read_header, write_header, calculate_checksum)
771 (copy_file, copy_rest, display_header): Likewise.
772 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
774 * xdisp.c (check_it): Likewise.
775 * xfaces.c (register_color, unregister_color, unregister_colors):
777 * xfns.c (print_fontset_result): Likewise.
778 * xrdb.c (member, fatal, main): Likewise.
780 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
782 Fix minor problems found by static checking (Bug#9031).
783 * chartab.c (char_table_set_range, map_sub_char_table):
784 Remove unused locals.
785 (uniprop_table): Now static.
786 * composite.c (_work_char): Remove unused static var.
788 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
790 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
792 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
794 * gtkutil.c (qttip_cb): Remove code without function.
796 2011-07-09 Eli Zaretskii <eliz@gnu.org>
798 * w32.c (pthread_sigmask): New stub.
800 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
802 Use pthread_sigmask, not sigprocmask (Bug#9010).
803 sigprocmask is portable only for single-threaded applications, and
804 Emacs can be multi-threaded when it uses GTK.
805 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
807 * callproc.c (Fcall_process):
808 * process.c (create_process):
809 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
810 Use pthread_sigmask, not sigprocmask.
812 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
814 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
815 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
818 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
820 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
821 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
822 (xg_hide_tooltip): Fix comment.
824 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
825 in registerServicesMenuSendTypes.
826 (validRequestorForSendType): Don't check ns_return_types.
828 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
831 2011-07-08 Jason Rumney <jasonr@gnu.org>
833 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
834 frame struct members of non-existent frames (Bug#6284).
836 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
838 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
839 variable firstTime not needed on OSX >= 10.6.
840 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
841 >= 10.5. Use setKnobProportion, setDoubleValue.
843 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
844 (MAC_OS_X_VERSION_10_5): Define if not defined.
845 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
846 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
847 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
849 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
850 cString and lossyCString on OSX >= 10.4
852 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
853 sizeToFit on OSX >= 10.2.
855 * nsimage.m (allocInitFromFile): Don't use deprecated method
856 bestRepresentationForDevice on OSX >= 10.6.
858 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
861 * emacs.c: Declare unexec_init_emacs_zone.
863 * nsgui.h: Fix compiler warning about gnulib redefining verify.
865 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
867 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
868 on svcsMenu (Bug#8842).
870 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
872 (Fns_list_services): Just return Qnil on 10.6, code not working there.
874 * nsterm.m (QUTF8_STRING): Declare.
875 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
876 (validRequestorForSendType): Return type is (id).
877 Change indexOfObjectIdenticalTo to indexOfObject.
878 Check if we have local selection before returning self (Bug#8842).
879 (writeSelectionToPasteboard): Put local selection into paste board
880 if we have a local selection (Bug#8842).
881 (syms_of_nsterm): DEFSYM QUTF8_STRING.
883 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
884 (ns_get_local_selection): Declare.
886 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
888 * keymap.c (describe_map_tree): Don't insert a double newline at
889 the end of the buffer (bug#1169) and return whether we inserted
892 * callint.c (Fcall_interactively): Change "reading args" to
893 "providing args" to try to clarify what it does (bug#1010).
895 2011-07-07 Kenichi Handa <handa@m17n.org>
897 * composite.c (composition_compute_stop_pos): Ignore a static
898 composition starting before CHARPOS (Bug#8915).
900 * xdisp.c (handle_composition_prop): Likewise.
902 2011-07-07 Eli Zaretskii <eliz@gnu.org>
904 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
907 2011-07-07 Kenichi Handa <handa@m17n.org>
909 * character.h (unicode_category_t): New enum type.
911 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
912 (Qchar_code_property_table): New variable.
913 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
914 (UNIPROP_COMPRESSED_FORM_P): New macros.
915 (char_table_ascii): Uncompress the compressed values.
916 (sub_char_table_ref): New arg is_uniprop. Callers changed.
917 Uncompress the compressed values.
918 (sub_char_table_ref_and_range): Likewise.
919 (char_table_ref_and_range): Uncompress the compressed values.
920 (sub_char_table_set): New arg is_uniprop. Callers changed.
921 Uncompress the compressed values.
922 (sub_char_table_set_range): Args changed. Callers changed.
923 (char_table_set_range): Adjuted for the above change.
924 (map_sub_char_table): Delete args default_val and parent. Add arg
925 top. Give decoded values to a Lisp function.
926 (map_char_table): Adjusted for the above change. Give decoded
927 values to a Lisp function. Gcpro more variables.
928 (uniprop_table_uncompress)
929 (uniprop_decode_value_run_length): New functions.
930 (uniprop_decoder, uniprop_decoder_count): New variables.
931 (uniprop_get_decoder, uniprop_encode_value_character)
932 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
934 (uniprop_encoder, uniprop_encoder_count): New variables.
935 (uniprop_get_encoder, uniprop_table)
936 (Funicode_property_table_internal, Fget_unicode_property_internal)
937 (Fput_unicode_property_internal): New functions.
938 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
939 Sunicode_property_table_internal, Sget_unicode_property_internal,
940 and Sput_unicode_property_internal. Defvar_lisp
941 char-code-property-alist.
943 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
944 Vunicode_category_table.
946 * font.c (font_range): Adjusted for the change of
947 Vunicode_category_table.
949 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
951 * m/iris4d.h: Remove file, move contents ...
952 * s/irix6-5.h: ... here.
954 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
956 Remove unportable assumption about struct layout (Bug#8884).
957 * alloc.c (mark_buffer):
958 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
959 (clone_per_buffer_values): Don't assume that
960 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
961 This isn't true in general, and it's particularly not true
962 if Emacs is configured with --with-wide-int.
963 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
964 New macros, used in the buffer.c change.
966 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
968 * xsettings.c: Use both GConf and GSettings if both are available.
969 (store_config_changed_event): Add comment.
970 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
971 (store_tool_bar_style_changed): New functions.
972 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
973 (struct xsettings): Move font inside HAVE_XFT.
974 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
975 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
976 Move inside HAVE_XFT.
977 (something_changed_gsettingsCB): Renamed from something_changedCB.
978 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
980 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
981 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
982 (something_changed_gconfCB): Renamed from something_changedCB.
983 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
984 (parse_settings): Move check for font inside HAVE_XFT.
985 (read_settings, apply_xft_settings): Add comment.
986 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
987 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
988 call store_font_name_changed.
989 (xft_settings_event): Add comment.
990 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
991 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
992 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
993 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
994 (xsettings_initialize): Call init_gsettings last.
995 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
998 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1000 Random fixes. E.g., (random) never returned negative values.
1001 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1002 subseconds part to the entropy, as that's a bit more random.
1003 Prefer signed to unsigned, since the signedness doesn't matter and
1004 in general we prefer signed. When given a limit, use a
1005 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1006 latter isn't right if USE_2_TAGS_FOR_INTS.
1007 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1008 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1010 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1012 * textprop.c (text_property_stickiness):
1013 Obey Vtext_property_default_nonsticky.
1014 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1015 * w32fns.c (syms_of_w32fns):
1016 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1018 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1020 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1021 This is more efficient than Ffile_directory_p and avoids a minor race.
1023 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1025 * buffer.c (Foverlay_put): Say what the return value is
1028 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1029 is a directory before asking whether to use the file name
1031 (barf_or_query_if_file_exists): Make the "File is a directory"
1032 error be more correct.
1034 * fns.c (Frequire): Remove the mention of the .gz files, since
1035 that's installation-specific, but keep the mention of
1036 `get-load-suffixes'.
1038 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1040 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1041 Report string overflow if the output is too long.
1043 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1045 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1046 (syms_of_gnutls): Remove duplicate DEFSYM for
1047 Qgnutls_bootprop_verify_hostname_error, an error for
1048 Qgnutls_bootprop_verify_error (which is no longer used).
1050 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1051 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1052 Also (re)move comments that are misplaced or no longer relevant.
1054 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1056 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1058 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1060 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1061 and background color parameters if they have been changed.
1063 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1065 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1067 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1069 * xsettings.c (SYSTEM_FONT): Define only when used.
1070 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1072 * keymap.c (access_keymap_1): Now static.
1074 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1076 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1077 leave any prefix arg for the up event (Bug#1586).
1079 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1081 * lread.c (syms_of_lread): Mention single symbols defined by
1082 `defvar' or `defconst' (bug#7154).
1084 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1085 (Frequire): Mention get-load-suffixes.
1087 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1089 * window.h (window): Remove clone_number slot.
1090 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1092 (make_parent_window, make_window, saved_window)
1093 (Fset_window_configuration, save_window_save): Don't deal with
1095 * buffer.c (Qclone_number): Remove declaration.
1096 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1098 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1100 Add multiple inheritance to keymaps.
1101 * keymap.c (Fmake_composed_keymap): New function.
1102 (Fset_keymap_parent): Simplify.
1103 (fix_submap_inheritance): Remove.
1104 (access_keymap_1): New function extracted from access_keymap to handle
1105 embedded parents and handle lists of maps.
1106 (access_keymap): Use it.
1107 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1108 (Fcopy_keymap): Handle embedded parents.
1109 (Fcommand_remapping, define_as_prefix): Simplify.
1110 (Fkey_binding): Simplify.
1111 (syms_of_keymap): Move minibuffer-local-completion-map,
1112 minibuffer-local-filename-completion-map,
1113 minibuffer-local-must-match-map, and
1114 minibuffer-local-filename-must-match-map to Elisp.
1115 (syms_of_keymap): Defsubr make-composed-keymap.
1116 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1117 (parse_menu_item): Trivial simplification.
1119 2011-07-01 Glenn Morris <rgm@gnu.org>
1121 * Makefile.in (SETTINGS_LIBS): Fix typo.
1123 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1125 * coding.c (Fencode_coding_string): Record the last coding system
1126 used, as the function doc string says (bug#8738).
1128 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1130 * xsettings.c (store_monospaced_changed): Take new font as arg and
1131 check for change against current_mono_font.
1132 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1133 (emacs_settings_constructor, emacs_settings_get_property)
1134 (emacs_settings_set_property, emacs_settings_class_init)
1135 (emacs_settings_init, gsettings_obj): Remove.
1136 (something_changedCB): New function for HAVE_GSETTINGS.
1137 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1138 with value as argument.
1139 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1140 g_settings_new (Bug#8967). Do not create gsettings_obj.
1141 Remove calls to g_settings_bind. Connect something_changedCB to
1144 * xgselect.c: Add defined (HAVE_GSETTINGS).
1145 (xgselect_initialize): Ditto.
1147 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1148 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1151 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1153 * eval.c (struct backtrace): Simplify and port the data structure.
1154 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1155 signed bit field, as this assumption is not portable and it makes
1156 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1157 "char debug_on_exit : 1" as this is not portable either; instead,
1158 use the portable "unsigned int debug_on_exit : 1". Remove unused
1159 member evalargs. Remove obsolete comments about cc bombing out.
1161 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1163 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1164 Let HAVE_GSETTINGS override HAVE_GCONF.
1165 (store_monospaced_changed): New function.
1166 (EMACS_SETTINGS): A new type derived from GObject to handle
1167 GSettings notifications.
1168 (emacs_settings_constructor, emacs_settings_get_property)
1169 (emacs_settings_set_property, emacs_settings_class_init):
1171 (gsettings_client, gsettings_obj): New variables.
1172 (GSETTINGS_SCHEMA): New define.
1173 (something_changedCB): Call store_monospaced_changed.
1174 (init_gsettings): New function.
1175 (xsettings_initialize): Call init_gsettings.
1176 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1179 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1182 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1184 * window.c (resize_root_window, grow_mini_window)
1185 (shrink_mini_window): Rename Qresize_root_window to
1186 Qwindow_resize_root_window and Qresize_root_window_vertically to
1187 Qwindow_resize_root_window_vertically.
1189 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1191 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1193 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1195 * makefile.w32-in: Redesign dependencies so they reflect more
1196 clearly which files are directly included by each source file,
1197 and not through other includes.
1199 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1201 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1202 (sort_overlays, overlay_strings): When an overlay's clone number
1203 matches the window's clone number process the overlay even if
1204 the overlay's window property doesn't match the current window.
1206 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1207 (Fwindow_hchild): Rename to Fwindow_left_child.
1208 (Fwindow_next): Rename to Fwindow_next_sibling.
1209 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1210 (resize_window_check): Rename to window_resize_check.
1211 (resize_window_apply): Rename to window_resize_apply.
1212 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1213 (Fdelete_other_windows_internal, resize_frame_windows)
1214 (Fsplit_window_internal, Fdelete_window_internal)
1215 (grow_mini_window, shrink_mini_window)
1216 (Fresize_mini_window_internal): Fix callers accordingly.
1218 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1220 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1221 (emacs_fixed_set_min_size): Remove.
1222 (emacs_fixed_new): Take frame as argument.
1224 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1225 (_EmacsFixedPrivate): Remove minwidth/height.
1226 Add struct frame *f.
1227 (emacs_fixed_init): Initialize priv->f.
1228 (get_parent_class, emacs_fixed_set_min_size): Remove.
1229 (emacs_fixed_new): Set priv->f to argument.
1230 (emacs_fixed_get_preferred_width)
1231 (emacs_fixed_get_preferred_height): Use min_width/height from
1232 frames size_hint to set minimum and natural (Bug#8919).
1233 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1234 and use min_width/height from frames size_hint to set
1235 min_width/height (Bug#8919).
1237 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1238 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1241 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1243 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1244 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1247 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1249 * process.c (wait_reading_process_output): Bypass select if
1250 waiting for a cell while ignoring keyboard input, and input is
1251 pending. Suggested by Jan Djärv (Bug#8869).
1253 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1255 Use gnulib's dup2 module instead of rolling our own.
1256 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1258 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1260 * dispnew.c (scrolling_window): Before scrolling, turn off a
1261 mouse-highlight in the window being scrolled.
1263 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1265 Move DEFSYM to lisp.h and use everywhere.
1267 * character.h (DEFSYM): Move declaration...
1268 * lisp.h (DEFSYM): ...here.
1274 * w32select.c: Don't include character.h.
1276 * alloc.c (syms_of_alloc):
1277 * buffer.c (syms_of_buffer):
1278 * bytecode.c (syms_of_bytecode):
1279 * callint.c (syms_of_callint):
1280 * casefiddle.c (syms_of_casefiddle):
1281 * casetab.c (init_casetab_once):
1282 * category.c (init_category_once, syms_of_category):
1283 * ccl.c (syms_of_ccl):
1284 * cmds.c (syms_of_cmds):
1285 * composite.c (syms_of_composite):
1286 * dbusbind.c (syms_of_dbusbind):
1287 * dired.c (syms_of_dired):
1288 * dispnew.c (syms_of_display):
1289 * doc.c (syms_of_doc):
1290 * editfns.c (syms_of_editfns):
1291 * emacs.c (syms_of_emacs):
1292 * eval.c (syms_of_eval):
1293 * fileio.c (syms_of_fileio):
1294 * fns.c (syms_of_fns):
1295 * frame.c (syms_of_frame):
1296 * fringe.c (syms_of_fringe):
1297 * insdel.c (syms_of_insdel):
1298 * keymap.c (syms_of_keymap):
1299 * lread.c (init_obarray, syms_of_lread):
1300 * macros.c (syms_of_macros):
1301 * msdos.c (syms_of_msdos):
1302 * print.c (syms_of_print):
1303 * process.c (syms_of_process):
1304 * search.c (syms_of_search):
1305 * sound.c (syms_of_sound):
1306 * syntax.c (init_syntax_once, syms_of_syntax):
1307 * terminal.c (syms_of_terminal):
1308 * textprop.c (syms_of_textprop):
1309 * undo.c (syms_of_undo):
1310 * w32.c (globals_of_w32):
1311 * window.c (syms_of_window):
1312 * xdisp.c (syms_of_xdisp):
1313 * xfaces.c (syms_of_xfaces):
1314 * xfns.c (syms_of_xfns):
1315 * xmenu.c (syms_of_xmenu):
1316 * xsettings.c (syms_of_xsettings):
1317 * xterm.c (syms_of_xterm): Use DEFSYM.
1319 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1321 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1323 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1325 Integer and buffer overflow fixes (Bug#8873).
1327 * print.c (printchar, strout): Check for string overflow.
1328 (PRINTPREPARE, printchar, strout):
1329 Don't set size unless allocation succeeds.
1331 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1332 for sizes. Check for string overflow more accurately.
1333 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1335 * macros.c: Integer and buffer overflow fixes.
1336 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1337 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1338 Use ptrdiff_t, not int, for sizes.
1339 Don't increment bufsize until after realloc succeeds.
1340 Check for size-calculation overflow.
1341 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1343 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1345 * lread.c: Integer overflow fixes.
1346 (read_integer): Radix is now EMACS_INT, not int,
1347 to improve quality of diagnostics for out-of-range radices.
1348 Calculate buffer size correctly for out-of-range radices.
1349 (read1): Check for integer overflow in radices, and in
1350 read-circle numbers.
1351 (read_escape): Avoid int overflow.
1352 (Fload, openp, read_buffer_size, read1)
1353 (substitute_object_recurse, read_vector, read_list, map_obarray):
1354 Use ptrdiff_t, not int, for sizes.
1355 (read1): Use EMACS_INT, not int, for sizes.
1356 Check for size overflow.
1358 * image.c (cache_image): Check for size arithmetic overflow.
1360 * lread.c: Integer overflow issues.
1361 (saved_doc_string_size, saved_doc_string_length)
1362 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1363 Now ptrdiff_t, not int.
1364 (read1): Don't assume doc string length fits in int. Check for
1365 out-of-range doc string lengths.
1366 (read_list): Don't assume file position fits in int.
1367 (read_escape): Check for hex character overflow.
1369 2011-06-22 Leo Liu <sdl.web@gmail.com>
1371 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1372 Move to minibuffer.el.
1374 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1376 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1377 The following patches are for when GLYPH_DEBUG && !XASSERT.
1378 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1379 * dispnew.c (flush_stdout):
1380 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1381 Mark as externally visible.
1382 * dispnew.c (check_window_matrix_pointers): Now static.
1383 * dispnew.c (window_to_frame_vpos):
1384 * xfns.c (unwind_create_frame):
1385 * xterm.c (x_check_font): Remove unused local.
1386 * scroll.c (CHECK_BOUNDS):
1387 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1388 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1389 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1390 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1391 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1393 (debug_method_add): Use va_list and vsprintf rather than relying
1394 on undefined behavior with wrong number of arguments.
1395 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1396 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1397 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1398 since we're not interested in debugging glyphs with old libraries.
1399 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1400 GCC 4.6.0's static checking.
1402 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1404 Integer overflow and signedness fixes (Bug#8873).
1405 A few related buffer overrun fixes, too.
1407 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1409 * dispextern.h (struct face.stipple):
1410 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1411 (x_bitmap_mask, x_allocate_bitmap_record)
1412 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1413 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1414 (x_create_bitmap_from_xpm_data):
1415 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1416 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1418 * xfaces.c (load_pixmap):
1419 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1420 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1421 (.bitmaps_last, struct x_output.icon_bitmap):
1422 Use ptrdiff_t, not int, for bitmap indexes.
1423 (x_allocate_bitmap_record): Check for size overflow.
1424 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1426 Use ptrdiff_t, not int, for overlay counts.
1427 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1428 * editfns.c (overlays_around, get_pos_property):
1429 * textprop.c (get_char_property_and_overlay):
1430 * xdisp.c (next_overlay_change, note_mouse_highlight):
1431 * xfaces.c (face_at_buffer_position):
1432 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1433 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1434 (Fnext_overlay_change, Fprevious_overlay_change)
1435 (mouse_face_overlay_overlaps, Foverlays_in):
1436 Use ptrdiff_t, not int, for sizes.
1437 (overlays_at, overlays_in): Check for size-calculation overflow.
1439 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1441 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1442 (x_session_initialize): Do not assume string length fits in int.
1444 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1445 This is unlikely, but can occur if DPI is outlandish.
1447 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1448 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1450 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1451 * xrdb.c (magic_file_p, search_magic_path):
1452 Omit last arg SUFFIX; it was always 0. All callers changed.
1453 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1455 * xfont.c (xfont_match): Avoid need for strlen.
1457 * xfns.c: Don't assume strlen fits in int.
1458 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1460 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1461 not unsigned long, as we prefer signed integers. All callers changed.
1462 Detect integer overflow in repeat count.
1463 (message_dolog): Don't assume print length fits in 39 bytes.
1464 (display_mode_element): Don't assume strlen fits in int.
1466 * termcap.c: Don't assume sizes fit in int and never overflow.
1467 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1468 (gobble_line): Check for size-calculation overflow.
1470 * minibuf.c (Fread_buffer):
1471 * lread.c (intern, intern_c_string):
1472 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1473 Don't assume string length fits in int.
1475 * keyboard.c (parse_tool_bar_item):
1476 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1478 * font.c: Don't assume string length fits in int.
1479 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1480 Use ptrdiff_t, not int.
1481 (font_intern_prop): Don't assume string length fits in int.
1482 Don't assume integer property fits in fixnum.
1483 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1485 * filelock.c: Fix some buffer overrun and integer overflow issues.
1486 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1487 Reformulate so as not to need the command string.
1488 Invoke gzip -cd rather than gunzip, as it's more portable.
1489 (lock_info_type, lock_file_1, lock_file):
1490 Don't assume pid_t and time_t fit in unsigned long.
1491 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1492 (current_lock_owner): Prefer signed type for sizes.
1493 Use memcpy, not strncpy, where memcpy is what is really wanted.
1494 Don't assume (via atoi) that time_t and pid_t fit in int.
1495 Check for time_t and/or pid_t out of range, e.g., via a network share.
1496 Don't alloca where an auto var works fine.
1498 * fileio.c: Fix some integer overflow issues.
1499 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1500 Don't assume string length fits in int.
1501 (directory_file_name): Don't assume string length fits in long.
1502 (make_temp_name): Don't assume pid fits in int, or that its print
1503 length is less than 20.
1505 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1507 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1509 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1511 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1512 We prefer signed integers, even for size calculations.
1514 * emacs.c: Don't assume string length fits in 'int'.
1515 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1516 (main): Don't invoke strlen when not needed.
1518 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1519 (XD_DEBUG_MESSAGE): Don't waste a byte.
1521 * callproc.c (getenv_internal_1, getenv_internal)
1523 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1525 * lread.c (invalid_syntax): Omit length argument.
1526 All uses changed. This doesn't fix a bug, but it simplifies the
1527 code away from its former Hollerith-constant appearance, and it's
1528 one less 'int' to worry about when looking at integer-overflow issues.
1529 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1531 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1532 This didn't break anything, but it didn't help either.
1533 It's confusing to put a bogus integer in a place where the actual
1534 value does not matter.
1535 (LIST_END_P): Remove unused macro and its bogus comment.
1536 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1538 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1539 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1541 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1542 We prefer signed types, and the value cannot exceed the EMACS_INT
1543 range anyway (because otherwise the length would not be representable).
1544 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1545 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1546 This avoids a GCC warning when WIDE_EMACS_INT.
1548 * indent.c (sane_tab_width): New function.
1549 (current_column, scan_for_column, Findent_to, position_indentation)
1550 (compute_motion): Use it. This is just for clarity.
1551 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1553 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1555 * lisp.h (lint_assume): New macro.
1556 * composite.c (composition_gstring_put_cache):
1557 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1559 * editfns.c, insdel.c:
1560 Omit unnecessary forward decls, to simplify future changes.
1562 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1564 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1566 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1567 Use much-faster test for byte-length change.
1568 Don't assume string byte-length fits in 'int'.
1569 Check that character arg fits in 'int'.
1570 (mapcar1): Declare byte as byte, for clarity.
1572 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1574 * fns.c (concat): Catch string overflow earlier.
1575 Do not rely on integer wraparound.
1577 * dispextern.h (struct it.overlay_strings_charpos)
1578 (struct it.selective): Now EMACS_INT, not int.
1579 * xdisp.c (forward_to_next_line_start)
1580 (back_to_previous_visible_line_start)
1581 (reseat_at_next_visible_line_start, next_element_from_buffer):
1582 Don't arbitrarily truncate the value of 'selective' to int.
1584 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1586 * composite.c: Don't truncate sizes to 'int'.
1587 (composition_gstring_p, composition_reseat_it)
1588 (composition_adjust_point): Use EMACS_INT, not int.
1589 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1590 not EMACS_UINT, for indexes.
1592 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1594 * buffer.c: Include <verify.h>.
1595 (struct sortvec.priority, struct sortstr.priority):
1596 Now EMACS_INT, not int.
1597 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1598 (struct sortstr.size, record_overlay_string)
1599 (struct sortstrlist.size, struct sortlist.used):
1600 Don't truncate size to int.
1601 (record_overlay_string): Check for size-calculation overflow.
1602 (init_buffer_once): Check at compile-time, not run-time.
1604 2011-06-22 Jim Meyering <meyering@redhat.com>
1606 Don't leak an XBM-image-sized buffer
1607 * image.c (xbm_load): Free the image buffer after using it.
1609 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1612 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1613 that Sun C diagnosed.
1614 * fns.c (secure_hash): Fix pointer signedness issue.
1615 * intervals.c (static_offset_intervals): New function.
1616 (offset_intervals): Use it.
1618 2011-06-21 Leo Liu <sdl.web@gmail.com>
1621 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1624 * fns.c (secure_hash): Rename from crypto_hash_function and change
1625 the first arg to accept symbols.
1626 (Fsecure_hash): New primitive.
1627 (syms_of_fns): New symbols.
1629 2011-06-20 Deniz Dogan <deniz@dogan.se>
1631 * process.c (Fset_process_buffer): Clarify return value in
1634 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1636 * dispnew.c (add_window_display_history): Use BVAR.
1638 * xdisp.c (debug_method_add): Use BVAR.
1639 (check_window_end, dump_glyph_matrix, dump_glyph)
1640 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1642 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1645 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1646 check till after the cache is created in init_frame_faces.
1648 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1650 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1652 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1654 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1655 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1656 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1658 Improve buffer-overflow checking (Bug#8873).
1659 * fileio.c (Finsert_file_contents):
1660 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1661 Remove the old (too-loose) buffer overflow checks.
1662 They weren't needed, since make_gap checks for buffer overflow.
1663 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1664 The old code merely checked for Emacs fixnum overflow, and relied
1665 on undefined (wraparound) behavior. The new code avoids undefined
1666 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1668 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1669 Tune. Don't use wider integers than needed. Don't use alloca.
1670 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1672 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1674 * insdel.c, lisp.h (buffer_overflow): New function.
1675 (insert_from_buffer_1, replace_range, replace_range_2):
1676 * insdel.c (make_gap_larger):
1677 * editfns.c (Finsert_char):
1678 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1680 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1682 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1684 Integer overflow and signedness fixes (Bug#8873).
1686 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1687 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1689 * fileio.c: Don't assume EMACS_INT fits in off_t.
1690 (emacs_lseek): New static function.
1691 (Finsert_file_contents, Fwrite_region): Use it.
1692 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1694 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1696 * fns.c: Don't overflow int when computing a list length.
1697 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1698 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1699 truncation on 64-bit hosts. Check for QUIT every
1700 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1701 faster and is responsive enough.
1702 (Flength): Report an error instead of overflowing an integer.
1703 (Fsafe_length): Return a float if the value is not representable
1704 as a fixnum. This shouldn't happen except in contrived situations.
1705 (Fnthcdr, Fsort): Don't assume list length fits in int.
1706 (Fcopy_sequence): Don't assume vector length fits in int.
1708 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1709 (header_size, word_size): New constants.
1710 (allocate_vectorlike): Don't check size overflow here.
1711 (allocate_vector): Check it here instead, since this is the only
1712 caller of allocate_vectorlike that could cause overflow.
1713 Check that the new vector's length is representable as a fixnum.
1715 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1716 The previous code was bogus. For example, next_almost_prime (32)
1717 returned 39, which is undesirable as it is a multiple of 3; and
1718 next_almost_prime (24) returned 25, which is a multiple of 5 so
1719 why was the code bothering to check for multiples of 7?
1721 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1723 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1725 Variadic C functions now count arguments with ptrdiff_t.
1726 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1727 Back then I didn't know that the Emacs coding style prefers signed int.
1728 Also, in the meantime I found a few more instances where arguments
1729 were being counted with int, which may truncate counts on 64-bit
1730 machines, or EMACS_INT, which may be unnecessarily wide.
1731 * lisp.h (struct Lisp_Subr.function.aMANY)
1732 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1733 Arg counts are now ptrdiff_t, not size_t.
1734 All variadic functions and their callers changed accordingly.
1735 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1736 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1737 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1738 * callint.c (Fcall_interactively): Check arg count for overflow,
1739 to avoid potential buffer overrun. Use signed char, not 'int',
1740 for 'varies' array, so that we needn't bother to check its size
1741 calculation for overflow.
1742 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1743 * eval.c (apply_lambda):
1744 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1745 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1746 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1748 * callint.c (Fcall_interactively): Don't use index var as event count.
1750 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1751 * mem-limits.h (SIZE): Remove; no longer used.
1753 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1755 Remove unnecessary casts.
1756 * xterm.c (x_term_init):
1757 * xfns.c (x_set_border_pixel):
1758 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1759 These aren't needed now that we assume ANSI C.
1761 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1762 It's more likely to cause problems (due to unsigned overflow)
1765 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1767 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1769 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1771 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1773 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1775 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1777 GLYPH_CODE_FACE returns EMACS_INT, not int.
1778 * dispextern.h (merge_faces):
1779 * xfaces.c (merge_faces):
1780 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1781 Don't assume EMACS_INT fits in int.
1783 * character.h (CHAR_VALID_P): Remove unused parameter.
1784 * fontset.c, lisp.h, xdisp.c: All uses changed.
1786 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1788 * fns.c (concat): Minor tuning based on overflow analysis.
1789 This doesn't fix any bugs. Use int to hold character, instead
1790 of constantly refetching from Emacs object. Use XFASTINT, not
1791 XINT, for value known to be a character. Don't bother comparing
1792 a single byte to 0400, as it's always less.
1794 * floatfns.c (Fexpt):
1795 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1797 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1800 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1802 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1803 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1804 incorrectly succeed when S was a string, because 4294967386 was
1805 truncated before it was used.
1807 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1808 Otherwise, an out-of-range integer could cause undefined behavior
1811 * composite.c: Use int, not EMACS_INT, for characters.
1812 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1813 EMACS_INT, for values that are known to be in character range.
1814 This doesn't fix any bugs but is the usual style inside Emacs and
1815 may generate better code on 32-bit machines.
1817 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1818 This is for reasons similar to the recent CHAR_STRING fix.
1819 * charset.c (Fencode_char): Check that character arg is actually
1820 a character. Pass an int to ENCODE_CHAR.
1821 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1822 wider than 'int', as a compile-time check to prevent future regressions
1825 * character.c (char_string): Remove unnecessary casts.
1827 Make sure a 64-bit char is never passed to CHAR_STRING.
1828 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1829 by silently ignoring the top 32 bits, allowing some values
1830 that were far too large to be valid characters.
1831 * character.h: Include <verify.h>.
1832 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1833 arguments are no wider than unsigned, as a compile-time check
1834 to prevent future regressions in this area.
1836 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1837 (Fsubst_char_in_region):
1839 * xdisp.c (decode_mode_spec_coding):
1840 Adjust to CHAR_STRING's new requirement.
1841 * editfns.c (Finsert_char, Fsubst_char_in_region):
1842 * fns.c (concat): Check that character args are actually
1843 characters. Without this test, these functions did the wrong
1844 thing with wildly out-of-range values on 64-bit hosts.
1846 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1847 These casts should not be needed on 32-bit hosts, either.
1848 * keyboard.c (read_char):
1849 * lread.c (Fload): Remove casts to unsigned.
1851 * lisp.h (UNSIGNED_CMP): New macro.
1852 This fixes comparison bugs on 64-bit hosts.
1853 (ASCII_CHAR_P): Use it.
1854 * casefiddle.c (casify_object):
1855 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1856 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1857 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1858 * dispextern.h (FACE_FROM_ID):
1859 * keyboard.c (read_char): Use UNSIGNED_CMP.
1861 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1862 not to EMACS_INT, to avoid GCC warning.
1864 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1866 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1867 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1868 isn't needed on 32-bit machines.
1870 * buffer.c (Fgenerate_new_buffer_name):
1871 Use EMACS_INT for count, not int.
1872 (advance_to_char_boundary): Return EMACS_INT, not int.
1874 * data.c (Qcompiled_function): Now static.
1876 * window.c (window_body_lines): Now static.
1878 * image.c (gif_load): Rename local to avoid shadowing.
1880 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1881 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1882 * alloc.c (make_save_value): Integer argument is now of type
1884 (mark_object): Use ptrdiff_t, not int.
1885 * lisp.h (pD): New macro.
1886 * print.c (print_object): Use it.
1888 * alloc.c: Use EMACS_INT, not int, to count objects.
1889 (total_conses, total_markers, total_symbols, total_vector_size)
1890 (total_free_conses, total_free_markers, total_free_symbols)
1891 (total_free_floats, total_floats, total_free_intervals)
1892 (total_intervals, total_strings, total_free_strings):
1893 Now EMACS_INT, not int. All uses changed.
1894 (Fgarbage_collect): Compute overall total using a double, so that
1895 integer overflow is less likely to be a problem. Check for overflow
1896 when converting back to an integer.
1897 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1898 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1899 These were 'int' variables that could overflow on 64-bit hosts;
1900 they were never used, so remove them instead of repairing them.
1901 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1902 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1903 Previously, this ceilinged at INT_MAX, but that doesn't work on
1905 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1907 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1908 (allocate_vectorlike): Check for ptrdiff_t overflow.
1909 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1910 when a (possibly-narrower) signed value would do just as well.
1911 We prefer using signed arithmetic, to avoid comparison confusion.
1913 * alloc.c: Catch some string size overflows that we were missing.
1914 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1915 for convenience in STRING_BYTES_MAX.
1916 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1917 The definition here is exact; the one in lisp.h was approximate.
1918 (allocate_string_data): Check for string overflow. This catches
1919 some instances we weren't catching before. Also, it catches
1920 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1921 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1922 and ptrdiff_t and EMACS_INT are both 64 bits.
1924 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1925 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1926 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1928 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1930 * alloc.c (Fmake_string): Check for out-of-range init.
1932 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1934 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1936 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1938 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1939 xg_get_default_scrollbar_width.
1941 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1942 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1943 (style_changed_cb): Call update_theme_scrollbar_width and call
1944 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1945 all frames (Bug#8505).
1946 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1947 Call gtk_window_set_resizable if HAVE_GTK3.
1948 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1949 and height if HAVE_GTK3 (Bug#8505).
1950 (scroll_bar_width_for_theme): New variable.
1951 (update_theme_scrollbar_width): New function.
1952 (xg_get_default_scrollbar_width): Move code to
1953 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1954 (xg_initialize): Call update_theme_scrollbar_width.
1956 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1958 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1960 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1962 * frame.c (make_frame): Call other_buffer_safely instead of
1965 * window.c (temp_output_buffer_show): Call display_buffer with
1966 second argument Vtemp_buffer_show_specifiers and reset latter
1967 immediately after the call.
1968 (Vtemp_buffer_show_specifiers): New variable.
1969 (auto_window_vscroll_p, next_screen_context_lines)
1970 (Vscroll_preserve_screen_position): Remove leading asterisks from
1973 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1975 Fix minor problems found by GCC 4.6.0 static checking.
1976 * buffer.c (Qclone_number): Remove for now, as it's unused.
1977 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1978 (record_buffer): Remove unused local.
1979 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1980 (set_frame_buffer_list): Remove; unused.
1981 * frame.h (other_visible_frames): Remove decl.
1982 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1983 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1984 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1986 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1987 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1988 Define only if HAVE_GPM.
1989 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1990 (update_hints_inhibit): Remove; never set. All uses removed.
1991 * widgetprv.h (emacsFrameClassRec): Remove decl.
1992 * window.c (delete_deletable_window): Now returns void, since it
1993 wasn't returning anything.
1994 (compare_window_configurations): Remove unused locals.
1995 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1996 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1997 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1998 the same widths as pointers. This follows up on the 2011-05-06 patch.
1999 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2000 * xterm.h: Likewise.
2001 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2003 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2005 * makefile.w32-in: Update dependencies.
2006 (LISP_H): Add lib/intprops.h.
2008 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2010 * image.c (gif_load): Add animation frame delay to the metadata.
2011 (syms_of_image): Use DEFSYM. New symbol `delay'.
2013 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2015 * window.c (delete_deletable_window): Re-add.
2016 (Fset_window_configuration): Rewrite to handle dead buffers and
2017 consequently deletable windows.
2018 (window_tree, Fwindow_tree): Remove. Supply functionality in
2020 (compare_window_configurations): Simplify code.
2022 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2024 * image.c (imagemagick_load_image): Fix type mismatch.
2025 (Fimagemagick_types): Likewise.
2027 * window.h (replace_buffer_in_windows): Declare.
2029 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2031 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2032 Qclone_number. Remove external declaration of Qdelete_window.
2033 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2035 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2036 Qbuffer_list_update_hook if allowed.
2037 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2038 buffer list implementation.
2039 (other_buffer_safely): New function.
2040 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2041 calls to replace_buffer_in_windows and
2042 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2044 (record_buffer): Inhibit quitting and rewrite using quittable
2045 functions. Run Qbuffer_list_update_hook if allowed.
2046 (Frecord_buffer, Funrecord_buffer): New functions.
2047 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2048 switch-to-buffer to window.el.
2049 (bury-buffer): Move to window.el.
2050 (Vbuffer_list_update_hook): New variable.
2052 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2055 * window.h (resize_frame_windows): Move up in code.
2056 (Fwindow_frame): Remove EXFUN.
2057 (replace_buffer_in_all_windows): Remove prototype.
2058 (replace_buffer_in_windows_safely): Add prototype.
2060 * window.c: Declare Qdelete_window static again. Move down
2061 declaration of select_count.
2062 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2063 (Fother_window): Move to window.el.
2064 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2065 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2066 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2068 (replace_buffer_in_windows): Implement by calling
2069 Qreplace_buffer_in_windows.
2070 (replace_buffer_in_all_windows): Remove with some functionality
2071 moved into replace_buffer_in_windows_safely.
2072 (replace_buffer_in_windows_safely): New function.
2073 (select_window_norecord, select_frame_norecord): Move in front
2074 of run_window_configuration_change_hook. Remove now obsolete
2076 (Fset_window_buffer): Rewrite doc-string. Call
2077 Qrecord_window_buffer.
2078 (keys_of_window): Move binding for other-window to window.el.
2080 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2082 * dispextern.h (struct image): Replace data member, whose int_val
2083 and ptr_val fields were not used by anything, with a single
2086 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2087 (gif_clear_image, gif_load, imagemagick_load_image)
2088 (gs_clear_image, gs_load): Callers changed.
2090 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2092 * buffer.h: Include <time.h>, for time_t.
2093 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2095 Fix minor problems found by static checking.
2097 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2099 Make identifiers static if they are not used in other modules.
2100 * data.c (Qcompiled_function, Qframe, Qvector):
2101 * image.c (QimageMagick, Qsvg):
2102 * minibuf.c (Qmetadata):
2103 * window.c (resize_window_check, resize_root_window): Now static.
2104 * window.h (resize_window_check, resize_root_window): Remove decls.
2106 * window.c (window_deletion_count, delete_deletable_window):
2108 (window_body_lines): Now static.
2109 (Fdelete_other_windows_internal): Mark vars as initialized.
2110 Make sure 'resize_failed' is initialized.
2111 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2112 (resize_window_apply): Remove unused local.
2113 * window.h (delete_deletable_window): Remove decl.
2115 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2116 (imagemagick_load_image): Fix pointer signedness problem by changing
2117 last arg from unsigned char * to char *. All uses changed.
2118 Also, fix a local for similar reasons.
2119 Remove unused locals. Remove locals to avoid shadowing.
2120 (fn_rsvg_handle_free): Remove; unused.
2121 (svg_load, svg_load_image): Fix pointer signedness problem.
2122 (imagemagick_load_image): Don't use garbage pointer image_wand.
2124 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2126 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2128 * image.c (gif_load): Fix omitted cast error introduced by
2131 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2133 * window.h (resize_proportionally, orig_total_lines)
2134 (orig_top_line): Remove from window structure.
2135 (set_window_height, set_window_width, change_window_heights)
2136 (Fdelete_window): Remove prototypes.
2137 (resize_frame_windows): Remove duplicate declaration.
2139 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2141 * window.h (resize_frame_windows, resize_window_check)
2142 (delete_deletable_window, resize_root_window)
2143 (resize_frame_windows): Declare prototypes.
2145 * window.c (resize_window_apply): Make definition be "static" to
2146 match the prototype.
2148 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2150 * window.c: Remove declarations of Qwindow_size_fixed,
2151 window_min_size_1, window_min_size_2, window_min_size,
2152 size_window, window_fixed_size_p, enlarge_window, delete_window.
2153 Remove static from declaration of Qdelete_window, it's
2154 temporarily needed by Fbury_buffer.
2155 (replace_window): Don't assign orig_top_line and
2157 (Fdelete_window, delete_window): Remove. Window deletion is
2158 handled by window.el.
2159 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2160 Fdelete_window calls with calls to Qdelete_window.
2161 (Fdelete_other_windows): Remove. Deleting other windows is
2162 handled by window.el.
2163 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2164 handled in window.el.
2165 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2166 Window minimum sizes are handled in window.el.
2167 (shrink_windows, size_window, set_window_height)
2168 (set_window_width, change_window_heights, window_height)
2169 (window_width, CURBEG, CURSIZE, enlarge_window)
2170 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2171 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2172 handled in window.el.
2173 (make_dummy_parent): Rename to make_parent_window and give it a
2174 second argument horflag.
2175 (make_window): Don't set resize_proportionally any more.
2176 (Fsplit_window): Remove. Windows are split in window.el.
2177 (save_restore_action, save_restore_orig_size)
2178 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2179 Resize mini windows in window.el.
2180 (grow_mini_window, shrink_mini_window): Implement by calling
2181 Qresize_root_window_vertically, resize_window_check and
2182 resize_window_apply.
2183 (saved_window, Fset_window_configuration, save_window_save): Do
2184 not handle orig_top_line, orig_total_lines, and
2185 resize_proportionally.
2186 (window_min_height, window_min_width): Move to window.el.
2187 (keys_of_window): Move bindings for delete-other-windows,
2188 split-window, delete-window and enlarge-window to window.el.
2190 * buffer.c: Temporarily extern Qdelete_window.
2191 (Fbury_buffer): Temporarily call Qdelete_window instead of
2192 Fdelete_window (Fbury_buffer will move to window.el soon).
2194 * frame.c (set_menu_bar_lines_1): Remove code handling
2195 orig_top_line and orig_total_lines.
2197 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2198 set_window_height but set heights directly.
2199 (change_frame_size_1): Use resize_frame_windows.
2201 * xdisp.c (init_xdisp): Don't use set_window_height but set
2204 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2205 resize_frame_windows instead of change_window_heights and run
2206 run_window_configuration_change_hook.
2208 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2209 instead of change_window_heights and run
2210 run_window_configuration_change_hook.
2212 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2214 * window.c (replace_window): Rename second argument REPLACEMENT to
2215 NEW. New third argument SETFLAG. Rewrite.
2216 (delete_window, make_dummy_parent): Call replace_window with
2218 (window_list_1): Move down in code.
2219 (run_window_configuration_change_hook): Move set_buffer part
2220 before select_frame_norecord part in order to unwind correctly.
2221 Rename count1 to count.
2222 (recombine_windows, delete_deletable_window, resize_root_window)
2223 (Fdelete_other_windows_internal)
2224 (Frun_window_configuration_change_hook, make_parent_window)
2225 (resize_window_check, resize_window_apply, Fresize_window_apply)
2226 (resize_frame_windows, Fsplit_window_internal)
2227 (Fdelete_window_internal, Fresize_mini_window_internal): New
2229 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2231 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2233 * window.h (window): Add some new members to window structure -
2234 normal_lines, normal_cols, new_total, new_normal, clone_number,
2235 splits, nest, prev_buffers, next_buffers.
2236 (WINDOW_TOTAL_SIZE): Move here from window.c.
2237 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2239 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2241 (make_dummy_parent): Set new members of windows structure.
2242 (make_window): Move down in code. Handle new members of window
2244 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2245 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2246 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2247 (Fset_window_prev_buffers, Fwindow_next_buffers)
2248 (Fset_window_next_buffers, Fset_window_clone_number): New
2250 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2251 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2253 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2254 Argument WINDOW can be now internal window too.
2255 (Fwindow_use_time): Move up in code.
2256 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2258 (Fset_window_configuration, saved_window)
2259 (Fcurrent_window_configuration, save_window_save): Handle new
2260 members of window structure.
2261 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2262 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2263 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2264 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2265 Qget_mru_window, Qresize_root_window,
2266 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2267 Qauto_buffer_name; staticpro them.
2269 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2271 * window.c (Fwindow_total_size, Fwindow_left_column)
2272 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2273 (Fwindow_list_1): New functions.
2274 (window_box_text_cols): Replace with window_body_cols.
2275 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2276 window_body_cols instead of window_box_text_cols.
2277 (delete_window, Fset_window_configuration): Call
2278 delete_all_subwindows with window as argument.
2279 (delete_all_subwindows): Take a window as argument and not a
2281 (window_loop): Remove handling of GET_LRU_WINDOW and
2283 (Fget_lru_window, Fget_largest_window): Move to window.el.
2285 * window.h: Extern window_body_cols instead of
2286 window_box_text_cols. delete_all_subwindows now takes a
2287 Lisp_Object as argument.
2289 * indent.c (compute_motion, Fcompute_motion): Use
2290 window_body_cols instead of window_box_text_cols.
2292 * frame.c (delete_frame): Call delete_all_subwindows with root
2295 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2297 * fns.c (Fputhash): Document return value.
2299 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2301 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2303 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2305 Cons<->int and similar integer overflow fixes (Bug#8794).
2307 Check for overflow when converting integer to cons and back.
2308 * charset.c (Fdefine_charset_internal, Fdecode_char):
2309 Use cons_to_unsigned to catch overflow.
2310 (Fencode_char): Use INTEGER_TO_CONS.
2311 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2312 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2313 * data.c (long_to_cons, cons_to_long): Remove.
2314 (cons_to_unsigned, cons_to_signed): New functions.
2315 These signal an error for invalid or out-of-range values.
2316 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2317 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2318 * font.c (Ffont_variation_glyphs):
2319 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2320 * lisp.h: Include <intprops.h>.
2321 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2322 (cons_to_signed, cons_to_unsigned): New decls.
2323 (long_to_cons, cons_to_long): Remove decls.
2324 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2325 (Fprimitive_undo): Use CONS_TO_INTEGER.
2326 * xfns.c (Fx_window_property): Likewise.
2327 * xselect.c: Include <limits.h>.
2328 (x_own_selection, selection_data_to_lisp_data):
2329 Use INTEGER_TO_CONS.
2330 (x_handle_selection_request, x_handle_selection_clear)
2331 (x_get_foreign_selection, Fx_disown_selection_internal)
2332 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2333 (lisp_data_to_selection_data): Use cons_to_unsigned.
2334 (x_fill_property_data): Use cons_to_signed.
2335 Report values out of range.
2337 Check for buffer and string overflow more precisely.
2338 * buffer.h (BUF_BYTES_MAX): New macro.
2339 * lisp.h (STRING_BYTES_MAX): New macro.
2340 * alloc.c (Fmake_string):
2341 * character.c (string_escape_byte8):
2342 * coding.c (coding_alloc_by_realloc):
2343 * doprnt.c (doprnt):
2344 * editfns.c (Fformat):
2346 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2347 since they may not be the same number.
2348 * editfns.c (Finsert_char):
2349 * fileio.c (Finsert_file_contents):
2350 Likewise for BUF_BYTES_MAX.
2352 * image.c: Use ptrdiff_t, not int, for sizes.
2353 (slurp_file): Switch from int to ptrdiff_t.
2355 (slurp_file): Check that file size fits in both size_t (for
2356 malloc) and ptrdiff_t (for sanity and safety).
2358 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2359 if b->modtime has its maximal value.
2361 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2363 Don't assume time_t can fit into int.
2364 * buffer.h (struct buffer.modtime): Now time_t, not int.
2365 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2366 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2368 Minor fixes for signed vs unsigned integers.
2369 * character.h (MAYBE_UNIFY_CHAR):
2370 * charset.c (maybe_unify_char):
2371 * keyboard.c (read_char, reorder_modifiers):
2372 XINT -> XFASTINT, since the integer must be nonnegative.
2373 * ftfont.c (ftfont_spec_pattern):
2374 * keymap.c (access_keymap, silly_event_symbol_error):
2375 XUINT -> XFASTINT, since the integer must be nonnegative.
2376 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2377 since it makes no difference and we prefer signed.
2378 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2379 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2382 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2384 * window.h (Fwindow_frame): Declare.
2386 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2388 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2389 (SPARE_MEMORY): Always define.
2390 (LARGE_REQUEST): Remove.
2391 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2393 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2395 * lisp.h: Move EXFUNS for Fframe_root_window,
2396 Fframe_first_window and Fset_frame_selected_window to window.h.
2398 * window.h: Move EXFUNS for Fframe_root_window,
2399 Fframe_first_window and Fset_frame_selected_window here from
2402 * frame.c (Fwindow_frame, Fframe_first_window)
2403 (Fframe_root_window, Fframe_selected_window)
2404 (Fset_frame_selected_window): Move to window.c.
2405 (Factive_minibuffer_window): Move to minibuf.c.
2406 (Fother_visible_frames_p): New function.
2408 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2410 * window.c (decode_window, decode_any_window): Move up in code.
2411 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2412 (inhibit_frame_unsplittable): Remove unused variable.
2413 (Fwindow_buffer): Move up and rewrite doc-string.
2414 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2415 (Fwindow_prev): New functions.
2416 (Fwindow_frame): Move here from frame.c. Accept any window as
2418 (Fframe_root_window, Fframe_first_window)
2419 (Fframe_selected_window): Move here from frame.c. Accept frame
2420 or arbitrary window as argument. Update doc-strings.
2421 (Fminibuffer_window): Move up in code.
2422 (Fwindow_minibuffer_p): Move up in code and simplify.
2423 (Fset_frame_selected_window): Move here from frame.c.
2425 (Fselected_window, select_window, Fselect_window): Move up in
2426 code. Minor doc-string fixes.
2428 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2430 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2431 Do not assume that spare memory exists; that assumption is valid
2432 only if SYSTEM_MALLOC.
2433 (LARGE_REQUEST): New macro, so that the issue of large requests
2434 is separated from the issue of spare memory.
2436 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2438 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2441 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2443 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2446 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2448 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2450 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2452 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2453 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2455 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2457 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2459 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2461 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2462 (x_clipboard_manager_save): Add return value.
2463 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2465 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2466 Obey Vx_select_enable_clipboard_manager. Catch errors in
2467 x_clipboard_manager_save (Bug#8779).
2468 (Vx_select_enable_clipboard_manager): New variable.
2469 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2471 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2473 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2475 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2477 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2478 in the current matrix if keep_current_p is non-zero.
2480 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2482 * bidi.c (bidi_level_of_next_char): Fix last change.
2484 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2486 Support bidi reordering of text covered by display properties.
2488 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2489 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2490 (bidi_cache_search, bidi_cache_iterator_state)
2491 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2492 (bidi_level_of_next_char, bidi_move_to_visually_next):
2493 Support character positions inside a run of characters covered by a
2495 (bidi_paragraph_init, bidi_resolve_explicit_1)
2496 (bidi_level_of_next_char): Call bidi_fetch_char and
2497 bidi_fetch_char_advance instead of FETCH_CHAR and
2499 (bidi_init_it): Initialize new members.
2500 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2502 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2503 instead of using explicit *_CHAR codes.
2504 (bidi_resolve_explicit, bidi_resolve_weak):
2505 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2506 bidirectional text is supported only in multibyte buffers.
2507 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2508 it to initialize the frame_window_p member of struct bidi_it.
2509 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2510 (bidi_resolve_explicit, bidi_resolve_weak)
2511 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2512 bidi_it->nchars is non-positive.
2513 (bidi_level_of_next_char): Don't try to lookup the cache for the
2514 next/previous character if nothing is cached there yet, or if we
2515 were just reseat()'ed to a new position.
2517 * xdisp.c (set_cursor_from_row): Set start and stop points
2518 according to the row's direction when priming the loop that looks
2519 for the glyph on which to display cursor.
2520 (single_display_spec_intangible_p): Function deleted.
2521 (display_prop_intangible_p): Reimplement to call
2522 handle_display_spec instead of single_display_spec_intangible_p.
2523 Accept 3 additional arguments needed by handle_display_spec.
2524 This fixes incorrect cursor motion across display property with complex
2525 values: lists, `(when COND...)' forms, etc.
2526 (single_display_spec_string_p): Support property values that are
2527 lists with the argument STRING its top-level element.
2528 (display_prop_string_p): Fix the condition for processing a
2529 property that is a list to be consistent with handle_display_spec.
2530 (handle_display_spec): New function, refactored from the
2531 last portion of handle_display_prop.
2532 (compute_display_string_pos): Accept additional argument
2533 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2534 value of a `display' property is a "replacing spec".
2535 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2536 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2537 the display property, but just return a value indicating whether
2538 the display property will replace the characters it covers.
2539 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2540 frame_window_p members of struct bidi_it.
2541 (compute_display_string_pos, compute_display_string_end):
2543 (push_it): Accept second argument POSITION, where pop_it should
2544 jump to continue iteration.
2545 (reseat_1): Initialize bidi_it.disp_pos.
2547 * keyboard.c (adjust_point_for_property): Adjust the call to
2548 display_prop_intangible_p to its new signature.
2550 * dispextern.h (struct bidi_it): New member frame_window_p.
2551 (bidi_init_it): Update prototypes.
2552 (display_prop_intangible_p): Update prototype.
2553 (compute_display_string_pos, compute_display_string_end):
2555 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2558 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2560 Malloc failure behavior now depends on size of allocation.
2561 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2562 * lisp.h: Change signatures accordingly.
2563 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2564 All callers changed. (Bug#8762)
2566 * gnutls.c: Use Emacs's memory allocators.
2567 Without this change, the gnutls library would invoke malloc etc.
2568 directly, which causes problems on non-SYNC_INPUT hosts, and which
2569 runs afoul of improving memory_full behavior. (Bug#8761)
2570 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2571 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2572 xfree instead of the default malloc, realloc, free.
2573 (Fgnutls_boot): No need to check for memory allocation failure,
2574 since xmalloc does that for us.
2576 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2577 * category.c (hash_get_category_set):
2578 * ccl.c (ccl_driver):
2579 * charset.c (Fdefine_charset_internal):
2580 * charset.h (struct charset.hash_index):
2581 * composite.c (get_composition_id, gstring_lookup_cache)
2582 (composition_gstring_put_cache):
2583 * composite.h (struct composition.hash_index):
2584 * dispextern.h (struct image.hash):
2585 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2586 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2587 (hashfn_equal, hashfn_user_defined, make_hash_table)
2588 (maybe_resize_hash_table, hash_lookup, hash_put)
2589 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2590 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2591 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2592 * image.c (make_image, search_image_cache, lookup_image)
2593 (xpm_put_color_table_h):
2594 * lisp.h (struct Lisp_Hash_Table):
2595 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2596 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2597 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2598 * alloc.c (allocate_vectorlike):
2599 Check for overflow in vector size calculations.
2600 * ccl.c (ccl_driver):
2601 Check for overflow when converting EMACS_INT to int.
2602 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2603 need to be updated by these changes.
2604 * fns.c (make_hash_table, maybe_resize_hash_table):
2605 Check for integer overflow with large hash tables.
2606 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2607 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2608 (SXHASH_REDUCE): New macro.
2609 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2610 Use it instead of discarding useful hash info with large hash values.
2611 (sxhash_float): New function.
2612 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2613 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2614 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2615 Rewrite to use FIXNUM_BITS, as this simplifies things.
2616 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2617 Adjust signatures to match updated version of code.
2618 (consing_since_gc): Now EMACS_INT, since a single hash table can
2619 use more than INT_MAX bytes.
2621 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2623 Make it possible to build with GCC-4.6+ -O2 -flto.
2625 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2627 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2629 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2630 Call minibuffer-inactive-mode.
2632 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2634 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2635 Update dependencies.
2637 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2639 * data.c (init_data): Remove code for UTS, this system is not
2642 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2644 Don't force ./temacs to start in terminal mode.
2646 * frame.c (make_initial_frame): Initialize faces in all cases, not
2647 only when CANNOT_DUMP is defined.
2648 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2650 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2652 * dispnew.c (add_window_display_history): Use const for the string
2653 pointer. Remove declaration, not needed.
2655 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2657 Use 'inline', not 'INLINE'.
2658 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2659 * alloc.c, fontset.c (INLINE): Remove.
2660 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2661 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2662 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2663 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2664 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2666 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2668 Make it possible to run ./temacs.
2670 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2671 syms_of_callproc does the same thing. Remove test for
2672 "initialized", do it in the caller.
2673 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2675 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2677 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2678 (read_minibuf): Use get_minibuffer.
2679 (syms_of_minibuf): Use DEFSYM.
2680 (Qmetadata): New var.
2681 * data.c (Qbuffer): Don't make it static.
2682 (syms_of_data): Use DEFSYM.
2684 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2686 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2687 (CCL_CODE_MIN): New macro.
2689 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2691 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2693 * eval.c (Qdebug): Now static.
2694 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2695 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2696 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2698 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2700 * image.c: Various fixes to ImageMagick code comments.
2701 (Fimagemagick_types): Doc fix.
2703 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2705 Minor fixes prompted by GCC 4.6.0 warnings.
2707 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2709 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2710 (x_clipboard_manager_save_all): Move extern decl to ...
2711 * xterm.h: ... here, so that it can be checked for consistency.
2713 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2715 * xselect.c (x_clipboard_manager_save_frame)
2716 (x_clipboard_manager_save_all): New functions.
2717 (Fx_clipboard_manager_save): Lisp function deleted.
2719 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2720 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2722 * xterm.h: Update prototype.
2724 2011-05-28 William Xu <william.xwl@gmail.com>
2726 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2729 2011-05-28 Jim Meyering <meyering@redhat.com>
2731 Avoid a sign-extension bug in crypto_hash_function.
2732 * fns.c (to_uchar): Define.
2733 (crypto_hash_function): Use it to convert some newly-signed
2734 variables to unsigned, to avoid sign-extension bugs. For example,
2735 without this change, (md5 "truc") would evaluate to
2736 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2737 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2738 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2740 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2742 Integer overflow fixes.
2744 * dbusbind.c: Serial number integer overflow fixes.
2745 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2746 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2747 to hold a serial number that is too large for a fixnum.
2748 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2749 Check for serial numbers out of range. Decode any serial number
2750 that was so large that it became a float. (Bug#8722)
2752 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2753 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2754 Use XFASTINT rather than XUINT when numbers are nonnegative.
2755 (xd_append_arg, Fdbus_method_return_internal):
2756 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2757 arguments, check that Lisp number is nonnegative, rather than
2758 silently wrapping negative numbers around. (Bug#8722)
2759 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2762 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2764 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2766 ccl: add integer overflow checks
2767 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2768 (IN_INT_RANGE): New macros.
2769 (ccl_driver): Use them to check for integer overflow when
2770 decoding a CCL program. Many of the new checks are whether XINT (x)
2771 fits in int; it doesn't always, on 64-bit hosts. The new version
2772 doesn't catch all possible integer overflows, but it's an
2773 improvement. (Bug#8719)
2775 * alloc.c (make_event_array): Use XINT, not XUINT.
2776 There's no need for unsigned here.
2778 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2779 This follows up to the 2011-05-06 change that substituted uintptr_t
2780 for EMACS_INT. This case wasn't caught back then.
2782 Rework Fformat to avoid integer overflow issues.
2783 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2784 now (part of C89). Include <verify.h>.
2785 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2786 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2787 (Fformat): Avoid the prepass trying to compute sizes; it was only
2788 approximate and thus did not catch overflow reliably. Instead, walk
2789 through the format just once, formatting and computing sizes as we go,
2790 checking for integer overflow at every step, and allocating a larger
2791 buffer as needed. Keep track separately whether the format is
2792 multibyte. Keep only the most-recently calculated precision, rather
2793 than them all. Record whether each argument has been converted to
2794 string. Use EMACS_INT, not int, for byte and char and arg counts.
2795 Support field widths and precisions larger than INT_MAX. Avoid
2796 sprintf's undefined behavior with conversion specifications such as %#d
2797 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2798 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2799 formatting out-of-range floating point numbers with int
2802 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2804 * data.c: Avoid integer truncation in expressions involving floats.
2805 * data.c: Include <intprops.h>.
2806 (arith_driver): When there's an integer overflow in an expression
2807 involving floating point, convert the integers to floating point
2808 so that the resulting value does not suffer from catastrophic
2809 integer truncation. For example, on a 64-bit host (* 4
2810 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2811 Do not rely on undefined behavior after integer overflow.
2813 merge count_size_as_multibyte, parse_str_to_multibyte
2814 * character.c, character.h (count_size_as_multibyte):
2815 Rename from parse_str_to_multibyte; all uses changed.
2816 Check for integer overflow.
2817 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2818 since it's now a duplicate of the other. This is more of
2819 a character than a buffer op, so better that it's in character.c.
2820 * fns.c, print.c: Adjust to above changes.
2822 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2824 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2826 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2828 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2829 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2830 (x_clipboard_manager_save): Now static.
2831 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2833 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2834 (crypto_hash_function): Now static.
2835 Fix pointer signedness problems. Avoid unnecessary initializations.
2837 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2839 * termhooks.h (Vselection_alist): Make it terminal-local.
2841 * terminal.c (create_terminal): Initialize it.
2843 * xselect.c: Support for clipboard managers.
2844 (Vselection_alist): Move to termhooks.h as terminal-local var.
2845 (LOCAL_SELECTION): New macro.
2846 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2847 (symbol_to_x_atom): Remove gratuitous arg.
2848 (x_handle_selection_request, lisp_data_to_selection_data)
2849 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2850 (x_own_selection, x_get_local_selection, x_convert_selection):
2851 New arg, specifying work frame. Use terminal-local Vselection_alist.
2852 (some_frame_on_display): Delete unused function.
2853 (Fx_own_selection_internal, Fx_get_selection_internal)
2854 (Fx_disown_selection_internal, Fx_selection_owner_p)
2855 (Fx_selection_exists_p): New optional frame arg.
2856 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2857 (x_handle_selection_clear): Don't treat other terminals with the
2858 same keyboard specially. Use the terminal-local Vselection_alist.
2859 (x_clear_frame_selections): Use Frun_hook_with_args.
2861 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2863 * xterm.h: Add support for those atoms.
2865 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2867 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2868 (converted_selections, conversion_fail_tag): New global variables.
2869 (x_selection_request_lisp_error): Free the above.
2870 (x_get_local_selection): Remove unnecessary code.
2871 (x_reply_selection_request): Args changed; handle arbitrary array
2872 of converted selections stored in converted_selections.
2873 Separate the XChangeProperty and SelectionNotify steps.
2874 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2875 (x_convert_selection): New function.
2876 (x_handle_selection_event): Simplify.
2877 (x_get_foreign_selection): Don't ignore incoming requests while
2878 waiting for an answer; this will fail when we implement
2879 SAVE_TARGETS, and seems unnecessary anyway.
2880 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2881 (Vx_sent_selection_functions): Doc fix.
2883 2011-05-26 Leo Liu <sdl.web@gmail.com>
2885 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2887 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2889 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2891 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2892 for fringe update if it has periodic bitmap.
2893 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2894 and fringe_bitmap_periodic_p.
2896 * fringe.c (get_fringe_bitmap_data): New function.
2897 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2898 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2899 row. Mark glyph row for fringe update if periodicity changed.
2901 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2902 for fringe update unless it has periodic bitmap.
2904 2011-05-25 Kenichi Handa <handa@m17n.org>
2906 * xdisp.c (get_next_display_element): Set correct it->face_id for
2907 a static composition.
2909 2011-05-24 Leo Liu <sdl.web@gmail.com>
2912 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2914 * fns.c (crypto_hash_function, Fsha1): New function.
2915 (Fmd5): Use crypto_hash_function.
2916 (syms_of_fns): Add Ssha1.
2918 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2920 * gnutls.c: Remove unused macros.
2921 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2922 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2923 Remove macros that are defined and never used.
2924 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2926 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2928 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2929 (Fx_get_selection_internal): Minor cleanup.
2930 (Fx_own_selection_internal): Rename arguments for consistency with
2933 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2935 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2937 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2939 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2941 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2943 * dispnew.c (scrolling_window): Don't exclude the case that the
2944 last enabled row in the desired matrix touches the bottom boundary.
2946 2011-05-21 Glenn Morris <rgm@gnu.org>
2948 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2949 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2950 and add some more files.
2952 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2954 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2955 report_file_error introduced by the change from 2011-05-07.
2957 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2959 * systime.h (Time): Define only if emacs is defined.
2960 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2961 where the include path doesn't have X11/X.h by default. See
2962 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2964 2011-05-20 Kenichi Handa <handa@m17n.org>
2966 * composite.c (find_automatic_composition): Fix previous change.
2968 2011-05-20 Glenn Morris <rgm@gnu.org>
2970 * lisp.mk: New file, split from Makefile.in.
2971 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2972 (shortlisp): Remove.
2973 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2975 2011-05-19 Glenn Morris <rgm@gnu.org>
2977 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2978 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2979 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2980 (lisp): Set the order to that of loadup.el.
2981 (shortlisp): Make it a copy of $lisp.
2982 (SOME_MACHINE_LISP): Remove.
2983 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2984 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2986 2011-05-18 Kenichi Handa <handa@m17n.org>
2988 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2989 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2990 (find_automatic_composition): Mostly rewrite for efficiency.
2992 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2994 * makefile.w32-in: Update dependencies.
2996 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2998 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2999 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3001 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3003 Fix some integer overflow issues, such as string length overflow.
3005 * insdel.c (count_size_as_multibyte): Check for string overflow.
3007 * character.c (lisp_string_width): Check for string overflow.
3008 Use EMACS_INT, not int, for string indexes and lengths; in
3009 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3010 the resulting string length overflows an EMACS_INT; instead,
3011 report a string overflow if no precision given. When checking for
3012 precision exhaustion, use a check that cannot possibly have
3013 integer overflow. (Bug#8675)
3014 * character.h (lisp_string_width): Adjust to new signature.
3016 * alloc.c (string_overflow): New function.
3017 (Fmake_string): Use it. This doesn't change behavior, but saves
3018 a few bytes and will simplify future changes.
3019 * character.c (string_escape_byte8): Likewise.
3020 * lisp.h (string_overflow): New decl.
3022 Fixups, following up to the user-interface timestamp change.
3023 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3024 for UI timestamps, instead of unsigned long.
3025 * msdos.c (mouse_get_pos): Likewise.
3026 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3027 * w32gui.h (Time): Define by including "systime.h" rather than by
3028 declaring it ourselves. (Bug#8664)
3030 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3031 * image.c (clear_image_cache): Likewise.
3033 * term.c (term_mouse_position): Don't assume time_t wraparound.
3035 Be more systematic about user-interface timestamps.
3036 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3037 and sometimes 'EMACS_UINT', to represent these timestamps.
3038 This change causes it to use 'Time' uniformly, as that's what X uses.
3039 This makes the code easier to follow, and makes it easier to catch
3040 integer overflow bugs such as Bug#8664.
3041 * frame.c (Fmouse_position, Fmouse_pixel_position):
3042 Use Time, not unsigned long, for user-interface timestamps.
3043 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3044 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3045 * keyboard.h (last_event_timestamp): Likewise.
3046 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3047 * menu.h (xmenu_show): Likewise.
3048 * term.c (term_mouse_position): Likewise.
3049 * termhooks.h (struct input_event.timestamp): Likewise.
3050 (struct terminal.mouse_position_hook): Likewise.
3051 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3052 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3053 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3054 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3056 * menu.h, termhooks.h: Include "systime.h", for Time.
3058 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3059 Don't assume that the difference between two unsigned long values
3060 can fit into an integer. At this point, we know button_down_time
3061 <= event->timestamp, so the difference must be nonnegative, so
3062 there's no need to cast the result if double-click-time is
3063 nonnegative, as it should be; check that it's nonnegative, just in
3064 case. This bug is triggered when events are more than 2**31 ms
3065 apart (about 25 days). (Bug#8664)
3067 * xselect.c (last_event_timestamp): Remove duplicate decl.
3068 (x_own_selection): Remove needless cast to unsigned long.
3070 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3071 that always fit in int. Use a sentinel instead of a counter, to
3072 avoid a temp and to allay GCC's concerns about possible int overflow.
3073 * frame.h (struct frame): Use int for menu_bar_items_used
3074 instead of EMACS_INT, since it always fits in int.
3076 * menu.c (grow_menu_items): Check for int overflow.
3078 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3080 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3081 Before, the code was not consistent. These values cannot exceed
3082 2**31 - 1 so there's no need to make them unsigned.
3083 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3084 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3085 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3087 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3089 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3090 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3091 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3092 presumably because the widths might not match.
3094 * window.c (size_window): Avoid needless test at loop start.
3096 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3098 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3100 2011-05-12 Drew Adams <drew.adams@oracle.com>
3102 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3104 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3106 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3107 `width' to `bar_area_x' and `bar_area_width', respectively.
3108 (x_scroll_run): Take account of fringe background extension.
3110 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3111 Rename local vars `left' and `width' to `bar_area_x' and
3112 `bar_area_width', respectively.
3113 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3114 background extension.
3116 2011-05-10 Jim Meyering <meyering@redhat.com>
3118 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3120 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3122 * image.c (Finit_image_library): Return t for built-in image types,
3123 like pbm and xbm. (Bug#8640)
3125 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3127 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3129 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3131 * w32console.c (Fset_screen_color): Doc fix.
3132 (Fget_screen_color): New function.
3133 (syms_of_ntterm): Defsubr it.
3135 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3136 unlink the temporary file if Fcall_process didn't create it in the
3138 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3139 child process will be redirected to a file specified with `:file'.
3140 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3141 cue to call_process_cleanup not to close that handle.
3143 2011-05-07 Ben Key <bkey76@gmail.com>
3145 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3146 one of two shell specific rules, either bootstrap-temacs-CMD or
3147 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3148 to the previous implementation of the bootstrap-temacs rule.
3149 The bootstrap-temacs-CMD rule is similar to the previous
3150 implementation of the bootstrap-temacs rule except that it
3151 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3154 These changes, along with some changes to nt/configure.bat,
3155 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3156 earlier fix to add support for --cflags and --ldflags options
3157 that include quotes so that it works whether make uses cmd or
3160 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3162 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3163 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3165 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3166 a string. Handle both cases.
3167 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3168 (Fdbus_register_method): Use Qinvalid_function.
3170 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3172 * makefile.w32-in: Update dependencies.
3173 (LISP_H): Add inttypes.h and stdin.h.
3174 (PROCESS_H): Add unistd.h.
3176 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3178 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3179 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3181 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3183 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3185 * term.c (vfatal): Remove stray call to va_end.
3186 It's not needed and the C Standard doesn't allow it here anyway.
3188 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3189 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3191 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3194 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3196 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3198 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3200 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3202 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3204 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3205 * charset.c (Fdefine_charset_internal): Don't initialize
3206 charset.code_space[15]. The value was garbage, on hosts with
3207 32-bit int (Bug#8600).
3209 * lread.c (read_integer): Be more consistent with string-to-number.
3210 Use string_to_number to do the actual conversion; this avoids
3211 rounding errors and fixes some other screwups. Without this fix,
3212 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3213 (digit_to_number): Move earlier, for benefit of read_integer.
3214 Return -1 if the digit is out of range for the base, -2 if it is
3215 not a digit in any supported base. (Bug#8602)
3217 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3219 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3220 to match comment at start of function. This also removes a
3221 GCC warning about overflow in a 32+64-bit port.
3223 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3225 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3226 Reported by Stefan Monnier in
3227 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3228 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3229 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3231 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3232 (EMACS_UINTPTR): Likewise, with uintptr_t.
3234 * lisp.h: Prefer 64-bit EMACS_INT if available.
3235 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3236 on 32-bit hosts that have 64-bit int, so that they can access
3238 However, temporarily disable this change unless the temporary
3239 symbol WIDE_EMACS_INT is defined.
3241 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3243 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3244 This removes an assumption that EMACS_INT and long are the same
3245 width as pointers. The assumption is true for Emacs porting targets
3246 now, but we want to make other targets possible.
3247 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3248 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3249 In the rest of the code, change types of integers that hold casted
3250 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3251 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3252 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3253 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3254 No need to cast type when ORing.
3255 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3256 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3257 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3258 assume EMACS_INT is the same width as char *.
3259 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3260 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3261 Remove no-longer-needed casts.
3262 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3263 (xg_tool_bar_help_callback, xg_make_tool_item):
3264 Use EMACS_INTPTR to hold an integer
3265 that will be cast to void *; this can avoid a GCC warning
3266 if EMACS_INT is not the same width as void *.
3267 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3268 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3269 (current_message_1, set_message_1):
3270 Use a local to convert to proper width without a cast.
3271 * xmenu.c (dialog_selection_callback): Likewise.
3273 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3274 Also, don't assume VALBITS / RAND_BITS is less than 5,
3275 and don't rely on undefined behavior when shifting a 1 left into
3277 * lisp.h (get_random): Change signature to match.
3279 * lread.c (hash_string): Use size_t, not int, for hash computation.
3280 Normally we prefer signed values; but hashing is special, because
3281 it's better to use unsigned division on hash table sizes so that
3282 the remainder is nonnegative. Also, size_t is the natural width
3283 for hashing into memory. The previous code used 'int', which doesn't
3284 retain enough info to hash well into very large tables.
3285 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3287 * dbusbind.c: Don't possibly lose pointer info when converting.
3288 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3289 Use XPNTR rather than XHASH, so that the high-order bits of
3290 the pointer aren't lost when converting through void *.
3292 * eval.c (Fautoload): Don't double-shift a pointer.
3294 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3296 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3298 * gnutls.c (DEF_GNUTLS_FN):
3299 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3301 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3303 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3306 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3308 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3309 New version that can reserve upto 2GB of heap space.
3311 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3313 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3315 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3317 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3318 `gnutls_certificate_set_x509_key_file'.
3320 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3322 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3323 Update dependencies.
3325 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3327 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3328 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3329 Remove unused parameter `fildes'.
3330 * process.c (read_process_output, send_process): Don't pass it.
3332 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3334 Fix previous change: the library cache is defined in w32.c.
3335 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3336 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3338 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3340 Implement dynamic loading of GnuTLS on Windows.
3342 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3343 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3344 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3347 * gnutls.c (Qgnutls_dll): Define.
3348 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3349 (gnutls_*): Declare function pointers.
3350 (init_gnutls_functions): New function to initialize function pointers.
3351 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3352 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3353 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3354 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3355 (emacs_gnutls_write, emacs_gnutls_read)
3356 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3357 (Fgnutls_available_p): New function.
3358 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3359 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3360 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3362 * image.c: Include w32.h.
3363 (Vimage_type_cache): Delete.
3364 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3365 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3366 (w32_delayed_load): Move to w32.c.
3368 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3370 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3371 (w32_delayed_load): Move from image.c. When loading a library, record
3372 its filename in the :loaded-from property of the library id.
3373 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3374 Initialize and staticpro them.
3375 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3377 * process.c: Include lisp.h before w32.h, not after.
3378 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3379 instead of gnutls_record_check_pending.
3381 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3383 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3385 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3386 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3389 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3391 * xterm.c (x_set_frame_alpha): Do not set property on anything
3392 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3394 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3396 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3398 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3400 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3401 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3402 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3403 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3404 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3405 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3406 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3407 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3408 (Qgnutls_bootprop_callbacks_verify): Make static.
3410 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3412 * callproc.c: Indentation fixup.
3414 * sysdep.c (wait_for_termination_1): Make static.
3415 (wait_for_termination, interruptible_wait_for_termination):
3416 Move after wait_for_termination_1.
3418 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3420 * sysdep.c (interruptible_wait_for_termination): New function
3421 which is like wait_for_termination, but allows keyboard
3424 * callproc.c (Fcall_process): Add (:file "file") as an option for
3426 (Fcall_process_region): Ditto.
3428 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3430 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3431 rather than `XVECTOR (FOO)->size'.
3433 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3434 inttypes.h, as a gnulib replacement is used if it not available in
3437 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3439 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3440 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3441 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3443 * coding.c (coding_alloc_by_realloc): Error out if destination
3444 will grow beyond MOST_POSITIVE_FIXNUM.
3445 (decode_coding_emacs_mule): Abort if there isn't enough place in
3446 charbuf for the composition carryover bytes. Reserve an extra
3447 space for up to 2 characters produced in a loop.
3448 (decode_coding_iso_2022): Abort if there isn't enough place in
3449 charbuf for the composition carryover bytes.
3451 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3453 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3454 aborting when %lld or %lll format is passed.
3455 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3456 %llo or %llx format is passed. (Bug#8545)
3458 * window.c (window_scroll_line_based): Use a marker instead of
3459 simple variables to record original value of point. (Bug#7952)
3461 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3462 produced by %s or %c overflows available buffer space. (Bug#8545)
3464 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3466 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3467 (SIZE_MAX): Move defn after all includes, as they might #define it.
3469 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3471 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3473 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3475 * keyboard.c (Qdelayed_warnings_hook): Define.
3476 (command_loop_1): Run `delayed-warnings-hook'
3477 if Vdelayed_warnings_list is non-nil.
3478 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3479 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3481 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3483 * doprnt.c (doprnt): Don't return value smaller than the buffer
3484 size if the message was truncated. (Bug#8545).
3486 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3488 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3489 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3491 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3493 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3495 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3497 * makefile.w32-in: Update dependencies.
3499 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3501 Improve `doprnt' and its usage. (Bug#8545)
3502 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3503 `format_end'. Remove support for %l as a conversion specifier.
3504 Don't use xrealloc. Improve diagnostics when the %l size modifier
3505 is used. Update the commentary.
3507 * eval.c (verror): Simplify calculation of size_t.
3509 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3512 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3514 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3517 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3519 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3520 This makes this file independent of the recent pseudovector change.
3522 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3524 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3526 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3527 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3528 Remove unused local.
3529 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3531 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3532 GCC 4.6.0 optimizes based on type-based alias analysis.
3533 For example, if b is of type struct buffer * and v of type struct
3534 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3535 != &v->size, and therefore "v->size = 1; b->size = 2; return
3536 v->size;" must therefore return 1. This assumption is incorrect
3537 for Emacs, since it type-puns struct Lisp_Vector * with many other
3538 types. To fix this problem, this patch adds a new type struct
3539 vectorlike_header that documents the constraints on layout of vectors
3540 and pseudovectors, and helps optimizing compilers not get fooled
3541 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3542 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3543 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3545 (XSETPVECTYPE): Rewrite in terms of new macro.
3546 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3547 This is a bit clearer, and further avoids the possibility of
3548 undesirable aliasing.
3549 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3550 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3551 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3552 since Lisp_Subr is a special case (no "next" field).
3553 (ASIZE): Now uses header.size rather than size.
3554 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3555 to avoid the hassle of writing XVECTOR (foo)->header.size.
3556 (struct vectorlike_header): New type.
3557 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3558 object, to help avoid aliasing.
3559 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3560 (SUBRP): Likewise, since Lisp_Subr is a special case.
3561 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3562 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3563 (struct Lisp_Hash_Table): Combine first two members into a single
3564 struct vectorlike_header member. All uses of "size" and "next" members
3565 changed to be "header.size" and "header.next".
3566 * buffer.h (struct buffer): Likewise.
3567 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3568 * frame.h (struct frame): Likewise.
3569 * process.h (struct Lisp_Process): Likewise.
3570 * termhooks.h (struct terminal): Likewise.
3571 * window.c (struct save_window_data, struct saved_window): Likewise.
3572 * window.h (struct window): Likewise.
3573 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3574 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3575 * buffer.c (init_buffer_once): Likewise.
3576 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3578 * process.c (Fformat_network_address): Use local var for size,
3581 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3583 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3584 * data.c (atof): Remove decl; no longer used or needed.
3585 (digit_to_number): Move to lread.c.
3586 (Fstring_to_number): Use new string_to_number function, to be
3587 consistent with how the Lisp reader treats infinities and NaNs.
3588 Do not assume that floating-point numbers represent EMACS_INT
3589 without losing information; this is not true on most 64-bit hosts.
3590 Avoid double-rounding errors, by insisting on integers when
3591 parsing non-base-10 numbers, as the documentation specifies.
3592 * lisp.h (string_to_number): New decl, replacing ...
3593 (isfloat_string): Remove.
3594 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3595 (read1): Do not accept +. and -. as integers; this
3596 appears to have been a coding error. Similarly, do not accept
3597 strings like +-1e0 as floating point numbers. Do not report
3598 overflow for integer overflows unless the base is not 10 which
3599 means we have no simple and reliable way to continue.
3600 Break out the floating-point parsing into a new
3601 function string_to_number, so that Fstring_to_number parses
3602 floating point numbers consistently with the Lisp reader.
3603 (digit_to_number): Move here from data.c. Make it static inline.
3604 (E_CHAR, EXP_INT): Remove, replacing with ...
3605 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3606 (string_to_number): New function, replacing isfloat_string.
3607 This function checks for valid syntax and produces the resulting
3608 Lisp float number too. Rework it so that string-to-number
3609 no longer mishandles examples like "1.0e+". Use strtoumax,
3610 so that overflow for non-base-10 numbers is reported only when
3611 there's no portable and simple way to convert to floating point.
3613 * textprop.c (set_text_properties_1): Rewrite for clarity,
3614 and to avoid GCC warning about integer overflow.
3616 * intervals.h (struct interval): Use EMACS_INT for members
3617 where EMACS_UINT might cause problems. See
3618 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3619 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3620 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3622 (offset_intervals): Tell GCC not to worry about length overflow
3623 when negating a negative length.
3625 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3626 (overrun_check_free): Likewise.
3628 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3629 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3632 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3633 (gnutls_make_error): Rename local to avoid shadowing.
3634 (gnutls_emacs_global_deinit): ifdef out; not used.
3635 (Fgnutls_boot): Use const for pointer to readonly storage.
3636 Comment out unused local. Fix pointer signedness problems.
3638 * lread.c (openp): Don't stuff size_t into an 'int'.
3639 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3640 about possible signed overflow.
3642 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3643 (GDK_KEY_g): Don't define if already defined.
3644 (xg_prepare_tooltip): Avoid pointer signedness problem.
3645 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3647 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3648 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3650 * xfns.c (Fx_window_property): Simplify a bit,
3651 to make a bit faster and to avoid GCC 4.6.0 warning.
3652 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3654 * fns.c (internal_equal): Don't assume size_t fits in int.
3656 * alloc.c (compact_small_strings): Tighten assertion a little.
3658 Replace pEd with more-general pI, and fix some printf arg casts.
3659 * lisp.h (pI): New macro, generalizing old pEd macro to other
3660 conversion specifiers. For example, use "...%"pI"d..." rather
3661 than "...%"pEd"...".
3662 (pEd): Remove. All uses replaced with similar uses of pI.
3663 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3664 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3665 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3666 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3667 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3668 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3669 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3671 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3672 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3673 * print.c (safe_debug_print, print_object): Likewise.
3674 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3676 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3677 avoiding the 0 flag, which is not portable.
3678 * process.c (Fmake_network_process): Use pI to avoid cast.
3679 * region-cache.c (pp_cache): Likewise.
3680 * xdisp.c (decode_mode_spec): Likewise.
3681 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3682 behavior on 64-bit hosts with printf arg.
3683 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3684 (x_stop_queuing_selection_requests): Likewise.
3685 (x_get_window_property): Don't truncate byte count to an 'int'
3688 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3689 here, since it parses constructs like leading '-' and spaces,
3690 which are not wanted; and it overflows with large numbers.
3691 Instead, simply match F[0-9]+, which is what is wanted anyway.
3693 * alloc.c: Remove unportable assumptions about struct layout.
3694 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3695 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3696 (allocate_vectorlike, make_pure_vector): Use the new macros,
3697 plus offsetof, to remove unportable assumptions about struct layout.
3698 These assumptions hold on all porting targets that I know of, but
3699 they are not guaranteed, they're easy to remove, and removing them
3700 makes further changes easier.
3702 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3703 This doesn't fix a bug but makes the code clearer.
3704 (string_overrun_cookie): Now const. Use initializers that
3705 don't formally overflow signed char, to avoid warnings.
3706 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3707 can cause Emacs to crash when string overrun checking is enabled.
3708 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3709 multiple of sizeof (EMACS_INT); it need not be, if
3710 alignof(EMACS_INT) < sizeof (EMACS_INT).
3711 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3713 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3715 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3717 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3719 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3720 supposed to be handshaking. (Bug#8556)
3721 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3723 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3725 * lisp.h (Qdebug): List symbol.
3726 * eval.c (Qdebug): Restore global linkage.
3727 * keyboard.c (debug-on-event): New variable.
3728 (handle_user_signal): Break into debugger when debug-on-event
3729 matches the current signal symbol.
3731 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3733 * alloc.c (check_sblock, check_string_bytes)
3734 (check_string_free_list): Convert to standard C.
3736 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3738 * w32.c (emacs_gnutls_push): Fix typo.
3740 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3742 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3743 "cast to pointer from integer of different size".
3745 Improve doprnt and its use in verror. (Bug#8545)
3746 * doprnt.c (doprnt): Document the set of format control sequences
3747 supported by the function. Use SAFE_ALLOCA instead of always
3750 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3751 is one byte too soon. Don't use xrealloc; instead xfree and
3754 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3756 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3759 * gnutls.c: Renamed global_initialized to
3760 gnutls_global_initialized. Added internals for the
3761 :verify-hostname-error, :verify-error, and :verify-flags
3762 parameters of `gnutls-boot' and documented those parameters in the
3763 docstring. Start callback support.
3764 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3765 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3766 on error. Return error code.
3767 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3768 (emacs_gnutls_read): Likewise.
3769 (Fgnutls_boot): Return handshake error code.
3770 (emacs_gnutls_handle_error): New function.
3771 (wsaerror_to_errno): Likewise.
3773 * w32.h (emacs_gnutls_pull): Add prototype.
3774 (emacs_gnutls_push): Likewise.
3776 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3777 (emacs_gnutls_push): Likewise.
3779 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3781 * process.c (wait_reading_process_output): Check if GnuTLS
3782 buffered some data internally if no FDs are set for TLS
3785 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3786 (LIBS): Link to USER_LIBS.
3787 ($(BLD)/gnutls.$(0)): New target.
3789 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3791 * xdisp.c (handle_single_display_spec): Rename the
3792 display_replaced_before_p argument into display_replaced_p, to
3793 make it consistent with the commentary. Fix typos in the
3796 * textprop.c (syms_of_textprop): Remove dead code.
3797 (copy_text_properties): Delete obsolete commentary about an
3798 interface that was deleted long ago. Fix typos in the description
3801 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3802 to changes in oldXMenu/XMenu.h from 2011-04-16.
3803 <menu_help_message, prev_menu_help_message>: Constify.
3804 (IT_menu_make_room): menu->help_text is now `const char **';
3807 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3808 to changes in oldXMenu/XMenu.h from 2011-04-16.
3809 (struct XMenu): Declare `help_text' `const char **'.
3811 * xfaces.c <Qunspecified>: Make extern again.
3813 * syntax.c: Include sys/types.h before including regex.h, as
3816 * doc.c (get_doc_string): Improve the format passed to `error'.
3818 * doprnt.c (doprnt): Improve commentary.
3820 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3822 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3825 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3826 changes in globals.h immediately force recompilation.
3827 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3828 $(CURDIR)/s/ms-w32.h.
3829 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3831 * character.c (Fchar_direction): Function deleted.
3832 (syms_of_character): Don't defsubr it.
3833 <char-direction-table>: Deleted.
3835 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3837 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3838 * doprnt.c: Include limits.h.
3839 (SIZE_MAX): New macro.
3840 (doprnt): Return a size_t value. 2nd arg is now size_t.
3841 Many local variables are now size_t instead of int or unsigned.
3842 Improve overflow protection. Support `l' modifier for integer
3843 conversions. Support %l conversion. Don't assume an EMACS_INT
3844 argument for integer conversions and for %c.
3846 * lisp.h (doprnt): Restore prototype.
3848 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3851 * Makefile.in (base_obj): Add back doprnt.o.
3853 * deps.mk (doprnt.o): Add back prerequisites.
3854 (callint.o): Depend on character.h.
3856 * eval.c (internal_lisp_condition_case): Include the handler
3857 representation in the error message.
3858 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3859 when breaking from the loop.
3861 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3863 * callint.c (Fcall_interactively): When displaying error message
3864 about invalid control letter, pass the character's codepoint, not
3865 a pointer to its multibyte form. Improve display of the character
3866 in octal and display also its hex code.
3868 * character.c (char_string): Use %x to display the (unsigned)
3869 codepoint of an invalid character, to avoid displaying a bogus
3872 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3873 `error', not SYMBOL_NAME itself.
3875 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3876 character arguments to `error'.
3878 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3879 to `error' in error message about FINAL_CHAR argument. Make sure
3880 FINAL_CHAR is a character, and use %c when it is passed as
3881 argument to `error'.
3883 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3885 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3887 * w32.c: Include <time.h>.
3888 (sys_localtime): New function.
3890 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3892 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3894 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3896 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3898 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3901 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3903 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3904 gl_state.e_property when gl_state.object is Qt.
3906 * insdel.c (make_gap_larger): Remove limitation of buffer size
3909 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3911 * xdisp.c (lookup_glyphless_char_display)
3912 (produce_glyphless_glyph): Handle cons cell entry in
3913 glyphless-char-display.
3914 (Vglyphless_char_display): Document it.
3916 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3917 glyphless-char-display.
3919 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3921 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3923 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3925 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3926 definition for no-X builds.
3928 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3930 Static checks with GCC 4.6.0 and non-default toolkits.
3932 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3934 * process.c (keyboard_bit_set): Define only if SIGIO.
3935 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3936 (send_process): Repair possible setjmp clobbering.
3938 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3940 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3942 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3944 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3945 Define only if needed.
3947 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3948 by pacifying GCC about it. Maybe it's time to retire it?
3949 * xfaces.c (USG, __TIMEVAL__): Likewise.
3951 * dispextern.h (struct redisplay_interface): Rename param
3953 * termhooks.h (struct terminal): Likewise.
3954 * xterm.c (xembed_send_message): Likewise.
3956 * insdel.c (make_gap_smaller): Define only if
3957 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3959 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3962 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3963 so that we aren't warned about unused symbols.
3965 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3967 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3969 * xfns.c (x_real_positions): Mark locals as initialized.
3971 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3973 * xterm.c: Fix problems found by static analysis with other toolkits.
3974 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3975 (x_dispatch_event): Declare static if USE_GTK, and
3976 define if USE_GTK || USE_X_TOOLKIT.
3977 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3978 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3979 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3980 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3982 * xmenu.c (menu_help_callback): Pointer type fixes.
3983 Use const pointers when pointing at readonly data. Avoid pointer
3985 (FALSE): Remove unused macro.
3986 (update_frame_menubar): Remove unused decl.
3988 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3990 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3991 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3992 (single_menu_item): Rename local to avoid shadowing.
3994 * keyboard.c (make_lispy_event): Remove unused local var.
3996 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3997 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3999 * bitmaps: Change bitmaps from unsigned char back to the X11
4000 compatible char. Avoid the old compiler warnings about
4001 out-of-range initializers by using, for example, '\xab' rather
4004 * xgselect.c (xgselect_initialize): Check vs interface
4005 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4007 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4009 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4010 to read-only memory.
4012 * fns.c (vector): Remove; this old hack is no longer needed.
4014 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4016 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4018 * xrdb.c (x_load_resources): Omit unused local.
4020 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4021 (x_window): Rename locals to avoid shadowing.
4022 (USG): Use the kludged USG macro, to pacify gcc.
4024 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4025 (x_term_init): Remove local to avoid shadowing.
4027 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4029 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4030 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4032 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4034 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4036 Fix regex.c, syntax.c and friends for buffers > 2GB.
4037 * syntax.h (struct gl_state_s): Declare character position members
4040 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4042 * textprop.c (verify_interval_modification, interval_of):
4043 Declare arguments EMACS_INT.
4045 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4048 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4050 * indent.c (Fvertical_motion): Local variable it_start is now
4053 * regex.c (re_match, re_match_2, re_match_2_internal)
4054 (bcmp_translate, regcomp, regexec, print_double_string)
4055 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4056 (re_compile_pattern, re_exec): Declare arguments and local
4057 variables `size_t' and `ssize_t' and return values `regoff_t', as
4059 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4060 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4061 <compile_stack_type>: `size' and `avail' are now `size_t'.
4063 * regex.h <regoff_t>: Use ssize_t, not int.
4064 (re_search, re_search_2, re_match, re_match_2): Arguments that
4065 specify buffer/string position and length are now ssize_t and
4066 size_t. Return type is regoff_t.
4068 2011-04-16 Ben Key <bkey76@gmail.com>
4070 * nsfont.m: Fixed bugs in ns_get_family and
4071 ns_descriptor_to_entity that were caused by using free to
4072 deallocate memory blocks that were allocated by xmalloc (via
4073 xstrdup). This caused Emacs to crash when compiled with
4074 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4075 --enable-checking=xmallocoverrun). xfree is now used to
4076 deallocate these memory blocks.
4078 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4080 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4082 emacs_write: Accept and return EMACS_INT for sizes.
4083 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4085 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4086 Accept and return EMACS_INT.
4087 (emacs_gnutls_write): Return the number of bytes written on
4089 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4090 (emacs_read, emacs_write): Remove check for negative size, as the
4091 Emacs source code has been audited now.
4092 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4093 (emacs_read, emacs_write): Use it.
4094 * process.c (send_process): Adjust to the new signatures of
4095 emacs_write and emacs_gnutls_write. Do not attempt to store
4096 a byte offset into an 'int'; it might overflow.
4097 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4099 * sound.c: Don't assume sizes fit in 'int'.
4100 (struct sound_device.period_size, alsa_period_size):
4101 Return EMACS_INT, not int.
4102 (struct sound_device.write, vox_write, alsa_write):
4103 Accept EMACS_INT, not int.
4104 (wav_play, au_play): Use EMACS_INT to store sizes and to
4105 record read return values.
4107 2011-04-15 Ben Key <bkey76@gmail.com>
4109 * keyboard.c (Qundefined): Don't declare static since it is used
4111 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4112 static since they are used in nsfont.m.
4114 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4116 * process.c (Qprocessp): Don't declare static.
4117 * lisp.h (Qprocessp): Declare again.
4119 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4121 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4123 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4125 Improve C-level modularity by making more things 'static'.
4127 Don't publish debugger-only interfaces to other modules.
4128 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4129 (verify_bytepos, count_markers): Move decls to the only modules
4131 * region-cache.h (pp_cache): Likewise.
4132 * window.h (check_all_windows): Likewise.
4133 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4135 * sysdep.c (croak): Now static, if
4136 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4137 * syssignal.h (croak): Declare only if not static.
4139 * alloc.c (refill_memory_reserve): Now static if
4140 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4141 * lisp.h (refill_memory_reserve): Declare only if not static.
4143 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4144 Define only if USE_LUCID.
4146 * xrdb.c (x_customization_string, x_rm_string): Now static.
4148 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4149 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4151 * xdisp.c (draw_row_with_mouse_face): Now static.
4152 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4154 * window.h (check_all_windows): Mark externally visible.
4156 * window.c (window_deletion_count): Now static.
4158 * undo.c: Make symbols static if they're not exported.
4159 (last_undo_buffer, last_boundary_position, pending_boundary):
4162 * textprop.c (interval_insert_behind_hooks): Now static.
4163 (interval_insert_in_front_hooks): Likewise.
4165 * term.c: Make symbols static if they're not exported.
4166 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4167 (max_frame_lines, tty_set_terminal_modes):
4168 (tty_reset_terminal_modes, tty_turn_off_highlight):
4169 (get_tty_terminal): Now static.
4170 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4171 * termhooks.h (term_mouse_moveto): Do not declare if
4173 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4174 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4176 * sysdep.c: Make symbols static if they're not exported.
4177 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4179 (sigprocmask_set, full_mask): Remove; unused.
4180 (wait_debugging): Mark as visible.
4181 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4182 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4184 * syntax.c (syntax_temp): Define only if !__GNUC__.
4186 * sound.c (current_sound_device, current_sound): Now static.
4188 * search.c (searchbufs, searchbuf_head): Now static.
4190 * scroll.c (scroll_cost): Remove; unused.
4191 * dispextern.h (scroll_cost): Remove decl.
4193 * region-cache.h (pp_cache): Mark as externally visible.
4195 * process.c: Make symbols static if they're not exported.
4196 (process_tick, update_tick, create_process, chan_process):
4197 (Vprocess_alist, proc_buffered_char, datagram_access):
4198 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4199 (deactivate_process): Mark defn as static, as well as decl.
4200 * lisp.h (create_process): Remove decl.
4201 * process.h (chan_process, Vprocess_alist): Remove decls.
4203 * print.c: Make symbols static if they're not exported.
4204 (print_depth, new_backquote_output, being_printed, print_buffer):
4205 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4206 (print_interval, print_number_index, initial_stderr_stream):
4208 * lisp.h (Fprinc): Remove decl.
4209 (debug_output_compilation_hack): Mark as externally visible.
4211 * sysdep.c (croak): Move decl from here to syssignal.h.
4212 * syssignal.h (croak): Put it here, so the API can be checked when
4213 'croak' is called from dissociate_if_controlling_tty.
4215 * minibuf.c: Make symbols static if they're not exported.
4216 (minibuf_save_list, choose_minibuf_frame): Now static.
4217 * lisp.h (choose_minibuf_frame): Remove decl.
4219 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4221 * lread.c: Make symbols static if they're not exported.
4222 (read_objects, initial_obarray, oblookup_last_bucket_number):
4224 (make_symbol): Remove; unused.
4225 * lisp.h (initial_obarray, make_symbol): Remove decls.
4227 * keyboard.c: Make symbols static if they're not exported.
4228 (single_kboard, recent_keys_index, total_keys, recent_keys):
4229 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4230 (this_single_command_key_start, echoing, last_auto_save):
4231 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4232 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4233 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4234 (Vlispy_mouse_stem, double_click_count):
4236 (force_auto_save_soon): Define only if SIGDANGER.
4237 (ignore_mouse_drag_p): Now static if
4238 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4239 (print_help): Remove; unused.
4240 (stop_character, last_timer_event): Mark as externally visible.
4241 * keyboard.h (ignore_mouse_drag_p): Declare only if
4242 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4243 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4244 * lisp.h (echoing): Remove decl.
4245 (force_auto_save_soon): Declare only if SIGDANGER.
4246 * xdisp.c (redisplay_window): Simplify code, to make it more
4247 obvious that ignore_mouse_drag_p is not accessed if !defined
4248 USE_GTK && !defined HAVE_NS.
4250 * intervals.c: Make symbols static if they're not exported.
4251 (merge_properties_sticky, merge_interval_right, delete_interval):
4253 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4255 * insdel.c: Make symbols static if they're not exported.
4256 However, leave prepare_to_modify_buffer alone. It's never
4257 called from outside this function, but that appears to be a bug.
4258 (combine_after_change_list, combine_after_change_buffer):
4259 (adjust_after_replace, signal_before_change): Now static.
4260 (adjust_after_replace_noundo): Remove; unused.
4261 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4262 (signal_before_change): Remove decls.
4264 * indent.c (val_compute_motion, val_vmotion): Now static.
4266 * image.c: Make symbols static if they're not exported.
4267 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4269 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4270 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4272 * fringe.c (standard_bitmaps): Now static.
4273 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4275 * frame.c: Make symbols static if they're not exported.
4276 (x_report_frame_params, make_terminal_frame): Now static.
4277 (get_frame_param): Now static, unless HAVE_NS.
4278 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4279 (x_get_resource_string): Remove; not used.
4280 * frame.h (make_terminal_frame, x_report_frame_params):
4281 (x_get_resource_string); Remove decls.
4282 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4283 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4285 * font.c, fontset.c: Make symbols static if they're not exported.
4286 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4287 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4288 * font.c (font_close_object): Now static.
4289 * font.h (font_close_object): Remove.
4290 * fontset.c (FONTSET_OBJLIST): Remove.
4291 (free_realized_fontset) #if-0 the body, which does nothing.
4292 (face_suitable_for_char_p): #if-0, as it's never called.
4293 * fontset.h (face_suitable_for_char_p): Remove decl.
4294 * xfaces.c (face_at_string_position):
4295 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4296 since 0 is always ASCII.
4298 * fns.c (weak_hash_tables): Now static.
4300 * fileio.c: Make symbols static if they're not exported.
4301 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4302 (Vwrite_region_annotation_buffers): Now static.
4304 * eval.c: Make symbols static if they're not exported.
4305 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4306 * lisp.h (backtrace_list): Remove decl.
4308 * emacs.c: Make symbols static if they're not exported.
4309 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4310 (fatal_error_code, fatal_error_signal_hook, standard_args):
4312 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4313 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4314 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4315 * lisp.h (fatal_error_signal_hook): Remove decl.
4316 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4318 * editfns.c: Move a (normally-unused) function to its only use.
4319 * editfns.c, lisp.h (get_operating_system_release): Remove.
4320 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4321 worth the hassle of breaking this out.
4323 * xterm.c: Make symbols static if they're not exported.
4324 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4325 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4326 (x_destroy_window, x_delete_display):
4328 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4329 (x_mouse_leave): Remove; unused.
4330 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4331 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4332 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4334 (x_mouse_leave): Declare only if WINDOWSNT.
4335 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4336 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4339 * ftxfont.c: Make symbols static if they're not exported.
4340 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4342 * font.h (ftxfont_driver): Likewise.
4344 * xfns.c: Make symbols static if they're not exported.
4345 (x_last_font_name, x_display_info_for_name):
4346 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4347 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4348 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4349 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4350 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4351 (last_show_tip_args): Now static.
4352 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4353 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4354 (x_screen_planes): Remove; unused.
4355 * dispextern.h (x_screen_planes): Remove decl.
4357 * dispnew.c: Make symbols static if they're not exported.
4358 * dispextern.h (redraw_garbaged_frames, scrolling):
4359 (increment_row_positions): Remove.
4360 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4361 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4363 (redraw_garbaged_frames): Remove; unused.
4365 * xfaces.c: Make symbols static if they're not exported.
4366 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4368 * xterm.h (defined_color): Remove decls.
4369 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4370 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4371 (menu_face_changed_default, defined_color, free_realized_face):
4372 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4373 (ascii_face_of_lisp_face): Remove; unused.
4375 * xdisp.c: Make symbols static if they're not exported.
4376 * dispextern.h (scratch_glyph_row, window_box_edges):
4377 (glyph_to_pixel_coords, set_cursor_from_row):
4378 (get_next_display_element, set_iterator_to_next):
4379 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4380 (show_mouse_face): Remove decls
4381 * frame.h (message_buf_print): Likewise.
4382 * lisp.h (pop_message, set_message, check_point_in_composition):
4384 * xterm.h (set_vertical_scroll_bar): Likewise.
4385 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4386 (message_buf_print, scratch_glyph_row, displayed_buffer):
4387 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4388 (get_next_display_element, show_mouse_face, window_box_edges):
4389 (frame_to_window_pixel_xy, check_point_in_composition):
4390 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4391 (glyph_to_pixel_coords): Remove; unused.
4393 * dired.c (file_name_completion): Now static.
4395 * dbusbind.c (xd_in_read_queued_messages): Now static.
4397 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4398 * data.c (circular_list_error): Remove.
4400 * commands.h (last_point_position, last_point_position_buffer):
4401 (last_point_position_window): Remove decls.
4402 * keyboard.c: Make these variables static.
4404 * coding.h (coding, code_convert_region, encode_coding_gap):
4406 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4407 (iso_code_class, detect_coding, code_convert_region): Now static.
4408 (encode_coding_gap): Remove; unused.
4410 * chartab.c (chartab_chars, chartab_bits): Now static.
4412 * charset.h (charset_iso_8859_1): Remove decl.
4413 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4416 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4417 * ccl.c (Vccl_program_table): Now static.
4418 (check_ccl_update): Remove; unused.
4420 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4421 * category.h: ... from here.
4422 * category.c (check_category_table, set_category_set): Now static.
4424 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4425 * lisp.h: Remove these decls.
4427 * buffer.c (buffer_count): Remove unused var.
4429 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4430 so that it's not optimized away.
4431 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4432 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4433 exported only to the debugger.
4435 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4436 * atimer.h (run_all_atimers): Remove; not exported.
4438 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4439 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4440 was inaccessible from Lisp.
4441 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4442 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4444 alloc.c: Import and export fewer symbols, and remove unused items.
4445 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4447 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4448 it's not optimized away by whole-program optimization.
4449 (message_enable_multibyte, free_misc): Remove.
4450 (catchlist, handlerlist, mark_backtrace):
4451 Declare only if BYTE_MARK_STACK.
4452 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4453 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4454 (message_enable_multibyte): Remove decl.
4455 (free_misc, interval_free_list, float_block, float_block_index):
4456 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4457 (cons_free_list, last_marked_index):
4459 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4460 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4461 (mark_backtrace): Define only if BYTE_MARK_STACK.
4462 * xdisp.c (message_enable_multibyte): Now static.
4464 Declare Lisp_Object Q* variables to be 'static' if not exported.
4465 This makes it easier for human readers (and static analyzers)
4466 to see whether these variables are used from other modules.
4467 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4468 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4469 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4470 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4471 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4472 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4473 * xmenu.c, xselect.c:
4474 Declare Q* vars static if they are not used in other modules.
4475 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4476 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4477 Remove decls of unexported vars.
4478 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4480 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4482 Make Emacs functions such as Fatom 'static' by default.
4483 This makes it easier for human readers (and static analyzers)
4484 to see whether these functions can be called from other modules.
4485 DEFUN now defines a static function. To make the function external
4486 so that it can be used in other C modules, use the new macro DEFUE.
4487 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4488 (Finit_image_library):
4489 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4490 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4491 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4492 Remove decls, since these functions are now static.
4493 (Funintern, Fget_internal_run_time): New decls, since these functions
4494 were already external.
4496 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4497 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4498 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4499 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4500 * keyboard.c, keymap.c, lread.c:
4501 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4502 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4503 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4504 Mark functions with DEFUE instead of DEFUN,
4505 if they are used in other modules.
4506 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4507 decls for now-static functions.
4508 * buffer.h (Fdelete_overlay): Remove decl.
4509 * callproc.c (Fgetenv_internal): Mark as internal.
4510 * composite.c (Fremove_list_of_text_properties): Remove decl.
4511 (Fcomposition_get_gstring): New forward static decl.
4512 * composite.h (Fcomposite_get_gstring): Remove decl.
4513 * dired.c (Ffile_attributes): New forward static decl.
4514 * doc.c (Fdocumntation_property): New forward static decl.
4515 * eval.c (Ffetch_bytecode): New forward static decl.
4516 (Funintern): Remove extern decl; now in .h file where it belongs.
4517 * fileio.c (Fmake_symbolic_link): New forward static decl.
4518 * image.c (Finit_image_library): New forward static decl.
4519 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4520 * intervals.h (Fprevious_property_change):
4521 (Fremove_list_of_text_properties): Remove decls.
4522 * keyboard.c (Fthis_command_keys): Remove decl.
4523 (Fcommand_execute): New forward static decl.
4524 * keymap.c (Flookup_key): New forward static decl.
4525 (Fcopy_keymap): Now static.
4526 * keymap.h (Flookup_key): Remove decl.
4527 * process.c (Fget_process): New forward static decl.
4528 (Fprocess_datagram_address): Mark as internal.
4529 * syntax.c (Fsyntax_table_p): New forward static decl.
4530 (skip_chars): Remove duplicate decl.
4531 * textprop.c (Fprevious_property_change): New forward static decl.
4532 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4534 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4535 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4537 * editfns.c (Fformat): Remove unreachable code.
4539 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4541 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4544 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4546 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4547 when at ZV. (Bug#8487)
4549 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4551 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4553 * keyboard.c (parse_tool_bar_item): Likewise.
4554 * sound.c (sound_cleanup, alsa_close): Likewise.
4555 * termcap.c (tgetent): Likewise.
4556 * xfns.c (x_default_font_parameter): Likewise.
4557 * xsettings.c (read_and_apply_settings): Likewise.
4559 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4560 (overrun_check_free): Protoize.
4562 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4564 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4565 since callers should never pass a negative size.
4566 Change the signature to match that of plain 'read' and 'write'; see
4567 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4568 * lisp.h: Update prototypes of emacs_write and emacs_read.
4570 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4572 * xdisp.c (redisplay_window): Don't try to determine the character
4573 position of the scroll margin if the window start point w->startp
4574 is outside the buffer's accessible region. (Bug#8468)
4576 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4578 Fix write-region and its subroutines for buffers > 2GB.
4579 * fileio.c (a_write, e_write): Modify declaration of arguments and
4580 local variables to support buffers larger than 2GB.
4581 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4583 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4584 argument, local variables, and return value.
4586 * lisp.h: Update prototypes of emacs_write and emacs_read.
4588 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4590 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4592 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4594 Fix more problems found by GCC 4.6.0's static checks.
4596 * xdisp.c (vmessage): Use a better test for character truncation.
4598 * charset.c (load_charset_map): <, not <=, for optimization,
4599 and to avoid potential problems with integer overflow.
4600 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4601 * casetab.c (set_identity, shuffle): Likewise.
4602 * editfns.c (Fformat): Likewise.
4603 * syntax.c (skip_chars): Likewise.
4605 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4606 This also lets GCC 4.6.0 generate slightly better loop code.
4608 * callint.c (Fcall_interactively): <, not <=, for optimization.
4609 (Fcall_interactively): Count the number of arguments produced,
4610 not the number of arguments given. This is simpler and lets GCC
4611 4.6.0 generate slightly better code.
4613 * ftfont.c: Distingish more carefully between FcChar8 and char.
4614 The previous code passed unsigned char * to a functions like
4615 strlen and xstrcasecmp that expect char *, which does not
4616 conform to the C standard.
4617 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4618 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4619 char * when the C standard requires it.
4621 * keyboard.c (read_char): Remove unused var.
4623 * eval.c: Port to Windows vsnprintf (Bug#8435).
4625 (SIZE_MAX): Define if the headers do not.
4626 (verror): Do not give up if vsnprintf returns a negative count.
4627 Instead, grow the buffer. This ports to Windows vsnprintf, which
4628 does not conform to C99. Problem reported by Eli Zaretskii.
4629 Also, simplify the allocation scheme, by avoiding the need for
4630 calling realloc, and removing the ALLOCATED variable.
4632 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4634 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4635 But keep the doprint source code for now, as we might revamp it
4636 and use it again (Bug#8435).
4637 * lisp.h (doprnt): Remove.
4638 * Makefile.in (base_obj): Remove doprnt.o.
4639 * deps.mk (doprnt.o): Remove.
4641 error: Print 32- and 64-bit integers portably (Bug#8435).
4642 Without this change, on typical 64-bit hosts error ("...%d...", N)
4643 was used to print both 32- and 64-bit integers N, which relied on
4645 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4647 * lisp.h (error, verror): Mark as printf-like functions.
4648 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4649 Report overflow in size calculations when allocating printf buffer.
4650 Do not truncate output string at its first null byte.
4651 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4652 Truncate the output at a character boundary, since vsnprintf does not
4654 * charset.c (check_iso_charset_parameter): Convert internal
4655 character to string before calling 'error', since %c now has the
4657 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4658 overflow when computing char to be passed to 'error'. Do not
4659 pass Lisp_Object to 'error'; pass the integer instead.
4660 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4661 formatted with plain %d.
4663 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4665 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4667 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4669 * xterm.c (x_catch_errors): Remove duplicate declaration.
4671 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4673 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4675 2011-04-10 Jim Meyering <meyering@redhat.com>
4677 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4678 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4679 return ssize_t not "int", and use size_t as the buffer length.
4680 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4681 * gnutls.h: Update declarations.
4682 * process.c (read_process_output): Use ssize_t, to match.
4683 (send_process): Likewise.
4685 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4687 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4689 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4691 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4692 Use unsigned char, to match FcChar8 type definition.
4694 * xterm.c (handle_one_xevent):
4695 * xmenu.c (create_and_show_popup_menu):
4696 * xselect.c (x_decline_selection_request)
4697 (x_reply_selection_request): Avoid type-punned deref of X events.
4699 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4701 Fix some uses of `int' instead of EMACS_INT.
4702 * search.c (string_match_1, fast_string_match)
4703 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4704 (scan_buffer, find_next_newline_no_quit)
4705 (find_before_next_newline, search_command, Freplace_match)
4706 (Fmatch_data): Make some `int' variables be EMACS_INT.
4708 * xdisp.c (display_count_lines): 3rd argument and return value now
4709 EMACS_INT. All callers changed.
4710 (pint2hrstr): Last argument is now EMACS_INT.
4712 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4713 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4714 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4715 (decode_coding_utf_16, decode_coding_emacs_mule)
4716 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4717 (decode_coding_ccl, decode_coding_charset)
4718 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4719 (decode_coding_iso_2022, decode_coding_emacs_mule)
4720 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4721 <char_offset, last_offset>: Declare EMACS_INT.
4722 (encode_coding_utf_8, encode_coding_utf_16)
4723 (encode_coding_emacs_mule, encode_invocation_designation)
4724 (encode_designation_at_bol, encode_coding_iso_2022)
4725 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4726 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4728 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4729 (encode_invocation_designation): Last argument P_NCHARS is now
4731 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4732 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4734 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4737 * ccl.c (Fccl_execute_on_string): Declare some variables
4740 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4742 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4744 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4746 * process.c (Fformat_network_address): Doc fix.
4748 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4750 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4752 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4754 * keyboard.c (read_char): Call Lisp function help-form-show,
4755 instead of using internal_with_output_to_temp_buffer.
4756 (Qhelp_form_show): New var.
4757 (syms_of_keyboard): Use DEFSYM macro.
4759 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4761 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4763 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4765 * process.c (Flist_processes): Remove to Lisp.
4766 (list_processes_1): Delete.
4768 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4770 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4772 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4774 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4776 Fix more problems found by GCC 4.6.0's static checks.
4778 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4780 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4782 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4784 * xdisp.c (vmessage): Mark as a printf-like function.
4786 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4788 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4790 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4791 printf-like functions.
4792 (tiff_load): Add casts to remove these marks before passing them
4793 to system-supplied API.
4795 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4797 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4798 This avoids several warnings with gcc -Wstrict-overflow.
4799 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4800 directly, rather than having caller test rule sign. This avoids
4801 some unnecessary tests.
4802 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4803 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4804 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4806 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4807 (xfont_open): Avoid unnecessary tests.
4809 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4811 * composite.h, composite.c (composition_gstring_put_cache):
4812 Use EMACS_INT, not int, for length.
4814 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4815 breaking out part of COMPOSITION_DECODE_RULE.
4816 (COMPOSITION_DECODE_RULE): Use it.
4817 * composite.c (get_composition_id): Remove unused local vars,
4818 by using the new macro.
4820 * textprop.c (set_text_properties_1): Change while to do-while,
4821 since the condition is always true at first.
4823 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4824 (interval_deletion_adjustment): Return unsigned value.
4827 * process.c (list_processes_1, create_pty, read_process_output):
4828 (exec_sentinel): Remove vars that were set but not used.
4829 (create_pty): Remove unnecessary "volatile"s.
4830 (Fnetwork_interface_info): Avoid possibility of int overflow.
4831 (read_process_output): Do adaptive read buffering even if carryover.
4832 (read_process_output): Simplify nbytes computation if buffered.
4834 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4836 * syntax.c (scan_words): Remove var that was set but not used.
4837 (update_syntax_table): Use unsigned instead of int.
4839 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4840 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4841 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4843 * print.c (print_error_message): Avoid int overflow.
4845 * font.c (font_list_entities): Redo for clarity,
4846 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4848 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4849 (font_score): Avoid potential overflow in diff calculation.
4851 * fns.c (substring_both): Remove var that is set but not used.
4852 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4854 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4856 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4857 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4858 can always succeed if overflow has undefined behavior.
4860 * search.c (boyer_moore, wordify): Remove vars set but not used.
4861 (wordify): Omit three unnecessary tests.
4863 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4864 All callers changed. This avoids the need for an unused var.
4866 * casefiddle.c (casify_region): Remove var that is set but not used.
4868 * dired.c (file_name_completion): Remove var that is set but not used.
4870 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4872 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4873 (Finsert_file_contents): Remove unnecessary code checking fd.
4875 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4876 Check for integer overflow on size calculations.
4878 * buffer.c (Fprevious_overlay_change): Remove var that is set
4881 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4882 Remove vars that are set but not used.
4883 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4884 (timer_check_2): Mark vars as initialized.
4886 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4888 * image.c (lookup_image): Remove var that is set but not used.
4889 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4891 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4892 that are set but not used.
4894 * xfns.c (make_invisible_cursor): Don't return garbage
4895 if XCreateBitmapFromData fails (Bug#8410).
4897 * xselect.c (x_get_local_selection, x_handle_property_notify):
4898 Remove vars that are set but not used.
4900 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4901 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4903 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4904 Remove var that is set but not used.
4905 (scroll_bar_windows_size): Now size_t, not int.
4906 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4909 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4910 (map_tty_color) [!defined MSDOS]: Likewise.
4912 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4914 * coding.c: Remove vars that are set but not used.
4915 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4916 All callers changed.
4917 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4918 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4919 (decode_coding_charset): Remove vars that are set but not used.
4921 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4922 that is set but not used.
4924 * print.c (print_object): Remove var that is set but not used.
4926 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4927 The gnulib version avoids calling malloc in the usual case,
4928 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4929 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4930 * filelock.c (current_lock_owner): Likewise.
4931 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4932 * sysdep.c: Include allocator.h, careadlinkat.h.
4933 (emacs_no_realloc_allocator): New static constant.
4934 (emacs_readlink): New function.
4935 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4936 ../lib/careadlinkat.h.
4938 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4940 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4941 first non-nil return value).
4943 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4945 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4946 if not defined (Bug#8403).
4948 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4950 * xdisp.c (display_count_lines): Remove parameter `start',
4951 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4952 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4953 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4954 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4955 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4956 and thereabouts. All callers changed.
4957 (get_per_char_metric): Remove parameter `f', unused since
4958 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4960 2011-04-02 Jim Meyering <meyering@redhat.com>
4962 do not dereference NULL upon failed strdup
4963 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4964 (ns_get_family): Likewise.
4966 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4968 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4970 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4972 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4975 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4977 Add lexical binding.
4979 * window.c (Ftemp_output_buffer_show): New fun.
4980 (Fsave_window_excursion):
4981 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4983 * lread.c (lisp_file_lexically_bound_p): New function.
4984 (Fload): Bind Qlexical_binding.
4985 (readevalloop): Remove `evalfun' arg.
4986 Bind Qinternal_interpreter_environment.
4987 (Feval_buffer): Bind Qlexical_binding.
4988 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4990 (syms_of_lread): Declare `lexical-binding'.
4992 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4994 * keyboard.c (eval_dyn): New fun.
4995 (menu_item_eval_property): Use it.
4997 * image.c (parse_image_spec): Use Ffunctionp.
4999 * fns.c (concat, mapcar1): Accept byte-code-functions.
5001 * eval.c (Fsetq): Handle lexical vars.
5002 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5003 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5004 (FletX, Flet): Obey lexical binding.
5005 (Fcommandp): Handle closures.
5006 (Feval): New `lexical' arg.
5007 (eval_sub): New function extracted from Feval. Use it almost
5008 everywhere where Feval was used. Look up vars in lexical env.
5010 (Ffunctionp): Move from subr.el.
5011 (Ffuncall): Handle closures.
5012 (apply_lambda): Remove `eval_flags'.
5013 (funcall_lambda): Handle closures and new byte-code-functions.
5014 (Fspecial_variable_p): New function.
5015 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5016 but without exporting it to Lisp.
5018 * doc.c (Fdocumentation, store_function_docstring):
5019 * data.c (Finteractive_form): Handle closures.
5021 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5024 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5026 (exec_byte_code): New function extracted from Fbyte_code to handle new
5027 calling convention for byte-code-functions. Add new byte-codes.
5029 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5031 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5033 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5035 * xdisp.c (redisplay_internal): Fix prototype.
5037 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5039 * xdisp.c (SCROLL_LIMIT): New macro.
5040 (try_scrolling): Use it when setting scroll_limit.
5041 Limit scrolling to 100 screen lines.
5042 (redisplay_window): Even when falling back on "recentering",
5043 position point in the window according to scroll-conservatively,
5044 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5046 (try_scrolling): When point is above the window, allow searching
5047 as far as scroll_max, or one screenful, to compute vertical
5048 distance from PT to the scroll margin position. This prevents
5049 try_scrolling from unnecessarily failing when
5050 scroll-conservatively is set to a value slightly larger than the
5051 window height. Clean up the case of PT below the margin at bottom
5052 of window: scroll_max can no longer be INT_MAX. When aggressive
5053 scrolling is in use, don't let point enter the opposite scroll
5054 margin as result of the scroll.
5055 (syms_of_xdisp) <scroll-conservatively>: Document the
5056 threshold of 100 lines for never-recentering scrolling.
5058 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5060 * dispextern.h (move_it_by_lines):
5061 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5062 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5063 (message_log_check_duplicate): Remove parameters `prev_bol' and
5064 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5065 (redisplay_internal): Remove parameter `preserve_echo_area',
5066 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5068 * indent.c (Fvertical_motion):
5069 * window.c (window_scroll_pixel_based, Frecenter):
5070 Don't pass `need_y_p' to `move_it_by_lines'.
5072 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5074 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5075 steal a few bits to be more compact.
5076 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5077 Remove unneeded casts.
5079 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5081 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5083 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5084 binding" message (bug#7967).
5086 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5088 Fix more problems found by GCC 4.6.0's static checks.
5090 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5091 Remove unused local var.
5093 * editfns.c (Fmessage_box): Remove unused local var.
5095 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5096 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5097 Omit unused local vars.
5098 * window.c (shrink_windows): Omit unused local var.
5099 * menu.c (digest_single_submenu): Omit unused local var.
5100 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5101 Omit unused local var.
5103 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5104 Don't assume string length fits in int.
5105 (keyremap_step, read_key_sequence): Use size_t for sizes.
5106 (read_key_sequence): Don't check last_real_key_start redundantly.
5108 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5109 instead of alloca (Bug#8344).
5111 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5112 (Fbacktrace_frame): Don't assume nframes fits in int.
5114 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5116 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5119 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5121 * cm.c (calccost): Turn while-do into do-while, for clarity.
5123 * keyboard.c (syms_of_keyboard): Use the same style as later
5124 in this function when indexing through an array. This also
5125 works around GCC bug 48267.
5127 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5129 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5131 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5132 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5134 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5135 This avoids undefined behavior on integer overflow, and is a bit
5136 more convenient anyway since it is compared to a size_t variable.
5138 Variadic C functions now count arguments with size_t, not int.
5139 This avoids an unnecessary limitation on 64-bit machines, which
5140 caused (substring ...) to crash on large vectors (Bug#8344).
5141 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5142 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5143 All variadic functions and their callers changed accordingly.
5144 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5145 * data.c (arith_driver, float_arith_driver): Likewise.
5146 * editfns.c (general_insert_function): Likewise.
5147 * eval.c (struct backtrace.nargs, interactive_p)
5148 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5149 (funcall_lambda, mark_backtrace): Likewise.
5150 * fns.c (concat): Likewise.
5151 * frame.c (x_set_frame_parameters): Likewise.
5152 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5153 0 if not found, not -1. All callers changed.
5155 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5156 (stack_copy_size): Now size_t, not int.
5157 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5159 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5161 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5162 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5163 All callers changed.
5165 * lisp.h (multibyte_char_to_unibyte):
5166 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5167 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5168 * character.h (CHAR_TO_BYTE8):
5169 * cmds.c (internal_self_insert):
5170 * editfns.c (general_insert_function):
5171 * keymap.c (push_key_description):
5172 * search.c (Freplace_match):
5173 * xdisp.c (message_dolog, set_message_1): All callers changed.
5175 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5177 * keyboard.c (safe_run_hook_funcall): New function.
5178 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5179 don't set the hook to nil, but remove the offending function instead.
5180 (Qcommand_hook_internal): Remove, unused.
5181 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5182 Vcommand_hook_internal.
5184 * eval.c (enum run_hooks_condition): Remove.
5185 (funcall_nil, funcall_not): New functions.
5186 (run_hook_with_args): Call each function through a `funcall' argument.
5187 Remove `cond' argument, now redundant.
5188 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5189 (Frun_hook_with_args_until_failure): Adjust accordingly.
5190 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5192 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5194 * dispextern.h (string_buffer_position): Remove declaration.
5196 * print.c (strout): Remove parameter `multibyte', unused since
5197 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5199 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5200 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5201 All callers changed.
5203 * w32.c (_wsa_errlist): Use braces for struct initializers.
5205 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5206 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5207 All callers changed.
5208 (string_buffer_position): Likewise. Also, make static (it's never
5209 used outside xdisp.c).
5210 (cursor_row_p): Remove parameter `w', unused since
5211 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5212 (decode_mode_spec): Remove parameter `precision', introduced during
5213 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5214 All callers changed.
5216 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5218 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5220 2011-03-27 Anders Lindgren <andlind@gmail.com>
5222 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5223 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5224 (ns_update_auto_hide_menu_bar): New functions.
5225 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5226 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5227 ns_constrain_all_frames.
5228 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5229 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5231 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5233 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5235 2011-03-27 Glenn Morris <rgm@gnu.org>
5237 * syssignal.h: Replace RETSIGTYPE with void.
5238 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5239 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5240 Replace SIGTYPE with void everywhere.
5241 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5242 * s/template.h (SIGTYPE): Remove commented out definition.
5244 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5246 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5247 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5249 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5251 * w32.c (read_unc_volume): Use parameter `henum', instead of
5252 global variable `wget_enum_handle'.
5254 * keymap.c (describe_vector): Remove parameters `indices' and
5255 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5256 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5258 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5260 * keyboard.c (timer_check): Remove parameter `do_it_now',
5261 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5262 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5263 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5265 * keyboard.c (read_char):
5266 * w32menu.c (w32_menu_display_help):
5267 * xmenu.c (show_help_event, menu_help_callback):
5268 Adjust calls to `show_help_echo'.
5270 * gtkutil.c (xg_maybe_add_timer):
5271 * keyboard.c (readable_events):
5272 * process.c (wait_reading_process_output):
5273 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5275 * insdel.c (adjust_markers_gap_motion):
5276 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5277 (gap_left, gap_right): Don't call it.
5279 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5281 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5282 incurred during fontification.
5284 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5286 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5287 (DEFVAR_PER_BUFFER): Don't pass it.
5289 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5290 (scrolling_window): Don't pass it.
5292 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5294 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5296 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5298 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5299 of variables specific to SELinux and computation of `encoded_absname'.
5301 * image.c (XPutPixel): Remove unused variable `height'.
5303 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5305 * unexw32.c (get_section_info): Remove unused variable `section'.
5307 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5308 (system_process_attributes): Remove unused variable `sess'.
5309 (sys_read): Remove unused variable `err'.
5311 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5312 (w32_wnd_proc): Remove unused variable `isdead'.
5313 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5314 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5315 (x_create_tip_frame): Remove unused variable `tem'.
5317 * w32inevt.c (w32_console_read_socket):
5318 Remove unused variable `no_events'.
5320 * w32term.c (x_draw_composite_glyph_string_foreground):
5321 Remove unused variable `width'.
5323 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5325 * w32term.c (x_set_glyph_string_clipping):
5326 Don't pass uninitialized region to CombineRgn.
5328 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5330 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5331 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5332 (Fx_close_connection): Remove unused variable `i'.
5334 * w32font.c (w32font_draw): Return number of glyphs.
5335 (w32font_open_internal): Remove unused variable `i'.
5336 (w32font_driver): Add missing initializer.
5338 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5339 (fill_in_menu): Remove unused variable `items_added'.
5341 * w32term.c (last_mouse_press_frame): Remove static global variable.
5342 (w32_clip_to_row): Remove unused variable `f'.
5343 (x_delete_terminal): Remove unused variable `i'.
5345 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5346 (NOTHING): Remove unused static global variable.
5347 (uniscribe_check_otf): Remove unused variable `table'.
5348 (uniscribe_font_driver): Add missing initializers.
5350 2011-03-23 Julien Danjou <julien@danjou.info>
5352 * term.c (Fsuspend_tty, Fresume_tty):
5353 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5354 * window.c (temp_output_buffer_show):
5355 * insdel.c (signal_before_change):
5356 * frame.c (Fhandle_switch_frame):
5357 * fileio.c (Fdo_auto_save):
5358 * emacs.c (Fkill_emacs):
5359 * editfns.c (save_excursion_restore):
5360 * cmds.c (internal_self_insert):
5361 * callint.c (Fcall_interactively):
5362 * buffer.c (Fkill_all_local_variables):
5363 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5365 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5366 unconditionnaly since it does the check itself.
5368 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5370 Fix more problems found by GCC 4.5.2's static checks.
5372 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5373 the first time through the loop, since we know p0 < p1 then.
5374 This also avoids a gcc -Wstrict-overflow warning.
5376 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5377 leading to a memory leak, possible in functions like
5378 load_charset_map_from_file that can allocate an unbounded number
5379 of objects (Bug#8318).
5381 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5382 that could (at least in theory) be that large.
5384 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5385 This is less likely to overflow, and avoids undefined behavior if
5386 overflow does occur. All callers changed. Use strtoul to scan
5387 for the unsigned long integer.
5388 (pint2hrstr): Simplify and tune code slightly.
5389 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5391 * scroll.c (do_scrolling): Work around GCC bug 48228.
5392 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5394 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5395 This also avoids a warning with gcc -Wstrict-overflow.
5396 (validate_x_resource_name): Simplify count usage.
5397 This also avoids a warning with gcc -Wstrict-overflow.
5399 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5402 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5404 * process.c (Fmake_network_process): Use socklen_t, not int,
5405 where POSIX says socklen_t is required in portable programs.
5406 This fixes a porting bug on hosts like 64-bit HP-UX, where
5407 socklen_t is wider than int (Bug#8277).
5408 (Fmake_network_process, server_accept_connection):
5409 (wait_reading_process_output, read_process_output):
5412 * process.c: Rename or move locals to avoid shadowing.
5413 (list_processes_1, Fmake_network_process):
5414 (read_process_output_error_handler, exec_sentinel_error_handler):
5415 Rename or move locals.
5416 (Fmake_network_process): Define label "retry_connect" only if needed.
5417 (Fnetwork_interface_info): Fix pointer signedness.
5418 (process_send_signal): Add cast to avoid pointer signedness problem.
5419 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5420 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5422 Make tparam.h and terminfo.c consistent.
5423 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5424 Include tparam.h instead, since it declares them.
5425 * cm.h (PC): Remove extern decl; tparam.h now does this.
5426 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5427 * terminfo.c: Include tparam.h, to check interfaces.
5428 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5429 (tparam): Adjust signature to match interface in tparam.h;
5430 this removes some undefined behavior. Check that outstring and len
5431 are zero, which they always are with Emacs.
5432 * tparam.h (PC, BC, UP): New extern decls.
5434 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5435 (xftfont_open): Rename locals to avoid shadowing.
5437 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5438 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5439 (OTF_TAG_SYM): Omit macro if not needed.
5440 (ftfont_list): Remove unused local.
5441 (get_adstyle_property, ftfont_pattern_entity):
5442 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5443 Rename locals to avoid shadowing.
5445 * xfont.c (xfont_list_family): Mark var as initialized.
5447 * xml.c (make_dom): Now static.
5449 * composite.c (composition_compute_stop_pos): Rename local to
5451 (composition_reseat_it): Remove unused locals.
5452 (find_automatic_composition, composition_adjust_point): Likewise.
5453 (composition_update_it): Mark var as initialized.
5454 (find_automatic_composition): Mark vars as initialized,
5455 with a FIXME (Bug#8290).
5457 character.h: Rename locals to avoid shadowing.
5458 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5459 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5460 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5461 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5464 * textprop.c (property_change_between_p): Remove; unused.
5466 * intervals.c (interval_start_pos): Now static.
5468 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5470 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5471 Rename locals to avoid shadowing.
5473 * sound.c (wav_play, au_play, Fplay_sound_internal):
5474 Fix pointer signedness.
5475 (alsa_choose_format): Remove unused local var.
5476 (wav_play): Initialize a variable to 0, to prevent undefined
5477 behavior (Bug#8278).
5479 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5481 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5483 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5484 clobbering (Bug#8298).
5485 * sysdep.c (sys_subshell): Likewise.
5486 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5488 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5489 This should get cleaned up, so that child_setup has the
5490 same signature on all platforms.
5492 * callproc.c (call_process_cleanup): Now static.
5493 (relocate_fd): Rename locals to avoid shadowing.
5495 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5497 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5498 not to be necessary, and produces flickering.
5500 2011-03-20 Glenn Morris <rgm@gnu.org>
5502 * config.in: Remove file.
5504 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5506 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5507 are now in src/globals.h.
5508 (syms_of_minibuf): Remove spurious & from previous change.
5510 2011-03-20 Leo <sdl.web@gmail.com>
5512 * minibuf.c (completing-read-function): New variable.
5513 (completing-read-default): Rename from completing-read.
5514 (completing-read): Call completing-read-function.
5516 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5518 * xfaces.c (Fx_load_color_file):
5519 Read color file from absolute filename (bug#8250).
5521 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5523 * makefile.w32-in: Update dependencies.
5525 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5527 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5529 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5531 Fix more problems found by GCC 4.5.2's static checks.
5533 * process.c (make_serial_process_unwind, send_process_trap):
5534 (sigchld_handler): Now static.
5536 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5537 That way, the code declares only the vars that it needs.
5538 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5539 * s/cygwin.h (PTY_ITERATION): Likewise.
5540 * s/darwin.h (PTY_ITERATION): Likewise.
5541 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5543 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5544 * process.c (allocate_pty): Don't declare stb unless it's needed.
5546 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5547 (CONSTANTLIM): Remove; unused.
5548 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5549 Define only if needed.
5551 * unexelf.c (unexec): Name an expression,
5552 to avoid gcc -Wbad-function-cast warning.
5553 Use a different way to cause a compilation error if anyone uses
5554 n rather than nn, a way that does not involve shadowing.
5555 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5557 * deps.mk (unexalpha.o): Remove; unused.
5559 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5560 * unexec.h: New file.
5561 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5562 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5564 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5565 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5566 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5567 Change as necessary to match prototype in unexec.h.
5569 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5571 (back_comment, skip_chars): Mark vars as initialized.
5573 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5574 Rename locals to avoid shadowing.
5576 * lread.c (read1): Rewrite so as not to use empty "else".
5577 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5579 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5581 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5582 warning when compiling print.c.
5584 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5585 instead of using an uninitialized var.
5586 (font_sort_entities): Mark var as initialized.
5588 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5590 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5591 pointers to constants.
5592 (font_parse_fcname): Remove unused vars.
5593 (font_delete_unmatched): Now static.
5594 (font_get_spec): Remove; unused.
5595 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5596 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5597 Rename or move locals to avoid shadowing.
5599 * fns.c (require_nesting_list, require_unwind): Now static.
5600 (Ffillarray): Rename locals to avoid shadowing.
5602 * floatfns.c (domain_error2): Define only if needed.
5603 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5605 * alloc.c (mark_backtrace): Move decl from here ...
5606 * lisp.h: ... to here, so that it can be checked.
5608 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5609 (Fdefvar): Rewrite so as not to use empty "else".
5610 (lisp_indirect_variable): Name an expression,
5611 to avoid gcc -Wbad-function-cast warning.
5612 (Fdefvar): Rename locals to avoid shadowing.
5614 * callint.c (quotify_arg, quotify_args): Now static.
5615 (Fcall_interactively): Rename locals to avoid shadowing.
5616 Use const pointer when appropriate.
5618 * lisp.h (get_system_name, get_operating_system_release):
5619 Move decls here, to check interfaces.
5620 * process.c (get_operating_system_release): Move decl to lisp.h.
5621 * xrdb.c (get_system_name): Likewise.
5622 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5623 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5624 some of which prompt warnings from gcc -Wbad-function-cast.
5625 (Fformat_time_string, Fencode_time, Finsert_char):
5626 (Ftranslate_region_internal, Fformat):
5627 Rename or remove local vars to avoid shadowing.
5628 (Ftranslate_region_internal): Mark var as initialized.
5630 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5633 * lisp.h (eassert): Check that the argument compiles, even if
5634 ENABLE_CHECKING is not defined.
5636 * data.c (Findirect_variable): Name an expression, to avoid
5637 gcc -Wbad-function-cast warning.
5638 (default_value, arithcompare, arith_driver, arith_error): Now static.
5639 (store_symval_forwarding): Rename local to avoid shadowing.
5640 (Fmake_variable_buffer_local, Fmake_local_variable):
5641 Mark variables as initialized.
5642 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5644 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5645 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5646 Rename locals to avoid shadowing.
5647 (mark_stack): Move local variables into the #ifdef region where
5649 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5650 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5652 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5653 (GC_STRING_CHARS): Remove; not used.
5654 (Fmemory_limit): Cast sbrk's returned value to char *.
5656 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5657 avoids undefined behavior in theory.
5659 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5661 Use functions, not macros, for up- and down-casing (Bug#8254).
5662 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5663 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5664 to use the following functions instead of these macros.
5665 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5666 EMACS_INT, since callers assume the returned value fits in int.
5667 (upcase1): Likewise, for UPCASE_TABLE.
5668 (uppercasep, lowercasep, upcase): New static inline functions.
5669 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5670 the race-condition problem in the old DOWNCASE.
5672 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5673 Rename locals to avoid shadowing.
5674 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5675 (regex_compile, re_search_2, re_match_2_internal):
5676 Remove unused local vars.
5677 (FREE_VAR): Rewrite so as not to use empty "else",
5678 which gcc can warn about.
5679 (regex_compile, re_match_2_internal): Mark locals as initialized.
5680 (RETALLOC_IF): Define only if needed.
5681 (WORDCHAR_P): Likewise. This one is never needed, but is used
5682 only in a comment talking about a compiler bug, so put inside
5683 the #if 0 of that comment.
5684 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5685 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5688 * search.c (boyer_moore): Rename locals to avoid shadowing.
5689 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5690 (PREV_CHAR_BOUNDARY): Likewise.
5692 * search.c (simple_search): Remove unused var.
5694 * dired.c (compile_pattern): Move decl from here ...
5695 * lisp.h: ... to here, so that it can be checked.
5696 (struct re_registers): New forward decl.
5698 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5700 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5702 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5703 Rename locals to avoid shadowing.
5704 (Fvertical_motion): Mark locals as initialized.
5706 * casefiddle.c (casify_object, casify_region): Now static.
5707 (casify_region): Mark local as initialized.
5709 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5711 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5712 New macros, so that the caller can use some names other than
5713 gcpro1, gcpro2, etc.
5714 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5716 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5717 argument, for consistency with GCPRO2_VAR, etc: it is now the
5718 prefix of the variable, not the variable itself. All uses
5720 * dired.c (directory_files_internal, file_name_completion):
5721 Rename locals to avoid shadowing.
5723 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5724 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5725 dired.c's scmp function, had undefined behavior.
5726 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5727 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5728 * buffer.h: ... to here, because these macros use current_buffer,
5729 and the new implementation with inline functions needs to have
5730 current_buffer in scope now, rather than later when the macros
5732 (downcase, upcase1): New static inline functions.
5733 (DOWNCASE, UPCASE1): Reimplement using these functions.
5734 This avoids undefined behavior in expressions like
5735 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5736 from race conditions in accessing the global variables
5737 case_temp1 and case_temp2.
5738 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5739 * lisp.h (case_temp1, case_temp2): Remove their decls.
5740 * character.h (ASCII_CHAR_P): Move from here ...
5741 * lisp.h: ... to here, so that the inline functions mentioned
5744 * dired.c (directory_files_internal_unwind): Now static.
5746 * fileio.c (file_name_as_directory, directory_file_name):
5747 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5749 (file_name_as_directory): Use const pointers when appropriate.
5750 (Fexpand_file_name): Likewise. In particular, newdir might
5751 point at constant storage, so make it a const pointer.
5752 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5753 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5755 (Fset_file_times, Finsert_file_contents, auto_save_error):
5756 Rename locals to avoid shadowing.
5758 * minibuf.c (choose_minibuf_frame_1): Now static.
5759 (Ftry_completion, Fall_completions): Rename or remove locals
5762 * marker.c (bytepos_to_charpos): Remove; unused.
5764 * lisp.h (verify_bytepos, count_markers): New decls,
5765 so that gcc does not warn that these functions aren't declared.
5767 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5768 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5769 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5770 (copy_text): Remove unused local var.
5772 * filelock.c (within_one_second): Now static.
5773 (lock_file_1): Rename local to avoid shadowing.
5775 * buffer.c (fix_overlays_before): Mark locals as initialized.
5776 (fix_start_end_in_overlays): Likewise. This function should be
5777 simplified by using pointers-to-pointers, but that's a different
5779 (switch_to_buffer_1): Now static.
5780 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5781 (report_overlay_modification): Rename locals to avoid shadowing.
5783 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5784 Fix pointer signedness issue.
5785 (sys_subshell): Mark local as volatile if checking for lint,
5786 to suppress a gcc -Wclobbered warning that does not seem to be right.
5787 (MAXPATHLEN): Define only if needed.
5789 * process.c (serial_open, serial_configure): Move decls from here ...
5790 * systty.h: ... to here, so that they can be checked.
5792 * fns.c (get_random, seed_random): Move extern decls from here ...
5793 * lisp.h: ... to here, so that they can be checked.
5795 * sysdep.c (reset_io): Now static.
5796 (wait_for_termination_signal): Remove; unused.
5798 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5799 (copy_keymap_item, append_key, push_text_char_description):
5801 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5802 (DENSE_TABLE_SIZE): Remove; unused.
5803 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5804 (describe_map_tree):
5805 Rename locals to avoid shadowing.
5807 * keyboard.c: Declare functions static if they are not used elsewhere.
5808 (echo_char, echo_dash, cmd_error, top_level_2):
5809 (poll_for_input, handle_async_input): Now static.
5810 (read_char, kbd_buffer_get_event, make_lispy_position):
5811 (make_lispy_event, make_lispy_movement, apply_modifiers):
5812 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5813 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5814 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5815 (read_key_sequence, read_char): Mark locals as initialized.
5816 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5818 * keyboard.h (make_ctrl_char): New decl.
5819 (mark_kboards): Move decl here ...
5820 * alloc.c (mark_kboards): ... from here.
5822 * lisp.h (force_auto_save_soon): New decl.
5824 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5825 (DEFINE_DUMMY_FUNCTION): New macro.
5826 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5828 (main): Add casts to avoid warnings
5829 if GCC considers string literals to be constants.
5831 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5833 * dbusbind.c: Pointer signedness fixes.
5834 (xd_signature, xd_append_arg, xd_initialize):
5835 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5836 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5837 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5838 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5840 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5841 if GCC considers string literals to be constants.
5842 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5844 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5846 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5847 (print_preprocess, print_object): New macro to fix last change.
5849 * print.c (print_preprocess): Don't forget font objects.
5851 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5853 * emacs.c (USAGE3): Doc fixes.
5855 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5857 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5860 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5862 * lisp.h (VWindow_system, Qfile_name_history):
5863 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5864 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5865 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5867 * w32select.c: Don't #include "keyboard.h".
5868 (run_protected): Add extern declaration for waiting_for_input.
5870 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5871 * w32console.c (detect_input_pending, read_input_pending)
5872 (encode_terminal_code):
5873 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5874 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5875 (w32_system_caret_y, Qfile_name_history):
5876 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5877 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5878 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5879 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5880 * w32proc.c (Qlocal, report_file_error):
5881 * w32term.c (Vwindow_system, updating_frame):
5882 * w32uniscribe.c (initialized, uniscribe_font_driver):
5883 Remove unneeded extern declarations.
5885 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5887 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5889 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5891 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5892 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5893 These macros can no longer be used for assignment.
5895 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5896 Assign struct members directly, instead of using BUF_BEGV etc.
5897 (record_buffer_markers, fetch_buffer_markers): New functions for
5898 recording and fetching special buffer markers.
5899 (set_buffer_internal_1, set_buffer_temp): Use them.
5901 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5903 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5905 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5906 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5908 * xdisp.c (hscroll_window_tree):
5909 (reconsider_clip_changes): Use PT instead of BUF_PT.
5911 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5913 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5914 $(EMACS_ROOT)/lib/intprops.h.
5916 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5918 Fix more problems found by GCC 4.5.2's static checks.
5920 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5921 to unsigned char * to avoid compiler diagnostic.
5922 (xg_free_frame_widgets): Make it clear that a local variable is
5923 needed only if USE_GTK_TOOLTIP.
5924 (gdk_window_get_screen): Make it clear that this macro is needed
5925 only if USE_GTK_TOOLTIP.
5926 (int_gtk_range_get_value): New function, which avoids a diagnostic
5927 from gcc -Wbad-function-cast.
5928 (xg_set_toolkit_scroll_bar_thumb): Use it.
5929 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5930 diagnostic from gcc -Wbad-function-cast.
5931 (get_utf8_string, xg_get_file_with_chooser):
5932 Rename locals to avoid shadowing.
5933 (create_dialog): Move locals to avoid shadowing.
5935 * xgselect.c (xg_select): Remove unused var.
5937 * image.c (four_corners_best): Mark locals as initialized.
5938 (gif_load): Initialize transparent_p to zero (Bug#8238).
5939 Mark another local as initialized.
5940 (my_png_error, my_error_exit): Mark with NO_RETURN.
5942 * image.c (clear_image_cache): Now static.
5943 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5944 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5945 (x_edge_detection): Remove unnecessary cast that
5946 gcc -Wbad-function-cast diagnoses.
5947 (gif_load): Fix pointer signedness.
5948 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5949 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5951 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5953 Improve quality of tests for time stamp overflow.
5954 For example, without this patch (encode-time 0 0 0 1 1
5955 1152921504606846976) returns the obviously-bogus value (-948597
5956 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5957 reports time overflow. See
5958 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5959 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5960 * editfns.c: Include limits.h and intprops.h.
5961 (TIME_T_MIN, TIME_T_MAX): New macros.
5962 (time_overflow): Move earlier, to before first use.
5963 (hi_time, lo_time): New functions, for an accurate test for
5965 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5966 (Fget_internal_run_time): Don't assume time_t fits in int.
5967 (make_time): Use list2 instead of Fcons twice.
5968 (Fdecode_time): More accurate test for out-of-range times.
5969 (check_tm_member): New function.
5970 (Fencode_time): Use it, to test for out-of-range times.
5971 (lisp_time_argument): Don't rely on undefined left-shift and
5972 right-shift behavior when checking for time stamp overflow.
5974 * editfns.c (time_overflow): New function, refactoring common code.
5975 (Fformat_time_string, Fdecode_time, Fencode_time):
5976 (Fcurrent_time_string): Use it.
5978 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5979 * dired.c (make_time): Move to ...
5980 * editfns.c (make_time): ... here.
5981 * systime.h: Note the move.
5983 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5985 * fringe.c (update_window_fringes): Remove unused variables.
5987 * unexmacosx.c (copy_data_segment): Also copy __got section.
5990 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5992 * termcap.c [MSDOS]: Include "msdos.h".
5993 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5994 Constify `char *' arguments and their references according to
5995 prototypes in tparam.h.
5997 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5999 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6000 Adapt all references accordingly.
6002 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6004 2011-03-11 Tom Tromey <tromey@redhat.com>
6006 * buffer.c (syms_of_buffer): Remove obsolete comment.
6008 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6010 * termhooks.h (encode_terminal_code): Declare prototype.
6012 * msdos.c (encode_terminal_code): Don't declare prototype.
6014 * term.c (encode_terminal_code): Now external again, used by
6015 w32console.c and msdos.c.
6017 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6018 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6020 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6022 Fix some minor problems found by GCC 4.5.2's static checks.
6024 * fringe.c (update_window_fringes): Mark locals as initialized
6026 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6028 * alloc.c (mark_fringe_data): Move decl from here ...
6029 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6030 to check its interface.
6031 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6033 * fontset.c (free_realized_fontset): Now static.
6034 (Fset_fontset_font): Rename local to avoid shadowing.
6035 (fontset_font): Mark local as initialized.
6036 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6038 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6040 * xselect.c (x_disown_buffer_selections): Remove; not used.
6041 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6042 (x_own_selection, Fx_disown_selection_internal): Rename locals
6044 (x_handle_dnd_message): Remove local to avoid shadowing.
6046 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6047 so that the caller can use some name other than gcpro1.
6048 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6049 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6050 (Fx_backspace_delete_keys_p):
6051 Use them to avoid shadowing, and rename vars to avoid shadowing.
6052 (x_decode_color, x_set_name, x_window): Now static.
6053 (Fx_create_frame): Add braces to silence GCC warning.
6054 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6055 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6056 Remove unused locals.
6057 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6058 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6059 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6062 * xterm.h (x_mouse_leave): New decl.
6064 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6065 Remove unused functions.
6066 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6067 (x_calc_absolute_position): Now static.
6068 (XTread_socket): Don't define label "out" unless it's used.
6069 Don't declare local "event" unless it's used.
6070 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6071 unless they are used.
6072 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6073 (x_fatal_error_signal): Remove; not used.
6074 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6075 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6076 (x_error_catcher, x_connection_closed, x_error_handler):
6077 (x_error_quitter, xembed_send_message, x_iconify_frame):
6078 (my_log_handler): Rename locals to avoid shadowing.
6079 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6080 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6082 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6083 Rename or move locals to avoid shadowing.
6084 (tty_defined_color, merge_face_heights): Now static.
6085 (free_realized_faces_for_fontset): Remove; not used.
6086 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6087 does not deduce is never used uninitialized.
6088 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6089 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6091 * terminal.c (store_terminal_param): Now static.
6093 * xmenu.c (menu_highlight_callback): Now static.
6094 (set_frame_menubar): Remove unused local.
6095 (xmenu_show): Rename parameter to avoid shadowing.
6096 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6097 since they might point to immutable storage.
6098 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6099 since it's unused otherwise.
6101 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6102 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6103 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6104 avoids a gcc -Wuninitialized diagnostic.
6105 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6106 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6107 does not deduce are never used uninitialized.
6109 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6111 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6112 * window.c (window_loop, size_window):
6113 (run_window_configuration_change_hook, enlarge_window): Likewise.
6115 * window.c (display_buffer): Now static.
6116 (size_window): Mark variables that gcc -Wuninitialized
6117 does not deduce are never used uninitialized.
6118 * window.h (check_all_windows): New decl, to forestall
6119 gcc -Wmissing-prototypes diagnostic.
6120 * dispextern.h (bidi_dump_cached_states): Likewise.
6122 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6124 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6126 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6127 and to avoid gcc -Wuninitialized warning.
6128 (load_charset_map): Mark variables that gcc -Wuninitialized
6129 does not deduce are never used uninitialized.
6130 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6132 * coding.c (coding_set_source, coding_set_destination):
6133 Use "else { /* comment */ }" rather than "else /* comment */;"
6134 for clarity, and to avoid gcc -Wempty-body warning.
6135 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6136 a block, when the outer 'i' will do.
6137 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6138 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6139 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6140 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6141 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6142 Rename locals to avoid shadowing.
6143 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6144 * coding.c (emacs_mule_char, encode_invocation_designation):
6145 Now static, since they're not used elsewhere.
6146 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6147 (decode_coding_object, encode_coding_object, detect_coding_system):
6148 (decode_coding_emacs_mule): Mark variables that gcc
6149 -Wuninitialized does not deduce are never used uninitialized.
6150 (detect_coding_iso_2022): Initialize a local variable that might
6151 be used uninitialized. Leave a FIXME because it's not clear that
6152 this initialization is needed. (Bug#8211)
6153 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6154 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6155 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6156 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6157 Remove unused macros.
6159 * category.c (hash_get_category_set): Remove unused local var.
6160 (copy_category_table): Now static, since it's not used elsewhere.
6161 * character.c (string_count_byte8): Likewise.
6163 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6164 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6166 * chartab.c (copy_sub_char_table): Now static, since it's not used
6168 (sub_char_table_ref_and_range, char_table_ref_and_range):
6169 Rename locals to avoid shadowing.
6170 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6172 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6173 (BIDI_BOB): Remove unused macro.
6175 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6176 deduce are never used uninitialized.
6177 * term.c (encode_terminal_code): Likewise.
6179 * term.c (encode_terminal_code): Now static. Remove unused local.
6181 * tparam.h: New file.
6182 * term.c, tparam.h: Include it.
6183 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6184 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6185 Move these decls to tparam.h, and make them agree with what
6186 is actually in tparam.c. The previous trick of using incompatible
6187 decls in different modules does not conform to the C standard.
6188 All callers of tparam changed to use tparam's actual API.
6189 * tparam.c (tparam1, tparam, tgoto):
6190 Use const pointers where appropriate.
6192 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6193 * cm.h (struct cm): Likewise.
6194 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6195 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6196 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6197 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6198 (turn_on_face, init_tty): Likewise.
6199 * termchar.h (struct tty_display_info): Likewise.
6201 * term.c (term_mouse_position): Rename local to avoid shadowing.
6203 * alloc.c (mark_ttys): Move decl from here ...
6204 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6206 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6208 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6210 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6212 * search.c (compile_pattern_1): Remove argument regp, unused since
6213 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6214 (compile_pattern): Don't pass it.
6216 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6218 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6219 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6221 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6223 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6225 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6226 gdk_window_get_screen, gdk_window_get_geometry,
6227 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6228 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6229 (xg_get_pixbuf_from_pixmap): New function.
6230 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6231 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6232 Call xg_get_pixbuf_from_pixmap instead of
6233 gdk_pixbuf_get_from_drawable.
6234 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6235 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6236 (xg_check_special_colors): Use GtkStyleContext and its functions
6238 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6239 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6240 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6241 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6242 Call gtk_widget_get_preferred_size.
6243 (xg_frame_resized): gdk_window_get_geometry only takes 5
6245 (xg_win_to_widget, xg_event_is_for_menubar):
6246 Call gdk_x11_window_lookup_for_display.
6247 (xg_set_widget_bg): New function.
6248 (delete_cb): New function.
6249 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6250 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6251 (xg_set_background_color): Call xg_set_widget_bg.
6252 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6253 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6254 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6255 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6257 (update_frame_tool_bar): Call gtk_widget_hide.
6258 (xg_initialize): Use GDK_KEY_g.
6260 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6262 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6264 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6265 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6266 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6268 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6270 * w32xfns.c (select_palette): Check success of RealizePalette against
6271 GDI_ERROR, not zero.
6273 See ChangeLog.11 for earlier changes.
6279 Copyright (C) 2011 Free Software Foundation, Inc.
6281 This file is part of GNU Emacs.
6283 GNU Emacs is free software: you can redistribute it and/or modify
6284 it under the terms of the GNU General Public License as published by
6285 the Free Software Foundation, either version 3 of the License, or
6286 (at your option) any later version.
6288 GNU Emacs is distributed in the hope that it will be useful,
6289 but WITHOUT ANY WARRANTY; without even the implied warranty of
6290 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6291 GNU General Public License for more details.
6293 You should have received a copy of the GNU General Public License
6294 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.