Put the '$Id:' tag into MS-Windows executable of Emacs.
[bpt/emacs.git] / src / ChangeLog
1 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
2
3 configure: new option --enable-gcc-warnings (Bug#11207)
4 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
6 (ALL_CFLAGS): Use new macros rather than old.
7 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
8 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
9 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
10 -Wunused-result, -Wunused-variable. This should go away once
11 the Emacs and Gnulib regex code is merged.
12 (xmalloc, xrealloc): Now static.
13
14 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
15
16 * dired.c (Fsystem_groups): Remove unused local.
17
18 2012-04-17 Glenn Morris <rgm@gnu.org>
19
20 * dired.c (Fsystem_users): Doc fix.
21
22 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
23
24 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
25 (syms_of_dired): Add them.
26
27 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
28
29 Fix minor alloc.c problems found by static checking.
30 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
31 New extern decls, to avoid calling undeclared functions.
32 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
33 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
34 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
35 (NEED_MEM_INSERT): New macro.
36 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
37 Remove one incorrect comment and fix another.
38
39 Fix minor ralloc.c problems found by static checking.
40 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
41 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
42 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
43 (r_alloc_sbrk): Now static.
44
45 Improve ralloc.c interface checking.
46 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
47 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
48 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
49 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
50 [REL_ALLOC]: ... to here, to check interface.
51 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
52 Remove decls. This fixes an "It stinks!".
53
54 * alloc.c (which_symbols): Fix alignment issue / type clash.
55
56 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
57
58 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
59 (struct Lisp_Misc_Any): Likewise.
60 (struct Lisp_Free): Likewise.
61 * alloc.c (union aligned_Lisp_Symbol): Define.
62 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
63 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
64 (union aligned_Lisp_Misc): Define.
65 (MARKER_BLOCK_SIZE, struct marker_block): Use union
66 aligned_Lisp_Misc instead of union Lisp_Misc.
67 (Fmake_symbol, allocate_misc, gc_sweep): Adjust
68
69 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
70
71 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
72 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
73 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
74 * s/netbsd.h, s/sol2-6.h:
75 Remove definition of GC_MARK_STACK, since the default now works.
76 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
77 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
78 no longer the default.
79 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
80
81 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
82
83 * lread.c (lisp_file_lexically_bound_p):
84 Fix hang at ";-*-\n" (bug#11238).
85
86 2012-04-14 Eli Zaretskii <eliz@gnu.org>
87
88 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
89 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
90
91 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
92
93 * nsterm.m (constrainFrameRect): Always constrain when there is only
94 one screen (Bug#10962).
95
96 2012-04-13 Ken Brown <kbrown@cornell.edu>
97
98 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
99
100 2012-04-13 Reuben Thomas <rrt@sc3d.org>
101
102 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
103
104 2012-04-11 Daniel Colascione <dancol@dancol.org>
105
106 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
107 against is gone. It's better to use vfork now so that when Cygwin
108 gains a new, working vfork, we use it automatically (bug#10398).
109
110 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
111
112 * window.c (save_window_save): Obey window-point-insertion-type.
113
114 2012-04-11 Glenn Morris <rgm@gnu.org>
115
116 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
117
118 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
119
120 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
121
122 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
123
124 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
125 (force_quit_count): New var.
126 (handle_interrupt): Use it.
127
128 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
129
130 * w32.c (w32_delayed_load): Record the full path of the library
131 being loaded (bug#10424).
132
133 2012-04-09 Glenn Morris <rgm@gnu.org>
134
135 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
136 not just in the obarray, before snarfing them. (Bug#11036)
137
138 * Makefile.in ($(leimdir)/leim-list.el):
139 Pass EMACS rather than BUILT_EMACS.
140
141 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
142
143 * process.c (make_process):
144 * process.h: Add integer `gnutls_handshakes_tried' member to
145 process struct.
146
147 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
148 Add convenience `GNUTLS_LOG2i' macro.
149
150 * gnutls.c (gnutls_log_function2i): Convenience log function.
151 (emacs_gnutls_read): Use new log functions,
152 `gnutls_handshakes_tried' process member, and
153 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
154 attempts per process (connection).
155
156 2012-04-09 Chong Yidong <cyd@gnu.org>
157
158 * eval.c (Fuser_variable_p, user_variable_p_eh)
159 (lisp_indirect_variable): Functions deleted.
160 (Fdefvar): Caller changed.
161
162 * callint.c (Finteractive, Fcall_interactively):
163 * minibuf.c (Fread_variable): Callers changed.
164
165 2012-04-09 Eli Zaretskii <eliz@gnu.org>
166
167 * xdisp.c (set_cursor_from_row): If the display string appears in
168 the buffer at position that is closer to point than the position
169 after the display string, display the cursor on the first glyph of
170 the display string. Fixes cursor display when a 'display' text
171 property immediately follows invisible text. (Bug#11094)
172
173 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
174
175 composite.c: use 'double' consistently
176 * composite.c (get_composition_id): Use 'double' consistently
177 instead of converting 'float' to 'double' and vice versa; this is
178 easier to understand and avoids a GCC warning.
179
180 2012-04-09 Glenn Morris <rgm@gnu.org>
181
182 * Makefile.in: Generate leim-list with bootstrap-emacs, in
183 preparation for dumping it with emacs. (Bug#4789)
184 (leimdir): New variable.
185 ($(leimdir)/leim-list.el): New rule.
186 (emacs$(EXEEXT)): Depend on leim-list.el.
187
188 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
189 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
190 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
191
192 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
193
194 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
195 proper alignment.
196
197 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
198
199 * xml.c (init_libxml2_functions) [WINDOWSNT]:
200 Remove unused local variable.
201
202 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
203
204 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
205 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
206 (mark_memory): Mark Lisp_Objects only if pointers might hide in
207 objects, as mark_maybe_pointer will catch them otherwise.
208 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
209 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
210
211 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
212
213 Fix typo that broke non-Windows builds.
214 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
215
216 2012-04-07 Eli Zaretskii <eliz@gnu.org>
217
218 Support building on MS-Windows with libxml2.
219
220 * makefile.w32-in (OBJ2): Add xml.$(O).
221 (GLOBAL_SOURCES): Add xml.c.
222 ($(BLD)/xml.$(O)): New dependency list.
223
224 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
225 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
226 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
227 [!WINDOWSNT]: New macros.
228 (init_libxml2_functions, libxml2_loaded_p): New functions.
229 (parse_region): Call fn_xmlCheckVersion instead of using the macro
230 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
231 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
232 Calls xmlCleanupParser only if libxml2 was loaded (or statically
233 linked in).
234 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
235 Call init_libxml2_functions before calling libxml2 functions.
236 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
237
238 * emacs.c: Don't include libxml/parser.h.
239 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
240 xmlCleanupParser directly.
241
242 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
243
244 2012-04-07 Eli Zaretskii <eliz@gnu.org>
245
246 * indent.c (Fvertical_motion): If there is a display string at
247 point, use it.vpos to compute how many lines to backtrack after
248 move_it_to point. (Bug#11133)
249
250 2012-04-06 Eli Zaretskii <eliz@gnu.org>
251
252 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
253 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
254 about subtle differences between FETCH_CHAR* and STRING_CHAR*
255 macros related to unification of CJK characters. For the details,
256 see the discussion following the message here:
257 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
258
259 2012-04-04 Chong Yidong <cyd@gnu.org>
260
261 * keyboard.c (Vdelayed_warnings_list): Doc fix.
262
263 2012-04-01 Eli Zaretskii <eliz@gnu.org>
264
265 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
266 instead of alloca. (Bug#11138)
267
268 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
269
270 * w32menu.c (is_simple_dialog): Properly check lisp types.
271 (Bug#11141)
272
273 2012-03-31 Eli Zaretskii <eliz@gnu.org>
274
275 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
276 position we get to after a call to move_it_to fails the
277 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
278 only if we wind up in a string from display property. (Bug#11063)
279
280 * window.c (Fdelete_other_windows_internal): Invalidate the row
281 and column information about mouse highlight, so that redisplay
282 restores it after reallocating the glyph matrices. (Bug#7464)
283
284 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
285 string comes from a `display' text property, use the buffer
286 position of that property as if we actually saw that position in
287 the row's glyphs.
288 (move_it_by_lines): Remove the assertion that
289 "it->current_x == 0 && it->hpos == 0" which can be legitimately
290 violated when there's a before-string at the beginning of a line.
291 (Bug#11063)
292
293 2012-03-30 Eli Zaretskii <eliz@gnu.org>
294
295 * xdisp.c (append_space_for_newline): If the default face was
296 remapped, use the remapped face for the appended newline.
297 (extend_face_to_end_of_line): Use the remapped default face for
298 extending the face to the end of the line.
299 (display_line): Call extend_face_to_end_of_line when the default
300 face was remapped. (Bug#11068)
301
302 2012-03-29 Eli Zaretskii <eliz@gnu.org>
303
304 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
305
306 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
307
308 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
309
310 2012-03-27 Glenn Morris <rgm@gnu.org>
311
312 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
313 Doc fixes.
314
315 2012-03-26 Kenichi Handa <handa@m17n.org>
316
317 * dispextern.h (struct glyph): Fix previous change. Change the
318 bit length of glyphless.ch to 25 (Bug#11082).
319
320 2012-03-26 Chong Yidong <cyd@gnu.org>
321
322 * keyboard.c (Vselection_inhibit_update_commands): New variable.
323 (command_loop_1): Use it; inhibit selection update for
324 handle-select-window too (Bug#8996).
325
326 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
327
328 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
329
330 2012-03-25 Kenichi Handa <handa@m17n.org>
331
332 * dispextern.h (struct glyph): Change the bit length of
333 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
334
335 2012-03-24 Eli Zaretskii <eliz@gnu.org>
336
337 * s/ms-w32.h (tzname): Include time.h before redirecting to
338 _tzname. Fixes the MSVC build. (Bug#9960)
339
340 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
341
342 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
343 characters.
344
345 * xterm.c (XTread_socket): Only modify handling_signal if
346 !SYNC_INPUT. (Bug#11080)
347
348 2012-03-23 Eli Zaretskii <eliz@gnu.org>
349
350 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
351 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
352 when fetching a multibyte character consumes more bytes than
353 CHAR_BYTES returns, due to unification of CJK characters in
354 string_char. (Bug#11073)
355
356 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
357
358 * process.c (wait_reading_process_output): Handle pty disconnect
359 by refraining from sending oneself a SIGCHLD (bug#10933).
360
361 2012-03-22 Chong Yidong <cyd@gnu.org>
362
363 * dispextern.h (struct it): New member string_from_prefix_prop_p.
364
365 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
366 Mark string as coming from a prefix property.
367 (handle_face_prop): Use default face for prefix strings (Bug#4281).
368 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
369
370 2012-03-21 Chong Yidong <cyd@gnu.org>
371
372 * xfaces.c (Vface_remapping_alist): Doc fix.
373
374 2012-03-20 Eli Zaretskii <eliz@gnu.org>
375
376 * w32proc.c (Fw32_set_console_codepage)
377 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
378 Doc fixes.
379
380 2012-03-20 Chong Yidong <cyd@gnu.org>
381
382 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
383 to reflect default non-nil value of redisplay-dont-pause.
384
385 2012-03-19 Kenichi Handa <handa@m17n.org>
386
387 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
388 it fit in a valid range (Bug#11003).
389
390 2012-03-18 Eli Zaretskii <eliz@gnu.org>
391
392 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
393 that is not from display property, accept the row as a "cursor
394 row" if one of the string's character has a non-nil `cursor'
395 property. Fixes cursor positioning when there are newlines in
396 overlay strings, e.g. in icomplete.el. (Bug#11035)
397
398 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
399
400 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
401
402 2012-03-12 Chong Yidong <cyd@gnu.org>
403
404 * eval.c (inhibit_lisp_code): Rename from
405 inhibit_window_configuration_change_hook; move from window.c.
406
407 * xfns.c (unwind_create_frame_1, Fx_create_frame):
408 * window.c (run_window_configuration_change_hook)
409 (syms_of_window): Callers changed.
410
411 2012-03-11 Chong Yidong <cyd@gnu.org>
412
413 * keymap.c (Fkey_description): Doc fix (Bug#9700).
414
415 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
416
417 2012-03-10 Chong Yidong <cyd@gnu.org>
418
419 * frame.c (other_visible_frames): Don't assume the selected frame
420 is visible (Bug#10955).
421
422 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
423
424 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
425
426 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
427
428 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
429 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
430 zero (Bug#10954).
431
432 2012-03-03 Glenn Morris <rgm@gnu.org>
433
434 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
435
436 2012-03-02 Eli Zaretskii <eliz@gnu.org>
437
438 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
439 position past the first glyph_row that ends at ZV. (Bug#10902)
440 (redisplay_window, next_element_from_string): Fix typos in
441 comments.
442 (redisplay_window): Pass to move_it_vertically the margin in
443 pixels, not in screen lines.
444
445 2012-03-02 Glenn Morris <rgm@gnu.org>
446
447 * buffer.c (buffer-list-update-hook): Doc fix.
448
449 2012-02-29 Eli Zaretskii <eliz@gnu.org>
450
451 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
452 push_it before setting up the iterator for the first overlay
453 string, even if we have an empty string loaded.
454 (next_overlay_string): If there's an empty string on the iterator
455 stack, pop the stack. (Bug#10903)
456
457 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
458
459 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
460 Suggested by Stefan Monnier in
461 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
462 * alloc.c (widen_to_Lisp_Object): New static function.
463 (mark_memory): Also mark Lisp_Objects by fetching pointer words
464 and widening them to Lisp_Objects. This would work even if
465 USE_LSB_TAG is defined and wide integers are used, which might
466 happen in a future version of Emacs.
467
468 2012-02-25 Chong Yidong <cyd@gnu.org>
469
470 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
471 Doc fix.
472
473 * xselect.c (Fx_selection_exists_p): Doc fix.
474 (x_clipboard_manager_save_all): Print an informative message
475 before saving to clipboard manager.
476
477 2012-02-24 Chong Yidong <cyd@gnu.org>
478
479 * keyboard.c (process_special_events): Handle all X selection
480 requests in kbd_buffer, not just the next one (Bug#8869).
481
482 2012-02-23 Chong Yidong <cyd@gnu.org>
483
484 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
485 call when setting menu-bar-lines and tool-bar-lines parameters.
486 (unwind_create_frame_1): New helper function.
487
488 * window.c (inhibit_window_configuration_change_hook): New var.
489 (run_window_configuration_change_hook): Obey it.
490 (syms_of_window): Initialize it.
491
492 2012-02-22 Chong Yidong <cyd@gnu.org>
493
494 * xterm.c (x_draw_image_relief): Add missing type check for
495 Vtool_bar_button_margin (Bug#10743).
496
497 2012-02-21 Chong Yidong <cyd@gnu.org>
498
499 * fileio.c (Vfile_name_handler_alist): Doc fix.
500
501 * buffer.c (Fget_file_buffer): Protect against invalid file
502 handler return value.
503
504 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
505
506 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
507 when computing $valmask.
508
509 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
510 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
511 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
512 It's useless in that case, and it can cause problems on hosts
513 that allocate halves of EMACS_INT values separately.
514 Reported by Dan Horák. Diagnosed by Andreas Schwab in
515 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
516 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
517 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
518 it avoids undefined behavior on hosts where shifting right by more
519 than the word width has undefined behavior.
520
521 2012-02-19 Chong Yidong <cyd@gnu.org>
522
523 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
524 (Funhandled_file_name_directory, Ffile_name_as_directory)
525 (Fdirectory_file_name, Fexpand_file_name)
526 (Fsubstitute_in_file_name): Protect against invalid file handler
527 return values (Bug#10845).
528
529 2012-02-18 Eli Zaretskii <eliz@gnu.org>
530
531 * .gdbinit (pitx): Fix incorrect references to fields of the
532 iterator stack.
533
534 2012-02-17 Chong Yidong <cyd@gnu.org>
535
536 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
537
538 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
539
540 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
541 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
542
543 2012-02-15 Chong Yidong <cyd@gnu.org>
544
545 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
546 marked as special. Also, starting docstrings with * is obsolete.
547
548 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
549
550 * gnutls.c (emacs_gnutls_write): Fix last change.
551
552 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
553
554 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
555 send_process.
556
557 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
558
559 * keymap.c (Fsingle_key_description): Handle char ranges.
560
561 2012-02-12 Chong Yidong <cyd@gnu.org>
562
563 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
564 as that creates a dangerous corner case.
565
566 * window.c (Fdelete_window_internal): Invalidate the mouse
567 highlight (Bug#9904).
568
569 2012-02-12 Glenn Morris <rgm@gnu.org>
570
571 * xselect.c (Fx_own_selection_internal)
572 (Fx_get_selection_internal, Fx_disown_selection_internal)
573 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
574 * nsselect.m (Fx_own_selection_internal)
575 (Fx_disown_selection_internal, Fx_selection_exists_p)
576 (Fx_selection_owner_p, Fx_get_selection_internal):
577 Sync docs and argument specs with the xselect.c versions.
578
579 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
580
581 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
582
583 2012-02-11 Eli Zaretskii <eliz@gnu.org>
584
585 * w32select.c (Fx_selection_exists_p): Sync doc string and
586 argument list with xselect.c. (Bug#10783)
587
588 * w16select.c (Fx_selection_exists_p): Sync doc string and
589 argument list with xselect.c. (Bug#10783)
590
591 2012-02-10 Glenn Morris <rgm@gnu.org>
592
593 * fns.c (Fsecure_hash): Doc fix.
594
595 2012-02-09 Kenichi Handa <handa@m17n.org>
596
597 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
598
599 2012-02-07 Chong Yidong <cyd@gnu.org>
600
601 * buffer.c (Fbuffer_local_variables)
602 (buffer_lisp_local_variables): Handle unbound vars correctly;
603 don't let Qunbound leak into Lisp.
604
605 2012-02-07 Glenn Morris <rgm@gnu.org>
606
607 * image.c (Fimagemagick_types): Doc fix.
608
609 * image.c (imagemagick-render-type): Change it from a lisp object
610 to an integer. Move the doc here from the lisp manual.
611 Treat all values not equal to 0 the same.
612
613 2012-02-06 Chong Yidong <cyd@gnu.org>
614
615 * doc.c (store_function_docstring): Avoid applying docstring of
616 alias to base function (Bug#2603).
617
618 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
619
620 * .gdbinit (pp1, pv1): Remove redundant defines.
621 (pr): Use pp.
622
623 2012-02-04 Chong Yidong <cyd@gnu.org>
624
625 * nsterm.m: Declare a global (Bug#10694).
626
627 2012-02-04 Eli Zaretskii <eliz@gnu.org>
628
629 * w32.c (get_emacs_configuration_options):
630 Include --enable-checking, if specified, in the return value.
631
632 2012-02-04 Martin Rudalics <rudalics@gmx.at>
633
634 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
635 after rounding frame sizes. (Bug#9723)
636
637 2012-02-04 Eli Zaretskii <eliz@gnu.org>
638
639 * keyboard.c (adjust_point_for_property): Don't position point
640 before BEGV. (Bug#10696)
641
642 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
643
644 Handle overflow when computing char display width (Bug#9496).
645 * character.c (char_width): Return EMACS_INT, not int.
646 (char_width, c_string_width): Check for overflow when
647 computing the width; this is possible now that individual
648 characters can have unbounded width. Problem introduced
649 by merge from Emacs 23 on 2012-01-19.
650
651 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
652
653 * dbusbind.c (Fdbus_register_method): Mention the return value
654 :ignore in the docstring.
655
656 2012-02-02 Glenn Morris <rgm@gnu.org>
657
658 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
659
660 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
661 Unconditionally set to t. (Bug#10673)
662 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
663 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
664 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
665
666 2012-02-02 Kenichi Handa <handa@m17n.org>
667
668 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
669 0, do not call append_composite_glyph.
670
671 2012-02-02 Kenichi Handa <handa@m17n.org>
672
673 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
674 NULL (Bug#6988).
675 (x_produce_glyphs): If the component of a composition is a null
676 string, set it->pixel_width to 1 to avoid zero-width glyph.
677
678 2012-02-01 Eli Zaretskii <eliz@gnu.org>
679
680 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
681 first 2 arguments are identical. This makes inserting large
682 output from a subprocess an order of magnitude faster on
683 MS-Windows, where all sbrk'ed memory is always contiguous.
684
685 2012-01-31 Glenn Morris <rgm@gnu.org>
686
687 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
688 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
689 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
690
691 2012-01-29 Glenn Morris <rgm@gnu.org>
692
693 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
694
695 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
696
697 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
698
699 2012-01-28 Chong Yidong <cyd@gnu.org>
700
701 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
702
703 2012-01-26 Chong Yidong <cyd@gnu.org>
704
705 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
706
707 * search.c (Fsearch_forward, Fsearch_backward): Document negative
708 repeat counts (Bug#10507).
709
710 2012-01-26 Glenn Morris <rgm@gnu.org>
711
712 * lread.c (syms_of_lread): Doc fix.
713
714 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
715
716 * coding.c (encode_designation_at_bol): Change return value to
717 EMACS_INT.
718
719 2012-01-25 Chong Yidong <cyd@gnu.org>
720
721 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
722
723 2012-01-21 Chong Yidong <cyd@gnu.org>
724
725 * floatfns.c (Fcopysign): Make the second argument non-optional,
726 since nil is not allowed anyway.
727
728 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
729
730 * process.c (read_process_output): Use p instead of XPROCESS (proc).
731 (send_process): Likewise.
732
733 2012-01-19 Martin Rudalics <rudalics@gmx.at>
734
735 * window.c (save_window_save, Fcurrent_window_configuration)
736 (Vwindow_persistent_parameters): Do not use Qstate.
737 Rewrite doc-strings.
738
739 2012-01-19 Kenichi Handa <handa@m17n.org>
740
741 * character.c (char_width): New function.
742 (Fchar_width, c_string_width, lisp_string_width):
743 Use char_width (Bug#9496).
744
745 2012-01-16 Martin Rudalics <rudalics@gmx.at>
746
747 * window.c (Vwindow_persistent_parameters): New variable.
748 (Fset_window_configuration, save_window_save): Handle persistent
749 window parameters.
750
751 2012-01-14 Eli Zaretskii <eliz@gnu.org>
752
753 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
754 thrashing the stack of the thread. (Bug#9087)
755
756 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
757
758 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
759
760 2012-01-11 Eli Zaretskii <eliz@gnu.org>
761
762 * xdisp.c (rows_from_pos_range): Handle the case where the
763 highlight ends on a newline. (Bug#10464)
764 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
765 he end column for display of highlight that ends on a newline
766 before a R2L line.
767
768 2012-01-11 Glenn Morris <rgm@gnu.org>
769
770 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
771 from load-path also when installation-directory is nil. (Bug#10208)
772
773 2012-01-10 Glenn Morris <rgm@gnu.org>
774
775 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
776
777 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
778 Update template values to be closer to their typical values these days.
779
780 2012-01-09 Eli Zaretskii <eliz@gnu.org>
781
782 * xdisp.c (rows_from_pos_range): Accept additional argument
783 DISP_STRING, and accept any glyph in a row whose object is that
784 string as eligible for mouse highlight. Fixes mouse highlight of
785 display strings from overlays. (Bug#10464)
786
787 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
788
789 emacs: fix an auto-save permissions race condition (Bug#10400)
790 * fileio.c (auto_saving_dir_umask): New static var.
791 (Fmake_directory_internal): Use it.
792 (do_auto_save_make_dir): Set it, instead of invoking chmod after
793 creating the directory. The old code temporarily assigns
794 too-generous permissions to the directory.
795 (do_auto_save_eh): Clear it.
796 (Fdo_auto_save): Catch all errors, not just file errors, so
797 that the var is always cleared.
798
799 2012-01-07 Eli Zaretskii <eliz@gnu.org>
800
801 * search.c (scan_buffer): Pass character positions to
802 know_region_cache, not byte positions. (Bug#6540)
803
804 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
805
806 * w32.c (sys_rename): Report EXDEV when rename of a directory
807 fails because the target is on another logical disk. (Bug#10284)
808
809 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
810
811 * xterm.c (x_embed_request_focus): New function.
812
813 * xterm.h: Add prototype.
814
815 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
816
817 2012-01-05 Glenn Morris <rgm@gnu.org>
818
819 * emacs.c (emacs_copyright): Update short copyright year to 2012.
820
821 2012-01-01 Eli Zaretskii <eliz@gnu.org>
822
823 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
824 Load gnutls_transport_set_lowat only if GnuTLS version is below
825 2.11.1.
826 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
827 GnuTLS versions below 2.11.1.
828
829 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
830
831 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
832 to the doc string advising against its use for altering the way
833 windows are scrolled.
834
835 2011-12-28 Kenichi Handa <handa@m17n.org>
836
837 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
838 coding-system ASCII compatible only when it does not produce BOM
839 on encoding (Bug#10383).
840
841 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
842
843 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
844 can scroll.
845 (create_and_show_popup_menu): Always use menu_position_func for
846 Gtk3 (Bug#10361).
847
848 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
849
850 * callint.c (Fcall_interactively): Don't truncate prompt string.
851
852 2011-12-23 Eli Zaretskii <eliz@gnu.org>
853
854 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
855 property that ends at ZV, so that the bidi iteration could be
856 resumed from there (after widening). (Bug#10360)
857
858 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
859
860 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
861
862 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
863
864 * nsterm.m (x_free_frame_resources):
865 Release f->output_data.ns->miniimage.
866 (ns_index_color): Fix indentation. Do not retain
867 color_table->colors[i].
868
869 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
870 before returning.
871
872 * nsfns.m (x_set_background_color): Assign return value from
873 ns_index_color to face-background instead of NSColor*.
874 (ns_implicitly_set_icon_type): Fix indentation.
875 Change assignment in for loop to comparison.
876
877 * emacs.c (ns_pool): New variable.
878 (main): Assign ns_pool.
879 (Fkill_emacs): Call ns_release_autorelease_pool.
880
881 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
882 autorelease fdesc, release fdAttrs and tdict.
883 (ns_get_covering_families): Release charset.
884 (ns_findfonts): Release NSFontDescriptor created with new.
885 (ns_uni_to_glyphs): Fix indentation.
886 (setString): Release attrStr before assigning new value.
887
888 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
889
890 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
891 and NS_IMPL_COCOA.
892 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
893 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
894
895 2011-12-18 David Reitter <reitter@cmu.edu>
896
897 * nsterm.m (ns_term_init): Subscribe for notifications
898 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
899 to method trackingNotification in EmacsMenu.
900
901 * nsmenu.m (trackingMenu): New variable.
902 (trackingNotification): New method (from Aquamacs).
903 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
904 from Aquamacs (Bug#7030).
905
906 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
907
908 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
909 (symbol_to_nsstring): Fix indentation.
910 (ns_symbol_to_pb): New function.
911 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
912 (Fns_rotate_cut_buffers_internal): Remove.
913 (Fns_store_selection_internal): Rename from
914 Fns_store_cut_buffer_internal.
915 (ns_get_foreign_selection, Fx_own_selection_internal)
916 (Fx_disown_selection_internal, Fx_selection_exists_p)
917 (Fns_get_selection_internal, Fns_store_selection_internal):
918 Use ns_symbol_to_pb and check if return value is nil.
919 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
920 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
921 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
922 renamed to Sns_store_selection_internal.
923 (ns_handle_selection_request): Move code to Fx_own_selection_internal
924 and remove this function.
925 (ns_handle_selection_clear): Remove, never used.
926 (Fx_own_selection_internal): Move code from ns_handle_selection_request
927 here.
928
929 2011-12-17 Ken Brown <kbrown@cornell.edu>
930
931 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
932 GID is unknown (Bug#10257).
933
934 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
935
936 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
937 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
938 which caused a build failure on GNU/Linux IA-64. This problem was
939 introduced by my 2011-10-07 patch.
940
941 2011-12-15 Juri Linkov <juri@jurta.org>
942
943 * image.c (imagemagick_error): New function. (Bug#10112)
944 (imagemagick_load_image): Comment out `MagickSetResolution' call.
945 Use `imagemagick_error' where ImageMagick functions return
946 `MagickFalse'.
947 (Fimagemagick_types): Add `Fnreverse' to return the list in the
948 proper order.
949
950 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
951
952 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
953 fill background (Bug#8992).
954
955 2011-12-13 Martin Rudalics <rudalics@gmx.at>
956
957 * window.c (Vwindow_combination_resize)
958 (Vwindow_combination_limit): Use t instead of non-nil in
959 doc-strings.
960 (Vrecenter_redisplay): Add first sentence of doc-string on
961 separate line.
962 (Frecenter): Fix doc-string typo.
963
964 2011-12-11 Kenichi Handa <handa@m17n.org>
965
966 * coding.c (Funencodable_char_position): Pay attention to the
967 buffer text relocation (Bug#9389).
968
969 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
970
971 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
972 gtk_init (Bug#10100).
973
974 2011-12-10 Eli Zaretskii <eliz@gnu.org>
975
976 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
977 IT->string is nil. (Bug#10263)
978
979 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
980
981 * nsterm.h (x_free_frame_resources): Declare.
982
983 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
984 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
985
986 * nsterm.h (ns_get_defaults_value): Declare.
987
988 * nsterm.m (ns_default): Call ns_get_defaults_value.
989
990 2011-12-09 Eli Zaretskii <eliz@gnu.org>
991
992 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
993 (Bug#10170)
994
995 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
996
997 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
998 that where the value of an _OBJC_* symbol points to is in the .bss
999 section (Bug#10240).
1000
1001 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1002
1003 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1004 after the loop to call ccl_driver at least once (Bug#8619).
1005
1006 2011-12-08 Kenichi Handa <handa@m17n.org>
1007
1008 * ftfont.c (get_adstyle_property): Fix previous change
1009 (Bug#10233).
1010
1011 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1012
1013 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1014 dirs from the default value of EMACSLOADPATH (bug#10208).
1015
1016 2011-12-07 Glenn Morris <rgm@gnu.org>
1017
1018 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1019 installation and source directories as well. (Bug#10208)
1020
1021 2011-12-06 Chong Yidong <cyd@gnu.org>
1022
1023 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1024
1025 2011-12-06 Glenn Morris <rgm@gnu.org>
1026
1027 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1028 as an error, not just -1. (Bug#10217)
1029
1030 2011-12-05 Chong Yidong <cyd@gnu.org>
1031
1032 * keyboard.c (process_special_events): New function.
1033 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1034
1035 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1036
1037 * coding.c (encode_designation_at_bol): Don't use uninitialized
1038 local variable (Bug#9318).
1039
1040 2011-12-05 Kenichi Handa <handa@m17n.org>
1041
1042 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1043 return Qnil (Bug#8046, Bug#10193).
1044
1045 2011-12-05 Kenichi Handa <handa@m17n.org>
1046
1047 * coding.c (encode_designation_at_bol): New args charbuf_end and
1048 dst. Return the number of produced bytes. Callers changed.
1049 (coding_set_source): Return how many bytes coding->source was
1050 relocated.
1051 (coding_set_destination): Return how many bytes
1052 coding->destination was relocated.
1053 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1054 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1055
1056 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1057
1058 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1059 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1060 macro (Bug#9318).
1061
1062 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1063
1064 The following changes are to fix Bug#9318.
1065
1066 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1067 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1068 (encode_coding_iso_2022, encode_coding_sjis)
1069 (encode_coding_big5, encode_coding_charset): Use the above macros.
1070
1071 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1072
1073 * lisp.h (process_quit_flag): Fix external declaration.
1074
1075 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1076
1077 Don't macro-inline non-performance-critical code.
1078 * eval.c (process_quit_flag): New function.
1079 * lisp.h (QUIT): Use it.
1080
1081 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1082
1083 * nsfns.m (get_geometry_from_preferences): New function.
1084 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1085
1086 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1087
1088 * emacs.c (Qkill_emacs): Define.
1089 (syms_of_emacs): Initialize it.
1090 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1091 Qquit_flag to `kill-emacs' instead.
1092 (quit_throw_to_read_char): Add parameter `from_signal'.
1093 All callers changed. Call Fkill_emacs if requested and safe.
1094 * lisp.h (QUIT): Call Fkill_emacs if requested.
1095
1096 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1097
1098 * widget.c (update_wm_hints): Return if wmshell is null.
1099 (widget_update_wm_size_hints): New function.
1100
1101 * widget.h (widget_update_wm_size_hints): Declare.
1102
1103 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1104 widget_update_wm_size_hints (Bug#10104).
1105
1106 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1107
1108 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1109 before a newline, prepare the bidi iterator for consuming the
1110 newline, and keep the current paragraph direction. (Bug#10183)
1111 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1112
1113 2011-12-02 Juri Linkov <juri@jurta.org>
1114
1115 * search.c (Fword_search_regexp): New Lisp function created from
1116 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1117 (Fword_search_backward, Fword_search_forward)
1118 (Fword_search_backward_lax, Fword_search_forward_lax):
1119 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1120 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1121
1122 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1123
1124 * fileio.c (Finsert_file_contents): Move after-change-function call
1125 to before the "handled:" label, since all "goto handled" appear in
1126 cases where the *-change-functions have already been properly called
1127 (bug#10117).
1128
1129 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1130
1131 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1132 waiting for input. (Bug#10169)
1133
1134 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1135
1136 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1137 verifies glyph row's hash code--we have just reallocated the
1138 glyphs, so their contents can be complete garbage. (Bug#10164)
1139
1140 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1141
1142 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1143
1144 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1145
1146 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1147 attributes are tested _before_ calling verify_row_hash, to protect
1148 against GCC re-ordering of the tests. (Bug#10164)
1149
1150 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1151
1152 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1153
1154 * xterm.c (handle_one_xevent): Only set async_visible and friends
1155 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1156 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1157 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1158
1159 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1160
1161 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1162 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1163 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1164 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1165 All uses changed to use GCPRO1 etc.
1166 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1167 Revert to old implementation (i.e., before 2011-03-11).
1168
1169 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1170
1171 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1172 of scroll runs so as to avoid assigning disabled bogus rows and
1173 unnecessary graphics copy operations.
1174
1175 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1176
1177 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1178 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1179 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1180 (malloc, free, realloc, calloc): Redirect to e_* only when
1181 compiling Emacs.
1182
1183 * lisp.h (GCTYPEBITS): Move before first use.
1184 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1185 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1186 this macro definition.
1187
1188 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1189 _MSC_VER.
1190
1191 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1192
1193 * gtkutil.c (xg_create_frame_widgets):
1194 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1195 present with Gtk+ 2.0.
1196
1197 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1198
1199 * fileio.c (Finsert_file_contents): Undo previous change; see
1200 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1201
1202 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1203
1204 Rename locals to avoid shadowing.
1205 * fileio.c (Finsert_file_contents):
1206 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1207 * process.c (wait_reading_process_output):
1208 Rename inner 'proc' to 'p' to avoid shadowing.
1209 Indent for consistency with usual Emacs style.
1210
1211 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1212
1213 * xdisp.c (redisplay_window): If cursor row is not fully visible
1214 after recentering, and scroll-conservatively is set to a large
1215 number, scroll window by a few more lines to make the cursor fully
1216 visible and out of scroll-margin. (Bug#10105)
1217 (start_display): Don't move to the next line if the display should
1218 start at a newline that is part of a display vector or an overlay
1219 string. (Bug#10119)
1220
1221 2011-11-24 Juri Linkov <juri@jurta.org>
1222
1223 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1224 after the `MagickPingImage' call. (Bug#10112)
1225
1226 2011-11-23 Chong Yidong <cyd@gnu.org>
1227
1228 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1229
1230 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1231
1232 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1233 making another buffer current. (Bug#10114)
1234
1235 2011-11-23 Glenn Morris <rgm@gnu.org>
1236
1237 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1238
1239 2011-11-23 Chong Yidong <cyd@gnu.org>
1240
1241 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1242 using it (Bug#5984).
1243
1244 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1245
1246 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1247 and header-lines, as they don't have one computed for them.
1248 (Bug#10098)
1249
1250 * .gdbinit (prow): Make displayed values more self-explaining.
1251 Add row's hash code.
1252
1253 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1254
1255 * process.c (wait_reading_process_output): Fix asynchrounous
1256 GnuTLS socket handling on some versions of the GnuTLS library.
1257 (wait_reading_process_output): Add comment and URL.
1258
1259 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1260
1261 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1262
1263 2011-11-21 Chong Yidong <cyd@gnu.org>
1264
1265 * window.c (Fnext_window, Fprevious_window): Doc fix.
1266
1267 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1268
1269 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1270
1271 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1272
1273 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1274
1275 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1276
1277 * window.c (Fset_window_combination_limit): Rename argument
1278 STATUS to LIMIT.
1279 (Vwindow_combination_limit): Remove "status" from doc-string.
1280
1281 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1282
1283 * m/ibms390.h: Remove.
1284 * m/ibms390x.h: Don't include "ibms390.h".
1285
1286 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1287
1288 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1289 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1290
1291 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1292
1293 * casetab.c (Fset_case_table):
1294 * charset.c (Fcharset_after): Fix typos.
1295
1296 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1297
1298 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1299 Otherwise, valgrind does not work on some platforms.
1300 Problem reported by Andreas Schwab in
1301 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1302 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1303 is set, removing the need for VIRT_ADDRESS_VARIES.
1304 (PURE_P): Use a more-efficient implementation that needs just one
1305 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1306 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1307 to 4 (xorl, subq, cmpq, setbe).
1308 * alloc.c (pure): Always extern now, since that's the
1309 VIRT_ADDR_VARIES behavior.
1310 (PURE_POINTER_P): Use a single comparison, not two, for
1311 consistency with the new puresize.h.
1312 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1313 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1314 Remove VIRT_ADDR_VARIES no longer needed.
1315
1316 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1317
1318 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1319 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1320 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1321 behave as if the cursor position were at the window margin.
1322
1323 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1324 and the cursor position is out of bounds, behave as if the cursor
1325 position were at the window margin. (Bug#10075)
1326
1327 2011-11-18 Chong Yidong <cyd@gnu.org>
1328
1329 * window.c (Fwindow_combination_limit): Make first argument
1330 non-optional, since it is meaningless for live windows like the
1331 selected window.
1332
1333 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1334
1335 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1336
1337 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1338
1339 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1340 (graft_intervals_into_buffer): Simplify.
1341
1342 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1343
1344 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1345 hash values of the two rows.
1346 (copy_row_except_pointers): Preserve the used[] arrays and the
1347 hash values of the two rows. (Bug#10035)
1348 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1349
1350 * xdisp.c (row_hash): New function, body extracted from
1351 compute_line_metrics.
1352 (compute_line_metrics): Call row_hash, instead of computing the
1353 hash code inline.
1354
1355 * dispnew.c (verify_row_hash): Call row_hash for computing the
1356 hash code of a row, instead of duplicating code from xdisp.c.
1357
1358 * dispextern.h (row_hash): Add prototype.
1359
1360 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1361
1362 * frame.c (delete_frame): Don't delete the terminal when the last
1363 X frame is closed if emacs is built with GTK toolkit.
1364
1365 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1366
1367 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1368
1369 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1370
1371 * window.c (Vwindow_splits): Rename to
1372 Vwindow_combination_resize. Suggested by Juri Linkov.
1373 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1374 of Vwindow_splits.
1375
1376 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1377
1378 * nsfns.m (Fns_font_name):
1379 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1380
1381 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1382
1383 * window.h (window): Rename slot "nest" to "combination_limit".
1384 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1385 (Fset_window_nest): Rename to Fset_window_combination_limit.
1386 (Vwindow_nest): Rename to Vwindow_combination_limit.
1387 (recombine_windows, make_parent_window, make_window)
1388 (Fsplit_window_internal, saved_window)
1389 (Fset_window_configuration, save_window_save): Rename all
1390 occurrences of window_nest to window_combination_limit.
1391
1392 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1393
1394 * image.c (imagemagick_load_image): Fix typo.
1395
1396 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1397
1398 * xdisp.c (display_line): Move the call to
1399 highlight_trailing_whitespace before the call to
1400 compute_line_metrics, since the latter needs to see the final
1401 faces of all the glyphs to compute ROW's hash value.
1402 Fixes assertion violations in row_equal_p. (Bug#10035)
1403
1404 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1405
1406 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1407 just return (bug#10044).
1408
1409 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1410
1411 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1412 with user-defined heap size. Bump the default size of the temacs
1413 heap to 27MB, to avoid memory warning when running temacs.
1414 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1415
1416 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1417 current_matrix and desired_matrix. (Bug#9990)
1418 (verify_row_hash) [XASSERTS]: New function.
1419 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1420 that the hash value of glyph rows is correct.
1421
1422 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1423
1424 * window.h (window): Remove splits slot.
1425 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1426 (Fdelete_other_windows_internal, make_parent_window)
1427 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1428 (Fset_window_configuration, save_window_save): Don't deal with
1429 split status of windows.
1430 (saved_window): Remove splits slot.
1431 (Vwindow_splits): Rewrite doc-string.
1432
1433 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1434
1435 * xfns.c (unwind_create_frame):
1436 * nsfns.m (unwind_create_frame):
1437 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1438 Vframe_list (Bug#9999).
1439
1440 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1441
1442 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1443
1444 2011-11-11 Kenichi Handa <handa@m17n.org>
1445
1446 * callproc.c (Fcall_process): Set the member dst_multibyte of
1447 process_coding.
1448
1449 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1450
1451 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1452 avoid a crash (bug#9496).
1453
1454 2011-11-09 Chong Yidong <cyd@gnu.org>
1455
1456 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1457 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1458
1459 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1460
1461 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1462
1463 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1464
1465 Avoid some portability problems by eschewing 'extern inline' functions.
1466 The trivial performance wins aren't worth the portability hassles; see
1467 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1468 et seq.
1469 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1470 (window_box_width, window_box_left, window_box_left_offset)
1471 (window_box_right, window_box_right_offset): Undo previous change,
1472 by removing the "extern"s.
1473 * intervals.c (adjust_intervals_for_insertion)
1474 (adjust_intervals_for_deletion): Undo previous change,
1475 making these static again.
1476 (offset_intervals, temp_set_point_both, temp_set_point)
1477 (copy_intervals_to_string): No longer inline.
1478 * xdisp.c (window_text_bottom_y, window_box_width)
1479 (window_box_height, window_box_left_offset)
1480 (window_box_right_offset, window_box_left, window_box_right)
1481 (window_box): No longer inline.
1482
1483 2011-11-08 Chong Yidong <cyd@gnu.org>
1484
1485 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1486 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1487 Signal an error if not a live window.
1488 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1489 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1490
1491 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1492
1493 * lisp.h (syms_of_abbrev): Remove declaration.
1494 Reported by CHENG Gao <chenggao@royau.me>.
1495
1496 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1497
1498 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1499 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1500 of temacs in GUI mode.
1501
1502 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1503
1504 * window.h: Declare delete_all_child_windows instead of
1505 delete_all_subwindows.
1506 * window.c (Fwindow_nest, Fset_window_nest)
1507 (Fset_window_new_total, Fset_window_new_normal)
1508 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1509 (delete_all_subwindows): Rename to delete_all_child_windows.
1510 (Fdelete_other_windows_internal, Fset_window_configuration):
1511 Call delete_all_child_windows instead of delete_all_subwindows.
1512 * frame.c (delete_frame): Call delete_all_child_windows instead
1513 of delete_all_subwindows.
1514
1515 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1516
1517 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1518 This is also needed for porting to any host where GC_MARK_STACK is
1519 not GC_MAKE_GCPROS_NOOPS.
1520 (which_symbols): Use it.
1521
1522 2011-11-07 Kenichi Handa <handa@m17n.org>
1523
1524 * coding.c (coding_set_destination): Check coding->src_pos only
1525 when coding->src_object is a buffer (bug#9910).
1526
1527 * process.c (send_process): Set the member src_multibyte of coding
1528 to 0 (bug#9911) when sending a unibyte text.
1529
1530 * callproc.c (Fcall_process): Set the member src_multibyte of
1531 process_coding to 0 (bug#9912).
1532
1533 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1534
1535 * xmenu.c (cleanup_widget_value_tree): New function.
1536 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1537 calling free_menubar_widget_value_tree directly (Bug#9830).
1538
1539 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1540
1541 Fix some portability problems with 'inline'.
1542 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1543 (window_box_width, window_box_left, window_box_left_offset)
1544 (window_box_right, window_box_right_offset): Declare extern.
1545 Otherwise, these inline functions do not conform to C99 and
1546 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1547 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1548 * intervals.c (adjust_intervals_for_insertion)
1549 (adjust_intervals_for_deletion): Now extern, because otherwise the
1550 extern inline functions 'offset_intervals' couldn't refer to it.
1551 (static_offset_intervals): Remove.
1552 (offset_intervals): Rewrite using the old contents of
1553 static_offset_intervals. The old version didn't conform to C99
1554 because an extern inline function contained a reference to an
1555 identifier with static linkage.
1556
1557 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1558
1559 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1560 GC.
1561
1562 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1563
1564 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1565 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1566 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1567 return Qleft_to_right.
1568
1569 2011-11-06 Chong Yidong <cyd@gnu.org>
1570
1571 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1572 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1573 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1574 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1575 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1576 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1577 (Fwindow_vscroll): Doc fix.
1578 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1579 argument, since it makes no sense to pass a live window and for
1580 consistency with window-child.
1581
1582 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1583
1584 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1585 support MSVC.
1586
1587 2011-11-05 Jason Rumney <jasonr@gnu.org>
1588
1589 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1590 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1591 fonts (Bug#6029).
1592 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1593 bitwise arithmetic preventing use of unicode-sip and non-truetype
1594 opentype fonts.
1595
1596 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1597
1598 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1599 "emacs"-only part.
1600
1601 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1602 initialization code to keep similarity to xfns.c after changes
1603 from 2011-11-05.
1604
1605 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1606
1607 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1608 (unwind_create_frame): New function (Bug#9943).
1609 (Fx_create_frame): Restructure code to be more similar to the one in
1610 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1611 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1612 Move terminal->reference_count++ just before making the frame official
1613 (Bug#9943).
1614
1615 * nsterm.m (x_free_frame_resources): New function.
1616 (x_destroy_window): Move code to x_free_frame_resources.
1617
1618 * xfns.c (unwind_create_frame): Fix comment.
1619 (Fx_create_frame, x_create_tip_frame):
1620 Move terminal->reference_count++ just before making the frame
1621 official. Move initialization of image_cache_refcount and
1622 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1623
1624 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1625
1626 Support MSVC build with newer versions of Visual Studio.
1627 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1628 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1629 nt/gmake.defs.
1630
1631 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1632 which are not supported by MSVC.
1633 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1634 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1635 bitfields.
1636 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1637 types in bitfields.
1638 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1639
1640 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1641
1642 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1643
1644 Support MSVC build with newer versions of Visual Studio.
1645 * w32.c: Don't include w32api.h for MSVC.
1646 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1647
1648 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1649 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1650 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1651 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1652 e_* cousins.
1653 (alloca) [_MSC_VER]: Define to _alloca.
1654
1655 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1656
1657 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1658
1659 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1660
1661 * xdisp.c (note_mouse_highlight): If either of
1662 previous/next-single-property-change returns nil, treat that as
1663 the beginning or the end of the buffer. (Bug#9955)
1664
1665 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1666
1667 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1668 label is not null (Bug#9951).
1669 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1670 may be NULL.
1671
1672 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1673
1674 * window.c (Fwindow_body_size): Mention in the doc string that the
1675 return value is in frame's canonical units. (Bug#9949)
1676
1677 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1678
1679 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1680
1681 * w32fns.c (unwind_create_frame): If needed, free the glyph
1682 matrices of the partially constructed frame. (Bug#9943)
1683 * xfns.c (unwind_create_frame): Likewise.
1684
1685 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1686
1687 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1688 Don't stop backward scan on the continuation glyph, even though
1689 its CHARPOS is positive.
1690 (mouse_face_from_buffer_pos, note_mouse_highlight):
1691 Rename cover_string to disp_string.
1692
1693 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1694
1695 * window.c (temp_output_buffer_show): Don't use
1696 Vtemp_buffer_show_specifiers.
1697 (Vtemp_buffer_show_specifiers): Remove unused variable.
1698
1699 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1700
1701 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1702 past the beginning of the current glyph matrix.
1703
1704 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1705
1706 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1707 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1708 HAVE_GTK3 (Bug#9869).
1709
1710 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1711 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1712
1713 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1714
1715 * xterm.c: Declare x_handle_net_wm_state to return int.
1716 (handle_one_xevent): Check if we are iconified but don't have
1717 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1718 (get_current_wm_state): Return non-zero if not hidden,
1719 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1720 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1721 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1722 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1723
1724 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1725
1726 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1727 so that this new function doesn't get optimized away by a
1728 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1729
1730 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1731
1732 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1733
1734 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1735
1736 Fix the `xbytecode' command.
1737 * .gdbinit (xprintbytestr): New command.
1738 (xwhichsymbols): Rename from `which'; all callers changed.
1739 (xbytecode): Print the byte-code string as well.
1740
1741 2011-10-29 Kim Storm <storm@cua.dk>
1742
1743 * alloc.c (which_symbols): New function.
1744
1745 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1746
1747 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1748 line. (Bug#9903)
1749
1750 2011-10-29 Glenn Morris <rgm@gnu.org>
1751
1752 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1753 Not clear what it was for, and it causes various bugs. (Bug#9839)
1754
1755 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1756
1757 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1758 possible random value that matches one of those tested as
1759 condition to clear the mouse face.
1760
1761 2011-10-28 Chong Yidong <cyd@gnu.org>
1762
1763 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1764
1765 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1766
1767 * window.c (make_window): Initialize phys_cursor_on_p.
1768
1769 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1770
1771 * lisp.h (struct Lisp_Symbol): Update comments.
1772
1773 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1774
1775 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1776
1777 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1778
1779 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1780 <oslsachem@gmail.com> for helping to debug this.
1781
1782 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1783 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1784 (g_b_init_get_glyph_outline_w): New static variables.
1785 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1786 (GetGlyphOutlineW_Proc): New typedefs.
1787 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1788 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1789 New functions.
1790 (w32font_open_internal, compute_metrics):
1791 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1792 instead of calling the "wide" APIs directly.
1793
1794 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1795
1796 * w32.h (syms_of_w32font): Add prototype.
1797
1798 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1799
1800 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1801 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1802 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1803 (Fmove_to_window_line): Doc fix.
1804
1805 2011-10-27 Chong Yidong <cyd@gnu.org>
1806
1807 * process.c (make_process): Set gnutls_state to NULL.
1808
1809 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1810 non-NULL, regardless of GNUTLS_INITSTAGE.
1811 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1812 an error. Set process slots as soon as we allocate them.
1813
1814 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1815
1816 2011-10-27 Chong Yidong <cyd@gnu.org>
1817
1818 * gnutls.c (emacs_gnutls_deinit): New function.
1819 Deallocate credentials structures as well as calling gnutls_deinit.
1820 (Fgnutls_deinit, Fgnutls_boot): Use it.
1821
1822 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1823 (deactivate_process): Call emacs_gnutls_deinit.
1824
1825 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1826
1827 * image.c (x_create_x_image_and_pixmap):
1828 * w32.c (sys_rename, w32_delayed_load):
1829 * w32font.c (fill_in_logfont):
1830 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1831
1832 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1833
1834 * w32fns.c (w32_default_color_map): New function,
1835 extracted from Fw32_default_color_map.
1836 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1837
1838 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1839
1840 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1841
1842 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1843
1844 * keyboard.c (test_undefined): New function (bug#9751).
1845 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1846
1847 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1848
1849 * sysdep.c (init_sys_modes): Fix the check for the controlling
1850 terminal (Bug#6649).
1851
1852 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1853
1854 * dispextern.h (struct bidi_it): New member next_en_type.
1855
1856 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1857 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1858 current character, check also for next_en_type being WEAK_EN.
1859 (bidi_resolve_weak): Don't enter the expensive loop if the current
1860 position is before next_en_pos. Record the bidi type of the first
1861 non-ET, non-BN character we find, in addition to its position.
1862 (bidi_level_of_next_char): Invalidate next_en_type when
1863 next_en_pos is over-stepped.
1864
1865 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1866
1867 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1868 * editfns.c: Rewrite current-time-zone so that it invokes
1869 the equivalent of (format-time-string "%Z") to get the time zone name.
1870 This fixes a bug when the time zone name contains characters that
1871 need converting from the system time locale to Emacs internal format.
1872 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1873 that patch fixed format-time-string to do the conversion, but
1874 I forgot to fix current-time-zone.
1875 (format_time_string): New function, containing most of
1876 what Fformat_time_string used to contain.
1877 (Fformat_time_string): Rewrite in terms of format_time_string.
1878 This doesn't change this function's behavior.
1879 (current-time-zone): Rewrite to use format_time_string.
1880 This fixes the bug reported by Michael Schierl in
1881 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1882 Jason Rumney's 2007-06-07 change worked around this bug, but
1883 didn't fix it.
1884 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1885
1886 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1887
1888 * xdisp.c (start_display): If the character at POS is displayed
1889 via a display vector, reset IT->current.dpvec_index to zero.
1890 (try_window_reusing_current_matrix): If a line ends in a display
1891 vector or the next line starts in a display vector, continue
1892 redrawing the window even though the character position of
1893 start_row was reached.
1894 (Bug#9771, part 2)
1895
1896 2011-10-18 Chong Yidong <cyd@gnu.org>
1897
1898 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1899 with nobreak-char-display too.
1900
1901 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1902
1903 Fix part 3 of bug#9771.
1904 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1905 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1906 non-neutral characters if the current character is a paragraph
1907 separator (a.k.a. Newline). This avoids running the same
1908 expensive loop twice, once when we consume the preceding newline
1909 and the other time when the line actually needs to be displayed.
1910 Avoid the loop when we see neutrals on the base embedding level
1911 following a character whose directionality is the same as the
1912 paragraph's. This avoids running the expensive loop when a line
1913 ends in a long sequence of neutrals, like control characters.
1914 Add assertion against STRONG_AL type. Slightly rearrange code
1915 that determines the type of a neutral given the first non-neutral
1916 that follows it.
1917 (bidi_level_of_next_char): Set next_en_pos to zero when
1918 invalidating its info.
1919
1920 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1921
1922 * xdisp.c (push_display_prop): Determine whether to record string
1923 or buffer position by IT->string, not by IT->method. Allow
1924 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1925 (move_it_vertically_backward): Don't look for character position
1926 immediately after the newline when in a continuation line.
1927 (Bug#9771, part 1)
1928
1929 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1930
1931 * window.c (coordinates_in_window): Rewrite and delabelize
1932 vertical border check. (Bug#5357) (Bug#9618)
1933
1934 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1935
1936 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1937 errors in XSetWindowBorder (bug#9310).
1938
1939 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1940
1941 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1942 avoid crash when xmalloc overrun checking is enabled.
1943
1944 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1945
1946 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1947 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1948 cursor motion with <left> and <right> arrow keys.
1949
1950 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1951 some callers set that themselves.
1952
1953 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1954
1955 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1956 display string and the previous row comes from the same string and
1957 is empty. (Bug#9739) (Bug#9738)
1958
1959 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1960
1961 * doc.c (get_doc_string): Encode file name (bug#9735).
1962
1963 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1964
1965 * bidi.c (bidi_level_of_next_char):
1966 * xdisp.c (get_visually_first_element): Remove old incorrect
1967 comments regarding the Unicode Line Separator character.
1968
1969 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1970
1971 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1972
1973 * alloc.c (Fgc_status): Do not access beyond zombies array
1974 boundary if nzombies > MAX_ZOMBIES.
1975 * alloc.c (dump_zombies): Add missing format specifier.
1976
1977 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1978
1979 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1980 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1981
1982 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1983 Some packages use them to denote characters with modifiers.
1984
1985 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1986
1987 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1988 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1989 matching a pp-number. Rename parameter var to var1.
1990
1991 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1992
1993 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1994
1995 2011-10-08 Glenn Morris <rgm@gnu.org>
1996
1997 * callint.c (Fcall_interactively): Give a more explicit error for the
1998 'c' case with a non-character input. (Bug#8479)
1999
2000 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2001
2002 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2003 lines.
2004 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2005 lines that are hscrolled on the left.
2006
2007 * dispnew.c (buffer_posn_from_coords): Account for a possible
2008 presence of header-line. (Bug#4426)
2009
2010 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2011
2012 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2013 Don't advertise functionality which we discourage or doesn't work.
2014
2015 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2016
2017 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2018 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2019 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2020 this makes Emacs dump core during garbage collection on rare
2021 occasions. sizeof is obviously inferior to offsetof here, so
2022 stick with offsetof.
2023 (GC_POINTER_ALIGNMENT): New macro.
2024 (mark_memory): Omit 3rd (offset) arg; caller changed.
2025 Don't assume EMACS_INT alignment is the same as pointer alignment.
2026
2027 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2028
2029 * keyboard.c (read_key_sequence_remapped): New var.
2030 (read_key_sequence): Compute remapping in the right buffer.
2031 (command_loop_1): Use read_key_sequence's remapping directly.
2032
2033 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2034
2035 * dired.c (file_name_completion): Don't expand file name.
2036 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2037 before checking file name handler.
2038
2039 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2040 they've been requested explicitly (bug#9591).
2041
2042 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2043
2044 * keymap.c (Fsingle_key_description): Use make_specified_string
2045 instead of build_string to build string from push_key_description.
2046 (Bug#5193)
2047
2048 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2049
2050 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2051 This fixes a Y2038 bug on 64-bit hosts.
2052 * buffer.c (reset_buffer):
2053 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2054 (Fclear_buffer_auto_save_failure):
2055 Use 0, not -1, to represent an unset failure time, since time_t
2056 might not be signed.
2057
2058 Remove dependency on glibc malloc internals.
2059 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2060 Move back here from lisp.h, but with their new implementations.
2061 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2062 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2063 * charset.c (charset_table_init): New static var.
2064 (syms_of_charset): Use it instead of xmalloc. This removes a
2065 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2066 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2067 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2068 Move back to alloc.c.
2069 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2070 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2071
2072 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2073
2074 * nsterm.m (windowDidResize): Call x_set_window_size only when
2075 ns_in_resize is true. Otherwise set pixelwidth/height and
2076 call change_frame_size (Bug#9628).
2077
2078 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2079
2080 Port --enable-checking=all to Fedora 14 x86-64.
2081 * charset.c (syms_of_charset): Also account for glibc malloc's
2082 internal overhead when calculating the initial malloc maximum.
2083
2084 Port --enable-checking=all to Fedora 14 x86.
2085 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2086 Move to lisp.h.
2087 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2088 (overrun_check_realloc, overrun_check_free):
2089 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2090 That way, xmalloc returns a properly-aligned pointer even if
2091 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2092 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2093 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2094 into account when calculating the initial malloc maximum.
2095 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2096 Move here from alloc.c, so that charset.c can use it too.
2097 Properly align; the old code wasn't right for common 32-bit hosts
2098 when configured with --enable-checking=all.
2099 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2100 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2101
2102 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2103
2104 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2105 use EDOM.
2106
2107 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2108
2109 * xdisp.c (compute_display_string_end): If there's no display
2110 string at CHARPOS, return -1.
2111
2112 * bidi.c (bidi_fetch_char): When compute_display_string_end
2113 returns a negative value, treat the character as a normal
2114 character not covered by a display string. (Bug#9624)
2115
2116 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2117
2118 * lread.c (Fread_from_string): Fix typo in docstring.
2119
2120 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2121
2122 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2123 newline, reseat the iterator instead of bidi-iterating there one
2124 character at a time. (Bug#9610)
2125 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2126 TO_CHARPOS if the bidi iterator is at base embedding level.
2127
2128 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2129
2130 * lread.c (readevalloop): Use correct code for NBSP.
2131 (read1): Likewise. (Bug#9608)
2132
2133 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2134
2135 * dbusbind.c (Fdbus_register_signal): When service is not
2136 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2137
2138 2011-09-25 Glenn Morris <rgm@gnu.org>
2139
2140 * buffer.c (truncate-lines): Doc fix.
2141
2142 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2143
2144 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2145 (Fset_window_next_buffers): Doc fix.
2146
2147 2011-09-24 Glenn Morris <rgm@gnu.org>
2148
2149 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2150
2151 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2152
2153 Fix minor problems found by static checking.
2154 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2155 * indent.c (Fvertical_motion): Fix == vs = typo.
2156
2157 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2158
2159 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2160 Default value is now t. Doc fix.
2161
2162 * indent.c (Fvertical_motion): Compute and apply the overshoot
2163 logic when moving up, not only when moving down. Fix the
2164 confusing name and values of the it_overshoot_expected variable;
2165 logic changes accordingly. (Bug#9254) (Bug#9549)
2166
2167 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2168 CHARPOS is covered by a display string which includes newlines.
2169 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2170 is covered by a display string with embedded newlines.
2171
2172 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2173
2174 * dbusbind.c (Fdbus_register_signal): Add match rule to
2175 Vdbus_registered_objects_table. (Bug#9581)
2176 (Fdbus_register_method, Vdbus_registered_objects_table):
2177 Fix docstring.
2178
2179 2011-09-24 Jim Meyering <meyering@redhat.com>
2180
2181 do not ignore write error for any output size
2182 The previous change was incomplete.
2183 While it makes emacs --batch detect the vast majority of stdout
2184 write failures, errors were still ignored whenever the output size is
2185 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2186 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2187 && echo FAIL: ignored write error
2188 FAIL: ignored write error
2189 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2190 && echo FAIL: ignored write error
2191 FAIL: ignored write error
2192 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2193
2194 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2195
2196 * emacs.c (Fkill_emacs): In noninteractive mode exit
2197 non-successfully if a write error occurred on stdout. (Bug#9574)
2198
2199 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2200
2201 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2202 the xassert test.
2203
2204 * dispextern.h (struct it): Update the comment documenting what
2205 can it->OBJECT be.
2206
2207 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2208
2209 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2210 a display string, extend search for cursor position to end of row.
2211 (find_row_edges): If the row ends in a newline from a display
2212 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2213 Handle the case of a display string with multiple newlines.
2214 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2215 non-empty line. Fixes confusing cursor motion with arrow keys at
2216 the beginning of a line that starts with whitespace.
2217
2218 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2219
2220 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2221 (bug#9493).
2222
2223 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2224
2225 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2226 boolean (Bug#9154).
2227
2228 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2229
2230 * xdisp.c (display_line): Record maximum and minimum buffer
2231 positions even if no glyphs were produced (e.g., by a zero-width
2232 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2233 buffer positions that will be removed from the glyph row because
2234 they don't fit.
2235 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2236 column is beyond frame width: don't subtract 1 "pixel" when
2237 computing width of the stretch.
2238 (reseat_at_next_visible_line_start): Undo the change made on
2239 2011-09-17 that saved paragraph information and restored it after
2240 the call to `reseat'. (Bug#9545)
2241
2242 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2243
2244 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2245 and turn window cursor on if cleared (Bug#9415).
2246
2247 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2248
2249 * search.c (boyer_moore): Take unibyte characters from pattern
2250 literally. (Bug#9458)
2251
2252 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2253
2254 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2255
2256 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2257
2258 Fix minor problem found by static checking.
2259 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2260 initialized, to pacify gcc -Wuninitialized.
2261
2262 * fileio.c: Report proper errno when syscall falls.
2263 (Finsert_file_contents): Save and restore errno,
2264 so that report_file_error outputs the correct diagnostic.
2265 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2266
2267 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2268
2269 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2270
2271 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2272
2273 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2274 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2275
2276 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2277
2278 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2279 about the current paragraph and restore it after the call to reseat.
2280
2281 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2282 (bidi_find_paragraph_start): Search back for paragraph beginning
2283 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2284 (bidi_move_to_visually_next): Only trigger paragraph-related
2285 computations when the last character is a newline or at EOB, not
2286 just any NEUTRAL_B. (Bug#9470)
2287
2288 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2289 truncated lines if point is covered by a display string. (Bug#9524)
2290
2291 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2292
2293 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2294 (cons_to_x_long): New function.
2295 (lisp_data_to_selection_data): Use it. Correct the test for
2296 short-versus-long data; it was negated. Break out of vector
2297 loop, for efficiency, when a long datum is discovered.
2298
2299 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2300
2301 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2302
2303 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2304
2305 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2306 GCC PR/17406) by declaring this function with external scope.
2307
2308 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2309
2310 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2311 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2312
2313 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2314
2315 * editfns.c (Fformat): Correctly handle text properties on "%%".
2316
2317 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2318
2319 * xterm.c (x_draw_composite_glyph_string_foreground):
2320 * w32term.c (x_draw_composite_glyph_string_foreground):
2321 * term.c (encode_terminal_code):
2322 * composite.c (composition_update_it, get_composition_id):
2323 * xdisp.c (get_next_display_element)
2324 (fill_composite_glyph_string): Add comments about special meaning
2325 of TAB characters in a composition.
2326
2327 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2328
2329 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2330 This occurs when processing a multibyte format.
2331 Problem reported by Wolfgang Jenker.
2332
2333 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2334
2335 * xdisp.c (try_cursor_movement): Only check for exact match if
2336 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2337
2338 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2339
2340 Remove unused external symbols.
2341 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2342 * xdisp.c (calc_pixel_width_or_height): Now static.
2343 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2344 * indent.c (check_display_width):
2345 * w32term.c: Fix comment to match code.
2346 * xterm.c, xterm.h (x_catching_errors): Remove.
2347
2348 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2349
2350 * xselect.c: Use signed conversions more consistently (Bug#9498).
2351 (selection_data_to_lisp_data): Assume incoming selection data are
2352 signed integers, not unsigned. This is to be consistent with
2353 outgoing selection data, which was modified to use signed integers
2354 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2355 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2356 expects long, not unsigned long.
2357
2358 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2359
2360 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2361 computation of loop end. Reported by Johan Bockgård
2362 <bojohan@gnu.org>.
2363
2364 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2365
2366 * frame.c (Fother_visible_frames_p): Function deleted.
2367
2368 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2369
2370 * indent.c (compute_motion): Process display vector front to back
2371 rather than the other way around. (Bug#2496)
2372
2373 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2374
2375 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2376
2377 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2378
2379 * minibuf.c (Fread_from_minibuffer): Doc fix.
2380
2381 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2382
2383 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2384 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2385
2386 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2387
2388 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2389 value for non-existent files.
2390
2391 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2392
2393 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2394 set its "size" to -1. This will set the modtime_size field of
2395 the corresponding buffer to -1, which is what
2396 verify-visited-file-modtime expects for files that do not exist.
2397 (Bug#9139)
2398
2399 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2400
2401 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2402 here ...
2403 * lisp.h: ... from here. push_key_description is no longer
2404 defined in keyboard.c, so its declaration should not be in
2405 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2406 logically belongs with push_key_description.
2407
2408 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2409
2410 * buffer.h: Include <sys/types.h> instead of <time.h>.
2411 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2412 Problem reported by Herbert J. Skuhra.
2413
2414 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2415
2416 * xml.c (parse_region): Make the parsing work for
2417 non-comment-starting XML files again (bug#9144).
2418
2419 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2420
2421 * image.c (gif_load): Fix calculation of bottom and right corner.
2422 (Bug#9468)
2423
2424 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2425
2426 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2427 redisplay in small windows.
2428
2429 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2430
2431 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2432
2433 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2434
2435 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2436 Operate on live windows only.
2437
2438 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2439
2440 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2441
2442 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2443
2444 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2445 only under bidi iteration.
2446
2447 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2448
2449 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2450
2451 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2452
2453 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2454 Without this fix, the command to link temacs failed due to an
2455 undefined symbol __builtin_isnan. This is because
2456 /usr/include/iso/math_c99.h #defines isnan(x) to
2457 __builtin_isnan(x), but the bundled gcc, which identifies itself
2458 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2459 a __builtin_isnan.
2460 * floatfns.c (isnan): #undef, and then #define to a clone of
2461 what's in data.c.
2462 (Fisnan): Always define, since it's always available now.
2463 (syms_of_floatfns): Always define isnan at the Lisp level.
2464
2465 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2466
2467 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2468
2469 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2470
2471 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2472 The previous code assumed that file offsets (off_t values) fit in
2473 EMACS_INT variables, which is not true on typical 32-bit hosts.
2474 The code messed up by falsely reporting buffer overflow in cases
2475 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2476 when "big" contains more than 2**29 bytes, even though this
2477 inserts just one byte and does not overflow the buffer.
2478 (Finsert_file_contents): Store file offsets as off_t
2479 values, not as EMACS_INT values. Check for overflow when
2480 converting between EMACS_INT and off_t. When checking for
2481 buffer overflow or for overlap, take the offsets into account.
2482 Don't use EMACS_INT for small values where int suffices.
2483 When checking for overlap, fix a typo: ZV was used where
2484 ZV_BYTE was intended.
2485 (Fwrite_region): Don't assume off_t fits into 'long'.
2486 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2487
2488 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2489
2490 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2491
2492 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2493
2494 sprintf-related integer and memory overflow issues (Bug#9412).
2495
2496 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2497 (esprintf, exprintf, evxprintf): New functions.
2498 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2499 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2500 (modify_event_symbol): Do not assume that the length of
2501 name_alist_or_stem is safe to alloca and fits in int.
2502 (Fexecute_extended_command): Likewise for function name and binding.
2503 (Frecursion_depth): Wrap around reliably on integer overflow.
2504 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2505 since some callers pass EMACS_INT values.
2506 (Fsingle_key_description): Don't crash if symbol name contains more
2507 than MAX_ALLOCA bytes.
2508 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2509 (get_minibuffer): Arg is now EMACS_INT, not int.
2510 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2511 (esprintf, exprintf, evxprintf): New decls.
2512 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2513
2514 * dbusbind.c (signature_cat): New function.
2515 (xd_signature, Fdbus_register_signal):
2516 Do not overrun buffer; instead, report string overflow.
2517
2518 * dispnew.c (add_window_display_history): Don't overrun buffer.
2519 Truncate instead; this is OK since it's just a log.
2520
2521 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2522 even if the time zone offset is outlandishly large.
2523 Don't mishandle offset == INT_MIN.
2524
2525 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2526 when creating daemon; the previous buffer-overflow check was incorrect.
2527
2528 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2529 which has the guts of the old verror function.
2530
2531 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2532 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2533
2534 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2535 (font_unparse_xlfd): Don't blindly alloca long strings.
2536 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2537 fits in int, when using sprintf. Use single snprintf to count
2538 length of string rather than counting it via multiple sprintfs;
2539 that's simpler and more reliable.
2540 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2541 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2542 sprintf, in case result does not fit in int.
2543
2544 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2545 (fontset_from_font): Print it.
2546
2547 * frame.c (tty_frame_count): Now printmax_t, not int.
2548 (make_terminal_frame, set_term_frame_name): Print it.
2549 (x_report_frame_params): In X, window IDs are unsigned long,
2550 not signed long, so print them as unsigned.
2551 (validate_x_resource_name): Check for implausibly long names,
2552 and don't assume name length fits in 'int'.
2553 (x_get_resource_string): Don't blindly alloca invocation name;
2554 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2555 not fit in int.
2556
2557 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2558 (xg_check_special_colors, xg_set_geometry):
2559 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2560
2561 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2562 Use esprintf, not sprintf, in case result does not fit in int.
2563
2564 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2565 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2566 it as a large positive number.
2567 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2568 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2569
2570 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2571 in case result does not fit in int.
2572
2573 * print.c (float_to_string): Detect width overflow more reliably.
2574 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2575 buffer overrun. Don't assume list length fits in 'int'. Treat
2576 print length of 0 as 0, not as infinity; to be consistent with other
2577 uses of print length in this function. Don't overflow print length
2578 index. Don't assume hash table size fits in 'long', or that
2579 vectorlike size fits in 'unsigned long'.
2580
2581 * process.c (make_process): Use printmax_t, not int, to format
2582 process-name gensyms.
2583
2584 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2585
2586 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2587 to avoid potential buffer overrun.
2588
2589 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2590 if X resource line is longer than 512 bytes.
2591
2592 * xfns.c (x_window): Make sprintf buffer a bit bigger
2593 to avoid potential buffer overrun.
2594
2595 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2596
2597 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2598
2599 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2600
2601 Integer overflow fixes for scrolling, etc.
2602 Without these, Emacs silently mishandles large integers sometimes.
2603 For example, "C-u 4294967297 M-x recenter" was treated as if
2604 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2605
2606 * xdisp.c (try_window_id): Check Emacs fixnum range before
2607 converting to 'int'.
2608
2609 * window.c (window_scroll_line_based, Frecenter):
2610 Check that an Emacs fixnum is in range before assigning it to 'int'.
2611 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2612 values converted from Emacs fixnums.
2613 (Frecenter): Don't wrap around a line count if it is out of 'int'
2614 range; instead, treat it as an extreme value.
2615 (Fset_window_configuration, compare_window_configurations):
2616 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2617
2618 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2619 that can exceed INT_MAX. Check that EMACS_INT value is in range
2620 before assigning it to the (possibly-narrower) index.
2621 (match_limit): Don't assume that a fixnum can fit in 'int'.
2622
2623 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2624 exceed INT_MAX.
2625
2626 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2627 (Fvertical_motion): Don't wrap around LINES values that don't fit
2628 in 'int'. Instead, treat them as extreme values. This is good
2629 enough for windows, which can't have more than INT_MAX lines anyway.
2630
2631 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2632
2633 * Require libxml/parser.h to avoid compilation warning.
2634
2635 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2636
2637 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2638 since this reportedly can destroy thread storage.
2639
2640 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2641
2642 * syntax.c (find_defun_start): Update all cache variables if
2643 exiting early (Bug#9401).
2644
2645 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2646
2647 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2648
2649 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2650 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2651 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2652
2653 * term.c (tty_append_glyph): New function.
2654 (produce_stretch_glyph): Static function and its prototype deleted.
2655
2656 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2657 Add prototypes.
2658
2659 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2660
2661 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2662 when checking :margin (Bug#9390).
2663 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2664 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2665 so that the name doesn't mislead. All uses changed.
2666
2667 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2668
2669 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2670 set_tty_hooks.
2671
2672 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2673
2674 * xdisp.c (move_it_to): Don't bail out early when reaching
2675 position beyond to_charpos, if we are scanning backwards.
2676 (move_it_vertically_backward): When DY == 0, make sure we get to
2677 the first character in the line after the newline.
2678
2679 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2680
2681 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2682 (ccl_driver): Do not generate an out-of-range pointer.
2683 (Fccl_execute_on_string): Remove unnecessary check for
2684 integer overflow, noted by Stefan Monnier in
2685 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2686 Remove a FIXME that didn't need fixing.
2687 Simplify the newly-introduced buffer reallocation code.
2688
2689 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2690
2691 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2692
2693 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2694
2695 Integer and memory overflow issues (Bug#9196).
2696
2697 * doc.c (get_doc_string): Rework so that
2698 get_doc_string_buffer_size is the actual buffer size, rather than
2699 being 1 less than the actual buffer size; this makes xpalloc more
2700 convenient.
2701
2702 * image.c (x_allocate_bitmap_record, cache_image):
2703 * xselect.c (Fx_register_dnd_atom):
2704 Simplify previous changes by using xpalloc.
2705
2706 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2707 since either will do and ptrdiff_t is convenient with xpalloc.
2708
2709 * charset.c (charset_table_size)
2710 (struct charset_sort_data.priority): Now ptrdiff_t.
2711 (charset_compare): Don't overflow if priorities differ greatly.
2712 (Fsort_charsets): Don't assume list length fits in int.
2713 Check for size-calculation overflow when allocating sort data.
2714 (syms_of_charset): Allocate an initial charset table that is
2715 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2716
2717 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2718
2719 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2720 The actual value is always <= INT_MAX, and leaving it unsigned made
2721 overflow checking harder.
2722
2723 * dispextern.h (struct glyph_matrix.rows_allocated)
2724 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2725 with xpalloc. The values are still always <= INT_MAX.
2726
2727 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2728
2729 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2730 (SAFE_NALLOCA): New macro.
2731
2732 * region-cache.c (struct boundary.pos, find_cache_boundary)
2733 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2734 (set_cache_region, invalidate_region_cache)
2735 (revalidate_region_cache, know_region_cache, region_cache_forward)
2736 (region_cache_backward, pp_cache):
2737 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2738 so that ptrdiff_t * can be passed to xpalloc.
2739 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2740 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2741 (pp_cache): Don't assume cache_len fits in int.
2742 * region-cache.h: Adjust extern decls to match.
2743
2744 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2745 EMACS_INT, since either will do, for xpalloc.
2746
2747 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2748 (xnmalloc, xnrealloc, xpalloc): New functions.
2749
2750 * bidi.c (bidi_shelve_header_size): New constant.
2751 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2752 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2753
2754 * bidi.c (bidi_cache_shrink):
2755 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2756 (overlay_strings):
2757 Don't update size of array until after memory allocation succeeds,
2758 because xmalloc/xrealloc may not return.
2759 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2760 now that we have proper integer overflow checking.
2761 (record_overlay_string, overlay_strings): Catch overflows when
2762 calculating size of overlay_str_buf.
2763
2764 * callproc.c (Fcall_process): Check for size overflow when
2765 calculating size of args2.
2766 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2767 Normally we prefer signed values, but sticking with ptrdiff_t would
2768 require adding more-complicated checks.
2769
2770 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2771 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2772 Redo buffer-overflow calculations to avoid integer overflow.
2773 Add a FIXME comment where memory seems to be over-allocated.
2774
2775 * character.c (Fstring): Check for size-calculation overflow.
2776
2777 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2778 unnecessary integer overflow. Check for size overflow.
2779 (encode_coding_object): Don't update size until xmalloc succeeds.
2780
2781 * composite.c (get_composition_id): Check for overflow in glyph
2782 length calculations.
2783
2784 Integer and memory overflow fixes for display code.
2785 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2786 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2787 (scrolling_window): Check for overflow in size calculations.
2788 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2789 Don't assume glyph table len fits in int.
2790 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2791 (row_table_size): Now ptrdiff_t, not int.
2792 (scrolling_window): Avoid overflow in size calculations.
2793 Don't update size until allocation succeeds.
2794 * fns.c (concat): Check for overflow in size calculations.
2795 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2796 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2797 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2798
2799 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2800 (get_doc_string): Check for size calculation overflow.
2801 Don't update size until allocation succeeds.
2802 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2803 EMACS_INT, where ptrdiff_t will do.
2804 (Fsubstitute_command_keys): Check for string overflow.
2805
2806 * editfns.c (set_time_zone_rule): Don't assume environment length
2807 fits in int.
2808 (message_length): Now ptrdiff_t, not int.
2809 (Fmessage_box): Don't update size until allocation succeeds.
2810 Don't assume message length fits in int.
2811 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2812
2813 * emacs.c (main): Do not reallocate argv, since there is a null at
2814 the end that can be overwritten, and this way there's no need to
2815 worry about size-calculation overflow.
2816 (sort_args): Check for size-calculation overflow.
2817
2818 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2819 alloc succeeds.
2820 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2821
2822 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2823 (x_set_scroll_bar_width, x_figure_window_size):
2824 Check for integer overflow.
2825 (x_set_alpha): Do not assume XINT fits in int.
2826
2827 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2828 This is for the members text_lines, text_cols, total_lines, total_cols,
2829 where the system imposes an 'int' limit.
2830
2831 * fringe.c (Fdefine_fringe_bitmap):
2832 Don't update size until alloc works.
2833
2834 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2835 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2836
2837 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2838 Check for size-calculation overflow.
2839 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2840 do, as we prefer signed integers.
2841 (id_to_widget.max_size, id_to_widget.used)
2842 (xg_store_widget_in_map, xg_remove_widget_from_map)
2843 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2844 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2845 Use and return ptrdiff_t, not int.
2846 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2847 * gtkutil.h: Change prototypes to match the above.
2848
2849 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2850 are duplicate now that they've been promoted to lisp.h.
2851 (x_allocate_bitmap_record, x_alloc_image_color)
2852 (make_image_cache, cache_image, xpm_load):
2853 Don't update size until alloc is done.
2854 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2855 (x_detect_edges):
2856 Check for size calculation overflow.
2857 (ct_colors_allocated_max): New constant.
2858 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2859 overflow.
2860
2861 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2862 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2863 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2864 Use ptrdiff_t, not int, to count maps.
2865 (read_char_minibuf_menu_prompt): Check for overflow in size
2866 calculations. Don't update size until allocation succeeds.
2867 Redo calculations to avoid overflow.
2868 * keyboard.h: Change prototypes to match the above.
2869
2870 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2871 to count maps.
2872 (current_minor_maps): Check for size calculation overflow.
2873 * keymap.h: Change prototypes to match the above.
2874
2875 * lread.c (read1, init_obarray): Don't update size until alloc done.
2876
2877 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2878 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2879
2880 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2881 Now ptrdiff_t, not int.
2882 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2883 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2884
2885 * process.c (Fnetwork_interface_list): Check for overflow
2886 in size calculation.
2887
2888 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2889
2890 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2891 overflow. Don't bother calling xmalloc when xrealloc will do.
2892
2893 * search.c (Freplace_match): Check for size calculation overflow.
2894 (Fset_match_data): Don't assume list lengths fit in 'int'.
2895
2896 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2897 for command line length. Do not attempt to address one before the
2898 beginning of an array, as that's not portable.
2899
2900 * term.c (max_frame_lines): Remove; unused.
2901 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2902 not int.
2903 (encode_terminal_code, calculate_costs): Check for size
2904 calculation overflow.
2905 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2906 table lengths and related sizes. Don't update size until alloc
2907 done. Redo calculations to avoid overflow.
2908 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2909
2910 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2911 subtracting pointers.
2912 (gobble_line): Check for overflow more carefully. Don't update size
2913 until alloc done.
2914
2915 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2916 Don't update size until alloc done.
2917 Redo size calculations to avoid overflow.
2918 Check for size calculation overflow.
2919 (main) [DEBUG]: Fix typo in invoking tparam1.
2920
2921 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2922 Use ptrdiff_t, not int, for sizes.
2923 (store_mode_line_noprop_char): Don't update size until alloc done.
2924
2925 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2926 Use ptrdiff_t, not int, for sizes.
2927 (Finternal_make_lisp_face, cache_face):
2928 Check for size calculation overflow.
2929 (cache_face): Treat size calculation overflows as if they were
2930 memory exhaustion (the usual treatment), rather than aborting.
2931
2932 * xfns.c (x_encode_text, x_set_name_internal)
2933 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2934 sizes, since they can exceed INT_MAX in size. Check for size
2935 calculation overflow.
2936
2937 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2938 (xg_select): Check for size calculation overflow.
2939 Don't update size until alloc done.
2940
2941 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2942 as sprintf is limited to int lengths.
2943
2944 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2945 (X_LONG_MIN): New macros.
2946 Use them to make the following changes clearer.
2947 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2948 This change doesn't affect the value now, but it may help remind
2949 future maintainers not to raise the value too much later.
2950 (SELECTION_QUANTUM): Remove, replacing with ...
2951 (selection_quantum): ... new function, which avoids overflow.
2952 All uses changed.
2953 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2954 assumption that selection length fits in 'int'.
2955 (x_reply_selection_request, x_handle_selection_request)
2956 (x_get_window_property, receive_incremental_selection)
2957 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2958 (lisp_data_to_selection_data, clean_local_selection_data):
2959 Use ptrdiff_t, not int, to record length of selection.
2960 (x_reply_selection_request, x_get_window_property)
2961 (receive_incremental_selection, x_property_data_to_lisp):
2962 Redo calculations to avoid overflow.
2963 (x_reply_selection_request): When sending hint, ceiling it at
2964 X_LONG_MAX rather than relying on wraparound overflow to send
2965 something.
2966 (x_get_window_property, receive_incremental_selection)
2967 (lisp_data_to_selection_data, x_property_data_to_lisp):
2968 Check for size-calculation overflow.
2969 (x_get_window_property, receive_incremental_selection)
2970 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2971 Don't store size until memory allocation succeeds.
2972 (x_get_window_property): Plug memory leak on memory exhaustion.
2973 Don't double-block input; malloc is safe here. Don't assume 2**34
2974 - 4 fits in unsigned long. Add an xassert to check
2975 XGetWindowProperty overflow. Be more careful about overflow
2976 calculations, and distinguish size from memory overflow better.
2977 (receive_incremental_selection): When tracing, don't assume
2978 unsigned int is less than INT_MAX.
2979 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2980 harmful) conversions of unsigned short to int.
2981 (lisp_data_to_selection_data): Don't assume that integers
2982 in the range -65535 through -1 fit in an X unsigned short.
2983 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2984 result parameters unless successful. Rely on cons_to_unsigned
2985 to report problems with elements; the old code wasn't right anyway.
2986 (x_check_property_data): Check for int overflow; we cannot use
2987 a wider type due to X limits.
2988 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2989
2990 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2991
2992 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2993 (x_term_init): Check for size calculation overflow.
2994 (x_color_cells): Don't store size until memory allocation succeeds.
2995 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2996 Don't assume alloca size is less than MAX_ALLOCA.
2997 (x_term_init): Don't assume length fits in int (sprintf is limited
2998 to int size).
2999
3000 Use ptrdiff_t for composition IDs.
3001 * character.c (lisp_string_width):
3002 * composite.c (composition_table_size, n_compositions)
3003 (get_composition_id, composition_gstring_from_id):
3004 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3005 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3006 * window.c (Frecenter):
3007 Use ptrdiff_t, not int, for composition IDs.
3008 * composite.c (get_composition_id): Check for integer overflow.
3009 * composite.h: Adjust prototypes to match the above changes.
3010
3011 Use ptrdiff_t for hash table indexes.
3012 * category.c (hash_get_category_set):
3013 * ccl.c (ccl_driver):
3014 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3015 * coding.c (coding_system_charset_list, detect_coding_system):
3016 * coding.h (struct coding_system.id):
3017 * composite.c (get_composition_id, gstring_lookup_cache):
3018 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3019 * image.c (xpm_get_color_table_h):
3020 * lisp.h (hash_lookup, hash_put):
3021 * minibuf.c (Ftest_completion):
3022 Use ptrdiff_t for hash table indexes, not int (which is too
3023 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3024 32-bit --with-wide-int hosts).
3025
3026 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3027 Add a FIXME comment about memory leaks.
3028 (syms_of_charset): Don't assume xmalloc returns.
3029
3030 Don't assume that stated character widths fit in int.
3031 * character.c (Fchar_width, c_string_width, lisp_string_width):
3032 * character.h (CHAR_WIDTH):
3033 * indent.c (MULTIBYTE_BYTES_WIDTH):
3034 Use sanitize_char_width to avoid undefined and/or bad behavior
3035 with outlandish widths.
3036 * character.h (sanitize_tab_width): Rename from sanitize_width,
3037 now that we have two such functions. All uses changed.
3038 (sanitize_char_width): New inline function.
3039
3040 Don't assume that tab-width fits in int.
3041 * character.h (sanitize_width): New inline function.
3042 (SANE_TAB_WIDTH): New macro.
3043 (ASCII_CHAR_WIDTH): Use it.
3044 * indent.c (sane_tab_width): Remove. All uses replaced by
3045 SANE_TAB_WIDTH (current_buffer).
3046 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3047
3048 * fileio.c: Integer overflow issues with file modes.
3049 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3050
3051 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3052 Remove unreachable code.
3053 (read_hex, load_charset_map_from_file): Check for integer overflow.
3054
3055 * xterm.c: Don't go over XClientMessageEvent limit.
3056 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3057 (x_send_scroll_bar_event): Likewise. Check that the size does not
3058 exceed limits imposed by XClientMessageEvent, as well as the usual
3059 ptrdiff_t and size_t limits.
3060
3061 * keyboard.c: Overflow, signedness and related fixes.
3062 (make_lispy_movement): Use same integer type in forward decl
3063 that is used in the definition.
3064 (read_key_sequence, keyremap_step):
3065 Change bufsize argument back to int, undoing my 2011-03-30 change.
3066 We prefer signed types, and int is wide enough here.
3067 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3068 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3069 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3070 length, not size_t. Use ptrdiff_t for index, not int.
3071 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3072 possibility of integer overflow.
3073
3074 Overflow, signedness and related fixes for images.
3075
3076 * dispextern.h (struct it.stack[0].u.image.image_id)
3077 (struct_it.image_id, struct image.id, struct image_cache.size)
3078 (struct image_cache.used, struct image_cache.ref_count):
3079 * gtkutil.c (update_frame_tool_bar):
3080 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3081 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3082 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3083 * nsmenu.m (update_frame_tool_bar):
3084 * xdisp.c (calc_pixel_width_or_height):
3085 * xfns.c (image_cache_refcount):
3086 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3087 on typical 64-bit hosts.
3088
3089 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3090 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3091 Omit unnecessary casts to int.
3092 (parse_image_spec): Check that integers fall into 'int' range
3093 when the callers expect that.
3094 (image_ascent): Redo ascent calculation to avoid int overflow.
3095 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3096 (lookup_image): Remove unnecessary tests.
3097 (xbm_image_p): Locals are now of int, not EMACS_INT,
3098 since parse_image_check makes sure they fit into int.
3099 (png_load, gif_load, svg_load_image):
3100 Prefer int to unsigned where either will do.
3101 (tiff_handler): New function, combining the cores of the
3102 old tiff_error_handler and tiff_warning_handler.
3103 This function is rewritten to use vsnprintf and thereby avoid
3104 stack buffer overflows. It uses only the features of vsnprintf
3105 that are common to both POSIX and native Microsoft.
3106 (tiff_error_handler, tiff_warning_handler): Use it.
3107 (tiff_load, gif_load, imagemagick_load_image):
3108 Don't assume :index value fits in 'int'.
3109 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3110 (imagemagick_load_image): Check that crop parameters fit into
3111 the integer types that MagickCropImage accepts. Don't assume
3112 Vimagemagick_render_type has a nonnegative value. Don't assume
3113 size_t fits in 'long'.
3114 (gs_load): Use printmax_t to print the widest integers possible.
3115 Check for integer overflow when computing image height and width.
3116
3117 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3118
3119 * xdisp.c (redisplay_window): Don't force window start if point
3120 will be invisible in the resulting window. (Bug#9324)
3121
3122 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3123
3124 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3125 the display spec is of the form `(space ...)'.
3126 (handle_display_spec): Return the value returned by
3127 handle_single_display_spec, not just 1 or zero.
3128 (handle_single_display_spec): If the display spec is of the form
3129 `(space ...)', and specifies display in the text area, return 2
3130 rather than 1.
3131 (try_cursor_movement): Check for the need to scroll more
3132 accurately, and prefer exact match for point under bidi.
3133 Don't advance `row' beyond the last row of the window.
3134
3135 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3136 into disp_prop; all users changed.
3137
3138 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3139 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3140 for the text covered by the display property.
3141
3142 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3143
3144 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3145 Change return value to nil.
3146 (Frecord_buffer): Delete unused function.
3147
3148 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3149
3150 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3151 buffers, return left-to-right.
3152 (set_cursor_from_row): Consider candidate row a win if its glyph
3153 represents a newline and point is on that newline. Fixes cursor
3154 positioning on the newline at EOL of R2L text within L2R
3155 paragraph, and vice versa.
3156 (try_cursor_movement): Check continued rows, in addition to
3157 continuation rows. Fixes unwarranted scroll when point enters a
3158 continued line of R2L text within an L2R paragraph, or vice versa.
3159 (cursor_row_p): Consider the case of point being equal to
3160 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3161 from the end of a short line to the beginning of a continued line
3162 of R2L text within L2R paragraph.
3163 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3164 composed characters.
3165
3166 * bidi.c (bidi_check_type): Use xassert.
3167 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3168 members.
3169
3170 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3171
3172 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3173 a character.
3174
3175 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3176
3177 * nsfont.m (ns_otf_to_script): Fix typo.
3178
3179 2011-08-22 Kenichi Handa <handa@m17n.org>
3180
3181 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3182 extra slot even if the purpose is char-code-property-table.
3183
3184 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3185
3186 * xdisp.c (redisplay_window): When computing centering_position,
3187 account for the height of the header line. (Bug#8874)
3188
3189 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3190 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3191 candidate is selected by the mouse, and that candidate has a
3192 composed character under the mouse.
3193
3194 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3195 coordinates reported by pos-visible-in-window-p for a composed
3196 character in column zero.
3197
3198 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3199
3200 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3201
3202 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3203
3204 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3205 consider it a hit if to_charpos is anywhere in the range of the
3206 composed buffer positions.
3207
3208 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3209
3210 * image.c (gif_load): Don't assume that each subimage has the same
3211 dimensions as the base image. Handle disposal method that is
3212 "undefined" by the gif spec (Bug#9335).
3213
3214 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3215
3216 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3217 (Fcondition_case): Document `debug' symbol in error handler.
3218
3219 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3220
3221 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3222 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3223 from an Org mode buffer to a Speedbar frame.
3224
3225 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3226 a composition, take its buffer position from IT->cmp_it.charpos.
3227 Fixes cursor positioning at the beginning of a line that begins
3228 with a composed character.
3229
3230 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3231
3232 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3233 character bidirectional type, use STRONG_L instead. Fixes crashes
3234 in a buffer produced by `describe-categories'.
3235
3236 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3237 members before the level stack, so they would be saved and
3238 restored when copying iterator state. Fixes incorrect reordering
3239 around TABs covered by display properties.
3240
3241 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3242
3243 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3244
3245 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3246
3247 * eval.c (internal_condition_case, internal_condition_case_1)
3248 (internal_condition_case_2, internal_condition_case_n):
3249 Remove unnecessary aborts (Bug#9081).
3250
3251 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3252
3253 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3254 has no `load' handler, try opening the file locally. (Bug#9311)
3255
3256 2011-08-16 Ken Brown <kbrown@cornell.edu>
3257
3258 * gmalloc.c: Expand comment.
3259
3260 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3261
3262 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3263 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3264
3265 2011-08-16 Ken Brown <kbrown@cornell.edu>
3266
3267 Fix memory allocation problems in Cygwin build (Bug#9273).
3268
3269 * unexcw.c ( __malloc_initialized): Declare external variable.
3270 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3271
3272 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3273 New variables.
3274 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3275 dumped emacs.
3276 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3277 in the static heap.
3278 [CYGWIN] (special_realloc): New function.
3279 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3280 requests to realloc storage in the static heap.
3281
3282 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3283
3284 * bidi.c (bidi_initialize): Remove unused local.
3285
3286 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3287
3288 * bidimirror.h:
3289 * biditype.h: Remove file.
3290 * makefile.w32-in ($(BLD)/bidi.$(O)):
3291 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3292
3293 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3294
3295 * chartab.c: Improve commentary for the uniprop_table API.
3296
3297 * bidi.c (bidi_paragraph_init): Support zero value of
3298 bidi_ignore_explicit_marks_for_paragraph_level.
3299 (bidi_initialize): Use uniprop_table instead of including
3300 biditype.h and bidimirror.h.
3301
3302 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3303 coordinates of the iterator when restoring from ppos_it.
3304 (Bug#9296)
3305
3306 2011-08-14 Kenichi Handa <handa@m17n.org>
3307
3308 * process.c (create_process): Call setup_process_coding_systems
3309 after the pid of the process is set to -1 (Bug#8162).
3310
3311 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3312
3313 * xdisp.c (move_it_in_display_line_to): Don't invoke
3314 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3315 ppos_it. Fixes vertical cursor motion when line beginning is
3316 covered by an image. (Bug#9296)
3317
3318 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3319
3320 * nsterm.h (ns_run_ascript): Declare.
3321 (NSAPP_DATA2_RUNASSCRIPT): Define.
3322
3323 * nsfns.m (as_script, as_result, as_status): New static variables.
3324 (ns_run_ascript): New function.
3325 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3326 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3327 the event loop. Get status from as_status (Bug#7276).
3328
3329 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3330 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3331 the event loop (Bug#7276).
3332
3333 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3334
3335 * gnutls.c (QCgnutls_bootprop_priority)
3336 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3337 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3338 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3339 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3340 (QCgnutls_bootprop_verify_hostname_error)
3341 (QCgnutls_bootprop_callbacks_verify): Rename from
3342 Qgnutls_bootprop_..., all uses changed.
3343
3344 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3345 uses changed.
3346
3347 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3348
3349 * xfaces.c (Qframe_set_background_mode): Now static.
3350 * dispextern.h (Qframe_set_background_mode): Remove decl.
3351
3352 * process.c (Fnetwork_interface_info): Declare local only if needed.
3353
3354 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3355
3356 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3357 (Fnetwork_interface_list): Allocate in increments of bytes instead
3358 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3359 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3360 sockaddr.
3361 (struct ifflag_def): notrailers is smart on OSX.
3362 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3363 Get hardware address with getifaddrs if available.
3364
3365 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3366
3367 * xdisp.c (iterate_out_of_display_property): xassert that
3368 IT->position is set to within IT->object's boundaries. Break from
3369 the loop as soon as EOB is reached; avoids infloops in redisplay
3370 when IT->position is set up wrongly due to some bug.
3371 Set IT->current to match the bidi iterator unconditionally.
3372 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3373 entry. Force push_it to save on the stack the current
3374 buffer/string position, to be restored by pop_it. Fix flags in
3375 the iterator structure wrt the object coming from a display
3376 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3377 properties. (Bug#9284)
3378
3379 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3380
3381 * fontset.c (fontset_get_font_group): Add proper type checks.
3382 (Bug#9172)
3383
3384 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3385
3386 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3387 and LC_VERSION_MIN_MACOSX.
3388 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3389 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3390
3391 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3392
3393 * xdisp.c (forward_to_next_line_start): Allow to use the
3394 no-display-properties-and-no-overlays under bidi display.
3395 Set disp_pos in the bidi iterator to avoid searches for display
3396 properties and overlays.
3397
3398 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3399
3400 * editfns.c (Fset_time_zone_rule): Document relationship with the
3401 setenv function.
3402
3403 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3404 the font entity extracted from the cache (Bug#8109).
3405
3406 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3407
3408 * composite.c (autocmp_chars): Don't reset point. That is done by
3409 restore_point_unwind (Bug#5984).
3410
3411 2011-08-07 Juri Linkov <juri@jurta.org>
3412
3413 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3414 to show the arg `TIME' instead of `TIMEVAL'.
3415
3416 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3417
3418 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3419 display property strides EOL and includes a newline, as in
3420 longlines-mode. (Bug#9254)
3421 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3422 word-wrap under bidirectional display. (Bug#9224)
3423
3424 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3425 is non-zero, even if the data buffer is NULL. Fixes a crash in
3426 vertical-motion with longlines-mode. (Bug#9254)
3427
3428 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3429
3430 * bidi.c <bidi_cache_total_alloc>: Now static.
3431 (bidi_initialize): Initialize bidi_cache_total_alloc.
3432
3433 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3434 cache. (Bug#9221)
3435
3436 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3437 amount allocated this far in `bidi_cache_total_alloc'.
3438 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3439 non-zero, only free the data buffer without restoring the cache
3440 contents. All callers changed.
3441
3442 * dispextern.h (bidi_unshelve_cache): Update prototype.
3443
3444 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3445 (move_it_in_display_line, move_it_to)
3446 (move_it_vertically_backward, move_it_by_lines): Replace the call
3447 to xfree to an equivalent call to bidi_unshelve_cache.
3448 (move_it_in_display_line_to): Fix logic of returning
3449 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3450
3451 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3452
3453 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3454 came from a string character with a `cursor' property. (Bug#9229)
3455
3456 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3457
3458 * Makefile.in (LIB_PTHREAD): New variable.
3459 (LIBES): Add LIB_PTHREAD (Bug#9216).
3460
3461 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3462 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3463
3464 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3465
3466 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3467
3468 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3469
3470 * xterm.c (x_find_topmost_parent): New function.
3471 (x_set_frame_alpha): Find topmost parent window with
3472 x_find_topmost_parent and set the property there also (bug#9181).
3473 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3474
3475 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3476
3477 * callproc.c (Fcall_process): Avoid vfork clobbering
3478 the local vars buffer, coding_systems, current_dir.
3479
3480 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3481
3482 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3483
3484 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3485
3486 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3487 so that it is not optimized away.
3488
3489 * xdisp.c (compute_display_string_pos): Remove unused local.
3490
3491 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3492
3493 Fix slow cursor motion and scrolling in large buffers with
3494 selective display, like Org Mode buffers. (Bug#9218)
3495
3496 * dispextern.h (struct bidi_it): New member disp_prop_p.
3497
3498 * xdisp.c: Remove one-slot cache of display string positions.
3499 (compute_display_string_pos): Accept an additional argument
3500 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3501 for a display string or property. If found, set DISP_PROP_P
3502 non-zero.
3503
3504 * bidi.c (bidi_fetch_char): Accept an additional argument
3505 DISP_PROP_P, and pass it to compute_display_string_pos.
3506 Only handle text covered by a display string if DISP_PROP_P is returned
3507 non-zero. All callers of bidi_fetch_char changed.
3508
3509 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3510
3511 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3512
3513 2010-12-03 Don March <don@ohspite.net>
3514
3515 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3516 last character M-[char] is translated to ESC [char] (bug#7541).
3517
3518 2011-08-02 Kenichi Handa <handa@m17n.org>
3519
3520 * lisp.h (uniprop_table): Extern it.
3521
3522 * chartab.c (uniprop_table): Make it non-static.
3523
3524 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3525
3526 * xdisp.c (forward_to_next_line_start): Accept additional argument
3527 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3528 on the newline.
3529 (reseat_at_next_visible_line_start): Use the bidi iterator state
3530 returned by forward_to_next_line_start to restore the state of
3531 it->bidi_it after backing up to previous newline. (Bug#9212)
3532
3533 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3534
3535 * regex.c (re_comp): Protoize.
3536 (re_exec): Fix return type.
3537 (regexec): Fix type of `ret'. (Bug#9203)
3538
3539 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3540
3541 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3542 This is needed if max-image-size is a floating-point number.
3543
3544 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3545
3546 * print.c (print_object): Print empty symbol as ##.
3547
3548 * lread.c (read1): Read ## as empty symbol.
3549
3550 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3551
3552 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3553 setting frame foreground color (Bug#9175).
3554 (x_set_background_color): Likewise.
3555
3556 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3557 contents (Bug#9176).
3558 (EmacsTooltip -init): Remove bezels and add shadows to
3559 tooltip windows.
3560
3561 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3562 or scroll bar (Bug#8470).
3563
3564 * nsfont.m (nsfont_open): Remove assignment to voffset and
3565 unnecessary vars hshink, expand, hd, full_height, min_height.
3566 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3567
3568 * nsterm.h (nsfont_info): Remove voffset field.
3569
3570 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3571
3572 Implement strike-through and overline on NextStep (Bug#8863).
3573
3574 * nsfont.m (nsfont_open): Use underline position provided by font,
3575 instead of hard-coded value of 2.
3576 (nsfont_draw): Call ns_draw_text_decoration instead.
3577
3578 * nsterm.h: Add declaration for ns_draw_text_decoration.
3579
3580 * nsterm.m (ns_draw_text_decoration): New function for drawing
3581 underline, overline, and strike-through.
3582 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3583 ns_draw_text_decoration. Change treatment of cursor drawing to
3584 accommodate underlining, etc.
3585
3586 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3587
3588 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3589 default.
3590
3591 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3592
3593 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3594 Without this fix, if a signal arrives just after memory fills up,
3595 'malloc' might be invoked reentrantly.
3596
3597 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3598 In other words, assume that every image size is allowed, on non-X
3599 hosts. This assumption is probably wrong, but it lets Emacs compile.
3600
3601 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3602
3603 * regex.c (re_iswctype): Convert return values to boolean.
3604
3605 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3606
3607 * xdisp.c (compute_display_string_pos): Don't use cached display
3608 string position if the buffer had its restriction changed.
3609 (Bug#9184)
3610
3611 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3612
3613 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3614
3615 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3616
3617 Integer signedness and overflow and related fixes. (Bug#9079)
3618
3619 * bidi.c: Integer size and overflow fixes.
3620 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3621 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3622 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3623 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3624 (bidi_find_other_level_edge):
3625 Use ptrdiff_t instead of EMACS_INT where either will do.
3626 This works better on 32-bit hosts configured --with-wide-int.
3627 (bidi_cache_ensure_space): Check for size-calculation overflow.
3628 Use % rather than repeated addition, for better worst-case speed.
3629 Don't set bidi_cache_size until after xrealloc returns, because it
3630 might not return.
3631 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3632 (bidi_cache_ensure_space): Also check that the bidi cache size
3633 does not exceed that of the largest Lisp string or buffer. See Eli
3634 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3635
3636 * alloc.c (__malloc_size_t): Remove.
3637 All uses replaced by size_t. See Andreas Schwab's note
3638 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3639
3640 * image.c: Improve checking for integer overflow.
3641 (check_image_size): Assume that f is nonnull, since
3642 it is always nonnull in practice. This is one less thing to
3643 worry about when checking for integer overflow later.
3644 (x_check_image_size): New function, which checks for integer
3645 overflow issues inside X.
3646 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3647 This removes the need for a memory_full check.
3648 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3649 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3650 (xbm_read_bitmap_data): Change locals back to 'int', since
3651 their values must fit in 'int'.
3652 (xpm_load_image, png_load, tiff_load):
3653 Invoke x_create_x_image_and_pixmap earlier,
3654 to avoid much needless work if the image is too large.
3655 (tiff_load): Treat overly large images as if
3656 x_create_x_image_and_pixmap failed, not as malloc failures.
3657 (gs_load): Use x_check_image_size.
3658
3659 * gtkutil.c: Omit integer casts.
3660 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3661 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3662
3663 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3664
3665 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3666 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3667 would wrongly return t on a 64-bit host.
3668
3669 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3670 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3671 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3672 and therefore cause GCC to emit a bogus diagnostic in some cases.
3673
3674 * image.c: Integer signedness and overflow and related fixes.
3675 This is not an exhaustive set of fixes, but it's time to
3676 record what I've got.
3677 (lookup_pixel_color, check_image_size): Remove redundant decls.
3678 (check_image_size): Don't assume that arbitrary EMACS_INT values
3679 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3680 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3681 (tiff_load, imagemagick_load_image):
3682 Check for overflow in size calculations.
3683 (x_create_x_image_and_pixmap): Remove unnecessary test for
3684 xmalloc returning NULL; that can't happen.
3685 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3686 (xpm_color_bucket): Use better integer hashing function.
3687 (xpm_cache_color): Don't possibly over-allocate memory.
3688 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3689 (gif_memory_source):
3690 Use ptrdiff_t, not int or size_t, to record sizes.
3691 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3692 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3693 either works, as we prefer signed integers.
3694 (tiff_read_from_memory, tiff_write_from_memory):
3695 Return tsize_t, not size_t, since that's what the TIFF API wants.
3696 (tiff_read_from_memory): Don't fail simply because the read would
3697 go past EOF; instead, return a short read.
3698 (tiff_load): Omit no-longer-needed casts.
3699 (Fimagemagick_types): Don't assume size fits into 'int'.
3700
3701 Improve hashing quality when configured --with-wide-int.
3702 * fns.c (hash_string): New function, taken from sxhash_string.
3703 Do not discard information about ASCII character case; this
3704 discarding is no longer needed.
3705 (sxhash-string): Use it. Change sig to match it. Caller changed.
3706 * lisp.h: Declare it.
3707 * lread.c (hash_string): Remove, since we now use fns.c's version.
3708 The fns.c version returns a wider integer if --with-wide-int is
3709 specified, so this should help the quality of the hashing a bit.
3710
3711 * emacs.c: Integer overflow minor fix.
3712 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3713 Define only if GNU_LINUX.
3714 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3715
3716 * dispnew.c: Integer signedness and overflow fixes.
3717 Remove unnecessary forward decls, that were a maintenance hassle.
3718 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3719 All uses changed.
3720 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3721 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3722 (prepare_desired_row, line_draw_cost):
3723 Use int, not unsigned, where either works.
3724 (save_current_matrix, restore_current_matrix):
3725 Use ptrdiff_t, not size_t, where either works.
3726 (init_display): Check for overflow more accurately, and without
3727 relying on undefined behavior.
3728
3729 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3730 Remove, replacing with the new symbols in lisp.h. All uses changed.
3731 * fileio.c (make_temp_name):
3732 * filelock.c (lock_file_1, lock_file):
3733 * xdisp.c (message_dolog):
3734 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3735 Use pMd etc. instead.
3736 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3737 replacing the pWIDE etc. symbols removed from editfns.c.
3738
3739 * keyboard.h (num_input_events): Now uintmax_t.
3740 This is (very slightly) less likely to mess up due to wraparound.
3741 All uses changed.
3742
3743 * buffer.c: Integer signedness fixes.
3744 (alloc_buffer_text, enlarge_buffer_text):
3745 Use ptrdiff_t rather than size_t when either will do, as we prefer
3746 signed integers.
3747
3748 * alloc.c: Integer signedness and overflow fixes.
3749 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3750 (__malloc_size_t): Default to size_t, not to int.
3751 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3752 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3753 Prefer ptrdiff_t to size_t when either would do, as we prefer
3754 signed integers.
3755 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3756 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3757 Now const. Initialize with values that are in range even if char
3758 is signed.
3759 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3760 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3761 These functions do the right thing with sizes > 2**32.
3762 (check_depth): Now ptrdiff_t, not int.
3763 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3764 Adjust to new way of storing sizes. Check for size overflow bugs
3765 in rest of code.
3766 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3767 slightly wrong anyway, as it missed one instance of
3768 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3769 (refill_memory_reserve): Omit needless cast to size_t.
3770 (mark_object_loop_halt): Mark as externally visible.
3771
3772 * xselect.c: Integer signedness and overflow fixes.
3773 (Fx_register_dnd_atom, x_handle_dnd_message):
3774 Use ptrdiff_t, not size_t, since we prefer signed.
3775 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3776 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3777 x_dnd_atoms_size and x_dnd_atoms_length.
3778
3779 * doprnt.c: Prefer signed to unsigned when either works.
3780 * eval.c (verror):
3781 * doprnt.c (doprnt):
3782 * lisp.h (doprnt):
3783 * xdisp.c (vmessage):
3784 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3785 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3786 prefer signed arithmetic to avoid comparison confusion.
3787 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3788 but is a bit tricky.
3789
3790 Assume freestanding C89 headers, string.h, stdlib.h.
3791 * data.c, doprnt.c, floatfns.c, print.c:
3792 Include float.h unconditionally.
3793 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3794 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3795 * regex.c: Likewise for stddef.h, string.h.
3796 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3797 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3798 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3799 (STDC_HEADERS): Remove obsolete defines.
3800 * sysdep.c: Include limits.h unconditionally.
3801
3802 Assume support for memcmp, memcpy, memmove, memset.
3803 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3804 * regex.c (memcmp, memcpy):
3805 Remove; we assume C89 now.
3806
3807 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3808 (__malloc_safe_bcopy): Remove; no longer needed.
3809
3810 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3811 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3812 well either way, and we prefer signed to unsigned.
3813
3814 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3815
3816 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3817 closes the connection while we're reading (bug#9182).
3818
3819 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3820
3821 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3822 are specified (Bug#9168).
3823
3824 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3825
3826 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3827 Found by GCC static checking and --with-wide-int on a 32-bit host.
3828
3829 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3830
3831 * xdisp.c (compute_display_string_pos): Fix logic of caching
3832 previous display string position. Initialize cached_prev_pos to
3833 -1. Fixes slow-down at the beginning of a buffer.
3834
3835 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3836
3837 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3838 for attrs[LFACE_FONTSET_INDEX].
3839
3840 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3841
3842 * xml.c (parse_region): Remove unused local
3843 that was recently introduced.
3844
3845 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3846
3847 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3848 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3849
3850 * xdisp.c (move_it_in_display_line_to): Record the best matching
3851 position for TO_CHARPOS while scanning the line, and restore it on
3852 exit if none of the characters scanned was an exact match.
3853 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3854 when exact match is impossible due to invisible text, and the
3855 lines are truncated.
3856
3857 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3858
3859 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3860 for OSX >= 10.7.
3861
3862 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3863
3864 Fix a significant slow-down of cursor motion with C-n, C-p,
3865 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3866 auto-repeat under bidi redisplay in fontified buffers.
3867 * xdisp.c (compute_stop_pos_backwards): New function.
3868 (next_element_from_buffer): Call compute_stop_pos_backwards to
3869 find a suitable prev_stop when we find ourselves before
3870 base_level_stop.
3871 (reseat): Don't look for prev_stop, as that could mean a very long
3872 run.
3873 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3874 <cached_disp_overlay_modiff>: Cache for last found display string
3875 position.
3876 (compute_display_string_pos): Return the cached position if asked
3877 about the same buffer in the same area of character positions, and
3878 the buffer wasn't changed since the time the display string
3879 position was cached.
3880
3881 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3882
3883 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3884 is an integer, which is important for empty lines. (Bug#9149)
3885
3886 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3887
3888 * frame.c (Fmodify_frame_parameters): In tty case, update the
3889 default face if necessary (Bug#4238).
3890
3891 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3892
3893 * editfns.c (Fstring_to_char): No need to explain what a character
3894 is in the docstring (Bug#6576).
3895
3896 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3897
3898 * xml.c (parse_region): Make sure we always return a tree.
3899
3900 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3901
3902 * xml.c (parse_region): If a document contains only comments,
3903 return that, too.
3904
3905 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3906
3907 * xml.c (make_dom): Return comments, too.
3908
3909 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3910
3911 Port to OpenBSD.
3912 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3913 and the surrounding thread.
3914 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3915 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3916 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3917 timer goes off.
3918 * s/openbsd.h (BROKEN_SIGIO): Define.
3919 * unexelf.c (unexec) [__OpenBSD__]:
3920 Don't update the .mdebug section of the Alpha COFF symbol table.
3921
3922 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3923
3924 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3925 (bug#8460).
3926
3927 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3928
3929 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3930 This fixes some race conditions on the permissions of any newly
3931 created file.
3932
3933 * alloc.c (valid_pointer_p): Use pipe, not open.
3934 This fixes some permissions issues when debugging.
3935
3936 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3937 If fchown fails to set both uid and gid, try to set just gid,
3938 as that is sometimes allowed. Adjust the file's mode to eliminate
3939 setuid or setgid bits that are inappropriate if fchown fails.
3940
3941 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3942
3943 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3944 to compare Lisp_Objects.
3945 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3946 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3947 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3948
3949 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3950
3951 * lread.c (read_integer): Unread even EOF character.
3952 (read1): Likewise. Properly record start position of symbol.
3953
3954 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3955 symbol character follows.
3956
3957 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3958
3959 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3960 This works around a problem with the previous change to Fcopy_file.
3961 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3962 and without this change, GCC might complain about discarding
3963 fchown's return value.
3964
3965 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3966
3967 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3968
3969 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3970
3971 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3972
3973 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3974
3975 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3976 it's used from the C level.
3977
3978 * process.c: Use the same condition for POLL_FOR_INPUT in both
3979 keyboard.c and process.c (bug#1858).
3980
3981 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3982
3983 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3984 (Fgnutls_boot): Use it.
3985
3986 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3987
3988 * doc.c (Fsubstitute_command_keys): Revert last change.
3989
3990 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3991
3992 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3993 quotes the next character, and doesn't affect other longer
3994 sequences (bug#8935).
3995
3996 * lread.c (syms_of_lread): Clarify that is isn't only
3997 `eval-buffer' and `eval-defun' that's affected by
3998 `lexical-binding' (bug#8460).
3999
4000 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4001
4002 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4003 bidi redisplay when a line includes both an image and is truncated.
4004
4005 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4006
4007 Fix minor problems found by static checking.
4008 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4009 (elsz): Now a signed constant, not a size_t var. We prefer signed
4010 types to unsigned, to avoid integer comparison confusion. Without
4011 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4012 "cannot optimize loop, the loop counter may overflow", a symptom
4013 of the confusion.
4014 * indent.c (Fvertical_motion): Mark locals as initialized.
4015 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4016
4017 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4018
4019 * search.c (Fre_search_backward): Mention `case-fold-search' in
4020 all the re_search_* functions (bug#8138).
4021
4022 * keyboard.c (Fopen_dribble_file): Document when the file is
4023 closed (bug#8056).
4024
4025 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4026
4027 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4028 bidi_cache_idx.
4029
4030 Support bidi reordering of display and overlay strings.
4031 * xdisp.c (compute_display_string_pos)
4032 (compute_display_string_end): Accept additional argument STRING.
4033 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4034 (reseat_to_string): Initialize bidi_it->string.s and
4035 bidi_it->string.schars.
4036 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4037 NULL (avoids a crash in bidi_paragraph_init).
4038 Initialize itb.string.lstring.
4039 (init_iterator): Call bidi_init_it only of a valid
4040 buffer position was specified. Initialize paragraph_embedding to
4041 L2R.
4042 (reseat_to_string): Initialize the bidi iterator.
4043 (display_string): If we need to ignore text properties of
4044 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4045 original value of -1 will not work with bidi.)
4046 (compute_display_string_pos): First arg is now struct
4047 `text_pos *'; all callers changed. Support display properties on
4048 Lisp strings.
4049 (compute_display_string_end): Support display properties on Lisp
4050 strings.
4051 (init_iterator, reseat_1, reseat_to_string): Initialize the
4052 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4053 when iterating on a string not from display properties).
4054 (compute_display_string_pos, compute_display_string_end):
4055 Fix calculation of the object to scan. Fixes an error when using
4056 arrow keys.
4057 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4058 base_level_stop; instead, set base_level_stop to BEGV.
4059 Fixes crashes in vertical-motion.
4060 (next_element_from_buffer): Improve commentary for when
4061 the iterator is before prev_stop.
4062 (init_iterator): Initialize bidi_p from the default value of
4063 bidi-display-reordering, not from buffer-local value. Use the
4064 buffer-local value only if initializing for buffer iteration.
4065 (handle_invisible_prop): Support invisible properties on strings
4066 that are being bidi-reordered.
4067 (set_iterator_to_next): Support bidi reordering of C strings and
4068 Lisp strings.
4069 (next_element_from_string): Support bidi reordering of Lisp
4070 strings.
4071 (handle_stop_backwards): Support Lisp strings as well.
4072 (display_string): Support display of R2L glyph rows.
4073 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4074 (init_iterator): Don't initialize it->bidi_p for strings
4075 here.
4076 (reseat_to_string): Initialize it->bidi_p for strings here.
4077 (next_element_from_string, next_element_from_c_string)
4078 (next_element_from_buffer): Add xassert's for correspondence
4079 between IT's object being iterated and it->bidi_it.string
4080 structure.
4081 (face_before_or_after_it_pos): Support bidi iteration.
4082 (next_element_from_c_string): Handle the case of the first string
4083 character that is not the first one in the visual order.
4084 (get_visually_first_element): New function, refactored from common
4085 parts of next_element_from_buffer, next_element_from_string, and
4086 next_element_from_c_string.
4087 (tool_bar_lines_needed, redisplay_tool_bar)
4088 (display_menu_bar): Force left-to-right direction. Add a FIXME
4089 comment for making that be controlled by a user option.
4090 (push_it, pop_it): Save and restore the state of the
4091 bidi iterator. Save and restore the bidi_p flag.
4092 (pop_it): Iterate out of display property for string iteration as
4093 well.
4094 (iterate_out_of_display_property): Support iteration over strings.
4095 (handle_single_display_spec): Set up it->bidi_it for iteration
4096 over a display string, and call bidi_init_it.
4097 (handle_single_display_spec, next_overlay_string)
4098 (get_overlay_strings_1, push_display_prop): Set up the bidi
4099 iterator for displaying display or overlay strings.
4100 (forward_to_next_line_start): Don't use the shortcut if
4101 bidi-iterating.
4102 (back_to_previous_visible_line_start): If handle_display_prop
4103 pushed the iterator stack, restore the internal state of the bidi
4104 iterator by calling bidi_pop_it same number of times.
4105 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4106 and we are bidi-iterating, don't decrement the iterator position;
4107 instead, set the first_elt flag in the bidi iterator, to produce
4108 the same effect.
4109 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4110 (push_display_prop): xassert that we are iterating a buffer.
4111 (push_it, pop_it): Save and restore paragraph_embedding member.
4112 (handle_single_display_spec, next_overlay_string)
4113 (get_overlay_strings_1, reseat_1, reseat_to_string)
4114 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4115 correctly. Don't assume unibyte strings are not bidi-reordered.
4116 (compute_display_string_pos)
4117 (compute_display_string_end): Fix handling the case of C string.
4118 (push_it, pop_it): Save and restore from_disp_prop_p.
4119 (handle_single_display_spec, push_display_prop): Set the
4120 from_disp_prop_p flag.
4121 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4122 (pop_it): Call iterate_out_of_display_property only if we are
4123 popping after iteration over a string that came from a display
4124 property. Fix a typo in popping stretch info. Add an assertion
4125 for verifying that the iterator position is in sync with the bidi
4126 iterator.
4127 (handle_single_display_spec, get_overlay_strings_1)
4128 (push_display_prop): Fix initialization of paragraph direction for
4129 string when that of the parent object is not yet determined.
4130 (reseat_1): Call bidi_init_it to resync the bidi
4131 iterator with IT's position. (Bug#7616)
4132 (find_row_edges): If ROW->start.pos gives position
4133 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4134 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4135 Reset the from_disp_prop_p flag.
4136 (SAVE_IT, RESTORE_IT): New macros.
4137 (pos_visible_p, face_before_or_after_it_pos)
4138 (back_to_previous_visible_line_start)
4139 (move_it_in_display_line_to, move_it_in_display_line)
4140 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4141 (try_scrolling, redisplay_window, display_line): Use them when
4142 saving a temporary copy of the iterator and restoring it back.
4143 (back_to_previous_visible_line_start, reseat_1)
4144 (init_iterator): Empty the bidi cache "stack".
4145 (move_it_in_display_line_to): If iterator ended up at
4146 EOL, but we never saw any buffer positions smaller than
4147 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4148 motion in bidi-reordered lines.
4149 (move_it_in_display_line_to): Record prev_method and prev_pos
4150 immediately before the call to set_iterator_to_next. Fixes cursor
4151 motion in bidi-reordered lines with stretch glyphs and strings
4152 displayed in margins. (Bug#8133) (Bug#8867)
4153 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4154 TO_CHARPOS.
4155 (pos_visible_p): Support positions in bidi-reordered lines.
4156 Save and restore bidi cache.
4157
4158 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4159 (bidi_paragraph_info): Delete unused struct.
4160 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4161 (bidi_cache_start): New variable.
4162 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4163 to zero.
4164 (bidi_cache_fetch_state, bidi_cache_search)
4165 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4166 (bidi_cache_find, bidi_peek_at_next_level)
4167 (bidi_level_of_next_char, bidi_find_other_level_edge)
4168 (bidi_move_to_visually_next): Compare cache index with
4169 bidi_cache_start rather than with zero.
4170 (bidi_fetch_char): Accept new argument STRING; all callers
4171 changed. Support iteration over a string. Support strings with
4172 display properties. Support unibyte strings. Fix the type of
4173 `len' according to what STRING_CHAR_AND_LENGTH expects.
4174 (bidi_paragraph_init, bidi_resolve_explicit_1)
4175 (bidi_resolve_explicit, bidi_resolve_weak)
4176 (bidi_level_of_next_char, bidi_move_to_visually_next):
4177 Support iteration over a string.
4178 (bidi_set_sor_type, bidi_resolve_explicit_1)
4179 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4180 can now be zero (for strings); special values 0 and -1 were
4181 changed to -1 and -2, respectively.
4182 (bidi_char_at_pos): New function.
4183 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4184 Call it instead of FETCH_MULTIBYTE_CHAR.
4185 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4186 initialized to valid values.
4187 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4188 values.
4189 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4190 the test for valid cached positions. Fix the logic for looking up
4191 the sentinel state in the cache. GCPRO the Lisp string we are
4192 iterating.
4193 (bidi_push_it, bidi_pop_it): New functions.
4194 (bidi_initialize): Initialize the bidi cache start stack pointer.
4195 (bidi_cache_ensure_space): New function, refactored from part of
4196 bidi_cache_iterator_state. Don't assume the required size is just
4197 one BIDI_CACHE_CHUNK away.
4198 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4199 (bidi_count_bytes, bidi_char_at_pos): New functions.
4200 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4201 always valid if bidi_cache_idx is valid.
4202 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4203 is valid if it's going to be used.
4204 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4205 (bidi_cache_fetch_state, bidi_cache_search)
4206 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4207 (bidi_cache_iterator_state, bidi_cache_find)
4208 (bidi_find_other_level_edge, bidi_cache_start_stack):
4209 All variables related to cache indices are now EMACS_INT.
4210
4211 * dispextern.h (struct bidi_string_data): New structure.
4212 (struct bidi_it): New member `string'. Make flag members be 1-bit
4213 fields, and put them last in the struct.
4214 (compute_display_string_pos, compute_display_string_end):
4215 Update prototypes.
4216 (bidi_push_it, bidi_pop_it): Add prototypes.
4217 (struct iterator_stack_entry): New members bidi_p,
4218 paragraph_embedding, and from_disp_prop_p.
4219 (struct it): Member bidi_p is now a bit field 1 bit wide.
4220 (bidi_shelve_cache, bidi_unshelve_cache):
4221 Declare prototypes.
4222
4223 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4224 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4225 and vector-like objects.
4226
4227 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4228 cache around display iteration.
4229
4230 * window.c (Fwindow_end, window_scroll_pixel_based)
4231 (displayed_window_lines, Frecenter): Save and restore the bidi
4232 cache around display iteration.
4233
4234 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4235
4236 * editfns.c (Fdelete_region): Clarify the use of the named
4237 parameters (bug#6788).
4238
4239 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4240
4241 * indent.c (Fvertical_motion): Set and restore w->pointm when
4242 saving and restoring the window's buffer (Bug#9006).
4243
4244 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4245
4246 * editfns.c (Fstring_to_char): Clarify just what is returned
4247 (bug#6576). Text by Eli Zaretskii.
4248
4249 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4250
4251 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4252
4253 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4254
4255 * buffer.c (mmap_find): Fix a typo.
4256
4257 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4258
4259 Fix execution of x selection hooks.
4260 * xselect.c (Qx_lost_selection_functions)
4261 (Qx_sent_selection_functions): New vars.
4262 (syms_of_xselect): DEFSYM them.
4263 (x_handle_selection_request): Pass Qx_sent_selection_functions
4264 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4265 (x_handle_selection_clear,x_clear_frame_selections):
4266 Pass Qx_lost_selection_functions rather than
4267 Vx_lost_selection_functions to Frun_hook_with_args.
4268
4269 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4270
4271 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4272 The old code sometimes used this field without initializing it.
4273
4274 * alloc.c (gc_sweep): Don't read past end of array.
4275 In theory, the old code could also have corrupted Emacs internals,
4276 though it'd be very unlikely.
4277
4278 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4279
4280 * character.c (Fcharacterp): Don't advertise optional ignored
4281 argument. (Bug#4026)
4282
4283 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4284
4285 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4286 key" (bug#4257).
4287
4288 * window.c (Fset_window_start): Doc fix (bug#4199).
4289 (Fset_window_hscroll): Ditto.
4290
4291 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4292
4293 Fix minor new problems caught by GCC 4.6.1.
4294 * term.c (init_tty): Remove unused local.
4295 * xsettings.c (store_monospaced_changed): Define this function only
4296 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4297 not used otherwise.
4298
4299 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4300
4301 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4302
4303 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4304
4305 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4306 are the mini-buffer and the echo area (bug#3320).
4307
4308 * term.c (init_tty): Remove support for supdup, c10 and perq
4309 terminals, which are no longer supported (bug#1482).
4310
4311 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4312
4313 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4314
4315 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4316
4317 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4318 for non-popups (Bug#3642).
4319
4320 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4321
4322 * alloc.c (reset_malloc_hooks): Protoize.
4323 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4324 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4325 * cm.c (losecursor): Likewise.
4326 * data.c (fmod): Likewise.
4327 * dispnew.c (swap_glyphs_in_rows): Likewise.
4328 * emacs.c (memory_warning_signal): Likewise.
4329 * floatfns.c (float_error): Likewise.
4330 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4331 (otf_open, font_otf_capability, generate_otf_features)
4332 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4333 Likewise.
4334 * image.c (pbm_read_file): Likewise.
4335 * indent.c (string_display_width): Likewise.
4336 * intervals.c (check_for_interval, search_for_interval)
4337 (inc_interval_count, count_intervals, root_interval)
4338 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4339 * lread.c (defalias): Likewise.
4340 * ralloc.c (r_alloc_check): Likewise.
4341 * regex.c (set_image_of_range_1, set_image_of_range)
4342 (regex_grow_registers): Likewise.
4343 * sysdep.c (strerror): Likewise.
4344 * termcap.c (valid_filename_p, tprint, main): Likewise.
4345 * tparam.c (main): Likewise.
4346 * unexhp9k800.c (run_time_remap, save_data_space)
4347 (update_file_ptrs, read_header, write_header, calculate_checksum)
4348 (copy_file, copy_rest, display_header): Likewise.
4349 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4350 Likewise.
4351 * xdisp.c (check_it): Likewise.
4352 * xfaces.c (register_color, unregister_color, unregister_colors):
4353 Likewise.
4354 * xfns.c (print_fontset_result): Likewise.
4355 * xrdb.c (member, fatal, main): Likewise.
4356
4357 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4358
4359 Fix minor problems found by static checking (Bug#9031).
4360 * chartab.c (char_table_set_range, map_sub_char_table):
4361 Remove unused locals.
4362 (uniprop_table): Now static.
4363 * composite.c (_work_char): Remove unused static var.
4364
4365 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4366
4367 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4368
4369 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4370
4371 * gtkutil.c (qttip_cb): Remove code without function.
4372
4373 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4374
4375 * w32.c (pthread_sigmask): New stub.
4376
4377 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4378
4379 Use pthread_sigmask, not sigprocmask (Bug#9010).
4380 sigprocmask is portable only for single-threaded applications, and
4381 Emacs can be multi-threaded when it uses GTK.
4382 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4383 (LIBES): Use it.
4384 * callproc.c (Fcall_process):
4385 * process.c (create_process):
4386 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4387 Use pthread_sigmask, not sigprocmask.
4388
4389 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4390
4391 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4392 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4393 wrong (Bug#8591).
4394
4395 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4396
4397 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4398 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4399 (xg_hide_tooltip): Fix comment.
4400
4401 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4402 in registerServicesMenuSendTypes.
4403 (validRequestorForSendType): Don't check ns_return_types.
4404
4405 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4406 ns_return_type.
4407
4408 2011-07-08 Jason Rumney <jasonr@gnu.org>
4409
4410 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4411 SH_SHOW for hidden windows (Bug#5482).
4412
4413 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4414 frame struct members of non-existent frames (Bug#6284).
4415
4416 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4417
4418 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4419 variable firstTime not needed on OSX >= 10.6.
4420 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4421 >= 10.5. Use setKnobProportion, setDoubleValue.
4422
4423 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4424 (MAC_OS_X_VERSION_10_5): Define if not defined.
4425 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4426 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4427 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4428
4429 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4430 cString and lossyCString on OSX >= 10.4
4431
4432 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4433 sizeToFit on OSX >= 10.2.
4434
4435 * nsimage.m (allocInitFromFile): Don't use deprecated method
4436 bestRepresentationForDevice on OSX >= 10.6.
4437
4438 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4439 to avoid warning.
4440
4441 * emacs.c: Declare unexec_init_emacs_zone.
4442
4443 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4444
4445 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4446
4447 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4448 on svcsMenu (Bug#8842).
4449
4450 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4451 ns_return_types.
4452 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4453
4454 * nsterm.m (QUTF8_STRING): Declare.
4455 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4456 (validRequestorForSendType): Return type is (id).
4457 Change indexOfObjectIdenticalTo to indexOfObject.
4458 Check if we have local selection before returning self (Bug#8842).
4459 (writeSelectionToPasteboard): Put local selection into paste board
4460 if we have a local selection (Bug#8842).
4461 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4462
4463 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4464 (ns_get_local_selection): Declare.
4465
4466 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4467
4468 * keymap.c (describe_map_tree): Don't insert a double newline at
4469 the end of the buffer (bug#1169) and return whether we inserted
4470 something.
4471
4472 * callint.c (Fcall_interactively): Change "reading args" to
4473 "providing args" to try to clarify what it does (bug#1010).
4474
4475 2011-07-07 Kenichi Handa <handa@m17n.org>
4476
4477 * composite.c (composition_compute_stop_pos): Ignore a static
4478 composition starting before CHARPOS (Bug#8915).
4479
4480 * xdisp.c (handle_composition_prop): Likewise.
4481
4482 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4483
4484 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4485 (Bug#9015)
4486
4487 2011-07-07 Kenichi Handa <handa@m17n.org>
4488
4489 * character.h (unicode_category_t): New enum type.
4490
4491 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4492 (Qchar_code_property_table): New variable.
4493 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4494 (UNIPROP_COMPRESSED_FORM_P): New macros.
4495 (char_table_ascii): Uncompress the compressed values.
4496 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4497 Uncompress the compressed values.
4498 (sub_char_table_ref_and_range): Likewise.
4499 (char_table_ref_and_range): Uncompress the compressed values.
4500 (sub_char_table_set): New arg is_uniprop. Callers changed.
4501 Uncompress the compressed values.
4502 (sub_char_table_set_range): Args changed. Callers changed.
4503 (char_table_set_range): Adjuted for the above change.
4504 (map_sub_char_table): Delete args default_val and parent. Add arg
4505 top. Give decoded values to a Lisp function.
4506 (map_char_table): Adjust for the above change. Give decoded
4507 values to a Lisp function. Gcpro more variables.
4508 (uniprop_table_uncompress)
4509 (uniprop_decode_value_run_length): New functions.
4510 (uniprop_decoder, uniprop_decoder_count): New variables.
4511 (uniprop_get_decoder, uniprop_encode_value_character)
4512 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4513 New functions.
4514 (uniprop_encoder, uniprop_encoder_count): New variables.
4515 (uniprop_get_encoder, uniprop_table)
4516 (Funicode_property_table_internal, Fget_unicode_property_internal)
4517 (Fput_unicode_property_internal): New functions.
4518 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4519 Sunicode_property_table_internal, Sget_unicode_property_internal,
4520 and Sput_unicode_property_internal. Defvar_lisp
4521 char-code-property-alist.
4522
4523 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4524 Vunicode_category_table.
4525
4526 * font.c (font_range): Adjust for the change of
4527 Vunicode_category_table.
4528
4529 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4530
4531 * m/iris4d.h: Remove file, move contents ...
4532 * s/irix6-5.h: ... here.
4533
4534 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4535
4536 Remove unportable assumption about struct layout (Bug#8884).
4537 * alloc.c (mark_buffer):
4538 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4539 (clone_per_buffer_values): Don't assume that
4540 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4541 This isn't true in general, and it's particularly not true
4542 if Emacs is configured with --with-wide-int.
4543 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4544 New macros, used in the buffer.c change.
4545
4546 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4547
4548 * xsettings.c: Use both GConf and GSettings if both are available.
4549 (store_config_changed_event): Add comment.
4550 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4551 (store_tool_bar_style_changed): New functions.
4552 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4553 (struct xsettings): Move font inside HAVE_XFT.
4554 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4555 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4556 Move inside HAVE_XFT.
4557 (something_changed_gsettingsCB): Rename from something_changedCB.
4558 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4559 also.
4560 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4561 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4562 (something_changed_gconfCB): Rename from something_changedCB.
4563 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4564 (parse_settings): Move check for font inside HAVE_XFT.
4565 (read_settings, apply_xft_settings): Add comment.
4566 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4567 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4568 call store_font_name_changed.
4569 (xft_settings_event): Add comment.
4570 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4571 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4572 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4573 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4574 (xsettings_initialize): Call init_gsettings last.
4575 (xsettings_get_system_font, xsettings_get_system_normal_font):
4576 Add comment.
4577
4578 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4579
4580 Random fixes. E.g., (random) never returned negative values.
4581 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4582 subseconds part to the entropy, as that's a bit more random.
4583 Prefer signed to unsigned, since the signedness doesn't matter and
4584 in general we prefer signed. When given a limit, use a
4585 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4586 latter isn't right if USE_2_TAGS_FOR_INTS.
4587 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4588 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4589
4590 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4591
4592 * textprop.c (text_property_stickiness):
4593 Obey Vtext_property_default_nonsticky.
4594 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4595 * w32fns.c (syms_of_w32fns):
4596 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4597
4598 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4599
4600 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4601 This is more efficient than Ffile_directory_p and avoids a minor race.
4602
4603 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4604
4605 * buffer.c (Foverlay_put): Say what the return value is
4606 (bug#7835).
4607
4608 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4609 is a directory before asking whether to use the file name
4610 (bug#7564).
4611 (barf_or_query_if_file_exists): Make the "File is a directory"
4612 error be more correct.
4613
4614 * fns.c (Frequire): Remove the mention of the .gz files, since
4615 that's installation-specific, but keep the mention of
4616 `get-load-suffixes'.
4617
4618 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4619
4620 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4621 Report string overflow if the output is too long.
4622
4623 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4624
4625 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4626 (syms_of_gnutls): Remove duplicate DEFSYM for
4627 Qgnutls_bootprop_verify_hostname_error, an error for
4628 Qgnutls_bootprop_verify_error (which is no longer used).
4629
4630 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4631 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4632 Also (re)move comments that are misplaced or no longer relevant.
4633
4634 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4635
4636 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4637
4638 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4639
4640 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4641 and background color parameters if they have been changed.
4642
4643 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4644
4645 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4646
4647 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4648
4649 * xsettings.c (SYSTEM_FONT): Define only when used.
4650 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4651
4652 * keymap.c (access_keymap_1): Now static.
4653
4654 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4655
4656 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4657 leave any prefix arg for the up event (Bug#1586).
4658
4659 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4660
4661 * lread.c (syms_of_lread): Mention single symbols defined by
4662 `defvar' or `defconst' (bug#7154).
4663
4664 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4665 (Frequire): Mention get-load-suffixes.
4666
4667 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4668
4669 * window.h (window): Remove clone_number slot.
4670 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4671 Remove.
4672 (make_parent_window, make_window, saved_window)
4673 (Fset_window_configuration, save_window_save): Don't deal with
4674 clone numbers.
4675 * buffer.c (Qclone_number): Remove declaration.
4676 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4677
4678 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4679
4680 Add multiple inheritance to keymaps.
4681 * keymap.c (Fmake_composed_keymap): New function.
4682 (Fset_keymap_parent): Simplify.
4683 (fix_submap_inheritance): Remove.
4684 (access_keymap_1): New function extracted from access_keymap to handle
4685 embedded parents and handle lists of maps.
4686 (access_keymap): Use it.
4687 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4688 (Fcopy_keymap): Handle embedded parents.
4689 (Fcommand_remapping, define_as_prefix): Simplify.
4690 (Fkey_binding): Simplify.
4691 (syms_of_keymap): Move minibuffer-local-completion-map,
4692 minibuffer-local-filename-completion-map,
4693 minibuffer-local-must-match-map, and
4694 minibuffer-local-filename-must-match-map to Elisp.
4695 (syms_of_keymap): Defsubr make-composed-keymap.
4696 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4697 (parse_menu_item): Trivial simplification.
4698
4699 2011-07-01 Glenn Morris <rgm@gnu.org>
4700
4701 * Makefile.in (SETTINGS_LIBS): Fix typo.
4702
4703 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4704
4705 * coding.c (Fencode_coding_string): Record the last coding system
4706 used, as the function doc string says (bug#8738).
4707
4708 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4709
4710 * xsettings.c (store_monospaced_changed): Take new font as arg and
4711 check for change against current_mono_font.
4712 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4713 (emacs_settings_constructor, emacs_settings_get_property)
4714 (emacs_settings_set_property, emacs_settings_class_init)
4715 (emacs_settings_init, gsettings_obj): Remove.
4716 (something_changedCB): New function for HAVE_GSETTINGS.
4717 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4718 with value as argument.
4719 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4720 g_settings_new (Bug#8967). Do not create gsettings_obj.
4721 Remove calls to g_settings_bind. Connect something_changedCB to
4722 "changed".
4723
4724 * xgselect.c: Add defined (HAVE_GSETTINGS).
4725 (xgselect_initialize): Ditto.
4726
4727 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4728 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4729 xg_select.
4730
4731 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4732
4733 * eval.c (struct backtrace): Simplify and port the data structure.
4734 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4735 signed bit field, as this assumption is not portable and it makes
4736 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4737 "char debug_on_exit : 1" as this is not portable either; instead,
4738 use the portable "unsigned int debug_on_exit : 1". Remove unused
4739 member evalargs. Remove obsolete comments about cc bombing out.
4740
4741 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4742
4743 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4744 Let HAVE_GSETTINGS override HAVE_GCONF.
4745 (store_monospaced_changed): New function.
4746 (EMACS_SETTINGS): A new type derived from GObject to handle
4747 GSettings notifications.
4748 (emacs_settings_constructor, emacs_settings_get_property)
4749 (emacs_settings_set_property, emacs_settings_class_init):
4750 New functions.
4751 (gsettings_client, gsettings_obj): New variables.
4752 (GSETTINGS_SCHEMA): New define.
4753 (something_changedCB): Call store_monospaced_changed.
4754 (init_gsettings): New function.
4755 (xsettings_initialize): Call init_gsettings.
4756 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4757 to NULL.
4758
4759 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4760 GCONF_CFLAGS/LIBS.
4761
4762 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4763
4764 * window.c (resize_root_window, grow_mini_window)
4765 (shrink_mini_window): Rename Qresize_root_window to
4766 Qwindow_resize_root_window and Qresize_root_window_vertically to
4767 Qwindow_resize_root_window_vertically.
4768
4769 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4770
4771 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4772
4773 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4774
4775 * makefile.w32-in: Redesign dependencies so they reflect more
4776 clearly which files are directly included by each source file,
4777 and not through other includes.
4778
4779 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4780
4781 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4782 (sort_overlays, overlay_strings): When an overlay's clone number
4783 matches the window's clone number process the overlay even if
4784 the overlay's window property doesn't match the current window.
4785
4786 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4787 (Fwindow_hchild): Rename to Fwindow_left_child.
4788 (Fwindow_next): Rename to Fwindow_next_sibling.
4789 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4790 (resize_window_check): Rename to window_resize_check.
4791 (resize_window_apply): Rename to window_resize_apply.
4792 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4793 (Fdelete_other_windows_internal, resize_frame_windows)
4794 (Fsplit_window_internal, Fdelete_window_internal)
4795 (grow_mini_window, shrink_mini_window)
4796 (Fresize_mini_window_internal): Fix callers accordingly.
4797
4798 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4799
4800 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4801 (emacs_fixed_set_min_size): Remove.
4802 (emacs_fixed_new): Take frame as argument.
4803
4804 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4805 (_EmacsFixedPrivate): Remove minwidth/height.
4806 Add struct frame *f.
4807 (emacs_fixed_init): Initialize priv->f.
4808 (get_parent_class, emacs_fixed_set_min_size): Remove.
4809 (emacs_fixed_new): Set priv->f to argument.
4810 (emacs_fixed_get_preferred_width)
4811 (emacs_fixed_get_preferred_height): Use min_width/height from
4812 frames size_hint to set minimum and natural (Bug#8919).
4813 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4814 and use min_width/height from frames size_hint to set
4815 min_width/height (Bug#8919).
4816
4817 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4818 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4819 Fix indentation.
4820
4821 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4822
4823 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4824 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4825 called at ZV.
4826
4827 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4828
4829 * process.c (wait_reading_process_output): Bypass select if
4830 waiting for a cell while ignoring keyboard input, and input is
4831 pending. Suggested by Jan Djärv (Bug#8869).
4832
4833 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4834
4835 Use gnulib's dup2 module instead of rolling our own.
4836 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4837
4838 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4839
4840 * dispnew.c (scrolling_window): Before scrolling, turn off a
4841 mouse-highlight in the window being scrolled.
4842
4843 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4844
4845 Move DEFSYM to lisp.h and use everywhere.
4846
4847 * character.h (DEFSYM): Move declaration...
4848 * lisp.h (DEFSYM): ...here.
4849
4850 * gnutls.c:
4851 * minibuf.c:
4852 * w32menu.c:
4853 * w32proc.c:
4854 * w32select.c: Don't include character.h.
4855
4856 * alloc.c (syms_of_alloc):
4857 * buffer.c (syms_of_buffer):
4858 * bytecode.c (syms_of_bytecode):
4859 * callint.c (syms_of_callint):
4860 * casefiddle.c (syms_of_casefiddle):
4861 * casetab.c (init_casetab_once):
4862 * category.c (init_category_once, syms_of_category):
4863 * ccl.c (syms_of_ccl):
4864 * cmds.c (syms_of_cmds):
4865 * composite.c (syms_of_composite):
4866 * dbusbind.c (syms_of_dbusbind):
4867 * dired.c (syms_of_dired):
4868 * dispnew.c (syms_of_display):
4869 * doc.c (syms_of_doc):
4870 * editfns.c (syms_of_editfns):
4871 * emacs.c (syms_of_emacs):
4872 * eval.c (syms_of_eval):
4873 * fileio.c (syms_of_fileio):
4874 * fns.c (syms_of_fns):
4875 * frame.c (syms_of_frame):
4876 * fringe.c (syms_of_fringe):
4877 * insdel.c (syms_of_insdel):
4878 * keymap.c (syms_of_keymap):
4879 * lread.c (init_obarray, syms_of_lread):
4880 * macros.c (syms_of_macros):
4881 * msdos.c (syms_of_msdos):
4882 * print.c (syms_of_print):
4883 * process.c (syms_of_process):
4884 * search.c (syms_of_search):
4885 * sound.c (syms_of_sound):
4886 * syntax.c (init_syntax_once, syms_of_syntax):
4887 * terminal.c (syms_of_terminal):
4888 * textprop.c (syms_of_textprop):
4889 * undo.c (syms_of_undo):
4890 * w32.c (globals_of_w32):
4891 * window.c (syms_of_window):
4892 * xdisp.c (syms_of_xdisp):
4893 * xfaces.c (syms_of_xfaces):
4894 * xfns.c (syms_of_xfns):
4895 * xmenu.c (syms_of_xmenu):
4896 * xsettings.c (syms_of_xsettings):
4897 * xterm.c (syms_of_xterm): Use DEFSYM.
4898
4899 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4900
4901 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4902
4903 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4904
4905 Integer and buffer overflow fixes (Bug#8873).
4906
4907 * print.c (printchar, strout): Check for string overflow.
4908 (PRINTPREPARE, printchar, strout):
4909 Don't set size unless allocation succeeds.
4910
4911 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4912 for sizes. Check for string overflow more accurately.
4913 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4914
4915 * macros.c: Integer and buffer overflow fixes.
4916 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4917 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4918 Use ptrdiff_t, not int, for sizes.
4919 Don't increment bufsize until after realloc succeeds.
4920 Check for size-calculation overflow.
4921 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4922
4923 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4924
4925 * lread.c: Integer overflow fixes.
4926 (read_integer): Radix is now EMACS_INT, not int,
4927 to improve quality of diagnostics for out-of-range radices.
4928 Calculate buffer size correctly for out-of-range radices.
4929 (read1): Check for integer overflow in radices, and in
4930 read-circle numbers.
4931 (read_escape): Avoid int overflow.
4932 (Fload, openp, read_buffer_size, read1)
4933 (substitute_object_recurse, read_vector, read_list, map_obarray):
4934 Use ptrdiff_t, not int, for sizes.
4935 (read1): Use EMACS_INT, not int, for sizes.
4936 Check for size overflow.
4937
4938 * image.c (cache_image): Check for size arithmetic overflow.
4939
4940 * lread.c: Integer overflow issues.
4941 (saved_doc_string_size, saved_doc_string_length)
4942 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4943 Now ptrdiff_t, not int.
4944 (read1): Don't assume doc string length fits in int. Check for
4945 out-of-range doc string lengths.
4946 (read_list): Don't assume file position fits in int.
4947 (read_escape): Check for hex character overflow.
4948
4949 2011-06-22 Leo Liu <sdl.web@gmail.com>
4950
4951 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4952 Move to minibuffer.el.
4953
4954 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4955
4956 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4957 The following patches are for when GLYPH_DEBUG && !XASSERT.
4958 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4959 * dispnew.c (flush_stdout):
4960 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4961 Mark as externally visible.
4962 * dispnew.c (check_window_matrix_pointers): Now static.
4963 * dispnew.c (window_to_frame_vpos):
4964 * xfns.c (unwind_create_frame):
4965 * xterm.c (x_check_font): Remove unused local.
4966 * scroll.c (CHECK_BOUNDS):
4967 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4968 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4969 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4970 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4971 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4972 Now static.
4973 (debug_method_add): Use va_list and vsprintf rather than relying
4974 on undefined behavior with wrong number of arguments.
4975 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4976 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4977 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4978 since we're not interested in debugging glyphs with old libraries.
4979 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4980 GCC 4.6.0's static checking.
4981
4982 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4983
4984 Integer overflow and signedness fixes (Bug#8873).
4985 A few related buffer overrun fixes, too.
4986
4987 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4988
4989 * dispextern.h (struct face.stipple):
4990 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4991 (x_bitmap_mask, x_allocate_bitmap_record)
4992 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4993 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4994 (x_create_bitmap_from_xpm_data):
4995 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4996 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4997 (.bitmaps_last):
4998 * xfaces.c (load_pixmap):
4999 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5000 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5001 (.bitmaps_last, struct x_output.icon_bitmap):
5002 Use ptrdiff_t, not int, for bitmap indexes.
5003 (x_allocate_bitmap_record): Check for size overflow.
5004 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5005
5006 Use ptrdiff_t, not int, for overlay counts.
5007 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5008 * editfns.c (overlays_around, get_pos_property):
5009 * textprop.c (get_char_property_and_overlay):
5010 * xdisp.c (next_overlay_change, note_mouse_highlight):
5011 * xfaces.c (face_at_buffer_position):
5012 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5013 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5014 (Fnext_overlay_change, Fprevious_overlay_change)
5015 (mouse_face_overlay_overlaps, Foverlays_in):
5016 Use ptrdiff_t, not int, for sizes.
5017 (overlays_at, overlays_in): Check for size-calculation overflow.
5018
5019 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5020
5021 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5022 (x_session_initialize): Do not assume string length fits in int.
5023
5024 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5025 This is unlikely, but can occur if DPI is outlandish.
5026
5027 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5028 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5029
5030 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5031 * xrdb.c (magic_file_p, search_magic_path):
5032 Omit last arg SUFFIX; it was always 0. All callers changed.
5033 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5034
5035 * xfont.c (xfont_match): Avoid need for strlen.
5036
5037 * xfns.c: Don't assume strlen fits in int.
5038 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5039
5040 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5041 not unsigned long, as we prefer signed integers. All callers changed.
5042 Detect integer overflow in repeat count.
5043 (message_dolog): Don't assume print length fits in 39 bytes.
5044 (display_mode_element): Don't assume strlen fits in int.
5045
5046 * termcap.c: Don't assume sizes fit in int and never overflow.
5047 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5048 (gobble_line): Check for size-calculation overflow.
5049
5050 * minibuf.c (Fread_buffer):
5051 * lread.c (intern, intern_c_string):
5052 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5053 Don't assume string length fits in int.
5054
5055 * keyboard.c (parse_tool_bar_item):
5056 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5057
5058 * font.c: Don't assume string length fits in int.
5059 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5060 Use ptrdiff_t, not int.
5061 (font_intern_prop): Don't assume string length fits in int.
5062 Don't assume integer property fits in fixnum.
5063 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5064
5065 * filelock.c: Fix some buffer overrun and integer overflow issues.
5066 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5067 Reformulate so as not to need the command string.
5068 Invoke gzip -cd rather than gunzip, as it's more portable.
5069 (lock_info_type, lock_file_1, lock_file):
5070 Don't assume pid_t and time_t fit in unsigned long.
5071 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5072 (current_lock_owner): Prefer signed type for sizes.
5073 Use memcpy, not strncpy, where memcpy is what is really wanted.
5074 Don't assume (via atoi) that time_t and pid_t fit in int.
5075 Check for time_t and/or pid_t out of range, e.g., via a network share.
5076 Don't alloca where an auto var works fine.
5077
5078 * fileio.c: Fix some integer overflow issues.
5079 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5080 Don't assume string length fits in int.
5081 (directory_file_name): Don't assume string length fits in long.
5082 (make_temp_name): Don't assume pid fits in int, or that its print
5083 length is less than 20.
5084
5085 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5086
5087 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5088
5089 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5090
5091 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5092 We prefer signed integers, even for size calculations.
5093
5094 * emacs.c: Don't assume string length fits in 'int'.
5095 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5096 (main): Don't invoke strlen when not needed.
5097
5098 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5099 (XD_DEBUG_MESSAGE): Don't waste a byte.
5100
5101 * callproc.c (getenv_internal_1, getenv_internal)
5102 (Fgetenv_internal):
5103 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5104
5105 * lread.c (invalid_syntax): Omit length argument.
5106 All uses changed. This doesn't fix a bug, but it simplifies the
5107 code away from its former Hollerith-constant appearance, and it's
5108 one less 'int' to worry about when looking at integer-overflow issues.
5109 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5110
5111 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5112 This didn't break anything, but it didn't help either.
5113 It's confusing to put a bogus integer in a place where the actual
5114 value does not matter.
5115 (LIST_END_P): Remove unused macro and its bogus comment.
5116 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5117
5118 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5119 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5120 implementation.
5121 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5122 We prefer signed types, and the value cannot exceed the EMACS_INT
5123 range anyway (because otherwise the length would not be representable).
5124 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5125 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5126 This avoids a GCC warning when WIDE_EMACS_INT.
5127
5128 * indent.c (sane_tab_width): New function.
5129 (current_column, scan_for_column, Findent_to, position_indentation)
5130 (compute_motion): Use it. This is just for clarity.
5131 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5132
5133 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5134
5135 * lisp.h (lint_assume): New macro.
5136 * composite.c (composition_gstring_put_cache):
5137 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5138
5139 * editfns.c, insdel.c:
5140 Omit unnecessary forward decls, to simplify future changes.
5141
5142 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5143
5144 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5145
5146 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5147 Use much-faster test for byte-length change.
5148 Don't assume string byte-length fits in 'int'.
5149 Check that character arg fits in 'int'.
5150 (mapcar1): Declare byte as byte, for clarity.
5151
5152 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5153
5154 * fns.c (concat): Catch string overflow earlier.
5155 Do not rely on integer wraparound.
5156
5157 * dispextern.h (struct it.overlay_strings_charpos)
5158 (struct it.selective): Now EMACS_INT, not int.
5159 * xdisp.c (forward_to_next_line_start)
5160 (back_to_previous_visible_line_start)
5161 (reseat_at_next_visible_line_start, next_element_from_buffer):
5162 Don't arbitrarily truncate the value of 'selective' to int.
5163
5164 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5165
5166 * composite.c: Don't truncate sizes to 'int'.
5167 (composition_gstring_p, composition_reseat_it)
5168 (composition_adjust_point): Use EMACS_INT, not int.
5169 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5170 not EMACS_UINT, for indexes.
5171
5172 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5173
5174 * buffer.c: Include <verify.h>.
5175 (struct sortvec.priority, struct sortstr.priority):
5176 Now EMACS_INT, not int.
5177 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5178 (struct sortstr.size, record_overlay_string)
5179 (struct sortstrlist.size, struct sortlist.used):
5180 Don't truncate size to int.
5181 (record_overlay_string): Check for size-calculation overflow.
5182 (init_buffer_once): Check at compile-time, not run-time.
5183
5184 2011-06-22 Jim Meyering <meyering@redhat.com>
5185
5186 Don't leak an XBM-image-sized buffer
5187 * image.c (xbm_load): Free the image buffer after using it.
5188
5189 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5190
5191 Port to Sun C.
5192 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5193 that Sun C diagnosed.
5194 * fns.c (secure_hash): Fix pointer signedness issue.
5195 * intervals.c (static_offset_intervals): New function.
5196 (offset_intervals): Use it.
5197
5198 2011-06-21 Leo Liu <sdl.web@gmail.com>
5199
5200 * deps.mk (fns.o):
5201 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5202 sha512.h.
5203
5204 * fns.c (secure_hash): Rename from crypto_hash_function and change
5205 the first arg to accept symbols.
5206 (Fsecure_hash): New primitive.
5207 (syms_of_fns): New symbols.
5208
5209 2011-06-20 Deniz Dogan <deniz@dogan.se>
5210
5211 * process.c (Fset_process_buffer): Clarify return value in
5212 docstring.
5213
5214 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5215
5216 * dispnew.c (add_window_display_history): Use BVAR.
5217
5218 * xdisp.c (debug_method_add): Use BVAR.
5219 (check_window_end, dump_glyph_matrix, dump_glyph)
5220 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5221
5222 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5223 Likewise.
5224
5225 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5226 check till after the cache is created in init_frame_faces.
5227
5228 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5229
5230 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5231
5232 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5233
5234 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5235 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5236 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5237
5238 Improve buffer-overflow checking (Bug#8873).
5239 * fileio.c (Finsert_file_contents):
5240 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5241 Remove the old (too-loose) buffer overflow checks.
5242 They weren't needed, since make_gap checks for buffer overflow.
5243 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5244 The old code merely checked for Emacs fixnum overflow, and relied
5245 on undefined (wraparound) behavior. The new code avoids undefined
5246 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5247
5248 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5249 Tune. Don't use wider integers than needed. Don't use alloca.
5250 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5251
5252 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5253
5254 * insdel.c, lisp.h (buffer_overflow): New function.
5255 (insert_from_buffer_1, replace_range, replace_range_2):
5256 * insdel.c (make_gap_larger):
5257 * editfns.c (Finsert_char):
5258 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5259
5260 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5261
5262 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5263
5264 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5265
5266 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5267 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5268
5269 * fileio.c: Don't assume EMACS_INT fits in off_t.
5270 (emacs_lseek): New static function.
5271 (Finsert_file_contents, Fwrite_region): Use it.
5272 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5273
5274 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5275
5276 * fns.c: Don't overflow int when computing a list length.
5277 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5278 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5279 truncation on 64-bit hosts. Check for QUIT every
5280 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5281 faster and is responsive enough.
5282 (Flength): Report an error instead of overflowing an integer.
5283 (Fsafe_length): Return a float if the value is not representable
5284 as a fixnum. This shouldn't happen except in contrived situations.
5285 (Fnthcdr, Fsort): Don't assume list length fits in int.
5286 (Fcopy_sequence): Don't assume vector length fits in int.
5287
5288 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5289 (header_size, word_size): New constants.
5290 (allocate_vectorlike): Don't check size overflow here.
5291 (allocate_vector): Check it here instead, since this is the only
5292 caller of allocate_vectorlike that could cause overflow.
5293 Check that the new vector's length is representable as a fixnum.
5294
5295 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5296 The previous code was bogus. For example, next_almost_prime (32)
5297 returned 39, which is undesirable as it is a multiple of 3; and
5298 next_almost_prime (24) returned 25, which is a multiple of 5 so
5299 why was the code bothering to check for multiples of 7?
5300
5301 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5302
5303 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5304
5305 Variadic C functions now count arguments with ptrdiff_t.
5306 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5307 Back then I didn't know that the Emacs coding style prefers signed int.
5308 Also, in the meantime I found a few more instances where arguments
5309 were being counted with int, which may truncate counts on 64-bit
5310 machines, or EMACS_INT, which may be unnecessarily wide.
5311 * lisp.h (struct Lisp_Subr.function.aMANY)
5312 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5313 Arg counts are now ptrdiff_t, not size_t.
5314 All variadic functions and their callers changed accordingly.
5315 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5316 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5317 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5318 * callint.c (Fcall_interactively): Check arg count for overflow,
5319 to avoid potential buffer overrun. Use signed char, not 'int',
5320 for 'varies' array, so that we needn't bother to check its size
5321 calculation for overflow.
5322 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5323 * eval.c (apply_lambda):
5324 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5325 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5326 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5327
5328 * callint.c (Fcall_interactively): Don't use index var as event count.
5329
5330 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5331 * mem-limits.h (SIZE): Remove; no longer used.
5332
5333 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5334
5335 Remove unnecessary casts.
5336 * xterm.c (x_term_init):
5337 * xfns.c (x_set_border_pixel):
5338 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5339 These aren't needed now that we assume ANSI C.
5340
5341 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5342 It's more likely to cause problems (due to unsigned overflow)
5343 than to cure them.
5344
5345 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5346
5347 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5348
5349 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5350
5351 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5352
5353 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5354
5355 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5356
5357 GLYPH_CODE_FACE returns EMACS_INT, not int.
5358 * dispextern.h (merge_faces):
5359 * xfaces.c (merge_faces):
5360 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5361 Don't assume EMACS_INT fits in int.
5362
5363 * character.h (CHAR_VALID_P): Remove unused parameter.
5364 * fontset.c, lisp.h, xdisp.c: All uses changed.
5365
5366 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5367
5368 * fns.c (concat): Minor tuning based on overflow analysis.
5369 This doesn't fix any bugs. Use int to hold character, instead
5370 of constantly refetching from Emacs object. Use XFASTINT, not
5371 XINT, for value known to be a character. Don't bother comparing
5372 a single byte to 0400, as it's always less.
5373
5374 * floatfns.c (Fexpt):
5375 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5376
5377 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5378 for characters.
5379
5380 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5381
5382 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5383 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5384 incorrectly succeed when S was a string, because 4294967386 was
5385 truncated before it was used.
5386
5387 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5388 Otherwise, an out-of-range integer could cause undefined behavior
5389 on a 64-bit host.
5390
5391 * composite.c: Use int, not EMACS_INT, for characters.
5392 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5393 EMACS_INT, for values that are known to be in character range.
5394 This doesn't fix any bugs but is the usual style inside Emacs and
5395 may generate better code on 32-bit machines.
5396
5397 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5398 This is for reasons similar to the recent CHAR_STRING fix.
5399 * charset.c (Fencode_char): Check that character arg is actually
5400 a character. Pass an int to ENCODE_CHAR.
5401 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5402 wider than 'int', as a compile-time check to prevent future regressions
5403 in this area.
5404
5405 * character.c (char_string): Remove unnecessary casts.
5406
5407 Make sure a 64-bit char is never passed to CHAR_STRING.
5408 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5409 by silently ignoring the top 32 bits, allowing some values
5410 that were far too large to be valid characters.
5411 * character.h: Include <verify.h>.
5412 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5413 arguments are no wider than unsigned, as a compile-time check
5414 to prevent future regressions in this area.
5415 * data.c (Faset):
5416 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5417 (Fsubst_char_in_region):
5418 * fns.c (concat):
5419 * xdisp.c (decode_mode_spec_coding):
5420 Adjust to CHAR_STRING's new requirement.
5421 * editfns.c (Finsert_char, Fsubst_char_in_region):
5422 * fns.c (concat): Check that character args are actually
5423 characters. Without this test, these functions did the wrong
5424 thing with wildly out-of-range values on 64-bit hosts.
5425
5426 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5427 These casts should not be needed on 32-bit hosts, either.
5428 * keyboard.c (read_char):
5429 * lread.c (Fload): Remove casts to unsigned.
5430
5431 * lisp.h (UNSIGNED_CMP): New macro.
5432 This fixes comparison bugs on 64-bit hosts.
5433 (ASCII_CHAR_P): Use it.
5434 * casefiddle.c (casify_object):
5435 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5436 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5437 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5438 * dispextern.h (FACE_FROM_ID):
5439 * keyboard.c (read_char): Use UNSIGNED_CMP.
5440
5441 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5442 not to EMACS_INT, to avoid GCC warning.
5443
5444 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5445
5446 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5447 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5448 isn't needed on 32-bit machines.
5449
5450 * buffer.c (Fgenerate_new_buffer_name):
5451 Use EMACS_INT for count, not int.
5452 (advance_to_char_boundary): Return EMACS_INT, not int.
5453
5454 * data.c (Qcompiled_function): Now static.
5455
5456 * window.c (window_body_lines): Now static.
5457
5458 * image.c (gif_load): Rename local to avoid shadowing.
5459
5460 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5461 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5462 * alloc.c (make_save_value): Integer argument is now of type
5463 ptrdiff_t, not int.
5464 (mark_object): Use ptrdiff_t, not int.
5465 * lisp.h (pD): New macro.
5466 * print.c (print_object): Use it.
5467
5468 * alloc.c: Use EMACS_INT, not int, to count objects.
5469 (total_conses, total_markers, total_symbols, total_vector_size)
5470 (total_free_conses, total_free_markers, total_free_symbols)
5471 (total_free_floats, total_floats, total_free_intervals)
5472 (total_intervals, total_strings, total_free_strings):
5473 Now EMACS_INT, not int. All uses changed.
5474 (Fgarbage_collect): Compute overall total using a double, so that
5475 integer overflow is less likely to be a problem. Check for overflow
5476 when converting back to an integer.
5477 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5478 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5479 These were 'int' variables that could overflow on 64-bit hosts;
5480 they were never used, so remove them instead of repairing them.
5481 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5482 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5483 Previously, this ceilinged at INT_MAX, but that doesn't work on
5484 64-bit machines.
5485 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5486
5487 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5488 (allocate_vectorlike): Check for ptrdiff_t overflow.
5489 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5490 when a (possibly-narrower) signed value would do just as well.
5491 We prefer using signed arithmetic, to avoid comparison confusion.
5492
5493 * alloc.c: Catch some string size overflows that we were missing.
5494 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5495 for convenience in STRING_BYTES_MAX.
5496 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5497 The definition here is exact; the one in lisp.h was approximate.
5498 (allocate_string_data): Check for string overflow. This catches
5499 some instances we weren't catching before. Also, it catches
5500 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5501 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5502 and ptrdiff_t and EMACS_INT are both 64 bits.
5503
5504 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5505 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5506 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5507
5508 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5509
5510 * alloc.c (Fmake_string): Check for out-of-range init.
5511
5512 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5513
5514 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5515
5516 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5517
5518 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5519 xg_get_default_scrollbar_width.
5520
5521 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5522 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5523 (style_changed_cb): Call update_theme_scrollbar_width and call
5524 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5525 all frames (Bug#8505).
5526 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5527 Call gtk_window_set_resizable if HAVE_GTK3.
5528 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5529 and height if HAVE_GTK3 (Bug#8505).
5530 (scroll_bar_width_for_theme): New variable.
5531 (update_theme_scrollbar_width): New function.
5532 (xg_get_default_scrollbar_width): Move code to
5533 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5534 (xg_initialize): Call update_theme_scrollbar_width.
5535
5536 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5537
5538 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5539
5540 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5541
5542 * frame.c (make_frame): Call other_buffer_safely instead of
5543 other_buffer.
5544
5545 * window.c (temp_output_buffer_show): Call display_buffer with
5546 second argument Vtemp_buffer_show_specifiers and reset latter
5547 immediately after the call.
5548 (Vtemp_buffer_show_specifiers): New variable.
5549 (auto_window_vscroll_p, next_screen_context_lines)
5550 (Vscroll_preserve_screen_position): Remove leading asterisks from
5551 doc-strings.
5552
5553 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5554
5555 Fix minor problems found by GCC 4.6.0 static checking.
5556 * buffer.c (Qclone_number): Remove for now, as it's unused.
5557 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5558 (record_buffer): Remove unused local.
5559 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5560 (set_frame_buffer_list): Remove; unused.
5561 * frame.h (other_visible_frames): Remove decl.
5562 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5563 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5564 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5565 if HAVE_GPM.
5566 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5567 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5568 Define only if HAVE_GPM.
5569 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5570 (update_hints_inhibit): Remove; never set. All uses removed.
5571 * widgetprv.h (emacsFrameClassRec): Remove decl.
5572 * window.c (delete_deletable_window): Now returns void, since it
5573 wasn't returning anything.
5574 (compare_window_configurations): Remove unused locals.
5575 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5576 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5577 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5578 the same widths as pointers. This follows up on the 2011-05-06 patch.
5579 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5580 * xterm.h: Likewise.
5581 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5582
5583 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5584
5585 * makefile.w32-in: Update dependencies.
5586 (LISP_H): Add lib/intprops.h.
5587
5588 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5589
5590 * image.c (gif_load): Add animation frame delay to the metadata.
5591 (syms_of_image): Use DEFSYM. New symbol `delay'.
5592
5593 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5594
5595 * window.c (delete_deletable_window): Re-add.
5596 (Fset_window_configuration): Rewrite to handle dead buffers and
5597 consequently deletable windows.
5598 (window_tree, Fwindow_tree): Remove. Supply functionality in
5599 window.el.
5600 (compare_window_configurations): Simplify code.
5601
5602 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5603
5604 * image.c (imagemagick_load_image): Fix type mismatch.
5605 (Fimagemagick_types): Likewise.
5606
5607 * window.h (replace_buffer_in_windows): Declare.
5608
5609 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5610
5611 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5612 Qclone_number. Remove external declaration of Qdelete_window.
5613 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5614 code.
5615 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5616 Run Qbuffer_list_update_hook if allowed.
5617 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5618 buffer list implementation.
5619 (other_buffer_safely): New function.
5620 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5621 calls to replace_buffer_in_windows and
5622 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5623 if allowed.
5624 (record_buffer): Inhibit quitting and rewrite using quittable
5625 functions. Run Qbuffer_list_update_hook if allowed.
5626 (Frecord_buffer, Funrecord_buffer): New functions.
5627 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5628 Move switch-to-buffer to window.el.
5629 (bury-buffer): Move to window.el.
5630 (Vbuffer_list_update_hook): New variable.
5631
5632 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5633 section.
5634
5635 * window.h (resize_frame_windows): Move up in code.
5636 (Fwindow_frame): Remove EXFUN.
5637 (replace_buffer_in_all_windows): Remove prototype.
5638 (replace_buffer_in_windows_safely): Add prototype.
5639
5640 * window.c: Declare Qdelete_window static again. Move down
5641 declaration of select_count.
5642 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5643 (Fother_window): Move to window.el.
5644 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5645 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5646 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5647 window.el.
5648 (replace_buffer_in_windows): Implement by calling
5649 Qreplace_buffer_in_windows.
5650 (replace_buffer_in_all_windows): Remove with some functionality
5651 moved into replace_buffer_in_windows_safely.
5652 (replace_buffer_in_windows_safely): New function.
5653 (select_window_norecord, select_frame_norecord): Move in front
5654 of run_window_configuration_change_hook. Remove now obsolete
5655 declarations.
5656 (Fset_window_buffer): Rewrite doc-string.
5657 Call Qrecord_window_buffer.
5658 (keys_of_window): Move binding for other-window to window.el.
5659
5660 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5661
5662 * dispextern.h (struct image): Replace data member, whose int_val
5663 and ptr_val fields were not used by anything, with a single
5664 lisp_val object.
5665
5666 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5667 (gif_clear_image, gif_load, imagemagick_load_image)
5668 (gs_clear_image, gs_load): Callers changed.
5669
5670 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5671
5672 * buffer.h: Include <time.h>, for time_t.
5673 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5674
5675 Fix minor problems found by static checking.
5676
5677 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5678
5679 Make identifiers static if they are not used in other modules.
5680 * data.c (Qcompiled_function, Qframe, Qvector):
5681 * image.c (QimageMagick, Qsvg):
5682 * minibuf.c (Qmetadata):
5683 * window.c (resize_window_check, resize_root_window): Now static.
5684 * window.h (resize_window_check, resize_root_window): Remove decls.
5685
5686 * window.c (window_deletion_count, delete_deletable_window):
5687 Remove; unused.
5688 (window_body_lines): Now static.
5689 (Fdelete_other_windows_internal): Mark vars as initialized.
5690 Make sure 'resize_failed' is initialized.
5691 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5692 (resize_window_apply): Remove unused local.
5693 * window.h (delete_deletable_window): Remove decl.
5694
5695 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5696 (imagemagick_load_image): Fix pointer signedness problem by changing
5697 last arg from unsigned char * to char *. All uses changed.
5698 Also, fix a local for similar reasons.
5699 Remove unused locals. Remove locals to avoid shadowing.
5700 (fn_rsvg_handle_free): Remove; unused.
5701 (svg_load, svg_load_image): Fix pointer signedness problem.
5702 (imagemagick_load_image): Don't use garbage pointer image_wand.
5703
5704 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5705
5706 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5707
5708 * image.c (gif_load): Fix omitted cast error introduced by
5709 2011-06-06 change.
5710
5711 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5712
5713 * window.h (resize_proportionally, orig_total_lines)
5714 (orig_top_line): Remove from window structure.
5715 (set_window_height, set_window_width, change_window_heights)
5716 (Fdelete_window): Remove prototypes.
5717 (resize_frame_windows): Remove duplicate declaration.
5718
5719 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5720
5721 * window.h (resize_frame_windows, resize_window_check)
5722 (delete_deletable_window, resize_root_window)
5723 (resize_frame_windows): Declare prototypes.
5724
5725 * window.c (resize_window_apply): Make definition be "static" to
5726 match the prototype.
5727
5728 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5729
5730 * window.c: Remove declarations of Qwindow_size_fixed,
5731 window_min_size_1, window_min_size_2, window_min_size,
5732 size_window, window_fixed_size_p, enlarge_window, delete_window.
5733 Remove static from declaration of Qdelete_window, it's
5734 temporarily needed by Fbury_buffer.
5735 (replace_window): Don't assign orig_top_line and
5736 orig_total_lines.
5737 (Fdelete_window, delete_window): Remove. Window deletion is
5738 handled by window.el.
5739 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5740 Replace Fdelete_window calls with calls to Qdelete_window.
5741 (Fdelete_other_windows): Remove. Deleting other windows is
5742 handled by window.el.
5743 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5744 handled in window.el.
5745 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5746 Window minimum sizes are handled in window.el.
5747 (shrink_windows, size_window, set_window_height)
5748 (set_window_width, change_window_heights, window_height)
5749 (window_width, CURBEG, CURSIZE, enlarge_window)
5750 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5751 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5752 handled in window.el.
5753 (make_dummy_parent): Rename to make_parent_window and give it a
5754 second argument horflag.
5755 (make_window): Don't set resize_proportionally any more.
5756 (Fsplit_window): Remove. Windows are split in window.el.
5757 (save_restore_action, save_restore_orig_size)
5758 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5759 Resize mini windows in window.el.
5760 (grow_mini_window, shrink_mini_window): Implement by calling
5761 Qresize_root_window_vertically, resize_window_check and
5762 resize_window_apply.
5763 (saved_window, Fset_window_configuration, save_window_save):
5764 Do not handle orig_top_line, orig_total_lines, and
5765 resize_proportionally.
5766 (window_min_height, window_min_width): Move to window.el.
5767 (keys_of_window): Move bindings for delete-other-windows,
5768 split-window, delete-window and enlarge-window to window.el.
5769
5770 * buffer.c: Temporarily extern Qdelete_window.
5771 (Fbury_buffer): Temporarily call Qdelete_window instead of
5772 Fdelete_window (Fbury_buffer will move to window.el soon).
5773
5774 * frame.c (set_menu_bar_lines_1): Remove code handling
5775 orig_top_line and orig_total_lines.
5776
5777 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5778 set_window_height but set heights directly.
5779 (change_frame_size_1): Use resize_frame_windows.
5780
5781 * xdisp.c (init_xdisp): Don't use set_window_height but set
5782 heights directly.
5783
5784 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5785 Use resize_frame_windows instead of change_window_heights and run
5786 run_window_configuration_change_hook.
5787
5788 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5789 instead of change_window_heights and run
5790 run_window_configuration_change_hook.
5791
5792 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5793
5794 * window.c (replace_window): Rename second argument REPLACEMENT to
5795 NEW. New third argument SETFLAG. Rewrite.
5796 (delete_window, make_dummy_parent): Call replace_window with
5797 third argument 1.
5798 (window_list_1): Move down in code.
5799 (run_window_configuration_change_hook): Move set_buffer part
5800 before select_frame_norecord part in order to unwind correctly.
5801 Rename count1 to count.
5802 (recombine_windows, delete_deletable_window, resize_root_window)
5803 (Fdelete_other_windows_internal)
5804 (Frun_window_configuration_change_hook, make_parent_window)
5805 (resize_window_check, resize_window_apply, Fresize_window_apply)
5806 (resize_frame_windows, Fsplit_window_internal)
5807 (Fdelete_window_internal, Fresize_mini_window_internal):
5808 New functions.
5809 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5810
5811 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5812
5813 * window.h (window): Add some new members to window structure -
5814 normal_lines, normal_cols, new_total, new_normal, clone_number,
5815 splits, nest, prev_buffers, next_buffers.
5816 (WINDOW_TOTAL_SIZE): Move here from window.c.
5817 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5818
5819 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5820 Remove.
5821 (make_dummy_parent): Set new members of windows structure.
5822 (make_window): Move down in code. Handle new members of window
5823 structure.
5824 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5825 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5826 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5827 (Fset_window_prev_buffers, Fwindow_next_buffers)
5828 (Fset_window_next_buffers, Fset_window_clone_number):
5829 New functions.
5830 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5831 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5832 Doc-string fixes.
5833 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5834 Argument WINDOW can be now internal window too.
5835 (Fwindow_use_time): Move up in code.
5836 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5837 Rewrite doc-string.
5838 (Fset_window_configuration, saved_window)
5839 (Fcurrent_window_configuration, save_window_save): Handle new
5840 members of window structure.
5841 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5842 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5843 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5844 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5845 Qget_mru_window, Qresize_root_window,
5846 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5847 Qauto_buffer_name; staticpro them.
5848
5849 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5850
5851 * window.c (Fwindow_total_size, Fwindow_left_column)
5852 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5853 (Fwindow_list_1): New functions.
5854 (window_box_text_cols): Replace with window_body_cols.
5855 (Fwindow_width, Fscroll_left, Fscroll_right):
5856 Use window_body_cols instead of window_box_text_cols.
5857 (delete_window, Fset_window_configuration):
5858 Call delete_all_subwindows with window as argument.
5859 (delete_all_subwindows): Take a window as argument and not a
5860 structure. Rewrite.
5861 (window_loop): Remove handling of GET_LRU_WINDOW and
5862 GET_LARGEST_WINDOW.
5863 (Fget_lru_window, Fget_largest_window): Move to window.el.
5864
5865 * window.h: Extern window_body_cols instead of
5866 window_box_text_cols. delete_all_subwindows now takes a
5867 Lisp_Object as argument.
5868
5869 * indent.c (compute_motion, Fcompute_motion):
5870 Use window_body_cols instead of window_box_text_cols.
5871
5872 * frame.c (delete_frame): Call delete_all_subwindows with root
5873 window as argument.
5874
5875 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5876
5877 * fns.c (Fputhash): Document return value.
5878
5879 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5880
5881 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5882
5883 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5884
5885 Cons<->int and similar integer overflow fixes (Bug#8794).
5886
5887 Check for overflow when converting integer to cons and back.
5888 * charset.c (Fdefine_charset_internal, Fdecode_char):
5889 Use cons_to_unsigned to catch overflow.
5890 (Fencode_char): Use INTEGER_TO_CONS.
5891 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5892 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5893 * data.c (long_to_cons, cons_to_long): Remove.
5894 (cons_to_unsigned, cons_to_signed): New functions.
5895 These signal an error for invalid or out-of-range values.
5896 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5897 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5898 * font.c (Ffont_variation_glyphs):
5899 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5900 * lisp.h: Include <intprops.h>.
5901 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5902 (cons_to_signed, cons_to_unsigned): New decls.
5903 (long_to_cons, cons_to_long): Remove decls.
5904 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5905 (Fprimitive_undo): Use CONS_TO_INTEGER.
5906 * xfns.c (Fx_window_property): Likewise.
5907 * xselect.c: Include <limits.h>.
5908 (x_own_selection, selection_data_to_lisp_data):
5909 Use INTEGER_TO_CONS.
5910 (x_handle_selection_request, x_handle_selection_clear)
5911 (x_get_foreign_selection, Fx_disown_selection_internal)
5912 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5913 (lisp_data_to_selection_data): Use cons_to_unsigned.
5914 (x_fill_property_data): Use cons_to_signed.
5915 Report values out of range.
5916
5917 Check for buffer and string overflow more precisely.
5918 * buffer.h (BUF_BYTES_MAX): New macro.
5919 * lisp.h (STRING_BYTES_MAX): New macro.
5920 * alloc.c (Fmake_string):
5921 * character.c (string_escape_byte8):
5922 * coding.c (coding_alloc_by_realloc):
5923 * doprnt.c (doprnt):
5924 * editfns.c (Fformat):
5925 * eval.c (verror):
5926 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5927 since they may not be the same number.
5928 * editfns.c (Finsert_char):
5929 * fileio.c (Finsert_file_contents):
5930 Likewise for BUF_BYTES_MAX.
5931
5932 * image.c: Use ptrdiff_t, not int, for sizes.
5933 (slurp_file): Switch from int to ptrdiff_t.
5934 All uses changed.
5935 (slurp_file): Check that file size fits in both size_t (for
5936 malloc) and ptrdiff_t (for sanity and safety).
5937
5938 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5939 if b->modtime has its maximal value.
5940
5941 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5942
5943 Don't assume time_t can fit into int.
5944 * buffer.h (struct buffer.modtime): Now time_t, not int.
5945 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5946 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5947
5948 Minor fixes for signed vs unsigned integers.
5949 * character.h (MAYBE_UNIFY_CHAR):
5950 * charset.c (maybe_unify_char):
5951 * keyboard.c (read_char, reorder_modifiers):
5952 XINT -> XFASTINT, since the integer must be nonnegative.
5953 * ftfont.c (ftfont_spec_pattern):
5954 * keymap.c (access_keymap, silly_event_symbol_error):
5955 XUINT -> XFASTINT, since the integer must be nonnegative.
5956 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5957 since it makes no difference and we prefer signed.
5958 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5959 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5960 nonnegative.
5961
5962 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5963
5964 * window.h (Fwindow_frame): Declare.
5965
5966 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5967
5968 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5969 (SPARE_MEMORY): Always define.
5970 (LARGE_REQUEST): Remove.
5971 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5972
5973 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5974
5975 * lisp.h: Move EXFUNS for Fframe_root_window,
5976 Fframe_first_window and Fset_frame_selected_window to window.h.
5977
5978 * window.h: Move EXFUNS for Fframe_root_window,
5979 Fframe_first_window and Fset_frame_selected_window here from
5980 lisp.h.
5981
5982 * frame.c (Fwindow_frame, Fframe_first_window)
5983 (Fframe_root_window, Fframe_selected_window)
5984 (Fset_frame_selected_window): Move to window.c.
5985 (Factive_minibuffer_window): Move to minibuf.c.
5986 (Fother_visible_frames_p): New function.
5987
5988 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5989
5990 * window.c (decode_window, decode_any_window): Move up in code.
5991 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5992 (inhibit_frame_unsplittable): Remove unused variable.
5993 (Fwindow_buffer): Move up and rewrite doc-string.
5994 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5995 (Fwindow_prev): New functions.
5996 (Fwindow_frame): Move here from frame.c. Accept any window as
5997 argument.
5998 (Fframe_root_window, Fframe_first_window)
5999 (Fframe_selected_window): Move here from frame.c. Accept frame
6000 or arbitrary window as argument. Update doc-strings.
6001 (Fminibuffer_window): Move up in code.
6002 (Fwindow_minibuffer_p): Move up in code and simplify.
6003 (Fset_frame_selected_window): Move here from frame.c.
6004 Marginal rewrite.
6005 (Fselected_window, select_window, Fselect_window): Move up in
6006 code. Minor doc-string fixes.
6007
6008 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6009
6010 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6011 Do not assume that spare memory exists; that assumption is valid
6012 only if SYSTEM_MALLOC.
6013 (LARGE_REQUEST): New macro, so that the issue of large requests
6014 is separated from the issue of spare memory.
6015
6016 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6017
6018 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6019 format. (Bug#8806)
6020
6021 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6022
6023 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6024 before statements.
6025
6026 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6027
6028 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6029
6030 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6031
6032 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6033 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6034
6035 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6036
6037 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6038
6039 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6040
6041 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6042 (x_clipboard_manager_save): Add return value.
6043 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6044 New error handlers.
6045 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6046 Obey Vx_select_enable_clipboard_manager. Catch errors in
6047 x_clipboard_manager_save (Bug#8779).
6048 (Vx_select_enable_clipboard_manager): New variable.
6049 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6050
6051 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6052
6053 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6054
6055 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6056
6057 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6058 in the current matrix if keep_current_p is non-zero.
6059
6060 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6061
6062 * bidi.c (bidi_level_of_next_char): Fix last change.
6063
6064 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6065
6066 Support bidi reordering of text covered by display properties.
6067
6068 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6069 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6070 (bidi_cache_search, bidi_cache_iterator_state)
6071 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6072 (bidi_level_of_next_char, bidi_move_to_visually_next):
6073 Support character positions inside a run of characters covered by a
6074 display string.
6075 (bidi_paragraph_init, bidi_resolve_explicit_1)
6076 (bidi_level_of_next_char): Call bidi_fetch_char and
6077 bidi_fetch_char_advance instead of FETCH_CHAR and
6078 FETCH_CHAR_ADVANCE.
6079 (bidi_init_it): Initialize new members.
6080 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6081 definitions.
6082 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6083 instead of using explicit *_CHAR codes.
6084 (bidi_resolve_explicit, bidi_resolve_weak):
6085 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6086 bidirectional text is supported only in multibyte buffers.
6087 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6088 it to initialize the frame_window_p member of struct bidi_it.
6089 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6090 (bidi_resolve_explicit, bidi_resolve_weak)
6091 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6092 bidi_it->nchars is non-positive.
6093 (bidi_level_of_next_char): Don't try to lookup the cache for the
6094 next/previous character if nothing is cached there yet, or if we
6095 were just reseat()'ed to a new position.
6096
6097 * xdisp.c (set_cursor_from_row): Set start and stop points
6098 according to the row's direction when priming the loop that looks
6099 for the glyph on which to display cursor.
6100 (single_display_spec_intangible_p): Function deleted.
6101 (display_prop_intangible_p): Reimplement to call
6102 handle_display_spec instead of single_display_spec_intangible_p.
6103 Accept 3 additional arguments needed by handle_display_spec.
6104 This fixes incorrect cursor motion across display property with complex
6105 values: lists, `(when COND...)' forms, etc.
6106 (single_display_spec_string_p): Support property values that are
6107 lists with the argument STRING its top-level element.
6108 (display_prop_string_p): Fix the condition for processing a
6109 property that is a list to be consistent with handle_display_spec.
6110 (handle_display_spec): New function, refactored from the
6111 last portion of handle_display_prop.
6112 (compute_display_string_pos): Accept additional argument
6113 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6114 value of a `display' property is a "replacing spec".
6115 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6116 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6117 the display property, but just return a value indicating whether
6118 the display property will replace the characters it covers.
6119 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6120 frame_window_p members of struct bidi_it.
6121 (compute_display_string_pos, compute_display_string_end):
6122 New functions.
6123 (push_it): Accept second argument POSITION, where pop_it should
6124 jump to continue iteration.
6125 (reseat_1): Initialize bidi_it.disp_pos.
6126
6127 * keyboard.c (adjust_point_for_property): Adjust the call to
6128 display_prop_intangible_p to its new signature.
6129
6130 * dispextern.h (struct bidi_it): New member frame_window_p.
6131 (bidi_init_it): Update prototypes.
6132 (display_prop_intangible_p): Update prototype.
6133 (compute_display_string_pos, compute_display_string_end):
6134 Declare prototypes.
6135 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6136 EMACS_INT.
6137
6138 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6139
6140 Malloc failure behavior now depends on size of allocation.
6141 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6142 * lisp.h: Change signatures accordingly.
6143 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6144 All callers changed. (Bug#8762)
6145
6146 * gnutls.c: Use Emacs's memory allocators.
6147 Without this change, the gnutls library would invoke malloc etc.
6148 directly, which causes problems on non-SYNC_INPUT hosts, and which
6149 runs afoul of improving memory_full behavior. (Bug#8761)
6150 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6151 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6152 xfree instead of the default malloc, realloc, free.
6153 (Fgnutls_boot): No need to check for memory allocation failure,
6154 since xmalloc does that for us.
6155
6156 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6157 * category.c (hash_get_category_set):
6158 * ccl.c (ccl_driver):
6159 * charset.c (Fdefine_charset_internal):
6160 * charset.h (struct charset.hash_index):
6161 * composite.c (get_composition_id, gstring_lookup_cache)
6162 (composition_gstring_put_cache):
6163 * composite.h (struct composition.hash_index):
6164 * dispextern.h (struct image.hash):
6165 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6166 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6167 (hashfn_equal, hashfn_user_defined, make_hash_table)
6168 (maybe_resize_hash_table, hash_lookup, hash_put)
6169 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6170 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6171 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6172 * image.c (make_image, search_image_cache, lookup_image)
6173 (xpm_put_color_table_h):
6174 * lisp.h (struct Lisp_Hash_Table):
6175 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6176 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6177 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6178 * alloc.c (allocate_vectorlike):
6179 Check for overflow in vector size calculations.
6180 * ccl.c (ccl_driver):
6181 Check for overflow when converting EMACS_INT to int.
6182 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6183 need to be updated by these changes.
6184 * fns.c (make_hash_table, maybe_resize_hash_table):
6185 Check for integer overflow with large hash tables.
6186 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6187 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6188 (SXHASH_REDUCE): New macro.
6189 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6190 Use it instead of discarding useful hash info with large hash values.
6191 (sxhash_float): New function.
6192 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6193 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6194 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6195 Rewrite to use FIXNUM_BITS, as this simplifies things.
6196 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6197 Adjust signatures to match updated version of code.
6198 (consing_since_gc): Now EMACS_INT, since a single hash table can
6199 use more than INT_MAX bytes.
6200
6201 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6202
6203 Make it possible to build with GCC-4.6+ -O2 -flto.
6204
6205 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6206
6207 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6208
6209 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6210 Call minibuffer-inactive-mode.
6211
6212 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6213
6214 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6215 Update dependencies.
6216
6217 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6218
6219 * data.c (init_data): Remove code for UTS, this system is not
6220 supported anymore.
6221
6222 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6223
6224 Don't force ./temacs to start in terminal mode.
6225
6226 * frame.c (make_initial_frame): Initialize faces in all cases, not
6227 only when CANNOT_DUMP is defined.
6228 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6229
6230 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6231
6232 * dispnew.c (add_window_display_history): Use const for the string
6233 pointer. Remove declaration, not needed.
6234
6235 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6236
6237 Use 'inline', not 'INLINE'.
6238 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6239 * alloc.c, fontset.c (INLINE): Remove.
6240 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6241 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6242 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6243 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6244 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6245
6246 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6247
6248 Make it possible to run ./temacs.
6249
6250 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6251 syms_of_callproc does the same thing. Remove test for
6252 "initialized", do it in the caller.
6253 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6254
6255 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6256
6257 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6258 (read_minibuf): Use get_minibuffer.
6259 (syms_of_minibuf): Use DEFSYM.
6260 (Qmetadata): New var.
6261 * data.c (Qbuffer): Don't make it static.
6262 (syms_of_data): Use DEFSYM.
6263
6264 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6265
6266 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6267 (CCL_CODE_MIN): New macro.
6268
6269 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6270
6271 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6272
6273 * eval.c (Qdebug): Now static.
6274 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6275 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6276 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6277
6278 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6279
6280 * image.c: Various fixes to ImageMagick code comments.
6281 (Fimagemagick_types): Doc fix.
6282
6283 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6284
6285 Minor fixes prompted by GCC 4.6.0 warnings.
6286
6287 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6288
6289 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6290 (x_clipboard_manager_save_all): Move extern decl to ...
6291 * xterm.h: ... here, so that it can be checked for consistency.
6292
6293 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6294
6295 * xselect.c (x_clipboard_manager_save_frame)
6296 (x_clipboard_manager_save_all): New functions.
6297 (Fx_clipboard_manager_save): Lisp function deleted.
6298
6299 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6300 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6301
6302 * xterm.h: Update prototype.
6303
6304 2011-05-28 William Xu <william.xwl@gmail.com>
6305
6306 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6307 exiting (Bug#8239).
6308
6309 2011-05-28 Jim Meyering <meyering@redhat.com>
6310
6311 Avoid a sign-extension bug in crypto_hash_function.
6312 * fns.c (to_uchar): Define.
6313 (crypto_hash_function): Use it to convert some newly-signed
6314 variables to unsigned, to avoid sign-extension bugs. For example,
6315 without this change, (md5 "truc") would evaluate to
6316 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6317 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6318 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6319
6320 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6321
6322 Integer overflow fixes.
6323
6324 * dbusbind.c: Serial number integer overflow fixes.
6325 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6326 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6327 to hold a serial number that is too large for a fixnum.
6328 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6329 Check for serial numbers out of range. Decode any serial number
6330 that was so large that it became a float. (Bug#8722)
6331
6332 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6333 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6334 Use XFASTINT rather than XUINT when numbers are nonnegative.
6335 (xd_append_arg, Fdbus_method_return_internal):
6336 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6337 arguments, check that Lisp number is nonnegative, rather than
6338 silently wrapping negative numbers around. (Bug#8722)
6339 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6340 (Bug#8722)
6341
6342 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6343
6344 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6345
6346 ccl: Add integer overflow checks.
6347 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6348 (IN_INT_RANGE): New macros.
6349 (ccl_driver): Use them to check for integer overflow when
6350 decoding a CCL program. Many of the new checks are whether XINT (x)
6351 fits in int; it doesn't always, on 64-bit hosts. The new version
6352 doesn't catch all possible integer overflows, but it's an
6353 improvement. (Bug#8719)
6354
6355 * alloc.c (make_event_array): Use XINT, not XUINT.
6356 There's no need for unsigned here.
6357
6358 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6359 This follows up to the 2011-05-06 change that substituted uintptr_t
6360 for EMACS_INT. This case wasn't caught back then.
6361
6362 Rework Fformat to avoid integer overflow issues.
6363 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6364 now (part of C89). Include <verify.h>.
6365 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6366 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6367 (Fformat): Avoid the prepass trying to compute sizes; it was only
6368 approximate and thus did not catch overflow reliably. Instead, walk
6369 through the format just once, formatting and computing sizes as we go,
6370 checking for integer overflow at every step, and allocating a larger
6371 buffer as needed. Keep track separately whether the format is
6372 multibyte. Keep only the most-recently calculated precision, rather
6373 than them all. Record whether each argument has been converted to
6374 string. Use EMACS_INT, not int, for byte and char and arg counts.
6375 Support field widths and precisions larger than INT_MAX. Avoid
6376 sprintf's undefined behavior with conversion specifications such as %#d
6377 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6378 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6379 formatting out-of-range floating point numbers with int
6380 formats. (Bug#8668)
6381
6382 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6383
6384 * data.c: Avoid integer truncation in expressions involving floats.
6385 * data.c: Include <intprops.h>.
6386 (arith_driver): When there's an integer overflow in an expression
6387 involving floating point, convert the integers to floating point
6388 so that the resulting value does not suffer from catastrophic
6389 integer truncation. For example, on a 64-bit host (* 4
6390 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6391 Do not rely on undefined behavior after integer overflow.
6392
6393 merge count_size_as_multibyte, parse_str_to_multibyte
6394 * character.c, character.h (count_size_as_multibyte):
6395 Rename from parse_str_to_multibyte; all uses changed.
6396 Check for integer overflow.
6397 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6398 since it's now a duplicate of the other. This is more of
6399 a character than a buffer op, so better that it's in character.c.
6400 * fns.c, print.c: Adjust to above changes.
6401
6402 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6403
6404 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6405
6406 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6407
6408 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6409 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6410 (x_clipboard_manager_save): Now static.
6411 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6412
6413 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6414 (crypto_hash_function): Now static.
6415 Fix pointer signedness problems. Avoid unnecessary initializations.
6416
6417 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6418
6419 * termhooks.h (Vselection_alist): Make it terminal-local.
6420
6421 * terminal.c (create_terminal): Initialize it.
6422
6423 * xselect.c: Support for clipboard managers.
6424 (Vselection_alist): Move to termhooks.h as terminal-local var.
6425 (LOCAL_SELECTION): New macro.
6426 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6427 (symbol_to_x_atom): Remove gratuitous arg.
6428 (x_handle_selection_request, lisp_data_to_selection_data)
6429 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6430 (x_own_selection, x_get_local_selection, x_convert_selection):
6431 New arg, specifying work frame. Use terminal-local Vselection_alist.
6432 (some_frame_on_display): Delete unused function.
6433 (Fx_own_selection_internal, Fx_get_selection_internal)
6434 (Fx_disown_selection_internal, Fx_selection_owner_p)
6435 (Fx_selection_exists_p): New optional frame arg.
6436 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6437 (x_handle_selection_clear): Don't treat other terminals with the
6438 same keyboard specially. Use the terminal-local Vselection_alist.
6439 (x_clear_frame_selections): Use Frun_hook_with_args.
6440
6441 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6442
6443 * xterm.h: Add support for those atoms.
6444
6445 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6446
6447 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6448 (converted_selections, conversion_fail_tag): New global variables.
6449 (x_selection_request_lisp_error): Free the above.
6450 (x_get_local_selection): Remove unnecessary code.
6451 (x_reply_selection_request): Args changed; handle arbitrary array
6452 of converted selections stored in converted_selections.
6453 Separate the XChangeProperty and SelectionNotify steps.
6454 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6455 (x_convert_selection): New function.
6456 (x_handle_selection_event): Simplify.
6457 (x_get_foreign_selection): Don't ignore incoming requests while
6458 waiting for an answer; this will fail when we implement
6459 SAVE_TARGETS, and seems unnecessary anyway.
6460 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6461 (Vx_sent_selection_functions): Doc fix.
6462
6463 2011-05-26 Leo Liu <sdl.web@gmail.com>
6464
6465 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6466
6467 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6468
6469 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6470
6471 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6472 for fringe update if it has periodic bitmap.
6473 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6474 and fringe_bitmap_periodic_p.
6475
6476 * fringe.c (get_fringe_bitmap_data): New function.
6477 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6478 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6479 row. Mark glyph row for fringe update if periodicity changed.
6480
6481 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6482 for fringe update unless it has periodic bitmap.
6483
6484 2011-05-25 Kenichi Handa <handa@m17n.org>
6485
6486 * xdisp.c (get_next_display_element): Set correct it->face_id for
6487 a static composition.
6488
6489 2011-05-24 Leo Liu <sdl.web@gmail.com>
6490
6491 * deps.mk (fns.o):
6492 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6493
6494 * fns.c (crypto_hash_function, Fsha1): New function.
6495 (Fmd5): Use crypto_hash_function.
6496 (syms_of_fns): Add Ssha1.
6497
6498 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6499
6500 * gnutls.c: Remove unused macros.
6501 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6502 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6503 Remove macros that are defined and never used.
6504 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6505
6506 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6507
6508 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6509 (Fx_get_selection_internal): Minor cleanup.
6510 (Fx_own_selection_internal): Rename arguments for consistency with
6511 select.el.
6512
6513 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6514
6515 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6516
6517 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6518
6519 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6520
6521 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6522
6523 * dispnew.c (scrolling_window): Don't exclude the case that the
6524 last enabled row in the desired matrix touches the bottom boundary.
6525
6526 2011-05-21 Glenn Morris <rgm@gnu.org>
6527
6528 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6529 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6530 and add some more files.
6531
6532 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6533
6534 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6535 report_file_error introduced by the change from 2011-05-07.
6536
6537 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6538
6539 * systime.h (Time): Define only if emacs is defined.
6540 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6541 where the include path doesn't have X11/X.h by default. See
6542 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6543
6544 2011-05-20 Kenichi Handa <handa@m17n.org>
6545
6546 * composite.c (find_automatic_composition): Fix previous change.
6547
6548 2011-05-20 Glenn Morris <rgm@gnu.org>
6549
6550 * lisp.mk: New file, split from Makefile.in.
6551 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6552 (shortlisp): Remove.
6553 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6554
6555 2011-05-19 Glenn Morris <rgm@gnu.org>
6556
6557 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6558 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6559 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6560 (lisp): Set the order to that of loadup.el.
6561 (shortlisp): Make it a copy of $lisp.
6562 (SOME_MACHINE_LISP): Remove.
6563 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6564 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6565
6566 2011-05-18 Kenichi Handa <handa@m17n.org>
6567
6568 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6569 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6570 (find_automatic_composition): Mostly rewrite for efficiency.
6571
6572 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6573
6574 * makefile.w32-in: Update dependencies.
6575
6576 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6577
6578 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6579 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6580
6581 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6582
6583 Fix some integer overflow issues, such as string length overflow.
6584
6585 * insdel.c (count_size_as_multibyte): Check for string overflow.
6586
6587 * character.c (lisp_string_width): Check for string overflow.
6588 Use EMACS_INT, not int, for string indexes and lengths; in
6589 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6590 the resulting string length overflows an EMACS_INT; instead,
6591 report a string overflow if no precision given. When checking for
6592 precision exhaustion, use a check that cannot possibly have
6593 integer overflow. (Bug#8675)
6594 * character.h (lisp_string_width): Adjust to new signature.
6595
6596 * alloc.c (string_overflow): New function.
6597 (Fmake_string): Use it. This doesn't change behavior, but saves
6598 a few bytes and will simplify future changes.
6599 * character.c (string_escape_byte8): Likewise.
6600 * lisp.h (string_overflow): New decl.
6601
6602 Fixups, following up to the user-interface timestamp change.
6603 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6604 for UI timestamps, instead of unsigned long.
6605 * msdos.c (mouse_get_pos): Likewise.
6606 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6607 * w32gui.h (Time): Define by including "systime.h" rather than by
6608 declaring it ourselves. (Bug#8664)
6609
6610 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6611 * image.c (clear_image_cache): Likewise.
6612
6613 * term.c (term_mouse_position): Don't assume time_t wraparound.
6614
6615 Be more systematic about user-interface timestamps.
6616 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6617 and sometimes 'EMACS_UINT', to represent these timestamps.
6618 This change causes it to use 'Time' uniformly, as that's what X uses.
6619 This makes the code easier to follow, and makes it easier to catch
6620 integer overflow bugs such as Bug#8664.
6621 * frame.c (Fmouse_position, Fmouse_pixel_position):
6622 Use Time, not unsigned long, for user-interface timestamps.
6623 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6624 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6625 * keyboard.h (last_event_timestamp): Likewise.
6626 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6627 * menu.h (xmenu_show): Likewise.
6628 * term.c (term_mouse_position): Likewise.
6629 * termhooks.h (struct input_event.timestamp): Likewise.
6630 (struct terminal.mouse_position_hook): Likewise.
6631 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6632 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6633 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6634 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6635 what it was before.
6636 * menu.h, termhooks.h: Include "systime.h", for Time.
6637
6638 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6639 Don't assume that the difference between two unsigned long values
6640 can fit into an integer. At this point, we know button_down_time
6641 <= event->timestamp, so the difference must be nonnegative, so
6642 there's no need to cast the result if double-click-time is
6643 nonnegative, as it should be; check that it's nonnegative, just in
6644 case. This bug is triggered when events are more than 2**31 ms
6645 apart (about 25 days). (Bug#8664)
6646
6647 * xselect.c (last_event_timestamp): Remove duplicate decl.
6648 (x_own_selection): Remove needless cast to unsigned long.
6649
6650 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6651 that always fit in int. Use a sentinel instead of a counter, to
6652 avoid a temp and to allay GCC's concerns about possible int overflow.
6653 * frame.h (struct frame): Use int for menu_bar_items_used
6654 instead of EMACS_INT, since it always fits in int.
6655
6656 * menu.c (grow_menu_items): Check for int overflow.
6657
6658 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6659
6660 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6661 Before, the code was not consistent. These values cannot exceed
6662 2**31 - 1 so there's no need to make them unsigned.
6663 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6664 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6665 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6666 as modifiers.
6667 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6668
6669 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6670 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6671 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6672 presumably because the widths might not match.
6673
6674 * window.c (size_window): Avoid needless test at loop start.
6675
6676 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6677
6678 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6679
6680 2011-05-12 Drew Adams <drew.adams@oracle.com>
6681
6682 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6683
6684 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6685
6686 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6687 `width' to `bar_area_x' and `bar_area_width', respectively.
6688 (x_scroll_run): Take account of fringe background extension.
6689
6690 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6691 Rename local vars `left' and `width' to `bar_area_x' and
6692 `bar_area_width', respectively.
6693 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6694 background extension.
6695
6696 2011-05-10 Jim Meyering <meyering@redhat.com>
6697
6698 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6699
6700 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6701
6702 * image.c (Finit_image_library): Return t for built-in image types,
6703 like pbm and xbm. (Bug#8640)
6704
6705 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6706
6707 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6708
6709 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6710
6711 * w32console.c (Fset_screen_color): Doc fix.
6712 (Fget_screen_color): New function.
6713 (syms_of_ntterm): Defsubr it.
6714
6715 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6716 unlink the temporary file if Fcall_process didn't create it in the
6717 first place.
6718 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6719 child process will be redirected to a file specified with `:file'.
6720 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6721 cue to call_process_cleanup not to close that handle.
6722
6723 2011-05-07 Ben Key <bkey76@gmail.com>
6724
6725 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6726 one of two shell specific rules, either bootstrap-temacs-CMD or
6727 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6728 to the previous implementation of the bootstrap-temacs rule.
6729 The bootstrap-temacs-CMD rule is similar to the previous
6730 implementation of the bootstrap-temacs rule except that it
6731 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6732 variable.
6733
6734 These changes, along with some changes to nt/configure.bat,
6735 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6736 earlier fix to add support for --cflags and --ldflags options
6737 that include quotes so that it works whether make uses cmd or
6738 sh as the shell.
6739
6740 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6741
6742 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6743 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6744 is a constant.
6745 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6746 a string. Handle both cases.
6747 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6748 (Fdbus_register_method): Use Qinvalid_function.
6749
6750 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6751
6752 * makefile.w32-in: Update dependencies.
6753 (LISP_H): Add inttypes.h and stdin.h.
6754 (PROCESS_H): Add unistd.h.
6755
6756 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6757
6758 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6759 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6760
6761 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6762
6763 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6764
6765 * term.c (vfatal): Remove stray call to va_end.
6766 It's not needed and the C Standard doesn't allow it here anyway.
6767
6768 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6769 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6770
6771 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6772 bytes.
6773
6774 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6775
6776 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6777
6778 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6779
6780 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6781
6782 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6783
6784 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6785 * charset.c (Fdefine_charset_internal): Don't initialize
6786 charset.code_space[15]. The value was garbage, on hosts with
6787 32-bit int (Bug#8600).
6788
6789 * lread.c (read_integer): Be more consistent with string-to-number.
6790 Use string_to_number to do the actual conversion; this avoids
6791 rounding errors and fixes some other screwups. Without this fix,
6792 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6793 (digit_to_number): Move earlier, for benefit of read_integer.
6794 Return -1 if the digit is out of range for the base, -2 if it is
6795 not a digit in any supported base. (Bug#8602)
6796
6797 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6798
6799 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6800 to match comment at start of function. This also removes a
6801 GCC warning about overflow in a 32+64-bit port.
6802
6803 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6804
6805 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6806 Reported by Stefan Monnier in
6807 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6808 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6809 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6810
6811 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6812 (EMACS_UINTPTR): Likewise, with uintptr_t.
6813
6814 * lisp.h: Prefer 64-bit EMACS_INT if available.
6815 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6816 on 32-bit hosts that have 64-bit int, so that they can access
6817 large files.
6818 However, temporarily disable this change unless the temporary
6819 symbol WIDE_EMACS_INT is defined.
6820
6821 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6822
6823 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6824 This removes an assumption that EMACS_INT and long are the same
6825 width as pointers. The assumption is true for Emacs porting targets
6826 now, but we want to make other targets possible.
6827 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6828 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6829 In the rest of the code, change types of integers that hold casted
6830 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6831 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6832 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6833 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6834 No need to cast type when ORing.
6835 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6836 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6837 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6838 assume EMACS_INT is the same width as char *.
6839 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6840 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6841 Remove no-longer-needed casts.
6842 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6843 (xg_tool_bar_help_callback, xg_make_tool_item):
6844 Use EMACS_INTPTR to hold an integer
6845 that will be cast to void *; this can avoid a GCC warning
6846 if EMACS_INT is not the same width as void *.
6847 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6848 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6849 (current_message_1, set_message_1):
6850 Use a local to convert to proper width without a cast.
6851 * xmenu.c (dialog_selection_callback): Likewise.
6852
6853 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6854 Also, don't assume VALBITS / RAND_BITS is less than 5,
6855 and don't rely on undefined behavior when shifting a 1 left into
6856 the sign bit.
6857 * lisp.h (get_random): Change signature to match.
6858
6859 * lread.c (hash_string): Use size_t, not int, for hash computation.
6860 Normally we prefer signed values; but hashing is special, because
6861 it's better to use unsigned division on hash table sizes so that
6862 the remainder is nonnegative. Also, size_t is the natural width
6863 for hashing into memory. The previous code used 'int', which doesn't
6864 retain enough info to hash well into very large tables.
6865 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6866
6867 * dbusbind.c: Don't possibly lose pointer info when converting.
6868 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6869 Use XPNTR rather than XHASH, so that the high-order bits of
6870 the pointer aren't lost when converting through void *.
6871
6872 * eval.c (Fautoload): Don't double-shift a pointer.
6873
6874 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6875
6876 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6877
6878 * gnutls.c (DEF_GNUTLS_FN):
6879 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6880
6881 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6882
6883 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6884 marker. (Bug#8610)
6885
6886 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6887
6888 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6889 New version that can reserve upto 2GB of heap space.
6890
6891 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6892
6893 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6894
6895 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6896
6897 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6898 `gnutls_certificate_set_x509_key_file'.
6899
6900 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6901
6902 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6903 Update dependencies.
6904
6905 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6906
6907 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6908 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6909 Remove unused parameter `fildes'.
6910 * process.c (read_process_output, send_process): Don't pass it.
6911
6912 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6913
6914 Fix previous change: the library cache is defined in w32.c.
6915 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6916 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6917
6918 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6919
6920 Implement dynamic loading of GnuTLS on Windows.
6921
6922 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6923 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6924 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6925 Declare.
6926
6927 * gnutls.c (Qgnutls_dll): Define.
6928 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6929 (gnutls_*): Declare function pointers.
6930 (init_gnutls_functions): New function to initialize function pointers.
6931 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6932 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6933 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6934 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6935 (emacs_gnutls_write, emacs_gnutls_read)
6936 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6937 (Fgnutls_available_p): New function.
6938 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6939 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6940 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6941
6942 * image.c: Include w32.h.
6943 (Vimage_type_cache): Delete.
6944 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6945 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6946 (w32_delayed_load): Move to w32.c.
6947
6948 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6949
6950 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6951 (w32_delayed_load): Move from image.c. When loading a library, record
6952 its filename in the :loaded-from property of the library id.
6953 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6954 Initialize and staticpro them.
6955 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6956
6957 * process.c: Include lisp.h before w32.h, not after.
6958 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6959 instead of gnutls_record_check_pending.
6960
6961 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6962
6963 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6964
6965 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6966 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6967 as passed in.
6968
6969 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6970
6971 * xterm.c (x_set_frame_alpha): Do not set property on anything
6972 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6973
6974 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6975
6976 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6977
6978 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6979
6980 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6981 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6982 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6983 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6984 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6985 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6986 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6987 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6988 (Qgnutls_bootprop_callbacks_verify): Make static.
6989
6990 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6991
6992 * callproc.c: Indentation fixup.
6993
6994 * sysdep.c (wait_for_termination_1): Make static.
6995 (wait_for_termination, interruptible_wait_for_termination):
6996 Move after wait_for_termination_1.
6997
6998 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6999
7000 * sysdep.c (interruptible_wait_for_termination): New function
7001 which is like wait_for_termination, but allows keyboard
7002 interruptions.
7003
7004 * callproc.c (Fcall_process): Add (:file "file") as an option for
7005 the STDOUT buffer.
7006 (Fcall_process_region): Ditto.
7007
7008 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7009
7010 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7011 rather than `XVECTOR (FOO)->size'.
7012
7013 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7014 inttypes.h, as a gnulib replacement is used if it not available in
7015 system headers.
7016
7017 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7018
7019 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7020 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7021 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7022
7023 * coding.c (coding_alloc_by_realloc): Error out if destination
7024 will grow beyond MOST_POSITIVE_FIXNUM.
7025 (decode_coding_emacs_mule): Abort if there isn't enough place in
7026 charbuf for the composition carryover bytes. Reserve an extra
7027 space for up to 2 characters produced in a loop.
7028 (decode_coding_iso_2022): Abort if there isn't enough place in
7029 charbuf for the composition carryover bytes.
7030
7031 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7032
7033 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7034 aborting when %lld or %lll format is passed.
7035 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7036 %llo or %llx format is passed. (Bug#8545)
7037
7038 * window.c (window_scroll_line_based): Use a marker instead of
7039 simple variables to record original value of point. (Bug#7952)
7040
7041 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7042 produced by %s or %c overflows available buffer space. (Bug#8545)
7043
7044 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7045
7046 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7047 (SIZE_MAX): Move defn after all includes, as they might #define it.
7048
7049 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7050
7051 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7052
7053 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7054
7055 * keyboard.c (Qdelayed_warnings_hook): Define.
7056 (command_loop_1): Run `delayed-warnings-hook'
7057 if Vdelayed_warnings_list is non-nil.
7058 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7059 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7060
7061 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7062
7063 * doprnt.c (doprnt): Don't return value smaller than the buffer
7064 size if the message was truncated. (Bug#8545).
7065
7066 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7067
7068 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7069 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7070
7071 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7072
7073 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7074
7075 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7076
7077 * makefile.w32-in: Update dependencies.
7078
7079 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7080
7081 Improve `doprnt' and its usage. (Bug#8545)
7082 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7083 `format_end'. Remove support for %l as a conversion specifier.
7084 Don't use xrealloc. Improve diagnostics when the %l size modifier
7085 is used. Update the commentary.
7086
7087 * eval.c (verror): Simplify calculation of size_t.
7088
7089 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7090 messages.
7091
7092 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7093
7094 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7095 change.
7096
7097 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7098
7099 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7100 This makes this file independent of the recent pseudovector change.
7101
7102 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7103
7104 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7105
7106 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7107 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7108 Remove unused local.
7109 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7110
7111 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7112 GCC 4.6.0 optimizes based on type-based alias analysis.
7113 For example, if b is of type struct buffer * and v of type struct
7114 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7115 != &v->size, and therefore "v->size = 1; b->size = 2; return
7116 v->size;" must therefore return 1. This assumption is incorrect
7117 for Emacs, since it type-puns struct Lisp_Vector * with many other
7118 types. To fix this problem, this patch adds a new type struct
7119 vectorlike_header that documents the constraints on layout of vectors
7120 and pseudovectors, and helps optimizing compilers not get fooled
7121 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7122 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7123 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7124 the size member.
7125 (XSETPVECTYPE): Rewrite in terms of new macro.
7126 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7127 This is a bit clearer, and further avoids the possibility of
7128 undesirable aliasing.
7129 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7130 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7131 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7132 since Lisp_Subr is a special case (no "next" field).
7133 (ASIZE): Now uses header.size rather than size.
7134 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7135 to avoid the hassle of writing XVECTOR (foo)->header.size.
7136 (struct vectorlike_header): New type.
7137 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7138 object, to help avoid aliasing.
7139 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7140 (SUBRP): Likewise, since Lisp_Subr is a special case.
7141 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7142 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7143 (struct Lisp_Hash_Table): Combine first two members into a single
7144 struct vectorlike_header member. All uses of "size" and "next" members
7145 changed to be "header.size" and "header.next".
7146 * buffer.h (struct buffer): Likewise.
7147 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7148 * frame.h (struct frame): Likewise.
7149 * process.h (struct Lisp_Process): Likewise.
7150 * termhooks.h (struct terminal): Likewise.
7151 * window.c (struct save_window_data, struct saved_window): Likewise.
7152 * window.h (struct window): Likewise.
7153 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7154 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7155 * buffer.c (init_buffer_once): Likewise.
7156 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7157 special case.
7158 * process.c (Fformat_network_address): Use local var for size,
7159 for brevity.
7160
7161 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7162
7163 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7164 * data.c (atof): Remove decl; no longer used or needed.
7165 (digit_to_number): Move to lread.c.
7166 (Fstring_to_number): Use new string_to_number function, to be
7167 consistent with how the Lisp reader treats infinities and NaNs.
7168 Do not assume that floating-point numbers represent EMACS_INT
7169 without losing information; this is not true on most 64-bit hosts.
7170 Avoid double-rounding errors, by insisting on integers when
7171 parsing non-base-10 numbers, as the documentation specifies.
7172 * lisp.h (string_to_number): New decl, replacing ...
7173 (isfloat_string): Remove.
7174 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7175 (read1): Do not accept +. and -. as integers; this
7176 appears to have been a coding error. Similarly, do not accept
7177 strings like +-1e0 as floating point numbers. Do not report
7178 overflow for integer overflows unless the base is not 10 which
7179 means we have no simple and reliable way to continue.
7180 Break out the floating-point parsing into a new
7181 function string_to_number, so that Fstring_to_number parses
7182 floating point numbers consistently with the Lisp reader.
7183 (digit_to_number): Move here from data.c. Make it static inline.
7184 (E_CHAR, EXP_INT): Remove, replacing with ...
7185 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7186 (string_to_number): New function, replacing isfloat_string.
7187 This function checks for valid syntax and produces the resulting
7188 Lisp float number too. Rework it so that string-to-number
7189 no longer mishandles examples like "1.0e+". Use strtoumax,
7190 so that overflow for non-base-10 numbers is reported only when
7191 there's no portable and simple way to convert to floating point.
7192
7193 * textprop.c (set_text_properties_1): Rewrite for clarity,
7194 and to avoid GCC warning about integer overflow.
7195
7196 * intervals.h (struct interval): Use EMACS_INT for members
7197 where EMACS_UINT might cause problems. See
7198 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7199 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7200 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7201 All uses changed.
7202 (offset_intervals): Tell GCC not to worry about length overflow
7203 when negating a negative length.
7204
7205 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7206 (overrun_check_free): Likewise.
7207
7208 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7209 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7210 word size.
7211
7212 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7213 (gnutls_make_error): Rename local to avoid shadowing.
7214 (gnutls_emacs_global_deinit): ifdef out; not used.
7215 (Fgnutls_boot): Use const for pointer to readonly storage.
7216 Comment out unused local. Fix pointer signedness problems.
7217
7218 * lread.c (openp): Don't stuff size_t into an 'int'.
7219 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7220 about possible signed overflow.
7221
7222 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7223 (GDK_KEY_g): Don't define if already defined.
7224 (xg_prepare_tooltip): Avoid pointer signedness problem.
7225 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7226
7227 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7228 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7229
7230 * xfns.c (Fx_window_property): Simplify a bit,
7231 to make a bit faster and to avoid GCC 4.6.0 warning.
7232 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7233
7234 * fns.c (internal_equal): Don't assume size_t fits in int.
7235
7236 * alloc.c (compact_small_strings): Tighten assertion a little.
7237
7238 Replace pEd with more-general pI, and fix some printf arg casts.
7239 * lisp.h (pI): New macro, generalizing old pEd macro to other
7240 conversion specifiers. For example, use "...%"pI"d..." rather
7241 than "...%"pEd"...".
7242 (pEd): Remove. All uses replaced with similar uses of pI.
7243 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7244 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7245 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7246 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7247 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7248 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7249 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7250 64-bit hosts.
7251 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7252 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7253 * print.c (safe_debug_print, print_object): Likewise.
7254 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7255 to int.
7256 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7257 avoiding the 0 flag, which is not portable.
7258 * process.c (Fmake_network_process): Use pI to avoid cast.
7259 * region-cache.c (pp_cache): Likewise.
7260 * xdisp.c (decode_mode_spec): Likewise.
7261 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7262 behavior on 64-bit hosts with printf arg.
7263 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7264 (x_stop_queuing_selection_requests): Likewise.
7265 (x_get_window_property): Don't truncate byte count to an 'int'
7266 when tracing.
7267
7268 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7269 here, since it parses constructs like leading '-' and spaces,
7270 which are not wanted; and it overflows with large numbers.
7271 Instead, simply match F[0-9]+, which is what is wanted anyway.
7272
7273 * alloc.c: Remove unportable assumptions about struct layout.
7274 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7275 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7276 (allocate_vectorlike, make_pure_vector): Use the new macros,
7277 plus offsetof, to remove unportable assumptions about struct layout.
7278 These assumptions hold on all porting targets that I know of, but
7279 they are not guaranteed, they're easy to remove, and removing them
7280 makes further changes easier.
7281
7282 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7283 This doesn't fix a bug but makes the code clearer.
7284 (string_overrun_cookie): Now const. Use initializers that
7285 don't formally overflow signed char, to avoid warnings.
7286 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7287 can cause Emacs to crash when string overrun checking is enabled.
7288 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7289 multiple of sizeof (EMACS_INT); it need not be, if
7290 alignof(EMACS_INT) < sizeof (EMACS_INT).
7291 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7292
7293 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7294
7295 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7296
7297 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7298
7299 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7300 supposed to be handshaking. (Bug#8556)
7301 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7302
7303 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7304
7305 * lisp.h (Qdebug): List symbol.
7306 * eval.c (Qdebug): Restore global linkage.
7307 * keyboard.c (debug-on-event): New variable.
7308 (handle_user_signal): Break into debugger when debug-on-event
7309 matches the current signal symbol.
7310
7311 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7312
7313 * alloc.c (check_sblock, check_string_bytes)
7314 (check_string_free_list): Convert to standard C.
7315
7316 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7317
7318 * w32.c (emacs_gnutls_push): Fix typo.
7319
7320 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7321
7322 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7323 "cast to pointer from integer of different size".
7324
7325 Improve doprnt and its use in verror. (Bug#8545)
7326 * doprnt.c (doprnt): Document the set of format control sequences
7327 supported by the function. Use SAFE_ALLOCA instead of always
7328 using `alloca'.
7329
7330 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7331 is one byte too soon. Don't use xrealloc; instead xfree and
7332 xmalloc anew.
7333
7334 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7335
7336 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7337 callbacks stage.
7338
7339 * gnutls.c: Renamed global_initialized to
7340 gnutls_global_initialized. Added internals for the
7341 :verify-hostname-error, :verify-error, and :verify-flags
7342 parameters of `gnutls-boot' and documented those parameters in the
7343 docstring. Start callback support.
7344 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7345 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7346 on error. Return error code.
7347 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7348 (emacs_gnutls_read): Likewise.
7349 (Fgnutls_boot): Return handshake error code.
7350 (emacs_gnutls_handle_error): New function.
7351 (wsaerror_to_errno): Likewise.
7352
7353 * w32.h (emacs_gnutls_pull): Add prototype.
7354 (emacs_gnutls_push): Likewise.
7355
7356 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7357 (emacs_gnutls_push): Likewise.
7358
7359 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7360
7361 * process.c (wait_reading_process_output): Check if GnuTLS
7362 buffered some data internally if no FDs are set for TLS
7363 connections.
7364
7365 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7366 (LIBS): Link to USER_LIBS.
7367 ($(BLD)/gnutls.$(0)): New target.
7368
7369 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7370
7371 * xdisp.c (handle_single_display_spec): Rename the
7372 display_replaced_before_p argument into display_replaced_p, to
7373 make it consistent with the commentary. Fix typos in the
7374 commentary.
7375
7376 * textprop.c (syms_of_textprop): Remove dead code.
7377 (copy_text_properties): Delete obsolete commentary about an
7378 interface that was deleted long ago. Fix typos in the description
7379 of arguments.
7380
7381 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7382 to changes in oldXMenu/XMenu.h from 2011-04-16.
7383 <menu_help_message, prev_menu_help_message>: Constify.
7384 (IT_menu_make_room): menu->help_text is now `const char **';
7385 adjust.
7386
7387 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7388 to changes in oldXMenu/XMenu.h from 2011-04-16.
7389 (struct XMenu): Declare `help_text' `const char **'.
7390
7391 * xfaces.c <Qunspecified>: Make extern again.
7392
7393 * syntax.c: Include sys/types.h before including regex.h, as
7394 required by POSIX.
7395
7396 * doc.c (get_doc_string): Improve the format passed to `error'.
7397
7398 * doprnt.c (doprnt): Improve commentary.
7399
7400 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7401
7402 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7403 them with etags.
7404
7405 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7406 changes in globals.h immediately force recompilation.
7407 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7408 $(CURDIR)/s/ms-w32.h.
7409 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7410
7411 * character.c (Fchar_direction): Function deleted.
7412 (syms_of_character): Don't defsubr it.
7413 <char-direction-table>: Deleted.
7414
7415 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7416
7417 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7418 * doprnt.c: Include limits.h.
7419 (SIZE_MAX): New macro.
7420 (doprnt): Return a size_t value. 2nd arg is now size_t.
7421 Many local variables are now size_t instead of int or unsigned.
7422 Improve overflow protection. Support `l' modifier for integer
7423 conversions. Support %l conversion. Don't assume an EMACS_INT
7424 argument for integer conversions and for %c.
7425
7426 * lisp.h (doprnt): Restore prototype.
7427
7428 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7429 $(SRC)/character.h.
7430
7431 * Makefile.in (base_obj): Add back doprnt.o.
7432
7433 * deps.mk (doprnt.o): Add back prerequisites.
7434 (callint.o): Depend on character.h.
7435
7436 * eval.c (internal_lisp_condition_case): Include the handler
7437 representation in the error message.
7438 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7439 when breaking from the loop.
7440
7441 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7442
7443 * callint.c (Fcall_interactively): When displaying error message
7444 about invalid control letter, pass the character's codepoint, not
7445 a pointer to its multibyte form. Improve display of the character
7446 in octal and display also its hex code.
7447
7448 * character.c (char_string): Use %x to display the (unsigned)
7449 codepoint of an invalid character, to avoid displaying a bogus
7450 negative value.
7451
7452 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7453 `error', not SYMBOL_NAME itself.
7454
7455 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7456 character arguments to `error'.
7457
7458 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7459 to `error' in error message about FINAL_CHAR argument. Make sure
7460 FINAL_CHAR is a character, and use %c when it is passed as
7461 argument to `error'.
7462
7463 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7464
7465 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7466
7467 * w32.c: Include <time.h>.
7468 (sys_localtime): New function.
7469
7470 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7471
7472 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7473
7474 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7475
7476 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7477
7478 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7479 zombies (Bug#8467).
7480
7481 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7482
7483 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7484 gl_state.e_property when gl_state.object is Qt.
7485
7486 * insdel.c (make_gap_larger): Remove limitation of buffer size
7487 to <= INT_MAX.
7488
7489 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7490
7491 * xdisp.c (lookup_glyphless_char_display)
7492 (produce_glyphless_glyph): Handle cons cell entry in
7493 glyphless-char-display.
7494 (Vglyphless_char_display): Document it.
7495
7496 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7497 glyphless-char-display.
7498
7499 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7500
7501 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7502
7503 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7504
7505 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7506 definition for no-X builds.
7507
7508 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7509
7510 Static checks with GCC 4.6.0 and non-default toolkits.
7511
7512 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7513
7514 * process.c (keyboard_bit_set): Define only if SIGIO.
7515 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7516 (send_process): Repair possible setjmp clobbering.
7517
7518 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7519
7520 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7521
7522 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7523
7524 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7525 Define only if needed.
7526
7527 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7528 by pacifying GCC about it. Maybe it's time to retire it?
7529 * xfaces.c (USG, __TIMEVAL__): Likewise.
7530
7531 * dispextern.h (struct redisplay_interface): Rename param
7532 to avoid shadowing.
7533 * termhooks.h (struct terminal): Likewise.
7534 * xterm.c (xembed_send_message): Likewise.
7535
7536 * insdel.c (make_gap_smaller): Define only if
7537 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7538
7539 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7540 it.
7541
7542 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7543 so that we aren't warned about unused symbols.
7544
7545 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7546
7547 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7548
7549 * xfns.c (x_real_positions): Mark locals as initialized.
7550
7551 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7552
7553 * xterm.c: Fix problems found by static analysis with other toolkits.
7554 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7555 (x_dispatch_event): Declare static if USE_GTK, and
7556 define if USE_GTK || USE_X_TOOLKIT.
7557 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7558 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7559 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7560 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7561
7562 * xmenu.c (menu_help_callback): Pointer type fixes.
7563 Use const pointers when pointing at readonly data. Avoid pointer
7564 signedness clashes.
7565 (FALSE): Remove unused macro.
7566 (update_frame_menubar): Remove unused decl.
7567
7568 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7569
7570 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7571 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7572 (single_menu_item): Rename local to avoid shadowing.
7573
7574 * keyboard.c (make_lispy_event): Remove unused local var.
7575
7576 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7577 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7578
7579 * bitmaps: Change bitmaps from unsigned char back to the X11
7580 compatible char. Avoid the old compiler warnings about
7581 out-of-range initializers by using, for example, '\xab' rather
7582 than 0xab.
7583
7584 * xgselect.c (xgselect_initialize): Check vs interface
7585 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7586
7587 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7588
7589 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7590 to read-only memory.
7591
7592 * fns.c (vector): Remove; this old hack is no longer needed.
7593
7594 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7595 Remove unused var.
7596 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7597
7598 * xrdb.c (x_load_resources): Omit unused local.
7599
7600 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7601 (x_window): Rename locals to avoid shadowing.
7602 (USG): Use the kludged USG macro, to pacify gcc.
7603
7604 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7605 (x_term_init): Remove local to avoid shadowing.
7606
7607 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7608
7609 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7610 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7611
7612 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7613
7614 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7615
7616 Fix regex.c, syntax.c and friends for buffers > 2GB.
7617 * syntax.h (struct gl_state_s): Declare character position members
7618 EMACS_INT.
7619
7620 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7621
7622 * textprop.c (verify_interval_modification, interval_of):
7623 Declare arguments EMACS_INT.
7624
7625 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7626 EMACS_INT.
7627
7628 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7629
7630 * indent.c (Fvertical_motion): Local variable it_start is now
7631 EMACS_INT.
7632
7633 * regex.c (re_match, re_match_2, re_match_2_internal)
7634 (bcmp_translate, regcomp, regexec, print_double_string)
7635 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7636 (re_compile_pattern, re_exec): Declare arguments and local
7637 variables `size_t' and `ssize_t' and return values `regoff_t', as
7638 appropriate.
7639 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7640 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7641 <compile_stack_type>: `size' and `avail' are now `size_t'.
7642
7643 * regex.h <regoff_t>: Use ssize_t, not int.
7644 (re_search, re_search_2, re_match, re_match_2): Arguments that
7645 specify buffer/string position and length are now ssize_t and
7646 size_t. Return type is regoff_t.
7647
7648 2011-04-16 Ben Key <bkey76@gmail.com>
7649
7650 * nsfont.m: Fixed bugs in ns_get_family and
7651 ns_descriptor_to_entity that were caused by using free to
7652 deallocate memory blocks that were allocated by xmalloc (via
7653 xstrdup). This caused Emacs to crash when compiled with
7654 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7655 --enable-checking=xmallocoverrun). xfree is now used to
7656 deallocate these memory blocks.
7657
7658 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7659
7660 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7661
7662 emacs_write: Accept and return EMACS_INT for sizes.
7663 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7664 et seq.
7665 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7666 Accept and return EMACS_INT.
7667 (emacs_gnutls_write): Return the number of bytes written on
7668 partial writes.
7669 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7670 (emacs_read, emacs_write): Remove check for negative size, as the
7671 Emacs source code has been audited now.
7672 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7673 (emacs_read, emacs_write): Use it.
7674 * process.c (send_process): Adjust to the new signatures of
7675 emacs_write and emacs_gnutls_write. Do not attempt to store
7676 a byte offset into an 'int'; it might overflow.
7677 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7678
7679 * sound.c: Don't assume sizes fit in 'int'.
7680 (struct sound_device.period_size, alsa_period_size):
7681 Return EMACS_INT, not int.
7682 (struct sound_device.write, vox_write, alsa_write):
7683 Accept EMACS_INT, not int.
7684 (wav_play, au_play): Use EMACS_INT to store sizes and to
7685 record read return values.
7686
7687 2011-04-15 Ben Key <bkey76@gmail.com>
7688
7689 * keyboard.c (Qundefined): Don't declare static since it is used
7690 in nsfns.m.
7691 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7692 static since they are used in nsfont.m.
7693
7694 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7695
7696 * process.c (Qprocessp): Don't declare static.
7697 * lisp.h (Qprocessp): Declare again.
7698
7699 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7700
7701 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7702
7703 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7704
7705 Improve C-level modularity by making more things 'static'.
7706
7707 Don't publish debugger-only interfaces to other modules.
7708 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7709 (verify_bytepos, count_markers): Move decls to the only modules
7710 that need them.
7711 * region-cache.h (pp_cache): Likewise.
7712 * window.h (check_all_windows): Likewise.
7713 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7714
7715 * sysdep.c (croak): Now static, if
7716 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7717 * syssignal.h (croak): Declare only if not static.
7718
7719 * alloc.c (refill_memory_reserve): Now static if
7720 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7721 * lisp.h (refill_memory_reserve): Declare only if not static.
7722
7723 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7724 Define only if USE_LUCID.
7725
7726 * xrdb.c (x_customization_string, x_rm_string): Now static.
7727
7728 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7729 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7730
7731 * xdisp.c (draw_row_with_mouse_face): Now static.
7732 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7733
7734 * window.h (check_all_windows): Mark externally visible.
7735
7736 * window.c (window_deletion_count): Now static.
7737
7738 * undo.c: Make symbols static if they're not exported.
7739 (last_undo_buffer, last_boundary_position, pending_boundary):
7740 Now static.
7741
7742 * textprop.c (interval_insert_behind_hooks): Now static.
7743 (interval_insert_in_front_hooks): Likewise.
7744
7745 * term.c: Make symbols static if they're not exported.
7746 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7747 (max_frame_lines, tty_set_terminal_modes):
7748 (tty_reset_terminal_modes, tty_turn_off_highlight):
7749 (get_tty_terminal): Now static.
7750 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7751 * termhooks.h (term_mouse_moveto): Do not declare if
7752 HAVE_WINDOW_SYSTEM.
7753 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7754 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7755
7756 * sysdep.c: Make symbols static if they're not exported.
7757 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7758 Now static.
7759 (sigprocmask_set, full_mask): Remove; unused.
7760 (wait_debugging): Mark as visible.
7761 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7762 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7763
7764 * syntax.c (syntax_temp): Define only if !__GNUC__.
7765
7766 * sound.c (current_sound_device, current_sound): Now static.
7767
7768 * search.c (searchbufs, searchbuf_head): Now static.
7769
7770 * scroll.c (scroll_cost): Remove; unused.
7771 * dispextern.h (scroll_cost): Remove decl.
7772
7773 * region-cache.h (pp_cache): Mark as externally visible.
7774
7775 * process.c: Make symbols static if they're not exported.
7776 (process_tick, update_tick, create_process, chan_process):
7777 (Vprocess_alist, proc_buffered_char, datagram_access):
7778 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7779 (deactivate_process): Mark defn as static, as well as decl.
7780 * lisp.h (create_process): Remove decl.
7781 * process.h (chan_process, Vprocess_alist): Remove decls.
7782
7783 * print.c: Make symbols static if they're not exported.
7784 (print_depth, new_backquote_output, being_printed, print_buffer):
7785 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7786 (print_interval, print_number_index, initial_stderr_stream):
7787 Now static.
7788 * lisp.h (Fprinc): Remove decl.
7789 (debug_output_compilation_hack): Mark as externally visible.
7790
7791 * sysdep.c (croak): Move decl from here to syssignal.h.
7792 * syssignal.h (croak): Put it here, so the API can be checked when
7793 'croak' is called from dissociate_if_controlling_tty.
7794
7795 * minibuf.c: Make symbols static if they're not exported.
7796 (minibuf_save_list, choose_minibuf_frame): Now static.
7797 * lisp.h (choose_minibuf_frame): Remove decl.
7798
7799 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7800
7801 * lread.c: Make symbols static if they're not exported.
7802 (read_objects, initial_obarray, oblookup_last_bucket_number):
7803 Now static.
7804 (make_symbol): Remove; unused.
7805 * lisp.h (initial_obarray, make_symbol): Remove decls.
7806
7807 * keyboard.c: Make symbols static if they're not exported.
7808 (single_kboard, recent_keys_index, total_keys, recent_keys):
7809 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7810 (this_single_command_key_start, echoing, last_auto_save):
7811 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7812 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7813 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7814 (Vlispy_mouse_stem, double_click_count):
7815 Now static.
7816 (force_auto_save_soon): Define only if SIGDANGER.
7817 (ignore_mouse_drag_p): Now static if
7818 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7819 (print_help): Remove; unused.
7820 (stop_character, last_timer_event): Mark as externally visible.
7821 * keyboard.h (ignore_mouse_drag_p): Declare only if
7822 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7823 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7824 * lisp.h (echoing): Remove decl.
7825 (force_auto_save_soon): Declare only if SIGDANGER.
7826 * xdisp.c (redisplay_window): Simplify code, to make it more
7827 obvious that ignore_mouse_drag_p is not accessed if !defined
7828 USE_GTK && !defined HAVE_NS.
7829
7830 * intervals.c: Make symbols static if they're not exported.
7831 (merge_properties_sticky, merge_interval_right, delete_interval):
7832 Now static.
7833 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7834
7835 * insdel.c: Make symbols static if they're not exported.
7836 However, leave prepare_to_modify_buffer alone. It's never
7837 called from outside this function, but that appears to be a bug.
7838 (combine_after_change_list, combine_after_change_buffer):
7839 (adjust_after_replace, signal_before_change): Now static.
7840 (adjust_after_replace_noundo): Remove; unused.
7841 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7842 (signal_before_change): Remove decls.
7843
7844 * indent.c (val_compute_motion, val_vmotion): Now static.
7845
7846 * image.c: Make symbols static if they're not exported.
7847 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7848 if USE_GTK.
7849 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7850 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7851
7852 * fringe.c (standard_bitmaps): Now static.
7853 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7854
7855 * frame.c: Make symbols static if they're not exported.
7856 (x_report_frame_params, make_terminal_frame): Now static.
7857 (get_frame_param): Now static, unless HAVE_NS.
7858 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7859 (x_get_resource_string): Remove; not used.
7860 * frame.h (make_terminal_frame, x_report_frame_params):
7861 (x_get_resource_string); Remove decls.
7862 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7863 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7864
7865 * font.c, fontset.c: Make symbols static if they're not exported.
7866 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7867 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7868 * font.c (font_close_object): Now static.
7869 * font.h (font_close_object): Remove.
7870 * fontset.c (FONTSET_OBJLIST): Remove.
7871 (free_realized_fontset) #if-0 the body, which does nothing.
7872 (face_suitable_for_char_p): #if-0, as it's never called.
7873 * fontset.h (face_suitable_for_char_p): Remove decl.
7874 * xfaces.c (face_at_string_position):
7875 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7876 since 0 is always ASCII.
7877
7878 * fns.c (weak_hash_tables): Now static.
7879
7880 * fileio.c: Make symbols static if they're not exported.
7881 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7882 (Vwrite_region_annotation_buffers): Now static.
7883
7884 * eval.c: Make symbols static if they're not exported.
7885 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7886 * lisp.h (backtrace_list): Remove decl.
7887
7888 * emacs.c: Make symbols static if they're not exported.
7889 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7890 (fatal_error_code, fatal_error_signal_hook, standard_args):
7891 Now static.
7892 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7893 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7894 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7895 * lisp.h (fatal_error_signal_hook): Remove decl.
7896 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7897
7898 * editfns.c: Move a (normally-unused) function to its only use.
7899 * editfns.c, lisp.h (get_operating_system_release): Remove.
7900 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7901 worth the hassle of breaking this out.
7902
7903 * xterm.c: Make symbols static if they're not exported.
7904 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7905 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7906 (x_destroy_window, x_delete_display):
7907 Now static.
7908 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7909 (x_mouse_leave): Remove; unused.
7910 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7911 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7912 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7913 Remove decls.
7914 (x_mouse_leave): Declare only if WINDOWSNT.
7915 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7916 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7917 USE_X_TOOLKIT.
7918
7919 * ftxfont.c: Make symbols static if they're not exported.
7920 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7921 HAVE_FREETYPE.
7922 * font.h (ftxfont_driver): Likewise.
7923
7924 * xfns.c: Make symbols static if they're not exported.
7925 (x_last_font_name, x_display_info_for_name):
7926 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7927 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7928 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7929 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7930 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7931 (last_show_tip_args): Now static.
7932 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7933 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7934 (x_screen_planes): Remove; unused.
7935 * dispextern.h (x_screen_planes): Remove decl.
7936
7937 * dispnew.c: Make symbols static if they're not exported.
7938 * dispextern.h (redraw_garbaged_frames, scrolling):
7939 (increment_row_positions): Remove.
7940 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7941 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7942 Now static.
7943 (redraw_garbaged_frames): Remove; unused.
7944
7945 * xfaces.c: Make symbols static if they're not exported.
7946 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7947 Remove decls.
7948 * xterm.h (defined_color): Remove decls.
7949 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7950 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7951 (menu_face_changed_default, defined_color, free_realized_face):
7952 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7953 (ascii_face_of_lisp_face): Remove; unused.
7954
7955 * xdisp.c: Make symbols static if they're not exported.
7956 * dispextern.h (scratch_glyph_row, window_box_edges):
7957 (glyph_to_pixel_coords, set_cursor_from_row):
7958 (get_next_display_element, set_iterator_to_next):
7959 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7960 (show_mouse_face): Remove decls
7961 * frame.h (message_buf_print): Likewise.
7962 * lisp.h (pop_message, set_message, check_point_in_composition):
7963 Likewise.
7964 * xterm.h (set_vertical_scroll_bar): Likewise.
7965 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7966 (message_buf_print, scratch_glyph_row, displayed_buffer):
7967 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7968 (get_next_display_element, show_mouse_face, window_box_edges):
7969 (frame_to_window_pixel_xy, check_point_in_composition):
7970 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7971 (glyph_to_pixel_coords): Remove; unused.
7972
7973 * dired.c (file_name_completion): Now static.
7974
7975 * dbusbind.c (xd_in_read_queued_messages): Now static.
7976
7977 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7978 * data.c (circular_list_error): Remove.
7979
7980 * commands.h (last_point_position, last_point_position_buffer):
7981 (last_point_position_window): Remove decls.
7982 * keyboard.c: Make these variables static.
7983
7984 * coding.h (coding, code_convert_region, encode_coding_gap):
7985 Remove decls.
7986 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7987 (iso_code_class, detect_coding, code_convert_region): Now static.
7988 (encode_coding_gap): Remove; unused.
7989
7990 * chartab.c (chartab_chars, chartab_bits): Now static.
7991
7992 * charset.h (charset_iso_8859_1): Remove decl.
7993 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7994 Now static.
7995
7996 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7997 * ccl.c (Vccl_program_table): Now static.
7998 (check_ccl_update): Remove; unused.
7999
8000 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8001 * category.h: ... from here.
8002 * category.c (check_category_table, set_category_set): Now static.
8003
8004 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8005 * lisp.h: Remove these decls.
8006
8007 * buffer.c (buffer_count): Remove unused var.
8008
8009 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8010 so that it's not optimized away.
8011 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8012 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8013 exported only to the debugger.
8014
8015 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8016 * atimer.h (run_all_atimers): Remove; not exported.
8017
8018 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8019 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8020 was inaccessible from Lisp.
8021 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8022 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8023
8024 alloc.c: Import and export fewer symbols, and remove unused items.
8025 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8026 is defined.
8027 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8028 it's not optimized away by whole-program optimization.
8029 (message_enable_multibyte, free_misc): Remove.
8030 (catchlist, handlerlist, mark_backtrace):
8031 Declare only if BYTE_MARK_STACK.
8032 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8033 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8034 (message_enable_multibyte): Remove decl.
8035 (free_misc, interval_free_list, float_block, float_block_index):
8036 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8037 (cons_free_list, last_marked_index):
8038 Now static.
8039 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8040 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8041 (mark_backtrace): Define only if BYTE_MARK_STACK.
8042 * xdisp.c (message_enable_multibyte): Now static.
8043
8044 Declare Lisp_Object Q* variables to be 'static' if not exported.
8045 This makes it easier for human readers (and static analyzers)
8046 to see whether these variables are used from other modules.
8047 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8048 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8049 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8050 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8051 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8052 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8053 * xmenu.c, xselect.c:
8054 Declare Q* vars static if they are not used in other modules.
8055 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8056 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8057 Remove decls of unexported vars.
8058 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8059
8060 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8061
8062 Make Emacs functions such as Fatom 'static' by default.
8063 This makes it easier for human readers (and static analyzers)
8064 to see whether these functions can be called from other modules.
8065 DEFUN now defines a static function. To make the function external
8066 so that it can be used in other C modules, use the new macro DEFUE.
8067 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8068 (Finit_image_library):
8069 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8070 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8071 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8072 Remove decls, since these functions are now static.
8073 (Funintern, Fget_internal_run_time): New decls, since these functions
8074 were already external.
8075
8076 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8077 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8078 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8079 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8080 * keyboard.c, keymap.c, lread.c:
8081 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8082 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8083 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8084 Mark functions with DEFUE instead of DEFUN,
8085 if they are used in other modules.
8086 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8087 decls for now-static functions.
8088 * buffer.h (Fdelete_overlay): Remove decl.
8089 * callproc.c (Fgetenv_internal): Mark as internal.
8090 * composite.c (Fremove_list_of_text_properties): Remove decl.
8091 (Fcomposition_get_gstring): New forward static decl.
8092 * composite.h (Fcomposite_get_gstring): Remove decl.
8093 * dired.c (Ffile_attributes): New forward static decl.
8094 * doc.c (Fdocumntation_property): New forward static decl.
8095 * eval.c (Ffetch_bytecode): New forward static decl.
8096 (Funintern): Remove extern decl; now in .h file where it belongs.
8097 * fileio.c (Fmake_symbolic_link): New forward static decl.
8098 * image.c (Finit_image_library): New forward static decl.
8099 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8100 * intervals.h (Fprevious_property_change):
8101 (Fremove_list_of_text_properties): Remove decls.
8102 * keyboard.c (Fthis_command_keys): Remove decl.
8103 (Fcommand_execute): New forward static decl.
8104 * keymap.c (Flookup_key): New forward static decl.
8105 (Fcopy_keymap): Now static.
8106 * keymap.h (Flookup_key): Remove decl.
8107 * process.c (Fget_process): New forward static decl.
8108 (Fprocess_datagram_address): Mark as internal.
8109 * syntax.c (Fsyntax_table_p): New forward static decl.
8110 (skip_chars): Remove duplicate decl.
8111 * textprop.c (Fprevious_property_change): New forward static decl.
8112 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8113 Now internal.
8114 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8115 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8116
8117 * editfns.c (Fformat): Remove unreachable code.
8118
8119 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8120
8121 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8122 change. (Bug#8496)
8123
8124 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8125
8126 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8127 when at ZV. (Bug#8487)
8128
8129 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8130
8131 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8132 (Bug#8437)
8133 * keyboard.c (parse_tool_bar_item): Likewise.
8134 * sound.c (sound_cleanup, alsa_close): Likewise.
8135 * termcap.c (tgetent): Likewise.
8136 * xfns.c (x_default_font_parameter): Likewise.
8137 * xsettings.c (read_and_apply_settings): Likewise.
8138
8139 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8140 (overrun_check_free): Protoize.
8141
8142 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8143
8144 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8145 since callers should never pass a negative size.
8146 Change the signature to match that of plain 'read' and 'write'; see
8147 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8148 * lisp.h: Update prototypes of emacs_write and emacs_read.
8149
8150 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8151
8152 * xdisp.c (redisplay_window): Don't try to determine the character
8153 position of the scroll margin if the window start point w->startp
8154 is outside the buffer's accessible region. (Bug#8468)
8155
8156 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8157
8158 Fix write-region and its subroutines for buffers > 2GB.
8159 * fileio.c (a_write, e_write): Modify declaration of arguments and
8160 local variables to support buffers larger than 2GB.
8161 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8162
8163 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8164 argument, local variables, and return value.
8165
8166 * lisp.h: Update prototypes of emacs_write and emacs_read.
8167
8168 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8169
8170 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8171
8172 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8173
8174 Fix more problems found by GCC 4.6.0's static checks.
8175
8176 * xdisp.c (vmessage): Use a better test for character truncation.
8177
8178 * charset.c (load_charset_map): <, not <=, for optimization,
8179 and to avoid potential problems with integer overflow.
8180 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8181 * casetab.c (set_identity, shuffle): Likewise.
8182 * editfns.c (Fformat): Likewise.
8183 * syntax.c (skip_chars): Likewise.
8184
8185 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8186 This also lets GCC 4.6.0 generate slightly better loop code.
8187
8188 * callint.c (Fcall_interactively): <, not <=, for optimization.
8189 (Fcall_interactively): Count the number of arguments produced,
8190 not the number of arguments given. This is simpler and lets GCC
8191 4.6.0 generate slightly better code.
8192
8193 * ftfont.c: Distingish more carefully between FcChar8 and char.
8194 The previous code passed unsigned char * to a functions like
8195 strlen and xstrcasecmp that expect char *, which does not
8196 conform to the C standard.
8197 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8198 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8199 char * when the C standard requires it.
8200
8201 * keyboard.c (read_char): Remove unused var.
8202
8203 * eval.c: Port to Windows vsnprintf (Bug#8435).
8204 Include <limits.h>.
8205 (SIZE_MAX): Define if the headers do not.
8206 (verror): Do not give up if vsnprintf returns a negative count.
8207 Instead, grow the buffer. This ports to Windows vsnprintf, which
8208 does not conform to C99. Problem reported by Eli Zaretskii.
8209 Also, simplify the allocation scheme, by avoiding the need for
8210 calling realloc, and removing the ALLOCATED variable.
8211
8212 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8213
8214 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8215 But keep the doprint source code for now, as we might revamp it
8216 and use it again (Bug#8435).
8217 * lisp.h (doprnt): Remove.
8218 * Makefile.in (base_obj): Remove doprnt.o.
8219 * deps.mk (doprnt.o): Remove.
8220
8221 error: Print 32- and 64-bit integers portably (Bug#8435).
8222 Without this change, on typical 64-bit hosts error ("...%d...", N)
8223 was used to print both 32- and 64-bit integers N, which relied on
8224 undefined behavior.
8225 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8226 * lisp.h (error, verror): Mark as printf-like functions.
8227 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8228 Report overflow in size calculations when allocating printf buffer.
8229 Do not truncate output string at its first null byte.
8230 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8231 Truncate the output at a character boundary, since vsnprintf does not
8232 do that.
8233 * charset.c (check_iso_charset_parameter): Convert internal
8234 character to string before calling 'error', since %c now has the
8235 printf meaning.
8236 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8237 overflow when computing char to be passed to 'error'. Do not
8238 pass Lisp_Object to 'error'; pass the integer instead.
8239 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8240 formatted with plain %d.
8241
8242 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8243
8244 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8245
8246 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8247
8248 * xterm.c (x_catch_errors): Remove duplicate declaration.
8249
8250 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8251
8252 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8253
8254 2011-04-10 Jim Meyering <meyering@redhat.com>
8255
8256 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8257 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8258 return ssize_t not "int", and use size_t as the buffer length.
8259 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8260 * gnutls.h: Update declarations.
8261 * process.c (read_process_output): Use ssize_t, to match.
8262 (send_process): Likewise.
8263
8264 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8265
8266 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8267
8268 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8269
8270 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8271 Use unsigned char, to match FcChar8 type definition.
8272
8273 * xterm.c (handle_one_xevent):
8274 * xmenu.c (create_and_show_popup_menu):
8275 * xselect.c (x_decline_selection_request)
8276 (x_reply_selection_request): Avoid type-punned deref of X events.
8277
8278 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8279
8280 Fix some uses of `int' instead of EMACS_INT.
8281 * search.c (string_match_1, fast_string_match)
8282 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8283 (scan_buffer, find_next_newline_no_quit)
8284 (find_before_next_newline, search_command, Freplace_match)
8285 (Fmatch_data): Make some `int' variables be EMACS_INT.
8286
8287 * xdisp.c (display_count_lines): 3rd argument and return value now
8288 EMACS_INT. All callers changed.
8289 (pint2hrstr): Last argument is now EMACS_INT.
8290
8291 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8292 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8293 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8294 (decode_coding_utf_16, decode_coding_emacs_mule)
8295 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8296 (decode_coding_ccl, decode_coding_charset)
8297 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8298 (decode_coding_iso_2022, decode_coding_emacs_mule)
8299 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8300 <char_offset, last_offset>: Declare EMACS_INT.
8301 (encode_coding_utf_8, encode_coding_utf_16)
8302 (encode_coding_emacs_mule, encode_invocation_designation)
8303 (encode_designation_at_bol, encode_coding_iso_2022)
8304 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8305 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8306 Declare EMACS_INT.
8307 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8308 (encode_invocation_designation): Last argument P_NCHARS is now
8309 EMACS_INT.
8310 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8311 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8312
8313 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8314 All users changed.
8315
8316 * ccl.c (Fccl_execute_on_string): Declare some variables
8317 EMACS_INT.
8318
8319 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8320
8321 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8322
8323 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8324
8325 * process.c (Fformat_network_address): Doc fix.
8326
8327 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8328
8329 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8330
8331 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8332
8333 * keyboard.c (read_char): Call Lisp function help-form-show,
8334 instead of using internal_with_output_to_temp_buffer.
8335 (Qhelp_form_show): New var.
8336 (syms_of_keyboard): Use DEFSYM macro.
8337
8338 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8339
8340 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8341
8342 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8343
8344 * process.c (Flist_processes): Remove to Lisp.
8345 (list_processes_1): Delete.
8346
8347 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8348
8349 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8350
8351 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8352
8353 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8354
8355 Fix more problems found by GCC 4.6.0's static checks.
8356
8357 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8358
8359 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8360
8361 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8362
8363 * xdisp.c (vmessage): Mark as a printf-like function.
8364
8365 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8366
8367 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8368
8369 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8370 printf-like functions.
8371 (tiff_load): Add casts to remove these marks before passing them
8372 to system-supplied API.
8373
8374 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8375
8376 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8377 This avoids several warnings with gcc -Wstrict-overflow.
8378 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8379 directly, rather than having caller test rule sign. This avoids
8380 some unnecessary tests.
8381 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8382 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8383 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8384
8385 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8386 (xfont_open): Avoid unnecessary tests.
8387
8388 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8389
8390 * composite.h, composite.c (composition_gstring_put_cache):
8391 Use EMACS_INT, not int, for length.
8392
8393 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8394 breaking out part of COMPOSITION_DECODE_RULE.
8395 (COMPOSITION_DECODE_RULE): Use it.
8396 * composite.c (get_composition_id): Remove unused local vars,
8397 by using the new macro.
8398
8399 * textprop.c (set_text_properties_1): Change while to do-while,
8400 since the condition is always true at first.
8401
8402 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8403 (interval_deletion_adjustment): Return unsigned value.
8404 All uses changed.
8405
8406 * process.c (list_processes_1, create_pty, read_process_output):
8407 (exec_sentinel): Remove vars that were set but not used.
8408 (create_pty): Remove unnecessary "volatile"s.
8409 (Fnetwork_interface_info): Avoid possibility of int overflow.
8410 (read_process_output): Do adaptive read buffering even if carryover.
8411 (read_process_output): Simplify nbytes computation if buffered.
8412
8413 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8414
8415 * syntax.c (scan_words): Remove var that was set but not used.
8416 (update_syntax_table): Use unsigned instead of int.
8417
8418 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8419 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8420 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8421
8422 * print.c (print_error_message): Avoid int overflow.
8423
8424 * font.c (font_list_entities): Redo for clarity,
8425 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8426
8427 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8428 (font_score): Avoid potential overflow in diff calculation.
8429
8430 * fns.c (substring_both): Remove var that is set but not used.
8431 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8432
8433 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8434
8435 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8436 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8437 can always succeed if overflow has undefined behavior.
8438
8439 * search.c (boyer_moore, wordify): Remove vars set but not used.
8440 (wordify): Omit three unnecessary tests.
8441
8442 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8443 All callers changed. This avoids the need for an unused var.
8444
8445 * casefiddle.c (casify_region): Remove var that is set but not used.
8446
8447 * dired.c (file_name_completion): Remove var that is set but not used.
8448
8449 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8450
8451 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8452 (Finsert_file_contents): Remove unnecessary code checking fd.
8453
8454 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8455 Check for integer overflow on size calculations.
8456
8457 * buffer.c (Fprevious_overlay_change): Remove var that is set
8458 but not used.
8459
8460 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8461 Remove vars that are set but not used.
8462 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8463 (timer_check_2): Mark vars as initialized.
8464
8465 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8466
8467 * image.c (lookup_image): Remove var that is set but not used.
8468 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8469
8470 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8471 that are set but not used.
8472
8473 * xfns.c (make_invisible_cursor): Don't return garbage
8474 if XCreateBitmapFromData fails (Bug#8410).
8475
8476 * xselect.c (x_get_local_selection, x_handle_property_notify):
8477 Remove vars that are set but not used.
8478
8479 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8480 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8481
8482 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8483 Remove var that is set but not used.
8484 (scroll_bar_windows_size): Now size_t, not int.
8485 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8486 Check for overflow.
8487
8488 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8489 (map_tty_color) [!defined MSDOS]: Likewise.
8490
8491 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8492
8493 * coding.c: Remove vars that are set but not used.
8494 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8495 All callers changed.
8496 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8497 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8498 (decode_coding_charset): Remove vars that are set but not used.
8499
8500 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8501 that is set but not used.
8502
8503 * print.c (print_object): Remove var that is set but not used.
8504
8505 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8506 The gnulib version avoids calling malloc in the usual case,
8507 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8508 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8509 * filelock.c (current_lock_owner): Likewise.
8510 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8511 * sysdep.c: Include allocator.h, careadlinkat.h.
8512 (emacs_no_realloc_allocator): New static constant.
8513 (emacs_readlink): New function.
8514 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8515 ../lib/careadlinkat.h.
8516
8517 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8518
8519 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8520 first non-nil return value).
8521
8522 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8523
8524 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8525 if not defined (Bug#8403).
8526
8527 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8528
8529 * xdisp.c (display_count_lines): Remove parameter `start',
8530 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8531 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8532 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8533 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8534 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8535 and thereabouts. All callers changed.
8536 (get_per_char_metric): Remove parameter `f', unused since
8537 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8538
8539 2011-04-02 Jim Meyering <meyering@redhat.com>
8540
8541 do not dereference NULL upon failed strdup
8542 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8543 (ns_get_family): Likewise.
8544
8545 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8546
8547 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8548
8549 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8550
8551 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8552 later (Bug#8403).
8553
8554 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8555
8556 Add lexical binding.
8557
8558 * window.c (Ftemp_output_buffer_show): New fun.
8559 (Fsave_window_excursion):
8560 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8561
8562 * lread.c (lisp_file_lexically_bound_p): New function.
8563 (Fload): Bind Qlexical_binding.
8564 (readevalloop): Remove `evalfun' arg.
8565 Bind Qinternal_interpreter_environment.
8566 (Feval_buffer): Bind Qlexical_binding.
8567 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8568 Mark as dynamic.
8569 (syms_of_lread): Declare `lexical-binding'.
8570
8571 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8572
8573 * keyboard.c (eval_dyn): New fun.
8574 (menu_item_eval_property): Use it.
8575
8576 * image.c (parse_image_spec): Use Ffunctionp.
8577
8578 * fns.c (concat, mapcar1): Accept byte-code-functions.
8579
8580 * eval.c (Fsetq): Handle lexical vars.
8581 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8582 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8583 (FletX, Flet): Obey lexical binding.
8584 (Fcommandp): Handle closures.
8585 (Feval): New `lexical' arg.
8586 (eval_sub): New function extracted from Feval. Use it almost
8587 everywhere where Feval was used. Look up vars in lexical env.
8588 Handle closures.
8589 (Ffunctionp): Move from subr.el.
8590 (Ffuncall): Handle closures.
8591 (apply_lambda): Remove `eval_flags'.
8592 (funcall_lambda): Handle closures and new byte-code-functions.
8593 (Fspecial_variable_p): New function.
8594 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8595 but without exporting it to Lisp.
8596
8597 * doc.c (Fdocumentation, store_function_docstring):
8598 * data.c (Finteractive_form): Handle closures.
8599
8600 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8601 interactive spec.
8602
8603 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8604 New byte-codes.
8605 (exec_byte_code): New function extracted from Fbyte_code to handle new
8606 calling convention for byte-code-functions. Add new byte-codes.
8607
8608 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8609
8610 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8611
8612 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8613
8614 * xdisp.c (redisplay_internal): Fix prototype.
8615
8616 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8617
8618 * xdisp.c (SCROLL_LIMIT): New macro.
8619 (try_scrolling): Use it when setting scroll_limit.
8620 Limit scrolling to 100 screen lines.
8621 (redisplay_window): Even when falling back on "recentering",
8622 position point in the window according to scroll-conservatively,
8623 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8624
8625 (try_scrolling): When point is above the window, allow searching
8626 as far as scroll_max, or one screenful, to compute vertical
8627 distance from PT to the scroll margin position. This prevents
8628 try_scrolling from unnecessarily failing when
8629 scroll-conservatively is set to a value slightly larger than the
8630 window height. Clean up the case of PT below the margin at bottom
8631 of window: scroll_max can no longer be INT_MAX. When aggressive
8632 scrolling is in use, don't let point enter the opposite scroll
8633 margin as result of the scroll.
8634 (syms_of_xdisp) <scroll-conservatively>: Document the
8635 threshold of 100 lines for never-recentering scrolling.
8636
8637 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8638
8639 * dispextern.h (move_it_by_lines):
8640 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8641 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8642 (message_log_check_duplicate): Remove parameters `prev_bol' and
8643 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8644 (redisplay_internal): Remove parameter `preserve_echo_area',
8645 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8646
8647 * indent.c (Fvertical_motion):
8648 * window.c (window_scroll_pixel_based, Frecenter):
8649 Don't pass `need_y_p' to `move_it_by_lines'.
8650
8651 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8652
8653 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8654 steal a few bits to be more compact.
8655 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8656 Remove unneeded casts.
8657
8658 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8659
8660 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8661
8662 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8663 binding" message (bug#7967).
8664
8665 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8666
8667 Fix more problems found by GCC 4.6.0's static checks.
8668
8669 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8670 Remove unused local var.
8671
8672 * editfns.c (Fmessage_box): Remove unused local var.
8673
8674 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8675 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8676 Omit unused local vars.
8677 * window.c (shrink_windows): Omit unused local var.
8678 * menu.c (digest_single_submenu): Omit unused local var.
8679 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8680 Omit unused local var.
8681
8682 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8683 Don't assume string length fits in int.
8684 (keyremap_step, read_key_sequence): Use size_t for sizes.
8685 (read_key_sequence): Don't check last_real_key_start redundantly.
8686
8687 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8688 instead of alloca (Bug#8344).
8689
8690 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8691 (Fbacktrace_frame): Don't assume nframes fits in int.
8692
8693 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8694
8695 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8696 concerns.
8697
8698 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8699
8700 * cm.c (calccost): Turn while-do into do-while, for clarity.
8701
8702 * keyboard.c (syms_of_keyboard): Use the same style as later
8703 in this function when indexing through an array. This also
8704 works around GCC bug 48267.
8705
8706 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8707
8708 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8709
8710 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8711 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8712
8713 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8714 This avoids undefined behavior on integer overflow, and is a bit
8715 more convenient anyway since it is compared to a size_t variable.
8716
8717 Variadic C functions now count arguments with size_t, not int.
8718 This avoids an unnecessary limitation on 64-bit machines, which
8719 caused (substring ...) to crash on large vectors (Bug#8344).
8720 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8721 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8722 All variadic functions and their callers changed accordingly.
8723 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8724 * data.c (arith_driver, float_arith_driver): Likewise.
8725 * editfns.c (general_insert_function): Likewise.
8726 * eval.c (struct backtrace.nargs, interactive_p)
8727 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8728 (funcall_lambda, mark_backtrace): Likewise.
8729 * fns.c (concat): Likewise.
8730 * frame.c (x_set_frame_parameters): Likewise.
8731 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8732 0 if not found, not -1. All callers changed.
8733
8734 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8735 (stack_copy_size): Now size_t, not int.
8736 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8737
8738 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8739
8740 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8741 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8742 All callers changed.
8743
8744 * lisp.h (multibyte_char_to_unibyte):
8745 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8746 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8747 * character.h (CHAR_TO_BYTE8):
8748 * cmds.c (internal_self_insert):
8749 * editfns.c (general_insert_function):
8750 * keymap.c (push_key_description):
8751 * search.c (Freplace_match):
8752 * xdisp.c (message_dolog, set_message_1): All callers changed.
8753
8754 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8755
8756 * keyboard.c (safe_run_hook_funcall): New function.
8757 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8758 don't set the hook to nil, but remove the offending function instead.
8759 (Qcommand_hook_internal): Remove, unused.
8760 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8761 Vcommand_hook_internal.
8762
8763 * eval.c (enum run_hooks_condition): Remove.
8764 (funcall_nil, funcall_not): New functions.
8765 (run_hook_with_args): Call each function through a `funcall' argument.
8766 Remove `cond' argument, now redundant.
8767 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8768 (Frun_hook_with_args_until_failure): Adjust accordingly.
8769 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8770
8771 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8772
8773 * dispextern.h (string_buffer_position): Remove declaration.
8774
8775 * print.c (strout): Remove parameter `multibyte', unused since
8776 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8777
8778 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8779 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8780 All callers changed.
8781
8782 * w32.c (_wsa_errlist): Use braces for struct initializers.
8783
8784 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8785 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8786 All callers changed.
8787 (string_buffer_position): Likewise. Also, make static (it's never
8788 used outside xdisp.c).
8789 (cursor_row_p): Remove parameter `w', unused since
8790 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8791 (decode_mode_spec): Remove parameter `precision', introduced during
8792 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8793 All callers changed.
8794
8795 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8796
8797 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8798
8799 2011-03-27 Anders Lindgren <andlind@gmail.com>
8800
8801 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8802 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8803 (ns_update_auto_hide_menu_bar): New functions.
8804 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8805 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8806 ns_constrain_all_frames.
8807 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8808 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8809
8810 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8811
8812 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8813
8814 2011-03-27 Glenn Morris <rgm@gnu.org>
8815
8816 * syssignal.h: Replace RETSIGTYPE with void.
8817 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8818 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8819 Replace SIGTYPE with void everywhere.
8820 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8821 * s/template.h (SIGTYPE): Remove commented out definition.
8822
8823 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8824
8825 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8826 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8827
8828 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8829
8830 * w32.c (read_unc_volume): Use parameter `henum', instead of
8831 global variable `wget_enum_handle'.
8832
8833 * keymap.c (describe_vector): Remove parameters `indices' and
8834 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8835 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8836
8837 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8838
8839 * keyboard.c (timer_check): Remove parameter `do_it_now',
8840 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8841 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8842 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8843
8844 * keyboard.c (read_char):
8845 * w32menu.c (w32_menu_display_help):
8846 * xmenu.c (show_help_event, menu_help_callback):
8847 Adjust calls to `show_help_echo'.
8848
8849 * gtkutil.c (xg_maybe_add_timer):
8850 * keyboard.c (readable_events):
8851 * process.c (wait_reading_process_output):
8852 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8853
8854 * insdel.c (adjust_markers_gap_motion):
8855 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8856 (gap_left, gap_right): Don't call it.
8857
8858 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8859
8860 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8861 incurred during fontification.
8862
8863 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8864
8865 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8866 (DEFVAR_PER_BUFFER): Don't pass it.
8867
8868 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8869 (scrolling_window): Don't pass it.
8870
8871 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8872
8873 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8874
8875 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8876 and `suffix'.
8877 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8878 of variables specific to SELinux and computation of `encoded_absname'.
8879
8880 * image.c (XPutPixel): Remove unused variable `height'.
8881
8882 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8883
8884 * unexw32.c (get_section_info): Remove unused variable `section'.
8885
8886 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8887 (system_process_attributes): Remove unused variable `sess'.
8888 (sys_read): Remove unused variable `err'.
8889
8890 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8891 (w32_wnd_proc): Remove unused variable `isdead'.
8892 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8893 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8894 (x_create_tip_frame): Remove unused variable `tem'.
8895
8896 * w32inevt.c (w32_console_read_socket):
8897 Remove unused variable `no_events'.
8898
8899 * w32term.c (x_draw_composite_glyph_string_foreground):
8900 Remove unused variable `width'.
8901
8902 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8903
8904 * w32term.c (x_set_glyph_string_clipping):
8905 Don't pass uninitialized region to CombineRgn.
8906
8907 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8908
8909 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8910 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8911 (Fx_close_connection): Remove unused variable `i'.
8912
8913 * w32font.c (w32font_draw): Return number of glyphs.
8914 (w32font_open_internal): Remove unused variable `i'.
8915 (w32font_driver): Add missing initializer.
8916
8917 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8918 (fill_in_menu): Remove unused variable `items_added'.
8919
8920 * w32term.c (last_mouse_press_frame): Remove static global variable.
8921 (w32_clip_to_row): Remove unused variable `f'.
8922 (x_delete_terminal): Remove unused variable `i'.
8923
8924 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8925 (NOTHING): Remove unused static global variable.
8926 (uniscribe_check_otf): Remove unused variable `table'.
8927 (uniscribe_font_driver): Add missing initializers.
8928
8929 2011-03-23 Julien Danjou <julien@danjou.info>
8930
8931 * term.c (Fsuspend_tty, Fresume_tty):
8932 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8933 * window.c (temp_output_buffer_show):
8934 * insdel.c (signal_before_change):
8935 * frame.c (Fhandle_switch_frame):
8936 * fileio.c (Fdo_auto_save):
8937 * emacs.c (Fkill_emacs):
8938 * editfns.c (save_excursion_restore):
8939 * cmds.c (internal_self_insert):
8940 * callint.c (Fcall_interactively):
8941 * buffer.c (Fkill_all_local_variables):
8942 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8943 Use Frun_hooks.
8944 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8945 unconditionally since it does the check itself.
8946
8947 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8948
8949 Fix more problems found by GCC 4.5.2's static checks.
8950
8951 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8952 the first time through the loop, since we know p0 < p1 then.
8953 This also avoids a gcc -Wstrict-overflow warning.
8954
8955 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8956 leading to a memory leak, possible in functions like
8957 load_charset_map_from_file that can allocate an unbounded number
8958 of objects (Bug#8318).
8959
8960 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8961 that could (at least in theory) be that large.
8962
8963 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8964 This is less likely to overflow, and avoids undefined behavior if
8965 overflow does occur. All callers changed. Use strtoul to scan
8966 for the unsigned long integer.
8967 (pint2hrstr): Simplify and tune code slightly.
8968 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8969
8970 * scroll.c (do_scrolling): Work around GCC bug 48228.
8971 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8972
8973 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8974 This also avoids a warning with gcc -Wstrict-overflow.
8975 (validate_x_resource_name): Simplify count usage.
8976 This also avoids a warning with gcc -Wstrict-overflow.
8977
8978 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8979 fail (Bug#8306).
8980
8981 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8982
8983 * process.c (Fmake_network_process): Use socklen_t, not int,
8984 where POSIX says socklen_t is required in portable programs.
8985 This fixes a porting bug on hosts like 64-bit HP-UX, where
8986 socklen_t is wider than int (Bug#8277).
8987 (Fmake_network_process, server_accept_connection):
8988 (wait_reading_process_output, read_process_output):
8989 Likewise.
8990
8991 * process.c: Rename or move locals to avoid shadowing.
8992 (list_processes_1, Fmake_network_process):
8993 (read_process_output_error_handler, exec_sentinel_error_handler):
8994 Rename or move locals.
8995 (Fmake_network_process): Define label "retry_connect" only if needed.
8996 (Fnetwork_interface_info): Fix pointer signedness.
8997 (process_send_signal): Add cast to avoid pointer signedness problem.
8998 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8999 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9000
9001 Make tparam.h and terminfo.c consistent.
9002 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9003 Include tparam.h instead, since it declares them.
9004 * cm.h (PC): Remove extern decl; tparam.h now does this.
9005 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9006 * terminfo.c: Include tparam.h, to check interfaces.
9007 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9008 (tparam): Adjust signature to match interface in tparam.h;
9009 this removes some undefined behavior. Check that outstring and len
9010 are zero, which they always are with Emacs.
9011 * tparam.h (PC, BC, UP): New extern decls.
9012
9013 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9014 (xftfont_open): Rename locals to avoid shadowing.
9015
9016 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9017 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9018 (OTF_TAG_SYM): Omit macro if not needed.
9019 (ftfont_list): Remove unused local.
9020 (get_adstyle_property, ftfont_pattern_entity):
9021 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9022 Rename locals to avoid shadowing.
9023
9024 * xfont.c (xfont_list_family): Mark var as initialized.
9025
9026 * xml.c (make_dom): Now static.
9027
9028 * composite.c (composition_compute_stop_pos): Rename local to
9029 avoid shadowing.
9030 (composition_reseat_it): Remove unused locals.
9031 (find_automatic_composition, composition_adjust_point): Likewise.
9032 (composition_update_it): Mark var as initialized.
9033 (find_automatic_composition): Mark vars as initialized,
9034 with a FIXME (Bug#8290).
9035
9036 character.h: Rename locals to avoid shadowing.
9037 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9038 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9039 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9040 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9041 to avoid shadowing.
9042
9043 * textprop.c (property_change_between_p): Remove; unused.
9044
9045 * intervals.c (interval_start_pos): Now static.
9046
9047 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9048
9049 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9050 Rename locals to avoid shadowing.
9051
9052 * sound.c (wav_play, au_play, Fplay_sound_internal):
9053 Fix pointer signedness.
9054 (alsa_choose_format): Remove unused local var.
9055 (wav_play): Initialize a variable to 0, to prevent undefined
9056 behavior (Bug#8278).
9057
9058 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9059
9060 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9061
9062 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9063 clobbering (Bug#8298).
9064 * sysdep.c (sys_subshell): Likewise.
9065 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9066
9067 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9068 This should get cleaned up, so that child_setup has the
9069 same signature on all platforms.
9070
9071 * callproc.c (call_process_cleanup): Now static.
9072 (relocate_fd): Rename locals to avoid shadowing.
9073
9074 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9075
9076 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9077 not to be necessary, and produces flickering.
9078
9079 2011-03-20 Glenn Morris <rgm@gnu.org>
9080
9081 * config.in: Remove file.
9082
9083 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9084
9085 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9086 are now in src/globals.h.
9087 (syms_of_minibuf): Remove spurious & from previous change.
9088
9089 2011-03-20 Leo Liu <sdl.web@gmail.com>
9090
9091 * minibuf.c (completing-read-function): New variable.
9092 (completing-read-default): Rename from completing-read.
9093 (completing-read): Call completing-read-function.
9094
9095 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9096
9097 * xfaces.c (Fx_load_color_file):
9098 Read color file from absolute filename (bug#8250).
9099
9100 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9101
9102 * makefile.w32-in: Update dependencies.
9103
9104 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9105
9106 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9107
9108 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9109
9110 Fix more problems found by GCC 4.5.2's static checks.
9111
9112 * process.c (make_serial_process_unwind, send_process_trap):
9113 (sigchld_handler): Now static.
9114
9115 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9116 That way, the code declares only the vars that it needs.
9117 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9118 * s/cygwin.h (PTY_ITERATION): Likewise.
9119 * s/darwin.h (PTY_ITERATION): Likewise.
9120 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9121
9122 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9123 * process.c (allocate_pty): Don't declare stb unless it's needed.
9124
9125 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9126 (CONSTANTLIM): Remove; unused.
9127 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9128 Define only if needed.
9129
9130 * unexelf.c (unexec): Name an expression,
9131 to avoid gcc -Wbad-function-cast warning.
9132 Use a different way to cause a compilation error if anyone uses
9133 n rather than nn, a way that does not involve shadowing.
9134 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9135
9136 * deps.mk (unexalpha.o): Remove; unused.
9137
9138 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9139 * unexec.h: New file.
9140 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9141 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9142 Depend on unexec.h.
9143 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9144 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9145 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9146 Change as necessary to match prototype in unexec.h.
9147
9148 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9149 shadowing.
9150 (back_comment, skip_chars): Mark vars as initialized.
9151
9152 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9153 Rename locals to avoid shadowing.
9154
9155 * lread.c (read1): Rewrite so as not to use empty "else".
9156 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9157
9158 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9159
9160 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9161 warning when compiling print.c.
9162
9163 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9164 instead of using an uninitialized var.
9165 (font_sort_entities): Mark var as initialized.
9166
9167 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9168
9169 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9170 pointers to constants.
9171 (font_parse_fcname): Remove unused vars.
9172 (font_delete_unmatched): Now static.
9173 (font_get_spec): Remove; unused.
9174 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9175 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9176 Rename or move locals to avoid shadowing.
9177
9178 * fns.c (require_nesting_list, require_unwind): Now static.
9179 (Ffillarray): Rename locals to avoid shadowing.
9180
9181 * floatfns.c (domain_error2): Define only if needed.
9182 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9183
9184 * alloc.c (mark_backtrace): Move decl from here ...
9185 * lisp.h: ... to here, so that it can be checked.
9186
9187 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9188 (Fdefvar): Rewrite so as not to use empty "else".
9189 (lisp_indirect_variable): Name an expression,
9190 to avoid gcc -Wbad-function-cast warning.
9191 (Fdefvar): Rename locals to avoid shadowing.
9192
9193 * callint.c (quotify_arg, quotify_args): Now static.
9194 (Fcall_interactively): Rename locals to avoid shadowing.
9195 Use const pointer when appropriate.
9196
9197 * lisp.h (get_system_name, get_operating_system_release):
9198 Move decls here, to check interfaces.
9199 * process.c (get_operating_system_release): Move decl to lisp.h.
9200 * xrdb.c (get_system_name): Likewise.
9201 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9202 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9203 some of which prompt warnings from gcc -Wbad-function-cast.
9204 (Fformat_time_string, Fencode_time, Finsert_char):
9205 (Ftranslate_region_internal, Fformat):
9206 Rename or remove local vars to avoid shadowing.
9207 (Ftranslate_region_internal): Mark var as initialized.
9208
9209 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9210 avoid shadowing.
9211
9212 * lisp.h (eassert): Check that the argument compiles, even if
9213 ENABLE_CHECKING is not defined.
9214
9215 * data.c (Findirect_variable): Name an expression, to avoid
9216 gcc -Wbad-function-cast warning.
9217 (default_value, arithcompare, arith_driver, arith_error): Now static.
9218 (store_symval_forwarding): Rename local to avoid shadowing.
9219 (Fmake_variable_buffer_local, Fmake_local_variable):
9220 Mark variables as initialized.
9221 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9222
9223 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9224 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9225 Rename locals to avoid shadowing.
9226 (mark_stack): Move local variables into the #ifdef region where
9227 they're used.
9228 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9229 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9230 needed otherwise.
9231 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9232 (GC_STRING_CHARS): Remove; not used.
9233 (Fmemory_limit): Cast sbrk's returned value to char *.
9234
9235 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9236 avoids undefined behavior in theory.
9237
9238 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9239
9240 Use functions, not macros, for up- and down-casing (Bug#8254).
9241 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9242 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9243 to use the following functions instead of these macros.
9244 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9245 EMACS_INT, since callers assume the returned value fits in int.
9246 (upcase1): Likewise, for UPCASE_TABLE.
9247 (uppercasep, lowercasep, upcase): New static inline functions.
9248 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9249 the race-condition problem in the old DOWNCASE.
9250
9251 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9252 Rename locals to avoid shadowing.
9253 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9254 (regex_compile, re_search_2, re_match_2_internal):
9255 Remove unused local vars.
9256 (FREE_VAR): Rewrite so as not to use empty "else",
9257 which gcc can warn about.
9258 (regex_compile, re_match_2_internal): Mark locals as initialized.
9259 (RETALLOC_IF): Define only if needed.
9260 (WORDCHAR_P): Likewise. This one is never needed, but is used
9261 only in a comment talking about a compiler bug, so put inside
9262 the #if 0 of that comment.
9263 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9264 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9265 Remove; unused.
9266
9267 * search.c (boyer_moore): Rename locals to avoid shadowing.
9268 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9269 (PREV_CHAR_BOUNDARY): Likewise.
9270
9271 * search.c (simple_search): Remove unused var.
9272
9273 * dired.c (compile_pattern): Move decl from here ...
9274 * lisp.h: ... to here, so that it can be checked.
9275 (struct re_registers): New forward decl.
9276
9277 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9278
9279 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9280 All uses changed.
9281 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9282 Rename locals to avoid shadowing.
9283 (Fvertical_motion): Mark locals as initialized.
9284
9285 * casefiddle.c (casify_object, casify_region): Now static.
9286 (casify_region): Mark local as initialized.
9287
9288 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9289
9290 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9291 New macros, so that the caller can use some names other than
9292 gcpro1, gcpro2, etc.
9293 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9294 of the new macros.
9295 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9296 argument, for consistency with GCPRO2_VAR, etc: it is now the
9297 prefix of the variable, not the variable itself. All uses
9298 changed.
9299 * dired.c (directory_files_internal, file_name_completion):
9300 Rename locals to avoid shadowing.
9301
9302 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9303 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9304 dired.c's scmp function, had undefined behavior.
9305 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9306 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9307 * buffer.h: ... to here, because these macros use current_buffer,
9308 and the new implementation with inline functions needs to have
9309 current_buffer in scope now, rather than later when the macros
9310 are used.
9311 (downcase, upcase1): New static inline functions.
9312 (DOWNCASE, UPCASE1): Reimplement using these functions.
9313 This avoids undefined behavior in expressions like
9314 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9315 from race conditions in accessing the global variables
9316 case_temp1 and case_temp2.
9317 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9318 * lisp.h (case_temp1, case_temp2): Remove their decls.
9319 * character.h (ASCII_CHAR_P): Move from here ...
9320 * lisp.h: ... to here, so that the inline functions mentioned
9321 above can use them.
9322
9323 * dired.c (directory_files_internal_unwind): Now static.
9324
9325 * fileio.c (file_name_as_directory, directory_file_name):
9326 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9327 Now static.
9328 (file_name_as_directory): Use const pointers when appropriate.
9329 (Fexpand_file_name): Likewise. In particular, newdir might
9330 point at constant storage, so make it a const pointer.
9331 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9332 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9333 signedness issues.
9334 (Fset_file_times, Finsert_file_contents, auto_save_error):
9335 Rename locals to avoid shadowing.
9336
9337 * minibuf.c (choose_minibuf_frame_1): Now static.
9338 (Ftry_completion, Fall_completions): Rename or remove locals
9339 to avoid shadowing.
9340
9341 * marker.c (bytepos_to_charpos): Remove; unused.
9342
9343 * lisp.h (verify_bytepos, count_markers): New decls,
9344 so that gcc does not warn that these functions aren't declared.
9345
9346 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9347 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9348 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9349 (copy_text): Remove unused local var.
9350
9351 * filelock.c (within_one_second): Now static.
9352 (lock_file_1): Rename local to avoid shadowing.
9353
9354 * buffer.c (fix_overlays_before): Mark locals as initialized.
9355 (fix_start_end_in_overlays): Likewise. This function should be
9356 simplified by using pointers-to-pointers, but that's a different
9357 matter.
9358 (switch_to_buffer_1): Now static.
9359 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9360 (report_overlay_modification): Rename locals to avoid shadowing.
9361
9362 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9363 Fix pointer signedness issue.
9364 (sys_subshell): Mark local as volatile if checking for lint,
9365 to suppress a gcc -Wclobbered warning that does not seem to be right.
9366 (MAXPATHLEN): Define only if needed.
9367
9368 * process.c (serial_open, serial_configure): Move decls from here ...
9369 * systty.h: ... to here, so that they can be checked.
9370
9371 * fns.c (get_random, seed_random): Move extern decls from here ...
9372 * lisp.h: ... to here, so that they can be checked.
9373
9374 * sysdep.c (reset_io): Now static.
9375 (wait_for_termination_signal): Remove; unused.
9376
9377 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9378 (copy_keymap_item, append_key, push_text_char_description):
9379 Now static.
9380 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9381 (DENSE_TABLE_SIZE): Remove; unused.
9382 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9383 (describe_map_tree):
9384 Rename locals to avoid shadowing.
9385
9386 * keyboard.c: Declare functions static if they are not used elsewhere.
9387 (echo_char, echo_dash, cmd_error, top_level_2):
9388 (poll_for_input, handle_async_input): Now static.
9389 (read_char, kbd_buffer_get_event, make_lispy_position):
9390 (make_lispy_event, make_lispy_movement, apply_modifiers):
9391 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9392 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9393 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9394 (read_key_sequence, read_char): Mark locals as initialized.
9395 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9396
9397 * keyboard.h (make_ctrl_char): New decl.
9398 (mark_kboards): Move decl here ...
9399 * alloc.c (mark_kboards): ... from here.
9400
9401 * lisp.h (force_auto_save_soon): New decl.
9402
9403 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9404 (DEFINE_DUMMY_FUNCTION): New macro.
9405 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9406 Use it.
9407 (main): Add casts to avoid warnings
9408 if GCC considers string literals to be constants.
9409
9410 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9411
9412 * dbusbind.c: Pointer signedness fixes.
9413 (xd_signature, xd_append_arg, xd_initialize):
9414 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9415 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9416 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9417 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9418
9419 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9420 if GCC considers string literals to be constants.
9421 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9422
9423 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9424
9425 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9426 (print_preprocess, print_object): New macro to fix last change.
9427
9428 * print.c (print_preprocess): Don't forget font objects.
9429
9430 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9431
9432 * emacs.c (USAGE3): Doc fixes.
9433
9434 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9435
9436 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9437 structure.
9438
9439 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9440
9441 * lisp.h (VWindow_system, Qfile_name_history):
9442 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9443 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9444 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9445
9446 * w32select.c: Don't #include "keyboard.h".
9447 (run_protected): Add extern declaration for waiting_for_input.
9448
9449 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9450 * w32console.c (detect_input_pending, read_input_pending)
9451 (encode_terminal_code):
9452 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9453 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9454 (w32_system_caret_y, Qfile_name_history):
9455 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9456 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9457 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9458 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9459 * w32proc.c (Qlocal, report_file_error):
9460 * w32term.c (Vwindow_system, updating_frame):
9461 * w32uniscribe.c (initialized, uniscribe_font_driver):
9462 Remove unneeded extern declarations.
9463
9464 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9465
9466 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9467
9468 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9469
9470 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9471 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9472 These macros can no longer be used for assignment.
9473
9474 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9475 Assign struct members directly, instead of using BUF_BEGV etc.
9476 (record_buffer_markers, fetch_buffer_markers): New functions for
9477 recording and fetching special buffer markers.
9478 (set_buffer_internal_1, set_buffer_temp): Use them.
9479
9480 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9481
9482 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9483
9484 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9485 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9486
9487 * xdisp.c (hscroll_window_tree):
9488 (reconsider_clip_changes): Use PT instead of BUF_PT.
9489
9490 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9491
9492 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9493 $(EMACS_ROOT)/lib/intprops.h.
9494
9495 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9496
9497 Fix more problems found by GCC 4.5.2's static checks.
9498
9499 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9500 to unsigned char * to avoid compiler diagnostic.
9501 (xg_free_frame_widgets): Make it clear that a local variable is
9502 needed only if USE_GTK_TOOLTIP.
9503 (gdk_window_get_screen): Make it clear that this macro is needed
9504 only if USE_GTK_TOOLTIP.
9505 (int_gtk_range_get_value): New function, which avoids a diagnostic
9506 from gcc -Wbad-function-cast.
9507 (xg_set_toolkit_scroll_bar_thumb): Use it.
9508 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9509 diagnostic from gcc -Wbad-function-cast.
9510 (get_utf8_string, xg_get_file_with_chooser):
9511 Rename locals to avoid shadowing.
9512 (create_dialog): Move locals to avoid shadowing.
9513
9514 * xgselect.c (xg_select): Remove unused var.
9515
9516 * image.c (four_corners_best): Mark locals as initialized.
9517 (gif_load): Initialize transparent_p to zero (Bug#8238).
9518 Mark another local as initialized.
9519 (my_png_error, my_error_exit): Mark with NO_RETURN.
9520
9521 * image.c (clear_image_cache): Now static.
9522 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9523 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9524 (x_edge_detection): Remove unnecessary cast that
9525 gcc -Wbad-function-cast diagnoses.
9526 (gif_load): Fix pointer signedness.
9527 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9528 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9529
9530 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9531
9532 Improve quality of tests for time stamp overflow.
9533 For example, without this patch (encode-time 0 0 0 1 1
9534 1152921504606846976) returns the obviously-bogus value (-948597
9535 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9536 reports time overflow. See
9537 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9538 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9539 * editfns.c: Include limits.h and intprops.h.
9540 (TIME_T_MIN, TIME_T_MAX): New macros.
9541 (time_overflow): Move earlier, to before first use.
9542 (hi_time, lo_time): New functions, for an accurate test for
9543 out-of-range times.
9544 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9545 (Fget_internal_run_time): Don't assume time_t fits in int.
9546 (make_time): Use list2 instead of Fcons twice.
9547 (Fdecode_time): More accurate test for out-of-range times.
9548 (check_tm_member): New function.
9549 (Fencode_time): Use it, to test for out-of-range times.
9550 (lisp_time_argument): Don't rely on undefined left-shift and
9551 right-shift behavior when checking for time stamp overflow.
9552
9553 * editfns.c (time_overflow): New function, refactoring common code.
9554 (Fformat_time_string, Fdecode_time, Fencode_time):
9555 (Fcurrent_time_string): Use it.
9556
9557 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9558 * dired.c (make_time): Move to ...
9559 * editfns.c (make_time): ... here.
9560 * systime.h: Note the move.
9561
9562 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9563
9564 * fringe.c (update_window_fringes): Remove unused variables.
9565
9566 * unexmacosx.c (copy_data_segment): Also copy __got section.
9567 (Bug#8223)
9568
9569 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9570
9571 * termcap.c [MSDOS]: Include "msdos.h".
9572 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9573 Constify `char *' arguments and their references according to
9574 prototypes in tparam.h.
9575
9576 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9577
9578 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9579 Adapt all references accordingly.
9580
9581 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9582
9583 2011-03-11 Tom Tromey <tromey@redhat.com>
9584
9585 * buffer.c (syms_of_buffer): Remove obsolete comment.
9586
9587 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9588
9589 * termhooks.h (encode_terminal_code): Declare prototype.
9590
9591 * msdos.c (encode_terminal_code): Don't declare prototype.
9592
9593 * term.c (encode_terminal_code): Now external again, used by
9594 w32console.c and msdos.c.
9595
9596 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9597 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9598
9599 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9600
9601 Fix some minor problems found by GCC 4.5.2's static checks.
9602
9603 * fringe.c (update_window_fringes): Mark locals as initialized
9604 (Bug#8227).
9605 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9606
9607 * alloc.c (mark_fringe_data): Move decl from here ...
9608 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9609 to check its interface.
9610 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9611
9612 * fontset.c (free_realized_fontset): Now static.
9613 (Fset_fontset_font): Rename local to avoid shadowing.
9614 (fontset_font): Mark local as initialized.
9615 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9616
9617 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9618
9619 * xselect.c (x_disown_buffer_selections): Remove; not used.
9620 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9621 (x_own_selection, Fx_disown_selection_internal): Rename locals
9622 to avoid shadowing.
9623 (x_handle_dnd_message): Remove local to avoid shadowing.
9624
9625 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9626 so that the caller can use some name other than gcpro1.
9627 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9628 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9629 (Fx_backspace_delete_keys_p):
9630 Use them to avoid shadowing, and rename vars to avoid shadowing.
9631 (x_decode_color, x_set_name, x_window): Now static.
9632 (Fx_create_frame): Add braces to silence GCC warning.
9633 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9634 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9635 Remove unused locals.
9636 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9637 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9638 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9639 macros.
9640
9641 * xterm.h (x_mouse_leave): New decl.
9642
9643 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9644 Remove unused functions.
9645 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9646 (x_calc_absolute_position): Now static.
9647 (XTread_socket): Don't define label "out" unless it's used.
9648 Don't declare local "event" unless it's used.
9649 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9650 unless they are used.
9651 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9652 (x_fatal_error_signal): Remove; not used.
9653 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9654 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9655 (x_error_catcher, x_connection_closed, x_error_handler):
9656 (x_error_quitter, xembed_send_message, x_iconify_frame):
9657 (my_log_handler): Rename locals to avoid shadowing.
9658 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9659 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9660
9661 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9662 Rename or move locals to avoid shadowing.
9663 (tty_defined_color, merge_face_heights): Now static.
9664 (free_realized_faces_for_fontset): Remove; not used.
9665 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9666 does not deduce is never used uninitialized.
9667 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9668 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9669
9670 * terminal.c (store_terminal_param): Now static.
9671
9672 * xmenu.c (menu_highlight_callback): Now static.
9673 (set_frame_menubar): Remove unused local.
9674 (xmenu_show): Rename parameter to avoid shadowing.
9675 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9676 since they might point to immutable storage.
9677 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9678 since it's unused otherwise.
9679
9680 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9681 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9682 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9683 avoids a gcc -Wuninitialized diagnostic.
9684 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9685 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9686 does not deduce are never used uninitialized.
9687
9688 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9689
9690 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9691 * window.c (window_loop, size_window):
9692 (run_window_configuration_change_hook, enlarge_window): Likewise.
9693
9694 * window.c (display_buffer): Now static.
9695 (size_window): Mark variables that gcc -Wuninitialized
9696 does not deduce are never used uninitialized.
9697 * window.h (check_all_windows): New decl, to forestall
9698 gcc -Wmissing-prototypes diagnostic.
9699 * dispextern.h (bidi_dump_cached_states): Likewise.
9700
9701 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9702 shadowing.
9703 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9704 Include <limits.h>.
9705 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9706 and to avoid gcc -Wuninitialized warning.
9707 (load_charset_map): Mark variables that gcc -Wuninitialized
9708 does not deduce are never used uninitialized.
9709 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9710
9711 * coding.c (coding_set_source, coding_set_destination):
9712 Use "else { /* comment */ }" rather than "else /* comment */;"
9713 for clarity, and to avoid gcc -Wempty-body warning.
9714 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9715 a block, when the outer 'i' will do.
9716 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9717 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9718 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9719 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9720 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9721 Rename locals to avoid shadowing.
9722 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9723 * coding.c (emacs_mule_char, encode_invocation_designation):
9724 Now static, since they're not used elsewhere.
9725 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9726 (decode_coding_object, encode_coding_object, detect_coding_system):
9727 (decode_coding_emacs_mule): Mark variables that gcc
9728 -Wuninitialized does not deduce are never used uninitialized.
9729 (detect_coding_iso_2022): Initialize a local variable that might
9730 be used uninitialized. Leave a FIXME because it's not clear that
9731 this initialization is needed. (Bug#8211)
9732 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9733 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9734 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9735 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9736 Remove unused macros.
9737
9738 * category.c (hash_get_category_set): Remove unused local var.
9739 (copy_category_table): Now static, since it's not used elsewhere.
9740 * character.c (string_count_byte8): Likewise.
9741
9742 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9743 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9744
9745 * chartab.c (copy_sub_char_table): Now static, since it's not used
9746 elsewhere.
9747 (sub_char_table_ref_and_range, char_table_ref_and_range):
9748 Rename locals to avoid shadowing.
9749 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9750
9751 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9752 (BIDI_BOB): Remove unused macro.
9753
9754 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9755 deduce are never used uninitialized.
9756 * term.c (encode_terminal_code): Likewise.
9757
9758 * term.c (encode_terminal_code): Now static. Remove unused local.
9759
9760 * tparam.h: New file.
9761 * term.c, tparam.h: Include it.
9762 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9763 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9764 Move these decls to tparam.h, and make them agree with what
9765 is actually in tparam.c. The previous trick of using incompatible
9766 decls in different modules does not conform to the C standard.
9767 All callers of tparam changed to use tparam's actual API.
9768 * tparam.c (tparam1, tparam, tgoto):
9769 Use const pointers where appropriate.
9770
9771 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9772 * cm.h (struct cm): Likewise.
9773 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9774 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9775 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9776 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9777 (turn_on_face, init_tty): Likewise.
9778 * termchar.h (struct tty_display_info): Likewise.
9779
9780 * term.c (term_mouse_position): Rename local to avoid shadowing.
9781
9782 * alloc.c (mark_ttys): Move decl from here ...
9783 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9784
9785 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9786
9787 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9788
9789 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9790
9791 * search.c (compile_pattern_1): Remove argument regp, unused since
9792 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9793 (compile_pattern): Don't pass it.
9794
9795 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9796
9797 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9798 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9799 for ! HAVE_GTK3.
9800 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9801
9802 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9803
9804 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9805 gdk_window_get_screen, gdk_window_get_geometry,
9806 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9807 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9808 (xg_get_pixbuf_from_pixmap): New function.
9809 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9810 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9811 Call xg_get_pixbuf_from_pixmap instead of
9812 gdk_pixbuf_get_from_drawable.
9813 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9814 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9815 (xg_check_special_colors): Use GtkStyleContext and its functions
9816 for HAVE_GTK3.
9817 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9818 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9819 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9820 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9821 Call gtk_widget_get_preferred_size.
9822 (xg_frame_resized): gdk_window_get_geometry only takes 5
9823 parameters.
9824 (xg_win_to_widget, xg_event_is_for_menubar):
9825 Call gdk_x11_window_lookup_for_display.
9826 (xg_set_widget_bg): New function.
9827 (delete_cb): New function.
9828 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9829 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9830 (xg_set_background_color): Call xg_set_widget_bg.
9831 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9832 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9833 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9834 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9835 if ! HAVE_GTK3.
9836 (update_frame_tool_bar): Call gtk_widget_hide.
9837 (xg_initialize): Use GDK_KEY_g.
9838
9839 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9840 if ! HAVE_GTK3
9841 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9842
9843 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9844 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9845 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9846
9847 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9848
9849 * w32xfns.c (select_palette): Check success of RealizePalette against
9850 GDI_ERROR, not zero.
9851
9852 See ChangeLog.11 for earlier changes.
9853
9854 ;; Local Variables:
9855 ;; coding: utf-8
9856 ;; End:
9857
9858 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9859
9860 This file is part of GNU Emacs.
9861
9862 GNU Emacs is free software: you can redistribute it and/or modify
9863 it under the terms of the GNU General Public License as published by
9864 the Free Software Foundation, either version 3 of the License, or
9865 (at your option) any later version.
9866
9867 GNU Emacs is distributed in the hope that it will be useful,
9868 but WITHOUT ANY WARRANTY; without even the implied warranty of
9869 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9870 GNU General Public License for more details.
9871
9872 You should have received a copy of the GNU General Public License
9873 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.