* dbusbind.c (Fdbus_register_method): Mention the return value
[bpt/emacs.git] / src / ChangeLog
1 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2
3 * dbusbind.c (Fdbus_register_method): Mention the return value
4 :ignore in the docstring.
5
6 2012-02-02 Glenn Morris <rgm@gnu.org>
7
8 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
9
10 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
11 Unconditionally set to t. (Bug#10673)
12 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
13 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
14 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
15
16 2012-02-02 Kenichi Handa <handa@m17n.org>
17
18 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
19 0, do not call append_composite_glyph.
20
21 2012-02-02 Kenichi Handa <handa@m17n.org>
22
23 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
24 NULL (Bug#6988).
25 (x_produce_glyphs): If the component of a composition is a null
26 string, set it->pixel_width to 1 to avoid zero-width glyph.
27
28 2012-02-01 Eli Zaretskii <eliz@gnu.org>
29
30 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
31 first 2 arguments are identical. This makes inserting large
32 output from a subprocess an order of magnitude faster on
33 MS-Windows, where all sbrk'ed memory is always contiguous.
34
35 2012-01-31 Glenn Morris <rgm@gnu.org>
36
37 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
38 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
39 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
40
41 2012-01-29 Glenn Morris <rgm@gnu.org>
42
43 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
44
45 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
46
47 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
48
49 2012-01-28 Chong Yidong <cyd@gnu.org>
50
51 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
52
53 2012-01-26 Chong Yidong <cyd@gnu.org>
54
55 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
56
57 * search.c (Fsearch_forward, Fsearch_backward): Document negative
58 repeat counts (Bug#10507).
59
60 2012-01-26 Glenn Morris <rgm@gnu.org>
61
62 * lread.c (syms_of_lread): Doc fix.
63
64 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
65
66 * coding.c (encode_designation_at_bol): Change return value to
67 EMACS_INT.
68
69 2012-01-25 Chong Yidong <cyd@gnu.org>
70
71 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
72
73 2012-01-21 Chong Yidong <cyd@gnu.org>
74
75 * floatfns.c (Fcopysign): Make the second argument non-optional,
76 since nil is not allowed anyway.
77
78 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
79
80 * process.c (read_process_output): Use p instead of XPROCESS (proc).
81 (send_process): Likewise.
82
83 2012-01-19 Martin Rudalics <rudalics@gmx.at>
84
85 * window.c (save_window_save, Fcurrent_window_configuration)
86 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
87 doc-strings.
88
89 2012-01-19 Kenichi Handa <handa@m17n.org>
90
91 * character.c (char_width): New function.
92 (Fchar_width, c_string_width, lisp_string_width):
93 Use char_width (Bug#9496).
94
95 2012-01-16 Martin Rudalics <rudalics@gmx.at>
96
97 * window.c (Vwindow_persistent_parameters): New variable.
98 (Fset_window_configuration, save_window_save): Handle persistent
99 window parameters.
100
101 2012-01-14 Eli Zaretskii <eliz@gnu.org>
102
103 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
104 thrashing the stack of the thread. (Bug#9087)
105
106 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
107
108 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
109
110 2012-01-11 Eli Zaretskii <eliz@gnu.org>
111
112 * xdisp.c (rows_from_pos_range): Handle the case where the
113 highlight ends on a newline. (Bug#10464)
114 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
115 he end column for display of highlight that ends on a newline
116 before a R2L line.
117
118 2012-01-11 Glenn Morris <rgm@gnu.org>
119
120 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
121 from load-path also when installation-directory is nil. (Bug#10208)
122
123 2012-01-10 Glenn Morris <rgm@gnu.org>
124
125 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
126
127 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
128 Update template values to be closer to their typical values these days.
129
130 2012-01-09 Eli Zaretskii <eliz@gnu.org>
131
132 * xdisp.c (rows_from_pos_range): Accept additional argument
133 DISP_STRING, and accept any glyph in a row whose object is that
134 string as eligible for mouse highlight. Fixes mouse highlight of
135 display strings from overlays. (Bug#10464)
136
137 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
138
139 emacs: fix an auto-save permissions race condition (Bug#10400)
140 * fileio.c (auto_saving_dir_umask): New static var.
141 (Fmake_directory_internal): Use it.
142 (do_auto_save_make_dir): Set it, instead of invoking chmod after
143 creating the directory. The old code temporarily assigns
144 too-generous permissions to the directory.
145 (do_auto_save_eh): Clear it.
146 (Fdo_auto_save): Catch all errors, not just file errors, so
147 that the var is always cleared.
148
149 2012-01-07 Eli Zaretskii <eliz@gnu.org>
150
151 * search.c (scan_buffer): Pass character positions to
152 know_region_cache, not byte positions. (Bug#6540)
153
154 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
155
156 * w32.c (sys_rename): Report EXDEV when rename of a directory
157 fails because the target is on another logical disk. (Bug#10284)
158
159 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
160
161 * xterm.c (x_embed_request_focus): New function.
162
163 * xterm.h: Add prototype.
164
165 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
166
167 2012-01-05 Glenn Morris <rgm@gnu.org>
168
169 * emacs.c (emacs_copyright): Update short copyright year to 2012.
170
171 2012-01-01 Eli Zaretskii <eliz@gnu.org>
172
173 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
174 Load gnutls_transport_set_lowat only if GnuTLS version is below
175 2.11.1.
176 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
177 GnuTLS versions below 2.11.1.
178
179 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
180
181 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
182 to the doc string advising against its use for altering the way
183 windows are scrolled.
184
185 2011-12-28 Kenichi Handa <handa@m17n.org>
186
187 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
188 coding-system ASCII compatible only when it does not produce BOM
189 on encoding (Bug#10383).
190
191 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
192
193 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
194 can scroll.
195 (create_and_show_popup_menu): Always use menu_position_func for
196 Gtk3 (Bug#10361).
197
198 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
199
200 * callint.c (Fcall_interactively): Don't truncate prompt string.
201
202 2011-12-23 Eli Zaretskii <eliz@gnu.org>
203
204 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
205 property that ends at ZV, so that the bidi iteration could be
206 resumed from there (after widening). (Bug#10360)
207
208 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
209
210 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
211
212 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
213
214 * nsterm.m (x_free_frame_resources):
215 Release f->output_data.ns->miniimage.
216 (ns_index_color): Fix indentation. Do not retain
217 color_table->colors[i].
218
219 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
220 before returning.
221
222 * nsfns.m (x_set_background_color): Assign return value from
223 ns_index_color to face-background instead of NSColor*.
224 (ns_implicitly_set_icon_type): Fix indentation.
225 Change assignment in for loop to comparison.
226
227 * emacs.c (ns_pool): New variable.
228 (main): Assign ns_pool.
229 (Fkill_emacs): Call ns_release_autorelease_pool.
230
231 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
232 autorelease fdesc, release fdAttrs and tdict.
233 (ns_get_covering_families): Release charset.
234 (ns_findfonts): Release NSFontDescriptor created with new.
235 (ns_uni_to_glyphs): Fix indentation.
236 (setString): Release attrStr before assigning new value.
237
238 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
239
240 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
241 and NS_IMPL_COCOA.
242 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
243 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
244
245 2011-12-18 David Reitter <reitter@cmu.edu>
246
247 * nsterm.m (ns_term_init): Subscribe for notifications
248 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
249 to method trackingNotification in EmacsMenu.
250
251 * nsmenu.m (trackingMenu): New variable.
252 (trackingNotification): New method (from Aquamacs).
253 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
254 from Aquamacs (Bug#7030).
255
256 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
257
258 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
259 (symbol_to_nsstring): Fix indentation.
260 (ns_symbol_to_pb): New function.
261 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
262 (Fns_rotate_cut_buffers_internal): Removed.
263 (Fns_store_selection_internal): Renamed from
264 Fns_store_cut_buffer_internal.
265 (ns_get_foreign_selection, Fx_own_selection_internal)
266 (Fx_disown_selection_internal, Fx_selection_exists_p)
267 (Fns_get_selection_internal, Fns_store_selection_internal):
268 Use ns_symbol_to_pb and check if return value is nil.
269 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
270 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
271 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
272 renamed to Sns_store_selection_internal.
273 (ns_handle_selection_request): Move code to Fx_own_selection_internal
274 and remove this function.
275 (ns_handle_selection_clear): Remove, never used.
276 (Fx_own_selection_internal): Move code from ns_handle_selection_request
277 here.
278
279 2011-12-17 Ken Brown <kbrown@cornell.edu>
280
281 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
282 GID is unknown (Bug#10257).
283
284 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
285
286 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
287 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
288 which caused a build failure on GNU/Linux IA-64. This problem was
289 introduced by my 2011-10-07 patch.
290
291 2011-12-15 Juri Linkov <juri@jurta.org>
292
293 * image.c (imagemagick_error): New function. (Bug#10112)
294 (imagemagick_load_image): Comment out `MagickSetResolution' call.
295 Use `imagemagick_error' where ImageMagick functions return
296 `MagickFalse'.
297 (Fimagemagick_types): Add `Fnreverse' to return the list in the
298 proper order.
299
300 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
301
302 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
303 fill background (Bug#8992).
304
305 2011-12-13 Martin Rudalics <rudalics@gmx.at>
306
307 * window.c (Vwindow_combination_resize)
308 (Vwindow_combination_limit): Use t instead of non-nil in
309 doc-strings.
310 (Vrecenter_redisplay): Add first sentence of doc-string on
311 separate line.
312 (Frecenter): Fix doc-string typo.
313
314 2011-12-11 Kenichi Handa <handa@m17n.org>
315
316 * coding.c (Funencodable_char_position): Pay attention to the
317 buffer text relocation (Bug#9389).
318
319 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
320
321 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
322 gtk_init (Bug#10100).
323
324 2011-12-10 Eli Zaretskii <eliz@gnu.org>
325
326 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
327 IT->string is nil. (Bug#10263)
328
329 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
330
331 * nsterm.h (x_free_frame_resources): Declare.
332
333 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
334 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
335
336 * nsterm.h (ns_get_defaults_value): Declare.
337
338 * nsterm.m (ns_default): Call ns_get_defaults_value.
339
340 2011-12-09 Eli Zaretskii <eliz@gnu.org>
341
342 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
343 (Bug#10170)
344
345 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
346
347 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
348 that where the value of an _OBJC_* symbol points to is in the .bss
349 section (Bug#10240).
350
351 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
352
353 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
354 after the loop to call ccl_driver at least once (Bug#8619).
355
356 2011-12-08 Kenichi Handa <handa@m17n.org>
357
358 * ftfont.c (get_adstyle_property): Fix previous change
359 (Bug#10233).
360
361 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
362
363 * w32.c (init_environment): If no_site_lisp, remove site-lisp
364 dirs from the default value of EMACSLOADPATH (bug#10208).
365
366 2011-12-07 Glenn Morris <rgm@gnu.org>
367
368 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
369 installation and source directories as well. (Bug#10208)
370
371 2011-12-06 Chong Yidong <cyd@gnu.org>
372
373 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
374
375 2011-12-06 Glenn Morris <rgm@gnu.org>
376
377 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
378 as an error, not just -1. (Bug#10217)
379
380 2011-12-05 Chong Yidong <cyd@gnu.org>
381
382 * keyboard.c (process_special_events): New function.
383 (swallow_events, Finput_pending_p): Use it (Bug#10195).
384
385 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
386
387 * coding.c (encode_designation_at_bol): Don't use uninitialized
388 local variable (Bug#9318).
389
390 2011-12-05 Kenichi Handa <handa@m17n.org>
391
392 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
393 return Qnil (Bug#8046, Bug#10193).
394
395 2011-12-05 Kenichi Handa <handa@m17n.org>
396
397 * coding.c (encode_designation_at_bol): New args charbuf_end and
398 dst. Return the number of produced bytes. Callers changed.
399 (coding_set_source): Return how many bytes coding->source was
400 relocated.
401 (coding_set_destination): Return how many bytes
402 coding->destination was relocated.
403 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
404 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
405
406 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
407
408 * coding.c (CODING_CHAR_CHARSET_P): New macro.
409 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
410 macro (Bug#9318).
411
412 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
413
414 The following changes are to fix Bug#9318.
415
416 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
417 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
418 (encode_coding_iso_2022, encode_coding_sjis)
419 (encode_coding_big5, encode_coding_charset): Use the above macros.
420
421 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
422
423 * lisp.h (process_quit_flag): Fix external declaration.
424
425 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
426
427 Don't macro-inline non-performance-critical code.
428 * eval.c (process_quit_flag): New function.
429 * lisp.h (QUIT): Use it.
430
431 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
432
433 * nsfns.m (get_geometry_from_preferences): New function.
434 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
435
436 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
437
438 * emacs.c (Qkill_emacs): Define.
439 (syms_of_emacs): Initialize it.
440 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
441 Qquit_flag to `kill-emacs' instead.
442 (quit_throw_to_read_char): Add parameter `from_signal'.
443 All callers changed. Call Fkill_emacs if requested and safe.
444 * lisp.h (QUIT): Call Fkill_emacs if requested.
445
446 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
447
448 * widget.c (update_wm_hints): Return if wmshell is null.
449 (widget_update_wm_size_hints): New function.
450
451 * widget.h (widget_update_wm_size_hints): Declare.
452
453 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
454 widget_update_wm_size_hints (Bug#10104).
455
456 2011-12-03 Eli Zaretskii <eliz@gnu.org>
457
458 * xdisp.c (handle_invisible_prop): If the invisible text ends just
459 before a newline, prepare the bidi iterator for consuming the
460 newline, and keep the current paragraph direction. (Bug#10183)
461 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
462
463 2011-12-02 Juri Linkov <juri@jurta.org>
464
465 * search.c (Fword_search_regexp): New Lisp function created from
466 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
467 (Fword_search_backward, Fword_search_forward)
468 (Fword_search_backward_lax, Fword_search_forward_lax):
469 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
470 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
471
472 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
473
474 * fileio.c (Finsert_file_contents): Move after-change-function call
475 to before the "handled:" label, since all "goto handled" appear in
476 cases where the *-change-functions have already been properly called
477 (bug#10117).
478
479 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
480
481 * keyboard.c (interrupt_signal): Don't call kill-emacs when
482 waiting for input. (Bug#10169)
483
484 2011-11-30 Eli Zaretskii <eliz@gnu.org>
485
486 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
487 verifies glyph row's hash code--we have just reallocated the
488 glyphs, so their contents can be complete garbage. (Bug#10164)
489
490 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
491
492 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
493
494 2011-11-30 Eli Zaretskii <eliz@gnu.org>
495
496 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
497 attributes are tested _before_ calling verify_row_hash, to protect
498 against GCC re-ordering of the tests. (Bug#10164)
499
500 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
501
502 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
503
504 * xterm.c (handle_one_xevent): Only set async_visible and friends
505 if net_wm_state_hidden_seen is non-zero (Bug#10002)
506 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
507 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
508
509 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
510
511 Remove GCPRO-related macros that exist only to avoid shadowing locals.
512 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
513 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
514 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
515 All uses changed to use GCPRO1 etc.
516 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
517 Revert to old implementation (i.e., before 2011-03-11).
518
519 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
520
521 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
522 of scroll runs so as to avoid assigning disabled bogus rows and
523 unnecessary graphics copy operations.
524
525 2011-11-27 Eli Zaretskii <eliz@gnu.org>
526
527 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
528 (snprintf) [_MSC_VER]: Redirect to _snprintf.
529 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
530 (malloc, free, realloc, calloc): Redirect to e_* only when
531 compiling Emacs.
532
533 * lisp.h (GCTYPEBITS): Move before first use.
534 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
535 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
536 this macro definition.
537
538 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
539 _MSC_VER.
540
541 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
542
543 * gtkutil.c (xg_create_frame_widgets):
544 Call gtk_window_set_has_resize_grip (FALSE) if that function is
545 present with Gtk+ 2.0.
546
547 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
548
549 * fileio.c (Finsert_file_contents): Undo previous change; see
550 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
551
552 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
553
554 Rename locals to avoid shadowing.
555 * fileio.c (Finsert_file_contents):
556 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
557 * process.c (wait_reading_process_output):
558 Rename inner 'proc' to 'p' to avoid shadowing.
559 Indent for consistency with usual Emacs style.
560
561 2011-11-25 Eli Zaretskii <eliz@gnu.org>
562
563 * xdisp.c (redisplay_window): If cursor row is not fully visible
564 after recentering, and scroll-conservatively is set to a large
565 number, scroll window by a few more lines to make the cursor fully
566 visible and out of scroll-margin. (Bug#10105)
567 (start_display): Don't move to the next line if the display should
568 start at a newline that is part of a display vector or an overlay
569 string. (Bug#10119)
570
571 2011-11-24 Juri Linkov <juri@jurta.org>
572
573 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
574 after the `MagickPingImage' call. (Bug#10112)
575
576 2011-11-23 Chong Yidong <cyd@gnu.org>
577
578 * window.c (Fcoordinates_in_window_p): Accept only live windows.
579
580 2011-11-23 Martin Rudalics <rudalics@gmx.at>
581
582 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
583 making another buffer current. (Bug#10114)
584
585 2011-11-23 Glenn Morris <rgm@gnu.org>
586
587 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
588
589 2011-11-23 Chong Yidong <cyd@gnu.org>
590
591 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
592 using it (Bug#5984).
593
594 2011-11-22 Eli Zaretskii <eliz@gnu.org>
595
596 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
597 and header-lines, as they don't have one computed for them.
598 (Bug#10098)
599
600 * .gdbinit (prow): Make displayed values more self-explaining.
601 Add row's hash code.
602
603 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
604
605 * process.c (wait_reading_process_output): Fix asynchrounous
606 GnuTLS socket handling on some versions of the GnuTLS library.
607 (wait_reading_process_output): Add comment and URL.
608
609 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
610
611 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
612
613 2011-11-21 Chong Yidong <cyd@gnu.org>
614
615 * window.c (Fnext_window, Fprevious_window): Doc fix.
616
617 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
618
619 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
620
621 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
622
623 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
624
625 2011-11-20 Martin Rudalics <rudalics@gmx.at>
626
627 * window.c (Fset_window_combination_limit): Rename argument
628 STATUS to LIMIT.
629 (Vwindow_combination_limit): Remove "status" from doc-string.
630
631 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
632
633 * m/ibms390.h: Remove.
634 * m/ibms390x.h: Don't include "ibms390.h".
635
636 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
637
638 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
639 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
640
641 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
642
643 * casetab.c (Fset_case_table):
644 * charset.c (Fcharset_after): Fix typos.
645
646 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
647
648 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
649 Otherwise, valgrind does not work on some platforms.
650 Problem reported by Andreas Schwab in
651 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
652 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
653 is set, removing the need for VIRT_ADDRESS_VARIES.
654 (PURE_P): Use a more-efficient implementation that needs just one
655 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
656 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
657 to 4 (xorl, subq, cmpq, setbe).
658 * alloc.c (pure): Always extern now, since that's the
659 VIRT_ADDR_VARIES behavior.
660 (PURE_POINTER_P): Use a single comparison, not two, for
661 consistency with the new puresize.h.
662 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
663 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
664 Remove VIRT_ADDR_VARIES no longer needed.
665
666 2011-11-19 Eli Zaretskii <eliz@gnu.org>
667
668 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
669 (erase_phys_cursor, update_window_cursor, show_mouse_face)
670 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
671 behave as if the cursor position were at the window margin.
672
673 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
674 and the cursor position is out of bounds, behave as if the cursor
675 position were at the window margin. (Bug#10075)
676
677 2011-11-18 Chong Yidong <cyd@gnu.org>
678
679 * window.c (Fwindow_combination_limit): Make first argument
680 non-optional, since it is meaningless for live windows like the
681 selected window.
682
683 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
684
685 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
686
687 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
688
689 * intervals.c: Fix grafting over the whole buffer (bug#10071).
690 (graft_intervals_into_buffer): Simplify.
691
692 2011-11-18 Eli Zaretskii <eliz@gnu.org>
693
694 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
695 hash values of the two rows.
696 (copy_row_except_pointers): Preserve the used[] arrays and the
697 hash values of the two rows. (Bug#10035)
698 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
699
700 * xdisp.c (row_hash): New function, body extracted from
701 compute_line_metrics.
702 (compute_line_metrics): Call row_hash, instead of computing the
703 hash code inline.
704
705 * dispnew.c (verify_row_hash): Call row_hash for computing the
706 hash code of a row, instead of duplicating code from xdisp.c.
707
708 * dispextern.h (row_hash): Add prototype.
709
710 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
711
712 * frame.c (delete_frame): Don't delete the terminal when the last
713 X frame is closed if emacs is built with GTK toolkit.
714
715 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
716
717 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
718
719 2011-11-17 Martin Rudalics <rudalics@gmx.at>
720
721 * window.c (Vwindow_splits): Rename to
722 Vwindow_combination_resize. Suggested by Juri Linkov.
723 (Fsplit_window_internal): Use Vwindow_combination_resize instead
724 of Vwindow_splits.
725
726 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
727
728 * nsfns.m (Fns_font_name):
729 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
730
731 2011-11-16 Martin Rudalics <rudalics@gmx.at>
732
733 * window.h (window): Rename slot "nest" to "combination_limit".
734 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
735 (Fset_window_nest): Rename to Fset_window_combination_limit.
736 (Vwindow_nest): Rename to Vwindow_combination_limit.
737 (recombine_windows, make_parent_window, make_window)
738 (Fsplit_window_internal, saved_window)
739 (Fset_window_configuration, save_window_save): Rename all
740 occurrences of window_nest to window_combination_limit.
741
742 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
743
744 * image.c (imagemagick_load_image): Fix typo.
745
746 2011-11-14 Eli Zaretskii <eliz@gnu.org>
747
748 * xdisp.c (display_line): Move the call to
749 highlight_trailing_whitespace before the call to
750 compute_line_metrics, since the latter needs to see the final
751 faces of all the glyphs to compute ROW's hash value.
752 Fixes assertion violations in row_equal_p. (Bug#10035)
753
754 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
755
756 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
757 just return (bug#10044).
758
759 2011-11-12 Eli Zaretskii <eliz@gnu.org>
760
761 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
762 with user-defined heap size. Bump the default size of the temacs
763 heap to 27MB, to avoid memory warning when running temacs.
764 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
765
766 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
767 current_matrix and desired_matrix. (Bug#9990)
768 (verify_row_hash) [XASSERTS]: New function.
769 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
770 that the hash value of glyph rows is correct.
771
772 2011-11-12 Martin Rudalics <rudalics@gmx.at>
773
774 * window.h (window): Remove splits slot.
775 * window.c (Fwindow_splits, Fset_window_splits): Remove.
776 (Fdelete_other_windows_internal, make_parent_window)
777 (make_window, Fsplit_window_internal, Fdelete_window_internal)
778 (Fset_window_configuration, save_window_save): Don't deal with
779 split status of windows.
780 (saved_window): Remove splits slot.
781 (Vwindow_splits): Rewrite doc-string.
782
783 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
784
785 * xfns.c (unwind_create_frame):
786 * nsfns.m (unwind_create_frame):
787 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
788 Vframe_list (Bug#9999).
789
790 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
791
792 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
793
794 2011-11-11 Kenichi Handa <handa@m17n.org>
795
796 * callproc.c (Fcall_process): Set the member dst_multibyte of
797 process_coding.
798
799 2011-11-11 Johan Bockgård <bojohan@gnu.org>
800
801 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
802 avoid a crash (bug#9496).
803
804 2011-11-09 Chong Yidong <cyd@gnu.org>
805
806 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
807 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
808
809 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
810
811 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
812
813 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
814
815 Avoid some portability problems by eschewing 'extern inline' functions.
816 The trivial performance wins aren't worth the portability hassles; see
817 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
818 et seq.
819 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
820 (window_box_width, window_box_left, window_box_left_offset)
821 (window_box_right, window_box_right_offset): Undo previous change,
822 by removing the "extern"s.
823 * intervals.c (adjust_intervals_for_insertion)
824 (adjust_intervals_for_deletion): Undo previous change,
825 making these static again.
826 (offset_intervals, temp_set_point_both, temp_set_point)
827 (copy_intervals_to_string): No longer inline.
828 * xdisp.c (window_text_bottom_y, window_box_width)
829 (window_box_height, window_box_left_offset)
830 (window_box_right_offset, window_box_left, window_box_right)
831 (window_box): No longer inline.
832
833 2011-11-08 Chong Yidong <cyd@gnu.org>
834
835 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
836 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
837 Signal an error if not a live window.
838 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
839 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
840
841 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
842
843 * lisp.h (syms_of_abbrev): Remove declaration.
844 Reported by CHENG Gao <chenggao@royau.me>.
845
846 2011-11-07 Eli Zaretskii <eliz@gnu.org>
847
848 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
849 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
850 of temacs in GUI mode.
851
852 2011-11-07 Martin Rudalics <rudalics@gmx.at>
853
854 * window.h: Declare delete_all_child_windows instead of
855 delete_all_subwindows.
856 * window.c (Fwindow_nest, Fset_window_nest)
857 (Fset_window_new_total, Fset_window_new_normal)
858 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
859 (delete_all_subwindows): Rename to delete_all_child_windows.
860 (Fdelete_other_windows_internal, Fset_window_configuration):
861 Call delete_all_child_windows instead of delete_all_subwindows.
862 * frame.c (delete_frame): Call delete_all_child_windows instead
863 of delete_all_subwindows.
864
865 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
866
867 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
868 This is also needed for porting to any host where GC_MARK_STACK is
869 not GC_MAKE_GCPROS_NOOPS.
870 (which_symbols): Use it.
871
872 2011-11-07 Kenichi Handa <handa@m17n.org>
873
874 * coding.c (coding_set_destination): Check coding->src_pos only
875 when coding->src_object is a buffer (bug#9910).
876
877 * process.c (send_process): Set the member src_multibyte of coding
878 to 0 (bug#9911) when sending a unibyte text.
879
880 * callproc.c (Fcall_process): Set the member src_multibyte of
881 process_coding to 0 (bug#9912).
882
883 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
884
885 * xmenu.c (cleanup_widget_value_tree): New function.
886 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
887 calling free_menubar_widget_value_tree directly (Bug#9830).
888
889 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
890
891 Fix some portability problems with 'inline'.
892 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
893 (window_box_width, window_box_left, window_box_left_offset)
894 (window_box_right, window_box_right_offset): Declare extern.
895 Otherwise, these inline functions do not conform to C99 and
896 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
897 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
898 * intervals.c (adjust_intervals_for_insertion)
899 (adjust_intervals_for_deletion): Now extern, because otherwise the
900 extern inline functions 'offset_intervals' couldn't refer to it.
901 (static_offset_intervals): Remove.
902 (offset_intervals): Rewrite using the old contents of
903 static_offset_intervals. The old version didn't conform to C99
904 because an extern inline function contained a reference to an
905 identifier with static linkage.
906
907 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
908
909 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
910 GC.
911
912 2011-11-06 Eli Zaretskii <eliz@gnu.org>
913
914 * xdisp.c (init_iterator, reseat_to_string): Don't set the
915 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
916 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
917 return Qleft_to_right.
918
919 2011-11-06 Chong Yidong <cyd@gnu.org>
920
921 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
922 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
923 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
924 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
925 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
926 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
927 (Fwindow_vscroll): Doc fix.
928 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
929 argument, since it makes no sense to pass a live window and for
930 consistency with window-child.
931
932 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
933
934 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
935 support MSVC.
936
937 2011-11-05 Jason Rumney <jasonr@gnu.org>
938
939 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
940 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
941 fonts (Bug#6029).
942 (add_font_entity_to_list): Fix logic errors in mixed boolean and
943 bitwise arithmetic preventing use of unicode-sip and non-truetype
944 opentype fonts.
945
946 2011-11-05 Eli Zaretskii <eliz@gnu.org>
947
948 * s/ms-w32.h (fstat, stat, utime): Move redirections to
949 "emacs"-only part.
950
951 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
952 initialization code to keep similarity to xfns.c after changes
953 from 2011-11-05.
954
955 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
956
957 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
958 (unwind_create_frame): New function (Bug#9943).
959 (Fx_create_frame): Restructure code to be more similar to the one in
960 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
961 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
962 Move terminal->reference_count++ just before making the frame official
963 (Bug#9943).
964
965 * nsterm.m (x_free_frame_resources): New function.
966 (x_destroy_window): Move code to x_free_frame_resources.
967
968 * xfns.c (unwind_create_frame): Fix comment.
969 (Fx_create_frame, x_create_tip_frame):
970 Move terminal->reference_count++ just before making the frame
971 official. Move initialization of image_cache_refcount and
972 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
973
974 2011-11-05 Eli Zaretskii <eliz@gnu.org>
975
976 Support MSVC build with newer versions of Visual Studio.
977 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
978 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
979 nt/gmake.defs.
980
981 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
982 which are not supported by MSVC.
983 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
984 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
985 bitfields.
986 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
987 types in bitfields.
988 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
989
990 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
991
992 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
993
994 Support MSVC build with newer versions of Visual Studio.
995 * w32.c: Don't include w32api.h for MSVC.
996 (init_environment) [_MSC_VER]: Call sys_access, not _access.
997
998 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
999 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1000 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1001 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1002 e_* cousins.
1003 (alloca) [_MSC_VER]: Define to _alloca.
1004
1005 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1006
1007 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1008
1009 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1010
1011 * xdisp.c (note_mouse_highlight): If either of
1012 previous/next-single-property-change returns nil, treat that as
1013 the beginning or the end of the buffer. (Bug#9955)
1014
1015 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1016
1017 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1018 label is not null (Bug#9951).
1019 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1020 may be NULL.
1021
1022 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1023
1024 * window.c (Fwindow_body_size): Mention in the doc string that the
1025 return value is in frame's canonical units. (Bug#9949)
1026
1027 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1028
1029 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1030
1031 * w32fns.c (unwind_create_frame): If needed, free the glyph
1032 matrices of the partially constructed frame. (Bug#9943)
1033 * xfns.c (unwind_create_frame): Likewise.
1034
1035 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1036
1037 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1038 Don't stop backward scan on the continuation glyph, even though
1039 its CHARPOS is positive.
1040 (mouse_face_from_buffer_pos, note_mouse_highlight):
1041 Rename cover_string to disp_string.
1042
1043 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1044
1045 * window.c (temp_output_buffer_show): Don't use
1046 Vtemp_buffer_show_specifiers.
1047 (Vtemp_buffer_show_specifiers): Remove unused variable.
1048
1049 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1050
1051 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1052 past the beginning of the current glyph matrix.
1053
1054 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1055
1056 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1057 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1058 HAVE_GTK3 (Bug#9869).
1059
1060 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1061 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1062
1063 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1064
1065 * xterm.c: Declare x_handle_net_wm_state to return int.
1066 (handle_one_xevent): Check if we are iconified but don't have
1067 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1068 (get_current_wm_state): Return non-zero if not hidden,
1069 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1070 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1071 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1072 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1073
1074 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1075
1076 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1077 so that this new function doesn't get optimized away by a
1078 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1079
1080 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1081
1082 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1083
1084 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1085
1086 Fix the `xbytecode' command.
1087 * .gdbinit (xprintbytestr): New command.
1088 (xwhichsymbols): Rename from `which'; all callers changed.
1089 (xbytecode): Print the byte-code string as well.
1090
1091 2011-10-29 Kim Storm <storm@cua.dk>
1092
1093 * alloc.c (which_symbols): New function.
1094
1095 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1096
1097 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1098 line. (Bug#9903)
1099
1100 2011-10-29 Glenn Morris <rgm@gnu.org>
1101
1102 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1103 Not clear what it was for, and it causes various bugs. (Bug#9839)
1104
1105 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1106
1107 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1108 possible random value that matches one of those tested as
1109 condition to clear the mouse face.
1110
1111 2011-10-28 Chong Yidong <cyd@gnu.org>
1112
1113 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1114
1115 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1116
1117 * window.c (make_window): Initialize phys_cursor_on_p.
1118
1119 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1120
1121 * lisp.h (struct Lisp_Symbol): Update comments.
1122
1123 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1124
1125 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1126
1127 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1128
1129 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1130 <oslsachem@gmail.com> for helping to debug this.
1131
1132 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1133 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1134 (g_b_init_get_glyph_outline_w): New static variables.
1135 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1136 (GetGlyphOutlineW_Proc): New typedefs.
1137 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1138 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1139 New functions.
1140 (w32font_open_internal, compute_metrics):
1141 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1142 instead of calling the "wide" APIs directly.
1143
1144 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1145
1146 * w32.h (syms_of_w32font): Add prototype.
1147
1148 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1149
1150 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1151 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1152 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1153 (Fmove_to_window_line): Doc fix.
1154
1155 2011-10-27 Chong Yidong <cyd@gnu.org>
1156
1157 * process.c (make_process): Set gnutls_state to NULL.
1158
1159 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1160 non-NULL, regardless of GNUTLS_INITSTAGE.
1161 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1162 an error. Set process slots as soon as we allocate them.
1163
1164 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1165
1166 2011-10-27 Chong Yidong <cyd@gnu.org>
1167
1168 * gnutls.c (emacs_gnutls_deinit): New function.
1169 Deallocate credentials structures as well as calling gnutls_deinit.
1170 (Fgnutls_deinit, Fgnutls_boot): Use it.
1171
1172 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1173 (deactivate_process): Call emacs_gnutls_deinit.
1174
1175 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1176
1177 * image.c (x_create_x_image_and_pixmap):
1178 * w32.c (sys_rename, w32_delayed_load):
1179 * w32font.c (fill_in_logfont):
1180 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1181
1182 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1183
1184 * w32fns.c (w32_default_color_map): New function,
1185 extracted from Fw32_default_color_map.
1186 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1187
1188 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1189
1190 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1191
1192 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1193
1194 * keyboard.c (test_undefined): New function (bug#9751).
1195 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1196
1197 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1198
1199 * sysdep.c (init_sys_modes): Fix the check for the controlling
1200 terminal (Bug#6649).
1201
1202 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1203
1204 * dispextern.h (struct bidi_it): New member next_en_type.
1205
1206 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1207 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1208 current character, check also for next_en_type being WEAK_EN.
1209 (bidi_resolve_weak): Don't enter the expensive loop if the current
1210 position is before next_en_pos. Record the bidi type of the first
1211 non-ET, non-BN character we find, in addition to its position.
1212 (bidi_level_of_next_char): Invalidate next_en_type when
1213 next_en_pos is over-stepped.
1214
1215 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1216
1217 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1218 * editfns.c: Rewrite current-time-zone so that it invokes
1219 the equivalent of (format-time-string "%Z") to get the time zone name.
1220 This fixes a bug when the time zone name contains characters that
1221 need converting from the system time locale to Emacs internal format.
1222 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1223 that patch fixed format-time-string to do the conversion, but
1224 I forgot to fix current-time-zone.
1225 (format_time_string): New function, containing most of
1226 what Fformat_time_string used to contain.
1227 (Fformat_time_string): Rewrite in terms of format_time_string.
1228 This doesn't change this function's behavior.
1229 (current-time-zone): Rewrite to use format_time_string.
1230 This fixes the bug reported by Michael Schierl in
1231 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1232 Jason Rumney's 2007-06-07 change worked around this bug, but
1233 didn't fix it.
1234 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1235
1236 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1237
1238 * xdisp.c (start_display): If the character at POS is displayed
1239 via a display vector, reset IT->current.dpvec_index to zero.
1240 (try_window_reusing_current_matrix): If a line ends in a display
1241 vector or the next line starts in a display vector, continue
1242 redrawing the window even though the character position of
1243 start_row was reached.
1244 (Bug#9771, part 2)
1245
1246 2011-10-18 Chong Yidong <cyd@gnu.org>
1247
1248 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1249 with nobreak-char-display too.
1250
1251 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1252
1253 Fix part 3 of bug#9771.
1254 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1255 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1256 non-neutral characters if the current character is a paragraph
1257 separator (a.k.a. Newline). This avoids running the same
1258 expensive loop twice, once when we consume the preceding newline
1259 and the other time when the line actually needs to be displayed.
1260 Avoid the loop when we see neutrals on the base embedding level
1261 following a character whose directionality is the same as the
1262 paragraph's. This avoids running the expensive loop when a line
1263 ends in a long sequence of neutrals, like control characters.
1264 Add assertion against STRONG_AL type. Slightly rearrange code
1265 that determines the type of a neutral given the first non-neutral
1266 that follows it.
1267 (bidi_level_of_next_char): Set next_en_pos to zero when
1268 invalidating its info.
1269
1270 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1271
1272 * xdisp.c (push_display_prop): Determine whether to record string
1273 or buffer position by IT->string, not by IT->method. Allow
1274 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1275 (move_it_vertically_backward): Don't look for character position
1276 immediately after the newline when in a continuation line.
1277 (Bug#9771, part 1)
1278
1279 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1280
1281 * window.c (coordinates_in_window): Rewrite and delabelize
1282 vertical border check. (Bug#5357) (Bug#9618)
1283
1284 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1285
1286 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1287 errors in XSetWindowBorder (bug#9310).
1288
1289 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1290
1291 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1292 avoid crash when xmalloc overrun checking is enabled.
1293
1294 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1295
1296 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1297 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1298 cursor motion with <left> and <right> arrow keys.
1299
1300 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1301 some callers set that themselves.
1302
1303 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1304
1305 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1306 display string and the previous row comes from the same string and
1307 is empty. (Bug#9739) (Bug#9738)
1308
1309 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1310
1311 * doc.c (get_doc_string): Encode file name (bug#9735).
1312
1313 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1314
1315 * bidi.c (bidi_level_of_next_char):
1316 * xdisp.c (get_visually_first_element): Remove old incorrect
1317 comments regarding the Unicode Line Separator character.
1318
1319 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1320
1321 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1322
1323 * alloc.c (Fgc_status): Do not access beyond zombies array
1324 boundary if nzombies > MAX_ZOMBIES.
1325 * alloc.c (dump_zombies): Add missing format specifier.
1326
1327 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1328
1329 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1330 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1331
1332 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1333 Some packages use them to denote characters with modifiers.
1334
1335 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1336
1337 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1338 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1339 matching a pp-number. Rename parameter var to var1.
1340
1341 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1342
1343 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1344
1345 2011-10-08 Glenn Morris <rgm@gnu.org>
1346
1347 * callint.c (Fcall_interactively): Give a more explicit error for the
1348 'c' case with a non-character input. (Bug#8479)
1349
1350 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1351
1352 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1353 lines.
1354 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1355 lines that are hscrolled on the left.
1356
1357 * dispnew.c (buffer_posn_from_coords): Account for a possible
1358 presence of header-line. (Bug#4426)
1359
1360 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1361
1362 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1363 Don't advertise functionality which we discourage or doesn't work.
1364
1365 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1366
1367 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1368 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1369 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1370 this makes Emacs dump core during garbage collection on rare
1371 occasions. sizeof is obviously inferior to offsetof here, so
1372 stick with offsetof.
1373 (GC_POINTER_ALIGNMENT): New macro.
1374 (mark_memory): Omit 3rd (offset) arg; caller changed.
1375 Don't assume EMACS_INT alignment is the same as pointer alignment.
1376
1377 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1378
1379 * keyboard.c (read_key_sequence_remapped): New var.
1380 (read_key_sequence): Compute remapping in the right buffer.
1381 (command_loop_1): Use read_key_sequence's remapping directly.
1382
1383 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1384
1385 * dired.c (file_name_completion): Don't expand file name.
1386 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1387 before checking file name handler.
1388
1389 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1390 they've been requested explicitly (bug#9591).
1391
1392 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1393
1394 * keymap.c (Fsingle_key_description): Use make_specified_string
1395 instead of build_string to build string from push_key_description.
1396 (Bug#5193)
1397
1398 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1399
1400 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1401 This fixes a Y2038 bug on 64-bit hosts.
1402 * buffer.c (reset_buffer):
1403 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1404 (Fclear_buffer_auto_save_failure):
1405 Use 0, not -1, to represent an unset failure time, since time_t
1406 might not be signed.
1407
1408 Remove dependency on glibc malloc internals.
1409 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1410 Move back here from lisp.h, but with their new implementations.
1411 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1412 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1413 * charset.c (charset_table_init): New static var.
1414 (syms_of_charset): Use it instead of xmalloc. This removes a
1415 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1416 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1417 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1418 Move back to alloc.c.
1419 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1420 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1421
1422 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1423
1424 * nsterm.m (windowDidResize): Call x_set_window_size only when
1425 ns_in_resize is true. Otherwise set pixelwidth/height and
1426 call change_frame_size (Bug#9628).
1427
1428 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1429
1430 Port --enable-checking=all to Fedora 14 x86-64.
1431 * charset.c (syms_of_charset): Also account for glibc malloc's
1432 internal overhead when calculating the initial malloc maximum.
1433
1434 Port --enable-checking=all to Fedora 14 x86.
1435 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1436 Move to lisp.h.
1437 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1438 (overrun_check_realloc, overrun_check_free):
1439 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1440 That way, xmalloc returns a properly-aligned pointer even if
1441 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1442 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1443 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1444 into account when calculating the initial malloc maximum.
1445 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1446 Move here from alloc.c, so that charset.c can use it too.
1447 Properly align; the old code wasn't right for common 32-bit hosts
1448 when configured with --enable-checking=all.
1449 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1450 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1451
1452 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1453
1454 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1455 use EDOM.
1456
1457 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1458
1459 * xdisp.c (compute_display_string_end): If there's no display
1460 string at CHARPOS, return -1.
1461
1462 * bidi.c (bidi_fetch_char): When compute_display_string_end
1463 returns a negative value, treat the character as a normal
1464 character not covered by a display string. (Bug#9624)
1465
1466 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1467
1468 * lread.c (Fread_from_string): Fix typo in docstring.
1469
1470 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1471
1472 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1473 newline, reseat the iterator instead of bidi-iterating there one
1474 character at a time. (Bug#9610)
1475 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1476 TO_CHARPOS if the bidi iterator is at base embedding level.
1477
1478 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1479
1480 * lread.c (readevalloop): Use correct code for NBSP.
1481 (read1): Likewise. (Bug#9608)
1482
1483 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1484
1485 * dbusbind.c (Fdbus_register_signal): When service is not
1486 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1487
1488 2011-09-25 Glenn Morris <rgm@gnu.org>
1489
1490 * buffer.c (truncate-lines): Doc fix.
1491
1492 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1493
1494 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1495 (Fset_window_next_buffers): Doc fix.
1496
1497 2011-09-24 Glenn Morris <rgm@gnu.org>
1498
1499 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1500
1501 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1502
1503 Fix minor problems found by static checking.
1504 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1505 * indent.c (Fvertical_motion): Fix == vs = typo.
1506
1507 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1508
1509 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1510 Default value is now t. Doc fix.
1511
1512 * indent.c (Fvertical_motion): Compute and apply the overshoot
1513 logic when moving up, not only when moving down. Fix the
1514 confusing name and values of the it_overshoot_expected variable;
1515 logic changes accordingly. (Bug#9254) (Bug#9549)
1516
1517 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1518 CHARPOS is covered by a display string which includes newlines.
1519 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1520 is covered by a display string with embedded newlines.
1521
1522 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1523
1524 * dbusbind.c (Fdbus_register_signal): Add match rule to
1525 Vdbus_registered_objects_table. (Bug#9581)
1526 (Fdbus_register_method, Vdbus_registered_objects_table):
1527 Fix docstring.
1528
1529 2011-09-24 Jim Meyering <meyering@redhat.com>
1530
1531 do not ignore write error for any output size
1532 The previous change was incomplete.
1533 While it makes emacs --batch detect the vast majority of stdout
1534 write failures, errors were still ignored whenever the output size is
1535 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1536 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1537 && echo FAIL: ignored write error
1538 FAIL: ignored write error
1539 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1540 && echo FAIL: ignored write error
1541 FAIL: ignored write error
1542 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1543
1544 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1545
1546 * emacs.c (Fkill_emacs): In noninteractive mode exit
1547 non-successfully if a write error occurred on stdout. (Bug#9574)
1548
1549 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1550
1551 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1552 the xassert test.
1553
1554 * dispextern.h (struct it): Update the comment documenting what
1555 can it->OBJECT be.
1556
1557 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1558
1559 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1560 a display string, extend search for cursor position to end of row.
1561 (find_row_edges): If the row ends in a newline from a display
1562 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1563 Handle the case of a display string with multiple newlines.
1564 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1565 non-empty line. Fixes confusing cursor motion with arrow keys at
1566 the beginning of a line that starts with whitespace.
1567
1568 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1569
1570 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1571 (bug#9493).
1572
1573 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1574
1575 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1576 boolean (Bug#9154).
1577
1578 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1579
1580 * xdisp.c (display_line): Record maximum and minimum buffer
1581 positions even if no glyphs were produced (e.g., by a zero-width
1582 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1583 buffer positions that will be removed from the glyph row because
1584 they don't fit.
1585 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1586 column is beyond frame width: don't subtract 1 "pixel" when
1587 computing width of the stretch.
1588 (reseat_at_next_visible_line_start): Undo the change made on
1589 2011-09-17 that saved paragraph information and restored it after
1590 the call to `reseat'. (Bug#9545)
1591
1592 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1593
1594 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1595 and turn window cursor on if cleared (Bug#9415).
1596
1597 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1598
1599 * search.c (boyer_moore): Take unibyte characters from pattern
1600 literally. (Bug#9458)
1601
1602 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1603
1604 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1605
1606 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1607
1608 Fix minor problem found by static checking.
1609 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1610 initialized, to pacify gcc -Wuninitialized.
1611
1612 * fileio.c: Report proper errno when syscall falls.
1613 (Finsert_file_contents): Save and restore errno,
1614 so that report_file_error outputs the correct diagnostic.
1615 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1616
1617 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1618
1619 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1620
1621 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1622
1623 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1624 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1625
1626 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1627
1628 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1629 about the current paragraph and restore it after the call to reseat.
1630
1631 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1632 (bidi_find_paragraph_start): Search back for paragraph beginning
1633 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1634 (bidi_move_to_visually_next): Only trigger paragraph-related
1635 computations when the last character is a newline or at EOB, not
1636 just any NEUTRAL_B. (Bug#9470)
1637
1638 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1639 truncated lines if point is covered by a display string. (Bug#9524)
1640
1641 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1642
1643 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1644 (cons_to_x_long): New function.
1645 (lisp_data_to_selection_data): Use it. Correct the test for
1646 short-versus-long data; it was negated. Break out of vector
1647 loop, for efficiency, when a long datum is discovered.
1648
1649 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1650
1651 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1652
1653 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1654
1655 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1656 GCC PR/17406) by declaring this function with external scope.
1657
1658 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1659
1660 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1661 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1662
1663 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1664
1665 * editfns.c (Fformat): Correctly handle text properties on "%%".
1666
1667 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1668
1669 * xterm.c (x_draw_composite_glyph_string_foreground):
1670 * w32term.c (x_draw_composite_glyph_string_foreground):
1671 * term.c (encode_terminal_code):
1672 * composite.c (composition_update_it, get_composition_id):
1673 * xdisp.c (get_next_display_element)
1674 (fill_composite_glyph_string): Add comments about special meaning
1675 of TAB characters in a composition.
1676
1677 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1678
1679 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1680 This occurs when processing a multibyte format.
1681 Problem reported by Wolfgang Jenker.
1682
1683 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1684
1685 * xdisp.c (try_cursor_movement): Only check for exact match if
1686 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1687
1688 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1689
1690 Remove unused external symbols.
1691 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1692 * xdisp.c (calc_pixel_width_or_height): Now static.
1693 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1694 * indent.c (check_display_width):
1695 * w32term.c: Fix comment to match code.
1696 * xterm.c, xterm.h (x_catching_errors): Remove.
1697
1698 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1699
1700 * xselect.c: Use signed conversions more consistently (Bug#9498).
1701 (selection_data_to_lisp_data): Assume incoming selection data are
1702 signed integers, not unsigned. This is to be consistent with
1703 outgoing selection data, which was modified to use signed integers
1704 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1705 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1706 expects long, not unsigned long.
1707
1708 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1709
1710 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1711 computation of loop end. Reported by Johan Bockgård
1712 <bojohan@gnu.org>.
1713
1714 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1715
1716 * frame.c (Fother_visible_frames_p): Function deleted.
1717
1718 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1719
1720 * indent.c (compute_motion): Process display vector front to back
1721 rather than the other way around. (Bug#2496)
1722
1723 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1724
1725 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1726
1727 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1728
1729 * minibuf.c (Fread_from_minibuffer): Doc fix.
1730
1731 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1732
1733 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1734 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1735
1736 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1737
1738 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1739 value for non-existent files.
1740
1741 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1742
1743 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1744 set its "size" to -1. This will set the modtime_size field of
1745 the corresponding buffer to -1, which is what
1746 verify-visited-file-modtime expects for files that do not exist.
1747 (Bug#9139)
1748
1749 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1750
1751 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1752 here ...
1753 * lisp.h: ... from here. push_key_description is no longer
1754 defined in keyboard.c, so its declaration should not be in
1755 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1756 logically belongs with push_key_description.
1757
1758 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1759
1760 * buffer.h: Include <sys/types.h> instead of <time.h>.
1761 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1762 Problem reported by Herbert J. Skuhra.
1763
1764 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1765
1766 * xml.c (parse_region): Make the parsing work for
1767 non-comment-starting XML files again (bug#9144).
1768
1769 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1770
1771 * image.c (gif_load): Fix calculation of bottom and right corner.
1772 (Bug#9468)
1773
1774 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1775
1776 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1777 redisplay in small windows.
1778
1779 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1780
1781 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1782
1783 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1784
1785 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1786 Operate on live windows only.
1787
1788 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1789
1790 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1791
1792 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1793
1794 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1795 only under bidi iteration.
1796
1797 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1798
1799 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1800
1801 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1802
1803 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1804 Without this fix, the command to link temacs failed due to an
1805 undefined symbol __builtin_isnan. This is because
1806 /usr/include/iso/math_c99.h #defines isnan(x) to
1807 __builtin_isnan(x), but the bundled gcc, which identifies itself
1808 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1809 a __builtin_isnan.
1810 * floatfns.c (isnan): #undef, and then #define to a clone of
1811 what's in data.c.
1812 (Fisnan): Always define, since it's always available now.
1813 (syms_of_floatfns): Always define isnan at the Lisp level.
1814
1815 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1816
1817 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1818
1819 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1820
1821 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1822 The previous code assumed that file offsets (off_t values) fit in
1823 EMACS_INT variables, which is not true on typical 32-bit hosts.
1824 The code messed up by falsely reporting buffer overflow in cases
1825 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1826 when "big" contains more than 2**29 bytes, even though this
1827 inserts just one byte and does not overflow the buffer.
1828 (Finsert_file_contents): Store file offsets as off_t
1829 values, not as EMACS_INT values. Check for overflow when
1830 converting between EMACS_INT and off_t. When checking for
1831 buffer overflow or for overlap, take the offsets into account.
1832 Don't use EMACS_INT for small values where int suffices.
1833 When checking for overlap, fix a typo: ZV was used where
1834 ZV_BYTE was intended.
1835 (Fwrite_region): Don't assume off_t fits into 'long'.
1836 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1837
1838 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1839
1840 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1841
1842 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1843
1844 sprintf-related integer and memory overflow issues (Bug#9412).
1845
1846 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1847 (esprintf, exprintf, evxprintf): New functions.
1848 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1849 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1850 (modify_event_symbol): Do not assume that the length of
1851 name_alist_or_stem is safe to alloca and fits in int.
1852 (Fexecute_extended_command): Likewise for function name and binding.
1853 (Frecursion_depth): Wrap around reliably on integer overflow.
1854 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1855 since some callers pass EMACS_INT values.
1856 (Fsingle_key_description): Don't crash if symbol name contains more
1857 than MAX_ALLOCA bytes.
1858 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1859 (get_minibuffer): Arg is now EMACS_INT, not int.
1860 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1861 (esprintf, exprintf, evxprintf): New decls.
1862 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1863
1864 * dbusbind.c (signature_cat): New function.
1865 (xd_signature, Fdbus_register_signal):
1866 Do not overrun buffer; instead, report string overflow.
1867
1868 * dispnew.c (add_window_display_history): Don't overrun buffer.
1869 Truncate instead; this is OK since it's just a log.
1870
1871 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1872 even if the time zone offset is outlandishly large.
1873 Don't mishandle offset == INT_MIN.
1874
1875 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1876 when creating daemon; the previous buffer-overflow check was incorrect.
1877
1878 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1879 which has the guts of the old verror function.
1880
1881 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1882 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1883
1884 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1885 (font_unparse_xlfd): Don't blindly alloca long strings.
1886 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1887 fits in int, when using sprintf. Use single snprintf to count
1888 length of string rather than counting it via multiple sprintfs;
1889 that's simpler and more reliable.
1890 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1891 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1892 sprintf, in case result does not fit in int.
1893
1894 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1895 (fontset_from_font): Print it.
1896
1897 * frame.c (tty_frame_count): Now printmax_t, not int.
1898 (make_terminal_frame, set_term_frame_name): Print it.
1899 (x_report_frame_params): In X, window IDs are unsigned long,
1900 not signed long, so print them as unsigned.
1901 (validate_x_resource_name): Check for implausibly long names,
1902 and don't assume name length fits in 'int'.
1903 (x_get_resource_string): Don't blindly alloca invocation name;
1904 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1905 not fit in int.
1906
1907 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1908 (xg_check_special_colors, xg_set_geometry):
1909 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1910
1911 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1912 Use esprintf, not sprintf, in case result does not fit in int.
1913
1914 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1915 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1916 it as a large positive number.
1917 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1918 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1919
1920 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1921 in case result does not fit in int.
1922
1923 * print.c (float_to_string): Detect width overflow more reliably.
1924 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1925 buffer overrun. Don't assume list length fits in 'int'. Treat
1926 print length of 0 as 0, not as infinity; to be consistent with other
1927 uses of print length in this function. Don't overflow print length
1928 index. Don't assume hash table size fits in 'long', or that
1929 vectorlike size fits in 'unsigned long'.
1930
1931 * process.c (make_process): Use printmax_t, not int, to format
1932 process-name gensyms.
1933
1934 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1935
1936 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1937 to avoid potential buffer overrun.
1938
1939 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1940 if X resource line is longer than 512 bytes.
1941
1942 * xfns.c (x_window): Make sprintf buffer a bit bigger
1943 to avoid potential buffer overrun.
1944
1945 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1946
1947 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1948
1949 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1950
1951 Integer overflow fixes for scrolling, etc.
1952 Without these, Emacs silently mishandles large integers sometimes.
1953 For example, "C-u 4294967297 M-x recenter" was treated as if
1954 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1955
1956 * xdisp.c (try_window_id): Check Emacs fixnum range before
1957 converting to 'int'.
1958
1959 * window.c (window_scroll_line_based, Frecenter):
1960 Check that an Emacs fixnum is in range before assigning it to 'int'.
1961 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1962 values converted from Emacs fixnums.
1963 (Frecenter): Don't wrap around a line count if it is out of 'int'
1964 range; instead, treat it as an extreme value.
1965 (Fset_window_configuration, compare_window_configurations):
1966 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1967
1968 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1969 that can exceed INT_MAX. Check that EMACS_INT value is in range
1970 before assigning it to the (possibly-narrower) index.
1971 (match_limit): Don't assume that a fixnum can fit in 'int'.
1972
1973 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1974 exceed INT_MAX.
1975
1976 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1977 (Fvertical_motion): Don't wrap around LINES values that don't fit
1978 in 'int'. Instead, treat them as extreme values. This is good
1979 enough for windows, which can't have more than INT_MAX lines anyway.
1980
1981 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1982
1983 * Require libxml/parser.h to avoid compilation warning.
1984
1985 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1986
1987 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1988 since this reportedly can destroy thread storage.
1989
1990 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1991
1992 * syntax.c (find_defun_start): Update all cache variables if
1993 exiting early (Bug#9401).
1994
1995 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1996
1997 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1998
1999 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2000 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2001 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2002
2003 * term.c (tty_append_glyph): New function.
2004 (produce_stretch_glyph): Static function and its prototype deleted.
2005
2006 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2007 Add prototypes.
2008
2009 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2010
2011 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2012 when checking :margin (Bug#9390).
2013 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2014 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2015 so that the name doesn't mislead. All uses changed.
2016
2017 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2018
2019 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2020 set_tty_hooks.
2021
2022 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2023
2024 * xdisp.c (move_it_to): Don't bail out early when reaching
2025 position beyond to_charpos, if we are scanning backwards.
2026 (move_it_vertically_backward): When DY == 0, make sure we get to
2027 the first character in the line after the newline.
2028
2029 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2030
2031 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2032 (ccl_driver): Do not generate an out-of-range pointer.
2033 (Fccl_execute_on_string): Remove unnecessary check for
2034 integer overflow, noted by Stefan Monnier in
2035 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2036 Remove a FIXME that didn't need fixing.
2037 Simplify the newly-introduced buffer reallocation code.
2038
2039 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2040
2041 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2042
2043 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2044
2045 Integer and memory overflow issues (Bug#9196).
2046
2047 * doc.c (get_doc_string): Rework so that
2048 get_doc_string_buffer_size is the actual buffer size, rather than
2049 being 1 less than the actual buffer size; this makes xpalloc more
2050 convenient.
2051
2052 * image.c (x_allocate_bitmap_record, cache_image):
2053 * xselect.c (Fx_register_dnd_atom):
2054 Simplify previous changes by using xpalloc.
2055
2056 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2057 since either will do and ptrdiff_t is convenient with xpalloc.
2058
2059 * charset.c (charset_table_size)
2060 (struct charset_sort_data.priority): Now ptrdiff_t.
2061 (charset_compare): Don't overflow if priorities differ greatly.
2062 (Fsort_charsets): Don't assume list length fits in int.
2063 Check for size-calculation overflow when allocating sort data.
2064 (syms_of_charset): Allocate an initial charset table that is
2065 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2066
2067 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2068
2069 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2070 The actual value is always <= INT_MAX, and leaving it unsigned made
2071 overflow checking harder.
2072
2073 * dispextern.h (struct glyph_matrix.rows_allocated)
2074 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2075 with xpalloc. The values are still always <= INT_MAX.
2076
2077 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2078
2079 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2080 (SAFE_NALLOCA): New macro.
2081
2082 * region-cache.c (struct boundary.pos, find_cache_boundary)
2083 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2084 (set_cache_region, invalidate_region_cache)
2085 (revalidate_region_cache, know_region_cache, region_cache_forward)
2086 (region_cache_backward, pp_cache):
2087 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2088 so that ptrdiff_t * can be passed to xpalloc.
2089 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2090 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2091 (pp_cache): Don't assume cache_len fits in int.
2092 * region-cache.h: Adjust extern decls to match.
2093
2094 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2095 EMACS_INT, since either will do, for xpalloc.
2096
2097 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2098 (xnmalloc, xnrealloc, xpalloc): New functions.
2099
2100 * bidi.c (bidi_shelve_header_size): New constant.
2101 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2102 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2103
2104 * bidi.c (bidi_cache_shrink):
2105 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2106 (overlay_strings):
2107 Don't update size of array until after memory allocation succeeds,
2108 because xmalloc/xrealloc may not return.
2109 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2110 now that we have proper integer overflow checking.
2111 (record_overlay_string, overlay_strings): Catch overflows when
2112 calculating size of overlay_str_buf.
2113
2114 * callproc.c (Fcall_process): Check for size overflow when
2115 calculating size of args2.
2116 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2117 Normally we prefer signed values, but sticking with ptrdiff_t would
2118 require adding more-complicated checks.
2119
2120 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2121 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2122 Redo buffer-overflow calculations to avoid integer overflow.
2123 Add a FIXME comment where memory seems to be over-allocated.
2124
2125 * character.c (Fstring): Check for size-calculation overflow.
2126
2127 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2128 unnecessary integer overflow. Check for size overflow.
2129 (encode_coding_object): Don't update size until xmalloc succeeds.
2130
2131 * composite.c (get_composition_id): Check for overflow in glyph
2132 length calculations.
2133
2134 Integer and memory overflow fixes for display code.
2135 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2136 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2137 (scrolling_window): Check for overflow in size calculations.
2138 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2139 Don't assume glyph table len fits in int.
2140 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2141 (row_table_size): Now ptrdiff_t, not int.
2142 (scrolling_window): Avoid overflow in size calculations.
2143 Don't update size until allocation succeeds.
2144 * fns.c (concat): Check for overflow in size calculations.
2145 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2146 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2147 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2148
2149 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2150 (get_doc_string): Check for size calculation overflow.
2151 Don't update size until allocation succeeds.
2152 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2153 EMACS_INT, where ptrdiff_t will do.
2154 (Fsubstitute_command_keys): Check for string overflow.
2155
2156 * editfns.c (set_time_zone_rule): Don't assume environment length
2157 fits in int.
2158 (message_length): Now ptrdiff_t, not int.
2159 (Fmessage_box): Don't update size until allocation succeeds.
2160 Don't assume message length fits in int.
2161 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2162
2163 * emacs.c (main): Do not reallocate argv, since there is a null at
2164 the end that can be overwritten, and this way there's no need to
2165 worry about size-calculation overflow.
2166 (sort_args): Check for size-calculation overflow.
2167
2168 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2169 alloc succeeds.
2170 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2171
2172 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2173 (x_set_scroll_bar_width, x_figure_window_size):
2174 Check for integer overflow.
2175 (x_set_alpha): Do not assume XINT fits in int.
2176
2177 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2178 This is for the members text_lines, text_cols, total_lines, total_cols,
2179 where the system imposes an 'int' limit.
2180
2181 * fringe.c (Fdefine_fringe_bitmap):
2182 Don't update size until alloc works.
2183
2184 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2185 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2186
2187 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2188 Check for size-calculation overflow.
2189 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2190 do, as we prefer signed integers.
2191 (id_to_widget.max_size, id_to_widget.used)
2192 (xg_store_widget_in_map, xg_remove_widget_from_map)
2193 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2194 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2195 Use and return ptrdiff_t, not int.
2196 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2197 * gtkutil.h: Change prototypes to match the above.
2198
2199 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2200 are duplicate now that they've been promoted to lisp.h.
2201 (x_allocate_bitmap_record, x_alloc_image_color)
2202 (make_image_cache, cache_image, xpm_load):
2203 Don't update size until alloc is done.
2204 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2205 (x_detect_edges):
2206 Check for size calculation overflow.
2207 (ct_colors_allocated_max): New constant.
2208 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2209 overflow.
2210
2211 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2212 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2213 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2214 Use ptrdiff_t, not int, to count maps.
2215 (read_char_minibuf_menu_prompt): Check for overflow in size
2216 calculations. Don't update size until allocation succeeds.
2217 Redo calculations to avoid overflow.
2218 * keyboard.h: Change prototypes to match the above.
2219
2220 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2221 to count maps.
2222 (current_minor_maps): Check for size calculation overflow.
2223 * keymap.h: Change prototypes to match the above.
2224
2225 * lread.c (read1, init_obarray): Don't update size until alloc done.
2226
2227 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2228 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2229
2230 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2231 Now ptrdiff_t, not int.
2232 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2233 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2234
2235 * process.c (Fnetwork_interface_list): Check for overflow
2236 in size calculation.
2237
2238 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2239
2240 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2241 overflow. Don't bother calling xmalloc when xrealloc will do.
2242
2243 * search.c (Freplace_match): Check for size calculation overflow.
2244 (Fset_match_data): Don't assume list lengths fit in 'int'.
2245
2246 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2247 for command line length. Do not attempt to address one before the
2248 beginning of an array, as that's not portable.
2249
2250 * term.c (max_frame_lines): Remove; unused.
2251 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2252 not int.
2253 (encode_terminal_code, calculate_costs): Check for size
2254 calculation overflow.
2255 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2256 table lengths and related sizes. Don't update size until alloc
2257 done. Redo calculations to avoid overflow.
2258 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2259
2260 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2261 subtracting pointers.
2262 (gobble_line): Check for overflow more carefully. Don't update size
2263 until alloc done.
2264
2265 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2266 Don't update size until alloc done.
2267 Redo size calculations to avoid overflow.
2268 Check for size calculation overflow.
2269 (main) [DEBUG]: Fix typo in invoking tparam1.
2270
2271 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2272 Use ptrdiff_t, not int, for sizes.
2273 (store_mode_line_noprop_char): Don't update size until alloc done.
2274
2275 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2276 Use ptrdiff_t, not int, for sizes.
2277 (Finternal_make_lisp_face, cache_face):
2278 Check for size calculation overflow.
2279 (cache_face): Treat size calculation overflows as if they were
2280 memory exhaustion (the usual treatment), rather than aborting.
2281
2282 * xfns.c (x_encode_text, x_set_name_internal)
2283 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2284 sizes, since they can exceed INT_MAX in size. Check for size
2285 calculation overflow.
2286
2287 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2288 (xg_select): Check for size calculation overflow.
2289 Don't update size until alloc done.
2290
2291 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2292 as sprintf is limited to int lengths.
2293
2294 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2295 (X_LONG_MIN): New macros.
2296 Use them to make the following changes clearer.
2297 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2298 This change doesn't affect the value now, but it may help remind
2299 future maintainers not to raise the value too much later.
2300 (SELECTION_QUANTUM): Remove, replacing with ...
2301 (selection_quantum): ... new function, which avoids overflow.
2302 All uses changed.
2303 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2304 assumption that selection length fits in 'int'.
2305 (x_reply_selection_request, x_handle_selection_request)
2306 (x_get_window_property, receive_incremental_selection)
2307 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2308 (lisp_data_to_selection_data, clean_local_selection_data):
2309 Use ptrdiff_t, not int, to record length of selection.
2310 (x_reply_selection_request, x_get_window_property)
2311 (receive_incremental_selection, x_property_data_to_lisp):
2312 Redo calculations to avoid overflow.
2313 (x_reply_selection_request): When sending hint, ceiling it at
2314 X_LONG_MAX rather than relying on wraparound overflow to send
2315 something.
2316 (x_get_window_property, receive_incremental_selection)
2317 (lisp_data_to_selection_data, x_property_data_to_lisp):
2318 Check for size-calculation overflow.
2319 (x_get_window_property, receive_incremental_selection)
2320 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2321 Don't store size until memory allocation succeeds.
2322 (x_get_window_property): Plug memory leak on memory exhaustion.
2323 Don't double-block input; malloc is safe here. Don't assume 2**34
2324 - 4 fits in unsigned long. Add an xassert to check
2325 XGetWindowProperty overflow. Be more careful about overflow
2326 calculations, and distinguish size from memory overflow better.
2327 (receive_incremental_selection): When tracing, don't assume
2328 unsigned int is less than INT_MAX.
2329 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2330 harmful) conversions of unsigned short to int.
2331 (lisp_data_to_selection_data): Don't assume that integers
2332 in the range -65535 through -1 fit in an X unsigned short.
2333 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2334 result parameters unless successful. Rely on cons_to_unsigned
2335 to report problems with elements; the old code wasn't right anyway.
2336 (x_check_property_data): Check for int overflow; we cannot use
2337 a wider type due to X limits.
2338 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2339
2340 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2341
2342 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2343 (x_term_init): Check for size calculation overflow.
2344 (x_color_cells): Don't store size until memory allocation succeeds.
2345 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2346 Don't assume alloca size is less than MAX_ALLOCA.
2347 (x_term_init): Don't assume length fits in int (sprintf is limited
2348 to int size).
2349
2350 Use ptrdiff_t for composition IDs.
2351 * character.c (lisp_string_width):
2352 * composite.c (composition_table_size, n_compositions)
2353 (get_composition_id, composition_gstring_from_id):
2354 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2355 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2356 * window.c (Frecenter):
2357 Use ptrdiff_t, not int, for composition IDs.
2358 * composite.c (get_composition_id): Check for integer overflow.
2359 * composite.h: Adjust prototypes to match the above changes.
2360
2361 Use ptrdiff_t for hash table indexes.
2362 * category.c (hash_get_category_set):
2363 * ccl.c (ccl_driver):
2364 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2365 * coding.c (coding_system_charset_list, detect_coding_system):
2366 * coding.h (struct coding_system.id):
2367 * composite.c (get_composition_id, gstring_lookup_cache):
2368 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2369 * image.c (xpm_get_color_table_h):
2370 * lisp.h (hash_lookup, hash_put):
2371 * minibuf.c (Ftest_completion):
2372 Use ptrdiff_t for hash table indexes, not int (which is too
2373 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2374 32-bit --with-wide-int hosts).
2375
2376 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2377 Add a FIXME comment about memory leaks.
2378 (syms_of_charset): Don't assume xmalloc returns.
2379
2380 Don't assume that stated character widths fit in int.
2381 * character.c (Fchar_width, c_string_width, lisp_string_width):
2382 * character.h (CHAR_WIDTH):
2383 * indent.c (MULTIBYTE_BYTES_WIDTH):
2384 Use sanitize_char_width to avoid undefined and/or bad behavior
2385 with outlandish widths.
2386 * character.h (sanitize_tab_width): Rename from sanitize_width,
2387 now that we have two such functions. All uses changed.
2388 (sanitize_char_width): New inline function.
2389
2390 Don't assume that tab-width fits in int.
2391 * character.h (sanitize_width): New inline function.
2392 (SANE_TAB_WIDTH): New macro.
2393 (ASCII_CHAR_WIDTH): Use it.
2394 * indent.c (sane_tab_width): Remove. All uses replaced by
2395 SANE_TAB_WIDTH (current_buffer).
2396 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2397
2398 * fileio.c: Integer overflow issues with file modes.
2399 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2400
2401 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2402 Remove unreachable code.
2403 (read_hex, load_charset_map_from_file): Check for integer overflow.
2404
2405 * xterm.c: Don't go over XClientMessageEvent limit.
2406 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2407 (x_send_scroll_bar_event): Likewise. Check that the size does not
2408 exceed limits imposed by XClientMessageEvent, as well as the usual
2409 ptrdiff_t and size_t limits.
2410
2411 * keyboard.c: Overflow, signedness and related fixes.
2412 (make_lispy_movement): Use same integer type in forward decl
2413 that is used in the definition.
2414 (read_key_sequence, keyremap_step):
2415 Change bufsize argument back to int, undoing my 2011-03-30 change.
2416 We prefer signed types, and int is wide enough here.
2417 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2418 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2419 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2420 length, not size_t. Use ptrdiff_t for index, not int.
2421 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2422 possibility of integer overflow.
2423
2424 Overflow, signedness and related fixes for images.
2425
2426 * dispextern.h (struct it.stack[0].u.image.image_id)
2427 (struct_it.image_id, struct image.id, struct image_cache.size)
2428 (struct image_cache.used, struct image_cache.ref_count):
2429 * gtkutil.c (update_frame_tool_bar):
2430 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2431 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2432 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2433 * nsmenu.m (update_frame_tool_bar):
2434 * xdisp.c (calc_pixel_width_or_height):
2435 * xfns.c (image_cache_refcount):
2436 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2437 on typical 64-bit hosts.
2438
2439 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2440 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2441 Omit unnecessary casts to int.
2442 (parse_image_spec): Check that integers fall into 'int' range
2443 when the callers expect that.
2444 (image_ascent): Redo ascent calculation to avoid int overflow.
2445 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2446 (lookup_image): Remove unnecessary tests.
2447 (xbm_image_p): Locals are now of int, not EMACS_INT,
2448 since parse_image_check makes sure they fit into int.
2449 (png_load, gif_load, svg_load_image):
2450 Prefer int to unsigned where either will do.
2451 (tiff_handler): New function, combining the cores of the
2452 old tiff_error_handler and tiff_warning_handler.
2453 This function is rewritten to use vsnprintf and thereby avoid
2454 stack buffer overflows. It uses only the features of vsnprintf
2455 that are common to both POSIX and native Microsoft.
2456 (tiff_error_handler, tiff_warning_handler): Use it.
2457 (tiff_load, gif_load, imagemagick_load_image):
2458 Don't assume :index value fits in 'int'.
2459 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2460 (imagemagick_load_image): Check that crop parameters fit into
2461 the integer types that MagickCropImage accepts. Don't assume
2462 Vimagemagick_render_type has a nonnegative value. Don't assume
2463 size_t fits in 'long'.
2464 (gs_load): Use printmax_t to print the widest integers possible.
2465 Check for integer overflow when computing image height and width.
2466
2467 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2468
2469 * xdisp.c (redisplay_window): Don't force window start if point
2470 will be invisible in the resulting window. (Bug#9324)
2471
2472 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2473
2474 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2475 the display spec is of the form `(space ...)'.
2476 (handle_display_spec): Return the value returned by
2477 handle_single_display_spec, not just 1 or zero.
2478 (handle_single_display_spec): If the display spec is of the form
2479 `(space ...)', and specifies display in the text area, return 2
2480 rather than 1.
2481 (try_cursor_movement): Check for the need to scroll more
2482 accurately, and prefer exact match for point under bidi.
2483 Don't advance `row' beyond the last row of the window.
2484
2485 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2486 into disp_prop; all users changed.
2487
2488 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2489 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2490 for the text covered by the display property.
2491
2492 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2493
2494 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2495 Change return value to nil.
2496 (Frecord_buffer): Delete unused function.
2497
2498 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2499
2500 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2501 buffers, return left-to-right.
2502 (set_cursor_from_row): Consider candidate row a win if its glyph
2503 represents a newline and point is on that newline. Fixes cursor
2504 positioning on the newline at EOL of R2L text within L2R
2505 paragraph, and vice versa.
2506 (try_cursor_movement): Check continued rows, in addition to
2507 continuation rows. Fixes unwarranted scroll when point enters a
2508 continued line of R2L text within an L2R paragraph, or vice versa.
2509 (cursor_row_p): Consider the case of point being equal to
2510 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2511 from the end of a short line to the beginning of a continued line
2512 of R2L text within L2R paragraph.
2513 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2514 composed characters.
2515
2516 * bidi.c (bidi_check_type): Use xassert.
2517 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2518 members.
2519
2520 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2521
2522 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2523 a character.
2524
2525 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2526
2527 * nsfont.m (ns_otf_to_script): Fix typo.
2528
2529 2011-08-22 Kenichi Handa <handa@m17n.org>
2530
2531 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2532 extra slot even if the purpose is char-code-property-table.
2533
2534 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2535
2536 * xdisp.c (redisplay_window): When computing centering_position,
2537 account for the height of the header line. (Bug#8874)
2538
2539 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2540 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2541 candidate is selected by the mouse, and that candidate has a
2542 composed character under the mouse.
2543
2544 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2545 coordinates reported by pos-visible-in-window-p for a composed
2546 character in column zero.
2547
2548 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2549
2550 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2551
2552 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2553
2554 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2555 consider it a hit if to_charpos is anywhere in the range of the
2556 composed buffer positions.
2557
2558 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2559
2560 * image.c (gif_load): Don't assume that each subimage has the same
2561 dimensions as the base image. Handle disposal method that is
2562 "undefined" by the gif spec (Bug#9335).
2563
2564 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2565
2566 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2567 (Fcondition_case): Document `debug' symbol in error handler.
2568
2569 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2570
2571 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2572 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2573 from an Org mode buffer to a Speedbar frame.
2574
2575 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2576 a composition, take its buffer position from IT->cmp_it.charpos.
2577 Fixes cursor positioning at the beginning of a line that begins
2578 with a composed character.
2579
2580 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2581
2582 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2583 character bidirectional type, use STRONG_L instead. Fixes crashes
2584 in a buffer produced by `describe-categories'.
2585
2586 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2587 members before the level stack, so they would be saved and
2588 restored when copying iterator state. Fixes incorrect reordering
2589 around TABs covered by display properties.
2590
2591 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2592
2593 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2594
2595 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2596
2597 * eval.c (internal_condition_case, internal_condition_case_1)
2598 (internal_condition_case_2, internal_condition_case_n):
2599 Remove unnecessary aborts (Bug#9081).
2600
2601 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2602
2603 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2604 has no `load' handler, try opening the file locally. (Bug#9311)
2605
2606 2011-08-16 Ken Brown <kbrown@cornell.edu>
2607
2608 * gmalloc.c: Expand comment.
2609
2610 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2611
2612 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2613 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2614
2615 2011-08-16 Ken Brown <kbrown@cornell.edu>
2616
2617 Fix memory allocation problems in Cygwin build (Bug#9273).
2618
2619 * unexcw.c ( __malloc_initialized): Declare external variable.
2620 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2621
2622 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2623 New variables.
2624 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2625 dumped emacs.
2626 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2627 in the static heap.
2628 [CYGWIN] (special_realloc): New function.
2629 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2630 requests to realloc storage in the static heap.
2631
2632 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2633
2634 * bidi.c (bidi_initialize): Remove unused local.
2635
2636 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2637
2638 * bidimirror.h:
2639 * biditype.h: Remove file.
2640 * makefile.w32-in ($(BLD)/bidi.$(O)):
2641 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2642
2643 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2644
2645 * chartab.c: Improve commentary for the uniprop_table API.
2646
2647 * bidi.c (bidi_paragraph_init): Support zero value of
2648 bidi_ignore_explicit_marks_for_paragraph_level.
2649 (bidi_initialize): Use uniprop_table instead of including
2650 biditype.h and bidimirror.h.
2651
2652 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2653 coordinates of the iterator when restoring from ppos_it.
2654 (Bug#9296)
2655
2656 2011-08-14 Kenichi Handa <handa@m17n.org>
2657
2658 * process.c (create_process): Call setup_process_coding_systems
2659 after the pid of the process is set to -1 (Bug#8162).
2660
2661 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2662
2663 * xdisp.c (move_it_in_display_line_to): Don't invoke
2664 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2665 ppos_it. Fixes vertical cursor motion when line beginning is
2666 covered by an image. (Bug#9296)
2667
2668 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2669
2670 * nsterm.h (ns_run_ascript): Declare.
2671 (NSAPP_DATA2_RUNASSCRIPT): Define.
2672
2673 * nsfns.m (as_script, as_result, as_status): New static variables.
2674 (ns_run_ascript): New function.
2675 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2676 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2677 the event loop. Get status from as_status (Bug#7276).
2678
2679 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2680 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2681 the event loop (Bug#7276).
2682
2683 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2684
2685 * gnutls.c (QCgnutls_bootprop_priority)
2686 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2687 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2688 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2689 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2690 (QCgnutls_bootprop_verify_hostname_error)
2691 (QCgnutls_bootprop_callbacks_verify): Rename from
2692 Qgnutls_bootprop_..., all uses changed.
2693
2694 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2695 uses changed.
2696
2697 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2698
2699 * xfaces.c (Qframe_set_background_mode): Now static.
2700 * dispextern.h (Qframe_set_background_mode): Remove decl.
2701
2702 * process.c (Fnetwork_interface_info): Declare local only if needed.
2703
2704 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2705
2706 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2707 (Fnetwork_interface_list): Allocate in increments of bytes instead
2708 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2709 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2710 sockaddr.
2711 (struct ifflag_def): notrailers is smart on OSX.
2712 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2713 Get hardware address with getifaddrs if available.
2714
2715 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2716
2717 * xdisp.c (iterate_out_of_display_property): xassert that
2718 IT->position is set to within IT->object's boundaries. Break from
2719 the loop as soon as EOB is reached; avoids infloops in redisplay
2720 when IT->position is set up wrongly due to some bug.
2721 Set IT->current to match the bidi iterator unconditionally.
2722 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2723 entry. Force push_it to save on the stack the current
2724 buffer/string position, to be restored by pop_it. Fix flags in
2725 the iterator structure wrt the object coming from a display
2726 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2727 properties. (Bug#9284)
2728
2729 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2730
2731 * fontset.c (fontset_get_font_group): Add proper type checks.
2732 (Bug#9172)
2733
2734 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2735
2736 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2737 and LC_VERSION_MIN_MACOSX.
2738 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2739 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2740
2741 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2742
2743 * xdisp.c (forward_to_next_line_start): Allow to use the
2744 no-display-properties-and-no-overlays under bidi display.
2745 Set disp_pos in the bidi iterator to avoid searches for display
2746 properties and overlays.
2747
2748 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2749
2750 * editfns.c (Fset_time_zone_rule): Document relationship with the
2751 setenv function.
2752
2753 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2754 the font entity extracted from the cache (Bug#8109).
2755
2756 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2757
2758 * composite.c (autocmp_chars): Don't reset point. That is done by
2759 restore_point_unwind (Bug#5984).
2760
2761 2011-08-07 Juri Linkov <juri@jurta.org>
2762
2763 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2764 to show the arg `TIME' instead of `TIMEVAL'.
2765
2766 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2767
2768 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2769 display property strides EOL and includes a newline, as in
2770 longlines-mode. (Bug#9254)
2771 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2772 word-wrap under bidirectional display. (Bug#9224)
2773
2774 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2775 is non-zero, even if the data buffer is NULL. Fixes a crash in
2776 vertical-motion with longlines-mode. (Bug#9254)
2777
2778 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2779
2780 * bidi.c <bidi_cache_total_alloc>: Now static.
2781 (bidi_initialize): Initialize bidi_cache_total_alloc.
2782
2783 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2784 cache. (Bug#9221)
2785
2786 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2787 amount allocated this far in `bidi_cache_total_alloc'.
2788 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2789 non-zero, only free the data buffer without restoring the cache
2790 contents. All callers changed.
2791
2792 * dispextern.h (bidi_unshelve_cache): Update prototype.
2793
2794 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2795 (move_it_in_display_line, move_it_to)
2796 (move_it_vertically_backward, move_it_by_lines): Replace the call
2797 to xfree to an equivalent call to bidi_unshelve_cache.
2798 (move_it_in_display_line_to): Fix logic of returning
2799 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2800
2801 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2802
2803 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2804 came from a string character with a `cursor' property. (Bug#9229)
2805
2806 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2807
2808 * Makefile.in (LIB_PTHREAD): New variable.
2809 (LIBES): Add LIB_PTHREAD (Bug#9216).
2810
2811 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2812 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2813
2814 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2815
2816 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2817
2818 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2819
2820 * xterm.c (x_find_topmost_parent): New function.
2821 (x_set_frame_alpha): Find topmost parent window with
2822 x_find_topmost_parent and set the property there also (bug#9181).
2823 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2824
2825 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2826
2827 * callproc.c (Fcall_process): Avoid vfork clobbering
2828 the local vars buffer, coding_systems, current_dir.
2829
2830 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2831
2832 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2833
2834 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2835
2836 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2837 so that it is not optimized away.
2838
2839 * xdisp.c (compute_display_string_pos): Remove unused local.
2840
2841 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2842
2843 Fix slow cursor motion and scrolling in large buffers with
2844 selective display, like Org Mode buffers. (Bug#9218)
2845
2846 * dispextern.h (struct bidi_it): New member disp_prop_p.
2847
2848 * xdisp.c: Remove one-slot cache of display string positions.
2849 (compute_display_string_pos): Accept an additional argument
2850 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2851 for a display string or property. If found, set DISP_PROP_P
2852 non-zero.
2853
2854 * bidi.c (bidi_fetch_char): Accept an additional argument
2855 DISP_PROP_P, and pass it to compute_display_string_pos.
2856 Only handle text covered by a display string if DISP_PROP_P is returned
2857 non-zero. All callers of bidi_fetch_char changed.
2858
2859 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2860
2861 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2862
2863 2010-12-03 Don March <don@ohspite.net>
2864
2865 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2866 last character M-[char] is translated to ESC [char] (bug#7541).
2867
2868 2011-08-02 Kenichi Handa <handa@m17n.org>
2869
2870 * lisp.h (uniprop_table): Extern it.
2871
2872 * chartab.c (uniprop_table): Make it non-static.
2873
2874 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2875
2876 * xdisp.c (forward_to_next_line_start): Accept additional argument
2877 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2878 on the newline.
2879 (reseat_at_next_visible_line_start): Use the bidi iterator state
2880 returned by forward_to_next_line_start to restore the state of
2881 it->bidi_it after backing up to previous newline. (Bug#9212)
2882
2883 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2884
2885 * regex.c (re_comp): Protoize.
2886 (re_exec): Fix return type.
2887 (regexec): Fix type of `ret'. (Bug#9203)
2888
2889 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2890
2891 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2892 This is needed if max-image-size is a floating-point number.
2893
2894 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2895
2896 * print.c (print_object): Print empty symbol as ##.
2897
2898 * lread.c (read1): Read ## as empty symbol.
2899
2900 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2901
2902 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2903 setting frame foreground color (Bug#9175).
2904 (x_set_background_color): Likewise.
2905
2906 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2907 contents (Bug#9176).
2908 (EmacsTooltip -init): Remove bezels and add shadows to
2909 tooltip windows.
2910
2911 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2912 or scroll bar (Bug#8470).
2913
2914 * nsfont.m (nsfont_open): Remove assignment to voffset and
2915 unnecessary vars hshink, expand, hd, full_height, min_height.
2916 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2917
2918 * nsterm.h (nsfont_info): Remove voffset field.
2919
2920 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2921
2922 Implement strike-through and overline on NextStep (Bug#8863).
2923
2924 * nsfont.m (nsfont_open): Use underline position provided by font,
2925 instead of hard-coded value of 2.
2926 (nsfont_draw): Call ns_draw_text_decoration instead.
2927
2928 * nsterm.h: Add declaration for ns_draw_text_decoration.
2929
2930 * nsterm.m (ns_draw_text_decoration): New function for drawing
2931 underline, overline, and strike-through.
2932 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2933 ns_draw_text_decoration. Change treatment of cursor drawing to
2934 accommodate underlining, etc.
2935
2936 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2937
2938 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2939 default.
2940
2941 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2942
2943 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2944 Without this fix, if a signal arrives just after memory fills up,
2945 'malloc' might be invoked reentrantly.
2946
2947 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2948 In other words, assume that every image size is allowed, on non-X
2949 hosts. This assumption is probably wrong, but it lets Emacs compile.
2950
2951 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2952
2953 * regex.c (re_iswctype): Convert return values to boolean.
2954
2955 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2956
2957 * xdisp.c (compute_display_string_pos): Don't use cached display
2958 string position if the buffer had its restriction changed.
2959 (Bug#9184)
2960
2961 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2962
2963 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2964
2965 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2966
2967 Integer signedness and overflow and related fixes. (Bug#9079)
2968
2969 * bidi.c: Integer size and overflow fixes.
2970 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2971 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2972 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2973 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2974 (bidi_find_other_level_edge):
2975 Use ptrdiff_t instead of EMACS_INT where either will do.
2976 This works better on 32-bit hosts configured --with-wide-int.
2977 (bidi_cache_ensure_space): Check for size-calculation overflow.
2978 Use % rather than repeated addition, for better worst-case speed.
2979 Don't set bidi_cache_size until after xrealloc returns, because it
2980 might not return.
2981 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2982 (bidi_cache_ensure_space): Also check that the bidi cache size
2983 does not exceed that of the largest Lisp string or buffer. See Eli
2984 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2985
2986 * alloc.c (__malloc_size_t): Remove.
2987 All uses replaced by size_t. See Andreas Schwab's note
2988 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2989
2990 * image.c: Improve checking for integer overflow.
2991 (check_image_size): Assume that f is nonnull, since
2992 it is always nonnull in practice. This is one less thing to
2993 worry about when checking for integer overflow later.
2994 (x_check_image_size): New function, which checks for integer
2995 overflow issues inside X.
2996 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2997 This removes the need for a memory_full check.
2998 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2999 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3000 (xbm_read_bitmap_data): Change locals back to 'int', since
3001 their values must fit in 'int'.
3002 (xpm_load_image, png_load, tiff_load):
3003 Invoke x_create_x_image_and_pixmap earlier,
3004 to avoid much needless work if the image is too large.
3005 (tiff_load): Treat overly large images as if
3006 x_create_x_image_and_pixmap failed, not as malloc failures.
3007 (gs_load): Use x_check_image_size.
3008
3009 * gtkutil.c: Omit integer casts.
3010 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3011 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3012
3013 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3014
3015 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3016 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3017 would wrongly return t on a 64-bit host.
3018
3019 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3020 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3021 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3022 and therefore cause GCC to emit a bogus diagnostic in some cases.
3023
3024 * image.c: Integer signedness and overflow and related fixes.
3025 This is not an exhaustive set of fixes, but it's time to
3026 record what I've got.
3027 (lookup_pixel_color, check_image_size): Remove redundant decls.
3028 (check_image_size): Don't assume that arbitrary EMACS_INT values
3029 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3030 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3031 (tiff_load, imagemagick_load_image):
3032 Check for overflow in size calculations.
3033 (x_create_x_image_and_pixmap): Remove unnecessary test for
3034 xmalloc returning NULL; that can't happen.
3035 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3036 (xpm_color_bucket): Use better integer hashing function.
3037 (xpm_cache_color): Don't possibly over-allocate memory.
3038 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3039 (gif_memory_source):
3040 Use ptrdiff_t, not int or size_t, to record sizes.
3041 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3042 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3043 either works, as we prefer signed integers.
3044 (tiff_read_from_memory, tiff_write_from_memory):
3045 Return tsize_t, not size_t, since that's what the TIFF API wants.
3046 (tiff_read_from_memory): Don't fail simply because the read would
3047 go past EOF; instead, return a short read.
3048 (tiff_load): Omit no-longer-needed casts.
3049 (Fimagemagick_types): Don't assume size fits into 'int'.
3050
3051 Improve hashing quality when configured --with-wide-int.
3052 * fns.c (hash_string): New function, taken from sxhash_string.
3053 Do not discard information about ASCII character case; this
3054 discarding is no longer needed.
3055 (sxhash-string): Use it. Change sig to match it. Caller changed.
3056 * lisp.h: Declare it.
3057 * lread.c (hash_string): Remove, since we now use fns.c's version.
3058 The fns.c version returns a wider integer if --with-wide-int is
3059 specified, so this should help the quality of the hashing a bit.
3060
3061 * emacs.c: Integer overflow minor fix.
3062 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3063 Define only if GNU_LINUX.
3064 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3065
3066 * dispnew.c: Integer signedness and overflow fixes.
3067 Remove unnecessary forward decls, that were a maintenance hassle.
3068 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3069 All uses changed.
3070 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3071 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3072 (prepare_desired_row, line_draw_cost):
3073 Use int, not unsigned, where either works.
3074 (save_current_matrix, restore_current_matrix):
3075 Use ptrdiff_t, not size_t, where either works.
3076 (init_display): Check for overflow more accurately, and without
3077 relying on undefined behavior.
3078
3079 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3080 Remove, replacing with the new symbols in lisp.h. All uses changed.
3081 * fileio.c (make_temp_name):
3082 * filelock.c (lock_file_1, lock_file):
3083 * xdisp.c (message_dolog):
3084 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3085 Use pMd etc. instead.
3086 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3087 replacing the pWIDE etc. symbols removed from editfns.c.
3088
3089 * keyboard.h (num_input_events): Now uintmax_t.
3090 This is (very slightly) less likely to mess up due to wraparound.
3091 All uses changed.
3092
3093 * buffer.c: Integer signedness fixes.
3094 (alloc_buffer_text, enlarge_buffer_text):
3095 Use ptrdiff_t rather than size_t when either will do, as we prefer
3096 signed integers.
3097
3098 * alloc.c: Integer signedness and overflow fixes.
3099 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3100 (__malloc_size_t): Default to size_t, not to int.
3101 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3102 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3103 Prefer ptrdiff_t to size_t when either would do, as we prefer
3104 signed integers.
3105 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3106 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3107 Now const. Initialize with values that are in range even if char
3108 is signed.
3109 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3110 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3111 These functions do the right thing with sizes > 2**32.
3112 (check_depth): Now ptrdiff_t, not int.
3113 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3114 Adjust to new way of storing sizes. Check for size overflow bugs
3115 in rest of code.
3116 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3117 slightly wrong anyway, as it missed one instance of
3118 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3119 (refill_memory_reserve): Omit needless cast to size_t.
3120 (mark_object_loop_halt): Mark as externally visible.
3121
3122 * xselect.c: Integer signedness and overflow fixes.
3123 (Fx_register_dnd_atom, x_handle_dnd_message):
3124 Use ptrdiff_t, not size_t, since we prefer signed.
3125 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3126 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3127 x_dnd_atoms_size and x_dnd_atoms_length.
3128
3129 * doprnt.c: Prefer signed to unsigned when either works.
3130 * eval.c (verror):
3131 * doprnt.c (doprnt):
3132 * lisp.h (doprnt):
3133 * xdisp.c (vmessage):
3134 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3135 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3136 prefer signed arithmetic to avoid comparison confusion.
3137 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3138 but is a bit tricky.
3139
3140 Assume freestanding C89 headers, string.h, stdlib.h.
3141 * data.c, doprnt.c, floatfns.c, print.c:
3142 Include float.h unconditionally.
3143 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3144 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3145 * regex.c: Likewise for stddef.h, string.h.
3146 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3147 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3148 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3149 (STDC_HEADERS): Remove obsolete defines.
3150 * sysdep.c: Include limits.h unconditionally.
3151
3152 Assume support for memcmp, memcpy, memmove, memset.
3153 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3154 * regex.c (memcmp, memcpy):
3155 Remove; we assume C89 now.
3156
3157 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3158 (__malloc_safe_bcopy): Remove; no longer needed.
3159
3160 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3161 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3162 well either way, and we prefer signed to unsigned.
3163
3164 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3165
3166 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3167 closes the connection while we're reading (bug#9182).
3168
3169 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3170
3171 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3172 are specified (Bug#9168).
3173
3174 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3175
3176 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3177 Found by GCC static checking and --with-wide-int on a 32-bit host.
3178
3179 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3180
3181 * xdisp.c (compute_display_string_pos): Fix logic of caching
3182 previous display string position. Initialize cached_prev_pos to
3183 -1. Fixes slow-down at the beginning of a buffer.
3184
3185 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3186
3187 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3188 for attrs[LFACE_FONTSET_INDEX].
3189
3190 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3191
3192 * xml.c (parse_region): Remove unused local
3193 that was recently introduced.
3194
3195 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3196
3197 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3198 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3199
3200 * xdisp.c (move_it_in_display_line_to): Record the best matching
3201 position for TO_CHARPOS while scanning the line, and restore it on
3202 exit if none of the characters scanned was an exact match.
3203 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3204 when exact match is impossible due to invisible text, and the
3205 lines are truncated.
3206
3207 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3208
3209 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3210 for OSX >= 10.7.
3211
3212 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3213
3214 Fix a significant slow-down of cursor motion with C-n, C-p,
3215 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3216 auto-repeat under bidi redisplay in fontified buffers.
3217 * xdisp.c (compute_stop_pos_backwards): New function.
3218 (next_element_from_buffer): Call compute_stop_pos_backwards to
3219 find a suitable prev_stop when we find ourselves before
3220 base_level_stop.
3221 (reseat): Don't look for prev_stop, as that could mean a very long
3222 run.
3223 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3224 <cached_disp_overlay_modiff>: Cache for last found display string
3225 position.
3226 (compute_display_string_pos): Return the cached position if asked
3227 about the same buffer in the same area of character positions, and
3228 the buffer wasn't changed since the time the display string
3229 position was cached.
3230
3231 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3232
3233 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3234 is an integer, which is important for empty lines. (Bug#9149)
3235
3236 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3237
3238 * frame.c (Fmodify_frame_parameters): In tty case, update the
3239 default face if necessary (Bug#4238).
3240
3241 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3242
3243 * editfns.c (Fstring_to_char): No need to explain what a character
3244 is in the docstring (Bug#6576).
3245
3246 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3247
3248 * xml.c (parse_region): Make sure we always return a tree.
3249
3250 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3251
3252 * xml.c (parse_region): If a document contains only comments,
3253 return that, too.
3254
3255 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3256
3257 * xml.c (make_dom): Return comments, too.
3258
3259 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3260
3261 Port to OpenBSD.
3262 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3263 and the surrounding thread.
3264 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3265 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3266 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3267 timer goes off.
3268 * s/openbsd.h (BROKEN_SIGIO): Define.
3269 * unexelf.c (unexec) [__OpenBSD__]:
3270 Don't update the .mdebug section of the Alpha COFF symbol table.
3271
3272 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3273
3274 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3275 (bug#8460).
3276
3277 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3278
3279 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3280 This fixes some race conditions on the permissions of any newly
3281 created file.
3282
3283 * alloc.c (valid_pointer_p): Use pipe, not open.
3284 This fixes some permissions issues when debugging.
3285
3286 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3287 If fchown fails to set both uid and gid, try to set just gid,
3288 as that is sometimes allowed. Adjust the file's mode to eliminate
3289 setuid or setgid bits that are inappropriate if fchown fails.
3290
3291 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3292
3293 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3294 to compare Lisp_Objects.
3295 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3296 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3297 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3298
3299 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3300
3301 * lread.c (read_integer): Unread even EOF character.
3302 (read1): Likewise. Properly record start position of symbol.
3303
3304 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3305 symbol character follows.
3306
3307 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3308
3309 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3310 This works around a problem with the previous change to Fcopy_file.
3311 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3312 and without this change, GCC might complain about discarding
3313 fchown's return value.
3314
3315 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3316
3317 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3318
3319 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3320
3321 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3322
3323 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3324
3325 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3326 it's used from the C level.
3327
3328 * process.c: Use the same condition for POLL_FOR_INPUT in both
3329 keyboard.c and process.c (bug#1858).
3330
3331 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3332
3333 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3334 (Fgnutls_boot): Use it.
3335
3336 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3337
3338 * doc.c (Fsubstitute_command_keys): Revert last change.
3339
3340 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3341
3342 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3343 quotes the next character, and doesn't affect other longer
3344 sequences (bug#8935).
3345
3346 * lread.c (syms_of_lread): Clarify that is isn't only
3347 `eval-buffer' and `eval-defun' that's affected by
3348 `lexical-binding' (bug#8460).
3349
3350 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3351
3352 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3353 bidi redisplay when a line includes both an image and is truncated.
3354
3355 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3356
3357 Fix minor problems found by static checking.
3358 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3359 (elsz): Now a signed constant, not a size_t var. We prefer signed
3360 types to unsigned, to avoid integer comparison confusion. Without
3361 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3362 "cannot optimize loop, the loop counter may overflow", a symptom
3363 of the confusion.
3364 * indent.c (Fvertical_motion): Mark locals as initialized.
3365 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3366
3367 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3368
3369 * search.c (Fre_search_backward): Mention `case-fold-search' in
3370 all the re_search_* functions (bug#8138).
3371
3372 * keyboard.c (Fopen_dribble_file): Document when the file is
3373 closed (bug#8056).
3374
3375 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3376
3377 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3378 bidi_cache_idx.
3379
3380 Support bidi reordering of display and overlay strings.
3381 * xdisp.c (compute_display_string_pos)
3382 (compute_display_string_end): Accept additional argument STRING.
3383 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3384 (reseat_to_string): Initialize bidi_it->string.s and
3385 bidi_it->string.schars.
3386 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3387 NULL (avoids a crash in bidi_paragraph_init).
3388 Initialize itb.string.lstring.
3389 (init_iterator): Call bidi_init_it only of a valid
3390 buffer position was specified. Initialize paragraph_embedding to
3391 L2R.
3392 (reseat_to_string): Initialize the bidi iterator.
3393 (display_string): If we need to ignore text properties of
3394 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3395 original value of -1 will not work with bidi.)
3396 (compute_display_string_pos): First arg is now struct
3397 `text_pos *'; all callers changed. Support display properties on
3398 Lisp strings.
3399 (compute_display_string_end): Support display properties on Lisp
3400 strings.
3401 (init_iterator, reseat_1, reseat_to_string): Initialize the
3402 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3403 when iterating on a string not from display properties).
3404 (compute_display_string_pos, compute_display_string_end):
3405 Fix calculation of the object to scan. Fixes an error when using
3406 arrow keys.
3407 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3408 base_level_stop; instead, set base_level_stop to BEGV.
3409 Fixes crashes in vertical-motion.
3410 (next_element_from_buffer): Improve commentary for when
3411 the iterator is before prev_stop.
3412 (init_iterator): Initialize bidi_p from the default value of
3413 bidi-display-reordering, not from buffer-local value. Use the
3414 buffer-local value only if initializing for buffer iteration.
3415 (handle_invisible_prop): Support invisible properties on strings
3416 that are being bidi-reordered.
3417 (set_iterator_to_next): Support bidi reordering of C strings and
3418 Lisp strings.
3419 (next_element_from_string): Support bidi reordering of Lisp
3420 strings.
3421 (handle_stop_backwards): Support Lisp strings as well.
3422 (display_string): Support display of R2L glyph rows.
3423 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3424 (init_iterator): Don't initialize it->bidi_p for strings
3425 here.
3426 (reseat_to_string): Initialize it->bidi_p for strings here.
3427 (next_element_from_string, next_element_from_c_string)
3428 (next_element_from_buffer): Add xassert's for correspondence
3429 between IT's object being iterated and it->bidi_it.string
3430 structure.
3431 (face_before_or_after_it_pos): Support bidi iteration.
3432 (next_element_from_c_string): Handle the case of the first string
3433 character that is not the first one in the visual order.
3434 (get_visually_first_element): New function, refactored from common
3435 parts of next_element_from_buffer, next_element_from_string, and
3436 next_element_from_c_string.
3437 (tool_bar_lines_needed, redisplay_tool_bar)
3438 (display_menu_bar): Force left-to-right direction. Add a FIXME
3439 comment for making that be controlled by a user option.
3440 (push_it, pop_it): Save and restore the state of the
3441 bidi iterator. Save and restore the bidi_p flag.
3442 (pop_it): Iterate out of display property for string iteration as
3443 well.
3444 (iterate_out_of_display_property): Support iteration over strings.
3445 (handle_single_display_spec): Set up it->bidi_it for iteration
3446 over a display string, and call bidi_init_it.
3447 (handle_single_display_spec, next_overlay_string)
3448 (get_overlay_strings_1, push_display_prop): Set up the bidi
3449 iterator for displaying display or overlay strings.
3450 (forward_to_next_line_start): Don't use the shortcut if
3451 bidi-iterating.
3452 (back_to_previous_visible_line_start): If handle_display_prop
3453 pushed the iterator stack, restore the internal state of the bidi
3454 iterator by calling bidi_pop_it same number of times.
3455 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3456 and we are bidi-iterating, don't decrement the iterator position;
3457 instead, set the first_elt flag in the bidi iterator, to produce
3458 the same effect.
3459 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3460 (push_display_prop): xassert that we are iterating a buffer.
3461 (push_it, pop_it): Save and restore paragraph_embedding member.
3462 (handle_single_display_spec, next_overlay_string)
3463 (get_overlay_strings_1, reseat_1, reseat_to_string)
3464 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3465 correctly. Don't assume unibyte strings are not bidi-reordered.
3466 (compute_display_string_pos)
3467 (compute_display_string_end): Fix handling the case of C string.
3468 (push_it, pop_it): Save and restore from_disp_prop_p.
3469 (handle_single_display_spec, push_display_prop): Set the
3470 from_disp_prop_p flag.
3471 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3472 (pop_it): Call iterate_out_of_display_property only if we are
3473 popping after iteration over a string that came from a display
3474 property. Fix a typo in popping stretch info. Add an assertion
3475 for verifying that the iterator position is in sync with the bidi
3476 iterator.
3477 (handle_single_display_spec, get_overlay_strings_1)
3478 (push_display_prop): Fix initialization of paragraph direction for
3479 string when that of the parent object is not yet determined.
3480 (reseat_1): Call bidi_init_it to resync the bidi
3481 iterator with IT's position. (Bug#7616)
3482 (find_row_edges): If ROW->start.pos gives position
3483 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3484 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3485 Reset the from_disp_prop_p flag.
3486 (SAVE_IT, RESTORE_IT): New macros.
3487 (pos_visible_p, face_before_or_after_it_pos)
3488 (back_to_previous_visible_line_start)
3489 (move_it_in_display_line_to, move_it_in_display_line)
3490 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3491 (try_scrolling, redisplay_window, display_line): Use them when
3492 saving a temporary copy of the iterator and restoring it back.
3493 (back_to_previous_visible_line_start, reseat_1)
3494 (init_iterator): Empty the bidi cache "stack".
3495 (move_it_in_display_line_to): If iterator ended up at
3496 EOL, but we never saw any buffer positions smaller than
3497 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3498 motion in bidi-reordered lines.
3499 (move_it_in_display_line_to): Record prev_method and prev_pos
3500 immediately before the call to set_iterator_to_next. Fixes cursor
3501 motion in bidi-reordered lines with stretch glyphs and strings
3502 displayed in margins. (Bug#8133) (Bug#8867)
3503 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3504 TO_CHARPOS.
3505 (pos_visible_p): Support positions in bidi-reordered lines.
3506 Save and restore bidi cache.
3507
3508 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3509 (bidi_paragraph_info): Delete unused struct.
3510 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3511 (bidi_cache_start): New variable.
3512 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3513 to zero.
3514 (bidi_cache_fetch_state, bidi_cache_search)
3515 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3516 (bidi_cache_find, bidi_peek_at_next_level)
3517 (bidi_level_of_next_char, bidi_find_other_level_edge)
3518 (bidi_move_to_visually_next): Compare cache index with
3519 bidi_cache_start rather than with zero.
3520 (bidi_fetch_char): Accept new argument STRING; all callers
3521 changed. Support iteration over a string. Support strings with
3522 display properties. Support unibyte strings. Fix the type of
3523 `len' according to what STRING_CHAR_AND_LENGTH expects.
3524 (bidi_paragraph_init, bidi_resolve_explicit_1)
3525 (bidi_resolve_explicit, bidi_resolve_weak)
3526 (bidi_level_of_next_char, bidi_move_to_visually_next):
3527 Support iteration over a string.
3528 (bidi_set_sor_type, bidi_resolve_explicit_1)
3529 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3530 can now be zero (for strings); special values 0 and -1 were
3531 changed to -1 and -2, respectively.
3532 (bidi_char_at_pos): New function.
3533 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3534 Call it instead of FETCH_MULTIBYTE_CHAR.
3535 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3536 initialized to valid values.
3537 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3538 values.
3539 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3540 the test for valid cached positions. Fix the logic for looking up
3541 the sentinel state in the cache. GCPRO the Lisp string we are
3542 iterating.
3543 (bidi_push_it, bidi_pop_it): New functions.
3544 (bidi_initialize): Initialize the bidi cache start stack pointer.
3545 (bidi_cache_ensure_space): New function, refactored from part of
3546 bidi_cache_iterator_state. Don't assume the required size is just
3547 one BIDI_CACHE_CHUNK away.
3548 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3549 (bidi_count_bytes, bidi_char_at_pos): New functions.
3550 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3551 always valid if bidi_cache_idx is valid.
3552 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3553 is valid if it's going to be used.
3554 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3555 (bidi_cache_fetch_state, bidi_cache_search)
3556 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3557 (bidi_cache_iterator_state, bidi_cache_find)
3558 (bidi_find_other_level_edge, bidi_cache_start_stack):
3559 All variables related to cache indices are now EMACS_INT.
3560
3561 * dispextern.h (struct bidi_string_data): New structure.
3562 (struct bidi_it): New member `string'. Make flag members be 1-bit
3563 fields, and put them last in the struct.
3564 (compute_display_string_pos, compute_display_string_end):
3565 Update prototypes.
3566 (bidi_push_it, bidi_pop_it): Add prototypes.
3567 (struct iterator_stack_entry): New members bidi_p,
3568 paragraph_embedding, and from_disp_prop_p.
3569 (struct it): Member bidi_p is now a bit field 1 bit wide.
3570 (bidi_shelve_cache, bidi_unshelve_cache):
3571 Declare prototypes.
3572
3573 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3574 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3575 and vector-like objects.
3576
3577 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3578 cache around display iteration.
3579
3580 * window.c (Fwindow_end, window_scroll_pixel_based)
3581 (displayed_window_lines, Frecenter): Save and restore the bidi
3582 cache around display iteration.
3583
3584 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3585
3586 * editfns.c (Fdelete_region): Clarify the use of the named
3587 parameters (bug#6788).
3588
3589 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3590
3591 * indent.c (Fvertical_motion): Set and restore w->pointm when
3592 saving and restoring the window's buffer (Bug#9006).
3593
3594 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3595
3596 * editfns.c (Fstring_to_char): Clarify just what is returned
3597 (bug#6576). Text by Eli Zaretskii.
3598
3599 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3600
3601 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3602
3603 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3604
3605 * buffer.c (mmap_find): Fix a typo.
3606
3607 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3608
3609 Fix execution of x selection hooks.
3610 * xselect.c (Qx_lost_selection_functions)
3611 (Qx_sent_selection_functions): New vars.
3612 (syms_of_xselect): DEFSYM them.
3613 (x_handle_selection_request): Pass Qx_sent_selection_functions
3614 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3615 (x_handle_selection_clear,x_clear_frame_selections):
3616 Pass Qx_lost_selection_functions rather than
3617 Vx_lost_selection_functions to Frun_hook_with_args.
3618
3619 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3620
3621 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3622 The old code sometimes used this field without initializing it.
3623
3624 * alloc.c (gc_sweep): Don't read past end of array.
3625 In theory, the old code could also have corrupted Emacs internals,
3626 though it'd be very unlikely.
3627
3628 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3629
3630 * character.c (Fcharacterp): Don't advertise optional ignored
3631 argument. (Bug#4026)
3632
3633 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3634
3635 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3636 key" (bug#4257).
3637
3638 * window.c (Fset_window_start): Doc fix (bug#4199).
3639 (Fset_window_hscroll): Ditto.
3640
3641 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3642
3643 Fix minor new problems caught by GCC 4.6.1.
3644 * term.c (init_tty): Remove unused local.
3645 * xsettings.c (store_monospaced_changed): Define this function only
3646 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3647 not used otherwise.
3648
3649 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3650
3651 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3652
3653 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3654
3655 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3656 are the mini-buffer and the echo area (bug#3320).
3657
3658 * term.c (init_tty): Remove support for supdup, c10 and perq
3659 terminals, which are no longer supported (bug#1482).
3660
3661 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3662
3663 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3664
3665 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3666
3667 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3668 for non-popups (Bug#3642).
3669
3670 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3671
3672 * alloc.c (reset_malloc_hooks): Protoize.
3673 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3674 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3675 * cm.c (losecursor): Likewise.
3676 * data.c (fmod): Likewise.
3677 * dispnew.c (swap_glyphs_in_rows): Likewise.
3678 * emacs.c (memory_warning_signal): Likewise.
3679 * floatfns.c (float_error): Likewise.
3680 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3681 (otf_open, font_otf_capability, generate_otf_features)
3682 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3683 Likewise.
3684 * image.c (pbm_read_file): Likewise.
3685 * indent.c (string_display_width): Likewise.
3686 * intervals.c (check_for_interval, search_for_interval)
3687 (inc_interval_count, count_intervals, root_interval)
3688 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3689 * lread.c (defalias): Likewise.
3690 * ralloc.c (r_alloc_check): Likewise.
3691 * regex.c (set_image_of_range_1, set_image_of_range)
3692 (regex_grow_registers): Likewise.
3693 * sysdep.c (strerror): Likewise.
3694 * termcap.c (valid_filename_p, tprint, main): Likewise.
3695 * tparam.c (main): Likewise.
3696 * unexhp9k800.c (run_time_remap, save_data_space)
3697 (update_file_ptrs, read_header, write_header, calculate_checksum)
3698 (copy_file, copy_rest, display_header): Likewise.
3699 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3700 Likewise.
3701 * xdisp.c (check_it): Likewise.
3702 * xfaces.c (register_color, unregister_color, unregister_colors):
3703 Likewise.
3704 * xfns.c (print_fontset_result): Likewise.
3705 * xrdb.c (member, fatal, main): Likewise.
3706
3707 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3708
3709 Fix minor problems found by static checking (Bug#9031).
3710 * chartab.c (char_table_set_range, map_sub_char_table):
3711 Remove unused locals.
3712 (uniprop_table): Now static.
3713 * composite.c (_work_char): Remove unused static var.
3714
3715 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3716
3717 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3718
3719 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3720
3721 * gtkutil.c (qttip_cb): Remove code without function.
3722
3723 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3724
3725 * w32.c (pthread_sigmask): New stub.
3726
3727 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3728
3729 Use pthread_sigmask, not sigprocmask (Bug#9010).
3730 sigprocmask is portable only for single-threaded applications, and
3731 Emacs can be multi-threaded when it uses GTK.
3732 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3733 (LIBES): Use it.
3734 * callproc.c (Fcall_process):
3735 * process.c (create_process):
3736 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3737 Use pthread_sigmask, not sigprocmask.
3738
3739 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3740
3741 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3742 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3743 wrong (Bug#8591).
3744
3745 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3746
3747 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3748 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3749 (xg_hide_tooltip): Fix comment.
3750
3751 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3752 in registerServicesMenuSendTypes.
3753 (validRequestorForSendType): Don't check ns_return_types.
3754
3755 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3756 ns_return_type.
3757
3758 2011-07-08 Jason Rumney <jasonr@gnu.org>
3759
3760 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3761 SH_SHOW for hidden windows (Bug#5482).
3762
3763 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3764 frame struct members of non-existent frames (Bug#6284).
3765
3766 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3767
3768 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3769 variable firstTime not needed on OSX >= 10.6.
3770 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3771 >= 10.5. Use setKnobProportion, setDoubleValue.
3772
3773 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3774 (MAC_OS_X_VERSION_10_5): Define if not defined.
3775 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3776 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3777 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3778
3779 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3780 cString and lossyCString on OSX >= 10.4
3781
3782 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3783 sizeToFit on OSX >= 10.2.
3784
3785 * nsimage.m (allocInitFromFile): Don't use deprecated method
3786 bestRepresentationForDevice on OSX >= 10.6.
3787
3788 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3789 to avoid warning.
3790
3791 * emacs.c: Declare unexec_init_emacs_zone.
3792
3793 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3794
3795 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3796
3797 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3798 on svcsMenu (Bug#8842).
3799
3800 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3801 ns_return_types.
3802 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3803
3804 * nsterm.m (QUTF8_STRING): Declare.
3805 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3806 (validRequestorForSendType): Return type is (id).
3807 Change indexOfObjectIdenticalTo to indexOfObject.
3808 Check if we have local selection before returning self (Bug#8842).
3809 (writeSelectionToPasteboard): Put local selection into paste board
3810 if we have a local selection (Bug#8842).
3811 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3812
3813 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3814 (ns_get_local_selection): Declare.
3815
3816 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3817
3818 * keymap.c (describe_map_tree): Don't insert a double newline at
3819 the end of the buffer (bug#1169) and return whether we inserted
3820 something.
3821
3822 * callint.c (Fcall_interactively): Change "reading args" to
3823 "providing args" to try to clarify what it does (bug#1010).
3824
3825 2011-07-07 Kenichi Handa <handa@m17n.org>
3826
3827 * composite.c (composition_compute_stop_pos): Ignore a static
3828 composition starting before CHARPOS (Bug#8915).
3829
3830 * xdisp.c (handle_composition_prop): Likewise.
3831
3832 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3833
3834 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3835 (Bug#9015)
3836
3837 2011-07-07 Kenichi Handa <handa@m17n.org>
3838
3839 * character.h (unicode_category_t): New enum type.
3840
3841 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3842 (Qchar_code_property_table): New variable.
3843 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3844 (UNIPROP_COMPRESSED_FORM_P): New macros.
3845 (char_table_ascii): Uncompress the compressed values.
3846 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3847 Uncompress the compressed values.
3848 (sub_char_table_ref_and_range): Likewise.
3849 (char_table_ref_and_range): Uncompress the compressed values.
3850 (sub_char_table_set): New arg is_uniprop. Callers changed.
3851 Uncompress the compressed values.
3852 (sub_char_table_set_range): Args changed. Callers changed.
3853 (char_table_set_range): Adjuted for the above change.
3854 (map_sub_char_table): Delete args default_val and parent. Add arg
3855 top. Give decoded values to a Lisp function.
3856 (map_char_table): Adjust for the above change. Give decoded
3857 values to a Lisp function. Gcpro more variables.
3858 (uniprop_table_uncompress)
3859 (uniprop_decode_value_run_length): New functions.
3860 (uniprop_decoder, uniprop_decoder_count): New variables.
3861 (uniprop_get_decoder, uniprop_encode_value_character)
3862 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3863 New functions.
3864 (uniprop_encoder, uniprop_encoder_count): New variables.
3865 (uniprop_get_encoder, uniprop_table)
3866 (Funicode_property_table_internal, Fget_unicode_property_internal)
3867 (Fput_unicode_property_internal): New functions.
3868 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3869 Sunicode_property_table_internal, Sget_unicode_property_internal,
3870 and Sput_unicode_property_internal. Defvar_lisp
3871 char-code-property-alist.
3872
3873 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3874 Vunicode_category_table.
3875
3876 * font.c (font_range): Adjust for the change of
3877 Vunicode_category_table.
3878
3879 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3880
3881 * m/iris4d.h: Remove file, move contents ...
3882 * s/irix6-5.h: ... here.
3883
3884 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3885
3886 Remove unportable assumption about struct layout (Bug#8884).
3887 * alloc.c (mark_buffer):
3888 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3889 (clone_per_buffer_values): Don't assume that
3890 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3891 This isn't true in general, and it's particularly not true
3892 if Emacs is configured with --with-wide-int.
3893 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3894 New macros, used in the buffer.c change.
3895
3896 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3897
3898 * xsettings.c: Use both GConf and GSettings if both are available.
3899 (store_config_changed_event): Add comment.
3900 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3901 (store_tool_bar_style_changed): New functions.
3902 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3903 (struct xsettings): Move font inside HAVE_XFT.
3904 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3905 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3906 Move inside HAVE_XFT.
3907 (something_changed_gsettingsCB): Rename from something_changedCB.
3908 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3909 also.
3910 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3911 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3912 (something_changed_gconfCB): Rename from something_changedCB.
3913 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3914 (parse_settings): Move check for font inside HAVE_XFT.
3915 (read_settings, apply_xft_settings): Add comment.
3916 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3917 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3918 call store_font_name_changed.
3919 (xft_settings_event): Add comment.
3920 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3921 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3922 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3923 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3924 (xsettings_initialize): Call init_gsettings last.
3925 (xsettings_get_system_font, xsettings_get_system_normal_font):
3926 Add comment.
3927
3928 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3929
3930 Random fixes. E.g., (random) never returned negative values.
3931 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3932 subseconds part to the entropy, as that's a bit more random.
3933 Prefer signed to unsigned, since the signedness doesn't matter and
3934 in general we prefer signed. When given a limit, use a
3935 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3936 latter isn't right if USE_2_TAGS_FOR_INTS.
3937 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3938 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3939
3940 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3941
3942 * textprop.c (text_property_stickiness):
3943 Obey Vtext_property_default_nonsticky.
3944 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3945 * w32fns.c (syms_of_w32fns):
3946 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3947
3948 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3949
3950 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3951 This is more efficient than Ffile_directory_p and avoids a minor race.
3952
3953 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3954
3955 * buffer.c (Foverlay_put): Say what the return value is
3956 (bug#7835).
3957
3958 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3959 is a directory before asking whether to use the file name
3960 (bug#7564).
3961 (barf_or_query_if_file_exists): Make the "File is a directory"
3962 error be more correct.
3963
3964 * fns.c (Frequire): Remove the mention of the .gz files, since
3965 that's installation-specific, but keep the mention of
3966 `get-load-suffixes'.
3967
3968 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3969
3970 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3971 Report string overflow if the output is too long.
3972
3973 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3974
3975 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3976 (syms_of_gnutls): Remove duplicate DEFSYM for
3977 Qgnutls_bootprop_verify_hostname_error, an error for
3978 Qgnutls_bootprop_verify_error (which is no longer used).
3979
3980 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3981 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3982 Also (re)move comments that are misplaced or no longer relevant.
3983
3984 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3985
3986 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3987
3988 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3989
3990 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3991 and background color parameters if they have been changed.
3992
3993 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3994
3995 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3996
3997 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3998
3999 * xsettings.c (SYSTEM_FONT): Define only when used.
4000 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4001
4002 * keymap.c (access_keymap_1): Now static.
4003
4004 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4005
4006 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4007 leave any prefix arg for the up event (Bug#1586).
4008
4009 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4010
4011 * lread.c (syms_of_lread): Mention single symbols defined by
4012 `defvar' or `defconst' (bug#7154).
4013
4014 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4015 (Frequire): Mention get-load-suffixes.
4016
4017 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4018
4019 * window.h (window): Remove clone_number slot.
4020 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4021 Remove.
4022 (make_parent_window, make_window, saved_window)
4023 (Fset_window_configuration, save_window_save): Don't deal with
4024 clone numbers.
4025 * buffer.c (Qclone_number): Remove declaration.
4026 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4027
4028 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4029
4030 Add multiple inheritance to keymaps.
4031 * keymap.c (Fmake_composed_keymap): New function.
4032 (Fset_keymap_parent): Simplify.
4033 (fix_submap_inheritance): Remove.
4034 (access_keymap_1): New function extracted from access_keymap to handle
4035 embedded parents and handle lists of maps.
4036 (access_keymap): Use it.
4037 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4038 (Fcopy_keymap): Handle embedded parents.
4039 (Fcommand_remapping, define_as_prefix): Simplify.
4040 (Fkey_binding): Simplify.
4041 (syms_of_keymap): Move minibuffer-local-completion-map,
4042 minibuffer-local-filename-completion-map,
4043 minibuffer-local-must-match-map, and
4044 minibuffer-local-filename-must-match-map to Elisp.
4045 (syms_of_keymap): Defsubr make-composed-keymap.
4046 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4047 (parse_menu_item): Trivial simplification.
4048
4049 2011-07-01 Glenn Morris <rgm@gnu.org>
4050
4051 * Makefile.in (SETTINGS_LIBS): Fix typo.
4052
4053 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4054
4055 * coding.c (Fencode_coding_string): Record the last coding system
4056 used, as the function doc string says (bug#8738).
4057
4058 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4059
4060 * xsettings.c (store_monospaced_changed): Take new font as arg and
4061 check for change against current_mono_font.
4062 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4063 (emacs_settings_constructor, emacs_settings_get_property)
4064 (emacs_settings_set_property, emacs_settings_class_init)
4065 (emacs_settings_init, gsettings_obj): Remove.
4066 (something_changedCB): New function for HAVE_GSETTINGS.
4067 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4068 with value as argument.
4069 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4070 g_settings_new (Bug#8967). Do not create gsettings_obj.
4071 Remove calls to g_settings_bind. Connect something_changedCB to
4072 "changed".
4073
4074 * xgselect.c: Add defined (HAVE_GSETTINGS).
4075 (xgselect_initialize): Ditto.
4076
4077 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4078 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4079 xg_select.
4080
4081 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4082
4083 * eval.c (struct backtrace): Simplify and port the data structure.
4084 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4085 signed bit field, as this assumption is not portable and it makes
4086 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4087 "char debug_on_exit : 1" as this is not portable either; instead,
4088 use the portable "unsigned int debug_on_exit : 1". Remove unused
4089 member evalargs. Remove obsolete comments about cc bombing out.
4090
4091 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4092
4093 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4094 Let HAVE_GSETTINGS override HAVE_GCONF.
4095 (store_monospaced_changed): New function.
4096 (EMACS_SETTINGS): A new type derived from GObject to handle
4097 GSettings notifications.
4098 (emacs_settings_constructor, emacs_settings_get_property)
4099 (emacs_settings_set_property, emacs_settings_class_init):
4100 New functions.
4101 (gsettings_client, gsettings_obj): New variables.
4102 (GSETTINGS_SCHEMA): New define.
4103 (something_changedCB): Call store_monospaced_changed.
4104 (init_gsettings): New function.
4105 (xsettings_initialize): Call init_gsettings.
4106 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4107 to NULL.
4108
4109 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4110 GCONF_CFLAGS/LIBS.
4111
4112 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4113
4114 * window.c (resize_root_window, grow_mini_window)
4115 (shrink_mini_window): Rename Qresize_root_window to
4116 Qwindow_resize_root_window and Qresize_root_window_vertically to
4117 Qwindow_resize_root_window_vertically.
4118
4119 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4120
4121 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4122
4123 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4124
4125 * makefile.w32-in: Redesign dependencies so they reflect more
4126 clearly which files are directly included by each source file,
4127 and not through other includes.
4128
4129 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4130
4131 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4132 (sort_overlays, overlay_strings): When an overlay's clone number
4133 matches the window's clone number process the overlay even if
4134 the overlay's window property doesn't match the current window.
4135
4136 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4137 (Fwindow_hchild): Rename to Fwindow_left_child.
4138 (Fwindow_next): Rename to Fwindow_next_sibling.
4139 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4140 (resize_window_check): Rename to window_resize_check.
4141 (resize_window_apply): Rename to window_resize_apply.
4142 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4143 (Fdelete_other_windows_internal, resize_frame_windows)
4144 (Fsplit_window_internal, Fdelete_window_internal)
4145 (grow_mini_window, shrink_mini_window)
4146 (Fresize_mini_window_internal): Fix callers accordingly.
4147
4148 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4149
4150 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4151 (emacs_fixed_set_min_size): Remove.
4152 (emacs_fixed_new): Take frame as argument.
4153
4154 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4155 (_EmacsFixedPrivate): Remove minwidth/height.
4156 Add struct frame *f.
4157 (emacs_fixed_init): Initialize priv->f.
4158 (get_parent_class, emacs_fixed_set_min_size): Remove.
4159 (emacs_fixed_new): Set priv->f to argument.
4160 (emacs_fixed_get_preferred_width)
4161 (emacs_fixed_get_preferred_height): Use min_width/height from
4162 frames size_hint to set minimum and natural (Bug#8919).
4163 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4164 and use min_width/height from frames size_hint to set
4165 min_width/height (Bug#8919).
4166
4167 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4168 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4169 Fix indentation.
4170
4171 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4172
4173 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4174 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4175 called at ZV.
4176
4177 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4178
4179 * process.c (wait_reading_process_output): Bypass select if
4180 waiting for a cell while ignoring keyboard input, and input is
4181 pending. Suggested by Jan Djärv (Bug#8869).
4182
4183 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4184
4185 Use gnulib's dup2 module instead of rolling our own.
4186 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4187
4188 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4189
4190 * dispnew.c (scrolling_window): Before scrolling, turn off a
4191 mouse-highlight in the window being scrolled.
4192
4193 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4194
4195 Move DEFSYM to lisp.h and use everywhere.
4196
4197 * character.h (DEFSYM): Move declaration...
4198 * lisp.h (DEFSYM): ...here.
4199
4200 * gnutls.c:
4201 * minibuf.c:
4202 * w32menu.c:
4203 * w32proc.c:
4204 * w32select.c: Don't include character.h.
4205
4206 * alloc.c (syms_of_alloc):
4207 * buffer.c (syms_of_buffer):
4208 * bytecode.c (syms_of_bytecode):
4209 * callint.c (syms_of_callint):
4210 * casefiddle.c (syms_of_casefiddle):
4211 * casetab.c (init_casetab_once):
4212 * category.c (init_category_once, syms_of_category):
4213 * ccl.c (syms_of_ccl):
4214 * cmds.c (syms_of_cmds):
4215 * composite.c (syms_of_composite):
4216 * dbusbind.c (syms_of_dbusbind):
4217 * dired.c (syms_of_dired):
4218 * dispnew.c (syms_of_display):
4219 * doc.c (syms_of_doc):
4220 * editfns.c (syms_of_editfns):
4221 * emacs.c (syms_of_emacs):
4222 * eval.c (syms_of_eval):
4223 * fileio.c (syms_of_fileio):
4224 * fns.c (syms_of_fns):
4225 * frame.c (syms_of_frame):
4226 * fringe.c (syms_of_fringe):
4227 * insdel.c (syms_of_insdel):
4228 * keymap.c (syms_of_keymap):
4229 * lread.c (init_obarray, syms_of_lread):
4230 * macros.c (syms_of_macros):
4231 * msdos.c (syms_of_msdos):
4232 * print.c (syms_of_print):
4233 * process.c (syms_of_process):
4234 * search.c (syms_of_search):
4235 * sound.c (syms_of_sound):
4236 * syntax.c (init_syntax_once, syms_of_syntax):
4237 * terminal.c (syms_of_terminal):
4238 * textprop.c (syms_of_textprop):
4239 * undo.c (syms_of_undo):
4240 * w32.c (globals_of_w32):
4241 * window.c (syms_of_window):
4242 * xdisp.c (syms_of_xdisp):
4243 * xfaces.c (syms_of_xfaces):
4244 * xfns.c (syms_of_xfns):
4245 * xmenu.c (syms_of_xmenu):
4246 * xsettings.c (syms_of_xsettings):
4247 * xterm.c (syms_of_xterm): Use DEFSYM.
4248
4249 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4250
4251 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4252
4253 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4254
4255 Integer and buffer overflow fixes (Bug#8873).
4256
4257 * print.c (printchar, strout): Check for string overflow.
4258 (PRINTPREPARE, printchar, strout):
4259 Don't set size unless allocation succeeds.
4260
4261 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4262 for sizes. Check for string overflow more accurately.
4263 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4264
4265 * macros.c: Integer and buffer overflow fixes.
4266 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4267 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4268 Use ptrdiff_t, not int, for sizes.
4269 Don't increment bufsize until after realloc succeeds.
4270 Check for size-calculation overflow.
4271 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4272
4273 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4274
4275 * lread.c: Integer overflow fixes.
4276 (read_integer): Radix is now EMACS_INT, not int,
4277 to improve quality of diagnostics for out-of-range radices.
4278 Calculate buffer size correctly for out-of-range radices.
4279 (read1): Check for integer overflow in radices, and in
4280 read-circle numbers.
4281 (read_escape): Avoid int overflow.
4282 (Fload, openp, read_buffer_size, read1)
4283 (substitute_object_recurse, read_vector, read_list, map_obarray):
4284 Use ptrdiff_t, not int, for sizes.
4285 (read1): Use EMACS_INT, not int, for sizes.
4286 Check for size overflow.
4287
4288 * image.c (cache_image): Check for size arithmetic overflow.
4289
4290 * lread.c: Integer overflow issues.
4291 (saved_doc_string_size, saved_doc_string_length)
4292 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4293 Now ptrdiff_t, not int.
4294 (read1): Don't assume doc string length fits in int. Check for
4295 out-of-range doc string lengths.
4296 (read_list): Don't assume file position fits in int.
4297 (read_escape): Check for hex character overflow.
4298
4299 2011-06-22 Leo Liu <sdl.web@gmail.com>
4300
4301 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4302 Move to minibuffer.el.
4303
4304 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4305
4306 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4307 The following patches are for when GLYPH_DEBUG && !XASSERT.
4308 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4309 * dispnew.c (flush_stdout):
4310 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4311 Mark as externally visible.
4312 * dispnew.c (check_window_matrix_pointers): Now static.
4313 * dispnew.c (window_to_frame_vpos):
4314 * xfns.c (unwind_create_frame):
4315 * xterm.c (x_check_font): Remove unused local.
4316 * scroll.c (CHECK_BOUNDS):
4317 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4318 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4319 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4320 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4321 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4322 Now static.
4323 (debug_method_add): Use va_list and vsprintf rather than relying
4324 on undefined behavior with wrong number of arguments.
4325 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4326 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4327 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4328 since we're not interested in debugging glyphs with old libraries.
4329 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4330 GCC 4.6.0's static checking.
4331
4332 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4333
4334 Integer overflow and signedness fixes (Bug#8873).
4335 A few related buffer overrun fixes, too.
4336
4337 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4338
4339 * dispextern.h (struct face.stipple):
4340 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4341 (x_bitmap_mask, x_allocate_bitmap_record)
4342 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4343 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4344 (x_create_bitmap_from_xpm_data):
4345 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4346 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4347 (.bitmaps_last):
4348 * xfaces.c (load_pixmap):
4349 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4350 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4351 (.bitmaps_last, struct x_output.icon_bitmap):
4352 Use ptrdiff_t, not int, for bitmap indexes.
4353 (x_allocate_bitmap_record): Check for size overflow.
4354 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4355
4356 Use ptrdiff_t, not int, for overlay counts.
4357 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4358 * editfns.c (overlays_around, get_pos_property):
4359 * textprop.c (get_char_property_and_overlay):
4360 * xdisp.c (next_overlay_change, note_mouse_highlight):
4361 * xfaces.c (face_at_buffer_position):
4362 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4363 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4364 (Fnext_overlay_change, Fprevious_overlay_change)
4365 (mouse_face_overlay_overlaps, Foverlays_in):
4366 Use ptrdiff_t, not int, for sizes.
4367 (overlays_at, overlays_in): Check for size-calculation overflow.
4368
4369 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4370
4371 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4372 (x_session_initialize): Do not assume string length fits in int.
4373
4374 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4375 This is unlikely, but can occur if DPI is outlandish.
4376
4377 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4378 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4379
4380 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4381 * xrdb.c (magic_file_p, search_magic_path):
4382 Omit last arg SUFFIX; it was always 0. All callers changed.
4383 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4384
4385 * xfont.c (xfont_match): Avoid need for strlen.
4386
4387 * xfns.c: Don't assume strlen fits in int.
4388 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4389
4390 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4391 not unsigned long, as we prefer signed integers. All callers changed.
4392 Detect integer overflow in repeat count.
4393 (message_dolog): Don't assume print length fits in 39 bytes.
4394 (display_mode_element): Don't assume strlen fits in int.
4395
4396 * termcap.c: Don't assume sizes fit in int and never overflow.
4397 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4398 (gobble_line): Check for size-calculation overflow.
4399
4400 * minibuf.c (Fread_buffer):
4401 * lread.c (intern, intern_c_string):
4402 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4403 Don't assume string length fits in int.
4404
4405 * keyboard.c (parse_tool_bar_item):
4406 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4407
4408 * font.c: Don't assume string length fits in int.
4409 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4410 Use ptrdiff_t, not int.
4411 (font_intern_prop): Don't assume string length fits in int.
4412 Don't assume integer property fits in fixnum.
4413 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4414
4415 * filelock.c: Fix some buffer overrun and integer overflow issues.
4416 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4417 Reformulate so as not to need the command string.
4418 Invoke gzip -cd rather than gunzip, as it's more portable.
4419 (lock_info_type, lock_file_1, lock_file):
4420 Don't assume pid_t and time_t fit in unsigned long.
4421 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4422 (current_lock_owner): Prefer signed type for sizes.
4423 Use memcpy, not strncpy, where memcpy is what is really wanted.
4424 Don't assume (via atoi) that time_t and pid_t fit in int.
4425 Check for time_t and/or pid_t out of range, e.g., via a network share.
4426 Don't alloca where an auto var works fine.
4427
4428 * fileio.c: Fix some integer overflow issues.
4429 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4430 Don't assume string length fits in int.
4431 (directory_file_name): Don't assume string length fits in long.
4432 (make_temp_name): Don't assume pid fits in int, or that its print
4433 length is less than 20.
4434
4435 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4436
4437 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4438
4439 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4440
4441 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4442 We prefer signed integers, even for size calculations.
4443
4444 * emacs.c: Don't assume string length fits in 'int'.
4445 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4446 (main): Don't invoke strlen when not needed.
4447
4448 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4449 (XD_DEBUG_MESSAGE): Don't waste a byte.
4450
4451 * callproc.c (getenv_internal_1, getenv_internal)
4452 (Fgetenv_internal):
4453 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4454
4455 * lread.c (invalid_syntax): Omit length argument.
4456 All uses changed. This doesn't fix a bug, but it simplifies the
4457 code away from its former Hollerith-constant appearance, and it's
4458 one less 'int' to worry about when looking at integer-overflow issues.
4459 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4460
4461 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4462 This didn't break anything, but it didn't help either.
4463 It's confusing to put a bogus integer in a place where the actual
4464 value does not matter.
4465 (LIST_END_P): Remove unused macro and its bogus comment.
4466 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4467
4468 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4469 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4470 implementation.
4471 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4472 We prefer signed types, and the value cannot exceed the EMACS_INT
4473 range anyway (because otherwise the length would not be representable).
4474 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4475 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4476 This avoids a GCC warning when WIDE_EMACS_INT.
4477
4478 * indent.c (sane_tab_width): New function.
4479 (current_column, scan_for_column, Findent_to, position_indentation)
4480 (compute_motion): Use it. This is just for clarity.
4481 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4482
4483 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4484
4485 * lisp.h (lint_assume): New macro.
4486 * composite.c (composition_gstring_put_cache):
4487 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4488
4489 * editfns.c, insdel.c:
4490 Omit unnecessary forward decls, to simplify future changes.
4491
4492 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4493
4494 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4495
4496 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4497 Use much-faster test for byte-length change.
4498 Don't assume string byte-length fits in 'int'.
4499 Check that character arg fits in 'int'.
4500 (mapcar1): Declare byte as byte, for clarity.
4501
4502 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4503
4504 * fns.c (concat): Catch string overflow earlier.
4505 Do not rely on integer wraparound.
4506
4507 * dispextern.h (struct it.overlay_strings_charpos)
4508 (struct it.selective): Now EMACS_INT, not int.
4509 * xdisp.c (forward_to_next_line_start)
4510 (back_to_previous_visible_line_start)
4511 (reseat_at_next_visible_line_start, next_element_from_buffer):
4512 Don't arbitrarily truncate the value of 'selective' to int.
4513
4514 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4515
4516 * composite.c: Don't truncate sizes to 'int'.
4517 (composition_gstring_p, composition_reseat_it)
4518 (composition_adjust_point): Use EMACS_INT, not int.
4519 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4520 not EMACS_UINT, for indexes.
4521
4522 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4523
4524 * buffer.c: Include <verify.h>.
4525 (struct sortvec.priority, struct sortstr.priority):
4526 Now EMACS_INT, not int.
4527 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4528 (struct sortstr.size, record_overlay_string)
4529 (struct sortstrlist.size, struct sortlist.used):
4530 Don't truncate size to int.
4531 (record_overlay_string): Check for size-calculation overflow.
4532 (init_buffer_once): Check at compile-time, not run-time.
4533
4534 2011-06-22 Jim Meyering <meyering@redhat.com>
4535
4536 Don't leak an XBM-image-sized buffer
4537 * image.c (xbm_load): Free the image buffer after using it.
4538
4539 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4540
4541 Port to Sun C.
4542 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4543 that Sun C diagnosed.
4544 * fns.c (secure_hash): Fix pointer signedness issue.
4545 * intervals.c (static_offset_intervals): New function.
4546 (offset_intervals): Use it.
4547
4548 2011-06-21 Leo Liu <sdl.web@gmail.com>
4549
4550 * deps.mk (fns.o):
4551 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4552 sha512.h.
4553
4554 * fns.c (secure_hash): Rename from crypto_hash_function and change
4555 the first arg to accept symbols.
4556 (Fsecure_hash): New primitive.
4557 (syms_of_fns): New symbols.
4558
4559 2011-06-20 Deniz Dogan <deniz@dogan.se>
4560
4561 * process.c (Fset_process_buffer): Clarify return value in
4562 docstring.
4563
4564 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4565
4566 * dispnew.c (add_window_display_history): Use BVAR.
4567
4568 * xdisp.c (debug_method_add): Use BVAR.
4569 (check_window_end, dump_glyph_matrix, dump_glyph)
4570 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4571
4572 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4573 Likewise.
4574
4575 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4576 check till after the cache is created in init_frame_faces.
4577
4578 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4579
4580 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4581
4582 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4583
4584 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4585 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4586 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4587
4588 Improve buffer-overflow checking (Bug#8873).
4589 * fileio.c (Finsert_file_contents):
4590 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4591 Remove the old (too-loose) buffer overflow checks.
4592 They weren't needed, since make_gap checks for buffer overflow.
4593 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4594 The old code merely checked for Emacs fixnum overflow, and relied
4595 on undefined (wraparound) behavior. The new code avoids undefined
4596 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4597
4598 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4599 Tune. Don't use wider integers than needed. Don't use alloca.
4600 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4601
4602 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4603
4604 * insdel.c, lisp.h (buffer_overflow): New function.
4605 (insert_from_buffer_1, replace_range, replace_range_2):
4606 * insdel.c (make_gap_larger):
4607 * editfns.c (Finsert_char):
4608 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4609
4610 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4611
4612 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4613
4614 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4615
4616 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4617 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4618
4619 * fileio.c: Don't assume EMACS_INT fits in off_t.
4620 (emacs_lseek): New static function.
4621 (Finsert_file_contents, Fwrite_region): Use it.
4622 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4623
4624 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4625
4626 * fns.c: Don't overflow int when computing a list length.
4627 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4628 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4629 truncation on 64-bit hosts. Check for QUIT every
4630 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4631 faster and is responsive enough.
4632 (Flength): Report an error instead of overflowing an integer.
4633 (Fsafe_length): Return a float if the value is not representable
4634 as a fixnum. This shouldn't happen except in contrived situations.
4635 (Fnthcdr, Fsort): Don't assume list length fits in int.
4636 (Fcopy_sequence): Don't assume vector length fits in int.
4637
4638 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4639 (header_size, word_size): New constants.
4640 (allocate_vectorlike): Don't check size overflow here.
4641 (allocate_vector): Check it here instead, since this is the only
4642 caller of allocate_vectorlike that could cause overflow.
4643 Check that the new vector's length is representable as a fixnum.
4644
4645 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4646 The previous code was bogus. For example, next_almost_prime (32)
4647 returned 39, which is undesirable as it is a multiple of 3; and
4648 next_almost_prime (24) returned 25, which is a multiple of 5 so
4649 why was the code bothering to check for multiples of 7?
4650
4651 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4652
4653 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4654
4655 Variadic C functions now count arguments with ptrdiff_t.
4656 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4657 Back then I didn't know that the Emacs coding style prefers signed int.
4658 Also, in the meantime I found a few more instances where arguments
4659 were being counted with int, which may truncate counts on 64-bit
4660 machines, or EMACS_INT, which may be unnecessarily wide.
4661 * lisp.h (struct Lisp_Subr.function.aMANY)
4662 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4663 Arg counts are now ptrdiff_t, not size_t.
4664 All variadic functions and their callers changed accordingly.
4665 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4666 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4667 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4668 * callint.c (Fcall_interactively): Check arg count for overflow,
4669 to avoid potential buffer overrun. Use signed char, not 'int',
4670 for 'varies' array, so that we needn't bother to check its size
4671 calculation for overflow.
4672 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4673 * eval.c (apply_lambda):
4674 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4675 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4676 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4677
4678 * callint.c (Fcall_interactively): Don't use index var as event count.
4679
4680 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4681 * mem-limits.h (SIZE): Remove; no longer used.
4682
4683 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4684
4685 Remove unnecessary casts.
4686 * xterm.c (x_term_init):
4687 * xfns.c (x_set_border_pixel):
4688 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4689 These aren't needed now that we assume ANSI C.
4690
4691 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4692 It's more likely to cause problems (due to unsigned overflow)
4693 than to cure them.
4694
4695 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4696
4697 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4698
4699 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4700
4701 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4702
4703 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4704
4705 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4706
4707 GLYPH_CODE_FACE returns EMACS_INT, not int.
4708 * dispextern.h (merge_faces):
4709 * xfaces.c (merge_faces):
4710 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4711 Don't assume EMACS_INT fits in int.
4712
4713 * character.h (CHAR_VALID_P): Remove unused parameter.
4714 * fontset.c, lisp.h, xdisp.c: All uses changed.
4715
4716 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4717
4718 * fns.c (concat): Minor tuning based on overflow analysis.
4719 This doesn't fix any bugs. Use int to hold character, instead
4720 of constantly refetching from Emacs object. Use XFASTINT, not
4721 XINT, for value known to be a character. Don't bother comparing
4722 a single byte to 0400, as it's always less.
4723
4724 * floatfns.c (Fexpt):
4725 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4726
4727 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4728 for characters.
4729
4730 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4731
4732 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4733 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4734 incorrectly succeed when S was a string, because 4294967386 was
4735 truncated before it was used.
4736
4737 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4738 Otherwise, an out-of-range integer could cause undefined behavior
4739 on a 64-bit host.
4740
4741 * composite.c: Use int, not EMACS_INT, for characters.
4742 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4743 EMACS_INT, for values that are known to be in character range.
4744 This doesn't fix any bugs but is the usual style inside Emacs and
4745 may generate better code on 32-bit machines.
4746
4747 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4748 This is for reasons similar to the recent CHAR_STRING fix.
4749 * charset.c (Fencode_char): Check that character arg is actually
4750 a character. Pass an int to ENCODE_CHAR.
4751 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4752 wider than 'int', as a compile-time check to prevent future regressions
4753 in this area.
4754
4755 * character.c (char_string): Remove unnecessary casts.
4756
4757 Make sure a 64-bit char is never passed to CHAR_STRING.
4758 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4759 by silently ignoring the top 32 bits, allowing some values
4760 that were far too large to be valid characters.
4761 * character.h: Include <verify.h>.
4762 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4763 arguments are no wider than unsigned, as a compile-time check
4764 to prevent future regressions in this area.
4765 * data.c (Faset):
4766 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4767 (Fsubst_char_in_region):
4768 * fns.c (concat):
4769 * xdisp.c (decode_mode_spec_coding):
4770 Adjust to CHAR_STRING's new requirement.
4771 * editfns.c (Finsert_char, Fsubst_char_in_region):
4772 * fns.c (concat): Check that character args are actually
4773 characters. Without this test, these functions did the wrong
4774 thing with wildly out-of-range values on 64-bit hosts.
4775
4776 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4777 These casts should not be needed on 32-bit hosts, either.
4778 * keyboard.c (read_char):
4779 * lread.c (Fload): Remove casts to unsigned.
4780
4781 * lisp.h (UNSIGNED_CMP): New macro.
4782 This fixes comparison bugs on 64-bit hosts.
4783 (ASCII_CHAR_P): Use it.
4784 * casefiddle.c (casify_object):
4785 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4786 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4787 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4788 * dispextern.h (FACE_FROM_ID):
4789 * keyboard.c (read_char): Use UNSIGNED_CMP.
4790
4791 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4792 not to EMACS_INT, to avoid GCC warning.
4793
4794 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4795
4796 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4797 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4798 isn't needed on 32-bit machines.
4799
4800 * buffer.c (Fgenerate_new_buffer_name):
4801 Use EMACS_INT for count, not int.
4802 (advance_to_char_boundary): Return EMACS_INT, not int.
4803
4804 * data.c (Qcompiled_function): Now static.
4805
4806 * window.c (window_body_lines): Now static.
4807
4808 * image.c (gif_load): Rename local to avoid shadowing.
4809
4810 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4811 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4812 * alloc.c (make_save_value): Integer argument is now of type
4813 ptrdiff_t, not int.
4814 (mark_object): Use ptrdiff_t, not int.
4815 * lisp.h (pD): New macro.
4816 * print.c (print_object): Use it.
4817
4818 * alloc.c: Use EMACS_INT, not int, to count objects.
4819 (total_conses, total_markers, total_symbols, total_vector_size)
4820 (total_free_conses, total_free_markers, total_free_symbols)
4821 (total_free_floats, total_floats, total_free_intervals)
4822 (total_intervals, total_strings, total_free_strings):
4823 Now EMACS_INT, not int. All uses changed.
4824 (Fgarbage_collect): Compute overall total using a double, so that
4825 integer overflow is less likely to be a problem. Check for overflow
4826 when converting back to an integer.
4827 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4828 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4829 These were 'int' variables that could overflow on 64-bit hosts;
4830 they were never used, so remove them instead of repairing them.
4831 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4832 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4833 Previously, this ceilinged at INT_MAX, but that doesn't work on
4834 64-bit machines.
4835 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4836
4837 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4838 (allocate_vectorlike): Check for ptrdiff_t overflow.
4839 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4840 when a (possibly-narrower) signed value would do just as well.
4841 We prefer using signed arithmetic, to avoid comparison confusion.
4842
4843 * alloc.c: Catch some string size overflows that we were missing.
4844 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4845 for convenience in STRING_BYTES_MAX.
4846 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4847 The definition here is exact; the one in lisp.h was approximate.
4848 (allocate_string_data): Check for string overflow. This catches
4849 some instances we weren't catching before. Also, it catches
4850 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4851 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4852 and ptrdiff_t and EMACS_INT are both 64 bits.
4853
4854 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4855 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4856 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4857
4858 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4859
4860 * alloc.c (Fmake_string): Check for out-of-range init.
4861
4862 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4863
4864 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4865
4866 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4867
4868 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4869 xg_get_default_scrollbar_width.
4870
4871 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4872 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4873 (style_changed_cb): Call update_theme_scrollbar_width and call
4874 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4875 all frames (Bug#8505).
4876 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4877 Call gtk_window_set_resizable if HAVE_GTK3.
4878 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4879 and height if HAVE_GTK3 (Bug#8505).
4880 (scroll_bar_width_for_theme): New variable.
4881 (update_theme_scrollbar_width): New function.
4882 (xg_get_default_scrollbar_width): Move code to
4883 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4884 (xg_initialize): Call update_theme_scrollbar_width.
4885
4886 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4887
4888 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4889
4890 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4891
4892 * frame.c (make_frame): Call other_buffer_safely instead of
4893 other_buffer.
4894
4895 * window.c (temp_output_buffer_show): Call display_buffer with
4896 second argument Vtemp_buffer_show_specifiers and reset latter
4897 immediately after the call.
4898 (Vtemp_buffer_show_specifiers): New variable.
4899 (auto_window_vscroll_p, next_screen_context_lines)
4900 (Vscroll_preserve_screen_position): Remove leading asterisks from
4901 doc-strings.
4902
4903 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4904
4905 Fix minor problems found by GCC 4.6.0 static checking.
4906 * buffer.c (Qclone_number): Remove for now, as it's unused.
4907 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4908 (record_buffer): Remove unused local.
4909 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4910 (set_frame_buffer_list): Remove; unused.
4911 * frame.h (other_visible_frames): Remove decl.
4912 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4913 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4914 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4915 if HAVE_GPM.
4916 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4917 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4918 Define only if HAVE_GPM.
4919 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4920 (update_hints_inhibit): Remove; never set. All uses removed.
4921 * widgetprv.h (emacsFrameClassRec): Remove decl.
4922 * window.c (delete_deletable_window): Now returns void, since it
4923 wasn't returning anything.
4924 (compare_window_configurations): Remove unused locals.
4925 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4926 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4927 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4928 the same widths as pointers. This follows up on the 2011-05-06 patch.
4929 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4930 * xterm.h: Likewise.
4931 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4932
4933 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4934
4935 * makefile.w32-in: Update dependencies.
4936 (LISP_H): Add lib/intprops.h.
4937
4938 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4939
4940 * image.c (gif_load): Add animation frame delay to the metadata.
4941 (syms_of_image): Use DEFSYM. New symbol `delay'.
4942
4943 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4944
4945 * window.c (delete_deletable_window): Re-add.
4946 (Fset_window_configuration): Rewrite to handle dead buffers and
4947 consequently deletable windows.
4948 (window_tree, Fwindow_tree): Remove. Supply functionality in
4949 window.el.
4950 (compare_window_configurations): Simplify code.
4951
4952 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4953
4954 * image.c (imagemagick_load_image): Fix type mismatch.
4955 (Fimagemagick_types): Likewise.
4956
4957 * window.h (replace_buffer_in_windows): Declare.
4958
4959 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4960
4961 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4962 Qclone_number. Remove external declaration of Qdelete_window.
4963 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4964 code.
4965 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4966 Run Qbuffer_list_update_hook if allowed.
4967 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4968 buffer list implementation.
4969 (other_buffer_safely): New function.
4970 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4971 calls to replace_buffer_in_windows and
4972 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4973 if allowed.
4974 (record_buffer): Inhibit quitting and rewrite using quittable
4975 functions. Run Qbuffer_list_update_hook if allowed.
4976 (Frecord_buffer, Funrecord_buffer): New functions.
4977 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4978 Move switch-to-buffer to window.el.
4979 (bury-buffer): Move to window.el.
4980 (Vbuffer_list_update_hook): New variable.
4981
4982 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4983 section.
4984
4985 * window.h (resize_frame_windows): Move up in code.
4986 (Fwindow_frame): Remove EXFUN.
4987 (replace_buffer_in_all_windows): Remove prototype.
4988 (replace_buffer_in_windows_safely): Add prototype.
4989
4990 * window.c: Declare Qdelete_window static again. Move down
4991 declaration of select_count.
4992 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4993 (Fother_window): Move to window.el.
4994 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4995 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4996 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4997 window.el.
4998 (replace_buffer_in_windows): Implement by calling
4999 Qreplace_buffer_in_windows.
5000 (replace_buffer_in_all_windows): Remove with some functionality
5001 moved into replace_buffer_in_windows_safely.
5002 (replace_buffer_in_windows_safely): New function.
5003 (select_window_norecord, select_frame_norecord): Move in front
5004 of run_window_configuration_change_hook. Remove now obsolete
5005 declarations.
5006 (Fset_window_buffer): Rewrite doc-string.
5007 Call Qrecord_window_buffer.
5008 (keys_of_window): Move binding for other-window to window.el.
5009
5010 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5011
5012 * dispextern.h (struct image): Replace data member, whose int_val
5013 and ptr_val fields were not used by anything, with a single
5014 lisp_val object.
5015
5016 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5017 (gif_clear_image, gif_load, imagemagick_load_image)
5018 (gs_clear_image, gs_load): Callers changed.
5019
5020 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5021
5022 * buffer.h: Include <time.h>, for time_t.
5023 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5024
5025 Fix minor problems found by static checking.
5026
5027 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5028
5029 Make identifiers static if they are not used in other modules.
5030 * data.c (Qcompiled_function, Qframe, Qvector):
5031 * image.c (QimageMagick, Qsvg):
5032 * minibuf.c (Qmetadata):
5033 * window.c (resize_window_check, resize_root_window): Now static.
5034 * window.h (resize_window_check, resize_root_window): Remove decls.
5035
5036 * window.c (window_deletion_count, delete_deletable_window):
5037 Remove; unused.
5038 (window_body_lines): Now static.
5039 (Fdelete_other_windows_internal): Mark vars as initialized.
5040 Make sure 'resize_failed' is initialized.
5041 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5042 (resize_window_apply): Remove unused local.
5043 * window.h (delete_deletable_window): Remove decl.
5044
5045 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5046 (imagemagick_load_image): Fix pointer signedness problem by changing
5047 last arg from unsigned char * to char *. All uses changed.
5048 Also, fix a local for similar reasons.
5049 Remove unused locals. Remove locals to avoid shadowing.
5050 (fn_rsvg_handle_free): Remove; unused.
5051 (svg_load, svg_load_image): Fix pointer signedness problem.
5052 (imagemagick_load_image): Don't use garbage pointer image_wand.
5053
5054 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5055
5056 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5057
5058 * image.c (gif_load): Fix omitted cast error introduced by
5059 2011-06-06 change.
5060
5061 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5062
5063 * window.h (resize_proportionally, orig_total_lines)
5064 (orig_top_line): Remove from window structure.
5065 (set_window_height, set_window_width, change_window_heights)
5066 (Fdelete_window): Remove prototypes.
5067 (resize_frame_windows): Remove duplicate declaration.
5068
5069 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5070
5071 * window.h (resize_frame_windows, resize_window_check)
5072 (delete_deletable_window, resize_root_window)
5073 (resize_frame_windows): Declare prototypes.
5074
5075 * window.c (resize_window_apply): Make definition be "static" to
5076 match the prototype.
5077
5078 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5079
5080 * window.c: Remove declarations of Qwindow_size_fixed,
5081 window_min_size_1, window_min_size_2, window_min_size,
5082 size_window, window_fixed_size_p, enlarge_window, delete_window.
5083 Remove static from declaration of Qdelete_window, it's
5084 temporarily needed by Fbury_buffer.
5085 (replace_window): Don't assign orig_top_line and
5086 orig_total_lines.
5087 (Fdelete_window, delete_window): Remove. Window deletion is
5088 handled by window.el.
5089 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5090 Replace Fdelete_window calls with calls to Qdelete_window.
5091 (Fdelete_other_windows): Remove. Deleting other windows is
5092 handled by window.el.
5093 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5094 handled in window.el.
5095 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5096 Window minimum sizes are handled in window.el.
5097 (shrink_windows, size_window, set_window_height)
5098 (set_window_width, change_window_heights, window_height)
5099 (window_width, CURBEG, CURSIZE, enlarge_window)
5100 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5101 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5102 handled in window.el.
5103 (make_dummy_parent): Rename to make_parent_window and give it a
5104 second argument horflag.
5105 (make_window): Don't set resize_proportionally any more.
5106 (Fsplit_window): Remove. Windows are split in window.el.
5107 (save_restore_action, save_restore_orig_size)
5108 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5109 Resize mini windows in window.el.
5110 (grow_mini_window, shrink_mini_window): Implement by calling
5111 Qresize_root_window_vertically, resize_window_check and
5112 resize_window_apply.
5113 (saved_window, Fset_window_configuration, save_window_save):
5114 Do not handle orig_top_line, orig_total_lines, and
5115 resize_proportionally.
5116 (window_min_height, window_min_width): Move to window.el.
5117 (keys_of_window): Move bindings for delete-other-windows,
5118 split-window, delete-window and enlarge-window to window.el.
5119
5120 * buffer.c: Temporarily extern Qdelete_window.
5121 (Fbury_buffer): Temporarily call Qdelete_window instead of
5122 Fdelete_window (Fbury_buffer will move to window.el soon).
5123
5124 * frame.c (set_menu_bar_lines_1): Remove code handling
5125 orig_top_line and orig_total_lines.
5126
5127 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5128 set_window_height but set heights directly.
5129 (change_frame_size_1): Use resize_frame_windows.
5130
5131 * xdisp.c (init_xdisp): Don't use set_window_height but set
5132 heights directly.
5133
5134 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5135 Use resize_frame_windows instead of change_window_heights and run
5136 run_window_configuration_change_hook.
5137
5138 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5139 instead of change_window_heights and run
5140 run_window_configuration_change_hook.
5141
5142 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5143
5144 * window.c (replace_window): Rename second argument REPLACEMENT to
5145 NEW. New third argument SETFLAG. Rewrite.
5146 (delete_window, make_dummy_parent): Call replace_window with
5147 third argument 1.
5148 (window_list_1): Move down in code.
5149 (run_window_configuration_change_hook): Move set_buffer part
5150 before select_frame_norecord part in order to unwind correctly.
5151 Rename count1 to count.
5152 (recombine_windows, delete_deletable_window, resize_root_window)
5153 (Fdelete_other_windows_internal)
5154 (Frun_window_configuration_change_hook, make_parent_window)
5155 (resize_window_check, resize_window_apply, Fresize_window_apply)
5156 (resize_frame_windows, Fsplit_window_internal)
5157 (Fdelete_window_internal, Fresize_mini_window_internal):
5158 New functions.
5159 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5160
5161 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5162
5163 * window.h (window): Add some new members to window structure -
5164 normal_lines, normal_cols, new_total, new_normal, clone_number,
5165 splits, nest, prev_buffers, next_buffers.
5166 (WINDOW_TOTAL_SIZE): Move here from window.c.
5167 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5168
5169 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5170 Remove.
5171 (make_dummy_parent): Set new members of windows structure.
5172 (make_window): Move down in code. Handle new members of window
5173 structure.
5174 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5175 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5176 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5177 (Fset_window_prev_buffers, Fwindow_next_buffers)
5178 (Fset_window_next_buffers, Fset_window_clone_number):
5179 New functions.
5180 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5181 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5182 Doc-string fixes.
5183 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5184 Argument WINDOW can be now internal window too.
5185 (Fwindow_use_time): Move up in code.
5186 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5187 Rewrite doc-string.
5188 (Fset_window_configuration, saved_window)
5189 (Fcurrent_window_configuration, save_window_save): Handle new
5190 members of window structure.
5191 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5192 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5193 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5194 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5195 Qget_mru_window, Qresize_root_window,
5196 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5197 Qauto_buffer_name; staticpro them.
5198
5199 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5200
5201 * window.c (Fwindow_total_size, Fwindow_left_column)
5202 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5203 (Fwindow_list_1): New functions.
5204 (window_box_text_cols): Replace with window_body_cols.
5205 (Fwindow_width, Fscroll_left, Fscroll_right):
5206 Use window_body_cols instead of window_box_text_cols.
5207 (delete_window, Fset_window_configuration):
5208 Call delete_all_subwindows with window as argument.
5209 (delete_all_subwindows): Take a window as argument and not a
5210 structure. Rewrite.
5211 (window_loop): Remove handling of GET_LRU_WINDOW and
5212 GET_LARGEST_WINDOW.
5213 (Fget_lru_window, Fget_largest_window): Move to window.el.
5214
5215 * window.h: Extern window_body_cols instead of
5216 window_box_text_cols. delete_all_subwindows now takes a
5217 Lisp_Object as argument.
5218
5219 * indent.c (compute_motion, Fcompute_motion):
5220 Use window_body_cols instead of window_box_text_cols.
5221
5222 * frame.c (delete_frame): Call delete_all_subwindows with root
5223 window as argument.
5224
5225 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5226
5227 * fns.c (Fputhash): Document return value.
5228
5229 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5230
5231 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5232
5233 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5234
5235 Cons<->int and similar integer overflow fixes (Bug#8794).
5236
5237 Check for overflow when converting integer to cons and back.
5238 * charset.c (Fdefine_charset_internal, Fdecode_char):
5239 Use cons_to_unsigned to catch overflow.
5240 (Fencode_char): Use INTEGER_TO_CONS.
5241 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5242 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5243 * data.c (long_to_cons, cons_to_long): Remove.
5244 (cons_to_unsigned, cons_to_signed): New functions.
5245 These signal an error for invalid or out-of-range values.
5246 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5247 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5248 * font.c (Ffont_variation_glyphs):
5249 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5250 * lisp.h: Include <intprops.h>.
5251 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5252 (cons_to_signed, cons_to_unsigned): New decls.
5253 (long_to_cons, cons_to_long): Remove decls.
5254 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5255 (Fprimitive_undo): Use CONS_TO_INTEGER.
5256 * xfns.c (Fx_window_property): Likewise.
5257 * xselect.c: Include <limits.h>.
5258 (x_own_selection, selection_data_to_lisp_data):
5259 Use INTEGER_TO_CONS.
5260 (x_handle_selection_request, x_handle_selection_clear)
5261 (x_get_foreign_selection, Fx_disown_selection_internal)
5262 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5263 (lisp_data_to_selection_data): Use cons_to_unsigned.
5264 (x_fill_property_data): Use cons_to_signed.
5265 Report values out of range.
5266
5267 Check for buffer and string overflow more precisely.
5268 * buffer.h (BUF_BYTES_MAX): New macro.
5269 * lisp.h (STRING_BYTES_MAX): New macro.
5270 * alloc.c (Fmake_string):
5271 * character.c (string_escape_byte8):
5272 * coding.c (coding_alloc_by_realloc):
5273 * doprnt.c (doprnt):
5274 * editfns.c (Fformat):
5275 * eval.c (verror):
5276 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5277 since they may not be the same number.
5278 * editfns.c (Finsert_char):
5279 * fileio.c (Finsert_file_contents):
5280 Likewise for BUF_BYTES_MAX.
5281
5282 * image.c: Use ptrdiff_t, not int, for sizes.
5283 (slurp_file): Switch from int to ptrdiff_t.
5284 All uses changed.
5285 (slurp_file): Check that file size fits in both size_t (for
5286 malloc) and ptrdiff_t (for sanity and safety).
5287
5288 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5289 if b->modtime has its maximal value.
5290
5291 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5292
5293 Don't assume time_t can fit into int.
5294 * buffer.h (struct buffer.modtime): Now time_t, not int.
5295 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5296 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5297
5298 Minor fixes for signed vs unsigned integers.
5299 * character.h (MAYBE_UNIFY_CHAR):
5300 * charset.c (maybe_unify_char):
5301 * keyboard.c (read_char, reorder_modifiers):
5302 XINT -> XFASTINT, since the integer must be nonnegative.
5303 * ftfont.c (ftfont_spec_pattern):
5304 * keymap.c (access_keymap, silly_event_symbol_error):
5305 XUINT -> XFASTINT, since the integer must be nonnegative.
5306 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5307 since it makes no difference and we prefer signed.
5308 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5309 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5310 nonnegative.
5311
5312 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5313
5314 * window.h (Fwindow_frame): Declare.
5315
5316 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5317
5318 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5319 (SPARE_MEMORY): Always define.
5320 (LARGE_REQUEST): Remove.
5321 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5322
5323 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5324
5325 * lisp.h: Move EXFUNS for Fframe_root_window,
5326 Fframe_first_window and Fset_frame_selected_window to window.h.
5327
5328 * window.h: Move EXFUNS for Fframe_root_window,
5329 Fframe_first_window and Fset_frame_selected_window here from
5330 lisp.h.
5331
5332 * frame.c (Fwindow_frame, Fframe_first_window)
5333 (Fframe_root_window, Fframe_selected_window)
5334 (Fset_frame_selected_window): Move to window.c.
5335 (Factive_minibuffer_window): Move to minibuf.c.
5336 (Fother_visible_frames_p): New function.
5337
5338 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5339
5340 * window.c (decode_window, decode_any_window): Move up in code.
5341 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5342 (inhibit_frame_unsplittable): Remove unused variable.
5343 (Fwindow_buffer): Move up and rewrite doc-string.
5344 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5345 (Fwindow_prev): New functions.
5346 (Fwindow_frame): Move here from frame.c. Accept any window as
5347 argument.
5348 (Fframe_root_window, Fframe_first_window)
5349 (Fframe_selected_window): Move here from frame.c. Accept frame
5350 or arbitrary window as argument. Update doc-strings.
5351 (Fminibuffer_window): Move up in code.
5352 (Fwindow_minibuffer_p): Move up in code and simplify.
5353 (Fset_frame_selected_window): Move here from frame.c.
5354 Marginal rewrite.
5355 (Fselected_window, select_window, Fselect_window): Move up in
5356 code. Minor doc-string fixes.
5357
5358 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5359
5360 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5361 Do not assume that spare memory exists; that assumption is valid
5362 only if SYSTEM_MALLOC.
5363 (LARGE_REQUEST): New macro, so that the issue of large requests
5364 is separated from the issue of spare memory.
5365
5366 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5367
5368 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5369 format. (Bug#8806)
5370
5371 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5372
5373 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5374 before statements.
5375
5376 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5377
5378 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5379
5380 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5381
5382 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5383 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5384
5385 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5386
5387 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5388
5389 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5390
5391 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5392 (x_clipboard_manager_save): Add return value.
5393 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5394 New error handlers.
5395 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5396 Obey Vx_select_enable_clipboard_manager. Catch errors in
5397 x_clipboard_manager_save (Bug#8779).
5398 (Vx_select_enable_clipboard_manager): New variable.
5399 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5400
5401 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5402
5403 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5404
5405 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5406
5407 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5408 in the current matrix if keep_current_p is non-zero.
5409
5410 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5411
5412 * bidi.c (bidi_level_of_next_char): Fix last change.
5413
5414 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5415
5416 Support bidi reordering of text covered by display properties.
5417
5418 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5419 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5420 (bidi_cache_search, bidi_cache_iterator_state)
5421 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5422 (bidi_level_of_next_char, bidi_move_to_visually_next):
5423 Support character positions inside a run of characters covered by a
5424 display string.
5425 (bidi_paragraph_init, bidi_resolve_explicit_1)
5426 (bidi_level_of_next_char): Call bidi_fetch_char and
5427 bidi_fetch_char_advance instead of FETCH_CHAR and
5428 FETCH_CHAR_ADVANCE.
5429 (bidi_init_it): Initialize new members.
5430 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5431 definitions.
5432 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5433 instead of using explicit *_CHAR codes.
5434 (bidi_resolve_explicit, bidi_resolve_weak):
5435 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5436 bidirectional text is supported only in multibyte buffers.
5437 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5438 it to initialize the frame_window_p member of struct bidi_it.
5439 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5440 (bidi_resolve_explicit, bidi_resolve_weak)
5441 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5442 bidi_it->nchars is non-positive.
5443 (bidi_level_of_next_char): Don't try to lookup the cache for the
5444 next/previous character if nothing is cached there yet, or if we
5445 were just reseat()'ed to a new position.
5446
5447 * xdisp.c (set_cursor_from_row): Set start and stop points
5448 according to the row's direction when priming the loop that looks
5449 for the glyph on which to display cursor.
5450 (single_display_spec_intangible_p): Function deleted.
5451 (display_prop_intangible_p): Reimplement to call
5452 handle_display_spec instead of single_display_spec_intangible_p.
5453 Accept 3 additional arguments needed by handle_display_spec.
5454 This fixes incorrect cursor motion across display property with complex
5455 values: lists, `(when COND...)' forms, etc.
5456 (single_display_spec_string_p): Support property values that are
5457 lists with the argument STRING its top-level element.
5458 (display_prop_string_p): Fix the condition for processing a
5459 property that is a list to be consistent with handle_display_spec.
5460 (handle_display_spec): New function, refactored from the
5461 last portion of handle_display_prop.
5462 (compute_display_string_pos): Accept additional argument
5463 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5464 value of a `display' property is a "replacing spec".
5465 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5466 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5467 the display property, but just return a value indicating whether
5468 the display property will replace the characters it covers.
5469 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5470 frame_window_p members of struct bidi_it.
5471 (compute_display_string_pos, compute_display_string_end):
5472 New functions.
5473 (push_it): Accept second argument POSITION, where pop_it should
5474 jump to continue iteration.
5475 (reseat_1): Initialize bidi_it.disp_pos.
5476
5477 * keyboard.c (adjust_point_for_property): Adjust the call to
5478 display_prop_intangible_p to its new signature.
5479
5480 * dispextern.h (struct bidi_it): New member frame_window_p.
5481 (bidi_init_it): Update prototypes.
5482 (display_prop_intangible_p): Update prototype.
5483 (compute_display_string_pos, compute_display_string_end):
5484 Declare prototypes.
5485 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5486 EMACS_INT.
5487
5488 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5489
5490 Malloc failure behavior now depends on size of allocation.
5491 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5492 * lisp.h: Change signatures accordingly.
5493 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5494 All callers changed. (Bug#8762)
5495
5496 * gnutls.c: Use Emacs's memory allocators.
5497 Without this change, the gnutls library would invoke malloc etc.
5498 directly, which causes problems on non-SYNC_INPUT hosts, and which
5499 runs afoul of improving memory_full behavior. (Bug#8761)
5500 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5501 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5502 xfree instead of the default malloc, realloc, free.
5503 (Fgnutls_boot): No need to check for memory allocation failure,
5504 since xmalloc does that for us.
5505
5506 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5507 * category.c (hash_get_category_set):
5508 * ccl.c (ccl_driver):
5509 * charset.c (Fdefine_charset_internal):
5510 * charset.h (struct charset.hash_index):
5511 * composite.c (get_composition_id, gstring_lookup_cache)
5512 (composition_gstring_put_cache):
5513 * composite.h (struct composition.hash_index):
5514 * dispextern.h (struct image.hash):
5515 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5516 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5517 (hashfn_equal, hashfn_user_defined, make_hash_table)
5518 (maybe_resize_hash_table, hash_lookup, hash_put)
5519 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5520 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5521 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5522 * image.c (make_image, search_image_cache, lookup_image)
5523 (xpm_put_color_table_h):
5524 * lisp.h (struct Lisp_Hash_Table):
5525 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5526 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5527 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5528 * alloc.c (allocate_vectorlike):
5529 Check for overflow in vector size calculations.
5530 * ccl.c (ccl_driver):
5531 Check for overflow when converting EMACS_INT to int.
5532 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5533 need to be updated by these changes.
5534 * fns.c (make_hash_table, maybe_resize_hash_table):
5535 Check for integer overflow with large hash tables.
5536 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5537 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5538 (SXHASH_REDUCE): New macro.
5539 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5540 Use it instead of discarding useful hash info with large hash values.
5541 (sxhash_float): New function.
5542 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5543 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5544 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5545 Rewrite to use FIXNUM_BITS, as this simplifies things.
5546 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5547 Adjust signatures to match updated version of code.
5548 (consing_since_gc): Now EMACS_INT, since a single hash table can
5549 use more than INT_MAX bytes.
5550
5551 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5552
5553 Make it possible to build with GCC-4.6+ -O2 -flto.
5554
5555 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5556
5557 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5558
5559 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5560 Call minibuffer-inactive-mode.
5561
5562 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5563
5564 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5565 Update dependencies.
5566
5567 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5568
5569 * data.c (init_data): Remove code for UTS, this system is not
5570 supported anymore.
5571
5572 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5573
5574 Don't force ./temacs to start in terminal mode.
5575
5576 * frame.c (make_initial_frame): Initialize faces in all cases, not
5577 only when CANNOT_DUMP is defined.
5578 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5579
5580 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5581
5582 * dispnew.c (add_window_display_history): Use const for the string
5583 pointer. Remove declaration, not needed.
5584
5585 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5586
5587 Use 'inline', not 'INLINE'.
5588 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5589 * alloc.c, fontset.c (INLINE): Remove.
5590 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5591 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5592 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5593 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5594 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5595
5596 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5597
5598 Make it possible to run ./temacs.
5599
5600 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5601 syms_of_callproc does the same thing. Remove test for
5602 "initialized", do it in the caller.
5603 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5604
5605 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5606
5607 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5608 (read_minibuf): Use get_minibuffer.
5609 (syms_of_minibuf): Use DEFSYM.
5610 (Qmetadata): New var.
5611 * data.c (Qbuffer): Don't make it static.
5612 (syms_of_data): Use DEFSYM.
5613
5614 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5615
5616 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5617 (CCL_CODE_MIN): New macro.
5618
5619 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5620
5621 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5622
5623 * eval.c (Qdebug): Now static.
5624 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5625 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5626 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5627
5628 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5629
5630 * image.c: Various fixes to ImageMagick code comments.
5631 (Fimagemagick_types): Doc fix.
5632
5633 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5634
5635 Minor fixes prompted by GCC 4.6.0 warnings.
5636
5637 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5638
5639 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5640 (x_clipboard_manager_save_all): Move extern decl to ...
5641 * xterm.h: ... here, so that it can be checked for consistency.
5642
5643 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5644
5645 * xselect.c (x_clipboard_manager_save_frame)
5646 (x_clipboard_manager_save_all): New functions.
5647 (Fx_clipboard_manager_save): Lisp function deleted.
5648
5649 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5650 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5651
5652 * xterm.h: Update prototype.
5653
5654 2011-05-28 William Xu <william.xwl@gmail.com>
5655
5656 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5657 exiting (Bug#8239).
5658
5659 2011-05-28 Jim Meyering <meyering@redhat.com>
5660
5661 Avoid a sign-extension bug in crypto_hash_function.
5662 * fns.c (to_uchar): Define.
5663 (crypto_hash_function): Use it to convert some newly-signed
5664 variables to unsigned, to avoid sign-extension bugs. For example,
5665 without this change, (md5 "truc") would evaluate to
5666 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5667 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5668 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5669
5670 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5671
5672 Integer overflow fixes.
5673
5674 * dbusbind.c: Serial number integer overflow fixes.
5675 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5676 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5677 to hold a serial number that is too large for a fixnum.
5678 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5679 Check for serial numbers out of range. Decode any serial number
5680 that was so large that it became a float. (Bug#8722)
5681
5682 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5683 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5684 Use XFASTINT rather than XUINT when numbers are nonnegative.
5685 (xd_append_arg, Fdbus_method_return_internal):
5686 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5687 arguments, check that Lisp number is nonnegative, rather than
5688 silently wrapping negative numbers around. (Bug#8722)
5689 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5690 (Bug#8722)
5691
5692 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5693
5694 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5695
5696 ccl: Add integer overflow checks.
5697 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5698 (IN_INT_RANGE): New macros.
5699 (ccl_driver): Use them to check for integer overflow when
5700 decoding a CCL program. Many of the new checks are whether XINT (x)
5701 fits in int; it doesn't always, on 64-bit hosts. The new version
5702 doesn't catch all possible integer overflows, but it's an
5703 improvement. (Bug#8719)
5704
5705 * alloc.c (make_event_array): Use XINT, not XUINT.
5706 There's no need for unsigned here.
5707
5708 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5709 This follows up to the 2011-05-06 change that substituted uintptr_t
5710 for EMACS_INT. This case wasn't caught back then.
5711
5712 Rework Fformat to avoid integer overflow issues.
5713 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5714 now (part of C89). Include <verify.h>.
5715 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5716 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5717 (Fformat): Avoid the prepass trying to compute sizes; it was only
5718 approximate and thus did not catch overflow reliably. Instead, walk
5719 through the format just once, formatting and computing sizes as we go,
5720 checking for integer overflow at every step, and allocating a larger
5721 buffer as needed. Keep track separately whether the format is
5722 multibyte. Keep only the most-recently calculated precision, rather
5723 than them all. Record whether each argument has been converted to
5724 string. Use EMACS_INT, not int, for byte and char and arg counts.
5725 Support field widths and precisions larger than INT_MAX. Avoid
5726 sprintf's undefined behavior with conversion specifications such as %#d
5727 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5728 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5729 formatting out-of-range floating point numbers with int
5730 formats. (Bug#8668)
5731
5732 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5733
5734 * data.c: Avoid integer truncation in expressions involving floats.
5735 * data.c: Include <intprops.h>.
5736 (arith_driver): When there's an integer overflow in an expression
5737 involving floating point, convert the integers to floating point
5738 so that the resulting value does not suffer from catastrophic
5739 integer truncation. For example, on a 64-bit host (* 4
5740 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5741 Do not rely on undefined behavior after integer overflow.
5742
5743 merge count_size_as_multibyte, parse_str_to_multibyte
5744 * character.c, character.h (count_size_as_multibyte):
5745 Rename from parse_str_to_multibyte; all uses changed.
5746 Check for integer overflow.
5747 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5748 since it's now a duplicate of the other. This is more of
5749 a character than a buffer op, so better that it's in character.c.
5750 * fns.c, print.c: Adjust to above changes.
5751
5752 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5753
5754 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5755
5756 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5757
5758 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5759 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5760 (x_clipboard_manager_save): Now static.
5761 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5762
5763 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5764 (crypto_hash_function): Now static.
5765 Fix pointer signedness problems. Avoid unnecessary initializations.
5766
5767 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5768
5769 * termhooks.h (Vselection_alist): Make it terminal-local.
5770
5771 * terminal.c (create_terminal): Initialize it.
5772
5773 * xselect.c: Support for clipboard managers.
5774 (Vselection_alist): Move to termhooks.h as terminal-local var.
5775 (LOCAL_SELECTION): New macro.
5776 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5777 (symbol_to_x_atom): Remove gratuitous arg.
5778 (x_handle_selection_request, lisp_data_to_selection_data)
5779 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5780 (x_own_selection, x_get_local_selection, x_convert_selection):
5781 New arg, specifying work frame. Use terminal-local Vselection_alist.
5782 (some_frame_on_display): Delete unused function.
5783 (Fx_own_selection_internal, Fx_get_selection_internal)
5784 (Fx_disown_selection_internal, Fx_selection_owner_p)
5785 (Fx_selection_exists_p): New optional frame arg.
5786 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5787 (x_handle_selection_clear): Don't treat other terminals with the
5788 same keyboard specially. Use the terminal-local Vselection_alist.
5789 (x_clear_frame_selections): Use Frun_hook_with_args.
5790
5791 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5792
5793 * xterm.h: Add support for those atoms.
5794
5795 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5796
5797 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5798 (converted_selections, conversion_fail_tag): New global variables.
5799 (x_selection_request_lisp_error): Free the above.
5800 (x_get_local_selection): Remove unnecessary code.
5801 (x_reply_selection_request): Args changed; handle arbitrary array
5802 of converted selections stored in converted_selections.
5803 Separate the XChangeProperty and SelectionNotify steps.
5804 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5805 (x_convert_selection): New function.
5806 (x_handle_selection_event): Simplify.
5807 (x_get_foreign_selection): Don't ignore incoming requests while
5808 waiting for an answer; this will fail when we implement
5809 SAVE_TARGETS, and seems unnecessary anyway.
5810 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5811 (Vx_sent_selection_functions): Doc fix.
5812
5813 2011-05-26 Leo Liu <sdl.web@gmail.com>
5814
5815 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5816
5817 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5818
5819 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5820
5821 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5822 for fringe update if it has periodic bitmap.
5823 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5824 and fringe_bitmap_periodic_p.
5825
5826 * fringe.c (get_fringe_bitmap_data): New function.
5827 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5828 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5829 row. Mark glyph row for fringe update if periodicity changed.
5830
5831 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5832 for fringe update unless it has periodic bitmap.
5833
5834 2011-05-25 Kenichi Handa <handa@m17n.org>
5835
5836 * xdisp.c (get_next_display_element): Set correct it->face_id for
5837 a static composition.
5838
5839 2011-05-24 Leo Liu <sdl.web@gmail.com>
5840
5841 * deps.mk (fns.o):
5842 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5843
5844 * fns.c (crypto_hash_function, Fsha1): New function.
5845 (Fmd5): Use crypto_hash_function.
5846 (syms_of_fns): Add Ssha1.
5847
5848 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5849
5850 * gnutls.c: Remove unused macros.
5851 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5852 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5853 Remove macros that are defined and never used.
5854 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5855
5856 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5857
5858 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5859 (Fx_get_selection_internal): Minor cleanup.
5860 (Fx_own_selection_internal): Rename arguments for consistency with
5861 select.el.
5862
5863 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5864
5865 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5866
5867 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5868
5869 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5870
5871 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5872
5873 * dispnew.c (scrolling_window): Don't exclude the case that the
5874 last enabled row in the desired matrix touches the bottom boundary.
5875
5876 2011-05-21 Glenn Morris <rgm@gnu.org>
5877
5878 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5879 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5880 and add some more files.
5881
5882 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5883
5884 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5885 report_file_error introduced by the change from 2011-05-07.
5886
5887 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5888
5889 * systime.h (Time): Define only if emacs is defined.
5890 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5891 where the include path doesn't have X11/X.h by default. See
5892 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5893
5894 2011-05-20 Kenichi Handa <handa@m17n.org>
5895
5896 * composite.c (find_automatic_composition): Fix previous change.
5897
5898 2011-05-20 Glenn Morris <rgm@gnu.org>
5899
5900 * lisp.mk: New file, split from Makefile.in.
5901 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5902 (shortlisp): Remove.
5903 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5904
5905 2011-05-19 Glenn Morris <rgm@gnu.org>
5906
5907 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5908 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5909 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5910 (lisp): Set the order to that of loadup.el.
5911 (shortlisp): Make it a copy of $lisp.
5912 (SOME_MACHINE_LISP): Remove.
5913 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5914 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5915
5916 2011-05-18 Kenichi Handa <handa@m17n.org>
5917
5918 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5919 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5920 (find_automatic_composition): Mostly rewrite for efficiency.
5921
5922 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5923
5924 * makefile.w32-in: Update dependencies.
5925
5926 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5927
5928 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5929 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5930
5931 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5932
5933 Fix some integer overflow issues, such as string length overflow.
5934
5935 * insdel.c (count_size_as_multibyte): Check for string overflow.
5936
5937 * character.c (lisp_string_width): Check for string overflow.
5938 Use EMACS_INT, not int, for string indexes and lengths; in
5939 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5940 the resulting string length overflows an EMACS_INT; instead,
5941 report a string overflow if no precision given. When checking for
5942 precision exhaustion, use a check that cannot possibly have
5943 integer overflow. (Bug#8675)
5944 * character.h (lisp_string_width): Adjust to new signature.
5945
5946 * alloc.c (string_overflow): New function.
5947 (Fmake_string): Use it. This doesn't change behavior, but saves
5948 a few bytes and will simplify future changes.
5949 * character.c (string_escape_byte8): Likewise.
5950 * lisp.h (string_overflow): New decl.
5951
5952 Fixups, following up to the user-interface timestamp change.
5953 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5954 for UI timestamps, instead of unsigned long.
5955 * msdos.c (mouse_get_pos): Likewise.
5956 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5957 * w32gui.h (Time): Define by including "systime.h" rather than by
5958 declaring it ourselves. (Bug#8664)
5959
5960 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5961 * image.c (clear_image_cache): Likewise.
5962
5963 * term.c (term_mouse_position): Don't assume time_t wraparound.
5964
5965 Be more systematic about user-interface timestamps.
5966 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5967 and sometimes 'EMACS_UINT', to represent these timestamps.
5968 This change causes it to use 'Time' uniformly, as that's what X uses.
5969 This makes the code easier to follow, and makes it easier to catch
5970 integer overflow bugs such as Bug#8664.
5971 * frame.c (Fmouse_position, Fmouse_pixel_position):
5972 Use Time, not unsigned long, for user-interface timestamps.
5973 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5974 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5975 * keyboard.h (last_event_timestamp): Likewise.
5976 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5977 * menu.h (xmenu_show): Likewise.
5978 * term.c (term_mouse_position): Likewise.
5979 * termhooks.h (struct input_event.timestamp): Likewise.
5980 (struct terminal.mouse_position_hook): Likewise.
5981 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5982 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5983 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5984 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5985 what it was before.
5986 * menu.h, termhooks.h: Include "systime.h", for Time.
5987
5988 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5989 Don't assume that the difference between two unsigned long values
5990 can fit into an integer. At this point, we know button_down_time
5991 <= event->timestamp, so the difference must be nonnegative, so
5992 there's no need to cast the result if double-click-time is
5993 nonnegative, as it should be; check that it's nonnegative, just in
5994 case. This bug is triggered when events are more than 2**31 ms
5995 apart (about 25 days). (Bug#8664)
5996
5997 * xselect.c (last_event_timestamp): Remove duplicate decl.
5998 (x_own_selection): Remove needless cast to unsigned long.
5999
6000 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6001 that always fit in int. Use a sentinel instead of a counter, to
6002 avoid a temp and to allay GCC's concerns about possible int overflow.
6003 * frame.h (struct frame): Use int for menu_bar_items_used
6004 instead of EMACS_INT, since it always fits in int.
6005
6006 * menu.c (grow_menu_items): Check for int overflow.
6007
6008 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6009
6010 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6011 Before, the code was not consistent. These values cannot exceed
6012 2**31 - 1 so there's no need to make them unsigned.
6013 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6014 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6015 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6016 as modifiers.
6017 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6018
6019 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6020 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6021 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6022 presumably because the widths might not match.
6023
6024 * window.c (size_window): Avoid needless test at loop start.
6025
6026 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6027
6028 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6029
6030 2011-05-12 Drew Adams <drew.adams@oracle.com>
6031
6032 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6033
6034 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6035
6036 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6037 `width' to `bar_area_x' and `bar_area_width', respectively.
6038 (x_scroll_run): Take account of fringe background extension.
6039
6040 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6041 Rename local vars `left' and `width' to `bar_area_x' and
6042 `bar_area_width', respectively.
6043 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6044 background extension.
6045
6046 2011-05-10 Jim Meyering <meyering@redhat.com>
6047
6048 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6049
6050 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6051
6052 * image.c (Finit_image_library): Return t for built-in image types,
6053 like pbm and xbm. (Bug#8640)
6054
6055 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6056
6057 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6058
6059 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6060
6061 * w32console.c (Fset_screen_color): Doc fix.
6062 (Fget_screen_color): New function.
6063 (syms_of_ntterm): Defsubr it.
6064
6065 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6066 unlink the temporary file if Fcall_process didn't create it in the
6067 first place.
6068 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6069 child process will be redirected to a file specified with `:file'.
6070 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6071 cue to call_process_cleanup not to close that handle.
6072
6073 2011-05-07 Ben Key <bkey76@gmail.com>
6074
6075 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6076 one of two shell specific rules, either bootstrap-temacs-CMD or
6077 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6078 to the previous implementation of the bootstrap-temacs rule.
6079 The bootstrap-temacs-CMD rule is similar to the previous
6080 implementation of the bootstrap-temacs rule except that it
6081 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6082 variable.
6083
6084 These changes, along with some changes to nt/configure.bat,
6085 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6086 earlier fix to add support for --cflags and --ldflags options
6087 that include quotes so that it works whether make uses cmd or
6088 sh as the shell.
6089
6090 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6091
6092 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6093 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6094 is a constant.
6095 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6096 a string. Handle both cases.
6097 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6098 (Fdbus_register_method): Use Qinvalid_function.
6099
6100 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6101
6102 * makefile.w32-in: Update dependencies.
6103 (LISP_H): Add inttypes.h and stdin.h.
6104 (PROCESS_H): Add unistd.h.
6105
6106 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6107
6108 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6109 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6110
6111 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6112
6113 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6114
6115 * term.c (vfatal): Remove stray call to va_end.
6116 It's not needed and the C Standard doesn't allow it here anyway.
6117
6118 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6119 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6120
6121 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6122 bytes.
6123
6124 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6125
6126 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6127
6128 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6129
6130 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6131
6132 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6133
6134 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6135 * charset.c (Fdefine_charset_internal): Don't initialize
6136 charset.code_space[15]. The value was garbage, on hosts with
6137 32-bit int (Bug#8600).
6138
6139 * lread.c (read_integer): Be more consistent with string-to-number.
6140 Use string_to_number to do the actual conversion; this avoids
6141 rounding errors and fixes some other screwups. Without this fix,
6142 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6143 (digit_to_number): Move earlier, for benefit of read_integer.
6144 Return -1 if the digit is out of range for the base, -2 if it is
6145 not a digit in any supported base. (Bug#8602)
6146
6147 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6148
6149 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6150 to match comment at start of function. This also removes a
6151 GCC warning about overflow in a 32+64-bit port.
6152
6153 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6154
6155 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6156 Reported by Stefan Monnier in
6157 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6158 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6159 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6160
6161 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6162 (EMACS_UINTPTR): Likewise, with uintptr_t.
6163
6164 * lisp.h: Prefer 64-bit EMACS_INT if available.
6165 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6166 on 32-bit hosts that have 64-bit int, so that they can access
6167 large files.
6168 However, temporarily disable this change unless the temporary
6169 symbol WIDE_EMACS_INT is defined.
6170
6171 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6172
6173 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6174 This removes an assumption that EMACS_INT and long are the same
6175 width as pointers. The assumption is true for Emacs porting targets
6176 now, but we want to make other targets possible.
6177 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6178 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6179 In the rest of the code, change types of integers that hold casted
6180 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6181 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6182 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6183 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6184 No need to cast type when ORing.
6185 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6186 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6187 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6188 assume EMACS_INT is the same width as char *.
6189 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6190 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6191 Remove no-longer-needed casts.
6192 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6193 (xg_tool_bar_help_callback, xg_make_tool_item):
6194 Use EMACS_INTPTR to hold an integer
6195 that will be cast to void *; this can avoid a GCC warning
6196 if EMACS_INT is not the same width as void *.
6197 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6198 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6199 (current_message_1, set_message_1):
6200 Use a local to convert to proper width without a cast.
6201 * xmenu.c (dialog_selection_callback): Likewise.
6202
6203 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6204 Also, don't assume VALBITS / RAND_BITS is less than 5,
6205 and don't rely on undefined behavior when shifting a 1 left into
6206 the sign bit.
6207 * lisp.h (get_random): Change signature to match.
6208
6209 * lread.c (hash_string): Use size_t, not int, for hash computation.
6210 Normally we prefer signed values; but hashing is special, because
6211 it's better to use unsigned division on hash table sizes so that
6212 the remainder is nonnegative. Also, size_t is the natural width
6213 for hashing into memory. The previous code used 'int', which doesn't
6214 retain enough info to hash well into very large tables.
6215 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6216
6217 * dbusbind.c: Don't possibly lose pointer info when converting.
6218 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6219 Use XPNTR rather than XHASH, so that the high-order bits of
6220 the pointer aren't lost when converting through void *.
6221
6222 * eval.c (Fautoload): Don't double-shift a pointer.
6223
6224 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6225
6226 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6227
6228 * gnutls.c (DEF_GNUTLS_FN):
6229 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6230
6231 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6232
6233 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6234 marker. (Bug#8610)
6235
6236 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6237
6238 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6239 New version that can reserve upto 2GB of heap space.
6240
6241 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6242
6243 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6244
6245 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6246
6247 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6248 `gnutls_certificate_set_x509_key_file'.
6249
6250 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6251
6252 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6253 Update dependencies.
6254
6255 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6256
6257 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6258 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6259 Remove unused parameter `fildes'.
6260 * process.c (read_process_output, send_process): Don't pass it.
6261
6262 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6263
6264 Fix previous change: the library cache is defined in w32.c.
6265 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6266 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6267
6268 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6269
6270 Implement dynamic loading of GnuTLS on Windows.
6271
6272 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6273 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6274 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6275 Declare.
6276
6277 * gnutls.c (Qgnutls_dll): Define.
6278 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6279 (gnutls_*): Declare function pointers.
6280 (init_gnutls_functions): New function to initialize function pointers.
6281 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6282 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6283 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6284 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6285 (emacs_gnutls_write, emacs_gnutls_read)
6286 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6287 (Fgnutls_available_p): New function.
6288 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6289 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6290 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6291
6292 * image.c: Include w32.h.
6293 (Vimage_type_cache): Delete.
6294 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6295 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6296 (w32_delayed_load): Move to w32.c.
6297
6298 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6299
6300 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6301 (w32_delayed_load): Move from image.c. When loading a library, record
6302 its filename in the :loaded-from property of the library id.
6303 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6304 Initialize and staticpro them.
6305 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6306
6307 * process.c: Include lisp.h before w32.h, not after.
6308 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6309 instead of gnutls_record_check_pending.
6310
6311 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6312
6313 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6314
6315 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6316 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6317 as passed in.
6318
6319 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6320
6321 * xterm.c (x_set_frame_alpha): Do not set property on anything
6322 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6323
6324 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6325
6326 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6327
6328 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6329
6330 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6331 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6332 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6333 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6334 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6335 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6336 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6337 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6338 (Qgnutls_bootprop_callbacks_verify): Make static.
6339
6340 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6341
6342 * callproc.c: Indentation fixup.
6343
6344 * sysdep.c (wait_for_termination_1): Make static.
6345 (wait_for_termination, interruptible_wait_for_termination):
6346 Move after wait_for_termination_1.
6347
6348 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6349
6350 * sysdep.c (interruptible_wait_for_termination): New function
6351 which is like wait_for_termination, but allows keyboard
6352 interruptions.
6353
6354 * callproc.c (Fcall_process): Add (:file "file") as an option for
6355 the STDOUT buffer.
6356 (Fcall_process_region): Ditto.
6357
6358 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6359
6360 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6361 rather than `XVECTOR (FOO)->size'.
6362
6363 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6364 inttypes.h, as a gnulib replacement is used if it not available in
6365 system headers.
6366
6367 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6368
6369 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6370 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6371 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6372
6373 * coding.c (coding_alloc_by_realloc): Error out if destination
6374 will grow beyond MOST_POSITIVE_FIXNUM.
6375 (decode_coding_emacs_mule): Abort if there isn't enough place in
6376 charbuf for the composition carryover bytes. Reserve an extra
6377 space for up to 2 characters produced in a loop.
6378 (decode_coding_iso_2022): Abort if there isn't enough place in
6379 charbuf for the composition carryover bytes.
6380
6381 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6382
6383 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6384 aborting when %lld or %lll format is passed.
6385 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6386 %llo or %llx format is passed. (Bug#8545)
6387
6388 * window.c (window_scroll_line_based): Use a marker instead of
6389 simple variables to record original value of point. (Bug#7952)
6390
6391 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6392 produced by %s or %c overflows available buffer space. (Bug#8545)
6393
6394 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6395
6396 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6397 (SIZE_MAX): Move defn after all includes, as they might #define it.
6398
6399 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6400
6401 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6402
6403 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6404
6405 * keyboard.c (Qdelayed_warnings_hook): Define.
6406 (command_loop_1): Run `delayed-warnings-hook'
6407 if Vdelayed_warnings_list is non-nil.
6408 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6409 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6410
6411 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6412
6413 * doprnt.c (doprnt): Don't return value smaller than the buffer
6414 size if the message was truncated. (Bug#8545).
6415
6416 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6417
6418 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6419 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6420
6421 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6422
6423 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6424
6425 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6426
6427 * makefile.w32-in: Update dependencies.
6428
6429 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6430
6431 Improve `doprnt' and its usage. (Bug#8545)
6432 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6433 `format_end'. Remove support for %l as a conversion specifier.
6434 Don't use xrealloc. Improve diagnostics when the %l size modifier
6435 is used. Update the commentary.
6436
6437 * eval.c (verror): Simplify calculation of size_t.
6438
6439 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6440 messages.
6441
6442 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6443
6444 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6445 change.
6446
6447 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6448
6449 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6450 This makes this file independent of the recent pseudovector change.
6451
6452 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6453
6454 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6455
6456 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6457 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6458 Remove unused local.
6459 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6460
6461 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6462 GCC 4.6.0 optimizes based on type-based alias analysis.
6463 For example, if b is of type struct buffer * and v of type struct
6464 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6465 != &v->size, and therefore "v->size = 1; b->size = 2; return
6466 v->size;" must therefore return 1. This assumption is incorrect
6467 for Emacs, since it type-puns struct Lisp_Vector * with many other
6468 types. To fix this problem, this patch adds a new type struct
6469 vectorlike_header that documents the constraints on layout of vectors
6470 and pseudovectors, and helps optimizing compilers not get fooled
6471 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6472 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6473 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6474 the size member.
6475 (XSETPVECTYPE): Rewrite in terms of new macro.
6476 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6477 This is a bit clearer, and further avoids the possibility of
6478 undesirable aliasing.
6479 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6480 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6481 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6482 since Lisp_Subr is a special case (no "next" field).
6483 (ASIZE): Now uses header.size rather than size.
6484 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6485 to avoid the hassle of writing XVECTOR (foo)->header.size.
6486 (struct vectorlike_header): New type.
6487 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6488 object, to help avoid aliasing.
6489 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6490 (SUBRP): Likewise, since Lisp_Subr is a special case.
6491 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6492 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6493 (struct Lisp_Hash_Table): Combine first two members into a single
6494 struct vectorlike_header member. All uses of "size" and "next" members
6495 changed to be "header.size" and "header.next".
6496 * buffer.h (struct buffer): Likewise.
6497 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6498 * frame.h (struct frame): Likewise.
6499 * process.h (struct Lisp_Process): Likewise.
6500 * termhooks.h (struct terminal): Likewise.
6501 * window.c (struct save_window_data, struct saved_window): Likewise.
6502 * window.h (struct window): Likewise.
6503 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6504 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6505 * buffer.c (init_buffer_once): Likewise.
6506 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6507 special case.
6508 * process.c (Fformat_network_address): Use local var for size,
6509 for brevity.
6510
6511 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6512
6513 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6514 * data.c (atof): Remove decl; no longer used or needed.
6515 (digit_to_number): Move to lread.c.
6516 (Fstring_to_number): Use new string_to_number function, to be
6517 consistent with how the Lisp reader treats infinities and NaNs.
6518 Do not assume that floating-point numbers represent EMACS_INT
6519 without losing information; this is not true on most 64-bit hosts.
6520 Avoid double-rounding errors, by insisting on integers when
6521 parsing non-base-10 numbers, as the documentation specifies.
6522 * lisp.h (string_to_number): New decl, replacing ...
6523 (isfloat_string): Remove.
6524 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6525 (read1): Do not accept +. and -. as integers; this
6526 appears to have been a coding error. Similarly, do not accept
6527 strings like +-1e0 as floating point numbers. Do not report
6528 overflow for integer overflows unless the base is not 10 which
6529 means we have no simple and reliable way to continue.
6530 Break out the floating-point parsing into a new
6531 function string_to_number, so that Fstring_to_number parses
6532 floating point numbers consistently with the Lisp reader.
6533 (digit_to_number): Move here from data.c. Make it static inline.
6534 (E_CHAR, EXP_INT): Remove, replacing with ...
6535 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6536 (string_to_number): New function, replacing isfloat_string.
6537 This function checks for valid syntax and produces the resulting
6538 Lisp float number too. Rework it so that string-to-number
6539 no longer mishandles examples like "1.0e+". Use strtoumax,
6540 so that overflow for non-base-10 numbers is reported only when
6541 there's no portable and simple way to convert to floating point.
6542
6543 * textprop.c (set_text_properties_1): Rewrite for clarity,
6544 and to avoid GCC warning about integer overflow.
6545
6546 * intervals.h (struct interval): Use EMACS_INT for members
6547 where EMACS_UINT might cause problems. See
6548 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6549 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6550 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6551 All uses changed.
6552 (offset_intervals): Tell GCC not to worry about length overflow
6553 when negating a negative length.
6554
6555 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6556 (overrun_check_free): Likewise.
6557
6558 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6559 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6560 word size.
6561
6562 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6563 (gnutls_make_error): Rename local to avoid shadowing.
6564 (gnutls_emacs_global_deinit): ifdef out; not used.
6565 (Fgnutls_boot): Use const for pointer to readonly storage.
6566 Comment out unused local. Fix pointer signedness problems.
6567
6568 * lread.c (openp): Don't stuff size_t into an 'int'.
6569 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6570 about possible signed overflow.
6571
6572 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6573 (GDK_KEY_g): Don't define if already defined.
6574 (xg_prepare_tooltip): Avoid pointer signedness problem.
6575 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6576
6577 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6578 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6579
6580 * xfns.c (Fx_window_property): Simplify a bit,
6581 to make a bit faster and to avoid GCC 4.6.0 warning.
6582 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6583
6584 * fns.c (internal_equal): Don't assume size_t fits in int.
6585
6586 * alloc.c (compact_small_strings): Tighten assertion a little.
6587
6588 Replace pEd with more-general pI, and fix some printf arg casts.
6589 * lisp.h (pI): New macro, generalizing old pEd macro to other
6590 conversion specifiers. For example, use "...%"pI"d..." rather
6591 than "...%"pEd"...".
6592 (pEd): Remove. All uses replaced with similar uses of pI.
6593 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6594 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6595 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6596 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6597 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6598 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6599 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6600 64-bit hosts.
6601 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6602 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6603 * print.c (safe_debug_print, print_object): Likewise.
6604 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6605 to int.
6606 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6607 avoiding the 0 flag, which is not portable.
6608 * process.c (Fmake_network_process): Use pI to avoid cast.
6609 * region-cache.c (pp_cache): Likewise.
6610 * xdisp.c (decode_mode_spec): Likewise.
6611 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6612 behavior on 64-bit hosts with printf arg.
6613 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6614 (x_stop_queuing_selection_requests): Likewise.
6615 (x_get_window_property): Don't truncate byte count to an 'int'
6616 when tracing.
6617
6618 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6619 here, since it parses constructs like leading '-' and spaces,
6620 which are not wanted; and it overflows with large numbers.
6621 Instead, simply match F[0-9]+, which is what is wanted anyway.
6622
6623 * alloc.c: Remove unportable assumptions about struct layout.
6624 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6625 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6626 (allocate_vectorlike, make_pure_vector): Use the new macros,
6627 plus offsetof, to remove unportable assumptions about struct layout.
6628 These assumptions hold on all porting targets that I know of, but
6629 they are not guaranteed, they're easy to remove, and removing them
6630 makes further changes easier.
6631
6632 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6633 This doesn't fix a bug but makes the code clearer.
6634 (string_overrun_cookie): Now const. Use initializers that
6635 don't formally overflow signed char, to avoid warnings.
6636 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6637 can cause Emacs to crash when string overrun checking is enabled.
6638 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6639 multiple of sizeof (EMACS_INT); it need not be, if
6640 alignof(EMACS_INT) < sizeof (EMACS_INT).
6641 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6642
6643 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6644
6645 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6646
6647 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6648
6649 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6650 supposed to be handshaking. (Bug#8556)
6651 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6652
6653 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6654
6655 * lisp.h (Qdebug): List symbol.
6656 * eval.c (Qdebug): Restore global linkage.
6657 * keyboard.c (debug-on-event): New variable.
6658 (handle_user_signal): Break into debugger when debug-on-event
6659 matches the current signal symbol.
6660
6661 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6662
6663 * alloc.c (check_sblock, check_string_bytes)
6664 (check_string_free_list): Convert to standard C.
6665
6666 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6667
6668 * w32.c (emacs_gnutls_push): Fix typo.
6669
6670 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6671
6672 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6673 "cast to pointer from integer of different size".
6674
6675 Improve doprnt and its use in verror. (Bug#8545)
6676 * doprnt.c (doprnt): Document the set of format control sequences
6677 supported by the function. Use SAFE_ALLOCA instead of always
6678 using `alloca'.
6679
6680 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6681 is one byte too soon. Don't use xrealloc; instead xfree and
6682 xmalloc anew.
6683
6684 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6685
6686 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6687 callbacks stage.
6688
6689 * gnutls.c: Renamed global_initialized to
6690 gnutls_global_initialized. Added internals for the
6691 :verify-hostname-error, :verify-error, and :verify-flags
6692 parameters of `gnutls-boot' and documented those parameters in the
6693 docstring. Start callback support.
6694 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6695 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6696 on error. Return error code.
6697 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6698 (emacs_gnutls_read): Likewise.
6699 (Fgnutls_boot): Return handshake error code.
6700 (emacs_gnutls_handle_error): New function.
6701 (wsaerror_to_errno): Likewise.
6702
6703 * w32.h (emacs_gnutls_pull): Add prototype.
6704 (emacs_gnutls_push): Likewise.
6705
6706 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6707 (emacs_gnutls_push): Likewise.
6708
6709 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6710
6711 * process.c (wait_reading_process_output): Check if GnuTLS
6712 buffered some data internally if no FDs are set for TLS
6713 connections.
6714
6715 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6716 (LIBS): Link to USER_LIBS.
6717 ($(BLD)/gnutls.$(0)): New target.
6718
6719 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6720
6721 * xdisp.c (handle_single_display_spec): Rename the
6722 display_replaced_before_p argument into display_replaced_p, to
6723 make it consistent with the commentary. Fix typos in the
6724 commentary.
6725
6726 * textprop.c (syms_of_textprop): Remove dead code.
6727 (copy_text_properties): Delete obsolete commentary about an
6728 interface that was deleted long ago. Fix typos in the description
6729 of arguments.
6730
6731 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6732 to changes in oldXMenu/XMenu.h from 2011-04-16.
6733 <menu_help_message, prev_menu_help_message>: Constify.
6734 (IT_menu_make_room): menu->help_text is now `const char **';
6735 adjust.
6736
6737 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6738 to changes in oldXMenu/XMenu.h from 2011-04-16.
6739 (struct XMenu): Declare `help_text' `const char **'.
6740
6741 * xfaces.c <Qunspecified>: Make extern again.
6742
6743 * syntax.c: Include sys/types.h before including regex.h, as
6744 required by Posix.
6745
6746 * doc.c (get_doc_string): Improve the format passed to `error'.
6747
6748 * doprnt.c (doprnt): Improve commentary.
6749
6750 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6751
6752 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6753 them with etags.
6754
6755 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6756 changes in globals.h immediately force recompilation.
6757 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6758 $(CURDIR)/s/ms-w32.h.
6759 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6760
6761 * character.c (Fchar_direction): Function deleted.
6762 (syms_of_character): Don't defsubr it.
6763 <char-direction-table>: Deleted.
6764
6765 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6766
6767 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6768 * doprnt.c: Include limits.h.
6769 (SIZE_MAX): New macro.
6770 (doprnt): Return a size_t value. 2nd arg is now size_t.
6771 Many local variables are now size_t instead of int or unsigned.
6772 Improve overflow protection. Support `l' modifier for integer
6773 conversions. Support %l conversion. Don't assume an EMACS_INT
6774 argument for integer conversions and for %c.
6775
6776 * lisp.h (doprnt): Restore prototype.
6777
6778 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6779 $(SRC)/character.h.
6780
6781 * Makefile.in (base_obj): Add back doprnt.o.
6782
6783 * deps.mk (doprnt.o): Add back prerequisites.
6784 (callint.o): Depend on character.h.
6785
6786 * eval.c (internal_lisp_condition_case): Include the handler
6787 representation in the error message.
6788 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6789 when breaking from the loop.
6790
6791 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6792
6793 * callint.c (Fcall_interactively): When displaying error message
6794 about invalid control letter, pass the character's codepoint, not
6795 a pointer to its multibyte form. Improve display of the character
6796 in octal and display also its hex code.
6797
6798 * character.c (char_string): Use %x to display the (unsigned)
6799 codepoint of an invalid character, to avoid displaying a bogus
6800 negative value.
6801
6802 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6803 `error', not SYMBOL_NAME itself.
6804
6805 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6806 character arguments to `error'.
6807
6808 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6809 to `error' in error message about FINAL_CHAR argument. Make sure
6810 FINAL_CHAR is a character, and use %c when it is passed as
6811 argument to `error'.
6812
6813 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6814
6815 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6816
6817 * w32.c: Include <time.h>.
6818 (sys_localtime): New function.
6819
6820 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6821
6822 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6823
6824 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6825
6826 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6827
6828 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6829 zombies (Bug#8467).
6830
6831 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6832
6833 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6834 gl_state.e_property when gl_state.object is Qt.
6835
6836 * insdel.c (make_gap_larger): Remove limitation of buffer size
6837 to <= INT_MAX.
6838
6839 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6840
6841 * xdisp.c (lookup_glyphless_char_display)
6842 (produce_glyphless_glyph): Handle cons cell entry in
6843 glyphless-char-display.
6844 (Vglyphless_char_display): Document it.
6845
6846 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6847 glyphless-char-display.
6848
6849 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6850
6851 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6852
6853 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6854
6855 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6856 definition for no-X builds.
6857
6858 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6859
6860 Static checks with GCC 4.6.0 and non-default toolkits.
6861
6862 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6863
6864 * process.c (keyboard_bit_set): Define only if SIGIO.
6865 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6866 (send_process): Repair possible setjmp clobbering.
6867
6868 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6869
6870 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6871
6872 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6873
6874 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6875 Define only if needed.
6876
6877 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6878 by pacifying GCC about it. Maybe it's time to retire it?
6879 * xfaces.c (USG, __TIMEVAL__): Likewise.
6880
6881 * dispextern.h (struct redisplay_interface): Rename param
6882 to avoid shadowing.
6883 * termhooks.h (struct terminal): Likewise.
6884 * xterm.c (xembed_send_message): Likewise.
6885
6886 * insdel.c (make_gap_smaller): Define only if
6887 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6888
6889 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6890 it.
6891
6892 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6893 so that we aren't warned about unused symbols.
6894
6895 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6896
6897 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6898
6899 * xfns.c (x_real_positions): Mark locals as initialized.
6900
6901 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6902
6903 * xterm.c: Fix problems found by static analysis with other toolkits.
6904 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6905 (x_dispatch_event): Declare static if USE_GTK, and
6906 define if USE_GTK || USE_X_TOOLKIT.
6907 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6908 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6909 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6910 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6911
6912 * xmenu.c (menu_help_callback): Pointer type fixes.
6913 Use const pointers when pointing at readonly data. Avoid pointer
6914 signedness clashes.
6915 (FALSE): Remove unused macro.
6916 (update_frame_menubar): Remove unused decl.
6917
6918 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6919
6920 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6921 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6922 (single_menu_item): Rename local to avoid shadowing.
6923
6924 * keyboard.c (make_lispy_event): Remove unused local var.
6925
6926 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6927 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6928
6929 * bitmaps: Change bitmaps from unsigned char back to the X11
6930 compatible char. Avoid the old compiler warnings about
6931 out-of-range initializers by using, for example, '\xab' rather
6932 than 0xab.
6933
6934 * xgselect.c (xgselect_initialize): Check vs interface
6935 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6936
6937 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6938
6939 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6940 to read-only memory.
6941
6942 * fns.c (vector): Remove; this old hack is no longer needed.
6943
6944 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6945 Remove unused var.
6946 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6947
6948 * xrdb.c (x_load_resources): Omit unused local.
6949
6950 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6951 (x_window): Rename locals to avoid shadowing.
6952 (USG): Use the kludged USG macro, to pacify gcc.
6953
6954 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6955 (x_term_init): Remove local to avoid shadowing.
6956
6957 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6958
6959 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6960 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6961
6962 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6963
6964 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6965
6966 Fix regex.c, syntax.c and friends for buffers > 2GB.
6967 * syntax.h (struct gl_state_s): Declare character position members
6968 EMACS_INT.
6969
6970 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6971
6972 * textprop.c (verify_interval_modification, interval_of):
6973 Declare arguments EMACS_INT.
6974
6975 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6976 EMACS_INT.
6977
6978 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6979
6980 * indent.c (Fvertical_motion): Local variable it_start is now
6981 EMACS_INT.
6982
6983 * regex.c (re_match, re_match_2, re_match_2_internal)
6984 (bcmp_translate, regcomp, regexec, print_double_string)
6985 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6986 (re_compile_pattern, re_exec): Declare arguments and local
6987 variables `size_t' and `ssize_t' and return values `regoff_t', as
6988 appropriate.
6989 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6990 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6991 <compile_stack_type>: `size' and `avail' are now `size_t'.
6992
6993 * regex.h <regoff_t>: Use ssize_t, not int.
6994 (re_search, re_search_2, re_match, re_match_2): Arguments that
6995 specify buffer/string position and length are now ssize_t and
6996 size_t. Return type is regoff_t.
6997
6998 2011-04-16 Ben Key <bkey76@gmail.com>
6999
7000 * nsfont.m: Fixed bugs in ns_get_family and
7001 ns_descriptor_to_entity that were caused by using free to
7002 deallocate memory blocks that were allocated by xmalloc (via
7003 xstrdup). This caused Emacs to crash when compiled with
7004 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7005 --enable-checking=xmallocoverrun). xfree is now used to
7006 deallocate these memory blocks.
7007
7008 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7009
7010 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7011
7012 emacs_write: Accept and return EMACS_INT for sizes.
7013 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7014 et seq.
7015 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7016 Accept and return EMACS_INT.
7017 (emacs_gnutls_write): Return the number of bytes written on
7018 partial writes.
7019 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7020 (emacs_read, emacs_write): Remove check for negative size, as the
7021 Emacs source code has been audited now.
7022 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7023 (emacs_read, emacs_write): Use it.
7024 * process.c (send_process): Adjust to the new signatures of
7025 emacs_write and emacs_gnutls_write. Do not attempt to store
7026 a byte offset into an 'int'; it might overflow.
7027 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7028
7029 * sound.c: Don't assume sizes fit in 'int'.
7030 (struct sound_device.period_size, alsa_period_size):
7031 Return EMACS_INT, not int.
7032 (struct sound_device.write, vox_write, alsa_write):
7033 Accept EMACS_INT, not int.
7034 (wav_play, au_play): Use EMACS_INT to store sizes and to
7035 record read return values.
7036
7037 2011-04-15 Ben Key <bkey76@gmail.com>
7038
7039 * keyboard.c (Qundefined): Don't declare static since it is used
7040 in nsfns.m.
7041 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7042 static since they are used in nsfont.m.
7043
7044 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7045
7046 * process.c (Qprocessp): Don't declare static.
7047 * lisp.h (Qprocessp): Declare again.
7048
7049 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7050
7051 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7052
7053 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7054
7055 Improve C-level modularity by making more things 'static'.
7056
7057 Don't publish debugger-only interfaces to other modules.
7058 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7059 (verify_bytepos, count_markers): Move decls to the only modules
7060 that need them.
7061 * region-cache.h (pp_cache): Likewise.
7062 * window.h (check_all_windows): Likewise.
7063 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7064
7065 * sysdep.c (croak): Now static, if
7066 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7067 * syssignal.h (croak): Declare only if not static.
7068
7069 * alloc.c (refill_memory_reserve): Now static if
7070 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7071 * lisp.h (refill_memory_reserve): Declare only if not static.
7072
7073 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7074 Define only if USE_LUCID.
7075
7076 * xrdb.c (x_customization_string, x_rm_string): Now static.
7077
7078 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7079 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7080
7081 * xdisp.c (draw_row_with_mouse_face): Now static.
7082 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7083
7084 * window.h (check_all_windows): Mark externally visible.
7085
7086 * window.c (window_deletion_count): Now static.
7087
7088 * undo.c: Make symbols static if they're not exported.
7089 (last_undo_buffer, last_boundary_position, pending_boundary):
7090 Now static.
7091
7092 * textprop.c (interval_insert_behind_hooks): Now static.
7093 (interval_insert_in_front_hooks): Likewise.
7094
7095 * term.c: Make symbols static if they're not exported.
7096 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7097 (max_frame_lines, tty_set_terminal_modes):
7098 (tty_reset_terminal_modes, tty_turn_off_highlight):
7099 (get_tty_terminal): Now static.
7100 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7101 * termhooks.h (term_mouse_moveto): Do not declare if
7102 HAVE_WINDOW_SYSTEM.
7103 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7104 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7105
7106 * sysdep.c: Make symbols static if they're not exported.
7107 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7108 Now static.
7109 (sigprocmask_set, full_mask): Remove; unused.
7110 (wait_debugging): Mark as visible.
7111 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7112 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7113
7114 * syntax.c (syntax_temp): Define only if !__GNUC__.
7115
7116 * sound.c (current_sound_device, current_sound): Now static.
7117
7118 * search.c (searchbufs, searchbuf_head): Now static.
7119
7120 * scroll.c (scroll_cost): Remove; unused.
7121 * dispextern.h (scroll_cost): Remove decl.
7122
7123 * region-cache.h (pp_cache): Mark as externally visible.
7124
7125 * process.c: Make symbols static if they're not exported.
7126 (process_tick, update_tick, create_process, chan_process):
7127 (Vprocess_alist, proc_buffered_char, datagram_access):
7128 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7129 (deactivate_process): Mark defn as static, as well as decl.
7130 * lisp.h (create_process): Remove decl.
7131 * process.h (chan_process, Vprocess_alist): Remove decls.
7132
7133 * print.c: Make symbols static if they're not exported.
7134 (print_depth, new_backquote_output, being_printed, print_buffer):
7135 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7136 (print_interval, print_number_index, initial_stderr_stream):
7137 Now static.
7138 * lisp.h (Fprinc): Remove decl.
7139 (debug_output_compilation_hack): Mark as externally visible.
7140
7141 * sysdep.c (croak): Move decl from here to syssignal.h.
7142 * syssignal.h (croak): Put it here, so the API can be checked when
7143 'croak' is called from dissociate_if_controlling_tty.
7144
7145 * minibuf.c: Make symbols static if they're not exported.
7146 (minibuf_save_list, choose_minibuf_frame): Now static.
7147 * lisp.h (choose_minibuf_frame): Remove decl.
7148
7149 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7150
7151 * lread.c: Make symbols static if they're not exported.
7152 (read_objects, initial_obarray, oblookup_last_bucket_number):
7153 Now static.
7154 (make_symbol): Remove; unused.
7155 * lisp.h (initial_obarray, make_symbol): Remove decls.
7156
7157 * keyboard.c: Make symbols static if they're not exported.
7158 (single_kboard, recent_keys_index, total_keys, recent_keys):
7159 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7160 (this_single_command_key_start, echoing, last_auto_save):
7161 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7162 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7163 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7164 (Vlispy_mouse_stem, double_click_count):
7165 Now static.
7166 (force_auto_save_soon): Define only if SIGDANGER.
7167 (ignore_mouse_drag_p): Now static if
7168 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7169 (print_help): Remove; unused.
7170 (stop_character, last_timer_event): Mark as externally visible.
7171 * keyboard.h (ignore_mouse_drag_p): Declare only if
7172 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7173 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7174 * lisp.h (echoing): Remove decl.
7175 (force_auto_save_soon): Declare only if SIGDANGER.
7176 * xdisp.c (redisplay_window): Simplify code, to make it more
7177 obvious that ignore_mouse_drag_p is not accessed if !defined
7178 USE_GTK && !defined HAVE_NS.
7179
7180 * intervals.c: Make symbols static if they're not exported.
7181 (merge_properties_sticky, merge_interval_right, delete_interval):
7182 Now static.
7183 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7184
7185 * insdel.c: Make symbols static if they're not exported.
7186 However, leave prepare_to_modify_buffer alone. It's never
7187 called from outside this function, but that appears to be a bug.
7188 (combine_after_change_list, combine_after_change_buffer):
7189 (adjust_after_replace, signal_before_change): Now static.
7190 (adjust_after_replace_noundo): Remove; unused.
7191 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7192 (signal_before_change): Remove decls.
7193
7194 * indent.c (val_compute_motion, val_vmotion): Now static.
7195
7196 * image.c: Make symbols static if they're not exported.
7197 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7198 if USE_GTK.
7199 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7200 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7201
7202 * fringe.c (standard_bitmaps): Now static.
7203 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7204
7205 * frame.c: Make symbols static if they're not exported.
7206 (x_report_frame_params, make_terminal_frame): Now static.
7207 (get_frame_param): Now static, unless HAVE_NS.
7208 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7209 (x_get_resource_string): Remove; not used.
7210 * frame.h (make_terminal_frame, x_report_frame_params):
7211 (x_get_resource_string); Remove decls.
7212 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7213 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7214
7215 * font.c, fontset.c: Make symbols static if they're not exported.
7216 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7217 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7218 * font.c (font_close_object): Now static.
7219 * font.h (font_close_object): Remove.
7220 * fontset.c (FONTSET_OBJLIST): Remove.
7221 (free_realized_fontset) #if-0 the body, which does nothing.
7222 (face_suitable_for_char_p): #if-0, as it's never called.
7223 * fontset.h (face_suitable_for_char_p): Remove decl.
7224 * xfaces.c (face_at_string_position):
7225 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7226 since 0 is always ASCII.
7227
7228 * fns.c (weak_hash_tables): Now static.
7229
7230 * fileio.c: Make symbols static if they're not exported.
7231 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7232 (Vwrite_region_annotation_buffers): Now static.
7233
7234 * eval.c: Make symbols static if they're not exported.
7235 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7236 * lisp.h (backtrace_list): Remove decl.
7237
7238 * emacs.c: Make symbols static if they're not exported.
7239 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7240 (fatal_error_code, fatal_error_signal_hook, standard_args):
7241 Now static.
7242 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7243 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7244 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7245 * lisp.h (fatal_error_signal_hook): Remove decl.
7246 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7247
7248 * editfns.c: Move a (normally-unused) function to its only use.
7249 * editfns.c, lisp.h (get_operating_system_release): Remove.
7250 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7251 worth the hassle of breaking this out.
7252
7253 * xterm.c: Make symbols static if they're not exported.
7254 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7255 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7256 (x_destroy_window, x_delete_display):
7257 Now static.
7258 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7259 (x_mouse_leave): Remove; unused.
7260 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7261 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7262 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7263 Remove decls.
7264 (x_mouse_leave): Declare only if WINDOWSNT.
7265 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7266 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7267 USE_X_TOOLKIT.
7268
7269 * ftxfont.c: Make symbols static if they're not exported.
7270 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7271 HAVE_FREETYPE.
7272 * font.h (ftxfont_driver): Likewise.
7273
7274 * xfns.c: Make symbols static if they're not exported.
7275 (x_last_font_name, x_display_info_for_name):
7276 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7277 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7278 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7279 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7280 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7281 (last_show_tip_args): Now static.
7282 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7283 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7284 (x_screen_planes): Remove; unused.
7285 * dispextern.h (x_screen_planes): Remove decl.
7286
7287 * dispnew.c: Make symbols static if they're not exported.
7288 * dispextern.h (redraw_garbaged_frames, scrolling):
7289 (increment_row_positions): Remove.
7290 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7291 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7292 Now static.
7293 (redraw_garbaged_frames): Remove; unused.
7294
7295 * xfaces.c: Make symbols static if they're not exported.
7296 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7297 Remove decls.
7298 * xterm.h (defined_color): Remove decls.
7299 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7300 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7301 (menu_face_changed_default, defined_color, free_realized_face):
7302 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7303 (ascii_face_of_lisp_face): Remove; unused.
7304
7305 * xdisp.c: Make symbols static if they're not exported.
7306 * dispextern.h (scratch_glyph_row, window_box_edges):
7307 (glyph_to_pixel_coords, set_cursor_from_row):
7308 (get_next_display_element, set_iterator_to_next):
7309 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7310 (show_mouse_face): Remove decls
7311 * frame.h (message_buf_print): Likewise.
7312 * lisp.h (pop_message, set_message, check_point_in_composition):
7313 Likewise.
7314 * xterm.h (set_vertical_scroll_bar): Likewise.
7315 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7316 (message_buf_print, scratch_glyph_row, displayed_buffer):
7317 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7318 (get_next_display_element, show_mouse_face, window_box_edges):
7319 (frame_to_window_pixel_xy, check_point_in_composition):
7320 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7321 (glyph_to_pixel_coords): Remove; unused.
7322
7323 * dired.c (file_name_completion): Now static.
7324
7325 * dbusbind.c (xd_in_read_queued_messages): Now static.
7326
7327 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7328 * data.c (circular_list_error): Remove.
7329
7330 * commands.h (last_point_position, last_point_position_buffer):
7331 (last_point_position_window): Remove decls.
7332 * keyboard.c: Make these variables static.
7333
7334 * coding.h (coding, code_convert_region, encode_coding_gap):
7335 Remove decls.
7336 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7337 (iso_code_class, detect_coding, code_convert_region): Now static.
7338 (encode_coding_gap): Remove; unused.
7339
7340 * chartab.c (chartab_chars, chartab_bits): Now static.
7341
7342 * charset.h (charset_iso_8859_1): Remove decl.
7343 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7344 Now static.
7345
7346 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7347 * ccl.c (Vccl_program_table): Now static.
7348 (check_ccl_update): Remove; unused.
7349
7350 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7351 * category.h: ... from here.
7352 * category.c (check_category_table, set_category_set): Now static.
7353
7354 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7355 * lisp.h: Remove these decls.
7356
7357 * buffer.c (buffer_count): Remove unused var.
7358
7359 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7360 so that it's not optimized away.
7361 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7362 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7363 exported only to the debugger.
7364
7365 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7366 * atimer.h (run_all_atimers): Remove; not exported.
7367
7368 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7369 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7370 was inaccessible from Lisp.
7371 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7372 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7373
7374 alloc.c: Import and export fewer symbols, and remove unused items.
7375 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7376 is defined.
7377 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7378 it's not optimized away by whole-program optimization.
7379 (message_enable_multibyte, free_misc): Remove.
7380 (catchlist, handlerlist, mark_backtrace):
7381 Declare only if BYTE_MARK_STACK.
7382 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7383 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7384 (message_enable_multibyte): Remove decl.
7385 (free_misc, interval_free_list, float_block, float_block_index):
7386 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7387 (cons_free_list, last_marked_index):
7388 Now static.
7389 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7390 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7391 (mark_backtrace): Define only if BYTE_MARK_STACK.
7392 * xdisp.c (message_enable_multibyte): Now static.
7393
7394 Declare Lisp_Object Q* variables to be 'static' if not exported.
7395 This makes it easier for human readers (and static analyzers)
7396 to see whether these variables are used from other modules.
7397 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7398 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7399 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7400 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7401 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7402 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7403 * xmenu.c, xselect.c:
7404 Declare Q* vars static if they are not used in other modules.
7405 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7406 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7407 Remove decls of unexported vars.
7408 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7409
7410 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7411
7412 Make Emacs functions such as Fatom 'static' by default.
7413 This makes it easier for human readers (and static analyzers)
7414 to see whether these functions can be called from other modules.
7415 DEFUN now defines a static function. To make the function external
7416 so that it can be used in other C modules, use the new macro DEFUE.
7417 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7418 (Finit_image_library):
7419 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7420 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7421 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7422 Remove decls, since these functions are now static.
7423 (Funintern, Fget_internal_run_time): New decls, since these functions
7424 were already external.
7425
7426 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7427 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7428 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7429 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7430 * keyboard.c, keymap.c, lread.c:
7431 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7432 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7433 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7434 Mark functions with DEFUE instead of DEFUN,
7435 if they are used in other modules.
7436 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7437 decls for now-static functions.
7438 * buffer.h (Fdelete_overlay): Remove decl.
7439 * callproc.c (Fgetenv_internal): Mark as internal.
7440 * composite.c (Fremove_list_of_text_properties): Remove decl.
7441 (Fcomposition_get_gstring): New forward static decl.
7442 * composite.h (Fcomposite_get_gstring): Remove decl.
7443 * dired.c (Ffile_attributes): New forward static decl.
7444 * doc.c (Fdocumntation_property): New forward static decl.
7445 * eval.c (Ffetch_bytecode): New forward static decl.
7446 (Funintern): Remove extern decl; now in .h file where it belongs.
7447 * fileio.c (Fmake_symbolic_link): New forward static decl.
7448 * image.c (Finit_image_library): New forward static decl.
7449 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7450 * intervals.h (Fprevious_property_change):
7451 (Fremove_list_of_text_properties): Remove decls.
7452 * keyboard.c (Fthis_command_keys): Remove decl.
7453 (Fcommand_execute): New forward static decl.
7454 * keymap.c (Flookup_key): New forward static decl.
7455 (Fcopy_keymap): Now static.
7456 * keymap.h (Flookup_key): Remove decl.
7457 * process.c (Fget_process): New forward static decl.
7458 (Fprocess_datagram_address): Mark as internal.
7459 * syntax.c (Fsyntax_table_p): New forward static decl.
7460 (skip_chars): Remove duplicate decl.
7461 * textprop.c (Fprevious_property_change): New forward static decl.
7462 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7463 Now internal.
7464 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7465 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7466
7467 * editfns.c (Fformat): Remove unreachable code.
7468
7469 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7470
7471 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7472 change. (Bug#8496)
7473
7474 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7475
7476 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7477 when at ZV. (Bug#8487)
7478
7479 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7480
7481 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7482 (Bug#8437)
7483 * keyboard.c (parse_tool_bar_item): Likewise.
7484 * sound.c (sound_cleanup, alsa_close): Likewise.
7485 * termcap.c (tgetent): Likewise.
7486 * xfns.c (x_default_font_parameter): Likewise.
7487 * xsettings.c (read_and_apply_settings): Likewise.
7488
7489 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7490 (overrun_check_free): Protoize.
7491
7492 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7493
7494 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7495 since callers should never pass a negative size.
7496 Change the signature to match that of plain 'read' and 'write'; see
7497 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7498 * lisp.h: Update prototypes of emacs_write and emacs_read.
7499
7500 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7501
7502 * xdisp.c (redisplay_window): Don't try to determine the character
7503 position of the scroll margin if the window start point w->startp
7504 is outside the buffer's accessible region. (Bug#8468)
7505
7506 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7507
7508 Fix write-region and its subroutines for buffers > 2GB.
7509 * fileio.c (a_write, e_write): Modify declaration of arguments and
7510 local variables to support buffers larger than 2GB.
7511 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7512
7513 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7514 argument, local variables, and return value.
7515
7516 * lisp.h: Update prototypes of emacs_write and emacs_read.
7517
7518 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7519
7520 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7521
7522 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7523
7524 Fix more problems found by GCC 4.6.0's static checks.
7525
7526 * xdisp.c (vmessage): Use a better test for character truncation.
7527
7528 * charset.c (load_charset_map): <, not <=, for optimization,
7529 and to avoid potential problems with integer overflow.
7530 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7531 * casetab.c (set_identity, shuffle): Likewise.
7532 * editfns.c (Fformat): Likewise.
7533 * syntax.c (skip_chars): Likewise.
7534
7535 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7536 This also lets GCC 4.6.0 generate slightly better loop code.
7537
7538 * callint.c (Fcall_interactively): <, not <=, for optimization.
7539 (Fcall_interactively): Count the number of arguments produced,
7540 not the number of arguments given. This is simpler and lets GCC
7541 4.6.0 generate slightly better code.
7542
7543 * ftfont.c: Distingish more carefully between FcChar8 and char.
7544 The previous code passed unsigned char * to a functions like
7545 strlen and xstrcasecmp that expect char *, which does not
7546 conform to the C standard.
7547 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7548 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7549 char * when the C standard requires it.
7550
7551 * keyboard.c (read_char): Remove unused var.
7552
7553 * eval.c: Port to Windows vsnprintf (Bug#8435).
7554 Include <limits.h>.
7555 (SIZE_MAX): Define if the headers do not.
7556 (verror): Do not give up if vsnprintf returns a negative count.
7557 Instead, grow the buffer. This ports to Windows vsnprintf, which
7558 does not conform to C99. Problem reported by Eli Zaretskii.
7559 Also, simplify the allocation scheme, by avoiding the need for
7560 calling realloc, and removing the ALLOCATED variable.
7561
7562 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7563
7564 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7565 But keep the doprint source code for now, as we might revamp it
7566 and use it again (Bug#8435).
7567 * lisp.h (doprnt): Remove.
7568 * Makefile.in (base_obj): Remove doprnt.o.
7569 * deps.mk (doprnt.o): Remove.
7570
7571 error: Print 32- and 64-bit integers portably (Bug#8435).
7572 Without this change, on typical 64-bit hosts error ("...%d...", N)
7573 was used to print both 32- and 64-bit integers N, which relied on
7574 undefined behavior.
7575 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7576 New macro.
7577 * lisp.h (error, verror): Mark as printf-like functions.
7578 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7579 Report overflow in size calculations when allocating printf buffer.
7580 Do not truncate output string at its first null byte.
7581 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7582 Truncate the output at a character boundary, since vsnprintf does not
7583 do that.
7584 * charset.c (check_iso_charset_parameter): Convert internal
7585 character to string before calling 'error', since %c now has the
7586 printf meaning.
7587 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7588 overflow when computing char to be passed to 'error'. Do not
7589 pass Lisp_Object to 'error'; pass the integer instead.
7590 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7591 formatted with plain %d.
7592
7593 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7594
7595 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7596
7597 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7598
7599 * xterm.c (x_catch_errors): Remove duplicate declaration.
7600
7601 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7602
7603 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7604
7605 2011-04-10 Jim Meyering <meyering@redhat.com>
7606
7607 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7608 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7609 return ssize_t not "int", and use size_t as the buffer length.
7610 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7611 * gnutls.h: Update declarations.
7612 * process.c (read_process_output): Use ssize_t, to match.
7613 (send_process): Likewise.
7614
7615 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7616
7617 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7618
7619 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7620
7621 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7622 Use unsigned char, to match FcChar8 type definition.
7623
7624 * xterm.c (handle_one_xevent):
7625 * xmenu.c (create_and_show_popup_menu):
7626 * xselect.c (x_decline_selection_request)
7627 (x_reply_selection_request): Avoid type-punned deref of X events.
7628
7629 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7630
7631 Fix some uses of `int' instead of EMACS_INT.
7632 * search.c (string_match_1, fast_string_match)
7633 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7634 (scan_buffer, find_next_newline_no_quit)
7635 (find_before_next_newline, search_command, Freplace_match)
7636 (Fmatch_data): Make some `int' variables be EMACS_INT.
7637
7638 * xdisp.c (display_count_lines): 3rd argument and return value now
7639 EMACS_INT. All callers changed.
7640 (pint2hrstr): Last argument is now EMACS_INT.
7641
7642 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7643 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7644 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7645 (decode_coding_utf_16, decode_coding_emacs_mule)
7646 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7647 (decode_coding_ccl, decode_coding_charset)
7648 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7649 (decode_coding_iso_2022, decode_coding_emacs_mule)
7650 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7651 <char_offset, last_offset>: Declare EMACS_INT.
7652 (encode_coding_utf_8, encode_coding_utf_16)
7653 (encode_coding_emacs_mule, encode_invocation_designation)
7654 (encode_designation_at_bol, encode_coding_iso_2022)
7655 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7656 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7657 Declare EMACS_INT.
7658 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7659 (encode_invocation_designation): Last argument P_NCHARS is now
7660 EMACS_INT.
7661 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7662 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7663
7664 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7665 All users changed.
7666
7667 * ccl.c (Fccl_execute_on_string): Declare some variables
7668 EMACS_INT.
7669
7670 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7671
7672 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7673
7674 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7675
7676 * process.c (Fformat_network_address): Doc fix.
7677
7678 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7679
7680 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7681
7682 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7683
7684 * keyboard.c (read_char): Call Lisp function help-form-show,
7685 instead of using internal_with_output_to_temp_buffer.
7686 (Qhelp_form_show): New var.
7687 (syms_of_keyboard): Use DEFSYM macro.
7688
7689 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7690
7691 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7692
7693 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7694
7695 * process.c (Flist_processes): Remove to Lisp.
7696 (list_processes_1): Delete.
7697
7698 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7699
7700 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7701
7702 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7703
7704 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7705
7706 Fix more problems found by GCC 4.6.0's static checks.
7707
7708 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7709
7710 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7711
7712 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7713
7714 * xdisp.c (vmessage): Mark as a printf-like function.
7715
7716 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7717
7718 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7719
7720 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7721 printf-like functions.
7722 (tiff_load): Add casts to remove these marks before passing them
7723 to system-supplied API.
7724
7725 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7726
7727 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7728 This avoids several warnings with gcc -Wstrict-overflow.
7729 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7730 directly, rather than having caller test rule sign. This avoids
7731 some unnecessary tests.
7732 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7733 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7734 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7735
7736 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7737 (xfont_open): Avoid unnecessary tests.
7738
7739 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7740
7741 * composite.h, composite.c (composition_gstring_put_cache):
7742 Use EMACS_INT, not int, for length.
7743
7744 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7745 breaking out part of COMPOSITION_DECODE_RULE.
7746 (COMPOSITION_DECODE_RULE): Use it.
7747 * composite.c (get_composition_id): Remove unused local vars,
7748 by using the new macro.
7749
7750 * textprop.c (set_text_properties_1): Change while to do-while,
7751 since the condition is always true at first.
7752
7753 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7754 (interval_deletion_adjustment): Return unsigned value.
7755 All uses changed.
7756
7757 * process.c (list_processes_1, create_pty, read_process_output):
7758 (exec_sentinel): Remove vars that were set but not used.
7759 (create_pty): Remove unnecessary "volatile"s.
7760 (Fnetwork_interface_info): Avoid possibility of int overflow.
7761 (read_process_output): Do adaptive read buffering even if carryover.
7762 (read_process_output): Simplify nbytes computation if buffered.
7763
7764 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7765
7766 * syntax.c (scan_words): Remove var that was set but not used.
7767 (update_syntax_table): Use unsigned instead of int.
7768
7769 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7770 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7771 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7772
7773 * print.c (print_error_message): Avoid int overflow.
7774
7775 * font.c (font_list_entities): Redo for clarity,
7776 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7777
7778 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7779 (font_score): Avoid potential overflow in diff calculation.
7780
7781 * fns.c (substring_both): Remove var that is set but not used.
7782 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7783
7784 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7785
7786 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7787 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7788 can always succeed if overflow has undefined behavior.
7789
7790 * search.c (boyer_moore, wordify): Remove vars set but not used.
7791 (wordify): Omit three unnecessary tests.
7792
7793 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7794 All callers changed. This avoids the need for an unused var.
7795
7796 * casefiddle.c (casify_region): Remove var that is set but not used.
7797
7798 * dired.c (file_name_completion): Remove var that is set but not used.
7799
7800 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7801
7802 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7803 (Finsert_file_contents): Remove unnecessary code checking fd.
7804
7805 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7806 Check for integer overflow on size calculations.
7807
7808 * buffer.c (Fprevious_overlay_change): Remove var that is set
7809 but not used.
7810
7811 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7812 Remove vars that are set but not used.
7813 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7814 (timer_check_2): Mark vars as initialized.
7815
7816 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7817
7818 * image.c (lookup_image): Remove var that is set but not used.
7819 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7820
7821 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7822 that are set but not used.
7823
7824 * xfns.c (make_invisible_cursor): Don't return garbage
7825 if XCreateBitmapFromData fails (Bug#8410).
7826
7827 * xselect.c (x_get_local_selection, x_handle_property_notify):
7828 Remove vars that are set but not used.
7829
7830 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7831 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7832
7833 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7834 Remove var that is set but not used.
7835 (scroll_bar_windows_size): Now size_t, not int.
7836 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7837 Check for overflow.
7838
7839 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7840 (map_tty_color) [!defined MSDOS]: Likewise.
7841
7842 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7843
7844 * coding.c: Remove vars that are set but not used.
7845 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7846 All callers changed.
7847 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7848 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7849 (decode_coding_charset): Remove vars that are set but not used.
7850
7851 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7852 that is set but not used.
7853
7854 * print.c (print_object): Remove var that is set but not used.
7855
7856 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7857 The gnulib version avoids calling malloc in the usual case,
7858 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7859 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7860 * filelock.c (current_lock_owner): Likewise.
7861 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7862 * sysdep.c: Include allocator.h, careadlinkat.h.
7863 (emacs_no_realloc_allocator): New static constant.
7864 (emacs_readlink): New function.
7865 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7866 ../lib/careadlinkat.h.
7867
7868 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7869
7870 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7871 first non-nil return value).
7872
7873 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7874
7875 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7876 if not defined (Bug#8403).
7877
7878 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7879
7880 * xdisp.c (display_count_lines): Remove parameter `start',
7881 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7882 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7883 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7884 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7885 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7886 and thereabouts. All callers changed.
7887 (get_per_char_metric): Remove parameter `f', unused since
7888 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7889
7890 2011-04-02 Jim Meyering <meyering@redhat.com>
7891
7892 do not dereference NULL upon failed strdup
7893 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7894 (ns_get_family): Likewise.
7895
7896 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7897
7898 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7899
7900 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7901
7902 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7903 later (Bug#8403).
7904
7905 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7906
7907 Add lexical binding.
7908
7909 * window.c (Ftemp_output_buffer_show): New fun.
7910 (Fsave_window_excursion):
7911 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7912
7913 * lread.c (lisp_file_lexically_bound_p): New function.
7914 (Fload): Bind Qlexical_binding.
7915 (readevalloop): Remove `evalfun' arg.
7916 Bind Qinternal_interpreter_environment.
7917 (Feval_buffer): Bind Qlexical_binding.
7918 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7919 Mark as dynamic.
7920 (syms_of_lread): Declare `lexical-binding'.
7921
7922 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7923
7924 * keyboard.c (eval_dyn): New fun.
7925 (menu_item_eval_property): Use it.
7926
7927 * image.c (parse_image_spec): Use Ffunctionp.
7928
7929 * fns.c (concat, mapcar1): Accept byte-code-functions.
7930
7931 * eval.c (Fsetq): Handle lexical vars.
7932 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7933 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7934 (FletX, Flet): Obey lexical binding.
7935 (Fcommandp): Handle closures.
7936 (Feval): New `lexical' arg.
7937 (eval_sub): New function extracted from Feval. Use it almost
7938 everywhere where Feval was used. Look up vars in lexical env.
7939 Handle closures.
7940 (Ffunctionp): Move from subr.el.
7941 (Ffuncall): Handle closures.
7942 (apply_lambda): Remove `eval_flags'.
7943 (funcall_lambda): Handle closures and new byte-code-functions.
7944 (Fspecial_variable_p): New function.
7945 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7946 but without exporting it to Lisp.
7947
7948 * doc.c (Fdocumentation, store_function_docstring):
7949 * data.c (Finteractive_form): Handle closures.
7950
7951 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7952 interactive spec.
7953
7954 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7955 New byte-codes.
7956 (exec_byte_code): New function extracted from Fbyte_code to handle new
7957 calling convention for byte-code-functions. Add new byte-codes.
7958
7959 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7960
7961 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7962
7963 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7964
7965 * xdisp.c (redisplay_internal): Fix prototype.
7966
7967 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7968
7969 * xdisp.c (SCROLL_LIMIT): New macro.
7970 (try_scrolling): Use it when setting scroll_limit.
7971 Limit scrolling to 100 screen lines.
7972 (redisplay_window): Even when falling back on "recentering",
7973 position point in the window according to scroll-conservatively,
7974 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7975
7976 (try_scrolling): When point is above the window, allow searching
7977 as far as scroll_max, or one screenful, to compute vertical
7978 distance from PT to the scroll margin position. This prevents
7979 try_scrolling from unnecessarily failing when
7980 scroll-conservatively is set to a value slightly larger than the
7981 window height. Clean up the case of PT below the margin at bottom
7982 of window: scroll_max can no longer be INT_MAX. When aggressive
7983 scrolling is in use, don't let point enter the opposite scroll
7984 margin as result of the scroll.
7985 (syms_of_xdisp) <scroll-conservatively>: Document the
7986 threshold of 100 lines for never-recentering scrolling.
7987
7988 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7989
7990 * dispextern.h (move_it_by_lines):
7991 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7992 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7993 (message_log_check_duplicate): Remove parameters `prev_bol' and
7994 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7995 (redisplay_internal): Remove parameter `preserve_echo_area',
7996 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7997
7998 * indent.c (Fvertical_motion):
7999 * window.c (window_scroll_pixel_based, Frecenter):
8000 Don't pass `need_y_p' to `move_it_by_lines'.
8001
8002 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8003
8004 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8005 steal a few bits to be more compact.
8006 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8007 Remove unneeded casts.
8008
8009 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8010
8011 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8012
8013 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8014 binding" message (bug#7967).
8015
8016 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8017
8018 Fix more problems found by GCC 4.6.0's static checks.
8019
8020 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8021 Remove unused local var.
8022
8023 * editfns.c (Fmessage_box): Remove unused local var.
8024
8025 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8026 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8027 Omit unused local vars.
8028 * window.c (shrink_windows): Omit unused local var.
8029 * menu.c (digest_single_submenu): Omit unused local var.
8030 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8031 Omit unused local var.
8032
8033 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8034 Don't assume string length fits in int.
8035 (keyremap_step, read_key_sequence): Use size_t for sizes.
8036 (read_key_sequence): Don't check last_real_key_start redundantly.
8037
8038 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8039 instead of alloca (Bug#8344).
8040
8041 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8042 (Fbacktrace_frame): Don't assume nframes fits in int.
8043
8044 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8045
8046 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8047 concerns.
8048
8049 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8050
8051 * cm.c (calccost): Turn while-do into do-while, for clarity.
8052
8053 * keyboard.c (syms_of_keyboard): Use the same style as later
8054 in this function when indexing through an array. This also
8055 works around GCC bug 48267.
8056
8057 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8058
8059 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8060
8061 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8062 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8063
8064 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8065 This avoids undefined behavior on integer overflow, and is a bit
8066 more convenient anyway since it is compared to a size_t variable.
8067
8068 Variadic C functions now count arguments with size_t, not int.
8069 This avoids an unnecessary limitation on 64-bit machines, which
8070 caused (substring ...) to crash on large vectors (Bug#8344).
8071 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8072 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8073 All variadic functions and their callers changed accordingly.
8074 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8075 * data.c (arith_driver, float_arith_driver): Likewise.
8076 * editfns.c (general_insert_function): Likewise.
8077 * eval.c (struct backtrace.nargs, interactive_p)
8078 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8079 (funcall_lambda, mark_backtrace): Likewise.
8080 * fns.c (concat): Likewise.
8081 * frame.c (x_set_frame_parameters): Likewise.
8082 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8083 0 if not found, not -1. All callers changed.
8084
8085 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8086 (stack_copy_size): Now size_t, not int.
8087 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8088
8089 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8090
8091 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8092 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8093 All callers changed.
8094
8095 * lisp.h (multibyte_char_to_unibyte):
8096 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8097 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8098 * character.h (CHAR_TO_BYTE8):
8099 * cmds.c (internal_self_insert):
8100 * editfns.c (general_insert_function):
8101 * keymap.c (push_key_description):
8102 * search.c (Freplace_match):
8103 * xdisp.c (message_dolog, set_message_1): All callers changed.
8104
8105 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8106
8107 * keyboard.c (safe_run_hook_funcall): New function.
8108 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8109 don't set the hook to nil, but remove the offending function instead.
8110 (Qcommand_hook_internal): Remove, unused.
8111 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8112 Vcommand_hook_internal.
8113
8114 * eval.c (enum run_hooks_condition): Remove.
8115 (funcall_nil, funcall_not): New functions.
8116 (run_hook_with_args): Call each function through a `funcall' argument.
8117 Remove `cond' argument, now redundant.
8118 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8119 (Frun_hook_with_args_until_failure): Adjust accordingly.
8120 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8121
8122 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8123
8124 * dispextern.h (string_buffer_position): Remove declaration.
8125
8126 * print.c (strout): Remove parameter `multibyte', unused since
8127 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8128
8129 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8130 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8131 All callers changed.
8132
8133 * w32.c (_wsa_errlist): Use braces for struct initializers.
8134
8135 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8136 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8137 All callers changed.
8138 (string_buffer_position): Likewise. Also, make static (it's never
8139 used outside xdisp.c).
8140 (cursor_row_p): Remove parameter `w', unused since
8141 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8142 (decode_mode_spec): Remove parameter `precision', introduced during
8143 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8144 All callers changed.
8145
8146 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8147
8148 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8149
8150 2011-03-27 Anders Lindgren <andlind@gmail.com>
8151
8152 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8153 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8154 (ns_update_auto_hide_menu_bar): New functions.
8155 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8156 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8157 ns_constrain_all_frames.
8158 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8159 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8160
8161 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8162
8163 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8164
8165 2011-03-27 Glenn Morris <rgm@gnu.org>
8166
8167 * syssignal.h: Replace RETSIGTYPE with void.
8168 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8169 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8170 Replace SIGTYPE with void everywhere.
8171 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8172 * s/template.h (SIGTYPE): Remove commented out definition.
8173
8174 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8175
8176 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8177 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8178
8179 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8180
8181 * w32.c (read_unc_volume): Use parameter `henum', instead of
8182 global variable `wget_enum_handle'.
8183
8184 * keymap.c (describe_vector): Remove parameters `indices' and
8185 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8186 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8187
8188 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8189
8190 * keyboard.c (timer_check): Remove parameter `do_it_now',
8191 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8192 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8193 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8194
8195 * keyboard.c (read_char):
8196 * w32menu.c (w32_menu_display_help):
8197 * xmenu.c (show_help_event, menu_help_callback):
8198 Adjust calls to `show_help_echo'.
8199
8200 * gtkutil.c (xg_maybe_add_timer):
8201 * keyboard.c (readable_events):
8202 * process.c (wait_reading_process_output):
8203 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8204
8205 * insdel.c (adjust_markers_gap_motion):
8206 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8207 (gap_left, gap_right): Don't call it.
8208
8209 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8210
8211 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8212 incurred during fontification.
8213
8214 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8215
8216 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8217 (DEFVAR_PER_BUFFER): Don't pass it.
8218
8219 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8220 (scrolling_window): Don't pass it.
8221
8222 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8223
8224 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8225
8226 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8227 and `suffix'.
8228 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8229 of variables specific to SELinux and computation of `encoded_absname'.
8230
8231 * image.c (XPutPixel): Remove unused variable `height'.
8232
8233 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8234
8235 * unexw32.c (get_section_info): Remove unused variable `section'.
8236
8237 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8238 (system_process_attributes): Remove unused variable `sess'.
8239 (sys_read): Remove unused variable `err'.
8240
8241 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8242 (w32_wnd_proc): Remove unused variable `isdead'.
8243 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8244 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8245 (x_create_tip_frame): Remove unused variable `tem'.
8246
8247 * w32inevt.c (w32_console_read_socket):
8248 Remove unused variable `no_events'.
8249
8250 * w32term.c (x_draw_composite_glyph_string_foreground):
8251 Remove unused variable `width'.
8252
8253 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8254
8255 * w32term.c (x_set_glyph_string_clipping):
8256 Don't pass uninitialized region to CombineRgn.
8257
8258 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8259
8260 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8261 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8262 (Fx_close_connection): Remove unused variable `i'.
8263
8264 * w32font.c (w32font_draw): Return number of glyphs.
8265 (w32font_open_internal): Remove unused variable `i'.
8266 (w32font_driver): Add missing initializer.
8267
8268 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8269 (fill_in_menu): Remove unused variable `items_added'.
8270
8271 * w32term.c (last_mouse_press_frame): Remove static global variable.
8272 (w32_clip_to_row): Remove unused variable `f'.
8273 (x_delete_terminal): Remove unused variable `i'.
8274
8275 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8276 (NOTHING): Remove unused static global variable.
8277 (uniscribe_check_otf): Remove unused variable `table'.
8278 (uniscribe_font_driver): Add missing initializers.
8279
8280 2011-03-23 Julien Danjou <julien@danjou.info>
8281
8282 * term.c (Fsuspend_tty, Fresume_tty):
8283 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8284 * window.c (temp_output_buffer_show):
8285 * insdel.c (signal_before_change):
8286 * frame.c (Fhandle_switch_frame):
8287 * fileio.c (Fdo_auto_save):
8288 * emacs.c (Fkill_emacs):
8289 * editfns.c (save_excursion_restore):
8290 * cmds.c (internal_self_insert):
8291 * callint.c (Fcall_interactively):
8292 * buffer.c (Fkill_all_local_variables):
8293 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8294 Use Frun_hooks.
8295 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8296 unconditionally since it does the check itself.
8297
8298 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8299
8300 Fix more problems found by GCC 4.5.2's static checks.
8301
8302 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8303 the first time through the loop, since we know p0 < p1 then.
8304 This also avoids a gcc -Wstrict-overflow warning.
8305
8306 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8307 leading to a memory leak, possible in functions like
8308 load_charset_map_from_file that can allocate an unbounded number
8309 of objects (Bug#8318).
8310
8311 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8312 that could (at least in theory) be that large.
8313
8314 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8315 This is less likely to overflow, and avoids undefined behavior if
8316 overflow does occur. All callers changed. Use strtoul to scan
8317 for the unsigned long integer.
8318 (pint2hrstr): Simplify and tune code slightly.
8319 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8320
8321 * scroll.c (do_scrolling): Work around GCC bug 48228.
8322 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8323
8324 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8325 This also avoids a warning with gcc -Wstrict-overflow.
8326 (validate_x_resource_name): Simplify count usage.
8327 This also avoids a warning with gcc -Wstrict-overflow.
8328
8329 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8330 fail (Bug#8306).
8331
8332 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8333
8334 * process.c (Fmake_network_process): Use socklen_t, not int,
8335 where POSIX says socklen_t is required in portable programs.
8336 This fixes a porting bug on hosts like 64-bit HP-UX, where
8337 socklen_t is wider than int (Bug#8277).
8338 (Fmake_network_process, server_accept_connection):
8339 (wait_reading_process_output, read_process_output):
8340 Likewise.
8341
8342 * process.c: Rename or move locals to avoid shadowing.
8343 (list_processes_1, Fmake_network_process):
8344 (read_process_output_error_handler, exec_sentinel_error_handler):
8345 Rename or move locals.
8346 (Fmake_network_process): Define label "retry_connect" only if needed.
8347 (Fnetwork_interface_info): Fix pointer signedness.
8348 (process_send_signal): Add cast to avoid pointer signedness problem.
8349 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8350 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8351
8352 Make tparam.h and terminfo.c consistent.
8353 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8354 Include tparam.h instead, since it declares them.
8355 * cm.h (PC): Remove extern decl; tparam.h now does this.
8356 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8357 * terminfo.c: Include tparam.h, to check interfaces.
8358 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8359 (tparam): Adjust signature to match interface in tparam.h;
8360 this removes some undefined behavior. Check that outstring and len
8361 are zero, which they always are with Emacs.
8362 * tparam.h (PC, BC, UP): New extern decls.
8363
8364 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8365 (xftfont_open): Rename locals to avoid shadowing.
8366
8367 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8368 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8369 (OTF_TAG_SYM): Omit macro if not needed.
8370 (ftfont_list): Remove unused local.
8371 (get_adstyle_property, ftfont_pattern_entity):
8372 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8373 Rename locals to avoid shadowing.
8374
8375 * xfont.c (xfont_list_family): Mark var as initialized.
8376
8377 * xml.c (make_dom): Now static.
8378
8379 * composite.c (composition_compute_stop_pos): Rename local to
8380 avoid shadowing.
8381 (composition_reseat_it): Remove unused locals.
8382 (find_automatic_composition, composition_adjust_point): Likewise.
8383 (composition_update_it): Mark var as initialized.
8384 (find_automatic_composition): Mark vars as initialized,
8385 with a FIXME (Bug#8290).
8386
8387 character.h: Rename locals to avoid shadowing.
8388 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8389 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8390 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8391 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8392 to avoid shadowing.
8393
8394 * textprop.c (property_change_between_p): Remove; unused.
8395
8396 * intervals.c (interval_start_pos): Now static.
8397
8398 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8399
8400 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8401 Rename locals to avoid shadowing.
8402
8403 * sound.c (wav_play, au_play, Fplay_sound_internal):
8404 Fix pointer signedness.
8405 (alsa_choose_format): Remove unused local var.
8406 (wav_play): Initialize a variable to 0, to prevent undefined
8407 behavior (Bug#8278).
8408
8409 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8410
8411 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8412
8413 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8414 clobbering (Bug#8298).
8415 * sysdep.c (sys_subshell): Likewise.
8416 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8417
8418 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8419 This should get cleaned up, so that child_setup has the
8420 same signature on all platforms.
8421
8422 * callproc.c (call_process_cleanup): Now static.
8423 (relocate_fd): Rename locals to avoid shadowing.
8424
8425 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8426
8427 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8428 not to be necessary, and produces flickering.
8429
8430 2011-03-20 Glenn Morris <rgm@gnu.org>
8431
8432 * config.in: Remove file.
8433
8434 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8435
8436 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8437 are now in src/globals.h.
8438 (syms_of_minibuf): Remove spurious & from previous change.
8439
8440 2011-03-20 Leo Liu <sdl.web@gmail.com>
8441
8442 * minibuf.c (completing-read-function): New variable.
8443 (completing-read-default): Rename from completing-read.
8444 (completing-read): Call completing-read-function.
8445
8446 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8447
8448 * xfaces.c (Fx_load_color_file):
8449 Read color file from absolute filename (bug#8250).
8450
8451 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8452
8453 * makefile.w32-in: Update dependencies.
8454
8455 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8456
8457 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8458
8459 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8460
8461 Fix more problems found by GCC 4.5.2's static checks.
8462
8463 * process.c (make_serial_process_unwind, send_process_trap):
8464 (sigchld_handler): Now static.
8465
8466 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8467 That way, the code declares only the vars that it needs.
8468 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8469 * s/cygwin.h (PTY_ITERATION): Likewise.
8470 * s/darwin.h (PTY_ITERATION): Likewise.
8471 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8472
8473 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8474 * process.c (allocate_pty): Don't declare stb unless it's needed.
8475
8476 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8477 (CONSTANTLIM): Remove; unused.
8478 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8479 Define only if needed.
8480
8481 * unexelf.c (unexec): Name an expression,
8482 to avoid gcc -Wbad-function-cast warning.
8483 Use a different way to cause a compilation error if anyone uses
8484 n rather than nn, a way that does not involve shadowing.
8485 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8486
8487 * deps.mk (unexalpha.o): Remove; unused.
8488
8489 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8490 * unexec.h: New file.
8491 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8492 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8493 Depend on unexec.h.
8494 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8495 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8496 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8497 Change as necessary to match prototype in unexec.h.
8498
8499 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8500 shadowing.
8501 (back_comment, skip_chars): Mark vars as initialized.
8502
8503 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8504 Rename locals to avoid shadowing.
8505
8506 * lread.c (read1): Rewrite so as not to use empty "else".
8507 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8508
8509 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8510
8511 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8512 warning when compiling print.c.
8513
8514 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8515 instead of using an uninitialized var.
8516 (font_sort_entities): Mark var as initialized.
8517
8518 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8519
8520 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8521 pointers to constants.
8522 (font_parse_fcname): Remove unused vars.
8523 (font_delete_unmatched): Now static.
8524 (font_get_spec): Remove; unused.
8525 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8526 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8527 Rename or move locals to avoid shadowing.
8528
8529 * fns.c (require_nesting_list, require_unwind): Now static.
8530 (Ffillarray): Rename locals to avoid shadowing.
8531
8532 * floatfns.c (domain_error2): Define only if needed.
8533 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8534
8535 * alloc.c (mark_backtrace): Move decl from here ...
8536 * lisp.h: ... to here, so that it can be checked.
8537
8538 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8539 (Fdefvar): Rewrite so as not to use empty "else".
8540 (lisp_indirect_variable): Name an expression,
8541 to avoid gcc -Wbad-function-cast warning.
8542 (Fdefvar): Rename locals to avoid shadowing.
8543
8544 * callint.c (quotify_arg, quotify_args): Now static.
8545 (Fcall_interactively): Rename locals to avoid shadowing.
8546 Use const pointer when appropriate.
8547
8548 * lisp.h (get_system_name, get_operating_system_release):
8549 Move decls here, to check interfaces.
8550 * process.c (get_operating_system_release): Move decl to lisp.h.
8551 * xrdb.c (get_system_name): Likewise.
8552 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8553 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8554 some of which prompt warnings from gcc -Wbad-function-cast.
8555 (Fformat_time_string, Fencode_time, Finsert_char):
8556 (Ftranslate_region_internal, Fformat):
8557 Rename or remove local vars to avoid shadowing.
8558 (Ftranslate_region_internal): Mark var as initialized.
8559
8560 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8561 avoid shadowing.
8562
8563 * lisp.h (eassert): Check that the argument compiles, even if
8564 ENABLE_CHECKING is not defined.
8565
8566 * data.c (Findirect_variable): Name an expression, to avoid
8567 gcc -Wbad-function-cast warning.
8568 (default_value, arithcompare, arith_driver, arith_error): Now static.
8569 (store_symval_forwarding): Rename local to avoid shadowing.
8570 (Fmake_variable_buffer_local, Fmake_local_variable):
8571 Mark variables as initialized.
8572 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8573
8574 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8575 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8576 Rename locals to avoid shadowing.
8577 (mark_stack): Move local variables into the #ifdef region where
8578 they're used.
8579 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8580 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8581 needed otherwise.
8582 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8583 (GC_STRING_CHARS): Remove; not used.
8584 (Fmemory_limit): Cast sbrk's returned value to char *.
8585
8586 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8587 avoids undefined behavior in theory.
8588
8589 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8590
8591 Use functions, not macros, for up- and down-casing (Bug#8254).
8592 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8593 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8594 to use the following functions instead of these macros.
8595 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8596 EMACS_INT, since callers assume the returned value fits in int.
8597 (upcase1): Likewise, for UPCASE_TABLE.
8598 (uppercasep, lowercasep, upcase): New static inline functions.
8599 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8600 the race-condition problem in the old DOWNCASE.
8601
8602 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8603 Rename locals to avoid shadowing.
8604 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8605 (regex_compile, re_search_2, re_match_2_internal):
8606 Remove unused local vars.
8607 (FREE_VAR): Rewrite so as not to use empty "else",
8608 which gcc can warn about.
8609 (regex_compile, re_match_2_internal): Mark locals as initialized.
8610 (RETALLOC_IF): Define only if needed.
8611 (WORDCHAR_P): Likewise. This one is never needed, but is used
8612 only in a comment talking about a compiler bug, so put inside
8613 the #if 0 of that comment.
8614 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8615 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8616 Remove; unused.
8617
8618 * search.c (boyer_moore): Rename locals to avoid shadowing.
8619 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8620 (PREV_CHAR_BOUNDARY): Likewise.
8621
8622 * search.c (simple_search): Remove unused var.
8623
8624 * dired.c (compile_pattern): Move decl from here ...
8625 * lisp.h: ... to here, so that it can be checked.
8626 (struct re_registers): New forward decl.
8627
8628 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8629
8630 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8631 All uses changed.
8632 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8633 Rename locals to avoid shadowing.
8634 (Fvertical_motion): Mark locals as initialized.
8635
8636 * casefiddle.c (casify_object, casify_region): Now static.
8637 (casify_region): Mark local as initialized.
8638
8639 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8640
8641 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8642 New macros, so that the caller can use some names other than
8643 gcpro1, gcpro2, etc.
8644 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8645 of the new macros.
8646 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8647 argument, for consistency with GCPRO2_VAR, etc: it is now the
8648 prefix of the variable, not the variable itself. All uses
8649 changed.
8650 * dired.c (directory_files_internal, file_name_completion):
8651 Rename locals to avoid shadowing.
8652
8653 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8654 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8655 dired.c's scmp function, had undefined behavior.
8656 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8657 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8658 * buffer.h: ... to here, because these macros use current_buffer,
8659 and the new implementation with inline functions needs to have
8660 current_buffer in scope now, rather than later when the macros
8661 are used.
8662 (downcase, upcase1): New static inline functions.
8663 (DOWNCASE, UPCASE1): Reimplement using these functions.
8664 This avoids undefined behavior in expressions like
8665 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8666 from race conditions in accessing the global variables
8667 case_temp1 and case_temp2.
8668 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8669 * lisp.h (case_temp1, case_temp2): Remove their decls.
8670 * character.h (ASCII_CHAR_P): Move from here ...
8671 * lisp.h: ... to here, so that the inline functions mentioned
8672 above can use them.
8673
8674 * dired.c (directory_files_internal_unwind): Now static.
8675
8676 * fileio.c (file_name_as_directory, directory_file_name):
8677 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8678 Now static.
8679 (file_name_as_directory): Use const pointers when appropriate.
8680 (Fexpand_file_name): Likewise. In particular, newdir might
8681 point at constant storage, so make it a const pointer.
8682 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8683 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8684 signedness issues.
8685 (Fset_file_times, Finsert_file_contents, auto_save_error):
8686 Rename locals to avoid shadowing.
8687
8688 * minibuf.c (choose_minibuf_frame_1): Now static.
8689 (Ftry_completion, Fall_completions): Rename or remove locals
8690 to avoid shadowing.
8691
8692 * marker.c (bytepos_to_charpos): Remove; unused.
8693
8694 * lisp.h (verify_bytepos, count_markers): New decls,
8695 so that gcc does not warn that these functions aren't declared.
8696
8697 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8698 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8699 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8700 (copy_text): Remove unused local var.
8701
8702 * filelock.c (within_one_second): Now static.
8703 (lock_file_1): Rename local to avoid shadowing.
8704
8705 * buffer.c (fix_overlays_before): Mark locals as initialized.
8706 (fix_start_end_in_overlays): Likewise. This function should be
8707 simplified by using pointers-to-pointers, but that's a different
8708 matter.
8709 (switch_to_buffer_1): Now static.
8710 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8711 (report_overlay_modification): Rename locals to avoid shadowing.
8712
8713 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8714 Fix pointer signedness issue.
8715 (sys_subshell): Mark local as volatile if checking for lint,
8716 to suppress a gcc -Wclobbered warning that does not seem to be right.
8717 (MAXPATHLEN): Define only if needed.
8718
8719 * process.c (serial_open, serial_configure): Move decls from here ...
8720 * systty.h: ... to here, so that they can be checked.
8721
8722 * fns.c (get_random, seed_random): Move extern decls from here ...
8723 * lisp.h: ... to here, so that they can be checked.
8724
8725 * sysdep.c (reset_io): Now static.
8726 (wait_for_termination_signal): Remove; unused.
8727
8728 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8729 (copy_keymap_item, append_key, push_text_char_description):
8730 Now static.
8731 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8732 (DENSE_TABLE_SIZE): Remove; unused.
8733 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8734 (describe_map_tree):
8735 Rename locals to avoid shadowing.
8736
8737 * keyboard.c: Declare functions static if they are not used elsewhere.
8738 (echo_char, echo_dash, cmd_error, top_level_2):
8739 (poll_for_input, handle_async_input): Now static.
8740 (read_char, kbd_buffer_get_event, make_lispy_position):
8741 (make_lispy_event, make_lispy_movement, apply_modifiers):
8742 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8743 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8744 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8745 (read_key_sequence, read_char): Mark locals as initialized.
8746 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8747
8748 * keyboard.h (make_ctrl_char): New decl.
8749 (mark_kboards): Move decl here ...
8750 * alloc.c (mark_kboards): ... from here.
8751
8752 * lisp.h (force_auto_save_soon): New decl.
8753
8754 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8755 (DEFINE_DUMMY_FUNCTION): New macro.
8756 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8757 Use it.
8758 (main): Add casts to avoid warnings
8759 if GCC considers string literals to be constants.
8760
8761 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8762
8763 * dbusbind.c: Pointer signedness fixes.
8764 (xd_signature, xd_append_arg, xd_initialize):
8765 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8766 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8767 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8768 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8769
8770 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8771 if GCC considers string literals to be constants.
8772 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8773
8774 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8775
8776 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8777 (print_preprocess, print_object): New macro to fix last change.
8778
8779 * print.c (print_preprocess): Don't forget font objects.
8780
8781 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8782
8783 * emacs.c (USAGE3): Doc fixes.
8784
8785 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8786
8787 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8788 structure.
8789
8790 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8791
8792 * lisp.h (VWindow_system, Qfile_name_history):
8793 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8794 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8795 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8796
8797 * w32select.c: Don't #include "keyboard.h".
8798 (run_protected): Add extern declaration for waiting_for_input.
8799
8800 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8801 * w32console.c (detect_input_pending, read_input_pending)
8802 (encode_terminal_code):
8803 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8804 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8805 (w32_system_caret_y, Qfile_name_history):
8806 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8807 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8808 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8809 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8810 * w32proc.c (Qlocal, report_file_error):
8811 * w32term.c (Vwindow_system, updating_frame):
8812 * w32uniscribe.c (initialized, uniscribe_font_driver):
8813 Remove unneeded extern declarations.
8814
8815 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8816
8817 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8818
8819 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8820
8821 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8822 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8823 These macros can no longer be used for assignment.
8824
8825 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8826 Assign struct members directly, instead of using BUF_BEGV etc.
8827 (record_buffer_markers, fetch_buffer_markers): New functions for
8828 recording and fetching special buffer markers.
8829 (set_buffer_internal_1, set_buffer_temp): Use them.
8830
8831 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8832
8833 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8834
8835 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8836 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8837
8838 * xdisp.c (hscroll_window_tree):
8839 (reconsider_clip_changes): Use PT instead of BUF_PT.
8840
8841 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8842
8843 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8844 $(EMACS_ROOT)/lib/intprops.h.
8845
8846 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8847
8848 Fix more problems found by GCC 4.5.2's static checks.
8849
8850 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8851 to unsigned char * to avoid compiler diagnostic.
8852 (xg_free_frame_widgets): Make it clear that a local variable is
8853 needed only if USE_GTK_TOOLTIP.
8854 (gdk_window_get_screen): Make it clear that this macro is needed
8855 only if USE_GTK_TOOLTIP.
8856 (int_gtk_range_get_value): New function, which avoids a diagnostic
8857 from gcc -Wbad-function-cast.
8858 (xg_set_toolkit_scroll_bar_thumb): Use it.
8859 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8860 diagnostic from gcc -Wbad-function-cast.
8861 (get_utf8_string, xg_get_file_with_chooser):
8862 Rename locals to avoid shadowing.
8863 (create_dialog): Move locals to avoid shadowing.
8864
8865 * xgselect.c (xg_select): Remove unused var.
8866
8867 * image.c (four_corners_best): Mark locals as initialized.
8868 (gif_load): Initialize transparent_p to zero (Bug#8238).
8869 Mark another local as initialized.
8870 (my_png_error, my_error_exit): Mark with NO_RETURN.
8871
8872 * image.c (clear_image_cache): Now static.
8873 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8874 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8875 (x_edge_detection): Remove unnecessary cast that
8876 gcc -Wbad-function-cast diagnoses.
8877 (gif_load): Fix pointer signedness.
8878 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8879 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8880
8881 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8882
8883 Improve quality of tests for time stamp overflow.
8884 For example, without this patch (encode-time 0 0 0 1 1
8885 1152921504606846976) returns the obviously-bogus value (-948597
8886 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8887 reports time overflow. See
8888 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8889 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8890 * editfns.c: Include limits.h and intprops.h.
8891 (TIME_T_MIN, TIME_T_MAX): New macros.
8892 (time_overflow): Move earlier, to before first use.
8893 (hi_time, lo_time): New functions, for an accurate test for
8894 out-of-range times.
8895 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8896 (Fget_internal_run_time): Don't assume time_t fits in int.
8897 (make_time): Use list2 instead of Fcons twice.
8898 (Fdecode_time): More accurate test for out-of-range times.
8899 (check_tm_member): New function.
8900 (Fencode_time): Use it, to test for out-of-range times.
8901 (lisp_time_argument): Don't rely on undefined left-shift and
8902 right-shift behavior when checking for time stamp overflow.
8903
8904 * editfns.c (time_overflow): New function, refactoring common code.
8905 (Fformat_time_string, Fdecode_time, Fencode_time):
8906 (Fcurrent_time_string): Use it.
8907
8908 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8909 * dired.c (make_time): Move to ...
8910 * editfns.c (make_time): ... here.
8911 * systime.h: Note the move.
8912
8913 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8914
8915 * fringe.c (update_window_fringes): Remove unused variables.
8916
8917 * unexmacosx.c (copy_data_segment): Also copy __got section.
8918 (Bug#8223)
8919
8920 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8921
8922 * termcap.c [MSDOS]: Include "msdos.h".
8923 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8924 Constify `char *' arguments and their references according to
8925 prototypes in tparam.h.
8926
8927 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8928
8929 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8930 Adapt all references accordingly.
8931
8932 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8933
8934 2011-03-11 Tom Tromey <tromey@redhat.com>
8935
8936 * buffer.c (syms_of_buffer): Remove obsolete comment.
8937
8938 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8939
8940 * termhooks.h (encode_terminal_code): Declare prototype.
8941
8942 * msdos.c (encode_terminal_code): Don't declare prototype.
8943
8944 * term.c (encode_terminal_code): Now external again, used by
8945 w32console.c and msdos.c.
8946
8947 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8948 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8949
8950 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8951
8952 Fix some minor problems found by GCC 4.5.2's static checks.
8953
8954 * fringe.c (update_window_fringes): Mark locals as initialized
8955 (Bug#8227).
8956 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8957
8958 * alloc.c (mark_fringe_data): Move decl from here ...
8959 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8960 to check its interface.
8961 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8962
8963 * fontset.c (free_realized_fontset): Now static.
8964 (Fset_fontset_font): Rename local to avoid shadowing.
8965 (fontset_font): Mark local as initialized.
8966 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8967
8968 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8969
8970 * xselect.c (x_disown_buffer_selections): Remove; not used.
8971 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8972 (x_own_selection, Fx_disown_selection_internal): Rename locals
8973 to avoid shadowing.
8974 (x_handle_dnd_message): Remove local to avoid shadowing.
8975
8976 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8977 so that the caller can use some name other than gcpro1.
8978 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8979 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8980 (Fx_backspace_delete_keys_p):
8981 Use them to avoid shadowing, and rename vars to avoid shadowing.
8982 (x_decode_color, x_set_name, x_window): Now static.
8983 (Fx_create_frame): Add braces to silence GCC warning.
8984 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8985 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8986 Remove unused locals.
8987 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8988 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8989 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8990 macros.
8991
8992 * xterm.h (x_mouse_leave): New decl.
8993
8994 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8995 Remove unused functions.
8996 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8997 (x_calc_absolute_position): Now static.
8998 (XTread_socket): Don't define label "out" unless it's used.
8999 Don't declare local "event" unless it's used.
9000 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9001 unless they are used.
9002 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9003 (x_fatal_error_signal): Remove; not used.
9004 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9005 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9006 (x_error_catcher, x_connection_closed, x_error_handler):
9007 (x_error_quitter, xembed_send_message, x_iconify_frame):
9008 (my_log_handler): Rename locals to avoid shadowing.
9009 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9010 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9011
9012 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9013 Rename or move locals to avoid shadowing.
9014 (tty_defined_color, merge_face_heights): Now static.
9015 (free_realized_faces_for_fontset): Remove; not used.
9016 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9017 does not deduce is never used uninitialized.
9018 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9019 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9020
9021 * terminal.c (store_terminal_param): Now static.
9022
9023 * xmenu.c (menu_highlight_callback): Now static.
9024 (set_frame_menubar): Remove unused local.
9025 (xmenu_show): Rename parameter to avoid shadowing.
9026 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9027 since they might point to immutable storage.
9028 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9029 since it's unused otherwise.
9030
9031 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9032 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9033 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9034 avoids a gcc -Wuninitialized diagnostic.
9035 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9036 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9037 does not deduce are never used uninitialized.
9038
9039 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9040
9041 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9042 * window.c (window_loop, size_window):
9043 (run_window_configuration_change_hook, enlarge_window): Likewise.
9044
9045 * window.c (display_buffer): Now static.
9046 (size_window): Mark variables that gcc -Wuninitialized
9047 does not deduce are never used uninitialized.
9048 * window.h (check_all_windows): New decl, to forestall
9049 gcc -Wmissing-prototypes diagnostic.
9050 * dispextern.h (bidi_dump_cached_states): Likewise.
9051
9052 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9053 shadowing.
9054 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9055 Include <limits.h>.
9056 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9057 and to avoid gcc -Wuninitialized warning.
9058 (load_charset_map): Mark variables that gcc -Wuninitialized
9059 does not deduce are never used uninitialized.
9060 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9061
9062 * coding.c (coding_set_source, coding_set_destination):
9063 Use "else { /* comment */ }" rather than "else /* comment */;"
9064 for clarity, and to avoid gcc -Wempty-body warning.
9065 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9066 a block, when the outer 'i' will do.
9067 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9068 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9069 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9070 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9071 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9072 Rename locals to avoid shadowing.
9073 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9074 * coding.c (emacs_mule_char, encode_invocation_designation):
9075 Now static, since they're not used elsewhere.
9076 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9077 (decode_coding_object, encode_coding_object, detect_coding_system):
9078 (decode_coding_emacs_mule): Mark variables that gcc
9079 -Wuninitialized does not deduce are never used uninitialized.
9080 (detect_coding_iso_2022): Initialize a local variable that might
9081 be used uninitialized. Leave a FIXME because it's not clear that
9082 this initialization is needed. (Bug#8211)
9083 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9084 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9085 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9086 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9087 Remove unused macros.
9088
9089 * category.c (hash_get_category_set): Remove unused local var.
9090 (copy_category_table): Now static, since it's not used elsewhere.
9091 * character.c (string_count_byte8): Likewise.
9092
9093 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9094 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9095
9096 * chartab.c (copy_sub_char_table): Now static, since it's not used
9097 elsewhere.
9098 (sub_char_table_ref_and_range, char_table_ref_and_range):
9099 Rename locals to avoid shadowing.
9100 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9101
9102 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9103 (BIDI_BOB): Remove unused macro.
9104
9105 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9106 deduce are never used uninitialized.
9107 * term.c (encode_terminal_code): Likewise.
9108
9109 * term.c (encode_terminal_code): Now static. Remove unused local.
9110
9111 * tparam.h: New file.
9112 * term.c, tparam.h: Include it.
9113 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9114 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9115 Move these decls to tparam.h, and make them agree with what
9116 is actually in tparam.c. The previous trick of using incompatible
9117 decls in different modules does not conform to the C standard.
9118 All callers of tparam changed to use tparam's actual API.
9119 * tparam.c (tparam1, tparam, tgoto):
9120 Use const pointers where appropriate.
9121
9122 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9123 * cm.h (struct cm): Likewise.
9124 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9125 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9126 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9127 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9128 (turn_on_face, init_tty): Likewise.
9129 * termchar.h (struct tty_display_info): Likewise.
9130
9131 * term.c (term_mouse_position): Rename local to avoid shadowing.
9132
9133 * alloc.c (mark_ttys): Move decl from here ...
9134 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9135
9136 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9137
9138 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9139
9140 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9141
9142 * search.c (compile_pattern_1): Remove argument regp, unused since
9143 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9144 (compile_pattern): Don't pass it.
9145
9146 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9147
9148 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9149 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9150 for ! HAVE_GTK3.
9151 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9152
9153 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9154
9155 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9156 gdk_window_get_screen, gdk_window_get_geometry,
9157 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9158 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9159 (xg_get_pixbuf_from_pixmap): New function.
9160 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9161 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9162 Call xg_get_pixbuf_from_pixmap instead of
9163 gdk_pixbuf_get_from_drawable.
9164 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9165 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9166 (xg_check_special_colors): Use GtkStyleContext and its functions
9167 for HAVE_GTK3.
9168 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9169 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9170 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9171 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9172 Call gtk_widget_get_preferred_size.
9173 (xg_frame_resized): gdk_window_get_geometry only takes 5
9174 parameters.
9175 (xg_win_to_widget, xg_event_is_for_menubar):
9176 Call gdk_x11_window_lookup_for_display.
9177 (xg_set_widget_bg): New function.
9178 (delete_cb): New function.
9179 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9180 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9181 (xg_set_background_color): Call xg_set_widget_bg.
9182 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9183 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9184 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9185 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9186 if ! HAVE_GTK3.
9187 (update_frame_tool_bar): Call gtk_widget_hide.
9188 (xg_initialize): Use GDK_KEY_g.
9189
9190 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9191 if ! HAVE_GTK3
9192 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9193
9194 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9195 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9196 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9197
9198 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9199
9200 * w32xfns.c (select_palette): Check success of RealizePalette against
9201 GDI_ERROR, not zero.
9202
9203 See ChangeLog.11 for earlier changes.
9204
9205 ;; Local Variables:
9206 ;; coding: utf-8
9207 ;; End:
9208
9209 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9210
9211 This file is part of GNU Emacs.
9212
9213 GNU Emacs is free software: you can redistribute it and/or modify
9214 it under the terms of the GNU General Public License as published by
9215 the Free Software Foundation, either version 3 of the License, or
9216 (at your option) any later version.
9217
9218 GNU Emacs is distributed in the hope that it will be useful,
9219 but WITHOUT ANY WARRANTY; without even the implied warranty of
9220 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9221 GNU General Public License for more details.
9222
9223 You should have received a copy of the GNU General Public License
9224 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.