Remove an incorrect assertion on move_it_by_lines.
[bpt/emacs.git] / src / ChangeLog
1 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4 string comes from a `display' text property, use the buffer
5 position of that property as if we actually saw that position in
6 the row's glyphs.
7 (move_it_by_lines): Remove the assertion that
8 "it->current_x == 0 && it->hpos == 0" which can be legitimately
9 violated when there's a before-string at the beginning of a line.
10 (Bug#11063)
11
12 2012-03-30 Eli Zaretskii <eliz@gnu.org>
13
14 * xdisp.c (append_space_for_newline): If the default face was
15 remapped, use the remapped face for the appended newline.
16 (extend_face_to_end_of_line): Use the remapped default face for
17 extending the face to the end of the line.
18 (display_line): Call extend_face_to_end_of_line when the default
19 face was remapped. (Bug#11068)
20
21 2012-03-29 Eli Zaretskii <eliz@gnu.org>
22
23 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
24
25 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
26
27 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
28
29 2012-03-27 Glenn Morris <rgm@gnu.org>
30
31 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
32 Doc fixes.
33
34 2012-03-26 Kenichi Handa <handa@m17n.org>
35
36 * dispextern.h (struct glyph): Fix previous change. Change the
37 bit length of glyphless.ch to 25 (Bug#11082).
38
39 2012-03-26 Chong Yidong <cyd@gnu.org>
40
41 * keyboard.c (Vselection_inhibit_update_commands): New variable.
42 (command_loop_1): Use it; inhibit selection update for
43 handle-select-window too (Bug#8996).
44
45 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
46
47 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
48
49 2012-03-25 Kenichi Handa <handa@m17n.org>
50
51 * dispextern.h (struct glyph): Change the bit length of
52 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
53
54 2012-03-24 Eli Zaretskii <eliz@gnu.org>
55
56 * s/ms-w32.h (tzname): Include time.h before redirecting to
57 _tzname. Fixes the MSVC build. (Bug#9960)
58
59 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
60
61 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
62 characters.
63
64 * xterm.c (XTread_socket): Only modify handling_signal if
65 !SYNC_INPUT. (Bug#11080)
66
67 2012-03-23 Eli Zaretskii <eliz@gnu.org>
68
69 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
70 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
71 when fetching a multibyte character consumes more bytes than
72 CHAR_BYTES returns, due to unification of CJK characters in
73 string_char. (Bug#11073)
74
75 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
76
77 * process.c (wait_reading_process_output): Handle pty disconnect
78 by refraining from sending oneself a SIGCHLD (bug#10933).
79
80 2012-03-22 Chong Yidong <cyd@gnu.org>
81
82 * dispextern.h (struct it): New member string_from_prefix_prop_p.
83
84 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
85 Mark string as coming from a prefix property.
86 (handle_face_prop): Use default face for prefix strings (Bug#4281).
87 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
88
89 2012-03-21 Chong Yidong <cyd@gnu.org>
90
91 * xfaces.c (Vface_remapping_alist): Doc fix.
92
93 2012-03-20 Eli Zaretskii <eliz@gnu.org>
94
95 * w32proc.c (Fw32_set_console_codepage)
96 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
97 Doc fixes.
98
99 2012-03-20 Chong Yidong <cyd@gnu.org>
100
101 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
102 to reflect default non-nil value of redisplay-dont-pause.
103
104 2012-03-19 Kenichi Handa <handa@m17n.org>
105
106 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
107 it fit in a valid range (Bug#11003).
108
109 2012-03-18 Eli Zaretskii <eliz@gnu.org>
110
111 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
112 that is not from display property, accept the row as a "cursor
113 row" if one of the string's character has a non-nil `cursor'
114 property. Fixes cursor positioning when there are newlines in
115 overlay strings, e.g. in icomplete.el. (Bug#11035)
116
117 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
118
119 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
120
121 2012-03-12 Chong Yidong <cyd@gnu.org>
122
123 * eval.c (inhibit_lisp_code): Rename from
124 inhibit_window_configuration_change_hook; move from window.c.
125
126 * xfns.c (unwind_create_frame_1, Fx_create_frame):
127 * window.c (run_window_configuration_change_hook)
128 (syms_of_window): Callers changed.
129
130 2012-03-11 Chong Yidong <cyd@gnu.org>
131
132 * keymap.c (Fkey_description): Doc fix (Bug#9700).
133
134 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
135
136 2012-03-10 Chong Yidong <cyd@gnu.org>
137
138 * frame.c (other_visible_frames): Don't assume the selected frame
139 is visible (Bug#10955).
140
141 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
142
143 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
144
145 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
146
147 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
148 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
149 zero (Bug#10954).
150
151 2012-03-03 Glenn Morris <rgm@gnu.org>
152
153 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
154
155 2012-03-02 Eli Zaretskii <eliz@gnu.org>
156
157 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
158 position past the first glyph_row that ends at ZV. (Bug#10902)
159 (redisplay_window, next_element_from_string): Fix typos in
160 comments.
161 (redisplay_window): Pass to move_it_vertically the margin in
162 pixels, not in screen lines.
163
164 2012-03-02 Glenn Morris <rgm@gnu.org>
165
166 * buffer.c (buffer-list-update-hook): Doc fix.
167
168 2012-02-29 Eli Zaretskii <eliz@gnu.org>
169
170 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
171 push_it before setting up the iterator for the first overlay
172 string, even if we have an empty string loaded.
173 (next_overlay_string): If there's an empty string on the iterator
174 stack, pop the stack. (Bug#10903)
175
176 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
177
178 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
179 Suggested by Stefan Monnier in
180 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
181 * alloc.c (widen_to_Lisp_Object): New static function.
182 (mark_memory): Also mark Lisp_Objects by fetching pointer words
183 and widening them to Lisp_Objects. This would work even if
184 USE_LSB_TAG is defined and wide integers are used, which might
185 happen in a future version of Emacs.
186
187 2012-02-25 Chong Yidong <cyd@gnu.org>
188
189 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
190 Doc fix.
191
192 * xselect.c (Fx_selection_exists_p): Doc fix.
193 (x_clipboard_manager_save_all): Print an informative message
194 before saving to clipboard manager.
195
196 2012-02-24 Chong Yidong <cyd@gnu.org>
197
198 * keyboard.c (process_special_events): Handle all X selection
199 requests in kbd_buffer, not just the next one (Bug#8869).
200
201 2012-02-23 Chong Yidong <cyd@gnu.org>
202
203 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
204 call when setting menu-bar-lines and tool-bar-lines parameters.
205 (unwind_create_frame_1): New helper function.
206
207 * window.c (inhibit_window_configuration_change_hook): New var.
208 (run_window_configuration_change_hook): Obey it.
209 (syms_of_window): Initialize it.
210
211 2012-02-22 Chong Yidong <cyd@gnu.org>
212
213 * xterm.c (x_draw_image_relief): Add missing type check for
214 Vtool_bar_button_margin (Bug#10743).
215
216 2012-02-21 Chong Yidong <cyd@gnu.org>
217
218 * fileio.c (Vfile_name_handler_alist): Doc fix.
219
220 * buffer.c (Fget_file_buffer): Protect against invalid file
221 handler return value.
222
223 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
224
225 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
226 when computing $valmask.
227
228 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
229 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
230 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
231 It's useless in that case, and it can cause problems on hosts
232 that allocate halves of EMACS_INT values separately.
233 Reported by Dan Horák. Diagnosed by Andreas Schwab in
234 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
235 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
236 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
237 it avoids undefined behavior on hosts where shifting right by more
238 than the word width has undefined behavior.
239
240 2012-02-19 Chong Yidong <cyd@gnu.org>
241
242 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
243 (Funhandled_file_name_directory, Ffile_name_as_directory)
244 (Fdirectory_file_name, Fexpand_file_name)
245 (Fsubstitute_in_file_name): Protect against invalid file handler
246 return values (Bug#10845).
247
248 2012-02-18 Eli Zaretskii <eliz@gnu.org>
249
250 * .gdbinit (pitx): Fix incorrect references to fields of the
251 iterator stack.
252
253 2012-02-17 Chong Yidong <cyd@gnu.org>
254
255 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
256
257 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
258
259 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
260 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
261
262 2012-02-15 Chong Yidong <cyd@gnu.org>
263
264 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
265 marked as special. Also, starting docstrings with * is obsolete.
266
267 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
268
269 * gnutls.c (emacs_gnutls_write): Fix last change.
270
271 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
272
273 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
274 send_process.
275
276 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
277
278 * keymap.c (Fsingle_key_description): Handle char ranges.
279
280 2012-02-12 Chong Yidong <cyd@gnu.org>
281
282 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
283 as that creates a dangerous corner case.
284
285 * window.c (Fdelete_window_internal): Invalidate the mouse
286 highlight (Bug#9904).
287
288 2012-02-12 Glenn Morris <rgm@gnu.org>
289
290 * xselect.c (Fx_own_selection_internal)
291 (Fx_get_selection_internal, Fx_disown_selection_internal)
292 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
293 * nsselect.m (Fx_own_selection_internal)
294 (Fx_disown_selection_internal, Fx_selection_exists_p)
295 (Fx_selection_owner_p, Fx_get_selection_internal):
296 Sync docs and argument specs with the xselect.c versions.
297
298 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
299
300 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
301
302 2012-02-11 Eli Zaretskii <eliz@gnu.org>
303
304 * w32select.c (Fx_selection_exists_p): Sync doc string and
305 argument list with xselect.c. (Bug#10783)
306
307 * w16select.c (Fx_selection_exists_p): Sync doc string and
308 argument list with xselect.c. (Bug#10783)
309
310 2012-02-10 Glenn Morris <rgm@gnu.org>
311
312 * fns.c (Fsecure_hash): Doc fix.
313
314 2012-02-09 Kenichi Handa <handa@m17n.org>
315
316 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
317
318 2012-02-07 Chong Yidong <cyd@gnu.org>
319
320 * buffer.c (Fbuffer_local_variables)
321 (buffer_lisp_local_variables): Handle unbound vars correctly;
322 don't let Qunbound leak into Lisp.
323
324 2012-02-07 Glenn Morris <rgm@gnu.org>
325
326 * image.c (Fimagemagick_types): Doc fix.
327
328 * image.c (imagemagick-render-type): Change it from a lisp object
329 to an integer. Move the doc here from the lisp manual.
330 Treat all values not equal to 0 the same.
331
332 2012-02-06 Chong Yidong <cyd@gnu.org>
333
334 * doc.c (store_function_docstring): Avoid applying docstring of
335 alias to base function (Bug#2603).
336
337 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
338
339 * .gdbinit (pp1, pv1): Remove redundant defines.
340 (pr): Use pp.
341
342 2012-02-04 Chong Yidong <cyd@gnu.org>
343
344 * nsterm.m: Declare a global (Bug#10694).
345
346 2012-02-04 Eli Zaretskii <eliz@gnu.org>
347
348 * w32.c (get_emacs_configuration_options):
349 Include --enable-checking, if specified, in the return value.
350
351 2012-02-04 Martin Rudalics <rudalics@gmx.at>
352
353 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
354 after rounding frame sizes. (Bug#9723)
355
356 2012-02-04 Eli Zaretskii <eliz@gnu.org>
357
358 * keyboard.c (adjust_point_for_property): Don't position point
359 before BEGV. (Bug#10696)
360
361 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
362
363 Handle overflow when computing char display width (Bug#9496).
364 * character.c (char_width): Return EMACS_INT, not int.
365 (char_width, c_string_width): Check for overflow when
366 computing the width; this is possible now that individual
367 characters can have unbounded width. Problem introduced
368 by merge from Emacs 23 on 2012-01-19.
369
370 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
371
372 * dbusbind.c (Fdbus_register_method): Mention the return value
373 :ignore in the docstring.
374
375 2012-02-02 Glenn Morris <rgm@gnu.org>
376
377 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
378
379 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
380 Unconditionally set to t. (Bug#10673)
381 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
382 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
383 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
384
385 2012-02-02 Kenichi Handa <handa@m17n.org>
386
387 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
388 0, do not call append_composite_glyph.
389
390 2012-02-02 Kenichi Handa <handa@m17n.org>
391
392 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
393 NULL (Bug#6988).
394 (x_produce_glyphs): If the component of a composition is a null
395 string, set it->pixel_width to 1 to avoid zero-width glyph.
396
397 2012-02-01 Eli Zaretskii <eliz@gnu.org>
398
399 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
400 first 2 arguments are identical. This makes inserting large
401 output from a subprocess an order of magnitude faster on
402 MS-Windows, where all sbrk'ed memory is always contiguous.
403
404 2012-01-31 Glenn Morris <rgm@gnu.org>
405
406 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
407 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
408 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
409
410 2012-01-29 Glenn Morris <rgm@gnu.org>
411
412 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
413
414 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
415
416 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
417
418 2012-01-28 Chong Yidong <cyd@gnu.org>
419
420 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
421
422 2012-01-26 Chong Yidong <cyd@gnu.org>
423
424 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
425
426 * search.c (Fsearch_forward, Fsearch_backward): Document negative
427 repeat counts (Bug#10507).
428
429 2012-01-26 Glenn Morris <rgm@gnu.org>
430
431 * lread.c (syms_of_lread): Doc fix.
432
433 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
434
435 * coding.c (encode_designation_at_bol): Change return value to
436 EMACS_INT.
437
438 2012-01-25 Chong Yidong <cyd@gnu.org>
439
440 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
441
442 2012-01-21 Chong Yidong <cyd@gnu.org>
443
444 * floatfns.c (Fcopysign): Make the second argument non-optional,
445 since nil is not allowed anyway.
446
447 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
448
449 * process.c (read_process_output): Use p instead of XPROCESS (proc).
450 (send_process): Likewise.
451
452 2012-01-19 Martin Rudalics <rudalics@gmx.at>
453
454 * window.c (save_window_save, Fcurrent_window_configuration)
455 (Vwindow_persistent_parameters): Do not use Qstate.
456 Rewrite doc-strings.
457
458 2012-01-19 Kenichi Handa <handa@m17n.org>
459
460 * character.c (char_width): New function.
461 (Fchar_width, c_string_width, lisp_string_width):
462 Use char_width (Bug#9496).
463
464 2012-01-16 Martin Rudalics <rudalics@gmx.at>
465
466 * window.c (Vwindow_persistent_parameters): New variable.
467 (Fset_window_configuration, save_window_save): Handle persistent
468 window parameters.
469
470 2012-01-14 Eli Zaretskii <eliz@gnu.org>
471
472 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
473 thrashing the stack of the thread. (Bug#9087)
474
475 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
476
477 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
478
479 2012-01-11 Eli Zaretskii <eliz@gnu.org>
480
481 * xdisp.c (rows_from_pos_range): Handle the case where the
482 highlight ends on a newline. (Bug#10464)
483 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
484 he end column for display of highlight that ends on a newline
485 before a R2L line.
486
487 2012-01-11 Glenn Morris <rgm@gnu.org>
488
489 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
490 from load-path also when installation-directory is nil. (Bug#10208)
491
492 2012-01-10 Glenn Morris <rgm@gnu.org>
493
494 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
495
496 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
497 Update template values to be closer to their typical values these days.
498
499 2012-01-09 Eli Zaretskii <eliz@gnu.org>
500
501 * xdisp.c (rows_from_pos_range): Accept additional argument
502 DISP_STRING, and accept any glyph in a row whose object is that
503 string as eligible for mouse highlight. Fixes mouse highlight of
504 display strings from overlays. (Bug#10464)
505
506 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
507
508 emacs: fix an auto-save permissions race condition (Bug#10400)
509 * fileio.c (auto_saving_dir_umask): New static var.
510 (Fmake_directory_internal): Use it.
511 (do_auto_save_make_dir): Set it, instead of invoking chmod after
512 creating the directory. The old code temporarily assigns
513 too-generous permissions to the directory.
514 (do_auto_save_eh): Clear it.
515 (Fdo_auto_save): Catch all errors, not just file errors, so
516 that the var is always cleared.
517
518 2012-01-07 Eli Zaretskii <eliz@gnu.org>
519
520 * search.c (scan_buffer): Pass character positions to
521 know_region_cache, not byte positions. (Bug#6540)
522
523 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
524
525 * w32.c (sys_rename): Report EXDEV when rename of a directory
526 fails because the target is on another logical disk. (Bug#10284)
527
528 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
529
530 * xterm.c (x_embed_request_focus): New function.
531
532 * xterm.h: Add prototype.
533
534 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
535
536 2012-01-05 Glenn Morris <rgm@gnu.org>
537
538 * emacs.c (emacs_copyright): Update short copyright year to 2012.
539
540 2012-01-01 Eli Zaretskii <eliz@gnu.org>
541
542 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
543 Load gnutls_transport_set_lowat only if GnuTLS version is below
544 2.11.1.
545 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
546 GnuTLS versions below 2.11.1.
547
548 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
549
550 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
551 to the doc string advising against its use for altering the way
552 windows are scrolled.
553
554 2011-12-28 Kenichi Handa <handa@m17n.org>
555
556 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
557 coding-system ASCII compatible only when it does not produce BOM
558 on encoding (Bug#10383).
559
560 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
561
562 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
563 can scroll.
564 (create_and_show_popup_menu): Always use menu_position_func for
565 Gtk3 (Bug#10361).
566
567 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
568
569 * callint.c (Fcall_interactively): Don't truncate prompt string.
570
571 2011-12-23 Eli Zaretskii <eliz@gnu.org>
572
573 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
574 property that ends at ZV, so that the bidi iteration could be
575 resumed from there (after widening). (Bug#10360)
576
577 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
578
579 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
580
581 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
582
583 * nsterm.m (x_free_frame_resources):
584 Release f->output_data.ns->miniimage.
585 (ns_index_color): Fix indentation. Do not retain
586 color_table->colors[i].
587
588 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
589 before returning.
590
591 * nsfns.m (x_set_background_color): Assign return value from
592 ns_index_color to face-background instead of NSColor*.
593 (ns_implicitly_set_icon_type): Fix indentation.
594 Change assignment in for loop to comparison.
595
596 * emacs.c (ns_pool): New variable.
597 (main): Assign ns_pool.
598 (Fkill_emacs): Call ns_release_autorelease_pool.
599
600 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
601 autorelease fdesc, release fdAttrs and tdict.
602 (ns_get_covering_families): Release charset.
603 (ns_findfonts): Release NSFontDescriptor created with new.
604 (ns_uni_to_glyphs): Fix indentation.
605 (setString): Release attrStr before assigning new value.
606
607 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
608
609 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
610 and NS_IMPL_COCOA.
611 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
612 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
613
614 2011-12-18 David Reitter <reitter@cmu.edu>
615
616 * nsterm.m (ns_term_init): Subscribe for notifications
617 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
618 to method trackingNotification in EmacsMenu.
619
620 * nsmenu.m (trackingMenu): New variable.
621 (trackingNotification): New method (from Aquamacs).
622 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
623 from Aquamacs (Bug#7030).
624
625 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
626
627 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
628 (symbol_to_nsstring): Fix indentation.
629 (ns_symbol_to_pb): New function.
630 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
631 (Fns_rotate_cut_buffers_internal): Remove.
632 (Fns_store_selection_internal): Rename from
633 Fns_store_cut_buffer_internal.
634 (ns_get_foreign_selection, Fx_own_selection_internal)
635 (Fx_disown_selection_internal, Fx_selection_exists_p)
636 (Fns_get_selection_internal, Fns_store_selection_internal):
637 Use ns_symbol_to_pb and check if return value is nil.
638 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
639 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
640 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
641 renamed to Sns_store_selection_internal.
642 (ns_handle_selection_request): Move code to Fx_own_selection_internal
643 and remove this function.
644 (ns_handle_selection_clear): Remove, never used.
645 (Fx_own_selection_internal): Move code from ns_handle_selection_request
646 here.
647
648 2011-12-17 Ken Brown <kbrown@cornell.edu>
649
650 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
651 GID is unknown (Bug#10257).
652
653 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
654
655 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
656 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
657 which caused a build failure on GNU/Linux IA-64. This problem was
658 introduced by my 2011-10-07 patch.
659
660 2011-12-15 Juri Linkov <juri@jurta.org>
661
662 * image.c (imagemagick_error): New function. (Bug#10112)
663 (imagemagick_load_image): Comment out `MagickSetResolution' call.
664 Use `imagemagick_error' where ImageMagick functions return
665 `MagickFalse'.
666 (Fimagemagick_types): Add `Fnreverse' to return the list in the
667 proper order.
668
669 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
670
671 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
672 fill background (Bug#8992).
673
674 2011-12-13 Martin Rudalics <rudalics@gmx.at>
675
676 * window.c (Vwindow_combination_resize)
677 (Vwindow_combination_limit): Use t instead of non-nil in
678 doc-strings.
679 (Vrecenter_redisplay): Add first sentence of doc-string on
680 separate line.
681 (Frecenter): Fix doc-string typo.
682
683 2011-12-11 Kenichi Handa <handa@m17n.org>
684
685 * coding.c (Funencodable_char_position): Pay attention to the
686 buffer text relocation (Bug#9389).
687
688 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
689
690 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
691 gtk_init (Bug#10100).
692
693 2011-12-10 Eli Zaretskii <eliz@gnu.org>
694
695 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
696 IT->string is nil. (Bug#10263)
697
698 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
699
700 * nsterm.h (x_free_frame_resources): Declare.
701
702 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
703 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
704
705 * nsterm.h (ns_get_defaults_value): Declare.
706
707 * nsterm.m (ns_default): Call ns_get_defaults_value.
708
709 2011-12-09 Eli Zaretskii <eliz@gnu.org>
710
711 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
712 (Bug#10170)
713
714 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
715
716 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
717 that where the value of an _OBJC_* symbol points to is in the .bss
718 section (Bug#10240).
719
720 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
721
722 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
723 after the loop to call ccl_driver at least once (Bug#8619).
724
725 2011-12-08 Kenichi Handa <handa@m17n.org>
726
727 * ftfont.c (get_adstyle_property): Fix previous change
728 (Bug#10233).
729
730 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
731
732 * w32.c (init_environment): If no_site_lisp, remove site-lisp
733 dirs from the default value of EMACSLOADPATH (bug#10208).
734
735 2011-12-07 Glenn Morris <rgm@gnu.org>
736
737 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
738 installation and source directories as well. (Bug#10208)
739
740 2011-12-06 Chong Yidong <cyd@gnu.org>
741
742 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
743
744 2011-12-06 Glenn Morris <rgm@gnu.org>
745
746 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
747 as an error, not just -1. (Bug#10217)
748
749 2011-12-05 Chong Yidong <cyd@gnu.org>
750
751 * keyboard.c (process_special_events): New function.
752 (swallow_events, Finput_pending_p): Use it (Bug#10195).
753
754 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
755
756 * coding.c (encode_designation_at_bol): Don't use uninitialized
757 local variable (Bug#9318).
758
759 2011-12-05 Kenichi Handa <handa@m17n.org>
760
761 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
762 return Qnil (Bug#8046, Bug#10193).
763
764 2011-12-05 Kenichi Handa <handa@m17n.org>
765
766 * coding.c (encode_designation_at_bol): New args charbuf_end and
767 dst. Return the number of produced bytes. Callers changed.
768 (coding_set_source): Return how many bytes coding->source was
769 relocated.
770 (coding_set_destination): Return how many bytes
771 coding->destination was relocated.
772 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
773 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
774
775 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
776
777 * coding.c (CODING_CHAR_CHARSET_P): New macro.
778 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
779 macro (Bug#9318).
780
781 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
782
783 The following changes are to fix Bug#9318.
784
785 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
786 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
787 (encode_coding_iso_2022, encode_coding_sjis)
788 (encode_coding_big5, encode_coding_charset): Use the above macros.
789
790 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
791
792 * lisp.h (process_quit_flag): Fix external declaration.
793
794 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
795
796 Don't macro-inline non-performance-critical code.
797 * eval.c (process_quit_flag): New function.
798 * lisp.h (QUIT): Use it.
799
800 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
801
802 * nsfns.m (get_geometry_from_preferences): New function.
803 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
804
805 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
806
807 * emacs.c (Qkill_emacs): Define.
808 (syms_of_emacs): Initialize it.
809 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
810 Qquit_flag to `kill-emacs' instead.
811 (quit_throw_to_read_char): Add parameter `from_signal'.
812 All callers changed. Call Fkill_emacs if requested and safe.
813 * lisp.h (QUIT): Call Fkill_emacs if requested.
814
815 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
816
817 * widget.c (update_wm_hints): Return if wmshell is null.
818 (widget_update_wm_size_hints): New function.
819
820 * widget.h (widget_update_wm_size_hints): Declare.
821
822 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
823 widget_update_wm_size_hints (Bug#10104).
824
825 2011-12-03 Eli Zaretskii <eliz@gnu.org>
826
827 * xdisp.c (handle_invisible_prop): If the invisible text ends just
828 before a newline, prepare the bidi iterator for consuming the
829 newline, and keep the current paragraph direction. (Bug#10183)
830 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
831
832 2011-12-02 Juri Linkov <juri@jurta.org>
833
834 * search.c (Fword_search_regexp): New Lisp function created from
835 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
836 (Fword_search_backward, Fword_search_forward)
837 (Fword_search_backward_lax, Fword_search_forward_lax):
838 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
839 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
840
841 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
842
843 * fileio.c (Finsert_file_contents): Move after-change-function call
844 to before the "handled:" label, since all "goto handled" appear in
845 cases where the *-change-functions have already been properly called
846 (bug#10117).
847
848 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
849
850 * keyboard.c (interrupt_signal): Don't call kill-emacs when
851 waiting for input. (Bug#10169)
852
853 2011-11-30 Eli Zaretskii <eliz@gnu.org>
854
855 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
856 verifies glyph row's hash code--we have just reallocated the
857 glyphs, so their contents can be complete garbage. (Bug#10164)
858
859 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
860
861 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
862
863 2011-11-30 Eli Zaretskii <eliz@gnu.org>
864
865 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
866 attributes are tested _before_ calling verify_row_hash, to protect
867 against GCC re-ordering of the tests. (Bug#10164)
868
869 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
870
871 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
872
873 * xterm.c (handle_one_xevent): Only set async_visible and friends
874 if net_wm_state_hidden_seen is non-zero (Bug#10002)
875 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
876 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
877
878 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
879
880 Remove GCPRO-related macros that exist only to avoid shadowing locals.
881 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
882 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
883 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
884 All uses changed to use GCPRO1 etc.
885 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
886 Revert to old implementation (i.e., before 2011-03-11).
887
888 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
889
890 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
891 of scroll runs so as to avoid assigning disabled bogus rows and
892 unnecessary graphics copy operations.
893
894 2011-11-27 Eli Zaretskii <eliz@gnu.org>
895
896 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
897 (snprintf) [_MSC_VER]: Redirect to _snprintf.
898 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
899 (malloc, free, realloc, calloc): Redirect to e_* only when
900 compiling Emacs.
901
902 * lisp.h (GCTYPEBITS): Move before first use.
903 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
904 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
905 this macro definition.
906
907 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
908 _MSC_VER.
909
910 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
911
912 * gtkutil.c (xg_create_frame_widgets):
913 Call gtk_window_set_has_resize_grip (FALSE) if that function is
914 present with Gtk+ 2.0.
915
916 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
917
918 * fileio.c (Finsert_file_contents): Undo previous change; see
919 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
920
921 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
922
923 Rename locals to avoid shadowing.
924 * fileio.c (Finsert_file_contents):
925 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
926 * process.c (wait_reading_process_output):
927 Rename inner 'proc' to 'p' to avoid shadowing.
928 Indent for consistency with usual Emacs style.
929
930 2011-11-25 Eli Zaretskii <eliz@gnu.org>
931
932 * xdisp.c (redisplay_window): If cursor row is not fully visible
933 after recentering, and scroll-conservatively is set to a large
934 number, scroll window by a few more lines to make the cursor fully
935 visible and out of scroll-margin. (Bug#10105)
936 (start_display): Don't move to the next line if the display should
937 start at a newline that is part of a display vector or an overlay
938 string. (Bug#10119)
939
940 2011-11-24 Juri Linkov <juri@jurta.org>
941
942 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
943 after the `MagickPingImage' call. (Bug#10112)
944
945 2011-11-23 Chong Yidong <cyd@gnu.org>
946
947 * window.c (Fcoordinates_in_window_p): Accept only live windows.
948
949 2011-11-23 Martin Rudalics <rudalics@gmx.at>
950
951 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
952 making another buffer current. (Bug#10114)
953
954 2011-11-23 Glenn Morris <rgm@gnu.org>
955
956 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
957
958 2011-11-23 Chong Yidong <cyd@gnu.org>
959
960 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
961 using it (Bug#5984).
962
963 2011-11-22 Eli Zaretskii <eliz@gnu.org>
964
965 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
966 and header-lines, as they don't have one computed for them.
967 (Bug#10098)
968
969 * .gdbinit (prow): Make displayed values more self-explaining.
970 Add row's hash code.
971
972 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
973
974 * process.c (wait_reading_process_output): Fix asynchrounous
975 GnuTLS socket handling on some versions of the GnuTLS library.
976 (wait_reading_process_output): Add comment and URL.
977
978 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
979
980 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
981
982 2011-11-21 Chong Yidong <cyd@gnu.org>
983
984 * window.c (Fnext_window, Fprevious_window): Doc fix.
985
986 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
987
988 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
989
990 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
991
992 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
993
994 2011-11-20 Martin Rudalics <rudalics@gmx.at>
995
996 * window.c (Fset_window_combination_limit): Rename argument
997 STATUS to LIMIT.
998 (Vwindow_combination_limit): Remove "status" from doc-string.
999
1000 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1001
1002 * m/ibms390.h: Remove.
1003 * m/ibms390x.h: Don't include "ibms390.h".
1004
1005 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1006
1007 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1008 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1009
1010 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1011
1012 * casetab.c (Fset_case_table):
1013 * charset.c (Fcharset_after): Fix typos.
1014
1015 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1016
1017 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1018 Otherwise, valgrind does not work on some platforms.
1019 Problem reported by Andreas Schwab in
1020 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1021 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1022 is set, removing the need for VIRT_ADDRESS_VARIES.
1023 (PURE_P): Use a more-efficient implementation that needs just one
1024 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1025 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1026 to 4 (xorl, subq, cmpq, setbe).
1027 * alloc.c (pure): Always extern now, since that's the
1028 VIRT_ADDR_VARIES behavior.
1029 (PURE_POINTER_P): Use a single comparison, not two, for
1030 consistency with the new puresize.h.
1031 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1032 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1033 Remove VIRT_ADDR_VARIES no longer needed.
1034
1035 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1036
1037 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1038 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1039 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1040 behave as if the cursor position were at the window margin.
1041
1042 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1043 and the cursor position is out of bounds, behave as if the cursor
1044 position were at the window margin. (Bug#10075)
1045
1046 2011-11-18 Chong Yidong <cyd@gnu.org>
1047
1048 * window.c (Fwindow_combination_limit): Make first argument
1049 non-optional, since it is meaningless for live windows like the
1050 selected window.
1051
1052 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1053
1054 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1055
1056 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1057
1058 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1059 (graft_intervals_into_buffer): Simplify.
1060
1061 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1062
1063 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1064 hash values of the two rows.
1065 (copy_row_except_pointers): Preserve the used[] arrays and the
1066 hash values of the two rows. (Bug#10035)
1067 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1068
1069 * xdisp.c (row_hash): New function, body extracted from
1070 compute_line_metrics.
1071 (compute_line_metrics): Call row_hash, instead of computing the
1072 hash code inline.
1073
1074 * dispnew.c (verify_row_hash): Call row_hash for computing the
1075 hash code of a row, instead of duplicating code from xdisp.c.
1076
1077 * dispextern.h (row_hash): Add prototype.
1078
1079 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1080
1081 * frame.c (delete_frame): Don't delete the terminal when the last
1082 X frame is closed if emacs is built with GTK toolkit.
1083
1084 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1085
1086 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1087
1088 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1089
1090 * window.c (Vwindow_splits): Rename to
1091 Vwindow_combination_resize. Suggested by Juri Linkov.
1092 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1093 of Vwindow_splits.
1094
1095 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1096
1097 * nsfns.m (Fns_font_name):
1098 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1099
1100 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1101
1102 * window.h (window): Rename slot "nest" to "combination_limit".
1103 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1104 (Fset_window_nest): Rename to Fset_window_combination_limit.
1105 (Vwindow_nest): Rename to Vwindow_combination_limit.
1106 (recombine_windows, make_parent_window, make_window)
1107 (Fsplit_window_internal, saved_window)
1108 (Fset_window_configuration, save_window_save): Rename all
1109 occurrences of window_nest to window_combination_limit.
1110
1111 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1112
1113 * image.c (imagemagick_load_image): Fix typo.
1114
1115 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1116
1117 * xdisp.c (display_line): Move the call to
1118 highlight_trailing_whitespace before the call to
1119 compute_line_metrics, since the latter needs to see the final
1120 faces of all the glyphs to compute ROW's hash value.
1121 Fixes assertion violations in row_equal_p. (Bug#10035)
1122
1123 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1124
1125 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1126 just return (bug#10044).
1127
1128 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1129
1130 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1131 with user-defined heap size. Bump the default size of the temacs
1132 heap to 27MB, to avoid memory warning when running temacs.
1133 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1134
1135 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1136 current_matrix and desired_matrix. (Bug#9990)
1137 (verify_row_hash) [XASSERTS]: New function.
1138 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1139 that the hash value of glyph rows is correct.
1140
1141 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1142
1143 * window.h (window): Remove splits slot.
1144 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1145 (Fdelete_other_windows_internal, make_parent_window)
1146 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1147 (Fset_window_configuration, save_window_save): Don't deal with
1148 split status of windows.
1149 (saved_window): Remove splits slot.
1150 (Vwindow_splits): Rewrite doc-string.
1151
1152 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1153
1154 * xfns.c (unwind_create_frame):
1155 * nsfns.m (unwind_create_frame):
1156 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1157 Vframe_list (Bug#9999).
1158
1159 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1160
1161 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1162
1163 2011-11-11 Kenichi Handa <handa@m17n.org>
1164
1165 * callproc.c (Fcall_process): Set the member dst_multibyte of
1166 process_coding.
1167
1168 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1169
1170 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1171 avoid a crash (bug#9496).
1172
1173 2011-11-09 Chong Yidong <cyd@gnu.org>
1174
1175 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1176 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1177
1178 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1179
1180 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1181
1182 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1183
1184 Avoid some portability problems by eschewing 'extern inline' functions.
1185 The trivial performance wins aren't worth the portability hassles; see
1186 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1187 et seq.
1188 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1189 (window_box_width, window_box_left, window_box_left_offset)
1190 (window_box_right, window_box_right_offset): Undo previous change,
1191 by removing the "extern"s.
1192 * intervals.c (adjust_intervals_for_insertion)
1193 (adjust_intervals_for_deletion): Undo previous change,
1194 making these static again.
1195 (offset_intervals, temp_set_point_both, temp_set_point)
1196 (copy_intervals_to_string): No longer inline.
1197 * xdisp.c (window_text_bottom_y, window_box_width)
1198 (window_box_height, window_box_left_offset)
1199 (window_box_right_offset, window_box_left, window_box_right)
1200 (window_box): No longer inline.
1201
1202 2011-11-08 Chong Yidong <cyd@gnu.org>
1203
1204 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1205 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1206 Signal an error if not a live window.
1207 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1208 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1209
1210 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1211
1212 * lisp.h (syms_of_abbrev): Remove declaration.
1213 Reported by CHENG Gao <chenggao@royau.me>.
1214
1215 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1216
1217 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1218 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1219 of temacs in GUI mode.
1220
1221 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1222
1223 * window.h: Declare delete_all_child_windows instead of
1224 delete_all_subwindows.
1225 * window.c (Fwindow_nest, Fset_window_nest)
1226 (Fset_window_new_total, Fset_window_new_normal)
1227 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1228 (delete_all_subwindows): Rename to delete_all_child_windows.
1229 (Fdelete_other_windows_internal, Fset_window_configuration):
1230 Call delete_all_child_windows instead of delete_all_subwindows.
1231 * frame.c (delete_frame): Call delete_all_child_windows instead
1232 of delete_all_subwindows.
1233
1234 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1235
1236 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1237 This is also needed for porting to any host where GC_MARK_STACK is
1238 not GC_MAKE_GCPROS_NOOPS.
1239 (which_symbols): Use it.
1240
1241 2011-11-07 Kenichi Handa <handa@m17n.org>
1242
1243 * coding.c (coding_set_destination): Check coding->src_pos only
1244 when coding->src_object is a buffer (bug#9910).
1245
1246 * process.c (send_process): Set the member src_multibyte of coding
1247 to 0 (bug#9911) when sending a unibyte text.
1248
1249 * callproc.c (Fcall_process): Set the member src_multibyte of
1250 process_coding to 0 (bug#9912).
1251
1252 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1253
1254 * xmenu.c (cleanup_widget_value_tree): New function.
1255 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1256 calling free_menubar_widget_value_tree directly (Bug#9830).
1257
1258 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1259
1260 Fix some portability problems with 'inline'.
1261 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1262 (window_box_width, window_box_left, window_box_left_offset)
1263 (window_box_right, window_box_right_offset): Declare extern.
1264 Otherwise, these inline functions do not conform to C99 and
1265 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1266 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1267 * intervals.c (adjust_intervals_for_insertion)
1268 (adjust_intervals_for_deletion): Now extern, because otherwise the
1269 extern inline functions 'offset_intervals' couldn't refer to it.
1270 (static_offset_intervals): Remove.
1271 (offset_intervals): Rewrite using the old contents of
1272 static_offset_intervals. The old version didn't conform to C99
1273 because an extern inline function contained a reference to an
1274 identifier with static linkage.
1275
1276 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1277
1278 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1279 GC.
1280
1281 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1282
1283 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1284 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1285 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1286 return Qleft_to_right.
1287
1288 2011-11-06 Chong Yidong <cyd@gnu.org>
1289
1290 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1291 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1292 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1293 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1294 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1295 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1296 (Fwindow_vscroll): Doc fix.
1297 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1298 argument, since it makes no sense to pass a live window and for
1299 consistency with window-child.
1300
1301 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1302
1303 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1304 support MSVC.
1305
1306 2011-11-05 Jason Rumney <jasonr@gnu.org>
1307
1308 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1309 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1310 fonts (Bug#6029).
1311 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1312 bitwise arithmetic preventing use of unicode-sip and non-truetype
1313 opentype fonts.
1314
1315 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1316
1317 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1318 "emacs"-only part.
1319
1320 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1321 initialization code to keep similarity to xfns.c after changes
1322 from 2011-11-05.
1323
1324 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1325
1326 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1327 (unwind_create_frame): New function (Bug#9943).
1328 (Fx_create_frame): Restructure code to be more similar to the one in
1329 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1330 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1331 Move terminal->reference_count++ just before making the frame official
1332 (Bug#9943).
1333
1334 * nsterm.m (x_free_frame_resources): New function.
1335 (x_destroy_window): Move code to x_free_frame_resources.
1336
1337 * xfns.c (unwind_create_frame): Fix comment.
1338 (Fx_create_frame, x_create_tip_frame):
1339 Move terminal->reference_count++ just before making the frame
1340 official. Move initialization of image_cache_refcount and
1341 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1342
1343 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1344
1345 Support MSVC build with newer versions of Visual Studio.
1346 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1347 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1348 nt/gmake.defs.
1349
1350 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1351 which are not supported by MSVC.
1352 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1353 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1354 bitfields.
1355 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1356 types in bitfields.
1357 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1358
1359 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1360
1361 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1362
1363 Support MSVC build with newer versions of Visual Studio.
1364 * w32.c: Don't include w32api.h for MSVC.
1365 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1366
1367 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1368 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1369 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1370 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1371 e_* cousins.
1372 (alloca) [_MSC_VER]: Define to _alloca.
1373
1374 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1375
1376 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1377
1378 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1379
1380 * xdisp.c (note_mouse_highlight): If either of
1381 previous/next-single-property-change returns nil, treat that as
1382 the beginning or the end of the buffer. (Bug#9955)
1383
1384 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1385
1386 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1387 label is not null (Bug#9951).
1388 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1389 may be NULL.
1390
1391 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1392
1393 * window.c (Fwindow_body_size): Mention in the doc string that the
1394 return value is in frame's canonical units. (Bug#9949)
1395
1396 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1397
1398 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1399
1400 * w32fns.c (unwind_create_frame): If needed, free the glyph
1401 matrices of the partially constructed frame. (Bug#9943)
1402 * xfns.c (unwind_create_frame): Likewise.
1403
1404 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1405
1406 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1407 Don't stop backward scan on the continuation glyph, even though
1408 its CHARPOS is positive.
1409 (mouse_face_from_buffer_pos, note_mouse_highlight):
1410 Rename cover_string to disp_string.
1411
1412 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1413
1414 * window.c (temp_output_buffer_show): Don't use
1415 Vtemp_buffer_show_specifiers.
1416 (Vtemp_buffer_show_specifiers): Remove unused variable.
1417
1418 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1419
1420 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1421 past the beginning of the current glyph matrix.
1422
1423 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1424
1425 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1426 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1427 HAVE_GTK3 (Bug#9869).
1428
1429 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1430 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1431
1432 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1433
1434 * xterm.c: Declare x_handle_net_wm_state to return int.
1435 (handle_one_xevent): Check if we are iconified but don't have
1436 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1437 (get_current_wm_state): Return non-zero if not hidden,
1438 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1439 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1440 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1441 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1442
1443 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1444
1445 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1446 so that this new function doesn't get optimized away by a
1447 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1448
1449 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1450
1451 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1452
1453 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1454
1455 Fix the `xbytecode' command.
1456 * .gdbinit (xprintbytestr): New command.
1457 (xwhichsymbols): Rename from `which'; all callers changed.
1458 (xbytecode): Print the byte-code string as well.
1459
1460 2011-10-29 Kim Storm <storm@cua.dk>
1461
1462 * alloc.c (which_symbols): New function.
1463
1464 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1465
1466 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1467 line. (Bug#9903)
1468
1469 2011-10-29 Glenn Morris <rgm@gnu.org>
1470
1471 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1472 Not clear what it was for, and it causes various bugs. (Bug#9839)
1473
1474 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1475
1476 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1477 possible random value that matches one of those tested as
1478 condition to clear the mouse face.
1479
1480 2011-10-28 Chong Yidong <cyd@gnu.org>
1481
1482 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1483
1484 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1485
1486 * window.c (make_window): Initialize phys_cursor_on_p.
1487
1488 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1489
1490 * lisp.h (struct Lisp_Symbol): Update comments.
1491
1492 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1493
1494 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1495
1496 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1497
1498 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1499 <oslsachem@gmail.com> for helping to debug this.
1500
1501 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1502 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1503 (g_b_init_get_glyph_outline_w): New static variables.
1504 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1505 (GetGlyphOutlineW_Proc): New typedefs.
1506 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1507 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1508 New functions.
1509 (w32font_open_internal, compute_metrics):
1510 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1511 instead of calling the "wide" APIs directly.
1512
1513 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1514
1515 * w32.h (syms_of_w32font): Add prototype.
1516
1517 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1518
1519 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1520 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1521 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1522 (Fmove_to_window_line): Doc fix.
1523
1524 2011-10-27 Chong Yidong <cyd@gnu.org>
1525
1526 * process.c (make_process): Set gnutls_state to NULL.
1527
1528 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1529 non-NULL, regardless of GNUTLS_INITSTAGE.
1530 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1531 an error. Set process slots as soon as we allocate them.
1532
1533 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1534
1535 2011-10-27 Chong Yidong <cyd@gnu.org>
1536
1537 * gnutls.c (emacs_gnutls_deinit): New function.
1538 Deallocate credentials structures as well as calling gnutls_deinit.
1539 (Fgnutls_deinit, Fgnutls_boot): Use it.
1540
1541 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1542 (deactivate_process): Call emacs_gnutls_deinit.
1543
1544 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1545
1546 * image.c (x_create_x_image_and_pixmap):
1547 * w32.c (sys_rename, w32_delayed_load):
1548 * w32font.c (fill_in_logfont):
1549 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1550
1551 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1552
1553 * w32fns.c (w32_default_color_map): New function,
1554 extracted from Fw32_default_color_map.
1555 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1556
1557 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1558
1559 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1560
1561 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1562
1563 * keyboard.c (test_undefined): New function (bug#9751).
1564 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1565
1566 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1567
1568 * sysdep.c (init_sys_modes): Fix the check for the controlling
1569 terminal (Bug#6649).
1570
1571 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1572
1573 * dispextern.h (struct bidi_it): New member next_en_type.
1574
1575 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1576 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1577 current character, check also for next_en_type being WEAK_EN.
1578 (bidi_resolve_weak): Don't enter the expensive loop if the current
1579 position is before next_en_pos. Record the bidi type of the first
1580 non-ET, non-BN character we find, in addition to its position.
1581 (bidi_level_of_next_char): Invalidate next_en_type when
1582 next_en_pos is over-stepped.
1583
1584 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1585
1586 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1587 * editfns.c: Rewrite current-time-zone so that it invokes
1588 the equivalent of (format-time-string "%Z") to get the time zone name.
1589 This fixes a bug when the time zone name contains characters that
1590 need converting from the system time locale to Emacs internal format.
1591 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1592 that patch fixed format-time-string to do the conversion, but
1593 I forgot to fix current-time-zone.
1594 (format_time_string): New function, containing most of
1595 what Fformat_time_string used to contain.
1596 (Fformat_time_string): Rewrite in terms of format_time_string.
1597 This doesn't change this function's behavior.
1598 (current-time-zone): Rewrite to use format_time_string.
1599 This fixes the bug reported by Michael Schierl in
1600 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1601 Jason Rumney's 2007-06-07 change worked around this bug, but
1602 didn't fix it.
1603 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1604
1605 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1606
1607 * xdisp.c (start_display): If the character at POS is displayed
1608 via a display vector, reset IT->current.dpvec_index to zero.
1609 (try_window_reusing_current_matrix): If a line ends in a display
1610 vector or the next line starts in a display vector, continue
1611 redrawing the window even though the character position of
1612 start_row was reached.
1613 (Bug#9771, part 2)
1614
1615 2011-10-18 Chong Yidong <cyd@gnu.org>
1616
1617 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1618 with nobreak-char-display too.
1619
1620 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1621
1622 Fix part 3 of bug#9771.
1623 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1624 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1625 non-neutral characters if the current character is a paragraph
1626 separator (a.k.a. Newline). This avoids running the same
1627 expensive loop twice, once when we consume the preceding newline
1628 and the other time when the line actually needs to be displayed.
1629 Avoid the loop when we see neutrals on the base embedding level
1630 following a character whose directionality is the same as the
1631 paragraph's. This avoids running the expensive loop when a line
1632 ends in a long sequence of neutrals, like control characters.
1633 Add assertion against STRONG_AL type. Slightly rearrange code
1634 that determines the type of a neutral given the first non-neutral
1635 that follows it.
1636 (bidi_level_of_next_char): Set next_en_pos to zero when
1637 invalidating its info.
1638
1639 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1640
1641 * xdisp.c (push_display_prop): Determine whether to record string
1642 or buffer position by IT->string, not by IT->method. Allow
1643 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1644 (move_it_vertically_backward): Don't look for character position
1645 immediately after the newline when in a continuation line.
1646 (Bug#9771, part 1)
1647
1648 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1649
1650 * window.c (coordinates_in_window): Rewrite and delabelize
1651 vertical border check. (Bug#5357) (Bug#9618)
1652
1653 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1654
1655 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1656 errors in XSetWindowBorder (bug#9310).
1657
1658 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1659
1660 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1661 avoid crash when xmalloc overrun checking is enabled.
1662
1663 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1664
1665 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1666 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1667 cursor motion with <left> and <right> arrow keys.
1668
1669 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1670 some callers set that themselves.
1671
1672 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1673
1674 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1675 display string and the previous row comes from the same string and
1676 is empty. (Bug#9739) (Bug#9738)
1677
1678 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1679
1680 * doc.c (get_doc_string): Encode file name (bug#9735).
1681
1682 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1683
1684 * bidi.c (bidi_level_of_next_char):
1685 * xdisp.c (get_visually_first_element): Remove old incorrect
1686 comments regarding the Unicode Line Separator character.
1687
1688 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1689
1690 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1691
1692 * alloc.c (Fgc_status): Do not access beyond zombies array
1693 boundary if nzombies > MAX_ZOMBIES.
1694 * alloc.c (dump_zombies): Add missing format specifier.
1695
1696 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1697
1698 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1699 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1700
1701 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1702 Some packages use them to denote characters with modifiers.
1703
1704 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1705
1706 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1707 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1708 matching a pp-number. Rename parameter var to var1.
1709
1710 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1711
1712 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1713
1714 2011-10-08 Glenn Morris <rgm@gnu.org>
1715
1716 * callint.c (Fcall_interactively): Give a more explicit error for the
1717 'c' case with a non-character input. (Bug#8479)
1718
1719 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1720
1721 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1722 lines.
1723 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1724 lines that are hscrolled on the left.
1725
1726 * dispnew.c (buffer_posn_from_coords): Account for a possible
1727 presence of header-line. (Bug#4426)
1728
1729 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1730
1731 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1732 Don't advertise functionality which we discourage or doesn't work.
1733
1734 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1735
1736 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1737 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1738 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1739 this makes Emacs dump core during garbage collection on rare
1740 occasions. sizeof is obviously inferior to offsetof here, so
1741 stick with offsetof.
1742 (GC_POINTER_ALIGNMENT): New macro.
1743 (mark_memory): Omit 3rd (offset) arg; caller changed.
1744 Don't assume EMACS_INT alignment is the same as pointer alignment.
1745
1746 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1747
1748 * keyboard.c (read_key_sequence_remapped): New var.
1749 (read_key_sequence): Compute remapping in the right buffer.
1750 (command_loop_1): Use read_key_sequence's remapping directly.
1751
1752 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1753
1754 * dired.c (file_name_completion): Don't expand file name.
1755 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1756 before checking file name handler.
1757
1758 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1759 they've been requested explicitly (bug#9591).
1760
1761 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1762
1763 * keymap.c (Fsingle_key_description): Use make_specified_string
1764 instead of build_string to build string from push_key_description.
1765 (Bug#5193)
1766
1767 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1768
1769 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1770 This fixes a Y2038 bug on 64-bit hosts.
1771 * buffer.c (reset_buffer):
1772 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1773 (Fclear_buffer_auto_save_failure):
1774 Use 0, not -1, to represent an unset failure time, since time_t
1775 might not be signed.
1776
1777 Remove dependency on glibc malloc internals.
1778 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1779 Move back here from lisp.h, but with their new implementations.
1780 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1781 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1782 * charset.c (charset_table_init): New static var.
1783 (syms_of_charset): Use it instead of xmalloc. This removes a
1784 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1785 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1786 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1787 Move back to alloc.c.
1788 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1789 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1790
1791 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1792
1793 * nsterm.m (windowDidResize): Call x_set_window_size only when
1794 ns_in_resize is true. Otherwise set pixelwidth/height and
1795 call change_frame_size (Bug#9628).
1796
1797 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1798
1799 Port --enable-checking=all to Fedora 14 x86-64.
1800 * charset.c (syms_of_charset): Also account for glibc malloc's
1801 internal overhead when calculating the initial malloc maximum.
1802
1803 Port --enable-checking=all to Fedora 14 x86.
1804 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1805 Move to lisp.h.
1806 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1807 (overrun_check_realloc, overrun_check_free):
1808 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1809 That way, xmalloc returns a properly-aligned pointer even if
1810 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1811 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1812 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1813 into account when calculating the initial malloc maximum.
1814 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1815 Move here from alloc.c, so that charset.c can use it too.
1816 Properly align; the old code wasn't right for common 32-bit hosts
1817 when configured with --enable-checking=all.
1818 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1819 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1820
1821 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1822
1823 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1824 use EDOM.
1825
1826 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1827
1828 * xdisp.c (compute_display_string_end): If there's no display
1829 string at CHARPOS, return -1.
1830
1831 * bidi.c (bidi_fetch_char): When compute_display_string_end
1832 returns a negative value, treat the character as a normal
1833 character not covered by a display string. (Bug#9624)
1834
1835 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1836
1837 * lread.c (Fread_from_string): Fix typo in docstring.
1838
1839 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1840
1841 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1842 newline, reseat the iterator instead of bidi-iterating there one
1843 character at a time. (Bug#9610)
1844 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1845 TO_CHARPOS if the bidi iterator is at base embedding level.
1846
1847 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1848
1849 * lread.c (readevalloop): Use correct code for NBSP.
1850 (read1): Likewise. (Bug#9608)
1851
1852 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1853
1854 * dbusbind.c (Fdbus_register_signal): When service is not
1855 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1856
1857 2011-09-25 Glenn Morris <rgm@gnu.org>
1858
1859 * buffer.c (truncate-lines): Doc fix.
1860
1861 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1862
1863 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1864 (Fset_window_next_buffers): Doc fix.
1865
1866 2011-09-24 Glenn Morris <rgm@gnu.org>
1867
1868 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1869
1870 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1871
1872 Fix minor problems found by static checking.
1873 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1874 * indent.c (Fvertical_motion): Fix == vs = typo.
1875
1876 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1877
1878 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1879 Default value is now t. Doc fix.
1880
1881 * indent.c (Fvertical_motion): Compute and apply the overshoot
1882 logic when moving up, not only when moving down. Fix the
1883 confusing name and values of the it_overshoot_expected variable;
1884 logic changes accordingly. (Bug#9254) (Bug#9549)
1885
1886 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1887 CHARPOS is covered by a display string which includes newlines.
1888 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1889 is covered by a display string with embedded newlines.
1890
1891 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1892
1893 * dbusbind.c (Fdbus_register_signal): Add match rule to
1894 Vdbus_registered_objects_table. (Bug#9581)
1895 (Fdbus_register_method, Vdbus_registered_objects_table):
1896 Fix docstring.
1897
1898 2011-09-24 Jim Meyering <meyering@redhat.com>
1899
1900 do not ignore write error for any output size
1901 The previous change was incomplete.
1902 While it makes emacs --batch detect the vast majority of stdout
1903 write failures, errors were still ignored whenever the output size is
1904 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1905 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1906 && echo FAIL: ignored write error
1907 FAIL: ignored write error
1908 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1909 && echo FAIL: ignored write error
1910 FAIL: ignored write error
1911 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1912
1913 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1914
1915 * emacs.c (Fkill_emacs): In noninteractive mode exit
1916 non-successfully if a write error occurred on stdout. (Bug#9574)
1917
1918 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1919
1920 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1921 the xassert test.
1922
1923 * dispextern.h (struct it): Update the comment documenting what
1924 can it->OBJECT be.
1925
1926 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1927
1928 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1929 a display string, extend search for cursor position to end of row.
1930 (find_row_edges): If the row ends in a newline from a display
1931 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1932 Handle the case of a display string with multiple newlines.
1933 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1934 non-empty line. Fixes confusing cursor motion with arrow keys at
1935 the beginning of a line that starts with whitespace.
1936
1937 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1938
1939 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1940 (bug#9493).
1941
1942 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1943
1944 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1945 boolean (Bug#9154).
1946
1947 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1948
1949 * xdisp.c (display_line): Record maximum and minimum buffer
1950 positions even if no glyphs were produced (e.g., by a zero-width
1951 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1952 buffer positions that will be removed from the glyph row because
1953 they don't fit.
1954 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1955 column is beyond frame width: don't subtract 1 "pixel" when
1956 computing width of the stretch.
1957 (reseat_at_next_visible_line_start): Undo the change made on
1958 2011-09-17 that saved paragraph information and restored it after
1959 the call to `reseat'. (Bug#9545)
1960
1961 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1962
1963 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1964 and turn window cursor on if cleared (Bug#9415).
1965
1966 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1967
1968 * search.c (boyer_moore): Take unibyte characters from pattern
1969 literally. (Bug#9458)
1970
1971 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1972
1973 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1974
1975 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1976
1977 Fix minor problem found by static checking.
1978 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1979 initialized, to pacify gcc -Wuninitialized.
1980
1981 * fileio.c: Report proper errno when syscall falls.
1982 (Finsert_file_contents): Save and restore errno,
1983 so that report_file_error outputs the correct diagnostic.
1984 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1985
1986 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1987
1988 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1989
1990 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1991
1992 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1993 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1994
1995 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1996
1997 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1998 about the current paragraph and restore it after the call to reseat.
1999
2000 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2001 (bidi_find_paragraph_start): Search back for paragraph beginning
2002 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2003 (bidi_move_to_visually_next): Only trigger paragraph-related
2004 computations when the last character is a newline or at EOB, not
2005 just any NEUTRAL_B. (Bug#9470)
2006
2007 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2008 truncated lines if point is covered by a display string. (Bug#9524)
2009
2010 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2011
2012 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2013 (cons_to_x_long): New function.
2014 (lisp_data_to_selection_data): Use it. Correct the test for
2015 short-versus-long data; it was negated. Break out of vector
2016 loop, for efficiency, when a long datum is discovered.
2017
2018 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2019
2020 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2021
2022 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2023
2024 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2025 GCC PR/17406) by declaring this function with external scope.
2026
2027 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2028
2029 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2030 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2031
2032 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2033
2034 * editfns.c (Fformat): Correctly handle text properties on "%%".
2035
2036 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2037
2038 * xterm.c (x_draw_composite_glyph_string_foreground):
2039 * w32term.c (x_draw_composite_glyph_string_foreground):
2040 * term.c (encode_terminal_code):
2041 * composite.c (composition_update_it, get_composition_id):
2042 * xdisp.c (get_next_display_element)
2043 (fill_composite_glyph_string): Add comments about special meaning
2044 of TAB characters in a composition.
2045
2046 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2047
2048 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2049 This occurs when processing a multibyte format.
2050 Problem reported by Wolfgang Jenker.
2051
2052 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2053
2054 * xdisp.c (try_cursor_movement): Only check for exact match if
2055 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2056
2057 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2058
2059 Remove unused external symbols.
2060 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2061 * xdisp.c (calc_pixel_width_or_height): Now static.
2062 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2063 * indent.c (check_display_width):
2064 * w32term.c: Fix comment to match code.
2065 * xterm.c, xterm.h (x_catching_errors): Remove.
2066
2067 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2068
2069 * xselect.c: Use signed conversions more consistently (Bug#9498).
2070 (selection_data_to_lisp_data): Assume incoming selection data are
2071 signed integers, not unsigned. This is to be consistent with
2072 outgoing selection data, which was modified to use signed integers
2073 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2074 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2075 expects long, not unsigned long.
2076
2077 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2078
2079 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2080 computation of loop end. Reported by Johan Bockgård
2081 <bojohan@gnu.org>.
2082
2083 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2084
2085 * frame.c (Fother_visible_frames_p): Function deleted.
2086
2087 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2088
2089 * indent.c (compute_motion): Process display vector front to back
2090 rather than the other way around. (Bug#2496)
2091
2092 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2093
2094 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2095
2096 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2097
2098 * minibuf.c (Fread_from_minibuffer): Doc fix.
2099
2100 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2101
2102 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2103 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2104
2105 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2106
2107 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2108 value for non-existent files.
2109
2110 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2111
2112 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2113 set its "size" to -1. This will set the modtime_size field of
2114 the corresponding buffer to -1, which is what
2115 verify-visited-file-modtime expects for files that do not exist.
2116 (Bug#9139)
2117
2118 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2119
2120 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2121 here ...
2122 * lisp.h: ... from here. push_key_description is no longer
2123 defined in keyboard.c, so its declaration should not be in
2124 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2125 logically belongs with push_key_description.
2126
2127 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2128
2129 * buffer.h: Include <sys/types.h> instead of <time.h>.
2130 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2131 Problem reported by Herbert J. Skuhra.
2132
2133 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2134
2135 * xml.c (parse_region): Make the parsing work for
2136 non-comment-starting XML files again (bug#9144).
2137
2138 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2139
2140 * image.c (gif_load): Fix calculation of bottom and right corner.
2141 (Bug#9468)
2142
2143 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2144
2145 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2146 redisplay in small windows.
2147
2148 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2149
2150 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2151
2152 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2153
2154 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2155 Operate on live windows only.
2156
2157 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2158
2159 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2160
2161 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2162
2163 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2164 only under bidi iteration.
2165
2166 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2167
2168 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2169
2170 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2171
2172 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2173 Without this fix, the command to link temacs failed due to an
2174 undefined symbol __builtin_isnan. This is because
2175 /usr/include/iso/math_c99.h #defines isnan(x) to
2176 __builtin_isnan(x), but the bundled gcc, which identifies itself
2177 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2178 a __builtin_isnan.
2179 * floatfns.c (isnan): #undef, and then #define to a clone of
2180 what's in data.c.
2181 (Fisnan): Always define, since it's always available now.
2182 (syms_of_floatfns): Always define isnan at the Lisp level.
2183
2184 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2185
2186 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2187
2188 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2189
2190 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2191 The previous code assumed that file offsets (off_t values) fit in
2192 EMACS_INT variables, which is not true on typical 32-bit hosts.
2193 The code messed up by falsely reporting buffer overflow in cases
2194 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2195 when "big" contains more than 2**29 bytes, even though this
2196 inserts just one byte and does not overflow the buffer.
2197 (Finsert_file_contents): Store file offsets as off_t
2198 values, not as EMACS_INT values. Check for overflow when
2199 converting between EMACS_INT and off_t. When checking for
2200 buffer overflow or for overlap, take the offsets into account.
2201 Don't use EMACS_INT for small values where int suffices.
2202 When checking for overlap, fix a typo: ZV was used where
2203 ZV_BYTE was intended.
2204 (Fwrite_region): Don't assume off_t fits into 'long'.
2205 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2206
2207 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2208
2209 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2210
2211 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2212
2213 sprintf-related integer and memory overflow issues (Bug#9412).
2214
2215 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2216 (esprintf, exprintf, evxprintf): New functions.
2217 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2218 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2219 (modify_event_symbol): Do not assume that the length of
2220 name_alist_or_stem is safe to alloca and fits in int.
2221 (Fexecute_extended_command): Likewise for function name and binding.
2222 (Frecursion_depth): Wrap around reliably on integer overflow.
2223 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2224 since some callers pass EMACS_INT values.
2225 (Fsingle_key_description): Don't crash if symbol name contains more
2226 than MAX_ALLOCA bytes.
2227 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2228 (get_minibuffer): Arg is now EMACS_INT, not int.
2229 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2230 (esprintf, exprintf, evxprintf): New decls.
2231 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2232
2233 * dbusbind.c (signature_cat): New function.
2234 (xd_signature, Fdbus_register_signal):
2235 Do not overrun buffer; instead, report string overflow.
2236
2237 * dispnew.c (add_window_display_history): Don't overrun buffer.
2238 Truncate instead; this is OK since it's just a log.
2239
2240 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2241 even if the time zone offset is outlandishly large.
2242 Don't mishandle offset == INT_MIN.
2243
2244 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2245 when creating daemon; the previous buffer-overflow check was incorrect.
2246
2247 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2248 which has the guts of the old verror function.
2249
2250 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2251 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2252
2253 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2254 (font_unparse_xlfd): Don't blindly alloca long strings.
2255 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2256 fits in int, when using sprintf. Use single snprintf to count
2257 length of string rather than counting it via multiple sprintfs;
2258 that's simpler and more reliable.
2259 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2260 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2261 sprintf, in case result does not fit in int.
2262
2263 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2264 (fontset_from_font): Print it.
2265
2266 * frame.c (tty_frame_count): Now printmax_t, not int.
2267 (make_terminal_frame, set_term_frame_name): Print it.
2268 (x_report_frame_params): In X, window IDs are unsigned long,
2269 not signed long, so print them as unsigned.
2270 (validate_x_resource_name): Check for implausibly long names,
2271 and don't assume name length fits in 'int'.
2272 (x_get_resource_string): Don't blindly alloca invocation name;
2273 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2274 not fit in int.
2275
2276 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2277 (xg_check_special_colors, xg_set_geometry):
2278 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2279
2280 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2281 Use esprintf, not sprintf, in case result does not fit in int.
2282
2283 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2284 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2285 it as a large positive number.
2286 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2287 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2288
2289 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2290 in case result does not fit in int.
2291
2292 * print.c (float_to_string): Detect width overflow more reliably.
2293 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2294 buffer overrun. Don't assume list length fits in 'int'. Treat
2295 print length of 0 as 0, not as infinity; to be consistent with other
2296 uses of print length in this function. Don't overflow print length
2297 index. Don't assume hash table size fits in 'long', or that
2298 vectorlike size fits in 'unsigned long'.
2299
2300 * process.c (make_process): Use printmax_t, not int, to format
2301 process-name gensyms.
2302
2303 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2304
2305 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2306 to avoid potential buffer overrun.
2307
2308 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2309 if X resource line is longer than 512 bytes.
2310
2311 * xfns.c (x_window): Make sprintf buffer a bit bigger
2312 to avoid potential buffer overrun.
2313
2314 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2315
2316 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2317
2318 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2319
2320 Integer overflow fixes for scrolling, etc.
2321 Without these, Emacs silently mishandles large integers sometimes.
2322 For example, "C-u 4294967297 M-x recenter" was treated as if
2323 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2324
2325 * xdisp.c (try_window_id): Check Emacs fixnum range before
2326 converting to 'int'.
2327
2328 * window.c (window_scroll_line_based, Frecenter):
2329 Check that an Emacs fixnum is in range before assigning it to 'int'.
2330 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2331 values converted from Emacs fixnums.
2332 (Frecenter): Don't wrap around a line count if it is out of 'int'
2333 range; instead, treat it as an extreme value.
2334 (Fset_window_configuration, compare_window_configurations):
2335 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2336
2337 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2338 that can exceed INT_MAX. Check that EMACS_INT value is in range
2339 before assigning it to the (possibly-narrower) index.
2340 (match_limit): Don't assume that a fixnum can fit in 'int'.
2341
2342 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2343 exceed INT_MAX.
2344
2345 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2346 (Fvertical_motion): Don't wrap around LINES values that don't fit
2347 in 'int'. Instead, treat them as extreme values. This is good
2348 enough for windows, which can't have more than INT_MAX lines anyway.
2349
2350 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2351
2352 * Require libxml/parser.h to avoid compilation warning.
2353
2354 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2355
2356 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2357 since this reportedly can destroy thread storage.
2358
2359 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2360
2361 * syntax.c (find_defun_start): Update all cache variables if
2362 exiting early (Bug#9401).
2363
2364 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2365
2366 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2367
2368 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2369 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2370 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2371
2372 * term.c (tty_append_glyph): New function.
2373 (produce_stretch_glyph): Static function and its prototype deleted.
2374
2375 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2376 Add prototypes.
2377
2378 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2379
2380 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2381 when checking :margin (Bug#9390).
2382 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2383 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2384 so that the name doesn't mislead. All uses changed.
2385
2386 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2387
2388 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2389 set_tty_hooks.
2390
2391 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2392
2393 * xdisp.c (move_it_to): Don't bail out early when reaching
2394 position beyond to_charpos, if we are scanning backwards.
2395 (move_it_vertically_backward): When DY == 0, make sure we get to
2396 the first character in the line after the newline.
2397
2398 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2399
2400 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2401 (ccl_driver): Do not generate an out-of-range pointer.
2402 (Fccl_execute_on_string): Remove unnecessary check for
2403 integer overflow, noted by Stefan Monnier in
2404 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2405 Remove a FIXME that didn't need fixing.
2406 Simplify the newly-introduced buffer reallocation code.
2407
2408 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2409
2410 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2411
2412 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2413
2414 Integer and memory overflow issues (Bug#9196).
2415
2416 * doc.c (get_doc_string): Rework so that
2417 get_doc_string_buffer_size is the actual buffer size, rather than
2418 being 1 less than the actual buffer size; this makes xpalloc more
2419 convenient.
2420
2421 * image.c (x_allocate_bitmap_record, cache_image):
2422 * xselect.c (Fx_register_dnd_atom):
2423 Simplify previous changes by using xpalloc.
2424
2425 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2426 since either will do and ptrdiff_t is convenient with xpalloc.
2427
2428 * charset.c (charset_table_size)
2429 (struct charset_sort_data.priority): Now ptrdiff_t.
2430 (charset_compare): Don't overflow if priorities differ greatly.
2431 (Fsort_charsets): Don't assume list length fits in int.
2432 Check for size-calculation overflow when allocating sort data.
2433 (syms_of_charset): Allocate an initial charset table that is
2434 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2435
2436 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2437
2438 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2439 The actual value is always <= INT_MAX, and leaving it unsigned made
2440 overflow checking harder.
2441
2442 * dispextern.h (struct glyph_matrix.rows_allocated)
2443 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2444 with xpalloc. The values are still always <= INT_MAX.
2445
2446 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2447
2448 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2449 (SAFE_NALLOCA): New macro.
2450
2451 * region-cache.c (struct boundary.pos, find_cache_boundary)
2452 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2453 (set_cache_region, invalidate_region_cache)
2454 (revalidate_region_cache, know_region_cache, region_cache_forward)
2455 (region_cache_backward, pp_cache):
2456 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2457 so that ptrdiff_t * can be passed to xpalloc.
2458 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2459 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2460 (pp_cache): Don't assume cache_len fits in int.
2461 * region-cache.h: Adjust extern decls to match.
2462
2463 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2464 EMACS_INT, since either will do, for xpalloc.
2465
2466 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2467 (xnmalloc, xnrealloc, xpalloc): New functions.
2468
2469 * bidi.c (bidi_shelve_header_size): New constant.
2470 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2471 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2472
2473 * bidi.c (bidi_cache_shrink):
2474 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2475 (overlay_strings):
2476 Don't update size of array until after memory allocation succeeds,
2477 because xmalloc/xrealloc may not return.
2478 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2479 now that we have proper integer overflow checking.
2480 (record_overlay_string, overlay_strings): Catch overflows when
2481 calculating size of overlay_str_buf.
2482
2483 * callproc.c (Fcall_process): Check for size overflow when
2484 calculating size of args2.
2485 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2486 Normally we prefer signed values, but sticking with ptrdiff_t would
2487 require adding more-complicated checks.
2488
2489 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2490 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2491 Redo buffer-overflow calculations to avoid integer overflow.
2492 Add a FIXME comment where memory seems to be over-allocated.
2493
2494 * character.c (Fstring): Check for size-calculation overflow.
2495
2496 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2497 unnecessary integer overflow. Check for size overflow.
2498 (encode_coding_object): Don't update size until xmalloc succeeds.
2499
2500 * composite.c (get_composition_id): Check for overflow in glyph
2501 length calculations.
2502
2503 Integer and memory overflow fixes for display code.
2504 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2505 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2506 (scrolling_window): Check for overflow in size calculations.
2507 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2508 Don't assume glyph table len fits in int.
2509 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2510 (row_table_size): Now ptrdiff_t, not int.
2511 (scrolling_window): Avoid overflow in size calculations.
2512 Don't update size until allocation succeeds.
2513 * fns.c (concat): Check for overflow in size calculations.
2514 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2515 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2516 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2517
2518 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2519 (get_doc_string): Check for size calculation overflow.
2520 Don't update size until allocation succeeds.
2521 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2522 EMACS_INT, where ptrdiff_t will do.
2523 (Fsubstitute_command_keys): Check for string overflow.
2524
2525 * editfns.c (set_time_zone_rule): Don't assume environment length
2526 fits in int.
2527 (message_length): Now ptrdiff_t, not int.
2528 (Fmessage_box): Don't update size until allocation succeeds.
2529 Don't assume message length fits in int.
2530 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2531
2532 * emacs.c (main): Do not reallocate argv, since there is a null at
2533 the end that can be overwritten, and this way there's no need to
2534 worry about size-calculation overflow.
2535 (sort_args): Check for size-calculation overflow.
2536
2537 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2538 alloc succeeds.
2539 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2540
2541 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2542 (x_set_scroll_bar_width, x_figure_window_size):
2543 Check for integer overflow.
2544 (x_set_alpha): Do not assume XINT fits in int.
2545
2546 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2547 This is for the members text_lines, text_cols, total_lines, total_cols,
2548 where the system imposes an 'int' limit.
2549
2550 * fringe.c (Fdefine_fringe_bitmap):
2551 Don't update size until alloc works.
2552
2553 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2554 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2555
2556 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2557 Check for size-calculation overflow.
2558 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2559 do, as we prefer signed integers.
2560 (id_to_widget.max_size, id_to_widget.used)
2561 (xg_store_widget_in_map, xg_remove_widget_from_map)
2562 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2563 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2564 Use and return ptrdiff_t, not int.
2565 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2566 * gtkutil.h: Change prototypes to match the above.
2567
2568 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2569 are duplicate now that they've been promoted to lisp.h.
2570 (x_allocate_bitmap_record, x_alloc_image_color)
2571 (make_image_cache, cache_image, xpm_load):
2572 Don't update size until alloc is done.
2573 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2574 (x_detect_edges):
2575 Check for size calculation overflow.
2576 (ct_colors_allocated_max): New constant.
2577 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2578 overflow.
2579
2580 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2581 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2582 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2583 Use ptrdiff_t, not int, to count maps.
2584 (read_char_minibuf_menu_prompt): Check for overflow in size
2585 calculations. Don't update size until allocation succeeds.
2586 Redo calculations to avoid overflow.
2587 * keyboard.h: Change prototypes to match the above.
2588
2589 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2590 to count maps.
2591 (current_minor_maps): Check for size calculation overflow.
2592 * keymap.h: Change prototypes to match the above.
2593
2594 * lread.c (read1, init_obarray): Don't update size until alloc done.
2595
2596 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2597 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2598
2599 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2600 Now ptrdiff_t, not int.
2601 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2602 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2603
2604 * process.c (Fnetwork_interface_list): Check for overflow
2605 in size calculation.
2606
2607 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2608
2609 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2610 overflow. Don't bother calling xmalloc when xrealloc will do.
2611
2612 * search.c (Freplace_match): Check for size calculation overflow.
2613 (Fset_match_data): Don't assume list lengths fit in 'int'.
2614
2615 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2616 for command line length. Do not attempt to address one before the
2617 beginning of an array, as that's not portable.
2618
2619 * term.c (max_frame_lines): Remove; unused.
2620 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2621 not int.
2622 (encode_terminal_code, calculate_costs): Check for size
2623 calculation overflow.
2624 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2625 table lengths and related sizes. Don't update size until alloc
2626 done. Redo calculations to avoid overflow.
2627 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2628
2629 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2630 subtracting pointers.
2631 (gobble_line): Check for overflow more carefully. Don't update size
2632 until alloc done.
2633
2634 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2635 Don't update size until alloc done.
2636 Redo size calculations to avoid overflow.
2637 Check for size calculation overflow.
2638 (main) [DEBUG]: Fix typo in invoking tparam1.
2639
2640 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2641 Use ptrdiff_t, not int, for sizes.
2642 (store_mode_line_noprop_char): Don't update size until alloc done.
2643
2644 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2645 Use ptrdiff_t, not int, for sizes.
2646 (Finternal_make_lisp_face, cache_face):
2647 Check for size calculation overflow.
2648 (cache_face): Treat size calculation overflows as if they were
2649 memory exhaustion (the usual treatment), rather than aborting.
2650
2651 * xfns.c (x_encode_text, x_set_name_internal)
2652 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2653 sizes, since they can exceed INT_MAX in size. Check for size
2654 calculation overflow.
2655
2656 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2657 (xg_select): Check for size calculation overflow.
2658 Don't update size until alloc done.
2659
2660 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2661 as sprintf is limited to int lengths.
2662
2663 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2664 (X_LONG_MIN): New macros.
2665 Use them to make the following changes clearer.
2666 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2667 This change doesn't affect the value now, but it may help remind
2668 future maintainers not to raise the value too much later.
2669 (SELECTION_QUANTUM): Remove, replacing with ...
2670 (selection_quantum): ... new function, which avoids overflow.
2671 All uses changed.
2672 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2673 assumption that selection length fits in 'int'.
2674 (x_reply_selection_request, x_handle_selection_request)
2675 (x_get_window_property, receive_incremental_selection)
2676 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2677 (lisp_data_to_selection_data, clean_local_selection_data):
2678 Use ptrdiff_t, not int, to record length of selection.
2679 (x_reply_selection_request, x_get_window_property)
2680 (receive_incremental_selection, x_property_data_to_lisp):
2681 Redo calculations to avoid overflow.
2682 (x_reply_selection_request): When sending hint, ceiling it at
2683 X_LONG_MAX rather than relying on wraparound overflow to send
2684 something.
2685 (x_get_window_property, receive_incremental_selection)
2686 (lisp_data_to_selection_data, x_property_data_to_lisp):
2687 Check for size-calculation overflow.
2688 (x_get_window_property, receive_incremental_selection)
2689 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2690 Don't store size until memory allocation succeeds.
2691 (x_get_window_property): Plug memory leak on memory exhaustion.
2692 Don't double-block input; malloc is safe here. Don't assume 2**34
2693 - 4 fits in unsigned long. Add an xassert to check
2694 XGetWindowProperty overflow. Be more careful about overflow
2695 calculations, and distinguish size from memory overflow better.
2696 (receive_incremental_selection): When tracing, don't assume
2697 unsigned int is less than INT_MAX.
2698 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2699 harmful) conversions of unsigned short to int.
2700 (lisp_data_to_selection_data): Don't assume that integers
2701 in the range -65535 through -1 fit in an X unsigned short.
2702 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2703 result parameters unless successful. Rely on cons_to_unsigned
2704 to report problems with elements; the old code wasn't right anyway.
2705 (x_check_property_data): Check for int overflow; we cannot use
2706 a wider type due to X limits.
2707 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2708
2709 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2710
2711 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2712 (x_term_init): Check for size calculation overflow.
2713 (x_color_cells): Don't store size until memory allocation succeeds.
2714 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2715 Don't assume alloca size is less than MAX_ALLOCA.
2716 (x_term_init): Don't assume length fits in int (sprintf is limited
2717 to int size).
2718
2719 Use ptrdiff_t for composition IDs.
2720 * character.c (lisp_string_width):
2721 * composite.c (composition_table_size, n_compositions)
2722 (get_composition_id, composition_gstring_from_id):
2723 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2724 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2725 * window.c (Frecenter):
2726 Use ptrdiff_t, not int, for composition IDs.
2727 * composite.c (get_composition_id): Check for integer overflow.
2728 * composite.h: Adjust prototypes to match the above changes.
2729
2730 Use ptrdiff_t for hash table indexes.
2731 * category.c (hash_get_category_set):
2732 * ccl.c (ccl_driver):
2733 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2734 * coding.c (coding_system_charset_list, detect_coding_system):
2735 * coding.h (struct coding_system.id):
2736 * composite.c (get_composition_id, gstring_lookup_cache):
2737 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2738 * image.c (xpm_get_color_table_h):
2739 * lisp.h (hash_lookup, hash_put):
2740 * minibuf.c (Ftest_completion):
2741 Use ptrdiff_t for hash table indexes, not int (which is too
2742 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2743 32-bit --with-wide-int hosts).
2744
2745 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2746 Add a FIXME comment about memory leaks.
2747 (syms_of_charset): Don't assume xmalloc returns.
2748
2749 Don't assume that stated character widths fit in int.
2750 * character.c (Fchar_width, c_string_width, lisp_string_width):
2751 * character.h (CHAR_WIDTH):
2752 * indent.c (MULTIBYTE_BYTES_WIDTH):
2753 Use sanitize_char_width to avoid undefined and/or bad behavior
2754 with outlandish widths.
2755 * character.h (sanitize_tab_width): Rename from sanitize_width,
2756 now that we have two such functions. All uses changed.
2757 (sanitize_char_width): New inline function.
2758
2759 Don't assume that tab-width fits in int.
2760 * character.h (sanitize_width): New inline function.
2761 (SANE_TAB_WIDTH): New macro.
2762 (ASCII_CHAR_WIDTH): Use it.
2763 * indent.c (sane_tab_width): Remove. All uses replaced by
2764 SANE_TAB_WIDTH (current_buffer).
2765 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2766
2767 * fileio.c: Integer overflow issues with file modes.
2768 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2769
2770 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2771 Remove unreachable code.
2772 (read_hex, load_charset_map_from_file): Check for integer overflow.
2773
2774 * xterm.c: Don't go over XClientMessageEvent limit.
2775 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2776 (x_send_scroll_bar_event): Likewise. Check that the size does not
2777 exceed limits imposed by XClientMessageEvent, as well as the usual
2778 ptrdiff_t and size_t limits.
2779
2780 * keyboard.c: Overflow, signedness and related fixes.
2781 (make_lispy_movement): Use same integer type in forward decl
2782 that is used in the definition.
2783 (read_key_sequence, keyremap_step):
2784 Change bufsize argument back to int, undoing my 2011-03-30 change.
2785 We prefer signed types, and int is wide enough here.
2786 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2787 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2788 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2789 length, not size_t. Use ptrdiff_t for index, not int.
2790 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2791 possibility of integer overflow.
2792
2793 Overflow, signedness and related fixes for images.
2794
2795 * dispextern.h (struct it.stack[0].u.image.image_id)
2796 (struct_it.image_id, struct image.id, struct image_cache.size)
2797 (struct image_cache.used, struct image_cache.ref_count):
2798 * gtkutil.c (update_frame_tool_bar):
2799 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2800 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2801 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2802 * nsmenu.m (update_frame_tool_bar):
2803 * xdisp.c (calc_pixel_width_or_height):
2804 * xfns.c (image_cache_refcount):
2805 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2806 on typical 64-bit hosts.
2807
2808 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2809 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2810 Omit unnecessary casts to int.
2811 (parse_image_spec): Check that integers fall into 'int' range
2812 when the callers expect that.
2813 (image_ascent): Redo ascent calculation to avoid int overflow.
2814 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2815 (lookup_image): Remove unnecessary tests.
2816 (xbm_image_p): Locals are now of int, not EMACS_INT,
2817 since parse_image_check makes sure they fit into int.
2818 (png_load, gif_load, svg_load_image):
2819 Prefer int to unsigned where either will do.
2820 (tiff_handler): New function, combining the cores of the
2821 old tiff_error_handler and tiff_warning_handler.
2822 This function is rewritten to use vsnprintf and thereby avoid
2823 stack buffer overflows. It uses only the features of vsnprintf
2824 that are common to both POSIX and native Microsoft.
2825 (tiff_error_handler, tiff_warning_handler): Use it.
2826 (tiff_load, gif_load, imagemagick_load_image):
2827 Don't assume :index value fits in 'int'.
2828 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2829 (imagemagick_load_image): Check that crop parameters fit into
2830 the integer types that MagickCropImage accepts. Don't assume
2831 Vimagemagick_render_type has a nonnegative value. Don't assume
2832 size_t fits in 'long'.
2833 (gs_load): Use printmax_t to print the widest integers possible.
2834 Check for integer overflow when computing image height and width.
2835
2836 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2837
2838 * xdisp.c (redisplay_window): Don't force window start if point
2839 will be invisible in the resulting window. (Bug#9324)
2840
2841 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2842
2843 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2844 the display spec is of the form `(space ...)'.
2845 (handle_display_spec): Return the value returned by
2846 handle_single_display_spec, not just 1 or zero.
2847 (handle_single_display_spec): If the display spec is of the form
2848 `(space ...)', and specifies display in the text area, return 2
2849 rather than 1.
2850 (try_cursor_movement): Check for the need to scroll more
2851 accurately, and prefer exact match for point under bidi.
2852 Don't advance `row' beyond the last row of the window.
2853
2854 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2855 into disp_prop; all users changed.
2856
2857 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2858 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2859 for the text covered by the display property.
2860
2861 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2862
2863 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2864 Change return value to nil.
2865 (Frecord_buffer): Delete unused function.
2866
2867 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2868
2869 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2870 buffers, return left-to-right.
2871 (set_cursor_from_row): Consider candidate row a win if its glyph
2872 represents a newline and point is on that newline. Fixes cursor
2873 positioning on the newline at EOL of R2L text within L2R
2874 paragraph, and vice versa.
2875 (try_cursor_movement): Check continued rows, in addition to
2876 continuation rows. Fixes unwarranted scroll when point enters a
2877 continued line of R2L text within an L2R paragraph, or vice versa.
2878 (cursor_row_p): Consider the case of point being equal to
2879 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2880 from the end of a short line to the beginning of a continued line
2881 of R2L text within L2R paragraph.
2882 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2883 composed characters.
2884
2885 * bidi.c (bidi_check_type): Use xassert.
2886 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2887 members.
2888
2889 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2890
2891 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2892 a character.
2893
2894 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2895
2896 * nsfont.m (ns_otf_to_script): Fix typo.
2897
2898 2011-08-22 Kenichi Handa <handa@m17n.org>
2899
2900 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2901 extra slot even if the purpose is char-code-property-table.
2902
2903 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2904
2905 * xdisp.c (redisplay_window): When computing centering_position,
2906 account for the height of the header line. (Bug#8874)
2907
2908 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2909 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2910 candidate is selected by the mouse, and that candidate has a
2911 composed character under the mouse.
2912
2913 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2914 coordinates reported by pos-visible-in-window-p for a composed
2915 character in column zero.
2916
2917 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2918
2919 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2920
2921 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2922
2923 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2924 consider it a hit if to_charpos is anywhere in the range of the
2925 composed buffer positions.
2926
2927 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2928
2929 * image.c (gif_load): Don't assume that each subimage has the same
2930 dimensions as the base image. Handle disposal method that is
2931 "undefined" by the gif spec (Bug#9335).
2932
2933 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2934
2935 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2936 (Fcondition_case): Document `debug' symbol in error handler.
2937
2938 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2939
2940 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2941 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2942 from an Org mode buffer to a Speedbar frame.
2943
2944 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2945 a composition, take its buffer position from IT->cmp_it.charpos.
2946 Fixes cursor positioning at the beginning of a line that begins
2947 with a composed character.
2948
2949 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2950
2951 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2952 character bidirectional type, use STRONG_L instead. Fixes crashes
2953 in a buffer produced by `describe-categories'.
2954
2955 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2956 members before the level stack, so they would be saved and
2957 restored when copying iterator state. Fixes incorrect reordering
2958 around TABs covered by display properties.
2959
2960 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2961
2962 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2963
2964 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2965
2966 * eval.c (internal_condition_case, internal_condition_case_1)
2967 (internal_condition_case_2, internal_condition_case_n):
2968 Remove unnecessary aborts (Bug#9081).
2969
2970 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2971
2972 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2973 has no `load' handler, try opening the file locally. (Bug#9311)
2974
2975 2011-08-16 Ken Brown <kbrown@cornell.edu>
2976
2977 * gmalloc.c: Expand comment.
2978
2979 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2980
2981 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2982 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2983
2984 2011-08-16 Ken Brown <kbrown@cornell.edu>
2985
2986 Fix memory allocation problems in Cygwin build (Bug#9273).
2987
2988 * unexcw.c ( __malloc_initialized): Declare external variable.
2989 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2990
2991 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2992 New variables.
2993 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2994 dumped emacs.
2995 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2996 in the static heap.
2997 [CYGWIN] (special_realloc): New function.
2998 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2999 requests to realloc storage in the static heap.
3000
3001 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3002
3003 * bidi.c (bidi_initialize): Remove unused local.
3004
3005 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3006
3007 * bidimirror.h:
3008 * biditype.h: Remove file.
3009 * makefile.w32-in ($(BLD)/bidi.$(O)):
3010 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3011
3012 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3013
3014 * chartab.c: Improve commentary for the uniprop_table API.
3015
3016 * bidi.c (bidi_paragraph_init): Support zero value of
3017 bidi_ignore_explicit_marks_for_paragraph_level.
3018 (bidi_initialize): Use uniprop_table instead of including
3019 biditype.h and bidimirror.h.
3020
3021 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3022 coordinates of the iterator when restoring from ppos_it.
3023 (Bug#9296)
3024
3025 2011-08-14 Kenichi Handa <handa@m17n.org>
3026
3027 * process.c (create_process): Call setup_process_coding_systems
3028 after the pid of the process is set to -1 (Bug#8162).
3029
3030 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3031
3032 * xdisp.c (move_it_in_display_line_to): Don't invoke
3033 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3034 ppos_it. Fixes vertical cursor motion when line beginning is
3035 covered by an image. (Bug#9296)
3036
3037 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3038
3039 * nsterm.h (ns_run_ascript): Declare.
3040 (NSAPP_DATA2_RUNASSCRIPT): Define.
3041
3042 * nsfns.m (as_script, as_result, as_status): New static variables.
3043 (ns_run_ascript): New function.
3044 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3045 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3046 the event loop. Get status from as_status (Bug#7276).
3047
3048 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3049 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3050 the event loop (Bug#7276).
3051
3052 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3053
3054 * gnutls.c (QCgnutls_bootprop_priority)
3055 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3056 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3057 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3058 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3059 (QCgnutls_bootprop_verify_hostname_error)
3060 (QCgnutls_bootprop_callbacks_verify): Rename from
3061 Qgnutls_bootprop_..., all uses changed.
3062
3063 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3064 uses changed.
3065
3066 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3067
3068 * xfaces.c (Qframe_set_background_mode): Now static.
3069 * dispextern.h (Qframe_set_background_mode): Remove decl.
3070
3071 * process.c (Fnetwork_interface_info): Declare local only if needed.
3072
3073 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3074
3075 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3076 (Fnetwork_interface_list): Allocate in increments of bytes instead
3077 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3078 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3079 sockaddr.
3080 (struct ifflag_def): notrailers is smart on OSX.
3081 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3082 Get hardware address with getifaddrs if available.
3083
3084 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3085
3086 * xdisp.c (iterate_out_of_display_property): xassert that
3087 IT->position is set to within IT->object's boundaries. Break from
3088 the loop as soon as EOB is reached; avoids infloops in redisplay
3089 when IT->position is set up wrongly due to some bug.
3090 Set IT->current to match the bidi iterator unconditionally.
3091 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3092 entry. Force push_it to save on the stack the current
3093 buffer/string position, to be restored by pop_it. Fix flags in
3094 the iterator structure wrt the object coming from a display
3095 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3096 properties. (Bug#9284)
3097
3098 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3099
3100 * fontset.c (fontset_get_font_group): Add proper type checks.
3101 (Bug#9172)
3102
3103 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3104
3105 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3106 and LC_VERSION_MIN_MACOSX.
3107 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3108 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3109
3110 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3111
3112 * xdisp.c (forward_to_next_line_start): Allow to use the
3113 no-display-properties-and-no-overlays under bidi display.
3114 Set disp_pos in the bidi iterator to avoid searches for display
3115 properties and overlays.
3116
3117 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3118
3119 * editfns.c (Fset_time_zone_rule): Document relationship with the
3120 setenv function.
3121
3122 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3123 the font entity extracted from the cache (Bug#8109).
3124
3125 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3126
3127 * composite.c (autocmp_chars): Don't reset point. That is done by
3128 restore_point_unwind (Bug#5984).
3129
3130 2011-08-07 Juri Linkov <juri@jurta.org>
3131
3132 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3133 to show the arg `TIME' instead of `TIMEVAL'.
3134
3135 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3136
3137 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3138 display property strides EOL and includes a newline, as in
3139 longlines-mode. (Bug#9254)
3140 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3141 word-wrap under bidirectional display. (Bug#9224)
3142
3143 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3144 is non-zero, even if the data buffer is NULL. Fixes a crash in
3145 vertical-motion with longlines-mode. (Bug#9254)
3146
3147 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3148
3149 * bidi.c <bidi_cache_total_alloc>: Now static.
3150 (bidi_initialize): Initialize bidi_cache_total_alloc.
3151
3152 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3153 cache. (Bug#9221)
3154
3155 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3156 amount allocated this far in `bidi_cache_total_alloc'.
3157 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3158 non-zero, only free the data buffer without restoring the cache
3159 contents. All callers changed.
3160
3161 * dispextern.h (bidi_unshelve_cache): Update prototype.
3162
3163 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3164 (move_it_in_display_line, move_it_to)
3165 (move_it_vertically_backward, move_it_by_lines): Replace the call
3166 to xfree to an equivalent call to bidi_unshelve_cache.
3167 (move_it_in_display_line_to): Fix logic of returning
3168 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3169
3170 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3171
3172 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3173 came from a string character with a `cursor' property. (Bug#9229)
3174
3175 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3176
3177 * Makefile.in (LIB_PTHREAD): New variable.
3178 (LIBES): Add LIB_PTHREAD (Bug#9216).
3179
3180 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3181 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3182
3183 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3184
3185 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3186
3187 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3188
3189 * xterm.c (x_find_topmost_parent): New function.
3190 (x_set_frame_alpha): Find topmost parent window with
3191 x_find_topmost_parent and set the property there also (bug#9181).
3192 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3193
3194 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3195
3196 * callproc.c (Fcall_process): Avoid vfork clobbering
3197 the local vars buffer, coding_systems, current_dir.
3198
3199 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3200
3201 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3202
3203 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3204
3205 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3206 so that it is not optimized away.
3207
3208 * xdisp.c (compute_display_string_pos): Remove unused local.
3209
3210 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3211
3212 Fix slow cursor motion and scrolling in large buffers with
3213 selective display, like Org Mode buffers. (Bug#9218)
3214
3215 * dispextern.h (struct bidi_it): New member disp_prop_p.
3216
3217 * xdisp.c: Remove one-slot cache of display string positions.
3218 (compute_display_string_pos): Accept an additional argument
3219 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3220 for a display string or property. If found, set DISP_PROP_P
3221 non-zero.
3222
3223 * bidi.c (bidi_fetch_char): Accept an additional argument
3224 DISP_PROP_P, and pass it to compute_display_string_pos.
3225 Only handle text covered by a display string if DISP_PROP_P is returned
3226 non-zero. All callers of bidi_fetch_char changed.
3227
3228 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3229
3230 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3231
3232 2010-12-03 Don March <don@ohspite.net>
3233
3234 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3235 last character M-[char] is translated to ESC [char] (bug#7541).
3236
3237 2011-08-02 Kenichi Handa <handa@m17n.org>
3238
3239 * lisp.h (uniprop_table): Extern it.
3240
3241 * chartab.c (uniprop_table): Make it non-static.
3242
3243 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3244
3245 * xdisp.c (forward_to_next_line_start): Accept additional argument
3246 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3247 on the newline.
3248 (reseat_at_next_visible_line_start): Use the bidi iterator state
3249 returned by forward_to_next_line_start to restore the state of
3250 it->bidi_it after backing up to previous newline. (Bug#9212)
3251
3252 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3253
3254 * regex.c (re_comp): Protoize.
3255 (re_exec): Fix return type.
3256 (regexec): Fix type of `ret'. (Bug#9203)
3257
3258 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3259
3260 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3261 This is needed if max-image-size is a floating-point number.
3262
3263 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3264
3265 * print.c (print_object): Print empty symbol as ##.
3266
3267 * lread.c (read1): Read ## as empty symbol.
3268
3269 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3270
3271 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3272 setting frame foreground color (Bug#9175).
3273 (x_set_background_color): Likewise.
3274
3275 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3276 contents (Bug#9176).
3277 (EmacsTooltip -init): Remove bezels and add shadows to
3278 tooltip windows.
3279
3280 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3281 or scroll bar (Bug#8470).
3282
3283 * nsfont.m (nsfont_open): Remove assignment to voffset and
3284 unnecessary vars hshink, expand, hd, full_height, min_height.
3285 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3286
3287 * nsterm.h (nsfont_info): Remove voffset field.
3288
3289 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3290
3291 Implement strike-through and overline on NextStep (Bug#8863).
3292
3293 * nsfont.m (nsfont_open): Use underline position provided by font,
3294 instead of hard-coded value of 2.
3295 (nsfont_draw): Call ns_draw_text_decoration instead.
3296
3297 * nsterm.h: Add declaration for ns_draw_text_decoration.
3298
3299 * nsterm.m (ns_draw_text_decoration): New function for drawing
3300 underline, overline, and strike-through.
3301 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3302 ns_draw_text_decoration. Change treatment of cursor drawing to
3303 accommodate underlining, etc.
3304
3305 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3306
3307 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3308 default.
3309
3310 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3311
3312 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3313 Without this fix, if a signal arrives just after memory fills up,
3314 'malloc' might be invoked reentrantly.
3315
3316 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3317 In other words, assume that every image size is allowed, on non-X
3318 hosts. This assumption is probably wrong, but it lets Emacs compile.
3319
3320 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3321
3322 * regex.c (re_iswctype): Convert return values to boolean.
3323
3324 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3325
3326 * xdisp.c (compute_display_string_pos): Don't use cached display
3327 string position if the buffer had its restriction changed.
3328 (Bug#9184)
3329
3330 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3331
3332 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3333
3334 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3335
3336 Integer signedness and overflow and related fixes. (Bug#9079)
3337
3338 * bidi.c: Integer size and overflow fixes.
3339 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3340 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3341 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3342 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3343 (bidi_find_other_level_edge):
3344 Use ptrdiff_t instead of EMACS_INT where either will do.
3345 This works better on 32-bit hosts configured --with-wide-int.
3346 (bidi_cache_ensure_space): Check for size-calculation overflow.
3347 Use % rather than repeated addition, for better worst-case speed.
3348 Don't set bidi_cache_size until after xrealloc returns, because it
3349 might not return.
3350 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3351 (bidi_cache_ensure_space): Also check that the bidi cache size
3352 does not exceed that of the largest Lisp string or buffer. See Eli
3353 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3354
3355 * alloc.c (__malloc_size_t): Remove.
3356 All uses replaced by size_t. See Andreas Schwab's note
3357 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3358
3359 * image.c: Improve checking for integer overflow.
3360 (check_image_size): Assume that f is nonnull, since
3361 it is always nonnull in practice. This is one less thing to
3362 worry about when checking for integer overflow later.
3363 (x_check_image_size): New function, which checks for integer
3364 overflow issues inside X.
3365 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3366 This removes the need for a memory_full check.
3367 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3368 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3369 (xbm_read_bitmap_data): Change locals back to 'int', since
3370 their values must fit in 'int'.
3371 (xpm_load_image, png_load, tiff_load):
3372 Invoke x_create_x_image_and_pixmap earlier,
3373 to avoid much needless work if the image is too large.
3374 (tiff_load): Treat overly large images as if
3375 x_create_x_image_and_pixmap failed, not as malloc failures.
3376 (gs_load): Use x_check_image_size.
3377
3378 * gtkutil.c: Omit integer casts.
3379 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3380 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3381
3382 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3383
3384 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3385 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3386 would wrongly return t on a 64-bit host.
3387
3388 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3389 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3390 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3391 and therefore cause GCC to emit a bogus diagnostic in some cases.
3392
3393 * image.c: Integer signedness and overflow and related fixes.
3394 This is not an exhaustive set of fixes, but it's time to
3395 record what I've got.
3396 (lookup_pixel_color, check_image_size): Remove redundant decls.
3397 (check_image_size): Don't assume that arbitrary EMACS_INT values
3398 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3399 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3400 (tiff_load, imagemagick_load_image):
3401 Check for overflow in size calculations.
3402 (x_create_x_image_and_pixmap): Remove unnecessary test for
3403 xmalloc returning NULL; that can't happen.
3404 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3405 (xpm_color_bucket): Use better integer hashing function.
3406 (xpm_cache_color): Don't possibly over-allocate memory.
3407 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3408 (gif_memory_source):
3409 Use ptrdiff_t, not int or size_t, to record sizes.
3410 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3411 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3412 either works, as we prefer signed integers.
3413 (tiff_read_from_memory, tiff_write_from_memory):
3414 Return tsize_t, not size_t, since that's what the TIFF API wants.
3415 (tiff_read_from_memory): Don't fail simply because the read would
3416 go past EOF; instead, return a short read.
3417 (tiff_load): Omit no-longer-needed casts.
3418 (Fimagemagick_types): Don't assume size fits into 'int'.
3419
3420 Improve hashing quality when configured --with-wide-int.
3421 * fns.c (hash_string): New function, taken from sxhash_string.
3422 Do not discard information about ASCII character case; this
3423 discarding is no longer needed.
3424 (sxhash-string): Use it. Change sig to match it. Caller changed.
3425 * lisp.h: Declare it.
3426 * lread.c (hash_string): Remove, since we now use fns.c's version.
3427 The fns.c version returns a wider integer if --with-wide-int is
3428 specified, so this should help the quality of the hashing a bit.
3429
3430 * emacs.c: Integer overflow minor fix.
3431 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3432 Define only if GNU_LINUX.
3433 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3434
3435 * dispnew.c: Integer signedness and overflow fixes.
3436 Remove unnecessary forward decls, that were a maintenance hassle.
3437 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3438 All uses changed.
3439 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3440 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3441 (prepare_desired_row, line_draw_cost):
3442 Use int, not unsigned, where either works.
3443 (save_current_matrix, restore_current_matrix):
3444 Use ptrdiff_t, not size_t, where either works.
3445 (init_display): Check for overflow more accurately, and without
3446 relying on undefined behavior.
3447
3448 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3449 Remove, replacing with the new symbols in lisp.h. All uses changed.
3450 * fileio.c (make_temp_name):
3451 * filelock.c (lock_file_1, lock_file):
3452 * xdisp.c (message_dolog):
3453 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3454 Use pMd etc. instead.
3455 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3456 replacing the pWIDE etc. symbols removed from editfns.c.
3457
3458 * keyboard.h (num_input_events): Now uintmax_t.
3459 This is (very slightly) less likely to mess up due to wraparound.
3460 All uses changed.
3461
3462 * buffer.c: Integer signedness fixes.
3463 (alloc_buffer_text, enlarge_buffer_text):
3464 Use ptrdiff_t rather than size_t when either will do, as we prefer
3465 signed integers.
3466
3467 * alloc.c: Integer signedness and overflow fixes.
3468 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3469 (__malloc_size_t): Default to size_t, not to int.
3470 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3471 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3472 Prefer ptrdiff_t to size_t when either would do, as we prefer
3473 signed integers.
3474 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3475 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3476 Now const. Initialize with values that are in range even if char
3477 is signed.
3478 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3479 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3480 These functions do the right thing with sizes > 2**32.
3481 (check_depth): Now ptrdiff_t, not int.
3482 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3483 Adjust to new way of storing sizes. Check for size overflow bugs
3484 in rest of code.
3485 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3486 slightly wrong anyway, as it missed one instance of
3487 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3488 (refill_memory_reserve): Omit needless cast to size_t.
3489 (mark_object_loop_halt): Mark as externally visible.
3490
3491 * xselect.c: Integer signedness and overflow fixes.
3492 (Fx_register_dnd_atom, x_handle_dnd_message):
3493 Use ptrdiff_t, not size_t, since we prefer signed.
3494 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3495 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3496 x_dnd_atoms_size and x_dnd_atoms_length.
3497
3498 * doprnt.c: Prefer signed to unsigned when either works.
3499 * eval.c (verror):
3500 * doprnt.c (doprnt):
3501 * lisp.h (doprnt):
3502 * xdisp.c (vmessage):
3503 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3504 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3505 prefer signed arithmetic to avoid comparison confusion.
3506 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3507 but is a bit tricky.
3508
3509 Assume freestanding C89 headers, string.h, stdlib.h.
3510 * data.c, doprnt.c, floatfns.c, print.c:
3511 Include float.h unconditionally.
3512 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3513 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3514 * regex.c: Likewise for stddef.h, string.h.
3515 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3516 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3517 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3518 (STDC_HEADERS): Remove obsolete defines.
3519 * sysdep.c: Include limits.h unconditionally.
3520
3521 Assume support for memcmp, memcpy, memmove, memset.
3522 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3523 * regex.c (memcmp, memcpy):
3524 Remove; we assume C89 now.
3525
3526 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3527 (__malloc_safe_bcopy): Remove; no longer needed.
3528
3529 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3530 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3531 well either way, and we prefer signed to unsigned.
3532
3533 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3534
3535 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3536 closes the connection while we're reading (bug#9182).
3537
3538 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3539
3540 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3541 are specified (Bug#9168).
3542
3543 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3544
3545 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3546 Found by GCC static checking and --with-wide-int on a 32-bit host.
3547
3548 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3549
3550 * xdisp.c (compute_display_string_pos): Fix logic of caching
3551 previous display string position. Initialize cached_prev_pos to
3552 -1. Fixes slow-down at the beginning of a buffer.
3553
3554 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3555
3556 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3557 for attrs[LFACE_FONTSET_INDEX].
3558
3559 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3560
3561 * xml.c (parse_region): Remove unused local
3562 that was recently introduced.
3563
3564 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3565
3566 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3567 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3568
3569 * xdisp.c (move_it_in_display_line_to): Record the best matching
3570 position for TO_CHARPOS while scanning the line, and restore it on
3571 exit if none of the characters scanned was an exact match.
3572 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3573 when exact match is impossible due to invisible text, and the
3574 lines are truncated.
3575
3576 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3577
3578 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3579 for OSX >= 10.7.
3580
3581 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3582
3583 Fix a significant slow-down of cursor motion with C-n, C-p,
3584 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3585 auto-repeat under bidi redisplay in fontified buffers.
3586 * xdisp.c (compute_stop_pos_backwards): New function.
3587 (next_element_from_buffer): Call compute_stop_pos_backwards to
3588 find a suitable prev_stop when we find ourselves before
3589 base_level_stop.
3590 (reseat): Don't look for prev_stop, as that could mean a very long
3591 run.
3592 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3593 <cached_disp_overlay_modiff>: Cache for last found display string
3594 position.
3595 (compute_display_string_pos): Return the cached position if asked
3596 about the same buffer in the same area of character positions, and
3597 the buffer wasn't changed since the time the display string
3598 position was cached.
3599
3600 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3601
3602 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3603 is an integer, which is important for empty lines. (Bug#9149)
3604
3605 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3606
3607 * frame.c (Fmodify_frame_parameters): In tty case, update the
3608 default face if necessary (Bug#4238).
3609
3610 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3611
3612 * editfns.c (Fstring_to_char): No need to explain what a character
3613 is in the docstring (Bug#6576).
3614
3615 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3616
3617 * xml.c (parse_region): Make sure we always return a tree.
3618
3619 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3620
3621 * xml.c (parse_region): If a document contains only comments,
3622 return that, too.
3623
3624 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3625
3626 * xml.c (make_dom): Return comments, too.
3627
3628 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3629
3630 Port to OpenBSD.
3631 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3632 and the surrounding thread.
3633 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3634 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3635 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3636 timer goes off.
3637 * s/openbsd.h (BROKEN_SIGIO): Define.
3638 * unexelf.c (unexec) [__OpenBSD__]:
3639 Don't update the .mdebug section of the Alpha COFF symbol table.
3640
3641 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3642
3643 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3644 (bug#8460).
3645
3646 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3647
3648 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3649 This fixes some race conditions on the permissions of any newly
3650 created file.
3651
3652 * alloc.c (valid_pointer_p): Use pipe, not open.
3653 This fixes some permissions issues when debugging.
3654
3655 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3656 If fchown fails to set both uid and gid, try to set just gid,
3657 as that is sometimes allowed. Adjust the file's mode to eliminate
3658 setuid or setgid bits that are inappropriate if fchown fails.
3659
3660 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3661
3662 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3663 to compare Lisp_Objects.
3664 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3665 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3666 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3667
3668 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3669
3670 * lread.c (read_integer): Unread even EOF character.
3671 (read1): Likewise. Properly record start position of symbol.
3672
3673 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3674 symbol character follows.
3675
3676 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3677
3678 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3679 This works around a problem with the previous change to Fcopy_file.
3680 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3681 and without this change, GCC might complain about discarding
3682 fchown's return value.
3683
3684 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3685
3686 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3687
3688 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3689
3690 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3691
3692 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3693
3694 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3695 it's used from the C level.
3696
3697 * process.c: Use the same condition for POLL_FOR_INPUT in both
3698 keyboard.c and process.c (bug#1858).
3699
3700 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3701
3702 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3703 (Fgnutls_boot): Use it.
3704
3705 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3706
3707 * doc.c (Fsubstitute_command_keys): Revert last change.
3708
3709 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3710
3711 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3712 quotes the next character, and doesn't affect other longer
3713 sequences (bug#8935).
3714
3715 * lread.c (syms_of_lread): Clarify that is isn't only
3716 `eval-buffer' and `eval-defun' that's affected by
3717 `lexical-binding' (bug#8460).
3718
3719 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3720
3721 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3722 bidi redisplay when a line includes both an image and is truncated.
3723
3724 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3725
3726 Fix minor problems found by static checking.
3727 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3728 (elsz): Now a signed constant, not a size_t var. We prefer signed
3729 types to unsigned, to avoid integer comparison confusion. Without
3730 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3731 "cannot optimize loop, the loop counter may overflow", a symptom
3732 of the confusion.
3733 * indent.c (Fvertical_motion): Mark locals as initialized.
3734 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3735
3736 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3737
3738 * search.c (Fre_search_backward): Mention `case-fold-search' in
3739 all the re_search_* functions (bug#8138).
3740
3741 * keyboard.c (Fopen_dribble_file): Document when the file is
3742 closed (bug#8056).
3743
3744 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3745
3746 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3747 bidi_cache_idx.
3748
3749 Support bidi reordering of display and overlay strings.
3750 * xdisp.c (compute_display_string_pos)
3751 (compute_display_string_end): Accept additional argument STRING.
3752 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3753 (reseat_to_string): Initialize bidi_it->string.s and
3754 bidi_it->string.schars.
3755 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3756 NULL (avoids a crash in bidi_paragraph_init).
3757 Initialize itb.string.lstring.
3758 (init_iterator): Call bidi_init_it only of a valid
3759 buffer position was specified. Initialize paragraph_embedding to
3760 L2R.
3761 (reseat_to_string): Initialize the bidi iterator.
3762 (display_string): If we need to ignore text properties of
3763 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3764 original value of -1 will not work with bidi.)
3765 (compute_display_string_pos): First arg is now struct
3766 `text_pos *'; all callers changed. Support display properties on
3767 Lisp strings.
3768 (compute_display_string_end): Support display properties on Lisp
3769 strings.
3770 (init_iterator, reseat_1, reseat_to_string): Initialize the
3771 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3772 when iterating on a string not from display properties).
3773 (compute_display_string_pos, compute_display_string_end):
3774 Fix calculation of the object to scan. Fixes an error when using
3775 arrow keys.
3776 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3777 base_level_stop; instead, set base_level_stop to BEGV.
3778 Fixes crashes in vertical-motion.
3779 (next_element_from_buffer): Improve commentary for when
3780 the iterator is before prev_stop.
3781 (init_iterator): Initialize bidi_p from the default value of
3782 bidi-display-reordering, not from buffer-local value. Use the
3783 buffer-local value only if initializing for buffer iteration.
3784 (handle_invisible_prop): Support invisible properties on strings
3785 that are being bidi-reordered.
3786 (set_iterator_to_next): Support bidi reordering of C strings and
3787 Lisp strings.
3788 (next_element_from_string): Support bidi reordering of Lisp
3789 strings.
3790 (handle_stop_backwards): Support Lisp strings as well.
3791 (display_string): Support display of R2L glyph rows.
3792 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3793 (init_iterator): Don't initialize it->bidi_p for strings
3794 here.
3795 (reseat_to_string): Initialize it->bidi_p for strings here.
3796 (next_element_from_string, next_element_from_c_string)
3797 (next_element_from_buffer): Add xassert's for correspondence
3798 between IT's object being iterated and it->bidi_it.string
3799 structure.
3800 (face_before_or_after_it_pos): Support bidi iteration.
3801 (next_element_from_c_string): Handle the case of the first string
3802 character that is not the first one in the visual order.
3803 (get_visually_first_element): New function, refactored from common
3804 parts of next_element_from_buffer, next_element_from_string, and
3805 next_element_from_c_string.
3806 (tool_bar_lines_needed, redisplay_tool_bar)
3807 (display_menu_bar): Force left-to-right direction. Add a FIXME
3808 comment for making that be controlled by a user option.
3809 (push_it, pop_it): Save and restore the state of the
3810 bidi iterator. Save and restore the bidi_p flag.
3811 (pop_it): Iterate out of display property for string iteration as
3812 well.
3813 (iterate_out_of_display_property): Support iteration over strings.
3814 (handle_single_display_spec): Set up it->bidi_it for iteration
3815 over a display string, and call bidi_init_it.
3816 (handle_single_display_spec, next_overlay_string)
3817 (get_overlay_strings_1, push_display_prop): Set up the bidi
3818 iterator for displaying display or overlay strings.
3819 (forward_to_next_line_start): Don't use the shortcut if
3820 bidi-iterating.
3821 (back_to_previous_visible_line_start): If handle_display_prop
3822 pushed the iterator stack, restore the internal state of the bidi
3823 iterator by calling bidi_pop_it same number of times.
3824 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3825 and we are bidi-iterating, don't decrement the iterator position;
3826 instead, set the first_elt flag in the bidi iterator, to produce
3827 the same effect.
3828 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3829 (push_display_prop): xassert that we are iterating a buffer.
3830 (push_it, pop_it): Save and restore paragraph_embedding member.
3831 (handle_single_display_spec, next_overlay_string)
3832 (get_overlay_strings_1, reseat_1, reseat_to_string)
3833 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3834 correctly. Don't assume unibyte strings are not bidi-reordered.
3835 (compute_display_string_pos)
3836 (compute_display_string_end): Fix handling the case of C string.
3837 (push_it, pop_it): Save and restore from_disp_prop_p.
3838 (handle_single_display_spec, push_display_prop): Set the
3839 from_disp_prop_p flag.
3840 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3841 (pop_it): Call iterate_out_of_display_property only if we are
3842 popping after iteration over a string that came from a display
3843 property. Fix a typo in popping stretch info. Add an assertion
3844 for verifying that the iterator position is in sync with the bidi
3845 iterator.
3846 (handle_single_display_spec, get_overlay_strings_1)
3847 (push_display_prop): Fix initialization of paragraph direction for
3848 string when that of the parent object is not yet determined.
3849 (reseat_1): Call bidi_init_it to resync the bidi
3850 iterator with IT's position. (Bug#7616)
3851 (find_row_edges): If ROW->start.pos gives position
3852 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3853 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3854 Reset the from_disp_prop_p flag.
3855 (SAVE_IT, RESTORE_IT): New macros.
3856 (pos_visible_p, face_before_or_after_it_pos)
3857 (back_to_previous_visible_line_start)
3858 (move_it_in_display_line_to, move_it_in_display_line)
3859 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3860 (try_scrolling, redisplay_window, display_line): Use them when
3861 saving a temporary copy of the iterator and restoring it back.
3862 (back_to_previous_visible_line_start, reseat_1)
3863 (init_iterator): Empty the bidi cache "stack".
3864 (move_it_in_display_line_to): If iterator ended up at
3865 EOL, but we never saw any buffer positions smaller than
3866 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3867 motion in bidi-reordered lines.
3868 (move_it_in_display_line_to): Record prev_method and prev_pos
3869 immediately before the call to set_iterator_to_next. Fixes cursor
3870 motion in bidi-reordered lines with stretch glyphs and strings
3871 displayed in margins. (Bug#8133) (Bug#8867)
3872 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3873 TO_CHARPOS.
3874 (pos_visible_p): Support positions in bidi-reordered lines.
3875 Save and restore bidi cache.
3876
3877 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3878 (bidi_paragraph_info): Delete unused struct.
3879 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3880 (bidi_cache_start): New variable.
3881 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3882 to zero.
3883 (bidi_cache_fetch_state, bidi_cache_search)
3884 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3885 (bidi_cache_find, bidi_peek_at_next_level)
3886 (bidi_level_of_next_char, bidi_find_other_level_edge)
3887 (bidi_move_to_visually_next): Compare cache index with
3888 bidi_cache_start rather than with zero.
3889 (bidi_fetch_char): Accept new argument STRING; all callers
3890 changed. Support iteration over a string. Support strings with
3891 display properties. Support unibyte strings. Fix the type of
3892 `len' according to what STRING_CHAR_AND_LENGTH expects.
3893 (bidi_paragraph_init, bidi_resolve_explicit_1)
3894 (bidi_resolve_explicit, bidi_resolve_weak)
3895 (bidi_level_of_next_char, bidi_move_to_visually_next):
3896 Support iteration over a string.
3897 (bidi_set_sor_type, bidi_resolve_explicit_1)
3898 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3899 can now be zero (for strings); special values 0 and -1 were
3900 changed to -1 and -2, respectively.
3901 (bidi_char_at_pos): New function.
3902 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3903 Call it instead of FETCH_MULTIBYTE_CHAR.
3904 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3905 initialized to valid values.
3906 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3907 values.
3908 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3909 the test for valid cached positions. Fix the logic for looking up
3910 the sentinel state in the cache. GCPRO the Lisp string we are
3911 iterating.
3912 (bidi_push_it, bidi_pop_it): New functions.
3913 (bidi_initialize): Initialize the bidi cache start stack pointer.
3914 (bidi_cache_ensure_space): New function, refactored from part of
3915 bidi_cache_iterator_state. Don't assume the required size is just
3916 one BIDI_CACHE_CHUNK away.
3917 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3918 (bidi_count_bytes, bidi_char_at_pos): New functions.
3919 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3920 always valid if bidi_cache_idx is valid.
3921 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3922 is valid if it's going to be used.
3923 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3924 (bidi_cache_fetch_state, bidi_cache_search)
3925 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3926 (bidi_cache_iterator_state, bidi_cache_find)
3927 (bidi_find_other_level_edge, bidi_cache_start_stack):
3928 All variables related to cache indices are now EMACS_INT.
3929
3930 * dispextern.h (struct bidi_string_data): New structure.
3931 (struct bidi_it): New member `string'. Make flag members be 1-bit
3932 fields, and put them last in the struct.
3933 (compute_display_string_pos, compute_display_string_end):
3934 Update prototypes.
3935 (bidi_push_it, bidi_pop_it): Add prototypes.
3936 (struct iterator_stack_entry): New members bidi_p,
3937 paragraph_embedding, and from_disp_prop_p.
3938 (struct it): Member bidi_p is now a bit field 1 bit wide.
3939 (bidi_shelve_cache, bidi_unshelve_cache):
3940 Declare prototypes.
3941
3942 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3943 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3944 and vector-like objects.
3945
3946 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3947 cache around display iteration.
3948
3949 * window.c (Fwindow_end, window_scroll_pixel_based)
3950 (displayed_window_lines, Frecenter): Save and restore the bidi
3951 cache around display iteration.
3952
3953 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3954
3955 * editfns.c (Fdelete_region): Clarify the use of the named
3956 parameters (bug#6788).
3957
3958 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3959
3960 * indent.c (Fvertical_motion): Set and restore w->pointm when
3961 saving and restoring the window's buffer (Bug#9006).
3962
3963 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3964
3965 * editfns.c (Fstring_to_char): Clarify just what is returned
3966 (bug#6576). Text by Eli Zaretskii.
3967
3968 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3969
3970 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3971
3972 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3973
3974 * buffer.c (mmap_find): Fix a typo.
3975
3976 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3977
3978 Fix execution of x selection hooks.
3979 * xselect.c (Qx_lost_selection_functions)
3980 (Qx_sent_selection_functions): New vars.
3981 (syms_of_xselect): DEFSYM them.
3982 (x_handle_selection_request): Pass Qx_sent_selection_functions
3983 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3984 (x_handle_selection_clear,x_clear_frame_selections):
3985 Pass Qx_lost_selection_functions rather than
3986 Vx_lost_selection_functions to Frun_hook_with_args.
3987
3988 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3989
3990 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3991 The old code sometimes used this field without initializing it.
3992
3993 * alloc.c (gc_sweep): Don't read past end of array.
3994 In theory, the old code could also have corrupted Emacs internals,
3995 though it'd be very unlikely.
3996
3997 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3998
3999 * character.c (Fcharacterp): Don't advertise optional ignored
4000 argument. (Bug#4026)
4001
4002 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4003
4004 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4005 key" (bug#4257).
4006
4007 * window.c (Fset_window_start): Doc fix (bug#4199).
4008 (Fset_window_hscroll): Ditto.
4009
4010 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4011
4012 Fix minor new problems caught by GCC 4.6.1.
4013 * term.c (init_tty): Remove unused local.
4014 * xsettings.c (store_monospaced_changed): Define this function only
4015 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4016 not used otherwise.
4017
4018 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4019
4020 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4021
4022 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4023
4024 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4025 are the mini-buffer and the echo area (bug#3320).
4026
4027 * term.c (init_tty): Remove support for supdup, c10 and perq
4028 terminals, which are no longer supported (bug#1482).
4029
4030 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4031
4032 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4033
4034 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4035
4036 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4037 for non-popups (Bug#3642).
4038
4039 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4040
4041 * alloc.c (reset_malloc_hooks): Protoize.
4042 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4043 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4044 * cm.c (losecursor): Likewise.
4045 * data.c (fmod): Likewise.
4046 * dispnew.c (swap_glyphs_in_rows): Likewise.
4047 * emacs.c (memory_warning_signal): Likewise.
4048 * floatfns.c (float_error): Likewise.
4049 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4050 (otf_open, font_otf_capability, generate_otf_features)
4051 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4052 Likewise.
4053 * image.c (pbm_read_file): Likewise.
4054 * indent.c (string_display_width): Likewise.
4055 * intervals.c (check_for_interval, search_for_interval)
4056 (inc_interval_count, count_intervals, root_interval)
4057 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4058 * lread.c (defalias): Likewise.
4059 * ralloc.c (r_alloc_check): Likewise.
4060 * regex.c (set_image_of_range_1, set_image_of_range)
4061 (regex_grow_registers): Likewise.
4062 * sysdep.c (strerror): Likewise.
4063 * termcap.c (valid_filename_p, tprint, main): Likewise.
4064 * tparam.c (main): Likewise.
4065 * unexhp9k800.c (run_time_remap, save_data_space)
4066 (update_file_ptrs, read_header, write_header, calculate_checksum)
4067 (copy_file, copy_rest, display_header): Likewise.
4068 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4069 Likewise.
4070 * xdisp.c (check_it): Likewise.
4071 * xfaces.c (register_color, unregister_color, unregister_colors):
4072 Likewise.
4073 * xfns.c (print_fontset_result): Likewise.
4074 * xrdb.c (member, fatal, main): Likewise.
4075
4076 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4077
4078 Fix minor problems found by static checking (Bug#9031).
4079 * chartab.c (char_table_set_range, map_sub_char_table):
4080 Remove unused locals.
4081 (uniprop_table): Now static.
4082 * composite.c (_work_char): Remove unused static var.
4083
4084 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4085
4086 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4087
4088 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4089
4090 * gtkutil.c (qttip_cb): Remove code without function.
4091
4092 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4093
4094 * w32.c (pthread_sigmask): New stub.
4095
4096 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4097
4098 Use pthread_sigmask, not sigprocmask (Bug#9010).
4099 sigprocmask is portable only for single-threaded applications, and
4100 Emacs can be multi-threaded when it uses GTK.
4101 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4102 (LIBES): Use it.
4103 * callproc.c (Fcall_process):
4104 * process.c (create_process):
4105 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4106 Use pthread_sigmask, not sigprocmask.
4107
4108 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4109
4110 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4111 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4112 wrong (Bug#8591).
4113
4114 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4115
4116 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4117 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4118 (xg_hide_tooltip): Fix comment.
4119
4120 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4121 in registerServicesMenuSendTypes.
4122 (validRequestorForSendType): Don't check ns_return_types.
4123
4124 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4125 ns_return_type.
4126
4127 2011-07-08 Jason Rumney <jasonr@gnu.org>
4128
4129 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4130 SH_SHOW for hidden windows (Bug#5482).
4131
4132 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4133 frame struct members of non-existent frames (Bug#6284).
4134
4135 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4136
4137 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4138 variable firstTime not needed on OSX >= 10.6.
4139 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4140 >= 10.5. Use setKnobProportion, setDoubleValue.
4141
4142 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4143 (MAC_OS_X_VERSION_10_5): Define if not defined.
4144 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4145 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4146 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4147
4148 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4149 cString and lossyCString on OSX >= 10.4
4150
4151 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4152 sizeToFit on OSX >= 10.2.
4153
4154 * nsimage.m (allocInitFromFile): Don't use deprecated method
4155 bestRepresentationForDevice on OSX >= 10.6.
4156
4157 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4158 to avoid warning.
4159
4160 * emacs.c: Declare unexec_init_emacs_zone.
4161
4162 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4163
4164 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4165
4166 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4167 on svcsMenu (Bug#8842).
4168
4169 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4170 ns_return_types.
4171 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4172
4173 * nsterm.m (QUTF8_STRING): Declare.
4174 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4175 (validRequestorForSendType): Return type is (id).
4176 Change indexOfObjectIdenticalTo to indexOfObject.
4177 Check if we have local selection before returning self (Bug#8842).
4178 (writeSelectionToPasteboard): Put local selection into paste board
4179 if we have a local selection (Bug#8842).
4180 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4181
4182 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4183 (ns_get_local_selection): Declare.
4184
4185 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4186
4187 * keymap.c (describe_map_tree): Don't insert a double newline at
4188 the end of the buffer (bug#1169) and return whether we inserted
4189 something.
4190
4191 * callint.c (Fcall_interactively): Change "reading args" to
4192 "providing args" to try to clarify what it does (bug#1010).
4193
4194 2011-07-07 Kenichi Handa <handa@m17n.org>
4195
4196 * composite.c (composition_compute_stop_pos): Ignore a static
4197 composition starting before CHARPOS (Bug#8915).
4198
4199 * xdisp.c (handle_composition_prop): Likewise.
4200
4201 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4202
4203 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4204 (Bug#9015)
4205
4206 2011-07-07 Kenichi Handa <handa@m17n.org>
4207
4208 * character.h (unicode_category_t): New enum type.
4209
4210 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4211 (Qchar_code_property_table): New variable.
4212 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4213 (UNIPROP_COMPRESSED_FORM_P): New macros.
4214 (char_table_ascii): Uncompress the compressed values.
4215 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4216 Uncompress the compressed values.
4217 (sub_char_table_ref_and_range): Likewise.
4218 (char_table_ref_and_range): Uncompress the compressed values.
4219 (sub_char_table_set): New arg is_uniprop. Callers changed.
4220 Uncompress the compressed values.
4221 (sub_char_table_set_range): Args changed. Callers changed.
4222 (char_table_set_range): Adjuted for the above change.
4223 (map_sub_char_table): Delete args default_val and parent. Add arg
4224 top. Give decoded values to a Lisp function.
4225 (map_char_table): Adjust for the above change. Give decoded
4226 values to a Lisp function. Gcpro more variables.
4227 (uniprop_table_uncompress)
4228 (uniprop_decode_value_run_length): New functions.
4229 (uniprop_decoder, uniprop_decoder_count): New variables.
4230 (uniprop_get_decoder, uniprop_encode_value_character)
4231 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4232 New functions.
4233 (uniprop_encoder, uniprop_encoder_count): New variables.
4234 (uniprop_get_encoder, uniprop_table)
4235 (Funicode_property_table_internal, Fget_unicode_property_internal)
4236 (Fput_unicode_property_internal): New functions.
4237 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4238 Sunicode_property_table_internal, Sget_unicode_property_internal,
4239 and Sput_unicode_property_internal. Defvar_lisp
4240 char-code-property-alist.
4241
4242 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4243 Vunicode_category_table.
4244
4245 * font.c (font_range): Adjust for the change of
4246 Vunicode_category_table.
4247
4248 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4249
4250 * m/iris4d.h: Remove file, move contents ...
4251 * s/irix6-5.h: ... here.
4252
4253 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4254
4255 Remove unportable assumption about struct layout (Bug#8884).
4256 * alloc.c (mark_buffer):
4257 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4258 (clone_per_buffer_values): Don't assume that
4259 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4260 This isn't true in general, and it's particularly not true
4261 if Emacs is configured with --with-wide-int.
4262 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4263 New macros, used in the buffer.c change.
4264
4265 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4266
4267 * xsettings.c: Use both GConf and GSettings if both are available.
4268 (store_config_changed_event): Add comment.
4269 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4270 (store_tool_bar_style_changed): New functions.
4271 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4272 (struct xsettings): Move font inside HAVE_XFT.
4273 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4274 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4275 Move inside HAVE_XFT.
4276 (something_changed_gsettingsCB): Rename from something_changedCB.
4277 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4278 also.
4279 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4280 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4281 (something_changed_gconfCB): Rename from something_changedCB.
4282 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4283 (parse_settings): Move check for font inside HAVE_XFT.
4284 (read_settings, apply_xft_settings): Add comment.
4285 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4286 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4287 call store_font_name_changed.
4288 (xft_settings_event): Add comment.
4289 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4290 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4291 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4292 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4293 (xsettings_initialize): Call init_gsettings last.
4294 (xsettings_get_system_font, xsettings_get_system_normal_font):
4295 Add comment.
4296
4297 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4298
4299 Random fixes. E.g., (random) never returned negative values.
4300 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4301 subseconds part to the entropy, as that's a bit more random.
4302 Prefer signed to unsigned, since the signedness doesn't matter and
4303 in general we prefer signed. When given a limit, use a
4304 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4305 latter isn't right if USE_2_TAGS_FOR_INTS.
4306 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4307 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4308
4309 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4310
4311 * textprop.c (text_property_stickiness):
4312 Obey Vtext_property_default_nonsticky.
4313 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4314 * w32fns.c (syms_of_w32fns):
4315 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4316
4317 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4318
4319 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4320 This is more efficient than Ffile_directory_p and avoids a minor race.
4321
4322 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4323
4324 * buffer.c (Foverlay_put): Say what the return value is
4325 (bug#7835).
4326
4327 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4328 is a directory before asking whether to use the file name
4329 (bug#7564).
4330 (barf_or_query_if_file_exists): Make the "File is a directory"
4331 error be more correct.
4332
4333 * fns.c (Frequire): Remove the mention of the .gz files, since
4334 that's installation-specific, but keep the mention of
4335 `get-load-suffixes'.
4336
4337 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4338
4339 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4340 Report string overflow if the output is too long.
4341
4342 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4343
4344 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4345 (syms_of_gnutls): Remove duplicate DEFSYM for
4346 Qgnutls_bootprop_verify_hostname_error, an error for
4347 Qgnutls_bootprop_verify_error (which is no longer used).
4348
4349 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4350 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4351 Also (re)move comments that are misplaced or no longer relevant.
4352
4353 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4354
4355 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4356
4357 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4358
4359 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4360 and background color parameters if they have been changed.
4361
4362 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4363
4364 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4365
4366 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4367
4368 * xsettings.c (SYSTEM_FONT): Define only when used.
4369 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4370
4371 * keymap.c (access_keymap_1): Now static.
4372
4373 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4374
4375 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4376 leave any prefix arg for the up event (Bug#1586).
4377
4378 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4379
4380 * lread.c (syms_of_lread): Mention single symbols defined by
4381 `defvar' or `defconst' (bug#7154).
4382
4383 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4384 (Frequire): Mention get-load-suffixes.
4385
4386 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4387
4388 * window.h (window): Remove clone_number slot.
4389 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4390 Remove.
4391 (make_parent_window, make_window, saved_window)
4392 (Fset_window_configuration, save_window_save): Don't deal with
4393 clone numbers.
4394 * buffer.c (Qclone_number): Remove declaration.
4395 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4396
4397 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4398
4399 Add multiple inheritance to keymaps.
4400 * keymap.c (Fmake_composed_keymap): New function.
4401 (Fset_keymap_parent): Simplify.
4402 (fix_submap_inheritance): Remove.
4403 (access_keymap_1): New function extracted from access_keymap to handle
4404 embedded parents and handle lists of maps.
4405 (access_keymap): Use it.
4406 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4407 (Fcopy_keymap): Handle embedded parents.
4408 (Fcommand_remapping, define_as_prefix): Simplify.
4409 (Fkey_binding): Simplify.
4410 (syms_of_keymap): Move minibuffer-local-completion-map,
4411 minibuffer-local-filename-completion-map,
4412 minibuffer-local-must-match-map, and
4413 minibuffer-local-filename-must-match-map to Elisp.
4414 (syms_of_keymap): Defsubr make-composed-keymap.
4415 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4416 (parse_menu_item): Trivial simplification.
4417
4418 2011-07-01 Glenn Morris <rgm@gnu.org>
4419
4420 * Makefile.in (SETTINGS_LIBS): Fix typo.
4421
4422 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4423
4424 * coding.c (Fencode_coding_string): Record the last coding system
4425 used, as the function doc string says (bug#8738).
4426
4427 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4428
4429 * xsettings.c (store_monospaced_changed): Take new font as arg and
4430 check for change against current_mono_font.
4431 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4432 (emacs_settings_constructor, emacs_settings_get_property)
4433 (emacs_settings_set_property, emacs_settings_class_init)
4434 (emacs_settings_init, gsettings_obj): Remove.
4435 (something_changedCB): New function for HAVE_GSETTINGS.
4436 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4437 with value as argument.
4438 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4439 g_settings_new (Bug#8967). Do not create gsettings_obj.
4440 Remove calls to g_settings_bind. Connect something_changedCB to
4441 "changed".
4442
4443 * xgselect.c: Add defined (HAVE_GSETTINGS).
4444 (xgselect_initialize): Ditto.
4445
4446 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4447 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4448 xg_select.
4449
4450 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4451
4452 * eval.c (struct backtrace): Simplify and port the data structure.
4453 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4454 signed bit field, as this assumption is not portable and it makes
4455 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4456 "char debug_on_exit : 1" as this is not portable either; instead,
4457 use the portable "unsigned int debug_on_exit : 1". Remove unused
4458 member evalargs. Remove obsolete comments about cc bombing out.
4459
4460 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4461
4462 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4463 Let HAVE_GSETTINGS override HAVE_GCONF.
4464 (store_monospaced_changed): New function.
4465 (EMACS_SETTINGS): A new type derived from GObject to handle
4466 GSettings notifications.
4467 (emacs_settings_constructor, emacs_settings_get_property)
4468 (emacs_settings_set_property, emacs_settings_class_init):
4469 New functions.
4470 (gsettings_client, gsettings_obj): New variables.
4471 (GSETTINGS_SCHEMA): New define.
4472 (something_changedCB): Call store_monospaced_changed.
4473 (init_gsettings): New function.
4474 (xsettings_initialize): Call init_gsettings.
4475 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4476 to NULL.
4477
4478 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4479 GCONF_CFLAGS/LIBS.
4480
4481 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4482
4483 * window.c (resize_root_window, grow_mini_window)
4484 (shrink_mini_window): Rename Qresize_root_window to
4485 Qwindow_resize_root_window and Qresize_root_window_vertically to
4486 Qwindow_resize_root_window_vertically.
4487
4488 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4489
4490 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4491
4492 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4493
4494 * makefile.w32-in: Redesign dependencies so they reflect more
4495 clearly which files are directly included by each source file,
4496 and not through other includes.
4497
4498 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4499
4500 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4501 (sort_overlays, overlay_strings): When an overlay's clone number
4502 matches the window's clone number process the overlay even if
4503 the overlay's window property doesn't match the current window.
4504
4505 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4506 (Fwindow_hchild): Rename to Fwindow_left_child.
4507 (Fwindow_next): Rename to Fwindow_next_sibling.
4508 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4509 (resize_window_check): Rename to window_resize_check.
4510 (resize_window_apply): Rename to window_resize_apply.
4511 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4512 (Fdelete_other_windows_internal, resize_frame_windows)
4513 (Fsplit_window_internal, Fdelete_window_internal)
4514 (grow_mini_window, shrink_mini_window)
4515 (Fresize_mini_window_internal): Fix callers accordingly.
4516
4517 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4518
4519 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4520 (emacs_fixed_set_min_size): Remove.
4521 (emacs_fixed_new): Take frame as argument.
4522
4523 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4524 (_EmacsFixedPrivate): Remove minwidth/height.
4525 Add struct frame *f.
4526 (emacs_fixed_init): Initialize priv->f.
4527 (get_parent_class, emacs_fixed_set_min_size): Remove.
4528 (emacs_fixed_new): Set priv->f to argument.
4529 (emacs_fixed_get_preferred_width)
4530 (emacs_fixed_get_preferred_height): Use min_width/height from
4531 frames size_hint to set minimum and natural (Bug#8919).
4532 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4533 and use min_width/height from frames size_hint to set
4534 min_width/height (Bug#8919).
4535
4536 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4537 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4538 Fix indentation.
4539
4540 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4541
4542 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4543 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4544 called at ZV.
4545
4546 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4547
4548 * process.c (wait_reading_process_output): Bypass select if
4549 waiting for a cell while ignoring keyboard input, and input is
4550 pending. Suggested by Jan Djärv (Bug#8869).
4551
4552 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4553
4554 Use gnulib's dup2 module instead of rolling our own.
4555 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4556
4557 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4558
4559 * dispnew.c (scrolling_window): Before scrolling, turn off a
4560 mouse-highlight in the window being scrolled.
4561
4562 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4563
4564 Move DEFSYM to lisp.h and use everywhere.
4565
4566 * character.h (DEFSYM): Move declaration...
4567 * lisp.h (DEFSYM): ...here.
4568
4569 * gnutls.c:
4570 * minibuf.c:
4571 * w32menu.c:
4572 * w32proc.c:
4573 * w32select.c: Don't include character.h.
4574
4575 * alloc.c (syms_of_alloc):
4576 * buffer.c (syms_of_buffer):
4577 * bytecode.c (syms_of_bytecode):
4578 * callint.c (syms_of_callint):
4579 * casefiddle.c (syms_of_casefiddle):
4580 * casetab.c (init_casetab_once):
4581 * category.c (init_category_once, syms_of_category):
4582 * ccl.c (syms_of_ccl):
4583 * cmds.c (syms_of_cmds):
4584 * composite.c (syms_of_composite):
4585 * dbusbind.c (syms_of_dbusbind):
4586 * dired.c (syms_of_dired):
4587 * dispnew.c (syms_of_display):
4588 * doc.c (syms_of_doc):
4589 * editfns.c (syms_of_editfns):
4590 * emacs.c (syms_of_emacs):
4591 * eval.c (syms_of_eval):
4592 * fileio.c (syms_of_fileio):
4593 * fns.c (syms_of_fns):
4594 * frame.c (syms_of_frame):
4595 * fringe.c (syms_of_fringe):
4596 * insdel.c (syms_of_insdel):
4597 * keymap.c (syms_of_keymap):
4598 * lread.c (init_obarray, syms_of_lread):
4599 * macros.c (syms_of_macros):
4600 * msdos.c (syms_of_msdos):
4601 * print.c (syms_of_print):
4602 * process.c (syms_of_process):
4603 * search.c (syms_of_search):
4604 * sound.c (syms_of_sound):
4605 * syntax.c (init_syntax_once, syms_of_syntax):
4606 * terminal.c (syms_of_terminal):
4607 * textprop.c (syms_of_textprop):
4608 * undo.c (syms_of_undo):
4609 * w32.c (globals_of_w32):
4610 * window.c (syms_of_window):
4611 * xdisp.c (syms_of_xdisp):
4612 * xfaces.c (syms_of_xfaces):
4613 * xfns.c (syms_of_xfns):
4614 * xmenu.c (syms_of_xmenu):
4615 * xsettings.c (syms_of_xsettings):
4616 * xterm.c (syms_of_xterm): Use DEFSYM.
4617
4618 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4619
4620 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4621
4622 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4623
4624 Integer and buffer overflow fixes (Bug#8873).
4625
4626 * print.c (printchar, strout): Check for string overflow.
4627 (PRINTPREPARE, printchar, strout):
4628 Don't set size unless allocation succeeds.
4629
4630 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4631 for sizes. Check for string overflow more accurately.
4632 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4633
4634 * macros.c: Integer and buffer overflow fixes.
4635 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4636 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4637 Use ptrdiff_t, not int, for sizes.
4638 Don't increment bufsize until after realloc succeeds.
4639 Check for size-calculation overflow.
4640 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4641
4642 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4643
4644 * lread.c: Integer overflow fixes.
4645 (read_integer): Radix is now EMACS_INT, not int,
4646 to improve quality of diagnostics for out-of-range radices.
4647 Calculate buffer size correctly for out-of-range radices.
4648 (read1): Check for integer overflow in radices, and in
4649 read-circle numbers.
4650 (read_escape): Avoid int overflow.
4651 (Fload, openp, read_buffer_size, read1)
4652 (substitute_object_recurse, read_vector, read_list, map_obarray):
4653 Use ptrdiff_t, not int, for sizes.
4654 (read1): Use EMACS_INT, not int, for sizes.
4655 Check for size overflow.
4656
4657 * image.c (cache_image): Check for size arithmetic overflow.
4658
4659 * lread.c: Integer overflow issues.
4660 (saved_doc_string_size, saved_doc_string_length)
4661 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4662 Now ptrdiff_t, not int.
4663 (read1): Don't assume doc string length fits in int. Check for
4664 out-of-range doc string lengths.
4665 (read_list): Don't assume file position fits in int.
4666 (read_escape): Check for hex character overflow.
4667
4668 2011-06-22 Leo Liu <sdl.web@gmail.com>
4669
4670 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4671 Move to minibuffer.el.
4672
4673 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4674
4675 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4676 The following patches are for when GLYPH_DEBUG && !XASSERT.
4677 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4678 * dispnew.c (flush_stdout):
4679 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4680 Mark as externally visible.
4681 * dispnew.c (check_window_matrix_pointers): Now static.
4682 * dispnew.c (window_to_frame_vpos):
4683 * xfns.c (unwind_create_frame):
4684 * xterm.c (x_check_font): Remove unused local.
4685 * scroll.c (CHECK_BOUNDS):
4686 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4687 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4688 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4689 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4690 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4691 Now static.
4692 (debug_method_add): Use va_list and vsprintf rather than relying
4693 on undefined behavior with wrong number of arguments.
4694 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4695 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4696 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4697 since we're not interested in debugging glyphs with old libraries.
4698 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4699 GCC 4.6.0's static checking.
4700
4701 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4702
4703 Integer overflow and signedness fixes (Bug#8873).
4704 A few related buffer overrun fixes, too.
4705
4706 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4707
4708 * dispextern.h (struct face.stipple):
4709 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4710 (x_bitmap_mask, x_allocate_bitmap_record)
4711 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4712 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4713 (x_create_bitmap_from_xpm_data):
4714 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4715 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4716 (.bitmaps_last):
4717 * xfaces.c (load_pixmap):
4718 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4719 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4720 (.bitmaps_last, struct x_output.icon_bitmap):
4721 Use ptrdiff_t, not int, for bitmap indexes.
4722 (x_allocate_bitmap_record): Check for size overflow.
4723 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4724
4725 Use ptrdiff_t, not int, for overlay counts.
4726 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4727 * editfns.c (overlays_around, get_pos_property):
4728 * textprop.c (get_char_property_and_overlay):
4729 * xdisp.c (next_overlay_change, note_mouse_highlight):
4730 * xfaces.c (face_at_buffer_position):
4731 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4732 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4733 (Fnext_overlay_change, Fprevious_overlay_change)
4734 (mouse_face_overlay_overlaps, Foverlays_in):
4735 Use ptrdiff_t, not int, for sizes.
4736 (overlays_at, overlays_in): Check for size-calculation overflow.
4737
4738 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4739
4740 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4741 (x_session_initialize): Do not assume string length fits in int.
4742
4743 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4744 This is unlikely, but can occur if DPI is outlandish.
4745
4746 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4747 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4748
4749 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4750 * xrdb.c (magic_file_p, search_magic_path):
4751 Omit last arg SUFFIX; it was always 0. All callers changed.
4752 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4753
4754 * xfont.c (xfont_match): Avoid need for strlen.
4755
4756 * xfns.c: Don't assume strlen fits in int.
4757 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4758
4759 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4760 not unsigned long, as we prefer signed integers. All callers changed.
4761 Detect integer overflow in repeat count.
4762 (message_dolog): Don't assume print length fits in 39 bytes.
4763 (display_mode_element): Don't assume strlen fits in int.
4764
4765 * termcap.c: Don't assume sizes fit in int and never overflow.
4766 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4767 (gobble_line): Check for size-calculation overflow.
4768
4769 * minibuf.c (Fread_buffer):
4770 * lread.c (intern, intern_c_string):
4771 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4772 Don't assume string length fits in int.
4773
4774 * keyboard.c (parse_tool_bar_item):
4775 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4776
4777 * font.c: Don't assume string length fits in int.
4778 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4779 Use ptrdiff_t, not int.
4780 (font_intern_prop): Don't assume string length fits in int.
4781 Don't assume integer property fits in fixnum.
4782 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4783
4784 * filelock.c: Fix some buffer overrun and integer overflow issues.
4785 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4786 Reformulate so as not to need the command string.
4787 Invoke gzip -cd rather than gunzip, as it's more portable.
4788 (lock_info_type, lock_file_1, lock_file):
4789 Don't assume pid_t and time_t fit in unsigned long.
4790 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4791 (current_lock_owner): Prefer signed type for sizes.
4792 Use memcpy, not strncpy, where memcpy is what is really wanted.
4793 Don't assume (via atoi) that time_t and pid_t fit in int.
4794 Check for time_t and/or pid_t out of range, e.g., via a network share.
4795 Don't alloca where an auto var works fine.
4796
4797 * fileio.c: Fix some integer overflow issues.
4798 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4799 Don't assume string length fits in int.
4800 (directory_file_name): Don't assume string length fits in long.
4801 (make_temp_name): Don't assume pid fits in int, or that its print
4802 length is less than 20.
4803
4804 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4805
4806 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4807
4808 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4809
4810 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4811 We prefer signed integers, even for size calculations.
4812
4813 * emacs.c: Don't assume string length fits in 'int'.
4814 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4815 (main): Don't invoke strlen when not needed.
4816
4817 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4818 (XD_DEBUG_MESSAGE): Don't waste a byte.
4819
4820 * callproc.c (getenv_internal_1, getenv_internal)
4821 (Fgetenv_internal):
4822 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4823
4824 * lread.c (invalid_syntax): Omit length argument.
4825 All uses changed. This doesn't fix a bug, but it simplifies the
4826 code away from its former Hollerith-constant appearance, and it's
4827 one less 'int' to worry about when looking at integer-overflow issues.
4828 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4829
4830 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4831 This didn't break anything, but it didn't help either.
4832 It's confusing to put a bogus integer in a place where the actual
4833 value does not matter.
4834 (LIST_END_P): Remove unused macro and its bogus comment.
4835 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4836
4837 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4838 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4839 implementation.
4840 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4841 We prefer signed types, and the value cannot exceed the EMACS_INT
4842 range anyway (because otherwise the length would not be representable).
4843 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4844 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4845 This avoids a GCC warning when WIDE_EMACS_INT.
4846
4847 * indent.c (sane_tab_width): New function.
4848 (current_column, scan_for_column, Findent_to, position_indentation)
4849 (compute_motion): Use it. This is just for clarity.
4850 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4851
4852 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4853
4854 * lisp.h (lint_assume): New macro.
4855 * composite.c (composition_gstring_put_cache):
4856 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4857
4858 * editfns.c, insdel.c:
4859 Omit unnecessary forward decls, to simplify future changes.
4860
4861 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4862
4863 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4864
4865 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4866 Use much-faster test for byte-length change.
4867 Don't assume string byte-length fits in 'int'.
4868 Check that character arg fits in 'int'.
4869 (mapcar1): Declare byte as byte, for clarity.
4870
4871 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4872
4873 * fns.c (concat): Catch string overflow earlier.
4874 Do not rely on integer wraparound.
4875
4876 * dispextern.h (struct it.overlay_strings_charpos)
4877 (struct it.selective): Now EMACS_INT, not int.
4878 * xdisp.c (forward_to_next_line_start)
4879 (back_to_previous_visible_line_start)
4880 (reseat_at_next_visible_line_start, next_element_from_buffer):
4881 Don't arbitrarily truncate the value of 'selective' to int.
4882
4883 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4884
4885 * composite.c: Don't truncate sizes to 'int'.
4886 (composition_gstring_p, composition_reseat_it)
4887 (composition_adjust_point): Use EMACS_INT, not int.
4888 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4889 not EMACS_UINT, for indexes.
4890
4891 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4892
4893 * buffer.c: Include <verify.h>.
4894 (struct sortvec.priority, struct sortstr.priority):
4895 Now EMACS_INT, not int.
4896 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4897 (struct sortstr.size, record_overlay_string)
4898 (struct sortstrlist.size, struct sortlist.used):
4899 Don't truncate size to int.
4900 (record_overlay_string): Check for size-calculation overflow.
4901 (init_buffer_once): Check at compile-time, not run-time.
4902
4903 2011-06-22 Jim Meyering <meyering@redhat.com>
4904
4905 Don't leak an XBM-image-sized buffer
4906 * image.c (xbm_load): Free the image buffer after using it.
4907
4908 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4909
4910 Port to Sun C.
4911 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4912 that Sun C diagnosed.
4913 * fns.c (secure_hash): Fix pointer signedness issue.
4914 * intervals.c (static_offset_intervals): New function.
4915 (offset_intervals): Use it.
4916
4917 2011-06-21 Leo Liu <sdl.web@gmail.com>
4918
4919 * deps.mk (fns.o):
4920 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4921 sha512.h.
4922
4923 * fns.c (secure_hash): Rename from crypto_hash_function and change
4924 the first arg to accept symbols.
4925 (Fsecure_hash): New primitive.
4926 (syms_of_fns): New symbols.
4927
4928 2011-06-20 Deniz Dogan <deniz@dogan.se>
4929
4930 * process.c (Fset_process_buffer): Clarify return value in
4931 docstring.
4932
4933 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4934
4935 * dispnew.c (add_window_display_history): Use BVAR.
4936
4937 * xdisp.c (debug_method_add): Use BVAR.
4938 (check_window_end, dump_glyph_matrix, dump_glyph)
4939 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4940
4941 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4942 Likewise.
4943
4944 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4945 check till after the cache is created in init_frame_faces.
4946
4947 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4948
4949 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4950
4951 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4952
4953 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4954 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4955 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4956
4957 Improve buffer-overflow checking (Bug#8873).
4958 * fileio.c (Finsert_file_contents):
4959 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4960 Remove the old (too-loose) buffer overflow checks.
4961 They weren't needed, since make_gap checks for buffer overflow.
4962 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4963 The old code merely checked for Emacs fixnum overflow, and relied
4964 on undefined (wraparound) behavior. The new code avoids undefined
4965 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4966
4967 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4968 Tune. Don't use wider integers than needed. Don't use alloca.
4969 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4970
4971 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4972
4973 * insdel.c, lisp.h (buffer_overflow): New function.
4974 (insert_from_buffer_1, replace_range, replace_range_2):
4975 * insdel.c (make_gap_larger):
4976 * editfns.c (Finsert_char):
4977 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4978
4979 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4980
4981 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4982
4983 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4984
4985 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4986 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4987
4988 * fileio.c: Don't assume EMACS_INT fits in off_t.
4989 (emacs_lseek): New static function.
4990 (Finsert_file_contents, Fwrite_region): Use it.
4991 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4992
4993 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4994
4995 * fns.c: Don't overflow int when computing a list length.
4996 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4997 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4998 truncation on 64-bit hosts. Check for QUIT every
4999 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5000 faster and is responsive enough.
5001 (Flength): Report an error instead of overflowing an integer.
5002 (Fsafe_length): Return a float if the value is not representable
5003 as a fixnum. This shouldn't happen except in contrived situations.
5004 (Fnthcdr, Fsort): Don't assume list length fits in int.
5005 (Fcopy_sequence): Don't assume vector length fits in int.
5006
5007 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5008 (header_size, word_size): New constants.
5009 (allocate_vectorlike): Don't check size overflow here.
5010 (allocate_vector): Check it here instead, since this is the only
5011 caller of allocate_vectorlike that could cause overflow.
5012 Check that the new vector's length is representable as a fixnum.
5013
5014 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5015 The previous code was bogus. For example, next_almost_prime (32)
5016 returned 39, which is undesirable as it is a multiple of 3; and
5017 next_almost_prime (24) returned 25, which is a multiple of 5 so
5018 why was the code bothering to check for multiples of 7?
5019
5020 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5021
5022 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5023
5024 Variadic C functions now count arguments with ptrdiff_t.
5025 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5026 Back then I didn't know that the Emacs coding style prefers signed int.
5027 Also, in the meantime I found a few more instances where arguments
5028 were being counted with int, which may truncate counts on 64-bit
5029 machines, or EMACS_INT, which may be unnecessarily wide.
5030 * lisp.h (struct Lisp_Subr.function.aMANY)
5031 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5032 Arg counts are now ptrdiff_t, not size_t.
5033 All variadic functions and their callers changed accordingly.
5034 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5035 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5036 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5037 * callint.c (Fcall_interactively): Check arg count for overflow,
5038 to avoid potential buffer overrun. Use signed char, not 'int',
5039 for 'varies' array, so that we needn't bother to check its size
5040 calculation for overflow.
5041 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5042 * eval.c (apply_lambda):
5043 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5044 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5045 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5046
5047 * callint.c (Fcall_interactively): Don't use index var as event count.
5048
5049 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5050 * mem-limits.h (SIZE): Remove; no longer used.
5051
5052 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5053
5054 Remove unnecessary casts.
5055 * xterm.c (x_term_init):
5056 * xfns.c (x_set_border_pixel):
5057 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5058 These aren't needed now that we assume ANSI C.
5059
5060 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5061 It's more likely to cause problems (due to unsigned overflow)
5062 than to cure them.
5063
5064 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5065
5066 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5067
5068 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5069
5070 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5071
5072 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5073
5074 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5075
5076 GLYPH_CODE_FACE returns EMACS_INT, not int.
5077 * dispextern.h (merge_faces):
5078 * xfaces.c (merge_faces):
5079 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5080 Don't assume EMACS_INT fits in int.
5081
5082 * character.h (CHAR_VALID_P): Remove unused parameter.
5083 * fontset.c, lisp.h, xdisp.c: All uses changed.
5084
5085 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5086
5087 * fns.c (concat): Minor tuning based on overflow analysis.
5088 This doesn't fix any bugs. Use int to hold character, instead
5089 of constantly refetching from Emacs object. Use XFASTINT, not
5090 XINT, for value known to be a character. Don't bother comparing
5091 a single byte to 0400, as it's always less.
5092
5093 * floatfns.c (Fexpt):
5094 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5095
5096 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5097 for characters.
5098
5099 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5100
5101 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5102 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5103 incorrectly succeed when S was a string, because 4294967386 was
5104 truncated before it was used.
5105
5106 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5107 Otherwise, an out-of-range integer could cause undefined behavior
5108 on a 64-bit host.
5109
5110 * composite.c: Use int, not EMACS_INT, for characters.
5111 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5112 EMACS_INT, for values that are known to be in character range.
5113 This doesn't fix any bugs but is the usual style inside Emacs and
5114 may generate better code on 32-bit machines.
5115
5116 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5117 This is for reasons similar to the recent CHAR_STRING fix.
5118 * charset.c (Fencode_char): Check that character arg is actually
5119 a character. Pass an int to ENCODE_CHAR.
5120 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5121 wider than 'int', as a compile-time check to prevent future regressions
5122 in this area.
5123
5124 * character.c (char_string): Remove unnecessary casts.
5125
5126 Make sure a 64-bit char is never passed to CHAR_STRING.
5127 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5128 by silently ignoring the top 32 bits, allowing some values
5129 that were far too large to be valid characters.
5130 * character.h: Include <verify.h>.
5131 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5132 arguments are no wider than unsigned, as a compile-time check
5133 to prevent future regressions in this area.
5134 * data.c (Faset):
5135 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5136 (Fsubst_char_in_region):
5137 * fns.c (concat):
5138 * xdisp.c (decode_mode_spec_coding):
5139 Adjust to CHAR_STRING's new requirement.
5140 * editfns.c (Finsert_char, Fsubst_char_in_region):
5141 * fns.c (concat): Check that character args are actually
5142 characters. Without this test, these functions did the wrong
5143 thing with wildly out-of-range values on 64-bit hosts.
5144
5145 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5146 These casts should not be needed on 32-bit hosts, either.
5147 * keyboard.c (read_char):
5148 * lread.c (Fload): Remove casts to unsigned.
5149
5150 * lisp.h (UNSIGNED_CMP): New macro.
5151 This fixes comparison bugs on 64-bit hosts.
5152 (ASCII_CHAR_P): Use it.
5153 * casefiddle.c (casify_object):
5154 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5155 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5156 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5157 * dispextern.h (FACE_FROM_ID):
5158 * keyboard.c (read_char): Use UNSIGNED_CMP.
5159
5160 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5161 not to EMACS_INT, to avoid GCC warning.
5162
5163 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5164
5165 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5166 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5167 isn't needed on 32-bit machines.
5168
5169 * buffer.c (Fgenerate_new_buffer_name):
5170 Use EMACS_INT for count, not int.
5171 (advance_to_char_boundary): Return EMACS_INT, not int.
5172
5173 * data.c (Qcompiled_function): Now static.
5174
5175 * window.c (window_body_lines): Now static.
5176
5177 * image.c (gif_load): Rename local to avoid shadowing.
5178
5179 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5180 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5181 * alloc.c (make_save_value): Integer argument is now of type
5182 ptrdiff_t, not int.
5183 (mark_object): Use ptrdiff_t, not int.
5184 * lisp.h (pD): New macro.
5185 * print.c (print_object): Use it.
5186
5187 * alloc.c: Use EMACS_INT, not int, to count objects.
5188 (total_conses, total_markers, total_symbols, total_vector_size)
5189 (total_free_conses, total_free_markers, total_free_symbols)
5190 (total_free_floats, total_floats, total_free_intervals)
5191 (total_intervals, total_strings, total_free_strings):
5192 Now EMACS_INT, not int. All uses changed.
5193 (Fgarbage_collect): Compute overall total using a double, so that
5194 integer overflow is less likely to be a problem. Check for overflow
5195 when converting back to an integer.
5196 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5197 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5198 These were 'int' variables that could overflow on 64-bit hosts;
5199 they were never used, so remove them instead of repairing them.
5200 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5201 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5202 Previously, this ceilinged at INT_MAX, but that doesn't work on
5203 64-bit machines.
5204 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5205
5206 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5207 (allocate_vectorlike): Check for ptrdiff_t overflow.
5208 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5209 when a (possibly-narrower) signed value would do just as well.
5210 We prefer using signed arithmetic, to avoid comparison confusion.
5211
5212 * alloc.c: Catch some string size overflows that we were missing.
5213 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5214 for convenience in STRING_BYTES_MAX.
5215 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5216 The definition here is exact; the one in lisp.h was approximate.
5217 (allocate_string_data): Check for string overflow. This catches
5218 some instances we weren't catching before. Also, it catches
5219 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5220 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5221 and ptrdiff_t and EMACS_INT are both 64 bits.
5222
5223 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5224 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5225 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5226
5227 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5228
5229 * alloc.c (Fmake_string): Check for out-of-range init.
5230
5231 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5232
5233 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5234
5235 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5236
5237 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5238 xg_get_default_scrollbar_width.
5239
5240 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5241 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5242 (style_changed_cb): Call update_theme_scrollbar_width and call
5243 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5244 all frames (Bug#8505).
5245 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5246 Call gtk_window_set_resizable if HAVE_GTK3.
5247 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5248 and height if HAVE_GTK3 (Bug#8505).
5249 (scroll_bar_width_for_theme): New variable.
5250 (update_theme_scrollbar_width): New function.
5251 (xg_get_default_scrollbar_width): Move code to
5252 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5253 (xg_initialize): Call update_theme_scrollbar_width.
5254
5255 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5256
5257 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5258
5259 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5260
5261 * frame.c (make_frame): Call other_buffer_safely instead of
5262 other_buffer.
5263
5264 * window.c (temp_output_buffer_show): Call display_buffer with
5265 second argument Vtemp_buffer_show_specifiers and reset latter
5266 immediately after the call.
5267 (Vtemp_buffer_show_specifiers): New variable.
5268 (auto_window_vscroll_p, next_screen_context_lines)
5269 (Vscroll_preserve_screen_position): Remove leading asterisks from
5270 doc-strings.
5271
5272 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5273
5274 Fix minor problems found by GCC 4.6.0 static checking.
5275 * buffer.c (Qclone_number): Remove for now, as it's unused.
5276 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5277 (record_buffer): Remove unused local.
5278 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5279 (set_frame_buffer_list): Remove; unused.
5280 * frame.h (other_visible_frames): Remove decl.
5281 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5282 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5283 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5284 if HAVE_GPM.
5285 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5286 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5287 Define only if HAVE_GPM.
5288 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5289 (update_hints_inhibit): Remove; never set. All uses removed.
5290 * widgetprv.h (emacsFrameClassRec): Remove decl.
5291 * window.c (delete_deletable_window): Now returns void, since it
5292 wasn't returning anything.
5293 (compare_window_configurations): Remove unused locals.
5294 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5295 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5296 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5297 the same widths as pointers. This follows up on the 2011-05-06 patch.
5298 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5299 * xterm.h: Likewise.
5300 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5301
5302 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5303
5304 * makefile.w32-in: Update dependencies.
5305 (LISP_H): Add lib/intprops.h.
5306
5307 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5308
5309 * image.c (gif_load): Add animation frame delay to the metadata.
5310 (syms_of_image): Use DEFSYM. New symbol `delay'.
5311
5312 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5313
5314 * window.c (delete_deletable_window): Re-add.
5315 (Fset_window_configuration): Rewrite to handle dead buffers and
5316 consequently deletable windows.
5317 (window_tree, Fwindow_tree): Remove. Supply functionality in
5318 window.el.
5319 (compare_window_configurations): Simplify code.
5320
5321 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5322
5323 * image.c (imagemagick_load_image): Fix type mismatch.
5324 (Fimagemagick_types): Likewise.
5325
5326 * window.h (replace_buffer_in_windows): Declare.
5327
5328 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5329
5330 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5331 Qclone_number. Remove external declaration of Qdelete_window.
5332 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5333 code.
5334 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5335 Run Qbuffer_list_update_hook if allowed.
5336 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5337 buffer list implementation.
5338 (other_buffer_safely): New function.
5339 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5340 calls to replace_buffer_in_windows and
5341 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5342 if allowed.
5343 (record_buffer): Inhibit quitting and rewrite using quittable
5344 functions. Run Qbuffer_list_update_hook if allowed.
5345 (Frecord_buffer, Funrecord_buffer): New functions.
5346 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5347 Move switch-to-buffer to window.el.
5348 (bury-buffer): Move to window.el.
5349 (Vbuffer_list_update_hook): New variable.
5350
5351 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5352 section.
5353
5354 * window.h (resize_frame_windows): Move up in code.
5355 (Fwindow_frame): Remove EXFUN.
5356 (replace_buffer_in_all_windows): Remove prototype.
5357 (replace_buffer_in_windows_safely): Add prototype.
5358
5359 * window.c: Declare Qdelete_window static again. Move down
5360 declaration of select_count.
5361 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5362 (Fother_window): Move to window.el.
5363 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5364 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5365 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5366 window.el.
5367 (replace_buffer_in_windows): Implement by calling
5368 Qreplace_buffer_in_windows.
5369 (replace_buffer_in_all_windows): Remove with some functionality
5370 moved into replace_buffer_in_windows_safely.
5371 (replace_buffer_in_windows_safely): New function.
5372 (select_window_norecord, select_frame_norecord): Move in front
5373 of run_window_configuration_change_hook. Remove now obsolete
5374 declarations.
5375 (Fset_window_buffer): Rewrite doc-string.
5376 Call Qrecord_window_buffer.
5377 (keys_of_window): Move binding for other-window to window.el.
5378
5379 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5380
5381 * dispextern.h (struct image): Replace data member, whose int_val
5382 and ptr_val fields were not used by anything, with a single
5383 lisp_val object.
5384
5385 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5386 (gif_clear_image, gif_load, imagemagick_load_image)
5387 (gs_clear_image, gs_load): Callers changed.
5388
5389 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5390
5391 * buffer.h: Include <time.h>, for time_t.
5392 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5393
5394 Fix minor problems found by static checking.
5395
5396 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5397
5398 Make identifiers static if they are not used in other modules.
5399 * data.c (Qcompiled_function, Qframe, Qvector):
5400 * image.c (QimageMagick, Qsvg):
5401 * minibuf.c (Qmetadata):
5402 * window.c (resize_window_check, resize_root_window): Now static.
5403 * window.h (resize_window_check, resize_root_window): Remove decls.
5404
5405 * window.c (window_deletion_count, delete_deletable_window):
5406 Remove; unused.
5407 (window_body_lines): Now static.
5408 (Fdelete_other_windows_internal): Mark vars as initialized.
5409 Make sure 'resize_failed' is initialized.
5410 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5411 (resize_window_apply): Remove unused local.
5412 * window.h (delete_deletable_window): Remove decl.
5413
5414 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5415 (imagemagick_load_image): Fix pointer signedness problem by changing
5416 last arg from unsigned char * to char *. All uses changed.
5417 Also, fix a local for similar reasons.
5418 Remove unused locals. Remove locals to avoid shadowing.
5419 (fn_rsvg_handle_free): Remove; unused.
5420 (svg_load, svg_load_image): Fix pointer signedness problem.
5421 (imagemagick_load_image): Don't use garbage pointer image_wand.
5422
5423 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5424
5425 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5426
5427 * image.c (gif_load): Fix omitted cast error introduced by
5428 2011-06-06 change.
5429
5430 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5431
5432 * window.h (resize_proportionally, orig_total_lines)
5433 (orig_top_line): Remove from window structure.
5434 (set_window_height, set_window_width, change_window_heights)
5435 (Fdelete_window): Remove prototypes.
5436 (resize_frame_windows): Remove duplicate declaration.
5437
5438 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5439
5440 * window.h (resize_frame_windows, resize_window_check)
5441 (delete_deletable_window, resize_root_window)
5442 (resize_frame_windows): Declare prototypes.
5443
5444 * window.c (resize_window_apply): Make definition be "static" to
5445 match the prototype.
5446
5447 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5448
5449 * window.c: Remove declarations of Qwindow_size_fixed,
5450 window_min_size_1, window_min_size_2, window_min_size,
5451 size_window, window_fixed_size_p, enlarge_window, delete_window.
5452 Remove static from declaration of Qdelete_window, it's
5453 temporarily needed by Fbury_buffer.
5454 (replace_window): Don't assign orig_top_line and
5455 orig_total_lines.
5456 (Fdelete_window, delete_window): Remove. Window deletion is
5457 handled by window.el.
5458 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5459 Replace Fdelete_window calls with calls to Qdelete_window.
5460 (Fdelete_other_windows): Remove. Deleting other windows is
5461 handled by window.el.
5462 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5463 handled in window.el.
5464 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5465 Window minimum sizes are handled in window.el.
5466 (shrink_windows, size_window, set_window_height)
5467 (set_window_width, change_window_heights, window_height)
5468 (window_width, CURBEG, CURSIZE, enlarge_window)
5469 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5470 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5471 handled in window.el.
5472 (make_dummy_parent): Rename to make_parent_window and give it a
5473 second argument horflag.
5474 (make_window): Don't set resize_proportionally any more.
5475 (Fsplit_window): Remove. Windows are split in window.el.
5476 (save_restore_action, save_restore_orig_size)
5477 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5478 Resize mini windows in window.el.
5479 (grow_mini_window, shrink_mini_window): Implement by calling
5480 Qresize_root_window_vertically, resize_window_check and
5481 resize_window_apply.
5482 (saved_window, Fset_window_configuration, save_window_save):
5483 Do not handle orig_top_line, orig_total_lines, and
5484 resize_proportionally.
5485 (window_min_height, window_min_width): Move to window.el.
5486 (keys_of_window): Move bindings for delete-other-windows,
5487 split-window, delete-window and enlarge-window to window.el.
5488
5489 * buffer.c: Temporarily extern Qdelete_window.
5490 (Fbury_buffer): Temporarily call Qdelete_window instead of
5491 Fdelete_window (Fbury_buffer will move to window.el soon).
5492
5493 * frame.c (set_menu_bar_lines_1): Remove code handling
5494 orig_top_line and orig_total_lines.
5495
5496 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5497 set_window_height but set heights directly.
5498 (change_frame_size_1): Use resize_frame_windows.
5499
5500 * xdisp.c (init_xdisp): Don't use set_window_height but set
5501 heights directly.
5502
5503 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5504 Use resize_frame_windows instead of change_window_heights and run
5505 run_window_configuration_change_hook.
5506
5507 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5508 instead of change_window_heights and run
5509 run_window_configuration_change_hook.
5510
5511 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5512
5513 * window.c (replace_window): Rename second argument REPLACEMENT to
5514 NEW. New third argument SETFLAG. Rewrite.
5515 (delete_window, make_dummy_parent): Call replace_window with
5516 third argument 1.
5517 (window_list_1): Move down in code.
5518 (run_window_configuration_change_hook): Move set_buffer part
5519 before select_frame_norecord part in order to unwind correctly.
5520 Rename count1 to count.
5521 (recombine_windows, delete_deletable_window, resize_root_window)
5522 (Fdelete_other_windows_internal)
5523 (Frun_window_configuration_change_hook, make_parent_window)
5524 (resize_window_check, resize_window_apply, Fresize_window_apply)
5525 (resize_frame_windows, Fsplit_window_internal)
5526 (Fdelete_window_internal, Fresize_mini_window_internal):
5527 New functions.
5528 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5529
5530 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5531
5532 * window.h (window): Add some new members to window structure -
5533 normal_lines, normal_cols, new_total, new_normal, clone_number,
5534 splits, nest, prev_buffers, next_buffers.
5535 (WINDOW_TOTAL_SIZE): Move here from window.c.
5536 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5537
5538 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5539 Remove.
5540 (make_dummy_parent): Set new members of windows structure.
5541 (make_window): Move down in code. Handle new members of window
5542 structure.
5543 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5544 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5545 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5546 (Fset_window_prev_buffers, Fwindow_next_buffers)
5547 (Fset_window_next_buffers, Fset_window_clone_number):
5548 New functions.
5549 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5550 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5551 Doc-string fixes.
5552 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5553 Argument WINDOW can be now internal window too.
5554 (Fwindow_use_time): Move up in code.
5555 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5556 Rewrite doc-string.
5557 (Fset_window_configuration, saved_window)
5558 (Fcurrent_window_configuration, save_window_save): Handle new
5559 members of window structure.
5560 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5561 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5562 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5563 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5564 Qget_mru_window, Qresize_root_window,
5565 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5566 Qauto_buffer_name; staticpro them.
5567
5568 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5569
5570 * window.c (Fwindow_total_size, Fwindow_left_column)
5571 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5572 (Fwindow_list_1): New functions.
5573 (window_box_text_cols): Replace with window_body_cols.
5574 (Fwindow_width, Fscroll_left, Fscroll_right):
5575 Use window_body_cols instead of window_box_text_cols.
5576 (delete_window, Fset_window_configuration):
5577 Call delete_all_subwindows with window as argument.
5578 (delete_all_subwindows): Take a window as argument and not a
5579 structure. Rewrite.
5580 (window_loop): Remove handling of GET_LRU_WINDOW and
5581 GET_LARGEST_WINDOW.
5582 (Fget_lru_window, Fget_largest_window): Move to window.el.
5583
5584 * window.h: Extern window_body_cols instead of
5585 window_box_text_cols. delete_all_subwindows now takes a
5586 Lisp_Object as argument.
5587
5588 * indent.c (compute_motion, Fcompute_motion):
5589 Use window_body_cols instead of window_box_text_cols.
5590
5591 * frame.c (delete_frame): Call delete_all_subwindows with root
5592 window as argument.
5593
5594 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5595
5596 * fns.c (Fputhash): Document return value.
5597
5598 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5599
5600 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5601
5602 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5603
5604 Cons<->int and similar integer overflow fixes (Bug#8794).
5605
5606 Check for overflow when converting integer to cons and back.
5607 * charset.c (Fdefine_charset_internal, Fdecode_char):
5608 Use cons_to_unsigned to catch overflow.
5609 (Fencode_char): Use INTEGER_TO_CONS.
5610 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5611 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5612 * data.c (long_to_cons, cons_to_long): Remove.
5613 (cons_to_unsigned, cons_to_signed): New functions.
5614 These signal an error for invalid or out-of-range values.
5615 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5616 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5617 * font.c (Ffont_variation_glyphs):
5618 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5619 * lisp.h: Include <intprops.h>.
5620 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5621 (cons_to_signed, cons_to_unsigned): New decls.
5622 (long_to_cons, cons_to_long): Remove decls.
5623 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5624 (Fprimitive_undo): Use CONS_TO_INTEGER.
5625 * xfns.c (Fx_window_property): Likewise.
5626 * xselect.c: Include <limits.h>.
5627 (x_own_selection, selection_data_to_lisp_data):
5628 Use INTEGER_TO_CONS.
5629 (x_handle_selection_request, x_handle_selection_clear)
5630 (x_get_foreign_selection, Fx_disown_selection_internal)
5631 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5632 (lisp_data_to_selection_data): Use cons_to_unsigned.
5633 (x_fill_property_data): Use cons_to_signed.
5634 Report values out of range.
5635
5636 Check for buffer and string overflow more precisely.
5637 * buffer.h (BUF_BYTES_MAX): New macro.
5638 * lisp.h (STRING_BYTES_MAX): New macro.
5639 * alloc.c (Fmake_string):
5640 * character.c (string_escape_byte8):
5641 * coding.c (coding_alloc_by_realloc):
5642 * doprnt.c (doprnt):
5643 * editfns.c (Fformat):
5644 * eval.c (verror):
5645 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5646 since they may not be the same number.
5647 * editfns.c (Finsert_char):
5648 * fileio.c (Finsert_file_contents):
5649 Likewise for BUF_BYTES_MAX.
5650
5651 * image.c: Use ptrdiff_t, not int, for sizes.
5652 (slurp_file): Switch from int to ptrdiff_t.
5653 All uses changed.
5654 (slurp_file): Check that file size fits in both size_t (for
5655 malloc) and ptrdiff_t (for sanity and safety).
5656
5657 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5658 if b->modtime has its maximal value.
5659
5660 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5661
5662 Don't assume time_t can fit into int.
5663 * buffer.h (struct buffer.modtime): Now time_t, not int.
5664 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5665 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5666
5667 Minor fixes for signed vs unsigned integers.
5668 * character.h (MAYBE_UNIFY_CHAR):
5669 * charset.c (maybe_unify_char):
5670 * keyboard.c (read_char, reorder_modifiers):
5671 XINT -> XFASTINT, since the integer must be nonnegative.
5672 * ftfont.c (ftfont_spec_pattern):
5673 * keymap.c (access_keymap, silly_event_symbol_error):
5674 XUINT -> XFASTINT, since the integer must be nonnegative.
5675 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5676 since it makes no difference and we prefer signed.
5677 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5678 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5679 nonnegative.
5680
5681 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5682
5683 * window.h (Fwindow_frame): Declare.
5684
5685 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5686
5687 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5688 (SPARE_MEMORY): Always define.
5689 (LARGE_REQUEST): Remove.
5690 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5691
5692 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5693
5694 * lisp.h: Move EXFUNS for Fframe_root_window,
5695 Fframe_first_window and Fset_frame_selected_window to window.h.
5696
5697 * window.h: Move EXFUNS for Fframe_root_window,
5698 Fframe_first_window and Fset_frame_selected_window here from
5699 lisp.h.
5700
5701 * frame.c (Fwindow_frame, Fframe_first_window)
5702 (Fframe_root_window, Fframe_selected_window)
5703 (Fset_frame_selected_window): Move to window.c.
5704 (Factive_minibuffer_window): Move to minibuf.c.
5705 (Fother_visible_frames_p): New function.
5706
5707 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5708
5709 * window.c (decode_window, decode_any_window): Move up in code.
5710 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5711 (inhibit_frame_unsplittable): Remove unused variable.
5712 (Fwindow_buffer): Move up and rewrite doc-string.
5713 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5714 (Fwindow_prev): New functions.
5715 (Fwindow_frame): Move here from frame.c. Accept any window as
5716 argument.
5717 (Fframe_root_window, Fframe_first_window)
5718 (Fframe_selected_window): Move here from frame.c. Accept frame
5719 or arbitrary window as argument. Update doc-strings.
5720 (Fminibuffer_window): Move up in code.
5721 (Fwindow_minibuffer_p): Move up in code and simplify.
5722 (Fset_frame_selected_window): Move here from frame.c.
5723 Marginal rewrite.
5724 (Fselected_window, select_window, Fselect_window): Move up in
5725 code. Minor doc-string fixes.
5726
5727 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5728
5729 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5730 Do not assume that spare memory exists; that assumption is valid
5731 only if SYSTEM_MALLOC.
5732 (LARGE_REQUEST): New macro, so that the issue of large requests
5733 is separated from the issue of spare memory.
5734
5735 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5736
5737 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5738 format. (Bug#8806)
5739
5740 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5741
5742 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5743 before statements.
5744
5745 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5746
5747 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5748
5749 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5750
5751 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5752 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5753
5754 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5755
5756 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5757
5758 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5759
5760 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5761 (x_clipboard_manager_save): Add return value.
5762 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5763 New error handlers.
5764 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5765 Obey Vx_select_enable_clipboard_manager. Catch errors in
5766 x_clipboard_manager_save (Bug#8779).
5767 (Vx_select_enable_clipboard_manager): New variable.
5768 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5769
5770 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5771
5772 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5773
5774 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5775
5776 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5777 in the current matrix if keep_current_p is non-zero.
5778
5779 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5780
5781 * bidi.c (bidi_level_of_next_char): Fix last change.
5782
5783 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5784
5785 Support bidi reordering of text covered by display properties.
5786
5787 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5788 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5789 (bidi_cache_search, bidi_cache_iterator_state)
5790 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5791 (bidi_level_of_next_char, bidi_move_to_visually_next):
5792 Support character positions inside a run of characters covered by a
5793 display string.
5794 (bidi_paragraph_init, bidi_resolve_explicit_1)
5795 (bidi_level_of_next_char): Call bidi_fetch_char and
5796 bidi_fetch_char_advance instead of FETCH_CHAR and
5797 FETCH_CHAR_ADVANCE.
5798 (bidi_init_it): Initialize new members.
5799 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5800 definitions.
5801 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5802 instead of using explicit *_CHAR codes.
5803 (bidi_resolve_explicit, bidi_resolve_weak):
5804 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5805 bidirectional text is supported only in multibyte buffers.
5806 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5807 it to initialize the frame_window_p member of struct bidi_it.
5808 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5809 (bidi_resolve_explicit, bidi_resolve_weak)
5810 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5811 bidi_it->nchars is non-positive.
5812 (bidi_level_of_next_char): Don't try to lookup the cache for the
5813 next/previous character if nothing is cached there yet, or if we
5814 were just reseat()'ed to a new position.
5815
5816 * xdisp.c (set_cursor_from_row): Set start and stop points
5817 according to the row's direction when priming the loop that looks
5818 for the glyph on which to display cursor.
5819 (single_display_spec_intangible_p): Function deleted.
5820 (display_prop_intangible_p): Reimplement to call
5821 handle_display_spec instead of single_display_spec_intangible_p.
5822 Accept 3 additional arguments needed by handle_display_spec.
5823 This fixes incorrect cursor motion across display property with complex
5824 values: lists, `(when COND...)' forms, etc.
5825 (single_display_spec_string_p): Support property values that are
5826 lists with the argument STRING its top-level element.
5827 (display_prop_string_p): Fix the condition for processing a
5828 property that is a list to be consistent with handle_display_spec.
5829 (handle_display_spec): New function, refactored from the
5830 last portion of handle_display_prop.
5831 (compute_display_string_pos): Accept additional argument
5832 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5833 value of a `display' property is a "replacing spec".
5834 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5835 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5836 the display property, but just return a value indicating whether
5837 the display property will replace the characters it covers.
5838 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5839 frame_window_p members of struct bidi_it.
5840 (compute_display_string_pos, compute_display_string_end):
5841 New functions.
5842 (push_it): Accept second argument POSITION, where pop_it should
5843 jump to continue iteration.
5844 (reseat_1): Initialize bidi_it.disp_pos.
5845
5846 * keyboard.c (adjust_point_for_property): Adjust the call to
5847 display_prop_intangible_p to its new signature.
5848
5849 * dispextern.h (struct bidi_it): New member frame_window_p.
5850 (bidi_init_it): Update prototypes.
5851 (display_prop_intangible_p): Update prototype.
5852 (compute_display_string_pos, compute_display_string_end):
5853 Declare prototypes.
5854 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5855 EMACS_INT.
5856
5857 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5858
5859 Malloc failure behavior now depends on size of allocation.
5860 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5861 * lisp.h: Change signatures accordingly.
5862 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5863 All callers changed. (Bug#8762)
5864
5865 * gnutls.c: Use Emacs's memory allocators.
5866 Without this change, the gnutls library would invoke malloc etc.
5867 directly, which causes problems on non-SYNC_INPUT hosts, and which
5868 runs afoul of improving memory_full behavior. (Bug#8761)
5869 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5870 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5871 xfree instead of the default malloc, realloc, free.
5872 (Fgnutls_boot): No need to check for memory allocation failure,
5873 since xmalloc does that for us.
5874
5875 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5876 * category.c (hash_get_category_set):
5877 * ccl.c (ccl_driver):
5878 * charset.c (Fdefine_charset_internal):
5879 * charset.h (struct charset.hash_index):
5880 * composite.c (get_composition_id, gstring_lookup_cache)
5881 (composition_gstring_put_cache):
5882 * composite.h (struct composition.hash_index):
5883 * dispextern.h (struct image.hash):
5884 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5885 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5886 (hashfn_equal, hashfn_user_defined, make_hash_table)
5887 (maybe_resize_hash_table, hash_lookup, hash_put)
5888 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5889 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5890 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5891 * image.c (make_image, search_image_cache, lookup_image)
5892 (xpm_put_color_table_h):
5893 * lisp.h (struct Lisp_Hash_Table):
5894 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5895 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5896 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5897 * alloc.c (allocate_vectorlike):
5898 Check for overflow in vector size calculations.
5899 * ccl.c (ccl_driver):
5900 Check for overflow when converting EMACS_INT to int.
5901 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5902 need to be updated by these changes.
5903 * fns.c (make_hash_table, maybe_resize_hash_table):
5904 Check for integer overflow with large hash tables.
5905 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5906 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5907 (SXHASH_REDUCE): New macro.
5908 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5909 Use it instead of discarding useful hash info with large hash values.
5910 (sxhash_float): New function.
5911 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5912 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5913 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5914 Rewrite to use FIXNUM_BITS, as this simplifies things.
5915 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5916 Adjust signatures to match updated version of code.
5917 (consing_since_gc): Now EMACS_INT, since a single hash table can
5918 use more than INT_MAX bytes.
5919
5920 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5921
5922 Make it possible to build with GCC-4.6+ -O2 -flto.
5923
5924 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5925
5926 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5927
5928 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5929 Call minibuffer-inactive-mode.
5930
5931 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5932
5933 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5934 Update dependencies.
5935
5936 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5937
5938 * data.c (init_data): Remove code for UTS, this system is not
5939 supported anymore.
5940
5941 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5942
5943 Don't force ./temacs to start in terminal mode.
5944
5945 * frame.c (make_initial_frame): Initialize faces in all cases, not
5946 only when CANNOT_DUMP is defined.
5947 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5948
5949 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5950
5951 * dispnew.c (add_window_display_history): Use const for the string
5952 pointer. Remove declaration, not needed.
5953
5954 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5955
5956 Use 'inline', not 'INLINE'.
5957 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5958 * alloc.c, fontset.c (INLINE): Remove.
5959 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5960 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5961 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5962 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5963 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5964
5965 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5966
5967 Make it possible to run ./temacs.
5968
5969 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5970 syms_of_callproc does the same thing. Remove test for
5971 "initialized", do it in the caller.
5972 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5973
5974 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5975
5976 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5977 (read_minibuf): Use get_minibuffer.
5978 (syms_of_minibuf): Use DEFSYM.
5979 (Qmetadata): New var.
5980 * data.c (Qbuffer): Don't make it static.
5981 (syms_of_data): Use DEFSYM.
5982
5983 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5984
5985 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5986 (CCL_CODE_MIN): New macro.
5987
5988 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5989
5990 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5991
5992 * eval.c (Qdebug): Now static.
5993 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5994 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5995 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5996
5997 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5998
5999 * image.c: Various fixes to ImageMagick code comments.
6000 (Fimagemagick_types): Doc fix.
6001
6002 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6003
6004 Minor fixes prompted by GCC 4.6.0 warnings.
6005
6006 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6007
6008 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6009 (x_clipboard_manager_save_all): Move extern decl to ...
6010 * xterm.h: ... here, so that it can be checked for consistency.
6011
6012 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6013
6014 * xselect.c (x_clipboard_manager_save_frame)
6015 (x_clipboard_manager_save_all): New functions.
6016 (Fx_clipboard_manager_save): Lisp function deleted.
6017
6018 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6019 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6020
6021 * xterm.h: Update prototype.
6022
6023 2011-05-28 William Xu <william.xwl@gmail.com>
6024
6025 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6026 exiting (Bug#8239).
6027
6028 2011-05-28 Jim Meyering <meyering@redhat.com>
6029
6030 Avoid a sign-extension bug in crypto_hash_function.
6031 * fns.c (to_uchar): Define.
6032 (crypto_hash_function): Use it to convert some newly-signed
6033 variables to unsigned, to avoid sign-extension bugs. For example,
6034 without this change, (md5 "truc") would evaluate to
6035 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6036 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6037 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6038
6039 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6040
6041 Integer overflow fixes.
6042
6043 * dbusbind.c: Serial number integer overflow fixes.
6044 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6045 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6046 to hold a serial number that is too large for a fixnum.
6047 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6048 Check for serial numbers out of range. Decode any serial number
6049 that was so large that it became a float. (Bug#8722)
6050
6051 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6052 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6053 Use XFASTINT rather than XUINT when numbers are nonnegative.
6054 (xd_append_arg, Fdbus_method_return_internal):
6055 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6056 arguments, check that Lisp number is nonnegative, rather than
6057 silently wrapping negative numbers around. (Bug#8722)
6058 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6059 (Bug#8722)
6060
6061 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6062
6063 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6064
6065 ccl: Add integer overflow checks.
6066 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6067 (IN_INT_RANGE): New macros.
6068 (ccl_driver): Use them to check for integer overflow when
6069 decoding a CCL program. Many of the new checks are whether XINT (x)
6070 fits in int; it doesn't always, on 64-bit hosts. The new version
6071 doesn't catch all possible integer overflows, but it's an
6072 improvement. (Bug#8719)
6073
6074 * alloc.c (make_event_array): Use XINT, not XUINT.
6075 There's no need for unsigned here.
6076
6077 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6078 This follows up to the 2011-05-06 change that substituted uintptr_t
6079 for EMACS_INT. This case wasn't caught back then.
6080
6081 Rework Fformat to avoid integer overflow issues.
6082 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6083 now (part of C89). Include <verify.h>.
6084 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6085 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6086 (Fformat): Avoid the prepass trying to compute sizes; it was only
6087 approximate and thus did not catch overflow reliably. Instead, walk
6088 through the format just once, formatting and computing sizes as we go,
6089 checking for integer overflow at every step, and allocating a larger
6090 buffer as needed. Keep track separately whether the format is
6091 multibyte. Keep only the most-recently calculated precision, rather
6092 than them all. Record whether each argument has been converted to
6093 string. Use EMACS_INT, not int, for byte and char and arg counts.
6094 Support field widths and precisions larger than INT_MAX. Avoid
6095 sprintf's undefined behavior with conversion specifications such as %#d
6096 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6097 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6098 formatting out-of-range floating point numbers with int
6099 formats. (Bug#8668)
6100
6101 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6102
6103 * data.c: Avoid integer truncation in expressions involving floats.
6104 * data.c: Include <intprops.h>.
6105 (arith_driver): When there's an integer overflow in an expression
6106 involving floating point, convert the integers to floating point
6107 so that the resulting value does not suffer from catastrophic
6108 integer truncation. For example, on a 64-bit host (* 4
6109 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6110 Do not rely on undefined behavior after integer overflow.
6111
6112 merge count_size_as_multibyte, parse_str_to_multibyte
6113 * character.c, character.h (count_size_as_multibyte):
6114 Rename from parse_str_to_multibyte; all uses changed.
6115 Check for integer overflow.
6116 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6117 since it's now a duplicate of the other. This is more of
6118 a character than a buffer op, so better that it's in character.c.
6119 * fns.c, print.c: Adjust to above changes.
6120
6121 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6122
6123 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6124
6125 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6126
6127 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6128 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6129 (x_clipboard_manager_save): Now static.
6130 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6131
6132 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6133 (crypto_hash_function): Now static.
6134 Fix pointer signedness problems. Avoid unnecessary initializations.
6135
6136 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6137
6138 * termhooks.h (Vselection_alist): Make it terminal-local.
6139
6140 * terminal.c (create_terminal): Initialize it.
6141
6142 * xselect.c: Support for clipboard managers.
6143 (Vselection_alist): Move to termhooks.h as terminal-local var.
6144 (LOCAL_SELECTION): New macro.
6145 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6146 (symbol_to_x_atom): Remove gratuitous arg.
6147 (x_handle_selection_request, lisp_data_to_selection_data)
6148 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6149 (x_own_selection, x_get_local_selection, x_convert_selection):
6150 New arg, specifying work frame. Use terminal-local Vselection_alist.
6151 (some_frame_on_display): Delete unused function.
6152 (Fx_own_selection_internal, Fx_get_selection_internal)
6153 (Fx_disown_selection_internal, Fx_selection_owner_p)
6154 (Fx_selection_exists_p): New optional frame arg.
6155 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6156 (x_handle_selection_clear): Don't treat other terminals with the
6157 same keyboard specially. Use the terminal-local Vselection_alist.
6158 (x_clear_frame_selections): Use Frun_hook_with_args.
6159
6160 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6161
6162 * xterm.h: Add support for those atoms.
6163
6164 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6165
6166 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6167 (converted_selections, conversion_fail_tag): New global variables.
6168 (x_selection_request_lisp_error): Free the above.
6169 (x_get_local_selection): Remove unnecessary code.
6170 (x_reply_selection_request): Args changed; handle arbitrary array
6171 of converted selections stored in converted_selections.
6172 Separate the XChangeProperty and SelectionNotify steps.
6173 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6174 (x_convert_selection): New function.
6175 (x_handle_selection_event): Simplify.
6176 (x_get_foreign_selection): Don't ignore incoming requests while
6177 waiting for an answer; this will fail when we implement
6178 SAVE_TARGETS, and seems unnecessary anyway.
6179 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6180 (Vx_sent_selection_functions): Doc fix.
6181
6182 2011-05-26 Leo Liu <sdl.web@gmail.com>
6183
6184 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6185
6186 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6187
6188 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6189
6190 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6191 for fringe update if it has periodic bitmap.
6192 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6193 and fringe_bitmap_periodic_p.
6194
6195 * fringe.c (get_fringe_bitmap_data): New function.
6196 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6197 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6198 row. Mark glyph row for fringe update if periodicity changed.
6199
6200 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6201 for fringe update unless it has periodic bitmap.
6202
6203 2011-05-25 Kenichi Handa <handa@m17n.org>
6204
6205 * xdisp.c (get_next_display_element): Set correct it->face_id for
6206 a static composition.
6207
6208 2011-05-24 Leo Liu <sdl.web@gmail.com>
6209
6210 * deps.mk (fns.o):
6211 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6212
6213 * fns.c (crypto_hash_function, Fsha1): New function.
6214 (Fmd5): Use crypto_hash_function.
6215 (syms_of_fns): Add Ssha1.
6216
6217 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6218
6219 * gnutls.c: Remove unused macros.
6220 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6221 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6222 Remove macros that are defined and never used.
6223 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6224
6225 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6226
6227 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6228 (Fx_get_selection_internal): Minor cleanup.
6229 (Fx_own_selection_internal): Rename arguments for consistency with
6230 select.el.
6231
6232 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6233
6234 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6235
6236 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6237
6238 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6239
6240 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6241
6242 * dispnew.c (scrolling_window): Don't exclude the case that the
6243 last enabled row in the desired matrix touches the bottom boundary.
6244
6245 2011-05-21 Glenn Morris <rgm@gnu.org>
6246
6247 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6248 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6249 and add some more files.
6250
6251 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6252
6253 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6254 report_file_error introduced by the change from 2011-05-07.
6255
6256 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6257
6258 * systime.h (Time): Define only if emacs is defined.
6259 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6260 where the include path doesn't have X11/X.h by default. See
6261 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6262
6263 2011-05-20 Kenichi Handa <handa@m17n.org>
6264
6265 * composite.c (find_automatic_composition): Fix previous change.
6266
6267 2011-05-20 Glenn Morris <rgm@gnu.org>
6268
6269 * lisp.mk: New file, split from Makefile.in.
6270 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6271 (shortlisp): Remove.
6272 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6273
6274 2011-05-19 Glenn Morris <rgm@gnu.org>
6275
6276 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6277 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6278 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6279 (lisp): Set the order to that of loadup.el.
6280 (shortlisp): Make it a copy of $lisp.
6281 (SOME_MACHINE_LISP): Remove.
6282 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6283 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6284
6285 2011-05-18 Kenichi Handa <handa@m17n.org>
6286
6287 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6288 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6289 (find_automatic_composition): Mostly rewrite for efficiency.
6290
6291 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6292
6293 * makefile.w32-in: Update dependencies.
6294
6295 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6296
6297 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6298 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6299
6300 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6301
6302 Fix some integer overflow issues, such as string length overflow.
6303
6304 * insdel.c (count_size_as_multibyte): Check for string overflow.
6305
6306 * character.c (lisp_string_width): Check for string overflow.
6307 Use EMACS_INT, not int, for string indexes and lengths; in
6308 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6309 the resulting string length overflows an EMACS_INT; instead,
6310 report a string overflow if no precision given. When checking for
6311 precision exhaustion, use a check that cannot possibly have
6312 integer overflow. (Bug#8675)
6313 * character.h (lisp_string_width): Adjust to new signature.
6314
6315 * alloc.c (string_overflow): New function.
6316 (Fmake_string): Use it. This doesn't change behavior, but saves
6317 a few bytes and will simplify future changes.
6318 * character.c (string_escape_byte8): Likewise.
6319 * lisp.h (string_overflow): New decl.
6320
6321 Fixups, following up to the user-interface timestamp change.
6322 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6323 for UI timestamps, instead of unsigned long.
6324 * msdos.c (mouse_get_pos): Likewise.
6325 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6326 * w32gui.h (Time): Define by including "systime.h" rather than by
6327 declaring it ourselves. (Bug#8664)
6328
6329 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6330 * image.c (clear_image_cache): Likewise.
6331
6332 * term.c (term_mouse_position): Don't assume time_t wraparound.
6333
6334 Be more systematic about user-interface timestamps.
6335 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6336 and sometimes 'EMACS_UINT', to represent these timestamps.
6337 This change causes it to use 'Time' uniformly, as that's what X uses.
6338 This makes the code easier to follow, and makes it easier to catch
6339 integer overflow bugs such as Bug#8664.
6340 * frame.c (Fmouse_position, Fmouse_pixel_position):
6341 Use Time, not unsigned long, for user-interface timestamps.
6342 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6343 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6344 * keyboard.h (last_event_timestamp): Likewise.
6345 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6346 * menu.h (xmenu_show): Likewise.
6347 * term.c (term_mouse_position): Likewise.
6348 * termhooks.h (struct input_event.timestamp): Likewise.
6349 (struct terminal.mouse_position_hook): Likewise.
6350 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6351 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6352 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6353 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6354 what it was before.
6355 * menu.h, termhooks.h: Include "systime.h", for Time.
6356
6357 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6358 Don't assume that the difference between two unsigned long values
6359 can fit into an integer. At this point, we know button_down_time
6360 <= event->timestamp, so the difference must be nonnegative, so
6361 there's no need to cast the result if double-click-time is
6362 nonnegative, as it should be; check that it's nonnegative, just in
6363 case. This bug is triggered when events are more than 2**31 ms
6364 apart (about 25 days). (Bug#8664)
6365
6366 * xselect.c (last_event_timestamp): Remove duplicate decl.
6367 (x_own_selection): Remove needless cast to unsigned long.
6368
6369 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6370 that always fit in int. Use a sentinel instead of a counter, to
6371 avoid a temp and to allay GCC's concerns about possible int overflow.
6372 * frame.h (struct frame): Use int for menu_bar_items_used
6373 instead of EMACS_INT, since it always fits in int.
6374
6375 * menu.c (grow_menu_items): Check for int overflow.
6376
6377 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6378
6379 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6380 Before, the code was not consistent. These values cannot exceed
6381 2**31 - 1 so there's no need to make them unsigned.
6382 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6383 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6384 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6385 as modifiers.
6386 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6387
6388 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6389 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6390 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6391 presumably because the widths might not match.
6392
6393 * window.c (size_window): Avoid needless test at loop start.
6394
6395 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6396
6397 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6398
6399 2011-05-12 Drew Adams <drew.adams@oracle.com>
6400
6401 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6402
6403 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6404
6405 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6406 `width' to `bar_area_x' and `bar_area_width', respectively.
6407 (x_scroll_run): Take account of fringe background extension.
6408
6409 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6410 Rename local vars `left' and `width' to `bar_area_x' and
6411 `bar_area_width', respectively.
6412 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6413 background extension.
6414
6415 2011-05-10 Jim Meyering <meyering@redhat.com>
6416
6417 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6418
6419 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6420
6421 * image.c (Finit_image_library): Return t for built-in image types,
6422 like pbm and xbm. (Bug#8640)
6423
6424 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6425
6426 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6427
6428 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6429
6430 * w32console.c (Fset_screen_color): Doc fix.
6431 (Fget_screen_color): New function.
6432 (syms_of_ntterm): Defsubr it.
6433
6434 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6435 unlink the temporary file if Fcall_process didn't create it in the
6436 first place.
6437 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6438 child process will be redirected to a file specified with `:file'.
6439 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6440 cue to call_process_cleanup not to close that handle.
6441
6442 2011-05-07 Ben Key <bkey76@gmail.com>
6443
6444 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6445 one of two shell specific rules, either bootstrap-temacs-CMD or
6446 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6447 to the previous implementation of the bootstrap-temacs rule.
6448 The bootstrap-temacs-CMD rule is similar to the previous
6449 implementation of the bootstrap-temacs rule except that it
6450 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6451 variable.
6452
6453 These changes, along with some changes to nt/configure.bat,
6454 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6455 earlier fix to add support for --cflags and --ldflags options
6456 that include quotes so that it works whether make uses cmd or
6457 sh as the shell.
6458
6459 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6460
6461 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6462 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6463 is a constant.
6464 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6465 a string. Handle both cases.
6466 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6467 (Fdbus_register_method): Use Qinvalid_function.
6468
6469 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6470
6471 * makefile.w32-in: Update dependencies.
6472 (LISP_H): Add inttypes.h and stdin.h.
6473 (PROCESS_H): Add unistd.h.
6474
6475 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6476
6477 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6478 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6479
6480 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6481
6482 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6483
6484 * term.c (vfatal): Remove stray call to va_end.
6485 It's not needed and the C Standard doesn't allow it here anyway.
6486
6487 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6488 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6489
6490 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6491 bytes.
6492
6493 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6494
6495 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6496
6497 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6498
6499 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6500
6501 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6502
6503 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6504 * charset.c (Fdefine_charset_internal): Don't initialize
6505 charset.code_space[15]. The value was garbage, on hosts with
6506 32-bit int (Bug#8600).
6507
6508 * lread.c (read_integer): Be more consistent with string-to-number.
6509 Use string_to_number to do the actual conversion; this avoids
6510 rounding errors and fixes some other screwups. Without this fix,
6511 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6512 (digit_to_number): Move earlier, for benefit of read_integer.
6513 Return -1 if the digit is out of range for the base, -2 if it is
6514 not a digit in any supported base. (Bug#8602)
6515
6516 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6517
6518 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6519 to match comment at start of function. This also removes a
6520 GCC warning about overflow in a 32+64-bit port.
6521
6522 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6523
6524 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6525 Reported by Stefan Monnier in
6526 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6527 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6528 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6529
6530 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6531 (EMACS_UINTPTR): Likewise, with uintptr_t.
6532
6533 * lisp.h: Prefer 64-bit EMACS_INT if available.
6534 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6535 on 32-bit hosts that have 64-bit int, so that they can access
6536 large files.
6537 However, temporarily disable this change unless the temporary
6538 symbol WIDE_EMACS_INT is defined.
6539
6540 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6541
6542 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6543 This removes an assumption that EMACS_INT and long are the same
6544 width as pointers. The assumption is true for Emacs porting targets
6545 now, but we want to make other targets possible.
6546 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6547 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6548 In the rest of the code, change types of integers that hold casted
6549 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6550 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6551 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6552 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6553 No need to cast type when ORing.
6554 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6555 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6556 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6557 assume EMACS_INT is the same width as char *.
6558 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6559 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6560 Remove no-longer-needed casts.
6561 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6562 (xg_tool_bar_help_callback, xg_make_tool_item):
6563 Use EMACS_INTPTR to hold an integer
6564 that will be cast to void *; this can avoid a GCC warning
6565 if EMACS_INT is not the same width as void *.
6566 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6567 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6568 (current_message_1, set_message_1):
6569 Use a local to convert to proper width without a cast.
6570 * xmenu.c (dialog_selection_callback): Likewise.
6571
6572 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6573 Also, don't assume VALBITS / RAND_BITS is less than 5,
6574 and don't rely on undefined behavior when shifting a 1 left into
6575 the sign bit.
6576 * lisp.h (get_random): Change signature to match.
6577
6578 * lread.c (hash_string): Use size_t, not int, for hash computation.
6579 Normally we prefer signed values; but hashing is special, because
6580 it's better to use unsigned division on hash table sizes so that
6581 the remainder is nonnegative. Also, size_t is the natural width
6582 for hashing into memory. The previous code used 'int', which doesn't
6583 retain enough info to hash well into very large tables.
6584 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6585
6586 * dbusbind.c: Don't possibly lose pointer info when converting.
6587 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6588 Use XPNTR rather than XHASH, so that the high-order bits of
6589 the pointer aren't lost when converting through void *.
6590
6591 * eval.c (Fautoload): Don't double-shift a pointer.
6592
6593 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6594
6595 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6596
6597 * gnutls.c (DEF_GNUTLS_FN):
6598 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6599
6600 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6601
6602 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6603 marker. (Bug#8610)
6604
6605 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6606
6607 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6608 New version that can reserve upto 2GB of heap space.
6609
6610 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6611
6612 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6613
6614 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6615
6616 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6617 `gnutls_certificate_set_x509_key_file'.
6618
6619 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6620
6621 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6622 Update dependencies.
6623
6624 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6625
6626 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6627 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6628 Remove unused parameter `fildes'.
6629 * process.c (read_process_output, send_process): Don't pass it.
6630
6631 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6632
6633 Fix previous change: the library cache is defined in w32.c.
6634 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6635 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6636
6637 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6638
6639 Implement dynamic loading of GnuTLS on Windows.
6640
6641 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6642 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6643 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6644 Declare.
6645
6646 * gnutls.c (Qgnutls_dll): Define.
6647 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6648 (gnutls_*): Declare function pointers.
6649 (init_gnutls_functions): New function to initialize function pointers.
6650 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6651 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6652 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6653 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6654 (emacs_gnutls_write, emacs_gnutls_read)
6655 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6656 (Fgnutls_available_p): New function.
6657 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6658 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6659 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6660
6661 * image.c: Include w32.h.
6662 (Vimage_type_cache): Delete.
6663 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6664 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6665 (w32_delayed_load): Move to w32.c.
6666
6667 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6668
6669 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6670 (w32_delayed_load): Move from image.c. When loading a library, record
6671 its filename in the :loaded-from property of the library id.
6672 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6673 Initialize and staticpro them.
6674 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6675
6676 * process.c: Include lisp.h before w32.h, not after.
6677 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6678 instead of gnutls_record_check_pending.
6679
6680 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6681
6682 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6683
6684 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6685 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6686 as passed in.
6687
6688 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6689
6690 * xterm.c (x_set_frame_alpha): Do not set property on anything
6691 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6692
6693 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6694
6695 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6696
6697 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6698
6699 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6700 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6701 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6702 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6703 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6704 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6705 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6706 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6707 (Qgnutls_bootprop_callbacks_verify): Make static.
6708
6709 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6710
6711 * callproc.c: Indentation fixup.
6712
6713 * sysdep.c (wait_for_termination_1): Make static.
6714 (wait_for_termination, interruptible_wait_for_termination):
6715 Move after wait_for_termination_1.
6716
6717 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6718
6719 * sysdep.c (interruptible_wait_for_termination): New function
6720 which is like wait_for_termination, but allows keyboard
6721 interruptions.
6722
6723 * callproc.c (Fcall_process): Add (:file "file") as an option for
6724 the STDOUT buffer.
6725 (Fcall_process_region): Ditto.
6726
6727 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6728
6729 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6730 rather than `XVECTOR (FOO)->size'.
6731
6732 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6733 inttypes.h, as a gnulib replacement is used if it not available in
6734 system headers.
6735
6736 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6737
6738 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6739 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6740 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6741
6742 * coding.c (coding_alloc_by_realloc): Error out if destination
6743 will grow beyond MOST_POSITIVE_FIXNUM.
6744 (decode_coding_emacs_mule): Abort if there isn't enough place in
6745 charbuf for the composition carryover bytes. Reserve an extra
6746 space for up to 2 characters produced in a loop.
6747 (decode_coding_iso_2022): Abort if there isn't enough place in
6748 charbuf for the composition carryover bytes.
6749
6750 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6751
6752 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6753 aborting when %lld or %lll format is passed.
6754 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6755 %llo or %llx format is passed. (Bug#8545)
6756
6757 * window.c (window_scroll_line_based): Use a marker instead of
6758 simple variables to record original value of point. (Bug#7952)
6759
6760 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6761 produced by %s or %c overflows available buffer space. (Bug#8545)
6762
6763 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6764
6765 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6766 (SIZE_MAX): Move defn after all includes, as they might #define it.
6767
6768 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6769
6770 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6771
6772 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6773
6774 * keyboard.c (Qdelayed_warnings_hook): Define.
6775 (command_loop_1): Run `delayed-warnings-hook'
6776 if Vdelayed_warnings_list is non-nil.
6777 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6778 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6779
6780 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6781
6782 * doprnt.c (doprnt): Don't return value smaller than the buffer
6783 size if the message was truncated. (Bug#8545).
6784
6785 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6786
6787 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6788 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6789
6790 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6791
6792 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6793
6794 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6795
6796 * makefile.w32-in: Update dependencies.
6797
6798 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6799
6800 Improve `doprnt' and its usage. (Bug#8545)
6801 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6802 `format_end'. Remove support for %l as a conversion specifier.
6803 Don't use xrealloc. Improve diagnostics when the %l size modifier
6804 is used. Update the commentary.
6805
6806 * eval.c (verror): Simplify calculation of size_t.
6807
6808 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6809 messages.
6810
6811 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6812
6813 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6814 change.
6815
6816 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6817
6818 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6819 This makes this file independent of the recent pseudovector change.
6820
6821 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6822
6823 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6824
6825 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6826 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6827 Remove unused local.
6828 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6829
6830 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6831 GCC 4.6.0 optimizes based on type-based alias analysis.
6832 For example, if b is of type struct buffer * and v of type struct
6833 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6834 != &v->size, and therefore "v->size = 1; b->size = 2; return
6835 v->size;" must therefore return 1. This assumption is incorrect
6836 for Emacs, since it type-puns struct Lisp_Vector * with many other
6837 types. To fix this problem, this patch adds a new type struct
6838 vectorlike_header that documents the constraints on layout of vectors
6839 and pseudovectors, and helps optimizing compilers not get fooled
6840 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6841 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6842 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6843 the size member.
6844 (XSETPVECTYPE): Rewrite in terms of new macro.
6845 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6846 This is a bit clearer, and further avoids the possibility of
6847 undesirable aliasing.
6848 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6849 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6850 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6851 since Lisp_Subr is a special case (no "next" field).
6852 (ASIZE): Now uses header.size rather than size.
6853 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6854 to avoid the hassle of writing XVECTOR (foo)->header.size.
6855 (struct vectorlike_header): New type.
6856 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6857 object, to help avoid aliasing.
6858 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6859 (SUBRP): Likewise, since Lisp_Subr is a special case.
6860 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6861 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6862 (struct Lisp_Hash_Table): Combine first two members into a single
6863 struct vectorlike_header member. All uses of "size" and "next" members
6864 changed to be "header.size" and "header.next".
6865 * buffer.h (struct buffer): Likewise.
6866 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6867 * frame.h (struct frame): Likewise.
6868 * process.h (struct Lisp_Process): Likewise.
6869 * termhooks.h (struct terminal): Likewise.
6870 * window.c (struct save_window_data, struct saved_window): Likewise.
6871 * window.h (struct window): Likewise.
6872 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6873 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6874 * buffer.c (init_buffer_once): Likewise.
6875 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6876 special case.
6877 * process.c (Fformat_network_address): Use local var for size,
6878 for brevity.
6879
6880 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6881
6882 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6883 * data.c (atof): Remove decl; no longer used or needed.
6884 (digit_to_number): Move to lread.c.
6885 (Fstring_to_number): Use new string_to_number function, to be
6886 consistent with how the Lisp reader treats infinities and NaNs.
6887 Do not assume that floating-point numbers represent EMACS_INT
6888 without losing information; this is not true on most 64-bit hosts.
6889 Avoid double-rounding errors, by insisting on integers when
6890 parsing non-base-10 numbers, as the documentation specifies.
6891 * lisp.h (string_to_number): New decl, replacing ...
6892 (isfloat_string): Remove.
6893 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6894 (read1): Do not accept +. and -. as integers; this
6895 appears to have been a coding error. Similarly, do not accept
6896 strings like +-1e0 as floating point numbers. Do not report
6897 overflow for integer overflows unless the base is not 10 which
6898 means we have no simple and reliable way to continue.
6899 Break out the floating-point parsing into a new
6900 function string_to_number, so that Fstring_to_number parses
6901 floating point numbers consistently with the Lisp reader.
6902 (digit_to_number): Move here from data.c. Make it static inline.
6903 (E_CHAR, EXP_INT): Remove, replacing with ...
6904 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6905 (string_to_number): New function, replacing isfloat_string.
6906 This function checks for valid syntax and produces the resulting
6907 Lisp float number too. Rework it so that string-to-number
6908 no longer mishandles examples like "1.0e+". Use strtoumax,
6909 so that overflow for non-base-10 numbers is reported only when
6910 there's no portable and simple way to convert to floating point.
6911
6912 * textprop.c (set_text_properties_1): Rewrite for clarity,
6913 and to avoid GCC warning about integer overflow.
6914
6915 * intervals.h (struct interval): Use EMACS_INT for members
6916 where EMACS_UINT might cause problems. See
6917 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6918 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6919 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6920 All uses changed.
6921 (offset_intervals): Tell GCC not to worry about length overflow
6922 when negating a negative length.
6923
6924 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6925 (overrun_check_free): Likewise.
6926
6927 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6928 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6929 word size.
6930
6931 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6932 (gnutls_make_error): Rename local to avoid shadowing.
6933 (gnutls_emacs_global_deinit): ifdef out; not used.
6934 (Fgnutls_boot): Use const for pointer to readonly storage.
6935 Comment out unused local. Fix pointer signedness problems.
6936
6937 * lread.c (openp): Don't stuff size_t into an 'int'.
6938 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6939 about possible signed overflow.
6940
6941 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6942 (GDK_KEY_g): Don't define if already defined.
6943 (xg_prepare_tooltip): Avoid pointer signedness problem.
6944 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6945
6946 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6947 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6948
6949 * xfns.c (Fx_window_property): Simplify a bit,
6950 to make a bit faster and to avoid GCC 4.6.0 warning.
6951 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6952
6953 * fns.c (internal_equal): Don't assume size_t fits in int.
6954
6955 * alloc.c (compact_small_strings): Tighten assertion a little.
6956
6957 Replace pEd with more-general pI, and fix some printf arg casts.
6958 * lisp.h (pI): New macro, generalizing old pEd macro to other
6959 conversion specifiers. For example, use "...%"pI"d..." rather
6960 than "...%"pEd"...".
6961 (pEd): Remove. All uses replaced with similar uses of pI.
6962 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6963 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6964 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6965 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6966 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6967 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6968 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6969 64-bit hosts.
6970 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6971 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6972 * print.c (safe_debug_print, print_object): Likewise.
6973 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6974 to int.
6975 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6976 avoiding the 0 flag, which is not portable.
6977 * process.c (Fmake_network_process): Use pI to avoid cast.
6978 * region-cache.c (pp_cache): Likewise.
6979 * xdisp.c (decode_mode_spec): Likewise.
6980 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6981 behavior on 64-bit hosts with printf arg.
6982 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6983 (x_stop_queuing_selection_requests): Likewise.
6984 (x_get_window_property): Don't truncate byte count to an 'int'
6985 when tracing.
6986
6987 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6988 here, since it parses constructs like leading '-' and spaces,
6989 which are not wanted; and it overflows with large numbers.
6990 Instead, simply match F[0-9]+, which is what is wanted anyway.
6991
6992 * alloc.c: Remove unportable assumptions about struct layout.
6993 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6994 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6995 (allocate_vectorlike, make_pure_vector): Use the new macros,
6996 plus offsetof, to remove unportable assumptions about struct layout.
6997 These assumptions hold on all porting targets that I know of, but
6998 they are not guaranteed, they're easy to remove, and removing them
6999 makes further changes easier.
7000
7001 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7002 This doesn't fix a bug but makes the code clearer.
7003 (string_overrun_cookie): Now const. Use initializers that
7004 don't formally overflow signed char, to avoid warnings.
7005 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7006 can cause Emacs to crash when string overrun checking is enabled.
7007 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7008 multiple of sizeof (EMACS_INT); it need not be, if
7009 alignof(EMACS_INT) < sizeof (EMACS_INT).
7010 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7011
7012 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7013
7014 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7015
7016 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7017
7018 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7019 supposed to be handshaking. (Bug#8556)
7020 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7021
7022 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7023
7024 * lisp.h (Qdebug): List symbol.
7025 * eval.c (Qdebug): Restore global linkage.
7026 * keyboard.c (debug-on-event): New variable.
7027 (handle_user_signal): Break into debugger when debug-on-event
7028 matches the current signal symbol.
7029
7030 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7031
7032 * alloc.c (check_sblock, check_string_bytes)
7033 (check_string_free_list): Convert to standard C.
7034
7035 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7036
7037 * w32.c (emacs_gnutls_push): Fix typo.
7038
7039 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7040
7041 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7042 "cast to pointer from integer of different size".
7043
7044 Improve doprnt and its use in verror. (Bug#8545)
7045 * doprnt.c (doprnt): Document the set of format control sequences
7046 supported by the function. Use SAFE_ALLOCA instead of always
7047 using `alloca'.
7048
7049 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7050 is one byte too soon. Don't use xrealloc; instead xfree and
7051 xmalloc anew.
7052
7053 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7054
7055 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7056 callbacks stage.
7057
7058 * gnutls.c: Renamed global_initialized to
7059 gnutls_global_initialized. Added internals for the
7060 :verify-hostname-error, :verify-error, and :verify-flags
7061 parameters of `gnutls-boot' and documented those parameters in the
7062 docstring. Start callback support.
7063 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7064 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7065 on error. Return error code.
7066 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7067 (emacs_gnutls_read): Likewise.
7068 (Fgnutls_boot): Return handshake error code.
7069 (emacs_gnutls_handle_error): New function.
7070 (wsaerror_to_errno): Likewise.
7071
7072 * w32.h (emacs_gnutls_pull): Add prototype.
7073 (emacs_gnutls_push): Likewise.
7074
7075 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7076 (emacs_gnutls_push): Likewise.
7077
7078 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7079
7080 * process.c (wait_reading_process_output): Check if GnuTLS
7081 buffered some data internally if no FDs are set for TLS
7082 connections.
7083
7084 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7085 (LIBS): Link to USER_LIBS.
7086 ($(BLD)/gnutls.$(0)): New target.
7087
7088 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7089
7090 * xdisp.c (handle_single_display_spec): Rename the
7091 display_replaced_before_p argument into display_replaced_p, to
7092 make it consistent with the commentary. Fix typos in the
7093 commentary.
7094
7095 * textprop.c (syms_of_textprop): Remove dead code.
7096 (copy_text_properties): Delete obsolete commentary about an
7097 interface that was deleted long ago. Fix typos in the description
7098 of arguments.
7099
7100 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7101 to changes in oldXMenu/XMenu.h from 2011-04-16.
7102 <menu_help_message, prev_menu_help_message>: Constify.
7103 (IT_menu_make_room): menu->help_text is now `const char **';
7104 adjust.
7105
7106 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7107 to changes in oldXMenu/XMenu.h from 2011-04-16.
7108 (struct XMenu): Declare `help_text' `const char **'.
7109
7110 * xfaces.c <Qunspecified>: Make extern again.
7111
7112 * syntax.c: Include sys/types.h before including regex.h, as
7113 required by Posix.
7114
7115 * doc.c (get_doc_string): Improve the format passed to `error'.
7116
7117 * doprnt.c (doprnt): Improve commentary.
7118
7119 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7120
7121 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7122 them with etags.
7123
7124 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7125 changes in globals.h immediately force recompilation.
7126 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7127 $(CURDIR)/s/ms-w32.h.
7128 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7129
7130 * character.c (Fchar_direction): Function deleted.
7131 (syms_of_character): Don't defsubr it.
7132 <char-direction-table>: Deleted.
7133
7134 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7135
7136 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7137 * doprnt.c: Include limits.h.
7138 (SIZE_MAX): New macro.
7139 (doprnt): Return a size_t value. 2nd arg is now size_t.
7140 Many local variables are now size_t instead of int or unsigned.
7141 Improve overflow protection. Support `l' modifier for integer
7142 conversions. Support %l conversion. Don't assume an EMACS_INT
7143 argument for integer conversions and for %c.
7144
7145 * lisp.h (doprnt): Restore prototype.
7146
7147 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7148 $(SRC)/character.h.
7149
7150 * Makefile.in (base_obj): Add back doprnt.o.
7151
7152 * deps.mk (doprnt.o): Add back prerequisites.
7153 (callint.o): Depend on character.h.
7154
7155 * eval.c (internal_lisp_condition_case): Include the handler
7156 representation in the error message.
7157 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7158 when breaking from the loop.
7159
7160 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7161
7162 * callint.c (Fcall_interactively): When displaying error message
7163 about invalid control letter, pass the character's codepoint, not
7164 a pointer to its multibyte form. Improve display of the character
7165 in octal and display also its hex code.
7166
7167 * character.c (char_string): Use %x to display the (unsigned)
7168 codepoint of an invalid character, to avoid displaying a bogus
7169 negative value.
7170
7171 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7172 `error', not SYMBOL_NAME itself.
7173
7174 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7175 character arguments to `error'.
7176
7177 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7178 to `error' in error message about FINAL_CHAR argument. Make sure
7179 FINAL_CHAR is a character, and use %c when it is passed as
7180 argument to `error'.
7181
7182 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7183
7184 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7185
7186 * w32.c: Include <time.h>.
7187 (sys_localtime): New function.
7188
7189 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7190
7191 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7192
7193 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7194
7195 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7196
7197 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7198 zombies (Bug#8467).
7199
7200 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7201
7202 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7203 gl_state.e_property when gl_state.object is Qt.
7204
7205 * insdel.c (make_gap_larger): Remove limitation of buffer size
7206 to <= INT_MAX.
7207
7208 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7209
7210 * xdisp.c (lookup_glyphless_char_display)
7211 (produce_glyphless_glyph): Handle cons cell entry in
7212 glyphless-char-display.
7213 (Vglyphless_char_display): Document it.
7214
7215 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7216 glyphless-char-display.
7217
7218 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7219
7220 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7221
7222 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7223
7224 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7225 definition for no-X builds.
7226
7227 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7228
7229 Static checks with GCC 4.6.0 and non-default toolkits.
7230
7231 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7232
7233 * process.c (keyboard_bit_set): Define only if SIGIO.
7234 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7235 (send_process): Repair possible setjmp clobbering.
7236
7237 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7238
7239 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7240
7241 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7242
7243 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7244 Define only if needed.
7245
7246 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7247 by pacifying GCC about it. Maybe it's time to retire it?
7248 * xfaces.c (USG, __TIMEVAL__): Likewise.
7249
7250 * dispextern.h (struct redisplay_interface): Rename param
7251 to avoid shadowing.
7252 * termhooks.h (struct terminal): Likewise.
7253 * xterm.c (xembed_send_message): Likewise.
7254
7255 * insdel.c (make_gap_smaller): Define only if
7256 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7257
7258 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7259 it.
7260
7261 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7262 so that we aren't warned about unused symbols.
7263
7264 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7265
7266 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7267
7268 * xfns.c (x_real_positions): Mark locals as initialized.
7269
7270 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7271
7272 * xterm.c: Fix problems found by static analysis with other toolkits.
7273 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7274 (x_dispatch_event): Declare static if USE_GTK, and
7275 define if USE_GTK || USE_X_TOOLKIT.
7276 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7277 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7278 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7279 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7280
7281 * xmenu.c (menu_help_callback): Pointer type fixes.
7282 Use const pointers when pointing at readonly data. Avoid pointer
7283 signedness clashes.
7284 (FALSE): Remove unused macro.
7285 (update_frame_menubar): Remove unused decl.
7286
7287 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7288
7289 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7290 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7291 (single_menu_item): Rename local to avoid shadowing.
7292
7293 * keyboard.c (make_lispy_event): Remove unused local var.
7294
7295 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7296 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7297
7298 * bitmaps: Change bitmaps from unsigned char back to the X11
7299 compatible char. Avoid the old compiler warnings about
7300 out-of-range initializers by using, for example, '\xab' rather
7301 than 0xab.
7302
7303 * xgselect.c (xgselect_initialize): Check vs interface
7304 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7305
7306 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7307
7308 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7309 to read-only memory.
7310
7311 * fns.c (vector): Remove; this old hack is no longer needed.
7312
7313 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7314 Remove unused var.
7315 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7316
7317 * xrdb.c (x_load_resources): Omit unused local.
7318
7319 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7320 (x_window): Rename locals to avoid shadowing.
7321 (USG): Use the kludged USG macro, to pacify gcc.
7322
7323 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7324 (x_term_init): Remove local to avoid shadowing.
7325
7326 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7327
7328 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7329 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7330
7331 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7332
7333 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7334
7335 Fix regex.c, syntax.c and friends for buffers > 2GB.
7336 * syntax.h (struct gl_state_s): Declare character position members
7337 EMACS_INT.
7338
7339 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7340
7341 * textprop.c (verify_interval_modification, interval_of):
7342 Declare arguments EMACS_INT.
7343
7344 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7345 EMACS_INT.
7346
7347 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7348
7349 * indent.c (Fvertical_motion): Local variable it_start is now
7350 EMACS_INT.
7351
7352 * regex.c (re_match, re_match_2, re_match_2_internal)
7353 (bcmp_translate, regcomp, regexec, print_double_string)
7354 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7355 (re_compile_pattern, re_exec): Declare arguments and local
7356 variables `size_t' and `ssize_t' and return values `regoff_t', as
7357 appropriate.
7358 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7359 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7360 <compile_stack_type>: `size' and `avail' are now `size_t'.
7361
7362 * regex.h <regoff_t>: Use ssize_t, not int.
7363 (re_search, re_search_2, re_match, re_match_2): Arguments that
7364 specify buffer/string position and length are now ssize_t and
7365 size_t. Return type is regoff_t.
7366
7367 2011-04-16 Ben Key <bkey76@gmail.com>
7368
7369 * nsfont.m: Fixed bugs in ns_get_family and
7370 ns_descriptor_to_entity that were caused by using free to
7371 deallocate memory blocks that were allocated by xmalloc (via
7372 xstrdup). This caused Emacs to crash when compiled with
7373 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7374 --enable-checking=xmallocoverrun). xfree is now used to
7375 deallocate these memory blocks.
7376
7377 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7378
7379 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7380
7381 emacs_write: Accept and return EMACS_INT for sizes.
7382 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7383 et seq.
7384 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7385 Accept and return EMACS_INT.
7386 (emacs_gnutls_write): Return the number of bytes written on
7387 partial writes.
7388 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7389 (emacs_read, emacs_write): Remove check for negative size, as the
7390 Emacs source code has been audited now.
7391 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7392 (emacs_read, emacs_write): Use it.
7393 * process.c (send_process): Adjust to the new signatures of
7394 emacs_write and emacs_gnutls_write. Do not attempt to store
7395 a byte offset into an 'int'; it might overflow.
7396 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7397
7398 * sound.c: Don't assume sizes fit in 'int'.
7399 (struct sound_device.period_size, alsa_period_size):
7400 Return EMACS_INT, not int.
7401 (struct sound_device.write, vox_write, alsa_write):
7402 Accept EMACS_INT, not int.
7403 (wav_play, au_play): Use EMACS_INT to store sizes and to
7404 record read return values.
7405
7406 2011-04-15 Ben Key <bkey76@gmail.com>
7407
7408 * keyboard.c (Qundefined): Don't declare static since it is used
7409 in nsfns.m.
7410 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7411 static since they are used in nsfont.m.
7412
7413 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7414
7415 * process.c (Qprocessp): Don't declare static.
7416 * lisp.h (Qprocessp): Declare again.
7417
7418 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7419
7420 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7421
7422 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7423
7424 Improve C-level modularity by making more things 'static'.
7425
7426 Don't publish debugger-only interfaces to other modules.
7427 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7428 (verify_bytepos, count_markers): Move decls to the only modules
7429 that need them.
7430 * region-cache.h (pp_cache): Likewise.
7431 * window.h (check_all_windows): Likewise.
7432 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7433
7434 * sysdep.c (croak): Now static, if
7435 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7436 * syssignal.h (croak): Declare only if not static.
7437
7438 * alloc.c (refill_memory_reserve): Now static if
7439 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7440 * lisp.h (refill_memory_reserve): Declare only if not static.
7441
7442 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7443 Define only if USE_LUCID.
7444
7445 * xrdb.c (x_customization_string, x_rm_string): Now static.
7446
7447 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7448 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7449
7450 * xdisp.c (draw_row_with_mouse_face): Now static.
7451 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7452
7453 * window.h (check_all_windows): Mark externally visible.
7454
7455 * window.c (window_deletion_count): Now static.
7456
7457 * undo.c: Make symbols static if they're not exported.
7458 (last_undo_buffer, last_boundary_position, pending_boundary):
7459 Now static.
7460
7461 * textprop.c (interval_insert_behind_hooks): Now static.
7462 (interval_insert_in_front_hooks): Likewise.
7463
7464 * term.c: Make symbols static if they're not exported.
7465 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7466 (max_frame_lines, tty_set_terminal_modes):
7467 (tty_reset_terminal_modes, tty_turn_off_highlight):
7468 (get_tty_terminal): Now static.
7469 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7470 * termhooks.h (term_mouse_moveto): Do not declare if
7471 HAVE_WINDOW_SYSTEM.
7472 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7473 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7474
7475 * sysdep.c: Make symbols static if they're not exported.
7476 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7477 Now static.
7478 (sigprocmask_set, full_mask): Remove; unused.
7479 (wait_debugging): Mark as visible.
7480 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7481 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7482
7483 * syntax.c (syntax_temp): Define only if !__GNUC__.
7484
7485 * sound.c (current_sound_device, current_sound): Now static.
7486
7487 * search.c (searchbufs, searchbuf_head): Now static.
7488
7489 * scroll.c (scroll_cost): Remove; unused.
7490 * dispextern.h (scroll_cost): Remove decl.
7491
7492 * region-cache.h (pp_cache): Mark as externally visible.
7493
7494 * process.c: Make symbols static if they're not exported.
7495 (process_tick, update_tick, create_process, chan_process):
7496 (Vprocess_alist, proc_buffered_char, datagram_access):
7497 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7498 (deactivate_process): Mark defn as static, as well as decl.
7499 * lisp.h (create_process): Remove decl.
7500 * process.h (chan_process, Vprocess_alist): Remove decls.
7501
7502 * print.c: Make symbols static if they're not exported.
7503 (print_depth, new_backquote_output, being_printed, print_buffer):
7504 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7505 (print_interval, print_number_index, initial_stderr_stream):
7506 Now static.
7507 * lisp.h (Fprinc): Remove decl.
7508 (debug_output_compilation_hack): Mark as externally visible.
7509
7510 * sysdep.c (croak): Move decl from here to syssignal.h.
7511 * syssignal.h (croak): Put it here, so the API can be checked when
7512 'croak' is called from dissociate_if_controlling_tty.
7513
7514 * minibuf.c: Make symbols static if they're not exported.
7515 (minibuf_save_list, choose_minibuf_frame): Now static.
7516 * lisp.h (choose_minibuf_frame): Remove decl.
7517
7518 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7519
7520 * lread.c: Make symbols static if they're not exported.
7521 (read_objects, initial_obarray, oblookup_last_bucket_number):
7522 Now static.
7523 (make_symbol): Remove; unused.
7524 * lisp.h (initial_obarray, make_symbol): Remove decls.
7525
7526 * keyboard.c: Make symbols static if they're not exported.
7527 (single_kboard, recent_keys_index, total_keys, recent_keys):
7528 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7529 (this_single_command_key_start, echoing, last_auto_save):
7530 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7531 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7532 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7533 (Vlispy_mouse_stem, double_click_count):
7534 Now static.
7535 (force_auto_save_soon): Define only if SIGDANGER.
7536 (ignore_mouse_drag_p): Now static if
7537 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7538 (print_help): Remove; unused.
7539 (stop_character, last_timer_event): Mark as externally visible.
7540 * keyboard.h (ignore_mouse_drag_p): Declare only if
7541 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7542 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7543 * lisp.h (echoing): Remove decl.
7544 (force_auto_save_soon): Declare only if SIGDANGER.
7545 * xdisp.c (redisplay_window): Simplify code, to make it more
7546 obvious that ignore_mouse_drag_p is not accessed if !defined
7547 USE_GTK && !defined HAVE_NS.
7548
7549 * intervals.c: Make symbols static if they're not exported.
7550 (merge_properties_sticky, merge_interval_right, delete_interval):
7551 Now static.
7552 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7553
7554 * insdel.c: Make symbols static if they're not exported.
7555 However, leave prepare_to_modify_buffer alone. It's never
7556 called from outside this function, but that appears to be a bug.
7557 (combine_after_change_list, combine_after_change_buffer):
7558 (adjust_after_replace, signal_before_change): Now static.
7559 (adjust_after_replace_noundo): Remove; unused.
7560 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7561 (signal_before_change): Remove decls.
7562
7563 * indent.c (val_compute_motion, val_vmotion): Now static.
7564
7565 * image.c: Make symbols static if they're not exported.
7566 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7567 if USE_GTK.
7568 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7569 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7570
7571 * fringe.c (standard_bitmaps): Now static.
7572 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7573
7574 * frame.c: Make symbols static if they're not exported.
7575 (x_report_frame_params, make_terminal_frame): Now static.
7576 (get_frame_param): Now static, unless HAVE_NS.
7577 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7578 (x_get_resource_string): Remove; not used.
7579 * frame.h (make_terminal_frame, x_report_frame_params):
7580 (x_get_resource_string); Remove decls.
7581 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7582 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7583
7584 * font.c, fontset.c: Make symbols static if they're not exported.
7585 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7586 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7587 * font.c (font_close_object): Now static.
7588 * font.h (font_close_object): Remove.
7589 * fontset.c (FONTSET_OBJLIST): Remove.
7590 (free_realized_fontset) #if-0 the body, which does nothing.
7591 (face_suitable_for_char_p): #if-0, as it's never called.
7592 * fontset.h (face_suitable_for_char_p): Remove decl.
7593 * xfaces.c (face_at_string_position):
7594 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7595 since 0 is always ASCII.
7596
7597 * fns.c (weak_hash_tables): Now static.
7598
7599 * fileio.c: Make symbols static if they're not exported.
7600 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7601 (Vwrite_region_annotation_buffers): Now static.
7602
7603 * eval.c: Make symbols static if they're not exported.
7604 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7605 * lisp.h (backtrace_list): Remove decl.
7606
7607 * emacs.c: Make symbols static if they're not exported.
7608 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7609 (fatal_error_code, fatal_error_signal_hook, standard_args):
7610 Now static.
7611 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7612 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7613 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7614 * lisp.h (fatal_error_signal_hook): Remove decl.
7615 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7616
7617 * editfns.c: Move a (normally-unused) function to its only use.
7618 * editfns.c, lisp.h (get_operating_system_release): Remove.
7619 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7620 worth the hassle of breaking this out.
7621
7622 * xterm.c: Make symbols static if they're not exported.
7623 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7624 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7625 (x_destroy_window, x_delete_display):
7626 Now static.
7627 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7628 (x_mouse_leave): Remove; unused.
7629 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7630 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7631 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7632 Remove decls.
7633 (x_mouse_leave): Declare only if WINDOWSNT.
7634 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7635 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7636 USE_X_TOOLKIT.
7637
7638 * ftxfont.c: Make symbols static if they're not exported.
7639 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7640 HAVE_FREETYPE.
7641 * font.h (ftxfont_driver): Likewise.
7642
7643 * xfns.c: Make symbols static if they're not exported.
7644 (x_last_font_name, x_display_info_for_name):
7645 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7646 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7647 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7648 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7649 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7650 (last_show_tip_args): Now static.
7651 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7652 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7653 (x_screen_planes): Remove; unused.
7654 * dispextern.h (x_screen_planes): Remove decl.
7655
7656 * dispnew.c: Make symbols static if they're not exported.
7657 * dispextern.h (redraw_garbaged_frames, scrolling):
7658 (increment_row_positions): Remove.
7659 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7660 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7661 Now static.
7662 (redraw_garbaged_frames): Remove; unused.
7663
7664 * xfaces.c: Make symbols static if they're not exported.
7665 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7666 Remove decls.
7667 * xterm.h (defined_color): Remove decls.
7668 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7669 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7670 (menu_face_changed_default, defined_color, free_realized_face):
7671 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7672 (ascii_face_of_lisp_face): Remove; unused.
7673
7674 * xdisp.c: Make symbols static if they're not exported.
7675 * dispextern.h (scratch_glyph_row, window_box_edges):
7676 (glyph_to_pixel_coords, set_cursor_from_row):
7677 (get_next_display_element, set_iterator_to_next):
7678 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7679 (show_mouse_face): Remove decls
7680 * frame.h (message_buf_print): Likewise.
7681 * lisp.h (pop_message, set_message, check_point_in_composition):
7682 Likewise.
7683 * xterm.h (set_vertical_scroll_bar): Likewise.
7684 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7685 (message_buf_print, scratch_glyph_row, displayed_buffer):
7686 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7687 (get_next_display_element, show_mouse_face, window_box_edges):
7688 (frame_to_window_pixel_xy, check_point_in_composition):
7689 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7690 (glyph_to_pixel_coords): Remove; unused.
7691
7692 * dired.c (file_name_completion): Now static.
7693
7694 * dbusbind.c (xd_in_read_queued_messages): Now static.
7695
7696 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7697 * data.c (circular_list_error): Remove.
7698
7699 * commands.h (last_point_position, last_point_position_buffer):
7700 (last_point_position_window): Remove decls.
7701 * keyboard.c: Make these variables static.
7702
7703 * coding.h (coding, code_convert_region, encode_coding_gap):
7704 Remove decls.
7705 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7706 (iso_code_class, detect_coding, code_convert_region): Now static.
7707 (encode_coding_gap): Remove; unused.
7708
7709 * chartab.c (chartab_chars, chartab_bits): Now static.
7710
7711 * charset.h (charset_iso_8859_1): Remove decl.
7712 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7713 Now static.
7714
7715 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7716 * ccl.c (Vccl_program_table): Now static.
7717 (check_ccl_update): Remove; unused.
7718
7719 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7720 * category.h: ... from here.
7721 * category.c (check_category_table, set_category_set): Now static.
7722
7723 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7724 * lisp.h: Remove these decls.
7725
7726 * buffer.c (buffer_count): Remove unused var.
7727
7728 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7729 so that it's not optimized away.
7730 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7731 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7732 exported only to the debugger.
7733
7734 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7735 * atimer.h (run_all_atimers): Remove; not exported.
7736
7737 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7738 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7739 was inaccessible from Lisp.
7740 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7741 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7742
7743 alloc.c: Import and export fewer symbols, and remove unused items.
7744 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7745 is defined.
7746 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7747 it's not optimized away by whole-program optimization.
7748 (message_enable_multibyte, free_misc): Remove.
7749 (catchlist, handlerlist, mark_backtrace):
7750 Declare only if BYTE_MARK_STACK.
7751 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7752 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7753 (message_enable_multibyte): Remove decl.
7754 (free_misc, interval_free_list, float_block, float_block_index):
7755 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7756 (cons_free_list, last_marked_index):
7757 Now static.
7758 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7759 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7760 (mark_backtrace): Define only if BYTE_MARK_STACK.
7761 * xdisp.c (message_enable_multibyte): Now static.
7762
7763 Declare Lisp_Object Q* variables to be 'static' if not exported.
7764 This makes it easier for human readers (and static analyzers)
7765 to see whether these variables are used from other modules.
7766 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7767 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7768 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7769 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7770 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7771 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7772 * xmenu.c, xselect.c:
7773 Declare Q* vars static if they are not used in other modules.
7774 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7775 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7776 Remove decls of unexported vars.
7777 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7778
7779 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7780
7781 Make Emacs functions such as Fatom 'static' by default.
7782 This makes it easier for human readers (and static analyzers)
7783 to see whether these functions can be called from other modules.
7784 DEFUN now defines a static function. To make the function external
7785 so that it can be used in other C modules, use the new macro DEFUE.
7786 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7787 (Finit_image_library):
7788 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7789 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7790 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7791 Remove decls, since these functions are now static.
7792 (Funintern, Fget_internal_run_time): New decls, since these functions
7793 were already external.
7794
7795 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7796 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7797 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7798 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7799 * keyboard.c, keymap.c, lread.c:
7800 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7801 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7802 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7803 Mark functions with DEFUE instead of DEFUN,
7804 if they are used in other modules.
7805 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7806 decls for now-static functions.
7807 * buffer.h (Fdelete_overlay): Remove decl.
7808 * callproc.c (Fgetenv_internal): Mark as internal.
7809 * composite.c (Fremove_list_of_text_properties): Remove decl.
7810 (Fcomposition_get_gstring): New forward static decl.
7811 * composite.h (Fcomposite_get_gstring): Remove decl.
7812 * dired.c (Ffile_attributes): New forward static decl.
7813 * doc.c (Fdocumntation_property): New forward static decl.
7814 * eval.c (Ffetch_bytecode): New forward static decl.
7815 (Funintern): Remove extern decl; now in .h file where it belongs.
7816 * fileio.c (Fmake_symbolic_link): New forward static decl.
7817 * image.c (Finit_image_library): New forward static decl.
7818 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7819 * intervals.h (Fprevious_property_change):
7820 (Fremove_list_of_text_properties): Remove decls.
7821 * keyboard.c (Fthis_command_keys): Remove decl.
7822 (Fcommand_execute): New forward static decl.
7823 * keymap.c (Flookup_key): New forward static decl.
7824 (Fcopy_keymap): Now static.
7825 * keymap.h (Flookup_key): Remove decl.
7826 * process.c (Fget_process): New forward static decl.
7827 (Fprocess_datagram_address): Mark as internal.
7828 * syntax.c (Fsyntax_table_p): New forward static decl.
7829 (skip_chars): Remove duplicate decl.
7830 * textprop.c (Fprevious_property_change): New forward static decl.
7831 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7832 Now internal.
7833 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7834 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7835
7836 * editfns.c (Fformat): Remove unreachable code.
7837
7838 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7839
7840 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7841 change. (Bug#8496)
7842
7843 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7844
7845 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7846 when at ZV. (Bug#8487)
7847
7848 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7849
7850 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7851 (Bug#8437)
7852 * keyboard.c (parse_tool_bar_item): Likewise.
7853 * sound.c (sound_cleanup, alsa_close): Likewise.
7854 * termcap.c (tgetent): Likewise.
7855 * xfns.c (x_default_font_parameter): Likewise.
7856 * xsettings.c (read_and_apply_settings): Likewise.
7857
7858 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7859 (overrun_check_free): Protoize.
7860
7861 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7862
7863 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7864 since callers should never pass a negative size.
7865 Change the signature to match that of plain 'read' and 'write'; see
7866 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7867 * lisp.h: Update prototypes of emacs_write and emacs_read.
7868
7869 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7870
7871 * xdisp.c (redisplay_window): Don't try to determine the character
7872 position of the scroll margin if the window start point w->startp
7873 is outside the buffer's accessible region. (Bug#8468)
7874
7875 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7876
7877 Fix write-region and its subroutines for buffers > 2GB.
7878 * fileio.c (a_write, e_write): Modify declaration of arguments and
7879 local variables to support buffers larger than 2GB.
7880 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7881
7882 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7883 argument, local variables, and return value.
7884
7885 * lisp.h: Update prototypes of emacs_write and emacs_read.
7886
7887 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7888
7889 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7890
7891 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7892
7893 Fix more problems found by GCC 4.6.0's static checks.
7894
7895 * xdisp.c (vmessage): Use a better test for character truncation.
7896
7897 * charset.c (load_charset_map): <, not <=, for optimization,
7898 and to avoid potential problems with integer overflow.
7899 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7900 * casetab.c (set_identity, shuffle): Likewise.
7901 * editfns.c (Fformat): Likewise.
7902 * syntax.c (skip_chars): Likewise.
7903
7904 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7905 This also lets GCC 4.6.0 generate slightly better loop code.
7906
7907 * callint.c (Fcall_interactively): <, not <=, for optimization.
7908 (Fcall_interactively): Count the number of arguments produced,
7909 not the number of arguments given. This is simpler and lets GCC
7910 4.6.0 generate slightly better code.
7911
7912 * ftfont.c: Distingish more carefully between FcChar8 and char.
7913 The previous code passed unsigned char * to a functions like
7914 strlen and xstrcasecmp that expect char *, which does not
7915 conform to the C standard.
7916 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7917 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7918 char * when the C standard requires it.
7919
7920 * keyboard.c (read_char): Remove unused var.
7921
7922 * eval.c: Port to Windows vsnprintf (Bug#8435).
7923 Include <limits.h>.
7924 (SIZE_MAX): Define if the headers do not.
7925 (verror): Do not give up if vsnprintf returns a negative count.
7926 Instead, grow the buffer. This ports to Windows vsnprintf, which
7927 does not conform to C99. Problem reported by Eli Zaretskii.
7928 Also, simplify the allocation scheme, by avoiding the need for
7929 calling realloc, and removing the ALLOCATED variable.
7930
7931 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7932
7933 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7934 But keep the doprint source code for now, as we might revamp it
7935 and use it again (Bug#8435).
7936 * lisp.h (doprnt): Remove.
7937 * Makefile.in (base_obj): Remove doprnt.o.
7938 * deps.mk (doprnt.o): Remove.
7939
7940 error: Print 32- and 64-bit integers portably (Bug#8435).
7941 Without this change, on typical 64-bit hosts error ("...%d...", N)
7942 was used to print both 32- and 64-bit integers N, which relied on
7943 undefined behavior.
7944 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7945 * lisp.h (error, verror): Mark as printf-like functions.
7946 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7947 Report overflow in size calculations when allocating printf buffer.
7948 Do not truncate output string at its first null byte.
7949 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7950 Truncate the output at a character boundary, since vsnprintf does not
7951 do that.
7952 * charset.c (check_iso_charset_parameter): Convert internal
7953 character to string before calling 'error', since %c now has the
7954 printf meaning.
7955 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7956 overflow when computing char to be passed to 'error'. Do not
7957 pass Lisp_Object to 'error'; pass the integer instead.
7958 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7959 formatted with plain %d.
7960
7961 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7962
7963 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7964
7965 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7966
7967 * xterm.c (x_catch_errors): Remove duplicate declaration.
7968
7969 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7970
7971 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7972
7973 2011-04-10 Jim Meyering <meyering@redhat.com>
7974
7975 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7976 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7977 return ssize_t not "int", and use size_t as the buffer length.
7978 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7979 * gnutls.h: Update declarations.
7980 * process.c (read_process_output): Use ssize_t, to match.
7981 (send_process): Likewise.
7982
7983 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7984
7985 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7986
7987 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7988
7989 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7990 Use unsigned char, to match FcChar8 type definition.
7991
7992 * xterm.c (handle_one_xevent):
7993 * xmenu.c (create_and_show_popup_menu):
7994 * xselect.c (x_decline_selection_request)
7995 (x_reply_selection_request): Avoid type-punned deref of X events.
7996
7997 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7998
7999 Fix some uses of `int' instead of EMACS_INT.
8000 * search.c (string_match_1, fast_string_match)
8001 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8002 (scan_buffer, find_next_newline_no_quit)
8003 (find_before_next_newline, search_command, Freplace_match)
8004 (Fmatch_data): Make some `int' variables be EMACS_INT.
8005
8006 * xdisp.c (display_count_lines): 3rd argument and return value now
8007 EMACS_INT. All callers changed.
8008 (pint2hrstr): Last argument is now EMACS_INT.
8009
8010 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8011 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8012 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8013 (decode_coding_utf_16, decode_coding_emacs_mule)
8014 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8015 (decode_coding_ccl, decode_coding_charset)
8016 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8017 (decode_coding_iso_2022, decode_coding_emacs_mule)
8018 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8019 <char_offset, last_offset>: Declare EMACS_INT.
8020 (encode_coding_utf_8, encode_coding_utf_16)
8021 (encode_coding_emacs_mule, encode_invocation_designation)
8022 (encode_designation_at_bol, encode_coding_iso_2022)
8023 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8024 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8025 Declare EMACS_INT.
8026 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8027 (encode_invocation_designation): Last argument P_NCHARS is now
8028 EMACS_INT.
8029 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8030 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8031
8032 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8033 All users changed.
8034
8035 * ccl.c (Fccl_execute_on_string): Declare some variables
8036 EMACS_INT.
8037
8038 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8039
8040 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8041
8042 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8043
8044 * process.c (Fformat_network_address): Doc fix.
8045
8046 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8047
8048 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8049
8050 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8051
8052 * keyboard.c (read_char): Call Lisp function help-form-show,
8053 instead of using internal_with_output_to_temp_buffer.
8054 (Qhelp_form_show): New var.
8055 (syms_of_keyboard): Use DEFSYM macro.
8056
8057 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8058
8059 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8060
8061 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8062
8063 * process.c (Flist_processes): Remove to Lisp.
8064 (list_processes_1): Delete.
8065
8066 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8067
8068 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8069
8070 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8071
8072 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8073
8074 Fix more problems found by GCC 4.6.0's static checks.
8075
8076 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8077
8078 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8079
8080 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8081
8082 * xdisp.c (vmessage): Mark as a printf-like function.
8083
8084 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8085
8086 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8087
8088 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8089 printf-like functions.
8090 (tiff_load): Add casts to remove these marks before passing them
8091 to system-supplied API.
8092
8093 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8094
8095 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8096 This avoids several warnings with gcc -Wstrict-overflow.
8097 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8098 directly, rather than having caller test rule sign. This avoids
8099 some unnecessary tests.
8100 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8101 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8102 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8103
8104 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8105 (xfont_open): Avoid unnecessary tests.
8106
8107 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8108
8109 * composite.h, composite.c (composition_gstring_put_cache):
8110 Use EMACS_INT, not int, for length.
8111
8112 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8113 breaking out part of COMPOSITION_DECODE_RULE.
8114 (COMPOSITION_DECODE_RULE): Use it.
8115 * composite.c (get_composition_id): Remove unused local vars,
8116 by using the new macro.
8117
8118 * textprop.c (set_text_properties_1): Change while to do-while,
8119 since the condition is always true at first.
8120
8121 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8122 (interval_deletion_adjustment): Return unsigned value.
8123 All uses changed.
8124
8125 * process.c (list_processes_1, create_pty, read_process_output):
8126 (exec_sentinel): Remove vars that were set but not used.
8127 (create_pty): Remove unnecessary "volatile"s.
8128 (Fnetwork_interface_info): Avoid possibility of int overflow.
8129 (read_process_output): Do adaptive read buffering even if carryover.
8130 (read_process_output): Simplify nbytes computation if buffered.
8131
8132 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8133
8134 * syntax.c (scan_words): Remove var that was set but not used.
8135 (update_syntax_table): Use unsigned instead of int.
8136
8137 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8138 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8139 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8140
8141 * print.c (print_error_message): Avoid int overflow.
8142
8143 * font.c (font_list_entities): Redo for clarity,
8144 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8145
8146 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8147 (font_score): Avoid potential overflow in diff calculation.
8148
8149 * fns.c (substring_both): Remove var that is set but not used.
8150 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8151
8152 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8153
8154 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8155 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8156 can always succeed if overflow has undefined behavior.
8157
8158 * search.c (boyer_moore, wordify): Remove vars set but not used.
8159 (wordify): Omit three unnecessary tests.
8160
8161 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8162 All callers changed. This avoids the need for an unused var.
8163
8164 * casefiddle.c (casify_region): Remove var that is set but not used.
8165
8166 * dired.c (file_name_completion): Remove var that is set but not used.
8167
8168 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8169
8170 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8171 (Finsert_file_contents): Remove unnecessary code checking fd.
8172
8173 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8174 Check for integer overflow on size calculations.
8175
8176 * buffer.c (Fprevious_overlay_change): Remove var that is set
8177 but not used.
8178
8179 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8180 Remove vars that are set but not used.
8181 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8182 (timer_check_2): Mark vars as initialized.
8183
8184 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8185
8186 * image.c (lookup_image): Remove var that is set but not used.
8187 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8188
8189 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8190 that are set but not used.
8191
8192 * xfns.c (make_invisible_cursor): Don't return garbage
8193 if XCreateBitmapFromData fails (Bug#8410).
8194
8195 * xselect.c (x_get_local_selection, x_handle_property_notify):
8196 Remove vars that are set but not used.
8197
8198 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8199 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8200
8201 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8202 Remove var that is set but not used.
8203 (scroll_bar_windows_size): Now size_t, not int.
8204 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8205 Check for overflow.
8206
8207 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8208 (map_tty_color) [!defined MSDOS]: Likewise.
8209
8210 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8211
8212 * coding.c: Remove vars that are set but not used.
8213 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8214 All callers changed.
8215 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8216 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8217 (decode_coding_charset): Remove vars that are set but not used.
8218
8219 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8220 that is set but not used.
8221
8222 * print.c (print_object): Remove var that is set but not used.
8223
8224 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8225 The gnulib version avoids calling malloc in the usual case,
8226 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8227 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8228 * filelock.c (current_lock_owner): Likewise.
8229 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8230 * sysdep.c: Include allocator.h, careadlinkat.h.
8231 (emacs_no_realloc_allocator): New static constant.
8232 (emacs_readlink): New function.
8233 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8234 ../lib/careadlinkat.h.
8235
8236 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8237
8238 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8239 first non-nil return value).
8240
8241 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8242
8243 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8244 if not defined (Bug#8403).
8245
8246 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8247
8248 * xdisp.c (display_count_lines): Remove parameter `start',
8249 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8250 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8251 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8252 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8253 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8254 and thereabouts. All callers changed.
8255 (get_per_char_metric): Remove parameter `f', unused since
8256 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8257
8258 2011-04-02 Jim Meyering <meyering@redhat.com>
8259
8260 do not dereference NULL upon failed strdup
8261 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8262 (ns_get_family): Likewise.
8263
8264 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8265
8266 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8267
8268 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8269
8270 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8271 later (Bug#8403).
8272
8273 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8274
8275 Add lexical binding.
8276
8277 * window.c (Ftemp_output_buffer_show): New fun.
8278 (Fsave_window_excursion):
8279 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8280
8281 * lread.c (lisp_file_lexically_bound_p): New function.
8282 (Fload): Bind Qlexical_binding.
8283 (readevalloop): Remove `evalfun' arg.
8284 Bind Qinternal_interpreter_environment.
8285 (Feval_buffer): Bind Qlexical_binding.
8286 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8287 Mark as dynamic.
8288 (syms_of_lread): Declare `lexical-binding'.
8289
8290 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8291
8292 * keyboard.c (eval_dyn): New fun.
8293 (menu_item_eval_property): Use it.
8294
8295 * image.c (parse_image_spec): Use Ffunctionp.
8296
8297 * fns.c (concat, mapcar1): Accept byte-code-functions.
8298
8299 * eval.c (Fsetq): Handle lexical vars.
8300 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8301 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8302 (FletX, Flet): Obey lexical binding.
8303 (Fcommandp): Handle closures.
8304 (Feval): New `lexical' arg.
8305 (eval_sub): New function extracted from Feval. Use it almost
8306 everywhere where Feval was used. Look up vars in lexical env.
8307 Handle closures.
8308 (Ffunctionp): Move from subr.el.
8309 (Ffuncall): Handle closures.
8310 (apply_lambda): Remove `eval_flags'.
8311 (funcall_lambda): Handle closures and new byte-code-functions.
8312 (Fspecial_variable_p): New function.
8313 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8314 but without exporting it to Lisp.
8315
8316 * doc.c (Fdocumentation, store_function_docstring):
8317 * data.c (Finteractive_form): Handle closures.
8318
8319 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8320 interactive spec.
8321
8322 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8323 New byte-codes.
8324 (exec_byte_code): New function extracted from Fbyte_code to handle new
8325 calling convention for byte-code-functions. Add new byte-codes.
8326
8327 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8328
8329 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8330
8331 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8332
8333 * xdisp.c (redisplay_internal): Fix prototype.
8334
8335 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8336
8337 * xdisp.c (SCROLL_LIMIT): New macro.
8338 (try_scrolling): Use it when setting scroll_limit.
8339 Limit scrolling to 100 screen lines.
8340 (redisplay_window): Even when falling back on "recentering",
8341 position point in the window according to scroll-conservatively,
8342 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8343
8344 (try_scrolling): When point is above the window, allow searching
8345 as far as scroll_max, or one screenful, to compute vertical
8346 distance from PT to the scroll margin position. This prevents
8347 try_scrolling from unnecessarily failing when
8348 scroll-conservatively is set to a value slightly larger than the
8349 window height. Clean up the case of PT below the margin at bottom
8350 of window: scroll_max can no longer be INT_MAX. When aggressive
8351 scrolling is in use, don't let point enter the opposite scroll
8352 margin as result of the scroll.
8353 (syms_of_xdisp) <scroll-conservatively>: Document the
8354 threshold of 100 lines for never-recentering scrolling.
8355
8356 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8357
8358 * dispextern.h (move_it_by_lines):
8359 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8360 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8361 (message_log_check_duplicate): Remove parameters `prev_bol' and
8362 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8363 (redisplay_internal): Remove parameter `preserve_echo_area',
8364 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8365
8366 * indent.c (Fvertical_motion):
8367 * window.c (window_scroll_pixel_based, Frecenter):
8368 Don't pass `need_y_p' to `move_it_by_lines'.
8369
8370 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8371
8372 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8373 steal a few bits to be more compact.
8374 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8375 Remove unneeded casts.
8376
8377 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8378
8379 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8380
8381 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8382 binding" message (bug#7967).
8383
8384 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8385
8386 Fix more problems found by GCC 4.6.0's static checks.
8387
8388 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8389 Remove unused local var.
8390
8391 * editfns.c (Fmessage_box): Remove unused local var.
8392
8393 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8394 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8395 Omit unused local vars.
8396 * window.c (shrink_windows): Omit unused local var.
8397 * menu.c (digest_single_submenu): Omit unused local var.
8398 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8399 Omit unused local var.
8400
8401 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8402 Don't assume string length fits in int.
8403 (keyremap_step, read_key_sequence): Use size_t for sizes.
8404 (read_key_sequence): Don't check last_real_key_start redundantly.
8405
8406 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8407 instead of alloca (Bug#8344).
8408
8409 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8410 (Fbacktrace_frame): Don't assume nframes fits in int.
8411
8412 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8413
8414 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8415 concerns.
8416
8417 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8418
8419 * cm.c (calccost): Turn while-do into do-while, for clarity.
8420
8421 * keyboard.c (syms_of_keyboard): Use the same style as later
8422 in this function when indexing through an array. This also
8423 works around GCC bug 48267.
8424
8425 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8426
8427 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8428
8429 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8430 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8431
8432 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8433 This avoids undefined behavior on integer overflow, and is a bit
8434 more convenient anyway since it is compared to a size_t variable.
8435
8436 Variadic C functions now count arguments with size_t, not int.
8437 This avoids an unnecessary limitation on 64-bit machines, which
8438 caused (substring ...) to crash on large vectors (Bug#8344).
8439 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8440 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8441 All variadic functions and their callers changed accordingly.
8442 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8443 * data.c (arith_driver, float_arith_driver): Likewise.
8444 * editfns.c (general_insert_function): Likewise.
8445 * eval.c (struct backtrace.nargs, interactive_p)
8446 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8447 (funcall_lambda, mark_backtrace): Likewise.
8448 * fns.c (concat): Likewise.
8449 * frame.c (x_set_frame_parameters): Likewise.
8450 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8451 0 if not found, not -1. All callers changed.
8452
8453 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8454 (stack_copy_size): Now size_t, not int.
8455 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8456
8457 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8458
8459 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8460 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8461 All callers changed.
8462
8463 * lisp.h (multibyte_char_to_unibyte):
8464 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8465 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8466 * character.h (CHAR_TO_BYTE8):
8467 * cmds.c (internal_self_insert):
8468 * editfns.c (general_insert_function):
8469 * keymap.c (push_key_description):
8470 * search.c (Freplace_match):
8471 * xdisp.c (message_dolog, set_message_1): All callers changed.
8472
8473 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8474
8475 * keyboard.c (safe_run_hook_funcall): New function.
8476 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8477 don't set the hook to nil, but remove the offending function instead.
8478 (Qcommand_hook_internal): Remove, unused.
8479 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8480 Vcommand_hook_internal.
8481
8482 * eval.c (enum run_hooks_condition): Remove.
8483 (funcall_nil, funcall_not): New functions.
8484 (run_hook_with_args): Call each function through a `funcall' argument.
8485 Remove `cond' argument, now redundant.
8486 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8487 (Frun_hook_with_args_until_failure): Adjust accordingly.
8488 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8489
8490 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8491
8492 * dispextern.h (string_buffer_position): Remove declaration.
8493
8494 * print.c (strout): Remove parameter `multibyte', unused since
8495 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8496
8497 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8498 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8499 All callers changed.
8500
8501 * w32.c (_wsa_errlist): Use braces for struct initializers.
8502
8503 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8504 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8505 All callers changed.
8506 (string_buffer_position): Likewise. Also, make static (it's never
8507 used outside xdisp.c).
8508 (cursor_row_p): Remove parameter `w', unused since
8509 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8510 (decode_mode_spec): Remove parameter `precision', introduced during
8511 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8512 All callers changed.
8513
8514 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8515
8516 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8517
8518 2011-03-27 Anders Lindgren <andlind@gmail.com>
8519
8520 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8521 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8522 (ns_update_auto_hide_menu_bar): New functions.
8523 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8524 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8525 ns_constrain_all_frames.
8526 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8527 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8528
8529 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8530
8531 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8532
8533 2011-03-27 Glenn Morris <rgm@gnu.org>
8534
8535 * syssignal.h: Replace RETSIGTYPE with void.
8536 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8537 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8538 Replace SIGTYPE with void everywhere.
8539 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8540 * s/template.h (SIGTYPE): Remove commented out definition.
8541
8542 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8543
8544 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8545 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8546
8547 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8548
8549 * w32.c (read_unc_volume): Use parameter `henum', instead of
8550 global variable `wget_enum_handle'.
8551
8552 * keymap.c (describe_vector): Remove parameters `indices' and
8553 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8554 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8555
8556 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8557
8558 * keyboard.c (timer_check): Remove parameter `do_it_now',
8559 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8560 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8561 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8562
8563 * keyboard.c (read_char):
8564 * w32menu.c (w32_menu_display_help):
8565 * xmenu.c (show_help_event, menu_help_callback):
8566 Adjust calls to `show_help_echo'.
8567
8568 * gtkutil.c (xg_maybe_add_timer):
8569 * keyboard.c (readable_events):
8570 * process.c (wait_reading_process_output):
8571 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8572
8573 * insdel.c (adjust_markers_gap_motion):
8574 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8575 (gap_left, gap_right): Don't call it.
8576
8577 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8578
8579 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8580 incurred during fontification.
8581
8582 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8583
8584 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8585 (DEFVAR_PER_BUFFER): Don't pass it.
8586
8587 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8588 (scrolling_window): Don't pass it.
8589
8590 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8591
8592 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8593
8594 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8595 and `suffix'.
8596 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8597 of variables specific to SELinux and computation of `encoded_absname'.
8598
8599 * image.c (XPutPixel): Remove unused variable `height'.
8600
8601 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8602
8603 * unexw32.c (get_section_info): Remove unused variable `section'.
8604
8605 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8606 (system_process_attributes): Remove unused variable `sess'.
8607 (sys_read): Remove unused variable `err'.
8608
8609 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8610 (w32_wnd_proc): Remove unused variable `isdead'.
8611 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8612 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8613 (x_create_tip_frame): Remove unused variable `tem'.
8614
8615 * w32inevt.c (w32_console_read_socket):
8616 Remove unused variable `no_events'.
8617
8618 * w32term.c (x_draw_composite_glyph_string_foreground):
8619 Remove unused variable `width'.
8620
8621 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8622
8623 * w32term.c (x_set_glyph_string_clipping):
8624 Don't pass uninitialized region to CombineRgn.
8625
8626 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8627
8628 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8629 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8630 (Fx_close_connection): Remove unused variable `i'.
8631
8632 * w32font.c (w32font_draw): Return number of glyphs.
8633 (w32font_open_internal): Remove unused variable `i'.
8634 (w32font_driver): Add missing initializer.
8635
8636 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8637 (fill_in_menu): Remove unused variable `items_added'.
8638
8639 * w32term.c (last_mouse_press_frame): Remove static global variable.
8640 (w32_clip_to_row): Remove unused variable `f'.
8641 (x_delete_terminal): Remove unused variable `i'.
8642
8643 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8644 (NOTHING): Remove unused static global variable.
8645 (uniscribe_check_otf): Remove unused variable `table'.
8646 (uniscribe_font_driver): Add missing initializers.
8647
8648 2011-03-23 Julien Danjou <julien@danjou.info>
8649
8650 * term.c (Fsuspend_tty, Fresume_tty):
8651 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8652 * window.c (temp_output_buffer_show):
8653 * insdel.c (signal_before_change):
8654 * frame.c (Fhandle_switch_frame):
8655 * fileio.c (Fdo_auto_save):
8656 * emacs.c (Fkill_emacs):
8657 * editfns.c (save_excursion_restore):
8658 * cmds.c (internal_self_insert):
8659 * callint.c (Fcall_interactively):
8660 * buffer.c (Fkill_all_local_variables):
8661 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8662 Use Frun_hooks.
8663 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8664 unconditionally since it does the check itself.
8665
8666 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8667
8668 Fix more problems found by GCC 4.5.2's static checks.
8669
8670 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8671 the first time through the loop, since we know p0 < p1 then.
8672 This also avoids a gcc -Wstrict-overflow warning.
8673
8674 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8675 leading to a memory leak, possible in functions like
8676 load_charset_map_from_file that can allocate an unbounded number
8677 of objects (Bug#8318).
8678
8679 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8680 that could (at least in theory) be that large.
8681
8682 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8683 This is less likely to overflow, and avoids undefined behavior if
8684 overflow does occur. All callers changed. Use strtoul to scan
8685 for the unsigned long integer.
8686 (pint2hrstr): Simplify and tune code slightly.
8687 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8688
8689 * scroll.c (do_scrolling): Work around GCC bug 48228.
8690 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8691
8692 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8693 This also avoids a warning with gcc -Wstrict-overflow.
8694 (validate_x_resource_name): Simplify count usage.
8695 This also avoids a warning with gcc -Wstrict-overflow.
8696
8697 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8698 fail (Bug#8306).
8699
8700 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8701
8702 * process.c (Fmake_network_process): Use socklen_t, not int,
8703 where POSIX says socklen_t is required in portable programs.
8704 This fixes a porting bug on hosts like 64-bit HP-UX, where
8705 socklen_t is wider than int (Bug#8277).
8706 (Fmake_network_process, server_accept_connection):
8707 (wait_reading_process_output, read_process_output):
8708 Likewise.
8709
8710 * process.c: Rename or move locals to avoid shadowing.
8711 (list_processes_1, Fmake_network_process):
8712 (read_process_output_error_handler, exec_sentinel_error_handler):
8713 Rename or move locals.
8714 (Fmake_network_process): Define label "retry_connect" only if needed.
8715 (Fnetwork_interface_info): Fix pointer signedness.
8716 (process_send_signal): Add cast to avoid pointer signedness problem.
8717 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8718 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8719
8720 Make tparam.h and terminfo.c consistent.
8721 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8722 Include tparam.h instead, since it declares them.
8723 * cm.h (PC): Remove extern decl; tparam.h now does this.
8724 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8725 * terminfo.c: Include tparam.h, to check interfaces.
8726 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8727 (tparam): Adjust signature to match interface in tparam.h;
8728 this removes some undefined behavior. Check that outstring and len
8729 are zero, which they always are with Emacs.
8730 * tparam.h (PC, BC, UP): New extern decls.
8731
8732 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8733 (xftfont_open): Rename locals to avoid shadowing.
8734
8735 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8736 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8737 (OTF_TAG_SYM): Omit macro if not needed.
8738 (ftfont_list): Remove unused local.
8739 (get_adstyle_property, ftfont_pattern_entity):
8740 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8741 Rename locals to avoid shadowing.
8742
8743 * xfont.c (xfont_list_family): Mark var as initialized.
8744
8745 * xml.c (make_dom): Now static.
8746
8747 * composite.c (composition_compute_stop_pos): Rename local to
8748 avoid shadowing.
8749 (composition_reseat_it): Remove unused locals.
8750 (find_automatic_composition, composition_adjust_point): Likewise.
8751 (composition_update_it): Mark var as initialized.
8752 (find_automatic_composition): Mark vars as initialized,
8753 with a FIXME (Bug#8290).
8754
8755 character.h: Rename locals to avoid shadowing.
8756 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8757 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8758 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8759 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8760 to avoid shadowing.
8761
8762 * textprop.c (property_change_between_p): Remove; unused.
8763
8764 * intervals.c (interval_start_pos): Now static.
8765
8766 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8767
8768 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8769 Rename locals to avoid shadowing.
8770
8771 * sound.c (wav_play, au_play, Fplay_sound_internal):
8772 Fix pointer signedness.
8773 (alsa_choose_format): Remove unused local var.
8774 (wav_play): Initialize a variable to 0, to prevent undefined
8775 behavior (Bug#8278).
8776
8777 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8778
8779 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8780
8781 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8782 clobbering (Bug#8298).
8783 * sysdep.c (sys_subshell): Likewise.
8784 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8785
8786 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8787 This should get cleaned up, so that child_setup has the
8788 same signature on all platforms.
8789
8790 * callproc.c (call_process_cleanup): Now static.
8791 (relocate_fd): Rename locals to avoid shadowing.
8792
8793 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8794
8795 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8796 not to be necessary, and produces flickering.
8797
8798 2011-03-20 Glenn Morris <rgm@gnu.org>
8799
8800 * config.in: Remove file.
8801
8802 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8803
8804 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8805 are now in src/globals.h.
8806 (syms_of_minibuf): Remove spurious & from previous change.
8807
8808 2011-03-20 Leo Liu <sdl.web@gmail.com>
8809
8810 * minibuf.c (completing-read-function): New variable.
8811 (completing-read-default): Rename from completing-read.
8812 (completing-read): Call completing-read-function.
8813
8814 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8815
8816 * xfaces.c (Fx_load_color_file):
8817 Read color file from absolute filename (bug#8250).
8818
8819 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8820
8821 * makefile.w32-in: Update dependencies.
8822
8823 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8824
8825 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8826
8827 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8828
8829 Fix more problems found by GCC 4.5.2's static checks.
8830
8831 * process.c (make_serial_process_unwind, send_process_trap):
8832 (sigchld_handler): Now static.
8833
8834 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8835 That way, the code declares only the vars that it needs.
8836 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8837 * s/cygwin.h (PTY_ITERATION): Likewise.
8838 * s/darwin.h (PTY_ITERATION): Likewise.
8839 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8840
8841 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8842 * process.c (allocate_pty): Don't declare stb unless it's needed.
8843
8844 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8845 (CONSTANTLIM): Remove; unused.
8846 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8847 Define only if needed.
8848
8849 * unexelf.c (unexec): Name an expression,
8850 to avoid gcc -Wbad-function-cast warning.
8851 Use a different way to cause a compilation error if anyone uses
8852 n rather than nn, a way that does not involve shadowing.
8853 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8854
8855 * deps.mk (unexalpha.o): Remove; unused.
8856
8857 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8858 * unexec.h: New file.
8859 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8860 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8861 Depend on unexec.h.
8862 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8863 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8864 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8865 Change as necessary to match prototype in unexec.h.
8866
8867 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8868 shadowing.
8869 (back_comment, skip_chars): Mark vars as initialized.
8870
8871 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8872 Rename locals to avoid shadowing.
8873
8874 * lread.c (read1): Rewrite so as not to use empty "else".
8875 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8876
8877 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8878
8879 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8880 warning when compiling print.c.
8881
8882 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8883 instead of using an uninitialized var.
8884 (font_sort_entities): Mark var as initialized.
8885
8886 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8887
8888 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8889 pointers to constants.
8890 (font_parse_fcname): Remove unused vars.
8891 (font_delete_unmatched): Now static.
8892 (font_get_spec): Remove; unused.
8893 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8894 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8895 Rename or move locals to avoid shadowing.
8896
8897 * fns.c (require_nesting_list, require_unwind): Now static.
8898 (Ffillarray): Rename locals to avoid shadowing.
8899
8900 * floatfns.c (domain_error2): Define only if needed.
8901 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8902
8903 * alloc.c (mark_backtrace): Move decl from here ...
8904 * lisp.h: ... to here, so that it can be checked.
8905
8906 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8907 (Fdefvar): Rewrite so as not to use empty "else".
8908 (lisp_indirect_variable): Name an expression,
8909 to avoid gcc -Wbad-function-cast warning.
8910 (Fdefvar): Rename locals to avoid shadowing.
8911
8912 * callint.c (quotify_arg, quotify_args): Now static.
8913 (Fcall_interactively): Rename locals to avoid shadowing.
8914 Use const pointer when appropriate.
8915
8916 * lisp.h (get_system_name, get_operating_system_release):
8917 Move decls here, to check interfaces.
8918 * process.c (get_operating_system_release): Move decl to lisp.h.
8919 * xrdb.c (get_system_name): Likewise.
8920 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8921 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8922 some of which prompt warnings from gcc -Wbad-function-cast.
8923 (Fformat_time_string, Fencode_time, Finsert_char):
8924 (Ftranslate_region_internal, Fformat):
8925 Rename or remove local vars to avoid shadowing.
8926 (Ftranslate_region_internal): Mark var as initialized.
8927
8928 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8929 avoid shadowing.
8930
8931 * lisp.h (eassert): Check that the argument compiles, even if
8932 ENABLE_CHECKING is not defined.
8933
8934 * data.c (Findirect_variable): Name an expression, to avoid
8935 gcc -Wbad-function-cast warning.
8936 (default_value, arithcompare, arith_driver, arith_error): Now static.
8937 (store_symval_forwarding): Rename local to avoid shadowing.
8938 (Fmake_variable_buffer_local, Fmake_local_variable):
8939 Mark variables as initialized.
8940 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8941
8942 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8943 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8944 Rename locals to avoid shadowing.
8945 (mark_stack): Move local variables into the #ifdef region where
8946 they're used.
8947 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8948 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8949 needed otherwise.
8950 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8951 (GC_STRING_CHARS): Remove; not used.
8952 (Fmemory_limit): Cast sbrk's returned value to char *.
8953
8954 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8955 avoids undefined behavior in theory.
8956
8957 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8958
8959 Use functions, not macros, for up- and down-casing (Bug#8254).
8960 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8961 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8962 to use the following functions instead of these macros.
8963 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8964 EMACS_INT, since callers assume the returned value fits in int.
8965 (upcase1): Likewise, for UPCASE_TABLE.
8966 (uppercasep, lowercasep, upcase): New static inline functions.
8967 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8968 the race-condition problem in the old DOWNCASE.
8969
8970 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8971 Rename locals to avoid shadowing.
8972 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8973 (regex_compile, re_search_2, re_match_2_internal):
8974 Remove unused local vars.
8975 (FREE_VAR): Rewrite so as not to use empty "else",
8976 which gcc can warn about.
8977 (regex_compile, re_match_2_internal): Mark locals as initialized.
8978 (RETALLOC_IF): Define only if needed.
8979 (WORDCHAR_P): Likewise. This one is never needed, but is used
8980 only in a comment talking about a compiler bug, so put inside
8981 the #if 0 of that comment.
8982 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8983 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8984 Remove; unused.
8985
8986 * search.c (boyer_moore): Rename locals to avoid shadowing.
8987 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8988 (PREV_CHAR_BOUNDARY): Likewise.
8989
8990 * search.c (simple_search): Remove unused var.
8991
8992 * dired.c (compile_pattern): Move decl from here ...
8993 * lisp.h: ... to here, so that it can be checked.
8994 (struct re_registers): New forward decl.
8995
8996 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8997
8998 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8999 All uses changed.
9000 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9001 Rename locals to avoid shadowing.
9002 (Fvertical_motion): Mark locals as initialized.
9003
9004 * casefiddle.c (casify_object, casify_region): Now static.
9005 (casify_region): Mark local as initialized.
9006
9007 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9008
9009 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9010 New macros, so that the caller can use some names other than
9011 gcpro1, gcpro2, etc.
9012 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9013 of the new macros.
9014 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9015 argument, for consistency with GCPRO2_VAR, etc: it is now the
9016 prefix of the variable, not the variable itself. All uses
9017 changed.
9018 * dired.c (directory_files_internal, file_name_completion):
9019 Rename locals to avoid shadowing.
9020
9021 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9022 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9023 dired.c's scmp function, had undefined behavior.
9024 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9025 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9026 * buffer.h: ... to here, because these macros use current_buffer,
9027 and the new implementation with inline functions needs to have
9028 current_buffer in scope now, rather than later when the macros
9029 are used.
9030 (downcase, upcase1): New static inline functions.
9031 (DOWNCASE, UPCASE1): Reimplement using these functions.
9032 This avoids undefined behavior in expressions like
9033 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9034 from race conditions in accessing the global variables
9035 case_temp1 and case_temp2.
9036 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9037 * lisp.h (case_temp1, case_temp2): Remove their decls.
9038 * character.h (ASCII_CHAR_P): Move from here ...
9039 * lisp.h: ... to here, so that the inline functions mentioned
9040 above can use them.
9041
9042 * dired.c (directory_files_internal_unwind): Now static.
9043
9044 * fileio.c (file_name_as_directory, directory_file_name):
9045 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9046 Now static.
9047 (file_name_as_directory): Use const pointers when appropriate.
9048 (Fexpand_file_name): Likewise. In particular, newdir might
9049 point at constant storage, so make it a const pointer.
9050 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9051 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9052 signedness issues.
9053 (Fset_file_times, Finsert_file_contents, auto_save_error):
9054 Rename locals to avoid shadowing.
9055
9056 * minibuf.c (choose_minibuf_frame_1): Now static.
9057 (Ftry_completion, Fall_completions): Rename or remove locals
9058 to avoid shadowing.
9059
9060 * marker.c (bytepos_to_charpos): Remove; unused.
9061
9062 * lisp.h (verify_bytepos, count_markers): New decls,
9063 so that gcc does not warn that these functions aren't declared.
9064
9065 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9066 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9067 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9068 (copy_text): Remove unused local var.
9069
9070 * filelock.c (within_one_second): Now static.
9071 (lock_file_1): Rename local to avoid shadowing.
9072
9073 * buffer.c (fix_overlays_before): Mark locals as initialized.
9074 (fix_start_end_in_overlays): Likewise. This function should be
9075 simplified by using pointers-to-pointers, but that's a different
9076 matter.
9077 (switch_to_buffer_1): Now static.
9078 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9079 (report_overlay_modification): Rename locals to avoid shadowing.
9080
9081 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9082 Fix pointer signedness issue.
9083 (sys_subshell): Mark local as volatile if checking for lint,
9084 to suppress a gcc -Wclobbered warning that does not seem to be right.
9085 (MAXPATHLEN): Define only if needed.
9086
9087 * process.c (serial_open, serial_configure): Move decls from here ...
9088 * systty.h: ... to here, so that they can be checked.
9089
9090 * fns.c (get_random, seed_random): Move extern decls from here ...
9091 * lisp.h: ... to here, so that they can be checked.
9092
9093 * sysdep.c (reset_io): Now static.
9094 (wait_for_termination_signal): Remove; unused.
9095
9096 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9097 (copy_keymap_item, append_key, push_text_char_description):
9098 Now static.
9099 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9100 (DENSE_TABLE_SIZE): Remove; unused.
9101 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9102 (describe_map_tree):
9103 Rename locals to avoid shadowing.
9104
9105 * keyboard.c: Declare functions static if they are not used elsewhere.
9106 (echo_char, echo_dash, cmd_error, top_level_2):
9107 (poll_for_input, handle_async_input): Now static.
9108 (read_char, kbd_buffer_get_event, make_lispy_position):
9109 (make_lispy_event, make_lispy_movement, apply_modifiers):
9110 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9111 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9112 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9113 (read_key_sequence, read_char): Mark locals as initialized.
9114 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9115
9116 * keyboard.h (make_ctrl_char): New decl.
9117 (mark_kboards): Move decl here ...
9118 * alloc.c (mark_kboards): ... from here.
9119
9120 * lisp.h (force_auto_save_soon): New decl.
9121
9122 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9123 (DEFINE_DUMMY_FUNCTION): New macro.
9124 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9125 Use it.
9126 (main): Add casts to avoid warnings
9127 if GCC considers string literals to be constants.
9128
9129 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9130
9131 * dbusbind.c: Pointer signedness fixes.
9132 (xd_signature, xd_append_arg, xd_initialize):
9133 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9134 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9135 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9136 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9137
9138 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9139 if GCC considers string literals to be constants.
9140 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9141
9142 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9143
9144 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9145 (print_preprocess, print_object): New macro to fix last change.
9146
9147 * print.c (print_preprocess): Don't forget font objects.
9148
9149 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9150
9151 * emacs.c (USAGE3): Doc fixes.
9152
9153 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9154
9155 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9156 structure.
9157
9158 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9159
9160 * lisp.h (VWindow_system, Qfile_name_history):
9161 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9162 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9163 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9164
9165 * w32select.c: Don't #include "keyboard.h".
9166 (run_protected): Add extern declaration for waiting_for_input.
9167
9168 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9169 * w32console.c (detect_input_pending, read_input_pending)
9170 (encode_terminal_code):
9171 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9172 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9173 (w32_system_caret_y, Qfile_name_history):
9174 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9175 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9176 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9177 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9178 * w32proc.c (Qlocal, report_file_error):
9179 * w32term.c (Vwindow_system, updating_frame):
9180 * w32uniscribe.c (initialized, uniscribe_font_driver):
9181 Remove unneeded extern declarations.
9182
9183 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9184
9185 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9186
9187 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9188
9189 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9190 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9191 These macros can no longer be used for assignment.
9192
9193 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9194 Assign struct members directly, instead of using BUF_BEGV etc.
9195 (record_buffer_markers, fetch_buffer_markers): New functions for
9196 recording and fetching special buffer markers.
9197 (set_buffer_internal_1, set_buffer_temp): Use them.
9198
9199 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9200
9201 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9202
9203 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9204 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9205
9206 * xdisp.c (hscroll_window_tree):
9207 (reconsider_clip_changes): Use PT instead of BUF_PT.
9208
9209 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9210
9211 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9212 $(EMACS_ROOT)/lib/intprops.h.
9213
9214 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9215
9216 Fix more problems found by GCC 4.5.2's static checks.
9217
9218 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9219 to unsigned char * to avoid compiler diagnostic.
9220 (xg_free_frame_widgets): Make it clear that a local variable is
9221 needed only if USE_GTK_TOOLTIP.
9222 (gdk_window_get_screen): Make it clear that this macro is needed
9223 only if USE_GTK_TOOLTIP.
9224 (int_gtk_range_get_value): New function, which avoids a diagnostic
9225 from gcc -Wbad-function-cast.
9226 (xg_set_toolkit_scroll_bar_thumb): Use it.
9227 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9228 diagnostic from gcc -Wbad-function-cast.
9229 (get_utf8_string, xg_get_file_with_chooser):
9230 Rename locals to avoid shadowing.
9231 (create_dialog): Move locals to avoid shadowing.
9232
9233 * xgselect.c (xg_select): Remove unused var.
9234
9235 * image.c (four_corners_best): Mark locals as initialized.
9236 (gif_load): Initialize transparent_p to zero (Bug#8238).
9237 Mark another local as initialized.
9238 (my_png_error, my_error_exit): Mark with NO_RETURN.
9239
9240 * image.c (clear_image_cache): Now static.
9241 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9242 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9243 (x_edge_detection): Remove unnecessary cast that
9244 gcc -Wbad-function-cast diagnoses.
9245 (gif_load): Fix pointer signedness.
9246 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9247 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9248
9249 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9250
9251 Improve quality of tests for time stamp overflow.
9252 For example, without this patch (encode-time 0 0 0 1 1
9253 1152921504606846976) returns the obviously-bogus value (-948597
9254 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9255 reports time overflow. See
9256 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9257 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9258 * editfns.c: Include limits.h and intprops.h.
9259 (TIME_T_MIN, TIME_T_MAX): New macros.
9260 (time_overflow): Move earlier, to before first use.
9261 (hi_time, lo_time): New functions, for an accurate test for
9262 out-of-range times.
9263 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9264 (Fget_internal_run_time): Don't assume time_t fits in int.
9265 (make_time): Use list2 instead of Fcons twice.
9266 (Fdecode_time): More accurate test for out-of-range times.
9267 (check_tm_member): New function.
9268 (Fencode_time): Use it, to test for out-of-range times.
9269 (lisp_time_argument): Don't rely on undefined left-shift and
9270 right-shift behavior when checking for time stamp overflow.
9271
9272 * editfns.c (time_overflow): New function, refactoring common code.
9273 (Fformat_time_string, Fdecode_time, Fencode_time):
9274 (Fcurrent_time_string): Use it.
9275
9276 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9277 * dired.c (make_time): Move to ...
9278 * editfns.c (make_time): ... here.
9279 * systime.h: Note the move.
9280
9281 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9282
9283 * fringe.c (update_window_fringes): Remove unused variables.
9284
9285 * unexmacosx.c (copy_data_segment): Also copy __got section.
9286 (Bug#8223)
9287
9288 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9289
9290 * termcap.c [MSDOS]: Include "msdos.h".
9291 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9292 Constify `char *' arguments and their references according to
9293 prototypes in tparam.h.
9294
9295 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9296
9297 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9298 Adapt all references accordingly.
9299
9300 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9301
9302 2011-03-11 Tom Tromey <tromey@redhat.com>
9303
9304 * buffer.c (syms_of_buffer): Remove obsolete comment.
9305
9306 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9307
9308 * termhooks.h (encode_terminal_code): Declare prototype.
9309
9310 * msdos.c (encode_terminal_code): Don't declare prototype.
9311
9312 * term.c (encode_terminal_code): Now external again, used by
9313 w32console.c and msdos.c.
9314
9315 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9316 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9317
9318 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9319
9320 Fix some minor problems found by GCC 4.5.2's static checks.
9321
9322 * fringe.c (update_window_fringes): Mark locals as initialized
9323 (Bug#8227).
9324 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9325
9326 * alloc.c (mark_fringe_data): Move decl from here ...
9327 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9328 to check its interface.
9329 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9330
9331 * fontset.c (free_realized_fontset): Now static.
9332 (Fset_fontset_font): Rename local to avoid shadowing.
9333 (fontset_font): Mark local as initialized.
9334 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9335
9336 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9337
9338 * xselect.c (x_disown_buffer_selections): Remove; not used.
9339 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9340 (x_own_selection, Fx_disown_selection_internal): Rename locals
9341 to avoid shadowing.
9342 (x_handle_dnd_message): Remove local to avoid shadowing.
9343
9344 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9345 so that the caller can use some name other than gcpro1.
9346 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9347 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9348 (Fx_backspace_delete_keys_p):
9349 Use them to avoid shadowing, and rename vars to avoid shadowing.
9350 (x_decode_color, x_set_name, x_window): Now static.
9351 (Fx_create_frame): Add braces to silence GCC warning.
9352 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9353 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9354 Remove unused locals.
9355 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9356 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9357 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9358 macros.
9359
9360 * xterm.h (x_mouse_leave): New decl.
9361
9362 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9363 Remove unused functions.
9364 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9365 (x_calc_absolute_position): Now static.
9366 (XTread_socket): Don't define label "out" unless it's used.
9367 Don't declare local "event" unless it's used.
9368 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9369 unless they are used.
9370 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9371 (x_fatal_error_signal): Remove; not used.
9372 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9373 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9374 (x_error_catcher, x_connection_closed, x_error_handler):
9375 (x_error_quitter, xembed_send_message, x_iconify_frame):
9376 (my_log_handler): Rename locals to avoid shadowing.
9377 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9378 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9379
9380 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9381 Rename or move locals to avoid shadowing.
9382 (tty_defined_color, merge_face_heights): Now static.
9383 (free_realized_faces_for_fontset): Remove; not used.
9384 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9385 does not deduce is never used uninitialized.
9386 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9387 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9388
9389 * terminal.c (store_terminal_param): Now static.
9390
9391 * xmenu.c (menu_highlight_callback): Now static.
9392 (set_frame_menubar): Remove unused local.
9393 (xmenu_show): Rename parameter to avoid shadowing.
9394 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9395 since they might point to immutable storage.
9396 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9397 since it's unused otherwise.
9398
9399 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9400 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9401 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9402 avoids a gcc -Wuninitialized diagnostic.
9403 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9404 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9405 does not deduce are never used uninitialized.
9406
9407 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9408
9409 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9410 * window.c (window_loop, size_window):
9411 (run_window_configuration_change_hook, enlarge_window): Likewise.
9412
9413 * window.c (display_buffer): Now static.
9414 (size_window): Mark variables that gcc -Wuninitialized
9415 does not deduce are never used uninitialized.
9416 * window.h (check_all_windows): New decl, to forestall
9417 gcc -Wmissing-prototypes diagnostic.
9418 * dispextern.h (bidi_dump_cached_states): Likewise.
9419
9420 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9421 shadowing.
9422 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9423 Include <limits.h>.
9424 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9425 and to avoid gcc -Wuninitialized warning.
9426 (load_charset_map): Mark variables that gcc -Wuninitialized
9427 does not deduce are never used uninitialized.
9428 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9429
9430 * coding.c (coding_set_source, coding_set_destination):
9431 Use "else { /* comment */ }" rather than "else /* comment */;"
9432 for clarity, and to avoid gcc -Wempty-body warning.
9433 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9434 a block, when the outer 'i' will do.
9435 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9436 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9437 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9438 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9439 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9440 Rename locals to avoid shadowing.
9441 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9442 * coding.c (emacs_mule_char, encode_invocation_designation):
9443 Now static, since they're not used elsewhere.
9444 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9445 (decode_coding_object, encode_coding_object, detect_coding_system):
9446 (decode_coding_emacs_mule): Mark variables that gcc
9447 -Wuninitialized does not deduce are never used uninitialized.
9448 (detect_coding_iso_2022): Initialize a local variable that might
9449 be used uninitialized. Leave a FIXME because it's not clear that
9450 this initialization is needed. (Bug#8211)
9451 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9452 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9453 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9454 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9455 Remove unused macros.
9456
9457 * category.c (hash_get_category_set): Remove unused local var.
9458 (copy_category_table): Now static, since it's not used elsewhere.
9459 * character.c (string_count_byte8): Likewise.
9460
9461 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9462 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9463
9464 * chartab.c (copy_sub_char_table): Now static, since it's not used
9465 elsewhere.
9466 (sub_char_table_ref_and_range, char_table_ref_and_range):
9467 Rename locals to avoid shadowing.
9468 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9469
9470 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9471 (BIDI_BOB): Remove unused macro.
9472
9473 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9474 deduce are never used uninitialized.
9475 * term.c (encode_terminal_code): Likewise.
9476
9477 * term.c (encode_terminal_code): Now static. Remove unused local.
9478
9479 * tparam.h: New file.
9480 * term.c, tparam.h: Include it.
9481 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9482 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9483 Move these decls to tparam.h, and make them agree with what
9484 is actually in tparam.c. The previous trick of using incompatible
9485 decls in different modules does not conform to the C standard.
9486 All callers of tparam changed to use tparam's actual API.
9487 * tparam.c (tparam1, tparam, tgoto):
9488 Use const pointers where appropriate.
9489
9490 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9491 * cm.h (struct cm): Likewise.
9492 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9493 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9494 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9495 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9496 (turn_on_face, init_tty): Likewise.
9497 * termchar.h (struct tty_display_info): Likewise.
9498
9499 * term.c (term_mouse_position): Rename local to avoid shadowing.
9500
9501 * alloc.c (mark_ttys): Move decl from here ...
9502 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9503
9504 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9505
9506 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9507
9508 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9509
9510 * search.c (compile_pattern_1): Remove argument regp, unused since
9511 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9512 (compile_pattern): Don't pass it.
9513
9514 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9515
9516 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9517 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9518 for ! HAVE_GTK3.
9519 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9520
9521 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9522
9523 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9524 gdk_window_get_screen, gdk_window_get_geometry,
9525 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9526 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9527 (xg_get_pixbuf_from_pixmap): New function.
9528 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9529 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9530 Call xg_get_pixbuf_from_pixmap instead of
9531 gdk_pixbuf_get_from_drawable.
9532 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9533 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9534 (xg_check_special_colors): Use GtkStyleContext and its functions
9535 for HAVE_GTK3.
9536 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9537 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9538 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9539 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9540 Call gtk_widget_get_preferred_size.
9541 (xg_frame_resized): gdk_window_get_geometry only takes 5
9542 parameters.
9543 (xg_win_to_widget, xg_event_is_for_menubar):
9544 Call gdk_x11_window_lookup_for_display.
9545 (xg_set_widget_bg): New function.
9546 (delete_cb): New function.
9547 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9548 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9549 (xg_set_background_color): Call xg_set_widget_bg.
9550 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9551 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9552 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9553 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9554 if ! HAVE_GTK3.
9555 (update_frame_tool_bar): Call gtk_widget_hide.
9556 (xg_initialize): Use GDK_KEY_g.
9557
9558 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9559 if ! HAVE_GTK3
9560 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9561
9562 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9563 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9564 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9565
9566 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9567
9568 * w32xfns.c (select_palette): Check success of RealizePalette against
9569 GDI_ERROR, not zero.
9570
9571 See ChangeLog.11 for earlier changes.
9572
9573 ;; Local Variables:
9574 ;; coding: utf-8
9575 ;; End:
9576
9577 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9578
9579 This file is part of GNU Emacs.
9580
9581 GNU Emacs is free software: you can redistribute it and/or modify
9582 it under the terms of the GNU General Public License as published by
9583 the Free Software Foundation, either version 3 of the License, or
9584 (at your option) any later version.
9585
9586 GNU Emacs is distributed in the hope that it will be useful,
9587 but WITHOUT ANY WARRANTY; without even the implied warranty of
9588 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9589 GNU General Public License for more details.
9590
9591 You should have received a copy of the GNU General Public License
9592 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.