1 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
3 Utility function to make a list from specified amount of objects.
4 * lisp.h (enum constype): New datatype.
5 (listn): New prototype.
6 * alloc.c (listn): New function.
7 (Fmemory_use_count, syms_of_alloc): Use it.
8 * buffer.c (syms_of_buffer): Likewise.
9 * callint.c (syms_of_callint): Likewise.
10 * charset.c (define_charset_internal): Likewise.
11 * coding.c (syms_of_coding): Likewise.
12 * keymap.c (syms_of_keymap): Likewise.
13 * search.c (syms_of_search): Likewise.
14 * syntax.c (syms_of_syntax): Likewise.
15 * w32.c (init_environment): Likewise.
16 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
17 * xdisp.c (syms_of_xdisp): Likewise.
18 * xfns.c (syms_of_xfns): Likewise.
20 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
22 Fast save_excursion_save and save_excursion_restore.
23 * lisp.h (struct Lisp_Excursion): New data type.
24 (PVEC_EXCURSION): New pseudovector type.
25 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
26 to deal with it. Adjust comments.
27 (init_marker, attach_marker): New prototype.
28 (unchain_marker): Adjust prototype.
29 * marker.c (attach_marker): Change to global.
30 (init_marker): New function.
31 * alloc.c (Fmake_marker, build_marker): Use it.
32 (build_marker): More easserts.
33 (mark_object): Handle struct Lisp_Excursion.
34 * editfns.c (save_excursion_save, save_excursion_restore):
35 Reimplement to use struct Lisp_Excursion. Add comments.
37 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
39 Fix export of symbols to GDB (Bug#12036).
40 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
41 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
42 emacs.c, as this is a more-suitable home. Had this been done earlier
43 the fix for 12036 would have avoided some of the problems noted in
44 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
45 would have been more obvious.
46 * emacs.c: Do not include <verify.h>; no longer needed.
47 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
48 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
49 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
50 Remove; now done in lisp.h.
51 * lisp.h (PUBLISH_TO_GDB): New macro.
52 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
53 (DATA_SEG_BITS): Use it.
54 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
55 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
56 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
57 not be usable in #if. This simplifies things.
59 2012-07-26 Juanma Barranquero <lekktu@gmail.com>
61 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
63 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
65 Simplify export of symbols to GDB (Bug#12036).
66 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
67 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
68 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
69 Adjust to changes in lisp.h and emacs.c, by using
70 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
71 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
72 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
73 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
74 instead of gdb_valbits.
75 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
76 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
77 instead of gdb_array_mark_flag.
78 (xboolvector): Get size from $->size, not $->header.size.
79 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
80 (xreload, hook-run, hookpost-run): Remove.
81 * emacs.c: Include <verify.h>.
82 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
83 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
85 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
86 (gdb_USE_LSB_TAG): New enum constants.
87 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
88 Also define these as enum constants, so they're visible to GDB.
89 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
90 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
91 as constants, so they're visible to GDB.
92 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
93 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
94 Now enum constants, not macros, so they're visible to GDB.
95 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
96 more convenient now. All uses changed.
97 (VALMASK) [USE_LSB_TAG]: Also define in this case.
98 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
100 2012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
102 Explicitly free restriction data that are not needed anymore.
103 * editfns.c (save_restriction_restore): Free restriction data.
105 2012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
107 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
108 add argument, tune behavior, and adjust all callers.
110 2012-07-25 Paul Eggert <eggert@cs.ucla.edu>
112 Use typedef for EMACS_INT, EMACS_UINT.
113 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
114 than macros. This simplifies debugging in the usual case, since
115 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
116 and it allows expressions involving EMACS_INT casts.
117 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
119 2012-07-25 Jan Djärv <jan.h.d@swipnet.se>
121 * nsterm.m (ns_read_socket): Return early if there is a modal
124 2012-07-25 Martin Rudalics <rudalics@gmx.at>
126 * frame.c (Fredirect_frame_focus): In doc-string don't mention
127 that FOCUS-FRAME can be omitted.
129 2012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
131 Adjust buffer text indirection counters at the end of Fkill_buffer.
132 * buffer.c (Fkill_buffer): Adjust indirection counters when the
133 buffer is definitely dead. This should really fix an issue reported
134 by Christoph Scholtes again. (Bug#12007).
135 (init_buffer_once): Initialize indirection counters of
136 buffer_defaults and buffer_local_symbols (for sanity and safety).
138 2012-07-24 Eli Zaretskii <eliz@gnu.org>
140 * xdisp.c (init_iterator): Don't compute dimensions of truncation
141 and continuation glyphs on tooltip frames, leave them at zero.
142 Avoids continued lines in tooltips. (Bug#11832)
144 2012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
146 Simplify copy_overlay.
147 * buffer.c (copy_overlay): Simplify. Use build_marker.
148 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
150 2012-07-23 Eli Zaretskii <eliz@gnu.org>
152 * print.c (print_object): Don't crash when a frame's name is nil
153 or invalid. (Bug#12025)
155 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
156 it signals an error when a tooltip frame is being created.
158 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
160 Cleanup miscellaneous objects allocation and initialization.
161 * alloc.c (allocate_misc): Change to static. Add argument to
162 specify the subtype. Adjust comment and users.
163 (build_overlay): New function.
164 * buffer.c (copy_overlays, Fmake_overlay): Use it.
165 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
166 (allocate_misc): Remove prototype.
167 (build_overlay): Add prototype.
169 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
171 Swap buffer text indirection counters in Fbuffer_swap_text.
172 * buffer.c (Fbuffer_swap_text): Swap indirections too.
173 This avoids crash reported by Christoph Scholtes at
174 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
176 2012-07-22 Jan Djärv <jan.h.d@swipnet.se>
178 * nsmenu.m (Popdown_data): New struct.
179 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
181 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
182 (initWithContentRect): Make imgView and contentView non-static
183 and autorelease them. Also autorelease img and matrix (Bug#12005).
184 (dealloc): Remove (Bug#12005).
186 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
188 Adjust consing_since_gc when objects are explicitly freed.
189 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
190 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
191 (free_cons, free_misc): Subtract object size from consing_since_gc.
193 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
195 Simplify and cleanup markers positioning code.
196 * marker.c (attach_marker): More useful eassert.
197 (live_buffer, set_marker_internal): New function.
198 (Fset_marker, set_marker_restricted): Use set_marker_internal.
199 (set_marker_both, set_marker_restricted_both): Use live_buffer.
201 2012-07-22 Paul Eggert <eggert@cs.ucla.edu>
203 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
204 as it's limited by the amount of memory, not by INT_MAX.
206 2012-07-21 Eli Zaretskii <eliz@gnu.org>
208 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
209 in special-event-map. See the discussion at
210 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
213 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
214 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
215 Fabrice Popineau <fabrice.popineau@supelec.fr>.
217 2012-07-21 Jan Djärv <jan.h.d@swipnet.se>
219 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
220 (conversationIdentifier): Return value is NSInteger.
221 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
223 2012-07-21 Chong Yidong <cyd@gnu.org>
225 * window.c (decode_any_window): Signal an error if the window is
226 on a dead frame (Bug#11984).
228 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
230 Add indirection counting to speed up Fkill_buffer.
231 * buffer.h (struct buffer): New member.
232 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
233 (Fmake_indirect_buffer): Set indirection counter to -1, increment
234 base buffer indirection counter.
235 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
236 (Fkill_buffer): Adjust indirection counters as needed, don't walk
237 through buffer list if indirection counter is 0.
239 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
241 Extend the value returned by Fgarbage_collect with heap statistics.
242 * alloc.c (Qheap): New symbol.
243 (syms_of_alloc): DEFSYM it.
244 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
245 (Fmemory_free): Remove.
246 (syms_of_alloc): Don't defsubr it.
247 * buffer.c (Fcompact_buffer): Remove.
248 (syms_of_buffer): Don't defsubr it.
250 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
252 Make maybe_gc inline.
253 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
254 * lisp.h (consing_since_gc, gc_relative_threshold)
255 (memory_full_cons_threshold): Revert declaration.
256 (maybe_gc): Remove prototype, define as inline.
257 * alloc.c: Remove old commented-out code.
258 (consing_since_gc, gc_relative_threshold)
259 (memory_full_cons_threshold): Revert to global.
262 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
264 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
265 * lisp.h (build_unibyte_string): New function.
266 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
267 * sysdep.c, w32fns.c, xfns.c: Use it.
268 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
269 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
270 Adjust users accordingly.
271 * font.h (font_open_by_name): Adjust prototype.
273 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
275 Cleanup calls to Fgarbage_collect.
276 * lisp.h (maybe_gc): New prototype.
277 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
279 * alloc.c (maybe_gc): New function.
280 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
282 * bytecode.c (MAYBE_GC): Use maybe_gc.
283 * eval.c (eval_sub, Ffuncall): Likewise.
284 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
285 to avoid dependency from auto-save feature.
287 2012-07-19 Paul Eggert <eggert@cs.ucla.edu>
289 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
290 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
291 'for_each_per_buffer_object_at'.
292 All uses changed. It's better to use upper-case for macros that
293 cannot be implemented as functions, to give the reader a clue
294 that they're special.
296 2012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
298 * alloc.c (Fgarbage_collect): Tweak docstring.
300 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
302 Tweak the value returned from Fgarbage_collect again.
303 * alloc.c (Fgarbage_collect): New return value, as confirmed in
304 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
305 Adjust documentation.
306 (total_vector_bytes): Rename to total_vector_slots, adjust
308 (total_free_vector_bytes): Rename to total_free_vector_slots,
310 (Qstring_bytes, Qvector_slots): New symbols.
311 (syms_of_alloc): DEFSYM them.
313 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
315 Buffer compaction primitive which may be used from Lisp.
316 * buffer.c (compact_buffer, Fcompact_buffer): New function.
317 (syms_of_buffer): Register Fcompact_buffer.
318 * alloc.c (Fgarbage_collect): Use compact_buffer.
319 * buffer.h (compact_buffer): New prototype.
320 (struct buffer_text): New member.
322 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
324 New macro to iterate over all buffers, miscellaneous cleanups.
325 * lisp.h (all_buffers): Remove declaration.
326 * buffer.h (all_buffers): Add declaration, with comment.
327 (for_each_buffer): New macro.
328 * alloc.c (Fgarbage_collect, mark_object): Use it.
329 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
330 (init_buffer): Likewise.
331 * data.c (Fset_default): Likewise.
332 * coding.c (code_conversion_restore): Remove redundant check
334 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
336 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
338 Fix bug that created negative-length intervals.
339 * intervals.c (merge_interval_right, merge_interval_left):
340 Do not zero out this interval if it is absorbed by its children,
341 as this interval's total length doesn't change in that case. See
342 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
344 2012-07-18 Paul Eggert <eggert@cs.ucla.edu>
346 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
347 when invoking (make-bool-vector N t) and N is a positive
348 multiple of 8 -- the last 8 bits were mistakenly cleared.
350 Remove some struct layout assumptions in bool vectors.
351 * alloc.c (bool_header_size): New constant.
352 (header_size, word_size): Move earlier, as they're now used earlier.
353 Use 'word_size' in a few more places, where it's appropriate.
354 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
355 padding before the data member of a bool vector.
356 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
357 than doing the check by hand with an abort ().
359 2012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
361 * eval.c (Fdefvar): Don't check constants since we only set the var if
362 it's not yet defined anyway (bug#11904).
364 * lisp.h (last_undo_boundary): Declare new var.
365 * keyboard.c (command_loop_1): Set it.
366 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
367 were auto-added by the command loop (bug#11774).
369 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
371 * w32font.c (Qsymbol): Remove local definition.
372 (syms_of_w32font): Don't DEFSYM it.
374 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
376 Fix sweep_vectors to handle large bool vectors correctly.
377 * alloc.c (sweep_vectors): Account total_vector_bytes for
378 bool vectors larger than VBLOCK_BYTES_MAX.
380 2012-07-18 Chong Yidong <cyd@gnu.org>
382 * frame.c (x_set_frame_parameters): Revert bogus change introduced
383 in 2012-05-25 commit by Paul Eggert (Bug#11738).
385 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
387 Return more descriptive data from Fgarbage_collect.
388 Suggested by Stefan Monnier in
389 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
390 * alloc.c (bounded_number): New function.
391 (total_buffers, total_vectors): New variable.
392 (total_string_size): Rename to total_string_bytes, adjust users.
393 (total_vector_size): Rename to total_vector_bytes, adjust users.
394 (sweep_vectors): Account total_vectors and total_vector_bytes.
395 (Fgarbage_collect): New return value. Adjust documentation.
396 (gc_sweep): Account total_buffers.
397 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
398 (VECTOR_SIZE): Remove.
399 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
400 (Qinterval, Qmisc): New symbols.
401 (syms_of_data): Initialize them.
402 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
403 (Qcons, Qbuffer): New declarations.
405 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
407 * alloc.c (Fmemory_free): Account for memory-free's own storage.
408 Round up, not down. Improve doc.
410 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
412 Restore old code in allocate_string_data to avoid Faset breakage.
413 Reported by Julien Danjou <julien@danjou.info> in
414 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
415 * alloc.c (allocate_string_data): Restore old code with minor
416 adjustments, fix comment to explain this subtle issue.
418 2012-07-17 Eli Zaretskii <eliz@gnu.org>
420 Remove FILE_SYSTEM_CASE.
421 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
423 * fileio.c (FILE_SYSTEM_CASE): Don't define.
424 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
425 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
426 call-process-region passes it through expand-file-name.
428 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
430 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
432 Fix crash when creating indirect buffer (Bug#11917)
433 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
434 Don't handle unbound variables specially if non-zero.
435 (Fbuffer_local_variables): Pass zero.
436 (clone_per_buffer_values): Pass non-zero.
438 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
440 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
441 to make the loop interruptible.
443 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
445 * gnutls.c (emacs_gnutls_handshake): Only retry if
446 GNUTLS_E_INTERRUPTED.
448 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
450 Cleanup and convert miscellaneous checks to eassert.
451 * alloc.c (mark_interval): Fix comment, partially rephrase
452 old comment from intervals.h (see below).
453 * intervals.c (find_interval, adjust_intervals_for_insertion)
454 (delete_interval, adjust_intervals_for_deletion)
455 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
457 (adjust_intervals_for_insertion, make_new_interval):
458 Remove obsolete and unused code.
459 * intervals.h (struct interval): Remove obsolete comment.
460 * textprotp.c (erase_properties): Remove unused code.
461 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
462 (Fremove_list_of_text_properties): Convert to eassert.
464 2012-07-17 Chong Yidong <cyd@gnu.org>
466 * editfns.c (Finsert_char): Doc fix.
468 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
470 Fix previous change to make Fmemory_free always accurate.
471 * alloc.c (make_interval): Update total_free_intervals.
472 (make_float): Likewise for total_free_floats.
473 (free_cons, Fcons): Likewise for total_free_conses.
474 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
475 Likewise for total_free_vector_bytes.
476 (Fmake_symbol): Likewise for total_free_symbols.
477 (bytes_free): Remove.
479 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
481 Simple free memory accounting feature.
482 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
483 (sweep_vectors): Accumulate size of free vectors.
484 (Fgarbage_collect): Setup bytes_free.
485 (Fmemory_free): New function.
486 (syms_of_alloc): Register it.
488 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
490 Cleanup overlays checking.
491 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
492 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
493 eassert and OVERLAYP.
494 (sort_overlays): Change to use OVERLAYP.
496 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
498 * editfns.c (Finsert_char): Make it interactive, and make the
499 second arg optional. Copy interactive spec and docstring from
502 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
504 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
505 Unlike the other wrapped functions, fabs has an unspecified
508 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
510 * nsterm.m (keyDown): Interpret flags without left/right bits
511 as the left key (Bug#11670).
513 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
515 Remove empty and useless init functions.
516 * lisp.h (init_character_once, init_fns, init_image)
517 (init_filelock, init_sound): Remove prototype.
518 * character.c (init_character_once): Remove.
519 * filelock.c (init_filelock): Likewise.
520 * fns.c (init_fns): Likewise.
521 * image.c (init_image): Likewise.
522 * sound.c (init_sound): Likewise.
523 * emacs.c (main): Adjust accordingly.
525 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
527 * gtkutil.h: Tiny cleanups.
528 (use_old_gtk_file_dialog): Remove useless declaration.
529 (xg_uses_old_file_dialog): Add suggested const attribute.
531 2012-07-15 Eli Zaretskii <eliz@gnu.org>
533 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
534 (bidi_paragraph_init): Use it to limit search forward for a strong
535 directional character in abnormally large paragraphs full of
536 neutral or weak characters. (Bug#11943)
538 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
540 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
541 the toolbar (Bug#9451).
542 (xg_make_tool_item): Give the widget event box a transparent
545 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
547 Cleanup basic allocation variables and functions.
548 * alloc.c (ignore_warnings, init_intervals, init_float)
549 (init_cons, init_symbol, init_marker): Remove.
550 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
551 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
552 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
553 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
554 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
555 (staticidx, init_alloc_once, init_strings, free_ablock):
556 Remove redundant initialization.
557 * fns.c (init_weak_hash_tables): Remove.
558 * lisp.h (init_weak_hash_tables): Remove prototype.
560 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
562 Use zero_vector where appropriate.
563 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
565 * lisp.h (zero_vector): New declaration.
566 * font.c (null_vector): Remove.
567 (syms_of_font): Remove initialization and staticpro.
568 (font_list_entities, font_find_for_lface): Change to use zero_vector.
569 * keymap.c (Faccessible_keymaps): Likewise.
571 2012-07-15 Leo Liu <sdl.web@gmail.com>
573 * fringe.c: Fix typo in comments.
575 2012-07-14 Leo Liu <sdl.web@gmail.com>
577 * fringe.c: Add a new bitmap exclamation-mark.
579 2012-07-14 Eli Zaretskii <eliz@gnu.org>
581 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
583 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
584 (HAVE_MENUS): Don't define, defined by editing config.in with
586 (GMALLOC_INHIBIT_VALLOC): Don't define.
587 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
589 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
591 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
593 2012-07-14 Glenn Morris <rgm@gnu.org>
595 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
596 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
597 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
599 2012-07-13 Glenn Morris <rgm@gnu.org>
601 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
603 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
604 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
606 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
608 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
609 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
610 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
611 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
613 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
614 as boolean expression.
615 (x_set_window_size): Remove unused variable toolbar.
616 (ns_get_color_default, ns_mod_to_lisp): Remove.
617 (ns_mouse_position): Remove unused variables xchar and ychar.
618 (ns_compute_glyph_string_overhangs): Remove unused variable face.
619 (ns_set_vertical_scroll_bar): Remove unused variable count.
620 (ns_delete_terminal): Remove unused variable i.
621 (ns_term_init): Remove unused variables r, g and b.
622 (mouseDown): Remove unused variable window.
623 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
624 (initFrameFromEmacs): Remove unused variable vbextra.
625 (mouseEntered): Remove unused variables p and dpyinfo.
626 (mouseExited): Remove unused variables p and r.
627 (ns_define_frame_cursor, ns_clear_frame_area)
628 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
629 (menuDown): Assign [sender tag] to variable and cast the variable.
631 * nsterm.h (menuDown): Add id as type to argument sender.
632 (ns_display_info_for_name): Add Lisp_Object argument.
633 (ns_term_init): Add Lisp_Object argument.
634 (ns_map_event_to_object): Add void argument.
635 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
636 prototype with arguments and only declare if __OBJC__.
637 (nxatoms_of_nsselect): Add void argument.
638 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
639 (ns_alloc_autorelease_pool): Add void argument.
640 (ns_release_autorelease_pool): Add void* argument.
641 (ns_get_defaults_value): Add const char* argument.
643 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
644 (initFromContents): Use SSDATA where appropriate.
645 (ns_update_menubar): Add braces to ambigous if-else.
646 (initWithTitle): Put () around assignment in if statement.
647 (ns_menu_show): Remove unused variables window and keymap.
648 (update_frame_tool_bar): Remove unused variable selected_p.
649 (initWithContentRect): Remove unused variable this_cmd_name.
651 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
653 (setXBMColor): Remove unused variable len.
654 (setPixmapData): Put () around assignment in loop statement.
656 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
657 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
659 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
660 around assignment in loop statement.
661 (nsfont_open): Remove unused variable i.
662 (nsfont_open): Remove unused variable len.
663 (nsfont_draw): Remove unused variable cs.
665 * nsfns.m (x_set_icon_name, ns_set_name_internal)
666 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
667 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
668 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
669 (Fns_font_name, Fns_perform_service)
670 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
671 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
672 (ns_set_name): Remove unused variable view.
673 (x_set_menu_bar_lines): Remove unused variable olines.
674 (x_set_tool_bar_lines): Remove unused variable root_window.
675 (Fns_list_colors): Put () around assignment in while statement.
676 (Fns_perform_service): Remove unused variable len.
677 (Fns_display_usable_bounds): Remove unused variable top.
678 (syms_of_nsfns): Remove unused variable i.
680 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
683 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
685 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
686 and free it with DestroyExceptionInfo (Bug#11558).
688 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
690 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
691 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
692 Set here, not in nt/config.nt.
694 2012-07-13 Eli Zaretskii <eliz@gnu.org>
696 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
697 cursor overflow into the last glyph on display line when the right
698 fringe is off. (Bug#11832)
700 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
702 * xdisp.c (produce_special_glyphs): Now static.
703 * dispextern.h (produce_special_glyphs): Remove decl.
705 2012-07-13 Glenn Morris <rgm@gnu.org>
707 * s/bsd-common, s/cygwin.h: Remove empty files.
708 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
710 * s/usg5-4-common.h (USG, USG5):
711 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
712 * s/sol2-6.h (SOLARIS2):
713 * s/irix6-5.h (IRIX6_5):
714 * s/hpux10-20.h (USG, USG5, HPUX):
715 * s/gnu-linux.h (USG, GNU_LINUX):
716 * s/freebsd.h (BSD_SYSTEM):
717 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
718 * s/cygwin.h (CYGWIN):
719 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
720 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
722 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
724 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
726 2012-07-13 Glenn Morris <rgm@gnu.org>
728 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
730 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
732 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
733 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
735 2012-07-12 Glenn Morris <rgm@gnu.org>
737 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
739 * process.c (init_process_emacs): Rename from init_process.
740 The old name is also the name of a Mach system call.
741 * lisp.h, emacs.c: Update for this name change.
742 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
745 2012-07-12 Eli Zaretskii <eliz@gnu.org>
747 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
748 memmove call that removes glyphs covered by the left truncation
749 glyph. Improve commentary.
750 (display_line): Fix display of continuation glyphs on GUI frames
751 when the right fringe is turned off and variable-size fonts are
752 used in the window. Move the code that appends a stretch glyph to
753 produce_special_glyphs, so that it could be used for truncation
754 and continuation glyphs alike.
755 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
756 glyph of a suitably computed width, to align the special glyphs at
757 the window margin. Code moved from display_line. (Bug#11832)
759 2012-07-12 Glenn Morris <rgm@gnu.org>
761 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
763 * s/gnu-linux.h, s/hpux10-20.h:
764 Do not unconditionally define HAVE_XRMSETDATABASE.
766 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
768 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
770 Fix typos that broke OS X build.
771 Reported by Randal L. Schwartz in
772 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
773 * nsterm.m (ns_timeout): Add missing local decl.
774 (ns_get_color): snprintf -> sprintf, to fix typo.
776 2012-07-12 Glenn Morris <rgm@gnu.org>
778 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
779 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
780 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
781 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
783 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
784 Move PTY_OPEN to configure.
786 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
787 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
788 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
790 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
792 Use empty_unibyte_string where applicable.
793 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
794 * lread.c (read1): Likewise.
795 * xsettings.c (syms_of_xsettings): Likewise.
797 2012-07-12 Glenn Morris <rgm@gnu.org>
799 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
800 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
801 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
802 * s/hpux10-20.h (RUN_TIME_REMAP):
803 * s/bsd-common.h (TABDLY): Move to configure.
805 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
807 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
809 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
810 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
812 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
814 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
815 * s/template.h: Move NARROWPROTO to configure.
817 2012-07-11 Glenn Morris <rgm@gnu.org>
819 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
820 unused since 2011-01-17 change to systty.h.
822 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
823 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
824 Move HAVE_PTYS and HAVE_SOCKETS to configure.
826 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
828 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
830 2012-07-11 Glenn Morris <rgm@gnu.org>
832 * s/darwin.h, s/gnu-linux.h, s/template.h:
833 Move INTERRUPT_INPUT to configure.
835 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
837 Minor adjustments to interning code.
838 * lisp.h (intern, intern_c_string): Redefine as static inline
839 wrappers for intern_1 and intern_c_string_1, respectively.
840 (intern_1, intern_c_string_1): Rename prototypes.
841 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
843 * font.c (font_intern_prop): Likewise. Adjust comment.
844 * w32font.c (intern_font_name): Likewise.
846 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
848 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
850 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
851 of Fcar/Fcdr if possible.
852 * font.c (check_otf_features): Likewise.
853 * fontset.c (Fnew_fontset): Likewise.
854 * gnutls.c (Fgnutls_boot): Likewise.
855 * minibuf.c (read_minibuf): Likewise.
856 * msdos.c (IT_set_frame_parameters): Likewise.
857 * xmenu.c (Fx_popup_dialog): Likewise.
858 * w32menu.c (Fx_popup_dialog): Likewise.
860 2012-07-11 Glenn Morris <rgm@gnu.org>
862 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
863 since nothing has defined it on these platforms.
865 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
866 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
868 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
869 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
870 Move CLASH_DETECTION to configure.
872 * s/gnu.h: Remove file, which is now empty.
874 * s/gnu.h, s/gnu-linux.h:
875 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
877 2012-07-11 John Wiegley <johnw@newartisans.com>
879 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
880 function attribute, so we only use it if it exists in the
883 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
885 Avoid call to strlen in fast_c_string_match_ignore_case.
886 * search.c (fast_c_string_match_ignore_case): Change to use
887 length argument. Adjust users accordingly.
888 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
890 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
893 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
894 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
897 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
900 * s/hpux10-20.h (HAVE_PERROR): Remove.
901 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
902 Remove dummy definition, as this problem was obsolete long ago.
905 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
907 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
909 Avoid calls to strlen in font processing functions.
910 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
911 (font_open_by_name): Change to use length argument. Adjust
913 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
915 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
916 Change to return ptrdiff_t.
917 (xfont_list_pattern, xfont_match): Use length returned by
918 xfont_decode_coding_xlfd.
919 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
921 2012-07-11 Glenn Morris <rgm@gnu.org>
923 * s/darwin.h, s/freebsd.h, s/netbsd.h:
924 Move DONT_REOPEN_PTY to configure.
926 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
927 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
929 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
931 Remove "#define unix" that is no longer needed (Bug#11905).
932 * s/aix4-2.h (unix): Remove; no longer needed.
934 EMACS_TIME simplification (Bug#11875).
935 This replaces macros (which typically do not work in GDB)
936 with functions, typedefs and enums, making the code easier to debug.
937 The functional style also makes code easier to read and maintain.
938 * systime.h: Include <sys/time.h> on all hosts, not just if
939 WINDOWSNT, since 'struct timeval' is needed in general.
940 (EMACS_TIME): Now a typedef, not a macro.
941 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
943 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
944 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
945 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
946 (EMACS_TIME_LE): Now functions, not macros.
947 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
948 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
949 which are not functions. All uses rewritten to use:
950 (make_emacs_time): New function.
951 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
952 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
953 not functions. All uses rewritten to use the following, respectively:
954 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
955 (add_emacs_time, sub_emacs_time): New functions.
956 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
957 * fileio.c (Fcopy_file):
958 * xterm.c (XTflash): Get the current time closer to when it's used.
959 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
961 * bytecode.c (targets): Suppress -Woverride-init warnings.
963 Simplify by avoiding confusing use of strncpy etc.
964 * doc.c (Fsnarf_documentation):
965 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
966 * frame.c (Fmake_terminal_frame):
967 * gtkutil.c (get_utf8_string):
969 * nsmenu.m (ns_update_menubar):
970 * regex.c (regerror):
971 Prefer memcpy to strncpy and strncat when either will do.
972 * fileio.c (Fsubstitute_in_file_name):
973 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
974 (menu_separator_name_p):
975 * nsmenu.m (ns_update_menubar):
976 Prefer memcmp to strncmp when either will do.
977 * nsterm.m: Include <ftoastr.h>.
979 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
980 Prefer snprintf to strncpy.
981 * nsterm.m (ns_term_init):
982 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
983 * nsterm.m (ns_term_init):
984 Avoid the need for strncpy, by using build_string or
985 make_unibyte_string directly. Use dtoastr, not snprintf.
986 * process.c (Fmake_network_process): Diagnose service names that
987 are too long, rather than silently truncating them or creating
988 non-null-terminated names.
989 (Fnetwork_interface_info): Likewise, for interface names.
990 * sysdep.c (system_process_attributes) [GNU_LINUX]:
991 Prefer sprintf to strncat.
992 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
993 Prefer vsnprintf to vsprintf + strncpy.
995 2012-07-10 Glenn Morris <rgm@gnu.org>
997 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
998 Clarify fallback case.
1000 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1002 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1003 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1004 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
1005 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
1006 where argument type is known to be a Lisp_Cons.
1008 2012-07-10 Tom Tromey <tromey@redhat.com>
1010 * bytecode.c (BYTE_CODE_THREADED): New macro.
1011 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1012 (enum byte_code_op): New type.
1013 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1014 (exec_byte_code): Use them. Use token threading when applicable.
1016 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1018 Optimize pure C strings initialization.
1019 * lisp.h (make_pure_string): Fix prototype.
1020 (build_pure_c_string): New function, defined as static inline. This
1021 provides a better opportunity to optimize away calls to strlen when
1022 the function is called with compile-time constant argument.
1023 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1024 argument, adjust users accordingly. Use build_pure_c_string where
1026 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1027 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1028 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1030 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1032 Avoid calls to strlen in miscellaneous functions.
1033 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1034 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1035 * lread.c (openp): Likewise.
1037 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1039 Avoid calls to strlen in path processing functions.
1040 * fileio.c (file_name_as_directory): Add comment. Change to add
1041 srclen argument and return the length of result. Adjust users
1043 (directory_file_name): Fix comment. Change to add srclen argument,
1044 swap 1st and 2nd arguments to obey the common convention. Adjust
1046 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1048 2012-07-10 Glenn Morris <rgm@gnu.org>
1050 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1051 Move PENDING_OUTPUT_COUNT definition to configure.
1053 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1054 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1055 * s/gnu.h (DATA_START): Move definitions to configure.
1057 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1058 We include usg5-4-common.h, which defines them both.
1060 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1061 O_RDONLY already includes it).
1063 Stop ns builds setting the EMACSLOADPATH environment variable.
1064 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1065 Now it does not set EMACSLOADPATH, just returns the load-path string.
1066 * nsterm.h: Update accordingly.
1067 * lread.c [HAVE_NS]: Include nsterm.h.
1068 (init_lread) [HAVE_NS]: Use ns_load_path.
1069 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1071 2012-07-09 Glenn Morris <rgm@gnu.org>
1073 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1074 since the included bsd-common.h does so.
1076 Stop ns builds setting the EMACSPATH environment variable.
1077 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1078 (ns_init_paths): Do not set EMACSPATH.
1079 * nsterm.h (ns_exec_path): Add it.
1080 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1083 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1085 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1087 * process.c (wait_reading_process_output): 'waitchannels' was unset
1088 when read_kbd || !NILP (wait_for_cell); fix this.
1090 Add GCC-style 'const' attribute to functions that can use it.
1091 * character.h (char_resolve_modifier_mask):
1092 * keyboard.h (make_ctrl_char):
1093 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1094 (init_character_once, next_almost_prime, init_fns, init_image)
1095 (flush_pending_output, init_sound):
1096 * mem-limits.h (start_of_data):
1097 * menu.h (finish_menu_items):
1098 Add ATTRIBUTE_CONST.
1099 * emacs.c (DEFINE_DUMMY_FUNCTION):
1100 Declare the dummy function with ATTRIBUTE_CONST.
1101 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1102 Add decls with ATTRIBUTE_CONST.
1104 Minor improvements to make_formatted_string.
1105 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1106 where int is good enough, as vsprintf returns an int.
1107 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1109 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1111 Use make_formatted_string to avoid double length calculation.
1112 * lisp.h (make_formatted_string): New prototype.
1113 * alloc.c (make_formatted_string): New function.
1114 * buffer.c (Fgenerate_new_buffer_name): Use it.
1115 * dbus.c (syms_of_dbusbind): Likewise.
1116 * editfns.c (Fcurrent_time_zone): Likewise.
1117 * filelock.c (get_boot_time): Likewise.
1118 * frame.c (make_terminal_frame, set_term_frame_name)
1119 (x_report_frame_params): Likewise.
1120 * image.c (gs_load): Likewise.
1121 * minibuf.c (get_minibuffer): Likewise.
1122 * msdos.c (dos_set_window_size): Likewise.
1123 * process.c (make_process): Likewise.
1124 * xdisp.c (ensure_echo_area_buffers): Likewise.
1125 * xsettings.c (apply_xft_settings): Likewise.
1127 2012-07-09 Glenn Morris <rgm@gnu.org>
1129 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1130 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1131 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1132 * nsterm.h (ns_etc_directory): Add it.
1133 * callproc.c [HAVE_NS]: Include nsterm.h.
1134 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1136 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1138 Move marker debugging code under MARKER_DEBUG.
1139 * marker.c (MARKER_DEBUG): Move marker debugging code under
1140 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1141 for bootstrap with --enable-checking (~3x slowdown reported
1142 by Juanma Barranquero <lekktu@gmail.com>).
1143 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1145 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1147 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1148 See <http://bugs.gnu.org/11825#29>.
1150 2012-07-08 Eli Zaretskii <eliz@gnu.org>
1152 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1153 has no font, use the frame's font. (Bug#11813)
1154 (display_line): Add commentary about displaying truncation glyphs
1156 (produce_special_glyphs): Move here from term.c.
1158 * term.c (produce_special_glyphs): Move to xdisp.c.
1160 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1163 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1165 * xdisp.c (display_line): Avoid warning about implicit declaration
1168 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1170 * lisp.h: Remove empty conditional.
1172 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1174 * lread.c (load_path_check): Now static.
1176 Fix some minor --with-ns problems found by static checking.
1177 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1178 (x_set_font) [!HAVE_X_WINDOWS]:
1179 * image.c (xpm_load_image) [HAVE_NS]:
1180 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1181 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1182 Remove unused local.
1183 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1184 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1185 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1186 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1187 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1188 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1189 Fix pointer signedness problem.
1190 * xfaces.c (FRAME_X_FONT_TABLE):
1191 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1193 2012-07-07 Glenn Morris <rgm@gnu.org>
1195 * lread.c (load_path_check): New function, split from init_lread.
1196 (init_lread): Reorganize. Motivation:
1197 If EMACSLOADPATH is set, check/warn about that rather than the
1198 defaults, which we are not going to use. Hence we can remove
1199 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1200 Don't warn if site-lisp directories are missing.
1201 If not installed, start from a blank load-path, since
1202 PATH_LOADSEARCH refers to the eventual installation directories.
1204 2012-07-07 Eli Zaretskii <eliz@gnu.org>
1206 Support truncation and continuation glyphs on GUI frames, when
1207 fringes are disabled. (Bug#11832)
1208 * xdisp.c (init_iterator): Get dimensions of truncation and
1209 continuation glyphs even if on GUI frames. Adjust
1210 it->last_visible_x on GUI frames when the left or right fringes,
1211 or both, are absent.
1212 (start_display, move_it_in_display_line_to): Handle the case of a
1213 GUI frame without a fringe to display continuation or truncation
1215 (insert_left_trunc_glyphs): Support GUI frames: make sure
1216 truncation glyphs overwrite enough glyphs from the current line to
1217 have sufficient space in pixels.
1218 (display_line): Support truncation and continuation glyphs on GUI
1219 frames. If some spare pixels are left on the line after inserting
1220 the truncation glyphs, fill that space with a stretch glyph of a
1221 suitably computed width.
1223 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1224 produce_glyphs, to support GUI sessions.
1226 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1228 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1230 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1232 Do not require float-time's arg to fit in time_t (Bug#11825).
1233 This works better on hosts where time_t is unsigned, and where
1234 float-time is applied to the (negative) difference between two times.
1235 * editfns.c (decode_time_components): Last arg is now double *,
1236 not int *, and means to store all the result as a double, without
1237 worrying about whether the seconds part fits in time_t.
1238 All callers changed.
1239 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1240 All callers changed.
1241 (Ffloat_time): Do not fail merely because the specified time falls
1242 outside of time_t range.
1244 2012-07-07 Glenn Morris <rgm@gnu.org>
1246 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1247 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1248 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1250 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
1252 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1253 Update dependencies.
1255 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1257 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1259 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1260 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1261 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1262 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1263 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1264 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1266 * xfont.c (compare_font_names): Redo to omit the need for casts.
1268 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1270 * xfns.c (Fx_change_window_property): Doc fix.
1271 * w32fns.c (Fx_change_window_property): Doc fix.
1273 * w32fns.c (Fx_window_property): Accept the same arguments as the
1274 X Windows version. Doc fix.
1275 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1277 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
1278 Eli Zaretskii <eliz@gnu.org>
1280 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1281 Windows-specific code from nt/config.nt moved here.
1282 Obsolete settings removed.
1284 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1286 * process.c: Avoid unnecessary calls to gettime.
1287 (wait_reading_process_output): Don't get the time of day
1288 when gobbling data immediately and not waiting, as there's no need
1289 for it in that case. This removes a FIXME.
1291 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1293 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1294 is defined (Bug#11768).
1296 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1298 Fix marker debugging code.
1299 * marker.c (byte_char_debug_check): Do not perform the check
1300 if buffer is not multibyte.
1301 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1302 Call byte_char_debug_check with correct arguments.
1304 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1306 Compile marker debugging code only if ENABLE_CHECKING is defined.
1307 * marker.c (byte_char_debug_check, count_markers):
1308 Use only if ENABLE_CHECKING is defined.
1309 (byte_debug_flag): Remove.
1310 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1311 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1313 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1315 Avoid code repetition in marker-related functions.
1316 * marker.c (attach_marker): New function.
1317 (Fset_marker, set_marker_restricted, set_marker_both)
1318 (set_marker_restricted_both): Use it.
1319 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1320 Consistently rename charno to charpos.
1321 (marker_position): Add eassert.
1322 (marker_byte_position): Convert to eassert.
1324 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1326 Simplify list operations in unchain_overlay and unchain_marker.
1327 * buffer.c (unchain_overlay): Simplify. Add comment.
1328 * marker.c (unchain_marker): Simplify. Fix comments.
1330 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1332 Introduce fast path for the widely used marker operation.
1333 * alloc.c (build_marker): New function.
1334 * lisp.h (build_marker): New prototype.
1335 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1336 * composite.c (autocmp_chars): Likewise.
1337 * editfns.c (buildmark): Remove.
1338 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1339 (save_restriction_save): Use build_marker.
1340 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1341 * window.c (save_window_save): Likewise.
1343 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1345 Do not use Fdelete_overlay in delete_all_overlays
1346 to avoid redundant calls to unchain_overlay.
1347 * buffer.c (drop_overlay): New function.
1348 (delete_all_overlays, Fdelete_overlay): Use it.
1349 * minibuf.c (get_minibuffer): Fix comment.
1351 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1353 Port to OpenBSD 5.1 amd64.
1354 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1355 This is needed for OpenBSD, and should be harmless on all BSD systems.
1356 Also, include <sys/sysctl.h>, as it should be available on all
1357 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1358 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1359 use p_pid member, not kp_proc.pid.
1361 2012-07-06 Glenn Morris <rgm@gnu.org>
1363 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1365 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1367 More xmalloc and related cleanup.
1368 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1369 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1370 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1371 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1372 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1373 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1374 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1375 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1376 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1378 Omit needless casts involving void * pointers and allocation.
1379 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1380 as the former is more robust if P's type is changed.
1381 Prefer xzalloc to xmalloc + memset 0.
1382 Simplify malloc-or-realloc to realloc.
1383 Don't worry about xmalloc returning a null pointer.
1384 Prefer xstrdup to xmalloc + strcpy.
1385 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1387 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1388 alloca of a constant.
1390 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1392 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1393 hscroll is larger than the line width. Fixes long and futile
1394 looping inside extend_face_to_end_of_line (on a TTY) producing
1395 glyphs that are not needed and thrown away.
1397 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1399 * marker.c (set_marker_restricted_both): Simplify by using
1402 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1404 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1406 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1408 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1409 not defined (Bug#11768).
1410 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1411 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1412 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1413 followed by gtk_box_set_homogeneous (Bug#11768).
1414 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
1415 (update_theme_scrollbar_width, xg_create_scroll_bar):
1416 Use gtk_scrollbar_new (Bug#11768).
1417 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1418 (is_box_type): New function (Bug#11768).
1419 (xg_tool_item_stale_p): Call is_box_type.
1420 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
1421 with default display (Bug#11768).
1423 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1425 * xdisp.c (window_hscroll_limited): New function.
1426 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1427 coordinates when window's hscroll is set to insanely large
1430 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
1432 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1433 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1435 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1438 * lisp.h (xzalloc): New prototype. Omit needless casts.
1439 * alloc.c (xzalloc): New function. Omit needless casts.
1440 * charset.c: Omit needless casts. Convert all calls to
1441 xmalloc with following memset to xzalloc.
1442 * dispnew.c: Likewise.
1443 * fringe.c: Likewise.
1444 * image.c: Likewise.
1445 * sound.c: Likewise.
1447 * w32fns.c: Likewise.
1448 * w32font.c: Likewise.
1449 * w32term.c: Likewise.
1450 * xfaces.c: Likewise.
1452 * xterm.c: Likewise.
1453 * atimer.c: Omit needless casts.
1454 * buffer.c: Likewise.
1455 * callproc.c: Likewise.
1457 * coding.c: Likewise.
1458 * composite.c: Likewise.
1460 * doprnt.c: Likewise.
1461 * editfns.c: Likewise.
1462 * emacs.c: Likewise.
1464 * filelock.c: Likewise.
1466 * gtkutil.c: Likewise.
1467 * keyboard.c: Likewise.
1469 * lread.c: Likewise.
1470 * minibuf.c: Likewise.
1471 * msdos.c: Likewise.
1472 * print.c: Likewise.
1473 * process.c: Likewise.
1474 * region-cache.c: Likewise.
1475 * search.c: Likewise.
1476 * sysdep.c: Likewise.
1477 * termcap.c: Likewise.
1478 * terminal.c: Likewise.
1479 * tparam.c: Likewise.
1480 * w16select.c: Likewise.
1482 * w32reg.c: Likewise.
1483 * w32select.c: Likewise.
1484 * w32uniscribe.c: Likewise.
1485 * widget.c: Likewise.
1486 * xdisp.c: Likewise.
1487 * xmenu.c: Likewise.
1489 * xselect.c: Likewise.
1491 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1493 * fileio.c (time_error_value): Check the right error number.
1494 Problem reported by Troels Nielsen in
1495 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1497 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1499 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1500 This should be fixed in a better way; see Eli Zaretskii in
1501 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1502 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1504 * fileio.c (time_error_value): Rename from special_mtime.
1505 The old name's problems were noted by Eli Zaretskii in
1506 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1508 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1509 This variable's comment says Emacs needs at least one GDB-visible
1510 symbol of type enum pvec_type, to work around GDB problems.
1511 The symbol's value doesn't matter.
1513 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1514 that causes compilation to fail on pre-C99 compilers.
1516 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
1518 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1519 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1521 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1523 * buffer.c (init_buffer_once): Fix initialization of
1524 headers for buffer_defaults and buffer_local_symbols.
1525 Reported by Juanma Barranquero <lekktu@gmail.com>.
1527 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1529 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1530 * lisp.h (enum pvec_type): Use fewer bits.
1531 (PSEUDOVECTOR_SIZE_BITS): New constant.
1532 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1533 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1534 change in pvec_type.
1535 (PSEUDOVECTOR_TYPEP): New macro.
1536 (TYPED_PSEUDOVECTORP): Use it.
1537 * fns.c (internal_equal): Adapt code to extract pvectype.
1538 * emacs.c (gdb_pvec_type): Update type.
1539 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1540 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1541 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1542 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1543 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1544 abusing vector->header.next.nbytes.
1545 (live_vector_p): Use PVEC_TYPE.
1546 (mark_object): Adapt code to extract pvectype. Use switch.
1548 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1550 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1551 Tighten new eassert a bit.
1553 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1555 Fix compilation with --enable-gcc-warnings and -O1
1557 * doprnt.c (doprnt): Change type of tem to int, initialize
1558 to avoid compiler warning. Add eassert.
1559 * search.c (simple_search): Initialize match_byte to avoid
1560 compiler warning. Add eassert.
1562 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1564 Avoid weird behavior with large horizontal scrolls.
1565 Without this change, for example, large hscroll values would
1566 mess up Emacs's display on Fedora 15 x86, presumably due to
1567 overflows in int calculations in the display code.
1568 Also, if buffers had long lines, Emacs would freeze.
1569 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1570 (set_window_hscroll): New function, containing the old guts of
1571 Fset_window_hscroll. Return the clipped value.
1572 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1573 This avoids the need to check against PTRDIFF_MAX.
1575 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1577 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1579 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1581 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1583 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1584 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1585 since GCC 4.4.6 issues a bogus warning for them.
1587 Fix bugs in file timestamp newness comparisons.
1588 * fileio.c (Ffile_newer_than_file_p):
1589 * lread.c (Fload): Use full timestamp resolution of files,
1590 not just the 1-second resolution, so that files that are only
1591 slightly newer still count as newer.
1592 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1593 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1595 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1597 * fileio.c: Improve handling of file time marker. (Bug#11852)
1598 (special_mtime): New function.
1599 (Finsert_file_contents, Fverify_visited_file_modtime):
1600 Use it to set special mtime values consistently.
1602 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1604 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1605 marker for non-existing file. (Bug#11852)
1607 2012-07-03 Glenn Morris <rgm@gnu.org>
1609 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1610 and did not make it into globals.h).
1612 2012-07-03 Tom Tromey <tromey@redhat.com>
1614 * window.c (Fset_window_margins, Fset_window_fringes)
1615 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1616 * textprop.c (Fprevious_property_change): No longer static.
1617 * syntax.c (Fsyntax_table_p): No longer static.
1618 * process.c (Fget_process, Fprocess_datagram_address): No longer
1620 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1621 * keyboard.c (Fcommand_execute): No longer static.
1623 * insdel.c (Fcombine_after_change_execute): No longer static.
1624 * image.c (Finit_image_library): No longer static.
1625 * fileio.c (Fmake_symbolic_link): No longer static.
1626 * eval.c (Ffetch_bytecode): No longer static.
1627 * editfns.c (Fuser_full_name): No longer static.
1628 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1630 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1632 * dired.c (Ffile_attributes): No longer static.
1633 * composite.c (Fcomposition_get_gstring): No longer static.
1634 * callproc.c (Fgetenv_internal): No longer static.
1636 * ccl.h: Remove EXFUNs.
1637 * buffer.h: Remove EXFUNs.
1638 * dispextern.h: Remove EXFUNs.
1639 * intervals.h: Remove EXFUNs.
1640 * fontset.h: Remove EXFUN.
1641 * font.h: Remove EXFUNs.
1642 * dosfns.c (system_process_attributes): Remove EXFUN.
1643 * keymap.h: Remove EXFUNs.
1644 * lisp.h: Remove EXFUNs.
1645 * w32term.h: Remove EXFUNs.
1646 * window.h: Remove EXFUNs.
1647 * xsettings.h: Remove EXFUN.
1648 * xterm.h: Remove EXFUN.
1650 2012-07-03 Glenn Morris <rgm@gnu.org>
1652 * lisp.h (Frandom): Make it visible to C.
1653 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1654 buffer for invisible buffers. (Bug#1229)
1656 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1658 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1659 values which aren't power of 2.
1660 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1661 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1664 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1666 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1668 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1670 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1672 * alloc.c (allocate_vector_block): Remove redundant
1673 calls to mallopt if DOUG_LEA_MALLOC is defined.
1674 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1675 avoid calls to mallopt if zero_vector is returned.
1677 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1679 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1680 is enabled, avoid dereferencing NULL current_sblock if
1683 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1685 Cleanup basic buffer management.
1686 * buffer.h (struct buffer): Change layout to use generic vector
1687 marking code. Fix some comments. Change type of 'clip_changed'
1688 to bitfield. Remove unused #ifndef old.
1689 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1690 (GET_OVERLAYS_AT): Fix indentation.
1691 (for_each_per_buffer_object_at): New macro.
1692 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1693 (Fbuffer_local_variables): Use it.
1694 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1695 * alloc.c (allocate_buffer): Adjust to match new layout of
1696 struct buffer. Fix comment.
1697 (mark_overlay): New function.
1698 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1699 Lisp area of struct buffer.
1700 (mark_object): Use it. Adjust marking of misc objects
1701 and related comments.
1703 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1705 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1706 wrapper that is not needed because the wrapped code is a no-op (zero
1707 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1708 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1710 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1712 * alloc.c (mark_buffer): Simplify. Remove prototype.
1713 (mark_object): Add comment. Reorganize marking of vector-like
1714 objects. Use CHECK_LIVE for all vector-like objects except buffers
1715 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1716 redundant calls to mark_vectorlike for bool vectors.
1718 2012-06-30 Glenn Morris <rgm@gnu.org>
1720 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1722 * epaths.in (PATH_SITELOADSEARCH): New.
1723 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1724 This is rather than relying on --enable-locallisppath elements
1725 having "site-lisp" in their names. (Bug#10208#25, 11658)
1727 2012-06-30 Eli Zaretskii <eliz@gnu.org>
1729 * w32proc.c (sys_select): Accept and ignore one more argument.
1731 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1733 * sysselect.h [DOS_NT]: Don't include sys/select.h.
1734 (pselect) [!MS_DOS]: Redirect to sys_select.
1736 * sysdep.c: Don't include dos.h and dosfns.h.
1738 * process.c (sys_select):
1739 * msdos.c (sys_select): Accept one more argument and ignore it.
1741 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1742 adapt data types and code to that.
1745 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1746 which clashes with the gnulib function of the same name.
1748 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1750 * font.c (font_style_to_value, font_style_symbolic)
1751 (font_prop_validate_style): Add type checks for values in
1754 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1756 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1759 2012-06-29 Eli Zaretskii <eliz@gnu.org>
1761 * xdisp.c (try_window_id): Undo last change.
1763 * w32.c (getwd): Adjust commentary about startup_dir.
1764 (init_environment): Always call sys_access, even in non-MSVC
1765 builds. Don't chdir to the directory of the Emacs executable.
1766 This undoes code from 1997 which was justified by the need to
1767 "avoid conflicts when removing and renaming directories". But its
1768 downside was that every relative file name was being interpreted
1769 relative to the directory of the Emacs executable, which can never
1770 be TRT. In particular, it broke sys_access when called with
1771 relative file names.
1772 (sys_access): Map GetLastError to errno.
1774 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1776 * window.h (struct window): Change type of 'fringes_outside_margins'
1777 to bitfield. Fix comment. Adjust users accordingly.
1778 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
1780 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1783 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
1785 * gnutls.c (emacs_gnutls_handshake):
1786 Add QUIT to make the loop interruptible.
1788 2012-06-29 Glenn Morris <rgm@gnu.org>
1790 * charset.c (init_charset): Make lack of etc/charsets fatal.
1792 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1794 * editfns.c (region_limit): Fix type mismatch.
1796 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1798 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1799 undefined. Convert from xassert to eassert.
1800 * nsmenu.m: Convert from xassert to eassert.
1801 * nsterm.m: Likewise.
1803 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1805 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1807 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1809 Avoid integer overflow on scroll-left and scroll-right.
1810 * window.c (HSCROLL_MAX): New macro.
1811 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1812 overflow when requested scroll falls outside ptrdiff_t range.
1814 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1816 * window.h (struct window): Change type of 'hscroll',
1817 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1818 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1819 Adjust users accordingly.
1820 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1821 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1822 from EMACS_INT to ptrdiff_t.
1823 (make_window): Omit redundant initialization.
1825 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
1827 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1829 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1831 * window.h (struct window): Change type of 'use_time' and
1832 'sequence_number' from Lisp_Object to int.
1833 * frame.c (make_frame): Adjust users accordingly.
1834 * print.c (print_object): Likewise.
1835 * window.c (select_window, Fwindow_use_time, make_parent_window)
1836 (make_window): Likewise.
1838 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1840 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1841 enabled with --enable-checking=[all,glyphs] configure option.
1842 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1843 adjust comments accordingly.
1844 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1845 undefined, adjust comments accordingly.
1846 * image.c: Likewise.
1847 * scroll.c: Likewise.
1848 * w32fns.c: Likewise.
1849 * w32term.c: Likewise.
1850 * xdisp.c: Likewise.
1851 * xfaces.c: Likewise.
1853 * xterm.c: Likewise.
1855 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1857 Generalize run-time debugging checks.
1858 * dispextern.h (XASSERTS): Remove.
1859 * fontset.c (xassert): Remove.
1860 Convert from xassert to eassert.
1861 * alloc.c: Convert from xassert to eassert.
1863 * dispnew.c: Likewise.
1865 * fringe.c: Likewise.
1866 * ftfont.c: Likewise.
1867 * gtkutil.c: Likewise.
1868 * image.c: Likewise.
1869 * keyboard.c: Likewise.
1871 * process.c: Likewise.
1872 * scroll.c: Likewise.
1873 * sound.c: Likewise.
1875 * w32console.c: Likewise.
1876 * w32fns.c: Likewise.
1877 * w32term.c: Likewise.
1878 * window.c: Likewise.
1879 * xdisp.c: Likewise.
1880 * xfaces.c: Likewise.
1882 * xselect.c: Likewise.
1883 * xterm.c: Likewise.
1885 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1887 * fns.c (maybe_resize_hash_table): Output message when growing the
1890 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1892 * alloc.c (allocate_string_data): Remove dead code.
1893 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1894 avoid GCC warning about unused macro.
1896 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1898 * alloc.c (allocate_string): Omit intervals initialization.
1899 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1900 as in make_pure_string and make_pure_c_string.
1902 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1904 * alloc.c (allocate_string): Fix last change.
1906 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1908 * alloc.c (allocate_string): Remove two redundant calls
1909 to memset, add explicit initialization where appropriate.
1911 2012-06-27 Glenn Morris <rgm@gnu.org>
1913 * lisp.mk (lisp): Remove paths.elc.
1915 2012-06-27 Chong Yidong <cyd@gnu.org>
1917 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1919 2012-06-26 John Wiegley <johnw@newartisans.com>
1921 * unexmacosx.c (copy_data_segment): Add two section names used
1922 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1924 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1925 when building with Clang.
1927 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1929 * eval.c (Fapply): Allow calling it with a single argument.
1931 2012-06-26 Eli Zaretskii <eliz@gnu.org>
1933 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1934 _stricmp and _strnicmp.
1935 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1937 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1939 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1941 (allocate_process): Likewise for new process.
1942 (allocate_terminal): Change to use offsetof.
1943 (allocate_frame): Likewise.
1944 * frame.c (make_frame): Omit redundant initialization.
1945 * window.c (make_parent_window): Use memset.
1946 (make_window): Omit redundant initialization.
1947 * process.c (make_process): Omit redundant initialization.
1948 * terminal.c (create_terminal): Likewise.
1950 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1952 * term.c (delete_tty): Remove redundant call to memset.
1954 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1956 * alloc.c: Remove build_string.
1957 * lisp.h: Define build_string as static inline. This provides
1958 a better opportunity to optimize away calls to strlen when the
1959 function is called with compile-time constant argument.
1960 * image.c (imagemagick_error): Convert to build_string.
1961 * w32proc.c (sys_spawnve): Likewise.
1962 * xterm.c (x_term_init): Likewise.
1964 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1966 Use sprintf return value instead of invoking strlen on result.
1967 In the old days this wasn't portable, since some sprintf
1968 implementations returned char *. But they died out years ago and
1969 Emacs already assumes sprintf returns int.
1970 Similarly for float_to_string.
1971 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1972 * ccl.c (ccl_driver):
1973 * character.c (string_escape_byte8):
1974 * data.c (Fnumber_to_string):
1975 * doprnt.c (doprnt):
1976 * print.c (print_object):
1977 * xdisp.c (message_dolog):
1978 * xfns.c (syms_of_xfns):
1979 Use sprintf or float_to_string result to avoid need to call strlen.
1980 * data.c (Fnumber_to_string):
1981 Use make_unibyte_string, since the string must be ASCII.
1982 * lisp.h, print.c (float_to_string): Now returns int length.
1983 * term.c (produce_glyphless_glyph):
1984 Use sprintf result rather than recomputing it.
1986 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1987 * Makefile.in (ALL_CFLAGS):
1988 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1989 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1991 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1993 * dispextern.h (xstrcasecmp): Define to library function
1994 strcasecmp if available.
1995 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1997 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1999 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2000 Avoid comma operator.
2001 * menu.c (push_submenu_start, push_submenu_end)
2002 (push_left_right_boundary, push_menu_pane): Likewise.
2003 * msdos.c (dos_rawgetc): Likewise.
2005 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2007 * xfns.c (xic_create_fontsetname): Remove redundant calls
2010 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2012 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2013 sprintf already null-terminates its output.
2015 * xfns.c (x_window): Remove redundant cast.
2017 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2019 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2020 `const char *' to `char *' to avoid compiler warning.
2022 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2024 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2025 instead of truncating it to 63 (admittedly a generous limit).
2027 * process.c: Fix spelling and caps in comments.
2029 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2031 * emacs.c (setpgrp): Remove definition, unused.
2032 * sysdep.c (setpgrp): Remove definition, not used in this file.
2034 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
2036 * makefile.w32-in: Update dependencies.
2038 2012-06-24 Eli Zaretskii <eliz@gnu.org>
2040 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2041 (SYSTIME_H): Add nt/inc/sys/time.h.
2043 * systime.h [WINDOWSNT]: Include sys/time.h.
2045 * s/ms-w32.h (struct timespec): Definition moved from
2046 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2048 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2050 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2051 * buffer.h (buffer_slot_type_mismatch):
2052 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2053 * eval.c (unwind_to_catch):
2054 * image.c (my_png_error, my_error_exit):
2055 * keyboard.c (quit_throw_to_read_char, user_error)
2056 (Fexit_recursive_edit, Fabort_recursive_edit):
2057 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2058 (wrong_type_argument, buffer_overflow, __executable_start)
2059 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2060 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2061 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2063 (child_setup) [!DOS_NT]:
2064 * lread.c (end_of_file_error, invalid_syntax):
2065 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2066 * puresize.h (pure_write_error):
2067 * search.c (matcher_overflow):
2068 * sound.c (sound_perror, alsa_sound_perror):
2069 * sysdep.c, syssignal.h (croak):
2070 * term.c (maybe_fatal, vfatal):
2071 * textprop.c (text_read_only):
2072 * undo.c (user_error):
2073 * unexmacosx.c (unexec_error):
2074 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2075 Use _Noreturn rather than NO_RETURN.
2076 No need for separate decl merely because of _Noreturn.
2077 * sound.c (sound_warning, parse_sound):
2078 Remove unnecessary forward decls.
2080 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2082 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2083 * lisp.h (WAIT_READING_MAX): New macro.
2084 * dispnew.c (Fsleep_for, sit_for):
2085 * keyboard.c (kbd_buffer_get_event):
2086 * process.c (Faccept_process_output):
2087 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2088 This improves on the previous patch, which introduced a bug
2089 when time_t is unsigned and as wide as intmax_t.
2090 See <http://bugs.gnu.org/9000#51>.
2092 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2094 * dispnew.c (sit_for, Fsleep_for):
2095 * keyboard.c (kbd_buffer_get_event):
2096 * process.c (Faccept_process_output): Avoid compiler warnings when
2097 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2099 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
2101 * makefile.w32-in: Update dependencies.
2103 * w32.c (ltime): Add return type and declare static.
2104 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2106 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2108 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2109 Privately reported by Herbert J. Skuhra.
2110 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2112 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2113 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2115 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2117 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2118 last argument of make_unibyte_string.
2120 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2121 language ID in the event parameters.
2123 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2124 event.code, not the obscure "character set ID".
2126 2012-06-23 Chong Yidong <cyd@gnu.org>
2128 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2130 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2132 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2133 * w32.c (fdutimens): New function.
2135 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2137 * s/ms-w32.h (pselect): Redirect to sys_select.
2139 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2141 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2142 in the logic of incrementing and decrementing the value of
2143 use_relocatable_buffers.
2145 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2147 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2148 Privately reported by Herbert J. Skuhra.
2149 [__FreeBSD__]: Remove "*/" typo after "#include".
2150 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2151 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2152 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2153 Don't assume EMACS_TIME and struct timeval are the same type.
2155 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2157 Support higher-resolution time stamps (Bug#9000).
2158 The time stamps are only nanosecond-resolution at the C level,
2159 since that's the best that any real-world system supports now.
2160 But they are picosecond-resolution at the Lisp level, as that's
2161 easy, and leaves room for future OS improvements.
2163 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2166 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2167 Don't get current time unless it's needed.
2169 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2170 now provides it if it's absent.
2171 (start_atimer): Port to higher-res time stamps.
2172 Check for time stamp overflow. Don't get current time more
2173 often than is needed.
2175 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2176 Include systime.h, not time.h.
2177 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2179 * dired.c: Include stat-time.h.
2180 (Ffile-attributes): File times now have higher resolution.
2182 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2183 (struct image): Timestamp now has higher resolution.
2185 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2186 has at least microseconds now. All uses removed.
2187 (update_frame, update_single_window, update_window, update_frame_1)
2188 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2190 * editfns.c (time_overflow): Now extern.
2191 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2192 (float-time, Fformat_time_string, Fcurrent_time_string)
2193 (Fcurrent_time_zone): Accept and generate higher-resolution
2195 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2196 (decode_time_components, lisp_seconds_argument): New functions.
2197 (make_time): Now static.
2198 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2199 Report an error if the time is invalid, rather than having the caller
2202 * fileio.c: Include <stat-time.h>
2203 (Fcopy_file): Copy higher-resolution time stamps.
2204 Prefer to set the time stamp via a file descriptor if that works.
2205 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2206 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2207 (Fvisited_file_modtime, Fset_visited_file_modtime):
2208 Support higher-resolution time stamps.
2210 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2212 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2214 * image.c (prepare_image_for_display, clear_image_cache)
2215 (lookup_image): Port to higer-resolution time stamps.
2217 * keyboard.c (start_polling, bind_polling_period):
2218 Check for time stamp overflow.
2219 (read_char, kbd_buffer_get_event, timer_start_idle)
2220 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2221 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2222 Port to higher-resolution time stamps. Do not assume time_t is signed.
2223 (decode_timer): New function. Timers are now vectors of length 9,
2224 not 8, to accommodate the picosecond component.
2225 (timer_check_2): Use it.
2227 * nsterm.m (select_timeout, timeval_subtract): Remove.
2228 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2229 as they're a bit more accurate and handle overflow better.
2230 (ns_select): Change prototype to be compatible with pselect.
2231 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2232 * nsterm.h (ns_select): Adjust prototype.
2234 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2235 us-resolution time stamps.
2236 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2238 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2240 * lisp.h (time_overflow): New decl.
2241 (wait_reading_process_output): First arg is now intmax_t, not int,
2242 to accommodate larger waits.
2244 * process.h (struct Lisp_Process.read_output_delay):
2245 Now counts nanoseconds, not microseconds.
2246 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2248 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2249 (wait_reading_process_output):
2250 Port to ns-resolution time stamps.
2251 (Faccept_process_output, wait_reading_process_output):
2252 Check for time stamp overflow. Do not assume time_t is signed.
2253 (select_wrapper): Remove; we now use pselect.
2254 (Fprocess_attributes): Now generates ns-resolution time stamps.
2256 * sysdep.c: Include utimens.h. Don't include utime.h
2257 or worry about struct utimbuf; gnulib does that for us now.
2258 (gettimeofday): Remove; gnulib provides a substitute.
2259 (make_timeval): New function.
2260 (set_file_times): Now sets ns-resolution time stamps.
2261 New arg FD; all uses changed.
2262 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2263 (system_process_attributes):
2264 Now returns ns-resolution time stamp. All uses changed.
2265 Check for time stamp overflow.
2267 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2268 provides a substitute now.
2270 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2271 since it guarantees struct timespec.
2272 (EMACS_TIME): Now struct timespec, so that we can support
2273 ns-resolution time stamps.
2274 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2275 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2276 (EMACS_USECS): Remove.
2277 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2278 so multiply the arg by 1000 before storing it.
2279 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2281 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2282 Port to ns-resolution time stamps.
2283 (EMACS_TIME_NEG_P): Remove; replaced by....
2284 (EMACS_TIME_SIGN): New macro.
2285 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2286 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2287 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2288 (make_timeval, make_lisp_time, decode_time_components): New decls.
2289 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2290 that it mishandled time_t overflow. You can't compare by subtracting!
2291 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2292 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2294 * term.c: Include <sys/time.h>.
2295 (timeval_to_Time): New function, for proper overflow wraparound.
2296 (term_mouse_position, term_mouse_click): Use it.
2298 * undo.c (record_first_change): Support higher-resolution time stamps
2300 (Fprimitive_undo): Use them when restoring time stamps.
2302 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2303 (w32_get_internal_run_time):
2304 Port to higher-resolution Emacs time stamps.
2305 (ltime): Now accepts single 64-bit integer, as that's more convenient
2308 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2310 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2311 for compatibility with pselect. Support ns-resolution time stamps.
2313 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2315 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2316 Check for time stamp overflow, and support ns-resolution time stamps.
2318 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2319 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2320 (timeval_subtract): Remove; no longer needed.
2321 (XTflash, XTring_bell, x_wait_for_event):
2322 Port to ns-resolution time stamps. Don't assume time_t is signed.
2324 2012-06-22 Chong Yidong <cyd@gnu.org>
2326 * xdisp.c (x_consider_frame_title): Revert last change.
2328 2012-06-22 Eli Zaretskii <eliz@gnu.org>
2330 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2331 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2332 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2333 staticidx goes up to 1597 out of 1600 = 0x640.)
2335 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2337 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2338 Otherwise, the umask might be mistakenly 0 while handling input signals.
2340 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2342 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2344 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2346 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2347 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2348 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2349 access to `contents' member of Lisp_Vector objects with AREF and ASET
2352 2012-06-19 Chong Yidong <cyd@gnu.org>
2354 * frame.c (delete_frame): When selecting a frame on a different
2355 text terminal, do not alter the terminal's top-frame.
2357 * xdisp.c (format_mode_line_unwind_data): Record the target
2358 frame's selected window and its terminal's top-frame.
2359 (unwind_format_mode_line): Restore them.
2360 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2362 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2363 since tty frames can be explicitly named.
2364 (prepare_menu_bars): Likewise.
2366 * term.c (Ftty_top_frame): New function.
2368 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2370 Port byte-code-meter to modern targets.
2371 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2372 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
2373 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
2374 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2375 (METER_1, METER_2): Simplify.
2377 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2379 * data.c (Fdefalias): Return `symbol' (bug#11686).
2381 2012-06-18 Martin Rudalics <rudalics@gmx.at>
2383 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
2384 gets killed during executing of this function (Bug#11665).
2385 Try to always return Qt when the buffer has been actually killed.
2386 (Vkill_buffer_query_functions): In doc-string say that functions
2387 run by this hook should not change the current buffer.
2389 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2391 Fix recently-introduced process.c problems found by static checking.
2392 * process.c (write_queue_push, write_queue_pop, send_process):
2393 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2394 (write_queue_pop): Fix pointer signedness problem.
2395 (send_process): Remove unused local.
2397 2012-06-17 Chong Yidong <cyd@gnu.org>
2399 * xdisp.c (redisplay_internal): No need to redisplay terminal
2400 frames that are not on top.
2402 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
2404 * process.c (make_process): Initialize write_queue.
2405 (write_queue_push, write_queue_pop): New functions.
2406 (send_process): Use them to maintain correct ordering of process
2409 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2411 * lisp.h (eassert): Assume C89 or later.
2412 This removes the need for CHECK.
2413 (CHECK): Remove. Its comments about always evaluating its
2414 argument were confusing, as 'eassert' typically does not evaluate
2417 * coding.c (produce_chars): Use ptrdiff_t, not int.
2419 * xterm.c (x_draw_underwave): Check for integer overflow.
2420 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2422 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
2424 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2425 referenced (Bug#11583).
2427 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2429 Implement wave-style variant of underlining.
2430 * dispextern.h (face_underline_type): New enum.
2431 (face): Add field for underline type.
2432 * nsterm.m (ns_draw_underwave): New function.
2433 (ns_draw_text_decoration): Use it.
2434 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2436 (x_draw_glyph_string): Use them.
2437 * xfaces.c (Qline, Qwave): New Lisp objects.
2438 (check_lface_attrs, merge_face_ref)
2439 (Finternal_set_lisp_face_attribute, realize_x_face):
2440 Handle wave-style underline face attributes.
2441 * xterm.c (x_draw_underwave): New function.
2442 (x_draw_glyph_string): Use it.
2444 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
2446 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2447 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2448 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2449 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2450 ($(BLD)/w32select.$(O)): Update dependencies.
2452 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2454 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2455 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2456 * character.c (_fetch_multibyte_char_p): Remove.
2457 * alloc.c: Include "character.h" before "buffer.h".
2459 * buffer.c: Likewise.
2460 * bytecode.c: Likewise.
2461 * callint.c: Likewise.
2462 * callproc.c: Likewise.
2463 * casefiddle.c: Likewise.
2464 * casetab.c: Likewise.
2465 * category.c: Likewise.
2467 * coding.c: Likewise.
2468 * composite.c: Likewise.
2469 * dired.c: Likewise.
2470 * dispnew.c: Likewise.
2472 * dosfns.c: Likewise.
2473 * editfns.c: Likewise.
2474 * emacs.c: Likewise.
2475 * fileio.c: Likewise.
2476 * filelock.c: Likewise.
2478 * fontset.c: Likewise.
2479 * fringe.c: Likewise.
2480 * indent.c: Likewise.
2481 * insdel.c: Likewise.
2482 * intervals.c: Likewise.
2483 * keyboard.c: Likewise.
2484 * keymap.c: Likewise.
2485 * lread.c: Likewise.
2486 * macros.c: Likewise.
2487 * marker.c: Likewise.
2488 * minibuf.c: Likewise.
2489 * nsfns.m: Likewise.
2490 * nsmenu.m: Likewise.
2491 * print.c: Likewise.
2492 * process.c: Likewise.
2493 * regex.c: Likewise.
2494 * region-cache.c: Likewise.
2495 * search.c: Likewise.
2496 * syntax.c: Likewise.
2498 * textprop.c: Likewise.
2500 * unexsol.c: Likewise.
2501 * w16select.c: Likewise.
2502 * w32fns.c: Likewise.
2503 * w32menu.c: Likewise.
2504 * window.c: Likewise.
2505 * xdisp.c: Likewise.
2507 * xmenu.c: Likewise.
2509 * xselect.c: Likewise.
2511 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2513 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2514 If all the glyphs of the glyph row came from strings, and we have no
2515 cursor positioning clues, put the cursor on the first glyph of the
2517 (handle_face_prop): Use chunk-relative overlay string index when
2518 indexing into it->string_overlays array. (Bug#11653)
2519 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2520 the rightmost. (Bug#11720)
2522 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2524 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2525 (CATEGORY_MEMBER): Enforce 1/0 value.
2526 * category.c (_temp_category_set): Remove.
2528 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2530 * window.c (Fdelete_other_windows_internal)
2531 (Fdelete_window_internal): Don't access frame's mouse highlight
2532 info of the initial frame. (Bug#11677)
2534 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2536 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2537 Assume USE_2_TAGS_FOR_INTS.
2538 (xreload): Adjust $tagmask width to match recent lisp.h change.
2540 Simplify lisp.h in minor ways that should not affect code.
2541 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2542 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2543 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2544 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2545 (INTTYPEBITS): New macro, for clarity.
2546 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
2547 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2548 Simplify now that USE_LSB_TAG is always defined.
2549 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2550 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2552 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
2554 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2556 2012-06-13 Glenn Morris <rgm@gnu.org>
2558 * s/bsd-common.h (BSD4_3):
2559 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2561 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2563 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2566 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2568 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
2569 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
2570 * alloc.c (widen_to_Lisp_Object): Remove.
2571 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2572 * frame.c (delete_frame): Remove outdated comment.
2573 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2574 USE_LISP_UNION_TYPE.
2575 (Fw32_unregister_hot_key): Likewise.
2576 (Fw32_toggle_lock_key): Likewise.
2577 * w32menu.c (add_menu_item): Likewise.
2578 (w32_menu_display_help): Use XIL instead of checking
2579 USE_LISP_UNION_TYPE.
2580 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2581 (init_heap): Likewise.
2582 * w32term.c (w32_read_socket): Update comment.
2584 2012-06-13 Glenn Morris <rgm@gnu.org>
2586 * s/usg5-4-common.h, src/s/unixware.h:
2587 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2589 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2591 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2593 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2594 * alloc.c (make_number) [!defined make_number]:
2595 Remove, as lisp.h always defines this now.
2596 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2597 (roundup_size): Verify that it is a power of 2.
2598 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2599 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2600 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2601 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2602 USE_LSB_TAG now is always defined to be either 0 or 1.
2604 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2605 code works fine either way, and efficiency is not a concern here,
2606 as the union type is for debugging, not for production.
2607 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2608 Use an inline function on all platforms when using the union type,
2609 since this is simpler and 'static inline' can be used portably
2611 (LISP_INITIALLY_ZERO): New macro.
2612 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2613 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2615 2012-06-12 Glenn Morris <rgm@gnu.org>
2617 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2619 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
2621 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2622 Move BROKEN_SIGIO to configure.
2624 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2625 Move NO_TERMIO to configure.
2627 2012-06-12 Chong Yidong <cyd@gnu.org>
2629 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2630 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2631 MagickExportImagePixels is undefined.
2633 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2635 * image.c (imagemagick_load_image): Remove unused label.
2637 2012-06-11 Glenn Morris <rgm@gnu.org>
2639 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2640 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2641 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2642 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2644 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2646 * alloc.c (make_byte_code): New function.
2647 (Fmake_byte_code): Use it. Don't purify here.
2648 * lread.c (read1): Use it as well to avoid extra allocation.
2650 2012-06-11 Chong Yidong <cyd@gnu.org>
2652 * image.c (imagemagick_load_image): Implement transparency.
2654 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2656 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2657 account for preceding backslashes. (Bug#11663)
2659 2012-06-09 Chong Yidong <cyd@gnu.org>
2661 * term.c: Support italics in capable terminals (Bug#9652).
2662 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2663 (turn_on_face): Output using TS_enter_italic_mode if available.
2664 Don't handle unused blinking and alt-charset cases.
2665 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2666 and tty_alt_charset_p cases.
2667 (tty_capable_p, init_tty): Support italics.
2669 * termchar.h (struct tty_display_info): Add field for italics.
2670 Remove unused blink field.
2672 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2675 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2676 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2677 tty_alt_charset_p. Add tty_italic_p.
2679 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
2681 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2682 dbus_type_is_basic if available.
2683 (xd_extract_signed, xd_extract_unsigned): Rename from
2684 extract_signed and extract_unsigned, respectively. Adapt callers.
2686 2012-06-09 Chong Yidong <cyd@gnu.org>
2688 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2690 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2693 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2695 * xdisp.c (vmessage): Treat frame message as multibyte.
2696 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2697 would generate the diagnostic "Making \302\247 buffer-local while
2700 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2702 * dispnew.c (showing_window_margins_p): Undo last change, which
2703 was done due to an inadvertent commit.
2704 (adjust_frame_glyphs_for_frame_redisplay): Do call
2705 showing_window_margins_p.
2707 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2709 * eval.c (Fmake_var_non_special): New primitive.
2710 (syms_of_eval): Defsubr it.
2711 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2713 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
2715 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2716 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2718 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2720 * alloc.c (allocate_vectorlike): Fix last change.
2722 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2724 Block-based vector allocation of small vectors.
2725 * lisp.h (struct vectorlike_header): New field `nbytes',
2726 adjust comment accordingly.
2727 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2728 to denote vector blocks. Adjust users (live_vector_p,
2729 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2730 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2731 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2732 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2733 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2734 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2735 (roundup_size): New constant.
2736 (struct vector_block): New data type.
2737 (vector_blocks, vector_free_lists, zero_vector): New variables.
2738 (all_vectors): Rename to `large_vectors'.
2739 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2740 (sweep_vectors): New functions.
2741 (allocate_vectorlike): Return `zero_vector' as the only vector of
2742 0 items. Allocate new vector from block if vector size is less than
2743 or equal to VBLOCK_BYTES_MAX.
2744 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2745 (init_alloc_once): Add call to init_vectors.
2747 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2749 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2751 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2753 * doprnt.c (doprnt): Truncate multibyte char correctly.
2754 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2755 would mishandle a string argument "Xc" if X was a multibyte
2756 character of length 2: it would truncate after X's first byte
2757 rather than including all of X.
2759 2012-06-06 Chong Yidong <cyd@gnu.org>
2761 * buffer.c (word_wrap): Doc fix.
2763 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2765 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2767 2012-06-03 Glenn Morris <rgm@gnu.org>
2769 * xdisp.c (tool-bar-style): Doc fix.
2771 2012-06-03 Ulrich Müller <ulm@gentoo.org>
2773 * Makefile.in (PAXCTL): Define.
2774 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2775 binary via PaX flags if the paxctl utility is available.
2776 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2777 Restore PaX flags to their default. (Bug#11398)
2779 2012-06-03 Chong Yidong <cyd@gnu.org>
2781 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2784 2012-06-03 Chong Yidong <cyd@gnu.org>
2786 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2787 (note_mode_line_or_margin_highlight): If there is no help echo,
2788 use mode-line-default-help-echo. Handle the case where the mouse
2789 position is past the end of the mode line string.
2791 * buffer.c (buffer_local_value_1): New function, split from
2792 Fbuffer_local_value; can return Qunbound.
2793 (Fbuffer_local_value): Use it.
2794 (Vmode_line_format): Docstring tweaks.
2796 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2798 * sysdep.c (system_process_attributes): Improve comment.
2800 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2802 * keyboard.c: Export real-this-command to Elisp.
2803 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2804 and DEFVAR it. Update all users.
2806 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2808 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2810 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2811 Convert pctcpu and pctmem to Lisp float properly.
2812 Let the compiler fold better, as 100.0/0x8000 is exact.
2814 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2816 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2819 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2821 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2823 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2825 For a 'struct window', replace some Lisp_Object fields to
2826 bitfields where appropriate, remove unused fields.
2827 * window.h (struct window): Remove unused 'last_mark_x' and
2828 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2829 change it's type from Lisp_Object to bitfield.
2830 Change type of 'force_start', 'optional_new_start',
2831 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2832 fields from Lisp_Object to bitfield. Adjust users accordingly.
2834 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2836 Pacify gcc -Wdouble-precision when using Xaw.
2837 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2838 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2839 Use 'float' consistently, rather than 'float' in most places
2840 and 'double' in a couple of places.
2842 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2844 * xdisp.c (handle_stop): Detect whether we have overlay strings
2845 loaded by testing it->current.overlay_string_index to be
2846 non-negative, instead of checking whether n_overlay_strings is
2847 positive. (Bug#11587)
2849 2012-05-31 Chong Yidong <cyd@gnu.org>
2851 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2853 * doc.c (Fsubstitute_command_keys): Doc fix.
2855 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2857 * search.c (search_buffer): Remove calls to
2858 r_alloc_inhibit_buffer_relocation, as it is now called by
2859 maybe_unify_char, which was the cause of relocation of buffer text
2862 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2864 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2865 for the duration of call to load_charset, to avoid problems with
2866 callers of maybe_unify_char that access buffer text through C
2869 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2870 decrement the inhibition flag, instead of just setting or
2873 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2875 Remove obsolete '#define static' cruft.
2876 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2877 This #undef was "temporary" in 2000; it is no longer needed
2878 now that '#define static' has gone away.
2879 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2880 (gray_bitmap_bits): Remove; no longer needed.
2881 All uses replaced with definiens.
2882 * xterm.c: Include "bitmaps/gray.xbm".
2884 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2886 Clean up __executable_start, monstartup when --enable-profiling.
2887 The following changes affect the code only when profiling.
2888 * dispnew.c (__executable_start): Rename from safe_bcopy.
2889 Define only on platforms that need it.
2890 * emacs.c: Include <sys/gmon.h> when profiling.
2891 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2892 (__executable_start): Remove decl, since lisp.h does it now.
2893 (safe_bcopy): Remove decl; no longer has that name.
2894 (main): Coalesce #if into single bit of code, for simplicity.
2895 Cast pointers to uintptr_t, since standard libraries want integers
2897 * lisp.h (__executable_start): New decl.
2899 2012-05-31 Glenn Morris <rgm@gnu.org>
2901 * image.c (Fimagemagick_types): Doc fix.
2903 2012-05-30 Jim Meyering <meyering@redhat.com>
2905 * callproc.c (Fcall_process_region): Include directory component
2906 in mkstemp error message (Bug#11586).
2908 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2910 * alloc.c, lisp.h (make_pure_vector): Now static.
2912 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2914 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2915 Move to byte-run.el.
2916 (Fautoload): Do the hash-doc more carefully.
2917 * data.c (Fdefalias): Purify definition, except for keymaps.
2918 (Qdefun): Move from eval.c.
2919 * lisp.h (Qdefun): Remove.
2920 * lread.c (read1): Tiny simplification.
2922 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
2924 Do not create empty overlays with the evaporate property (Bug#9642).
2925 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2926 Bug#9642, but explicitly check that the buffer the overlay would
2927 be moved to is live and rearrange lines to make sure that errors
2928 will not put the overlay in an inconsistent state.
2929 (Fdelete_overlay): Cosmetics.
2931 2012-05-28 Eli Zaretskii <eliz@gnu.org>
2933 * w32term.c (my_bring_window_to_top): New function.
2934 (x_raise_frame): Use handle returned by DeferWindowPos, which
2935 could be different from the original one.
2936 Call my_bring_window_to_top instead of my_set_foreground_window.
2939 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2940 by calling BringWindowToTop.
2942 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2943 (WM_EMACS_END): Increase by one.
2945 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2947 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2948 This avoids undefined behavior that might cause the eassert
2949 to not catch an out-of-range value.
2951 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
2953 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2954 Update dependencies.
2956 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2958 * bidi.c (bidi_mirror_char): Fix last change.
2960 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2962 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2963 when referring to sectname field in printf format.
2965 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2967 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2968 Only r_alloc_inhibit_buffer_relocation needed to be added;
2969 the others were already declared.
2971 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2972 before checking whether it's out of range. Put the check inside
2974 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2976 2012-05-27 Ken Brown <kbrown@cornell.edu>
2978 * callproc.c (Fcall_process): Restore a line that was accidentally
2979 commented out in the 2011-02-13 change (bug#11547).
2981 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2983 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2984 defined on ralloc.c.
2986 * buffer.c [REL_ALLOC]: Remove prototypes of
2987 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2988 they are now on lisp.h.
2990 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2992 * search.c (search_buffer): Use it to inhibit relocation of buffer
2993 text while re_search_2 is doing its job, because re_search_2 is
2994 passed C pointers to buffer text. (Bug#11519)
2996 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2999 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3000 state after an additional call to move_it_in_display_line_to, keep
3001 the values of it->max_ascent and it->max_descent found for the
3003 (pos_visible_p): Revert the comparison against bottom_y to what it
3004 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3007 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3009 Fix coding-related core dumps with gcc -ftrapv.
3010 The code was computing A - B, where A and B are pointers, and B is
3011 random garbage. This can lead to core dumps on platforms that
3012 have special pointer registers, and it also leads to core dumps on
3013 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3014 A - B only when B is initialized properly.
3015 * coding.c (coding_set_source, coding_set_destination): Return void.
3016 (coding_change_source, coding_change_destinations): New functions,
3017 with the old behaviors of coding_set_source and coding_set_destination.
3018 All callers that need an offset changed to use these new functions.
3020 2012-05-26 Glenn Morris <rgm@gnu.org>
3022 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3024 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3026 Extend mouse support on W32 text-mode console.
3027 * xdisp.c (draw_row_with_mouse_face):
3028 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
3030 * w32console.c: Include window.h.
3031 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3033 (initialize_w32_display): Initialize mouse-highlight data.
3035 * w32inevt.c: Include termchar.h and window.h.
3036 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3037 moves, call note_mouse_highlight. If help_echo changed, call
3038 gen_help_event to produce help-echo message in the echo area.
3039 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3042 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3044 * lread.c (read1): Simplify slightly to avoid an overflow warning
3045 with GCC 4.7.0 on x86-64.
3047 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3049 * bidi.c (bidi_mirror_char): Revert last change: an int is
3050 definitely wide enough here.
3052 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3054 Fix integer width and related bugs (Bug#9874).
3055 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
3056 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3057 (string_bytes, check_sblock, allocate_string_data):
3058 (compact_small_strings, Fmake_bool_vector, make_string)
3059 (make_unibyte_string, make_multibyte_string)
3060 (make_string_from_bytes, make_specified_string)
3061 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3062 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3064 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3065 (allocate_pseudovector):
3066 Use int, not EMACS_INT, where int is wide enough.
3067 (inhibit_garbage_collection, Fgarbage_collect):
3068 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3069 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3070 int might not be wide enough.
3071 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3072 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3073 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3074 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3075 (bidi_level_of_next_char, bidi_move_to_visually_next):
3076 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3077 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3078 (Fkill_buffer, Fset_buffer_major_mode)
3079 (advance_to_char_boundary, Fbuffer_swap_text)
3080 (Fset_buffer_multibyte, overlays_at, overlays_in)
3081 (overlay_touches_p, struct sortvec, record_overlay_string)
3082 (overlay_strings, recenter_overlay_lists)
3083 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3084 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3085 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3086 (Foverlay_recenter, last_overlay_modification_hooks_used)
3087 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3088 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3089 (validate_region): Omit unnecessary test for b <= e,
3090 since that's guaranteed by the previous test.
3091 (adjust_overlays_for_delete): Avoid pos + length overflow.
3092 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3093 (report_overlay_modification):
3094 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3095 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3096 Omit pointer cast, which isn't needed anyway, and doesn't work
3097 after the EMACS_INT -> ptrdiff_t change.
3098 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
3099 * buffer.h: Adjust decls to match defn changes elsewhere.
3100 (struct buffer_text, struct buffer):
3101 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3102 Use EMACS_INT, not int, where int might not be wide enough.
3103 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3104 not int, to avoid needless 32-bit limit on 64-bit hosts.
3105 (exec_byte_code): Use tighter memory-full test, one that checks
3106 for alloca overflow. Don't compute the address of the object just
3107 before an array, as that's not portable. Use EMACS_INT, not
3108 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
3109 * callint.c (Fcall_interactively):
3110 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3111 * callproc.c (call_process_kill, Fcall_process):
3112 Don't assume pid_t fits into an Emacs fixnum.
3113 (call_process_cleanup, Fcall_process, child_setup):
3114 Don't assume pid_t fits into int.
3115 (call_process_cleanup, Fcall_process, delete_temp_file)
3116 (Fcall_process_region):
3117 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3118 (Fcall_process): Simplify handling of volatile integers.
3119 Use int, not EMACS_INT, where int will do.
3120 * casefiddle.c (casify_object, casify_region, operate_on_word)
3121 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3122 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3123 (casify_object): Avoid integer overflow when overallocating buffer.
3124 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
3125 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
3126 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3127 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3128 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3129 integers are now checked earlier. All uses replaced with XINT.
3131 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3132 For CCL_MapSingle, check that content and value are in int range.
3133 (ccl_driver, Fregister_code_conversion_map):
3134 Check that Vcode_version_map_vector is a vector.
3135 (resolve_symbol_ccl_program): Check that vector header is in range.
3136 Always copy the vector, so that we can check its contents reliably
3137 now rather than having to recheck each instruction as it's being
3138 executed. Check that vector words fit in 'int'.
3139 (ccl_get_compiled_code, Fregister_ccl_program)
3140 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3141 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3142 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3143 contents are in range.
3144 (Fccl_execute_on_string): Check that status is in range.
3145 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3146 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3147 Accept and return EMACS_INT, not int, because callers can pass values
3149 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3150 (multibyte_chars_in_text, parse_str_as_multibyte)
3151 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3152 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3153 (string_escape_byte8, Fget_byte):
3154 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3155 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
3156 avoid mishandling large integers.
3157 * character.h: Adjust decls to match defn changes elsewhere.
3158 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3159 (Ffind_charset_region):
3160 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3161 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3162 (load_charset_map_from_vector, Fdefine_charset_internal):
3163 Don't assume fixnum fits in int.
3164 (load_charset_map_from_vector, Fmap_charset_chars):
3165 Remove now-unnecessary CHECK_NATNUMs.
3166 (Fdefine_charset_internal): Check ranges here, more carefully.
3167 Don't rely on undefined behavior with signed left shift overflow.
3168 Don't assume unsigned int fits into fixnum, or that fixnum fits
3169 into unsigned int. Don't require max_code to be a valid fixnum;
3170 that's not true for gb10830 4-byte on a 32-bit host. Allow
3171 invalid_code to be a cons, for the same reason. Require code_offset
3172 to be a character. Avoid int overflow if max_char is close
3174 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3175 this is intended anyway and avoids some undefined behavior.
3176 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3177 INDEX_TO_CODE_POINT, as that's what it expects.
3178 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
3179 * charset.h (DECODE_CHAR): Return int, not unsigned;
3180 this is what was intended anyway, and it avoids undefined behavior.
3181 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3182 integer-overflow issues.
3183 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3184 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3185 where the argument is EMACS_INT, and this behavior is not intended.
3186 * chartab.c (Fmake_char_table, Fset_char_table_range)
3187 (uniprop_get_decoder, uniprop_get_encoder):
3188 Don't assume fixnum fits in int.
3189 * cmds.c (move_point): New function, that does the gist of
3190 Fforward_char and Fbackward_char, but does so while checking
3191 for integer overflow more accurately.
3192 (Fforward_char, Fbackward_char): Use it.
3193 (Fforward_line, Fend_of_line, internal_self_insert)
3194 (internal_self_insert):
3195 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3196 Fix a FIXME, by checking for integer overflow when calculating
3197 target_clm and actual_clm.
3198 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
3199 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
3200 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3201 (coding_alloc_by_making_gap, alloc_destination)
3202 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3203 (encode_coding_utf_16, detect_coding_emacs_mule)
3204 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3205 (detect_coding_iso_2022, decode_coding_iso_2022)
3206 (encode_invocation_designation, encode_designation_at_bol)
3207 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3208 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3209 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3210 (encode_coding_ccl, encode_coding_raw_text)
3211 (detect_coding_charset, decode_coding_charset)
3212 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3213 (produce_composition, produce_charset, produce_annotation)
3214 (decode_coding, handle_composition_annotation)
3215 (handle_charset_annotation, consume_chars, decode_coding_gap)
3216 (decode_coding_object, encode_coding_object, detect_coding_system)
3217 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3218 (code_convert_region, code_convert_string)
3219 (Fdefine_coding_system_internal)
3220 (coding_set_source, coding_set_destination):
3221 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3222 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3223 (Fdefine_coding_system_internal):
3224 Don't assume fixnums fit in int.
3225 (decode_coding_gap, decode_coding_object, encode_coding_object)
3226 (Fread_coding_system, Fdetect_coding_region)
3227 (Funencodable_char_position, Fcheck_coding_systems_region)
3228 (get_translation, handle_composition_annotation, consume_chars):
3229 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3230 (consume_chars): Rewrite to not calculate an address outside buffer.
3231 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
3232 Don't access memory outside of the args array.
3233 (Fdefine_coding_system_internal): Check for charset-id overflow.
3234 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3235 result of ENCODE_CHAR.
3236 * coding.h: Adjust decls to match defn changes elsewhere.
3237 (struct coding_system):
3238 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3239 * composite.c (get_composition_id, find_composition)
3240 (run_composition_function, update_compositions)
3241 (compose_text, composition_gstring_put_cache)
3242 (composition_gstring_p, composition_gstring_width)
3243 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3244 (composition_compute_stop_pos, composition_reseat_it)
3245 (composition_update_it, struct position_record)
3246 (find_automatic_composition, composition_adjust_point)
3247 (Fcomposition_get_gstring, Ffind_composition_internal):
3248 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3249 (update_compositions):
3250 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3251 * composite.h: Adjust decls to match defn changes elsewhere.
3252 (struct composition):
3253 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3254 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3255 Do not attempt to compute the address of the object just before a
3256 buffer; this is not portable.
3258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3259 (Faset): Use int, not EMACS_INT, where int is wide enough.
3260 (Fstring_to_number): Don't assume fixnums fit in int.
3261 (Frem): Don't assume arg is nonnegative.
3262 * dbusbind.c (xd_append_arg): Check for integers out of range.
3263 (Fdbus_call_method): Don't overflow the timeout int.
3264 (extract_signed, extract_unsigned): New functions.
3265 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3266 (xd_get_connection_references): Return ptrdiff_t, not int.
3268 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3269 (xd_read_message_1):
3270 Use int, not unsigned, where the dbus API uses int.
3271 (Fdbus_message_internal): Don't overflow mtype.
3272 (syms_of_dbusbind): Allocate right-sized buffer for integers.
3273 * dired.c (directory_files_internal, file_name_completion, scmp)
3274 (file_name_completion_stat):
3275 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3276 (file_name_completion): Don't overflow matchcount.
3277 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3278 * dispextern.h: Adjust decls to match defn changes elsewhere.
3279 (struct text_pos, struct glyph, struct bidi_saved_info)
3280 (struct bidi_string_data, struct bidi_it, struct composition_it)
3282 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3283 (struct display_pos, struct composition_it, struct it):
3284 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3285 * dispnew.c (increment_matrix_positions)
3286 (increment_row_positions, mode_line_string)
3287 (marginal_area_string):
3288 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3289 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
3290 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3291 (duration_to_sec_usec): New function, to check for overflow better.
3292 (Fsleep_for, sit_for): Use it.
3293 * doc.c (get_doc_string, store_function_docstring):
3294 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3295 (get_doc_string, Fsnarf_documentation):
3296 Use int, not EMACS_INT, where int is wide enough.
3298 Use SAFE_ALLOCA, not alloca.
3299 Check for overflow when converting EMACS_INT to off_t.
3300 * doprnt.c (doprnt):
3301 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3302 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3303 Don't assume uid_t fits into fixnum.
3304 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3305 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3306 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3307 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3308 (general_insert_function)
3309 (Finsert_char, make_buffer_string, make_buffer_string_both)
3310 (update_buffer_properties, Fbuffer_substring)
3311 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3312 (Fsubst_char_in_region, check_translation)
3313 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3314 (transpose_markers, Ftranspose_regions):
3315 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3316 (clip_to_bounds): Move to lisp.h as an inline function).
3317 (Fconstrain_to_field): Don't assume integers are nonnegative.
3318 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3319 (Fsubst_char_in_region, Fsave_restriction):
3320 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3321 (Femacs_pid): Don't assume pid_t fits into fixnum.
3322 (lo_time): Use int, not EMACS_INT, when int suffices.
3323 (lisp_time_argument): Check for usec out of range.
3324 (Fencode_time): Don't assume fixnum fits in int.
3325 (Fuser_login_name, Fuser_full_name): Signal an error
3326 if a uid argument is out of range, rather than relying on
3328 (Fformat_time_string): Remove now-unnecessary check.
3329 lisp_time_argument checks for out-of-range usec now.
3330 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
3331 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3332 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3333 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3334 (init_cmdargs, Fdump_emacs):
3335 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3336 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3337 the bottom (typically) 32 bits of the fixnum.
3338 * eval.c (specpdl_size, call_debugger):
3339 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3340 (when_entered_debugger, Fbacktrace_debug):
3341 Don't assume fixnum can fit in int.
3342 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3343 the object just before a buffer; this is not portable.
3344 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3345 (grow_specpdl, unbind_to):
3346 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3347 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3348 (grow_specpdl): Simplify allocation by using xpalloc.
3349 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
3350 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3351 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3352 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3353 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3355 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3356 (Fcopy_file, non_regular_nbytes, read_non_regular)
3357 (Finsert_file_contents):
3358 Use int, not EMACS_INT, where int is wide enough.
3359 (READ_BUF_SIZE): Verify that it fits in int.
3360 (Finsert_file_contents): Check that counts are in proper range,
3361 rather than assuming fixnums fit into ptrdiff_t etc.
3362 Don't assume fixnums fit into int.
3363 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
3364 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3365 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
3366 (string_char_to_byte, string_byte_to_char)
3367 (string_make_multibyte, string_to_multibyte)
3368 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3369 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3370 (substring_both, Fdelete, internal_equal, Ffillarray)
3371 (Fclear_string, mapcar1)
3372 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3373 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3374 (larger_vector, make_hash_table, maybe_resize_hash_table)
3375 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3376 (Fmaphash, secure_hash):
3377 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3378 (concat): Check for string index and length overflow.
3379 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3381 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3382 (larger_vector): New API (vec, incr_min, size_max) replaces old
3383 one (vec, new_size, init). This catches size overflow.
3384 INIT was removed because it was always Qnil.
3385 All callers changed.
3386 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3387 the upper bound on a hash table index size.
3388 (make_hash_table, maybe_resize_hash_table): Use it.
3389 (secure_hash): Computer start_byte and end_byte only after
3390 they're known to be in ptrdiff_t range.
3391 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3392 (Ffont_get_glyphs, Ffont_at):
3393 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3394 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3395 (Flist_fonts, Fopen_font):
3396 Don't assume fixnum can fit in int.
3397 (check_gstring): Don't assume index can fit in int.
3398 (font_match_p): Check that fixnum is a character, not a nonnegative
3399 fixnum, since the later code needs to stuff it into an int.
3400 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3401 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3402 conversion overflow issues.
3403 (Fopen_font): Check for integer out of range.
3404 (Ffont_get_glyphs): Don't assume index can fit in int.
3405 * font.h: Adjust decls to match defn changes elsewhere.
3406 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3408 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3409 printmax_t, where ptrdiff_t is wide enough.
3410 (Finternal_char_font):
3411 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3412 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3413 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3414 (Fset_frame_position, x_set_frame_parameters)
3415 (x_set_line_spacing, x_set_border_width)
3416 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3417 Check that fixnums are in proper range for system types.
3418 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3419 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3420 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3421 Use SAFE_ALLOCA_LISP, not alloca.
3422 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3423 intptr_t is wide enough.
3424 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3425 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3426 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3427 Check for fixnum out of range.
3428 * ftfont.c (ftfont_list): Don't assume index fits in int.
3429 Check that fixnums are in proper range for system types.
3430 (ftfont_shape_by_flt):
3431 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3432 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3434 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3435 Check that fixnums are in proper range for system types.
3436 * gnutls.h: Adjust decls to match defn changes elsewhere.
3437 * gtkutil.c (xg_dialog_run):
3438 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3439 (update_frame_tool_bar):
3440 Check that fixnums are in proper range for system types.
3441 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
3442 (lookup_image): Check that fixnums are in range for system types.
3443 * indent.c (last_known_column, last_known_column_point):
3444 (current_column_bol_cache):
3445 (skip_invisible, current_column, check_display_width):
3446 (check_display_width, scan_for_column, current_column_1)
3447 (Findent_to, Fcurrent_indentation, position_indentation)
3448 (indented_beyond_p, Fmove_to_column, compute_motion):
3449 (Fcompute_motion, Fvertical_motion):
3450 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3451 (last_known_column_modified): Use EMACS_INT, not int.
3452 (check_display_width):
3454 Check that fixnums and floats are in proper range for system types.
3455 (compute_motion): Don't assume index or fixnum fits in int.
3456 (compute_motion, Fcompute_motion):
3457 Use int, not EMACS_INT, when it is wide enough.
3458 (vmotion): Omit local var start_hpos that is always 0; that way
3459 we don't need to worry about overflow in expressions involving it.
3460 * indent.h: Adjust decls to match defn changes elsewhere.
3462 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3463 Use int, not EMACS_INT, where int is wide enough.
3464 Remove unused members ovstring_chars_done and tab_offset;
3466 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3467 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3468 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3469 (make_gap, copy_text, insert, insert_and_inherit)
3470 (insert_before_markers, insert_before_markers_and_inherit)
3471 (insert_1, count_combining_before, count_combining_after)
3472 (insert_1_both, insert_from_string)
3473 (insert_from_string_before_markers, insert_from_string_1)
3474 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3475 (adjust_after_replace, adjust_after_insert, replace_range)
3476 (replace_range_2, del_range, del_range_1, del_range_byte)
3477 (del_range_both, del_range_2, modify_region)
3478 (prepare_to_modify_buffer, signal_before_change)
3479 (signal_after_change, Fcombine_after_change_execute):
3480 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3481 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3482 (balance_an_interval, split_interval_right, split_interval_left)
3483 (find_interval, next_interval, update_interval)
3484 (adjust_intervals_for_insertion, delete_node, delete_interval)
3485 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3486 (static_offset_intervals, offset_intervals)
3487 (merge_interval_right, merge_interval_left, make_new_interval)
3488 (graft_intervals_into_buffer, temp_set_point_both)
3489 (temp_set_point, set_point, adjust_for_invis_intang)
3490 (set_point_both, move_if_not_intangible, get_property_and_range)
3491 (get_local_map, copy_intervals, copy_intervals_to_string)
3492 (compare_string_intervals, set_intervals_multibyte_1):
3493 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3494 * intervals.h: Adjust decls to match defn changes elsewhere.
3496 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3497 * keyboard.c (this_command_key_count, this_single_command_key_start)
3498 (before_command_key_count, before_command_echo_length, echo_now)
3499 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3500 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3501 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3502 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3503 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3504 (last_non_minibuf_size, last_point_position, echo_truncate)
3505 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3506 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3507 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3508 (stuff_buffered_input):
3509 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3510 (last_auto_save, command_loop_1, read_char):
3511 Use EMACS_INT, not int, to avoid integer overflow.
3512 (record_char): Avoid overflow in total_keys computation.
3513 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3514 * keyboard.h: Adjust decls to match defn changes elsewhere.
3515 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3516 (Fkey_description, Fdescribe_vector, Flookup_key):
3517 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3518 (click_position): New function, to check that positions are in range.
3519 (Fcurrent_active_maps):
3521 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3522 (Faccessible_keymaps, Fkey_description):
3523 (preferred_sequence_p):
3524 Don't assume fixnum can fit into int.
3525 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3526 Check for integer overflow in size calculations.
3527 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3528 avoid mishandling large integers.
3529 * lisp.h: Adjust decls to match defn changes elsewhere.
3530 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3531 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3532 (struct Lisp_Marker):
3533 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3534 (clip_to_bounds): Now an inline function, moved here from editfns.c.
3535 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3536 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3537 All callers changed.
3538 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3539 Assume the arg has valid form, since it always does.
3540 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3541 unsigned integer system type.
3542 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3543 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3544 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3545 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3546 (duration_to_sec_usec): New decl.
3547 * lread.c (read_from_string_index, read_from_string_index_byte)
3548 (read_from_string_limit, readchar, unreadchar, openp)
3549 (read_internal_start, read1, oblookup):
3550 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3551 (Fload, readevalloop, Feval_buffer, Feval_region):
3552 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3553 (openp): Check for out-of-range argument to 'access'.
3554 (read1): Use int, not EMACS_INT, where int is wide enough.
3555 Don't assume fixnum fits into int.
3556 Fix off-by-one error that can read outside a buffer.
3557 (read_filtered_event): Use duration_to_sec_usec
3558 to do proper overflow checking on durations.
3559 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3560 in size calculation.
3561 (Fexecute_kbd_macro):
3562 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3563 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3564 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3565 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3566 (set_marker_both, set_marker_restricted_both, marker_position)
3567 (marker_byte_position, Fbuffer_has_markers_at):
3568 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3569 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
3570 * menu.c (ensure_menu_items): Rename from grow_menu_items.
3571 It now merely ensures that the menu is large enough, without
3572 necessarily growing it, as this avoids some integer overflow issues.
3573 All callers changed.
3574 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3575 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3576 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3577 Use SAFE_ALLOCA_LISP, not alloca.
3578 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3579 to EMACS_INT. Check that fixnums are in proper range for system types.
3580 * minibuf.c (minibuf_prompt_width, string_to_object)
3581 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3582 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3583 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3584 (get_minibuffer, read_minibuf_unwind):
3585 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3586 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3587 this simplifies overflow checking. All callers changed.
3588 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3590 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3591 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3592 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3593 Check that fixnums are in proper range for system types.
3594 (Fx_create_frame, Fx_show_tip):
3595 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3596 * nsfont.m (ns_findfonts, nsfont_list_family):
3597 Don't assume fixnum fits in long.
3598 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3599 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3600 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3602 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
3603 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3604 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3605 (PRINTDECLARE, PRINTPREPARE):
3606 (strout, print_string):
3607 (print, print_preprocess, print_check_string_charset_prop)
3609 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3611 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3612 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3613 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
3614 (printchar, strout): Use xpalloc to catch size calculation overflow.
3615 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
3616 (print_error_message): Use SAFE_ALLOCA, not alloca.
3617 (print_object): Use int, not EMACS_INT, where int is wide enough.
3618 (print_depth, new_backquote_output, print_number_index):
3619 Use ptrdiff_t, not int, where int might not be wide enough.
3620 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3621 (Fset_process_window_size, Fformat_network_address)
3622 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
3624 Check that fixnums are in proper range for system types.
3625 (Fsignal_process): Simplify by avoiding a goto.
3626 Check for process-ids out of pid_t range rather than relying on
3628 (process_tick, update_tick): Use EMACS_INT, not int.
3629 (Fformat_network_address, read_process_output, send_process)
3630 (Fprocess_send_region, status_notify):
3631 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3632 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3633 (wait_reading_process_output, read_process_output, exec_sentinel):
3634 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3635 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3636 (Faccept_process_output): Use duration_to_sec_usec to do proper
3637 overflow checking on durations.
3638 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3639 Don't assume pid_t fits in int.
3640 * process.h (struct Lisp_Process): Members tick and update_tick
3641 are now of type EMACS_INT, not int.
3642 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3643 configured --with-wide-int.
3644 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3645 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3646 * search.c (looking_at_1, string_match_1):
3647 (fast_string_match, fast_c_string_match_ignore_case)
3648 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3649 (scan_newline, find_before_next_newline, search_command)
3650 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3651 (set_search_regs, wordify):
3654 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3655 (string_match_1, search_buffer, set_search_regs):
3657 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3658 (wordify): Check for overflow in size calculation.
3659 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3660 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3661 Check that fixnums are in proper range for system types.
3662 * sound.c (struct sound_device)
3663 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3664 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3665 (Fplay_sound_internal):
3666 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3667 * syntax.c (struct lisp_parse_state, find_start_modiff)
3668 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3669 (Fparse_partial_sexp):
3670 Don't assume fixnums can fit in int.
3671 (struct lisp_parse_state, find_start_pos, find_start_value)
3672 (find_start_value_byte, find_start_begv)
3673 (update_syntax_table, char_quoted, dec_bytepos)
3674 (find_defun_start, prev_char_comend_first, back_comment):
3675 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3676 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3677 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3678 (Finternal_describe_syntax_value): Check that match_lisp is a
3679 character, not an integer, since the code stuffs it into int.
3680 (scan_words, scan_sexps_forward):
3681 Check that fixnums are in proper range for system types.
3683 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3684 (scan_sexps_forward):
3685 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3686 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3687 * syntax.h: Adjust decls to match defn changes elsewhere.
3688 (struct gl_state_s):
3689 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3690 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3691 MOST_POSITIVE_FIXNUM.
3692 * sysdep.c (wait_for_termination_1, wait_for_termination)
3693 (interruptible_wait_for_termination, mkdir):
3694 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3695 (emacs_read, emacs_write):
3696 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3697 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3698 and double all fit in int.
3699 * term.c (set_tty_color_mode):
3700 Check that fixnums are in proper range for system types.
3701 * termhooks.h (struct input_event):
3702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3703 * textprop.c (validate_interval_range, interval_of)
3704 (Fadd_text_properties, set_text_properties_1)
3705 (Fremove_text_properties, Fremove_list_of_text_properties)
3706 (Ftext_property_any, Ftext_property_not_all)
3707 (copy_text_properties, text_property_list, extend_property_ranges)
3708 (verify_interval_modification):
3709 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3710 (Fnext_single_char_property_change)
3711 (Fprevious_single_char_property_change):
3712 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3713 (copy_text_properties):
3714 Check for integer overflow in index calculation.
3715 * undo.c (last_boundary_position, record_point, record_insert)
3716 (record_delete, record_marker_adjustment, record_change)
3717 (record_property_change):
3718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3719 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3720 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3721 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3722 (Fx_hide_tip, Fx_file_dialog):
3723 * w32menu.c (set_frame_menubar):
3724 Use ptrdiff_t, not int, for consistency with rest of code.
3725 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3726 (select_window, Fdelete_other_windows_internal)
3727 (window_scroll_pixel_based, window_scroll_line_based)
3728 (Frecenter, Fset_window_configuration):
3729 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3730 (Fset_window_hscroll, run_window_configuration_change_hook)
3731 (set_window_buffer, temp_output_buffer_show, scroll_command)
3732 (Fscroll_other_window, Frecenter):
3733 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3734 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3735 Don't assume fixnum fits in int.
3736 (Fset_window_scroll_bars):
3737 Check that fixnums are in proper range for system types.
3738 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3739 (string_pos, c_string_pos, number_of_chars, init_iterator)
3740 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3741 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3742 (compute_display_string_end, handle_face_prop)
3743 (face_before_or_after_it_pos, handle_invisible_prop)
3744 (handle_display_prop, handle_display_spec, handle_single_display_spec)
3745 (display_prop_intangible_p, string_buffer_position_lim)
3746 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3747 (get_overlay_strings_1, get_overlay_strings)
3748 (iterate_out_of_display_property, forward_to_next_line_start)
3749 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3750 (get_next_display_element, set_iterator_to_next)
3751 (get_visually_first_element, compute_stop_pos_backwards)
3752 (handle_stop_backwards, next_element_from_buffer)
3753 (move_it_in_display_line_to, move_it_in_display_line)
3754 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3755 (add_to_log, message_dolog, message_log_check_duplicate)
3756 (message2, message2_nolog, message3, message3_nolog
3757 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3758 (current_message_1, truncate_echo_area, truncate_message_1)
3759 (set_message, set_message_1, store_mode_line_noprop)
3760 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3761 (text_outside_line_unchanged_p, check_point_in_composition)
3762 (reconsider_clip_changes)
3763 (redisplay_internal, set_cursor_from_row, try_scrolling)
3764 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3765 (redisplay_window, find_last_unchanged_at_beg_row)
3766 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3767 (trailing_whitespace_p, find_row_edges, display_line)
3768 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3769 (display_mode_element, store_mode_line_string)
3770 (pint2str, pint2hrstr, decode_mode_spec)
3771 (display_count_lines, display_string, draw_glyphs)
3772 (x_produce_glyphs, x_insert_glyphs)
3773 (rows_from_pos_range, mouse_face_from_buffer_pos)
3774 (fast_find_string_pos, mouse_face_from_string_pos)
3775 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3776 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3777 (safe_call, init_from_display_pos, handle_fontified_prop)
3778 (handle_single_display_spec, load_overlay_strings)
3779 (with_echo_area_buffer, setup_echo_area_for_printing)
3780 (display_echo_area, echo_area_display)
3781 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3782 (update_tool_bar, hscroll_window_tree, redisplay_internal)
3783 (redisplay_window, dump_glyph_row, display_mode_line)
3784 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
3785 (handle_display_spec, display_prop_string_p):
3786 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3787 (handle_single_display_spec, build_desired_tool_bar_string)
3788 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3789 (get_specified_cursor_type):
3790 Check that fixnums are in proper range for system types.
3791 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3792 (Flookup_image_map):
3793 Don't assume fixnums fit in int.
3794 (compare_overlay_entries):
3795 Avoid mishandling comparisons due to subtraction overflow.
3796 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3797 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3798 (handle_tool_bar_click):
3799 Use int, not unsigned, since we prefer signed and the signedness
3800 doesn't matter here.
3801 (get_next_display_element, next_element_from_display_vector):
3802 Use int, not EMACS_INT, when int is wide enough.
3803 (start_hourglass): Use duration_to_sec_usec to do proper
3804 overflow checking on durations.
3805 * xfaces.c (Fbitmap_spec_p):
3806 Check that fixnums are in proper range for system types.
3807 (compare_fonts_by_sort_order):
3808 Avoid mishandling comparisons due to subtraction overflow.
3809 (Fx_family_fonts, realize_basic_faces):
3810 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3812 Don't assume fixnum fits in int.
3813 Use SAFE_ALLOCA_LISP, not alloca.
3814 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3815 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3816 (face_at_buffer_position, face_for_overlay_string)
3817 (face_at_string_position):
3818 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3819 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3820 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3822 Check that fixnums are in proper range for system types.
3823 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3824 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3825 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3826 (Fx_change_window_property): Don't assume fixnums fit in int.
3827 * xfont.c (xfont_chars_supported):
3828 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3829 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3830 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3831 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3832 * xml.c (parse_region):
3833 * xrdb.c (magic_file_p):
3834 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3835 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3836 (x_get_local_selection, x_reply_selection_request)
3837 (x_handle_selection_request, wait_for_property_change):
3838 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3839 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3840 short is wide enough.
3841 (x_send_client_event): Don't assume fixnum fits in int.
3842 * xterm.c (x_x_to_emacs_modifiers):
3843 Don't assume EMACS_INT overflows nicely into int.
3844 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3846 (handle_one_xevent): NATNUMP can eval its arg twice.
3847 (x_connection_closed):
3848 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3849 * xterm.h: Adjust decls to match defn changes elsewhere.
3850 (struct scroll_bar): Use struct vectorlike_header
3851 rather than rolling our own approximation.
3852 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3854 2012-05-25 Glenn Morris <rgm@gnu.org>
3856 * lisp.mk (lisp): Update for more files being compiled now.
3858 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3860 * lread.c: Remove `read_pure' which makes no difference.
3861 (read_pure): Remove var.
3862 (unreadpure): Remove function.
3863 (readevalloop): Don't call read_list with -1 flag.
3864 (read1, read_vector): Don't test read_pure any more.
3865 (read_list): Simplify.
3867 * fileio.c, character.h: Minor style tweaks.
3869 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3871 * window.h (clip_changed): Remove useless declaration.
3873 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
3875 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3876 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3878 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3881 This directory predates autoconf and is no longer needed nowadays.
3882 Move its few remaining bits of functionality to where they're needed.
3883 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3884 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3885 * m/template.h: Remove.
3886 * Makefile.in (M_FILE): Remove. All uses removed.
3887 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3888 * lisp.h (USE_LSB_TAG):
3889 * mem-limits.h (EXCEEDS_LISP_PTR):
3890 Use VAL_MAX, not VALBITS, in #if.
3891 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3892 (EMACS_UINT): Define unconditionally now.
3893 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3894 (BITS_PER_EMACS_INT): New constants, replacing
3895 what used to be in config.h, but not useful in #if.
3896 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3897 define them any more.
3898 (VAL_MAX): New macro.
3900 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3901 BITS_PER_EMACS_INT, in #if.
3902 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3903 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3904 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3905 * s/ms-w32.h (DATA_START):
3906 Move here from removed file m/intel386.h.
3907 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3908 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3910 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3912 Assume C89 or later.
3913 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3914 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3916 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3917 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3918 * textprop.c, tparam.c (NULL): Remove.
3919 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3920 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3921 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3922 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3923 * xterm.c (input_signal_count): Assume volatile works.
3925 2012-05-21 Ken Brown <kbrown@cornell.edu>
3927 * xgselect.c (xg_select): Fix first argument in call to 'select'
3930 2012-05-20 Ken Brown <kbrown@cornell.edu>
3932 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
3933 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
3935 2012-05-19 Ken Brown <kbrown@cornell.edu>
3937 * xfns.c (x_in_use): Remove `static' qualifier.
3938 * xterm.h (x_in_use): Declare.
3939 * xgselect.c: Include xterm.h.
3940 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3941 and `display_arg' (bug#9754).
3943 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3945 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3947 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3948 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3950 2012-05-18 Eli Zaretskii <eliz@gnu.org>
3952 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3954 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
3955 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
3957 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3958 reference to image_cache->refcount.
3959 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3961 2012-05-17 Juri Linkov <juri@jurta.org>
3963 * search.c (Fword_search_regexp, Fword_search_backward)
3964 (Fword_search_forward, Fword_search_backward_lax)
3965 (Fword_search_forward_lax): Move functions to isearch.el
3966 (bug#10145, bug#11381).
3968 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3970 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3972 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3974 * lread.c (init_obarray): Declare Qt and Qnil as special.
3976 2012-05-14 Glenn Morris <rgm@gnu.org>
3978 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
3979 Put "libexec" before "bin", for the sake of init_callproc_1.
3981 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3983 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3985 * unexaix.c: Port to more-recent AIX compilers.
3986 (report_error, report_error_1, make_hdr, copy_sym)
3987 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3988 Make arguments const char *, not char *, to avoid violations of C
3989 standard and to fix some AIX warnings reported by Gilles Pion.
3991 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3993 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3994 already have overlays loaded.
3995 (handle_single_display_spec): Before returning without displaying
3996 fringe bitmap, synchronize the bidi iterator with the main display
3997 iterator, by calling iterate_out_of_display_property.
3998 (iterate_out_of_display_property): Detect buffer iteration by
3999 testing that it->string is a Lisp string.
4000 (get_next_display_element): When the current object is exhausted,
4001 and there's something on it->stack, call set_iterator_to_next to
4002 proceed with what's on the stack, instead of returning zero.
4003 (set_iterator_to_next): If called at the end of a Lisp string,
4004 proceed to consider_string_end without incrementing string
4005 position. Don't increment display vector index past the end of
4006 the display vector. (Bug#11417)
4007 (pos_visible_p): Don't report a position visible when move_it_to
4008 stopped at the last line of window, which happens to be scanned
4009 backwards by the bidi iteration. (Bug#11464)
4011 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4013 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4014 and right-margin display specs even if the spec is invalid or we
4015 are on a TTY, and thus unable to display on the fringes.
4016 That's because the text with the property will not be displayed anyway,
4017 so we need to signal to the caller that this is a "replacing"
4018 display spec. This fixes display when the spec is invalid or we
4021 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4023 * unexaix.c (make_hdr): Fix typo in prototype.
4024 This bug broke the build on AIX. Problem reported by Gilles Pion.
4026 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
4028 * keyboard.c (kbd_buffer_get_event): Read special events also in
4029 batch mode. (Bug#11415)
4031 2012-05-12 Glenn Morris <rgm@gnu.org>
4033 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4035 2012-05-12 Eli Zaretskii <eliz@gnu.org>
4037 * lisp.mk (lisp): Add newcomment.elc.
4039 2012-05-12 Glenn Morris <rgm@gnu.org>
4041 * Makefile.in (MKDIR_P): New, set by configure.
4042 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4044 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4046 Remove unused function hourglass_started.
4047 * dispextern.h (hourglass_started):
4048 * w32fns.c (hourglass_started):
4049 * xdisp.c (hourglass_started): Remove.
4051 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
4053 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4054 Update dependencies.
4056 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4058 * xgselect.c (xg_select): Put maxfds+1 into a var.
4059 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4061 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4063 2012-05-10 Dave Abrahams <dave@boostpro.com>
4065 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4066 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4068 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
4070 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4071 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4072 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4073 Initialize xd_registered_buses.
4075 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4077 Untag more efficiently if USE_LSB_TAG.
4078 This is based on a proposal by YAMAMOTO Mitsuharu in
4079 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4080 For an admittedly artificial (nth 8000 longlist) benchmark on
4081 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4082 Emacs's overall text size by 1%.
4083 * lisp.h (XUNTAG): New macro.
4084 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4085 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4086 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4087 * eval.c (Fautoload):
4088 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4089 * frame.h (XFRAME): Use XUNTAG.
4091 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4092 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4093 Remove unportable assumptions about print widths of types like
4095 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4096 intptr_t when converting between pointer and integer, to avoid GCC
4097 warnings about wrong width.
4099 2012-05-09 Eli Zaretskii <eliz@gnu.org>
4101 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4102 stack for each reader_thread, instead of defaulting to 8MB
4103 determined by the linker. This avoids failures in creating
4104 subprocesses on Windows 7, see the discussion in this thread:
4105 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4107 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4109 Fix up display of the *Minibuf-0* buffer in the mini window.
4110 * keyboard.c (read_char): Don't clear the echo area if there's no
4112 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
4113 contents of *Minibuf-0*) if there's no message displayed in its stead.
4115 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
4117 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4120 2012-05-06 Chong Yidong <cyd@gnu.org>
4122 * lisp.mk (lisp): Update.
4124 2012-05-05 Jim Meyering <meyering@redhat.com>
4126 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4128 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4130 * data.c (PUT_ERROR): New macro.
4131 (syms_of_data): Use it. Add new error type `user-error'.
4132 * undo.c (user_error): New function.
4133 (Fprimitive_undo): Use it.
4134 * print.c (print_error_message): Adjust print style for `user-error'.
4135 * keyboard.c (user_error): New function.
4136 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4138 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4140 Do not limit current-time-string to years 1000..9999.
4141 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4142 (Fcurrent_time_string): Support any year that is supported by the
4143 underlying localtime representation. Don't use asctime, as it
4144 has undefined behavior for years outside the range -999..9999.
4146 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4148 Fix race conditions involving setenv, gmtime, localtime, asctime.
4149 Without this fix, interrupts could mess up code that uses these
4150 nonreentrant functions, since setting TZ invalidates existing
4151 tm_zone or tzname values, and since most of these functions return
4152 pointers to static storage.
4153 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4154 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4155 Grow the critical sections to include not just invoking
4156 localtime/gmtime, but also accessing these functions' results
4157 including their tm_zone values if any, and any related TZ setting.
4158 (format_time_string): Last arg is now struct tm *, not struct tm **,
4159 so that the struct tm is saved in the critical section.
4160 All callers changed. Simplify allocation of initial buffer, partly
4161 motivated by the fact that memory allocation needs to be outside
4162 the critical section.
4164 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4166 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4167 with RESET_INTERVAL.
4169 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4170 Remove duplicated buffer name initialization.
4172 2012-05-02 Jim Meyering <jim@meyering.net>
4174 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4176 * xfns.c (x_window): Use xstrdup (Bug#11375).
4178 2012-05-02 Eli Zaretskii <eliz@gnu.org>
4180 * xdisp.c (pos_visible_p): If already at a newline from the
4181 display string before the 'while' loop, don't walk back the glyphs
4182 from it3.glyph_row. Solves assertion violation when the display
4183 string begins with a newline (egg.el). (Bug#11367)
4185 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4187 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4190 2012-05-01 Glenn Morris <rgm@gnu.org>
4192 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4193 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4194 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4195 All were removed before 23.1.
4197 * dispnew.c: Remove HAVE_LIBNCURSES test;
4198 it is always true on relevant platforms.
4200 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4201 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4203 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4205 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4207 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4208 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4211 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4213 Do not avoid creating empty evaporating overlays (Bug#9642).
4214 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4215 That is, do not delete an evaporating overlay if it becomes
4216 empty after its bounds are adjusted to fit within its buffer.
4217 This fix caused other problems, and I'm reverting it until we get
4218 to the bottom of them.
4220 2012-04-27 Chong Yidong <cyd@gnu.org>
4222 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4224 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4226 * xdisp.c (pos_visible_p): If the window start position is beyond
4227 ZV, start the display from buffer beginning. Prevents assertion
4228 violation in init_iterator when the minibuffer window is scrolled
4231 * window.c (window_scroll_pixel_based): Likewise.
4233 2012-04-27 Chong Yidong <cyd@gnu.org>
4235 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4237 2012-04-27 Glenn Morris <rgm@gnu.org>
4239 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4240 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4242 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4244 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4245 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
4247 2012-04-26 Eli Zaretskii <eliz@gnu.org>
4249 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4250 display element, check also the underlying string or buffer
4251 character. (Bug#11341)
4253 * w32menu.c: Include w32heap.h.
4254 (add_menu_item): If the call to AppendMenuW (via
4255 unicode_append_menu) fails, disable Unicode menus only if we are
4256 running on Windows 9X/Me.
4258 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4260 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4261 (xgetint): Add missing shift for LSB tags.
4263 2012-04-24 Martin Rudalics <rudalics@gmx.at>
4265 * keyboard.c (read_char): Don't wipe echo area for select window
4266 events: These might get delayed via `mouse-autoselect-window'
4269 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
4271 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4272 manipulation of :loaded-from data.
4274 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
4276 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4277 now a cons (bug#11311).
4279 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4281 Do not create empty overlays with the evaporate property (Bug#9642).
4282 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4283 if it becomes empty after its bounds are adjusted to fit within
4284 its buffer. Without this fix, in a nonempty buffer (let ((o
4285 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4286 yields an empty overlay that has the evaporate property, which is
4287 not supposed to happen.
4289 Fix minor GTK3 problems found by static checking.
4290 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4291 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4292 (struct _EmacsFixedClass, emacs_fixed_get_type):
4293 Move decls here from emacsgtkfixed.h, since they needn't be public.
4294 (emacs_fixed_get_type): Now static.
4295 (emacs_fixed_class_init): Omit unused local.
4296 (emacs_fixed_child_type): Remove; unused.
4297 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4298 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4299 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4300 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4301 (EMACS_FIXED_GET_CLASS): Remove; unused.
4302 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4304 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4305 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4307 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4309 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
4310 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
4311 (__malloc_size_t, __malloc_ptrdiff_t):
4312 Remove. All uses removed, replaced by the definiens if needed,
4313 since we can assume C89 or better now.
4314 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4315 (protect_malloc_state, align, get_contiguous_space)
4316 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4317 (malloc_atfork_handler_child, malloc_enable_thread)
4318 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4319 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4320 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4321 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4322 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4323 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4324 Define using prototypes, not old style.
4325 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4326 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4327 (align): Don't assume that signed integer overflow wraps around.
4328 Omit unused local var.
4329 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4330 (_free_internal_nolock, memalign, mallochook, reallochook):
4331 Omit no-longer-needed casts.
4332 (valloc): Use getpagesize, not __getpagesize.
4333 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4334 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4336 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4338 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
4340 Move functions from C to Lisp. Make non-blocking method calls
4341 the default. Implement further D-Bus standard interfaces.
4343 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4344 (QCdbus_request_name_allow_replacement)
4345 (QCdbus_request_name_replace_existing)
4346 (QCdbus_request_name_do_not_queue)
4347 (QCdbus_request_name_reply_primary_owner)
4348 (QCdbus_request_name_reply_in_queue)
4349 (QCdbus_request_name_reply_exists)
4350 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4351 (QCdbus_registered_serial, QCdbus_registered_method)
4352 (QCdbus_registered_signal): New Lisp objects.
4353 (XD_DEBUG_MESSAGE): Use sizeof.
4354 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4355 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4356 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4357 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4358 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4359 (xd_signature, xd_append_arg): Allow float for integer types.
4360 (xd_get_connection_references): New function.
4361 (xd_get_connection_address): Rename from xd_initialize.
4362 Return cached address.
4363 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4364 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4366 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
4367 Return number of refcounts.
4368 (Fdbus_get_unique_name): Make stronger parameter check.
4369 (Fdbus_message_internal): New defun.
4370 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4371 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4372 (Fdbus_send_signal, Fdbus_register_service)
4373 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4374 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4375 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4376 (Vdbus_compiled_version, Vdbus_runtime_version)
4377 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4378 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4379 (Vdbus_message_type_signal): New defvars.
4380 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4383 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4385 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4386 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4387 Do not assume ptrdiff_t is the same width as 'int'.
4389 * alloc.c: Handle unusual debugging option combinations.
4390 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4391 since the two debugging options are incompatible.
4392 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4394 (mem_init, mem_insert, mem_insert_fixup):
4395 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4396 (NEED_MEM_INSERT): Remove; no longer needed.
4398 2012-04-22 Leo Liu <sdl.web@gmail.com>
4400 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4402 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4404 * sysdep.c [__FreeBSD__]: Minor cleanups.
4405 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4406 Use Emacs indenting style more consistently. Avoid some casts.
4407 Use 'double' consistently rather than mixing 'float' and 'double'.
4409 2012-04-21 Eduard Wiebe <usenet@pusto.de>
4411 * sysdep.c (list_system_processes, system_process_attributes):
4412 Add implementation for FreeBSD (Bug#5243).
4414 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4416 * lisp.mk (lisp): Update.
4418 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4420 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4421 It is never used otherwise.
4423 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4425 * print.c (print_preprocess): Only check print_depth if print-circle
4427 (print_object): Check for cycles even when print-circle is nil and
4428 print-gensym is t, but only check print_depth if print-circle is nil.
4430 2012-04-20 Chong Yidong <cyd@gnu.org>
4432 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4433 set the status to "failed" and ensure that sentinel is run.
4435 2012-04-20 Glenn Morris <rgm@gnu.org>
4437 * process.c (Fset_process_inherit_coding_system_flag)
4438 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4439 (Fmake_network_process, Fmake_serial_process): Doc fix.
4441 2012-04-20 Eli Zaretskii <eliz@gnu.org>
4443 * xdisp.c (string_buffer_position_lim): Limit starting position to
4445 (set_cursor_from_row): If called for a mode-line or header-line
4446 row, return zero immediately.
4447 (try_cursor_movement): If inside continuation line, don't back up
4448 farther than the first row after the header line, if any.
4449 Don't consider the header-line row as "partially visible", even if
4450 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4452 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4454 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4457 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
4458 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
4460 configure: new option --enable-gcc-warnings (Bug#11207)
4461 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4462 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4463 (ALL_CFLAGS): Use new macros rather than old.
4464 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4465 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4466 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4467 -Wunused-result, -Wunused-variable. This should go away once
4468 the Emacs and Gnulib regex code is merged.
4469 (xmalloc, xrealloc): Now static.
4471 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4473 * dired.c (Fsystem_groups): Remove unused local.
4475 2012-04-17 Glenn Morris <rgm@gnu.org>
4477 * dired.c (Fsystem_users): Doc fix.
4479 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4481 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4482 (syms_of_dired): Add them.
4484 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4486 Fix minor alloc.c problems found by static checking.
4487 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4488 New extern decls, to avoid calling undeclared functions.
4489 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4490 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4491 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4492 (NEED_MEM_INSERT): New macro.
4493 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4494 Remove one incorrect comment and fix another.
4496 Fix minor ralloc.c problems found by static checking.
4497 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4498 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4499 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4500 (r_alloc_sbrk): Now static.
4502 Improve ralloc.c interface checking.
4503 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4504 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4505 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4506 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4507 [REL_ALLOC]: ... to here, to check interface.
4508 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4509 Remove decls. This fixes an "It stinks!".
4511 * alloc.c (which_symbols): Fix alignment issue / type clash.
4513 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4515 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4516 (struct Lisp_Misc_Any): Likewise.
4517 (struct Lisp_Free): Likewise.
4518 * alloc.c (union aligned_Lisp_Symbol): Define.
4519 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4520 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4521 (union aligned_Lisp_Misc): Define.
4522 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4523 aligned_Lisp_Misc instead of union Lisp_Misc.
4524 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
4526 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4528 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4529 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4530 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4531 * s/netbsd.h, s/sol2-6.h:
4532 Remove definition of GC_MARK_STACK, since the default now works.
4533 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4534 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4535 no longer the default.
4536 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4538 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4540 * lread.c (lisp_file_lexically_bound_p):
4541 Fix hang at ";-*-\n" (bug#11238).
4543 2012-04-14 Eli Zaretskii <eliz@gnu.org>
4545 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4546 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4548 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4550 * nsterm.m (constrainFrameRect): Always constrain when there is only
4551 one screen (Bug#10962).
4553 2012-04-13 Ken Brown <kbrown@cornell.edu>
4555 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4557 2012-04-13 Reuben Thomas <rrt@sc3d.org>
4559 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4561 2012-04-11 Daniel Colascione <dancol@dancol.org>
4563 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4564 against is gone. It's better to use vfork now so that when Cygwin
4565 gains a new, working vfork, we use it automatically (bug#10398).
4567 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4569 * window.c (save_window_save): Obey window-point-insertion-type.
4571 2012-04-11 Glenn Morris <rgm@gnu.org>
4573 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4575 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4577 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4579 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
4581 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4582 (force_quit_count): New var.
4583 (handle_interrupt): Use it.
4585 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
4587 * w32.c (w32_delayed_load): Record the full path of the library
4588 being loaded (bug#10424).
4590 2012-04-09 Glenn Morris <rgm@gnu.org>
4592 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4593 not just in the obarray, before snarfing them. (Bug#11036)
4595 * Makefile.in ($(leimdir)/leim-list.el):
4596 Pass EMACS rather than BUILT_EMACS.
4598 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4600 * process.c (make_process):
4601 * process.h: Add integer `gnutls_handshakes_tried' member to
4604 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4605 Add convenience `GNUTLS_LOG2i' macro.
4607 * gnutls.c (gnutls_log_function2i): Convenience log function.
4608 (emacs_gnutls_read): Use new log functions,
4609 `gnutls_handshakes_tried' process member, and
4610 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4611 attempts per process (connection).
4613 2012-04-09 Chong Yidong <cyd@gnu.org>
4615 * eval.c (Fuser_variable_p, user_variable_p_eh)
4616 (lisp_indirect_variable): Functions deleted.
4617 (Fdefvar): Caller changed.
4619 * callint.c (Finteractive, Fcall_interactively):
4620 * minibuf.c (Fread_variable): Callers changed.
4622 2012-04-09 Eli Zaretskii <eliz@gnu.org>
4624 * xdisp.c (set_cursor_from_row): If the display string appears in
4625 the buffer at position that is closer to point than the position
4626 after the display string, display the cursor on the first glyph of
4627 the display string. Fixes cursor display when a 'display' text
4628 property immediately follows invisible text. (Bug#11094)
4630 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4632 composite.c: use 'double' consistently
4633 * composite.c (get_composition_id): Use 'double' consistently
4634 instead of converting 'float' to 'double' and vice versa; this is
4635 easier to understand and avoids a GCC warning.
4637 2012-04-09 Glenn Morris <rgm@gnu.org>
4639 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4640 preparation for dumping it with emacs. (Bug#4789)
4641 (leimdir): New variable.
4642 ($(leimdir)/leim-list.el): New rule.
4643 (emacs$(EXEEXT)): Depend on leim-list.el.
4645 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4646 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4647 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4649 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4651 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4654 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
4656 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4657 Remove unused local variable.
4659 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4661 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4662 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4663 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4664 objects, as mark_maybe_pointer will catch them otherwise.
4665 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4666 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4668 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4670 Fix typo that broke non-Windows builds.
4671 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4673 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4675 Support building on MS-Windows with libxml2.
4677 * makefile.w32-in (OBJ2): Add xml.$(O).
4678 (GLOBAL_SOURCES): Add xml.c.
4679 ($(BLD)/xml.$(O)): New dependency list.
4681 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4682 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4683 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4684 [!WINDOWSNT]: New macros.
4685 (init_libxml2_functions, libxml2_loaded_p): New functions.
4686 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4687 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4688 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4689 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4691 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4692 Call init_libxml2_functions before calling libxml2 functions.
4693 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4695 * emacs.c: Don't include libxml/parser.h.
4696 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4697 xmlCleanupParser directly.
4699 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4701 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4703 * indent.c (Fvertical_motion): If there is a display string at
4704 point, use it.vpos to compute how many lines to backtrack after
4705 move_it_to point. (Bug#11133)
4707 2012-04-06 Eli Zaretskii <eliz@gnu.org>
4709 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4710 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4711 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4712 macros related to unification of CJK characters. For the details,
4713 see the discussion following the message here:
4714 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4716 2012-04-04 Chong Yidong <cyd@gnu.org>
4718 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4720 2012-04-01 Eli Zaretskii <eliz@gnu.org>
4722 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4723 instead of alloca. (Bug#11138)
4725 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4727 * w32menu.c (is_simple_dialog): Properly check lisp types.
4730 2012-03-31 Eli Zaretskii <eliz@gnu.org>
4732 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4733 position we get to after a call to move_it_to fails the
4734 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4735 only if we wind up in a string from display property. (Bug#11063)
4737 * window.c (Fdelete_other_windows_internal): Invalidate the row
4738 and column information about mouse highlight, so that redisplay
4739 restores it after reallocating the glyph matrices. (Bug#7464)
4741 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4742 string comes from a `display' text property, use the buffer
4743 position of that property as if we actually saw that position in
4745 (move_it_by_lines): Remove the assertion that
4746 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4747 violated when there's a before-string at the beginning of a line.
4750 2012-03-30 Eli Zaretskii <eliz@gnu.org>
4752 * xdisp.c (append_space_for_newline): If the default face was
4753 remapped, use the remapped face for the appended newline.
4754 (extend_face_to_end_of_line): Use the remapped default face for
4755 extending the face to the end of the line.
4756 (display_line): Call extend_face_to_end_of_line when the default
4757 face was remapped. (Bug#11068)
4759 2012-03-29 Eli Zaretskii <eliz@gnu.org>
4761 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4763 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4765 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4767 2012-03-27 Glenn Morris <rgm@gnu.org>
4769 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4772 2012-03-26 Kenichi Handa <handa@m17n.org>
4774 * dispextern.h (struct glyph): Fix previous change. Change the
4775 bit length of glyphless.ch to 25 (Bug#11082).
4777 2012-03-26 Chong Yidong <cyd@gnu.org>
4779 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4780 (command_loop_1): Use it; inhibit selection update for
4781 handle-select-window too (Bug#8996).
4783 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4785 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
4787 2012-03-25 Kenichi Handa <handa@m17n.org>
4789 * dispextern.h (struct glyph): Change the bit length of
4790 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4792 2012-03-24 Eli Zaretskii <eliz@gnu.org>
4794 * s/ms-w32.h (tzname): Include time.h before redirecting to
4795 _tzname. Fixes the MSVC build. (Bug#9960)
4797 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4799 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4802 * xterm.c (XTread_socket): Only modify handling_signal if
4803 !SYNC_INPUT. (Bug#11080)
4805 2012-03-23 Eli Zaretskii <eliz@gnu.org>
4807 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4808 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4809 when fetching a multibyte character consumes more bytes than
4810 CHAR_BYTES returns, due to unification of CJK characters in
4811 string_char. (Bug#11073)
4813 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4815 * process.c (wait_reading_process_output): Handle pty disconnect
4816 by refraining from sending oneself a SIGCHLD (bug#10933).
4818 2012-03-22 Chong Yidong <cyd@gnu.org>
4820 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4822 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
4823 Mark string as coming from a prefix property.
4824 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4825 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4827 2012-03-21 Chong Yidong <cyd@gnu.org>
4829 * xfaces.c (Vface_remapping_alist): Doc fix.
4831 2012-03-20 Eli Zaretskii <eliz@gnu.org>
4833 * w32proc.c (Fw32_set_console_codepage)
4834 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4837 2012-03-20 Chong Yidong <cyd@gnu.org>
4839 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4840 to reflect default non-nil value of redisplay-dont-pause.
4842 2012-03-19 Kenichi Handa <handa@m17n.org>
4844 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4845 it fit in a valid range (Bug#11003).
4847 2012-03-18 Eli Zaretskii <eliz@gnu.org>
4849 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4850 that is not from display property, accept the row as a "cursor
4851 row" if one of the string's character has a non-nil `cursor'
4852 property. Fixes cursor positioning when there are newlines in
4853 overlay strings, e.g. in icomplete.el. (Bug#11035)
4855 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4857 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4859 2012-03-12 Chong Yidong <cyd@gnu.org>
4861 * eval.c (inhibit_lisp_code): Rename from
4862 inhibit_window_configuration_change_hook; move from window.c.
4864 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4865 * window.c (run_window_configuration_change_hook)
4866 (syms_of_window): Callers changed.
4868 2012-03-11 Chong Yidong <cyd@gnu.org>
4870 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4872 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4874 2012-03-10 Chong Yidong <cyd@gnu.org>
4876 * frame.c (other_visible_frames): Don't assume the selected frame
4877 is visible (Bug#10955).
4879 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4881 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4883 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4885 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4886 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4889 2012-03-03 Glenn Morris <rgm@gnu.org>
4891 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
4893 2012-03-02 Eli Zaretskii <eliz@gnu.org>
4895 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4896 position past the first glyph_row that ends at ZV. (Bug#10902)
4897 (redisplay_window, next_element_from_string): Fix typos in
4899 (redisplay_window): Pass to move_it_vertically the margin in
4900 pixels, not in screen lines.
4902 2012-03-02 Glenn Morris <rgm@gnu.org>
4904 * buffer.c (buffer-list-update-hook): Doc fix.
4906 2012-02-29 Eli Zaretskii <eliz@gnu.org>
4908 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4909 push_it before setting up the iterator for the first overlay
4910 string, even if we have an empty string loaded.
4911 (next_overlay_string): If there's an empty string on the iterator
4912 stack, pop the stack. (Bug#10903)
4914 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4916 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4917 Suggested by Stefan Monnier in
4918 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4919 * alloc.c (widen_to_Lisp_Object): New static function.
4920 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4921 and widening them to Lisp_Objects. This would work even if
4922 USE_LSB_TAG is defined and wide integers are used, which might
4923 happen in a future version of Emacs.
4925 2012-02-25 Chong Yidong <cyd@gnu.org>
4927 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4930 * xselect.c (Fx_selection_exists_p): Doc fix.
4931 (x_clipboard_manager_save_all): Print an informative message
4932 before saving to clipboard manager.
4934 2012-02-24 Chong Yidong <cyd@gnu.org>
4936 * keyboard.c (process_special_events): Handle all X selection
4937 requests in kbd_buffer, not just the next one (Bug#8869).
4939 2012-02-23 Chong Yidong <cyd@gnu.org>
4941 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4942 call when setting menu-bar-lines and tool-bar-lines parameters.
4943 (unwind_create_frame_1): New helper function.
4945 * window.c (inhibit_window_configuration_change_hook): New var.
4946 (run_window_configuration_change_hook): Obey it.
4947 (syms_of_window): Initialize it.
4949 2012-02-22 Chong Yidong <cyd@gnu.org>
4951 * xterm.c (x_draw_image_relief): Add missing type check for
4952 Vtool_bar_button_margin (Bug#10743).
4954 2012-02-21 Chong Yidong <cyd@gnu.org>
4956 * fileio.c (Vfile_name_handler_alist): Doc fix.
4958 * buffer.c (Fget_file_buffer): Protect against invalid file
4959 handler return value.
4961 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4963 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4964 when computing $valmask.
4966 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4967 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4968 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4969 It's useless in that case, and it can cause problems on hosts
4970 that allocate halves of EMACS_INT values separately.
4971 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4972 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4973 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4974 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4975 it avoids undefined behavior on hosts where shifting right by more
4976 than the word width has undefined behavior.
4978 2012-02-19 Chong Yidong <cyd@gnu.org>
4980 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4981 (Funhandled_file_name_directory, Ffile_name_as_directory)
4982 (Fdirectory_file_name, Fexpand_file_name)
4983 (Fsubstitute_in_file_name): Protect against invalid file handler
4984 return values (Bug#10845).
4986 2012-02-18 Eli Zaretskii <eliz@gnu.org>
4988 * .gdbinit (pitx): Fix incorrect references to fields of the
4991 2012-02-17 Chong Yidong <cyd@gnu.org>
4993 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4995 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4997 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4998 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5000 2012-02-15 Chong Yidong <cyd@gnu.org>
5002 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5003 marked as special. Also, starting docstrings with * is obsolete.
5005 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5007 * gnutls.c (emacs_gnutls_write): Fix last change.
5009 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5011 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5014 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5016 * keymap.c (Fsingle_key_description): Handle char ranges.
5018 2012-02-12 Chong Yidong <cyd@gnu.org>
5020 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5021 as that creates a dangerous corner case.
5023 * window.c (Fdelete_window_internal): Invalidate the mouse
5024 highlight (Bug#9904).
5026 2012-02-12 Glenn Morris <rgm@gnu.org>
5028 * xselect.c (Fx_own_selection_internal)
5029 (Fx_get_selection_internal, Fx_disown_selection_internal)
5030 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5031 * nsselect.m (Fx_own_selection_internal)
5032 (Fx_disown_selection_internal, Fx_selection_exists_p)
5033 (Fx_selection_owner_p, Fx_get_selection_internal):
5034 Sync docs and argument specs with the xselect.c versions.
5036 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5038 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5040 2012-02-11 Eli Zaretskii <eliz@gnu.org>
5042 * w32select.c (Fx_selection_exists_p): Sync doc string and
5043 argument list with xselect.c. (Bug#10783)
5045 * w16select.c (Fx_selection_exists_p): Sync doc string and
5046 argument list with xselect.c. (Bug#10783)
5048 2012-02-10 Glenn Morris <rgm@gnu.org>
5050 * fns.c (Fsecure_hash): Doc fix.
5052 2012-02-09 Kenichi Handa <handa@m17n.org>
5054 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5056 2012-02-07 Chong Yidong <cyd@gnu.org>
5058 * buffer.c (Fbuffer_local_variables)
5059 (buffer_lisp_local_variables): Handle unbound vars correctly;
5060 don't let Qunbound leak into Lisp.
5062 2012-02-07 Glenn Morris <rgm@gnu.org>
5064 * image.c (Fimagemagick_types): Doc fix.
5066 * image.c (imagemagick-render-type): Change it from a lisp object
5067 to an integer. Move the doc here from the lisp manual.
5068 Treat all values not equal to 0 the same.
5070 2012-02-06 Chong Yidong <cyd@gnu.org>
5072 * doc.c (store_function_docstring): Avoid applying docstring of
5073 alias to base function (Bug#2603).
5075 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5077 * .gdbinit (pp1, pv1): Remove redundant defines.
5080 2012-02-04 Chong Yidong <cyd@gnu.org>
5082 * nsterm.m: Declare a global (Bug#10694).
5084 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5086 * w32.c (get_emacs_configuration_options):
5087 Include --enable-checking, if specified, in the return value.
5089 2012-02-04 Martin Rudalics <rudalics@gmx.at>
5091 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5092 after rounding frame sizes. (Bug#9723)
5094 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5096 * keyboard.c (adjust_point_for_property): Don't position point
5097 before BEGV. (Bug#10696)
5099 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5101 Handle overflow when computing char display width (Bug#9496).
5102 * character.c (char_width): Return EMACS_INT, not int.
5103 (char_width, c_string_width): Check for overflow when
5104 computing the width; this is possible now that individual
5105 characters can have unbounded width. Problem introduced
5106 by merge from Emacs 23 on 2012-01-19.
5108 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
5110 * dbusbind.c (Fdbus_register_method): Mention the return value
5111 :ignore in the docstring.
5113 2012-02-02 Glenn Morris <rgm@gnu.org>
5115 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5117 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5118 Unconditionally set to t. (Bug#10673)
5119 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5120 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5121 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5123 2012-02-02 Kenichi Handa <handa@m17n.org>
5125 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5126 0, do not call append_composite_glyph.
5128 2012-02-02 Kenichi Handa <handa@m17n.org>
5130 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5132 (x_produce_glyphs): If the component of a composition is a null
5133 string, set it->pixel_width to 1 to avoid zero-width glyph.
5135 2012-02-01 Eli Zaretskii <eliz@gnu.org>
5137 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5138 first 2 arguments are identical. This makes inserting large
5139 output from a subprocess an order of magnitude faster on
5140 MS-Windows, where all sbrk'ed memory is always contiguous.
5142 2012-01-31 Glenn Morris <rgm@gnu.org>
5144 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5145 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5146 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5148 2012-01-29 Glenn Morris <rgm@gnu.org>
5150 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5152 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5154 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5156 2012-01-28 Chong Yidong <cyd@gnu.org>
5158 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5160 2012-01-26 Chong Yidong <cyd@gnu.org>
5162 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5164 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5165 repeat counts (Bug#10507).
5167 2012-01-26 Glenn Morris <rgm@gnu.org>
5169 * lread.c (syms_of_lread): Doc fix.
5171 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5173 * coding.c (encode_designation_at_bol): Change return value to
5176 2012-01-25 Chong Yidong <cyd@gnu.org>
5178 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5180 2012-01-21 Chong Yidong <cyd@gnu.org>
5182 * floatfns.c (Fcopysign): Make the second argument non-optional,
5183 since nil is not allowed anyway.
5185 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5187 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5188 (send_process): Likewise.
5190 2012-01-19 Martin Rudalics <rudalics@gmx.at>
5192 * window.c (save_window_save, Fcurrent_window_configuration)
5193 (Vwindow_persistent_parameters): Do not use Qstate.
5194 Rewrite doc-strings.
5196 2012-01-19 Kenichi Handa <handa@m17n.org>
5198 * character.c (char_width): New function.
5199 (Fchar_width, c_string_width, lisp_string_width):
5200 Use char_width (Bug#9496).
5202 2012-01-16 Martin Rudalics <rudalics@gmx.at>
5204 * window.c (Vwindow_persistent_parameters): New variable.
5205 (Fset_window_configuration, save_window_save): Handle persistent
5208 2012-01-14 Eli Zaretskii <eliz@gnu.org>
5210 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5211 thrashing the stack of the thread. (Bug#9087)
5213 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5215 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5217 2012-01-11 Eli Zaretskii <eliz@gnu.org>
5219 * xdisp.c (rows_from_pos_range): Handle the case where the
5220 highlight ends on a newline. (Bug#10464)
5221 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5222 he end column for display of highlight that ends on a newline
5225 2012-01-11 Glenn Morris <rgm@gnu.org>
5227 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5228 from load-path also when installation-directory is nil. (Bug#10208)
5230 2012-01-10 Glenn Morris <rgm@gnu.org>
5232 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5234 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5235 Update template values to be closer to their typical values these days.
5237 2012-01-09 Eli Zaretskii <eliz@gnu.org>
5239 * xdisp.c (rows_from_pos_range): Accept additional argument
5240 DISP_STRING, and accept any glyph in a row whose object is that
5241 string as eligible for mouse highlight. Fixes mouse highlight of
5242 display strings from overlays. (Bug#10464)
5244 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
5246 emacs: fix an auto-save permissions race condition (Bug#10400)
5247 * fileio.c (auto_saving_dir_umask): New static var.
5248 (Fmake_directory_internal): Use it.
5249 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5250 creating the directory. The old code temporarily assigns
5251 too-generous permissions to the directory.
5252 (do_auto_save_eh): Clear it.
5253 (Fdo_auto_save): Catch all errors, not just file errors, so
5254 that the var is always cleared.
5256 2012-01-07 Eli Zaretskii <eliz@gnu.org>
5258 * search.c (scan_buffer): Pass character positions to
5259 know_region_cache, not byte positions. (Bug#6540)
5261 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
5263 * w32.c (sys_rename): Report EXDEV when rename of a directory
5264 fails because the target is on another logical disk. (Bug#10284)
5266 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5268 * xterm.c (x_embed_request_focus): New function.
5270 * xterm.h: Add prototype.
5272 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5274 2012-01-05 Glenn Morris <rgm@gnu.org>
5276 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5278 2012-01-01 Eli Zaretskii <eliz@gnu.org>
5280 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5281 Load gnutls_transport_set_lowat only if GnuTLS version is below
5283 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5284 GnuTLS versions below 2.11.1.
5286 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5288 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5289 to the doc string advising against its use for altering the way
5290 windows are scrolled.
5292 2011-12-28 Kenichi Handa <handa@m17n.org>
5294 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5295 coding-system ASCII compatible only when it does not produce BOM
5296 on encoding (Bug#10383).
5298 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5300 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5302 (create_and_show_popup_menu): Always use menu_position_func for
5305 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5307 * callint.c (Fcall_interactively): Don't truncate prompt string.
5309 2011-12-23 Eli Zaretskii <eliz@gnu.org>
5311 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5312 property that ends at ZV, so that the bidi iteration could be
5313 resumed from there (after widening). (Bug#10360)
5315 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5317 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5319 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5321 * nsterm.m (x_free_frame_resources):
5322 Release f->output_data.ns->miniimage.
5323 (ns_index_color): Fix indentation. Do not retain
5324 color_table->colors[i].
5326 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5329 * nsfns.m (x_set_background_color): Assign return value from
5330 ns_index_color to face-background instead of NSColor*.
5331 (ns_implicitly_set_icon_type): Fix indentation.
5332 Change assignment in for loop to comparison.
5334 * emacs.c (ns_pool): New variable.
5335 (main): Assign ns_pool.
5336 (Fkill_emacs): Call ns_release_autorelease_pool.
5338 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5339 autorelease fdesc, release fdAttrs and tdict.
5340 (ns_get_covering_families): Release charset.
5341 (ns_findfonts): Release NSFontDescriptor created with new.
5342 (ns_uni_to_glyphs): Fix indentation.
5343 (setString): Release attrStr before assigning new value.
5345 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5347 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5349 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5350 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5352 2011-12-18 David Reitter <reitter@cmu.edu>
5354 * nsterm.m (ns_term_init): Subscribe for notifications
5355 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5356 to method trackingNotification in EmacsMenu.
5358 * nsmenu.m (trackingMenu): New variable.
5359 (trackingNotification): New method (from Aquamacs).
5360 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
5361 from Aquamacs (Bug#7030).
5363 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5365 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5366 (symbol_to_nsstring): Fix indentation.
5367 (ns_symbol_to_pb): New function.
5368 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5369 (Fns_rotate_cut_buffers_internal): Remove.
5370 (Fns_store_selection_internal): Rename from
5371 Fns_store_cut_buffer_internal.
5372 (ns_get_foreign_selection, Fx_own_selection_internal)
5373 (Fx_disown_selection_internal, Fx_selection_exists_p)
5374 (Fns_get_selection_internal, Fns_store_selection_internal):
5375 Use ns_symbol_to_pb and check if return value is nil.
5376 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5377 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
5378 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5379 renamed to Sns_store_selection_internal.
5380 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5381 and remove this function.
5382 (ns_handle_selection_clear): Remove, never used.
5383 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5386 2011-12-17 Ken Brown <kbrown@cornell.edu>
5388 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5389 GID is unknown (Bug#10257).
5391 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5393 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5394 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5395 which caused a build failure on GNU/Linux IA-64. This problem was
5396 introduced by my 2011-10-07 patch.
5398 2011-12-15 Juri Linkov <juri@jurta.org>
5400 * image.c (imagemagick_error): New function. (Bug#10112)
5401 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5402 Use `imagemagick_error' where ImageMagick functions return
5404 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5407 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5409 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5410 fill background (Bug#8992).
5412 2011-12-13 Martin Rudalics <rudalics@gmx.at>
5414 * window.c (Vwindow_combination_resize)
5415 (Vwindow_combination_limit): Use t instead of non-nil in
5417 (Vrecenter_redisplay): Add first sentence of doc-string on
5419 (Frecenter): Fix doc-string typo.
5421 2011-12-11 Kenichi Handa <handa@m17n.org>
5423 * coding.c (Funencodable_char_position): Pay attention to the
5424 buffer text relocation (Bug#9389).
5426 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5428 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5429 gtk_init (Bug#10100).
5431 2011-12-10 Eli Zaretskii <eliz@gnu.org>
5433 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5434 IT->string is nil. (Bug#10263)
5436 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5438 * nsterm.h (x_free_frame_resources): Declare.
5440 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5441 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5443 * nsterm.h (ns_get_defaults_value): Declare.
5445 * nsterm.m (ns_default): Call ns_get_defaults_value.
5447 2011-12-09 Eli Zaretskii <eliz@gnu.org>
5449 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5452 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5454 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5455 that where the value of an _OBJC_* symbol points to is in the .bss
5456 section (Bug#10240).
5458 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5460 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
5461 after the loop to call ccl_driver at least once (Bug#8619).
5463 2011-12-08 Kenichi Handa <handa@m17n.org>
5465 * ftfont.c (get_adstyle_property): Fix previous change
5468 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
5470 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5471 dirs from the default value of EMACSLOADPATH (bug#10208).
5473 2011-12-07 Glenn Morris <rgm@gnu.org>
5475 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5476 installation and source directories as well. (Bug#10208)
5478 2011-12-06 Chong Yidong <cyd@gnu.org>
5480 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5482 2011-12-06 Glenn Morris <rgm@gnu.org>
5484 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5485 as an error, not just -1. (Bug#10217)
5487 2011-12-05 Chong Yidong <cyd@gnu.org>
5489 * keyboard.c (process_special_events): New function.
5490 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5492 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5494 * coding.c (encode_designation_at_bol): Don't use uninitialized
5495 local variable (Bug#9318).
5497 2011-12-05 Kenichi Handa <handa@m17n.org>
5499 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5500 return Qnil (Bug#8046, Bug#10193).
5502 2011-12-05 Kenichi Handa <handa@m17n.org>
5504 * coding.c (encode_designation_at_bol): New args charbuf_end and
5505 dst. Return the number of produced bytes. Callers changed.
5506 (coding_set_source): Return how many bytes coding->source was
5508 (coding_set_destination): Return how many bytes
5509 coding->destination was relocated.
5510 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
5511 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5513 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5515 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5516 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5519 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5521 The following changes are to fix Bug#9318.
5523 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5524 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5525 (encode_coding_iso_2022, encode_coding_sjis)
5526 (encode_coding_big5, encode_coding_charset): Use the above macros.
5528 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
5530 * lisp.h (process_quit_flag): Fix external declaration.
5532 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5534 Don't macro-inline non-performance-critical code.
5535 * eval.c (process_quit_flag): New function.
5536 * lisp.h (QUIT): Use it.
5538 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5540 * nsfns.m (get_geometry_from_preferences): New function.
5541 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5543 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5545 * emacs.c (Qkill_emacs): Define.
5546 (syms_of_emacs): Initialize it.
5547 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5548 Qquit_flag to `kill-emacs' instead.
5549 (quit_throw_to_read_char): Add parameter `from_signal'.
5550 All callers changed. Call Fkill_emacs if requested and safe.
5551 * lisp.h (QUIT): Call Fkill_emacs if requested.
5553 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5555 * widget.c (update_wm_hints): Return if wmshell is null.
5556 (widget_update_wm_size_hints): New function.
5558 * widget.h (widget_update_wm_size_hints): Declare.
5560 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5561 widget_update_wm_size_hints (Bug#10104).
5563 2011-12-03 Eli Zaretskii <eliz@gnu.org>
5565 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5566 before a newline, prepare the bidi iterator for consuming the
5567 newline, and keep the current paragraph direction. (Bug#10183)
5568 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
5570 2011-12-02 Juri Linkov <juri@jurta.org>
5572 * search.c (Fword_search_regexp): New Lisp function created from
5573 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5574 (Fword_search_backward, Fword_search_forward)
5575 (Fword_search_backward_lax, Fword_search_forward_lax):
5576 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5577 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5579 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5581 * fileio.c (Finsert_file_contents): Move after-change-function call
5582 to before the "handled:" label, since all "goto handled" appear in
5583 cases where the *-change-functions have already been properly called
5586 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5588 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5589 waiting for input. (Bug#10169)
5591 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5593 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5594 verifies glyph row's hash code--we have just reallocated the
5595 glyphs, so their contents can be complete garbage. (Bug#10164)
5597 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
5599 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5601 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5603 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5604 attributes are tested _before_ calling verify_row_hash, to protect
5605 against GCC re-ordering of the tests. (Bug#10164)
5607 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5609 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5611 * xterm.c (handle_one_xevent): Only set async_visible and friends
5612 if net_wm_state_hidden_seen is non-zero (Bug#10002)
5613 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
5614 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5616 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5618 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5619 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5620 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5621 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5622 All uses changed to use GCPRO1 etc.
5623 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5624 Revert to old implementation (i.e., before 2011-03-11).
5626 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5628 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5629 of scroll runs so as to avoid assigning disabled bogus rows and
5630 unnecessary graphics copy operations.
5632 2011-11-27 Eli Zaretskii <eliz@gnu.org>
5634 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5635 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5636 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5637 (malloc, free, realloc, calloc): Redirect to e_* only when
5640 * lisp.h (GCTYPEBITS): Move before first use.
5641 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5642 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5643 this macro definition.
5645 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5648 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5650 * gtkutil.c (xg_create_frame_widgets):
5651 Call gtk_window_set_has_resize_grip (FALSE) if that function is
5652 present with Gtk+ 2.0.
5654 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5656 * fileio.c (Finsert_file_contents): Undo previous change; see
5657 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5659 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5661 Rename locals to avoid shadowing.
5662 * fileio.c (Finsert_file_contents):
5663 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5664 * process.c (wait_reading_process_output):
5665 Rename inner 'proc' to 'p' to avoid shadowing.
5666 Indent for consistency with usual Emacs style.
5668 2011-11-25 Eli Zaretskii <eliz@gnu.org>
5670 * xdisp.c (redisplay_window): If cursor row is not fully visible
5671 after recentering, and scroll-conservatively is set to a large
5672 number, scroll window by a few more lines to make the cursor fully
5673 visible and out of scroll-margin. (Bug#10105)
5674 (start_display): Don't move to the next line if the display should
5675 start at a newline that is part of a display vector or an overlay
5678 2011-11-24 Juri Linkov <juri@jurta.org>
5680 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5681 after the `MagickPingImage' call. (Bug#10112)
5683 2011-11-23 Chong Yidong <cyd@gnu.org>
5685 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5687 2011-11-23 Martin Rudalics <rudalics@gmx.at>
5689 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5690 making another buffer current. (Bug#10114)
5692 2011-11-23 Glenn Morris <rgm@gnu.org>
5694 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5696 2011-11-23 Chong Yidong <cyd@gnu.org>
5698 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5699 using it (Bug#5984).
5701 2011-11-22 Eli Zaretskii <eliz@gnu.org>
5703 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5704 and header-lines, as they don't have one computed for them.
5707 * .gdbinit (prow): Make displayed values more self-explaining.
5708 Add row's hash code.
5710 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5712 * process.c (wait_reading_process_output): Fix asynchrounous
5713 GnuTLS socket handling on some versions of the GnuTLS library.
5714 (wait_reading_process_output): Add comment and URL.
5716 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5718 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5720 2011-11-21 Chong Yidong <cyd@gnu.org>
5722 * window.c (Fnext_window, Fprevious_window): Doc fix.
5724 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5726 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5728 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5730 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5732 2011-11-20 Martin Rudalics <rudalics@gmx.at>
5734 * window.c (Fset_window_combination_limit): Rename argument
5736 (Vwindow_combination_limit): Remove "status" from doc-string.
5738 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5740 * m/ibms390.h: Remove.
5741 * m/ibms390x.h: Don't include "ibms390.h".
5743 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5745 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5746 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5748 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5750 * casetab.c (Fset_case_table):
5751 * charset.c (Fcharset_after): Fix typos.
5753 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
5755 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5756 Otherwise, valgrind does not work on some platforms.
5757 Problem reported by Andreas Schwab in
5758 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5759 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5760 is set, removing the need for VIRT_ADDRESS_VARIES.
5761 (PURE_P): Use a more-efficient implementation that needs just one
5762 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5763 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5764 to 4 (xorl, subq, cmpq, setbe).
5765 * alloc.c (pure): Always extern now, since that's the
5766 VIRT_ADDR_VARIES behavior.
5767 (PURE_POINTER_P): Use a single comparison, not two, for
5768 consistency with the new puresize.h.
5769 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5770 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5771 Remove VIRT_ADDR_VARIES no longer needed.
5773 2011-11-19 Eli Zaretskii <eliz@gnu.org>
5775 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5776 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5777 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5778 behave as if the cursor position were at the window margin.
5780 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5781 and the cursor position is out of bounds, behave as if the cursor
5782 position were at the window margin. (Bug#10075)
5784 2011-11-18 Chong Yidong <cyd@gnu.org>
5786 * window.c (Fwindow_combination_limit): Make first argument
5787 non-optional, since it is meaningless for live windows like the
5790 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5792 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5794 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5796 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5797 (graft_intervals_into_buffer): Simplify.
5799 2011-11-18 Eli Zaretskii <eliz@gnu.org>
5801 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5802 hash values of the two rows.
5803 (copy_row_except_pointers): Preserve the used[] arrays and the
5804 hash values of the two rows. (Bug#10035)
5805 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
5807 * xdisp.c (row_hash): New function, body extracted from
5808 compute_line_metrics.
5809 (compute_line_metrics): Call row_hash, instead of computing the
5812 * dispnew.c (verify_row_hash): Call row_hash for computing the
5813 hash code of a row, instead of duplicating code from xdisp.c.
5815 * dispextern.h (row_hash): Add prototype.
5817 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5819 * frame.c (delete_frame): Don't delete the terminal when the last
5820 X frame is closed if emacs is built with GTK toolkit.
5822 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
5824 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5826 2011-11-17 Martin Rudalics <rudalics@gmx.at>
5828 * window.c (Vwindow_splits): Rename to
5829 Vwindow_combination_resize. Suggested by Juri Linkov.
5830 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5833 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
5835 * nsfns.m (Fns_font_name):
5836 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
5838 2011-11-16 Martin Rudalics <rudalics@gmx.at>
5840 * window.h (window): Rename slot "nest" to "combination_limit".
5841 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5842 (Fset_window_nest): Rename to Fset_window_combination_limit.
5843 (Vwindow_nest): Rename to Vwindow_combination_limit.
5844 (recombine_windows, make_parent_window, make_window)
5845 (Fsplit_window_internal, saved_window)
5846 (Fset_window_configuration, save_window_save): Rename all
5847 occurrences of window_nest to window_combination_limit.
5849 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
5851 * image.c (imagemagick_load_image): Fix typo.
5853 2011-11-14 Eli Zaretskii <eliz@gnu.org>
5855 * xdisp.c (display_line): Move the call to
5856 highlight_trailing_whitespace before the call to
5857 compute_line_metrics, since the latter needs to see the final
5858 faces of all the glyphs to compute ROW's hash value.
5859 Fixes assertion violations in row_equal_p. (Bug#10035)
5861 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
5863 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5864 just return (bug#10044).
5866 2011-11-12 Eli Zaretskii <eliz@gnu.org>
5868 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5869 with user-defined heap size. Bump the default size of the temacs
5870 heap to 27MB, to avoid memory warning when running temacs.
5871 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5873 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5874 current_matrix and desired_matrix. (Bug#9990)
5875 (verify_row_hash) [XASSERTS]: New function.
5876 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5877 that the hash value of glyph rows is correct.
5879 2011-11-12 Martin Rudalics <rudalics@gmx.at>
5881 * window.h (window): Remove splits slot.
5882 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5883 (Fdelete_other_windows_internal, make_parent_window)
5884 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5885 (Fset_window_configuration, save_window_save): Don't deal with
5886 split status of windows.
5887 (saved_window): Remove splits slot.
5888 (Vwindow_splits): Rewrite doc-string.
5890 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5892 * xfns.c (unwind_create_frame):
5893 * nsfns.m (unwind_create_frame):
5894 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5895 Vframe_list (Bug#9999).
5897 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5899 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
5901 2011-11-11 Kenichi Handa <handa@m17n.org>
5903 * callproc.c (Fcall_process): Set the member dst_multibyte of
5906 2011-11-11 Johan Bockgård <bojohan@gnu.org>
5908 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5909 avoid a crash (bug#9496).
5911 2011-11-09 Chong Yidong <cyd@gnu.org>
5913 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5914 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5916 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5918 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5920 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5922 Avoid some portability problems by eschewing 'extern inline' functions.
5923 The trivial performance wins aren't worth the portability hassles; see
5924 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5926 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5927 (window_box_width, window_box_left, window_box_left_offset)
5928 (window_box_right, window_box_right_offset): Undo previous change,
5929 by removing the "extern"s.
5930 * intervals.c (adjust_intervals_for_insertion)
5931 (adjust_intervals_for_deletion): Undo previous change,
5932 making these static again.
5933 (offset_intervals, temp_set_point_both, temp_set_point)
5934 (copy_intervals_to_string): No longer inline.
5935 * xdisp.c (window_text_bottom_y, window_box_width)
5936 (window_box_height, window_box_left_offset)
5937 (window_box_right_offset, window_box_left, window_box_right)
5938 (window_box): No longer inline.
5940 2011-11-08 Chong Yidong <cyd@gnu.org>
5942 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
5943 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5944 Signal an error if not a live window.
5945 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5946 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5948 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
5950 * lisp.h (syms_of_abbrev): Remove declaration.
5951 Reported by CHENG Gao <chenggao@royau.me>.
5953 2011-11-07 Eli Zaretskii <eliz@gnu.org>
5955 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5956 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5957 of temacs in GUI mode.
5959 2011-11-07 Martin Rudalics <rudalics@gmx.at>
5961 * window.h: Declare delete_all_child_windows instead of
5962 delete_all_subwindows.
5963 * window.c (Fwindow_nest, Fset_window_nest)
5964 (Fset_window_new_total, Fset_window_new_normal)
5965 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5966 (delete_all_subwindows): Rename to delete_all_child_windows.
5967 (Fdelete_other_windows_internal, Fset_window_configuration):
5968 Call delete_all_child_windows instead of delete_all_subwindows.
5969 * frame.c (delete_frame): Call delete_all_child_windows instead
5970 of delete_all_subwindows.
5972 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5974 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5975 This is also needed for porting to any host where GC_MARK_STACK is
5976 not GC_MAKE_GCPROS_NOOPS.
5977 (which_symbols): Use it.
5979 2011-11-07 Kenichi Handa <handa@m17n.org>
5981 * coding.c (coding_set_destination): Check coding->src_pos only
5982 when coding->src_object is a buffer (bug#9910).
5984 * process.c (send_process): Set the member src_multibyte of coding
5985 to 0 (bug#9911) when sending a unibyte text.
5987 * callproc.c (Fcall_process): Set the member src_multibyte of
5988 process_coding to 0 (bug#9912).
5990 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5992 * xmenu.c (cleanup_widget_value_tree): New function.
5993 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5994 calling free_menubar_widget_value_tree directly (Bug#9830).
5996 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5998 Fix some portability problems with 'inline'.
5999 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6000 (window_box_width, window_box_left, window_box_left_offset)
6001 (window_box_right, window_box_right_offset): Declare extern.
6002 Otherwise, these inline functions do not conform to C99 and
6003 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6004 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6005 * intervals.c (adjust_intervals_for_insertion)
6006 (adjust_intervals_for_deletion): Now extern, because otherwise the
6007 extern inline functions 'offset_intervals' couldn't refer to it.
6008 (static_offset_intervals): Remove.
6009 (offset_intervals): Rewrite using the old contents of
6010 static_offset_intervals. The old version didn't conform to C99
6011 because an extern inline function contained a reference to an
6012 identifier with static linkage.
6014 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6016 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6019 2011-11-06 Eli Zaretskii <eliz@gnu.org>
6021 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6022 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6023 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6024 return Qleft_to_right.
6026 2011-11-06 Chong Yidong <cyd@gnu.org>
6028 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6029 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6030 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6031 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6032 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6033 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6034 (Fwindow_vscroll): Doc fix.
6035 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6036 argument, since it makes no sense to pass a live window and for
6037 consistency with window-child.
6039 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6041 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6044 2011-11-05 Jason Rumney <jasonr@gnu.org>
6046 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6047 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6049 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6050 bitwise arithmetic preventing use of unicode-sip and non-truetype
6053 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6055 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6058 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6059 initialization code to keep similarity to xfns.c after changes
6062 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6064 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6065 (unwind_create_frame): New function (Bug#9943).
6066 (Fx_create_frame): Restructure code to be more similar to the one in
6067 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6068 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6069 Move terminal->reference_count++ just before making the frame official
6072 * nsterm.m (x_free_frame_resources): New function.
6073 (x_destroy_window): Move code to x_free_frame_resources.
6075 * xfns.c (unwind_create_frame): Fix comment.
6076 (Fx_create_frame, x_create_tip_frame):
6077 Move terminal->reference_count++ just before making the frame
6078 official. Move initialization of image_cache_refcount and
6079 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6081 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6083 Support MSVC build with newer versions of Visual Studio.
6084 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6085 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6088 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6089 which are not supported by MSVC.
6090 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6091 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6093 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6095 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6097 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6099 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
6101 Support MSVC build with newer versions of Visual Studio.
6102 * w32.c: Don't include w32api.h for MSVC.
6103 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6105 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6106 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6107 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6108 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6110 (alloca) [_MSC_VER]: Define to _alloca.
6112 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6114 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6116 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6118 * xdisp.c (note_mouse_highlight): If either of
6119 previous/next-single-property-change returns nil, treat that as
6120 the beginning or the end of the buffer. (Bug#9955)
6122 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6124 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
6125 label is not null (Bug#9951).
6126 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6129 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6131 * window.c (Fwindow_body_size): Mention in the doc string that the
6132 return value is in frame's canonical units. (Bug#9949)
6134 2011-11-03 Eli Zaretskii <eliz@gnu.org>
6136 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6138 * w32fns.c (unwind_create_frame): If needed, free the glyph
6139 matrices of the partially constructed frame. (Bug#9943)
6140 * xfns.c (unwind_create_frame): Likewise.
6142 2011-11-01 Eli Zaretskii <eliz@gnu.org>
6144 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6145 Don't stop backward scan on the continuation glyph, even though
6146 its CHARPOS is positive.
6147 (mouse_face_from_buffer_pos, note_mouse_highlight):
6148 Rename cover_string to disp_string.
6150 2011-11-01 Martin Rudalics <rudalics@gmx.at>
6152 * window.c (temp_output_buffer_show): Don't use
6153 Vtemp_buffer_show_specifiers.
6154 (Vtemp_buffer_show_specifiers): Remove unused variable.
6156 2011-10-30 Eli Zaretskii <eliz@gnu.org>
6158 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6159 past the beginning of the current glyph matrix.
6161 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6163 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6164 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6165 HAVE_GTK3 (Bug#9869).
6167 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6168 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6170 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6172 * xterm.c: Declare x_handle_net_wm_state to return int.
6173 (handle_one_xevent): Check if we are iconified but don't have
6174 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6175 (get_current_wm_state): Return non-zero if not hidden,
6176 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6177 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6178 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6179 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6181 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6183 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6184 so that this new function doesn't get optimized away by a
6185 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6187 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6189 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6191 2011-10-29 Eli Zaretskii <eliz@gnu.org>
6193 Fix the `xbytecode' command.
6194 * .gdbinit (xprintbytestr): New command.
6195 (xwhichsymbols): Rename from `which'; all callers changed.
6196 (xbytecode): Print the byte-code string as well.
6198 2011-10-29 Kim Storm <storm@cua.dk>
6200 * alloc.c (which_symbols): New function.
6202 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6204 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6207 2011-10-29 Glenn Morris <rgm@gnu.org>
6209 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6210 Not clear what it was for, and it causes various bugs. (Bug#9839)
6212 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6214 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6215 possible random value that matches one of those tested as
6216 condition to clear the mouse face.
6218 2011-10-28 Chong Yidong <cyd@gnu.org>
6220 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6222 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6224 * window.c (make_window): Initialize phys_cursor_on_p.
6226 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6228 * lisp.h (struct Lisp_Symbol): Update comments.
6230 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
6232 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6234 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6236 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6237 <oslsachem@gmail.com> for helping to debug this.
6239 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6240 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6241 (g_b_init_get_glyph_outline_w): New static variables.
6242 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6243 (GetGlyphOutlineW_Proc): New typedefs.
6244 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
6245 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6247 (w32font_open_internal, compute_metrics):
6248 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
6249 instead of calling the "wide" APIs directly.
6251 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6253 * w32.h (syms_of_w32font): Add prototype.
6255 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6257 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6258 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6259 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6260 (Fmove_to_window_line): Doc fix.
6262 2011-10-27 Chong Yidong <cyd@gnu.org>
6264 * process.c (make_process): Set gnutls_state to NULL.
6266 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6267 non-NULL, regardless of GNUTLS_INITSTAGE.
6268 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6269 an error. Set process slots as soon as we allocate them.
6271 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6273 2011-10-27 Chong Yidong <cyd@gnu.org>
6275 * gnutls.c (emacs_gnutls_deinit): New function.
6276 Deallocate credentials structures as well as calling gnutls_deinit.
6277 (Fgnutls_deinit, Fgnutls_boot): Use it.
6279 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6280 (deactivate_process): Call emacs_gnutls_deinit.
6282 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6284 * image.c (x_create_x_image_and_pixmap):
6285 * w32.c (sys_rename, w32_delayed_load):
6286 * w32font.c (fill_in_logfont):
6287 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6289 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
6291 * w32fns.c (w32_default_color_map): New function,
6292 extracted from Fw32_default_color_map.
6293 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
6295 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6297 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6299 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6301 * keyboard.c (test_undefined): New function (bug#9751).
6302 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6304 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6306 * sysdep.c (init_sys_modes): Fix the check for the controlling
6307 terminal (Bug#6649).
6309 2011-10-20 Eli Zaretskii <eliz@gnu.org>
6311 * dispextern.h (struct bidi_it): New member next_en_type.
6313 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6314 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6315 current character, check also for next_en_type being WEAK_EN.
6316 (bidi_resolve_weak): Don't enter the expensive loop if the current
6317 position is before next_en_pos. Record the bidi type of the first
6318 non-ET, non-BN character we find, in addition to its position.
6319 (bidi_level_of_next_char): Invalidate next_en_type when
6320 next_en_pos is over-stepped.
6322 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6324 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6325 * editfns.c: Rewrite current-time-zone so that it invokes
6326 the equivalent of (format-time-string "%Z") to get the time zone name.
6327 This fixes a bug when the time zone name contains characters that
6328 need converting from the system time locale to Emacs internal format.
6329 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6330 that patch fixed format-time-string to do the conversion, but
6331 I forgot to fix current-time-zone.
6332 (format_time_string): New function, containing most of
6333 what Fformat_time_string used to contain.
6334 (Fformat_time_string): Rewrite in terms of format_time_string.
6335 This doesn't change this function's behavior.
6336 (current-time-zone): Rewrite to use format_time_string.
6337 This fixes the bug reported by Michael Schierl in
6338 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6339 Jason Rumney's 2007-06-07 change worked around this bug, but
6341 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6343 2011-10-19 Eli Zaretskii <eliz@gnu.org>
6345 * xdisp.c (start_display): If the character at POS is displayed
6346 via a display vector, reset IT->current.dpvec_index to zero.
6347 (try_window_reusing_current_matrix): If a line ends in a display
6348 vector or the next line starts in a display vector, continue
6349 redrawing the window even though the character position of
6350 start_row was reached.
6353 2011-10-18 Chong Yidong <cyd@gnu.org>
6355 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6356 with nobreak-char-display too.
6358 2011-10-18 Eli Zaretskii <eliz@gnu.org>
6360 Fix part 3 of bug#9771.
6361 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6362 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6363 non-neutral characters if the current character is a paragraph
6364 separator (a.k.a. Newline). This avoids running the same
6365 expensive loop twice, once when we consume the preceding newline
6366 and the other time when the line actually needs to be displayed.
6367 Avoid the loop when we see neutrals on the base embedding level
6368 following a character whose directionality is the same as the
6369 paragraph's. This avoids running the expensive loop when a line
6370 ends in a long sequence of neutrals, like control characters.
6371 Add assertion against STRONG_AL type. Slightly rearrange code
6372 that determines the type of a neutral given the first non-neutral
6374 (bidi_level_of_next_char): Set next_en_pos to zero when
6375 invalidating its info.
6377 2011-10-17 Eli Zaretskii <eliz@gnu.org>
6379 * xdisp.c (push_display_prop): Determine whether to record string
6380 or buffer position by IT->string, not by IT->method. Allow
6381 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
6382 (move_it_vertically_backward): Don't look for character position
6383 immediately after the newline when in a continuation line.
6386 2011-10-15 Martin Rudalics <rudalics@gmx.at>
6388 * window.c (coordinates_in_window): Rewrite and delabelize
6389 vertical border check. (Bug#5357) (Bug#9618)
6391 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6393 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6394 errors in XSetWindowBorder (bug#9310).
6396 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6398 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6399 avoid crash when xmalloc overrun checking is enabled.
6401 2011-10-13 Eli Zaretskii <eliz@gnu.org>
6403 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6404 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6405 cursor motion with <left> and <right> arrow keys.
6407 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6408 some callers set that themselves.
6410 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6412 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6413 display string and the previous row comes from the same string and
6414 is empty. (Bug#9739) (Bug#9738)
6416 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6418 * doc.c (get_doc_string): Encode file name (bug#9735).
6420 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6422 * bidi.c (bidi_level_of_next_char):
6423 * xdisp.c (get_visually_first_element): Remove old incorrect
6424 comments regarding the Unicode Line Separator character.
6426 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6428 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6430 * alloc.c (Fgc_status): Do not access beyond zombies array
6431 boundary if nzombies > MAX_ZOMBIES.
6432 * alloc.c (dump_zombies): Add missing format specifier.
6434 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6436 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6437 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6439 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6440 Some packages use them to denote characters with modifiers.
6442 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6444 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6445 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6446 matching a pp-number. Rename parameter var to var1.
6448 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6450 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6452 2011-10-08 Glenn Morris <rgm@gnu.org>
6454 * callint.c (Fcall_interactively): Give a more explicit error for the
6455 'c' case with a non-character input. (Bug#8479)
6457 2011-10-08 Eli Zaretskii <eliz@gnu.org>
6459 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6461 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6462 lines that are hscrolled on the left.
6464 * dispnew.c (buffer_posn_from_coords): Account for a possible
6465 presence of header-line. (Bug#4426)
6467 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6469 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6470 Don't advertise functionality which we discourage or doesn't work.
6472 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6474 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6475 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6476 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6477 this makes Emacs dump core during garbage collection on rare
6478 occasions. sizeof is obviously inferior to offsetof here, so
6479 stick with offsetof.
6480 (GC_POINTER_ALIGNMENT): New macro.
6481 (mark_memory): Omit 3rd (offset) arg; caller changed.
6482 Don't assume EMACS_INT alignment is the same as pointer alignment.
6484 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6486 * keyboard.c (read_key_sequence_remapped): New var.
6487 (read_key_sequence): Compute remapping in the right buffer.
6488 (command_loop_1): Use read_key_sequence's remapping directly.
6490 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6492 * dired.c (file_name_completion): Don't expand file name.
6493 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6494 before checking file name handler.
6496 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6497 they've been requested explicitly (bug#9591).
6499 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
6501 * keymap.c (Fsingle_key_description): Use make_specified_string
6502 instead of build_string to build string from push_key_description.
6505 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6507 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6508 This fixes a Y2038 bug on 64-bit hosts.
6509 * buffer.c (reset_buffer):
6510 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6511 (Fclear_buffer_auto_save_failure):
6512 Use 0, not -1, to represent an unset failure time, since time_t
6513 might not be signed.
6515 Remove dependency on glibc malloc internals.
6516 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6517 Move back here from lisp.h, but with their new implementations.
6518 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6519 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6520 * charset.c (charset_table_init): New static var.
6521 (syms_of_charset): Use it instead of xmalloc. This removes a
6522 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6523 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6524 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6525 Move back to alloc.c.
6526 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6527 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6529 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6531 * nsterm.m (windowDidResize): Call x_set_window_size only when
6532 ns_in_resize is true. Otherwise set pixelwidth/height and
6533 call change_frame_size (Bug#9628).
6535 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6537 Port --enable-checking=all to Fedora 14 x86-64.
6538 * charset.c (syms_of_charset): Also account for glibc malloc's
6539 internal overhead when calculating the initial malloc maximum.
6541 Port --enable-checking=all to Fedora 14 x86.
6542 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6544 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6545 (overrun_check_realloc, overrun_check_free):
6546 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6547 That way, xmalloc returns a properly-aligned pointer even if
6548 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6549 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6550 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6551 into account when calculating the initial malloc maximum.
6552 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6553 Move here from alloc.c, so that charset.c can use it too.
6554 Properly align; the old code wasn't right for common 32-bit hosts
6555 when configured with --enable-checking=all.
6556 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6557 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6559 2011-09-29 Eli Zaretskii <eliz@gnu.org>
6561 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
6564 2011-09-28 Eli Zaretskii <eliz@gnu.org>
6566 * xdisp.c (compute_display_string_end): If there's no display
6567 string at CHARPOS, return -1.
6569 * bidi.c (bidi_fetch_char): When compute_display_string_end
6570 returns a negative value, treat the character as a normal
6571 character not covered by a display string. (Bug#9624)
6573 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
6575 * lread.c (Fread_from_string): Fix typo in docstring.
6577 2011-09-27 Eli Zaretskii <eliz@gnu.org>
6579 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6580 newline, reseat the iterator instead of bidi-iterating there one
6581 character at a time. (Bug#9610)
6582 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6583 TO_CHARPOS if the bidi iterator is at base embedding level.
6585 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6587 * lread.c (readevalloop): Use correct code for NBSP.
6588 (read1): Likewise. (Bug#9608)
6590 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
6592 * dbusbind.c (Fdbus_register_signal): When service is not
6593 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6595 2011-09-25 Glenn Morris <rgm@gnu.org>
6597 * buffer.c (truncate-lines): Doc fix.
6599 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
6601 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6602 (Fset_window_next_buffers): Doc fix.
6604 2011-09-24 Glenn Morris <rgm@gnu.org>
6606 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6608 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6610 Fix minor problems found by static checking.
6611 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
6612 * indent.c (Fvertical_motion): Fix == vs = typo.
6614 2011-09-24 Eli Zaretskii <eliz@gnu.org>
6616 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6617 Default value is now t. Doc fix.
6619 * indent.c (Fvertical_motion): Compute and apply the overshoot
6620 logic when moving up, not only when moving down. Fix the
6621 confusing name and values of the it_overshoot_expected variable;
6622 logic changes accordingly. (Bug#9254) (Bug#9549)
6624 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6625 CHARPOS is covered by a display string which includes newlines.
6626 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6627 is covered by a display string with embedded newlines.
6629 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
6631 * dbusbind.c (Fdbus_register_signal): Add match rule to
6632 Vdbus_registered_objects_table. (Bug#9581)
6633 (Fdbus_register_method, Vdbus_registered_objects_table):
6636 2011-09-24 Jim Meyering <meyering@redhat.com>
6638 do not ignore write error for any output size
6639 The previous change was incomplete.
6640 While it makes emacs --batch detect the vast majority of stdout
6641 write failures, errors were still ignored whenever the output size is
6642 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6643 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6644 && echo FAIL: ignored write error
6645 FAIL: ignored write error
6646 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6647 && echo FAIL: ignored write error
6648 FAIL: ignored write error
6649 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6651 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6653 * emacs.c (Fkill_emacs): In noninteractive mode exit
6654 non-successfully if a write error occurred on stdout. (Bug#9574)
6656 2011-09-21 Eli Zaretskii <eliz@gnu.org>
6658 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6661 * dispextern.h (struct it): Update the comment documenting what
6664 2011-09-20 Eli Zaretskii <eliz@gnu.org>
6666 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6667 a display string, extend search for cursor position to end of row.
6668 (find_row_edges): If the row ends in a newline from a display
6669 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6670 Handle the case of a display string with multiple newlines.
6671 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6672 non-empty line. Fixes confusing cursor motion with arrow keys at
6673 the beginning of a line that starts with whitespace.
6675 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6677 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6680 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
6682 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6685 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6687 * xdisp.c (display_line): Record maximum and minimum buffer
6688 positions even if no glyphs were produced (e.g., by a zero-width
6689 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6690 buffer positions that will be removed from the glyph row because
6692 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6693 column is beyond frame width: don't subtract 1 "pixel" when
6694 computing width of the stretch.
6695 (reseat_at_next_visible_line_start): Undo the change made on
6696 2011-09-17 that saved paragraph information and restored it after
6697 the call to `reseat'. (Bug#9545)
6699 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6701 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6702 and turn window cursor on if cleared (Bug#9415).
6704 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
6706 * search.c (boyer_moore): Take unibyte characters from pattern
6707 literally. (Bug#9458)
6709 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6711 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6713 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6715 Fix minor problem found by static checking.
6716 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6717 initialized, to pacify gcc -Wuninitialized.
6719 * fileio.c: Report proper errno when syscall falls.
6720 (Finsert_file_contents): Save and restore errno,
6721 so that report_file_error outputs the correct diagnostic.
6722 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6724 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6726 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6728 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6730 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6731 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6733 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6735 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6736 about the current paragraph and restore it after the call to reseat.
6738 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6739 (bidi_find_paragraph_start): Search back for paragraph beginning
6740 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6741 (bidi_move_to_visually_next): Only trigger paragraph-related
6742 computations when the last character is a newline or at EOB, not
6743 just any NEUTRAL_B. (Bug#9470)
6745 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6746 truncated lines if point is covered by a display string. (Bug#9524)
6748 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6750 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6751 (cons_to_x_long): New function.
6752 (lisp_data_to_selection_data): Use it. Correct the test for
6753 short-versus-long data; it was negated. Break out of vector
6754 loop, for efficiency, when a long datum is discovered.
6756 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6758 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6760 2011-09-16 Eli Zaretskii <eliz@gnu.org>
6762 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6763 GCC PR/17406) by declaring this function with external scope.
6765 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6767 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6768 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6770 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6772 * editfns.c (Fformat): Correctly handle text properties on "%%".
6774 2011-09-15 Eli Zaretskii <eliz@gnu.org>
6776 * xterm.c (x_draw_composite_glyph_string_foreground):
6777 * w32term.c (x_draw_composite_glyph_string_foreground):
6778 * term.c (encode_terminal_code):
6779 * composite.c (composition_update_it, get_composition_id):
6780 * xdisp.c (get_next_display_element)
6781 (fill_composite_glyph_string): Add comments about special meaning
6782 of TAB characters in a composition.
6784 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6786 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
6787 This occurs when processing a multibyte format.
6788 Problem reported by Wolfgang Jenker.
6790 2011-09-15 Johan Bockgård <bojohan@gnu.org>
6792 * xdisp.c (try_cursor_movement): Only check for exact match if
6793 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6795 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6797 Remove unused external symbols.
6798 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6799 * xdisp.c (calc_pixel_width_or_height): Now static.
6800 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6801 * indent.c (check_display_width):
6802 * w32term.c: Fix comment to match code.
6803 * xterm.c, xterm.h (x_catching_errors): Remove.
6805 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6807 * xselect.c: Use signed conversions more consistently (Bug#9498).
6808 (selection_data_to_lisp_data): Assume incoming selection data are
6809 signed integers, not unsigned. This is to be consistent with
6810 outgoing selection data, which was modified to use signed integers
6811 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6812 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6813 expects long, not unsigned long.
6815 2011-09-14 Eli Zaretskii <eliz@gnu.org>
6817 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6818 computation of loop end. Reported by Johan Bockgård
6821 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
6823 * frame.c (Fother_visible_frames_p): Function deleted.
6825 2011-09-12 Eli Zaretskii <eliz@gnu.org>
6827 * indent.c (compute_motion): Process display vector front to back
6828 rather than the other way around. (Bug#2496)
6830 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6832 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6834 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
6836 * minibuf.c (Fread_from_minibuffer): Doc fix.
6838 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6840 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6841 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6843 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6845 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6846 value for non-existent files.
6848 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6850 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6851 set its "size" to -1. This will set the modtime_size field of
6852 the corresponding buffer to -1, which is what
6853 verify-visited-file-modtime expects for files that do not exist.
6856 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6858 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6860 * lisp.h: ... from here. push_key_description is no longer
6861 defined in keyboard.c, so its declaration should not be in
6862 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6863 logically belongs with push_key_description.
6865 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6867 * buffer.h: Include <sys/types.h> instead of <time.h>.
6868 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6869 Problem reported by Herbert J. Skuhra.
6871 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6873 * xml.c (parse_region): Make the parsing work for
6874 non-comment-starting XML files again (bug#9144).
6876 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6878 * image.c (gif_load): Fix calculation of bottom and right corner.
6881 2011-09-10 Eli Zaretskii <eliz@gnu.org>
6883 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6884 redisplay in small windows.
6886 2011-09-09 Eli Zaretskii <eliz@gnu.org>
6888 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6890 2011-09-08 Martin Rudalics <rudalics@gmx.at>
6892 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6893 Operate on live windows only.
6895 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
6897 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6899 2011-09-07 Eli Zaretskii <eliz@gnu.org>
6901 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6902 only under bidi iteration.
6904 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6906 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6908 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6910 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6911 Without this fix, the command to link temacs failed due to an
6912 undefined symbol __builtin_isnan. This is because
6913 /usr/include/iso/math_c99.h #defines isnan(x) to
6914 __builtin_isnan(x), but the bundled gcc, which identifies itself
6915 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6917 * floatfns.c (isnan): #undef, and then #define to a clone of
6919 (Fisnan): Always define, since it's always available now.
6920 (syms_of_floatfns): Always define isnan at the Lisp level.
6922 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6924 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6926 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6928 * fileio.c: Fix bugs with large file offsets (Bug#9428).
6929 The previous code assumed that file offsets (off_t values) fit in
6930 EMACS_INT variables, which is not true on typical 32-bit hosts.
6931 The code messed up by falsely reporting buffer overflow in cases
6932 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6933 when "big" contains more than 2**29 bytes, even though this
6934 inserts just one byte and does not overflow the buffer.
6935 (Finsert_file_contents): Store file offsets as off_t
6936 values, not as EMACS_INT values. Check for overflow when
6937 converting between EMACS_INT and off_t. When checking for
6938 buffer overflow or for overlap, take the offsets into account.
6939 Don't use EMACS_INT for small values where int suffices.
6940 When checking for overlap, fix a typo: ZV was used where
6941 ZV_BYTE was intended.
6942 (Fwrite_region): Don't assume off_t fits into 'long'.
6943 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6945 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
6947 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6949 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6951 sprintf-related integer and memory overflow issues (Bug#9412).
6953 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6954 (esprintf, exprintf, evxprintf): New functions.
6955 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6956 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
6957 (modify_event_symbol): Do not assume that the length of
6958 name_alist_or_stem is safe to alloca and fits in int.
6959 (Fexecute_extended_command): Likewise for function name and binding.
6960 (Frecursion_depth): Wrap around reliably on integer overflow.
6961 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6962 since some callers pass EMACS_INT values.
6963 (Fsingle_key_description): Don't crash if symbol name contains more
6964 than MAX_ALLOCA bytes.
6965 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6966 (get_minibuffer): Arg is now EMACS_INT, not int.
6967 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
6968 (esprintf, exprintf, evxprintf): New decls.
6969 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6971 * dbusbind.c (signature_cat): New function.
6972 (xd_signature, Fdbus_register_signal):
6973 Do not overrun buffer; instead, report string overflow.
6975 * dispnew.c (add_window_display_history): Don't overrun buffer.
6976 Truncate instead; this is OK since it's just a log.
6978 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6979 even if the time zone offset is outlandishly large.
6980 Don't mishandle offset == INT_MIN.
6982 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6983 when creating daemon; the previous buffer-overflow check was incorrect.
6985 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6986 which has the guts of the old verror function.
6988 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6989 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6991 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6992 (font_unparse_xlfd): Don't blindly alloca long strings.
6993 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
6994 fits in int, when using sprintf. Use single snprintf to count
6995 length of string rather than counting it via multiple sprintfs;
6996 that's simpler and more reliable.
6997 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6998 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6999 sprintf, in case result does not fit in int.
7001 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7002 (fontset_from_font): Print it.
7004 * frame.c (tty_frame_count): Now printmax_t, not int.
7005 (make_terminal_frame, set_term_frame_name): Print it.
7006 (x_report_frame_params): In X, window IDs are unsigned long,
7007 not signed long, so print them as unsigned.
7008 (validate_x_resource_name): Check for implausibly long names,
7009 and don't assume name length fits in 'int'.
7010 (x_get_resource_string): Don't blindly alloca invocation name;
7011 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7014 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7015 (xg_check_special_colors, xg_set_geometry):
7016 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7018 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7019 Use esprintf, not sprintf, in case result does not fit in int.
7021 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7022 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7023 it as a large positive number.
7024 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7025 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7027 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7028 in case result does not fit in int.
7030 * print.c (float_to_string): Detect width overflow more reliably.
7031 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7032 buffer overrun. Don't assume list length fits in 'int'. Treat
7033 print length of 0 as 0, not as infinity; to be consistent with other
7034 uses of print length in this function. Don't overflow print length
7035 index. Don't assume hash table size fits in 'long', or that
7036 vectorlike size fits in 'unsigned long'.
7038 * process.c (make_process): Use printmax_t, not int, to format
7039 process-name gensyms.
7041 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7043 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7044 to avoid potential buffer overrun.
7046 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7047 if X resource line is longer than 512 bytes.
7049 * xfns.c (x_window): Make sprintf buffer a bit bigger
7050 to avoid potential buffer overrun.
7052 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7054 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7056 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7058 Integer overflow fixes for scrolling, etc.
7059 Without these, Emacs silently mishandles large integers sometimes.
7060 For example, "C-u 4294967297 M-x recenter" was treated as if
7061 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7063 * xdisp.c (try_window_id): Check Emacs fixnum range before
7064 converting to 'int'.
7066 * window.c (window_scroll_line_based, Frecenter):
7067 Check that an Emacs fixnum is in range before assigning it to 'int'.
7068 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7069 values converted from Emacs fixnums.
7070 (Frecenter): Don't wrap around a line count if it is out of 'int'
7071 range; instead, treat it as an extreme value.
7072 (Fset_window_configuration, compare_window_configurations):
7073 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7075 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7076 that can exceed INT_MAX. Check that EMACS_INT value is in range
7077 before assigning it to the (possibly-narrower) index.
7078 (match_limit): Don't assume that a fixnum can fit in 'int'.
7080 * print.c (print_object): Use ptrdiff_t, not int, for index that can
7083 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
7084 (Fvertical_motion): Don't wrap around LINES values that don't fit
7085 in 'int'. Instead, treat them as extreme values. This is good
7086 enough for windows, which can't have more than INT_MAX lines anyway.
7088 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7090 * Require libxml/parser.h to avoid compilation warning.
7092 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7094 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7095 since this reportedly can destroy thread storage.
7097 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
7099 * syntax.c (find_defun_start): Update all cache variables if
7100 exiting early (Bug#9401).
7102 2011-08-30 Eli Zaretskii <eliz@gnu.org>
7104 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7106 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7107 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7108 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7110 * term.c (tty_append_glyph): New function.
7111 (produce_stretch_glyph): Static function and its prototype deleted.
7113 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7116 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7118 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7119 when checking :margin (Bug#9390).
7120 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
7121 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
7122 so that the name doesn't mislead. All uses changed.
7124 2011-08-28 Johan Bockgård <bojohan@gnu.org>
7126 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7129 2011-08-27 Eli Zaretskii <eliz@gnu.org>
7131 * xdisp.c (move_it_to): Don't bail out early when reaching
7132 position beyond to_charpos, if we are scanning backwards.
7133 (move_it_vertically_backward): When DY == 0, make sure we get to
7134 the first character in the line after the newline.
7136 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7138 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7139 (ccl_driver): Do not generate an out-of-range pointer.
7140 (Fccl_execute_on_string): Remove unnecessary check for
7141 integer overflow, noted by Stefan Monnier in
7142 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7143 Remove a FIXME that didn't need fixing.
7144 Simplify the newly-introduced buffer reallocation code.
7146 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
7148 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7150 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
7152 Integer and memory overflow issues (Bug#9196).
7154 * doc.c (get_doc_string): Rework so that
7155 get_doc_string_buffer_size is the actual buffer size, rather than
7156 being 1 less than the actual buffer size; this makes xpalloc more
7159 * image.c (x_allocate_bitmap_record, cache_image):
7160 * xselect.c (Fx_register_dnd_atom):
7161 Simplify previous changes by using xpalloc.
7163 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7164 since either will do and ptrdiff_t is convenient with xpalloc.
7166 * charset.c (charset_table_size)
7167 (struct charset_sort_data.priority): Now ptrdiff_t.
7168 (charset_compare): Don't overflow if priorities differ greatly.
7169 (Fsort_charsets): Don't assume list length fits in int.
7170 Check for size-calculation overflow when allocating sort data.
7171 (syms_of_charset): Allocate an initial charset table that is
7172 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7174 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7176 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7177 The actual value is always <= INT_MAX, and leaving it unsigned made
7178 overflow checking harder.
7180 * dispextern.h (struct glyph_matrix.rows_allocated)
7181 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7182 with xpalloc. The values are still always <= INT_MAX.
7184 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7186 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7187 (SAFE_NALLOCA): New macro.
7189 * region-cache.c (struct boundary.pos, find_cache_boundary)
7190 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7191 (set_cache_region, invalidate_region_cache)
7192 (revalidate_region_cache, know_region_cache, region_cache_forward)
7193 (region_cache_backward, pp_cache):
7194 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7195 so that ptrdiff_t * can be passed to xpalloc.
7196 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7197 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7198 (pp_cache): Don't assume cache_len fits in int.
7199 * region-cache.h: Adjust extern decls to match.
7201 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7202 EMACS_INT, since either will do, for xpalloc.
7204 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7205 (xnmalloc, xnrealloc, xpalloc): New functions.
7207 * bidi.c (bidi_shelve_header_size): New constant.
7208 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7209 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7211 * bidi.c (bidi_cache_shrink):
7212 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7214 Don't update size of array until after memory allocation succeeds,
7215 because xmalloc/xrealloc may not return.
7216 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7217 now that we have proper integer overflow checking.
7218 (record_overlay_string, overlay_strings): Catch overflows when
7219 calculating size of overlay_str_buf.
7221 * callproc.c (Fcall_process): Check for size overflow when
7222 calculating size of args2.
7223 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7224 Normally we prefer signed values, but sticking with ptrdiff_t would
7225 require adding more-complicated checks.
7227 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7228 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7229 Redo buffer-overflow calculations to avoid integer overflow.
7230 Add a FIXME comment where memory seems to be over-allocated.
7232 * character.c (Fstring): Check for size-calculation overflow.
7234 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7235 unnecessary integer overflow. Check for size overflow.
7236 (encode_coding_object): Don't update size until xmalloc succeeds.
7238 * composite.c (get_composition_id): Check for overflow in glyph
7239 length calculations.
7241 Integer and memory overflow fixes for display code.
7242 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7243 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7244 (scrolling_window): Check for overflow in size calculations.
7245 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7246 Don't assume glyph table len fits in int.
7247 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7248 (row_table_size): Now ptrdiff_t, not int.
7249 (scrolling_window): Avoid overflow in size calculations.
7250 Don't update size until allocation succeeds.
7251 * fns.c (concat): Check for overflow in size calculations.
7252 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7253 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7254 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7256 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7257 (get_doc_string): Check for size calculation overflow.
7258 Don't update size until allocation succeeds.
7259 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7260 EMACS_INT, where ptrdiff_t will do.
7261 (Fsubstitute_command_keys): Check for string overflow.
7263 * editfns.c (set_time_zone_rule): Don't assume environment length
7265 (message_length): Now ptrdiff_t, not int.
7266 (Fmessage_box): Don't update size until allocation succeeds.
7267 Don't assume message length fits in int.
7268 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7270 * emacs.c (main): Do not reallocate argv, since there is a null at
7271 the end that can be overwritten, and this way there's no need to
7272 worry about size-calculation overflow.
7273 (sort_args): Check for size-calculation overflow.
7275 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7277 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7279 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7280 (x_set_scroll_bar_width, x_figure_window_size):
7281 Check for integer overflow.
7282 (x_set_alpha): Do not assume XINT fits in int.
7284 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7285 This is for the members text_lines, text_cols, total_lines, total_cols,
7286 where the system imposes an 'int' limit.
7288 * fringe.c (Fdefine_fringe_bitmap):
7289 Don't update size until alloc works.
7291 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7292 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7294 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7295 Check for size-calculation overflow.
7296 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7297 do, as we prefer signed integers.
7298 (id_to_widget.max_size, id_to_widget.used)
7299 (xg_store_widget_in_map, xg_remove_widget_from_map)
7300 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7301 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7302 Use and return ptrdiff_t, not int.
7303 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7304 * gtkutil.h: Change prototypes to match the above.
7306 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7307 are duplicate now that they've been promoted to lisp.h.
7308 (x_allocate_bitmap_record, x_alloc_image_color)
7309 (make_image_cache, cache_image, xpm_load):
7310 Don't update size until alloc is done.
7311 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7313 Check for size calculation overflow.
7314 (ct_colors_allocated_max): New constant.
7315 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7318 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7319 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7320 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7321 Use ptrdiff_t, not int, to count maps.
7322 (read_char_minibuf_menu_prompt): Check for overflow in size
7323 calculations. Don't update size until allocation succeeds.
7324 Redo calculations to avoid overflow.
7325 * keyboard.h: Change prototypes to match the above.
7327 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7329 (current_minor_maps): Check for size calculation overflow.
7330 * keymap.h: Change prototypes to match the above.
7332 * lread.c (read1, init_obarray): Don't update size until alloc done.
7334 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7335 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7337 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7338 Now ptrdiff_t, not int.
7339 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7340 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7342 * process.c (Fnetwork_interface_list): Check for overflow
7343 in size calculation.
7345 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7347 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7348 overflow. Don't bother calling xmalloc when xrealloc will do.
7350 * search.c (Freplace_match): Check for size calculation overflow.
7351 (Fset_match_data): Don't assume list lengths fit in 'int'.
7353 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7354 for command line length. Do not attempt to address one before the
7355 beginning of an array, as that's not portable.
7357 * term.c (max_frame_lines): Remove; unused.
7358 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7360 (encode_terminal_code, calculate_costs): Check for size
7361 calculation overflow.
7362 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7363 table lengths and related sizes. Don't update size until alloc
7364 done. Redo calculations to avoid overflow.
7365 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7367 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7368 subtracting pointers.
7369 (gobble_line): Check for overflow more carefully. Don't update size
7372 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7373 Don't update size until alloc done.
7374 Redo size calculations to avoid overflow.
7375 Check for size calculation overflow.
7376 (main) [DEBUG]: Fix typo in invoking tparam1.
7378 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7379 Use ptrdiff_t, not int, for sizes.
7380 (store_mode_line_noprop_char): Don't update size until alloc done.
7382 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7383 Use ptrdiff_t, not int, for sizes.
7384 (Finternal_make_lisp_face, cache_face):
7385 Check for size calculation overflow.
7386 (cache_face): Treat size calculation overflows as if they were
7387 memory exhaustion (the usual treatment), rather than aborting.
7389 * xfns.c (x_encode_text, x_set_name_internal)
7390 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7391 sizes, since they can exceed INT_MAX in size. Check for size
7392 calculation overflow.
7394 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7395 (xg_select): Check for size calculation overflow.
7396 Don't update size until alloc done.
7398 * xrdb.c (get_environ_db): Don't assume path length fits in int,
7399 as sprintf is limited to int lengths.
7401 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7402 (X_LONG_MIN): New macros.
7403 Use them to make the following changes clearer.
7404 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7405 This change doesn't affect the value now, but it may help remind
7406 future maintainers not to raise the value too much later.
7407 (SELECTION_QUANTUM): Remove, replacing with ...
7408 (selection_quantum): ... new function, which avoids overflow.
7410 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7411 assumption that selection length fits in 'int'.
7412 (x_reply_selection_request, x_handle_selection_request)
7413 (x_get_window_property, receive_incremental_selection)
7414 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7415 (lisp_data_to_selection_data, clean_local_selection_data):
7416 Use ptrdiff_t, not int, to record length of selection.
7417 (x_reply_selection_request, x_get_window_property)
7418 (receive_incremental_selection, x_property_data_to_lisp):
7419 Redo calculations to avoid overflow.
7420 (x_reply_selection_request): When sending hint, ceiling it at
7421 X_LONG_MAX rather than relying on wraparound overflow to send
7423 (x_get_window_property, receive_incremental_selection)
7424 (lisp_data_to_selection_data, x_property_data_to_lisp):
7425 Check for size-calculation overflow.
7426 (x_get_window_property, receive_incremental_selection)
7427 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7428 Don't store size until memory allocation succeeds.
7429 (x_get_window_property): Plug memory leak on memory exhaustion.
7430 Don't double-block input; malloc is safe here. Don't assume 2**34
7431 - 4 fits in unsigned long. Add an xassert to check
7432 XGetWindowProperty overflow. Be more careful about overflow
7433 calculations, and distinguish size from memory overflow better.
7434 (receive_incremental_selection): When tracing, don't assume
7435 unsigned int is less than INT_MAX.
7436 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7437 harmful) conversions of unsigned short to int.
7438 (lisp_data_to_selection_data): Don't assume that integers
7439 in the range -65535 through -1 fit in an X unsigned short.
7440 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7441 result parameters unless successful. Rely on cons_to_unsigned
7442 to report problems with elements; the old code wasn't right anyway.
7443 (x_check_property_data): Check for int overflow; we cannot use
7444 a wider type due to X limits.
7445 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7447 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
7449 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7450 (x_term_init): Check for size calculation overflow.
7451 (x_color_cells): Don't store size until memory allocation succeeds.
7452 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
7453 Don't assume alloca size is less than MAX_ALLOCA.
7454 (x_term_init): Don't assume length fits in int (sprintf is limited
7457 Use ptrdiff_t for composition IDs.
7458 * character.c (lisp_string_width):
7459 * composite.c (composition_table_size, n_compositions)
7460 (get_composition_id, composition_gstring_from_id):
7461 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7462 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7463 * window.c (Frecenter):
7464 Use ptrdiff_t, not int, for composition IDs.
7465 * composite.c (get_composition_id): Check for integer overflow.
7466 * composite.h: Adjust prototypes to match the above changes.
7468 Use ptrdiff_t for hash table indexes.
7469 * category.c (hash_get_category_set):
7470 * ccl.c (ccl_driver):
7471 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7472 * coding.c (coding_system_charset_list, detect_coding_system):
7473 * coding.h (struct coding_system.id):
7474 * composite.c (get_composition_id, gstring_lookup_cache):
7475 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7476 * image.c (xpm_get_color_table_h):
7477 * lisp.h (hash_lookup, hash_put):
7478 * minibuf.c (Ftest_completion):
7479 Use ptrdiff_t for hash table indexes, not int (which is too
7480 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7481 32-bit --with-wide-int hosts).
7483 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7484 Add a FIXME comment about memory leaks.
7485 (syms_of_charset): Don't assume xmalloc returns.
7487 Don't assume that stated character widths fit in int.
7488 * character.c (Fchar_width, c_string_width, lisp_string_width):
7489 * character.h (CHAR_WIDTH):
7490 * indent.c (MULTIBYTE_BYTES_WIDTH):
7491 Use sanitize_char_width to avoid undefined and/or bad behavior
7492 with outlandish widths.
7493 * character.h (sanitize_tab_width): Rename from sanitize_width,
7494 now that we have two such functions. All uses changed.
7495 (sanitize_char_width): New inline function.
7497 Don't assume that tab-width fits in int.
7498 * character.h (sanitize_width): New inline function.
7499 (SANE_TAB_WIDTH): New macro.
7500 (ASCII_CHAR_WIDTH): Use it.
7501 * indent.c (sane_tab_width): Remove. All uses replaced by
7502 SANE_TAB_WIDTH (current_buffer).
7503 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7505 * fileio.c: Integer overflow issues with file modes.
7506 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7508 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7509 Remove unreachable code.
7510 (read_hex, load_charset_map_from_file): Check for integer overflow.
7512 * xterm.c: Don't go over XClientMessageEvent limit.
7513 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7514 (x_send_scroll_bar_event): Likewise. Check that the size does not
7515 exceed limits imposed by XClientMessageEvent, as well as the usual
7516 ptrdiff_t and size_t limits.
7518 * keyboard.c: Overflow, signedness and related fixes.
7519 (make_lispy_movement): Use same integer type in forward decl
7520 that is used in the definition.
7521 (read_key_sequence, keyremap_step):
7522 Change bufsize argument back to int, undoing my 2011-03-30 change.
7523 We prefer signed types, and int is wide enough here.
7524 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7525 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7526 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7527 length, not size_t. Use ptrdiff_t for index, not int.
7528 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7529 possibility of integer overflow.
7531 Overflow, signedness and related fixes for images.
7533 * dispextern.h (struct it.stack[0].u.image.image_id)
7534 (struct_it.image_id, struct image.id, struct image_cache.size)
7535 (struct image_cache.used, struct image_cache.ref_count):
7536 * gtkutil.c (update_frame_tool_bar):
7537 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7538 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7539 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7540 * nsmenu.m (update_frame_tool_bar):
7541 * xdisp.c (calc_pixel_width_or_height):
7542 * xfns.c (image_cache_refcount):
7543 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7544 on typical 64-bit hosts.
7546 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7547 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7548 Omit unnecessary casts to int.
7549 (parse_image_spec): Check that integers fall into 'int' range
7550 when the callers expect that.
7551 (image_ascent): Redo ascent calculation to avoid int overflow.
7552 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7553 (lookup_image): Remove unnecessary tests.
7554 (xbm_image_p): Locals are now of int, not EMACS_INT,
7555 since parse_image_check makes sure they fit into int.
7556 (png_load, gif_load, svg_load_image):
7557 Prefer int to unsigned where either will do.
7558 (tiff_handler): New function, combining the cores of the
7559 old tiff_error_handler and tiff_warning_handler.
7560 This function is rewritten to use vsnprintf and thereby avoid
7561 stack buffer overflows. It uses only the features of vsnprintf
7562 that are common to both POSIX and native Microsoft.
7563 (tiff_error_handler, tiff_warning_handler): Use it.
7564 (tiff_load, gif_load, imagemagick_load_image):
7565 Don't assume :index value fits in 'int'.
7566 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7567 (imagemagick_load_image): Check that crop parameters fit into
7568 the integer types that MagickCropImage accepts. Don't assume
7569 Vimagemagick_render_type has a nonnegative value. Don't assume
7570 size_t fits in 'long'.
7571 (gs_load): Use printmax_t to print the widest integers possible.
7572 Check for integer overflow when computing image height and width.
7574 2011-08-26 Eli Zaretskii <eliz@gnu.org>
7576 * xdisp.c (redisplay_window): Don't force window start if point
7577 will be invisible in the resulting window. (Bug#9324)
7579 2011-08-25 Eli Zaretskii <eliz@gnu.org>
7581 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7582 the display spec is of the form `(space ...)'.
7583 (handle_display_spec): Return the value returned by
7584 handle_single_display_spec, not just 1 or zero.
7585 (handle_single_display_spec): If the display spec is of the form
7586 `(space ...)', and specifies display in the text area, return 2
7588 (try_cursor_movement): Check for the need to scroll more
7589 accurately, and prefer exact match for point under bidi.
7590 Don't advance `row' beyond the last row of the window.
7592 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7593 into disp_prop; all users changed.
7595 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7596 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7597 for the text covered by the display property.
7599 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
7601 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7602 Change return value to nil.
7603 (Frecord_buffer): Delete unused function.
7605 2011-08-24 Eli Zaretskii <eliz@gnu.org>
7607 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7608 buffers, return left-to-right.
7609 (set_cursor_from_row): Consider candidate row a win if its glyph
7610 represents a newline and point is on that newline. Fixes cursor
7611 positioning on the newline at EOL of R2L text within L2R
7612 paragraph, and vice versa.
7613 (try_cursor_movement): Check continued rows, in addition to
7614 continuation rows. Fixes unwarranted scroll when point enters a
7615 continued line of R2L text within an L2R paragraph, or vice versa.
7616 (cursor_row_p): Consider the case of point being equal to
7617 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7618 from the end of a short line to the beginning of a continued line
7619 of R2L text within L2R paragraph.
7620 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7621 composed characters.
7623 * bidi.c (bidi_check_type): Use xassert.
7624 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7627 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7629 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7632 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
7634 * nsfont.m (ns_otf_to_script): Fix typo.
7636 2011-08-22 Kenichi Handa <handa@m17n.org>
7638 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7639 extra slot even if the purpose is char-code-property-table.
7641 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7643 * xdisp.c (redisplay_window): When computing centering_position,
7644 account for the height of the header line. (Bug#8874)
7646 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7647 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7648 candidate is selected by the mouse, and that candidate has a
7649 composed character under the mouse.
7651 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7652 coordinates reported by pos-visible-in-window-p for a composed
7653 character in column zero.
7655 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7657 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7659 2011-08-22 Eli Zaretskii <eliz@gnu.org>
7661 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7662 consider it a hit if to_charpos is anywhere in the range of the
7663 composed buffer positions.
7665 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
7667 * image.c (gif_load): Don't assume that each subimage has the same
7668 dimensions as the base image. Handle disposal method that is
7669 "undefined" by the gif spec (Bug#9335).
7671 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
7673 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
7674 (Fcondition_case): Document `debug' symbol in error handler.
7676 2011-08-19 Eli Zaretskii <eliz@gnu.org>
7678 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7679 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7680 from an Org mode buffer to a Speedbar frame.
7682 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7683 a composition, take its buffer position from IT->cmp_it.charpos.
7684 Fixes cursor positioning at the beginning of a line that begins
7685 with a composed character.
7687 2011-08-18 Eli Zaretskii <eliz@gnu.org>
7689 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7690 character bidirectional type, use STRONG_L instead. Fixes crashes
7691 in a buffer produced by `describe-categories'.
7693 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7694 members before the level stack, so they would be saved and
7695 restored when copying iterator state. Fixes incorrect reordering
7696 around TABs covered by display properties.
7698 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7700 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
7702 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
7704 * eval.c (internal_condition_case, internal_condition_case_1)
7705 (internal_condition_case_2, internal_condition_case_n):
7706 Remove unnecessary aborts (Bug#9081).
7708 2011-08-17 Eli Zaretskii <eliz@gnu.org>
7710 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7711 has no `load' handler, try opening the file locally. (Bug#9311)
7713 2011-08-16 Ken Brown <kbrown@cornell.edu>
7715 * gmalloc.c: Expand comment.
7717 2011-08-16 Eli Zaretskii <eliz@gnu.org>
7719 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7720 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7722 2011-08-16 Ken Brown <kbrown@cornell.edu>
7724 Fix memory allocation problems in Cygwin build (Bug#9273).
7726 * unexcw.c ( __malloc_initialized): Declare external variable.
7727 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7729 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7731 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7733 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7735 [CYGWIN] (special_realloc): New function.
7736 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7737 requests to realloc storage in the static heap.
7739 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7741 * bidi.c (bidi_initialize): Remove unused local.
7743 2011-08-15 Eli Zaretskii <eliz@gnu.org>
7746 * biditype.h: Remove file.
7747 * makefile.w32-in ($(BLD)/bidi.$(O)):
7748 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
7750 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7752 * chartab.c: Improve commentary for the uniprop_table API.
7754 * bidi.c (bidi_paragraph_init): Support zero value of
7755 bidi_ignore_explicit_marks_for_paragraph_level.
7756 (bidi_initialize): Use uniprop_table instead of including
7757 biditype.h and bidimirror.h.
7759 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7760 coordinates of the iterator when restoring from ppos_it.
7763 2011-08-14 Kenichi Handa <handa@m17n.org>
7765 * process.c (create_process): Call setup_process_coding_systems
7766 after the pid of the process is set to -1 (Bug#8162).
7768 2011-08-14 Eli Zaretskii <eliz@gnu.org>
7770 * xdisp.c (move_it_in_display_line_to): Don't invoke
7771 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7772 ppos_it. Fixes vertical cursor motion when line beginning is
7773 covered by an image. (Bug#9296)
7775 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7777 * nsterm.h (ns_run_ascript): Declare.
7778 (NSAPP_DATA2_RUNASSCRIPT): Define.
7780 * nsfns.m (as_script, as_result, as_status): New static variables.
7781 (ns_run_ascript): New function.
7782 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
7783 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7784 the event loop. Get status from as_status (Bug#7276).
7786 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7787 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7788 the event loop (Bug#7276).
7790 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7792 * gnutls.c (QCgnutls_bootprop_priority)
7793 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7794 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7795 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7796 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7797 (QCgnutls_bootprop_verify_hostname_error)
7798 (QCgnutls_bootprop_callbacks_verify): Rename from
7799 Qgnutls_bootprop_..., all uses changed.
7801 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7804 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7806 * xfaces.c (Qframe_set_background_mode): Now static.
7807 * dispextern.h (Qframe_set_background_mode): Remove decl.
7809 * process.c (Fnetwork_interface_info): Declare local only if needed.
7811 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7813 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7814 (Fnetwork_interface_list): Allocate in increments of bytes instead
7815 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7816 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7818 (struct ifflag_def): notrailers is smart on OSX.
7819 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7820 Get hardware address with getifaddrs if available.
7822 2011-08-12 Eli Zaretskii <eliz@gnu.org>
7824 * xdisp.c (iterate_out_of_display_property): xassert that
7825 IT->position is set to within IT->object's boundaries. Break from
7826 the loop as soon as EOB is reached; avoids infloops in redisplay
7827 when IT->position is set up wrongly due to some bug.
7828 Set IT->current to match the bidi iterator unconditionally.
7829 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7830 entry. Force push_it to save on the stack the current
7831 buffer/string position, to be restored by pop_it. Fix flags in
7832 the iterator structure wrt the object coming from a display
7833 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7834 properties. (Bug#9284)
7836 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
7838 * fontset.c (fontset_get_font_group): Add proper type checks.
7841 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7843 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7844 and LC_VERSION_MIN_MACOSX.
7845 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7846 (dump_it) [LC_FUNCTION_STARTS]: Use it.
7848 2011-08-08 Eli Zaretskii <eliz@gnu.org>
7850 * xdisp.c (forward_to_next_line_start): Allow to use the
7851 no-display-properties-and-no-overlays under bidi display.
7852 Set disp_pos in the bidi iterator to avoid searches for display
7853 properties and overlays.
7855 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
7857 * editfns.c (Fset_time_zone_rule): Document relationship with the
7860 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7861 the font entity extracted from the cache (Bug#8109).
7863 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
7865 * composite.c (autocmp_chars): Don't reset point. That is done by
7866 restore_point_unwind (Bug#5984).
7868 2011-08-07 Juri Linkov <juri@jurta.org>
7870 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7871 to show the arg `TIME' instead of `TIMEVAL'.
7873 2011-08-06 Eli Zaretskii <eliz@gnu.org>
7875 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7876 display property strides EOL and includes a newline, as in
7877 longlines-mode. (Bug#9254)
7878 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7879 word-wrap under bidirectional display. (Bug#9224)
7881 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7882 is non-zero, even if the data buffer is NULL. Fixes a crash in
7883 vertical-motion with longlines-mode. (Bug#9254)
7885 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7887 * bidi.c <bidi_cache_total_alloc>: Now static.
7888 (bidi_initialize): Initialize bidi_cache_total_alloc.
7890 * xdisp.c (display_line): Release buffer allocated for shelved bidi
7893 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7894 amount allocated this far in `bidi_cache_total_alloc'.
7895 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7896 non-zero, only free the data buffer without restoring the cache
7897 contents. All callers changed.
7899 * dispextern.h (bidi_unshelve_cache): Update prototype.
7901 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7902 (move_it_in_display_line, move_it_to)
7903 (move_it_vertically_backward, move_it_by_lines): Replace the call
7904 to xfree to an equivalent call to bidi_unshelve_cache.
7905 (move_it_in_display_line_to): Fix logic of returning
7906 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
7908 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7910 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7911 came from a string character with a `cursor' property. (Bug#9229)
7913 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7915 * Makefile.in (LIB_PTHREAD): New variable.
7916 (LIBES): Add LIB_PTHREAD (Bug#9216).
7918 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7919 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7921 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7923 * regex.c (re_iswctype): Remove some redundant boolean conversions.
7925 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7927 * xterm.c (x_find_topmost_parent): New function.
7928 (x_set_frame_alpha): Find topmost parent window with
7929 x_find_topmost_parent and set the property there also (bug#9181).
7930 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7932 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7934 * callproc.c (Fcall_process): Avoid vfork clobbering
7935 the local vars buffer, coding_systems, current_dir.
7937 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7939 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7941 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7943 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7944 so that it is not optimized away.
7946 * xdisp.c (compute_display_string_pos): Remove unused local.
7948 2011-08-02 Eli Zaretskii <eliz@gnu.org>
7950 Fix slow cursor motion and scrolling in large buffers with
7951 selective display, like Org Mode buffers. (Bug#9218)
7953 * dispextern.h (struct bidi_it): New member disp_prop_p.
7955 * xdisp.c: Remove one-slot cache of display string positions.
7956 (compute_display_string_pos): Accept an additional argument
7957 DISP_PROP_P; callers changed. Scan at most 5K characters forward
7958 for a display string or property. If found, set DISP_PROP_P
7961 * bidi.c (bidi_fetch_char): Accept an additional argument
7962 DISP_PROP_P, and pass it to compute_display_string_pos.
7963 Only handle text covered by a display string if DISP_PROP_P is returned
7964 non-zero. All callers of bidi_fetch_char changed.
7966 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7968 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7970 2010-12-03 Don March <don@ohspite.net>
7972 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7973 last character M-[char] is translated to ESC [char] (bug#7541).
7975 2011-08-02 Kenichi Handa <handa@m17n.org>
7977 * lisp.h (uniprop_table): Extern it.
7979 * chartab.c (uniprop_table): Make it non-static.
7981 2011-08-01 Eli Zaretskii <eliz@gnu.org>
7983 * xdisp.c (forward_to_next_line_start): Accept additional argument
7984 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7986 (reseat_at_next_visible_line_start): Use the bidi iterator state
7987 returned by forward_to_next_line_start to restore the state of
7988 it->bidi_it after backing up to previous newline. (Bug#9212)
7990 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7992 * regex.c (re_comp): Protoize.
7993 (re_exec): Fix return type.
7994 (regexec): Fix type of `ret'. (Bug#9203)
7996 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7998 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7999 This is needed if max-image-size is a floating-point number.
8001 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8003 * print.c (print_object): Print empty symbol as ##.
8005 * lread.c (read1): Read ## as empty symbol.
8007 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8009 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8010 setting frame foreground color (Bug#9175).
8011 (x_set_background_color): Likewise.
8013 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8014 contents (Bug#9176).
8015 (EmacsTooltip -init): Remove bezels and add shadows to
8018 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8019 or scroll bar (Bug#8470).
8021 * nsfont.m (nsfont_open): Remove assignment to voffset and
8022 unnecessary vars hshink, expand, hd, full_height, min_height.
8023 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8025 * nsterm.h (nsfont_info): Remove voffset field.
8027 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8029 Implement strike-through and overline on NextStep (Bug#8863).
8031 * nsfont.m (nsfont_open): Use underline position provided by font,
8032 instead of hard-coded value of 2.
8033 (nsfont_draw): Call ns_draw_text_decoration instead.
8035 * nsterm.h: Add declaration for ns_draw_text_decoration.
8037 * nsterm.m (ns_draw_text_decoration): New function for drawing
8038 underline, overline, and strike-through.
8039 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8040 ns_draw_text_decoration. Change treatment of cursor drawing to
8041 accommodate underlining, etc.
8043 2011-07-28 Eli Zaretskii <eliz@gnu.org>
8045 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8048 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8050 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8051 Without this fix, if a signal arrives just after memory fills up,
8052 'malloc' might be invoked reentrantly.
8054 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8055 In other words, assume that every image size is allowed, on non-X
8056 hosts. This assumption is probably wrong, but it lets Emacs compile.
8058 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8060 * regex.c (re_iswctype): Convert return values to boolean.
8062 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8064 * xdisp.c (compute_display_string_pos): Don't use cached display
8065 string position if the buffer had its restriction changed.
8068 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8070 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8072 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8074 Integer signedness and overflow and related fixes. (Bug#9079)
8076 * bidi.c: Integer size and overflow fixes.
8077 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8078 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8079 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8080 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8081 (bidi_find_other_level_edge):
8082 Use ptrdiff_t instead of EMACS_INT where either will do.
8083 This works better on 32-bit hosts configured --with-wide-int.
8084 (bidi_cache_ensure_space): Check for size-calculation overflow.
8085 Use % rather than repeated addition, for better worst-case speed.
8086 Don't set bidi_cache_size until after xrealloc returns, because it
8088 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
8089 (bidi_cache_ensure_space): Also check that the bidi cache size
8090 does not exceed that of the largest Lisp string or buffer. See Eli
8091 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
8093 * alloc.c (__malloc_size_t): Remove.
8094 All uses replaced by size_t. See Andreas Schwab's note
8095 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8097 * image.c: Improve checking for integer overflow.
8098 (check_image_size): Assume that f is nonnull, since
8099 it is always nonnull in practice. This is one less thing to
8100 worry about when checking for integer overflow later.
8101 (x_check_image_size): New function, which checks for integer
8102 overflow issues inside X.
8103 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8104 This removes the need for a memory_full check.
8105 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8106 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8107 (xbm_read_bitmap_data): Change locals back to 'int', since
8108 their values must fit in 'int'.
8109 (xpm_load_image, png_load, tiff_load):
8110 Invoke x_create_x_image_and_pixmap earlier,
8111 to avoid much needless work if the image is too large.
8112 (tiff_load): Treat overly large images as if
8113 x_create_x_image_and_pixmap failed, not as malloc failures.
8114 (gs_load): Use x_check_image_size.
8116 * gtkutil.c: Omit integer casts.
8117 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8118 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8120 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8122 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8123 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8124 would wrongly return t on a 64-bit host.
8126 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8127 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8128 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8129 and therefore cause GCC to emit a bogus diagnostic in some cases.
8131 * image.c: Integer signedness and overflow and related fixes.
8132 This is not an exhaustive set of fixes, but it's time to
8133 record what I've got.
8134 (lookup_pixel_color, check_image_size): Remove redundant decls.
8135 (check_image_size): Don't assume that arbitrary EMACS_INT values
8136 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8137 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8138 (tiff_load, imagemagick_load_image):
8139 Check for overflow in size calculations.
8140 (x_create_x_image_and_pixmap): Remove unnecessary test for
8141 xmalloc returning NULL; that can't happen.
8142 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8143 (xpm_color_bucket): Use better integer hashing function.
8144 (xpm_cache_color): Don't possibly over-allocate memory.
8145 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8146 (gif_memory_source):
8147 Use ptrdiff_t, not int or size_t, to record sizes.
8148 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8149 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8150 either works, as we prefer signed integers.
8151 (tiff_read_from_memory, tiff_write_from_memory):
8152 Return tsize_t, not size_t, since that's what the TIFF API wants.
8153 (tiff_read_from_memory): Don't fail simply because the read would
8154 go past EOF; instead, return a short read.
8155 (tiff_load): Omit no-longer-needed casts.
8156 (Fimagemagick_types): Don't assume size fits into 'int'.
8158 Improve hashing quality when configured --with-wide-int.
8159 * fns.c (hash_string): New function, taken from sxhash_string.
8160 Do not discard information about ASCII character case; this
8161 discarding is no longer needed.
8162 (sxhash-string): Use it. Change sig to match it. Caller changed.
8163 * lisp.h: Declare it.
8164 * lread.c (hash_string): Remove, since we now use fns.c's version.
8165 The fns.c version returns a wider integer if --with-wide-int is
8166 specified, so this should help the quality of the hashing a bit.
8168 * emacs.c: Integer overflow minor fix.
8169 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8170 Define only if GNU_LINUX.
8171 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8173 * dispnew.c: Integer signedness and overflow fixes.
8174 Remove unnecessary forward decls, that were a maintenance hassle.
8175 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8177 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8178 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8179 (prepare_desired_row, line_draw_cost):
8180 Use int, not unsigned, where either works.
8181 (save_current_matrix, restore_current_matrix):
8182 Use ptrdiff_t, not size_t, where either works.
8183 (init_display): Check for overflow more accurately, and without
8184 relying on undefined behavior.
8186 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8187 Remove, replacing with the new symbols in lisp.h. All uses changed.
8188 * fileio.c (make_temp_name):
8189 * filelock.c (lock_file_1, lock_file):
8190 * xdisp.c (message_dolog):
8191 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8192 Use pMd etc. instead.
8193 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8194 replacing the pWIDE etc. symbols removed from editfns.c.
8196 * keyboard.h (num_input_events): Now uintmax_t.
8197 This is (very slightly) less likely to mess up due to wraparound.
8200 * buffer.c: Integer signedness fixes.
8201 (alloc_buffer_text, enlarge_buffer_text):
8202 Use ptrdiff_t rather than size_t when either will do, as we prefer
8205 * alloc.c: Integer signedness and overflow fixes.
8206 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8207 (__malloc_size_t): Default to size_t, not to int.
8208 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8209 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8210 Prefer ptrdiff_t to size_t when either would do, as we prefer
8212 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8213 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8214 Now const. Initialize with values that are in range even if char
8216 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8217 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8218 These functions do the right thing with sizes > 2**32.
8219 (check_depth): Now ptrdiff_t, not int.
8220 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8221 Adjust to new way of storing sizes. Check for size overflow bugs
8223 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8224 slightly wrong anyway, as it missed one instance of
8225 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8226 (refill_memory_reserve): Omit needless cast to size_t.
8227 (mark_object_loop_halt): Mark as externally visible.
8229 * xselect.c: Integer signedness and overflow fixes.
8230 (Fx_register_dnd_atom, x_handle_dnd_message):
8231 Use ptrdiff_t, not size_t, since we prefer signed.
8232 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8233 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8234 x_dnd_atoms_size and x_dnd_atoms_length.
8236 * doprnt.c: Prefer signed to unsigned when either works.
8238 * doprnt.c (doprnt):
8240 * xdisp.c (vmessage):
8241 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8242 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8243 prefer signed arithmetic to avoid comparison confusion.
8244 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8245 but is a bit tricky.
8247 Assume freestanding C89 headers, string.h, stdlib.h.
8248 * data.c, doprnt.c, floatfns.c, print.c:
8249 Include float.h unconditionally.
8250 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8251 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8252 * regex.c: Likewise for stddef.h, string.h.
8253 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8254 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8255 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8256 (STDC_HEADERS): Remove obsolete defines.
8257 * sysdep.c: Include limits.h unconditionally.
8259 Assume support for memcmp, memcpy, memmove, memset.
8260 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8261 * regex.c (memcmp, memcpy):
8262 Remove; we assume C89 now.
8264 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8265 (__malloc_safe_bcopy): Remove; no longer needed.
8267 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
8268 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8269 well either way, and we prefer signed to unsigned.
8271 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8273 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8274 closes the connection while we're reading (bug#9182).
8276 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
8278 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8279 are specified (Bug#9168).
8281 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8283 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8284 Found by GCC static checking and --with-wide-int on a 32-bit host.
8286 2011-07-25 Eli Zaretskii <eliz@gnu.org>
8288 * xdisp.c (compute_display_string_pos): Fix logic of caching
8289 previous display string position. Initialize cached_prev_pos to
8290 -1. Fixes slow-down at the beginning of a buffer.
8292 2011-07-24 Eli Zaretskii <eliz@gnu.org>
8294 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8295 for attrs[LFACE_FONTSET_INDEX].
8297 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8299 * xml.c (parse_region): Remove unused local
8300 that was recently introduced.
8302 2011-07-23 Eli Zaretskii <eliz@gnu.org>
8304 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8305 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8307 * xdisp.c (move_it_in_display_line_to): Record the best matching
8308 position for TO_CHARPOS while scanning the line, and restore it on
8309 exit if none of the characters scanned was an exact match.
8310 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
8311 when exact match is impossible due to invisible text, and the
8312 lines are truncated.
8314 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8316 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8319 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8321 Fix a significant slow-down of cursor motion with C-n, C-p,
8322 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8323 auto-repeat under bidi redisplay in fontified buffers.
8324 * xdisp.c (compute_stop_pos_backwards): New function.
8325 (next_element_from_buffer): Call compute_stop_pos_backwards to
8326 find a suitable prev_stop when we find ourselves before
8328 (reseat): Don't look for prev_stop, as that could mean a very long
8330 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8331 <cached_disp_overlay_modiff>: Cache for last found display string
8333 (compute_display_string_pos): Return the cached position if asked
8334 about the same buffer in the same area of character positions, and
8335 the buffer wasn't changed since the time the display string
8336 position was cached.
8338 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8340 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8341 is an integer, which is important for empty lines. (Bug#9149)
8343 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
8345 * frame.c (Fmodify_frame_parameters): In tty case, update the
8346 default face if necessary (Bug#4238).
8348 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
8350 * editfns.c (Fstring_to_char): No need to explain what a character
8351 is in the docstring (Bug#6576).
8353 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8355 * xml.c (parse_region): Make sure we always return a tree.
8357 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8359 * xml.c (parse_region): If a document contains only comments,
8362 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8364 * xml.c (make_dom): Return comments, too.
8366 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8369 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8370 and the surrounding thread.
8371 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8372 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8373 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8375 * s/openbsd.h (BROKEN_SIGIO): Define.
8376 * unexelf.c (unexec) [__OpenBSD__]:
8377 Don't update the .mdebug section of the Alpha COFF symbol table.
8379 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8381 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8384 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8386 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8387 This fixes some race conditions on the permissions of any newly
8390 * alloc.c (valid_pointer_p): Use pipe, not open.
8391 This fixes some permissions issues when debugging.
8393 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8394 If fchown fails to set both uid and gid, try to set just gid,
8395 as that is sometimes allowed. Adjust the file's mode to eliminate
8396 setuid or setgid bits that are inappropriate if fchown fails.
8398 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8400 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8401 to compare Lisp_Objects.
8402 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8403 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8404 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8406 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8408 * lread.c (read_integer): Unread even EOF character.
8409 (read1): Likewise. Properly record start position of symbol.
8411 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8412 symbol character follows.
8414 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8416 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8417 This works around a problem with the previous change to Fcopy_file.
8418 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8419 and without this change, GCC might complain about discarding
8420 fchown's return value.
8422 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
8424 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8426 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8428 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8430 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8432 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8433 it's used from the C level.
8435 * process.c: Use the same condition for POLL_FOR_INPUT in both
8436 keyboard.c and process.c (bug#1858).
8438 2011-07-09 Lawrence Mitchell <wence@gmx.li>
8440 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8441 (Fgnutls_boot): Use it.
8443 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8445 * doc.c (Fsubstitute_command_keys): Revert last change.
8447 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8449 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8450 quotes the next character, and doesn't affect other longer
8451 sequences (bug#8935).
8453 * lread.c (syms_of_lread): Clarify that is isn't only
8454 `eval-buffer' and `eval-defun' that's affected by
8455 `lexical-binding' (bug#8460).
8457 2011-07-15 Eli Zaretskii <eliz@gnu.org>
8459 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
8460 bidi redisplay when a line includes both an image and is truncated.
8462 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8464 Fix minor problems found by static checking.
8465 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8466 (elsz): Now a signed constant, not a size_t var. We prefer signed
8467 types to unsigned, to avoid integer comparison confusion. Without
8468 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8469 "cannot optimize loop, the loop counter may overflow", a symptom
8471 * indent.c (Fvertical_motion): Mark locals as initialized.
8472 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8474 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8476 * search.c (Fre_search_backward): Mention `case-fold-search' in
8477 all the re_search_* functions (bug#8138).
8479 * keyboard.c (Fopen_dribble_file): Document when the file is
8482 2011-07-14 Eli Zaretskii <eliz@gnu.org>
8484 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8487 Support bidi reordering of display and overlay strings.
8488 * xdisp.c (compute_display_string_pos)
8489 (compute_display_string_end): Accept additional argument STRING.
8490 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8491 (reseat_to_string): Initialize bidi_it->string.s and
8492 bidi_it->string.schars.
8493 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
8494 NULL (avoids a crash in bidi_paragraph_init).
8495 Initialize itb.string.lstring.
8496 (init_iterator): Call bidi_init_it only of a valid
8497 buffer position was specified. Initialize paragraph_embedding to
8499 (reseat_to_string): Initialize the bidi iterator.
8500 (display_string): If we need to ignore text properties of
8501 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8502 original value of -1 will not work with bidi.)
8503 (compute_display_string_pos): First arg is now struct
8504 `text_pos *'; all callers changed. Support display properties on
8506 (compute_display_string_end): Support display properties on Lisp
8508 (init_iterator, reseat_1, reseat_to_string): Initialize the
8509 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8510 when iterating on a string not from display properties).
8511 (compute_display_string_pos, compute_display_string_end):
8512 Fix calculation of the object to scan. Fixes an error when using
8514 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
8515 base_level_stop; instead, set base_level_stop to BEGV.
8516 Fixes crashes in vertical-motion.
8517 (next_element_from_buffer): Improve commentary for when
8518 the iterator is before prev_stop.
8519 (init_iterator): Initialize bidi_p from the default value of
8520 bidi-display-reordering, not from buffer-local value. Use the
8521 buffer-local value only if initializing for buffer iteration.
8522 (handle_invisible_prop): Support invisible properties on strings
8523 that are being bidi-reordered.
8524 (set_iterator_to_next): Support bidi reordering of C strings and
8526 (next_element_from_string): Support bidi reordering of Lisp
8528 (handle_stop_backwards): Support Lisp strings as well.
8529 (display_string): Support display of R2L glyph rows.
8530 Use IT_STRING_CHARPOS when displaying from a Lisp string.
8531 (init_iterator): Don't initialize it->bidi_p for strings
8533 (reseat_to_string): Initialize it->bidi_p for strings here.
8534 (next_element_from_string, next_element_from_c_string)
8535 (next_element_from_buffer): Add xassert's for correspondence
8536 between IT's object being iterated and it->bidi_it.string
8538 (face_before_or_after_it_pos): Support bidi iteration.
8539 (next_element_from_c_string): Handle the case of the first string
8540 character that is not the first one in the visual order.
8541 (get_visually_first_element): New function, refactored from common
8542 parts of next_element_from_buffer, next_element_from_string, and
8543 next_element_from_c_string.
8544 (tool_bar_lines_needed, redisplay_tool_bar)
8545 (display_menu_bar): Force left-to-right direction. Add a FIXME
8546 comment for making that be controlled by a user option.
8547 (push_it, pop_it): Save and restore the state of the
8548 bidi iterator. Save and restore the bidi_p flag.
8549 (pop_it): Iterate out of display property for string iteration as
8551 (iterate_out_of_display_property): Support iteration over strings.
8552 (handle_single_display_spec): Set up it->bidi_it for iteration
8553 over a display string, and call bidi_init_it.
8554 (handle_single_display_spec, next_overlay_string)
8555 (get_overlay_strings_1, push_display_prop): Set up the bidi
8556 iterator for displaying display or overlay strings.
8557 (forward_to_next_line_start): Don't use the shortcut if
8559 (back_to_previous_visible_line_start): If handle_display_prop
8560 pushed the iterator stack, restore the internal state of the bidi
8561 iterator by calling bidi_pop_it same number of times.
8562 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8563 and we are bidi-iterating, don't decrement the iterator position;
8564 instead, set the first_elt flag in the bidi iterator, to produce
8566 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8567 (push_display_prop): xassert that we are iterating a buffer.
8568 (push_it, pop_it): Save and restore paragraph_embedding member.
8569 (handle_single_display_spec, next_overlay_string)
8570 (get_overlay_strings_1, reseat_1, reseat_to_string)
8571 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8572 correctly. Don't assume unibyte strings are not bidi-reordered.
8573 (compute_display_string_pos)
8574 (compute_display_string_end): Fix handling the case of C string.
8575 (push_it, pop_it): Save and restore from_disp_prop_p.
8576 (handle_single_display_spec, push_display_prop): Set the
8577 from_disp_prop_p flag.
8578 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8579 (pop_it): Call iterate_out_of_display_property only if we are
8580 popping after iteration over a string that came from a display
8581 property. Fix a typo in popping stretch info. Add an assertion
8582 for verifying that the iterator position is in sync with the bidi
8584 (handle_single_display_spec, get_overlay_strings_1)
8585 (push_display_prop): Fix initialization of paragraph direction for
8586 string when that of the parent object is not yet determined.
8587 (reseat_1): Call bidi_init_it to resync the bidi
8588 iterator with IT's position. (Bug#7616)
8589 (find_row_edges): If ROW->start.pos gives position
8590 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8591 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8592 Reset the from_disp_prop_p flag.
8593 (SAVE_IT, RESTORE_IT): New macros.
8594 (pos_visible_p, face_before_or_after_it_pos)
8595 (back_to_previous_visible_line_start)
8596 (move_it_in_display_line_to, move_it_in_display_line)
8597 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8598 (try_scrolling, redisplay_window, display_line): Use them when
8599 saving a temporary copy of the iterator and restoring it back.
8600 (back_to_previous_visible_line_start, reseat_1)
8601 (init_iterator): Empty the bidi cache "stack".
8602 (move_it_in_display_line_to): If iterator ended up at
8603 EOL, but we never saw any buffer positions smaller than
8604 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8605 motion in bidi-reordered lines.
8606 (move_it_in_display_line_to): Record prev_method and prev_pos
8607 immediately before the call to set_iterator_to_next. Fixes cursor
8608 motion in bidi-reordered lines with stretch glyphs and strings
8609 displayed in margins. (Bug#8133) (Bug#8867)
8610 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8612 (pos_visible_p): Support positions in bidi-reordered lines.
8613 Save and restore bidi cache.
8615 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8616 (bidi_paragraph_info): Delete unused struct.
8617 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8618 (bidi_cache_start): New variable.
8619 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8621 (bidi_cache_fetch_state, bidi_cache_search)
8622 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8623 (bidi_cache_find, bidi_peek_at_next_level)
8624 (bidi_level_of_next_char, bidi_find_other_level_edge)
8625 (bidi_move_to_visually_next): Compare cache index with
8626 bidi_cache_start rather than with zero.
8627 (bidi_fetch_char): Accept new argument STRING; all callers
8628 changed. Support iteration over a string. Support strings with
8629 display properties. Support unibyte strings. Fix the type of
8630 `len' according to what STRING_CHAR_AND_LENGTH expects.
8631 (bidi_paragraph_init, bidi_resolve_explicit_1)
8632 (bidi_resolve_explicit, bidi_resolve_weak)
8633 (bidi_level_of_next_char, bidi_move_to_visually_next):
8634 Support iteration over a string.
8635 (bidi_set_sor_type, bidi_resolve_explicit_1)
8636 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8637 can now be zero (for strings); special values 0 and -1 were
8638 changed to -1 and -2, respectively.
8639 (bidi_char_at_pos): New function.
8640 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8641 Call it instead of FETCH_MULTIBYTE_CHAR.
8642 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8643 initialized to valid values.
8644 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8646 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8647 the test for valid cached positions. Fix the logic for looking up
8648 the sentinel state in the cache. GCPRO the Lisp string we are
8650 (bidi_push_it, bidi_pop_it): New functions.
8651 (bidi_initialize): Initialize the bidi cache start stack pointer.
8652 (bidi_cache_ensure_space): New function, refactored from part of
8653 bidi_cache_iterator_state. Don't assume the required size is just
8654 one BIDI_CACHE_CHUNK away.
8655 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8656 (bidi_count_bytes, bidi_char_at_pos): New functions.
8657 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8658 always valid if bidi_cache_idx is valid.
8659 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8660 is valid if it's going to be used.
8661 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8662 (bidi_cache_fetch_state, bidi_cache_search)
8663 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8664 (bidi_cache_iterator_state, bidi_cache_find)
8665 (bidi_find_other_level_edge, bidi_cache_start_stack):
8666 All variables related to cache indices are now EMACS_INT.
8668 * dispextern.h (struct bidi_string_data): New structure.
8669 (struct bidi_it): New member `string'. Make flag members be 1-bit
8670 fields, and put them last in the struct.
8671 (compute_display_string_pos, compute_display_string_end):
8673 (bidi_push_it, bidi_pop_it): Add prototypes.
8674 (struct iterator_stack_entry): New members bidi_p,
8675 paragraph_embedding, and from_disp_prop_p.
8676 (struct it): Member bidi_p is now a bit field 1 bit wide.
8677 (bidi_shelve_cache, bidi_unshelve_cache):
8680 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8681 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8682 and vector-like objects.
8684 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8685 cache around display iteration.
8687 * window.c (Fwindow_end, window_scroll_pixel_based)
8688 (displayed_window_lines, Frecenter): Save and restore the bidi
8689 cache around display iteration.
8691 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8693 * editfns.c (Fdelete_region): Clarify the use of the named
8694 parameters (bug#6788).
8696 2011-07-14 Martin Rudalics <rudalics@gmx.at>
8698 * indent.c (Fvertical_motion): Set and restore w->pointm when
8699 saving and restoring the window's buffer (Bug#9006).
8701 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8703 * editfns.c (Fstring_to_char): Clarify just what is returned
8704 (bug#6576). Text by Eli Zaretskii.
8706 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
8708 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8710 2011-07-13 Eli Zaretskii <eliz@gnu.org>
8712 * buffer.c (mmap_find): Fix a typo.
8714 2011-07-13 Johan Bockgård <bojohan@gnu.org>
8716 Fix execution of x selection hooks.
8717 * xselect.c (Qx_lost_selection_functions)
8718 (Qx_sent_selection_functions): New vars.
8719 (syms_of_xselect): DEFSYM them.
8720 (x_handle_selection_request): Pass Qx_sent_selection_functions
8721 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8722 (x_handle_selection_clear,x_clear_frame_selections):
8723 Pass Qx_lost_selection_functions rather than
8724 Vx_lost_selection_functions to Frun_hook_with_args.
8726 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8728 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
8729 The old code sometimes used this field without initializing it.
8731 * alloc.c (gc_sweep): Don't read past end of array.
8732 In theory, the old code could also have corrupted Emacs internals,
8733 though it'd be very unlikely.
8735 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8737 * character.c (Fcharacterp): Don't advertise optional ignored
8738 argument. (Bug#4026)
8740 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8742 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8745 * window.c (Fset_window_start): Doc fix (bug#4199).
8746 (Fset_window_hscroll): Ditto.
8748 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8750 Fix minor new problems caught by GCC 4.6.1.
8751 * term.c (init_tty): Remove unused local.
8752 * xsettings.c (store_monospaced_changed): Define this function only
8753 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
8756 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
8758 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8760 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8762 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8763 are the mini-buffer and the echo area (bug#3320).
8765 * term.c (init_tty): Remove support for supdup, c10 and perq
8766 terminals, which are no longer supported (bug#1482).
8768 2011-07-10 Johan Bockgård <bojohan@gnu.org>
8770 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8772 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8774 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8775 for non-popups (Bug#3642).
8777 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8779 * alloc.c (reset_malloc_hooks): Protoize.
8780 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
8781 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8782 * cm.c (losecursor): Likewise.
8783 * data.c (fmod): Likewise.
8784 * dispnew.c (swap_glyphs_in_rows): Likewise.
8785 * emacs.c (memory_warning_signal): Likewise.
8786 * floatfns.c (float_error): Likewise.
8787 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8788 (otf_open, font_otf_capability, generate_otf_features)
8789 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8791 * image.c (pbm_read_file): Likewise.
8792 * indent.c (string_display_width): Likewise.
8793 * intervals.c (check_for_interval, search_for_interval)
8794 (inc_interval_count, count_intervals, root_interval)
8795 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8796 * lread.c (defalias): Likewise.
8797 * ralloc.c (r_alloc_check): Likewise.
8798 * regex.c (set_image_of_range_1, set_image_of_range)
8799 (regex_grow_registers): Likewise.
8800 * sysdep.c (strerror): Likewise.
8801 * termcap.c (valid_filename_p, tprint, main): Likewise.
8802 * tparam.c (main): Likewise.
8803 * unexhp9k800.c (run_time_remap, save_data_space)
8804 (update_file_ptrs, read_header, write_header, calculate_checksum)
8805 (copy_file, copy_rest, display_header): Likewise.
8806 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8808 * xdisp.c (check_it): Likewise.
8809 * xfaces.c (register_color, unregister_color, unregister_colors):
8811 * xfns.c (print_fontset_result): Likewise.
8812 * xrdb.c (member, fatal, main): Likewise.
8814 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8816 Fix minor problems found by static checking (Bug#9031).
8817 * chartab.c (char_table_set_range, map_sub_char_table):
8818 Remove unused locals.
8819 (uniprop_table): Now static.
8820 * composite.c (_work_char): Remove unused static var.
8822 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
8824 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8826 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8828 * gtkutil.c (qttip_cb): Remove code without function.
8830 2011-07-09 Eli Zaretskii <eliz@gnu.org>
8832 * w32.c (pthread_sigmask): New stub.
8834 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
8836 Use pthread_sigmask, not sigprocmask (Bug#9010).
8837 sigprocmask is portable only for single-threaded applications, and
8838 Emacs can be multi-threaded when it uses GTK.
8839 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8841 * callproc.c (Fcall_process):
8842 * process.c (create_process):
8843 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8844 Use pthread_sigmask, not sigprocmask.
8846 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8848 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8849 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8852 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8854 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8855 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8856 (xg_hide_tooltip): Fix comment.
8858 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8859 in registerServicesMenuSendTypes.
8860 (validRequestorForSendType): Don't check ns_return_types.
8862 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8865 2011-07-08 Jason Rumney <jasonr@gnu.org>
8867 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8868 SH_SHOW for hidden windows (Bug#5482).
8870 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8871 frame struct members of non-existent frames (Bug#6284).
8873 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8875 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8876 variable firstTime not needed on OSX >= 10.6.
8877 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8878 >= 10.5. Use setKnobProportion, setDoubleValue.
8880 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8881 (MAC_OS_X_VERSION_10_5): Define if not defined.
8882 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8883 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8884 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8886 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
8887 cString and lossyCString on OSX >= 10.4.
8889 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
8890 sizeToFit on OSX >= 10.2.
8892 * nsimage.m (allocInitFromFile): Don't use deprecated method
8893 bestRepresentationForDevice on OSX >= 10.6.
8895 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8898 * emacs.c: Declare unexec_init_emacs_zone.
8900 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8902 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8904 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8905 on svcsMenu (Bug#8842).
8907 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8909 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8911 * nsterm.m (QUTF8_STRING): Declare.
8912 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8913 (validRequestorForSendType): Return type is (id).
8914 Change indexOfObjectIdenticalTo to indexOfObject.
8915 Check if we have local selection before returning self (Bug#8842).
8916 (writeSelectionToPasteboard): Put local selection into paste board
8917 if we have a local selection (Bug#8842).
8918 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8920 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8921 (ns_get_local_selection): Declare.
8923 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8925 * keymap.c (describe_map_tree): Don't insert a double newline at
8926 the end of the buffer (bug#1169) and return whether we inserted
8929 * callint.c (Fcall_interactively): Change "reading args" to
8930 "providing args" to try to clarify what it does (bug#1010).
8932 2011-07-07 Kenichi Handa <handa@m17n.org>
8934 * composite.c (composition_compute_stop_pos): Ignore a static
8935 composition starting before CHARPOS (Bug#8915).
8937 * xdisp.c (handle_composition_prop): Likewise.
8939 2011-07-07 Eli Zaretskii <eliz@gnu.org>
8941 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8944 2011-07-07 Kenichi Handa <handa@m17n.org>
8946 * character.h (unicode_category_t): New enum type.
8948 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8949 (Qchar_code_property_table): New variable.
8950 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8951 (UNIPROP_COMPRESSED_FORM_P): New macros.
8952 (char_table_ascii): Uncompress the compressed values.
8953 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8954 Uncompress the compressed values.
8955 (sub_char_table_ref_and_range): Likewise.
8956 (char_table_ref_and_range): Uncompress the compressed values.
8957 (sub_char_table_set): New arg is_uniprop. Callers changed.
8958 Uncompress the compressed values.
8959 (sub_char_table_set_range): Args changed. Callers changed.
8960 (char_table_set_range): Adjuted for the above change.
8961 (map_sub_char_table): Delete args default_val and parent. Add arg
8962 top. Give decoded values to a Lisp function.
8963 (map_char_table): Adjust for the above change. Give decoded
8964 values to a Lisp function. Gcpro more variables.
8965 (uniprop_table_uncompress)
8966 (uniprop_decode_value_run_length): New functions.
8967 (uniprop_decoder, uniprop_decoder_count): New variables.
8968 (uniprop_get_decoder, uniprop_encode_value_character)
8969 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8971 (uniprop_encoder, uniprop_encoder_count): New variables.
8972 (uniprop_get_encoder, uniprop_table)
8973 (Funicode_property_table_internal, Fget_unicode_property_internal)
8974 (Fput_unicode_property_internal): New functions.
8975 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8976 Sunicode_property_table_internal, Sget_unicode_property_internal,
8977 and Sput_unicode_property_internal. Defvar_lisp
8978 char-code-property-alist.
8980 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
8981 Vunicode_category_table.
8983 * font.c (font_range): Adjust for the change of
8984 Vunicode_category_table.
8986 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8988 * m/iris4d.h: Remove file, move contents ...
8989 * s/irix6-5.h: ... here.
8991 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8993 Remove unportable assumption about struct layout (Bug#8884).
8994 * alloc.c (mark_buffer):
8995 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8996 (clone_per_buffer_values): Don't assume that
8997 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8998 This isn't true in general, and it's particularly not true
8999 if Emacs is configured with --with-wide-int.
9000 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9001 New macros, used in the buffer.c change.
9003 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9005 * xsettings.c: Use both GConf and GSettings if both are available.
9006 (store_config_changed_event): Add comment.
9007 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9008 (store_tool_bar_style_changed): New functions.
9009 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
9010 (struct xsettings): Move font inside HAVE_XFT.
9011 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
9012 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
9013 Move inside HAVE_XFT.
9014 (something_changed_gsettingsCB): Rename from something_changedCB.
9015 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9017 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
9018 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
9019 (something_changed_gconfCB): Rename from something_changedCB.
9020 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9021 (parse_settings): Move check for font inside HAVE_XFT.
9022 (read_settings, apply_xft_settings): Add comment.
9023 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9024 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9025 call store_font_name_changed.
9026 (xft_settings_event): Add comment.
9027 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9028 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9029 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9030 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9031 (xsettings_initialize): Call init_gsettings last.
9032 (xsettings_get_system_font, xsettings_get_system_normal_font):
9035 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9037 Random fixes. E.g., (random) never returned negative values.
9038 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9039 subseconds part to the entropy, as that's a bit more random.
9040 Prefer signed to unsigned, since the signedness doesn't matter and
9041 in general we prefer signed. When given a limit, use a
9042 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9043 latter isn't right if USE_2_TAGS_FOR_INTS.
9044 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9045 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9047 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9049 * textprop.c (text_property_stickiness):
9050 Obey Vtext_property_default_nonsticky.
9051 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9052 * w32fns.c (syms_of_w32fns):
9053 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9055 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9057 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9058 This is more efficient than Ffile_directory_p and avoids a minor race.
9060 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9062 * buffer.c (Foverlay_put): Say what the return value is
9065 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9066 is a directory before asking whether to use the file name
9068 (barf_or_query_if_file_exists): Make the "File is a directory"
9069 error be more correct.
9071 * fns.c (Frequire): Remove the mention of the .gz files, since
9072 that's installation-specific, but keep the mention of
9073 `get-load-suffixes'.
9075 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9077 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9078 Report string overflow if the output is too long.
9080 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
9082 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9083 (syms_of_gnutls): Remove duplicate DEFSYM for
9084 Qgnutls_bootprop_verify_hostname_error, an error for
9085 Qgnutls_bootprop_verify_error (which is no longer used).
9087 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9088 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9089 Also (re)move comments that are misplaced or no longer relevant.
9091 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9093 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9095 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
9097 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9098 and background color parameters if they have been changed.
9100 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9102 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9104 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9106 * xsettings.c (SYSTEM_FONT): Define only when used.
9107 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9109 * keymap.c (access_keymap_1): Now static.
9111 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
9113 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9114 leave any prefix arg for the up event (Bug#1586).
9116 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9118 * lread.c (syms_of_lread): Mention single symbols defined by
9119 `defvar' or `defconst' (bug#7154).
9121 * fns.c (Frequire): Mention .el.gz files (bug#7314).
9122 (Frequire): Mention get-load-suffixes.
9124 2011-07-02 Martin Rudalics <rudalics@gmx.at>
9126 * window.h (window): Remove clone_number slot.
9127 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9129 (make_parent_window, make_window, saved_window)
9130 (Fset_window_configuration, save_window_save): Don't deal with
9132 * buffer.c (Qclone_number): Remove declaration.
9133 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9135 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9137 Add multiple inheritance to keymaps.
9138 * keymap.c (Fmake_composed_keymap): New function.
9139 (Fset_keymap_parent): Simplify.
9140 (fix_submap_inheritance): Remove.
9141 (access_keymap_1): New function extracted from access_keymap to handle
9142 embedded parents and handle lists of maps.
9143 (access_keymap): Use it.
9144 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9145 (Fcopy_keymap): Handle embedded parents.
9146 (Fcommand_remapping, define_as_prefix): Simplify.
9147 (Fkey_binding): Simplify.
9148 (syms_of_keymap): Move minibuffer-local-completion-map,
9149 minibuffer-local-filename-completion-map,
9150 minibuffer-local-must-match-map, and
9151 minibuffer-local-filename-must-match-map to Elisp.
9152 (syms_of_keymap): Defsubr make-composed-keymap.
9153 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9154 (parse_menu_item): Trivial simplification.
9156 2011-07-01 Glenn Morris <rgm@gnu.org>
9158 * Makefile.in (SETTINGS_LIBS): Fix typo.
9160 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9162 * coding.c (Fencode_coding_string): Record the last coding system
9163 used, as the function doc string says (bug#8738).
9165 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9167 * xsettings.c (store_monospaced_changed): Take new font as arg and
9168 check for change against current_mono_font.
9169 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9170 (emacs_settings_constructor, emacs_settings_get_property)
9171 (emacs_settings_set_property, emacs_settings_class_init)
9172 (emacs_settings_init, gsettings_obj): Remove.
9173 (something_changedCB): New function for HAVE_GSETTINGS.
9174 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9175 with value as argument.
9176 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9177 g_settings_new (Bug#8967). Do not create gsettings_obj.
9178 Remove calls to g_settings_bind. Connect something_changedCB to
9181 * xgselect.c: Add defined (HAVE_GSETTINGS).
9182 (xgselect_initialize): Ditto.
9184 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9185 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9188 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9190 * eval.c (struct backtrace): Simplify and port the data structure.
9191 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9192 signed bit field, as this assumption is not portable and it makes
9193 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9194 "char debug_on_exit : 1" as this is not portable either; instead,
9195 use the portable "unsigned int debug_on_exit : 1". Remove unused
9196 member evalargs. Remove obsolete comments about cc bombing out.
9198 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9200 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9201 Let HAVE_GSETTINGS override HAVE_GCONF.
9202 (store_monospaced_changed): New function.
9203 (EMACS_SETTINGS): A new type derived from GObject to handle
9204 GSettings notifications.
9205 (emacs_settings_constructor, emacs_settings_get_property)
9206 (emacs_settings_set_property, emacs_settings_class_init):
9208 (gsettings_client, gsettings_obj): New variables.
9209 (GSETTINGS_SCHEMA): New define.
9210 (something_changedCB): Call store_monospaced_changed.
9211 (init_gsettings): New function.
9212 (xsettings_initialize): Call init_gsettings.
9213 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9216 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9219 2011-06-29 Martin Rudalics <rudalics@gmx.at>
9221 * window.c (resize_root_window, grow_mini_window)
9222 (shrink_mini_window): Rename Qresize_root_window to
9223 Qwindow_resize_root_window and Qresize_root_window_vertically to
9224 Qwindow_resize_root_window_vertically.
9226 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9228 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9230 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
9232 * makefile.w32-in: Redesign dependencies so they reflect more
9233 clearly which files are directly included by each source file,
9234 and not through other includes.
9236 2011-06-27 Martin Rudalics <rudalics@gmx.at>
9238 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9239 (sort_overlays, overlay_strings): When an overlay's clone number
9240 matches the window's clone number process the overlay even if
9241 the overlay's window property doesn't match the current window.
9243 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9244 (Fwindow_hchild): Rename to Fwindow_left_child.
9245 (Fwindow_next): Rename to Fwindow_next_sibling.
9246 (Fwindow_prev): Rename to Fwindow_prev_sibling.
9247 (resize_window_check): Rename to window_resize_check.
9248 (resize_window_apply): Rename to window_resize_apply.
9249 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9250 (Fdelete_other_windows_internal, resize_frame_windows)
9251 (Fsplit_window_internal, Fdelete_window_internal)
9252 (grow_mini_window, shrink_mini_window)
9253 (Fresize_mini_window_internal): Fix callers accordingly.
9255 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9257 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9258 (emacs_fixed_set_min_size): Remove.
9259 (emacs_fixed_new): Take frame as argument.
9261 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9262 (_EmacsFixedPrivate): Remove minwidth/height.
9263 Add struct frame *f.
9264 (emacs_fixed_init): Initialize priv->f.
9265 (get_parent_class, emacs_fixed_set_min_size): Remove.
9266 (emacs_fixed_new): Set priv->f to argument.
9267 (emacs_fixed_get_preferred_width)
9268 (emacs_fixed_get_preferred_height): Use min_width/height from
9269 frames size_hint to set minimum and natural (Bug#8919).
9270 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9271 and use min_width/height from frames size_hint to set
9272 min_width/height (Bug#8919).
9274 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9275 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9278 2011-06-26 Eli Zaretskii <eliz@gnu.org>
9280 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9281 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9284 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
9286 * process.c (wait_reading_process_output): Bypass select if
9287 waiting for a cell while ignoring keyboard input, and input is
9288 pending. Suggested by Jan Djärv (Bug#8869).
9290 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9292 Use gnulib's dup2 module instead of rolling our own.
9293 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9295 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9297 * dispnew.c (scrolling_window): Before scrolling, turn off a
9298 mouse-highlight in the window being scrolled.
9300 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
9302 Move DEFSYM to lisp.h and use everywhere.
9304 * character.h (DEFSYM): Move declaration...
9305 * lisp.h (DEFSYM): ...here.
9311 * w32select.c: Don't include character.h.
9313 * alloc.c (syms_of_alloc):
9314 * buffer.c (syms_of_buffer):
9315 * bytecode.c (syms_of_bytecode):
9316 * callint.c (syms_of_callint):
9317 * casefiddle.c (syms_of_casefiddle):
9318 * casetab.c (init_casetab_once):
9319 * category.c (init_category_once, syms_of_category):
9320 * ccl.c (syms_of_ccl):
9321 * cmds.c (syms_of_cmds):
9322 * composite.c (syms_of_composite):
9323 * dbusbind.c (syms_of_dbusbind):
9324 * dired.c (syms_of_dired):
9325 * dispnew.c (syms_of_display):
9326 * doc.c (syms_of_doc):
9327 * editfns.c (syms_of_editfns):
9328 * emacs.c (syms_of_emacs):
9329 * eval.c (syms_of_eval):
9330 * fileio.c (syms_of_fileio):
9331 * fns.c (syms_of_fns):
9332 * frame.c (syms_of_frame):
9333 * fringe.c (syms_of_fringe):
9334 * insdel.c (syms_of_insdel):
9335 * keymap.c (syms_of_keymap):
9336 * lread.c (init_obarray, syms_of_lread):
9337 * macros.c (syms_of_macros):
9338 * msdos.c (syms_of_msdos):
9339 * print.c (syms_of_print):
9340 * process.c (syms_of_process):
9341 * search.c (syms_of_search):
9342 * sound.c (syms_of_sound):
9343 * syntax.c (init_syntax_once, syms_of_syntax):
9344 * terminal.c (syms_of_terminal):
9345 * textprop.c (syms_of_textprop):
9346 * undo.c (syms_of_undo):
9347 * w32.c (globals_of_w32):
9348 * window.c (syms_of_window):
9349 * xdisp.c (syms_of_xdisp):
9350 * xfaces.c (syms_of_xfaces):
9351 * xfns.c (syms_of_xfns):
9352 * xmenu.c (syms_of_xmenu):
9353 * xsettings.c (syms_of_xsettings):
9354 * xterm.c (syms_of_xterm): Use DEFSYM.
9356 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9358 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
9360 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9362 Integer and buffer overflow fixes (Bug#8873).
9364 * print.c (printchar, strout): Check for string overflow.
9365 (PRINTPREPARE, printchar, strout):
9366 Don't set size unless allocation succeeds.
9368 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9369 for sizes. Check for string overflow more accurately.
9370 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9372 * macros.c: Integer and buffer overflow fixes.
9373 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9374 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9375 Use ptrdiff_t, not int, for sizes.
9376 Don't increment bufsize until after realloc succeeds.
9377 Check for size-calculation overflow.
9378 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9380 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9382 * lread.c: Integer overflow fixes.
9383 (read_integer): Radix is now EMACS_INT, not int,
9384 to improve quality of diagnostics for out-of-range radices.
9385 Calculate buffer size correctly for out-of-range radices.
9386 (read1): Check for integer overflow in radices, and in
9387 read-circle numbers.
9388 (read_escape): Avoid int overflow.
9389 (Fload, openp, read_buffer_size, read1)
9390 (substitute_object_recurse, read_vector, read_list, map_obarray):
9391 Use ptrdiff_t, not int, for sizes.
9392 (read1): Use EMACS_INT, not int, for sizes.
9393 Check for size overflow.
9395 * image.c (cache_image): Check for size arithmetic overflow.
9397 * lread.c: Integer overflow issues.
9398 (saved_doc_string_size, saved_doc_string_length)
9399 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9400 Now ptrdiff_t, not int.
9401 (read1): Don't assume doc string length fits in int. Check for
9402 out-of-range doc string lengths.
9403 (read_list): Don't assume file position fits in int.
9404 (read_escape): Check for hex character overflow.
9406 2011-06-22 Leo Liu <sdl.web@gmail.com>
9408 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9409 Move to minibuffer.el.
9411 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9413 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
9414 The following patches are for when GLYPH_DEBUG && !XASSERT.
9415 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9416 * dispnew.c (flush_stdout):
9417 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9418 Mark as externally visible.
9419 * dispnew.c (check_window_matrix_pointers): Now static.
9420 * dispnew.c (window_to_frame_vpos):
9421 * xfns.c (unwind_create_frame):
9422 * xterm.c (x_check_font): Remove unused local.
9423 * scroll.c (CHECK_BOUNDS):
9424 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9425 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9426 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9427 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9428 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9430 (debug_method_add): Use va_list and vsprintf rather than relying
9431 on undefined behavior with wrong number of arguments.
9432 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9433 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9434 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9435 since we're not interested in debugging glyphs with old libraries.
9436 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9437 GCC 4.6.0's static checking.
9439 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9441 Integer overflow and signedness fixes (Bug#8873).
9442 A few related buffer overrun fixes, too.
9444 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9446 * dispextern.h (struct face.stipple):
9447 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9448 (x_bitmap_mask, x_allocate_bitmap_record)
9449 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9450 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9451 (x_create_bitmap_from_xpm_data):
9452 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9453 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9455 * xfaces.c (load_pixmap):
9456 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9457 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9458 (.bitmaps_last, struct x_output.icon_bitmap):
9459 Use ptrdiff_t, not int, for bitmap indexes.
9460 (x_allocate_bitmap_record): Check for size overflow.
9461 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9463 Use ptrdiff_t, not int, for overlay counts.
9464 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9465 * editfns.c (overlays_around, get_pos_property):
9466 * textprop.c (get_char_property_and_overlay):
9467 * xdisp.c (next_overlay_change, note_mouse_highlight):
9468 * xfaces.c (face_at_buffer_position):
9469 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9470 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9471 (Fnext_overlay_change, Fprevious_overlay_change)
9472 (mouse_face_overlay_overlaps, Foverlays_in):
9473 Use ptrdiff_t, not int, for sizes.
9474 (overlays_at, overlays_in): Check for size-calculation overflow.
9476 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9478 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9479 (x_session_initialize): Do not assume string length fits in int.
9481 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9482 This is unlikely, but can occur if DPI is outlandish.
9484 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
9485 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9487 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9488 * xrdb.c (magic_file_p, search_magic_path):
9489 Omit last arg SUFFIX; it was always 0. All callers changed.
9490 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9492 * xfont.c (xfont_match): Avoid need for strlen.
9494 * xfns.c: Don't assume strlen fits in int.
9495 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9497 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9498 not unsigned long, as we prefer signed integers. All callers changed.
9499 Detect integer overflow in repeat count.
9500 (message_dolog): Don't assume print length fits in 39 bytes.
9501 (display_mode_element): Don't assume strlen fits in int.
9503 * termcap.c: Don't assume sizes fit in int and never overflow.
9504 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9505 (gobble_line): Check for size-calculation overflow.
9507 * minibuf.c (Fread_buffer):
9508 * lread.c (intern, intern_c_string):
9509 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9510 Don't assume string length fits in int.
9512 * keyboard.c (parse_tool_bar_item):
9513 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9515 * font.c: Don't assume string length fits in int.
9516 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9517 Use ptrdiff_t, not int.
9518 (font_intern_prop): Don't assume string length fits in int.
9519 Don't assume integer property fits in fixnum.
9520 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
9522 * filelock.c: Fix some buffer overrun and integer overflow issues.
9523 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
9524 Reformulate so as not to need the command string.
9525 Invoke gzip -cd rather than gunzip, as it's more portable.
9526 (lock_info_type, lock_file_1, lock_file):
9527 Don't assume pid_t and time_t fit in unsigned long.
9528 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9529 (current_lock_owner): Prefer signed type for sizes.
9530 Use memcpy, not strncpy, where memcpy is what is really wanted.
9531 Don't assume (via atoi) that time_t and pid_t fit in int.
9532 Check for time_t and/or pid_t out of range, e.g., via a network share.
9533 Don't alloca where an auto var works fine.
9535 * fileio.c: Fix some integer overflow issues.
9536 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9537 Don't assume string length fits in int.
9538 (directory_file_name): Don't assume string length fits in long.
9539 (make_temp_name): Don't assume pid fits in int, or that its print
9540 length is less than 20.
9542 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9544 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9546 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9548 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9549 We prefer signed integers, even for size calculations.
9551 * emacs.c: Don't assume string length fits in 'int'.
9552 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9553 (main): Don't invoke strlen when not needed.
9555 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9556 (XD_DEBUG_MESSAGE): Don't waste a byte.
9558 * callproc.c (getenv_internal_1, getenv_internal)
9560 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9562 * lread.c (invalid_syntax): Omit length argument.
9563 All uses changed. This doesn't fix a bug, but it simplifies the
9564 code away from its former Hollerith-constant appearance, and it's
9565 one less 'int' to worry about when looking at integer-overflow issues.
9566 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
9568 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9569 This didn't break anything, but it didn't help either.
9570 It's confusing to put a bogus integer in a place where the actual
9571 value does not matter.
9572 (LIST_END_P): Remove unused macro and its bogus comment.
9573 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
9575 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9576 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9578 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9579 We prefer signed types, and the value cannot exceed the EMACS_INT
9580 range anyway (because otherwise the length would not be representable).
9581 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9582 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9583 This avoids a GCC warning when WIDE_EMACS_INT.
9585 * indent.c (sane_tab_width): New function.
9586 (current_column, scan_for_column, Findent_to, position_indentation)
9587 (compute_motion): Use it. This is just for clarity.
9588 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
9590 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
9592 * lisp.h (lint_assume): New macro.
9593 * composite.c (composition_gstring_put_cache):
9594 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9596 * editfns.c, insdel.c:
9597 Omit unnecessary forward decls, to simplify future changes.
9599 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9601 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9603 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
9604 Use much-faster test for byte-length change.
9605 Don't assume string byte-length fits in 'int'.
9606 Check that character arg fits in 'int'.
9607 (mapcar1): Declare byte as byte, for clarity.
9609 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9611 * fns.c (concat): Catch string overflow earlier.
9612 Do not rely on integer wraparound.
9614 * dispextern.h (struct it.overlay_strings_charpos)
9615 (struct it.selective): Now EMACS_INT, not int.
9616 * xdisp.c (forward_to_next_line_start)
9617 (back_to_previous_visible_line_start)
9618 (reseat_at_next_visible_line_start, next_element_from_buffer):
9619 Don't arbitrarily truncate the value of 'selective' to int.
9621 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9623 * composite.c: Don't truncate sizes to 'int'.
9624 (composition_gstring_p, composition_reseat_it)
9625 (composition_adjust_point): Use EMACS_INT, not int.
9626 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9627 not EMACS_UINT, for indexes.
9629 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9631 * buffer.c: Include <verify.h>.
9632 (struct sortvec.priority, struct sortstr.priority):
9633 Now EMACS_INT, not int.
9634 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
9635 (struct sortstr.size, record_overlay_string)
9636 (struct sortstrlist.size, struct sortlist.used):
9637 Don't truncate size to int.
9638 (record_overlay_string): Check for size-calculation overflow.
9639 (init_buffer_once): Check at compile-time, not run-time.
9641 2011-06-22 Jim Meyering <meyering@redhat.com>
9643 Don't leak an XBM-image-sized buffer
9644 * image.c (xbm_load): Free the image buffer after using it.
9646 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9649 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9650 that Sun C diagnosed.
9651 * fns.c (secure_hash): Fix pointer signedness issue.
9652 * intervals.c (static_offset_intervals): New function.
9653 (offset_intervals): Use it.
9655 2011-06-21 Leo Liu <sdl.web@gmail.com>
9658 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9661 * fns.c (secure_hash): Rename from crypto_hash_function and change
9662 the first arg to accept symbols.
9663 (Fsecure_hash): New primitive.
9664 (syms_of_fns): New symbols.
9666 2011-06-20 Deniz Dogan <deniz@dogan.se>
9668 * process.c (Fset_process_buffer): Clarify return value in
9671 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
9673 * dispnew.c (add_window_display_history): Use BVAR.
9675 * xdisp.c (debug_method_add): Use BVAR.
9676 (check_window_end, dump_glyph_matrix, dump_glyph)
9677 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9679 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9682 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9683 check till after the cache is created in init_frame_faces.
9685 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9687 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9689 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9691 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9692 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9693 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9695 Improve buffer-overflow checking (Bug#8873).
9696 * fileio.c (Finsert_file_contents):
9697 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9698 Remove the old (too-loose) buffer overflow checks.
9699 They weren't needed, since make_gap checks for buffer overflow.
9700 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9701 The old code merely checked for Emacs fixnum overflow, and relied
9702 on undefined (wraparound) behavior. The new code avoids undefined
9703 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9705 * editfns.c (Finsert_char): Don't dump core with very negative counts.
9706 Tune. Don't use wider integers than needed. Don't use alloca.
9707 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
9709 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9711 * insdel.c, lisp.h (buffer_overflow): New function.
9712 (insert_from_buffer_1, replace_range, replace_range_2):
9713 * insdel.c (make_gap_larger):
9714 * editfns.c (Finsert_char):
9715 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9717 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9719 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9721 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
9723 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9724 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9726 * fileio.c: Don't assume EMACS_INT fits in off_t.
9727 (emacs_lseek): New static function.
9728 (Finsert_file_contents, Fwrite_region): Use it.
9729 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9731 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9733 * fns.c: Don't overflow int when computing a list length.
9734 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9735 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9736 truncation on 64-bit hosts. Check for QUIT every
9737 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9738 faster and is responsive enough.
9739 (Flength): Report an error instead of overflowing an integer.
9740 (Fsafe_length): Return a float if the value is not representable
9741 as a fixnum. This shouldn't happen except in contrived situations.
9742 (Fnthcdr, Fsort): Don't assume list length fits in int.
9743 (Fcopy_sequence): Don't assume vector length fits in int.
9745 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9746 (header_size, word_size): New constants.
9747 (allocate_vectorlike): Don't check size overflow here.
9748 (allocate_vector): Check it here instead, since this is the only
9749 caller of allocate_vectorlike that could cause overflow.
9750 Check that the new vector's length is representable as a fixnum.
9752 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9753 The previous code was bogus. For example, next_almost_prime (32)
9754 returned 39, which is undesirable as it is a multiple of 3; and
9755 next_almost_prime (24) returned 25, which is a multiple of 5 so
9756 why was the code bothering to check for multiples of 7?
9758 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9760 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9762 Variadic C functions now count arguments with ptrdiff_t.
9763 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9764 Back then I didn't know that the Emacs coding style prefers signed int.
9765 Also, in the meantime I found a few more instances where arguments
9766 were being counted with int, which may truncate counts on 64-bit
9767 machines, or EMACS_INT, which may be unnecessarily wide.
9768 * lisp.h (struct Lisp_Subr.function.aMANY)
9769 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9770 Arg counts are now ptrdiff_t, not size_t.
9771 All variadic functions and their callers changed accordingly.
9772 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9773 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9774 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9775 * callint.c (Fcall_interactively): Check arg count for overflow,
9776 to avoid potential buffer overrun. Use signed char, not 'int',
9777 for 'varies' array, so that we needn't bother to check its size
9778 calculation for overflow.
9779 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9780 * eval.c (apply_lambda):
9781 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9782 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9783 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9785 * callint.c (Fcall_interactively): Don't use index var as event count.
9787 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9788 * mem-limits.h (SIZE): Remove; no longer used.
9790 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
9792 Remove unnecessary casts.
9793 * xterm.c (x_term_init):
9794 * xfns.c (x_set_border_pixel):
9795 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9796 These aren't needed now that we assume ANSI C.
9798 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9799 It's more likely to cause problems (due to unsigned overflow)
9802 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9804 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9806 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9808 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9810 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9812 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9814 GLYPH_CODE_FACE returns EMACS_INT, not int.
9815 * dispextern.h (merge_faces):
9816 * xfaces.c (merge_faces):
9817 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9818 Don't assume EMACS_INT fits in int.
9820 * character.h (CHAR_VALID_P): Remove unused parameter.
9821 * fontset.c, lisp.h, xdisp.c: All uses changed.
9823 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9825 * fns.c (concat): Minor tuning based on overflow analysis.
9826 This doesn't fix any bugs. Use int to hold character, instead
9827 of constantly refetching from Emacs object. Use XFASTINT, not
9828 XINT, for value known to be a character. Don't bother comparing
9829 a single byte to 0400, as it's always less.
9831 * floatfns.c (Fexpt):
9832 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9834 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9837 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9839 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9840 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9841 incorrectly succeed when S was a string, because 4294967386 was
9842 truncated before it was used.
9844 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9845 Otherwise, an out-of-range integer could cause undefined behavior
9848 * composite.c: Use int, not EMACS_INT, for characters.
9849 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9850 EMACS_INT, for values that are known to be in character range.
9851 This doesn't fix any bugs but is the usual style inside Emacs and
9852 may generate better code on 32-bit machines.
9854 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9855 This is for reasons similar to the recent CHAR_STRING fix.
9856 * charset.c (Fencode_char): Check that character arg is actually
9857 a character. Pass an int to ENCODE_CHAR.
9858 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9859 wider than 'int', as a compile-time check to prevent future regressions
9862 * character.c (char_string): Remove unnecessary casts.
9864 Make sure a 64-bit char is never passed to CHAR_STRING.
9865 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9866 by silently ignoring the top 32 bits, allowing some values
9867 that were far too large to be valid characters.
9868 * character.h: Include <verify.h>.
9869 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9870 arguments are no wider than unsigned, as a compile-time check
9871 to prevent future regressions in this area.
9873 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
9874 (Fsubst_char_in_region):
9876 * xdisp.c (decode_mode_spec_coding):
9877 Adjust to CHAR_STRING's new requirement.
9878 * editfns.c (Finsert_char, Fsubst_char_in_region):
9879 * fns.c (concat): Check that character args are actually
9880 characters. Without this test, these functions did the wrong
9881 thing with wildly out-of-range values on 64-bit hosts.
9883 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9884 These casts should not be needed on 32-bit hosts, either.
9885 * keyboard.c (read_char):
9886 * lread.c (Fload): Remove casts to unsigned.
9888 * lisp.h (UNSIGNED_CMP): New macro.
9889 This fixes comparison bugs on 64-bit hosts.
9890 (ASCII_CHAR_P): Use it.
9891 * casefiddle.c (casify_object):
9892 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
9893 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9894 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9895 * dispextern.h (FACE_FROM_ID):
9896 * keyboard.c (read_char): Use UNSIGNED_CMP.
9898 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9899 not to EMACS_INT, to avoid GCC warning.
9901 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9903 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9904 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9905 isn't needed on 32-bit machines.
9907 * buffer.c (Fgenerate_new_buffer_name):
9908 Use EMACS_INT for count, not int.
9909 (advance_to_char_boundary): Return EMACS_INT, not int.
9911 * data.c (Qcompiled_function): Now static.
9913 * window.c (window_body_lines): Now static.
9915 * image.c (gif_load): Rename local to avoid shadowing.
9917 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9918 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9919 * alloc.c (make_save_value): Integer argument is now of type
9921 (mark_object): Use ptrdiff_t, not int.
9922 * lisp.h (pD): New macro.
9923 * print.c (print_object): Use it.
9925 * alloc.c: Use EMACS_INT, not int, to count objects.
9926 (total_conses, total_markers, total_symbols, total_vector_size)
9927 (total_free_conses, total_free_markers, total_free_symbols)
9928 (total_free_floats, total_floats, total_free_intervals)
9929 (total_intervals, total_strings, total_free_strings):
9930 Now EMACS_INT, not int. All uses changed.
9931 (Fgarbage_collect): Compute overall total using a double, so that
9932 integer overflow is less likely to be a problem. Check for overflow
9933 when converting back to an integer.
9934 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9935 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9936 These were 'int' variables that could overflow on 64-bit hosts;
9937 they were never used, so remove them instead of repairing them.
9938 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
9939 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9940 Previously, this ceilinged at INT_MAX, but that doesn't work on
9942 (allocate_pseudovector): Don't use EMACS_INT when int would do.
9944 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
9945 (allocate_vectorlike): Check for ptrdiff_t overflow.
9946 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9947 when a (possibly-narrower) signed value would do just as well.
9948 We prefer using signed arithmetic, to avoid comparison confusion.
9950 * alloc.c: Catch some string size overflows that we were missing.
9951 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9952 for convenience in STRING_BYTES_MAX.
9953 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9954 The definition here is exact; the one in lisp.h was approximate.
9955 (allocate_string_data): Check for string overflow. This catches
9956 some instances we weren't catching before. Also, it catches
9957 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9958 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9959 and ptrdiff_t and EMACS_INT are both 64 bits.
9961 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9962 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
9963 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
9965 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9967 * alloc.c (Fmake_string): Check for out-of-range init.
9969 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9971 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9973 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9975 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9976 xg_get_default_scrollbar_width.
9978 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9979 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9980 (style_changed_cb): Call update_theme_scrollbar_width and call
9981 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9982 all frames (Bug#8505).
9983 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9984 Call gtk_window_set_resizable if HAVE_GTK3.
9985 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9986 and height if HAVE_GTK3 (Bug#8505).
9987 (scroll_bar_width_for_theme): New variable.
9988 (update_theme_scrollbar_width): New function.
9989 (xg_get_default_scrollbar_width): Move code to
9990 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9991 (xg_initialize): Call update_theme_scrollbar_width.
9993 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9995 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9997 2011-06-12 Martin Rudalics <rudalics@gmx.at>
9999 * frame.c (make_frame): Call other_buffer_safely instead of
10002 * window.c (temp_output_buffer_show): Call display_buffer with
10003 second argument Vtemp_buffer_show_specifiers and reset latter
10004 immediately after the call.
10005 (Vtemp_buffer_show_specifiers): New variable.
10006 (auto_window_vscroll_p, next_screen_context_lines)
10007 (Vscroll_preserve_screen_position): Remove leading asterisks from
10010 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
10012 Fix minor problems found by GCC 4.6.0 static checking.
10013 * buffer.c (Qclone_number): Remove for now, as it's unused.
10014 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10015 (record_buffer): Remove unused local.
10016 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10017 (set_frame_buffer_list): Remove; unused.
10018 * frame.h (other_visible_frames): Remove decl.
10019 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10020 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10021 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10023 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10024 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10025 Define only if HAVE_GPM.
10026 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10027 (update_hints_inhibit): Remove; never set. All uses removed.
10028 * widgetprv.h (emacsFrameClassRec): Remove decl.
10029 * window.c (delete_deletable_window): Now returns void, since it
10030 wasn't returning anything.
10031 (compare_window_configurations): Remove unused locals.
10032 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10033 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
10034 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10035 the same widths as pointers. This follows up on the 2011-05-06 patch.
10036 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10037 * xterm.h: Likewise.
10038 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10040 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
10042 * makefile.w32-in: Update dependencies.
10043 (LISP_H): Add lib/intprops.h.
10045 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10047 * image.c (gif_load): Add animation frame delay to the metadata.
10048 (syms_of_image): Use DEFSYM. New symbol `delay'.
10050 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10052 * window.c (delete_deletable_window): Re-add.
10053 (Fset_window_configuration): Rewrite to handle dead buffers and
10054 consequently deletable windows.
10055 (window_tree, Fwindow_tree): Remove. Supply functionality in
10057 (compare_window_configurations): Simplify code.
10059 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10061 * image.c (imagemagick_load_image): Fix type mismatch.
10062 (Fimagemagick_types): Likewise.
10064 * window.h (replace_buffer_in_windows): Declare.
10066 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10068 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10069 Qclone_number. Remove external declaration of Qdelete_window.
10070 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10072 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10073 Run Qbuffer_list_update_hook if allowed.
10074 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10075 buffer list implementation.
10076 (other_buffer_safely): New function.
10077 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10078 calls to replace_buffer_in_windows and
10079 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10081 (record_buffer): Inhibit quitting and rewrite using quittable
10082 functions. Run Qbuffer_list_update_hook if allowed.
10083 (Frecord_buffer, Funrecord_buffer): New functions.
10084 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10085 Move switch-to-buffer to window.el.
10086 (bury-buffer): Move to window.el.
10087 (Vbuffer_list_update_hook): New variable.
10089 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10092 * window.h (resize_frame_windows): Move up in code.
10093 (Fwindow_frame): Remove EXFUN.
10094 (replace_buffer_in_all_windows): Remove prototype.
10095 (replace_buffer_in_windows_safely): Add prototype.
10097 * window.c: Declare Qdelete_window static again. Move down
10098 declaration of select_count.
10099 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10100 (Fother_window): Move to window.el.
10101 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10102 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10103 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10105 (replace_buffer_in_windows): Implement by calling
10106 Qreplace_buffer_in_windows.
10107 (replace_buffer_in_all_windows): Remove with some functionality
10108 moved into replace_buffer_in_windows_safely.
10109 (replace_buffer_in_windows_safely): New function.
10110 (select_window_norecord, select_frame_norecord): Move in front
10111 of run_window_configuration_change_hook. Remove now obsolete
10113 (Fset_window_buffer): Rewrite doc-string.
10114 Call Qrecord_window_buffer.
10115 (keys_of_window): Move binding for other-window to window.el.
10117 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10119 * dispextern.h (struct image): Replace data member, whose int_val
10120 and ptr_val fields were not used by anything, with a single
10123 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10124 (gif_clear_image, gif_load, imagemagick_load_image)
10125 (gs_clear_image, gs_load): Callers changed.
10127 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10129 * buffer.h: Include <time.h>, for time_t.
10130 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10132 Fix minor problems found by static checking.
10134 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10136 Make identifiers static if they are not used in other modules.
10137 * data.c (Qcompiled_function, Qframe, Qvector):
10138 * image.c (QimageMagick, Qsvg):
10139 * minibuf.c (Qmetadata):
10140 * window.c (resize_window_check, resize_root_window): Now static.
10141 * window.h (resize_window_check, resize_root_window): Remove decls.
10143 * window.c (window_deletion_count, delete_deletable_window):
10145 (window_body_lines): Now static.
10146 (Fdelete_other_windows_internal): Mark vars as initialized.
10147 Make sure 'resize_failed' is initialized.
10148 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10149 (resize_window_apply): Remove unused local.
10150 * window.h (delete_deletable_window): Remove decl.
10152 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
10153 (imagemagick_load_image): Fix pointer signedness problem by changing
10154 last arg from unsigned char * to char *. All uses changed.
10155 Also, fix a local for similar reasons.
10156 Remove unused locals. Remove locals to avoid shadowing.
10157 (fn_rsvg_handle_free): Remove; unused.
10158 (svg_load, svg_load_image): Fix pointer signedness problem.
10159 (imagemagick_load_image): Don't use garbage pointer image_wand.
10161 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10163 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
10165 * image.c (gif_load): Fix omitted cast error introduced by
10168 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10170 * window.h (resize_proportionally, orig_total_lines)
10171 (orig_top_line): Remove from window structure.
10172 (set_window_height, set_window_width, change_window_heights)
10173 (Fdelete_window): Remove prototypes.
10174 (resize_frame_windows): Remove duplicate declaration.
10176 2011-06-10 Eli Zaretskii <eliz@gnu.org>
10178 * window.h (resize_frame_windows, resize_window_check)
10179 (delete_deletable_window, resize_root_window)
10180 (resize_frame_windows): Declare prototypes.
10182 * window.c (resize_window_apply): Make definition be "static" to
10183 match the prototype.
10185 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10187 * window.c: Remove declarations of Qwindow_size_fixed,
10188 window_min_size_1, window_min_size_2, window_min_size,
10189 size_window, window_fixed_size_p, enlarge_window, delete_window.
10190 Remove static from declaration of Qdelete_window, it's
10191 temporarily needed by Fbury_buffer.
10192 (replace_window): Don't assign orig_top_line and
10194 (Fdelete_window, delete_window): Remove. Window deletion is
10195 handled by window.el.
10196 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10197 Replace Fdelete_window calls with calls to Qdelete_window.
10198 (Fdelete_other_windows): Remove. Deleting other windows is
10199 handled by window.el.
10200 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10201 handled in window.el.
10202 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10203 Window minimum sizes are handled in window.el.
10204 (shrink_windows, size_window, set_window_height)
10205 (set_window_width, change_window_heights, window_height)
10206 (window_width, CURBEG, CURSIZE, enlarge_window)
10207 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10208 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10209 handled in window.el.
10210 (make_dummy_parent): Rename to make_parent_window and give it a
10211 second argument horflag.
10212 (make_window): Don't set resize_proportionally any more.
10213 (Fsplit_window): Remove. Windows are split in window.el.
10214 (save_restore_action, save_restore_orig_size)
10215 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10216 Resize mini windows in window.el.
10217 (grow_mini_window, shrink_mini_window): Implement by calling
10218 Qresize_root_window_vertically, resize_window_check and
10219 resize_window_apply.
10220 (saved_window, Fset_window_configuration, save_window_save):
10221 Do not handle orig_top_line, orig_total_lines, and
10222 resize_proportionally.
10223 (window_min_height, window_min_width): Move to window.el.
10224 (keys_of_window): Move bindings for delete-other-windows,
10225 split-window, delete-window and enlarge-window to window.el.
10227 * buffer.c: Temporarily extern Qdelete_window.
10228 (Fbury_buffer): Temporarily call Qdelete_window instead of
10229 Fdelete_window (Fbury_buffer will move to window.el soon).
10231 * frame.c (set_menu_bar_lines_1): Remove code handling
10232 orig_top_line and orig_total_lines.
10234 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10235 set_window_height but set heights directly.
10236 (change_frame_size_1): Use resize_frame_windows.
10238 * xdisp.c (init_xdisp): Don't use set_window_height but set
10241 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10242 Use resize_frame_windows instead of change_window_heights and run
10243 run_window_configuration_change_hook.
10245 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10246 instead of change_window_heights and run
10247 run_window_configuration_change_hook.
10249 2011-06-09 Martin Rudalics <rudalics@gmx.at>
10251 * window.c (replace_window): Rename second argument REPLACEMENT to
10252 NEW. New third argument SETFLAG. Rewrite.
10253 (delete_window, make_dummy_parent): Call replace_window with
10255 (window_list_1): Move down in code.
10256 (run_window_configuration_change_hook): Move set_buffer part
10257 before select_frame_norecord part in order to unwind correctly.
10258 Rename count1 to count.
10259 (recombine_windows, delete_deletable_window, resize_root_window)
10260 (Fdelete_other_windows_internal)
10261 (Frun_window_configuration_change_hook, make_parent_window)
10262 (resize_window_check, resize_window_apply, Fresize_window_apply)
10263 (resize_frame_windows, Fsplit_window_internal)
10264 (Fdelete_window_internal, Fresize_mini_window_internal):
10266 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10268 2011-06-08 Martin Rudalics <rudalics@gmx.at>
10270 * window.h (window): Add some new members to window structure -
10271 normal_lines, normal_cols, new_total, new_normal, clone_number,
10272 splits, nest, prev_buffers, next_buffers.
10273 (WINDOW_TOTAL_SIZE): Move here from window.c.
10274 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
10276 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10278 (make_dummy_parent): Set new members of windows structure.
10279 (make_window): Move down in code. Handle new members of window
10281 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10282 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10283 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10284 (Fset_window_prev_buffers, Fwindow_next_buffers)
10285 (Fset_window_next_buffers, Fset_window_clone_number):
10287 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10288 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10290 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10291 Argument WINDOW can be now internal window too.
10292 (Fwindow_use_time): Move up in code.
10293 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10294 Rewrite doc-string.
10295 (Fset_window_configuration, saved_window)
10296 (Fcurrent_window_configuration, save_window_save): Handle new
10297 members of window structure.
10298 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10299 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10300 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10301 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10302 Qget_mru_window, Qresize_root_window,
10303 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10304 Qauto_buffer_name; staticpro them.
10306 2011-06-07 Martin Rudalics <rudalics@gmx.at>
10308 * window.c (Fwindow_total_size, Fwindow_left_column)
10309 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10310 (Fwindow_list_1): New functions.
10311 (window_box_text_cols): Replace with window_body_cols.
10312 (Fwindow_width, Fscroll_left, Fscroll_right):
10313 Use window_body_cols instead of window_box_text_cols.
10314 (delete_window, Fset_window_configuration):
10315 Call delete_all_subwindows with window as argument.
10316 (delete_all_subwindows): Take a window as argument and not a
10317 structure. Rewrite.
10318 (window_loop): Remove handling of GET_LRU_WINDOW and
10319 GET_LARGEST_WINDOW.
10320 (Fget_lru_window, Fget_largest_window): Move to window.el.
10322 * window.h: Extern window_body_cols instead of
10323 window_box_text_cols. delete_all_subwindows now takes a
10324 Lisp_Object as argument.
10326 * indent.c (compute_motion, Fcompute_motion):
10327 Use window_body_cols instead of window_box_text_cols.
10329 * frame.c (delete_frame): Call delete_all_subwindows with root
10330 window as argument.
10332 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10334 * fns.c (Fputhash): Document return value.
10336 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
10338 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10340 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10342 Cons<->int and similar integer overflow fixes (Bug#8794).
10344 Check for overflow when converting integer to cons and back.
10345 * charset.c (Fdefine_charset_internal, Fdecode_char):
10346 Use cons_to_unsigned to catch overflow.
10347 (Fencode_char): Use INTEGER_TO_CONS.
10348 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10349 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10350 * data.c (long_to_cons, cons_to_long): Remove.
10351 (cons_to_unsigned, cons_to_signed): New functions.
10352 These signal an error for invalid or out-of-range values.
10353 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10354 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10355 * font.c (Ffont_variation_glyphs):
10356 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10357 * lisp.h: Include <intprops.h>.
10358 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10359 (cons_to_signed, cons_to_unsigned): New decls.
10360 (long_to_cons, cons_to_long): Remove decls.
10361 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10362 (Fprimitive_undo): Use CONS_TO_INTEGER.
10363 * xfns.c (Fx_window_property): Likewise.
10364 * xselect.c: Include <limits.h>.
10365 (x_own_selection, selection_data_to_lisp_data):
10366 Use INTEGER_TO_CONS.
10367 (x_handle_selection_request, x_handle_selection_clear)
10368 (x_get_foreign_selection, Fx_disown_selection_internal)
10369 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10370 (lisp_data_to_selection_data): Use cons_to_unsigned.
10371 (x_fill_property_data): Use cons_to_signed.
10372 Report values out of range.
10374 Check for buffer and string overflow more precisely.
10375 * buffer.h (BUF_BYTES_MAX): New macro.
10376 * lisp.h (STRING_BYTES_MAX): New macro.
10377 * alloc.c (Fmake_string):
10378 * character.c (string_escape_byte8):
10379 * coding.c (coding_alloc_by_realloc):
10380 * doprnt.c (doprnt):
10381 * editfns.c (Fformat):
10383 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10384 since they may not be the same number.
10385 * editfns.c (Finsert_char):
10386 * fileio.c (Finsert_file_contents):
10387 Likewise for BUF_BYTES_MAX.
10389 * image.c: Use ptrdiff_t, not int, for sizes.
10390 (slurp_file): Switch from int to ptrdiff_t.
10392 (slurp_file): Check that file size fits in both size_t (for
10393 malloc) and ptrdiff_t (for sanity and safety).
10395 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10396 if b->modtime has its maximal value.
10398 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10400 Don't assume time_t can fit into int.
10401 * buffer.h (struct buffer.modtime): Now time_t, not int.
10402 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10403 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10405 Minor fixes for signed vs unsigned integers.
10406 * character.h (MAYBE_UNIFY_CHAR):
10407 * charset.c (maybe_unify_char):
10408 * keyboard.c (read_char, reorder_modifiers):
10409 XINT -> XFASTINT, since the integer must be nonnegative.
10410 * ftfont.c (ftfont_spec_pattern):
10411 * keymap.c (access_keymap, silly_event_symbol_error):
10412 XUINT -> XFASTINT, since the integer must be nonnegative.
10413 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10414 since it makes no difference and we prefer signed.
10415 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10416 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10419 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10421 * window.h (Fwindow_frame): Declare.
10423 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10425 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10426 (SPARE_MEMORY): Always define.
10427 (LARGE_REQUEST): Remove.
10428 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10430 2011-06-06 Martin Rudalics <rudalics@gmx.at>
10432 * lisp.h: Move EXFUNS for Fframe_root_window,
10433 Fframe_first_window and Fset_frame_selected_window to window.h.
10435 * window.h: Move EXFUNS for Fframe_root_window,
10436 Fframe_first_window and Fset_frame_selected_window here from
10439 * frame.c (Fwindow_frame, Fframe_first_window)
10440 (Fframe_root_window, Fframe_selected_window)
10441 (Fset_frame_selected_window): Move to window.c.
10442 (Factive_minibuffer_window): Move to minibuf.c.
10443 (Fother_visible_frames_p): New function.
10445 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10447 * window.c (decode_window, decode_any_window): Move up in code.
10448 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10449 (inhibit_frame_unsplittable): Remove unused variable.
10450 (Fwindow_buffer): Move up and rewrite doc-string.
10451 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10452 (Fwindow_prev): New functions.
10453 (Fwindow_frame): Move here from frame.c. Accept any window as
10455 (Fframe_root_window, Fframe_first_window)
10456 (Fframe_selected_window): Move here from frame.c. Accept frame
10457 or arbitrary window as argument. Update doc-strings.
10458 (Fminibuffer_window): Move up in code.
10459 (Fwindow_minibuffer_p): Move up in code and simplify.
10460 (Fset_frame_selected_window): Move here from frame.c.
10462 (Fselected_window, select_window, Fselect_window): Move up in
10463 code. Minor doc-string fixes.
10465 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10467 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10468 Do not assume that spare memory exists; that assumption is valid
10469 only if SYSTEM_MALLOC.
10470 (LARGE_REQUEST): New macro, so that the issue of large requests
10471 is separated from the issue of spare memory.
10473 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10475 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10478 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10480 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10483 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10485 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10487 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10489 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10490 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10492 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
10494 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10496 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
10498 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10499 (x_clipboard_manager_save): Add return value.
10500 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10501 New error handlers.
10502 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10503 Obey Vx_select_enable_clipboard_manager. Catch errors in
10504 x_clipboard_manager_save (Bug#8779).
10505 (Vx_select_enable_clipboard_manager): New variable.
10506 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
10508 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
10510 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10512 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10514 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10515 in the current matrix if keep_current_p is non-zero.
10517 2011-06-04 Eli Zaretskii <eliz@gnu.org>
10519 * bidi.c (bidi_level_of_next_char): Fix last change.
10521 2011-06-03 Eli Zaretskii <eliz@gnu.org>
10523 Support bidi reordering of text covered by display properties.
10525 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10526 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10527 (bidi_cache_search, bidi_cache_iterator_state)
10528 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
10529 (bidi_level_of_next_char, bidi_move_to_visually_next):
10530 Support character positions inside a run of characters covered by a
10532 (bidi_paragraph_init, bidi_resolve_explicit_1)
10533 (bidi_level_of_next_char): Call bidi_fetch_char and
10534 bidi_fetch_char_advance instead of FETCH_CHAR and
10535 FETCH_CHAR_ADVANCE.
10536 (bidi_init_it): Initialize new members.
10537 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10539 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10540 instead of using explicit *_CHAR codes.
10541 (bidi_resolve_explicit, bidi_resolve_weak):
10542 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
10543 bidirectional text is supported only in multibyte buffers.
10544 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10545 it to initialize the frame_window_p member of struct bidi_it.
10546 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10547 (bidi_resolve_explicit, bidi_resolve_weak)
10548 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10549 bidi_it->nchars is non-positive.
10550 (bidi_level_of_next_char): Don't try to lookup the cache for the
10551 next/previous character if nothing is cached there yet, or if we
10552 were just reseat()'ed to a new position.
10554 * xdisp.c (set_cursor_from_row): Set start and stop points
10555 according to the row's direction when priming the loop that looks
10556 for the glyph on which to display cursor.
10557 (single_display_spec_intangible_p): Function deleted.
10558 (display_prop_intangible_p): Reimplement to call
10559 handle_display_spec instead of single_display_spec_intangible_p.
10560 Accept 3 additional arguments needed by handle_display_spec.
10561 This fixes incorrect cursor motion across display property with complex
10562 values: lists, `(when COND...)' forms, etc.
10563 (single_display_spec_string_p): Support property values that are
10564 lists with the argument STRING its top-level element.
10565 (display_prop_string_p): Fix the condition for processing a
10566 property that is a list to be consistent with handle_display_spec.
10567 (handle_display_spec): New function, refactored from the
10568 last portion of handle_display_prop.
10569 (compute_display_string_pos): Accept additional argument
10570 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10571 value of a `display' property is a "replacing spec".
10572 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10573 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10574 the display property, but just return a value indicating whether
10575 the display property will replace the characters it covers.
10576 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10577 frame_window_p members of struct bidi_it.
10578 (compute_display_string_pos, compute_display_string_end):
10580 (push_it): Accept second argument POSITION, where pop_it should
10581 jump to continue iteration.
10582 (reseat_1): Initialize bidi_it.disp_pos.
10584 * keyboard.c (adjust_point_for_property): Adjust the call to
10585 display_prop_intangible_p to its new signature.
10587 * dispextern.h (struct bidi_it): New member frame_window_p.
10588 (bidi_init_it): Update prototypes.
10589 (display_prop_intangible_p): Update prototype.
10590 (compute_display_string_pos, compute_display_string_end):
10591 Declare prototypes.
10592 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10595 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
10597 Malloc failure behavior now depends on size of allocation.
10598 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10599 * lisp.h: Change signatures accordingly.
10600 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10601 All callers changed. (Bug#8762)
10603 * gnutls.c: Use Emacs's memory allocators.
10604 Without this change, the gnutls library would invoke malloc etc.
10605 directly, which causes problems on non-SYNC_INPUT hosts, and which
10606 runs afoul of improving memory_full behavior. (Bug#8761)
10607 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10608 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10609 xfree instead of the default malloc, realloc, free.
10610 (Fgnutls_boot): No need to check for memory allocation failure,
10611 since xmalloc does that for us.
10613 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
10614 * category.c (hash_get_category_set):
10615 * ccl.c (ccl_driver):
10616 * charset.c (Fdefine_charset_internal):
10617 * charset.h (struct charset.hash_index):
10618 * composite.c (get_composition_id, gstring_lookup_cache)
10619 (composition_gstring_put_cache):
10620 * composite.h (struct composition.hash_index):
10621 * dispextern.h (struct image.hash):
10622 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10623 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10624 (hashfn_equal, hashfn_user_defined, make_hash_table)
10625 (maybe_resize_hash_table, hash_lookup, hash_put)
10626 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10627 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10628 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10629 * image.c (make_image, search_image_cache, lookup_image)
10630 (xpm_put_color_table_h):
10631 * lisp.h (struct Lisp_Hash_Table):
10632 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
10633 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
10634 for hashes and hash indexes, instead of 'unsigned' and 'int'.
10635 * alloc.c (allocate_vectorlike):
10636 Check for overflow in vector size calculations.
10637 * ccl.c (ccl_driver):
10638 Check for overflow when converting EMACS_INT to int.
10639 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10640 need to be updated by these changes.
10641 * fns.c (make_hash_table, maybe_resize_hash_table):
10642 Check for integer overflow with large hash tables.
10643 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10644 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10645 (SXHASH_REDUCE): New macro.
10646 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10647 Use it instead of discarding useful hash info with large hash values.
10648 (sxhash_float): New function.
10649 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10650 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
10651 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10652 Rewrite to use FIXNUM_BITS, as this simplifies things.
10653 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10654 Adjust signatures to match updated version of code.
10655 (consing_since_gc): Now EMACS_INT, since a single hash table can
10656 use more than INT_MAX bytes.
10658 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10660 Make it possible to build with GCC-4.6+ -O2 -flto.
10662 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10664 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10666 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10667 Call minibuffer-inactive-mode.
10669 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
10671 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10672 Update dependencies.
10674 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10676 * data.c (init_data): Remove code for UTS, this system is not
10679 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10681 Don't force ./temacs to start in terminal mode.
10683 * frame.c (make_initial_frame): Initialize faces in all cases, not
10684 only when CANNOT_DUMP is defined.
10685 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10687 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10689 * dispnew.c (add_window_display_history): Use const for the string
10690 pointer. Remove declaration, not needed.
10692 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10694 Use 'inline', not 'INLINE'.
10695 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
10696 * alloc.c, fontset.c (INLINE): Remove.
10697 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10698 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10699 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10700 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10701 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10703 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10705 Make it possible to run ./temacs.
10707 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10708 syms_of_callproc does the same thing. Remove test for
10709 "initialized", do it in the caller.
10710 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10712 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10714 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10715 (read_minibuf): Use get_minibuffer.
10716 (syms_of_minibuf): Use DEFSYM.
10717 (Qmetadata): New var.
10718 * data.c (Qbuffer): Don't make it static.
10719 (syms_of_data): Use DEFSYM.
10721 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10723 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10724 (CCL_CODE_MIN): New macro.
10726 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10728 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10730 * eval.c (Qdebug): Now static.
10731 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10732 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10733 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10735 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10737 * image.c: Various fixes to ImageMagick code comments.
10738 (Fimagemagick_types): Doc fix.
10740 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10742 Minor fixes prompted by GCC 4.6.0 warnings.
10744 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10746 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10747 (x_clipboard_manager_save_all): Move extern decl to ...
10748 * xterm.h: ... here, so that it can be checked for consistency.
10750 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10752 * xselect.c (x_clipboard_manager_save_frame)
10753 (x_clipboard_manager_save_all): New functions.
10754 (Fx_clipboard_manager_save): Lisp function deleted.
10756 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10757 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10759 * xterm.h: Update prototype.
10761 2011-05-28 William Xu <william.xwl@gmail.com>
10763 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10764 exiting (Bug#8239).
10766 2011-05-28 Jim Meyering <meyering@redhat.com>
10768 Avoid a sign-extension bug in crypto_hash_function.
10769 * fns.c (to_uchar): Define.
10770 (crypto_hash_function): Use it to convert some newly-signed
10771 variables to unsigned, to avoid sign-extension bugs. For example,
10772 without this change, (md5 "truc") would evaluate to
10773 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10774 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
10775 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
10777 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10779 Integer overflow fixes.
10781 * dbusbind.c: Serial number integer overflow fixes.
10782 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
10783 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10784 to hold a serial number that is too large for a fixnum.
10785 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10786 Check for serial numbers out of range. Decode any serial number
10787 that was so large that it became a float. (Bug#8722)
10789 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10790 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10791 Use XFASTINT rather than XUINT when numbers are nonnegative.
10792 (xd_append_arg, Fdbus_method_return_internal):
10793 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10794 arguments, check that Lisp number is nonnegative, rather than
10795 silently wrapping negative numbers around. (Bug#8722)
10796 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
10799 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10801 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10803 ccl: Add integer overflow checks.
10804 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10805 (IN_INT_RANGE): New macros.
10806 (ccl_driver): Use them to check for integer overflow when
10807 decoding a CCL program. Many of the new checks are whether XINT (x)
10808 fits in int; it doesn't always, on 64-bit hosts. The new version
10809 doesn't catch all possible integer overflows, but it's an
10810 improvement. (Bug#8719)
10812 * alloc.c (make_event_array): Use XINT, not XUINT.
10813 There's no need for unsigned here.
10815 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10816 This follows up to the 2011-05-06 change that substituted uintptr_t
10817 for EMACS_INT. This case wasn't caught back then.
10819 Rework Fformat to avoid integer overflow issues.
10820 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10821 now (part of C89). Include <verify.h>.
10822 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10823 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10824 (Fformat): Avoid the prepass trying to compute sizes; it was only
10825 approximate and thus did not catch overflow reliably. Instead, walk
10826 through the format just once, formatting and computing sizes as we go,
10827 checking for integer overflow at every step, and allocating a larger
10828 buffer as needed. Keep track separately whether the format is
10829 multibyte. Keep only the most-recently calculated precision, rather
10830 than them all. Record whether each argument has been converted to
10831 string. Use EMACS_INT, not int, for byte and char and arg counts.
10832 Support field widths and precisions larger than INT_MAX. Avoid
10833 sprintf's undefined behavior with conversion specifications such as %#d
10834 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10835 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10836 formatting out-of-range floating point numbers with int
10837 formats. (Bug#8668)
10839 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10841 * data.c: Avoid integer truncation in expressions involving floats.
10842 * data.c: Include <intprops.h>.
10843 (arith_driver): When there's an integer overflow in an expression
10844 involving floating point, convert the integers to floating point
10845 so that the resulting value does not suffer from catastrophic
10846 integer truncation. For example, on a 64-bit host (* 4
10847 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10848 Do not rely on undefined behavior after integer overflow.
10850 merge count_size_as_multibyte, parse_str_to_multibyte
10851 * character.c, character.h (count_size_as_multibyte):
10852 Rename from parse_str_to_multibyte; all uses changed.
10853 Check for integer overflow.
10854 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10855 since it's now a duplicate of the other. This is more of
10856 a character than a buffer op, so better that it's in character.c.
10857 * fns.c, print.c: Adjust to above changes.
10859 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10861 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10863 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10865 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10866 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10867 (x_clipboard_manager_save): Now static.
10868 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10870 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10871 (crypto_hash_function): Now static.
10872 Fix pointer signedness problems. Avoid unnecessary initializations.
10874 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
10876 * termhooks.h (Vselection_alist): Make it terminal-local.
10878 * terminal.c (create_terminal): Initialize it.
10880 * xselect.c: Support for clipboard managers.
10881 (Vselection_alist): Move to termhooks.h as terminal-local var.
10882 (LOCAL_SELECTION): New macro.
10883 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10884 (symbol_to_x_atom): Remove gratuitous arg.
10885 (x_handle_selection_request, lisp_data_to_selection_data)
10886 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
10887 (x_own_selection, x_get_local_selection, x_convert_selection):
10888 New arg, specifying work frame. Use terminal-local Vselection_alist.
10889 (some_frame_on_display): Delete unused function.
10890 (Fx_own_selection_internal, Fx_get_selection_internal)
10891 (Fx_disown_selection_internal, Fx_selection_owner_p)
10892 (Fx_selection_exists_p): New optional frame arg.
10893 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10894 (x_handle_selection_clear): Don't treat other terminals with the
10895 same keyboard specially. Use the terminal-local Vselection_alist.
10896 (x_clear_frame_selections): Use Frun_hook_with_args.
10898 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10900 * xterm.h: Add support for those atoms.
10902 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
10904 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10905 (converted_selections, conversion_fail_tag): New global variables.
10906 (x_selection_request_lisp_error): Free the above.
10907 (x_get_local_selection): Remove unnecessary code.
10908 (x_reply_selection_request): Args changed; handle arbitrary array
10909 of converted selections stored in converted_selections.
10910 Separate the XChangeProperty and SelectionNotify steps.
10911 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10912 (x_convert_selection): New function.
10913 (x_handle_selection_event): Simplify.
10914 (x_get_foreign_selection): Don't ignore incoming requests while
10915 waiting for an answer; this will fail when we implement
10916 SAVE_TARGETS, and seems unnecessary anyway.
10917 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10918 (Vx_sent_selection_functions): Doc fix.
10920 2011-05-26 Leo Liu <sdl.web@gmail.com>
10922 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10924 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10926 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10928 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10929 for fringe update if it has periodic bitmap.
10930 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
10931 and fringe_bitmap_periodic_p.
10933 * fringe.c (get_fringe_bitmap_data): New function.
10934 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10935 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10936 row. Mark glyph row for fringe update if periodicity changed.
10938 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10939 for fringe update unless it has periodic bitmap.
10941 2011-05-25 Kenichi Handa <handa@m17n.org>
10943 * xdisp.c (get_next_display_element): Set correct it->face_id for
10944 a static composition.
10946 2011-05-24 Leo Liu <sdl.web@gmail.com>
10949 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10951 * fns.c (crypto_hash_function, Fsha1): New function.
10952 (Fmd5): Use crypto_hash_function.
10953 (syms_of_fns): Add Ssha1.
10955 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10957 * gnutls.c: Remove unused macros.
10958 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10959 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10960 Remove macros that are defined and never used.
10961 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10963 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10965 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10966 (Fx_get_selection_internal): Minor cleanup.
10967 (Fx_own_selection_internal): Rename arguments for consistency with
10970 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10972 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10974 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10976 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10978 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10980 * dispnew.c (scrolling_window): Don't exclude the case that the
10981 last enabled row in the desired matrix touches the bottom boundary.
10983 2011-05-21 Glenn Morris <rgm@gnu.org>
10985 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
10986 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10987 and add some more files.
10989 2011-05-20 Eli Zaretskii <eliz@gnu.org>
10991 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10992 report_file_error introduced by the change from 2011-05-07.
10994 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10996 * systime.h (Time): Define only if emacs is defined.
10997 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10998 where the include path doesn't have X11/X.h by default. See
10999 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11001 2011-05-20 Kenichi Handa <handa@m17n.org>
11003 * composite.c (find_automatic_composition): Fix previous change.
11005 2011-05-20 Glenn Morris <rgm@gnu.org>
11007 * lisp.mk: New file, split from Makefile.in.
11008 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11009 (shortlisp): Remove.
11010 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11012 2011-05-19 Glenn Morris <rgm@gnu.org>
11014 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11015 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11016 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11017 (lisp): Set the order to that of loadup.el.
11018 (shortlisp): Make it a copy of $lisp.
11019 (SOME_MACHINE_LISP): Remove.
11020 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11021 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11023 2011-05-18 Kenichi Handa <handa@m17n.org>
11025 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11026 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11027 (find_automatic_composition): Mostly rewrite for efficiency.
11029 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
11031 * makefile.w32-in: Update dependencies.
11033 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11035 * menu.c: Include limits.h (fixes the MS-Windows build broken by
11036 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
11038 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
11040 Fix some integer overflow issues, such as string length overflow.
11042 * insdel.c (count_size_as_multibyte): Check for string overflow.
11044 * character.c (lisp_string_width): Check for string overflow.
11045 Use EMACS_INT, not int, for string indexes and lengths; in
11046 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11047 the resulting string length overflows an EMACS_INT; instead,
11048 report a string overflow if no precision given. When checking for
11049 precision exhaustion, use a check that cannot possibly have
11050 integer overflow. (Bug#8675)
11051 * character.h (lisp_string_width): Adjust to new signature.
11053 * alloc.c (string_overflow): New function.
11054 (Fmake_string): Use it. This doesn't change behavior, but saves
11055 a few bytes and will simplify future changes.
11056 * character.c (string_escape_byte8): Likewise.
11057 * lisp.h (string_overflow): New decl.
11059 Fixups, following up to the user-interface timestamp change.
11060 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11061 for UI timestamps, instead of unsigned long.
11062 * msdos.c (mouse_get_pos): Likewise.
11063 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
11064 * w32gui.h (Time): Define by including "systime.h" rather than by
11065 declaring it ourselves. (Bug#8664)
11067 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11068 * image.c (clear_image_cache): Likewise.
11070 * term.c (term_mouse_position): Don't assume time_t wraparound.
11072 Be more systematic about user-interface timestamps.
11073 Before, the code sometimes used 'Time', sometimes 'unsigned long',
11074 and sometimes 'EMACS_UINT', to represent these timestamps.
11075 This change causes it to use 'Time' uniformly, as that's what X uses.
11076 This makes the code easier to follow, and makes it easier to catch
11077 integer overflow bugs such as Bug#8664.
11078 * frame.c (Fmouse_position, Fmouse_pixel_position):
11079 Use Time, not unsigned long, for user-interface timestamps.
11080 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11081 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11082 * keyboard.h (last_event_timestamp): Likewise.
11083 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11084 * menu.h (xmenu_show): Likewise.
11085 * term.c (term_mouse_position): Likewise.
11086 * termhooks.h (struct input_event.timestamp): Likewise.
11087 (struct terminal.mouse_position_hook): Likewise.
11088 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11089 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11090 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11091 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11092 what it was before.
11093 * menu.h, termhooks.h: Include "systime.h", for Time.
11095 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11096 Don't assume that the difference between two unsigned long values
11097 can fit into an integer. At this point, we know button_down_time
11098 <= event->timestamp, so the difference must be nonnegative, so
11099 there's no need to cast the result if double-click-time is
11100 nonnegative, as it should be; check that it's nonnegative, just in
11101 case. This bug is triggered when events are more than 2**31 ms
11102 apart (about 25 days). (Bug#8664)
11104 * xselect.c (last_event_timestamp): Remove duplicate decl.
11105 (x_own_selection): Remove needless cast to unsigned long.
11107 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11108 that always fit in int. Use a sentinel instead of a counter, to
11109 avoid a temp and to allay GCC's concerns about possible int overflow.
11110 * frame.h (struct frame): Use int for menu_bar_items_used
11111 instead of EMACS_INT, since it always fits in int.
11113 * menu.c (grow_menu_items): Check for int overflow.
11115 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11117 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11118 Before, the code was not consistent. These values cannot exceed
11119 2**31 - 1 so there's no need to make them unsigned.
11120 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11121 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11122 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11124 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11126 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11127 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11128 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11129 presumably because the widths might not match.
11131 * window.c (size_window): Avoid needless test at loop start.
11133 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11135 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11137 2011-05-12 Drew Adams <drew.adams@oracle.com>
11139 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11141 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11143 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11144 `width' to `bar_area_x' and `bar_area_width', respectively.
11145 (x_scroll_run): Take account of fringe background extension.
11147 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11148 Rename local vars `left' and `width' to `bar_area_x' and
11149 `bar_area_width', respectively.
11150 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11151 background extension.
11153 2011-05-10 Jim Meyering <meyering@redhat.com>
11155 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11157 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
11159 * image.c (Finit_image_library): Return t for built-in image types,
11160 like pbm and xbm. (Bug#8640)
11162 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11164 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11166 2011-05-07 Eli Zaretskii <eliz@gnu.org>
11168 * w32console.c (Fset_screen_color): Doc fix.
11169 (Fget_screen_color): New function.
11170 (syms_of_ntterm): Defsubr it.
11172 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11173 unlink the temporary file if Fcall_process didn't create it in the
11175 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11176 child process will be redirected to a file specified with `:file'.
11177 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11178 cue to call_process_cleanup not to close that handle.
11180 2011-05-07 Ben Key <bkey76@gmail.com>
11182 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11183 one of two shell specific rules, either bootstrap-temacs-CMD or
11184 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11185 to the previous implementation of the bootstrap-temacs rule.
11186 The bootstrap-temacs-CMD rule is similar to the previous
11187 implementation of the bootstrap-temacs rule except that it
11188 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11191 These changes, along with some changes to nt/configure.bat,
11192 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11193 earlier fix to add support for --cflags and --ldflags options
11194 that include quotes so that it works whether make uses cmd or
11197 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
11199 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11200 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11202 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11203 a string. Handle both cases.
11204 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11205 (Fdbus_register_method): Use Qinvalid_function.
11207 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11209 * makefile.w32-in: Update dependencies.
11210 (LISP_H): Add inttypes.h and stdin.h.
11211 (PROCESS_H): Add unistd.h.
11213 2011-05-06 Eli Zaretskii <eliz@gnu.org>
11215 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11216 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11218 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
11220 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11222 * term.c (vfatal): Remove stray call to va_end.
11223 It's not needed and the C Standard doesn't allow it here anyway.
11225 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11226 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11228 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11231 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11233 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11235 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11237 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11239 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11241 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11242 * charset.c (Fdefine_charset_internal): Don't initialize
11243 charset.code_space[15]. The value was garbage, on hosts with
11244 32-bit int (Bug#8600).
11246 * lread.c (read_integer): Be more consistent with string-to-number.
11247 Use string_to_number to do the actual conversion; this avoids
11248 rounding errors and fixes some other screwups. Without this fix,
11249 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11250 (digit_to_number): Move earlier, for benefit of read_integer.
11251 Return -1 if the digit is out of range for the base, -2 if it is
11252 not a digit in any supported base. (Bug#8602)
11254 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11256 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11257 to match comment at start of function. This also removes a
11258 GCC warning about overflow in a 32+64-bit port.
11260 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11262 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11263 Reported by Stefan Monnier in
11264 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
11265 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11266 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
11268 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11269 (EMACS_UINTPTR): Likewise, with uintptr_t.
11271 * lisp.h: Prefer 64-bit EMACS_INT if available.
11272 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11273 on 32-bit hosts that have 64-bit int, so that they can access
11275 However, temporarily disable this change unless the temporary
11276 symbol WIDE_EMACS_INT is defined.
11278 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11280 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11281 This removes an assumption that EMACS_INT and long are the same
11282 width as pointers. The assumption is true for Emacs porting targets
11283 now, but we want to make other targets possible.
11284 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11285 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11286 In the rest of the code, change types of integers that hold casted
11287 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11288 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11289 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11290 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11291 No need to cast type when ORing.
11292 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11293 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11294 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11295 assume EMACS_INT is the same width as char *.
11296 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11297 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11298 Remove no-longer-needed casts.
11299 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11300 (xg_tool_bar_help_callback, xg_make_tool_item):
11301 Use EMACS_INTPTR to hold an integer
11302 that will be cast to void *; this can avoid a GCC warning
11303 if EMACS_INT is not the same width as void *.
11304 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11305 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11306 (current_message_1, set_message_1):
11307 Use a local to convert to proper width without a cast.
11308 * xmenu.c (dialog_selection_callback): Likewise.
11310 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11311 Also, don't assume VALBITS / RAND_BITS is less than 5,
11312 and don't rely on undefined behavior when shifting a 1 left into
11314 * lisp.h (get_random): Change signature to match.
11316 * lread.c (hash_string): Use size_t, not int, for hash computation.
11317 Normally we prefer signed values; but hashing is special, because
11318 it's better to use unsigned division on hash table sizes so that
11319 the remainder is nonnegative. Also, size_t is the natural width
11320 for hashing into memory. The previous code used 'int', which doesn't
11321 retain enough info to hash well into very large tables.
11322 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11324 * dbusbind.c: Don't possibly lose pointer info when converting.
11325 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11326 Use XPNTR rather than XHASH, so that the high-order bits of
11327 the pointer aren't lost when converting through void *.
11329 * eval.c (Fautoload): Don't double-shift a pointer.
11331 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11333 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11335 * gnutls.c (DEF_GNUTLS_FN):
11336 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11338 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11340 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11343 2011-05-05 Eli Zaretskii <eliz@gnu.org>
11345 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11346 New version that can reserve upto 2GB of heap space.
11348 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
11350 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11352 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11354 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11355 `gnutls_certificate_set_x509_key_file'.
11357 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
11359 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11360 Update dependencies.
11362 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11364 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11365 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11366 Remove unused parameter `fildes'.
11367 * process.c (read_process_output, send_process): Don't pass it.
11369 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11371 Fix previous change: the library cache is defined in w32.c.
11372 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11373 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11375 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11377 Implement dynamic loading of GnuTLS on Windows.
11379 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11380 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11381 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11384 * gnutls.c (Qgnutls_dll): Define.
11385 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11386 (gnutls_*): Declare function pointers.
11387 (init_gnutls_functions): New function to initialize function pointers.
11388 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11389 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11390 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11391 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11392 (emacs_gnutls_write, emacs_gnutls_read)
11393 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11394 (Fgnutls_available_p): New function.
11395 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11396 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11397 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11399 * image.c: Include w32.h.
11400 (Vimage_type_cache): Delete.
11401 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11402 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11403 (w32_delayed_load): Move to w32.c.
11405 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11407 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11408 (w32_delayed_load): Move from image.c. When loading a library, record
11409 its filename in the :loaded-from property of the library id.
11410 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11411 Initialize and staticpro them.
11412 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11414 * process.c: Include lisp.h before w32.h, not after.
11415 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11416 instead of gnutls_record_check_pending.
11418 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11420 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11422 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11423 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11426 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11428 * xterm.c (x_set_frame_alpha): Do not set property on anything
11429 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11431 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11433 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11435 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11437 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11438 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11439 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11440 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11441 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11442 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11443 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11444 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11445 (Qgnutls_bootprop_callbacks_verify): Make static.
11447 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11449 * callproc.c: Indentation fixup.
11451 * sysdep.c (wait_for_termination_1): Make static.
11452 (wait_for_termination, interruptible_wait_for_termination):
11453 Move after wait_for_termination_1.
11455 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11457 * sysdep.c (interruptible_wait_for_termination): New function
11458 which is like wait_for_termination, but allows keyboard
11461 * callproc.c (Fcall_process): Add (:file "file") as an option for
11463 (Fcall_process_region): Ditto.
11465 2011-04-30 Eli Zaretskii <eliz@gnu.org>
11467 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11468 rather than `XVECTOR (FOO)->size'.
11470 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11471 inttypes.h, as a gnulib replacement is used if it not available in
11474 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11476 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11477 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11478 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11480 * coding.c (coding_alloc_by_realloc): Error out if destination
11481 will grow beyond MOST_POSITIVE_FIXNUM.
11482 (decode_coding_emacs_mule): Abort if there isn't enough place in
11483 charbuf for the composition carryover bytes. Reserve an extra
11484 space for up to 2 characters produced in a loop.
11485 (decode_coding_iso_2022): Abort if there isn't enough place in
11486 charbuf for the composition carryover bytes.
11488 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11490 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11491 aborting when %lld or %lll format is passed.
11492 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11493 %llo or %llx format is passed. (Bug#8545)
11495 * window.c (window_scroll_line_based): Use a marker instead of
11496 simple variables to record original value of point. (Bug#7952)
11498 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11499 produced by %s or %c overflows available buffer space. (Bug#8545)
11501 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11503 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
11504 (SIZE_MAX): Move defn after all includes, as they might #define it.
11506 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11508 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11510 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11512 * keyboard.c (Qdelayed_warnings_hook): Define.
11513 (command_loop_1): Run `delayed-warnings-hook'
11514 if Vdelayed_warnings_list is non-nil.
11515 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11516 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11518 2011-04-28 Eli Zaretskii <eliz@gnu.org>
11520 * doprnt.c (doprnt): Don't return value smaller than the buffer
11521 size if the message was truncated. (Bug#8545).
11523 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11525 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11526 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11528 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11530 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11532 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
11534 * makefile.w32-in: Update dependencies.
11536 2011-04-27 Eli Zaretskii <eliz@gnu.org>
11538 Improve `doprnt' and its usage. (Bug#8545)
11539 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11540 `format_end'. Remove support for %l as a conversion specifier.
11541 Don't use xrealloc. Improve diagnostics when the %l size modifier
11542 is used. Update the commentary.
11544 * eval.c (verror): Simplify calculation of size_t.
11546 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11549 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11551 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11554 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11556 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11557 This makes this file independent of the recent pseudovector change.
11559 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
11561 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11563 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
11564 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
11565 Remove unused local.
11566 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
11568 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
11569 GCC 4.6.0 optimizes based on type-based alias analysis.
11570 For example, if b is of type struct buffer * and v of type struct
11571 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11572 != &v->size, and therefore "v->size = 1; b->size = 2; return
11573 v->size;" must therefore return 1. This assumption is incorrect
11574 for Emacs, since it type-puns struct Lisp_Vector * with many other
11575 types. To fix this problem, this patch adds a new type struct
11576 vectorlike_header that documents the constraints on layout of vectors
11577 and pseudovectors, and helps optimizing compilers not get fooled
11578 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11579 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
11580 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11582 (XSETPVECTYPE): Rewrite in terms of new macro.
11583 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11584 This is a bit clearer, and further avoids the possibility of
11585 undesirable aliasing.
11586 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
11587 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
11588 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11589 since Lisp_Subr is a special case (no "next" field).
11590 (ASIZE): Now uses header.size rather than size.
11591 All previous uses of XVECTOR (foo)->size replaced to use this macro,
11592 to avoid the hassle of writing XVECTOR (foo)->header.size.
11593 (struct vectorlike_header): New type.
11594 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11595 object, to help avoid aliasing.
11596 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11597 (SUBRP): Likewise, since Lisp_Subr is a special case.
11598 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11599 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11600 (struct Lisp_Hash_Table): Combine first two members into a single
11601 struct vectorlike_header member. All uses of "size" and "next" members
11602 changed to be "header.size" and "header.next".
11603 * buffer.h (struct buffer): Likewise.
11604 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11605 * frame.h (struct frame): Likewise.
11606 * process.h (struct Lisp_Process): Likewise.
11607 * termhooks.h (struct terminal): Likewise.
11608 * window.c (struct save_window_data, struct saved_window): Likewise.
11609 * window.h (struct window): Likewise.
11610 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11611 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11612 * buffer.c (init_buffer_once): Likewise.
11613 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11615 * process.c (Fformat_network_address): Use local var for size,
11618 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11620 Make the Lisp reader and string-to-float more consistent (Bug#8525)
11621 * data.c (atof): Remove decl; no longer used or needed.
11622 (digit_to_number): Move to lread.c.
11623 (Fstring_to_number): Use new string_to_number function, to be
11624 consistent with how the Lisp reader treats infinities and NaNs.
11625 Do not assume that floating-point numbers represent EMACS_INT
11626 without losing information; this is not true on most 64-bit hosts.
11627 Avoid double-rounding errors, by insisting on integers when
11628 parsing non-base-10 numbers, as the documentation specifies.
11629 * lisp.h (string_to_number): New decl, replacing ...
11630 (isfloat_string): Remove.
11631 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
11632 (read1): Do not accept +. and -. as integers; this
11633 appears to have been a coding error. Similarly, do not accept
11634 strings like +-1e0 as floating point numbers. Do not report
11635 overflow for integer overflows unless the base is not 10 which
11636 means we have no simple and reliable way to continue.
11637 Break out the floating-point parsing into a new
11638 function string_to_number, so that Fstring_to_number parses
11639 floating point numbers consistently with the Lisp reader.
11640 (digit_to_number): Move here from data.c. Make it static inline.
11641 (E_CHAR, EXP_INT): Remove, replacing with ...
11642 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11643 (string_to_number): New function, replacing isfloat_string.
11644 This function checks for valid syntax and produces the resulting
11645 Lisp float number too. Rework it so that string-to-number
11646 no longer mishandles examples like "1.0e+". Use strtoumax,
11647 so that overflow for non-base-10 numbers is reported only when
11648 there's no portable and simple way to convert to floating point.
11650 * textprop.c (set_text_properties_1): Rewrite for clarity,
11651 and to avoid GCC warning about integer overflow.
11653 * intervals.h (struct interval): Use EMACS_INT for members
11654 where EMACS_UINT might cause problems. See
11655 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11656 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11657 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11659 (offset_intervals): Tell GCC not to worry about length overflow
11660 when negating a negative length.
11662 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11663 (overrun_check_free): Likewise.
11665 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11666 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11669 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11670 (gnutls_make_error): Rename local to avoid shadowing.
11671 (gnutls_emacs_global_deinit): ifdef out; not used.
11672 (Fgnutls_boot): Use const for pointer to readonly storage.
11673 Comment out unused local. Fix pointer signedness problems.
11675 * lread.c (openp): Don't stuff size_t into an 'int'.
11676 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11677 about possible signed overflow.
11679 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11680 (GDK_KEY_g): Don't define if already defined.
11681 (xg_prepare_tooltip): Avoid pointer signedness problem.
11682 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11684 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11685 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11687 * xfns.c (Fx_window_property): Simplify a bit,
11688 to make a bit faster and to avoid GCC 4.6.0 warning.
11689 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11691 * fns.c (internal_equal): Don't assume size_t fits in int.
11693 * alloc.c (compact_small_strings): Tighten assertion a little.
11695 Replace pEd with more-general pI, and fix some printf arg casts.
11696 * lisp.h (pI): New macro, generalizing old pEd macro to other
11697 conversion specifiers. For example, use "...%"pI"d..." rather
11698 than "...%"pEd"...".
11699 (pEd): Remove. All uses replaced with similar uses of pI.
11700 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
11701 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11702 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11703 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11704 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11705 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11706 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11708 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11709 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11710 * print.c (safe_debug_print, print_object): Likewise.
11711 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11713 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11714 avoiding the 0 flag, which is not portable.
11715 * process.c (Fmake_network_process): Use pI to avoid cast.
11716 * region-cache.c (pp_cache): Likewise.
11717 * xdisp.c (decode_mode_spec): Likewise.
11718 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11719 behavior on 64-bit hosts with printf arg.
11720 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
11721 (x_stop_queuing_selection_requests): Likewise.
11722 (x_get_window_property): Don't truncate byte count to an 'int'
11725 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11726 here, since it parses constructs like leading '-' and spaces,
11727 which are not wanted; and it overflows with large numbers.
11728 Instead, simply match F[0-9]+, which is what is wanted anyway.
11730 * alloc.c: Remove unportable assumptions about struct layout.
11731 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11732 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11733 (allocate_vectorlike, make_pure_vector): Use the new macros,
11734 plus offsetof, to remove unportable assumptions about struct layout.
11735 These assumptions hold on all porting targets that I know of, but
11736 they are not guaranteed, they're easy to remove, and removing them
11737 makes further changes easier.
11739 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11740 This doesn't fix a bug but makes the code clearer.
11741 (string_overrun_cookie): Now const. Use initializers that
11742 don't formally overflow signed char, to avoid warnings.
11743 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11744 can cause Emacs to crash when string overrun checking is enabled.
11745 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11746 multiple of sizeof (EMACS_INT); it need not be, if
11747 alignof(EMACS_INT) < sizeof (EMACS_INT).
11748 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
11750 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
11752 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11754 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11756 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
11757 supposed to be handshaking. (Bug#8556)
11758 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11760 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
11762 * lisp.h (Qdebug): List symbol.
11763 * eval.c (Qdebug): Restore global linkage.
11764 * keyboard.c (debug-on-event): New variable.
11765 (handle_user_signal): Break into debugger when debug-on-event
11766 matches the current signal symbol.
11768 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11770 * alloc.c (check_sblock, check_string_bytes)
11771 (check_string_free_list): Convert to standard C.
11773 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11775 * w32.c (emacs_gnutls_push): Fix typo.
11777 2011-04-25 Eli Zaretskii <eliz@gnu.org>
11779 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11780 "cast to pointer from integer of different size".
11782 Improve doprnt and its use in verror. (Bug#8545)
11783 * doprnt.c (doprnt): Document the set of format control sequences
11784 supported by the function. Use SAFE_ALLOCA instead of always
11787 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11788 is one byte too soon. Don't use xrealloc; instead xfree and
11791 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11793 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11796 * gnutls.c: Renamed global_initialized to
11797 gnutls_global_initialized. Added internals for the
11798 :verify-hostname-error, :verify-error, and :verify-flags
11799 parameters of `gnutls-boot' and documented those parameters in the
11800 docstring. Start callback support.
11801 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11802 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11803 on error. Return error code.
11804 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11805 (emacs_gnutls_read): Likewise.
11806 (Fgnutls_boot): Return handshake error code.
11807 (emacs_gnutls_handle_error): New function.
11808 (wsaerror_to_errno): Likewise.
11810 * w32.h (emacs_gnutls_pull): Add prototype.
11811 (emacs_gnutls_push): Likewise.
11813 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11814 (emacs_gnutls_push): Likewise.
11816 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11818 * process.c (wait_reading_process_output): Check if GnuTLS
11819 buffered some data internally if no FDs are set for TLS
11822 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11823 (LIBS): Link to USER_LIBS.
11824 ($(BLD)/gnutls.$(0)): New target.
11826 2011-04-24 Eli Zaretskii <eliz@gnu.org>
11828 * xdisp.c (handle_single_display_spec): Rename the
11829 display_replaced_before_p argument into display_replaced_p, to
11830 make it consistent with the commentary. Fix typos in the
11833 * textprop.c (syms_of_textprop): Remove dead code.
11834 (copy_text_properties): Delete obsolete commentary about an
11835 interface that was deleted long ago. Fix typos in the description
11838 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11839 to changes in oldXMenu/XMenu.h from 2011-04-16.
11840 <menu_help_message, prev_menu_help_message>: Constify.
11841 (IT_menu_make_room): menu->help_text is now `const char **';
11844 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11845 to changes in oldXMenu/XMenu.h from 2011-04-16.
11846 (struct XMenu): Declare `help_text' `const char **'.
11848 * xfaces.c <Qunspecified>: Make extern again.
11850 * syntax.c: Include sys/types.h before including regex.h, as
11853 * doc.c (get_doc_string): Improve the format passed to `error'.
11855 * doprnt.c (doprnt): Improve commentary.
11857 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11859 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11862 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11863 changes in globals.h immediately force recompilation.
11864 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11865 $(CURDIR)/s/ms-w32.h.
11866 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
11868 * character.c (Fchar_direction): Function deleted.
11869 (syms_of_character): Don't defsubr it.
11870 <char-direction-table>: Deleted.
11872 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11874 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11875 * doprnt.c: Include limits.h.
11876 (SIZE_MAX): New macro.
11877 (doprnt): Return a size_t value. 2nd arg is now size_t.
11878 Many local variables are now size_t instead of int or unsigned.
11879 Improve overflow protection. Support `l' modifier for integer
11880 conversions. Support %l conversion. Don't assume an EMACS_INT
11881 argument for integer conversions and for %c.
11883 * lisp.h (doprnt): Restore prototype.
11885 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11886 $(SRC)/character.h.
11888 * Makefile.in (base_obj): Add back doprnt.o.
11890 * deps.mk (doprnt.o): Add back prerequisites.
11891 (callint.o): Depend on character.h.
11893 * eval.c (internal_lisp_condition_case): Include the handler
11894 representation in the error message.
11895 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11896 when breaking from the loop.
11898 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11900 * callint.c (Fcall_interactively): When displaying error message
11901 about invalid control letter, pass the character's codepoint, not
11902 a pointer to its multibyte form. Improve display of the character
11903 in octal and display also its hex code.
11905 * character.c (char_string): Use %x to display the (unsigned)
11906 codepoint of an invalid character, to avoid displaying a bogus
11909 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11910 `error', not SYMBOL_NAME itself.
11912 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11913 character arguments to `error'.
11915 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11916 to `error' in error message about FINAL_CHAR argument. Make sure
11917 FINAL_CHAR is a character, and use %c when it is passed as
11918 argument to `error'.
11920 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11922 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11924 * w32.c: Include <time.h>.
11925 (sys_localtime): New function.
11927 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
11929 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11931 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
11933 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
11935 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11936 zombies (Bug#8467).
11938 2011-04-19 Eli Zaretskii <eliz@gnu.org>
11940 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11941 gl_state.e_property when gl_state.object is Qt.
11943 * insdel.c (make_gap_larger): Remove limitation of buffer size
11946 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
11948 * xdisp.c (lookup_glyphless_char_display)
11949 (produce_glyphless_glyph): Handle cons cell entry in
11950 glyphless-char-display.
11951 (Vglyphless_char_display): Document it.
11953 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11954 glyphless-char-display.
11956 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
11958 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11960 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11962 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11963 definition for no-X builds.
11965 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
11967 Static checks with GCC 4.6.0 and non-default toolkits.
11969 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11971 * process.c (keyboard_bit_set): Define only if SIGIO.
11972 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11973 (send_process): Repair possible setjmp clobbering.
11975 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11977 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11979 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11981 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11982 Define only if needed.
11984 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11985 by pacifying GCC about it. Maybe it's time to retire it?
11986 * xfaces.c (USG, __TIMEVAL__): Likewise.
11988 * dispextern.h (struct redisplay_interface): Rename param
11989 to avoid shadowing.
11990 * termhooks.h (struct terminal): Likewise.
11991 * xterm.c (xembed_send_message): Likewise.
11993 * insdel.c (make_gap_smaller): Define only if
11994 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11996 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11999 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12000 so that we aren't warned about unused symbols.
12002 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12004 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
12006 * xfns.c (x_real_positions): Mark locals as initialized.
12008 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12010 * xterm.c: Fix problems found by static analysis with other toolkits.
12011 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
12012 (x_dispatch_event): Declare static if USE_GTK, and
12013 define if USE_GTK || USE_X_TOOLKIT.
12014 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
12015 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
12016 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12017 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
12019 * xmenu.c (menu_help_callback): Pointer type fixes.
12020 Use const pointers when pointing at readonly data. Avoid pointer
12021 signedness clashes.
12022 (FALSE): Remove unused macro.
12023 (update_frame_menubar): Remove unused decl.
12025 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12027 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12028 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12029 (single_menu_item): Rename local to avoid shadowing.
12031 * keyboard.c (make_lispy_event): Remove unused local var.
12033 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12034 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12036 * bitmaps: Change bitmaps from unsigned char back to the X11
12037 compatible char. Avoid the old compiler warnings about
12038 out-of-range initializers by using, for example, '\xab' rather
12041 * xgselect.c (xgselect_initialize): Check vs interface
12042 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12044 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12046 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12047 to read-only memory.
12049 * fns.c (vector): Remove; this old hack is no longer needed.
12051 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
12053 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
12055 * xrdb.c (x_load_resources): Omit unused local.
12057 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
12058 (x_window): Rename locals to avoid shadowing.
12059 (USG): Use the kludged USG macro, to pacify gcc.
12061 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
12062 (x_term_init): Remove local to avoid shadowing.
12064 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
12066 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12067 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12069 2011-04-16 Eli Zaretskii <eliz@gnu.org>
12071 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12073 Fix regex.c, syntax.c and friends for buffers > 2GB.
12074 * syntax.h (struct gl_state_s): Declare character position members
12077 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12079 * textprop.c (verify_interval_modification, interval_of):
12080 Declare arguments EMACS_INT.
12082 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12085 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12087 * indent.c (Fvertical_motion): Local variable it_start is now
12090 * regex.c (re_match, re_match_2, re_match_2_internal)
12091 (bcmp_translate, regcomp, regexec, print_double_string)
12092 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12093 (re_compile_pattern, re_exec): Declare arguments and local
12094 variables `size_t' and `ssize_t' and return values `regoff_t', as
12096 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12097 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12098 <compile_stack_type>: `size' and `avail' are now `size_t'.
12100 * regex.h <regoff_t>: Use ssize_t, not int.
12101 (re_search, re_search_2, re_match, re_match_2): Arguments that
12102 specify buffer/string position and length are now ssize_t and
12103 size_t. Return type is regoff_t.
12105 2011-04-16 Ben Key <bkey76@gmail.com>
12107 * nsfont.m: Fixed bugs in ns_get_family and
12108 ns_descriptor_to_entity that were caused by using free to
12109 deallocate memory blocks that were allocated by xmalloc (via
12110 xstrdup). This caused Emacs to crash when compiled with
12111 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12112 --enable-checking=xmallocoverrun). xfree is now used to
12113 deallocate these memory blocks.
12115 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
12117 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12119 emacs_write: Accept and return EMACS_INT for sizes.
12120 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12122 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12123 Accept and return EMACS_INT.
12124 (emacs_gnutls_write): Return the number of bytes written on
12126 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
12127 (emacs_read, emacs_write): Remove check for negative size, as the
12128 Emacs source code has been audited now.
12129 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12130 (emacs_read, emacs_write): Use it.
12131 * process.c (send_process): Adjust to the new signatures of
12132 emacs_write and emacs_gnutls_write. Do not attempt to store
12133 a byte offset into an 'int'; it might overflow.
12134 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
12136 * sound.c: Don't assume sizes fit in 'int'.
12137 (struct sound_device.period_size, alsa_period_size):
12138 Return EMACS_INT, not int.
12139 (struct sound_device.write, vox_write, alsa_write):
12140 Accept EMACS_INT, not int.
12141 (wav_play, au_play): Use EMACS_INT to store sizes and to
12142 record read return values.
12144 2011-04-15 Ben Key <bkey76@gmail.com>
12146 * keyboard.c (Qundefined): Don't declare static since it is used
12148 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12149 static since they are used in nsfont.m.
12151 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12153 * process.c (Qprocessp): Don't declare static.
12154 * lisp.h (Qprocessp): Declare again.
12156 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
12158 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12160 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12162 Improve C-level modularity by making more things 'static'.
12164 Don't publish debugger-only interfaces to other modules.
12165 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12166 (verify_bytepos, count_markers): Move decls to the only modules
12168 * region-cache.h (pp_cache): Likewise.
12169 * window.h (check_all_windows): Likewise.
12170 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12172 * sysdep.c (croak): Now static, if
12173 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12174 * syssignal.h (croak): Declare only if not static.
12176 * alloc.c (refill_memory_reserve): Now static if
12177 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12178 * lisp.h (refill_memory_reserve): Declare only if not static.
12180 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12181 Define only if USE_LUCID.
12183 * xrdb.c (x_customization_string, x_rm_string): Now static.
12185 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12186 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12188 * xdisp.c (draw_row_with_mouse_face): Now static.
12189 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12191 * window.h (check_all_windows): Mark externally visible.
12193 * window.c (window_deletion_count): Now static.
12195 * undo.c: Make symbols static if they're not exported.
12196 (last_undo_buffer, last_boundary_position, pending_boundary):
12199 * textprop.c (interval_insert_behind_hooks): Now static.
12200 (interval_insert_in_front_hooks): Likewise.
12202 * term.c: Make symbols static if they're not exported.
12203 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12204 (max_frame_lines, tty_set_terminal_modes):
12205 (tty_reset_terminal_modes, tty_turn_off_highlight):
12206 (get_tty_terminal): Now static.
12207 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12208 * termhooks.h (term_mouse_moveto): Do not declare if
12209 HAVE_WINDOW_SYSTEM.
12210 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12211 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12213 * sysdep.c: Make symbols static if they're not exported.
12214 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12216 (sigprocmask_set, full_mask): Remove; unused.
12217 (wait_debugging): Mark as visible.
12218 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12219 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12221 * syntax.c (syntax_temp): Define only if !__GNUC__.
12223 * sound.c (current_sound_device, current_sound): Now static.
12225 * search.c (searchbufs, searchbuf_head): Now static.
12227 * scroll.c (scroll_cost): Remove; unused.
12228 * dispextern.h (scroll_cost): Remove decl.
12230 * region-cache.h (pp_cache): Mark as externally visible.
12232 * process.c: Make symbols static if they're not exported.
12233 (process_tick, update_tick, create_process, chan_process):
12234 (Vprocess_alist, proc_buffered_char, datagram_access):
12235 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12236 (deactivate_process): Mark defn as static, as well as decl.
12237 * lisp.h (create_process): Remove decl.
12238 * process.h (chan_process, Vprocess_alist): Remove decls.
12240 * print.c: Make symbols static if they're not exported.
12241 (print_depth, new_backquote_output, being_printed, print_buffer):
12242 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12243 (print_interval, print_number_index, initial_stderr_stream):
12245 * lisp.h (Fprinc): Remove decl.
12246 (debug_output_compilation_hack): Mark as externally visible.
12248 * sysdep.c (croak): Move decl from here to syssignal.h.
12249 * syssignal.h (croak): Put it here, so the API can be checked when
12250 'croak' is called from dissociate_if_controlling_tty.
12252 * minibuf.c: Make symbols static if they're not exported.
12253 (minibuf_save_list, choose_minibuf_frame): Now static.
12254 * lisp.h (choose_minibuf_frame): Remove decl.
12256 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12258 * lread.c: Make symbols static if they're not exported.
12259 (read_objects, initial_obarray, oblookup_last_bucket_number):
12261 (make_symbol): Remove; unused.
12262 * lisp.h (initial_obarray, make_symbol): Remove decls.
12264 * keyboard.c: Make symbols static if they're not exported.
12265 (single_kboard, recent_keys_index, total_keys, recent_keys):
12266 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12267 (this_single_command_key_start, echoing, last_auto_save):
12268 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12269 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12270 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12271 (Vlispy_mouse_stem, double_click_count):
12273 (force_auto_save_soon): Define only if SIGDANGER.
12274 (ignore_mouse_drag_p): Now static if
12275 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12276 (print_help): Remove; unused.
12277 (stop_character, last_timer_event): Mark as externally visible.
12278 * keyboard.h (ignore_mouse_drag_p): Declare only if
12279 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12280 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12281 * lisp.h (echoing): Remove decl.
12282 (force_auto_save_soon): Declare only if SIGDANGER.
12283 * xdisp.c (redisplay_window): Simplify code, to make it more
12284 obvious that ignore_mouse_drag_p is not accessed if !defined
12285 USE_GTK && !defined HAVE_NS.
12287 * intervals.c: Make symbols static if they're not exported.
12288 (merge_properties_sticky, merge_interval_right, delete_interval):
12290 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12292 * insdel.c: Make symbols static if they're not exported.
12293 However, leave prepare_to_modify_buffer alone. It's never
12294 called from outside this function, but that appears to be a bug.
12295 (combine_after_change_list, combine_after_change_buffer):
12296 (adjust_after_replace, signal_before_change): Now static.
12297 (adjust_after_replace_noundo): Remove; unused.
12298 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
12299 (signal_before_change): Remove decls.
12301 * indent.c (val_compute_motion, val_vmotion): Now static.
12303 * image.c: Make symbols static if they're not exported.
12304 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12306 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12307 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12309 * fringe.c (standard_bitmaps): Now static.
12310 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12312 * frame.c: Make symbols static if they're not exported.
12313 (x_report_frame_params, make_terminal_frame): Now static.
12314 (get_frame_param): Now static, unless HAVE_NS.
12315 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12316 (x_get_resource_string): Remove; not used.
12317 * frame.h (make_terminal_frame, x_report_frame_params):
12318 (x_get_resource_string); Remove decls.
12319 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12320 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12322 * font.c, fontset.c: Make symbols static if they're not exported.
12323 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12324 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12325 * font.c (font_close_object): Now static.
12326 * font.h (font_close_object): Remove.
12327 * fontset.c (FONTSET_OBJLIST): Remove.
12328 (free_realized_fontset) #if-0 the body, which does nothing.
12329 (face_suitable_for_char_p): #if-0, as it's never called.
12330 * fontset.h (face_suitable_for_char_p): Remove decl.
12331 * xfaces.c (face_at_string_position):
12332 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
12333 since 0 is always ASCII.
12335 * fns.c (weak_hash_tables): Now static.
12337 * fileio.c: Make symbols static if they're not exported.
12338 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12339 (Vwrite_region_annotation_buffers): Now static.
12341 * eval.c: Make symbols static if they're not exported.
12342 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12343 * lisp.h (backtrace_list): Remove decl.
12345 * emacs.c: Make symbols static if they're not exported.
12346 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12347 (fatal_error_code, fatal_error_signal_hook, standard_args):
12349 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12350 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12351 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12352 * lisp.h (fatal_error_signal_hook): Remove decl.
12353 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12355 * editfns.c: Move a (normally-unused) function to its only use.
12356 * editfns.c, lisp.h (get_operating_system_release): Remove.
12357 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12358 worth the hassle of breaking this out.
12360 * xterm.c: Make symbols static if they're not exported.
12361 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12362 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12363 (x_destroy_window, x_delete_display):
12365 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12366 (x_mouse_leave): Remove; unused.
12367 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12368 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12369 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12371 (x_mouse_leave): Declare only if WINDOWSNT.
12372 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12373 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12376 * ftxfont.c: Make symbols static if they're not exported.
12377 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12379 * font.h (ftxfont_driver): Likewise.
12381 * xfns.c: Make symbols static if they're not exported.
12382 (x_last_font_name, x_display_info_for_name):
12383 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12384 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12385 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12386 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12387 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12388 (last_show_tip_args): Now static.
12389 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12390 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12391 (x_screen_planes): Remove; unused.
12392 * dispextern.h (x_screen_planes): Remove decl.
12394 * dispnew.c: Make symbols static if they're not exported.
12395 * dispextern.h (redraw_garbaged_frames, scrolling):
12396 (increment_row_positions): Remove.
12397 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12398 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12400 (redraw_garbaged_frames): Remove; unused.
12402 * xfaces.c: Make symbols static if they're not exported.
12403 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12405 * xterm.h (defined_color): Remove decls.
12406 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12407 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12408 (menu_face_changed_default, defined_color, free_realized_face):
12409 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12410 (ascii_face_of_lisp_face): Remove; unused.
12412 * xdisp.c: Make symbols static if they're not exported.
12413 * dispextern.h (scratch_glyph_row, window_box_edges):
12414 (glyph_to_pixel_coords, set_cursor_from_row):
12415 (get_next_display_element, set_iterator_to_next):
12416 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12417 (show_mouse_face): Remove decls
12418 * frame.h (message_buf_print): Likewise.
12419 * lisp.h (pop_message, set_message, check_point_in_composition):
12421 * xterm.h (set_vertical_scroll_bar): Likewise.
12422 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12423 (message_buf_print, scratch_glyph_row, displayed_buffer):
12424 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12425 (get_next_display_element, show_mouse_face, window_box_edges):
12426 (frame_to_window_pixel_xy, check_point_in_composition):
12427 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12428 (glyph_to_pixel_coords): Remove; unused.
12430 * dired.c (file_name_completion): Now static.
12432 * dbusbind.c (xd_in_read_queued_messages): Now static.
12434 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12435 * data.c (circular_list_error): Remove.
12437 * commands.h (last_point_position, last_point_position_buffer):
12438 (last_point_position_window): Remove decls.
12439 * keyboard.c: Make these variables static.
12441 * coding.h (coding, code_convert_region, encode_coding_gap):
12443 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12444 (iso_code_class, detect_coding, code_convert_region): Now static.
12445 (encode_coding_gap): Remove; unused.
12447 * chartab.c (chartab_chars, chartab_bits): Now static.
12449 * charset.h (charset_iso_8859_1): Remove decl.
12450 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12453 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12454 * ccl.c (Vccl_program_table): Now static.
12455 (check_ccl_update): Remove; unused.
12457 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12458 * category.h: ... from here.
12459 * category.c (check_category_table, set_category_set): Now static.
12461 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12462 * lisp.h: Remove these decls.
12464 * buffer.c (buffer_count): Remove unused var.
12466 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12467 so that it's not optimized away.
12468 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12469 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12470 exported only to the debugger.
12472 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
12473 * atimer.h (run_all_atimers): Remove; not exported.
12475 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12476 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12477 was inaccessible from Lisp.
12478 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12479 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12481 alloc.c: Import and export fewer symbols, and remove unused items.
12482 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12484 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12485 it's not optimized away by whole-program optimization.
12486 (message_enable_multibyte, free_misc): Remove.
12487 (catchlist, handlerlist, mark_backtrace):
12488 Declare only if BYTE_MARK_STACK.
12489 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12490 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12491 (message_enable_multibyte): Remove decl.
12492 (free_misc, interval_free_list, float_block, float_block_index):
12493 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12494 (cons_free_list, last_marked_index):
12496 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12497 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12498 (mark_backtrace): Define only if BYTE_MARK_STACK.
12499 * xdisp.c (message_enable_multibyte): Now static.
12501 Declare Lisp_Object Q* variables to be 'static' if not exported.
12502 This makes it easier for human readers (and static analyzers)
12503 to see whether these variables are used from other modules.
12504 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12505 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12506 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12507 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12508 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12509 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12510 * xmenu.c, xselect.c:
12511 Declare Q* vars static if they are not used in other modules.
12512 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12513 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12514 Remove decls of unexported vars.
12515 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12517 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12519 Make Emacs functions such as Fatom 'static' by default.
12520 This makes it easier for human readers (and static analyzers)
12521 to see whether these functions can be called from other modules.
12522 DEFUN now defines a static function. To make the function external
12523 so that it can be used in other C modules, use the new macro DEFUE.
12524 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12525 (Finit_image_library):
12526 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12527 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12528 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12529 Remove decls, since these functions are now static.
12530 (Funintern, Fget_internal_run_time): New decls, since these functions
12531 were already external.
12533 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12534 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12535 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12536 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12537 * keyboard.c, keymap.c, lread.c:
12538 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12539 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12540 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12541 Mark functions with DEFUE instead of DEFUN,
12542 if they are used in other modules.
12543 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12544 decls for now-static functions.
12545 * buffer.h (Fdelete_overlay): Remove decl.
12546 * callproc.c (Fgetenv_internal): Mark as internal.
12547 * composite.c (Fremove_list_of_text_properties): Remove decl.
12548 (Fcomposition_get_gstring): New forward static decl.
12549 * composite.h (Fcomposite_get_gstring): Remove decl.
12550 * dired.c (Ffile_attributes): New forward static decl.
12551 * doc.c (Fdocumntation_property): New forward static decl.
12552 * eval.c (Ffetch_bytecode): New forward static decl.
12553 (Funintern): Remove extern decl; now in .h file where it belongs.
12554 * fileio.c (Fmake_symbolic_link): New forward static decl.
12555 * image.c (Finit_image_library): New forward static decl.
12556 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12557 * intervals.h (Fprevious_property_change):
12558 (Fremove_list_of_text_properties): Remove decls.
12559 * keyboard.c (Fthis_command_keys): Remove decl.
12560 (Fcommand_execute): New forward static decl.
12561 * keymap.c (Flookup_key): New forward static decl.
12562 (Fcopy_keymap): Now static.
12563 * keymap.h (Flookup_key): Remove decl.
12564 * process.c (Fget_process): New forward static decl.
12565 (Fprocess_datagram_address): Mark as internal.
12566 * syntax.c (Fsyntax_table_p): New forward static decl.
12567 (skip_chars): Remove duplicate decl.
12568 * textprop.c (Fprevious_property_change): New forward static decl.
12569 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12571 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12572 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12574 * editfns.c (Fformat): Remove unreachable code.
12576 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12578 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12581 2011-04-13 Eli Zaretskii <eliz@gnu.org>
12583 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12584 when at ZV. (Bug#8487)
12586 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12588 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12590 * keyboard.c (parse_tool_bar_item): Likewise.
12591 * sound.c (sound_cleanup, alsa_close): Likewise.
12592 * termcap.c (tgetent): Likewise.
12593 * xfns.c (x_default_font_parameter): Likewise.
12594 * xsettings.c (read_and_apply_settings): Likewise.
12596 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12597 (overrun_check_free): Protoize.
12599 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12601 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12602 since callers should never pass a negative size.
12603 Change the signature to match that of plain 'read' and 'write'; see
12604 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12605 * lisp.h: Update prototypes of emacs_write and emacs_read.
12607 2011-04-11 Eli Zaretskii <eliz@gnu.org>
12609 * xdisp.c (redisplay_window): Don't try to determine the character
12610 position of the scroll margin if the window start point w->startp
12611 is outside the buffer's accessible region. (Bug#8468)
12613 2011-04-10 Eli Zaretskii <eliz@gnu.org>
12615 Fix write-region and its subroutines for buffers > 2GB.
12616 * fileio.c (a_write, e_write): Modify declaration of arguments and
12617 local variables to support buffers larger than 2GB.
12618 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12620 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12621 argument, local variables, and return value.
12623 * lisp.h: Update prototypes of emacs_write and emacs_read.
12625 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12627 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
12629 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12631 Fix more problems found by GCC 4.6.0's static checks.
12633 * xdisp.c (vmessage): Use a better test for character truncation.
12635 * charset.c (load_charset_map): <, not <=, for optimization,
12636 and to avoid potential problems with integer overflow.
12637 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
12638 * casetab.c (set_identity, shuffle): Likewise.
12639 * editfns.c (Fformat): Likewise.
12640 * syntax.c (skip_chars): Likewise.
12642 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12643 This also lets GCC 4.6.0 generate slightly better loop code.
12645 * callint.c (Fcall_interactively): <, not <=, for optimization.
12646 (Fcall_interactively): Count the number of arguments produced,
12647 not the number of arguments given. This is simpler and lets GCC
12648 4.6.0 generate slightly better code.
12650 * ftfont.c: Distingish more carefully between FcChar8 and char.
12651 The previous code passed unsigned char * to a functions like
12652 strlen and xstrcasecmp that expect char *, which does not
12653 conform to the C standard.
12654 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12655 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12656 char * when the C standard requires it.
12658 * keyboard.c (read_char): Remove unused var.
12660 * eval.c: Port to Windows vsnprintf (Bug#8435).
12661 Include <limits.h>.
12662 (SIZE_MAX): Define if the headers do not.
12663 (verror): Do not give up if vsnprintf returns a negative count.
12664 Instead, grow the buffer. This ports to Windows vsnprintf, which
12665 does not conform to C99. Problem reported by Eli Zaretskii.
12666 Also, simplify the allocation scheme, by avoiding the need for
12667 calling realloc, and removing the ALLOCATED variable.
12669 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12671 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12672 But keep the doprint source code for now, as we might revamp it
12673 and use it again (Bug#8435).
12674 * lisp.h (doprnt): Remove.
12675 * Makefile.in (base_obj): Remove doprnt.o.
12676 * deps.mk (doprnt.o): Remove.
12678 error: Print 32- and 64-bit integers portably (Bug#8435).
12679 Without this change, on typical 64-bit hosts error ("...%d...", N)
12680 was used to print both 32- and 64-bit integers N, which relied on
12681 undefined behavior.
12682 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
12683 * lisp.h (error, verror): Mark as printf-like functions.
12684 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12685 Report overflow in size calculations when allocating printf buffer.
12686 Do not truncate output string at its first null byte.
12687 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12688 Truncate the output at a character boundary, since vsnprintf does not
12690 * charset.c (check_iso_charset_parameter): Convert internal
12691 character to string before calling 'error', since %c now has the
12693 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12694 overflow when computing char to be passed to 'error'. Do not
12695 pass Lisp_Object to 'error'; pass the integer instead.
12696 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12697 formatted with plain %d.
12699 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12701 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12703 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12705 * xterm.c (x_catch_errors): Remove duplicate declaration.
12707 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12709 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12711 2011-04-10 Jim Meyering <meyering@redhat.com>
12713 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12714 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12715 return ssize_t not "int", and use size_t as the buffer length.
12716 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12717 * gnutls.h: Update declarations.
12718 * process.c (read_process_output): Use ssize_t, to match.
12719 (send_process): Likewise.
12721 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12723 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12725 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12727 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12728 Use unsigned char, to match FcChar8 type definition.
12730 * xterm.c (handle_one_xevent):
12731 * xmenu.c (create_and_show_popup_menu):
12732 * xselect.c (x_decline_selection_request)
12733 (x_reply_selection_request): Avoid type-punned deref of X events.
12735 2011-04-09 Eli Zaretskii <eliz@gnu.org>
12737 Fix some uses of `int' instead of EMACS_INT.
12738 * search.c (string_match_1, fast_string_match)
12739 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12740 (scan_buffer, find_next_newline_no_quit)
12741 (find_before_next_newline, search_command, Freplace_match)
12742 (Fmatch_data): Make some `int' variables be EMACS_INT.
12744 * xdisp.c (display_count_lines): 3rd argument and return value now
12745 EMACS_INT. All callers changed.
12746 (pint2hrstr): Last argument is now EMACS_INT.
12748 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12749 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12750 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12751 (decode_coding_utf_16, decode_coding_emacs_mule)
12752 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12753 (decode_coding_ccl, decode_coding_charset)
12754 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12755 (decode_coding_iso_2022, decode_coding_emacs_mule)
12756 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12757 <char_offset, last_offset>: Declare EMACS_INT.
12758 (encode_coding_utf_8, encode_coding_utf_16)
12759 (encode_coding_emacs_mule, encode_invocation_designation)
12760 (encode_designation_at_bol, encode_coding_iso_2022)
12761 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12762 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12764 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12765 (encode_invocation_designation): Last argument P_NCHARS is now
12767 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12768 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12770 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12773 * ccl.c (Fccl_execute_on_string): Declare some variables
12776 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
12778 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12780 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12782 * process.c (Fformat_network_address): Doc fix.
12784 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12786 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
12788 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
12790 * keyboard.c (read_char): Call Lisp function help-form-show,
12791 instead of using internal_with_output_to_temp_buffer.
12792 (Qhelp_form_show): New var.
12793 (syms_of_keyboard): Use DEFSYM macro.
12795 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12797 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12799 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
12801 * process.c (Flist_processes): Remove to Lisp.
12802 (list_processes_1): Delete.
12804 2011-04-06 Eli Zaretskii <eliz@gnu.org>
12806 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12808 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12810 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
12812 Fix more problems found by GCC 4.6.0's static checks.
12814 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12816 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12818 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
12820 * xdisp.c (vmessage): Mark as a printf-like function.
12822 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12824 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12826 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12827 printf-like functions.
12828 (tiff_load): Add casts to remove these marks before passing them
12829 to system-supplied API.
12831 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12833 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12834 This avoids several warnings with gcc -Wstrict-overflow.
12835 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12836 directly, rather than having caller test rule sign. This avoids
12837 some unnecessary tests.
12838 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12839 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12840 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
12842 * xfont.c (xfont_text_extents): Remove var that was set but not used.
12843 (xfont_open): Avoid unnecessary tests.
12845 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12847 * composite.h, composite.c (composition_gstring_put_cache):
12848 Use EMACS_INT, not int, for length.
12850 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12851 breaking out part of COMPOSITION_DECODE_RULE.
12852 (COMPOSITION_DECODE_RULE): Use it.
12853 * composite.c (get_composition_id): Remove unused local vars,
12854 by using the new macro.
12856 * textprop.c (set_text_properties_1): Change while to do-while,
12857 since the condition is always true at first.
12859 * intervals.c (graft_intervals_into_buffer): Mark var as used.
12860 (interval_deletion_adjustment): Return unsigned value.
12863 * process.c (list_processes_1, create_pty, read_process_output):
12864 (exec_sentinel): Remove vars that were set but not used.
12865 (create_pty): Remove unnecessary "volatile"s.
12866 (Fnetwork_interface_info): Avoid possibility of int overflow.
12867 (read_process_output): Do adaptive read buffering even if carryover.
12868 (read_process_output): Simplify nbytes computation if buffered.
12870 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12872 * syntax.c (scan_words): Remove var that was set but not used.
12873 (update_syntax_table): Use unsigned instead of int.
12875 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
12876 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
12877 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
12879 * print.c (print_error_message): Avoid int overflow.
12881 * font.c (font_list_entities): Redo for clarity,
12882 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12884 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
12885 (font_score): Avoid potential overflow in diff calculation.
12887 * fns.c (substring_both): Remove var that is set but not used.
12888 (sxhash): Redo loop for clarity and to avoid wraparound warning.
12890 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12892 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12893 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12894 can always succeed if overflow has undefined behavior.
12896 * search.c (boyer_moore, wordify): Remove vars set but not used.
12897 (wordify): Omit three unnecessary tests.
12899 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12900 All callers changed. This avoids the need for an unused var.
12902 * casefiddle.c (casify_region): Remove var that is set but not used.
12904 * dired.c (file_name_completion): Remove var that is set but not used.
12906 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12908 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
12909 (Finsert_file_contents): Remove unnecessary code checking fd.
12911 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12912 Check for integer overflow on size calculations.
12914 * buffer.c (Fprevious_overlay_change): Remove var that is set
12917 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12918 Remove vars that are set but not used.
12919 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
12920 (timer_check_2): Mark vars as initialized.
12922 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12924 * image.c (lookup_image): Remove var that is set but not used.
12925 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
12927 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12928 that are set but not used.
12930 * xfns.c (make_invisible_cursor): Don't return garbage
12931 if XCreateBitmapFromData fails (Bug#8410).
12933 * xselect.c (x_get_local_selection, x_handle_property_notify):
12934 Remove vars that are set but not used.
12936 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
12937 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
12939 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12940 Remove var that is set but not used.
12941 (scroll_bar_windows_size): Now size_t, not int.
12942 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12943 Check for overflow.
12945 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12946 (map_tty_color) [!defined MSDOS]: Likewise.
12948 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12950 * coding.c: Remove vars that are set but not used.
12951 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12952 All callers changed.
12953 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12954 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12955 (decode_coding_charset): Remove vars that are set but not used.
12957 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12958 that is set but not used.
12960 * print.c (print_object): Remove var that is set but not used.
12962 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
12963 The gnulib version avoids calling malloc in the usual case,
12964 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12965 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12966 * filelock.c (current_lock_owner): Likewise.
12967 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12968 * sysdep.c: Include allocator.h, careadlinkat.h.
12969 (emacs_no_realloc_allocator): New static constant.
12970 (emacs_readlink): New function.
12971 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12972 ../lib/careadlinkat.h.
12974 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12976 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12977 first non-nil return value).
12979 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12981 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12982 if not defined (Bug#8403).
12984 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12986 * xdisp.c (display_count_lines): Remove parameter `start',
12987 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12988 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12989 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12990 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12991 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12992 and thereabouts. All callers changed.
12993 (get_per_char_metric): Remove parameter `f', unused since
12994 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12996 2011-04-02 Jim Meyering <meyering@redhat.com>
12998 do not dereference NULL upon failed strdup
12999 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13000 (ns_get_family): Likewise.
13002 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13004 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13006 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13008 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13011 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13013 Add lexical binding.
13015 * window.c (Ftemp_output_buffer_show): New fun.
13016 (Fsave_window_excursion):
13017 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13019 * lread.c (lisp_file_lexically_bound_p): New function.
13020 (Fload): Bind Qlexical_binding.
13021 (readevalloop): Remove `evalfun' arg.
13022 Bind Qinternal_interpreter_environment.
13023 (Feval_buffer): Bind Qlexical_binding.
13024 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13026 (syms_of_lread): Declare `lexical-binding'.
13028 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13030 * keyboard.c (eval_dyn): New fun.
13031 (menu_item_eval_property): Use it.
13033 * image.c (parse_image_spec): Use Ffunctionp.
13035 * fns.c (concat, mapcar1): Accept byte-code-functions.
13037 * eval.c (Fsetq): Handle lexical vars.
13038 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13039 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13040 (FletX, Flet): Obey lexical binding.
13041 (Fcommandp): Handle closures.
13042 (Feval): New `lexical' arg.
13043 (eval_sub): New function extracted from Feval. Use it almost
13044 everywhere where Feval was used. Look up vars in lexical env.
13046 (Ffunctionp): Move from subr.el.
13047 (Ffuncall): Handle closures.
13048 (apply_lambda): Remove `eval_flags'.
13049 (funcall_lambda): Handle closures and new byte-code-functions.
13050 (Fspecial_variable_p): New function.
13051 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13052 but without exporting it to Lisp.
13054 * doc.c (Fdocumentation, store_function_docstring):
13055 * data.c (Finteractive_form): Handle closures.
13057 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13060 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13062 (exec_byte_code): New function extracted from Fbyte_code to handle new
13063 calling convention for byte-code-functions. Add new byte-codes.
13065 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
13067 * alloc.c (Fmake_symbol): Init new `declared_special' field.
13069 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13071 * xdisp.c (redisplay_internal): Fix prototype.
13073 2011-03-31 Eli Zaretskii <eliz@gnu.org>
13075 * xdisp.c (SCROLL_LIMIT): New macro.
13076 (try_scrolling): Use it when setting scroll_limit.
13077 Limit scrolling to 100 screen lines.
13078 (redisplay_window): Even when falling back on "recentering",
13079 position point in the window according to scroll-conservatively,
13080 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13082 (try_scrolling): When point is above the window, allow searching
13083 as far as scroll_max, or one screenful, to compute vertical
13084 distance from PT to the scroll margin position. This prevents
13085 try_scrolling from unnecessarily failing when
13086 scroll-conservatively is set to a value slightly larger than the
13087 window height. Clean up the case of PT below the margin at bottom
13088 of window: scroll_max can no longer be INT_MAX. When aggressive
13089 scrolling is in use, don't let point enter the opposite scroll
13090 margin as result of the scroll.
13091 (syms_of_xdisp) <scroll-conservatively>: Document the
13092 threshold of 100 lines for never-recentering scrolling.
13094 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13096 * dispextern.h (move_it_by_lines):
13097 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13098 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13099 (message_log_check_duplicate): Remove parameters `prev_bol' and
13100 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13101 (redisplay_internal): Remove parameter `preserve_echo_area',
13102 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13104 * indent.c (Fvertical_motion):
13105 * window.c (window_scroll_pixel_based, Frecenter):
13106 Don't pass `need_y_p' to `move_it_by_lines'.
13108 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13110 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13111 steal a few bits to be more compact.
13112 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13113 Remove unneeded casts.
13115 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13117 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13119 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13120 binding" message (bug#7967).
13122 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13124 Fix more problems found by GCC 4.6.0's static checks.
13126 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13127 Remove unused local var.
13129 * editfns.c (Fmessage_box): Remove unused local var.
13131 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13132 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13133 Omit unused local vars.
13134 * window.c (shrink_windows): Omit unused local var.
13135 * menu.c (digest_single_submenu): Omit unused local var.
13136 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13137 Omit unused local var.
13139 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13140 Don't assume string length fits in int.
13141 (keyremap_step, read_key_sequence): Use size_t for sizes.
13142 (read_key_sequence): Don't check last_real_key_start redundantly.
13144 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13145 instead of alloca (Bug#8344).
13147 * eval.c (Fbacktrace): Don't assume nargs fits in int.
13148 (Fbacktrace_frame): Don't assume nframes fits in int.
13150 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13152 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13155 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13157 * cm.c (calccost): Turn while-do into do-while, for clarity.
13159 * keyboard.c (syms_of_keyboard): Use the same style as later
13160 in this function when indexing through an array. This also
13161 works around GCC bug 48267.
13163 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13165 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13167 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13168 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13170 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13171 This avoids undefined behavior on integer overflow, and is a bit
13172 more convenient anyway since it is compared to a size_t variable.
13174 Variadic C functions now count arguments with size_t, not int.
13175 This avoids an unnecessary limitation on 64-bit machines, which
13176 caused (substring ...) to crash on large vectors (Bug#8344).
13177 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13178 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
13179 All variadic functions and their callers changed accordingly.
13180 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13181 * data.c (arith_driver, float_arith_driver): Likewise.
13182 * editfns.c (general_insert_function): Likewise.
13183 * eval.c (struct backtrace.nargs, interactive_p)
13184 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13185 (funcall_lambda, mark_backtrace): Likewise.
13186 * fns.c (concat): Likewise.
13187 * frame.c (x_set_frame_parameters): Likewise.
13188 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13189 0 if not found, not -1. All callers changed.
13191 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13192 (stack_copy_size): Now size_t, not int.
13193 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13195 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13197 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13198 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13199 All callers changed.
13201 * lisp.h (multibyte_char_to_unibyte):
13202 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13203 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13204 * character.h (CHAR_TO_BYTE8):
13205 * cmds.c (internal_self_insert):
13206 * editfns.c (general_insert_function):
13207 * keymap.c (push_key_description):
13208 * search.c (Freplace_match):
13209 * xdisp.c (message_dolog, set_message_1): All callers changed.
13211 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13213 * keyboard.c (safe_run_hook_funcall): New function.
13214 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13215 don't set the hook to nil, but remove the offending function instead.
13216 (Qcommand_hook_internal): Remove, unused.
13217 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13218 Vcommand_hook_internal.
13220 * eval.c (enum run_hooks_condition): Remove.
13221 (funcall_nil, funcall_not): New functions.
13222 (run_hook_with_args): Call each function through a `funcall' argument.
13223 Remove `cond' argument, now redundant.
13224 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13225 (Frun_hook_with_args_until_failure): Adjust accordingly.
13226 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13228 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13230 * dispextern.h (string_buffer_position): Remove declaration.
13232 * print.c (strout): Remove parameter `multibyte', unused since
13233 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13235 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13236 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13237 All callers changed.
13239 * w32.c (_wsa_errlist): Use braces for struct initializers.
13241 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13242 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13243 All callers changed.
13244 (string_buffer_position): Likewise. Also, make static (it's never
13245 used outside xdisp.c).
13246 (cursor_row_p): Remove parameter `w', unused since
13247 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13248 (decode_mode_spec): Remove parameter `precision', introduced during
13249 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13250 All callers changed.
13252 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13254 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13256 2011-03-27 Anders Lindgren <andlind@gmail.com>
13258 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13259 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13260 (ns_update_auto_hide_menu_bar): New functions.
13261 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13262 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13263 ns_constrain_all_frames.
13264 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13265 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13267 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13269 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13271 2011-03-27 Glenn Morris <rgm@gnu.org>
13273 * syssignal.h: Replace RETSIGTYPE with void.
13274 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13275 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13276 Replace SIGTYPE with void everywhere.
13277 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13278 * s/template.h (SIGTYPE): Remove commented out definition.
13280 2011-03-26 Eli Zaretskii <eliz@gnu.org>
13282 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13283 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13285 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
13287 * w32.c (read_unc_volume): Use parameter `henum', instead of
13288 global variable `wget_enum_handle'.
13290 * keymap.c (describe_vector): Remove parameters `indices' and
13291 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13292 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13294 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13296 * keyboard.c (timer_check): Remove parameter `do_it_now',
13297 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13298 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13299 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13301 * keyboard.c (read_char):
13302 * w32menu.c (w32_menu_display_help):
13303 * xmenu.c (show_help_event, menu_help_callback):
13304 Adjust calls to `show_help_echo'.
13306 * gtkutil.c (xg_maybe_add_timer):
13307 * keyboard.c (readable_events):
13308 * process.c (wait_reading_process_output):
13309 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13311 * insdel.c (adjust_markers_gap_motion):
13312 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13313 (gap_left, gap_right): Don't call it.
13315 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
13317 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13318 incurred during fontification.
13320 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13322 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13323 (DEFVAR_PER_BUFFER): Don't pass it.
13325 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13326 (scrolling_window): Don't pass it.
13328 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13330 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13332 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13334 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13335 of variables specific to SELinux and computation of `encoded_absname'.
13337 * image.c (XPutPixel): Remove unused variable `height'.
13339 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13341 * unexw32.c (get_section_info): Remove unused variable `section'.
13343 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13344 (system_process_attributes): Remove unused variable `sess'.
13345 (sys_read): Remove unused variable `err'.
13347 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13348 (w32_wnd_proc): Remove unused variable `isdead'.
13349 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13350 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13351 (x_create_tip_frame): Remove unused variable `tem'.
13353 * w32inevt.c (w32_console_read_socket):
13354 Remove unused variable `no_events'.
13356 * w32term.c (x_draw_composite_glyph_string_foreground):
13357 Remove unused variable `width'.
13359 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
13361 * w32term.c (x_set_glyph_string_clipping):
13362 Don't pass uninitialized region to CombineRgn.
13364 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
13366 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13367 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13368 (Fx_close_connection): Remove unused variable `i'.
13370 * w32font.c (w32font_draw): Return number of glyphs.
13371 (w32font_open_internal): Remove unused variable `i'.
13372 (w32font_driver): Add missing initializer.
13374 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13375 (fill_in_menu): Remove unused variable `items_added'.
13377 * w32term.c (last_mouse_press_frame): Remove static global variable.
13378 (w32_clip_to_row): Remove unused variable `f'.
13379 (x_delete_terminal): Remove unused variable `i'.
13381 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13382 (NOTHING): Remove unused static global variable.
13383 (uniscribe_check_otf): Remove unused variable `table'.
13384 (uniscribe_font_driver): Add missing initializers.
13386 2011-03-23 Julien Danjou <julien@danjou.info>
13388 * term.c (Fsuspend_tty, Fresume_tty):
13389 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13390 * window.c (temp_output_buffer_show):
13391 * insdel.c (signal_before_change):
13392 * frame.c (Fhandle_switch_frame):
13393 * fileio.c (Fdo_auto_save):
13394 * emacs.c (Fkill_emacs):
13395 * editfns.c (save_excursion_restore):
13396 * cmds.c (internal_self_insert):
13397 * callint.c (Fcall_interactively):
13398 * buffer.c (Fkill_all_local_variables):
13399 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13401 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
13402 unconditionally since it does the check itself.
13404 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
13406 Fix more problems found by GCC 4.5.2's static checks.
13408 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13409 the first time through the loop, since we know p0 < p1 then.
13410 This also avoids a gcc -Wstrict-overflow warning.
13412 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13413 leading to a memory leak, possible in functions like
13414 load_charset_map_from_file that can allocate an unbounded number
13415 of objects (Bug#8318).
13417 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13418 that could (at least in theory) be that large.
13420 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13421 This is less likely to overflow, and avoids undefined behavior if
13422 overflow does occur. All callers changed. Use strtoul to scan
13423 for the unsigned long integer.
13424 (pint2hrstr): Simplify and tune code slightly.
13425 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
13427 * scroll.c (do_scrolling): Work around GCC bug 48228.
13428 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13430 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13431 This also avoids a warning with gcc -Wstrict-overflow.
13432 (validate_x_resource_name): Simplify count usage.
13433 This also avoids a warning with gcc -Wstrict-overflow.
13435 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13438 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
13440 * process.c (Fmake_network_process): Use socklen_t, not int,
13441 where POSIX says socklen_t is required in portable programs.
13442 This fixes a porting bug on hosts like 64-bit HP-UX, where
13443 socklen_t is wider than int (Bug#8277).
13444 (Fmake_network_process, server_accept_connection):
13445 (wait_reading_process_output, read_process_output):
13448 * process.c: Rename or move locals to avoid shadowing.
13449 (list_processes_1, Fmake_network_process):
13450 (read_process_output_error_handler, exec_sentinel_error_handler):
13451 Rename or move locals.
13452 (Fmake_network_process): Define label "retry_connect" only if needed.
13453 (Fnetwork_interface_info): Fix pointer signedness.
13454 (process_send_signal): Add cast to avoid pointer signedness problem.
13455 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
13456 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
13458 Make tparam.h and terminfo.c consistent.
13459 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13460 Include tparam.h instead, since it declares them.
13461 * cm.h (PC): Remove extern decl; tparam.h now does this.
13462 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13463 * terminfo.c: Include tparam.h, to check interfaces.
13464 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13465 (tparam): Adjust signature to match interface in tparam.h;
13466 this removes some undefined behavior. Check that outstring and len
13467 are zero, which they always are with Emacs.
13468 * tparam.h (PC, BC, UP): New extern decls.
13470 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
13471 (xftfont_open): Rename locals to avoid shadowing.
13473 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
13474 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13475 (OTF_TAG_SYM): Omit macro if not needed.
13476 (ftfont_list): Remove unused local.
13477 (get_adstyle_property, ftfont_pattern_entity):
13478 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13479 Rename locals to avoid shadowing.
13481 * xfont.c (xfont_list_family): Mark var as initialized.
13483 * xml.c (make_dom): Now static.
13485 * composite.c (composition_compute_stop_pos): Rename local to
13487 (composition_reseat_it): Remove unused locals.
13488 (find_automatic_composition, composition_adjust_point): Likewise.
13489 (composition_update_it): Mark var as initialized.
13490 (find_automatic_composition): Mark vars as initialized,
13491 with a FIXME (Bug#8290).
13493 character.h: Rename locals to avoid shadowing.
13494 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13495 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13496 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13497 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13498 to avoid shadowing.
13500 * textprop.c (property_change_between_p): Remove; unused.
13502 * intervals.c (interval_start_pos): Now static.
13504 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13506 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13507 Rename locals to avoid shadowing.
13509 * sound.c (wav_play, au_play, Fplay_sound_internal):
13510 Fix pointer signedness.
13511 (alsa_choose_format): Remove unused local var.
13512 (wav_play): Initialize a variable to 0, to prevent undefined
13513 behavior (Bug#8278).
13515 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13517 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13519 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13520 clobbering (Bug#8298).
13521 * sysdep.c (sys_subshell): Likewise.
13522 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
13524 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13525 This should get cleaned up, so that child_setup has the
13526 same signature on all platforms.
13528 * callproc.c (call_process_cleanup): Now static.
13529 (relocate_fd): Rename locals to avoid shadowing.
13531 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
13533 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13534 not to be necessary, and produces flickering.
13536 2011-03-20 Glenn Morris <rgm@gnu.org>
13538 * config.in: Remove file.
13540 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
13542 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13543 are now in src/globals.h.
13544 (syms_of_minibuf): Remove spurious & from previous change.
13546 2011-03-20 Leo Liu <sdl.web@gmail.com>
13548 * minibuf.c (completing-read-function): New variable.
13549 (completing-read-default): Rename from completing-read.
13550 (completing-read): Call completing-read-function.
13552 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13554 * xfaces.c (Fx_load_color_file):
13555 Read color file from absolute filename (bug#8250).
13557 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13559 * makefile.w32-in: Update dependencies.
13561 2011-03-17 Eli Zaretskii <eliz@gnu.org>
13563 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13565 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13567 Fix more problems found by GCC 4.5.2's static checks.
13569 * process.c (make_serial_process_unwind, send_process_trap):
13570 (sigchld_handler): Now static.
13572 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13573 That way, the code declares only the vars that it needs.
13574 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13575 * s/cygwin.h (PTY_ITERATION): Likewise.
13576 * s/darwin.h (PTY_ITERATION): Likewise.
13577 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13579 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13580 * process.c (allocate_pty): Don't declare stb unless it's needed.
13582 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
13583 (CONSTANTLIM): Remove; unused.
13584 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13585 Define only if needed.
13587 * unexelf.c (unexec): Name an expression,
13588 to avoid gcc -Wbad-function-cast warning.
13589 Use a different way to cause a compilation error if anyone uses
13590 n rather than nn, a way that does not involve shadowing.
13591 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
13593 * deps.mk (unexalpha.o): Remove; unused.
13595 New file unexec.h, the (simple) interface for unexec (Bug#8267).
13596 * unexec.h: New file.
13597 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13598 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13599 Depend on unexec.h.
13600 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13601 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13602 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
13603 Change as necessary to match prototype in unexec.h.
13605 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13607 (back_comment, skip_chars): Mark vars as initialized.
13609 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13610 Rename locals to avoid shadowing.
13612 * lread.c (read1): Rewrite so as not to use empty "else".
13613 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
13615 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13617 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13618 warning when compiling print.c.
13620 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13621 instead of using an uninitialized var.
13622 (font_sort_entities): Mark var as initialized.
13624 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13626 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13627 pointers to constants.
13628 (font_parse_fcname): Remove unused vars.
13629 (font_delete_unmatched): Now static.
13630 (font_get_spec): Remove; unused.
13631 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13632 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13633 Rename or move locals to avoid shadowing.
13635 * fns.c (require_nesting_list, require_unwind): Now static.
13636 (Ffillarray): Rename locals to avoid shadowing.
13638 * floatfns.c (domain_error2): Define only if needed.
13639 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
13641 * alloc.c (mark_backtrace): Move decl from here ...
13642 * lisp.h: ... to here, so that it can be checked.
13644 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
13645 (Fdefvar): Rewrite so as not to use empty "else".
13646 (lisp_indirect_variable): Name an expression,
13647 to avoid gcc -Wbad-function-cast warning.
13648 (Fdefvar): Rename locals to avoid shadowing.
13650 * callint.c (quotify_arg, quotify_args): Now static.
13651 (Fcall_interactively): Rename locals to avoid shadowing.
13652 Use const pointer when appropriate.
13654 * lisp.h (get_system_name, get_operating_system_release):
13655 Move decls here, to check interfaces.
13656 * process.c (get_operating_system_release): Move decl to lisp.h.
13657 * xrdb.c (get_system_name): Likewise.
13658 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13659 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13660 some of which prompt warnings from gcc -Wbad-function-cast.
13661 (Fformat_time_string, Fencode_time, Finsert_char):
13662 (Ftranslate_region_internal, Fformat):
13663 Rename or remove local vars to avoid shadowing.
13664 (Ftranslate_region_internal): Mark var as initialized.
13666 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13669 * lisp.h (eassert): Check that the argument compiles, even if
13670 ENABLE_CHECKING is not defined.
13672 * data.c (Findirect_variable): Name an expression, to avoid
13673 gcc -Wbad-function-cast warning.
13674 (default_value, arithcompare, arith_driver, arith_error): Now static.
13675 (store_symval_forwarding): Rename local to avoid shadowing.
13676 (Fmake_variable_buffer_local, Fmake_local_variable):
13677 Mark variables as initialized.
13678 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
13680 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
13681 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13682 Rename locals to avoid shadowing.
13683 (mark_stack): Move local variables into the #ifdef region where
13685 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13686 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13688 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13689 (GC_STRING_CHARS): Remove; not used.
13690 (Fmemory_limit): Cast sbrk's returned value to char *.
13692 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13693 avoids undefined behavior in theory.
13695 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13697 Use functions, not macros, for up- and down-casing (Bug#8254).
13698 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13699 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13700 to use the following functions instead of these macros.
13701 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13702 EMACS_INT, since callers assume the returned value fits in int.
13703 (upcase1): Likewise, for UPCASE_TABLE.
13704 (uppercasep, lowercasep, upcase): New static inline functions.
13705 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
13706 the race-condition problem in the old DOWNCASE.
13708 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13709 Rename locals to avoid shadowing.
13710 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
13711 (regex_compile, re_search_2, re_match_2_internal):
13712 Remove unused local vars.
13713 (FREE_VAR): Rewrite so as not to use empty "else",
13714 which gcc can warn about.
13715 (regex_compile, re_match_2_internal): Mark locals as initialized.
13716 (RETALLOC_IF): Define only if needed.
13717 (WORDCHAR_P): Likewise. This one is never needed, but is used
13718 only in a comment talking about a compiler bug, so put inside
13719 the #if 0 of that comment.
13720 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13721 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13724 * search.c (boyer_moore): Rename locals to avoid shadowing.
13725 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13726 (PREV_CHAR_BOUNDARY): Likewise.
13728 * search.c (simple_search): Remove unused var.
13730 * dired.c (compile_pattern): Move decl from here ...
13731 * lisp.h: ... to here, so that it can be checked.
13732 (struct re_registers): New forward decl.
13734 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13736 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13738 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13739 Rename locals to avoid shadowing.
13740 (Fvertical_motion): Mark locals as initialized.
13742 * casefiddle.c (casify_object, casify_region): Now static.
13743 (casify_region): Mark local as initialized.
13745 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13747 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13748 New macros, so that the caller can use some names other than
13749 gcpro1, gcpro2, etc.
13750 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13752 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13753 argument, for consistency with GCPRO2_VAR, etc: it is now the
13754 prefix of the variable, not the variable itself. All uses
13756 * dired.c (directory_files_internal, file_name_completion):
13757 Rename locals to avoid shadowing.
13759 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13760 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13761 dired.c's scmp function, had undefined behavior.
13762 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13763 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13764 * buffer.h: ... to here, because these macros use current_buffer,
13765 and the new implementation with inline functions needs to have
13766 current_buffer in scope now, rather than later when the macros
13768 (downcase, upcase1): New static inline functions.
13769 (DOWNCASE, UPCASE1): Reimplement using these functions.
13770 This avoids undefined behavior in expressions like
13771 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13772 from race conditions in accessing the global variables
13773 case_temp1 and case_temp2.
13774 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13775 * lisp.h (case_temp1, case_temp2): Remove their decls.
13776 * character.h (ASCII_CHAR_P): Move from here ...
13777 * lisp.h: ... to here, so that the inline functions mentioned
13778 above can use them.
13780 * dired.c (directory_files_internal_unwind): Now static.
13782 * fileio.c (file_name_as_directory, directory_file_name):
13783 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13785 (file_name_as_directory): Use const pointers when appropriate.
13786 (Fexpand_file_name): Likewise. In particular, newdir might
13787 point at constant storage, so make it a const pointer.
13788 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
13789 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13791 (Fset_file_times, Finsert_file_contents, auto_save_error):
13792 Rename locals to avoid shadowing.
13794 * minibuf.c (choose_minibuf_frame_1): Now static.
13795 (Ftry_completion, Fall_completions): Rename or remove locals
13796 to avoid shadowing.
13798 * marker.c (bytepos_to_charpos): Remove; unused.
13800 * lisp.h (verify_bytepos, count_markers): New decls,
13801 so that gcc does not warn that these functions aren't declared.
13803 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13804 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
13805 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
13806 (copy_text): Remove unused local var.
13808 * filelock.c (within_one_second): Now static.
13809 (lock_file_1): Rename local to avoid shadowing.
13811 * buffer.c (fix_overlays_before): Mark locals as initialized.
13812 (fix_start_end_in_overlays): Likewise. This function should be
13813 simplified by using pointers-to-pointers, but that's a different
13815 (switch_to_buffer_1): Now static.
13816 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13817 (report_overlay_modification): Rename locals to avoid shadowing.
13819 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
13820 Fix pointer signedness issue.
13821 (sys_subshell): Mark local as volatile if checking for lint,
13822 to suppress a gcc -Wclobbered warning that does not seem to be right.
13823 (MAXPATHLEN): Define only if needed.
13825 * process.c (serial_open, serial_configure): Move decls from here ...
13826 * systty.h: ... to here, so that they can be checked.
13828 * fns.c (get_random, seed_random): Move extern decls from here ...
13829 * lisp.h: ... to here, so that they can be checked.
13831 * sysdep.c (reset_io): Now static.
13832 (wait_for_termination_signal): Remove; unused.
13834 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13835 (copy_keymap_item, append_key, push_text_char_description):
13837 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
13838 (DENSE_TABLE_SIZE): Remove; unused.
13839 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13840 (describe_map_tree):
13841 Rename locals to avoid shadowing.
13843 * keyboard.c: Declare functions static if they are not used elsewhere.
13844 (echo_char, echo_dash, cmd_error, top_level_2):
13845 (poll_for_input, handle_async_input): Now static.
13846 (read_char, kbd_buffer_get_event, make_lispy_position):
13847 (make_lispy_event, make_lispy_movement, apply_modifiers):
13848 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13849 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13850 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
13851 (read_key_sequence, read_char): Mark locals as initialized.
13852 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
13854 * keyboard.h (make_ctrl_char): New decl.
13855 (mark_kboards): Move decl here ...
13856 * alloc.c (mark_kboards): ... from here.
13858 * lisp.h (force_auto_save_soon): New decl.
13860 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
13861 (DEFINE_DUMMY_FUNCTION): New macro.
13862 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13864 (main): Add casts to avoid warnings
13865 if GCC considers string literals to be constants.
13867 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13869 * dbusbind.c: Pointer signedness fixes.
13870 (xd_signature, xd_append_arg, xd_initialize):
13871 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13872 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13873 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13874 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13876 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13877 if GCC considers string literals to be constants.
13878 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
13880 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13882 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13883 (print_preprocess, print_object): New macro to fix last change.
13885 * print.c (print_preprocess): Don't forget font objects.
13887 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
13889 * emacs.c (USAGE3): Doc fixes.
13891 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13893 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13896 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
13898 * lisp.h (VWindow_system, Qfile_name_history):
13899 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13900 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13901 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13903 * w32select.c: Don't #include "keyboard.h".
13904 (run_protected): Add extern declaration for waiting_for_input.
13906 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13907 * w32console.c (detect_input_pending, read_input_pending)
13908 (encode_terminal_code):
13909 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13910 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13911 (w32_system_caret_y, Qfile_name_history):
13912 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13913 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13914 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13915 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13916 * w32proc.c (Qlocal, report_file_error):
13917 * w32term.c (Vwindow_system, updating_frame):
13918 * w32uniscribe.c (initialized, uniscribe_font_driver):
13919 Remove unneeded extern declarations.
13921 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
13923 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
13925 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
13927 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13928 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13929 These macros can no longer be used for assignment.
13931 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13932 Assign struct members directly, instead of using BUF_BEGV etc.
13933 (record_buffer_markers, fetch_buffer_markers): New functions for
13934 recording and fetching special buffer markers.
13935 (set_buffer_internal_1, set_buffer_temp): Use them.
13937 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13939 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13941 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13942 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13944 * xdisp.c (hscroll_window_tree):
13945 (reconsider_clip_changes): Use PT instead of BUF_PT.
13947 2011-03-13 Eli Zaretskii <eliz@gnu.org>
13949 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13950 $(EMACS_ROOT)/lib/intprops.h.
13952 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13954 Fix more problems found by GCC 4.5.2's static checks.
13956 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13957 to unsigned char * to avoid compiler diagnostic.
13958 (xg_free_frame_widgets): Make it clear that a local variable is
13959 needed only if USE_GTK_TOOLTIP.
13960 (gdk_window_get_screen): Make it clear that this macro is needed
13961 only if USE_GTK_TOOLTIP.
13962 (int_gtk_range_get_value): New function, which avoids a diagnostic
13963 from gcc -Wbad-function-cast.
13964 (xg_set_toolkit_scroll_bar_thumb): Use it.
13965 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13966 diagnostic from gcc -Wbad-function-cast.
13967 (get_utf8_string, xg_get_file_with_chooser):
13968 Rename locals to avoid shadowing.
13969 (create_dialog): Move locals to avoid shadowing.
13971 * xgselect.c (xg_select): Remove unused var.
13973 * image.c (four_corners_best): Mark locals as initialized.
13974 (gif_load): Initialize transparent_p to zero (Bug#8238).
13975 Mark another local as initialized.
13976 (my_png_error, my_error_exit): Mark with NO_RETURN.
13978 * image.c (clear_image_cache): Now static.
13979 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
13980 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
13981 (x_edge_detection): Remove unnecessary cast that
13982 gcc -Wbad-function-cast diagnoses.
13983 (gif_load): Fix pointer signedness.
13984 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13985 (jpeg_load, gif_load): Rename locals to avoid shadowing.
13987 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
13989 Improve quality of tests for time stamp overflow.
13990 For example, without this patch (encode-time 0 0 0 1 1
13991 1152921504606846976) returns the obviously-bogus value (-948597
13992 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13993 reports time overflow. See
13994 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
13995 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13996 * editfns.c: Include limits.h and intprops.h.
13997 (TIME_T_MIN, TIME_T_MAX): New macros.
13998 (time_overflow): Move earlier, to before first use.
13999 (hi_time, lo_time): New functions, for an accurate test for
14000 out-of-range times.
14001 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14002 (Fget_internal_run_time): Don't assume time_t fits in int.
14003 (make_time): Use list2 instead of Fcons twice.
14004 (Fdecode_time): More accurate test for out-of-range times.
14005 (check_tm_member): New function.
14006 (Fencode_time): Use it, to test for out-of-range times.
14007 (lisp_time_argument): Don't rely on undefined left-shift and
14008 right-shift behavior when checking for time stamp overflow.
14010 * editfns.c (time_overflow): New function, refactoring common code.
14011 (Fformat_time_string, Fdecode_time, Fencode_time):
14012 (Fcurrent_time_string): Use it.
14014 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14015 * dired.c (make_time): Move to ...
14016 * editfns.c (make_time): ... here.
14017 * systime.h: Note the move.
14019 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14021 * fringe.c (update_window_fringes): Remove unused variables.
14023 * unexmacosx.c (copy_data_segment): Also copy __got section.
14026 2011-03-12 Eli Zaretskii <eliz@gnu.org>
14028 * termcap.c [MSDOS]: Include "msdos.h".
14029 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14030 Constify `char *' arguments and their references according to
14031 prototypes in tparam.h.
14033 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
14035 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14036 Adapt all references accordingly.
14038 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14040 2011-03-11 Tom Tromey <tromey@redhat.com>
14042 * buffer.c (syms_of_buffer): Remove obsolete comment.
14044 2011-03-11 Eli Zaretskii <eliz@gnu.org>
14046 * termhooks.h (encode_terminal_code): Declare prototype.
14048 * msdos.c (encode_terminal_code): Don't declare prototype.
14050 * term.c (encode_terminal_code): Now external again, used by
14051 w32console.c and msdos.c.
14053 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14054 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
14056 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
14058 Fix some minor problems found by GCC 4.5.2's static checks.
14060 * fringe.c (update_window_fringes): Mark locals as initialized
14062 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
14064 * alloc.c (mark_fringe_data): Move decl from here ...
14065 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14066 to check its interface.
14067 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14069 * fontset.c (free_realized_fontset): Now static.
14070 (Fset_fontset_font): Rename local to avoid shadowing.
14071 (fontset_font): Mark local as initialized.
14072 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
14074 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14076 * xselect.c (x_disown_buffer_selections): Remove; not used.
14077 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
14078 (x_own_selection, Fx_disown_selection_internal): Rename locals
14079 to avoid shadowing.
14080 (x_handle_dnd_message): Remove local to avoid shadowing.
14082 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14083 so that the caller can use some name other than gcpro1.
14084 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
14085 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14086 (Fx_backspace_delete_keys_p):
14087 Use them to avoid shadowing, and rename vars to avoid shadowing.
14088 (x_decode_color, x_set_name, x_window): Now static.
14089 (Fx_create_frame): Add braces to silence GCC warning.
14090 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
14091 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14092 Remove unused locals.
14093 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14094 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14095 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14098 * xterm.h (x_mouse_leave): New decl.
14100 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14101 Remove unused functions.
14102 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14103 (x_calc_absolute_position): Now static.
14104 (XTread_socket): Don't define label "out" unless it's used.
14105 Don't declare local "event" unless it's used.
14106 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14107 unless they are used.
14108 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14109 (x_fatal_error_signal): Remove; not used.
14110 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14111 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14112 (x_error_catcher, x_connection_closed, x_error_handler):
14113 (x_error_quitter, xembed_send_message, x_iconify_frame):
14114 (my_log_handler): Rename locals to avoid shadowing.
14115 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
14116 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
14118 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14119 Rename or move locals to avoid shadowing.
14120 (tty_defined_color, merge_face_heights): Now static.
14121 (free_realized_faces_for_fontset): Remove; not used.
14122 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14123 does not deduce is never used uninitialized.
14124 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14125 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
14127 * terminal.c (store_terminal_param): Now static.
14129 * xmenu.c (menu_highlight_callback): Now static.
14130 (set_frame_menubar): Remove unused local.
14131 (xmenu_show): Rename parameter to avoid shadowing.
14132 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14133 since they might point to immutable storage.
14134 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14135 since it's unused otherwise.
14137 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
14138 Add a FIXME, since the code still doesn't look right. (Bug#8215)
14139 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14140 avoids a gcc -Wuninitialized diagnostic.
14141 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
14142 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14143 does not deduce are never used uninitialized.
14145 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14147 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
14148 * window.c (window_loop, size_window):
14149 (run_window_configuration_change_hook, enlarge_window): Likewise.
14151 * window.c (display_buffer): Now static.
14152 (size_window): Mark variables that gcc -Wuninitialized
14153 does not deduce are never used uninitialized.
14154 * window.h (check_all_windows): New decl, to forestall
14155 gcc -Wmissing-prototypes diagnostic.
14156 * dispextern.h (bidi_dump_cached_states): Likewise.
14158 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14160 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
14161 Include <limits.h>.
14162 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14163 and to avoid gcc -Wuninitialized warning.
14164 (load_charset_map): Mark variables that gcc -Wuninitialized
14165 does not deduce are never used uninitialized.
14166 (load_charset): Abort instead of using uninitialized var (Bug#8229).
14168 * coding.c (coding_set_source, coding_set_destination):
14169 Use "else { /* comment */ }" rather than "else /* comment */;"
14170 for clarity, and to avoid gcc -Wempty-body warning.
14171 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14172 a block, when the outer 'i' will do.
14173 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14174 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14175 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14176 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14177 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14178 Rename locals to avoid shadowing.
14179 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
14180 * coding.c (emacs_mule_char, encode_invocation_designation):
14181 Now static, since they're not used elsewhere.
14182 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
14183 (decode_coding_object, encode_coding_object, detect_coding_system):
14184 (decode_coding_emacs_mule): Mark variables that gcc
14185 -Wuninitialized does not deduce are never used uninitialized.
14186 (detect_coding_iso_2022): Initialize a local variable that might
14187 be used uninitialized. Leave a FIXME because it's not clear that
14188 this initialization is needed. (Bug#8211)
14189 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14190 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14191 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14192 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14193 Remove unused macros.
14195 * category.c (hash_get_category_set): Remove unused local var.
14196 (copy_category_table): Now static, since it's not used elsewhere.
14197 * character.c (string_count_byte8): Likewise.
14199 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14200 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14202 * chartab.c (copy_sub_char_table): Now static, since it's not used
14204 (sub_char_table_ref_and_range, char_table_ref_and_range):
14205 Rename locals to avoid shadowing.
14206 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
14208 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
14209 (BIDI_BOB): Remove unused macro.
14211 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14212 deduce are never used uninitialized.
14213 * term.c (encode_terminal_code): Likewise.
14215 * term.c (encode_terminal_code): Now static. Remove unused local.
14217 * tparam.h: New file.
14218 * term.c, tparam.h: Include it.
14219 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14220 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14221 Move these decls to tparam.h, and make them agree with what
14222 is actually in tparam.c. The previous trick of using incompatible
14223 decls in different modules does not conform to the C standard.
14224 All callers of tparam changed to use tparam's actual API.
14225 * tparam.c (tparam1, tparam, tgoto):
14226 Use const pointers where appropriate.
14228 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14229 * cm.h (struct cm): Likewise.
14230 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14231 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14232 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14233 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14234 (turn_on_face, init_tty): Likewise.
14235 * termchar.h (struct tty_display_info): Likewise.
14237 * term.c (term_mouse_position): Rename local to avoid shadowing.
14239 * alloc.c (mark_ttys): Move decl from here ...
14240 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14242 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14244 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14246 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
14248 * search.c (compile_pattern_1): Remove argument regp, unused since
14249 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14250 (compile_pattern): Don't pass it.
14252 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14254 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14255 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14257 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14259 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14261 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14262 gdk_window_get_screen, gdk_window_get_geometry,
14263 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14264 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14265 (xg_get_pixbuf_from_pixmap): New function.
14266 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14267 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14268 Call xg_get_pixbuf_from_pixmap instead of
14269 gdk_pixbuf_get_from_drawable.
14270 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14271 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14272 (xg_check_special_colors): Use GtkStyleContext and its functions
14274 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14275 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14276 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
14277 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14278 Call gtk_widget_get_preferred_size.
14279 (xg_frame_resized): gdk_window_get_geometry only takes 5
14281 (xg_win_to_widget, xg_event_is_for_menubar):
14282 Call gdk_x11_window_lookup_for_display.
14283 (xg_set_widget_bg): New function.
14284 (delete_cb): New function.
14285 (xg_create_frame_widgets): Connect delete-event to delete_cb.
14286 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
14287 (xg_set_background_color): Call xg_set_widget_bg.
14288 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14289 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14290 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14291 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14293 (update_frame_tool_bar): Call gtk_widget_hide.
14294 (xg_initialize): Use GDK_KEY_g.
14296 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14298 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14300 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14301 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14302 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14304 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
14306 * w32xfns.c (select_palette): Check success of RealizePalette against
14307 GDI_ERROR, not zero.
14309 See ChangeLog.11 for earlier changes.
14311 ;; Local Variables:
14315 Copyright (C) 2011-2012 Free Software Foundation, Inc.
14317 This file is part of GNU Emacs.
14319 GNU Emacs is free software: you can redistribute it and/or modify
14320 it under the terms of the GNU General Public License as published by
14321 the Free Software Foundation, either version 3 of the License, or
14322 (at your option) any later version.
14324 GNU Emacs is distributed in the hope that it will be useful,
14325 but WITHOUT ANY WARRANTY; without even the implied warranty of
14326 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14327 GNU General Public License for more details.
14329 You should have received a copy of the GNU General Public License
14330 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.