1 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3 * alloc.c (refill_memory_reserve): Now static if
4 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5 * lisp.h (refill_memory_reserve): Declare only if not static.
7 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8 Define only if USE_LUCID.
10 * xrdb.c (x_customization_string, x_rm_string): Now static.
12 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
13 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
15 * xdisp.c (draw_row_with_mouse_face): Now static.
16 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
18 * window.h (check_all_windows): Mark externally visible.
20 * window.c (window_deletion_count): Now static.
22 * undo.c: Make symbols static if they're not exported.
23 (last_undo_buffer, last_boundary_position, pending_boundary):
26 * textprop.c (interval_insert_behind_hooks): Now static.
27 (interval_insert_in_front_hooks): Likewise.
29 * term.c: Make symbols static if they're not exported.
30 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
31 (max_frame_lines, tty_set_terminal_modes):
32 (tty_reset_terminal_modes, tty_turn_off_highlight):
33 (get_tty_terminal): Now static.
34 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
35 * termhooks.h (term_mouse_moveto): Do not declare if
37 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
38 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
40 * sysdep.c: Make symbols static if they're not exported.
41 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
43 (sigprocmask_set, full_mask): Remove; unused.
44 (wait_debugging): Mark as visible.
45 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
46 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
48 * syntax.c (syntax_temp): Define only if !__GNUC__.
50 * sound.c (current_sound_device, current_sound): Now static.
52 * search.c (searchbufs, searchbuf_head): Now static.
54 * scroll.c (scroll_cost): Remove; unused.
55 * dispextern.h (scroll_cost): Remove decl.
57 * region-cache.h (pp_cache): Mark as externally visible.
59 * process.c: Make symbols static if they're not exported.
60 (process_tick, update_tick, create_process, chan_process):
61 (Vprocess_alist, proc_buffered_char, datagram_access):
62 (fd_callback_data, send_process_frame, process_sent_to): Now static.
63 (deactivate_process): Mark defn as static, as well as decl.
64 * lisp.h (create_process): Remove decl.
65 * process.h (chan_process, Vprocess_alist): Remove decls.
67 * print.c: Make symbols static if they're not exported.
68 (print_depth, new_backquote_output, being_printed, print_buffer):
69 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
70 (print_interval, print_number_index, initial_stderr_stream):
72 * lisp.h (Fprinc): Remove decl.
73 (debug_output_compilation_hack): Mark as externally visible.
75 * sysdep.c (croak): Move decl from here to syssignal.h.
76 * syssignal.h (croak): Put it here, so the API can be checked when
77 'croak' is called from dissociate_if_controlling_tty.
79 * minibuf.c: Make symbols static if they're not exported.
80 (minibuf_save_list, choose_minibuf_frame): Now static.
81 * lisp.h (choose_minibuf_frame): Remove decl.
83 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
85 * lread.c: Make symbols static if they're not exported.
86 (read_objects, initial_obarray, oblookup_last_bucket_number):
88 (make_symbol): Remove; unused.
89 * lisp.h (initial_obarray, make_symbol): Remove decls.
91 * keyboard.c: Make symbols static if they're not exported.
92 (single_kboard, recent_keys_index, total_keys, recent_keys):
93 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
94 (this_single_command_key_start, echoing, last_auto_save):
95 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
96 (command_loop, echo_now, keyboard_init_hook, help_char_p):
97 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
98 (Vlispy_mouse_stem, double_click_count):
100 (force_auto_save_soon): Define only if SIGDANGER.
101 (ignore_mouse_drag_p): Now static if
102 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
103 (print_help): Remove; unused.
104 (stop_character, last_timer_event): Mark as externally visible.
105 * keyboard.h (ignore_mouse_drag_p): Declare only if
106 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
107 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
108 * lisp.h (echoing): Remove decl.
109 (force_auto_save_soon): Declare only if SIGDANGER.
110 * xdisp.c (redisplay_window): Simplify code, to make it more
111 obvious that ignore_mouse_drag_p is not accessed if !defined
112 USE_GTK && !defined HAVE_NS.
114 * intervals.c: Make symbols static if they're not exported.
115 (merge_properties_sticky, merge_interval_right, delete_interval):
117 * intervals.h (merge_interval_right, delete_interval): Remove decls.
119 2011-04-13 Paul Eggert <eggert@cs.ucla.edu>
121 * insdel.c: Make symbols static if they're not exported.
122 However, leave prepare_to_modify_buffer alone. It's never
123 called from outside this function, but that appears to be a bug.
124 (combine_after_change_list, combine_after_change_buffer):
125 (adjust_after_replace, signal_before_change): Now static.
126 (adjust_after_replace_noundo): Remove; unused.
127 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
128 (signal_before_change): Remove decls.
130 * indent.c (val_compute_motion, val_vmotion): Now static.
132 * image.c: Make symbols static if they're not exported.
133 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
135 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
136 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
138 * fringe.c (standard_bitmaps): Now static.
139 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
141 * frame.c: Make symbols static if they're not exported.
142 (x_report_frame_params, make_terminal_frame): Now static.
143 (get_frame_param): Now static, unless HAVE_NS.
144 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
145 (x_get_resource_string): Remove; not used.
146 * frame.h (make_terminal_frame, x_report_frame_params):
147 (x_get_resource_string); Remove decls.
148 (x_fullscreen_adjust): Declare only if WINDOWSNT.
149 * lisp.h (get_frame_param): Declare only if HAVE_NS.
151 * font.c, fontset.c: Make symbols static if they're not exported.
152 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
153 (FACE_SUITABLE_FOR_CHAR_P): Use it.
154 * font.c (font_close_object): Now static.
155 * font.h (font_close_object): Remove.
156 * fontset.c (FONTSET_OBJLIST): Remove.
157 (free_realized_fontset) #if-0 the body, which does nothing.
158 (face_suitable_for_char_p): #if-0, as it's never called.
159 * fontset.h (face_suitable_for_char_p): Remove decl.
160 * xfaces.c (face_at_string_position): Use
161 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
162 since 0 is always ASCII.
164 * fns.c (weak_hash_tables): Now static.
166 * fileio.c: Make symbols static if they're not exported.
167 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
168 (Vwrite_region_annotation_buffers): Now static.
170 * eval.c: Make symbols static if they're not exported.
171 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
172 * lisp.h (backtrace_list): Remove decl.
174 * emacs.c: Make symbols static if they're not exported.
175 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
176 (fatal_error_code, fatal_error_signal_hook, standard_args):
178 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
179 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
180 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
181 * lisp.h (fatal_error_signal_hook): Remove decl.
182 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
184 * editfns.c: Move a (normally-unused) function to its only use.
185 * editfns.c, lisp.h (get_operating_system_release): Remove.
186 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
187 worth the hassle of breaking this out.
189 * xterm.c: Make symbols static if they're not exported.
190 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
191 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
192 (x_destroy_window, x_delete_display):
194 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
195 (x_mouse_leave): Remove; unused.
196 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
197 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
198 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
200 (x_mouse_leave): Declare only if WINDOWSNT.
201 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
202 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
205 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
207 * ftxfont.c: Make symbols static if they're not exported.
208 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
210 * font.h (ftxfont_driver): Likewise.
212 * xfns.c: Make symbols static if they're not exported.
213 (x_last_font_name, x_display_info_for_name):
214 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
215 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
216 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
217 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
218 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
219 (last_show_tip_args): Now static.
220 (xic_defaut_fontset, xic_create_fontsetname): Define only if
221 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
222 (x_screen_planes): Remove; unused.
223 * dispextern.h (x_screen_planes): Remove decl.
225 * dispnew.c: Make symbols static if they're not exported.
226 * dispextern.h (redraw_garbaged_frames, scrolling):
227 (increment_row_positions): Remove.
228 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
229 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
231 (redraw_garbaged_frames): Remove; unused.
233 * xfaces.c: Make symbols static if they're not exported.
234 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
236 * xterm.h (defined_color): Remove decls.
237 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
238 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
239 (menu_face_changed_default, defined_color, free_realized_face):
240 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
241 (ascii_face_of_lisp_face): Remove; unused.
243 * xdisp.c: Make symbols static if they're not exported.
244 * dispextern.h (scratch_glyph_row, window_box_edges):
245 (glyph_to_pixel_coords, set_cursor_from_row):
246 (get_next_display_element, set_iterator_to_next):
247 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
248 (show_mouse_face): Remove decls
249 * frame.h (message_buf_print): Likewise.
250 * lisp.h (pop_message, set_message, check_point_in_composition):
252 * xterm.h (set_vertical_scroll_bar): Likewise.
253 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
254 (message_buf_print, scratch_glyph_row, displayed_buffer):
255 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
256 (get_next_display_element, show_mouse_face, window_box_edges):
257 (frame_to_window_pixel_xy, check_point_in_composition):
258 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
259 (glyph_to_pixel_coords): Remove; unused.
261 * dired.c (file_name_completion): Now static.
263 * dbusbind.c (xd_in_read_queued_messages): Now static.
265 * lisp.h (circular_list_error, FOREACH): Remove; unused.
266 * data.c (circular_list_error): Remove.
268 2011-04-11 Paul Eggert <eggert@cs.ucla.edu>
270 * commands.h (last_point_position, last_point_position_buffer):
271 (last_point_position_window): Remove decls.
272 * keyboard.c: Make these variables static.
274 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
276 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
277 (iso_code_class, detect_coding, code_convert_region): Now static.
278 (encode_coding_gap): Remove; unused.
280 * chartab.c (chartab_chars, chartab_bits): Now static.
282 * charset.h (charset_iso_8859_1): Remove decl.
283 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
286 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
287 * ccl.c (Vccl_program_table): Now static.
288 (check_ccl_update): Remove; unused.
290 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
291 * category.h: ... from here.
292 * category.c (check_category_table, set_category_set): Now static.
294 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
295 * lisp.h: Remove these decls.
297 * buffer.c (buffer_count): Remove unused var.
299 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
300 so that it's not optimized away.
301 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
302 * dispextern.h (bidi_dump_cached_states): Remove, since it's
303 exported only to the debugger.
305 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
306 * atimer.h (run_all_atimers): Removed; not exported.
308 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
309 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
310 was inaccessible from Lisp.
311 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
312 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
314 alloc.c: Import and export fewer symbols, and remove unused items.
315 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
317 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
318 it's not optimized away by whole-program optimization.
319 (message_enable_multibyte, free_misc): Remove.
320 (catchlist, handlerlist, mark_backtrace):
321 Declare only if BYTE_MARK_STACK.
322 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
323 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
324 (message_enable_multibyte): Remove decl.
325 (free_misc, interval_free_list, float_block, float_block_index):
326 (n_float_blocks, float_free_list, cons_block, cons_block_index):
327 (cons_free_list, last_marked_index):
329 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
330 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
331 (mark_backtrace): Define only if BYTE_MARK_STACK.
332 * xdisp.c (message_enable_multibyte): Now static.
334 Declare Lisp_Object Q* variables to be 'static' if not exproted.
335 This makes it easier for human readers (and static analyzers)
336 to see whether these variables are used from other modules.
337 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
338 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
339 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
340 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
341 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
342 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
343 * xmenu.c, xselect.c:
344 Declare Q* vars static if they are not used in other modules.
345 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
346 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
347 Remove decls of unexported vars.
348 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
350 * lisp.h (DEFINE_FUNC): Make sname 'static'.
352 Make Emacs functions such as Fatom 'static' by default.
353 This makes it easier for human readers (and static analyzers)
354 to see whether these functions can be called from other modules.
355 DEFUN now defines a static function. To make the function external
356 so that it can be used in other C modules, use the new macro DEFUE.
357 * lisp.h (DEFINE_FUNC): New macro, with the old contents of DEFUN.
358 (DEFUN): Rewrite in terms of DEFINE_FUNC. It now generates a
359 static function definition. Use DEFUE if you want an extern one.
360 (DEFUE, INFUN): New macros.
361 (Funibyte_char_to_multibyte, Fsyntax_table_p, Finit_image_library):
362 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
363 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
364 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
365 Remove decls, since these functions are now static.
366 (Funintern, Fget_internal_run_time): New decls, since these functions
367 were already external.
369 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
370 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
371 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
372 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
373 * keyboard.c, keymap.c, lread.c:
374 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
375 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
376 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
377 Mark functions with DEFUE instead of DEFUN,
378 if they are used in other modules.
379 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
380 decls for now-static functions.
381 * buffer.h (Fdelete_overlay): Remove decl.
382 * callproc.c (Fgetenv_internal): Mark as internal.
383 * composite.c (Fremove_list_of_text_properties): Remove decl.
384 (Fcomposition_get_gstring): New forward static decl.
385 * composite.h (Fcomposite_get_gstring): Remove decl.
386 * dired.c (Ffile_attributes): New forward static decl.
387 * doc.c (Fdocumntation_property): New forward static decl.
388 * eval.c (Ffetch_bytecode): New forward static decl.
389 (Funintern): Remove extern decl; now in .h file where it belongs.
390 * fileio.c (Fmake_symbolic_link): New forward static decl.
391 * image.c (Finit_image_library): New forward static decl.
392 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
393 * intervals.h (Fprevious_property_change):
394 (Fremove_list_of_text_properties): Remove decls.
395 * keyboard.c (Fthis_command_keys): Remove decl.
396 (Fcommand_execute): New forward static decl.
397 * keymap.c (Flookup_key): New forward static decl.
398 (Fcopy_keymap): Now static.
399 * keymap.h (Flookup_key): Remove decl.
400 * process.c (Fget_process): New forward static decl.
401 (Fprocess_datagram_address): Mark as internal.
402 * syntax.c (Fsyntax_table_p): New forward static decl.
403 (skip_chars): Remove duplicate decl.
404 * textprop.c (Fprevious_property_change): New forward static decl.
405 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
407 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
408 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
410 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
412 * editfns.c (Fformat): Remove unreachable code.
414 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
416 Fix more problems found by GCC 4.6.0's static checks.
418 * xdisp.c (vmessage): Use a better test for character truncation.
420 * charset.c (load_charset_map): <, not <=, for optimization,
421 and to avoid potential problems with integer overflow.
422 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
423 * casetab.c (set_identity, shuffle): Likewise.
424 * editfns.c (Fformat): Likewise.
425 * syntax.c (skip_chars): Likewise.
427 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
428 This also lets GCC 4.6.0 generate slightly better loop code.
430 * callint.c (Fcall_interactively): <, not <=, for optimization.
431 (Fcall_interactively): Count the number of arguments produced,
432 not the number of arguments given. This is simpler and lets GCC
433 4.6.0 generate slightly better code.
435 * ftfont.c: Distingish more carefully between FcChar8 and char.
436 The previous code passed unsigned char * to a functions like
437 strlen and xstrcasecmp that expect char *, which does not
438 conform to the C standard.
439 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
440 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
441 char * when the C standard requires it.
443 * keyboard.c (read_char): Remove unused var.
445 * eval.c: Port to Windows vsnprintf (Bug#8435).
447 (SIZE_MAX): Define if the headers do not.
448 (verror): Do not give up if vsnprintf returns a negative count.
449 Instead, grow the buffer. This ports to Windows vsnprintf, which
450 does not conform to C99. Problem reported by Eli Zaretskii.
451 Also, simplify the allocation scheme, by avoiding the need for
452 calling realloc, and removing the ALLOCATED variable.
454 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
456 Remove invocations of doprnt, as Emacs now uses vsnprintf.
457 But keep the doprint source code for now, as we might revamp it
458 and use it again (Bug#8435).
459 * lisp.h (doprnt): Remove.
460 * Makefile.in (base_obj): Remove doprnt.o.
461 * deps.mk (doprnt.o): Remove.
463 error: Print 32- and 64-bit integers portably (Bug#8435).
464 Without this change, on typical 64-bit hosts error ("...%d...", N)
465 was used to print both 32- and 64-bit integers N, which relied on
467 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
469 * lisp.h (error, verror): Mark as printf-like functions.
470 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
471 Report overflow in size calculations when allocating printf buffer.
472 Do not truncate output string at its first null byte.
473 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
474 Truncate the output at a character boundary, since vsnprintf does not
476 * charset.c (check_iso_charset_parameter): Convert internal
477 character to string before calling 'error', since %c now has the
479 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
480 overflow when computing char to be passed to 'error'. Do not
481 pass Lisp_Object to 'error'; pass the integer instead.
482 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
483 formatted with plain %d.
485 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
487 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
489 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
491 * xterm.c (x_catch_errors): Remove duplicate declaration.
493 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
495 * xdisp.c, lisp.h (message_nolog): Remove; unused.
497 2011-04-10 Jim Meyering <meyering@redhat.com>
499 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
500 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
501 return ssize_t not "int", and use size_t as the buffer length.
502 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
503 * gnutls.h: Update declarations.
504 * process.c (read_process_output): Use ssize_t, to match.
505 (send_process): Likewise.
507 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
509 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
511 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
513 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
514 unsigned char, to match FcChar8 type definition.
516 * xterm.c (handle_one_xevent):
517 * xmenu.c (create_and_show_popup_menu):
518 * xselect.c (x_decline_selection_request)
519 (x_reply_selection_request): Avoid type-punned deref of X events.
521 2011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
523 Fix some uses of `int' instead of EMACS_INT.
524 * search.c (string_match_1, fast_string_match)
525 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
526 (scan_buffer, find_next_newline_no_quit)
527 (find_before_next_newline, search_command, Freplace_match)
528 (Fmatch_data): Make some `int' variables be EMACS_INT.
530 * xdisp.c (display_count_lines): 3rd argument and return value now
531 EMACS_INT. All callers changed.
532 (pint2hrstr): Last argument is now EMACS_INT.
534 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
535 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
536 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
537 (decode_coding_utf_16, decode_coding_emacs_mule)
538 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
539 (decode_coding_ccl, decode_coding_charset)
540 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
541 (decode_coding_iso_2022, decode_coding_emacs_mule)
542 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
543 <char_offset, last_offset>: Declare EMACS_INT.
544 (encode_coding_utf_8, encode_coding_utf_16)
545 (encode_coding_emacs_mule, encode_invocation_designation)
546 (encode_designation_at_bol, encode_coding_iso_2022)
547 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
548 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
550 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
551 (encode_invocation_designation): Last argument P_NCHARS is now
553 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
554 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
556 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
559 * ccl.c (Fccl_execute_on_string): Declare some variables
562 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
564 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
566 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
568 * process.c (Fformat_network_address): Doc fix.
570 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
572 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
574 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
576 * keyboard.c (read_char): Call Lisp function help-form-show,
577 instead of using internal_with_output_to_temp_buffer.
578 (Qhelp_form_show): New var.
579 (syms_of_keyboard): Use DEFSYM macro.
581 * print.c (internal_with_output_to_temp_buffer): Function deleted.
583 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
585 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
587 * process.c (Flist_processes): Removed to Lisp.
588 (list_processes_1): Deleted.
590 2011-04-06 Eli Zaretskii <eliz@gnu.org>
592 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
594 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
596 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
598 Fix more problems found by GCC 4.6.0's static checks.
600 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
602 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
604 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
606 * xdisp.c (vmessage): Mark as a printf-like function.
608 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
610 * sound.c (sound_warning): Don't crash if arg contains a printf format.
612 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
613 printf-like functions.
614 (tiff_load): Add casts to remove these marks before passing them
615 to system-supplied API.
617 * eval.c (Fsignal): Remove excess argument to 'fatal'.
619 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
620 This avoids several warnings with gcc -Wstrict-overflow.
621 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
622 directly, rather than having caller test rule sign. This avoids
623 some unnecessary tests.
624 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
625 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
626 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
628 * xfont.c (xfont_text_extents): Remove var that was set but not used.
629 (xfont_open): Avoid unnecessary tests.
631 * composite.c (composition_gstring_put_cache): Use unsigned integer.
633 * composite.h, composite.c (composition_gstring_put_cache):
634 Use EMACS_INT, not int, for length.
636 * composite.h (COMPOSITION_DECODE_REFS): New macro,
637 breaking out part of COMPOSITION_DECODE_RULE.
638 (COMPOSITION_DECODE_RULE): Use it.
639 * composite.c (get_composition_id): Remove unused local vars,
640 by using the new macro.
642 * textprop.c (set_text_properties_1): Change while to do-while,
643 since the condition is always true at first.
645 * intervals.c (graft_intervals_into_buffer): Mark var as used.
646 (interval_deletion_adjustment): Return unsigned value.
649 * process.c (list_processes_1, create_pty, read_process_output):
650 (exec_sentinel): Remove vars that were set but not used.
651 (create_pty): Remove unnecessary "volatile"s.
652 (Fnetwork_interface_info): Avoid possibility of int overflow.
653 (read_process_output): Do adaptive read buffering even if carryover.
654 (read_process_output): Simplify nbytes computation if buffered.
656 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
658 * syntax.c (scan_words): Remove var that was set but not used.
659 (update_syntax_table): Use unsigned instead of int.
661 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
662 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
663 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
665 * print.c (print_error_message): Avoid int overflow.
667 * font.c (font_list_entities): Redo for clarity,
668 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
670 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
671 (font_score): Avoid potential overflow in diff calculation.
673 * fns.c (substring_both): Remove var that is set but not used.
674 (sxhash): Redo loop for clarity and to avoid wraparound warning.
676 * eval.c (funcall_lambda): Rename local to avoid shadowing.
678 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
679 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
680 can always succeed if overflow has undefined behavior.
682 * search.c (boyer_moore, wordify): Remove vars set but not used.
683 (wordify): Omit three unnecessary tests.
685 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
686 All callers changed. This avoids the need for an unused var.
688 * casefiddle.c (casify_region): Remove var that is set but not used.
690 * dired.c (file_name_completion): Remove var that is set but not used.
692 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
694 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
695 (Finsert_file_contents): Remove unnecessary code checking fd.
697 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
698 Check for integer overflow on size calculations.
700 * buffer.c (Fprevious_overlay_change): Remove var that is set
703 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
704 Remove vars that are set but not used.
705 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
706 (timer_check_2): Mark vars as initialized.
708 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
710 * image.c (lookup_image): Remove var that is set but not used.
711 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
713 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
714 that are set but not used.
716 * xfns.c (make_invisible_cursor): Don't return garbage
717 if XCreateBitmapFromData fails (Bug#8410).
719 * xselect.c (x_get_local_selection, x_handle_property_notify):
720 Remove vars that are set but not used.
722 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
723 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
725 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
726 Remove var that is set but not used.
727 (scroll_bar_windows_size): Now size_t, not int.
728 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
731 * xfaces.c (realize_named_face): Remove vars that are set but not used.
732 (map_tty_color) [!defined MSDOS]: Likewise.
734 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
736 * coding.c: Remove vars that are set but not used.
737 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
739 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
740 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
741 (decode_coding_charset): Remove vars that are set but not used.
743 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
744 that is set but not used.
746 * print.c (print_object): Remove var that is set but not used.
748 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
749 The gnulib version avoids calling malloc in the usual case,
750 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
751 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
752 * filelock.c (current_lock_owner): Likewise.
753 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
754 * sysdep.c: Include allocator.h, careadlinkat.h.
755 (emacs_no_realloc_allocator): New static constant.
756 (emacs_readlink): New function.
757 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
758 ../lib/careadlinkat.h.
760 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
762 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
763 first non-nil return value).
765 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
767 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
768 if not defined (Bug#8403).
770 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
772 * xdisp.c (display_count_lines): Remove parameter `start',
773 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
774 (get_char_face_and_encoding): Remove parameter `multibyte_p',
775 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
776 (fill_stretch_glyph_string): Remove parameters `row' and `area',
777 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
778 and thereabouts. All callers changed.
779 (get_per_char_metric): Remove parameter `f', unused since
780 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
782 2011-04-02 Jim Meyering <meyering@redhat.com>
784 do not dereference NULL upon failed strdup
785 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
786 (ns_get_family): Likewise.
788 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
790 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
792 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
794 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
797 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
801 * window.c (Ftemp_output_buffer_show): New fun.
802 (Fsave_window_excursion):
803 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
805 * lread.c (lisp_file_lexically_bound_p): New function.
806 (Fload): Bind Qlexical_binding.
807 (readevalloop): Remove `evalfun' arg.
808 Bind Qinternal_interpreter_environment.
809 (Feval_buffer): Bind Qlexical_binding.
810 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
812 (syms_of_lread): Declare `lexical-binding'.
814 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
816 * keyboard.c (eval_dyn): New fun.
817 (menu_item_eval_property): Use it.
819 * image.c (parse_image_spec): Use Ffunctionp.
821 * fns.c (concat, mapcar1): Accept byte-code-functions.
823 * eval.c (Fsetq): Handle lexical vars.
824 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
825 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
826 (FletX, Flet): Obey lexical binding.
827 (Fcommandp): Handle closures.
828 (Feval): New `lexical' arg.
829 (eval_sub): New function extracted from Feval. Use it almost
830 everywhere where Feval was used. Look up vars in lexical env.
832 (Ffunctionp): Move from subr.el.
833 (Ffuncall): Handle closures.
834 (apply_lambda): Remove `eval_flags'.
835 (funcall_lambda): Handle closures and new byte-code-functions.
836 (Fspecial_variable_p): New function.
837 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
838 but without exporting it to Lisp.
840 * doc.c (Fdocumentation, store_function_docstring):
841 * data.c (Finteractive_form): Handle closures.
843 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
846 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
848 (exec_byte_code): New function extracted from Fbyte_code to handle new
849 calling convention for byte-code-functions. Add new byte-codes.
851 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
853 * alloc.c (Fmake_symbol): Init new `declared_special' field.
855 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
857 * xdisp.c (redisplay_internal): Fix prototype.
859 2011-03-31 Eli Zaretskii <eliz@gnu.org>
861 * xdisp.c (SCROLL_LIMIT): New macro.
862 (try_scrolling): Use it when setting scroll_limit. Limit
863 scrolling to 100 screen lines.
864 (redisplay_window): Even when falling back on "recentering",
865 position point in the window according to scroll-conservatively,
866 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
868 (try_scrolling): When point is above the window, allow searching
869 as far as scroll_max, or one screenful, to compute vertical
870 distance from PT to the scroll margin position. This prevents
871 try_scrolling from unnecessarily failing when
872 scroll-conservatively is set to a value slightly larger than the
873 window height. Clean up the case of PT below the margin at bottom
874 of window: scroll_max can no longer be INT_MAX. When aggressive
875 scrolling is in use, don't let point enter the opposite scroll
876 margin as result of the scroll.
877 (syms_of_xdisp) <scroll-conservatively>: Document the
878 threshold of 100 lines for never-recentering scrolling.
880 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
882 * dispextern.h (move_it_by_lines):
883 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
884 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
885 (message_log_check_duplicate): Remove parameters `prev_bol' and
886 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
887 (redisplay_internal): Remove parameter `preserve_echo_area',
888 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
890 * indent.c (Fvertical_motion):
891 * window.c (window_scroll_pixel_based, Frecenter):
892 Don't pass `need_y_p' to `move_it_by_lines'.
894 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
896 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
897 steal a few bits to be more compact.
898 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
899 Remove unneeded casts.
901 * bytecode.c (Fbyte_code): CAR and CDR can GC.
903 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
905 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
906 binding" message (bug#7967).
908 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
910 Fix more problems found by GCC 4.6.0's static checks.
912 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
913 Remove unused local var.
915 * editfns.c (Fmessage_box): Remove unused local var.
917 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
918 (note_mode_line_or_margin_highlight, note_mouse_highlight):
919 Omit unused local vars.
920 * window.c (shrink_windows): Omit unused local var.
921 * menu.c (digest_single_submenu): Omit unused local var.
922 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
923 Omit unused local var.
925 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
926 Don't assume string length fits in int.
927 (keyremap_step, read_key_sequence): Use size_t for sizes.
928 (read_key_sequence): Don't check last_real_key_start redundantly.
930 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
931 instead of alloca (Bug#8344).
933 * eval.c (Fbacktrace): Don't assume nargs fits in int.
934 (Fbacktrace_frame): Don't assume nframes fits in int.
936 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
938 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
941 * term.c (produce_glyphless_glyph): Remove unnecessary test.
943 * cm.c (calccost): Turn while-do into do-while, for clarity.
945 * keyboard.c (syms_of_keyboard): Use the same style as later
946 in this function when indexing through an array. This also
947 works around GCC bug 48267.
949 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
951 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
953 * chartab.c (sub_char_table_ref_and_range): Redo for slight
954 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
956 * keyboard.c, keyboard.h (num_input_events): Now size_t.
957 This avoids undefined behavior on integer overflow, and is a bit
958 more convenient anyway since it is compared to a size_t variable.
960 Variadic C functions now count arguments with size_t, not int.
961 This avoids an unnecessary limitation on 64-bit machines, which
962 caused (substring ...) to crash on large vectors (Bug#8344).
963 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
964 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
965 All variadic functions and their callers changed accordingly.
966 (struct gcpro.nvars): Now size_t, not int. All uses changed.
967 * data.c (arith_driver, float_arith_driver): Likewise.
968 * editfns.c (general_insert_function): Likewise.
969 * eval.c (struct backtrace.nargs, interactive_p)
970 (internal_condition_case_n, run_hook_with_args, apply_lambda)
971 (funcall_lambda, mark_backtrace): Likewise.
972 * fns.c (concat): Likewise.
973 * frame.c (x_set_frame_parameters): Likewise.
974 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
975 0 if not found, not -1. All callers changed.
977 * alloc.c (garbage_collect): Don't assume stack size fits in int.
978 (stack_copy_size): Now size_t, not int.
979 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
981 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
983 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
984 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
987 * lisp.h (multibyte_char_to_unibyte):
988 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
989 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
990 * character.h (CHAR_TO_BYTE8):
991 * cmds.c (internal_self_insert):
992 * editfns.c (general_insert_function):
993 * keymap.c (push_key_description):
994 * search.c (Freplace_match):
995 * xdisp.c (message_dolog, set_message_1): All callers changed.
997 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
999 * keyboard.c (safe_run_hook_funcall): New function.
1000 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1001 don't set the hook to nil, but remove the offending function instead.
1002 (Qcommand_hook_internal): Remove, unused.
1003 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1004 Vcommand_hook_internal.
1006 * eval.c (enum run_hooks_condition): Remove.
1007 (funcall_nil, funcall_not): New functions.
1008 (run_hook_with_args): Call each function through a `funcall' argument.
1009 Remove `cond' argument, now redundant.
1010 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1011 (Frun_hook_with_args_until_failure): Adjust accordingly.
1012 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1014 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1016 * dispextern.h (string_buffer_position): Remove declaration.
1018 * print.c (strout): Remove parameter `multibyte', unused since
1019 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1021 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1022 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1023 All callers changed.
1025 * w32.c (_wsa_errlist): Use braces for struct initializers.
1027 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1028 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1029 All callers changed.
1030 (string_buffer_position): Likewise. Also, make static (it's never
1031 used outside xdisp.c).
1032 (cursor_row_p): Remove parameter `w', unused since
1033 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1034 (decode_mode_spec): Remove parameter `precision', introduced during
1035 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1036 All callers changed.
1038 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1040 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1042 2011-03-27 Anders Lindgren <andlind@gmail.com>
1044 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1045 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1046 (ns_update_auto_hide_menu_bar): New functions.
1047 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1048 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1049 ns_constrain_all_frames.
1050 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1051 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1053 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1055 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1057 2011-03-27 Glenn Morris <rgm@gnu.org>
1059 * syssignal.h: Replace RETSIGTYPE with void.
1060 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1061 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1062 Replace SIGTYPE with void everywhere.
1063 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1064 * s/template.h (SIGTYPE): Remove commented out definition.
1066 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1068 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1069 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1071 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1073 * w32.c (read_unc_volume): Use parameter `henum', instead of
1074 global variable `wget_enum_handle'.
1076 * keymap.c (describe_vector): Remove parameters `indices' and
1077 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1078 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1080 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1082 * keyboard.c (timer_check): Remove parameter `do_it_now',
1083 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1084 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1085 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1087 * keyboard.c (read_char):
1088 * w32menu.c (w32_menu_display_help):
1089 * xmenu.c (show_help_event, menu_help_callback):
1090 Adjust calls to `show_help_echo'.
1092 * gtkutil.c (xg_maybe_add_timer):
1093 * keyboard.c (readable_events):
1094 * process.c (wait_reading_process_output):
1095 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1097 * insdel.c (adjust_markers_gap_motion):
1098 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1099 (gap_left, gap_right): Don't call it.
1101 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1103 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1104 incurred during fontification.
1106 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1108 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1109 (DEFVAR_PER_BUFFER): Don't pass it.
1111 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1112 (scrolling_window): Don't pass it.
1114 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1116 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1118 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1120 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1121 of variables specific to SELinux and computation of `encoded_absname'.
1123 * image.c (XPutPixel): Remove unused variable `height'.
1125 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1127 * unexw32.c (get_section_info): Remove unused variable `section'.
1129 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1130 (system_process_attributes): Remove unused variable `sess'.
1131 (sys_read): Remove unused variable `err'.
1133 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1134 (w32_wnd_proc): Remove unused variable `isdead'.
1135 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1136 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1137 (x_create_tip_frame): Remove unused variable `tem'.
1139 * w32inevt.c (w32_console_read_socket):
1140 Remove unused variable `no_events'.
1142 * w32term.c (x_draw_composite_glyph_string_foreground):
1143 Remove unused variable `width'.
1145 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
1147 * w32term.c (x_set_glyph_string_clipping):
1148 Don't pass uninitialized region to CombineRgn.
1150 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
1152 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1153 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1154 (Fx_close_connection): Remove unused variable `i'.
1156 * w32font.c (w32font_draw): Return number of glyphs.
1157 (w32font_open_internal): Remove unused variable `i'.
1158 (w32font_driver): Add missing initializer.
1160 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1161 (fill_in_menu): Remove unused variable `items_added'.
1163 * w32term.c (last_mouse_press_frame): Remove static global variable.
1164 (w32_clip_to_row): Remove unused variable `f'.
1165 (x_delete_terminal): Remove unused variable `i'.
1167 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1168 (NOTHING): Remove unused static global variable.
1169 (uniscribe_check_otf): Remove unused variable `table'.
1170 (uniscribe_font_driver): Add missing initializers.
1172 2011-03-23 Julien Danjou <julien@danjou.info>
1174 * term.c (Fsuspend_tty, Fresume_tty):
1175 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1176 * window.c (temp_output_buffer_show):
1177 * insdel.c (signal_before_change):
1178 * frame.c (Fhandle_switch_frame):
1179 * fileio.c (Fdo_auto_save):
1180 * emacs.c (Fkill_emacs):
1181 * editfns.c (save_excursion_restore):
1182 * cmds.c (internal_self_insert):
1183 * callint.c (Fcall_interactively):
1184 * buffer.c (Fkill_all_local_variables):
1185 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1187 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
1188 unconditionnaly since it does the check itself.
1190 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
1192 Fix more problems found by GCC 4.5.2's static checks.
1194 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1195 the first time through the loop, since we know p0 < p1 then.
1196 This also avoids a gcc -Wstrict-overflow warning.
1198 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1199 leading to a memory leak, possible in functions like
1200 load_charset_map_from_file that can allocate an unbounded number
1201 of objects (Bug#8318).
1203 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1204 that could (at least in theory) be that large.
1206 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1207 This is less likely to overflow, and avoids undefined behavior if
1208 overflow does occur. All callers changed. Use strtoul to scan
1209 for the unsigned long integer.
1210 (pint2hrstr): Simplify and tune code slightly.
1211 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1213 * scroll.c (do_scrolling): Work around GCC bug 48228.
1214 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1216 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1217 This also avoids a warning with gcc -Wstrict-overflow.
1218 (validate_x_resource_name): Simplify count usage.
1219 This also avoids a warning with gcc -Wstrict-overflow.
1221 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1224 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1226 * process.c (Fmake_network_process): Use socklen_t, not int,
1227 where POSIX says socklen_t is required in portable programs.
1228 This fixes a porting bug on hosts like 64-bit HP-UX, where
1229 socklen_t is wider than int (Bug#8277).
1230 (Fmake_network_process, server_accept_connection):
1231 (wait_reading_process_output, read_process_output):
1234 * process.c: Rename or move locals to avoid shadowing.
1235 (list_processes_1, Fmake_network_process):
1236 (read_process_output_error_handler, exec_sentinel_error_handler):
1237 Rename or move locals.
1238 (Fmake_network_process): Define label "retry_connect" only if needed.
1239 (Fnetwork_interface_info): Fix pointer signedness.
1240 (process_send_signal): Add cast to avoid pointer signedness problem.
1241 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
1242 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
1244 Make tparam.h and terminfo.c consistent.
1245 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1246 Include tparam.h instead, since it declares them.
1247 * cm.h (PC): Remove extern decl; tparam.h now does this.
1248 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1249 * terminfo.c: Include tparam.h, to check interfaces.
1250 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1251 (tparam): Adjust signature to match interface in tparam.h;
1252 this removes some undefined behavior. Check that outstring and len
1253 are zero, which they always are with Emacs.
1254 * tparam.h (PC, BC, UP): New extern decls.
1256 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
1257 (xftfont_open): Rename locals to avoid shadowing.
1259 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
1260 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1261 (OTF_TAG_SYM): Omit macro if not needed.
1262 (ftfont_list): Remove unused local.
1263 (get_adstyle_property, ftfont_pattern_entity):
1264 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1265 Rename locals to avoid shadowing.
1267 * xfont.c (xfont_list_family): Mark var as initialized.
1269 * xml.c (make_dom): Now static.
1271 * composite.c (composition_compute_stop_pos): Rename local to
1273 (composition_reseat_it): Remove unused locals.
1274 (find_automatic_composition, composition_adjust_point): Likewise.
1275 (composition_update_it): Mark var as initialized.
1276 (find_automatic_composition): Mark vars as initialized,
1277 with a FIXME (Bug#8290).
1279 character.h: Rename locals to avoid shadowing.
1280 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1281 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1282 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1283 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1286 * textprop.c (property_change_between_p): Remove; unused.
1288 * intervals.c (interval_start_pos): Now static.
1290 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1292 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1293 Rename locals to avoid shadowing.
1295 * sound.c (wav_play, au_play, Fplay_sound_internal):
1296 Fix pointer signedness.
1297 (alsa_choose_format): Remove unused local var.
1298 (wav_play): Initialize a variable to 0, to prevent undefined
1299 behavior (Bug#8278).
1301 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1303 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1305 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1306 clobbering (Bug#8298).
1307 * sysdep.c (sys_subshell): Likewise.
1308 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
1310 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1311 This should get cleaned up, so that child_setup has the
1312 same signature on all platforms.
1314 * callproc.c (call_process_cleanup): Now static.
1315 (relocate_fd): Rename locals to avoid shadowing.
1317 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
1319 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1320 not to be necessary, and produces flickering.
1322 2011-03-20 Glenn Morris <rgm@gnu.org>
1324 * config.in: Remove file.
1326 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
1328 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1329 are now in src/globals.h.
1330 (syms_of_minibuf): Remove spurious & from previous change.
1332 2011-03-20 Leo <sdl.web@gmail.com>
1334 * minibuf.c (completing-read-function): New variable.
1335 (completing-read-default): Rename from completing-read.
1336 (completing-read): Call completing-read-function.
1338 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1340 * xfaces.c (Fx_load_color_file):
1341 Read color file from absolute filename (bug#8250).
1343 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1345 * makefile.w32-in: Update dependencies.
1347 2011-03-17 Eli Zaretskii <eliz@gnu.org>
1349 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1351 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1353 Fix more problems found by GCC 4.5.2's static checks.
1355 * process.c (make_serial_process_unwind, send_process_trap):
1356 (sigchld_handler): Now static.
1358 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1359 That way, the code declares only the vars that it needs.
1360 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1361 * s/cygwin.h (PTY_ITERATION): Likewise.
1362 * s/darwin.h (PTY_ITERATION): Likewise.
1363 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1365 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1366 * process.c (allocate_pty): Don't declare stb unless it's needed.
1368 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
1369 (CONSTANTLIM): Remove; unused.
1370 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1371 Define only if needed.
1373 * unexelf.c (unexec): Name an expression,
1374 to avoid gcc -Wbad-function-cast warning.
1375 Use a different way to cause a compilation error if anyone uses
1376 n rather than nn, a way that does not involve shadowing.
1377 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
1379 * deps.mk (unexalpha.o): Remove; unused.
1381 New file unexec.h, the (simple) interface for unexec (Bug#8267).
1382 * unexec.h: New file.
1383 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1384 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1386 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1387 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1388 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
1389 Change as necessary to match prototype in unexec.h.
1391 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1393 (back_comment, skip_chars): Mark vars as initialized.
1395 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1396 Rename locals to avoid shadowing.
1398 * lread.c (read1): Rewrite so as not to use empty "else".
1399 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
1401 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1403 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1404 warning when compiling print.c.
1406 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1407 instead of using an uninitialized var.
1408 (font_sort_entities): Mark var as initialized.
1410 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1412 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1413 pointers to constants.
1414 (font_parse_fcname): Remove unused vars.
1415 (font_delete_unmatched): Now static.
1416 (font_get_spec): Remove; unused.
1417 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1418 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1419 Rename or move locals to avoid shadowing.
1421 * fns.c (require_nesting_list, require_unwind): Now static.
1422 (Ffillarray): Rename locals to avoid shadowing.
1424 * floatfns.c (domain_error2): Define only if needed.
1425 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1427 * alloc.c (mark_backtrace): Move decl from here ...
1428 * lisp.h: ... to here, so that it can be checked.
1430 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
1431 (Fdefvar): Rewrite so as not to use empty "else".
1432 (lisp_indirect_variable): Name an expression,
1433 to avoid gcc -Wbad-function-cast warning.
1434 (Fdefvar): Rename locals to avoid shadowing.
1436 * callint.c (quotify_arg, quotify_args): Now static.
1437 (Fcall_interactively): Rename locals to avoid shadowing.
1438 Use const pointer when appropriate.
1440 * lisp.h (get_system_name, get_operating_system_release):
1441 Move decls here, to check interfaces.
1442 * process.c (get_operating_system_release): Move decl to lisp.h.
1443 * xrdb.c (get_system_name): Likewise.
1444 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1445 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1446 some of which prompt warnings from gcc -Wbad-function-cast.
1447 (Fformat_time_string, Fencode_time, Finsert_char):
1448 (Ftranslate_region_internal, Fformat):
1449 Rename or remove local vars to avoid shadowing.
1450 (Ftranslate_region_internal): Mark var as initialized.
1452 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1455 * lisp.h (eassert): Check that the argument compiles, even if
1456 ENABLE_CHECKING is not defined.
1458 * data.c (Findirect_variable): Name an expression, to avoid
1459 gcc -Wbad-function-cast warning.
1460 (default_value, arithcompare, arith_driver, arith_error): Now static.
1461 (store_symval_forwarding): Rename local to avoid shadowing.
1462 (Fmake_variable_buffer_local, Fmake_local_variable):
1463 Mark variables as initialized.
1464 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
1466 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
1467 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1468 Rename locals to avoid shadowing.
1469 (mark_stack): Move local variables into the #ifdef region where
1471 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1472 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1474 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1475 (GC_STRING_CHARS): Remove; not used.
1476 (Fmemory_limit): Cast sbrk's returned value to char *.
1478 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1479 avoids undefined behavior in theory.
1481 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1483 Use functions, not macros, for up- and down-casing (Bug#8254).
1484 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1485 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1486 to use the following functions instead of these macros.
1487 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1488 EMACS_INT, since callers assume the returned value fits in int.
1489 (upcase1): Likewise, for UPCASE_TABLE.
1490 (uppercasep, lowercasep, upcase): New static inline functions.
1491 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
1492 the race-condition problem in the old DOWNCASE.
1494 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1495 Rename locals to avoid shadowing.
1496 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
1497 (regex_compile, re_search_2, re_match_2_internal):
1498 Remove unused local vars.
1499 (FREE_VAR): Rewrite so as not to use empty "else",
1500 which gcc can warn about.
1501 (regex_compile, re_match_2_internal): Mark locals as initialized.
1502 (RETALLOC_IF): Define only if needed.
1503 (WORDCHAR_P): Likewise. This one is never needed, but is used
1504 only in a comment talking about a compiler bug, so put inside
1505 the #if 0 of that comment.
1506 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1507 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1510 * search.c (boyer_moore): Rename locals to avoid shadowing.
1511 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1512 (PREV_CHAR_BOUNDARY): Likewise.
1514 * search.c (simple_search): Remove unused var.
1516 * dired.c (compile_pattern): Move decl from here ...
1517 * lisp.h: ... to here, so that it can be checked.
1518 (struct re_registers): New forward decl.
1520 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1522 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1524 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1525 Rename locals to avoid shadowing.
1526 (Fvertical_motion): Mark locals as initialized.
1528 * casefiddle.c (casify_object, casify_region): Now static.
1529 (casify_region): Mark local as initialized.
1531 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1533 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1534 New macros, so that the caller can use some names other than
1535 gcpro1, gcpro2, etc.
1536 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1538 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1539 argument, for consistency with GCPRO2_VAR, etc: it is now the
1540 prefix of the variable, not the variable itself. All uses
1542 * dired.c (directory_files_internal, file_name_completion):
1543 Rename locals to avoid shadowing.
1545 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1546 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1547 dired.c's scmp function, had undefined behavior.
1548 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1549 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1550 * buffer.h: ... to here, because these macros use current_buffer,
1551 and the new implementation with inline functions needs to have
1552 current_buffer in scope now, rather than later when the macros
1554 (downcase, upcase1): New static inline functions.
1555 (DOWNCASE, UPCASE1): Reimplement using these functions.
1556 This avoids undefined behavior in expressions like
1557 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1558 from race conditions in accessing the global variables
1559 case_temp1 and case_temp2.
1560 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1561 * lisp.h (case_temp1, case_temp2): Remove their decls.
1562 * character.h (ASCII_CHAR_P): Move from here ...
1563 * lisp.h: ... to here, so that the inline functions mentioned
1566 * dired.c (directory_files_internal_unwind): Now static.
1568 * fileio.c (file_name_as_directory, directory_file_name):
1569 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1571 (file_name_as_directory): Use const pointers when appropriate.
1572 (Fexpand_file_name): Likewise. In particular, newdir might
1573 point at constant storage, so make it a const pointer.
1574 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
1575 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1577 (Fset_file_times, Finsert_file_contents, auto_save_error):
1578 Rename locals to avoid shadowing.
1580 * minibuf.c (choose_minibuf_frame_1): Now static.
1581 (Ftry_completion, Fall_completions): Rename or remove locals
1584 * marker.c (bytepos_to_charpos): Remove; unused.
1586 * lisp.h (verify_bytepos, count_markers): New decls,
1587 so that gcc does not warn that these functions aren't declared.
1589 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1590 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
1591 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
1592 (copy_text): Remove unused local var.
1594 * filelock.c (within_one_second): Now static.
1595 (lock_file_1): Rename local to avoid shadowing.
1597 * buffer.c (fix_overlays_before): Mark locals as initialized.
1598 (fix_start_end_in_overlays): Likewise. This function should be
1599 simplified by using pointers-to-pointers, but that's a different
1601 (switch_to_buffer_1): Now static.
1602 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1603 (report_overlay_modification): Rename locals to avoid shadowing.
1605 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
1606 Fix pointer signedness issue.
1607 (sys_subshell): Mark local as volatile if checking for lint,
1608 to suppress a gcc -Wclobbered warning that does not seem to be right.
1609 (MAXPATHLEN): Define only if needed.
1611 * process.c (serial_open, serial_configure): Move decls from here ...
1612 * systty.h: ... to here, so that they can be checked.
1614 * fns.c (get_random, seed_random): Move extern decls from here ...
1615 * lisp.h: ... to here, so that they can be checked.
1617 * sysdep.c (reset_io): Now static.
1618 (wait_for_termination_signal): Remove; unused.
1620 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1621 (copy_keymap_item, append_key, push_text_char_description):
1623 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
1624 (DENSE_TABLE_SIZE): Remove; unused.
1625 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1626 (describe_map_tree):
1627 Rename locals to avoid shadowing.
1629 * keyboard.c: Declare functions static if they are not used elsewhere.
1630 (echo_char, echo_dash, cmd_error, top_level_2):
1631 (poll_for_input, handle_async_input): Now static.
1632 (read_char, kbd_buffer_get_event, make_lispy_position):
1633 (make_lispy_event, make_lispy_movement, apply_modifiers):
1634 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1635 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1636 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
1637 (read_key_sequence, read_char): Mark locals as initialized.
1638 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
1640 * keyboard.h (make_ctrl_char): New decl.
1641 (mark_kboards): Move decl here ...
1642 * alloc.c (mark_kboards): ... from here.
1644 * lisp.h (force_auto_save_soon): New decl.
1646 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
1647 (DEFINE_DUMMY_FUNCTION): New macro.
1648 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1650 (main): Add casts to avoid warnings
1651 if GCC considers string literals to be constants.
1653 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1655 * dbusbind.c: Pointer signedness fixes.
1656 (xd_signature, xd_append_arg, xd_initialize):
1657 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1658 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1659 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1660 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1662 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1663 if GCC considers string literals to be constants.
1664 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
1666 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1668 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1669 (print_preprocess, print_object): New macro to fix last change.
1671 * print.c (print_preprocess): Don't forget font objects.
1673 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
1675 * emacs.c (USAGE3): Doc fixes.
1677 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1679 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1682 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
1684 * lisp.h (VWindow_system, Qfile_name_history):
1685 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1686 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1687 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1689 * w32select.c: Don't #include "keyboard.h".
1690 (run_protected): Add extern declaration for waiting_for_input.
1692 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1693 * w32console.c (detect_input_pending, read_input_pending)
1694 (encode_terminal_code):
1695 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1696 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1697 (w32_system_caret_y, Qfile_name_history):
1698 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1699 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1700 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1701 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1702 * w32proc.c (Qlocal, report_file_error):
1703 * w32term.c (Vwindow_system, updating_frame):
1704 * w32uniscribe.c (initialized, uniscribe_font_driver):
1705 Remove unneeded extern declarations.
1707 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
1709 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
1711 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
1713 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1714 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1715 These macros can no longer be used for assignment.
1717 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1718 Assign struct members directly, instead of using BUF_BEGV etc.
1719 (record_buffer_markers, fetch_buffer_markers): New functions for
1720 recording and fetching special buffer markers.
1721 (set_buffer_internal_1, set_buffer_temp): Use them.
1723 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1725 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1727 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1728 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1730 * xdisp.c (hscroll_window_tree):
1731 (reconsider_clip_changes): Use PT instead of BUF_PT.
1733 2011-03-13 Eli Zaretskii <eliz@gnu.org>
1735 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1736 $(EMACS_ROOT)/lib/intprops.h.
1738 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1740 Fix more problems found by GCC 4.5.2's static checks.
1742 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1743 to unsigned char * to avoid compiler diagnostic.
1744 (xg_free_frame_widgets): Make it clear that a local variable is
1745 needed only if USE_GTK_TOOLTIP.
1746 (gdk_window_get_screen): Make it clear that this macro is needed
1747 only if USE_GTK_TOOLTIP.
1748 (int_gtk_range_get_value): New function, which avoids a diagnostic
1749 from gcc -Wbad-function-cast.
1750 (xg_set_toolkit_scroll_bar_thumb): Use it.
1751 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1752 diagnostic from gcc -Wbad-function-cast.
1753 (get_utf8_string, xg_get_file_with_chooser):
1754 Rename locals to avoid shadowing.
1755 (create_dialog): Move locals to avoid shadowing.
1757 * xgselect.c (xg_select): Remove unused var.
1759 * image.c (four_corners_best): Mark locals as initialized.
1760 (gif_load): Initialize transparent_p to zero (Bug#8238).
1761 Mark another local as initialized.
1762 (my_png_error, my_error_exit): Mark with NO_RETURN.
1764 * image.c (clear_image_cache): Now static.
1765 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
1766 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
1767 (x_edge_detection): Remove unnecessary cast that
1768 gcc -Wbad-function-cast diagnoses.
1769 (gif_load): Fix pointer signedness.
1770 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1771 (jpeg_load, gif_load): Rename locals to avoid shadowing.
1773 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
1775 Improve quality of tests for time stamp overflow.
1776 For example, without this patch (encode-time 0 0 0 1 1
1777 1152921504606846976) returns the obviously-bogus value (-948597
1778 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1779 reports time overflow. See
1780 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
1781 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1782 * editfns.c: Include limits.h and intprops.h.
1783 (TIME_T_MIN, TIME_T_MAX): New macros.
1784 (time_overflow): Move earlier, to before first use.
1785 (hi_time, lo_time): New functions, for an accurate test for
1787 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1788 (Fget_internal_run_time): Don't assume time_t fits in int.
1789 (make_time): Use list2 instead of Fcons twice.
1790 (Fdecode_time): More accurate test for out-of-range times.
1791 (check_tm_member): New function.
1792 (Fencode_time): Use it, to test for out-of-range times.
1793 (lisp_time_argument): Don't rely on undefined left-shift and
1794 right-shift behavior when checking for time stamp overflow.
1796 * editfns.c (time_overflow): New function, refactoring common code.
1797 (Fformat_time_string, Fdecode_time, Fencode_time):
1798 (Fcurrent_time_string): Use it.
1800 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1801 * dired.c (make_time): Move to ...
1802 * editfns.c (make_time): ... here.
1803 * systime.h: Note the move.
1805 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1807 * fringe.c (update_window_fringes): Remove unused variables.
1809 * unexmacosx.c (copy_data_segment): Also copy __got section.
1812 2011-03-12 Eli Zaretskii <eliz@gnu.org>
1814 * termcap.c [MSDOS]: Include "msdos.h".
1815 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1816 Constify `char *' arguments and their references according to
1817 prototypes in tparam.h.
1819 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
1821 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1822 Adapt all references accordingly.
1824 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1826 2011-03-11 Tom Tromey <tromey@redhat.com>
1828 * buffer.c (syms_of_buffer): Remove obsolete comment.
1830 2011-03-11 Eli Zaretskii <eliz@gnu.org>
1832 * termhooks.h (encode_terminal_code): Declare prototype.
1834 * msdos.c (encode_terminal_code): Don't declare prototype.
1836 * term.c (encode_terminal_code): Now external again, used by
1837 w32console.c and msdos.c.
1839 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1840 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
1842 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
1844 Fix some minor problems found by GCC 4.5.2's static checks.
1846 * fringe.c (update_window_fringes): Mark locals as initialized
1848 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
1850 * alloc.c (mark_fringe_data): Move decl from here ...
1851 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1852 to check its interface.
1853 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1855 * fontset.c (free_realized_fontset): Now static.
1856 (Fset_fontset_font): Rename local to avoid shadowing.
1857 (fontset_font): Mark local as initialized.
1858 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
1860 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1862 * xselect.c (x_disown_buffer_selections): Remove; not used.
1863 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
1864 (x_own_selection, Fx_disown_selection_internal): Rename locals
1866 (x_handle_dnd_message): Remove local to avoid shadowing.
1868 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1869 so that the caller can use some name other than gcpro1.
1870 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
1871 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1872 (Fx_backspace_delete_keys_p):
1873 Use them to avoid shadowing, and rename vars to avoid shadowing.
1874 (x_decode_color, x_set_name, x_window): Now static.
1875 (Fx_create_frame): Add braces to silence GCC warning.
1876 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
1877 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1878 Remove unused locals.
1879 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1880 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1881 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1884 * xterm.h (x_mouse_leave): New decl.
1886 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1887 Remove unused functions.
1888 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1889 (x_calc_absolute_position): Now static.
1890 (XTread_socket): Don't define label "out" unless it's used.
1891 Don't declare local "event" unless it's used.
1892 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1893 unless they are used.
1894 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1895 (x_fatal_error_signal): Remove; not used.
1896 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1897 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1898 (x_error_catcher, x_connection_closed, x_error_handler):
1899 (x_error_quitter, xembed_send_message, x_iconify_frame):
1900 (my_log_handler): Rename locals to avoid shadowing.
1901 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
1902 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
1904 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1905 Rename or move locals to avoid shadowing.
1906 (tty_defined_color, merge_face_heights): Now static.
1907 (free_realized_faces_for_fontset): Remove; not used.
1908 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1909 does not deduce is never used uninitialized.
1910 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1911 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
1913 * terminal.c (store_terminal_param): Now static.
1915 * xmenu.c (menu_highlight_callback): Now static.
1916 (set_frame_menubar): Remove unused local.
1917 (xmenu_show): Rename parameter to avoid shadowing.
1918 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1919 since they might point to immutable storage.
1920 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1921 since it's unused otherwise.
1923 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
1924 Add a FIXME, since the code still doesn't look right. (Bug#8215)
1925 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1926 avoids a gcc -Wuninitialized diagnostic.
1927 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
1928 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1929 does not deduce are never used uninitialized.
1931 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1933 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
1934 * window.c (window_loop, size_window):
1935 (run_window_configuration_change_hook, enlarge_window): Likewise.
1937 * window.c (display_buffer): Now static.
1938 (size_window): Mark variables that gcc -Wuninitialized
1939 does not deduce are never used uninitialized.
1940 * window.h (check_all_windows): New decl, to forestall
1941 gcc -Wmissing-prototypes diagnostic.
1942 * dispextern.h (bidi_dump_cached_states): Likewise.
1944 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1946 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
1948 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1949 and to avoid gcc -Wuninitialized warning.
1950 (load_charset_map): Mark variables that gcc -Wuninitialized
1951 does not deduce are never used uninitialized.
1952 (load_charset): Abort instead of using uninitialized var (Bug#8229).
1954 * coding.c (coding_set_source, coding_set_destination):
1955 Use "else { /* comment */ }" rather than "else /* comment */;"
1956 for clarity, and to avoid gcc -Wempty-body warning.
1957 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1958 a block, when the outer 'i' will do.
1959 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1960 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1961 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1962 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1963 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1964 Rename locals to avoid shadowing.
1965 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
1966 * coding.c (emacs_mule_char, encode_invocation_designation):
1967 Now static, since they're not used elsewhere.
1968 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
1969 (decode_coding_object, encode_coding_object, detect_coding_system):
1970 (decode_coding_emacs_mule): Mark variables that gcc
1971 -Wuninitialized does not deduce are never used uninitialized.
1972 (detect_coding_iso_2022): Initialize a local variable that might
1973 be used uninitialized. Leave a FIXME because it's not clear that
1974 this initialization is needed. (Bug#8211)
1975 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1976 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1977 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1978 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1979 Remove unused macros.
1981 * category.c (hash_get_category_set): Remove unused local var.
1982 (copy_category_table): Now static, since it's not used elsewhere.
1983 * character.c (string_count_byte8): Likewise.
1985 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1986 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1988 * chartab.c (copy_sub_char_table): Now static, since it's not used
1990 (sub_char_table_ref_and_range, char_table_ref_and_range):
1991 Rename locals to avoid shadowing.
1992 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
1994 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
1995 (BIDI_BOB): Remove unused macro.
1997 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1998 deduce are never used uninitialized.
1999 * term.c (encode_terminal_code): Likewise.
2001 * term.c (encode_terminal_code): Now static. Remove unused local.
2003 * tparam.h: New file.
2004 * term.c, tparam.h: Include it.
2005 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2006 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2007 Move these decls to tparam.h, and make them agree with what
2008 is actually in tparam.c. The previous trick of using incompatible
2009 decls in different modules does not conform to the C standard.
2010 All callers of tparam changed to use tparam's actual API.
2011 * tparam.c (tparam1, tparam, tgoto):
2012 Use const pointers where appropriate.
2014 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2015 * cm.h (struct cm): Likewise.
2016 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2017 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2018 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2019 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2020 (turn_on_face, init_tty): Likewise.
2021 * termchar.h (struct tty_display_info): Likewise.
2023 * term.c (term_mouse_position): Rename local to avoid shadowing.
2025 * alloc.c (mark_ttys): Move decl from here ...
2026 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2028 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2030 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2032 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2034 * search.c (compile_pattern_1): Remove argument regp, unused since
2035 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2036 (compile_pattern): Don't pass it.
2038 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2040 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2041 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2043 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2045 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2047 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2048 gdk_window_get_screen, gdk_window_get_geometry,
2049 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2050 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2051 (xg_get_pixbuf_from_pixmap): New function.
2052 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2053 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2054 Call xg_get_pixbuf_from_pixmap instead of
2055 gdk_pixbuf_get_from_drawable.
2056 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2057 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2058 (xg_check_special_colors): Use GtkStyleContext and its functions
2060 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2061 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2062 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2063 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2064 Call gtk_widget_get_preferred_size.
2065 (xg_frame_resized): gdk_window_get_geometry only takes 5
2067 (xg_win_to_widget, xg_event_is_for_menubar):
2068 Call gdk_x11_window_lookup_for_display.
2069 (xg_set_widget_bg): New function.
2070 (delete_cb): New function.
2071 (xg_create_frame_widgets): connect delete-event to delete_cb.
2072 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2073 (xg_set_background_color): Call xg_set_widget_bg.
2074 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2075 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2076 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2077 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2079 (update_frame_tool_bar): Call gtk_widget_hide.
2080 (xg_initialize): Use GDK_KEY_g.
2082 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2084 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2086 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2087 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2088 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2090 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2092 * w32xfns.c (select_palette): Check success of RealizePalette against
2093 GDI_ERROR, not zero.
2095 See ChangeLog.11 for earlier changes.
2101 Copyright (C) 2011 Free Software Foundation, Inc.
2103 This file is part of GNU Emacs.
2105 GNU Emacs is free software: you can redistribute it and/or modify
2106 it under the terms of the GNU General Public License as published by
2107 the Free Software Foundation, either version 3 of the License, or
2108 (at your option) any later version.
2110 GNU Emacs is distributed in the hope that it will be useful,
2111 but WITHOUT ANY WARRANTY; without even the implied warranty of
2112 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2113 GNU General Public License for more details.
2115 You should have received a copy of the GNU General Public License
2116 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.