dispextern.h (struct glyph): Fix previous change. Change the bit length of glyphless...
[bpt/emacs.git] / src / ChangeLog
1 2012-03-26 Kenichi Handa <handa@m17n.org>
2
3 * dispextern.h (struct glyph): Fix previous change. Change the
4 bit length of glyphless.ch to 25 (Bug#11082).
5
6 2012-03-26 Chong Yidong <cyd@gnu.org>
7
8 * keyboard.c (Vselection_inhibit_update_commands): New variable.
9 (command_loop_1): Use it; inhibit selection update for
10 handle-select-window too (Bug#8996).
11
12 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
13
14 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific
15 code.
16
17 2012-03-25 Kenichi Handa <handa@m17n.org>
18
19 * dispextern.h (struct glyph): Change the bit length of
20 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
21
22 2012-03-24 Eli Zaretskii <eliz@gnu.org>
23
24 * s/ms-w32.h (tzname): Include time.h before redirecting to
25 _tzname. Fixes the MSVC build. (Bug#9960)
26
27 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
28
29 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
30 characters.
31
32 * xterm.c (XTread_socket): Only modify handling_signal if
33 !SYNC_INPUT. (Bug#11080)
34
35 2012-03-23 Eli Zaretskii <eliz@gnu.org>
36
37 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
38 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
39 when fetching a multibyte character consumes more bytes than
40 CHAR_BYTES returns, due to unification of CJK characters in
41 string_char. (Bug#11073)
42
43 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
44
45 * process.c (wait_reading_process_output): Handle pty disconnect
46 by refraining from sending oneself a SIGCHLD (bug#10933).
47
48 2012-03-22 Chong Yidong <cyd@gnu.org>
49
50 * dispextern.h (struct it): New member string_from_prefix_prop_p.
51
52 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
53 Mark string as coming from a prefix property.
54 (handle_face_prop): Use default face for prefix strings (Bug#4281).
55 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
56
57 2012-03-21 Chong Yidong <cyd@gnu.org>
58
59 * xfaces.c (Vface_remapping_alist): Doc fix.
60
61 2012-03-20 Eli Zaretskii <eliz@gnu.org>
62
63 * w32proc.c (Fw32_set_console_codepage)
64 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
65 Doc fixes.
66
67 2012-03-20 Chong Yidong <cyd@gnu.org>
68
69 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
70 to reflect default non-nil value of redisplay-dont-pause.
71
72 2012-03-19 Kenichi Handa <handa@m17n.org>
73
74 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
75 it fit in a valid range (Bug#11003).
76
77 2012-03-18 Eli Zaretskii <eliz@gnu.org>
78
79 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
80 that is not from display property, accept the row as a "cursor
81 row" if one of the string's character has a non-nil `cursor'
82 property. Fixes cursor positioning when there are newlines in
83 overlay strings, e.g. in icomplete.el. (Bug#11035)
84
85 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
86
87 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
88
89 2012-03-12 Chong Yidong <cyd@gnu.org>
90
91 * eval.c (inhibit_lisp_code): Rename from
92 inhibit_window_configuration_change_hook; move from window.c.
93
94 * xfns.c (unwind_create_frame_1, Fx_create_frame):
95 * window.c (run_window_configuration_change_hook)
96 (syms_of_window): Callers changed.
97
98 2012-03-11 Chong Yidong <cyd@gnu.org>
99
100 * keymap.c (Fkey_description): Doc fix (Bug#9700).
101
102 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
103
104 2012-03-10 Chong Yidong <cyd@gnu.org>
105
106 * frame.c (other_visible_frames): Don't assume the selected frame
107 is visible (Bug#10955).
108
109 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
110
111 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
112
113 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
114
115 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
116 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
117 zero (Bug#10954).
118
119 2012-03-03 Glenn Morris <rgm@gnu.org>
120
121 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
122
123 2012-03-02 Eli Zaretskii <eliz@gnu.org>
124
125 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
126 position past the first glyph_row that ends at ZV. (Bug#10902)
127 (redisplay_window, next_element_from_string): Fix typos in
128 comments.
129 (redisplay_window): Pass to move_it_vertically the margin in
130 pixels, not in screen lines.
131
132 2012-03-02 Glenn Morris <rgm@gnu.org>
133
134 * buffer.c (buffer-list-update-hook): Doc fix.
135
136 2012-02-29 Eli Zaretskii <eliz@gnu.org>
137
138 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
139 push_it before setting up the iterator for the first overlay
140 string, even if we have an empty string loaded.
141 (next_overlay_string): If there's an empty string on the iterator
142 stack, pop the stack. (Bug#10903)
143
144 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
145
146 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
147 Suggested by Stefan Monnier in
148 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
149 * alloc.c (widen_to_Lisp_Object): New static function.
150 (mark_memory): Also mark Lisp_Objects by fetching pointer words
151 and widening them to Lisp_Objects. This would work even if
152 USE_LSB_TAG is defined and wide integers are used, which might
153 happen in a future version of Emacs.
154
155 2012-02-25 Chong Yidong <cyd@gnu.org>
156
157 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
158 Doc fix.
159
160 * xselect.c (Fx_selection_exists_p): Doc fix.
161 (x_clipboard_manager_save_all): Print an informative message
162 before saving to clipboard manager.
163
164 2012-02-24 Chong Yidong <cyd@gnu.org>
165
166 * keyboard.c (process_special_events): Handle all X selection
167 requests in kbd_buffer, not just the next one (Bug#8869).
168
169 2012-02-23 Chong Yidong <cyd@gnu.org>
170
171 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
172 call when setting menu-bar-lines and tool-bar-lines parameters.
173 (unwind_create_frame_1): New helper function.
174
175 * window.c (inhibit_window_configuration_change_hook): New var.
176 (run_window_configuration_change_hook): Obey it.
177 (syms_of_window): Initialize it.
178
179 2012-02-22 Chong Yidong <cyd@gnu.org>
180
181 * xterm.c (x_draw_image_relief): Add missing type check for
182 Vtool_bar_button_margin (Bug#10743).
183
184 2012-02-21 Chong Yidong <cyd@gnu.org>
185
186 * fileio.c (Vfile_name_handler_alist): Doc fix.
187
188 * buffer.c (Fget_file_buffer): Protect against invalid file
189 handler return value.
190
191 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
192
193 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
194 when computing $valmask.
195
196 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
197 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
198 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
199 It's useless in that case, and it can cause problems on hosts
200 that allocate halves of EMACS_INT values separately.
201 Reported by Dan Horák. Diagnosed by Andreas Schwab in
202 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
203 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
204 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
205 it avoids undefined behavior on hosts where shifting right by more
206 than the word width has undefined behavior.
207
208 2012-02-19 Chong Yidong <cyd@gnu.org>
209
210 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
211 (Funhandled_file_name_directory, Ffile_name_as_directory)
212 (Fdirectory_file_name, Fexpand_file_name)
213 (Fsubstitute_in_file_name): Protect against invalid file handler
214 return values (Bug#10845).
215
216 2012-02-18 Eli Zaretskii <eliz@gnu.org>
217
218 * .gdbinit (pitx): Fix incorrect references to fields of the
219 iterator stack.
220
221 2012-02-17 Chong Yidong <cyd@gnu.org>
222
223 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
224
225 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
226
227 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
228 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
229
230 2012-02-15 Chong Yidong <cyd@gnu.org>
231
232 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
233 marked as special. Also, starting docstrings with * is obsolete.
234
235 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
236
237 * gnutls.c (emacs_gnutls_write): Fix last change.
238
239 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
240
241 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
242 send_process.
243
244 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
245
246 * keymap.c (Fsingle_key_description): Handle char ranges.
247
248 2012-02-12 Chong Yidong <cyd@gnu.org>
249
250 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
251 as that creates a dangerous corner case.
252
253 * window.c (Fdelete_window_internal): Invalidate the mouse
254 highlight (Bug#9904).
255
256 2012-02-12 Glenn Morris <rgm@gnu.org>
257
258 * xselect.c (Fx_own_selection_internal)
259 (Fx_get_selection_internal, Fx_disown_selection_internal)
260 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
261 * nsselect.m (Fx_own_selection_internal)
262 (Fx_disown_selection_internal, Fx_selection_exists_p)
263 (Fx_selection_owner_p, Fx_get_selection_internal):
264 Sync docs and argument specs with the xselect.c versions.
265
266 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
267
268 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
269
270 2012-02-11 Eli Zaretskii <eliz@gnu.org>
271
272 * w32select.c (Fx_selection_exists_p): Sync doc string and
273 argument list with xselect.c. (Bug#10783)
274
275 * w16select.c (Fx_selection_exists_p): Sync doc string and
276 argument list with xselect.c. (Bug#10783)
277
278 2012-02-10 Glenn Morris <rgm@gnu.org>
279
280 * fns.c (Fsecure_hash): Doc fix.
281
282 2012-02-09 Kenichi Handa <handa@m17n.org>
283
284 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
285
286 2012-02-07 Chong Yidong <cyd@gnu.org>
287
288 * buffer.c (Fbuffer_local_variables)
289 (buffer_lisp_local_variables): Handle unbound vars correctly;
290 don't let Qunbound leak into Lisp.
291
292 2012-02-07 Glenn Morris <rgm@gnu.org>
293
294 * image.c (Fimagemagick_types): Doc fix.
295
296 * image.c (imagemagick-render-type): Change it from a lisp object
297 to an integer. Move the doc here from the lisp manual.
298 Treat all values not equal to 0 the same.
299
300 2012-02-06 Chong Yidong <cyd@gnu.org>
301
302 * doc.c (store_function_docstring): Avoid applying docstring of
303 alias to base function (Bug#2603).
304
305 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
306
307 * .gdbinit (pp1, pv1): Remove redundant defines.
308 (pr): Use pp.
309
310 2012-02-04 Chong Yidong <cyd@gnu.org>
311
312 * nsterm.m: Declare a global (Bug#10694).
313
314 2012-02-04 Eli Zaretskii <eliz@gnu.org>
315
316 * w32.c (get_emacs_configuration_options):
317 Include --enable-checking, if specified, in the return value.
318
319 2012-02-04 Martin Rudalics <rudalics@gmx.at>
320
321 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
322 after rounding frame sizes. (Bug#9723)
323
324 2012-02-04 Eli Zaretskii <eliz@gnu.org>
325
326 * keyboard.c (adjust_point_for_property): Don't position point
327 before BEGV. (Bug#10696)
328
329 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
330
331 Handle overflow when computing char display width (Bug#9496).
332 * character.c (char_width): Return EMACS_INT, not int.
333 (char_width, c_string_width): Check for overflow when
334 computing the width; this is possible now that individual
335 characters can have unbounded width. Problem introduced
336 by merge from Emacs 23 on 2012-01-19.
337
338 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
339
340 * dbusbind.c (Fdbus_register_method): Mention the return value
341 :ignore in the docstring.
342
343 2012-02-02 Glenn Morris <rgm@gnu.org>
344
345 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
346
347 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
348 Unconditionally set to t. (Bug#10673)
349 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
350 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
351 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
352
353 2012-02-02 Kenichi Handa <handa@m17n.org>
354
355 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
356 0, do not call append_composite_glyph.
357
358 2012-02-02 Kenichi Handa <handa@m17n.org>
359
360 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
361 NULL (Bug#6988).
362 (x_produce_glyphs): If the component of a composition is a null
363 string, set it->pixel_width to 1 to avoid zero-width glyph.
364
365 2012-02-01 Eli Zaretskii <eliz@gnu.org>
366
367 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
368 first 2 arguments are identical. This makes inserting large
369 output from a subprocess an order of magnitude faster on
370 MS-Windows, where all sbrk'ed memory is always contiguous.
371
372 2012-01-31 Glenn Morris <rgm@gnu.org>
373
374 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
375 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
376 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
377
378 2012-01-29 Glenn Morris <rgm@gnu.org>
379
380 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
381
382 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
383
384 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
385
386 2012-01-28 Chong Yidong <cyd@gnu.org>
387
388 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
389
390 2012-01-26 Chong Yidong <cyd@gnu.org>
391
392 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
393
394 * search.c (Fsearch_forward, Fsearch_backward): Document negative
395 repeat counts (Bug#10507).
396
397 2012-01-26 Glenn Morris <rgm@gnu.org>
398
399 * lread.c (syms_of_lread): Doc fix.
400
401 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
402
403 * coding.c (encode_designation_at_bol): Change return value to
404 EMACS_INT.
405
406 2012-01-25 Chong Yidong <cyd@gnu.org>
407
408 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
409
410 2012-01-21 Chong Yidong <cyd@gnu.org>
411
412 * floatfns.c (Fcopysign): Make the second argument non-optional,
413 since nil is not allowed anyway.
414
415 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
416
417 * process.c (read_process_output): Use p instead of XPROCESS (proc).
418 (send_process): Likewise.
419
420 2012-01-19 Martin Rudalics <rudalics@gmx.at>
421
422 * window.c (save_window_save, Fcurrent_window_configuration)
423 (Vwindow_persistent_parameters): Do not use Qstate.
424 Rewrite doc-strings.
425
426 2012-01-19 Kenichi Handa <handa@m17n.org>
427
428 * character.c (char_width): New function.
429 (Fchar_width, c_string_width, lisp_string_width):
430 Use char_width (Bug#9496).
431
432 2012-01-16 Martin Rudalics <rudalics@gmx.at>
433
434 * window.c (Vwindow_persistent_parameters): New variable.
435 (Fset_window_configuration, save_window_save): Handle persistent
436 window parameters.
437
438 2012-01-14 Eli Zaretskii <eliz@gnu.org>
439
440 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
441 thrashing the stack of the thread. (Bug#9087)
442
443 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
444
445 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
446
447 2012-01-11 Eli Zaretskii <eliz@gnu.org>
448
449 * xdisp.c (rows_from_pos_range): Handle the case where the
450 highlight ends on a newline. (Bug#10464)
451 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
452 he end column for display of highlight that ends on a newline
453 before a R2L line.
454
455 2012-01-11 Glenn Morris <rgm@gnu.org>
456
457 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
458 from load-path also when installation-directory is nil. (Bug#10208)
459
460 2012-01-10 Glenn Morris <rgm@gnu.org>
461
462 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
463
464 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
465 Update template values to be closer to their typical values these days.
466
467 2012-01-09 Eli Zaretskii <eliz@gnu.org>
468
469 * xdisp.c (rows_from_pos_range): Accept additional argument
470 DISP_STRING, and accept any glyph in a row whose object is that
471 string as eligible for mouse highlight. Fixes mouse highlight of
472 display strings from overlays. (Bug#10464)
473
474 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
475
476 emacs: fix an auto-save permissions race condition (Bug#10400)
477 * fileio.c (auto_saving_dir_umask): New static var.
478 (Fmake_directory_internal): Use it.
479 (do_auto_save_make_dir): Set it, instead of invoking chmod after
480 creating the directory. The old code temporarily assigns
481 too-generous permissions to the directory.
482 (do_auto_save_eh): Clear it.
483 (Fdo_auto_save): Catch all errors, not just file errors, so
484 that the var is always cleared.
485
486 2012-01-07 Eli Zaretskii <eliz@gnu.org>
487
488 * search.c (scan_buffer): Pass character positions to
489 know_region_cache, not byte positions. (Bug#6540)
490
491 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
492
493 * w32.c (sys_rename): Report EXDEV when rename of a directory
494 fails because the target is on another logical disk. (Bug#10284)
495
496 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
497
498 * xterm.c (x_embed_request_focus): New function.
499
500 * xterm.h: Add prototype.
501
502 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
503
504 2012-01-05 Glenn Morris <rgm@gnu.org>
505
506 * emacs.c (emacs_copyright): Update short copyright year to 2012.
507
508 2012-01-01 Eli Zaretskii <eliz@gnu.org>
509
510 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
511 Load gnutls_transport_set_lowat only if GnuTLS version is below
512 2.11.1.
513 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
514 GnuTLS versions below 2.11.1.
515
516 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
517
518 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
519 to the doc string advising against its use for altering the way
520 windows are scrolled.
521
522 2011-12-28 Kenichi Handa <handa@m17n.org>
523
524 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
525 coding-system ASCII compatible only when it does not produce BOM
526 on encoding (Bug#10383).
527
528 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
529
530 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
531 can scroll.
532 (create_and_show_popup_menu): Always use menu_position_func for
533 Gtk3 (Bug#10361).
534
535 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
536
537 * callint.c (Fcall_interactively): Don't truncate prompt string.
538
539 2011-12-23 Eli Zaretskii <eliz@gnu.org>
540
541 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
542 property that ends at ZV, so that the bidi iteration could be
543 resumed from there (after widening). (Bug#10360)
544
545 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
546
547 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
548
549 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
550
551 * nsterm.m (x_free_frame_resources):
552 Release f->output_data.ns->miniimage.
553 (ns_index_color): Fix indentation. Do not retain
554 color_table->colors[i].
555
556 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
557 before returning.
558
559 * nsfns.m (x_set_background_color): Assign return value from
560 ns_index_color to face-background instead of NSColor*.
561 (ns_implicitly_set_icon_type): Fix indentation.
562 Change assignment in for loop to comparison.
563
564 * emacs.c (ns_pool): New variable.
565 (main): Assign ns_pool.
566 (Fkill_emacs): Call ns_release_autorelease_pool.
567
568 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
569 autorelease fdesc, release fdAttrs and tdict.
570 (ns_get_covering_families): Release charset.
571 (ns_findfonts): Release NSFontDescriptor created with new.
572 (ns_uni_to_glyphs): Fix indentation.
573 (setString): Release attrStr before assigning new value.
574
575 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
576
577 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
578 and NS_IMPL_COCOA.
579 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
580 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
581
582 2011-12-18 David Reitter <reitter@cmu.edu>
583
584 * nsterm.m (ns_term_init): Subscribe for notifications
585 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
586 to method trackingNotification in EmacsMenu.
587
588 * nsmenu.m (trackingMenu): New variable.
589 (trackingNotification): New method (from Aquamacs).
590 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
591 from Aquamacs (Bug#7030).
592
593 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
594
595 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
596 (symbol_to_nsstring): Fix indentation.
597 (ns_symbol_to_pb): New function.
598 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
599 (Fns_rotate_cut_buffers_internal): Remove.
600 (Fns_store_selection_internal): Rename from
601 Fns_store_cut_buffer_internal.
602 (ns_get_foreign_selection, Fx_own_selection_internal)
603 (Fx_disown_selection_internal, Fx_selection_exists_p)
604 (Fns_get_selection_internal, Fns_store_selection_internal):
605 Use ns_symbol_to_pb and check if return value is nil.
606 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
607 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
608 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
609 renamed to Sns_store_selection_internal.
610 (ns_handle_selection_request): Move code to Fx_own_selection_internal
611 and remove this function.
612 (ns_handle_selection_clear): Remove, never used.
613 (Fx_own_selection_internal): Move code from ns_handle_selection_request
614 here.
615
616 2011-12-17 Ken Brown <kbrown@cornell.edu>
617
618 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
619 GID is unknown (Bug#10257).
620
621 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
622
623 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
624 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
625 which caused a build failure on GNU/Linux IA-64. This problem was
626 introduced by my 2011-10-07 patch.
627
628 2011-12-15 Juri Linkov <juri@jurta.org>
629
630 * image.c (imagemagick_error): New function. (Bug#10112)
631 (imagemagick_load_image): Comment out `MagickSetResolution' call.
632 Use `imagemagick_error' where ImageMagick functions return
633 `MagickFalse'.
634 (Fimagemagick_types): Add `Fnreverse' to return the list in the
635 proper order.
636
637 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
638
639 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
640 fill background (Bug#8992).
641
642 2011-12-13 Martin Rudalics <rudalics@gmx.at>
643
644 * window.c (Vwindow_combination_resize)
645 (Vwindow_combination_limit): Use t instead of non-nil in
646 doc-strings.
647 (Vrecenter_redisplay): Add first sentence of doc-string on
648 separate line.
649 (Frecenter): Fix doc-string typo.
650
651 2011-12-11 Kenichi Handa <handa@m17n.org>
652
653 * coding.c (Funencodable_char_position): Pay attention to the
654 buffer text relocation (Bug#9389).
655
656 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
657
658 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
659 gtk_init (Bug#10100).
660
661 2011-12-10 Eli Zaretskii <eliz@gnu.org>
662
663 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
664 IT->string is nil. (Bug#10263)
665
666 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
667
668 * nsterm.h (x_free_frame_resources): Declare.
669
670 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
671 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
672
673 * nsterm.h (ns_get_defaults_value): Declare.
674
675 * nsterm.m (ns_default): Call ns_get_defaults_value.
676
677 2011-12-09 Eli Zaretskii <eliz@gnu.org>
678
679 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
680 (Bug#10170)
681
682 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
683
684 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
685 that where the value of an _OBJC_* symbol points to is in the .bss
686 section (Bug#10240).
687
688 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
689
690 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
691 after the loop to call ccl_driver at least once (Bug#8619).
692
693 2011-12-08 Kenichi Handa <handa@m17n.org>
694
695 * ftfont.c (get_adstyle_property): Fix previous change
696 (Bug#10233).
697
698 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
699
700 * w32.c (init_environment): If no_site_lisp, remove site-lisp
701 dirs from the default value of EMACSLOADPATH (bug#10208).
702
703 2011-12-07 Glenn Morris <rgm@gnu.org>
704
705 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
706 installation and source directories as well. (Bug#10208)
707
708 2011-12-06 Chong Yidong <cyd@gnu.org>
709
710 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
711
712 2011-12-06 Glenn Morris <rgm@gnu.org>
713
714 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
715 as an error, not just -1. (Bug#10217)
716
717 2011-12-05 Chong Yidong <cyd@gnu.org>
718
719 * keyboard.c (process_special_events): New function.
720 (swallow_events, Finput_pending_p): Use it (Bug#10195).
721
722 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
723
724 * coding.c (encode_designation_at_bol): Don't use uninitialized
725 local variable (Bug#9318).
726
727 2011-12-05 Kenichi Handa <handa@m17n.org>
728
729 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
730 return Qnil (Bug#8046, Bug#10193).
731
732 2011-12-05 Kenichi Handa <handa@m17n.org>
733
734 * coding.c (encode_designation_at_bol): New args charbuf_end and
735 dst. Return the number of produced bytes. Callers changed.
736 (coding_set_source): Return how many bytes coding->source was
737 relocated.
738 (coding_set_destination): Return how many bytes
739 coding->destination was relocated.
740 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
741 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
742
743 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
744
745 * coding.c (CODING_CHAR_CHARSET_P): New macro.
746 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
747 macro (Bug#9318).
748
749 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
750
751 The following changes are to fix Bug#9318.
752
753 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
754 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
755 (encode_coding_iso_2022, encode_coding_sjis)
756 (encode_coding_big5, encode_coding_charset): Use the above macros.
757
758 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
759
760 * lisp.h (process_quit_flag): Fix external declaration.
761
762 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
763
764 Don't macro-inline non-performance-critical code.
765 * eval.c (process_quit_flag): New function.
766 * lisp.h (QUIT): Use it.
767
768 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
769
770 * nsfns.m (get_geometry_from_preferences): New function.
771 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
772
773 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
774
775 * emacs.c (Qkill_emacs): Define.
776 (syms_of_emacs): Initialize it.
777 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
778 Qquit_flag to `kill-emacs' instead.
779 (quit_throw_to_read_char): Add parameter `from_signal'.
780 All callers changed. Call Fkill_emacs if requested and safe.
781 * lisp.h (QUIT): Call Fkill_emacs if requested.
782
783 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
784
785 * widget.c (update_wm_hints): Return if wmshell is null.
786 (widget_update_wm_size_hints): New function.
787
788 * widget.h (widget_update_wm_size_hints): Declare.
789
790 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
791 widget_update_wm_size_hints (Bug#10104).
792
793 2011-12-03 Eli Zaretskii <eliz@gnu.org>
794
795 * xdisp.c (handle_invisible_prop): If the invisible text ends just
796 before a newline, prepare the bidi iterator for consuming the
797 newline, and keep the current paragraph direction. (Bug#10183)
798 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
799
800 2011-12-02 Juri Linkov <juri@jurta.org>
801
802 * search.c (Fword_search_regexp): New Lisp function created from
803 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
804 (Fword_search_backward, Fword_search_forward)
805 (Fword_search_backward_lax, Fword_search_forward_lax):
806 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
807 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
808
809 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
810
811 * fileio.c (Finsert_file_contents): Move after-change-function call
812 to before the "handled:" label, since all "goto handled" appear in
813 cases where the *-change-functions have already been properly called
814 (bug#10117).
815
816 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
817
818 * keyboard.c (interrupt_signal): Don't call kill-emacs when
819 waiting for input. (Bug#10169)
820
821 2011-11-30 Eli Zaretskii <eliz@gnu.org>
822
823 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
824 verifies glyph row's hash code--we have just reallocated the
825 glyphs, so their contents can be complete garbage. (Bug#10164)
826
827 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
828
829 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
830
831 2011-11-30 Eli Zaretskii <eliz@gnu.org>
832
833 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
834 attributes are tested _before_ calling verify_row_hash, to protect
835 against GCC re-ordering of the tests. (Bug#10164)
836
837 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
838
839 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
840
841 * xterm.c (handle_one_xevent): Only set async_visible and friends
842 if net_wm_state_hidden_seen is non-zero (Bug#10002)
843 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
844 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
845
846 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
847
848 Remove GCPRO-related macros that exist only to avoid shadowing locals.
849 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
850 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
851 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
852 All uses changed to use GCPRO1 etc.
853 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
854 Revert to old implementation (i.e., before 2011-03-11).
855
856 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
857
858 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
859 of scroll runs so as to avoid assigning disabled bogus rows and
860 unnecessary graphics copy operations.
861
862 2011-11-27 Eli Zaretskii <eliz@gnu.org>
863
864 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
865 (snprintf) [_MSC_VER]: Redirect to _snprintf.
866 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
867 (malloc, free, realloc, calloc): Redirect to e_* only when
868 compiling Emacs.
869
870 * lisp.h (GCTYPEBITS): Move before first use.
871 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
872 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
873 this macro definition.
874
875 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
876 _MSC_VER.
877
878 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
879
880 * gtkutil.c (xg_create_frame_widgets):
881 Call gtk_window_set_has_resize_grip (FALSE) if that function is
882 present with Gtk+ 2.0.
883
884 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
885
886 * fileio.c (Finsert_file_contents): Undo previous change; see
887 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
888
889 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
890
891 Rename locals to avoid shadowing.
892 * fileio.c (Finsert_file_contents):
893 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
894 * process.c (wait_reading_process_output):
895 Rename inner 'proc' to 'p' to avoid shadowing.
896 Indent for consistency with usual Emacs style.
897
898 2011-11-25 Eli Zaretskii <eliz@gnu.org>
899
900 * xdisp.c (redisplay_window): If cursor row is not fully visible
901 after recentering, and scroll-conservatively is set to a large
902 number, scroll window by a few more lines to make the cursor fully
903 visible and out of scroll-margin. (Bug#10105)
904 (start_display): Don't move to the next line if the display should
905 start at a newline that is part of a display vector or an overlay
906 string. (Bug#10119)
907
908 2011-11-24 Juri Linkov <juri@jurta.org>
909
910 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
911 after the `MagickPingImage' call. (Bug#10112)
912
913 2011-11-23 Chong Yidong <cyd@gnu.org>
914
915 * window.c (Fcoordinates_in_window_p): Accept only live windows.
916
917 2011-11-23 Martin Rudalics <rudalics@gmx.at>
918
919 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
920 making another buffer current. (Bug#10114)
921
922 2011-11-23 Glenn Morris <rgm@gnu.org>
923
924 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
925
926 2011-11-23 Chong Yidong <cyd@gnu.org>
927
928 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
929 using it (Bug#5984).
930
931 2011-11-22 Eli Zaretskii <eliz@gnu.org>
932
933 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
934 and header-lines, as they don't have one computed for them.
935 (Bug#10098)
936
937 * .gdbinit (prow): Make displayed values more self-explaining.
938 Add row's hash code.
939
940 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
941
942 * process.c (wait_reading_process_output): Fix asynchrounous
943 GnuTLS socket handling on some versions of the GnuTLS library.
944 (wait_reading_process_output): Add comment and URL.
945
946 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
947
948 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
949
950 2011-11-21 Chong Yidong <cyd@gnu.org>
951
952 * window.c (Fnext_window, Fprevious_window): Doc fix.
953
954 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
955
956 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
957
958 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
959
960 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
961
962 2011-11-20 Martin Rudalics <rudalics@gmx.at>
963
964 * window.c (Fset_window_combination_limit): Rename argument
965 STATUS to LIMIT.
966 (Vwindow_combination_limit): Remove "status" from doc-string.
967
968 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
969
970 * m/ibms390.h: Remove.
971 * m/ibms390x.h: Don't include "ibms390.h".
972
973 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
974
975 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
976 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
977
978 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
979
980 * casetab.c (Fset_case_table):
981 * charset.c (Fcharset_after): Fix typos.
982
983 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
984
985 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
986 Otherwise, valgrind does not work on some platforms.
987 Problem reported by Andreas Schwab in
988 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
989 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
990 is set, removing the need for VIRT_ADDRESS_VARIES.
991 (PURE_P): Use a more-efficient implementation that needs just one
992 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
993 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
994 to 4 (xorl, subq, cmpq, setbe).
995 * alloc.c (pure): Always extern now, since that's the
996 VIRT_ADDR_VARIES behavior.
997 (PURE_POINTER_P): Use a single comparison, not two, for
998 consistency with the new puresize.h.
999 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1000 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1001 Remove VIRT_ADDR_VARIES no longer needed.
1002
1003 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1004
1005 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1006 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1007 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1008 behave as if the cursor position were at the window margin.
1009
1010 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1011 and the cursor position is out of bounds, behave as if the cursor
1012 position were at the window margin. (Bug#10075)
1013
1014 2011-11-18 Chong Yidong <cyd@gnu.org>
1015
1016 * window.c (Fwindow_combination_limit): Make first argument
1017 non-optional, since it is meaningless for live windows like the
1018 selected window.
1019
1020 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1021
1022 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1023
1024 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1025
1026 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1027 (graft_intervals_into_buffer): Simplify.
1028
1029 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1030
1031 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1032 hash values of the two rows.
1033 (copy_row_except_pointers): Preserve the used[] arrays and the
1034 hash values of the two rows. (Bug#10035)
1035 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1036
1037 * xdisp.c (row_hash): New function, body extracted from
1038 compute_line_metrics.
1039 (compute_line_metrics): Call row_hash, instead of computing the
1040 hash code inline.
1041
1042 * dispnew.c (verify_row_hash): Call row_hash for computing the
1043 hash code of a row, instead of duplicating code from xdisp.c.
1044
1045 * dispextern.h (row_hash): Add prototype.
1046
1047 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1048
1049 * frame.c (delete_frame): Don't delete the terminal when the last
1050 X frame is closed if emacs is built with GTK toolkit.
1051
1052 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1053
1054 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1055
1056 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1057
1058 * window.c (Vwindow_splits): Rename to
1059 Vwindow_combination_resize. Suggested by Juri Linkov.
1060 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1061 of Vwindow_splits.
1062
1063 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1064
1065 * nsfns.m (Fns_font_name):
1066 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1067
1068 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1069
1070 * window.h (window): Rename slot "nest" to "combination_limit".
1071 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1072 (Fset_window_nest): Rename to Fset_window_combination_limit.
1073 (Vwindow_nest): Rename to Vwindow_combination_limit.
1074 (recombine_windows, make_parent_window, make_window)
1075 (Fsplit_window_internal, saved_window)
1076 (Fset_window_configuration, save_window_save): Rename all
1077 occurrences of window_nest to window_combination_limit.
1078
1079 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1080
1081 * image.c (imagemagick_load_image): Fix typo.
1082
1083 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1084
1085 * xdisp.c (display_line): Move the call to
1086 highlight_trailing_whitespace before the call to
1087 compute_line_metrics, since the latter needs to see the final
1088 faces of all the glyphs to compute ROW's hash value.
1089 Fixes assertion violations in row_equal_p. (Bug#10035)
1090
1091 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1092
1093 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1094 just return (bug#10044).
1095
1096 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1097
1098 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1099 with user-defined heap size. Bump the default size of the temacs
1100 heap to 27MB, to avoid memory warning when running temacs.
1101 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1102
1103 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1104 current_matrix and desired_matrix. (Bug#9990)
1105 (verify_row_hash) [XASSERTS]: New function.
1106 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1107 that the hash value of glyph rows is correct.
1108
1109 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1110
1111 * window.h (window): Remove splits slot.
1112 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1113 (Fdelete_other_windows_internal, make_parent_window)
1114 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1115 (Fset_window_configuration, save_window_save): Don't deal with
1116 split status of windows.
1117 (saved_window): Remove splits slot.
1118 (Vwindow_splits): Rewrite doc-string.
1119
1120 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1121
1122 * xfns.c (unwind_create_frame):
1123 * nsfns.m (unwind_create_frame):
1124 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1125 Vframe_list (Bug#9999).
1126
1127 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1128
1129 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1130
1131 2011-11-11 Kenichi Handa <handa@m17n.org>
1132
1133 * callproc.c (Fcall_process): Set the member dst_multibyte of
1134 process_coding.
1135
1136 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1137
1138 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1139 avoid a crash (bug#9496).
1140
1141 2011-11-09 Chong Yidong <cyd@gnu.org>
1142
1143 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1144 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1145
1146 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1147
1148 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1149
1150 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1151
1152 Avoid some portability problems by eschewing 'extern inline' functions.
1153 The trivial performance wins aren't worth the portability hassles; see
1154 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1155 et seq.
1156 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1157 (window_box_width, window_box_left, window_box_left_offset)
1158 (window_box_right, window_box_right_offset): Undo previous change,
1159 by removing the "extern"s.
1160 * intervals.c (adjust_intervals_for_insertion)
1161 (adjust_intervals_for_deletion): Undo previous change,
1162 making these static again.
1163 (offset_intervals, temp_set_point_both, temp_set_point)
1164 (copy_intervals_to_string): No longer inline.
1165 * xdisp.c (window_text_bottom_y, window_box_width)
1166 (window_box_height, window_box_left_offset)
1167 (window_box_right_offset, window_box_left, window_box_right)
1168 (window_box): No longer inline.
1169
1170 2011-11-08 Chong Yidong <cyd@gnu.org>
1171
1172 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1173 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1174 Signal an error if not a live window.
1175 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1176 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1177
1178 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1179
1180 * lisp.h (syms_of_abbrev): Remove declaration.
1181 Reported by CHENG Gao <chenggao@royau.me>.
1182
1183 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1184
1185 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1186 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1187 of temacs in GUI mode.
1188
1189 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1190
1191 * window.h: Declare delete_all_child_windows instead of
1192 delete_all_subwindows.
1193 * window.c (Fwindow_nest, Fset_window_nest)
1194 (Fset_window_new_total, Fset_window_new_normal)
1195 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1196 (delete_all_subwindows): Rename to delete_all_child_windows.
1197 (Fdelete_other_windows_internal, Fset_window_configuration):
1198 Call delete_all_child_windows instead of delete_all_subwindows.
1199 * frame.c (delete_frame): Call delete_all_child_windows instead
1200 of delete_all_subwindows.
1201
1202 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1203
1204 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1205 This is also needed for porting to any host where GC_MARK_STACK is
1206 not GC_MAKE_GCPROS_NOOPS.
1207 (which_symbols): Use it.
1208
1209 2011-11-07 Kenichi Handa <handa@m17n.org>
1210
1211 * coding.c (coding_set_destination): Check coding->src_pos only
1212 when coding->src_object is a buffer (bug#9910).
1213
1214 * process.c (send_process): Set the member src_multibyte of coding
1215 to 0 (bug#9911) when sending a unibyte text.
1216
1217 * callproc.c (Fcall_process): Set the member src_multibyte of
1218 process_coding to 0 (bug#9912).
1219
1220 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1221
1222 * xmenu.c (cleanup_widget_value_tree): New function.
1223 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1224 calling free_menubar_widget_value_tree directly (Bug#9830).
1225
1226 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1227
1228 Fix some portability problems with 'inline'.
1229 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1230 (window_box_width, window_box_left, window_box_left_offset)
1231 (window_box_right, window_box_right_offset): Declare extern.
1232 Otherwise, these inline functions do not conform to C99 and
1233 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1234 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1235 * intervals.c (adjust_intervals_for_insertion)
1236 (adjust_intervals_for_deletion): Now extern, because otherwise the
1237 extern inline functions 'offset_intervals' couldn't refer to it.
1238 (static_offset_intervals): Remove.
1239 (offset_intervals): Rewrite using the old contents of
1240 static_offset_intervals. The old version didn't conform to C99
1241 because an extern inline function contained a reference to an
1242 identifier with static linkage.
1243
1244 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1245
1246 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1247 GC.
1248
1249 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1250
1251 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1252 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1253 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1254 return Qleft_to_right.
1255
1256 2011-11-06 Chong Yidong <cyd@gnu.org>
1257
1258 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1259 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1260 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1261 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1262 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1263 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1264 (Fwindow_vscroll): Doc fix.
1265 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1266 argument, since it makes no sense to pass a live window and for
1267 consistency with window-child.
1268
1269 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1270
1271 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1272 support MSVC.
1273
1274 2011-11-05 Jason Rumney <jasonr@gnu.org>
1275
1276 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1277 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1278 fonts (Bug#6029).
1279 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1280 bitwise arithmetic preventing use of unicode-sip and non-truetype
1281 opentype fonts.
1282
1283 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1284
1285 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1286 "emacs"-only part.
1287
1288 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1289 initialization code to keep similarity to xfns.c after changes
1290 from 2011-11-05.
1291
1292 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1293
1294 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1295 (unwind_create_frame): New function (Bug#9943).
1296 (Fx_create_frame): Restructure code to be more similar to the one in
1297 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1298 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1299 Move terminal->reference_count++ just before making the frame official
1300 (Bug#9943).
1301
1302 * nsterm.m (x_free_frame_resources): New function.
1303 (x_destroy_window): Move code to x_free_frame_resources.
1304
1305 * xfns.c (unwind_create_frame): Fix comment.
1306 (Fx_create_frame, x_create_tip_frame):
1307 Move terminal->reference_count++ just before making the frame
1308 official. Move initialization of image_cache_refcount and
1309 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1310
1311 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1312
1313 Support MSVC build with newer versions of Visual Studio.
1314 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1315 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1316 nt/gmake.defs.
1317
1318 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1319 which are not supported by MSVC.
1320 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1321 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1322 bitfields.
1323 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1324 types in bitfields.
1325 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1326
1327 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1328
1329 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1330
1331 Support MSVC build with newer versions of Visual Studio.
1332 * w32.c: Don't include w32api.h for MSVC.
1333 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1334
1335 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1336 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1337 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1338 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1339 e_* cousins.
1340 (alloca) [_MSC_VER]: Define to _alloca.
1341
1342 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1343
1344 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1345
1346 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1347
1348 * xdisp.c (note_mouse_highlight): If either of
1349 previous/next-single-property-change returns nil, treat that as
1350 the beginning or the end of the buffer. (Bug#9955)
1351
1352 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1353
1354 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1355 label is not null (Bug#9951).
1356 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1357 may be NULL.
1358
1359 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1360
1361 * window.c (Fwindow_body_size): Mention in the doc string that the
1362 return value is in frame's canonical units. (Bug#9949)
1363
1364 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1365
1366 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1367
1368 * w32fns.c (unwind_create_frame): If needed, free the glyph
1369 matrices of the partially constructed frame. (Bug#9943)
1370 * xfns.c (unwind_create_frame): Likewise.
1371
1372 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1373
1374 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1375 Don't stop backward scan on the continuation glyph, even though
1376 its CHARPOS is positive.
1377 (mouse_face_from_buffer_pos, note_mouse_highlight):
1378 Rename cover_string to disp_string.
1379
1380 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1381
1382 * window.c (temp_output_buffer_show): Don't use
1383 Vtemp_buffer_show_specifiers.
1384 (Vtemp_buffer_show_specifiers): Remove unused variable.
1385
1386 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1387
1388 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1389 past the beginning of the current glyph matrix.
1390
1391 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1392
1393 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1394 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1395 HAVE_GTK3 (Bug#9869).
1396
1397 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1398 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1399
1400 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1401
1402 * xterm.c: Declare x_handle_net_wm_state to return int.
1403 (handle_one_xevent): Check if we are iconified but don't have
1404 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1405 (get_current_wm_state): Return non-zero if not hidden,
1406 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1407 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1408 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1409 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1410
1411 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1412
1413 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1414 so that this new function doesn't get optimized away by a
1415 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1416
1417 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1418
1419 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1420
1421 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1422
1423 Fix the `xbytecode' command.
1424 * .gdbinit (xprintbytestr): New command.
1425 (xwhichsymbols): Rename from `which'; all callers changed.
1426 (xbytecode): Print the byte-code string as well.
1427
1428 2011-10-29 Kim Storm <storm@cua.dk>
1429
1430 * alloc.c (which_symbols): New function.
1431
1432 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1433
1434 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1435 line. (Bug#9903)
1436
1437 2011-10-29 Glenn Morris <rgm@gnu.org>
1438
1439 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1440 Not clear what it was for, and it causes various bugs. (Bug#9839)
1441
1442 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1443
1444 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1445 possible random value that matches one of those tested as
1446 condition to clear the mouse face.
1447
1448 2011-10-28 Chong Yidong <cyd@gnu.org>
1449
1450 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1451
1452 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1453
1454 * window.c (make_window): Initialize phys_cursor_on_p.
1455
1456 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1457
1458 * lisp.h (struct Lisp_Symbol): Update comments.
1459
1460 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1461
1462 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1463
1464 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1465
1466 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1467 <oslsachem@gmail.com> for helping to debug this.
1468
1469 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1470 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1471 (g_b_init_get_glyph_outline_w): New static variables.
1472 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1473 (GetGlyphOutlineW_Proc): New typedefs.
1474 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1475 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1476 New functions.
1477 (w32font_open_internal, compute_metrics):
1478 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1479 instead of calling the "wide" APIs directly.
1480
1481 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1482
1483 * w32.h (syms_of_w32font): Add prototype.
1484
1485 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1486
1487 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1488 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1489 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1490 (Fmove_to_window_line): Doc fix.
1491
1492 2011-10-27 Chong Yidong <cyd@gnu.org>
1493
1494 * process.c (make_process): Set gnutls_state to NULL.
1495
1496 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1497 non-NULL, regardless of GNUTLS_INITSTAGE.
1498 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1499 an error. Set process slots as soon as we allocate them.
1500
1501 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1502
1503 2011-10-27 Chong Yidong <cyd@gnu.org>
1504
1505 * gnutls.c (emacs_gnutls_deinit): New function.
1506 Deallocate credentials structures as well as calling gnutls_deinit.
1507 (Fgnutls_deinit, Fgnutls_boot): Use it.
1508
1509 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1510 (deactivate_process): Call emacs_gnutls_deinit.
1511
1512 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1513
1514 * image.c (x_create_x_image_and_pixmap):
1515 * w32.c (sys_rename, w32_delayed_load):
1516 * w32font.c (fill_in_logfont):
1517 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1518
1519 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1520
1521 * w32fns.c (w32_default_color_map): New function,
1522 extracted from Fw32_default_color_map.
1523 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1524
1525 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1526
1527 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1528
1529 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1530
1531 * keyboard.c (test_undefined): New function (bug#9751).
1532 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1533
1534 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1535
1536 * sysdep.c (init_sys_modes): Fix the check for the controlling
1537 terminal (Bug#6649).
1538
1539 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1540
1541 * dispextern.h (struct bidi_it): New member next_en_type.
1542
1543 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1544 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1545 current character, check also for next_en_type being WEAK_EN.
1546 (bidi_resolve_weak): Don't enter the expensive loop if the current
1547 position is before next_en_pos. Record the bidi type of the first
1548 non-ET, non-BN character we find, in addition to its position.
1549 (bidi_level_of_next_char): Invalidate next_en_type when
1550 next_en_pos is over-stepped.
1551
1552 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1553
1554 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1555 * editfns.c: Rewrite current-time-zone so that it invokes
1556 the equivalent of (format-time-string "%Z") to get the time zone name.
1557 This fixes a bug when the time zone name contains characters that
1558 need converting from the system time locale to Emacs internal format.
1559 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1560 that patch fixed format-time-string to do the conversion, but
1561 I forgot to fix current-time-zone.
1562 (format_time_string): New function, containing most of
1563 what Fformat_time_string used to contain.
1564 (Fformat_time_string): Rewrite in terms of format_time_string.
1565 This doesn't change this function's behavior.
1566 (current-time-zone): Rewrite to use format_time_string.
1567 This fixes the bug reported by Michael Schierl in
1568 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1569 Jason Rumney's 2007-06-07 change worked around this bug, but
1570 didn't fix it.
1571 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1572
1573 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1574
1575 * xdisp.c (start_display): If the character at POS is displayed
1576 via a display vector, reset IT->current.dpvec_index to zero.
1577 (try_window_reusing_current_matrix): If a line ends in a display
1578 vector or the next line starts in a display vector, continue
1579 redrawing the window even though the character position of
1580 start_row was reached.
1581 (Bug#9771, part 2)
1582
1583 2011-10-18 Chong Yidong <cyd@gnu.org>
1584
1585 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1586 with nobreak-char-display too.
1587
1588 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1589
1590 Fix part 3 of bug#9771.
1591 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1592 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1593 non-neutral characters if the current character is a paragraph
1594 separator (a.k.a. Newline). This avoids running the same
1595 expensive loop twice, once when we consume the preceding newline
1596 and the other time when the line actually needs to be displayed.
1597 Avoid the loop when we see neutrals on the base embedding level
1598 following a character whose directionality is the same as the
1599 paragraph's. This avoids running the expensive loop when a line
1600 ends in a long sequence of neutrals, like control characters.
1601 Add assertion against STRONG_AL type. Slightly rearrange code
1602 that determines the type of a neutral given the first non-neutral
1603 that follows it.
1604 (bidi_level_of_next_char): Set next_en_pos to zero when
1605 invalidating its info.
1606
1607 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1608
1609 * xdisp.c (push_display_prop): Determine whether to record string
1610 or buffer position by IT->string, not by IT->method. Allow
1611 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1612 (move_it_vertically_backward): Don't look for character position
1613 immediately after the newline when in a continuation line.
1614 (Bug#9771, part 1)
1615
1616 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1617
1618 * window.c (coordinates_in_window): Rewrite and delabelize
1619 vertical border check. (Bug#5357) (Bug#9618)
1620
1621 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1622
1623 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1624 errors in XSetWindowBorder (bug#9310).
1625
1626 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1627
1628 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1629 avoid crash when xmalloc overrun checking is enabled.
1630
1631 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1632
1633 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1634 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1635 cursor motion with <left> and <right> arrow keys.
1636
1637 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1638 some callers set that themselves.
1639
1640 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1641
1642 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1643 display string and the previous row comes from the same string and
1644 is empty. (Bug#9739) (Bug#9738)
1645
1646 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1647
1648 * doc.c (get_doc_string): Encode file name (bug#9735).
1649
1650 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1651
1652 * bidi.c (bidi_level_of_next_char):
1653 * xdisp.c (get_visually_first_element): Remove old incorrect
1654 comments regarding the Unicode Line Separator character.
1655
1656 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1657
1658 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1659
1660 * alloc.c (Fgc_status): Do not access beyond zombies array
1661 boundary if nzombies > MAX_ZOMBIES.
1662 * alloc.c (dump_zombies): Add missing format specifier.
1663
1664 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1665
1666 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1667 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1668
1669 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1670 Some packages use them to denote characters with modifiers.
1671
1672 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1673
1674 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1675 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1676 matching a pp-number. Rename parameter var to var1.
1677
1678 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1679
1680 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1681
1682 2011-10-08 Glenn Morris <rgm@gnu.org>
1683
1684 * callint.c (Fcall_interactively): Give a more explicit error for the
1685 'c' case with a non-character input. (Bug#8479)
1686
1687 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1688
1689 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1690 lines.
1691 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1692 lines that are hscrolled on the left.
1693
1694 * dispnew.c (buffer_posn_from_coords): Account for a possible
1695 presence of header-line. (Bug#4426)
1696
1697 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1698
1699 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1700 Don't advertise functionality which we discourage or doesn't work.
1701
1702 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1703
1704 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1705 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1706 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1707 this makes Emacs dump core during garbage collection on rare
1708 occasions. sizeof is obviously inferior to offsetof here, so
1709 stick with offsetof.
1710 (GC_POINTER_ALIGNMENT): New macro.
1711 (mark_memory): Omit 3rd (offset) arg; caller changed.
1712 Don't assume EMACS_INT alignment is the same as pointer alignment.
1713
1714 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1715
1716 * keyboard.c (read_key_sequence_remapped): New var.
1717 (read_key_sequence): Compute remapping in the right buffer.
1718 (command_loop_1): Use read_key_sequence's remapping directly.
1719
1720 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1721
1722 * dired.c (file_name_completion): Don't expand file name.
1723 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1724 before checking file name handler.
1725
1726 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1727 they've been requested explicitly (bug#9591).
1728
1729 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1730
1731 * keymap.c (Fsingle_key_description): Use make_specified_string
1732 instead of build_string to build string from push_key_description.
1733 (Bug#5193)
1734
1735 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1736
1737 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1738 This fixes a Y2038 bug on 64-bit hosts.
1739 * buffer.c (reset_buffer):
1740 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1741 (Fclear_buffer_auto_save_failure):
1742 Use 0, not -1, to represent an unset failure time, since time_t
1743 might not be signed.
1744
1745 Remove dependency on glibc malloc internals.
1746 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1747 Move back here from lisp.h, but with their new implementations.
1748 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1749 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1750 * charset.c (charset_table_init): New static var.
1751 (syms_of_charset): Use it instead of xmalloc. This removes a
1752 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1753 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1754 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1755 Move back to alloc.c.
1756 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1757 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1758
1759 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1760
1761 * nsterm.m (windowDidResize): Call x_set_window_size only when
1762 ns_in_resize is true. Otherwise set pixelwidth/height and
1763 call change_frame_size (Bug#9628).
1764
1765 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1766
1767 Port --enable-checking=all to Fedora 14 x86-64.
1768 * charset.c (syms_of_charset): Also account for glibc malloc's
1769 internal overhead when calculating the initial malloc maximum.
1770
1771 Port --enable-checking=all to Fedora 14 x86.
1772 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1773 Move to lisp.h.
1774 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1775 (overrun_check_realloc, overrun_check_free):
1776 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1777 That way, xmalloc returns a properly-aligned pointer even if
1778 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1779 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1780 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1781 into account when calculating the initial malloc maximum.
1782 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1783 Move here from alloc.c, so that charset.c can use it too.
1784 Properly align; the old code wasn't right for common 32-bit hosts
1785 when configured with --enable-checking=all.
1786 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1787 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1788
1789 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1790
1791 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1792 use EDOM.
1793
1794 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1795
1796 * xdisp.c (compute_display_string_end): If there's no display
1797 string at CHARPOS, return -1.
1798
1799 * bidi.c (bidi_fetch_char): When compute_display_string_end
1800 returns a negative value, treat the character as a normal
1801 character not covered by a display string. (Bug#9624)
1802
1803 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1804
1805 * lread.c (Fread_from_string): Fix typo in docstring.
1806
1807 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1808
1809 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1810 newline, reseat the iterator instead of bidi-iterating there one
1811 character at a time. (Bug#9610)
1812 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1813 TO_CHARPOS if the bidi iterator is at base embedding level.
1814
1815 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1816
1817 * lread.c (readevalloop): Use correct code for NBSP.
1818 (read1): Likewise. (Bug#9608)
1819
1820 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1821
1822 * dbusbind.c (Fdbus_register_signal): When service is not
1823 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1824
1825 2011-09-25 Glenn Morris <rgm@gnu.org>
1826
1827 * buffer.c (truncate-lines): Doc fix.
1828
1829 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1830
1831 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1832 (Fset_window_next_buffers): Doc fix.
1833
1834 2011-09-24 Glenn Morris <rgm@gnu.org>
1835
1836 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1837
1838 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1839
1840 Fix minor problems found by static checking.
1841 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1842 * indent.c (Fvertical_motion): Fix == vs = typo.
1843
1844 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1845
1846 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1847 Default value is now t. Doc fix.
1848
1849 * indent.c (Fvertical_motion): Compute and apply the overshoot
1850 logic when moving up, not only when moving down. Fix the
1851 confusing name and values of the it_overshoot_expected variable;
1852 logic changes accordingly. (Bug#9254) (Bug#9549)
1853
1854 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1855 CHARPOS is covered by a display string which includes newlines.
1856 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1857 is covered by a display string with embedded newlines.
1858
1859 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1860
1861 * dbusbind.c (Fdbus_register_signal): Add match rule to
1862 Vdbus_registered_objects_table. (Bug#9581)
1863 (Fdbus_register_method, Vdbus_registered_objects_table):
1864 Fix docstring.
1865
1866 2011-09-24 Jim Meyering <meyering@redhat.com>
1867
1868 do not ignore write error for any output size
1869 The previous change was incomplete.
1870 While it makes emacs --batch detect the vast majority of stdout
1871 write failures, errors were still ignored whenever the output size is
1872 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1873 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1874 && echo FAIL: ignored write error
1875 FAIL: ignored write error
1876 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1877 && echo FAIL: ignored write error
1878 FAIL: ignored write error
1879 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1880
1881 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1882
1883 * emacs.c (Fkill_emacs): In noninteractive mode exit
1884 non-successfully if a write error occurred on stdout. (Bug#9574)
1885
1886 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1887
1888 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1889 the xassert test.
1890
1891 * dispextern.h (struct it): Update the comment documenting what
1892 can it->OBJECT be.
1893
1894 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1895
1896 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1897 a display string, extend search for cursor position to end of row.
1898 (find_row_edges): If the row ends in a newline from a display
1899 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1900 Handle the case of a display string with multiple newlines.
1901 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1902 non-empty line. Fixes confusing cursor motion with arrow keys at
1903 the beginning of a line that starts with whitespace.
1904
1905 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1906
1907 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1908 (bug#9493).
1909
1910 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1911
1912 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1913 boolean (Bug#9154).
1914
1915 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1916
1917 * xdisp.c (display_line): Record maximum and minimum buffer
1918 positions even if no glyphs were produced (e.g., by a zero-width
1919 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1920 buffer positions that will be removed from the glyph row because
1921 they don't fit.
1922 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1923 column is beyond frame width: don't subtract 1 "pixel" when
1924 computing width of the stretch.
1925 (reseat_at_next_visible_line_start): Undo the change made on
1926 2011-09-17 that saved paragraph information and restored it after
1927 the call to `reseat'. (Bug#9545)
1928
1929 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1930
1931 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1932 and turn window cursor on if cleared (Bug#9415).
1933
1934 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1935
1936 * search.c (boyer_moore): Take unibyte characters from pattern
1937 literally. (Bug#9458)
1938
1939 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1940
1941 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1942
1943 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1944
1945 Fix minor problem found by static checking.
1946 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1947 initialized, to pacify gcc -Wuninitialized.
1948
1949 * fileio.c: Report proper errno when syscall falls.
1950 (Finsert_file_contents): Save and restore errno,
1951 so that report_file_error outputs the correct diagnostic.
1952 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1953
1954 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1955
1956 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1957
1958 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1959
1960 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1961 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1962
1963 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1964
1965 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1966 about the current paragraph and restore it after the call to reseat.
1967
1968 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1969 (bidi_find_paragraph_start): Search back for paragraph beginning
1970 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1971 (bidi_move_to_visually_next): Only trigger paragraph-related
1972 computations when the last character is a newline or at EOB, not
1973 just any NEUTRAL_B. (Bug#9470)
1974
1975 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1976 truncated lines if point is covered by a display string. (Bug#9524)
1977
1978 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1979
1980 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1981 (cons_to_x_long): New function.
1982 (lisp_data_to_selection_data): Use it. Correct the test for
1983 short-versus-long data; it was negated. Break out of vector
1984 loop, for efficiency, when a long datum is discovered.
1985
1986 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1987
1988 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1989
1990 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1991
1992 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1993 GCC PR/17406) by declaring this function with external scope.
1994
1995 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1996
1997 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1998 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1999
2000 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2001
2002 * editfns.c (Fformat): Correctly handle text properties on "%%".
2003
2004 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2005
2006 * xterm.c (x_draw_composite_glyph_string_foreground):
2007 * w32term.c (x_draw_composite_glyph_string_foreground):
2008 * term.c (encode_terminal_code):
2009 * composite.c (composition_update_it, get_composition_id):
2010 * xdisp.c (get_next_display_element)
2011 (fill_composite_glyph_string): Add comments about special meaning
2012 of TAB characters in a composition.
2013
2014 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2015
2016 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2017 This occurs when processing a multibyte format.
2018 Problem reported by Wolfgang Jenker.
2019
2020 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2021
2022 * xdisp.c (try_cursor_movement): Only check for exact match if
2023 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2024
2025 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2026
2027 Remove unused external symbols.
2028 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2029 * xdisp.c (calc_pixel_width_or_height): Now static.
2030 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2031 * indent.c (check_display_width):
2032 * w32term.c: Fix comment to match code.
2033 * xterm.c, xterm.h (x_catching_errors): Remove.
2034
2035 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2036
2037 * xselect.c: Use signed conversions more consistently (Bug#9498).
2038 (selection_data_to_lisp_data): Assume incoming selection data are
2039 signed integers, not unsigned. This is to be consistent with
2040 outgoing selection data, which was modified to use signed integers
2041 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2042 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2043 expects long, not unsigned long.
2044
2045 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2046
2047 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2048 computation of loop end. Reported by Johan Bockgård
2049 <bojohan@gnu.org>.
2050
2051 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2052
2053 * frame.c (Fother_visible_frames_p): Function deleted.
2054
2055 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2056
2057 * indent.c (compute_motion): Process display vector front to back
2058 rather than the other way around. (Bug#2496)
2059
2060 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2061
2062 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2063
2064 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2065
2066 * minibuf.c (Fread_from_minibuffer): Doc fix.
2067
2068 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2069
2070 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2071 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2072
2073 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2074
2075 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2076 value for non-existent files.
2077
2078 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2079
2080 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2081 set its "size" to -1. This will set the modtime_size field of
2082 the corresponding buffer to -1, which is what
2083 verify-visited-file-modtime expects for files that do not exist.
2084 (Bug#9139)
2085
2086 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2087
2088 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2089 here ...
2090 * lisp.h: ... from here. push_key_description is no longer
2091 defined in keyboard.c, so its declaration should not be in
2092 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2093 logically belongs with push_key_description.
2094
2095 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2096
2097 * buffer.h: Include <sys/types.h> instead of <time.h>.
2098 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2099 Problem reported by Herbert J. Skuhra.
2100
2101 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2102
2103 * xml.c (parse_region): Make the parsing work for
2104 non-comment-starting XML files again (bug#9144).
2105
2106 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2107
2108 * image.c (gif_load): Fix calculation of bottom and right corner.
2109 (Bug#9468)
2110
2111 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2112
2113 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2114 redisplay in small windows.
2115
2116 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2117
2118 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2119
2120 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2121
2122 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2123 Operate on live windows only.
2124
2125 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2126
2127 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2128
2129 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2130
2131 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2132 only under bidi iteration.
2133
2134 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2135
2136 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2137
2138 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2139
2140 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2141 Without this fix, the command to link temacs failed due to an
2142 undefined symbol __builtin_isnan. This is because
2143 /usr/include/iso/math_c99.h #defines isnan(x) to
2144 __builtin_isnan(x), but the bundled gcc, which identifies itself
2145 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2146 a __builtin_isnan.
2147 * floatfns.c (isnan): #undef, and then #define to a clone of
2148 what's in data.c.
2149 (Fisnan): Always define, since it's always available now.
2150 (syms_of_floatfns): Always define isnan at the Lisp level.
2151
2152 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2153
2154 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2155
2156 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2157
2158 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2159 The previous code assumed that file offsets (off_t values) fit in
2160 EMACS_INT variables, which is not true on typical 32-bit hosts.
2161 The code messed up by falsely reporting buffer overflow in cases
2162 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2163 when "big" contains more than 2**29 bytes, even though this
2164 inserts just one byte and does not overflow the buffer.
2165 (Finsert_file_contents): Store file offsets as off_t
2166 values, not as EMACS_INT values. Check for overflow when
2167 converting between EMACS_INT and off_t. When checking for
2168 buffer overflow or for overlap, take the offsets into account.
2169 Don't use EMACS_INT for small values where int suffices.
2170 When checking for overlap, fix a typo: ZV was used where
2171 ZV_BYTE was intended.
2172 (Fwrite_region): Don't assume off_t fits into 'long'.
2173 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2174
2175 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2176
2177 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2178
2179 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2180
2181 sprintf-related integer and memory overflow issues (Bug#9412).
2182
2183 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2184 (esprintf, exprintf, evxprintf): New functions.
2185 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2186 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2187 (modify_event_symbol): Do not assume that the length of
2188 name_alist_or_stem is safe to alloca and fits in int.
2189 (Fexecute_extended_command): Likewise for function name and binding.
2190 (Frecursion_depth): Wrap around reliably on integer overflow.
2191 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2192 since some callers pass EMACS_INT values.
2193 (Fsingle_key_description): Don't crash if symbol name contains more
2194 than MAX_ALLOCA bytes.
2195 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2196 (get_minibuffer): Arg is now EMACS_INT, not int.
2197 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2198 (esprintf, exprintf, evxprintf): New decls.
2199 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2200
2201 * dbusbind.c (signature_cat): New function.
2202 (xd_signature, Fdbus_register_signal):
2203 Do not overrun buffer; instead, report string overflow.
2204
2205 * dispnew.c (add_window_display_history): Don't overrun buffer.
2206 Truncate instead; this is OK since it's just a log.
2207
2208 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2209 even if the time zone offset is outlandishly large.
2210 Don't mishandle offset == INT_MIN.
2211
2212 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2213 when creating daemon; the previous buffer-overflow check was incorrect.
2214
2215 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2216 which has the guts of the old verror function.
2217
2218 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2219 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2220
2221 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2222 (font_unparse_xlfd): Don't blindly alloca long strings.
2223 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2224 fits in int, when using sprintf. Use single snprintf to count
2225 length of string rather than counting it via multiple sprintfs;
2226 that's simpler and more reliable.
2227 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2228 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2229 sprintf, in case result does not fit in int.
2230
2231 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2232 (fontset_from_font): Print it.
2233
2234 * frame.c (tty_frame_count): Now printmax_t, not int.
2235 (make_terminal_frame, set_term_frame_name): Print it.
2236 (x_report_frame_params): In X, window IDs are unsigned long,
2237 not signed long, so print them as unsigned.
2238 (validate_x_resource_name): Check for implausibly long names,
2239 and don't assume name length fits in 'int'.
2240 (x_get_resource_string): Don't blindly alloca invocation name;
2241 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2242 not fit in int.
2243
2244 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2245 (xg_check_special_colors, xg_set_geometry):
2246 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2247
2248 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2249 Use esprintf, not sprintf, in case result does not fit in int.
2250
2251 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2252 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2253 it as a large positive number.
2254 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2255 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2256
2257 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2258 in case result does not fit in int.
2259
2260 * print.c (float_to_string): Detect width overflow more reliably.
2261 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2262 buffer overrun. Don't assume list length fits in 'int'. Treat
2263 print length of 0 as 0, not as infinity; to be consistent with other
2264 uses of print length in this function. Don't overflow print length
2265 index. Don't assume hash table size fits in 'long', or that
2266 vectorlike size fits in 'unsigned long'.
2267
2268 * process.c (make_process): Use printmax_t, not int, to format
2269 process-name gensyms.
2270
2271 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2272
2273 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2274 to avoid potential buffer overrun.
2275
2276 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2277 if X resource line is longer than 512 bytes.
2278
2279 * xfns.c (x_window): Make sprintf buffer a bit bigger
2280 to avoid potential buffer overrun.
2281
2282 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2283
2284 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2285
2286 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2287
2288 Integer overflow fixes for scrolling, etc.
2289 Without these, Emacs silently mishandles large integers sometimes.
2290 For example, "C-u 4294967297 M-x recenter" was treated as if
2291 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2292
2293 * xdisp.c (try_window_id): Check Emacs fixnum range before
2294 converting to 'int'.
2295
2296 * window.c (window_scroll_line_based, Frecenter):
2297 Check that an Emacs fixnum is in range before assigning it to 'int'.
2298 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2299 values converted from Emacs fixnums.
2300 (Frecenter): Don't wrap around a line count if it is out of 'int'
2301 range; instead, treat it as an extreme value.
2302 (Fset_window_configuration, compare_window_configurations):
2303 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2304
2305 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2306 that can exceed INT_MAX. Check that EMACS_INT value is in range
2307 before assigning it to the (possibly-narrower) index.
2308 (match_limit): Don't assume that a fixnum can fit in 'int'.
2309
2310 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2311 exceed INT_MAX.
2312
2313 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2314 (Fvertical_motion): Don't wrap around LINES values that don't fit
2315 in 'int'. Instead, treat them as extreme values. This is good
2316 enough for windows, which can't have more than INT_MAX lines anyway.
2317
2318 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2319
2320 * Require libxml/parser.h to avoid compilation warning.
2321
2322 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2323
2324 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2325 since this reportedly can destroy thread storage.
2326
2327 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2328
2329 * syntax.c (find_defun_start): Update all cache variables if
2330 exiting early (Bug#9401).
2331
2332 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2333
2334 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2335
2336 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2337 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2338 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2339
2340 * term.c (tty_append_glyph): New function.
2341 (produce_stretch_glyph): Static function and its prototype deleted.
2342
2343 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2344 Add prototypes.
2345
2346 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2347
2348 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2349 when checking :margin (Bug#9390).
2350 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2351 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2352 so that the name doesn't mislead. All uses changed.
2353
2354 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2355
2356 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2357 set_tty_hooks.
2358
2359 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2360
2361 * xdisp.c (move_it_to): Don't bail out early when reaching
2362 position beyond to_charpos, if we are scanning backwards.
2363 (move_it_vertically_backward): When DY == 0, make sure we get to
2364 the first character in the line after the newline.
2365
2366 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2367
2368 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2369 (ccl_driver): Do not generate an out-of-range pointer.
2370 (Fccl_execute_on_string): Remove unnecessary check for
2371 integer overflow, noted by Stefan Monnier in
2372 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2373 Remove a FIXME that didn't need fixing.
2374 Simplify the newly-introduced buffer reallocation code.
2375
2376 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2377
2378 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2379
2380 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2381
2382 Integer and memory overflow issues (Bug#9196).
2383
2384 * doc.c (get_doc_string): Rework so that
2385 get_doc_string_buffer_size is the actual buffer size, rather than
2386 being 1 less than the actual buffer size; this makes xpalloc more
2387 convenient.
2388
2389 * image.c (x_allocate_bitmap_record, cache_image):
2390 * xselect.c (Fx_register_dnd_atom):
2391 Simplify previous changes by using xpalloc.
2392
2393 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2394 since either will do and ptrdiff_t is convenient with xpalloc.
2395
2396 * charset.c (charset_table_size)
2397 (struct charset_sort_data.priority): Now ptrdiff_t.
2398 (charset_compare): Don't overflow if priorities differ greatly.
2399 (Fsort_charsets): Don't assume list length fits in int.
2400 Check for size-calculation overflow when allocating sort data.
2401 (syms_of_charset): Allocate an initial charset table that is
2402 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2403
2404 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2405
2406 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2407 The actual value is always <= INT_MAX, and leaving it unsigned made
2408 overflow checking harder.
2409
2410 * dispextern.h (struct glyph_matrix.rows_allocated)
2411 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2412 with xpalloc. The values are still always <= INT_MAX.
2413
2414 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2415
2416 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2417 (SAFE_NALLOCA): New macro.
2418
2419 * region-cache.c (struct boundary.pos, find_cache_boundary)
2420 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2421 (set_cache_region, invalidate_region_cache)
2422 (revalidate_region_cache, know_region_cache, region_cache_forward)
2423 (region_cache_backward, pp_cache):
2424 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2425 so that ptrdiff_t * can be passed to xpalloc.
2426 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2427 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2428 (pp_cache): Don't assume cache_len fits in int.
2429 * region-cache.h: Adjust extern decls to match.
2430
2431 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2432 EMACS_INT, since either will do, for xpalloc.
2433
2434 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2435 (xnmalloc, xnrealloc, xpalloc): New functions.
2436
2437 * bidi.c (bidi_shelve_header_size): New constant.
2438 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2439 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2440
2441 * bidi.c (bidi_cache_shrink):
2442 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2443 (overlay_strings):
2444 Don't update size of array until after memory allocation succeeds,
2445 because xmalloc/xrealloc may not return.
2446 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2447 now that we have proper integer overflow checking.
2448 (record_overlay_string, overlay_strings): Catch overflows when
2449 calculating size of overlay_str_buf.
2450
2451 * callproc.c (Fcall_process): Check for size overflow when
2452 calculating size of args2.
2453 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2454 Normally we prefer signed values, but sticking with ptrdiff_t would
2455 require adding more-complicated checks.
2456
2457 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2458 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2459 Redo buffer-overflow calculations to avoid integer overflow.
2460 Add a FIXME comment where memory seems to be over-allocated.
2461
2462 * character.c (Fstring): Check for size-calculation overflow.
2463
2464 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2465 unnecessary integer overflow. Check for size overflow.
2466 (encode_coding_object): Don't update size until xmalloc succeeds.
2467
2468 * composite.c (get_composition_id): Check for overflow in glyph
2469 length calculations.
2470
2471 Integer and memory overflow fixes for display code.
2472 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2473 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2474 (scrolling_window): Check for overflow in size calculations.
2475 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2476 Don't assume glyph table len fits in int.
2477 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2478 (row_table_size): Now ptrdiff_t, not int.
2479 (scrolling_window): Avoid overflow in size calculations.
2480 Don't update size until allocation succeeds.
2481 * fns.c (concat): Check for overflow in size calculations.
2482 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2483 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2484 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2485
2486 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2487 (get_doc_string): Check for size calculation overflow.
2488 Don't update size until allocation succeeds.
2489 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2490 EMACS_INT, where ptrdiff_t will do.
2491 (Fsubstitute_command_keys): Check for string overflow.
2492
2493 * editfns.c (set_time_zone_rule): Don't assume environment length
2494 fits in int.
2495 (message_length): Now ptrdiff_t, not int.
2496 (Fmessage_box): Don't update size until allocation succeeds.
2497 Don't assume message length fits in int.
2498 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2499
2500 * emacs.c (main): Do not reallocate argv, since there is a null at
2501 the end that can be overwritten, and this way there's no need to
2502 worry about size-calculation overflow.
2503 (sort_args): Check for size-calculation overflow.
2504
2505 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2506 alloc succeeds.
2507 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2508
2509 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2510 (x_set_scroll_bar_width, x_figure_window_size):
2511 Check for integer overflow.
2512 (x_set_alpha): Do not assume XINT fits in int.
2513
2514 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2515 This is for the members text_lines, text_cols, total_lines, total_cols,
2516 where the system imposes an 'int' limit.
2517
2518 * fringe.c (Fdefine_fringe_bitmap):
2519 Don't update size until alloc works.
2520
2521 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2522 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2523
2524 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2525 Check for size-calculation overflow.
2526 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2527 do, as we prefer signed integers.
2528 (id_to_widget.max_size, id_to_widget.used)
2529 (xg_store_widget_in_map, xg_remove_widget_from_map)
2530 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2531 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2532 Use and return ptrdiff_t, not int.
2533 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2534 * gtkutil.h: Change prototypes to match the above.
2535
2536 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2537 are duplicate now that they've been promoted to lisp.h.
2538 (x_allocate_bitmap_record, x_alloc_image_color)
2539 (make_image_cache, cache_image, xpm_load):
2540 Don't update size until alloc is done.
2541 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2542 (x_detect_edges):
2543 Check for size calculation overflow.
2544 (ct_colors_allocated_max): New constant.
2545 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2546 overflow.
2547
2548 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2549 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2550 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2551 Use ptrdiff_t, not int, to count maps.
2552 (read_char_minibuf_menu_prompt): Check for overflow in size
2553 calculations. Don't update size until allocation succeeds.
2554 Redo calculations to avoid overflow.
2555 * keyboard.h: Change prototypes to match the above.
2556
2557 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2558 to count maps.
2559 (current_minor_maps): Check for size calculation overflow.
2560 * keymap.h: Change prototypes to match the above.
2561
2562 * lread.c (read1, init_obarray): Don't update size until alloc done.
2563
2564 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2565 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2566
2567 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2568 Now ptrdiff_t, not int.
2569 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2570 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2571
2572 * process.c (Fnetwork_interface_list): Check for overflow
2573 in size calculation.
2574
2575 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2576
2577 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2578 overflow. Don't bother calling xmalloc when xrealloc will do.
2579
2580 * search.c (Freplace_match): Check for size calculation overflow.
2581 (Fset_match_data): Don't assume list lengths fit in 'int'.
2582
2583 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2584 for command line length. Do not attempt to address one before the
2585 beginning of an array, as that's not portable.
2586
2587 * term.c (max_frame_lines): Remove; unused.
2588 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2589 not int.
2590 (encode_terminal_code, calculate_costs): Check for size
2591 calculation overflow.
2592 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2593 table lengths and related sizes. Don't update size until alloc
2594 done. Redo calculations to avoid overflow.
2595 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2596
2597 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2598 subtracting pointers.
2599 (gobble_line): Check for overflow more carefully. Don't update size
2600 until alloc done.
2601
2602 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2603 Don't update size until alloc done.
2604 Redo size calculations to avoid overflow.
2605 Check for size calculation overflow.
2606 (main) [DEBUG]: Fix typo in invoking tparam1.
2607
2608 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2609 Use ptrdiff_t, not int, for sizes.
2610 (store_mode_line_noprop_char): Don't update size until alloc done.
2611
2612 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2613 Use ptrdiff_t, not int, for sizes.
2614 (Finternal_make_lisp_face, cache_face):
2615 Check for size calculation overflow.
2616 (cache_face): Treat size calculation overflows as if they were
2617 memory exhaustion (the usual treatment), rather than aborting.
2618
2619 * xfns.c (x_encode_text, x_set_name_internal)
2620 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2621 sizes, since they can exceed INT_MAX in size. Check for size
2622 calculation overflow.
2623
2624 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2625 (xg_select): Check for size calculation overflow.
2626 Don't update size until alloc done.
2627
2628 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2629 as sprintf is limited to int lengths.
2630
2631 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2632 (X_LONG_MIN): New macros.
2633 Use them to make the following changes clearer.
2634 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2635 This change doesn't affect the value now, but it may help remind
2636 future maintainers not to raise the value too much later.
2637 (SELECTION_QUANTUM): Remove, replacing with ...
2638 (selection_quantum): ... new function, which avoids overflow.
2639 All uses changed.
2640 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2641 assumption that selection length fits in 'int'.
2642 (x_reply_selection_request, x_handle_selection_request)
2643 (x_get_window_property, receive_incremental_selection)
2644 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2645 (lisp_data_to_selection_data, clean_local_selection_data):
2646 Use ptrdiff_t, not int, to record length of selection.
2647 (x_reply_selection_request, x_get_window_property)
2648 (receive_incremental_selection, x_property_data_to_lisp):
2649 Redo calculations to avoid overflow.
2650 (x_reply_selection_request): When sending hint, ceiling it at
2651 X_LONG_MAX rather than relying on wraparound overflow to send
2652 something.
2653 (x_get_window_property, receive_incremental_selection)
2654 (lisp_data_to_selection_data, x_property_data_to_lisp):
2655 Check for size-calculation overflow.
2656 (x_get_window_property, receive_incremental_selection)
2657 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2658 Don't store size until memory allocation succeeds.
2659 (x_get_window_property): Plug memory leak on memory exhaustion.
2660 Don't double-block input; malloc is safe here. Don't assume 2**34
2661 - 4 fits in unsigned long. Add an xassert to check
2662 XGetWindowProperty overflow. Be more careful about overflow
2663 calculations, and distinguish size from memory overflow better.
2664 (receive_incremental_selection): When tracing, don't assume
2665 unsigned int is less than INT_MAX.
2666 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2667 harmful) conversions of unsigned short to int.
2668 (lisp_data_to_selection_data): Don't assume that integers
2669 in the range -65535 through -1 fit in an X unsigned short.
2670 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2671 result parameters unless successful. Rely on cons_to_unsigned
2672 to report problems with elements; the old code wasn't right anyway.
2673 (x_check_property_data): Check for int overflow; we cannot use
2674 a wider type due to X limits.
2675 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2676
2677 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2678
2679 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2680 (x_term_init): Check for size calculation overflow.
2681 (x_color_cells): Don't store size until memory allocation succeeds.
2682 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2683 Don't assume alloca size is less than MAX_ALLOCA.
2684 (x_term_init): Don't assume length fits in int (sprintf is limited
2685 to int size).
2686
2687 Use ptrdiff_t for composition IDs.
2688 * character.c (lisp_string_width):
2689 * composite.c (composition_table_size, n_compositions)
2690 (get_composition_id, composition_gstring_from_id):
2691 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2692 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2693 * window.c (Frecenter):
2694 Use ptrdiff_t, not int, for composition IDs.
2695 * composite.c (get_composition_id): Check for integer overflow.
2696 * composite.h: Adjust prototypes to match the above changes.
2697
2698 Use ptrdiff_t for hash table indexes.
2699 * category.c (hash_get_category_set):
2700 * ccl.c (ccl_driver):
2701 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2702 * coding.c (coding_system_charset_list, detect_coding_system):
2703 * coding.h (struct coding_system.id):
2704 * composite.c (get_composition_id, gstring_lookup_cache):
2705 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2706 * image.c (xpm_get_color_table_h):
2707 * lisp.h (hash_lookup, hash_put):
2708 * minibuf.c (Ftest_completion):
2709 Use ptrdiff_t for hash table indexes, not int (which is too
2710 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2711 32-bit --with-wide-int hosts).
2712
2713 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2714 Add a FIXME comment about memory leaks.
2715 (syms_of_charset): Don't assume xmalloc returns.
2716
2717 Don't assume that stated character widths fit in int.
2718 * character.c (Fchar_width, c_string_width, lisp_string_width):
2719 * character.h (CHAR_WIDTH):
2720 * indent.c (MULTIBYTE_BYTES_WIDTH):
2721 Use sanitize_char_width to avoid undefined and/or bad behavior
2722 with outlandish widths.
2723 * character.h (sanitize_tab_width): Rename from sanitize_width,
2724 now that we have two such functions. All uses changed.
2725 (sanitize_char_width): New inline function.
2726
2727 Don't assume that tab-width fits in int.
2728 * character.h (sanitize_width): New inline function.
2729 (SANE_TAB_WIDTH): New macro.
2730 (ASCII_CHAR_WIDTH): Use it.
2731 * indent.c (sane_tab_width): Remove. All uses replaced by
2732 SANE_TAB_WIDTH (current_buffer).
2733 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2734
2735 * fileio.c: Integer overflow issues with file modes.
2736 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2737
2738 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2739 Remove unreachable code.
2740 (read_hex, load_charset_map_from_file): Check for integer overflow.
2741
2742 * xterm.c: Don't go over XClientMessageEvent limit.
2743 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2744 (x_send_scroll_bar_event): Likewise. Check that the size does not
2745 exceed limits imposed by XClientMessageEvent, as well as the usual
2746 ptrdiff_t and size_t limits.
2747
2748 * keyboard.c: Overflow, signedness and related fixes.
2749 (make_lispy_movement): Use same integer type in forward decl
2750 that is used in the definition.
2751 (read_key_sequence, keyremap_step):
2752 Change bufsize argument back to int, undoing my 2011-03-30 change.
2753 We prefer signed types, and int is wide enough here.
2754 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2755 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2756 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2757 length, not size_t. Use ptrdiff_t for index, not int.
2758 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2759 possibility of integer overflow.
2760
2761 Overflow, signedness and related fixes for images.
2762
2763 * dispextern.h (struct it.stack[0].u.image.image_id)
2764 (struct_it.image_id, struct image.id, struct image_cache.size)
2765 (struct image_cache.used, struct image_cache.ref_count):
2766 * gtkutil.c (update_frame_tool_bar):
2767 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2768 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2769 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2770 * nsmenu.m (update_frame_tool_bar):
2771 * xdisp.c (calc_pixel_width_or_height):
2772 * xfns.c (image_cache_refcount):
2773 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2774 on typical 64-bit hosts.
2775
2776 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2777 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2778 Omit unnecessary casts to int.
2779 (parse_image_spec): Check that integers fall into 'int' range
2780 when the callers expect that.
2781 (image_ascent): Redo ascent calculation to avoid int overflow.
2782 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2783 (lookup_image): Remove unnecessary tests.
2784 (xbm_image_p): Locals are now of int, not EMACS_INT,
2785 since parse_image_check makes sure they fit into int.
2786 (png_load, gif_load, svg_load_image):
2787 Prefer int to unsigned where either will do.
2788 (tiff_handler): New function, combining the cores of the
2789 old tiff_error_handler and tiff_warning_handler.
2790 This function is rewritten to use vsnprintf and thereby avoid
2791 stack buffer overflows. It uses only the features of vsnprintf
2792 that are common to both POSIX and native Microsoft.
2793 (tiff_error_handler, tiff_warning_handler): Use it.
2794 (tiff_load, gif_load, imagemagick_load_image):
2795 Don't assume :index value fits in 'int'.
2796 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2797 (imagemagick_load_image): Check that crop parameters fit into
2798 the integer types that MagickCropImage accepts. Don't assume
2799 Vimagemagick_render_type has a nonnegative value. Don't assume
2800 size_t fits in 'long'.
2801 (gs_load): Use printmax_t to print the widest integers possible.
2802 Check for integer overflow when computing image height and width.
2803
2804 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2805
2806 * xdisp.c (redisplay_window): Don't force window start if point
2807 will be invisible in the resulting window. (Bug#9324)
2808
2809 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2810
2811 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2812 the display spec is of the form `(space ...)'.
2813 (handle_display_spec): Return the value returned by
2814 handle_single_display_spec, not just 1 or zero.
2815 (handle_single_display_spec): If the display spec is of the form
2816 `(space ...)', and specifies display in the text area, return 2
2817 rather than 1.
2818 (try_cursor_movement): Check for the need to scroll more
2819 accurately, and prefer exact match for point under bidi.
2820 Don't advance `row' beyond the last row of the window.
2821
2822 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2823 into disp_prop; all users changed.
2824
2825 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2826 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2827 for the text covered by the display property.
2828
2829 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2830
2831 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2832 Change return value to nil.
2833 (Frecord_buffer): Delete unused function.
2834
2835 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2836
2837 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2838 buffers, return left-to-right.
2839 (set_cursor_from_row): Consider candidate row a win if its glyph
2840 represents a newline and point is on that newline. Fixes cursor
2841 positioning on the newline at EOL of R2L text within L2R
2842 paragraph, and vice versa.
2843 (try_cursor_movement): Check continued rows, in addition to
2844 continuation rows. Fixes unwarranted scroll when point enters a
2845 continued line of R2L text within an L2R paragraph, or vice versa.
2846 (cursor_row_p): Consider the case of point being equal to
2847 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2848 from the end of a short line to the beginning of a continued line
2849 of R2L text within L2R paragraph.
2850 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2851 composed characters.
2852
2853 * bidi.c (bidi_check_type): Use xassert.
2854 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2855 members.
2856
2857 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2858
2859 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2860 a character.
2861
2862 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2863
2864 * nsfont.m (ns_otf_to_script): Fix typo.
2865
2866 2011-08-22 Kenichi Handa <handa@m17n.org>
2867
2868 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2869 extra slot even if the purpose is char-code-property-table.
2870
2871 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2872
2873 * xdisp.c (redisplay_window): When computing centering_position,
2874 account for the height of the header line. (Bug#8874)
2875
2876 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2877 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2878 candidate is selected by the mouse, and that candidate has a
2879 composed character under the mouse.
2880
2881 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2882 coordinates reported by pos-visible-in-window-p for a composed
2883 character in column zero.
2884
2885 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2886
2887 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2888
2889 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2890
2891 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2892 consider it a hit if to_charpos is anywhere in the range of the
2893 composed buffer positions.
2894
2895 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2896
2897 * image.c (gif_load): Don't assume that each subimage has the same
2898 dimensions as the base image. Handle disposal method that is
2899 "undefined" by the gif spec (Bug#9335).
2900
2901 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2902
2903 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2904 (Fcondition_case): Document `debug' symbol in error handler.
2905
2906 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2907
2908 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2909 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2910 from an Org mode buffer to a Speedbar frame.
2911
2912 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2913 a composition, take its buffer position from IT->cmp_it.charpos.
2914 Fixes cursor positioning at the beginning of a line that begins
2915 with a composed character.
2916
2917 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2918
2919 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2920 character bidirectional type, use STRONG_L instead. Fixes crashes
2921 in a buffer produced by `describe-categories'.
2922
2923 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2924 members before the level stack, so they would be saved and
2925 restored when copying iterator state. Fixes incorrect reordering
2926 around TABs covered by display properties.
2927
2928 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2929
2930 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2931
2932 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2933
2934 * eval.c (internal_condition_case, internal_condition_case_1)
2935 (internal_condition_case_2, internal_condition_case_n):
2936 Remove unnecessary aborts (Bug#9081).
2937
2938 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2939
2940 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2941 has no `load' handler, try opening the file locally. (Bug#9311)
2942
2943 2011-08-16 Ken Brown <kbrown@cornell.edu>
2944
2945 * gmalloc.c: Expand comment.
2946
2947 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2948
2949 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2950 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2951
2952 2011-08-16 Ken Brown <kbrown@cornell.edu>
2953
2954 Fix memory allocation problems in Cygwin build (Bug#9273).
2955
2956 * unexcw.c ( __malloc_initialized): Declare external variable.
2957 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2958
2959 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2960 New variables.
2961 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2962 dumped emacs.
2963 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2964 in the static heap.
2965 [CYGWIN] (special_realloc): New function.
2966 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2967 requests to realloc storage in the static heap.
2968
2969 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2970
2971 * bidi.c (bidi_initialize): Remove unused local.
2972
2973 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2974
2975 * bidimirror.h:
2976 * biditype.h: Remove file.
2977 * makefile.w32-in ($(BLD)/bidi.$(O)):
2978 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2979
2980 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2981
2982 * chartab.c: Improve commentary for the uniprop_table API.
2983
2984 * bidi.c (bidi_paragraph_init): Support zero value of
2985 bidi_ignore_explicit_marks_for_paragraph_level.
2986 (bidi_initialize): Use uniprop_table instead of including
2987 biditype.h and bidimirror.h.
2988
2989 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2990 coordinates of the iterator when restoring from ppos_it.
2991 (Bug#9296)
2992
2993 2011-08-14 Kenichi Handa <handa@m17n.org>
2994
2995 * process.c (create_process): Call setup_process_coding_systems
2996 after the pid of the process is set to -1 (Bug#8162).
2997
2998 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2999
3000 * xdisp.c (move_it_in_display_line_to): Don't invoke
3001 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3002 ppos_it. Fixes vertical cursor motion when line beginning is
3003 covered by an image. (Bug#9296)
3004
3005 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3006
3007 * nsterm.h (ns_run_ascript): Declare.
3008 (NSAPP_DATA2_RUNASSCRIPT): Define.
3009
3010 * nsfns.m (as_script, as_result, as_status): New static variables.
3011 (ns_run_ascript): New function.
3012 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3013 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3014 the event loop. Get status from as_status (Bug#7276).
3015
3016 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3017 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3018 the event loop (Bug#7276).
3019
3020 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3021
3022 * gnutls.c (QCgnutls_bootprop_priority)
3023 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3024 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3025 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3026 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3027 (QCgnutls_bootprop_verify_hostname_error)
3028 (QCgnutls_bootprop_callbacks_verify): Rename from
3029 Qgnutls_bootprop_..., all uses changed.
3030
3031 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3032 uses changed.
3033
3034 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3035
3036 * xfaces.c (Qframe_set_background_mode): Now static.
3037 * dispextern.h (Qframe_set_background_mode): Remove decl.
3038
3039 * process.c (Fnetwork_interface_info): Declare local only if needed.
3040
3041 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3042
3043 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3044 (Fnetwork_interface_list): Allocate in increments of bytes instead
3045 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3046 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3047 sockaddr.
3048 (struct ifflag_def): notrailers is smart on OSX.
3049 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3050 Get hardware address with getifaddrs if available.
3051
3052 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3053
3054 * xdisp.c (iterate_out_of_display_property): xassert that
3055 IT->position is set to within IT->object's boundaries. Break from
3056 the loop as soon as EOB is reached; avoids infloops in redisplay
3057 when IT->position is set up wrongly due to some bug.
3058 Set IT->current to match the bidi iterator unconditionally.
3059 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3060 entry. Force push_it to save on the stack the current
3061 buffer/string position, to be restored by pop_it. Fix flags in
3062 the iterator structure wrt the object coming from a display
3063 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3064 properties. (Bug#9284)
3065
3066 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3067
3068 * fontset.c (fontset_get_font_group): Add proper type checks.
3069 (Bug#9172)
3070
3071 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3072
3073 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3074 and LC_VERSION_MIN_MACOSX.
3075 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3076 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3077
3078 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3079
3080 * xdisp.c (forward_to_next_line_start): Allow to use the
3081 no-display-properties-and-no-overlays under bidi display.
3082 Set disp_pos in the bidi iterator to avoid searches for display
3083 properties and overlays.
3084
3085 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3086
3087 * editfns.c (Fset_time_zone_rule): Document relationship with the
3088 setenv function.
3089
3090 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3091 the font entity extracted from the cache (Bug#8109).
3092
3093 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3094
3095 * composite.c (autocmp_chars): Don't reset point. That is done by
3096 restore_point_unwind (Bug#5984).
3097
3098 2011-08-07 Juri Linkov <juri@jurta.org>
3099
3100 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3101 to show the arg `TIME' instead of `TIMEVAL'.
3102
3103 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3104
3105 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3106 display property strides EOL and includes a newline, as in
3107 longlines-mode. (Bug#9254)
3108 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3109 word-wrap under bidirectional display. (Bug#9224)
3110
3111 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3112 is non-zero, even if the data buffer is NULL. Fixes a crash in
3113 vertical-motion with longlines-mode. (Bug#9254)
3114
3115 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3116
3117 * bidi.c <bidi_cache_total_alloc>: Now static.
3118 (bidi_initialize): Initialize bidi_cache_total_alloc.
3119
3120 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3121 cache. (Bug#9221)
3122
3123 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3124 amount allocated this far in `bidi_cache_total_alloc'.
3125 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3126 non-zero, only free the data buffer without restoring the cache
3127 contents. All callers changed.
3128
3129 * dispextern.h (bidi_unshelve_cache): Update prototype.
3130
3131 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3132 (move_it_in_display_line, move_it_to)
3133 (move_it_vertically_backward, move_it_by_lines): Replace the call
3134 to xfree to an equivalent call to bidi_unshelve_cache.
3135 (move_it_in_display_line_to): Fix logic of returning
3136 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3137
3138 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3139
3140 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3141 came from a string character with a `cursor' property. (Bug#9229)
3142
3143 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3144
3145 * Makefile.in (LIB_PTHREAD): New variable.
3146 (LIBES): Add LIB_PTHREAD (Bug#9216).
3147
3148 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3149 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3150
3151 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3152
3153 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3154
3155 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3156
3157 * xterm.c (x_find_topmost_parent): New function.
3158 (x_set_frame_alpha): Find topmost parent window with
3159 x_find_topmost_parent and set the property there also (bug#9181).
3160 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3161
3162 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3163
3164 * callproc.c (Fcall_process): Avoid vfork clobbering
3165 the local vars buffer, coding_systems, current_dir.
3166
3167 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3168
3169 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3170
3171 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3172
3173 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3174 so that it is not optimized away.
3175
3176 * xdisp.c (compute_display_string_pos): Remove unused local.
3177
3178 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3179
3180 Fix slow cursor motion and scrolling in large buffers with
3181 selective display, like Org Mode buffers. (Bug#9218)
3182
3183 * dispextern.h (struct bidi_it): New member disp_prop_p.
3184
3185 * xdisp.c: Remove one-slot cache of display string positions.
3186 (compute_display_string_pos): Accept an additional argument
3187 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3188 for a display string or property. If found, set DISP_PROP_P
3189 non-zero.
3190
3191 * bidi.c (bidi_fetch_char): Accept an additional argument
3192 DISP_PROP_P, and pass it to compute_display_string_pos.
3193 Only handle text covered by a display string if DISP_PROP_P is returned
3194 non-zero. All callers of bidi_fetch_char changed.
3195
3196 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3197
3198 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3199
3200 2010-12-03 Don March <don@ohspite.net>
3201
3202 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3203 last character M-[char] is translated to ESC [char] (bug#7541).
3204
3205 2011-08-02 Kenichi Handa <handa@m17n.org>
3206
3207 * lisp.h (uniprop_table): Extern it.
3208
3209 * chartab.c (uniprop_table): Make it non-static.
3210
3211 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3212
3213 * xdisp.c (forward_to_next_line_start): Accept additional argument
3214 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3215 on the newline.
3216 (reseat_at_next_visible_line_start): Use the bidi iterator state
3217 returned by forward_to_next_line_start to restore the state of
3218 it->bidi_it after backing up to previous newline. (Bug#9212)
3219
3220 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3221
3222 * regex.c (re_comp): Protoize.
3223 (re_exec): Fix return type.
3224 (regexec): Fix type of `ret'. (Bug#9203)
3225
3226 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3227
3228 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3229 This is needed if max-image-size is a floating-point number.
3230
3231 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3232
3233 * print.c (print_object): Print empty symbol as ##.
3234
3235 * lread.c (read1): Read ## as empty symbol.
3236
3237 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3238
3239 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3240 setting frame foreground color (Bug#9175).
3241 (x_set_background_color): Likewise.
3242
3243 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3244 contents (Bug#9176).
3245 (EmacsTooltip -init): Remove bezels and add shadows to
3246 tooltip windows.
3247
3248 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3249 or scroll bar (Bug#8470).
3250
3251 * nsfont.m (nsfont_open): Remove assignment to voffset and
3252 unnecessary vars hshink, expand, hd, full_height, min_height.
3253 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3254
3255 * nsterm.h (nsfont_info): Remove voffset field.
3256
3257 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3258
3259 Implement strike-through and overline on NextStep (Bug#8863).
3260
3261 * nsfont.m (nsfont_open): Use underline position provided by font,
3262 instead of hard-coded value of 2.
3263 (nsfont_draw): Call ns_draw_text_decoration instead.
3264
3265 * nsterm.h: Add declaration for ns_draw_text_decoration.
3266
3267 * nsterm.m (ns_draw_text_decoration): New function for drawing
3268 underline, overline, and strike-through.
3269 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3270 ns_draw_text_decoration. Change treatment of cursor drawing to
3271 accommodate underlining, etc.
3272
3273 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3274
3275 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3276 default.
3277
3278 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3279
3280 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3281 Without this fix, if a signal arrives just after memory fills up,
3282 'malloc' might be invoked reentrantly.
3283
3284 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3285 In other words, assume that every image size is allowed, on non-X
3286 hosts. This assumption is probably wrong, but it lets Emacs compile.
3287
3288 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3289
3290 * regex.c (re_iswctype): Convert return values to boolean.
3291
3292 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3293
3294 * xdisp.c (compute_display_string_pos): Don't use cached display
3295 string position if the buffer had its restriction changed.
3296 (Bug#9184)
3297
3298 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3299
3300 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3301
3302 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3303
3304 Integer signedness and overflow and related fixes. (Bug#9079)
3305
3306 * bidi.c: Integer size and overflow fixes.
3307 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3308 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3309 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3310 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3311 (bidi_find_other_level_edge):
3312 Use ptrdiff_t instead of EMACS_INT where either will do.
3313 This works better on 32-bit hosts configured --with-wide-int.
3314 (bidi_cache_ensure_space): Check for size-calculation overflow.
3315 Use % rather than repeated addition, for better worst-case speed.
3316 Don't set bidi_cache_size until after xrealloc returns, because it
3317 might not return.
3318 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3319 (bidi_cache_ensure_space): Also check that the bidi cache size
3320 does not exceed that of the largest Lisp string or buffer. See Eli
3321 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3322
3323 * alloc.c (__malloc_size_t): Remove.
3324 All uses replaced by size_t. See Andreas Schwab's note
3325 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3326
3327 * image.c: Improve checking for integer overflow.
3328 (check_image_size): Assume that f is nonnull, since
3329 it is always nonnull in practice. This is one less thing to
3330 worry about when checking for integer overflow later.
3331 (x_check_image_size): New function, which checks for integer
3332 overflow issues inside X.
3333 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3334 This removes the need for a memory_full check.
3335 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3336 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3337 (xbm_read_bitmap_data): Change locals back to 'int', since
3338 their values must fit in 'int'.
3339 (xpm_load_image, png_load, tiff_load):
3340 Invoke x_create_x_image_and_pixmap earlier,
3341 to avoid much needless work if the image is too large.
3342 (tiff_load): Treat overly large images as if
3343 x_create_x_image_and_pixmap failed, not as malloc failures.
3344 (gs_load): Use x_check_image_size.
3345
3346 * gtkutil.c: Omit integer casts.
3347 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3348 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3349
3350 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3351
3352 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3353 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3354 would wrongly return t on a 64-bit host.
3355
3356 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3357 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3358 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3359 and therefore cause GCC to emit a bogus diagnostic in some cases.
3360
3361 * image.c: Integer signedness and overflow and related fixes.
3362 This is not an exhaustive set of fixes, but it's time to
3363 record what I've got.
3364 (lookup_pixel_color, check_image_size): Remove redundant decls.
3365 (check_image_size): Don't assume that arbitrary EMACS_INT values
3366 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3367 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3368 (tiff_load, imagemagick_load_image):
3369 Check for overflow in size calculations.
3370 (x_create_x_image_and_pixmap): Remove unnecessary test for
3371 xmalloc returning NULL; that can't happen.
3372 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3373 (xpm_color_bucket): Use better integer hashing function.
3374 (xpm_cache_color): Don't possibly over-allocate memory.
3375 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3376 (gif_memory_source):
3377 Use ptrdiff_t, not int or size_t, to record sizes.
3378 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3379 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3380 either works, as we prefer signed integers.
3381 (tiff_read_from_memory, tiff_write_from_memory):
3382 Return tsize_t, not size_t, since that's what the TIFF API wants.
3383 (tiff_read_from_memory): Don't fail simply because the read would
3384 go past EOF; instead, return a short read.
3385 (tiff_load): Omit no-longer-needed casts.
3386 (Fimagemagick_types): Don't assume size fits into 'int'.
3387
3388 Improve hashing quality when configured --with-wide-int.
3389 * fns.c (hash_string): New function, taken from sxhash_string.
3390 Do not discard information about ASCII character case; this
3391 discarding is no longer needed.
3392 (sxhash-string): Use it. Change sig to match it. Caller changed.
3393 * lisp.h: Declare it.
3394 * lread.c (hash_string): Remove, since we now use fns.c's version.
3395 The fns.c version returns a wider integer if --with-wide-int is
3396 specified, so this should help the quality of the hashing a bit.
3397
3398 * emacs.c: Integer overflow minor fix.
3399 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3400 Define only if GNU_LINUX.
3401 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3402
3403 * dispnew.c: Integer signedness and overflow fixes.
3404 Remove unnecessary forward decls, that were a maintenance hassle.
3405 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3406 All uses changed.
3407 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3408 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3409 (prepare_desired_row, line_draw_cost):
3410 Use int, not unsigned, where either works.
3411 (save_current_matrix, restore_current_matrix):
3412 Use ptrdiff_t, not size_t, where either works.
3413 (init_display): Check for overflow more accurately, and without
3414 relying on undefined behavior.
3415
3416 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3417 Remove, replacing with the new symbols in lisp.h. All uses changed.
3418 * fileio.c (make_temp_name):
3419 * filelock.c (lock_file_1, lock_file):
3420 * xdisp.c (message_dolog):
3421 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3422 Use pMd etc. instead.
3423 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3424 replacing the pWIDE etc. symbols removed from editfns.c.
3425
3426 * keyboard.h (num_input_events): Now uintmax_t.
3427 This is (very slightly) less likely to mess up due to wraparound.
3428 All uses changed.
3429
3430 * buffer.c: Integer signedness fixes.
3431 (alloc_buffer_text, enlarge_buffer_text):
3432 Use ptrdiff_t rather than size_t when either will do, as we prefer
3433 signed integers.
3434
3435 * alloc.c: Integer signedness and overflow fixes.
3436 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3437 (__malloc_size_t): Default to size_t, not to int.
3438 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3439 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3440 Prefer ptrdiff_t to size_t when either would do, as we prefer
3441 signed integers.
3442 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3443 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3444 Now const. Initialize with values that are in range even if char
3445 is signed.
3446 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3447 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3448 These functions do the right thing with sizes > 2**32.
3449 (check_depth): Now ptrdiff_t, not int.
3450 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3451 Adjust to new way of storing sizes. Check for size overflow bugs
3452 in rest of code.
3453 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3454 slightly wrong anyway, as it missed one instance of
3455 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3456 (refill_memory_reserve): Omit needless cast to size_t.
3457 (mark_object_loop_halt): Mark as externally visible.
3458
3459 * xselect.c: Integer signedness and overflow fixes.
3460 (Fx_register_dnd_atom, x_handle_dnd_message):
3461 Use ptrdiff_t, not size_t, since we prefer signed.
3462 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3463 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3464 x_dnd_atoms_size and x_dnd_atoms_length.
3465
3466 * doprnt.c: Prefer signed to unsigned when either works.
3467 * eval.c (verror):
3468 * doprnt.c (doprnt):
3469 * lisp.h (doprnt):
3470 * xdisp.c (vmessage):
3471 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3472 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3473 prefer signed arithmetic to avoid comparison confusion.
3474 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3475 but is a bit tricky.
3476
3477 Assume freestanding C89 headers, string.h, stdlib.h.
3478 * data.c, doprnt.c, floatfns.c, print.c:
3479 Include float.h unconditionally.
3480 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3481 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3482 * regex.c: Likewise for stddef.h, string.h.
3483 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3484 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3485 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3486 (STDC_HEADERS): Remove obsolete defines.
3487 * sysdep.c: Include limits.h unconditionally.
3488
3489 Assume support for memcmp, memcpy, memmove, memset.
3490 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3491 * regex.c (memcmp, memcpy):
3492 Remove; we assume C89 now.
3493
3494 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3495 (__malloc_safe_bcopy): Remove; no longer needed.
3496
3497 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3498 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3499 well either way, and we prefer signed to unsigned.
3500
3501 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3502
3503 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3504 closes the connection while we're reading (bug#9182).
3505
3506 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3507
3508 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3509 are specified (Bug#9168).
3510
3511 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3512
3513 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3514 Found by GCC static checking and --with-wide-int on a 32-bit host.
3515
3516 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3517
3518 * xdisp.c (compute_display_string_pos): Fix logic of caching
3519 previous display string position. Initialize cached_prev_pos to
3520 -1. Fixes slow-down at the beginning of a buffer.
3521
3522 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3523
3524 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3525 for attrs[LFACE_FONTSET_INDEX].
3526
3527 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3528
3529 * xml.c (parse_region): Remove unused local
3530 that was recently introduced.
3531
3532 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3533
3534 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3535 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3536
3537 * xdisp.c (move_it_in_display_line_to): Record the best matching
3538 position for TO_CHARPOS while scanning the line, and restore it on
3539 exit if none of the characters scanned was an exact match.
3540 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3541 when exact match is impossible due to invisible text, and the
3542 lines are truncated.
3543
3544 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3545
3546 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3547 for OSX >= 10.7.
3548
3549 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3550
3551 Fix a significant slow-down of cursor motion with C-n, C-p,
3552 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3553 auto-repeat under bidi redisplay in fontified buffers.
3554 * xdisp.c (compute_stop_pos_backwards): New function.
3555 (next_element_from_buffer): Call compute_stop_pos_backwards to
3556 find a suitable prev_stop when we find ourselves before
3557 base_level_stop.
3558 (reseat): Don't look for prev_stop, as that could mean a very long
3559 run.
3560 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3561 <cached_disp_overlay_modiff>: Cache for last found display string
3562 position.
3563 (compute_display_string_pos): Return the cached position if asked
3564 about the same buffer in the same area of character positions, and
3565 the buffer wasn't changed since the time the display string
3566 position was cached.
3567
3568 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3569
3570 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3571 is an integer, which is important for empty lines. (Bug#9149)
3572
3573 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3574
3575 * frame.c (Fmodify_frame_parameters): In tty case, update the
3576 default face if necessary (Bug#4238).
3577
3578 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3579
3580 * editfns.c (Fstring_to_char): No need to explain what a character
3581 is in the docstring (Bug#6576).
3582
3583 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3584
3585 * xml.c (parse_region): Make sure we always return a tree.
3586
3587 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3588
3589 * xml.c (parse_region): If a document contains only comments,
3590 return that, too.
3591
3592 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3593
3594 * xml.c (make_dom): Return comments, too.
3595
3596 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3597
3598 Port to OpenBSD.
3599 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3600 and the surrounding thread.
3601 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3602 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3603 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3604 timer goes off.
3605 * s/openbsd.h (BROKEN_SIGIO): Define.
3606 * unexelf.c (unexec) [__OpenBSD__]:
3607 Don't update the .mdebug section of the Alpha COFF symbol table.
3608
3609 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3610
3611 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3612 (bug#8460).
3613
3614 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3615
3616 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3617 This fixes some race conditions on the permissions of any newly
3618 created file.
3619
3620 * alloc.c (valid_pointer_p): Use pipe, not open.
3621 This fixes some permissions issues when debugging.
3622
3623 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3624 If fchown fails to set both uid and gid, try to set just gid,
3625 as that is sometimes allowed. Adjust the file's mode to eliminate
3626 setuid or setgid bits that are inappropriate if fchown fails.
3627
3628 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3629
3630 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3631 to compare Lisp_Objects.
3632 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3633 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3634 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3635
3636 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3637
3638 * lread.c (read_integer): Unread even EOF character.
3639 (read1): Likewise. Properly record start position of symbol.
3640
3641 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3642 symbol character follows.
3643
3644 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3645
3646 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3647 This works around a problem with the previous change to Fcopy_file.
3648 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3649 and without this change, GCC might complain about discarding
3650 fchown's return value.
3651
3652 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3653
3654 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3655
3656 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3657
3658 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3659
3660 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3661
3662 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3663 it's used from the C level.
3664
3665 * process.c: Use the same condition for POLL_FOR_INPUT in both
3666 keyboard.c and process.c (bug#1858).
3667
3668 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3669
3670 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3671 (Fgnutls_boot): Use it.
3672
3673 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3674
3675 * doc.c (Fsubstitute_command_keys): Revert last change.
3676
3677 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3678
3679 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3680 quotes the next character, and doesn't affect other longer
3681 sequences (bug#8935).
3682
3683 * lread.c (syms_of_lread): Clarify that is isn't only
3684 `eval-buffer' and `eval-defun' that's affected by
3685 `lexical-binding' (bug#8460).
3686
3687 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3688
3689 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3690 bidi redisplay when a line includes both an image and is truncated.
3691
3692 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3693
3694 Fix minor problems found by static checking.
3695 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3696 (elsz): Now a signed constant, not a size_t var. We prefer signed
3697 types to unsigned, to avoid integer comparison confusion. Without
3698 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3699 "cannot optimize loop, the loop counter may overflow", a symptom
3700 of the confusion.
3701 * indent.c (Fvertical_motion): Mark locals as initialized.
3702 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3703
3704 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3705
3706 * search.c (Fre_search_backward): Mention `case-fold-search' in
3707 all the re_search_* functions (bug#8138).
3708
3709 * keyboard.c (Fopen_dribble_file): Document when the file is
3710 closed (bug#8056).
3711
3712 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3713
3714 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3715 bidi_cache_idx.
3716
3717 Support bidi reordering of display and overlay strings.
3718 * xdisp.c (compute_display_string_pos)
3719 (compute_display_string_end): Accept additional argument STRING.
3720 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3721 (reseat_to_string): Initialize bidi_it->string.s and
3722 bidi_it->string.schars.
3723 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3724 NULL (avoids a crash in bidi_paragraph_init).
3725 Initialize itb.string.lstring.
3726 (init_iterator): Call bidi_init_it only of a valid
3727 buffer position was specified. Initialize paragraph_embedding to
3728 L2R.
3729 (reseat_to_string): Initialize the bidi iterator.
3730 (display_string): If we need to ignore text properties of
3731 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3732 original value of -1 will not work with bidi.)
3733 (compute_display_string_pos): First arg is now struct
3734 `text_pos *'; all callers changed. Support display properties on
3735 Lisp strings.
3736 (compute_display_string_end): Support display properties on Lisp
3737 strings.
3738 (init_iterator, reseat_1, reseat_to_string): Initialize the
3739 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3740 when iterating on a string not from display properties).
3741 (compute_display_string_pos, compute_display_string_end):
3742 Fix calculation of the object to scan. Fixes an error when using
3743 arrow keys.
3744 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3745 base_level_stop; instead, set base_level_stop to BEGV.
3746 Fixes crashes in vertical-motion.
3747 (next_element_from_buffer): Improve commentary for when
3748 the iterator is before prev_stop.
3749 (init_iterator): Initialize bidi_p from the default value of
3750 bidi-display-reordering, not from buffer-local value. Use the
3751 buffer-local value only if initializing for buffer iteration.
3752 (handle_invisible_prop): Support invisible properties on strings
3753 that are being bidi-reordered.
3754 (set_iterator_to_next): Support bidi reordering of C strings and
3755 Lisp strings.
3756 (next_element_from_string): Support bidi reordering of Lisp
3757 strings.
3758 (handle_stop_backwards): Support Lisp strings as well.
3759 (display_string): Support display of R2L glyph rows.
3760 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3761 (init_iterator): Don't initialize it->bidi_p for strings
3762 here.
3763 (reseat_to_string): Initialize it->bidi_p for strings here.
3764 (next_element_from_string, next_element_from_c_string)
3765 (next_element_from_buffer): Add xassert's for correspondence
3766 between IT's object being iterated and it->bidi_it.string
3767 structure.
3768 (face_before_or_after_it_pos): Support bidi iteration.
3769 (next_element_from_c_string): Handle the case of the first string
3770 character that is not the first one in the visual order.
3771 (get_visually_first_element): New function, refactored from common
3772 parts of next_element_from_buffer, next_element_from_string, and
3773 next_element_from_c_string.
3774 (tool_bar_lines_needed, redisplay_tool_bar)
3775 (display_menu_bar): Force left-to-right direction. Add a FIXME
3776 comment for making that be controlled by a user option.
3777 (push_it, pop_it): Save and restore the state of the
3778 bidi iterator. Save and restore the bidi_p flag.
3779 (pop_it): Iterate out of display property for string iteration as
3780 well.
3781 (iterate_out_of_display_property): Support iteration over strings.
3782 (handle_single_display_spec): Set up it->bidi_it for iteration
3783 over a display string, and call bidi_init_it.
3784 (handle_single_display_spec, next_overlay_string)
3785 (get_overlay_strings_1, push_display_prop): Set up the bidi
3786 iterator for displaying display or overlay strings.
3787 (forward_to_next_line_start): Don't use the shortcut if
3788 bidi-iterating.
3789 (back_to_previous_visible_line_start): If handle_display_prop
3790 pushed the iterator stack, restore the internal state of the bidi
3791 iterator by calling bidi_pop_it same number of times.
3792 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3793 and we are bidi-iterating, don't decrement the iterator position;
3794 instead, set the first_elt flag in the bidi iterator, to produce
3795 the same effect.
3796 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3797 (push_display_prop): xassert that we are iterating a buffer.
3798 (push_it, pop_it): Save and restore paragraph_embedding member.
3799 (handle_single_display_spec, next_overlay_string)
3800 (get_overlay_strings_1, reseat_1, reseat_to_string)
3801 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3802 correctly. Don't assume unibyte strings are not bidi-reordered.
3803 (compute_display_string_pos)
3804 (compute_display_string_end): Fix handling the case of C string.
3805 (push_it, pop_it): Save and restore from_disp_prop_p.
3806 (handle_single_display_spec, push_display_prop): Set the
3807 from_disp_prop_p flag.
3808 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3809 (pop_it): Call iterate_out_of_display_property only if we are
3810 popping after iteration over a string that came from a display
3811 property. Fix a typo in popping stretch info. Add an assertion
3812 for verifying that the iterator position is in sync with the bidi
3813 iterator.
3814 (handle_single_display_spec, get_overlay_strings_1)
3815 (push_display_prop): Fix initialization of paragraph direction for
3816 string when that of the parent object is not yet determined.
3817 (reseat_1): Call bidi_init_it to resync the bidi
3818 iterator with IT's position. (Bug#7616)
3819 (find_row_edges): If ROW->start.pos gives position
3820 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3821 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3822 Reset the from_disp_prop_p flag.
3823 (SAVE_IT, RESTORE_IT): New macros.
3824 (pos_visible_p, face_before_or_after_it_pos)
3825 (back_to_previous_visible_line_start)
3826 (move_it_in_display_line_to, move_it_in_display_line)
3827 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3828 (try_scrolling, redisplay_window, display_line): Use them when
3829 saving a temporary copy of the iterator and restoring it back.
3830 (back_to_previous_visible_line_start, reseat_1)
3831 (init_iterator): Empty the bidi cache "stack".
3832 (move_it_in_display_line_to): If iterator ended up at
3833 EOL, but we never saw any buffer positions smaller than
3834 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3835 motion in bidi-reordered lines.
3836 (move_it_in_display_line_to): Record prev_method and prev_pos
3837 immediately before the call to set_iterator_to_next. Fixes cursor
3838 motion in bidi-reordered lines with stretch glyphs and strings
3839 displayed in margins. (Bug#8133) (Bug#8867)
3840 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3841 TO_CHARPOS.
3842 (pos_visible_p): Support positions in bidi-reordered lines.
3843 Save and restore bidi cache.
3844
3845 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3846 (bidi_paragraph_info): Delete unused struct.
3847 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3848 (bidi_cache_start): New variable.
3849 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3850 to zero.
3851 (bidi_cache_fetch_state, bidi_cache_search)
3852 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3853 (bidi_cache_find, bidi_peek_at_next_level)
3854 (bidi_level_of_next_char, bidi_find_other_level_edge)
3855 (bidi_move_to_visually_next): Compare cache index with
3856 bidi_cache_start rather than with zero.
3857 (bidi_fetch_char): Accept new argument STRING; all callers
3858 changed. Support iteration over a string. Support strings with
3859 display properties. Support unibyte strings. Fix the type of
3860 `len' according to what STRING_CHAR_AND_LENGTH expects.
3861 (bidi_paragraph_init, bidi_resolve_explicit_1)
3862 (bidi_resolve_explicit, bidi_resolve_weak)
3863 (bidi_level_of_next_char, bidi_move_to_visually_next):
3864 Support iteration over a string.
3865 (bidi_set_sor_type, bidi_resolve_explicit_1)
3866 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3867 can now be zero (for strings); special values 0 and -1 were
3868 changed to -1 and -2, respectively.
3869 (bidi_char_at_pos): New function.
3870 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3871 Call it instead of FETCH_MULTIBYTE_CHAR.
3872 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3873 initialized to valid values.
3874 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3875 values.
3876 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3877 the test for valid cached positions. Fix the logic for looking up
3878 the sentinel state in the cache. GCPRO the Lisp string we are
3879 iterating.
3880 (bidi_push_it, bidi_pop_it): New functions.
3881 (bidi_initialize): Initialize the bidi cache start stack pointer.
3882 (bidi_cache_ensure_space): New function, refactored from part of
3883 bidi_cache_iterator_state. Don't assume the required size is just
3884 one BIDI_CACHE_CHUNK away.
3885 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3886 (bidi_count_bytes, bidi_char_at_pos): New functions.
3887 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3888 always valid if bidi_cache_idx is valid.
3889 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3890 is valid if it's going to be used.
3891 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3892 (bidi_cache_fetch_state, bidi_cache_search)
3893 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3894 (bidi_cache_iterator_state, bidi_cache_find)
3895 (bidi_find_other_level_edge, bidi_cache_start_stack):
3896 All variables related to cache indices are now EMACS_INT.
3897
3898 * dispextern.h (struct bidi_string_data): New structure.
3899 (struct bidi_it): New member `string'. Make flag members be 1-bit
3900 fields, and put them last in the struct.
3901 (compute_display_string_pos, compute_display_string_end):
3902 Update prototypes.
3903 (bidi_push_it, bidi_pop_it): Add prototypes.
3904 (struct iterator_stack_entry): New members bidi_p,
3905 paragraph_embedding, and from_disp_prop_p.
3906 (struct it): Member bidi_p is now a bit field 1 bit wide.
3907 (bidi_shelve_cache, bidi_unshelve_cache):
3908 Declare prototypes.
3909
3910 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3911 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3912 and vector-like objects.
3913
3914 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3915 cache around display iteration.
3916
3917 * window.c (Fwindow_end, window_scroll_pixel_based)
3918 (displayed_window_lines, Frecenter): Save and restore the bidi
3919 cache around display iteration.
3920
3921 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3922
3923 * editfns.c (Fdelete_region): Clarify the use of the named
3924 parameters (bug#6788).
3925
3926 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3927
3928 * indent.c (Fvertical_motion): Set and restore w->pointm when
3929 saving and restoring the window's buffer (Bug#9006).
3930
3931 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3932
3933 * editfns.c (Fstring_to_char): Clarify just what is returned
3934 (bug#6576). Text by Eli Zaretskii.
3935
3936 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3937
3938 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3939
3940 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3941
3942 * buffer.c (mmap_find): Fix a typo.
3943
3944 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3945
3946 Fix execution of x selection hooks.
3947 * xselect.c (Qx_lost_selection_functions)
3948 (Qx_sent_selection_functions): New vars.
3949 (syms_of_xselect): DEFSYM them.
3950 (x_handle_selection_request): Pass Qx_sent_selection_functions
3951 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3952 (x_handle_selection_clear,x_clear_frame_selections):
3953 Pass Qx_lost_selection_functions rather than
3954 Vx_lost_selection_functions to Frun_hook_with_args.
3955
3956 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3957
3958 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3959 The old code sometimes used this field without initializing it.
3960
3961 * alloc.c (gc_sweep): Don't read past end of array.
3962 In theory, the old code could also have corrupted Emacs internals,
3963 though it'd be very unlikely.
3964
3965 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3966
3967 * character.c (Fcharacterp): Don't advertise optional ignored
3968 argument. (Bug#4026)
3969
3970 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3971
3972 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3973 key" (bug#4257).
3974
3975 * window.c (Fset_window_start): Doc fix (bug#4199).
3976 (Fset_window_hscroll): Ditto.
3977
3978 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3979
3980 Fix minor new problems caught by GCC 4.6.1.
3981 * term.c (init_tty): Remove unused local.
3982 * xsettings.c (store_monospaced_changed): Define this function only
3983 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3984 not used otherwise.
3985
3986 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3987
3988 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3989
3990 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3991
3992 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3993 are the mini-buffer and the echo area (bug#3320).
3994
3995 * term.c (init_tty): Remove support for supdup, c10 and perq
3996 terminals, which are no longer supported (bug#1482).
3997
3998 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3999
4000 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4001
4002 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4003
4004 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4005 for non-popups (Bug#3642).
4006
4007 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4008
4009 * alloc.c (reset_malloc_hooks): Protoize.
4010 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4011 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4012 * cm.c (losecursor): Likewise.
4013 * data.c (fmod): Likewise.
4014 * dispnew.c (swap_glyphs_in_rows): Likewise.
4015 * emacs.c (memory_warning_signal): Likewise.
4016 * floatfns.c (float_error): Likewise.
4017 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4018 (otf_open, font_otf_capability, generate_otf_features)
4019 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4020 Likewise.
4021 * image.c (pbm_read_file): Likewise.
4022 * indent.c (string_display_width): Likewise.
4023 * intervals.c (check_for_interval, search_for_interval)
4024 (inc_interval_count, count_intervals, root_interval)
4025 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4026 * lread.c (defalias): Likewise.
4027 * ralloc.c (r_alloc_check): Likewise.
4028 * regex.c (set_image_of_range_1, set_image_of_range)
4029 (regex_grow_registers): Likewise.
4030 * sysdep.c (strerror): Likewise.
4031 * termcap.c (valid_filename_p, tprint, main): Likewise.
4032 * tparam.c (main): Likewise.
4033 * unexhp9k800.c (run_time_remap, save_data_space)
4034 (update_file_ptrs, read_header, write_header, calculate_checksum)
4035 (copy_file, copy_rest, display_header): Likewise.
4036 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4037 Likewise.
4038 * xdisp.c (check_it): Likewise.
4039 * xfaces.c (register_color, unregister_color, unregister_colors):
4040 Likewise.
4041 * xfns.c (print_fontset_result): Likewise.
4042 * xrdb.c (member, fatal, main): Likewise.
4043
4044 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4045
4046 Fix minor problems found by static checking (Bug#9031).
4047 * chartab.c (char_table_set_range, map_sub_char_table):
4048 Remove unused locals.
4049 (uniprop_table): Now static.
4050 * composite.c (_work_char): Remove unused static var.
4051
4052 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4053
4054 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4055
4056 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4057
4058 * gtkutil.c (qttip_cb): Remove code without function.
4059
4060 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4061
4062 * w32.c (pthread_sigmask): New stub.
4063
4064 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4065
4066 Use pthread_sigmask, not sigprocmask (Bug#9010).
4067 sigprocmask is portable only for single-threaded applications, and
4068 Emacs can be multi-threaded when it uses GTK.
4069 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4070 (LIBES): Use it.
4071 * callproc.c (Fcall_process):
4072 * process.c (create_process):
4073 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4074 Use pthread_sigmask, not sigprocmask.
4075
4076 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4077
4078 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4079 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4080 wrong (Bug#8591).
4081
4082 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4083
4084 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4085 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4086 (xg_hide_tooltip): Fix comment.
4087
4088 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4089 in registerServicesMenuSendTypes.
4090 (validRequestorForSendType): Don't check ns_return_types.
4091
4092 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4093 ns_return_type.
4094
4095 2011-07-08 Jason Rumney <jasonr@gnu.org>
4096
4097 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4098 SH_SHOW for hidden windows (Bug#5482).
4099
4100 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4101 frame struct members of non-existent frames (Bug#6284).
4102
4103 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4104
4105 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4106 variable firstTime not needed on OSX >= 10.6.
4107 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4108 >= 10.5. Use setKnobProportion, setDoubleValue.
4109
4110 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4111 (MAC_OS_X_VERSION_10_5): Define if not defined.
4112 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4113 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4114 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4115
4116 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4117 cString and lossyCString on OSX >= 10.4
4118
4119 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4120 sizeToFit on OSX >= 10.2.
4121
4122 * nsimage.m (allocInitFromFile): Don't use deprecated method
4123 bestRepresentationForDevice on OSX >= 10.6.
4124
4125 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4126 to avoid warning.
4127
4128 * emacs.c: Declare unexec_init_emacs_zone.
4129
4130 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4131
4132 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4133
4134 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4135 on svcsMenu (Bug#8842).
4136
4137 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4138 ns_return_types.
4139 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4140
4141 * nsterm.m (QUTF8_STRING): Declare.
4142 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4143 (validRequestorForSendType): Return type is (id).
4144 Change indexOfObjectIdenticalTo to indexOfObject.
4145 Check if we have local selection before returning self (Bug#8842).
4146 (writeSelectionToPasteboard): Put local selection into paste board
4147 if we have a local selection (Bug#8842).
4148 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4149
4150 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4151 (ns_get_local_selection): Declare.
4152
4153 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4154
4155 * keymap.c (describe_map_tree): Don't insert a double newline at
4156 the end of the buffer (bug#1169) and return whether we inserted
4157 something.
4158
4159 * callint.c (Fcall_interactively): Change "reading args" to
4160 "providing args" to try to clarify what it does (bug#1010).
4161
4162 2011-07-07 Kenichi Handa <handa@m17n.org>
4163
4164 * composite.c (composition_compute_stop_pos): Ignore a static
4165 composition starting before CHARPOS (Bug#8915).
4166
4167 * xdisp.c (handle_composition_prop): Likewise.
4168
4169 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4170
4171 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4172 (Bug#9015)
4173
4174 2011-07-07 Kenichi Handa <handa@m17n.org>
4175
4176 * character.h (unicode_category_t): New enum type.
4177
4178 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4179 (Qchar_code_property_table): New variable.
4180 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4181 (UNIPROP_COMPRESSED_FORM_P): New macros.
4182 (char_table_ascii): Uncompress the compressed values.
4183 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4184 Uncompress the compressed values.
4185 (sub_char_table_ref_and_range): Likewise.
4186 (char_table_ref_and_range): Uncompress the compressed values.
4187 (sub_char_table_set): New arg is_uniprop. Callers changed.
4188 Uncompress the compressed values.
4189 (sub_char_table_set_range): Args changed. Callers changed.
4190 (char_table_set_range): Adjuted for the above change.
4191 (map_sub_char_table): Delete args default_val and parent. Add arg
4192 top. Give decoded values to a Lisp function.
4193 (map_char_table): Adjust for the above change. Give decoded
4194 values to a Lisp function. Gcpro more variables.
4195 (uniprop_table_uncompress)
4196 (uniprop_decode_value_run_length): New functions.
4197 (uniprop_decoder, uniprop_decoder_count): New variables.
4198 (uniprop_get_decoder, uniprop_encode_value_character)
4199 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4200 New functions.
4201 (uniprop_encoder, uniprop_encoder_count): New variables.
4202 (uniprop_get_encoder, uniprop_table)
4203 (Funicode_property_table_internal, Fget_unicode_property_internal)
4204 (Fput_unicode_property_internal): New functions.
4205 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4206 Sunicode_property_table_internal, Sget_unicode_property_internal,
4207 and Sput_unicode_property_internal. Defvar_lisp
4208 char-code-property-alist.
4209
4210 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4211 Vunicode_category_table.
4212
4213 * font.c (font_range): Adjust for the change of
4214 Vunicode_category_table.
4215
4216 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4217
4218 * m/iris4d.h: Remove file, move contents ...
4219 * s/irix6-5.h: ... here.
4220
4221 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4222
4223 Remove unportable assumption about struct layout (Bug#8884).
4224 * alloc.c (mark_buffer):
4225 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4226 (clone_per_buffer_values): Don't assume that
4227 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4228 This isn't true in general, and it's particularly not true
4229 if Emacs is configured with --with-wide-int.
4230 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4231 New macros, used in the buffer.c change.
4232
4233 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4234
4235 * xsettings.c: Use both GConf and GSettings if both are available.
4236 (store_config_changed_event): Add comment.
4237 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4238 (store_tool_bar_style_changed): New functions.
4239 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4240 (struct xsettings): Move font inside HAVE_XFT.
4241 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4242 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4243 Move inside HAVE_XFT.
4244 (something_changed_gsettingsCB): Rename from something_changedCB.
4245 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4246 also.
4247 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4248 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4249 (something_changed_gconfCB): Rename from something_changedCB.
4250 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4251 (parse_settings): Move check for font inside HAVE_XFT.
4252 (read_settings, apply_xft_settings): Add comment.
4253 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4254 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4255 call store_font_name_changed.
4256 (xft_settings_event): Add comment.
4257 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4258 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4259 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4260 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4261 (xsettings_initialize): Call init_gsettings last.
4262 (xsettings_get_system_font, xsettings_get_system_normal_font):
4263 Add comment.
4264
4265 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4266
4267 Random fixes. E.g., (random) never returned negative values.
4268 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4269 subseconds part to the entropy, as that's a bit more random.
4270 Prefer signed to unsigned, since the signedness doesn't matter and
4271 in general we prefer signed. When given a limit, use a
4272 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4273 latter isn't right if USE_2_TAGS_FOR_INTS.
4274 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4275 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4276
4277 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4278
4279 * textprop.c (text_property_stickiness):
4280 Obey Vtext_property_default_nonsticky.
4281 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4282 * w32fns.c (syms_of_w32fns):
4283 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4284
4285 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4286
4287 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4288 This is more efficient than Ffile_directory_p and avoids a minor race.
4289
4290 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4291
4292 * buffer.c (Foverlay_put): Say what the return value is
4293 (bug#7835).
4294
4295 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4296 is a directory before asking whether to use the file name
4297 (bug#7564).
4298 (barf_or_query_if_file_exists): Make the "File is a directory"
4299 error be more correct.
4300
4301 * fns.c (Frequire): Remove the mention of the .gz files, since
4302 that's installation-specific, but keep the mention of
4303 `get-load-suffixes'.
4304
4305 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4306
4307 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4308 Report string overflow if the output is too long.
4309
4310 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4311
4312 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4313 (syms_of_gnutls): Remove duplicate DEFSYM for
4314 Qgnutls_bootprop_verify_hostname_error, an error for
4315 Qgnutls_bootprop_verify_error (which is no longer used).
4316
4317 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4318 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4319 Also (re)move comments that are misplaced or no longer relevant.
4320
4321 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4322
4323 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4324
4325 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4326
4327 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4328 and background color parameters if they have been changed.
4329
4330 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4331
4332 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4333
4334 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4335
4336 * xsettings.c (SYSTEM_FONT): Define only when used.
4337 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4338
4339 * keymap.c (access_keymap_1): Now static.
4340
4341 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4342
4343 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4344 leave any prefix arg for the up event (Bug#1586).
4345
4346 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4347
4348 * lread.c (syms_of_lread): Mention single symbols defined by
4349 `defvar' or `defconst' (bug#7154).
4350
4351 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4352 (Frequire): Mention get-load-suffixes.
4353
4354 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4355
4356 * window.h (window): Remove clone_number slot.
4357 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4358 Remove.
4359 (make_parent_window, make_window, saved_window)
4360 (Fset_window_configuration, save_window_save): Don't deal with
4361 clone numbers.
4362 * buffer.c (Qclone_number): Remove declaration.
4363 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4364
4365 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4366
4367 Add multiple inheritance to keymaps.
4368 * keymap.c (Fmake_composed_keymap): New function.
4369 (Fset_keymap_parent): Simplify.
4370 (fix_submap_inheritance): Remove.
4371 (access_keymap_1): New function extracted from access_keymap to handle
4372 embedded parents and handle lists of maps.
4373 (access_keymap): Use it.
4374 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4375 (Fcopy_keymap): Handle embedded parents.
4376 (Fcommand_remapping, define_as_prefix): Simplify.
4377 (Fkey_binding): Simplify.
4378 (syms_of_keymap): Move minibuffer-local-completion-map,
4379 minibuffer-local-filename-completion-map,
4380 minibuffer-local-must-match-map, and
4381 minibuffer-local-filename-must-match-map to Elisp.
4382 (syms_of_keymap): Defsubr make-composed-keymap.
4383 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4384 (parse_menu_item): Trivial simplification.
4385
4386 2011-07-01 Glenn Morris <rgm@gnu.org>
4387
4388 * Makefile.in (SETTINGS_LIBS): Fix typo.
4389
4390 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4391
4392 * coding.c (Fencode_coding_string): Record the last coding system
4393 used, as the function doc string says (bug#8738).
4394
4395 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4396
4397 * xsettings.c (store_monospaced_changed): Take new font as arg and
4398 check for change against current_mono_font.
4399 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4400 (emacs_settings_constructor, emacs_settings_get_property)
4401 (emacs_settings_set_property, emacs_settings_class_init)
4402 (emacs_settings_init, gsettings_obj): Remove.
4403 (something_changedCB): New function for HAVE_GSETTINGS.
4404 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4405 with value as argument.
4406 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4407 g_settings_new (Bug#8967). Do not create gsettings_obj.
4408 Remove calls to g_settings_bind. Connect something_changedCB to
4409 "changed".
4410
4411 * xgselect.c: Add defined (HAVE_GSETTINGS).
4412 (xgselect_initialize): Ditto.
4413
4414 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4415 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4416 xg_select.
4417
4418 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4419
4420 * eval.c (struct backtrace): Simplify and port the data structure.
4421 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4422 signed bit field, as this assumption is not portable and it makes
4423 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4424 "char debug_on_exit : 1" as this is not portable either; instead,
4425 use the portable "unsigned int debug_on_exit : 1". Remove unused
4426 member evalargs. Remove obsolete comments about cc bombing out.
4427
4428 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4429
4430 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4431 Let HAVE_GSETTINGS override HAVE_GCONF.
4432 (store_monospaced_changed): New function.
4433 (EMACS_SETTINGS): A new type derived from GObject to handle
4434 GSettings notifications.
4435 (emacs_settings_constructor, emacs_settings_get_property)
4436 (emacs_settings_set_property, emacs_settings_class_init):
4437 New functions.
4438 (gsettings_client, gsettings_obj): New variables.
4439 (GSETTINGS_SCHEMA): New define.
4440 (something_changedCB): Call store_monospaced_changed.
4441 (init_gsettings): New function.
4442 (xsettings_initialize): Call init_gsettings.
4443 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4444 to NULL.
4445
4446 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4447 GCONF_CFLAGS/LIBS.
4448
4449 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4450
4451 * window.c (resize_root_window, grow_mini_window)
4452 (shrink_mini_window): Rename Qresize_root_window to
4453 Qwindow_resize_root_window and Qresize_root_window_vertically to
4454 Qwindow_resize_root_window_vertically.
4455
4456 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4457
4458 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4459
4460 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4461
4462 * makefile.w32-in: Redesign dependencies so they reflect more
4463 clearly which files are directly included by each source file,
4464 and not through other includes.
4465
4466 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4467
4468 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4469 (sort_overlays, overlay_strings): When an overlay's clone number
4470 matches the window's clone number process the overlay even if
4471 the overlay's window property doesn't match the current window.
4472
4473 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4474 (Fwindow_hchild): Rename to Fwindow_left_child.
4475 (Fwindow_next): Rename to Fwindow_next_sibling.
4476 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4477 (resize_window_check): Rename to window_resize_check.
4478 (resize_window_apply): Rename to window_resize_apply.
4479 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4480 (Fdelete_other_windows_internal, resize_frame_windows)
4481 (Fsplit_window_internal, Fdelete_window_internal)
4482 (grow_mini_window, shrink_mini_window)
4483 (Fresize_mini_window_internal): Fix callers accordingly.
4484
4485 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4486
4487 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4488 (emacs_fixed_set_min_size): Remove.
4489 (emacs_fixed_new): Take frame as argument.
4490
4491 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4492 (_EmacsFixedPrivate): Remove minwidth/height.
4493 Add struct frame *f.
4494 (emacs_fixed_init): Initialize priv->f.
4495 (get_parent_class, emacs_fixed_set_min_size): Remove.
4496 (emacs_fixed_new): Set priv->f to argument.
4497 (emacs_fixed_get_preferred_width)
4498 (emacs_fixed_get_preferred_height): Use min_width/height from
4499 frames size_hint to set minimum and natural (Bug#8919).
4500 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4501 and use min_width/height from frames size_hint to set
4502 min_width/height (Bug#8919).
4503
4504 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4505 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4506 Fix indentation.
4507
4508 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4509
4510 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4511 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4512 called at ZV.
4513
4514 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4515
4516 * process.c (wait_reading_process_output): Bypass select if
4517 waiting for a cell while ignoring keyboard input, and input is
4518 pending. Suggested by Jan Djärv (Bug#8869).
4519
4520 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4521
4522 Use gnulib's dup2 module instead of rolling our own.
4523 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4524
4525 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4526
4527 * dispnew.c (scrolling_window): Before scrolling, turn off a
4528 mouse-highlight in the window being scrolled.
4529
4530 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4531
4532 Move DEFSYM to lisp.h and use everywhere.
4533
4534 * character.h (DEFSYM): Move declaration...
4535 * lisp.h (DEFSYM): ...here.
4536
4537 * gnutls.c:
4538 * minibuf.c:
4539 * w32menu.c:
4540 * w32proc.c:
4541 * w32select.c: Don't include character.h.
4542
4543 * alloc.c (syms_of_alloc):
4544 * buffer.c (syms_of_buffer):
4545 * bytecode.c (syms_of_bytecode):
4546 * callint.c (syms_of_callint):
4547 * casefiddle.c (syms_of_casefiddle):
4548 * casetab.c (init_casetab_once):
4549 * category.c (init_category_once, syms_of_category):
4550 * ccl.c (syms_of_ccl):
4551 * cmds.c (syms_of_cmds):
4552 * composite.c (syms_of_composite):
4553 * dbusbind.c (syms_of_dbusbind):
4554 * dired.c (syms_of_dired):
4555 * dispnew.c (syms_of_display):
4556 * doc.c (syms_of_doc):
4557 * editfns.c (syms_of_editfns):
4558 * emacs.c (syms_of_emacs):
4559 * eval.c (syms_of_eval):
4560 * fileio.c (syms_of_fileio):
4561 * fns.c (syms_of_fns):
4562 * frame.c (syms_of_frame):
4563 * fringe.c (syms_of_fringe):
4564 * insdel.c (syms_of_insdel):
4565 * keymap.c (syms_of_keymap):
4566 * lread.c (init_obarray, syms_of_lread):
4567 * macros.c (syms_of_macros):
4568 * msdos.c (syms_of_msdos):
4569 * print.c (syms_of_print):
4570 * process.c (syms_of_process):
4571 * search.c (syms_of_search):
4572 * sound.c (syms_of_sound):
4573 * syntax.c (init_syntax_once, syms_of_syntax):
4574 * terminal.c (syms_of_terminal):
4575 * textprop.c (syms_of_textprop):
4576 * undo.c (syms_of_undo):
4577 * w32.c (globals_of_w32):
4578 * window.c (syms_of_window):
4579 * xdisp.c (syms_of_xdisp):
4580 * xfaces.c (syms_of_xfaces):
4581 * xfns.c (syms_of_xfns):
4582 * xmenu.c (syms_of_xmenu):
4583 * xsettings.c (syms_of_xsettings):
4584 * xterm.c (syms_of_xterm): Use DEFSYM.
4585
4586 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4587
4588 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4589
4590 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4591
4592 Integer and buffer overflow fixes (Bug#8873).
4593
4594 * print.c (printchar, strout): Check for string overflow.
4595 (PRINTPREPARE, printchar, strout):
4596 Don't set size unless allocation succeeds.
4597
4598 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4599 for sizes. Check for string overflow more accurately.
4600 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4601
4602 * macros.c: Integer and buffer overflow fixes.
4603 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4604 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4605 Use ptrdiff_t, not int, for sizes.
4606 Don't increment bufsize until after realloc succeeds.
4607 Check for size-calculation overflow.
4608 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4609
4610 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4611
4612 * lread.c: Integer overflow fixes.
4613 (read_integer): Radix is now EMACS_INT, not int,
4614 to improve quality of diagnostics for out-of-range radices.
4615 Calculate buffer size correctly for out-of-range radices.
4616 (read1): Check for integer overflow in radices, and in
4617 read-circle numbers.
4618 (read_escape): Avoid int overflow.
4619 (Fload, openp, read_buffer_size, read1)
4620 (substitute_object_recurse, read_vector, read_list, map_obarray):
4621 Use ptrdiff_t, not int, for sizes.
4622 (read1): Use EMACS_INT, not int, for sizes.
4623 Check for size overflow.
4624
4625 * image.c (cache_image): Check for size arithmetic overflow.
4626
4627 * lread.c: Integer overflow issues.
4628 (saved_doc_string_size, saved_doc_string_length)
4629 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4630 Now ptrdiff_t, not int.
4631 (read1): Don't assume doc string length fits in int. Check for
4632 out-of-range doc string lengths.
4633 (read_list): Don't assume file position fits in int.
4634 (read_escape): Check for hex character overflow.
4635
4636 2011-06-22 Leo Liu <sdl.web@gmail.com>
4637
4638 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4639 Move to minibuffer.el.
4640
4641 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4642
4643 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4644 The following patches are for when GLYPH_DEBUG && !XASSERT.
4645 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4646 * dispnew.c (flush_stdout):
4647 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4648 Mark as externally visible.
4649 * dispnew.c (check_window_matrix_pointers): Now static.
4650 * dispnew.c (window_to_frame_vpos):
4651 * xfns.c (unwind_create_frame):
4652 * xterm.c (x_check_font): Remove unused local.
4653 * scroll.c (CHECK_BOUNDS):
4654 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4655 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4656 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4657 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4658 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4659 Now static.
4660 (debug_method_add): Use va_list and vsprintf rather than relying
4661 on undefined behavior with wrong number of arguments.
4662 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4663 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4664 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4665 since we're not interested in debugging glyphs with old libraries.
4666 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4667 GCC 4.6.0's static checking.
4668
4669 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4670
4671 Integer overflow and signedness fixes (Bug#8873).
4672 A few related buffer overrun fixes, too.
4673
4674 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4675
4676 * dispextern.h (struct face.stipple):
4677 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4678 (x_bitmap_mask, x_allocate_bitmap_record)
4679 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4680 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4681 (x_create_bitmap_from_xpm_data):
4682 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4683 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4684 (.bitmaps_last):
4685 * xfaces.c (load_pixmap):
4686 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4687 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4688 (.bitmaps_last, struct x_output.icon_bitmap):
4689 Use ptrdiff_t, not int, for bitmap indexes.
4690 (x_allocate_bitmap_record): Check for size overflow.
4691 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4692
4693 Use ptrdiff_t, not int, for overlay counts.
4694 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4695 * editfns.c (overlays_around, get_pos_property):
4696 * textprop.c (get_char_property_and_overlay):
4697 * xdisp.c (next_overlay_change, note_mouse_highlight):
4698 * xfaces.c (face_at_buffer_position):
4699 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4700 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4701 (Fnext_overlay_change, Fprevious_overlay_change)
4702 (mouse_face_overlay_overlaps, Foverlays_in):
4703 Use ptrdiff_t, not int, for sizes.
4704 (overlays_at, overlays_in): Check for size-calculation overflow.
4705
4706 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4707
4708 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4709 (x_session_initialize): Do not assume string length fits in int.
4710
4711 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4712 This is unlikely, but can occur if DPI is outlandish.
4713
4714 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4715 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4716
4717 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4718 * xrdb.c (magic_file_p, search_magic_path):
4719 Omit last arg SUFFIX; it was always 0. All callers changed.
4720 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4721
4722 * xfont.c (xfont_match): Avoid need for strlen.
4723
4724 * xfns.c: Don't assume strlen fits in int.
4725 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4726
4727 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4728 not unsigned long, as we prefer signed integers. All callers changed.
4729 Detect integer overflow in repeat count.
4730 (message_dolog): Don't assume print length fits in 39 bytes.
4731 (display_mode_element): Don't assume strlen fits in int.
4732
4733 * termcap.c: Don't assume sizes fit in int and never overflow.
4734 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4735 (gobble_line): Check for size-calculation overflow.
4736
4737 * minibuf.c (Fread_buffer):
4738 * lread.c (intern, intern_c_string):
4739 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4740 Don't assume string length fits in int.
4741
4742 * keyboard.c (parse_tool_bar_item):
4743 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4744
4745 * font.c: Don't assume string length fits in int.
4746 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4747 Use ptrdiff_t, not int.
4748 (font_intern_prop): Don't assume string length fits in int.
4749 Don't assume integer property fits in fixnum.
4750 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4751
4752 * filelock.c: Fix some buffer overrun and integer overflow issues.
4753 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4754 Reformulate so as not to need the command string.
4755 Invoke gzip -cd rather than gunzip, as it's more portable.
4756 (lock_info_type, lock_file_1, lock_file):
4757 Don't assume pid_t and time_t fit in unsigned long.
4758 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4759 (current_lock_owner): Prefer signed type for sizes.
4760 Use memcpy, not strncpy, where memcpy is what is really wanted.
4761 Don't assume (via atoi) that time_t and pid_t fit in int.
4762 Check for time_t and/or pid_t out of range, e.g., via a network share.
4763 Don't alloca where an auto var works fine.
4764
4765 * fileio.c: Fix some integer overflow issues.
4766 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4767 Don't assume string length fits in int.
4768 (directory_file_name): Don't assume string length fits in long.
4769 (make_temp_name): Don't assume pid fits in int, or that its print
4770 length is less than 20.
4771
4772 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4773
4774 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4775
4776 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4777
4778 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4779 We prefer signed integers, even for size calculations.
4780
4781 * emacs.c: Don't assume string length fits in 'int'.
4782 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4783 (main): Don't invoke strlen when not needed.
4784
4785 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4786 (XD_DEBUG_MESSAGE): Don't waste a byte.
4787
4788 * callproc.c (getenv_internal_1, getenv_internal)
4789 (Fgetenv_internal):
4790 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4791
4792 * lread.c (invalid_syntax): Omit length argument.
4793 All uses changed. This doesn't fix a bug, but it simplifies the
4794 code away from its former Hollerith-constant appearance, and it's
4795 one less 'int' to worry about when looking at integer-overflow issues.
4796 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4797
4798 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4799 This didn't break anything, but it didn't help either.
4800 It's confusing to put a bogus integer in a place where the actual
4801 value does not matter.
4802 (LIST_END_P): Remove unused macro and its bogus comment.
4803 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4804
4805 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4806 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4807 implementation.
4808 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4809 We prefer signed types, and the value cannot exceed the EMACS_INT
4810 range anyway (because otherwise the length would not be representable).
4811 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4812 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4813 This avoids a GCC warning when WIDE_EMACS_INT.
4814
4815 * indent.c (sane_tab_width): New function.
4816 (current_column, scan_for_column, Findent_to, position_indentation)
4817 (compute_motion): Use it. This is just for clarity.
4818 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4819
4820 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4821
4822 * lisp.h (lint_assume): New macro.
4823 * composite.c (composition_gstring_put_cache):
4824 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4825
4826 * editfns.c, insdel.c:
4827 Omit unnecessary forward decls, to simplify future changes.
4828
4829 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4830
4831 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4832
4833 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4834 Use much-faster test for byte-length change.
4835 Don't assume string byte-length fits in 'int'.
4836 Check that character arg fits in 'int'.
4837 (mapcar1): Declare byte as byte, for clarity.
4838
4839 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4840
4841 * fns.c (concat): Catch string overflow earlier.
4842 Do not rely on integer wraparound.
4843
4844 * dispextern.h (struct it.overlay_strings_charpos)
4845 (struct it.selective): Now EMACS_INT, not int.
4846 * xdisp.c (forward_to_next_line_start)
4847 (back_to_previous_visible_line_start)
4848 (reseat_at_next_visible_line_start, next_element_from_buffer):
4849 Don't arbitrarily truncate the value of 'selective' to int.
4850
4851 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4852
4853 * composite.c: Don't truncate sizes to 'int'.
4854 (composition_gstring_p, composition_reseat_it)
4855 (composition_adjust_point): Use EMACS_INT, not int.
4856 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4857 not EMACS_UINT, for indexes.
4858
4859 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4860
4861 * buffer.c: Include <verify.h>.
4862 (struct sortvec.priority, struct sortstr.priority):
4863 Now EMACS_INT, not int.
4864 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4865 (struct sortstr.size, record_overlay_string)
4866 (struct sortstrlist.size, struct sortlist.used):
4867 Don't truncate size to int.
4868 (record_overlay_string): Check for size-calculation overflow.
4869 (init_buffer_once): Check at compile-time, not run-time.
4870
4871 2011-06-22 Jim Meyering <meyering@redhat.com>
4872
4873 Don't leak an XBM-image-sized buffer
4874 * image.c (xbm_load): Free the image buffer after using it.
4875
4876 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4877
4878 Port to Sun C.
4879 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4880 that Sun C diagnosed.
4881 * fns.c (secure_hash): Fix pointer signedness issue.
4882 * intervals.c (static_offset_intervals): New function.
4883 (offset_intervals): Use it.
4884
4885 2011-06-21 Leo Liu <sdl.web@gmail.com>
4886
4887 * deps.mk (fns.o):
4888 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4889 sha512.h.
4890
4891 * fns.c (secure_hash): Rename from crypto_hash_function and change
4892 the first arg to accept symbols.
4893 (Fsecure_hash): New primitive.
4894 (syms_of_fns): New symbols.
4895
4896 2011-06-20 Deniz Dogan <deniz@dogan.se>
4897
4898 * process.c (Fset_process_buffer): Clarify return value in
4899 docstring.
4900
4901 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4902
4903 * dispnew.c (add_window_display_history): Use BVAR.
4904
4905 * xdisp.c (debug_method_add): Use BVAR.
4906 (check_window_end, dump_glyph_matrix, dump_glyph)
4907 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4908
4909 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4910 Likewise.
4911
4912 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4913 check till after the cache is created in init_frame_faces.
4914
4915 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4916
4917 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4918
4919 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4920
4921 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4922 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4923 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4924
4925 Improve buffer-overflow checking (Bug#8873).
4926 * fileio.c (Finsert_file_contents):
4927 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4928 Remove the old (too-loose) buffer overflow checks.
4929 They weren't needed, since make_gap checks for buffer overflow.
4930 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4931 The old code merely checked for Emacs fixnum overflow, and relied
4932 on undefined (wraparound) behavior. The new code avoids undefined
4933 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4934
4935 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4936 Tune. Don't use wider integers than needed. Don't use alloca.
4937 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4938
4939 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4940
4941 * insdel.c, lisp.h (buffer_overflow): New function.
4942 (insert_from_buffer_1, replace_range, replace_range_2):
4943 * insdel.c (make_gap_larger):
4944 * editfns.c (Finsert_char):
4945 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4946
4947 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4948
4949 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4950
4951 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4952
4953 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4954 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4955
4956 * fileio.c: Don't assume EMACS_INT fits in off_t.
4957 (emacs_lseek): New static function.
4958 (Finsert_file_contents, Fwrite_region): Use it.
4959 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4960
4961 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4962
4963 * fns.c: Don't overflow int when computing a list length.
4964 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4965 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4966 truncation on 64-bit hosts. Check for QUIT every
4967 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4968 faster and is responsive enough.
4969 (Flength): Report an error instead of overflowing an integer.
4970 (Fsafe_length): Return a float if the value is not representable
4971 as a fixnum. This shouldn't happen except in contrived situations.
4972 (Fnthcdr, Fsort): Don't assume list length fits in int.
4973 (Fcopy_sequence): Don't assume vector length fits in int.
4974
4975 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4976 (header_size, word_size): New constants.
4977 (allocate_vectorlike): Don't check size overflow here.
4978 (allocate_vector): Check it here instead, since this is the only
4979 caller of allocate_vectorlike that could cause overflow.
4980 Check that the new vector's length is representable as a fixnum.
4981
4982 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4983 The previous code was bogus. For example, next_almost_prime (32)
4984 returned 39, which is undesirable as it is a multiple of 3; and
4985 next_almost_prime (24) returned 25, which is a multiple of 5 so
4986 why was the code bothering to check for multiples of 7?
4987
4988 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4989
4990 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4991
4992 Variadic C functions now count arguments with ptrdiff_t.
4993 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4994 Back then I didn't know that the Emacs coding style prefers signed int.
4995 Also, in the meantime I found a few more instances where arguments
4996 were being counted with int, which may truncate counts on 64-bit
4997 machines, or EMACS_INT, which may be unnecessarily wide.
4998 * lisp.h (struct Lisp_Subr.function.aMANY)
4999 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5000 Arg counts are now ptrdiff_t, not size_t.
5001 All variadic functions and their callers changed accordingly.
5002 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5003 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5004 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5005 * callint.c (Fcall_interactively): Check arg count for overflow,
5006 to avoid potential buffer overrun. Use signed char, not 'int',
5007 for 'varies' array, so that we needn't bother to check its size
5008 calculation for overflow.
5009 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5010 * eval.c (apply_lambda):
5011 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5012 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5013 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5014
5015 * callint.c (Fcall_interactively): Don't use index var as event count.
5016
5017 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5018 * mem-limits.h (SIZE): Remove; no longer used.
5019
5020 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5021
5022 Remove unnecessary casts.
5023 * xterm.c (x_term_init):
5024 * xfns.c (x_set_border_pixel):
5025 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5026 These aren't needed now that we assume ANSI C.
5027
5028 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5029 It's more likely to cause problems (due to unsigned overflow)
5030 than to cure them.
5031
5032 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5033
5034 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5035
5036 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5037
5038 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5039
5040 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5041
5042 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5043
5044 GLYPH_CODE_FACE returns EMACS_INT, not int.
5045 * dispextern.h (merge_faces):
5046 * xfaces.c (merge_faces):
5047 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5048 Don't assume EMACS_INT fits in int.
5049
5050 * character.h (CHAR_VALID_P): Remove unused parameter.
5051 * fontset.c, lisp.h, xdisp.c: All uses changed.
5052
5053 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5054
5055 * fns.c (concat): Minor tuning based on overflow analysis.
5056 This doesn't fix any bugs. Use int to hold character, instead
5057 of constantly refetching from Emacs object. Use XFASTINT, not
5058 XINT, for value known to be a character. Don't bother comparing
5059 a single byte to 0400, as it's always less.
5060
5061 * floatfns.c (Fexpt):
5062 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5063
5064 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5065 for characters.
5066
5067 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5068
5069 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5070 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5071 incorrectly succeed when S was a string, because 4294967386 was
5072 truncated before it was used.
5073
5074 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5075 Otherwise, an out-of-range integer could cause undefined behavior
5076 on a 64-bit host.
5077
5078 * composite.c: Use int, not EMACS_INT, for characters.
5079 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5080 EMACS_INT, for values that are known to be in character range.
5081 This doesn't fix any bugs but is the usual style inside Emacs and
5082 may generate better code on 32-bit machines.
5083
5084 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5085 This is for reasons similar to the recent CHAR_STRING fix.
5086 * charset.c (Fencode_char): Check that character arg is actually
5087 a character. Pass an int to ENCODE_CHAR.
5088 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5089 wider than 'int', as a compile-time check to prevent future regressions
5090 in this area.
5091
5092 * character.c (char_string): Remove unnecessary casts.
5093
5094 Make sure a 64-bit char is never passed to CHAR_STRING.
5095 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5096 by silently ignoring the top 32 bits, allowing some values
5097 that were far too large to be valid characters.
5098 * character.h: Include <verify.h>.
5099 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5100 arguments are no wider than unsigned, as a compile-time check
5101 to prevent future regressions in this area.
5102 * data.c (Faset):
5103 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5104 (Fsubst_char_in_region):
5105 * fns.c (concat):
5106 * xdisp.c (decode_mode_spec_coding):
5107 Adjust to CHAR_STRING's new requirement.
5108 * editfns.c (Finsert_char, Fsubst_char_in_region):
5109 * fns.c (concat): Check that character args are actually
5110 characters. Without this test, these functions did the wrong
5111 thing with wildly out-of-range values on 64-bit hosts.
5112
5113 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5114 These casts should not be needed on 32-bit hosts, either.
5115 * keyboard.c (read_char):
5116 * lread.c (Fload): Remove casts to unsigned.
5117
5118 * lisp.h (UNSIGNED_CMP): New macro.
5119 This fixes comparison bugs on 64-bit hosts.
5120 (ASCII_CHAR_P): Use it.
5121 * casefiddle.c (casify_object):
5122 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5123 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5124 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5125 * dispextern.h (FACE_FROM_ID):
5126 * keyboard.c (read_char): Use UNSIGNED_CMP.
5127
5128 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5129 not to EMACS_INT, to avoid GCC warning.
5130
5131 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5132
5133 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5134 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5135 isn't needed on 32-bit machines.
5136
5137 * buffer.c (Fgenerate_new_buffer_name):
5138 Use EMACS_INT for count, not int.
5139 (advance_to_char_boundary): Return EMACS_INT, not int.
5140
5141 * data.c (Qcompiled_function): Now static.
5142
5143 * window.c (window_body_lines): Now static.
5144
5145 * image.c (gif_load): Rename local to avoid shadowing.
5146
5147 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5148 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5149 * alloc.c (make_save_value): Integer argument is now of type
5150 ptrdiff_t, not int.
5151 (mark_object): Use ptrdiff_t, not int.
5152 * lisp.h (pD): New macro.
5153 * print.c (print_object): Use it.
5154
5155 * alloc.c: Use EMACS_INT, not int, to count objects.
5156 (total_conses, total_markers, total_symbols, total_vector_size)
5157 (total_free_conses, total_free_markers, total_free_symbols)
5158 (total_free_floats, total_floats, total_free_intervals)
5159 (total_intervals, total_strings, total_free_strings):
5160 Now EMACS_INT, not int. All uses changed.
5161 (Fgarbage_collect): Compute overall total using a double, so that
5162 integer overflow is less likely to be a problem. Check for overflow
5163 when converting back to an integer.
5164 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5165 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5166 These were 'int' variables that could overflow on 64-bit hosts;
5167 they were never used, so remove them instead of repairing them.
5168 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5169 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5170 Previously, this ceilinged at INT_MAX, but that doesn't work on
5171 64-bit machines.
5172 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5173
5174 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5175 (allocate_vectorlike): Check for ptrdiff_t overflow.
5176 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5177 when a (possibly-narrower) signed value would do just as well.
5178 We prefer using signed arithmetic, to avoid comparison confusion.
5179
5180 * alloc.c: Catch some string size overflows that we were missing.
5181 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5182 for convenience in STRING_BYTES_MAX.
5183 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5184 The definition here is exact; the one in lisp.h was approximate.
5185 (allocate_string_data): Check for string overflow. This catches
5186 some instances we weren't catching before. Also, it catches
5187 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5188 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5189 and ptrdiff_t and EMACS_INT are both 64 bits.
5190
5191 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5192 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5193 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5194
5195 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5196
5197 * alloc.c (Fmake_string): Check for out-of-range init.
5198
5199 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5200
5201 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5202
5203 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5204
5205 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5206 xg_get_default_scrollbar_width.
5207
5208 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5209 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5210 (style_changed_cb): Call update_theme_scrollbar_width and call
5211 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5212 all frames (Bug#8505).
5213 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5214 Call gtk_window_set_resizable if HAVE_GTK3.
5215 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5216 and height if HAVE_GTK3 (Bug#8505).
5217 (scroll_bar_width_for_theme): New variable.
5218 (update_theme_scrollbar_width): New function.
5219 (xg_get_default_scrollbar_width): Move code to
5220 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5221 (xg_initialize): Call update_theme_scrollbar_width.
5222
5223 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5224
5225 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5226
5227 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5228
5229 * frame.c (make_frame): Call other_buffer_safely instead of
5230 other_buffer.
5231
5232 * window.c (temp_output_buffer_show): Call display_buffer with
5233 second argument Vtemp_buffer_show_specifiers and reset latter
5234 immediately after the call.
5235 (Vtemp_buffer_show_specifiers): New variable.
5236 (auto_window_vscroll_p, next_screen_context_lines)
5237 (Vscroll_preserve_screen_position): Remove leading asterisks from
5238 doc-strings.
5239
5240 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5241
5242 Fix minor problems found by GCC 4.6.0 static checking.
5243 * buffer.c (Qclone_number): Remove for now, as it's unused.
5244 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5245 (record_buffer): Remove unused local.
5246 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5247 (set_frame_buffer_list): Remove; unused.
5248 * frame.h (other_visible_frames): Remove decl.
5249 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5250 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5251 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5252 if HAVE_GPM.
5253 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5254 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5255 Define only if HAVE_GPM.
5256 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5257 (update_hints_inhibit): Remove; never set. All uses removed.
5258 * widgetprv.h (emacsFrameClassRec): Remove decl.
5259 * window.c (delete_deletable_window): Now returns void, since it
5260 wasn't returning anything.
5261 (compare_window_configurations): Remove unused locals.
5262 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5263 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5264 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5265 the same widths as pointers. This follows up on the 2011-05-06 patch.
5266 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5267 * xterm.h: Likewise.
5268 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5269
5270 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5271
5272 * makefile.w32-in: Update dependencies.
5273 (LISP_H): Add lib/intprops.h.
5274
5275 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5276
5277 * image.c (gif_load): Add animation frame delay to the metadata.
5278 (syms_of_image): Use DEFSYM. New symbol `delay'.
5279
5280 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5281
5282 * window.c (delete_deletable_window): Re-add.
5283 (Fset_window_configuration): Rewrite to handle dead buffers and
5284 consequently deletable windows.
5285 (window_tree, Fwindow_tree): Remove. Supply functionality in
5286 window.el.
5287 (compare_window_configurations): Simplify code.
5288
5289 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5290
5291 * image.c (imagemagick_load_image): Fix type mismatch.
5292 (Fimagemagick_types): Likewise.
5293
5294 * window.h (replace_buffer_in_windows): Declare.
5295
5296 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5297
5298 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5299 Qclone_number. Remove external declaration of Qdelete_window.
5300 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5301 code.
5302 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5303 Run Qbuffer_list_update_hook if allowed.
5304 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5305 buffer list implementation.
5306 (other_buffer_safely): New function.
5307 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5308 calls to replace_buffer_in_windows and
5309 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5310 if allowed.
5311 (record_buffer): Inhibit quitting and rewrite using quittable
5312 functions. Run Qbuffer_list_update_hook if allowed.
5313 (Frecord_buffer, Funrecord_buffer): New functions.
5314 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5315 Move switch-to-buffer to window.el.
5316 (bury-buffer): Move to window.el.
5317 (Vbuffer_list_update_hook): New variable.
5318
5319 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5320 section.
5321
5322 * window.h (resize_frame_windows): Move up in code.
5323 (Fwindow_frame): Remove EXFUN.
5324 (replace_buffer_in_all_windows): Remove prototype.
5325 (replace_buffer_in_windows_safely): Add prototype.
5326
5327 * window.c: Declare Qdelete_window static again. Move down
5328 declaration of select_count.
5329 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5330 (Fother_window): Move to window.el.
5331 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5332 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5333 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5334 window.el.
5335 (replace_buffer_in_windows): Implement by calling
5336 Qreplace_buffer_in_windows.
5337 (replace_buffer_in_all_windows): Remove with some functionality
5338 moved into replace_buffer_in_windows_safely.
5339 (replace_buffer_in_windows_safely): New function.
5340 (select_window_norecord, select_frame_norecord): Move in front
5341 of run_window_configuration_change_hook. Remove now obsolete
5342 declarations.
5343 (Fset_window_buffer): Rewrite doc-string.
5344 Call Qrecord_window_buffer.
5345 (keys_of_window): Move binding for other-window to window.el.
5346
5347 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5348
5349 * dispextern.h (struct image): Replace data member, whose int_val
5350 and ptr_val fields were not used by anything, with a single
5351 lisp_val object.
5352
5353 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5354 (gif_clear_image, gif_load, imagemagick_load_image)
5355 (gs_clear_image, gs_load): Callers changed.
5356
5357 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5358
5359 * buffer.h: Include <time.h>, for time_t.
5360 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5361
5362 Fix minor problems found by static checking.
5363
5364 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5365
5366 Make identifiers static if they are not used in other modules.
5367 * data.c (Qcompiled_function, Qframe, Qvector):
5368 * image.c (QimageMagick, Qsvg):
5369 * minibuf.c (Qmetadata):
5370 * window.c (resize_window_check, resize_root_window): Now static.
5371 * window.h (resize_window_check, resize_root_window): Remove decls.
5372
5373 * window.c (window_deletion_count, delete_deletable_window):
5374 Remove; unused.
5375 (window_body_lines): Now static.
5376 (Fdelete_other_windows_internal): Mark vars as initialized.
5377 Make sure 'resize_failed' is initialized.
5378 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5379 (resize_window_apply): Remove unused local.
5380 * window.h (delete_deletable_window): Remove decl.
5381
5382 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5383 (imagemagick_load_image): Fix pointer signedness problem by changing
5384 last arg from unsigned char * to char *. All uses changed.
5385 Also, fix a local for similar reasons.
5386 Remove unused locals. Remove locals to avoid shadowing.
5387 (fn_rsvg_handle_free): Remove; unused.
5388 (svg_load, svg_load_image): Fix pointer signedness problem.
5389 (imagemagick_load_image): Don't use garbage pointer image_wand.
5390
5391 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5392
5393 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5394
5395 * image.c (gif_load): Fix omitted cast error introduced by
5396 2011-06-06 change.
5397
5398 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5399
5400 * window.h (resize_proportionally, orig_total_lines)
5401 (orig_top_line): Remove from window structure.
5402 (set_window_height, set_window_width, change_window_heights)
5403 (Fdelete_window): Remove prototypes.
5404 (resize_frame_windows): Remove duplicate declaration.
5405
5406 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5407
5408 * window.h (resize_frame_windows, resize_window_check)
5409 (delete_deletable_window, resize_root_window)
5410 (resize_frame_windows): Declare prototypes.
5411
5412 * window.c (resize_window_apply): Make definition be "static" to
5413 match the prototype.
5414
5415 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5416
5417 * window.c: Remove declarations of Qwindow_size_fixed,
5418 window_min_size_1, window_min_size_2, window_min_size,
5419 size_window, window_fixed_size_p, enlarge_window, delete_window.
5420 Remove static from declaration of Qdelete_window, it's
5421 temporarily needed by Fbury_buffer.
5422 (replace_window): Don't assign orig_top_line and
5423 orig_total_lines.
5424 (Fdelete_window, delete_window): Remove. Window deletion is
5425 handled by window.el.
5426 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5427 Replace Fdelete_window calls with calls to Qdelete_window.
5428 (Fdelete_other_windows): Remove. Deleting other windows is
5429 handled by window.el.
5430 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5431 handled in window.el.
5432 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5433 Window minimum sizes are handled in window.el.
5434 (shrink_windows, size_window, set_window_height)
5435 (set_window_width, change_window_heights, window_height)
5436 (window_width, CURBEG, CURSIZE, enlarge_window)
5437 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5438 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5439 handled in window.el.
5440 (make_dummy_parent): Rename to make_parent_window and give it a
5441 second argument horflag.
5442 (make_window): Don't set resize_proportionally any more.
5443 (Fsplit_window): Remove. Windows are split in window.el.
5444 (save_restore_action, save_restore_orig_size)
5445 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5446 Resize mini windows in window.el.
5447 (grow_mini_window, shrink_mini_window): Implement by calling
5448 Qresize_root_window_vertically, resize_window_check and
5449 resize_window_apply.
5450 (saved_window, Fset_window_configuration, save_window_save):
5451 Do not handle orig_top_line, orig_total_lines, and
5452 resize_proportionally.
5453 (window_min_height, window_min_width): Move to window.el.
5454 (keys_of_window): Move bindings for delete-other-windows,
5455 split-window, delete-window and enlarge-window to window.el.
5456
5457 * buffer.c: Temporarily extern Qdelete_window.
5458 (Fbury_buffer): Temporarily call Qdelete_window instead of
5459 Fdelete_window (Fbury_buffer will move to window.el soon).
5460
5461 * frame.c (set_menu_bar_lines_1): Remove code handling
5462 orig_top_line and orig_total_lines.
5463
5464 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5465 set_window_height but set heights directly.
5466 (change_frame_size_1): Use resize_frame_windows.
5467
5468 * xdisp.c (init_xdisp): Don't use set_window_height but set
5469 heights directly.
5470
5471 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5472 Use resize_frame_windows instead of change_window_heights and run
5473 run_window_configuration_change_hook.
5474
5475 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5476 instead of change_window_heights and run
5477 run_window_configuration_change_hook.
5478
5479 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5480
5481 * window.c (replace_window): Rename second argument REPLACEMENT to
5482 NEW. New third argument SETFLAG. Rewrite.
5483 (delete_window, make_dummy_parent): Call replace_window with
5484 third argument 1.
5485 (window_list_1): Move down in code.
5486 (run_window_configuration_change_hook): Move set_buffer part
5487 before select_frame_norecord part in order to unwind correctly.
5488 Rename count1 to count.
5489 (recombine_windows, delete_deletable_window, resize_root_window)
5490 (Fdelete_other_windows_internal)
5491 (Frun_window_configuration_change_hook, make_parent_window)
5492 (resize_window_check, resize_window_apply, Fresize_window_apply)
5493 (resize_frame_windows, Fsplit_window_internal)
5494 (Fdelete_window_internal, Fresize_mini_window_internal):
5495 New functions.
5496 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5497
5498 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5499
5500 * window.h (window): Add some new members to window structure -
5501 normal_lines, normal_cols, new_total, new_normal, clone_number,
5502 splits, nest, prev_buffers, next_buffers.
5503 (WINDOW_TOTAL_SIZE): Move here from window.c.
5504 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5505
5506 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5507 Remove.
5508 (make_dummy_parent): Set new members of windows structure.
5509 (make_window): Move down in code. Handle new members of window
5510 structure.
5511 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5512 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5513 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5514 (Fset_window_prev_buffers, Fwindow_next_buffers)
5515 (Fset_window_next_buffers, Fset_window_clone_number):
5516 New functions.
5517 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5518 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5519 Doc-string fixes.
5520 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5521 Argument WINDOW can be now internal window too.
5522 (Fwindow_use_time): Move up in code.
5523 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5524 Rewrite doc-string.
5525 (Fset_window_configuration, saved_window)
5526 (Fcurrent_window_configuration, save_window_save): Handle new
5527 members of window structure.
5528 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5529 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5530 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5531 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5532 Qget_mru_window, Qresize_root_window,
5533 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5534 Qauto_buffer_name; staticpro them.
5535
5536 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5537
5538 * window.c (Fwindow_total_size, Fwindow_left_column)
5539 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5540 (Fwindow_list_1): New functions.
5541 (window_box_text_cols): Replace with window_body_cols.
5542 (Fwindow_width, Fscroll_left, Fscroll_right):
5543 Use window_body_cols instead of window_box_text_cols.
5544 (delete_window, Fset_window_configuration):
5545 Call delete_all_subwindows with window as argument.
5546 (delete_all_subwindows): Take a window as argument and not a
5547 structure. Rewrite.
5548 (window_loop): Remove handling of GET_LRU_WINDOW and
5549 GET_LARGEST_WINDOW.
5550 (Fget_lru_window, Fget_largest_window): Move to window.el.
5551
5552 * window.h: Extern window_body_cols instead of
5553 window_box_text_cols. delete_all_subwindows now takes a
5554 Lisp_Object as argument.
5555
5556 * indent.c (compute_motion, Fcompute_motion):
5557 Use window_body_cols instead of window_box_text_cols.
5558
5559 * frame.c (delete_frame): Call delete_all_subwindows with root
5560 window as argument.
5561
5562 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5563
5564 * fns.c (Fputhash): Document return value.
5565
5566 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5567
5568 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5569
5570 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5571
5572 Cons<->int and similar integer overflow fixes (Bug#8794).
5573
5574 Check for overflow when converting integer to cons and back.
5575 * charset.c (Fdefine_charset_internal, Fdecode_char):
5576 Use cons_to_unsigned to catch overflow.
5577 (Fencode_char): Use INTEGER_TO_CONS.
5578 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5579 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5580 * data.c (long_to_cons, cons_to_long): Remove.
5581 (cons_to_unsigned, cons_to_signed): New functions.
5582 These signal an error for invalid or out-of-range values.
5583 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5584 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5585 * font.c (Ffont_variation_glyphs):
5586 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5587 * lisp.h: Include <intprops.h>.
5588 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5589 (cons_to_signed, cons_to_unsigned): New decls.
5590 (long_to_cons, cons_to_long): Remove decls.
5591 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5592 (Fprimitive_undo): Use CONS_TO_INTEGER.
5593 * xfns.c (Fx_window_property): Likewise.
5594 * xselect.c: Include <limits.h>.
5595 (x_own_selection, selection_data_to_lisp_data):
5596 Use INTEGER_TO_CONS.
5597 (x_handle_selection_request, x_handle_selection_clear)
5598 (x_get_foreign_selection, Fx_disown_selection_internal)
5599 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5600 (lisp_data_to_selection_data): Use cons_to_unsigned.
5601 (x_fill_property_data): Use cons_to_signed.
5602 Report values out of range.
5603
5604 Check for buffer and string overflow more precisely.
5605 * buffer.h (BUF_BYTES_MAX): New macro.
5606 * lisp.h (STRING_BYTES_MAX): New macro.
5607 * alloc.c (Fmake_string):
5608 * character.c (string_escape_byte8):
5609 * coding.c (coding_alloc_by_realloc):
5610 * doprnt.c (doprnt):
5611 * editfns.c (Fformat):
5612 * eval.c (verror):
5613 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5614 since they may not be the same number.
5615 * editfns.c (Finsert_char):
5616 * fileio.c (Finsert_file_contents):
5617 Likewise for BUF_BYTES_MAX.
5618
5619 * image.c: Use ptrdiff_t, not int, for sizes.
5620 (slurp_file): Switch from int to ptrdiff_t.
5621 All uses changed.
5622 (slurp_file): Check that file size fits in both size_t (for
5623 malloc) and ptrdiff_t (for sanity and safety).
5624
5625 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5626 if b->modtime has its maximal value.
5627
5628 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5629
5630 Don't assume time_t can fit into int.
5631 * buffer.h (struct buffer.modtime): Now time_t, not int.
5632 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5633 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5634
5635 Minor fixes for signed vs unsigned integers.
5636 * character.h (MAYBE_UNIFY_CHAR):
5637 * charset.c (maybe_unify_char):
5638 * keyboard.c (read_char, reorder_modifiers):
5639 XINT -> XFASTINT, since the integer must be nonnegative.
5640 * ftfont.c (ftfont_spec_pattern):
5641 * keymap.c (access_keymap, silly_event_symbol_error):
5642 XUINT -> XFASTINT, since the integer must be nonnegative.
5643 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5644 since it makes no difference and we prefer signed.
5645 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5646 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5647 nonnegative.
5648
5649 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5650
5651 * window.h (Fwindow_frame): Declare.
5652
5653 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5654
5655 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5656 (SPARE_MEMORY): Always define.
5657 (LARGE_REQUEST): Remove.
5658 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5659
5660 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5661
5662 * lisp.h: Move EXFUNS for Fframe_root_window,
5663 Fframe_first_window and Fset_frame_selected_window to window.h.
5664
5665 * window.h: Move EXFUNS for Fframe_root_window,
5666 Fframe_first_window and Fset_frame_selected_window here from
5667 lisp.h.
5668
5669 * frame.c (Fwindow_frame, Fframe_first_window)
5670 (Fframe_root_window, Fframe_selected_window)
5671 (Fset_frame_selected_window): Move to window.c.
5672 (Factive_minibuffer_window): Move to minibuf.c.
5673 (Fother_visible_frames_p): New function.
5674
5675 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5676
5677 * window.c (decode_window, decode_any_window): Move up in code.
5678 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5679 (inhibit_frame_unsplittable): Remove unused variable.
5680 (Fwindow_buffer): Move up and rewrite doc-string.
5681 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5682 (Fwindow_prev): New functions.
5683 (Fwindow_frame): Move here from frame.c. Accept any window as
5684 argument.
5685 (Fframe_root_window, Fframe_first_window)
5686 (Fframe_selected_window): Move here from frame.c. Accept frame
5687 or arbitrary window as argument. Update doc-strings.
5688 (Fminibuffer_window): Move up in code.
5689 (Fwindow_minibuffer_p): Move up in code and simplify.
5690 (Fset_frame_selected_window): Move here from frame.c.
5691 Marginal rewrite.
5692 (Fselected_window, select_window, Fselect_window): Move up in
5693 code. Minor doc-string fixes.
5694
5695 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5696
5697 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5698 Do not assume that spare memory exists; that assumption is valid
5699 only if SYSTEM_MALLOC.
5700 (LARGE_REQUEST): New macro, so that the issue of large requests
5701 is separated from the issue of spare memory.
5702
5703 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5704
5705 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5706 format. (Bug#8806)
5707
5708 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5709
5710 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5711 before statements.
5712
5713 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5714
5715 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5716
5717 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5718
5719 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5720 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5721
5722 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5723
5724 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5725
5726 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5727
5728 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5729 (x_clipboard_manager_save): Add return value.
5730 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5731 New error handlers.
5732 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5733 Obey Vx_select_enable_clipboard_manager. Catch errors in
5734 x_clipboard_manager_save (Bug#8779).
5735 (Vx_select_enable_clipboard_manager): New variable.
5736 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5737
5738 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5739
5740 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5741
5742 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5743
5744 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5745 in the current matrix if keep_current_p is non-zero.
5746
5747 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5748
5749 * bidi.c (bidi_level_of_next_char): Fix last change.
5750
5751 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5752
5753 Support bidi reordering of text covered by display properties.
5754
5755 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5756 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5757 (bidi_cache_search, bidi_cache_iterator_state)
5758 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5759 (bidi_level_of_next_char, bidi_move_to_visually_next):
5760 Support character positions inside a run of characters covered by a
5761 display string.
5762 (bidi_paragraph_init, bidi_resolve_explicit_1)
5763 (bidi_level_of_next_char): Call bidi_fetch_char and
5764 bidi_fetch_char_advance instead of FETCH_CHAR and
5765 FETCH_CHAR_ADVANCE.
5766 (bidi_init_it): Initialize new members.
5767 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5768 definitions.
5769 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5770 instead of using explicit *_CHAR codes.
5771 (bidi_resolve_explicit, bidi_resolve_weak):
5772 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5773 bidirectional text is supported only in multibyte buffers.
5774 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5775 it to initialize the frame_window_p member of struct bidi_it.
5776 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5777 (bidi_resolve_explicit, bidi_resolve_weak)
5778 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5779 bidi_it->nchars is non-positive.
5780 (bidi_level_of_next_char): Don't try to lookup the cache for the
5781 next/previous character if nothing is cached there yet, or if we
5782 were just reseat()'ed to a new position.
5783
5784 * xdisp.c (set_cursor_from_row): Set start and stop points
5785 according to the row's direction when priming the loop that looks
5786 for the glyph on which to display cursor.
5787 (single_display_spec_intangible_p): Function deleted.
5788 (display_prop_intangible_p): Reimplement to call
5789 handle_display_spec instead of single_display_spec_intangible_p.
5790 Accept 3 additional arguments needed by handle_display_spec.
5791 This fixes incorrect cursor motion across display property with complex
5792 values: lists, `(when COND...)' forms, etc.
5793 (single_display_spec_string_p): Support property values that are
5794 lists with the argument STRING its top-level element.
5795 (display_prop_string_p): Fix the condition for processing a
5796 property that is a list to be consistent with handle_display_spec.
5797 (handle_display_spec): New function, refactored from the
5798 last portion of handle_display_prop.
5799 (compute_display_string_pos): Accept additional argument
5800 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5801 value of a `display' property is a "replacing spec".
5802 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5803 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5804 the display property, but just return a value indicating whether
5805 the display property will replace the characters it covers.
5806 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5807 frame_window_p members of struct bidi_it.
5808 (compute_display_string_pos, compute_display_string_end):
5809 New functions.
5810 (push_it): Accept second argument POSITION, where pop_it should
5811 jump to continue iteration.
5812 (reseat_1): Initialize bidi_it.disp_pos.
5813
5814 * keyboard.c (adjust_point_for_property): Adjust the call to
5815 display_prop_intangible_p to its new signature.
5816
5817 * dispextern.h (struct bidi_it): New member frame_window_p.
5818 (bidi_init_it): Update prototypes.
5819 (display_prop_intangible_p): Update prototype.
5820 (compute_display_string_pos, compute_display_string_end):
5821 Declare prototypes.
5822 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5823 EMACS_INT.
5824
5825 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5826
5827 Malloc failure behavior now depends on size of allocation.
5828 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5829 * lisp.h: Change signatures accordingly.
5830 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5831 All callers changed. (Bug#8762)
5832
5833 * gnutls.c: Use Emacs's memory allocators.
5834 Without this change, the gnutls library would invoke malloc etc.
5835 directly, which causes problems on non-SYNC_INPUT hosts, and which
5836 runs afoul of improving memory_full behavior. (Bug#8761)
5837 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5838 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5839 xfree instead of the default malloc, realloc, free.
5840 (Fgnutls_boot): No need to check for memory allocation failure,
5841 since xmalloc does that for us.
5842
5843 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5844 * category.c (hash_get_category_set):
5845 * ccl.c (ccl_driver):
5846 * charset.c (Fdefine_charset_internal):
5847 * charset.h (struct charset.hash_index):
5848 * composite.c (get_composition_id, gstring_lookup_cache)
5849 (composition_gstring_put_cache):
5850 * composite.h (struct composition.hash_index):
5851 * dispextern.h (struct image.hash):
5852 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5853 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5854 (hashfn_equal, hashfn_user_defined, make_hash_table)
5855 (maybe_resize_hash_table, hash_lookup, hash_put)
5856 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5857 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5858 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5859 * image.c (make_image, search_image_cache, lookup_image)
5860 (xpm_put_color_table_h):
5861 * lisp.h (struct Lisp_Hash_Table):
5862 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5863 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5864 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5865 * alloc.c (allocate_vectorlike):
5866 Check for overflow in vector size calculations.
5867 * ccl.c (ccl_driver):
5868 Check for overflow when converting EMACS_INT to int.
5869 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5870 need to be updated by these changes.
5871 * fns.c (make_hash_table, maybe_resize_hash_table):
5872 Check for integer overflow with large hash tables.
5873 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5874 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5875 (SXHASH_REDUCE): New macro.
5876 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5877 Use it instead of discarding useful hash info with large hash values.
5878 (sxhash_float): New function.
5879 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5880 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5881 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5882 Rewrite to use FIXNUM_BITS, as this simplifies things.
5883 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5884 Adjust signatures to match updated version of code.
5885 (consing_since_gc): Now EMACS_INT, since a single hash table can
5886 use more than INT_MAX bytes.
5887
5888 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5889
5890 Make it possible to build with GCC-4.6+ -O2 -flto.
5891
5892 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5893
5894 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5895
5896 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5897 Call minibuffer-inactive-mode.
5898
5899 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5900
5901 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5902 Update dependencies.
5903
5904 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5905
5906 * data.c (init_data): Remove code for UTS, this system is not
5907 supported anymore.
5908
5909 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5910
5911 Don't force ./temacs to start in terminal mode.
5912
5913 * frame.c (make_initial_frame): Initialize faces in all cases, not
5914 only when CANNOT_DUMP is defined.
5915 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5916
5917 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5918
5919 * dispnew.c (add_window_display_history): Use const for the string
5920 pointer. Remove declaration, not needed.
5921
5922 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5923
5924 Use 'inline', not 'INLINE'.
5925 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5926 * alloc.c, fontset.c (INLINE): Remove.
5927 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5928 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5929 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5930 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5931 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5932
5933 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5934
5935 Make it possible to run ./temacs.
5936
5937 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5938 syms_of_callproc does the same thing. Remove test for
5939 "initialized", do it in the caller.
5940 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5941
5942 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5943
5944 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5945 (read_minibuf): Use get_minibuffer.
5946 (syms_of_minibuf): Use DEFSYM.
5947 (Qmetadata): New var.
5948 * data.c (Qbuffer): Don't make it static.
5949 (syms_of_data): Use DEFSYM.
5950
5951 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5952
5953 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5954 (CCL_CODE_MIN): New macro.
5955
5956 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5957
5958 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5959
5960 * eval.c (Qdebug): Now static.
5961 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5962 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5963 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5964
5965 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5966
5967 * image.c: Various fixes to ImageMagick code comments.
5968 (Fimagemagick_types): Doc fix.
5969
5970 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5971
5972 Minor fixes prompted by GCC 4.6.0 warnings.
5973
5974 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5975
5976 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5977 (x_clipboard_manager_save_all): Move extern decl to ...
5978 * xterm.h: ... here, so that it can be checked for consistency.
5979
5980 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5981
5982 * xselect.c (x_clipboard_manager_save_frame)
5983 (x_clipboard_manager_save_all): New functions.
5984 (Fx_clipboard_manager_save): Lisp function deleted.
5985
5986 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5987 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5988
5989 * xterm.h: Update prototype.
5990
5991 2011-05-28 William Xu <william.xwl@gmail.com>
5992
5993 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5994 exiting (Bug#8239).
5995
5996 2011-05-28 Jim Meyering <meyering@redhat.com>
5997
5998 Avoid a sign-extension bug in crypto_hash_function.
5999 * fns.c (to_uchar): Define.
6000 (crypto_hash_function): Use it to convert some newly-signed
6001 variables to unsigned, to avoid sign-extension bugs. For example,
6002 without this change, (md5 "truc") would evaluate to
6003 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6004 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6005 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6006
6007 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6008
6009 Integer overflow fixes.
6010
6011 * dbusbind.c: Serial number integer overflow fixes.
6012 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6013 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6014 to hold a serial number that is too large for a fixnum.
6015 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6016 Check for serial numbers out of range. Decode any serial number
6017 that was so large that it became a float. (Bug#8722)
6018
6019 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6020 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6021 Use XFASTINT rather than XUINT when numbers are nonnegative.
6022 (xd_append_arg, Fdbus_method_return_internal):
6023 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6024 arguments, check that Lisp number is nonnegative, rather than
6025 silently wrapping negative numbers around. (Bug#8722)
6026 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6027 (Bug#8722)
6028
6029 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6030
6031 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6032
6033 ccl: Add integer overflow checks.
6034 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6035 (IN_INT_RANGE): New macros.
6036 (ccl_driver): Use them to check for integer overflow when
6037 decoding a CCL program. Many of the new checks are whether XINT (x)
6038 fits in int; it doesn't always, on 64-bit hosts. The new version
6039 doesn't catch all possible integer overflows, but it's an
6040 improvement. (Bug#8719)
6041
6042 * alloc.c (make_event_array): Use XINT, not XUINT.
6043 There's no need for unsigned here.
6044
6045 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6046 This follows up to the 2011-05-06 change that substituted uintptr_t
6047 for EMACS_INT. This case wasn't caught back then.
6048
6049 Rework Fformat to avoid integer overflow issues.
6050 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6051 now (part of C89). Include <verify.h>.
6052 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6053 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6054 (Fformat): Avoid the prepass trying to compute sizes; it was only
6055 approximate and thus did not catch overflow reliably. Instead, walk
6056 through the format just once, formatting and computing sizes as we go,
6057 checking for integer overflow at every step, and allocating a larger
6058 buffer as needed. Keep track separately whether the format is
6059 multibyte. Keep only the most-recently calculated precision, rather
6060 than them all. Record whether each argument has been converted to
6061 string. Use EMACS_INT, not int, for byte and char and arg counts.
6062 Support field widths and precisions larger than INT_MAX. Avoid
6063 sprintf's undefined behavior with conversion specifications such as %#d
6064 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6065 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6066 formatting out-of-range floating point numbers with int
6067 formats. (Bug#8668)
6068
6069 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6070
6071 * data.c: Avoid integer truncation in expressions involving floats.
6072 * data.c: Include <intprops.h>.
6073 (arith_driver): When there's an integer overflow in an expression
6074 involving floating point, convert the integers to floating point
6075 so that the resulting value does not suffer from catastrophic
6076 integer truncation. For example, on a 64-bit host (* 4
6077 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6078 Do not rely on undefined behavior after integer overflow.
6079
6080 merge count_size_as_multibyte, parse_str_to_multibyte
6081 * character.c, character.h (count_size_as_multibyte):
6082 Rename from parse_str_to_multibyte; all uses changed.
6083 Check for integer overflow.
6084 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6085 since it's now a duplicate of the other. This is more of
6086 a character than a buffer op, so better that it's in character.c.
6087 * fns.c, print.c: Adjust to above changes.
6088
6089 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6090
6091 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6092
6093 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6094
6095 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6096 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6097 (x_clipboard_manager_save): Now static.
6098 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6099
6100 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6101 (crypto_hash_function): Now static.
6102 Fix pointer signedness problems. Avoid unnecessary initializations.
6103
6104 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6105
6106 * termhooks.h (Vselection_alist): Make it terminal-local.
6107
6108 * terminal.c (create_terminal): Initialize it.
6109
6110 * xselect.c: Support for clipboard managers.
6111 (Vselection_alist): Move to termhooks.h as terminal-local var.
6112 (LOCAL_SELECTION): New macro.
6113 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6114 (symbol_to_x_atom): Remove gratuitous arg.
6115 (x_handle_selection_request, lisp_data_to_selection_data)
6116 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6117 (x_own_selection, x_get_local_selection, x_convert_selection):
6118 New arg, specifying work frame. Use terminal-local Vselection_alist.
6119 (some_frame_on_display): Delete unused function.
6120 (Fx_own_selection_internal, Fx_get_selection_internal)
6121 (Fx_disown_selection_internal, Fx_selection_owner_p)
6122 (Fx_selection_exists_p): New optional frame arg.
6123 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6124 (x_handle_selection_clear): Don't treat other terminals with the
6125 same keyboard specially. Use the terminal-local Vselection_alist.
6126 (x_clear_frame_selections): Use Frun_hook_with_args.
6127
6128 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6129
6130 * xterm.h: Add support for those atoms.
6131
6132 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6133
6134 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6135 (converted_selections, conversion_fail_tag): New global variables.
6136 (x_selection_request_lisp_error): Free the above.
6137 (x_get_local_selection): Remove unnecessary code.
6138 (x_reply_selection_request): Args changed; handle arbitrary array
6139 of converted selections stored in converted_selections.
6140 Separate the XChangeProperty and SelectionNotify steps.
6141 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6142 (x_convert_selection): New function.
6143 (x_handle_selection_event): Simplify.
6144 (x_get_foreign_selection): Don't ignore incoming requests while
6145 waiting for an answer; this will fail when we implement
6146 SAVE_TARGETS, and seems unnecessary anyway.
6147 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6148 (Vx_sent_selection_functions): Doc fix.
6149
6150 2011-05-26 Leo Liu <sdl.web@gmail.com>
6151
6152 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6153
6154 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6155
6156 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6157
6158 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6159 for fringe update if it has periodic bitmap.
6160 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6161 and fringe_bitmap_periodic_p.
6162
6163 * fringe.c (get_fringe_bitmap_data): New function.
6164 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6165 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6166 row. Mark glyph row for fringe update if periodicity changed.
6167
6168 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6169 for fringe update unless it has periodic bitmap.
6170
6171 2011-05-25 Kenichi Handa <handa@m17n.org>
6172
6173 * xdisp.c (get_next_display_element): Set correct it->face_id for
6174 a static composition.
6175
6176 2011-05-24 Leo Liu <sdl.web@gmail.com>
6177
6178 * deps.mk (fns.o):
6179 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6180
6181 * fns.c (crypto_hash_function, Fsha1): New function.
6182 (Fmd5): Use crypto_hash_function.
6183 (syms_of_fns): Add Ssha1.
6184
6185 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6186
6187 * gnutls.c: Remove unused macros.
6188 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6189 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6190 Remove macros that are defined and never used.
6191 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6192
6193 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6194
6195 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6196 (Fx_get_selection_internal): Minor cleanup.
6197 (Fx_own_selection_internal): Rename arguments for consistency with
6198 select.el.
6199
6200 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6201
6202 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6203
6204 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6205
6206 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6207
6208 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6209
6210 * dispnew.c (scrolling_window): Don't exclude the case that the
6211 last enabled row in the desired matrix touches the bottom boundary.
6212
6213 2011-05-21 Glenn Morris <rgm@gnu.org>
6214
6215 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6216 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6217 and add some more files.
6218
6219 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6220
6221 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6222 report_file_error introduced by the change from 2011-05-07.
6223
6224 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6225
6226 * systime.h (Time): Define only if emacs is defined.
6227 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6228 where the include path doesn't have X11/X.h by default. See
6229 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6230
6231 2011-05-20 Kenichi Handa <handa@m17n.org>
6232
6233 * composite.c (find_automatic_composition): Fix previous change.
6234
6235 2011-05-20 Glenn Morris <rgm@gnu.org>
6236
6237 * lisp.mk: New file, split from Makefile.in.
6238 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6239 (shortlisp): Remove.
6240 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6241
6242 2011-05-19 Glenn Morris <rgm@gnu.org>
6243
6244 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6245 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6246 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6247 (lisp): Set the order to that of loadup.el.
6248 (shortlisp): Make it a copy of $lisp.
6249 (SOME_MACHINE_LISP): Remove.
6250 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6251 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6252
6253 2011-05-18 Kenichi Handa <handa@m17n.org>
6254
6255 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6256 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6257 (find_automatic_composition): Mostly rewrite for efficiency.
6258
6259 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6260
6261 * makefile.w32-in: Update dependencies.
6262
6263 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6264
6265 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6266 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6267
6268 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6269
6270 Fix some integer overflow issues, such as string length overflow.
6271
6272 * insdel.c (count_size_as_multibyte): Check for string overflow.
6273
6274 * character.c (lisp_string_width): Check for string overflow.
6275 Use EMACS_INT, not int, for string indexes and lengths; in
6276 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6277 the resulting string length overflows an EMACS_INT; instead,
6278 report a string overflow if no precision given. When checking for
6279 precision exhaustion, use a check that cannot possibly have
6280 integer overflow. (Bug#8675)
6281 * character.h (lisp_string_width): Adjust to new signature.
6282
6283 * alloc.c (string_overflow): New function.
6284 (Fmake_string): Use it. This doesn't change behavior, but saves
6285 a few bytes and will simplify future changes.
6286 * character.c (string_escape_byte8): Likewise.
6287 * lisp.h (string_overflow): New decl.
6288
6289 Fixups, following up to the user-interface timestamp change.
6290 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6291 for UI timestamps, instead of unsigned long.
6292 * msdos.c (mouse_get_pos): Likewise.
6293 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6294 * w32gui.h (Time): Define by including "systime.h" rather than by
6295 declaring it ourselves. (Bug#8664)
6296
6297 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6298 * image.c (clear_image_cache): Likewise.
6299
6300 * term.c (term_mouse_position): Don't assume time_t wraparound.
6301
6302 Be more systematic about user-interface timestamps.
6303 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6304 and sometimes 'EMACS_UINT', to represent these timestamps.
6305 This change causes it to use 'Time' uniformly, as that's what X uses.
6306 This makes the code easier to follow, and makes it easier to catch
6307 integer overflow bugs such as Bug#8664.
6308 * frame.c (Fmouse_position, Fmouse_pixel_position):
6309 Use Time, not unsigned long, for user-interface timestamps.
6310 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6311 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6312 * keyboard.h (last_event_timestamp): Likewise.
6313 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6314 * menu.h (xmenu_show): Likewise.
6315 * term.c (term_mouse_position): Likewise.
6316 * termhooks.h (struct input_event.timestamp): Likewise.
6317 (struct terminal.mouse_position_hook): Likewise.
6318 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6319 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6320 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6321 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6322 what it was before.
6323 * menu.h, termhooks.h: Include "systime.h", for Time.
6324
6325 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6326 Don't assume that the difference between two unsigned long values
6327 can fit into an integer. At this point, we know button_down_time
6328 <= event->timestamp, so the difference must be nonnegative, so
6329 there's no need to cast the result if double-click-time is
6330 nonnegative, as it should be; check that it's nonnegative, just in
6331 case. This bug is triggered when events are more than 2**31 ms
6332 apart (about 25 days). (Bug#8664)
6333
6334 * xselect.c (last_event_timestamp): Remove duplicate decl.
6335 (x_own_selection): Remove needless cast to unsigned long.
6336
6337 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6338 that always fit in int. Use a sentinel instead of a counter, to
6339 avoid a temp and to allay GCC's concerns about possible int overflow.
6340 * frame.h (struct frame): Use int for menu_bar_items_used
6341 instead of EMACS_INT, since it always fits in int.
6342
6343 * menu.c (grow_menu_items): Check for int overflow.
6344
6345 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6346
6347 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6348 Before, the code was not consistent. These values cannot exceed
6349 2**31 - 1 so there's no need to make them unsigned.
6350 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6351 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6352 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6353 as modifiers.
6354 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6355
6356 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6357 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6358 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6359 presumably because the widths might not match.
6360
6361 * window.c (size_window): Avoid needless test at loop start.
6362
6363 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6364
6365 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6366
6367 2011-05-12 Drew Adams <drew.adams@oracle.com>
6368
6369 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6370
6371 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6372
6373 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6374 `width' to `bar_area_x' and `bar_area_width', respectively.
6375 (x_scroll_run): Take account of fringe background extension.
6376
6377 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6378 Rename local vars `left' and `width' to `bar_area_x' and
6379 `bar_area_width', respectively.
6380 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6381 background extension.
6382
6383 2011-05-10 Jim Meyering <meyering@redhat.com>
6384
6385 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6386
6387 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6388
6389 * image.c (Finit_image_library): Return t for built-in image types,
6390 like pbm and xbm. (Bug#8640)
6391
6392 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6393
6394 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6395
6396 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6397
6398 * w32console.c (Fset_screen_color): Doc fix.
6399 (Fget_screen_color): New function.
6400 (syms_of_ntterm): Defsubr it.
6401
6402 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6403 unlink the temporary file if Fcall_process didn't create it in the
6404 first place.
6405 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6406 child process will be redirected to a file specified with `:file'.
6407 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6408 cue to call_process_cleanup not to close that handle.
6409
6410 2011-05-07 Ben Key <bkey76@gmail.com>
6411
6412 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6413 one of two shell specific rules, either bootstrap-temacs-CMD or
6414 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6415 to the previous implementation of the bootstrap-temacs rule.
6416 The bootstrap-temacs-CMD rule is similar to the previous
6417 implementation of the bootstrap-temacs rule except that it
6418 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6419 variable.
6420
6421 These changes, along with some changes to nt/configure.bat,
6422 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6423 earlier fix to add support for --cflags and --ldflags options
6424 that include quotes so that it works whether make uses cmd or
6425 sh as the shell.
6426
6427 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6428
6429 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6430 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6431 is a constant.
6432 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6433 a string. Handle both cases.
6434 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6435 (Fdbus_register_method): Use Qinvalid_function.
6436
6437 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6438
6439 * makefile.w32-in: Update dependencies.
6440 (LISP_H): Add inttypes.h and stdin.h.
6441 (PROCESS_H): Add unistd.h.
6442
6443 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6444
6445 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6446 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6447
6448 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6449
6450 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6451
6452 * term.c (vfatal): Remove stray call to va_end.
6453 It's not needed and the C Standard doesn't allow it here anyway.
6454
6455 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6456 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6457
6458 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6459 bytes.
6460
6461 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6462
6463 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6464
6465 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6466
6467 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6468
6469 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6470
6471 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6472 * charset.c (Fdefine_charset_internal): Don't initialize
6473 charset.code_space[15]. The value was garbage, on hosts with
6474 32-bit int (Bug#8600).
6475
6476 * lread.c (read_integer): Be more consistent with string-to-number.
6477 Use string_to_number to do the actual conversion; this avoids
6478 rounding errors and fixes some other screwups. Without this fix,
6479 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6480 (digit_to_number): Move earlier, for benefit of read_integer.
6481 Return -1 if the digit is out of range for the base, -2 if it is
6482 not a digit in any supported base. (Bug#8602)
6483
6484 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6485
6486 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6487 to match comment at start of function. This also removes a
6488 GCC warning about overflow in a 32+64-bit port.
6489
6490 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6491
6492 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6493 Reported by Stefan Monnier in
6494 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6495 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6496 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6497
6498 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6499 (EMACS_UINTPTR): Likewise, with uintptr_t.
6500
6501 * lisp.h: Prefer 64-bit EMACS_INT if available.
6502 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6503 on 32-bit hosts that have 64-bit int, so that they can access
6504 large files.
6505 However, temporarily disable this change unless the temporary
6506 symbol WIDE_EMACS_INT is defined.
6507
6508 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6509
6510 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6511 This removes an assumption that EMACS_INT and long are the same
6512 width as pointers. The assumption is true for Emacs porting targets
6513 now, but we want to make other targets possible.
6514 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6515 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6516 In the rest of the code, change types of integers that hold casted
6517 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6518 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6519 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6520 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6521 No need to cast type when ORing.
6522 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6523 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6524 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6525 assume EMACS_INT is the same width as char *.
6526 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6527 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6528 Remove no-longer-needed casts.
6529 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6530 (xg_tool_bar_help_callback, xg_make_tool_item):
6531 Use EMACS_INTPTR to hold an integer
6532 that will be cast to void *; this can avoid a GCC warning
6533 if EMACS_INT is not the same width as void *.
6534 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6535 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6536 (current_message_1, set_message_1):
6537 Use a local to convert to proper width without a cast.
6538 * xmenu.c (dialog_selection_callback): Likewise.
6539
6540 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6541 Also, don't assume VALBITS / RAND_BITS is less than 5,
6542 and don't rely on undefined behavior when shifting a 1 left into
6543 the sign bit.
6544 * lisp.h (get_random): Change signature to match.
6545
6546 * lread.c (hash_string): Use size_t, not int, for hash computation.
6547 Normally we prefer signed values; but hashing is special, because
6548 it's better to use unsigned division on hash table sizes so that
6549 the remainder is nonnegative. Also, size_t is the natural width
6550 for hashing into memory. The previous code used 'int', which doesn't
6551 retain enough info to hash well into very large tables.
6552 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6553
6554 * dbusbind.c: Don't possibly lose pointer info when converting.
6555 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6556 Use XPNTR rather than XHASH, so that the high-order bits of
6557 the pointer aren't lost when converting through void *.
6558
6559 * eval.c (Fautoload): Don't double-shift a pointer.
6560
6561 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6562
6563 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6564
6565 * gnutls.c (DEF_GNUTLS_FN):
6566 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6567
6568 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6569
6570 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6571 marker. (Bug#8610)
6572
6573 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6574
6575 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6576 New version that can reserve upto 2GB of heap space.
6577
6578 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6579
6580 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6581
6582 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6583
6584 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6585 `gnutls_certificate_set_x509_key_file'.
6586
6587 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6588
6589 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6590 Update dependencies.
6591
6592 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6593
6594 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6595 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6596 Remove unused parameter `fildes'.
6597 * process.c (read_process_output, send_process): Don't pass it.
6598
6599 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6600
6601 Fix previous change: the library cache is defined in w32.c.
6602 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6603 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6604
6605 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6606
6607 Implement dynamic loading of GnuTLS on Windows.
6608
6609 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6610 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6611 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6612 Declare.
6613
6614 * gnutls.c (Qgnutls_dll): Define.
6615 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6616 (gnutls_*): Declare function pointers.
6617 (init_gnutls_functions): New function to initialize function pointers.
6618 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6619 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6620 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6621 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6622 (emacs_gnutls_write, emacs_gnutls_read)
6623 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6624 (Fgnutls_available_p): New function.
6625 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6626 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6627 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6628
6629 * image.c: Include w32.h.
6630 (Vimage_type_cache): Delete.
6631 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6632 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6633 (w32_delayed_load): Move to w32.c.
6634
6635 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6636
6637 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6638 (w32_delayed_load): Move from image.c. When loading a library, record
6639 its filename in the :loaded-from property of the library id.
6640 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6641 Initialize and staticpro them.
6642 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6643
6644 * process.c: Include lisp.h before w32.h, not after.
6645 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6646 instead of gnutls_record_check_pending.
6647
6648 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6649
6650 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6651
6652 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6653 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6654 as passed in.
6655
6656 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6657
6658 * xterm.c (x_set_frame_alpha): Do not set property on anything
6659 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6660
6661 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6662
6663 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6664
6665 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6666
6667 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6668 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6669 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6670 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6671 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6672 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6673 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6674 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6675 (Qgnutls_bootprop_callbacks_verify): Make static.
6676
6677 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6678
6679 * callproc.c: Indentation fixup.
6680
6681 * sysdep.c (wait_for_termination_1): Make static.
6682 (wait_for_termination, interruptible_wait_for_termination):
6683 Move after wait_for_termination_1.
6684
6685 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6686
6687 * sysdep.c (interruptible_wait_for_termination): New function
6688 which is like wait_for_termination, but allows keyboard
6689 interruptions.
6690
6691 * callproc.c (Fcall_process): Add (:file "file") as an option for
6692 the STDOUT buffer.
6693 (Fcall_process_region): Ditto.
6694
6695 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6696
6697 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6698 rather than `XVECTOR (FOO)->size'.
6699
6700 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6701 inttypes.h, as a gnulib replacement is used if it not available in
6702 system headers.
6703
6704 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6705
6706 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6707 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6708 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6709
6710 * coding.c (coding_alloc_by_realloc): Error out if destination
6711 will grow beyond MOST_POSITIVE_FIXNUM.
6712 (decode_coding_emacs_mule): Abort if there isn't enough place in
6713 charbuf for the composition carryover bytes. Reserve an extra
6714 space for up to 2 characters produced in a loop.
6715 (decode_coding_iso_2022): Abort if there isn't enough place in
6716 charbuf for the composition carryover bytes.
6717
6718 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6719
6720 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6721 aborting when %lld or %lll format is passed.
6722 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6723 %llo or %llx format is passed. (Bug#8545)
6724
6725 * window.c (window_scroll_line_based): Use a marker instead of
6726 simple variables to record original value of point. (Bug#7952)
6727
6728 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6729 produced by %s or %c overflows available buffer space. (Bug#8545)
6730
6731 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6732
6733 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6734 (SIZE_MAX): Move defn after all includes, as they might #define it.
6735
6736 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6737
6738 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6739
6740 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6741
6742 * keyboard.c (Qdelayed_warnings_hook): Define.
6743 (command_loop_1): Run `delayed-warnings-hook'
6744 if Vdelayed_warnings_list is non-nil.
6745 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6746 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6747
6748 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6749
6750 * doprnt.c (doprnt): Don't return value smaller than the buffer
6751 size if the message was truncated. (Bug#8545).
6752
6753 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6754
6755 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6756 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6757
6758 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6759
6760 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6761
6762 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6763
6764 * makefile.w32-in: Update dependencies.
6765
6766 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6767
6768 Improve `doprnt' and its usage. (Bug#8545)
6769 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6770 `format_end'. Remove support for %l as a conversion specifier.
6771 Don't use xrealloc. Improve diagnostics when the %l size modifier
6772 is used. Update the commentary.
6773
6774 * eval.c (verror): Simplify calculation of size_t.
6775
6776 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6777 messages.
6778
6779 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6780
6781 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6782 change.
6783
6784 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6785
6786 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6787 This makes this file independent of the recent pseudovector change.
6788
6789 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6790
6791 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6792
6793 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6794 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6795 Remove unused local.
6796 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6797
6798 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6799 GCC 4.6.0 optimizes based on type-based alias analysis.
6800 For example, if b is of type struct buffer * and v of type struct
6801 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6802 != &v->size, and therefore "v->size = 1; b->size = 2; return
6803 v->size;" must therefore return 1. This assumption is incorrect
6804 for Emacs, since it type-puns struct Lisp_Vector * with many other
6805 types. To fix this problem, this patch adds a new type struct
6806 vectorlike_header that documents the constraints on layout of vectors
6807 and pseudovectors, and helps optimizing compilers not get fooled
6808 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6809 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6810 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6811 the size member.
6812 (XSETPVECTYPE): Rewrite in terms of new macro.
6813 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6814 This is a bit clearer, and further avoids the possibility of
6815 undesirable aliasing.
6816 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6817 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6818 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6819 since Lisp_Subr is a special case (no "next" field).
6820 (ASIZE): Now uses header.size rather than size.
6821 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6822 to avoid the hassle of writing XVECTOR (foo)->header.size.
6823 (struct vectorlike_header): New type.
6824 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6825 object, to help avoid aliasing.
6826 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6827 (SUBRP): Likewise, since Lisp_Subr is a special case.
6828 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6829 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6830 (struct Lisp_Hash_Table): Combine first two members into a single
6831 struct vectorlike_header member. All uses of "size" and "next" members
6832 changed to be "header.size" and "header.next".
6833 * buffer.h (struct buffer): Likewise.
6834 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6835 * frame.h (struct frame): Likewise.
6836 * process.h (struct Lisp_Process): Likewise.
6837 * termhooks.h (struct terminal): Likewise.
6838 * window.c (struct save_window_data, struct saved_window): Likewise.
6839 * window.h (struct window): Likewise.
6840 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6841 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6842 * buffer.c (init_buffer_once): Likewise.
6843 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6844 special case.
6845 * process.c (Fformat_network_address): Use local var for size,
6846 for brevity.
6847
6848 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6849
6850 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6851 * data.c (atof): Remove decl; no longer used or needed.
6852 (digit_to_number): Move to lread.c.
6853 (Fstring_to_number): Use new string_to_number function, to be
6854 consistent with how the Lisp reader treats infinities and NaNs.
6855 Do not assume that floating-point numbers represent EMACS_INT
6856 without losing information; this is not true on most 64-bit hosts.
6857 Avoid double-rounding errors, by insisting on integers when
6858 parsing non-base-10 numbers, as the documentation specifies.
6859 * lisp.h (string_to_number): New decl, replacing ...
6860 (isfloat_string): Remove.
6861 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6862 (read1): Do not accept +. and -. as integers; this
6863 appears to have been a coding error. Similarly, do not accept
6864 strings like +-1e0 as floating point numbers. Do not report
6865 overflow for integer overflows unless the base is not 10 which
6866 means we have no simple and reliable way to continue.
6867 Break out the floating-point parsing into a new
6868 function string_to_number, so that Fstring_to_number parses
6869 floating point numbers consistently with the Lisp reader.
6870 (digit_to_number): Move here from data.c. Make it static inline.
6871 (E_CHAR, EXP_INT): Remove, replacing with ...
6872 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6873 (string_to_number): New function, replacing isfloat_string.
6874 This function checks for valid syntax and produces the resulting
6875 Lisp float number too. Rework it so that string-to-number
6876 no longer mishandles examples like "1.0e+". Use strtoumax,
6877 so that overflow for non-base-10 numbers is reported only when
6878 there's no portable and simple way to convert to floating point.
6879
6880 * textprop.c (set_text_properties_1): Rewrite for clarity,
6881 and to avoid GCC warning about integer overflow.
6882
6883 * intervals.h (struct interval): Use EMACS_INT for members
6884 where EMACS_UINT might cause problems. See
6885 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6886 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6887 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6888 All uses changed.
6889 (offset_intervals): Tell GCC not to worry about length overflow
6890 when negating a negative length.
6891
6892 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6893 (overrun_check_free): Likewise.
6894
6895 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6896 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6897 word size.
6898
6899 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6900 (gnutls_make_error): Rename local to avoid shadowing.
6901 (gnutls_emacs_global_deinit): ifdef out; not used.
6902 (Fgnutls_boot): Use const for pointer to readonly storage.
6903 Comment out unused local. Fix pointer signedness problems.
6904
6905 * lread.c (openp): Don't stuff size_t into an 'int'.
6906 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6907 about possible signed overflow.
6908
6909 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6910 (GDK_KEY_g): Don't define if already defined.
6911 (xg_prepare_tooltip): Avoid pointer signedness problem.
6912 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6913
6914 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6915 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6916
6917 * xfns.c (Fx_window_property): Simplify a bit,
6918 to make a bit faster and to avoid GCC 4.6.0 warning.
6919 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6920
6921 * fns.c (internal_equal): Don't assume size_t fits in int.
6922
6923 * alloc.c (compact_small_strings): Tighten assertion a little.
6924
6925 Replace pEd with more-general pI, and fix some printf arg casts.
6926 * lisp.h (pI): New macro, generalizing old pEd macro to other
6927 conversion specifiers. For example, use "...%"pI"d..." rather
6928 than "...%"pEd"...".
6929 (pEd): Remove. All uses replaced with similar uses of pI.
6930 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6931 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6932 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6933 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6934 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6935 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6936 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6937 64-bit hosts.
6938 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6939 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6940 * print.c (safe_debug_print, print_object): Likewise.
6941 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6942 to int.
6943 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6944 avoiding the 0 flag, which is not portable.
6945 * process.c (Fmake_network_process): Use pI to avoid cast.
6946 * region-cache.c (pp_cache): Likewise.
6947 * xdisp.c (decode_mode_spec): Likewise.
6948 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6949 behavior on 64-bit hosts with printf arg.
6950 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6951 (x_stop_queuing_selection_requests): Likewise.
6952 (x_get_window_property): Don't truncate byte count to an 'int'
6953 when tracing.
6954
6955 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6956 here, since it parses constructs like leading '-' and spaces,
6957 which are not wanted; and it overflows with large numbers.
6958 Instead, simply match F[0-9]+, which is what is wanted anyway.
6959
6960 * alloc.c: Remove unportable assumptions about struct layout.
6961 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6962 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6963 (allocate_vectorlike, make_pure_vector): Use the new macros,
6964 plus offsetof, to remove unportable assumptions about struct layout.
6965 These assumptions hold on all porting targets that I know of, but
6966 they are not guaranteed, they're easy to remove, and removing them
6967 makes further changes easier.
6968
6969 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6970 This doesn't fix a bug but makes the code clearer.
6971 (string_overrun_cookie): Now const. Use initializers that
6972 don't formally overflow signed char, to avoid warnings.
6973 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6974 can cause Emacs to crash when string overrun checking is enabled.
6975 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6976 multiple of sizeof (EMACS_INT); it need not be, if
6977 alignof(EMACS_INT) < sizeof (EMACS_INT).
6978 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6979
6980 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6981
6982 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6983
6984 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6985
6986 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6987 supposed to be handshaking. (Bug#8556)
6988 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6989
6990 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6991
6992 * lisp.h (Qdebug): List symbol.
6993 * eval.c (Qdebug): Restore global linkage.
6994 * keyboard.c (debug-on-event): New variable.
6995 (handle_user_signal): Break into debugger when debug-on-event
6996 matches the current signal symbol.
6997
6998 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6999
7000 * alloc.c (check_sblock, check_string_bytes)
7001 (check_string_free_list): Convert to standard C.
7002
7003 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7004
7005 * w32.c (emacs_gnutls_push): Fix typo.
7006
7007 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7008
7009 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7010 "cast to pointer from integer of different size".
7011
7012 Improve doprnt and its use in verror. (Bug#8545)
7013 * doprnt.c (doprnt): Document the set of format control sequences
7014 supported by the function. Use SAFE_ALLOCA instead of always
7015 using `alloca'.
7016
7017 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7018 is one byte too soon. Don't use xrealloc; instead xfree and
7019 xmalloc anew.
7020
7021 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7022
7023 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7024 callbacks stage.
7025
7026 * gnutls.c: Renamed global_initialized to
7027 gnutls_global_initialized. Added internals for the
7028 :verify-hostname-error, :verify-error, and :verify-flags
7029 parameters of `gnutls-boot' and documented those parameters in the
7030 docstring. Start callback support.
7031 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7032 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7033 on error. Return error code.
7034 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7035 (emacs_gnutls_read): Likewise.
7036 (Fgnutls_boot): Return handshake error code.
7037 (emacs_gnutls_handle_error): New function.
7038 (wsaerror_to_errno): Likewise.
7039
7040 * w32.h (emacs_gnutls_pull): Add prototype.
7041 (emacs_gnutls_push): Likewise.
7042
7043 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7044 (emacs_gnutls_push): Likewise.
7045
7046 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7047
7048 * process.c (wait_reading_process_output): Check if GnuTLS
7049 buffered some data internally if no FDs are set for TLS
7050 connections.
7051
7052 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7053 (LIBS): Link to USER_LIBS.
7054 ($(BLD)/gnutls.$(0)): New target.
7055
7056 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7057
7058 * xdisp.c (handle_single_display_spec): Rename the
7059 display_replaced_before_p argument into display_replaced_p, to
7060 make it consistent with the commentary. Fix typos in the
7061 commentary.
7062
7063 * textprop.c (syms_of_textprop): Remove dead code.
7064 (copy_text_properties): Delete obsolete commentary about an
7065 interface that was deleted long ago. Fix typos in the description
7066 of arguments.
7067
7068 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7069 to changes in oldXMenu/XMenu.h from 2011-04-16.
7070 <menu_help_message, prev_menu_help_message>: Constify.
7071 (IT_menu_make_room): menu->help_text is now `const char **';
7072 adjust.
7073
7074 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7075 to changes in oldXMenu/XMenu.h from 2011-04-16.
7076 (struct XMenu): Declare `help_text' `const char **'.
7077
7078 * xfaces.c <Qunspecified>: Make extern again.
7079
7080 * syntax.c: Include sys/types.h before including regex.h, as
7081 required by Posix.
7082
7083 * doc.c (get_doc_string): Improve the format passed to `error'.
7084
7085 * doprnt.c (doprnt): Improve commentary.
7086
7087 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7088
7089 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7090 them with etags.
7091
7092 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7093 changes in globals.h immediately force recompilation.
7094 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7095 $(CURDIR)/s/ms-w32.h.
7096 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7097
7098 * character.c (Fchar_direction): Function deleted.
7099 (syms_of_character): Don't defsubr it.
7100 <char-direction-table>: Deleted.
7101
7102 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7103
7104 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7105 * doprnt.c: Include limits.h.
7106 (SIZE_MAX): New macro.
7107 (doprnt): Return a size_t value. 2nd arg is now size_t.
7108 Many local variables are now size_t instead of int or unsigned.
7109 Improve overflow protection. Support `l' modifier for integer
7110 conversions. Support %l conversion. Don't assume an EMACS_INT
7111 argument for integer conversions and for %c.
7112
7113 * lisp.h (doprnt): Restore prototype.
7114
7115 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7116 $(SRC)/character.h.
7117
7118 * Makefile.in (base_obj): Add back doprnt.o.
7119
7120 * deps.mk (doprnt.o): Add back prerequisites.
7121 (callint.o): Depend on character.h.
7122
7123 * eval.c (internal_lisp_condition_case): Include the handler
7124 representation in the error message.
7125 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7126 when breaking from the loop.
7127
7128 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7129
7130 * callint.c (Fcall_interactively): When displaying error message
7131 about invalid control letter, pass the character's codepoint, not
7132 a pointer to its multibyte form. Improve display of the character
7133 in octal and display also its hex code.
7134
7135 * character.c (char_string): Use %x to display the (unsigned)
7136 codepoint of an invalid character, to avoid displaying a bogus
7137 negative value.
7138
7139 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7140 `error', not SYMBOL_NAME itself.
7141
7142 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7143 character arguments to `error'.
7144
7145 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7146 to `error' in error message about FINAL_CHAR argument. Make sure
7147 FINAL_CHAR is a character, and use %c when it is passed as
7148 argument to `error'.
7149
7150 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7151
7152 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7153
7154 * w32.c: Include <time.h>.
7155 (sys_localtime): New function.
7156
7157 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7158
7159 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7160
7161 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7162
7163 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7164
7165 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7166 zombies (Bug#8467).
7167
7168 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7169
7170 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7171 gl_state.e_property when gl_state.object is Qt.
7172
7173 * insdel.c (make_gap_larger): Remove limitation of buffer size
7174 to <= INT_MAX.
7175
7176 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7177
7178 * xdisp.c (lookup_glyphless_char_display)
7179 (produce_glyphless_glyph): Handle cons cell entry in
7180 glyphless-char-display.
7181 (Vglyphless_char_display): Document it.
7182
7183 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7184 glyphless-char-display.
7185
7186 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7187
7188 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7189
7190 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7191
7192 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7193 definition for no-X builds.
7194
7195 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7196
7197 Static checks with GCC 4.6.0 and non-default toolkits.
7198
7199 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7200
7201 * process.c (keyboard_bit_set): Define only if SIGIO.
7202 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7203 (send_process): Repair possible setjmp clobbering.
7204
7205 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7206
7207 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7208
7209 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7210
7211 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7212 Define only if needed.
7213
7214 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7215 by pacifying GCC about it. Maybe it's time to retire it?
7216 * xfaces.c (USG, __TIMEVAL__): Likewise.
7217
7218 * dispextern.h (struct redisplay_interface): Rename param
7219 to avoid shadowing.
7220 * termhooks.h (struct terminal): Likewise.
7221 * xterm.c (xembed_send_message): Likewise.
7222
7223 * insdel.c (make_gap_smaller): Define only if
7224 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7225
7226 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7227 it.
7228
7229 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7230 so that we aren't warned about unused symbols.
7231
7232 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7233
7234 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7235
7236 * xfns.c (x_real_positions): Mark locals as initialized.
7237
7238 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7239
7240 * xterm.c: Fix problems found by static analysis with other toolkits.
7241 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7242 (x_dispatch_event): Declare static if USE_GTK, and
7243 define if USE_GTK || USE_X_TOOLKIT.
7244 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7245 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7246 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7247 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7248
7249 * xmenu.c (menu_help_callback): Pointer type fixes.
7250 Use const pointers when pointing at readonly data. Avoid pointer
7251 signedness clashes.
7252 (FALSE): Remove unused macro.
7253 (update_frame_menubar): Remove unused decl.
7254
7255 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7256
7257 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7258 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7259 (single_menu_item): Rename local to avoid shadowing.
7260
7261 * keyboard.c (make_lispy_event): Remove unused local var.
7262
7263 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7264 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7265
7266 * bitmaps: Change bitmaps from unsigned char back to the X11
7267 compatible char. Avoid the old compiler warnings about
7268 out-of-range initializers by using, for example, '\xab' rather
7269 than 0xab.
7270
7271 * xgselect.c (xgselect_initialize): Check vs interface
7272 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7273
7274 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7275
7276 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7277 to read-only memory.
7278
7279 * fns.c (vector): Remove; this old hack is no longer needed.
7280
7281 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7282 Remove unused var.
7283 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7284
7285 * xrdb.c (x_load_resources): Omit unused local.
7286
7287 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7288 (x_window): Rename locals to avoid shadowing.
7289 (USG): Use the kludged USG macro, to pacify gcc.
7290
7291 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7292 (x_term_init): Remove local to avoid shadowing.
7293
7294 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7295
7296 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7297 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7298
7299 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7300
7301 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7302
7303 Fix regex.c, syntax.c and friends for buffers > 2GB.
7304 * syntax.h (struct gl_state_s): Declare character position members
7305 EMACS_INT.
7306
7307 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7308
7309 * textprop.c (verify_interval_modification, interval_of):
7310 Declare arguments EMACS_INT.
7311
7312 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7313 EMACS_INT.
7314
7315 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7316
7317 * indent.c (Fvertical_motion): Local variable it_start is now
7318 EMACS_INT.
7319
7320 * regex.c (re_match, re_match_2, re_match_2_internal)
7321 (bcmp_translate, regcomp, regexec, print_double_string)
7322 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7323 (re_compile_pattern, re_exec): Declare arguments and local
7324 variables `size_t' and `ssize_t' and return values `regoff_t', as
7325 appropriate.
7326 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7327 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7328 <compile_stack_type>: `size' and `avail' are now `size_t'.
7329
7330 * regex.h <regoff_t>: Use ssize_t, not int.
7331 (re_search, re_search_2, re_match, re_match_2): Arguments that
7332 specify buffer/string position and length are now ssize_t and
7333 size_t. Return type is regoff_t.
7334
7335 2011-04-16 Ben Key <bkey76@gmail.com>
7336
7337 * nsfont.m: Fixed bugs in ns_get_family and
7338 ns_descriptor_to_entity that were caused by using free to
7339 deallocate memory blocks that were allocated by xmalloc (via
7340 xstrdup). This caused Emacs to crash when compiled with
7341 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7342 --enable-checking=xmallocoverrun). xfree is now used to
7343 deallocate these memory blocks.
7344
7345 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7346
7347 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7348
7349 emacs_write: Accept and return EMACS_INT for sizes.
7350 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7351 et seq.
7352 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7353 Accept and return EMACS_INT.
7354 (emacs_gnutls_write): Return the number of bytes written on
7355 partial writes.
7356 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7357 (emacs_read, emacs_write): Remove check for negative size, as the
7358 Emacs source code has been audited now.
7359 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7360 (emacs_read, emacs_write): Use it.
7361 * process.c (send_process): Adjust to the new signatures of
7362 emacs_write and emacs_gnutls_write. Do not attempt to store
7363 a byte offset into an 'int'; it might overflow.
7364 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7365
7366 * sound.c: Don't assume sizes fit in 'int'.
7367 (struct sound_device.period_size, alsa_period_size):
7368 Return EMACS_INT, not int.
7369 (struct sound_device.write, vox_write, alsa_write):
7370 Accept EMACS_INT, not int.
7371 (wav_play, au_play): Use EMACS_INT to store sizes and to
7372 record read return values.
7373
7374 2011-04-15 Ben Key <bkey76@gmail.com>
7375
7376 * keyboard.c (Qundefined): Don't declare static since it is used
7377 in nsfns.m.
7378 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7379 static since they are used in nsfont.m.
7380
7381 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7382
7383 * process.c (Qprocessp): Don't declare static.
7384 * lisp.h (Qprocessp): Declare again.
7385
7386 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7387
7388 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7389
7390 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7391
7392 Improve C-level modularity by making more things 'static'.
7393
7394 Don't publish debugger-only interfaces to other modules.
7395 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7396 (verify_bytepos, count_markers): Move decls to the only modules
7397 that need them.
7398 * region-cache.h (pp_cache): Likewise.
7399 * window.h (check_all_windows): Likewise.
7400 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7401
7402 * sysdep.c (croak): Now static, if
7403 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7404 * syssignal.h (croak): Declare only if not static.
7405
7406 * alloc.c (refill_memory_reserve): Now static if
7407 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7408 * lisp.h (refill_memory_reserve): Declare only if not static.
7409
7410 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7411 Define only if USE_LUCID.
7412
7413 * xrdb.c (x_customization_string, x_rm_string): Now static.
7414
7415 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7416 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7417
7418 * xdisp.c (draw_row_with_mouse_face): Now static.
7419 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7420
7421 * window.h (check_all_windows): Mark externally visible.
7422
7423 * window.c (window_deletion_count): Now static.
7424
7425 * undo.c: Make symbols static if they're not exported.
7426 (last_undo_buffer, last_boundary_position, pending_boundary):
7427 Now static.
7428
7429 * textprop.c (interval_insert_behind_hooks): Now static.
7430 (interval_insert_in_front_hooks): Likewise.
7431
7432 * term.c: Make symbols static if they're not exported.
7433 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7434 (max_frame_lines, tty_set_terminal_modes):
7435 (tty_reset_terminal_modes, tty_turn_off_highlight):
7436 (get_tty_terminal): Now static.
7437 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7438 * termhooks.h (term_mouse_moveto): Do not declare if
7439 HAVE_WINDOW_SYSTEM.
7440 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7441 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7442
7443 * sysdep.c: Make symbols static if they're not exported.
7444 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7445 Now static.
7446 (sigprocmask_set, full_mask): Remove; unused.
7447 (wait_debugging): Mark as visible.
7448 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7449 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7450
7451 * syntax.c (syntax_temp): Define only if !__GNUC__.
7452
7453 * sound.c (current_sound_device, current_sound): Now static.
7454
7455 * search.c (searchbufs, searchbuf_head): Now static.
7456
7457 * scroll.c (scroll_cost): Remove; unused.
7458 * dispextern.h (scroll_cost): Remove decl.
7459
7460 * region-cache.h (pp_cache): Mark as externally visible.
7461
7462 * process.c: Make symbols static if they're not exported.
7463 (process_tick, update_tick, create_process, chan_process):
7464 (Vprocess_alist, proc_buffered_char, datagram_access):
7465 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7466 (deactivate_process): Mark defn as static, as well as decl.
7467 * lisp.h (create_process): Remove decl.
7468 * process.h (chan_process, Vprocess_alist): Remove decls.
7469
7470 * print.c: Make symbols static if they're not exported.
7471 (print_depth, new_backquote_output, being_printed, print_buffer):
7472 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7473 (print_interval, print_number_index, initial_stderr_stream):
7474 Now static.
7475 * lisp.h (Fprinc): Remove decl.
7476 (debug_output_compilation_hack): Mark as externally visible.
7477
7478 * sysdep.c (croak): Move decl from here to syssignal.h.
7479 * syssignal.h (croak): Put it here, so the API can be checked when
7480 'croak' is called from dissociate_if_controlling_tty.
7481
7482 * minibuf.c: Make symbols static if they're not exported.
7483 (minibuf_save_list, choose_minibuf_frame): Now static.
7484 * lisp.h (choose_minibuf_frame): Remove decl.
7485
7486 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7487
7488 * lread.c: Make symbols static if they're not exported.
7489 (read_objects, initial_obarray, oblookup_last_bucket_number):
7490 Now static.
7491 (make_symbol): Remove; unused.
7492 * lisp.h (initial_obarray, make_symbol): Remove decls.
7493
7494 * keyboard.c: Make symbols static if they're not exported.
7495 (single_kboard, recent_keys_index, total_keys, recent_keys):
7496 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7497 (this_single_command_key_start, echoing, last_auto_save):
7498 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7499 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7500 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7501 (Vlispy_mouse_stem, double_click_count):
7502 Now static.
7503 (force_auto_save_soon): Define only if SIGDANGER.
7504 (ignore_mouse_drag_p): Now static if
7505 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7506 (print_help): Remove; unused.
7507 (stop_character, last_timer_event): Mark as externally visible.
7508 * keyboard.h (ignore_mouse_drag_p): Declare only if
7509 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7510 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7511 * lisp.h (echoing): Remove decl.
7512 (force_auto_save_soon): Declare only if SIGDANGER.
7513 * xdisp.c (redisplay_window): Simplify code, to make it more
7514 obvious that ignore_mouse_drag_p is not accessed if !defined
7515 USE_GTK && !defined HAVE_NS.
7516
7517 * intervals.c: Make symbols static if they're not exported.
7518 (merge_properties_sticky, merge_interval_right, delete_interval):
7519 Now static.
7520 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7521
7522 * insdel.c: Make symbols static if they're not exported.
7523 However, leave prepare_to_modify_buffer alone. It's never
7524 called from outside this function, but that appears to be a bug.
7525 (combine_after_change_list, combine_after_change_buffer):
7526 (adjust_after_replace, signal_before_change): Now static.
7527 (adjust_after_replace_noundo): Remove; unused.
7528 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7529 (signal_before_change): Remove decls.
7530
7531 * indent.c (val_compute_motion, val_vmotion): Now static.
7532
7533 * image.c: Make symbols static if they're not exported.
7534 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7535 if USE_GTK.
7536 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7537 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7538
7539 * fringe.c (standard_bitmaps): Now static.
7540 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7541
7542 * frame.c: Make symbols static if they're not exported.
7543 (x_report_frame_params, make_terminal_frame): Now static.
7544 (get_frame_param): Now static, unless HAVE_NS.
7545 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7546 (x_get_resource_string): Remove; not used.
7547 * frame.h (make_terminal_frame, x_report_frame_params):
7548 (x_get_resource_string); Remove decls.
7549 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7550 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7551
7552 * font.c, fontset.c: Make symbols static if they're not exported.
7553 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7554 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7555 * font.c (font_close_object): Now static.
7556 * font.h (font_close_object): Remove.
7557 * fontset.c (FONTSET_OBJLIST): Remove.
7558 (free_realized_fontset) #if-0 the body, which does nothing.
7559 (face_suitable_for_char_p): #if-0, as it's never called.
7560 * fontset.h (face_suitable_for_char_p): Remove decl.
7561 * xfaces.c (face_at_string_position):
7562 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7563 since 0 is always ASCII.
7564
7565 * fns.c (weak_hash_tables): Now static.
7566
7567 * fileio.c: Make symbols static if they're not exported.
7568 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7569 (Vwrite_region_annotation_buffers): Now static.
7570
7571 * eval.c: Make symbols static if they're not exported.
7572 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7573 * lisp.h (backtrace_list): Remove decl.
7574
7575 * emacs.c: Make symbols static if they're not exported.
7576 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7577 (fatal_error_code, fatal_error_signal_hook, standard_args):
7578 Now static.
7579 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7580 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7581 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7582 * lisp.h (fatal_error_signal_hook): Remove decl.
7583 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7584
7585 * editfns.c: Move a (normally-unused) function to its only use.
7586 * editfns.c, lisp.h (get_operating_system_release): Remove.
7587 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7588 worth the hassle of breaking this out.
7589
7590 * xterm.c: Make symbols static if they're not exported.
7591 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7592 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7593 (x_destroy_window, x_delete_display):
7594 Now static.
7595 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7596 (x_mouse_leave): Remove; unused.
7597 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7598 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7599 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7600 Remove decls.
7601 (x_mouse_leave): Declare only if WINDOWSNT.
7602 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7603 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7604 USE_X_TOOLKIT.
7605
7606 * ftxfont.c: Make symbols static if they're not exported.
7607 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7608 HAVE_FREETYPE.
7609 * font.h (ftxfont_driver): Likewise.
7610
7611 * xfns.c: Make symbols static if they're not exported.
7612 (x_last_font_name, x_display_info_for_name):
7613 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7614 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7615 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7616 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7617 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7618 (last_show_tip_args): Now static.
7619 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7620 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7621 (x_screen_planes): Remove; unused.
7622 * dispextern.h (x_screen_planes): Remove decl.
7623
7624 * dispnew.c: Make symbols static if they're not exported.
7625 * dispextern.h (redraw_garbaged_frames, scrolling):
7626 (increment_row_positions): Remove.
7627 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7628 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7629 Now static.
7630 (redraw_garbaged_frames): Remove; unused.
7631
7632 * xfaces.c: Make symbols static if they're not exported.
7633 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7634 Remove decls.
7635 * xterm.h (defined_color): Remove decls.
7636 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7637 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7638 (menu_face_changed_default, defined_color, free_realized_face):
7639 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7640 (ascii_face_of_lisp_face): Remove; unused.
7641
7642 * xdisp.c: Make symbols static if they're not exported.
7643 * dispextern.h (scratch_glyph_row, window_box_edges):
7644 (glyph_to_pixel_coords, set_cursor_from_row):
7645 (get_next_display_element, set_iterator_to_next):
7646 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7647 (show_mouse_face): Remove decls
7648 * frame.h (message_buf_print): Likewise.
7649 * lisp.h (pop_message, set_message, check_point_in_composition):
7650 Likewise.
7651 * xterm.h (set_vertical_scroll_bar): Likewise.
7652 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7653 (message_buf_print, scratch_glyph_row, displayed_buffer):
7654 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7655 (get_next_display_element, show_mouse_face, window_box_edges):
7656 (frame_to_window_pixel_xy, check_point_in_composition):
7657 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7658 (glyph_to_pixel_coords): Remove; unused.
7659
7660 * dired.c (file_name_completion): Now static.
7661
7662 * dbusbind.c (xd_in_read_queued_messages): Now static.
7663
7664 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7665 * data.c (circular_list_error): Remove.
7666
7667 * commands.h (last_point_position, last_point_position_buffer):
7668 (last_point_position_window): Remove decls.
7669 * keyboard.c: Make these variables static.
7670
7671 * coding.h (coding, code_convert_region, encode_coding_gap):
7672 Remove decls.
7673 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7674 (iso_code_class, detect_coding, code_convert_region): Now static.
7675 (encode_coding_gap): Remove; unused.
7676
7677 * chartab.c (chartab_chars, chartab_bits): Now static.
7678
7679 * charset.h (charset_iso_8859_1): Remove decl.
7680 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7681 Now static.
7682
7683 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7684 * ccl.c (Vccl_program_table): Now static.
7685 (check_ccl_update): Remove; unused.
7686
7687 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7688 * category.h: ... from here.
7689 * category.c (check_category_table, set_category_set): Now static.
7690
7691 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7692 * lisp.h: Remove these decls.
7693
7694 * buffer.c (buffer_count): Remove unused var.
7695
7696 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7697 so that it's not optimized away.
7698 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7699 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7700 exported only to the debugger.
7701
7702 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7703 * atimer.h (run_all_atimers): Remove; not exported.
7704
7705 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7706 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7707 was inaccessible from Lisp.
7708 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7709 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7710
7711 alloc.c: Import and export fewer symbols, and remove unused items.
7712 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7713 is defined.
7714 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7715 it's not optimized away by whole-program optimization.
7716 (message_enable_multibyte, free_misc): Remove.
7717 (catchlist, handlerlist, mark_backtrace):
7718 Declare only if BYTE_MARK_STACK.
7719 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7720 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7721 (message_enable_multibyte): Remove decl.
7722 (free_misc, interval_free_list, float_block, float_block_index):
7723 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7724 (cons_free_list, last_marked_index):
7725 Now static.
7726 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7727 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7728 (mark_backtrace): Define only if BYTE_MARK_STACK.
7729 * xdisp.c (message_enable_multibyte): Now static.
7730
7731 Declare Lisp_Object Q* variables to be 'static' if not exported.
7732 This makes it easier for human readers (and static analyzers)
7733 to see whether these variables are used from other modules.
7734 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7735 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7736 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7737 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7738 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7739 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7740 * xmenu.c, xselect.c:
7741 Declare Q* vars static if they are not used in other modules.
7742 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7743 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7744 Remove decls of unexported vars.
7745 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7746
7747 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7748
7749 Make Emacs functions such as Fatom 'static' by default.
7750 This makes it easier for human readers (and static analyzers)
7751 to see whether these functions can be called from other modules.
7752 DEFUN now defines a static function. To make the function external
7753 so that it can be used in other C modules, use the new macro DEFUE.
7754 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7755 (Finit_image_library):
7756 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7757 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7758 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7759 Remove decls, since these functions are now static.
7760 (Funintern, Fget_internal_run_time): New decls, since these functions
7761 were already external.
7762
7763 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7764 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7765 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7766 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7767 * keyboard.c, keymap.c, lread.c:
7768 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7769 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7770 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7771 Mark functions with DEFUE instead of DEFUN,
7772 if they are used in other modules.
7773 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7774 decls for now-static functions.
7775 * buffer.h (Fdelete_overlay): Remove decl.
7776 * callproc.c (Fgetenv_internal): Mark as internal.
7777 * composite.c (Fremove_list_of_text_properties): Remove decl.
7778 (Fcomposition_get_gstring): New forward static decl.
7779 * composite.h (Fcomposite_get_gstring): Remove decl.
7780 * dired.c (Ffile_attributes): New forward static decl.
7781 * doc.c (Fdocumntation_property): New forward static decl.
7782 * eval.c (Ffetch_bytecode): New forward static decl.
7783 (Funintern): Remove extern decl; now in .h file where it belongs.
7784 * fileio.c (Fmake_symbolic_link): New forward static decl.
7785 * image.c (Finit_image_library): New forward static decl.
7786 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7787 * intervals.h (Fprevious_property_change):
7788 (Fremove_list_of_text_properties): Remove decls.
7789 * keyboard.c (Fthis_command_keys): Remove decl.
7790 (Fcommand_execute): New forward static decl.
7791 * keymap.c (Flookup_key): New forward static decl.
7792 (Fcopy_keymap): Now static.
7793 * keymap.h (Flookup_key): Remove decl.
7794 * process.c (Fget_process): New forward static decl.
7795 (Fprocess_datagram_address): Mark as internal.
7796 * syntax.c (Fsyntax_table_p): New forward static decl.
7797 (skip_chars): Remove duplicate decl.
7798 * textprop.c (Fprevious_property_change): New forward static decl.
7799 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7800 Now internal.
7801 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7802 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7803
7804 * editfns.c (Fformat): Remove unreachable code.
7805
7806 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7807
7808 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7809 change. (Bug#8496)
7810
7811 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7812
7813 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7814 when at ZV. (Bug#8487)
7815
7816 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7817
7818 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7819 (Bug#8437)
7820 * keyboard.c (parse_tool_bar_item): Likewise.
7821 * sound.c (sound_cleanup, alsa_close): Likewise.
7822 * termcap.c (tgetent): Likewise.
7823 * xfns.c (x_default_font_parameter): Likewise.
7824 * xsettings.c (read_and_apply_settings): Likewise.
7825
7826 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7827 (overrun_check_free): Protoize.
7828
7829 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7830
7831 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7832 since callers should never pass a negative size.
7833 Change the signature to match that of plain 'read' and 'write'; see
7834 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7835 * lisp.h: Update prototypes of emacs_write and emacs_read.
7836
7837 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7838
7839 * xdisp.c (redisplay_window): Don't try to determine the character
7840 position of the scroll margin if the window start point w->startp
7841 is outside the buffer's accessible region. (Bug#8468)
7842
7843 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7844
7845 Fix write-region and its subroutines for buffers > 2GB.
7846 * fileio.c (a_write, e_write): Modify declaration of arguments and
7847 local variables to support buffers larger than 2GB.
7848 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7849
7850 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7851 argument, local variables, and return value.
7852
7853 * lisp.h: Update prototypes of emacs_write and emacs_read.
7854
7855 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7856
7857 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7858
7859 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7860
7861 Fix more problems found by GCC 4.6.0's static checks.
7862
7863 * xdisp.c (vmessage): Use a better test for character truncation.
7864
7865 * charset.c (load_charset_map): <, not <=, for optimization,
7866 and to avoid potential problems with integer overflow.
7867 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7868 * casetab.c (set_identity, shuffle): Likewise.
7869 * editfns.c (Fformat): Likewise.
7870 * syntax.c (skip_chars): Likewise.
7871
7872 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7873 This also lets GCC 4.6.0 generate slightly better loop code.
7874
7875 * callint.c (Fcall_interactively): <, not <=, for optimization.
7876 (Fcall_interactively): Count the number of arguments produced,
7877 not the number of arguments given. This is simpler and lets GCC
7878 4.6.0 generate slightly better code.
7879
7880 * ftfont.c: Distingish more carefully between FcChar8 and char.
7881 The previous code passed unsigned char * to a functions like
7882 strlen and xstrcasecmp that expect char *, which does not
7883 conform to the C standard.
7884 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7885 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7886 char * when the C standard requires it.
7887
7888 * keyboard.c (read_char): Remove unused var.
7889
7890 * eval.c: Port to Windows vsnprintf (Bug#8435).
7891 Include <limits.h>.
7892 (SIZE_MAX): Define if the headers do not.
7893 (verror): Do not give up if vsnprintf returns a negative count.
7894 Instead, grow the buffer. This ports to Windows vsnprintf, which
7895 does not conform to C99. Problem reported by Eli Zaretskii.
7896 Also, simplify the allocation scheme, by avoiding the need for
7897 calling realloc, and removing the ALLOCATED variable.
7898
7899 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7900
7901 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7902 But keep the doprint source code for now, as we might revamp it
7903 and use it again (Bug#8435).
7904 * lisp.h (doprnt): Remove.
7905 * Makefile.in (base_obj): Remove doprnt.o.
7906 * deps.mk (doprnt.o): Remove.
7907
7908 error: Print 32- and 64-bit integers portably (Bug#8435).
7909 Without this change, on typical 64-bit hosts error ("...%d...", N)
7910 was used to print both 32- and 64-bit integers N, which relied on
7911 undefined behavior.
7912 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7913 * lisp.h (error, verror): Mark as printf-like functions.
7914 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7915 Report overflow in size calculations when allocating printf buffer.
7916 Do not truncate output string at its first null byte.
7917 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7918 Truncate the output at a character boundary, since vsnprintf does not
7919 do that.
7920 * charset.c (check_iso_charset_parameter): Convert internal
7921 character to string before calling 'error', since %c now has the
7922 printf meaning.
7923 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7924 overflow when computing char to be passed to 'error'. Do not
7925 pass Lisp_Object to 'error'; pass the integer instead.
7926 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7927 formatted with plain %d.
7928
7929 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7930
7931 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7932
7933 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7934
7935 * xterm.c (x_catch_errors): Remove duplicate declaration.
7936
7937 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7938
7939 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7940
7941 2011-04-10 Jim Meyering <meyering@redhat.com>
7942
7943 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7944 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7945 return ssize_t not "int", and use size_t as the buffer length.
7946 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7947 * gnutls.h: Update declarations.
7948 * process.c (read_process_output): Use ssize_t, to match.
7949 (send_process): Likewise.
7950
7951 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7952
7953 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7954
7955 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7956
7957 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7958 Use unsigned char, to match FcChar8 type definition.
7959
7960 * xterm.c (handle_one_xevent):
7961 * xmenu.c (create_and_show_popup_menu):
7962 * xselect.c (x_decline_selection_request)
7963 (x_reply_selection_request): Avoid type-punned deref of X events.
7964
7965 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7966
7967 Fix some uses of `int' instead of EMACS_INT.
7968 * search.c (string_match_1, fast_string_match)
7969 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7970 (scan_buffer, find_next_newline_no_quit)
7971 (find_before_next_newline, search_command, Freplace_match)
7972 (Fmatch_data): Make some `int' variables be EMACS_INT.
7973
7974 * xdisp.c (display_count_lines): 3rd argument and return value now
7975 EMACS_INT. All callers changed.
7976 (pint2hrstr): Last argument is now EMACS_INT.
7977
7978 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7979 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7980 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7981 (decode_coding_utf_16, decode_coding_emacs_mule)
7982 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7983 (decode_coding_ccl, decode_coding_charset)
7984 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7985 (decode_coding_iso_2022, decode_coding_emacs_mule)
7986 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7987 <char_offset, last_offset>: Declare EMACS_INT.
7988 (encode_coding_utf_8, encode_coding_utf_16)
7989 (encode_coding_emacs_mule, encode_invocation_designation)
7990 (encode_designation_at_bol, encode_coding_iso_2022)
7991 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7992 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7993 Declare EMACS_INT.
7994 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7995 (encode_invocation_designation): Last argument P_NCHARS is now
7996 EMACS_INT.
7997 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7998 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7999
8000 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8001 All users changed.
8002
8003 * ccl.c (Fccl_execute_on_string): Declare some variables
8004 EMACS_INT.
8005
8006 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8007
8008 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8009
8010 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8011
8012 * process.c (Fformat_network_address): Doc fix.
8013
8014 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8015
8016 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8017
8018 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8019
8020 * keyboard.c (read_char): Call Lisp function help-form-show,
8021 instead of using internal_with_output_to_temp_buffer.
8022 (Qhelp_form_show): New var.
8023 (syms_of_keyboard): Use DEFSYM macro.
8024
8025 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8026
8027 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8028
8029 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8030
8031 * process.c (Flist_processes): Remove to Lisp.
8032 (list_processes_1): Delete.
8033
8034 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8035
8036 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8037
8038 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8039
8040 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8041
8042 Fix more problems found by GCC 4.6.0's static checks.
8043
8044 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8045
8046 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8047
8048 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8049
8050 * xdisp.c (vmessage): Mark as a printf-like function.
8051
8052 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8053
8054 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8055
8056 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8057 printf-like functions.
8058 (tiff_load): Add casts to remove these marks before passing them
8059 to system-supplied API.
8060
8061 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8062
8063 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8064 This avoids several warnings with gcc -Wstrict-overflow.
8065 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8066 directly, rather than having caller test rule sign. This avoids
8067 some unnecessary tests.
8068 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8069 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8070 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8071
8072 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8073 (xfont_open): Avoid unnecessary tests.
8074
8075 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8076
8077 * composite.h, composite.c (composition_gstring_put_cache):
8078 Use EMACS_INT, not int, for length.
8079
8080 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8081 breaking out part of COMPOSITION_DECODE_RULE.
8082 (COMPOSITION_DECODE_RULE): Use it.
8083 * composite.c (get_composition_id): Remove unused local vars,
8084 by using the new macro.
8085
8086 * textprop.c (set_text_properties_1): Change while to do-while,
8087 since the condition is always true at first.
8088
8089 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8090 (interval_deletion_adjustment): Return unsigned value.
8091 All uses changed.
8092
8093 * process.c (list_processes_1, create_pty, read_process_output):
8094 (exec_sentinel): Remove vars that were set but not used.
8095 (create_pty): Remove unnecessary "volatile"s.
8096 (Fnetwork_interface_info): Avoid possibility of int overflow.
8097 (read_process_output): Do adaptive read buffering even if carryover.
8098 (read_process_output): Simplify nbytes computation if buffered.
8099
8100 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8101
8102 * syntax.c (scan_words): Remove var that was set but not used.
8103 (update_syntax_table): Use unsigned instead of int.
8104
8105 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8106 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8107 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8108
8109 * print.c (print_error_message): Avoid int overflow.
8110
8111 * font.c (font_list_entities): Redo for clarity,
8112 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8113
8114 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8115 (font_score): Avoid potential overflow in diff calculation.
8116
8117 * fns.c (substring_both): Remove var that is set but not used.
8118 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8119
8120 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8121
8122 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8123 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8124 can always succeed if overflow has undefined behavior.
8125
8126 * search.c (boyer_moore, wordify): Remove vars set but not used.
8127 (wordify): Omit three unnecessary tests.
8128
8129 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8130 All callers changed. This avoids the need for an unused var.
8131
8132 * casefiddle.c (casify_region): Remove var that is set but not used.
8133
8134 * dired.c (file_name_completion): Remove var that is set but not used.
8135
8136 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8137
8138 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8139 (Finsert_file_contents): Remove unnecessary code checking fd.
8140
8141 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8142 Check for integer overflow on size calculations.
8143
8144 * buffer.c (Fprevious_overlay_change): Remove var that is set
8145 but not used.
8146
8147 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8148 Remove vars that are set but not used.
8149 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8150 (timer_check_2): Mark vars as initialized.
8151
8152 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8153
8154 * image.c (lookup_image): Remove var that is set but not used.
8155 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8156
8157 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8158 that are set but not used.
8159
8160 * xfns.c (make_invisible_cursor): Don't return garbage
8161 if XCreateBitmapFromData fails (Bug#8410).
8162
8163 * xselect.c (x_get_local_selection, x_handle_property_notify):
8164 Remove vars that are set but not used.
8165
8166 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8167 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8168
8169 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8170 Remove var that is set but not used.
8171 (scroll_bar_windows_size): Now size_t, not int.
8172 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8173 Check for overflow.
8174
8175 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8176 (map_tty_color) [!defined MSDOS]: Likewise.
8177
8178 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8179
8180 * coding.c: Remove vars that are set but not used.
8181 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8182 All callers changed.
8183 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8184 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8185 (decode_coding_charset): Remove vars that are set but not used.
8186
8187 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8188 that is set but not used.
8189
8190 * print.c (print_object): Remove var that is set but not used.
8191
8192 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8193 The gnulib version avoids calling malloc in the usual case,
8194 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8195 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8196 * filelock.c (current_lock_owner): Likewise.
8197 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8198 * sysdep.c: Include allocator.h, careadlinkat.h.
8199 (emacs_no_realloc_allocator): New static constant.
8200 (emacs_readlink): New function.
8201 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8202 ../lib/careadlinkat.h.
8203
8204 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8205
8206 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8207 first non-nil return value).
8208
8209 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8210
8211 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8212 if not defined (Bug#8403).
8213
8214 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8215
8216 * xdisp.c (display_count_lines): Remove parameter `start',
8217 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8218 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8219 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8220 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8221 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8222 and thereabouts. All callers changed.
8223 (get_per_char_metric): Remove parameter `f', unused since
8224 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8225
8226 2011-04-02 Jim Meyering <meyering@redhat.com>
8227
8228 do not dereference NULL upon failed strdup
8229 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8230 (ns_get_family): Likewise.
8231
8232 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8233
8234 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8235
8236 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8237
8238 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8239 later (Bug#8403).
8240
8241 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8242
8243 Add lexical binding.
8244
8245 * window.c (Ftemp_output_buffer_show): New fun.
8246 (Fsave_window_excursion):
8247 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8248
8249 * lread.c (lisp_file_lexically_bound_p): New function.
8250 (Fload): Bind Qlexical_binding.
8251 (readevalloop): Remove `evalfun' arg.
8252 Bind Qinternal_interpreter_environment.
8253 (Feval_buffer): Bind Qlexical_binding.
8254 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8255 Mark as dynamic.
8256 (syms_of_lread): Declare `lexical-binding'.
8257
8258 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8259
8260 * keyboard.c (eval_dyn): New fun.
8261 (menu_item_eval_property): Use it.
8262
8263 * image.c (parse_image_spec): Use Ffunctionp.
8264
8265 * fns.c (concat, mapcar1): Accept byte-code-functions.
8266
8267 * eval.c (Fsetq): Handle lexical vars.
8268 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8269 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8270 (FletX, Flet): Obey lexical binding.
8271 (Fcommandp): Handle closures.
8272 (Feval): New `lexical' arg.
8273 (eval_sub): New function extracted from Feval. Use it almost
8274 everywhere where Feval was used. Look up vars in lexical env.
8275 Handle closures.
8276 (Ffunctionp): Move from subr.el.
8277 (Ffuncall): Handle closures.
8278 (apply_lambda): Remove `eval_flags'.
8279 (funcall_lambda): Handle closures and new byte-code-functions.
8280 (Fspecial_variable_p): New function.
8281 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8282 but without exporting it to Lisp.
8283
8284 * doc.c (Fdocumentation, store_function_docstring):
8285 * data.c (Finteractive_form): Handle closures.
8286
8287 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8288 interactive spec.
8289
8290 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8291 New byte-codes.
8292 (exec_byte_code): New function extracted from Fbyte_code to handle new
8293 calling convention for byte-code-functions. Add new byte-codes.
8294
8295 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8296
8297 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8298
8299 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8300
8301 * xdisp.c (redisplay_internal): Fix prototype.
8302
8303 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8304
8305 * xdisp.c (SCROLL_LIMIT): New macro.
8306 (try_scrolling): Use it when setting scroll_limit.
8307 Limit scrolling to 100 screen lines.
8308 (redisplay_window): Even when falling back on "recentering",
8309 position point in the window according to scroll-conservatively,
8310 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8311
8312 (try_scrolling): When point is above the window, allow searching
8313 as far as scroll_max, or one screenful, to compute vertical
8314 distance from PT to the scroll margin position. This prevents
8315 try_scrolling from unnecessarily failing when
8316 scroll-conservatively is set to a value slightly larger than the
8317 window height. Clean up the case of PT below the margin at bottom
8318 of window: scroll_max can no longer be INT_MAX. When aggressive
8319 scrolling is in use, don't let point enter the opposite scroll
8320 margin as result of the scroll.
8321 (syms_of_xdisp) <scroll-conservatively>: Document the
8322 threshold of 100 lines for never-recentering scrolling.
8323
8324 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8325
8326 * dispextern.h (move_it_by_lines):
8327 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8328 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8329 (message_log_check_duplicate): Remove parameters `prev_bol' and
8330 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8331 (redisplay_internal): Remove parameter `preserve_echo_area',
8332 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8333
8334 * indent.c (Fvertical_motion):
8335 * window.c (window_scroll_pixel_based, Frecenter):
8336 Don't pass `need_y_p' to `move_it_by_lines'.
8337
8338 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8339
8340 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8341 steal a few bits to be more compact.
8342 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8343 Remove unneeded casts.
8344
8345 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8346
8347 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8348
8349 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8350 binding" message (bug#7967).
8351
8352 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8353
8354 Fix more problems found by GCC 4.6.0's static checks.
8355
8356 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8357 Remove unused local var.
8358
8359 * editfns.c (Fmessage_box): Remove unused local var.
8360
8361 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8362 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8363 Omit unused local vars.
8364 * window.c (shrink_windows): Omit unused local var.
8365 * menu.c (digest_single_submenu): Omit unused local var.
8366 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8367 Omit unused local var.
8368
8369 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8370 Don't assume string length fits in int.
8371 (keyremap_step, read_key_sequence): Use size_t for sizes.
8372 (read_key_sequence): Don't check last_real_key_start redundantly.
8373
8374 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8375 instead of alloca (Bug#8344).
8376
8377 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8378 (Fbacktrace_frame): Don't assume nframes fits in int.
8379
8380 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8381
8382 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8383 concerns.
8384
8385 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8386
8387 * cm.c (calccost): Turn while-do into do-while, for clarity.
8388
8389 * keyboard.c (syms_of_keyboard): Use the same style as later
8390 in this function when indexing through an array. This also
8391 works around GCC bug 48267.
8392
8393 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8394
8395 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8396
8397 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8398 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8399
8400 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8401 This avoids undefined behavior on integer overflow, and is a bit
8402 more convenient anyway since it is compared to a size_t variable.
8403
8404 Variadic C functions now count arguments with size_t, not int.
8405 This avoids an unnecessary limitation on 64-bit machines, which
8406 caused (substring ...) to crash on large vectors (Bug#8344).
8407 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8408 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8409 All variadic functions and their callers changed accordingly.
8410 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8411 * data.c (arith_driver, float_arith_driver): Likewise.
8412 * editfns.c (general_insert_function): Likewise.
8413 * eval.c (struct backtrace.nargs, interactive_p)
8414 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8415 (funcall_lambda, mark_backtrace): Likewise.
8416 * fns.c (concat): Likewise.
8417 * frame.c (x_set_frame_parameters): Likewise.
8418 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8419 0 if not found, not -1. All callers changed.
8420
8421 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8422 (stack_copy_size): Now size_t, not int.
8423 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8424
8425 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8426
8427 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8428 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8429 All callers changed.
8430
8431 * lisp.h (multibyte_char_to_unibyte):
8432 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8433 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8434 * character.h (CHAR_TO_BYTE8):
8435 * cmds.c (internal_self_insert):
8436 * editfns.c (general_insert_function):
8437 * keymap.c (push_key_description):
8438 * search.c (Freplace_match):
8439 * xdisp.c (message_dolog, set_message_1): All callers changed.
8440
8441 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8442
8443 * keyboard.c (safe_run_hook_funcall): New function.
8444 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8445 don't set the hook to nil, but remove the offending function instead.
8446 (Qcommand_hook_internal): Remove, unused.
8447 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8448 Vcommand_hook_internal.
8449
8450 * eval.c (enum run_hooks_condition): Remove.
8451 (funcall_nil, funcall_not): New functions.
8452 (run_hook_with_args): Call each function through a `funcall' argument.
8453 Remove `cond' argument, now redundant.
8454 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8455 (Frun_hook_with_args_until_failure): Adjust accordingly.
8456 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8457
8458 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8459
8460 * dispextern.h (string_buffer_position): Remove declaration.
8461
8462 * print.c (strout): Remove parameter `multibyte', unused since
8463 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8464
8465 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8466 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8467 All callers changed.
8468
8469 * w32.c (_wsa_errlist): Use braces for struct initializers.
8470
8471 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8472 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8473 All callers changed.
8474 (string_buffer_position): Likewise. Also, make static (it's never
8475 used outside xdisp.c).
8476 (cursor_row_p): Remove parameter `w', unused since
8477 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8478 (decode_mode_spec): Remove parameter `precision', introduced during
8479 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8480 All callers changed.
8481
8482 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8483
8484 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8485
8486 2011-03-27 Anders Lindgren <andlind@gmail.com>
8487
8488 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8489 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8490 (ns_update_auto_hide_menu_bar): New functions.
8491 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8492 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8493 ns_constrain_all_frames.
8494 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8495 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8496
8497 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8498
8499 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8500
8501 2011-03-27 Glenn Morris <rgm@gnu.org>
8502
8503 * syssignal.h: Replace RETSIGTYPE with void.
8504 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8505 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8506 Replace SIGTYPE with void everywhere.
8507 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8508 * s/template.h (SIGTYPE): Remove commented out definition.
8509
8510 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8511
8512 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8513 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8514
8515 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8516
8517 * w32.c (read_unc_volume): Use parameter `henum', instead of
8518 global variable `wget_enum_handle'.
8519
8520 * keymap.c (describe_vector): Remove parameters `indices' and
8521 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8522 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8523
8524 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8525
8526 * keyboard.c (timer_check): Remove parameter `do_it_now',
8527 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8528 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8529 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8530
8531 * keyboard.c (read_char):
8532 * w32menu.c (w32_menu_display_help):
8533 * xmenu.c (show_help_event, menu_help_callback):
8534 Adjust calls to `show_help_echo'.
8535
8536 * gtkutil.c (xg_maybe_add_timer):
8537 * keyboard.c (readable_events):
8538 * process.c (wait_reading_process_output):
8539 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8540
8541 * insdel.c (adjust_markers_gap_motion):
8542 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8543 (gap_left, gap_right): Don't call it.
8544
8545 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8546
8547 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8548 incurred during fontification.
8549
8550 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8551
8552 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8553 (DEFVAR_PER_BUFFER): Don't pass it.
8554
8555 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8556 (scrolling_window): Don't pass it.
8557
8558 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8559
8560 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8561
8562 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8563 and `suffix'.
8564 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8565 of variables specific to SELinux and computation of `encoded_absname'.
8566
8567 * image.c (XPutPixel): Remove unused variable `height'.
8568
8569 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8570
8571 * unexw32.c (get_section_info): Remove unused variable `section'.
8572
8573 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8574 (system_process_attributes): Remove unused variable `sess'.
8575 (sys_read): Remove unused variable `err'.
8576
8577 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8578 (w32_wnd_proc): Remove unused variable `isdead'.
8579 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8580 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8581 (x_create_tip_frame): Remove unused variable `tem'.
8582
8583 * w32inevt.c (w32_console_read_socket):
8584 Remove unused variable `no_events'.
8585
8586 * w32term.c (x_draw_composite_glyph_string_foreground):
8587 Remove unused variable `width'.
8588
8589 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8590
8591 * w32term.c (x_set_glyph_string_clipping):
8592 Don't pass uninitialized region to CombineRgn.
8593
8594 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8595
8596 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8597 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8598 (Fx_close_connection): Remove unused variable `i'.
8599
8600 * w32font.c (w32font_draw): Return number of glyphs.
8601 (w32font_open_internal): Remove unused variable `i'.
8602 (w32font_driver): Add missing initializer.
8603
8604 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8605 (fill_in_menu): Remove unused variable `items_added'.
8606
8607 * w32term.c (last_mouse_press_frame): Remove static global variable.
8608 (w32_clip_to_row): Remove unused variable `f'.
8609 (x_delete_terminal): Remove unused variable `i'.
8610
8611 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8612 (NOTHING): Remove unused static global variable.
8613 (uniscribe_check_otf): Remove unused variable `table'.
8614 (uniscribe_font_driver): Add missing initializers.
8615
8616 2011-03-23 Julien Danjou <julien@danjou.info>
8617
8618 * term.c (Fsuspend_tty, Fresume_tty):
8619 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8620 * window.c (temp_output_buffer_show):
8621 * insdel.c (signal_before_change):
8622 * frame.c (Fhandle_switch_frame):
8623 * fileio.c (Fdo_auto_save):
8624 * emacs.c (Fkill_emacs):
8625 * editfns.c (save_excursion_restore):
8626 * cmds.c (internal_self_insert):
8627 * callint.c (Fcall_interactively):
8628 * buffer.c (Fkill_all_local_variables):
8629 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8630 Use Frun_hooks.
8631 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8632 unconditionally since it does the check itself.
8633
8634 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8635
8636 Fix more problems found by GCC 4.5.2's static checks.
8637
8638 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8639 the first time through the loop, since we know p0 < p1 then.
8640 This also avoids a gcc -Wstrict-overflow warning.
8641
8642 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8643 leading to a memory leak, possible in functions like
8644 load_charset_map_from_file that can allocate an unbounded number
8645 of objects (Bug#8318).
8646
8647 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8648 that could (at least in theory) be that large.
8649
8650 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8651 This is less likely to overflow, and avoids undefined behavior if
8652 overflow does occur. All callers changed. Use strtoul to scan
8653 for the unsigned long integer.
8654 (pint2hrstr): Simplify and tune code slightly.
8655 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8656
8657 * scroll.c (do_scrolling): Work around GCC bug 48228.
8658 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8659
8660 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8661 This also avoids a warning with gcc -Wstrict-overflow.
8662 (validate_x_resource_name): Simplify count usage.
8663 This also avoids a warning with gcc -Wstrict-overflow.
8664
8665 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8666 fail (Bug#8306).
8667
8668 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8669
8670 * process.c (Fmake_network_process): Use socklen_t, not int,
8671 where POSIX says socklen_t is required in portable programs.
8672 This fixes a porting bug on hosts like 64-bit HP-UX, where
8673 socklen_t is wider than int (Bug#8277).
8674 (Fmake_network_process, server_accept_connection):
8675 (wait_reading_process_output, read_process_output):
8676 Likewise.
8677
8678 * process.c: Rename or move locals to avoid shadowing.
8679 (list_processes_1, Fmake_network_process):
8680 (read_process_output_error_handler, exec_sentinel_error_handler):
8681 Rename or move locals.
8682 (Fmake_network_process): Define label "retry_connect" only if needed.
8683 (Fnetwork_interface_info): Fix pointer signedness.
8684 (process_send_signal): Add cast to avoid pointer signedness problem.
8685 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8686 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8687
8688 Make tparam.h and terminfo.c consistent.
8689 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8690 Include tparam.h instead, since it declares them.
8691 * cm.h (PC): Remove extern decl; tparam.h now does this.
8692 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8693 * terminfo.c: Include tparam.h, to check interfaces.
8694 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8695 (tparam): Adjust signature to match interface in tparam.h;
8696 this removes some undefined behavior. Check that outstring and len
8697 are zero, which they always are with Emacs.
8698 * tparam.h (PC, BC, UP): New extern decls.
8699
8700 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8701 (xftfont_open): Rename locals to avoid shadowing.
8702
8703 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8704 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8705 (OTF_TAG_SYM): Omit macro if not needed.
8706 (ftfont_list): Remove unused local.
8707 (get_adstyle_property, ftfont_pattern_entity):
8708 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8709 Rename locals to avoid shadowing.
8710
8711 * xfont.c (xfont_list_family): Mark var as initialized.
8712
8713 * xml.c (make_dom): Now static.
8714
8715 * composite.c (composition_compute_stop_pos): Rename local to
8716 avoid shadowing.
8717 (composition_reseat_it): Remove unused locals.
8718 (find_automatic_composition, composition_adjust_point): Likewise.
8719 (composition_update_it): Mark var as initialized.
8720 (find_automatic_composition): Mark vars as initialized,
8721 with a FIXME (Bug#8290).
8722
8723 character.h: Rename locals to avoid shadowing.
8724 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8725 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8726 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8727 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8728 to avoid shadowing.
8729
8730 * textprop.c (property_change_between_p): Remove; unused.
8731
8732 * intervals.c (interval_start_pos): Now static.
8733
8734 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8735
8736 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8737 Rename locals to avoid shadowing.
8738
8739 * sound.c (wav_play, au_play, Fplay_sound_internal):
8740 Fix pointer signedness.
8741 (alsa_choose_format): Remove unused local var.
8742 (wav_play): Initialize a variable to 0, to prevent undefined
8743 behavior (Bug#8278).
8744
8745 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8746
8747 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8748
8749 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8750 clobbering (Bug#8298).
8751 * sysdep.c (sys_subshell): Likewise.
8752 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8753
8754 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8755 This should get cleaned up, so that child_setup has the
8756 same signature on all platforms.
8757
8758 * callproc.c (call_process_cleanup): Now static.
8759 (relocate_fd): Rename locals to avoid shadowing.
8760
8761 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8762
8763 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8764 not to be necessary, and produces flickering.
8765
8766 2011-03-20 Glenn Morris <rgm@gnu.org>
8767
8768 * config.in: Remove file.
8769
8770 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8771
8772 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8773 are now in src/globals.h.
8774 (syms_of_minibuf): Remove spurious & from previous change.
8775
8776 2011-03-20 Leo Liu <sdl.web@gmail.com>
8777
8778 * minibuf.c (completing-read-function): New variable.
8779 (completing-read-default): Rename from completing-read.
8780 (completing-read): Call completing-read-function.
8781
8782 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8783
8784 * xfaces.c (Fx_load_color_file):
8785 Read color file from absolute filename (bug#8250).
8786
8787 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8788
8789 * makefile.w32-in: Update dependencies.
8790
8791 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8792
8793 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8794
8795 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8796
8797 Fix more problems found by GCC 4.5.2's static checks.
8798
8799 * process.c (make_serial_process_unwind, send_process_trap):
8800 (sigchld_handler): Now static.
8801
8802 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8803 That way, the code declares only the vars that it needs.
8804 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8805 * s/cygwin.h (PTY_ITERATION): Likewise.
8806 * s/darwin.h (PTY_ITERATION): Likewise.
8807 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8808
8809 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8810 * process.c (allocate_pty): Don't declare stb unless it's needed.
8811
8812 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8813 (CONSTANTLIM): Remove; unused.
8814 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8815 Define only if needed.
8816
8817 * unexelf.c (unexec): Name an expression,
8818 to avoid gcc -Wbad-function-cast warning.
8819 Use a different way to cause a compilation error if anyone uses
8820 n rather than nn, a way that does not involve shadowing.
8821 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8822
8823 * deps.mk (unexalpha.o): Remove; unused.
8824
8825 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8826 * unexec.h: New file.
8827 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8828 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8829 Depend on unexec.h.
8830 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8831 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8832 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8833 Change as necessary to match prototype in unexec.h.
8834
8835 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8836 shadowing.
8837 (back_comment, skip_chars): Mark vars as initialized.
8838
8839 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8840 Rename locals to avoid shadowing.
8841
8842 * lread.c (read1): Rewrite so as not to use empty "else".
8843 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8844
8845 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8846
8847 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8848 warning when compiling print.c.
8849
8850 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8851 instead of using an uninitialized var.
8852 (font_sort_entities): Mark var as initialized.
8853
8854 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8855
8856 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8857 pointers to constants.
8858 (font_parse_fcname): Remove unused vars.
8859 (font_delete_unmatched): Now static.
8860 (font_get_spec): Remove; unused.
8861 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8862 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8863 Rename or move locals to avoid shadowing.
8864
8865 * fns.c (require_nesting_list, require_unwind): Now static.
8866 (Ffillarray): Rename locals to avoid shadowing.
8867
8868 * floatfns.c (domain_error2): Define only if needed.
8869 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8870
8871 * alloc.c (mark_backtrace): Move decl from here ...
8872 * lisp.h: ... to here, so that it can be checked.
8873
8874 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8875 (Fdefvar): Rewrite so as not to use empty "else".
8876 (lisp_indirect_variable): Name an expression,
8877 to avoid gcc -Wbad-function-cast warning.
8878 (Fdefvar): Rename locals to avoid shadowing.
8879
8880 * callint.c (quotify_arg, quotify_args): Now static.
8881 (Fcall_interactively): Rename locals to avoid shadowing.
8882 Use const pointer when appropriate.
8883
8884 * lisp.h (get_system_name, get_operating_system_release):
8885 Move decls here, to check interfaces.
8886 * process.c (get_operating_system_release): Move decl to lisp.h.
8887 * xrdb.c (get_system_name): Likewise.
8888 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8889 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8890 some of which prompt warnings from gcc -Wbad-function-cast.
8891 (Fformat_time_string, Fencode_time, Finsert_char):
8892 (Ftranslate_region_internal, Fformat):
8893 Rename or remove local vars to avoid shadowing.
8894 (Ftranslate_region_internal): Mark var as initialized.
8895
8896 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8897 avoid shadowing.
8898
8899 * lisp.h (eassert): Check that the argument compiles, even if
8900 ENABLE_CHECKING is not defined.
8901
8902 * data.c (Findirect_variable): Name an expression, to avoid
8903 gcc -Wbad-function-cast warning.
8904 (default_value, arithcompare, arith_driver, arith_error): Now static.
8905 (store_symval_forwarding): Rename local to avoid shadowing.
8906 (Fmake_variable_buffer_local, Fmake_local_variable):
8907 Mark variables as initialized.
8908 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8909
8910 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8911 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8912 Rename locals to avoid shadowing.
8913 (mark_stack): Move local variables into the #ifdef region where
8914 they're used.
8915 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8916 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8917 needed otherwise.
8918 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8919 (GC_STRING_CHARS): Remove; not used.
8920 (Fmemory_limit): Cast sbrk's returned value to char *.
8921
8922 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8923 avoids undefined behavior in theory.
8924
8925 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8926
8927 Use functions, not macros, for up- and down-casing (Bug#8254).
8928 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8929 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8930 to use the following functions instead of these macros.
8931 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8932 EMACS_INT, since callers assume the returned value fits in int.
8933 (upcase1): Likewise, for UPCASE_TABLE.
8934 (uppercasep, lowercasep, upcase): New static inline functions.
8935 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8936 the race-condition problem in the old DOWNCASE.
8937
8938 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8939 Rename locals to avoid shadowing.
8940 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8941 (regex_compile, re_search_2, re_match_2_internal):
8942 Remove unused local vars.
8943 (FREE_VAR): Rewrite so as not to use empty "else",
8944 which gcc can warn about.
8945 (regex_compile, re_match_2_internal): Mark locals as initialized.
8946 (RETALLOC_IF): Define only if needed.
8947 (WORDCHAR_P): Likewise. This one is never needed, but is used
8948 only in a comment talking about a compiler bug, so put inside
8949 the #if 0 of that comment.
8950 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8951 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8952 Remove; unused.
8953
8954 * search.c (boyer_moore): Rename locals to avoid shadowing.
8955 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8956 (PREV_CHAR_BOUNDARY): Likewise.
8957
8958 * search.c (simple_search): Remove unused var.
8959
8960 * dired.c (compile_pattern): Move decl from here ...
8961 * lisp.h: ... to here, so that it can be checked.
8962 (struct re_registers): New forward decl.
8963
8964 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8965
8966 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8967 All uses changed.
8968 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8969 Rename locals to avoid shadowing.
8970 (Fvertical_motion): Mark locals as initialized.
8971
8972 * casefiddle.c (casify_object, casify_region): Now static.
8973 (casify_region): Mark local as initialized.
8974
8975 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8976
8977 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8978 New macros, so that the caller can use some names other than
8979 gcpro1, gcpro2, etc.
8980 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8981 of the new macros.
8982 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8983 argument, for consistency with GCPRO2_VAR, etc: it is now the
8984 prefix of the variable, not the variable itself. All uses
8985 changed.
8986 * dired.c (directory_files_internal, file_name_completion):
8987 Rename locals to avoid shadowing.
8988
8989 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8990 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8991 dired.c's scmp function, had undefined behavior.
8992 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8993 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8994 * buffer.h: ... to here, because these macros use current_buffer,
8995 and the new implementation with inline functions needs to have
8996 current_buffer in scope now, rather than later when the macros
8997 are used.
8998 (downcase, upcase1): New static inline functions.
8999 (DOWNCASE, UPCASE1): Reimplement using these functions.
9000 This avoids undefined behavior in expressions like
9001 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9002 from race conditions in accessing the global variables
9003 case_temp1 and case_temp2.
9004 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9005 * lisp.h (case_temp1, case_temp2): Remove their decls.
9006 * character.h (ASCII_CHAR_P): Move from here ...
9007 * lisp.h: ... to here, so that the inline functions mentioned
9008 above can use them.
9009
9010 * dired.c (directory_files_internal_unwind): Now static.
9011
9012 * fileio.c (file_name_as_directory, directory_file_name):
9013 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9014 Now static.
9015 (file_name_as_directory): Use const pointers when appropriate.
9016 (Fexpand_file_name): Likewise. In particular, newdir might
9017 point at constant storage, so make it a const pointer.
9018 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9019 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9020 signedness issues.
9021 (Fset_file_times, Finsert_file_contents, auto_save_error):
9022 Rename locals to avoid shadowing.
9023
9024 * minibuf.c (choose_minibuf_frame_1): Now static.
9025 (Ftry_completion, Fall_completions): Rename or remove locals
9026 to avoid shadowing.
9027
9028 * marker.c (bytepos_to_charpos): Remove; unused.
9029
9030 * lisp.h (verify_bytepos, count_markers): New decls,
9031 so that gcc does not warn that these functions aren't declared.
9032
9033 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9034 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9035 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9036 (copy_text): Remove unused local var.
9037
9038 * filelock.c (within_one_second): Now static.
9039 (lock_file_1): Rename local to avoid shadowing.
9040
9041 * buffer.c (fix_overlays_before): Mark locals as initialized.
9042 (fix_start_end_in_overlays): Likewise. This function should be
9043 simplified by using pointers-to-pointers, but that's a different
9044 matter.
9045 (switch_to_buffer_1): Now static.
9046 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9047 (report_overlay_modification): Rename locals to avoid shadowing.
9048
9049 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9050 Fix pointer signedness issue.
9051 (sys_subshell): Mark local as volatile if checking for lint,
9052 to suppress a gcc -Wclobbered warning that does not seem to be right.
9053 (MAXPATHLEN): Define only if needed.
9054
9055 * process.c (serial_open, serial_configure): Move decls from here ...
9056 * systty.h: ... to here, so that they can be checked.
9057
9058 * fns.c (get_random, seed_random): Move extern decls from here ...
9059 * lisp.h: ... to here, so that they can be checked.
9060
9061 * sysdep.c (reset_io): Now static.
9062 (wait_for_termination_signal): Remove; unused.
9063
9064 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9065 (copy_keymap_item, append_key, push_text_char_description):
9066 Now static.
9067 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9068 (DENSE_TABLE_SIZE): Remove; unused.
9069 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9070 (describe_map_tree):
9071 Rename locals to avoid shadowing.
9072
9073 * keyboard.c: Declare functions static if they are not used elsewhere.
9074 (echo_char, echo_dash, cmd_error, top_level_2):
9075 (poll_for_input, handle_async_input): Now static.
9076 (read_char, kbd_buffer_get_event, make_lispy_position):
9077 (make_lispy_event, make_lispy_movement, apply_modifiers):
9078 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9079 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9080 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9081 (read_key_sequence, read_char): Mark locals as initialized.
9082 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9083
9084 * keyboard.h (make_ctrl_char): New decl.
9085 (mark_kboards): Move decl here ...
9086 * alloc.c (mark_kboards): ... from here.
9087
9088 * lisp.h (force_auto_save_soon): New decl.
9089
9090 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9091 (DEFINE_DUMMY_FUNCTION): New macro.
9092 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9093 Use it.
9094 (main): Add casts to avoid warnings
9095 if GCC considers string literals to be constants.
9096
9097 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9098
9099 * dbusbind.c: Pointer signedness fixes.
9100 (xd_signature, xd_append_arg, xd_initialize):
9101 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9102 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9103 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9104 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9105
9106 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9107 if GCC considers string literals to be constants.
9108 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9109
9110 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9111
9112 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9113 (print_preprocess, print_object): New macro to fix last change.
9114
9115 * print.c (print_preprocess): Don't forget font objects.
9116
9117 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9118
9119 * emacs.c (USAGE3): Doc fixes.
9120
9121 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9122
9123 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9124 structure.
9125
9126 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9127
9128 * lisp.h (VWindow_system, Qfile_name_history):
9129 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9130 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9131 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9132
9133 * w32select.c: Don't #include "keyboard.h".
9134 (run_protected): Add extern declaration for waiting_for_input.
9135
9136 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9137 * w32console.c (detect_input_pending, read_input_pending)
9138 (encode_terminal_code):
9139 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9140 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9141 (w32_system_caret_y, Qfile_name_history):
9142 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9143 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9144 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9145 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9146 * w32proc.c (Qlocal, report_file_error):
9147 * w32term.c (Vwindow_system, updating_frame):
9148 * w32uniscribe.c (initialized, uniscribe_font_driver):
9149 Remove unneeded extern declarations.
9150
9151 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9152
9153 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9154
9155 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9156
9157 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9158 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9159 These macros can no longer be used for assignment.
9160
9161 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9162 Assign struct members directly, instead of using BUF_BEGV etc.
9163 (record_buffer_markers, fetch_buffer_markers): New functions for
9164 recording and fetching special buffer markers.
9165 (set_buffer_internal_1, set_buffer_temp): Use them.
9166
9167 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9168
9169 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9170
9171 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9172 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9173
9174 * xdisp.c (hscroll_window_tree):
9175 (reconsider_clip_changes): Use PT instead of BUF_PT.
9176
9177 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9178
9179 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9180 $(EMACS_ROOT)/lib/intprops.h.
9181
9182 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9183
9184 Fix more problems found by GCC 4.5.2's static checks.
9185
9186 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9187 to unsigned char * to avoid compiler diagnostic.
9188 (xg_free_frame_widgets): Make it clear that a local variable is
9189 needed only if USE_GTK_TOOLTIP.
9190 (gdk_window_get_screen): Make it clear that this macro is needed
9191 only if USE_GTK_TOOLTIP.
9192 (int_gtk_range_get_value): New function, which avoids a diagnostic
9193 from gcc -Wbad-function-cast.
9194 (xg_set_toolkit_scroll_bar_thumb): Use it.
9195 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9196 diagnostic from gcc -Wbad-function-cast.
9197 (get_utf8_string, xg_get_file_with_chooser):
9198 Rename locals to avoid shadowing.
9199 (create_dialog): Move locals to avoid shadowing.
9200
9201 * xgselect.c (xg_select): Remove unused var.
9202
9203 * image.c (four_corners_best): Mark locals as initialized.
9204 (gif_load): Initialize transparent_p to zero (Bug#8238).
9205 Mark another local as initialized.
9206 (my_png_error, my_error_exit): Mark with NO_RETURN.
9207
9208 * image.c (clear_image_cache): Now static.
9209 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9210 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9211 (x_edge_detection): Remove unnecessary cast that
9212 gcc -Wbad-function-cast diagnoses.
9213 (gif_load): Fix pointer signedness.
9214 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9215 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9216
9217 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9218
9219 Improve quality of tests for time stamp overflow.
9220 For example, without this patch (encode-time 0 0 0 1 1
9221 1152921504606846976) returns the obviously-bogus value (-948597
9222 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9223 reports time overflow. See
9224 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9225 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9226 * editfns.c: Include limits.h and intprops.h.
9227 (TIME_T_MIN, TIME_T_MAX): New macros.
9228 (time_overflow): Move earlier, to before first use.
9229 (hi_time, lo_time): New functions, for an accurate test for
9230 out-of-range times.
9231 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9232 (Fget_internal_run_time): Don't assume time_t fits in int.
9233 (make_time): Use list2 instead of Fcons twice.
9234 (Fdecode_time): More accurate test for out-of-range times.
9235 (check_tm_member): New function.
9236 (Fencode_time): Use it, to test for out-of-range times.
9237 (lisp_time_argument): Don't rely on undefined left-shift and
9238 right-shift behavior when checking for time stamp overflow.
9239
9240 * editfns.c (time_overflow): New function, refactoring common code.
9241 (Fformat_time_string, Fdecode_time, Fencode_time):
9242 (Fcurrent_time_string): Use it.
9243
9244 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9245 * dired.c (make_time): Move to ...
9246 * editfns.c (make_time): ... here.
9247 * systime.h: Note the move.
9248
9249 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9250
9251 * fringe.c (update_window_fringes): Remove unused variables.
9252
9253 * unexmacosx.c (copy_data_segment): Also copy __got section.
9254 (Bug#8223)
9255
9256 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9257
9258 * termcap.c [MSDOS]: Include "msdos.h".
9259 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9260 Constify `char *' arguments and their references according to
9261 prototypes in tparam.h.
9262
9263 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9264
9265 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9266 Adapt all references accordingly.
9267
9268 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9269
9270 2011-03-11 Tom Tromey <tromey@redhat.com>
9271
9272 * buffer.c (syms_of_buffer): Remove obsolete comment.
9273
9274 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9275
9276 * termhooks.h (encode_terminal_code): Declare prototype.
9277
9278 * msdos.c (encode_terminal_code): Don't declare prototype.
9279
9280 * term.c (encode_terminal_code): Now external again, used by
9281 w32console.c and msdos.c.
9282
9283 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9284 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9285
9286 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9287
9288 Fix some minor problems found by GCC 4.5.2's static checks.
9289
9290 * fringe.c (update_window_fringes): Mark locals as initialized
9291 (Bug#8227).
9292 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9293
9294 * alloc.c (mark_fringe_data): Move decl from here ...
9295 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9296 to check its interface.
9297 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9298
9299 * fontset.c (free_realized_fontset): Now static.
9300 (Fset_fontset_font): Rename local to avoid shadowing.
9301 (fontset_font): Mark local as initialized.
9302 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9303
9304 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9305
9306 * xselect.c (x_disown_buffer_selections): Remove; not used.
9307 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9308 (x_own_selection, Fx_disown_selection_internal): Rename locals
9309 to avoid shadowing.
9310 (x_handle_dnd_message): Remove local to avoid shadowing.
9311
9312 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9313 so that the caller can use some name other than gcpro1.
9314 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9315 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9316 (Fx_backspace_delete_keys_p):
9317 Use them to avoid shadowing, and rename vars to avoid shadowing.
9318 (x_decode_color, x_set_name, x_window): Now static.
9319 (Fx_create_frame): Add braces to silence GCC warning.
9320 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9321 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9322 Remove unused locals.
9323 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9324 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9325 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9326 macros.
9327
9328 * xterm.h (x_mouse_leave): New decl.
9329
9330 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9331 Remove unused functions.
9332 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9333 (x_calc_absolute_position): Now static.
9334 (XTread_socket): Don't define label "out" unless it's used.
9335 Don't declare local "event" unless it's used.
9336 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9337 unless they are used.
9338 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9339 (x_fatal_error_signal): Remove; not used.
9340 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9341 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9342 (x_error_catcher, x_connection_closed, x_error_handler):
9343 (x_error_quitter, xembed_send_message, x_iconify_frame):
9344 (my_log_handler): Rename locals to avoid shadowing.
9345 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9346 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9347
9348 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9349 Rename or move locals to avoid shadowing.
9350 (tty_defined_color, merge_face_heights): Now static.
9351 (free_realized_faces_for_fontset): Remove; not used.
9352 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9353 does not deduce is never used uninitialized.
9354 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9355 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9356
9357 * terminal.c (store_terminal_param): Now static.
9358
9359 * xmenu.c (menu_highlight_callback): Now static.
9360 (set_frame_menubar): Remove unused local.
9361 (xmenu_show): Rename parameter to avoid shadowing.
9362 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9363 since they might point to immutable storage.
9364 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9365 since it's unused otherwise.
9366
9367 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9368 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9369 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9370 avoids a gcc -Wuninitialized diagnostic.
9371 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9372 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9373 does not deduce are never used uninitialized.
9374
9375 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9376
9377 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9378 * window.c (window_loop, size_window):
9379 (run_window_configuration_change_hook, enlarge_window): Likewise.
9380
9381 * window.c (display_buffer): Now static.
9382 (size_window): Mark variables that gcc -Wuninitialized
9383 does not deduce are never used uninitialized.
9384 * window.h (check_all_windows): New decl, to forestall
9385 gcc -Wmissing-prototypes diagnostic.
9386 * dispextern.h (bidi_dump_cached_states): Likewise.
9387
9388 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9389 shadowing.
9390 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9391 Include <limits.h>.
9392 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9393 and to avoid gcc -Wuninitialized warning.
9394 (load_charset_map): Mark variables that gcc -Wuninitialized
9395 does not deduce are never used uninitialized.
9396 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9397
9398 * coding.c (coding_set_source, coding_set_destination):
9399 Use "else { /* comment */ }" rather than "else /* comment */;"
9400 for clarity, and to avoid gcc -Wempty-body warning.
9401 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9402 a block, when the outer 'i' will do.
9403 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9404 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9405 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9406 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9407 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9408 Rename locals to avoid shadowing.
9409 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9410 * coding.c (emacs_mule_char, encode_invocation_designation):
9411 Now static, since they're not used elsewhere.
9412 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9413 (decode_coding_object, encode_coding_object, detect_coding_system):
9414 (decode_coding_emacs_mule): Mark variables that gcc
9415 -Wuninitialized does not deduce are never used uninitialized.
9416 (detect_coding_iso_2022): Initialize a local variable that might
9417 be used uninitialized. Leave a FIXME because it's not clear that
9418 this initialization is needed. (Bug#8211)
9419 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9420 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9421 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9422 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9423 Remove unused macros.
9424
9425 * category.c (hash_get_category_set): Remove unused local var.
9426 (copy_category_table): Now static, since it's not used elsewhere.
9427 * character.c (string_count_byte8): Likewise.
9428
9429 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9430 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9431
9432 * chartab.c (copy_sub_char_table): Now static, since it's not used
9433 elsewhere.
9434 (sub_char_table_ref_and_range, char_table_ref_and_range):
9435 Rename locals to avoid shadowing.
9436 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9437
9438 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9439 (BIDI_BOB): Remove unused macro.
9440
9441 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9442 deduce are never used uninitialized.
9443 * term.c (encode_terminal_code): Likewise.
9444
9445 * term.c (encode_terminal_code): Now static. Remove unused local.
9446
9447 * tparam.h: New file.
9448 * term.c, tparam.h: Include it.
9449 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9450 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9451 Move these decls to tparam.h, and make them agree with what
9452 is actually in tparam.c. The previous trick of using incompatible
9453 decls in different modules does not conform to the C standard.
9454 All callers of tparam changed to use tparam's actual API.
9455 * tparam.c (tparam1, tparam, tgoto):
9456 Use const pointers where appropriate.
9457
9458 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9459 * cm.h (struct cm): Likewise.
9460 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9461 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9462 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9463 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9464 (turn_on_face, init_tty): Likewise.
9465 * termchar.h (struct tty_display_info): Likewise.
9466
9467 * term.c (term_mouse_position): Rename local to avoid shadowing.
9468
9469 * alloc.c (mark_ttys): Move decl from here ...
9470 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9471
9472 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9473
9474 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9475
9476 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9477
9478 * search.c (compile_pattern_1): Remove argument regp, unused since
9479 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9480 (compile_pattern): Don't pass it.
9481
9482 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9483
9484 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9485 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9486 for ! HAVE_GTK3.
9487 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9488
9489 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9490
9491 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9492 gdk_window_get_screen, gdk_window_get_geometry,
9493 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9494 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9495 (xg_get_pixbuf_from_pixmap): New function.
9496 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9497 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9498 Call xg_get_pixbuf_from_pixmap instead of
9499 gdk_pixbuf_get_from_drawable.
9500 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9501 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9502 (xg_check_special_colors): Use GtkStyleContext and its functions
9503 for HAVE_GTK3.
9504 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9505 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9506 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9507 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9508 Call gtk_widget_get_preferred_size.
9509 (xg_frame_resized): gdk_window_get_geometry only takes 5
9510 parameters.
9511 (xg_win_to_widget, xg_event_is_for_menubar):
9512 Call gdk_x11_window_lookup_for_display.
9513 (xg_set_widget_bg): New function.
9514 (delete_cb): New function.
9515 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9516 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9517 (xg_set_background_color): Call xg_set_widget_bg.
9518 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9519 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9520 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9521 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9522 if ! HAVE_GTK3.
9523 (update_frame_tool_bar): Call gtk_widget_hide.
9524 (xg_initialize): Use GDK_KEY_g.
9525
9526 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9527 if ! HAVE_GTK3
9528 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9529
9530 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9531 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9532 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9533
9534 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9535
9536 * w32xfns.c (select_palette): Check success of RealizePalette against
9537 GDI_ERROR, not zero.
9538
9539 See ChangeLog.11 for earlier changes.
9540
9541 ;; Local Variables:
9542 ;; coding: utf-8
9543 ;; End:
9544
9545 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9546
9547 This file is part of GNU Emacs.
9548
9549 GNU Emacs is free software: you can redistribute it and/or modify
9550 it under the terms of the GNU General Public License as published by
9551 the Free Software Foundation, either version 3 of the License, or
9552 (at your option) any later version.
9553
9554 GNU Emacs is distributed in the hope that it will be useful,
9555 but WITHOUT ANY WARRANTY; without even the implied warranty of
9556 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9557 GNU General Public License for more details.
9558
9559 You should have received a copy of the GNU General Public License
9560 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.