1 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3 * bidi.c (bidi_fetch_char): Fix the type of `len' according to
4 what STRING_CHAR_AND_LENGTH expects.
6 * xdisp.c (move_it_in_display_line_to): Record prev_method and
7 prev_pos immediately before the call to set_iterator_to_next.
8 Fixes cursor motion in bidi-reordered lines with stretch glyphs
9 and strings displayed in margins. (Bug#8133) (Bug#8867)
10 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
12 (pos_visible_p): Support positions in bidi-reordered lines. Save
13 and restore bidi cache.
15 2011-07-08 Eli Zaretskii <eliz@gnu.org>
17 * xdisp.c (move_it_in_display_line_to): If iterator ended up at
18 EOL, but we never saw any buffer positions smaller than
19 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
20 motion in bidi-reordered lines.
22 2011-07-07 Eli Zaretskii <eliz@gnu.org>
24 * xdisp.c (find_row_edges): If ROW->start.pos gives position
25 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
27 2011-07-05 Eli Zaretskii <eliz@gnu.org>
29 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
30 cache around display iteration.
32 * window.c (Fwindow_end, window_scroll_pixel_based)
33 (displayed_window_lines, Frecenter): Save and restore the bidi
34 cache around display iteration.
36 * bidi.c (bidi_unshelve_cache): Ensure we have enough space before
37 restoring the shelved cache.
38 (bidi_cache_ensure_space): Don't assume the required size is just
39 one BIDI_CACHE_CHUNK away.
41 * xdisp.c (back_to_previous_visible_line_start, reseat_1)
42 (init_iterator): Empty the bidi cache "stack".
44 2011-07-03 Eli Zaretskii <eliz@gnu.org>
46 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): New functions.
48 * dispextern.h (bidi_shelve_cache, bidi_unshelve_cache): Declare
51 * xdisp.c (SAVE_IT, RESTORE_IT): New macros.
52 (pos_visible_p, face_before_or_after_it_pos)
53 (back_to_previous_visible_line_start)
54 (move_it_in_display_line_to, move_it_in_display_line)
55 (move_it_to, move_it_vertically_backward, move_it_by_lines)
56 (try_scrolling, redisplay_window, display_line): Use them when
57 saving a temporary copy of the iterator and restoring it back.
59 2011-07-02 Eli Zaretskii <eliz@gnu.org>
61 * xdisp.c (reseat_1): Call bidi_init_it to resync the bidi
62 iterator with IT's position. (Bug#7616)
63 (handle_stop, back_to_previous_visible_line_start, reseat_1):
64 Reset the from_disp_prop_p flag.
66 * bidi.c (bidi_cache_search): Don't assume bidi_cache_last_idx is
67 always valid if bidi_cache_idx is valid.
68 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
69 is valid if it's going to be used.
71 * dispextern.h (struct iterator_stack_entry, struct it): New
72 member from_disp_prop_p.
74 * xdisp.c (push_it, pop_it): Save and restore from_disp_prop_p.
75 (handle_single_display_spec, push_display_prop): Set the
76 from_disp_prop_p flag.
77 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
78 (pop_it): Call iterate_out_of_display_property only if we are
79 popping after iteration over a string that came from a display
80 property. Fix a typo in popping stretch info. Add an assertion
81 for verifying that the iterator position is in sync with the bidi
83 (handle_single_display_spec, get_overlay_strings_1)
84 (push_display_prop): Fix initialization of paragraph direction for
85 string when that of the parent object is not yet determined.
87 2011-07-01 Eli Zaretskii <eliz@gnu.org>
89 * dispextern.h (struct bidi_string_data): New member `unibyte'.
91 * xdisp.c (handle_single_display_spec, next_overlay_string)
92 (get_overlay_strings_1, reseat_1, reseat_to_string)
93 (push_display_prop): Set up the `unibyte' member of bidi_it.string
94 correctly. Don't assume unibyte strings are not bidi-reordered.
95 (compute_display_string_pos)
96 (compute_display_string_end): Fix handling the case of C string.
98 * bidi.c (bidi_count_bytes, bidi_char_at_pos): Accept an
99 additional argument UNIBYTE, and support unibyte strings. All
101 (bidi_fetch_char): Support unibyte strings.
103 2011-06-25 Eli Zaretskii <eliz@gnu.org>
105 * xdisp.c (set_iterator_to_next, get_visually_first_element): Use
106 it->bidi_it.string.schars rather than it->string_nchars when
107 testing whether we're beyond string end, because string_nchars is
108 zero for strings that come from overlays and display properties.
110 * bidi.c (bidi_cache_iterator_state): Fix a bug with testing
111 character positions against the cached range, when we use a
114 * xdisp.c (push_it, pop_it): Save and restore it.
116 * dispextern.h (struct iterator_stack_entry): New member
119 * xdisp.c (handle_single_display_spec, next_overlay_string)
120 (get_overlay_strings_1, push_display_prop): Set up the bidi
121 iterator for displaying display or overlay strings.
122 (forward_to_next_line_start): Don't use the shortcut if
124 (back_to_previous_visible_line_start): If handle_display_prop
125 pushed the iterator stack, restore the internal state of the bidi
126 iterator by calling bidi_pop_it same number of times.
127 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
128 and we are bidi-iterating, don't decrement the iterator position;
129 instead, set the first_elt flag in the bidi iterator, to produce
131 (reseat_1): Remove redundant setting of string_from_display_prop_p.
132 (push_display_prop): xassert that we are iterating a buffer.
134 * bidi.c (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
136 2011-06-24 Eli Zaretskii <eliz@gnu.org>
138 * xdisp.c (push_it, pop_it): Save and restore the state of the
139 bidi iterator. Save and restore the bidi_p flag.
140 (pop_it): Iterate out of display property for string iteration as
142 (iterate_out_of_display_property): Support iteration over strings.
143 (handle_single_display_spec): Set up it->bidi_it for iteration
144 over a display string, and call bidi_init_it.
146 * dispextern.h (struct iterator_stack_entry): New member bidi_p.
147 (struct it): Member bidi_p is now a bit field 1 bit wide.
149 2011-06-23 Eli Zaretskii <eliz@gnu.org>
151 * dispextern.h (bidi_push_it, bidi_pop_it): Add prototypes.
153 * bidi.c (bidi_push_it, bidi_pop_it): New functions.
154 (bidi_initialize): Initialize the bidi cache start stack pointer.
155 (bidi_cache_ensure_space): New function, refactored from part of
156 bidi_cache_iterator_state.
158 2011-06-18 Eli Zaretskii <eliz@gnu.org>
160 * xdisp.c (tool_bar_lines_needed, redisplay_tool_bar)
161 (display_menu_bar): Force left-to-right direction. Add a FIXME
162 comment for making that be controlled by a user option.
164 * bidi.c (bidi_move_to_visually_next): GCPRO the Lisp string we
167 * term.c (produce_glyphs): Add IT_GLYPHLESS to the values of
168 it->what accepted by the xassert. Fixes a gratuitous crash in an
169 Emacs built with -DXASSERTS.
171 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
172 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
173 and vector-like objects.
175 * xdisp.c (face_before_or_after_it_pos): Support bidi iteration.
176 (next_element_from_c_string): Handle the case of the first string
177 character that is not the first one in the visual order.
178 (get_visually_first_element): New function, refactored from common
179 parts of next_element_from_buffer, next_element_from_string, and
180 next_element_from_c_string.
182 2011-06-16 Eli Zaretskii <eliz@gnu.org>
184 * xdisp.c (init_iterator): Don't initialize it->bidi_p for strings
186 (reseat_to_string): Initialize it->bidi_p for strings here.
187 (next_element_from_string, next_element_from_c_string)
188 (next_element_from_buffer): Add xassert's for correspondence
189 between IT's object being iterated and it->bidi_it.string
192 * bidi.c (bidi_level_of_next_char): Fix the logic for looking up
193 the sentinel state in the cache.
195 2011-06-13 Eli Zaretskii <eliz@gnu.org>
197 * xdisp.c (compute_display_string_pos)
198 (compute_display_string_end, reseat_to_string): Don't assume
199 it->bidi_it.string.s always points to string.lstring's data.
201 * bidi.c (bidi_fetch_char, bidi_paragraph_init)
202 (bidi_resolve_explicit_1, bidi_resolve_explicit)
203 (bidi_resolve_weak, bidi_level_of_next_char): Don't assume
204 string.s always points to string.lstring's data.
206 2011-06-11 Eli Zaretskii <eliz@gnu.org>
208 * xdisp.c (set_iterator_to_next): Advance string position
209 correctly when padding it with blanks.
211 2011-06-11 Eli Zaretskii <eliz@gnu.org>
213 * xdisp.c (next_element_from_buffer): Improve commentary for when
214 the iterator is before prev_stop.
215 (init_iterator): Initialize bidi_p from the default value of
216 bidi-display-reordering, not from buffer-local value. Use the
217 buffer-local value only if initializing for buffer iteration.
218 (handle_invisible_prop): Support invisible properties on strings
219 that are being bidi-reordered.
220 (reseat_to_string): Enable bidi-related code.
221 (set_iterator_to_next): Support bidi reordering of C strings and
223 (next_element_from_string): Support bidi reordering of Lisp
225 (handle_stop_backwards): Support Lisp strings as well.
226 (display_mode_line, display_mode_element): Temporarily force L2R
228 (display_string): Support display of R2L glyph rows. Use
229 IT_STRING_CHARPOS when displaying from a Lisp string.
231 2011-06-10 Eli Zaretskii <eliz@gnu.org>
233 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
235 (compute_display_string_pos, compute_display_string_end):
236 Fix calculation of the object to scan. Fixes an error when using
238 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
239 base_level_stop; instead, set base_level_stop to BEGV. Fixes
240 crashes in vertical-motion.
242 2011-06-09 Eli Zaretskii <eliz@gnu.org>
244 * xdisp.c (compute_display_string_pos): First arg is now struct
245 `text_pos *'; all callers changed. Support display properties on
247 (compute_display_string_end): Support display properties on Lisp
249 (init_iterator, reseat_1, reseat_to_string): Initialize the
250 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
251 when iterating on a string not from display properties).
253 * bidi.c (bidi_fetch_char): Support strings with display
256 * dispextern.h (struct bidi_string_data): New member bufpos.
257 (compute_display_string_pos): Update prototype.
259 2011-06-09 Eli Zaretskii <eliz@gnu.org>
261 * bidi.c (bidi_level_of_next_char): Allow the sentinel "position"
262 to pass the test for valid cached positions.
264 * xdisp.c (init_iterator): Call bidi_init_it only of a valid
265 buffer position was specified. Initialize paragraph_embedding to
267 (reseat_to_string): Initialize the bidi iterator (for now ifdef'ed
269 (display_string): If we need to ignore text properties of
270 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
271 original value of -1 will not work with bidi.)
273 * dispextern.h (struct bidi_string_data): New member lstring.
275 2011-06-09 Eli Zaretskii <eliz@gnu.org>
277 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
278 itb.string.s to NULL (avoids a crash in bidi_paragraph_init).
280 2011-06-08 Eli Zaretskii <eliz@gnu.org>
282 * bidi.c (bidi_paragraph_info): Delete unused struct.
283 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
284 (bidi_cache_start): New variable.
285 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
287 (bidi_cache_fetch_state, bidi_cache_search)
288 (bidi_cache_find_level_change, bidi_cache_iterator_state)
289 (bidi_cache_find, bidi_peek_at_next_level)
290 (bidi_level_of_next_char, bidi_find_other_level_edge)
291 (bidi_move_to_visually_next): Compare cache index with
292 bidi_cache_start rather than with zero.
293 (bidi_fetch_char): Accept new argument STRING; all callers
294 changed. Support iteration over a string.
295 (bidi_paragraph_init, bidi_resolve_explicit_1)
296 (bidi_resolve_explicit, bidi_resolve_weak)
297 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
298 iteration over a string.
299 (bidi_set_sor_type, bidi_resolve_explicit_1)
300 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
301 can now be zero (for strings); special values 0 and -1 were
302 changed to -1 and -2, respectively.
303 (bidi_char_at_pos): New function.
304 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
305 Call it instead of FETCH_MULTIBYTE_CHAR.
306 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
307 initialized to valid values.
308 (bidi_init_it): Don't initialize charpos and bytepos with invalid
311 * xdisp.c (compute_display_string_pos)
312 (compute_display_string_end): Accept additional argument STRING.
313 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
314 (reseat_to_string): Initialize bidi_it->string.s and
315 bidi_it->string.schars.
317 * dispextern.h (struct bidi_string_data): New structure.
318 (struct bidi_it): New member `string'. Make flag members be 1-bit
319 fields, and put them last in the struct.
320 (compute_display_string_pos, compute_display_string_end): Update
323 2011-06-04 Eli Zaretskii <eliz@gnu.org>
325 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
327 2011-06-03 Eli Zaretskii <eliz@gnu.org>
329 * bidi.c (bidi_fetch_char_advance): Remove unused and
330 unimplemented function.
332 2011-05-28 Eli Zaretskii <eliz@gnu.org>
334 * xdisp.c (set_cursor_from_row): Set start and stop points
335 according to the row's direction when priming the loop that looks
336 for the glyph on which to display cursor.
337 (single_display_spec_intangible_p): Function deleted.
338 (display_prop_intangible_p): Reimplement to call
339 handle_display_spec instead of single_display_spec_intangible_p.
340 Accept 3 additional arguments needed by handle_display_spec. This
341 fixes incorrect cursor motion across display property with complex
342 values: lists, `(when COND...)' forms, etc.
343 (single_display_spec_string_p): Support property values that are
344 lists with the argument STRING its top-level element.
345 (display_prop_string_p): Fix the condition for processing a
346 property that is a list to be consistent with handle_display_spec.
348 * keyboard.c (adjust_point_for_property): Adjust the call to
349 display_prop_intangible_p to its new signature.
351 * dispextern.h (display_prop_intangible_p): Adjust prototype.
353 2011-05-21 Eli Zaretskii <eliz@gnu.org>
355 * xdisp.c (handle_display_spec): New function, refactored from the
356 last portion of handle_display_prop.
357 (compute_display_string_pos): Accept additional argument
358 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
359 value of a `display' property is a "replacing spec".
360 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
361 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
362 the display property, but just return a value indicating whether
363 the display property will replace the characters it covers.
364 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
365 frame_window_p members of struct bidi_it.
367 * bidi.c (bidi_fetch_char): Accept additional argument
368 FRAME_WINDOW_P and pass it to compute_display_string_pos. All
370 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
371 it to initialize the frame_window_p member of struct bidi_it.
373 * dispextern.h (struct bidi_it): New member frame_window_p.
374 (bidi_init_it, compute_display_string_pos): Update prototypes.
376 2011-05-14 Eli Zaretskii <eliz@gnu.org>
378 * xdisp.c (compute_display_string_pos): Non-trivial implementation.
379 (compute_display_string_end): New function.
380 (push_it): Accept second argument POSITION, where pop_it should
381 jump to continue iteration.
383 * dispextern.h (compute_display_string_end): Declare prototype.
385 * bidi.c (bidi_resolve_explicit_1): Use ZV for disp_pos.
386 (bidi_fetch_char): Implement support for runs of characters
387 covered by display strings.
389 * bidi.c (bidi_fetch_char): Accept also character position
390 corresponding to BYTEPOS. DISP_POS is now a character position,
391 not a byte position. All callers changed.
392 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
393 (bidi_resolve_explicit, bidi_resolve_weak)
394 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
395 bidi_it->nchars is non-positive.
396 (bidi_level_of_next_char): Don't try to lookup the cache for the
397 next/previous character if nothing is cached there yet, or if we
398 were just reseat()'ed to a new position.
399 (bidi_paragraph_init, bidi_resolve_explicit_1)
400 (bidi_level_of_next_char): Fix arguments in the calls to
403 2011-05-10 Eli Zaretskii <eliz@gnu.org>
405 * xdisp.c (compute_display_string_pos): New function.
406 (reseat_1): Initialize bidi_it.disp_pos.
408 * bidi.c (bidi_copy_it): Use offsetof.
409 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
410 (bidi_cache_search, bidi_cache_iterator_state)
411 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
412 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
413 character positions inside a run of characters covered by a
415 (bidi_paragraph_init, bidi_resolve_explicit_1)
416 (bidi_level_of_next_char): Call bidi_fetch_char and
417 bidi_fetch_char_advance instead of FETCH_CHAR and
419 (bidi_init_it): Initialize new members.
420 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
422 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
423 instead of using explicit *_CHAR codes.
424 (bidi_resolve_explicit, bidi_resolve_weak): Use
425 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
426 bidirectional text is supported only in multibyte buffers.
428 * dispextern.h (struct bidi_it): New members nchars and disp_pos.
429 ch_len is now EMACS_INT.
430 (compute_display_string_pos): Declare prototype.
432 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
434 * w32menu.c (set_frame_menubar): Fix submenu allocation.
436 2011-05-07 Eli Zaretskii <eliz@gnu.org>
438 * w32console.c (Fset_screen_color): Doc fix.
439 (Fget_screen_color): New function.
440 (syms_of_ntterm): Defsubr it.
442 * callproc.c (call_process_cleanup): Don't close and unlink the
443 temporary file if Fcall_process didn't create it in the first
445 (Fcall_process): Don't create tempfile if stdout of the child
446 process will be redirected to a file specified with `:file'.
447 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
448 cue to call_process_cleanup not to close that handle.
450 2011-05-07 Ben Key <bkey76@gmail.com>
452 * makefile.w32-in: The bootstrap-temacs rule now makes use of
453 one of two shell specific rules, either bootstrap-temacs-CMD or
454 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
455 to the previous implementation of the bootstrap-temacs rule.
456 The bootstrap-temacs-CMD rule is similar to the previous
457 implementation of the bootstrap-temacs rule except that it
458 makes use of the ESC_CFLAGS variable instead of the CFLAGS
461 These changes, along with some changes to nt/configure.bat,
462 nt/gmake.defs, and nt/nmake.defs, are required to extend my
463 earlier fix to add support for --cflags and --ldflags options
464 that include quotes so that it works whether make uses cmd or
467 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
469 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
470 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
472 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
473 a string. Handle both cases.
474 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
475 (Fdbus_register_method): Use Qinvalid_function.
477 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
479 * makefile.w32-in: Update dependencies.
480 (LISP_H): Add inttypes.h and stdin.h.
481 (PROCESS_H): Add unistd.h.
483 2011-05-06 Eli Zaretskii <eliz@gnu.org>
485 * lread.c: Include limits.h (fixes the MS-Windows build broken by
486 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
488 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
490 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
492 * term.c (vfatal): Remove stray call to va_end.
493 It's not needed and the C Standard doesn't allow it here anyway.
495 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
496 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
498 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
501 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
503 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
505 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
507 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
509 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
511 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
512 * charset.c (Fdefine_charset_internal): Don't initialize
513 charset.code_space[15]. The value was garbage, on hosts with
514 32-bit int (Bug#8600).
516 * lread.c (read_integer): Be more consistent with string-to-number.
517 Use string_to_number to do the actual conversion; this avoids
518 rounding errors and fixes some other screwups. Without this fix,
519 for example, #x1fffffffffffffff was misread as -2305843009213693952.
520 (digit_to_number): Move earlier, for benefit of read_integer.
521 Return -1 if the digit is out of range for the base, -2 if it is
522 not a digit in any supported base. (Bug#8602)
524 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
526 * dispnew.c (scrolling_window): Return 1 if we scrolled,
527 to match comment at start of function. This also removes a
528 GCC warning about overflow in a 32+64-bit port.
530 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
532 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
533 Reported by Stefan Monnier in
534 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
535 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
536 SYMBOLP-guarded XSYMBOL, not XPNTR.
538 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
539 (EMACS_UINTPTR): Likewise, with uintptr_t.
541 * lisp.h: Prefer 64-bit EMACS_INT if available.
542 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
543 on 32-bit hosts that have 64-bit int, so that they can access
545 However, temporarily disable this change unless the temporary
546 symbol WIDE_EMACS_INT is defined.
548 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
550 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
551 This removes an assumption that EMACS_INT and long are the same
552 width as pointers. The assumption is true for Emacs porting targets
553 now, but we want to make other targets possible.
554 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
555 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
556 In the rest of the code, change types of integers that hold casted
557 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
558 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
559 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
560 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
561 No need to cast type when ORing.
562 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
563 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
564 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
565 assume EMACS_INT is the same width as char *.
566 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
567 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
568 Remove no-longer-needed casts.
569 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
570 (xg_tool_bar_help_callback, xg_make_tool_item):
571 Use EMACS_INTPTR to hold an integer
572 that will be cast to void *; this can avoid a GCC warning
573 if EMACS_INT is not the same width as void *.
574 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
575 * xdisp.c (display_echo_area_1, resize_mini_window_1):
576 (current_message_1, set_message_1):
577 Use a local to convert to proper width without a cast.
578 * xmenu.c (dialog_selection_callback): Likewise.
580 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
581 Also, don't assume VALBITS / RAND_BITS is less than 5,
582 and don't rely on undefined behavior when shifting a 1 left into
584 * lisp.h (get_random): Change signature to match.
586 * lread.c (hash_string): Use size_t, not int, for hash computation.
587 Normally we prefer signed values; but hashing is special, because
588 it's better to use unsigned division on hash table sizes so that
589 the remainder is nonnegative. Also, size_t is the natural width
590 for hashing into memory. The previous code used 'int', which doesn't
591 retain enough info to hash well into very large tables.
592 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
594 * dbusbind.c: Don't possibly lose pointer info when converting.
595 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
596 Use XPNTR rather than XHASH, so that the high-order bits of
597 the pointer aren't lost when converting through void *.
599 * eval.c (Fautoload): Don't double-shift a pointer.
601 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
603 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
605 * gnutls.c (DEF_GNUTLS_FN):
606 * image.c (DEF_IMGLIB_FN): Make function pointers static.
608 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
610 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
613 2011-05-05 Eli Zaretskii <eliz@gnu.org>
615 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
616 New version that can reserve upto 2GB of heap space.
618 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
620 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
622 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
624 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
625 `gnutls_certificate_set_x509_key_file'.
627 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
629 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
632 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
634 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
635 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
636 Remove unused parameter `fildes'.
637 * process.c (read_process_output, send_process): Don't pass it.
639 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
641 Fix previous change: the library cache is defined in w32.c.
642 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
643 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
645 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
647 Implement dynamic loading of GnuTLS on Windows.
649 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
650 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
651 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
654 * gnutls.c (Qgnutls_dll): Define.
655 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
656 (gnutls_*): Declare function pointers.
657 (init_gnutls_functions): New function to initialize function pointers.
658 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
659 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
660 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
661 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
662 (emacs_gnutls_write, emacs_gnutls_read)
663 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
664 (Fgnutls_available_p): New function.
665 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
666 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
667 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
669 * image.c: Include w32.h.
670 (Vimage_type_cache): Delete.
671 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
672 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
673 (w32_delayed_load): Move to w32.c.
675 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
677 * w32.c (QCloaded_from, Vlibrary_cache): Define.
678 (w32_delayed_load): Move from image.c. When loading a library, record
679 its filename in the :loaded-from property of the library id.
680 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
681 Initialize and staticpro them.
682 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
684 * process.c: Include lisp.h before w32.h, not after.
685 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
686 instead of gnutls_record_check_pending.
688 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
690 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
692 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
693 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
696 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
698 * xterm.c (x_set_frame_alpha): Do not set property on anything
699 else than FRAME_X_OUTER_WINDOW (Bug#8608).
701 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
703 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
705 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
707 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
708 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
709 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
710 (gnutls_global_initialized, Qgnutls_bootprop_priority)
711 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
712 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
713 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
714 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
715 (Qgnutls_bootprop_callbacks_verify): Make static.
717 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
719 * callproc.c: Indentation fixup.
721 * sysdep.c (wait_for_termination_1): Make static.
722 (wait_for_termination, interruptible_wait_for_termination): Move
723 after wait_for_termination_1.
725 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
727 * sysdep.c (interruptible_wait_for_termination): New function
728 which is like wait_for_termination, but allows keyboard
731 * callproc.c (Fcall_process): Add (:file "file") as an option for
733 (Fcall_process_region): Ditto.
735 2011-04-30 Eli Zaretskii <eliz@gnu.org>
737 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
738 rather than `XVECTOR (FOO)->size'.
740 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
741 inttypes.h, as a gnulib replacement is used if it not available in
744 2011-04-21 Eli Zaretskii <eliz@gnu.org>
746 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
747 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
748 of MOST_POSITIVE_FIXNUM. (Bug#8528)
750 * coding.c (coding_alloc_by_realloc): Error out if destination
751 will grow beyond MOST_POSITIVE_FIXNUM.
752 (decode_coding_emacs_mule): Abort if there isn't enough place in
753 charbuf for the composition carryover bytes. Reserve an extra
754 space for up to 2 characters produced in a loop.
755 (decode_coding_iso_2022): Abort if there isn't enough place in
756 charbuf for the composition carryover bytes.
758 2011-04-21 Eli Zaretskii <eliz@gnu.org>
760 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
761 aborting when %lld or %lll format is passed.
762 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
763 %llo or %llx format is passed. (Bug#8545)
765 * window.c (window_scroll_line_based): Use a marker instead of
766 simple variables to record original value of point. (Bug#7952)
768 * doprnt.c (doprnt): Fix the case where a multibyte sequence
769 produced by %s or %c overflows available buffer space. (Bug#8545)
771 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
773 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
774 (SIZE_MAX): Move defn after all includes, as they might #define it.
776 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
778 * w32.c (init_environment): Warn about defaulting HOME to C:\.
780 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
782 * keyboard.c (Qdelayed_warnings_hook): Define.
783 (command_loop_1): Run `delayed-warnings-hook'
784 if Vdelayed_warnings_list is non-nil.
785 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
786 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
788 2011-04-28 Eli Zaretskii <eliz@gnu.org>
790 * doprnt.c (doprnt): Don't return value smaller than the buffer
791 size if the message was truncated. (Bug#8545).
793 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
795 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
796 (Fx_window_property): #if-0 the whole functions, not just the bodies.
798 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
800 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
802 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
804 * makefile.w32-in: Update dependencies.
806 2011-04-27 Eli Zaretskii <eliz@gnu.org>
808 Improve `doprnt' and its usage. (Bug#8545)
809 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
810 `format_end'. Remove support for %l as a conversion specifier.
811 Don't use xrealloc. Improve diagnostics when the %l size modifier
812 is used. Update the commentary.
814 * eval.c (verror): Simplify calculation of size_t.
816 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
819 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
821 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
824 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
826 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
827 This makes this file independent of the recent pseudovector change.
829 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
831 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
833 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
834 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
836 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
838 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
839 GCC 4.6.0 optimizes based on type-based alias analysis. For
840 example, if b is of type struct buffer * and v of type struct
841 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
842 != &v->size, and therefore "v->size = 1; b->size = 2; return
843 v->size;" must therefore return 1. This assumption is incorrect
844 for Emacs, since it type-puns struct Lisp_Vector * with many other
845 types. To fix this problem, this patch adds a new type struct
846 vectorlike_header that documents the constraints on layout of vectors
847 and pseudovectors, and helps optimizing compilers not get fooled
848 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
849 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
850 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
852 (XSETPVECTYPE): Rewrite in terms of new macro.
853 (XSETPVECTYPESIZE): New macro, specifying both type and size.
854 This is a bit clearer, and further avoids the possibility of
855 undesirable aliasing.
856 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
857 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
858 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
859 since Lisp_Subr is a special case (no "next" field).
860 (ASIZE): Now uses header.size rather than size. All
861 previous uses of XVECTOR (foo)->size replaced to use this macro,
862 to avoid the hassle of writing XVECTOR (foo)->header.size.
863 (struct vectorlike_header): New type.
864 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
865 object, to help avoid aliasing.
866 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
867 (SUBRP): Likewise, since Lisp_Subr is a special case.
868 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
869 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
870 (struct Lisp_Hash_Table): Combine first two members into a single
871 struct vectorlike_header member. All uses of "size" and "next" members
872 changed to be "header.size" and "header.next".
873 * buffer.h (struct buffer): Likewise.
874 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
875 * frame.h (struct frame): Likewise.
876 * process.h (struct Lisp_Process): Likewise.
877 * termhooks.h (struct terminal): Likewise.
878 * window.c (struct save_window_data, struct saved_window): Likewise.
879 * window.h (struct window): Likewise.
880 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
881 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
882 * buffer.c (init_buffer_once): Likewise.
883 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
885 * process.c (Fformat_network_address): Use local var for size,
888 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
890 Make the Lisp reader and string-to-float more consistent (Bug#8525)
891 * data.c (atof): Remove decl; no longer used or needed.
892 (digit_to_number): Move to lread.c.
893 (Fstring_to_number): Use new string_to_number function, to be
894 consistent with how the Lisp reader treats infinities and NaNs.
895 Do not assume that floating-point numbers represent EMACS_INT
896 without losing information; this is not true on most 64-bit hosts.
897 Avoid double-rounding errors, by insisting on integers when
898 parsing non-base-10 numbers, as the documentation specifies.
899 * lisp.h (string_to_number): New decl, replacing ...
900 (isfloat_string): Remove.
901 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
902 (read1): Do not accept +. and -. as integers; this
903 appears to have been a coding error. Similarly, do not accept
904 strings like +-1e0 as floating point numbers. Do not report
905 overflow for integer overflows unless the base is not 10 which
906 means we have no simple and reliable way to continue.
907 Break out the floating-point parsing into a new
908 function string_to_number, so that Fstring_to_number parses
909 floating point numbers consistently with the Lisp reader.
910 (digit_to_number): Moved here from data.c. Make it static inline.
911 (E_CHAR, EXP_INT): Remove, replacing with ...
912 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
913 (string_to_number): New function, replacing isfloat_string.
914 This function checks for valid syntax and produces the resulting
915 Lisp float number too. Rework it so that string-to-number
916 no longer mishandles examples like "1.0e+". Use strtoumax,
917 so that overflow for non-base-10 numbers is reported only when
918 there's no portable and simple way to convert to floating point.
920 * textprop.c (set_text_properties_1): Rewrite for clarity,
921 and to avoid GCC warning about integer overflow.
923 * intervals.h (struct interval): Use EMACS_INT for members
924 where EMACS_UINT might cause problems. See
925 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
926 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
927 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
929 (offset_intervals): Tell GCC not to worry about length overflow
930 when negating a negative length.
932 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
933 (overrun_check_free): Likewise.
935 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
936 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
939 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
940 (gnutls_make_error): Rename local to avoid shadowing.
941 (gnutls_emacs_global_deinit): ifdef out; not used.
942 (Fgnutls_boot): Use const for pointer to readonly storage.
943 Comment out unused local. Fix pointer signedness problems.
945 * lread.c (openp): Don't stuff size_t into an 'int'.
946 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
947 about possible signed overflow.
949 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
950 (GDK_KEY_g): Don't define if already defined.
951 (xg_prepare_tooltip): Avoid pointer signedness problem.
952 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
954 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
955 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
957 * xfns.c (Fx_window_property): Simplify a bit,
958 to make a bit faster and to avoid GCC 4.6.0 warning.
959 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
961 * fns.c (internal_equal): Don't assume size_t fits in int.
963 * alloc.c (compact_small_strings): Tighten assertion a little.
965 Replace pEd with more-general pI, and fix some printf arg casts.
966 * lisp.h (pI): New macro, generalizing old pEd macro to other
967 conversion specifiers. For example, use "...%"pI"d..." rather
969 (pEd): Remove. All uses replaced with similar uses of pI.
970 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
971 * alloc.c (check_pure_size): Don't overflow by converting size to int.
972 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
973 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
974 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
975 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
976 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
978 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
979 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
980 * print.c (safe_debug_print, print_object): Likewise.
981 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
983 Use pI instead of if-then-else-abort. Use %p to avoid casts,
984 avoiding the 0 flag, which is not portable.
985 * process.c (Fmake_network_process): Use pI to avoid cast.
986 * region-cache.c (pp_cache): Likewise.
987 * xdisp.c (decode_mode_spec): Likewise.
988 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
989 behavior on 64-bit hosts with printf arg.
990 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
991 (x_stop_queuing_selection_requests): Likewise.
992 (x_get_window_property): Don't truncate byte count to an 'int'
995 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
996 here, since it parses constructs like leading '-' and spaces,
997 which are not wanted; and it overflows with large numbers.
998 Instead, simply match F[0-9]+, which is what is wanted anyway.
1000 * alloc.c: Remove unportable assumptions about struct layout.
1001 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1002 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1003 (allocate_vectorlike, make_pure_vector): Use the new macros,
1004 plus offsetof, to remove unportable assumptions about struct layout.
1005 These assumptions hold on all porting targets that I know of, but
1006 they are not guaranteed, they're easy to remove, and removing them
1007 makes further changes easier.
1009 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1010 This doesn't fix a bug but makes the code clearer.
1011 (string_overrun_cookie): Now const. Use initializers that
1012 don't formally overflow signed char, to avoid warnings.
1013 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1014 can cause Emacs to crash when string overrun checking is enabled.
1015 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1016 multiple of sizeof (EMACS_INT); it need not be, if
1017 alignof(EMACS_INT) < sizeof (EMACS_INT).
1018 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1020 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1022 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1024 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1026 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1027 supposed to be handshaking. (Bug#8556)
1028 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1030 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1032 * lisp.h (Qdebug): List symbol.
1033 * eval.c (Qdebug): Restore global linkage.
1034 * keyboard.c (debug-on-event): New variable.
1035 (handle_user_signal): Break into debugger when debug-on-event
1036 matches the current signal symbol.
1038 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1040 * alloc.c (check_sblock, check_string_bytes)
1041 (check_string_free_list): Convert to standard C.
1043 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1045 * w32.c (emacs_gnutls_push): Fix typo.
1047 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1049 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1050 "cast to pointer from integer of different size".
1052 Improve doprnt and its use in verror. (Bug#8545)
1053 * doprnt.c (doprnt): Document the set of format control sequences
1054 supported by the function. Use SAFE_ALLOCA instead of always
1057 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1058 is one byte too soon. Don't use xrealloc; instead xfree and
1061 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1063 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1066 * gnutls.c: Renamed global_initialized to
1067 gnutls_global_initialized. Added internals for the
1068 :verify-hostname-error, :verify-error, and :verify-flags
1069 parameters of `gnutls-boot' and documented those parameters in the
1070 docstring. Start callback support.
1071 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1072 unless a fatal error occured. Call gnutls_alert_send_appropriate
1073 on error. Return error code.
1074 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1075 (emacs_gnutls_read): Likewise.
1076 (Fgnutls_boot): Return handshake error code.
1077 (emacs_gnutls_handle_error): New function.
1078 (wsaerror_to_errno): Likewise.
1080 * w32.h (emacs_gnutls_pull): Add prototype.
1081 (emacs_gnutls_push): Likewise.
1083 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1084 (emacs_gnutls_push): Likewise.
1086 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1088 * process.c (wait_reading_process_output): Check if GnuTLS
1089 buffered some data internally if no FDs are set for TLS
1092 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1093 (LIBS): Link to USER_LIBS.
1094 ($(BLD)/gnutls.$(0)): New target.
1096 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1098 * xdisp.c (handle_single_display_spec): Rename the
1099 display_replaced_before_p argument into display_replaced_p, to
1100 make it consistent with the commentary. Fix typos in the
1103 * textprop.c (syms_of_textprop): Remove dead code.
1104 (copy_text_properties): Delete obsolete commentary about an
1105 interface that was deleted long ago. Fix typos in the description
1108 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1109 to changes in oldXMenu/XMenu.h from 2011-04-16.
1110 <menu_help_message, prev_menu_help_message>: Constify.
1111 (IT_menu_make_room): menu->help_text is now `const char **';
1114 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1115 to changes in oldXMenu/XMenu.h from 2011-04-16.
1116 (struct XMenu): Declare `help_text' `const char **'.
1118 * xfaces.c <Qunspecified>: Make extern again.
1120 * syntax.c: Include sys/types.h before including regex.h, as
1123 * doc.c (get_doc_string): Improve the format passed to `error'.
1125 * doprnt.c (doprnt): Improve commentary.
1127 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1129 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1132 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1133 changes in globals.h immediately force recompilation.
1134 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1135 $(CURDIR)/s/ms-w32.h.
1136 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1138 * character.c (Fchar_direction): Function deleted.
1139 (syms_of_character): Don't defsubr it.
1140 <char-direction-table>: Deleted.
1142 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1144 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1145 * doprnt.c: Include limits.h.
1146 (SIZE_MAX): New macro.
1147 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
1148 local variables are now size_t instead of int or unsigned.
1149 Improve overflow protection. Support `l' modifier for integer
1150 conversions. Support %l conversion. Don't assume an EMACS_INT
1151 argument for integer conversions and for %c.
1153 * lisp.h (doprnt): Restore prototype.
1155 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1158 * Makefile.in (base_obj): Add back doprnt.o.
1160 * deps.mk (doprnt.o): Add back prerequisites.
1161 (callint.o): Depend on character.h.
1163 * eval.c (internal_lisp_condition_case): Include the handler
1164 representation in the error message.
1165 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1166 when breaking from the loop.
1168 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1170 * callint.c (Fcall_interactively): When displaying error message
1171 about invalid control letter, pass the character's codepoint, not
1172 a pointer to its multibyte form. Improve display of the character
1173 in octal and display also its hex code.
1175 * character.c (char_string): Use %x to display the (unsigned)
1176 codepoint of an invalid character, to avoid displaying a bogus
1179 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1180 `error', not SYMBOL_NAME itself.
1182 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1183 character arguments to `error'.
1185 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1186 to `error' in error message about FINAL_CHAR argument. Make sure
1187 FINAL_CHAR is a character, and use %c when it is passed as
1188 argument to `error'.
1190 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1192 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1194 * w32.c: Include <time.h>.
1195 (sys_localtime): New function.
1197 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1199 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1201 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1203 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1205 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1208 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1210 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1211 gl_state.e_property when gl_state.object is Qt.
1213 * insdel.c (make_gap_larger): Remove limitation of buffer size
1216 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1218 * xdisp.c (lookup_glyphless_char_display)
1219 (produce_glyphless_glyph): Handle cons cell entry in
1220 glyphless-char-display.
1221 (Vglyphless_char_display): Document it.
1223 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1224 glyphless-char-display.
1226 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1228 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1230 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1232 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1233 definition for no-X builds.
1235 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1237 Static checks with GCC 4.6.0 and non-default toolkits.
1239 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1241 * process.c (keyboard_bit_set): Define only if SIGIO.
1242 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1243 (send_process): Repair possible setjmp clobbering.
1245 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1247 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1249 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1251 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1252 Define only if needed.
1254 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1255 by pacifying GCC about it. Maybe it's time to retire it?
1256 * xfaces.c (USG, __TIMEVAL__): Likewise.
1258 * dispextern.h (struct redisplay_interface): Rename param
1260 * termhooks.h (struct terminal): Likewise.
1261 * xterm.c (xembed_send_message): Likewise.
1263 * insdel.c (make_gap_smaller): Define only if
1264 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1266 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1269 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1270 so that we aren't warned about unused symbols.
1272 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1274 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1276 * xfns.c (x_real_positions): Mark locals as initialized.
1278 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1280 * xterm.c: Fix problems found by static analysis with other toolkits.
1281 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1282 (x_dispatch_event): Declare static if USE_GTK, and
1283 define if USE_GTK || USE_X_TOOLKIT.
1284 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1285 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1286 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1287 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1289 * xmenu.c (menu_help_callback): Pointer type fixes.
1290 Use const pointers when pointing at readonly data. Avoid pointer
1292 (FALSE): Remove unused macro.
1293 (update_frame_menubar): Remove unused decl.
1295 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1297 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1298 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1299 (single_menu_item): Rename local to avoid shadowing.
1301 * keyboard.c (make_lispy_event): Remove unused local var.
1303 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1304 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1306 * bitmaps: Change bitmaps from unsigned char back to the X11
1307 compatible char. Avoid the old compiler warnings about
1308 out-of-range initializers by using, for example, '\xab' rather
1311 * xgselect.c (xgselect_initialize): Check vs interface
1312 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1314 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1316 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1317 to read-only memory.
1319 * fns.c (vector): Remove; this old hack is no longer needed.
1321 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1323 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1325 * xrdb.c (x_load_resources): Omit unused local.
1327 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1328 (x_window): Rename locals to avoid shadowing.
1329 (USG): Use the kludged USG macro, to pacify gcc.
1331 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1332 (x_term_init): Remove local to avoid shadowing.
1334 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1336 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1337 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1339 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1341 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1343 Fix regex.c, syntax.c and friends for buffers > 2GB.
1344 * syntax.h (struct gl_state_s): Declare character position members
1347 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1349 * textprop.c (verify_interval_modification, interval_of): Declare
1350 arguments EMACS_INT.
1352 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1355 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1357 * indent.c (Fvertical_motion): Local variable it_start is now
1360 * regex.c (re_match, re_match_2, re_match_2_internal)
1361 (bcmp_translate, regcomp, regexec, print_double_string)
1362 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1363 (re_compile_pattern, re_exec): Declare arguments and local
1364 variables `size_t' and `ssize_t' and return values `regoff_t', as
1366 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1367 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1368 <compile_stack_type>: `size' and `avail' are now `size_t'.
1370 * regex.h <regoff_t>: Use ssize_t, not int.
1371 (re_search, re_search_2, re_match, re_match_2): Arguments that
1372 specify buffer/string position and length are now ssize_t and
1373 size_t. Return type is regoff_t.
1375 2011-04-16 Ben Key <bkey76@gmail.com>
1377 * nsfont.m: Fixed bugs in ns_get_family and
1378 ns_descriptor_to_entity that were caused by using free to
1379 deallocate memory blocks that were allocated by xmalloc (via
1380 xstrdup). This caused Emacs to crash when compiled with
1381 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1382 --enable-checking=xmallocoverrun). xfree is now used to
1383 deallocate these memory blocks.
1385 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1387 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1389 emacs_write: Accept and return EMACS_INT for sizes.
1390 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1392 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1393 Accept and return EMACS_INT.
1394 (emacs_gnutls_write): Return the number of bytes written on
1396 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1397 (emacs_read, emacs_write): Remove check for negative size, as the
1398 Emacs source code has been audited now.
1399 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1400 (emacs_read, emacs_write): Use it.
1401 * process.c (send_process): Adjust to the new signatures of
1402 emacs_write and emacs_gnutls_write. Do not attempt to store
1403 a byte offset into an 'int'; it might overflow.
1404 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1406 * sound.c: Don't assume sizes fit in 'int'.
1407 (struct sound_device.period_size, alsa_period_size):
1408 Return EMACS_INT, not int.
1409 (struct sound_device.write, vox_write, alsa_write):
1410 Accept EMACS_INT, not int.
1411 (wav_play, au_play): Use EMACS_INT to store sizes and to
1412 record read return values.
1414 2011-04-15 Ben Key <bkey76@gmail.com>
1416 * keyboard.c (Qundefined): Don't declare static since it is used
1418 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1419 static since they are used in nsfont.m.
1421 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1423 * process.c (Qprocessp): Don't declare static.
1424 * lisp.h (Qprocessp): Declare again.
1426 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1428 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1430 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1432 Improve C-level modularity by making more things 'static'.
1434 Don't publish debugger-only interfaces to other modules.
1435 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1436 (verify_bytepos, count_markers): Move decls to the only modules
1438 * region-cache.h (pp_cache): Likewise.
1439 * window.h (check_all_windows): Likewise.
1440 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1442 * sysdep.c (croak): Now static, if
1443 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1444 * syssignal.h (croak): Declare only if not static.
1446 * alloc.c (refill_memory_reserve): Now static if
1447 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1448 * lisp.h (refill_memory_reserve): Declare only if not static.
1450 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1451 Define only if USE_LUCID.
1453 * xrdb.c (x_customization_string, x_rm_string): Now static.
1455 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1456 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1458 * xdisp.c (draw_row_with_mouse_face): Now static.
1459 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1461 * window.h (check_all_windows): Mark externally visible.
1463 * window.c (window_deletion_count): Now static.
1465 * undo.c: Make symbols static if they're not exported.
1466 (last_undo_buffer, last_boundary_position, pending_boundary):
1469 * textprop.c (interval_insert_behind_hooks): Now static.
1470 (interval_insert_in_front_hooks): Likewise.
1472 * term.c: Make symbols static if they're not exported.
1473 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1474 (max_frame_lines, tty_set_terminal_modes):
1475 (tty_reset_terminal_modes, tty_turn_off_highlight):
1476 (get_tty_terminal): Now static.
1477 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1478 * termhooks.h (term_mouse_moveto): Do not declare if
1480 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1481 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1483 * sysdep.c: Make symbols static if they're not exported.
1484 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1486 (sigprocmask_set, full_mask): Remove; unused.
1487 (wait_debugging): Mark as visible.
1488 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1489 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1491 * syntax.c (syntax_temp): Define only if !__GNUC__.
1493 * sound.c (current_sound_device, current_sound): Now static.
1495 * search.c (searchbufs, searchbuf_head): Now static.
1497 * scroll.c (scroll_cost): Remove; unused.
1498 * dispextern.h (scroll_cost): Remove decl.
1500 * region-cache.h (pp_cache): Mark as externally visible.
1502 * process.c: Make symbols static if they're not exported.
1503 (process_tick, update_tick, create_process, chan_process):
1504 (Vprocess_alist, proc_buffered_char, datagram_access):
1505 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1506 (deactivate_process): Mark defn as static, as well as decl.
1507 * lisp.h (create_process): Remove decl.
1508 * process.h (chan_process, Vprocess_alist): Remove decls.
1510 * print.c: Make symbols static if they're not exported.
1511 (print_depth, new_backquote_output, being_printed, print_buffer):
1512 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1513 (print_interval, print_number_index, initial_stderr_stream):
1515 * lisp.h (Fprinc): Remove decl.
1516 (debug_output_compilation_hack): Mark as externally visible.
1518 * sysdep.c (croak): Move decl from here to syssignal.h.
1519 * syssignal.h (croak): Put it here, so the API can be checked when
1520 'croak' is called from dissociate_if_controlling_tty.
1522 * minibuf.c: Make symbols static if they're not exported.
1523 (minibuf_save_list, choose_minibuf_frame): Now static.
1524 * lisp.h (choose_minibuf_frame): Remove decl.
1526 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1528 * lread.c: Make symbols static if they're not exported.
1529 (read_objects, initial_obarray, oblookup_last_bucket_number):
1531 (make_symbol): Remove; unused.
1532 * lisp.h (initial_obarray, make_symbol): Remove decls.
1534 * keyboard.c: Make symbols static if they're not exported.
1535 (single_kboard, recent_keys_index, total_keys, recent_keys):
1536 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1537 (this_single_command_key_start, echoing, last_auto_save):
1538 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1539 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1540 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1541 (Vlispy_mouse_stem, double_click_count):
1543 (force_auto_save_soon): Define only if SIGDANGER.
1544 (ignore_mouse_drag_p): Now static if
1545 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1546 (print_help): Remove; unused.
1547 (stop_character, last_timer_event): Mark as externally visible.
1548 * keyboard.h (ignore_mouse_drag_p): Declare only if
1549 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1550 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1551 * lisp.h (echoing): Remove decl.
1552 (force_auto_save_soon): Declare only if SIGDANGER.
1553 * xdisp.c (redisplay_window): Simplify code, to make it more
1554 obvious that ignore_mouse_drag_p is not accessed if !defined
1555 USE_GTK && !defined HAVE_NS.
1557 * intervals.c: Make symbols static if they're not exported.
1558 (merge_properties_sticky, merge_interval_right, delete_interval):
1560 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1562 * insdel.c: Make symbols static if they're not exported.
1563 However, leave prepare_to_modify_buffer alone. It's never
1564 called from outside this function, but that appears to be a bug.
1565 (combine_after_change_list, combine_after_change_buffer):
1566 (adjust_after_replace, signal_before_change): Now static.
1567 (adjust_after_replace_noundo): Remove; unused.
1568 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1569 (signal_before_change): Remove decls.
1571 * indent.c (val_compute_motion, val_vmotion): Now static.
1573 * image.c: Make symbols static if they're not exported.
1574 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1576 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1577 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1579 * fringe.c (standard_bitmaps): Now static.
1580 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1582 * frame.c: Make symbols static if they're not exported.
1583 (x_report_frame_params, make_terminal_frame): Now static.
1584 (get_frame_param): Now static, unless HAVE_NS.
1585 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1586 (x_get_resource_string): Remove; not used.
1587 * frame.h (make_terminal_frame, x_report_frame_params):
1588 (x_get_resource_string); Remove decls.
1589 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1590 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1592 * font.c, fontset.c: Make symbols static if they're not exported.
1593 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1594 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1595 * font.c (font_close_object): Now static.
1596 * font.h (font_close_object): Remove.
1597 * fontset.c (FONTSET_OBJLIST): Remove.
1598 (free_realized_fontset) #if-0 the body, which does nothing.
1599 (face_suitable_for_char_p): #if-0, as it's never called.
1600 * fontset.h (face_suitable_for_char_p): Remove decl.
1601 * xfaces.c (face_at_string_position): Use
1602 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1603 since 0 is always ASCII.
1605 * fns.c (weak_hash_tables): Now static.
1607 * fileio.c: Make symbols static if they're not exported.
1608 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1609 (Vwrite_region_annotation_buffers): Now static.
1611 * eval.c: Make symbols static if they're not exported.
1612 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1613 * lisp.h (backtrace_list): Remove decl.
1615 * emacs.c: Make symbols static if they're not exported.
1616 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1617 (fatal_error_code, fatal_error_signal_hook, standard_args):
1619 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1620 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1621 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1622 * lisp.h (fatal_error_signal_hook): Remove decl.
1623 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1625 * editfns.c: Move a (normally-unused) function to its only use.
1626 * editfns.c, lisp.h (get_operating_system_release): Remove.
1627 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1628 worth the hassle of breaking this out.
1630 * xterm.c: Make symbols static if they're not exported.
1631 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1632 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1633 (x_destroy_window, x_delete_display):
1635 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1636 (x_mouse_leave): Remove; unused.
1637 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1638 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1639 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1641 (x_mouse_leave): Declare only if WINDOWSNT.
1642 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1643 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1646 * ftxfont.c: Make symbols static if they're not exported.
1647 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1649 * font.h (ftxfont_driver): Likewise.
1651 * xfns.c: Make symbols static if they're not exported.
1652 (x_last_font_name, x_display_info_for_name):
1653 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1654 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1655 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1656 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1657 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1658 (last_show_tip_args): Now static.
1659 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1660 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1661 (x_screen_planes): Remove; unused.
1662 * dispextern.h (x_screen_planes): Remove decl.
1664 * dispnew.c: Make symbols static if they're not exported.
1665 * dispextern.h (redraw_garbaged_frames, scrolling):
1666 (increment_row_positions): Remove.
1667 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1668 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1670 (redraw_garbaged_frames): Remove; unused.
1672 * xfaces.c: Make symbols static if they're not exported.
1673 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1675 * xterm.h (defined_color): Remove decls.
1676 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1677 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1678 (menu_face_changed_default, defined_color, free_realized_face):
1679 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1680 (ascii_face_of_lisp_face): Remove; unused.
1682 * xdisp.c: Make symbols static if they're not exported.
1683 * dispextern.h (scratch_glyph_row, window_box_edges):
1684 (glyph_to_pixel_coords, set_cursor_from_row):
1685 (get_next_display_element, set_iterator_to_next):
1686 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1687 (show_mouse_face): Remove decls
1688 * frame.h (message_buf_print): Likewise.
1689 * lisp.h (pop_message, set_message, check_point_in_composition):
1691 * xterm.h (set_vertical_scroll_bar): Likewise.
1692 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1693 (message_buf_print, scratch_glyph_row, displayed_buffer):
1694 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1695 (get_next_display_element, show_mouse_face, window_box_edges):
1696 (frame_to_window_pixel_xy, check_point_in_composition):
1697 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1698 (glyph_to_pixel_coords): Remove; unused.
1700 * dired.c (file_name_completion): Now static.
1702 * dbusbind.c (xd_in_read_queued_messages): Now static.
1704 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1705 * data.c (circular_list_error): Remove.
1707 * commands.h (last_point_position, last_point_position_buffer):
1708 (last_point_position_window): Remove decls.
1709 * keyboard.c: Make these variables static.
1711 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1713 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1714 (iso_code_class, detect_coding, code_convert_region): Now static.
1715 (encode_coding_gap): Remove; unused.
1717 * chartab.c (chartab_chars, chartab_bits): Now static.
1719 * charset.h (charset_iso_8859_1): Remove decl.
1720 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1723 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1724 * ccl.c (Vccl_program_table): Now static.
1725 (check_ccl_update): Remove; unused.
1727 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1728 * category.h: ... from here.
1729 * category.c (check_category_table, set_category_set): Now static.
1731 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1732 * lisp.h: Remove these decls.
1734 * buffer.c (buffer_count): Remove unused var.
1736 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1737 so that it's not optimized away.
1738 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1739 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1740 exported only to the debugger.
1742 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1743 * atimer.h (run_all_atimers): Removed; not exported.
1745 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1746 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1747 was inaccessible from Lisp.
1748 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1749 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1751 alloc.c: Import and export fewer symbols, and remove unused items.
1752 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1754 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1755 it's not optimized away by whole-program optimization.
1756 (message_enable_multibyte, free_misc): Remove.
1757 (catchlist, handlerlist, mark_backtrace):
1758 Declare only if BYTE_MARK_STACK.
1759 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1760 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1761 (message_enable_multibyte): Remove decl.
1762 (free_misc, interval_free_list, float_block, float_block_index):
1763 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1764 (cons_free_list, last_marked_index):
1766 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1767 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1768 (mark_backtrace): Define only if BYTE_MARK_STACK.
1769 * xdisp.c (message_enable_multibyte): Now static.
1771 Declare Lisp_Object Q* variables to be 'static' if not exported.
1772 This makes it easier for human readers (and static analyzers)
1773 to see whether these variables are used from other modules.
1774 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1775 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1776 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1777 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1778 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1779 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1780 * xmenu.c, xselect.c:
1781 Declare Q* vars static if they are not used in other modules.
1782 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1783 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1784 Remove decls of unexported vars.
1785 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1787 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1789 Make Emacs functions such as Fatom 'static' by default.
1790 This makes it easier for human readers (and static analyzers)
1791 to see whether these functions can be called from other modules.
1792 DEFUN now defines a static function. To make the function external
1793 so that it can be used in other C modules, use the new macro DEFUE.
1794 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1795 (Finit_image_library):
1796 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1797 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1798 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1799 Remove decls, since these functions are now static.
1800 (Funintern, Fget_internal_run_time): New decls, since these functions
1801 were already external.
1803 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1804 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1805 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1806 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1807 * keyboard.c, keymap.c, lread.c:
1808 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1809 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1810 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1811 Mark functions with DEFUE instead of DEFUN,
1812 if they are used in other modules.
1813 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1814 decls for now-static functions.
1815 * buffer.h (Fdelete_overlay): Remove decl.
1816 * callproc.c (Fgetenv_internal): Mark as internal.
1817 * composite.c (Fremove_list_of_text_properties): Remove decl.
1818 (Fcomposition_get_gstring): New forward static decl.
1819 * composite.h (Fcomposite_get_gstring): Remove decl.
1820 * dired.c (Ffile_attributes): New forward static decl.
1821 * doc.c (Fdocumntation_property): New forward static decl.
1822 * eval.c (Ffetch_bytecode): New forward static decl.
1823 (Funintern): Remove extern decl; now in .h file where it belongs.
1824 * fileio.c (Fmake_symbolic_link): New forward static decl.
1825 * image.c (Finit_image_library): New forward static decl.
1826 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1827 * intervals.h (Fprevious_property_change):
1828 (Fremove_list_of_text_properties): Remove decls.
1829 * keyboard.c (Fthis_command_keys): Remove decl.
1830 (Fcommand_execute): New forward static decl.
1831 * keymap.c (Flookup_key): New forward static decl.
1832 (Fcopy_keymap): Now static.
1833 * keymap.h (Flookup_key): Remove decl.
1834 * process.c (Fget_process): New forward static decl.
1835 (Fprocess_datagram_address): Mark as internal.
1836 * syntax.c (Fsyntax_table_p): New forward static decl.
1837 (skip_chars): Remove duplicate decl.
1838 * textprop.c (Fprevious_property_change): New forward static decl.
1839 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1841 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1842 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1844 * editfns.c (Fformat): Remove unreachable code.
1846 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1848 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1851 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1853 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1854 when at ZV. (Bug#8487)
1856 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1858 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1860 * keyboard.c (parse_tool_bar_item): Likewise.
1861 * sound.c (sound_cleanup, alsa_close): Likewise.
1862 * termcap.c (tgetent): Likewise.
1863 * xfns.c (x_default_font_parameter): Likewise.
1864 * xsettings.c (read_and_apply_settings): Likewise.
1866 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1867 (overrun_check_free): Protoize.
1869 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1871 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1872 since callers should never pass a negative size.
1873 Change the signature to match that of plain 'read' and 'write'; see
1874 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1875 * lisp.h: Update prototypes of emacs_write and emacs_read.
1877 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1879 * xdisp.c (redisplay_window): Don't try to determine the character
1880 position of the scroll margin if the window start point w->startp
1881 is outside the buffer's accessible region. (Bug#8468)
1883 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1885 Fix write-region and its subroutines for buffers > 2GB.
1886 * fileio.c (a_write, e_write): Modify declaration of arguments and
1887 local variables to support buffers larger than 2GB.
1888 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1890 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1891 argument, local variables, and return value.
1893 * lisp.h: Update prototypes of emacs_write and emacs_read.
1895 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1897 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1899 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1901 Fix more problems found by GCC 4.6.0's static checks.
1903 * xdisp.c (vmessage): Use a better test for character truncation.
1905 * charset.c (load_charset_map): <, not <=, for optimization,
1906 and to avoid potential problems with integer overflow.
1907 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1908 * casetab.c (set_identity, shuffle): Likewise.
1909 * editfns.c (Fformat): Likewise.
1910 * syntax.c (skip_chars): Likewise.
1912 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1913 This also lets GCC 4.6.0 generate slightly better loop code.
1915 * callint.c (Fcall_interactively): <, not <=, for optimization.
1916 (Fcall_interactively): Count the number of arguments produced,
1917 not the number of arguments given. This is simpler and lets GCC
1918 4.6.0 generate slightly better code.
1920 * ftfont.c: Distingish more carefully between FcChar8 and char.
1921 The previous code passed unsigned char * to a functions like
1922 strlen and xstrcasecmp that expect char *, which does not
1923 conform to the C standard.
1924 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1925 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1926 char * when the C standard requires it.
1928 * keyboard.c (read_char): Remove unused var.
1930 * eval.c: Port to Windows vsnprintf (Bug#8435).
1932 (SIZE_MAX): Define if the headers do not.
1933 (verror): Do not give up if vsnprintf returns a negative count.
1934 Instead, grow the buffer. This ports to Windows vsnprintf, which
1935 does not conform to C99. Problem reported by Eli Zaretskii.
1936 Also, simplify the allocation scheme, by avoiding the need for
1937 calling realloc, and removing the ALLOCATED variable.
1939 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1941 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1942 But keep the doprint source code for now, as we might revamp it
1943 and use it again (Bug#8435).
1944 * lisp.h (doprnt): Remove.
1945 * Makefile.in (base_obj): Remove doprnt.o.
1946 * deps.mk (doprnt.o): Remove.
1948 error: Print 32- and 64-bit integers portably (Bug#8435).
1949 Without this change, on typical 64-bit hosts error ("...%d...", N)
1950 was used to print both 32- and 64-bit integers N, which relied on
1952 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1954 * lisp.h (error, verror): Mark as printf-like functions.
1955 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1956 Report overflow in size calculations when allocating printf buffer.
1957 Do not truncate output string at its first null byte.
1958 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1959 Truncate the output at a character boundary, since vsnprintf does not
1961 * charset.c (check_iso_charset_parameter): Convert internal
1962 character to string before calling 'error', since %c now has the
1964 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1965 overflow when computing char to be passed to 'error'. Do not
1966 pass Lisp_Object to 'error'; pass the integer instead.
1967 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1968 formatted with plain %d.
1970 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1972 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1974 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1976 * xterm.c (x_catch_errors): Remove duplicate declaration.
1978 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1980 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1982 2011-04-10 Jim Meyering <meyering@redhat.com>
1984 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1985 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1986 return ssize_t not "int", and use size_t as the buffer length.
1987 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1988 * gnutls.h: Update declarations.
1989 * process.c (read_process_output): Use ssize_t, to match.
1990 (send_process): Likewise.
1992 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1994 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1996 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1998 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1999 unsigned char, to match FcChar8 type definition.
2001 * xterm.c (handle_one_xevent):
2002 * xmenu.c (create_and_show_popup_menu):
2003 * xselect.c (x_decline_selection_request)
2004 (x_reply_selection_request): Avoid type-punned deref of X events.
2006 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2008 Fix some uses of `int' instead of EMACS_INT.
2009 * search.c (string_match_1, fast_string_match)
2010 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2011 (scan_buffer, find_next_newline_no_quit)
2012 (find_before_next_newline, search_command, Freplace_match)
2013 (Fmatch_data): Make some `int' variables be EMACS_INT.
2015 * xdisp.c (display_count_lines): 3rd argument and return value now
2016 EMACS_INT. All callers changed.
2017 (pint2hrstr): Last argument is now EMACS_INT.
2019 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2020 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2021 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2022 (decode_coding_utf_16, decode_coding_emacs_mule)
2023 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2024 (decode_coding_ccl, decode_coding_charset)
2025 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2026 (decode_coding_iso_2022, decode_coding_emacs_mule)
2027 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2028 <char_offset, last_offset>: Declare EMACS_INT.
2029 (encode_coding_utf_8, encode_coding_utf_16)
2030 (encode_coding_emacs_mule, encode_invocation_designation)
2031 (encode_designation_at_bol, encode_coding_iso_2022)
2032 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2033 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2035 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2036 (encode_invocation_designation): Last argument P_NCHARS is now
2038 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2039 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2041 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2044 * ccl.c (Fccl_execute_on_string): Declare some variables
2047 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2049 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2051 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2053 * process.c (Fformat_network_address): Doc fix.
2055 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2057 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2059 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2061 * keyboard.c (read_char): Call Lisp function help-form-show,
2062 instead of using internal_with_output_to_temp_buffer.
2063 (Qhelp_form_show): New var.
2064 (syms_of_keyboard): Use DEFSYM macro.
2066 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2068 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2070 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2072 * process.c (Flist_processes): Removed to Lisp.
2073 (list_processes_1): Deleted.
2075 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2077 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2079 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2081 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2083 Fix more problems found by GCC 4.6.0's static checks.
2085 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2087 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2089 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2091 * xdisp.c (vmessage): Mark as a printf-like function.
2093 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2095 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2097 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2098 printf-like functions.
2099 (tiff_load): Add casts to remove these marks before passing them
2100 to system-supplied API.
2102 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2104 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2105 This avoids several warnings with gcc -Wstrict-overflow.
2106 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2107 directly, rather than having caller test rule sign. This avoids
2108 some unnecessary tests.
2109 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2110 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2111 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2113 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2114 (xfont_open): Avoid unnecessary tests.
2116 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2118 * composite.h, composite.c (composition_gstring_put_cache):
2119 Use EMACS_INT, not int, for length.
2121 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2122 breaking out part of COMPOSITION_DECODE_RULE.
2123 (COMPOSITION_DECODE_RULE): Use it.
2124 * composite.c (get_composition_id): Remove unused local vars,
2125 by using the new macro.
2127 * textprop.c (set_text_properties_1): Change while to do-while,
2128 since the condition is always true at first.
2130 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2131 (interval_deletion_adjustment): Return unsigned value.
2134 * process.c (list_processes_1, create_pty, read_process_output):
2135 (exec_sentinel): Remove vars that were set but not used.
2136 (create_pty): Remove unnecessary "volatile"s.
2137 (Fnetwork_interface_info): Avoid possibility of int overflow.
2138 (read_process_output): Do adaptive read buffering even if carryover.
2139 (read_process_output): Simplify nbytes computation if buffered.
2141 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2143 * syntax.c (scan_words): Remove var that was set but not used.
2144 (update_syntax_table): Use unsigned instead of int.
2146 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2147 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2148 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2150 * print.c (print_error_message): Avoid int overflow.
2152 * font.c (font_list_entities): Redo for clarity,
2153 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2155 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2156 (font_score): Avoid potential overflow in diff calculation.
2158 * fns.c (substring_both): Remove var that is set but not used.
2159 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2161 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2163 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2164 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2165 can always succeed if overflow has undefined behavior.
2167 * search.c (boyer_moore, wordify): Remove vars set but not used.
2168 (wordify): Omit three unnecessary tests.
2170 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2171 All callers changed. This avoids the need for an unused var.
2173 * casefiddle.c (casify_region): Remove var that is set but not used.
2175 * dired.c (file_name_completion): Remove var that is set but not used.
2177 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2179 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2180 (Finsert_file_contents): Remove unnecessary code checking fd.
2182 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2183 Check for integer overflow on size calculations.
2185 * buffer.c (Fprevious_overlay_change): Remove var that is set
2188 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2189 Remove vars that are set but not used.
2190 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2191 (timer_check_2): Mark vars as initialized.
2193 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2195 * image.c (lookup_image): Remove var that is set but not used.
2196 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2198 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2199 that are set but not used.
2201 * xfns.c (make_invisible_cursor): Don't return garbage
2202 if XCreateBitmapFromData fails (Bug#8410).
2204 * xselect.c (x_get_local_selection, x_handle_property_notify):
2205 Remove vars that are set but not used.
2207 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2208 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2210 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2211 Remove var that is set but not used.
2212 (scroll_bar_windows_size): Now size_t, not int.
2213 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2216 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2217 (map_tty_color) [!defined MSDOS]: Likewise.
2219 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2221 * coding.c: Remove vars that are set but not used.
2222 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2223 All callers changed.
2224 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2225 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2226 (decode_coding_charset): Remove vars that are set but not used.
2228 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2229 that is set but not used.
2231 * print.c (print_object): Remove var that is set but not used.
2233 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2234 The gnulib version avoids calling malloc in the usual case,
2235 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2236 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2237 * filelock.c (current_lock_owner): Likewise.
2238 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2239 * sysdep.c: Include allocator.h, careadlinkat.h.
2240 (emacs_no_realloc_allocator): New static constant.
2241 (emacs_readlink): New function.
2242 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2243 ../lib/careadlinkat.h.
2245 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2247 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2248 first non-nil return value).
2250 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2252 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2253 if not defined (Bug#8403).
2255 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2257 * xdisp.c (display_count_lines): Remove parameter `start',
2258 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2259 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2260 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2261 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2262 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2263 and thereabouts. All callers changed.
2264 (get_per_char_metric): Remove parameter `f', unused since
2265 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2267 2011-04-02 Jim Meyering <meyering@redhat.com>
2269 do not dereference NULL upon failed strdup
2270 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2271 (ns_get_family): Likewise.
2273 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2275 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2277 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2279 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2282 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2284 Add lexical binding.
2286 * window.c (Ftemp_output_buffer_show): New fun.
2287 (Fsave_window_excursion):
2288 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2290 * lread.c (lisp_file_lexically_bound_p): New function.
2291 (Fload): Bind Qlexical_binding.
2292 (readevalloop): Remove `evalfun' arg.
2293 Bind Qinternal_interpreter_environment.
2294 (Feval_buffer): Bind Qlexical_binding.
2295 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2297 (syms_of_lread): Declare `lexical-binding'.
2299 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2301 * keyboard.c (eval_dyn): New fun.
2302 (menu_item_eval_property): Use it.
2304 * image.c (parse_image_spec): Use Ffunctionp.
2306 * fns.c (concat, mapcar1): Accept byte-code-functions.
2308 * eval.c (Fsetq): Handle lexical vars.
2309 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2310 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2311 (FletX, Flet): Obey lexical binding.
2312 (Fcommandp): Handle closures.
2313 (Feval): New `lexical' arg.
2314 (eval_sub): New function extracted from Feval. Use it almost
2315 everywhere where Feval was used. Look up vars in lexical env.
2317 (Ffunctionp): Move from subr.el.
2318 (Ffuncall): Handle closures.
2319 (apply_lambda): Remove `eval_flags'.
2320 (funcall_lambda): Handle closures and new byte-code-functions.
2321 (Fspecial_variable_p): New function.
2322 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2323 but without exporting it to Lisp.
2325 * doc.c (Fdocumentation, store_function_docstring):
2326 * data.c (Finteractive_form): Handle closures.
2328 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2331 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
2333 (exec_byte_code): New function extracted from Fbyte_code to handle new
2334 calling convention for byte-code-functions. Add new byte-codes.
2336 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2338 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2340 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2342 * xdisp.c (redisplay_internal): Fix prototype.
2344 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2346 * xdisp.c (SCROLL_LIMIT): New macro.
2347 (try_scrolling): Use it when setting scroll_limit. Limit
2348 scrolling to 100 screen lines.
2349 (redisplay_window): Even when falling back on "recentering",
2350 position point in the window according to scroll-conservatively,
2351 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2353 (try_scrolling): When point is above the window, allow searching
2354 as far as scroll_max, or one screenful, to compute vertical
2355 distance from PT to the scroll margin position. This prevents
2356 try_scrolling from unnecessarily failing when
2357 scroll-conservatively is set to a value slightly larger than the
2358 window height. Clean up the case of PT below the margin at bottom
2359 of window: scroll_max can no longer be INT_MAX. When aggressive
2360 scrolling is in use, don't let point enter the opposite scroll
2361 margin as result of the scroll.
2362 (syms_of_xdisp) <scroll-conservatively>: Document the
2363 threshold of 100 lines for never-recentering scrolling.
2365 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2367 * dispextern.h (move_it_by_lines):
2368 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2369 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2370 (message_log_check_duplicate): Remove parameters `prev_bol' and
2371 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2372 (redisplay_internal): Remove parameter `preserve_echo_area',
2373 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2375 * indent.c (Fvertical_motion):
2376 * window.c (window_scroll_pixel_based, Frecenter):
2377 Don't pass `need_y_p' to `move_it_by_lines'.
2379 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2381 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2382 steal a few bits to be more compact.
2383 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2384 Remove unneeded casts.
2386 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2388 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2390 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2391 binding" message (bug#7967).
2393 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2395 Fix more problems found by GCC 4.6.0's static checks.
2397 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2398 Remove unused local var.
2400 * editfns.c (Fmessage_box): Remove unused local var.
2402 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2403 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2404 Omit unused local vars.
2405 * window.c (shrink_windows): Omit unused local var.
2406 * menu.c (digest_single_submenu): Omit unused local var.
2407 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2408 Omit unused local var.
2410 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2411 Don't assume string length fits in int.
2412 (keyremap_step, read_key_sequence): Use size_t for sizes.
2413 (read_key_sequence): Don't check last_real_key_start redundantly.
2415 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2416 instead of alloca (Bug#8344).
2418 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2419 (Fbacktrace_frame): Don't assume nframes fits in int.
2421 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2423 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2426 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2428 * cm.c (calccost): Turn while-do into do-while, for clarity.
2430 * keyboard.c (syms_of_keyboard): Use the same style as later
2431 in this function when indexing through an array. This also
2432 works around GCC bug 48267.
2434 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2436 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2438 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2439 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2441 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2442 This avoids undefined behavior on integer overflow, and is a bit
2443 more convenient anyway since it is compared to a size_t variable.
2445 Variadic C functions now count arguments with size_t, not int.
2446 This avoids an unnecessary limitation on 64-bit machines, which
2447 caused (substring ...) to crash on large vectors (Bug#8344).
2448 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2449 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2450 All variadic functions and their callers changed accordingly.
2451 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2452 * data.c (arith_driver, float_arith_driver): Likewise.
2453 * editfns.c (general_insert_function): Likewise.
2454 * eval.c (struct backtrace.nargs, interactive_p)
2455 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2456 (funcall_lambda, mark_backtrace): Likewise.
2457 * fns.c (concat): Likewise.
2458 * frame.c (x_set_frame_parameters): Likewise.
2459 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2460 0 if not found, not -1. All callers changed.
2462 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2463 (stack_copy_size): Now size_t, not int.
2464 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2466 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2468 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2469 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2470 All callers changed.
2472 * lisp.h (multibyte_char_to_unibyte):
2473 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2474 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2475 * character.h (CHAR_TO_BYTE8):
2476 * cmds.c (internal_self_insert):
2477 * editfns.c (general_insert_function):
2478 * keymap.c (push_key_description):
2479 * search.c (Freplace_match):
2480 * xdisp.c (message_dolog, set_message_1): All callers changed.
2482 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2484 * keyboard.c (safe_run_hook_funcall): New function.
2485 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2486 don't set the hook to nil, but remove the offending function instead.
2487 (Qcommand_hook_internal): Remove, unused.
2488 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2489 Vcommand_hook_internal.
2491 * eval.c (enum run_hooks_condition): Remove.
2492 (funcall_nil, funcall_not): New functions.
2493 (run_hook_with_args): Call each function through a `funcall' argument.
2494 Remove `cond' argument, now redundant.
2495 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2496 (Frun_hook_with_args_until_failure): Adjust accordingly.
2497 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2499 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2501 * dispextern.h (string_buffer_position): Remove declaration.
2503 * print.c (strout): Remove parameter `multibyte', unused since
2504 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2506 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2507 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2508 All callers changed.
2510 * w32.c (_wsa_errlist): Use braces for struct initializers.
2512 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2513 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2514 All callers changed.
2515 (string_buffer_position): Likewise. Also, make static (it's never
2516 used outside xdisp.c).
2517 (cursor_row_p): Remove parameter `w', unused since
2518 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2519 (decode_mode_spec): Remove parameter `precision', introduced during
2520 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2521 All callers changed.
2523 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2525 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2527 2011-03-27 Anders Lindgren <andlind@gmail.com>
2529 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2530 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2531 (ns_update_auto_hide_menu_bar): New functions.
2532 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2533 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2534 ns_constrain_all_frames.
2535 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2536 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2538 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2540 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2542 2011-03-27 Glenn Morris <rgm@gnu.org>
2544 * syssignal.h: Replace RETSIGTYPE with void.
2545 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2546 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2547 Replace SIGTYPE with void everywhere.
2548 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2549 * s/template.h (SIGTYPE): Remove commented out definition.
2551 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2553 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2554 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2556 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2558 * w32.c (read_unc_volume): Use parameter `henum', instead of
2559 global variable `wget_enum_handle'.
2561 * keymap.c (describe_vector): Remove parameters `indices' and
2562 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2563 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2565 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2567 * keyboard.c (timer_check): Remove parameter `do_it_now',
2568 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2569 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2570 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2572 * keyboard.c (read_char):
2573 * w32menu.c (w32_menu_display_help):
2574 * xmenu.c (show_help_event, menu_help_callback):
2575 Adjust calls to `show_help_echo'.
2577 * gtkutil.c (xg_maybe_add_timer):
2578 * keyboard.c (readable_events):
2579 * process.c (wait_reading_process_output):
2580 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2582 * insdel.c (adjust_markers_gap_motion):
2583 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2584 (gap_left, gap_right): Don't call it.
2586 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2588 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2589 incurred during fontification.
2591 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2593 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2594 (DEFVAR_PER_BUFFER): Don't pass it.
2596 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2597 (scrolling_window): Don't pass it.
2599 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2601 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2603 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2605 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2606 of variables specific to SELinux and computation of `encoded_absname'.
2608 * image.c (XPutPixel): Remove unused variable `height'.
2610 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2612 * unexw32.c (get_section_info): Remove unused variable `section'.
2614 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2615 (system_process_attributes): Remove unused variable `sess'.
2616 (sys_read): Remove unused variable `err'.
2618 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2619 (w32_wnd_proc): Remove unused variable `isdead'.
2620 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2621 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2622 (x_create_tip_frame): Remove unused variable `tem'.
2624 * w32inevt.c (w32_console_read_socket):
2625 Remove unused variable `no_events'.
2627 * w32term.c (x_draw_composite_glyph_string_foreground):
2628 Remove unused variable `width'.
2630 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2632 * w32term.c (x_set_glyph_string_clipping):
2633 Don't pass uninitialized region to CombineRgn.
2635 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2637 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2638 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2639 (Fx_close_connection): Remove unused variable `i'.
2641 * w32font.c (w32font_draw): Return number of glyphs.
2642 (w32font_open_internal): Remove unused variable `i'.
2643 (w32font_driver): Add missing initializer.
2645 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2646 (fill_in_menu): Remove unused variable `items_added'.
2648 * w32term.c (last_mouse_press_frame): Remove static global variable.
2649 (w32_clip_to_row): Remove unused variable `f'.
2650 (x_delete_terminal): Remove unused variable `i'.
2652 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2653 (NOTHING): Remove unused static global variable.
2654 (uniscribe_check_otf): Remove unused variable `table'.
2655 (uniscribe_font_driver): Add missing initializers.
2657 2011-03-23 Julien Danjou <julien@danjou.info>
2659 * term.c (Fsuspend_tty, Fresume_tty):
2660 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2661 * window.c (temp_output_buffer_show):
2662 * insdel.c (signal_before_change):
2663 * frame.c (Fhandle_switch_frame):
2664 * fileio.c (Fdo_auto_save):
2665 * emacs.c (Fkill_emacs):
2666 * editfns.c (save_excursion_restore):
2667 * cmds.c (internal_self_insert):
2668 * callint.c (Fcall_interactively):
2669 * buffer.c (Fkill_all_local_variables):
2670 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2672 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2673 unconditionnaly since it does the check itself.
2675 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2677 Fix more problems found by GCC 4.5.2's static checks.
2679 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2680 the first time through the loop, since we know p0 < p1 then.
2681 This also avoids a gcc -Wstrict-overflow warning.
2683 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2684 leading to a memory leak, possible in functions like
2685 load_charset_map_from_file that can allocate an unbounded number
2686 of objects (Bug#8318).
2688 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2689 that could (at least in theory) be that large.
2691 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2692 This is less likely to overflow, and avoids undefined behavior if
2693 overflow does occur. All callers changed. Use strtoul to scan
2694 for the unsigned long integer.
2695 (pint2hrstr): Simplify and tune code slightly.
2696 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2698 * scroll.c (do_scrolling): Work around GCC bug 48228.
2699 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2701 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2702 This also avoids a warning with gcc -Wstrict-overflow.
2703 (validate_x_resource_name): Simplify count usage.
2704 This also avoids a warning with gcc -Wstrict-overflow.
2706 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2709 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2711 * process.c (Fmake_network_process): Use socklen_t, not int,
2712 where POSIX says socklen_t is required in portable programs.
2713 This fixes a porting bug on hosts like 64-bit HP-UX, where
2714 socklen_t is wider than int (Bug#8277).
2715 (Fmake_network_process, server_accept_connection):
2716 (wait_reading_process_output, read_process_output):
2719 * process.c: Rename or move locals to avoid shadowing.
2720 (list_processes_1, Fmake_network_process):
2721 (read_process_output_error_handler, exec_sentinel_error_handler):
2722 Rename or move locals.
2723 (Fmake_network_process): Define label "retry_connect" only if needed.
2724 (Fnetwork_interface_info): Fix pointer signedness.
2725 (process_send_signal): Add cast to avoid pointer signedness problem.
2726 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2727 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2729 Make tparam.h and terminfo.c consistent.
2730 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2731 Include tparam.h instead, since it declares them.
2732 * cm.h (PC): Remove extern decl; tparam.h now does this.
2733 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2734 * terminfo.c: Include tparam.h, to check interfaces.
2735 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2736 (tparam): Adjust signature to match interface in tparam.h;
2737 this removes some undefined behavior. Check that outstring and len
2738 are zero, which they always are with Emacs.
2739 * tparam.h (PC, BC, UP): New extern decls.
2741 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2742 (xftfont_open): Rename locals to avoid shadowing.
2744 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2745 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2746 (OTF_TAG_SYM): Omit macro if not needed.
2747 (ftfont_list): Remove unused local.
2748 (get_adstyle_property, ftfont_pattern_entity):
2749 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2750 Rename locals to avoid shadowing.
2752 * xfont.c (xfont_list_family): Mark var as initialized.
2754 * xml.c (make_dom): Now static.
2756 * composite.c (composition_compute_stop_pos): Rename local to
2758 (composition_reseat_it): Remove unused locals.
2759 (find_automatic_composition, composition_adjust_point): Likewise.
2760 (composition_update_it): Mark var as initialized.
2761 (find_automatic_composition): Mark vars as initialized,
2762 with a FIXME (Bug#8290).
2764 character.h: Rename locals to avoid shadowing.
2765 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2766 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2767 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2768 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2771 * textprop.c (property_change_between_p): Remove; unused.
2773 * intervals.c (interval_start_pos): Now static.
2775 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2777 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2778 Rename locals to avoid shadowing.
2780 * sound.c (wav_play, au_play, Fplay_sound_internal):
2781 Fix pointer signedness.
2782 (alsa_choose_format): Remove unused local var.
2783 (wav_play): Initialize a variable to 0, to prevent undefined
2784 behavior (Bug#8278).
2786 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2788 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2790 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2791 clobbering (Bug#8298).
2792 * sysdep.c (sys_subshell): Likewise.
2793 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2795 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2796 This should get cleaned up, so that child_setup has the
2797 same signature on all platforms.
2799 * callproc.c (call_process_cleanup): Now static.
2800 (relocate_fd): Rename locals to avoid shadowing.
2802 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2804 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2805 not to be necessary, and produces flickering.
2807 2011-03-20 Glenn Morris <rgm@gnu.org>
2809 * config.in: Remove file.
2811 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2813 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2814 are now in src/globals.h.
2815 (syms_of_minibuf): Remove spurious & from previous change.
2817 2011-03-20 Leo <sdl.web@gmail.com>
2819 * minibuf.c (completing-read-function): New variable.
2820 (completing-read-default): Rename from completing-read.
2821 (completing-read): Call completing-read-function.
2823 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2825 * xfaces.c (Fx_load_color_file):
2826 Read color file from absolute filename (bug#8250).
2828 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2830 * makefile.w32-in: Update dependencies.
2832 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2834 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2836 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2838 Fix more problems found by GCC 4.5.2's static checks.
2840 * process.c (make_serial_process_unwind, send_process_trap):
2841 (sigchld_handler): Now static.
2843 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2844 That way, the code declares only the vars that it needs.
2845 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2846 * s/cygwin.h (PTY_ITERATION): Likewise.
2847 * s/darwin.h (PTY_ITERATION): Likewise.
2848 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2850 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2851 * process.c (allocate_pty): Don't declare stb unless it's needed.
2853 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2854 (CONSTANTLIM): Remove; unused.
2855 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2856 Define only if needed.
2858 * unexelf.c (unexec): Name an expression,
2859 to avoid gcc -Wbad-function-cast warning.
2860 Use a different way to cause a compilation error if anyone uses
2861 n rather than nn, a way that does not involve shadowing.
2862 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2864 * deps.mk (unexalpha.o): Remove; unused.
2866 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2867 * unexec.h: New file.
2868 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2869 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2871 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2872 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2873 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2874 Change as necessary to match prototype in unexec.h.
2876 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2878 (back_comment, skip_chars): Mark vars as initialized.
2880 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2881 Rename locals to avoid shadowing.
2883 * lread.c (read1): Rewrite so as not to use empty "else".
2884 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2886 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2888 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2889 warning when compiling print.c.
2891 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2892 instead of using an uninitialized var.
2893 (font_sort_entities): Mark var as initialized.
2895 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2897 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2898 pointers to constants.
2899 (font_parse_fcname): Remove unused vars.
2900 (font_delete_unmatched): Now static.
2901 (font_get_spec): Remove; unused.
2902 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2903 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2904 Rename or move locals to avoid shadowing.
2906 * fns.c (require_nesting_list, require_unwind): Now static.
2907 (Ffillarray): Rename locals to avoid shadowing.
2909 * floatfns.c (domain_error2): Define only if needed.
2910 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2912 * alloc.c (mark_backtrace): Move decl from here ...
2913 * lisp.h: ... to here, so that it can be checked.
2915 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2916 (Fdefvar): Rewrite so as not to use empty "else".
2917 (lisp_indirect_variable): Name an expression,
2918 to avoid gcc -Wbad-function-cast warning.
2919 (Fdefvar): Rename locals to avoid shadowing.
2921 * callint.c (quotify_arg, quotify_args): Now static.
2922 (Fcall_interactively): Rename locals to avoid shadowing.
2923 Use const pointer when appropriate.
2925 * lisp.h (get_system_name, get_operating_system_release):
2926 Move decls here, to check interfaces.
2927 * process.c (get_operating_system_release): Move decl to lisp.h.
2928 * xrdb.c (get_system_name): Likewise.
2929 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2930 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2931 some of which prompt warnings from gcc -Wbad-function-cast.
2932 (Fformat_time_string, Fencode_time, Finsert_char):
2933 (Ftranslate_region_internal, Fformat):
2934 Rename or remove local vars to avoid shadowing.
2935 (Ftranslate_region_internal): Mark var as initialized.
2937 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2940 * lisp.h (eassert): Check that the argument compiles, even if
2941 ENABLE_CHECKING is not defined.
2943 * data.c (Findirect_variable): Name an expression, to avoid
2944 gcc -Wbad-function-cast warning.
2945 (default_value, arithcompare, arith_driver, arith_error): Now static.
2946 (store_symval_forwarding): Rename local to avoid shadowing.
2947 (Fmake_variable_buffer_local, Fmake_local_variable):
2948 Mark variables as initialized.
2949 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2951 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2952 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2953 Rename locals to avoid shadowing.
2954 (mark_stack): Move local variables into the #ifdef region where
2956 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2957 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2959 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2960 (GC_STRING_CHARS): Remove; not used.
2961 (Fmemory_limit): Cast sbrk's returned value to char *.
2963 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2964 avoids undefined behavior in theory.
2966 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2968 Use functions, not macros, for up- and down-casing (Bug#8254).
2969 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2970 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2971 to use the following functions instead of these macros.
2972 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2973 EMACS_INT, since callers assume the returned value fits in int.
2974 (upcase1): Likewise, for UPCASE_TABLE.
2975 (uppercasep, lowercasep, upcase): New static inline functions.
2976 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2977 the race-condition problem in the old DOWNCASE.
2979 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2980 Rename locals to avoid shadowing.
2981 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2982 (regex_compile, re_search_2, re_match_2_internal):
2983 Remove unused local vars.
2984 (FREE_VAR): Rewrite so as not to use empty "else",
2985 which gcc can warn about.
2986 (regex_compile, re_match_2_internal): Mark locals as initialized.
2987 (RETALLOC_IF): Define only if needed.
2988 (WORDCHAR_P): Likewise. This one is never needed, but is used
2989 only in a comment talking about a compiler bug, so put inside
2990 the #if 0 of that comment.
2991 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2992 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2995 * search.c (boyer_moore): Rename locals to avoid shadowing.
2996 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2997 (PREV_CHAR_BOUNDARY): Likewise.
2999 * search.c (simple_search): Remove unused var.
3001 * dired.c (compile_pattern): Move decl from here ...
3002 * lisp.h: ... to here, so that it can be checked.
3003 (struct re_registers): New forward decl.
3005 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3007 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3009 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3010 Rename locals to avoid shadowing.
3011 (Fvertical_motion): Mark locals as initialized.
3013 * casefiddle.c (casify_object, casify_region): Now static.
3014 (casify_region): Mark local as initialized.
3016 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3018 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3019 New macros, so that the caller can use some names other than
3020 gcpro1, gcpro2, etc.
3021 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3023 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3024 argument, for consistency with GCPRO2_VAR, etc: it is now the
3025 prefix of the variable, not the variable itself. All uses
3027 * dired.c (directory_files_internal, file_name_completion):
3028 Rename locals to avoid shadowing.
3030 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3031 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3032 dired.c's scmp function, had undefined behavior.
3033 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3034 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3035 * buffer.h: ... to here, because these macros use current_buffer,
3036 and the new implementation with inline functions needs to have
3037 current_buffer in scope now, rather than later when the macros
3039 (downcase, upcase1): New static inline functions.
3040 (DOWNCASE, UPCASE1): Reimplement using these functions.
3041 This avoids undefined behavior in expressions like
3042 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3043 from race conditions in accessing the global variables
3044 case_temp1 and case_temp2.
3045 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3046 * lisp.h (case_temp1, case_temp2): Remove their decls.
3047 * character.h (ASCII_CHAR_P): Move from here ...
3048 * lisp.h: ... to here, so that the inline functions mentioned
3051 * dired.c (directory_files_internal_unwind): Now static.
3053 * fileio.c (file_name_as_directory, directory_file_name):
3054 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3056 (file_name_as_directory): Use const pointers when appropriate.
3057 (Fexpand_file_name): Likewise. In particular, newdir might
3058 point at constant storage, so make it a const pointer.
3059 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3060 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3062 (Fset_file_times, Finsert_file_contents, auto_save_error):
3063 Rename locals to avoid shadowing.
3065 * minibuf.c (choose_minibuf_frame_1): Now static.
3066 (Ftry_completion, Fall_completions): Rename or remove locals
3069 * marker.c (bytepos_to_charpos): Remove; unused.
3071 * lisp.h (verify_bytepos, count_markers): New decls,
3072 so that gcc does not warn that these functions aren't declared.
3074 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3075 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3076 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3077 (copy_text): Remove unused local var.
3079 * filelock.c (within_one_second): Now static.
3080 (lock_file_1): Rename local to avoid shadowing.
3082 * buffer.c (fix_overlays_before): Mark locals as initialized.
3083 (fix_start_end_in_overlays): Likewise. This function should be
3084 simplified by using pointers-to-pointers, but that's a different
3086 (switch_to_buffer_1): Now static.
3087 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3088 (report_overlay_modification): Rename locals to avoid shadowing.
3090 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3091 Fix pointer signedness issue.
3092 (sys_subshell): Mark local as volatile if checking for lint,
3093 to suppress a gcc -Wclobbered warning that does not seem to be right.
3094 (MAXPATHLEN): Define only if needed.
3096 * process.c (serial_open, serial_configure): Move decls from here ...
3097 * systty.h: ... to here, so that they can be checked.
3099 * fns.c (get_random, seed_random): Move extern decls from here ...
3100 * lisp.h: ... to here, so that they can be checked.
3102 * sysdep.c (reset_io): Now static.
3103 (wait_for_termination_signal): Remove; unused.
3105 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3106 (copy_keymap_item, append_key, push_text_char_description):
3108 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3109 (DENSE_TABLE_SIZE): Remove; unused.
3110 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3111 (describe_map_tree):
3112 Rename locals to avoid shadowing.
3114 * keyboard.c: Declare functions static if they are not used elsewhere.
3115 (echo_char, echo_dash, cmd_error, top_level_2):
3116 (poll_for_input, handle_async_input): Now static.
3117 (read_char, kbd_buffer_get_event, make_lispy_position):
3118 (make_lispy_event, make_lispy_movement, apply_modifiers):
3119 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3120 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3121 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3122 (read_key_sequence, read_char): Mark locals as initialized.
3123 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3125 * keyboard.h (make_ctrl_char): New decl.
3126 (mark_kboards): Move decl here ...
3127 * alloc.c (mark_kboards): ... from here.
3129 * lisp.h (force_auto_save_soon): New decl.
3131 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3132 (DEFINE_DUMMY_FUNCTION): New macro.
3133 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3135 (main): Add casts to avoid warnings
3136 if GCC considers string literals to be constants.
3138 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3140 * dbusbind.c: Pointer signedness fixes.
3141 (xd_signature, xd_append_arg, xd_initialize):
3142 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3143 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3144 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3145 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3147 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3148 if GCC considers string literals to be constants.
3149 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3151 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3153 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3154 (print_preprocess, print_object): New macro to fix last change.
3156 * print.c (print_preprocess): Don't forget font objects.
3158 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3160 * emacs.c (USAGE3): Doc fixes.
3162 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3164 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3167 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3169 * lisp.h (VWindow_system, Qfile_name_history):
3170 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3171 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3172 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3174 * w32select.c: Don't #include "keyboard.h".
3175 (run_protected): Add extern declaration for waiting_for_input.
3177 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3178 * w32console.c (detect_input_pending, read_input_pending)
3179 (encode_terminal_code):
3180 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3181 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3182 (w32_system_caret_y, Qfile_name_history):
3183 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3184 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3185 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3186 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3187 * w32proc.c (Qlocal, report_file_error):
3188 * w32term.c (Vwindow_system, updating_frame):
3189 * w32uniscribe.c (initialized, uniscribe_font_driver):
3190 Remove unneeded extern declarations.
3192 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3194 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3196 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3198 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3199 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3200 These macros can no longer be used for assignment.
3202 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3203 Assign struct members directly, instead of using BUF_BEGV etc.
3204 (record_buffer_markers, fetch_buffer_markers): New functions for
3205 recording and fetching special buffer markers.
3206 (set_buffer_internal_1, set_buffer_temp): Use them.
3208 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3210 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3212 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3213 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3215 * xdisp.c (hscroll_window_tree):
3216 (reconsider_clip_changes): Use PT instead of BUF_PT.
3218 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3220 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3221 $(EMACS_ROOT)/lib/intprops.h.
3223 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3225 Fix more problems found by GCC 4.5.2's static checks.
3227 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3228 to unsigned char * to avoid compiler diagnostic.
3229 (xg_free_frame_widgets): Make it clear that a local variable is
3230 needed only if USE_GTK_TOOLTIP.
3231 (gdk_window_get_screen): Make it clear that this macro is needed
3232 only if USE_GTK_TOOLTIP.
3233 (int_gtk_range_get_value): New function, which avoids a diagnostic
3234 from gcc -Wbad-function-cast.
3235 (xg_set_toolkit_scroll_bar_thumb): Use it.
3236 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3237 diagnostic from gcc -Wbad-function-cast.
3238 (get_utf8_string, xg_get_file_with_chooser):
3239 Rename locals to avoid shadowing.
3240 (create_dialog): Move locals to avoid shadowing.
3242 * xgselect.c (xg_select): Remove unused var.
3244 * image.c (four_corners_best): Mark locals as initialized.
3245 (gif_load): Initialize transparent_p to zero (Bug#8238).
3246 Mark another local as initialized.
3247 (my_png_error, my_error_exit): Mark with NO_RETURN.
3249 * image.c (clear_image_cache): Now static.
3250 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3251 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3252 (x_edge_detection): Remove unnecessary cast that
3253 gcc -Wbad-function-cast diagnoses.
3254 (gif_load): Fix pointer signedness.
3255 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3256 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3258 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3260 Improve quality of tests for time stamp overflow.
3261 For example, without this patch (encode-time 0 0 0 1 1
3262 1152921504606846976) returns the obviously-bogus value (-948597
3263 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3264 reports time overflow. See
3265 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3266 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3267 * editfns.c: Include limits.h and intprops.h.
3268 (TIME_T_MIN, TIME_T_MAX): New macros.
3269 (time_overflow): Move earlier, to before first use.
3270 (hi_time, lo_time): New functions, for an accurate test for
3272 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3273 (Fget_internal_run_time): Don't assume time_t fits in int.
3274 (make_time): Use list2 instead of Fcons twice.
3275 (Fdecode_time): More accurate test for out-of-range times.
3276 (check_tm_member): New function.
3277 (Fencode_time): Use it, to test for out-of-range times.
3278 (lisp_time_argument): Don't rely on undefined left-shift and
3279 right-shift behavior when checking for time stamp overflow.
3281 * editfns.c (time_overflow): New function, refactoring common code.
3282 (Fformat_time_string, Fdecode_time, Fencode_time):
3283 (Fcurrent_time_string): Use it.
3285 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3286 * dired.c (make_time): Move to ...
3287 * editfns.c (make_time): ... here.
3288 * systime.h: Note the move.
3290 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3292 * fringe.c (update_window_fringes): Remove unused variables.
3294 * unexmacosx.c (copy_data_segment): Also copy __got section.
3297 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3299 * termcap.c [MSDOS]: Include "msdos.h".
3300 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3301 Constify `char *' arguments and their references according to
3302 prototypes in tparam.h.
3304 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3306 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3307 Adapt all references accordingly.
3309 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3311 2011-03-11 Tom Tromey <tromey@redhat.com>
3313 * buffer.c (syms_of_buffer): Remove obsolete comment.
3315 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3317 * termhooks.h (encode_terminal_code): Declare prototype.
3319 * msdos.c (encode_terminal_code): Don't declare prototype.
3321 * term.c (encode_terminal_code): Now external again, used by
3322 w32console.c and msdos.c.
3324 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3325 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3327 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3329 Fix some minor problems found by GCC 4.5.2's static checks.
3331 * fringe.c (update_window_fringes): Mark locals as initialized
3333 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3335 * alloc.c (mark_fringe_data): Move decl from here ...
3336 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3337 to check its interface.
3338 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3340 * fontset.c (free_realized_fontset): Now static.
3341 (Fset_fontset_font): Rename local to avoid shadowing.
3342 (fontset_font): Mark local as initialized.
3343 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3345 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3347 * xselect.c (x_disown_buffer_selections): Remove; not used.
3348 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3349 (x_own_selection, Fx_disown_selection_internal): Rename locals
3351 (x_handle_dnd_message): Remove local to avoid shadowing.
3353 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3354 so that the caller can use some name other than gcpro1.
3355 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3356 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3357 (Fx_backspace_delete_keys_p):
3358 Use them to avoid shadowing, and rename vars to avoid shadowing.
3359 (x_decode_color, x_set_name, x_window): Now static.
3360 (Fx_create_frame): Add braces to silence GCC warning.
3361 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3362 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3363 Remove unused locals.
3364 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3365 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3366 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3369 * xterm.h (x_mouse_leave): New decl.
3371 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3372 Remove unused functions.
3373 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3374 (x_calc_absolute_position): Now static.
3375 (XTread_socket): Don't define label "out" unless it's used.
3376 Don't declare local "event" unless it's used.
3377 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3378 unless they are used.
3379 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3380 (x_fatal_error_signal): Remove; not used.
3381 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3382 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3383 (x_error_catcher, x_connection_closed, x_error_handler):
3384 (x_error_quitter, xembed_send_message, x_iconify_frame):
3385 (my_log_handler): Rename locals to avoid shadowing.
3386 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3387 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3389 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3390 Rename or move locals to avoid shadowing.
3391 (tty_defined_color, merge_face_heights): Now static.
3392 (free_realized_faces_for_fontset): Remove; not used.
3393 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3394 does not deduce is never used uninitialized.
3395 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3396 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3398 * terminal.c (store_terminal_param): Now static.
3400 * xmenu.c (menu_highlight_callback): Now static.
3401 (set_frame_menubar): Remove unused local.
3402 (xmenu_show): Rename parameter to avoid shadowing.
3403 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3404 since they might point to immutable storage.
3405 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3406 since it's unused otherwise.
3408 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3409 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3410 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3411 avoids a gcc -Wuninitialized diagnostic.
3412 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3413 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3414 does not deduce are never used uninitialized.
3416 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3418 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3419 * window.c (window_loop, size_window):
3420 (run_window_configuration_change_hook, enlarge_window): Likewise.
3422 * window.c (display_buffer): Now static.
3423 (size_window): Mark variables that gcc -Wuninitialized
3424 does not deduce are never used uninitialized.
3425 * window.h (check_all_windows): New decl, to forestall
3426 gcc -Wmissing-prototypes diagnostic.
3427 * dispextern.h (bidi_dump_cached_states): Likewise.
3429 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3431 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3433 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3434 and to avoid gcc -Wuninitialized warning.
3435 (load_charset_map): Mark variables that gcc -Wuninitialized
3436 does not deduce are never used uninitialized.
3437 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3439 * coding.c (coding_set_source, coding_set_destination):
3440 Use "else { /* comment */ }" rather than "else /* comment */;"
3441 for clarity, and to avoid gcc -Wempty-body warning.
3442 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3443 a block, when the outer 'i' will do.
3444 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3445 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3446 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3447 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3448 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3449 Rename locals to avoid shadowing.
3450 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3451 * coding.c (emacs_mule_char, encode_invocation_designation):
3452 Now static, since they're not used elsewhere.
3453 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3454 (decode_coding_object, encode_coding_object, detect_coding_system):
3455 (decode_coding_emacs_mule): Mark variables that gcc
3456 -Wuninitialized does not deduce are never used uninitialized.
3457 (detect_coding_iso_2022): Initialize a local variable that might
3458 be used uninitialized. Leave a FIXME because it's not clear that
3459 this initialization is needed. (Bug#8211)
3460 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3461 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3462 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3463 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3464 Remove unused macros.
3466 * category.c (hash_get_category_set): Remove unused local var.
3467 (copy_category_table): Now static, since it's not used elsewhere.
3468 * character.c (string_count_byte8): Likewise.
3470 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3471 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3473 * chartab.c (copy_sub_char_table): Now static, since it's not used
3475 (sub_char_table_ref_and_range, char_table_ref_and_range):
3476 Rename locals to avoid shadowing.
3477 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3479 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3480 (BIDI_BOB): Remove unused macro.
3482 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3483 deduce are never used uninitialized.
3484 * term.c (encode_terminal_code): Likewise.
3486 * term.c (encode_terminal_code): Now static. Remove unused local.
3488 * tparam.h: New file.
3489 * term.c, tparam.h: Include it.
3490 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3491 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3492 Move these decls to tparam.h, and make them agree with what
3493 is actually in tparam.c. The previous trick of using incompatible
3494 decls in different modules does not conform to the C standard.
3495 All callers of tparam changed to use tparam's actual API.
3496 * tparam.c (tparam1, tparam, tgoto):
3497 Use const pointers where appropriate.
3499 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3500 * cm.h (struct cm): Likewise.
3501 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3502 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3503 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3504 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3505 (turn_on_face, init_tty): Likewise.
3506 * termchar.h (struct tty_display_info): Likewise.
3508 * term.c (term_mouse_position): Rename local to avoid shadowing.
3510 * alloc.c (mark_ttys): Move decl from here ...
3511 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3513 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3515 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3517 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3519 * search.c (compile_pattern_1): Remove argument regp, unused since
3520 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3521 (compile_pattern): Don't pass it.
3523 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3525 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3526 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3528 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3530 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3532 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3533 gdk_window_get_screen, gdk_window_get_geometry,
3534 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3535 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3536 (xg_get_pixbuf_from_pixmap): New function.
3537 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3538 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3539 Call xg_get_pixbuf_from_pixmap instead of
3540 gdk_pixbuf_get_from_drawable.
3541 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3542 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3543 (xg_check_special_colors): Use GtkStyleContext and its functions
3545 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3546 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3547 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3548 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3549 Call gtk_widget_get_preferred_size.
3550 (xg_frame_resized): gdk_window_get_geometry only takes 5
3552 (xg_win_to_widget, xg_event_is_for_menubar):
3553 Call gdk_x11_window_lookup_for_display.
3554 (xg_set_widget_bg): New function.
3555 (delete_cb): New function.
3556 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3557 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3558 (xg_set_background_color): Call xg_set_widget_bg.
3559 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3560 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3561 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3562 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3564 (update_frame_tool_bar): Call gtk_widget_hide.
3565 (xg_initialize): Use GDK_KEY_g.
3567 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3569 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3571 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3572 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3573 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3575 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3577 * w32xfns.c (select_palette): Check success of RealizePalette against
3578 GDI_ERROR, not zero.
3580 See ChangeLog.11 for earlier changes.
3586 Copyright (C) 2011 Free Software Foundation, Inc.
3588 This file is part of GNU Emacs.
3590 GNU Emacs is free software: you can redistribute it and/or modify
3591 it under the terms of the GNU General Public License as published by
3592 the Free Software Foundation, either version 3 of the License, or
3593 (at your option) any later version.
3595 GNU Emacs is distributed in the hope that it will be useful,
3596 but WITHOUT ANY WARRANTY; without even the implied warranty of
3597 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3598 GNU General Public License for more details.
3600 You should have received a copy of the GNU General Public License
3601 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.